------------------------------------------------------------------------
r60592 | thestig@chromium.org | 2010-09-26 04:35:45 +0200 (Sun, 26 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: Fix problem with zombies and hanging browsers when METHOD_GET_CHILD_WITH_INODE fails.

BUG=none
TEST=fewer zombies.
Review URL: http://codereview.chromium.org/3416023
------------------------------------------------------------------------
r60586 | tfarina@chromium.org | 2010-09-25 21:19:08 +0200 (Sat, 25 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html

DOMUI: Add prefs ui for enabling/disabling background mode.

BUG=53337
TEST=out/Debug/chrome --enable-tabbed-options, go to Under the hood, see
the Chromium/Google Chrome Web Apps, try to enable or disable the pref (it should works).
Try to click in the Learn more link, it should go to the help page.

Review URL: http://codereview.chromium.org/3441016
------------------------------------------------------------------------
r60584 | thakis@chromium.org | 2010-09-25 20:02:54 +0200 (Sat, 25 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   D /trunk/src/chrome/browser/sync/profile_sync_service_harness.cc
   D /trunk/src/chrome/browser/sync/profile_sync_service_harness.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/multiple_client_live_bookmarks_sync_test.cc
   A /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc (from /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc:60555)
   A /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h (from /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h:60555)
   M /trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_test.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_preferences_sync_test.cc

Revert 60556 (broke chrome, at least on linux) - Refactor, rename and relocate ProfileSyncServiceTestHarness.

ProfileSyncServiceTestHarness needs to support a specialization that can use a WaitableEvent instead of starting and stopping the UI Message loop. Required for automation provider support for sync.

The class also needs to live in chrome/browser, instead of chrome/test, and could do with a rename.

BUG=56460
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3492005

TBR=rsimha@chromium.org
------------------------------------------------------------------------
r60583 | arv@chromium.org | 2010-09-25 19:48:36 +0200 (Sat, 25 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui.js

Bookmarks manager: Remove a console.log

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3461027
------------------------------------------------------------------------
r60582 | arv@chromium.org | 2010-09-25 19:44:52 +0200 (Sat, 25 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Fix canceling of add page

BUG=39407
TEST=Open bookmark manager
     Right click the list
     Add page
     Press esc, enter or outside the inputs
     The new item should be removed

Review URL: http://codereview.chromium.org/3432029
------------------------------------------------------------------------
r60580 | tfarina@chromium.org | 2010-09-25 16:56:31 +0200 (Sat, 25 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/labs.cc

Fix a typo introduced in r60578.

OS_WINDOWS doesn't exists, it should be OS_WIN.

TBR=thakis@chromium.org
BUG=55676
TEST=None

Review URL: http://codereview.chromium.org/3505002
------------------------------------------------------------------------
r60579 | tfarina@chromium.org | 2010-09-25 16:25:32 +0200 (Sat, 25 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/labs.cc

Fix an empty string to fix r60578.

TBR=thakis@chromium.org
BUG=55676
TEST=None

Review URL: http://codereview.chromium.org/3503006
------------------------------------------------------------------------
r60578 | tfarina@chromium.org | 2010-09-25 16:08:56 +0200 (Sat, 25 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.h
   M /trunk/src/chrome/browser/labs.cc

Add remoting to about:labs.

BUG=55676
TEST=Go to about:labs and make sure you see a section for Remoting.

Review URL: http://codereview.chromium.org/3422010
------------------------------------------------------------------------
r60577 | ananta@chromium.org | 2010-09-25 16:08:51 +0200 (Sat, 25 Sep 2010) | 20 lines
Changed paths:
   A /trunk/src/chrome/browser/plugin_download_helper.cc
   A /trunk/src/chrome/browser/plugin_download_helper.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/plugin/plugin_test.cpp

Relanding this patch with the compile fix for Visual studio 2005. The compiler gets
confused between the two Delegate classes URLRequest::Delegate and the
PluginDownloadHelper::Delegate class. Renaming the latter seems to work

Fix a regression introduced in the chrome plugin installer on Windows in revision 54316
which was to remove usages of GetTempDir. However the change failed to take into account
that the file name which is used to perform the download eventually is shell executed on
windows. In this case the download was performed on a temporary file which causes ShellExecute
to put up a confirmation dialog asking the user to select the application for opening the file.

Fix is to rename the temp file path to the desired file path on success.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=56746

Bug=56746
Test=Covered by plugin installer plugin test.

TBR=jam

Review URL: http://codereview.chromium.org/3453025
------------------------------------------------------------------------
r60575 | ananta@chromium.org | 2010-09-25 10:51:27 +0200 (Sat, 25 Sep 2010) | 17 lines
Changed paths:
   D /trunk/src/chrome/browser/plugin_download_helper.cc
   D /trunk/src/chrome/browser/plugin_download_helper.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/plugin/plugin_test.cpp

Revert 60574 - Fix a regression introduced in the chrome plugin installer on Windows in revision 54316
which was to remove usages of GetTempDir. However the change failed to take into account
that the file name which is used to perform the download eventually is shell executed on
windows. In this case the download was performed on a temporary file which causes ShellExecute
to put up a confirmation dialog asking the user to select the application for opening the file.

Fix is to rename the temp file path to the desired file path on success.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=56746

Bug=56746
Test=Covered by plugin installer plugin test.

Review URL: http://codereview.chromium.org/3432028

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/3461029
------------------------------------------------------------------------
r60574 | ananta@chromium.org | 2010-09-25 10:41:26 +0200 (Sat, 25 Sep 2010) | 14 lines
Changed paths:
   A /trunk/src/chrome/browser/plugin_download_helper.cc
   A /trunk/src/chrome/browser/plugin_download_helper.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/plugin/plugin_test.cpp

Fix a regression introduced in the chrome plugin installer on Windows in revision 54316
which was to remove usages of GetTempDir. However the change failed to take into account
that the file name which is used to perform the download eventually is shell executed on
windows. In this case the download was performed on a temporary file which causes ShellExecute
to put up a confirmation dialog asking the user to select the application for opening the file.

Fix is to rename the temp file path to the desired file path on success.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=56746

Bug=56746
Test=Covered by plugin installer plugin test.

Review URL: http://codereview.chromium.org/3432028
------------------------------------------------------------------------
r60572 | ctguil@chromium.org | 2010-09-25 09:42:47 +0200 (Sat, 25 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Call InfoBar::ViewHierarchyChangedViewHierarchyChanged after the ConfirmInfoBar is initialized.

BUG=37360
TEST=JAWS screen reader will read all items in the confirm infobar.

Review URL: http://codereview.chromium.org/3441032
------------------------------------------------------------------------
r60571 | ctguil@chromium.org | 2010-09-25 09:19:27 +0200 (Sat, 25 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Make the close_button the last child view of an infobar.

BUG=37360
TEST=JAWS read the infobar's text before it reads the close button.

Review URL: http://codereview.chromium.org/3431027
------------------------------------------------------------------------
r60569 | ctguil@chromium.org | 2010-09-25 08:41:14 +0200 (Sat, 25 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.h
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Support additional webkit accessibility notifications and states. 

1. Update WebAccessibility::ConvertState to function similarly to WebCore's AccessibleBase::get_accState. 
2. Use WebKit's load complete notification to send the renderer's tree to the browser. 
We enable accessibility on the renderer now instead of requesting a tree. 
3. Use WebKit's focused ui element notification to send renderer focus events to the browser. 

BUG=13291
BUG=38106
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationActiveDescendantChanged 
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationFocusChanged 

Review URL: http://codereview.chromium.org/3380017
------------------------------------------------------------------------
r60568 | zelidrag@chromium.org | 2010-09-25 08:17:04 +0200 (Sat, 25 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/mobile_setup_ui.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/register_page_ui.cc (from /trunk/src/chrome/browser/dom_ui/register_page_ui.cc:60460)
   A /trunk/src/chrome/browser/chromeos/dom_ui/register_page_ui.h (from /trunk/src/chrome/browser/dom_ui/register_page_ui.h:60460)
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   D /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   D /trunk/src/chrome/browser/dom_ui/register_page_ui.h
   A /trunk/src/chrome/browser/resources/connection_manager.js
   A /trunk/src/chrome/browser/resources/mobile_setup.html
   A /trunk/src/chrome/browser/resources/mobile_setup.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   A /trunk/src/chrome/test/data/chromeos
   A /trunk/src/chrome/test/data/chromeos/mobile_activation.html

Skeleton for mobile device activation UI.

BUG=chromium-os:6868
TEST=none

Review URL: http://codereview.chromium.org/3448018
------------------------------------------------------------------------
r60567 | thakis@chromium.org | 2010-09-25 07:35:49 +0200 (Sat, 25 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

clang: Remove unused function.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3402034
------------------------------------------------------------------------
r60566 | davidben@chromium.org | 2010-09-25 06:34:34 +0200 (Sat, 25 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/ssl_client_certificate_selector.mm

Do not save identity preferences on OS X

Chrome largely does not use them and interprets them differently from
Safari.

R=wtc
BUG=41669
TEST=logging in with client certificate does not add to Keychain

Review URL: http://codereview.chromium.org/3400007
------------------------------------------------------------------------
r60556 | rsimha@chromium.org | 2010-09-25 04:25:07 +0200 (Sat, 25 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_harness.cc (from /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc:60554)
   A /trunk/src/chrome/browser/sync/profile_sync_service_harness.h (from /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h:60554)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/multiple_client_live_bookmarks_sync_test.cc
   D /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   D /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_test.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_preferences_sync_test.cc

Refactor, rename and relocate ProfileSyncServiceTestHarness.

ProfileSyncServiceTestHarness needs to support a specialization that can use a WaitableEvent instead of starting and stopping the UI Message loop. Required for automation provider support for sync.

The class also needs to live in chrome/browser, instead of chrome/test, and could do with a rename.

BUG=56460
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3492005
------------------------------------------------------------------------
r60541 | mihaip@chromium.org | 2010-09-25 00:42:35 +0200 (Sat, 25 Sep 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

Add parentheses around bit-wise operations to quieten warning.
------------------------------------------------------------------------
r60530 | isherman@chromium.org | 2010-09-24 23:56:30 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.mm

Mac: Ignore omnibox selection changes that come from programmatic events

BUG=56149,56720
TEST=start typing a url, arrow around in the autocomplete popup menu -- the results should not change.

Review URL: http://codereview.chromium.org/3397019
------------------------------------------------------------------------
r60529 | tfarina@chromium.org | 2010-09-24 23:55:26 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Change the menu item 'Options' to 'Settings' on the wrench menu.

BUG=56152
TEST=out/Debug/chrome --enable-tabbed-options, go to wrench menu, you should see
a 'Settings' menu item. Also without the switch you should still see the
'Options' menu item.

Review URL: http://codereview.chromium.org/3398026
------------------------------------------------------------------------
r60528 | dhg@chromium.org | 2010-09-24 23:53:11 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.h
   A /trunk/src/chrome/browser/resources/options/chromeos_internet_detail.html
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_network_element.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options_page.css
   M /trunk/src/chrome/browser/resources/options.html

Adding ability to log into networks, and view network configs, all from the DOM_UI

BUG=chromium-os:6241
TEST=connect to networks

Review URL: http://codereview.chromium.org/3388006
------------------------------------------------------------------------
r60527 | mihaip@chromium.org | 2010-09-24 23:52:51 +0200 (Fri, 24 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix flickering when calling push/replaceState (or changing the location hash)
in a tight loop by delaying the UI updates when beginning a load by 50
milliseconds (and cancelling altogether if the load finishes before then).

BUG=50298
TEST=Links on http://bodytag.org/rollstate/
Review URL: http://codereview.chromium.org/3300013
------------------------------------------------------------------------
r60518 | asargent@chromium.org | 2010-09-24 22:55:44 +0200 (Fri, 24 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_apitest.cc

Small cleanup - remove 2 unnecessary includes.

BUG=None
TEST=It compiles

TBR=mpcomplete@chromium.org


Review URL: http://codereview.chromium.org/3473018
------------------------------------------------------------------------
r60513 | jianli@chromium.org | 2010-09-24 22:36:46 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/common/webblobregistry_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webblobregistry_impl.cc

Fix the problem that BlobDispatcherHost is not hooked up in WorkerProcessHost.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3472010
------------------------------------------------------------------------
r60511 | akalin@chromium.org | 2010-09-24 22:03:46 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Fixed bug where the "Keep everything synced" preference wasn't being honored.

BUG=55026
TEST=Manual

Review URL: http://codereview.chromium.org/3433017
------------------------------------------------------------------------
r60510 | avi@chromium.org | 2010-09-24 21:51:04 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc

Comment typo fix.

BUG=none
TEST=look at file and not get annoyed

Review URL: http://codereview.chromium.org/3391025
------------------------------------------------------------------------
r60504 | evan@chromium.org | 2010-09-24 21:16:04 +0200 (Fri, 24 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sanity_uitest.cc

ui_tests: disable EarlyReturnTest.

It always times out.  It is only passing on the bots because of a bug in the UI
test framework that doesn't detect the timeout.

BUG=45115
TEST=ui_tests are 30 seconds faster

Review URL: http://codereview.chromium.org/3433022
------------------------------------------------------------------------
r60498 | erikkay@chromium.org | 2010-09-24 20:35:00 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/webstore_app/manifest.json

added /webstore to app.urls

BUG=56795
TEST=verify that /webstore URLs can install apps

Review URL: http://codereview.chromium.org/3503004
------------------------------------------------------------------------
r60486 | evan@chromium.org | 2010-09-24 19:33:36 +0200 (Fri, 24 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

linux: zygote should suicide when the browser channel closes.

We attempt to do this when recvmsg() returns 0, indicating EOF.
But man 7 unix also says we can get ECONNRESET, so accept that too.

TEST=run Chrome such that it exits quickly, e.g.
  ./out/Debug/chrome --try-chrome-again=10001
it should not print any zygote error messages.

Review URL: http://codereview.chromium.org/3387017
------------------------------------------------------------------------
r60483 | vandebo@chromium.org | 2010-09-24 19:22:26 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/gfx/native_theme_win.cc
   M /trunk/src/gfx/skia_util.h
   M /trunk/src/skia/ext/vector_platform_device_linux.cc
   M /trunk/src/skia/ext/vector_platform_device_win.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/plugin_object.cc

Remove use of Skia's safeUnref() in favor of SkSafeUnref(...)

safeUnref() technically has undefined behavior on a null pointer.

TEST=green bots
BUG=none

Review URL: http://codereview.chromium.org/3475007
------------------------------------------------------------------------
r60481 | sky@chromium.org | 2010-09-24 19:11:58 +0200 (Fri, 24 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h

Fixes bug where showing an auth dialog during instant would trigger
the page to be prematurely committed.

BUG=56462
TEST=see bug

Review URL: http://codereview.chromium.org/3461020
------------------------------------------------------------------------
r60480 | wtc@chromium.org | 2010-09-24 19:01:40 +0200 (Fri, 24 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc

Change NOTREACHED() to LOG(ERROR) when we cannot initialize
the web database.  This is not a programming error.  This
can happen if we run an old version of Chrome with a new
version of user data directory.

R=sky
BUG=none
TEST=N/A
Review URL: http://codereview.chromium.org/3418028
------------------------------------------------------------------------
r60479 | sky@chromium.org | 2010-09-24 19:00:13 +0200 (Fri, 24 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.h
   M /trunk/src/chrome/browser/tab_contents/match_preview_delegate.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

Adds support for sending script when the user accepts instant
results. Also tweaks the delegate interface to be a bit more sensical.

BUG=54833
TEST=see bug

Review URL: http://codereview.chromium.org/3440025
------------------------------------------------------------------------
r60478 | dilmah@chromium.org | 2010-09-24 18:49:39 +0200 (Fri, 24 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/app/resources/menu_droparrow_sharp.png
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h

Visually polish language selector for new user pod.

BUG=http://crosbug.com/5749, http://crosbug.com/6568
TEST=Manual
Review URL: http://codereview.chromium.org/3473014
------------------------------------------------------------------------
r60477 | lzheng@chromium.org | 2010-09-24 18:49:32 +0200 (Fri, 24 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

Mark TestDigestAuth FLAKY on all platforms.

TEST=none
BUG=56670
Review URL: http://codereview.chromium.org/3381023
------------------------------------------------------------------------
r60476 | skerner@chromium.org | 2010-09-24 18:33:03 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc

Make app panels use popup type.  Nuke refocus code and tests.

BUG=55943
TEST=Manual.

Review URL: http://codereview.chromium.org/3418027
------------------------------------------------------------------------
r60475 | dhg@chromium.org | 2010-09-24 18:24:27 +0200 (Fri, 24 Sep 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/browser/resources/mediaplayer.html
   M /trunk/src/chrome/browser/resources/playlist.html

Adding copy to the filebrowser.  Also fixes a crash bug when the user tries to access a download that no longer exists.
Review URL: http://codereview.chromium.org/2844040
------------------------------------------------------------------------
r60474 | dtseng@chromium.org | 2010-09-24 18:21:20 +0200 (Fri, 24 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accessibility_event_router_views.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc

Reland r60342.

TBR=dmazzoni.
Review URL: http://codereview.chromium.org/3444021
------------------------------------------------------------------------
r60471 | skerner@chromium.org | 2010-09-24 17:39:39 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Remove logging for issue 35198.

Remove switch --issue35198-logging .

BUG=56664
TEST=Install an extension on all platforms.

Review URL: http://codereview.chromium.org/3427019
------------------------------------------------------------------------
r60470 | bauerb@chromium.org | 2010-09-24 17:32:42 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/cookies_view_handler.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/resources/options/cookies_view.html
   M /trunk/src/chrome/browser/resources/options/cookies_view.js
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   A /trunk/src/chrome/browser/views/indexed_db_info_view.cc
   A /trunk/src/chrome/browser/views/indexed_db_info_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Add IndexedDB to cookie tree.

XIB changes: Add another view with IndexedDB details to CookieDetailsView.xib.

BUG=56248
TEST=CookiesTreeModelTest.*:CookiesDetailsTest.*:CookiesViewTest.*:

Review URL: http://codereview.chromium.org/3429020
------------------------------------------------------------------------
r60468 | allanwoj@chromium.org | 2010-09-24 17:02:25 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/core_location_provider_mac.mm
   M /trunk/src/chrome/browser/geolocation/win7_location_api_win.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Unify experimental location features under one flag.

Changed the CoreLocation and Win7 Location Api enable flags to the same one as gateway data provider so that all experimental geolocation features can be enabled/disabled at once.

BUG=None
TEST=Experimental location features work under run time flag --experimental-location-features

Review URL: http://codereview.chromium.org/3419021
------------------------------------------------------------------------
r60466 | dilmah@chromium.org | 2010-09-24 16:37:21 +0200 (Fri, 24 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc

Hide "Change proxy settings link" during connection in progress.
Replace chrome://options with chrome://settings because it was changed recently.

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/3397028
------------------------------------------------------------------------
r60463 | allanwoj@chromium.org | 2010-09-24 16:17:34 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   A /trunk/src/chrome/browser/geolocation/gateway_data_provider_win.cc
   A /trunk/src/chrome/browser/geolocation/gateway_data_provider_win.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Windows Gateway Data Provider.

Provides the MAC address of any routers connected via Ethernet. Also added in a command line flag to enable it.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3368014
------------------------------------------------------------------------
r60461 | shess@chromium.org | 2010-09-24 15:11:06 +0200 (Fri, 24 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc

Finally flip safe-browsing to SafeBrowsingStoreFile.

With this, everyone will use SafeBrowsingDatabaseNew with
SafeBrowsingStoreFile backing.  The database file should be smaller
and faster.

BUG=28647
TEST=Monitor crash server and histograms.

Review URL: http://codereview.chromium.org/3473016
------------------------------------------------------------------------
r60460 | andreip@chromium.org | 2010-09-24 15:03:26 +0200 (Fri, 24 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.h
   M /trunk/src/chrome/test/data/indexeddb/common.js
   A /trunk/src/chrome/test/data/indexeddb/transaction_get_test.html
   A /trunk/src/chrome/test/data/indexeddb/transaction_get_test.js

Revert "Revert 60457 - Adds IDBFactory::didCompleteEventsForTransaction plumbing"

This reverts commit b1e231ca824b2fb9a96bffc04f26eae336ff6ed5.

Also disable the transaction_get.html test, added in this CL.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3466018
------------------------------------------------------------------------
r60459 | phajdan.jr@chromium.org | 2010-09-24 14:16:17 +0200 (Fri, 24 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.h
   M /trunk/src/chrome/test/data/indexeddb/common.js
   D /trunk/src/chrome/test/data/indexeddb/transaction_get_test.html
   D /trunk/src/chrome/test/data/indexeddb/transaction_get_test.js

Revert 60457 - Adds IDBFactory::didCompleteEventsForTransaction plumbing

(depends on https://bugs.webkit.org/show_bug.cgi?id=44700)

TEST=IndexedDBBrowserTest.TransactionGetTest

This takes over http://codereview.chromium.org/3310022/show

Review URL: http://codereview.chromium.org/3394007

TBR=andreip@chromium.org
Review URL: http://codereview.chromium.org/3405031
------------------------------------------------------------------------
r60457 | andreip@chromium.org | 2010-09-24 13:23:45 +0200 (Fri, 24 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.h
   M /trunk/src/chrome/test/data/indexeddb/common.js
   A /trunk/src/chrome/test/data/indexeddb/transaction_get_test.html
   A /trunk/src/chrome/test/data/indexeddb/transaction_get_test.js

Adds IDBFactory::didCompleteEventsForTransaction plumbing

(depends on https://bugs.webkit.org/show_bug.cgi?id=44700)

TEST=IndexedDBBrowserTest.TransactionGetTest

This takes over http://codereview.chromium.org/3310022/show

Review URL: http://codereview.chromium.org/3394007
------------------------------------------------------------------------
r60449 | dpolukhin@chromium.org | 2010-09-24 11:31:15 +0200 (Fri, 24 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Revert incognito option for external_extensions.json file

Original codereviw: http://codereview.chromium.org/3360020

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6516
TEST=n/a
TBR=skerner@chromium.org

Review URL: http://codereview.chromium.org/3415022
------------------------------------------------------------------------
r60448 | satorux@chromium.org | 2010-09-24 11:21:56 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Fix test failures in LanguageMenuButtonTest.GetTextForIndicatorTest.

Update test expectations broken by r60432.

BUG=chromium-os:6561
TEST=out/Release/unit_tests --gtest_filter='*GetTextForIndicatorTest'

Review URL: http://codereview.chromium.org/3390025
------------------------------------------------------------------------
r60443 | jknotten@chromium.org | 2010-09-24 10:57:13 +0200 (Fri, 24 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.cc
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Improve flaky ui_test AutomationProxyVisibleTest.AutocompleteMatchesTest

The omnibox requires that it is focused before text input to it will
kick off the autocompletion providers. We add code
(edit->WaitForFocus()) to the test to wait for the focus to be obtained
before setting the omnibox’s text input and proceeding with the rest of
the test.

BUG=19876
TEST=Existing

Review URL: http://codereview.chromium.org/3348021
------------------------------------------------------------------------
r60442 | phajdan.jr@chromium.org | 2010-09-24 10:54:20 +0200 (Fri, 24 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Revert 60035 - Make sure the application icon is up to date
when destroying DownloadManager.

This causes a crash on Windows.

BUG=54823, 56722
TEST=see bug

Review URL: http://codereview.chromium.org/3397017

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3416024
------------------------------------------------------------------------
r60440 | altimofeev@chromium.org | 2010-09-24 10:39:36 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h

Adds accelerators for BWSI(guest) mode.

BUG=chromium-os:6028
TEST=In login screen press ALT+B, - BWSI session starts.

Review URL: http://codereview.chromium.org/3443015
------------------------------------------------------------------------
r60439 | phajdan.jr@chromium.org | 2010-09-24 10:30:14 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix leak of a DownloadItem in SavePackage::Init.

BUG=56495, 54149
TEST=valgrind, see bugs

Review URL: http://codereview.chromium.org/3498002
------------------------------------------------------------------------
r60437 | isherman@chromium.org | 2010-09-24 10:06:04 +0200 (Fri, 24 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc

Experimental change to try to reduce the flakiness of BrowserKeyEventsTest.AccessKeys

The theory is that the QuitTask might be nestling into the message loop before the task for the result of the key press.  For example, in bug 55713, the theory is that we quit out of the message loop after the key press is sent, but before the location bar is focused.

If so, this patch should serve as a band-aid to (nearly) eliminate the test flakiness.  At that point we can try to figure out a more bulletproof fix; for now, I'd like to make sure we're right about the underlying cause of the flakiness.

BUG=55713
TEST=interactive_ui_tests --gtest_filter=BrowserKeyEventsTest.AccessKeys should not flakily fail

Review URL: http://codereview.chromium.org/3454025
------------------------------------------------------------------------
r60436 | satorux@chromium.org | 2010-09-24 10:03:53 +0200 (Fri, 24 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Fix a crash at browser shutdown time.

Instead of stopping input processes from the destructor of InputMehotdLibrary,
we'll observe NotificationType::APP_EXITING to do it.

Here's the crash senario: When the browser shuts down,
1. AtExitManager deletes CrosLibrary, a singleton object.
2. CrosLibrary deletes InputMethodLibrary
3. InputMethodLibrary calls StopInputMethodProcesses().
4. StopInputMethodProcesses() relies on the CrosLibrary instance to alive.
5. Which is not the case here, so it crashes.

BUG=chromium-os:6995
TEST=confirmed that StopInputMethodProcesses() is called on APP_EXITINIG.

Review URL: http://codereview.chromium.org/3497006
------------------------------------------------------------------------
r60434 | phajdan.jr@chromium.org | 2010-09-24 09:42:56 +0200 (Fri, 24 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Revert 60362 - Downloads: Don't create the default download directory on startup.

The change has been committed without "LGTM" from all reviewers.

BUG=56021
TEST=see bug.
Review URL: http://codereview.chromium.org/3386024

TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/3462010
------------------------------------------------------------------------
r60432 | satorux@chromium.org | 2010-09-24 08:31:58 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Add indicators for Hangul and Quick input methods.

TEST=manually on the netbook
BUG=chromium-os:6561

Review URL: http://codereview.chromium.org/3395012
------------------------------------------------------------------------
r60430 | thakis@chromium.org | 2010-09-24 08:14:00 +0200 (Fri, 24 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h

Revert 60421 - Revert 60373, trying to track down a perf regression (see bug 56752)- Add about:gpuhang

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3447023

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3398027

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3398028
------------------------------------------------------------------------
r60425 | thakis@chromium.org | 2010-09-24 07:19:13 +0200 (Fri, 24 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/net/blob_url_request_job_factory.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   D /trunk/src/webkit/blob/deletable_file_reference.cc
   D /trunk/src/webkit/blob/deletable_file_reference.h
   D /trunk/src/webkit/blob/deletable_file_reference_unittest.cc
   M /trunk/src/webkit/blob/webkit_blob.gypi
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Revert 60378 (trying to track down http://crbug.com/56752 )- Flesh out URLLoader's download_to_file function.
* tie the lifetime of the resulting temp file to the lifetime of the URLLoader
  (the plan is to later extend the lifetime of the temp file to support xhr.responseBlob)
* make it work in test_shell
* make it work for sync requests
* added OnDataDownloaded messages to report progress

A related BlobURL loading change.
* grab a reference to the blob early on to ensure it's still there when the 'job' is finally started.

TEST=manual and deletable_file_reference_unittest.cc
BUG=52486

Review URL: http://codereview.chromium.org/3165062

TBR=michaeln@chromium.org
Review URL: http://codereview.chromium.org/3455022
------------------------------------------------------------------------
r60422 | tfarina@chromium.org | 2010-09-24 06:52:11 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/text_elider.cc
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/string_split.cc
   M /trunk/src/base/string_split.h
   M /trunk/src/base/string_split_unittest.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/version.cc
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/version_loader.cc
   M /trunk/src/chrome/browser/dom_ui/cookies_view_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/download/download_prefs.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/language_order_table_model.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/common/zip.cc
   M /trunk/src/chrome/default_plugin/plugin_database_handler.cc
   M /trunk/src/chrome/installer/util/compat_checks.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/version.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/chrome_process_util_mac.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/webdriver/dispatch.h
   M /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/metrics_service.cc
   M /trunk/src/net/base/host_mapping_rules.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_ls.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_mlsd.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_netware.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_vms.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_vms_unittest.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_windows.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_stream_factory.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/net/websockets/websocket_job_unittest.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_lib_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

base: Finish moving the SplitString functions from string_util.h to string_split.h

BUG=None
TEST=trybos

Review URL: http://codereview.chromium.org/3447008
------------------------------------------------------------------------
r60421 | thakis@chromium.org | 2010-09-24 06:46:58 +0200 (Fri, 24 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h

Revert 60373, trying to track down a perf regression (see bug 56752)- Add about:gpuhang

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3447023

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3398027
------------------------------------------------------------------------
r60396 | ericu@google.com | 2010-09-24 03:06:00 +0200 (Fri, 24 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/browser_file_system_callback_dispatcher.cc
   M /trunk/src/chrome/browser/file_system/browser_file_system_callback_dispatcher.h
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/webkit/fileapi/file_system_operation.cc
   M /trunk/src/webkit/fileapi/file_system_operation.h
   M /trunk/src/webkit/tools/test_shell/simple_file_system.cc

This is the IPC and bits of the browser backend for FileWriter.  The rest of
it's too tied together to include a small amount; this is the most-significant
chunk that I could put up without making too big a changelist.

The backend isn't complete, but you can see where it's going from here.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3440021
------------------------------------------------------------------------
r60391 | aa@chromium.org | 2010-09-24 02:49:36 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js

Fix bug where install animation would replay if something on the
same page was uninstalled.

BUG=56454
TEST=Install one app, then another. Uninstall the first one.
Second one's install animation should not replay.

Review URL: http://codereview.chromium.org/3396021
------------------------------------------------------------------------
r60380 | mirandac@chromium.org | 2010-09-24 01:27:53 +0200 (Fri, 24 Sep 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/web_resource/web_resource_service_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add a unit test for web resource logo unpacking.

BUG=none
TEST=new unit test should pass.
Review URL: http://codereview.chromium.org/3473013
------------------------------------------------------------------------
r60378 | michaeln@chromium.org | 2010-09-24 01:16:45 +0200 (Fri, 24 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/net/blob_url_request_job_factory.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   A /trunk/src/webkit/blob/deletable_file_reference.cc
   A /trunk/src/webkit/blob/deletable_file_reference.h
   A /trunk/src/webkit/blob/deletable_file_reference_unittest.cc
   M /trunk/src/webkit/blob/webkit_blob.gypi
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Flesh out URLLoader's download_to_file function.
* tie the lifetime of the resulting temp file to the lifetime of the URLLoader
  (the plan is to later extend the lifetime of the temp file to support xhr.responseBlob)
* make it work in test_shell
* make it work for sync requests
* added OnDataDownloaded messages to report progress

A related BlobURL loading change.
* grab a reference to the blob early on to ensure it's still there when the 'job' is finally started.

TEST=manual and deletable_file_reference_unittest.cc
BUG=52486

Review URL: http://codereview.chromium.org/3165062
------------------------------------------------------------------------
r60373 | thakis@chromium.org | 2010-09-24 01:06:49 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h

Add about:gpuhang

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3447023
------------------------------------------------------------------------
r60371 | aa@chromium.org | 2010-09-24 00:55:00 +0200 (Fri, 24 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_icon_set.cc
   M /trunk/src/chrome/common/extensions/extension_icon_set.h
   M /trunk/src/chrome/common/extensions/extension_icon_set_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc

Allow extensions to request the icons of hosted apps.

BUG=53495
TEST=

Review URL: http://codereview.chromium.org/3409004
------------------------------------------------------------------------
r60370 | twiz@google.com | 2010-09-24 00:45:25 +0200 (Fri, 24 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/renderer/render_view.cc

Simple fix correcting the assignment of page_id to RenderView instances.

The logic in NavigationController::ClassifyNavigation assumes that all new pages will have an id LARGER than the maximal id that is locally cached in the SiteInstance of the active RenderViewHost.  

Because page ids are doled out by incrementing a static variable that resides in the render process - see RenderView::next_page_id_ -  resetting this counter while the render process is still in use will confuse the browser, and trigger the assert logic in NavigationController::ClassifyNavigation.  Newly created RenderView objects in this render process will send page ids  less than the value stored in SiteInstance::max_page_id during navigation operations.

This problem was manifested during the interaction of multiple instances of a chrome-extension residing in ActiveX controls.  Consider navigating a Chrome-Frame instance to an extension page.  Now navigate a second Chrome-Frame instance to another extension page within the same extension.  If a top-level link navigation is initiated on the second CF instance, then the extension will be torn down, but the old logic would have reset the next_page_id_ counter.  If a subsequent CF was navigated to a page within the same extension, it would be backed by the same extension process, yet it would be assigned an incorrect page id, as described above.

BUG=55138
TEST=none

Review URL: http://codereview.chromium.org/3442007
------------------------------------------------------------------------
r60369 | erg@google.com | 2010-09-24 00:43:53 +0200 (Fri, 24 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/app/table_model.cc
   M /trunk/src/app/table_model.h
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/base/base.gypi
   A /trunk/src/base/stats_counters.cc
   M /trunk/src/base/stats_counters.h
   M /trunk/src/base/watchdog.cc
   M /trunk/src/base/watchdog.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/table_model_array_controller.mm
   M /trunk/src/chrome/browser/default_encoding_combo_model.cc
   M /trunk/src/chrome/browser/default_encoding_combo_model.h
   M /trunk/src/chrome/browser/device_orientation/provider.cc
   M /trunk/src/chrome/browser/device_orientation/provider.h
   M /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   M /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.h
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/language_order_table_model.h
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/connect_interceptor.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/ipc/ipc_channel_proxy.cc
   M /trunk/src/ipc/ipc_channel_proxy.h
   M /trunk/src/media/base/factory.h
   A /trunk/src/media/base/filters.cc
   M /trunk/src/media/base/filters.h
   M /trunk/src/media/filters/ffmpeg_demuxer.cc
   M /trunk/src/media/media.gyp
   M /trunk/src/media/tools/player_x11/x11_video_renderer.cc
   M /trunk/src/views/controls/table/native_table_gtk.cc
   M /trunk/src/views/controls/table/table_view2.cc
   M /trunk/src/webkit/glue/media/buffered_data_source_unittest.cc

FBTF: Move virtual methods to implementation files.

Remove logging.h and other headers where possible.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3461019
------------------------------------------------------------------------
r60362 | thestig@chromium.org | 2010-09-24 00:14:05 +0200 (Fri, 24 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Downloads: Don't create the default download directory on startup.

BUG=56021
TEST=see bug.
Review URL: http://codereview.chromium.org/3386024
------------------------------------------------------------------------
r60359 | mpcomplete@chromium.org | 2010-09-23 23:55:52 +0200 (Thu, 23 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/incognito_tab.html

Move the extensions warning on the incognito NTP into the grey box.

This fixes an issue where the text would be unreadable with certain themes
installed.

BUG=45971
TEST=see bug for repro steps

Review URL: http://codereview.chromium.org/3497002
------------------------------------------------------------------------
r60358 | oshima@chromium.org | 2010-09-23 23:47:15 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc

Wait for all tasks to finish before exitting the test.

BUG=chromium-os:6899
TEST=ScreenLockerTest.TestFullscreenExit will not crash on trybots.

Review URL: http://codereview.chromium.org/3432024
------------------------------------------------------------------------
r60354 | stuartmorgan@chromium.org | 2010-09-23 23:42:33 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

ifdef out tests that don't apply to the Mac

The reason these tests were failing on the Mac is that they test something that the Mac explicitly doesn't support: opening a new window in the existing browser process by re-running from the command line. This ifdefs out the tests that don't apply to the Mac, and the helper method that they are built on so that new tests using it won't accidentally be run on the Mac.

BUG=45108
TEST=N/A

Review URL: http://codereview.chromium.org/3394018
------------------------------------------------------------------------
r60351 | isherman@chromium.org | 2010-09-23 23:40:37 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc

Reduce console DLOG(INFO) spam in history_backend.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3449019
------------------------------------------------------------------------
r60350 | mpcomplete@chromium.org | 2010-09-23 23:31:06 +0200 (Thu, 23 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Trying to reland r59889, this time as a multi-stage patch.

Fix regression introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=57788

Add a delegate interface so that chromium have more fine-grained control over
whether a V8 extension is injected into a script context. This is the
chromium-side change of webkit bug
https://bugs.webkit.org/show_bug.cgi?id=45721

BUG=37290
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/3464005
------------------------------------------------------------------------
r60348 | maruel@chromium.org | 2010-09-23 23:00:39 +0200 (Thu, 23 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc

Revert "Set focus to a ConfirmInfoBar.  This serves to alerts screen reader users ..."

This reverts commit 60342.

TBR=dtseng
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3472008
------------------------------------------------------------------------
r60345 | xiyuan@chromium.org | 2010-09-23 22:47:22 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc

Fix a regression that users checkboxes are enabled for non-owner.

Also block StoreProperty op for non-owner.

BUG=none.
TEST=Verify the users options are disabled for non-owner.

Review URL: http://codereview.chromium.org/3381020
------------------------------------------------------------------------
r60342 | dtseng@chromium.org | 2010-09-23 22:37:10 +0200 (Thu, 23 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc

Set focus to a ConfirmInfoBar.  This serves to alerts screen reader users that the confirmation has appeared and alleviates the need to hunt for these controls.
BUG=37360
TEST=Confirm that focus lands correctly on the "save" button when logging into a site and offer to save passwords is enabled.
Review URL: http://codereview.chromium.org/3405026
------------------------------------------------------------------------
r60338 | stevenjb@google.com | 2010-09-23 22:30:32 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/cros/syslogs_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/syslogs_library.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_info_ui.cc
   M /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc

chromium-os:6108 - about:system should use FILE thread to get system info.
Replaced SyslogsLibrary::GetSyslogs with asynchronous RequestSyslogs.
Modified BugReportHandler and AboutSource in browser_about_handler.cc appropriately.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6108
TEST=Test chrome:system, and bug reporter. Both should always be responsive. Test multiple instances of each, closing tabs quickly, and sending a bug quickly. Veryify results of bug report. Confirm that about:system no longer shows anything.

Review URL: http://codereview.chromium.org/3295024
------------------------------------------------------------------------
r60334 | asargent@chromium.org | 2010-09-23 22:19:56 +0200 (Thu, 23 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.h
   M /trunk/src/chrome/browser/extensions/extension_management_api_browsertest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.management.html
   A /trunk/src/chrome/test/data/extensions/management/launch_app
   A /trunk/src/chrome/test/data/extensions/management/launch_app/background.html
   A /trunk/src/chrome/test/data/extensions/management/launch_app/manifest.json
   A /trunk/src/chrome/test/data/extensions/management/launch_app/test.js
   A /trunk/src/chrome/test/data/extensions/management/packaged_app
   A /trunk/src/chrome/test/data/extensions/management/packaged_app/main.html
   A /trunk/src/chrome/test/data/extensions/management/packaged_app/manifest.json
   A /trunk/src/chrome/test/data/extensions/management/simple_extension
   A /trunk/src/chrome/test/data/extensions/management/simple_extension/manifest.json

Add a launchApp method to extension management API.

This makes it possible for new tab replacement extensions to recreate the same
app launch experience as the built-in NTP (pinned tabs, launch containers,
etc.)

Also add the extension version to data we report about extensions via
the management API.

BUG=56325,55474
TEST=An extension using chrome.experimental.management.launchApp(<id>) should
work to launch an app the same way that app gets launched from the built-in
new tab page.



Review URL: http://codereview.chromium.org/3381019
------------------------------------------------------------------------
r60325 | evan@chromium.org | 2010-09-23 21:34:12 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   A /trunk/src/chrome/browser/task_manager
   A /trunk/src/chrome/browser/task_manager/task_manager.cc (from /trunk/src/chrome/browser/task_manager.cc:60323)
   A /trunk/src/chrome/browser/task_manager/task_manager.h (from /trunk/src/chrome/browser/task_manager.h:60323)
   A /trunk/src/chrome/browser/task_manager/task_manager_browsertest.cc (from /trunk/src/chrome/browser/task_manager_browsertest.cc:60323)
   A /trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc (from /trunk/src/chrome/browser/task_manager_resource_providers.cc:60323)
   A /trunk/src/chrome/browser/task_manager/task_manager_resource_providers.h (from /trunk/src/chrome/browser/task_manager_resource_providers.h:60323)
   A /trunk/src/chrome/browser/task_manager/task_manager_unittest.cc (from /trunk/src/chrome/browser/task_manager_unittest.cc:60323)
   D /trunk/src/chrome/browser/task_manager.cc
   D /trunk/src/chrome/browser/task_manager.h
   D /trunk/src/chrome/browser/task_manager_browsertest.cc
   D /trunk/src/chrome/browser/task_manager_resource_providers.cc
   D /trunk/src/chrome/browser/task_manager_resource_providers.h
   D /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Move task manager code into a subdirectory.

BUG=50548
TEST=compiles

Review URL: http://codereview.chromium.org/3454028
------------------------------------------------------------------------
r60321 | oshima@chromium.org | 2010-09-23 21:00:16 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Exit fullscreen when creating new tab by search key.

BUG=chromium-os:6591
TEST=manual: exter full screen, hit search key (left win key on desktop). it should exit full screen and show new tab page.

Review URL: http://codereview.chromium.org/3483007
------------------------------------------------------------------------
r60319 | xiyuan@chromium.org | 2010-09-23 20:42:01 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Fix a typo that crashes oobe.

This breaks owning process as well.

BUG=chromium-os:6854
TEST=Verify fix for chromeium-os:6854 and make sure you see the account image screen in oobe.

Review URL: http://codereview.chromium.org/3393021
------------------------------------------------------------------------
r60318 | thestig@chromium.org | 2010-09-23 20:39:42 +0200 (Thu, 23 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Don't initialize the download manager when trying to shut down.

BUG=56598
TEST=none
Review URL: http://codereview.chromium.org/3419016
------------------------------------------------------------------------
r60315 | tim@chromium.org | 2010-09-23 20:32:47 +0200 (Thu, 23 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

sync: Introduce support for split transaction apply/commit changes. Change_processors can now perform I/O heavy work in a commitchanges phase during which the syncable::WriteTransaction lock is not held, thereby not janking the UI. AutofillChangeProcessor updated to make use of this.

Added ServerChangeRace test to ProfileSyncServiceAutofillTest in order test newfound jank-lessness. Simulates a server initiated change with modified UnlockAndLog which puts thread to sleep before completion so a syncapi initiated change can happen. Then, a second "server" change posts before first has completed. Test succeeds if all three entries are successfully created.

BUG=53601
TEST=unit_tests --gtest_filter="*ServerChangeRace*"

Original patch by zea@chromium.org
Original review: http://codereview.chromium.org/3326015/show

Review URL: http://codereview.chromium.org/3480002
------------------------------------------------------------------------
r60312 | evan@chromium.org | 2010-09-23 20:16:29 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

dom_storage_uitest: clean up code to use file_util::IsDirectoryEmpty.

(I'm trying to eliminate a function it was previously
calling.  This new code is clearer anyway.)

BUG=46246

Review URL: http://codereview.chromium.org/3451015
------------------------------------------------------------------------
r60310 | cbentzel@chromium.org | 2010-09-23 20:02:23 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

Change bug reference in comments for flaky LoginPromptTest

BUG=55380,56670
TEST=None

Review URL: http://codereview.chromium.org/3483006
------------------------------------------------------------------------
r60309 | rvargas@google.com | 2010-09-23 19:55:29 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/view_http_cache_job_factory.cc

View_cache: Make sure that the ViewHttpCacheJob is valid
while we are getting the data from the backend.

BUG=54829
TEST=none


Review URL: http://codereview.chromium.org/3437020
------------------------------------------------------------------------
r60306 | aa@chromium.org | 2010-09-23 19:48:02 +0200 (Thu, 23 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/ntp/apps.js

NTP: Don't show any sections or layout until we receive mv
and apps data. This improves performance and avoids
flickeryness.

BUG=56278
TEST=Install some apps and refresh the ntp over and over.
Should not see flickering as mv section, then apps load.

Review URL: http://codereview.chromium.org/3474006
------------------------------------------------------------------------
r60301 | csilv@chromium.org | 2010-09-23 19:05:56 +0200 (Thu, 23 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc

Tweaks to OptionUI tests to reduce flaky behavior.  These changes are in-line w/ BookmarksUI tests that seem to behave better. Will re-evaluate later to determine if we can safely remove the flaky tag.

BUG=48521
TEST=Review behavior on flakiness dashboard after some time.
Review URL: http://codereview.chromium.org/3429019
------------------------------------------------------------------------
r60300 | rickcam@chromium.org | 2010-09-23 18:56:37 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/shell_integration.h

BUG=43382
TEST=none

Addressing some code review comments that were missed in earlier dcommit on issue 3441021.

Specifically, this change splits DisableLaunchOnStartupTask out from EnableLaunchOnStartupTask and eliminates the should_enable_ data member.  In addition, it changes the logic in the calling routine to introduce the conditional at that point rather than passing through the should_launch value.

Review URL: http://codereview.chromium.org/3441021
------------------------------------------------------------------------
r60294 | andreip@chromium.org | 2010-09-23 17:56:13 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc

Remove call to WebIDBFactory::abortPendingTransactions ahead of WK roll to r68143.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3470009
------------------------------------------------------------------------
r60291 | mirandac@chromium.org | 2010-09-23 17:29:47 +0200 (Thu, 23 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Allow web resource server to set custom logo display by start and end date.

BUG=56388
TEST=none
Review URL: http://codereview.chromium.org/3382014
------------------------------------------------------------------------
r60289 | phajdan.jr@chromium.org | 2010-09-23 16:46:51 +0200 (Thu, 23 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

GTTF: Remove the flaky mark from SSLUITest.TestDisplaysInsecureContentLoadedFromJS

The last test failure occurred on September 14th.

TBR=jcivelli

BUG=52557
TEST=browser_tests

Review URL: http://codereview.chromium.org/3395013
------------------------------------------------------------------------
r60288 | phajdan.jr@chromium.org | 2010-09-23 16:38:58 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/policy/policy_templates.grd
   M /trunk/src/chrome/app/policy/policy_templates.json
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h

Implement policy for enabling/disabling JavaScript.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3395011
------------------------------------------------------------------------
r60285 | altimofeev@chromium.org | 2010-09-23 16:26:19 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Uses 'Exit guest mode' instead of 'Sing Out'.

BUG=chromium-os:5942
TEST=Enter guest mode, click on menu, notice 'Exit guest mode' label at the bottom.

Review URL: http://codereview.chromium.org/3429017
------------------------------------------------------------------------
r60284 | satish@chromium.org | 2010-09-23 15:40:29 +0200 (Thu, 23 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc

Fix build break due to comparison between signed/unsigned integers.

TBR=maruel
BUG=none
TEST=tree turns green.
------------------------------------------------------------------------
r60283 | jorlow@chromium.org | 2010-09-23 15:34:02 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h

Revert my revert of 60275 + don't do static casting + disable the tests for now.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3435022
------------------------------------------------------------------------
r60282 | satish@chromium.org | 2010-09-23 15:22:19 +0200 (Thu, 23 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/theme/speech_input_mic_mask.png
   D /trunk/src/chrome/app/theme/speech_input_processing.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/cocoa/speech_input_window_controller.mm
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   M /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_views.cc

Earlier we used to show a static image in this state, instead we now show the animation.

The images for each step of the animation are stored horizontally next to each other in a sprite image
and during the animation we just draw the same bitmap with the x origin moving around from one step
to another and wrapping around.

BUG=53598
TEST=manual, start speech recognition, speak something and wait for the animation to show up on screen.

Review URL: http://codereview.chromium.org/3417012
------------------------------------------------------------------------
r60281 | jorlow@chromium.org | 2010-09-23 14:24:53 +0200 (Thu, 23 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h

Revert 60275.

TEST=none
BUG=none
------------------------------------------------------------------------
r60279 | phajdan.jr@chromium.org | 2010-09-23 14:19:43 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_prefs.cc

Do not create download directory on startup, except on ChromeOS.

BUG=56021
TEST=see bug

Review URL: http://codereview.chromium.org/3471009
------------------------------------------------------------------------
r60278 | phajdan.jr@chromium.org | 2010-09-23 14:18:34 +0200 (Thu, 23 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc

Make it possible to run unit_tests under parallel_launcher.py for speed.

This replaces usage of DIR_TEMP with ScopedTempDir, which is unique
for each test. Otherwise two tests running in parallel could refer
to the same directory and fail.

BUG=54098
TEST=unit_tests

Review URL: http://codereview.chromium.org/3387013
------------------------------------------------------------------------
r60277 | pam@chromium.org | 2010-09-23 13:22:20 +0200 (Thu, 23 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/prefs/pref_value_store.h

Improve comment for PrefValueStore::HasPrefPath().

BUG=52719
TEST=none needed, comment-only change
Review URL: http://codereview.chromium.org/3397020
------------------------------------------------------------------------
r60275 | jorlow@chromium.org | 2010-09-23 12:47:00 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h

Add the transaction id plumbing to IndexedDB.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3478003
------------------------------------------------------------------------
r60274 | andreip@chromium.org | 2010-09-23 12:30:15 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc

Add plumbing for IDBTransaction::abort()

BUG=
TEST=

Review URL: http://codereview.chromium.org/3441019
------------------------------------------------------------------------
r60270 | jochen@chromium.org | 2010-09-23 10:53:26 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/browsing_data_indexed_db_helper.cc
   A /trunk/src/chrome/browser/browsing_data_indexed_db_helper.h
   A /trunk/src/chrome/browser/browsing_data_indexed_db_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_browsertest.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   A /trunk/src/chrome/browser/mock_browsing_data_indexed_db_helper.cc
   A /trunk/src/chrome/browser/mock_browsing_data_indexed_db_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/thread_test_helper.h

Hook up indexed databases to content settings.

Step 2: add a browsing data helper for indexed databases.

BUG=56248
TEST=CannedBrowsingDataIndexedDBHelperTest.*,BrowsingDataIndexedDBHelperTest.*

Review URL: http://codereview.chromium.org/3468007
------------------------------------------------------------------------
r60265 | oshima@chromium.org | 2010-09-23 08:46:35 +0200 (Thu, 23 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Enable html background for login screen.
Fix background of unlock view to match login screen.

BUG=chromium-os:5763
TEST=none

Review URL: http://codereview.chromium.org/3380021
------------------------------------------------------------------------
r60264 | oshima@chromium.org | 2010-09-23 08:43:00 +0200 (Thu, 23 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Add more logs to diagnose crash issue in chromeos bvt test.

TBR=cmasone@chromium.org
BUG=chromium-os:6802
TEST=none

Review URL: http://codereview.chromium.org/3423020
------------------------------------------------------------------------
r60260 | ctguil@chromium.org | 2010-09-23 07:50:42 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_win.cc

Expose the level of headings to NVDA.

BUG=47493
TEST=NVDA reads out heading levels.

Review URL: http://codereview.chromium.org/3402025
------------------------------------------------------------------------
r60259 | ctguil@chromium.org | 2010-09-23 07:45:13 +0200 (Thu, 23 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc
   M /trunk/src/webkit/glue/webaccessibility.cc

Store lower case tag names within web accessibility.

This is similar to the behavior of firefox.

BUG=none
TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.*

Review URL: http://codereview.chromium.org/3435019
------------------------------------------------------------------------
r60257 | shess@chromium.org | 2010-09-23 06:07:46 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc

Make SafeBrowsingStoreFile the default store for developers.

Get some early coverage by opting developers into the experiment.

BUG=28647
TEST=Developers don't complain.

Review URL: http://codereview.chromium.org/3389025
------------------------------------------------------------------------
r60256 | sky@chromium.org | 2010-09-23 05:33:05 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc

Fixes bug in match preview getting layed out one pixel too high.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3462007
------------------------------------------------------------------------
r60255 | sky@chromium.org | 2010-09-23 05:29:11 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Makes right arrow in omnibox commit suggest results.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3493002
------------------------------------------------------------------------
r60254 | sky@chromium.org | 2010-09-23 05:28:46 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc

Fixes some fragile code in BrowserViewLayout.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3443018
------------------------------------------------------------------------
r60250 | atwilson@chromium.org | 2010-09-23 03:49:33 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc

Disable ExtensionApiTest.WebSocket on Mac

BUG=56596
TEST=none

Review URL: http://codereview.chromium.org/3498001
------------------------------------------------------------------------
r60240 | alekseys@chromium.org | 2010-09-23 02:15:05 +0200 (Thu, 23 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

[Mac] 1) Status bubble respects page contents view bounds, not just its vertical size; 2) Bubble expansion preserves bubble's current position; 3) Bubble won't expand if it's going to cover current mouse position in the expanded state.

BUG=54882,56434
TEST=All usual status bubble tests (mouse evasion, fullscreen mode, devtools and download panel interaction)
plus the same with sidebar open.
Status bubble should behave as expected plus it should not cover sidebar content in mouse or screen bottom evading mode.

Review URL: http://codereview.chromium.org/3347022
------------------------------------------------------------------------
r60230 | johnnyg@chromium.org | 2010-09-23 01:04:40 +0200 (Thu, 23 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/signin_manager.cc
   M /trunk/src/chrome/browser/sync/signin_manager.h
   M /trunk/src/chrome/browser/sync/signin_manager_unittest.cc
   M /trunk/src/chrome/common/net/gaia/gaia_auth_consumer.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h

Look up the canonical email address before reporting client login success.

BUG=55133
TEST=login without @gmail.com at the end

Review URL: http://codereview.chromium.org/3451012
------------------------------------------------------------------------
r60228 | aa@chromium.org | 2010-09-23 00:50:02 +0200 (Thu, 23 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Remove some more log spam.

TBR=evan@chromium.org
------------------------------------------------------------------------
r60222 | shess@chromium.org | 2010-09-22 23:06:12 +0200 (Wed, 22 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h

[Mac] Don't allow new I/O after profile dir is gone.

Mac tests have lots of failures in ImportantFileWriter.  It is because
the scoped temp dir associated with the testing profile is being
deleted before the background task on the FILE thread scheduled by
ImportantFileWriter is run.  Other places in the code simply don't
have a FILE thread, so the task is dropped.  This gets rid of those
threads before deleting the testing profile in ~BrowserTestHelper().

BUG=none
TEST=fewer nuisance log lines in unit_tests.

Review URL: http://codereview.chromium.org/3440012
------------------------------------------------------------------------
r60221 | evan@chromium.org | 2010-09-22 23:05:08 +0200 (Wed, 22 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

Remove a sleep from SandboxedExtensionUnpackerTest.WithCatalogsSuccess.

Previously the test: (1) wrote a file, (2) slept, (3) wrote a file,
(4) checked that the file time changed.

I modified it so step 2 instead just sets the file mod time into the
past.

BUG=46246

Review URL: http://codereview.chromium.org/3464012
------------------------------------------------------------------------
r60216 | aa@chromium.org | 2010-09-22 22:44:19 +0200 (Wed, 22 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/ntp/apps.js

Fix a bug where we would show both the apps and thumb
sections if both sections were shown under the old version
of the ntp.

Also clean up some old cruft.

BUG=55610
TEST=Upgrade Chrome from an older version to a version with
this change with at least one app installed. Should see only
apps section. Do it with no apps installed, should see only
MV section.

Review URL: http://codereview.chromium.org/3393013
------------------------------------------------------------------------
r60210 | nick@chromium.org | 2010-09-22 21:59:58 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/protocol/encryption.proto
   M /trunk/src/chrome/browser/sync/protocol/session_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync.proto

Refresh sync.proto.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3387010
------------------------------------------------------------------------
r60208 | erg@google.com | 2010-09-22 21:42:00 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_extension_tracker.cc
   M /trunk/src/chrome/browser/automation/automation_extension_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_json.cc
   M /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.cc
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   A /trunk/src/chrome/browser/automation/automation_tab_tracker.cc
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   A /trunk/src/chrome/browser/automation/automation_window_tracker.cc
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome_frame/test/net/test_automation_resource_message_filter.h
   M /trunk/src/chrome_frame/urlmon_url_request_private.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/dnssec_chain_verifier.cc
   M /trunk/src/net/base/dnssec_chain_verifier.h
   M /trunk/src/net/base/dnssec_keyset.cc
   M /trunk/src/net/base/dnssec_keyset.h
   M /trunk/src/net/base/ev_root_ca_metadata.cc
   M /trunk/src/net/base/ev_root_ca_metadata.h
   M /trunk/src/net/base/host_mapping_rules.cc
   M /trunk/src/net/base/host_mapping_rules.h
   M /trunk/src/net/base/io_buffer.cc
   M /trunk/src/net/base/io_buffer.h
   M /trunk/src/net/base/pem_tokenizer.cc
   M /trunk/src/net/base/pem_tokenizer.h
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   A /trunk/src/net/base/ssl_config_service_defaults.cc
   M /trunk/src/net/base/ssl_config_service_defaults.h
   M /trunk/src/net/base/transport_security_state.cc
   M /trunk/src/net/base/transport_security_state.h
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/base/upload_data_stream.h
   M /trunk/src/net/base/x509_cert_types.cc
   M /trunk/src/net/base/x509_cert_types.h
   M /trunk/src/net/http/http_stream_parser.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/https_prober.cc
   M /trunk/src/net/url_request/https_prober.h
   M /trunk/src/net/url_request/url_request_data_job.cc
   M /trunk/src/net/url_request/url_request_data_job.h

FBTF: Move a bunch of code to the headers and remove includes.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3412016
------------------------------------------------------------------------
r60207 | estade@chromium.org | 2010-09-22 21:37:49 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/update_recommended_dialog.cc
   M /trunk/src/chrome/browser/upgrade_detector.cc

Change the frequency of update checks depending on the installed channel of chrome.

BUG=50278
TEST=none

Review URL: http://codereview.chromium.org/3455009
------------------------------------------------------------------------
r60206 | jamesr@chromium.org | 2010-09-22 21:35:43 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Force accelerated 2d canvas off for chrome ui

BUG=56455
TEST=start chrome with --enable-accelerated-2d-canvas, open bookmark manager, verify there is no GPU process

Review URL: http://codereview.chromium.org/3413027
------------------------------------------------------------------------
r60205 | sanjeevr@chromium.org | 2010-09-22 21:22:20 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added code in the browser process to display a Cloud Print token expired desktop notification. Also added a command-line switch to show this UI.

BUG=None
TEST=None for now.

Review URL: http://codereview.chromium.org/3436019
------------------------------------------------------------------------
r60201 | avi@chromium.org | 2010-09-22 20:34:15 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h

Typo fix.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3455014
------------------------------------------------------------------------
r60195 | xiyuan@chromium.org | 2010-09-22 19:48:32 +0200 (Wed, 22 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc

Implement users options handling in login screen.

- Use BrowserProcess's local_state as a cache to users settings;
- Update login code to use the cached users settings per chromium-os:6789

BUG=chromium-os:6789
TEST=Verify fix for chromium-os:6789.

Review URL: http://codereview.chromium.org/3413021
------------------------------------------------------------------------
r60191 | sky@chromium.org | 2010-09-22 19:28:27 +0200 (Wed, 22 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc

Fixes bug where match preview wouldn't get hidden if match preview was
showing and you pressed control-w.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3453016
------------------------------------------------------------------------
r60190 | cmasone@google.com | 2010-09-22 19:04:18 +0200 (Wed, 22 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h
   A /trunk/src/chrome/browser/chromeos/login/auth_attempt_state.cc
   A /trunk/src/chrome/browser/chromeos/login/auth_attempt_state.h
   A /trunk/src/chrome/browser/chromeos/login/auth_attempt_state_resolver.cc
   A /trunk/src/chrome/browser/chromeos/login/auth_attempt_state_resolver.h
   A /trunk/src/chrome/browser/chromeos/login/cryptohome_op.cc
   A /trunk/src/chrome/browser/chromeos/login/cryptohome_op.h
   A /trunk/src/chrome/browser/chromeos/login/cryptohome_op_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   A /trunk/src/chrome/browser/chromeos/login/mock_auth_attempt_state_resolver.h
   A /trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.cc
   A /trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.h
   A /trunk/src/chrome/browser/chromeos/login/online_attempt.cc
   A /trunk/src/chrome/browser/chromeos/login/online_attempt.h
   A /trunk/src/chrome/browser/chromeos/login/online_attempt_unittest.cc
   A /trunk/src/chrome/browser/chromeos/login/test_attempt_state.cc
   A /trunk/src/chrome/browser/chromeos/login/test_attempt_state.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Chrome OS] Infrastucture for doing offline/online login simultaneously

These are meant to wrap and replace large chunks of code in GoogleAuthenticator,
once I rewrite that code to do offline and online login at the same time.
That's why there's some code that's still in GoogleAuthenticator that's
refactored into some of these classes.

Essentially, one creates an AuthAttemptState object, which will only allow
its mutable contents to be read/written on the IO thread.  Then, you pass it
to an OnlineAttempt which, when done, stores results in the AuthAttemptState.
You can do the same thing with the various CryptohomeOp classes.  They call out
over DBus to asynchronously do stuff with the user's cryptohome and then,
when the callbacks come in, these object post a call over to the IO thread to
update the contents of the AuthAttemptState instance they're holding on to.

BUG=chromium-os:4929
TEST=unit testss

Review URL: http://codereview.chromium.org/3407008
------------------------------------------------------------------------
r60189 | ctguil@chromium.org | 2010-09-22 19:04:16 +0200 (Wed, 22 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Mark AccessibilityWinBrowserTest.ContainsRendererAccessibilityTree as DISABLED.

This test doesn't pass on the interactive_ui_tests builder, but always passes locally.

BUG=54220
TEST=none
TBR=dmazzoni@chromium.org

------------------------------------------------------------------------
r60184 | xiyuan@chromium.org | 2010-09-22 18:40:49 +0200 (Wed, 22 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/webkit/glue/cpp_variant.cc

Fix a problem that text prefs are not hooked up with CrosSettings.

And bump up CppVariant::ToStringVector limit from 100 to 60000 so that we can pass more arguments through chrome.send.

BUG=chromium-os:6827
TEST=Verify proxy setting values entered are sent to CrosSettingsProviderProxy.

Review URL: http://codereview.chromium.org/3386009
------------------------------------------------------------------------
r60181 | jorlow@chromium.org | 2010-09-22 17:51:11 +0200 (Wed, 22 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc

Fix some bugs that only show up when running layout tests manually
without --single-process.  (Yes, this means we need to make our
test coverage better in the near future.)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3487003
------------------------------------------------------------------------
r60176 | glotov@chromium.org | 2010-09-22 17:16:13 +0200 (Wed, 22 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/volume_bubble.cc

Volume bubble horizontally centered.
BUG=chromium-os:5176
TEST=Volume bubble should appear horizontally centered.

Review URL: http://codereview.chromium.org/3488002
------------------------------------------------------------------------
r60175 | mmenke@chromium.org | 2010-09-22 16:47:28 +0200 (Wed, 22 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/serviceprovidersview.js
   M /trunk/src/chrome/browser/resources/net_internals/util.js

Adds Winsock service providers to log dumps, and converts a couple of their numeric values to strings.

Also adds the OS version from the user-agent string to the top of the log dump.

TEST=manual
BUG=53474
BUG=54302

Review URL: http://codereview.chromium.org/3416015
------------------------------------------------------------------------
r60174 | caseq@google.com | 2010-09-22 16:41:49 +0200 (Wed, 22 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc

Revert 60122 - WebKit roll: 67957:68016

BUG=none
TEST=none
TBR=atwilson

Review URL: http://codereview.chromium.org/3437014

------------------------------------------------------------------------
r60172 | caseq@google.com | 2010-09-22 15:56:27 +0200 (Wed, 22 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc

    WebKit roll: 67957:68016
    Marked IndexedDBBrowserTest.{CursorTest,IndexTest,KeyPathTest} as FAIL under linux.

    BUG=none
    TEST=none
    TBR=atwilson,jorlow

    Review URL: http://codereview.chromium.org/3437014

------------------------------------------------------------------------
r60171 | cbentzel@chromium.org | 2010-09-22 15:51:19 +0200 (Wed, 22 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc

Save passwords for HTTP+FTP authentication.

Rather than modifying the PasswordForm to have a username_element and password_element, change the logic in PasswordFormManager::HasValidPasswordForm to only care about empty username_element and password_element for HTML-form based PasswordForms.

BUG=5236,49894
TEST=unit_tests --gtest_filter="*TestValidForms*". Manual: Start Chrome with fresh profile, go to a Digest authenticating proxy or server and enter a username+password. After page loads successfully, click "save password" in the infobar. Restart chrome with the same profile, and make sure username+password dialog prompt is filled in.

 
Review URL: http://codereview.chromium.org/3419011
------------------------------------------------------------------------
r60170 | danno@chromium.org | 2010-09-22 15:47:59 +0200 (Wed, 22 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.h
   M /trunk/src/chrome/browser/host_zoom_map_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/prefs/pref_change_registrar.cc
   M /trunk/src/chrome/browser/prefs/pref_change_registrar.h
   M /trunk/src/chrome/browser/prefs/pref_change_registrar_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_service.h
   M /trunk/src/chrome/browser/prefs/pref_service_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Revert 60169 - Use PrefChangeRegistrar everywhere

BUG=54955
TEST=PrefChangeRegistrarTest.*

Review URL: http://codereview.chromium.org/3304015

TBR=danno@chromium.org
------------------------------------------------------------------------
r60169 | danno@chromium.org | 2010-09-22 14:43:14 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.h
   M /trunk/src/chrome/browser/host_zoom_map_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/prefs/pref_change_registrar.cc
   M /trunk/src/chrome/browser/prefs/pref_change_registrar.h
   M /trunk/src/chrome/browser/prefs/pref_change_registrar_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_service.h
   M /trunk/src/chrome/browser/prefs/pref_service_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Use PrefChangeRegistrar everywhere

BUG=54955
TEST=PrefChangeRegistrarTest.*

Review URL: http://codereview.chromium.org/3304015
------------------------------------------------------------------------
r60167 | altimofeev@chromium.org | 2010-09-22 13:54:13 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Disables "Bookmark all tabs" item in the tab contex menu.

BUG=chromium-os:6028
TEST=Go BWSI session, open at least 2 tabs, notice item "Bookmark all tabs" is disabled.

Review URL: http://codereview.chromium.org/3440008
------------------------------------------------------------------------
r60162 | dilmah@chromium.org | 2010-09-22 11:40:24 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/menu_droparrow_sharp.png (from /trunk/src/app/resources/menu_droparrow.png:60046)
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc

Default IDR_MENU_DROPARROW is unsuitable for us because it is too opaque.
Added IDR_MENU_DROPARROW_SHARP with more transparent background.

BUG=http://crosbug.com/6568
TEST=Manual
Review URL: http://codereview.chromium.org/3479002
------------------------------------------------------------------------
r60161 | finnur@chromium.org | 2010-09-22 11:37:21 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/switch_utils.cc
   A /trunk/src/chrome/common/switch_utils.h
   A /trunk/src/chrome/common/switch_utils_unittest.cc

Remove one-time flags when restarting after update.

BUG=53407
TEST=SwitchUtilsTest.AddRemoveSwitches

Review URL: http://codereview.chromium.org/3307024
------------------------------------------------------------------------
r60153 | sky@chromium.org | 2010-09-22 05:32:47 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.h
   M /trunk/src/chrome/browser/tab_contents/match_preview_delegate.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/contents_container.cc
   M /trunk/src/chrome/browser/views/frame/contents_container.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Makes match preview send the dimensions of the omnibox to the page.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3417011
------------------------------------------------------------------------
r60152 | dumi@chromium.org | 2010-09-22 05:29:14 +0200 (Wed, 22 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/base/platform_file.h
   A /trunk/src/chrome/browser/file_system/browser_file_system_callback_dispatcher.cc
   A /trunk/src/chrome/browser/file_system/browser_file_system_callback_dispatcher.h
   D /trunk/src/chrome/browser/file_system/chrome_file_system_operation.cc
   D /trunk/src/chrome/browser/file_system/chrome_file_system_operation.h
   D /trunk/src/chrome/browser/file_system/chrome_file_system_operation_unittest.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.h
   M /trunk/src/chrome/common/file_system/webfilesystem_impl.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   A /trunk/src/webkit/fileapi/file_system_callback_dispatcher.h
   M /trunk/src/webkit/fileapi/file_system_operation.cc
   M /trunk/src/webkit/fileapi/file_system_operation.h
   D /trunk/src/webkit/fileapi/file_system_operation_client.h
   A /trunk/src/webkit/fileapi/file_system_operation_unittest.cc
   M /trunk/src/webkit/fileapi/webkit_fileapi.gypi
   M /trunk/src/webkit/tools/test_shell/simple_file_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_file_system.h
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Refactor some file_system classes to use chromium types instead of
WebKit API types.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3406008
------------------------------------------------------------------------
r60151 | thestig@chromium.org | 2010-09-22 05:04:21 +0200 (Wed, 22 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Disable ExtensionApiTest.FLAKY_Tabs on CrOS, it's crashing.

BUG=56479
TEST=browser_tests no longer hangs with a zombie process.
Review URL: http://codereview.chromium.org/3470004
------------------------------------------------------------------------
r60149 | nick@chromium.org | 2010-09-22 04:55:32 +0200 (Wed, 22 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Fix bug "Autofill: A large number of unnecessary sync updates
generated when no syncable action was performed".

BUG=54461,56305
TEST=bug repro steps

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60083

Review URL: http://codereview.chromium.org/3426007
------------------------------------------------------------------------
r60141 | csilv@chromium.org | 2010-09-22 03:15:43 +0200 (Wed, 22 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options.html

dom-ui settings: Add icon for settings tab.

BUG=56153
TEST=Verify that the dom-ui settings tab displays the proper favicon.
Review URL: http://codereview.chromium.org/3444012
------------------------------------------------------------------------
r60140 | mark@chromium.org | 2010-09-22 03:11:41 +0200 (Wed, 22 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database.cc

Fix numeric typo. The page size needs to be a power of 2 between 512 and 8192,
inclusive. This was 4096 before r26022 but it was broken in that revision
despite the comment just above.

BUG=45108
TEST=none

Review URL: http://codereview.chromium.org/2220007
------------------------------------------------------------------------
r60139 | dhollowa@chromium.org | 2010-09-22 03:09:02 +0200 (Wed, 22 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/test/live_sync/live_autofill_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_test.cc

AutoFill schema changes break AutoFill syncing

AutoFill sync relies on the presence of a valid profile label.  This change sets all profile labels prior to saving to the database.

BUG=56305
TEST=PersonalDataManager.*, manual test of creating a new profile, then checking the "Web Data" sqlite database to see that the profile label was set correctly.

Review URL: http://codereview.chromium.org/3471004
------------------------------------------------------------------------
r60135 | tfarina@chromium.org | 2010-09-22 02:33:30 +0200 (Wed, 22 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

DOMUI: Make Settings page available at chrome://settings.

BUG=56152
TEST=out/Debug/chrome --enable-tabbed-options. Navigate to the Settings page,
it should works as before.

Review URL: http://codereview.chromium.org/3461010
------------------------------------------------------------------------
r60133 | aa@chromium.org | 2010-09-22 02:15:28 +0200 (Wed, 22 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js

Remove some unnecessary style recalc.

BUG=56278

Review URL: http://codereview.chromium.org/3393015
------------------------------------------------------------------------
r60131 | thakis@chromium.org | 2010-09-22 02:09:28 +0200 (Wed, 22 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.mm
   M /trunk/src/chrome/browser/cocoa/authorization_util.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/gpu/command_buffer/client/fenced_allocator.h
   M /trunk/src/gpu/command_buffer/client/gles2_implementation.cc
   M /trunk/src/ipc/ipc_channel_posix.cc

Mac: clang build

Fixes the last few warnings / errors necessary to build chrome/mac with clang.

See http://code.google.com/p/chromium/wiki/Clang

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2762014
------------------------------------------------------------------------
r60128 | shess@chromium.org | 2010-09-22 01:46:53 +0200 (Wed, 22 Sep 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc

Short-circuit safe-browsing updates once corruption is detected.

The corruption handler posts a task to the current message loop to
delete the database after the current task has completed.  The older
code re-created the database and allowed the transaction to continue,
the newer code did not, causing a crash.  [The database was deleted
first, so on next launch it would not crash again.]

This changes the new code to short-circuit storage of further chunks
once corruption is detected, until the next update (which will
re-create the database as needed).

Adding the tests exposed some code paths which weren't quite right.
Pulled the lock out of ClearUpdateCaches() because ResetDatabase()
calls it with a lock.  The corruption handler can delete open
databases.  Added sanity-check code to SafeBrowsingStoreFile so that
it doesn't allocate insane vectors.

BUG=55606
TEST=crash in 55606 stops happening, tests green.

Review URL: http://codereview.chromium.org/3420015
------------------------------------------------------------------------
r60124 | tfarina@chromium.org | 2010-09-22 01:18:30 +0200 (Wed, 22 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc

DOMUI: Convert the Options page title to 'Settings'

BUG=56151
TEST=out/Debug/chrome --enable-tabbed-options, open the tabbed options, notice
the page title read 'Settings' not 'Chromium/Google Chrome Options.

Review URL: http://codereview.chromium.org/3418021
------------------------------------------------------------------------
r60123 | scherkus@chromium.org | 2010-09-22 01:17:17 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/resources/options/chromeos_labs.html
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Enable and disable Chat Manager component extension based on labs preference setting.

BUG=56429
TEST=unit_tests --gtest_filter=ExtensionsServiceTest.*

Review URL: http://codereview.chromium.org/3120029
------------------------------------------------------------------------
r60120 | ctguil@chromium.org | 2010-09-22 00:58:29 +0200 (Wed, 22 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc
   M /trunk/src/webkit/glue/webaccessibility.cc

Set name of document accessibility nodes to document title. 

BUG=36169
TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationActiveDescendantChanged

Review URL: http://codereview.chromium.org/3448016
------------------------------------------------------------------------
r60119 | erikkay@chromium.org | 2010-09-22 00:58:14 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

use larger icon if available

BUG=56301
TEST=go to an offline app page with a 128px icon defined

Review URL: http://codereview.chromium.org/3471002
------------------------------------------------------------------------
r60117 | willchan@chromium.org | 2010-09-22 00:44:04 +0200 (Wed, 22 Sep 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/net/http/http_basic_stream.cc
   M /trunk/src/net/http/http_basic_stream.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_proxy_client_socket.cc
   M /trunk/src/net/http/http_proxy_client_socket.h
   M /trunk/src/net/http/http_stream.h
   D /trunk/src/net/http/http_stream_handle.cc
   D /trunk/src/net/http/http_stream_handle.h
   M /trunk/src/net/http/http_stream_request.cc
   M /trunk/src/net/http/http_stream_request.h
   M /trunk/src/net/http/stream_factory.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc

Eliminate HttpStreamHandle.  The name confused me.

HttpStreamHandle was a combination of an HttpStream and a
scoped_ptr<ClientSocketHandle>.  This let it manage the transport socket if
so desired.  I think that the HttpStream should be in charge of managing this.
* HttpBasicStream should always release it to the pool when done, but perhaps
  disconnect it first.
* HttpPipelinedStream (or whatever we name it) should know not to disconnect
  the transport socket or whatever.  It should return it to the pipeline stream
  manager.
* SPDY subtypes of HttpStream do not manage the transport socket.  They let the
  SpdySession handle it.
Since the ownership pattern varies based on the HttpStream subtype, I think
letting a HttpStreamHandle class perhaps control it is confusing.  It's better
for the subtype to know what it's supposed to do.

There was only one hangup here, the HttpProxyClientSocket, since it might need
to Disconnect() and then re-Connect() the transport socket.  It was using an
HttpBasicStream, which, with my change, would own the transport socket handle.
I fixed this by making the HttpProxyClientSocket create an HttpStreamParser
instead, which does not own the transport socket handle.

Review URL: http://codereview.chromium.org/3133029
------------------------------------------------------------------------
r60116 | tim@chromium.org | 2010-09-22 00:39:09 +0200 (Wed, 22 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc

sync: make default passwords sync pref value false

BUG=56417
TEST=start syncing in debug build, don't crash.

Review URL: http://codereview.chromium.org/3466007
------------------------------------------------------------------------
r60115 | seh@chromium.org | 2010-09-22 00:20:27 +0200 (Wed, 22 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/central_roster.html
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json

Update call to GTalkNotifier ctor to match updated ctor design.
TEST=Install the test.talkgadget chat manager. Chats should appear in panels. Hovering over contact should not show profile card.
BUG=none
Review URL: http://codereview.chromium.org/3391017
------------------------------------------------------------------------
r60114 | oshima@chromium.org | 2010-09-22 00:20:07 +0200 (Wed, 22 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

There may be no active browser when a lock request is received.
 This can happen when chrome is starting and no browser window is active yet.

BUG=chromium-os:6802
TEST=BVT test should turn green.

Review URL: http://codereview.chromium.org/3455011
------------------------------------------------------------------------
r60112 | satish@chromium.org | 2010-09-21 23:51:43 +0200 (Tue, 21 Sep 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/SpeechInputBubble.xib
   M /trunk/src/chrome/browser/cocoa/speech_input_window_controller.h
   M /trunk/src/chrome/browser/cocoa/speech_input_window_controller.mm
   A /trunk/src/chrome/browser/speech/speech_input_bubble_browsertest.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/chrome_tests.gypi

Extend speech input bubble in Mac to display error messages with try-again and cancel buttons.
The SpeechInputBubbleImpl object now lives longer than the actual info bubble window, and
allows the caller to create a bubble on screen or update with an error message when needed.

When recording speech, the layout of controls are (vertical):
- Label ('Speak now')
- Icon (Mic or wait)
- Button Bar (Horizontal, 1 button, 'Cancel')

When showing a message, the layout of controls are (vertical):
- Label (message text)
- Button Bar (Horizontal, 2 buttons, 'Try Again' and 'Cancel')

Also made a small correction to the info bubble's anchor point to get the arrow point at the correct starting point of the given element rect.

XIB changes:
- Added a 'try again' button and hooked it up to the tryAgainButton outlet in the controller
- Moved position of the cancel button for easier editing in interface builder

BUG=53598
TEST=manual, unplug mic and start recognition to check error message, and similarly give no speech to check.

Review URL: http://codereview.chromium.org/3438002
------------------------------------------------------------------------
r60111 | thakis@chromium.org | 2010-09-21 23:36:26 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Unbreak doubleclicking task manager rows.

BUG=54910
TEST=see bug

Review URL: http://codereview.chromium.org/3414012
------------------------------------------------------------------------
r60109 | thakis@chromium.org | 2010-09-21 23:31:27 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/base/mac_util.mm
   M /trunk/src/base/mach_ipc_mac.h
   M /trunk/src/base/scoped_nsobject.h
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_folder_applescript.h
   M /trunk/src/chrome/browser/cocoa/sidebar_controller.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/common/net/gaia/google_service_auth_error.h
   M /trunk/src/net/disk_cache/entry_impl.cc
   M /trunk/src/net/http/http_auth_gssapi_posix.cc

Fix a bunch of clang warnings/errors.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3473006
------------------------------------------------------------------------
r60108 | rdsmith@google.com | 2010-09-21 23:30:39 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/repost_form_warning_uitest.cc

Make TestLoginAfterRepost flaky on linux.

BUG=56401
TEST=None.

Review URL: http://codereview.chromium.org/3461012
------------------------------------------------------------------------
r60106 | chaitanyag@chromium.org | 2010-09-21 23:22:55 +0200 (Tue, 21 Sep 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h

Fixing the problem where accessibility events for password fields did not set the password boolean field.
Review URL: http://codereview.chromium.org/3353005
------------------------------------------------------------------------
r60097 | isherman@chromium.org | 2010-09-21 22:30:08 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Re-enable BrowserWindowControllerTest.TestNormal

BUG=54945
TEST=BrowserWindowControllerTest.TestNormal

Review URL: http://codereview.chromium.org/3440014
------------------------------------------------------------------------
r60095 | jcivelli@chromium.org | 2010-09-21 22:14:26 +0200 (Tue, 21 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc

Fix crasher with autofill infobar.
The "save credit card" information was deleted by the AutofillManager when the form is submitted but was still pointed to by the TabContents, causing a crasher when navigating.

BUG=50428
TEST=See steps in 56238.

Review URL: http://codereview.chromium.org/3466006
------------------------------------------------------------------------
r60094 | isherman@chromium.org | 2010-09-21 22:13:33 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Changes to the omnibox selection should not affect the "just deleted text" state for autocomplete.

BUG=55983
TEST=none

Review URL: http://codereview.chromium.org/3433014
------------------------------------------------------------------------
r60092 | rdsmith@chromium.org | 2010-09-21 21:40:25 +0200 (Tue, 21 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc
   M /trunk/src/webkit/glue/webaccessibility.cc

Revert 60088 - Set name of document accessibility nodes to document title.

BUG=36169
TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree

Review URL: http://codereview.chromium.org/3448016

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/3402020
------------------------------------------------------------------------
r60089 | nick@chromium.org | 2010-09-21 21:28:15 +0200 (Tue, 21 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Revert 60083 - Fix bug "Autofill: A large number of unnecessary sync updates
generated when no syncable action was performed".

Reason for revert: breaks sync integration tests.

BUG=54461,56305
TEST=bug repro steps

Review URL: http://codereview.chromium.org/3426007

TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/3436025
------------------------------------------------------------------------
r60088 | ctguil@chromium.org | 2010-09-21 21:24:04 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc
   M /trunk/src/webkit/glue/webaccessibility.cc

Set name of document accessibility nodes to document title.

BUG=36169
TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree

Review URL: http://codereview.chromium.org/3448016
------------------------------------------------------------------------
r60087 | jhawkins@chromium.org | 2010-09-21 21:18:05 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/gfx/native_widget_types.h
   M /trunk/src/printing/print_settings.cc
   M /trunk/src/printing/print_settings.h
   M /trunk/src/printing/printing.gyp
   M /trunk/src/printing/printing_context.h
   M /trunk/src/printing/printing_context_cairo.cc
   M /trunk/src/printing/printing_context_mac.mm
   M /trunk/src/printing/printing_context_win.cc
   M /trunk/src/printing/printing_context_win_unittest.cc

Printing: Implement PrintingContext::UseDefaultSettings for Linux/Cairo.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3389005
------------------------------------------------------------------------
r60085 | rohitrao@chromium.org | 2010-09-21 21:13:58 +0200 (Tue, 21 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/reload_button.mm

[Mac] Fix a problem with flicker when moving the mouse off the reload button.

BUG=46981
TEST=Click on the reload button and leave the mouse inside.  When the page is finished reloading, move the mouse out of the button.  The button should re-enable and change from stop to reload, but the border should not flicker.
Review URL: http://codereview.chromium.org/3467003
------------------------------------------------------------------------
r60083 | nick@chromium.org | 2010-09-21 20:54:13 +0200 (Tue, 21 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Fix bug "Autofill: A large number of unnecessary sync updates
generated when no syncable action was performed".

BUG=54461,56305
TEST=bug repro steps

Review URL: http://codereview.chromium.org/3426007
------------------------------------------------------------------------
r60081 | csilv@chromium.org | 2010-09-21 20:42:14 +0200 (Tue, 21 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html

dom-ui options: Add missing label end tags.

BUG=none
TEST=Verify that import data overlay displays with valid HTML.
Review URL: http://codereview.chromium.org/3480001
------------------------------------------------------------------------
r60076 | agl@chromium.org | 2010-09-21 20:19:10 +0200 (Tue, 21 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

zygote: use pthread_once to init localtime(_r) functions.

The previous trick (thread safe statics) is disabled via
compiler flags in our build.

BUG=54264
TEST=none

http://codereview.chromium.org/3412017
------------------------------------------------------------------------
r60068 | xiyuan@chromium.org | 2010-09-21 19:41:43 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js

Fix options page breakage.

BUG=none
TEST=Verify there is not javascript error when loading options page.

Review URL: http://codereview.chromium.org/3450019
------------------------------------------------------------------------
r60063 | rohitrao@chromium.org | 2010-09-21 18:15:49 +0200 (Tue, 21 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/nswindow_additions.h
   A /trunk/src/chrome/browser/cocoa/nswindow_additions.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Explicitly set Space when existing full screen 

If a user moves the full screen window to a different space they get snapped back to the original space when they exit full screen. 

The problem is that internally the full screen window is a different window than the normal browser window. This means that any changes the user makes to the full screen window aren't reflected on the normal browser window. 

The correct fix for this bug is to create a new browser window when the user exits full screen. This new window would then be on the correct space. This would require a fairly large architectural change to the BrowserWindowController class. 

My proposed fix is much simpler. When exiting full screen we simply move the normal browser window to the Space that the full screen window is on. 

Original review at: http://codereview.chromium.org/3345005/show

Patch by Sailesh Agrawal <fnepal@gmail.com>.

BUG=41693
TEST=Moved the full screen window to a different Space. Verified that exiting full screen didn't change the active Space. 
Review URL: http://codereview.chromium.org/3386015
------------------------------------------------------------------------
r60062 | kuan@chromium.org | 2010-09-21 18:02:32 +0200 (Tue, 21 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_proxy.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_proxy.h

chromeos: fix bug where modifying manual proxy settings in UI doesn't take effect

- after tying the text input fields to cros prefs, the options page couldn't load because some server uri's were invalid
- restructure code to extract common code into functionns to check for valid ProxyServer before accessing them for Get and Set
- fix all bugs that i discover in the process

BUG=chromium-os:6827
TEST=modify proxy settings from options page, especially the manual settings. on linux-box, click reload and verify settings are updated as input.  on device, logout or reboot, reopen options and verify settings are updated.

Review URL: http://codereview.chromium.org/3448011
------------------------------------------------------------------------
r60060 | rkc@chromium.org | 2010-09-21 17:36:36 +0200 (Tue, 21 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Disable feedback menu for Chrome.

TBR=zelidrag@chromium.org

BUG=55790
TEST=Report Bug Menu doesn't show up anymore; as with M6

Review URL: http://codereview.chromium.org/3453015
------------------------------------------------------------------------
r60058 | nkostylev@chromium.org | 2010-09-21 17:22:57 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h

Add welcome title to a separate GridLayout.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6194
TEST=Manual. Change languages at welcome screen, see that screen resizes if needed.

Review URL: http://codereview.chromium.org/3423017
------------------------------------------------------------------------
r60054 | bauerb@chromium.org | 2010-09-21 17:00:34 +0200 (Tue, 21 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.mm
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/plugin_updater.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/views/content_setting_bubble_contents.cc
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/plugin_group_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc

Add a unique identifier for plugin groups and use it to identify blocked plugins.

Currently we use the plugin path as identifier for per-plugin content settings, which is not stable across Chrome updates or plugin moves.

The new identifier is either hardcoded (for predefined plugin groups), or the filename without path.

BUG=39252
TEST=none

Review URL: http://codereview.chromium.org/3384014
------------------------------------------------------------------------
r60046 | bauerb@chromium.org | 2010-09-21 14:20:39 +0200 (Tue, 21 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.cc
   M /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.h
   M /trunk/src/chrome/browser/plugin_exceptions_table_model.cc
   M /trunk/src/chrome/browser/plugin_exceptions_table_model.h
   M /trunk/src/chrome/browser/plugin_exceptions_table_model_unittest.cc

[Gtk] Add per-plugin content exceptions to preferences.

Modify gtk_tree::TableAdapter to add groups in the TableModel as special rows in the list_store.

Also, fix a bug in PluginExceptionsTableModel sending OnItemsRemoved callbacks at the wrong time.

Run with --enable-resource-content-settings to test.

BUG=39252
TEST=manual

Review URL: http://codereview.chromium.org/3435009
------------------------------------------------------------------------
r60044 | satish@chromium.org | 2010-09-21 13:33:13 +0200 (Tue, 21 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Disable a test that fails in the Linux perf canary
BUG=56364
TEST=linux perf canary goes green
TBR=imcheng@chromium.org
------------------------------------------------------------------------
r60040 | allanwoj@chromium.org | 2010-09-21 12:45:10 +0200 (Tue, 21 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc

Tidy up network location unit test.

Just a bit of tidy up.

BUG= None
TEST= unit test --gtest_filter=*Geolo*Netw*

Review URL: http://codereview.chromium.org/3436021
------------------------------------------------------------------------
r60039 | jochen@chromium.org | 2010-09-21 11:58:01 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/enumerate_tabs
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/enumerate_tabs/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/enumerate_tabs/manifest.json

Do not create an incogntio profile as side effect when listing all tabs/windows.

BUG=55479
TEST=DontCreateIncognitoProfile

Review URL: http://codereview.chromium.org/3412005
------------------------------------------------------------------------
r60038 | joth@chromium.org | 2010-09-21 11:37:50 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

NoInfobarForDeniedOrigin no longer appears flaky (last seen July 10)

BUG=47053
TEST=GeolocationBrowserTest.NoInfobarForDeniedOrigin

Review URL: http://codereview.chromium.org/3424005
------------------------------------------------------------------------
r60036 | allanwoj@chromium.org | 2010-09-21 11:23:33 +0200 (Tue, 21 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/gateway_data_provider_common.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc

Fix starting network location data provider thread issue.

Have a reference count in each network location data provider and check the reference count in StartProvider to see if the network location provider thread has already been started. Before it would just Start the thread again if StartProvider was called more than once.

BUG=56245
TEST= unit test --gtest_filter=*Geolo*Netw*

Review URL: http://codereview.chromium.org/3405017
------------------------------------------------------------------------
r60035 | phajdan.jr@chromium.org | 2010-09-21 11:16:51 +0200 (Tue, 21 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Make sure the application icon is up to date
when destroying DownloadManager.

BUG=54823
TEST=see bug

Review URL: http://codereview.chromium.org/3397017
------------------------------------------------------------------------
r60034 | phajdan.jr@chromium.org | 2010-09-21 11:15:59 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc

Regression fix: keep the download shelf visible when multiple sites are saved.

BUG=54149
TEST=see bug

Review URL: http://codereview.chromium.org/3442003
------------------------------------------------------------------------
r60033 | dilmah@chromium.org | 2010-09-21 11:04:31 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc

Make Enter key work on wi-fi password window.
Another attempt (previous one was incorrect).

BUG=http://crosbug.com/6620
TEST=Manual
Review URL: http://codereview.chromium.org/3386013
------------------------------------------------------------------------
r60027 | nkostylev@chromium.org | 2010-09-21 10:10:57 +0200 (Tue, 21 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_delegate.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_dropdown_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_dropdown_button.h

Switch welcome screen layout to GridLayout.
Welcome label temporary is not used.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6194
TEST=Manual: on welcome screen switch languages. See that controls stay in screen bounds.

Review URL: http://codereview.chromium.org/3432013
------------------------------------------------------------------------
r60026 | dpolukhin@chromium.org | 2010-09-21 08:24:53 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc

Remove button on image pod shouldn't jump

BUG=none
TEST=Manual, move mouse over remove button on login screen.

Review URL: http://codereview.chromium.org/3382011
------------------------------------------------------------------------
r60025 | willchan@chromium.org | 2010-09-21 08:13:49 +0200 (Tue, 21 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/common/net/url_request_context_getter.h
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/ocsp/nss_ocsp.h
   M /trunk/src/net/url_request/url_request_context.cc
   M /trunk/src/net/url_request/url_request_context.h

Revert 59972 (chromium os leaks) - Reland r59511: Eagerly set the IO loop used for OCSP.

ChromeOS will create a special Profile for login.  Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile.  Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics.  The solution is to identify the "main" Profile.  We create said Profile in BrowserMain.  I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP.

Other than minor plumbing of "is_main_", this changelist is identical to r59511.

BUG=55940
TEST=Startup ChromeOS's Chrome.  Should not crash on startup.

Review URL: http://codereview.chromium.org/3470001

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3468005
------------------------------------------------------------------------
r60021 | johnnyg@chromium.org | 2010-09-21 07:15:13 +0200 (Tue, 21 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc

Set the migration-completed flag once sync is setup on the new system,
and also don't crash if the user settings db doesn't exist.

BUG=55640
TEST=set up sync with new profile, but shutdown before credentials arrive.  then restart chrome.

Review URL: http://codereview.chromium.org/3450006
------------------------------------------------------------------------
r60019 | johnnyg@chromium.org | 2010-09-21 06:50:33 +0200 (Tue, 21 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Tear down the notifications UI manager before the profile goes away.

BUG=53912
TEST=close chrome with a notification open


Review URL: http://codereview.chromium.org/3481001
------------------------------------------------------------------------
r60013 | sky@chromium.org | 2010-09-21 05:24:49 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Disables top sites until we get it in a better shape.

BUG=40313
TEST=see bug. aocampo has some test cases too.

Review URL: http://codereview.chromium.org/3412015
------------------------------------------------------------------------
r60012 | tfarina@chromium.org | 2010-09-21 05:21:04 +0200 (Tue, 21 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.cc
   M /trunk/src/chrome/browser/extensions/extension_gallery_install_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_proxy_api.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

extensions: Append base:: in the StringPrintf calls.

(Note this is a TODO in string_util.h)

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3415015
------------------------------------------------------------------------
r60007 | tfarina@chromium.org | 2010-09-21 04:40:00 +0200 (Tue, 21 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/prefs/scoped_pref_update.cc
   M /trunk/src/chrome/browser/prefs/scoped_pref_update.h

Remove deprecated ScopedPrefUpdate constructor

(Note: This was a TODO for viettrunglu).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3449012
------------------------------------------------------------------------
r60001 | mirandac@chromium.org | 2010-09-21 03:00:34 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add the ability to change NTP logos using a command from the web resource server.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3418020
------------------------------------------------------------------------
r60000 | cbentzel@chromium.org | 2010-09-21 02:43:37 +0200 (Tue, 21 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

Username+password weren't being saved for HTTP or FTP authentication.

HTTP + FTP authentication reuses the PasswordManager infrastructure for saving and autofilling passwords. When the user needs to be prompted for username + password, a PasswordForm is created. However, a username_element and password_element were never set in the PasswordForm.

The PasswordFormManager would then treat this form as invalid, and the values would never be saved even if the page loaded successfully.
 
The UI flow is a bit different from older versions of Chrome, but more consistent with other password saves: the user first presses the OK
button to provisionally save and try the new password. When the page loads successfully, an info bar than appears to ask the user whether the password should be saved.

BUG=5236
TEST=Go to site (or proxy) which requires Basic or Digest HTTP authentication, enter correct username+password and elect to save the password. Stop Chrome, reopen, and go to site (or through same proxy) and make sure username+password are autofilled in the form.

Review URL: http://codereview.chromium.org/3398010
------------------------------------------------------------------------
r59998 | erg@google.com | 2010-09-21 02:30:17 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

GTK: Update wrench menu icon on GTK theme change.

BUG=none
TEST=switch GTK themes; wrench icon should change.

Review URL: http://codereview.chromium.org/3468004
------------------------------------------------------------------------
r59997 | alekseys@chromium.org | 2010-09-21 02:20:12 +0200 (Tue, 21 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_sidebar_api.cc
   M /trunk/src/chrome/test/data/extensions/api_test/sidebar/test.js

experimental.sidebar extensions API: handle 'undefined' and 'null' values of 'details' parameter
as if it was omitted.

BUG=55202
TEST=run browser_tests.exe --gtest_filter=SidebarApiTest.*
Manual test:
1. Open Developer Tools in any extension page.
2. Run the code
     chrome.experimental.sidebar.getState(undefined,function(){})
   (undefined can be replaced with null)
It should return the state of the sidebar in the current tab.

Review URL: http://codereview.chromium.org/3390015
------------------------------------------------------------------------
r59996 | estade@chromium.org | 2010-09-21 02:19:54 +0200 (Tue, 21 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

Fix up some spacing. No code change.

TBR=evan
BUG=none
TEST=compile

Review URL: http://codereview.chromium.org/3448015
------------------------------------------------------------------------
r59995 | estade@chromium.org | 2010-09-21 02:13:13 +0200 (Tue, 21 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

[GTK] show the upgrade icon in the wrench menu.

Regardless of whether the user has the system preference for showing icons in menus, we should show this one as it is "urgent".

BUG=none
TEST=manual (faked an upgrade)

Review URL: http://codereview.chromium.org/3398013
------------------------------------------------------------------------
r59993 | seh@chromium.org | 2010-09-21 01:49:59 +0200 (Tue, 21 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/background.html
   M /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgehook.js
   M /trunk/src/chrome/browser/resources/chat_manager/js/gmailbridgehook.js
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json

Content scripts ping background extension for the central roster jid
earlier in the load process, so they can cache the values for subsequent
use by Google chat code to prevent on-page moles from appearing on ChromeOS
BUG=chromium-os:3312
TEST=Open chat through chat manager and then launch iGoogle.
Review URL: http://codereview.chromium.org/3416014
------------------------------------------------------------------------
r59992 | csilv@chromium.org | 2010-09-21 01:43:18 +0200 (Tue, 21 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js

dom-ui options: code review improvements, fixed enable state bug.

BUG=none
TEST=validate import dialog behavior in tabbed-options window
Review URL: http://codereview.chromium.org/3402008
------------------------------------------------------------------------
r59988 | chocobo@chromium.org | 2010-09-21 01:18:10 +0200 (Tue, 21 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc

Locally update cache when network objects change.
This removes the lag users see when they make changes to networks but libcros has not called back yet.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3391013
------------------------------------------------------------------------
r59987 | evan@chromium.org | 2010-09-21 01:09:27 +0200 (Tue, 21 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Move the statistics initialization higher up in browser init.

This allows code (that lives in between its old location and its
new location; in particular, PrefService initialization) to use
histograms.

TEST=verified about:histograms contained my histogram after starting

Review URL: http://codereview.chromium.org/3390017
------------------------------------------------------------------------
r59986 | asargent@chromium.org | 2010-09-21 01:00:54 +0200 (Tue, 21 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/test/data/extensions/context_menus/patterns/test.js
   A /trunk/src/chrome/test/data/extensions/context_menus/target_urls
   A /trunk/src/chrome/test/data/extensions/context_menus/target_urls/background.html
   A /trunk/src/chrome/test/data/extensions/context_menus/target_urls/manifest.json
   A /trunk/src/chrome/test/data/extensions/context_menus/target_urls/test.js

Specifying "targetUrlPatterns" should imply link context.

When creating a context menu item from an extension, specifying one or more 
patterns in the "targetUrlPatterns" should imply that your item only appears
on items with a matching link, and not in contexts that have no link (which
does not match, sort of by definition :) ).


BUG=49739
TEST=Follow steps in bug report.

Review URL: http://codereview.chromium.org/3420009
------------------------------------------------------------------------
r59983 | dtseng@chromium.org | 2010-09-21 00:46:30 +0200 (Tue, 21 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Only enable renderer accessibility on Mac if a command line flag is passed or VoiceOver is running.
BUG=55902
TEST=run Chrome with and without VoiceOver on.  In the former case, verify that accessibility works; in the latter case, verify that accessibility doesn't work.
Review URL: http://codereview.chromium.org/3468001
------------------------------------------------------------------------
r59977 | mlloyd@chromium.org | 2010-09-20 23:15:20 +0200 (Mon, 20 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Marking SyncXMLHttpRequest_DuringUnload as flaky after multiple failures.

BUG=55380
TEST=

------------------------------------------------------------------------
r59975 | mlloyd@chromium.org | 2010-09-20 23:03:51 +0200 (Mon, 20 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Mark RestoreWithExistingSiteInstance as flaky on all platforms.

BUG=55380
TEST=

------------------------------------------------------------------------
r59974 | estade@chromium.org | 2010-09-20 23:03:09 +0200 (Mon, 20 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

[GTK] handle popup window resize events properly.

BUG=51586
TEST=see bug for repro

Review URL: http://codereview.chromium.org/3388012
------------------------------------------------------------------------
r59972 | willchan@chromium.org | 2010-09-20 22:29:29 +0200 (Mon, 20 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/common/net/url_request_context_getter.h
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/ocsp/nss_ocsp.h
   M /trunk/src/net/url_request/url_request_context.cc
   M /trunk/src/net/url_request/url_request_context.h

Reland r59511: Eagerly set the IO loop used for OCSP.

ChromeOS will create a special Profile for login.  Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile.  Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics.  The solution is to identify the "main" Profile.  We create said Profile in BrowserMain.  I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP.

Other than minor plumbing of "is_main_", this changelist is identical to r59511.

BUG=55940
TEST=Startup ChromeOS's Chrome.  Should not crash on startup.

Review URL: http://codereview.chromium.org/3470001
------------------------------------------------------------------------
r59967 | georgey@chromium.org | 2010-09-20 22:08:08 +0200 (Mon, 20 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

Fix for Newly created autofill profile shows up three times in dialog
BUG=55649
TEST=should appear only once :)
Review URL: http://codereview.chromium.org/3411005
------------------------------------------------------------------------
r59963 | erg@google.com | 2010-09-20 21:38:43 +0200 (Mon, 20 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/app/menus/button_menu_item_model.cc
   M /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu.cc
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h

GTK: The wrench menu should remain open after clicking +/-.

This changes the model so there's a property about whether a button should
dismiss the menu, modifies the GtkCustomMenu[Item] implementation to obey it,
and modifies the BrowserToolbar to update the menu on zoom change.

BUG=48240
TEST=matches windows behaviour

Review URL: http://codereview.chromium.org/3391009
------------------------------------------------------------------------
r59956 | agl@chromium.org | 2010-09-20 21:27:16 +0200 (Mon, 20 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Replicate r59512 for localtime_r

Use magic to init our 'localtime_r' wrapper.

(See bug for details.)

Patch-by: kcc (Chromium)

BUG=54264
TEST=none
------------------------------------------------------------------------
r59955 | glotov@chromium.org | 2010-09-20 21:02:44 +0200 (Mon, 20 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Cancel button changed to Back button.

BUG=chromium-os:4945
TEST=Run chrome --login-manager --login-screen=eula, Back button should be enabled and lead to Network screen.

Review URL: http://codereview.chromium.org/3393007
------------------------------------------------------------------------
r59954 | rickcam@chromium.org | 2010-09-20 20:59:53 +0200 (Mon, 20 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Added Linux support for Launch-on-Startup

BUG=43382
TEST=none

Review URL: http://codereview.chromium.org/3417004
------------------------------------------------------------------------
r59953 | mmenke@chromium.org | 2010-09-20 20:58:39 +0200 (Mon, 20 Sep 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   A /trunk/src/chrome/browser/resources/net_internals/socketpoolwrapper.js
   M /trunk/src/chrome/browser/resources/net_internals/socketsview.js
   M /trunk/src/chrome/browser/resources/net_internals/util.js

Adds state of socket pools to net-internals data dumps as a series of tables.Extends TablePrinter to output HTML in addition to plain text tables, to avoid duplicating code to populate the tables.BUG=39756TEST=manual
Review URL: http://codereview.chromium.org/3451001
------------------------------------------------------------------------
r59950 | dhollowa@chromium.org | 2010-09-20 20:55:36 +0200 (Mon, 20 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h

Autofill profile pop-up should trigger for mouse double-clicks

Removes the cancellation logic for separated AutoFill and Autocomplete.  This is no longer needed.  The recent refactoring of the popup handling causes this logic to always hit the "cancel" scenario and thus return only Autocomplete suggestions and never AutoFill suggestions.  But in fact, we get the Autocomplete-only results in the correct cases by virtue of the field type queried.

BUG=54875
TEST=AutoFillManagerTest.GetFieldSuggestions*

Review URL: http://codereview.chromium.org/3405015
------------------------------------------------------------------------
r59949 | evan@chromium.org | 2010-09-20 20:54:13 +0200 (Mon, 20 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

Reduce console spam of LOG(INFO) in buffered_resource_handler.cc.

This code, though marked temporary, dates back to at least 2008!

TEST=compiles

Review URL: http://codereview.chromium.org/3427010
------------------------------------------------------------------------
r59941 | evan@chromium.org | 2010-09-20 18:57:11 +0200 (Mon, 20 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Disable SessionHistoryTest.HistoryLength.

It is very slow and occasionally times out.

BUG=56267

Review URL: http://codereview.chromium.org/3412013
------------------------------------------------------------------------
r59940 | evan@chromium.org | 2010-09-20 18:56:47 +0200 (Mon, 20 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Disable ResourceDispatcherTest.SyncXMLHttpRequest_DuringUnload.

It is very slow.

BUG=56264

Review URL: http://codereview.chromium.org/3452016
------------------------------------------------------------------------
r59933 | mmenke@chromium.org | 2010-09-20 16:38:53 +0200 (Mon, 20 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/browser/resources/net_internals/requestsview.js
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js

Adds "delete all" buttons to chrome://net-internals/#data and chrome://net-internals/#requests.  Both buttons delete all captured events that appear in subsequent log dumps and on the requests page.

The delete selected button on the requests page now deletes items from subsequent log dumps as well.

BUG=54744
TEST=manual

Review URL: http://codereview.chromium.org/3450013
------------------------------------------------------------------------
r59930 | finnur@chromium.org | 2010-09-20 16:05:27 +0200 (Mon, 20 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

Updating status on three tests:

Someone changed FindInPagePrematureEnd from DISABLED to FAILS. However, it is not expected to pass until we fix 11761 so we don't need to run it until then. Marking it back as DISABLED.

NoIncognitoPrepopulate was failing because the infrastructure was laggy (the simple act of launching a page in incognito could take up to a minute). I can no longer repro the error, so I think the problem is gone.

Back in June, ActivateLinkNavigatesPage got marked as DISABLED (because it crashed occasionally), with a bug filed against no-one, so I have no crashdump or try bot logs nor any idea what the state of it is. Marking as enabled to see if it is still a problem. It passes locally.

BUG=45594, 40948
TEST=These are tests.

Review URL: http://codereview.chromium.org/601044
------------------------------------------------------------------------
r59929 | nkostylev@chromium.org | 2010-09-20 15:42:40 +0200 (Mon, 20 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/resources/host_registration_page.html
   M /trunk/src/chrome/test/data/register_form.html

Expose additional system info to register page via set_user_info message.
Skip registration screen when manifest is not defined or url is invalid.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6708, http://code.google.com/p/chromium-os/issues/detail?id=6749
TEST=Manual. Register screen is not shown when OEM customization is not specified. Additional system info is passed to register page.

Review URL: http://codereview.chromium.org/3459009
------------------------------------------------------------------------
r59928 | tfarina@chromium.org | 2010-09-20 15:28:17 +0200 (Mon, 20 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/autofill_options.js

DOMUI: Fix a bug in the AutoFill tab.

Bug: When there is no items in the profile list, click on the checkbox to
disable the autofill feature. Notice that all buttons become disable (that is ok).
Now click again to enable the feature, notice that all buttons become enabled
(that is NOT ok, because there aren't any items in the profile list).

Fix: Properly enable/disable the Edit and Remove buttons based on the profile
list size and the current state of the preference.

BUG=None
TEST=see Bug description above.

Review URL: http://codereview.chromium.org/3390016
------------------------------------------------------------------------
r59926 | dilmah@chromium.org | 2010-09-20 14:25:21 +0200 (Mon, 20 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc

Make link to proxy settings visible.

However, chrome://options/proxy page does not actually save settings ATM.
This page does not save settings even for logged in user: settings do not survive across logins.

BUG=http://crosbug.com/3062
TEST=Manual

Review URL: http://codereview.chromium.org/3413018
------------------------------------------------------------------------
r59925 | jochen@chromium.org | 2010-09-20 14:03:43 +0200 (Mon, 20 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_notification_task.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h

Hook up indexed databases to content settings.

Step 1: check content settings and report back the result to the content settings delegate.

BUG=56248
TEST=none

Review URL: http://codereview.chromium.org/3420012
------------------------------------------------------------------------
r59920 | allanwoj@chromium.org | 2010-09-20 12:25:48 +0200 (Mon, 20 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc

Fix behaviour of queued geolocation infobars on navigate.

Now checks to see if a pending infobar request already exists before adding it to the vector of pending infobar requests. Before more than one of the same request could be stored, not all of them would be deleted on a navigate within a domain. Also noticed this bug http://code.google.com/p/chromium/issues/detail?id=55691 while investigating.

BUG=51899
TEST=Go to a website with two gelocation requests and navigate within that domain. There should be no leftover infobars.

Review URL: http://codereview.chromium.org/3396006
------------------------------------------------------------------------
r59916 | pfeldman@chromium.org | 2010-09-20 11:16:46 +0200 (Mon, 20 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer.cc
   M /trunk/src/chrome/browser/net/load_timing_observer.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.h

DevTools: provide load timing for sync resources.

Review URL: http://codereview.chromium.org/3458004
------------------------------------------------------------------------
r59915 | jochen@chromium.org | 2010-09-20 10:47:37 +0200 (Mon, 20 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/content_exceptions_table_model.h
   A /trunk/src/chrome/browser/content_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/chrome_tests.gypi

Refcount the host content settings map from the content exceptions table model.

Otherwise, we run into a problem when the incognito profile goes away while the user is editing exceptions.

BUG=51959
TEST=ContentExceptionsTableModelTest.*

Review URL: http://codereview.chromium.org/3446013
------------------------------------------------------------------------
r59914 | jochen@chromium.org | 2010-09-20 10:10:17 +0200 (Mon, 20 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_terms_data.cc

Include rlz headers only on official builds

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3440009
------------------------------------------------------------------------
r59913 | hans@chromium.org | 2010-09-20 09:59:14 +0200 (Mon, 20 Sep 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h
   M /trunk/src/chrome/browser/sync/util/fast_dump.h

Fix sync_unit_tests two-phase lookup problems.

Clang fails to compile some files used by sync_unit_tests because it is more
strict on code following the Standard.

Type-dependent names are bound during template instantiation by looking at
declarations that are visible at the point of definition of the template
and declarations from namespaces associated with the types of the function
arguments both from the instantiation context and from the definition context.

For this reason, when declaring a function like
std::ostream& operator<<(std::ostream& s, const syncable::Entry& e);
it is important that the function is declared in the namespace of one of its
arguemnts, i.e. syncable in this case.

See http://clang.llvm.org/compatibility.html#dep_lookup for more info.

BUG=none
TEST=sync_unit_tests

Review URL: http://codereview.chromium.org/3401002
------------------------------------------------------------------------
r59909 | tfarina@chromium.org | 2010-09-20 01:42:12 +0200 (Mon, 20 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc

gtk: Implement SetImage function for speech input bubble.

(Note: This was a TODO for satish).

BUG=53598
TEST=try out one of the samples in https://docs.google.com/View?id=dcfg79pz_5dhnp23f5, notice that we don't crash in debug mode.

Review URL: http://codereview.chromium.org/3391012
------------------------------------------------------------------------
r59906 | thakis@chromium.org | 2010-09-19 22:42:52 +0200 (Sun, 19 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Revert 59889 - Fix regression introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=57788

Add a delegate interface so that chromium have more fine-grained control over
whether a V8 extension is injected into a script context. This is the
chromium-side change of webkit bug
https://bugs.webkit.org/show_bug.cgi?id=45721

BUG=37290
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/3398001

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/3464003
------------------------------------------------------------------------
r59904 | thakis@chromium.org | 2010-09-19 22:40:15 +0200 (Sun, 19 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc

Revert 59893 - Disable failing Basic test that I broke.

BUG=56091
TEST=no
TBR=rafaelw

Review URL: http://codereview.chromium.org/3434011

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/3450015
------------------------------------------------------------------------
r59900 | finnur@chromium.org | 2010-09-18 12:56:48 +0200 (Sat, 18 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a command line switch to allow testers to test the upgrade detection
without having to wait 24 hrs.

BUG=None
TEST=To check every 10 seconds, use: --check-for-update-interval=10

Review URL: http://codereview.chromium.org/3419004
------------------------------------------------------------------------
r59899 | ctguil@chromium.org | 2010-09-18 09:43:58 +0200 (Sat, 18 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/test/run_all_unittests.cc
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/chrome_frame/utils.h

Remove code that enables renderer accessibility based on the SPI_GETSCREENREADER parameter. 

Update chrome frame so that its test automation can still use renderer accessibility.

BUG=55902
TEST=none

Review URL: http://codereview.chromium.org/3383010
------------------------------------------------------------------------
r59898 | shess@chromium.org | 2010-09-18 06:54:04 +0200 (Sat, 18 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Suppress safe-browsing perf logging.

Under SB_DLOG(), so easy to enable for those as wants it back.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3389019
------------------------------------------------------------------------
r59893 | mpcomplete@chromium.org | 2010-09-18 03:54:36 +0200 (Sat, 18 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc

Disable failing Basic test that I broke.

BUG=56091
TEST=no
TBR=rafaelw

Review URL: http://codereview.chromium.org/3434011
------------------------------------------------------------------------
r59890 | thakis@chromium.org | 2010-09-18 03:30:05 +0200 (Sat, 18 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h

Map: Guard concurrent accesses to a std::map by a lock in drawing code.

Both UI thread and displaylink thread always take the CG lock before taking this new lock, hence this shouldn't deadlock (the UI thread sometimes only takes and releases the new lock without attempting to take the CG lock).

BUG=52491
TEST=no more crashes in DrawAcceleratedSurfaceInstace

Review URL: http://codereview.chromium.org/3391011
------------------------------------------------------------------------
r59889 | mpcomplete@chromium.org | 2010-09-18 03:02:38 +0200 (Sat, 18 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Fix regression introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=57788

Add a delegate interface so that chromium have more fine-grained control over
whether a V8 extension is injected into a script context. This is the
chromium-side change of webkit bug
https://bugs.webkit.org/show_bug.cgi?id=45721

BUG=37290
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/3398001
------------------------------------------------------------------------
r59887 | chaitanyag@chromium.org | 2010-09-18 02:59:31 +0200 (Sat, 18 Sep 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Fixing a bug which causes crash on linux when opening pref dialog.
Review URL: http://codereview.chromium.org/3402009
------------------------------------------------------------------------
r59884 | imcheng@chromium.org | 2010-09-18 02:47:28 +0200 (Sat, 18 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Restoring the old media UI test before the move from ui_test to interactive_uitest.

TEST=ui_test
BUG=none

Review URL: http://codereview.chromium.org/3416012
------------------------------------------------------------------------
r59882 | evan@chromium.org | 2010-09-18 02:09:15 +0200 (Sat, 18 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/base/linked_list.h
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate_linux.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   M /trunk/src/sandbox/sandbox.gyp
   M /trunk/src/skia/skia.gyp
   M /trunk/src/testing/gtest.gyp

Support for building Chrome using Clang.

To build, set the clang=1 gyp_define.

This patch is the culmination of many months of effort and many
patches.  It contains the minimal changes to Chrome that
are Clang-specific.

With this, I can build the "chrome" target.  Once this patch
is in, we can incrementally fix bits of Chrome and various
tests and remove the Clang-specific workarounds.

Review URL: http://codereview.chromium.org/522020
------------------------------------------------------------------------
r59876 | zelidrag@chromium.org | 2010-09-18 01:18:55 +0200 (Sat, 18 Sep 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/system_info_ui.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/system_info_ui.h
   M /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/resources/bug_report.css
   M /trunk/src/chrome/browser/resources/bug_report.html
   M /trunk/src/chrome/browser/resources/bug_report.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Bunch of bugreport fixes. Also, moved about:system page to chrome:system.

BUG=chromium-os:6737,chromium-os:6739,chromium-os:6547,chromium-os:6108
TEST=test the bugs above

Review URL: http://codereview.chromium.org/3417008
------------------------------------------------------------------------
r59870 | aa@chromium.org | 2010-09-18 00:59:33 +0200 (Sat, 18 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Scroll to the top when toggling sections on the NTP.

BUG=56075
TEST=Open NTP. Make window small enough to scroll. Open a different
section, then reopen the original section. Scroll should have returned
to top.

Review URL: http://codereview.chromium.org/3415016
------------------------------------------------------------------------
r59869 | sergeyu@chromium.org | 2010-09-18 00:51:16 +0200 (Sat, 18 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/media/audio/audio_output_controller.cc
   M /trunk/src/media/audio/audio_output_controller.h
   M /trunk/src/media/audio/audio_output_controller_unittest.cc

Make AudioOutputController.Close() truly asynchronous.
Added closed_task parameter in this method. This parameter is used to
notify the caller when the stream is actually closed. Callbacks may
be called until closed_task is executed.

BUG=55755
TEST=Unittests, audio still works, doesn't crash

Review URL: http://codereview.chromium.org/3415007
------------------------------------------------------------------------
r59868 | aa@chromium.org | 2010-09-18 00:49:08 +0200 (Sat, 18 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css

Make all font sizes in NTP percentages of their parent.

BUG=54275
TEST=Open NTP. Change font size (preferences > under the hood
> change font and language settings). All fonts on page
should change size proportionally.

Review URL: http://codereview.chromium.org/3458007
------------------------------------------------------------------------
r59865 | lzheng@chromium.org | 2010-09-18 00:34:42 +0200 (Sat, 18 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/build/all.gyp
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_browsertest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_test.cc (from /trunk/src/chrome/browser/safe_browsing/safe_browsing_browsertest.cc:59224)
   M /trunk/src/chrome/chrome_tests.gypi

Create test for safebrowsing_test 
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3383006
------------------------------------------------------------------------
r59858 | thestig@chromium.org | 2010-09-17 23:56:42 +0200 (Fri, 17 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc

Cleanup: Review lots of CHECKs used to debug bug 16371.

BUG=16371
TEST=none
Review URL: http://codereview.chromium.org/3405013
------------------------------------------------------------------------
r59857 | glen@chromium.org | 2010-09-17 23:55:27 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/themes/browser_theme_provider.cc

Change NTP colors, remove shadows.

BUG=55911
TEST=Verify that the new tab page colors are grey and the shadow is removed.

Review URL: http://codereview.chromium.org/3423011
------------------------------------------------------------------------
r59855 | evan@chromium.org | 2010-09-17 23:48:14 +0200 (Fri, 17 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/endpointer/energy_endpointer.cc

Remove console LOG(INFO) spam from EnergyEndpointer.

TEST=compiles

Review URL: http://codereview.chromium.org/3414008
------------------------------------------------------------------------
r59854 | ananta@chromium.org | 2010-09-17 23:47:16 +0200 (Fri, 17 Sep 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/custom_sync_call_context.h
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/chrome_frame/utils.h

Added full support for invoking before unload and unload handlers on ChromeFrame rendered
pages. This allows a webpage to put up a confirmation dialog in its beforeunload handler
and potentially cancel the operation. We only support invoking unload handlers on the page
for IE full tab mode. To achieve this the active document handles the OLECMDID_ONUNLOAD
exec command which is passed by the DOCHOST to the object which allows us to potentially
cancel the operation.

Thanks to Stoyan for his help in authoring parts of this CL.

The AutomationMsg_RunUnloadHandlers message which is used only by ChromeFrame is now a sync
message which returns back a bool indicating whether the unload operation can be continued
or not. The ExternalTabContainer now implements the BeforeUnloadFired method in the
TabContentsDelegate and aborts the unload operation if the user chose to not proceed with
the unload.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=33200

Bug=33200
Test=Covered by existing unload event test. Will add a test which validates whether a page
can cancel the unload operation in a subsequent CL.

Review URL: http://codereview.chromium.org/3450014
------------------------------------------------------------------------
r59851 | mlloyd@chromium.org | 2010-09-17 23:14:45 +0200 (Fri, 17 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc

Marking RedirectTest.Client as FLAKY

BUG=55380
TEST=

------------------------------------------------------------------------
r59850 | thakis@chromium.org | 2010-09-17 23:10:21 +0200 (Fri, 17 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Stop display link thread for views that are in background tabs.

Also, make the display link code more similar to Apple's VideoView example.

BUG=53344
TEST=YouTube videos should still play. Try switching between tabs with youtube videos.

Review URL: http://codereview.chromium.org/3453008
------------------------------------------------------------------------
r59848 | tim@chromium.org | 2010-09-17 23:05:16 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/about_sync.html

Remove unnecessary log spew from ProfileSyncService.

BUG=none.
TEST=examine logs from browser/ui/unit/interactive_ui tests, profile_sync_service should not be in top 20 spammers.

Review URL: http://codereview.chromium.org/3436017
------------------------------------------------------------------------
r59847 | ace@chromium.org | 2010-09-17 23:03:07 +0200 (Fri, 17 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   A /trunk/src/chrome/test/functional/search_engines.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Adding automation hook GetSearchEngineInfo, accessible through json automation proxy interface.

BUG=52009

Review URL: http://codereview.chromium.org/3389016
------------------------------------------------------------------------
r59846 | evan@chromium.org | 2010-09-17 23:01:12 +0200 (Fri, 17 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc

Reduce console LOG(INFO) spam in history_service.

TEST=compiles

Review URL: http://codereview.chromium.org/3386010
------------------------------------------------------------------------
r59844 | apatrick@chromium.org | 2010-09-17 22:49:49 +0200 (Fri, 17 Sep 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Disabled SessionHistoryTest.BasicBackForward for Linux because it is flaky. It was already disabled for Windows.

chrome/browser/session_history_uitest.cc:123: Failure
Value of: tab_->NavigateToURL( test_server_.GetURL("files/session_history/bot3.html"))
  Actual: false
Expected: true
chrome/test/ui/ui_test.cc:361: Failure
Value of: automation()->SetFilteredInet(false)
  Actual: false
Expected: true
chrome/test/ui/ui_test.cc:365: Failure
Value of: automation()->GetBrowserWindowCount(&window_count)
  Actual: false
Expected: true
chrome/test/ui/ui_test.cc:386: Failure
Value of: browser_proxy.get()
  Actual: false
Expected: true

TEST=try
BUG=55380

Review URL: http://codereview.chromium.org/3437007
------------------------------------------------------------------------
r59843 | levin@chromium.org | 2010-09-17 22:46:29 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/search_engines/search_provider_install_state_dispatcher_host.cc
   M /trunk/src/chrome/browser/search_engines/search_provider_install_state_dispatcher_host.h
   M /trunk/src/chrome/renderer/external_extension_uitest.cc

Implement IsSearchProviderInstalled handling on I/O thread.

BUG=38475
TEST=ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled

Review URL: http://codereview.chromium.org/3460001
------------------------------------------------------------------------
r59841 | rohitrao@chromium.org | 2010-09-17 22:37:15 +0200 (Fri, 17 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/dev_tools_controller.h
   M /trunk/src/chrome/browser/cocoa/dev_tools_controller.mm
   M /trunk/src/chrome/browser/cocoa/sidebar_controller.h
   M /trunk/src/chrome/browser/cocoa/sidebar_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

[Mac] Refactor the DevToolsController and SidebarController to create their views directly.  Remove references to the devtools and sidebar NSSplitViews from TabWindowController.

This also fixes the issue where the findbar and resize widget would disappear.  For some reason, the NSSplitViews were indicating that they were opaque when instantiated in the xib files, but this does not happen when they are created programmatically.

Xib changes:
- BrowserWindow.xib no longer contains the two NSSplitViews.

BUG=55228,55441
TEST=All unittest should pass.
TEST=Findbar and resize widget should not disappear when scrolling.
Review URL: http://codereview.chromium.org/3436009
------------------------------------------------------------------------
r59840 | tim@chromium.org | 2010-09-17 22:26:59 +0200 (Fri, 17 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Take 2 - Get password sync to a usable state.

Plumb the gaia password up to the cryptographer to generate an
encryption key.
Add NIGORI to the list of active datatypes to request if
enable-sync-passwords is specified.

Also fixes behavior from bug 55501 (required adding ExtraChangeRecordData to syncapi), as well as an ADD-handling bug in ApplyChangesFromSyncModel.

Add back the call to Cryptographer::Bootstrap which was mistakenly removed in auth refactor.

This patch doesn't have necessary UI to handle secondary passphrases,
password changes, or existing user upgrades. Only unsynced profiles
can currently get password sync working.

BUG=48702, 32410, 55501
TEST=ProfileSyncPasswordTest, upcoming password integration tests

Review URL: http://codereview.chromium.org/3441009
------------------------------------------------------------------------
r59839 | evan@chromium.org | 2010-09-17 22:23:08 +0200 (Fri, 17 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc

Reduce console spam from top_sites.

This prints over 500 times while running tests.

TEST=compiles

Review URL: http://codereview.chromium.org/3441015
------------------------------------------------------------------------
r59838 | ben@chromium.org | 2010-09-17 22:21:04 +0200 (Fri, 17 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   D /trunk/src/chrome/app/nibs/CookiePrompt.xib
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.h
   D /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   D /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.h
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   D /trunk/src/chrome/browser/cookie_modal_dialog.cc
   D /trunk/src/chrome/browser/cookie_modal_dialog.h
   D /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   D /trunk/src/chrome/browser/cookie_modal_dialog_mac.mm
   D /trunk/src/chrome/browser/cookie_modal_dialog_uitest.cc
   D /trunk/src/chrome/browser/cookie_modal_dialog_views.cc
   D /trunk/src/chrome/browser/cookie_prompt_modal_dialog_delegate.h
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   D /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   D /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   D /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   D /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   D /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   D /trunk/src/chrome/browser/views/cookie_prompt_view.h
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove vestigial cookie/web app permissions prompting UI now that the async UI has been approved for M7.This allows me to more easily change the way the appmodal dialog system works.

http://crbug.com/55121
TEST=existing tests
Review URL: http://codereview.chromium.org/3299020
------------------------------------------------------------------------
r59837 | cmasone@google.com | 2010-09-17 22:19:00 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc

[Chrome OS] ensure owner key is found after crash, if user is owner

BUG=chromium-os:6687
TEST=unit tests, put on device and check

Review URL: http://codereview.chromium.org/3452009
------------------------------------------------------------------------
r59834 | levin@chromium.org | 2010-09-17 21:35:21 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_provider_install_data.cc
   M /trunk/src/chrome/browser/search_engines/search_provider_install_data.h
   M /trunk/src/chrome/browser/search_engines/search_provider_install_data_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_test_util.h

Add support for Google base URL to SearchProviderInstallData.

BUG=38475
TEST=unit_tests --gtest_filter=SearchProviderInstallDataTest*

Review URL: http://codereview.chromium.org/3410010
------------------------------------------------------------------------
r59832 | mirandac@chromium.org | 2010-09-17 21:29:02 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

Make status bubble expand on Mac to fit URLs longer than the standard width.

BUG=43193, 55770
TEST=status bubble resizes on Mac to fit URLs longer than standard bubble size.

Review URL: http://codereview.chromium.org/3437002
------------------------------------------------------------------------
r59826 | kbr@google.com | 2010-09-17 21:05:46 +0200 (Fri, 17 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Fixed crash in DOM UI setup caused by lazy instantiation of the
DOMUIBindings. Added helper functions to lazily instantiate both
DOMUIBindings and ExternalHostBindings and call them from all access
sites in render_view.

Also incorporated re-enabling of InputFileTriggerFileBrowse test
thanks to xiyuan in http://codereview.chromium.org/3466001 .

BUG=55959
TEST=none

Review URL: http://codereview.chromium.org/3412011
------------------------------------------------------------------------
r59823 | aa@chromium.org | 2010-09-17 20:58:10 +0200 (Fri, 17 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Remove unnecessary LOG(INFO) lines from extensions system
that were creating logs of spam in test output.

TBR=shess@chromium.org
------------------------------------------------------------------------
r59821 | mlloyd@chromium.org | 2010-09-17 20:49:47 +0200 (Fri, 17 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Marking GeolocationBrowserTest.CancelpermissionsForFrame as flaky

BUG=56033
TEST=

------------------------------------------------------------------------
r59820 | tim@chromium.org | 2010-09-17 20:13:03 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_mock.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

Add Sources to several notifications.

BUG=none
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3400011
------------------------------------------------------------------------
r59819 | levin@chromium.org | 2010-09-17 20:11:43 +0200 (Fri, 17 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_provider_install_data.cc
   M /trunk/src/chrome/browser/search_engines/search_provider_install_data_unittest.cc
   M /trunk/src/tools/valgrind/tsan/suppressions.txt

Fix race in SearchProviderInstallDataTest (must delete SearchProviderInstallData on the I/O thread).

I also added several DCHECKs to make this bug apparent in a normal test run.

BUG=56002
TEST=unit_tests --gtest_filter=SearchProviderInstallDataTest.GetInstallState

Review URL: http://codereview.chromium.org/3383012
------------------------------------------------------------------------
r59815 | cmasone@google.com | 2010-09-17 20:01:22 +0200 (Fri, 17 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

DISABLE UnloadTest.BrowserCloseTabWhenOtherTabHasListener on windows

Per discussion with maruel and phajdan.jr, re-marking this test as DISABLED on windows.  It sometimes crashes, causing the remaining tests to be marked as failing.

TBR=estade
BUG=45281
TEST=UnloadTest.BrowserCloseTabWhenOtherTabHasListener doesn't run

Review URL: http://codereview.chromium.org/3421016
------------------------------------------------------------------------
r59797 | sky@chromium.org | 2010-09-17 18:17:29 +0200 (Fri, 17 Sep 2010) | 16 lines
Changed paths:
   D /trunk/src/chrome/browser/media_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/data/media/player_fullscreen.html
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Revert 59715 - Second try of http://codereview.chromium.org/3322009 since it got reverted.

Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.

Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.

Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.

TEST=ui_tests, interactive_ui_tests
BUG=54838


Review URL: http://codereview.chromium.org/3407003

TBR=imcheng@chromium.org
Review URL: http://codereview.chromium.org/3448008
------------------------------------------------------------------------
r59796 | sky@chromium.org | 2010-09-17 18:15:55 +0200 (Fri, 17 Sep 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/media_uitest.cc (from /trunk/src/chrome/browser/media_uitest.cc:59767)
   M /trunk/src/chrome/test/data/media/player.html
   D /trunk/src/chrome/test/data/media/player.js
   M /trunk/src/chrome/test/data/media/player_fullscreen.html

Revert 59768 - Refactoring of player[_fullscreen].html by placing the common functions in a js file. Also, removing media_uitest.cc which is now empty. (it was not removed on last commit due to some svn oddities)

BUG=none
TEST=MediaBrowserTest.*


Review URL: http://codereview.chromium.org/3454005

TBR=imcheng@chromium.org
------------------------------------------------------------------------
r59782 | rohitrao@chromium.org | 2010-09-17 14:28:32 +0200 (Fri, 17 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/base/mach_ipc_mac.h
   M /trunk/src/base/mach_ipc_mac.mm
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/mach_broker_mac.cc
   M /trunk/src/chrome/browser/mach_broker_mac.h
   M /trunk/src/chrome/browser/mach_broker_mac_unittest.cc

[Mac] Replace the existing browser-child mach ipc with a long-lived listener on a well-known port.

Before this CL:
Before fork()ing a child, the browser process creates a mach receive port with a random name.  After the fork() but before exec(), the child uses mach ipc to transmit send rights to its task port.  The child has access to the random name because it inherits it from the browser process.  Unfortunately, some of the library functions involved in sending a mach message are not safe to call after fork().

After this CL:
Before forking the first child, the browser spins off a new thread that listens on a well-known port for mach ipc from any process.  This well-known port is "com.google.Chrome.<browserpid>".  When a child process starts up, it sends a mach message to its parent browser's well-known port.  On the browser side, we listen for said message, extract the pid of the sending process, and ignore any messages from processes we did not personally fork().  This check is necessary because any arbitrary process on the system could send mach ipc to that port.

BUG=35374
TEST=Browser should still start up.  The task manager should still show correct cpu/memory data.  There should be no perf regressions.  
TEST=Mac ui_tests and browser_tests should be less flaky.
Review URL: http://codereview.chromium.org/3443002
------------------------------------------------------------------------
r59781 | jorlow@chromium.org | 2010-09-17 13:47:36 +0200 (Fri, 17 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.h

The Chromium side of implementing the IndexedDB base path stuff.
This allows Chromium to specify where IndexedDB files are stored.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3413010
------------------------------------------------------------------------
r59780 | jorlow@chromium.org | 2010-09-17 13:27:26 +0200 (Fri, 17 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbcursor_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbcursor_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.h

Add IDBIndex plumbing (for IndexedDB).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3442001
------------------------------------------------------------------------
r59777 | jochen@chromium.org | 2010-09-17 10:35:22 +0200 (Fri, 17 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html

Reland r59641. Add the onBeforeNavigate and onErrorOccured events to the webNavigation API.

Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.

BUG=50943
TEST=WebNavigationEvents

Review URL: http://codereview.chromium.org/3383008
------------------------------------------------------------------------
r59774 | dpolukhin@chromium.org | 2010-09-17 09:54:33 +0200 (Fri, 17 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h

Added tests for OOBE network screen

Add new tests instead of tests disabled in http://codereview.chromium.org/3166028

BUG=chromium-os:6672
TEST=browser_tests --gtest_filter=NetworkScreenTest.*

Review URL: http://codereview.chromium.org/3441008
------------------------------------------------------------------------
r59773 | pam@chromium.org | 2010-09-17 09:53:28 +0200 (Fri, 17 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/prefs/pref_service.cc
   M /trunk/src/chrome/browser/prefs/pref_service.h
   M /trunk/src/chrome/browser/prefs/pref_value_store.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.h
   M /trunk/src/chrome/browser/prefs/pref_value_store_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator_unittest.cc

Make pref service more robust against prefs that change their types without updating user pref values.

The outdated value will be ignored, but can be overwritten by a value of the correct type. Developers
who change types of prefs should provide migration functionality if needed. Changing the pref's path
(i.e., its name) is also advisable, but watch out that you don't leave an orphaned pref value in the
user pref file forever.

This change also moves tracking of preference types out of PrefService::Preference and into the
PrefValueStore, because the latter now needs to know the registered pref types. This is an
implementation change, only "externally" visible to unit tests.

BUG=55552
TEST=covered by unit tests; also, Chrome launched with a pre-June 2010 profile containing
    kWebkitInspectorSettings shouldn't crash
Review URL: http://codereview.chromium.org/3411011
------------------------------------------------------------------------
r59772 | kuan@chromium.org | 2010-09-17 09:44:10 +0200 (Fri, 17 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/proxy_config_service_impl.cc
   M /trunk/src/chrome/browser/chromeos/proxy_config_service_impl.h
   M /trunk/src/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

chromeos: implement persistence of proxy config to device, enhance unittest
- during storing, all info in proxy config is serialized into a dictionary and persisted to device via SignedSettings::StoragePropertyOp
- during retrieving, value is retrieved from device via SignedSettings::RetrievePropertyOp and deserialized into proxy config
- modify API to return bool when setting proxy config from UI
  - in DOMUI design, every interaction with the page triggers a call to update config in backend
  - but, sometimes, the info is incomplete, e.g. single-proxy checkbox is checked but proxy server is still empty
  - for such cases, config service caches the info (so that UI can get this info on the next Get), but doesn't activate or persist it, and returns false to UI
- wrote unittests for configuring socks proxy and bypass rules, serialize and deserialize, update unittest for code changes
- handle using stub implementation of libcros to make browser tests pass

BUG=chromium_os:5127
TEST=as owner, modify proxy config from UI, log out or reboot device, verify that proxy config is updated.

Review URL: http://codereview.chromium.org/3366028
------------------------------------------------------------------------
r59770 | isherman@chromium.org | 2010-09-17 07:28:12 +0200 (Fri, 17 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.mm

Update omnibox popup when selection changes.

The original motivation for this cl corresponds to bug 47210: If the user changes the selection by arrowing around in the omnibox, we should detect this as accepting the inline autocomplete suggestion.  Otherwise, if the user subsequently presses ctrl (e.g. as part of the keystroke ctrl-d to perform a forward delete), the omnibox contents are reverted as if the user had never arrowed around.

The other motivation is just to match the behavior on Windows, which detects changes to the selection.

BUG=47210
TEST=none

Review URL: http://codereview.chromium.org/3126024
------------------------------------------------------------------------
r59768 | imcheng@chromium.org | 2010-09-17 06:32:09 +0200 (Fri, 17 Sep 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/chrome/test/data/media/player.html
   A /trunk/src/chrome/test/data/media/player.js
   M /trunk/src/chrome/test/data/media/player_fullscreen.html

Refactoring of player[_fullscreen].html by placing the common functions in a js file. Also, removing media_uitest.cc which is now empty. (it was not removed on last commit due to some svn oddities)

BUG=none
TEST=MediaBrowserTest.*


Review URL: http://codereview.chromium.org/3454005
------------------------------------------------------------------------
r59765 | levin@chromium.org | 2010-09-17 06:10:08 +0200 (Fri, 17 Sep 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/search_engines/search_provider_install_data.cc
   M /trunk/src/chrome/browser/search_engines/search_provider_install_data.h
   A /trunk/src/chrome/browser/search_engines/search_provider_install_data_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implement SearchProviderInstallData.

Support for Google base URL will be in another patch.

BUG=38475
TEST=unit_tests --gtest_filter=SearchProviderInstallDataTest*

Review URL: http://codereview.chromium.org/3403008
------------------------------------------------------------------------
r59764 | yusukes@chromium.org | 2010-09-17 05:21:56 +0200 (Fri, 17 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_add_language_overlay.js

Remove unused code.

The click event of add-language-overlay-language-list is handled by
handleAddLanguageListClick_ in chromeos_language_options.js.
So the temporarily commented out code is not needed in the first place.

BUG=chromium-os:6713
TEST=manually on the net book

Review URL: http://codereview.chromium.org/3452005
Patch from Yasuhiro Matsuda <mazda@chromium.org>.
------------------------------------------------------------------------
r59761 | inferno@chromium.org | 2010-09-17 02:53:54 +0200 (Fri, 17 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc

FileBrowseBrowserTest.InputFileTriggerFileBrowser fails on linux bots.

BUG=55959

------------------------------------------------------------------------
r59748 | kkanetkar@chromium.org | 2010-09-17 01:05:14 +0200 (Fri, 17 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/chrome_file_system_operation.h
   D /trunk/src/chrome/browser/file_system/file_system_operation_unittest.cc
   M /trunk/src/webkit/fileapi/file_system_operation.h

Unittest renamed to chrome_file_system_operation_unittest.cc. Deleting original one.
Svn rename didn't quite work. Also changed the comments in operations file to have clearer
message.

BUG=None
TEST=none

Review URL: http://codereview.chromium.org/3415012
------------------------------------------------------------------------
r59746 | thestig@chromium.org | 2010-09-17 01:03:08 +0200 (Fri, 17 Sep 2010) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/cros/cros_api.gyp
   D /trunk/src/chrome/test/data/History/history_length_test1.html
   D /trunk/src/chrome/test/data/History/history_length_test2.html
   D /trunk/src/gfx/font_gtk.cc

Cleanup: Delete some 0 byte sized files that we no longer reference.

BUG=none
TEST=none
------------------------------------------------------------------------
r59741 | akalin@chromium.org | 2010-09-17 00:27:24 +0200 (Fri, 17 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   M /trunk/src/jingle/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/jingle/notifier/listener/talk_mediator_impl.h
   M /trunk/src/jingle/notifier/listener/talk_mediator_unittest.cc

Removed TalkMediator SSL initialization.

Since we're now using chrome sockets, we don't need this code.

BUG=54146
TEST=Unit tests

Review URL: http://codereview.chromium.org/3411012
------------------------------------------------------------------------
r59733 | sky@chromium.org | 2010-09-16 23:57:45 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/browser/aeropeek_manager.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.cc
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.h
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/cocoa/applescript/window_applescript.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window_unittest.mm
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/platform_util_chromeos.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   A /trunk/src/chrome/browser/tabs/tab_strip_model_delegate.h
   A /trunk/src/chrome/browser/tabs/tab_strip_model_observer.cc
   A /trunk/src/chrome/browser/tabs/tab_strip_model_observer.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Moves TabStripModelObserver/Delegate into their own headers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3425009
------------------------------------------------------------------------
r59726 | asargent@chromium.org | 2010-09-16 23:39:29 +0200 (Thu, 16 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.cc
   A /trunk/src/chrome/browser/extensions/extension_icon_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension_action_unittest.cc
   M /trunk/src/gfx/skia_util.cc
   M /trunk/src/gfx/skia_util.h

Fix problem with extension context menu items losing top-level icon.

If an extension adds some context menu items, then removes them all, and adds
some more, instead of their actual icon the new items will get the default
extension icon in context menus. This is because we use the caching feature of
ImageLoadingTracker and get an immediate callback from LoadImage before we've
put the request in pending_icons_.

BUG=53543
TEST=Steps are outlined in bug report.

Review URL: http://codereview.chromium.org/3425007
------------------------------------------------------------------------
r59716 | xiyuan@chromium.org | 2010-09-16 23:06:20 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js

Hook users DOMUI with backend.

BUG=chromium-os:968
TEST=Verify users settings are persisted per machine correctly and only owner is allowed to make changes.

Review URL: http://codereview.chromium.org/3403007
------------------------------------------------------------------------
r59715 | imcheng@chromium.org | 2010-09-16 23:03:09 +0200 (Thu, 16 Sep 2010) | 13 lines
Changed paths:
   A /trunk/src/chrome/browser/media_browsertest.cc
   R /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/media/player_fullscreen.html
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Second try of http://codereview.chromium.org/3322009 since it got reverted.

Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.

Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.

Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.

TEST=ui_tests, interactive_ui_tests
BUG=54838


Review URL: http://codereview.chromium.org/3407003
------------------------------------------------------------------------
r59712 | bryeung@chromium.org | 2010-09-16 22:59:42 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/keyboard_ui.cc
   A /trunk/src/chrome/browser/dom_ui/keyboard_ui.h
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   A /trunk/src/chrome/browser/resources/keyboard
   A /trunk/src/chrome/browser/resources/keyboard/index.html
   A /trunk/src/chrome/browser/resources/keyboard/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard/keyboard.html
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard_fails
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard_fails/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard_fails/keyboard.html
   A /trunk/src/chrome/test/data/extensions/api_test/override/keyboard_fails/manifest.json

Add a placeholder, overridable DOMUI keyboard.

This change does not add support for displaying the keyboard.  That will be provided (along with a more useful keyboard) in follow-up changes.

BUG=none
TEST=added new override test

Review URL: http://codereview.chromium.org/3362019
------------------------------------------------------------------------
r59709 | levin@chromium.org | 2010-09-16 22:44:08 +0200 (Thu, 16 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model_test_util.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc

Make the test code that changes the GoogleBaseURL do a notification (instead of
directly calling a method) to more closely mimic the way this usually happens.

This is being done to avoid making special "update GoogleBaseURL" method
calls both here and in future tests, and helps ensure that the notification
observer code is set-up correctly.

BUG=38475
TEST=unit_tests --gtest_filter=Temp*

Review URL: http://codereview.chromium.org/3420007
------------------------------------------------------------------------
r59708 | erg@google.com | 2010-09-16 22:43:44 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK: Cleanup MenuGtk to use signals thunk macros.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3426006
------------------------------------------------------------------------
r59703 | thakis@chromium.org | 2010-09-16 22:10:53 +0200 (Thu, 16 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm

Mac: Add a few more keyboard shortcuts to tabpose.

* shift / tab-shift cycle through all open tabs
* arrow keys move selection up, down, left, right
* cmd-1-8 selects tab 1-8 and exits tabpose, cmd-9 selects last tab and exits tabpose
* cmd-ctrl-t exits tabpose

BUG=50307,55530
TEST=try it

Review URL: http://codereview.chromium.org/3389010
------------------------------------------------------------------------
r59701 | evan@chromium.org | 2010-09-16 21:50:59 +0200 (Thu, 16 Sep 2010) | 48 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   A /trunk/src/testing/gmock/CMakeLists.txt
   M /trunk/src/testing/gmock/Makefile.am
   M /trunk/src/testing/gmock/README
   M /trunk/src/testing/gmock/include/gmock/gmock-actions.h
   M /trunk/src/testing/gmock/include/gmock/gmock-generated-function-mockers.h
   M /trunk/src/testing/gmock/include/gmock/gmock-generated-function-mockers.h.pump
   M /trunk/src/testing/gmock/include/gmock/gmock-generated-matchers.h
   M /trunk/src/testing/gmock/include/gmock/gmock-generated-matchers.h.pump
   M /trunk/src/testing/gmock/include/gmock/gmock-matchers.h
   M /trunk/src/testing/gmock/include/gmock/gmock-more-actions.h
   D /trunk/src/testing/gmock/include/gmock/gmock-printers.h
   M /trunk/src/testing/gmock/include/gmock/gmock-spec-builders.h
   M /trunk/src/testing/gmock/include/gmock/gmock.h
   M /trunk/src/testing/gmock/include/gmock/internal/gmock-internal-utils.h
   M /trunk/src/testing/gmock/include/gmock/internal/gmock-port.h
   M /trunk/src/testing/gmock/make/Makefile
   M /trunk/src/testing/gmock/msvc/gmock-spec-builders_test.vcproj
   M /trunk/src/testing/gmock/run_tests.py
   M /trunk/src/testing/gmock/scripts/gmock-config.in
   M /trunk/src/testing/gmock/scripts/gmock_doctor.py
   D /trunk/src/testing/gmock/scripts/test/Makefile
   M /trunk/src/testing/gmock/src/gmock-all.cc
   D /trunk/src/testing/gmock/src/gmock-printers.cc
   M /trunk/src/testing/gmock/test/gmock-actions_test.cc
   M /trunk/src/testing/gmock/test/gmock-generated-matchers_test.cc
   M /trunk/src/testing/gmock/test/gmock-internal-utils_test.cc
   M /trunk/src/testing/gmock/test/gmock-matchers_test.cc
   M /trunk/src/testing/gmock/test/gmock-nice-strict_test.cc
   M /trunk/src/testing/gmock/test/gmock-port_test.cc
   D /trunk/src/testing/gmock/test/gmock-printers_test.cc
   M /trunk/src/testing/gmock/test/gmock-spec-builders_test.cc
   M /trunk/src/testing/gmock/test/gmock_all_test.cc
   M /trunk/src/testing/gmock/test/gmock_output_test.py
   M /trunk/src/testing/gmock/test/gmock_output_test_golden.txt
   M /trunk/src/testing/gmock/test/gmock_test_utils.py
   M /trunk/src/testing/gmock.gyp
   M /trunk/src/testing/gtest.gyp

clang: update gtest to r435 and gmock to r300.

This picks up some clang-specific fixes.
Unfortunately, the gtest update cascaded into a gmock update.
So I picked the earliest gmock version that mentioned a specific
gtest version so that they are more likely to work together.

gtest changelog:
- Fixes a leak in ThreadLocal.
- CMake 2.8/Visual Age compatibility patch by Hady Zalek.
- C++ Builder compatibility patch by Josh Kelley.
- Fixes gtest_filter_unittest and gtest_help_test on systems without death tests.
- Simplifies Makefile.am (by Zhanyong Wan and Vlad Losev).
- Adds alternative spellings for FAIL, SUCCEED, and TEST.
- Over-hauls README, and fixes Makefile.
- Fixes gtest-port_test on MinGW.
- Implements color output in GNU Screen sessions (issue 277).
- Minor improvement to hermetic build support in the CMake script, by Vlad Losev.
- Improves support for building Google Test as Windows DLL.
- Silence a Clang warning about an unused variable.
- Moves the universal printer from gmock to gtest and refactors the cmake script for reusing in gmock (by Vlad Losev).
- Suppresses some Clang warnings (by Chandler Carruth, Jeffrey Yasskin, and Zhanyong Wan).
- Renames CMake build script options.
- Lucid autotools compatibility patch by Jeffrey Yasskin.
- Replaces UniversalPrinter<T>::Print(x, os) with UniversalPrint(x, os) as appropriate (by Zhanyong Wan).
- Comment tweaks in CMakeLists.txt.
- Renames test script flags.
- Fixes a typo in comments.
- Adds GTEST_REMOVE_REFERENCE_AND_CONST_.
- Introduces gtest_force_shared_crt option for CMake build scripts.
- Implements printing parameters of failed parameterized tests (issue 71).

gmock changelog:
- Improves Makefile.am (by Vlad Losev); fixes Makefile and updates README (by Zhanyong Wan).
- Fixes a typo in README.
- Adds Each(m) (by Wojtek Moczydlowski); removes scripts/test/Makefile (by Zhanyong Wan); pulls in gtest r424.
- Adds a synchronization test.
- Fixes tests leaking altered values of GMOCK_FLAG(verbose) (issue 110).
- Moves the universal printer from gmock to gtest (by Vlad Losev).
- Renames test script flags.
- Adds CMake build script.
- Implements Pointwise().
- Fixes build failure on Windows/CMake (issue 111).
- Pulls r435 of gtest. This brings in the gtest_force_shared_crt option in CMake.

TEST=all existing tests should still pass

Review URL: http://codereview.chromium.org/3427004
------------------------------------------------------------------------
r59697 | dumi@chromium.org | 2010-09-16 21:44:32 +0200 (Thu, 16 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   M /trunk/src/chrome/common/render_messages_internal.h

Change the FileSystem IPCs to take FilePaths as arguments instead of
string16s. FilePaths are better than string16s, because pepper uses
FilePaths, and for the WebFileSystem API it doesn't matter, because it
needs to do the string16 --> FilePath conversion once.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3383003
------------------------------------------------------------------------
r59696 | thestig@chromium.org | 2010-09-16 21:44:09 +0200 (Thu, 16 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.h

Linux: Fix pure call in CrashHandlerHostLinux::Init().

BUG=55780
TEST=no more random crashes on startup.
Review URL: http://codereview.chromium.org/3417005
------------------------------------------------------------------------
r59693 | ctguil@chromium.org | 2010-09-16 21:38:46 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/webkit/glue/webaccessibility.h

Remove use of accessible prop service from render_widget_host_view_win.cc

BUG=none
TEST=interactive_iu_tests:AccessibilityWinBrowserTest.TestRendererAccessibilityTree

Review URL: http://codereview.chromium.org/3415008
------------------------------------------------------------------------
r59692 | levin@chromium.org | 2010-09-16 21:38:44 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model_test_util.cc

Remove the code that shall not be used in tests: PathService::Get(base::DIR_TEMP

Use ScopedTempDir instead.

BUG=38475
TEST=unit_tests --gtest_filter=Temp*

Review URL: http://codereview.chromium.org/3423010
------------------------------------------------------------------------
r59690 | ctguil@chromium.org | 2010-09-16 21:37:46 +0200 (Thu, 16 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc

Fix browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree for all platforms.

- Remove sending of ViewMsg_GetAccessibilityTree. It can request the accessibility tree before the page is loaded.
- Remove use of std::string::c_str() when the object is out of scope.
- Initialize COM on windows.

BUG=53853
TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree

Review URL: http://codereview.chromium.org/3424011
------------------------------------------------------------------------
r59689 | levin@chromium.org | 2010-09-16 21:29:09 +0200 (Thu, 16 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   A /trunk/src/chrome/browser/search_engines/template_url_model_test_util.cc
   A /trunk/src/chrome/browser/search_engines/template_url_model_test_util.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Make a utility test class that is useful to any code which is trying to create
a TemplateURLModel and persist it.

This only affects test code and should have no functionality change (just code
re-arrangement).

This change prepares the way for an implementation of SearchProviderInstallData
and a unit test for it.

BUG=38475
TEST=unit_tests --gtest_filter=Temp*

Review URL: http://codereview.chromium.org/3422006
------------------------------------------------------------------------
r59686 | agl@chromium.org | 2010-09-16 21:24:45 +0200 (Thu, 16 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/net/base/cert_status_flags.cc
   M /trunk/src/net/base/cert_status_flags.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc

Show "DNS" as the authority for DNSSEC validated certficiates.

At the moment, if we validate a certificate using DNSSEC the Page Info
dialog will show whatever Issuer the site chose as the issuing
authority. That's confusing because the site could choose a string
like 'US Dept of Homeland Security' (for example) which is misleading.

This patch forces the authority string to always be "DNSSEC" in the
case that we used DNSSEC to validate the certificate.

(The string "DNSSEC" isn't translated as it's an acronym.)

BUG=none
TEST=none

http://codereview.chromium.org/3304016/show
------------------------------------------------------------------------
r59684 | thakis@chromium.org | 2010-09-16 21:18:46 +0200 (Thu, 16 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Fix concurrent access on a non-threadsafe data structure.

Also remove a call to cocoa from the non-ui thread.

DrawAcceleratedSurfaceInstance is called on the display link thread. plugin_views_ can be written to from the main thread. Since the map is only used to get the view's size, pass in the size right away.

There's another problem like this in plugin_container_manager_, which also has a map that is accessed from two threads. I will address this in a follow-up CL.

BUG=52491
TEST=none

Review URL: http://codereview.chromium.org/3431011
------------------------------------------------------------------------
r59678 | rohitrao@chromium.org | 2010-09-16 19:31:31 +0200 (Thu, 16 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Size popup windows correctly.

BUG=48428
TEST=Popup windows should open with the correct content size (while still respecting the 400x250 minimum window size).
Review URL: http://codereview.chromium.org/3408003
------------------------------------------------------------------------
r59669 | mnissler@chromium.org | 2010-09-16 18:46:17 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_store.h

Clean up policy tests.

Refactor the unit tests for the various ConfigurationPolicyProvider implementations and the ConfigurationPolicyPrefStore, so they are more modular and it becomes easy to add tests for new policies. Also make sure all the existing policies get test coverage.

BUG=none
TEST=compiles and passes unit tests

Review URL: http://codereview.chromium.org/3311005
------------------------------------------------------------------------
r59667 | xiyuan@chromium.org | 2010-09-16 18:39:33 +0200 (Thu, 16 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/signed_settings_helper.cc
   M /trunk/src/chrome/browser/chromeos/login/signed_settings_helper.h
   M /trunk/src/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

Improvements of SignedSettingsHelper:

- Fixed a bug that helper gets stuck waiting for never-happening callback
  when op's Executed returns false;
- Change Cancel -> CancelCallback and execute all pending ops even when its
  callbacks are canceled. This makes sure that settings change are applied
  even user dismisses UI before the ops complete;
- Update unit tests accordingly;

BUG=chromium-os:968
TEST=none.

Review URL: http://codereview.chromium.org/3443004
------------------------------------------------------------------------
r59666 | xiyuan@chromium.org | 2010-09-16 18:37:33 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/cellular_config_view.cc

Use net-yet-implemented message in cellular config view to avoid confusion.

BUG=none
TEST=Verify celluar config view shows not-yet-implemented info instead of fake data.

Review URL: http://codereview.chromium.org/3397006
------------------------------------------------------------------------
r59665 | xiyuan@chromium.org | 2010-09-16 18:36:16 +0200 (Thu, 16 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc

Change CorsSettings::Get's assumption of who owns the returned value.

This is because most of the settings providers and
CoreChromeOSOptionsHandler::NotifySettingsChanged assumes the caller
would own the returned value.

BUG=none.
TEST=none.

Review URL: http://codereview.chromium.org/3382008
------------------------------------------------------------------------
r59658 | estade@chromium.org | 2010-09-16 18:14:40 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

[GTK] adjust GtkFloatingContainer child allocation calculation.

Offset the floating child position coordinates by the container's allocation. This prevents floating children from attempting to position themselves outside the floating container.

BUG=52595
TEST=see bug

Review URL: http://codereview.chromium.org/3424009
------------------------------------------------------------------------
r59657 | estade@chromium.org | 2010-09-16 18:01:18 +0200 (Thu, 16 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

[GTK] Apply SetLabelWidth workaround in more places.

- first run search engine ballot explanatory text
- first run bubble text
- sync setup label in options dialog's second tab

BUG=54898
TEST=all places listed above look good in LTR and at least ok in RTL

Review URL: http://codereview.chromium.org/3443006
------------------------------------------------------------------------
r59649 | sky@chromium.org | 2010-09-16 17:40:21 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/labs.cc

Adds instant to about:labs.

BUG=54833
TEST=go to about:labs on windows and make sure you see a section for instant

Review URL: http://codereview.chromium.org/3387004
------------------------------------------------------------------------
r59646 | dilmah@chromium.org | 2010-09-16 16:21:07 +0200 (Thu, 16 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/burn_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/burn_library.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/imageburner_ui.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_settings_provider.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.h
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   M /trunk/src/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/signed_settings_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/network_state_notifier_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_service.cc
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_service.h
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.cc
   M /trunk/src/chrome/browser/chromeos/update_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_fav_icon.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.h

Google codestyle prescribes sorting #include filenames within a section.
Do it fast with following shell script:

export LC_ALL=C
find chrome/browser/chromeos/ -name '*.h' -o -name '*.cc' \
  | xargs grep -C1 '^#include' \
  | awk -F: '$2 !~ "include" { prev=""; next } ($2 <= prev) { print $1 } { prev=$2 }' \
  | uniq \
  | xargs -n1 sh -c 'cat "$1" \
                       | awk "{ tag=((/^#include/) \"_\" (/</) \"_\" (/third.party/)); print tag \"\t\" \$0 }" \
                       | awk -vi=0 -F\\t "{ if (!/^1_0_/ || \$1 != prev) { ++i } } { printf \"%09d\t%s\n\",i,\$0; prev=\$1 }" \
                       | sort \
                       | sed "s/^[0-9]*\t[0-9]_[0-9]_[0-9]\t//" > "$1".fixed; mv -f "$1".fixed "$1"' xxx

BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/3402010
------------------------------------------------------------------------
r59645 | joth@chromium.org | 2010-09-16 15:56:23 +0200 (Thu, 16 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

LoginPromptTest.TestDigestAuth is also flaky due to NavigateToURL failing

BUG=55380
TEST=LoginPromptTest.TestDigestAuth
TBR=thomasvl@chromium.org
------------------------------------------------------------------------
r59644 | mmenke@chromium.org | 2010-09-16 15:42:27 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/loggrouper.js

Fix a bug in determining a LogGroupEntry's parent in net-internals.  Only noticeable when end events missing from log.

BUG=54879
TEST=manual

Review URL: http://codereview.chromium.org/3450009
------------------------------------------------------------------------
r59642 | jochen@chromium.org | 2010-09-16 15:00:33 +0200 (Thu, 16 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html

Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webNavigation API.

Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.

The frameId and the requestId fields are still unimplemented.

Also, there occur navigation events after an error is reported.

BUG=50943
TEST=WebNavigationEvents

Review URL: http://codereview.chromium.org/3436002

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3389012
------------------------------------------------------------------------
r59641 | jochen@chromium.org | 2010-09-16 14:41:15 +0200 (Thu, 16 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html

Add the onBeforeNavigate and onErrorOccured events to the webNavigation API.

Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.

The frameId and the requestId fields are still unimplemented.

Also, there occur navigation events after an error is reported.

BUG=50943
TEST=WebNavigationEvents

Review URL: http://codereview.chromium.org/3436002
------------------------------------------------------------------------
r59639 | joth@chromium.org | 2010-09-16 14:14:38 +0200 (Thu, 16 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

LoginPromptTest.TestBasicAuth is also flaky due to NavigateToURL failing

BUG=55380
TEST=LoginPromptTest.TestBasicAuth
TBR=thomasvl@chromium.org
------------------------------------------------------------------------
r59638 | satish@chromium.org | 2010-09-16 14:07:57 +0200 (Thu, 16 Sep 2010) | 15 lines
Changed paths:
   D /trunk/src/chrome/app/theme/speech_input_recording.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/cocoa/speech_input_window_controller.mm
   M /trunk/src/chrome/browser/speech/endpointer/endpointer.cc
   M /trunk/src/chrome/browser/speech/endpointer/endpointer.h
   M /trunk/src/chrome/browser/speech/endpointer/endpointer_unittest.cc
   M /trunk/src/chrome/browser/speech/endpointer/energy_endpointer.cc
   M /trunk/src/chrome/browser/speech/endpointer/energy_endpointer.h
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller.h
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller_unittest.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm
   M /trunk/src/chrome/browser/speech/speech_input_bubble_views.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc

Show a volume indicator as audio is being recorded.
Per UX input from Cole, this matches the implementation in the android voice actions app.

Changes in this CL:
- Instead of the old mic icon use the recently added mic-volume-empty, mic-volume-full and mask images for the volume indicator.
- Extended the endpointer code to return the audio RMS level (copied from the original source).
- SpeechRecognizer receives the above calculated RMS level and computes a volume level in the [0.0-1.0] range.
- SpeechInputManager receives the above computed volume level and passes it to SpeechInputBubbleController for display, which passes it to SpeechInputBubble.
- SpeechInputBubbleBase creates the appropriate skia bitmap for the volume indicator and passes to the platform specific code for display.
- As part of the above SpeechInputBubbleController addition for volume level, I wrote a single function to process all calls received by it and handled in the UI thread for simplicity.

BUG=53598
TEST=updated existing tests. Also test manually, use speech input and verify the audio level changes appropriately in the UI as mic is moved near and far.

Review URL: http://codereview.chromium.org/3384005
------------------------------------------------------------------------
r59635 | mnissler@chromium.org | 2010-09-16 13:23:17 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/plugin_group_unittest.cc

Support wildcards for policy-controlled plugin blacklists.

BUG=53158
TEST=Configure wildcard blacklist pattern and check whether plugins get disabled in about:plugins.

Review URL: http://codereview.chromium.org/3435001
------------------------------------------------------------------------
r59634 | mseaborn@chromium.org | 2010-09-16 12:03:09 +0200 (Thu, 16 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux zygote: Fix race condition when using SUID + seccomp sandboxes

Change the child process to synchronise with the parent (the zygote)
so that the child does not fork further children while the zygote is
trying to discover the child's real PID from the SUID helper.

Split the logic for doing METHOD_GET_CHILD_WITH_INODE into a separate
function.  Add a pipe for doing the synchronisation.

Now that the child synchronises, it can close dummy_fd.

BUG=55599
TEST=Tested manually with:
  cd native_client && ./tools/httpd.py &
  CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox ./out/Debug/chrome-wrapper --enable-nacl --enable-seccomp-sandbox http://localhost:5103/tests/prebuilt/srpc_hw.html

Review URL: http://codereview.chromium.org/3391003
------------------------------------------------------------------------
r59630 | mseaborn@chromium.org | 2010-09-16 11:46:59 +0200 (Thu, 16 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux sandbox: Allow seccomp sandbox to be stacked on top of the SUID sandbox

Since this mostly worked before, this is just a matter of reordering
some "if" clauses.

Before this change, --enable-seccomp-sandbox would have the side
effect of disabling the SUID sandbox.  The zygote would get run
through the SUID helper, but the zygote would never send the message
to turn the SUID sandbox on.

Change this so that --enable-seccomp-sandbox does not disable the SUID
sandbox.

BUG=55599
TEST=Tested manually with:
  cd native_client && ./tools/httpd.py &
  CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox ./out/Debug/chrome-wrapper --enable-nacl --enable-seccomp-sandbox http://localhost:5103/tests/prebuilt/srpc_hw.html

Review URL: http://codereview.chromium.org/3449001
------------------------------------------------------------------------
r59629 | akalin@chromium.org | 2010-09-16 11:23:27 +0200 (Thu, 16 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/jingle/jingle.gyp
   D /trunk/src/jingle/notifier/base/sigslotrepeater.h
   M /trunk/src/jingle/notifier/base/task_pump.cc
   M /trunk/src/jingle/notifier/base/task_pump.h
   A /trunk/src/jingle/notifier/base/weak_xmpp_client.cc
   A /trunk/src/jingle/notifier/base/weak_xmpp_client.h
   A /trunk/src/jingle/notifier/base/weak_xmpp_client_unittest.cc
   A /trunk/src/jingle/notifier/base/xmpp_connection.cc
   A /trunk/src/jingle/notifier/base/xmpp_connection.h
   A /trunk/src/jingle/notifier/base/xmpp_connection_unittest.cc
   M /trunk/src/jingle/notifier/communicator/connection_settings.cc
   M /trunk/src/jingle/notifier/communicator/connection_settings.h
   M /trunk/src/jingle/notifier/communicator/login.cc
   M /trunk/src/jingle/notifier/communicator/login.h
   D /trunk/src/jingle/notifier/communicator/login_connection_state.h
   D /trunk/src/jingle/notifier/communicator/login_failure.cc
   D /trunk/src/jingle/notifier/communicator/login_failure.h
   M /trunk/src/jingle/notifier/communicator/login_settings.cc
   M /trunk/src/jingle/notifier/communicator/login_settings.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.h
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/tools/valgrind/chrome_tests.py

Refactored handling of XmppClient.

Added new classes WeakXmppClient and XmppConnection, which let me
simplify MediatorThreadImpl et al.

BUG=55302
TEST=new unit tests, manually

Review URL: http://codereview.chromium.org/3290025
------------------------------------------------------------------------
r59626 | jorlow@chromium.org | 2010-09-16 11:14:06 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Clarify some comments from a recent patch that changes TabContents.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3423004
------------------------------------------------------------------------
r59624 | dilmah@chromium.org | 2010-09-16 10:31:45 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h

Make Enter and Esc keys work at wi-fi password dialog.

BUG=http://crosbug.com/6620
TEST=Manual

Review URL: http://codereview.chromium.org/3429007
------------------------------------------------------------------------
r59621 | jochen@chromium.org | 2010-09-16 09:48:19 +0200 (Thu, 16 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_terms_data.cc

Reland r59492. Do not include RLZ parameters in search requests for organic installs.

BUG=55363
TEST=none
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/3404005
------------------------------------------------------------------------
r59619 | tim@chromium.org | 2010-09-16 08:29:42 +0200 (Thu, 16 Sep 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 59618 - Get password sync to a usable state.

Plumb the gaia password up to the cryptographer to generate an
encryption key.
Add NIGORI to the list of active datatypes to request if
enable-sync-passwords is specified.

Also fixes behavior from bug 55501 (required adding ExtraChangeRecordData to syncapi), as well as an ADD-handling bug in ApplyChangesFromSyncModel.

Add back the call to Cryptographer::Bootstrap which was mistakenly removed in auth refactor.

This patch doesn't have necessary UI to handle secondary passphrases,
password changes, or existing user upgrades.  Only unsynced profiles
can currently get password sync working.

BUG=48702,32410, 55501
TEST=ProfileSyncPasswordTest, upcoming password integration tests

Review URL: http://codereview.chromium.org/3295026

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3419003
------------------------------------------------------------------------
r59618 | tim@chromium.org | 2010-09-16 08:03:45 +0200 (Thu, 16 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Get password sync to a usable state.

Plumb the gaia password up to the cryptographer to generate an
encryption key.
Add NIGORI to the list of active datatypes to request if
enable-sync-passwords is specified.

Also fixes behavior from bug 55501 (required adding ExtraChangeRecordData to syncapi), as well as an ADD-handling bug in ApplyChangesFromSyncModel.

Add back the call to Cryptographer::Bootstrap which was mistakenly removed in auth refactor.

This patch doesn't have necessary UI to handle secondary passphrases,
password changes, or existing user upgrades.  Only unsynced profiles
can currently get password sync working.

BUG=48702,32410, 55501
TEST=ProfileSyncPasswordTest, upcoming password integration tests

Review URL: http://codereview.chromium.org/3295026
------------------------------------------------------------------------
r59617 | pfeldman@chromium.org | 2010-09-16 06:50:41 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/extensions/extension_localization_peer.cc
   M /trunk/src/chrome/common/extensions/extension_localization_peer.h
   M /trunk/src/chrome/common/extensions/extension_localization_peer_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/safe_browsing/render_view_fake_resources_test.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.h
   M /trunk/src/webkit/glue/media/buffered_data_source_unittest.cc
   M /trunk/src/webkit/glue/media/simple_data_source.cc
   M /trunk/src/webkit/glue/media/simple_data_source.h
   M /trunk/src/webkit/glue/media/simple_data_source_unittest.cc
   M /trunk/src/webkit/glue/multipart_response_delegate_unittest.cc
   M /trunk/src/webkit/glue/plugins/pepper_url_loader.cc
   M /trunk/src/webkit/glue/plugins/pepper_url_loader.h
   M /trunk/src/webkit/glue/plugins/pepper_webplugin_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.h
   M /trunk/src/webkit/glue/resource_fetcher.cc
   M /trunk/src/webkit/glue/resource_fetcher.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

DevTools: report network stack-based finish time for resources.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3385004
------------------------------------------------------------------------
r59616 | kkanetkar@chromium.org | 2010-09-16 06:46:14 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/DEPS
   A /trunk/src/chrome/browser/file_system/chrome_file_system_operation.cc
   A /trunk/src/chrome/browser/file_system/chrome_file_system_operation.h
   A /trunk/src/chrome/browser/file_system/chrome_file_system_operation_unittest.cc (from /trunk/src/chrome/browser/file_system/file_system_operation_unittest.cc:59424)
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   D /trunk/src/chrome/browser/file_system/file_system_operation.cc
   D /trunk/src/chrome/browser/file_system/file_system_operation.h
   D /trunk/src/chrome/browser/file_system/file_system_operation_client.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/webkit/fileapi
   A /trunk/src/webkit/fileapi/file_system_operation.cc
   A /trunk/src/webkit/fileapi/file_system_operation.h
   A /trunk/src/webkit/fileapi/file_system_operation_client.h
   A /trunk/src/webkit/fileapi/webkit_fileapi.gypi
   M /trunk/src/webkit/support/test_webkit_client.cc
   M /trunk/src/webkit/support/test_webkit_client.h
   M /trunk/src/webkit/support/webkit_support.gyp
   M /trunk/src/webkit/support/webkit_support.gypi
   A /trunk/src/webkit/tools/test_shell/simple_file_system.cc
   A /trunk/src/webkit/tools/test_shell/simple_file_system.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Test shell impl for WebKit's File System API:BUG=52799TEST=none

Also refactored a bunch of code from chrome/browser to webkit/fileapi for reuse.
Added class hierarchy. Test shell and browser operations now inherit from
common webkit/fileapi/file_system_operation.


Review URL: http://codereview.chromium.org/3186009
------------------------------------------------------------------------
r59614 | jar@chromium.org | 2010-09-16 06:12:15 +0200 (Thu, 16 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/url_info.cc

Reduce fieldtrials percentages for push to stable M7

In one case, completely removed the field trial.

BUG=55634
r=mbelshe,willchan
Review URL: http://codereview.chromium.org/3449003
------------------------------------------------------------------------
r59613 | tfarina@chromium.org | 2010-09-16 05:44:22 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Move ExtensionsServiceBackend class into the .cc file.

(Note: This was a TODO for Aaron).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3429003
------------------------------------------------------------------------
r59612 | zork@chromium.org | 2010-09-16 05:36:51 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc

Add functions to watch the ibus connection.

BUG=chromium-os:6554
TEST=kill ibus-daemon and check that candidate_window shuts down.

Review URL: http://codereview.chromium.org/3429002
------------------------------------------------------------------------
r59611 | skerner@chromium.org | 2010-09-16 04:56:17 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/common/tabs_util.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test_jpeg.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test_png.js

Do not resize image before testing pixel colors in browser test.  Only crop.

Scaling would change the color of pixels, causing test failure.

BUG=51761
TEST=ExtensionApiTest.CaptureVisibleTabPng

Review URL: http://codereview.chromium.org/3395004
------------------------------------------------------------------------
r59608 | thestig@chromium.org | 2010-09-16 04:35:10 +0200 (Thu, 16 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_terms_data.cc

Revert 59492 - Do not include RLZ parameters in search requests for organic installs.

BUG=55363
TEST=none

Review URL: http://codereview.chromium.org/3324017

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3406004
------------------------------------------------------------------------
r59607 | arv@chromium.org | 2010-09-16 04:14:42 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/css/menu.css

DOMUI: Don't paint menu separators as selected

BUG=55798
TEST=Go to bookmark manager
     Right click the list
     Mouse over and mousedown on a separator. It should not change color.

Review URL: http://codereview.chromium.org/3381007
------------------------------------------------------------------------
r59606 | arv@chromium.org | 2010-09-16 04:08:07 +0200 (Thu, 16 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js

Bookmark Manager: Handle multiple right clicks correctly.

BUG=52291
TEST=Go to bookmark manager.
     Right click a bookmark.
     Right click another bookmark. This should open a new context menu
     Right click "Edit...". This should start editing the item.

Review URL: http://codereview.chromium.org/3395006
------------------------------------------------------------------------
r59605 | cmasone@google.com | 2010-09-16 03:58:04 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h

[chrome os] Add async method for removing cryptohomes

BUG=None
TEST=unit tests

Review URL: http://codereview.chromium.org/3440005
------------------------------------------------------------------------
r59601 | sergeyu@chromium.org | 2010-09-16 03:15:45 +0200 (Thu, 16 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/media/audio/audio_output_controller.cc
   M /trunk/src/media/audio/audio_output_controller.h
   M /trunk/src/media/audio/audio_output_controller_unittest.cc

Revert 59600 - Make AudioOutputController.Close() truly asynchronous.
Added closed_task parameter in this method. This parameter is used to
notify the caller when the stream is actually closed. Callbacks may
be called until closed_task is executed.

BUG=55755
TEST=Unittests, audio still works, doesn't crash

Review URL: http://codereview.chromium.org/3415007

TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/3425008
------------------------------------------------------------------------
r59600 | sergeyu@chromium.org | 2010-09-16 03:13:53 +0200 (Thu, 16 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/media/audio/audio_output_controller.cc
   M /trunk/src/media/audio/audio_output_controller.h
   M /trunk/src/media/audio/audio_output_controller_unittest.cc

Make AudioOutputController.Close() truly asynchronous.
Added closed_task parameter in this method. This parameter is used to
notify the caller when the stream is actually closed. Callbacks may
be called until closed_task is executed.

BUG=55755
TEST=Unittests, audio still works, doesn't crash

Review URL: http://codereview.chromium.org/3415007
------------------------------------------------------------------------
r59598 | aa@chromium.org | 2010-09-16 03:05:33 +0200 (Thu, 16 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Display attribution correctly on initial load.

BUG=55732
TEST=Create a ntp that is small enough that the theme
attribution or chrome/chromium icon does not show up. Refresh
the page. The attribution or icon should still not be
visible.

Review URL: http://codereview.chromium.org/3437004
------------------------------------------------------------------------
r59597 | aa@chromium.org | 2010-09-16 03:04:48 +0200 (Thu, 16 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_infobar_controller.mm
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/gtk/extension_infobar_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/app_launched_animation_win.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   A /trunk/src/chrome/common/extensions/extension_icon_set.cc
   A /trunk/src/chrome/common/extensions/extension_icon_set.h
   A /trunk/src/chrome/common/extensions/extension_icon_set_unittest.cc

Factor an ExtensionIconSet class out of Extension. This can
be passed to the IO thread or into renderers, where its
functionality can be reused without having to reimplement.

This will be used in the fix for bug 53495.

BUG=53495
TEST=unit_tests --gtest_filter=Extension*

Review URL: http://codereview.chromium.org/3432001
------------------------------------------------------------------------
r59595 | jamesr@chromium.org | 2010-09-16 02:52:58 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/app/x11_util.cc
   M /trunk/src/app/x11_util_internal.h
   M /trunk/src/chrome/browser/browser_main_gtk.cc

Make our X11 error handler more descriptive

BUG=none
TEST=trigger X11 error, look at the error dialog

Review URL: http://codereview.chromium.org/3425006
------------------------------------------------------------------------
r59593 | chocobo@chromium.org | 2010-09-16 02:35:43 +0200 (Thu, 16 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

Remove hack to auto-connect to Google-A on browser startup in ChromeOS
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3395005
------------------------------------------------------------------------
r59592 | levin@chromium.org | 2010-09-16 02:33:48 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map_unittest.cc
   M /trunk/src/chrome/browser/search_engines/search_provider_install_state_dispatcher_host.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Various style fixes (indenting, captitalization, adding some comments).

Also removed a function that is no longer called.

BUG=None
TEST=Build works.

Review URL: http://codereview.chromium.org/3453006
------------------------------------------------------------------------
r59589 | ctguil@chromium.org | 2010-09-16 02:23:42 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.h
   M /trunk/src/chrome/browser/browser_accessibility_win_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webaccessibility.h

Add support for webkit ValueChanged accessibility notification.

BUG=13291
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotification*

Review URL: http://codereview.chromium.org/3341021
------------------------------------------------------------------------
r59588 | erg@google.com | 2010-09-16 02:22:48 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/base/ref_counted_memory.cc
   M /trunk/src/base/ref_counted_memory.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/backend_impl.h

FBTF: Move Extension::LaunchContainer to extension_constants.h.

This makes browser.h not depend on extension.h.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3399008
------------------------------------------------------------------------
r59587 | phajdan.jr@chromium.org | 2010-09-16 02:22:21 +0200 (Thu, 16 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/chrome_browser.gypi

Linux: make compile-time dependency on gnome-keyring optional.

This is upstreaming a Gentoo Linux patch.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3380004
------------------------------------------------------------------------
r59577 | eroman@chromium.org | 2010-09-16 00:54:10 +0200 (Thu, 16 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/net/base/host_port_pair.cc
   M /trunk/src/net/base/host_port_pair.h
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mapped_host_resolver.cc
   M /trunk/src/net/base/mapped_host_resolver_unittest.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/http/http_auth_handler_negotiate.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool.cc
   M /trunk/src/net/proxy/proxy_resolver_js_bindings.cc
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/proxy/sync_host_resolver_bridge_unittest.cc
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/socks_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc

Change HostResolver::RequestInfo to take a HostPortPair rather than naked host string + port.

Review URL: http://codereview.chromium.org/3420001
------------------------------------------------------------------------
r59572 | dtseng@chromium.org | 2010-09-16 00:33:38 +0200 (Thu, 16 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tts_api.cc
   M /trunk/src/chrome/browser/extensions/extension_tts_api.h
   M /trunk/src/chrome/browser/extensions/extension_tts_api_mac.mm
   A /trunk/src/chrome/browser/extensions/extension_tts_api_util.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api_util.h
   M /trunk/src/chrome/browser/extensions/extension_tts_api_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Add support for speak properties such as rate to platform specific TTS.
BUG=none.
TEST=Use extension to drive the tts engines on Windows and Mac.  Had key bindings so that verification of:
  decrease rate, increase rate, decrease pitch, increase pitch, decrease volume, and increase volume worked.  Verified that the limits, when reached, did not have any adverse effects.
Review URL: http://codereview.chromium.org/3325021
------------------------------------------------------------------------
r59570 | willchan@chromium.org | 2010-09-16 00:24:58 +0200 (Thu, 16 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/ocsp/nss_ocsp.h

Revert 59511 (potentially caused chromiumos leaks) - Take 2: Eagerly set the IO loop used for OCSP.

Refactor nss_ocsp.cc code even more.  Split up OCSP initialization into two LazyInstances.  One is for the IO loop.  One is for registration of OCSP callbacks in NSS, which will load NSS into memory.  Sync and the normal network stack race to set their loop at the IO loop used by OCSP.  We fix that by providing a SetMessageLoopForOCSP() function which will be called in the IOThread initialization code which runs before the sync thread starts up.  Since we split this up from the registration of the OCSP callbacks, it won't also eagerly load NSS, which previously regressed startup time.  Note that the URLRequestContext pointer is still a global, not associated with either of the LazyInstances, because it's used by worker threads which can run past the lifetime of the LazyInstances.

BUG=36740
TEST=none

Review URL: http://codereview.chromium.org/3446001

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3424010
------------------------------------------------------------------------
r59568 | nkostylev@chromium.org | 2010-09-16 00:20:02 +0200 (Thu, 16 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_delegate.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h

Add help dialog for connectivity issues on welcome screen.

BUG= http://crosbug.com/6379
TEST=Help dialogs occur on welcome screen, login screen.

Review URL: http://codereview.chromium.org/3330017
------------------------------------------------------------------------
r59566 | sky@chromium.org | 2010-09-16 00:14:36 +0200 (Thu, 16 Sep 2010) | 61 lines
Changed paths:
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.cc

Fixes bad URLRequest leak detection. nss_ocsp creates a
URLRequest. This URLRequest, if valid, is deleted when the IO thread
is being shutdown by way of a DestructionObserver attached to the IO
thread. Prior to this patch this proves problematic as the LeakTracker
is run before DestructionObservers, which means we were errorenously
detecting a leak and causing random UI failures (and perhaps other
tests).

To fix this I've moved the LeakTracker to run after the IO thread
MessageLoop has been deleted (which means DestructionObservers have
been notified). Doing this triggered a DCHECK in
ChromeNetLog::AddEntry:

  DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));

Here's the full stack:

	StackTrace::StackTrace() [0xf247c1]
	logging::LogMessage::~LogMessage() [0xf3ef4f]
	ChromeNetLog::AddEntry() [0x5c9639]
	net::BoundNetLog::AddEntry() [0x147d8a3]
	net::BoundNetLog::AddEvent() [0x147d92a]
	net::internal::ClientSocketPoolBaseHelper::CancelRequest() [0x132d032]
	net::ClientSocketPoolBase<>::CancelRequest() [0x134aabd]
	net::TCPClientSocketPool::CancelRequest() [0x1348fdb]
	net::ClientSocketHandle::ResetInternal() [0x13273b7]
	net::ClientSocketHandle::Reset() [0x1327874]
	net::ClientSocketHandle::~ClientSocketHandle() [0x1327895]
	scoped_ptr<>::~scoped_ptr() [0x1304b97]
	net::HttpStreamRequest::~HttpStreamRequest() [0x1300933]
	base::RefCounted<>::Release() [0xa15b83]
	scoped_refptr<>::operator=() [0x12f2da4]
	net::HttpNetworkTransaction::~HttpNetworkTransaction() [0x12ee377]
	scoped_ptr<>::~scoped_ptr() [0x12e2724]
	net::HttpCache::Transaction::~Transaction() [0x12e10a6]
	scoped_ptr<>::reset() [0x12d1f0b]
	URLRequestHttpJob::DestroyTransaction() [0x142229e]
	URLRequestHttpJob::Kill() [0x14252e5]
	URLRequest::DoCancel() [0x137af1e]
	URLRequest::Cancel() [0x137b081]
	(anonymous namespace)::OCSPRequestSession::CancelURLRequest() [0x13142a7]
	(anonymous namespace)::OCSPRequestSession::WillDestroyCurrentMessageLoop() [0x1314b30]
	MessageLoop::~MessageLoop() [0xf421ab]
	base::Thread::ThreadMain() [0xf71395]
	ThreadFunc() [0xf54338]
	start_thread [0x7ff66c6d83f7]
	0x7ff669d5cbbd

This is still on the IO thread, but the DCHECK fails because at the
time the DestructionObservers are run Thread::message_loop() returns
NULL, which means the DCHECK fails. I've fixed this by changing the
DCHECK to pass if the current thread's message loop is NULL. I feel a
bit quesy about this as it seems a bit fragile (well, all this code is
fragile). I would be inclined to make Thread::message_loop() return
the MessageLoop until after the destructor has run, but this seems
equally risky. Let me know what you prefer.

BUG=52022
TEST=none

Review URL: http://codereview.chromium.org/3402006
------------------------------------------------------------------------
r59562 | sky@chromium.org | 2010-09-15 23:40:22 +0200 (Wed, 15 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_win.cc

Changes tab dragging code to ignore WS_EX_TRANSPARENT and
WS_EX_LAYERED windows. Here's the comment I'm adding as to why:

      // Mouse events fall through WS_EX_TRANSPARENT windows, so we ignore them.
      //
      // WS_EX_LAYERED is trickier. Apps like Switcher create a totally
      // transparent WS_EX_LAYERED window that is always on top. If we don't
      // ignore WS_EX_LAYERED windows and there are totally transparent
      // WS_EX_LAYERED windows then there are effectively holes on the screen
      // that the user can't reattach tabs to. So we ignore them. This is a bit
      // problematic in so far as WS_EX_LAYERED windows need not be totally
      // transparent in which case we treat chrome windows as not being obscured
      // when they really are, but this is better than not being able to
      // reattach tabs.

BUG=12580 10742
TEST=none

Review URL: http://codereview.chromium.org/3383004
------------------------------------------------------------------------
r59555 | nick@chromium.org | 2010-09-15 23:25:02 +0200 (Wed, 15 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/sessions/status_controller.cc

Treat "changes_remaining == 0" as a firm bound that indicates
the end of a batch.  The server implementation has always been consistent with this treatment.

This has the effect of eliminating a GetUpdates proximate to a commit (we do 3 total instead of 4).

BUG=55279
TEST=Integration tests + Manual testing of sync with trace breakpoints.

Review URL: http://codereview.chromium.org/3402003
------------------------------------------------------------------------
r59552 | gavinp@chromium.org | 2010-09-15 23:03:08 +0200 (Wed, 15 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Increase the prefetch experiment to 50/50 in dev & beta

I want more data on prefetch effectiveness, and so I'm upping it to
50/50 in dev & beta channels with this CL

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/3396007
------------------------------------------------------------------------
r59551 | stevenjb@google.com | 2010-09-15 23:02:52 +0200 (Wed, 15 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/sad_tab_view.cc

chromium-os:3730 - 'Aw snap on moles links to unreadable Help Center articles.'
Customize SadTabView to open a new FG tab from the 'learn more' link for chromeos popups.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=3730
TEST=See bug

Review URL: http://codereview.chromium.org/3367022
------------------------------------------------------------------------
r59542 | dhg@chromium.org | 2010-09-15 22:13:28 +0200 (Wed, 15 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_add_language_overlay.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js

Fixing build.

BUG=none
TEST=no longer has an error in the javascript console
Review URL: http://codereview.chromium.org/3435008
------------------------------------------------------------------------
r59541 | nkostylev@chromium.org | 2010-09-15 22:11:13 +0200 (Wed, 15 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h

Support custom sizes for wizard screens.
Change default size of welcome screen.

Some reordering of methods in .cc (better align to header).

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6194
TEST=Welcome screen has different size than other OOBE windows, transitions happen smoothly.

Review URL: http://codereview.chromium.org/3405002
------------------------------------------------------------------------
r59540 | thakis@chromium.org | 2010-09-15 22:07:19 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h

Add about:gpucrash

BUG=None
TEST=open a tab that uses the compositor. Open a second tab, go to about:gpucrash. Verify in the task manager that the gpu process is now gone.

Review URL: http://codereview.chromium.org/3424007
------------------------------------------------------------------------
r59532 | alekseys@chromium.org | 2010-09-15 21:16:50 +0200 (Wed, 15 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/sidebar_controller.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm

Unsubscribe SidebarController from NSSplitView updates in dealloc (no zombies).
Enable ViewIDTest.Fullscreen back.

BUG=55643
TEST=browser_tests --gtest_filter=ViewIdTest.Fullscreen

Review URL: http://codereview.chromium.org/3424006
------------------------------------------------------------------------
r59530 | albertb@chromium.org | 2010-09-15 20:41:08 +0200 (Wed, 15 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/resources/options/sync_options.html
   A /trunk/src/chrome/browser/resources/options/sync_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/common/notification_type.h

Re-land: Hook up the dom_ui sync options to the sync service.

TBR=tim
BUG=chromiumos:6363
TEST=manual

Review URL: http://codereview.chromium.org/3447003
------------------------------------------------------------------------
r59515 | erg@google.com | 2010-09-15 19:46:17 +0200 (Wed, 15 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc

GTK: If the user hovers over stop, it should be disabled once page has finished loading.

This works in both chrome and gtk theme mode, though it uses different code paths (in chrome-theme mode, we override stop_.paint_state(), in gtk-theme mode, we force rendering of the stock icon to insensitive). We can't just set the widget to insensitive because changing the sensitivity of a widget immediately synthesizes a leave notification.

BUG=46981
TEST=behaviour matches windows.

Review URL: http://codereview.chromium.org/3396004
------------------------------------------------------------------------
r59514 | csilv@chromium.org | 2010-09-15 19:42:57 +0200 (Wed, 15 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.h
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js

dom-ui options: Import dialog improvements
  - Fixed so that import window is setup correctly when invoked directly from a command.
  - Correctly enable/disable checkboxes based on what services are supported by a profile.
  - Changes to avoid relying on the exact order of checkboxes in the DOM.
  - Changes to use ExternalProcessImporterHost instead of ImporterHost (MacOS X).
  - Put ok/cancel buttons in a button strip.

BUG=none
TEST=verify Import dialog works properly via dom-ui (--enable-tabbed-options)
Review URL: http://codereview.chromium.org/3363012
------------------------------------------------------------------------
r59513 | erg@google.com | 2010-09-15 19:38:42 +0200 (Wed, 15 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/common/plugin_messages.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/worker_messages.cc
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc

FBTF: Add default ctors/dtors for various param structs.

This patch also moves ParamTraits method definitions to the cc file.

(hbono@ has a patch out that does this for render_messages_params.h, so this
patch doesn't touch that to make sure we don't conflict.)

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3413003
------------------------------------------------------------------------
r59512 | agl@chromium.org | 2010-09-15 19:34:25 +0200 (Wed, 15 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Use magic to init our 'localtime' wrapper.

(See bug for details.)

Patch-by: kcc (Chromium)

BUG=54264
TEST=none
------------------------------------------------------------------------
r59511 | willchan@chromium.org | 2010-09-15 19:32:14 +0200 (Wed, 15 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/ocsp/nss_ocsp.h

Take 2: Eagerly set the IO loop used for OCSP.

Refactor nss_ocsp.cc code even more.  Split up OCSP initialization into two LazyInstances.  One is for the IO loop.  One is for registration of OCSP callbacks in NSS, which will load NSS into memory.  Sync and the normal network stack race to set their loop at the IO loop used by OCSP.  We fix that by providing a SetMessageLoopForOCSP() function which will be called in the IOThread initialization code which runs before the sync thread starts up.  Since we split this up from the registration of the OCSP callbacks, it won't also eagerly load NSS, which previously regressed startup time.  Note that the URLRequestContext pointer is still a global, not associated with either of the LazyInstances, because it's used by worker threads which can run past the lifetime of the LazyInstances.

BUG=36740
TEST=none

Review URL: http://codereview.chromium.org/3446001
------------------------------------------------------------------------
r59509 | joth@chromium.org | 2010-09-15 18:49:13 +0200 (Wed, 15 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Revert 59507 - NoInfobarForDeniedOrigin no longer appears flaky (last seen July 10)
Committed due to git branch error

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/3437003
------------------------------------------------------------------------
r59507 | joth@chromium.org | 2010-09-15 18:45:14 +0200 (Wed, 15 Sep 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

NoInfobarForDeniedOrigin no longer appears flaky (last seen July 10)
------------------------------------------------------------------------
r59504 | joth@chromium.org | 2010-09-15 18:07:29 +0200 (Wed, 15 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc

Fix type that broke build

TBR=suzhe@chromium.org
------------------------------------------------------------------------
r59503 | joth@chromium.org | 2010-09-15 17:46:24 +0200 (Wed, 15 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc

Mark BrowserKeyEventsTest.AccessKeys as flaky

BUG=55713
TEST=BrowserKeyEventsTest.AccessKeys
TBR=suzhe@chromium.org
------------------------------------------------------------------------
r59501 | bauerb@chromium.org | 2010-09-15 17:38:44 +0200 (Wed, 15 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/SimpleContentExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/table_model_array_controller.h
   A /trunk/src/chrome/browser/cocoa/table_model_array_controller.mm
   A /trunk/src/chrome/browser/cocoa/table_model_array_controller_unittest.mm
   A /trunk/src/chrome/browser/mock_plugin_exceptions_table_model.cc
   A /trunk/src/chrome/browser/mock_plugin_exceptions_table_model.h
   M /trunk/src/chrome/browser/plugin_exceptions_table_model.cc
   M /trunk/src/chrome/browser/plugin_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Add per-plugin exceptions to content settings.

Screenshot: ﻿http://www.dropmocks.com/mXMd

I'm adding a subclass of NSArrayController, TableModelArrayController, that binds to a RemoveRowsTableModel that can use groups and displays them using group rows in an NSTableView. This cleans up SimpleContentExceptionsWindowController a lot, and the class could also be used for other table models that use groups (keyword editor and autofill).

XIB changes: In SimpleContentExceptionsWindow.xib, bind table view to TableModelArrayController instead of using the dataSource outlet. Buttons call actions on TableModelArrayController, and table view delegate also points to it.

BUG=39252
TEST=SimpleContentExceptionsWindowControllerTest.*:TableModelArrayControllerTest.*:PluginExceptionsTableModelTest.*

Review URL: http://codereview.chromium.org/3327016
------------------------------------------------------------------------
r59497 | dpolukhin@chromium.org | 2010-09-15 16:42:51 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.h

Remove user should be button instead of menu item

BUG=chromium-os:6476
TEST=Manual, see images login.

Review URL: http://codereview.chromium.org/3392005
------------------------------------------------------------------------
r59494 | mmenke@chromium.org | 2010-09-15 15:40:28 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/main.js

Modify "Remove cookies" checkbox on net-internals to remove authentication credentials as well.

BUG=55211
TEST=manual

Review URL: http://codereview.chromium.org/3402002
------------------------------------------------------------------------
r59492 | jochen@chromium.org | 2010-09-15 15:24:24 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_terms_data.cc

Do not include RLZ parameters in search requests for organic installs.

BUG=55363
TEST=none

Review URL: http://codereview.chromium.org/3324017
------------------------------------------------------------------------
r59491 | jochen@chromium.org | 2010-09-15 15:22:45 +0200 (Wed, 15 Sep 2010) | 34 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history2.html

New information design for history browse and search entries.
Mock: https://docs.google.com/leaf?id=0B_nT9N2oDUPyNzg4MGFlYTEtYzc2MS00OThjLTk4OTMtOGFkMDlmM2U2ODBi&authkey=CJuQlvQN&hl=en

Entry changes:
  - Show the domain (green) for the page and favicon.
  - Page title has underline only on hover, and is blue even if visited.
  - Page title is truncated to 80 characters.
  - A tooltip is shown for truncated titles.
  - Fluid bidirectional layout with max-width and text wrapping.
Semantic HTML for accessibility (for screen-readers).
  - Headings used for day labels.
  - Ordered lists used for day groups or search results.
  - Removed table DOM structure used in search results.
Speeding up DOM generation
  - Using document fragments for generating day groups
Consistent browse and search entries:
  - Same JavaScript method is used to construct both types of entries.
  - Shared HTML structure and CSS for both types of entries.
Fixed minor issues with RTL languages (Hebrew and Arabic):
  - Wrapping issues for search results.
  - Inconsistent bidi layout
Code changes:
  - Added domain property to Page class.
  - Added getDomainFromURL_ method to Page class.
  - Added truncateString_ method to Page class.
  - Unified getSearchResultDom and getBrowseResultDom methods.
  - Updated getTitleDOM_ method to truncate title and add optional tooltip.
  - Updated displayResults_ method to use documentFragment and group into days.

BUG=52697
TEST=none

Review URL: http://codereview.chromium.org/3202002
Patch from Keekim Heng <keekim@google.com>.
------------------------------------------------------------------------
r59489 | dilmah@chromium.org | 2010-09-15 13:03:46 +0200 (Wed, 15 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/help_app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h

Add link on welcome page to setup a network proxy.  This link is still just overall chrome://options -- need to pinpoint more specific proxy options later.

Plus fixed regression with disabling continue button on welcome screen after language change.

BUG=http://crosbug.com/3062
TEST=Manual

Review URL: http://codereview.chromium.org/3440001
------------------------------------------------------------------------
r59487 | yusukes@chromium.org | 2010-09-15 12:07:53 +0200 (Wed, 15 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc

Add logic to display annotations in the candidate window.

Annotations are pieces of text that annotate candidates.
For example, Mozc uses annotations for explaining the type
of the candidate such as [HALF][KATAKANA], [GREEK],
[Black square], etc...

The lookup table has annotations. When receives new lookup
table, candidate window computes the width of the annotation
label for adjusting the column width. Then the third column in
CandidateView displays annotations.

BUG=chromium-os:3475
TEST=manual

Review URL: http://codereview.chromium.org/3304002
Patch from Hiroki Nakagawa <nhiroki@google.com>.
------------------------------------------------------------------------
r59485 | hans@chromium.org | 2010-09-15 10:33:38 +0200 (Wed, 15 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Handle return value from HANDLE_EINTR in render_sandbox_host_linux.cc.

Clang complains about this unused return value.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3323023
------------------------------------------------------------------------
r59482 | hbono@chromium.org | 2010-09-15 10:05:53 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl_unittest.cc
   M /trunk/src/chrome/renderer/render_view_browsertest.cc

Adds default constructors and destructors to ViewHostMsgs.
This change adds default constructors to ViewHostMsgs defined in 'chrome/common/render_messages_params.h' to prevent its variables from being used uninitialized, and adds destructors to prevent compilers from synthesizing them when including the header file. This change also removes code that inserts constants to the structs because we do not need it any more.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3252001
------------------------------------------------------------------------
r59480 | zelidrag@chromium.org | 2010-09-15 04:05:19 +0200 (Wed, 15 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.h
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc

Fixed saving of prefs from domui options page. There were number of cases where were weren't doing it since
pref saving logic has been bundled with user metrics operations.

BUG=chromium-os:6486
TEST=make sure all options are preserved between boots

Review URL: http://codereview.chromium.org/3304022
------------------------------------------------------------------------
r59479 | csilv@chromium.org | 2010-09-15 03:48:37 +0200 (Wed, 15 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.cc
   A /trunk/src/chrome/browser/resources/options/font_settings.html (from /trunk/src/chrome/browser/resources/options/font_settings_overlay.html:59280)
   A /trunk/src/chrome/browser/resources/options/font_settings.js (from /trunk/src/chrome/browser/resources/options/font_settings_overlay.js:59280)
   D /trunk/src/chrome/browser/resources/options/font_settings_overlay.html
   D /trunk/src/chrome/browser/resources/options/font_settings_overlay.js
   M /trunk/src/chrome/browser/resources/options.html

dom-ui options: Change the font settings dialog to be a sub-page, not an overlay.  Matches current mocks.

BUG=none
TEST=Verify font settings page appears correct via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3390005
------------------------------------------------------------------------
r59473 | vandebo@chromium.org | 2010-09-15 02:43:20 +0200 (Wed, 15 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_gallery_install_apitest.cc

ExtensionGalleryInstallApiTest.InstallAndUninstall is failing on 'XP Tests' bot.

TBR=rafaelw
TEST=green tree
BUG=55642

Review URL: http://codereview.chromium.org/3438004
------------------------------------------------------------------------
r59467 | estade@chromium.org | 2010-09-15 02:29:36 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

[GTK] Fix rtl tabstrip layout during window resize.

BUG=55619
TEST=see bug

Review URL: http://codereview.chromium.org/3431003
------------------------------------------------------------------------
r59464 | csilv@chromium.org | 2010-09-15 02:20:05 +0200 (Wed, 15 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.html
   M /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.html

dom-ui options: Order ok/cancel buttons according to OS.

BUG=none
TEST=Verify that cancel buttons only appear to left on Windows.
Review URL: http://codereview.chromium.org/3393001
------------------------------------------------------------------------
r59462 | cdn@chromium.org | 2010-09-15 02:15:46 +0200 (Wed, 15 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc

Added check when unpacking extensions for a null key.

BUG=55615
TEST=None
Review URL: http://codereview.chromium.org/3395002
------------------------------------------------------------------------
r59461 | isherman@chromium.org | 2010-09-15 02:13:45 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm

Disable ViewIDTest.Fullscreen -- it's crashy

BUG=55643
TEST=browser_tests --gtest_filter=ViewIdTest.Fullscreen

Review URL: http://codereview.chromium.org/3446003
------------------------------------------------------------------------
r59457 | shess@chromium.org | 2010-09-15 01:57:51 +0200 (Wed, 15 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/framed_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/image_utils_unittest.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

[Mac] Refactor FramedBrowserWindowTest.DoesHideTitle for valgrind.

Revised to use NSBitmapImageRep to snapshot, rather than going through
PDF, so it doesn't need a bunch of new valgrind suppressions.

BUG=30384
TEST=valgrind green

Review URL: http://codereview.chromium.org/3297019
------------------------------------------------------------------------
r59455 | skerner@chromium.org | 2010-09-15 01:50:45 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Hide packed hosted apps in chrome://extensions .

BUG=53222
TEST=Manualy installed extensions, hosted apps,a nd packaged apps.

Review URL: http://codereview.chromium.org/3425001
------------------------------------------------------------------------
r59454 | ctguil@chromium.org | 2010-09-15 01:50:06 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix in trunk. Null check view() in accessibility notifications

BUG=54976
TEST=none
TBR=dglavkov@chromium.org

------------------------------------------------------------------------
r59452 | albertb@chromium.org | 2010-09-15 01:30:32 +0200 (Wed, 15 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/resources/options/sync_options.html
   D /trunk/src/chrome/browser/resources/options/sync_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/common/notification_type.h

Revert 59451 - Hook up the dom_ui sync options to the sync service.

BUG=chromiumos:6363
TEST=manual

Review URL: http://codereview.chromium.org/3335017

TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/3405003
------------------------------------------------------------------------
r59451 | albertb@chromium.org | 2010-09-15 01:19:54 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/resources/options/sync_options.html
   A /trunk/src/chrome/browser/resources/options/sync_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/common/notification_type.h

Hook up the dom_ui sync options to the sync service.

BUG=chromiumos:6363
TEST=manual

Review URL: http://codereview.chromium.org/3335017
------------------------------------------------------------------------
r59449 | estade@chromium.org | 2010-09-15 01:14:32 +0200 (Wed, 15 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

Add "copy url" to popup window menu.

Also added "Close" as it is probably useful and pretty standard (on Windows this is a part of the default system contents for that menu).

BUG=55578
TEST=manual

Review URL: http://codereview.chromium.org/3412003
------------------------------------------------------------------------
r59438 | isherman@chromium.org | 2010-09-15 00:23:36 +0200 (Wed, 15 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/autofill_helper.cc
   M /trunk/src/chrome/renderer/autofill_helper.h
   M /trunk/src/chrome/renderer/render_view.cc

Clean up RenderViewHostDelegate::AutoFill interface -- remove |value| and |label| parameters from FillAutoFillFormData()

BUG=none
TEST=it compiles

Review URL: http://codereview.chromium.org/3319006
------------------------------------------------------------------------
r59436 | csilv@chromium.org | 2010-09-15 00:22:05 +0200 (Wed, 15 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/alert_overlay.html
   M /trunk/src/chrome/browser/resources/options/alert_overlay.js
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.js
   D /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.html
   D /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.js
   D /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.html
   D /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

dom-ui options: Migrate two alerts to shared AlertOverlay.

BUG=none
TEST=Verify that 'stop sync' and 'remove all password' alerts display correctly.
Review URL: http://codereview.chromium.org/3409001
------------------------------------------------------------------------
r59433 | satish@chromium.org | 2010-09-14 23:48:22 +0200 (Tue, 14 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc

Extend speech input bubble in GTK to display error messages with try-again and cancel buttons.
The SpeechInputBubbleGtk object now lives longer than the actual info bubble window, and
allows the caller to create a bubble on screen or update with an error message when needed.

When recording speech, the layout of controls are (vertical):
- Label ('Speak now')
- Icon (Mic or wait)
- Button Bar (Horizontal, 1 button, 'Cancel')

When showing a message, the layout of controls are (vertical):
- Label (message text)
- Button Bar (Horizontal, 2 buttons, 'Try Again' and 'Cancel')

While implementing this I noticed that the info bubble in GTK did not redraw itself properly if the content increased in width or height after creation, which seemed to be because the new mask region was 'combined' with the previous region. So I've added a line to clear the previous mask region before setting a new one.

BUG=53598
TEST=manual, unplug mic and start recognition to check error message, and similarly give no speech to check.

Review URL: http://codereview.chromium.org/3307025
------------------------------------------------------------------------
r59428 | sky@chromium.org | 2010-09-14 23:38:30 +0200 (Tue, 14 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.h
   A /trunk/src/chrome/browser/tab_contents/match_preview_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   A /trunk/src/chrome/browser/views/frame/contents_container.cc
   A /trunk/src/chrome/browser/views/frame/contents_container.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_location_bar.h

Bunch of match preview tweaks:
. Makes MatchPreview owned by Browser rather than each TabContents.
. Makes MatchPreview dismiss when the omnibox closes.
. Supports the ability to send script to the page rather than
  reloading on every keystroke.
. Supports receiving results from the page that drives the suggest
  text in the omnbox.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3332022
------------------------------------------------------------------------
r59427 | vandebo@chromium.org | 2010-09-14 23:23:08 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

Failing fairly often due to tab->NavigateToURL(...) failing.

BUG=55380
TEST=greener tree

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59417

Review URL: http://codereview.chromium.org/3439003
------------------------------------------------------------------------
r59424 | csilv@chromium.org | 2010-09-14 22:04:20 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.css
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.html

dom-ui options: 'Clear browsing data' layout tweaks.
  - Move the clear browser data buttons into a button strip div.
  - Improve how labels are associated with checkboxes, previous method had layout issues.
  - Removed an extraneous div.

BUG=none
TEST=Verify that clear browsing data dialog right justifies buttons.
Review URL: http://codereview.chromium.org/3363015
------------------------------------------------------------------------
r59423 | csilv@chromium.org | 2010-09-14 22:03:03 +0200 (Tue, 14 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css

dom-ui options: Add vertical padding for the button strip.

BUG=none
TEST=Verify that button strip buttons are not too close to upper dialog items.
Review URL: http://codereview.chromium.org/3407001
------------------------------------------------------------------------
r59422 | estade@chromium.org | 2010-09-14 21:59:29 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Tabbed options: Support direct navigation to content settings subtabs.

BUG=54903
TEST=block cookies, go to almost any site, click little cookie in omnibox, manage cookies

Review URL: http://codereview.chromium.org/3323021
------------------------------------------------------------------------
r59420 | johnnyg@chromium.org | 2010-09-14 21:43:36 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Establish new debug switches to manipulate the token service from the command line, replacing the old invalidate-sync-login switch.

The new switches can either clear the token service entirely, or set a new token for a given service id manually.

BUG=none
TEST=unit test, or use these switches for manual test

Review URL: http://codereview.chromium.org/3234005
------------------------------------------------------------------------
r59419 | vandebo@chromium.org | 2010-09-14 21:37:04 +0200 (Tue, 14 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

Revert 59417 - Failing fairly often due to tab->NavigateToURL(...) failing.

BUG=55380
TEST=greener tree

Review URL: http://codereview.chromium.org/3439003

TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/3427003
------------------------------------------------------------------------
r59418 | aa@chromium.org | 2010-09-14 21:35:04 +0200 (Tue, 14 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/window_open_apitest.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.cc
   M /trunk/src/chrome/renderer/render_view.cc

Land implementation part of cl 3352009 (that cl was just data
files that had to be uploaded first for try runs to work).

This makes window.open() open a tab or popup window correctly from extensions, even when no user gesture is present.

BUG=54768
TEST=Added browser tests.

Review URL: http://codereview.chromium.org/3325024
------------------------------------------------------------------------
r59417 | vandebo@chromium.org | 2010-09-14 21:32:08 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

Failing fairly often due to tab->NavigateToURL(...) failing.

BUG=55380
TEST=greener tree

Review URL: http://codereview.chromium.org/3439003
------------------------------------------------------------------------
r59403 | sky@chromium.org | 2010-09-14 20:23:19 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Fixes bug in WindowSimulateDrag that was leading to test flake. The
problem is sending escape isn't synchornous, so we have to wait for it
to be processed.

BUG=21092
TEST=none

Review URL: http://codereview.chromium.org/3411003
------------------------------------------------------------------------
r59398 | sergeyu@chromium.org | 2010-09-14 19:58:16 +0200 (Tue, 14 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/media/audio/audio_output_controller.cc
   M /trunk/src/media/audio/audio_output_controller.h

Fixed crash in AudioOutputController.

AudioOutputController must not call EventHandler after it has been
closed. Changing it so that lock_ is always locked whenever we call
handler_ to ensure that state_ != kClosed.
BUG=54939
TEST=unittests

Review URL: http://codereview.chromium.org/3308025
------------------------------------------------------------------------
r59397 | aa@chromium.org | 2010-09-14 19:56:55 +0200 (Tue, 14 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/most_visited.css
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js

Updates to NTP per UI review:

1) Turn off logo/attribution completely when it overlaps
   with the content.
2) Replace the single-item dropdown menu in the most visited
   section with a text link to restore blacklisted URLs. The
   link should only be visible if there are any blacklisted
   URLs.

BUG=55196,55208
TEST=unit_tests --gtest-filter=TopSitesTest.*

Review URL: http://codereview.chromium.org/3361015
------------------------------------------------------------------------
r59396 | craig.schlenter@chromium.org | 2010-09-14 19:54:04 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/webkit/glue/plugins/pepper_private.cc
   M /trunk/src/webkit/glue/plugins/pepper_transport.cc
   M /trunk/src/webkit/glue/webvideoframe_impl.cc

Linux: More gcc 4.5 NULL versus 0 fixes.

BUG=49533
TEST=compiles with gcc 4.5 and on trybots.

Review URL: http://codereview.chromium.org/3433005
------------------------------------------------------------------------
r59385 | mdm@chromium.org | 2010-09-14 19:18:56 +0200 (Tue, 14 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc

Fix several spelling mistakes, mostly in comments.
BUG=none
TEST=none
------------------------------------------------------------------------
r59382 | mdm@chromium.org | 2010-09-14 18:47:15 +0200 (Tue, 14 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_default_unittest.cc

Add tests to verify that non-ASCII passwords (and other password form data) can be stored correctly.
TEST=tests pass
BUG=54065
Review URL: http://codereview.chromium.org/3358031
------------------------------------------------------------------------
r59381 | shess@chromium.org | 2010-09-14 18:45:34 +0200 (Tue, 14 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

Reland "Make AutomationProvider fail fast on messages it doesn't understand."

Original review: http://codereview.chromium.org/3224001
Revert review: http://codereview.chromium.org/3317023

Relanding because it didn't cause the problem.

BUG=54453
TEST=chromebot

Review URL: http://codereview.chromium.org/3396001
------------------------------------------------------------------------
r59380 | xiyuan@chromium.org | 2010-09-14 18:37:41 +0200 (Tue, 14 Sep 2010) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/mock_ownership_service.h
   M /trunk/src/chrome/browser/chromeos/login/signed_settings.h
   A /trunk/src/chrome/browser/chromeos/login/signed_settings_helper.cc
   A /trunk/src/chrome/browser/chromeos/login/signed_settings_helper.h
   A /trunk/src/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/signed_settings_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add a helper class to use with SignedSettings.

- Add a SignedSettingsHelper that serializes all SignedSettings ops,
  provides a unified callback interface and allows canceling callback of
  requested ops;
- Move MockOwnershipService into a header file;
- Add a unit test for SignedSettingsHelper;

BUG=chromium-os:968
TEST=none. This is still plumbing work required users options ui.

Review URL: http://codereview.chromium.org/3373008
------------------------------------------------------------------------
r59378 | mbelshe@chromium.org | 2010-09-14 18:29:33 +0200 (Tue, 14 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Eliminate the 8-sockets-per-proxy field trial.  Reduce the percentage
of clients in the max-sockets tests from 20-25% to 1%.

BUG=52807
TEST=n/a

Review URL: http://codereview.chromium.org/3392003
------------------------------------------------------------------------
r59373 | thomasvl@chromium.org | 2010-09-14 16:56:27 +0200 (Tue, 14 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
   M /trunk/src/net/spdy/spdy_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_test_util.h
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Trying to green up the tree, lots of mac and win red around this cl.
Revert 59362 - net: Rename ProxyService::CreateNull to ProxyService::CreateDirect.

(Note: This was a TODO for eroman).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3336021

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/3444001
------------------------------------------------------------------------
r59366 | thakis@chromium.org | 2010-09-14 16:02:51 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Add to the task manager the v8 column on mac and the javascript column on mac and linux.

BUG=None (js column was added for windows in http://codereview.chromium.org/276009 ), 27226 (v8 column)
TEST=Add v8 and javascript columns using the task manager's context menu. should work on all platforms now.

Review URL: http://codereview.chromium.org/3419001
------------------------------------------------------------------------
r59364 | mmenke@chromium.org | 2010-09-14 15:40:54 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   A /trunk/src/chrome/browser/net/service_providers_win.cc
   A /trunk/src/chrome/browser/net/service_providers_win.h
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   A /trunk/src/chrome/browser/resources/net_internals/serviceprovidersview.js
   M /trunk/src/chrome/chrome_browser.gypi

Enumerate layered service providers and namespace providers under Windows and display them on a new net-internals tab.  On other OSes, the new tab is always hidden.

BUG=53474
TEST=manual

Review URL: http://codereview.chromium.org/3329016
------------------------------------------------------------------------
r59362 | tfarina@chromium.org | 2010-09-14 15:22:01 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
   M /trunk/src/net/spdy/spdy_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_test_util.h
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.h

net: Rename ProxyService::CreateNull to ProxyService::CreateDirect.

(Note: This was a TODO for eroman).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3336021
------------------------------------------------------------------------
r59361 | satorux@chromium.org | 2010-09-14 15:07:45 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

[Linux] Don't send a key event to browser window for pre-handling if it's handled by IME.

BUG=53397
BUG=chromium-os:6471
TEST=Manually. See bug report.

Review URL: http://codereview.chromium.org/3307020
Patch from James Su <suzhe@chromium.org>.
------------------------------------------------------------------------
r59360 | finnur@chromium.org | 2010-09-14 15:05:04 +0200 (Tue, 14 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/page_info_model.cc

Show these two cert errors as warnings, not errors (as requested by Ian):

CERT_STATUS_UNABLE_TO_CHECK_REVOCATION
CERT_STATUS_NO_REVOCATION_MECHANISM

Note: The Omnibox shows no_revocation_mechanism as skull and bones, but that's a separate issue.

BUG=http://crbug.com/52916
TEST=Requires server with cert errors.

Review URL: http://codereview.chromium.org/3293019
------------------------------------------------------------------------
r59357 | tfarina@chromium.org | 2010-09-14 14:12:01 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/page_info_bubble_gtk.cc

gtk: Show the page info icon for the first visit on Page Info Bubble.

BUG=52916
TEST=out/Debug/chrome --enable-new-page-info-bubble. Go to https://google.com,
     click on the omnibox icon, see the icon is showed for the the First Visit
     section.

Review URL: http://codereview.chromium.org/3364018
------------------------------------------------------------------------
r59356 | yusukes@chromium.org | 2010-09-14 13:18:47 +0200 (Tue, 14 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc

Modify candidate window to adjust shortcut and candidate column width.

* This patch is extracted from the patch (http://codereview.chromium.org/3304002/show)

Candidate window created shortcut and candidate columns in variable width,
so these columns were not aligned.

In this patch, candidate window computes column width and creates columns
in fixed width.

BUG=chromium-os:6377
TEST=manual

Review URL: http://codereview.chromium.org/3412002
Patch from Hiroki Nakagawa <nhiroki@google.com>.
------------------------------------------------------------------------
r59353 | hbono@google.com | 2010-09-14 12:13:14 +0200 (Tue, 14 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/app/win_util.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/chrome/browser/browser_init.cc

Revert 52446 - Supports High DPI mode.

This change caused too many layout problems; such as Issue 50100 and 51562. I would like to revert this change now and send another change when I fix them.

When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later.

BUG=1715,36939
TEST=Run chrome.exe on the screen resolution higher than 120 DPI.
Review URL: http://codereview.chromium.org/2867031

TBR=hbono@chromium.org
Review URL: http://codereview.chromium.org/3435002
------------------------------------------------------------------------
r59352 | hans@chromium.org | 2010-09-14 11:38:11 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc

Handle return value from HANDLE_EINTR in process_singleton_linux_uitest.cc.

Clang complains about this unused return value.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3334016
------------------------------------------------------------------------
r59350 | jorlow@chromium.org | 2010-09-14 11:36:07 +0200 (Tue, 14 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/web_page_view.cc
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   A /trunk/src/chrome/browser/in_process_webkit/session_storage_namespace.cc
   A /trunk/src/chrome/browser/in_process_webkit/session_storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_factory.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_factory.h
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sidebar/sidebar_container.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Fix SessionStorage

Apparently the session storage code was pretty horribly broken.  It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks.

To fix this, things had to be plumbed fairly differently.  We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id.  When closing a tab, we need to save the session storage with the restoration service.  When restoring a tab, we pass it back into the tab contents class.  When duplicating a tab, we clone the storage.

Lifetimes are now handled by standard reference counting code.  A SessionStorageNamespace object wraps an ID.  When it's instantiated, it allocates an ID.  When it's destroyed, it deletes the ID.  IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely.

BUG=52393
TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set.  You can also run through the repro steps in the bug.

Review URL: http://codereview.chromium.org/3325012
------------------------------------------------------------------------
r59348 | satorux@chromium.org | 2010-09-14 11:21:55 +0200 (Tue, 14 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/tools/chromeactions.txt
   M /trunk/src/chrome/tools/extract_actions.py

Add more useful metrics to "Languages and Input" page in Chrome OS.

Record metrics with associated input method IDs, and language codes,
to make the metrics data more useful.

Update chromeactions.txt as follows:
% cd chrome/tools
% PYTHONPATH=../../tools/python python extract_actions.py  --hash

BUG=chromium-os:2637
TEST=manually.

Review URL: http://codereview.chromium.org/3330021
------------------------------------------------------------------------
r59345 | pam@chromium.org | 2010-09-14 10:25:07 +0200 (Tue, 14 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   A /trunk/src/chrome/browser/prefs/default_pref_store.cc
   A /trunk/src/chrome/browser/prefs/default_pref_store.h
   M /trunk/src/chrome/browser/prefs/pref_notifier.cc
   M /trunk/src/chrome/browser/prefs/pref_notifier.h
   M /trunk/src/chrome/browser/prefs/pref_notifier_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_service.cc
   M /trunk/src/chrome/browser/prefs/pref_service.h
   M /trunk/src/chrome/browser/prefs/pref_service_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.h
   M /trunk/src/chrome/browser/prefs/pref_value_store_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_pref_service.cc
   M /trunk/src/chrome/test/testing_pref_service.h

Create a DefaultPrefStore to hold registered application-default preference values.

Also rework preference notifications so they're not sent when a pref store rewrites the same value it already had,
to avoid infinite recursion in places that set a pref in response to a notification that that pref has changed.

This allows notifications to be sent properly when another PrefStore takes control from a default value.

BUG=52719, 54950
TEST=covered by unit tests (PrefValueStoreTest.*, PrefNotifierTest.*, and ExtensionPrefStoreTest.*)
Review URL: http://codereview.chromium.org/3323022
------------------------------------------------------------------------
r59344 | dpolukhin@chromium.org | 2010-09-14 10:19:06 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Enable incognito mode from external_extensions.json

Add an ability to enable extension in incognito mode by default from external_extensions.json file.

BUG=chromium-os:6516
TEST=unit_tests --gtest_filter=ExtensionsServiceTest.ExternalPrefProvider

Review URL: http://codereview.chromium.org/3360020
------------------------------------------------------------------------
r59343 | dpolukhin@chromium.org | 2010-09-14 10:17:26 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_delegate.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   A /trunk/src/chrome/browser/chromeos/status/network_dropdown_button.cc
   A /trunk/src/chrome/browser/chromeos/status/network_dropdown_button.h
   A /trunk/src/chrome/browser/chromeos/status/network_menu.cc (from /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc:59342)
   A /trunk/src/chrome/browser/chromeos/status/network_menu.h (from /trunk/src/chrome/browser/chromeos/status/network_menu_button.h:59342)
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/chrome_browser.gypi

Replace network combobox with network dropdown button

BUG=chromium-os:4023, chromium-os:4117, chromium-os:4117
TEST=Manual test first OOBE screen

Review URL: http://codereview.chromium.org/3166028
------------------------------------------------------------------------
r59342 | tkent@chromium.org | 2010-09-14 09:48:40 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: push back the detached tab position inside the dragging window. 

BUG=32597
TEST=manual
Patch by morrita@google
Original code review: http://codereview.chromium.org/3333018/show
------------------------------------------------------------------------
r59341 | jamesr@chromium.org | 2010-09-14 09:01:35 +0200 (Tue, 14 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 59324 and 59337.  Too many test failures

BUG=none
TEST=none
TBR=darin

Review URL: http://codereview.chromium.org/3431001
------------------------------------------------------------------------
r59338 | akalin@chromium.org | 2010-09-14 08:24:00 +0200 (Tue, 14 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc

Added some tweaks to sync notification settings.

- Added 250ms delay for notification nudges
- Bumped up limits for Tango to reduce the number of registration replies

BUG=55279
TEST=manual

Review URL: http://codereview.chromium.org/3411004
------------------------------------------------------------------------
r59337 | jamesr@chromium.org | 2010-09-14 08:02:16 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Force accelerated canvas 2d to always be off on Mac

BUG=54197
TEST=none

Review URL: http://codereview.chromium.org/3396002
------------------------------------------------------------------------
r59336 | akalin@chromium.org | 2010-09-14 07:56:26 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h

Replaced sync thread nudge queue with a single pending nudge.

This partially fixes a high QPS issue we're seeing with notifications.

BUG=55279
TEST=Manually

Review URL: http://codereview.chromium.org/3410002
------------------------------------------------------------------------
r59333 | dhollowa@chromium.org | 2010-09-14 06:02:53 +0200 (Tue, 14 Sep 2010) | 37 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card.cc

AutoFill credit card Valgrind errors.

Changes AutoFill CreditCard class to initialize billing_address_id_ member in constructors.  This was causing initialization errors to be flagged in Valgrind on Mac and Linux.  Initializing member to 0 fixes Valgrind.

Suppression (error hash=#FFFFFFFFF153AE3B#):
{
   <insert_a_suppression_name_here>
   Memcheck:Cond
   fun:__udivdi3
   fun:sqlite3VXPrintf
   fun:sqlite3_snprintf
   fun:sqlite3VdbeMemStringify
   fun:applyAffinity
   fun:sqlite3VdbeExec
   fun:sqlite3Step
   fun:sqlite3_step
   fun:_ZN3sql9Statement3RunEv
   fun:_ZN11WebDatabase13AddCreditCardERK10CreditCard
   fun:_ZN14WebDataService17AddCreditCardImplEPNS_14GenericRequestI10CreditCardEE
   fun:_Z16DispatchToMethodI14WebDataServiceMS0_FvPNS0_14GenericRequestI10CreditCardEEES4_EvPT_T0_RK6Tuple1IT1_E
   fun:_ZN14RunnableMethodI14WebDataServiceMS0_FvPNS0_14GenericRequestI10CreditCardEEE6Tuple1IS4_EE3RunEv
   fun:_ZN11MessageLoop7RunTaskEP4Task
   fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
   fun:_ZN11MessageLoop6DoWorkEv
   fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE
   fun:_ZN11MessageLoop11RunInternalEv
   fun:_ZN11MessageLoop10RunHandlerEv
}
etc.
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/7521/steps/memory%20test:%20unit/logs/stdio
http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/5915/steps/memory%20test:%20unit/logs/stdio

BUG=49094
TEST=Run Valgrind, verify no leaks or errors reported.
TBR=jhawkins

Review URL: http://codereview.chromium.org/3422001
------------------------------------------------------------------------
r59331 | satorux@chromium.org | 2010-09-14 05:48:43 +0200 (Tue, 14 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/user_metrics.h

Add a pointer to chrome/tools/extract_actions.py in user_metrics.h.

Having the pointer would be useful for those who want to use
RecordComputedAction(). For instance, I spent some to find out
the script.

BUG=none
TEST=compiled.

Review URL: http://codereview.chromium.org/3364020
------------------------------------------------------------------------
r59324 | jamesr@chromium.org | 2010-09-14 05:04:29 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Turn --enable-accelerated-2d-canvas into --disable-accelerated-2d-canvas

BUG=54197
TEST=browse to page with a 2d canvas with no command line flags, verify that it uses the GPU

Review URL: http://codereview.chromium.org/3382003
------------------------------------------------------------------------
r59323 | tfarina@chromium.org | 2010-09-14 04:38:02 +0200 (Tue, 14 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc

Remove create_app_shortcut param from ExtensionInstallUI::Delegate::InstallUIProceed.

Reason: We don't support shortcut creation from this dialog anymore.

(Note: this was a TODO for Aaron).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3305030
------------------------------------------------------------------------
r59322 | jrg@chromium.org | 2010-09-14 04:37:10 +0200 (Tue, 14 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Make bookmark UI tweaks more selective; earlier ones were a bit too
invasive.  (identified by mehmet@chromium.org)
e.g. kBookmarkHorizontalPadding split into kBookmarkHorizontalPadding
and kBookmarkSubMenuHorizontalPadding.

Make padding on very top and very bottom of folder menus equal,
and consistent if we have 0, 1, or N marks (and work even when a
mark is dragged in).

BUG= http://crbug.com/59174 http://crbug.com/55203 http://crbug.com/55476

Review URL: http://codereview.chromium.org/3410001
------------------------------------------------------------------------
r59303 | arv@chromium.org | 2010-09-14 01:47:06 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/net_internals/util.js
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js
   M /trunk/src/chrome/browser/resources/ntp/util.js
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.js
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_name_edit.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_add_language_overlay.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_proxy_rules_list.js
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js
   M /trunk/src/chrome/browser/resources/options/cookies_view.js
   M /trunk/src/chrome/browser/resources/options/edit_search_engine_overlay.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.js
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/command.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/splitter.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/tree.js
   M /trunk/src/chrome/browser/resources/shared/js/cr.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

DOMUI etc. Use the built in bind method of Function now that V8 supports it.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3308030
------------------------------------------------------------------------
r59302 | jrg@chromium.org | 2010-09-14 01:44:59 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Reland of http://src.chromium.org/viewvc/chrome?view=rev&revision=59278
http://codereview.chromium.org/3377001

(But this time without breaking the tree)

Review URL: http://codereview.chromium.org/3295031
------------------------------------------------------------------------
r59299 | willchan@chromium.org | 2010-09-14 01:01:55 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/ocsp/nss_ocsp.h

Revert r59289: "Eagerly set the IO loop used for OCSP."

eroman caught a race in it.

BUG=36740
TEST=none

Review URL: http://codereview.chromium.org/3376005
------------------------------------------------------------------------
r59297 | bryeung@chromium.org | 2010-09-14 00:53:00 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

1 word change, to prevent confusion.

This error message misdirected me today.  I think this makes a bit more sense.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3292021
------------------------------------------------------------------------
r59296 | estade@chromium.org | 2010-09-14 00:43:05 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/labs.cc

Add tabbed options to labs.

BUG=55429
TEST=manual

Review URL: http://codereview.chromium.org/3357030
------------------------------------------------------------------------
r59294 | csilv@chromium.org | 2010-09-14 00:30:56 +0200 (Tue, 14 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

dom-ui options: Connect option related commands to the dom-ui options window.

BUG=54147
TEST=Verify that 'Clear Browsing Data' and 'Import' menu commands invoke the dom-ui options window.
Review URL: http://codereview.chromium.org/3319016
------------------------------------------------------------------------
r59291 | phajdan.jr@chromium.org | 2010-09-14 00:25:01 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc

Regression fix: cancel all downloads when shutting down DownloadManager.

BUG=54823
TEST=see bug

Review URL: http://codereview.chromium.org/3327024
------------------------------------------------------------------------
r59290 | dumi@chromium.org | 2010-09-14 00:22:39 +0200 (Tue, 14 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Defend against a malicious renderer trying to upload a file to which
it doesn't have access.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3363014
------------------------------------------------------------------------
r59289 | willchan@chromium.org | 2010-09-14 00:20:27 +0200 (Tue, 14 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/ocsp/nss_ocsp.h

Eagerly set the IO loop used for OCSP.

This prevents the IO loop being set to sync's thread instead of the IO thread.

BUG=36740
TEST=none

Review URL: http://codereview.chromium.org/3377002
------------------------------------------------------------------------
r59287 | phajdan.jr@chromium.org | 2010-09-14 00:12:53 +0200 (Tue, 14 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_unittest.cc
   M /trunk/src/tools/heapcheck/suppressions.txt

Fix a heapchecker leak by fixing a test.

BUG=53936
TEST=see bug

Review URL: http://codereview.chromium.org/3296021
------------------------------------------------------------------------
r59281 | phajdan.jr@chromium.org | 2010-09-13 23:22:48 +0200 (Mon, 13 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h

Revert 59278 - UI tweaks from cole as initiated by a discussion with Mehmet.

BUG=http://crbug.com/59174, http://crbug.com/55203, others

TEST=Open a bookmark folder.  See right/left side margin (between mark
and window border) as the same and as "not too squeezed in".  Open
subfolder; see more menu overlap than before.


Review URL: http://codereview.chromium.org/3377001

TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/3330023
------------------------------------------------------------------------
r59280 | sky@chromium.org | 2010-09-13 23:05:47 +0200 (Mon, 13 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h

Makes NavigationController:set_max_restored_page_id public. I need to
invoke this when doing match preview to make sure new navigations
don't end up using an ID I might have to merge with.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3325027
------------------------------------------------------------------------
r59278 | jrg@chromium.org | 2010-09-13 22:49:54 +0200 (Mon, 13 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h

UI tweaks from cole as initiated by a discussion with Mehmet.

BUG=http://crbug.com/59174, http://crbug.com/55203, others

TEST=Open a bookmark folder.  See right/left side margin (between mark
and window border) as the same and as "not too squeezed in".  Open
subfolder; see more menu overlap than before.


Review URL: http://codereview.chromium.org/3377001
------------------------------------------------------------------------
r59276 | jhawkins@chromium.org | 2010-09-13 22:38:57 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardSheet.xib
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/credit_card_unittest.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.h
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.js
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

DOMUI: Implement adding and editing credit cards in the AutoFill page.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3308006
------------------------------------------------------------------------
r59275 | estade@chromium.org | 2010-09-13 22:34:41 +0200 (Mon, 13 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

[GTK] extra special handling for bookmark bar drags

when dragging over a bookmark folder, when the drag is near the left or right edge, treat it like a toolbar drag.

BUG=51253
TEST=see bug

Review URL: http://codereview.chromium.org/3354024
------------------------------------------------------------------------
r59270 | jeanluc@google.com | 2010-09-13 22:06:17 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_store.h
   M /trunk/src/chrome/browser/prefs/pref_set_observer.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add constants for preferences and policies related to the Default Search Provider. Add code to read these new policies into prefs. Add code to enable monitoring change to these preferences. 

BUG=49306
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.* 

Review URL: http://codereview.chromium.org/3374004
------------------------------------------------------------------------
r59269 | davemoore@chromium.org | 2010-09-13 22:06:05 +0200 (Mon, 13 Sep 2010) | 25 lines
Changed paths:
   M /trunk/src/app/x11_util.cc
   M /trunk/src/app/x11_util.h
   M /trunk/src/app/x11_util_internal.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   A /trunk/src/chrome/browser/browser_main_gtk.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc

This is a second attempt of http://codereview.chromium.org/3175038

It failed the Vista Perf UI tests. This is because those tests close the browser upon an error. And they always get an error when the session is closed in the middle of the test.

The new changes are in chrome/browser/automation/testing_automation_provider.cc

BUG=50006
TEST=Run chrome under nested window manager using Xephyr (see
http://code.google.com/p/chromium/wiki/LayoutTestsLinux)

use --enable-logging=stderr --log-level=0
kill xephyr
examine log. You should see
X IO Error detected
followed (not necessarily immediately) by
successfully saved /tmp/tx/Default/Preferences
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Default/Preferences
along with no crash.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3364019
------------------------------------------------------------------------
r59264 | erg@google.com | 2010-09-13 21:40:08 +0200 (Mon, 13 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_editor.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_history.cc
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   A /trunk/src/chrome/browser/download/download_types.cc
   M /trunk/src/chrome/browser/download/download_types.h
   M /trunk/src/chrome/browser/download/download_util.cc
   A /trunk/src/chrome/browser/history/download_create_info.cc
   A /trunk/src/chrome/browser/history/download_create_info.h (from /trunk/src/chrome/browser/history/download_types.h:59259)
   M /trunk/src/chrome/browser/history/download_database.cc
   A /trunk/src/chrome/browser/history/download_types.cc
   D /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome_frame/chrome_frame.gyp

FBTF: Move ctors/dtors into cc files.

This cleanup patch isn't as impactful; this only shrinks our .a files by 304k.

This patch also renames chrome/browser/history/download_type.h to download_create_info.h because there are then two download_type.cc files and MSVS will have the .obj from one of those overwrite the other.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3351005
------------------------------------------------------------------------
r59263 | akalin@chromium.org | 2010-09-13 21:40:07 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Fixed == vs. = bug that screws up the Sync.ReauthorizationTime histogram.

BUG=40361
TEST=None

Review URL: http://codereview.chromium.org/3292020
------------------------------------------------------------------------
r59262 | jhawkins@chromium.org | 2010-09-13 21:39:19 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/printing/page_overlays.cc
   M /trunk/src/printing/page_overlays_unittest.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printed_document.h
   M /trunk/src/printing/printed_pages_source.h
   M /trunk/src/printing/printing_context.h
   M /trunk/src/printing/printing_context_cairo.cc
   M /trunk/src/printing/printing_context_mac.mm
   M /trunk/src/printing/printing_context_win.cc

Printing: Convert several wstrings to string16.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3292019
------------------------------------------------------------------------
r59260 | shess@chromium.org | 2010-09-13 21:35:52 +0200 (Mon, 13 Sep 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

Revert "Make AutomationProvider fail fast on messages it doesn't understand."

Original review: http://codereview.chromium.org/3224001

The mentioned bug involves a crash on chromebot on Mac.  My working
hypothesis, based on some of the log messages seen, is that some file
descriptors are being trashed.  The CL being reverted closes the
channel while handling a message, which seems like it has potential to
be a problem.

Since this should not have user-facing impact, I am reverting the
change for merging to the 517 branch, after which I will re-instate
the change.  We have been trying to verify that this change is in the
crashing set, or out, but our data turned out to be incorrect, so I'm
doing this in parallel with a new run.

BUG=54453
TEST=chromebot

Review URL: http://codereview.chromium.org/3317023
------------------------------------------------------------------------
r59252 | rohitrao@chromium.org | 2010-09-13 20:48:33 +0200 (Mon, 13 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm

[Mac] Remove an InfobarController DCHECK that doesn't belong.

BUG=52524
TEST=Repro steps in bug.  DCHECK should not fire in Debug builds.
Review URL: http://codereview.chromium.org/3322004
------------------------------------------------------------------------
r59248 | rogerta@google.com | 2010-09-13 20:18:18 +0200 (Mon, 13 Sep 2010) | 20 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

Revert 59138 - Revert 59123 - Don't use the return value of rlz_lib::SendFinancialPing() as the return value
of the chrome extension API, since a false does not represent an error. Added
an optional callback to the API so that caller can determine if the ping was
sent or not.

This CL is to reapply change 58827, which was reverted due to a test break.
I found an uninitialized variable in the underlying RLZ code, see
http://code.google.com/p/rlz/source/detail?r=18 for the fix.  This CL includes
a bump of the RLZ library to get this fix.  The tests have been expanded a bit
too since 58827.

BUG=54294
TEST=n/a

Review URL: http://codereview.chromium.org/3350016

Review URL: http://codereview.chromium.org/3330019

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3323028
------------------------------------------------------------------------
r59242 | agl@chromium.org | 2010-09-13 20:10:48 +0200 (Mon, 13 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/tools/chrome-process-identifier.sh

Run worker processes via the zygote.

The following tests fail when using the SUID sandbox because they try to count
processes and the extra sandbox processes throw them off. They pass with this
patch so long as the SUID sandbox isn't invoked (which is the case on the
builders):
 WorkerTest.FLAKY_MultipleTabsQueuedSharedWorker
 WorkerTest.FLAKY_LimitPerPage
 WorkerTest.WorkerClose
 WorkerTest.QueuedSharedWorkerShutdown
 WorkerTest.FLAKY_QueuedSharedWorkerStartedFromOtherTab

Note that this patch doesn't trigger the seccomp sandbox for worker
processes.  That will have to wait for another CL.

BUG=54794
TEST=ui_tests

http://codereview.chromium.org/3312021/show
------------------------------------------------------------------------
r59236 | jrg@chromium.org | 2010-09-13 19:57:41 +0200 (Mon, 13 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Catch one more case of logical focus-lost on a bookmark bar folder.

BUG=http://crbug.com/49333

Review URL: http://codereview.chromium.org/3328021
------------------------------------------------------------------------
r59235 | alekseys@chromium.org | 2010-09-13 19:48:02 +0200 (Mon, 13 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/sidebar_controller.mm

Do not change sidebar width proportionally when browser window is resized.

BUG=31633
TEST=Run browser_tests and interactive_ui_tests.
Review URL: http://codereview.chromium.org/3367025
------------------------------------------------------------------------
r59233 | alekseys@chromium.org | 2010-09-13 19:42:59 +0200 (Mon, 13 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Resize page contents view to match window size first time it's added into view hierarchy to avoid flashing.

BUG=55093
TEST=1. Make sure "Always show bookmark bar" is checked
2. close all Chromium windows (but don't quit)
3. open a new Chromium window by clicking on the Dockicon or by hitting CMD+N
4. Take a look on the NewTabPage while the window opens, scrollbars should not flash

Review URL: http://codereview.chromium.org/3323024
------------------------------------------------------------------------
r59228 | tim@chromium.org | 2010-09-13 19:00:38 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer_unittest.cc
   M /trunk/src/chrome/browser/sync/util/nigori_unittest.cc
   M /trunk/src/chrome/common/common_param_traits_unittest.cc

Disable tests that are crashing but currently passing due to an overridden assert handler.

BUG=55177,55178,55180,55181
TEST=unit_tests

Review URL: http://codereview.chromium.org/3303025
------------------------------------------------------------------------
r59227 | jrg@chromium.org | 2010-09-13 18:59:33 +0200 (Mon, 13 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Lock fullscreen chrome on transition from one one bookmark folder to
another.  Eliminate transition hazard.

BUG=http://crbug.com/53550

TEST=Place 2 bookmark folders on bar.  Go fullscreen.  Move mouse up
so chrome opens.  Click on one folder, then scroll down a little.
Move mouse to the side (so it's in a position that would NOT trigger
the chrome to be open) then quickly go up and click on 2nd folder.  If
the 2nd folder has the right y position, success!  If it's pegged to
the top of the screen, fail.  Repeat a few times.




Review URL: http://codereview.chromium.org/3297024
------------------------------------------------------------------------
r59218 | thomasvl@chromium.org | 2010-09-13 15:16:09 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Marking some bugs as flaky that are failing on chromium xp a lot now.

TBR=vandebo
BUG=55380
TEST=greener tree
Review URL: http://codereview.chromium.org/3290026
------------------------------------------------------------------------
r59217 | bryeung@chromium.org | 2010-09-13 15:05:37 +0200 (Mon, 13 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_url_handler.h

Make the list of handlers private.

It looks like that is what was intended.

TEST=still compiles
BUG=NONE

Review URL: http://codereview.chromium.org/3361012
------------------------------------------------------------------------
r59215 | jnd@google.com | 2010-09-13 14:23:23 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/popup_blocker_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/popup_blocker
   A /trunk/src/chrome/test/data/popup_blocker/popup-blocked-to-post-blank.html

Add a browser test for popup blocker to test blank-post blocked. For the details, please refer to https://bugs.webkit.org/show_bug.cgi?id=44969.

BUG=34414
test=popup-blocked-to-post-blank

Review URL: http://codereview.chromium.org/3291012
------------------------------------------------------------------------
r59213 | allanwoj@chromium.org | 2010-09-13 12:55:17 +0200 (Mon, 13 Sep 2010) | 18 lines
Changed paths:
   M /trunk/src/AUTHORS
   A /trunk/src/chrome/browser/geolocation/core_location_data_provider_mac.h
   A /trunk/src/chrome/browser/geolocation/core_location_data_provider_mac.mm
   A /trunk/src/chrome/browser/geolocation/core_location_provider_mac.h
   A /trunk/src/chrome/browser/geolocation/core_location_provider_mac.mm
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.h
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add CoreLocation support to Chrome.

Patch from Jorge Villatoro <jorge@tomatocannon.com>

This add core location support to the Geolocation code.  Included are the base
location provider class, a data provider class that allows CoreLocation to run
on the UI thread, and an Objective C wrapper for CoreLocation.  Hints were taken
from the CoreWLAN Api class in the same directory for dynamically loading the
framework, since CoreLocation is only available on Snow Leopard (Mac OS X 10.6)

This new provider has also been added to the location arbitrator in the same way
that the libgps provider was added.

BUG=45548
TEST=Open the browser with the --enable-geolocation argument on 10.6 and visit
http://maps.google.com/maps/m

Review URL: http://codereview.chromium.org/3092015
------------------------------------------------------------------------
r59212 | jochen@chromium.org | 2010-09-13 09:06:52 +0200 (Mon, 13 Sep 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   M /trunk/src/chrome/common/page_transition_types.cc
   M /trunk/src/chrome/common/page_transition_types.h
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html

Reland r54723. Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3310025
------------------------------------------------------------------------
r59202 | mdm@chromium.org | 2010-09-12 21:13:02 +0200 (Sun, 12 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/login_database_posix.cc

Linux: fix retrieving passwords with non-ASCII characters from the default password store.
TEST=save a password containing a non-ASCII character, it should autofill correctly
BUG=54065
Review URL: http://codereview.chromium.org/3316014
------------------------------------------------------------------------
r59192 | sky@chromium.org | 2010-09-11 20:06:54 +0200 (Sat, 11 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/test/test_location_bar.h

Adds support for the location bar to show suggested text. There are
still a couple of rough edges, but this is a good start.

BUG=54833
TEST=none

Review URL: http://codereview.chromium.org/3333027
------------------------------------------------------------------------
r59191 | willchan@chromium.org | 2010-09-11 19:43:49 +0200 (Sat, 11 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Revert r59190 for regressing startup tests.

BUG=36740
TEST=

Review URL: http://codereview.chromium.org/3341029
------------------------------------------------------------------------
r59190 | willchan@chromium.org | 2010-09-11 18:51:13 +0200 (Sat, 11 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Eagerly initialize NSS and OCSP on IOThread.

IOThread and the sync thread race to initialize OCSP (lazily done by SSLClientSocketNSS), but OCSP is only allowed to be initialized on the IOThread.  So we eagerly initialize it to prevent the race.  Hopefully this doesn't regress startup time!

BUG=36740
TEST=none

Review URL: http://codereview.chromium.org/3327019
------------------------------------------------------------------------
r59189 | sky@chromium.org | 2010-09-11 17:15:08 +0200 (Sat, 11 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Adds a notification event for onload. I would have liked to plumb this
through to the TabContentsDelegate, but at the time I need another
delegate will have been installed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3306015
------------------------------------------------------------------------
r59187 | satish@chromium.org | 2010-09-11 10:02:43 +0200 (Sat, 11 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble_views.cc

Fix chrome os build break caused by passing string16 where a wstring was expected.

TBR=vandebo
BUG=none
TEST=none
------------------------------------------------------------------------
r59184 | satish@chromium.org | 2010-09-11 09:29:34 +0200 (Sat, 11 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble_views.cc

Extend speech input bubble on windows to display error messages with try-again and cancel buttons.

For recognition status, the bubble shows:
-  "Speak now" at the top
-  Image/icon with status below that
-  "Cancel" button at the bottom

In message mode, the bubble shows:
-  The given message (could span multiple lines) at the top
-  A row of 2 buttons at the bottom, "Try again" and "Cancel"

BUG=53598
TEST=manual, unplug mic and start recognition to check error message, and similarly give no speech to check.

Review URL: http://codereview.chromium.org/3300029
------------------------------------------------------------------------
r59183 | isherman@chromium.org | 2010-09-11 07:20:42 +0200 (Sat, 11 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Handle FocusSearch() when in forced search mode with leading whitespace.

BUG=29593
TEST=browser_tests --gtest_filter=AutocompleteBrowserTest.FocusSearch

Review URL: http://codereview.chromium.org/3280012
------------------------------------------------------------------------
r59180 | arv@chromium.org | 2010-09-11 03:30:13 +0200 (Sat, 11 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Fix issue where the name of the newly created folder was not
editable.

BUG=52339
TEST=Right click on a folder in the folder tree
     Add folder
     The folder name should be editable.

Review URL: http://codereview.chromium.org/3326019
------------------------------------------------------------------------
r59175 | davemoore@chromium.org | 2010-09-11 01:43:24 +0200 (Sat, 11 Sep 2010) | 22 lines
Changed paths:
   M /trunk/src/app/x11_util.cc
   M /trunk/src/app/x11_util.h
   M /trunk/src/app/x11_util_internal.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   D /trunk/src/chrome/browser/browser_main_gtk.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc

Revert 59147 - Allow overriding of X error functions
BUG=50006 (and various other reports)
TEST=Run chrome under nested window manager using Xephyr (see
http://code.google.com/p/chromium/wiki/LayoutTestsLinux)

use --enable-logging=stderr --log-level=0
kill xephyr
examine log. You should see
X IO Error detected
followed (not necessarily immediately) by
successfully saved /tmp/tx/Default/Preferences
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Default/Preferences
along with no crash.

There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully.

Review URL: http://codereview.chromium.org/3175038

TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/3332019
------------------------------------------------------------------------
r59174 | johnnyg@chromium.org | 2010-09-11 01:32:51 +0200 (Sat, 11 Sep 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.cc

cleanup orphaned file after r59105, which renamed this file but didn't delete the old one.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3336020
------------------------------------------------------------------------
r59173 | jrg@chromium.org | 2010-09-11 01:32:01 +0200 (Sat, 11 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Be more accurate on a bookmark folder scroll trigger.

ALso fix broken unit test.

BUG=http://crbug.com/51640

TEST=place a million bookmarks in a folder.  Open the folder.  Make
sure the scroll up only happens when the mouse is over the arrow
(horiz positioning doesn't matter).  Now that the scroll down arrow
(at top of screen) has appeared, make sure the scroll down only
happens when the mouse is over the arrow (again, horiz positioning
doesn't matter).


Review URL: http://codereview.chromium.org/3327017
------------------------------------------------------------------------
r59169 | jrg@chromium.org | 2010-09-11 00:54:01 +0200 (Sat, 11 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Fix bookmark button padding.

BUG=http://crbug.com/48681

TEST=open bookmark folder.  Mouse-over a button to highlight it.  zoom
in (e.g. ctrl-scroll-up).  Make sure padding on right and left sides
are equal.  (Previously we had too much padding on right side).


Review URL: http://codereview.chromium.org/3361014
------------------------------------------------------------------------
r59166 | satish@chromium.org | 2010-09-11 00:46:52 +0200 (Sat, 11 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/speech_input_window_controller.mm
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller.h
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller_unittest.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm
   M /trunk/src/chrome/browser/speech/speech_input_bubble_views.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc

We used to show error messages as info bars earlier. Based on UX feedback, we now show the messages within the speech input UI bubble. We also let the user retry recognition without returning the error to the web page unless the user clicked the cancel button or closed the bubble.

For this to work, we now keep the request alive in the SpeechInputManager map until it completes successfully or user explicitly cancelled it. We also keep the SpeechInputBubble object alive, even when the actual bubble window is not visible on screen, and construct the window if required whenever we want to show the recording status or error message on screen.

BUG=53598
TEST=unit_tests --gtest_filter=SpeechInputBubbleControllerTest.*

Review URL: http://codereview.chromium.org/3352018
------------------------------------------------------------------------
r59165 | sky@chromium.org | 2010-09-11 00:36:26 +0200 (Sat, 11 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/renderer/search_extension.cc
   A /trunk/src/chrome/renderer/search_extension.h

Plumbs through window.chrome.setSuggestResult. It's currently hidden behind a flag.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3312017
------------------------------------------------------------------------
r59164 | estade@chromium.org | 2010-09-11 00:33:58 +0200 (Sat, 11 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc

Convert some importer NOTREACHED() cases to LOG(WARNING)s.

We could conceivably hit these lines if the firefox profile is in a weird state.

BUG=54718
TEST=none

Review URL: http://codereview.chromium.org/3305019
------------------------------------------------------------------------
r59163 | phajdan.jr@chromium.org | 2010-09-11 00:28:10 +0200 (Sat, 11 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_info_unittest.cc

Mark DnsHostInfoTest.StateChangeTest as flaky.

TBR=jar

BUG=55169
TEST=unit_tests

Review URL: http://codereview.chromium.org/3324016
------------------------------------------------------------------------
r59160 | estade@chromium.org | 2010-09-11 00:21:55 +0200 (Sat, 11 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc

[GTK] Only use label wrapping workaround when in RTL mode.

BUG=none
TEST=see attached image

Review URL: http://codereview.chromium.org/3351023
------------------------------------------------------------------------
r59159 | jhawkins@chromium.org | 2010-09-11 00:13:17 +0200 (Sat, 11 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/app/text_elider.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Cleanup: Convert net::StripWWW to string16 and fix up the callsites.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3360023
------------------------------------------------------------------------
r59158 | estade@chromium.org | 2010-09-11 00:08:01 +0200 (Sat, 11 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc

[GTK] disable drag image for non-compositing WMs.

BUG=55143
TEST=drag something in the render view

Review URL: http://codereview.chromium.org/3351024
------------------------------------------------------------------------
r59157 | aa@chromium.org | 2010-09-11 00:04:28 +0200 (Sat, 11 Sep 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Add a confirmation prompt to app uninstallation on the ntp.

The uninstall dialog used to say:

[===============================x]
|Confirm Uninstallation          |
|--------------------------------|
|<b>Uninstall Foo Extension?</b> |
|                                |
|Are you sure you want to        |
|uninstall this extension?       |
|                                |
|================================|

We don't have the bottom string with the word 'app', and I
realized it is somewhat extraneous anyway. So just removed it
in all cases and de-bolded the text above. Looks much better.

Also, fixed a bug where the icon we display in the GTK
dialogs is too big by doing image resizing in
ExtensionInstallUI.

BUG=54874
TEST=Uninstall app and extension. Both should have a prompt,
and UI layout should be the same.

Review URL: http://codereview.chromium.org/3332016
------------------------------------------------------------------------
r59156 | phajdan.jr@chromium.org | 2010-09-11 00:00:30 +0200 (Sat, 11 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

GTTF: download cleanup, rename things to be more accurate.

Also, moved some code closer to the object it's operating on.

BUG=48913
TEST=unit_tests, ui_tests, browser_tests

Review URL: http://codereview.chromium.org/3341013
------------------------------------------------------------------------
r59155 | thakis@chromium.org | 2010-09-10 23:37:49 +0200 (Fri, 10 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_exceptions_table_model.h
   M /trunk/src/chrome/browser/plugin_exceptions_table_model_unittest.cc

Fix gcc 4.2 warning in unit test.

As seen at http://build.chromium.org/buildbot/try-server/builders/mac/builds/45974/steps/compile/logs/stdio :

warning: 'PluginExceptionsTableModelTest' has a field 'PluginExceptionsTableModelTest::table_model_' whose type uses the anonymous namespace

The fix for that is to move the test into the anonymous namespace too, which breaks the friend declaration. So I need to work around that, too.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3345019
------------------------------------------------------------------------
r59147 | davemoore@chromium.org | 2010-09-10 22:40:34 +0200 (Fri, 10 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/app/x11_util.cc
   M /trunk/src/app/x11_util.h
   M /trunk/src/app/x11_util_internal.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   A /trunk/src/chrome/browser/browser_main_gtk.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc

Allow overriding of X error functions
BUG=50006 (and various other reports)
TEST=Run chrome under nested window manager using Xephyr (see
http://code.google.com/p/chromium/wiki/LayoutTestsLinux)

use --enable-logging=stderr --log-level=0
kill xephyr
examine log. You should see
X IO Error detected
followed (not necessarily immediately) by
successfully saved /tmp/tx/Default/Preferences
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Default/Preferences
along with no crash.

There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully.

Review URL: http://codereview.chromium.org/3175038
------------------------------------------------------------------------
r59145 | phajdan.jr@chromium.org | 2010-09-10 22:38:41 +0200 (Fri, 10 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/test_switches.cc
   M /trunk/src/chrome/test/test_switches.h
   A /trunk/src/chrome/test/test_timeouts.cc
   A /trunk/src/chrome/test/test_timeouts.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc

GTTF: Move UI test timeouts to a centralized place, chrome/test/test_timeouts.

Next patches will also centralize timeouts for our other test binaries
based on that file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3308020
------------------------------------------------------------------------
r59144 | scottbyer@google.com | 2010-09-10 22:38:32 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc

Fix unit test for GView interceptor.

Fix GView interceptor unit tests to match what is supposed to happen in the presence of the PDF internal plug-in on ChromeOS.

BUG=51242
TEST=GViewRequestInterceptorTest.DoNotInterceptPdfWhenEnabled, GViewRequestInterceptorTest.InterceptPdfWhenDisabled

Review URL: http://codereview.chromium.org/3308016
------------------------------------------------------------------------
r59143 | estade@chromium.org | 2010-09-10 22:32:44 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

Fix top of new first run search engine choice in RTL.

BUG=54898
TEST=first run in Hebrew

Review URL: http://codereview.chromium.org/3369012
------------------------------------------------------------------------
r59142 | twiz@google.com | 2010-09-10 22:29:11 +0200 (Fri, 10 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h

Partial clone of the following CL:  http://codereview.chromium.org/3013045/show

Differences from the above CL include the following:
 - RendererPreferences settings for ExtensionHosts are now extracted from the associated_tab_contents().  This ensures that extension hosts will also forward top level navigation requests.
 - Instead of explicitly setting the delegate on the TabContents in ExtensionHost::ShowCreatedWindow, instead I instruct the associated tab-contents to add the newly build tab-contents.  Note that this is the exact same behaviour performed by TabContents when initiating a top-level navigation to the host browser.  

Points of interest:
 - See the TODO in navigation_controller.cc.  This problem of an unrecognized navigation entry needs further investigation.
 - Also, I found that if the ActiveX control is navigated to a chrome-extension URL, then the top-level-navigation will fail because of the format of the URL.  The fix was to construct a temporary url in place of the chrome-extension url.

BUG=51091
TEST=None 

Review URL: http://codereview.chromium.org/3357013
------------------------------------------------------------------------
r59141 | rlp@chromium.org | 2010-09-10 22:27:13 +0200 (Fri, 10 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/gpu_process_host_ui_shim.cc
   M /trunk/src/chrome/browser/gpu_process_host_ui_shim.h
   M /trunk/src/chrome/common/gpu_info.cc
   M /trunk/src/chrome/common/gpu_info.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h

Updating the about:gpu to start a webgl context if one does not exist so that some gpu_info will actually exist. It does this by refreshing the page every 5 seconds until a context does exist, if necessary.

We also looked into other methods:
- synchronous call to create context, but that will hang if there are issues creating a context
- a call back, but that will also hang until we have a gpu context
- display no data and rely on the user to refresh which is somewhat unintuitive to the user

The method in this CL seemed to be the least annoying method of doing this which didn't cause the browser to hang.

BUG=none
TEST=visual

Review URL: http://codereview.chromium.org/3348007
------------------------------------------------------------------------
r59140 | jianli@chromium.org | 2010-09-10 22:25:52 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/blob_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/blob_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Add the security check to ensure that the child process has the permission to read files when registering the blob data.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3326017
------------------------------------------------------------------------
r59139 | phajdan.jr@chromium.org | 2010-09-10 22:21:13 +0200 (Fri, 10 Sep 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/download/base_file.cc
   M /trunk/src/chrome/browser/download/base_file.h
   M /trunk/src/chrome/browser/download/base_file_unittest.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

GTTF: Clean up DownloadFileManager

This removes a lot of duplication, locking, and thread jumping.

Most of the operations run on the FILE thread, and we do not duplicate
so much information. Each DownloadFile keeps track of its DownloadManager
(each Profile has its own DownloadManager). This allows us to remove
many maps from DownloadFileManager that were duplicating that information.

There is still SaveFileManager, but hopefully I will be able
to merge those two in small steps.

Hopefully, this is http://codereview.chromium.org/3245005 done right.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3347018
------------------------------------------------------------------------
r59138 | sky@chromium.org | 2010-09-10 22:14:37 +0200 (Fri, 10 Sep 2010) | 18 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

Revert 59123 - Don't use the return value of rlz_lib::SendFinancialPing() as the return value
of the chrome extension API, since a false does not represent an error. Added
an optional callback to the API so that caller can determine if the ping was
sent or not.

This CL is to reapply change 58827, which was reverted due to a test break.
I found an uninitialized variable in the underlying RLZ code, see
http://code.google.com/p/rlz/source/detail?r=18 for the fix.  This CL includes
a bump of the RLZ library to get this fix.  The tests have been expanded a bit
too since 58827.

BUG=54294
TEST=n/a

Review URL: http://codereview.chromium.org/3350016

TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/3330019
------------------------------------------------------------------------
r59134 | akalin@chromium.org | 2010-09-10 22:03:15 +0200 (Fri, 10 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/jingle/jingle.gyp
   M /trunk/src/jingle/notifier/base/notifier_options.h
   D /trunk/src/jingle/notifier/base/signal_thread_task.h
   D /trunk/src/jingle/notifier/base/ssl_adapter.cc
   D /trunk/src/jingle/notifier/base/ssl_adapter.h
   D /trunk/src/jingle/notifier/base/static_assert.h
   M /trunk/src/jingle/notifier/communicator/login.cc
   M /trunk/src/jingle/notifier/communicator/login.h
   D /trunk/src/jingle/notifier/communicator/product_info.cc
   D /trunk/src/jingle/notifier/communicator/product_info.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.h
   D /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.cc
   D /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc
   D /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.cc
   D /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/jingle_glue/jingle_client.cc
   A /trunk/src/remoting/jingle_glue/ssl_adapter.cc (from /trunk/src/jingle/notifier/base/ssl_adapter.cc:59118)
   A /trunk/src/remoting/jingle_glue/ssl_adapter.h (from /trunk/src/jingle/notifier/base/ssl_adapter.h:59118)
   A /trunk/src/remoting/jingle_glue/ssl_socket_adapter.cc (from /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.cc:59118)
   A /trunk/src/remoting/jingle_glue/ssl_socket_adapter.h (from /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.h:59118)
   A /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.cc (from /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.cc:59118)
   A /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.h (from /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.h:59118)
   M /trunk/src/remoting/remoting.gyp

Removed use of XmppSocketAdapter by sync.

Moved XmppSocketAdapter and friends to remoting directory.

Removed some dead code in jingle/.

This is a relanding of 59012, which was mistakenly reverted at 59104.

BUG=54146,55116
TEST=none
TBR=willchan

Review URL: http://codereview.chromium.org/3300030
------------------------------------------------------------------------
r59133 | tommi@chromium.org | 2010-09-10 21:52:18 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/policy/dummy_configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_provider.h

Refactoring the policy classes to allow the list of policy items of a policy provider to be specified via the constructor.

Subsequently we will be able to use these classes for Chrome Frame as well without adding Chrome Frame policy entries to Chrome's.

TEST=Run the policy tests.  There should be no change since I'm mostly just shifting code around.
BUG=29349

Review URL: http://codereview.chromium.org/3298012
------------------------------------------------------------------------
r59132 | phajdan.jr@chromium.org | 2010-09-10 21:51:15 +0200 (Fri, 10 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/net/base/host_port_pair.cc
   M /trunk/src/net/base/host_port_pair.h

Add HostForURL to HostPortPair and use it to make sure
the code is IPv6-correct.

This is a follow-up to an earlier review.

BUG=none
TEST=ui_tests

Review URL: http://codereview.chromium.org/3372008
------------------------------------------------------------------------
r59123 | rogerta@google.com | 2010-09-10 21:01:49 +0200 (Fri, 10 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

Don't use the return value of rlz_lib::SendFinancialPing() as the return value
of the chrome extension API, since a false does not represent an error. Added
an optional callback to the API so that caller can determine if the ping was
sent or not.

This CL is to reapply change 58827, which was reverted due to a test break.
I found an uninitialized variable in the underlying RLZ code, see
http://code.google.com/p/rlz/source/detail?r=18 for the fix.  This CL includes
a bump of the RLZ library to get this fix.  The tests have been expanded a bit
too since 58827.

BUG=54294
TEST=n/a

Review URL: http://codereview.chromium.org/3350016
------------------------------------------------------------------------
r59120 | cmasone@google.com | 2010-09-10 20:29:09 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h
   M /trunk/src/chrome/browser/chromeos/login/mock_owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   M /trunk/src/chrome/browser/chromeos/login/signed_settings.cc

[Chrome OS] expose async crypto API via CryptohomeLibrary

Also, get ride of the template on LoginLibrary::Delegate.  Most of the files are here due to that.

BUG=chromium-os:4929
TEST=None

Review URL: http://codereview.chromium.org/3319018
------------------------------------------------------------------------
r59118 | georgey@chromium.org | 2010-09-10 20:07:11 +0200 (Fri, 10 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Implementation of "If AufoFill options is opened, the profile is not saved." for Windows
BUG=54871
TEST=in the bug
Review URL: http://codereview.chromium.org/3375001
------------------------------------------------------------------------
r59117 | rdsmith@chromium.org | 2010-09-10 20:06:57 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/net/base/cookie_monster.cc

Fixed typo where I was using "net." prefix rather than "Net." prefix.  Also changed prefix on all newly added
histograms over to "Cookie."; there are enough such (and
Net. is already big enough) that a new group seemed warranted.

BUG=None
TEST=Trybots only.

Review URL: http://codereview.chromium.org/3319019
------------------------------------------------------------------------
r59114 | albertb@chromium.org | 2010-09-10 19:58:22 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/password_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Don't start the PasswordModelWorker if there's no PasswordStore.

BUG=52367
TEST=none

Review URL: http://codereview.chromium.org/3368010
------------------------------------------------------------------------
r59110 | jrg@chromium.org | 2010-09-10 19:31:05 +0200 (Fri, 10 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm

When holding command and moving/scrolling over folders on bookmark folder menu, don't "open all".

BUG=http://crbug.com/52488
TEST=
1) Confirm command-click on a folder still does OpenAllInNewTab.
2) Open a folder than has subfolders with bookmarks in them.  
  Hold command and move mouse slowly across the folder.
  Make sure an "open all" is NOT triggered.

Review URL: http://codereview.chromium.org/3329021
------------------------------------------------------------------------
r59105 | jcivelli@chromium.org | 2010-09-10 18:54:49 +0200 (Fri, 10 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/file_select_helper.cc
   A /trunk/src/chrome/browser/file_select_helper.h (from /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.h:59104)
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   D /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.h
   M /trunk/src/chrome/chrome_browser.gypi

Input file type now supported in extension popups.
To do this, this CL generalize the TabContentsFileSelectHelper (renamed FileSelectHelper) so it is associated with a RenderViewHost rather than a TabContents.
This allows the extension popups which don't use a TabContents to use it.

As part of that, I also moved GetTopLevelNativeWindow() from TabContentsView to TabContent, as it can be implemented in a non-platform specific way.

BUG=28829
TEST=Make sure you can still open file on web pages (such as http://www.cs.tut.fi/~jkorpela/forms/file.html.
     Create an extension with a popup that contains an input file tag. Make sure it does open a file dialog and lets you choose a file.

Review URL: http://codereview.chromium.org/3209002
------------------------------------------------------------------------
r59104 | willchan@chromium.org | 2010-09-10 18:53:42 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/jingle/jingle.gyp
   M /trunk/src/jingle/notifier/base/notifier_options.h
   A /trunk/src/jingle/notifier/base/signal_thread_task.h
   A /trunk/src/jingle/notifier/base/ssl_adapter.cc (from /trunk/src/remoting/jingle_glue/ssl_adapter.cc:59094)
   A /trunk/src/jingle/notifier/base/ssl_adapter.h (from /trunk/src/remoting/jingle_glue/ssl_adapter.h:59094)
   A /trunk/src/jingle/notifier/base/static_assert.h
   M /trunk/src/jingle/notifier/communicator/login.cc
   M /trunk/src/jingle/notifier/communicator/login.h
   A /trunk/src/jingle/notifier/communicator/product_info.cc
   A /trunk/src/jingle/notifier/communicator/product_info.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.h
   A /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.cc (from /trunk/src/remoting/jingle_glue/ssl_socket_adapter.cc:59094)
   A /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.h (from /trunk/src/remoting/jingle_glue/ssl_socket_adapter.h:59094)
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc
   A /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.cc (from /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.cc:59094)
   A /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.h (from /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.h:59094)
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/jingle_glue/jingle_client.cc
   D /trunk/src/remoting/jingle_glue/ssl_adapter.cc
   D /trunk/src/remoting/jingle_glue/ssl_adapter.h
   D /trunk/src/remoting/jingle_glue/ssl_socket_adapter.cc
   D /trunk/src/remoting/jingle_glue/ssl_socket_adapter.h
   D /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.cc
   D /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.h
   M /trunk/src/remoting/remoting.gyp

Revert r59012 which started using Chrome sockets for sync.

This caused us to write to ChromeNetLog from the sync thread.  ChromeNetLog is not thread safe, so this causes problems.

BUG=55116,54146
TEST=Start up chrome.  Does not repeatedly hit DCHECKs on ChromeNetLog::AddEntry().

Review URL: http://codereview.chromium.org/3358028
------------------------------------------------------------------------
r59102 | finnur@chromium.org | 2010-09-10 18:51:58 +0200 (Fri, 10 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc

Change the toast text and make sure errors are written to
HKLM too (not just success messages).

The toast text changes are listed in the bug; basically we
have 4 experiments that differ only in the text we display
as a headline.

I also fixed an issue raised by QA with error codes being
written to HKCU as opposed to HKLM. This should fix that
issue.

BUG=http://crbug.com/54835, http://crbug.com/44378
TEST=Requires manual testing by QA.

Review URL: http://codereview.chromium.org/3341026
------------------------------------------------------------------------
r59094 | danno@chromium.org | 2010-09-10 15:55:18 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/plugin_updater.h
   A /trunk/src/chrome/browser/prefs/pref_change_registrar.cc
   A /trunk/src/chrome/browser/prefs/pref_change_registrar.h
   A /trunk/src/chrome/browser/prefs/pref_change_registrar_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_service.h
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/plugin_group.h

Policy: plugins disabled by policy should honor policy changes without Chrome relaunch.

BUG=54620
TEST=PrefChangeRegistrarTest.*

Review URL: http://codereview.chromium.org/3316007
------------------------------------------------------------------------
r59090 | avi@chromium.org | 2010-09-10 15:45:38 +0200 (Fri, 10 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc

Easy cleanup in first-run.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/3290020
------------------------------------------------------------------------
r59089 | mnissler@chromium.org | 2010-09-10 15:44:54 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/options_managed_banner_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_managed_banner_handler.h
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/policy/dummy_configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/policy/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/policy/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_store.h
   M /trunk/src/chrome/browser/prefs/pref_notifier.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.cc
   M /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.cc
   M /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.h

Move policy-related stuff to its own namespace.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3360019
------------------------------------------------------------------------
r59088 | finnur@chromium.org | 2010-09-10 15:22:05 +0200 (Fri, 10 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/page_info_bubble_gtk.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Page info model now shows red skull and crossbones on SECURITY_STYLE_AUTHENTICATION_BROKEN, like the Omnibox does.

Started using...
a) the Info icon (blue i) for the first visit section and 
b) the yellow exclamation point for http connections (instead of the skull and crossbones).

BUG=http://crbug.com/52916
TEST=None

Review URL: http://codereview.chromium.org/3367007
------------------------------------------------------------------------
r59087 | nsylvain@chromium.org | 2010-09-10 15:14:11 +0200 (Fri, 10 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Revert 59077 - Tiny cleanup: remove all use of kFallbackInputMethodId from the Chrome tree.

BUG=chromium-os:6563
TEST=ran emerge, ran chrome on the device

Review URL: http://codereview.chromium.org/3340021

TBR=yusukes@chromium.org
Review URL: http://codereview.chromium.org/3358027
------------------------------------------------------------------------
r59086 | mnissler@chromium.org | 2010-09-10 13:52:20 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc

Fix style issues with ConfigDirPolicyProvider.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3331001
------------------------------------------------------------------------
r59085 | dilmah@chromium.org | 2010-09-10 13:47:14 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

Do not delete and recreate password field on locale changed because:
(1) it messes up with focus manager.
(2) it is redundant.

BUG=http://crosbug/6271
TEST=Manual

Review URL: http://codereview.chromium.org/3340019
------------------------------------------------------------------------
r59082 | satorux@chromium.org | 2010-09-10 12:51:45 +0200 (Fri, 10 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add logic to change UI font based on UI language, in candidate_window.

The logic is identical to one in Chrome.
See http://src.chromium.org/viewvc/chrome?view=rev&revision=58913 for details.

Along the way, removed --logtostderr in candidate_window,
as we no longer use it

BUG=chromium-os:2723
TEST=Confirmed that IPAPGothic is used when UI language is set to Japanese, on the netbook. Also confirmed that Pinyin and Chewing input methods work with UI language set to Japanese (i.e. fallback fonts are properly used).

Review URL: http://codereview.chromium.org/3334014
------------------------------------------------------------------------
r59081 | podivilov@chromium.org | 2010-09-10 12:35:34 +0200 (Fri, 10 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: enable two sanity tests (fixed upstream)

BUG=53406

Review URL: http://codereview.chromium.org/3305023
------------------------------------------------------------------------
r59077 | yusukes@chromium.org | 2010-09-10 11:34:23 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Tiny cleanup: remove all use of kFallbackInputMethodId from the Chrome tree.

BUG=chromium-os:6563
TEST=ran emerge, ran chrome on the device

Review URL: http://codereview.chromium.org/3340021
------------------------------------------------------------------------
r59075 | yusukes@chromium.org | 2010-09-10 11:16:52 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Always activate a keyboard layout that matches the hardware layout in the screen locker.

BUG=chromium-os:6564
TEST=manually checked. see the bug.

Review URL: http://codereview.chromium.org/3358026
------------------------------------------------------------------------
r59074 | finnur@chromium.org | 2010-09-10 11:12:11 +0200 (Fri, 10 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/always_allowed
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/always_allowed/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/always_allowed/manifest.json
   A /trunk/src/chrome/test/data/extensions/empty_manifest
   A /trunk/src/chrome/test/data/extensions/empty_manifest/empty.json

Excempt certain extension functions from module permission check.

BUG=43743
TEST=Two news tests: ExtensionTest.ApiPermissions (unit test), and ExtensionApiTest.AlwaysAllowed (browser test)
Review URL: http://codereview.chromium.org/3316009
------------------------------------------------------------------------
r59073 | pam@chromium.org | 2010-09-10 10:25:42 +0200 (Fri, 10 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_proxy_api.cc
   M /trunk/src/chrome/browser/extensions/extension_proxy_api.h
   M /trunk/src/chrome/browser/extensions/extension_proxy_apitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.proxy.html
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/auto
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/auto/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/proxy/single/manifest.json:58623)
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/auto/test.html (from /trunk/src/chrome/test/data/extensions/api_test/proxy/single/test.html:58623)
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/auto/test.js (from /trunk/src/chrome/test/data/extensions/api_test/proxy/single/test.js:58623)
   M /trunk/src/chrome/test/data/extensions/api_test/proxy/individual/test.js
   M /trunk/src/chrome/test/data/extensions/api_test/proxy/single/test.js

Add support for PAC scripts (URL only, no direct data yet) and proxy auto-config to the proxy extension API.

BUG=48930
TEST=covered by browser_tests ExtensionAPITest.Proxy*
Review URL: http://codereview.chromium.org/3348014
------------------------------------------------------------------------
r59071 | mnissler@chromium.org | 2010-09-10 10:18:46 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/third_party/icu/icu_utf.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome_frame/test/chrome_frame_ui_test_utils.cc
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/net/base/host_mapping_rules.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/proxy/proxy_bypass_rules.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc

Make the glob matcher support UTF8 strings.

This generalizes the existing pattern matching code to support UTF8 strings.

BUG=53158
TEST=string_util_unittests.cc

Review URL: http://codereview.chromium.org/3295018
------------------------------------------------------------------------
r59068 | satorux@chromium.org | 2010-09-10 09:46:09 +0200 (Fri, 10 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h

Refactor InputMethodLibrary.

Along the way, add more comments, and rename functions
to be more descriptive.

TEST=manually on the netbook
BUG=none

Review URL: http://codereview.chromium.org/3343016
------------------------------------------------------------------------
r59050 | tommi@chromium.org | 2010-09-10 06:59:33 +0200 (Fri, 10 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/policy/policy_templates.grd
   M /trunk/src/chrome/app/policy/policy_templates.json
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/tools/grit/grit/format/policy_templates/template_formatter.py
   M /trunk/src/tools/grit/grit/format/policy_templates/writer_configuration.py

Add policy support for Chrome Frame. New Chrome Frame messages added to th json and grd files that are used to generate the policy templates.
Added matching constants for the policy elements to the policy_constants files.
Added support for a new template value, $3, that represents the Chrome Frame product name in policy templates.

TEST=none
BUG=29349

Review URL: http://codereview.chromium.org/3325011
------------------------------------------------------------------------
r59048 | dumi@chromium.org | 2010-09-10 06:26:54 +0200 (Fri, 10 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Build fix for Linux.

TEST=none
BUG=none
TBR=darin

Review URL: http://codereview.chromium.org/3311024
------------------------------------------------------------------------
r59045 | dumi@chromium.org | 2010-09-10 06:06:24 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/plugins/pepper_file_io.cc
   M /trunk/src/webkit/glue/plugins/pepper_file_io.h
   M /trunk/src/webkit/glue/plugins/pepper_plugin_delegate.h

Implement pepper::FileIO.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3329014
------------------------------------------------------------------------
r59040 | thestig@chromium.org | 2010-09-10 04:47:40 +0200 (Fri, 10 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_store.h
   M /trunk/src/chrome/browser/prefs/pref_set_observer.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 59020 - Add constants for preferences and policies related to the Default Search Provider.  Add code to read these new policies into prefs.  Add code to enable monitoring change to these preferences.

BUG=49306
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.*  

Review URL: http://codereview.chromium.org/3359012

TBR=jeanluc@google.com
Review URL: http://codereview.chromium.org/3357026
------------------------------------------------------------------------
r59038 | jrg@chromium.org | 2010-09-10 04:33:24 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Prevent multiple bookmarks from having focus when trying to confuse
things with the context menu.

BUG=http://crbug.com/54324

Review URL: http://codereview.chromium.org/3345017
------------------------------------------------------------------------
r59037 | johnnyg@chromium.org | 2010-09-10 04:31:42 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/token_migrator.h

Add a header guard missing from previous patch.

BUG=none
TEST=none.

Review URL: http://codereview.chromium.org/3372006
------------------------------------------------------------------------
r59035 | satorux@chromium.org | 2010-09-10 04:19:33 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Record user actions in "Language and Input" page.

BUG=chromium-os:2637
TEST=manually

Review URL: http://codereview.chromium.org/3330014
------------------------------------------------------------------------
r59031 | johnnyg@chromium.org | 2010-09-10 03:41:12 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix a leak when syncapi is used in test mode, where the session context was being created but not handed over to the syncer thread.

BUG=55031
TEST=unit tests

Review URL: http://codereview.chromium.org/3374002
------------------------------------------------------------------------
r59030 | mrossetti@chromium.org | 2010-09-10 03:37:07 +0200 (Fri, 10 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm

Mac: Allow dragging bookmarks to trash

This patch allows users to delete bookmarks by dragging them to the trash icon on the Mac OS dock.

Note: Original patch http://codereview.chromium.org/3342023 proposed by fnepal@gmail.com.

BUG=54727
TEST=Dragged bookmarks to trash. Verified that the bookmark was deleted. Verified that the poof animation was draw centered over the mouse cursor. Verified that the same thing worked for bookmarks inside folders.

Review URL: http://codereview.chromium.org/3333026
------------------------------------------------------------------------
r59026 | thakis@chromium.org | 2010-09-10 03:17:20 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/first_run_bubble_controller.mm

Mac: Try to make sure that the first run bubble always disappears.

BUG=52726
TEST=The first run bubble should work as before for normal people. For deepakg, it should no longer stick around forever.

Review URL: http://codereview.chromium.org/3312018
------------------------------------------------------------------------
r59022 | wtc@chromium.org | 2010-09-10 02:01:23 +0200 (Fri, 10 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/importer_data_types.h
   M /trunk/src/chrome/browser/importer/importer_list.cc

Use Firefox3Importer to import the browser data of Firefox 4
and later.

R=mirandac
BUG=48513
TEST=Do "Import data from another browser" on a computer with
just Firefox 4 installed.  The dropdown menu should have
"Mozilla Firefox" listed, and all four types of data should
be imported correctly.
Review URL: http://codereview.chromium.org/3336017
------------------------------------------------------------------------
r59021 | phajdan.jr@chromium.org | 2010-09-10 01:49:04 +0200 (Fri, 10 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.

This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.

TEST=ui_tests in Release mode
BUG=49838

Review URL: http://codereview.chromium.org/2805100
------------------------------------------------------------------------
r59020 | jeanluc@google.com | 2010-09-10 01:48:38 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_provider.h
   M /trunk/src/chrome/browser/policy/mock_configuration_policy_store.h
   M /trunk/src/chrome/browser/prefs/pref_set_observer.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add constants for preferences and policies related to the Default Search Provider.  Add code to read these new policies into prefs.  Add code to enable monitoring change to these preferences.

BUG=49306
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.*  

Review URL: http://codereview.chromium.org/3359012
------------------------------------------------------------------------
r59014 | andybons@chromium.org | 2010-09-10 00:53:22 +0200 (Fri, 10 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/ntp/apps.js

NTP Apps bug fixes.

o Only do the bounce animation once when installing an app. Collapsing and expanding the apps section would cause the new app icon to bounce again.
o Expand the Apps section if it is collapsed and a new app isn't installed.

BUG=53974,54421
TEST=manual

Review URL: http://codereview.chromium.org/3371010
------------------------------------------------------------------------
r59012 | akalin@chromium.org | 2010-09-10 00:47:14 +0200 (Fri, 10 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/jingle/jingle.gyp
   M /trunk/src/jingle/notifier/base/notifier_options.h
   D /trunk/src/jingle/notifier/base/signal_thread_task.h
   D /trunk/src/jingle/notifier/base/ssl_adapter.cc
   D /trunk/src/jingle/notifier/base/ssl_adapter.h
   D /trunk/src/jingle/notifier/base/static_assert.h
   M /trunk/src/jingle/notifier/communicator/login.cc
   M /trunk/src/jingle/notifier/communicator/login.h
   D /trunk/src/jingle/notifier/communicator/product_info.cc
   D /trunk/src/jingle/notifier/communicator/product_info.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.h
   D /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.cc
   D /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc
   D /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.cc
   D /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/jingle_glue/jingle_client.cc
   A /trunk/src/remoting/jingle_glue/ssl_adapter.cc (from /trunk/src/jingle/notifier/base/ssl_adapter.cc:59009)
   A /trunk/src/remoting/jingle_glue/ssl_adapter.h (from /trunk/src/jingle/notifier/base/ssl_adapter.h:59009)
   A /trunk/src/remoting/jingle_glue/ssl_socket_adapter.cc (from /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.cc:59009)
   A /trunk/src/remoting/jingle_glue/ssl_socket_adapter.h (from /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.h:59009)
   A /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.cc (from /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.cc:59009)
   A /trunk/src/remoting/jingle_glue/xmpp_socket_adapter.h (from /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.h:59009)
   M /trunk/src/remoting/remoting.gyp

Removed use of XmppSocketAdapter by sync.

Moved XmppSocketAdapter and friends to remoting directory.

Removed some dead code in jingle/.

BUG=54146
TEST=none

Review URL: http://codereview.chromium.org/3298021
------------------------------------------------------------------------
r59008 | thakis@chromium.org | 2010-09-10 00:10:08 +0200 (Fri, 10 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/labs.html
   M /trunk/src/chrome/browser/resources/plugins.html

Fix 2 missing pixels on bottom of icon on about:plugins, chrome://extensions, and about:labs

BUG=none
TEST=look hard

Review URL: http://codereview.chromium.org/3270009
------------------------------------------------------------------------
r59005 | jrg@chromium.org | 2010-09-09 23:56:11 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Don't draw the highlight border of a button which is disabled.

BUG=http://crbug.com/54725


Review URL: http://codereview.chromium.org/3369010
------------------------------------------------------------------------
r58997 | rvargas@google.com | 2010-09-09 22:50:41 +0200 (Thu, 09 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc

AsyncResourceHandler: When a URLRequest is canceled,
the network code may complete the request with a
CANCELED status but hold on to the actual buffer that
was used for the operation (that's the whole point
about using IOBuffers instead of a plain, non-refcounted
buffer).

In this scenario, the AsyncResourceHandler should not
recycle the buffer for another request, unless we want
two requests using the same buffer.

BUG=53910
TEST=none

Review URL: http://codereview.chromium.org/3311019
------------------------------------------------------------------------
r58995 | sky@chromium.org | 2010-09-09 22:46:38 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Disables more media tests.

BUG=none
TEST=none
TBR=imcheng@chromium.org
Review URL: http://codereview.chromium.org/3366020
------------------------------------------------------------------------
r58993 | johnnyg@chromium.org | 2010-09-09 22:36:39 +0200 (Thu, 09 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   A /trunk/src/chrome/browser/net/gaia/token_service_unittest.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   D /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   D /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   D /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   D /trunk/src/chrome/browser/sync/engine/authenticator.cc
   D /trunk/src/chrome/browser/sync/engine/authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   A /trunk/src/chrome/browser/sync/signin_manager.cc
   A /trunk/src/chrome/browser/sync/signin_manager.h
   A /trunk/src/chrome/browser/sync/signin_manager_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   A /trunk/src/chrome/browser/sync/token_migrator.cc
   A /trunk/src/chrome/browser/sync/token_migrator.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   D /trunk/src/chrome/test/live_sync/offline_sync_test.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/single_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/profile_mock.h
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

2nd attempt at http://codereview.chromium.org/3305003/show

The difference between this patch and the other one is plumbing setup_in_test_mode through the Initialization process, rather than using a separate SetupInTestMode() method, which happens too late to safely stop the syncer thread.  [see syncapi.cc|h for most of the changes.]

---

This patch removes: authenticator.cc, auth_watcher.cc

removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome.

Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup.

BUG=51001, 50293, 35158
TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog.
Review URL: http://codereview.chromium.org/3342025
------------------------------------------------------------------------
r58979 | jshin@chromium.org | 2010-09-09 22:00:39 +0200 (Thu, 09 Sep 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html

Use text-overflow: ellipsis for long words in sync set-up UI.

In r57340, the datatype selection section of sync set-up UI got wider, but
not wide enough to avoid truncation in all the locales. When a word 
is too long to fit, it's truncated with 'tooltip' showing the full-word.

This CL adds 'text-overflow: ellipsis' and other necessary CSS properties 
to 'label' elements so that long words that do not fit are ellipsized instead of
truncated.

While I'm at it, I fixed two 'typos'. One is 'i8n' (note missing '1') and
the other is the misplaced label for the radio-button for 
'Choose what to sync'. The raido-button and the corresponding label is
separated by 'div' tag (chooseDataTypesBody) leading to a strange line wrapping
in the sync setup UI.

BUG=52789, 53494
TEST=1. Open sync setup UI in French, Italian, Brazilliant Portugest (pt-BR) and see if the translation for 'autofill' is ellipsized rather than truncated.
2. Open sync setup UI and 'Choose what to sync:' is on the same line as the corresponding radio button.

Review URL: http://codereview.chromium.org/3142042
------------------------------------------------------------------------
r58977 | sky@chromium.org | 2010-09-09 21:51:35 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h

Makes ExtensionBrowserEventRouter correctly deal with replacing a tab.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3305025
------------------------------------------------------------------------
r58976 | sky@chromium.org | 2010-09-09 21:50:23 +0200 (Thu, 09 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Changes TabStripModel to send out selection notification when the
selected tab is replaced.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3323020
------------------------------------------------------------------------
r58975 | phajdan.jr@chromium.org | 2010-09-09 21:40:03 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h

GTTF: Move some more bits of automation code from AutomationProvider to TestingAutomationProvider

BUG=52097
TEST=ui_tests, chrome_frame_tests

Review URL: http://codereview.chromium.org/3354013
------------------------------------------------------------------------
r58973 | altimofeev@chromium.org | 2010-09-09 21:12:03 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.cc
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Disallows opening non-incognito windows in BWSI mode. Also disables 'New window' menu item, but not the shortkey - 'CTRL+N' opens new incognito window.

BUG=chromium-os:6025
TEST=Start BWSI session. Note that only incognito windows could be opened.

Review URL: http://codereview.chromium.org/3235011
------------------------------------------------------------------------
r58971 | bulach@chromium.org | 2010-09-09 20:56:05 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/indexed_db_param_traits.cc
   M /trunk/src/chrome/common/indexed_db_param_traits.h
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/utility_messages.cc
   M /trunk/src/chrome/common/utility_messages_internal.h
   M /trunk/src/chrome/utility/utility_thread.cc

Removes indexed_db_param_traits.h depedencies on WebKit headers.

BUG=53317
TEST=No functional change, compiler/linker should be happy.

Review URL: http://codereview.chromium.org/3297011
------------------------------------------------------------------------
r58970 | rafaelw@chromium.org | 2010-09-09 20:47:36 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/webstore_app/manifest.json

Include all schemes for webstore component app urls

BUG=55002
TEST=type chrome.google.com/extensions into omnibox, open js console, verify that chrome.webstorePrivate object is defined

Review URL: http://codereview.chromium.org/3366018
------------------------------------------------------------------------
r58968 | sky@chromium.org | 2010-09-09 20:21:53 +0200 (Thu, 09 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Disables VideoBearTheora as crashes.

BUG=54939
TEST=none
Review URL: http://codereview.chromium.org/3333023
------------------------------------------------------------------------
r58967 | jcivelli@chromium.org | 2010-09-09 20:20:51 +0200 (Thu, 09 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc

The RenderViewHostManagerTest.PageDoesBackAndReload  unit-test was keeping a pointer to a RVH after a navigation was committed and was comparing the current RVH some time after that with that old RVH that had been deleted at that point.
When we were lucky, the same address was used for the new RVH and the test would pass. When we were not lucky the test would fail.

BUG=54708
TEST=Run the unit-tests.

Review URL: http://codereview.chromium.org/3335011
------------------------------------------------------------------------
r58964 | alekseys@chromium.org | 2010-09-09 20:11:57 +0200 (Thu, 09 Sep 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/TabContents.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   A /trunk/src/chrome/browser/cocoa/dev_tools_controller.h
   A /trunk/src/chrome/browser/cocoa/dev_tools_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/side_tab_strip_controller.mm
   A /trunk/src/chrome/browser/cocoa/sidebar_controller.h
   A /trunk/src/chrome/browser/cocoa/sidebar_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

Move devtools and sidebar handling to BWC and ensure the order of layout adjustments
during tab change updates to eliminate UI flickering.

TabContents.xib changes: devtools and sidebar NSSplitViews removed (moved to BrowserWindow.xib),
contentsContainer_ view removed (now it's inserted at runtime).
BrowserWindow.xib chnages: devtools and sidebar NSSplitViews added into FastResizeView.

BUG=22717, 31633
TEST=Run unit_tests, browser_tests and interactive_ui_tests.

Open google.com in one tab (it's easy to spot content relayout on google.com), trigger an infobar
and content scroll bar on another tab (ru.wikipedia.org with translation infobar will do), switch
tabs back and forth. Content should not relayout, scroll bar should not "jump".
Open new tab and make sure bookmark bar is not always visible, open any site which triggers infobar
and big enough to show content scroll bar on another tab, switch tabs back and forth. Content should
not relayout, scroolbar should not "jump".
Repeat the tests above with sidebar opened on any of these tabs, page and sidebar content should not
relayout, sidebar should stay the same width, scrollbar should not "jump".
Repeat the tests above with devtools docked.

------------------------------------------------------------------------
r58962 | altimofeev@chromium.org | 2010-09-09 19:57:40 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Deletes "Go incognito" button after login screen.

BUG=chromium-os:5630
TEST=Sing in as new user, notice that no "Go Incognito" button appears in the "set your profile" screen.

Review URL: http://codereview.chromium.org/3320007
------------------------------------------------------------------------
r58958 | phajdan.jr@chromium.org | 2010-09-09 19:36:22 +0200 (Thu, 09 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Remove the flaky mark from several Geolocation tests. We no longer see the flakes.

TBR=bulach, joth

BUG=52518
TEST=browser_tests

Review URL: http://codereview.chromium.org/3359015
------------------------------------------------------------------------
r58957 | zhurunz@google.com | 2010-09-09 19:34:42 +0200 (Thu, 09 Sep 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json
   A /trunk/src/chrome/browser/resources/chat_manager/options.html

Add options page for Chat Manager.
Review URL: http://codereview.chromium.org/3363010
------------------------------------------------------------------------
r58956 | rafaelw@chromium.org | 2010-09-09 19:33:18 +0200 (Thu, 09 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   A /trunk/src/chrome/browser/extensions/extension_gallery_install_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.h
   M /trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc
   M /trunk/src/chrome/browser/extensions/extension_webstore_private_api.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/resources/webstore_app/manifest.json
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   A /trunk/src/chrome/test/data/extensions/api_test/extension_gallery_install
   A /trunk/src/chrome/test/data/extensions/api_test/extension_gallery_install/test.html
   M /trunk/src/net/tools/testserver/testserver.py

Implement gallery install API

This patch implements chrome.experimental.management.install() which is only available for use by the web store. Calling with an extensionId, causes the download url to be constructed internally and downloaded and then cause the installation to bypass the normal permissions dialog.

BUG=27431,54148

Review URL: http://codereview.chromium.org/3353015
------------------------------------------------------------------------
r58955 | mrossetti@chromium.org | 2010-09-09 19:24:30 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   M /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Step 3 integrating the HistoryQuickProvider: Implement searching and production of search results in the InMemoryURLIndex. Unit test the production of results. Minor change in URLHistoryProvuder unit test setup.

BUG=None
TEST=None (unit tests added)

Review URL: http://codereview.chromium.org/3364004
------------------------------------------------------------------------
r58954 | arv@chromium.org | 2010-09-09 19:22:00 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

NTP: Fix the size of the most visited settings button so that the image is not cut off.

BUG=54864
TEST=Open NTP and look at the wrench icon of the most visited section.

Review URL: http://codereview.chromium.org/3362014
------------------------------------------------------------------------
r58953 | jianli@chromium.org | 2010-09-09 19:17:55 +0200 (Thu, 09 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/base/time.cc
   M /trunk/src/base/time.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc

Fix Time::FromDoubleT so that it will return null time when 0 is passed.

This is the rework of this issue before previous submit is reverted. We need to
fix the usage of Time::FromDoubleT(0) in extension history API.

BUG=none
TEST=non

Review URL: http://codereview.chromium.org/3295001
------------------------------------------------------------------------
r58949 | jshin@chromium.org | 2010-09-09 18:58:50 +0200 (Thu, 09 Sep 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings_cros.grd
   M /trunk/src/chrome/app/resources/locale_settings_linux.grd
   M /trunk/src/chrome/app/resources/locale_settings_mac.grd
   M /trunk/src/chrome/app/resources/locale_settings_win.grd
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_am.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ja.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ko.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_th.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ja.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ko.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ml.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_th.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_zh-CN.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_zh-TW.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ja.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ko.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-CN.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-TW.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ko.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_th.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb
   M /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-TW.xtb
   M /trunk/src/chrome/browser/resources/filebrowse.html

Make the content browser in ChromeOS honor the DOM  UI font setting.

At the moment, no font-family is specified. In that case, serif font is picked
by default by Chrome (exception being CJK for which sans-serif is picked).
Adding an attribute i18n-values for font-family will set up font-family
for the file. I'm not setting font-size because filebrowse.html uses em font-size
widely and the default value of 84% (set in locale_settings_cros.grd) will
disrupt the layout.

Change the DOM UI font for ChromeOS from 'Droid Sans' to 'Chrome Droid Sans'.
This may change again, but this matches the font used in the native UI (as
specified in gtkrc file) for now.

In addition, just as a 'sanitization', enclose font names (IDS_WEB_FONT_FAMILY)
with a space with a pair of single quotation marks.

BUG=chromiumos:6067 (http://crosbug.com/6067)
TEST=Build Chrome for ChromeOS and gmerge it to your build. Content browser does not use serif font any more. Instead, it uses 'Chrome Droid Sans'. 

Review URL: http://codereview.chromium.org/3295010
------------------------------------------------------------------------
r58947 | lzheng@chromium.org | 2010-09-09 18:45:49 +0200 (Thu, 09 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_browsertest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h


Add database_update_in_progress_ in SafeBrowsingService to indicate if the
database is still changing. This could be used in the end to end safebrowsing
test so we only verify database after this flag is set to false.

BUG=none
TEST=safe_browsing_browsertest.cc

Review URL: http://codereview.chromium.org/3258010
------------------------------------------------------------------------
r58945 | thakis@chromium.org | 2010-09-09 18:34:12 +0200 (Thu, 09 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window_unittest.mm
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Mac: Try to get tabpose unit tests working again.

The original problem was that the test plays an animation that outlives the test. When the animation is done, the tab strip model observer tries to unregister itself, but the registry died when the test exited already.

My faulty fix was to reset the observer as soon as the end animation starts. This has the problem that the end animation will try to access stale objects: TabContentss are destroyed when the test exits, but the exit animation still tries to access them when drawing ThumbnailLayers (because the observer didn't get a notification that these were dead, since it was unregistered).

This (hopefully better) fix now unregisters the observer directly before the tab strip goes away.

BUG= 54323,53893,54342
TEST=unit tests pass, valgrind stays green

Review URL: http://codereview.chromium.org/3304014
------------------------------------------------------------------------
r58944 | nsylvain@chromium.org | 2010-09-09 17:51:21 +0200 (Thu, 09 Sep 2010) | 16 lines
Changed paths:
   D /trunk/src/chrome/browser/media_browsertest.cc
   A /trunk/src/chrome/browser/media_uitest.cc (from /trunk/src/chrome/browser/media_uitest.cc:58909)
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/data/media/player_fullscreen.html
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Revert 58910 - This broke the "Google Chrome" compile.

Original description:
Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.

Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.

Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.

TEST=ui_tests, interactive_ui_tests
BUGS=54838

Review URL: http://codereview.chromium.org/3322009

TBR=imcheng@chromium.org
Review URL: http://codereview.chromium.org/3318020
------------------------------------------------------------------------
r58943 | nsylvain@chromium.org | 2010-09-09 17:50:06 +0200 (Thu, 09 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/media_browsertest.cc

Revert 58921 - Mark MediaBrowserTest.VideoBearTheora as FLAKY on Mac OS.

TBR=imcheng@chromium.org
BUG=54939

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/3364016
------------------------------------------------------------------------
r58942 | nsylvain@chromium.org | 2010-09-09 17:40:49 +0200 (Thu, 09 Sep 2010) | 3 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/default_extensions/chromeos

You can't point a DEPS entry to a directory that already exists! This is making
SVN fail and forcing a full checkout on all the bots for each build cycle.

------------------------------------------------------------------------
r58939 | gfeher@chromium.org | 2010-09-09 16:23:44 +0200 (Thu, 09 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Constants for the disable printing policy

Define constants for policy kPrintingEnabled and its corresponding preference.

BUG=54380
TEST=none

Review URL: http://codereview.chromium.org/3292015
------------------------------------------------------------------------
r58931 | nkostylev@chromium.org | 2010-09-09 15:47:57 +0200 (Thu, 09 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.cc
   M /trunk/src/chrome/common/net/gaia/google_service_auth_error.h

Adding additional ClientLogin error messages parsing.
By default use the same behavior as INVALID_GAIA_CREDENTIALS.
Might be used as additional error info or to show different UI error message.

ClientLogin API
http://code.google.com/apis/accounts/docs/AuthForInstalledApps.html

BUG= http://crosbug.com/6379
TEST=Added.

Review URL: http://codereview.chromium.org/3335006
------------------------------------------------------------------------
r58930 | satish@chromium.org | 2010-09-09 15:41:24 +0200 (Thu, 09 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/endpointer/endpointer.h
   M /trunk/src/chrome/browser/speech/endpointer/energy_endpointer.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc

Give time for environment estimation and detect the no-speech case.
Environment estimation helps establish a baseline against which the endpointer
compares to find beginning and end of speech. We now do this estimation for a
few hundred milliseconds before showing the speech UI asking user to speak.
Using this updated endpointer we also detect if no speech was heard for many
seconds and if so inform the delegate as an error. In a future CL we'll allow
the user to easily retry recognition in these error cases.

BUG=53598
TEST=unit_tests --gtest_filter=SpeechRecognizerTests.*

Review URL: http://codereview.chromium.org/3341020
------------------------------------------------------------------------
r58929 | bauerb@chromium.org | 2010-09-09 15:40:40 +0200 (Thu, 09 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   A /trunk/src/chrome/browser/plugin_exceptions_table_model.cc
   A /trunk/src/chrome/browser/plugin_exceptions_table_model.h
   A /trunk/src/chrome/browser/plugin_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h

[Win] Add per-plugin exceptions to content settings.

Screenshot: http://imgur.com/yxEzO.png

BUG=39252
TEST=PluginExceptionsTableModel.*

Review URL: http://codereview.chromium.org/3307014
------------------------------------------------------------------------
r58928 | yusukes@chromium.org | 2010-09-09 15:19:05 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc

Ignore very short Y move to prevent the window from shaking up and down.

BUG=chromium-os:6460
TEST=see the bug.

Review URL: http://codereview.chromium.org/3355016
------------------------------------------------------------------------
r58925 | pam@chromium.org | 2010-09-09 13:14:01 +0200 (Thu, 09 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   D /trunk/src/chrome/browser/prefs/default_pref_store.cc
   D /trunk/src/chrome/browser/prefs/default_pref_store.h
   M /trunk/src/chrome/browser/prefs/pref_member_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_notifier.h
   M /trunk/src/chrome/browser/prefs/pref_notifier_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_service.cc
   M /trunk/src/chrome/browser/prefs/pref_service.h
   M /trunk/src/chrome/browser/prefs/pref_service_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.h
   M /trunk/src/chrome/browser/prefs/pref_value_store_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_pref_service.cc
   M /trunk/src/chrome/test/testing_pref_service.h

Revert 58920 - Create a DefaultPrefStore to hold registered application-default preference values.

This allows notifications to be sent properly when another PrefStore takes control from a default value.

BUG=52719
TEST=covered by PrefValueStoreTest.* unit tests
Review URL: http://codereview.chromium.org/3331016

TBR=pam@chromium.org

[Reverting because it causes PrefsControllerTest.ValidateCustomHomePagesTable to crash on Mac.]
Review URL: http://codereview.chromium.org/3353019
------------------------------------------------------------------------
r58924 | bauerb@chromium.org | 2010-09-09 12:11:52 +0200 (Thu, 09 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm

Disable PrefsControllerTest.ValidateCustomHomePagesTable, it crashes.

BUG=54950
TBR=pam@chromium.org
------------------------------------------------------------------------
r58923 | bauerb@chromium.org | 2010-09-09 11:15:49 +0200 (Thu, 09 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Disable BrowserWindowControllerTest.TestNormal, it crashes.

BUG=54945
TBR=jrg@chromium.org
------------------------------------------------------------------------
r58921 | bauerb@chromium.org | 2010-09-09 10:38:42 +0200 (Thu, 09 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/media_browsertest.cc

Mark MediaBrowserTest.VideoBearTheora as FLAKY on Mac OS.

TBR=imcheng@chromium.org
BUG=54939
------------------------------------------------------------------------
r58920 | pam@chromium.org | 2010-09-09 09:42:35 +0200 (Thu, 09 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   A /trunk/src/chrome/browser/prefs/default_pref_store.cc
   A /trunk/src/chrome/browser/prefs/default_pref_store.h
   M /trunk/src/chrome/browser/prefs/pref_member_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_notifier.h
   M /trunk/src/chrome/browser/prefs/pref_notifier_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_service.cc
   M /trunk/src/chrome/browser/prefs/pref_service.h
   M /trunk/src/chrome/browser/prefs/pref_service_unittest.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.h
   M /trunk/src/chrome/browser/prefs/pref_value_store_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_pref_service.cc
   M /trunk/src/chrome/test/testing_pref_service.h

Create a DefaultPrefStore to hold registered application-default preference values.

This allows notifications to be sent properly when another PrefStore takes control from a default value.

BUG=52719
TEST=covered by PrefValueStoreTest.* unit tests
Review URL: http://codereview.chromium.org/3331016
------------------------------------------------------------------------
r58917 | dpolukhin@chromium.org | 2010-09-09 09:02:45 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/default_extensions/chromeos/external_extensions.json
   M /trunk/src/chrome/chrome.gyp

Remove default apps for Chrome OS from public repository

BUG=chromium-os:6318
TEST=none

Review URL: http://codereview.chromium.org/3353016
------------------------------------------------------------------------
r58915 | yusukes@chromium.org | 2010-09-09 07:13:22 +0200 (Thu, 09 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Pass --replace to ibus-daemon to terminate a stale ibus-daemon process.

Stale ibus-daemon processes should not exist, but just in case.

BUG=chromium-os:6515
TEST=manually checked that ibus-daemon can start with the option.

Review URL: http://codereview.chromium.org/3341022
------------------------------------------------------------------------
r58913 | satorux@chromium.org | 2010-09-09 06:36:52 +0200 (Thu, 09 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/resources/app_locale_settings.grd
   M /trunk/src/app/resources/app_locale_settings_ja.xtb
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/tools/build/repack_locales.py

Change UI font at startup time if necessary, based on the UI locale.

As of writing, ChromeDroidSans is used as the UI font (see
/etc/gtk-2.0/gtkrc). This setting does not work well for Japanese users
as Chinese glyphs are used for Kanji characters. For Japanese UI, we
should use a Japanese font.

Introduce IDS_UI_FONT_FAMILY_CROS to control the UI font based on the
UI locale. For now, app_locale_settings_ja.xtb only contains a
non-default value: IPAPGothic.

Just for the record, I originally tried to use "DroidSans Japanese"
but for some reason, this caused space characters (0x20) to be garbled
in the wrench menu. Hence, IPAPGotchic is chosen for now.

TEST=manually on the netbook, and ubuntu
BUG=chromium-os:4038

Review URL: http://codereview.chromium.org/3275008
------------------------------------------------------------------------
r58912 | shess@chromium.org | 2010-09-09 06:03:23 +0200 (Thu, 09 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc

Relax DCHECK in SafeBrowsingDatabaseNew::CacheHashResults().

Function is called on the I/O thread rather than the safe-browsing
thread.

BUG=54726
TEST=Browse to an URL on the malware or phishing list in debug build, no DCHECK.

Review URL: http://codereview.chromium.org/3348015
------------------------------------------------------------------------
r58910 | imcheng@chromium.org | 2010-09-09 05:08:46 +0200 (Thu, 09 Sep 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/media_browsertest.cc (from /trunk/src/chrome/browser/media_uitest.cc:58855)
   D /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/media/player_fullscreen.html
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.

Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.

Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.

TEST=ui_tests, interactive_ui_tests
BUGS=54838

Review URL: http://codereview.chromium.org/3322009
------------------------------------------------------------------------
r58907 | akalin@chromium.org | 2010-09-09 04:43:47 +0200 (Thu, 09 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/extension_sync_traits.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util.h
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc

Check for updates for a user script only if it has an update URL.

This is a modified revert of 52461.

BUG=53639
TEST=unit tests, manually with bettergmail extension

Review URL: http://codereview.chromium.org/3303017
------------------------------------------------------------------------
r58898 | vangelis@chromium.org | 2010-09-09 02:01:55 +0200 (Thu, 09 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Disable accelerated compositing on mac if IOSurfaces are not
supported (as is the case in 10.5).
BUG=54867
Review URL: http://codereview.chromium.org/3305018
------------------------------------------------------------------------
r58894 | tim@chromium.org | 2010-09-09 01:43:38 +0200 (Thu, 09 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 52870 - Revert 52740 - Always show the 'Control sync from Google Dashboard' link on the sync options dialog.

BUG=48844
TEST=open Personal Stuff on any platform, see dashboard link.

Review URL: http://codereview.chromium.org/2827055

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/2881021

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3364012
------------------------------------------------------------------------
r58892 | mbelshe@chromium.org | 2010-09-09 01:21:18 +0200 (Thu, 09 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/google/google_url_tracker.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a command line switch "--disable-background-networking", to be used in
benchmarking when unexpected background networking can cause undesired vairance.

The following systems are disabled via this flag:
   - IntranetRedirectDetector (requests randomURLs 2-5s after startup)
   - GoogleUrlTracker (searchdomaincheck)
   - SafeBrowsing updater
   - Extension updater

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3312014
------------------------------------------------------------------------
r58889 | levin@chromium.org | 2010-09-09 00:53:53 +0200 (Thu, 09 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h

Remove asserts in message_port_dispatcher that are too aggresive.

It seems like this data structure should have some checks to
validate the invariants that it is trying to maintain, but there
are more qualified folks than me to write them.

BUG=35221
TEST=None

Review URL: http://codereview.chromium.org/3325018
------------------------------------------------------------------------
r58886 | xiyuan@chromium.org | 2010-09-09 00:40:58 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h

Expose EnumerateWhitelisted to chrome.

BUG=chromium-os:4488
TEST=none.

Review URL: http://codereview.chromium.org/3337016
------------------------------------------------------------------------
r58884 | twiz@google.com | 2010-09-09 00:36:09 +0200 (Thu, 09 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/test/util_unittests.cc
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/chrome_frame/utils.h

Change correcting the profile used when performing top-level navigations of the host browser with a ChromeFrame instance.  If a ChromeFrame instance was loaded with a given profile, the bho used to always forward top-level navigation requests to a CF full-tab instance using the default (iexplore) profile.  This caused problems with the automation channel, and the navigation would not complete.

I also cleaned up the gcf and host networking registry keys used by Chrome-Frame so that ActiveX instances will also respect their values.

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/3295019
------------------------------------------------------------------------
r58883 | tim@chromium.org | 2010-09-09 00:35:30 +0200 (Thu, 09 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/clear_data_command_unittest.cc

Fix heapcheck leaks introduced by 58859.

TEST=heapcheck bot goes green

TBR=raz@chromium.org

Review URL: http://codereview.chromium.org/3361011
------------------------------------------------------------------------
r58880 | phajdan.jr@chromium.org | 2010-09-09 00:04:40 +0200 (Thu, 09 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/interactive_ui/infobars_uitest.cc

GTTF: Make WaitForInfoBarCount not Sleep.

Use an observer instead, to wait more reliably.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3344006
------------------------------------------------------------------------
r58879 | andybons@chromium.org | 2010-09-09 00:01:38 +0200 (Thu, 09 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm

[Mac] Add metrics to record when a bookmark is DnD'd in the bookmarks bar.

BUG=54690
TEST=none

Review URL: http://codereview.chromium.org/3290015
------------------------------------------------------------------------
r58874 | vangelis@chromium.org | 2010-09-08 23:29:08 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Moving the code that disables accelerated compositing for chrome: and chrome-extensions:
URLs into TabContents::GetWebkitPrefs() so that it gets called both when the RenderView is
created and on subsequent preference updates. Also removed checking for kChromeInternalScheme as it is not used (per Darin).

BUG=54869
Review URL: http://codereview.chromium.org/3364015
------------------------------------------------------------------------
r58872 | mpcomplete@chromium.org | 2010-09-08 23:10:31 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Fix spacing for extension omnibox keyword icons.

BUG=51981
TEST=no

Review URL: http://codereview.chromium.org/3266015
------------------------------------------------------------------------
r58870 | kinuko@chromium.org | 2010-09-08 23:00:56 +0200 (Wed, 08 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h

Integrate FileSystemOperation with FileSystemDispatcherHost.

(This patch depends on unsubmitted change in file_util_proxy:
http://codereview.chromium.org/3293009/show)

BUG=32277
TEST=none; layout tests will be added later.

Review URL: http://codereview.chromium.org/3328011
------------------------------------------------------------------------
r58869 | dhollowa@chromium.org | 2010-09-08 22:55:35 +0200 (Wed, 08 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm

AutoFill Mac dialog should be non-modal

Changes the AutoFill dialog on Mac to be modeless.  Changes to preferences and AutoFill profile and credit card information is now saved immediately.
Nib changes: Removes Save and Cancel buttons, activates Close and Minimize controls, and compacts dialog to account for new vertical space.

BUG=49935
TEST=AutoFillDialogControllerTest.*

Review URL: http://codereview.chromium.org/3302015
------------------------------------------------------------------------
r58868 | jianli@chromium.org | 2010-09-08 22:24:59 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/base/mime_util.cc
   M /trunk/src/net/base/mime_util.h

Support accept attribute for an <input type=file> element.

BUG=54009
TEST=none

Review URL: http://codereview.chromium.org/3311016
------------------------------------------------------------------------
r58867 | estade@chromium.org | 2010-09-08 22:23:59 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/resources/options/content_settings.js

Tabbed options: Update content settings defaults when they change.

BUG=54734
TEST=change a content setting to a non-default value, reset defaults, make sure the content setting radio has changed appropriately.

Review URL: http://codereview.chromium.org/3311017
------------------------------------------------------------------------
r58864 | georgey@chromium.org | 2010-09-08 21:52:20 +0200 (Wed, 08 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Fix for 54439 Browser crash @ WideToUTF8(std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t>  > const &)
Upload data was called after the InfoBar changed the current page thus resulting in the NULL pointer dereference.
BUG=54439
TEST=Should not crash
Review URL: http://codereview.chromium.org/3291019
------------------------------------------------------------------------
r58860 | rsimha@chromium.org | 2010-09-08 21:25:28 +0200 (Wed, 08 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   D /trunk/src/chrome/browser/sync/notification_method.cc
   D /trunk/src/chrome/browser/sync/notification_method.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/jingle/jingle.gyp
   A /trunk/src/jingle/notifier/base/notification_method.cc (from /trunk/src/chrome/browser/sync/notification_method.cc:58859)
   A /trunk/src/jingle/notifier/base/notification_method.h (from /trunk/src/chrome/browser/sync/notification_method.h:58859)
   A /trunk/src/jingle/notifier/base/notifier_options.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/jingle/notifier/listener/talk_mediator_unittest.cc

Adding the sync-notification-host command line parameter to the integration tests.

The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.

BUG=53933,53931
TEST=sync_integration_tests

First time committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58768

Review URL: http://codereview.chromium.org/3326007
------------------------------------------------------------------------
r58859 | tim@chromium.org | 2010-09-08 21:07:36 +0200 (Wed, 08 Sep 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/engine/clear_data_command.cc
   A /trunk/src/chrome/browser/sync/engine/clear_data_command.h
   A /trunk/src/chrome/browser/sync/engine/clear_data_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.h

Implements the backend for clearing data from the server
BUG=54280
TEST=accessible only via unit test checked in this CL

Original patch by raz@chromium.org
Original review: http://codereview.chromium.org/3293007

Review URL: http://codereview.chromium.org/3310018
------------------------------------------------------------------------
r58849 | arv@chromium.org | 2010-09-08 20:04:08 +0200 (Wed, 08 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Downloads: Use the otr_icon_standalone image in resources/shared/images.

BUG=53347
TEST=Go incognito
Download a large file
Go to the Downloads page (chrome://downloads)
The item being downloaded should have the incognito guy

Review URL: http://codereview.chromium.org/3305016
------------------------------------------------------------------------
r58843 | mnissler@chromium.org | 2010-09-08 19:37:02 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/file_path_watcher_unittest.cc

Mark FilePathWatcherTest.* flaky on Mac.

BUG=54822
TEST=Flakes don't make the buildbots red.

Review URL: http://codereview.chromium.org/3352012
------------------------------------------------------------------------
r58842 | davemoore@chromium.org | 2010-09-08 19:27:46 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.h
   D /trunk/src/chrome/browser/chromeos/cros/mock_synaptics_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_touchpad_library.h
   D /trunk/src/chrome/browser/chromeos/cros/synaptics_library.cc
   D /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h
   A /trunk/src/chrome/browser/chromeos/cros/touchpad_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/touchpad_library.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Use new touchpad api
BUG=chromium-os:4727,chromium-os:2863
TEST=Confirm that the UI only shows 2 settings (tap-to-click and sensitivity)
     Confirm that the settings work on both x86-generic and x86-dogfood builds.

Review URL: http://codereview.chromium.org/3315016
------------------------------------------------------------------------
r58839 | mark@chromium.org | 2010-09-08 18:46:50 +0200 (Wed, 08 Sep 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

Back out r58827. It caused browser_tests ExtensionApiTest.Rlz to fail.

Failures:

http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests/builds/22649/steps/browser_tests/logs/stdio
http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/22157/steps/browser_tests/logs/stdio

( RUN      ) sendFinancialPing
(  FAILED  ) sendFinancialPing
Got EXTENSION_TEST_FAILED notification.
.\browser\extensions\extension_rlz_apitest.cc(67): error: Value of: RunExtensionTest("rlz")
  Actual: false
Expected: true
FAIL (no message)
    at Object.callback (chrome-extension://acmddjjmpkiijbjcdpchhmniojioobgh/test.js:147:63)
    at Object.<anonymous> (chrome/ExtensionProcessBindings:124:19)
[  FAILED  ] ExtensionApiTest.Rlz (1531 ms)

BUG=54294
TEST=green tests
TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/3371006
------------------------------------------------------------------------
r58837 | yurys@chromium.org | 2010-09-08 18:34:04 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: delete TestStoragePanel which has been superseded by storage-panel-show.html

BUG=
TEST=

Review URL: http://codereview.chromium.org/3369003
------------------------------------------------------------------------
r58827 | rogerta@google.com | 2010-09-08 17:55:16 +0200 (Wed, 08 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

Don't use the return value of rlz_lib::SendFinancialPing() as the return value
of the chrome extension API, since a false does not represent an error.  Added
an optional callback to the API so that caller can determine if the ping was
sent or not.

BUG=54294
TEST=n/a

Review URL: http://codereview.chromium.org/3358012
------------------------------------------------------------------------
r58826 | mmenke@chromium.org | 2010-09-08 16:53:38 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/socketsview.js
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/socks_client_socket_pool.h
   M /trunk/src/net/socket/ssl_client_socket_pool.cc
   M /trunk/src/net/socket/ssl_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool.h

Add missing nested socket pools to socket pool info page.  Each socket pool should be displayed once and only once.  Also, if more than one proxy is in use, socket pools with the same proxy will appear adjacent to each other.

BUG=39756
TEST=manual

Review URL: http://codereview.chromium.org/3328009
------------------------------------------------------------------------
r58825 | yurys@chromium.org | 2010-09-08 16:21:51 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   D /trunk/src/chrome/test/data/devtools/script_syntax_error.html

DevTools: delete TestAutocontinueOnSyntaxError test which has been superseded by layout test

BUG=
TEST=

Review URL: http://codereview.chromium.org/3356011
------------------------------------------------------------------------
r58818 | tfarina@chromium.org | 2010-09-08 15:28:07 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h

gtk: Use gtk signal macro in BalloonViewImpl and move a thunk implementation to the source file.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3341018
------------------------------------------------------------------------
r58816 | jochen@chromium.org | 2010-09-08 14:29:47 +0200 (Wed, 08 Sep 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   M /trunk/src/chrome/common/page_transition_types.cc
   M /trunk/src/chrome/common/page_transition_types.h
   D /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation

Revert 58809 - Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3369007

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3359013
------------------------------------------------------------------------
r58809 | jochen@chromium.org | 2010-09-08 13:20:36 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   M /trunk/src/chrome/common/page_transition_types.cc
   M /trunk/src/chrome/common/page_transition_types.h
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html

Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3369007
------------------------------------------------------------------------
r58807 | jochen@chromium.org | 2010-09-08 12:13:57 +0200 (Wed, 08 Sep 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   M /trunk/src/chrome/common/page_transition_types.cc
   M /trunk/src/chrome/common/page_transition_types.h
   D /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation

Revert 58802 - Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3307013

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3317013
------------------------------------------------------------------------
r58806 | nkostylev@chromium.org | 2010-09-08 12:11:10 +0200 (Wed, 08 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/help_app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/login/login_html_dialog.h

Show help topic dialog with "Can't access your account" for online/offline cases.
Create HelpAppLauncher and LoginHtmlDialog instances only once.

BUG= http://crosbug.com/6379
TEST=Tried on 3 cases: network not connected/connected but no internet (offline), connected to internet (online help topic)

Review URL: http://codereview.chromium.org/3294012
------------------------------------------------------------------------
r58802 | jochen@chromium.org | 2010-09-08 11:37:23 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
   M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   M /trunk/src/chrome/common/page_transition_types.cc
   M /trunk/src/chrome/common/page_transition_types.h
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html

Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3307013
------------------------------------------------------------------------
r58799 | kochi@chromium.org | 2010-09-08 10:43:52 +0200 (Wed, 08 Sep 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/chrome_browser.gypi

Don't use anonymous namespace in header files.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces

BUG=none
TEST=compile and run manually

Review URL: http://codereview.chromium.org/3293014
------------------------------------------------------------------------
r58795 | oshima@chromium.org | 2010-09-08 09:23:38 +0200 (Wed, 08 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Initialize delegate_ with NULL to pervent calling method on uninitialized reference.
This was causing crash on screen locker.

BUG=chromium-os: 6417
TEST=none

Review URL: http://codereview.chromium.org/3296011
------------------------------------------------------------------------
r58794 | thestig@chromium.org | 2010-09-08 08:30:33 +0200 (Wed, 08 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autofill/autofill_type.cc
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils_unittest.cc
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_factory.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/focus_tracker.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view.mm
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   M /trunk/src/chrome/browser/cocoa/test_event_utils.h
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm
   M /trunk/src/chrome/browser/dock_info_mac.cc
   M /trunk/src/chrome/browser/dock_info_win.cc
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.cc
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_proxy_api.cc
   M /trunk/src/chrome/browser/extensions/extension_test_message_listener.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/google/google_update_settings_posix.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/js_modal_dialog_win.cc
   M /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.cc
   M /trunk/src/chrome/browser/password_manager/ie7_password.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/power_save_blocker_stub.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/resources_util.cc
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler_mac.mm
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/url_translator.cc
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_worker.cc
   M /trunk/src/chrome/browser/sync/notifier/registration_manager_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/util/crypto_helpers.h
   M /trunk/src/chrome/browser/sync/util/data_encryption.cc
   M /trunk/src/chrome/browser/sync/util/data_encryption.h
   M /trunk/src/chrome/browser/sync/util/user_settings_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/browser/views/frame/popup_non_client_frame_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/wrench_menu_model_unittest.cc
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/deprecated/event_sys_unittest.cc
   M /trunk/src/chrome/common/gpu_info_unittest.cc
   M /trunk/src/chrome/common/gpu_messages_unittest.cc
   M /trunk/src/chrome/gpu/gpu_info_collector_win.cc
   M /trunk/src/chrome/gpu/gpu_info_unittest_win.cc
   M /trunk/src/chrome/installer/util/chrome_frame_distribution.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/create_dir_work_item.cc
   M /trunk/src/chrome/installer/util/create_reg_key_work_item.cc
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item.cc
   M /trunk/src/chrome/installer/util/helper.cc
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/move_tree_work_item.cc
   M /trunk/src/chrome/installer/util/self_reg_work_item.cc
   M /trunk/src/chrome/installer/util/set_reg_value_work_item.cc
   M /trunk/src/chrome/installer/util/work_item_list.cc
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/mock_printer.cc
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.cc
   M /trunk/src/chrome/test/webdriver/commands/command.h
   M /trunk/src/chrome/test/webdriver/commands/response.h
   M /trunk/src/chrome/worker/worker_webapplicationcachehost_impl.cc

FBTF: Remove unneeded headers from base/ (part 8)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3232003
------------------------------------------------------------------------
r58792 | vangelis@chromium.org | 2010-09-08 07:53:04 +0200 (Wed, 08 Sep 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

Enable webgl and accelerated compositing by default on all platforms. Removes
--enable-webgl and --enable-accelerated-compositing flags and replaces them by
--disable-webgl and --disable-accelerated-compositing. This CL is practically identical
to:
http://src.chromium.org/viewvc/chrome?view=rev&revision=58711

which was checked in the later reverted in:

http://src.chromium.org/viewvc/chrome?view=rev&revision=58730 

due to UI test failures related to video playback via the compositor. The main difference
is that mac is no longer excluded so the two features are now turned on on all 3 platforms.

The issue with the failing UI tests was corrected upstream in WebKit:
http://trac.webkit.org/changeset/66923

so this WebKit change must be rolled in before the chromium change lands.

BUG=54469
TEST=NONE


Review URL: http://codereview.chromium.org/3348012
------------------------------------------------------------------------
r58789 | yusukes@chromium.org | 2010-09-08 07:11:16 +0200 (Wed, 08 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.cc

Improve Korean keyboard support.

- Add resources for xkb:kr:kr104:kor.
- Add "Hangul" to kHotkeyNextEngineInMenu. The key works just like the Zenkaku_Hankaku key on a Japanese keyboard.
- Change Hangul-to-Hanja hotkey from "Ctrl+Alt+9" to "Ctrl+9" following Mozc's policy. Note that we can use Hangul_Hanja key for the purpose as well.

BUG=chromium-os:4812
TEST=manually checked that both Hangul and Hangul_Hanja keys are working as intended. see the bug for details.

Review URL: http://codereview.chromium.org/3323012
------------------------------------------------------------------------
r58788 | isherman@chromium.org | 2010-09-08 06:53:42 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

Get rid of FormStructure::ConvertToFormData()

BUG=none
TEST=unit_tests --gtest_filter=FormStructureTest.SourceURL

Review URL: http://codereview.chromium.org/3309010
------------------------------------------------------------------------
r58787 | kochi@chromium.org | 2010-09-08 06:17:42 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Remove 'initialized' check to redraw list properly.

BUG=chromium-os:5887
TEST=manually

Review URL: http://codereview.chromium.org/3368002
------------------------------------------------------------------------
r58785 | kochi@chromium.org | 2010-09-08 05:07:02 +0200 (Wed, 08 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_chewing_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_mozc_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options/pref_ui.js

Input box with spin-button was used to input numbers
which has range.

But the HTML5 spin-button UI (<input type=number>) allows
users to input invalid values, which makes us show error
messages or something.

Instead of using spin-button UI, we use more restrictive
UI so that users cannot set any invalid value.

BUG=chromium-os:6369
TEST=manually on ChromeOS device.

Review URL: http://codereview.chromium.org/3296010
------------------------------------------------------------------------
r58782 | johnnyg@chromium.org | 2010-09-08 03:38:35 +0200 (Wed, 08 Sep 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   D /trunk/src/chrome/browser/net/gaia/token_service_unittest.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   A /trunk/src/chrome/browser/sync/engine/auth_watcher.cc (from /trunk/src/chrome/browser/sync/engine/auth_watcher.cc:58777)
   A /trunk/src/chrome/browser/sync/engine/auth_watcher.h (from /trunk/src/chrome/browser/sync/engine/auth_watcher.h:58777)
   A /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc (from /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc:58777)
   A /trunk/src/chrome/browser/sync/engine/authenticator.cc (from /trunk/src/chrome/browser/sync/engine/authenticator.cc:58777)
   A /trunk/src/chrome/browser/sync/engine/authenticator.h (from /trunk/src/chrome/browser/sync/engine/authenticator.h:58777)
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   D /trunk/src/chrome/browser/sync/signin_manager.cc
   D /trunk/src/chrome/browser/sync/signin_manager.h
   D /trunk/src/chrome/browser/sync/signin_manager_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   D /trunk/src/chrome/browser/sync/token_migrator.cc
   D /trunk/src/chrome/browser/sync/token_migrator.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   A /trunk/src/chrome/test/live_sync/offline_sync_test.cc (from /trunk/src/chrome/test/live_sync/offline_sync_test.cc:58777)
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/single_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/profile_mock.h
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Revert 58778 - New authorization framework for sync.  

To quote chron's original patch (http://codereview.chromium.org/3148036/show)
<blockquote>
This patch removes: authenticator.cc, auth_watcher.cc 

removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. 

Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. 
</blockquote>

BUG=51001, 50293, 35158
TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog.

Review URL: http://codereview.chromium.org/3305003

TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/3310019
------------------------------------------------------------------------
r58781 | kinuko@chromium.org | 2010-09-08 02:50:41 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/base/file_util_proxy.cc
   M /trunk/src/base/file_util_proxy.h
   M /trunk/src/chrome/browser/file_system/file_system_operation.cc

Add recursive flag to file_util_proxy::CreateDirectory.

BUG=54352
TEST=all the FileSystemOperationTest.TestCreateDir* should continue to pass

Review URL: http://codereview.chromium.org/3293009
------------------------------------------------------------------------
r58779 | isherman@chromium.org | 2010-09-08 02:12:25 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Break out of nested loops in AutoFillManager::GetAutoFillSuggestions

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3355012
------------------------------------------------------------------------
r58778 | johnnyg@chromium.org | 2010-09-08 02:06:34 +0200 (Wed, 08 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   A /trunk/src/chrome/browser/net/gaia/token_service_unittest.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   D /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   D /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   D /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   D /trunk/src/chrome/browser/sync/engine/authenticator.cc
   D /trunk/src/chrome/browser/sync/engine/authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   A /trunk/src/chrome/browser/sync/signin_manager.cc
   A /trunk/src/chrome/browser/sync/signin_manager.h
   A /trunk/src/chrome/browser/sync/signin_manager_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   A /trunk/src/chrome/browser/sync/token_migrator.cc
   A /trunk/src/chrome/browser/sync/token_migrator.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   D /trunk/src/chrome/test/live_sync/offline_sync_test.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/single_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/profile_mock.h
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

New authorization framework for sync.  

To quote chron's original patch (http://codereview.chromium.org/3148036/show)
<blockquote>
This patch removes: authenticator.cc, auth_watcher.cc 

removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. 

Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. 
</blockquote>

BUG=51001, 50293, 35158
TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog.

Review URL: http://codereview.chromium.org/3305003
------------------------------------------------------------------------
r58777 | jhawkins@chromium.org | 2010-09-08 02:05:39 +0200 (Wed, 08 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.h

gtk: Use CHROMEGTK_CALLBACK in PrintDialogGtk and move a thunk implementation
to the source file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3306012
------------------------------------------------------------------------
r58776 | ctguil@chromium.org | 2010-09-08 02:02:37 +0200 (Wed, 08 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.h

Implement ISimpleDOM COM interface in BrowserAccessibility. Also update
a few IAccessible2 functions with some of the new attributes that are
available now.

BUG=48185
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58491
Review URL: http://codereview.chromium.org/3219009
------------------------------------------------------------------------
r58775 | mirandac@chromium.org | 2010-09-08 01:58:49 +0200 (Wed, 08 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h

Fix Firefox data import for Mac.

r58258 broke Firefox import on the Mac by trying to use a value from g_browser_process, which is not accessible in Mac out-of-process import.

Because this value isn't used or needed for the Mac build, don't even create it in the Mac version.

BUG=54265
TEST=Firefox import works on Mac again.

Review URL: http://codereview.chromium.org/3341016
------------------------------------------------------------------------
r58771 | sky@chromium.org | 2010-09-08 01:02:35 +0200 (Wed, 08 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_delegate.h

Changes the max width for bookmark menus back to 400 and leaves them
at 800 for the wrench menu. Apparently folks don't like wide bookmark
menus.

BUG=50653
TEST=see bug

Review URL: http://codereview.chromium.org/3317011
------------------------------------------------------------------------
r58770 | thakis@chromium.org | 2010-09-08 00:56:32 +0200 (Wed, 08 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Mac: Fix window shadow when compositor is active.

BUG=53382
TEST=Enable compositor. Window shadow should look normal, even after resizing the window. The shadow of other windows (prefs, bubbles, etc) should look like it did before.

Review URL: http://codereview.chromium.org/3360014
------------------------------------------------------------------------
r58769 | rsimha@chromium.org | 2010-09-08 00:43:05 +0200 (Wed, 08 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/notification_method.cc (from /trunk/src/chrome/browser/sync/notification_method.cc:58767)
   A /trunk/src/chrome/browser/sync/notification_method.h (from /trunk/src/chrome/browser/sync/notification_method.h:58767)
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/jingle/jingle.gyp
   D /trunk/src/jingle/notifier/base/notification_method.cc
   D /trunk/src/jingle/notifier/base/notification_method.h
   D /trunk/src/jingle/notifier/base/notifier_options.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/jingle/notifier/listener/talk_mediator_unittest.cc

Revert 58768 - Adding the sync-notification-host command line parameter to the integration tests.

The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.

BUG=53933,53931
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3326007

TBR=rsimha@chromium.org
Review URL: http://codereview.chromium.org/3318016
------------------------------------------------------------------------
r58768 | rsimha@chromium.org | 2010-09-08 00:28:23 +0200 (Wed, 08 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   D /trunk/src/chrome/browser/sync/notification_method.cc
   D /trunk/src/chrome/browser/sync/notification_method.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/jingle/jingle.gyp
   A /trunk/src/jingle/notifier/base/notification_method.cc (from /trunk/src/chrome/browser/sync/notification_method.cc:58765)
   A /trunk/src/jingle/notifier/base/notification_method.h (from /trunk/src/chrome/browser/sync/notification_method.h:58765)
   A /trunk/src/jingle/notifier/base/notifier_options.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/jingle/notifier/listener/talk_mediator_unittest.cc

Adding the sync-notification-host command line parameter to the integration tests.

The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.

BUG=53933,53931
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3326007
------------------------------------------------------------------------
r58766 | lzheng@chromium.org | 2010-09-08 00:12:55 +0200 (Wed, 08 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

In OnEnableSpdy(bool), use "npn,force-alt-protocol" so we could use alternate protocol to test spdy number for http.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3315008
------------------------------------------------------------------------
r58762 | lzheng@chromium.org | 2010-09-07 23:57:08 +0200 (Tue, 07 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc

Add "?" to query strings if original url has no query string.

BUG=none
TEST=protocol_manager_unittest.cc
Review URL: http://codereview.chromium.org/3244005
------------------------------------------------------------------------
r58760 | eroman@chromium.org | 2010-09-07 23:39:06 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/main.js

Change the display of chrome://net-internals/#data.

The help text is no longer inline, and it shows the number of events that have been captured so far.

BUG=53168
Review URL: http://codereview.chromium.org/3351013
------------------------------------------------------------------------
r58759 | sky@chromium.org | 2010-09-07 23:33:58 +0200 (Tue, 07 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h

Adds the following to CancelableRequestConsumer:

GetClientDataForCurrentRequest: The particular use case I need this
for is that I'm using the same CancelableRequestConsumer for multiple
sources so that I don't know whic CancelableRequestProvider to pass in
to GetClientData. None-the-less it seems a lot easier to use this when
always get the provider and handle.

GetFirstHandleForClientData: For this one I know I want to cancel a
request for a given client data but don't know the associated handle.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3311012
------------------------------------------------------------------------
r58758 | estade@chromium.org | 2010-09-07 23:32:57 +0200 (Tue, 07 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/app/gtk_util.cc
   M /trunk/src/app/gtk_util.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc

[GTK] change workaround for weird RTL label alignment

When a GtkLabel has line wrapping and an integer size request, the text block is left aligned even in RTL locales. It will wrap at the left (which is correct) and be right justified (also correct) but is flush with the left of the widget allocation instead of the right of the widget allocation.

seems not to occur when the size is controled via gtk_label_set_width_chars() instead of gtk_widget_set_size_request(). (also goes away when line wrapping is turned off)

TODO: file a reduction upstream.

BUG=52857
TEST=launch chrome in Hebrew and look at the under the hood tab of options. Checkbox labels should look correct

Review URL: http://codereview.chromium.org/3355007
------------------------------------------------------------------------
r58757 | cmasone@google.com | 2010-09-07 23:23:35 +0200 (Tue, 07 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

[Chrome OS] Make Chrome call session_manager to trigger exit

On Chromium OS, instead of letting the browser exit directly, we want to
allow another process to trigger and watch shutdown, because otherwise we
have no way of dealing with chrome hanging on exit.

BUG=chromium-os:5395
TEST=Install chrome on a device, log in and log out.  Look at /var/log/session_manager to determine that it triggered the browser exit.

Review URL: http://codereview.chromium.org/3112012
------------------------------------------------------------------------
r58755 | apatrick@chromium.org | 2010-09-07 22:45:01 +0200 (Tue, 07 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/app/gfx/gl/gl_context_egl.cc
   M /trunk/src/app/gfx/gl/gl_context_egl.h
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/gpu_info.cc
   M /trunk/src/chrome/common/gpu_info.h
   R /trunk/src/chrome/common/gpu_messages.cc
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/gpu_messages_unittest.cc
   A /trunk/src/chrome/common/gpu_param_traits.h (from /trunk/src/chrome/common/gpu_messages.h:56594)
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/gpu/DEPS
   M /trunk/src/chrome/gpu/gpu_info_collector.h
   M /trunk/src/chrome/gpu/gpu_info_collector_linux.cc
   M /trunk/src/chrome/gpu/gpu_info_collector_mac.mm
   M /trunk/src/chrome/gpu/gpu_info_collector_win.cc
   M /trunk/src/chrome/gpu/gpu_info_unittest_win.cc
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Added GPU stat for whether a GPU can report context lost.
On Windows it checks to see if the IDirect3D9 object supports Vista and later features (meaning it won't routinely report lost contexts). On Linux and Mac we can just check if its EGL versus some other GL that doesn't report lost contexts.

I routed the stats to the renderer process so webkit code can query whether lost contexts are likely.

I didn't wire up breakpad yet.

TEST=try
BUG=52318

Review URL: http://codereview.chromium.org/3149016
------------------------------------------------------------------------
r58754 | tfarina@chromium.org | 2010-09-07 22:43:31 +0200 (Tue, 07 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/options_util.cc

Reset the desktop notifications settings to default.

When the user clicks in "Reset to default" button on the Preferences/Options dialog, we should reset
the desktop notifications settings to the default default option, like we already do for the other content settings.

BUG=49656
TEST=see bug.

Review URL: http://codereview.chromium.org/3332007
------------------------------------------------------------------------
r58747 | estade@chromium.org | 2010-09-07 22:32:07 +0200 (Tue, 07 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/content_settings.html

Clean up tabbed content settings pages.

Remove errant buttons and change a <span> to an <h4>.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/3298016
------------------------------------------------------------------------
r58744 | cmasone@google.com | 2010-09-07 22:28:16 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.cc
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.h
   M /trunk/src/chrome/browser/chromeos/login/ownership_service_unittest.cc

[Chrome OS] Add the owner to the whitelist on first login

BUG=None
TEST=unit tests, run on the device and then check the whitelist for the owner.

Review URL: http://codereview.chromium.org/3340012
------------------------------------------------------------------------
r58740 | rohitrao@chromium.org | 2010-09-07 22:02:18 +0200 (Tue, 07 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

[Mac] Snap fullscreen window to screen after exiting spaces 

Users can arbitrarily move fullscreen windows. If the fullscreen window changes screen then the fullscreen controller will snap it to the screen. If the fullscreen window doesn't change screen then the window will remain where it is which looks weird. 

This patch fixes the issue by always snapping the window's frame to the screen any time it has moved. 

An alternative fix would be to override a new 10.6 API: -[NSWindow isMovable] and return NO. This would allow users to move windows between spaces but not the position inside a space. 

I think detecting window move is better because: 
- it works on 10.5 also 
- users with multiple monitors can uses space to move the window between monitors 

Patch by Sailesh Agrawal <fnepal@gmail.com>.

BUG=41693
TEST=Verified that the full screen window snaps to the screen when moved in Spaces. Verified that changing the screen resolution, mirroring, etc... all correct cause the full screen window to snap to the screen.
Review URL: http://codereview.chromium.org/3343009
------------------------------------------------------------------------
r58739 | csilv@chromium.org | 2010-09-07 21:44:21 +0200 (Tue, 07 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js

dom-ui options: Correctly set enabled state of commit button when showing the dialog.

BUG=none
TEST=Open 'Clear Browsing Data' dialog when no options are checked, commit button should be disabled.
Review URL: http://codereview.chromium.org/3352006
------------------------------------------------------------------------
r58738 | csilv@chromium.org | 2010-09-07 21:43:42 +0200 (Tue, 07 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc

dom-ui options: Improve how proxy preferences are observed.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3366009
------------------------------------------------------------------------
r58737 | creis@google.com | 2010-09-07 21:42:41 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc

Makes --disable-hang-monitor apply to navigations and closing tabs.

BUG=none
TEST=Pass --disable-hang-monitor and close a tab with a slow onunload event.

Review URL: http://codereview.chromium.org/3327011
------------------------------------------------------------------------
r58733 | avayvod@chromium.org | 2010-09-07 21:35:56 +0200 (Tue, 07 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h

Disabled Create Account link with a flag.

BUG=chromium-os:5819
TEST=Check that Create Account link is not present on New User pod or login
screen.

Review URL: http://codereview.chromium.org/3315013
------------------------------------------------------------------------
r58732 | rdsmith@chromium.org | 2010-09-07 21:33:26 +0200 (Tue, 07 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_store_test.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

This CL changes our per-domain limits to be per-effective domain.

This matches FireFox behavior and is for denial of service protection
when we go to FireFox expiry behavior (keeping cookies around
indefinitely if they don't have a max-age and are being used); see
issue (8850) for details.

BUG=8850
TEST=net_unittests/net_perftests on Linux with CookieMonsterTest.* filter

Review URL: http://codereview.chromium.org/3122013
------------------------------------------------------------------------
r58731 | phajdan.jr@chromium.org | 2010-09-07 21:32:13 +0200 (Tue, 07 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc

GTTF: Make WaitForTabCountToBecome automation call not Sleep.

Sleeping is an unreliable method to wait for things.
Instead, we set up an observer.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3300011
------------------------------------------------------------------------
r58730 | mark@chromium.org | 2010-09-07 21:09:41 +0200 (Tue, 07 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

Back out r58711. It appears to have caused video/media-related ui_tests
failures on Windows:

MediaTest.VideoBearTheora
MediaTest.VideoBearSilentTheora
MediaTest.VideoBearWebm
MediaTest.VideoBearSilentWebm
UILayoutTest.MediaUILayoutTest

BUG=54469
TEST=tree
Review URL: http://codereview.chromium.org/3333019
------------------------------------------------------------------------
r58728 | nirnimesh@chromium.org | 2010-09-07 20:47:46 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc

Fix the expected number of crashes in a metrics test.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3295015
------------------------------------------------------------------------
r58727 | avi@chromium.org | 2010-09-07 20:46:51 +0200 (Tue, 07 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc

Update bug reference.

BUG=54711
TEST=no change; comment alteration.


Review URL: http://codereview.chromium.org/3306010
------------------------------------------------------------------------
r58718 | phajdan.jr@chromium.org | 2010-09-07 19:58:16 +0200 (Tue, 07 Sep 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/download/base_file.cc
   M /trunk/src/chrome/browser/download/base_file.h
   M /trunk/src/chrome/browser/download/base_file_unittest.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

Revert 58196 - GTTF: Clean up DownloadFileManager

This removes a lot of duplication, locking, and thread jumping.

Most of the operations run on the FILE thread, and we do not duplicate
so much information. Each DownloadFile keeps track of its DownloadManager
(each Profile has its own DownloadManager). This allows us to remove
many maps from DownloadFileManager that were duplicating that information.

There is still SaveFileManager, but hopefully I will be able
to merge those two in small steps.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3245005

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3348010
------------------------------------------------------------------------
r58717 | phajdan.jr@chromium.org | 2010-09-07 19:56:42 +0200 (Tue, 07 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

Revert 58374 - Fix a race condition after my latest download cleanup change.

We need to pause the download request until the on-disk file
is actually created. Otherwise all data received from network would
be discarded.

BUG=54131
TEST=see bug

Review URL: http://codereview.chromium.org/3333007

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3307015
------------------------------------------------------------------------
r58711 | vangelis@chromium.org | 2010-09-07 19:46:09 +0200 (Tue, 07 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

Turning WebGL and the accelerated compositor on by default (linux and windows only for the compositor),
removing the --enable-webgl flag and adding --disable-webgl and --disable-accelerated-compositing.
On the mac --enable-accelerated-compositing still needs to be supplied to enable the compositor.
BUG=54469
Review URL: http://codereview.chromium.org/3342016
------------------------------------------------------------------------
r58710 | jcivelli@chromium.org | 2010-09-07 19:39:15 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc

Unit test RenderViewHostManagerTest.PageDoesBackAndReload fails on Mac, marking it FAILS while I investigate.

TBR=shess
BUG=54708

Review URL: http://codereview.chromium.org/3355010
------------------------------------------------------------------------
r58709 | dimich@chromium.org | 2010-09-07 19:31:38 +0200 (Tue, 07 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

First click on Dock icon (OSX) should restore session if Chrome was launched as hidden login item.

Review URL: http://codereview.chromium.org/3246007
------------------------------------------------------------------------
r58708 | finnur@chromium.org | 2010-09-07 19:16:59 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Shorten the string telling you to restart in the About box to avoid truncation.

BUG=53276
TEST=On XP, upgrade through the About box and make sure the text prompting you to restart isn't truncated.

Review URL: http://codereview.chromium.org/3293013
------------------------------------------------------------------------
r58707 | stevenjb@chromium.org | 2010-09-07 19:02:44 +0200 (Tue, 07 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc

Rebaseline a bunch of tests in repaint since they are correct (except for the grayed-out repainted area we don't support in the image diffs).

Remove some passing tests from the new/ignored test list, rebase a few others.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2715

Review URL: http://codereview.chromium.org/5601
------------------------------------------------------------------------
r58703 | stevenjb@chromium.org | 2010-09-07 18:40:02 +0200 (Tue, 07 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view_browsertest.cc

Issue 5214: hide autoconnect option for new (non favorite) networks.
Add 'favorite' state to WirelessNetwork and use it to determine whether to show autoconnect checkbox.

BUG=chromium-os:5214
TEST=Test connecting to new and remembered secure netowrks. See issue.

Given that this dialog is going to be phased out, hiding the autoconnect checkbox for new networks is the most consistent with how the new UI will behave.

Review URL: http://codereview.chromium.org/3350007
------------------------------------------------------------------------
r58702 | zelidrag@chromium.org | 2010-09-07 18:30:17 +0200 (Tue, 07 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js

Fixed crashes caused by unimplemented content settings for location and notifications.
This should make these pages slightly more implemented as well.

BUG=chromium-os:6301
TEST=make sure playing with location and notifications content setting pages can't crash them anymore

Review URL: http://codereview.chromium.org/3303009
------------------------------------------------------------------------
r58701 | jcivelli@chromium.org | 2010-09-07 18:29:54 +0200 (Tue, 07 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Relanding this:

Don't create pending entries when a navigation is initiated by the page.
If the page reloads while such a navigation happens, we could end up with the wrong pending entry. Also make sure TestTabContents::NavigateAndCommit() does commit on the right RVH.

BUG=51680
TEST=See bug for steps.
TBR=creis
Review URL: http://codereview.chromium.org/3257002


Review URL: http://codereview.chromium.org/3346005
------------------------------------------------------------------------
r58698 | glotov@google.com | 2010-09-07 17:48:14 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Bugfix of language change in test image build.

BUG=chromium-os:6424
TEST=Languege change on test image does not cause a crash

Review URL: http://codereview.chromium.org/3311015
------------------------------------------------------------------------
r58692 | mnissler@chromium.org | 2010-09-07 15:58:47 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/policy/policy_templates.grd
   M /trunk/src/chrome/app/policy/policy_templates.json
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add policy to control 'show password' facility in the password manager.

BUG=49609
TEST=Manual

Review URL: http://codereview.chromium.org/3299010
------------------------------------------------------------------------
r58677 | zork@chromium.org | 2010-09-07 10:25:35 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Give kLanguagePreferredLanguages a default value.

BUG=chromium-os:6473
TEST=Log in in incognito mode.  Go to the language menu.  Check that languages exist.

Review URL: http://codereview.chromium.org/3297012
------------------------------------------------------------------------
r58676 | zork@chromium.org | 2010-09-07 10:15:21 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Reload language id maps when the locale changes

BUG=chromium-os:6393
TEST=See bug

Review URL: http://codereview.chromium.org/3326013
------------------------------------------------------------------------
r58672 | yusukes@chromium.org | 2010-09-07 09:24:06 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Call SetCurrentKeyboardLayoutByName("us") instead of ChangeInputMethod("xkb:us::eng") in StopInputMethodProcesses.

BUG=chromium-os:6461
TEST=manually

Review URL: http://codereview.chromium.org/3342018
------------------------------------------------------------------------
r58668 | yurys@chromium.org | 2010-09-07 07:59:07 +0200 (Tue, 07 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: delete DevToolsSanityTest.TestMessageLoopReentrant which is superseded by LayoutTests/inspector/debugger-eval-while-paused.html

BUG=53406
TEST=LayoutTests/inspector/debugger-eval-while-paused.html

Review URL: http://codereview.chromium.org/3309009
------------------------------------------------------------------------
r58666 | nsylvain@chromium.org | 2010-09-07 07:15:20 +0200 (Tue, 07 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h

Revert 58663 - Revert 58641 - Add user metrics for nonsandboxed plugin infobar.

BUG=52341
TEST=none

Review URL: http://codereview.chromium.org/3303003

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/3300015

TBR=mal@chromium.org
Review URL: http://codereview.chromium.org/3303011
------------------------------------------------------------------------
r58664 | nsylvain@chromium.org | 2010-09-07 06:38:51 +0200 (Tue, 07 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Reland 58601 -

Have the browser start connecting as soon as the navigation starts.  This
seems trivial, but this gets the network going before we start the renderer
process creation, which can save 45+ms of latency.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3358011

TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/3325014

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3340015
------------------------------------------------------------------------
r58663 | mal@chromium.org | 2010-09-07 06:38:47 +0200 (Tue, 07 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h

Revert 58641 - Add user metrics for nonsandboxed plugin infobar.

BUG=52341
TEST=none

Review URL: http://codereview.chromium.org/3303003

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/3300015
------------------------------------------------------------------------
r58662 | nsylvain@chromium.org | 2010-09-07 05:51:07 +0200 (Tue, 07 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Revert 58601 -

A lot of ui_tests flakiness started around that revision, I want to verify if this is the cause.

original comment:

Have the browser start connecting as soon as the navigation starts.  This
seems trivial, but this gets the network going before we start the renderer
process creation, which can save 45+ms of latency.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3358011

TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/3325014
------------------------------------------------------------------------
r58648 | arv@chromium.org | 2010-09-06 20:34:06 +0200 (Mon, 06 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js
   M /trunk/src/chrome/browser/resources/shared/css/menu.css
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/command.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/position_util.js

NTP: Adds a context menu to the apps section

This uses the cr Menu system and replaces the old options menu with a cr Menu.

BUG=52446
TEST=Start chrome with enable-apps. Install some apps.
Right clicking on an app should show a context menu.
Clicking the wrench should show the same menu.


Review URL: http://codereview.chromium.org/3315005
------------------------------------------------------------------------
r58647 | yurys@chromium.org | 2010-09-06 19:25:41 +0200 (Mon, 06 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   D /trunk/src/chrome/test/data/devtools/debugger_closure.html

DevTools: delete DevToolsSanityTest.TestExpandScope which was converted into a layout test

BUG=53664
TEST=DevToolsSanityTest.TestExpandScope

Review URL: http://codereview.chromium.org/3291013
------------------------------------------------------------------------
r58643 | nkostylev@chromium.org | 2010-09-06 17:59:08 +0200 (Mon, 06 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   A /trunk/src/chrome/browser/chromeos/login/help_app_launcher.cc
   A /trunk/src/chrome/browser/chromeos/login/help_app_launcher.h
   M /trunk/src/chrome/browser/chromeos/login/login_html_dialog.cc
   M /trunk/src/chrome/browser/chromeos/login/login_html_dialog.h
   M /trunk/src/chrome/chrome_browser.gypi

Adding HelpApp into login/OOBE flows that shows static help files. Show help dialog for EULA screen.
Default login html dialog size to 80% of each screen dimension.

BUG= http://crosbug.com/6379
TEST=Place help content to /usr/share/chromeos-assets/help/usage.html, observe help dialog at EULA screen.

Review URL: http://codereview.chromium.org/3367008
------------------------------------------------------------------------
r58642 | dilmah@chromium.org | 2010-09-06 17:49:05 +0200 (Mon, 06 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Show register screen for first incognito signin during OOBE.

BUG=http://crosbug.com/5375
TEST=Manual

Review URL: http://codereview.chromium.org/3332006
------------------------------------------------------------------------
r58641 | bauerb@chromium.org | 2010-09-06 17:47:38 +0200 (Mon, 06 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h

Add user metrics for nonsandboxed plugin infobar.

BUG=52341
TEST=none

Review URL: http://codereview.chromium.org/3303003
------------------------------------------------------------------------
r58640 | podivilov@chromium.org | 2010-09-06 17:34:28 +0200 (Mon, 06 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   D /trunk/src/chrome/test/data/devtools/pause_on_exception.html

DevTools: delete two debugger tests which was moved upstream

BUG=
TEST=

Review URL: http://codereview.chromium.org/3362009
------------------------------------------------------------------------
r58637 | mnissler@chromium.org | 2010-09-06 17:00:40 +0200 (Mon, 06 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/prefs/pref_set_observer.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 58630 - Add constants for preferences and policies related to the Default Search Provider.  Add code to read these new policies into prefs.  Add code to enable monitoring change to these preferences.

BUG=49306
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.*

Review URL: http://codereview.chromium.org/3363005
Patch from Jean-Luc Brouillet <jeanluc@google.com>.

TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3307012
------------------------------------------------------------------------
r58633 | ukai@chromium.org | 2010-09-06 14:25:29 +0200 (Mon, 06 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Failed on Builder Interactive Tests (dbg)

BUG=54592
TEST=interactive_ui_tests
TBR=zmo

Review URL: http://codereview.chromium.org/3337014
------------------------------------------------------------------------
r58630 | mnissler@chromium.org | 2010-09-06 13:38:11 +0200 (Mon, 06 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/prefs/pref_set_observer.cc
   M /trunk/src/chrome/browser/prefs/pref_set_observer.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add constants for preferences and policies related to the Default Search Provider.  Add code to read these new policies into prefs.  Add code to enable monitoring change to these preferences.

BUG=49306
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.*

Review URL: http://codereview.chromium.org/3363005
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
------------------------------------------------------------------------
r58629 | gfeher@chromium.org | 2010-09-06 12:59:52 +0200 (Mon, 06 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/prefs/session_startup_pref.cc

Fixup startup URLs when loaded from preferences

Issue a URL fixup for each startup URL when loaded through SessionStartupPref. This is used by both the preferences GUI and browser_init.cc.

BUG=54249
TEST=manual

Review URL: http://codereview.chromium.org/3350004
------------------------------------------------------------------------
r58627 | ukai@chromium.org | 2010-09-06 11:38:19 +0200 (Mon, 06 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

WebKit Roll 66724 -> 66804

BUG=54591,54592
TEST=none
TBR=zmo

Review URL: http://codereview.chromium.org/3341015
------------------------------------------------------------------------
r58620 | tkent@chromium.org | 2010-09-06 05:25:09 +0200 (Mon, 06 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

TabWindowControlller: did save/restore the first responder at the beginning/end of a drag. 

The problem was, 
replacing the first responder results [RenderWidgethostViewCocoa resignFirstResponder], 
which make the focus lost via render_widget_host_->Blur(). 
This lost happened immediately AFTER the dragging process. 
So we have no change to recover the focus. 

This change reset the first responder BEFORE the draggin process, and restore it after that. 
This makes [RWHVCocoa resignResponder] and [RWHVCocoa becomeFirstResponder] called in appropriate order, 
which calls RVH::Blur() and RVH::Focus() accordingly. 

BUG=30894
TEST=manual
Patch by morrita@google
Original code review: http://codereview.chromium.org/3150031/show
------------------------------------------------------------------------
r58619 | ukai@chromium.org | 2010-09-06 04:09:14 +0200 (Mon, 06 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/google/google_url_tracker.cc
   M /trunk/src/chrome/browser/google/google_url_tracker.h
   M /trunk/src/chrome/browser/google/google_url_tracker_unittest.cc

Update last prompted URL when user choosed "yes" or "no".

BUG=54274
TEST=GoogleURLTrackerTest passes

Review URL: http://codereview.chromium.org/3330008
------------------------------------------------------------------------
r58614 | ananta@chromium.org | 2010-09-05 22:34:06 +0200 (Sun, 05 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix a compile error which occurs on linux.

TBR=amit

Review URL: http://codereview.chromium.org/3364010
------------------------------------------------------------------------
r58613 | ananta@chromium.org | 2010-09-05 21:51:07 +0200 (Sun, 05 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix ChromeFrame tests which regressed due to the change to connect when navigation starts.
The preconnection code uses the chrome http stack which breaks chrome frame which uses
the host network stack.

The fix is to bypass this code if the current RenderViewHostDelegate is an ExternalTabContainer.

TBR=mbelshe

Review URL: http://codereview.chromium.org/3360010
------------------------------------------------------------------------
r58612 | tfarina@chromium.org | 2010-09-05 21:06:52 +0200 (Sun, 05 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Don't show "The page at..." in the Bookmark Manager confirmation dialog.

BUG=52729
TEST=have more than 15 bookmarks in bookmark manager, try to open or delete them
all at once, a confirmation dialog will be shown, notice that the "The page at..."
is not more visible.

Review URL: http://codereview.chromium.org/3195013
------------------------------------------------------------------------
r58607 | jorlow@chromium.org | 2010-09-05 16:58:18 +0200 (Sun, 05 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Land http://codereview.chromium.org/3167045/show

Make Marcus's KeyPath code work with single process mode for IndexedDB.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3296008
------------------------------------------------------------------------
r58601 | mbelshe@chromium.org | 2010-09-05 08:56:26 +0200 (Sun, 05 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Have the browser start connecting as soon as the navigation starts.  This
seems trivial, but this gets the network going before we start the renderer
process creation, which can save 45+ms of latency.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3358011
------------------------------------------------------------------------
r58582 | tfarina@chromium.org | 2010-09-04 17:21:50 +0200 (Sat, 04 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/base/debug_util_posix.cc
   M /trunk/src/base/linux_util.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Cleanup some duplicated includes.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3358014
------------------------------------------------------------------------
r58581 | sky@chromium.org | 2010-09-04 16:54:20 +0200 (Sat, 04 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.h
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Lands http://codereview.chromium.org/3364005/show for jeanluc:

Disable editing and setting of the default search provider if the
provider is managed via group policy. 

BUG=49306
TEST=KeywordEditorControllerTest* 
Review URL: http://codereview.chromium.org/3296007
------------------------------------------------------------------------
r58578 | shess@chromium.org | 2010-09-04 06:12:55 +0200 (Sat, 04 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc

Enable SafeBrowsingDatabaseNew.

Convert from SafeBrowsingDatabaseBloom to SafeBrowsingDatabaseNew for
default database.

Shift histograms for SB2.AddPrefixes and SB2.SubPrefixes to the store,
because the database can't see the sub count.

Enable SB2.FailedUpdate for SafeBrowsingStoreSqlite to match bloom
code.

BUG=28647
TEST=none

Review URL: http://codereview.chromium.org/3320009
------------------------------------------------------------------------
r58577 | tfarina@chromium.org | 2010-09-04 05:39:53 +0200 (Sat, 04 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h

Cleanup the SSLPolicyBackend class.

This removes some code that now are obsolete.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3337005
------------------------------------------------------------------------
r58571 | kinuko@chromium.org | 2010-09-04 03:59:48 +0200 (Sat, 04 Sep 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/file_system/file_system_backend.cc
   D /trunk/src/chrome/browser/file_system/file_system_backend.h
   D /trunk/src/chrome/browser/file_system/file_system_backend_client.h
   D /trunk/src/chrome/browser/file_system/file_system_backend_unittest.cc
   A /trunk/src/chrome/browser/file_system/file_system_operation.cc
   A /trunk/src/chrome/browser/file_system/file_system_operation.h (from /trunk/src/chrome/browser/file_system/file_system_backend.h:58570)
   A /trunk/src/chrome/browser/file_system/file_system_operation_client.h (from /trunk/src/chrome/browser/file_system/file_system_backend_client.h:58570)
   A /trunk/src/chrome/browser/file_system/file_system_operation_unittest.cc (from /trunk/src/chrome/browser/file_system/file_system_backend_unittest.cc:58570)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Rename FileSystemBackend to FileSystemOperation and make it explicit that it's supposed to be used for single time operation per instance.

Original patch from kkanetkar@chromium.org
http://codereview.chromium.org/3319005/show

BUG=32277
TEST=none

Review URL: http://codereview.chromium.org/3360006
------------------------------------------------------------------------
r58570 | estade@chromium.org | 2010-09-04 03:57:59 +0200 (Sat, 04 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

reland r57885 with a fix for the DCHECK failures observed by nsylvain.

Now we only delay shutdown of the constrained window in the escape case (see constrained_window_gtk.cc). Locally this fixes the DCHECKs in both manual testing and the login prompt ui tests.

BUG=53242, 50799
TEST=ui_tests --gtest_filter=LoginPromptTest*

Review URL: http://codereview.chromium.org/3351006
------------------------------------------------------------------------
r58569 | estade@chromium.org | 2010-09-04 03:54:11 +0200 (Sat, 04 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

[GTK] first run:

show default search engine from import.

BUG=49705
TEST=manual

Review URL: http://codereview.chromium.org/3365007
------------------------------------------------------------------------
r58568 | tfarina@chromium.org | 2010-09-04 03:54:00 +0200 (Sat, 04 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_settings_provider.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

chromeos: Append base:: to StringPrintf calls. Part 2.

This finish the work in the chromeos/ directory.

(Note: This is a TODO in base/stringprintf.h).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3336003
------------------------------------------------------------------------
r58567 | csilv@chromium.org | 2010-09-04 03:41:59 +0200 (Sat, 04 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_mac.cc
   M /trunk/src/net/base/ssl_config_service_mac_unittest.cc
   M /trunk/src/net/base/ssl_config_service_win.cc
   M /trunk/src/net/base/ssl_config_service_win_unittest.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/ssl_client_socket_pool.cc
   M /trunk/src/net/socket/ssl_client_socket_pool.h
   M /trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
   M /trunk/src/net/spdy/spdy_session_pool.cc
   M /trunk/src/net/spdy/spdy_session_pool.h
   M /trunk/src/net/spdy/spdy_test_util.h

Flush SSL pools after SSL config changes.

BUG=46043
TEST=Verify that SSL pools are flushed after user makes SSL change.
Review URL: http://codereview.chromium.org/3274004
------------------------------------------------------------------------
r58566 | gavinp@chromium.org | 2010-09-04 03:36:56 +0200 (Sat, 04 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc

Revert 58563 - GTTF: Make WaitForTabCountToBecome automation call not Sleep.

(unfortunately, Mac & Windows started failing tab perf tests on this change)

Sleeping is an unreliable method to wait for things.
Instead, we set up an observer.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3300011

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3344009
------------------------------------------------------------------------
r58563 | phajdan.jr@chromium.org | 2010-09-04 01:55:15 +0200 (Sat, 04 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc

GTTF: Make WaitForTabCountToBecome automation call not Sleep.

Sleeping is an unreliable method to wait for things.
Instead, we set up an observer.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3300011
------------------------------------------------------------------------
r58561 | mpcomplete@chromium.org | 2010-09-04 01:49:39 +0200 (Sat, 04 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Re-disable IncognitoSplitMode. It still fails/hangs periodically (though more
rare at least).

BUG=53991
TEST=no
TBR=aa

Review URL: http://codereview.chromium.org/3305011
------------------------------------------------------------------------
r58559 | stevenjb@chromium.org | 2010-09-04 01:27:28 +0200 (Sat, 04 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h

Valgrind fix for chromium-os:5601

BUG=chromium-os:6441 (valgrind error)
TEST=Run Valgrind, verify it doesn't fail in PowerMenuButton.

Original CL: http://codereview.chromium.org/3158014/show

Two changes:
1. Re-ordered the member variables so that members used by GetLabelAt() are initialized before power_menu_ which calls into GetLabelAt().
2. Modified GetLabelAt() to explicitly check for index == 1 for the second line, just for clarity.

Review URL: http://codereview.chromium.org/3291010
------------------------------------------------------------------------
r58556 | aa@chromium.org | 2010-09-04 00:33:53 +0200 (Sat, 04 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js

NTP: Add transitions.

BUG=53978
TEST=Install an app. Expand and collapse sections. Things should swish.

Review URL: http://codereview.chromium.org/3346006
------------------------------------------------------------------------
r58555 | aa@chromium.org | 2010-09-04 00:25:34 +0200 (Sat, 04 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Bring back attribution. If there is no custom attribution, fall back to the product logo.

BUG=53970
TEST=

Review URL: http://codereview.chromium.org/3336004
------------------------------------------------------------------------
r58551 | cbiffle@google.com | 2010-09-04 00:14:11 +0200 (Sat, 04 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/nacl_enabled/manifest.json

Due to some unresolved blocking issues, we are switching Native Client back off for applications/extensions in M7.  This change is aiming for a small diff, since I'm going to turn it right back on once this is cherrypicked.  Thus there's some small redundancy, e.g. in render_view.cc.

BUG=45881
TEST=included
Review URL: http://codereview.chromium.org/3324002
------------------------------------------------------------------------
r58546 | cmasone@google.com | 2010-09-03 23:40:10 +0200 (Fri, 03 Sep 2010) | 14 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/signed_settings.cc
   A /trunk/src/chrome/browser/chromeos/login/signed_settings.h
   A /trunk/src/chrome/browser/chromeos/login/signed_settings_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[CHrome OS] Provides nicer abstractions around ownership API

There are two categories of operations that can be performed on the Chrome OS owner-signed settings store:
1) doing stuff to the whitelist (adding/removing/checking)
2) Storing/Retrieving arbitrary name=value pairs

Unfortunately, it is currently a limitation that only one of a each category can be in-flight at a time.  I've filed an issue on me to remove that restriction.

The pattern of use here is that the caller instantiates some subclass of SignedSettings by calling one of the create methods.  Then, call Execute() on this object from the UI thread.  It'll go off and do work (on the FILE thread and over DBus), and then call the appropriate method of the Delegate you passed in -- again, on the UI thread.

BUG=chromium-os:4488
TEST=Unit tests

Review URL: http://codereview.chromium.org/3345002
------------------------------------------------------------------------
r58545 | tony@chromium.org | 2010-09-03 23:37:46 +0200 (Fri, 03 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Remove wstrings from status bubble code.

Use string16 instead.

BUG=23581

Review URL: http://codereview.chromium.org/3200010
------------------------------------------------------------------------
r58535 | vandebo@chromium.org | 2010-09-03 22:41:53 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/predictor.cc

Fix DCHECK when loading chrome://net-internals

TEST=visit chrome://net-internals and [::1] in a debug build, it shouldn't crash
BUG=NONE

Review URL: http://codereview.chromium.org/3359006
------------------------------------------------------------------------
r58533 | aa@chromium.org | 2010-09-03 22:15:54 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/ntp/apps.js

Remove old debug code from ntp.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3342009
------------------------------------------------------------------------
r58531 | skerner@chromium.org | 2010-09-03 22:08:06 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Error out if a version in external_extensions.json is invalid.

BUG=53915
TEST=ExtensionsServiceTest.ExternalPrefProvider

Review URL: http://codereview.chromium.org/3233008
------------------------------------------------------------------------
r58529 | phajdan.jr@chromium.org | 2010-09-03 21:56:15 +0200 (Fri, 03 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Remove risky DISABLE_RUNNABLE_METHOD_REFCOUNT macro from DownloadManager.

Just use a NewRunnableMethod task posted to the IO thread. The RDH
is guaranteed to live longer than the IO thread.

BUG=48913
TEST=none

Review URL: http://codereview.chromium.org/3331009
------------------------------------------------------------------------
r58528 | satish@chromium.org | 2010-09-03 21:56:13 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble_views.cc

Changed a link widget to button per feedback from UX.

BUG=none
TEST=manual, use speech input on windows and verify that the popup has a cancel button.

Review URL: http://codereview.chromium.org/3367009
------------------------------------------------------------------------
r58526 | stevenjb@chromium.org | 2010-09-03 21:29:29 +0200 (Fri, 03 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc

Added tooltips to stats bar items.
BUG=chromium-os:5601 (http://code.google.com/p/chromium-os/issues/detail?id=5601)
TEST=Check that hover text over status bar icons seems reasonable. Test different states of network (disconnected, ethernet, connecting to a wifi network, connected to a wifi network) and battery (plugged in, unplugged).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57234

Review URL: http://codereview.chromium.org/3158014
------------------------------------------------------------------------
r58524 | derat@chromium.org | 2010-09-03 21:10:02 +0200 (Fri, 03 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc

chromeos: Increase omnibox font size.

This change makes it two points larger than the popup and
tab text.  I am hesitant to make a similar change to the
GTK version, at least in this change, since there have
already been a bunch of omnibox-font-sizing problems there.

BUG=50568
TEST=built and tried it

Review URL: http://codereview.chromium.org/3181023
------------------------------------------------------------------------
r58516 | vangelis@chromium.org | 2010-09-03 20:49:57 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Turn off accelerated compositing for chrome:// and chrome-extension:// URLs for now to avoid
regressions in look or startup time penalty. Once the compositor is baked in a bit better we can
look into re-enabling them.
BUG=51691
TEST=NONE
Review URL: http://codereview.chromium.org/3315011
------------------------------------------------------------------------
r58510 | hclam@chromium.org | 2010-09-03 20:24:59 +0200 (Fri, 03 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/service/service_process_control_browsertest.cc

Enable ServiceProcessControlTest.LaunchTwice

Quit the message loop by posting a quit task instead of calling quit directly.

BUG=
TEST=

Review URL: http://codereview.chromium.org/3342012
------------------------------------------------------------------------
r58509 | mirandac@chromium.org | 2010-09-03 20:20:09 +0200 (Fri, 03 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h

Ensure that search engine dialog appears on top when it appears.

BUG=54417
TEST= install chrome.  during install, click on another app. search engine dialog should appear on top.
Review URL: http://codereview.chromium.org/3350008
------------------------------------------------------------------------
r58504 | thakis@chromium.org | 2010-09-03 19:56:03 +0200 (Fri, 03 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Make resizing the window larger nicer when compositor is active

We need to fill the part of the RWHVMac not covered by the compositor subview with white.

Resizing smaller is still a bit jumpy. We also still paint an uninitialized IOSurface every now and then.

BUG=53165
TEST=Enable compositor, make window larger. Right bottom part of window shouldn't be transparent.

Review URL: http://codereview.chromium.org/3319004
------------------------------------------------------------------------
r58502 | stoyan@chromium.org | 2010-09-03 19:45:00 +0200 (Fri, 03 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

Revert 58493 - Call InitEventRouters after a successful chromeos login. This successfully
solves a problem where extension event listeners were never getting called
on Chrome OS because InitEventRouters wasn't getting called from
browser_main.cc if the profile was in the temporary OTR state while the
login was in progress.

Does this need a check to make sure it doesn't happen twice?

BUG=51724
TEST=Log in, test simple extension that notifies when a tab is created.

Review URL: http://codereview.chromium.org/3177006

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/3306008
------------------------------------------------------------------------
r58499 | dmazzoni@chromium.org | 2010-09-03 18:50:28 +0200 (Fri, 03 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.h

Revert 58491 - Implement ISimpleDOM COM interface in BrowserAccessibility. Also update
a few IAccessible2 functions with some of the new attributes that are
available now.

BUG=48185
TEST=None

Review URL: http://codereview.chromium.org/3219009

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/3324006
------------------------------------------------------------------------
r58498 | dpolukhin@chromium.org | 2010-09-03 18:44:20 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc

Fix crash in HungRendererDialogGtk when contents_ == NULL.

BUG=chromium-os:6004
TEST=none

Review URL: http://codereview.chromium.org/3325010
------------------------------------------------------------------------
r58494 | mmenke@chromium.org | 2010-09-03 18:06:38 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc

Fixes minor bug that prevented version information from appearing in net-internals log dumps.  Broke in 57725.

BUG=54302
TEST=manual

Review URL: http://codereview.chromium.org/3325007
------------------------------------------------------------------------
r58493 | dmazzoni@chromium.org | 2010-09-03 18:01:52 +0200 (Fri, 03 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

Call InitEventRouters after a successful chromeos login. This successfully
solves a problem where extension event listeners were never getting called
on Chrome OS because InitEventRouters wasn't getting called from
browser_main.cc if the profile was in the temporary OTR state while the
login was in progress.

Does this need a check to make sure it doesn't happen twice?

BUG=51724
TEST=Log in, test simple extension that notifies when a tab is created.

Review URL: http://codereview.chromium.org/3177006
------------------------------------------------------------------------
r58492 | finnur@chromium.org | 2010-09-03 18:00:00 +0200 (Fri, 03 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc

Augment the fix for HungRenderDialogView::ButtonPressed.

We need to check GetRenderProcessHost() (also fixed the typo in the if statement).

BUG=http://crbug.com/52293
TEST=None

Review URL: http://codereview.chromium.org/3348009
------------------------------------------------------------------------
r58491 | dmazzoni@chromium.org | 2010-09-03 17:57:43 +0200 (Fri, 03 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.h

Implement ISimpleDOM COM interface in BrowserAccessibility. Also update
a few IAccessible2 functions with some of the new attributes that are
available now.

BUG=48185
TEST=None

Review URL: http://codereview.chromium.org/3219009
------------------------------------------------------------------------
r58482 | jorlow@chromium.org | 2010-09-03 14:15:15 +0200 (Fri, 03 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbcursor_impl.cc

Fix various issues with DOMStorage that only showed up in multi-process mode.

We need to beef up our automated test coverage before we come out from behind a flag,
but in the mean time, let's fix these known issues.

TEST=All the layout tests work in multi-process mode.
BUG=none

Review URL: http://codereview.chromium.org/3294002
------------------------------------------------------------------------
r58476 | mnissler@chromium.org | 2010-09-03 13:22:26 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/file_path_watcher_unittest.cc

Remove flaky mark for FilePathWatcherTest, the rewrite resolved it.

BUG=38188
TEST=FilePathWatcherTest.* is robust on Mac

Review URL: http://codereview.chromium.org/3322003
------------------------------------------------------------------------
r58475 | altimofeev@chromium.org | 2010-09-03 12:04:14 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Disables bookmarks bar for new page in BWSI mode.

BUG=chromioum-os:6028
TEST=Enter to the BWSI session, open new tab. Notice that no bookmarks bar is presented.

Review URL: http://codereview.chromium.org/3353009
------------------------------------------------------------------------
r58471 | mnissler@chromium.org | 2010-09-03 11:38:39 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/prefs/pref_value_store.cc
   M /trunk/src/chrome/common/json_pref_store.cc
   M /trunk/src/chrome/common/pref_store.h

Gracefully handle the case of empty preference file names in PrefValueStore.

BUG=53917
TEST=Instead of crashing, chrome should display a message if it cannot determine the local state file.

Review URL: http://codereview.chromium.org/3322005
------------------------------------------------------------------------
r58467 | hans@chromium.org | 2010-09-03 11:17:12 +0200 (Fri, 03 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc

SSLConfigServiceManagerPref: small fix to work around Clang problem.

SSLConfigServiceManagerPref is a friend of SSLConfigServicePref,
which inherits from net::SSLConfigService. So technically, it should have
access to the protected static member net::SSLConfigService::SetSSLConfigFlags,
but Clang does not currently support this.

As a work-around, make the call through SSLConfigServicePref instead.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3298007
------------------------------------------------------------------------
r58466 | kochi@chromium.org | 2010-09-03 11:14:36 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Fix a bug that the default input method of added language is not checked.

BUG=chromium-os:6413
TEST=manually add a language and check if the first im is checked.

Review URL: http://codereview.chromium.org/3310010
------------------------------------------------------------------------
r58464 | mbelshe@chromium.org | 2010-09-03 11:08:10 +0200 (Fri, 03 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/predictor_api.h
   M /trunk/src/chrome/browser/net/url_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_request_info.h
   M /trunk/src/net/http/http_stream_request.cc
   M /trunk/src/net/http/http_stream_request.h

Update the Preconnect logic to use the new HttpStreamFactory for
creating connections rather than doing it manually.

With this update, I believe we no longer need to avoid preconnects
through proxies.  The new logic can handle that case.

Also updated the predictor_api slightly for the next wave of work.

BUG=none
TEST=existing

Review URL: http://codereview.chromium.org/3226011
------------------------------------------------------------------------
r58463 | kkanetkar@chromium.org | 2010-09-03 08:03:18 +0200 (Fri, 03 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_backend.cc
   M /trunk/src/chrome/browser/file_system/file_system_backend.h
   A /trunk/src/chrome/browser/file_system/file_system_backend_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Unit tests for file_system_backend.cc 

BUG=32277

Review URL: http://codereview.chromium.org/3239011
------------------------------------------------------------------------
r58461 | rohitrao@chromium.org | 2010-09-03 06:12:25 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_text_field.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.h
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm

[Mac] Fix findbar drag and drop.  Make the FindBarView eat drags, so they don't pass through to the views below.  Make the FindBarTextField focus itself in draggingEntered:, allowing us to drag text to the editor.

BUG=41417
TEST=Should be able to drag text and urls to the find bar.
TEST=Should not be able to drop urls in the margin between the find bar's text field and the web.
Review URL: http://codereview.chromium.org/3242007
------------------------------------------------------------------------
r58460 | sky@chromium.org | 2010-09-03 05:54:06 +0200 (Fri, 03 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Lands http://codereview.chromium.org/3309007/show for jeanluc:

Add a created_by_policy field to TemplateURL. Added unit tests. 

BUG=49306
TEST=WebDatabaseTest.Keywords*
Review URL: http://codereview.chromium.org/3323006
------------------------------------------------------------------------
r58459 | kochi@chromium.org | 2010-09-03 05:52:32 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Sort preload engines on checkbox change as well.

BUG=6326
TEST=manually test on ChromeOS device

Review URL: http://codereview.chromium.org/3333009
------------------------------------------------------------------------
r58456 | tfarina@chromium.org | 2010-09-03 04:42:58 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/base/registry.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc

Remove the default argument from RegKey::ReadValue.

BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*

Review URL: http://codereview.chromium.org/3259005
------------------------------------------------------------------------
r58455 | suzhe@chromium.org | 2010-09-03 04:30:28 +0200 (Fri, 03 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

[CrOS] Fix reserved accelerators' behavior.

This CL fixes BrowserView::PreHandleKeyboardEvent() to make sure
reserved accelerators have the same behavior of normal ones handled by
views::FocusManager::OnKeyEvent() method.

BUG=54213
TEST=See bug report.

Review URL: http://codereview.chromium.org/3353008
------------------------------------------------------------------------
r58454 | dumi@chromium.org | 2010-09-03 04:28:37 +0200 (Fri, 03 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_proxy.cc
   M /trunk/src/base/file_util_proxy.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/platform_file.h
   M /trunk/src/base/time.h
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/browser/file_path_watcher_mac.cc
   M /trunk/src/chrome/browser/file_path_watcher_win.cc
   M /trunk/src/chrome/browser/file_system/file_system_backend.cc
   M /trunk/src/chrome/browser/file_system/file_system_backend.h
   M /trunk/src/chrome/browser/file_system/file_system_backend_client.h
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/password_manager/password_store_x_unittest.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/base/upload_data_stream_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/webkit/blob/blob_url_request_job.cc
   M /trunk/src/webkit/blob/blob_url_request_job.h
   M /trunk/src/webkit/blob/blob_url_request_job_unittest.cc
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_posix.cc
   M /trunk/src/webkit/glue/webfileutilities_impl.cc

Moving file_util::FileInfo to base::PlatformFileInfo, and adding the
last_accessed and creation_time fields.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/3347005
------------------------------------------------------------------------
r58453 | kinuko@chromium.org | 2010-09-03 03:56:04 +0200 (Fri, 03 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Add command-line switch to enable FileSystem API support.

This doesn't set the flag for workers.

BUG=32277
TEST=none; to be added when we have complete implementation.

Review URL: http://codereview.chromium.org/3240006
------------------------------------------------------------------------
r58452 | tfarina@chromium.org | 2010-09-03 03:44:33 +0200 (Fri, 03 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc

importer: Use BookmarkModel::HasBookmarks instead of BookmarkModel::GetBookmarks.

Reason: The importer only needs to know wheter any bookmarks exist or not,
instead of needing to go through all bookmarks to know that.

BUG=45551
TEST=trybots

Review URL: http://codereview.chromium.org/3227001
------------------------------------------------------------------------
r58451 | aa@chromium.org | 2010-09-03 03:20:00 +0200 (Fri, 03 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/resources/ntp/most_visited.css
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js

Instead of trying to arrange things so that there is something covering all the parts of the scrollable area we don't want to see, use -webkit-image-mask to only show the parts we do want to see.

This change also fixes overflow of miniview items. Under some circumstances, the old JS approach wasn't working. Used a CSS one instead.

TEST=Set up most visisted so that it has items. Start it in
expanded mode. Minimize it. There should be no clipped last
item.

Review URL: http://codereview.chromium.org/3363001
------------------------------------------------------------------------
r58448 | satish@chromium.org | 2010-09-03 03:06:19 +0200 (Fri, 03 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/enable_speech_input_switch_browsertest.cc
   M /trunk/src/chrome/renderer/render_thread.cc

This feature was already enabled on windows and mac last week (http://codereview.chromium.org/3261001), and since it now works on linux as well I'm including that.

This is just for the dev channel and soon after will be removed for the beta and stable builds.

BUG=53598
TEST=browser_tests --gtest_filter="SpeechInputBrowserTest.*"

Review URL: http://codereview.chromium.org/3315007
------------------------------------------------------------------------
r58445 | levin@chromium.org | 2010-09-03 02:53:31 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.cc
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.h
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc

Fix TemplateURLModel::GenerateSearchURL for use on non-UI threads.

BUG=38475
TEST=unit_tests --gtest_filter=Temp*:Sea*:Key*

Review URL: http://codereview.chromium.org/3343002
------------------------------------------------------------------------
r58443 | stevenjb@chromium.org | 2010-09-03 02:49:34 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc

Issue 6248: popup windows have tiny url text

BUG=chromium-os:6248
TEST=Open a popup window. URL should be readable (10 point font instead of 7).

Review URL: http://codereview.chromium.org/3338005
------------------------------------------------------------------------
r58442 | joi@chromium.org | 2010-09-03 02:49:04 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_from_infobar
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_from_infobar/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_from_infobar/in-infobar.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_from_infobar/in-popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_from_infobar/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main/background_page.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/background_page.html:58249)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main/dom_ui.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui.html:58249)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main/dom_ui_popup.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup.html:58249)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main/dom_ui_popup_a.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_a.html:58249)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main/dom_ui_popup_b.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_b.html:58249)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main/dom_ui_popup_dismissal.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_dismissal.html:58249)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup_main/dom_ui_popup_sizing.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_sizing.html:58249)

Allow experimental extension pop-ups from infobars.

BUG=none
TEST=browser_tests.exe --gtest_filter=*PopupFromInfobar*

Review URL: http://codereview.chromium.org/3127037
------------------------------------------------------------------------
r58438 | bryeung@chromium.org | 2010-09-03 02:38:27 +0200 (Fri, 03 Sep 2010) | 17 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/event_synthesis_gtk.cc (from /trunk/src/base/event_synthesis_gtk.cc:58437)
   A /trunk/src/app/event_synthesis_gtk.h (from /trunk/src/base/event_synthesis_gtk.h:58437)
   A /trunk/src/app/keyboard_code_conversion.cc (from /trunk/src/base/keyboard_code_conversion.cc:58437)
   A /trunk/src/app/keyboard_code_conversion.h (from /trunk/src/base/keyboard_code_conversion.h:58437)
   A /trunk/src/app/keyboard_code_conversion_gtk.cc (from /trunk/src/base/keyboard_code_conversion_gtk.cc:58437)
   A /trunk/src/app/keyboard_code_conversion_gtk.h (from /trunk/src/base/keyboard_code_conversion_gtk.h:58437)
   A /trunk/src/app/keyboard_code_conversion_mac.h (from /trunk/src/base/keyboard_code_conversion_mac.h:58437)
   A /trunk/src/app/keyboard_code_conversion_mac.mm (from /trunk/src/base/keyboard_code_conversion_mac.mm:58437)
   A /trunk/src/app/keyboard_code_conversion_unittest.cc
   A /trunk/src/app/keyboard_code_conversion_win.cc
   A /trunk/src/app/keyboard_code_conversion_win.h
   A /trunk/src/app/keyboard_codes.h (from /trunk/src/base/keyboard_codes.h:58437)
   A /trunk/src/app/keyboard_codes_posix.h (from /trunk/src/base/keyboard_codes_posix.h:58437)
   A /trunk/src/app/keyboard_codes_win.h (from /trunk/src/base/keyboard_codes_win.h:58437)
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/app/menus/accelerator_cocoa.h
   M /trunk/src/app/menus/accelerator_gtk.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   D /trunk/src/base/event_synthesis_gtk.cc
   D /trunk/src/base/event_synthesis_gtk.h
   D /trunk/src/base/keyboard_code_conversion.cc
   D /trunk/src/base/keyboard_code_conversion.h
   D /trunk/src/base/keyboard_code_conversion_gtk.cc
   D /trunk/src/base/keyboard_code_conversion_gtk.h
   D /trunk/src/base/keyboard_code_conversion_mac.h
   D /trunk/src/base/keyboard_code_conversion_mac.mm
   D /trunk/src/base/keyboard_code_conversion_unittest.cc
   D /trunk/src/base/keyboard_codes.h
   D /trunk/src/base/keyboard_codes_posix.h
   D /trunk/src/base/keyboard_codes_win.h
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/password_changed_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_input_api.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view_browsertest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/webdriver/keymap.cc
   M /trunk/src/chrome/test/webdriver/keymap.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/host/event_executor_win.cc
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_gtk.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/native_table_win.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/examples/table2_example.h
   M /trunk/src/views/examples/table_example.h
   M /trunk/src/views/focus/accelerator_handler_gtk_unittest.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/support/DEPS
   M /trunk/src/webkit/support/webkit_support.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc

Re-lands 58186:

Original message:
"""
Move the keyboard files from base/ to app/.

Also moves the associated classes/enums from base:: to app::.

TEST=try bots compile
BUG=NONE

Review URL: http://codereview.chromium.org/3165064
"""

TBR=phajdan.jr@chromium.org

Review URL: http://codereview.chromium.org/3354005
------------------------------------------------------------------------
r58436 | andybons@chromium.org | 2010-09-03 02:16:11 +0200 (Fri, 03 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

[Mac] Fix a bug where the moving a tab via an extension was failing.
This was due to a lack of re-layout within the function that the TabModelObserverBridge calls within the TabStripController class, violating its contract.

BUG=40371
TEST=see bug for an example extension that tests this.

Review URL: http://codereview.chromium.org/3312006
------------------------------------------------------------------------
r58431 | thestig@chromium.org | 2010-09-03 01:53:26 +0200 (Fri, 03 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.h
   M /trunk/src/chrome/browser/crash_handler_host_linux_stub.cc

Linux: Handle renderer and plugin crashes on a separate thread. (try 2)

Also set retries / timeouts for wget to attempt to limit the duration of each crash handler.
Move some code out of headers while we're at it.

BUG=54071
TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work.
Original Review URL: http://codereview.chromium.org/3308007
Review URL: http://codereview.chromium.org/3333012
------------------------------------------------------------------------
r58430 | phajdan.jr@chromium.org | 2010-09-03 01:51:45 +0200 (Fri, 03 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h

GTTF: Move pyauto automation provider code to TestingAutomationProvider

BUG=52097
TEST=pyauto tests
Review URL: http://codereview.chromium.org/3290008
------------------------------------------------------------------------
r58426 | shess@chromium.org | 2010-09-03 01:30:43 +0200 (Fri, 03 Sep 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc

Final fixes for new safe-browsing storage.

In safe_browsing_database.cc, when inserting subs which have no
prefixes, calculate the add-chunk based on the entry's chunk, not the
sub chunk being processed.  This matches the old code.

Revise safe_browsing_store* to trim deleted chunks as part of
processing rather than as part of reading.  This means that more
data will be in memory, but it follows the old code, which
allowed subs to cancel adds before the add's chunk was deleted.
Without this, those subs will stay around until the sub chunk is
deleted (because their adds are not seen).

In safe_browsing_store_sqlite.cc, the previous code attempted to trick
SQLite into writing data efficiently by locking down the old tables
while writing the new ones.  Due to our use of SQLITE_SECURE_DELETE,
this actually resulted in bigger files and more overall I/O.  Modify
things to simply delete the data, instead.

BUG=28647
TEST=none

Review URL: http://codereview.chromium.org/3244012
------------------------------------------------------------------------
r58424 | georgey@chromium.org | 2010-09-03 01:17:17 +0200 (Fri, 03 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h

Allow uploading of the form data to toolbar autofill servers.
BUG=52501
TEST=In the bug. The code now invoked is already unit-tested.
Review URL: http://codereview.chromium.org/3218008
------------------------------------------------------------------------
r58422 | mpcomplete@chromium.org | 2010-09-03 01:15:28 +0200 (Fri, 03 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Reenable IncognitoSplitMode with a hopeful fix.

I believe what was happening was this:
- I had 2 ResultCatchers, one per profile.
- I would call GetNextResult on profile A, which would spin up a nested
message loop.
- We would get a response for profile B, which would quit the nested message
loop.
- ResultCatcher A is confused because he has no results - B got them.

BUG=53991
TEST=no

Review URL: http://codereview.chromium.org/3340004
------------------------------------------------------------------------
r58419 | mpcomplete@chromium.org | 2010-09-03 00:57:39 +0200 (Fri, 03 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/common/extensions/docs/examples/api/override/blank_ntp/manifest.json
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/static/override.html

Fix some issues with incognito split mode extensions.
- No longer create the background host if an extension has not been enabled
for incognito.
- Always open the options page in a normal window. Incognito options pages
aren't able to save state.
- Overrides (like NTP) now apply to incognito windows if the extension is
split mode.

BUG=54173
BUG=45879
TEST=Install chrome/common/extensions//docs/examples/api/override/blank_ntp. Allow it to run in incognito, and open an incognito window. The new tab page should say "Blank New Tab".

Review URL: http://codereview.chromium.org/3360002
------------------------------------------------------------------------
r58417 | phajdan.jr@chromium.org | 2010-09-03 00:52:35 +0200 (Fri, 03 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tabpose_window_unittest.mm

GTTF: Disable crashy TabposeWindowTest.TestShow

TBR=thakis

BUG=54323
TEST=unit_tests

Review URL: http://codereview.chromium.org/3357007
------------------------------------------------------------------------
r58414 | thakis@chromium.org | 2010-09-03 00:24:30 +0200 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/base_view.h
   M /trunk/src/chrome/browser/cocoa/base_view.mm
   M /trunk/src/chrome/browser/cocoa/base_view_unittest.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Make two function names less confusing. No functionality change.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3327009
------------------------------------------------------------------------
r58407 | nsylvain@chromium.org | 2010-09-02 23:42:55 +0200 (Thu, 02 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.h

Revert 58403 - Linux: Handle renderer and plugin crashes on a separate thread.

This change broke the linux compile

Also set retries / timeouts for wget to attempt to limit the duration of each crash handler. Move some code out of headers while we're at it.

BUG=54071
TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work.
Review URL: http://codereview.chromium.org/3308007

TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/3358010
------------------------------------------------------------------------
r58403 | thestig@chromium.org | 2010-09-02 23:28:50 +0200 (Thu, 02 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.h

Linux: Handle renderer and plugin crashes on a separate thread.

Also set retries / timeouts for wget to attempt to limit the duration of each crash handler. Move some code out of headers while we're at it.

BUG=54071
TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work.
Review URL: http://codereview.chromium.org/3308007
------------------------------------------------------------------------
r58398 | willchan@chromium.org | 2010-09-02 22:45:55 +0200 (Thu, 02 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/net_log_event_type_list.h

Spelling error: s/ADDRESSSES/ADDRESSES/g.

Review URL: http://codereview.chromium.org/3330006
------------------------------------------------------------------------
r58396 | stuartmorgan@chromium.org | 2010-09-02 22:40:52 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css

DOMUI prefs: Fix RTL regression from managed pref banner changes

BUG=None
TEST=Launch DOMUI prefs in RTL. Prefs shouldn't be under the sidebar.

Review URL: http://codereview.chromium.org/3326005
------------------------------------------------------------------------
r58393 | stuartmorgan@chromium.org | 2010-09-02 22:36:36 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options_page.css
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.css

Fix display when search engine names are very long

BUG=54101
TEST=Make a search engine name very long, and open DOMUI prefs. The <select> on the main page should not be wider than other controls, and text in the search engine manager table shouldn't overlap.

Review URL: http://codereview.chromium.org/3349007
------------------------------------------------------------------------
r58391 | mirandac@chromium.org | 2010-09-02 21:57:30 +0200 (Thu, 02 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run.cc

Fix search engine import.

If the user has installed and then uninstalled Chrome, but not deleted their user data directory, a subsequent install will silently import default search engines, thus possibly giving the user a fresh install of Chrome with default search engine not Google.

Fix: if the user has already set up a user data directory, don't import search engines.

BUG=none
TEST=import works for all the usual paths.  also, specifically: install and then uninstall Chrome without deleting user data directory.  set search engine in default browser to something other than Google. install Chrome again.  search engines should not be imported, but should be whatever the user had been previously using in Chrome.

Review URL: http://codereview.chromium.org/3315009
------------------------------------------------------------------------
r58390 | akalin@chromium.org | 2010-09-02 21:54:58 +0200 (Thu, 02 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/event_synthesis_gtk.cc
   D /trunk/src/app/event_synthesis_gtk.h
   D /trunk/src/app/keyboard_code_conversion.cc
   D /trunk/src/app/keyboard_code_conversion.h
   D /trunk/src/app/keyboard_code_conversion_gtk.cc
   D /trunk/src/app/keyboard_code_conversion_gtk.h
   D /trunk/src/app/keyboard_code_conversion_mac.h
   D /trunk/src/app/keyboard_code_conversion_mac.mm
   D /trunk/src/app/keyboard_code_conversion_unittest.cc
   D /trunk/src/app/keyboard_code_conversion_win.cc
   D /trunk/src/app/keyboard_code_conversion_win.h
   D /trunk/src/app/keyboard_codes.h
   D /trunk/src/app/keyboard_codes_posix.h
   D /trunk/src/app/keyboard_codes_win.h
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/app/menus/accelerator_cocoa.h
   M /trunk/src/app/menus/accelerator_gtk.h
   M /trunk/src/base/base.gyp
   A /trunk/src/base/event_synthesis_gtk.cc (from /trunk/src/base/event_synthesis_gtk.cc:58387)
   A /trunk/src/base/event_synthesis_gtk.h (from /trunk/src/base/event_synthesis_gtk.h:58387)
   A /trunk/src/base/keyboard_code_conversion.cc (from /trunk/src/base/keyboard_code_conversion.cc:58387)
   A /trunk/src/base/keyboard_code_conversion.h (from /trunk/src/base/keyboard_code_conversion.h:58387)
   A /trunk/src/base/keyboard_code_conversion_gtk.cc (from /trunk/src/base/keyboard_code_conversion_gtk.cc:58387)
   A /trunk/src/base/keyboard_code_conversion_gtk.h (from /trunk/src/base/keyboard_code_conversion_gtk.h:58387)
   A /trunk/src/base/keyboard_code_conversion_mac.h (from /trunk/src/base/keyboard_code_conversion_mac.h:58387)
   A /trunk/src/base/keyboard_code_conversion_mac.mm (from /trunk/src/base/keyboard_code_conversion_mac.mm:58387)
   A /trunk/src/base/keyboard_code_conversion_unittest.cc (from /trunk/src/base/keyboard_code_conversion_unittest.cc:58387)
   A /trunk/src/base/keyboard_codes.h (from /trunk/src/base/keyboard_codes.h:58387)
   A /trunk/src/base/keyboard_codes_posix.h (from /trunk/src/base/keyboard_codes_posix.h:58387)
   A /trunk/src/base/keyboard_codes_win.h (from /trunk/src/base/keyboard_codes_win.h:58387)
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/password_changed_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_input_api.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view_browsertest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/webdriver/keymap.cc
   M /trunk/src/chrome/test/webdriver/keymap.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/host/event_executor_win.cc
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_gtk.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/native_table_win.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/examples/table2_example.h
   M /trunk/src/views/examples/table_example.h
   M /trunk/src/views/focus/accelerator_handler_gtk_unittest.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/support/DEPS
   M /trunk/src/webkit/support/webkit_support.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc

Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.

Also moves the associated classes/enums from base:: to app::.

TEST=try bots compile
BUG=NONE

Review URL: http://codereview.chromium.org/3165064

TBR=bryeung@chromium.org

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003

TBR=bryeung@chromium.org
Review URL: http://codereview.chromium.org/3337006
------------------------------------------------------------------------
r58388 | bryeung@chromium.org | 2010-09-02 21:22:15 +0200 (Thu, 02 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/event_synthesis_gtk.cc (from /trunk/src/app/event_synthesis_gtk.cc:58214)
   A /trunk/src/app/event_synthesis_gtk.h (from /trunk/src/app/event_synthesis_gtk.h:58214)
   A /trunk/src/app/keyboard_code_conversion.cc (from /trunk/src/app/keyboard_code_conversion.cc:58214)
   A /trunk/src/app/keyboard_code_conversion.h (from /trunk/src/app/keyboard_code_conversion.h:58214)
   A /trunk/src/app/keyboard_code_conversion_gtk.cc (from /trunk/src/app/keyboard_code_conversion_gtk.cc:58214)
   A /trunk/src/app/keyboard_code_conversion_gtk.h (from /trunk/src/app/keyboard_code_conversion_gtk.h:58214)
   A /trunk/src/app/keyboard_code_conversion_mac.h (from /trunk/src/app/keyboard_code_conversion_mac.h:58214)
   A /trunk/src/app/keyboard_code_conversion_mac.mm (from /trunk/src/app/keyboard_code_conversion_mac.mm:58214)
   A /trunk/src/app/keyboard_code_conversion_unittest.cc (from /trunk/src/app/keyboard_code_conversion_unittest.cc:58214)
   A /trunk/src/app/keyboard_code_conversion_win.cc (from /trunk/src/app/keyboard_code_conversion_win.cc:58214)
   A /trunk/src/app/keyboard_code_conversion_win.h (from /trunk/src/app/keyboard_code_conversion_win.h:58214)
   A /trunk/src/app/keyboard_codes.h (from /trunk/src/app/keyboard_codes.h:58214)
   A /trunk/src/app/keyboard_codes_posix.h (from /trunk/src/app/keyboard_codes_posix.h:58214)
   A /trunk/src/app/keyboard_codes_win.h (from /trunk/src/app/keyboard_codes_win.h:58214)
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/app/menus/accelerator_cocoa.h
   M /trunk/src/app/menus/accelerator_gtk.h
   M /trunk/src/base/base.gyp
   D /trunk/src/base/event_synthesis_gtk.cc
   D /trunk/src/base/event_synthesis_gtk.h
   D /trunk/src/base/keyboard_code_conversion.cc
   D /trunk/src/base/keyboard_code_conversion.h
   D /trunk/src/base/keyboard_code_conversion_gtk.cc
   D /trunk/src/base/keyboard_code_conversion_gtk.h
   D /trunk/src/base/keyboard_code_conversion_mac.h
   D /trunk/src/base/keyboard_code_conversion_mac.mm
   D /trunk/src/base/keyboard_code_conversion_unittest.cc
   D /trunk/src/base/keyboard_codes.h
   D /trunk/src/base/keyboard_codes_posix.h
   D /trunk/src/base/keyboard_codes_win.h
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/password_changed_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_input_api.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view_browsertest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/webdriver/keymap.cc
   M /trunk/src/chrome/test/webdriver/keymap.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/host/event_executor_win.cc
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_gtk.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/native_table_win.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/examples/table2_example.h
   M /trunk/src/views/examples/table_example.h
   M /trunk/src/views/focus/accelerator_handler_gtk_unittest.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/support/DEPS
   M /trunk/src/webkit/support/webkit_support.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc

Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.

Also moves the associated classes/enums from base:: to app::.

TEST=try bots compile
BUG=NONE

Review URL: http://codereview.chromium.org/3165064

TBR=bryeung@chromium.org

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003
------------------------------------------------------------------------
r58384 | thakis@chromium.org | 2010-09-02 20:37:32 +0200 (Thu, 02 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm

Mac: Let three-finger-down end tabpose as well.

Requested by stevegerak, and matches the four-finger-swipe exposé gesture.

BUG=50307
TEST=both three-finger-up and three-finger-down exit tabpose

Review URL: http://codereview.chromium.org/3342005
------------------------------------------------------------------------
r58382 | erg@google.com | 2010-09-02 20:35:06 +0200 (Thu, 02 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extension_proxy_apitest.cc
   M /trunk/src/chrome/browser/jumplist_win.h
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   A /trunk/src/chrome/browser/sessions/tab_restore_service_observer.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

FBTF: Reaplly the TabRestoreService::Observer into its own file commit.

This means browser.h no longer includes a large chunk of the tab restore
system. Now with fixes to chromeos.

BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3296003

Review URL: http://codereview.chromium.org/3358005
------------------------------------------------------------------------
r58379 | thakis@chromium.org | 2010-09-02 20:22:41 +0200 (Thu, 02 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Mac: Try to fix a valgrind problem in TabposeWindow.

Clear the model observer when the exit animation starts. Else, it is cleared when the animation ends, which calls RemoveObserver on the TabStrip, but in the unit test the TabStrip is gone when that call happens.

BUG=53893
TEST=valgrind turns green

Review URL: http://codereview.chromium.org/3220004
------------------------------------------------------------------------
r58378 | phajdan.jr@chromium.org | 2010-09-02 20:06:14 +0200 (Thu, 02 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.h

Make sure DownloadManager is shut down on the UI thread.

This fixes a pref-related crash.

TBR=darin

BUG=54128
TEST=memory_test and others; download a file and close the browser while it's downloading; should be no DCHECKs/segfaults

Review URL: http://codereview.chromium.org/3356005
------------------------------------------------------------------------
r58374 | phajdan.jr@chromium.org | 2010-09-02 19:25:09 +0200 (Thu, 02 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

Fix a race condition after my latest download cleanup change.

We need to pause the download request until the on-disk file
is actually created. Otherwise all data received from network would
be discarded.

BUG=54131
TEST=see bug

Review URL: http://codereview.chromium.org/3333007
------------------------------------------------------------------------
r58373 | dtseng@chromium.org | 2010-09-02 19:19:46 +0200 (Thu, 02 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api_gtk.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api_mac.mm
   A /trunk/src/chrome/browser/extensions/extension_tts_api_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Relanding 3149027.
TBR=dmazzoni,chaitanyag
BUG=none.
TEST=none.
------------------------------------------------------------------------
r58370 | dhg@chromium.org | 2010-09-02 18:37:19 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/cros_settings_provider_proxy.cc
   A /trunk/src/chrome/browser/chromeos/cros_settings_provider_proxy.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/proxy_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/proxy_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_proxy.html
   A /trunk/src/chrome/browser/resources/options/chromeos_proxy_options.js
   A /trunk/src/chrome/browser/resources/options/chromeos_proxy_rules_list.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Change for proxy stuff.

BUG=3370
TEST=none

Review URL: http://codereview.chromium.org/3113021
------------------------------------------------------------------------
r58364 | allanwoj@chromium.org | 2010-09-02 18:13:14 +0200 (Thu, 02 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h

Fix geolocation icon behaviour on navigation
Now clears the allowed/not allowed geolocation statemap at the beginning of a navigation in a similar way for cookies as done in this CL http://codereview.chromium.org/3194005 Before the icon would hang around after navigation until a tab contents update occurred.

BUG=53339
TEST=Start up geolocation on a website then navigate away.

Review URL: http://codereview.chromium.org/3305004
------------------------------------------------------------------------
r58361 | rohitrao@chromium.org | 2010-09-02 18:05:42 +0200 (Thu, 02 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm

[Mac] Round the left side of the find bar.

BUG=49798
TEST=Findbar should be rounded left.
Review URL: http://codereview.chromium.org/3212007
------------------------------------------------------------------------
r58359 | hans@chromium.org | 2010-09-02 18:01:54 +0200 (Thu, 02 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/device_orientation/provider_unittest.cc

Fix DeviceOrientationProviderTest.ObserverNotRemoved.

The problem was that some extra reference to Provider was left after the
ObserverNotRemoved test had finished. This reference was held by the
RunnableMethod object that executes ProviderImpl::DoInitializePollingThread on
a background thread. In the test, there were no guarantees that the body of
this function would finish before the test ended, thus causing a problem.

Fixing this by pushing another orientation through, forcing the Provider to
execute at least one Poll task on the background thread, which can only happen
after the initialization of the polling thread is done.

BUG=53865
TEST=unit_tests --gtest_filter=DeviceOrientationProviderTest.ObserverNotRemoved

Review URL: http://codereview.chromium.org/3232005
------------------------------------------------------------------------
r58348 | dilmah@chromium.org | 2010-09-02 15:22:36 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

Style fixes for recent CL r58341

BUG=http://crosbug.org/5756
TEST=Manual

Review URL: http://codereview.chromium.org/3297005
------------------------------------------------------------------------
r58344 | altimofeev@chromium.org | 2010-09-02 14:16:41 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

Passes switch to BWSI session that enables tabbed options.

BUG=chromium-os:6065
TEST=Start BWSI session. Go to wrench and click on Preferences. Notice that the new tab opens.

Review URL: http://codereview.chromium.org/3315004
------------------------------------------------------------------------
r58341 | dilmah@chromium.org | 2010-09-02 13:39:40 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

Round corners for user pods.

BUG=http://crosbug.org/5756
TEST=Manual

Review URL: http://codereview.chromium.org/3326001
------------------------------------------------------------------------
r58339 | xiyuan@chromium.org | 2010-09-02 13:01:38 +0200 (Thu, 02 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.cc

Fix chromeos browser_tests crash by skipping EnsurePrivateKey if device is not owned.

BUG=none.
TEST=ChromeOS buildbot should be green.
TBR=cmasone@chromium.org
------------------------------------------------------------------------
r58331 | xiyuan@chromium.org | 2010-09-02 10:12:24 +0200 (Thu, 02 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc

Fix ChromeOS debug buildbot failure.

Triggering ownership check on key load failure creates an infinite loop when
owner key file is missing.

BUG=none
TEST=ChromeOS debug buildbot should be green.
TBR=cmasone@chromium.org
------------------------------------------------------------------------
r58330 | jochen@chromium.org | 2010-09-02 09:32:32 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.cc
   D /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.h
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api_constants.cc (from /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.cc:58329)
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_api_constants.h (from /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.h:58329)
   A /trunk/src/chrome/browser/extensions/extension_webrequest_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_webrequest_api_constants.h
   M /trunk/src/chrome/chrome_browser.gypi

Add api constants for webRequest and clean up webNavigation.

BUG=50943
TEST=none

Review URL: http://codereview.chromium.org/3315002
------------------------------------------------------------------------
r58327 | mazda@chromium.org | 2010-09-02 08:07:52 +0200 (Thu, 02 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_chewing_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_mozc_options.html
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options/pref_ui.js

Change PrefNumber to listen to the input event so that the value input
with a spin button is correctly applied to the preference.

TEST=manually on the netbook
BUG=chromium-os:6022, chromium-os:6154

Review URL: http://codereview.chromium.org/3122042
------------------------------------------------------------------------
r58326 | zork@chromium.org | 2010-09-02 08:07:35 +0200 (Thu, 02 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc

Replace all constant string language_prefs::kHardwareKeyboardName with
GetHardwareKeyboardLayoutName method in libcros.

Apply issue:3132023(http://codereview.chromium.org/3132023/show)
before this edit.

BUG=chromium-os:5579
TEST=None

Review URL: http://codereview.chromium.org/3142033
Patch from Hitoshi Yoshida <peria@google.com>.
------------------------------------------------------------------------
r58325 | xiyuan@chromium.org | 2010-09-02 08:06:26 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options_page.css
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js

Only enable users DOMUI if current user is owner.

BUG=chromium-os:968
TEST=In ChromeOS, users DOMUI should only be enabled for owner.

Review URL: http://codereview.chromium.org/3284008
------------------------------------------------------------------------
r58324 | ctguil@chromium.org | 2010-09-02 08:02:48 +0200 (Thu, 02 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Mark AccessibilityWinBrowserTest.ContainsRendererAccessibilityTree as Fails

TBR=dmazzoni

------------------------------------------------------------------------
r58317 | ukai@chromium.org | 2010-09-02 06:39:36 +0200 (Thu, 02 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc

Try to fix crash in WebSocketExperimentRunner::DoLoop

Crash in WebSocketExperimentRunner::DoLoop() by access violation write.
I guess WebSocketExperimentRunner is deleted before calling back DoLoop.
I suspect WebSocketExperimentRunner is deleted if some task was finished
with ERR_ABORTED other than Cancel.  ERR_ABORTED may happen when SocketStream
closed unexpectedly, so it would not be good to handle Cancel case.
Use next_state_ == STATE_NONE to check the task was cancelled.

BUG=53985
TEST=none

Review URL: http://codereview.chromium.org/3317001
------------------------------------------------------------------------
r58315 | tfarina@chromium.org | 2010-09-02 05:49:49 +0200 (Thu, 02 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/camera.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc

chromeos/login: Append base:: to StringPrintf calls.

(Note: This is a TODO in base/stringprintf.h).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3272007
------------------------------------------------------------------------
r58314 | ctguil@chromium.org | 2010-09-02 05:46:47 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/views/accessibility/view_accessibility.cc

Connect native view accessibles back to the accessibility tree.

BUG=none
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.ContainsRendererAccessibilityTree

Review URL: http://codereview.chromium.org/3244011
------------------------------------------------------------------------
r58312 | kkanetkar@chromium.org | 2010-09-02 05:43:36 +0200 (Thu, 02 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/base/file_util_proxy.cc
   M /trunk/src/base/file_util_proxy.h
   M /trunk/src/base/platform_file.h
   A /trunk/src/chrome/browser/file_system/file_system_backend.cc
   A /trunk/src/chrome/browser/file_system/file_system_backend.h
   A /trunk/src/chrome/browser/file_system/file_system_backend_client.h
   M /trunk/src/chrome/chrome_browser.gypi

Changes for browser-side implementation for file api.

BUG=32277

TEST=Separate CL for unit test.

Review URL: http://codereview.chromium.org/3212002
------------------------------------------------------------------------
r58308 | nsylvain@chromium.org | 2010-09-02 05:04:48 +0200 (Thu, 02 Sep 2010) | 30 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

Revert 58259 - reland r57885 with a fix for linux/views.

We believe this caused a lot of login prompt auth tests to fail with : 

[5860:5871:2463125642585:FATAL:chrome/browser/gtk/owned_widget_gtk.cc(39)] Check failed: ((((GObject*) g_type_check_instance_cast ((GTypeInstance*) ((widget)), (((GType) ((20) << (2))))))))->ref_count == 1U (3 vs. 1)
Backtrace:
	StackTrace::StackTrace() [0x8b2d896]
	logging::LogMessage::~LogMessage() [0x8b47321]
	OwnedWidgetGtk::Destroy() [0x81b2536]
	LoginHandlerGtk::~LoginHandlerGtk() [0x860a419]
	base::RefCountedThreadSafe<>::DeleteInternal() [0x82911a4]
	base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x82911b7]
	base::RefCountedThreadSafe<>::Release() [0x8291215]
	
------
Original message:

[GTK] a couple of constrained window fixes:

1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front.
2) handle escape via normal key handling rather than accelerator keys
3) don't allow the content view to take focus (via tab) when the constrained window is showing.

BUG=53242, 50799
TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected.

Review URL: http://codereview.chromium.org/3235010

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/3293005
------------------------------------------------------------------------
r58302 | wtc@chromium.org | 2010-09-02 04:07:44 +0200 (Thu, 02 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Do not say the connection is not encrypted if security_bits
is -1 (unknown).  Say nothing in that case.

If the description for the connection section is empty, omit
the connection section in the dialog.

R=finnur,jcivelli
BUG=53366,13049
TEST=Visit https://alioth.debian.org/.  Bring up the Security
info dialog while Chrome is displaying the SSL certificate
error page.  The security info dialog should not say "Your
connection to alioth.debian.org is not encrypted."
Review URL: http://codereview.chromium.org/3243008
------------------------------------------------------------------------
r58296 | zelidrag@chromium.org | 2010-09-02 03:44:27 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h

Fixed the default value for 'crash report' on EULA screen.

BUG=chromium-os:6364
TEST=make sure EULA screen has 'crash report' checkbox checked by default even after the machine is reimaged.

Review URL: http://codereview.chromium.org/3342004
------------------------------------------------------------------------
r58294 | thestig@chromium.org | 2010-09-02 03:40:19 +0200 (Thu, 02 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/PRESUBMIT.py
   M /trunk/src/chrome/browser/views/PRESUBMIT.py
   M /trunk/src/views/PRESUBMIT.py

Sending try jobs to linux_view is a strong signal that we should also send the try jobs to linux_chromeos, and vice versa.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3291005
------------------------------------------------------------------------
r58291 | hclam@chromium.org | 2010-09-02 03:19:51 +0200 (Thu, 02 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/service/service_process_control_browsertest.cc

Build fix for browser_tests

ServiceProcesControlTest.LaunchTwice is timing out. Disable the test for now.

TBR=tc@chromium.org

BUG=
TEST=

Review URL: http://codereview.chromium.org/3349005
------------------------------------------------------------------------
r58289 | phajdan.jr@chromium.org | 2010-09-02 03:02:46 +0200 (Thu, 02 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Revert "Don't create pending entries when a navigation is initiated by the page."

TBR=jcivelli

Review URL: http://codereview.chromium.org/3360003
------------------------------------------------------------------------
r58278 | ananta@chromium.org | 2010-09-02 02:11:21 +0200 (Thu, 02 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.cc

Fix a chrome browser crash which occurs when launched as part of chrome frame while processing
the ViewHostMsg_AccessibilityObjectChildrenChange message. The crash occurs because we fail to
find the BrowserAccessibility interface for the child id passed in. 

Fix is to NULL check the same.

Bug=54142

Review URL: http://codereview.chromium.org/3295005
------------------------------------------------------------------------
r58275 | cmasone@google.com | 2010-09-02 02:02:05 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc

[Chrome OS] more of the ownership api

BUG=chromium-os:4488
TEST=unit tests

Review URL: http://codereview.chromium.org/3278001
------------------------------------------------------------------------
r58272 | aa@chromium.org | 2010-09-02 02:01:39 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/themes/browser_theme_provider.cc
   M /trunk/src/chrome/browser/themes/browser_theme_provider.h

Make NTP look good with themes.

BUG=52913
TEST=Visual inspection.

Review URL: http://codereview.chromium.org/3340005
------------------------------------------------------------------------
r58271 | erg@google.com | 2010-09-02 01:44:22 +0200 (Thu, 02 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extension_proxy_apitest.cc
   M /trunk/src/chrome/browser/jumplist_win.h
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   D /trunk/src/chrome/browser/sessions/tab_restore_service_observer.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

Revert "FBTF: Move the TabRestoreService::Observer into its own file."

This reverts commit 4a76b908daffee441d9ebf9fbc74b4015d9145df (r58256) due to
chromeos compile fail.

TBR=akalin

Review URL: http://codereview.chromium.org/3340007
------------------------------------------------------------------------
r58269 | erg@google.com | 2010-09-02 01:22:02 +0200 (Thu, 02 Sep 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h

Revert midair build fix to header; using akalin's fix instead.
------------------------------------------------------------------------
r58268 | erg@google.com | 2010-09-02 01:18:21 +0200 (Thu, 02 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h

Fix chromeos build.

TBR=akalin
------------------------------------------------------------------------
r58267 | akalin@chromium.org | 2010-09-02 01:17:37 +0200 (Thu, 02 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc

Added needed include to fix chromeos build.

TBR=erg@chromium.org

Review URL: http://codereview.chromium.org/3304005
------------------------------------------------------------------------
r58265 | hclam@chromium.org | 2010-09-02 01:07:21 +0200 (Thu, 02 Sep 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/browser/service/service_process_control.h
   M /trunk/src/chrome/browser/service/service_process_control_browsertest.cc

Don't launch service process if it's already running

BUG=52891
TEST=browser_tests --gtest_filter=ServiceProcess*

Removed ServiceProcessControl::Connect() and just have a Launch() method.
The Launch() method will connect to the service process if the it has
already been launched but not connected. The method will
simply return if the process is already been launched connected.

Review URL: http://codereview.chromium.org/3306001
------------------------------------------------------------------------
r58264 | isherman@chromium.org | 2010-09-02 01:06:24 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

OS X: Clicking on search keyword autocomplete result should update the omnibox

BUG=54052
TEST=none

Review URL: http://codereview.chromium.org/3300004
------------------------------------------------------------------------
r58263 | isherman@chromium.org | 2010-09-02 01:03:29 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Handle ctrl press when arrowing to a search keyword

BUG=44591,18431
TEST=none

Review URL: http://codereview.chromium.org/3322001
------------------------------------------------------------------------
r58262 | georgey@chromium.org | 2010-09-02 01:01:58 +0200 (Thu, 02 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

fix for  [AutoFill credit cards] Editing last 4 digit card number is not saved.
BUG=49566
TEST=If there is any obfuscation, editing the field clears it.
Review URL: http://codereview.chromium.org/3265005
------------------------------------------------------------------------
r58261 | jcivelli@chromium.org | 2010-09-02 01:01:51 +0200 (Thu, 02 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Don't create pending entries when a navigation is initiated by the page.
If the page reloads while such a navigation happens, we could end up with the wrong pending entry.
Also make sure TestTabContents::NavigateAndCommit() does commit on the right RVH.

BUG=51680
TEST=See bug for steps.

Review URL: http://codereview.chromium.org/3257002
------------------------------------------------------------------------
r58260 | johnnyg@chromium.org | 2010-09-02 01:01:29 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc

Remove the border around the wrench icon on notification balloons (Windows).

BUG=52545
TEST=notifications on windows

Review URL: http://codereview.chromium.org/3311006
------------------------------------------------------------------------
r58259 | estade@chromium.org | 2010-09-02 00:58:53 +0200 (Thu, 02 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

reland r57885 with a fix for linux/views.

[GTK] a couple of constrained window fixes:

1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front.
2) handle escape via normal key handling rather than accelerator keys
3) don't allow the content view to take focus (via tab) when the constrained window is showing.

BUG=53242, 50799
TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected.

Review URL: http://codereview.chromium.org/3235010
------------------------------------------------------------------------
r58258 | estade@chromium.org | 2010-09-02 00:58:24 +0200 (Thu, 02 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   A /trunk/src/chrome/browser/importer/firefox_importer_utils_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Fix a couple of firefox search engine import bugs.

1) on ubuntu, firefox3 search engines are stored in a slightly different place. See bug 53899 for more info.
2) fix parse error in ReadPrefJsValue. Firefox pref values may contain parentheses, e.g. "Wikipedia (en)"

BUG=53899
TEST=create a new firefox profile and set it as the default profile, and set firefox3 as the default browser. Launch chrome with --user-data-dir=/tmp/foo. The default set of firefox search engines should be silently imported. (Also, after I write a patch to do so, the first run ballot box should show the default ffox search engine along side the 3 defaults, if it is not one of the three defaults).

Review URL: http://codereview.chromium.org/3221007
------------------------------------------------------------------------
r58257 | jcivelli@chromium.org | 2010-09-02 00:52:19 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc

Bandaid around a weird crasher were we end up with a NULL infobar.

BUG=53979
TEST=None (wish I knew how to repro...)

Review URL: http://codereview.chromium.org/3341004
------------------------------------------------------------------------
r58256 | erg@google.com | 2010-09-02 00:50:25 +0200 (Thu, 02 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extension_proxy_apitest.cc
   M /trunk/src/chrome/browser/jumplist_win.h
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   A /trunk/src/chrome/browser/sessions/tab_restore_service_observer.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

FBTF: Move the TabRestoreService::Observer into its own file.

This means browser.h no longer includes a large chunk of the tab restore
system.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3296003
------------------------------------------------------------------------
r58249 | mattm@chromium.org | 2010-09-02 00:23:03 +0200 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/page_info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

Gtk page info bubble.

BUG=52916
TEST=run chrome with --enable-new-page-info-bubble, click on page info

Review URL: http://codereview.chromium.org/3310002
------------------------------------------------------------------------
r58248 | pkasting@chromium.org | 2010-09-02 00:16:33 +0200 (Thu, 02 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc

Don't treat input with a scheme that's not "http" or "https" as a potential keyword search.

BUG=27038
TEST=Type in "site:yahoo.com foo".  You should not go into keyword search mode.
Review URL: http://codereview.chromium.org/3259010
------------------------------------------------------------------------
r58247 | dhollowa@chromium.org | 2010-09-02 00:05:24 +0200 (Thu, 02 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Migration unit tests to web database for missing images on the search ballot

Adds migration unit tests to web database for missing images on the search ballot.  This is follow-up from review http://codereview.chromium.org/3189004.

BUG=52452, 50699, 10913
TEST=WebDatabaseMigrationTest.MigrateVersion22ToCurrent, WebDatabaseMigrationTest.MigrateVersion22CorruptToCurrent, WebDatabaseMigrationTest.MigrateVersion24ToCurrent

Review URL: http://codereview.chromium.org/3295002
------------------------------------------------------------------------
r58246 | sanjeevr@chromium.org | 2010-09-01 23:54:07 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/service_process_util.cc
   M /trunk/src/chrome/common/service_process_util.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy.h
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/chrome/service/service_process.h

Registered the service process to AutoRun (for Windows) if any service (CloudPrint or Remoting) is enabled. When all services are disabled, we delete the AutoRun key. Also remembered the enabled state of the Cloud Print Proxy in the service prefs.

BUG=None
TEST=After enabling cloud print or chromoting on Windows, the service process should auto start on user login.

Review URL: http://codereview.chromium.org/3257011
------------------------------------------------------------------------
r58238 | mpcomplete@chromium.org | 2010-09-01 22:55:52 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Close all tabs for an extension when disabling it.

BUG=53585
TEST=Open multiple tabs to a chrome-extension URL, then disable that extension. Tabs should close. See bug for details.

Review URL: http://codereview.chromium.org/3274012
------------------------------------------------------------------------
r58237 | stuartmorgan@chromium.org | 2010-09-01 22:55:19 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.h
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.html
   A /trunk/src/chrome/browser/resources/options/edit_search_engine_overlay.css
   A /trunk/src/chrome/browser/resources/options/edit_search_engine_overlay.html
   A /trunk/src/chrome/browser/resources/options/edit_search_engine_overlay.js
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.html
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.js
   M /trunk/src/chrome/browser/resources/options.html

DOMUI prefs: Add search engine editor overlay.

BUG=52649
TEST=DOMUI prefs should allow editing and adding search engines.

Review URL: http://codereview.chromium.org/3257008
------------------------------------------------------------------------
r58234 | jhawkins@chromium.org | 2010-09-01 22:54:09 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.h
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.html
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.html
   M /trunk/src/chrome/browser/resources/options/autofill_options.js

DOMUI: Implement editing AutoFill addresses.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3273003
------------------------------------------------------------------------
r58233 | pkasting@chromium.org | 2010-09-01 22:48:11 +0200 (Wed, 01 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc

Make history provider ranking stable for "visited but untyped" intranet URLs.

BUG=6905
TEST=Start with a clean profile; open a test file with a link to an intranet site (e.g. "http://m/"); click the link; type "m" in the address bar and watch the dropdown to ensure the default match doesn't change as results come in.
Review URL: http://codereview.chromium.org/3284009
------------------------------------------------------------------------
r58232 | rafaelw@chromium.org | 2010-09-01 22:47:07 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

revert r49556 - Interpret typed url into an apps extent from the NTP omnibox as launch event

BUG=44911
TEST=

Review URL: http://codereview.chromium.org/3358001
------------------------------------------------------------------------
r58226 | xiyuan@chromium.org | 2010-09-01 22:07:06 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_network_element.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options_page.css

Don't show status text for "remembered" networks and "Connect" button for ethernet.

BUG=chromium-os:6159
TEST=Verify that "Disconnected" is not shown for remembered networks and "Connect" button is not shown for ethernet.

Review URL: http://codereview.chromium.org/3239013
------------------------------------------------------------------------
r58225 | phajdan.jr@chromium.org | 2010-09-01 21:57:25 +0200 (Wed, 01 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

GTTF: Disable all download tests, they are broken just so much.

They don't wait until the download finishes,
so a "do you want to close the browser, you have pending downloads?"
dialog appears, which makes buildbots leak a process and become hosed.

TBR=ahendrickson

BUG=35275, 48913, 50060
TEST=ui_tests

Review URL: http://codereview.chromium.org/3301006
------------------------------------------------------------------------
r58221 | satish@chromium.org | 2010-09-01 21:44:47 +0200 (Wed, 01 Sep 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   A /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm
   A /trunk/src/chrome/browser/speech/speech_input_bubble_views.cc (from /trunk/src/chrome/browser/speech/speech_input_bubble_win.cc:58219)
   D /trunk/src/chrome/browser/speech/speech_input_bubble_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement the speech input bubble on linux/gtk.

This is a popup which gets displayed below an <input> element when the user starts speech recognition on it. It displays a recognition status icon, an instruction label ('Speak now') at the top and a Cancel button at the bottom. The speech input module gets callbacks on user actions such as clicking Cancel or clicking any other window, and on both cases recognition stops and the bubble closes.

As part of this CL I had to move a constant from the windows code to the class so it can be used in gtk and mac.

TEST=manual, the code to invoke the bubble depends on another pending CL.
BUG=53598

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58095

Review URL: http://codereview.chromium.org/3231009
------------------------------------------------------------------------
r58218 | sky@chromium.org | 2010-09-01 21:27:46 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc
   M /trunk/src/views/controls/menu/submenu_view.cc

Adds support for invisible menu items to bookmark menus and wires it
up for the wrench menu.

BUG=46221, 54017
TEST=see bug

Review URL: http://codereview.chromium.org/3289001
------------------------------------------------------------------------
r58215 | phajdan.jr@chromium.org | 2010-09-01 21:09:06 +0200 (Wed, 01 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/event_synthesis_gtk.cc
   D /trunk/src/app/event_synthesis_gtk.h
   D /trunk/src/app/keyboard_code_conversion.cc
   D /trunk/src/app/keyboard_code_conversion.h
   D /trunk/src/app/keyboard_code_conversion_gtk.cc
   D /trunk/src/app/keyboard_code_conversion_gtk.h
   D /trunk/src/app/keyboard_code_conversion_mac.h
   D /trunk/src/app/keyboard_code_conversion_mac.mm
   D /trunk/src/app/keyboard_code_conversion_unittest.cc
   D /trunk/src/app/keyboard_code_conversion_win.cc
   D /trunk/src/app/keyboard_code_conversion_win.h
   D /trunk/src/app/keyboard_codes.h
   D /trunk/src/app/keyboard_codes_posix.h
   D /trunk/src/app/keyboard_codes_win.h
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/app/menus/accelerator_cocoa.h
   M /trunk/src/app/menus/accelerator_gtk.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   A /trunk/src/base/event_synthesis_gtk.cc (from /trunk/src/base/event_synthesis_gtk.cc:58185)
   A /trunk/src/base/event_synthesis_gtk.h (from /trunk/src/base/event_synthesis_gtk.h:58185)
   A /trunk/src/base/keyboard_code_conversion.cc (from /trunk/src/base/keyboard_code_conversion.cc:58185)
   A /trunk/src/base/keyboard_code_conversion.h (from /trunk/src/base/keyboard_code_conversion.h:58185)
   A /trunk/src/base/keyboard_code_conversion_gtk.cc (from /trunk/src/base/keyboard_code_conversion_gtk.cc:58185)
   A /trunk/src/base/keyboard_code_conversion_gtk.h (from /trunk/src/base/keyboard_code_conversion_gtk.h:58185)
   A /trunk/src/base/keyboard_code_conversion_mac.h (from /trunk/src/base/keyboard_code_conversion_mac.h:58185)
   A /trunk/src/base/keyboard_code_conversion_mac.mm (from /trunk/src/base/keyboard_code_conversion_mac.mm:58185)
   A /trunk/src/base/keyboard_code_conversion_unittest.cc (from /trunk/src/base/keyboard_code_conversion_unittest.cc:58185)
   A /trunk/src/base/keyboard_codes.h (from /trunk/src/base/keyboard_codes.h:58185)
   A /trunk/src/base/keyboard_codes_posix.h (from /trunk/src/base/keyboard_codes_posix.h:58185)
   A /trunk/src/base/keyboard_codes_win.h (from /trunk/src/base/keyboard_codes_win.h:58185)
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/password_changed_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_input_api.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view_browsertest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/webdriver/keymap.cc
   M /trunk/src/chrome/test/webdriver/keymap.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/host/event_executor_win.cc
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_gtk.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/native_table_win.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/examples/table2_example.h
   M /trunk/src/views/examples/table_example.h
   M /trunk/src/views/focus/accelerator_handler_gtk_unittest.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/support/DEPS
   M /trunk/src/webkit/support/webkit_support.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc

Revert 58186 - Move the keyboard files from base/ to app/.

Also moves the associated classes/enums from base:: to app::.

TEST=try bots compile
BUG=NONE

Review URL: http://codereview.chromium.org/3165064

TBR=bryeung@chromium.org
------------------------------------------------------------------------
r58210 | phajdan.jr@chromium.org | 2010-09-01 20:53:39 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container_browsertest.cc

Disable BrowserActionsContainerTest.Visibility, it still times out.

BUG=38992
TEST=browser_tests

Review URL: http://codereview.chromium.org/3357001
------------------------------------------------------------------------
r58208 | phajdan.jr@chromium.org | 2010-09-01 20:51:04 +0200 (Wed, 01 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc

Mark ExtensionApiTest.Popup as FLAKY, it is still flaky.

TBR=twiz

BUG=46601
TEST=browser_tests

Review URL: http://codereview.chromium.org/3356001
------------------------------------------------------------------------
r58205 | erg@google.com | 2010-09-01 20:30:51 +0200 (Wed, 01 Sep 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc

Blind stab in the dark; working on the assumption that this very weird compile
error is a problem with the arm compiler.

TBR=phajden-jr
------------------------------------------------------------------------
r58204 | rohitrao@chromium.org | 2010-09-01 20:26:20 +0200 (Wed, 01 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Revert 57677 - Mark test as flaky that's been failing on Chromium Mac.

BUG=53586
TEST=Mark BrowserWindowFullScreenControllerTest.TestActivate as flaky.

Review URL: http://codereview.chromium.org/3221003

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/3327002
------------------------------------------------------------------------
r58196 | phajdan.jr@chromium.org | 2010-09-01 19:30:18 +0200 (Wed, 01 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/download/base_file.cc
   M /trunk/src/chrome/browser/download/base_file.h
   M /trunk/src/chrome/browser/download/base_file_unittest.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

GTTF: Clean up DownloadFileManager

This removes a lot of duplication, locking, and thread jumping.

Most of the operations run on the FILE thread, and we do not duplicate
so much information. Each DownloadFile keeps track of its DownloadManager
(each Profile has its own DownloadManager). This allows us to remove
many maps from DownloadFileManager that were duplicating that information.

There is still SaveFileManager, but hopefully I will be able
to merge those two in small steps.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3245005
------------------------------------------------------------------------
r58194 | ctguil@chromium.org | 2010-09-01 19:15:16 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.h
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Update browser accessibility tree on a renderer accessibility object state change.

BUG=13291
TEST=interactive_ui_tests AccessibilityWinBrowserTest.TestDynamicAccessibilityTree
R=dmazzoni

Review URL: http://codereview.chromium.org/3250014
------------------------------------------------------------------------
r58192 | erg@google.com | 2010-09-01 19:08:20 +0200 (Wed, 01 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.h
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/download/download_history.cc
   M /trunk/src/chrome/browser/download/download_history.h
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.h
   M /trunk/src/chrome/browser/favicon_service.cc
   M /trunk/src/chrome/browser/favicon_service.h
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.cc
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.h
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.h
   M /trunk/src/chrome/renderer/net/renderer_net_predictor.cc
   M /trunk/src/chrome/renderer/net/renderer_net_predictor.h
   M /trunk/src/chrome/renderer/translate_helper.cc
   M /trunk/src/chrome/renderer/translate_helper.h
   M /trunk/src/chrome/renderer/user_script_idle_scheduler.cc
   M /trunk/src/chrome/renderer/user_script_idle_scheduler.h
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/ipc/ipc_channel_posix.cc
   M /trunk/src/ipc/ipc_channel_posix.h
   M /trunk/src/ipc/ipc_channel_win.cc
   M /trunk/src/ipc/ipc_channel_win.h
   M /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/backend_impl.h
   M /trunk/src/net/disk_cache/disk_cache_test_util.cc
   M /trunk/src/net/disk_cache/disk_cache_test_util.h
   M /trunk/src/net/disk_cache/eviction.cc
   M /trunk/src/net/disk_cache/eviction.h
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/webkit/glue/resource_fetcher.cc
   M /trunk/src/webkit/glue/resource_fetcher.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_agent.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_agent.h

FBTF: Move more ctors/dtors from headers to implementation.

- Adding/Moving dtors of objects that have CancelableRequestConsumers shaves
  three megs off browser.a.
- Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only
  shaved 100k off browser.a/renderer.a.
- Adding/Moving dtors of objects that used some form of base::*Timer<> was
  negligible; there were only a few classes that had a Timer but had a
  ctor/dtor in the header after the previous cleanups.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3278006
------------------------------------------------------------------------
r58188 | twiz@google.com | 2010-09-01 18:53:12 +0200 (Wed, 01 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   A /trunk/src/chrome/test/data/extensions/api_test/popup/background_page.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html:57188)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup.html:57188)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_a.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_a.html:57188)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_b.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_b.html:57188)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_dismissal.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_domui_popup_dismissal.html:57188)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/dom_ui_popup_sizing.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_sizing.html:57188)
   M /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_domui_popup_dismissal.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_a.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_b.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_sizing.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup_api


A CL implementing a collection of fixes to tidy up experimental popups.

The following are fixed:
 - Modified test\data\extension\api_test\popup to account for the removal of toolbar support.  The tests now start with a background page that creates a tab pointing to an extension dom-ui that runs the tests.
 - Changed the positioning of experimental popup views with the arrow location set to the right.  Popups used to always be anchored to the left edge of their relative dom element, now popups with a right-arrow will be attached to the right edge of their relative dom anchor.  Note that this only impacts popups with the 'rectangle' chrome.
 - Removed empty directory, test\data\extensions\api_test\popup_api

BUG=46601, 51821
TEST=ExtensionApiTest.Popup


Review URL: http://codereview.chromium.org/3155044
------------------------------------------------------------------------
r58186 | bryeung@chromium.org | 2010-09-01 18:39:26 +0200 (Wed, 01 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/event_synthesis_gtk.cc (from /trunk/src/base/event_synthesis_gtk.cc:58184)
   A /trunk/src/app/event_synthesis_gtk.h (from /trunk/src/base/event_synthesis_gtk.h:58184)
   A /trunk/src/app/keyboard_code_conversion.cc (from /trunk/src/base/keyboard_code_conversion.cc:58184)
   A /trunk/src/app/keyboard_code_conversion.h (from /trunk/src/base/keyboard_code_conversion.h:58184)
   A /trunk/src/app/keyboard_code_conversion_gtk.cc (from /trunk/src/base/keyboard_code_conversion_gtk.cc:58184)
   A /trunk/src/app/keyboard_code_conversion_gtk.h (from /trunk/src/base/keyboard_code_conversion_gtk.h:58184)
   A /trunk/src/app/keyboard_code_conversion_mac.h (from /trunk/src/base/keyboard_code_conversion_mac.h:58184)
   A /trunk/src/app/keyboard_code_conversion_mac.mm (from /trunk/src/base/keyboard_code_conversion_mac.mm:58184)
   A /trunk/src/app/keyboard_code_conversion_unittest.cc
   A /trunk/src/app/keyboard_code_conversion_win.cc
   A /trunk/src/app/keyboard_code_conversion_win.h
   A /trunk/src/app/keyboard_codes.h (from /trunk/src/base/keyboard_codes.h:58184)
   A /trunk/src/app/keyboard_codes_posix.h (from /trunk/src/base/keyboard_codes_posix.h:58184)
   A /trunk/src/app/keyboard_codes_win.h (from /trunk/src/base/keyboard_codes_win.h:58184)
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/app/menus/accelerator_cocoa.h
   M /trunk/src/app/menus/accelerator_gtk.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   D /trunk/src/base/event_synthesis_gtk.cc
   D /trunk/src/base/event_synthesis_gtk.h
   D /trunk/src/base/keyboard_code_conversion.cc
   D /trunk/src/base/keyboard_code_conversion.h
   D /trunk/src/base/keyboard_code_conversion_gtk.cc
   D /trunk/src/base/keyboard_code_conversion_gtk.h
   D /trunk/src/base/keyboard_code_conversion_mac.h
   D /trunk/src/base/keyboard_code_conversion_mac.mm
   D /trunk/src/base/keyboard_code_conversion_unittest.cc
   D /trunk/src/base/keyboard_codes.h
   D /trunk/src/base/keyboard_codes_posix.h
   D /trunk/src/base/keyboard_codes_win.h
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/password_changed_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_input_api.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view_browsertest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/webdriver/keymap.cc
   M /trunk/src/chrome/test/webdriver/keymap.h
   M /trunk/src/remoting/DEPS
   M /trunk/src/remoting/host/event_executor_win.cc
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_gtk.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/native_table_win.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/examples/table2_example.h
   M /trunk/src/views/examples/table_example.h
   M /trunk/src/views/focus/accelerator_handler_gtk_unittest.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/support/DEPS
   M /trunk/src/webkit/support/webkit_support.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc

Move the keyboard files from base/ to app/.

Also moves the associated classes/enums from base:: to app::.

TEST=try bots compile
BUG=NONE

Review URL: http://codereview.chromium.org/3165064
------------------------------------------------------------------------
r58184 | mseaborn@chromium.org | 2010-09-01 18:22:01 +0200 (Wed, 01 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src
   M /trunk/src/.gitignore
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate_linux.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   D /trunk/src/sandbox/linux/seccomp
   M /trunk/src/sandbox/sandbox.gyp

Pull seccomp-sandbox in via DEPS rather than using an in-tree copy 

This means changes to the sandbox won't have to be committed twice, to 
both trees. 

This is a retry of r57921, which was committed with git-svn and failed 
to remove the "seccomp" directory. This caused problems when trying 
to "svn checkout" to the same location, and the change was reverted. 
This time I will use SVN to commit the change. 

BUG=none 
TEST=smoke test of running chromium with --enable-seccomp-sandbox 
Review URL: http://codereview.chromium.org/3225010
------------------------------------------------------------------------
r58183 | xiyuan@chromium.org | 2010-09-01 18:15:46 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js

Don't allow duplicate users to be added to user whitelist.

BUG=chromium-os:6259
TEST=Verify fix for chromium-os:6259.

Review URL: http://codereview.chromium.org/3264009
------------------------------------------------------------------------
r58180 | sky@chromium.org | 2010-09-01 18:04:33 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Adds some additional AutocompleteEditController methods. They are
currently views only, but that will change once everything is working.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3272009
------------------------------------------------------------------------
r58179 | brettw@chromium.org | 2010-09-01 18:03:48 +0200 (Wed, 01 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

When finding the navigation entry for updating the title, we should use the
site instance from the RVH that is updating the title rather than the current
one. The current one might be a different process, which has a different
page_id namespace and could cause us to get confused.

If we get the page ID from the renderer, we should use the SiteInstance from
the same one rather than getting it from somewhere else. I don't know exactly
what case this might happen in, I just noticed this big via inspection when
looking at the code.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3228007
------------------------------------------------------------------------
r58177 | oshima@chromium.org | 2010-09-01 17:57:52 +0200 (Wed, 01 Sep 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add html support to screenlocker background
 * escape to close password field.
 * hide the saver when the password field is shown.
   (compositing the password field on top of screensaver correctly
    require more work)
 * moved methods/function in background_view.cc to be
   ordered in public, procted and private.
  (SetOobeProgressBarVisible, IsOobeProgressBarVisible, SetOobeProgress, SetGoIncognitoButtonVisible, OnLocaleChanged)

BUG=chromium-os:189
TEST=tested manually on the device, but testing this change requires other CLs
     on chromium-os repository.

Review URL: http://codereview.chromium.org/3273008
------------------------------------------------------------------------
r58176 | mirandac@chromium.org | 2010-09-01 17:57:50 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run/first_run.cc
   M /trunk/src/chrome/browser/first_run/first_run.h

Set default browser AFTER import.

BUG=53655
TEST=set Firefox as default browser on Windows. Run Chrome with a fresh profile.  Import from FF should occur.

Review URL: http://codereview.chromium.org/3298004
------------------------------------------------------------------------
r58174 | erikkay@chromium.org | 2010-09-01 17:33:58 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

default app icon

BUG=41286
TEST=install and uninstall an app without any icons set

Review URL: http://codereview.chromium.org/3238016
------------------------------------------------------------------------
r58172 | shess@chromium.org | 2010-09-01 16:43:43 +0200 (Wed, 01 Sep 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc

Fix safe-browsing prefix comparator to sort stably.

SafeBrowsingDatabaseBloom::PairCompare() compared SBPairs.  The prefix
part is a 32-bit hash which should be uniformly distributed.  The
previous code used a trick of subtracting the prefixes and returning
the result.  If arg1<arg2, that resulted in a negative return value,
if arg1>arg2, positive, if ==, zero.  Since the distribution was
uniform, 1/4 of prefix comparisons gave incorrect results, which
caused qsort() and bsearch() gave incorrect results.

In practice, this caused some add prefixes to remain in the database
when their opposite sub prefixes were present.  Most of these would be
gone after a few updates (as items were added or removed, the sort
within a chunk would change, allowing more matches to occur).  The
excess add prefixes may have resulted in excess queries up to the
servers, but should not have resulted in false misses (sites escaping
the filter).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3284011
------------------------------------------------------------------------
r58171 | willchan@chromium.org | 2010-09-01 16:42:03 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc

Relands r58007.
Fixes the problem with the flaky unittest that happened due to message loop posting race conditions.
BUG=53386
TEST=HostResolverImplTest.AbortOnIPAddressChanged,HostResolverImplTest.OnlyAbortExistingRequestsOnIPAddressChange

Review URL: http://codereview.chromium.org/3231013
------------------------------------------------------------------------
r58169 | satish@chromium.org | 2010-09-01 16:28:51 +0200 (Wed, 01 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller.cc
   M /trunk/src/tools/valgrind/tsan/suppressions.txt

Fix data race in destroying the info bubble.

The info bubble is a member variable of the class and the controller class's lifetime is managed in the IO thread. However the info bubble's lifetime is managed in the UI thread and in this case it was not destroyed before the IO thread was notified of the event. So the IO thread could process the notification and destroy the controller object before it finished with releasing the bubble. This change destroys the bubble before notifying the delegate to prevent such cases.

BUG=53765
TEST=running unit_tests --gtest_filter="*Speech*Cancelled*" under RaceChecker should find no data races.

Review URL: http://codereview.chromium.org/3328001
------------------------------------------------------------------------
r58168 | dpolukhin@chromium.org | 2010-09-01 16:27:09 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Mark device registered for users who updated image
and thus never observed register device screen.

BUG=chromium-os:6289
TEST=Delete .oobe_completed file, reboot, OOBE progress bar shouldn't be visible if any user presents on login-screen.

Review URL: http://codereview.chromium.org/3325001
------------------------------------------------------------------------
r58159 | akalin@chromium.org | 2010-09-01 12:39:25 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble_controller_unittest.cc

Marked SpeechInputBubbleControllerTest.TestFocusChanged as disabled.

BUG=54044
TEST=none
TBR=satish@chromium.org

Review URL: http://codereview.chromium.org/3301003
------------------------------------------------------------------------
r58150 | finnur@chromium.org | 2010-09-01 10:55:53 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Show Page Info InfoBubble on the right side for RTL languages and make sure Warning is treated as error in old dialog (which is how it was before).

BUG=http://crbug.com/52916
TEST=Open SSL Infobubble on RTL languages, make sure it points to the right location. Then open a gmail containing an external image (not attached, but embedded) and make sure the old SSL dialog (not the infobubble) shows an error for mixed content, not the green icon.

Review URL: http://codereview.chromium.org/3245012
------------------------------------------------------------------------
r58149 | bauerb@chromium.org | 2010-09-01 10:35:47 +0200 (Wed, 01 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/host_content_settings_map.cc

[Mac] Add option to block nonsandboxed plugins to content settings.

XIB changes: Add a radio button in the middle of the plugin (default) content settings with title ^IDS_PLUGIN_LOAD_SNADBOXED_RADIO.

BUG=53812
TEST=none

Review URL: http://codereview.chromium.org/3250006
------------------------------------------------------------------------
r58148 | jochen@chromium.org | 2010-09-01 10:32:43 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc

Show option to block non-sandboxed plugins. (Gtk/Views/tabbed part)

BUG=53812
TEST=none

Review URL: http://codereview.chromium.org/3231008
------------------------------------------------------------------------
r58147 | bauerb@chromium.org | 2010-09-01 10:07:46 +0200 (Wed, 01 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc

Enable click-to-play by default.

Click-to-play can be disabled using the --disable-click-to-play command line switch.

BUG=35316
TEST=none

Review URL: http://codereview.chromium.org/3250012
------------------------------------------------------------------------
r58146 | zork@chromium.org | 2010-09-01 10:05:21 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc

Exit cleanly from the candidate_window if it can't connect to ibus.

BUG=chromium-os:6002
TEST=None

Review URL: http://codereview.chromium.org/3223012
------------------------------------------------------------------------
r58142 | aa@chromium.org | 2010-09-01 08:49:20 +0200 (Wed, 01 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc

Remove an incorrect dcheck.

TBR=aa@chromium.org
------------------------------------------------------------------------
r58141 | yutak@chromium.org | 2010-09-01 08:24:04 +0200 (Wed, 01 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm

Mac: Allowed incognito windows to be bookmark open target.

Patch contributed by Hajime Morita <morrita@google.com>.
Original review URL: http://codereview.chromium.org/3217007

BUG=23547
TEST=manual

Review URL: http://codereview.chromium.org/3225009
------------------------------------------------------------------------
r58139 | aa@chromium.org | 2010-09-01 07:59:47 +0200 (Wed, 01 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js

De-suck the NTP a bit more:

* When there are no apps, don't show the apps section.
* Expand the MV section by default, like it was in M6.
* Fix bug where recently closed is incorrectly toggleable.
* Stop showing miniview items for MV section when there is no more room.
* Don't show filler MV items in miniview.
* MV section is 5px too high because we were only apply extra padding
  to the first section, even if that section was disabled.

TEST=Visual inspection.

Review URL: http://codereview.chromium.org/3292003
------------------------------------------------------------------------
r58137 | johnnyg@chromium.org | 2010-09-01 07:50:35 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification.h
   M /trunk/src/chrome/browser/notifications/balloon.cc
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/notifications/notification.h
   M /trunk/src/chrome/browser/notifications/notification_delegate.h
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.cc
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/notification_provider.cc
   M /trunk/src/chrome/renderer/notification_provider.h

Implement the plumbing to deliver click events from the notification balloon view to the javascript object.

BUG=51226
TEST=use notifications with an onclick event

Review URL: http://codereview.chromium.org/3273007
------------------------------------------------------------------------
r58135 | zork@chromium.org | 2010-09-01 07:35:29 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Move preferred language and preload engines logic into first login code.

BUG=chromium-os:5879
TEST=See Bug.

Review URL: http://codereview.chromium.org/3249007
------------------------------------------------------------------------
r58132 | aa@chromium.org | 2010-09-01 07:10:48 +0200 (Wed, 01 Sep 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/window_open_apitest.cc

Mark a test flaky.

TBR=ananta@chromium.org
------------------------------------------------------------------------
r58130 | cmasone@google.com | 2010-09-01 06:48:03 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.h
   M /trunk/src/chrome/browser/chromeos/login/ownership_service_unittest.cc

[chrome os] Fix ownership sign/verify unit tests

BUG=chromium-os:4488
TEST=unit tests

Review URL: http://codereview.chromium.org/3226017
------------------------------------------------------------------------
r58129 | akalin@chromium.org | 2010-09-01 06:48:01 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc

Fixed crash in sync_listen_notifications.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/3291002
------------------------------------------------------------------------
r58126 | asargent@chromium.org | 2010-09-01 06:41:23 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   A /trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc
   A /trunk/src/chrome/browser/extensions/extension_webstore_private_api.h
   M /trunk/src/chrome/browser/resources/webstore_app/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Private API for web store to get sync login and set store login information.

BUG=53489
TEST=Not sure yet the best way to test this - it will depend on how the store
implements their part of the API. 

Review URL: http://codereview.chromium.org/3219006
------------------------------------------------------------------------
r58123 | akalin@chromium.org | 2010-09-01 06:28:04 +0200 (Wed, 01 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Use ChromeAsyncSocket by default.

Removed --sync-use-chrome-async-socket switch, added
--sync-disable-chrome-async-socket switch.

BUG=45612
TEST=manually

Review URL: http://codereview.chromium.org/3304001
------------------------------------------------------------------------
r58122 | thakis@chromium.org | 2010-09-01 06:25:03 +0200 (Wed, 01 Sep 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm

Mac: Make tabpose zoom-in animation a bit shorter.

Reviewed as part of http://codereview.chromium.org/3220004.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3301002
------------------------------------------------------------------------
r58121 | akalin@chromium.org | 2010-09-01 06:16:54 +0200 (Wed, 01 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/jingle/jingle.gyp
   M /trunk/src/jingle/notifier/base/chrome_async_socket.cc
   M /trunk/src/jingle/notifier/base/chrome_async_socket.h
   M /trunk/src/jingle/notifier/base/chrome_async_socket_unittest.cc
   A /trunk/src/jingle/notifier/base/xmpp_client_socket_factory.cc
   A /trunk/src/jingle/notifier/base/xmpp_client_socket_factory.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc

Added XmppClientSocketFactory for use with ChromeAsyncSocket

XmppClientSocketFactory serves up regular TCP sockets or fake SSL TCP
sockets.  This way, ChromeAsyncSocket has feature parity with
XmppSocketAdapter.

BUG=45612
TEST=existing unittests

Review URL: http://codereview.chromium.org/3299001
------------------------------------------------------------------------
r58120 | aa@chromium.org | 2010-09-01 06:15:00 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   A /trunk/src/chrome/browser/extensions/window_open_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/window_open
   A /trunk/src/chrome/test/data/extensions/api_test/window_open/spanning
   A /trunk/src/chrome/test/data/extensions/api_test/window_open/spanning/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/window_open/spanning/foo.html
   A /trunk/src/chrome/test/data/extensions/api_test/window_open/spanning/infobar.html
   A /trunk/src/chrome/test/data/extensions/api_test/window_open/spanning/manifest.json

window.open() from an extension should always goes in normal browser. When the split incognito stuff lands, I will change this to allow window.open() to go to incognito if you're in split mode.

BUG=52298
TEST=browser_tests --gtest_filter=ExtensionApiTest.WindowOpen

Review URL: http://codereview.chromium.org/3249012
------------------------------------------------------------------------
r58119 | ananta@chromium.org | 2010-09-01 04:56:23 +0200 (Wed, 01 Sep 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/download/base_file.cc
   M /trunk/src/chrome/browser/download/base_file.h
   M /trunk/src/chrome/browser/download/base_file_unittest.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

Reverting to see if this fixes linux ui tests hang. Just a shot in the dark at this
point.

Revert 58087 - GTTF: Clean up DownloadFileManager

This removes a lot of duplication, locking, and thread jumping.

Most of the operations run on the FILE thread, and we do not duplicate
so much information. Each DownloadFile keeps track of its DownloadManager
(each Profile has its own DownloadManager). This allows us to remove
many maps from DownloadFileManager that were duplicating that information.

There is still SaveFileManager, but hopefully I will be able
to merge those two in small steps.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3245005

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3311001
------------------------------------------------------------------------
r58118 | oshima@chromium.org | 2010-09-01 04:23:01 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   D /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   D /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/chromeos/view_ids.h
   M /trunk/src/chrome/chrome_browser.gypi

Remove NormalBrowserFrameView
 Main menu has been removed and OTR icon can now be placed on the left.

BUG=52674
TEST=none

Review URL: http://codereview.chromium.org/3215001
------------------------------------------------------------------------
r58116 | hclam@chromium.org | 2010-09-01 04:18:23 +0200 (Wed, 01 Sep 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/service/service_process_control_manager.cc

Don't shutdown service process when browser shuts down

Keep the service process running when browser shuts down.

BUG=52891
TBR=sanjeevr
TEST=none

Review URL: http://codereview.chromium.org/3307001
------------------------------------------------------------------------
r58109 | oshima@chromium.org | 2010-09-01 04:12:12 +0200 (Wed, 01 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Wait to compute mouse event offset until the info bubble is mapped.
 The destination widget's geometry returns -1,-1 when requested
 right after it's been created. I guess this is regression by WidgetGtk resize fix, but the old way was probably wrong anyway.
 This CL fixes the issue by deferring the offset computation until
 widget's location becomes available.

BUG=chromium-os:6250
TEST=manually tested on the device.

Review URL: http://codereview.chromium.org/3258005
------------------------------------------------------------------------
r58108 | andybons@chromium.org | 2010-09-01 04:09:42 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   A /trunk/src/chrome/test/data/extensions/app4
   A /trunk/src/chrome/test/data/extensions/app4/manifest.json
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h
   M /trunk/src/webkit/database/database_tracker_unittest.cc

Protect local storage created by extension apps.

BUG=49228
TEST=ExtensionsServiceTest.InstallAppsAndCheckStorageProtection
TEST=DatabaseTrackerTest.*

Review URL: http://codereview.chromium.org/3256003
------------------------------------------------------------------------
r58107 | tim@chromium.org | 2010-09-01 03:23:12 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disable DownloadTest.NewWindow everywhere.

BUG=44454, 50060
TBR=phajdan-jr

Review URL: http://codereview.chromium.org/3302001
------------------------------------------------------------------------
r58105 | mirandac@chromium.org | 2010-09-01 02:04:55 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h

Fix web_database credit card table data migration. 

(This is the trunk version of 3228011).

BUG=10913
TEST= run build on profile from before 37036; search engines should work. run build on corrupted profile (one from before 37036 that has been updated with build 6.0.472.50); search engines should work.
Review URL: http://codereview.chromium.org/3240007
------------------------------------------------------------------------
r58104 | ananta@chromium.org | 2010-09-01 01:58:56 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disabling the DownloadTest.NewWindow for linux as it seems to consistently fail there.

Bug=44454
TBR=phajdan-jr

Review URL: http://codereview.chromium.org/3270017
------------------------------------------------------------------------
r58100 | ananta@chromium.org | 2010-09-01 01:46:21 +0200 (Wed, 01 Sep 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   D /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm
   M /trunk/src/chrome/browser/speech/speech_input_bubble_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Reverting as this breaks Chromium OS. Please fix and reland.

Revert 58095 - Implement the speech input bubble on linux/gtk.

This is a popup which gets displayed below an <input> element when the user starts speech recognition on it. It displays a recognition status icon, an instruction label ('Speak now') at the top and a Cancel button at the bottom. The speech input module gets callbacks on user actions such as clicking Cancel or clicking any other window, and on both cases recognition stops and the bubble closes.

As part of this CL I had to move a constant from the windows code to the class so it can be used in gtk and mac.

TEST=manual, the code to invoke the bubble depends on another pending CL.
BUG=53598

Review URL: http://codereview.chromium.org/3231009

TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/3263010
------------------------------------------------------------------------
r58099 | mpcomplete@chromium.org | 2010-09-01 01:24:19 +0200 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Disable IncognitoSplitMode everywhere, it's failing and hangy. Working on a fix.

BUG=53991
TEST=no
TBR=aa

Review URL: http://codereview.chromium.org/3223013
------------------------------------------------------------------------
r58098 | levin@chromium.org | 2010-09-01 01:23:26 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.cc
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.h
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h

Prepare to load search provider information directly on the I/O thread.

BUG=38475
TEST=unit_tests --gtest_filter=Temp*:Search*:Key*

Review URL: http://codereview.chromium.org/3250011
------------------------------------------------------------------------
r58097 | sergeyu@chromium.org | 2010-09-01 01:18:48 +0200 (Wed, 01 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.cc
   M /trunk/src/media/audio/audio_input_controller.cc
   M /trunk/src/media/audio/audio_input_controller.h
   M /trunk/src/media/audio/audio_input_controller_unittest.cc
   M /trunk/src/media/audio/audio_manager.cc
   M /trunk/src/media/audio/audio_manager.h
   M /trunk/src/media/audio/audio_manager_base.h
   M /trunk/src/media/audio/audio_output_controller.cc
   M /trunk/src/media/audio/audio_output_controller.h
   M /trunk/src/media/audio/audio_output_controller_unittest.cc
   A /trunk/src/media/audio/audio_parameters.cc
   A /trunk/src/media/audio/audio_parameters.h
   M /trunk/src/media/audio/fake_audio_input_stream.cc
   M /trunk/src/media/audio/fake_audio_input_stream.h
   M /trunk/src/media/audio/fake_audio_input_stream_unittest.cc
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.h
   M /trunk/src/media/audio/mac/audio_input_mac.cc
   M /trunk/src/media/audio/mac/audio_input_mac.h
   M /trunk/src/media/audio/mac/audio_input_mac_unittest.cc
   M /trunk/src/media/audio/mac/audio_manager_mac.cc
   M /trunk/src/media/audio/mac/audio_manager_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac_unittest.cc
   M /trunk/src/media/audio/simple_sources_unittest.cc
   M /trunk/src/media/audio/test_audio_input_controller_factory.cc
   M /trunk/src/media/audio/test_audio_input_controller_factory.h
   M /trunk/src/media/audio/win/audio_input_win_unittest.cc
   M /trunk/src/media/audio/win/audio_manager_win.cc
   M /trunk/src/media/audio/win/audio_manager_win.h
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/wavein_input_win.cc
   M /trunk/src/media/audio/win/wavein_input_win.h
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/base/limits.h
   M /trunk/src/media/filters/audio_renderer_impl.cc
   M /trunk/src/media/filters/ffmpeg_audio_decoder.cc
   M /trunk/src/media/media.gyp

Add AudioParameters struct. Use it everywhere.
BUG=None
TEST=unittests

Review URL: http://codereview.chromium.org/3226012
------------------------------------------------------------------------
r58096 | csilv@chromium.org | 2010-09-01 01:13:35 +0200 (Wed, 01 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc

dom-ui options: Eliminate redundant DCHECKs (eliminates Coverity issue.)

BUG=none
TEST=Verify advanced_options_handler.cc has no coverity errors.
Review URL: http://codereview.chromium.org/3261005
------------------------------------------------------------------------
r58095 | satish@chromium.org | 2010-09-01 01:10:33 +0200 (Wed, 01 Sep 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   A /trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm
   M /trunk/src/chrome/browser/speech/speech_input_bubble_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement the speech input bubble on linux/gtk.

This is a popup which gets displayed below an <input> element when the user starts speech recognition on it. It displays a recognition status icon, an instruction label ('Speak now') at the top and a Cancel button at the bottom. The speech input module gets callbacks on user actions such as clicking Cancel or clicking any other window, and on both cases recognition stops and the bubble closes.

As part of this CL I had to move a constant from the windows code to the class so it can be used in gtk and mac.

TEST=manual, the code to invoke the bubble depends on another pending CL.
BUG=53598

Review URL: http://codereview.chromium.org/3231009
------------------------------------------------------------------------
r58094 | iyengar@google.com | 2010-09-01 01:08:08 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Marking the ExtensionApiTest.Tabs as FLAKY on Windows.

Bug=48920
TBR=timsteele

Review URL: http://codereview.chromium.org/3285004
------------------------------------------------------------------------
r58092 | csilv@chromium.org | 2010-09-01 00:59:33 +0200 (Wed, 01 Sep 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/alert_overlay.html
   M /trunk/src/chrome/browser/resources/options/alert_overlay.js

dom-ui options: Move alert onclick handlers to javascript, make handlers private.

BUG=none
TEST=verify alerts work properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3258007
------------------------------------------------------------------------
r58087 | phajdan.jr@chromium.org | 2010-09-01 00:53:51 +0200 (Wed, 01 Sep 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/download/base_file.cc
   M /trunk/src/chrome/browser/download/base_file.h
   M /trunk/src/chrome/browser/download/base_file_unittest.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

GTTF: Clean up DownloadFileManager

This removes a lot of duplication, locking, and thread jumping.

Most of the operations run on the FILE thread, and we do not duplicate
so much information. Each DownloadFile keeps track of its DownloadManager
(each Profile has its own DownloadManager). This allows us to remove
many maps from DownloadFileManager that were duplicating that information.

There is still SaveFileManager, but hopefully I will be able
to merge those two in small steps.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3245005
------------------------------------------------------------------------
r58086 | phajdan.jr@chromium.org | 2010-09-01 00:53:03 +0200 (Wed, 01 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_prefs.h
   M /trunk/src/chrome/browser/prefs/pref_member.cc
   M /trunk/src/chrome/browser/prefs/pref_member.h

Cleanup: make more PrefMember methods const.

This allows the users of PrefService to make their accessors
that refer to PrefMember members const too.

We use mutable for some PrefMember members, when they
do not reflect the outside-visible state. Those members
are used to do lazy loading of the preference values.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3271004
------------------------------------------------------------------------
r58080 | levin@chromium.org | 2010-09-01 00:37:11 +0200 (Wed, 01 Sep 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model.mm
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   A /trunk/src/chrome/browser/search_engines/template_url_id.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   A /trunk/src/chrome/browser/search_engines/template_url_model_observer.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/chrome_browser.gypi

Reduce the number of files that recompile when changing template_url.h or template_url_model.h.

Separated out the TemplateURL::IDType which is now TemplateURLId into its own
file, since this was a primary reason for including template_url.h in another
header.

Similarly separate out the TemplateURLModelObserver from template_url_model.h to
reduce how often that file is included.

BUG=None
TEST=Compiling.

Review URL: http://codereview.chromium.org/3270011
------------------------------------------------------------------------
r58077 | mattm@chromium.org | 2010-09-01 00:13:52 +0200 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M /trunk/src/base/nss_util.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h
   A /trunk/src/net/base/cert_database.cc
   M /trunk/src/net/base/cert_database.h
   M /trunk/src/net/base/cert_database_nss.cc
   M /trunk/src/net/base/cert_database_nss_unittest.cc
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/net.gyp
   A /trunk/src/net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp
   A /trunk/src/net/third_party/mozilla_security_manager/nsNSSCertificateDB.h

Add NSS cert trust setting, cert deleting, and CA cert import to CertDatabase.

BUG=19991
TEST=net/base/cert_database_nss_unittest.cc

Review URL: http://codereview.chromium.org/3106028
------------------------------------------------------------------------
r58072 | jam@chromium.org | 2010-08-31 23:28:20 +0200 (Tue, 31 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_updater.cc

Fix two bugs for setting the pdf plugin on by default:
-fix regression in enabling the plugin after the PluginGroup change
-rename the pref name, and add a dcheck to ensure this always is done, every time the plugin flips from enabled->disabled by default
Review URL: http://codereview.chromium.org/3238015
------------------------------------------------------------------------
r58070 | eroman@chromium.org | 2010-08-31 23:07:33 +0200 (Tue, 31 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/net/load_timing_observer.cc
   M /trunk/src/chrome/browser/net/net_log_logger.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/net/base/capturing_net_log.h
   M /trunk/src/net/base/forwarding_net_log.cc
   M /trunk/src/net/base/forwarding_net_log.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_proxy_client_socket.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/url_request/url_request.cc

Fix a regression whereby full-granularity network events were being captured by PassiveLogCollector.
BUG=53883
TEST=Load a webpage. Now open about:net-internals and verify that the log for that URL does NOT contain the HTTP request/response headers.
Review URL: http://codereview.chromium.org/3274016
------------------------------------------------------------------------
r58065 | mpcomplete@chromium.org | 2010-08-31 22:53:36 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Disable IncognitoSplitMode for linux, it's hanging there too.

BUG=53991
TEST=no
TBR=aa

Review URL: http://codereview.chromium.org/3225013
------------------------------------------------------------------------
r58059 | phajdan.jr@chromium.org | 2010-08-31 22:39:19 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disable BrowserFocusTest.FocusOnReloadCrashedTab on Linux and ChromeOS.

We just caught a failure on it on Linux/views (timeout).

BUG=50025
TEST=interactive_ui_tests

Review URL: http://codereview.chromium.org/3284007
------------------------------------------------------------------------
r58056 | levin@chromium.org | 2010-08-31 22:14:25 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc

Fix build due to breakage introduced in r57918.

BUG=38475
TEST=Compiles.

Review URL: http://codereview.chromium.org/3273014
------------------------------------------------------------------------
r58051 | mpcomplete@chromium.org | 2010-08-31 21:44:51 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Disable IncognitoSplitMode on ChromeOS until I can fix.

BUG=53991
TEST=no
TBR=aa

Review URL: http://codereview.chromium.org/3244007
------------------------------------------------------------------------
r58048 | tim@chromium.org | 2010-08-31 21:40:19 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.h
   M /trunk/src/chrome/browser/sync/util/cryptographer_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

sync: Add bootstrappability to the Cryptographer.

This avoids requiring prompting the user for a passphrase on each
start.

TEST=CryptographerTest, CryptographerPackUnpackTest

Review URL: http://codereview.chromium.org/3216001
------------------------------------------------------------------------
r58045 | dumi@chromium.org | 2010-08-31 21:30:27 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util_proxy.cc
   M /trunk/src/base/file_util_proxy.h
   M /trunk/src/base/platform_file.h
   M /trunk/src/base/platform_file_posix.cc
   M /trunk/src/base/platform_file_win.cc
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_unittest.cc
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/block_files.cc
   M /trunk/src/net/disk_cache/disk_cache_test_util.cc
   M /trunk/src/net/disk_cache/file_posix.cc
   M /trunk/src/webkit/blob/blob_url_request_job.cc
   M /trunk/src/webkit/blob/blob_url_request_job.h
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/glue/webfileutilities_impl.cc

Add an optional parameter to CreatePlatformFile() to report the type
of error that occured while trying to open/create a file.

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/3223007
------------------------------------------------------------------------
r58041 | hclam@chromium.org | 2010-08-31 21:23:14 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/common/service_process_util.cc
   M /trunk/src/chrome/common/service_process_util.h
   M /trunk/src/chrome/service/service_process.cc

Use named events instead of lock files for service process

Use named events to signal that a service process is running.

BUG=52891
TEST=browser_tests --gtest_filter=ServiceProcess*

Review URL: http://codereview.chromium.org/3268003
------------------------------------------------------------------------
r58040 | erg@google.com | 2010-08-31 21:22:41 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/app/menus/menu_model.cc
   M /trunk/src/app/menus/menu_model.h
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h

The "Update Chrome" menu item should appear in addition to the About menu.

It should not replace it. This patch modifications to the GTK and Cocoa ports to make the update chrome item appear when an update is available. On win/chromeos, the menu item is always there but disabled, since I'm having some problems figuring out the views custom menu implementation.

BUG=46221
TEST=The upgrade item should now appear under instead of replacing the about command.

Review URL: http://codereview.chromium.org/3143046
------------------------------------------------------------------------
r58037 | hclam@chromium.org | 2010-08-31 21:16:18 +0200 (Tue, 31 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.h
   M /trunk/src/chrome/browser/remoting/remoting_setup_message_handler.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_message_handler.h

Cleanup TODOs in RemotingSetupFlow

Things done in this patch:
1. RemotingSetupMessageHandler is not leaked.
2. Logic of showing different pages is now in RemotingSetupFlow.
3. Better lifetime for RemotingSetupFlow.
4. RemotingSetupFlow doesn't need to be refcounted, instead we have a helper
   class that we can detach when the dialog is closed.

BUG=52888
TEST=Run with --enable-remoting and start the remoting setup dialog

Review URL: http://codereview.chromium.org/3106036
------------------------------------------------------------------------
r58036 | johnnyg@chromium.org | 2010-08-31 21:13:23 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc

Make mac notifications less janky: group the animation together so that they slide in a group, and make the animation duration shorter.
Remove some unnecessary repositionings.

BUG=49245
TEST=notifications on mac

Review URL: http://codereview.chromium.org/3259009
------------------------------------------------------------------------
r58033 | mpcomplete@chromium.org | 2010-08-31 20:40:32 +0200 (Tue, 31 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_sidebar_api.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.cc
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.sidebar.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/test/data/extensions/api_test/incognito/apis/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/split
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/split/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/split/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json

Add support for a "split" incognito behavior for extensions.
- On by default for apps, off by default for extensions.
- Split mode means "run incognito extensions in a separate process if the user
says OK, and the two processes can only see their own profile."
- Spanning mode is what we have now, and means "run a single extension process,
but allow it to access both profiles if the user says OK."

BUG=49232
BUG=49114
TEST=extensions still work in incognito when you check "Allow in Incognito".

Review URL: http://codereview.chromium.org/3210007
------------------------------------------------------------------------
r58032 | sky@chromium.org | 2010-08-31 20:37:50 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Fixed bad ifdef.

BUG=none
TEST=none
TBR=oshima@chromium.org

Review URL: http://codereview.chromium.org/3283007
------------------------------------------------------------------------
r58031 | zelidrag@chromium.org | 2010-08-31 20:21:21 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc

Fixed feedback form crash.

BUG=chromium-os:6169
TEST=make sure that chromeos feedback form can survive browser state restore without crashing

Review URL: http://codereview.chromium.org/3280010
------------------------------------------------------------------------
r58028 | pkasting@chromium.org | 2010-08-31 20:20:43 +0200 (Tue, 31 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc

Hide page actions and star, like we already do for content settings, when the user is editing the omnibox.

BUG=none 
TEST=Typing in the omnibox should make all items on the right disappear, and make ctrl-d do nothing.
------------------------------------------------------------------------
r58023 | willchan@chromium.org | 2010-08-31 20:13:20 +0200 (Tue, 31 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc

Revert r58019 and r58007 due to flaky.
Blargh, there are race conditions in UI->IO MessageLoop passing.  Need to fix them.
BUG=53965,53386

Review URL: http://codereview.chromium.org/3215012
------------------------------------------------------------------------
r58020 | erg@google.com | 2010-08-31 20:00:53 +0200 (Tue, 31 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/net/net_log_logger.cc
   M /trunk/src/chrome/browser/net/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   A /trunk/src/net/base/auth.cc
   M /trunk/src/net/base/auth.h
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_proc.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   A /trunk/src/net/base/ssl_cert_request_info.cc
   M /trunk/src/net/base/ssl_cert_request_info.h
   A /trunk/src/net/base/ssl_info.cc
   M /trunk/src/net/base/ssl_info.h
   M /trunk/src/net/base/upload_data.cc
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/base/upload_data_stream_unittest.cc
   M /trunk/src/net/http/http_cache_transaction.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_response_headers.cc
   M /trunk/src/net/http/http_response_headers.h
   M /trunk/src/net/http/http_response_info.cc
   A /trunk/src/net/http/http_stream_handle.cc
   M /trunk/src/net/http/http_stream_handle.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_bypass_rules.cc
   M /trunk/src/net/proxy/proxy_bypass_rules.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket_stream/socket_stream.h
   M /trunk/src/net/tools/fetch/http_server.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_about_job.cc
   M /trunk/src/net/url_request/url_request_about_job.h
   M /trunk/src/net/url_request/url_request_context.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/websockets/websocket.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

FBTF: A giant cleanup to net/

This moves all sorts of code from h files to cc files and reduces header
dependencies.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3212008
------------------------------------------------------------------------
r58015 | nirnimesh@chromium.org | 2010-08-31 19:39:42 +0200 (Tue, 31 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/test/functional/ssl.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Fetch info about the state of navigation in a tab

This includes info about:
  - ssl status: allows for automation of ssl tests
  - page type
  - favicon

TEST=ssl.py

Review URL: http://codereview.chromium.org/3266012
------------------------------------------------------------------------
r58007 | willchan@chromium.org | 2010-08-31 18:52:15 +0200 (Tue, 31 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc

Abort host resolution requests with ERR_ABORTED on ip address change.
BUG=53386

Review URL: http://codereview.chromium.org/3277002
------------------------------------------------------------------------
r58006 | viettrungluu@chromium.org | 2010-08-31 18:52:13 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Convert wstrings in bookmarks, part 1000000.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3249013
------------------------------------------------------------------------
r58005 | cmasone@google.com | 2010-08-31 18:49:53 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/mock_owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.h
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.cc
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.h
   M /trunk/src/chrome/browser/chromeos/login/ownership_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

[Chrome OS] Add signing and verification to ownership API

Most of the files in here are changed only because I switched to representing digital signatures as std::vector<uint8> instead of std::string, so I had to alter the signatures of a lot of methods.

BUG=chromium-os:4488
TEST=unit tests

Review URL: http://codereview.chromium.org/3212011
------------------------------------------------------------------------
r58001 | dhg@chromium.org | 2010-08-31 17:54:45 +0200 (Tue, 31 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css

Changing the options page css so that things line up a little better.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3269004
------------------------------------------------------------------------
r58000 | dhg@chromium.org | 2010-08-31 17:54:28 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options.html

Changing the order of the loading of css files. Seems to improve speed significantly.

BUG=6140
TEST=try loading the page, is pretty fast.

Review URL: http://codereview.chromium.org/3256002
------------------------------------------------------------------------
r57999 | mnissler@chromium.org | 2010-08-31 17:49:20 +0200 (Tue, 31 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.h

[win] Add fallback for periodic reload to ConfigurationPolicyProviderWin.

In-the-wild crashes indicate it's possible RegisterGPNotification fails. Handle
that case gracefully, i.e. degrade to periodic group policy refresh.

BUG=53250
TEST=ConfigurationPolicyProviderWinTest, no more crashes due to CHECKs in ConfigurationPolicyProviderWin::GroupPolicyChangeWatcher::GroupPolicyChangeWatcher()

Review URL: http://codereview.chromium.org/3233007
------------------------------------------------------------------------
r57998 | sky@chromium.org | 2010-08-31 17:40:48 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Disables a couple of tab tests as they're not applicable on
linux/views.

BUG=10941
TEST=none

Review URL: http://codereview.chromium.org/3244003
------------------------------------------------------------------------
r57996 | rsesek@chromium.org | 2010-08-31 17:24:17 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/animatable_image_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/popup_blocked_animation_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Change the conditions on which the popup blocked animation is shown to be more reliable.
This also prevents AnimatableImage from running after the window has been closed.

BUG=50000,50395
TEST=Get a blocked popup. Open it. Animation not shown.
TEST=Go to a page that creates a popup on document.unload. Close the tab. Animation not shown.

Review URL: http://codereview.chromium.org/3169030
------------------------------------------------------------------------
r57988 | jorlow@chromium.org | 2010-08-31 16:23:42 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h

Implement the Chrome half of setVersion.

TEST=setVersion layout test works in non-single-process-mode
BUG=none

Review URL: http://codereview.chromium.org/3116043
------------------------------------------------------------------------
r57987 | tfarina@chromium.org | 2010-08-31 15:54:36 +0200 (Tue, 31 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h

Address a TODO in SSLPolicyBackend class.

Fix the conversions from wide to string16 in this class and get rid of the
base/utf_string_conversions.h.

(Note: this was a TODO for evanm).

BUG=None
TEST=compiles locally and trybots

Review URL: http://codereview.chromium.org/3284003
------------------------------------------------------------------------
r57986 | glotov@chromium.org | 2010-08-31 15:46:30 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc

Tiny fix: ResolveMetricsReportingEnabled() return value honored.

BUG=chromium-os:2884 
TEST=none

Review URL: http://codereview.chromium.org/3109012
------------------------------------------------------------------------
r57983 | ctguil@chromium.org | 2010-08-31 13:54:31 +0200 (Tue, 31 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.h
   M /trunk/src/chrome/browser/browser_accessibility_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.h
   M /trunk/src/chrome/browser/browser_accessibility_win_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Update browser cache of accessibility tree on renderer sub-tree changes.

WebKit sister patch: http://trac.webkit.org/changeset/66305

BUG=13291
TEST=interactive_ui_tests --gtest_filter=AccessibilityWinBrowserTest.TestDynamicAccessibilityTree
TEST=unit_tests --gtest_filter=BrowserAccessibilityTest.TestChildrenChange
TEST=unit_tests --gtest_filter=BrowserAccessibilityTest.TestChildrenChangeNoLeaks

Review URL: http://codereview.chromium.org/3117036
------------------------------------------------------------------------
r57982 | dilmah@chromium.org | 2010-08-31 13:42:53 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

Removed "New User" label for New user pod in case this pod is the only existing pod.
Removed "Cant authorize?" link on new user pod because this functionality has moved into a bubble prompt.

BUG=http://crosbug.org/5756
TEST=Manual

Review URL: http://codereview.chromium.org/3243013
------------------------------------------------------------------------
r57981 | allanwoj@chromium.org | 2010-08-31 13:24:13 +0200 (Tue, 31 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gateway_data_provider_common_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc

Fixed hanging gatewaydataprovider test fixture
Changed the behaviour of the listener on an update to not wait for pending tasks to quit. Same for the WifiDataProvider. Also gave the fixture a better name.
BUG=53472

Review URL: http://codereview.chromium.org/3266002
------------------------------------------------------------------------
r57975 | allanwoj@chromium.org | 2010-08-31 12:15:46 +0200 (Tue, 31 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gateway_data_provider_common_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc
   M /trunk/src/tools/heapcheck/suppressions.txt

Fix leaking tests for network location providers
The StartThread fixture now calls main_message_loop_.Run() to release a reference on the provider. Same problem should affect the wifi data provider so added there as well. Also removed the StopProvider call as it is done in the TearDown and change the NoRouterInterval to be 1 millisecond.
BUG=53573

Review URL: http://codereview.chromium.org/3264001
------------------------------------------------------------------------
r57970 | finnur@chromium.org | 2010-08-31 10:44:43 +0200 (Tue, 31 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/browser/views/page_info_bubble_view.h

Tweaks to the SSL InfoBubble dialog.

Fixed the mixed state icon not showing for section Connection. I overlooked the fact that we already check for mixed content, but reported state as error (whereas now we want warning).

Added link to help center explaining what this dialog means.

BUG=http://crbug.com/52916
TEST=SSL Infobubble should show link to help center and should show mixed content icon when, for example, you open an email in Gmail with an external image embedded in it.

Review URL: http://codereview.chromium.org/3221005
------------------------------------------------------------------------
r57968 | viettrungluu@chromium.org | 2010-08-31 08:14:17 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/app/text_elider.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   M /trunk/src/chrome/browser/net/browser_url_util.cc
   M /trunk/src/chrome/browser/net/browser_url_util.h
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Remove the wstring FormatUrl() functions (and convert remaining users to the string16 verison).

Still to do: Actually convert the code underlying FormatUrl().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3263005
------------------------------------------------------------------------
r57966 | aa@chromium.org | 2010-08-31 08:00:59 +0200 (Tue, 31 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/theme/ntp_header_background.png
   D /trunk/src/chrome/app/theme/ntp_header_background_active.png
   D /trunk/src/chrome/app/theme/ntp_header_background_hover.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/resources/ntp/most_visited.css
   M /trunk/src/chrome/browser/themes/browser_theme_provider.cc
   M /trunk/src/chrome/browser/themes/browser_theme_provider.h

Add an accordian effect to NTP.

BUG=53248

Review URL: http://codereview.chromium.org/3250002
------------------------------------------------------------------------
r57965 | aa@chromium.org | 2010-08-31 07:39:58 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_sidebar_api.cc
   M /trunk/src/chrome/browser/extensions/extension_sidebar_api.h
   M /trunk/src/chrome/browser/sidebar/sidebar_container.cc
   M /trunk/src/chrome/browser/sidebar/sidebar_container.h
   M /trunk/src/chrome/browser/sidebar/sidebar_manager.cc

Unify sidebar identification in the chrome.experimental.sidebar extension API implementation.

BUG=51084
TEST=Run interactive_ui_tests and browser_tests.

Review URL: http://codereview.chromium.org/3212005
Patch from Aleksey Shlyapnikov <alekseys@google.com>.
------------------------------------------------------------------------
r57959 | eroman@chromium.org | 2010-08-31 06:48:48 +0200 (Tue, 31 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/net/proxy/init_proxy_resolver.cc
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_service.cc

Refactor: Address a TODO about renaming a function.

Review URL: http://codereview.chromium.org/3216008
------------------------------------------------------------------------
r57957 | hbono@chromium.org | 2010-08-31 06:22:04 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

A quick fix for Bug 53559.
This change uses a scoped_ptr<FormStructure> variable instead of using a FormStructore pointer to avoid leaking FormStructore objects when continuing the loop in AutofillManager::ParseForms().

BUG=53559
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3245001
------------------------------------------------------------------------
r57955 | kinuko@chromium.org | 2010-08-31 06:07:29 +0200 (Tue, 31 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.h
   M /trunk/src/chrome/common/file_system/webfilesystem_impl.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/common/webkit_param_traits.h

Add final part of IPC plumbing for FileSystem API (retry).

Original issue: http://codereview.chromium.org/3208007/show
(Reverted due to rebase error)

BUG=32277
TEST=none; to be added when we have complete implementation.
TBR=phajdan-jr, michaeln

Review URL: http://codereview.chromium.org/3256006
------------------------------------------------------------------------
r57949 | eroman@chromium.org | 2010-08-31 05:48:34 +0200 (Tue, 31 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings_unittest.cc
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/proxyview.js
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_unittest.cc

Move the pretty-printing of proxy settings from the C++ code to javascript.

Also, the javascript version does some fancier output -- it now only displays the relevant fields, and numbers the fallback order.

Review URL: http://codereview.chromium.org/3219004
------------------------------------------------------------------------
r57941 | rafaelw@chromium.org | 2010-08-31 04:48:12 +0200 (Tue, 31 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_renderer_info.cc
   M /trunk/src/chrome/renderer/extensions/extension_renderer_info.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Reland r57788 - Expose Extension Bindings to Component Applications

This patch allows component (built-in) extension apps to have extension api bindings.

Note that this patch adds browser-side api permission checking for extension requests.

This is step two along the path to exposing an extension management api to the gallery (webstore).

Original Review: http://codereview.chromium.org/3163044
BUG=27431
TBR=mpcomplete

Review URL: http://codereview.chromium.org/3263007
------------------------------------------------------------------------
r57938 | jianli@chromium.org | 2010-08-31 04:42:36 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/file_util_proxy.cc
   M /trunk/src/base/file_util_proxy.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   A /trunk/src/chrome/browser/net/blob_url_request_job_factory.cc
   A /trunk/src/chrome/browser/net/blob_url_request_job_factory.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/webkit/blob/blob_data.cc
   M /trunk/src/webkit/blob/blob_data.h
   M /trunk/src/webkit/blob/blob_storage_controller.cc
   M /trunk/src/webkit/blob/blob_storage_controller.h
   M /trunk/src/webkit/blob/blob_storage_controller_unittest.cc
   A /trunk/src/webkit/blob/blob_url_request_job.cc
   A /trunk/src/webkit/blob/blob_url_request_job.h
   A /trunk/src/webkit/blob/blob_url_request_job_unittest.cc
   M /trunk/src/webkit/blob/webkit_blob.gypi
   M /trunk/src/webkit/glue/mock_resource_loader_bridge.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/support/webkit_support.gypi
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.h
   A /trunk/src/webkit/tools/test_shell/test_shell_webblobregistry_impl.cc
   A /trunk/src/webkit/tools/test_shell/test_shell_webblobregistry_impl.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Support handling blob URL and resolve blob references in upload data.

BUG=none
TEST=unittest

Review URL: http://codereview.chromium.org/3282003
------------------------------------------------------------------------
r57936 | mattm@chromium.org | 2010-08-31 04:36:38 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc

Fix linux and mac page info windows showing wrong status icons.

BUG=52916
TEST=load https://www.google.com, click on page info

Review URL: http://codereview.chromium.org/3250009
------------------------------------------------------------------------
r57934 | yusukes@chromium.org | 2010-08-31 04:17:05 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Add a string resource for xkb:il::heb.

BUG=chromium-os:6046
TEST=manually

Review URL: http://codereview.chromium.org/3218004
------------------------------------------------------------------------
r57925 | phajdan.jr@chromium.org | 2010-08-31 00:43:35 +0200 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_terms_data.cc

Fix compile bustage for levin.

TBR=levin

BUG=38475
TEST=compile please

Review URL: http://codereview.chromium.org/3280009
------------------------------------------------------------------------
r57924 | ananta@chromium.org | 2010-08-31 00:30:31 +0200 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Marking the ExtensionApiTest.Tabs test as flaky for Linux. This test now fails on the Linux dbg-shlib
builder as well.

Bug=48920
TBR=timsteele

Review URL: http://codereview.chromium.org/3262009
------------------------------------------------------------------------
r57923 | kinuko@chromium.org | 2010-08-31 00:30:12 +0200 (Tue, 31 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.h
   M /trunk/src/chrome/common/file_system/webfilesystem_impl.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/common/webkit_param_traits.h

Revert 57915 - Add final part of IPC plumbing for FileSystem API.

BUG=32277
TEST=none; to be added when we have complete implementation.

Review URL: http://codereview.chromium.org/3208007

TBR=kinuko@chromium.org,phajdan-jr
Review URL: http://codereview.chromium.org/3245010
------------------------------------------------------------------------
r57922 | evan@chromium.org | 2010-08-31 00:22:49 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/chromeos/google_update_chromeos.cc
   M /trunk/src/chrome/browser/chromeos/login/helper.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   A /trunk/src/chrome/browser/google
   A /trunk/src/chrome/browser/google/google_update.cc (from /trunk/src/chrome/browser/google_update.cc:57920)
   A /trunk/src/chrome/browser/google/google_update.h (from /trunk/src/chrome/browser/google_update.h:57920)
   A /trunk/src/chrome/browser/google/google_update_settings_posix.cc (from /trunk/src/chrome/browser/google_update_settings_posix.cc:57920)
   A /trunk/src/chrome/browser/google/google_update_settings_unittest.cc (from /trunk/src/chrome/browser/google_update_settings_unittest.cc:57920)
   A /trunk/src/chrome/browser/google/google_url_tracker.cc (from /trunk/src/chrome/browser/google_url_tracker.cc:57920)
   A /trunk/src/chrome/browser/google/google_url_tracker.h (from /trunk/src/chrome/browser/google_url_tracker.h:57920)
   A /trunk/src/chrome/browser/google/google_url_tracker_unittest.cc (from /trunk/src/chrome/browser/google_url_tracker_unittest.cc:57920)
   A /trunk/src/chrome/browser/google/google_util.cc (from /trunk/src/chrome/browser/google_util.cc:57920)
   A /trunk/src/chrome/browser/google/google_util.h (from /trunk/src/chrome/browser/google_util.h:57920)
   D /trunk/src/chrome/browser/google_update.cc
   D /trunk/src/chrome/browser/google_update.h
   D /trunk/src/chrome/browser/google_update_settings_posix.cc
   D /trunk/src/chrome/browser/google_update_settings_unittest.cc
   D /trunk/src/chrome/browser/google_url_tracker.cc
   D /trunk/src/chrome/browser/google_url_tracker.h
   D /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   D /trunk/src/chrome/browser/google_util.cc
   D /trunk/src/chrome/browser/google_util.h
   M /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.cc
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   M /trunk/src/chrome/browser/remoting/remoting_resources_source.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_browser_process.h

Move Google-specific code under browser/ into browser/google/.

BUG=50548
TEST=compiles

Review URL: http://codereview.chromium.org/3280008
------------------------------------------------------------------------
r57919 | jcivelli@chromium.org | 2010-08-31 00:20:14 +0200 (Tue, 31 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.h

Relanding this CL that was previously backed-out.
Fix the focus on post reload warning constrained window. The initial focus was not set to the right view.

TBR=chase
BUG=41926
TEST=Navigate to a page with a post. Reload the page. A constrained window with a warning that it is going to repost. The OK button should be focused. Pressing TAB should move the button to the next button. Pressing ESC should close the dialog.

Review URL: http://codereview.chromium.org/3238004

Review URL: http://codereview.chromium.org/3228004
------------------------------------------------------------------------
r57918 | levin@chromium.org | 2010-08-31 00:18:13 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map_unittest.cc
   A /trunk/src/chrome/browser/search_engines/search_terms_data.cc
   A /trunk/src/chrome/browser/search_engines/search_terms_data.h
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Allow one to call TemplateURLModel::GenerateSearchURL when not on the UI thread.

BUG=38475
TEST=unit_test --gtest_filter=Temp*

Review URL: http://codereview.chromium.org/3240005
------------------------------------------------------------------------
r57917 | thakis@chromium.org | 2010-08-31 00:17:18 +0200 (Tue, 31 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/labs.html

Use new labs_section on about:labs

BUG=53399
TEST=none
TBR=trungl
------------------------------------------------------------------------
r57916 | phajdan.jr@chromium.org | 2010-08-31 00:16:32 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   A /trunk/src/chrome/browser/download/download_prefs.cc
   A /trunk/src/chrome/browser/download/download_prefs.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTTF: Extract all preferences-related code from DownloadManager to DownloadPrefs.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3226010
------------------------------------------------------------------------
r57915 | kinuko@chromium.org | 2010-08-31 00:15:41 +0200 (Tue, 31 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   M /trunk/src/chrome/common/file_system/file_system_dispatcher.h
   M /trunk/src/chrome/common/file_system/webfilesystem_impl.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/common/webkit_param_traits.h

Add final part of IPC plumbing for FileSystem API.

BUG=32277
TEST=none; to be added when we have complete implementation.

Review URL: http://codereview.chromium.org/3208007
------------------------------------------------------------------------
r57908 | johnnyg@chromium.org | 2010-08-30 23:13:08 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view.mm

Mac notification UI improvements: reduce the roundedness of the corners from 8 to 6px, and remove the visible bounding box from the pressed state of the wrench icon.

BUG=52545
TEST=notifications on mac

Review URL: http://codereview.chromium.org/3270007
------------------------------------------------------------------------
r57907 | phajdan.jr@chromium.org | 2010-08-30 23:09:52 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

Make AutomationProvider fail fast on messages it doesn't understand.

This prevents an awful debugging experience where things just silently hang.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3224001
------------------------------------------------------------------------
r57904 | isherman@chromium.org | 2010-08-30 23:07:05 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/rand_util.cc
   M /trunk/src/base/rand_util.h
   M /trunk/src/base/rand_util_unittest.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/net/websockets/websocket_handshake.cc

Add RandomNumberGenerator adapter to base/rand_util.h

BUG=46679
TEST=none (yet...)

Review URL: http://codereview.chromium.org/3053050
------------------------------------------------------------------------
r57902 | mirandac@chromium.org | 2010-08-30 22:55:26 +0200 (Mon, 30 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h

Fix credit card table migration step by ensuring that we're not trying to add a column which is already present.  If we create a table as part of the init process, don't try to alter the table, because it already exists.

BUG=10913
TEST= search engine dialog works, search engines don't disappear.
Review URL: http://codereview.chromium.org/3239006
------------------------------------------------------------------------
r57901 | thakis@chromium.org | 2010-08-30 22:52:46 +0200 (Mon, 30 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/base/scoped_vector.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tabpose_window.h
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window_unittest.mm

Mac tabpose: Add thumbnails

Most things actually work.

Missing from this CL:
* Reloading thumbnails for tabs that change. This is required to show non-white thumbnails for thumbnails that are still waiting on the net when tabpose is opened.
* Showing infobars / bookmark bar in the thumbnail
* Showing accelerated surfaces (youtube videos on 10.6, compositor on 10.6)

BUG=50307
TEST=Enable tabpose. Should see thumbnails for all tabs (some loaded after a delay). Thumbnails should animate in correctly even if a tab has info bars, a detached NTP, or docked devtools. Tabs that haven't been frontmost since the window was last resized should look good. Opening many tabs and then immediately jumping into expose shouldn't crash.

Review URL: http://codereview.chromium.org/3163003
------------------------------------------------------------------------
r57898 | thakis@chromium.org | 2010-08-30 22:31:54 +0200 (Mon, 30 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabContents.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm

Sidebar view, Mac implementation (common sidebar code and Windows version is already submitted).
TabContents.xib changes: it was converted to the latest IB version and vertical NSSplitView was added to it
as a child for existing horizontal NSSplitView hosting devTools; new one hosts page content and sidebar content.
BrowserWindowCocoa instance listen to SIDEBAR_CHANGED notification and updates sidebar content view according
to the sidebar state linked to the current tab (adds or removes the corresponding view).
Sidebar API design doc: http://www.chromium.org/developers/design-documents/extensions/sidebar-extension-api.
BUG=51084
TEST=Run browser_tests and interactive_ui_tests.

Review URL: http://codereview.chromium.org/3228003
Patch from Aleksey Shlyapnikov <alekseys@chromium.org>.
------------------------------------------------------------------------
r57896 | erg@google.com | 2010-08-30 22:15:25 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_paths.cc
   M /trunk/src/app/gfx/gl/gl_implementation.cc
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/chrome/browser/prefs/command_line_pref_store.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate_mac.mm
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate_win.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   A /trunk/src/chrome/test/unit/chrome_test_suite.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome_frame/chrome_frame.gyp

FBTF: Move some heavy, repeatedly emitted symbols to implementation files.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3162047
------------------------------------------------------------------------
r57894 | pkasting@chromium.org | 2010-08-30 21:55:17 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc

Revert 57877 - Hide page actions and star, like we already do for content settings, when the user is editing the omnibox.

BUG=none
TEST=Typing in the omnibox should make all items on the right disappear, and make ctrl-d do nothing.
Review URL: http://codereview.chromium.org/3218002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3264005
------------------------------------------------------------------------
r57893 | ananta@chromium.org | 2010-08-30 21:43:07 +0200 (Mon, 30 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc

Disabling the TestCrossPlatformAccessibilityTree test on windows to prevent redness
due to the test timing out or crashing.

Bug=53853
TBR=dmazzoni

Review URL: http://codereview.chromium.org/3227004
------------------------------------------------------------------------
r57892 | phajdan.jr@chromium.org | 2010-08-30 21:42:43 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

GTTF: Disable hangy ExtensionApiTest.IncognitoDisabled

TBR=mpcomplete

TEST=browser_tests
BUG=53869

Review URL: http://codereview.chromium.org/3241006
------------------------------------------------------------------------
r57891 | ananta@chromium.org | 2010-08-30 21:36:28 +0200 (Mon, 30 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

Reverting to fix Chromium Arm compile failures. Please reland after fixing.

Revert 57885 - [GTK] a couple of constrained window fixes:

1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front.
2) handle escape via normal key handling rather than accelerator keys
3) don't allow the content view to take focus (via tab) when the constrained window is showing.

BUG=53242, 50799
TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected.

Review URL: http://codereview.chromium.org/3227003

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/3257005
------------------------------------------------------------------------
r57885 | estade@chromium.org | 2010-08-30 20:21:31 +0200 (Mon, 30 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

[GTK] a couple of constrained window fixes:

1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front.
2) handle escape via normal key handling rather than accelerator keys
3) don't allow the content view to take focus (via tab) when the constrained window is showing.

BUG=53242, 50799
TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected.

Review URL: http://codereview.chromium.org/3227003
------------------------------------------------------------------------
r57883 | ananta@chromium.org | 2010-08-30 20:09:18 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disabling the OpenTab, OpenPanel
 and PanelBeforeTab on Windows as well as they
randomly fail.

Bug=43061
TBR=skerner

Review URL: http://codereview.chromium.org/3252005
------------------------------------------------------------------------
r57881 | estade@chromium.org | 2010-08-30 20:01:37 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc

[GTK] fix alignment of an extension install UI string in RTL locales.

BUG=52857
TEST=test extension install with RTL locale in ubuntu 9.04+

Review URL: http://codereview.chromium.org/3240003
------------------------------------------------------------------------
r57880 | ananta@chromium.org | 2010-08-30 19:58:51 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc

Marking the TestCrossPlatformAccessibilityTree browser test as FAILS on Windows.

Bug=53853
TBR=dmazzoni

Review URL: http://codereview.chromium.org/3225006
------------------------------------------------------------------------
r57878 | pkasting@chromium.org | 2010-08-30 19:51:40 +0200 (Mon, 30 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Fix compile failure.

------------------------------------------------------------------------
r57877 | pkasting@chromium.org | 2010-08-30 19:44:13 +0200 (Mon, 30 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc

Hide page actions and star, like we already do for content settings, when the user is editing the omnibox.

BUG=none
TEST=Typing in the omnibox should make all items on the right disappear, and make ctrl-d do nothing.
Review URL: http://codereview.chromium.org/3218002
------------------------------------------------------------------------
r57873 | rlp@chromium.org | 2010-08-30 19:06:12 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

A new change for adding the about:gpu functionality. This change also adds about:gpu to about:about.

BUG=none
TEST=visual, usage

Review URL: http://codereview.chromium.org/3214007
------------------------------------------------------------------------
r57872 | bauerb@chromium.org | 2010-08-30 19:05:34 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Move --block-nonsandboxed-plugins command line switch to preferences.

BUG=53812
TEST=none

Review URL: http://codereview.chromium.org/3217009
------------------------------------------------------------------------
r57870 | mbelshe@chromium.org | 2010-08-30 18:56:56 +0200 (Mon, 30 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Remove the SetBackground call during process creation. The benefit
of the call is that we de-prioritize work that is in the background.
Unfortunately, tab creation currently bounces through hidden/unhidden/
hidden/unhidden at least 2x before the tab is visible to the user.
Because we don't know if the tab will be in the foreground (and thus
prevent it from being SetBackgrounded), the right thing to do is to
simply not Background it on startup.

BUG=21884
TEST=none

Review URL: http://codereview.chromium.org/3249006
------------------------------------------------------------------------
r57869 | mmenke@chromium.org | 2010-08-30 18:44:27 +0200 (Mon, 30 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   A /trunk/src/chrome/browser/resources/net_internals/socketsview.js
   M /trunk/src/chrome/browser/resources/net_internals/util.js
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_proxy_client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool.h
   M /trunk/src/net/socket/ssl_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool.h

Sockets page on net-internals now displays some information about the current socket pool state. Table padding slightly increased for legibility.

TEST=manual
BUG=39756
Review URL: http://codereview.chromium.org/3267002
------------------------------------------------------------------------
r57867 | suzhe@chromium.org | 2010-08-30 18:42:14 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h

[Linux]Workaround issue 50485

Please see http://crbug.com/50485 for details. This CL workarounds this issue by ignoring one "commit" signal triggered when resetting the gtk imcontext.

BUG=50485
TEST=See bug report.

Review URL: http://codereview.chromium.org/3214001
------------------------------------------------------------------------
r57866 | dmazzoni@chromium.org | 2010-08-30 18:40:37 +0200 (Mon, 30 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   A /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Add html node info (tag name, attributes, and computed display) and document
info (url, title, mimetype, doctype) to WebAccessibility.

BUG=none
TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility
TEST=Added new browser test: RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57188
Review URL: http://codereview.chromium.org/3013035
------------------------------------------------------------------------
r57865 | alyssad@google.com | 2010-08-30 18:35:31 +0200 (Mon, 30 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/functional/infobars.py
   M /trunk/src/chrome/test/functional/prefs.py
   M /trunk/src/chrome/test/functional/translate.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Fix pyauto wait until hooks to use client-side WaitUntil BUG=53647

Some hooks have small chances of race conditions that can cause hangs and test failures. Fix this by using the client-side WaitUntil for now.

Review URL: http://codereview.chromium.org/3222002
------------------------------------------------------------------------
r57863 | sky@chromium.org | 2010-08-30 18:10:31 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Removes unused field in LocationBarView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3245004
------------------------------------------------------------------------
r57861 | mnissler@chromium.org | 2010-08-30 17:38:18 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[mac] Properly update prefs window UI if managed preferences change.

Preferences.xib changes: Rename various binding targets.

BUG=53830, 53834
TEST=Mac prefs get disabled properly when configuration policy is in effect.

Review URL: http://codereview.chromium.org/3274006
------------------------------------------------------------------------
r57857 | mnissler@chromium.org | 2010-08-30 16:14:01 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Update password manager prefs UI on policy refresh.

Preferences.xib changes: Bind Enabled state of password manager radio matrix and button to the new @properties.

BUG=52830
TEST=Change password manager policy, watch preferences UI.

Review URL: http://codereview.chromium.org/3241005
------------------------------------------------------------------------
r57855 | skerner@chromium.org | 2010-08-30 15:35:39 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen_invalid.json

Remove full-screen launch option app.launch.fullscreen

BUG=42447
TEST=Load an extension with app.launch.fullscreen, saw that it had no effect.

Review URL: http://codereview.chromium.org/3275003
------------------------------------------------------------------------
r57853 | podivilov@chromium.org | 2010-08-30 15:05:59 +0200 (Mon, 30 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

TBR: enable SetBreakpoint test (fixed upstream)
------------------------------------------------------------------------
r57852 | thomasvl@chromium.org | 2010-08-30 14:51:49 +0200 (Mon, 30 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Update a crbug reference to point to the current bug tracking this test failure as the old one had been duped through things to this point.

BUG=38522
TEST=none
Review URL: http://codereview.chromium.org/3239007
------------------------------------------------------------------------
r57848 | dpolukhin@chromium.org | 2010-08-30 12:30:40 +0200 (Mon, 30 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/update_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Landing 3259001: Adds curtain screen with "Checking for updates..."

Original CL: http://codereview.chromium.org/3259001

Adds curtain screen with "Checking for updates..." label and throbber to update screen. Curtain screen is shown at most 15 secs.

BUG=hromium-os:2444
TEST=Go through updating process and notice that first 15 seconds only spinner with "Checking for updates..." label is shown. After 15 seconds usual update progress screen is shown.

Review URL: http://codereview.chromium.org/3275004
------------------------------------------------------------------------
r57841 | thakis@chromium.org | 2010-08-30 10:33:17 +0200 (Mon, 30 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm

Mac: Fix a crash on "Look Up in Dictionary" context menu.
- Add [NSPasteboard declareTypes] invocation before [NSPasteboard setData],
  which is required on Loopard. (and not required SL.)
- Fixed a potential leak, using scoped_nsobject.

BUG=53519
TEST=manual

Review URL: http://codereview.chromium.org/3217006
Patch from Hamaji Morita <morrita@chromium.org>.
------------------------------------------------------------------------
r57840 | dpolukhin@chromium.org | 2010-08-30 10:24:40 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/default_extensions/chromeos
   A /trunk/src/chrome/browser/extensions/default_extensions/chromeos/external_extensions.json
   M /trunk/src/chrome/chrome.gyp

Added default extensions for Chrome OS

BUG=chromium-os:6079
TEST=Login on Chrome OS and see list of extensions installed (won't work without changes in ebuild file)

Review URL: http://codereview.chromium.org/3251001
------------------------------------------------------------------------
r57838 | aa@chromium.org | 2010-08-30 08:29:34 +0200 (Mon, 30 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Whoops. Try again to disable a failing test.

TBR=asargent@chromium.org
BUG=53779
------------------------------------------------------------------------
r57837 | mbelshe@chromium.org | 2010-08-30 08:07:58 +0200 (Mon, 30 Aug 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Revert 57836 - Remove the SetBackground call during process creation.  The benefit
of the call is that we de-prioritize work that is in the background.
Unfortunately, tab creation currently bounces through hidden/unhidden/
hidden/unhidden at least 2x before the tab is visible to the user.
Because we don't know if the tab will be in the foreground (and thus
prevent it from being SetBackgrounded), the right thing to do is to
simply not Background it on startup.

I will test to see if this effects startup performance on the build
bots.  I wouldn't be surprised if it did, nor would I be surprised
if it had no effect!

NOTE: I'm uploading this as a test run through the performance bots.
I will revert this change.

BUG=21884
TEST=none


Review URL: http://codereview.chromium.org/3288001

TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/3263006
------------------------------------------------------------------------
r57836 | mbelshe@chromium.org | 2010-08-30 08:02:56 +0200 (Mon, 30 Aug 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Remove the SetBackground call during process creation.  The benefit
of the call is that we de-prioritize work that is in the background.
Unfortunately, tab creation currently bounces through hidden/unhidden/
hidden/unhidden at least 2x before the tab is visible to the user.
Because we don't know if the tab will be in the foreground (and thus
prevent it from being SetBackgrounded), the right thing to do is to
simply not Background it on startup.

I will test to see if this effects startup performance on the build
bots.  I wouldn't be surprised if it did, nor would I be surprised
if it had no effect!

NOTE: I'm uploading this as a test run through the performance bots.
I will revert this change.

BUG=21884
TEST=none


Review URL: http://codereview.chromium.org/3288001
------------------------------------------------------------------------
r57834 | viettrungluu@chromium.org | 2010-08-30 07:31:40 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/app/tree_model.h
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/app/tree_node_model_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.cc
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_node_applescript.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/collected_cookies_mac.mm
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc
   M /trunk/src/chrome/browser/dom_ui/cookies_view_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/model_test_utils.cc

Remove the wstring TreeModelNode::GetTitle() and rename GetTitleAsString16() to GetTitle().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3279005
------------------------------------------------------------------------
r57831 | asargent@chromium.org | 2010-08-30 07:10:46 +0200 (Mon, 30 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_event_names.cc
   M /trunk/src/chrome/browser/extensions/extension_event_names.h
   M /trunk/src/chrome/browser/extensions/extension_management_api.cc
   M /trunk/src/chrome/browser/extensions/extension_management_api.h
   A /trunk/src/chrome/browser/extensions/extension_management_api_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.management.html
   M /trunk/src/chrome/test/data/extensions/api_test/management/test/basics.js
   M /trunk/src/chrome/test/data/extensions/api_test/management/test/common.js
   M /trunk/src/chrome/test/data/extensions/api_test/management/test/uninstall.js
   A /trunk/src/chrome/test/data/extensions/management
   A /trunk/src/chrome/test/data/extensions/management/install_event
   A /trunk/src/chrome/test/data/extensions/management/install_event/background.html
   A /trunk/src/chrome/test/data/extensions/management/install_event/manifest.json
   A /trunk/src/chrome/test/data/extensions/management/install_event/test.js

Implement events for extensions management API.

BUG=51178
TEST=The events described in the experimental.management API should fire for
extensions and apps being installed, uninstalled, enabled, and disabled.


Review URL: http://codereview.chromium.org/3278003
------------------------------------------------------------------------
r57829 | viettrungluu@chromium.org | 2010-08-30 06:49:56 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/net/base/net_util.h

Convert a bunch of uses of the wstring net::FormatUrl() to the new string16 one.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3287002
------------------------------------------------------------------------
r57827 | yusukes@chromium.org | 2010-08-30 03:41:07 +0200 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/language_preferences_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc

Remove DOMUI and Views settings for key repeat rate and delay, change the default values instead.

BUG=chromium-os:5933
TEST=manually

Review URL: http://codereview.chromium.org/3181035
------------------------------------------------------------------------
r57824 | aa@chromium.org | 2010-08-30 01:08:17 +0200 (Mon, 30 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Disable ExtensionApiTest.Tabs on mac.

TBR=erikkay@chromium.org
BUG=53779
------------------------------------------------------------------------
r57815 | levin@chromium.org | 2010-08-29 19:16:13 +0200 (Sun, 29 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.cc
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.h
   M /trunk/src/chrome/browser/search_engines/search_host_to_urls_map_unittest.cc
   A /trunk/src/chrome/browser/search_engines/search_provider_install_data.h
   M /trunk/src/chrome/chrome_browser.gypi

Add code to get the search provider install state.

BUG=38475
TEST=unit_test --gtest_filter=SearchHost*

Review URL: http://codereview.chromium.org/3269001
------------------------------------------------------------------------
r57800 | viettrungluu@chromium.org | 2010-08-29 02:45:28 +0200 (Sun, 29 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_node_applescript.mm
   M /trunk/src/chrome/browser/dom_ui/cookies_view_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc

Remove wstrings from bookmarks, part 17.

This converts lots of (wstring) GetTitle()s to (string16) GetTitleAsString16().
Soon, I'll be able to delete the former, and rename the latter (s/AsString16//).

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3226004
------------------------------------------------------------------------
r57799 | aa@chromium.org | 2010-08-29 02:35:01 +0200 (Sun, 29 Aug 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/app/theme/extension_default_icon.png (from /trunk/src/chrome/browser/resources/extension_default_icon.png:57795)
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   D /trunk/src/chrome/browser/resources/extension_default_icon.png
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Add the collapsed 'miniview' to the apps and most visisted sections. Also, fix the bug where the wrench disappears on hover.

BUG=53248,52199

Review URL: http://codereview.chromium.org/3236001
------------------------------------------------------------------------
r57794 | danno@chromium.org | 2010-08-29 00:32:00 +0200 (Sun, 29 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h

Modify the policy to disable plugins to support TYPE_LIST values

BUG=51897
TEST=ConfigurationPolicyProviderWinTest.*

Review URL: http://codereview.chromium.org/3133012
------------------------------------------------------------------------
r57789 | rafaelw@chromium.org | 2010-08-28 19:05:51 +0200 (Sat, 28 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_renderer_info.cc
   M /trunk/src/chrome/renderer/extensions/extension_renderer_info.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Revert 57788 - Expose Extension Bindings to Component Applications

This patch allows component (built-in) extension apps to have extension api bindings.

Note that this patch adds browser-side api permission checking for extension requests.

This is step two along the path to exposing an extension management api to the gallery (webstore).

BUG=27431

Review URL: http://codereview.chromium.org/3163044

TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/3249004
------------------------------------------------------------------------
r57788 | rafaelw@chromium.org | 2010-08-28 18:20:47 +0200 (Sat, 28 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_renderer_info.cc
   M /trunk/src/chrome/renderer/extensions/extension_renderer_info.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Expose Extension Bindings to Component Applications

This patch allows component (built-in) extension apps to have extension api bindings.

Note that this patch adds browser-side api permission checking for extension requests.

This is step two along the path to exposing an extension management api to the gallery (webstore).

BUG=27431

Review URL: http://codereview.chromium.org/3163044
------------------------------------------------------------------------
r57787 | agl@chromium.org | 2010-08-28 17:53:50 +0200 (Sat, 28 Aug 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/net/base/cert_verify_result.h
   M /trunk/src/net/base/dnssec_chain_verifier.cc
   M /trunk/src/net/base/dnssec_chain_verifier.h
   M /trunk/src/net/base/dnssec_unittest.cc
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_client_socket.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   M /trunk/src/net/socket/ssl_client_socket_pool.cc
   M /trunk/src/net/socket/ssl_client_socket_pool.h

https: add support for DNS exclusion and switch to TXT records.

(This code has no effect unless --enable-dnssec-certs is given.)

The existing DNSSEC code will process embeded chains in certificates
and validate CERT records there in. The format of the CERT record was
just something made up as a proof of concept. This change switches
that code to using TXT records which are at least used by some other
code.

Additionally, when --enable-dnssec-certs is given. TXT record lookups
are triggered for each HTTPS connection. If DNSSEC secure, these
lookups can validate a HTTPS certificate. Even without DNSSEC, they
can by used for exclusion: if TLS fingerprints are given, but the
certificate doesn't match any of them, then the certificate is
rejected.

The next step in this series will be to perform the TXT lookup for
some percentage of dev channel users in order to measure the latency
impact. For this experiment, all behavioural changes will be disabled.

BUG=none
TEST=net_unittests

http://codereview.chromium.org/3148037/show
------------------------------------------------------------------------
r57785 | rohitrao@chromium.org | 2010-08-28 17:04:02 +0200 (Sat, 28 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

[Mac] Close file select dialogs when windows go away.

BUG=53361
TEST=Testcase in bug.
Review URL: http://codereview.chromium.org/3216004
------------------------------------------------------------------------
r57781 | satish@chromium.org | 2010-08-28 10:29:40 +0200 (Sat, 28 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/speech/enable_speech_input_switch_browsertest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Enable speech input by default on windows.
Makes --enable-speech-input with available only on non-windows builds
and adds --disable-speech-input for windows.

BUG=none
TEST=browser_tests --gtest_filter="SpeechInputBrowserTest.*"

Review URL: http://codereview.chromium.org/3261001
------------------------------------------------------------------------
r57780 | satish@chromium.org | 2010-08-28 09:17:38 +0200 (Sat, 28 Aug 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/SpeechInputBubble.xib
   A /trunk/src/chrome/browser/cocoa/speech_input_window_controller.h
   A /trunk/src/chrome/browser/cocoa/speech_input_window_controller.mm
   M /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   A /trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm
   A /trunk/src/chrome/browser/speech/speech_input_bubble_win.cc (from /trunk/src/chrome/browser/views/speech_input_bubble_view.cc:57779)
   D /trunk/src/chrome/browser/views/speech_input_bubble_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi

Implement the speech input bubble on mac.
This is a popup which gets displayed below an <input> element when the user starts speech recognition on it. It displays a recognition status icon, an instruction label ('Speak now') at the top and a Cancel button at the bottom. The speech input module gets callbacks on user actions such as clicking Cancel or clicking any other window, and on both cases recognition stops and the bubble closes.

TEST=manual, run chromium on mac and click on the mic button in a speech enabled input element to see the bubble appear.
BUG=53598

Review URL: http://codereview.chromium.org/3214006
------------------------------------------------------------------------
r57779 | atwilson@chromium.org | 2010-08-28 08:16:31 +0200 (Sat, 28 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Hide mac background mode prefs ui if background mode is not enabled.

Change to Preferences.xib: Setup preferences_window_controller.mm as a referencing outlet for the background mode UI so we can hide it.

BUG=53522
TEST=run chrome without --enable-background-mode, make sure associated prefs UI is not shown

Review URL: http://codereview.chromium.org/3246004
------------------------------------------------------------------------
r57778 | atwilson@chromium.org | 2010-08-28 08:13:30 +0200 (Sat, 28 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/background_mode_manager_unittest.cc
   M /trunk/src/chrome/browser/profile_impl.cc

Disable background mode when associated pref changes.

BUG=53173
TEST=new BackgroundModeManager unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57642

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57749

Review URL: http://codereview.chromium.org/3205008
------------------------------------------------------------------------
r57775 | eroman@chromium.org | 2010-08-28 05:34:11 +0200 (Sat, 28 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js

fix a regression whereby the display of proxy settings got broken in text dump on about:net-internals.

BUG=53673
TBR=rvargas
Review URL: http://codereview.chromium.org/3216009
------------------------------------------------------------------------
r57767 | eroman@chromium.org | 2010-08-28 03:17:56 +0200 (Sat, 28 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/browser/resources/net_internals/proxyview.js
   M /trunk/src/net/proxy/init_proxy_resolver.cc
   M /trunk/src/net/proxy/init_proxy_resolver.h
   M /trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h

Display the "effective" proxy settings in about:net-internals.

The "effective" settings is what you get after applying the various fallbacks between automatic and manual settings.

This display makes it easier to notice whether "auto-detect" actually took effect, and if so what was the PAC URL it used.

BUG=53549
TEST=On windows change your proxy settings to include both auto-detect, a custom pac script, and some manually configured proxy servers. Now run chrome and go to the proxy tab on about:net-internals. Check that the "original" settings is what you entered in the dialog box, however the "effective" settings will only be a subset of them.
Review URL: http://codereview.chromium.org/3241002
------------------------------------------------------------------------
r57763 | rickcam@chromium.org | 2010-08-28 02:51:09 +0200 (Sat, 28 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc

Implemented Launch-on-OS-login on Windows

BUG=43382
TEST=none

Review URL: http://codereview.chromium.org/3140033
------------------------------------------------------------------------
r57760 | estade@chromium.org | 2010-08-28 02:48:22 +0200 (Sat, 28 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util_unittest.cc

Expand tar.gz download workaround to work for tgz as well.

BUG=52250
TEST=included

Review URL: http://codereview.chromium.org/3173048
------------------------------------------------------------------------
r57759 | estade@chromium.org | 2010-08-28 02:36:16 +0200 (Sat, 28 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

fix views build

MINIMALBUBBLE -> MINIMAL_BUBBLE

TBR=dmazzoni

Review URL: http://codereview.chromium.org/3286001
------------------------------------------------------------------------
r57758 | tfarina@chromium.org | 2010-08-28 02:31:53 +0200 (Sat, 28 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/base/registry.h
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

Reland r57575 - Remove the default argument from RegKey::Open.

This fix the bad rebase conflict.

BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*

Review URL: http://codereview.chromium.org/3185032
------------------------------------------------------------------------
r57757 | estade@chromium.org | 2010-08-28 02:28:35 +0200 (Sat, 28 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.h

[GTK] fix extension install bubble positioning.

This should fix the position of the extension install bubble for both visible and overflow browser actions.

Mirrors the approach used on windows.

BUG=53326
TEST=manual

Review URL: http://codereview.chromium.org/3218001
------------------------------------------------------------------------
r57756 | prasadt@chromium.org | 2010-08-28 02:26:37 +0200 (Sat, 28 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Create an instance of AtExitManager before relaunching the browser on Windows.  This is needed for two reasons:
1) The RelaunchChromeBrowserWithNewCommandLineIfNeeded() code path on Windows invokes Singleton<PathData>::get()
   to get the module.  This in turn requires an  instance of AtExitManager to be present, as it manages the
   lifetime of singletons.
2) The point at which the RelaunchChromeBrowserWithNewCommandLineIfNeeded() is invoked we return from
   ChromeMain and thus the instance of AtExitManager that belongs to chrome.dll is already deleted.
3) Note that there is another instance of AtExitManager that's instantiated in wWinMain() that's still alive.
   But the scope of that is in chrome.exe and not chrome.dll, and hence is not visible to the code in
   RelaunchChromeBrowserWithNewCommandLineIfNeeded().

BUG=none 
TEST=On Windows - Change BrowserProcessImpl::StartAutoupdateTimer() function to 
change the timer from 6hrs to 30 seconds. Build and run chrome with 
--no-startup-window and --keep-alive-for-test flags. Copy chrome.exe to new_chrome.exe 
to fake an update. Wait for 30 seconds and verify that the browser shuts 
down and restarts.  Also verify that new_chrome.exe is deleted and there is an old_chrome.exe.

Review URL: http://codereview.chromium.org/3104037
------------------------------------------------------------------------
r57755 | estade@chromium.org | 2010-08-28 02:24:50 +0200 (Sat, 28 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

[GTK] implement minimal first run bubble.

This is the type of bubble now used in organic installs, i.e. all Linux installs.

BUG=49705
TEST=run with --first-run

Review URL: http://codereview.chromium.org/3203013
------------------------------------------------------------------------
r57754 | dmazzoni@chromium.org | 2010-08-28 02:15:22 +0200 (Sat, 28 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Mark interactive test as FAILS because it's failing on the
interactive ui bots.

BUG=53664
TEST=Mark DevToolsSanityTest.TestExpandScope as FAILS
TBR=chase@chromium.org

Review URL: http://codereview.chromium.org/3269002
------------------------------------------------------------------------
r57752 | atwilson@chromium.org | 2010-08-28 01:44:55 +0200 (Sat, 28 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/background_mode_manager_unittest.cc

Revert 57749 - Disable background mode when associated pref changes.
Disabling because new tests don't work now that BackgroundModeManager is
disabled by default from r57713.

BUG=53173
TEST=new BackgroundModeManager unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57642

Review URL: http://codereview.chromium.org/3205008

TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/3223008
------------------------------------------------------------------------
r57751 | dmazzoni@chromium.org | 2010-08-28 01:19:51 +0200 (Sat, 28 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm

Disable test that's been crashing.

BUG=49522
TEST=Disables AutocompleteTextFieldEditorTest.AddRemoveAutocompleteTextFieldEditorTest and AutocompleteTextFieldEditorTest.DisplayAutocompleteTextFieldEditorTest
TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/3229005
------------------------------------------------------------------------
r57749 | atwilson@chromium.org | 2010-08-28 01:17:23 +0200 (Sat, 28 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/background_mode_manager_unittest.cc

Disable background mode when associated pref changes.

BUG=53173
TEST=new BackgroundModeManager unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57642

Review URL: http://codereview.chromium.org/3205008
------------------------------------------------------------------------
r57747 | zelidrag@chromium.org | 2010-08-28 01:13:52 +0200 (Sat, 28 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.h

Fixed crashes cause by the lack of chromeos settings observer cleanup logic.

TEST=make sure crashes from these two bugs are not in the next dev release
BUG=chromium-os:6129,chromium-os:6130

Review URL: http://codereview.chromium.org/3231001
------------------------------------------------------------------------
r57743 | levin@chromium.org | 2010-08-28 00:55:56 +0200 (Sat, 28 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc

Address feedback regarding r57641.

BUG=53557
TEST=unit_tests --gtest_filter=TemplateURLModelTest.LoadDoesAutoKeywordUpdate

Review URL: http://codereview.chromium.org/3237002
------------------------------------------------------------------------
r57739 | chase@chromium.org | 2010-08-28 00:50:59 +0200 (Sat, 28 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.h

Revert 57726 - Fix the focus on post reload warning constrained window.
The initial focus was not set to the right view.

BUG=41926
TEST=Navigate to a page with a post. Reload the page. A constrained window with a warning that it is going to repost. The OK button should be focused. Pressing TAB should move the button to the next button. Pressing ESC should close the dialog.

Review URL: http://codereview.chromium.org/3238004

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3265004
------------------------------------------------------------------------
r57733 | kinuko@chromium.org | 2010-08-27 23:24:43 +0200 (Fri, 27 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   A /trunk/src/chrome/browser/file_system/file_system_host_context.cc
   A /trunk/src/chrome/browser/file_system/file_system_host_context.h
   A /trunk/src/chrome/browser/file_system/file_system_host_context_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.h

Add a helper class that keeps per-profile information for FileSystem API

Reapplying with the correct constructor order in resource_message_filter.

The original one was: http://codereview.chromium.org/3028033
Reverted due to rebase/merge failure: http://codereview.chromium.org/3243005

BUG=32277
TEST=FileSystemHostContextTest
TBR=dmazzoni

Review URL: http://codereview.chromium.org/3244002
------------------------------------------------------------------------
r57728 | evan@chromium.org | 2010-08-27 23:09:07 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/labs.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Fix official build.

I changed the type of this function, but the trybots didn't catch
it because it's in an offical-only ifdef.

Review URL: http://codereview.chromium.org/3236006
------------------------------------------------------------------------
r57727 | chase@chromium.org | 2010-08-27 23:05:28 +0200 (Fri, 27 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   D /trunk/src/chrome/browser/extensions/extension_tts_api_gtk.cc
   D /trunk/src/chrome/browser/extensions/extension_tts_api_mac.mm
   D /trunk/src/chrome/browser/extensions/extension_tts_api_win.cc
   M /trunk/src/chrome/browser/extensions/extension_tts_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert 57701 - Reland 3149027.
Review URL: http://codereview.chromium.org/3236004

Broke ChromiumOS browser_tests in ExtensionApiTest.Tts.

TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/3224003
------------------------------------------------------------------------
r57726 | jcivelli@chromium.org | 2010-08-27 22:33:03 +0200 (Fri, 27 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.h

Fix the focus on post reload warning constrained window.
The initial focus was not set to the right view.

BUG=41926
TEST=Navigate to a page with a post. Reload the page. A constrained window with a warning that it is going to repost. The OK button should be focused. Pressing TAB should move the button to the next button. Pressing ESC should close the dialog.

Review URL: http://codereview.chromium.org/3238004
------------------------------------------------------------------------
r57725 | evan@chromium.org | 2010-08-27 22:28:42 +0200 (Fri, 27 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/dom_ui/about_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/memory_details_mac.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/platform_util_common_linux.cc
   M /trunk/src/chrome/browser/platform_util_mac.mm
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/common/chrome_version_info.cc
   M /trunk/src/chrome/common/chrome_version_info.h
   M /trunk/src/chrome/common/chrome_version_info_posix.h.version
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome_frame/metrics_service.cc

Refactor version-getting info into a chrome::VersionInfo object.

I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear.  95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.

We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.

Review URL: http://codereview.chromium.org/3135028
------------------------------------------------------------------------
r57723 | stuartmorgan@chromium.org | 2010-08-27 21:57:37 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.h
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.h
   M /trunk/src/chrome/browser/views/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h

Remove wstring from the search engine management APIs

This stops short of doing a wstring -> string16 conversion in template_url and template_url_model since that would ripple through the omnibox and auto-search-detection code, making the change much larger and more complicated.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3245002
------------------------------------------------------------------------
r57721 | hans@chromium.org | 2010-08-27 21:52:36 +0200 (Fri, 27 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/device_orientation/accelerometer_mac.cc
   M /trunk/src/chrome/browser/device_orientation/accelerometer_mac.h

Added tested and corrected accelerometer support for the following MacBook / MacBook Pro models:

- MacBookPro2,2
- MacBookPro3,1
- MacBookPro4,1
- MacBookPro5,1
- MacBookPro6,2
- MacBookPro7,1

This patch fixes the axis inversion problems on these.

Landing for Leandro Gracia Gil <leandrogracia@google.com>.
Original code review: http://codereview.chromium.org/3177035/show

BUG=44654
TEST=None

Review URL: http://codereview.chromium.org/3275002
------------------------------------------------------------------------
r57720 | atwilson@chromium.org | 2010-08-27 21:46:42 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service_unittest.cc

Remove keepalive code from BackgroundContentsService

BUG=53602
TEST=Updated BackgroundContentsService unittests

Review URL: http://codereview.chromium.org/3234003
------------------------------------------------------------------------
r57719 | hans@chromium.org | 2010-08-27 21:44:50 +0200 (Fri, 27 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/device_orientation/provider.cc
   M /trunk/src/chrome/browser/device_orientation/provider.h
   M /trunk/src/chrome/browser/device_orientation/provider_impl.cc
   M /trunk/src/chrome/browser/device_orientation/provider_impl.h
   M /trunk/src/chrome/browser/device_orientation/provider_unittest.cc

Fix DeviceOrientationProviderTest.

There was a race that could potentially result in a reference to Provider being
left after a test finished, causing the next test to fail. The test must not
assume that the orientation update notification is posted on the message loop
right away, but rather wait for it.

I was not able to reproduce the bug, but I believe this should fix it.

BUG=53468
TEST=unit_tests --gtest_filter=DeviceOrientationProviderTest*

Review URL: http://codereview.chromium.org/3231003
------------------------------------------------------------------------
r57718 | dmazzoni@chromium.org | 2010-08-27 21:40:23 +0200 (Fri, 27 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   D /trunk/src/chrome/browser/file_system/file_system_host_context.cc
   D /trunk/src/chrome/browser/file_system/file_system_host_context.h
   D /trunk/src/chrome/browser/file_system/file_system_host_context_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.h

Revert 57715 - Add a helper class that keeps per-profile information for FileSystem API

BUG=32277
TEST=FileSystemHostContextTest

Review URL: http://codereview.chromium.org/3028033

TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/3243005
------------------------------------------------------------------------
r57715 | kinuko@chromium.org | 2010-08-27 21:23:09 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   A /trunk/src/chrome/browser/file_system/file_system_host_context.cc
   A /trunk/src/chrome/browser/file_system/file_system_host_context.h
   A /trunk/src/chrome/browser/file_system/file_system_host_context_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.h

Add a helper class that keeps per-profile information for FileSystem API

BUG=32277
TEST=FileSystemHostContextTest

Review URL: http://codereview.chromium.org/3028033
------------------------------------------------------------------------
r57713 | atwilson@chromium.org | 2010-08-27 20:53:52 +0200 (Fri, 27 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Disable BackgroundModeManager by default for M7, and add an --enable-background-mode
command line flag to enable it.

Also remove related preferences items if the --enable-background-mode flag is not passed.

BUG=53522
TEST=BackgroundModeManager unit tests pass, run without flag and look at preferences dialog to make sure preferences are not there, launch chrome with --keep-alive-for-test flag, see that no status icon appears

Review URL: http://codereview.chromium.org/3219001
------------------------------------------------------------------------
r57712 | thakis@chromium.org | 2010-08-27 20:48:24 +0200 (Fri, 27 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/labs.cc

Call side tabs "Side Tabs" in labs.

BUG=TEST=none

Review URL: http://codereview.chromium.org/3241004
------------------------------------------------------------------------
r57707 | jianli@chromium.org | 2010-08-27 20:29:24 +0200 (Fri, 27 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/DEPS
   A /trunk/src/chrome/browser/chrome_blob_storage_context.cc
   A /trunk/src/chrome/browser/chrome_blob_storage_context.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   A /trunk/src/chrome/browser/renderer_host/blob_dispatcher_host.cc
   A /trunk/src/chrome/browser/renderer_host/blob_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/webblobregistry_impl.cc
   A /trunk/src/chrome/common/webblobregistry_impl.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/net/base/upload_data.cc
   M /trunk/src/net/base/upload_data.h
   A /trunk/src/webkit/blob
   A /trunk/src/webkit/blob/blob_data.cc
   A /trunk/src/webkit/blob/blob_data.h
   A /trunk/src/webkit/blob/blob_storage_controller.cc
   A /trunk/src/webkit/blob/blob_storage_controller.h
   A /trunk/src/webkit/blob/blob_storage_controller_unittest.cc
   A /trunk/src/webkit/blob/webkit_blob.gypi
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/support/webkit_support.gyp
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Support sending BlobData to browser process. Also support sending UploadData
with the blob info to browser process.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3108042
------------------------------------------------------------------------
r57706 | mrossetti@chromium.org | 2010-08-27 20:26:44 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   A /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data. Eliminated DCHECKs which were surrounding 'release' code and causing release failures.

[Previously reviewed as: http://codereview.chromium.org/3138006.]

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3263002
------------------------------------------------------------------------
r57704 | dmazzoni@chromium.org | 2010-08-27 20:19:24 +0200 (Fri, 27 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc

Disable test on Linux after it timed out once.

BUG=53607
TEST=Disables TemplateURLModelTest.MAYBE_Load on Linux
TBR=levin@chromium.org

Review URL: http://codereview.chromium.org/3243004
------------------------------------------------------------------------
r57701 | dtseng@chromium.org | 2010-08-27 20:07:40 +0200 (Fri, 27 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api_gtk.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api_mac.mm
   A /trunk/src/chrome/browser/extensions/extension_tts_api_win.cc
   M /trunk/src/chrome/browser/extensions/extension_tts_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Reland 3149027.
Review URL: http://codereview.chromium.org/3236004
------------------------------------------------------------------------
r57699 | dimich@chromium.org | 2010-08-27 19:55:54 +0200 (Fri, 27 Aug 2010) | 23 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Re-land. Fixed previous errors.

Implement OSX version for "Start on Login" for background-enabled extensions.

When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List".

Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon.

Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case.

Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion.

Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX.

BUG=43382
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569
Reverted
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57614
Reverted

Review URL: http://codereview.chromium.org/3163029
------------------------------------------------------------------------
r57698 | levin@chromium.org | 2010-08-27 19:55:44 +0200 (Fri, 27 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller_unittest.cc
   A /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.cc
   A /trunk/src/chrome/browser/search_engines/search_host_to_urls_map.h
   A /trunk/src/chrome/browser/search_engines/search_host_to_urls_map_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/util.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Separate the "search host to TemplateURL" functionality out of the TemplateURLModel.

This separation allows for a smaller surface area which can be made read-only
thread-safe so that the question "IsSearchProviderInstalled" can be answered
from the I/O thread. The method to that answer question is not in this patch,
but this is the underlying mechanics that is necessary.

BUG=38475
TEST=unit_test --gtest_filter=Keyword* or Template* or SearchHost*

Review URL: http://codereview.chromium.org/3247003
------------------------------------------------------------------------
r57695 | cbentzel@chromium.org | 2010-08-27 19:35:02 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_auth_filter.cc
   M /trunk/src/net/http/http_auth_filter.h
   M /trunk/src/net/http/http_auth_filter_unittest.cc
   M /trunk/src/net/http/http_auth_gssapi_posix.cc
   M /trunk/src/net/http/http_auth_gssapi_posix.h
   M /trunk/src/net/http/http_auth_handler_negotiate.cc
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   M /trunk/src/net/http/http_auth_sspi_win.cc
   M /trunk/src/net/http/http_auth_sspi_win.h
   M /trunk/src/net/http/url_security_manager.cc
   M /trunk/src/net/http/url_security_manager.h
   M /trunk/src/net/http/url_security_manager_posix.cc
   M /trunk/src/net/http/url_security_manager_unittest.cc
   M /trunk/src/net/http/url_security_manager_win.cc

Add support for delegated kerberos tickets to Negotiate authentication.

This is controlled by the --auth-negotiate-delegate-whitelist command line. By default no servers are delegated to.

BUG=50076
TEST=net_unittests, go to an IIS server specified in --auth-negotiate-delegate-whitelist and see if this works correctly.

Review URL: http://codereview.chromium.org/3155046
------------------------------------------------------------------------
r57694 | rdsmith@chromium.org | 2010-08-27 19:25:38 +0200 (Fri, 27 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/a11y.html
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/contextMenus.html
   M /trunk/src/chrome/common/extensions/docs/cookies.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/docs.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html
   M /trunk/src/chrome/common/extensions/docs/experimental.cookies.html
   M /trunk/src/chrome/common/extensions/docs/experimental.history.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/experimental.idle.html
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/experimental.management.html
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/common/extensions/docs/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/experimental.proxy.html
   M /trunk/src/chrome/common/extensions/docs/experimental.sidebar.html
   M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   M /trunk/src/chrome/common/extensions/docs/experimental.webRequest.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/external_extensions.html
   M /trunk/src/chrome/common/extensions/docs/faq.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/idle.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/messaging.html
   M /trunk/src/chrome/common/extensions/docs/notifications.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/options.html
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   M /trunk/src/chrome/common/extensions/docs/samples.json
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/tut_analytics.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tut_oauth.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/whats_new.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/api/tab.html
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

Change, unify, and specify ordering of cookies from CookieMonster.
Affected interfaces:
	* GetCookiesWithOptions (used by HTTP requests)
	* GetAllCookiesForURL (used by extensions and Cookies UI)
	* GetAllCookies (used by Cookies UI).

BUG=8850 (indirectly)
TEST=Standard cookie monster tests, unit_tests::CookiesTreeModelTest.OriginOrdering, browser_tests::ExtensionApiTest.Cookies

Review URL: http://codereview.chromium.org/3170034
------------------------------------------------------------------------
r57693 | erikkay@chromium.org | 2010-08-27 19:19:39 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/renderer/extensions/chrome_app_bindings.cc

fix browsertest failure
TBR=skerner
BUG=none
TEST=ExtensionBrowserTest.PropertyAppIsInstalled

Review URL: http://codereview.chromium.org/3273001
------------------------------------------------------------------------
r57689 | atwilson@chromium.org | 2010-08-27 18:46:03 +0200 (Fri, 27 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Implements preference setting to allow enabling/disabling the
BackgroundModeManager, to match the gtk/windows versions. Checkbox
sets/clears the kBackgroundModeEnabled preference.

Preferences.xib change: Added new section to under-the-hood,
with a checkbox to enable/disable BackgroundModeManager (which
controls launch-on-login behavior), as well as a link to the help
center section for this feature.

BUG=53173
TEST=Adding BackgroundModeManagerTest.* in separate BackgroundModeManager CL.

Review URL: http://codereview.chromium.org/3199021
------------------------------------------------------------------------
r57688 | phajdan.jr@chromium.org | 2010-08-27 18:27:15 +0200 (Fri, 27 Aug 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/download/base_file.cc (from /trunk/src/chrome/browser/download/download_file.cc:57687)
   A /trunk/src/chrome/browser/download/base_file.h
   A /trunk/src/chrome/browser/download/base_file_unittest.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Download code cleanup: share most of the code between DownloadFile and SaveFile.

I'm not really happy about BaseFile, but removing the remaining differences
will require changes to DownloadFileManager and SaveFileManager.
I prefer to do that in small steps.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3164039
------------------------------------------------------------------------
r57687 | phajdan.jr@chromium.org | 2010-08-27 18:26:05 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/testing_automation_provider_win.cc

GTTF: Continue moving test automation code out of AutomationProvider.

TEST=ui_tests, chrome_frame_tests
BUG=52097

Review URL: http://codereview.chromium.org/3201019
------------------------------------------------------------------------
r57686 | cmasone@google.com | 2010-08-27 18:11:43 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc

Use new libcros ownership API enums

BUG=None
TEST=compile with rolled cros_deps/DEPS

Review URL: http://codereview.chromium.org/3122043
------------------------------------------------------------------------
r57685 | mirandac@chromium.org | 2010-08-27 18:07:27 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run.cc

Modify search engine dialog to only appear if the user does not have an existing preferences file.

LGTM from Glen in http://codereview.chromium.org/3232001/show for patch to 472 branch.

BUG=53485
TEST=search engine dialog works and appears only when user does not have a previously existing user data directory.  If user has already run Chrome and set up a user data directory, dialog should not appear, and search engines should be silently imported (in organic builds).

Review URL: http://codereview.chromium.org/3242004
------------------------------------------------------------------------
r57684 | hans@chromium.org | 2010-08-27 17:47:37 +0200 (Fri, 27 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/device_orientation/device_orientation_browsertest.cc
   D /trunk/src/chrome/browser/device_orientation/enable_switch_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   D /trunk/src/chrome/test/data/device_orientation/enable_switch_test.html

Enable device orientation by default.

Enable device orientation by default. Replace the --enable-device-orientation
command-line flag with a --disable-device-orientation flag.

BUG=44654
TEST=browser_tests --gtest_filter="DeviceOrientationBrowserTest.*"

Review URL: http://codereview.chromium.org/3136038
------------------------------------------------------------------------
r57681 | sky@chromium.org | 2010-08-27 17:23:49 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc

Nukes --main-menu-url as it's not used anymore.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3146046
------------------------------------------------------------------------
r57680 | erikkay@chromium.org | 2010-08-27 17:22:11 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/extensions/extension_infobar_controller.mm
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/gtk/extension_infobar_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/app_launched_animation_win.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_params.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/extensions/chrome_app_bindings.cc
   A /trunk/src/chrome/renderer/extensions/extension_renderer_info.cc
   A /trunk/src/chrome/renderer/extensions/extension_renderer_info.h
   A /trunk/src/chrome/renderer/extensions/extension_renderer_info_unittest.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/localized_error.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   A /trunk/src/chrome/renderer/resources/error_app.html

When the browser doesn't have connectivity to a hosted app, display a prettier error page by default.

TEST=none
BUG=41281

Review URL: http://codereview.chromium.org/3174024
------------------------------------------------------------------------
r57677 | dmazzoni@chromium.org | 2010-08-27 16:48:16 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Mark test as flaky that's been failing on Chromium Mac.

BUG=53586
TEST=Mark BrowserWindowFullScreenControllerTest.TestActivate as flaky.

Review URL: http://codereview.chromium.org/3221003
------------------------------------------------------------------------
r57675 | dmazzoni@chromium.org | 2010-08-27 16:31:28 +0200 (Fri, 27 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/applescript/browsercrapplication+applescript_test.mm
   M /trunk/src/chrome/browser/cocoa/applescript/window_applescript_test.mm

Mark as FLAKY two applescript tests that have been failing recently on
Chromium Mac.

BUG=53584
TEST=Marks BrowserCrApplicationAppleScriptTest.InsertWindow and WindowAppleScriptTest.WindowOrder as flaky

Review URL: http://codereview.chromium.org/3266001
------------------------------------------------------------------------
r57674 | skerner@chromium.org | 2010-08-27 16:22:12 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   A /trunk/src/chrome/renderer/extensions/chrome_app_bindings.cc
   A /trunk/src/chrome/renderer/extensions/chrome_app_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/test/data/extensions/app_dot_com_app
   A /trunk/src/chrome/test/data/extensions/app_dot_com_app/manifest.json

Implement window.chrome.app.isInstalled .

BUG=49225
TEST=ExtensionBrowserTest.PropertyAppIsInstalled

Review URL: http://codereview.chromium.org/3169045
------------------------------------------------------------------------
r57672 | satish@chromium.org | 2010-08-27 15:34:09 +0200 (Fri, 27 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc

Show proper messages if we find errors before or during audio recording.
BUG=none
TEST=manual, try clicking on speech input button without a mic connected.

Review URL: http://codereview.chromium.org/3240002
------------------------------------------------------------------------
r57671 | mrossetti@chromium.org | 2010-08-27 15:25:30 +0200 (Fri, 27 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   D /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Revert 57668 - Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data.

[Previously reviewed as: http://codereview.chromium.org/3138006.]

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3189025

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/3249002
------------------------------------------------------------------------
r57670 | thakis@chromium.org | 2010-08-27 15:19:05 +0200 (Fri, 27 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/labs_ui.cc
   A /trunk/src/chrome/browser/dom_ui/labs_ui.h
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   A /trunk/src/chrome/browser/labs.cc
   A /trunk/src/chrome/browser/labs.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   A /trunk/src/chrome/browser/resources/labs.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Implement about:labs

Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.

BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57635

Review URL: http://codereview.chromium.org/3152055
------------------------------------------------------------------------
r57668 | mrossetti@chromium.org | 2010-08-27 15:11:56 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   A /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data.

[Previously reviewed as: http://codereview.chromium.org/3138006.]

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3189025
------------------------------------------------------------------------
r57666 | satish@chromium.org | 2010-08-27 13:59:03 +0200 (Fri, 27 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   A /trunk/src/chrome/browser/speech/speech_input_bubble.cc
   M /trunk/src/chrome/browser/speech/speech_input_bubble.h
   A /trunk/src/chrome/browser/speech/speech_input_bubble_controller.cc
   A /trunk/src/chrome/browser/speech/speech_input_bubble_controller.h
   A /trunk/src/chrome/browser/speech/speech_input_bubble_controller_unittest.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.h
   D /trunk/src/chrome/browser/views/speech_input_bubble.cc
   A /trunk/src/chrome/browser/views/speech_input_bubble_view.cc (from /trunk/src/chrome/browser/views/speech_input_bubble.cc:57664)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/speech_input_dispatcher.cc
   M /trunk/src/chrome/renderer/speech_input_dispatcher.h
   M /trunk/src/media/audio/audio_input_controller.cc

Displays a speech input UI bubble during speech recognition.

The webkit code passes in display rect of the input element requesting speech input
and we create a UI bubble pointing at this element when starting speech input. The
user can click outside the bubble to close it, which aborts recognition if we were
still recording audio. The user can also click the cancel link in the bubble which
aborts recognition irrespective of what state it is in now.

Added a SpeechInputBubbleController class to take care of marshalling the requests
between the speech input code in IO thread and the UI bubble in the UI thread. Also
added a unit test for this class.

BUG=none
TEST=unit_tests --gtest_filter=SpeechInputBubbleControllerTest.*

Review URL: http://codereview.chromium.org/3156048
------------------------------------------------------------------------
r57664 | dpolukhin@chromium.org | 2010-08-27 13:44:36 +0200 (Fri, 27 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   D /trunk/src/chrome/browser/dom_ui/labs_ui.cc
   D /trunk/src/chrome/browser/dom_ui/labs_ui.h
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   D /trunk/src/chrome/browser/labs.cc
   D /trunk/src/chrome/browser/labs.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   D /trunk/src/chrome/browser/resources/labs.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Revert 57635: Implement about:labs

Original CL: http://codereview.chromium.org/3152055

Implement about:labs

Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.

BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)
TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/3256001
------------------------------------------------------------------------
r57654 | finnur@chromium.org | 2010-08-27 11:28:24 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Add mixed content warning to the Page Info bubble.

BUG=http://crbug.com/52916
TEST=Navigate to a page with mixed http and https content. The gray padlock should appear in the Omnibox icon and in the infobubble when you click it.

Review URL: http://codereview.chromium.org/3171031
------------------------------------------------------------------------
r57653 | kochi@chromium.org | 2010-08-27 11:21:07 +0200 (Fri, 27 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_language_chewing_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_hangul_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_mozc_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_pinyin_options.html

This CL cleans up the "Content" suffix and adds input method
name prefix for i18n preprocessor identifiers in language
options DOMUI HTMLs, which should be more readable and
less conflict-prone.

This CL also fixes multiple i18n-values attributes in a tag
(in chromeos_language_mozc_options.html).
it should be only one.

BUG=none
TEST=manually check the option UI

Review URL: http://codereview.chromium.org/3247001
------------------------------------------------------------------------
r57652 | dpolukhin@chromium.org | 2010-08-27 10:53:15 +0200 (Fri, 27 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Land 3189012: "Go incognito" button in bottom right corner

Original CL: http://codereview.chromium.org/3189012/show

Implemented "Go incognito" button that appears in bottom right corner
if oobe process is done. Otherwise usual "browse without signin" link
appears in the new login entry.

BUG=chromium-os:5630
TEST=When login screen is loaded there is button in bottom right corner (if no OOBE status bar).

Review URL: http://codereview.chromium.org/3231002
------------------------------------------------------------------------
r57644 | atwilson@chromium.org | 2010-08-27 09:06:18 +0200 (Fri, 27 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/background_mode_manager_unittest.cc

Revert 57642 - Disable background mode when associated pref changes.

BUG=53173
TEST=new BackgroundModeManager unit tests

Review URL: http://codereview.chromium.org/3205008

TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/3226006
------------------------------------------------------------------------
r57642 | atwilson@chromium.org | 2010-08-27 08:39:22 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/background_mode_manager_unittest.cc

Disable background mode when associated pref changes.

BUG=53173
TEST=new BackgroundModeManager unit tests

Review URL: http://codereview.chromium.org/3205008
------------------------------------------------------------------------
r57641 | levin@chromium.org | 2010-08-27 08:23:57 +0200 (Fri, 27 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc

Need to ensure that the autogenerated keyword is generated on the UI thread.
This was broken by r57563.

BUG=53557
TEST=unit_test --gtest_filter=TemplateURLModelTest.LoadDoesAutoKeywordUpdate

Review URL: http://codereview.chromium.org/3243001
------------------------------------------------------------------------
r57640 | aa@chromium.org | 2010-08-27 08:03:35 +0200 (Fri, 27 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Make the 'recently closed' section uncollapseable by adding a
'nocollapse' feature to the sections.

screencap:
http://aaronboodman.com/z_dropbox/cr3141046/ntp5.png

BUG=53248

Review URL: http://codereview.chromium.org/3141046
------------------------------------------------------------------------
r57637 | ukai@chromium.org | 2010-08-27 06:59:50 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/google_url_tracker.cc

Remove NAV_ENTRY_PENDING once NAV_ENTRY_COMITTED received

BUG=52832
TEST=search in the omnibox twice on chrome debug build and didn't crash

Review URL: http://codereview.chromium.org/3187015
------------------------------------------------------------------------
r57636 | thakis@chromium.org | 2010-08-27 06:26:46 +0200 (Fri, 27 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/labs.cc

Windows build fix attempt. TBR: trungl
------------------------------------------------------------------------
r57635 | thakis@chromium.org | 2010-08-27 06:11:14 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/labs_ui.cc
   A /trunk/src/chrome/browser/dom_ui/labs_ui.h
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   A /trunk/src/chrome/browser/labs.cc
   A /trunk/src/chrome/browser/labs.h
   M /trunk/src/chrome/browser/prefs/browser_prefs.cc
   A /trunk/src/chrome/browser/resources/labs.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Implement about:labs

Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.

BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)

Review URL: http://codereview.chromium.org/3152055
------------------------------------------------------------------------
r57629 | dmazzoni@chromium.org | 2010-08-27 04:40:02 +0200 (Fri, 27 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gateway_data_provider_common_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc

I accidentally disabled the wrong test earlier (it had a very similar name).

BUG=53472
TEST=Re-enables GeolocationWifiDataProviderCommonTest.IntermittentWifi, disables GeolocationGatewayDataProviderCommonTest.IntermittentWifi
TBR=joth@chromium.org

Review URL: http://codereview.chromium.org/3234001
------------------------------------------------------------------------
r57625 | dimich@chromium.org | 2010-08-27 03:54:28 +0200 (Fri, 27 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 57614 - Re-land. Fixed previous build error.
It looks like it broke browser_tests. Will revert and investigate.

Implement OSX version for "Start on Login" for background-enabled extensions.



Review URL: http://codereview.chromium.org/3163029

TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/3226002
------------------------------------------------------------------------
r57623 | davidben@chromium.org | 2010-08-27 03:29:28 +0200 (Fri, 27 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/base/scoped_temp_dir.cc
   M /trunk/src/base/scoped_temp_dir.h
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Move the SingletonSocket to a temporary directory

This is to workaround problems on certain network filesystems (notably AFS)
which do not support Unix domain sockets. We move the sockets into a temporary
folder and symlink. To avoid the possibility of a dangling link to a missing
(and later intercepted) remote directory, we create and check cookie files
and rely on the stickiness of /tmp/ to avoid a race condition in the check.

R=mattm
BUG=44606
TEST=ProcessSingletonLinuxTest.*

Review URL: http://codereview.chromium.org/2838034
------------------------------------------------------------------------
r57620 | jrg@chromium.org | 2010-08-27 02:50:45 +0200 (Fri, 27 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add --disable-translate to help Selenium/WebDriver dudes make Chrome
more predictable for automated testing.

BUG=none
TEST=Launch Chrome.  Go to http://www.diplomatie.gouv.fr/fr/
See translate info bar?  Good.
Now launch Chrome with --disable-translate and go to that page again.
Make sure translate info bar never shows up.

Review URL: http://codereview.chromium.org/3117044
------------------------------------------------------------------------
r57614 | dimich@chromium.org | 2010-08-27 02:19:58 +0200 (Fri, 27 Aug 2010) | 21 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Re-land. Fixed previous build error.

Implement OSX version for "Start on Login" for background-enabled extensions.

When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List".

Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon.

Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case.

Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion.

Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX.

BUG=43382
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569
Reverted, trying to re-land.

Review URL: http://codereview.chromium.org/3163029
------------------------------------------------------------------------
r57612 | oshima@chromium.org | 2010-08-27 02:09:01 +0200 (Fri, 27 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   A /trunk/src/chrome/browser/views/dom_view_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Fixed attach logic so that DOMView can be initialized before or after added to Widget.
 * Attach native view in Init if Widget exists.
 * Attach native view when the view is added to Widget if
   it's initialized but not yet attached.

Detach native view when it's removed from parent view so that
it can be re-attached.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3152053
------------------------------------------------------------------------
r57611 | tfarina@chromium.org | 2010-08-27 02:08:21 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

bookmarks: Add HasBookmarks() method to BookmarkModel API.

BUG=45551
TEST=out/Debug/unit_tests --gtest_filter=BookmarkModelTest.HasBookmarks

Review URL: http://codereview.chromium.org/3181030
------------------------------------------------------------------------
r57610 | dhollowa@chromium.org | 2010-08-27 02:07:00 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

AutoFill doesn't fill address information on www.gorillaclothing.com

Adjusts address heuristics to match "addressLine1" and "addressLine2" names.  Also, cleans up the regular expressions to avoid redundancies.

BUG=52126
TEST=FormStructureTest.BillingAndShippingAddresses

Review URL: http://codereview.chromium.org/3159043
------------------------------------------------------------------------
r57608 | chase@chromium.org | 2010-08-27 01:54:47 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   D /trunk/src/chrome/browser/extensions/extension_tts_api_gtk.cc
   D /trunk/src/chrome/browser/extensions/extension_tts_api_mac.mm
   D /trunk/src/chrome/browser/extensions/extension_tts_api_win.cc
   M /trunk/src/chrome/browser/extensions/extension_tts_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert 57595 - Initial TTS implementation on Mac and Windows.BUG=none.TEST=base extension test.  Currently no mocking for the native TTS api's.  Manually tested engines with ChromeVox (navigating around a page, expected interrupts, stopping speech, etc.).
Review URL: http://codereview.chromium.org/3149027

Reverted due to broken compile on Linux Builder
(views dbg).

TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/3217001
------------------------------------------------------------------------
r57601 | georgey@chromium.org | 2010-08-27 01:06:15 +0200 (Fri, 27 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Fix for: Autofill on Windows does not work for the first autofillable page encountered.
BUG=51831
TEST=In the bug.
Review URL: http://codereview.chromium.org/3155047
------------------------------------------------------------------------
r57599 | jhawkins@chromium.org | 2010-08-27 01:03:38 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   D /trunk/src/chrome/browser/dom_ui/autofill_edit_address_handler.cc
   D /trunk/src/chrome/browser/dom_ui/autofill_edit_address_handler.h
   D /trunk/src/chrome/browser/dom_ui/autofill_edit_creditcard_handler.cc
   D /trunk/src/chrome/browser/dom_ui/autofill_edit_creditcard_handler.h
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.js
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI: Implement adding an AutoFill address.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3174037
------------------------------------------------------------------------
r57597 | johnnyg@chromium.org | 2010-08-27 00:57:40 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html

Use a width which works on Windows as well (previous one caused bad line wrapping)

BUG=53494
TEST=choose datatypes screen on windows

Review URL: http://codereview.chromium.org/3184027
------------------------------------------------------------------------
r57596 | dhollowa@chromium.org | 2010-08-27 00:54:40 +0200 (Fri, 27 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

Autofill address line 2 is not applied to ebay.com

Fixes heuristics to include "suite" and "unit" when matching address line 2.

BUG=48197
TEST=FormStructureTest.TwoAddressLinesSkipSuite, FormStructureTest.TwoAddressLinesDontSkipSuite

Review URL: http://codereview.chromium.org/3134042
------------------------------------------------------------------------
r57595 | dtseng@chromium.org | 2010-08-27 00:54:02 +0200 (Fri, 27 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api_gtk.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api_mac.mm
   A /trunk/src/chrome/browser/extensions/extension_tts_api_win.cc
   M /trunk/src/chrome/browser/extensions/extension_tts_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Initial TTS implementation on Mac and Windows.BUG=none.TEST=base extension test.  Currently no mocking for the native TTS api's.  Manually tested engines with ChromeVox (navigating around a page, expected interrupts, stopping speech, etc.).
Review URL: http://codereview.chromium.org/3149027
------------------------------------------------------------------------
r57594 | erg@google.com | 2010-08-27 00:51:54 +0200 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener.h

FBTF: More extensions cleanup.

TEST=compiles
BUG=none

Review URL: http://codereview.chromium.org/3119052
------------------------------------------------------------------------
r57592 | isherman@chromium.org | 2010-08-26 23:52:49 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Don't inline autocomplete when the selected text is not the previously inline autocompleted text.

BUG=7894
TEST=none

Review URL: http://codereview.chromium.org/3136036
------------------------------------------------------------------------
r57591 | sky@chromium.org | 2010-08-26 23:45:34 +0200 (Thu, 26 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h

Makes NavigationController::max_restored_page_id_ an int32 to match
usage of it else where (TabContents, SiteInstance...)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3173050
------------------------------------------------------------------------
r57590 | oshima@chromium.org | 2010-08-26 23:44:28 +0200 (Thu, 26 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Clear Grab everytime before tring to grab input
 It's not clear why it's failing to grab the input.
 This could be because someone is stealing the grab at the same time and I lost.
 This CL changes TryGrabAllIput so that next time it will succeeds.

BUG=chromium-os:5902
TEST=none

Review URL: http://codereview.chromium.org/3134040
------------------------------------------------------------------------
r57589 | jcivelli@chromium.org | 2010-08-26 23:44:27 +0200 (Thu, 26 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/renderer/render_view.cc

Make context-menu show for large data encoded URLs.
The message sent by the renderer to the browser to show a context menu contains the image src URL.
For large images that use data URLs, this URL can be more than 2MB, which is the max limit for serializing a GURL for IPC.
So for these large images we fail to serialize the message and no context menu is shown.
By emptying the URL in that case we make sure the message is sent and the context menu is shown. (even though you cannot save/open the image from the menu).
Making sure you can save the image will be part of a different effort.

BUG=45160
TEST=See bug.

Review URL: http://codereview.chromium.org/3209006
------------------------------------------------------------------------
r57587 | oshima@chromium.org | 2010-08-26 23:43:00 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.h

Screen locker visual fix
 * Use link instead of button for signout.
 * Rounded background.

BUG=5763
TEST=no functional change. all test should still pass.

Review URL: http://codereview.chromium.org/3197013
------------------------------------------------------------------------
r57586 | rkc@google.com | 2010-08-26 23:42:46 +0200 (Thu, 26 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_screenshot_source.cc
   M /trunk/src/chrome/browser/resources/bug_report.js

The screenshots exposed by chrome://screenshots/path were being cached, causing old "Last Screenshot" images to show up.
Fixed it by a hack - unfortunately, cache-config:cache-off meta tags don't seem to be working in Chrome.

Review URL: http://codereview.chromium.org/3162050
------------------------------------------------------------------------
r57584 | xiyuan@chromium.org | 2010-08-26 23:39:59 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/cellular_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/cellular_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc

Implement 3G network settings dialog per chromium-os:5609.

BUG=chromium-os:5609
TEST=none. Hold until flipflam supports are implemented.

Review URL: http://codereview.chromium.org/3112035
------------------------------------------------------------------------
r57580 | cmasone@google.com | 2010-08-26 23:19:51 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.cc
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.h

[Chrome OS] API to determine if the current user is the device owner

BUG=chromium-os:6125
TEST=manual

Review URL: http://codereview.chromium.org/3108051
------------------------------------------------------------------------
r57577 | rohitrao@chromium.org | 2010-08-26 23:07:12 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/framed_browser_window.h
   M /trunk/src/chrome/browser/cocoa/framed_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] New base class for FramedBrowserWindow and FullscreenWindow.  Move common funtionality (theming and hole punching) into this base class.

BUG=53449,53991
TEST=Run with --enable-accelerated-compositing.  Go to http://webkit.org/blog/386/3d-transforms/.  Go fullscreen.  Should see the webpage, not pure black.
TEST=Go fullscreen with the Android Robot theme installed.  Tab text for unselected tabs should be grey, not black.
Review URL: http://codereview.chromium.org/3210004
------------------------------------------------------------------------
r57575 | chase@chromium.org | 2010-08-26 22:27:16 +0200 (Thu, 26 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/base/registry.h
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

Revert 57572 - Remove the default argument from RegKey::Open.

Caused a failure on Windows Chromium Builder (dbg):

...\configuration_policy_provider_win.cc(71) :
error C2660: 'RegKey::Open' : function does not take
2 arguments

BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*

Review URL: http://codereview.chromium.org/3205007

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/3211004
------------------------------------------------------------------------
r57573 | dimich@chromium.org | 2010-08-26 22:10:45 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 57569 - Implement OSX version for "Start on Login" for background-enabled extensions.

Review URL: http://codereview.chromium.org/3163029

TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/3130052
------------------------------------------------------------------------
r57572 | tfarina@chromium.org | 2010-08-26 22:01:32 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/registry.h
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

Remove the default argument from RegKey::Open.

BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*

Review URL: http://codereview.chromium.org/3205007
------------------------------------------------------------------------
r57569 | dimich@chromium.org | 2010-08-26 21:52:49 +0200 (Thu, 26 Aug 2010) | 17 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Implement OSX version for "Start on Login" for background-enabled extensions.

When user installs first bacground-enabled extension we set Chrome to be a "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List".

Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon.

Since we manipulate the user-faced UI item here, we try to do it minimally (only on first installed and last uninstalled background app) with understanding that when we have UI for install/uninstall we'll convert this into more visible, cancellable suggestion on that UI.

Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion.

The patch also removes SetKeepAlive/EndKeepAlive calls for OSX since on OSX they are already used properly to keep Chrome alive when all windows are closed (in other words, on Mac there is only one behavior that also fits what is needed for background apps)

Implementation for Login Items List access uses LSSharedFileList API that is availabel starting 10.5, which I think is our minimal supported version of OSX.

Also added a check in BackgroundModeManager::RemoveStatusTrayIcon() which could crash on OSX because there is no icon_tray_ yet.

Review URL: http://codereview.chromium.org/3163029
------------------------------------------------------------------------
r57567 | tommi@chromium.org | 2010-08-26 21:49:57 +0200 (Thu, 26 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/delete_chrome_history.cc

Submitting for Erik:
(http://codereview.chromium.org/3167040/show)

In IE8, on Vista, when the user deletes their browsing data, the IDeleteBrowsingHistory interface is invoked twice - once in a low integrity process and once in a medium integrity process.

Only the medium integrity process may succeed, but the low integrity process will restart the automation server after failing to connect to it.

Upon invocation by IE, check the integrity level of the current process - if it is low, exit. GetProcessIntegrityLevel was adapted from rlz. A follow-up changeset will modify rlz to use this implementation.

During editing, some unnecessary headers were removed from win_util.h and correspondingly added to win_util.cc and certain clients who were depending on transient includes.

BUG=56212
TEST=Load some pages using Chrome Frame. Close IE. Verify that the Chrome Frame cache has grown and that the accessed domains appear in the history files. Launch IE, load a page using Chrome Frame. Delete Browsing Data. Note that the tab does not crash, that the on-disk cache files shrink, and that the accessed domains no longer appear in the history file

Review URL: http://codereview.chromium.org/3171033
------------------------------------------------------------------------
r57566 | dhg@chromium.org | 2010-08-26 21:49:07 +0200 (Thu, 26 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Fixing crash when opening a new browser

BUG=chromium-os:5147,chromium-os:5997
TEST=none
Review URL: http://codereview.chromium.org/3113033
------------------------------------------------------------------------
r57563 | levin@chromium.org | 2010-08-26 21:43:48 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/util.cc
   M /trunk/src/chrome/browser/search_engines/util.h

Extract the processing of the web data service results processing in a standalone function.

BUG=38475
TEST=unit_test --gtest_filter=Temp*

Review URL: http://codereview.chromium.org/3110038
------------------------------------------------------------------------
r57558 | dmazzoni@chromium.org | 2010-08-26 20:43:00 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc

Mark test as disabled after it timed out on the buildbot.

BUG=53472
TEST=Marks DeviceOrientationProviderTest.StartFailing as disabled

Review URL: http://codereview.chromium.org/3175045
------------------------------------------------------------------------
r57557 | skerner@chromium.org | 2010-08-26 20:37:35 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Remove tests of app windows, which are no longer supported.  Re-enable tests on mac.

BUG=42865
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/3111031
------------------------------------------------------------------------
r57554 | dmazzoni@chromium.org | 2010-08-26 20:32:18 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/device_orientation/provider_unittest.cc

Mark test as DISABLED after it crashed twice.

BUG=53468
TEST=Mark DeviceOrientationProviderTest.StartFailing as disabled.

Review URL: http://codereview.chromium.org/3199022
------------------------------------------------------------------------
r57551 | gregoryd@google.com | 2010-08-26 20:22:31 +0200 (Thu, 26 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/nacl_enabled/background.html

Revert revision 57540
TBR=cbiffle
BUG=45881
Review URL: http://codereview.chromium.org/3159046
------------------------------------------------------------------------
r57550 | phajdan.jr@chromium.org | 2010-08-26 20:13:10 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/browser.h

GTTF: Move more and more automation bits to TestingAutomationProvider

And now it seems to handle more automation messages than the original one.

TEST=ui_tests, chrome_frame_tests
BUG=52097

Review URL: http://codereview.chromium.org/3185030
------------------------------------------------------------------------
r57548 | sky@chromium.org | 2010-08-26 20:03:25 +0200 (Thu, 26 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Adds NavigationController::CopyStateFromAndPrune which merges two
NavigationControllers.

BUG=none
TEST=covered by unit tests.

Review URL: http://codereview.chromium.org/3176030
------------------------------------------------------------------------
r57547 | dhg@chromium.org | 2010-08-26 19:59:08 +0200 (Thu, 26 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js

Fixing build for chromeos.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3197023
------------------------------------------------------------------------
r57545 | atwilson@chromium.org | 2010-08-26 19:46:27 +0200 (Thu, 26 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc

Added clarifying comment to BrowserList::RemoveBrowser().
Added comment describing why we don't need to call ShutdownSessionServices()

BUG=53360
TEST=None needed (comment change only)

Review URL: http://codereview.chromium.org/3186034
------------------------------------------------------------------------
r57544 | asargent@chromium.org | 2010-08-26 19:43:28 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_management_api.cc
   A /trunk/src/chrome/browser/extensions/extension_management_api.h
   A /trunk/src/chrome/browser/extensions/extension_management_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   A /trunk/src/chrome/common/extensions/docs/experimental.management.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   M /trunk/src/chrome/common/extensions/docs/samples.json
   A /trunk/src/chrome/common/extensions/docs/static/experimental.management.html
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/management
   A /trunk/src/chrome/test/data/extensions/api_test/management/disabled_app
   A /trunk/src/chrome/test/data/extensions/api_test/management/disabled_app/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/management/disabled_extension
   A /trunk/src/chrome/test/data/extensions/api_test/management/disabled_extension/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/management/disabled_extension/pages
   A /trunk/src/chrome/test/data/extensions/api_test/management/disabled_extension/pages/options.html
   A /trunk/src/chrome/test/data/extensions/api_test/management/enabled_app
   A /trunk/src/chrome/test/data/extensions/api_test/management/enabled_app/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/management/enabled_extension
   A /trunk/src/chrome/test/data/extensions/api_test/management/enabled_extension/icon_128.png
   A /trunk/src/chrome/test/data/extensions/api_test/management/enabled_extension/icon_16.png
   A /trunk/src/chrome/test/data/extensions/api_test/management/enabled_extension/icon_48.png
   A /trunk/src/chrome/test/data/extensions/api_test/management/enabled_extension/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/management/test
   A /trunk/src/chrome/test/data/extensions/api_test/management/test/basics.html
   A /trunk/src/chrome/test/data/extensions/api_test/management/test/basics.js
   A /trunk/src/chrome/test/data/extensions/api_test/management/test/common.js
   A /trunk/src/chrome/test/data/extensions/api_test/management/test/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/management/test/uninstall.html
   A /trunk/src/chrome/test/data/extensions/api_test/management/test/uninstall.js

First cut at experimental API for managing installed/enabled extensions.

The documented methods should all be working, but events are not hooked up yet.

BUG=51178
TEST=none

Review URL: http://codereview.chromium.org/3200012
------------------------------------------------------------------------
r57543 | erg@google.com | 2010-08-26 19:23:46 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/extensions/extension_metrics_module.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc
   M /trunk/src/chrome/browser/themes/browser_theme_pack.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h
   M /trunk/src/chrome/common/extensions/extension_file_util.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/common/extensions/update_manifest.h
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/url_pattern_unittest.cc
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h

FBTF: Forward declare and move constructors in chrome/common/extensions/.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3207002
------------------------------------------------------------------------
r57542 | rohitrao@chromium.org | 2010-08-26 19:21:11 +0200 (Thu, 26 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   D /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   D /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   D /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   A /trunk/src/chrome/browser/cocoa/framed_browser_window.h (from /trunk/src/chrome/browser/cocoa/chrome_browser_window.h:57522)
   A /trunk/src/chrome/browser/cocoa/framed_browser_window.mm (from /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm:57522)
   A /trunk/src/chrome/browser/cocoa/framed_browser_window_unittest.mm (from /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm:57522)
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

[Mac] Rename ChromeBrowserWindow to FramedBrowserWindow.

BUG=53449
TEST=No visible impact.  Everything should still work.
Review URL: http://codereview.chromium.org/3189026
------------------------------------------------------------------------
r57541 | sky@chromium.org | 2010-08-26 19:17:51 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/views/mouse_watcher.cc
   M /trunk/src/views/mouse_watcher.h

Makes the download shelf auto-close after the user opens all downloads
and moves mouse off the shelf.

BUG=27797
TEST=on windows download an item, open it, move the mouse off the
download shelf and make sure it closes.

Review URL: http://codereview.chromium.org/3177034
------------------------------------------------------------------------
r57540 | gregoryd@google.com | 2010-08-26 19:08:22 +0200 (Thu, 26 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/nacl_enabled/background.html

Run NaClPermissionEnabled on all platforms (relying on NaCl's support for multiple architectures)
BUG=45881
TEST=This CL
Review URL: http://codereview.chromium.org/3148025
------------------------------------------------------------------------
r57536 | allanwoj@chromium.org | 2010-08-26 18:55:22 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/gateway_data_provider_common.cc
   A /trunk/src/chrome/browser/geolocation/gateway_data_provider_common.h
   A /trunk/src/chrome/browser/geolocation/gateway_data_provider_common_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Base class for gateway data providers
Provides common code for platform specific implementations of gateway data providers. Might be a good idea to derive all network data providers from a single base class in a future patch as there is a lot of code replication between them.
BUG=NONE
TEST=Unit test

Review URL: http://codereview.chromium.org/3174031
------------------------------------------------------------------------
r57535 | nshkrob@chromium.org | 2010-08-26 18:50:57 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc

Fix a crash in MigrateThumbnailsDatabase.

BUG=53161
TEST=unit_tests

Review URL: http://codereview.chromium.org/3162037
------------------------------------------------------------------------
r57534 | cmasone@google.com | 2010-08-26 18:41:33 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/ownership_service.cc

[Chrome OS] Load the owner key, if it exists.  Generate it, if not.

Some of the notification logic was jacked up as well, so i fixed that while I was here.

BUG=chromium-os:4485
TEST=unit tests, load onto gadget and log in for the first time.  Verify the key is there.  Log out, log in as another user, verify the key gets loaded by chrome and that the key doesn't get changed.

Review URL: http://codereview.chromium.org/3159039
------------------------------------------------------------------------
r57528 | andreip@chromium.org | 2010-08-26 18:08:01 +0200 (Thu, 26 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_key_utility_client.h

Fix IndexedDBBrowserTest.KeyPathTest

We need to communicate with the Utility process from the IO thread, not the WebKit thread.

Review URL: http://codereview.chromium.org/3173049
------------------------------------------------------------------------
r57527 | viettrungluu@chromium.org | 2010-08-26 17:56:43 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h

Convert CookieTree...Node to not use the wstring GetTitle(), but instead GetTitleAsString16().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3146045
------------------------------------------------------------------------
r57525 | mmenke@chromium.org | 2010-08-26 17:33:18 +0200 (Thu, 26 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/browser/resources/net_internals/requestsview.js
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js

Sorting added to net-internals.  Also, search looks through all of a SourceEntry's text.

Add "sort:X" to the search field in the Requests view, and log entries will be sorted depending on "X".  Possible values are "id", "desc", "source", "duration", and "active".  "Active" sorts active entries first, longest active at the top, and inactive entries below, most recently active at the top.  "Source" sorts sourceless entries using the largest source ID seen up to that point.  The rest should be self-explanatory.

"sort:-X" will reverse the order of the sort.

New entries are sorted as they are added.

"is:active" shows only the active events, and "is:-active" only shows the inactive ones.


Bug=50764
Test=manual

Review URL: http://codereview.chromium.org/3165024
------------------------------------------------------------------------
r57524 | satish@chromium.org | 2010-08-26 17:18:35 +0200 (Thu, 26 Aug 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.h
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc

Make SpeechInputManager a process wide singleton so it can make sure there is only 1 active
audio recording happening at any time. Without this change, each SpeechInputDispatcherHost
has it's own instance of SpeechInputManager so multiple tabs/windows can record audio
simultaneously (and get the same audio data!).

With SpeechInputManager a singleton, it is no longer possible for the (render-view-id, request-id)
pair to be a unique identifier for a caller. We need to add render-process-id into the mix. None
of the speech input code cares about any of these and they can just work with an opaque identifier,
so I've added a SpeechInputDispatcherHost::SpeechInputCallers class which maps between the tuple of
3 values above to a single int/ID which can be passed as the caller id. With this change I have
removed the SpeechInputCallerId type replacing it with an int everywhere.

Also being a singleton the same SpeechInputManager is used by all SpeechInputDispatcherHost
instances, hence their delegate pointers could no longer be passed via the constructor of
SpeechInputManager. Instead we now pass the delegate to SpeechInputManager::StartRecognition and
it gets stored as part of the speech input session/request data. To implement this I have added
SpeechInputManager::SpeechInputRequest type and modified related code in that class accordingly.

BUG=none
TEST=All existing speech input unit tests and browser tests should pass. In manual testing, when recording is in progress in one browser window starting speech input in another browser window should abort/stop the first recording session.

Review URL: http://codereview.chromium.org/3116048
------------------------------------------------------------------------
r57523 | mrossetti@chromium.org | 2010-08-26 17:15:59 +0200 (Thu, 26 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   D /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Revert 57522 - Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data.

[Previously reviewed as: http://codereview.chromium.org/3138006.]

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3158027

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/3134038
------------------------------------------------------------------------
r57522 | mrossetti@chromium.org | 2010-08-26 16:40:32 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   A /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data.

[Previously reviewed as: http://codereview.chromium.org/3138006.]

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3158027
------------------------------------------------------------------------
r57521 | hans@chromium.org | 2010-08-26 16:34:41 +0200 (Thu, 26 Aug 2010) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/device_orientation/accelerometer_mac.cc
   A /trunk/src/chrome/browser/device_orientation/accelerometer_mac.h
   M /trunk/src/chrome/browser/device_orientation/provider.cc
   M /trunk/src/chrome/chrome_browser.gypi

Adding MacBook Pro accelerometer support.

A class for handling Sudden Motion Sensors. It's only compiled under Mac OS.

Landing for Leandro Gracia Gil <leandrogracia@google.com>.
Original code review: http://codereview.chromium.org/3169040/show

BUG=44654
TEST=none

Review URL: http://codereview.chromium.org/3187025
------------------------------------------------------------------------
r57520 | rafaelw@chromium.org | 2010-08-26 16:33:19 +0200 (Thu, 26 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   A /trunk/src/chrome/browser/resources/webstore_app
   A /trunk/src/chrome/browser/resources/webstore_app/manifest.json
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Re-land 57460 - Add hidden component app for web store.

Fixed ExtensionStartupTest which was essentially counting the number of component extensions. Now it doesn't.

Original review here: http://codereview.chromium.org/3116040

This patch adds a component which does not appear on the NTP, but does enforce that gallery urls are isolated in their own process. This is in anticipation of exposing extension api bindings to the gallery so it can install/detect/uninstall extensions & apps.

Note that this patch works correctly with the --apps-gallery-url. If specified, the replacement url will be inserted into the component app's extent

BUG=27431
TBR=aa

Review URL: http://codereview.chromium.org/3104039
------------------------------------------------------------------------
r57514 | rohitrao@chromium.org | 2010-08-26 16:01:59 +0200 (Thu, 26 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm

[Mac] Do not always restore focus to the RWHV on tab switches.

BUG=26610
TEST=Open news.google.com in one tab, anything in another.  Click on the news.google.com search box, then in the omnibox.  Switch tabs and switch back.  Focus should be in the omnibox, not in both the omnibox and the search box.
Review URL: http://codereview.chromium.org/3127029
------------------------------------------------------------------------
r57513 | mnissler@chromium.org | 2010-08-26 16:01:46 +0200 (Thu, 26 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/app/policy/mac/app-Manifest.plist
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/policy/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/prefs/session_startup_pref.cc
   M /trunk/src/chrome/browser/prefs/session_startup_pref.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h

Implement a policy to specify which pages to restore at startup.  The admin can choose no restore, last opened windows, or specific pages to be opened.

xib changes: Added an enabled binding to the policy-controlled "Restore on Startup" radiobox group in the "Basic" preference pane.  They can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.

BUG=49297
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.*  Manual tests: Set the policies externally.  Check that appropriate restore action is done at startup.  Check that the Restore on Startup buttons are disabled.

Review URL: http://codereview.chromium.org/3115021
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
------------------------------------------------------------------------
r57511 | pinkerton@chromium.org | 2010-08-26 15:36:08 +0200 (Thu, 26 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Don't use rapid-close mode when middle-clicking a pinned tab to close it as the calculations get all messed up due to the differences in widths.
BUG=51298
TEST=closing tabs and middle-click closing tabs, making sure everything resizes as expected.
Review URL: http://codereview.chromium.org/3116037
------------------------------------------------------------------------
r57502 | andreip@chromium.org | 2010-08-26 11:50:39 +0200 (Thu, 26 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_key_utility_client.h
   M /trunk/src/chrome/chrome_browser.gypi
   A /trunk/src/chrome/test/data/indexeddb/key_path_test.html
   A /trunk/src/chrome/test/data/indexeddb/key_path_test.js

Hooks IDBKeyPath with IDBObjectStorage::put.

This is a clone of Marcus' change:

http://codereview.chromium.org/3120019/show

I have also filed

http://code.google.com/p/chromium/issues/detail?id=53317

about resolving Brett's concerns with the header dependencies introduced by 3120019 and 3043037.

Review URL: http://codereview.chromium.org/3140029
------------------------------------------------------------------------
r57501 | finnur@chromium.org | 2010-08-26 11:26:53 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc

Build fix for ChromeOS. 
(Didn't see this error below the first)

BUG=None
TEST=None
TBR=mnissler

Review URL: http://codereview.chromium.org/3205009
------------------------------------------------------------------------
r57500 | finnur@chromium.org | 2010-08-26 11:21:43 +0200 (Thu, 26 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/page_info_bubble_view.h

Fix build failure (members initialized in incorrect order).

BUG=None
TEST=None
TBR=mnissler

Review URL: http://codereview.chromium.org/3170047
------------------------------------------------------------------------
r57499 | yusukes@chromium.org | 2010-08-26 11:13:38 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

Add string resources for US intl and Russia phonetic.

BUG=chromium-os:3440
TEST=checked chrome_log that no warnings are written.

Review URL: http://codereview.chromium.org/3159041
------------------------------------------------------------------------
r57498 | finnur@chromium.org | 2010-08-26 11:00:00 +0200 (Thu, 26 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/theme/pageinfo_bad.png
   M /trunk/src/chrome/app/theme/pageinfo_good.png
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/browser/views/page_info_bubble_view.h
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Part 2 of the SSL InfoBubble. 2nd try, this time with test fixed.

- Added Certificate Information link.

- Changed iconography to be:
 Identity  : Green check mark vs. Red skull and bones
 Connection: Green padlock vs. Orange exclamation point.
 (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3187019
------------------------------------------------------------------------
r57497 | mnissler@chromium.org | 2010-08-26 10:55:22 +0200 (Thu, 26 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/browser_child_process_host.cc
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc

Make crash reporting client_id accessible through child_process_logging.

On Mac and Linux, keep the client id in a global variable kept by the
child_process_logging implementations. This allows to read it in a
thread safe fashion when starting a child process.

Also replace std::string with statically allocated buffers for the
various items we add to the crash reports. This allows to properly
handle crashes upon shutdown (std::string would run its destructor,
invalidating the memory).

BUG=53231
TEST=Crash reporting should still work

Review URL: http://codereview.chromium.org/3186028
------------------------------------------------------------------------
r57496 | yuzo@chromium.org | 2010-08-26 10:52:20 +0200 (Thu, 26 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable one more test for WebKit roll 65992:66033

BUG=53406
TEST=none
TBR=dumi

Review URL: http://codereview.chromium.org/3174038
------------------------------------------------------------------------
r57495 | yuzo@chromium.org | 2010-08-26 10:38:43 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Add bug URL (53406) comments for tests disabled for the bug.

BUG=53406
TEST=none
TBR=dumi

------------------------------------------------------------------------
r57494 | mnissler@chromium.org | 2010-08-26 10:24:27 +0200 (Thu, 26 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm
   M /trunk/src/chrome/browser/first_run/first_run_mac.mm

[mac] Hide stats opt-in in first run if controlled by policy

The first run checkbox that asks the user for their agreement to send stats and
crash reports to Google should be hidden if that decision has been made by the
administrator through configuration management. Also remove a DCHECK that
tested for the crash reporter not being initialized during first run, since it
may be present in case configuration management is in effect.

BUG=49917
TEST=Configure MetricsReportingEnabled policy and trigger a first run, check UI.

Review URL: http://codereview.chromium.org/3152050
------------------------------------------------------------------------
r57493 | mnissler@chromium.org | 2010-08-26 10:14:23 +0200 (Thu, 26 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

[linux] Skip stats question dialog on Linux if managed by policy.

This skips the dialog that asks the user to opt in for sending stats and
crash reports to Google if that decision has already been made through
enterprise configuration management.

BUG=49917
TEST=Configure MetricsReportingEnabled policy to false, start chrome with fresh --user-data-dir

Review URL: http://codereview.chromium.org/3201017
------------------------------------------------------------------------
r57492 | aa@chromium.org | 2010-08-26 10:11:30 +0200 (Thu, 26 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/ntp_header_background.png
   A /trunk/src/chrome/app/theme/ntp_header_background_active.png
   A /trunk/src/chrome/app/theme/ntp_header_background_hover.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   A /trunk/src/chrome/browser/resources/ntp/ntp_disclosure_triangle.png
   M /trunk/src/chrome/browser/themes/browser_theme_provider.cc
   M /trunk/src/chrome/browser/themes/browser_theme_provider.h

Reland r57473

TBR=eroman@chromium.org
------------------------------------------------------------------------
r57491 | hbono@chromium.org | 2010-08-26 10:09:25 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Another fix for Bug 53385.
It seems some unit tests also need to initialize the new variable added by r57387.

BUG=53385
TEST=make the "Linux Tests (valgrind)(1)" and "Chromium Mac (valgrind)" bots greener.
Review URL: http://codereview.chromium.org/3124048
------------------------------------------------------------------------
r57488 | dumi@chromium.org | 2010-08-26 09:33:21 +0200 (Thu, 26 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc

Re-enable 2 uni_tests. They started passing again after a revert.

BUG=53405
TEST=none
TBR=eroman

Review URL: http://codereview.chromium.org/3200014
------------------------------------------------------------------------
r57484 | yuzo@chromium.org | 2010-08-26 09:13:44 +0200 (Thu, 26 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Second try for DevTools sanity tests start failing after rolling WebKit from 65992 to 66033

This time use DISABLED_ instead of FAILS_.

BUG=53406
TEST=none
TBR=dumi

Review URL: http://codereview.chromium.org/3186035
------------------------------------------------------------------------
r57483 | yuzo@chromium.org | 2010-08-26 08:58:47 +0200 (Thu, 26 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools sanity tests start failing after rolling WebKit from 65992 to 66033

Temporarily disable the tests to roll WebKit.

BUG=53406
TEST=none
TBR=dumi


Review URL: http://codereview.chromium.org/3115030
------------------------------------------------------------------------
r57482 | dumi@chromium.org | 2010-08-26 08:54:47 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc

Disable 2 unit tests that fail after a WebKit roll.

BUG=53405
TEST=none
TBR=yuzo


Review URL: http://codereview.chromium.org/3208005
------------------------------------------------------------------------
r57480 | atwilson@chromium.org | 2010-08-26 08:16:09 +0200 (Thu, 26 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.h

Background Mode prefs for gtk.
BUG=53173
TEST=Will add tests to BackgroundMode when it supports pref notifications

Review URL: http://codereview.chromium.org/3122037
------------------------------------------------------------------------
r57478 | aa@chromium.org | 2010-08-26 08:05:31 +0200 (Thu, 26 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/theme/ntp_header_background.png
   D /trunk/src/chrome/app/theme/ntp_header_background_active.png
   D /trunk/src/chrome/app/theme/ntp_header_background_hover.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   D /trunk/src/chrome/browser/resources/ntp/ntp_disclosure_triangle.png
   M /trunk/src/chrome/browser/themes/browser_theme_provider.cc
   M /trunk/src/chrome/browser/themes/browser_theme_provider.h

Revert 57473 and 57476. Best. Programmer. Ever.

TBR=eroman@chromium.org
------------------------------------------------------------------------
r57476 | aa@chromium.org | 2010-08-26 07:44:54 +0200 (Thu, 26 Aug 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/ntp/ntp_disclosure_triangle.png

Add missing file from r57473.

TBR=eroman@chromium.org
------------------------------------------------------------------------
r57473 | aa@chromium.org | 2010-08-26 07:29:54 +0200 (Thu, 26 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/ntp_header_background.png
   A /trunk/src/chrome/app/theme/ntp_header_background_active.png
   A /trunk/src/chrome/app/theme/ntp_header_background_hover.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   M /trunk/src/chrome/browser/themes/browser_theme_provider.cc
   M /trunk/src/chrome/browser/themes/browser_theme_provider.h

First set of changes for M7 NTP.

This doesn't do any behavior changes -- it just implements
the styling. So we still have multi expand, and the recently
closed section is still toggleable.

I also didn't make the changes to the placement or text of
the web store icon. I will make those separately.

Screen caps:
http://aaronboodman.com/z_dropbox/cr3156049/

BUG=53248

Review URL: http://codereview.chromium.org/3156049
------------------------------------------------------------------------
r57468 | rafaelw@chromium.org | 2010-08-26 06:54:09 +0200 (Thu, 26 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   D /trunk/src/chrome/browser/resources/webstore_app
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Revert 57460 - Add hidden component app for web store.

This patch adds a component which does not appear on the NTP, but does enforce that gallery urls are isolated in their own process. This is in anticipation of exposing extension api bindings to the gallery so it can install/detect/uninstall extensions & apps.

Note that this patch works correctly with the --apps-gallery-url. If specified, the replacement url will be inserted into the component app's extent

BUG=27431

Review URL: http://codereview.chromium.org/3116040

TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/3180027
------------------------------------------------------------------------
r57466 | viettrungluu@chromium.org | 2010-08-26 06:48:36 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

Remove wstrings from bookmarks, part 16.

This removes calls to the wstring GetTitle() method (in bookmarks).

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3166036
------------------------------------------------------------------------
r57460 | rafaelw@chromium.org | 2010-08-26 06:03:17 +0200 (Thu, 26 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   A /trunk/src/chrome/browser/resources/webstore_app
   A /trunk/src/chrome/browser/resources/webstore_app/manifest.json
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Add hidden component app for web store.

This patch adds a component which does not appear on the NTP, but does enforce that gallery urls are isolated in their own process. This is in anticipation of exposing extension api bindings to the gallery so it can install/detect/uninstall extensions & apps.

Note that this patch works correctly with the --apps-gallery-url. If specified, the replacement url will be inserted into the component app's extent

BUG=27431

Review URL: http://codereview.chromium.org/3116040
------------------------------------------------------------------------
r57458 | sky@chromium.org | 2010-08-26 05:16:58 +0200 (Thu, 26 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_screen.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Changes TabContentsDelegate::ShouldAddNavigationToHistory to be passed
the HistoryAddPageArgs so that they can be cached and used later
on. Refactors some other code that interacts with history so that it
can be called separately as well.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3158029
------------------------------------------------------------------------
r57457 | tbarzic@google.com | 2010-08-26 05:09:37 +0200 (Thu, 26 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/imageburner_ui.cc
   M /trunk/src/chrome/browser/resources/imageburner.html
   M /trunk/src/chrome/chrome_browser.gypi


Review URL: http://codereview.chromium.org/3110037
------------------------------------------------------------------------
r57452 | stevenjb@chromium.org | 2010-08-26 04:30:03 +0200 (Thu, 26 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.cc

Multiple calls to PanelBrowserView::Show() are spawning multiple PanelController instances:
BUG=chromeos:5898 (Crash when rapidly closing an app window)
BUG=chromeos:5824 (System crash while closing Downloads popup)
BUG=chromeos:5908 (Launching the same panel app twice (without closing first) prevents the app from being closed)
TEST=See individual bugs; repos should not crash.

Review URL: http://codereview.chromium.org/3135040
------------------------------------------------------------------------
r57449 | derat@chromium.org | 2010-08-26 04:11:38 +0200 (Thu, 26 Aug 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc

chromeos: Remove accelerator from fullscreen-exit text.

This currently displays a nonsensical message, but I can't
think of any good way to change the text to describe the
key, e.g. "Exit full screen (fourth key from the left on the
top row of the keyboard)". :-P

We'd ideally include an image of the keycap in the middle of
the text, but that seems like it'll require a decent amount
of Views hacking, and will be a pain to maintain while we're
still in the process of playing around with things like font
sizes (but I've created an image that works with the current
text size, if someone more Views-proficient than me wants to
take this on).  Glen agreed that this is an acceptable
compromise in the meantime.

BUG=chromium-os:3916
TEST=tried it

Review URL: http://codereview.chromium.org/3181042
------------------------------------------------------------------------
r57443 | thakis@chromium.org | 2010-08-26 03:29:15 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Fix deadlock with compositor

The problem was that some of the IOSurface messages weren't dispatched to the UI thread, and cocoa isn't happy when it's not called from the UI thread.

BUG=52798
TEST=see bug

Review URL: http://codereview.chromium.org/3124045
------------------------------------------------------------------------
r57440 | evan@chromium.org | 2010-08-26 02:35:10 +0200 (Thu, 26 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.cc

Anticipatory build fix.
------------------------------------------------------------------------
r57439 | evan@chromium.org | 2010-08-26 02:33:59 +0200 (Thu, 26 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Build fix.
------------------------------------------------------------------------
r57434 | evan@chromium.org | 2010-08-26 02:22:02 +0200 (Thu, 26 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_download.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service_unittest.cc
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_child_process_host.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/browser_prefs.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_customize_modifier_keys_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/apply_services_customization.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.h
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/restart_browser.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver_unittest.mm
   D /trunk/src/chrome/browser/command_line_pref_store.cc
   D /trunk/src/chrome/browser/command_line_pref_store.h
   D /trunk/src/chrome/browser/command_line_pref_store_unittest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/default_encoding_combo_model.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.h
   M /trunk/src/chrome/browser/dom_ui/font_settings_utils_mac.mm
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/options_managed_banner_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   D /trunk/src/chrome/browser/dummy_pref_store.cc
   D /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/encoding_menu_controller.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_proxy_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/first_run/first_run.cc
   M /trunk/src/chrome/browser/first_run/first_run_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/update_recommended_dialog.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/host_zoom_map_unittest.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   D /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   D /trunk/src/chrome/browser/managed_prefs_banner_base.h
   D /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service_unittest.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/options_page_base.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   A /trunk/src/chrome/browser/policy/managed_prefs_banner_base.cc (from /trunk/src/chrome/browser/managed_prefs_banner_base.cc:57433)
   A /trunk/src/chrome/browser/policy/managed_prefs_banner_base.h (from /trunk/src/chrome/browser/managed_prefs_banner_base.h:57433)
   A /trunk/src/chrome/browser/policy/managed_prefs_banner_base_unittest.cc (from /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc:57433)
   M /trunk/src/chrome/browser/possible_url_model.cc
   D /trunk/src/chrome/browser/pref_member.cc
   D /trunk/src/chrome/browser/pref_member.h
   D /trunk/src/chrome/browser/pref_member_unittest.cc
   D /trunk/src/chrome/browser/pref_notifier.cc
   D /trunk/src/chrome/browser/pref_notifier.h
   D /trunk/src/chrome/browser/pref_notifier_unittest.cc
   D /trunk/src/chrome/browser/pref_service.cc
   D /trunk/src/chrome/browser/pref_service.h
   D /trunk/src/chrome/browser/pref_service_uitest.cc
   D /trunk/src/chrome/browser/pref_service_unittest.cc
   D /trunk/src/chrome/browser/pref_set_observer.cc
   D /trunk/src/chrome/browser/pref_set_observer.h
   D /trunk/src/chrome/browser/pref_set_observer_unittest.cc
   D /trunk/src/chrome/browser/pref_value_store.cc
   D /trunk/src/chrome/browser/pref_value_store.h
   D /trunk/src/chrome/browser/pref_value_store_unittest.cc
   A /trunk/src/chrome/browser/prefs
   A /trunk/src/chrome/browser/prefs/browser_prefs.cc (from /trunk/src/chrome/browser/browser_prefs.cc:57433)
   A /trunk/src/chrome/browser/prefs/browser_prefs.h (from /trunk/src/chrome/browser/browser_prefs.h:57433)
   A /trunk/src/chrome/browser/prefs/command_line_pref_store.cc (from /trunk/src/chrome/browser/command_line_pref_store.cc:57433)
   A /trunk/src/chrome/browser/prefs/command_line_pref_store.h (from /trunk/src/chrome/browser/command_line_pref_store.h:57433)
   A /trunk/src/chrome/browser/prefs/command_line_pref_store_unittest.cc (from /trunk/src/chrome/browser/command_line_pref_store_unittest.cc:57433)
   A /trunk/src/chrome/browser/prefs/dummy_pref_store.cc (from /trunk/src/chrome/browser/dummy_pref_store.cc:57433)
   A /trunk/src/chrome/browser/prefs/dummy_pref_store.h (from /trunk/src/chrome/browser/dummy_pref_store.h:57433)
   A /trunk/src/chrome/browser/prefs/pref_member.cc (from /trunk/src/chrome/browser/pref_member.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_member.h (from /trunk/src/chrome/browser/pref_member.h:57433)
   A /trunk/src/chrome/browser/prefs/pref_member_unittest.cc (from /trunk/src/chrome/browser/pref_member_unittest.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_notifier.cc (from /trunk/src/chrome/browser/pref_notifier.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_notifier.h (from /trunk/src/chrome/browser/pref_notifier.h:57433)
   A /trunk/src/chrome/browser/prefs/pref_notifier_unittest.cc (from /trunk/src/chrome/browser/pref_notifier_unittest.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_service.cc (from /trunk/src/chrome/browser/pref_service.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_service.h (from /trunk/src/chrome/browser/pref_service.h:57433)
   A /trunk/src/chrome/browser/prefs/pref_service_uitest.cc (from /trunk/src/chrome/browser/pref_service_uitest.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_service_unittest.cc (from /trunk/src/chrome/browser/pref_service_unittest.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_set_observer.cc (from /trunk/src/chrome/browser/pref_set_observer.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_set_observer.h (from /trunk/src/chrome/browser/pref_set_observer.h:57433)
   A /trunk/src/chrome/browser/prefs/pref_set_observer_unittest.cc (from /trunk/src/chrome/browser/pref_set_observer_unittest.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_value_store.cc (from /trunk/src/chrome/browser/pref_value_store.cc:57433)
   A /trunk/src/chrome/browser/prefs/pref_value_store.h (from /trunk/src/chrome/browser/pref_value_store.h:57433)
   A /trunk/src/chrome/browser/prefs/pref_value_store_unittest.cc (from /trunk/src/chrome/browser/pref_value_store_unittest.cc:57433)
   A /trunk/src/chrome/browser/prefs/scoped_pref_update.cc (from /trunk/src/chrome/browser/scoped_pref_update.cc:57433)
   A /trunk/src/chrome/browser/prefs/scoped_pref_update.h (from /trunk/src/chrome/browser/scoped_pref_update.h:57433)
   A /trunk/src/chrome/browser/prefs/session_startup_pref.cc (from /trunk/src/chrome/browser/session_startup_pref.cc:57433)
   A /trunk/src/chrome/browser/prefs/session_startup_pref.h (from /trunk/src/chrome/browser/session_startup_pref.h:57433)
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   D /trunk/src/chrome/browser/scoped_pref_update.cc
   D /trunk/src/chrome/browser/scoped_pref_update.h
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   D /trunk/src/chrome/browser/session_startup_pref.cc
   D /trunk/src/chrome/browser/session_startup_pref.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sidebar/sidebar_manager.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/update_recommended_message_box.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/live_sync/live_autofill_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_preferences_sync_test.h
   M /trunk/src/chrome/test/live_sync/multiple_client_live_preferences_sync_test.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_preferences_sync_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/testing_pref_service.cc
   M /trunk/src/chrome/test/testing_pref_service.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Move prefs-related files under chrome/browser/ into a prefs/ subdir.

Rename includes, resort header include order in places where the rename
changed the order.

BUG=50548
TEST=compiles

Review URL: http://codereview.chromium.org/3203008
------------------------------------------------------------------------
r57429 | viettrungluu@chromium.org | 2010-08-26 02:09:11 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc

Remove wstrings from bookmarks, part 15.

Convert the languages parameters in bookmark_utils.* to std::string.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3169043
------------------------------------------------------------------------
r57425 | cpu@chromium.org | 2010-08-26 01:50:34 +0200 (Thu, 26 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc

Revert 57388 - Fix browser hang when blocking hulu pop-out

Flash while drawing the movie frames cannot handle being sized 0-by-0 and
a storm of math exception happen which prevents flash from pumping messages

BUG=52754
TEST=see bug

Reverting because Adam's fix for hulu obviates this workarround which can
have side effect elsewhere. See the bug.


Review URL: http://codereview.chromium.org/3132043

TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/3150038
------------------------------------------------------------------------
r57421 | estade@chromium.org | 2010-08-26 01:41:45 +0200 (Thu, 26 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run/first_run.cc
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/importer/importer.cc

Refactor new first run control flow.

Factor out the common code so that Mac and Linux may share the new flow with Windows (e.g., import is done before the first run dialog appears).

Windows *should* be unaffected by this change. Linux has some non-user-visible changes. The user visible changes (showing the default search engine in the ballot, for example) are TODO.

BUG=49705,47651
TEST=launching chromium with --first-run works as expected, i.e. it imports stuff from your default browser (such as history); if that browser is firefox and firefox is open, the failure is silent.

Review URL: http://codereview.chromium.org/3171029
------------------------------------------------------------------------
r57417 | cindylau@google.com | 2010-08-26 01:32:23 +0200 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc

Add external host binding permission for Extension DOMUI.

Committing for skare@google.com, original change at http://codereview.chromium.org/3074002/show .

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3189022
------------------------------------------------------------------------
r57416 | jar@chromium.org | 2010-08-26 01:31:30 +0200 (Thu, 26 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h

Handle nested frames more correctly in preconnection logic

BUG=53354
r=mbeleshe
Review URL: http://codereview.chromium.org/3161043
------------------------------------------------------------------------
r57415 | mdm@chromium.org | 2010-08-26 01:30:14 +0200 (Thu, 26 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h

Linux: set the size of the "show password" button in the password manager after realizing it, to get correct font info.
TEST=the button text no longer gets cut off with some fonts
BUG=52117
Review URL: http://codereview.chromium.org/3149033
------------------------------------------------------------------------
r57414 | phajdan.jr@chromium.org | 2010-08-26 01:29:39 +0200 (Thu, 26 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   D /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider_views.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi

GTTF: Move more code from AutomationProvider to TestingAutomationProvider

TEST=ui_tests, chrome_frame_tests
BUG=52097

Review URL: http://codereview.chromium.org/3108049
------------------------------------------------------------------------
r57413 | dhollowa@chromium.org | 2010-08-26 01:28:00 +0200 (Thu, 26 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h

Revert 57385 - Fix for: Autofill on Windows does not work for the first autofillable page encountered.

Reverting so we can address jhawkins concerns before relanding.

BUG=51831
TEST=In the bug.
Review URL: http://codereview.chromium.org/3149005

TBR=georgey@chromium.org, jhawkins@chromium.org

Review URL: http://codereview.chromium.org/3135050
------------------------------------------------------------------------
r57399 | jrg@chromium.org | 2010-08-25 23:49:44 +0200 (Wed, 25 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm

Try to fix top crasher.

The problem is timing related so I am unable to write a unit test which proves this fixes things.  The essence of the change is to make sure we don't send messages to objects which no longer exist by clearing the delegate pointer in objects we own before we go away (where "we" is an object).  The delegate pattern does not get retained, which gives certain objects to hold dangling pointers.  

BUG=53205  http://crbug.com/53205

Review URL: http://codereview.chromium.org/3158031
------------------------------------------------------------------------
r57397 | dhollowa@chromium.org | 2010-08-25 23:45:52 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

AutoFill incorrectly matches a radio control on youtube.com

Changes AutoFill heuristics to match against only form input element types that we actually fill.

BUG=47925
TEST=FormStructureTest.MatchSpecificInputTypes

Review URL: http://codereview.chromium.org/3153038
------------------------------------------------------------------------
r57394 | jhawkins@chromium.org | 2010-08-25 23:32:35 +0200 (Wed, 25 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.html
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.js

DOMUI: Enable and disable the 'Ok' button on the AutoFill address and credit
card overlays in response to user input.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3199018
------------------------------------------------------------------------
r57393 | chaitanyag@chromium.org | 2010-08-25 23:31:59 +0200 (Wed, 25 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_image_view.cc
   A /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_handler.cc
   A /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_handler.h
   A /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.cc
   A /trunk/src/chrome/browser/chromeos/login/wizard_accessibility_helper.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/chrome_browser.gypi

Add code to initialize accessibility for UI in the ChromeOS startup wizard.
Review URL: http://codereview.chromium.org/3159028
------------------------------------------------------------------------
r57391 | johnnyg@chromium.org | 2010-08-25 23:31:05 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm

Defensive patch that prevents a crash which doesn't have a solid repro but has been reported as still happening.

BUG=47758
TEST=none

Review URL: http://codereview.chromium.org/3197020
------------------------------------------------------------------------
r57388 | cpu@chromium.org | 2010-08-25 23:20:08 +0200 (Wed, 25 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc

Fix browser hang when blocking hulu pop-out

Flash while drawing the movie frames cannot handle being sized 0-by-0 and
a storm of math exception happen which prevents flash from pumping messages

BUG=52754
TEST=see bug


Review URL: http://codereview.chromium.org/3132043
------------------------------------------------------------------------
r57387 | kkania@chromium.org | 2010-08-25 23:12:09 +0200 (Wed, 25 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc

Do not refetch or clear the accessibility tree if the navigation is within the same page. This happens with links pointing to a location within the current page.
BUG=52943
TEST=none
Review URL: http://codereview.chromium.org/3205002
------------------------------------------------------------------------
r57385 | georgey@chromium.org | 2010-08-25 23:03:32 +0200 (Wed, 25 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h

Fix for: Autofill on Windows does not work for the first autofillable page encountered.
BUG=51831
TEST=In the bug.
Review URL: http://codereview.chromium.org/3149005
------------------------------------------------------------------------
r57384 | erg@google.com | 2010-08-25 23:01:34 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/browser/wrench_menu_model_unittest.cc
   M /trunk/src/chrome/test/menu_model_test.h

Reapply menu model cleanups, with WrenchMenuModel being a SimpleMenuModel.

BUG=47320
TEST=compiles

Review URL: http://codereview.chromium.org/3184021
------------------------------------------------------------------------
r57382 | csilv@chromium.org | 2010-08-25 22:58:25 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   A /trunk/src/chrome/browser/resources/options/alert_overlay.css
   A /trunk/src/chrome/browser/resources/options/alert_overlay.html
   A /trunk/src/chrome/browser/resources/options/alert_overlay.js
   M /trunk/src/chrome/browser/resources/options.html

dom-ui options: Implement the 'Reset to Defaults' button.  Also add a general AlertOverlay class.

BUG=53241
TEST=Exercice the 'Reset to Defaults' button in the dom-ui options window.
Review URL: http://codereview.chromium.org/3140027
------------------------------------------------------------------------
r57380 | xiyuan@chromium.org | 2010-08-25 22:48:37 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/cookies_view_handler.cc
   A /trunk/src/chrome/browser/dom_ui/cookies_view_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.js
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   A /trunk/src/chrome/browser/resources/options/cookies_tree.js
   A /trunk/src/chrome/browser/resources/options/cookies_view.css
   A /trunk/src/chrome/browser/resources/options/cookies_view.html
   A /trunk/src/chrome/browser/resources/options/cookies_view.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Add a cookies view based on old UI.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3161036
------------------------------------------------------------------------
r57375 | evan@chromium.org | 2010-08-25 22:28:03 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/browser_theme_pack.cc
   D /trunk/src/chrome/browser/browser_theme_pack.h
   D /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   D /trunk/src/chrome/browser/browser_theme_provider.cc
   D /trunk/src/chrome/browser/browser_theme_provider.h
   D /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   D /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   D /trunk/src/chrome/browser/browser_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/ntp_background_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.cc
   A /trunk/src/chrome/browser/themes
   A /trunk/src/chrome/browser/themes/browser_theme_pack.cc (from /trunk/src/chrome/browser/browser_theme_pack.cc:57374)
   A /trunk/src/chrome/browser/themes/browser_theme_pack.h (from /trunk/src/chrome/browser/browser_theme_pack.h:57374)
   A /trunk/src/chrome/browser/themes/browser_theme_pack_unittest.cc (from /trunk/src/chrome/browser/browser_theme_pack_unittest.cc:57374)
   A /trunk/src/chrome/browser/themes/browser_theme_provider.cc (from /trunk/src/chrome/browser/browser_theme_provider.cc:57374)
   A /trunk/src/chrome/browser/themes/browser_theme_provider.h (from /trunk/src/chrome/browser/browser_theme_provider.h:57374)
   A /trunk/src/chrome/browser/themes/browser_theme_provider_gtk.cc (from /trunk/src/chrome/browser/browser_theme_provider_gtk.cc:57374)
   A /trunk/src/chrome/browser/themes/browser_theme_provider_mac.mm (from /trunk/src/chrome/browser/browser_theme_provider_mac.mm:57374)
   A /trunk/src/chrome/browser/themes/browser_theme_provider_unittest.cc (from /trunk/src/chrome/browser/browser_theme_provider_unittest.cc:57374)
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/theme_background.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.cc

Move theme files in chrome/browser/ into a themes/ subdir.

Rename (and resort) every #include.

BUG=50548
TEST=compiles

Review URL: http://codereview.chromium.org/3173043
------------------------------------------------------------------------
r57373 | scottbyer@chromium.org | 2010-08-25 22:16:27 +0200 (Wed, 25 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h
   M /trunk/src/views/widget/widget_gtk.cc

Fix regression caused by http://codereview.chromium.org/2768006/show

Using the new preferred size attributes for non-GtkViewsFixed widgets
won't do very much.  Put the gtk_widget_size_allocation call back for
those widgets.  Add in a small check into the ScreenLockerTest.TestBasic to prevent any future such regression.

BUG=chromium-os:5987
TEST=ScreenLockerTest.TestBasic

Review URL: http://codereview.chromium.org/3181039
------------------------------------------------------------------------
r57370 | atwilson@chromium.org | 2010-08-25 22:05:29 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_util.cc

Expose GetStockPreferencesMenuLabel() on ChromeOS also.

TBR=tommi

Review URL: http://codereview.chromium.org/3132042
------------------------------------------------------------------------
r57365 | kinuko@chromium.org | 2010-08-25 21:44:49 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   A /trunk/src/chrome/common/file_system
   A /trunk/src/chrome/common/file_system/file_system_dispatcher.cc
   A /trunk/src/chrome/common/file_system/file_system_dispatcher.h
   A /trunk/src/chrome/common/file_system/file_system_dispatcher_dummy.cc
   A /trunk/src/chrome/common/file_system/webfilesystem_impl.cc
   A /trunk/src/chrome/common/file_system/webfilesystem_impl.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

Add WebFileSystemImpl and 2nd cut of IPC plumbing code for Move operation.

Plumbing code for the remaining operations (Copy, Remove etc) will come later in a separate patch once this one becomes to look good.

BUG=32277
TESTS=none, will be added later

Review URL: http://codereview.chromium.org/3165040
------------------------------------------------------------------------
r57364 | atwilson@chromium.org | 2010-08-25 21:31:00 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Added options/preferences menu item to status icon context menus. Also refactored code to get the stock preferences menu item label out of wrench_menu_model and into gtk_utils where it can be shared.

BUG=37375
TEST=none

Review URL: http://codereview.chromium.org/3175032
------------------------------------------------------------------------
r57359 | amarinichev@chromium.org | 2010-08-25 20:51:54 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

When compositor is enabled, do not do backing store updates.
BUG=52517
TEST=enable compositor and resize the window; there should be no continuous redraws

Review URL: http://codereview.chromium.org/3204004
------------------------------------------------------------------------
r57358 | rsesek@chromium.org | 2010-08-25 20:45:12 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a flag for the showing the Page Info dialog as a bubble. This adds stubs for all platforms.

BUG=52916
TEST=Compile.  Page Info works as before.

Review URL: http://codereview.chromium.org/3175037
------------------------------------------------------------------------
r57351 | akalin@chromium.org | 2010-08-25 20:32:53 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc

Turn on apps sync by default.

BUG=46512
TEST=manual

Review URL: http://codereview.chromium.org/3144012
------------------------------------------------------------------------
r57349 | erg@google.com | 2010-08-25 20:00:29 +0200 (Wed, 25 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc

Fix build.

TBR: tommi@chromium.org
------------------------------------------------------------------------
r57345 | erg@google.com | 2010-08-25 19:33:59 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_page_unittest.cc
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/collected_cookies_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate_unittest.cc
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/web_applications/web_app_unittest.cc
   M /trunk/src/chrome/browser/wrench_menu_model_unittest.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc

FBTF: Minor cleanup to testing headers.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3136014
------------------------------------------------------------------------
r57344 | phajdan.jr@chromium.org | 2010-08-25 19:33:34 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider_mac.mm
   A /trunk/src/chrome/browser/automation/testing_automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTTF: Continue moving testing automation bits out of AutomationProvider.

TEST=ui_tests, chrome_frame_tests
BUG=52097

Review URL: http://codereview.chromium.org/3167038
------------------------------------------------------------------------
r57343 | mirandac@chromium.org | 2010-08-25 19:31:00 +0200 (Wed, 25 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Commit http://codereview.chromium.org/3112033/show, fixing status bubble in RTL.

Review URL: http://codereview.chromium.org/3135046
------------------------------------------------------------------------
r57340 | johnnyg@chromium.org | 2010-08-25 19:23:42 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html

Make the choose datatypes section of sync setup UI wider and supply titles for the labels so that the long text can be seen on hover even if it still doesn't fit.

BUG=52789
TEST=open sync setup ui in a language with long words

Review URL: http://codereview.chromium.org/3197019
------------------------------------------------------------------------
r57337 | viettrungluu@chromium.org | 2010-08-25 18:50:48 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/app/tree_node_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h

Remove wstrings from bookmarks, part 14.

Convert TreeNodeWithValue's methods to string16.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3198014
------------------------------------------------------------------------
r57328 | thakis@chromium.org | 2010-08-25 16:36:32 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Work around deadlock

This makes painting a bit uglier, but that's better than a deadlock.

BUG=52798
TEST=see bug

Review URL: http://codereview.chromium.org/3107035
------------------------------------------------------------------------
r57326 | denisromanov@chromium.org | 2010-08-25 16:14:03 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc

Modified visual appearance of the OOBE update screen to closer resemble mock at http://www.corp.google.com/~kenmoore/mocks/chromeos/OOBE_Latest/OOBE_0015_Update.png
BUG=chromium-os:5781
TEST=Compare update screen to the mock visually.

Review URL: http://codereview.chromium.org/3104029
------------------------------------------------------------------------
r57323 | satish@chromium.org | 2010-08-25 15:49:17 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_recognizer.h

Fix order of includes in header file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3110039
------------------------------------------------------------------------
r57322 | tfarina@chromium.org | 2010-08-25 15:40:31 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.css
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html

Reland r55881: Disable the 'Clear browsing Data' button when no checkboxes are checked.

BUG=49037
TEST=out/Debug/chrome --enable-tabbed-options. Go to 'Under the Hood' tab, open the
dialog, check some checkbox, the button should become enabled, uncheck all the
checkboxes, the button should become disabled.

Review URL: http://codereview.chromium.org/3143012
------------------------------------------------------------------------
r57320 | pfeldman@chromium.org | 2010-08-25 15:19:59 +0200 (Wed, 25 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

DevTools: support disabled and checked context menu items.

Review URL: http://codereview.chromium.org/3141042
------------------------------------------------------------------------
r57319 | fgalligan@chromium.org | 2010-08-25 14:37:36 +0200 (Wed, 25 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc
   A /trunk/src/chrome/test/data/media/bear.webm
   A /trunk/src/chrome/test/data/media/bear_silent.webm

Add simple playback tests for WebM and MP4 files.

BUG=52866
TEST=The two new WebM tests pass in Chromium and all four new tests pass in
Chrome.

Review URL: http://codereview.chromium.org/3176035
------------------------------------------------------------------------
r57314 | finnur@chromium.org | 2010-08-25 12:40:25 +0200 (Wed, 25 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/theme/pageinfo_bad.png
   M /trunk/src/chrome/app/theme/pageinfo_good.png
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/browser/views/page_info_bubble_view.h
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Revert 57311 - Part 2 of the SSL InfoBubble.

- Added Certificate Information link.

- Changed iconography to be:
  Identity  : Green check mark vs. Red skull and bones
  Connection: Green padlock vs. Orange exclamation point.
  (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3136031

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3170043
------------------------------------------------------------------------
r57313 | finnur@chromium.org | 2010-08-25 12:38:41 +0200 (Wed, 25 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc

Revert 57312 - Fix build break on Linux x64.

TBR=jcivelli
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3180024

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3175040
------------------------------------------------------------------------
r57312 | finnur@chromium.org | 2010-08-25 12:34:31 +0200 (Wed, 25 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc

Fix build break on Linux x64.

TBR=jcivelli
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3180024
------------------------------------------------------------------------
r57311 | finnur@chromium.org | 2010-08-25 12:25:31 +0200 (Wed, 25 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/theme/pageinfo_bad.png
   M /trunk/src/chrome/app/theme/pageinfo_good.png
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   M /trunk/src/chrome/browser/views/page_info_bubble_view.h
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Part 2 of the SSL InfoBubble.

- Added Certificate Information link.

- Changed iconography to be:
  Identity  : Green check mark vs. Red skull and bones
  Connection: Green padlock vs. Orange exclamation point.
  (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3136031
------------------------------------------------------------------------
r57304 | kochi@chromium.org | 2010-08-25 10:50:33 +0200 (Wed, 25 Aug 2010) | 29 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Remove redundant "keyboard layout" suffix and fix redundant language display.

This issue is two-fold:

1) Remove "keyboard layout"-suffix from layouts
2) Do not show language name if obvious

For 1, basically I removed the suffix from keyboard layout names.
There are 2 exceptions:
 * For Japanese, to avoid confusion between Jpaanese input methods and
   Japanese keyboard layout, the suffix is intentionally kept.
 * For keyboard layouts used for Dutch, French and German,
   the suffix is kept (see below for the reason).

For 2,
* for non-ambiguous languages (do not have multiple input methods or layouts),
  show input method name or layout name
* for ambiguous languages
  - show keyboard layout or input method name without language name for
    other languages (as their layout name or input method name explicitly
    or implicitly imply language name)
  - show "language - layout" pair for Dutch, French and German
    (They share "Belgian" keyboard layout in common, showing only "Belgian"
    is ambiguous about language)

BUG=chromium-os:5804
TEST=./unit_tests --gtest_filter="LanguageMenu*" and manually check on ChromeOS device whether the menu text and notification menu are displayed as expected.

Review URL: http://codereview.chromium.org/3185020
------------------------------------------------------------------------
r57302 | mnissler@chromium.org | 2010-08-25 10:32:55 +0200 (Wed, 25 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/app/policy/mac/app-Manifest.plist
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h

Implement policy for disabling auto fill.

This introduces a new policy setting named AutoFillEnabled that administrators
can use to switch off the auto fill feature. The UI adjustments disable the
autofill button and dialog in the preferences dialog appropriate.

Preferences.xib change: Bind enabled state of the auto fill button to
autoFillSettingsButtonEnabled @property.
AutoFillDialog.xib change: Bind enabled state of the auto fill enabled checkbox and save button
to the autoFillEnabledAvailable and saveEnabled @properties, respectively.

BUG=49611
TEST=autofill_dialog_controller_mac_unittest.mm, manual testing

Review URL: http://codereview.chromium.org/3140024
------------------------------------------------------------------------
r57301 | akalin@chromium.org | 2010-08-25 10:15:37 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h

Fixed CacheInvalidationPacketHandler crash.

Made CacheInvalidationPacketHandler use a ScopedCallbackFactory.

BUG=53201
TEST=manually with sync_listen_notifications

Review URL: http://codereview.chromium.org/3191024
------------------------------------------------------------------------
r57300 | mbelshe@chromium.org | 2010-08-25 09:52:09 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer.cc
   M /trunk/src/net/base/net_log_event_type_list.h

Remove dead log entries for SPDY_TRANSACTION_*

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3205003
------------------------------------------------------------------------
r57294 | eroman@chromium.org | 2010-08-25 08:03:48 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/proxy_config_service_impl.cc
   M /trunk/src/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings_unittest.cc
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service_common_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_common_unittest.h
   M /trunk/src/net/proxy/proxy_config_service_mac.cc
   M /trunk/src/net/proxy/proxy_config_unittest.cc

Cleanup: rename ProxyRules::socks_proxy --> ProxyRules::fallback_proxy.

BUG=None
TEST=Compiles
Review URL: http://codereview.chromium.org/3146029
------------------------------------------------------------------------
r57293 | isherman@chromium.org | 2010-08-25 07:33:05 +0200 (Wed, 25 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Ctrl-based actions should take precedence over ctrl-enter

When the user presses ctrl, prefer (keeping) inline autocomplete
matches to (new, surprising) exact matches that include the
desired TLD.

BUG=52566
TEST=none

Review URL: http://codereview.chromium.org/3152029
------------------------------------------------------------------------
r57292 | viettrungluu@chromium.org | 2010-08-25 06:54:09 +0200 (Wed, 25 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/test/model_test_utils.cc
   M /trunk/src/chrome/test/model_test_utils.h

Remove wstrings from bookmarks, part 13.

This eliminates wstrings from bookmark_model_unittest.cc, which entails removing
them from model_test_utils.*.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3141033
------------------------------------------------------------------------
r57288 | tbarzic@google.com | 2010-08-25 06:07:16 +0200 (Wed, 25 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/resources/about_sys.html

Enabling about:system page to select shown entries and to scroll to specific entry

TEST=Open about:system. Table containing available system information is shown.
Clicking on button Expand shows associated entry, and clicking on Collapse hides it. Initialy all entries are hidden. 
Clicking on Expand all / Collapse all shows / hides all entries.
about:system/foo hides all entries but foo, and scrolls to it  

BUG=4973

Review URL: http://codereview.chromium.org/3173038
------------------------------------------------------------------------
r57284 | viettrungluu@chromium.org | 2010-08-25 05:22:40 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

Remove execute bits on tfarina's r57282.

TBR=tfarina@chromium.org,rohitrao@chromium.org

Review URL: http://codereview.chromium.org/3111032
------------------------------------------------------------------------
r57282 | tfarina@chromium.org | 2010-08-25 04:51:11 +0200 (Wed, 25 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

Rename the title of the Chromium Preferences dialog.

The menu currently is Preferences, so the dialog title should be named Chromium Preferences to match with it.

BUG=53114
TEST=run chrome, click on "Preferences" menu item. See if the dialog title is "Chromium/Google Chrome Preferences".

Screenshot: http://imgur.com/vferP

Review URL: http://codereview.chromium.org/3151031
------------------------------------------------------------------------
r57281 | mrossetti@chromium.org | 2010-08-25 04:19:57 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Minor adjustments to bookmark folder menu button placement during button moves/adds/deletes.  In most cases it was a simple matter of not accounting for the vertical separation between buttons.  In the case of a button add I reworked the logic a bit.

BUG=51730
TEST=1) Cut or delete a bookmark button at the top, middle and bottom of a bookmark folder and verify that the button placement is correct. 2) Past a bookmark button at top, middle and bottom and verify button placement and that of the buttons above the insertion. 3) Drag move a button both upward and downward, including to the very top and the very bottom, and verify proper button placement and the placement of the buttons above the button moved as well as those buttons between the 'from' location and the 'to' location.

Review URL: http://codereview.chromium.org/3137038
------------------------------------------------------------------------
r57276 | ziadh@chromium.org | 2010-08-25 03:45:22 +0200 (Wed, 25 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/socket/client_socket.cc
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc

A/B experiment for re-establishing TCP connections.

We would like to test the impact of automatic retries when a TCP connection exceeds a certain threshold before it gets back an ACK. We are observing a fair number of sockets where the connection had been established, but the sockets
were not used thereafter.


r=mbelche


Review URL: http://codereview.chromium.org/3191019
------------------------------------------------------------------------
r57275 | ziadh@chromium.org | 2010-08-25 03:45:21 +0200 (Wed, 25 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

Reduce browser work for consecutive fetch plugins list requests

I introduced a 3-second threshold value between consecutive fetch-plugin requests
that induce a disk read (on the file thread) by forcing a refresh. Now, if
multiple requests are made within the threshold values, no disk read will be
performed. Average request times have been reduced from 11ms/request down to
1ms/request.

BUG=44813
r=brettw

Review URL: http://codereview.chromium.org/3192013
------------------------------------------------------------------------
r57271 | derat@chromium.org | 2010-08-25 03:02:51 +0200 (Wed, 25 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

chromeos: Update autocomplete popup colors.

This fetches them from GTK using the same logic as is used in
the GTK port.

BUG=chromium-os:3916
TEST=built and ran it for GTK and Chrome OS Views

Review URL: http://codereview.chromium.org/3198013
------------------------------------------------------------------------
r57269 | cmasone@google.com | 2010-08-25 02:53:44 +0200 (Wed, 25 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h
   A /trunk/src/chrome/browser/chromeos/login/mock_owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   A /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.h
   A /trunk/src/chrome/browser/chromeos/login/ownership_service.cc
   A /trunk/src/chrome/browser/chromeos/login/ownership_service.h
   A /trunk/src/chrome/browser/chromeos/login/ownership_service_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Chrome OS] Wire up ownership API from libcros

I added an asynchronous API to libcros for setting the Owner's key
on Chrome OS.  This CL wires that out through LoginLibrary and also
refactors the OwnerManager class into the OwnershipService, a
Singleton that will provide access to the entire Ownership API --
which includes methods for whitelisting users and signed preferences.
The OwnerManager class is now just there to manage the Owner's
key and operations with that key.

A consumer of this API can call methods of OwnershipService, which will post tasks to run methods from OwnerManager (on the FILE thread if appropriate).  The OwnerManager will, in turn, call methods of LoginLibrary to perform owner key operations.  Since these calls to LoginLibrary are asyncrhonous, OwnerManager implements LoginLibrary::Delegate and passes |this|, so that LoginLibrary can call back to the OwnerManager when asynchronous operations are completed.

BUG=chromium-os:4488
TEST=unit tests

Review URL: http://codereview.chromium.org/3141031
------------------------------------------------------------------------
r57266 | atwilson@chromium.org | 2010-08-25 02:37:35 +0200 (Wed, 25 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc

BackgroudModeManager now listens for APP_TERMINATING and shuts down background
mode in all cases (now uses same code path for --keep-alive-for-test and for
background apps) - this is necessary because ExtensionsService does not
generate EXTENSION_UNLOADED notifications when the app shuts down as I thought.

With this fix, the extension API tests for background apps pass without
disabling background mode.

BUG=53021
TEST=extension API tests pass now with background mode enabled.

Review URL: http://codereview.chromium.org/3198007
------------------------------------------------------------------------
r57262 | csilv@chromium.org | 2010-08-25 02:19:47 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/pref_ui.js

dom-ui options: Fix incorrect handling of undefined values in pref UI.

BUG=none
TEST=Verify preference UI works properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3170042
------------------------------------------------------------------------
r57252 | ajwong@chromium.org | 2010-08-25 00:44:00 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc

Revert "Added tooltips to stats bar items."

This reverts commit r57234

TBR: stevenjb
------------------------------------------------------------------------
r57249 | jschuh@google.com | 2010-08-25 00:40:14 +0200 (Wed, 25 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc

Check that BlockedContents::blocked_popup_container is not NULL before using it.

BUG=53176
TEST=None.
Review URL: http://codereview.chromium.org/3204003
------------------------------------------------------------------------
r57248 | mirandac@chromium.org | 2010-08-25 00:36:49 +0200 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/search_engine_top.png
   D /trunk/src/chrome/app/theme/search_engine_top_rtl.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h

Change search engine dialog image to be transparent, and use this image flipped as the RTL dialog top.

BUG=none
TEST=search engine dialog looks fine in LTR and RTL modes

Review URL: http://codereview.chromium.org/3171028
------------------------------------------------------------------------
r57246 | dhollowa@chromium.org | 2010-08-25 00:33:23 +0200 (Wed, 25 Aug 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/form_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/name_field_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill address profile not seen in dropdown for name and address field on dell.com

Modifies AutoFill heuristics to match middle initial at end of string instead of strict match of whole string.  Also, adds form_field_unittest.cc with specific unit tests for pattern matching.

BUG=45123
TEST=FormFieldTest.Match, NameFieldTest.MiddleInitialAtEnd

Review URL: http://codereview.chromium.org/3127030
------------------------------------------------------------------------
r57238 | jhawkins@chromium.org | 2010-08-24 23:33:01 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.h
   M /trunk/src/chrome/browser/resources/options/autofill_options.js

DOMUI: Implement the 'Remove...' button on the AutoFill page.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3140026
------------------------------------------------------------------------
r57236 | phajdan.jr@chromium.org | 2010-08-24 23:25:25 +0200 (Tue, 24 Aug 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_messages_browsertest.cc (from /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc:57223)
   D /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   A /trunk/src/chrome/browser/sessions/tab_restore_service_browsertest.cc (from /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc:57223)
   D /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/renderer/form_manager_browsertest.cc (from /trunk/src/chrome/renderer/form_manager_unittest.cc:57223)
   D /trunk/src/chrome/renderer/form_manager_unittest.cc
   A /trunk/src/chrome/renderer/pepper_devices_browsertest.cc (from /trunk/src/chrome/renderer/pepper_devices_unittest.cc:57223)
   D /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   A /trunk/src/chrome/renderer/render_view_browsertest.cc (from /trunk/src/chrome/renderer/render_view_unittest.cc:57233)
   A /trunk/src/chrome/renderer/render_view_browsertest_mac.mm (from /trunk/src/chrome/renderer/render_view_unittest_mac.mm:57223)
   D /trunk/src/chrome/renderer/render_view_unittest.cc
   D /trunk/src/chrome/renderer/render_view_unittest_mac.mm
   A /trunk/src/chrome/renderer/translate_helper_browsertest.cc (from /trunk/src/chrome/renderer/translate_helper_unittest.cc:57223)
   D /trunk/src/chrome/renderer/translate_helper_unittest.cc

GTTF: move tests that use WebKit from unit_tests to browser_tests
to avoid crashes.

TBR=dhollowa, sky, erikkay

TEST=unit_tests, browser_tests
BUG=52731, 52643
Review URL: http://codereview.chromium.org/3150034
------------------------------------------------------------------------
r57234 | stevenjb@chromium.org | 2010-08-24 23:08:00 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc

Added tooltips to stats bar items.
BUG=chromium-os:5601 (http://code.google.com/p/chromium-os/issues/detail?id=5601)
TEST=Check that hover text over status bar icons seems reasonable. Test different states of network (disconnected, ethernet, connecting to a wifi network, connected to a wifi network) and battery (plugged in, unplugged).

Review URL: http://codereview.chromium.org/3158014
------------------------------------------------------------------------
r57230 | dhg@chromium.org | 2010-08-24 22:44:03 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css

Changing options page css so that we don't get that irritating little box around nav bar items.

BUG=chromium-os:6059
TEST=none

Review URL: http://codereview.chromium.org/3157037
------------------------------------------------------------------------
r57229 | erg@google.com | 2010-08-24 22:29:02 +0200 (Tue, 24 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_page_unittest.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/device_orientation/dispatcher_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/search_engines/search_provider_install_state_dispatcher_host.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_localization_peer.cc
   M /trunk/src/chrome/common/gpu_messages.cc
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/indexed_db_param_traits.h
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   A /trunk/src/chrome/common/render_messages_params.cc
   A /trunk/src/chrome/common/render_messages_params.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/utility_messages.cc
   M /trunk/src/chrome/common/utility_messages_internal.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.cc
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_video_decoder.cc
   M /trunk/src/chrome/gpu/gpu_view_win.cc
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/device_orientation_dispatcher.cc
   M /trunk/src/chrome/renderer/device_orientation_dispatcher.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/external_extension.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl_unittest.cc
   M /trunk/src/chrome/renderer/mock_printer.cc
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/notification_provider.cc
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_mac.mm
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/ipc/ipc.gypi
   M /trunk/src/ipc/ipc_message_utils.h
   A /trunk/src/ipc/ipc_param_traits.h

FBTF: Move individual XXXMsg_Params structs to a new file.

The new file, render_messages_params.h, is included in 57 files, while
render_messages.h is included in 176 files. Moving the Params structs to their
own file allow pruning the included headers.

(Part 2 of this cleanup will be sorting the individual structs into themes
to further minimize header inclusion.)

BUG=51411
TEST=compiles

Review URL: http://codereview.chromium.org/3119035
------------------------------------------------------------------------
r57228 | dumi@chromium.org | 2010-08-24 22:26:23 +0200 (Tue, 24 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/base/file_util_proxy.cc
   M /trunk/src/base/file_util_proxy.h
   M /trunk/src/base/platform_file.h
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.h

Change the FileUtilProxy callbacks to report error codes instead of booleans.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/3165050
------------------------------------------------------------------------
r57226 | satish@chromium.org | 2010-08-24 22:22:02 +0200 (Tue, 24 Aug 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/speech/endpointer
   A /trunk/src/chrome/browser/speech/endpointer/endpointer.cc
   A /trunk/src/chrome/browser/speech/endpointer/endpointer.h
   A /trunk/src/chrome/browser/speech/endpointer/endpointer_unittest.cc
   A /trunk/src/chrome/browser/speech/endpointer/energy_endpointer.cc
   A /trunk/src/chrome/browser/speech/endpointer/energy_endpointer.h
   A /trunk/src/chrome/browser/speech/endpointer/energy_endpointer_params.h
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add an endpointer for detecting end of speech.
This is based on existing code/math. I have removed all the unused code for our usage and adapted to the chromium coding style.

TEST=unit_tests --gtest_filter=EndpointerTest.*
BUG=none

Review URL: http://codereview.chromium.org/3117026
------------------------------------------------------------------------
r57225 | atwilson@chromium.org | 2010-08-24 22:21:51 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Added prefs ui for enabling/disabling background mode on windows.
BUG=53173
TEST=none yet (will add tests when BackgroundModeManager handles prefs notifications)

Review URL: http://codereview.chromium.org/3200007
------------------------------------------------------------------------
r57222 | johnnyg@chromium.org | 2010-08-24 21:46:26 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.cc
   A /trunk/src/chrome/browser/tab_contents/tab_contents_file_select_helper.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc

Add support for a directory file chooser command, which creates a file list by enumerating all the files in the selected directory.

BUG=47162
TEST=layout test input-file-directory-upload.html, or www/~johnnyg/dir_upload/ demo page

Review URL: http://codereview.chromium.org/2825051
------------------------------------------------------------------------
r57216 | csilv@chromium.org | 2010-08-24 21:00:48 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/pref_ui.js

Tweak preference code to work with or without the 'managed' property, makes for easier use on CrOS.

BUG=none
TEST=Verify CrOS preferences working properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3174032
------------------------------------------------------------------------
r57215 | andybons@chromium.org | 2010-08-24 20:58:28 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Fix a bug where you could not uninstall a disabled extension.

BUG=53035
TEST=none

Review URL: http://codereview.chromium.org/3151033
------------------------------------------------------------------------
r57208 | jcivelli@chromium.org | 2010-08-24 20:26:31 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Don't offer to translate the bookmark manager page.

BUG=52765
TEST=Bookmark sites in a language different than the language Chrome is configured in (you should have few of them, with titles long enough, so there are more than 100 characters in that language). Go to the bookmark manager, no translate infobar should be shown.

Review URL: http://codereview.chromium.org/3130045
------------------------------------------------------------------------
r57207 | thakis@chromium.org | 2010-08-24 20:00:56 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Cleanups for http://codereview.chromium.org/3176027

BUG=TEST=none

Review URL: http://codereview.chromium.org/3142035
------------------------------------------------------------------------
r57205 | sky@chromium.org | 2010-08-24 19:42:59 +0200 (Tue, 24 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fixes bug where Layout might not get invoked on view hosting
tabcontents after an animation that would result in a gray rect.

BUG=53083
TEST=see bug

Review URL: http://codereview.chromium.org/3142034
------------------------------------------------------------------------
r57204 | kuan@chromium.org | 2010-08-24 19:34:08 +0200 (Tue, 24 Aug 2010) | 32 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/proxy_config_service.h
   A /trunk/src/chrome/browser/chromeos/proxy_config_service_impl.cc
   A /trunk/src/chrome/browser/chromeos/proxy_config_service_impl.h
   A /trunk/src/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_service.cc

chromeos: 1st draft of ProxyConfigService for chromeos

what this cl is:
- a REALLY bare skeleton implementation of ProxyConfigService for chromeos (lots of design details remain to be worked out on the chromeos side, but i needed to get something basic up)
- focused on getting chrome part correct, extracting design flow and implementation from linux variant that are relevant to chromeos, e.g.: 
  - provide access of ProxyConfigService interface on IO thread
  - provide methods on UI thread for UI to read/modify proxy config (like linux's GConf notifications on UI thread)
  - fetch initial config on UI thread (this is not absolutely necessary for chromeos, 'cos i don't use GConf, but i just follow linux for now)
  - however, the class is RefCountedThreadSafe (so that both net::ProxyService and DOMUI can access it), and the code resides in chrome/browser/chromeos dir instead of net/proxy.  
  - design details are in .h files
- initial config is hardcoded as pac script and loaded as owner (TODO: load this from cros settings persisted on chromeos device)
  - this should work like the current chromeos session manager which sets the auto-proxy environment variable in login script to the same pac script
- implement an augmented analogue to net::ProxyConfig to hold actual proxy config and UI settings (e.g. source and readonly attributes)
  - backend uses this as the main proxy config, and only converts it to net:::ProxyConfig for network stack on the IO thread in net::ProxyService::GetLatestProxyConfig.
  - UI methods also use this structure
- provide methods to get and set configs from UI thread 
  - UI can use dom_ui->GetProfile()->GetChromeOSProxyConfigServiceImpl() to access these methods on the UI thread
  - these methods are by no means final
    - i only added them here to verify the design flow that modifications can be made from UI thread and picked up by IO thread.
    - david and i will improve or modify them to whatever works best for frontend and backend.
- unittest that tests most functionalities: socks and bypass_rules will be enabled in a later cl.

TODOs after this cl:
- work with UI, load initial config as owner from cros settings
- implement policy mechanism, merge it with owner during initial load and modifications
- persist proxy settings
- etc etc etc

BUG=chromium-os:5127
TEST=nothing yet.

Review URL: http://codereview.chromium.org/3047052
------------------------------------------------------------------------
r57201 | thakis@chromium.org | 2010-08-24 19:17:31 +0200 (Tue, 24 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Mac: Well-behaved accelerated plugins, actual fix

Configure the opengl view to draw below the window, draw the view with NSClearColor so that's transparent, and make the window non-opaque while plugins are showing, so that the opengl surface can show through.

This is a bit slower than previously without this patch, but it's about as fast as it was when we used CoreAnimation to show IOSurfaces.

Parts of this code are from Simon Fraser's MacTierra code (with permission).

BUG=44087,51748
TEST=
* Go to youtube. Findbar should show up on top of video. Go fullscreen. Tab overlay should show up on top of video.
* Go to youtube, drag tab with video out and to a new window. Video should continue playing.
* Install https://chrome.google.com/extensions/detail/bdnkaenpadjoldiddfdidinjmjeagaji , click browser action. Should still work.
* Install a transparent theme such as https://tools.google.com/chrome/intl/cy/themes/theme_at_mecko.html or http://chromium.googlecode.com/issues/attachment?aid=3778755830122130591&name=theme-bug.crx&token=27908ca7e699a023c8446657b24c4696 . Browser window shouldn't become transparent while videos are playing.

Review URL: http://codereview.chromium.org/3176027
------------------------------------------------------------------------
r57200 | csilv@chromium.org | 2010-08-24 19:15:40 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/font_settings_overlay.html
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options/preferences.js

reland 57093: dom-ui options: record user metrics for pref changes.

BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3153034
------------------------------------------------------------------------
r57199 | satish@chromium.org | 2010-08-24 19:06:49 +0200 (Tue, 24 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/speech_input_processing.png
   A /trunk/src/chrome/app/theme/speech_input_recording.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/speech/speech_input_bubble.h
   A /trunk/src/chrome/browser/views/speech_input_bubble.cc
   M /trunk/src/chrome/chrome_browser.gypi

Adds a speech input info bubble.

I have not implemented the Mac/Linux part yet, will do so in a subsequent CL (does InfoBubble exist for Mac?).

This info bubble remains visible on screen until recognition ends or the user cancels it.
It also tracks the html element which requested speech recognition if it changes position
on screen (e.g. user scrolls the page or moves the browser window).

To get this working, I extended InfoBubble to query the delegate if it can be closed when
another window gets activated, as well as to reposition it when required.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3133034
------------------------------------------------------------------------
r57197 | prasadt@chromium.org | 2010-08-24 18:52:53 +0200 (Tue, 24 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Autorestart on update should happen when (among other things), the browser is in
KeepAlive mode.  The condition to check that in CanAutorestartForUpdate() is
reversed.

BUG=none
TEST=On Linux - Change BrowserProcessImpl::StartAutoupdateTimer() function to
change the timer from 6hrs to 30 seconds.  Build and run chrome with
--no-startup-window and --keep-alive-for-test flags.  Run "touch" on browser
exe to fake an update.  Wait for 30 seconds and verify that the browser shuts
down and restarts.

Review URL: http://codereview.chromium.org/3206003
------------------------------------------------------------------------
r57196 | jrg@chromium.org | 2010-08-24 18:52:07 +0200 (Tue, 24 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/test/ui_test_utils_mac.mm

Minor fixes to keep TOT working with the 10.6 SDK. 

Review URL: http://codereview.chromium.org/3137033
------------------------------------------------------------------------
r57193 | dmazzoni@chromium.org | 2010-08-24 18:27:33 +0200 (Tue, 24 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   D /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Revert 57188 - Add html node info (tag name, attributes, and computed display) and document
info (url, title, mimetype, doctype) to WebAccessibility.

BUG=none
TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility
TEST=Added new browser test: RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree

Review URL: http://codereview.chromium.org/3013035

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/3173040
------------------------------------------------------------------------
r57189 | mmenke@chromium.org | 2010-08-24 17:55:51 +0200 (Tue, 24 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_source_type_list.h
   M /trunk/src/net/base/net_log_unittest.h
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Adds HostResolveImpl Requests and Jobs to log.

Differences over the reverted version (http://codereview.chromium.org/3080034/show - reverted http://codereview.chromium.org/3137022/show ):
  * Jobs never log anything in their destructor, as the HostResolverImpl randomly outlives the NetLog, at least in some unit tests.
  * Removed the extra log entries for when a DNS lookup starts/completes.  Instead, the job's event is ended in OnLookupComplete().
  * Slight modification of the CanceledAsynchronousLookup unit test, as the Job is now closed before posting any events to the Request.  For actual lookups, this behavior means the Job's duration more accurately reflects the time the DNS lookup takes itself.


BUG=46844
TEST=Look at the net-internals screen.

Review URL: http://codereview.chromium.org/3119027
------------------------------------------------------------------------
r57188 | dmazzoni@chromium.org | 2010-08-24 17:50:18 +0200 (Tue, 24 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   A /trunk/src/chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Add html node info (tag name, attributes, and computed display) and document
info (url, title, mimetype, doctype) to WebAccessibility.

BUG=none
TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility
TEST=Added new browser test: RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree

Review URL: http://codereview.chromium.org/3013035
------------------------------------------------------------------------
r57185 | andreip@chromium.org | 2010-08-24 16:56:05 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc

Implement IDBTransaction::objectStore

This depends on https://bugs.webkit.org/show_bug.cgi?id=44446

Review URL: http://codereview.chromium.org/3165053
------------------------------------------------------------------------
r57184 | dpolukhin@chromium.org | 2010-08-24 16:45:19 +0200 (Tue, 24 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Show update screen for non-official build
because update is enabled for non-official build there is no sense to skip OOBE update screen.

BUG=cromium-os:4002, cromium-os:4003
TEST=Install older Chromium OS build on device, start dev server with
new image (./start_devserver --client_prefix ChromeOSUpdateEngine),
remove Local State and .oobe_completed files.

Review URL: http://codereview.chromium.org/3192014
------------------------------------------------------------------------
r57183 | andreip@chromium.org | 2010-08-24 16:38:58 +0200 (Tue, 24 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h

Fix IDBDatabase::removeObjectStore for multiprocess mode

Review URL: http://codereview.chromium.org/3134029
------------------------------------------------------------------------
r57176 | hans@chromium.org | 2010-08-24 14:54:51 +0200 (Tue, 24 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/device_orientation/dispatcher_host.cc
   M /trunk/src/chrome/browser/device_orientation/dispatcher_host.h
   M /trunk/src/chrome/browser/device_orientation/provider.h

device_orientation::DispatcherHost: one Provider observer per render_view_id.

Refactor device_orientation::DispatcherHost to create a 1-to-1 relationship
between a RenderView and an observer of the Provider. The intention is
to remove the need for logic from DispatcherHost, and in effect have the
RenderView observe the Provider.

BUG=44654
TEST=browser_tests --gtest_filter=DeviceOrientationBrowserTest.BasicTest

Review URL: http://codereview.chromium.org/3152043
------------------------------------------------------------------------
r57168 | jnd@google.com | 2010-08-24 13:31:40 +0200 (Tue, 24 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/test/data/cancelled_redirect_test.html

Fix a few test failures when landing http://trac.webkit.org/changeset/57178.
http://trac.webkit.org/changeset/57178 broke some tests in browser_test and ui_test.

This patch is same as the patch in http://codereview.chromium.org/3136019/show except test RedirectTest.ClientCancelled.

RedirectTest.ClientCancelled was broken on windows platform when landing the original patch. So I revert it.
After digging in code, I found the root cause of why the test was broken on windows platform. Please refer to 
http://crbug.com/53091 for details.
So I add FAILS_ prefix to RedirectTest.ClientCancelled on windows platform. 

BUG=17655
TEST=RedirectTest.ClientCancelled, AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension, ExtensionBrowserTest.WindowOpenInvalidExtension

Review URL: http://codereview.chromium.org/3186023
------------------------------------------------------------------------
r57167 | mnissler@chromium.org | 2010-08-24 13:21:55 +0200 (Tue, 24 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h

Implement policy for controlling "Show Home Button" preference.

Preferences.xib changes: Connect the Enabled pin of the "Show home button" checkbox to PreferencesWindowController's showHomeButtonEnabled @property.

BUG=49603
TEST=manual

Review URL: http://codereview.chromium.org/3171022
------------------------------------------------------------------------
r57159 | allanwoj@chromium.org | 2010-08-24 11:23:58 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h

Removed inheritance of std:less in network data structures
BUG=None
TEST-None

Review URL: http://codereview.chromium.org/3116032
------------------------------------------------------------------------
r57158 | finnur@chromium.org | 2010-08-24 11:05:36 +0200 (Tue, 24 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   A /trunk/src/chrome/browser/views/page_info_bubble_view.cc
   A /trunk/src/chrome/browser/views/page_info_bubble_view.h
   M /trunk/src/chrome/chrome_browser.gypi

First pass at convert the SSL dialogs into InfoBubbles.

This just converts it from being a dialog to being a bubble, with no significant changes to the content.

This is only active on Windows, so I'm leaving the old dialog implementation behind.

Known issues: 
- View certificate not there yet. 
- Doesn't look exactly like the mocks.

BUG=http://crbug.com/52916
TEST=None

Review URL: http://codereview.chromium.org/3136027
------------------------------------------------------------------------
r57146 | aa@chromium.org | 2010-08-24 08:36:25 +0200 (Tue, 24 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc

When launcing apps from launcher, use pinned tabs, not app tabs.

Theory: pinned tabs are actually pretty ok, once the url
schenanigans are disabled and they don't have big ugly icons,
especially if we were to add something to the right-click menu
of the apps in the launcher like 'launch in a normal tab'.

Review URL: http://codereview.chromium.org/3152040
------------------------------------------------------------------------
r57143 | levin@chromium.org | 2010-08-24 07:12:55 +0200 (Tue, 24 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h

Consolidate places where a TemplateURL is removed and then added to the TemplateURLModel.

Also made TemplateURLModel::Update private since there were no
external users of this method.

BUG=None
TEST=unit_tests --gtest_filter=TemplateURL*.*

Review URL: http://codereview.chromium.org/3202005
------------------------------------------------------------------------
r57142 | atwilson@chromium.org | 2010-08-24 07:12:51 +0200 (Tue, 24 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.mm
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.h
   M /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_icon.cc
   M /trunk/src/chrome/browser/status_icons/status_icon.h
   M /trunk/src/chrome/browser/status_icons/status_icon_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.h

Add support for status icon context menus for gtk.
Rename ResetContextIcon()->UpdatePlatformContextIcon().

BUG=37375
TEST=CreateIcon updated

Review URL: http://codereview.chromium.org/3127028
------------------------------------------------------------------------
r57141 | mazda@chromium.org | 2010-08-24 06:44:46 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_customize_modifier_keys_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_customize_modifier_keys_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_customize_modifier_keys_overlay.html
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Add DOM UI version of "Customize modifier keys" dialog.

TEST=manually on the netbook
BUG=chromium-os:5152

Review URL: http://codereview.chromium.org/3153022
------------------------------------------------------------------------
r57135 | thakis@chromium.org | 2010-08-24 04:54:40 +0200 (Tue, 24 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/renderer/webgles2context_impl.cc
   M /trunk/src/chrome/renderer/webgles2context_impl.h

Mac: Correctly show/hide compositor on navigations.

The problem was that unlike plugins, the compositor surface is not destroyed on navigation, only a variable is_gpu_rendering_active is updated. The fix is to tell the RenderWidgetHostView if this variable changed and then to adapt the visibility of the view rendering the compositing layer accordingly.

Also, destroy its AcceleratedSurfaceContainer when the compositor is destroyed.

BUG=52134,51748
TEST=go to http://webkit.org/blog/386/3d-transforms/, then hit back. page should redraw on back button. go forward, should work too.

Review URL: http://codereview.chromium.org/3132038
------------------------------------------------------------------------
r57129 | jhawkins@chromium.org | 2010-08-24 02:47:57 +0200 (Tue, 24 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.html
   M /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.html
   M /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.html
   M /trunk/src/chrome/browser/resources/options/autofill_options.js

DOMUI: Several fixes for AutoFill page.
* Properly enable and disable the Edit and Remove buttons based on select
control state.
* Modify the title of the address/CC overlays when pressing the
'Add address/CC' buttons.
* Remove the ability to select multiple options.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3125039
------------------------------------------------------------------------
r57128 | erg@google.com | 2010-08-24 02:44:11 +0200 (Tue, 24 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/browser/wrench_menu_model_unittest.cc
   M /trunk/src/chrome/test/menu_model_test.h

Revert "Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate." (r57119)

TBR=rsesek

Review URL: http://codereview.chromium.org/3163035
------------------------------------------------------------------------
r57126 | estade@chromium.org | 2010-08-24 02:16:39 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc

[GTK] Don't line wrap on the extension uninstall dialog.

BUG=52781
TEST=see bug

Review URL: http://codereview.chromium.org/3106033
------------------------------------------------------------------------
r57124 | jcivelli@chromium.org | 2010-08-24 01:58:12 +0200 (Tue, 24 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_screen.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/sidebar/sidebar_container.h
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc

Relanding a previous CL (I fixed the ChromeOS build):

Making window.focus()/blur() work only when there is a user gesture.

Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).

TBR=darin,sky
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.

Review URL: http://codereview.chromium.org/3174030
------------------------------------------------------------------------
r57123 | seh@chromium.org | 2010-08-24 01:54:45 +0200 (Tue, 24 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json

Fix the size of the roster chat panel and update the JSON format.
Review URL: http://codereview.chromium.org/3184018
------------------------------------------------------------------------
r57122 | zelidrag@chromium.org | 2010-08-24 01:26:18 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc

Fixed flakyness of ClockMenuButtonTest.TimezoneTest.

BUG=chromium-os:5828
TEST=make sure browser_tests pass on chrome os

Review URL: http://codereview.chromium.org/3204001
------------------------------------------------------------------------
r57120 | hclam@chromium.org | 2010-08-24 01:20:57 +0200 (Tue, 24 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/remoting/remoting_resources_source.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/browser/service/service_process_control_manager.cc
   M /trunk/src/chrome/browser/sync/resources/setup_done.html
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/service/remoting/remoting_directory_service.cc
   M /trunk/src/chrome/service/service_main.cc
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/remoting/host/chromoting_host.cc

Resubmit r56600 - Start/stop service process when browser starts and stop

Save the information that the setup of remoting has completed.

After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.

Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.

BUG=50244, 50242, 50243, 50249

Review URL: http://codereview.chromium.org/3153029
------------------------------------------------------------------------
r57119 | erg@google.com | 2010-08-24 01:18:50 +0200 (Tue, 24 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/browser/wrench_menu_model_unittest.cc
   M /trunk/src/chrome/test/menu_model_test.h

Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate.

This removes copy-pasted code in each platform implementation.

BUG=47320
TEST=compiles

Review URL: http://codereview.chromium.org/3163023
------------------------------------------------------------------------
r57116 | phajdan.jr@chromium.org | 2010-08-24 00:35:18 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h
   A /trunk/src/chrome/browser/automation/testing_automation_provider_gtk.cc
   A /trunk/src/chrome/browser/automation/testing_automation_provider_mac.mm
   A /trunk/src/chrome/browser/automation/testing_automation_provider_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTTF: next batch of automation separation.

TEST=none
BUG=52097

Review URL: http://codereview.chromium.org/3191015
------------------------------------------------------------------------
r57114 | levin@chromium.org | 2010-08-24 00:01:25 +0200 (Tue, 24 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/search_engines/search_provider_install_state_dispatcher_host.cc
   A /trunk/src/chrome/browser/search_engines/search_provider_install_state_dispatcher_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/external_extension.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Skeleton of sync handler on the I/O thread for GetSearchProviderInstallState.

BUG=38475
TEST=Not fully testable yet (but the test is
  unit_test --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled

Review URL: http://codereview.chromium.org/3117034
------------------------------------------------------------------------
r57113 | nshkrob@chromium.org | 2010-08-24 00:00:24 +0200 (Tue, 24 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Fix broken thumbnails for sites with redirects.

BUG=52621
TEST=unit_tests

Review URL: http://codereview.chromium.org/3135035
------------------------------------------------------------------------
r57110 | jhawkins@chromium.org | 2010-08-23 23:31:17 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/autofill_edit_creditcard_handler.cc
   A /trunk/src/chrome/browser/dom_ui/autofill_edit_creditcard_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.css
   A /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.html
   A /trunk/src/chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI: Implement the base HTML for the 'Edit credit card' AutoFill overlay.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3174028
------------------------------------------------------------------------
r57109 | estade@chromium.org | 2010-08-23 23:31:16 +0200 (Mon, 23 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.cc
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.h

New first run experience for Linux.

We first show a search engine choice dialog (basically matches windows) but also (in the google chrome case) show a second dialog with the "make chrome the default browser" and "report crashes?" checkboxes. In the chromium case, we don't show the second dialog because it would have a single checkbox (no crash reporting in chromium), and that checkbox is covered by an infobar anyway.

In Chrome, the search engines have image logos. In chromium, they only have plain text logos.

We also no longer show the first run bubble.

BUG=49705
TEST=manual (Chrome and Chromium)

TODO:
- skip the search engine choice when there are no suggested search engines
- show the default search if it's not in the first 3 search engines list
- randomize the search engines list (sometimes)
- remove first run bubble code

Review URL: http://codereview.chromium.org/3106031
------------------------------------------------------------------------
r57105 | jcivelli@chromium.org | 2010-08-23 22:26:58 +0200 (Mon, 23 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/sidebar/sidebar_container.h
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc

Revert 57094 - Making window.focus()/blur() work only when there is a user gesture.

Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).

BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.

Review URL: http://codereview.chromium.org/3156016

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3201008
------------------------------------------------------------------------
r57099 | mirandac@chromium.org | 2010-08-23 21:58:08 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run.cc
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/chrome_installer_util.gypi

Reworked Avi's patch for master prefs implemented on mac (http://codereview.chromium.org/2903014/show), so that it will work with new first run sequence on Windows and Mac.

BUG=44901
TEST=in bug

Review URL: http://codereview.chromium.org/3148001
------------------------------------------------------------------------
r57096 | csilv@chromium.org | 2010-08-23 21:45:34 +0200 (Mon, 23 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/font_settings_overlay.html
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options/preferences.js

yRevert 57093 - dom-ui options: record user metrics for pref changes.

BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3190004

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3119038
------------------------------------------------------------------------
r57094 | jcivelli@chromium.org | 2010-08-23 21:38:21 +0200 (Mon, 23 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/sidebar/sidebar_container.h
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc

Making window.focus()/blur() work only when there is a user gesture.

Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).

BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.

Review URL: http://codereview.chromium.org/3156016
------------------------------------------------------------------------
r57093 | csilv@chromium.org | 2010-08-23 21:36:04 +0200 (Mon, 23 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/font_settings_overlay.html
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options/preferences.js

dom-ui options: record user metrics for pref changes.

BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3190004
------------------------------------------------------------------------
r57090 | rkc@google.com | 2010-08-23 21:16:45 +0200 (Mon, 23 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc

Change the path used to refer to tabs to a reference.
ShowSingletonTab considers only base URL's as unique; adding a /path opens another tab despite one being present at the base URL; changing the path to a ref fixes it.

Review URL: http://codereview.chromium.org/3155038
------------------------------------------------------------------------
r57087 | dmaclach@chromium.org | 2010-08-23 21:05:41 +0200 (Mon, 23 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Add support for receiving text from system services on Mac.

BUG=20868
TEST=manual

Review: http://codereview.chromium.org/3158026

Review URL: http://codereview.chromium.org/3158026
------------------------------------------------------------------------
r57086 | pinkerton@google.com | 2010-08-23 21:05:32 +0200 (Mon, 23 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/views/options/options_window_view.cc

Save and restore the options window position instead of always centering the window. 
BUG=34644
TEST=Open options window, move and close the window, re-open and ensure position is saved. 
Contributed by Steven Pennington <spenn@engr.uvic.ca>
------------------------------------------------------------------------
r57085 | tbarzic@google.com | 2010-08-23 21:04:46 +0200 (Mon, 23 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/chromeos/cros/burn_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/burn_library.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/imageburner_ui.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/imageburner_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/resources/imageburner.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Code implements UI for downloading and burning Chrome OS images on SSD card and USB key. Actual burning is not included in the change list.

BUG=chromium-os:5346

TEST=type in  chrome://imagebuner in browser. UI lists all media that image can be burnt to. After selecting burning target by clicking an image right to the target name, image download should start, and download progress should be displayed. After download ends alert should pop up asking user to confirm that he wants to burn image to selected device. Clicking both ok or cancel shouldn't do anything, since actual burning isn't stil included in CL.
Image should be downloaded to chrome_image folder in users Downloads directory. 
this folder is deleted during shutdown.
This is only visible in ChromeOS...

Review URL: http://codereview.chromium.org/2808100
------------------------------------------------------------------------
r57077 | stuartmorgan@chromium.org | 2010-08-23 20:24:56 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc

DOMUI prefs: Fix a race condition in pushing search engine information to DOMUI

BUG=None
TEST=Load DOMUI options, go to another page, load DOMUI options again, and manage search engines; the table should not be empty.

Review URL: http://codereview.chromium.org/3116023
------------------------------------------------------------------------
r57073 | cbentzel@chromium.org | 2010-08-23 19:42:29 +0200 (Mon, 23 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_auth_handler_factory.cc
   M /trunk/src/net/http/http_auth_handler_factory.h

--auth-schemes specifies which authentication schemes are supported on the command line.

--auth-schemes should be a command separated list containing one or more of the following schemes: basic, digest, ntlm, or negotiate.

This will primarily be used to help triage user-reported bugs.

BUG=None
TEST=specify --auth-schemes and ensure that only the specified schemes are supported. Also, when unspecified all schemes should be supported.

Review URL: http://codereview.chromium.org/3199002
------------------------------------------------------------------------
r57068 | dhg@chromium.org | 2010-08-23 18:27:40 +0200 (Mon, 23 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css

Changing options page so it is in the center, has less padding, a drop shadow and a border.

BUG=chromium-os:5956
TEST=none
Review URL: http://codereview.chromium.org/3146030
------------------------------------------------------------------------
r57067 | viettrungluu@chromium.org | 2010-08-23 18:25:08 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc

Fix small bug in BookmarkDragData: GURL specs are UTF-8, not ASCII.

BUG=none
TEST=I can't be bothered

Review URL: http://codereview.chromium.org/3137031
------------------------------------------------------------------------
r57064 | sky@chromium.org | 2010-08-23 18:21:28 +0200 (Mon, 23 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Adds ui_test_utils::SendAndWaitForKeyPress and converts callers (where
appropriate) to use it. Hopefully this will help isolate why tests are
failing on bot.

BUG=none
TEST=none; test only change.

Review URL: http://codereview.chromium.org/3117030
------------------------------------------------------------------------
r57063 | levin@chromium.org | 2010-08-23 18:20:01 +0200 (Mon, 23 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Remove sync handling of IsSearchProviderInstalled on the browser UI thread.

This is to avoid a deadlock on Windows. It will be replaced by a handler
on the I/O thread in a subsequent patch.

BUG=38475
TEST=None

Review URL: http://codereview.chromium.org/3142029
------------------------------------------------------------------------
r57062 | levin@chromium.org | 2010-08-23 18:18:21 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h

Nothing is ever added to hosts_to_delete_, so this code does nothing useful.

BUG=None
TEST=unit_tests --gtest_filer=TemplateURL*.*

Review URL: http://codereview.chromium.org/3161038
------------------------------------------------------------------------
r57061 | thakis@chromium.org | 2010-08-23 18:05:49 +0200 (Mon, 23 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Re-fix hidden CoreAnimation plugins.

Stuart fixed this in http://codereview.chromium.org/2147002 and I regressed it in http://codereview.chromium.org/3010054

Note that the reduced testcase on the bug is still broken. Since it's broken in Safari too, that's a WebKit problem.

BUG=52914,51748
TEST=See bug

Review URL: http://codereview.chromium.org/3125033
------------------------------------------------------------------------
r57060 | dpolukhin@chromium.org | 2010-08-23 18:03:05 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/helper.cc
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.h
   M /trunk/src/chrome/browser/chromeos/login/message_bubble.cc
   M /trunk/src/chrome/browser/chromeos/login/message_bubble.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Fixed error message bubbles according to the latest mocks

BUG=chromium-os:5762, chromium-os:5761
TEST=Enter wrong password on Chrome OS login screen.

Review URL: http://codereview.chromium.org/3201003
------------------------------------------------------------------------
r57058 | thakis@chromium.org | 2010-08-23 17:48:33 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Unregress right-clicks for CoreAnimation plugins.

BUG=52593,51748
TEST=Right-click a youtube video. Should get context menu.

Review URL: http://codereview.chromium.org/3117035
------------------------------------------------------------------------
r57054 | rkc@google.com | 2010-08-23 16:52:55 +0200 (Mon, 23 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc
   M /trunk/src/chrome/browser/resources/bug_report.html
   D /trunk/src/chrome/browser/resources/bug_report_cros.html

Use <if expr".."> to use a single bug report html for both Chrome and Chrome OS.

Review URL: http://codereview.chromium.org/3122034
------------------------------------------------------------------------
r57053 | denisromanov@chromium.org | 2010-08-23 16:51:37 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/update_screen.h
   A /trunk/src/chrome/browser/chromeos/login/update_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h
   M /trunk/src/chrome/chrome_tests.gypi

Added browser test for the OOBE update screen.

BUG=chromium-os:2265
TEST=Make and run out/Debug/browser_tests

Review URL: http://codereview.chromium.org/3130044
------------------------------------------------------------------------
r57052 | allanwoj@chromium.org | 2010-08-23 16:31:06 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h

Gateway Location Provider
Location provider using the MAC address of a router the user is connected to via Ethernet to find a position fix.
BUG=NONE
TEST=Unit test

Review URL: http://codereview.chromium.org/3153031
------------------------------------------------------------------------
r57048 | skerner@chromium.org | 2010-08-23 15:33:44 +0200 (Mon, 23 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

Ensure that a browser action is never passed to a function which expects a page action.

(Changed review name, because the solution has changed)

BUG=53041
TEST=On a mac, install a browser action and a page action, right click on each icon, select "Inspect Popup".

Review URL: http://codereview.chromium.org/3176021
------------------------------------------------------------------------
r57042 | andreip@chromium.org | 2010-08-23 12:01:52 +0200 (Mon, 23 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.h
   A /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc
   A /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.h

Fix compilation errors of 56862 by

- making the include path lower case in renderer_webidbransaction_impl.cc,
- adding a newline at the end of indexed_db_dispatcher.cc
- fixing the initialization order of member variables in
indexed_db_callbacks.h

Revert "Revert 56862 - Add transaction coordinator. Allow idle transactions to be aborted when their parent JS context finishes executing."

This reverts commit 6b25a433481c9127f8dbcbadc7f0685dc643d6de.

Review URL: http://codereview.chromium.org/3163028
------------------------------------------------------------------------
r57038 | mnissler@chromium.org | 2010-08-23 10:54:35 +0200 (Mon, 23 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc

Reland 56832 - Support change detection and reloading in ConfigDirPolicyProvider.

BUG=52418
TEST=unit tests

Review URL: http://codereview.chromium.org/3156040
------------------------------------------------------------------------
r57036 | hans@chromium.org | 2010-08-23 09:39:28 +0200 (Mon, 23 Aug 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/device_orientation/data_fetcher.h
   M /trunk/src/chrome/browser/device_orientation/orientation.h
   M /trunk/src/chrome/browser/device_orientation/provider.cc
   M /trunk/src/chrome/browser/device_orientation/provider.h
   A /trunk/src/chrome/browser/device_orientation/provider_impl.cc
   A /trunk/src/chrome/browser/device_orientation/provider_impl.h
   A /trunk/src/chrome/browser/device_orientation/provider_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implement device_orientation::Provider.

Provider provides its registered observers with device orientation data
by finding and polling a DataFetcher on a background thread.

BUG=44654
TEST=unit_tests --gtest_filter="DeviceOrientationProviderTest.*"

Review URL: http://codereview.chromium.org/3136008
------------------------------------------------------------------------
r57033 | dpolukhin@chromium.org | 2010-08-23 08:39:48 +0200 (Mon, 23 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h

Reland 56669: Initial change that allows to disable bookmarks

Original CL: http://codereview.chromium.org/3191007

Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.

BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.

Review URL: http://codereview.chromium.org/3156035
------------------------------------------------------------------------
r57032 | ukai@chromium.org | 2010-08-23 08:39:42 +0200 (Mon, 23 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/common/net/test_url_fetcher_factory.h
   M /trunk/src/chrome/common/net/url_fetcher.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Use ChromeThread::IO instead of virtual set_request_context

ChromeThread::IO will be used to cancel URLFetcher request and
clean up URLRequestContextGetter.

BUG=52562,52826
TEST=valgrind passes

Review URL: http://codereview.chromium.org/3176028
------------------------------------------------------------------------
r57025 | tkent@chromium.org | 2010-08-23 06:06:30 +0200 (Mon, 23 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm

Added "Look Up in Dictionary" item to context menu for Mac. 

BUG=46153
TEST=manual

Patch by morrita@google
Original code review: http://codereview.chromium.org/3139007/show
------------------------------------------------------------------------
r57021 | viettrungluu@chromium.org | 2010-08-22 18:49:37 +0200 (Sun, 22 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/app/combobox_model.h
   M /trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.cc
   M /trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_model_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_util.h
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.h
   M /trunk/src/chrome/browser/default_encoding_combo_model.cc
   M /trunk/src/chrome/browser/default_encoding_combo_model.h
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/language_combobox_model.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/cookie_info_view.cc
   M /trunk/src/chrome/browser/views/cookie_info_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/uninstall_view.cc
   M /trunk/src/chrome/browser/views/uninstall_view.h
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/combobox/native_combobox_gtk.cc
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/examples/combobox_example.h
   M /trunk/src/views/focus/focus_manager_unittest.cc

Remove wstrings from bookmarks, part 12.

- This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16
  instead of a wstring.
- This entailed changing the base class, ComboboxModel, and shaving a herd of
  yaks.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3159031
------------------------------------------------------------------------
r57020 | viettrungluu@chromium.org | 2010-08-22 18:19:13 +0200 (Sun, 22 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/app/sql/connection.cc
   M /trunk/src/app/sql/connection_unittest.cc
   M /trunk/src/app/sql/transaction.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/url_info.h
   M /trunk/src/chrome/browser/net/url_info_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc

Spelling correction: "nonexistant" -> "nonexistent".

BUG=none
TEST=good spellers are slightly happier

Review URL: http://codereview.chromium.org/3143037
------------------------------------------------------------------------
r57019 | rkc@google.com | 2010-08-22 12:38:54 +0200 (Sun, 22 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   A /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc
   A /trunk/src/chrome/browser/dom_ui/bug_report_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_screenshot_source.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_screenshot_source.h
   A /trunk/src/chrome/browser/resources/bug_report.css
   A /trunk/src/chrome/browser/resources/bug_report.html
   A /trunk/src/chrome/browser/resources/bug_report.js
   A /trunk/src/chrome/browser/resources/bug_report_cros.html
   A /trunk/src/chrome/browser/resources/bug_report_invalid.html
   A /trunk/src/chrome/browser/userfeedback/proto/chrome.proto
   M /trunk/src/chrome/browser/userfeedback/proto/common.proto
   M /trunk/src/chrome/browser/userfeedback/proto/extension.proto
   M /trunk/src/chrome/browser/userfeedback/proto/web.proto
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   D /trunk/src/chrome/browser/views/bug_report_view.cc
   D /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Build fixes to the CL

Review URL: http://codereview.chromium.org/3061044
------------------------------------------------------------------------
r57012 | viettrungluu@chromium.org | 2010-08-22 06:40:20 +0200 (Sun, 22 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc

Remove wstrings from bookmarks, part 11.

This removes wstrings from BookmarkIndex.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3112027
------------------------------------------------------------------------
r57011 | viettrungluu@chromium.org | 2010-08-22 06:05:26 +0200 (Sun, 22 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc

Whitespace change to trigger the bots.

BUG=things aren't as green as they should be
TEST=things get greener

Review URL: http://codereview.chromium.org/3125035
------------------------------------------------------------------------
r57008 | viettrungluu@chromium.org | 2010-08-22 04:10:44 +0200 (Sun, 22 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc

Remove wstrings in bookmarks, part 10.

This converts the text parameter in GetBookmarksContainingText() and
DoesBookmarkContainText() to string16. (The languages parameter will wait until
I decide what I want for languages parameters in general.)

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3197009
------------------------------------------------------------------------
r57006 | dtseng@chromium.org | 2010-08-22 01:38:58 +0200 (Sun, 22 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_accessibility.mm
   M /trunk/src/webkit/glue/webkit_strings.grd

Hookup role descriptions for webkit specific strings.  Only doing this for accessibility roles we know about.
BUG=none.
TEST=Use VoiceOver to confirm the proper role descriptions are read.
Review URL: http://codereview.chromium.org/3200001
------------------------------------------------------------------------
r57005 | johnnyg@chromium.org | 2010-08-22 01:25:22 +0200 (Sun, 22 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/directory_lister_unittest.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h

Allow net::DirectoryLister to be used to recursively list the directory, and add a FULL_PATH sort option.

BUG=41762
TEST=unit test

Review URL: http://codereview.chromium.org/3175023
------------------------------------------------------------------------
r57003 | rsleevi@chromium.org | 2010-08-22 00:45:54 +0200 (Sun, 22 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/ssl_client_certificate_selector_win.cc

Remove dependency on X509Certificate::Cache behaviour when selecting a client certificate on Win

On OS X and Linux (cocoa/gtk), the original X509Certificate pointer supplied in SSLCertRequestInfo's client_certs is the one returned when a user selects a certificate.

On Windows, a new X509Certificate is created from the selected certificate and returned, rather than the original X509Certificate. This translates to a dependency on X509Certificate::Cache to return the same certificate, which, while presently is true, is an implementation specific detail that should not be relied upon.

BUG=none
TEST=SSL client authentication continues to work on Windows

Review URL: http://codereview.chromium.org/3170019
------------------------------------------------------------------------
r57002 | aa@chromium.org | 2010-08-21 23:21:22 +0200 (Sat, 21 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   D /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/chrome_tests.gypi

Remove attempt to be smart about where to open navigations
targetting app tabs. I futzed with this a bit to try and
integrate installed apps extents, but it is complex.

Also, I looked over the original bug where this code was
added: crbug.com/29281. The issue there was that when you
click on a bookmark (presumably in the bookmark bar) the
pinned tab is unexpectedly overwritten. I can see that
complaint, but there is also the use case of clicking
a bookmark and intending it to overwrite the pinned tab.

In summary, I kinda feel like the expectations about
how navigation should work are too ingrained and we
shouldn't be meddling.

BUG=52680

Review URL: http://codereview.chromium.org/3161037
------------------------------------------------------------------------
r57000 | viettrungluu@chromium.org | 2010-08-21 20:25:31 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/app/tree_node_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc

Remove wstrings from bookmarks, part 7.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3140022
------------------------------------------------------------------------
r56997 | mirandac@chromium.org | 2010-08-21 19:02:12 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc

Fix search engine dialog top image for RTL languages.  The search engine dialog shows an image of the omnibox at the top of the dialog box; in RTL languages, this image needs to be reversed and moved to the left.

BUG=52769
TEST=search engine dialog looks correct in RTL languages.

Review URL: http://codereview.chromium.org/3198006
------------------------------------------------------------------------
r56996 | viettrungluu@chromium.org | 2010-08-21 18:47:44 +0200 (Sat, 21 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm

Remove wstrings from bookmarks, part 8.

Convert lots of uses of the wstring BookmarkNode::GetTitle() in browser/cocoa.

BUG=23581
TEST=builds and passes

Review URL: http://codereview.chromium.org/3113028
------------------------------------------------------------------------
r56989 | finnur@chromium.org | 2010-08-21 10:45:47 +0200 (Sat, 21 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc

Initialize member in BackgroundContents.

BUG=None
TEST=None
CID=12578

Review URL: http://codereview.chromium.org/3166025
------------------------------------------------------------------------
r56987 | finnur@chromium.org | 2010-08-21 10:45:25 +0200 (Sat, 21 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile_impl.cc

When extension is blacklisted by admin policy, it should be removed if already running.
(Attempt 2 at landing this, this time with changes to fix Enabledness unit test)

BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning


Review URL: http://codereview.chromium.org/3166023
------------------------------------------------------------------------
r56985 | viettrungluu@chromium.org | 2010-08-21 08:36:06 +0200 (Sat, 21 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_node_applescript.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_model_observer_for_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc

Remove wstrings from bookmarks, part 6.

Remove the wstring version of BookmarkModel::SetTitle().

BUG=23581
TEST=builds and passes enough tests

Review URL: http://codereview.chromium.org/3142030
------------------------------------------------------------------------
r56984 | kinuko@chromium.org | 2010-08-21 07:48:22 +0200 (Sat, 21 Aug 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/file_system
   A /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.cc
   A /trunk/src/chrome/browser/file_system/file_system_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Add 1st cut of IPC plumbing code for FileSystem API's openFileSystem

The dispatcher host code is just a stub.

BUG=32277
TESTS=none; will be added later

Review URL: http://codereview.chromium.org/3107026
------------------------------------------------------------------------
r56981 | isherman@chromium.org | 2010-08-21 05:48:22 +0200 (Sat, 21 Aug 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/autocomplete/history_provider_util.cc
   A /trunk/src/chrome/browser/autocomplete/history_provider_util.h
   M /trunk/src/chrome/browser/autocomplete/history_quick_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/chrome_browser.gypi

History provider: style cleanup

BUG=none
TEST=it compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56939

Review URL: http://codereview.chromium.org/3177020
------------------------------------------------------------------------
r56980 | chaitanyag@chromium.org | 2010-08-21 05:44:28 +0200 (Sat, 21 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accessibility_event_router_views.cc
   M /trunk/src/chrome/browser/views/accessibility_event_router_views.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/accessible_view_helper.cc
   M /trunk/src/chrome/browser/views/accessible_view_helper.h

Some minor fixes to remove unnecessary includes and do fwd declaration instead.
Review URL: http://codereview.chromium.org/3202003
------------------------------------------------------------------------
r56971 | brettw@chromium.org | 2010-08-21 04:21:11 +0200 (Sat, 21 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/importer/importer_messages_internal.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/importer/profile_writer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.h
   A /trunk/src/chrome/test/data/History/HistoryNoSource
   M /trunk/src/chrome/test/data/profiles/typical_history/Default/History
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Re-land r56742 now with correct database files

A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion. 

BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous 
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.

Original review: http://codereview.chromium.org/2906004/show
Patch by weili@google.com
------------------------------------------------------------------------
r56968 | mrossetti@chromium.org | 2010-08-21 04:03:41 +0200 (Sat, 21 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   D /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Revert 56962 - Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3138006

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/3197008
------------------------------------------------------------------------
r56962 | mrossetti@chromium.org | 2010-08-21 03:35:23 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   A /trunk/src/chrome/test/data/History/url_history_provider_test.db.txt

Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3138006
------------------------------------------------------------------------
r56953 | sergeyu@chromium.org | 2010-08-21 02:54:18 +0200 (Sat, 21 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc

Set state of a new audio stream to Paused until it start to play. Also added media layout tests in ui tests.
BUG=39825
TEST=sound is still playing (with and without autoplay).

Review URL: http://codereview.chromium.org/3160027
------------------------------------------------------------------------
r56952 | zelidrag@chromium.org | 2010-08-21 02:52:24 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc

Marked OmniboxApiTest.Basic and AutocompleteBrowserTest.Autocomplete flaky on ChromeOS. Both test fail consistently in autotest runs while manual run with --gfilter_test seems to be OK. 

BUG=52928,52929
TEST=make sure these two test don't cause autotest to fail anymore

Review URL: http://codereview.chromium.org/3150027
------------------------------------------------------------------------
r56946 | levin@chromium.org | 2010-08-21 02:34:46 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc

Sort the methods in template_url_model.cc to match the ordering in template_url_model.h (Only moving things around. No other changes.)

BUG=None
TEST=unit_tests --gtest_filer=TemplateURL*.*

Review URL: http://codereview.chromium.org/3171025
------------------------------------------------------------------------
r56945 | atwilson@chromium.org | 2010-08-21 02:32:40 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service_unittest.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Fix to change the sense (and name) of kRestoreBackgroundContents to be kDisableRestoreBackgroundContents

BUG=52793
TEST=none

Review URL: http://codereview.chromium.org/3202004
------------------------------------------------------------------------
r56943 | thestig@chromium.org | 2010-08-21 01:56:51 +0200 (Sat, 21 Aug 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/autocomplete/history_provider_util.cc
   D /trunk/src/chrome/browser/autocomplete/history_provider_util.h
   M /trunk/src/chrome/browser/autocomplete/history_quick_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 56939 - History provider: style cleanup

BUG=none
TEST=it compiles

Review URL: http://codereview.chromium.org/3177020

TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/3192006
------------------------------------------------------------------------
r56940 | csilv@chromium.org | 2010-08-21 01:32:54 +0200 (Sat, 21 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js

dom-ui options: Setup proxy settings UI accordingly if an Extension is managing proxies.

BUG=51376
TEST=Verify proxy settings UI matches proposal when proxy settings are managed by an extension.
Review URL: http://codereview.chromium.org/3132030
------------------------------------------------------------------------
r56939 | isherman@chromium.org | 2010-08-21 01:32:47 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/autocomplete/history_provider_util.cc
   A /trunk/src/chrome/browser/autocomplete/history_provider_util.h
   M /trunk/src/chrome/browser/autocomplete/history_quick_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/chrome_browser.gypi

History provider: style cleanup

BUG=none
TEST=it compiles

Review URL: http://codereview.chromium.org/3177020
------------------------------------------------------------------------
r56937 | csilv@chromium.org | 2010-08-21 01:27:57 +0200 (Sat, 21 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js

dom-ui options: Add button for displaying Gears settings (windows only).

BUG=none
TEST=Verify 'Show Gears Settings' button works properly in ChromeWin via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3187010
------------------------------------------------------------------------
r56935 | csilv@chromium.org | 2010-08-21 01:26:35 +0200 (Sat, 21 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/personal_options.js

dom-ui options: Remove special casing for Mac passwords, all platforms should use the same UI.

BUG=none
TEST=Verify that the 'Show Passwords' button displays the passwords panel in dom-ui.
Review URL: http://codereview.chromium.org/3149025
------------------------------------------------------------------------
r56933 | sargrass@google.com | 2010-08-21 01:21:59 +0200 (Sat, 21 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.h
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js

Fix a bug in ImportingData Overlay which cause crash when importing data multiple times.
Fix the problem when force closing the tab while importing.

BUG=49095
TEST=None

Review URL: http://codereview.chromium.org/3167028
------------------------------------------------------------------------
r56931 | sargrass@google.com | 2010-08-21 01:19:16 +0200 (Sat, 21 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   A /trunk/src/chrome/browser/dom_ui/passwords_remove_all_handler.cc
   A /trunk/src/chrome/browser/dom_ui/passwords_remove_all_handler.h
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.js
   A /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.html
   A /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Implement Password Exceptions Tab.
Separate the password exceptions list.

BUG=49093
TEST=None

Review URL: http://codereview.chromium.org/3177023
------------------------------------------------------------------------
r56928 | tim@chromium.org | 2010-08-21 01:11:48 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc

sync: disable the mistakenly enabled sessions code.

BUG=52703
TEST=Start chrome, set up sync, dont crash.  ProfileSyncFactoryImplTest.

Review URL: http://codereview.chromium.org/3165046
------------------------------------------------------------------------
r56926 | pkasting@chromium.org | 2010-08-21 01:06:50 +0200 (Sat, 21 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc

More reload button cleanup: Use widget() everywhere.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3161033
------------------------------------------------------------------------
r56925 | pkasting@chromium.org | 2010-08-21 01:06:19 +0200 (Sat, 21 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/cocoa/reload_button.mm
   M /trunk/src/chrome/browser/cocoa/reload_button_unittest.mm
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc
   M /trunk/src/chrome/browser/views/reload_button.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/custom_button.h
   M /trunk/src/views/widget/root_view.cc

Disable the stop button when the user is hovering it and the page finishes loading, so we don't look like we stay loading forever.  This change only does this for Mac and Windows, as GTK is going to be trickier.

This also fixes a pair of other bugs on Windows and Linux:
* Because we were setting the timer after telling the browser to reload, and the browser was calling us back synchronously, the timer had no effect.
* Because the timer firing changed modes with |force| set to true, if the page finished loading before the timer fired, the timer would flip the button back to reload.

BUG=46981
TEST=Hover the reload button and hit F5.  When the page finishes loading, the stop button should become disabled.  Mousing away should change it to an enabled reload button.
Review URL: http://codereview.chromium.org/3198005
------------------------------------------------------------------------
r56923 | dumi@chromium.org | 2010-08-21 00:42:50 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/base.gypi
   A /trunk/src/base/file_util_proxy.cc (from /trunk/src/chrome/browser/file_system_proxy.cc:56752)
   A /trunk/src/base/file_util_proxy.h (from /trunk/src/chrome/browser/file_system_proxy.h:56752)
   D /trunk/src/chrome/browser/chrome_thread_relay.cc
   D /trunk/src/chrome/browser/chrome_thread_relay.h
   D /trunk/src/chrome/browser/file_system_proxy.cc
   D /trunk/src/chrome/browser/file_system_proxy.h
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi

Moving file_system_proxy to base/ and changing it to work with MessageLoopProxies instead of ChromeThreads.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3131026
------------------------------------------------------------------------
r56920 | thakis@chromium.org | 2010-08-21 00:39:06 +0200 (Sat, 21 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

Revert 56908 (CL was only submitted to merge it to the branch) - Mac: Disable first-run bubble for m6.

BUG=52726
TEST=Run chrome with a new profile. No bubble should show up.

Review URL: http://codereview.chromium.org/3132031

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3169036
------------------------------------------------------------------------
r56919 | scottbyer@chromium.org | 2010-08-21 00:33:51 +0200 (Sat, 21 Aug 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/views/html_dialog_view_browsertest.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane_unittest.cc
   M /trunk/src/views/widget/gtk_views_fixed.cc
   M /trunk/src/views/widget/gtk_views_fixed.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Add in a browser test for dialog resizing, which was catching an issue with the way we were using GTK in toolkit views.  Possibly related to 27365 or 38785.

http://code.google.com/p/chromium-os/issues/detail?id=4126

BUG=chromium-os:4126
TEST=HtmlDialogBrowserTest.SizeWindow

Review URL: http://codereview.chromium.org/2768006
------------------------------------------------------------------------
r56916 | seanparent@google.com | 2010-08-21 00:18:55 +0200 (Sat, 21 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/about_page.html

Remove nested if statements.

BUG=none
TEST=Second attempt to repair options regression.

Review URL: http://codereview.chromium.org/3130041
------------------------------------------------------------------------
r56915 | lzheng@chromium.org | 2010-08-21 00:07:03 +0200 (Sat, 21 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Enable spdy to 95%, npn only to 5%.
BUG=48964
TEST=none
Review URL: http://codereview.chromium.org/3115023
------------------------------------------------------------------------
r56913 | jochen@chromium.org | 2010-08-20 23:35:32 +0200 (Fri, 20 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/CollectedCookies.xib
   M /trunk/src/chrome/browser/cocoa/collected_cookies_mac.h
   M /trunk/src/chrome/browser/cocoa/collected_cookies_mac.mm
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/views/collected_cookies_win.cc
   M /trunk/src/chrome/browser/views/collected_cookies_win.h
   M /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.cc
   M /trunk/src/views/box_layout.cc
   M /trunk/src/views/box_layout.h
   M /trunk/src/views/box_layout_unittest.cc
   M /trunk/src/views/examples/widget_example.h

Display an infobar when content settings were created.

The xib changes add a gradient view with an icon and a text field that is displayed as infobar. The text field is set to truncate. The blocked cookies label is set to wrap. The various views are connected to the new outlets.

win: http://imgur.com/OmTxr.png
linux: http://imgur.com/OmTxr
mac: http://imgur.com/VbwFp

BUG=49826
TEST=unit_tests

Review URL: http://codereview.chromium.org/3108029
------------------------------------------------------------------------
r56912 | seanparent@google.com | 2010-08-20 23:11:23 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options.html

Fixing merge regression.

BUG=none
TEST=Should fix DOM options on non-chromeos platforms.

Review URL: http://codereview.chromium.org/3152037
------------------------------------------------------------------------
r56910 | phajdan.jr@chromium.org | 2010-08-20 22:42:48 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h

GTTF: Continue moving testing automation bits to TestingAutomationProvider

TEST=ui_tests, chrome_frame_tests
BUG=52097

Review URL: http://codereview.chromium.org/3195011
------------------------------------------------------------------------
r56909 | phajdan.jr@chromium.org | 2010-08-20 22:42:19 +0200 (Fri, 20 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Make TestingProfile use ScopedTempDir.

Add some logic that tries to recover from common errors
that happen on the bots. We need to CHECK in really bad cases
because otherwise we'd end up writing to places where we should never write,
like the filesystem root.

TEST=unit_tests and others
BUG=51833

Review URL: http://codereview.chromium.org/3133031
------------------------------------------------------------------------
r56908 | thakis@chromium.org | 2010-08-20 22:36:26 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

Mac: Disable first-run bubble for m6.

BUG=52726
TEST=Run chrome with a new profile. No bubble should show up.

Review URL: http://codereview.chromium.org/3132031
------------------------------------------------------------------------
r56907 | aa@chromium.org | 2010-08-20 22:27:44 +0200 (Fri, 20 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Revert r56902

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r56906 | nirnimesh@chromium.org | 2010-08-20 21:51:24 +0200 (Fri, 20 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/crash_reporter.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py
   A /trunk/src/chrome/test/pyautolib/pyauto_utils.py
   A /trunk/src/chrome/test/pyautolib/pyauto_utils_test.py

PyAuto test for renderer crash reporting

- Add a helper class (ExistingPathReplacer) to temporarily back up a path while pyauto uses it, and then reinstate it. Used by crash reporter test

- Increase PyAuto's default logging level to INFO

Review URL: http://codereview.chromium.org/3083028
------------------------------------------------------------------------
r56902 | aa@chromium.org | 2010-08-20 21:31:46 +0200 (Fri, 20 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Remove TYPE_EXTENSION_APP. Experiment failed. It looks like the layout changes have already been removed.

Review URL: http://codereview.chromium.org/3149029
------------------------------------------------------------------------
r56900 | seanparent@google.com | 2010-08-20 21:23:55 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options.html

Moving about_page to chromeos only.
BUG=none
TEST=Ensure that pulling up options on non-chrome os devices doesn't report
problems.

Review URL: http://codereview.chromium.org/3170022
------------------------------------------------------------------------
r56899 | seanparent@google.com | 2010-08-20 21:20:01 +0200 (Fri, 20 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/update_observer.cc
   M /trunk/src/chrome/browser/chromeos/update_observer.h

Only showing notification when a restart is needed. Partial fix to 5168.

BUG=chromium-os:5168
TEST=Manual - use devserver to install update and verify notification
appears to restart after update is installed with no other notifications.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56616

Review URL: http://codereview.chromium.org/3157018
------------------------------------------------------------------------
r56886 | sky@chromium.org | 2010-08-20 20:00:45 +0200 (Fri, 20 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   A /trunk/src/base/keyboard_code_conversion.cc
   A /trunk/src/base/keyboard_code_conversion.h
   A /trunk/src/base/keyboard_code_conversion_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_input_api.cc
   A /trunk/src/chrome/browser/extensions/extension_input_api.h
   A /trunk/src/chrome/browser/extensions/extension_input_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/input
   A /trunk/src/chrome/test/data/extensions/api_test/input/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/input/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/input/test.js

Lands http://codereview.chromium.org/3153008 for bryeung:

Synthetic KeyEvent delivery, part I.

This delivers synthetic key events to the views hierarchy. This
currently does nothing, as nothing is listening for the event in
TOUCH_UI (or elsewhere). That part will come later.

BUG=none
TEST=unit test for key identifier conversion + manual for extension
api

Review URL: http://codereview.chromium.org/3130029
------------------------------------------------------------------------
r56878 | mnissler@chromium.org | 2010-08-20 19:19:40 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Properly convert the preferences label if it's not ASCII.

BUG=52823
TEST=Configure arabic locale, fire up chrome, check the "Preferences" item in the wrench menu.

Review URL: http://codereview.chromium.org/3166022
------------------------------------------------------------------------
r56877 | johnnyg@chromium.org | 2010-08-20 19:19:07 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc

Linux: change the notification close button to match the tab close button, and move the close and wrench buttons closer together.

BUG=52545
TEST=ui

Review URL: http://codereview.chromium.org/3125026
------------------------------------------------------------------------
r56876 | johnnyg@chromium.org | 2010-08-20 19:18:13 +0200 (Fri, 20 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc

Windows: Make the notification close button look the same as the tab close button.  Also move the close and wrench buttons closer together.

screenshot: http://www.corp.google.com/~johnnyg/52545-new-x-windows.png

BUG=52545
TEST=check out the ui

Review URL: http://codereview.chromium.org/3130034
------------------------------------------------------------------------
r56874 | viettrungluu@chromium.org | 2010-08-20 19:14:28 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.h
   M /trunk/src/chrome/browser/cocoa/tabpose_window.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/file_system_proxy.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/sidebar/sidebar_manager.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.h
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/update_manifest.cc
   M /trunk/src/chrome/common/extensions/update_manifest.h
   M /trunk/src/chrome/common/font_loader_mac.h
   M /trunk/src/chrome/gpu/gpu_video_service.h
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/chrome/test/automation/javascript_message_utils.h

FBTB: Remove unneeded #includes of base/ref_counted.h and base/string16.h in src/chrome.

BUG=23581
TEST=builds

Review URL: http://codereview.chromium.org/3181028
------------------------------------------------------------------------
r56866 | jcivelli@chromium.org | 2010-08-20 18:36:08 +0200 (Fri, 20 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

A crasher in TabContent::ExpireInfoBars is consistently reported in the field. Somehow one of the infobar delegate is NULL.
After spending some time investigating, I am still not clear on how this can happen.
Applying a band-aid with a NOTREACHED() in the hope someone will be able to repro consistently.

BUG=47669
TEST=Don't know how to repro :-(

Review URL: http://codereview.chromium.org/3112022
------------------------------------------------------------------------
r56863 | thomasvl@chromium.org | 2010-08-20 18:22:34 +0200 (Fri, 20 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.h
   D /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc
   D /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.h

Revert 56862 - Add transaction coordinator. Allow idle transactions to be aborted when their parent JS context finishes executing.

This change depends on the following WebKit bug:

https://bugs.webkit.org/show_bug.cgi?id=44101

Review URL: http://codereview.chromium.org/3165026

TBR=andreip@chromium.org
Review URL: http://codereview.chromium.org/3107029
------------------------------------------------------------------------
r56862 | andreip@chromium.org | 2010-08-20 18:05:02 +0200 (Fri, 20 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbfactory_impl.h
   A /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.cc
   A /trunk/src/chrome/renderer/renderer_webidbtransaction_impl.h

Add transaction coordinator. Allow idle transactions to be aborted when their parent JS context finishes executing.

This change depends on the following WebKit bug:

https://bugs.webkit.org/show_bug.cgi?id=44101

Review URL: http://codereview.chromium.org/3165026
------------------------------------------------------------------------
r56860 | viettrungluu@chromium.org | 2010-08-20 17:56:59 +0200 (Fri, 20 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_folder_applescript.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_model_observer_for_cocoa_unittest.mm
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/model_test_utils.cc

Remove wstrings in bookmarks, part 5.

Remove wstring BookmarkModel::AddURL().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3152034
------------------------------------------------------------------------
r56850 | jnd@google.com | 2010-08-20 13:58:08 +0200 (Fri, 20 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/test/data/cancelled_redirect_test.html

Revert 56834 - Fix a few test failures when landing http://trac.webkit.org/changeset/57178.
http://trac.webkit.org/changeset/57178 broke some tests in browser_test and ui_test.

In the test RedirectTest.ClientCancelled, it needs a user-initiated event to trigger the redirect, now it uses "javaScript:click()". When landing r57178, the call of window.open which is inside the call of javaScript:click() was treated as non user-initiated, so the in-page location change was treated as client redirect and the redirect was recoreded, that is why this test was failed when landing r57178. (Please refer to the logic in FrameLoaderClientImpl::dispatchDidNavigateWithinPage.)

In the tests AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension and ExtensionBrowserTest.WindowOpenInvalidExtension, they assume the new tabs opened by window.open in current window. But when landing r57178, since those calls of window.open were treated as non user-initiated, the disposition type of new tabs were changed to Popup, which caused a few new tabs were created instead of a few new tabs in current window (Please refer to RenderView::show), which cause those tests were failed when landing r57178.), that is why those tests were failed when landing r57178.

BUG=17655
TEST=RedirectTest.ClientCancelled, AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension, ExtensionBrowserTest.WindowOpenInvalidExtension

Review URL: http://codereview.chromium.org/3136019

TBR=jnd@google.com
Review URL: http://codereview.chromium.org/3174023
------------------------------------------------------------------------
r56842 | mnissler@chromium.org | 2010-08-20 12:16:25 +0200 (Fri, 20 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc

Revert 56832 - Support change detection and reloading in ConfigDirPolicyProvider.

BUG=52418
TEST=unit tests

Review URL: http://codereview.chromium.org/3124025

TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3161035
------------------------------------------------------------------------
r56837 | kochi@google.com | 2010-08-20 11:49:50 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Convert alert() to notification bar.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/3108032
------------------------------------------------------------------------
r56836 | dpolukhin@chromium.org | 2010-08-20 11:48:46 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/html_page_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/html_page_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

OOBE screen with HTML page specified from command line it is going to be used for recovery screen.

BUG=chromium-os:5877
TEST=Run Chrome with --login-manager --login-screen=html file://filename

Review URL: http://codereview.chromium.org/3158023
------------------------------------------------------------------------
r56834 | jnd@google.com | 2010-08-20 11:41:15 +0200 (Fri, 20 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/test/data/cancelled_redirect_test.html

Fix a few test failures when landing http://trac.webkit.org/changeset/57178.
http://trac.webkit.org/changeset/57178 broke some tests in browser_test and ui_test.

In the test RedirectTest.ClientCancelled, it needs a user-initiated event to trigger the redirect, now it uses "javaScript:click()". When landing r57178, the call of window.open which is inside the call of javaScript:click() was treated as non user-initiated, so the in-page location change was treated as client redirect and the redirect was recoreded, that is why this test was failed when landing r57178. (Please refer to the logic in FrameLoaderClientImpl::dispatchDidNavigateWithinPage.)

In the tests AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension and ExtensionBrowserTest.WindowOpenInvalidExtension, they assume the new tabs opened by window.open in current window. But when landing r57178, since those calls of window.open were treated as non user-initiated, the disposition type of new tabs were changed to Popup, which caused a few new tabs were created instead of a few new tabs in current window (Please refer to RenderView::show), which cause those tests were failed when landing r57178.), that is why those tests were failed when landing r57178.

BUG=17655
TEST=RedirectTest.ClientCancelled, AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension, ExtensionBrowserTest.WindowOpenInvalidExtension

Review URL: http://codereview.chromium.org/3136019
------------------------------------------------------------------------
r56832 | mnissler@chromium.org | 2010-08-20 11:31:27 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc

Support change detection and reloading in ConfigDirPolicyProvider.

BUG=52418
TEST=unit tests

Review URL: http://codereview.chromium.org/3124025
------------------------------------------------------------------------
r56831 | hbono@chromium.org | 2010-08-20 11:28:33 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc

A quick fix for Bug 52808.
This change just creates a scoped_ptr<Value> variable and sets the return value of base::JSONReader::Read() to it. 

BUG=52808
TEST=make the "Linux Test (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3163027
------------------------------------------------------------------------
r56828 | thestig@chromium.org | 2010-08-20 10:11:24 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc

Attempt to fix CrOS build after r56824 part 2.

BUG=none
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/3167031
------------------------------------------------------------------------
r56827 | thestig@chromium.org | 2010-08-20 09:58:13 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h

Attempt to fix CrOS build after r56824.

BUG=none
TEST=CrOS builds
TBR=jhawkins
Review URL: http://codereview.chromium.org/3171021
------------------------------------------------------------------------
r56824 | jhawkins@chromium.org | 2010-08-20 08:23:27 +0200 (Fri, 20 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   M /trunk/src/chrome/browser/cocoa/theme_install_bubble_view.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.h
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.h
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/idbbindingutilities_browsertest.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/mach_broker_mac.h
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/pref_notifier.h
   M /trunk/src/chrome/browser/pref_set_observer_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/repost_form_warning_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/collected_cookies_win.h
   M /trunk/src/chrome/browser/views/content_setting_bubble_contents.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.h
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/notification_observer_mock.h
   M /trunk/src/chrome/common/notification_registrar.h
   M /trunk/src/chrome/common/notification_service.cc
   M /trunk/src/chrome/common/notification_service.h
   M /trunk/src/chrome/common/notification_service_unittest.cc
   M /trunk/src/chrome/common/page_zoom.h
   M /trunk/src/chrome/common/pepper_plugin_registry.h
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/property_bag.cc
   M /trunk/src/chrome/common/property_bag.h
   M /trunk/src/chrome/common/serialized_script_value.cc
   M /trunk/src/chrome/common/serialized_script_value.h
   M /trunk/src/chrome/common/socket_stream_dispatcher.cc
   M /trunk/src/chrome/common/socket_stream_dispatcher.h
   M /trunk/src/chrome/renderer/blocked_plugin.h
   M /trunk/src/chrome/test/test_notification_tracker.h
   M /trunk/src/chrome/utility/utility_thread.cc

FBTF: Header cleanup in chrome/common part 2. The majority of the changed files
just added notification_observer.h.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3120021
------------------------------------------------------------------------
r56821 | viettrungluu@chromium.org | 2010-08-20 07:45:37 +0200 (Fri, 20 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc

Convert wstrings in bookmarks, part 4.

- convert GetURLAndTitleToBookmark() and GetURLsForOpenTabs()
- convert BookmarkEditor::EditDetails

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3176024
------------------------------------------------------------------------
r56819 | zelidrag@chromium.org | 2010-08-20 07:26:43 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/options_window.h

Fixed assert in options caused by my original CL.

TBR=zelidrag
TEST=none
BUG=chromium-os:5522

------------------------------------------------------------------------
r56816 | zelidrag@chromium.org | 2010-08-20 07:08:05 +0200 (Fri, 20 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Changed ChromeOS status bar menu handlers to obey --enable-tabbed-options switch and display the new DOM UI when it's used.


BUG=chromium-os:5522
TEST=make sure the new DOM UI option tab opens from status bar drop down menues (language, internet and system settings)

Review URL: http://codereview.chromium.org/3142020
------------------------------------------------------------------------
r56814 | darin@chromium.org | 2010-08-20 06:59:19 +0200 (Fri, 20 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

RenderWidget::WasRestored should repaint the view when accelerated compositing
is enabled. This fixes the case where restoring a previously-hidden accelerated
tab would not actually show its contents without mouse-moving within the tab's
contents.

Patch by Nat Duca (nduca@chromium.org)
R=darin
BUG=51306
TEST=Load the two URLS specified in original bug report into seperate tabs.
Switching tabs should show the content of the correct tab.

Originally reviewed at: http://codereview.chromium.org/3161023/show

Review URL: http://codereview.chromium.org/3176025
------------------------------------------------------------------------
r56812 | atwilson@chromium.org | 2010-08-20 06:52:44 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc
   M /trunk/src/chrome/browser/background_mode_manager.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.mm
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.h
   M /trunk/src/chrome/browser/status_icons/status_icon.cc
   M /trunk/src/chrome/browser/status_icons/status_icon.h
   M /trunk/src/chrome/browser/status_icons/status_icon_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.h
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win.cc
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win_unittest.cc

Added support for context menus to status icons.

BUG=37375
TEST=updated StatusIcon unit tests

Review URL: http://codereview.chromium.org/3189003
------------------------------------------------------------------------
r56811 | ukai@chromium.org | 2010-08-20 06:21:16 +0200 (Fri, 20 Aug 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/common/net/test_url_fetcher_factory.h
   M /trunk/src/chrome/common/net/url_fetcher.h
   M /trunk/src/chrome/common/net/url_fetcher_protect.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_browser_process.h

Reland r56483 - Monitor network change in GoogleURLTracker

It changes to fetch https://www.google.com/searchdomaincheck?format=domain&type=chrome
instead of checking http://www.google.com/ redirection.

Also show infobar if google domain has been changed to new domain and ask
user to switch new domain.

Fix Win IO Perf regressions:
- GoogleURLTracker::RequestServerCheck() is not called in headless mode
 (CHROME_HEADLESS=1) nor in Chrome Frame (--chrome-frame).

Fix leaks in TestingProfile::CreateRequestContext(): 52562
- Add TestURLFetcher::set_request_context() do nothing, because TestURLFetcher
 might miss to release core_->request_context_getter_.

Fix GoogleURLTracker observer removal DCHECK: 52608
- call RemoveAll(), instead of calling Remove()s

BUG=48688,15141,52477,52562,52608
TEST=unit_tests passes

Review URL: http://codereview.chromium.org/3171019
------------------------------------------------------------------------
r56804 | sky@chromium.org | 2010-08-20 04:52:32 +0200 (Fri, 20 Aug 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc

Fixes race condition that could result in a tab prematurely
closing. Here's the sequence that triggers the closing:
. go to a page.
. go to a new page, preferably one that takes a while to resolve, such
  as one on a site that doesn't exist.
. After this step is_waiting_for_unload_ack_ has been set to true on
  the first RVH.
. click stop before the page has been commited.
. click reload.
  . is_waiting_for_unload_ack_ is still true, and the if the hang monitor
    fires the tab gets closed.

I've changed the code to always set is_waiting_for_unload_ack_ when we
initiate a load.

BUG=52003
TEST=see bug

Review URL: http://codereview.chromium.org/3115020
------------------------------------------------------------------------
r56803 | satorux@chromium.org | 2010-08-20 04:50:23 +0200 (Fri, 20 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/language_preferences_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_util.h
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Add language_prefs namespace to language_preferences.h.

language_preferences.h exports lots of constants hence polutes chromeos
namespace.

TEST=compiles. try bots.
BUG=chromium-os:5848

Review URL: http://codereview.chromium.org/3132023
------------------------------------------------------------------------
r56795 | aa@chromium.org | 2010-08-20 03:05:35 +0200 (Fri, 20 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   A /trunk/src/chrome/browser/extensions/extension_install_ui_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Make the extension install UI de-dupe hosts after disregarding scheme and path.

BUG=52723

Review URL: http://codereview.chromium.org/3126023
------------------------------------------------------------------------
r56794 | pkasting@chromium.org | 2010-08-20 03:05:34 +0200 (Fri, 20 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Cleanup: Reload can't be disabled.  (This change matches views and GTK.)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3169029
------------------------------------------------------------------------
r56792 | pkasting@chromium.org | 2010-08-20 03:01:26 +0200 (Fri, 20 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc

Fix GTK unittest failure

------------------------------------------------------------------------
r56789 | alyssad@google.com | 2010-08-20 02:42:28 +0200 (Fri, 20 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/functional/downloads.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New downloads hooks for pyauto. BUG=35284

New hooks allow the user to pause/resume/cancel/remove downloads and more.

Review URL: http://codereview.chromium.org/3176016
------------------------------------------------------------------------
r56788 | chaitanyag@chromium.org | 2010-08-20 02:37:26 +0200 (Fri, 20 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tts_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json

Add code to support options for TTS speak.
Review URL: http://codereview.chromium.org/3116019
------------------------------------------------------------------------
r56787 | hclam@chromium.org | 2010-08-20 02:36:55 +0200 (Fri, 20 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/remoting/resources/remoting_setup_done.html (from /trunk/src/chrome/browser/remoting/resources/setup_done.html:56757)
   A /trunk/src/chrome/browser/remoting/resources/remoting_setup_flow.html (from /trunk/src/chrome/browser/remoting/resources/setup_flow.html:56757)
   D /trunk/src/chrome/browser/remoting/resources/setup_done.html
   D /trunk/src/chrome/browser/remoting/resources/setup_flow.html

ResourceBundle is loading a wrong resource on Windows for sync

In browser_resources.grd, both IDR_SYNC_SETUP_FLOW_HTML and
IDR_REMOTING_SETUP_FLOW_HTML are point to setup_flow.html although they
are different files in different folders. ResourceBundle gets confused
and always return the later one when asked for IDR_SYNC_SETUP_FLOW_HTML.
This problem only happens on Windows but not Linux.

This patch tries to avoid this problem by renaming remoting files with
a remoting_ prefix.

BUG=52777, 52625
TEST=Setup sync now loads the correct setup_flow.html

Review URL: http://codereview.chromium.org/3191013
------------------------------------------------------------------------
r56786 | evan@chromium.org | 2010-08-20 02:36:01 +0200 (Fri, 20 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/file_util.h
   A /trunk/src/base/file_util_linux.cc
   M /trunk/src/chrome/browser/pref_service.cc

linux: add UMA stat for the file system where the prefs are stored

I'd like to see how common it is to use a network file system for
your home directory.  This would help evaluate how important it is
to support these users.

See also:
  http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/b43d2905f079fa1c

Review URL: http://codereview.chromium.org/3187011
------------------------------------------------------------------------
r56785 | jhawkins@chromium.org | 2010-08-20 02:34:23 +0200 (Fri, 20 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.h
   A /trunk/src/chrome/browser/dom_ui/autofill_edit_address_handler.cc
   A /trunk/src/chrome/browser/dom_ui/autofill_edit_address_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.js
   A /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.css
   A /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.html
   A /trunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.js
   M /trunk/src/chrome/browser/resources/options/autofill_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI: Add the basic HTML for the 'Edit Address' AutoFill overlay.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3157027
------------------------------------------------------------------------
r56778 | rvargas@google.com | 2010-08-20 01:20:09 +0200 (Fri, 20 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Revert 56738 - Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.

This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.

TEST=ui_tests in Release mode
BUG=49838

Review URL: http://codereview.chromium.org/2805100

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3169031
------------------------------------------------------------------------
r56776 | pkasting@chromium.org | 2010-08-20 01:17:10 +0200 (Fri, 20 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc

Fix compile failure

------------------------------------------------------------------------
r56774 | davidben@chromium.org | 2010-08-20 01:12:12 +0200 (Fri, 20 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/net/base/keygen_handler.h
   M /trunk/src/net/base/keygen_handler_mac.cc
   M /trunk/src/net/base/keygen_handler_nss.cc
   M /trunk/src/net/base/keygen_handler_unittest.cc
   M /trunk/src/net/third_party/mozilla_security_manager/nsKeygenHandler.cpp
   M /trunk/src/net/third_party/mozilla_security_manager/nsKeygenHandler.h

Give keys friendly names in NSS and OS X

This will make them browsing them easier in Keychain Access and certutil.
It also gives them a more useful name in Keychain permission dialogs.

The friendly name is currently just the hostname which requested
the key. It would be nice to have some surrounding text with
localization, but this works for now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2806045
------------------------------------------------------------------------
r56771 | evan@chromium.org | 2010-08-20 01:11:28 +0200 (Fri, 20 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/webkit/appcache/view_appcache_internals_job.cc

Convert FormatBytes to string16.

I considered ASCII, but it's producing what is intended to be a
human-readable string.  For example, in theory the "bytes/s" annotation
could be localized into a language where the "b" is non-ASCII.

Review URL: http://codereview.chromium.org/3107021
------------------------------------------------------------------------
r56769 | pkasting@chromium.org | 2010-08-20 01:11:06 +0200 (Fri, 20 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Fix typo in setting event masks.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3146024
------------------------------------------------------------------------
r56767 | pkasting@chromium.org | 2010-08-20 01:10:03 +0200 (Fri, 20 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.h

Cleanup: Put signal handlers in alphabetical order.  Group a couple other things in a way that seems better to me.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3135034
------------------------------------------------------------------------
r56761 | mpcomplete@chromium.org | 2010-08-20 00:19:18 +0200 (Fri, 20 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/notification_type.h

Clean up ExtensionMessageService.
- Remove debugging cruft from an old bug that has been closed.
- Make it UI-thread only. This complicates ResourceMessageFilter a little, but
makes the EMS lifetime a lot easier to reason about.

BUG=no
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/3117024
------------------------------------------------------------------------
r56757 | oshima@chromium.org | 2010-08-19 23:57:43 +0200 (Thu, 19 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc

Fix build due to conflict

TBR=phajdan.jr@chromium.org,
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3149026
------------------------------------------------------------------------
r56754 | brettw@chromium.org | 2010-08-19 23:14:50 +0200 (Thu, 19 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/importer/importer_messages_internal.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/importer/profile_writer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Revert 56742 - A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion. 

BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous 
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.

Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com

TBR=brettw@chromium.org
------------------------------------------------------------------------
r56752 | aa@chromium.org | 2010-08-19 23:06:31 +0200 (Thu, 19 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Remove terrible cross-app navigation handling code that never really
worked correctly.

I think there might still be a place for this, but it is in
Browser::AdjustWindowOpenDispositionForTab(), which is a much more
constrained use case, and also isn't working correctly, because
it lacks knowledge of apps.

BUG=52442

Review URL: http://codereview.chromium.org/3199004
------------------------------------------------------------------------
r56750 | mihaip@chromium.org | 2010-08-19 23:00:20 +0200 (Thu, 19 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Undo user gesture detection added to NavigationController by r18373, since 
WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I 
couldn't remove ViewHostMsg_DocumentLoadedInFrame/ 
NavigationController::DocumentLoadedInFrame since it accumulated other usages 
since then. 

(second attempt of r56693, this time with updated unit tests)

BUG=40395
TEST=manual testing with hp.com and keyboard shortcut search experiment, 
history_uitest
Review URL: http://codereview.chromium.org/3124035
------------------------------------------------------------------------
r56749 | oshima@chromium.org | 2010-08-19 22:59:04 +0200 (Thu, 19 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   A /trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.cc
   A /trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI callback to notification
This is to (but not limited to) allow system update notification to have "restart" button.

 * BalloonHost::EnableDOMUI() to enable DOMUI in notification page.
 * chromeos::BalloonCollectionImpl::AddDOMUIMessageCallback to add
   a callback for given DOMUI message.
 * Added two tests cases (see below)

BUG=chromium-os:5810
TEST=TestAddDOMUIMessageCallback and TestDOMUIMessagCallback are added to notification_browsertest

Review URL: http://codereview.chromium.org/3186016
------------------------------------------------------------------------
r56742 | brettw@chromium.org | 2010-08-19 22:41:02 +0200 (Thu, 19 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/importer/importer_messages_internal.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/importer/profile_writer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion. 

BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous 
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.

Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
------------------------------------------------------------------------
r56740 | estade@chromium.org | 2010-08-19 22:34:43 +0200 (Thu, 19 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/about_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/about_page_handler.h
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.h
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_util.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_util.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc
   M /trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history2_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.h
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.cc
   M /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.cc
   M /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.h
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_internal.h
   M /trunk/src/chrome/browser/remoting/remoting_setup_message_handler.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_message_handler.h
   M /trunk/src/chrome/browser/resources/options/content_settings.css
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/select_file_dialog.cc

DOM UI: Change DOMMessageHandler callback arg type to ListValue.

The parameter describes a list of Values that act as parameters to the callback. It is always a ListValue. It should be typed as such.

BUG=none
TEST=compile; manual testing

Review URL: http://codereview.chromium.org/3146019
------------------------------------------------------------------------
r56738 | phajdan.jr@chromium.org | 2010-08-19 22:29:17 +0200 (Thu, 19 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.

This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.

TEST=ui_tests in Release mode
BUG=49838

Review URL: http://codereview.chromium.org/2805100
------------------------------------------------------------------------
r56737 | pkasting@chromium.org | 2010-08-19 22:29:07 +0200 (Thu, 19 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/popup_non_client_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/popup_non_client_frame_view.h

Fix numerous alignment problems, both horizontal and vertical, in drawing the browser chrome.  This doesn't fix problems with the NTP background image offsets (see bug 51853).

This also makes sure the OTR avatar is reversed in RTL mode, and clipped as usefully as possible when there isn't enough room for the full image.

BUG=44157
TEST=Frame, toolbar, bookmark bar, and find bar all look lined up with default and custom themes, restored and maximized, LTR and RTL, side tabs and normal tabs, and in popup and app windows
Review URL: http://codereview.chromium.org/3137019
------------------------------------------------------------------------
r56735 | brettw@chromium.org | 2010-08-19 22:25:23 +0200 (Thu, 19 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm

Disable failing test.

BUG=52750
Review URL: http://codereview.chromium.org/3171020
------------------------------------------------------------------------
r56731 | csilv@chromium.org | 2010-08-19 22:11:51 +0200 (Thu, 19 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_utils_gtk.cc

dom-ui options: Invoke Linux certs webpage in a new tab instead of a new window.

BUG=none
TEST=Verify that the linux certs webpage is displayed in a new tab (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3116022
------------------------------------------------------------------------
r56730 | thakis@chromium.org | 2010-08-19 22:11:38 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/scoped_vector.h
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Mac: Fix leak in tabpose.

BUG=51786
TEST=valgrind stays green

Review URL: http://codereview.chromium.org/3183019
------------------------------------------------------------------------
r56729 | estade@chromium.org | 2010-08-19 22:06:58 +0200 (Thu, 19 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   D /trunk/src/chrome/browser/dom_ui/passwords_remove_all_handler.cc
   D /trunk/src/chrome/browser/dom_ui/passwords_remove_all_handler.h
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.js
   D /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.html
   D /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Revert r56571:
------------
Make the saved passwords tab work.

BUG=49093
TEST=None
------------
TBR=sargrass

Review URL: http://codereview.chromium.org/3108034
------------------------------------------------------------------------
r56728 | gavinp@chromium.org | 2010-08-19 22:05:10 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc

Remove the negative field trial from prefetching histograms

We shouldn't have people in the NO group of the field trial generating
prefetching histograms.  This CL removes them.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3132016
------------------------------------------------------------------------
r56727 | agl@chromium.org | 2010-08-19 22:02:28 +0200 (Thu, 19 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_defaults.h
   M /trunk/src/net/base/ssl_config_service_mac.cc
   M /trunk/src/net/base/ssl_config_service_win.cc
   M /trunk/src/net/http/http_stream_request.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc

net: expect MITM attacks with HTTP proxies and command line flag.

With r51258 we started requiring the TLS renegotiation extension from a
whitelist of servers that we knew supported it. When Chrome is getting MITM
attacked, this extension can be removed and this broke some debugging tools
(which intercept SSL connections) and some proxies which do the same.

This patch causes us to expect to be MITM attacked when tunneling via an HTTP
proxy and when the --allow-ssl-mitm-proxies command line flag is given.

BUG=48485
TEST=Can't really test without one of these MITM proxy machines.

http://codereview.chromium.org/3111019
------------------------------------------------------------------------
r56726 | brettw@chromium.org | 2010-08-19 21:26:07 +0200 (Thu, 19 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm

iFix typo in previous build fix for Mac.
------------------------------------------------------------------------
r56724 | chron@chromium.org | 2010-08-19 20:44:19 +0200 (Thu, 19 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   D /trunk/src/chrome/browser/google_service_auth_error.h
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/net/gaia/gaia_auth_consumer.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.cc
   A /trunk/src/chrome/common/net/gaia/google_service_auth_error.h (from /trunk/src/chrome/browser/google_service_auth_error.h:56721)
   M /trunk/src/chrome/test/live_sync/offline_sync_test.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Switch to GoogleServiceAuthError struct instead of GaiaAuthError.
Remove CAPTCHA code from existing user controller and plumb into google
authenticator2.

TEST=Install ChromeOS build. Hit Captcha. Enter captcha.
BUG=50408

Review URL: http://codereview.chromium.org/3134009
------------------------------------------------------------------------
r56723 | phajdan.jr@chromium.org | 2010-08-19 20:42:01 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/testing_automation_provider.cc
   M /trunk/src/chrome/browser/automation/testing_automation_provider.h

GTTF: Keep removing testing automation bits from AutomationProvider.

TEST=ui_tests, chrome_frame_tests
BUG=52097

Review URL: http://codereview.chromium.org/3191009
------------------------------------------------------------------------
r56721 | aa@chromium.org | 2010-08-19 20:37:21 +0200 (Thu, 19 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Remove web store icon from most visited per Glen.

BUG=52669

Review URL: http://codereview.chromium.org/3140018
------------------------------------------------------------------------
r56720 | oshima@chromium.org | 2010-08-19 20:37:21 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Add more logs in screen locker to help troublehshooting

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3153023
------------------------------------------------------------------------
r56719 | brettw@chromium.org | 2010-08-19 20:36:25 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/native_library_mac.mm
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_address_sheet_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_accessibility_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/ssl_client_certificate_selector.mm
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/remoting/remoting_resources_source.cc
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/test/webdriver/server.cc
   M /trunk/src/chrome/test/webdriver/session.cc
   M /trunk/src/net/base/cert_database_nss_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Remove forward declares for ASCIIToUTF16 from string_util. All callers now use
utf_string_conversions.h

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3148019
------------------------------------------------------------------------
r56718 | brettw@chromium.org | 2010-08-19 20:35:06 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm

Fix broken ViewIDTest on Mac.

BUG=51084
TEST=none
Original review=http://codereview.chromium.org/3124033/show
Patch by alekseys@google.com
------------------------------------------------------------------------
r56717 | phajdan.jr@chromium.org | 2010-08-19 20:14:30 +0200 (Thu, 19 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   D /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc
   D /trunk/src/chrome/browser/dom_ui/bug_report_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   D /trunk/src/chrome/browser/dom_ui/dom_ui_screenshot_source.cc
   D /trunk/src/chrome/browser/dom_ui/dom_ui_screenshot_source.h
   D /trunk/src/chrome/browser/resources/bug_report.css
   D /trunk/src/chrome/browser/resources/bug_report.html
   D /trunk/src/chrome/browser/resources/bug_report.js
   D /trunk/src/chrome/browser/resources/bug_report_cros.html
   D /trunk/src/chrome/browser/resources/bug_report_invalid.html
   D /trunk/src/chrome/browser/userfeedback/proto/chrome.proto
   M /trunk/src/chrome/browser/userfeedback/proto/common.proto
   M /trunk/src/chrome/browser/userfeedback/proto/extension.proto
   M /trunk/src/chrome/browser/userfeedback/proto/web.proto
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   A /trunk/src/chrome/browser/views/bug_report_view.cc
   A /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Revert "Checkin for CL: http://codereview.chromium.org/3061044/show"

Broke compile.

TBR=rkc

Review URL: http://codereview.chromium.org/3199006
------------------------------------------------------------------------
r56716 | brettw@chromium.org | 2010-08-19 20:05:56 +0200 (Thu, 19 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/base/values.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/extensions/extension_sidebar_api.cc
   A /trunk/src/chrome/browser/extensions/extension_sidebar_api.h
   A /trunk/src/chrome/browser/extensions/extension_sidebar_apitest.cc
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   A /trunk/src/chrome/browser/sidebar
   A /trunk/src/chrome/browser/sidebar/sidebar_container.cc
   A /trunk/src/chrome/browser/sidebar/sidebar_container.h
   A /trunk/src/chrome/browser/sidebar/sidebar_manager.cc
   A /trunk/src/chrome/browser/sidebar/sidebar_manager.h
   A /trunk/src/chrome/browser/sidebar/sidebar_test.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   A /trunk/src/chrome/common/extensions/docs/experimental.sidebar.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/sidebar
   A /trunk/src/chrome/test/data/extensions/api_test/sidebar/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/sidebar/simple_page.html
   A /trunk/src/chrome/test/data/extensions/api_test/sidebar/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/sidebar/test.js
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/testing_browser_process.h

Initial version of chrome.experimental.sidebar extension API. 

BUG=51084
TEST=Run interactive_ui_tests and browser_tests. 

New: 
- sidebar Extension API (design doc: https://docs.google.com/a/google.com/Doc?docid=0AV4Qg3xyZ8RQZGZtbWIydDJfNWc0eHJtbmRm&hl=en); 
- Sidebar panel in Chrome browser view; 

Original review=http://codereview.chromium.org/2836040/show
Patch by alekseys@google.com
------------------------------------------------------------------------
r56712 | viettrungluu@chromium.org | 2010-08-19 19:56:33 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/system_library.h
   M /trunk/src/chrome/browser/chromeos/customization_document.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_screen.h
   M /trunk/src/chrome/browser/chromeos/network_list.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h
   M /trunk/src/chrome/browser/cocoa/base_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.h
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/menu_controller.h
   M /trunk/src/chrome/browser/cocoa/web_contents_drag_source.h
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/win7_location_api_win.h
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/hover_controller_gtk.h
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/net/predictor_api.h
   M /trunk/src/chrome/browser/omnibox_search_hint.h
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/test/testing_profile.h

Clean up unnecessary #includes of base/{scoped_ptr.h,string16.h}.

Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in
base/ref_counted.h, not in base/scoped_ptr.h.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3132024
------------------------------------------------------------------------
r56708 | rkc@google.com | 2010-08-19 19:42:20 +0200 (Thu, 19 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   A /trunk/src/chrome/browser/dom_ui/bug_report_ui.cc
   A /trunk/src/chrome/browser/dom_ui/bug_report_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_screenshot_source.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_screenshot_source.h
   A /trunk/src/chrome/browser/resources/bug_report.css
   A /trunk/src/chrome/browser/resources/bug_report.html
   A /trunk/src/chrome/browser/resources/bug_report.js
   A /trunk/src/chrome/browser/resources/bug_report_cros.html
   A /trunk/src/chrome/browser/resources/bug_report_invalid.html
   A /trunk/src/chrome/browser/userfeedback/proto/chrome.proto
   M /trunk/src/chrome/browser/userfeedback/proto/common.proto
   M /trunk/src/chrome/browser/userfeedback/proto/extension.proto
   M /trunk/src/chrome/browser/userfeedback/proto/web.proto
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   D /trunk/src/chrome/browser/views/bug_report_view.cc
   D /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Checkin for CL: http://codereview.chromium.org/3061044/show

TEST=Backend: Various reports submitted from Chrome OS and Windows builds
sent to the feedback test server. For Chromium OS, sent reports
with current screenshot and saved screenshots; verified all reports
for data accuracy and completion.
Frontend: Tested the UI features by excersizing various options; tested
not selecting any issue, tested switching between screenshot types.


Review URL: http://codereview.chromium.org/3181027
------------------------------------------------------------------------
r56704 | lzheng@chromium.org | 2010-08-19 19:30:54 +0200 (Thu, 19 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/extensions/v8/benchmarking_extension.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/support/webkit_support_glue.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Enable/Disable Spdy in benchmarking.

Test=none
Bug=52624
Review URL: http://codereview.chromium.org/3169022
------------------------------------------------------------------------
r56703 | stuartmorgan@chromium.org | 2010-08-19 19:30:05 +0200 (Thu, 19 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.css
   M /trunk/src/chrome/browser/resources/options/add_startup_page_recent_pages_list.js
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/browser_options_page.css
   A /trunk/src/chrome/browser/resources/options/browser_options_startup_page_list.js (from /trunk/src/chrome/browser/resources/options/add_startup_page_recent_pages_list.js:56685)
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.css
   M /trunk/src/chrome/browser/resources/options/search_engine_manager_engine_list.js
   M /trunk/src/chrome/browser/resources/options.html

DOMUI prefs: Use a List instead of a select for startup pages.

Refactors common elements (favicon source, CSS styling) from the subpages and the main page into shared locations. Also fixes a few small existing mistakes in comments and function naming.

BUG=48713
TEST=DOMUI prefs should show favicons for startup pages.

Review URL: http://codereview.chromium.org/3112017
------------------------------------------------------------------------
r56702 | davemoore@chromium.org | 2010-08-19 19:22:47 +0200 (Thu, 19 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/test/testing_profile.h

Removed unnecessary includes from profile.h and added the now necessary includes to other files

Review URL: http://codereview.chromium.org/3142019
------------------------------------------------------------------------
r56701 | skerner@chromium.org | 2010-08-19 19:14:32 +0200 (Thu, 19 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   M /trunk/src/chrome/browser/sync/glue/extension_sync.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/installer/util/master_preferences.cc

Allow update URLs in external_extensions.json.

Doc updates will follow in another CL.

BUG=48117
TEST=ExtensionsServiceTest.(UpdatePendingExternalCrx,UpdatePendingCrxThemeMismatch,ExternalPrefProvider), ExtensionManagmentTest.ExternalUrlUpdate, manual testing.

Review URL: http://codereview.chromium.org/3005057
------------------------------------------------------------------------
r56695 | tonyg@chromium.org | 2010-08-19 18:39:19 +0200 (Thu, 19 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Revert 56693 - broke compile

Undo user gesture detection added to NavigationController by r18373, since
WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I
couldn't remove ViewHostMsg_DocumentLoadedInFrame/
NavigationController::DocumentLoadedInFrame since it accumulated other usages
since then.

Contributed by mihaip@chromium.org

BUG=40395
TEST=manual testing with hp.com and keyboard shortcut search experiment,
history_uitest

Review URL: http://codereview.chromium.org/3168013

TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/3104021
------------------------------------------------------------------------
r56693 | tonyg@chromium.org | 2010-08-19 18:26:19 +0200 (Thu, 19 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Undo user gesture detection added to NavigationController by r18373, since
WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I
couldn't remove ViewHostMsg_DocumentLoadedInFrame/
NavigationController::DocumentLoadedInFrame since it accumulated other usages
since then.

Contributed by mihaip@chromium.org

BUG=40395
TEST=manual testing with hp.com and keyboard shortcut search experiment,
history_uitest

Review URL: http://codereview.chromium.org/3168013
------------------------------------------------------------------------
r56690 | boliu@chromium.org | 2010-08-19 18:13:18 +0200 (Thu, 19 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   A /trunk/src/chrome/browser/renderer_host/render_widget_fullscreen_host.cc
   A /trunk/src/chrome/browser/renderer_host/render_widget_fullscreen_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   A /trunk/src/chrome/renderer/render_widget_fullscreen.cc
   A /trunk/src/chrome/renderer/render_widget_fullscreen.h

Use RenderWidget(Host) for full screen

Add RenderWidgetFullscreen(Host) subclasses, InitAsFullscreen method
to RenderWidgetHostView, and add two new ipc messages for creating
and showing full screen.

Add createFullscreenWindow to RenderView that creates RenderWidgetFullscreen
and sends message to browser which eventually creates RenderWidgetFullscreenHost.

The show method on RenderWidgetFullscreen sends message to parent
RenderViewHost in browser, which calls InitAsFullscreen on the view.

BUG=16735
TEST=RenderViewHostTest.CreateFullscreenWidget

Review URL: http://codereview.chromium.org/3055009
------------------------------------------------------------------------
r56689 | viettrungluu@chromium.org | 2010-08-19 18:12:07 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_folder_applescript.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/model_test_utils.cc

Remove wstrings from bookmarks, part 3.

Get rid of wstring BookmarkModel::AddGroup() (and convert lots of uses; also
convert many uses of the wstring AddURL() as drive-by's).

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3115017
------------------------------------------------------------------------
r56688 | finnur@chromium.org | 2010-08-19 17:10:50 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Revert 56683 - When extension is blacklisted by admin policy, it should be removed if already running.

BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning

Review URL: http://codereview.chromium.org/3161020

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3163025
------------------------------------------------------------------------
r56687 | bauerb@chromium.org | 2010-08-19 16:53:28 +0200 (Thu, 19 Aug 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.h
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc
   M /trunk/src/chrome/browser/views/content_setting_bubble_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_sync_message_unittest.cc
   M /trunk/src/ipc/ipc_sync_message_unittest.h

Reland 55888: Allow per-plugin content settings.

Now with Fixed Unit Tests!

Run with --enable-resource-content-settings and --enable-click-to-play to enable.

TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.

The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.

Screenshot of the plugin bubble: ﻿http://imgur.com/6npqv.png

Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.

XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.

BUG=39252,38432
TEST=HostContentSettingsMapTest.*,manual

Review URL: http://codereview.chromium.org/2873104

Review URL: http://codereview.chromium.org/3124018
------------------------------------------------------------------------
r56685 | mmenke@chromium.org | 2010-08-19 16:37:07 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js

Automatically selects log dump text on the NetLog screen.  Ctrl-A selects too much text, and click+drag can take a while, for large amounts of text.

Bug=none
Test=Press the button

Review URL: http://codereview.chromium.org/3124029
------------------------------------------------------------------------
r56684 | markusheintz@chromium.org | 2010-08-19 16:36:56 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Enables/disables UI widgets for privacy preferences in the options->"Under the hood" dialog, if a corresponding policy is enabled or disabled during runtime on Windows.

BUG=52578
TEST=manual

Review URL: http://codereview.chromium.org/3129012
------------------------------------------------------------------------
r56683 | finnur@chromium.org | 2010-08-19 16:34:04 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

When extension is blacklisted by admin policy, it should be removed if already running.

BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning

Review URL: http://codereview.chromium.org/3161020
------------------------------------------------------------------------
r56682 | tfarina@chromium.org | 2010-08-19 16:31:52 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc

views: Use IDS_BROWSER_HANGMONITOR_RENDERER_TITLE as the hung renderer dialog title.

BUG=43103
TEST=None

Review URL: http://codereview.chromium.org/3166018
------------------------------------------------------------------------
r56681 | tfarina@chromium.org | 2010-08-19 16:27:00 +0200 (Thu, 19 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/autofill_options.js

AutoFill: Enable or disable the buttons whether the autofill is enabled or not.

BUG=49094
TEST=Open the dom ui dialog of the AutoFill options dialog, uncheck the checkbox,
see if the buttons become disable, do the reverse and see if the buttons becomes
enabled again and vice-versa.

Review URL: http://codereview.chromium.org/3156013
------------------------------------------------------------------------
r56676 | dpolukhin@chromium.org | 2010-08-19 15:25:00 +0200 (Thu, 19 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h

TBR:sky
------------------------------------------------------------------------
r56670 | mnissler@chromium.org | 2010-08-19 12:35:46 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/file_path_watcher.h
   A /trunk/src/chrome/browser/file_path_watcher_inotify.cc
   A /trunk/src/chrome/browser/file_path_watcher_mac.cc
   A /trunk/src/chrome/browser/file_path_watcher_stub.cc
   A /trunk/src/chrome/browser/file_path_watcher_unittest.cc
   A /trunk/src/chrome/browser/file_path_watcher_win.cc
   D /trunk/src/chrome/browser/file_watcher.h
   D /trunk/src/chrome/browser/file_watcher_inotify.cc
   D /trunk/src/chrome/browser/file_watcher_mac.cc
   D /trunk/src/chrome/browser/file_watcher_stub.cc
   D /trunk/src/chrome/browser/file_watcher_unittest.cc
   D /trunk/src/chrome/browser/file_watcher_win.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Reland 56341 - Add support for watching directories to FileWatcher.

BUG=none
TEST=Unit tests in file_watcher_unittest.cc.

Review URL: http://codereview.chromium.org/3184010
------------------------------------------------------------------------
r56669 | dpolukhin@chromium.org | 2010-08-19 12:33:04 +0200 (Thu, 19 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h

Land 3122014 for Anton: Initial change that allows to disable bookmarks

Original CL: http://codereview.chromium.org/3122014

Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.

BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.

Review URL: http://codereview.chromium.org/3191007
------------------------------------------------------------------------
r56668 | pfeldman@chromium.org | 2010-08-19 12:03:20 +0200 (Thu, 19 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: re-enable scopes test.
BUG=52085
TBR=yurys

Review URL: http://codereview.chromium.org/3175025
------------------------------------------------------------------------
r56661 | zork@chromium.org | 2010-08-19 11:18:12 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_keyboard_library.h

Replace all constant string kHardwareKeyboardName with
GetHardwareKeyboardLayoutName method in libcros.
(In addition to http://codereview.chromium.org/3188003/show)

BUG=chromium-os:5579
TEST=None

Review URL: http://codereview.chromium.org/3115018
Patch from Hitoshi Yoshida <peria@google.com>.
------------------------------------------------------------------------
r56660 | pam@chromium.org | 2010-08-19 11:08:14 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/pref_notifier.cc
   M /trunk/src/chrome/browser/pref_notifier.h
   M /trunk/src/chrome/browser/pref_notifier_unittest.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc

Notify pref observers when the PrefStore controlling a preference changes, even if its
effective value doesn't change.

BUG=50772
TEST=unit tests (PrefValueStoreTest.PrefHasChanged)
Review URL: http://codereview.chromium.org/3115016
------------------------------------------------------------------------
r56659 | zork@chromium.org | 2010-08-19 11:00:42 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Add a max retry count to the IME timer

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3183018
------------------------------------------------------------------------
r56657 | satorux@chromium.org | 2010-08-19 10:37:24 +0200 (Thu, 19 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/language_preferences.cc (from /trunk/src/chrome/browser/chromeos/language_preferences.h:56654)
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/chrome_browser.gypi

Clean up chrome/browser/chromeos/language_preferences.h.

Get rid of includes from language_preferences.h.
Move definitions of variables from .h to .cc file.
Change affected files accordingly.

Note that some files were depending on includes in
language_preferences.h. For these files, add required
includes so these files compile.

BUG=chromium-os:5848
TEST=compiles. try bots.

Review URL: http://codereview.chromium.org/3164027
------------------------------------------------------------------------
r56656 | jochen@chromium.org | 2010-08-19 10:33:41 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Clear cookie related settings at the beginning of a navigation instead of at the end.

BUG=none
TEST=TabSpecific*.*

Review URL: http://codereview.chromium.org/3194005
------------------------------------------------------------------------
r56653 | viettrungluu@chromium.org | 2010-08-19 10:15:21 +0200 (Thu, 19 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.h
   M /trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M /trunk/src/chrome/browser/download/download_history.h
   M /trunk/src/chrome/browser/geolocation/win7_location_api_win.h
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/sync/glue/session_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/session_model_associator.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/renderer/devtools_agent.h

FBTF: Remove unneeded STL includes from src/chrome.

This (re-)inspects files under src/chrome for unneeded #includes of <map>, <string>, <vector>, etc.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3152033
------------------------------------------------------------------------
r56652 | thestig@chromium.org | 2010-08-19 10:10:52 +0200 (Thu, 19 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc

Fix a crash where we send an invalid notification to TemplateURLTableModel's observers.

BUG=52251
TEST=included, also try: chmod a-r /path/to/profile/Default/Web\ Data, start Chromium and try to set the default search provider.
Review URL: http://codereview.chromium.org/3189006
------------------------------------------------------------------------
r56651 | yurys@chromium.org | 2010-08-19 10:06:26 +0200 (Thu, 19 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: remove some tests that have already been converted into layout tests

Review URL: http://codereview.chromium.org/3117022
------------------------------------------------------------------------
r56646 | mbelshe@chromium.org | 2010-08-19 07:56:38 +0200 (Thu, 19 Aug 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/http/http_auth_controller.cc
   M /trunk/src/net/http/http_basic_stream.cc
   M /trunk/src/net/http/http_basic_stream.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket.h
   M /trunk/src/net/http/http_stream.h
   A /trunk/src/net/http/http_stream_factory.cc
   A /trunk/src/net/http/http_stream_factory.h
   A /trunk/src/net/http/http_stream_handle.h
   M /trunk/src/net/http/http_stream_parser.cc
   M /trunk/src/net/http/http_stream_parser.h
   A /trunk/src/net/http/http_stream_request.cc
   A /trunk/src/net/http/http_stream_request.h
   A /trunk/src/net/http/stream_factory.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/spdy/spdy_http_stream.cc
   M /trunk/src/net/spdy/spdy_http_stream.h
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_stream.cc
   M /trunk/src/net/spdy/spdy_stream.h

Extract connection logic from HttpNetworkTransaction into a new
HttpStreamFactory.  The HttpNetworkTransaction now deals exclusively with
streams rather than connections directly.  This cut the size of HTN roughly in
in half.

The HttpNetworkTransaction is still responsible for all proxy and server
authentication functions.  This is because the streams may come and go - we
could create a stream, have the server declare auth is needed, and then the
next attempt would be on a different stream.  So Auth belongs on the HNT.
The HNT no longer has direct access to the connection itself; instead, it
only knows of an HttpStream.

The StreamRequest, however, is responsible for determining whether the
connection needs to use a proxy, whether AlternateProtocols are available, and
whether the connection should be SPDY or HTTP.

Other changes:
  - moved some static configuration methods from HNT to HttpStreamFactory.
  - added some methods to the HttpStream.


BUG=none
TEST=all



Review URL: http://codereview.chromium.org/3171002
------------------------------------------------------------------------
r56645 | thestig@chromium.org | 2010-08-19 07:30:18 +0200 (Thu, 19 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/update_observer.cc
   M /trunk/src/chrome/browser/chromeos/update_observer.h

Revert 56616 - Only showing notification when a restart is needed. Partial fix to 5168.

BUG=chromium-os:5168
TEST=Manual - use devserver to install update and verify notification
appears to restart after update is installed with no other notifications.

Review URL: http://codereview.chromium.org/3157018

TBR=seanparent@google.com
Review URL: http://codereview.chromium.org/3162022
------------------------------------------------------------------------
r56643 | hbono@chromium.org | 2010-08-19 06:39:53 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc

A quick fix for Bug 52675.
This change just initializes |status_icon_| to NULL in BackgroundModeManager::BackgroundModeManager to see it actually fixes Bug 52675.

BUG=52675
TEST=make the "Linux Tests (valgrind)(3)" bot green.
Review URL: http://codereview.chromium.org/3130032
------------------------------------------------------------------------
r56642 | kochi@google.com | 2010-08-19 06:08:38 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc

Fix build (wstring->string mismatch).

BUG=none
TEST=compile test

Review URL: http://codereview.chromium.org/3199005
------------------------------------------------------------------------
r56641 | thestig@chromium.org | 2010-08-19 05:49:38 +0200 (Thu, 19 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/app/clipboard/scoped_clipboard_writer.h
   M /trunk/src/base/i18n/file_util_icu.h
   M /trunk/src/base/scoped_native_library.h
   M /trunk/src/base/scoped_native_library_unittest.cc
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader.cc
   M /trunk/src/chrome/browser/chromeos/pipe_reader.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/download_util_mac.h
   M /trunk/src/chrome/browser/cocoa/web_contents_drag_source.h
   M /trunk/src/chrome/browser/cocoa/web_contents_drag_source.mm
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.mm
   M /trunk/src/chrome/browser/importer/nss_decryptor_system_nss.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_factory.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.h
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/extension_sync_traits.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_drag_data.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/chrome_paths_internal.h
   M /trunk/src/chrome/common/extensions/extension_file_util.h
   M /trunk/src/chrome/common/pepper_plugin_registry.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac_unittest_helper.mm
   M /trunk/src/chrome/common/sandbox_policy.h
   M /trunk/src/chrome/common/utility_messages.cc
   M /trunk/src/chrome/common/utility_messages.h
   M /trunk/src/chrome/common/web_resource/web_resource_unpacker.h
   M /trunk/src/chrome/common/zip.h
   M /trunk/src/chrome/gpu/gpu_info_collector_win.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/work_item.h
   M /trunk/src/chrome/installer/util/work_item_list.h
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/external_extension_uitest.cc
   M /trunk/src/chrome/service/cloud_print/job_status_updater.h
   M /trunk/src/chrome/service/cloud_print/print_system.h
   M /trunk/src/chrome/service/service_child_process_host.cc
   M /trunk/src/chrome/service/service_utility_process_host.h
   M /trunk/src/chrome/test/chrome_process_util.h
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome_frame/chrome_launcher_utils.h
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.h
   M /trunk/src/chrome_frame/test/net/process_singleton_subclass.h
   M /trunk/src/chrome_frame/test/util_unittests.cc
   M /trunk/src/chrome_frame/test_utils.h
   M /trunk/src/chrome_frame/utils.h
   M /trunk/src/net/base/cert_test_util.h
   M /trunk/src/net/disk_cache/disk_cache_test_util.h
   M /trunk/src/net/tools/dump_cache/url_to_filename_encoder.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/appcache/appcache_service.h
   M /trunk/src/webkit/database/database_util.h
   M /trunk/src/webkit/glue/media/mock_media_resource_loader_bridge_factory.h
   M /trunk/src/webkit/glue/mock_resource_loader_bridge.h
   M /trunk/src/webkit/glue/plugins/pepper_plugin_module.h
   M /trunk/src/webkit/glue/plugins/pepper_webplugin_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_stream.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.h

FBTF: Remove unneeded headers from base/ (part 6)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
------------------------------------------------------------------------
r56639 | tfarina@chromium.org | 2010-08-19 05:40:00 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/input_window_dialog_gtk.cc

gtk: Make use of the gtk signal macros in GtkInputWindowDialog class.

- Also renames GtkInputWindowDialog to InputWindowDialogGtk, to be consistent
with the file name.

BUG=None
TEST=right click on bookmarks bar, 'Add folder', everything should works as before.

Review URL: http://codereview.chromium.org/3186003
------------------------------------------------------------------------
r56638 | kochi@google.com | 2010-08-19 05:38:18 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Show message nicely when the user tries to remove tha last language or input method in DOMUI.

BUG=chromium-os:5546, chromium-os:5547
TEST=manual

Review URL: http://codereview.chromium.org/3143013
------------------------------------------------------------------------
r56628 | viettrungluu@chromium.org | 2010-08-19 03:11:08 +0200 (Thu, 19 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h

Convert a couple of wstring methods in ChildProcessInfo.

(The underlying data still needs to be converted.)

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3133023
------------------------------------------------------------------------
r56627 | atwilson@chromium.org | 2010-08-19 02:58:56 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/background_mode_manager.cc

Change when we create StatusTray to avoid problem running multi-profile tests
(StatusTray is effectively supposed to be a singleton, so creating multiple
instances isn't truly supported currently and would require a bit of extra
plumbing which I'd rather not do until we truly support multiple profiles).

BUG=52662
TEST=sync tests should pass now

Review URL: http://codereview.chromium.org/3169024
------------------------------------------------------------------------
r56622 | davidben@chromium.org | 2010-08-19 01:39:52 +0200 (Thu, 19 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_defaults.h
   M /trunk/src/net/base/ssl_config_service_mac.cc
   M /trunk/src/net/base/ssl_config_service_win.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc

Add a command-line flag to disable SSL/TLS False Start

Some servers are not compatible with False Start. Adding a command-line
flag will make it easier to test and verify such cases.

Also, blacklist www.picnik.com as incompatible with False Start.

BUG=50650
TEST=see bug

Review URL: http://codereview.chromium.org/3167015
------------------------------------------------------------------------
r56620 | tim@chromium.org | 2010-08-19 01:39:05 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/session_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc

Fix leaks in ProfileSyncServiceSessionTest.

BUG=52552
TEST=ProfileSyncServiceSessionTest.  Trying to get heapchecker running locally.

Review URL: http://codereview.chromium.org/3167022
------------------------------------------------------------------------
r56619 | phajdan.jr@chromium.org | 2010-08-19 01:37:03 +0200 (Thu, 19 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/app/sql/connection.cc
   M /trunk/src/app/sql/connection_unittest.cc
   M /trunk/src/app/sql/statement.cc
   M /trunk/src/app/sql/statement_unittest.cc
   M /trunk/src/app/sql/transaction_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/common/database_util.cc
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/renderer/render_thread.cc
   D /trunk/src/third_party/sqlite/LICENSE
   D /trunk/src/third_party/sqlite/Makefile.arm-wince-mingw32ce-gcc
   D /trunk/src/third_party/sqlite/Makefile.in
   D /trunk/src/third_party/sqlite/Makefile.linux-gcc
   D /trunk/src/third_party/sqlite/Makefile.vxworks
   D /trunk/src/third_party/sqlite/README
   D /trunk/src/third_party/sqlite/VERSION
   D /trunk/src/third_party/sqlite/aclocal.m4
   D /trunk/src/third_party/sqlite/addopcodes.awk
   D /trunk/src/third_party/sqlite/art
   D /trunk/src/third_party/sqlite/config.guess
   D /trunk/src/third_party/sqlite/config.h.in
   D /trunk/src/third_party/sqlite/config.sub
   D /trunk/src/third_party/sqlite/configure
   D /trunk/src/third_party/sqlite/configure.ac
   D /trunk/src/third_party/sqlite/contrib
   D /trunk/src/third_party/sqlite/doc
   D /trunk/src/third_party/sqlite/ext
   M /trunk/src/third_party/sqlite/google_generate_preprocessed.sh
   D /trunk/src/third_party/sqlite/install-sh
   D /trunk/src/third_party/sqlite/ltmain.sh
   D /trunk/src/third_party/sqlite/main.mk
   D /trunk/src/third_party/sqlite/manifest
   D /trunk/src/third_party/sqlite/manifest.uuid
   D /trunk/src/third_party/sqlite/mkdll.sh
   D /trunk/src/third_party/sqlite/mkextu.sh
   D /trunk/src/third_party/sqlite/mkextw.sh
   D /trunk/src/third_party/sqlite/mkopcodec.awk
   D /trunk/src/third_party/sqlite/mkopcodeh.awk
   D /trunk/src/third_party/sqlite/mkso.sh
   D /trunk/src/third_party/sqlite/preprocessed
   D /trunk/src/third_party/sqlite/publish.sh
   D /trunk/src/third_party/sqlite/publish_osx.sh
   D /trunk/src/third_party/sqlite/spec.template
   M /trunk/src/third_party/sqlite/sqlite.gyp
   D /trunk/src/third_party/sqlite/sqlite.pc.in
   D /trunk/src/third_party/sqlite/sqlite3.1
   A /trunk/src/third_party/sqlite/sqlite3.h
   D /trunk/src/third_party/sqlite/sqlite3.pc.in
   D /trunk/src/third_party/sqlite/sqlite_google
   A /trunk/src/third_party/sqlite/src/LICENSE (from /trunk/src/third_party/sqlite/LICENSE:56589)
   A /trunk/src/third_party/sqlite/src/Makefile.arm-wince-mingw32ce-gcc (from /trunk/src/third_party/sqlite/Makefile.arm-wince-mingw32ce-gcc:56589)
   A /trunk/src/third_party/sqlite/src/Makefile.in (from /trunk/src/third_party/sqlite/Makefile.in:56589)
   A /trunk/src/third_party/sqlite/src/Makefile.linux-gcc (from /trunk/src/third_party/sqlite/Makefile.linux-gcc:56589)
   A /trunk/src/third_party/sqlite/src/Makefile.vxworks (from /trunk/src/third_party/sqlite/Makefile.vxworks:56589)
   A /trunk/src/third_party/sqlite/src/README (from /trunk/src/third_party/sqlite/README:56589)
   A /trunk/src/third_party/sqlite/src/VERSION (from /trunk/src/third_party/sqlite/VERSION:56589)
   A /trunk/src/third_party/sqlite/src/aclocal.m4 (from /trunk/src/third_party/sqlite/aclocal.m4:56589)
   A /trunk/src/third_party/sqlite/src/addopcodes.awk (from /trunk/src/third_party/sqlite/addopcodes.awk:56589)
   D /trunk/src/third_party/sqlite/src/alter.c
   D /trunk/src/third_party/sqlite/src/analyze.c
   A /trunk/src/third_party/sqlite/src/art (from /trunk/src/third_party/sqlite/art:56589)
   D /trunk/src/third_party/sqlite/src/attach.c
   D /trunk/src/third_party/sqlite/src/auth.c
   D /trunk/src/third_party/sqlite/src/backup.c
   D /trunk/src/third_party/sqlite/src/bitvec.c
   D /trunk/src/third_party/sqlite/src/btmutex.c
   D /trunk/src/third_party/sqlite/src/btree.c
   D /trunk/src/third_party/sqlite/src/btree.h
   D /trunk/src/third_party/sqlite/src/btreeInt.h
   D /trunk/src/third_party/sqlite/src/build.c
   D /trunk/src/third_party/sqlite/src/callback.c
   D /trunk/src/third_party/sqlite/src/complete.c
   A /trunk/src/third_party/sqlite/src/config.guess (from /trunk/src/third_party/sqlite/config.guess:56589)
   A /trunk/src/third_party/sqlite/src/config.h.in (from /trunk/src/third_party/sqlite/config.h.in:56589)
   A /trunk/src/third_party/sqlite/src/config.sub (from /trunk/src/third_party/sqlite/config.sub:56589)
   A /trunk/src/third_party/sqlite/src/configure (from /trunk/src/third_party/sqlite/configure:56589)
   A /trunk/src/third_party/sqlite/src/configure.ac (from /trunk/src/third_party/sqlite/configure.ac:56589)
   A /trunk/src/third_party/sqlite/src/contrib (from /trunk/src/third_party/sqlite/contrib:56589)
   D /trunk/src/third_party/sqlite/src/date.c
   D /trunk/src/third_party/sqlite/src/delete.c
   A /trunk/src/third_party/sqlite/src/doc (from /trunk/src/third_party/sqlite/doc:56589)
   D /trunk/src/third_party/sqlite/src/expr.c
   A /trunk/src/third_party/sqlite/src/ext (from /trunk/src/third_party/sqlite/ext:56589)
   D /trunk/src/third_party/sqlite/src/fault.c
   D /trunk/src/third_party/sqlite/src/func.c
   D /trunk/src/third_party/sqlite/src/global.c
   D /trunk/src/third_party/sqlite/src/hash.c
   D /trunk/src/third_party/sqlite/src/hash.h
   D /trunk/src/third_party/sqlite/src/hwtime.h
   D /trunk/src/third_party/sqlite/src/insert.c
   A /trunk/src/third_party/sqlite/src/install-sh (from /trunk/src/third_party/sqlite/install-sh:56589)
   D /trunk/src/third_party/sqlite/src/journal.c
   D /trunk/src/third_party/sqlite/src/legacy.c
   D /trunk/src/third_party/sqlite/src/lempar.c
   D /trunk/src/third_party/sqlite/src/loadext.c
   A /trunk/src/third_party/sqlite/src/ltmain.sh (from /trunk/src/third_party/sqlite/ltmain.sh:56589)
   D /trunk/src/third_party/sqlite/src/main.c
   A /trunk/src/third_party/sqlite/src/main.mk (from /trunk/src/third_party/sqlite/main.mk:56589)
   D /trunk/src/third_party/sqlite/src/malloc.c
   A /trunk/src/third_party/sqlite/src/manifest (from /trunk/src/third_party/sqlite/manifest:56589)
   A /trunk/src/third_party/sqlite/src/manifest.uuid (from /trunk/src/third_party/sqlite/manifest.uuid:56589)
   D /trunk/src/third_party/sqlite/src/mem0.c
   D /trunk/src/third_party/sqlite/src/mem1.c
   D /trunk/src/third_party/sqlite/src/mem2.c
   D /trunk/src/third_party/sqlite/src/mem3.c
   D /trunk/src/third_party/sqlite/src/mem5.c
   D /trunk/src/third_party/sqlite/src/memjournal.c
   A /trunk/src/third_party/sqlite/src/mkdll.sh (from /trunk/src/third_party/sqlite/mkdll.sh:56589)
   A /trunk/src/third_party/sqlite/src/mkextu.sh (from /trunk/src/third_party/sqlite/mkextu.sh:56589)
   A /trunk/src/third_party/sqlite/src/mkextw.sh (from /trunk/src/third_party/sqlite/mkextw.sh:56589)
   A /trunk/src/third_party/sqlite/src/mkopcodec.awk (from /trunk/src/third_party/sqlite/mkopcodec.awk:56589)
   A /trunk/src/third_party/sqlite/src/mkopcodeh.awk (from /trunk/src/third_party/sqlite/mkopcodeh.awk:56589)
   A /trunk/src/third_party/sqlite/src/mkso.sh (from /trunk/src/third_party/sqlite/mkso.sh:56589)
   D /trunk/src/third_party/sqlite/src/mutex.c
   D /trunk/src/third_party/sqlite/src/mutex.h
   D /trunk/src/third_party/sqlite/src/mutex_noop.c
   D /trunk/src/third_party/sqlite/src/mutex_os2.c
   D /trunk/src/third_party/sqlite/src/mutex_unix.c
   D /trunk/src/third_party/sqlite/src/mutex_w32.c
   D /trunk/src/third_party/sqlite/src/notify.c
   D /trunk/src/third_party/sqlite/src/os.c
   D /trunk/src/third_party/sqlite/src/os.h
   D /trunk/src/third_party/sqlite/src/os_common.h
   D /trunk/src/third_party/sqlite/src/os_os2.c
   D /trunk/src/third_party/sqlite/src/os_symbian.cc
   D /trunk/src/third_party/sqlite/src/os_unix.c
   D /trunk/src/third_party/sqlite/src/os_win.c
   D /trunk/src/third_party/sqlite/src/pager.c
   D /trunk/src/third_party/sqlite/src/pager.h
   D /trunk/src/third_party/sqlite/src/parse.y
   D /trunk/src/third_party/sqlite/src/pcache.c
   D /trunk/src/third_party/sqlite/src/pcache.h
   D /trunk/src/third_party/sqlite/src/pcache1.c
   D /trunk/src/third_party/sqlite/src/pragma.c
   D /trunk/src/third_party/sqlite/src/prepare.c
   A /trunk/src/third_party/sqlite/src/preprocessed (from /trunk/src/third_party/sqlite/preprocessed:56589)
   D /trunk/src/third_party/sqlite/src/printf.c
   A /trunk/src/third_party/sqlite/src/publish.sh (from /trunk/src/third_party/sqlite/publish.sh:56589)
   A /trunk/src/third_party/sqlite/src/publish_osx.sh (from /trunk/src/third_party/sqlite/publish_osx.sh:56589)
   D /trunk/src/third_party/sqlite/src/random.c
   D /trunk/src/third_party/sqlite/src/resolve.c
   D /trunk/src/third_party/sqlite/src/rowset.c
   D /trunk/src/third_party/sqlite/src/select.c
   D /trunk/src/third_party/sqlite/src/shell.c
   D /trunk/src/third_party/sqlite/src/shell_icu_linux.c
   D /trunk/src/third_party/sqlite/src/shell_icu_win.c
   A /trunk/src/third_party/sqlite/src/spec.template (from /trunk/src/third_party/sqlite/spec.template:56589)
   D /trunk/src/third_party/sqlite/src/sqlite.h.in
   A /trunk/src/third_party/sqlite/src/sqlite.pc.in (from /trunk/src/third_party/sqlite/sqlite.pc.in:56589)
   A /trunk/src/third_party/sqlite/src/sqlite3.1 (from /trunk/src/third_party/sqlite/sqlite3.1:56589)
   A /trunk/src/third_party/sqlite/src/sqlite3.pc.in (from /trunk/src/third_party/sqlite/sqlite3.pc.in:56589)
   D /trunk/src/third_party/sqlite/src/sqlite3ext.h
   D /trunk/src/third_party/sqlite/src/sqliteInt.h
   D /trunk/src/third_party/sqlite/src/sqliteLimit.h
   A /trunk/src/third_party/sqlite/src/src
   A /trunk/src/third_party/sqlite/src/src/alter.c (from /trunk/src/third_party/sqlite/src/alter.c:56589)
   A /trunk/src/third_party/sqlite/src/src/analyze.c (from /trunk/src/third_party/sqlite/src/analyze.c:56589)
   A /trunk/src/third_party/sqlite/src/src/attach.c (from /trunk/src/third_party/sqlite/src/attach.c:56589)
   A /trunk/src/third_party/sqlite/src/src/auth.c (from /trunk/src/third_party/sqlite/src/auth.c:56589)
   A /trunk/src/third_party/sqlite/src/src/backup.c (from /trunk/src/third_party/sqlite/src/backup.c:56589)
   A /trunk/src/third_party/sqlite/src/src/bitvec.c (from /trunk/src/third_party/sqlite/src/bitvec.c:56589)
   A /trunk/src/third_party/sqlite/src/src/btmutex.c (from /trunk/src/third_party/sqlite/src/btmutex.c:56589)
   A /trunk/src/third_party/sqlite/src/src/btree.c (from /trunk/src/third_party/sqlite/src/btree.c:56589)
   A /trunk/src/third_party/sqlite/src/src/btree.h (from /trunk/src/third_party/sqlite/src/btree.h:56589)
   A /trunk/src/third_party/sqlite/src/src/btreeInt.h (from /trunk/src/third_party/sqlite/src/btreeInt.h:56589)
   A /trunk/src/third_party/sqlite/src/src/build.c (from /trunk/src/third_party/sqlite/src/build.c:56589)
   A /trunk/src/third_party/sqlite/src/src/callback.c (from /trunk/src/third_party/sqlite/src/callback.c:56589)
   A /trunk/src/third_party/sqlite/src/src/complete.c (from /trunk/src/third_party/sqlite/src/complete.c:56589)
   A /trunk/src/third_party/sqlite/src/src/date.c (from /trunk/src/third_party/sqlite/src/date.c:56589)
   A /trunk/src/third_party/sqlite/src/src/delete.c (from /trunk/src/third_party/sqlite/src/delete.c:56589)
   A /trunk/src/third_party/sqlite/src/src/expr.c (from /trunk/src/third_party/sqlite/src/expr.c:56589)
   A /trunk/src/third_party/sqlite/src/src/fault.c (from /trunk/src/third_party/sqlite/src/fault.c:56589)
   A /trunk/src/third_party/sqlite/src/src/func.c (from /trunk/src/third_party/sqlite/src/func.c:56589)
   A /trunk/src/third_party/sqlite/src/src/global.c (from /trunk/src/third_party/sqlite/src/global.c:56589)
   A /trunk/src/third_party/sqlite/src/src/hash.c (from /trunk/src/third_party/sqlite/src/hash.c:56589)
   A /trunk/src/third_party/sqlite/src/src/hash.h (from /trunk/src/third_party/sqlite/src/hash.h:56589)
   A /trunk/src/third_party/sqlite/src/src/hwtime.h (from /trunk/src/third_party/sqlite/src/hwtime.h:56589)
   A /trunk/src/third_party/sqlite/src/src/insert.c (from /trunk/src/third_party/sqlite/src/insert.c:56589)
   A /trunk/src/third_party/sqlite/src/src/journal.c (from /trunk/src/third_party/sqlite/src/journal.c:56589)
   A /trunk/src/third_party/sqlite/src/src/legacy.c (from /trunk/src/third_party/sqlite/src/legacy.c:56589)
   A /trunk/src/third_party/sqlite/src/src/lempar.c (from /trunk/src/third_party/sqlite/src/lempar.c:56589)
   A /trunk/src/third_party/sqlite/src/src/loadext.c (from /trunk/src/third_party/sqlite/src/loadext.c:56589)
   A /trunk/src/third_party/sqlite/src/src/main.c (from /trunk/src/third_party/sqlite/src/main.c:56589)
   A /trunk/src/third_party/sqlite/src/src/malloc.c (from /trunk/src/third_party/sqlite/src/malloc.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mem0.c (from /trunk/src/third_party/sqlite/src/mem0.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mem1.c (from /trunk/src/third_party/sqlite/src/mem1.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mem2.c (from /trunk/src/third_party/sqlite/src/mem2.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mem3.c (from /trunk/src/third_party/sqlite/src/mem3.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mem5.c (from /trunk/src/third_party/sqlite/src/mem5.c:56589)
   A /trunk/src/third_party/sqlite/src/src/memjournal.c (from /trunk/src/third_party/sqlite/src/memjournal.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mutex.c (from /trunk/src/third_party/sqlite/src/mutex.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mutex.h (from /trunk/src/third_party/sqlite/src/mutex.h:56589)
   A /trunk/src/third_party/sqlite/src/src/mutex_noop.c (from /trunk/src/third_party/sqlite/src/mutex_noop.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mutex_os2.c (from /trunk/src/third_party/sqlite/src/mutex_os2.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mutex_unix.c (from /trunk/src/third_party/sqlite/src/mutex_unix.c:56589)
   A /trunk/src/third_party/sqlite/src/src/mutex_w32.c (from /trunk/src/third_party/sqlite/src/mutex_w32.c:56589)
   A /trunk/src/third_party/sqlite/src/src/notify.c (from /trunk/src/third_party/sqlite/src/notify.c:56589)
   A /trunk/src/third_party/sqlite/src/src/os.c (from /trunk/src/third_party/sqlite/src/os.c:56589)
   A /trunk/src/third_party/sqlite/src/src/os.h (from /trunk/src/third_party/sqlite/src/os.h:56589)
   A /trunk/src/third_party/sqlite/src/src/os_common.h (from /trunk/src/third_party/sqlite/src/os_common.h:56589)
   A /trunk/src/third_party/sqlite/src/src/os_os2.c (from /trunk/src/third_party/sqlite/src/os_os2.c:56589)
   A /trunk/src/third_party/sqlite/src/src/os_symbian.cc (from /trunk/src/third_party/sqlite/src/os_symbian.cc:56589)
   A /trunk/src/third_party/sqlite/src/src/os_unix.c (from /trunk/src/third_party/sqlite/src/os_unix.c:56589)
   A /trunk/src/third_party/sqlite/src/src/os_win.c (from /trunk/src/third_party/sqlite/src/os_win.c:56589)
   A /trunk/src/third_party/sqlite/src/src/pager.c (from /trunk/src/third_party/sqlite/src/pager.c:56589)
   A /trunk/src/third_party/sqlite/src/src/pager.h (from /trunk/src/third_party/sqlite/src/pager.h:56589)
   A /trunk/src/third_party/sqlite/src/src/parse.y (from /trunk/src/third_party/sqlite/src/parse.y:56589)
   A /trunk/src/third_party/sqlite/src/src/pcache.c (from /trunk/src/third_party/sqlite/src/pcache.c:56589)
   A /trunk/src/third_party/sqlite/src/src/pcache.h (from /trunk/src/third_party/sqlite/src/pcache.h:56589)
   A /trunk/src/third_party/sqlite/src/src/pcache1.c (from /trunk/src/third_party/sqlite/src/pcache1.c:56589)
   A /trunk/src/third_party/sqlite/src/src/pragma.c (from /trunk/src/third_party/sqlite/src/pragma.c:56589)
   A /trunk/src/third_party/sqlite/src/src/prepare.c (from /trunk/src/third_party/sqlite/src/prepare.c:56589)
   A /trunk/src/third_party/sqlite/src/src/printf.c (from /trunk/src/third_party/sqlite/src/printf.c:56589)
   A /trunk/src/third_party/sqlite/src/src/random.c (from /trunk/src/third_party/sqlite/src/random.c:56589)
   A /trunk/src/third_party/sqlite/src/src/resolve.c (from /trunk/src/third_party/sqlite/src/resolve.c:56589)
   A /trunk/src/third_party/sqlite/src/src/rowset.c (from /trunk/src/third_party/sqlite/src/rowset.c:56589)
   A /trunk/src/third_party/sqlite/src/src/select.c (from /trunk/src/third_party/sqlite/src/select.c:56589)
   A /trunk/src/third_party/sqlite/src/src/shell.c (from /trunk/src/third_party/sqlite/src/shell.c:56589)
   A /trunk/src/third_party/sqlite/src/src/shell_icu_linux.c (from /trunk/src/third_party/sqlite/src/shell_icu_linux.c:56589)
   A /trunk/src/third_party/sqlite/src/src/shell_icu_win.c (from /trunk/src/third_party/sqlite/src/shell_icu_win.c:56589)
   A /trunk/src/third_party/sqlite/src/src/sqlite.h.in (from /trunk/src/third_party/sqlite/src/sqlite.h.in:56589)
   A /trunk/src/third_party/sqlite/src/src/sqlite3ext.h (from /trunk/src/third_party/sqlite/src/sqlite3ext.h:56589)
   A /trunk/src/third_party/sqlite/src/src/sqliteInt.h (from /trunk/src/third_party/sqlite/src/sqliteInt.h:56589)
   A /trunk/src/third_party/sqlite/src/src/sqliteLimit.h (from /trunk/src/third_party/sqlite/src/sqliteLimit.h:56589)
   A /trunk/src/third_party/sqlite/src/src/status.c (from /trunk/src/third_party/sqlite/src/status.c:56589)
   A /trunk/src/third_party/sqlite/src/src/table.c (from /trunk/src/third_party/sqlite/src/table.c:56589)
   A /trunk/src/third_party/sqlite/src/src/tclsqlite.c (from /trunk/src/third_party/sqlite/src/tclsqlite.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test1.c (from /trunk/src/third_party/sqlite/src/test1.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test2.c (from /trunk/src/third_party/sqlite/src/test2.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test3.c (from /trunk/src/third_party/sqlite/src/test3.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test4.c (from /trunk/src/third_party/sqlite/src/test4.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test5.c (from /trunk/src/third_party/sqlite/src/test5.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test6.c (from /trunk/src/third_party/sqlite/src/test6.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test7.c (from /trunk/src/third_party/sqlite/src/test7.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test8.c (from /trunk/src/third_party/sqlite/src/test8.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test9.c (from /trunk/src/third_party/sqlite/src/test9.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_async.c (from /trunk/src/third_party/sqlite/src/test_async.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_autoext.c (from /trunk/src/third_party/sqlite/src/test_autoext.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_backup.c (from /trunk/src/third_party/sqlite/src/test_backup.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_btree.c (from /trunk/src/third_party/sqlite/src/test_btree.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_config.c (from /trunk/src/third_party/sqlite/src/test_config.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_devsym.c (from /trunk/src/third_party/sqlite/src/test_devsym.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_func.c (from /trunk/src/third_party/sqlite/src/test_func.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_hexio.c (from /trunk/src/third_party/sqlite/src/test_hexio.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_init.c (from /trunk/src/third_party/sqlite/src/test_init.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_journal.c (from /trunk/src/third_party/sqlite/src/test_journal.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_loadext.c (from /trunk/src/third_party/sqlite/src/test_loadext.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_malloc.c (from /trunk/src/third_party/sqlite/src/test_malloc.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_md5.c (from /trunk/src/third_party/sqlite/src/test_md5.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_mutex.c (from /trunk/src/third_party/sqlite/src/test_mutex.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_onefile.c (from /trunk/src/third_party/sqlite/src/test_onefile.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_osinst.c (from /trunk/src/third_party/sqlite/src/test_osinst.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_pcache.c (from /trunk/src/third_party/sqlite/src/test_pcache.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_schema.c (from /trunk/src/third_party/sqlite/src/test_schema.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_server.c (from /trunk/src/third_party/sqlite/src/test_server.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_tclvar.c (from /trunk/src/third_party/sqlite/src/test_tclvar.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_thread.c (from /trunk/src/third_party/sqlite/src/test_thread.c:56589)
   A /trunk/src/third_party/sqlite/src/src/test_wsd.c (from /trunk/src/third_party/sqlite/src/test_wsd.c:56589)
   A /trunk/src/third_party/sqlite/src/src/tokenize.c (from /trunk/src/third_party/sqlite/src/tokenize.c:56589)
   A /trunk/src/third_party/sqlite/src/src/trigger.c (from /trunk/src/third_party/sqlite/src/trigger.c:56589)
   A /trunk/src/third_party/sqlite/src/src/update.c (from /trunk/src/third_party/sqlite/src/update.c:56589)
   A /trunk/src/third_party/sqlite/src/src/utf.c (from /trunk/src/third_party/sqlite/src/utf.c:56589)
   A /trunk/src/third_party/sqlite/src/src/util.c (from /trunk/src/third_party/sqlite/src/util.c:56589)
   A /trunk/src/third_party/sqlite/src/src/vacuum.c (from /trunk/src/third_party/sqlite/src/vacuum.c:56589)
   A /trunk/src/third_party/sqlite/src/src/vdbe.c (from /trunk/src/third_party/sqlite/src/vdbe.c:56589)
   A /trunk/src/third_party/sqlite/src/src/vdbe.h (from /trunk/src/third_party/sqlite/src/vdbe.h:56589)
   A /trunk/src/third_party/sqlite/src/src/vdbeInt.h (from /trunk/src/third_party/sqlite/src/vdbeInt.h:56589)
   A /trunk/src/third_party/sqlite/src/src/vdbeapi.c (from /trunk/src/third_party/sqlite/src/vdbeapi.c:56589)
   A /trunk/src/third_party/sqlite/src/src/vdbeaux.c (from /trunk/src/third_party/sqlite/src/vdbeaux.c:56589)
   A /trunk/src/third_party/sqlite/src/src/vdbeblob.c (from /trunk/src/third_party/sqlite/src/vdbeblob.c:56589)
   A /trunk/src/third_party/sqlite/src/src/vdbemem.c (from /trunk/src/third_party/sqlite/src/vdbemem.c:56589)
   A /trunk/src/third_party/sqlite/src/src/vtab.c (from /trunk/src/third_party/sqlite/src/vtab.c:56589)
   A /trunk/src/third_party/sqlite/src/src/walker.c (from /trunk/src/third_party/sqlite/src/walker.c:56589)
   A /trunk/src/third_party/sqlite/src/src/where.c (from /trunk/src/third_party/sqlite/src/where.c:56589)
   D /trunk/src/third_party/sqlite/src/status.c
   D /trunk/src/third_party/sqlite/src/table.c
   D /trunk/src/third_party/sqlite/src/tclsqlite.c
   A /trunk/src/third_party/sqlite/src/test (from /trunk/src/third_party/sqlite/test:56589)
   D /trunk/src/third_party/sqlite/src/test1.c
   D /trunk/src/third_party/sqlite/src/test2.c
   D /trunk/src/third_party/sqlite/src/test3.c
   D /trunk/src/third_party/sqlite/src/test4.c
   D /trunk/src/third_party/sqlite/src/test5.c
   D /trunk/src/third_party/sqlite/src/test6.c
   D /trunk/src/third_party/sqlite/src/test7.c
   D /trunk/src/third_party/sqlite/src/test8.c
   D /trunk/src/third_party/sqlite/src/test9.c
   D /trunk/src/third_party/sqlite/src/test_async.c
   D /trunk/src/third_party/sqlite/src/test_autoext.c
   D /trunk/src/third_party/sqlite/src/test_backup.c
   D /trunk/src/third_party/sqlite/src/test_btree.c
   D /trunk/src/third_party/sqlite/src/test_config.c
   D /trunk/src/third_party/sqlite/src/test_devsym.c
   D /trunk/src/third_party/sqlite/src/test_func.c
   D /trunk/src/third_party/sqlite/src/test_hexio.c
   D /trunk/src/third_party/sqlite/src/test_init.c
   D /trunk/src/third_party/sqlite/src/test_journal.c
   D /trunk/src/third_party/sqlite/src/test_loadext.c
   D /trunk/src/third_party/sqlite/src/test_malloc.c
   D /trunk/src/third_party/sqlite/src/test_md5.c
   D /trunk/src/third_party/sqlite/src/test_mutex.c
   D /trunk/src/third_party/sqlite/src/test_onefile.c
   D /trunk/src/third_party/sqlite/src/test_osinst.c
   D /trunk/src/third_party/sqlite/src/test_pcache.c
   D /trunk/src/third_party/sqlite/src/test_schema.c
   D /trunk/src/third_party/sqlite/src/test_server.c
   D /trunk/src/third_party/sqlite/src/test_tclvar.c
   D /trunk/src/third_party/sqlite/src/test_thread.c
   D /trunk/src/third_party/sqlite/src/test_wsd.c
   D /trunk/src/third_party/sqlite/src/tokenize.c
   A /trunk/src/third_party/sqlite/src/tool (from /trunk/src/third_party/sqlite/tool:56589)
   D /trunk/src/third_party/sqlite/src/trigger.c
   D /trunk/src/third_party/sqlite/src/update.c
   D /trunk/src/third_party/sqlite/src/utf.c
   D /trunk/src/third_party/sqlite/src/util.c
   D /trunk/src/third_party/sqlite/src/vacuum.c
   D /trunk/src/third_party/sqlite/src/vdbe.c
   D /trunk/src/third_party/sqlite/src/vdbe.h
   D /trunk/src/third_party/sqlite/src/vdbeInt.h
   D /trunk/src/third_party/sqlite/src/vdbeapi.c
   D /trunk/src/third_party/sqlite/src/vdbeaux.c
   D /trunk/src/third_party/sqlite/src/vdbeblob.c
   D /trunk/src/third_party/sqlite/src/vdbemem.c
   D /trunk/src/third_party/sqlite/src/vtab.c
   D /trunk/src/third_party/sqlite/src/walker.c
   D /trunk/src/third_party/sqlite/src/where.c
   A /trunk/src/third_party/sqlite/src/www (from /trunk/src/third_party/sqlite/www:56589)
   D /trunk/src/third_party/sqlite/test
   D /trunk/src/third_party/sqlite/tool
   D /trunk/src/third_party/sqlite/www
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc

Move bundled copy of sqlite one level deeper to better separate it
from our patches, READMEs, etc.

Also, add a shim header so we can use it for building
with system sqlite.

TEST=compile
BUG=22208
Review URL: http://codereview.chromium.org/3108030
------------------------------------------------------------------------
r56616 | seanparent@google.com | 2010-08-19 01:27:08 +0200 (Thu, 19 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/update_observer.cc
   M /trunk/src/chrome/browser/chromeos/update_observer.h

Only showing notification when a restart is needed. Partial fix to 5168.

BUG=chromium-os:5168
TEST=Manual - use devserver to install update and verify notification
appears to restart after update is installed with no other notifications.

Review URL: http://codereview.chromium.org/3157018
------------------------------------------------------------------------
r56615 | vandebo@chromium.org | 2010-08-19 01:26:51 +0200 (Thu, 19 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/predictor_unittest.cc
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc

Don't resolve IP literals.

For each resolution request this checks to see if this 'host' is a literal ip address.  If so, it synthesises a struct addrinfo and returns it without adding it to the cache.

BUG=39830
TEST=unit tests, new and old

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56384

Review URL: http://codereview.chromium.org/3023048
------------------------------------------------------------------------
r56614 | mirandac@chromium.org | 2010-08-19 01:25:53 +0200 (Thu, 19 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run_win.cc

Open welcome page on first run.

BUG=52378
TEST=organic first run should show welcome page.  run with skip_first_run_ui should not show welcome page unless forced by master_preferences.

Review URL: http://codereview.chromium.org/3151026
------------------------------------------------------------------------
r56610 | rvargas@google.com | 2010-08-19 00:15:09 +0200 (Thu, 19 Aug 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/remoting/remoting_resources_source.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/remoting/resources/setup_done.html
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/browser/service/service_process_control_manager.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/service/remoting/remoting_directory_service.cc
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/remoting/host/chromoting_host.cc

Revert 56600 - ServiceProcessControlBrowserTest.LaunchAndIPC crashes.

Start/stop service process when browser starts and stop

Save the information that the setup of remoting has completed.

After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.

Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.

Review URL: http://codereview.chromium.org/3185015

TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/3107024
------------------------------------------------------------------------
r56608 | evan@chromium.org | 2010-08-18 23:59:31 +0200 (Wed, 18 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/webkit/appcache/view_appcache_internals_job.cc

Revert "Convert FormatBytes to string16."

This reverts commit r56603.
------------------------------------------------------------------------
r56603 | evan@chromium.org | 2010-08-18 23:30:36 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/webkit/appcache/view_appcache_internals_job.cc

Convert FormatBytes to string16.

I considered ASCII, but it's producing what is intended to be a
human-readable string.  For example, in theory the "bytes/s" annotation
could be localized into a language where the "b" is non-ASCII.

Review URL: http://codereview.chromium.org/3107021
------------------------------------------------------------------------
r56601 | cmasone@google.com | 2010-08-18 23:05:24 +0200 (Wed, 18 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/data/extensions/permissions-high-v2.crx

Re-land r56529, and add fixes for the browser tests on chromium os.

Add fixes for browser tests broken by r56529

Revert "Revert 56529 - [Chrome OS] Block the installation of extensions with NPAPI plugins"

BUG=chromium-os:5454
TEST=browser tests, unit tests

This reverts commit 8e3ffd2dab317dd7fb2d501353153d3e4dcc1c90.

Review URL: http://codereview.chromium.org/3164026
------------------------------------------------------------------------
r56600 | hclam@chromium.org | 2010-08-18 23:04:49 +0200 (Wed, 18 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/remoting/remoting_resources_source.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/remoting/resources/setup_done.html
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/browser/service/service_process_control_manager.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/service/remoting/remoting_directory_service.cc
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/remoting/host/chromoting_host.cc

Start/stop service process when browser starts and stop

Save the information that the setup of remoting has completed.

After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.

Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.

Review URL: http://codereview.chromium.org/3185015
------------------------------------------------------------------------
r56598 | johnnyg@chromium.org | 2010-08-18 23:03:06 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/notification_1line.html
   M /trunk/src/chrome/browser/resources/notification_2line.html
   M /trunk/src/chrome/browser/resources/notification_icon.html

Get the same margin on all sides of the notification.

BUG=52545
TEST=create text notifications of various sizes, watch for a clipped bottom margin.

Review URL: http://codereview.chromium.org/3131021
------------------------------------------------------------------------
r56597 | csilv@chromium.org | 2010-08-18 23:00:18 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/options_managed_banner_handler.cc
   A /trunk/src/chrome/browser/dom_ui/options_managed_banner_handler.h
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Display a banner above each panel that contains managed options.

BUG=52099
TEST=Test with managed options and --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3108018
------------------------------------------------------------------------
r56596 | atwilson@chromium.org | 2010-08-18 22:55:45 +0200 (Wed, 18 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service.h
   A /trunk/src/chrome/browser/background_mode_manager.cc
   A /trunk/src/chrome/browser/background_mode_manager.h
   A /trunk/src/chrome/browser/background_mode_manager_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_tray_mac.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_tray_mac.mm
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.h
   M /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/status_icons/status_tray.cc
   M /trunk/src/chrome/browser/status_icons/status_tray.h
   D /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   D /trunk/src/chrome/browser/status_icons/status_tray_manager.h
   M /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc
   A /trunk/src/chrome/browser/views/status_icons/status_tray_gtk.cc
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win.cc
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win.h
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/testing_profile.h

Added BackgroundModeManager which tracks when background apps are loaded/unloaded
and puts Chrome into BackgroundMode appropriately.

Added EXTENSION_UNINSTALLING notification which is sent out when a notification
is about to be uninstalled.

Refactored StatusTray code to move StatusTray under the profile rather than
attaching it to the browser process, and removed StatusTrayManager which is
no longer needed now that BackgroundModeManager handles creating status icons.

BUG=43382
TEST=background_mode_manager_unittests.cc

Review URL: http://codereview.chromium.org/3134011
------------------------------------------------------------------------
r56592 | shess@chromium.org | 2010-08-18 22:34:04 +0200 (Wed, 18 Aug 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom_unittest.cc (from /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc:56588)
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Refactor SafeBrowsingDatabase for transition to new file format.

Refactor old SafeBrowsingDatabase code to allow for transitioning from
the old SQLite-based store to a new SQLite-based store, and from there
to the final raw file-based store.

The intended rollout is:
 - Rollout with SafeBrowsingDatabaseBloom (basically the old code).
 - Rollout SafeBrowsingDatabase+SafeBrowsingStoreSqlite.  This changes
   much of the code, but not the file format, so revert is possible
   without resync'ing everyone's store (unless the stores have been
   corrupted or something).
 - Rollout SafeBrowsingDatabase+SafeBrowsingStoreFile.  This changes
   the file format while the control code stays the same.  Revert
   requires resync.
 - Rollout a big cleanup which removes dead code.

BUG=28647
TEST=Safe browsing continues to work.

Review URL: http://codereview.chromium.org/3141009
------------------------------------------------------------------------
r56590 | erg@google.com | 2010-08-18 22:25:01 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.h
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.mm
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac_unittest.mm
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/extension_action_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

FBTF: Remove a few SkBitmap instances (and other headers that were next to them).

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3161027
------------------------------------------------------------------------
r56589 | pkasting@chromium.org | 2010-08-18 22:20:05 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/gfx/canvas.h
   M /trunk/src/gfx/canvas_direct2d.cc
   M /trunk/src/gfx/canvas_direct2d.h
   M /trunk/src/gfx/canvas_skia.cc
   M /trunk/src/gfx/canvas_skia.h
   M /trunk/src/gfx/canvas_skia_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc

Convert FillRect(... SkPaint) to DrawRect() since it doesn't necessarily fill, it just draws with the provided paint.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3165032
------------------------------------------------------------------------
r56587 | pkasting@chromium.org | 2010-08-18 22:19:20 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/find_box_bg_left_rtl.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

Remove an unnecessary image using auto-mirroring.

BUG=none
TEST=Find bar still looks right in RTL mode
Review URL: http://codereview.chromium.org/3162017
------------------------------------------------------------------------
r56583 | panayiotis@google.com | 2010-08-18 22:01:18 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Fix the urls reported as page_url and referer_url when a redirect is involved.

Bug=None
Test=Manually verified with sites redirecting to malware.

Review URL: http://codereview.chromium.org/3151018
------------------------------------------------------------------------
r56580 | jhawkins@chromium.org | 2010-08-18 21:52:54 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc

DOMUI: Use the OriginalProfile() to load the PersonalDataManager for AutoFill
settings.

BUG=52521
TEST=none

Review URL: http://codereview.chromium.org/3125020
------------------------------------------------------------------------
r56579 | zelidrag@chromium.org | 2010-08-18 21:49:50 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js

Removed 'stop syncing' button from chromeos options.

BUG=chromium-os:5842
TEST=make sure 'stop syncing' button never shows up on chrome os options (domui)

Review URL: http://codereview.chromium.org/3190007
------------------------------------------------------------------------
r56578 | sky@chromium.org | 2010-08-18 21:48:46 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/chrome_browser.gypi

Adds RenderWidgetHostWillPaint. I need this for something else I'm
working on.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3152026
------------------------------------------------------------------------
r56576 | rohitrao@chromium.org | 2010-08-18 21:42:05 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/new_tab_button.h
   M /trunk/src/chrome/browser/cocoa/new_tab_button.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h

[Mac] Fix the new tab button hover bounds to match what we test for in hitTest.

BUG=52302
TEST=New tab button should never highlight when the mouse is close to but still outside the button.
Review URL: http://codereview.chromium.org/3153016
------------------------------------------------------------------------
r56574 | mirandac@chromium.org | 2010-08-18 21:38:48 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run_win.cc

Ensure that import works according to the chart in go/chromefirstrun when skip-first-run-ui preference has been set in master_preferences.

BUG=52632
TEST=test master_preferences import settings (import_search_engine, import_bookmarks, import_home_page, import_history).  test with organic and non-organic builds, and with skip-first-run-ui turned on for non-organic builds.  should follow pattern described in go/chromefirstrun.


Review URL: http://codereview.chromium.org/3186008
------------------------------------------------------------------------
r56573 | phajdan.jr@chromium.org | 2010-08-18 21:16:29 +0200 (Wed, 18 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Revert 56529 - [Chrome OS] Block the installation of extensions with NPAPI plugins

BUG=chromium-os:5454
TEST=try to install http://www.3djam.com/roozz/roozz-plugin.crx, see that it is rejected.  Try to install https://chrome.google.com/extensions/detail/gofhjkjmkpinhpoiabjplobcaignabnl, see that it works.  And...unit tests

Review URL: http://codereview.chromium.org/3163013

TBR=cmasone@google.com
Review URL: http://codereview.chromium.org/3174015
------------------------------------------------------------------------
r56571 | sargrass@google.com | 2010-08-18 20:45:05 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   A /trunk/src/chrome/browser/dom_ui/passwords_remove_all_handler.cc
   A /trunk/src/chrome/browser/dom_ui/passwords_remove_all_handler.h
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.js
   A /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.html
   A /trunk/src/chrome/browser/resources/options/passwords_remove_all_overlay.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Make the saved passwords tab work.

BUG=49093
TEST=None

Review URL: http://codereview.chromium.org/3194002
------------------------------------------------------------------------
r56566 | rsesek@chromium.org | 2010-08-18 20:36:57 +0200 (Wed, 18 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/menu_tracked_button.h
   M /trunk/src/chrome/browser/cocoa/menu_tracked_button.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   A /trunk/src/chrome/browser/ui_thread_helpers.h
   A /trunk/src/chrome/browser/ui_thread_helpers_linux.cc
   A /trunk/src/chrome/browser/ui_thread_helpers_mac.mm
   A /trunk/src/chrome/browser/ui_thread_helpers_win.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Don't close the Wrench menu after using the zoom buttons if the menu was opened sticky.

This runs the Task that updates the zoom information in the UI thread outside of the
normal MessageLoop and instead runs it on the native run loop.

R=mark
BUG=48679
TEST=Open Wrench menu with a click. Use zoom buttons. Menu stays open and page zooms. Other buttons still close menu.
TEST=Open Wrench menu with click-hold-drag. Hover and release on zoom buttons. Menu closes and page zooms.

Review URL: http://codereview.chromium.org/3183013
------------------------------------------------------------------------
r56564 | kinuko@chromium.org | 2010-08-18 20:34:31 +0200 (Wed, 18 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   D /trunk/src/webkit/glue/webfilesystem_impl.cc
   D /trunk/src/webkit/glue/webfilesystem_impl.h
   A /trunk/src/webkit/glue/webfileutilities_impl.cc (from /trunk/src/webkit/glue/webfilesystem_impl.cc:56544)
   A /trunk/src/webkit/glue/webfileutilities_impl.h (from /trunk/src/webkit/glue/webfilesystem_impl.h:56544)
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/support/test_webkit_client.cc
   M /trunk/src/webkit/support/test_webkit_client.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Rename WebFileSystem to WebFileUtilities for corresponding WebKit API changes.

This change depends on an upstream change (not yet rolled):
http://trac.webkit.org/changeset/65482

BUG=52355
TESTS=existing tests (like ones under fast/files) should pass

Review URL: http://codereview.chromium.org/3153015
------------------------------------------------------------------------
r56563 | erg@google.com | 2010-08-18 20:33:57 +0200 (Wed, 18 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/cocoa/about_ipc_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_ipc_controller_unittest.mm
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_messages.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/gpu_messages_unittest.cc
   M /trunk/src/chrome/common/gpu_video_common.cc
   M /trunk/src/chrome/common/gpu_video_common.h
   M /trunk/src/chrome/common/indexed_db_param_traits.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/utility_messages.h
   M /trunk/src/chrome/common/webkit_param_traits.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_webcookiejar_impl.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/protocol_sink_wrap.cc
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/ipc/ipc_logging.h
   M /trunk/src/ipc/ipc_message.h
   M /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/ipc/ipc_message_utils.h

Remove all wstrings from the IPC logging subsystem.

Changes all IPC Log methods from wstring to string. All static logging debug
data changed from wchar[] to char[].

Various string conversion/numeric headers no longer need to be included in
ipc_message_utils.h and have been removed (and added in all implementation
files that require them).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3159013
------------------------------------------------------------------------
r56559 | phajdan.jr@chromium.org | 2010-08-18 20:33:00 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/automation/testing_automation_provider.cc (from /trunk/src/chrome/browser/automation/automation_provider.cc:56426)
   A /trunk/src/chrome/browser/automation/testing_automation_provider.h (from /trunk/src/chrome/browser/automation/automation_provider.h:56426)
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTTF: Move TestingAutomationProvider to its own file.

Use "svn cp" to preserve svn metadata.

TEST=compile, no code change
BUG=52097
Review URL: http://codereview.chromium.org/3112014
------------------------------------------------------------------------
r56556 | mmenke@chromium.org | 2010-08-18 20:01:15 +0200 (Wed, 18 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_source_type_list.h
   M /trunk/src/net/base/net_log_unittest.h
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Revert 56539 - Added HostResolveImpl Requests and Jobs to log.

ConnectJobs point to the requests, Requests point back to ConnectJobs and to the DNS lookup they were attached to, if any.

Also CONNECT_JOBs are now identified by their host/port on the Requests list.


BUG= 46844
TEST= Look at the net-internals screen.


Review URL: http://codereview.chromium.org/3080034

TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/3137022
------------------------------------------------------------------------
r56544 | thomasvl@chromium.org | 2010-08-18 19:08:03 +0200 (Wed, 18 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/common/net/url_fetcher_protect.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_browser_process.h

Win IO Perf Regressions
http://build.chromium.org/buildbot/perf/xp-release-dual-core/moz/report.html?history=150&rev=-1&graph=total_byte_b

Revert 56483 - Monitor network change in GoogleURLTracker

BUG=48688,15141
TEST=GoogleURLTrackerTest.MonitorNetworkChange passes

Review URL: http://codereview.chromium.org/3034018

TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/3176017
------------------------------------------------------------------------
r56543 | thomasvl@chromium.org | 2010-08-18 19:05:18 +0200 (Wed, 18 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/common/net/test_url_fetcher_factory.h

Revert 56522 - Fix leaks in GoogleURLTrackerTest::CreateRequestContext()

URLFetcher will release URLRequestContextGetter in CancelURLRequest,
which runs in IOMessageLoopProxy. So, if a test doesn't run with
IO thread, it will not run CancelURLRequest from URLFetcher::Core::Stop().

BUG=52562
TEST=./tools/valgrind/chrome_tests.sh --test unit --tool memcheck --gtest_filter='GoogleURLTrackerTest.*'

Review URL: http://codereview.chromium.org/3198001

TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/3160025
------------------------------------------------------------------------
r56539 | mmenke@chromium.org | 2010-08-18 18:38:00 +0200 (Wed, 18 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_source_type_list.h
   M /trunk/src/net/base/net_log_unittest.h
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Added HostResolveImpl Requests and Jobs to log.

ConnectJobs point to the requests, Requests point back to ConnectJobs and to the DNS lookup they were attached to, if any.

Also CONNECT_JOBs are now identified by their host/port on the Requests list.


BUG= 46844
TEST= Look at the net-internals screen.


Review URL: http://codereview.chromium.org/3080034
------------------------------------------------------------------------
r56538 | jar@chromium.org | 2010-08-18 18:32:14 +0200 (Wed, 18 Aug 2010) | 33 lines
Changed paths:
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/predictor_unittest.cc

Reduce "false positive" in preconnect rates.

Histograms suggest that all too often, we create a preconnection
for an omnibox entry (for a search URL), and then the 
connection goes unused.  This probably happens when
the first few letters of an URL are typed, but are
misconstrued to be a search URL.  I added code that
requires a sequence of consecutive assertions by the
omnibox that the URL is preconnectable (i.e., is a
search URL).  This will give me something to tune, but
this CL pulls a number out of teh air, in hopes of
getting some baseline.

I also noticed that the unused connections courtesy 
of speculative subresource preconnection was higher
than expected, and the number of cases where we
didn't bother to even do a pre-resolut1ion for
a subresource was higher than expected.  It used
to be that I did sub-resource pre-resolution for
all 8 learned speculative names.  Now that we
have preconnection as an alternative, I extended
the count to 10 names learned, but put in a
threshold for expected connections.  I adjusted
the thresholds to increase the amount of
pre-resolution, and decrease the amount of
preconection.  I really need an A/B test
to optimize these, but initially I wanted
to get a feel for what happens with different
limits.

BUG=42694
r=mbelshe
Review URL: http://codereview.chromium.org/3126012
------------------------------------------------------------------------
r56537 | stuartmorgan@chromium.org | 2010-08-18 18:25:52 +0200 (Wed, 18 Aug 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/options/list_inline_header_selection_controller.js
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.css
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.js
   A /trunk/src/chrome/browser/resources/options/search_engine_manager_engine_list.js
   M /trunk/src/chrome/browser/resources/options.html

DOMUI prefs: Move inline header list class into its own file for reuse.

Moves some corresponding CSS into the shared options CSS file as well; all of this will be re-used by other pref panes.
Also splits the search engine list class into a separate file.

BUG=None
TEST=Search engine manager should continue to work.

Review URL: http://codereview.chromium.org/3153019
------------------------------------------------------------------------
r56535 | tony@chromium.org | 2010-08-18 18:23:18 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/base/i18n/rtl.cc
   M /trunk/src/base/i18n/rtl.h
   M /trunk/src/base/i18n/rtl_unittest.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/views/controls/label.cc

Convert GetDisplayStringInLTRDirectionality from wstring to string16.

BUG=23581

Review URL: http://codereview.chromium.org/3108027
------------------------------------------------------------------------
r56534 | jcivelli@chromium.org | 2010-08-18 18:19:53 +0200 (Wed, 18 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Ensures we don't let users translate pages that are in an unsupported language by disabling the context menu in such cases.
It is OK to translate pages for which the language is unknown, as we let the server detect the language in such cases.

BUG=48635
TEST=Not sure how to repro without hacking the code.
     You need a page in a language that the CLD detects but that Chrome does not support for translation.

Review URL: http://codereview.chromium.org/3142015
------------------------------------------------------------------------
r56533 | viettrungluu@chromium.org | 2010-08-18 18:17:20 +0200 (Wed, 18 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

Convert strings in bookmarks, part 2.

This eliminates the wstring version of
BookmarkModel::GetBookmarksWithTitleMatchingTerm(). It also converts a pile of
wide strings in bookmark_model_unittest.cc.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3141024
------------------------------------------------------------------------
r56532 | andybons@chromium.org | 2010-08-18 18:04:47 +0200 (Wed, 18 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm

[Mac] Retain a reference within a scoped_nsobject of a Page Action's context menu.

The problem was that the menu was being dealloc'd upon selection of the 'Uninstall' option, which asynchonously loads the extension's icon. Upon deallocation, the ImageTracker was also being destructed and the loading cancelled, leaving OnImageLoad to never be called.

BUG=40233
TEST=see bug for repro steps. should be able to uninstall page actions through their context menus.

Review URL: http://codereview.chromium.org/3148018
------------------------------------------------------------------------
r56530 | stuartmorgan@chromium.org | 2010-08-18 17:59:15 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.h
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.css
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.html
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.js
   A /trunk/src/chrome/browser/resources/options/add_startup_page_recent_pages_list.js
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.css
   M /trunk/src/chrome/browser/resources/options.html

DOMUI prefs: Add the recent pages list to the 'add startup page' overlay

BUG=49090
TEST=Add a startup page using DOMUI prefs; there should be a list of recently-visited pages to choose from.

Review URL: http://codereview.chromium.org/3116018
------------------------------------------------------------------------
r56529 | cmasone@google.com | 2010-08-18 17:47:50 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

[Chrome OS] Block the installation of extensions with NPAPI plugins

BUG=chromium-os:5454
TEST=try to install http://www.3djam.com/roozz/roozz-plugin.crx, see that it is rejected.  Try to install https://chrome.google.com/extensions/detail/gofhjkjmkpinhpoiabjplobcaignabnl, see that it works.  And...unit tests

Review URL: http://codereview.chromium.org/3163013
------------------------------------------------------------------------
r56527 | markusheintz@chromium.org | 2010-08-18 16:25:35 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Upate privacy options preference UI GTK widgets when the corresponding policies change at runtime.

BUG=52436
TEST=manual

Review URL: http://codereview.chromium.org/3175011
------------------------------------------------------------------------
r56526 | avi@chromium.org | 2010-08-18 16:18:11 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Show keyboard focus on toolbar buttons.

BUG=52536
TEST=as in bug

Review URL: http://codereview.chromium.org/3151023
------------------------------------------------------------------------
r56525 | satish@chromium.org | 2010-08-18 16:01:21 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_recognition_request.cc
   M /trunk/src/chrome/browser/speech/speech_recognition_request.h
   M /trunk/src/chrome/browser/speech/speech_recognition_request_unittest.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Compress recorded audio with speex before transmitting to server for recognition.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3189007
------------------------------------------------------------------------
r56524 | bulach@chromium.org | 2010-08-18 15:54:59 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/idbbindingutilities_browsertest.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/indexed_db_param_traits.h
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/utility_messages.h
   M /trunk/src/chrome/common/utility_messages_internal.h
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h
   A /trunk/src/webkit/glue/idb_bindings.cc
   A /trunk/src/webkit/glue/idb_bindings.h
   M /trunk/src/webkit/glue/webkit_glue.gypi

Adds IDBKeyPath parser / extractor, and provides a mechanism to call it sandboxed.

TEST=idbkeypathextractor_browsertests.cc

Review URL: http://codereview.chromium.org/3043037
------------------------------------------------------------------------
r56522 | ukai@chromium.org | 2010-08-18 15:00:22 +0200 (Wed, 18 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/common/net/test_url_fetcher_factory.h

Fix leaks in GoogleURLTrackerTest::CreateRequestContext()

URLFetcher will release URLRequestContextGetter in CancelURLRequest,
which runs in IOMessageLoopProxy. So, if a test doesn't run with
IO thread, it will not run CancelURLRequest from URLFetcher::Core::Stop().

BUG=52562
TEST=./tools/valgrind/chrome_tests.sh --test unit --tool memcheck --gtest_filter='GoogleURLTrackerTest.*'

Review URL: http://codereview.chromium.org/3198001
------------------------------------------------------------------------
r56518 | yurys@chromium.org | 2010-08-18 14:28:37 +0200 (Wed, 18 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: remove tests that have been converted into layout tests

Review URL: http://codereview.chromium.org/3104018
------------------------------------------------------------------------
r56497 | thestig@chromium.org | 2010-08-18 09:55:41 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Mark SSLUITest.TestDisplaysInsecureContentLoadedFromJS as flaky on Win32.

BUG=52557
TEST=none
Review URL: http://codereview.chromium.org/3125021
------------------------------------------------------------------------
r56495 | jochen@chromium.org | 2010-08-18 09:42:27 +0200 (Wed, 18 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc

Revert 56315 - [Gtk] Display the current content setting applying to a domain along with the domain.

This patch only affectes the gtk ui. Here is what it looks like: http://imgur.com/g6Gox

If third party cookies are blocked, a warning is shown. Next to each domain, the content setting is displayed that applies (or nothing if the default applies). When the user selects some domains and presses an button, the labels are updated accordingly.

BUG=49826
TEST=unit_tests

Review URL: http://codereview.chromium.org/3096001

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3194004
------------------------------------------------------------------------
r56494 | bauerb@chromium.org | 2010-08-18 09:37:42 +0200 (Wed, 18 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/plugin_group_unittest.cc

Disable outdated plug-ins on a per-plugin basis.

Change the automatic disabling of outdated plugins (with --disable-outdated-plugins) so that a single plugin is disabled if it is out of date instead of the whole group.

This makes it possible to fall back on a newer version of a plugin that would otherwise have lower priority.

BUG=47731,51728
TEST=Install an old version and a new version of a plugin, run with --disable-outdated-plugins. The old version should be disabled, and the effective version of the plugin group should be the new one.

Review URL: http://codereview.chromium.org/3117009
------------------------------------------------------------------------
r56493 | pam@chromium.org | 2010-08-18 09:25:50 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   A /trunk/src/chrome/browser/pref_notifier.cc
   A /trunk/src/chrome/browser/pref_notifier.h
   A /trunk/src/chrome/browser/pref_notifier_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/browser/scoped_pref_update.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_pref_service.cc

Refactor PrefService, pulling the PREF_CHANGED notification infrastructure out so
it can be accessed by both the PrefService, for user preferences, and the individal
PrefStores, for preferences set "from below" (e.g., by configuration policy changes).

BUG=50722
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/3052045
------------------------------------------------------------------------
r56492 | dpolukhin@chromium.org | 2010-08-18 09:23:01 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc

Don't show non-localized detailed error info in bubbles.

BUG=chromium-os:5600
TEST=On Chrome OS login screen enter wrong password.

Review URL: http://codereview.chromium.org/3111009
------------------------------------------------------------------------
r56491 | jochen@chromium.org | 2010-08-18 09:17:09 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webcookiejar_impl.cc
   M /trunk/src/chrome/renderer/renderer_webcookiejar_impl.h

Don't claim we would always block cookies, since there are always exceptions.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3158016
------------------------------------------------------------------------
r56488 | viettrungluu@chromium.org | 2010-08-18 08:34:13 +0200 (Wed, 18 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc

Remove wstrings from bookmarks, part 1 (of many).

Start by removing wstring versions of BookmarkModel::AddURLWithCreationTime()
and BookmarkModel::SetURLStarred().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3111012
------------------------------------------------------------------------
r56487 | satorux@chromium.org | 2010-08-18 07:32:35 +0200 (Wed, 18 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_pinyin_options.html

Fix two bugs in pinyin config.

1. Remove "display candidates in Traditonal Chinese" config as it's no longer
present in the upstream.

2. Rephrase an incorrect description "Use Shift key to select a candidate"
per suggestion from penghuang.

BUG=chromium-os:4856,chromium-os:4685
TEST=manually

Review URL: http://codereview.chromium.org/3145023
------------------------------------------------------------------------
r56486 | satorux@chromium.org | 2010-08-18 07:19:46 +0200 (Wed, 18 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   D /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_chewing_options.html
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI - Fix a bug in the chewing config page.

We were showing 1 or 2 instead of meaningful labels.

TEST=manually
BUG=chromium-os:5690

Review URL: http://codereview.chromium.org/3165034
------------------------------------------------------------------------
r56485 | yusukes@chromium.org | 2010-08-18 07:08:22 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Modify language menu so it does not take the keyboard focus on popup.

BUG=chromium-os:5796
TEST=login, enable Japanese IME, click Omnibox, type aaa, make sure a preedit string like あああ is shown, click the language menu botton on the top-right corner of Chrome, make sure the language menu pops up, click the button again to close the menu, verify that the preedit string あああ still exists.

Review URL: http://codereview.chromium.org/3185009
------------------------------------------------------------------------
r56483 | ukai@chromium.org | 2010-08-18 05:59:31 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/common/net/url_fetcher_protect.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_browser_process.h

Monitor network change in GoogleURLTracker

BUG=48688,15141
TEST=GoogleURLTrackerTest.MonitorNetworkChange passes

Review URL: http://codereview.chromium.org/3034018
------------------------------------------------------------------------
r56476 | johnnyg@chromium.org | 2010-08-18 04:40:42 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc

Temporarily disable TimelineApi until the webkit cause can be reverted and the revert rolled to.

BUG=none
TEST=none
TBR=yutak

Review URL: http://codereview.chromium.org/3180010
------------------------------------------------------------------------
r56472 | scherkus@chromium.org | 2010-08-18 03:16:37 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Removing FLAKY from MediaTest.* UI tests as they appear to be passing consistently now.

BUG=51969
TEST=MediaTest.* should remain green

Review URL: http://codereview.chromium.org/3116016
------------------------------------------------------------------------
r56470 | aa@chromium.org | 2010-08-18 02:51:46 +0200 (Wed, 18 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc

Allow data URLs to load chrome-extension:// resources. Basic
notifications use data: URLs internally so this was required
to support that.

Also rejigger the logic in this area again to clarify and fix
an issue where the incognito window check did not have high
enough priority.

Also add back a null-pointer check that was previously in this code and is apparently necessary with a comment.

BUG=52313,52374

Review URL: http://codereview.chromium.org/3159019
------------------------------------------------------------------------
r56462 | tim@chromium.org | 2010-08-18 02:23:29 +0200 (Wed, 18 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   A /trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc
   A /trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   A /trunk/src/chrome/browser/dom_ui/value_helper.cc
   A /trunk/src/chrome/browser/dom_ui/value_helper.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore.h
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   A /trunk/src/chrome/browser/sync/glue/session_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/session_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/session_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/session_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/session_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/session_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   A /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h

sync: take two for:

Added classes to enable session sync functionality.

TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by : jerrica@chromium.org
Original review http://codereview.chromium.org/3168009

Review URL: http://codereview.chromium.org/3133022
------------------------------------------------------------------------
r56460 | davemoore@chromium.org | 2010-08-18 02:06:31 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Allow render_widget_host_gtk to autoscroll even when widget is against edge of screen
BUG=chromium-os:5669
TEST=Drag select text each edge. View should start scrolling and extending the selection. http://deanoakley.com/ is a good example of a very wide site for testing horizontal sides. Go fullscreen to test up.

Review URL: http://codereview.chromium.org/3158013
------------------------------------------------------------------------
r56450 | pkasting@chromium.org | 2010-08-18 01:33:30 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Fix parentheses omission which led to tab misplacement in maximized mode.  Also remove an extra pair of parentheses that snuck in.

TBR=jcivelli
BUG=none
TEST=When maximized with a custom theme, tabs should be at the top of the screen
Review URL: http://codereview.chromium.org/3191006
------------------------------------------------------------------------
r56449 | mirandac@chromium.org | 2010-08-18 01:31:13 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run_win.cc

Import search engines on first run in organic builds.  Once this patch is in, if the default search engine imported is not included in the first three shown in the search engine dialog, it will appear as a fourth choice.

BUG=52496
TEST=search engines are imported in organic builds.
Review URL: http://codereview.chromium.org/3181019
------------------------------------------------------------------------
r56445 | isherman@chromium.org | 2010-08-18 01:00:19 +0200 (Wed, 18 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h

Disable autocomplete for search keywords.

We have custom UI for search keywords anyway, so in practice a user would never see the autocompleted url.  But, we had been computing the index incorrectly in some cases, as we trim off "http://" and "www." to compute the keyword.  Since we don't use it anyway, simplify the logic and get rid of it :)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3151020
------------------------------------------------------------------------
r56439 | phajdan.jr@chromium.org | 2010-08-18 00:45:53 +0200 (Wed, 18 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Fix a problem with Geolocation tests trying to start the test server twice.

Will it fix some flakiness problems? Who knows. But at least NoInfobarForDeniedOrigin
should stop failing on XP (it's calling Initialize twice).

TBR=bulach, joth

BUG=49680, 52518

Review URL: http://codereview.chromium.org/3127018
------------------------------------------------------------------------
r56435 | georgey@chromium.org | 2010-08-18 00:44:29 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFillManagerTest.GetProfileSuggestionsEmptyValue crashes in official builds
BUG=50537
TEST=In the bug: unit test should work on any brand.

Review URL: http://codereview.chromium.org/3160022
------------------------------------------------------------------------
r56434 | pkasting@chromium.org | 2010-08-18 00:42:26 +0200 (Wed, 18 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h

Fix a couple of bookmark bar problems:

* With the new shorter toolbar, the attached bar overlapped the omnibox drop shadow.
* The animation wasn't completely smooth and the contents would "bounce up" 1 px at the end of the "slide down" animation.

BUG=none
TEST=Attached bookmark bar doesn't overlap omnibox drop shadow
Review URL: http://codereview.chromium.org/3136015
------------------------------------------------------------------------
r56431 | pkasting@chromium.org | 2010-08-18 00:40:31 +0200 (Wed, 18 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_win.cc

Sigh... in fixing the crash message for RTL, I broke LTR, due to AdjustStringForLocaleDirection() having stupid behavior.

BUG=none
TEST=Crashing in LTR mode produces a dialog box that isn't empty
Review URL: http://codereview.chromium.org/3195002
------------------------------------------------------------------------
r56430 | rsesek@chromium.org | 2010-08-18 00:39:59 +0200 (Wed, 18 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/menu_tracked_button.h
   M /trunk/src/chrome/browser/cocoa/menu_tracked_button.mm

[Mac] Implement highlight-on-hover for the Wrench menu buttons.

R=pinkerton, shess, mark
BUG=51643
TEST=Open Wrench menu in sticky and non-sticky mode. Hover over buttons and they highlight.

Review URL: http://codereview.chromium.org/3137013
------------------------------------------------------------------------
r56429 | mpcomplete@chromium.org | 2010-08-18 00:35:34 +0200 (Wed, 18 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Mark a bunch of geolocation tests as flaky while phajdan fixes.

BUG=52518
TEST=no

Review URL: http://codereview.chromium.org/3155027
------------------------------------------------------------------------
r56426 | tim@chromium.org | 2010-08-17 23:30:23 +0200 (Tue, 17 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   D /trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc
   D /trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   D /trunk/src/chrome/browser/dom_ui/value_helper.cc
   D /trunk/src/chrome/browser/dom_ui/value_helper.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore.h
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   D /trunk/src/chrome/browser/sync/glue/session_change_processor.cc
   D /trunk/src/chrome/browser/sync/glue/session_change_processor.h
   D /trunk/src/chrome/browser/sync/glue/session_data_type_controller.cc
   D /trunk/src/chrome/browser/sync/glue/session_data_type_controller.h
   D /trunk/src/chrome/browser/sync/glue/session_model_associator.cc
   D /trunk/src/chrome/browser/sync/glue/session_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   D /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h

Revert 56423 - Added classes to enable session sync functionality.

TEST=ProfileSyncServiceSessionTest
BUG=30519

Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009

Review URL: http://codereview.chromium.org/3184004

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3127017
------------------------------------------------------------------------
r56424 | sky@chromium.org | 2010-08-17 23:18:20 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   A /trunk/src/views/mouse_watcher.cc
   A /trunk/src/views/mouse_watcher.h
   M /trunk/src/views/views.gyp

Refactors mouse watching out of TabStrip into a standalone class.

BUG=27797
TEST=none

Review URL: http://codereview.chromium.org/3140008
------------------------------------------------------------------------
r56423 | tim@chromium.org | 2010-08-17 23:10:21 +0200 (Tue, 17 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   A /trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc
   A /trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   A /trunk/src/chrome/browser/dom_ui/value_helper.cc
   A /trunk/src/chrome/browser/dom_ui/value_helper.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore.h
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   A /trunk/src/chrome/browser/sync/glue/session_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/session_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/session_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/session_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/session_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/session_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   A /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h

Added classes to enable session sync functionality.

TEST=ProfileSyncServiceSessionTest
BUG=30519

Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009

Review URL: http://codereview.chromium.org/3184004
------------------------------------------------------------------------
r56420 | phajdan.jr@chromium.org | 2010-08-17 23:01:17 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/multipart_uitest.cc

Fix MultipartResponseUITest.SingleVisit after my test server change.

TBR=brettw, eroman

BUG=49680

Review URL: http://codereview.chromium.org/3151021
------------------------------------------------------------------------
r56419 | finnur@chromium.org | 2010-08-17 22:59:29 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc

Fix a crash in HungRendererView. |tab_contents_| can be set to NULL when TabContents is destroyed, when RenderViewIsGone and when the tab becomes responsive again. If we happen to press the button just after this happens, we'll get a crash.

BUG=http://crbug.com/52293
TEST=None

Review URL: http://codereview.chromium.org/3165022
------------------------------------------------------------------------
r56413 | isherman@chromium.org | 2010-08-17 22:42:48 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc

Don't show accidental search infobar for bookmark keywords.

BUG=6854
TEST=none

Review URL: http://codereview.chromium.org/3119007
------------------------------------------------------------------------
r56411 | phajdan.jr@chromium.org | 2010-08-17 22:37:47 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc

Fix compile on ChromeOS

TBR=eroman

BUG=49680

Review URL: http://codereview.chromium.org/3175019
------------------------------------------------------------------------
r56410 | phajdan.jr@chromium.org | 2010-08-17 22:26:23 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

GTTF: Further separation of testing automation stuff from ChromeFrame

TEST=ui_tests, chrome_frame_tests
BUG=52097

Review URL: http://codereview.chromium.org/3186004
------------------------------------------------------------------------
r56407 | jhawkins@chromium.org | 2010-08-17 22:13:13 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.h
   M /trunk/src/chrome/browser/resources/options/autofill_options.html
   M /trunk/src/chrome/browser/resources/options/autofill_options.js

DOMUI: Load and display the AutoFill addresses and credit cards.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3119020
------------------------------------------------------------------------
r56406 | pkasting@chromium.org | 2010-08-17 22:07:45 +0200 (Tue, 17 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_win.cc

Simplify some code.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3187002
------------------------------------------------------------------------
r56405 | phajdan.jr@chromium.org | 2010-08-17 22:07:11 +0200 (Tue, 17 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/chrome_plugin_unittest.cc
   M /trunk/src/chrome/browser/collected_cookies_uitest.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/cross_origin_xhr_apitest.cc
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_clipboard_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_history_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_javascript_url_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/fragment_navigation_apitest.cc
   M /trunk/src/chrome/browser/extensions/isolated_world_apitest.cc
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/stubs_apitest.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/net/connection_tester_unittest.cc
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/browser/net/ftp_browsertest.cc
   M /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/repost_form_warning_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_uitest.cc
   M /trunk/src/chrome/common/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/renderer/external_extension_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/dom_automation_browsertest.cc
   M /trunk/src/chrome/test/data/file_client_redirect.html
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/infobars_uitest.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/ui/ppapi_uitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/chrome_frame/test/http_server.cc
   M /trunk/src/chrome_frame/test/http_server.h
   M /trunk/src/chrome_frame/test/run_all_unittests.cc
   M /trunk/src/chrome_frame/test/test_with_web_server.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/test/test_server.h
   A /trunk/src/net/test/test_server_posix.cc
   A /trunk/src/net/test/test_server_win.cc
   D /trunk/src/net/tools/testserver/run_testserver.cc
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/glue/mimetype_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/unittest_test_server.h
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Test server cleanup patch of death:

- reduce the number of different classes
- clean up the internal code
- modify the interface to expose less internal details
  (this will allow more flexibility with port numbers)

TEST=many
BUG=49680

Review URL: http://codereview.chromium.org/3080029
------------------------------------------------------------------------
r56403 | rsimha@chromium.org | 2010-08-17 21:50:59 +0200 (Tue, 17 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Handling empty ScopedDirLookup username in HandleDirectoryManagerEvent().

The constructor of syncable::ScopedDirLookup takes the username of the
account being synced. There are times when the username is blank,
resulting in a DCHECK being fired for the value of good() within the method
SyncManager::SyncInternal::InitialSyncEndedForAllEnabledTypes().

This patch makes sure that a ScopedDirLookup with a blank username is
never created by adding a check in the method
SyncManager::SyncInternal::HandleDirectoryManagerEvent().

BUG=51820
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3184009
------------------------------------------------------------------------
r56400 | michaeln@chromium.org | 2010-08-17 21:41:02 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Output data about media requests to the netlog too.

TEST=manual
BUG=none

Review URL: http://codereview.chromium.org/3131018
------------------------------------------------------------------------
r56399 | brettw@chromium.org | 2010-08-17 21:40:11 +0200 (Tue, 17 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/app/test_suite.h
   M /trunk/src/base/DEPS
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base_switches.cc
   M /trunk/src/base/base_switches.h
   D /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/shared_memory_unittest.cc
   M /trunk/src/base/stats_table_unittest.cc
   A /trunk/src/base/test/multiprocess_test.cc (from /trunk/src/base/test/multiprocess_test.cc:55415)
   A /trunk/src/base/test/multiprocess_test.h (from /trunk/src/base/test/multiprocess_test.h:55415)
   M /trunk/src/base/test/perf_test_suite.h
   M /trunk/src/base/test/run_all_unittests.cc
   M /trunk/src/base/test/test_suite.cc
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/process_watcher_unittest.cc
   M /trunk/src/chrome/common/sandbox_mac_diraccess_unittest.mm
   M /trunk/src/chrome/common/sandbox_mac_unittest_helper.h
   M /trunk/src/chrome/common/sandbox_mac_unittest_helper.mm
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/test/mini_installer_test/run_all_unittests.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/test_launcher/test_runner.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/courgette/encoded_program_fuzz_unittest.cc
   M /trunk/src/courgette/run_all_unittests.cc
   M /trunk/src/gfx/test_suite.h
   M /trunk/src/ipc/ipc_send_fds_test.cc
   M /trunk/src/ipc/ipc_tests.cc
   M /trunk/src/ipc/ipc_tests.h
   M /trunk/src/media/base/run_all_unittests.cc
   M /trunk/src/media/mf/test/run_all_unittests.cc
   M /trunk/src/media/omx/run_all_unittests.cc
   M /trunk/src/net/base/net_test_suite.h
   M /trunk/src/net/base/run_all_unittests.cc
   M /trunk/src/printing/run_all_unittests.cc
   M /trunk/src/remoting/run_all_unittests.cc

Re-land part of r55416, minus actually moving the test_suite.h contents to a .cc file.

Cleanup in base. This moves the implementation (and a bunch of header file
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.

Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.

Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055

------------------------------------------------------------------------
r56397 | shess@chromium.org | 2010-08-17 21:39:25 +0200 (Tue, 17 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Incrementally bring SafeBrowsingDatabaseTest into the modern age.

Use ScopedTempDir, and don't CHECK in tests.

BUG=none
TEST=waterfall.

Review URL: http://codereview.chromium.org/3127007
------------------------------------------------------------------------
r56396 | phajdan.jr@chromium.org | 2010-08-17 21:39:13 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp

Include ICU headers in a way that will also work with use_system_icu=1

TEST=none
BUG=28294

Review URL: http://codereview.chromium.org/3145014
------------------------------------------------------------------------
r56390 | erg@google.com | 2010-08-17 20:38:24 +0200 (Tue, 17 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   A /trunk/src/chrome/browser/importer/importer_messages.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   A /trunk/src/chrome/common/devtools_messages.cc
   A /trunk/src/chrome/common/gpu_messages.cc
   A /trunk/src/chrome/common/nacl_messages.cc
   M /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/plugin_messages.cc
   A /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   A /trunk/src/chrome/common/service_messages.cc
   A /trunk/src/chrome/common/utility_messages.cc
   A /trunk/src/chrome/common/webkit_param_traits.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   A /trunk/src/chrome/common/worker_messages.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/renderer_webcookiejar_impl.cc
   M /trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   A /trunk/src/chrome/test/automation/automation_messages.cc
   M /trunk/src/ipc/ipc_fuzzing_tests.cc
   A /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/ipc/ipc_message_utils.h
   A /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/ipc_send_fds_test.cc
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/ipc/sync_socket_unittest.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h

Reapplies all the IPC system work (reverts the revert r56272).

That patch wasn't what caused the regression in the page cycler.

BUG=51411,52103
TEST=still compiles

Review URL: http://codereview.chromium.org/3106018
------------------------------------------------------------------------
r56389 | mirandac@chromium.org | 2010-08-17 20:34:16 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Ensure that logos are always shown in search engine dialog when available.

BUG=50699
TEST=First three (or two in Vietnam and Iran) search engine logos always available on import in --organic Chrome (not Chromium).

Review URL: http://codereview.chromium.org/3189004
------------------------------------------------------------------------
r56385 | vandebo@chromium.org | 2010-08-17 20:00:02 +0200 (Tue, 17 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/predictor_unittest.cc
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc

Revert 56384 - Don't resolve IP literals.

For each resolution request this checks to see if this 'host' is a literal ip address.  If so, it synthesises a struct addrinfo and returns it without adding it to the cache.

BUG=39830
TEST=unit tests, new and old

Review URL: http://codereview.chromium.org/3023048

TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/3115014
------------------------------------------------------------------------
r56384 | vandebo@chromium.org | 2010-08-17 19:50:41 +0200 (Tue, 17 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/predictor_unittest.cc
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc

Don't resolve IP literals.

For each resolution request this checks to see if this 'host' is a literal ip address.  If so, it synthesises a struct addrinfo and returns it without adding it to the cache.

BUG=39830
TEST=unit tests, new and old

Review URL: http://codereview.chromium.org/3023048
------------------------------------------------------------------------
r56379 | pkasting@chromium.org | 2010-08-17 19:40:35 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Turns out this code I'd removed is still necessary for the RTL OTR avatar to not look broken.

TBR=ben
BUG=none
TEST=Run in Aero with --lang=he, hit ctrl-shift-n, Incognito image should not be broken in two
Review URL: http://codereview.chromium.org/3117016
------------------------------------------------------------------------
r56377 | pkasting@chromium.org | 2010-08-17 19:35:00 +0200 (Tue, 17 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Misc. clean up: Rewrap, simplify.  Refactored two separate files' calls of TabStrip::SetBackgroundOffset() into a single call in a different place.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107012
------------------------------------------------------------------------
r56375 | pinkerton@chromium.org | 2010-08-17 19:15:49 +0200 (Tue, 17 Aug 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/applescript/examples/advanced_tab_manipulation.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/copy_html.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/delete_bookmarks.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/execute_javascript.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/open_tabs_from_bookmark_folder.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/tab_manipulation.applescript
   M /trunk/src/chrome/browser/cocoa/applescript/scripting.sdef
   M /trunk/src/chrome/browser/cocoa/applescript/tab_applescript.h
   M /trunk/src/chrome/browser/cocoa/applescript/tab_applescript.mm
   M /trunk/src/chrome/browser/cocoa/applescript/window_applescript_test.mm

Cleaned up the SDEF. Added execute javascript command. Updated tests. Fixed a bug in tabapplescript. Added more examples.
patch from (v.a.shreyas@gmail.com)
BUG=none
TEST=run tests included in CL.
------------------------------------------------------------------------
r56374 | nshkrob@chromium.org | 2010-08-17 19:08:00 +0200 (Tue, 17 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_impl.cc

Add and rename histograms for the new DB files.

The Thumbnails file is renamed to Favicons.
The new "Top Sites" DB file is added.

TEST=about:histograms
BUG=none

Review URL: http://codereview.chromium.org/3113002
------------------------------------------------------------------------
r56370 | stevenjb@chromium.org | 2010-08-17 18:41:10 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   A /trunk/src/chrome/browser/views/frame/popup_non_client_frame_view.cc
   A /trunk/src/chrome/browser/views/frame/popup_non_client_frame_view.h
   M /trunk/src/chrome/chrome_browser.gypi

BUG=chromium-os:4448 - Hide the address bar for popups in ChromeOS (http://code.google.com/p/chromium-os/issues/detail?id=4448)

Moved PopupNonClientFrameView to its own file and moved FrameView initialization logic to BrowserFrameChromeos::Init.
TEST=See issue. Additionally, ensure that non-chromeos Chrome popup window behavior is unaffected, and that the address bar is still visible for popup windows not generated by apps (e.g popped out google chat windows), on chromeos and non-chromeos.

Review URL: http://codereview.chromium.org/3133001
------------------------------------------------------------------------
r56369 | xiyuan@chromium.org | 2010-08-17 18:39:33 +0200 (Tue, 17 Aug 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h

Status menu change per chromium-os:5517

- Apply 10% white to selected menu button;
- Remove the menu offset so that the menu is top aligned with toolbar;
- Make all status area buttons derive from StatusAreaButton;
- Move ClockMenuButton's text size logic into StatusAreaButton to share the
  logic with LanguageMenuButton;
- Strip unused space from LanguageMenuButton so that it looks good with 10%
  white highlight;
- Make LanguageMenuButton and ClockMenuButton center aligned;
- Add 1-pixel padding at top when the vertical space is odd number so that text
  looks properly aligned with the icons;

BUG=chromium-os:5517
TEST=Verify fix for chromium-os:5517.

Review URL: http://codereview.chromium.org/3141019
------------------------------------------------------------------------
r56367 | jcivelli@chromium.org | 2010-08-17 18:33:17 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Don't show the extra "Always/never translate" buttons on the "before translate" infobar when in Incognito mode.

BUG=52305
TEST=See bug.

Review URL: http://codereview.chromium.org/3164016
------------------------------------------------------------------------
r56362 | viettrungluu@chromium.org | 2010-08-17 18:24:25 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/json/json_writer_unittest.cc
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/background_contents_service_unittest.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/about_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/remoting/remoting_resources_source.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/net/net_resource_provider.cc
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/test/automation/javascript_message_utils.h
   M /trunk/src/ipc/ipc_message_unittest.cc

Remove remaining deprecated wstring methods from base/values.{cc,h}.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3109025
------------------------------------------------------------------------
r56361 | amit@chromium.org | 2010-08-17 18:16:26 +0200 (Tue, 17 Aug 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc

Fix a crash during history deletion.

This happens mainly in chrome frame where password manager
or the web data service could be invalid due to failed sqllite 
initialization. The failure is due to chrome.exe running in low
integrity mode while deleting browser history.  This a temporary
fix to avoid crash the right fix is to run chrome.exe at medium
integrity and that involves some investigation.

Now why chrome.exe runs in the low integrity mode is a long
story. Chrome Frame implements IDeleteBrowsingHistory to 
participate in history/user data deletion. IE8 tries to be 
smart and invokes IDeleteBrowsingHistory methods in by
launching a separate process, rundll32.exe. However, when
npchrome_frame.dll's implementation is invoked the container 
rundll32.exe is in low integrity. IE's elevation policy does
not work for us to elevate chrome_launcher.exe to medium in
this case (since this is not IE). so we end up launching 
chrome.exe in low integrity.


BUG=51949
TEST=load gcf:about:version in Chrome Frame with IE8 on Win7
     and delete browsing history.


Review URL: http://codereview.chromium.org/3133019
------------------------------------------------------------------------
r56356 | stuartmorgan@chromium.org | 2010-08-17 17:55:57 +0200 (Tue, 17 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.css

DOMUI prefs: CSS changes for search engine manager

Part of http://codereview.chromium.org/3191002 missed during checkin.

BUG=49091
TEST=None

Review URL: http://codereview.chromium.org/3149018
------------------------------------------------------------------------
r56353 | joth@chromium.org | 2010-08-17 17:35:44 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Broaden flakiness filter for ExtensionApiTest.Tabs as it now appears to fail on NDEBUG builds too.

TBR: zelidrag

BUG=48920
TEST=none

------------------------------------------------------------------------
r56352 | evan@chromium.org | 2010-08-17 17:32:34 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.cc

Rmeove another wstring from infobar code.

Spotted in previous review.

BUG=23581

Review URL: http://codereview.chromium.org/3152019
------------------------------------------------------------------------
r56349 | mnissler@chromium.org | 2010-08-17 17:04:42 +0200 (Tue, 17 Aug 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/file_path_watcher.h
   D /trunk/src/chrome/browser/file_path_watcher_inotify.cc
   D /trunk/src/chrome/browser/file_path_watcher_mac.cc
   D /trunk/src/chrome/browser/file_path_watcher_stub.cc
   D /trunk/src/chrome/browser/file_path_watcher_unittest.cc
   D /trunk/src/chrome/browser/file_path_watcher_win.cc
   A /trunk/src/chrome/browser/file_watcher.h (from /trunk/src/chrome/browser/file_watcher.h:56340)
   A /trunk/src/chrome/browser/file_watcher_inotify.cc (from /trunk/src/chrome/browser/file_watcher_inotify.cc:56340)
   A /trunk/src/chrome/browser/file_watcher_mac.cc (from /trunk/src/chrome/browser/file_watcher_mac.cc:56340)
   A /trunk/src/chrome/browser/file_watcher_stub.cc (from /trunk/src/chrome/browser/file_watcher_stub.cc:56340)
   A /trunk/src/chrome/browser/file_watcher_unittest.cc (from /trunk/src/chrome/browser/file_watcher_unittest.cc:56340)
   A /trunk/src/chrome/browser/file_watcher_win.cc (from /trunk/src/chrome/browser/file_watcher_win.cc:56340)
   M /trunk/src/chrome/browser/user_style_sheet_watcher.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 56341 - Add support for watching directories to FileWatcher.

BUG=none
TEST=Unit tests in file_watcher_unittest.cc.

Review URL: http://codereview.chromium.org/3149004

TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3165027
------------------------------------------------------------------------
r56348 | pfeldman@chromium.org | 2010-08-17 16:58:38 +0200 (Tue, 17 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h

DevTools: Support runtime property name/value pairs instead of feature names as navigation state.

Review URL: http://codereview.chromium.org/3110018
------------------------------------------------------------------------
r56347 | yurys@chromium.org | 2010-08-17 16:57:32 +0200 (Tue, 17 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   D /trunk/src/chrome/test/data/devtools/debugger_step.html
   D /trunk/src/chrome/test/data/devtools/debugger_step.js

DevTools: remove debugger step tests that have been converted into WebKit layout tests

BUG=45080,46299

Review URL: http://codereview.chromium.org/3116015
------------------------------------------------------------------------
r56346 | stuartmorgan@chromium.org | 2010-08-17 16:55:34 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.h
   M /trunk/src/chrome/browser/resources/options/options_page.css
   A /trunk/src/chrome/browser/resources/options/search_engine_manager.css
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.html
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js

DOMUI prefs: Implement the non-editing parts of search engine management.

BUG=49091
TEST=Open DOMUI prefs, and click the "Manage..." button for search engines. Search engines should be listed, the default should be changeable, and entries should be removable.

Review URL: http://codereview.chromium.org/3191002
------------------------------------------------------------------------
r56343 | tfarina@chromium.org | 2010-08-17 16:35:02 +0200 (Tue, 17 Aug 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/views/content_setting_bubble_contents.cc (from /trunk/src/chrome/browser/views/content_setting_bubble_views.cc:56342)
   A /trunk/src/chrome/browser/views/content_setting_bubble_contents.h (from /trunk/src/chrome/browser/views/content_setting_bubble_views.h:56342)
   D /trunk/src/chrome/browser/views/content_setting_bubble_views.cc
   D /trunk/src/chrome/browser/views/content_setting_bubble_views.h
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

views: Rename content_setting_bubble_views.[cc/h] to content_setting_bubble_contents.[cc/h]

(Note: that was a TODO for bulach).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3177016
------------------------------------------------------------------------
r56341 | mnissler@chromium.org | 2010-08-17 16:26:03 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/file_path_watcher.h
   A /trunk/src/chrome/browser/file_path_watcher_inotify.cc
   A /trunk/src/chrome/browser/file_path_watcher_mac.cc
   A /trunk/src/chrome/browser/file_path_watcher_stub.cc
   A /trunk/src/chrome/browser/file_path_watcher_unittest.cc
   A /trunk/src/chrome/browser/file_path_watcher_win.cc
   D /trunk/src/chrome/browser/file_watcher.h
   D /trunk/src/chrome/browser/file_watcher_inotify.cc
   D /trunk/src/chrome/browser/file_watcher_mac.cc
   D /trunk/src/chrome/browser/file_watcher_stub.cc
   D /trunk/src/chrome/browser/file_watcher_unittest.cc
   D /trunk/src/chrome/browser/file_watcher_win.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add support for watching directories to FileWatcher.

BUG=none
TEST=Unit tests in file_watcher_unittest.cc.

Review URL: http://codereview.chromium.org/3149004
------------------------------------------------------------------------
r56340 | andybons@chromium.org | 2010-08-17 16:04:40 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_infobar_mac.css

[Mac] Tweak some CSS for extension infobars to have the correct text size and margin.

BUG=51124
TEST=none

Review URL: http://codereview.chromium.org/3184008
------------------------------------------------------------------------
r56339 | dilmah@chromium.org | 2010-08-17 16:04:24 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Swap EULA and update screens in OOBE process.

BUG=http://crosbug.com/5376
TEST=Manual

Review URL: http://codereview.chromium.org/3114011/show

------------------------------------------------------------------------
r56334 | allanwoj@chromium.org | 2010-08-17 14:21:22 +0200 (Tue, 17 Aug 2010) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/win7_location_api_unittest_win.cc
   A /trunk/src/chrome/browser/geolocation/win7_location_api_win.cc
   A /trunk/src/chrome/browser/geolocation/win7_location_api_win.h
   A /trunk/src/chrome/browser/geolocation/win7_location_provider_unittest_win.cc
   A /trunk/src/chrome/browser/geolocation/win7_location_provider_win.cc
   A /trunk/src/chrome/browser/geolocation/win7_location_provider_win.h

TBR: I didn't upload the six files that I added last time round see here http://src.chromium.org/viewvc/chrome?view=rev&revision=56332
BUG=45535
------------------------------------------------------------------------
r56333 | satish@chromium.org | 2010-08-17 13:40:22 +0200 (Tue, 17 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.h
   M /trunk/src/chrome/browser/speech/speech_recognizer.cc
   M /trunk/src/chrome/browser/speech/speech_recognizer.h
   M /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/speech_input_dispatcher.cc
   M /trunk/src/chrome/renderer/speech_input_dispatcher.h

Support for multiple speech enabled elements in same page.
This is the chromium side of https://bugs.webkit.org/show_bug.cgi?id=43922.

For all speech input requests WebKit now sends a 'requestId' which identifies the input element within the page. This requestId is returned back to WebKit in all the speech input callbacks/events. Within chromium, the pair (render view id, request id) uniquely identifies a caller and we introduce the SpeechInputCallerId to hold this data. All code which was previously using render view id now uses this caller id.

Once this is working fully on both ends I'll add relevant browser tests.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/3130018
------------------------------------------------------------------------
r56332 | allanwoj@chromium.org | 2010-08-17 13:38:40 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Location provider using Windows 7 Location API
Implementation of a location provider that uses the Windows 7 Location API. Currently uses polling to get the users location, I will update this to use signals provided by the API in a future patch.

BUG=45535
TEST=Two test files included.

Review URL: http://codereview.chromium.org/3015053
------------------------------------------------------------------------
r56329 | bulach@chromium.org | 2010-08-17 13:00:28 +0200 (Tue, 17 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   M /trunk/src/chrome/test/data/indexeddb/common.js
   M /trunk/src/chrome/test/data/indexeddb/cursor_test.js
   A /trunk/src/chrome/test/data/indexeddb/index_test.html
   A /trunk/src/chrome/test/data/indexeddb/index_test.js

Adds tests for IndexedDB's index plumbing.
TEST=IndexedDBBrowserTest, IndexTest

Review URL: http://codereview.chromium.org/3148009
------------------------------------------------------------------------
r56328 | bauerb@chromium.org | 2010-08-17 12:42:24 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.h
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver_unittest.mm

Change WindowSizeAutoSaver to store window size only when the window has resize controls.

BUG=51778
TEST=Automatically saved windows are correctly restored (see bug), unit test: WindowSizeAutosaverTest.*

Review URL: http://codereview.chromium.org/3115005
------------------------------------------------------------------------
r56327 | allanwoj@chromium.org | 2010-08-17 12:34:40 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc

Fixed crash on navigation with queued geolocation permission requests
Added a check to see if tab_contents is NULL before adding the next infobar. If it is NULL the pending request will be canceled and it will continue to search for more pending requests.
BUG=51787
TEST=Find a site with two geolocation permission requests (maybe iGoogle?) leave two pending permission requests and navigate to another site, Chrome should no longer crash.

Review URL: http://codereview.chromium.org/3112006
------------------------------------------------------------------------
r56321 | satorux@chromium.org | 2010-08-17 11:41:25 +0200 (Tue, 17 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Fix a bug where we were incorrectly disabling input methods used in other active languages.

When removing a language, we disable input methods associated with the language.
However, we should not disable input methods if these are used in other active
languages.

BUG=chromium-os:5798
TEST=manually

Review URL: http://codereview.chromium.org/3162014
------------------------------------------------------------------------
r56319 | yurys@chromium.org | 2010-08-17 10:29:12 +0200 (Tue, 17 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   D /trunk/src/chrome/test/data/devtools/debugger_intrinsic_properties.html
   D /trunk/src/chrome/test/data/devtools/eval_test_page.html

DevTools: convert console tests into WebKit layout tests

Review URL: http://codereview.chromium.org/3130022
------------------------------------------------------------------------
r56315 | jochen@chromium.org | 2010-08-17 08:30:10 +0200 (Tue, 17 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc

[Gtk] Display the current content setting applying to a domain along with the domain.

This patch only affectes the gtk ui. Here is what it looks like: http://imgur.com/g6Gox

If third party cookies are blocked, a warning is shown. Next to each domain, the content setting is displayed that applies (or nothing if the default applies). When the user selects some domains and presses an button, the labels are updated accordingly.

BUG=49826
TEST=unit_tests

Review URL: http://codereview.chromium.org/3096001
------------------------------------------------------------------------
r56314 | satorux@chromium.org | 2010-08-17 08:04:40 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Fix an incorrect comment in chromeos_language_options.js

TEST=manually
BUG=none

Review URL: http://codereview.chromium.org/3146020
------------------------------------------------------------------------
r56313 | yutak@chromium.org | 2010-08-17 07:55:16 +0200 (Tue, 17 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/renderer/render_view.cc

- Registered service types to make Services menu available
- implement NSServiesRequests protocol on BrowserWindowCotroller to provide selection text to the services framework.
See http://developer.apple.com/mac/library/documentation/cocoa/conceptual/SysServices/Articles/using.html for services implementation.

Patch contributed by Hajime Morita <morrita@google.com>.
Original review URL: http://codereview.chromium.org/2883062

BUG=20868
TEST=manual

Review URL: http://codereview.chromium.org/3174012
------------------------------------------------------------------------
r56306 | viettrungluu@chromium.org | 2010-08-17 06:18:13 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc

Fix build breakage from r56302.

BUG=none
TEST=builds
TBR=viettrungluu@chromium.org,brettw@chromium.org

Review URL: http://codereview.chromium.org/3156019
------------------------------------------------------------------------
r56302 | viettrungluu@chromium.org | 2010-08-17 06:00:57 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/chromeos/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/chromeos/external_protocol_dialog.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h

Remove deprecated wstring DictionaryValue Get{Boolean,Integer,Real,Binary,Dictionary,List}().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3187004
------------------------------------------------------------------------
r56300 | satorux@chromium.org | 2010-08-17 05:52:29 +0200 (Tue, 17 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Fix "Languages and Input" options.

Since r56268, "value" of a preference change event is a dictionary of
"value" and "managed", hence the client code has to be changed from
e.value to e.value.value.

TEST=manually
BUG=chromium-os:5789

Review URL: http://codereview.chromium.org/3193001
------------------------------------------------------------------------
r56299 | brettw@chromium.org | 2010-08-17 05:45:37 +0200 (Tue, 17 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   A /trunk/src/base/stringprintf.cc
   A /trunk/src/base/stringprintf.h
   A /trunk/src/base/stringprintf_unittest.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Move StringPrintf into its own file and use the base namespace. Currently this has using
directives for the functions so I don't have to change all files to use the namespace.

No code changes to logic.

TEST=it compiles + the included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3181016
------------------------------------------------------------------------
r56290 | akalin@chromium.org | 2010-08-17 03:29:01 +0200 (Tue, 17 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   M /trunk/src/chrome/browser/sync/notifier/registration_manager.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc

Made server_notifier_thread listen to UNKNOWN data type.

This is a temporary workaround so that server-issued notifications work
for new sync data types.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/3114012
------------------------------------------------------------------------
r56278 | hclam@chromium.org | 2010-08-17 02:33:46 +0200 (Tue, 17 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   M /trunk/src/chrome/browser/remoting/remoting_setup_flow.h
   M /trunk/src/chrome/browser/service/service_process_control.cc
   M /trunk/src/chrome/browser/service/service_process_control.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/net/gaia/gaia_constants.cc
   M /trunk/src/chrome/common/net/gaia/gaia_constants.h
   M /trunk/src/chrome/common/service_messages_internal.h
   A /trunk/src/chrome/service/remoting
   A /trunk/src/chrome/service/remoting/remoting_directory_service.cc
   A /trunk/src/chrome/service/remoting/remoting_directory_service.h
   M /trunk/src/chrome/service/service_ipc_server.cc
   M /trunk/src/chrome/service/service_ipc_server.h
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/chrome/service/service_process.h

Gaia authentication for access remoting directory and talk

We are now able to access remoting directory token and talk token through
the chromoting setup dialog.

These information are sent to the service process for enabling the chromoting
host and perform the host registration.

All the plumbing for starting the service process, enabling the chromoting
host through through IPC commands are in place but host registration is
stubbed out and will be completed in next patch.

Review URL: http://codereview.chromium.org/3176014
------------------------------------------------------------------------
r56277 | kbr@google.com | 2010-08-17 02:29:26 +0200 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Cleanups to well-behaved accelerated plugin CL requested by
stuartmorgan in http://codereview.chromium.org/3010054 .

BUG=51748
TEST=visited YouTube and ensured video shows up; 3D CSS demos; WebGL demos

Review URL: http://codereview.chromium.org/3185004
------------------------------------------------------------------------
r56276 | evan@chromium.org | 2010-08-17 02:29:14 +0200 (Tue, 17 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_response.cc
   M /trunk/src/chrome/default_plugin/DEPS
   M /trunk/src/chrome/default_plugin/plugin_database_handler.cc
   D /trunk/src/third_party/libxml/AUTHORS
   D /trunk/src/third_party/libxml/COPYING
   D /trunk/src/third_party/libxml/ChangeLog
   D /trunk/src/third_party/libxml/Copyright
   D /trunk/src/third_party/libxml/DOCBparser.c
   D /trunk/src/third_party/libxml/HTMLparser.c
   D /trunk/src/third_party/libxml/HTMLtree.c
   D /trunk/src/third_party/libxml/INSTALL
   D /trunk/src/third_party/libxml/NEWS
   D /trunk/src/third_party/libxml/README
   M /trunk/src/third_party/libxml/README.chromium
   D /trunk/src/third_party/libxml/README.tests
   D /trunk/src/third_party/libxml/SAX.c
   D /trunk/src/third_party/libxml/SAX2.c
   D /trunk/src/third_party/libxml/TODO
   D /trunk/src/third_party/libxml/TODO_SCHEMAS
   D /trunk/src/third_party/libxml/acconfig.h
   D /trunk/src/third_party/libxml/acinclude.m4
   D /trunk/src/third_party/libxml/aclocal.m4
   D /trunk/src/third_party/libxml/c14n.c
   D /trunk/src/third_party/libxml/catalog.c
   D /trunk/src/third_party/libxml/check-relaxng-test-suite.py
   D /trunk/src/third_party/libxml/check-relaxng-test-suite2.py
   D /trunk/src/third_party/libxml/check-xinclude-test-suite.py
   D /trunk/src/third_party/libxml/check-xml-test-suite.py
   D /trunk/src/third_party/libxml/check-xsddata-test-suite.py
   D /trunk/src/third_party/libxml/chvalid.c
   D /trunk/src/third_party/libxml/config.guess
   D /trunk/src/third_party/libxml/config.h.in
   D /trunk/src/third_party/libxml/config.sub
   D /trunk/src/third_party/libxml/configure
   D /trunk/src/third_party/libxml/configure.in
   D /trunk/src/third_party/libxml/dbgen.pl
   D /trunk/src/third_party/libxml/dbgenattr.pl
   D /trunk/src/third_party/libxml/debugXML.c
   D /trunk/src/third_party/libxml/depcomp
   D /trunk/src/third_party/libxml/dict.c
   D /trunk/src/third_party/libxml/elfgcchack.h
   D /trunk/src/third_party/libxml/encoding.c
   D /trunk/src/third_party/libxml/entities.c
   D /trunk/src/third_party/libxml/error.c
   D /trunk/src/third_party/libxml/genUnicode.py
   D /trunk/src/third_party/libxml/gentest.py
   D /trunk/src/third_party/libxml/globals.c
   D /trunk/src/third_party/libxml/hash.c
   D /trunk/src/third_party/libxml/include/libxml/DOCBparser.h
   D /trunk/src/third_party/libxml/include/libxml/HTMLparser.h
   D /trunk/src/third_party/libxml/include/libxml/HTMLtree.h
   D /trunk/src/third_party/libxml/include/libxml/SAX.h
   D /trunk/src/third_party/libxml/include/libxml/SAX2.h
   D /trunk/src/third_party/libxml/include/libxml/c14n.h
   D /trunk/src/third_party/libxml/include/libxml/catalog.h
   D /trunk/src/third_party/libxml/include/libxml/chvalid.h
   D /trunk/src/third_party/libxml/include/libxml/debugXML.h
   D /trunk/src/third_party/libxml/include/libxml/dict.h
   D /trunk/src/third_party/libxml/include/libxml/encoding.h
   D /trunk/src/third_party/libxml/include/libxml/entities.h
   D /trunk/src/third_party/libxml/include/libxml/globals.h
   D /trunk/src/third_party/libxml/include/libxml/hash.h
   D /trunk/src/third_party/libxml/include/libxml/list.h
   D /trunk/src/third_party/libxml/include/libxml/nanoftp.h
   D /trunk/src/third_party/libxml/include/libxml/nanohttp.h
   D /trunk/src/third_party/libxml/include/libxml/parser.h
   D /trunk/src/third_party/libxml/include/libxml/parserInternals.h
   D /trunk/src/third_party/libxml/include/libxml/pattern.h
   D /trunk/src/third_party/libxml/include/libxml/relaxng.h
   D /trunk/src/third_party/libxml/include/libxml/schemasInternals.h
   D /trunk/src/third_party/libxml/include/libxml/schematron.h
   D /trunk/src/third_party/libxml/include/libxml/threads.h
   D /trunk/src/third_party/libxml/include/libxml/tree.h
   D /trunk/src/third_party/libxml/include/libxml/uri.h
   D /trunk/src/third_party/libxml/include/libxml/valid.h
   D /trunk/src/third_party/libxml/include/libxml/xinclude.h
   D /trunk/src/third_party/libxml/include/libxml/xlink.h
   D /trunk/src/third_party/libxml/include/libxml/xmlIO.h
   D /trunk/src/third_party/libxml/include/libxml/xmlautomata.h
   D /trunk/src/third_party/libxml/include/libxml/xmlerror.h
   D /trunk/src/third_party/libxml/include/libxml/xmlexports.h
   D /trunk/src/third_party/libxml/include/libxml/xmlmemory.h
   D /trunk/src/third_party/libxml/include/libxml/xmlmodule.h
   D /trunk/src/third_party/libxml/include/libxml/xmlreader.h
   D /trunk/src/third_party/libxml/include/libxml/xmlregexp.h
   D /trunk/src/third_party/libxml/include/libxml/xmlsave.h
   D /trunk/src/third_party/libxml/include/libxml/xmlschemas.h
   D /trunk/src/third_party/libxml/include/libxml/xmlschemastypes.h
   D /trunk/src/third_party/libxml/include/libxml/xmlstring.h
   D /trunk/src/third_party/libxml/include/libxml/xmlunicode.h
   D /trunk/src/third_party/libxml/include/libxml/xmlversion.h.in
   D /trunk/src/third_party/libxml/include/libxml/xmlwriter.h
   D /trunk/src/third_party/libxml/include/libxml/xpath.h
   D /trunk/src/third_party/libxml/include/libxml/xpathInternals.h
   D /trunk/src/third_party/libxml/include/libxml/xpointer.h
   D /trunk/src/third_party/libxml/include/win32config.h
   D /trunk/src/third_party/libxml/include/wsockcompat.h
   D /trunk/src/third_party/libxml/install-sh
   D /trunk/src/third_party/libxml/legacy.c
   D /trunk/src/third_party/libxml/libxml-2.0-uninstalled.pc.in
   D /trunk/src/third_party/libxml/libxml-2.0.pc.in
   M /trunk/src/third_party/libxml/libxml.gyp
   D /trunk/src/third_party/libxml/libxml.h
   D /trunk/src/third_party/libxml/libxml.m4
   D /trunk/src/third_party/libxml/libxml.spec.in
   D /trunk/src/third_party/libxml/libxml2.spec
   D /trunk/src/third_party/libxml/list.c
   D /trunk/src/third_party/libxml/ltmain.sh
   D /trunk/src/third_party/libxml/missing
   D /trunk/src/third_party/libxml/mkinstalldirs
   D /trunk/src/third_party/libxml/nanoftp.c
   D /trunk/src/third_party/libxml/nanohttp.c
   D /trunk/src/third_party/libxml/parser.c
   D /trunk/src/third_party/libxml/parserInternals.c
   D /trunk/src/third_party/libxml/pattern.c
   D /trunk/src/third_party/libxml/regressions.py
   D /trunk/src/third_party/libxml/regressions.xml
   D /trunk/src/third_party/libxml/relaxng.c
   D /trunk/src/third_party/libxml/runsuite.c
   D /trunk/src/third_party/libxml/runtest.c
   D /trunk/src/third_party/libxml/schematron.c
   A /trunk/src/third_party/libxml/src/AUTHORS (from /trunk/src/third_party/libxml/AUTHORS:56269)
   A /trunk/src/third_party/libxml/src/COPYING (from /trunk/src/third_party/libxml/COPYING:56269)
   A /trunk/src/third_party/libxml/src/ChangeLog (from /trunk/src/third_party/libxml/ChangeLog:56269)
   A /trunk/src/third_party/libxml/src/Copyright (from /trunk/src/third_party/libxml/Copyright:56269)
   A /trunk/src/third_party/libxml/src/DOCBparser.c (from /trunk/src/third_party/libxml/DOCBparser.c:56269)
   A /trunk/src/third_party/libxml/src/HTMLparser.c (from /trunk/src/third_party/libxml/HTMLparser.c:56269)
   A /trunk/src/third_party/libxml/src/HTMLtree.c (from /trunk/src/third_party/libxml/HTMLtree.c:56269)
   A /trunk/src/third_party/libxml/src/INSTALL (from /trunk/src/third_party/libxml/INSTALL:56269)
   A /trunk/src/third_party/libxml/src/NEWS (from /trunk/src/third_party/libxml/NEWS:56269)
   A /trunk/src/third_party/libxml/src/README (from /trunk/src/third_party/libxml/README:56269)
   A /trunk/src/third_party/libxml/src/README.tests (from /trunk/src/third_party/libxml/README.tests:56269)
   A /trunk/src/third_party/libxml/src/SAX.c (from /trunk/src/third_party/libxml/SAX.c:56269)
   A /trunk/src/third_party/libxml/src/SAX2.c (from /trunk/src/third_party/libxml/SAX2.c:56269)
   A /trunk/src/third_party/libxml/src/TODO (from /trunk/src/third_party/libxml/TODO:56269)
   A /trunk/src/third_party/libxml/src/TODO_SCHEMAS (from /trunk/src/third_party/libxml/TODO_SCHEMAS:56269)
   A /trunk/src/third_party/libxml/src/acconfig.h (from /trunk/src/third_party/libxml/acconfig.h:56269)
   A /trunk/src/third_party/libxml/src/acinclude.m4 (from /trunk/src/third_party/libxml/acinclude.m4:56269)
   A /trunk/src/third_party/libxml/src/aclocal.m4 (from /trunk/src/third_party/libxml/aclocal.m4:56269)
   A /trunk/src/third_party/libxml/src/c14n.c (from /trunk/src/third_party/libxml/c14n.c:56269)
   A /trunk/src/third_party/libxml/src/catalog.c (from /trunk/src/third_party/libxml/catalog.c:56269)
   A /trunk/src/third_party/libxml/src/check-relaxng-test-suite.py (from /trunk/src/third_party/libxml/check-relaxng-test-suite.py:56269)
   A /trunk/src/third_party/libxml/src/check-relaxng-test-suite2.py (from /trunk/src/third_party/libxml/check-relaxng-test-suite2.py:56269)
   A /trunk/src/third_party/libxml/src/check-xinclude-test-suite.py (from /trunk/src/third_party/libxml/check-xinclude-test-suite.py:56269)
   A /trunk/src/third_party/libxml/src/check-xml-test-suite.py (from /trunk/src/third_party/libxml/check-xml-test-suite.py:56269)
   A /trunk/src/third_party/libxml/src/check-xsddata-test-suite.py (from /trunk/src/third_party/libxml/check-xsddata-test-suite.py:56269)
   A /trunk/src/third_party/libxml/src/chvalid.c (from /trunk/src/third_party/libxml/chvalid.c:56269)
   A /trunk/src/third_party/libxml/src/config.guess (from /trunk/src/third_party/libxml/config.guess:56269)
   A /trunk/src/third_party/libxml/src/config.h.in (from /trunk/src/third_party/libxml/config.h.in:56269)
   A /trunk/src/third_party/libxml/src/config.sub (from /trunk/src/third_party/libxml/config.sub:56269)
   A /trunk/src/third_party/libxml/src/configure (from /trunk/src/third_party/libxml/configure:56269)
   A /trunk/src/third_party/libxml/src/configure.in (from /trunk/src/third_party/libxml/configure.in:56269)
   A /trunk/src/third_party/libxml/src/dbgen.pl (from /trunk/src/third_party/libxml/dbgen.pl:56269)
   A /trunk/src/third_party/libxml/src/dbgenattr.pl (from /trunk/src/third_party/libxml/dbgenattr.pl:56269)
   A /trunk/src/third_party/libxml/src/debugXML.c (from /trunk/src/third_party/libxml/debugXML.c:56269)
   A /trunk/src/third_party/libxml/src/depcomp (from /trunk/src/third_party/libxml/depcomp:56269)
   A /trunk/src/third_party/libxml/src/dict.c (from /trunk/src/third_party/libxml/dict.c:56269)
   A /trunk/src/third_party/libxml/src/elfgcchack.h (from /trunk/src/third_party/libxml/elfgcchack.h:56269)
   A /trunk/src/third_party/libxml/src/encoding.c (from /trunk/src/third_party/libxml/encoding.c:56269)
   A /trunk/src/third_party/libxml/src/entities.c (from /trunk/src/third_party/libxml/entities.c:56269)
   A /trunk/src/third_party/libxml/src/error.c (from /trunk/src/third_party/libxml/error.c:56269)
   A /trunk/src/third_party/libxml/src/genUnicode.py (from /trunk/src/third_party/libxml/genUnicode.py:56269)
   A /trunk/src/third_party/libxml/src/gentest.py (from /trunk/src/third_party/libxml/gentest.py:56269)
   A /trunk/src/third_party/libxml/src/globals.c (from /trunk/src/third_party/libxml/globals.c:56269)
   A /trunk/src/third_party/libxml/src/hash.c (from /trunk/src/third_party/libxml/hash.c:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/DOCBparser.h (from /trunk/src/third_party/libxml/include/libxml/DOCBparser.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/HTMLparser.h (from /trunk/src/third_party/libxml/include/libxml/HTMLparser.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/HTMLtree.h (from /trunk/src/third_party/libxml/include/libxml/HTMLtree.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/SAX.h (from /trunk/src/third_party/libxml/include/libxml/SAX.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/SAX2.h (from /trunk/src/third_party/libxml/include/libxml/SAX2.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/c14n.h (from /trunk/src/third_party/libxml/include/libxml/c14n.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/catalog.h (from /trunk/src/third_party/libxml/include/libxml/catalog.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/chvalid.h (from /trunk/src/third_party/libxml/include/libxml/chvalid.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/debugXML.h (from /trunk/src/third_party/libxml/include/libxml/debugXML.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/dict.h (from /trunk/src/third_party/libxml/include/libxml/dict.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/encoding.h (from /trunk/src/third_party/libxml/include/libxml/encoding.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/entities.h (from /trunk/src/third_party/libxml/include/libxml/entities.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/globals.h (from /trunk/src/third_party/libxml/include/libxml/globals.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/hash.h (from /trunk/src/third_party/libxml/include/libxml/hash.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/list.h (from /trunk/src/third_party/libxml/include/libxml/list.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/nanoftp.h (from /trunk/src/third_party/libxml/include/libxml/nanoftp.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/nanohttp.h (from /trunk/src/third_party/libxml/include/libxml/nanohttp.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/parser.h (from /trunk/src/third_party/libxml/include/libxml/parser.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/parserInternals.h (from /trunk/src/third_party/libxml/include/libxml/parserInternals.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/pattern.h (from /trunk/src/third_party/libxml/include/libxml/pattern.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/relaxng.h (from /trunk/src/third_party/libxml/include/libxml/relaxng.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/schemasInternals.h (from /trunk/src/third_party/libxml/include/libxml/schemasInternals.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/schematron.h (from /trunk/src/third_party/libxml/include/libxml/schematron.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/threads.h (from /trunk/src/third_party/libxml/include/libxml/threads.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/tree.h (from /trunk/src/third_party/libxml/include/libxml/tree.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/uri.h (from /trunk/src/third_party/libxml/include/libxml/uri.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/valid.h (from /trunk/src/third_party/libxml/include/libxml/valid.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xinclude.h (from /trunk/src/third_party/libxml/include/libxml/xinclude.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xlink.h (from /trunk/src/third_party/libxml/include/libxml/xlink.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlIO.h (from /trunk/src/third_party/libxml/include/libxml/xmlIO.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlautomata.h (from /trunk/src/third_party/libxml/include/libxml/xmlautomata.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlerror.h (from /trunk/src/third_party/libxml/include/libxml/xmlerror.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlexports.h (from /trunk/src/third_party/libxml/include/libxml/xmlexports.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlmemory.h (from /trunk/src/third_party/libxml/include/libxml/xmlmemory.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlmodule.h (from /trunk/src/third_party/libxml/include/libxml/xmlmodule.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlreader.h (from /trunk/src/third_party/libxml/include/libxml/xmlreader.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlregexp.h (from /trunk/src/third_party/libxml/include/libxml/xmlregexp.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlsave.h (from /trunk/src/third_party/libxml/include/libxml/xmlsave.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlschemas.h (from /trunk/src/third_party/libxml/include/libxml/xmlschemas.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlschemastypes.h (from /trunk/src/third_party/libxml/include/libxml/xmlschemastypes.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlstring.h (from /trunk/src/third_party/libxml/include/libxml/xmlstring.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlunicode.h (from /trunk/src/third_party/libxml/include/libxml/xmlunicode.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlversion.h.in (from /trunk/src/third_party/libxml/include/libxml/xmlversion.h.in:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xmlwriter.h (from /trunk/src/third_party/libxml/include/libxml/xmlwriter.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xpath.h (from /trunk/src/third_party/libxml/include/libxml/xpath.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xpathInternals.h (from /trunk/src/third_party/libxml/include/libxml/xpathInternals.h:56269)
   A /trunk/src/third_party/libxml/src/include/libxml/xpointer.h (from /trunk/src/third_party/libxml/include/libxml/xpointer.h:56269)
   A /trunk/src/third_party/libxml/src/include/win32config.h (from /trunk/src/third_party/libxml/include/win32config.h:56269)
   A /trunk/src/third_party/libxml/src/include/wsockcompat.h (from /trunk/src/third_party/libxml/include/wsockcompat.h:56269)
   A /trunk/src/third_party/libxml/src/install-sh (from /trunk/src/third_party/libxml/install-sh:56269)
   A /trunk/src/third_party/libxml/src/legacy.c (from /trunk/src/third_party/libxml/legacy.c:56269)
   A /trunk/src/third_party/libxml/src/libxml-2.0-uninstalled.pc.in (from /trunk/src/third_party/libxml/libxml-2.0-uninstalled.pc.in:56269)
   A /trunk/src/third_party/libxml/src/libxml-2.0.pc.in (from /trunk/src/third_party/libxml/libxml-2.0.pc.in:56269)
   A /trunk/src/third_party/libxml/src/libxml.h (from /trunk/src/third_party/libxml/libxml.h:56269)
   A /trunk/src/third_party/libxml/src/libxml.m4 (from /trunk/src/third_party/libxml/libxml.m4:56269)
   A /trunk/src/third_party/libxml/src/libxml.spec.in (from /trunk/src/third_party/libxml/libxml.spec.in:56269)
   A /trunk/src/third_party/libxml/src/libxml2.spec (from /trunk/src/third_party/libxml/libxml2.spec:56269)
   A /trunk/src/third_party/libxml/src/list.c (from /trunk/src/third_party/libxml/list.c:56269)
   A /trunk/src/third_party/libxml/src/ltmain.sh (from /trunk/src/third_party/libxml/ltmain.sh:56269)
   A /trunk/src/third_party/libxml/src/missing (from /trunk/src/third_party/libxml/missing:56269)
   A /trunk/src/third_party/libxml/src/mkinstalldirs (from /trunk/src/third_party/libxml/mkinstalldirs:56269)
   A /trunk/src/third_party/libxml/src/nanoftp.c (from /trunk/src/third_party/libxml/nanoftp.c:56269)
   A /trunk/src/third_party/libxml/src/nanohttp.c (from /trunk/src/third_party/libxml/nanohttp.c:56269)
   A /trunk/src/third_party/libxml/src/parser.c (from /trunk/src/third_party/libxml/parser.c:56269)
   A /trunk/src/third_party/libxml/src/parserInternals.c (from /trunk/src/third_party/libxml/parserInternals.c:56269)
   A /trunk/src/third_party/libxml/src/pattern.c (from /trunk/src/third_party/libxml/pattern.c:56269)
   A /trunk/src/third_party/libxml/src/regressions.py (from /trunk/src/third_party/libxml/regressions.py:56269)
   A /trunk/src/third_party/libxml/src/regressions.xml (from /trunk/src/third_party/libxml/regressions.xml:56269)
   A /trunk/src/third_party/libxml/src/relaxng.c (from /trunk/src/third_party/libxml/relaxng.c:56269)
   A /trunk/src/third_party/libxml/src/runsuite.c (from /trunk/src/third_party/libxml/runsuite.c:56269)
   A /trunk/src/third_party/libxml/src/runtest.c (from /trunk/src/third_party/libxml/runtest.c:56269)
   A /trunk/src/third_party/libxml/src/schematron.c (from /trunk/src/third_party/libxml/schematron.c:56269)
   A /trunk/src/third_party/libxml/src/testAutomata.c (from /trunk/src/third_party/libxml/testAutomata.c:56269)
   A /trunk/src/third_party/libxml/src/testC14N.c (from /trunk/src/third_party/libxml/testC14N.c:56269)
   A /trunk/src/third_party/libxml/src/testHTML.c (from /trunk/src/third_party/libxml/testHTML.c:56269)
   A /trunk/src/third_party/libxml/src/testModule.c (from /trunk/src/third_party/libxml/testModule.c:56269)
   A /trunk/src/third_party/libxml/src/testReader.c (from /trunk/src/third_party/libxml/testReader.c:56269)
   A /trunk/src/third_party/libxml/src/testRegexp.c (from /trunk/src/third_party/libxml/testRegexp.c:56269)
   A /trunk/src/third_party/libxml/src/testRelax.c (from /trunk/src/third_party/libxml/testRelax.c:56269)
   A /trunk/src/third_party/libxml/src/testSAX.c (from /trunk/src/third_party/libxml/testSAX.c:56269)
   A /trunk/src/third_party/libxml/src/testSchemas.c (from /trunk/src/third_party/libxml/testSchemas.c:56269)
   A /trunk/src/third_party/libxml/src/testThreads.c (from /trunk/src/third_party/libxml/testThreads.c:56269)
   A /trunk/src/third_party/libxml/src/testThreadsWin32.c (from /trunk/src/third_party/libxml/testThreadsWin32.c:56269)
   A /trunk/src/third_party/libxml/src/testURI.c (from /trunk/src/third_party/libxml/testURI.c:56269)
   A /trunk/src/third_party/libxml/src/testXPath.c (from /trunk/src/third_party/libxml/testXPath.c:56269)
   A /trunk/src/third_party/libxml/src/testapi.c (from /trunk/src/third_party/libxml/testapi.c:56269)
   A /trunk/src/third_party/libxml/src/testdso.c (from /trunk/src/third_party/libxml/testdso.c:56269)
   A /trunk/src/third_party/libxml/src/threads.c (from /trunk/src/third_party/libxml/threads.c:56269)
   A /trunk/src/third_party/libxml/src/tree.c (from /trunk/src/third_party/libxml/tree.c:56269)
   A /trunk/src/third_party/libxml/src/trio.c (from /trunk/src/third_party/libxml/trio.c:56269)
   A /trunk/src/third_party/libxml/src/trio.h (from /trunk/src/third_party/libxml/trio.h:56269)
   A /trunk/src/third_party/libxml/src/triodef.h (from /trunk/src/third_party/libxml/triodef.h:56269)
   A /trunk/src/third_party/libxml/src/trionan.c (from /trunk/src/third_party/libxml/trionan.c:56269)
   A /trunk/src/third_party/libxml/src/trionan.h (from /trunk/src/third_party/libxml/trionan.h:56269)
   A /trunk/src/third_party/libxml/src/triop.h (from /trunk/src/third_party/libxml/triop.h:56269)
   A /trunk/src/third_party/libxml/src/triostr.c (from /trunk/src/third_party/libxml/triostr.c:56269)
   A /trunk/src/third_party/libxml/src/triostr.h (from /trunk/src/third_party/libxml/triostr.h:56269)
   A /trunk/src/third_party/libxml/src/uri.c (from /trunk/src/third_party/libxml/uri.c:56269)
   A /trunk/src/third_party/libxml/src/valid.c (from /trunk/src/third_party/libxml/valid.c:56269)
   A /trunk/src/third_party/libxml/src/win32/Makefile (from /trunk/src/third_party/libxml/win32/Makefile:56269)
   A /trunk/src/third_party/libxml/src/win32/Makefile.bcb (from /trunk/src/third_party/libxml/win32/Makefile.bcb:56269)
   A /trunk/src/third_party/libxml/src/win32/Makefile.mingw (from /trunk/src/third_party/libxml/win32/Makefile.mingw:56269)
   A /trunk/src/third_party/libxml/src/win32/Makefile.msvc (from /trunk/src/third_party/libxml/win32/Makefile.msvc:56269)
   A /trunk/src/third_party/libxml/src/win32/Readme.txt (from /trunk/src/third_party/libxml/win32/Readme.txt:56269)
   A /trunk/src/third_party/libxml/src/win32/configure.js (from /trunk/src/third_party/libxml/win32/configure.js:56269)
   A /trunk/src/third_party/libxml/src/win32/defgen.xsl (from /trunk/src/third_party/libxml/win32/defgen.xsl:56269)
   A /trunk/src/third_party/libxml/src/win32/libxml2.def.src (from /trunk/src/third_party/libxml/win32/libxml2.def.src:56269)
   A /trunk/src/third_party/libxml/src/xinclude.c (from /trunk/src/third_party/libxml/xinclude.c:56269)
   A /trunk/src/third_party/libxml/src/xlink.c (from /trunk/src/third_party/libxml/xlink.c:56269)
   A /trunk/src/third_party/libxml/src/xml2-config.1 (from /trunk/src/third_party/libxml/xml2-config.1:56269)
   A /trunk/src/third_party/libxml/src/xml2-config.in (from /trunk/src/third_party/libxml/xml2-config.in:56269)
   A /trunk/src/third_party/libxml/src/xml2Conf.sh.in (from /trunk/src/third_party/libxml/xml2Conf.sh.in:56269)
   A /trunk/src/third_party/libxml/src/xmlIO.c (from /trunk/src/third_party/libxml/xmlIO.c:56269)
   A /trunk/src/third_party/libxml/src/xmlcatalog.c (from /trunk/src/third_party/libxml/xmlcatalog.c:56269)
   A /trunk/src/third_party/libxml/src/xmllint.c (from /trunk/src/third_party/libxml/xmllint.c:56269)
   A /trunk/src/third_party/libxml/src/xmlmemory.c (from /trunk/src/third_party/libxml/xmlmemory.c:56269)
   A /trunk/src/third_party/libxml/src/xmlmodule.c (from /trunk/src/third_party/libxml/xmlmodule.c:56269)
   A /trunk/src/third_party/libxml/src/xmlreader.c (from /trunk/src/third_party/libxml/xmlreader.c:56269)
   A /trunk/src/third_party/libxml/src/xmlregexp.c (from /trunk/src/third_party/libxml/xmlregexp.c:56269)
   A /trunk/src/third_party/libxml/src/xmlsave.c (from /trunk/src/third_party/libxml/xmlsave.c:56269)
   A /trunk/src/third_party/libxml/src/xmlschemas.c (from /trunk/src/third_party/libxml/xmlschemas.c:56269)
   A /trunk/src/third_party/libxml/src/xmlschemastypes.c (from /trunk/src/third_party/libxml/xmlschemastypes.c:56269)
   A /trunk/src/third_party/libxml/src/xmlstring.c (from /trunk/src/third_party/libxml/xmlstring.c:56269)
   A /trunk/src/third_party/libxml/src/xmlunicode.c (from /trunk/src/third_party/libxml/xmlunicode.c:56269)
   A /trunk/src/third_party/libxml/src/xmlwriter.c (from /trunk/src/third_party/libxml/xmlwriter.c:56269)
   A /trunk/src/third_party/libxml/src/xpath.c (from /trunk/src/third_party/libxml/xpath.c:56269)
   A /trunk/src/third_party/libxml/src/xpointer.c (from /trunk/src/third_party/libxml/xpointer.c:56269)
   D /trunk/src/third_party/libxml/testAutomata.c
   D /trunk/src/third_party/libxml/testC14N.c
   D /trunk/src/third_party/libxml/testHTML.c
   D /trunk/src/third_party/libxml/testModule.c
   D /trunk/src/third_party/libxml/testReader.c
   D /trunk/src/third_party/libxml/testRegexp.c
   D /trunk/src/third_party/libxml/testRelax.c
   D /trunk/src/third_party/libxml/testSAX.c
   D /trunk/src/third_party/libxml/testSchemas.c
   D /trunk/src/third_party/libxml/testThreads.c
   D /trunk/src/third_party/libxml/testThreadsWin32.c
   D /trunk/src/third_party/libxml/testURI.c
   D /trunk/src/third_party/libxml/testXPath.c
   D /trunk/src/third_party/libxml/testapi.c
   D /trunk/src/third_party/libxml/testdso.c
   D /trunk/src/third_party/libxml/threads.c
   D /trunk/src/third_party/libxml/tree.c
   D /trunk/src/third_party/libxml/trio.c
   D /trunk/src/third_party/libxml/trio.h
   D /trunk/src/third_party/libxml/triodef.h
   D /trunk/src/third_party/libxml/trionan.c
   D /trunk/src/third_party/libxml/trionan.h
   D /trunk/src/third_party/libxml/triop.h
   D /trunk/src/third_party/libxml/triostr.c
   D /trunk/src/third_party/libxml/triostr.h
   D /trunk/src/third_party/libxml/uri.c
   D /trunk/src/third_party/libxml/valid.c
   D /trunk/src/third_party/libxml/win32/Makefile
   D /trunk/src/third_party/libxml/win32/Makefile.bcb
   D /trunk/src/third_party/libxml/win32/Makefile.mingw
   D /trunk/src/third_party/libxml/win32/Makefile.msvc
   D /trunk/src/third_party/libxml/win32/Readme.txt
   D /trunk/src/third_party/libxml/win32/configure.js
   D /trunk/src/third_party/libxml/win32/defgen.xsl
   D /trunk/src/third_party/libxml/win32/libxml2.def.src
   D /trunk/src/third_party/libxml/xinclude.c
   D /trunk/src/third_party/libxml/xlink.c
   D /trunk/src/third_party/libxml/xml2-config.1
   D /trunk/src/third_party/libxml/xml2-config.in
   D /trunk/src/third_party/libxml/xml2Conf.sh.in
   D /trunk/src/third_party/libxml/xmlIO.c
   D /trunk/src/third_party/libxml/xmlcatalog.c
   D /trunk/src/third_party/libxml/xmllint.c
   D /trunk/src/third_party/libxml/xmlmemory.c
   D /trunk/src/third_party/libxml/xmlmodule.c
   D /trunk/src/third_party/libxml/xmlreader.c
   D /trunk/src/third_party/libxml/xmlregexp.c
   D /trunk/src/third_party/libxml/xmlsave.c
   D /trunk/src/third_party/libxml/xmlschemas.c
   D /trunk/src/third_party/libxml/xmlschemastypes.c
   D /trunk/src/third_party/libxml/xmlstring.c
   D /trunk/src/third_party/libxml/xmlunicode.c
   D /trunk/src/third_party/libxml/xmlwriter.c
   D /trunk/src/third_party/libxml/xpath.c
   D /trunk/src/third_party/libxml/xpointer.c

* Add rmdir, mkdir -p and umask to d8 on Unix.
* Remove the non-working methods from the os object on d8 on Windows
so you can test for their presence with if (os.system).
* Add a test (not run by default since it only works on d8).
* Fix incorrect use of wait that left defunct processes (zombies).

Committed: http://code.google.com/p/v8/source/detail?r=1650

Review URL: http://codereview.chromium.org/56107
------------------------------------------------------------------------
r56273 | hclam@chromium.org | 2010-08-17 02:25:47 +0200 (Tue, 17 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/remoting/remoting_resources_source.cc
   A /trunk/src/chrome/browser/remoting/remoting_resources_source.h
   A /trunk/src/chrome/browser/remoting/remoting_setup_flow.cc
   A /trunk/src/chrome/browser/remoting/remoting_setup_flow.h (from /trunk/src/chrome/browser/remoting/setup_flow.h:56272)
   A /trunk/src/chrome/browser/remoting/remoting_setup_message_handler.cc
   A /trunk/src/chrome/browser/remoting/remoting_setup_message_handler.h
   A /trunk/src/chrome/browser/remoting/resources
   A /trunk/src/chrome/browser/remoting/resources/setup_done.html
   A /trunk/src/chrome/browser/remoting/resources/setup_flow.html
   D /trunk/src/chrome/browser/remoting/setup.cc
   D /trunk/src/chrome/browser/remoting/setup.h
   D /trunk/src/chrome/browser/remoting/setup_flow.cc
   D /trunk/src/chrome/browser/remoting/setup_flow.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Setup dialog for remoting

Adding more setup content to remoting. Including the gaia authenication
and done message. This provides the basic flow for the setup.

There's a lot still needs to be worked on:
1. Merge RemotingSetupFlow and RemotingSetupMessageHandler because we shouldn't
   splitting the logic into two separate classes.
2. Cleanup the memory ownership.
3. Perform the actual gaia login.
4. Perform host registration.

Review URL: http://codereview.chromium.org/3160016
------------------------------------------------------------------------
r56272 | erg@google.com | 2010-08-17 02:24:54 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   D /trunk/src/chrome/browser/importer/importer_messages.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   D /trunk/src/chrome/common/devtools_messages.cc
   D /trunk/src/chrome/common/gpu_messages.cc
   D /trunk/src/chrome/common/nacl_messages.cc
   M /trunk/src/chrome/common/nacl_messages_internal.h
   D /trunk/src/chrome/common/plugin_messages.cc
   D /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   D /trunk/src/chrome/common/service_messages.cc
   D /trunk/src/chrome/common/utility_messages.cc
   D /trunk/src/chrome/common/webkit_param_traits.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   D /trunk/src/chrome/common/worker_messages.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/renderer_webcookiejar_impl.cc
   M /trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   D /trunk/src/chrome/test/automation/automation_messages.cc
   M /trunk/src/ipc/ipc_fuzzing_tests.cc
   D /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/ipc/ipc_message_utils.h
   D /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/ipc_send_fds_test.cc
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/ipc/sync_socket_unittest.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h

Completely revert all my IPC work to see if this was what regressed the page cycler.

BUG=51411,52103
TEST=page cycler

Review URL: http://codereview.chromium.org/3170020
------------------------------------------------------------------------
r56269 | akalin@chromium.org | 2010-08-17 01:45:15 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/sync/glue/app_data_type_controller.cc (from /trunk/src/chrome/browser/sync/glue/extension_data_type_controller.cc:56267)
   A /trunk/src/chrome/browser/sync/glue/app_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/extension_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/extension_sync_traits.cc
   M /trunk/src/chrome/browser/sync/glue/extension_sync_traits.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implemented apps sync (behind a flag).

BUG=46512
TEST=manual

Review URL: http://codereview.chromium.org/3186002
------------------------------------------------------------------------
r56268 | csilv@chromium.org | 2010-08-17 01:40:25 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js

- Add support for managed options so that basic controls can disable themselves based on their managed state.
- Disable the proxy settings button if they are managed.

BUG=52335
TEST=Verify appropriate options are disabled in Enterprise version w/ --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3122021
------------------------------------------------------------------------
r56266 | phajdan.jr@chromium.org | 2010-08-17 01:39:42 +0200 (Tue, 17 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/download/download_history.cc
   M /trunk/src/chrome/browser/download/download_history.h
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/test/ui_test_utils.cc

Regression fix: Downloads page in Incognito mode works fine now.

Additionally, it fixes another ancient bug that prevented downloads search
from working in Incognito mode.

The design of DownloadHistory is also nicer now, with no dependencies
on DownloadManager.

TEST=see bug
BUG=51955

Review URL: http://codereview.chromium.org/3112011
------------------------------------------------------------------------
r56261 | sargrass@google.com | 2010-08-17 01:28:52 +0200 (Tue, 17 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js

Get saved passwords when click the "show saved passwords" button on personal stuff page.
Remove the trigger for showing list.
Make the remove button work.

BUG=49093
TEST=None

Review URL: http://codereview.chromium.org/3137011
------------------------------------------------------------------------
r56258 | pkasting@chromium.org | 2010-08-17 01:22:42 +0200 (Tue, 17 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Preserve the correct number of visible browser actions across restarts.

The problem here was that in the case where the container was sized all the way open, we never saved the result, because we never called Animate().  Having the size saving happen at the end of animation seemed subtle, so this:
* Saves at the beginning, not end, of animation (so shutdowns during animation don't forget the right size)
* Renames Animate() to make it clearer that it's also saving the desired size
* In general simplifies things by basing animation on a target number of icons instead of a target width

BUG=51179
TEST=Size browser actions container to hide one action (and show the rest); restart; size to show all; restart.  On both restarts, you should see the same number of visible actions as at shut down.
Review URL: http://codereview.chromium.org/3114014
------------------------------------------------------------------------
r56257 | pkasting@chromium.org | 2010-08-17 01:22:03 +0200 (Tue, 17 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Cleanup: Rewrap lines, simplify code by using canvas mirroring instead of manual RTL position calculations.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3176013
------------------------------------------------------------------------
r56256 | andybons@chromium.org | 2010-08-17 01:21:10 +0200 (Tue, 17 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Upon a bad reload of an extension, leave the original disabled instead of blasting it away.

BUG=26888
TEST=TBD

Review URL: http://codereview.chromium.org/3106015
------------------------------------------------------------------------
r56245 | zelidrag@chromium.org | 2010-08-16 23:59:04 +0200 (Mon, 16 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/cros_options_page_ui_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/cros_options_page_ui_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/system_settings_provider.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/system_settings_provider.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h

Reenabled ChromeOS system setting for timezone selection.

BUG=chromium-os:5646
TEST=option chrome:options on chromeos build, go to system page and make timezone is back there

Review URL: http://codereview.chromium.org/3143009
------------------------------------------------------------------------
r56244 | stevenjb@chromium.org | 2010-08-16 23:59:02 +0200 (Mon, 16 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Issue 5164: Remove addressbar from panels created from apps or extensions

BUG=chromium-os:5164 http://code.google.com/p/chromium-os/issues/detail?id=5164
TEST=See bug description.

Review URL: http://codereview.chromium.org/3083004
------------------------------------------------------------------------
r56243 | rafaelw@chromium.org | 2010-08-16 23:49:08 +0200 (Mon, 16 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Create BackgroundContents::Delegate interface to break dependency on browser.h

BUG=50554

Review URL: http://codereview.chromium.org/3106012
------------------------------------------------------------------------
r56238 | stuartmorgan@chromium.org | 2010-08-16 23:38:54 +0200 (Mon, 16 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.css

DOMUI prefs: Fix typo in CSS values

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3188004
------------------------------------------------------------------------
r56237 | jhawkins@chromium.org | 2010-08-16 23:35:33 +0200 (Mon, 16 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/scoped_ptr.h
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/video_layer.h
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.h
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_status.h

FBTF: Header cleanup in renderer_host.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3164011
------------------------------------------------------------------------
r56233 | estade@chromium.org | 2010-08-16 22:47:22 +0200 (Mon, 16 Aug 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/options/content_settings.css

Unbreak build - add missing file

TBR=mpcomplete
BUG=none
TEST=compile

Review URL: http://codereview.chromium.org/3185008
------------------------------------------------------------------------
r56232 | estade@chromium.org | 2010-08-16 22:40:14 +0200 (Mon, 16 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js

Content settings: support --enable-cookie-prompt flag

add Ask setting (default and exception) behind this flag.

BUG=51375
TEST=manual

Review URL: http://codereview.chromium.org/3137005
------------------------------------------------------------------------
r56231 | estade@chromium.org | 2010-08-16 22:39:05 +0200 (Mon, 16 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.css
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js
   M /trunk/src/chrome/browser/resources/options.html

Content settings: show/hide exceptions list when the exceptions link is clicked.

TODO: need to show a little triangle
TODO: need to animate the show/hide
TODO: need to remove ellipsis from end of "Exceptions..." text

BUG=51375
TEST=manual

Review URL: http://codereview.chromium.org/3148012
------------------------------------------------------------------------
r56227 | alyssad@chromium.org | 2010-08-16 22:37:48 +0200 (Mon, 16 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/functional/translate.py

PyAuto fix for declining translation.

Closing the infobar after decline translation.

Review URL: http://codereview.chromium.org/3160019
------------------------------------------------------------------------
r56226 | pkasting@chromium.org | 2010-08-16 22:37:26 +0200 (Mon, 16 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

I've gotten multiple crashes at shutdown due to my new DCHECKs.  It seems it's possible to hit them with invalid button IDs.  While the DCHECKs won't happen in release builds, what probably will happen is some sort of other problem due to invalid memory access.  So just convert the DCHECKs to conditionals.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3155018
------------------------------------------------------------------------
r56224 | pkasting@chromium.org | 2010-08-16 22:36:30 +0200 (Mon, 16 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h

Cleanup: Make function definition order match declaration order.  Don't inline a few things that don't need it.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3140012
------------------------------------------------------------------------
r56223 | mirandac@chromium.org | 2010-08-16 22:36:29 +0200 (Mon, 16 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h

Fix problem of identical search engine logos + names in search engine dialog.

After discussion with Brian and the search engine group for EMEA, the decision was made to fix by adding the distinct logo for Yahoo, in the case of Canada, and allowing Bing to be represented by one search engine out of the three in the Arab states and BE.  Because Bing, like Google, does not use distinct logos for different locales, and allows users to change language easily from the home page (based on market area), we treat Bing like Google, and have it represented by only a single search engine in the dialog of three choices.  

The Search Engine Dialog is populated by the top three search engines in the template_url_prepopulate_data.cc for each country, so to make this change, we move the second Bing language search engine out from the third into the fourth position.  Thus both will still be available in the user's "manage search engines" options, but only one will appear in the dialog.

BUG=51224
TEST=Search engine dialog has three separate search engines for each country -- especially BE, CA, DZ, MA, SY.
Review URL: http://codereview.chromium.org/3110016
------------------------------------------------------------------------
r56220 | rsesek@chromium.org | 2010-08-16 22:03:21 +0200 (Mon, 16 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Poke KVO for prefs::kDownloadDefaultDirectory when resetting to default values.

R=pinkerton
BUG=51733
TEST=Chromium-->Preferences-->Under the Hood. Change the download directory. Click Reset to Defaults. UI updates to ~/Downloads.

Review URL: http://codereview.chromium.org/3110019
------------------------------------------------------------------------
r56211 | joth@chromium.org | 2010-08-16 19:00:47 +0200 (Mon, 16 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc

TBR: joth@chromium.org
------------------------------------------------------------------------
r56205 | joth@chromium.org | 2010-08-16 17:55:04 +0200 (Mon, 16 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc

Mark 2 failing tests in SavePageBrowserTest as flaky
TBR: joth@chromium.org
------------------------------------------------------------------------
r56204 | yurys@chromium.org | 2010-08-16 15:41:04 +0200 (Mon, 16 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Remove \r from resource_dispatcher_host.cc

TBR=pfeldman

Review URL: http://codereview.chromium.org/3132012
------------------------------------------------------------------------
r56202 | rsesek@chromium.org | 2010-08-16 15:10:11 +0200 (Mon, 16 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.mm

Convert other callsites of AECreateDesc() to use scoped_aedesc<>.

BUG=none
TEST=Compile/unit_tests

Review URL: http://codereview.chromium.org/3173017
------------------------------------------------------------------------
r56197 | jorlow@chromium.org | 2010-08-16 13:19:39 +0200 (Mon, 16 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run.cc
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Fix a subtle issue/bug for unit tests to use IsChromeFirstRun. Once first_run was set to 1 from one unit test,
there is no way for other unit tests to change the first_run state regardless first_run_sentinel exists or not.
In this case, IsChromeFirstRun already return true which may not be desirable for some unit test such as Toolbar5ImporterTest::BookmarkParse.

The issue won't cause any problem if all unit tests were run separately instead of in a single unit_test.exe.
But the change itself is minimal, and allow future unit tests for IsChromeFirstRun itself.

Bug=None
Test=None

Review URL: http://codereview.chromium.org/3038024
------------------------------------------------------------------------
r56196 | satorux@chromium.org | 2010-08-16 12:27:58 +0200 (Mon, 16 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Add logic to remove duplicates.

Duplicates shouldn't be created if the code is correct, but
to be defensive, add logic to remove these.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/3135019
------------------------------------------------------------------------
r56192 | satorux@chromium.org | 2010-08-16 11:30:41 +0200 (Mon, 16 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Show native display names in two places: tooltip and language title on the right.

The change  makes it easy to choose a language from the language list
in UI langauge that you cannot read. This situation happens you
accidentally change the UI language some language they cannot read.

BUG=chromium-os:3871
TEST=manually

Review URL: http://codereview.chromium.org/3107014
------------------------------------------------------------------------
r56191 | satorux@chromium.org | 2010-08-16 11:08:45 +0200 (Mon, 16 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Add logic to enable the default input method for the language added.

When a new language is added, the default input method associated
with the langauge should be enabled.

TEST=manually
BUG=chromium-os:5657

Review URL: http://codereview.chromium.org/3180008
------------------------------------------------------------------------
r56190 | satorux@chromium.org | 2010-08-16 10:58:53 +0200 (Mon, 16 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Always display the input method name for Japanese.

In the language menu, we show language names only if there are no
ambiguity. However, showing "Japanese" is confusing, when only
Japanese keyboard layout is enabled. Users would expect they can
enter Japanese with an input method, rather than just using
"Japanese keyboard".

BUG=chromium-os:5675
TEST=unit tests; manually on the netbook

Review URL: http://codereview.chromium.org/3122019
------------------------------------------------------------------------
r56189 | satorux@chromium.org | 2010-08-16 10:47:01 +0200 (Mon, 16 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Fix a bug where users were able to remove a language used for displaying Chromium OS.

Users shoulnd't be able to remove such a language.
In the C++ version, we disabled the "Remove" button to prevent the action, but
in the DOMUI version, we'll show a warning instead, per suggestions from UX
designers.

BUG=chromium-os:5702
TEST=manually

Review URL: http://codereview.chromium.org/3122018
------------------------------------------------------------------------
r56188 | viettrungluu@chromium.org | 2010-08-16 09:59:07 +0200 (Mon, 16 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/browser_process.cc
   M /trunk/src/chrome/browser/clipboard_dispatcher_gtk.cc
   M /trunk/src/chrome/browser/clipboard_dispatcher_win.cc
   M /trunk/src/chrome/browser/gpu_process_host_ui_shim.cc
   M /trunk/src/chrome/browser/js_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/preferences_mock_mac.cc
   M /trunk/src/chrome/browser/tab_closeable_state_watcher.cc

Whitespace change to trigger the bots.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3167013
------------------------------------------------------------------------
r56187 | viettrungluu@chromium.org | 2010-08-16 09:13:53 +0200 (Mon, 16 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/json/json_reader_unittest.cc
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/command_line_pref_store_unittest.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/views/select_file_dialog.cc
   M /trunk/src/chrome/common/automation_constants.cc
   M /trunk/src/chrome/common/automation_constants.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/plugin_group_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_constants.cc
   M /trunk/src/chrome/installer/util/master_preferences_constants.h
   M /trunk/src/chrome/installer/util/master_preferences_dummy.cc
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_consts.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_consts.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   M /trunk/src/chrome/service/cloud_print/print_system_cups.cc
   M /trunk/src/chrome/service/cloud_print/printer_job_handler.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc

Remove deprecated wstring Get(As)String() methods from Value, etc.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3117017
------------------------------------------------------------------------
r56186 | yusukes@chromium.org | 2010-08-16 08:42:48 +0200 (Mon, 16 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h

cros/input_method_library clean up.

- Remove unused variable kDefaultKeyboardLayout.
- Fix  bad indent.
- Add comment to SetImeConfig().

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/3148014
------------------------------------------------------------------------
r56184 | yurys@chromium.org | 2010-08-16 08:09:22 +0200 (Mon, 16 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h

DevTools: support dispatching devtools commands when there is a tight loop in JavaScript

Review URL: http://codereview.chromium.org/3152011
------------------------------------------------------------------------
r56179 | satorux@chromium.org | 2010-08-16 05:38:13 +0200 (Mon, 16 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Fix a bug where clicking on the configure button caused the input method to be disabled.

This bug was caused as the button click event was propagated to the checkbox
click handler.

TEST=manually
BUG=chromium-os:5687

Review URL: http://codereview.chromium.org/3156014
------------------------------------------------------------------------
r56174 | cmasone@google.com | 2010-08-16 01:22:58 +0200 (Mon, 16 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc

Fix memory leaks in OwnerKeyUtils

I wasn't freeing some memory I caused to be allocated down in NSS.  It turns
out I didn't even need the data structures I was allocating anymore :-)

BUG=52181
TEST=Valgrind the unit_tests

Review URL: http://codereview.chromium.org/3106013
------------------------------------------------------------------------
r56173 | rafaelw@chromium.org | 2010-08-15 23:06:20 +0200 (Sun, 15 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc

Close NTP when launching an app (fix regression)

BUG=51157
TEST=none

Review URL: http://codereview.chromium.org/3159017
------------------------------------------------------------------------
r56171 | viettrungluu@chromium.org | 2010-08-15 21:00:19 +0200 (Sun, 15 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/autofill/autofill_type.h
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/proxy_handler.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   M /trunk/src/chrome/browser/chromeos/options/cellular_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/dom_ui/history2_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.h
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.h
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.h
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.h
   M /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/in_memory_database.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.h
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.h
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.h
   M /trunk/src/chrome/browser/translate/translate_prefs.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/content_setting_bubble_views.h
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.h
   M /trunk/src/chrome/browser/views/database_info_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/infobars/after_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/local_storage_info_view.h
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.h
   M /trunk/src/chrome/browser/views/modal_dialog_delegate.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer_data.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_controller.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/webdata/web_data_service_test_util.h
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/extensions/extension_extent.h
   M /trunk/src/chrome/common/extensions/extension_file_util.h
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/nacl_messages.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/utility_messages.h
   M /trunk/src/chrome/common/zip.h
   M /trunk/src/chrome/default_plugin/plugin_impl_gtk.h
   M /trunk/src/chrome/default_plugin/plugin_impl_mac.h
   M /trunk/src/chrome/default_plugin/plugin_impl_win.h
   M /trunk/src/chrome/default_plugin/plugin_main.h
   M /trunk/src/chrome/gpu/gpu_info_collector.h
   M /trunk/src/chrome/installer/util/create_dir_work_item.h
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/gpu_video_service_host.h
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/net/renderer_net_predictor.h
   M /trunk/src/chrome/renderer/notification_provider.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.h
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.h
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/browser_with_test_window_test.h
   M /trunk/src/chrome/test/sync/engine/proto_extension_validator.h
   M /trunk/src/chrome/test/test_launcher/test_runner.h
   M /trunk/src/chrome/tools/convert_dict/dic_reader.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.h

FBTF: Remove "obviously" unneeded standard C++ library #includes.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3179017
------------------------------------------------------------------------
r56170 | viettrungluu@chromium.org | 2010-08-15 20:37:10 +0200 (Sun, 15 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/json/json_reader.cc
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/about_page_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc

Remove (deprecated) wstring version of Value::CreateStringValue().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3136012
------------------------------------------------------------------------
r56165 | mirandac@chromium.org | 2010-08-15 18:16:27 +0200 (Sun, 15 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

Move some cleanup code to the destructor.  If the user closes the Chrome browser window while the first run bubble is showing, the First Run Bubble will close before the cleanup code has had a chance to fire.
This change fixes that.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/3120013
------------------------------------------------------------------------
r56163 | jar@chromium.org | 2010-08-15 17:13:49 +0200 (Sun, 15 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/predictor_api.h
   M /trunk/src/chrome/browser/net/url_info.cc
   M /trunk/src/chrome/browser/net/url_info.h

Intercept navigations, not DNS resolutions, to predict startup

Transition from using a DNS observer, to using the 
TCP/IP connection interceptor (which is used for
preconneciton and pre-resolution) to acquire the
list of hosts to resolve at startup.

BUG=42694
r=mbelshe
Review URL: http://codereview.chromium.org/3169006
------------------------------------------------------------------------
r56150 | mal@google.com | 2010-08-15 01:58:14 +0200 (Sun, 15 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Fix two calls to font.height to font.GetHeight.

This is a follow on to r56040, "Rework gfx::Font by moving platform-specific code into inner classes"

These two lines are inside #if defined(GOOGLE_CHROME_BUILD) and only
get compiled for Google Chrome official builds (which have been broken 
for Windows and ChromeOS since r56040).

TBR= ben
BUG= none
TEST= Google Chrome builders pass
      http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Google%20Chrome%20ChromeOS
      http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Google%20Chrome%20XP

Review URL: http://codereview.chromium.org/3161019
------------------------------------------------------------------------
r56148 | tfarina@chromium.org | 2010-08-15 00:33:56 +0200 (Sun, 15 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/wrench_menu_model.cc

gtk: Use 'Preferences' instead of 'Options' in wrench menu.

BUG=17870
TEST=launch chrome, open the wrench menu, see if the 'Preferences' menu is in
there instead of the 'Options' menu.

Review URL: http://codereview.chromium.org/3060050
------------------------------------------------------------------------
r56147 | zelidrag@chromium.org | 2010-08-14 20:35:01 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/browser_options.js

Made download location hidden on ChromeOS, fixed a JS error due to a related change

BUG=chromium-os:5539
TEST=make sure there are no JS errors on chrome:options page and that download location can't be changed

Review URL: http://codereview.chromium.org/3167012
------------------------------------------------------------------------
r56146 | akalin@chromium.org | 2010-08-14 20:26:28 +0200 (Sat, 14 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Made IsGalleryDownloadURL() compare based on spec and made it a
static function.

BUG=52067
TEST=none

Review URL: http://codereview.chromium.org/3175012
------------------------------------------------------------------------
r56143 | viettrungluu@chromium.org | 2010-08-14 19:25:32 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h

Convert remaining wide extension_automation_constants keys.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3187003
------------------------------------------------------------------------
r56142 | tfarina@chromium.org | 2010-08-14 18:33:50 +0200 (Sat, 14 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.h
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc

Get rid of the ERROR_TYPE from InfoBarDelegate.

Reason: This type is not really used and is just adding duplicated code.
We are using the same color scheme for both WARNING_TYPE and ERROR_TYPE, so
there is no really reason to both exists. Staing with WARNING_TYPE because
it used more than ERROR_TYPE and looks like it captures the idea better than
ERROR_TYPE.

BUG=39102
TEST=trybots

Review URL: http://codereview.chromium.org/3128007
------------------------------------------------------------------------
r56141 | viettrungluu@chromium.org | 2010-08-14 18:29:42 +0200 (Sat, 14 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_metrics_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_proxy_api.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Convert more wide strings in browser/extensions.

I think this kills off the remaining uses of the now-deprecated wstring
DictionaryValue methods.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3125010
------------------------------------------------------------------------
r56140 | viettrungluu@chromium.org | 2010-08-14 18:23:56 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Convert some obvious wide strings in browser/cocoa.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3124023
------------------------------------------------------------------------
r56139 | viettrungluu@chromium.org | 2010-08-14 18:11:10 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h

Convert wide strings in WebResourceService.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3130020
------------------------------------------------------------------------
r56138 | viettrungluu@chromium.org | 2010-08-14 16:53:43 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Convert Task Manager to string16 from wstring, part 1.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3108019
------------------------------------------------------------------------
r56130 | viettrungluu@chromium.org | 2010-08-14 08:19:43 +0200 (Sat, 14 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm

Whitespace change to trigger the bots.

BUG=none
TEST=none
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/3133015
------------------------------------------------------------------------
r56129 | akalin@chromium.org | 2010-08-14 05:36:15 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fixed bug preventing gallery apps from being autoupdated/synced.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/3146015
------------------------------------------------------------------------
r56128 | viettrungluu@chromium.org | 2010-08-14 05:32:17 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/json/json_reader.cc
   M /trunk/src/base/json/json_writer_unittest.cc
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Remove deprecated wstring DictionaryValue::SetWithoutPathExpansion().

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3121017
------------------------------------------------------------------------
r56124 | viettrungluu@chromium.org | 2010-08-14 04:54:08 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/host_zoom_map_unittest.cc

Remove remaining deprecated wstring DictionaryValue::Get...WithoutPathExpansion()s.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3116013
------------------------------------------------------------------------
r56123 | tfarina@chromium.org | 2010-08-14 04:13:43 +0200 (Sat, 14 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/base/registry.cc
   M /trunk/src/base/registry.h
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc
   M /trunk/src/net/base/platform_mime_util_win.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc

Cleanup Registry API: part 3.

- Remove the default arguments from the constructor.
- Add a empty constructor to handle the case of the default arguments were used.

BUG=44644
TEST=trybots

Review URL: http://codereview.chromium.org/3172009
------------------------------------------------------------------------
r56122 | viettrungluu@chromium.org | 2010-08-14 03:55:06 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc

Remove deprecated DictionaryValue::HasKeyASCII(); HasKey() already takes UTF-8.

BUG=none
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3142011
------------------------------------------------------------------------
r56121 | viettrungluu@chromium.org | 2010-08-14 03:49:14 +0200 (Sat, 14 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/json/json_reader_unittest.cc
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc

Remove deprecated wstring DictionaryValue::Get{Dictionary,List}WithoutPathExpansion() overloads.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3163015
------------------------------------------------------------------------
r56115 | pkasting@chromium.org | 2010-08-14 02:17:05 +0200 (Sat, 14 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_win.cc

Noticed when I crashed while running in RTL mode that the crash string had its punctuation messed up.

BUG=none
TEST=Force a browser crash while running with --lang=he and look at the "Woah!" string in the popup
Review URL: http://codereview.chromium.org/3187001
------------------------------------------------------------------------
r56106 | pkasting@chromium.org | 2010-08-14 00:35:50 +0200 (Sat, 14 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/views/view.cc

Misc. cleanup: simplify some code, add a few comments

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3143016
------------------------------------------------------------------------
r56103 | pkasting@chromium.org | 2010-08-14 00:26:48 +0200 (Sat, 14 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Fix some issues with the New Tab Page:
* In RTL, the options dropmarker button was still on the right (overlaying the Chrome logo and opposite where the dropdown menu would actually appear)
* Missing a <head> tag
* Made the "attribution" block at the bottom corner of the NTP be at the end rather than always on the right

BUG=none
TEST=Use NTP with --lang=he and check dropmarker and custom theme attribution position
Review URL: http://codereview.chromium.org/3122015
------------------------------------------------------------------------
r56100 | evan@chromium.org | 2010-08-14 00:10:30 +0200 (Sat, 14 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/apply_services_customization.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/tools/crash_cache/crash_cache.cc

CommandLine: eliminate wstring-accepting AppendLooseValue

Instead use AppendArg variants which accept a FilePath or an ASCII string.

Review URL: http://codereview.chromium.org/3134008
------------------------------------------------------------------------
r56099 | michaeln@chromium.org | 2010-08-13 23:59:48 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/test/data/extensions/app1/manifest.json
   M /trunk/src/chrome/test/data/extensions/app2/manifest.json

Grant ChromeApplications unlimited appcache and database storage if requested.

BUG=49227,49993
TEST=ExtensionsServiceTest.InstallAppsWithUnlimtedStorage

Review URL: http://codereview.chromium.org/3053048
------------------------------------------------------------------------
r56097 | sargrass@google.com | 2010-08-13 23:39:23 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   A /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.css
   A /trunk/src/chrome/browser/resources/options/passwords_exceptions_list.js
   M /trunk/src/chrome/browser/resources/options.html

Overwrite a list to display the passwords.

BUG=49093
TEST=None

Review URL: http://codereview.chromium.org/3161012
------------------------------------------------------------------------
r56094 | jhawkins@chromium.org | 2010-08-13 23:25:28 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc

Fix a bad line ending in sync_resource_handler.cc.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3185002
------------------------------------------------------------------------
r56091 | estade@chromium.org | 2010-08-13 23:17:44 +0200 (Fri, 13 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc

Fix suggested save file name for title-less pages.

regressed in r48691

BUG=51963
TEST=TODO

Review URL: http://codereview.chromium.org/3150012
------------------------------------------------------------------------
r56090 | asargent@chromium.org | 2010-08-13 23:09:21 +0200 (Fri, 13 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   M /trunk/src/chrome/common/extensions/docs/samples.json
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/storage_new.json
   A /trunk/src/chrome/test/data/extensions/storage_quota/unlimited_quota/2.0
   A /trunk/src/chrome/test/data/extensions/storage_quota/unlimited_quota/2.0/manifest.json

Rename the extension manifest key "unlimited_storage" to "unlimitedStorage"

But, still accept the old value for backwards compatability.

BUG=51970
TEST=Extensions should get unlimited storage quota for localStorage and web 
databases using either "unlimitedStorage" or "unlimited_storage" in their 
manifest's permissions key.

Review URL: http://codereview.chromium.org/3109013
------------------------------------------------------------------------
r56088 | jar@chromium.org | 2010-08-13 23:06:28 +0200 (Fri, 13 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable two tests to green up tree after webkit merge

BUG=52086
tbr=japhet
Review URL: http://codereview.chromium.org/3132009
------------------------------------------------------------------------
r56078 | mirandac@google.com | 2010-08-13 22:32:52 +0200 (Fri, 13 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

Stretch first run bubble linger time out to 3 seconds to avoid getting burned by page loading issues on slow Windows boxes.

This only affects the "Search from the omnibox" bubble that appears on the very first install of Chrome.

This solution came after a long discussion w/jcivelli yesterday.  A perfect solution to this problem would be too complex for M6, because it would involve triggering only when all first run pages have actually finished loading in the browser; this solution manages to both avoid getting stepped on by loading in all but the slowest machines -- and, if it does get stepped on, to at least actually show the bubble for 3 seconds.

BUG=51704
TEST=see bug
Review URL: http://codereview.chromium.org/3141015
------------------------------------------------------------------------
r56075 | nshkrob@chromium.org | 2010-08-13 22:27:15 +0200 (Fri, 13 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Add TopSites::ProcessPendingCallbacks and call it after ReadDatabase.

Fix the test and unmark as FLAKY.

BUG=51721
TEST=unit_tests, ui_tests

Review URL: http://codereview.chromium.org/3139009
------------------------------------------------------------------------
r56074 | davemoore@chromium.org | 2010-08-13 22:26:50 +0200 (Fri, 13 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

ScrollWheel scrolls by default amount (as opposed to touchpad)

BUG=chromium-os:5648
TEST=Connect mouse with wheel to USB port. Scroll with wheel. Each click on wheel should scroll by about 50 pixels.

Note: this will require this cl to be committed too:
http://codereview.chromium.org/3104009/show

Review URL: http://codereview.chromium.org/3112008
------------------------------------------------------------------------
r56073 | davemoore@chromium.org | 2010-08-13 22:13:10 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h

Fix previous cl to implement new panel mock to have each title own its background
so it doesn't get deleted more than once
BUG=chromium-os:5156
TEST=none

Review URL: http://codereview.chromium.org/3104010
------------------------------------------------------------------------
r56072 | jcivelli@chromium.org | 2010-08-13 22:10:58 +0200 (Fri, 13 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/language_state.cc
   M /trunk/src/chrome/browser/tab_contents/language_state.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Sites like Google Maps may trigger navigations when the user interacts with the page.
In such cases, we shouldn't show a new translate infobar offering to translate the page if the user already declined translation on that page.

BUG=48215
TEST=See bug for URL and steps.

Review URL: http://codereview.chromium.org/3183001
------------------------------------------------------------------------
r56070 | avi@chromium.org | 2010-08-13 22:00:28 +0200 (Fri, 13 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_test_helper.h

Include needed header for r56066; build fix.

TBR

Review URL: http://codereview.chromium.org/3119013
------------------------------------------------------------------------
r56069 | avi@chromium.org | 2010-08-13 21:47:11 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc

Plumb the find progress's "we're done" value to the browser.

BUG=51433
TEST=as in bug

Review URL: http://codereview.chromium.org/3157004
------------------------------------------------------------------------
r56066 | evan@chromium.org | 2010-08-13 21:39:58 +0200 (Fri, 13 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_test_helper.h
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.cc
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   M /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Convert infobar APIs to UTF-16.

The critical change is the base class in infobar_delegate.h.
The remainder is just adapting all users to that change.

I grepped for all instances of the three base functions whose
types I changed to be more sure that I found all classes that
tried to overload these functions.  I sure wish C++ had an
@Override annotation.  :~(

TEST=compiles
BUG=23581

Review URL: http://codereview.chromium.org/3127009
------------------------------------------------------------------------
r56062 | erg@google.com | 2010-08-13 21:04:46 +0200 (Fri, 13 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc

TBR: Fix chromeos build. Part 2.
------------------------------------------------------------------------
r56058 | erg@google.com | 2010-08-13 20:49:02 +0200 (Fri, 13 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

TBR: Fix chromeos build.
------------------------------------------------------------------------
r56057 | chocobo@chromium.org | 2010-08-13 20:38:22 +0200 (Fri, 13 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc

Use new GetServiceInfo() method on SystemInfo on libcros to fix backwards incompatibility issues.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/3181009
------------------------------------------------------------------------
r56055 | seanparent@google.com | 2010-08-13 20:28:17 +0200 (Fri, 13 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/dom_ui/about_page_handler.cc
   A /trunk/src/chrome/browser/dom_ui/about_page_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/about_page.css
   A /trunk/src/chrome/browser/resources/options/about_page.html
   A /trunk/src/chrome/browser/resources/options/about_page.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

First draft of DOM UI for about box. See chromium-os:5161 for details on what
is not part of this cl.

BUG=chromium-os:5161
TEST=select About Chromium in the menu.

Review URL: http://codereview.chromium.org/3064015
------------------------------------------------------------------------
r56053 | erg@google.com | 2010-08-13 20:18:36 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper_browsertest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_drag_data_unittest.cc
   M /trunk/src/chrome/browser/web_applications/web_app_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

FBTF: Forward declare everything possible in testing_profile.h

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3129007
------------------------------------------------------------------------
r56052 | asargent@chromium.org | 2010-08-13 20:12:35 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc
   A /trunk/src/chrome/test/data/extensions/autoupdate/v1/background.html
   M /trunk/src/chrome/test/data/extensions/autoupdate/v1/manifest.json
   M /trunk/src/chrome/test/data/extensions/autoupdate/v1.crx
   A /trunk/src/chrome/test/data/extensions/autoupdate/v2/background.html
   M /trunk/src/chrome/test/data/extensions/autoupdate/v2/manifest.json
   M /trunk/src/chrome/test/data/extensions/autoupdate/v2.crx
   M /trunk/src/chrome/test/data/extensions/autoupdate/v3/manifest.json
   M /trunk/src/chrome/test/data/extensions/autoupdate/v3.crx

Remove toolstrip references from autoupdate browser test

BUG=51734
TEST=none (this is changing a browser test - it should successfully run)

Review URL: http://codereview.chromium.org/3131012
------------------------------------------------------------------------
r56045 | cdn@chromium.org | 2010-08-13 19:09:49 +0200 (Fri, 13 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc

Revert 55967 - This was handled by another revision and is now redundant

BUG=51702
TEST=None
Review URL: http://codereview.chromium.org/3144003

TBR=cdn@chromium.org
Review URL: http://codereview.chromium.org/3150014
------------------------------------------------------------------------
r56040 | ben@chromium.org | 2010-08-13 18:43:03 +0200 (Fri, 13 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/app/gfx/font_util.cc
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle_dummy.cc
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/app/win_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_title.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/remoting/setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_exceptions_table_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/gfx/canvas_skia_linux.cc
   M /trunk/src/gfx/canvas_skia_mac.mm
   M /trunk/src/gfx/canvas_skia_win.cc
   A /trunk/src/gfx/font.cc
   M /trunk/src/gfx/font.h
   M /trunk/src/gfx/font_gtk.cc
   D /trunk/src/gfx/font_mac.mm
   D /trunk/src/gfx/font_skia.cc
   M /trunk/src/gfx/font_unittest.cc
   D /trunk/src/gfx/font_win.cc
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/gfx/native_widget_types.h
   A /trunk/src/gfx/platform_font.h
   A /trunk/src/gfx/platform_font_gtk.cc (from /trunk/src/gfx/font_skia.cc:55264)
   A /trunk/src/gfx/platform_font_gtk.h
   A /trunk/src/gfx/platform_font_mac.h
   A /trunk/src/gfx/platform_font_mac.mm (from /trunk/src/gfx/font_mac.mm:55264)
   A /trunk/src/gfx/platform_font_win.cc (from /trunk/src/gfx/font_win.cc:55264)
   A /trunk/src/gfx/platform_font_win.h
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printed_document_win.cc
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/listbox/native_listbox_win.cc
   M /trunk/src/views/controls/menu/menu_config_win.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/textfield/gtk_views_entry.cc
   M /trunk/src/views/controls/textfield/gtk_views_textview.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/view_text_utils.cc
   M /trunk/src/views/widget/tooltip_manager_gtk.cc
   M /trunk/src/views/widget/tooltip_manager_win.cc
   M /trunk/src/views/window/custom_frame_view.cc

Rework gfx::Font by moving platform-specific code into inner classes.

gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage.

gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk).

BUG=none
TEST=existing unittests

Review URL: http://codereview.chromium.org/3083022
------------------------------------------------------------------------
r56039 | viettrungluu@chromium.org | 2010-08-13 18:40:34 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Convert wide strings in extension_popup_api.cc and external_pref_extension_provider.cc.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3135013
------------------------------------------------------------------------
r56037 | viettrungluu@chromium.org | 2010-08-13 18:29:19 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.h

Convert wide strings in extension_context_menu_api.*.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3126008
------------------------------------------------------------------------
r56036 | dhg@chromium.org | 2010-08-13 18:26:10 +0200 (Fri, 13 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h

Adding ability to sort by date to directory_lister.cc.  Adding support for title and making so long filenames are ellipsis.  

BUG=chromium-os:5565 chromium-os:5566
TEST=manual
Review URL: http://codereview.chromium.org/3177010
------------------------------------------------------------------------
r56034 | nshkrob@chromium.org | 2010-08-13 18:23:05 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/tools/valgrind/tsan/suppressions.txt

Fix more races in TopSites: race on waiting_for_results_ and on top_sites_.size.

BUG=51890
TEST=tsan ui memory bot

Review URL: http://codereview.chromium.org/3131015
------------------------------------------------------------------------
r56032 | rogerta@google.com | 2010-08-13 18:09:39 +0200 (Fri, 13 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc

Fix for issue 51693, which was a regression from integrating the open source
version of RLZ into Chromium.  Chromium should never send RLZ pings to Google,
only Google Chrome should do so.

Removing dependency from rlz chrome extenion api to RLZTracker since it is
not required.

BUG=51693
TEST=Install Chromium on a clean machine and make sure no pings are sent to
http://client1.google.com/tools/pso/ping?...

Review URL: http://codereview.chromium.org/3146007
------------------------------------------------------------------------
r56031 | viettrungluu@chromium.org | 2010-08-13 18:07:35 +0200 (Fri, 13 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h

Remove (deprecated) wstring version of DictionaryValue::RemoveWithoutPathExpansion().

(And convert the few remaining uses.)

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3163011
------------------------------------------------------------------------
r56030 | viettrungluu@chromium.org | 2010-08-13 17:43:49 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/proxy_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.h

Convert wide strings in Chrome OS DOM UI code.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3159015
------------------------------------------------------------------------
r56029 | viettrungluu@chromium.org | 2010-08-13 17:38:44 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc

Remove a few more wide strings from Chrome OS.

BUG=23581
TEST=builds

Review URL: http://codereview.chromium.org/3162009
------------------------------------------------------------------------
r56028 | cmasone@google.com | 2010-08-13 17:35:16 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   M /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

Refactor OwnerKeyUtils and OwnerManager to leverage base::RSAPrivateKey

BUG=chromium-os:4485
TEST=unit tests

Review URL: http://codereview.chromium.org/3151008
------------------------------------------------------------------------
r56027 | avayvod@chromium.org | 2010-08-13 17:26:35 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h

Hook new libcros function to Chrome: restart Chrome in BWSI mode with start url passed.

BUG=http://crosbug.com/5154
TEST=Test that going BWSI works and that clicking on "Can't access your account link" opens Chrome in BWSI mode with the correct start url.

Review URL: http://codereview.chromium.org/3126009
------------------------------------------------------------------------
r56026 | rsesek@chromium.org | 2010-08-13 17:24:53 +0200 (Fri, 13 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/base/base.gypi
   A /trunk/src/base/scoped_aedesc.h
   M /trunk/src/chrome/browser/platform_util_mac.mm

[Mac] Use an AppleEvent to tell the Finder to open downloaded items, rather than NSWorkspace.

BUG=32921,50263
TEST=Force a PDF to download. Quit Preview, if open. Open the downloaded PDF from the download shelf. Preview opens and becomes frontmost.
TEST=Download a file of a type that you do not have an application with which to open it. Open it from the download shelf. Finder bounces for your attention to choose an application to open it.

Review URL: http://codereview.chromium.org/3151011
------------------------------------------------------------------------
r56021 | mmenke@chromium.org | 2010-08-13 15:55:10 +0200 (Fri, 13 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   A /trunk/src/chrome/browser/net/net_log_logger.cc
   A /trunk/src/chrome/browser/net/net_log_logger.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h

Redirects NetLog output to the log file, when the command line
option "--log-net-log" is used.

BUG= 50987
TEST= Run "chrome --log-net-log --enable-logging --log-level=0"
  And then check to make sure the log contains the NetLog events.

Review URL: http://codereview.chromium.org/3040051
------------------------------------------------------------------------
r56017 | satorux@chromium.org | 2010-08-13 14:27:01 +0200 (Fri, 13 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Implement logic to sort input methods per language codes.

The logic is a bit complex, since one input method can be associated with
multiple languages. For instance, US keyboard is used in English (United
States) and Filipino.

TEST=manually on the netbook
BUG=chromium-os:5544

Review URL: http://codereview.chromium.org/3146014
------------------------------------------------------------------------
r56016 | danno@chromium.org | 2010-08-13 14:23:43 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc

Merge policy provider objects into singleton where possible

BUG=50623
TEST=ConfigurationPolicyPrefStoreTest.*

Review URL: http://codereview.chromium.org/3072009
------------------------------------------------------------------------
r56007 | satorux@chromium.org | 2010-08-13 11:12:44 +0200 (Fri, 13 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.h

Revert 56006 - Revert 56002 - Adds SpeechInputManagerImpl to handle requests from render views and return recognition events.

Confirmed that r56002 was not guilty.


This CL depends on http://codereview.chromium.org/3124009 going in first for the SpeechRecognizer class.
Also renamed SpeechInputManager::Listener to Delegate to be consistent with Chromium terminology.

TEST=manually, open a webpage containing an <input speech> tag and click on the speech button to test.
BUG=none

Review URL: http://codereview.chromium.org/3108007

TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/3184001

TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/3167011
------------------------------------------------------------------------
r56006 | satorux@chromium.org | 2010-08-13 10:20:12 +0200 (Fri, 13 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.h

Revert 56002 - Adds SpeechInputManagerImpl to handle requests from render views and return recognition events.

This CL depends on http://codereview.chromium.org/3124009 going in first for the SpeechRecognizer class.
Also renamed SpeechInputManager::Listener to Delegate to be consistent with Chromium terminology.

TEST=manually, open a webpage containing an <input speech> tag and click on the speech button to test.
BUG=none

Review URL: http://codereview.chromium.org/3108007

TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/3184001
------------------------------------------------------------------------
r56004 | yurys@chromium.org | 2010-08-13 09:16:51 +0200 (Fri, 13 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: disable DevToolsSanityTest.TestPauseWhenScriptIsRunning until upstream change is rolled

BUG=52024

Review URL: http://codereview.chromium.org/3113013
------------------------------------------------------------------------
r56002 | satish@chromium.org | 2010-08-13 08:47:39 +0200 (Fri, 13 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   M /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.h
   M /trunk/src/chrome/browser/speech/speech_input_manager.cc
   M /trunk/src/chrome/browser/speech/speech_input_manager.h

Adds SpeechInputManagerImpl to handle requests from render views and return recognition events.
This CL depends on http://codereview.chromium.org/3124009 going in first for the SpeechRecognizer class.
Also renamed SpeechInputManager::Listener to Delegate to be consistent with Chromium terminology.

TEST=manually, open a webpage containing an <input speech> tag and click on the speech button to test.
BUG=none

Review URL: http://codereview.chromium.org/3108007
------------------------------------------------------------------------
r56001 | viettrungluu@chromium.org | 2010-08-13 08:29:57 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Mark SessionRestoreUITest.ShareProcessesOnRestore as flaky on Linux and Mac.

BUG=52022
TEST=greener tree

Review URL: http://codereview.chromium.org/3156007
------------------------------------------------------------------------
r56000 | viettrungluu@chromium.org | 2010-08-13 08:23:43 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_processes_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_processes_api_constants.h

Convert wide strings in extension_{page_actions_module,processes_api}_constants.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3113011
------------------------------------------------------------------------
r55999 | eroman@chromium.org | 2010-08-13 08:16:36 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings_unittest.cc
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc

Emit an event to NetLog whenever the proxy settings change.
Also removes the operator<< on ProxyConfig.

BUG=52004

Review URL: http://codereview.chromium.org/3144008
------------------------------------------------------------------------
r55996 | pfeldman@chromium.org | 2010-08-13 07:21:57 +0200 (Fri, 13 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: re-enable storage panel test.
BUG=51768
TBR=pam

Review URL: http://codereview.chromium.org/3111003
------------------------------------------------------------------------
r55995 | viettrungluu@chromium.org | 2010-08-13 07:16:19 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h

Convert wide strings in extension_tabs_module_constants.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3181010
------------------------------------------------------------------------
r55994 | akalin@chromium.org | 2010-08-13 06:55:17 +0200 (Fri, 13 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/extension_sync.cc
   A /trunk/src/chrome/browser/sync/glue/extension_sync.h
   A /trunk/src/chrome/browser/sync/glue/extension_sync_traits.cc
   A /trunk/src/chrome/browser/sync/glue/extension_sync_traits.h
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util.h
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/chrome_browser.gypi

Massive refactoring of extensions sync code

In preparation for apps sync, refactored out all the common extensions
sync code into extensions_sync_util.{h,cc} and extension_sync_traits.{h,cc}.

BUG=46512
TEST=manual

Review URL: http://codereview.chromium.org/3110008
------------------------------------------------------------------------
r55993 | tfarina@chromium.org | 2010-08-13 06:54:10 +0200 (Fri, 13 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome_frame/crash_reporting/crash_dll.cc
   M /trunk/src/chrome_frame/crash_reporting/crash_dll.h
   M /trunk/src/chrome_frame/crash_reporting/nt_loader_unittest.cc
   M /trunk/src/chrome_frame/crash_reporting/vectored_handler_unittest.cc

Use Environment::SetVar in more places.

Make use of Environment::SetVar API to replace the calls to the
Windows function SetEnvironmentVariable.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3076042
------------------------------------------------------------------------
r55992 | yusukes@chromium.org | 2010-08-13 06:49:53 +0200 (Fri, 13 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.cc

Support input methods on the account creation page (chromeos/login/account_screen.cc) and the registration page (chromeos/login/registration_screen.cc) so that CJK (and many other) language users could enter their first and last names.

Nikita:
Do you know whether input methods should be activated on the registration page or not? In other words, does the page have text fields for first/last names or an address? I couldn't find a HTML file for the registration page...

BUG=chromium-os:2670
TEST=boot the OS, on the login screen switch UI language to simplified Chinese, make sure only "US" keyboard layout is active by clicking the language selector, click the "Create a Google Account Now" link, make sure "US" and "pinyin" are now active, click "<< Back" button on the bottom of the page, make sure only US is active (i.e. pinyin is automatically deactivated.)

Review URL: http://codereview.chromium.org/3126007
------------------------------------------------------------------------
r55991 | viettrungluu@chromium.org | 2010-08-13 06:45:36 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.h

Convert wide strings in extension_web_navigation_api_constants.

BUG=23581
TEST=builds

Review URL: http://codereview.chromium.org/3137008
------------------------------------------------------------------------
r55987 | satorux@chromium.org | 2010-08-13 05:49:09 +0200 (Fri, 13 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Show restart warning when UI language is changed.

Instead of using Javascript alert(), we now show better UI for
users to notify a restart is required for UI language change to take effect,
with restart button.

This is based on the mock attached to
http://crosbug.com/5545

BUG=chromium-os:5545
TEST=manual

Review URL: http://codereview.chromium.org/3121008
Patch from Takayoshi Kochi <kochi@chromium.org>.
------------------------------------------------------------------------
r55986 | zork@chromium.org | 2010-08-13 05:35:54 +0200 (Fri, 13 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Make selectable keyboard layout only one for each language

BUG=chromuim-os:5399
TEST=See bug for details.

Review URL: http://codereview.chromium.org/3146012
Patch from Hitoshi Yoshida <peria@google.com>.
------------------------------------------------------------------------
r55981 | satorux@chromium.org | 2010-08-13 05:15:22 +0200 (Fri, 13 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Implement drag-and-drop for Languages and Input dialog.

With this change, users will be able to reoder the language list
by drag-and-drop.

BUG=chromium-os:5544
TEST=manually

Review URL: http://codereview.chromium.org/3172004
------------------------------------------------------------------------
r55980 | rafaelw@chromium.org | 2010-08-13 04:59:31 +0200 (Fri, 13 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc

Only use Browser::TYPE_NORMAL as the last-chance GetCurrentBrowser for Extension functions.

It was previously accepting any browser type. This was problematic, in particular if the last active browser was a DEVTOOLS window.

BUG=49111
TEST=Verify bug is no longer reproducible

Review URL: http://codereview.chromium.org/3113010
------------------------------------------------------------------------
r55979 | viettrungluu@chromium.org | 2010-08-13 04:45:23 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module_constants.h

Convert wide strings in extension_idle_api_constants and extension_infobar_module_constants.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3160011
------------------------------------------------------------------------
r55977 | viettrungluu@chromium.org | 2010-08-13 04:29:30 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc

Convert wide string constants in extension_bookmarks_module_constants.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3169011
------------------------------------------------------------------------
r55975 | zelidrag@chromium.org | 2010-08-13 03:28:33 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js

Removed incompatible options from ChromeOS version of DOM UI options page.

BUG=chromium-os:5668
TEST=make sure that 'import browser settings' and 'make chrome the default browser' don't show up on ChromeOS in the options (DOM UI)

Review URL: http://codereview.chromium.org/3125008
------------------------------------------------------------------------
r55973 | jerrica@google.com | 2010-08-13 03:01:53 +0200 (Fri, 13 Aug 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/protocol/session_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/net/tools/testserver/chromiumsync.py

sync: Add sessions to protocol and chromiumsync python test server.

BUG=30519
Review URL: http://codereview.chromium.org/3107008
------------------------------------------------------------------------
r55971 | tony@chromium.org | 2010-08-13 02:36:50 +0200 (Fri, 13 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc

Revert "Update panel title to match current mock. The corners become slightly rounded."

This reverts commit r55926.

TBR=davemoore

Review URL: http://codereview.chromium.org/3111004
------------------------------------------------------------------------
r55967 | cdn@chromium.org | 2010-08-13 02:01:34 +0200 (Fri, 13 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc

Fixes a bug in revision 55103 that prevents extensions from loading their own resources in some rare cases when the origin is "null". 

BUG=51702
TEST=None
Review URL: http://codereview.chromium.org/3144003
------------------------------------------------------------------------
r55966 | panayiotis@google.com | 2010-08-13 01:59:51 +0200 (Fri, 13 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Report malware redirectors as well.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/3028040
------------------------------------------------------------------------
r55965 | tony@chromium.org | 2010-08-13 01:44:44 +0200 (Fri, 13 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Migrate some wstring to string16 in chrome/browser/gtk/bookmark*.

BUG=23581

Review URL: http://codereview.chromium.org/3110003
------------------------------------------------------------------------
r55961 | viettrungluu@chromium.org | 2010-08-13 01:31:50 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h

Convert wide strings in extension_cookies_api_constants.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3171007
------------------------------------------------------------------------
r55960 | andybons@chromium.org | 2010-08-13 01:29:32 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

[Mac] Removes artificial location padding logic to fix a bug with browser action transparency.

BUG=51944
TEST=see bug. rightmost extension should not be transparent at all after resizing browser action container.

Review URL: http://codereview.chromium.org/3179011
------------------------------------------------------------------------
r55959 | suzhe@chromium.org | 2010-08-13 01:28:57 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

[Linux] Fix an assert failure when showing popup.

BUG=51834
TEST=Clicking on a selection dropdown should not cause assert failure.

Review URL: http://codereview.chromium.org/3176009
------------------------------------------------------------------------
r55958 | mpcomplete@chromium.org | 2010-08-13 01:23:32 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Mark ExtensionApiTest.Incognito as not FLAKY. According to the flakiness
dashboard, it has been passing consistently.

BUG=42844

Review URL: http://codereview.chromium.org/3095006
------------------------------------------------------------------------
r55957 | jhawkins@chromium.org | 2010-08-13 01:21:01 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/autofill_options.html
   A /trunk/src/chrome/browser/resources/options/autofill_options_page.css
   M /trunk/src/chrome/browser/resources/options.html

DOMUI: Add basic HTML for the AutoFill options page.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3171003
------------------------------------------------------------------------
r55956 | viettrungluu@chromium.org | 2010-08-13 01:17:27 +0200 (Fri, 13 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Get rid of wide string constants in extension_accessibility_api_constants.

BUG=none
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3106007
------------------------------------------------------------------------
r55951 | twiz@google.com | 2010-08-12 23:24:59 +0200 (Thu, 12 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/applescript/window_applescript.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/platform_util_chromeos.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tab_contents/match_preview.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc


Clone of issue 2941001.  See initial review below.

http://codereview.chromium.org/2941001

Initial submit broke the chromeos build.  This patch includes the original change, and fixes to compile ChromeOs properly.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/2819086
------------------------------------------------------------------------
r55949 | mark@chromium.org | 2010-08-12 23:22:09 +0200 (Thu, 12 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

10.6 SDK compatibility fix for GradientButtonCell following r55906.

See r26348, "Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize
conversions": The SDK has gotten stupider in 10.6, and has conspired with the
compiler, which now thinks that when the receiver is held in a scoped_nsobject,
NSColor and NSSize arguments should be converted to their CG cousins.

BUG=51430
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/3162008
------------------------------------------------------------------------
r55947 | feldstein@chromium.org | 2010-08-12 23:19:21 +0200 (Thu, 12 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.h
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.h

Fix Translate bar crashers

Disable the options menu divider so we don't fire an invalid command.

the translate bar was crashing when you would use
the context menu to translate a page with an unknown language.  It was trying to
instantiate an options menu model when it didn't need one, or have a language to
populate it with.  This makes it so the options menu model is not instantiated
unless it needs it, and it only needs it when it actually knows the language.

BUG=47303
TEST=see bug.

Review URL: http://codereview.chromium.org/3080035
------------------------------------------------------------------------
r55946 | andybons@chromium.org | 2010-08-12 23:19:08 +0200 (Thu, 12 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm
   M /trunk/src/chrome/browser/cocoa/applescript/browsercrapplication+applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/browsercrapplication+applescript_test.mm
   A /trunk/src/chrome/browser/cocoa/applescript/examples
   A /trunk/src/chrome/browser/cocoa/applescript/examples/app_info.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/bookmark_current_tabs.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/quit_app.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/tab_navigation.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/window_creation.applescript
   A /trunk/src/chrome/browser/cocoa/applescript/examples/window_operations.applescript
   M /trunk/src/chrome/browser/cocoa/applescript/scripting.sdef
   M /trunk/src/chrome/browser/cocoa/applescript/window_applescript.mm
   M /trunk/src/chrome/browser/cocoa/applescript/window_applescript_test.mm
   M /trunk/src/chrome/chrome_tests.gypi

Removed a command which resulted in a crash.
Removed Unnescessary code and also refactored some.
Added tests.
Added example AppleScripts.

original patch from shreyas.

BUG=none
TEST=updates some unit tests and adds some.
Review URL: http://codereview.chromium.org/3163008
------------------------------------------------------------------------
r55940 | stuartmorgan@chromium.org | 2010-08-12 22:55:48 +0200 (Thu, 12 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.css
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html

Revert 55881 - DOM-UI Options: Disable the 'Clear browsing Data' button when no checkboxes are checked.

BUG=49037
TEST=out/Debug/chrome --enable-tabbed-options. Go to 'Under the Hood' tab, open the
dialog, check some checkbox, the button should become enabled, uncheck all the
checkboxes, the button should become disabled.

Review URL: http://codereview.chromium.org/3155001

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/3172012
------------------------------------------------------------------------
r55933 | huanr@chromium.org | 2010-08-12 22:40:36 +0200 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Looks like both VideoBearTheora and VideoBearSilentTheora
are crashy.

BUG=51969
TEST=MediaTest.*

Review URL: http://codereview.chromium.org/3155010
------------------------------------------------------------------------
r55932 | nshkrob@chromium.org | 2010-08-12 22:38:49 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/tools/valgrind/tsan/suppressions.txt

Fix race conditions in TopSites.

BUG=51890
TEST=tsan ui_tests

Review URL: http://codereview.chromium.org/3158010
------------------------------------------------------------------------
r55931 | evan@chromium.org | 2010-08-12 22:31:13 +0200 (Thu, 12 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/jumplist_win.cc

CommandLine: remove three useless functions.

PrefixedSwitchString was full of encoding conversions, but there was only one
real caller, and the function is trivial.

Terminate is leftover cruft.

TEST=compiles

Review URL: http://codereview.chromium.org/3138001
------------------------------------------------------------------------
r55930 | rafaelw@chromium.org | 2010-08-12 22:27:09 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Disallow fullscreen for app-panels

BUG=42676
TEST=Hit F11 while an app panel is open. It should not be maximized

Review URL: http://codereview.chromium.org/3074033
------------------------------------------------------------------------
r55927 | sargrass@google.com | 2010-08-12 22:24:17 +0200 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js

Display saved login entries in Passwords and Exceptions subpage
Removed a unused header

BUG=49093
TEST=None

Review URL: http://codereview.chromium.org/3029065
------------------------------------------------------------------------
r55926 | davemoore@chromium.org | 2010-08-12 22:22:30 +0200 (Thu, 12 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc

Update panel title to match current mock. The corners become slightly rounded.
This will look a bit broken until the window manager changes its shadows to
match.
BUG=chromiumos:5156
TEST=Panels should have rounded corners, cleaner spacing of ui elements, and
     shouldn't change when they have the focus.

Review URL: http://codereview.chromium.org/3091009
------------------------------------------------------------------------
r55921 | erikkay@chromium.org | 2010-08-12 22:12:42 +0200 (Thu, 12 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   D /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   D /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   D /trunk/src/chrome/browser/extensions/extension_shelf_model_browsertest.cc
   D /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   D /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   D /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   D /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/view_ids.h
   D /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   D /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/view_types.cc
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   D /trunk/src/chrome/renderer/resources/extension_toolstrip.css
   M /trunk/src/chrome/test/data/extensions/api_test/README.txt
   D /trunk/src/chrome/test/data/extensions/api_test/toolstrip/folder/relative.html
   D /trunk/src/chrome/test/data/extensions/api_test/toolstrip/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/toolstrip/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/toolstrip/test2.html
   A /trunk/src/chrome/test/data/extensions/browsertest/last_error/bg.html (from /trunk/src/chrome/test/data/extensions/browsertest/last_error/toolstrip.html:55918)
   M /trunk/src/chrome/test/data/extensions/browsertest/last_error/manifest.json
   D /trunk/src/chrome/test/data/extensions/browsertest/last_error/toolstrip.html
   D /trunk/src/chrome/test/data/extensions/common/one_in_shelf/manifest.json
   D /trunk/src/chrome/test/data/extensions/common/one_in_shelf/shelf.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   D /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html
   M /trunk/src/chrome/test/data/extensions/good/Preferences
   D /trunk/src/chrome/test/data/extensions/profiles/toolstrips1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/profiles/toolstrips1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   D /trunk/src/chrome/test/data/extensions/profiles/toolstrips1/Default/Preferences
   D /trunk/src/chrome/test/data/extensions/profiles/toolstrips50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/profiles/toolstrips50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   D /trunk/src/chrome/test/data/extensions/profiles/toolstrips50/Default/Preferences
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/test_browser_window.h

remove toolstrips

BUG=51703
BUG=30178
BUG=25106
TEST=none

Review URL: http://codereview.chromium.org/3129003
------------------------------------------------------------------------
r55920 | huanr@chromium.org | 2010-08-12 22:10:11 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Mark MediaTest.VideoBearSilentTheora as flaky.

BUG=51969
TEST=MediaTest.VideoBearSilentTheora

Review URL: http://codereview.chromium.org/3155009
------------------------------------------------------------------------
r55918 | satish@chromium.org | 2010-08-12 21:57:31 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/speech/speech_recognizer.cc
   A /trunk/src/chrome/browser/speech/speech_recognizer.h
   A /trunk/src/chrome/browser/speech/speech_recognizer_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds SpeechRecognizer which provides a simple interface to record and recognize speech.
Also added a unit test for checking the callbacks fire as expected.
TEST=unit_tests --gtest_filter=SpeechRecognizerTest.*
BUG=none

Review URL: http://codereview.chromium.org/3124009
------------------------------------------------------------------------
r55915 | chocobo@chromium.org | 2010-08-12 21:47:47 +0200 (Thu, 12 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options_page.css

If ethernet is not available (i.e. no wired nic), don't show ethernet in status menu, about:networks, and options pages.
Also fixed a small issue where we should not be displaying "Other..." if wifi is disabled.
BUG=chromium-os:5570
TEST=manual
Review URL: http://codereview.chromium.org/3108011
------------------------------------------------------------------------
r55912 | mad@google.com | 2010-08-12 21:43:51 +0200 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.h
   M /trunk/src/chrome/chrome_browser.gypi

Add constant values for the webNavigation API.

for yzshen's http://codereview.chromium.org/3117011/show

BUG=50943
TEST=none
Review URL: http://codereview.chromium.org/3131014
------------------------------------------------------------------------
r55909 | aa@chromium.org | 2010-08-12 20:24:57 +0200 (Thu, 12 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/app_process/manifest.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/disallow_hybrid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/disallow_hybrid_2.json

Reland r55750. Broke AppApiTest.*.

TBR=mpcomplete@chromium.org
BUG=49234
------------------------------------------------------------------------
r55907 | jcivelli@chromium.org | 2010-08-12 20:08:44 +0200 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/views/window/window_gtk.cc

Implement BrowserWindow deactivate on Linux (views and GTK).
This is needed for pages to be able to deactivate the browser's or popup windows with window.blur().

BUG=51364
TEST=Open a page that calls window.blur(), it should move the browser window to the back of the Z order.

Review URL: http://codereview.chromium.org/3159007
------------------------------------------------------------------------
r55906 | andybons@chromium.org | 2010-08-12 20:04:17 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

[Mac] Fix aesthetic issues with themes given the new TopChrome changes.
o Just use the provided toolbar background color as the "highlight" color in most cases and don't draw a bevel on the templated buttons.

BUG=51430
TEST=see bug. make sure no jank.
Review URL: http://codereview.chromium.org/3140009
------------------------------------------------------------------------
r55902 | erg@google.com | 2010-08-12 19:48:54 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/plugin_messages.cc
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/webkit_param_traits.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/renderer_webcookiejar_impl.cc
   M /trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/ipc/ipc_send_fds_test.cc

FBTF: Remove all the easy headers from *_messages.h.

BUG=51411
TEST=compiles

Review URL: http://codereview.chromium.org/3174002
------------------------------------------------------------------------
r55901 | jhawkins@chromium.org | 2010-08-12 19:45:19 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc

gtk: Fix placement of the cursor in the credit card number field.

BUG=51847
TEST=none

Review URL: http://codereview.chromium.org/3141010
------------------------------------------------------------------------
r55900 | mmenke@chromium.org | 2010-08-12 19:38:16 +0200 (Thu, 12 Aug 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/requestsview.js
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/net/base/forwarding_net_log.cc

Net-internal's Javascript code no longer requires all enties have a unique source id.  It will assign entries with a source type of NONE their own unique negative id, which will never be displayed.

Also, the id column in the Requests tab is now right-aligned.

BUG= 48806
TEST= Run chromium while your ip address changes.
  Alternatively, add the following code to
  ConnectJob::LogConnectStart(), or somewhere else
  that looks promising:

    net_log().net_log()->AddEntry(net::NetLog::TYPE_NETWORK_IP_ADDRESSSES_CHANGED,
        base::TimeTicks::Now(),
        net::NetLog::Source(),
        net::NetLog::PHASE_NONE,
        NULL);

Review URL: http://codereview.chromium.org/2883061
------------------------------------------------------------------------
r55898 | viettrungluu@chromium.org | 2010-08-12 19:27:12 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Get rid of a few more wide strings.

BUG=23581
TEST=builds

Review URL: http://codereview.chromium.org/3136007
------------------------------------------------------------------------
r55891 | bauerb@chromium.org | 2010-08-12 18:14:22 +0200 (Thu, 12 Aug 2010) | 20 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.h
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc
   M /trunk/src/chrome/browser/views/content_setting_bubble_views.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h

Revert 55888: Allow per-plugin content settings.

Run with --enable-resource-content-settings and --enable-click-to-play to enable.

TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.

The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.

Screenshot of the plugin bubble: ﻿http://imgur.com/6npqv.png

Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.

XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.

BUG=39252,38432
TEST=manual

Review URL: http://codereview.chromium.org/2873104

TBR: bauerb@chromium.org
------------------------------------------------------------------------
r55889 | viettrungluu@chromium.org | 2010-08-12 17:56:08 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/customization_document.cc

Turn a bunch of wchar_t* dictionary keys (in CrOS) into char* keys.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3132007
------------------------------------------------------------------------
r55888 | bauerb@chromium.org | 2010-08-12 17:36:59 +0200 (Thu, 12 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.h
   M /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc
   M /trunk/src/chrome/browser/views/content_setting_bubble_views.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h

Allow per-plugin content settings.

Run with --enable-resource-content-settings and --enable-click-to-play to enable.

TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.

The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.

Screenshot of the plugin bubble: ﻿http://imgur.com/6npqv.png

Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.

XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.

BUG=39252,38432
TEST=manual

Review URL: http://codereview.chromium.org/2873104
------------------------------------------------------------------------
r55885 | glotov@chromium.org | 2010-08-12 16:59:42 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h

Prefrence policy is honored for changing crash reporting state.

BUG=chromium-os:2884 
TEST=none 

Review URL: http://codereview.chromium.org/3072029
------------------------------------------------------------------------
r55881 | tfarina@chromium.org | 2010-08-12 15:36:14 +0200 (Thu, 12 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.css
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html

DOM-UI Options: Disable the 'Clear browsing Data' button when no checkboxes are checked.

BUG=49037
TEST=out/Debug/chrome --enable-tabbed-options. Go to 'Under the Hood' tab, open the
dialog, check some checkbox, the button should become enabled, uncheck all the
checkboxes, the button should become disabled.

Review URL: http://codereview.chromium.org/3155001
------------------------------------------------------------------------
r55877 | avayvod@chromium.org | 2010-08-12 14:16:01 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h

Set logged in user image when image is selected.

BUG=chromium-os:5636
TEST=See instructions in the bug.

Review URL: http://codereview.chromium.org/3122011
------------------------------------------------------------------------
r55872 | bauerb@chromium.org | 2010-08-12 13:20:56 +0200 (Thu, 12 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentBlockedCookies.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedImages.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedJavaScript.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPopups.xib
   M /trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib
   D /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   D /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   D /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.h (from /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h:55871)
   A /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa.mm (from /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm:55871)
   A /trunk/src/chrome/browser/cocoa/content_setting_bubble_cocoa_unittest.mm (from /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm:55871)
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   D /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   D /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h
   A /trunk/src/chrome/browser/views/content_setting_bubble_views.cc (from /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc:55871)
   A /trunk/src/chrome/browser/views/content_setting_bubble_views.h (from /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h:55871)
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Use a sane naming scheme for content setting bubble classes.

I'm renaming the platform-specific content setting bubble classes to the uniform naming scheme content_setting_bubble_{views,gtk,cocoa}.{h,cc}

XIB changes: Rename ContentBlockedBubbleController in ContentBlocked*.xib to ContentSettingBubbleController.

BUG=none
TEST=everything compiles

Review URL: http://codereview.chromium.org/3099002
------------------------------------------------------------------------
r55870 | yusukes@chromium.org | 2010-08-12 12:40:04 +0200 (Thu, 12 Aug 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add prefs for the DOMUI version of "Customize modifier keys" dialog.

Mazda: In your DOMUI html, please set the integers defined in chromeos_keyboard.h:

  enum ModifierKey {
    kSearchKey = 0,
    kLeftControlKey,
    kLeftAltKey,
    kVoidKey,
    kCapsLockKey,

    kNumModifierKeys,
  };

to the following integer prefs:

  prefs::kLanguageXkbRemapSearchKeyTo
  prefs::kLanguageXkbRemapControlKeyTo
  prefs::kLanguageXkbRemapAltKeyTo

BUG=chromium-os:5152
TEST=manually

Review URL: http://codereview.chromium.org/3141011
------------------------------------------------------------------------
r55867 | joth@chromium.org | 2010-08-12 12:09:21 +0200 (Thu, 12 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.h
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/cros/syslogs_library.h
   M /trunk/src/chrome/browser/chromeos/cros/system_library.h
   M /trunk/src/chrome/browser/chromeos/cros/update_library.h

Fix cros library documentation:
- make it consistent in how to get an instance of the API classes
- remove duplicate (and obsolete) copies of the docs from .cc files, mocks etc.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3050049
------------------------------------------------------------------------
r55859 | bulach@chromium.org | 2010-08-12 11:15:20 +0200 (Thu, 12 Aug 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/indexeddb
   A /trunk/src/chrome/test/data/indexeddb/common.js
   A /trunk/src/chrome/test/data/indexeddb/cursor_test.html
   A /trunk/src/chrome/test/data/indexeddb/cursor_test.js

Adds a browser_test for IndexedDB.
TEST=indexed_db_browsertest.cc

Review URL: http://codereview.chromium.org/3061057
------------------------------------------------------------------------
r55857 | yusukes@chromium.org | 2010-08-12 10:43:23 +0200 (Thu, 12 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

Add the Resource ID of the keyboard layout(xkb:bg:phonetic:bul)

Patch from <nhiroki@google.com>.

BUG=chromium-os:5284
TEST=manual

Review URL: http://codereview.chromium.org/3179008
Patch from Hiroki Nakagawa <nhiroki@google.com>.
------------------------------------------------------------------------
r55853 | viettrungluu@chromium.org | 2010-08-12 08:50:54 +0200 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Try to fix CrOS build (probelm with r55848), part 2.

BUG=23581
TEST=builds
TBR=viettrungluu@chromium.org,brettw@chromium.org

Review URL: http://codereview.chromium.org/3130011
------------------------------------------------------------------------
r55852 | viettrungluu@chromium.org | 2010-08-12 08:39:39 +0200 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/apply_services_customization.cc

Fix r55848 (Chrome OS build failure).

BUG=23581
TEST=builds on Chrome OS
TBR=viettrungluu@chromium.org,brettw@chromium.org

Review URL: http://codereview.chromium.org/3129009
------------------------------------------------------------------------
r55848 | viettrungluu@chromium.org | 2010-08-12 07:54:34 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/language_combobox_model.h
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Remove wchar_t* methods from prefs.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3136004
------------------------------------------------------------------------
r55843 | satorux@chromium.org | 2010-08-12 05:57:51 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js

Fix a bug that caused the lead index to always move to the first item after removing a langauge.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3152005
------------------------------------------------------------------------
r55842 | viettrungluu@chromium.org | 2010-08-12 05:32:53 +0200 (Thu, 12 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/low_battery_observer.cc
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/common/time_format.h
   M /trunk/src/chrome/common/time_format_unittest.cc

Convert TimeFormat (chrome/common/time_format.*) to string16 (from wstring).

(Also do some drive-bys.)

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3165009
------------------------------------------------------------------------
r55838 | mirandac@chromium.org | 2010-08-12 04:45:12 +0200 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc

Copyright change to kick off new build.

TBR=lzheng@chromium.org

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3122010
------------------------------------------------------------------------
r55835 | chron@chromium.org | 2010-08-12 04:10:46 +0200 (Thu, 12 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_x_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   A /trunk/src/chrome/test/signaling_task.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Add token serialization to token_service.
The token service now supports serialization of tokens into the web database. The token service doesn't actually know the email of the user though, and it's assumed that whoever is using the token service does. Not sure whether that's a bad choice or not, open to suggestions.

This CL adds a new DB table.

Design comments / corrections are welcome. Testing in Chromium OS is in progress and not yet done. This CL will not be submitted prior to more Chromium OS testing.

BUG=47092,47093
TEST=Unit tests included

Review URL: http://codereview.chromium.org/3061025
------------------------------------------------------------------------
r55834 | zork@chromium.org | 2010-08-12 04:08:48 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Bug fix: Reset keyboard layout to hardware keyboard when IME is killed.

BUG=chromium-os:5224
TEST=See bug for details

Review URL: http://codereview.chromium.org/3113009
------------------------------------------------------------------------
r55832 | satorux@chromium.org | 2010-08-12 03:56:24 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.html

Add instructions in the Languages and Input dialog per a mock from UX.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3117003
------------------------------------------------------------------------
r55829 | lzheng@chromium.org | 2010-08-12 03:46:15 +0200 (Thu, 12 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc


Mark NaClPermissionEnabled as flaky.
BUG=51861
TEST=NONE
Review URL: http://codereview.chromium.org/3148008
------------------------------------------------------------------------
r55827 | yusukes@chromium.org | 2010-08-12 03:28:00 +0200 (Thu, 12 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html

Implement DOMUI version of key repeat options.

Added "Keyboard" section to chromeos_system_options.html which has the following:
- "Repeat keys" checkbox.
- "Key repeat delay" slider.
- "Key repeat speed" slider.

This CL depends on http://codereview.chromium.org/3023044/.

BUG=chromium-os:5481
TEST=manually

Review URL: http://codereview.chromium.org/3154002
------------------------------------------------------------------------
r55826 | hclam@chromium.org | 2010-08-12 03:07:24 +0200 (Thu, 12 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/service
   A /trunk/src/chrome/browser/service/service_process_control.cc
   A /trunk/src/chrome/browser/service/service_process_control.h
   A /trunk/src/chrome/browser/service/service_process_control_browsertest.cc
   A /trunk/src/chrome/browser/service/service_process_control_manager.cc
   A /trunk/src/chrome/browser/service/service_process_control_manager.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/service_messages_internal.h
   A /trunk/src/chrome/common/service_process_type.h
   A /trunk/src/chrome/common/service_process_util.cc
   A /trunk/src/chrome/common/service_process_util.h
   M /trunk/src/chrome/service/service_ipc_server.cc
   M /trunk/src/chrome/service/service_ipc_server.h
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/chrome/service/service_process.h

ServiceProcessControl to launch a service process and communicate through IPC.

Added two class for use with service process:

ServiceProcessControl
Used by the browser to launch and connect to the service process, also used
to receive messages from the service process.

ServiceProcessControlManager
A singleton to manage multiple ServicProcessControl.

BUG=50244
TEST=browser_tests --gtest_filter=ServiceProcess*

Review URL: http://codereview.chromium.org/3032061
------------------------------------------------------------------------
r55823 | tfarina@chromium.org | 2010-08-12 02:47:09 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

Use GetTitleAsString16 instead of GetTitle that returns std::wstring.

BUG=23581
TEST=trybots

Review URL: http://codereview.chromium.org/3073030
------------------------------------------------------------------------
r55822 | chaitanyag@chromium.org | 2010-08-12 02:40:22 +0200 (Thu, 12 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api.cc
   A /trunk/src/chrome/browser/extensions/extension_tts_api.h
   A /trunk/src/chrome/browser/extensions/extension_tts_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/tts
   A /trunk/src/chrome/test/data/extensions/api_test/tts/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tts/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/tts/test.js

Adding tts experimental extensions api
Review URL: http://codereview.chromium.org/2969005
------------------------------------------------------------------------
r55821 | erg@google.com | 2010-08-12 02:40:14 +0200 (Thu, 12 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/o3d/samples/o3d-webgl-samples/bubbles/third_party/jquery/AUTHORS.txt
   M /trunk/src/o3d/samples/o3d-webgl-samples/bubbles/third_party/jquery/MIT-LICENSE.txt
   M /trunk/src/o3d/samples/o3d-webgl-samples/bubbles/third_party/jquery/jquery-1.4.2.min.js
   M /trunk/src/o3d/samples/o3d-webgl-samples/bubbles/third_party/jquery/jquery-ui-1.8.4.custom.min.js

Fix permissions to fix broken chromium tree.

TBR=luchen,mirandac

Review URL: http://codereview.chromium.org/3171004
------------------------------------------------------------------------
r55815 | hclam@chromium.org | 2010-08-12 02:18:32 +0200 (Thu, 12 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/remoting
   A /trunk/src/chrome/browser/remoting/setup.cc
   A /trunk/src/chrome/browser/remoting/setup.h
   A /trunk/src/chrome/browser/remoting/setup_flow.cc
   A /trunk/src/chrome/browser/remoting/setup_flow.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi

Adding remoting setup to wrench menu

pranvak@ is OOO so I'm submitting for him.

This patch will add a menu in wrench menu to start the chromoting
setup flow.

Submit for: pranvak@chromium.org
Reviewed: http://codereview.chromium.org/3075024/show

Review URL: http://codereview.chromium.org/3134003
------------------------------------------------------------------------
r55808 | tim@chromium.org | 2010-08-12 01:25:35 +0200 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

sync: dont synchronously check server reachability during syncapi init

BUG=51742
TEST=start sync enabled chrome with/without network. connect/disconnect network.  upcoming offline startup integration tests will cover this

Review URL: http://codereview.chromium.org/3177004
------------------------------------------------------------------------
r55806 | ziadh@chromium.org | 2010-08-12 00:46:57 +0200 (Thu, 12 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Revert 55797 - Disable support of --enable-preconnect flag

The preconenct feature is still not fully implemented yet. We would like to
disable it for M6 as it is causing crashes. This is a temporary 'fix'.

BUG=48549
r=jar

Review URL: http://codereview.chromium.org/3140007

TBR=ziadh@chromium.org
Review URL: http://codereview.chromium.org/3161007
------------------------------------------------------------------------
r55799 | estade@chromium.org | 2010-08-12 00:20:53 +0200 (Thu, 12 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.cc

GTK: minor MenuBarHelper fix.

If one of the buttons is not realized, gtk_widget_translate_coordinates() will fail on it. Instead of aborting, just skip to the next button. This can happen when opening a new window with a bookmark bar that doesn't have an overflow chevron (when the chevron has not been shown, it will be unrealized).

BUG=51810
TESt=see bug + above description

Review URL: http://codereview.chromium.org/3175006
------------------------------------------------------------------------
r55797 | ziadh@chromium.org | 2010-08-11 23:57:53 +0200 (Wed, 11 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Disable support of --enable-preconnect flag

The preconenct feature is still not fully implemented yet. We would like to
disable it for M6 as it is causing crashes. This is a temporary 'fix'.

BUG=48549
r=jar

Review URL: http://codereview.chromium.org/3140007
------------------------------------------------------------------------
r55792 | erg@google.com | 2010-08-11 23:41:57 +0200 (Wed, 11 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc

Extension package creation cleanup

Unify extension package creation code between command line and GUI methods.

Properly handle extension names with periods or trailing slashes.

Don't DCHECK when creating packages from the command line.

BUG=14720, 19103, 51110
TEST=run 'chrome --pack-extension=has.a.dot/' on an extension with period in its name; make sure it is packed correctly and a message indicating success is printed.

Review URL: http://codereview.chromium.org/3077022
Patch from Ilya Sherman <isherman@google.com>.
------------------------------------------------------------------------
r55791 | dtseng@chromium.org | 2010-08-11 23:41:46 +0200 (Wed, 11 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Hook back up the overriding of AXDescriptions.  Note that the referenced bug doesn't seem to affect the usage of the method.
BUG=none
TEST=use VoiceOver to verify text reads when navigated to.
Review URL: http://codereview.chromium.org/3153003
------------------------------------------------------------------------
r55785 | avi@chromium.org | 2010-08-11 23:16:25 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_mac_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc

Add support for Value::TYPE_LIST policies for the Mac.

BUG=51688
TEST=unit tested

Review URL: http://codereview.chromium.org/3124013
------------------------------------------------------------------------
r55783 | estade@chromium.org | 2010-08-11 23:04:05 +0200 (Wed, 11 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js

Tabbed content settings:

- do nothing for empty edits
- double click to edit
- fix escape handling
 - deletes row if it's empty (i.e. new)
 - pressing escape with an invalid input now works

BUG=48862
TEST=all the above

Review URL: http://codereview.chromium.org/3128003
------------------------------------------------------------------------
r55781 | dhollowa@chromium.org | 2010-08-11 23:03:29 +0200 (Wed, 11 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Autocomplete entries submitted are limited in number.

Limits the number of Autocomplete entries added to the WebDB, per form submission, to a maximum of 256.  If elements occur that have duplicate names, only the first occurrence is added.

BUG=51727
TEST=WebDatabaseTest.Autofill_AddFormFieldValues

Review URL: http://codereview.chromium.org/3143005
------------------------------------------------------------------------
r55780 | erg@google.com | 2010-08-11 23:02:35 +0200 (Wed, 11 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_queue_unittest.cc
   M /trunk/src/net/http/http_auth_controller.cc
   M /trunk/src/net/http/http_auth_controller.h
   M /trunk/src/net/http/http_basic_stream.cc
   M /trunk/src/net/http/http_basic_stream.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket.cc
   M /trunk/src/net/http/http_request_headers.cc
   M /trunk/src/net/http/http_request_headers.h
   M /trunk/src/net/http/http_response_info.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/http/http_stream_parser.cc
   M /trunk/src/net/http/http_stream_parser.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_pool.cc
   M /trunk/src/net/socket_stream/socket_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_http_stream.cc
   M /trunk/src/net/websockets/websocket_handshake_handler.cc
   M /trunk/src/net/websockets/websocket_handshake_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_response_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/appcache_url_request_job.cc
   M /trunk/src/webkit/appcache/appcache_url_request_job_unittest.cc

FBTF: Start cleaning up net/

url_request.h and http_response_info.h are some of the most included headers from net/
in chrome. Do what forward declaration we can in those headers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3150003
------------------------------------------------------------------------
r55777 | jcivelli@chromium.org | 2010-08-11 22:49:44 +0200 (Wed, 11 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/options_menu_model.cc

Don't show preference related menus in the translate infobar in incognito mode.

BUG=51214
TEST=Navigate in a non incognito window to www.google.de. The translate infobar should show. The options menu should have options to always/never translate german.
     Navigate again to that page but from an incognito window, the options menu in the translate infobar should not have any preference (always/never translate) related items.

Review URL: http://codereview.chromium.org/3073025
------------------------------------------------------------------------
r55775 | gregoryd@google.com | 2010-08-11 22:48:28 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/nacl_enabled
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/nacl_enabled/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/nacl_enabled/manifest.json

Add a test for "native_client" permission for extensions.
BUG=45881
TEST=this CL

Review URL: http://codereview.chromium.org/3064048
------------------------------------------------------------------------
r55773 | michaeln@chromium.org | 2010-08-11 22:47:32 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/webkit/appcache/appcache_storage.cc

Provide a profile.GetAppCacheService() accessor and add two helper methods to ChromeAppCacheService to override the default quota for an origin.

BUG=49993
TESTS=existing tests apply

Review URL: http://codereview.chromium.org/2819091
------------------------------------------------------------------------
r55771 | agl@chromium.org | 2010-08-11 21:50:02 +0200 (Wed, 11 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/dns_util.h
   A /trunk/src/net/base/dnssec_chain_verifier.cc
   A /trunk/src/net/base/dnssec_chain_verifier.h
   A /trunk/src/net/base/dnssec_keyset.cc
   A /trunk/src/net/base/dnssec_keyset.h
   A /trunk/src/net/base/dnssec_unittest.cc
   M /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_defaults.h
   M /trunk/src/net/base/ssl_config_service_mac.cc
   M /trunk/src/net/base/ssl_config_service_win.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h

net: add embedded DNSSEC chain support.

Now that the DNS root is signed we have a good trust path in several
TLDs (including .org). This patch enables self-signed certificates to
include a DNSSEC chain as an extension which proves a CERT record,
containing the fingerprint of the public key.

The format of the chain is still undecided, so this is only enabled
with --enable-dnssec-certs.

BUG=none
TEST=net_unittests

http://codereview.chromium.org/2806076
------------------------------------------------------------------------
r55768 | davidben@chromium.org | 2010-08-11 21:33:40 +0200 (Wed, 11 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.h
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.mm
   M /trunk/src/chrome/browser/cocoa/ssl_client_certificate_selector.mm
   M /trunk/src/chrome/browser/ssl_client_certificate_selector.h

Implement a tab-modal constrained sheet on OS X for certificate selection

R=thakis
BUG=50710
TEST=SSL client auth on OS X still works

Review URL: http://codereview.chromium.org/3050028
------------------------------------------------------------------------
r55765 | lzheng@chromium.org | 2010-08-11 21:13:42 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable ageActionRefreshCrash on windows.

BUG=51814
TEST=NONE

Review URL: http://codereview.chromium.org/3153005
------------------------------------------------------------------------
r55764 | kbr@google.com | 2010-08-11 20:57:12 +0200 (Wed, 11 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

Enable GLSL shader translator by default. With this change, Chrome's
WebGL implementation requires GLSL ES compliant shaders. Now pass
--disable-glsl-translator on command line to disable the translator.

BUG=none
TEST=ran WebGL demos

Review URL: http://codereview.chromium.org/3121005
------------------------------------------------------------------------
r55761 | aa@chromium.org | 2010-08-11 20:47:01 +0200 (Wed, 11 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   D /trunk/src/chrome/test/data/extensions/manifest_tests/disallow_hybrid_1.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/disallow_hybrid_2.json

Revert r55750

TBR=mirandac@chromium.org
------------------------------------------------------------------------
r55758 | rsesek@chromium.org | 2010-08-11 20:25:39 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_button_cell.mm

Use |+selectedMenuItemColor| for the highlighted state.  This respects the system tint.

BUG=none
TEST=On 10.5 and 10.6, the Wrench menu buttons have a blue or gray pressed state, depending on Appearance prefs.

Review URL: http://codereview.chromium.org/3152006
------------------------------------------------------------------------
r55751 | davej@chromium.org | 2010-08-11 19:42:57 +0200 (Wed, 11 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/audio_handler.cc
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.cc
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.h

Improved thread safety
Before these fixes, if PulseAudio was installed, but had no devices, one of the callbacks could hang indefinitely.  If told to shut down before initialization had completed, weird things may have happened.  Now the mixer can be shut down at any time, and can handle requests safely from different threads.

BUG=5141
TEST=Make sure the "E: mutex-posic.c" assertion is no longer appearing in build-bot logs

Review URL: http://codereview.chromium.org/3069025
------------------------------------------------------------------------
r55750 | aa@chromium.org | 2010-08-11 19:38:56 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   A /trunk/src/chrome/test/data/extensions/manifest_tests/disallow_hybrid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/disallow_hybrid_2.json

Forbid hybrid apps.

BUG=49234

Review URL: http://codereview.chromium.org/3123004
------------------------------------------------------------------------
r55749 | erg@google.com | 2010-08-11 19:36:32 +0200 (Wed, 11 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_unittest.cc
   A /trunk/src/chrome/common/webkit_param_traits.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc

Reapplies r55735, fixing some message code that was checked in that I collided with.

BUG=51411
TEST=none
TBR=mpcomplete

Review URL: http://codereview.chromium.org/3118009
------------------------------------------------------------------------
r55738 | erg@google.com | 2010-08-11 18:52:42 +0200 (Wed, 11 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_unittest.cc
   D /trunk/src/chrome/common/webkit_param_traits.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc

Revert "FBTF: Allow forward declaration of classes passed to sync IPC messages."

This reverts commit r55735.

BUG=none
TEST=none
TBR=mirandac

Review URL: http://codereview.chromium.org/3152007
------------------------------------------------------------------------
r55735 | erg@google.com | 2010-08-11 18:38:22 +0200 (Wed, 11 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_unittest.cc
   A /trunk/src/chrome/common/webkit_param_traits.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc

FBTF: Allow forward declaration of classes passed to sync IPC messages.

This is a continuation of r55259, where we convert the remaining IPC messages
to the new system. At this point, all the messages should be able to accept
forward declared classes/structs as parameters.

BUG=51411
TEST=none

Review URL: http://codereview.chromium.org/3018045
------------------------------------------------------------------------
r55733 | sky@chromium.org | 2010-08-11 18:27:25 +0200 (Wed, 11 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

Lands http://codereview.chromium.org/2878087 for Alex:

Remove menu_gtk from the link for TOOLKIT_VIEWS builds.

BUG=none
TEST=manually, both with TOOLKIT_VIEWS=1 and TOOLKIT_VIEWS=0

Review URL: http://codereview.chromium.org/3130005
------------------------------------------------------------------------
r55727 | finnur@chromium.org | 2010-08-11 16:56:36 +0200 (Wed, 11 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_store.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/policy_constants.cc
   M /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Implement admin control (by policy) over which extensions the user can install and run. Currently we intercept in two locations: 

1) When the user tries to install an extension (includes error message). 
2) Every time the browser starts up and the currently installed extensions are loaded (silently skips the extension). 

I implemented a whitelist and a blacklist approach, calling it a allow/deny list to not clash with the global blacklist we have for extensions. A blacklist of '*' means all extensions are blacklisted. If an extension is on the blacklist it cannot be installed/loaded, unless it also appears on the whitelist. 

I also fleshed out the LIST_TYPE support for policy values, so that we don't have to use comma separated REG_SZ values for lists and can instead use ADM support for listboxes. 

BUG=47085
TEST=ExtensionsServiceTest.BlacklistedByPolicyWillNotInstall, ConfigurationPolicyProviderWinTest.TestExtensionInstall*

Review URL: http://codereview.chromium.org/3014053
------------------------------------------------------------------------
r55724 | hans@chromium.org | 2010-08-11 16:42:53 +0200 (Wed, 11 Aug 2010) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/device_orientation/device_orientation_browsertest.cc
   A /trunk/src/chrome/browser/device_orientation/dispatcher_host.cc
   A /trunk/src/chrome/browser/device_orientation/dispatcher_host.h
   A /trunk/src/chrome/browser/device_orientation/orientation.h
   A /trunk/src/chrome/browser/device_orientation/provider.cc
   A /trunk/src/chrome/browser/device_orientation/provider.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/device_orientation_dispatcher.cc
   A /trunk/src/chrome/renderer/device_orientation_dispatcher.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/device_orientation/device_orientation_test.html

Chromium plumbing for Device Orientation.

Add the plumbing needed for communicating with the Device Orientation code in WebKit.

RenderView provides an implementation of WebKit::WebDeviceOrientationClient: DeviceOrientationDispatcher. This communicates with the browser-side class device_orientation::DispatcherHost.

device_orientation::Provider, responsible for providing the orientation data, is just an empty shell for now.

BUG=44654
TEST=browser_tests --gtest_filter=DeviceOrientationBrowserTest.BasicTest

Review URL: http://codereview.chromium.org/2858049
------------------------------------------------------------------------
r55723 | tfarina@chromium.org | 2010-08-11 16:42:49 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc

Match the Notifications infobar color with the color of all other confirmation infobars. Use the new blue style instead of the old yellow.

BUG=51207, 39102
TEST=go to http://0xfe.muthanna.com/notifyme.html, click on 'Request permission', see the infobar, verify if it has a blue background color.

Review URL: http://codereview.chromium.org/3026061
------------------------------------------------------------------------
r55720 | rsesek@chromium.org | 2010-08-11 16:20:54 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm

Remove deprecated code in cocoa_test_helper.h.

BUG=none
TEST=unit_tests

Review URL: http://codereview.chromium.org/3129004
------------------------------------------------------------------------
r55713 | mnissler@chromium.org | 2010-08-11 15:30:43 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/file_watcher.h
   M /trunk/src/chrome/browser/file_watcher_inotify.cc
   M /trunk/src/chrome/browser/file_watcher_mac.cc
   M /trunk/src/chrome/browser/file_watcher_unittest.cc
   M /trunk/src/chrome/browser/file_watcher_win.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h

Rework FileWatcher to avoid race condition upon deletion.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2868114
------------------------------------------------------------------------
r55707 | tfarina@chromium.org | 2010-08-11 13:47:37 +0200 (Wed, 11 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_win.cc

views: Use InfoBarTextButton in the Autofill credit card infobar.

Use it instead of views::TextButton to avoid flickering and duplicating code.

BUG=39102
TEST=go to http://infernohacks.com/t/autofill/cc.html, fill the fields, hit send, see the infobar,
everything should work as before.

Review URL: http://codereview.chromium.org/3060051
------------------------------------------------------------------------
r55706 | mnissler@chromium.org | 2010-08-11 13:37:18 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc

Create and remove sync nodes whenever preferences flip their managed flag

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2182001
------------------------------------------------------------------------
r55705 | satish@chromium.org | 2010-08-11 13:31:37 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_recognition_request.cc

Address Andrei's comments from CL 3164002
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3163004
------------------------------------------------------------------------
r55701 | pam@chromium.org | 2010-08-11 12:02:16 +0200 (Wed, 11 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Mark TestShowStoragePanel as FAILS_ following recent WebKit roll.

TBR=hamaji

BUG=51768
TEST=greener interactive_ui_tests on bots
Review URL: http://codereview.chromium.org/3166004
------------------------------------------------------------------------
r55696 | satorux@chromium.org | 2010-08-11 11:16:50 +0200 (Wed, 11 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Show alert messages when the user tries to remove the last language or the input method.

For now, use alert(). We'll replace this with a nicer way.

Along the way, fix a bug in removePreloadEnginesByLanguageCode_(), where
we didn't put parens right.

BUG=chromium-os:4573
TEST=manually

Review URL: http://codereview.chromium.org/3151003
------------------------------------------------------------------------
r55694 | yusukes@chromium.org | 2010-08-11 11:05:52 +0200 (Wed, 11 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Synchronize Input Method and Keyboard preferences.

Sync Chewing prefs, Mozc prefs (except prefs::kLanguageMozcSelectionShortcut since it's not yet configurable), XKB prefs, and prefs::kLanguagePinyinDoublePinyinSchema (now it's configurable).

BUG=chromium-os:4551
TEST=none

Review URL: http://codereview.chromium.org/3142006
------------------------------------------------------------------------
r55693 | bulach@chromium.org | 2010-08-11 11:03:52 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/indexed_db_key.cc
   M /trunk/src/chrome/common/indexed_db_key.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/serialized_script_value.cc
   M /trunk/src/chrome/common/serialized_script_value.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   A /trunk/src/chrome/renderer/renderer_webidbcursor_impl.cc
   A /trunk/src/chrome/renderer/renderer_webidbcursor_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h

Implements initial plumbing for IDBCursor.
This is the Chromium side of https://bugs.webkit.org/show_bug.cgi?id=41888
It's almost purely plumbing: actual logic and cursor implementation will follow soon.

Review URL: http://codereview.chromium.org/2918002
------------------------------------------------------------------------
r55692 | jochen@chromium.org | 2010-08-11 10:55:18 +0200 (Wed, 11 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Reland r55382. When blocking cookies, also show an icon in the location bar when cookies are accessed.

If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked.

BUG=45230
TEST=Canned*.*:ContentSetting*.*:TabSpecific*.*

Review URL: http://codereview.chromium.org/3014056

Review URL: http://codereview.chromium.org/3121007
------------------------------------------------------------------------
r55690 | hamaji@chromium.org | 2010-08-11 10:32:12 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Suppress ExtensionApiTest.CaptureVisibleTabPng

BUG=51761
TEST=none

Review URL: http://codereview.chromium.org/3176002
------------------------------------------------------------------------
r55689 | satorux@chromium.org | 2010-08-11 10:30:57 +0200 (Wed, 11 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler_unittest.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Add better support for languages in kExtraLanguages.

Before this change, "Input Method" section was empty for
languages in kExtraLanguages (ex. Filipino). This change
fixes the problem for these languages.

Along the way, add some vertical margin to each item in
the input method list.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3160001
------------------------------------------------------------------------
r55688 | jochen@chromium.org | 2010-08-11 10:15:33 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Delete callbacks after use in canned browsing data helpers.

BUG=49750
TEST=Canned*.*

Review URL: http://codereview.chromium.org/3178001
------------------------------------------------------------------------
r55685 | satorux@chromium.org | 2010-08-11 09:35:44 +0200 (Wed, 11 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler_unittest.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Add ability to show "Chromium OS cannot be displayed" as needed.

In Chromium OS, there are languages that have input methods and/or
keyboard layouts but not supported as UI language (ex. Norwegian
at this moment). For these languages, we'll show this label until
it's supported.

TEST=manually; added a unit test.
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3131002
------------------------------------------------------------------------
r55682 | satorux@chromium.org | 2010-08-11 09:13:15 +0200 (Wed, 11 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/resources/shared_resources.grd

Use ListSingleSelectionModel in LanguageList.

Users shouldn't be able to select multiple languages in the list.

TEST=manually confirmed that multiple selection with Ctrl-click is now impossible
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3058059
------------------------------------------------------------------------
r55678 | jcivelli@chromium.org | 2010-08-11 08:44:38 +0200 (Wed, 11 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Making window.focus() work in Chrome.
A patch on the WebKit side https://bugs.webkit.org/show_bug.cgi?id=43542
ensures we get the correct notification when window.focus()/blur() is called.
This CL makes the browser active/unactive in response to the focus/blur message.

BUG=29643
TEST=Visit gmail. Open an IM conversation window and pop-it out.
     Focus the browser (so the IM window is in the back). Click on the person name in the IM section of gmail.
     The conversation window should be brought back to the front.
     Repeat but this time minimize the conversation window.

Review URL: http://codereview.chromium.org/3060045
------------------------------------------------------------------------
r55677 | markus@chromium.org | 2010-08-11 08:44:30 +0200 (Wed, 11 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc

Change the message size for breakpad notifications. Due to alignment issues,
this does not seem to a problem on x86-64, but on x86-32 we would encounter
assertion failures.

BUG=51715
TEST=none
Review URL: http://codereview.chromium.org/3155004
------------------------------------------------------------------------
r55676 | mazda@chromium.org | 2010-08-11 08:37:08 +0200 (Wed, 11 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css

Widen the margin between the two-column list and the cancel button

This adds "margin-top: 15px" to chromeos_language_options.css.

Patch from shinyatanaka@google.com

BUG=chromium-os:5540
TEST=manual

Review URL: http://codereview.chromium.org/3161005
------------------------------------------------------------------------
r55675 | yusukes@chromium.org | 2010-08-11 07:49:44 +0200 (Wed, 11 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Clean up latin-pre/post special handling in input method code.

This is a follow-up CL of
http://codereview.chromium.org/3041054
which removed m17n:t:* (latin-pre/post) from input method ID whitelist.

We had some special cases here and there for these IDs and I removed them.

Patch from kochi@chromium.org.

BUG=chromium-os:5439
TEST=run unittest (LanguageMenuButtonTest, InputMethodUtilTest)

Review URL: http://codereview.chromium.org/3122005
------------------------------------------------------------------------
r55673 | loislo@chromium.org | 2010-08-11 07:38:51 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.cc

Push DevTools extensions data to the client when the DevTools client page is loaded.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3090022
------------------------------------------------------------------------
r55672 | yusukes@chromium.org | 2010-08-11 06:49:54 +0200 (Wed, 11 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc

Remove ReorderInputMethodIdsForLanguageCode().

As we now sort language codes in assets/input_method/whitelist.txt
manually and use the order in the list, we don't need a hack to move
the default language first.

Patch from kochi@chromium.org.

BUG=chromium-os:4576
TEST=Run unit_tests --gtest_filter='Input*', manually install chromium and check if the order appears in the expected order.

Review URL: http://codereview.chromium.org/3161001
------------------------------------------------------------------------
r55671 | ananta@chromium.org | 2010-08-11 06:45:33 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc

Added event traces at various points during Chrome and ChromeFrame startup to help measure and track performance.

Bug=51638

Review URL: http://codereview.chromium.org/3152001
------------------------------------------------------------------------
r55670 | yusukes@chromium.org | 2010-08-11 06:38:59 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/language_preferences_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add Views UI for setting keyboard repeat delay and repeat interval.

BUG=chromium-os:4102
TEST=ran unit_tests

Review URL: http://codereview.chromium.org/3023044
------------------------------------------------------------------------
r55668 | atwilson@chromium.org | 2010-08-11 06:16:19 +0200 (Wed, 11 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_uitest.cc

fixup for style nits
------------------------------------------------------------------------
r55667 | atwilson@chromium.org | 2010-08-11 06:16:04 +0200 (Wed, 11 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Cleaned up an incorrect comment
------------------------------------------------------------------------
r55666 | atwilson@chromium.org | 2010-08-11 06:15:47 +0200 (Wed, 11 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added support for --no-startup-window flag to launch chrome with no startup window
------------------------------------------------------------------------
r55665 | sky@chromium.org | 2010-08-11 06:03:57 +0200 (Wed, 11 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/tab_contents/match_preview.cc
   A /trunk/src/chrome/browser/tab_contents/match_preview.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h

Adds support for showing the match preview on views. It's behind the
flag --enable-match-preview. There is still a lot of details to get it
working good enough, but this is a good point to check some stuff in.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3105004
------------------------------------------------------------------------
r55663 | thakis@chromium.org | 2010-08-11 05:46:32 +0200 (Wed, 11 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Well-behaved accelerated plugins, preparation

This moves IOSurfaces into NSOpenGLViews instead of CALayers.

The advantage of this is that we can use hole-punching (which I'm leaving for a separate CL, but which is easy to add: see diff from patch set 6 to 5), which fixes the appearance of find bar etc. Also, we don't have to hack around coreanimation behavior we don't want, like appkit destroying and recreating our layers, and CA animating everything implicitly.

Even though this CL doesn't have hole punching yet, it fixes the find bar in most cases already, because now only the area actually covered by a plugin is drawn via opengl – so if the findbar doesn't overlap the accelerated plugin, it will be visible.

I didn't test what happens if a page uses both accelerated plugins and the compositor. One view covering the whole tab is created for the compositor, and one view for every plugin. It might even work, but I couldn't find a page to test this with, and accelerated plugins will be handled by the compositor anyway.

The opengl views don't handle any events: Events fall through to the parent view (RWHVMac) and are handled as before.

BUG=51748
TEST=
* Go to youtube, video should still paint correctly (even when scrolling, switching tabs, resizing the window rapidly, etc). Mouse clicks and keyboard events in the player should still work.
* Build with `GYP_DEFINES="use_accelerated_compositing=1" gclient runhooks`, run with --enable-accelerated-compositing. Demos at http://webkit.org/blog/386/3d-transforms/ should still look fine (the color shift is not a regression caused by this CL, it was that way before)

Review URL: http://codereview.chromium.org/3010054
------------------------------------------------------------------------
r55660 | viettrungluu@chromium.org | 2010-08-11 05:02:51 +0200 (Wed, 11 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.h
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver_unittest.mm
   M /trunk/src/chrome/browser/command_line_pref_store.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/font_settings_utils_mac.mm
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/host_zoom_map_unittest.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/options_page_base.cc
   M /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/pref_member.cc
   M /trunk/src/chrome/browser/pref_member.h
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_uitest.cc
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   M /trunk/src/chrome/browser/pref_set_observer.cc
   M /trunk/src/chrome/browser/pref_set_observer.h
   M /trunk/src/chrome/browser/pref_set_observer_unittest.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/scoped_pref_update.cc
   M /trunk/src/chrome/browser/scoped_pref_update.h
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/web_applications/web_app.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/common/json_pref_store_unittest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/testing_pref_service.cc
   M /trunk/src/chrome/test/testing_pref_service.h

Make prefs use std::string for keys rather than wstrings.

Much remains to be converted.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3076037
------------------------------------------------------------------------
r55657 | tfarina@chromium.org | 2010-08-11 03:38:50 +0200 (Wed, 11 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/app/tree_model.h
   M /trunk/src/app/tree_node_model_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h

Cleanup: Get rid of TreeNodeChildrenReordered.

Reason: This function was never implemented by TreeNodeModel and is unlike it
will be. Also it proved to not be necessary at all.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3091016
------------------------------------------------------------------------
r55656 | aa@chromium.org | 2010-08-11 03:37:24 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   A /trunk/src/chrome/test/data/extensions/origin_privileges/extension2
   A /trunk/src/chrome/test/data/extensions/origin_privileges/extension2/index.html
   A /trunk/src/chrome/test/data/extensions/origin_privileges/extension2/manifest.json
   A /trunk/src/chrome/test/data/extensions/origin_privileges/extension2/test.png

Allow chrome:// pages to load extension resources. Also, lock down access from chrome-extension:// pages to the origin of the resource being requested.

BUG=51702

Review URL: http://codereview.chromium.org/3121003
------------------------------------------------------------------------
r55652 | jcivelli@chromium.org | 2010-08-11 03:32:32 +0200 (Wed, 11 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm

Prevents TranslateInfoBarDelegate from keeping a pointer to a deleted TabContents.
A CL that changed the OptionsMenuModel (not yet committed, http://codereview.chromium.org/3073025) made it access the tab contents, causing a crasher in on of the option tests.

BUG=None
TEST=All translate unit-tests should pass.

Review URL: http://codereview.chromium.org/3124001
------------------------------------------------------------------------
r55650 | erg@google.com | 2010-08-11 03:27:57 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Fix permissions on sync files.

TBR=mirandac,timsteele

Review URL: http://codereview.chromium.org/3145005
------------------------------------------------------------------------
r55647 | zork@chromium.org | 2010-08-11 03:14:20 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Fix some typos from a bad merge.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3162001
------------------------------------------------------------------------
r55644 | tim@chromium.org | 2010-08-11 02:47:19 +0200 (Wed, 11 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h

sync: Fix backend configuration to support sync db refresh.

Removes the has_new bit in favor of checking if initial_sync_ended for requested types, and recreates the sync db on corruption (as we used to).  These together mean we refresh the sync db on corruption.  Also added some defensive dchecks.

To test this, I ripped out the test-only #ifdefs in SyncBackendHost so the tests use the real Initialize code path, and added a toolbox of stuff to control when we set initial sync ended bits during testing.

BUG=50965
TEST=DirectoryBackingStoreTest, ProfileSyncService* tests.

Review URL: http://codereview.chromium.org/3099001
------------------------------------------------------------------------
r55643 | thakis@chromium.org | 2010-08-11 02:43:28 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tabpose_window.h
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm

Mac tabpose: Add favicons and titles.

BUG=50307
TEST=Activate tabpose. The (white) thumbnails should have favicons and titles drawn below them.

Review URL: http://codereview.chromium.org/3159001
------------------------------------------------------------------------
r55642 | estade@chromium.org | 2010-08-11 02:35:26 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js

Content settings: allow "session only" type for cookies exceptions

BUG=50629
TEST=manual

Review URL: http://codereview.chromium.org/3145002
------------------------------------------------------------------------
r55635 | erg@google.com | 2010-08-11 01:43:59 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_title.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.h
   M /trunk/src/chrome/gpu/gpu_video_layer_glx.h
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/dromaeo_benchmark_uitest.cc
   M /trunk/src/chrome/test/ui/sunspider_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/test/ui/v8_benchmark_uitest.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc

FBTF: Clean up some headers in tab_contents_delegate.h.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3145001
------------------------------------------------------------------------
r55632 | inferno@chromium.org | 2010-08-11 01:19:17 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager_unittest.cc

Unittest fix. Need to put usersubmitted = true for unittests.

BUG=51727

Review URL: http://codereview.chromium.org/3151006
------------------------------------------------------------------------
r55628 | mirandac@chromium.org | 2010-08-11 00:48:10 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Mark NewTabUITest.UpdateUserPrefsVersion as flaky.

BUG=51726
TEST=none

Review URL: http://codereview.chromium.org/3140006
------------------------------------------------------------------------
r55626 | inferno@chromium.org | 2010-08-11 00:39:30 +0200 (Wed, 11 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc

Not store autocomplete entries in DB for forms submitted using javascript.

BUG=51727

Review URL: http://codereview.chromium.org/3149003
------------------------------------------------------------------------
r55624 | nshkrob@chromium.org | 2010-08-11 00:10:02 +0200 (Wed, 11 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Mark NewTabUITest.NTPHasThumbnails FLAKY.

BUG=http://crbug.com/51721
TEST=ui_tests

Review URL: http://codereview.chromium.org/3169003
------------------------------------------------------------------------
r55620 | sky@chromium.org | 2010-08-10 22:50:39 +0200 (Tue, 10 Aug 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Revert 55602 - Attempt at making BrowserKeyboardAccessibility lets flaky. If an
accessibility event was received before the tab key was seen, then we
would prematurely quit the message loop and end up in
ui_controls::SendKeyPressNotifyWhenDone again, resulting in hitting
the DCHECK in ui_controls. Additionally if the test timed out we would
keep running other tests, resulting in hitting the DCHECK in ui_controls. I'm not sure which was happening, but either could have caused the DCHECK to get hit.

I'm going to leave the debugging code in for a few cycles.

I think we need a SendKeyPressAndBlock and callers ASSERT that it returns true. I'll look into that later though.

BUG=50864
TEST=this is only a test change

Review URL: http://codereview.chromium.org/3058039

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3174001
------------------------------------------------------------------------
r55619 | mirandac@chromium.org | 2010-08-10 22:27:27 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Marking BrowserEncodingTest.TestEncodingAliasMapping as flaky.

BUG=51716
TEST=none

Review URL: http://codereview.chromium.org/3122007
------------------------------------------------------------------------
r55617 | cmasone@google.com | 2010-08-10 22:18:49 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix CrosLibrary::TestApi valgrind errors

BUG=51261,51263
TEST=valgrind

Review URL: http://codereview.chromium.org/3005059
------------------------------------------------------------------------
r55616 | stuartmorgan@chromium.org | 2010-08-10 22:18:18 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js

DOMUI prefs: Wire up Basics control states based on pref selections

BUG=48713
TEST=Homepage and startup page controls should be disabled when the corresponding prefs aren't selected.

Review URL: http://codereview.chromium.org/3068007
------------------------------------------------------------------------
r55611 | satish@chromium.org | 2010-08-10 22:02:48 +0200 (Tue, 10 Aug 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/speech/speech_recognition_request.cc
   A /trunk/src/chrome/browser/speech/speech_recognition_request.h
   A /trunk/src/chrome/browser/speech/speech_recognition_request_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds SpeechRecognitionRequest class for sending recorded audio data to server and parse response.
Also added a unit test.
This code will be used in upcoming CLs for speech input.
TEST=unit_tests --gtest_filter=SpeechRecognitionRequestTest.*
BUG=none

Review URL: http://codereview.chromium.org/3164002
------------------------------------------------------------------------
r55610 | nshkrob@chromium.org | 2010-08-10 22:02:08 +0200 (Tue, 10 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/Favicons
   M /trunk/src/chrome/test/data/profiles/typical_history/Default/History
   D /trunk/src/chrome/test/data/profiles/typical_history/Default/Thumbnails
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/Top Sites
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Replace --top-sites flag with --no-top-sites flag. TopSites becomes the default.

BUG=none
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55244

Review URL: http://codereview.chromium.org/3054028
------------------------------------------------------------------------
r55606 | ctguil@chromium.org | 2010-08-10 21:41:32 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accessibility_event_router_views.cc
   M /trunk/src/views/controls/menu/submenu_view.cc

Initialize most_recent_profile_ in constructor.

BUG=51631
TEST=Ensure chrome --first-run don't crash when opening the wrench menu.

Review URL: http://codereview.chromium.org/3139002
------------------------------------------------------------------------
r55605 | stuartmorgan@chromium.org | 2010-08-10 21:41:28 +0200 (Tue, 10 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   A /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.css
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.html
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.js
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options.html

DOMUI prefs: Basic implementation of adding a startup page

Adds a text field for adding a startup page; the table of recent pages will be added later.

BUG=49090
TEST=Adding a startup page should be possible in DOMUI prefs.

Review URL: http://codereview.chromium.org/2873078
------------------------------------------------------------------------
r55602 | sky@chromium.org | 2010-08-10 21:25:31 +0200 (Tue, 10 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Attempt at making BrowserKeyboardAccessibility lets flaky. If an
accessibility event was received before the tab key was seen, then we
would prematurely quit the message loop and end up in
ui_controls::SendKeyPressNotifyWhenDone again, resulting in hitting
the DCHECK in ui_controls. Additionally if the test timed out we would
keep running other tests, resulting in hitting the DCHECK in ui_controls. I'm not sure which was happening, but either could have caused the DCHECK to get hit.

I'm going to leave the debugging code in for a few cycles.

I think we need a SendKeyPressAndBlock and callers ASSERT that it returns true. I'll look into that later though.

BUG=50864
TEST=this is only a test change

Review URL: http://codereview.chromium.org/3058039
------------------------------------------------------------------------
r55601 | dhg@chromium.org | 2010-08-10 21:17:31 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc

Fixing filebrowser so it opens with a panel with no location bar.  making it so only one can be opened, and making it so that it expands on getting a new download.

BUG=chromium-os:4995
TEST=verify that all the above happens (tested on device)

Review URL: http://codereview.chromium.org/3094001
------------------------------------------------------------------------
r55599 | rsimha@chromium.org | 2010-08-10 21:08:02 +0200 (Tue, 10 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/jingle/notifier/communicator/connection_settings.cc
   M /trunk/src/jingle/notifier/communicator/connection_settings.h
   M /trunk/src/jingle/notifier/communicator/login.cc
   M /trunk/src/jingle/notifier/communicator/login.h
   M /trunk/src/jingle/notifier/communicator/login_settings.cc
   M /trunk/src/jingle/notifier/communicator/login_settings.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/jingle/notifier/listener/talk_mediator_unittest.cc

Use SSL/TCP port for notifications in sync tests.

The sync integration tests start off by using the XMPP port (5222) to connect to the sync notification server. Since this port is blocked on the chromium builders, the tests wait for upto a minute before they failover to the SSL/TCP port (443), by which time the tests time out and fail.

This checkin adds a switch that, when enabled, causes the tests to try the SSL/TCP port before the XMPP port.

BUG=50595
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3050036
------------------------------------------------------------------------
r55598 | rsesek@chromium.org | 2010-08-10 21:06:54 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/accelerators_cocoa.mm

[Mac] Add key equivalent for Clear Browsing Data to the Wrench menu.

BUG=51038
TEST=Open Wrench-->Tools. Clear Browsing Data has an equivalent of Cmd+Shift+Backspace.

Review URL: http://codereview.chromium.org/3152002
------------------------------------------------------------------------
r55590 | alyssad@chromium.org | 2010-08-10 20:11:16 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/test/functional/translate.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New pyauto translate hooks: always and never translate button.

This hooks allows testers to test that always and never translate button that shows up after a user has accepted/declined translation several times.

Review URL: http://codereview.chromium.org/3061054
------------------------------------------------------------------------
r55587 | erg@google.com | 2010-08-10 20:02:03 +0200 (Tue, 10 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   A /trunk/src/chrome/browser/importer/importer_messages.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/common_param_traits.h
   A /trunk/src/chrome/common/devtools_messages.cc
   A /trunk/src/chrome/common/gpu_messages.cc
   A /trunk/src/chrome/common/nacl_messages.cc
   M /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/plugin_messages.cc
   A /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/service_messages.cc
   A /trunk/src/chrome/common/utility_messages.cc
   A /trunk/src/chrome/common/worker_messages.cc
   A /trunk/src/chrome/test/automation/automation_messages.cc
   M /trunk/src/ipc/ipc_fuzzing_tests.cc
   A /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/ipc/ipc_message_utils.h
   A /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/sync_socket_unittest.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h

FBTF: Reapplies r55259, the first new IPC definition patch.

This moves MessageWithTuple::Read() back into the main ipc_message_utils.h
header from the private ipc_messsage_utils_impl.h header. In release mode, this
was causing link failures.

BUG=51411
TEST=none

Review URL: http://codereview.chromium.org/3069034
------------------------------------------------------------------------
r55586 | mirandac@chromium.org | 2010-08-10 20:01:00 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Mark TaskManagerBrowserTest.NoticeExtensionChanges as flaky.

BUG=51701
TEST=none
Review URL: http://codereview.chromium.org/3124007
------------------------------------------------------------------------
r55583 | mirandac@chromium.org | 2010-08-10 19:59:08 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Mark test UnloadTest.BrowserCloseUnload as flaky.

BUG=51698
TEST=none

Review URL: http://codereview.chromium.org/3107004
------------------------------------------------------------------------
r55578 | erg@google.com | 2010-08-10 19:29:59 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h

FBTF: Minor #include cleanup.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3134004
------------------------------------------------------------------------
r55577 | erg@google.com | 2010-08-10 19:28:06 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/app/tween.cc
   M /trunk/src/app/tween.h
   M /trunk/src/app/x11_util.cc
   M /trunk/src/app/x11_util.h
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.h
   M /trunk/src/chrome/gpu/gpu_video_layer_glx.h
   M /trunk/src/gfx/blit.h
   M /trunk/src/gfx/blit_unittest.cc
   M /trunk/src/gfx/canvas.h
   M /trunk/src/gfx/canvas_direct2d.cc
   M /trunk/src/gfx/canvas_direct2d_unittest.cc
   M /trunk/src/gfx/canvas_skia.cc
   M /trunk/src/gfx/path.cc
   M /trunk/src/gfx/path.h

FBTF: Minor gfx/ header cleanup.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3034039
------------------------------------------------------------------------
r55569 | pinkerton@chromium.org | 2010-08-10 18:27:41 +0200 (Tue, 10 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/cocoa/applescript
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.mm
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_folder_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_folder_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_item_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_item_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_item_applescript_unittest.mm
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_node_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/bookmark_node_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/browsercrapplication+applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/browsercrapplication+applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/constants_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/constants_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/element_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/element_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/error_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/error_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/scripting.sdef
   A /trunk/src/chrome/browser/cocoa/applescript/tab_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/tab_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/window_applescript.h
   A /trunk/src/chrome/browser/cocoa/applescript/window_applescript.mm
   A /trunk/src/chrome/browser/cocoa/applescript/window_applescript_test.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_exe.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Added a method to check if a browser is closing.
Added a method to get the next node ID for bookmarks managed by the bookmark 
model.
Added AppleScript support.
Added scripting definition file.
Added support for saving tab.
Added localization support.
Added consistent error nos/error messages.
(patch developed by v.a.shreyas@gmail.com)

BUG=27468
TEST=none
------------------------------------------------------------------------
r55568 | rsesek@chromium.org | 2010-08-10 17:47:34 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm

[Mac] Insert the Update Chrome item to existing Wrench menus when notified.

BUG=50659
TEST=Wait for upgrade. Get yellow ball on Wrench menu. Open menu, see Update Chrome item.

Review URL: http://codereview.chromium.org/3124002
------------------------------------------------------------------------
r55567 | dilmah@chromium.org | 2010-08-10 16:53:57 +0200 (Tue, 10 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h

On locale changed: take care of continue button on network_selection screen.
Also on locale changed: preserve selection of network (previously network selection was reset to "No selection" on locale change)

BUG=http://crosbug.com/4944
TEST=Manual
Review URL: http://codereview.chromium.org/3054054

------------------------------------------------------------------------
r55563 | jochen@chromium.org | 2010-08-10 15:12:49 +0200 (Tue, 10 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Add a session storage node to the cookies tree view for collected cookies.

Furthermore, local storage and session storage accesses are recorded separately in the tab contents, so they can be displayed in the correct bucket.

BUG=45230
TEST=none

Review URL: http://codereview.chromium.org/3053052
------------------------------------------------------------------------
r55561 | jochen@chromium.org | 2010-08-10 14:46:45 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

Don't redraw the location bar if there's nothing to redraw.

BUG=none
TEST=perf improvement on page_cycler_intl1

Review URL: http://codereview.chromium.org/3168001
------------------------------------------------------------------------
r55553 | jochen@chromium.org | 2010-08-10 12:01:15 +0200 (Tue, 10 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Revert 55548 - Reland r55382. When blocking cookies, also show an icon in the location bar when cookies are accessed.

If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked.

BUG=45230
TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.*

Review URL: http://codereview.chromium.org/3014056

Review URL: http://codereview.chromium.org/3148002

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3132003
------------------------------------------------------------------------
r55548 | jochen@chromium.org | 2010-08-10 11:39:48 +0200 (Tue, 10 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Reland r55382. When blocking cookies, also show an icon in the location bar when cookies are accessed.

If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked.

BUG=45230
TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.*

Review URL: http://codereview.chromium.org/3014056

Review URL: http://codereview.chromium.org/3148002
------------------------------------------------------------------------
r55541 | bauerb@chromium.org | 2010-08-10 10:30:21 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/common/plugin_group.cc

Re-enable the link to disable invididual plug-ins in a group.

BUG=51597
TEST=In about:plugins, click on "Details". There should be a link to enable/disable each individual plug-in in a plug-in group.

Review URL: http://codereview.chromium.org/3038055
------------------------------------------------------------------------
r55540 | jochen@chromium.org | 2010-08-10 10:27:52 +0200 (Tue, 10 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Revert 55536 - Reland r55382. When blocking cookies, also show an icon in the location bar when cookies are accessed.

If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked.

BUG=45230
TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.*

Review URL: http://codereview.chromium.org/3014056

Review URL: http://codereview.chromium.org/3146003

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3127002
------------------------------------------------------------------------
r55538 | yusukes@chromium.org | 2010-08-10 09:16:14 +0200 (Tue, 10 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_keyboard_library.h

Support new libcros APIs: GetAutoRepeatEnabled, SetAutoRepeatEnabled, GetAutoRepeatRate, and SetAutoRepeatRate.

This change depends on http://codereview.chromium.org/3020073.

BUG=chromium-os:4102
TEST=ran browser_tests

Review URL: http://codereview.chromium.org/3078029
------------------------------------------------------------------------
r55536 | jochen@chromium.org | 2010-08-10 09:13:06 +0200 (Tue, 10 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Reland r55382. When blocking cookies, also show an icon in the location bar when cookies are accessed.

If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked.

BUG=45230
TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.*

Review URL: http://codereview.chromium.org/3014056

Review URL: http://codereview.chromium.org/3146003
------------------------------------------------------------------------
r55535 | mdm@chromium.org | 2010-08-10 09:11:53 +0200 (Tue, 10 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/native_backend_kwallet_x.cc
   M /trunk/src/chrome/browser/password_manager/native_backend_kwallet_x.h

Linux: fix several bugs in KWallet password store support.
* Don't disable kwallet support if the first site visited
  with a login form has no saved passwords.
* Don't crash when there are certain types of invalid entries
  stored in the wallet that fail to deserialize.
TEST=start with --password-store=detect in KDE and check that the above happens
BUG=49968
Review URL: http://codereview.chromium.org/3048052
------------------------------------------------------------------------
r55531 | inferno@chromium.org | 2010-08-10 08:19:28 +0200 (Tue, 10 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

Add xbap to download extensions warning list.

BUG=51658
TEST=NONE
TBR=cevans@chromium.org

Review URL: http://codereview.chromium.org/3158001
------------------------------------------------------------------------
r55530 | viettrungluu@chromium.org | 2010-08-10 07:23:33 +0200 (Tue, 10 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/common/notification_type.h

Revert 55449 - Fix some problems with TaskManagerBrowserTest.PopulateWebCacheFields:

- wait for an actual update to occur; otherwise we're not testing the real thing
- change DCHECKs to EXPECT_EQs; that's what we should use in tests

This change should also fix the crashiness of this test.

TEST=browser_tests
BUG=42301

Review URL: http://codereview.chromium.org/2856091

TBR=phajdan.jr@chromium.org,glen@chromium.org
Review URL: http://codereview.chromium.org/3118003
------------------------------------------------------------------------
r55529 | satorux@chromium.org | 2010-08-10 07:21:18 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js
   M /trunk/src/chrome/browser/resources/options.html

Add "Configure..." buttons for input methods that config pages.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3037054
------------------------------------------------------------------------
r55527 | tfarina@chromium.org | 2010-08-10 06:44:29 +0200 (Tue, 10 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Autofill: Two small fixes.

- Remove unnecessary "Summary" line from Autofill options dialog box.

- Make the sub-dialogs ('Add an address' and 'Add a credit card') modal.

BUG=49881,49787
TEST=Go to Options > Personal Stuff > AutoFill Options. The listview shouldn't have any header. Click on 'Add address...' or in 'Add credit card...', try to come back to the AutoFill options dialog again, it shouldn't be possible.

Review URL: http://codereview.chromium.org/3080039
------------------------------------------------------------------------
r55526 | viettrungluu@chromium.org | 2010-08-10 05:59:24 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/net/chrome_network_delegate.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/webkit/glue/mock_resource_loader_bridge.h

Whitespace change to trigger bots.

TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/2694003
------------------------------------------------------------------------
r55520 | tfarina@chromium.org | 2010-08-10 03:33:13 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_message_unittest.cc

Use scoped_ptr API from base/ instead of one from gtest/internal/gtest-port.h.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3043061
------------------------------------------------------------------------
r55518 | chocobo@chromium.org | 2010-08-10 03:14:05 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc

Fix to not show passwords in about:network page. Now it just shows *'s
BUG=none
TEST=none
TBR=sleffler
Review URL: http://codereview.chromium.org/3134005
------------------------------------------------------------------------
r55517 | jar@chromium.org | 2010-08-10 03:11:15 +0200 (Tue, 10 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc

(repair leak) Handle synchronous request for a preconnection

In some situations, the preconnection can be serviced
synchronously, and then there will be no callback
to release the Preconnect instance.  This change
properly handles that eventuality.

BUG=51133
r=wtc
Review URL: http://codereview.chromium.org/3115003
------------------------------------------------------------------------
r55516 | jiesun@google.com | 2010-08-10 03:05:41 +0200 (Tue, 10 Aug 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/gpu_messages_internal.h
   A /trunk/src/chrome/common/gpu_video_common.cc
   A /trunk/src/chrome/common/gpu_video_common.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_channel.h
   A /trunk/src/chrome/gpu/gpu_video_decoder.cc
   A /trunk/src/chrome/gpu/gpu_video_decoder.h
   A /trunk/src/chrome/gpu/gpu_video_service.cc
   A /trunk/src/chrome/gpu/gpu_video_service.h
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/renderer/gpu_channel_host.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   A /trunk/src/chrome/renderer/gpu_video_decoder_host.cc
   A /trunk/src/chrome/renderer/gpu_video_decoder_host.h
   A /trunk/src/chrome/renderer/gpu_video_service_host.cc
   A /trunk/src/chrome/renderer/gpu_video_service_host.h
   A /trunk/src/chrome/renderer/media/ipc_video_decoder.cc
   A /trunk/src/chrome/renderer/media/ipc_video_decoder.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/media/base/media_switches.cc
   M /trunk/src/media/base/media_switches.h
   M /trunk/src/media/filters/ffmpeg_demuxer.cc

1. ipc_video_decoder.cc/h is media pipeline filter which use the gpu decoder facilities in video stack. it is only enabled when (a) hardware composition is on (b) hardware decoding command line is on (c) h264 codec is specified.

2. gpu_video_service.cc/h is a singleton in gpu process which provide video services for renderer process, through it we could create decoder. ( in my imagination, in the future, we could create encoder or capturer too)

3. gpu_video_decoder.cc/h. abstract interface for hardware decoder.

4. gpu_video_service_host.cc/h is singleton in renderer process which provide proxy for gpu_video_service.

5. gpu_video_decoder_host.cc/h is proxy for gpu_video_decoder. (1 to 1 map).basically there is one global GpuVideoService in GPU process, one GpuVideoServiceHost in Renderer process. for each renderer process, there are could be multiple renderer view, each could had multiple GpuVideoDecoderHost the connect to GpuVideoDeocder through GPUCHannelHOst/GpuChannel.

6. gpu_video_common.cc/h: IPC message definition and pickle/marshaling support.

ISSUES:

1. in media pipeline, we need let decoder to determine if bit stream filter should be used instead of let command line to determine it.
2. stop readback from D3D surface use ANGLE.
3. Flush logic still need fine tuning.
4. CreateThread in GpuVideoDecoder, and post message in message handler, and derived classs handle message loop. ?
5. Error handling.
6. Input ring buffer implementation. Current impl is naive.
7.Add output queue for MFT decoder.
8. Query Capabilities at GetVideoServices()...

BUG=None
TEST=Windows7

Review URL: http://codereview.chromium.org/2873089
------------------------------------------------------------------------
r55515 | estade@chromium.org | 2010-08-10 03:04:19 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js
   M /trunk/src/chrome/browser/resources/options/options_page.css

Content settings: generalize the exceptions lists for all settings types.

BUG=48862
TEST=exceptions lists work for types besides images

Review URL: http://codereview.chromium.org/3035060
------------------------------------------------------------------------
r55514 | davidben@chromium.org | 2010-08-10 02:34:02 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/ssl_client_certificate_selector_win.cc

Add missing windows.h

TBR=wtc
BUG=none
TEST=windows compiles
------------------------------------------------------------------------
r55509 | davidben@chromium.org | 2010-08-10 02:15:35 +0200 (Tue, 10 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/ssl_client_certificate_selector.mm
   M /trunk/src/chrome/browser/gtk/ssl_client_certificate_selector.cc
   M /trunk/src/chrome/browser/ssl_client_certificate_selector.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.cc
   M /trunk/src/chrome/browser/views/ssl_client_certificate_selector_win.cc

Make GTK certificate selection dialog a constrained window

This makes the dialog tab-modal. Implementation on OS X is
forthcoming. Windows will be messier; we'll need to implement our own dialog,
but we want that anyway because of the annoying blocking call.

R=wtc,mattm
TEST=none
BUG=50710

Review URL: http://codereview.chromium.org/3077008
------------------------------------------------------------------------
r55508 | mpcomplete@chromium.org | 2010-08-10 02:08:45 +0200 (Tue, 10 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix a bug where the allow-in-incognito state would get reset when an extension
was updated.

BUG=51359
TEST=enable an extension in incognito and upgrade it to a newer version. should remain enabled.

Review URL: http://codereview.chromium.org/3121001
------------------------------------------------------------------------
r55505 | thakis@chromium.org | 2010-08-10 01:44:24 +0200 (Tue, 10 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tabpose_window.h
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm

Mac: Highlight selected tile in tabpose.

BUG=50307
TEST=selected tile now has a blue border

TBR=trungl

Review URL: http://codereview.chromium.org/3140001
------------------------------------------------------------------------
r55503 | evan@chromium.org | 2010-08-10 01:36:04 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/config_dir_policy_provider.cc
   D /trunk/src/chrome/browser/config_dir_policy_provider.h
   D /trunk/src/chrome/browser/config_dir_policy_provider_unittest.cc
   D /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   D /trunk/src/chrome/browser/configuration_policy_pref_store.h
   D /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   D /trunk/src/chrome/browser/configuration_policy_provider.cc
   D /trunk/src/chrome/browser/configuration_policy_provider.h
   D /trunk/src/chrome/browser/configuration_policy_provider_mac.cc
   D /trunk/src/chrome/browser/configuration_policy_provider_mac.h
   D /trunk/src/chrome/browser/configuration_policy_provider_mac_unittest.cc
   D /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   D /trunk/src/chrome/browser/configuration_policy_provider_win.h
   D /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   D /trunk/src/chrome/browser/configuration_policy_store.h
   D /trunk/src/chrome/browser/dummy_configuration_policy_provider.h
   D /trunk/src/chrome/browser/mock_configuration_policy_provider.h
   D /trunk/src/chrome/browser/mock_configuration_policy_store.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   A /trunk/src/chrome/browser/policy
   A /trunk/src/chrome/browser/policy/config_dir_policy_provider.cc (from /trunk/src/chrome/browser/config_dir_policy_provider.cc:55486)
   A /trunk/src/chrome/browser/policy/config_dir_policy_provider.h (from /trunk/src/chrome/browser/config_dir_policy_provider.h:55486)
   A /trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc (from /trunk/src/chrome/browser/config_dir_policy_provider_unittest.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_pref_store.cc (from /trunk/src/chrome/browser/configuration_policy_pref_store.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_pref_store.h (from /trunk/src/chrome/browser/configuration_policy_pref_store.h:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_pref_store_unittest.cc (from /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider.cc (from /trunk/src/chrome/browser/configuration_policy_provider.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider.h (from /trunk/src/chrome/browser/configuration_policy_provider.h:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.cc (from /trunk/src/chrome/browser/configuration_policy_provider_mac.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider_mac.h (from /trunk/src/chrome/browser/configuration_policy_provider_mac.h:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider_mac_unittest.cc (from /trunk/src/chrome/browser/configuration_policy_provider_mac_unittest.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider_win.cc (from /trunk/src/chrome/browser/configuration_policy_provider_win.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider_win.h (from /trunk/src/chrome/browser/configuration_policy_provider_win.h:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_provider_win_unittest.cc (from /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc:55486)
   A /trunk/src/chrome/browser/policy/configuration_policy_store.h (from /trunk/src/chrome/browser/configuration_policy_store.h:55486)
   A /trunk/src/chrome/browser/policy/dummy_configuration_policy_provider.h (from /trunk/src/chrome/browser/dummy_configuration_policy_provider.h:55486)
   A /trunk/src/chrome/browser/policy/mock_configuration_policy_provider.h (from /trunk/src/chrome/browser/mock_configuration_policy_provider.h:55486)
   A /trunk/src/chrome/browser/policy/mock_configuration_policy_store.h (from /trunk/src/chrome/browser/mock_configuration_policy_store.h:55486)
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Move a bunch of chrome/browser/ files into a policy/ subdir.

BUG=50548
TEST=compiles

Review URL: http://codereview.chromium.org/3110002
------------------------------------------------------------------------
r55500 | pkasting@chromium.org | 2010-08-10 01:31:17 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc

Fix gcc warning

BUG=51146
TEST=none

------------------------------------------------------------------------
r55496 | pkasting@chromium.org | 2010-08-10 01:23:14 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc

Prevent password leakage to the suggest server by being more strict about not doing suggest when the user might have typed a username.  Since we might parse this as something else (e.g. a scheme, or a hostname that's going to have a port number), the added checks are mainly for things that don't appear to be "usernames" (which were already not sent).

BUG=51146
TEST=Unittest
Review URL: http://codereview.chromium.org/3044054
------------------------------------------------------------------------
r55495 | pkasting@chromium.org | 2010-08-10 01:22:43 +0200 (Tue, 10 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h

Blind fix for a crash due to r54649.  Committing results can mean the provided is no longer valid.  In that case the best we can do is to clamp to the valid range.

BUG=51634
TEST=none (hard to reproduce this)
Review URL: http://codereview.chromium.org/3139001
------------------------------------------------------------------------
r55494 | ananta@chromium.org | 2010-08-10 01:18:05 +0200 (Tue, 10 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h

Added support in Chromeframe full tab mode IE for setting zoom levels via View->Zoom. Currently we only support
Zoom in and zoom out as Chrome only supports these zoom levels. 

Added an automation IPC message AutomationMsg_SetZoomLevel to set the zoom level in ChromeFrame.

The other change is in the active document in the handling of the attach external tab message. We now honor the
dimensions if any when we Launch the URL. This ensures that any windows opened outside chrome frame also honor these
dimensions.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=36000

Bug=36000

Review URL: http://codereview.chromium.org/3064049
------------------------------------------------------------------------
r55493 | sargrass@google.com | 2010-08-10 01:14:36 +0200 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js

Add Themes controls

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3066040
------------------------------------------------------------------------
r55484 | seh@chromium.org | 2010-08-10 00:06:00 +0200 (Tue, 10 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/central_roster.html

Reference ChromeOS specific config parameters.
Review URL: http://codereview.chromium.org/3126001
------------------------------------------------------------------------
r55482 | thakis@chromium.org | 2010-08-09 23:57:19 +0200 (Mon, 09 Aug 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window.h
   M /trunk/src/chrome/browser/cocoa/tabpose_window.mm
   M /trunk/src/chrome/browser/cocoa/tabpose_window_unittest.mm

Mac: more tabpose

Add layout logic, add layers, add entry/exit animations, add mouse selection of layers. Most things are functional, but no thumbnail images are shown yet.

Why is the Tile stuff c++ classes instead of objc classes? Because some of the linux folks said they'd like to see this on linux too, so I don't want to make it too hard for me to port this to other platforms if this survives the experiment stage.

Why is the Tile stuff not in its own file then? Because things are still far from settled down, and this way it's easier for me to change things around.

BUG=50307
TEST=
* All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled.
* Activate tabpose. One layer per tab should appear, they should be layed out in a sensible manner
* Layout should also be sensible if the window has extreme width to height ratios.
* Layers can be selected by hovering them with the mouse. enter, space, and clicking all select the currently selected layer. esc animated back to the initially selected layer
* If shift is down when tabpose is entered or left, the animation plays in slow motion
* For now, the layers are just black rects with a shadow or a white rect with a shadow for the selected layer.
* Shadows are not shown while the entry or exit animations are running (because animating shadows is very slow, and it's not noticable that they're not there during the animation)
* When a layer has been selected, the corresponding tab is selected once the exit animation is done
* The selected layer should animate to the size of the tab contents (minus download shelf, if visible): It should include infobars, the detached bookmarks bar on the ntp, and devtools.

Review URL: http://codereview.chromium.org/3063031
------------------------------------------------------------------------
r55480 | arv@chromium.org | 2010-08-09 23:56:19 +0200 (Mon, 09 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Bookmark manager: Fix error which prevented middle clicking from opening a bookmark in a background tab.

BUG=50636
TEST=Middle click on a bookmark in the bookmark manager.

Review URL: http://codereview.chromium.org/3043059
------------------------------------------------------------------------
r55479 | arv@chromium.org | 2010-08-09 23:56:06 +0200 (Mon, 09 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css

Bookmarks manager: Polish the edit mode CSS a little to make the text inputs line up correctly.

BUG=51181
TEST=Go to bookmarks manager and right click and select edit. The blue borders should not be covered by the input boxes. The text in the input boxes should align exactly with the text before and after editing.


Review URL: http://codereview.chromium.org/3071026
------------------------------------------------------------------------
r55478 | chocobo@chromium.org | 2010-08-09 23:53:33 +0200 (Mon, 09 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_message_observer.cc

Notify on failure during network connection.
BUG=chromium-os:2556
TEST=manual
Review URL: http://codereview.chromium.org/3096011
------------------------------------------------------------------------
r55471 | stevenjb@chromium.org | 2010-08-09 23:19:37 +0200 (Mon, 09 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_system_library.h
   M /trunk/src/chrome/browser/chromeos/cros/system_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/system_library.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_unittest.cc

Add GetMachineStatistic to SystemLibrary.

BUG=chromeos:3949 (http://code.google.com/p/chromium-os/issues/detail?id=3949)
TEST=Run a version of chrome with the corresponding changes. Ensure that reporting is enabled. Check that the report "hardware_class" value is valid.

See also: http://codereview.chromium.org/3067003/show

Review URL: http://codereview.chromium.org/3069002
------------------------------------------------------------------------
r55468 | glen@chromium.org | 2010-08-09 22:47:18 +0200 (Mon, 09 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc

Revert 55450 - Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.

This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.

Added a comment that PathService::Override should not be called
by production code.

TEST=ui_tests in Release mode
BUG=49838

Review URL: http://codereview.chromium.org/2805100

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3107001
------------------------------------------------------------------------
r55464 | markus@chromium.org | 2010-08-09 22:44:03 +0200 (Mon, 09 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc

Pid computation for breakpad had a race condition that could cause the
dumper to fail. We now send two file descriptors from the crashing process
to the dumper. One of these is used solely to identify the pid. We guarantee
that this file descriptor is open in the crashing process by the time the
dumper scans for it. And we also no longer play any tricks with guessing
the inode number based on the inode of the other descriptor in the socket
pair.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2856092
------------------------------------------------------------------------
r55452 | estade@chromium.org | 2010-08-09 22:09:21 +0200 (Mon, 09 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.css
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js

Content settings exceptions: add validity check.

This is somewhat complicated because we have to do the check in the browser, because it calls into some complicated canonicalization function in net/.

BUG=48862
TEST=try the pattern "foo*", the background should turn red and you shouldn't be able to unfocus the element. (better rejection UI pending design)

Review URL: http://codereview.chromium.org/3036049
------------------------------------------------------------------------
r55450 | phajdan.jr@chromium.org | 2010-08-09 22:04:14 +0200 (Mon, 09 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc

Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.

This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.

Added a comment that PathService::Override should not be called
by production code.

TEST=ui_tests in Release mode
BUG=49838

Review URL: http://codereview.chromium.org/2805100
------------------------------------------------------------------------
r55449 | phajdan.jr@chromium.org | 2010-08-09 22:03:23 +0200 (Mon, 09 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/common/notification_type.h

Fix some problems with TaskManagerBrowserTest.PopulateWebCacheFields:

- wait for an actual update to occur; otherwise we're not testing the real thing
- change DCHECKs to EXPECT_EQs; that's what we should use in tests

This change should also fix the crashiness of this test.

TEST=browser_tests
BUG=42301

Review URL: http://codereview.chromium.org/2856091
------------------------------------------------------------------------
r55437 | albertb@chromium.org | 2010-08-09 21:09:35 +0200 (Mon, 09 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc

Make the username readonly when asking the user to re-login to sync.

Partially from original patch by randy.posynick@gmail.com

BUG=26388,19721,37676
TEST=manually tested

Review URL: http://codereview.chromium.org/3090017
------------------------------------------------------------------------
r55435 | jar@chromium.org | 2010-08-09 21:06:33 +0200 (Mon, 09 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc

(repair leak) Protect instance after commiting to use network

The code was incorrectly protecting an instance of Preconnect
before deciding it would actually perform the async network
calls, and need the instance to stay alive for a callback.
The leak was caused when we exited the function, did not
make the asnyc call, but still incref'ed the instance
expecting a callback to come and decref it.

BUG=51133
r=wtc
Review URL: http://codereview.chromium.org/3086023
------------------------------------------------------------------------
r55432 | chocobo@chromium.org | 2010-08-09 20:59:50 +0200 (Mon, 09 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/network_message_observer.h
   M /trunk/src/chrome/browser/chromeos/network_state_notifier.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h

Clean up code by removing network traffic code in network library.
We are no longer using the code. If we decide that we need it later, we will likely do something different.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3084027
------------------------------------------------------------------------
r55431 | gavinp@google.com | 2010-08-09 20:58:51 +0200 (Mon, 09 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc

Histograms & Field Trails about prefetching

This CL lands some histograms to track prefetching, and a 10% field trial
enabling the feature to track performance.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3036050
------------------------------------------------------------------------
r55430 | jcivelli@chromium.org | 2010-08-09 20:58:18 +0200 (Mon, 09 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h

Fix crasher with download bar.
When dragging out a file, the download bar is shown and disappear automatically once the download is complete.
If the download item menu was opened at that point, we would crash.
This was because showing the menu runs an inner message loop that would process the hide for the download bar, leading to the download item that was on the call-stack to be deleted, causing a crasher once the stack-unwinded and the deleted object was accessed.

BUG=51187
TEST=In GMail, open an email with a large attachment (like 2 MB). Drag the file from GMail to your desktop. Click on the arrow on the item on the download bar to bring up the download menu. Keep the menu open until the download is completed and the bar gets hidden. It should not crash.

Review URL: http://codereview.chromium.org/3052043
------------------------------------------------------------------------
r55428 | csilv@chromium.org | 2010-08-09 20:56:54 +0200 (Mon, 09 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.h
   A /trunk/src/chrome/browser/dom_ui/font_settings_utils.h
   A /trunk/src/chrome/browser/dom_ui/font_settings_utils_gtk.cc
   A /trunk/src/chrome/browser/dom_ui/font_settings_utils_mac.mm
   A /trunk/src/chrome/browser/dom_ui/font_settings_utils_win.cc
   M /trunk/src/chrome/browser/resources/options/font_settings_overlay.html
   M /trunk/src/chrome/browser/resources/options/font_settings_overlay.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/chrome_browser.gypi

dom-ui options: Implement font settings overlay dialog.

BUG=48039
TEST=Exercise font settings in dom-ui options window using --enable-tabbed-options
Review URL: http://codereview.chromium.org/3073006
------------------------------------------------------------------------
r55427 | jcivelli@chromium.org | 2010-08-09 20:55:36 +0200 (Mon, 09 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc

Making sure the BrowserBubble does not notify its delegate after it's been deleted, in an attempt to fix a crasher.

BUG=46757
TEST=See bug

Review URL: http://codereview.chromium.org/3026060
------------------------------------------------------------------------
r55426 | rohitrao@chromium.org | 2010-08-09 20:48:16 +0200 (Mon, 09 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Speculative backout to see if this caused perf regressions.

Revert 55382 - When blocking cookies, also show an icon in the location bar when cookies are accessed.

If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked.

BUG=45230
TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.*

Review URL: http://codereview.chromium.org/3014056

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3095009
------------------------------------------------------------------------
r55419 | ananta@chromium.org | 2010-08-09 19:58:54 +0200 (Mon, 09 Aug 2010) | 34 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/gpu_messages_internal.h
   D /trunk/src/chrome/common/gpu_video_common.cc
   D /trunk/src/chrome/common/gpu_video_common.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_channel.h
   D /trunk/src/chrome/gpu/gpu_video_decoder.cc
   D /trunk/src/chrome/gpu/gpu_video_decoder.h
   D /trunk/src/chrome/gpu/gpu_video_decoder_mft.cc
   D /trunk/src/chrome/gpu/gpu_video_decoder_mft.h
   D /trunk/src/chrome/gpu/gpu_video_service.cc
   D /trunk/src/chrome/gpu/gpu_video_service.h
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/renderer/gpu_channel_host.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   D /trunk/src/chrome/renderer/gpu_video_decoder_host.cc
   D /trunk/src/chrome/renderer/gpu_video_decoder_host.h
   D /trunk/src/chrome/renderer/gpu_video_service_host.cc
   D /trunk/src/chrome/renderer/gpu_video_service_host.h
   D /trunk/src/chrome/renderer/media/ipc_video_decoder.cc
   D /trunk/src/chrome/renderer/media/ipc_video_decoder.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/media/base/media_switches.cc
   M /trunk/src/media/base/media_switches.h
   M /trunk/src/media/filters/ffmpeg_demuxer.cc

Revert 55405 - Special thanks for in-ming cheng's MFT hardware decodering code.

1. ipc_video_decoder.cc/h is media pipeline filter which use the gpu decoder facilities in video stack. it is only enabled when (a) hardware composition is on (b) hardware decoding command line is on (c) h264 codec is specified.

2. gpu_video_service.cc/h is a singleton in gpu process which provide video services for renderer process, through it we could create decoder. ( in my imagination, in the future, we could create encoder or capturer too)

3. gpu_video_decoder.cc/h. abstract interface for hardware decoder.

4. gpu_video_decoder_mft.cc/h  media foundation transform hardware decoder which run on windows 7 only.

5. gpu_video_service_host.cc/h is singleton in renderer process which provide proxy for gpu_video_service.

6. gpu_video_decoder_host.cc/h is proxy for gpu_video_decoder. (1 to 1 map).basically there is one global GpuVideoService in GPU process, one GpuVideoServiceHost in Renderer process. for each renderer process, there are could be multiple renderer view, each could had multiple GpuVideoDecoderHost the connect to GpuVideoDeocder through GPUCHannelHOst/GpuChannel.

7. gpu_video_common.cc/h: IPC message definition and pickle/marshaling support.

ISSUES:

1. in media pipeline, we need let decoder to determine if bit stream filter should be used instead of let command line to determine it.
2. stop readback from D3D surface use ANGLE.
3. Flush logic still need fine tuning.
4. CreateThread in GpuVideoDecoder, and post message in message handler, and derived classs handle message loop. ?
5. Error handling.
6. Input ring buffer implementation. Current impl is naive.
7.Add output queue for MFT decoder.
8. Query Capabilities at GetVideoServices()...

BUG=None
TEST=Windows7

Review URL: http://codereview.chromium.org/2873089

TBR=jiesun@google.com
Review URL: http://codereview.chromium.org/3020077
------------------------------------------------------------------------
r55408 | sky@chromium.org | 2010-08-09 18:33:08 +0200 (Mon, 09 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Fixes bug where the billing address combobox would not show newly
created addresses. This also fixes bug where removing address or
changing address would not be reflected in billing address combobox.

BUG=51217
TEST=see bug

Review URL: http://codereview.chromium.org/3038052
------------------------------------------------------------------------
r55406 | pinkerton@google.com | 2010-08-09 18:06:58 +0200 (Mon, 09 Aug 2010) | 28 lines
Changed paths:
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   D /trunk/src/chrome/browser/importer/importer_messages.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/common_param_traits.h
   D /trunk/src/chrome/common/devtools_messages.cc
   D /trunk/src/chrome/common/gpu_messages.cc
   D /trunk/src/chrome/common/nacl_messages.cc
   M /trunk/src/chrome/common/nacl_messages_internal.h
   D /trunk/src/chrome/common/plugin_messages.cc
   D /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/common/service_messages.cc
   D /trunk/src/chrome/common/utility_messages.cc
   D /trunk/src/chrome/common/worker_messages.cc
   D /trunk/src/chrome/test/automation/automation_messages.cc
   M /trunk/src/ipc/ipc_fuzzing_tests.cc
   D /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/ipc/ipc_message_utils.h
   D /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/sync_socket_unittest.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h

Revert 55259 - FBTF: New IPC definitions, only applied to async ROUTED and CONTROL messages.

The slowest cc files in chrome include render_messages.h and other IPC message
definitions. Including one of these files will bring in half of chrome because
in the IPC system previously required full class definitions due to
implementation details.

The new system allows forward declarations and places the implementations of
functions that need the full class definitions (ctor/dtor()/Log() and
superclass ctor/Read() methods) into a separate xxx_messages.cc file using a
parallel set of macros to ipc_message_macros.h. This has the added benefit
of moving most of the template instantiation junk into a small number of
files.

Pros:
- Will speed up compiling by a lot once everything is forward declared.
- Already, intermediary .o/.a files are smaller.

Cons:
- Adds a 4th pass to the messages system, this time in a different header.

BUG=51411
TEST=none

Review URL: http://codereview.chromium.org/2873090

TBR=erg@google.com
Review URL: http://codereview.chromium.org/3080040
------------------------------------------------------------------------
r55405 | jiesun@google.com | 2010-08-09 17:59:44 +0200 (Mon, 09 Aug 2010) | 31 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/gpu_messages_internal.h
   A /trunk/src/chrome/common/gpu_video_common.cc
   A /trunk/src/chrome/common/gpu_video_common.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_channel.h
   A /trunk/src/chrome/gpu/gpu_video_decoder.cc
   A /trunk/src/chrome/gpu/gpu_video_decoder.h
   A /trunk/src/chrome/gpu/gpu_video_decoder_mft.cc
   A /trunk/src/chrome/gpu/gpu_video_decoder_mft.h
   A /trunk/src/chrome/gpu/gpu_video_service.cc
   A /trunk/src/chrome/gpu/gpu_video_service.h
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/renderer/gpu_channel_host.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   A /trunk/src/chrome/renderer/gpu_video_decoder_host.cc
   A /trunk/src/chrome/renderer/gpu_video_decoder_host.h
   A /trunk/src/chrome/renderer/gpu_video_service_host.cc
   A /trunk/src/chrome/renderer/gpu_video_service_host.h
   A /trunk/src/chrome/renderer/media/ipc_video_decoder.cc
   A /trunk/src/chrome/renderer/media/ipc_video_decoder.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/media/base/media_switches.cc
   M /trunk/src/media/base/media_switches.h
   M /trunk/src/media/filters/ffmpeg_demuxer.cc

Special thanks for in-ming cheng's MFT hardware decodering code.

1. ipc_video_decoder.cc/h is media pipeline filter which use the gpu decoder facilities in video stack. it is only enabled when (a) hardware composition is on (b) hardware decoding command line is on (c) h264 codec is specified.

2. gpu_video_service.cc/h is a singleton in gpu process which provide video services for renderer process, through it we could create decoder. ( in my imagination, in the future, we could create encoder or capturer too)

3. gpu_video_decoder.cc/h. abstract interface for hardware decoder.

4. gpu_video_decoder_mft.cc/h  media foundation transform hardware decoder which run on windows 7 only.

5. gpu_video_service_host.cc/h is singleton in renderer process which provide proxy for gpu_video_service.

6. gpu_video_decoder_host.cc/h is proxy for gpu_video_decoder. (1 to 1 map).basically there is one global GpuVideoService in GPU process, one GpuVideoServiceHost in Renderer process. for each renderer process, there are could be multiple renderer view, each could had multiple GpuVideoDecoderHost the connect to GpuVideoDeocder through GPUCHannelHOst/GpuChannel.

7. gpu_video_common.cc/h: IPC message definition and pickle/marshaling support.

ISSUES:

1. in media pipeline, we need let decoder to determine if bit stream filter should be used instead of let command line to determine it.
2. stop readback from D3D surface use ANGLE.
3. Flush logic still need fine tuning.
4. CreateThread in GpuVideoDecoder, and post message in message handler, and derived classs handle message loop. ?
5. Error handling.
6. Input ring buffer implementation. Current impl is naive.
7.Add output queue for MFT decoder.
8. Query Capabilities at GetVideoServices()...

BUG=None
TEST=Windows7

Review URL: http://codereview.chromium.org/2873089
------------------------------------------------------------------------
r55399 | sky@chromium.org | 2010-08-09 17:18:17 +0200 (Mon, 09 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Adds some experimental stuff for tab preview: ability to determine max
screen position of popup and current url in omnibox.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3076040
------------------------------------------------------------------------
r55394 | bauerb@chromium.org | 2010-08-09 15:32:29 +0200 (Mon, 09 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/plugin_updater.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/blocked_plugin.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/resources/blocked_plugin.html

Disable outdated non-sandboxed plugins.

Relanding r55227, which had a compile error.

BUG=47731
TEST=Run with --disable-outdated-plugins

Review URL: http://codereview.chromium.org/3071028
------------------------------------------------------------------------
r55382 | jochen@chromium.org | 2010-08-09 08:55:01 +0200 (Mon, 09 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

When blocking cookies, also show an icon in the location bar when cookies are accessed.

If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked.

BUG=45230
TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.*

Review URL: http://codereview.chromium.org/3014056
------------------------------------------------------------------------
r55379 | satorux@chromium.org | 2010-08-09 08:16:06 +0200 (Mon, 09 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler_unittest.cc

Comment out test expectations that failed on the build bot

The GetLanguageList test passes fine locally if it's run as
"unit_tests -gtest_filter='*LanguageOptionsHandlerTest*'"
but it fails if it's run as "unit_tests" (i.e. run all tests
in unit_tests) for some reason.
For now, comment out the expectations that failed.

TEST=manually
BUG=chromium-os:5479

Review URL: http://codereview.chromium.org/3098003
------------------------------------------------------------------------
r55377 | ziadh@chromium.org | 2010-08-09 07:14:49 +0200 (Mon, 09 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket/client_socket_pool_histograms.cc
   M /trunk/src/net/socket/client_socket_pool_histograms.h

More metrics for proxy connections impact A/B test.

I added socket request times (for new/unused sockets). The hypothesis is that
if proxy servers get overloaded, we will see an increase in request times for
new sockets. Hence, we know that we should tone back a little.

BUG=44501
r=jar

Review URL: http://codereview.chromium.org/3040049
------------------------------------------------------------------------
r55376 | satorux@chromium.org | 2010-08-09 05:27:21 +0200 (Mon, 09 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler_unittest.cc

Add tests for LanguageOptionsHandler using the stub cros library.

TEST=unit_tests --gtest_filter='*LanguageOptionsHandlerTest*'
BUG=none

Review URL: http://codereview.chromium.org/2836093
------------------------------------------------------------------------
r55375 | tfarina@chromium.org | 2010-08-09 04:26:37 +0200 (Mon, 09 Aug 2010) | 17 lines
Changed paths:
   M /trunk/src/base/registry.cc
   M /trunk/src/base/registry.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/installer/util/google_update_settings_unittest.cc

Cleanup our Registry API.

- Use wchar_t instead of TCHAR.
- Use DCHECK instead of assert.
- Remove this keyword (we don't use it on chromium).
- Add DISALLOW_COPY_AND_ASSIGN to the classes.
- Make it more compliant with chromium code style.
- Remove ununsed methods.
- Use arraysize macro for array size calculation instead of doing it manually.

BUG=44644
TEST=trybots

TODO: Write unittests for this API.
TODO: Remove all the default arguments from the methods in this API. They aren't allowed by our style guide.

Review URL: http://codereview.chromium.org/3007037
------------------------------------------------------------------------
r55374 | satorux@chromium.org | 2010-08-09 04:07:39 +0200 (Mon, 09 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options_page.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/options_page.css

Fix style issues in CSS files of DOMUI options:: 0px -> 0.

Per our CSS style guide: Don't give units for 0 values.

BUG=none
TEST=run chrome and check appearances

Review URL: http://codereview.chromium.org/2836092
------------------------------------------------------------------------
r55373 | satorux@chromium.org | 2010-08-09 03:51:38 +0200 (Mon, 09 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Add realistic data to InputMethodLibraryStubImpl.

This will make it easy to test chrome os version of chrome
on regular linux desktops, as well as writing unit tests.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/3085023
------------------------------------------------------------------------
r55371 | viettrungluu@chromium.org | 2010-08-08 23:11:12 +0200 (Sun, 08 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/time_format.cc

Convert occurrences of WideToUTF{8,16}(l10n_util::GetString...() ...

... to l10n::GetString...UTF{8,16}().

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3054052
------------------------------------------------------------------------
r55367 | brettw@chromium.org | 2010-08-08 19:18:22 +0200 (Sun, 08 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/protocol/service_constants.h
   M /trunk/src/chrome/browser/sync/sessions/ordered_commit_set.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/path_name_cmp.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/crypto_helpers.h
   M /trunk/src/chrome/browser/sync/util/data_encryption.h
   D /trunk/src/chrome/browser/sync/util/sync_types.h
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/sync/util/user_settings_posix.cc
   M /trunk/src/chrome/test/live_sync/multiple_client_live_preferences_sync_test.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Remove sync_types.h. No functions from this file are used, and some of them are
explicitly disallowed in Google code (DWORD).

This implicitly brought string_util into a number of files which got ASCII
conversion routimes. I replaced these with *ToUTF8 from utf_string_conversions
since I am trying to delete WideToASCII.

TEST=it compiles
BUG=none

Review URL: http://codereview.chromium.org/3063021
------------------------------------------------------------------------
r55366 | viettrungluu@chromium.org | 2010-08-08 08:17:43 +0200 (Sun, 08 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h

De-wstring/wchar_t-ify extensions DOM UI as much as currently possible.

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/2808110
------------------------------------------------------------------------
r55361 | thakis@chromium.org | 2010-08-08 01:07:58 +0200 (Sun, 08 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac_unittest.mm
   M /trunk/src/chrome/browser/task_manager.h

Mac: Fix kill button and selection in task manager

BUG=51488,51486
TEST=Sort on a changing column such as %cpu or goats teleported. The selection should follow the selected rows (i.e. if the "maps" process jumps from row 2 to row 4, the selected row should follow). "Kill process" should kill the currently selected process, not the process that's at that index when no sorting is happening.

Review URL: http://codereview.chromium.org/3047055
------------------------------------------------------------------------
r55360 | viettrungluu@chromium.org | 2010-08-07 22:52:10 +0200 (Sat, 07 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h

Change TipsHandler::SendTip() to take const std::string& rather than std::string.

(This was noticed by thakis in some previous review.)

BUG=none
TEST=none
TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/3066042
------------------------------------------------------------------------
r55359 | viettrungluu@chromium.org | 2010-08-07 21:44:18 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc

Convert browser/dom_ui/n*.cc to not use wstrings/wchar_t*s (insofar as possible).

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3067039
------------------------------------------------------------------------
r55356 | viettrungluu@chromium.org | 2010-08-07 19:38:29 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.cc
   M /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.cc
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h

Convert browser/dom_ui/[st]*.cc to not use wstrings/wchar_t*s (insofar as possible).

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3063030
------------------------------------------------------------------------
r55355 | viettrungluu@chromium.org | 2010-08-07 19:16:11 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc

Convert browser/dom_ui/[o-r]*.cc to not use wstrings/wchar_t*s.

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3014060
------------------------------------------------------------------------
r55349 | thestig@chromium.org | 2010-08-07 09:24:21 +0200 (Sat, 07 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_exe_main_gtk.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/proxy_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc
   M /trunk/src/chrome/browser/views/location_bar/selected_keyword_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome_frame/test/run_all_unittests.cc
   M /trunk/src/ipc/ipc_tests.cc
   M /trunk/src/media/audio/fake_audio_input_stream.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.cc
   M /trunk/src/remoting/client/plugin/chromoting_instance.h
   M /trunk/src/remoting/host/host_key_pair_unittest.cc
   M /trunk/src/views/view_text_utils.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_thread_async_call_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_thread_async_call_test.h

FBTF: Remove unneeded headers from base/ (part 5)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3041049
------------------------------------------------------------------------
r55346 | viettrungluu@chromium.org | 2010-08-07 09:00:46 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.cc

Convert browser/dom_ui/f*.cc to not use wstrings/wchar_t*s.

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3037052
------------------------------------------------------------------------
r55345 | thestig@chromium.org | 2010-08-07 08:23:24 +0200 (Sat, 07 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_events.cc
   M /trunk/src/chrome/browser/accessibility_events.h
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/browser_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_view.cc
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/configuration_policy_provider.h
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.h
   M /trunk/src/chrome/browser/dummy_pref_store.cc
   M /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_processes_api.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/browser/net/predictor_unittest.cc
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/browser/password_manager/encryptor.h
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/scoped_pref_update.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/common/extensions/update_manifest.cc
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/master_preferences_dummy.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/service/cloud_print/job_status_updater.cc
   M /trunk/src/chrome/service/cloud_print/print_system_cups.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome_frame/np_proxy_service.h

FBTF: Remove unneeded headers from base/ (part 4)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819094
------------------------------------------------------------------------
r55344 | viettrungluu@chromium.org | 2010-08-07 08:22:21 +0200 (Sat, 07 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h

Convert browser/dom_ui/[g-m]*.cc to not use wstrings/wchar_t*s.

At least the easy cases anyway.

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3094004
------------------------------------------------------------------------
r55343 | viettrungluu@chromium.org | 2010-08-07 08:06:05 +0200 (Sat, 07 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc

Convert browser/dom_ui/d*.cc to not use wstrings/wchar_t*s.

(Well, the super-easy cases anyway.)

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3036052
------------------------------------------------------------------------
r55342 | viettrungluu@chromium.org | 2010-08-07 07:52:29 +0200 (Sat, 07 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc

Convert browser/dom_ui/c*.cc to not use wstrings/wchar_t*s ...

... except those still required by prefs. (I'm working on that separately.)

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3075027
------------------------------------------------------------------------
r55340 | viettrungluu@chromium.org | 2010-08-07 07:35:28 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc

Convert browser/dom_ui/browser_options_handler.cc to stop using wstrings/wchar_t*s.

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3061059
------------------------------------------------------------------------
r55339 | viettrungluu@chromium.org | 2010-08-07 07:34:01 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc

Convert browser/dom_ui/a*.cc to not use wstrings/wchar_t*s.

BUG=23581
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3078032
------------------------------------------------------------------------
r55327 | rsesek@chromium.org | 2010-08-07 04:59:31 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_button_cell.mm

[Mac] Do not use |+[NSColor selectedMenuItemColor]| in a gradient due to color space issues.

BUG=49448
TEST=On both 10.5 and 10.6, open the Wrench menu and click a button. Button has blue gradient.

Review URL: http://codereview.chromium.org/3046052
------------------------------------------------------------------------
r55326 | tfarina@chromium.org | 2010-08-07 04:57:59 +0200 (Sat, 07 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/base/base_paths_posix.cc
   M /trunk/src/base/environment.cc
   M /trunk/src/base/environment.h
   M /trunk/src/base/environment_unittest.cc
   M /trunk/src/base/xdg_util.cc
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/chrome/test/startup/shutdown_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/courgette/encoded_program.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

base: rename Environment::GetEnv to Environment::GetVar.

This is the part 4 and the latest of this series.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3029062
------------------------------------------------------------------------
r55316 | erikchen@google.com | 2010-08-07 01:50:37 +0200 (Sat, 07 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   D /trunk/src/chrome/browser/remoting
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert 55311 - Add remoting to wrench menu.

This change adds remoting item to wrench menu.
The change is under flag enable-remoting, so end users will not see it.

The CL is cleaned up. It was compiling and working. I added the check for kEnableRemoting and resynched and it is no longer compiling.

Submitted for: pranavk@chromium.org
Reviewed: http://codereview.chromium.org/3075024/show

BUG=50242
TEST=NONE

Review URL: http://codereview.chromium.org/3080038

TBR=hclam@chromium.org
------------------------------------------------------------------------
r55311 | hclam@chromium.org | 2010-08-07 01:17:43 +0200 (Sat, 07 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/remoting
   A /trunk/src/chrome/browser/remoting/setup.cc
   A /trunk/src/chrome/browser/remoting/setup.h
   A /trunk/src/chrome/browser/remoting/setup_flow.cc
   A /trunk/src/chrome/browser/remoting/setup_flow.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi

Add remoting to wrench menu.

This change adds remoting item to wrench menu.
The change is under flag enable-remoting, so end users will not see it.

The CL is cleaned up. It was compiling and working. I added the check for kEnableRemoting and resynched and it is no longer compiling.

Submitted for: pranavk@chromium.org
Reviewed: http://codereview.chromium.org/3075024/show

BUG=50242
TEST=NONE

Review URL: http://codereview.chromium.org/3080038
------------------------------------------------------------------------
r55305 | jeremy@chromium.org | 2010-08-07 01:01:44 +0200 (Sat, 07 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

[Mac] Don't fade text on bookmark items if we don't have to.

Fix a float <-> int comparison so items whose width is fractionally larger than the width of the cell aren't truncated.

BUG=51183
TEST=See bug

Review URL: http://codereview.chromium.org/3096007
------------------------------------------------------------------------
r55303 | ziadh@chromium.org | 2010-08-07 00:55:46 +0200 (Sat, 07 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h

Bad interaction between 2 A/B experiments

There is a 1/20 chance that the max number of sockets per group be greater than
the max number of sockets per proxy server. This would result in hitting a
DCHECK in client_socket_pool_base.cc:145. This CL attempts to circumvent that
event.

r=jar


Review URL: http://codereview.chromium.org/3044051
------------------------------------------------------------------------
r55301 | chocobo@chromium.org | 2010-08-07 00:52:56 +0200 (Sat, 07 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_message_observer.cc
   M /trunk/src/chrome/browser/chromeos/network_message_observer.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc

When user enters wrong password or bad wep key, we popup the login dialog again with an error message.
BUG=chromium-os:2556
TEST=manual
Review URL: http://codereview.chromium.org/2808108
------------------------------------------------------------------------
r55298 | rsesek@chromium.org | 2010-08-07 00:50:51 +0200 (Sat, 07 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.mm

[Mac] Make the default background style for InfoBubbleView white, per alcor.

This affects the bookmark bubble and the extension installed bubble.

BUG=51429
TEST=Press the Star button. Resulting bubble has a white, not gradient, background.

Review URL: http://codereview.chromium.org/3038054
------------------------------------------------------------------------
r55296 | albertb@chromium.org | 2010-08-07 00:47:54 +0200 (Sat, 07 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/nigori.cc
   M /trunk/src/chrome/browser/sync/util/nigori.h
   M /trunk/src/chrome/browser/sync/util/nigori_unittest.cc

Cleanup: Remove now obsolete Nigori params.

BUG=none
TEST=NigoriTest.*

Review URL: http://codereview.chromium.org/3088002
------------------------------------------------------------------------
r55289 | pvalchev@google.com | 2010-08-06 23:34:43 +0200 (Fri, 06 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/app/test_suite.h
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/renderer_preferences_util.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/native_web_keyboard_event.h

rid of more OS_LINUX defines, to help the BSD port (work by sprewell & I)
Review URL: http://codereview.chromium.org/2089010
------------------------------------------------------------------------
r55282 | suzhe@chromium.org | 2010-08-06 22:47:09 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Prevent browser actions toolbar's overflow button from being shown unexpectedly.

BUG=51268
TEST=See bug report.

Review URL: http://codereview.chromium.org/3073035
------------------------------------------------------------------------
r55280 | rsesek@chromium.org | 2010-08-06 22:43:07 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/accelerators_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_accessibility_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bubble_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_picker_table_unittest.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac_unittest.mm

[Mac] Use the new {EXPECT,ASSERT}_NS{EQ,NE} macros in unit tests where possible.

BUG=none
TEST=unit_tests

Review URL: http://codereview.chromium.org/3095004
------------------------------------------------------------------------
r55274 | johnnyg@chromium.org | 2010-08-06 22:21:50 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.h

In RenderViewHostDelegate::View, distinguish between MouseMove() and MouseDown() events, previously combined in a single MouseEvent().  This is a preliminary patch to allowing desktop notifications to capture click events, which require capturing MouseDown but not MouseOver.

BUG=51226
TEST=none

Review URL: http://codereview.chromium.org/3072023
------------------------------------------------------------------------
r55268 | phajdan.jr@chromium.org | 2010-08-06 21:46:57 +0200 (Fri, 06 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/data/profiles/typical_history/Default/History
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Revert "Replace --top-sites flag with --no-top-sites flag. TopSites becomes the default."

Introduced new crashes.

TBR=nshkrob

Review URL: http://codereview.chromium.org/3026059
------------------------------------------------------------------------
r55263 | shess@chromium.org | 2010-08-06 20:11:02 +0200 (Fri, 06 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm

[Mac] Don't indicate acceptance of non-url drag data.

If -performDragOperation: won't accept the data, then
-draggingEntered: and -draggingUpdated: also need to deny the drag so
that the OS doesn't show the drop indicator.

BUG=32139
TEST=Try to drop an image from TextEdit into Omnibox or tab bar.

Review URL: http://codereview.chromium.org/3077027
------------------------------------------------------------------------
r55262 | jshin@chromium.org | 2010-08-06 20:03:51 +0200 (Fri, 06 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/skia/ext/SkFontHost_fontconfig.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.h

Make SkFontHost_fontconfig support TTC font files.

In addition to this change, third_party/skia/src/port/SkFontHost_Freetype.cpp
needs a couple of lines changed. 

The Skia part is at http://codereview.appspot.com/1847046/show

BUG=50389
TEST=Install ttf-wqy-microhei package on Ubuntu and go to http://i18nl10n.com/chrome/ttc2.html. Latin letters in the 1st line should be monospaced while they're proportional in the second line. 

Review URL: http://codereview.chromium.org/2870073
------------------------------------------------------------------------
r55261 | sky@chromium.org | 2010-08-06 20:01:28 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc

Fixes regression the resulted in not showing window after doing a tab
restore in some situations.

BUG=51255
TEST=create a new window with one tab, press control-w to close the
window, restore the window by way of control-shift-t and make sure you
can see the window.

Review URL: http://codereview.chromium.org/3091012
------------------------------------------------------------------------
r55259 | erg@google.com | 2010-08-06 19:55:32 +0200 (Fri, 06 Aug 2010) | 25 lines
Changed paths:
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   A /trunk/src/chrome/browser/importer/importer_messages.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/common_param_traits.h
   A /trunk/src/chrome/common/devtools_messages.cc
   A /trunk/src/chrome/common/gpu_messages.cc
   A /trunk/src/chrome/common/nacl_messages.cc
   M /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/plugin_messages.cc
   A /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/service_messages.cc
   A /trunk/src/chrome/common/utility_messages.cc
   A /trunk/src/chrome/common/worker_messages.cc
   A /trunk/src/chrome/test/automation/automation_messages.cc
   M /trunk/src/ipc/ipc_fuzzing_tests.cc
   A /trunk/src/ipc/ipc_message_impl_macros.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/ipc/ipc_message_utils.h
   A /trunk/src/ipc/ipc_message_utils_impl.h
   M /trunk/src/ipc/sync_socket_unittest.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h

FBTF: New IPC definitions, only applied to async ROUTED and CONTROL messages.

The slowest cc files in chrome include render_messages.h and other IPC message
definitions. Including one of these files will bring in half of chrome because
in the IPC system previously required full class definitions due to
implementation details.

The new system allows forward declarations and places the implementations of
functions that need the full class definitions (ctor/dtor()/Log() and
superclass ctor/Read() methods) into a separate xxx_messages.cc file using a
parallel set of macros to ipc_message_macros.h. This has the added benefit
of moving most of the template instantiation junk into a small number of
files.

Pros:
- Will speed up compiling by a lot once everything is forward declared.
- Already, intermediary .o/.a files are smaller.

Cons:
- Adds a 4th pass to the messages system, this time in a different header.

BUG=51411
TEST=none

Review URL: http://codereview.chromium.org/2873090
------------------------------------------------------------------------
r55257 | agl@chromium.org | 2010-08-06 19:51:04 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/snippet_unittest.cc

Rebase ThaiUTF8 unit test.

TEST=unit_tests
BUG=50705

http://codereview.chromium.org/3085005
------------------------------------------------------------------------
r55253 | estade@chromium.org | 2010-08-06 19:40:53 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc

GTK toolbar -

- fix vertical height in gtk theme mode
- fix reload button showing two images when switching from gtk to chrome theme mode

BUG=51325
TEST=1) switch from gtk to chrome theme mode, look at stop/reload 2) change desktop document font size from 10 to 18 in gtk theme mode, the omnibox should size appropriately for each font.

Review URL: http://codereview.chromium.org/3086021
------------------------------------------------------------------------
r55247 | albertb@chromium.org | 2010-08-06 19:26:49 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/protocol/nigori_specifics.proto
   M /trunk/src/chrome/browser/sync/util/cryptographer.cc

Export and imports raw keys in the Cryptographer.

BUG=48701
TEST=CryptographerTest.*

Review URL: http://codereview.chromium.org/3043046
------------------------------------------------------------------------
r55246 | xiyuan@chromium.org | 2010-08-06 19:26:42 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.cc

Respect original dialog's default/focus widget in NativeDialogHost.

BUG=chromium-os:4005
TEST=Verify fix for chromium-os:4005.

Review URL: http://codereview.chromium.org/3063027
------------------------------------------------------------------------
r55244 | nshkrob@chromium.org | 2010-08-06 19:20:34 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/data/profiles/typical_history/Default/History
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Replace --top-sites flag with --no-top-sites flag. TopSites becomes the default.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/3054028
------------------------------------------------------------------------
r55241 | rdsmith@chromium.org | 2010-08-06 19:16:37 +0200 (Fri, 06 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_store_test.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

More cleanup relating to the domain now being part of the CanonicalCookie:
* Simplify DeleteCookie(CanonicalCookie) API
* Get rid of KeyedCanonicalCookie type; not needed.

BUG=8850
TEST=Try bots, net_unittest --gtest_filter=CookieMonsterTest.* (refactor, so tests should all keep passing.)

Review URL: http://codereview.chromium.org/3095002
------------------------------------------------------------------------
r55240 | asargent@chromium.org | 2010-08-06 19:13:26 +0200 (Fri, 06 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   A /trunk/src/chrome/test/data/extensions/context_menus/separators
   A /trunk/src/chrome/test/data/extensions/context_menus/separators/common.js
   A /trunk/src/chrome/test/data/extensions/context_menus/separators/manifest.json
   A /trunk/src/chrome/test/data/extensions/context_menus/separators/test1.html
   A /trunk/src/chrome/test/data/extensions/context_menus/separators/test1.js
   A /trunk/src/chrome/test/data/extensions/context_menus/separators/test2.html
   A /trunk/src/chrome/test/data/extensions/context_menus/separators/test2.js

Fixes to separators in context menu items added by extensions.

This fixes two problems:
-While the API let you add your own separator items, we weren't actually 
 displaying those.
-There is some logic about automatically inserting separators for groups of 
 radio items, but it didn't work correctly (it inserted one if the very first
 item was a radio item).

BUG=49730
TEST=Steps are outlined in bug. Also the browser test added should hopefully 
cover the relevant cases.

Review URL: http://codereview.chromium.org/3026056
------------------------------------------------------------------------
r55239 | arv@chromium.org | 2010-08-06 19:10:10 +0200 (Fri, 06 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_model_test.html
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_single_selection_model_test.html

DOM UI js: Add a single selection model.

Usage: list.selectionModel = new ListSingleSelectionModel

Once an item is selected the user has no way to make no items selected. You can still programmatically unselect all and changes to the data model can also cause cause no selection.

BUG=49893
TEST=I added a basic unit test (needs to be run manually). I also tested this in a simple demo app.

Review URL: http://codereview.chromium.org/2884064
------------------------------------------------------------------------
r55236 | phajdan.jr@chromium.org | 2010-08-06 18:53:33 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Undisable SessionHistoryTest.HistoryLength

There is not enough data to see what is happening.
Test itself seems to be fine.

TEST=ui_tests
BUG=38583

Review URL: http://codereview.chromium.org/3093007
------------------------------------------------------------------------
r55234 | mirandac@chromium.org | 2010-08-06 18:36:41 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Make status bubble behave properly in RTL languages.

BUG=49913
TEST= In RTL language, cause many status bubbles to appear. Hover over some to cause expansion. Bubble behaves correctly.

Review URL: http://codereview.chromium.org/3085018
------------------------------------------------------------------------
r55229 | bauerb@chromium.org | 2010-08-06 17:50:57 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/plugin_updater.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/blocked_plugin.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/resources/blocked_plugin.html

Revert 55227 - Disable outdated non-sandboxed plugins.

BUG=47731
TEST=Run with --disable-outdated-plugins

Review URL: http://codereview.chromium.org/3038051

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/3083021
------------------------------------------------------------------------
r55227 | bauerb@chromium.org | 2010-08-06 17:38:29 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/blocked_plugin_manager.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/plugin_updater.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/blocked_plugin.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/resources/blocked_plugin.html

Disable outdated non-sandboxed plugins.

BUG=47731
TEST=Run with --disable-outdated-plugins

Review URL: http://codereview.chromium.org/3038051
------------------------------------------------------------------------
r55224 | cbentzel@chromium.org | 2010-08-06 16:09:30 +0200 (Fri, 06 Aug 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_tracker.cc
   M /trunk/src/net/url_request/url_request_job_tracker.h
   A /trunk/src/net/url_request/url_request_job_tracker_unittest.cc

Add the actual data being read to the OnBytesRead callback, take two.

This change was originally committed as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53178
then rolled back as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53416
due to a breakage in FLAKY_UnknownSize download test.
FLAKY_UnknownSize depended on code with a bug that was exposed by this change. That bug has since been fixed and committed as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53876

So this change is ready for another round of review. It has not changed at all since being committed.

Contributed by: bmcquade@google.com

BUG=48192
TEST=Added new unit tests, ran net_unittests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54448

Review URL: http://codereview.chromium.org/3010037
------------------------------------------------------------------------
r55222 | viettrungluu@chromium.org | 2010-08-06 16:07:16 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_util.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.h
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.h
   M /trunk/src/chrome/browser/tabs/pinned_tab_service.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/translate/languages_menu_model.h
   M /trunk/src/chrome/browser/translate/options_menu_model.h

Minor header cleanup of chrome/browser/[st]*/*.h minus c/b/sync/*.h.

- Remove unnecessary forward decls.
- Remove unnecessary inclusions of <set>, <map>, <vector>, <list>.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3023043
------------------------------------------------------------------------
r55218 | finnur@chromium.org | 2010-08-06 14:18:16 +0200 (Fri, 06 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc

Uninitialized member in BrowserKeyboardAccessibility.

BUG=None
TEST=None
CID= 12238

Review URL: http://codereview.chromium.org/3086019
------------------------------------------------------------------------
r55217 | loislo@chromium.org | 2010-08-06 13:44:57 +0200 (Fri, 06 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   A /trunk/src/chrome/test/data/extensions/manifest_tests/devtools_extension.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/devtools_extension_no_permissions.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/devtools_extension_url_invalid_type.json

Added devtools_page field to extension manifest to specify a page loaded into devtools front-end.
Added support for enumerating devtools extensions in devtools' DOM UI.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3074025
------------------------------------------------------------------------
r55214 | danno@chromium.org | 2010-08-06 13:26:33 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memory leak in policy refresh implementation

TEST=PrefValueStoreTest.*
BUG=51176

Review URL: http://codereview.chromium.org/3031047
------------------------------------------------------------------------
r55213 | jochen@chromium.org | 2010-08-06 13:14:09 +0200 (Fri, 06 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/test/testing_pref_service.h

Introduce a resource identifier for content settings.

This will allow for having per plugin content settings, i.e. the content settings type would be plugin and the resource identifier would be to concrete plugin that is about to be loaded.

BUG=39252
TEST=unit_tests

Review URL: http://codereview.chromium.org/2878075
------------------------------------------------------------------------
r55211 | satorux@chromium.org | 2010-08-06 12:14:16 +0200 (Fri, 06 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css

Tweak CSS so that very long language names are folded in left-aligned.

For some reason, this is necessary to fold very long language names
into two lines in left-aligned. Example:

Spanish (Latin America and the Caribbean) - español (Latinoamérica y el Caribe)

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3085021
------------------------------------------------------------------------
r55210 | satorux@chromium.org | 2010-08-06 12:02:05 +0200 (Fri, 06 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Fix a bug where we were showing duplicate language names in the add language overlay.

We should've used "set" rather than "vector" to remove duplicates.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3043058
------------------------------------------------------------------------
r55204 | joth@chromium.org | 2010-08-06 11:32:44 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.h

Speculative fix for chromium-os:4706 - use singleton NetworkLibrary rather than create our own

BUG=chromium-os:4706
TEST=open chrome os, go to maps.google.com click my location, check it doesn't crash.

Review URL: http://codereview.chromium.org/3027042
------------------------------------------------------------------------
r55202 | pam@chromium.org | 2010-08-06 10:51:50 +0200 (Fri, 06 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/test/testing_pref_service.cc
   M /trunk/src/chrome/test/testing_pref_service.h

Move creation of the PrefStores into the PrefValueStore, to reduce the knowledge the PrefService has of its two-levels-deep implementation.

Create a TestingPrefService::TestingPrefValueStore to allow tests to set the PrefStores directly, as they used to be able to do.

BUG=50722
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/3032058
------------------------------------------------------------------------
r55201 | akalin@chromium.org | 2010-08-06 10:41:19 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   A /trunk/src/chrome/browser/sync/protocol/app_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Added constants, strings, protos for app sync.

BUG=51225
TEST=none needed

Review URL: http://codereview.chromium.org/3072022
------------------------------------------------------------------------
r55197 | jar@chromium.org | 2010-08-06 09:10:24 +0200 (Fri, 06 Aug 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   A /trunk/src/net/socket/client_socket.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool_base.h

Reland 54771 (and 54795) To enable TCP Preconnection by default

I pulled out the code to update the socket connectivity stats.

I added defensive code which should preclude the crash that 
was reported on the stability bot.

I added a second call to update the stats from
~ClientSocketHandle to ensure that we updated the
related ClientSocket when we are torn down.

As noted in the original checkin:

Enable speculative preconnection by default

Added histogram to track preconnection utilization (vs waste).

BUG=42694
r=mbelshe
Review URL: http://codereview.chromium.org/3050040
------------------------------------------------------------------------
r55196 | dmazzoni@chromium.org | 2010-08-06 09:07:18 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/accessibility_event_router_views.cc
   M /trunk/src/chrome/browser/views/accessibility_event_router_views.h
   M /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views.gyp

Improvements to accessibility extension api support for "views":
1. Handles the new wrench menu.
2. Uses NotifyAccessibilityEvent to find out when focus changes, rather
     than installing focus change listeners that need to be cleaned up.

BUG=none
TEST=Updated AccessibilityEventRouterViewsTest.TestFocusNotification

Review URL: http://codereview.chromium.org/3056045
------------------------------------------------------------------------
r55195 | satorux@chromium.org | 2010-08-06 08:55:51 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h

Build the language list just like we do in the C++ version.

Build the language list from supported input methods, as well
as kExtraLanguages which don't have associated input methods.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3072028
------------------------------------------------------------------------
r55193 | satorux@chromium.org | 2010-08-06 08:32:02 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc

Add chromeos namespace to the language options page and its friends.

BUG=none
TEST=confirmed chrome built fine.

Review URL: http://codereview.chromium.org/3081019
------------------------------------------------------------------------
r55192 | thestig@chromium.org | 2010-08-06 08:24:28 +0200 (Fri, 06 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/base/keyboard_codes_win.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/update_manifest.h
   M /trunk/src/chrome/common/extensions/update_manifest_unittest.cc
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/renderer/pepper_scrollbar_widget.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

FBTF: Remove unneeded headers from base/ (part 3)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3037044
------------------------------------------------------------------------
r55191 | thestig@chromium.org | 2010-08-06 08:22:15 +0200 (Fri, 06 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/base/logging_win.cc
   M /trunk/src/base/simple_thread.cc
   M /trunk/src/base/sync_socket_posix.cc
   M /trunk/src/base/sync_socket_win.cc
   M /trunk/src/base/trace_event_win.cc
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/browser/aeropeek_manager.h
   M /trunk/src/chrome/browser/browser_child_process_host.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/file_watcher_inotify.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/js_modal_dialog.h
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/common/deprecated/event_sys-inl.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/test/automation/extension_proxy.h
   M /trunk/src/chrome_frame/urlmon_url_request.h
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/ipc/ipc_logging.h
   M /trunk/src/ipc/ipc_sync_message_filter.cc
   M /trunk/src/ipc/ipc_sync_message_filter.h
   M /trunk/src/media/base/mock_filter_host.h
   M /trunk/src/media/base/mock_reader.h
   M /trunk/src/media/base/pipeline_impl_unittest.cc
   M /trunk/src/media/filters/omx_video_decoder.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/remoting/jingle_glue/jingle_client.cc

FBTF: Remove unneeded headers from base/ (part 2)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3010052
------------------------------------------------------------------------
r55188 | zork@chromium.org | 2010-08-06 06:37:50 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Add both English and the alternate language to the preferred language list on first login.

BUG=chromium-os:5332
TEST=On initial login, have the UI set to non-english.  Go to the language options menu.  Check that both English and the interface language show up.

Review URL: http://codereview.chromium.org/3010053
------------------------------------------------------------------------
r55178 | dmazzoni@chromium.org | 2010-08-06 04:17:39 +0200 (Fri, 06 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_events.cc
   M /trunk/src/chrome/browser/accessibility_events.h

Expose the type of an AccessibilityControlInfo. (This will allow us
to use this same accessibility event code to make the Chrome OS login
screen speak, before accessibility extensions are loaded.)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3073026
------------------------------------------------------------------------
r55177 | sargrass@google.com | 2010-08-06 04:04:06 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   D /trunk/src/chrome/browser/resources/options/content_settings_page.css
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   M /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   A /trunk/src/chrome/browser/resources/options/subpages_tab_controls.css (from /trunk/src/chrome/browser/resources/options/content_settings_page.css:55166)
   M /trunk/src/chrome/browser/resources/options.html

Add tabs to passwords and exceptions subpage.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3086017
------------------------------------------------------------------------
r55176 | evan@chromium.org | 2010-08-06 03:46:59 +0200 (Fri, 06 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate_win.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/test/mini_installer_test/test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome_frame/test/net/process_singleton_subclass.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc
   M /trunk/src/chrome_frame/test/reliability/run_all_unittests.cc

Remove GetSwitchValue() from chrome/* where easy.

Review URL: http://codereview.chromium.org/3057033
------------------------------------------------------------------------
r55175 | derat@chromium.org | 2010-08-06 03:36:34 +0200 (Fri, 06 Aug 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc
   M /trunk/src/chrome/browser/views/reload_button.cc

Make reload accelerators more consistent across platforms.

On Windows and Linux (both Views and GTK+), this makes
Ctrl-R, F5, and regular clicks on the reload button do
regular reloads, while Ctrl-Shift-R, Shift-F5, Control-F5,
and holding Shift or Control while clicking the button all
bypass the cache.

It does the same for the reload button on Mac, but I'm not
modifying any Mac keyboard shortcuts in this change (it
looks like Command-Shift-R already bypasses the cache).
I've updated http://crbug.com/38356 to mention that when
the F5 shortcut is added to Mac, the cache-bypassing
modifiers should also be supported.

BUG=47383
TEST=none

Review URL: http://codereview.chromium.org/2876008
------------------------------------------------------------------------
r55172 | satorux@chromium.org | 2010-08-06 03:32:52 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc

Sort the language list by locale specific sorter.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3032057
------------------------------------------------------------------------
r55170 | zork@chromium.org | 2010-08-06 03:16:19 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Explicitly set the input method on IME connected, even if it's the hardware layout.

BUG=none
TEST=Add the Dutch input method.  Set the input method to US Querty.  Log out.  Log in.  Ensure the starting input method is US Querty.

Review URL: http://codereview.chromium.org/3080027
------------------------------------------------------------------------
r55168 | tfarina@chromium.org | 2010-08-06 03:03:37 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/environment.cc
   M /trunk/src/base/environment.h
   M /trunk/src/base/environment_unittest.cc
   M /trunk/src/base/nss_util.cc
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

base: rename Environment::SetEnv to Environment::SetVar.

This is the part 3 of this series. One more remaining. Splitting this
into small parts, so it is more easy to review and reduce the size of the CL.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2836088
------------------------------------------------------------------------
r55165 | rsesek@chromium.org | 2010-08-06 02:46:50 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm

[Mac] Prevent a crash with the DownloadStartedAnimation.

The initializer for the class can sometimes return nil.  If so, do not try to
access an ivar directly.

BUG=51307
TEST=none

Review URL: http://codereview.chromium.org/3060047
------------------------------------------------------------------------
r55164 | mirandac@chromium.org | 2010-08-06 02:46:46 +0200 (Fri, 06 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc

Allow search engine dialog to have only two choices (Vietnam and Iran have only two listed in template_url_prepopulate_data).
Fix invalid search URL in in.gr search engine.

BUG= 51295
TEST= Vietnam and Iran search engine dialogs work fine, searching with in.gr (from Greek default search engine choices) works.

Review URL: http://codereview.chromium.org/3007032
------------------------------------------------------------------------
r55163 | ctguil@chromium.org | 2010-08-06 02:44:59 +0200 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.h
   M /trunk/src/views/controls/menu/submenu_view.cc

Enable better NVDA support for custom menus.

- Send the popupmenu events on the MenuScrollViewContainer since it is the View with the ROLE_MENUPOPUP role.
- Return AccessibilityTypes::STATE_FOCUSED for MenuScrollViewContainer since it's not focused by MenuHostWin::ShowMenuHost. NVDA won't process children menu item's focus events unless a parent claims to have focus.

TEST=The wrench menu and it's menu items are read aloud when using NVDA.
BUG=49360

Review URL: http://codereview.chromium.org/3015055
------------------------------------------------------------------------
r55159 | estade@chromium.org | 2010-08-06 02:13:10 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

[GTK] undo more toolbar destruction - unbreak GTK+ theme mode home button

BUG=51325
TEST=showing home button in gtk+ should work

Review URL: http://codereview.chromium.org/3083018
------------------------------------------------------------------------
r55155 | suzhe@chromium.org | 2010-08-06 01:14:22 +0200 (Fri, 06 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc

[ChromeOS] Fix accelerator keys in login wizard and html dialog.

BUG=none
TEST=Try ctrl+alt-{A,E,U,I,L,N} in different screens of login wizard. And try Escape to close a html dialog (eg. sync setup dialog).

Review URL: http://codereview.chromium.org/3067035
------------------------------------------------------------------------
r55149 | jianli@chromium.org | 2010-08-06 00:49:17 +0200 (Fri, 06 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/speech/speech_input_browsertest.cc

Disable SpeechInputBrowserTest.TestBasicRecognition.

BUG=51337
TEST=none
TBR=satish

Review URL: http://codereview.chromium.org/3069032
------------------------------------------------------------------------
r55146 | mlloyd@chromium.org | 2010-08-06 00:46:33 +0200 (Fri, 06 Aug 2010) | 16 lines
Changed paths:
   M /trunk/src/base/field_trial.cc
   M /trunk/src/base/field_trial.h
   M /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc

Have MakeName prepend the underscore to the field trial group name,
rather than having the field trial group name itself include the
underscore.

This will change the histogram names for only one field trial,
the CacheSizeGroup field trial, and I have got in touch with Mike
and Ricardo (who wrote that code); they confirmed that they don't
mind the name change.

Also updates the field trial unit tests to reflect the change,
and to make the use of the expected/actual arguments to the
unit test macros consistent

TEST=Unit tests pass.
BUG=None.
Review URL: http://codereview.chromium.org/3066036
------------------------------------------------------------------------
r55140 | csilv@chromium.org | 2010-08-06 00:01:24 +0200 (Fri, 06 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.html

dom-ui options: tweak advanced layout so Browse button appears on the same line as the download path.

BUG=none
TEST=Verify Browse button placement in dom-ui options advanced.
Review URL: http://codereview.chromium.org/3058054
------------------------------------------------------------------------
r55139 | lzheng@chromium.org | 2010-08-05 23:59:26 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_browsertest.cc

Revert 55138 - Full end to end test using safebrowsing test server suite.

Review URL: http://codereview.chromium.org/3032008

TBR=lzheng@google.com
Review URL: http://codereview.chromium.org/3027044
------------------------------------------------------------------------
r55138 | lzheng@google.com | 2010-08-05 23:56:22 +0200 (Thu, 05 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_browsertest.cc

Full end to end test using safebrowsing test server suite.

Review URL: http://codereview.chromium.org/3032008
------------------------------------------------------------------------
r55136 | viettrungluu@chromium.org | 2010-08-05 23:53:13 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autofill/autofill_address_sheet_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar.h
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.h
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_manager.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/user_script_master.h

Remove obviously unneeded forward declarations in chrome/browser/[abef]*/*.h.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3027041
------------------------------------------------------------------------
r55135 | viettrungluu@chromium.org | 2010-08-05 23:47:40 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser_accessibility_win.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/mock_browsing_data_database_helper.h
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/plugin_updater.h
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/wrench_menu_model.h

Clean up inclusion of <map>, <set>, <vector> in chrome/browser/*.h.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/2878081
------------------------------------------------------------------------
r55130 | finnur@chromium.org | 2010-08-05 23:33:31 +0200 (Thu, 05 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card.cc

Adding const ref instead of passing by value.

BUG=None
TEST=None
CID=12224

Review URL: http://codereview.chromium.org/3005058
------------------------------------------------------------------------
r55129 | finnur@chromium.org | 2010-08-05 23:33:20 +0200 (Thu, 05 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc

Uninitialize member var in SearchEngineChoice.

BUG=None
TEST=None
CID=11446

Review URL: http://codereview.chromium.org/3029060
------------------------------------------------------------------------
r55128 | finnur@chromium.org | 2010-08-05 23:33:12 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.h

Remove unused member variable from RenderViewContextMenuViews.

BUG=None
TEST=None
CID=11226
Review URL: http://codereview.chromium.org/3034057
------------------------------------------------------------------------
r55127 | cmasone@google.com | 2010-08-05 23:33:02 +0200 (Thu, 05 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

[ChromeOS] When doing a stub-login for chromeos, avoid the already-logged-in-user path

Before r54950, we used the kLoginUser switch to indicate that chrome
had crashed, and we were relaunching it for the indicated user.
http://src.chromium.org/viewvc/chrome?view=rev&revision=54950 introduced a
new semantic: if passed along with kLoginPassword, this flag now indicated
that a mocked-out login should be attempted with the given credentials.

Doing this as well as starting up like we were relaunching the browser for
the indicated user caused some DCHECKs to fire.

BUG=None
TEST=do a stub login, watch it succeed

Review URL: http://codereview.chromium.org/3026053
------------------------------------------------------------------------
r55103 | cdn@chromium.org | 2010-08-05 20:28:48 +0200 (Thu, 05 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   A /trunk/src/chrome/test/data/extensions/origin_privileges
   A /trunk/src/chrome/test/data/extensions/origin_privileges/extension
   A /trunk/src/chrome/test/data/extensions/origin_privileges/extension/manifest.json
   A /trunk/src/chrome/test/data/extensions/origin_privileges/extension/test.png
   A /trunk/src/chrome/test/data/extensions/origin_privileges/index.html

Refactored extension privilege enumeration and implemented URLPattern comparisons. 
This will allow checks on per origin extension resource access. Added origin
check when loading extension resources. 

BUG=45876
TEST=ExtensionTest.IsPrivilegeIncrease 
TEST=ExtensionTest.EffectiveHostPermissions
TEST=ExtensionBrowserTest.OriginPrivileges

Review URL: http://codereview.chromium.org/2808051
------------------------------------------------------------------------
r55100 | phajdan.jr@chromium.org | 2010-08-05 20:22:14 +0200 (Thu, 05 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util_unittest.cc

Fix DownloadUtilTest on Mac. Not sure what causes the difference.

TBR=ahendrickson

TEST=unit_tests
BUG=48913

Review URL: http://codereview.chromium.org/3058052
------------------------------------------------------------------------
r55097 | rafaelw@chromium.org | 2010-08-05 20:05:26 +0200 (Thu, 05 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Add debuggin CHECK to help track down ExtensionHost crasher

Hopefully this well tells us whether it's the ExtensionHost that has been deleted.

BUG=49114
TEST=none

Review URL: http://codereview.chromium.org/2883057
------------------------------------------------------------------------
r55094 | phajdan.jr@chromium.org | 2010-08-05 19:49:08 +0200 (Thu, 05 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

Fix unit_tests on Mac by renaming the MAc test name for DownloadUtilMacTest.

TBR=thakis

TEST=unit_tests
BUG=48913, 21479

Review URL: http://codereview.chromium.org/3085015
------------------------------------------------------------------------
r55093 | jhawkins@chromium.org | 2010-08-05 19:48:34 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/autofill_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/autofill_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/autofill_options.html
   A /trunk/src/chrome/browser/resources/options/autofill_options.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI: Base framework for the AutoFill page.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3044047
------------------------------------------------------------------------
r55090 | dhollowa@chromium.org | 2010-08-05 19:21:34 +0200 (Thu, 05 Aug 2010) | 91 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   D /trunk/src/net/socket/client_socket.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool_base.h

Revert 55071 - Reland 54771 (and 54795) To enable TCP Preconnection by default

Leaks reported with this CL.

http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/6130/steps/heapcheck%20test:%20net/logs/stdio

Eg.

Leak of 24 bytes in 1 objects allocated from:
	 @ 84aece net::SSLClientSocketNSS::BufferRecv
	 @ 84b161 net::SSLClientSocketNSS::DoTransportIO
	 @ 84ca1f net::SSLClientSocketNSS::DoHandshakeLoop
	 @ 84ca6b net::SSLClientSocketNSS::OnHandshakeIOComplete
	 @ 84cadc net::SSLClientSocketNSS::OnRecvComplete
	 @ 84cbb0 net::SSLClientSocketNSS::BufferRecvComplete
	 @ 84ea4b void DispatchToMethod
	 @ 84ea7b CallbackImpl::RunWithParams
	 @ 4b3a10 CallbackRunner::Run
	 @ 853e7e net::TCPClientSocketLibevent::DoReadCallback
	 @ 85426f net::TCPClientSocketLibevent::DidCompleteRead
	 @ 856a5c net::TCPClientSocketLibevent::ReadWatcher::OnFileCanReadWithoutBlocking
	 @ 93d8fd base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking
	 @ 93d966 base::MessagePumpLibevent::OnLibeventNotification
	 @ 9da639 event_process_active
	 @ 9da923 event_base_loop
	 @ 93dfd0 base::MessagePumpLibevent::Run
	 @ 8f2873 MessageLoop::RunInternal
	 @ 8f2893 MessageLoop::RunHandler
	 @ 8f2938 MessageLoop::Run
	 @ 44b7f9 TestCompletionCallback::WaitForResult
	 @ 6a1ee6 SSLClientSocketTest_ConnectMismatched_Test::TestBody
	 @ 961831 testing::Test::Run
	 @ 965026 testing::internal::TestInfoImpl::Run
	 @ 96515c testing::TestCase::Run
	 @ 965bbe testing::internal::UnitTestImpl::RunAllTests
	 @ 965d35 testing::UnitTest::Run
	 @ 4a4bf7 TestSuite::Run
	 @ 4a3b6d main
	 @ 2adff5bb11c4 __libc_start_main

Suppression:
{
   <insert_a_suppression_name_here>
   Heapcheck:Leak
   fun:net::SSLClientSocketNSS::BufferRecv
   fun:net::SSLClientSocketNSS::DoTransportIO
   fun:net::SSLClientSocketNSS::DoHandshakeLoop
   fun:net::SSLClientSocketNSS::OnHandshakeIOComplete
   fun:net::SSLClientSocketNSS::OnRecvComplete
   fun:net::SSLClientSocketNSS::BufferRecvComplete
   fun:void DispatchToMethod
   fun:CallbackImpl::RunWithParams
   fun:CallbackRunner::Run
   fun:net::TCPClientSocketLibevent::DoReadCallback
   fun:net::TCPClientSocketLibevent::DidCompleteRead
   fun:net::TCPClientSocketLibevent::ReadWatcher::OnFileCanReadWithoutBlocking
   fun:base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking
   fun:base::MessagePumpLibevent::OnLibeventNotification
   fun:event_process_active
   fun:event_base_loop
   fun:base::MessagePumpLibevent::Run
   fun:MessageLoop::RunInternal
   fun:MessageLoop::RunHandler
   fun:MessageLoop::Run
   fun:TestCompletionCallback::WaitForResult
   fun:SSLClientSocketTest_ConnectMismatched_Test::TestBody
   fun:testing::Test::Run
   fun:testing::internal::TestInfoImpl::Run
   fun:testing::TestCase::Run
   fun:testing::internal::UnitTestImpl::RunAllTests
   fun:testing::UnitTest::Run
   fun:TestSuite::Run
   fun:main
   fun:__libc_start_main
}




I added defensive code in ClientSocketHandle::ReleaseSocket(),
which should preclude the crash that was reported on the
stability bot.

I added a second call to ReleaseSocket() from
~ClientSocketHandle to ensure that we updated the
related ClientSocket when we are torn down.

r=mbelshe
Review URL: http://codereview.chromium.org/3071022

TBR=jar@chromium.org
------------------------------------------------------------------------
r55088 | phajdan.jr@chromium.org | 2010-08-05 19:14:00 +0200 (Thu, 05 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   A /trunk/src/chrome/browser/download/download_util_unittest.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/chrome_tests.gypi

Clean up download code:

- move filename generation parts and related code out of DownloadManager
  download_util is not the best place for it, but it's better than
  DownloadManager which we're trying to minimize

- clean up posting tasks to different threads. There's no need to create
  separate methods for that, it was cluttering the file needlessly

- other minor cleanups, like using static_cast instead of C-style cast

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3043048
------------------------------------------------------------------------
r55085 | dhollowa@chromium.org | 2010-08-05 19:05:14 +0200 (Thu, 05 Aug 2010) | 55 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Revert 55072 - Revert 55063 - WebKit roll: 64705:64742.
TBR=jianli

Reverting this roll didn't seem to affect the test failures.  So am reverting the revert.

Mac 10.6 Bot were failing after this change in unit_tests and interactive_ui_tests.  Failures seen:

Failing tests:
BrowserFocusTest.ClickingMovesFocus
BrowserFocusTest.TabsRememberFocus
BrowserFocusTest.FAILS_TabsRememberFocusFindInPage
BrowserFocusTest.BackgroundBrowserDontStealFocus
BrowserFocusTest.FAILS_FocusTraversal
BrowserFocusTest.FAILS_FocusTraversalOnInterstitial
BrowserFocusTest.FindFocusTest
BrowserKeyEventsTest.CommandKeyEvents
BrowserKeyEventsTest.FLAKY_ReservedAccelerators
MouseLeaveTest.FAILS_TestOnMouseOut

Note: Google Test filter = BrowserFocusTest.ClickingMovesFocus
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserFocusTest
[ RUN      ] BrowserFocusTest.ClickingMovesFocus
...
/b/slave/chromium-dbg-mac-builder/build/src/chrome/../chrome/browser/browser_focus_uitest.cc:182: Failure
Value of: IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)
  Actual: false
Expected: true


and

[----------] 2 tests from BrowserWindowFullScreenControllerTest
[ RUN      ] BrowserWindowFullScreenControllerTest.TestFullscreen
[       OK ] BrowserWindowFullScreenControllerTest.TestFullscreen (375 ms)
[ RUN      ] BrowserWindowFullScreenControllerTest.TestActivate
/b/slave/chromium-dbg-mac-builder/build/src/chrome/browser/cocoa/browser_window_controller_unittest.mm:600: Failure
Value of: [controller_ createFullscreenWindow]
  Actual: 0xa9a4890
Expected: frontmostWindow
Which is: 0x1e256e60
[  FAILED  ] BrowserWindowFullScreenControllerTest.TestActivate (63 ms)
[----------] 2 tests from BrowserWindowFullScreenControllerTest (438 ms total)




Review URL: http://codereview.chromium.org/3072024

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3051035

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/3067034
------------------------------------------------------------------------
r55083 | skrul@chromium.org | 2010-08-05 18:58:48 +0200 (Thu, 05 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Don't sync prefs::kAutoFillAuxiliaryProfilesEnabled on non-mac

BUG=51209

Review URL: http://codereview.chromium.org/3040037
------------------------------------------------------------------------
r55082 | csilv@chromium.org | 2010-08-05 18:57:51 +0200 (Thu, 05 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js

Fix the call to setClearingState which was causing a javascript error.

BUG=none
TEST=Verify that dom-ui options window shows no javascript errors in the dev-tools panel.
Review URL: http://codereview.chromium.org/3061053
------------------------------------------------------------------------
r55072 | dhollowa@chromium.org | 2010-08-05 18:36:06 +0200 (Thu, 05 Aug 2010) | 50 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Revert 55063 - WebKit roll: 64705:64742.
TBR=jianli

Mac 10.6 Bot were failing after this change in unit_tests and interactive_ui_tests.  Failures seen:

Failing tests:
BrowserFocusTest.ClickingMovesFocus
BrowserFocusTest.TabsRememberFocus
BrowserFocusTest.FAILS_TabsRememberFocusFindInPage
BrowserFocusTest.BackgroundBrowserDontStealFocus
BrowserFocusTest.FAILS_FocusTraversal
BrowserFocusTest.FAILS_FocusTraversalOnInterstitial
BrowserFocusTest.FindFocusTest
BrowserKeyEventsTest.CommandKeyEvents
BrowserKeyEventsTest.FLAKY_ReservedAccelerators
MouseLeaveTest.FAILS_TestOnMouseOut

Note: Google Test filter = BrowserFocusTest.ClickingMovesFocus
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserFocusTest
[ RUN      ] BrowserFocusTest.ClickingMovesFocus
...
/b/slave/chromium-dbg-mac-builder/build/src/chrome/../chrome/browser/browser_focus_uitest.cc:182: Failure
Value of: IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)
  Actual: false
Expected: true


and

[----------] 2 tests from BrowserWindowFullScreenControllerTest
[ RUN      ] BrowserWindowFullScreenControllerTest.TestFullscreen
[       OK ] BrowserWindowFullScreenControllerTest.TestFullscreen (375 ms)
[ RUN      ] BrowserWindowFullScreenControllerTest.TestActivate
/b/slave/chromium-dbg-mac-builder/build/src/chrome/browser/cocoa/browser_window_controller_unittest.mm:600: Failure
Value of: [controller_ createFullscreenWindow]
  Actual: 0xa9a4890
Expected: frontmostWindow
Which is: 0x1e256e60
[  FAILED  ] BrowserWindowFullScreenControllerTest.TestActivate (63 ms)
[----------] 2 tests from BrowserWindowFullScreenControllerTest (438 ms total)




Review URL: http://codereview.chromium.org/3072024

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3051035
------------------------------------------------------------------------
r55071 | jar@chromium.org | 2010-08-05 18:23:35 +0200 (Thu, 05 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   A /trunk/src/net/socket/client_socket.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool_base.h

Reland 54771 (and 54795) To enable TCP Preconnection by default

I added defensive code in ClientSocketHandle::ReleaseSocket(),
which should preclude the crash that was reported on the
stability bot.

I added a second call to ReleaseSocket() from
~ClientSocketHandle to ensure that we updated the
related ClientSocket when we are torn down.

r=mbelshe
Review URL: http://codereview.chromium.org/3071022
------------------------------------------------------------------------
r55070 | alyssad@chromium.org | 2010-08-05 17:52:59 +0200 (Thu, 05 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/test/data/translate
   A /trunk/src/chrome/test/data/translate/ar
   A /trunk/src/chrome/test/data/translate/ar/google.html
   A /trunk/src/chrome/test/data/translate/ar/google_images.html
   A /trunk/src/chrome/test/data/translate/ar/google_maps.html
   A /trunk/src/chrome/test/data/translate/ar/google_news.html
   A /trunk/src/chrome/test/data/translate/de
   A /trunk/src/chrome/test/data/translate/de/google.html
   A /trunk/src/chrome/test/data/translate/de/google_images.html
   A /trunk/src/chrome/test/data/translate/de/google_maps.html
   A /trunk/src/chrome/test/data/translate/de/google_news.html
   A /trunk/src/chrome/test/data/translate/el
   A /trunk/src/chrome/test/data/translate/el/google.html
   A /trunk/src/chrome/test/data/translate/el/google_images.html
   A /trunk/src/chrome/test/data/translate/el/google_maps.html
   A /trunk/src/chrome/test/data/translate/el/google_news.html
   A /trunk/src/chrome/test/data/translate/es
   A /trunk/src/chrome/test/data/translate/es/google.html
   A /trunk/src/chrome/test/data/translate/es/google_images.html
   A /trunk/src/chrome/test/data/translate/es/google_maps.html
   A /trunk/src/chrome/test/data/translate/es/google_news.html
   A /trunk/src/chrome/test/data/translate/fi
   A /trunk/src/chrome/test/data/translate/fi/google.html
   A /trunk/src/chrome/test/data/translate/fi/google_images.html
   A /trunk/src/chrome/test/data/translate/fi/google_maps.html
   A /trunk/src/chrome/test/data/translate/fr
   A /trunk/src/chrome/test/data/translate/fr/google.html
   A /trunk/src/chrome/test/data/translate/fr/google_images.html
   A /trunk/src/chrome/test/data/translate/fr/google_maps.html
   A /trunk/src/chrome/test/data/translate/fr/google_news.html
   A /trunk/src/chrome/test/data/translate/he
   A /trunk/src/chrome/test/data/translate/he/google.html
   A /trunk/src/chrome/test/data/translate/he/google_images.html
   A /trunk/src/chrome/test/data/translate/he/google_maps.html
   A /trunk/src/chrome/test/data/translate/hi
   A /trunk/src/chrome/test/data/translate/hi/google.html
   A /trunk/src/chrome/test/data/translate/hi/google_images.html
   A /trunk/src/chrome/test/data/translate/hi/google_maps.html
   A /trunk/src/chrome/test/data/translate/hi/google_news.html
   A /trunk/src/chrome/test/data/translate/it
   A /trunk/src/chrome/test/data/translate/it/google.html
   A /trunk/src/chrome/test/data/translate/it/google_maps.html
   A /trunk/src/chrome/test/data/translate/it/google_news.html
   A /trunk/src/chrome/test/data/translate/ja
   A /trunk/src/chrome/test/data/translate/ja/google.html
   A /trunk/src/chrome/test/data/translate/ja/google_images.html
   A /trunk/src/chrome/test/data/translate/ja/google_maps.html
   A /trunk/src/chrome/test/data/translate/ja/google_news.html
   A /trunk/src/chrome/test/data/translate/ko
   A /trunk/src/chrome/test/data/translate/ko/google.html
   A /trunk/src/chrome/test/data/translate/ko/google_images.html
   A /trunk/src/chrome/test/data/translate/ko/google_maps.html
   A /trunk/src/chrome/test/data/translate/ko/google_news.html
   A /trunk/src/chrome/test/data/translate/nl
   A /trunk/src/chrome/test/data/translate/nl/google.html
   A /trunk/src/chrome/test/data/translate/nl/google_images.html
   A /trunk/src/chrome/test/data/translate/nl/google_maps.html
   A /trunk/src/chrome/test/data/translate/nl/google_news.html
   A /trunk/src/chrome/test/data/translate/notranslate_meta_tag.html
   A /trunk/src/chrome/test/data/translate/pl
   A /trunk/src/chrome/test/data/translate/pl/google.html
   A /trunk/src/chrome/test/data/translate/pl/google_images.html
   A /trunk/src/chrome/test/data/translate/pl/google_maps.html
   A /trunk/src/chrome/test/data/translate/pl/google_news.html
   A /trunk/src/chrome/test/data/translate/pt
   A /trunk/src/chrome/test/data/translate/pt/google.html
   A /trunk/src/chrome/test/data/translate/pt/google_images.html
   A /trunk/src/chrome/test/data/translate/pt/google_maps.html
   A /trunk/src/chrome/test/data/translate/ru
   A /trunk/src/chrome/test/data/translate/ru/google.html
   A /trunk/src/chrome/test/data/translate/ru/google_images.html
   A /trunk/src/chrome/test/data/translate/ru/google_maps.html
   A /trunk/src/chrome/test/data/translate/ru/google_news.html
   A /trunk/src/chrome/test/data/translate/sv
   A /trunk/src/chrome/test/data/translate/sv/google.html
   A /trunk/src/chrome/test/data/translate/sv/google_images.html
   A /trunk/src/chrome/test/data/translate/sv/google_maps.html
   A /trunk/src/chrome/test/data/translate/sv/google_news.html
   A /trunk/src/chrome/test/data/translate/th
   A /trunk/src/chrome/test/data/translate/th/google.html
   A /trunk/src/chrome/test/data/translate/th/google_images.html
   A /trunk/src/chrome/test/data/translate/th/google_maps.html
   A /trunk/src/chrome/test/data/translate/th/google_news.html
   A /trunk/src/chrome/test/data/translate/tr
   A /trunk/src/chrome/test/data/translate/tr/google.html
   A /trunk/src/chrome/test/data/translate/tr/google_images.html
   A /trunk/src/chrome/test/data/translate/tr/google_maps.html
   A /trunk/src/chrome/test/data/translate/tr/google_news.html
   A /trunk/src/chrome/test/data/translate/zh-CN
   A /trunk/src/chrome/test/data/translate/zh-CN/google.html
   A /trunk/src/chrome/test/data/translate/zh-CN/google_images.html
   A /trunk/src/chrome/test/data/translate/zh-CN/google_maps.html
   A /trunk/src/chrome/test/data/translate/zh-CN/google_news.html
   A /trunk/src/chrome/test/data/translate/zh-TW
   A /trunk/src/chrome/test/data/translate/zh-TW/google.html
   A /trunk/src/chrome/test/data/translate/zh-TW/google_images.html
   A /trunk/src/chrome/test/data/translate/zh-TW/google_maps.html
   A /trunk/src/chrome/test/data/translate/zh-TW/google_news.html
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   M /trunk/src/chrome/test/functional/translate.py

New translate tests for pyauto.py

This also includes a change to WaitUntilTranslateComplete.

Review URL: http://codereview.chromium.org/3030042
------------------------------------------------------------------------
r55068 | nkostylev@google.com | 2010-08-05 17:40:56 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Disable EULA/update/register screens for non-official builds.

BUG= http://crosbug.com/4646
TEST=Manual. These screens should not be shown on dev builds. Testing accelerators still work.

Review URL: http://codereview.chromium.org/3023039
------------------------------------------------------------------------
r55067 | sky@chromium.org | 2010-08-05 17:33:57 +0200 (Thu, 05 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fixes bug in tab dragging when rtl where the dragged tab was
incorrectly positioned.

BUG=51219
TEST=see bug

Review URL: http://codereview.chromium.org/3091008
------------------------------------------------------------------------
r55063 | pfeldman@chromium.org | 2010-08-05 16:04:19 +0200 (Thu, 05 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

WebKit roll: 64705:64742.
TBR=jianli

Review URL: http://codereview.chromium.org/3072024
------------------------------------------------------------------------
r55062 | dpolukhin@chromium.org | 2010-08-05 15:50:43 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/chromeos/login/apply_services_customization.cc (from /trunk/src/chrome/browser/chromeos/login/string_fetcher.cc:54872)
   A /trunk/src/chrome/browser/chromeos/login/apply_services_customization.h (from /trunk/src/chrome/browser/chromeos/login/string_fetcher.h:54872)
   D /trunk/src/chrome/browser/chromeos/login/string_fetcher.cc
   D /trunk/src/chrome/browser/chromeos/login/string_fetcher.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

Fetch OEM services customization manifest from URL async.

BUG=chromium-os:5123
TEST=none

Review URL: http://codereview.chromium.org/3026048
------------------------------------------------------------------------
r55061 | glotov@chromium.org | 2010-08-05 15:38:48 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc

EULA screen enabling/disabling crash/metrics reporting renovated.

BUG=chromium-os:2884
TEST=none

Review URL: http://codereview.chromium.org/3069028
------------------------------------------------------------------------
r55056 | avayvod@chromium.org | 2010-08-05 13:03:19 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_screen.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

change behaviour of left arrow on NewUserView: allows to navigate using arrows.


BUG=http://crosbug.com/4337
TEST=Manual
Review URL: http://codereview.chromium.org/2808102
------------------------------------------------------------------------
r55047 | pfeldman@chromium.org | 2010-08-05 11:40:51 +0200 (Thu, 05 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_agent.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_agent.h
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_client.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_client.h

DevTools: get rid of delayed command dispatching on front-end side.

Review URL: http://codereview.chromium.org/3020063
------------------------------------------------------------------------
r55046 | satorux@chromium.org | 2010-08-05 11:37:07 +0200 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css

Tweak appearances of "Languages and Input" options.

- Set the fixed width per suggestion from Cole
- Reduce some padding/margin so the overlay can fit in the netbook screen.

TEST=manually on the netbook
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3058047
------------------------------------------------------------------------
r55044 | satorux@chromium.org | 2010-08-05 11:07:44 +0200 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_language_add_language_overlay.js

Show native language names in the add language overlay.

For instance, "Finnish - suomi". This is what we do in
the C++ version options.

TEST=manually; out/Release/unit_tests --gtest_filter='*InputMethodUtil*'
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/2808106
------------------------------------------------------------------------
r55042 | satorux@chromium.org | 2010-08-05 10:48:12 +0200 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Fix a bug that the language list is not drawn properly.

Get back handleVisibleChange_() which I deleted accidentally in
http://codereview.chromium.org/3041025.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3089007
------------------------------------------------------------------------
r55041 | bauerb@chromium.org | 2010-08-05 10:38:09 +0200 (Thu, 05 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/blocked_plugin_manager.cc
   A /trunk/src/chrome/browser/blocked_plugin_manager.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Block non-sandboxed plugins.

Run Chrome with --block-nonsandboxed-plugins to enable.

BUG=47730
TEST=See bug description for manual test.

Review URL: http://codereview.chromium.org/3040034
------------------------------------------------------------------------
r55039 | satorux@chromium.org | 2010-08-05 10:21:23 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

One line fix for a bug that broke the input method list.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3054046
------------------------------------------------------------------------
r55037 | viettrungluu@chromium.org | 2010-08-05 09:26:43 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.h
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/configuration_policy_provider.h
   M /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/file_watcher.h
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/js_modal_dialog.h
   M /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/memory_purger.h
   M /trunk/src/chrome/browser/remove_rows_table_model.h
   M /trunk/src/chrome/browser/repost_form_warning_controller.h
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/test/testing_browser_process.h

Delete obviously unneeded forward declarations in chrome/browser/*.h.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3080031
------------------------------------------------------------------------
r55036 | thestig@chromium.org | 2010-08-05 08:12:36 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc

Mark GViewRequestInterceptorTest.InterceptPdf as failing.

BUG=51242
TEST=none
TBR=gene
Review URL: http://codereview.chromium.org/3082020
------------------------------------------------------------------------
r55034 | thestig@chromium.org | 2010-08-05 07:12:35 +0200 (Thu, 05 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/app/resource_bundle_dummy.cc
   M /trunk/src/app/win_util.cc
   M /trunk/src/base/crypto/symmetric_key_mac.cc
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/shared_memory_win.cc
   M /trunk/src/base/trace_event_win.cc
   M /trunk/src/base/win_util_unittest.cc
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.cc
   M /trunk/src/chrome/browser/browser_accessibility_win.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/google_update_settings_posix.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/common/chrome_paths_win.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/chrome_frame_distribution.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome_frame/bho.cc
   M /trunk/src/chrome_frame/bho.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/protocol_sink_wrap.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.h
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/chrome_frame/test/ie_event_sink.cc
   M /trunk/src/chrome_frame/test/navigation_test.cc
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc
   M /trunk/src/chrome_frame/test/test_server.cc
   M /trunk/src/chrome_frame/test/ui_test.cc
   M /trunk/src/chrome_frame/urlmon_moniker.h
   M /trunk/src/chrome_frame/urlmon_url_request.h
   M /trunk/src/media/tools/mfdecoder/main.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/sandbox/src/dep.cc
   M /trunk/src/sandbox/src/process_thread_dispatcher.cc
   M /trunk/src/sandbox/src/registry_policy.cc
   M /trunk/src/views/controls/listbox/native_listbox_win.cc

FBTF: Remove unneeded headers from base/ (part 1)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3071012
------------------------------------------------------------------------
r55031 | satorux@chromium.org | 2010-08-05 06:58:34 +0200 (Thu, 05 Aug 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html

Make the width of overlay pages flexible.

Before the change, overlays take up the whole width
of the page except padding, thus overlays are very wide.

With this change, overlays only take up the width that is
necessary to show the contents inside.

The individual overlays can control the width using CSS
as needed. If you want the original behavior (taking up
the whole width), you could add "-webkit-box-flex: 1" to
the overlay's CSS. If you want to set a fixed width, you
could add something like "width: 600px" in the overlay's
CSS.

Note that the ability to set the fixed with is necessary to
follow a suggestion from Cole regarding the size of the
overlay for adding languages. See before.png and after.png in
crosbug.com/4573 for details.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3056042
------------------------------------------------------------------------
r55030 | viettrungluu@chromium.org | 2010-08-05 06:51:16 +0200 (Thu, 05 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h

Delete AvailableProfile (et al.) in browser/profile_manager.*.

It isn't used.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3075022
------------------------------------------------------------------------
r55029 | viettrungluu@chromium.org | 2010-08-05 06:47:44 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h

Remove a couple of unneeded forwarded decls.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3012046
------------------------------------------------------------------------
r55027 | satorux@chromium.org | 2010-08-05 06:12:01 +0200 (Thu, 05 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js

Fix behaviors of Add and Remove buttons.

When a languge is added, select the newly added language.
When a language is removed, keep the same position if possible.

Along the way, remove unnecesary code from removeSelectedLanguage().

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/2878079
------------------------------------------------------------------------
r55026 | satorux@chromium.org | 2010-08-05 05:39:15 +0200 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js
   M /trunk/src/chrome/browser/resources/options/options_page.css

Implement "Display Chrome OS in this language" button.

Hopefully, the "Languages and Input" language dialog will be mostly
functional with this change, although we need to polish it more.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3080026
------------------------------------------------------------------------
r55025 | viettrungluu@chromium.org | 2010-08-05 05:36:07 +0200 (Thu, 05 Aug 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/page_state.cc
   D /trunk/src/chrome/browser/page_state.h
   M /trunk/src/chrome/chrome_browser.gypi

Delete chrome/browser/page_state.*.

There are exactly zero references to them.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3092007
------------------------------------------------------------------------
r55016 | johnnyg@chromium.org | 2010-08-05 04:04:13 +0200 (Thu, 05 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Reset the notification ui manager even earlier, before the IO thread goes away.

BUG=50553
TEST=see bug
Review URL: http://codereview.chromium.org/2819092
------------------------------------------------------------------------
r55014 | zork@chromium.org | 2010-08-05 03:22:39 +0200 (Thu, 05 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc

Shutdown ibus when logging in.

BUG=chromium-os:3964
TEST=Get to the login screen.
Switch IME to dvorak.
Go to a virtual console.
Run 'ps aux | grep ibus'
Check the pid of ibus-daemon
Log in.
Go to a virtual console
Run 'ps aux | grep ibus'
Check the pid of ibus-daemon
Ensure that it is different from before.

Review URL: http://codereview.chromium.org/2836085
------------------------------------------------------------------------
r55012 | viettrungluu@chromium.org | 2010-08-05 02:55:08 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc

Convert a bunch of wstring/wchar_t*'s, mostly in browser_about_handler.cc.

BUG=23581
TEST=builds

Review URL: http://codereview.chromium.org/3030047
------------------------------------------------------------------------
r55011 | jrg@google.com | 2010-08-05 02:51:01 +0200 (Thu, 05 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm

Implement AutomationProvider::WindowGetViewBounds() for
VIEW_ID_TAB_CONTAINER only to help WebDriver doodz.

BUG=none
TESTS=WebDriver doodz say things work

Review URL: http://codereview.chromium.org/2843054
------------------------------------------------------------------------
r55010 | tim@chromium.org | 2010-08-05 02:47:21 +0200 (Thu, 05 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   D /trunk/src/chrome/browser/sync/engine/all_status_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/chrome_tests.gypi

Unplumb AllStatus from SyncerThread.

The AllStatus is now strictly used for status reporting in UI.
Motivation is that the ST can get what it needs from other sources it already depends on, and less dependencies is a good thing (easier to get to MLs, and but also AllStatus is pretty complicated and makes it hard to follow what's going on when looking at the SyncerThread code). And GetRecommendedDelay just didn't belong in there in the first place IMO.

AllStatus is complicated as it tries to keep an instantaneously up-to-date status, which is a) error prone and buggy and b) not needed by the syncer thread, which only needs to check things after a session has completed.  The one subtle fact is on exit, calling Syncer::RequestEarlyExit means we may not hit SyncerEndCommand so previous_session_snapshot() will be out of date.  In this case though we don't care, since we don't need SyncerThread::CalculatePollingWaitTime to do anything.

BUG=26339
TEST=SyncerThreadTest

Review URL: http://codereview.chromium.org/3078022
------------------------------------------------------------------------
r55007 | rsesek@chromium.org | 2010-08-05 02:09:03 +0200 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/wrench_menu_button_cell.h
   A /trunk/src/chrome/browser/cocoa/wrench_menu_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/wrench_menu_button_cell_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Tweaks to the Wrench menu buttons.

This changes the two-tone background to an even gradient and changes the push
state of the buttons to use the blue selected menu item color.

BUG=none
TEST=visual

Review URL: http://codereview.chromium.org/3072021
------------------------------------------------------------------------
r55006 | hclam@chromium.org | 2010-08-05 02:07:32 +0200 (Thu, 05 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/service/service_main.cc

Rename --enable-chromoting to --enable-remoting

Renaming the flag so we don't expose the internal name.

Review URL: http://codereview.chromium.org/3037043
------------------------------------------------------------------------
r55000 | alyssad@chromium.org | 2010-08-05 01:50:15 +0200 (Thu, 05 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New translate pyauto hook: select translate target language

This hook allows tests to select a different "to" language from the drop-down.

Review URL: http://codereview.chromium.org/3078026
------------------------------------------------------------------------
r54999 | asargent@chromium.org | 2010-08-05 01:47:41 +0200 (Thu, 05 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc

Update the names of some parameters passed to contextMenu onclick handlers.

This changes the mediaType parameter values to be lowercase (eg "audio" instead
of "AUDIO"), and changes mainFrameUrl to be pageUrl as the design doc had 
intended.

BUG=49725
TEST=In onclick handlers, values for mediaType should be lowercase and there
should be a pageUrl property matching the url of the page.

Review URL: http://codereview.chromium.org/3017056
------------------------------------------------------------------------
r54996 | tfarina@chromium.org | 2010-08-05 01:43:20 +0200 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/base/environment.cc
   M /trunk/src/base/environment.h
   M /trunk/src/base/environment_unittest.cc
   M /trunk/src/base/nss_util.cc
   M /trunk/src/base/xdg_util.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/process_watcher_win.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/media/audio/audio_output_controller_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

base: rename Environment::HasEnv to Environment::HasVar.

This is the part 2 of this series. More two comming. Splitting this
into small parts, so it is more easy to review and reduce the size of the CL.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3035050
------------------------------------------------------------------------
r54984 | davemoore@chromium.org | 2010-08-05 00:41:44 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc

Initialize use_stub_impl_ in cros_library.cc
BUG=NONE
TEST=Valgrind builders no longer show error
TBR: cmasone

Review URL: http://codereview.chromium.org/3020066
------------------------------------------------------------------------
r54981 | satish@chromium.org | 2010-08-05 00:24:11 +0200 (Thu, 05 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/speech/speech_input_browsertest.cc
   A /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.cc
   A /trunk/src/chrome/browser/speech/speech_input_dispatcher_host.h
   A /trunk/src/chrome/browser/speech/speech_input_manager.cc
   A /trunk/src/chrome/browser/speech/speech_input_manager.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/renderer/speech_input_dispatcher.cc
   A /trunk/src/chrome/renderer/speech_input_dispatcher.h
   A /trunk/src/chrome/test/data/speech/basic_recognition.html

Adds chromium side plumbing to pass speech input calls back and forth with WebKit.

Please advise if any of the code needs to be within "#if ENABLE_INPUT_SPEECH", since most of the speech input code in webkit is under "#if ENABLE(INPUT_SPEECH)"

- Created renderer/SpeechInputDispatcher, implements WebKit::WebSpeechInputController which is used by WebView for invoking speech input.
- Created browser/speech/SpeechInputDispatcherHost to receive IPC messages from the above SpeechInputDispatcher. Nothing done yet apart from receiving the messages.
- Creates new directory chrome/browser/speech, this will be used for SpeechInputDispatcherHost, network based speech recognizer, speech audio recording/buffering code as well as  speech output (Text-to-speech) code in future.

BUG=none
TEST=no functionality to test yet.

Review URL: http://codereview.chromium.org/3035035
------------------------------------------------------------------------
r54980 | brettw@chromium.org | 2010-08-05 00:23:29 +0200 (Thu, 05 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_publisher_win.cc

Fix a crash in the history publisher. This is caused by me changing the
signature of ASCIIToWide to no longer take a string piece. This changed the
behavior for NULL handling (NULL is no longer supported).

This change just doesn't do any conversion if the source is NULL.

BUG=51185
TEST=none

Review URL: http://codereview.chromium.org/2819090
------------------------------------------------------------------------
r54977 | erg@google.com | 2010-08-05 00:12:50 +0200 (Thu, 05 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc

Fixes bug 12305 -- 1.66:1 should be UNKNOWN, not URL.

Rearranges the autocomplete heuristics to reject malformed IP addresses before accepting them based on having a port or a username or a password.

BUG=12305
TEST=AutocompleteTest.InputType

Review URL: http://codereview.chromium.org/2868085
Patch from Ilya Sherman <isherman@google.com>.
------------------------------------------------------------------------
r54976 | xiyuan@chromium.org | 2010-08-05 00:08:41 +0200 (Thu, 05 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc

Add back the lost mock data to get rid of "undefined" in users options page.

BUG=none
TEST=Verify the mock user in users options page does not has "undefined" as their names.

Review URL: http://codereview.chromium.org/3076031
------------------------------------------------------------------------
r54974 | jhawkins@chromium.org | 2010-08-05 00:02:14 +0200 (Thu, 05 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/name_field_unittest.cc

AutoFill: Add more NameField tests and fix incorrect logic in ParseEmpty.
ParseEmpty should only match against the label text.

BUG=none
TEST=NameFieldTest.*;AddressFieldTest.*

Review URL: http://codereview.chromium.org/3067029
------------------------------------------------------------------------
r54970 | albertb@chromium.org | 2010-08-04 23:39:27 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/cryptographer.cc
   M /trunk/src/chrome/browser/sync/util/nigori.cc
   M /trunk/src/chrome/browser/sync/util/nigori.h
   M /trunk/src/chrome/browser/sync/util/nigori_unittest.cc

Let the Nigori client import and export raw encryption keys.

BUG=48701
TEST=NigoriTest.*

Review URL: http://codereview.chromium.org/3013047
------------------------------------------------------------------------
r54969 | evan@chromium.org | 2010-08-04 23:28:56 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate_win.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/test/mini_installer_test/test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome_frame/test/net/process_singleton_subclass.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc
   M /trunk/src/chrome_frame/test/reliability/run_all_unittests.cc

Revert "Remove GetSwitchValue() from chrome/* where easy."

This reverts commit r54966.

Meant to try it, not commit it, sorry everyone.  :(
------------------------------------------------------------------------
r54966 | evan@chromium.org | 2010-08-04 23:15:34 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate_win.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/test/mini_installer_test/test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome_frame/test/net/process_singleton_subclass.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc
   M /trunk/src/chrome_frame/test/reliability/run_all_unittests.cc

Remove GetSwitchValue() from chrome/* where easy.

Review URL: http://codereview.chromium.org/3057033
------------------------------------------------------------------------
r54964 | xiyuan@chromium.org | 2010-08-04 23:06:31 +0200 (Wed, 04 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/browser/resources/shared/js/media_common.js

Allow open local pdf file from FileBrowse UI.

Allow local pdf file to be opened if a pdf plugin is available.

BUG=chromium-os:5263
TEST=Verify local pdf file could be opened and viewed by pdf plugin.

Review URL: http://codereview.chromium.org/3083015
------------------------------------------------------------------------
r54959 | sargrass@google.com | 2010-08-04 22:23:44 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.cc
   A /trunk/src/chrome/browser/dom_ui/passwords_exceptions_handler.h
   A /trunk/src/chrome/browser/resources/options/passwords_exceptions.html
   A /trunk/src/chrome/browser/resources/options/passwords_exceptions.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Start passwords exceptions

BUG=None
Test=None

Review URL: http://codereview.chromium.org/3061049
------------------------------------------------------------------------
r54954 | estade@chromium.org | 2010-08-04 22:15:04 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

GTK: unbreak extension badges.

BUG=50682
TEST=load make_page_red, you can see the badge; dragging still works, clicking still works, removing icons still works

Review URL: http://codereview.chromium.org/3064039
------------------------------------------------------------------------
r54950 | davemoore@chromium.org | 2010-08-04 22:05:17 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.h
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/cros/syslogs_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/syslogs_library.h
   M /trunk/src/chrome/browser/chromeos/cros/system_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/system_library.h
   M /trunk/src/chrome/browser/chromeos/cros/update_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/update_library.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

To effectively test some parts of chrome for cros on the linux desktop, we need a way to start chrome logged in. The login UI requires the WM to display, so I added command line options to do this. But we needed the full functionality of login, which doesn't work when libcros can't be loaded. I created stubs for all the cros api. I then took both stubs and the real implementations and put them entirely inside the .cc files (no separate declaration of the implementations in the .h files).

Review URL: http://codereview.chromium.org/3076029
------------------------------------------------------------------------
r54947 | suzhe@chromium.org | 2010-08-04 21:48:19 +0200 (Wed, 04 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/base/keyboard_code_conversion_gtk.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/focus/accelerator_handler.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/accelerator_handler_gtk_unittest.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/widget/gtk_views_window.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

[Linux Views] Refactor accelerator handler related code.

This CL removes the accelerator handling logic in
accelerator_handler_gtk.cc and implements a much simpler solution in
WidgetGtk. The new approach always sends a key event to the focused View
and native GtkWidget first and only sends it to the focus manager if it's not
handled by any View or native GtkWidget.

BUG=23383 AcceleratorHandler on Windows should not dispatch the KEYUP messages eaten by the FocusManager
BUG=40966 BrowserKeyEventsTest.AccessKeys is crashy
BUG=49701 [Linux Views]Some Emacs keybindings are broken in omnibox and find in page box.
TEST=Press Alt key in different place (web page, omnibox, find bar, etc.) to see if menu bar can be focused correctly. Press alt-F to popup wrench menu and Escape to close it, then try alt key again.

Review URL: http://codereview.chromium.org/3046041
------------------------------------------------------------------------
r54946 | tony@chromium.org | 2010-08-04 21:47:20 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view.cc

Remove a deprecated wstring ToLower function.

BUG=23581

Review URL: http://codereview.chromium.org/3044043
------------------------------------------------------------------------
r54945 | evan@chromium.org | 2010-08-04 21:40:42 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Remove wstring-ness from some more locale variables.

Review URL: http://codereview.chromium.org/3043055
------------------------------------------------------------------------
r54944 | viettrungluu@chromium.org | 2010-08-04 21:35:33 +0200 (Wed, 04 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/plugin_updater.cc

Rename GetStringAsUTF16() to GetString() (and overload), etc.

Also do some drive-by wstring/wchar_t -> string/char changes (in addition to the
necessary ones).

BUG=none
TEST=builds and tests pass

Review URL: http://codereview.chromium.org/3091005
------------------------------------------------------------------------
r54942 | sky@chromium.org | 2010-08-04 21:31:45 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.cc

Makes browser windows always render active on chromeos.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3007031
------------------------------------------------------------------------
r54941 | xiyuan@chromium.org | 2010-08-04 21:29:22 +0200 (Wed, 04 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_network_element.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options_page.css

Add "Other..." to wireless networks.

- Create a fake network item for "Other..." in InternetOptionsHandler;
- Update js to handle "Other...". That is, no icon, status and action buttons for this item and click on the item brings up the wifi dialog;
- Show default cursor on network item text;

BUG=chromium-os:4744
TEST=Verify that "Other..." shows up at the end of wireless networks and works.

Review URL: http://codereview.chromium.org/3046044
------------------------------------------------------------------------
r54940 | avi@chromium.org | 2010-08-04 21:29:13 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.h

Cleanup of unused code.

BUG=none
TEST=no change

Review URL: http://codereview.chromium.org/3064040
------------------------------------------------------------------------
r54933 | evan@chromium.org | 2010-08-04 20:24:38 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

PrependWrapper is platform-specific, so it should take a platform string.

Though the comments said it was POSIX only, I see it used on Windows as
well so I'm updating the comment.

Review URL: http://codereview.chromium.org/3030043
------------------------------------------------------------------------
r54932 | cbentzel@chromium.org | 2010-08-04 20:14:15 +0200 (Wed, 04 Aug 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/net/spdy/spdy_session.cc

Adds an option, enabled by default, to net-internals to
remove cookies from log dumps.  Also, SPDY headers are now
displayed (And stored) just like http ones.  Cookies are
always shown on the Requests page.

As an added bonus, removes a superfluous </b> from index.html.

Contributed by: mmenke@google.com

BUG= 50668
TEST= Go to about:net-internals, and check for
  properly hiding cookies for both HTTP and SPDY,
  for both sent and received cookies.

Review URL: http://codereview.chromium.org/3072013
------------------------------------------------------------------------
r54931 | estade@chromium.org | 2010-08-04 20:10:37 +0200 (Wed, 04 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js

tabbed content settings:

- Implement add button
- disable edit/remove buttons when appropriate

BUG=48862
TEST=manual

Review URL: http://codereview.chromium.org/3076028
------------------------------------------------------------------------
r54930 | jar@chromium.org | 2010-08-04 20:03:11 +0200 (Wed, 04 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   D /trunk/src/net/socket/client_socket.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool_base.h

Revert 54771 - Enable speculative preconnection by default

Added histogram to track utilization (vs waste).

[The stability bot was reporting problems, so I'm reverting]

r=mbelshe
Review URL: http://codereview.chromium.org/3026038

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/3090011
------------------------------------------------------------------------
r54928 | estade@chromium.org | 2010-08-04 20:00:01 +0200 (Wed, 04 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

GTK: Fix upgrade notification dot.

Changing the wrench menu to a custom button broke it.

BUG=50682
TEST=visual

Review URL: http://codereview.chromium.org/3058041
------------------------------------------------------------------------
r54927 | xiyuan@chromium.org | 2010-08-04 19:54:42 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings_provider.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix valgrind mem leak per chromium:51134.

BUG=chromium:51134
TEST=CrOS UI (valgrind) should not complain mem leak as in issue 51134.

Review URL: http://codereview.chromium.org/3036042
------------------------------------------------------------------------
r54924 | thakis@chromium.org | 2010-08-04 19:47:06 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/background_contents_service_unittest.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/hover_image_button_unittest.mm

Mac: Make clang compile unit_tests.

BUG=TEST=none

Review URL: http://codereview.chromium.org/3012045
------------------------------------------------------------------------
r54923 | kbr@google.com | 2010-08-04 19:46:23 +0200 (Wed, 04 Aug 2010) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_channel.h
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.cc
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.h
   M /trunk/src/chrome/renderer/ggl/ggl.cc
   M /trunk/src/chrome/renderer/ggl/ggl.h
   M /trunk/src/chrome/renderer/gpu_channel_host.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webgles2context_impl.cc
   M /trunk/src/chrome/renderer/webgles2context_impl.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor_mac.cc

Initial port of accelerated compositor to Mac OS X 10.6. Reused
infrastructure added for Pepper 3D and Core Animation plugins to
render the compositor's output. The implementation allocates a fake
"plugin window handle" on the browser side which is the "root" handle,
containing the compositor's output, and which, if present, is drawn
before any other accelerated plugin instances.

Added messages from GPU process to browser process for handling window
resizing and presentation of output. Added support to GGL for "view"
contexts on Mac OS X, used only for the accelerated compositor, and
requiring explicit resize notifications.

The remainder of this port will go into the WebKit repository under
https://bugs.webkit.org/show_bug.cgi?id=43398 after this for
dependency reasons.

Tested manually with CSS 3D and WebGL demos. Several stability and
correctness issues remain and will be addressed in following CLs;
however, the current code works for the majority of basic use cases
including switching between accelerated compositing on and off, and
scrolling of content.

BUG=38969
TEST=none

Review URL: http://codereview.chromium.org/3067026
------------------------------------------------------------------------
r54921 | dmazzoni@chromium.org | 2010-08-04 19:41:54 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.js

Make options tabs keyboard-accessible.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3083010
------------------------------------------------------------------------
r54920 | mirandac@chromium.org | 2010-08-04 19:38:46 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

Fix Firefox import lock dialog on Windows.

BUG=50577
TEST= run chrome first_run with import while Firefox is default browser and open.  Dialog should pop up telling user to close FF.
Review URL: http://codereview.chromium.org/2868077
------------------------------------------------------------------------
r54917 | evan@chromium.org | 2010-08-04 19:07:46 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_dummy.cc
   M /trunk/src/app/resource_bundle_posix.cc
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/app/test_suite.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/examples/examples_main.cc

Remove wstrings from l10n_util/ResourceBundle locale functions.

Review URL: http://codereview.chromium.org/3069026
------------------------------------------------------------------------
r54916 | mpcomplete@chromium.org | 2010-08-04 19:06:41 +0200 (Wed, 04 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

When toggling an extension in incognito, don't disable/reenable the extension
unless it's already enabled.

BUG=50582
TEST=toggling extension in incognito still works, and syncs properly

Review URL: http://codereview.chromium.org/3043053
------------------------------------------------------------------------
r54915 | viettrungluu@chromium.org | 2010-08-04 18:58:12 +0200 (Wed, 04 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/net/proxy/proxy_resolver_js_bindings.cc

Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).

Also do a bunch of drive-by changes while I'm at it.

Still to do: rename GetStringAsUTF16() to GetString().

BUG=none
TEST=builds everywhere, tests pass

Review URL: http://codereview.chromium.org/3033050
------------------------------------------------------------------------
r54914 | dhg@chromium.org | 2010-08-04 18:20:24 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings_page.css
   M /trunk/src/chrome/browser/resources/options/options_page.css

Fixing css layouts

Review URL: http://codereview.chromium.org/3030040
------------------------------------------------------------------------
r54913 | dhg@chromium.org | 2010-08-04 18:17:38 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/dom_ui/proxy_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/proxy_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   A /trunk/src/chrome/browser/resources/options/chromeos_proxy.html
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Adding mocked out pages for the proxy settings.

Review URL: http://codereview.chromium.org/3051007
------------------------------------------------------------------------
r54911 | skrul@chromium.org | 2010-08-04 18:15:09 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html

Use the "tabIndex" property on the wizard iframes to prevent tabbing between iframes.

BUG=48138

Review URL: http://codereview.chromium.org/2819089
------------------------------------------------------------------------
r54910 | nkostylev@google.com | 2010-08-04 18:13:51 +0200 (Wed, 04 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Clear username (along with password) in NewUserView as long as NewUserView was abandoned and revisited later.
Also for NewUserView: get focus on username not password.

BUG=http://crosbug.com/4330
TEST=Manual

Review URL: http://codereview.chromium.org/3032053
------------------------------------------------------------------------
r54908 | mrossetti@chromium.org | 2010-08-04 18:07:34 +0200 (Wed, 04 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   A /trunk/src/chrome/browser/autocomplete/history_quick_provider.cc
   A /trunk/src/chrome/browser/autocomplete/history_quick_provider.h
   A /trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add Framework for History Quick Provider

Incorporate 'quick' history provider index as an autocomplete provider in preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results. 

BUG=None 
TEST=None 

Review URL: http://codereview.chromium.org/3005050
------------------------------------------------------------------------
r54904 | glotov@chromium.org | 2010-08-04 17:38:36 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h

Not showing OEM EULA border if nothing to show there.

BUG=chromium:3178 
TEST=none 

Review URL: http://codereview.chromium.org/3060040
------------------------------------------------------------------------
r54902 | danno@chromium.org | 2010-08-04 17:31:38 +0200 (Wed, 04 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.h
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

Changing policy while Chrome is running should refresh preferences without relaunching

Includes windows-only Group Policy watcher that triggers policy refresh.

BUG=45324
TEST=--gtest_filter=PrefValueStoreTest.* and manual

Review URL: http://codereview.chromium.org/2858060
------------------------------------------------------------------------
r54895 | nkostylev@google.com | 2010-08-04 14:36:52 +0200 (Wed, 04 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/resources/host_registration_page.html

Integrate register screen into OOBE.
Load startup manifest till device is registered.
Skip registration if any error occurs on register screen/page.

BUG= http://crosbug.com/4645
TEST=manually. Go through whole OOBE process, use startup manifest with external register page.

Review URL: http://codereview.chromium.org/3044042
------------------------------------------------------------------------
r54888 | finnur@chromium.org | 2010-08-04 12:29:47 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Augment the About box flow to automatically install any new version we find on the server and have inline buttons to suggest restart, which restores your session (as opposed to the modal dialog box suggesting a restart and not restarting/restoring).

BUG=http://crbug.com/43076, http://crbug.com/1821
TEST=Needs manual testing with an active Google Update server.

Review URL: http://codereview.chromium.org/3076018
------------------------------------------------------------------------
r54883 | pam@chromium.org | 2010-08-04 11:28:52 +0200 (Wed, 04 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_proxy_api.cc

Fix compile error by removing "typedef".

BUG=48930
TEST=Linux (dbg-shlib) compiles without warnings/errors
------------------------------------------------------------------------
r54882 | pam@chromium.org | 2010-08-04 11:13:44 +0200 (Wed, 04 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_proxy_api.cc
   A /trunk/src/chrome/browser/extensions/extension_proxy_api.h
   A /trunk/src/chrome/browser/extensions/extension_proxy_apitest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   A /trunk/src/chrome/common/extensions/docs/experimental.proxy.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/proxy
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/individual
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/individual/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/individual/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/individual/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/single
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/single/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/single/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/proxy/single/test.js

First stage of proxy extension API.

Adds a basic API that will cover the features available with the --proxy-server command-line switch,
once the underlying proxy config is rewritten to actually access the pref dynamically rather than
only ever loading a proxy config on startup.

BUG=48930
TEST=covered by browser_tests (ExtensionApiTest.Proxy*)

Review URL: http://codereview.chromium.org/3074013
------------------------------------------------------------------------
r54870 | thakis@chromium.org | 2010-08-04 06:27:19 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/base/string_piece.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.mm
   M /trunk/src/chrome/browser/cocoa/popup_blocked_animation_mac.mm
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/default_plugin/plugin_impl_gtk.h
   M /trunk/src/chrome/default_plugin/plugin_impl_mac.h
   M /trunk/src/chrome/default_plugin/plugin_impl_win.h
   M /trunk/src/gpu/command_buffer/service/program_manager.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/http/http_auth_gssapi_posix.h
   M /trunk/src/skia/ext/canvas_paint_mac.h
   M /trunk/src/webkit/glue/glue_serialize.cc

Mac: Some clang appeasing.

BUG=TEST=none

Review URL: http://codereview.chromium.org/3089004
------------------------------------------------------------------------
r54869 | satorux@chromium.org | 2010-08-04 06:13:26 +0200 (Wed, 04 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   A /trunk/src/chrome/browser/resources/options/chromeos_language_add_language_overlay.html
   A /trunk/src/chrome/browser/resources/options/chromeos_language_add_language_overlay.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html

Implement "Add" and "Remove" buttons in Language and Input page.

Along the way, remove translation for language codes in
|localStrings| (ex "fr" -> "French").
Instead introduce templateData.languageList, with which
we can retrieve language information.

TEST=manually
BUG=4573

Review URL: http://codereview.chromium.org/3041025
------------------------------------------------------------------------
r54867 | ananta@chromium.org | 2010-08-04 06:02:51 +0200 (Wed, 04 Aug 2010) | 12 lines
Changed paths:
   D /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   D /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

ChromeFrame currently overrides the request context for intercepting network requests and cookie requests to route them
over the automation channel. This adds needless complexity and race conditions between registering a request context for
a renderer process as the first one wins. 

We no longer override the request context in ChromeFrame. For cookie requests we look up the registered render view map
and on finding one we route the request over the automation channel.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=51103

Bug=51103

Review URL: http://codereview.chromium.org/3036038
------------------------------------------------------------------------
r54866 | nick@chromium.org | 2010-08-04 05:45:34 +0200 (Wed, 04 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Set expectation of default font to Tinos on ChromeOS

TBR=jshin
BUG=51135
TEST=unit_tests

Review URL: http://codereview.chromium.org/3064035
------------------------------------------------------------------------
r54863 | evan@chromium.org | 2010-08-04 04:25:03 +0200 (Wed, 04 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc

Build fix.
------------------------------------------------------------------------
r54862 | tfarina@chromium.org | 2010-08-04 04:13:34 +0200 (Wed, 04 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/environment.cc
   M /trunk/src/base/environment.h
   M /trunk/src/base/environment_unittest.cc
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

base: rename Environment::UnSetEnv to Environment::UnSetVar.

This is the part 1 of this series. More three comming. Splitting this
into small parts, so it is more easy to review and reduce the size of the CL.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/3058034
------------------------------------------------------------------------
r54860 | evan@chromium.org | 2010-08-04 03:47:55 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

De-wstringify some browser startup code and net utility.

Review URL: http://codereview.chromium.org/3054042
------------------------------------------------------------------------
r54859 | cbentzel@chromium.org | 2010-08-04 03:44:57 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connection_tester_unittest.cc
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest.txt

Enable ConnectionTesterTest.RunAllTests in everything but valgrind.

BUG=50950
TEST=None

Review URL: http://codereview.chromium.org/3082017
------------------------------------------------------------------------
r54858 | evan@chromium.org | 2010-08-04 03:28:51 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/update_recommended_dialog.cc

Reduce the padding in the "update needed" dialog.

Dialogs already have padding, so it had double the necessary padding.

Review URL: http://codereview.chromium.org/3056048
------------------------------------------------------------------------
r54856 | evan@chromium.org | 2010-08-04 03:23:00 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc

Remove usage of GetSwitchValue for most of chrome/browser/.

Review URL: http://codereview.chromium.org/3005053
------------------------------------------------------------------------
r54854 | cmasone@google.com | 2010-08-04 03:00:01 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/logging_chrome.cc

[ChromeOS] Keep logging inside the user's home dir, even after a browser crash

BUG=50866
TEST=Boot, log in, check that logging goes to /home/chronos/user/chrome_log.  Crash the browser.  After it comes back, verify that the browser process has created a new log file in /home/chronos/user and is writing to it.

Review URL: http://codereview.chromium.org/3063014
------------------------------------------------------------------------
r54851 | dcheng@chromium.org | 2010-08-04 02:17:13 +0200 (Wed, 04 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc

Fix debug build GTK assert in TabContentsDragSource::OnDragBegin().

The assert is:
Gtk: gtk_widget_set_colormap: assertion `!gtk_widget_get_realized
(widget)' failed.

BUG=none
TEST=Navigate to google.com and drag the logo twice.

Review URL: http://codereview.chromium.org/3086011
------------------------------------------------------------------------
r54850 | estade@chromium.org | 2010-08-04 02:12:48 +0200 (Wed, 04 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/owned_widget_gtk.cc

[GTK] More m6 toolbar fixes.

- make wrench menu a custom button rather than gtk_chrome_button (changes appearance slightly)
- correct sizing/spacing of wrench menu
- new overflow chevron graphic (also a CustomDrawButton converted from a gtk_chrome_button)
- fix things I broke when I was hastily fixing the build earlier

BUG=50682
TEST=visual

Review URL: http://codereview.chromium.org/3053038
------------------------------------------------------------------------
r54848 | dhg@chromium.org | 2010-08-04 01:50:47 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_settings.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings.h
   A /trunk/src/chrome/browser/chromeos/cros_settings_provider.h
   A /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.cc
   A /trunk/src/chrome/browser/chromeos/cros_settings_provider_user.h
   D /trunk/src/chrome/browser/chromeos/mock_cros_settings.cc
   D /trunk/src/chrome/browser/chromeos/mock_cros_settings.h
   M /trunk/src/chrome/chrome_browser.gypi

adding ability to register providers to handle particular properties

BUG=none
TEST=making sure the UI still works

Review URL: http://codereview.chromium.org/3020047
------------------------------------------------------------------------
r54843 | shess@chromium.org | 2010-08-04 01:36:50 +0200 (Wed, 04 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   A /trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button.h
   A /trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button.mm
   A /trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button_cell.h
   A /trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Integrate divider into browser-action overflow chevron.

Divider shows when the mouse is not hovering.

BUG=50575
TEST=divider shows when the mouse is not hovering.

Review URL: http://codereview.chromium.org/3014049
------------------------------------------------------------------------
r54839 | shess@chromium.org | 2010-08-04 01:27:04 +0200 (Wed, 04 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm

[Mac] Adjust browser-action and content-setting popup points

Adjust the browser-action popup point to leave the top border of the
window 2px below the bottom border of the Omnibox.  This matches the
Omnibox popup, the bookmark popup, and page-action popups.

Likewise content-setting popup.

BUG=50575
TEST=The popup is spaced correctly.

Review URL: http://codereview.chromium.org/3054040
------------------------------------------------------------------------
r54837 | sargrass@google.com | 2010-08-04 01:25:53 +0200 (Wed, 04 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   A /trunk/src/chrome/browser/resources/options/import_data_overlay.css
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options.html

add throbber, remove radio

Review URL: http://codereview.chromium.org/3074026
------------------------------------------------------------------------
r54834 | evan@chromium.org | 2010-08-04 01:15:38 +0200 (Wed, 04 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

Fix build.
------------------------------------------------------------------------
r54830 | viettrungluu@chromium.org | 2010-08-04 00:47:10 +0200 (Wed, 04 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc

Make BrowserInit use FilePath instead of wstring for current directory.

(A.k.a. shaving a yak to get rid of a FromWStringHack().)

BUG=24672
TEST=builds

Review URL: http://codereview.chromium.org/3064032
------------------------------------------------------------------------
r54827 | jhawkins@chromium.org | 2010-08-04 00:42:27 +0200 (Wed, 04 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card.cc

AutoFill: Remove an unused and buggy condition.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3060042
------------------------------------------------------------------------
r54824 | johnnyg@chromium.org | 2010-08-04 00:34:05 +0200 (Wed, 04 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm

Remove double initialization which causes valgrind failure in unit test.

BUG=49590
TEST=this test
Review URL: http://codereview.chromium.org/3085007
------------------------------------------------------------------------
r54818 | estade@chromium.org | 2010-08-03 23:03:46 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.css
   M /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js

[Options DOMUI] More content settings exceptions work

BUG=48862
TEST=editing image exceptions works

Review URL: http://codereview.chromium.org/2883045
------------------------------------------------------------------------
r54817 | estade@chromium.org | 2010-08-03 23:02:16 +0200 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/overflow_button.h
   A /trunk/src/chrome/browser/gtk/owned_widget_gtk.cc (from /trunk/src/chrome/common/owned_widget_gtk.cc:54659)
   A /trunk/src/chrome/browser/gtk/owned_widget_gtk.h (from /trunk/src/chrome/common/owned_widget_gtk.h:54659)
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.h
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   D /trunk/src/chrome/common/owned_widget_gtk.cc
   D /trunk/src/chrome/common/owned_widget_gtk.h

Move owned_widget_gtk.* out of common/, into browser/gtk/.

common/ is for files shared between the renderer and browser processes, and OwnedWidgetGtk is not used outside of browser/.

BUG=none
TEST=compile

Review URL: http://codereview.chromium.org/3063023
------------------------------------------------------------------------
r54814 | sargrass@google.com | 2010-08-03 22:52:05 +0200 (Tue, 03 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.h

remove memory leak
relating to http://code.google.com/p/chromium/issues/detail?id=51058

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3066032
------------------------------------------------------------------------
r54811 | dmazzoni@chromium.org | 2010-08-03 22:42:46 +0200 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   M /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc

Fix problem where AccessibilityEventRouterGtk could crash a unit test,
because an event listener registered by a singleton tried to access the
current message loop, which may not exist.

BUG=48717
TEST=Re-enables AccessibilityEventRouterViewsTest.TestFocusNotification

Review URL: http://codereview.chromium.org/3092004
------------------------------------------------------------------------
r54810 | phajdan.jr@chromium.org | 2010-08-03 22:41:03 +0200 (Tue, 03 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_history.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix a memory leak in all callers of DownloadHistory::Search.

We should delete the callback after running it.

This change removes Valgrind suppressions for the leak.

TEST=valgrind
BUG=50729

Review URL: http://codereview.chromium.org/2819085
------------------------------------------------------------------------
r54807 | mnissler@chromium.org | 2010-08-03 22:20:50 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Reset chrome://newtab URLs when the user selects to configure it.

BUG=50927
TEST=Manually configure a profile with prefs::kHomepage = chrome://newtab and prefs::kHomePageIsNewTabPage = true, fire up chrome and try to configure a different homepage URL through the options dialog.

Review URL: http://codereview.chromium.org/3092003
------------------------------------------------------------------------
r54804 | rsesek@chromium.org | 2010-08-03 22:10:41 +0200 (Tue, 03 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/menu_tracked_button.h
   A /trunk/src/chrome/browser/cocoa/menu_tracked_button.mm
   A /trunk/src/chrome/browser/cocoa/menu_tracked_button_unittest.mm
   A /trunk/src/chrome/browser/cocoa/menu_tracked_root_view.h
   A /trunk/src/chrome/browser/cocoa/menu_tracked_root_view.mm
   A /trunk/src/chrome/browser/cocoa/menu_tracked_root_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Enable click-drag-release behavior in the Wrench menu's custom items.

XIB changes:
* Replace the edit item's segmented control with 3 buttons
* Make the root view of both items a MenuTrackedRootView
* Use the custom MenuTrackedButton for all the buttons

BUG=49356
TEST=Click open the Wrench menu, hold, and drag over the buttons and they perform their function.

Review URL: http://codereview.chromium.org/3072014
------------------------------------------------------------------------
r54793 | dmazzoni@chromium.org | 2010-08-03 21:07:35 +0200 (Tue, 03 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/wrench_menu.cc

Add accessible labels for the icon buttons in the wrench menu.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3054037
------------------------------------------------------------------------
r54791 | evan@chromium.org | 2010-08-03 21:04:23 +0200 (Tue, 03 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc

Use new CopySwitchesFrom CommandLine API to simplify some code.

Review URL: http://codereview.chromium.org/3010046
------------------------------------------------------------------------
r54789 | petkov@chromium.org | 2010-08-03 20:52:02 +0200 (Tue, 03 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/update_observer.cc

Handle the REPORTING_ERROR_EVENT state appropriately.

Notify the user of the error event if the user has been
notified about the update progress already. Stay quiet
otherwise.

BUG=chromium-os:5266
TEST=unit tests

Review URL: http://codereview.chromium.org/3033048
------------------------------------------------------------------------
r54782 | shess@chromium.org | 2010-08-03 19:59:46 +0200 (Tue, 03 Aug 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/app/theme/browser_actions_overflow_Template.pdf
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/chrome_dll.gypi

[Mac] Adjust toolbar spacing of browser actions for M6.

Toolbar.xib change brings browser-action container view out from under
Omnibox.

Push browser-action sizing code into controller to reduce exposed
constants.  Make size consistent with other toolbar buttons.  4px
visual spacing from omnibox to first browser action (grippy in that
area), between browser actions, and last action to wrench menu.

browser_actions_overflow_Template.pdf resource for browser-action
chevron.  Chevron same height as browser actions.  Get rid of divider
between browser actions and wrench (future CL will integrate it into
chevron button).  Chevron 4px from Omnibox or 2px from last browser
action, then 4px to wrench menu.  Chevron button has hover like other
buttons.

BUG=50575
TEST=Browser-actions area still works right WRT spacing and rearranging and everything else.

Review URL: http://codereview.chromium.org/3012044
------------------------------------------------------------------------
r54777 | hans@chromium.org | 2010-08-03 19:40:28 +0200 (Tue, 03 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h

Forward-declare AutocompleteMatch as a struct in autocomplete_popup_view_gtk.h

AutocompleteMatch is a struct, and should thus be forward-declared as such.
Otherwise, Clang warns about the mismatch, and we treat the warning as an error.

BUG=49304
TEST=None

Review URL: http://codereview.chromium.org/2805086
------------------------------------------------------------------------
r54775 | csilv@chromium.org | 2010-08-03 19:33:57 +0200 (Tue, 03 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.cc
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js

Fix clear browser data buttons, broke due to namespace change.

BUG=none
TEST=verify clear browser data buttons work correctly via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3027039
------------------------------------------------------------------------
r54774 | thakis@chromium.org | 2010-08-03 19:26:34 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Mac: Fix merge mishap.

BUG=50307
TEST=Start chrome with --enable-expose-for-tabs. cmd-f10 should toggle a grey overlay instead of doing something strange to the tabstrip.

Review URL: http://codereview.chromium.org/3007028
------------------------------------------------------------------------
r54772 | sky@chromium.org | 2010-08-03 19:19:54 +0200 (Tue, 03 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc
   M /trunk/src/views/controls/menu/menu_config_win.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc

Makes cut/copy/paste buttons centered with respect to the
separator. This proves a bit tricky as normally separators are closer
to the bottom of the space provided. I've centered them now so that
the buttons look centered too.

BUG=50099
TEST=see bug

Review URL: http://codereview.chromium.org/3072015
------------------------------------------------------------------------
r54771 | jar@chromium.org | 2010-08-03 19:19:17 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   A /trunk/src/net/socket/client_socket.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool_base.h

Enable speculative preconnection by default

Added histogram to track utilization (vs waste).

r=mbelshe
Review URL: http://codereview.chromium.org/3026038
------------------------------------------------------------------------
r54768 | xiyuan@chromium.org | 2010-08-03 18:59:10 +0200 (Tue, 03 Aug 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/options/chromeos_internet_network_element.js
   D /trunk/src/chrome/browser/resources/options/chromeos_internet_network_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options_page.css
   M /trunk/src/chrome/browser/resources/options.html

CSS/JS touch up to make network options page look like mock.

- Overide section css to make things look like mock;
- CSS/JS updates per arv's previous reviews to make everything in CSS;

BUG=chromium-os:4744
TEST=none.

Review URL: http://codereview.chromium.org/3080017
------------------------------------------------------------------------
r54767 | shess@chromium.org | 2010-08-03 18:48:30 +0200 (Tue, 03 Aug 2010) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/image_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/star_decoration.mm

[Mac] M6 Omnibox positioning changes.

3px from top and bottom of images to cell edges in popup.  With this
change baselines worked out without tweaking.

Omnibox popup text wasn't quite aligned with field because previous
change used leading 'w' (regression).  This change measured using
leading 'P'.

Adjust keyword-hint decoration spacing around the image.  Also adjust
baseline to match font (regression).

Modify ImageDecoration to center the image horizontally, which allows
the decoration width to be independent of the image width.
PageActionDecoration uses this to pin the effective size at
|kPageActionIconMaxSize|.

Position page-action and bookmark popups so top border is at same gap
from Omnibox (2px) as Omnibox popup.  The mocks actually show the
bookmark point as an additional px from the star "crotch", but I think
this is reasonable for M6.

BUG=50575, 50765
TEST=none.  Everything still works?

Review URL: http://codereview.chromium.org/3015046
------------------------------------------------------------------------
r54763 | inferno@chromium.org | 2010-08-03 18:29:59 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Handle destruction of select file dialog listener object in tab contents destructor.

BUG=45400
TEST=None

Review URL: http://codereview.chromium.org/2856082
------------------------------------------------------------------------
r54761 | alyssad@chromium.org | 2010-08-03 18:27:01 +0200 (Tue, 03 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/extensions.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New PyAuto hooks for extensions.

Added two new hooks for extensions: GetExtensionsInfo returns information about all installed extensions and UninstallExtensionById uninstalls a given extension based on its id.

Review URL: http://codereview.chromium.org/3053034
------------------------------------------------------------------------
r54758 | brettw@chromium.org | 2010-08-03 18:17:20 +0200 (Tue, 03 Aug 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc

Fix the Windows build.
------------------------------------------------------------------------
r54757 | jiesun@google.com | 2010-08-03 18:10:27 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc

remove debug breaker when gpu process is enabled

BUG=None
TEST=Windows.

Review URL: http://codereview.chromium.org/3043044
------------------------------------------------------------------------
r54751 | viettrungluu@chromium.org | 2010-08-03 17:42:58 +0200 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/plugin_updater.cc

Remove Value/StringValue's ...UTF16() methods in favour of overloading.

Still to do: do the same for DictionaryValue.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3023037
------------------------------------------------------------------------
r54749 | brettw@chromium.org | 2010-08-03 17:21:27 +0200 (Tue, 03 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc

Fix the Windows build again.

TEST=none
BUG=none
------------------------------------------------------------------------
r54748 | brettw@chromium.org | 2010-08-03 17:07:03 +0200 (Tue, 03 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

Fix the Windows build.

TEST=it compiles
BUG=none
------------------------------------------------------------------------
r54747 | brettw@chromium.org | 2010-08-03 16:39:42 +0200 (Tue, 03 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/cocoa/authorization_util.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_text_field_cell.mm
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/default_plugin/plugin_database_handler.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/service/cloud_print/print_system_cups.cc
   M /trunk/src/chrome/test/chrome_process_util_mac.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome_frame/chrome_tab.cc
   M /trunk/src/chrome_frame/protocol_sink_wrap.cc
   M /trunk/src/chrome_frame/test/mock_ie_event_sink_test.h
   M /trunk/src/chrome_frame/test/test_server.cc
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/tools/dump_cache/upgrade.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_windowless_test.cc

Remove number conversion functions from string_util. These moved to string_number_conversions.

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3054036
------------------------------------------------------------------------
r54746 | brettw@chromium.org | 2010-08-03 16:35:22 +0200 (Tue, 03 Aug 2010) | 11 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_win.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/native_library_win.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/string16_unittest.cc
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   M /trunk/src/chrome/browser/autofill/contact_info_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card_unittest.cc
   M /trunk/src/chrome/browser/autofill/fax_field.cc
   M /trunk/src/chrome/browser/autofill/fax_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/name_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_number_unittest.cc
   M /trunk/src/chrome/browser/autofill/select_control_handler.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper_browsertest.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/network_message_observer.cc
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/cellular_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/ip_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc
   M /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk_unittest.cc
   M /trunk/src/chrome/browser/history/history_publisher_win.cc
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc
   M /trunk/src/chrome/browser/memory_details_linux.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/password_manager/login_database_posix.cc
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.cc
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/spellchecker_platform_engine_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/generic_info_view_unittest.cc
   M /trunk/src/chrome/browser/views/ssl_client_certificate_selector_win.cc
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win_unittest.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/web_applications/web_app_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc
   M /trunk/src/chrome/common/gpu_plugin.cc
   M /trunk/src/chrome/common/metrics_helpers.cc
   M /trunk/src/chrome/common/plugin_group_unittest.cc
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/default_plugin/plugin_impl_win.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager_unittest.cc
   M /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/translate_helper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome_frame/http_negotiate.cc
   M /trunk/src/chrome_frame/simple_resource_loader.cc
   M /trunk/src/chrome_frame/test/http_negotiate_unittest.cc
   M /trunk/src/chrome_frame/test/test_with_web_server.h
   M /trunk/src/chrome_frame/urlmon_moniker.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/courgette/encoded_program.cc
   M /trunk/src/ipc/ipc_channel_win.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/net/ftp/ftp_auth_cache_unittest.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_vms.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_vms_unittest.cc
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/http/http_auth_cache_unittest.cc
   M /trunk/src/net/http/http_auth_handler_basic_unittest.cc
   M /trunk/src/net/http/http_auth_handler_digest_unittest.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_unittest.cc
   M /trunk/src/net/http/http_auth_handler_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/url_security_manager_win.cc
   M /trunk/src/net/proxy/multi_threaded_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket_stream/socket_stream_unittest.cc
   M /trunk/src/net/tools/dump_cache/cache_dumper.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/webkit/database/database_util_unittest.cc
   M /trunk/src/webkit/database/databases_table_unittest.cc
   M /trunk/src/webkit/database/quota_table_unittest.cc
   M /trunk/src/webkit/glue/dom_operations_unittest.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_unittest.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_geturl_test.cc
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_unittest.cc
   M /trunk/src/webkit/support/test_webkit_client.cc
   M /trunk/src/webkit/tools/test_shell/mock_spellcheck.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Add #include utf_string_conversions.h to all files that use ASCIIToWide and
ASCIIToUTF16. I removed string_util includes from a few places where it
obviously wasn't needed.

In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm
going to do an even later pass to find the unnecessary string_util.h includes
and remove them.

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3058027
------------------------------------------------------------------------
r54742 | bauerb@chromium.org | 2010-08-03 15:18:04 +0200 (Tue, 03 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Fix DownloadTest.NewWindow

TBR: pfeldman@chromium.org
------------------------------------------------------------------------
r54737 | bauerb@chromium.org | 2010-08-03 13:46:51 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Only close a newly opened download tab if there's more than one tab.

BUG=45464,10764
TEST=See first bug for manual test.

Review URL: http://codereview.chromium.org/3029040
------------------------------------------------------------------------
r54731 | avayvod@chromium.org | 2010-08-03 12:09:39 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/existing_user_view.cc
   A /trunk/src/chrome/browser/chromeos/login/existing_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Landing http://codereview.chromium.org/3032043/show for Denis (dilmah).

BUG=http://crosbug.com/4411
TEST=On login screen change the language through new user pod and verify that for existing user pods text is translated to the new language.

Review URL: http://codereview.chromium.org/3047044
------------------------------------------------------------------------
r54727 | pfeldman@chromium.org | 2010-08-03 11:47:18 +0200 (Tue, 03 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc

DevTools: fix remote debugging dispatch, provide encoding in the main connect page.

Review URL: http://codereview.chromium.org/3071016
------------------------------------------------------------------------
r54725 | pfeldman@chromium.org | 2010-08-03 11:33:12 +0200 (Tue, 03 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: re-enable pause test.
BUG=50416

Review URL: http://codereview.chromium.org/3013057
------------------------------------------------------------------------
r54723 | jochen@chromium.org | 2010-08-03 10:55:01 +0200 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
   A /trunk/src/chrome/browser/extensions/extension_webrequest_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   A /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   A /trunk/src/chrome/common/extensions/docs/experimental.webRequest.html
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/api
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/api/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/api/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/webrequest
   A /trunk/src/chrome/test/data/extensions/api_test/webrequest/api
   A /trunk/src/chrome/test/data/extensions/api_test/webrequest/api/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/webrequest/api/test.html

Add the definition of the webRequest and webNavigation APIs.

The webRequest API doesn't support the planned filter and extraInfoSpec parameters yet, these will be added later.

BUG=50943
TEST=ExtensionApiTest.WebRequest,ExtensionApiTest.WebNavigation

Review URL: http://codereview.chromium.org/3061041
------------------------------------------------------------------------
r54722 | pfeldman@chromium.org | 2010-08-03 10:26:47 +0200 (Tue, 03 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/webkit/glue/devtools_message_data.cc
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_agent.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_agent.h
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_callargs.h
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_client.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_client.h

DevTools: Get rid of DevTools RPC.

Review URL: http://codereview.chromium.org/3005044
------------------------------------------------------------------------
r54720 | bauerb@chromium.org | 2010-08-03 10:22:21 +0200 (Tue, 03 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/blocked_plugin.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Add "Load all plugins on this page" button to blocked plugins bubble if click-to-play is enabled.

Screenshot: http://imgur.com/ZKsQB.png

XIB changes: Add a rounded rect button hooked up to |loadAllPlugins:| in the File's Owner and referenced by its |loadAllPluginsButton_| outlet, wrapped in a GTMWidthBasedTweaker.

BUG=49677
TEST=ContentSettingBubbleModelTest.*

Review URL: http://codereview.chromium.org/3015036
------------------------------------------------------------------------
r54719 | bauerb@chromium.org | 2010-08-03 10:18:24 +0200 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/blocked_plugin.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Replace ViewHostMsg_GetPluginPath with ViewHostMsg_GetPluginInfo.

This enables the renderer to get more information about a plugin than just the path.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3015029
------------------------------------------------------------------------
r54716 | mnissler@chromium.org | 2010-08-03 09:58:19 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/browser_child_process_host.cc
   M /trunk/src/chrome/browser/browser_main.cc

[linux] Hook up crash reporter initialization with configuration management.

BUG=49662
TEST=Enable/Disable metrics reporting through policy and check whether the crash reporter respects that.

Review URL: http://codereview.chromium.org/3084008
------------------------------------------------------------------------
r54713 | johnnyg@chromium.org | 2010-08-03 09:04:07 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Shutdown the notification UI manager before the notifications service, as the former's shutdown logic depends on the latter.

BUG=50553
TEST=see bug

Review URL: http://codereview.chromium.org/3051029
------------------------------------------------------------------------
r54705 | zork@chromium.org | 2010-08-03 07:05:16 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_input_method_library.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Don't launch the IME on the login screen unless needed.

BUG=chromium-os:4460
TEST=Boot chromium os.  Switch to a virtual console.  Run "ps aux | grep ibus" and check that ibus is not running.  Switch back to the login screen.  Switch the input method to Dvorak.  Check that Dvorak works.  Reboot.  Check that the input method is dvorak.

Review URL: http://codereview.chromium.org/2806083
------------------------------------------------------------------------
r54703 | satorux@chromium.org | 2010-08-03 06:56:06 +0200 (Tue, 03 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_mozc_options.html

Add missing "number of suggestions" configuration item in Mozc DOMUI
I forgot to include this item in the previous CL.
Use type=number rather than touch-slider (used in original UI) for number of suggestions.
Also clean up some of ARRAYSIZE_UNSAFE() usages in language_preferences.h.

TEST=manually check on the netbook by uncommenting TODO lines in options.html.
BUG=chromium-os:4809

Review URL: http://codereview.chromium.org/3020054
Patch from Takayoshi Kochi <kochi@chromium.org>.
------------------------------------------------------------------------
r54696 | tfarina@chromium.org | 2010-08-03 05:00:50 +0200 (Tue, 03 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/app/gtk_util.cc
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/base_paths_posix.cc
   D /trunk/src/base/env_var.cc
   D /trunk/src/base/env_var.h
   D /trunk/src/base/env_var_unittest.cc
   A /trunk/src/base/environment.cc (from /trunk/src/base/env_var.cc:54694)
   A /trunk/src/base/environment.h (from /trunk/src/base/env_var.h:54694)
   A /trunk/src/base/environment_unittest.cc (from /trunk/src/base/env_var_unittest.cc:54694)
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/base/nss_util.cc
   M /trunk/src/base/xdg_util.cc
   M /trunk/src/base/xdg_util.h
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gconf_titlebar_listener.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/chrome_paths_linux.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/common/process_watcher_win.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/startup/shutdown_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/courgette/encoded_program.cc
   M /trunk/src/media/audio/audio_input_controller_unittest.cc
   M /trunk/src/media/audio/audio_output_controller_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/remoting/host/simple_host_process.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

base: Rename EnvVarGetter to Environment.

Now EnvVarGetter do much more than getting environment variables.

Per suggestion from Pawel in http://codereview.chromium.org/3043018/.

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3052034
------------------------------------------------------------------------
r54694 | pkasting@chromium.org | 2010-08-03 04:49:34 +0200 (Tue, 03 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Fix two bugs caused by scheme stripping:
* We no longer detected that the user was dragging the permanent_text_, and thus that we could give the drag a title and favicon.
* We no longer scored hitting enter on the URL as a RELOAD.

BUG=47555
TEST=Visit www.google.com.  Drag the omnibox text to the desktop.  The shortcut should have a title and favicon.
Review URL: http://codereview.chromium.org/3030039
------------------------------------------------------------------------
r54691 | pkasting@chromium.org | 2010-08-03 04:13:56 +0200 (Tue, 03 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Revert 54643 - Fix --kiosk to work regardless of the startup pref setting or supplied URLs. 

This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive().  This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message.

BUG=none 
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/2847090

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3017052
------------------------------------------------------------------------
r54673 | sargrass@google.com | 2010-08-03 03:34:59 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.h
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js

Implement import data overlay

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3029044
------------------------------------------------------------------------
r54659 | estade@chromium.org | 2010-08-03 03:11:44 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

[GTK] compile fix, try2

TBR=pkasting, ncarter
TEST=compile

Review URL: http://codereview.chromium.org/3060037
------------------------------------------------------------------------
r54656 | estade@chromium.org | 2010-08-03 03:06:46 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

[GTK] Remove reference to obsolete constant.

TBR=ncarter
TEST=compile; also autocomplete popup text aligns with omnibox text

Review URL: http://codereview.chromium.org/3053036
------------------------------------------------------------------------
r54653 | tim@chromium.org | 2010-08-03 02:59:03 +0200 (Tue, 03 Aug 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/resources/setup_done.html

UI changes to sync dialogs to improve formatting and font sizes.

All resource files
_ Made text unselectable on all 3 screens
_ Change the default font size to 11pt and 1.8em line height spacing

gaia_login
_ Introduction paragraph is now using 11pt font and new spaced line height
_ Moved the cancel button into the GAIA login box.
_ Error message
> Made permanent space for the error msg between intro paragraph and GAIA login
> Error message now as the same orange background as on choosedatatypes
> Error shows on Captcha view if there's an error

setup_done
_ Got rid of the tables
_ Header is now the right size
_ Synced to user@gmail.com is now bold

BUG=49704

Original patch by dudley@chromium.org
Original review: http://codereview.chromium.org/3085003

Review URL: http://codereview.chromium.org/2856081
------------------------------------------------------------------------
r54652 | vangelis@chromium.org | 2010-08-03 02:58:37 +0200 (Tue, 03 Aug 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Pass value of enable-accelerated-compositing runtime flag down to the renderer.
BUG=50994
TEST=None
Review URL: http://codereview.chromium.org/3058031
------------------------------------------------------------------------
r54649 | pkasting@chromium.org | 2010-08-03 02:54:54 +0200 (Tue, 03 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc

Fix a number of problems caused by the AutocompleteController purposefully committing out-of-date results after the edit had changed.  Simply not doing this commit would make the popup appear less responsive, so instead we're more careful to not try and update the edit with the out-of-date data, and instead force the popup to get newer results in cases where it might have been out-of-date.

BUG=46315
TEST=Type a letter that inline autocompletes, then immediately hit ctrl-a.  You should get everything selected, not nothing.  Also, typing a letter that inline autocompletes, then immediately a random other letter and the down arrow key, should show a popup with results for the two letters you typed, not just the first.
Review URL: http://codereview.chromium.org/3047041
------------------------------------------------------------------------
r54648 | estade@chromium.org | 2010-08-03 02:54:31 +0200 (Tue, 03 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

[GTK] fix up spacing in upper chrome.

These changes mirror pkasting's work on windows for milestone6.

TODO (in a follow up patch): convert the wrench menu into a CustomDrawButton (you will notice that currently it is too wide and has the wrong sort of background hover appearance).

BUG=50682
TEST=look of upper chrome

Review URL: http://codereview.chromium.org/3007018
------------------------------------------------------------------------
r54645 | pkasting@chromium.org | 2010-08-03 02:52:10 +0200 (Tue, 03 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win_unittest.cc

When picking a filename to save, check whether the user's extension is registered on the system at all, rather than checking whether it has a known MIME type.  Many known extensions have no MIME type.

BUG=7499
TEST=Save a text file as "foo.reg" and ensure it doesn't get ".txt" appended.
Review URL: http://codereview.chromium.org/3050031
------------------------------------------------------------------------
r54643 | pkasting@chromium.org | 2010-08-03 02:51:49 +0200 (Tue, 03 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix --kiosk to work regardless of the startup pref setting or supplied URLs. 

This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive().  This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message.

BUG=none 
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/2847090
------------------------------------------------------------------------
r54634 | tfarina@chromium.org | 2010-08-03 01:35:58 +0200 (Tue, 03 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Use the blue style for the save password info bar.

BUG=47233
TEST=go to mail.google.com, log in, wait until the info bar appears, see if the
info bar has a blue background.

Review URL: http://codereview.chromium.org/3080016
------------------------------------------------------------------------
r54633 | chron@chromium.org | 2010-08-03 01:35:20 +0200 (Tue, 03 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Fix for RenewAuthToken crash. Extend life of AuthWatcher.
TEST=Open and close browser repeatedly.
BUG=50955

Review URL: http://codereview.chromium.org/3034045
------------------------------------------------------------------------
r54629 | ananta@chromium.org | 2010-08-03 01:13:12 +0200 (Tue, 03 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc

Fixes a crash seen on chrome frame reliability test runs. We need to validate the iterator from the render view map
in the SetCookies IPC as well as the render view could be in the process of being deleted

Fixes bug http://code.google.com/p/chromium/issues/detail?id=50966

Bug=50966
TBR=amit

Review URL: http://codereview.chromium.org/3050030
------------------------------------------------------------------------
r54628 | asargent@chromium.org | 2010-08-03 01:13:04 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc

Make sure we fully remove child context menu items when deleting a parent.

BUG=49742
TEST=Follow steps in the bug report

Review URL: http://codereview.chromium.org/3081009
------------------------------------------------------------------------
r54625 | thakis@chromium.org | 2010-08-03 00:56:40 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win_unittest.cc

Win: Don't give some downloads duplicate extensions like .arj.arj

BUG=49621
TEST=See bug. Also unittests.

Review URL: http://codereview.chromium.org/3069018
------------------------------------------------------------------------
r54624 | erikkay@chromium.org | 2010-08-03 00:56:38 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc

enable apps by default

BUG=none
TEST=run Chrome with no command line flags, apps should be enabled

Review URL: http://codereview.chromium.org/3015043
------------------------------------------------------------------------
r54622 | mpcomplete@chromium.org | 2010-08-03 00:20:36 +0200 (Tue, 03 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

Return an error code to extensions requesting a resource that requires basic
HTTP authentication.

BUG=31388
TEST=test that basic HTTP authentication still works

Review URL: http://codereview.chromium.org/2824063
------------------------------------------------------------------------
r54619 | inferno@chromium.org | 2010-08-03 00:17:23 +0200 (Tue, 03 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc

Fix wrong use of substr in autofill fix for bug 49172

BUG=49172
TEST=None

Review URL: http://codereview.chromium.org/3035046
------------------------------------------------------------------------
r54613 | eroman@chromium.org | 2010-08-02 23:49:40 +0200 (Mon, 02 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_server.cc
   M /trunk/src/net/proxy/proxy_server.h
   M /trunk/src/net/proxy/proxy_server_mac.cc

Address a TODO: use HostPortPair rather than a naked host string.

Review URL: http://codereview.chromium.org/3047033
------------------------------------------------------------------------
r54612 | chaitanyag@chromium.org | 2010-08-02 23:44:53 +0200 (Mon, 02 Aug 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   A /trunk/src/chrome/browser/chromeos/cros/cros_mock.cc
   A /trunk/src/chrome/browser/chromeos/cros/cros_mock.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/network_state_notifier_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Refactor cros_in_process_browser_test to separate the mock initialization.
Review URL: http://codereview.chromium.org/3012017
------------------------------------------------------------------------
r54610 | sky@chromium.org | 2010-08-02 23:43:47 +0200 (Mon, 02 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc

Fixes bug where border highlight was drawn wrong for
increment/decrement button in wrench menu.

BUG=50959
TEST=see bug

Review URL: http://codereview.chromium.org/3056039
------------------------------------------------------------------------
r54607 | pkasting@chromium.org | 2010-08-02 23:33:40 +0200 (Mon, 02 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

When dropping a tab torn from a maximized window, inherit the restored size and maximized state, instead of creating a restored window at the maximized size.

BUG=22154
TEST=Drag a tab from a maximized window and drop it; it should create a maximized window.
Review URL: http://codereview.chromium.org/3032039
------------------------------------------------------------------------
r54602 | davidben@chromium.org | 2010-08-02 23:26:11 +0200 (Mon, 02 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.h
   M /trunk/src/net/base/x509_cert_types.cc
   M /trunk/src/net/base/x509_cert_types.h

Display an infobar after enrolling a client certificate

This gives the user some feedback that we added a certificate.

R=wtc,brettw
TEST=none
BUG=50782

Review URL: http://codereview.chromium.org/2815023
------------------------------------------------------------------------
r54593 | ananta@chromium.org | 2010-08-02 22:21:42 +0200 (Mon, 02 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h

Fixes a crash seen on chrome frame reliability test runs. The crash occurs while servicing the GetCookies IPC from the renderer
and routing it over the automation channel to the host. It looks like the render view is in the process of being deleted and thus
it does not exist in the render view map.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=50966

Bug=50966

Review URL: http://codereview.chromium.org/2878067
------------------------------------------------------------------------
r54590 | stuartmorgan@chromium.org | 2010-08-02 21:58:29 +0200 (Mon, 02 Aug 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/resources/options/personal_options.css
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options.html

DOMUI prefs: Remove use of tables for layout in Personal pane

In addition clean up the JS for showing/hiding sections of controls so that it's class-based rather than manipulating raw styles.

Also fixes registration order of the top-level prefs (where order matter).

BUG=None
TEST=DOMUI Personal prefs still display and work correctly.

Review URL: http://codereview.chromium.org/3037030
------------------------------------------------------------------------
r54588 | davidben@chromium.org | 2010-08-02 21:51:31 +0200 (Mon, 02 Aug 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/ssl_client_certificate_selector.mm

Don't leak memory when displaying a SFChooseIdentityPanel

SFChooseIdentityPanel has rather non-standard (buggy) referencing semantics as
compared to other sheets. In particular, it fails to take a reference to itself
while open. It also takes a reference to its delegate, introducing a
reference cycle in our implementation.

This removes the panel reference in the delegate, in light of the second
behavior, and works around problems caused by the first with an autorelease.

Also avoids an indexing error in release mode should a DCHECK fail.

R=wtc,mark
BUG=none
TEST=displaying certificate selections still work in OS X

Review URL: http://codereview.chromium.org/3044036
------------------------------------------------------------------------
r54587 | pkasting@chromium.org | 2010-08-02 21:47:40 +0200 (Mon, 02 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Remove some code that seems unnecessary now that the distributor logo is dead.

BUG=none
TEST=Window frame still looks OK after switching themes or resizing
Review URL: http://codereview.chromium.org/3053025
------------------------------------------------------------------------
r54582 | dhollowa@chromium.org | 2010-08-02 21:23:37 +0200 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card.cc

AutoFill Credit Card matching for Diners Club incorrect

Changes matching logic for Diner's club card.

BUG=50976
TEST=none

Review URL: http://codereview.chromium.org/3061043
------------------------------------------------------------------------
r54581 | sky@chromium.org | 2010-08-02 21:18:23 +0200 (Mon, 02 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Fixes bug where toggling side tabs wouldn't do a Layout. This was a
result of recent changes to View::Layout

BUG=chromium-os:4637
TEST=see bug

Review URL: http://codereview.chromium.org/3056017
------------------------------------------------------------------------
r54575 | pathorn@chromium.org | 2010-08-02 21:05:55 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc

Unlink SingletonLock and SingletonSocket to allow for reusing profile directory between tests.

BUG=50454
TEST=Run ui_tests --user-data-dir=/tmp/foo

Review URL: http://codereview.chromium.org/3053020
------------------------------------------------------------------------
r54567 | cbentzel@chromium.org | 2010-08-02 20:37:41 +0200 (Mon, 02 Aug 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js

Modify display of time in net-internals to be more human
readable.

The right pane on the Requests tab now displays the local
time the selected request was started at the top of each log
page.  The time, in milliseconds, of each event relative
to the source's first event is displayed in a new "[st=#]"
column.

In the Data tab, after pressing dump to text, request
entries also display the information mentioned above.
Also, the local time is displayed in human readable format
for each "Host resolver cache" entry.

Note that just updating the two modified files may not result
in the pak file they're merged into being rebuilt. On Linux,
touching chrome/browser/resources/net_internals/index.html
seems to do the trick.  On Windows, just forcing
chrome_extra_resources to be rebuilt manually works as well.

BUG=41799
TEST=Go to the aforementioned tabs on about:net-internals
  and confirm the time is displayed.

Review URL: http://codereview.chromium.org/2868079
------------------------------------------------------------------------
r54566 | xiyuan@chromium.org | 2010-08-02 20:36:22 +0200 (Mon, 02 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/mock_cros_settings.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options_page.css
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js

Revert "Revert 53989 - Implement new mock for user options page per chromium-os:5028"

This reverts commit r54128.

TBR=dhg@chromium.org
BUG=chromium-os:5028
TEST=erify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only.

Review URL: http://codereview.chromium.org/3071013
------------------------------------------------------------------------
r54565 | nick@chromium.org | 2010-08-02 20:24:53 +0200 (Mon, 02 Aug 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h

Revert 54560 - 
Change removing method, GetBrowser from TabContentsDelegate, as this was breaking an abstraction layer.  This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances.

I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2941001

TBR=twiz@google.com
Review URL: http://codereview.chromium.org/3012042
------------------------------------------------------------------------
r54563 | glotov@chromium.org | 2010-08-02 20:02:39 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc

Initial locale is used if current locale is not handled by manifest.

BUG=chromium:3178
TEST=none

Review URL: http://codereview.chromium.org/3036034
------------------------------------------------------------------------
r54562 | tommi@chromium.org | 2010-08-02 19:59:39 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/test/automation/automation_messages.h

Add referrer to the NavigationInfo struct.

TEST=n/a
BUG=none

Review URL: http://codereview.chromium.org/3036030
------------------------------------------------------------------------
r54560 | twiz@google.com | 2010-08-02 19:56:11 +0200 (Mon, 02 Aug 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h


Change removing method, GetBrowser from TabContentsDelegate, as this was breaking an abstraction layer.  This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances.

I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2941001
------------------------------------------------------------------------
r54554 | stevenjb@chromium.org | 2010-08-02 19:24:02 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc

Issue 4072: App panels don't look right on Chromium OS

BUG=chromeos:4072 http://code.google.com/p/chromium-os/issues/detail?id=4072
TEST=See issue.

Review URL: http://codereview.chromium.org/2819076
------------------------------------------------------------------------
r54552 | alyssad@chromium.org | 2010-08-02 19:05:19 +0200 (Mon, 02 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/functional/autofill.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Fix pyauto AutoFill hook/test based on new CC functionality.

With this CL: http://codereview.chromium.org/3010041 credit cards were changed so that the type is determined based upon the number. Fixing the pyauto test to pass with new functionality.

Review URL: http://codereview.chromium.org/3084004
------------------------------------------------------------------------
r54551 | evan@chromium.org | 2010-08-02 19:00:15 +0200 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Fix test for valid UTF-16 input.

I got this wrong initially; Ningxin wrote a patch to fix it, which
agl then also got wrong.  So I am relanding Ningxin's original patch.

Patch by Ningxin Hu <ningxin.hu@intel.com>.

Review URL: http://codereview.chromium.org/3029048
------------------------------------------------------------------------
r54549 | cbentzel@chromium.org | 2010-08-02 18:50:35 +0200 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connection_tester_unittest.cc

DISABLE ConnectionTesterTest.RunAllTests

Mac Valgrind bot is consistently complaining a pure virtual method being called. The root cause is not obvious (i.e. calling directly in a constructor/destructor).

BUG=50950
TBR=eroman

Review URL: http://codereview.chromium.org/3087002
------------------------------------------------------------------------
r54545 | finnur@chromium.org | 2010-08-02 18:41:59 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

Coverity 12013: Uninitialized member in LocationBarView

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3018028
------------------------------------------------------------------------
r54543 | alyssad@chromium.org | 2010-08-02 18:39:12 +0200 (Mon, 02 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New pyauto translate hook: wait until translation complete.

This hook allows tests to wait until translation has been completed after visiting a page that should be automatically translated.

Review URL: http://codereview.chromium.org/3074014
------------------------------------------------------------------------
r54542 | avayvod@chromium.org | 2010-08-02 18:34:58 +0200 (Mon, 02 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc

Pass background to WizardController after new user login. This fixes SEGFAULT after new user login.

BUG=chromium-os:5250
TEST=Login as new user and verify that Chrome doesn't crash and camera screen is shown.
TBR=dpolukhin

Review URL: http://codereview.chromium.org/3010044
------------------------------------------------------------------------
r54541 | ziadh@chromium.org | 2010-08-02 18:34:26 +0200 (Mon, 02 Aug 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h

A/B test for measuring effect of number of proxy connections.

Currently, we limit the number of connections per proxy server to 32 (raised
from 15). Firefox uses 8. A low value keeps from overloading the proxy servers;
at the same time, some users may hit the limit (since we use the same number
for both HTTP and SOCKS proxies). This experiment selects a different number at
browser launch (from the set [8, 16, 32, 64]), and attempts to look at certain
stats to get a clearer picture of how this affects the user.

BUG=44501
r=jar


Review URL: http://codereview.chromium.org/3033045
------------------------------------------------------------------------
r54539 | cmasone@google.com | 2010-08-02 18:33:33 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Replace obsolete kProfile switch with kLoginProfile

BUG=50866
TEST=it compiles

Review URL: http://codereview.chromium.org/3013050
------------------------------------------------------------------------
r54534 | glotov@chromium.org | 2010-08-02 14:32:18 +0200 (Mon, 02 Aug 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/customization_document.cc
   M /trunk/src/chrome/browser/chromeos/customization_document.h
   M /trunk/src/chrome/browser/chromeos/customization_document_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h

OEM EULA extracted correctly from manifest.
Fixing CustomizationDocument to return full path to the pages being queried.

BUG=chromium:3178
TEST=none

Review URL: http://codereview.chromium.org/3052030
------------------------------------------------------------------------
r54532 | mnissler@chromium.org | 2010-08-02 14:20:40 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_mac.mm
   M /trunk/src/chrome/browser/browser_child_process_host.cc

[MAC] Disable crash reporting if configuration management says so.

BUG=49662
TEST=Configure MetricsReportingEnabled policy, crash browser/renderer and check whether crash dumps get generated.

Review URL: http://codereview.chromium.org/2832090
------------------------------------------------------------------------
r54525 | mnissler@chromium.org | 2010-08-02 11:59:40 +0200 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   A /trunk/src/chrome/common/policy_constants.cc
   A /trunk/src/chrome/common/policy_constants.h
   M /trunk/src/chrome/common_constants.gypi

Don't initialize the crash reporter on windows if disabled by configuration management.

BUG=49662
TEST=No crash reports get submitted if policy doesn't allow it.

Review URL: http://codereview.chromium.org/3033030
------------------------------------------------------------------------
r54516 | tim@chromium.org | 2010-08-02 08:12:00 +0200 (Mon, 02 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc

Stopgap fix for bug 48502.  Stop syncing on db corruption.

BUG=48502

Review URL: http://codereview.chromium.org/3075015
------------------------------------------------------------------------
r54515 | akalin@chromium.org | 2010-08-02 07:49:35 +0200 (Mon, 02 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/DEPS
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h

Revert 53799 - Made CacheInvalidationPacketHandler aware of XmppClient state changes.

Reverting this as it caused more problems than it solved (see 50511).

This is a speculative/defensive fix for bug 49274.

BUG=49274
TEST=manual (checked that this didn't break normal behavior)

Review URL: http://codereview.chromium.org/3054018

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/2819084
------------------------------------------------------------------------
r54514 | asargent@chromium.org | 2010-08-02 06:08:07 +0200 (Mon, 02 Aug 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   A /trunk/src/chrome/browser/extensions/extension_test_message_listener.cc
   A /trunk/src/chrome/browser/extensions/extension_test_message_listener.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/context_menus/long_title
   A /trunk/src/chrome/test/data/extensions/context_menus/long_title/background.html
   A /trunk/src/chrome/test/data/extensions/context_menus/long_title/manifest.json
   A /trunk/src/chrome/test/data/extensions/context_menus/long_title/test.js
   M /trunk/src/chrome/test/data/extensions/context_menus/patterns/test.js
   M /trunk/src/chrome/test/data/extensions/context_menus/simple/test.js

Set a max limit on extension items' labels in context menus.

Also do some cleanup of context menu tests, including adding a generic
mechanism to let javascript pass a test message and have C++ test code wait
for and retrieve those messages.

BUG=49744
TEST=Follow steps in bug report

Review URL: http://codereview.chromium.org/3017047
------------------------------------------------------------------------
r54490 | sanjeevr@chromium.org | 2010-08-01 06:32:58 +0200 (Sun, 01 Aug 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_updater.cc

Re-enabled internal PDF on trunk
BUG=None
TEST=Internal PDF plugin should be enabled by default

Review URL: http://codereview.chromium.org/3080014
------------------------------------------------------------------------
r54486 | tfarina@chromium.org | 2010-08-01 03:50:55 +0200 (Sun, 01 Aug 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h

gtk: Fix presubmit errors.

chrome/browser/gtk/gtk_chrome_button.h:21:  Extra space before ( in function
call  [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_button.h:23:  Extra space before ( in function
call  [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_button.h:25:  Extra space before ( in function
call  [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_link_button.h:27:  Extra space before ( in
function call  [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_link_button.h:29:  Extra space before ( in
function call  [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_link_button.h:31:  Extra space before ( in
function call  [whitespace/parens] [4]

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3064027
------------------------------------------------------------------------
r54485 | gavinp@google.com | 2010-08-01 03:02:57 +0200 (Sun, 01 Aug 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Make prefetching default to disabled

My earlier CL jumped the gun a bit; prefetching isn't ready to be the default,
so this CL reverses that.  Now you have to explicitly turn prefetching on to have it.

Note that prefetching was never enabled in trunk: because I haven't yet flipped the
build default for webkit to include prefetching, the command line flag had no effect
on trunk chrome.

BUG=none
TEST=chrome --enable-prefetch http://gemal.dk/browserspy/prefetch.php

Review URL: http://codereview.chromium.org/2847093
------------------------------------------------------------------------
r54484 | tfarina@chromium.org | 2010-08-01 02:36:10 +0200 (Sun, 01 Aug 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification.cc
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification_factory.cc
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/notification.h
   M /trunk/src/chrome/browser/notifications/notification_options_menu_model.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc

notifications: Convert some std::wstring over to string16.

BUG=43899
TEST=compiles, trybots.

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3010028
------------------------------------------------------------------------
r54477 | nsylvain@chromium.org | 2010-08-01 00:58:11 +0200 (Sun, 01 Aug 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Oops, Use the right variable to determine if linux is using breakpad

Review URL: http://codereview.chromium.org/3074020
------------------------------------------------------------------------
r54471 | nsylvain@chromium.org | 2010-07-31 22:38:56 +0200 (Sat, 31 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc

Disable mutliple tests that never worked.

bug:50864
TBR:dtseng
Review URL: http://codereview.chromium.org/2808084
------------------------------------------------------------------------
r54465 | nsylvain@chromium.org | 2010-07-31 21:51:54 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Fix CrossSiteAfterCrash for official builds.

We need to set expected_crashes_ when breakpad is set, because it
does generate a crash dump, even on Linux.

Review URL: http://codereview.chromium.org/3034042
------------------------------------------------------------------------
r54463 | jochen@chromium.org | 2010-07-31 21:17:42 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm

Also fix mac unit tests

BUG=none
TEST=unit_tests

Review URL: http://codereview.chromium.org/2873086
------------------------------------------------------------------------
r54462 | jochen@chromium.org | 2010-07-31 20:58:21 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc

Fix unit test.

BUG=none
TEST=unit_tests

Review URL: http://codereview.chromium.org/3035044
------------------------------------------------------------------------
r54461 | jochen@chromium.org | 2010-07-31 20:44:40 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Flip the default for the cookie prompt to disabled.

BUG=50083
TEST=none

Review URL: http://codereview.chromium.org/3030033
------------------------------------------------------------------------
r54456 | brettw@chromium.org | 2010-07-31 19:47:09 +0200 (Sat, 31 Jul 2010) | 19 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/native_library_linux.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/utf_string_conversions.cc
   M /trunk/src/base/utf_string_conversions.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/view_http_cache_job_factory.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/installer/util/version.cc
   M /trunk/src/net/base/cookie_store.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/transport_security_state.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_ls.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_netware.cc
   M /trunk/src/net/http/http_auth_controller.cc
   M /trunk/src/net/http/http_auth_filter.h
   M /trunk/src/net/http/http_auth_filter_win.h
   M /trunk/src/net/http/http_auth_handler_negotiate.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/spdy/spdy_session.cc
   A /trunk/src/net/url_request/url_request_context.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/net/websockets/websocket_job_unittest.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc

Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found it
weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in
string_util.h. This should help some dependencies since string_util changes
much more frequently than utf_string_conversions and fewer files will now need
string_utils.

Since this requires a lot of changes, this keeps a forward-declaration in
string_util so I can update the entire project incrementally. This change
updates base and net only.

I removed some includes of string_util from header files in net. In particular,
url_request_context which involved creating a new .cc file to implement a
function (already virtual so there's no speed penalty). It turns out a lot of
files were getting string_util from this include, so I had to update a bunch of
random files to now explicitly include string_util.h

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3076013
------------------------------------------------------------------------
r54455 | brettw@chromium.org | 2010-07-31 19:47:05 +0200 (Sat, 31 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Fix compile errors from moving number conversions to their own file.

TEST=none
BUG=none
------------------------------------------------------------------------
r54454 | brettw@chromium.org | 2010-07-31 19:29:25 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/gtk_util.cc
   M /trunk/src/base/string_number_conversions.cc
   M /trunk/src/base/string_number_conversions.h
   M /trunk/src/base/sys_info_chromeos.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_field.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/select_control_handler.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_posix.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/customization_document.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/profile_impl.cc
   M /trunk/src/chrome/browser/profile_import_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/util/crypto_helpers.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/wrench_menu.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/json_pref_store_unittest.cc
   M /trunk/src/chrome/installer/util/compat_checks.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/version.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/dom_automation_browsertest.cc
   M /trunk/src/chrome/test/automation/extension_proxy.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/startup/shutdown_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   M /trunk/src/chrome_frame/test/test_with_web_server.h
   M /trunk/src/courgette/adjustment_method.cc
   M /trunk/src/courgette/courgette_tool.cc
   M /trunk/src/gfx/window_impl.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
   M /trunk/src/gpu/command_buffer/service/program_manager_unittest.cc
   M /trunk/src/media/filters/ffmpeg_video_decode_engine.cc
   M /trunk/src/media/tools/media_bench/media_bench.cc
   M /trunk/src/media/tools/omx_test/omx_test.cc
   M /trunk/src/media/tools/scaler_bench/scaler_bench.cc
   M /trunk/src/media/tools/wav_ola_test/wav_ola_test.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/transport_security_state.cc
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/ftp/ftp_ctrl_response_buffer.cc
   M /trunk/src/net/ftp/ftp_directory_listing_buffer_unittest.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_ls.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_mlsd.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_netware.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_vms.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parser_windows.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_util.cc
   M /trunk/src/net/http/http_chunked_decoder.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_response_headers.cc
   M /trunk/src/net/http/http_util.cc
   M /trunk/src/net/proxy/proxy_bypass_rules.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/server/http_listen_socket.cc
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/spdy/spdy_http_stream.cc
   M /trunk/src/net/spdy/spdy_test_util.cc
   M /trunk/src/net/test/test_server.h
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/websockets/websocket_throttle.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/printing/page_overlays.cc
   M /trunk/src/views/controls/table/table_view_unittest.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_geturl_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_test.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/listener_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Convert more callers of the integer/string functions to using
string_number_conversions.h

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3013046
------------------------------------------------------------------------
r54451 | tfarina@chromium.org | 2010-07-31 18:55:40 +0200 (Sat, 31 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/env_var.cc
   M /trunk/src/base/env_var.h
   M /trunk/src/base/env_var_unittest.cc
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

Reland r54418 - base: Add UnSetEnv function to EnvVarGetter API.

This reverts commit 7ed083f6d2b1b0a09c8bf9470386ba3e38f2feed.

It was reverted due to crbug.com/50663 started failing when I land this patch,
so I'm relanding it now again.

BUG=None
TEST=trybots

TBR=thestig@chromium.org

Review URL: http://codereview.chromium.org/3043018

Review URL: http://codereview.chromium.org/3076020
------------------------------------------------------------------------
r54450 | tfarina@chromium.org | 2010-07-31 17:33:32 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_container.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.h
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/common/dom_storage_common.h
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h
   M /trunk/src/chrome/renderer/webmediaplayer_impl.h
   M /trunk/src/chrome/renderer/websharedworkerrepository_impl.h
   M /trunk/src/chrome/test/menu_model_test.h

Fix bad license header under chrome/ directory.

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/2847091
------------------------------------------------------------------------
r54449 | cbentzel@chromium.org | 2010-07-31 17:24:14 +0200 (Sat, 31 Jul 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_tracker.cc
   M /trunk/src/net/url_request/url_request_job_tracker.h
   D /trunk/src/net/url_request/url_request_job_tracker_unittest.cc

Revert 54448 - Add the actual data being read to the OnBytesRead callback, take two.

I'm not convinced that this actually introduced any problems (as compared to being bitten by flakiness), but I'll spend more time investigating on a weekday.

This change was originally committed as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53178
then rolled back as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53416
due to a breakage in FLAKY_UnknownSize download test.
FLAKY_UnknownSize depended on code with a bug that was exposed by this change. That bug has since been fixed and committed as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53876

So this change is ready for another round of review. It has not changed at all since being committed.

Contributed by: bmcquade@google.com

BUG=48192
TEST=Added new unit tests, ran net_unittests.

Review URL: http://codereview.chromium.org/3010037

TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3047037
------------------------------------------------------------------------
r54448 | cbentzel@chromium.org | 2010-07-31 14:13:14 +0200 (Sat, 31 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_tracker.cc
   M /trunk/src/net/url_request/url_request_job_tracker.h
   A /trunk/src/net/url_request/url_request_job_tracker_unittest.cc

Add the actual data being read to the OnBytesRead callback, take two.

This change was originally committed as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53178
then rolled back as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53416
due to a breakage in FLAKY_UnknownSize download test.
FLAKY_UnknownSize depended on code with a bug that was exposed by this change. That bug has since been fixed and committed as
http://src.chromium.org/viewvc/chrome?view=rev&revision=53876

So this change is ready for another round of review. It has not changed at all since being committed.

Contributed by: bmcquade@google.com

BUG=48192
TEST=Added new unit tests, ran net_unittests.

Review URL: http://codereview.chromium.org/3010037
------------------------------------------------------------------------
r54439 | thestig@chromium.org | 2010-07-31 09:42:28 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc

Another quick CrOS fix.

BUG=none
TEST=none
TBR=vtl
Review URL: http://codereview.chromium.org/3073015
------------------------------------------------------------------------
r54438 | thestig@chromium.org | 2010-07-31 09:35:07 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_util.h
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/volume_bubble_view.cc

Fix CrOS build.

BUG=none
TEST=CrOS bot goes green?
TBR=vtl
Review URL: http://codereview.chromium.org/3084006
------------------------------------------------------------------------
r54437 | thestig@chromium.org | 2010-07-31 09:11:47 +0200 (Sat, 31 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_win.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/appcache_info_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/infobars/after_translate_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/after_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/infobar_button_border.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/printing/printed_document_win.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/listbox/native_listbox_win.cc
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/progress_bar_unittest.cc
   M /trunk/src/views/controls/scroll_view.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/widget/tooltip_manager_win.cc
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_win.cc

Cleanup: Remove unneeded headers from app/ (part 2)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3066014
------------------------------------------------------------------------
r54436 | thestig@chromium.org | 2010-07-31 09:11:36 +0200 (Sat, 31 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/app/l10n_util_mac.h
   M /trunk/src/app/l10n_util_mac.mm
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc
   M /trunk/src/chrome/browser/chromeos/login/password_changed_view.h
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.h
   M /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/chromeos/volume_bubble.h
   M /trunk/src/chrome/browser/chromeos/volume_bubble_view.cc
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/collected_cookies_mac.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm
   M /trunk/src/chrome/browser/cocoa/install_from_dmg.mm
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm
   M /trunk/src/chrome/browser/cocoa/restart_browser.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/ui_localizer.mm
   M /trunk/src/chrome/browser/cocoa/web_contents_drag_source.h
   M /trunk/src/chrome/browser/cocoa/web_drag_source.h
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/gtk/update_recommended_dialog.cc
   M /trunk/src/chrome/browser/platform_util_chromeos.cc

Cleanup: Remove unneeded headers from app/ (part 3)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3054029
------------------------------------------------------------------------
r54423 | ziadh@chromium.org | 2010-07-31 04:30:14 +0200 (Sat, 31 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Revert 54411 - Reduce magnitude of non-default group probabilities for 2 A/B tests

I reduced the non-default group probabilities for "ConnCountImpact" and "IdleSktToImpact" by an order of magnitude from [20%, 25%] to [2%, 2.5%] respectively.

BUG=50802
r=jar

Review URL: http://codereview.chromium.org/3056037

TBR=ziadh@chromium.org
Review URL: http://codereview.chromium.org/2806099
------------------------------------------------------------------------
r54422 | tfarina@chromium.org | 2010-07-31 04:26:40 +0200 (Sat, 31 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/env_var.cc
   M /trunk/src/base/env_var.h
   M /trunk/src/base/env_var_unittest.cc
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

Revert 54418 - base: Add UnSetEnv function to EnvVarGetter API.

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.UnSetEnvVar

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3043018

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2847092
------------------------------------------------------------------------
r54421 | gavinp@google.com | 2010-07-31 03:30:03 +0200 (Sat, 31 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/test/functional/prefetch.py
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/request_priority.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_test_util.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_type.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Implement prefetching in chrome

With this CL (see also issue 2910009), chrome will support basic
prefetching.  You can optionally deactivate prefetching with the
command line argument --disable-prefetch.

A new RequestPriority was created as well, IDLE, which is lower
than LOWEST.  Unfortunately, SPDY has only two bits for priority, so
as a temporary measure (pending SPDY v3 which will have three), we
have a mapping in SPDY that folds net::LOWEST and net::IDLE together.

BUG=13505
TEST=http://gemal.dk/browserspy/prefetch.php

Review URL: http://codereview.chromium.org/3050016
------------------------------------------------------------------------
r54420 | tfarina@chromium.org | 2010-07-31 03:24:44 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/browser/views/infobars/after_translate_infobar.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.h

Fix presubmit errors part 2.

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3064026
------------------------------------------------------------------------
r54418 | tfarina@chromium.org | 2010-07-31 02:48:10 +0200 (Sat, 31 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/env_var.cc
   M /trunk/src/base/env_var.h
   M /trunk/src/base/env_var_unittest.cc
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

base: Add UnSetEnv function to EnvVarGetter API.

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.UnSetEnvVar

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3043018
------------------------------------------------------------------------
r54414 | pathorn@chromium.org | 2010-07-31 02:18:25 +0200 (Sat, 31 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.h

Add back chromeos preferences include in profile.h

BUG=none
TEST=none
TBR=brettw@chromium.org

Review URL: http://codereview.chromium.org/2868090
------------------------------------------------------------------------
r54412 | phajdan.jr@chromium.org | 2010-07-31 01:48:48 +0200 (Sat, 31 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h

Fix BrowserFocusTest crashes caused by a callback being invoked for an invalid pointer.

This depends on http://codereview.chromium.org/2878062/show

TEST=interactive_ui_tests:BrowserFocusTest.*
BUG=50696, 48913

Review URL: http://codereview.chromium.org/3047030
------------------------------------------------------------------------
r54411 | ziadh@chromium.org | 2010-07-31 01:47:44 +0200 (Sat, 31 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Reduce magnitude of non-default group probabilities for 2 A/B tests

I reduced the non-default group probabilities for "ConnCountImpact" and "IdleSktToImpact" by an order of magnitude from [20%, 25%] to [2%, 2.5%] respectively.

BUG=50802
r=jar

Review URL: http://codereview.chromium.org/3056037
------------------------------------------------------------------------
r54410 | shess@chromium.org | 2010-07-31 01:43:00 +0200 (Sat, 31 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm

[Mac] Un-tweak omnibox height and spacing and font.

Partial revert of http://codereview.chromium.org/3046029 .

Toolbar.xib change to make Omnibox 27px tall again.

Omnibox font back to system size, shift baselines to match, inset
location icon additional pixel to look good WRT text spacing, adjust
ev and keyword bubbles to match, adjust popup to match.

BUG=50765, 50575
TEST=See 50765

Review URL: http://codereview.chromium.org/2806098
------------------------------------------------------------------------
r54409 | pathorn@chromium.org | 2010-07-31 01:42:59 +0200 (Sat, 31 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/profile_impl.cc (from /trunk/src/chrome/browser/profile.cc:54405)
   A /trunk/src/chrome/browser/profile_impl.h
   M /trunk/src/chrome/chrome_browser.gypi

Split ProfileImpl out of profile.cc.

This is a relatively trivial change which moves ProfileImpl into a separate file to avoid depending on its implementation. The fact that no code references ProfileImpl implies that it doesn't need to be public anyway.

Does not affect OffTheRecordProfile, since its dependencies are relatively minimal.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2806087
------------------------------------------------------------------------
r54404 | phajdan.jr@chromium.org | 2010-07-31 01:20:32 +0200 (Sat, 31 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc

GTTF: Add more logging to BrowserKeyboardAccessibility test
to help debug hangs and crashes.

Using LOG(ERROR) to make sure the output will be always
visible and captured on Windows. We need the logs. The issue
is hard to reproduce.

TEST=BrowserKeyboardAccessibility
BUG=50663
Review URL: http://codereview.chromium.org/3071011
------------------------------------------------------------------------
r54403 | cbiffle@google.com | 2010-07-31 01:12:43 +0200 (Sat, 31 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_view.cc

Altered the logic that determines when NaCl is enabled.  Previously, we required an explicit command-line flag to use NaCl.  This enables NaCl without a flag for apps and extensions that have the special "native_client" permission.

Note that this causes the NaCl plugin to be registered unconditionally.  We need this, since at the time plugin registration is happening it's not clear whether we're in an extension/app.

BUG=45881
TEST=none yet
Review URL: http://codereview.chromium.org/3057025
------------------------------------------------------------------------
r54402 | darin@chromium.org | 2010-07-31 01:05:15 +0200 (Sat, 31 Jul 2010) | 35 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/platform_file.h
   A /trunk/src/base/scoped_callback_factory.h
   A /trunk/src/chrome/browser/chrome_thread_relay.cc
   A /trunk/src/chrome/browser/chrome_thread_relay.h
   A /trunk/src/chrome/browser/file_system_proxy.cc
   A /trunk/src/chrome/browser/file_system_proxy.h
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.h
   M /trunk/src/chrome/chrome_browser.gypi

Asynchronously open the temp file used for Pepper StreamToFile, and delete the
temp file once we are done with it.

We observe ResourceHandle::OnRequestClosed as a signal of when we should delete
the temp file.  This corresponds to the WebURLLoader being closed (or
canceled).

This patch also includes some helpers:

base/scoped_callback_factory.h
  This class makes it easy to allocate Callbacks that hold a weak reference
  back to the owning class.  It works just like ScopedRunnableMethodFactory
  but for Callbacks instead of RunnableMethods.

base/platform_file.h
  Added a PassPlatformFile class that is useful for cases where a callback may
  decide not to take ownership of a PlatformFile (as can happen when using
  ScopedCallbackFactory).

chrome/file_system_proxy.{h,cc}
  This class provides static methods for executing file system commands on the
  FILE thread.  It routes callbacks back to the originating thread to deliver
  results (file handles, etc.).  Note: this file declares a few functions that
  are not yet used.  I anticipate that we'll make use of these and add more
  functions here to support the Pepper and OWP FileSystem APIs.

chrome/chrome_thread_relay.{h,cc}
  This class is a helper class for proxying calls over to a background
  ChromeThread and then returning results to the originating ChromeThread.

R=brettw
BUG=49789
TEST=(more to be added in third_party/ppapi/tests)

Review URL: http://codereview.chromium.org/2878062
------------------------------------------------------------------------
r54400 | evan@chromium.org | 2010-07-31 00:35:33 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/nacl/broker_thread.cc
   M /trunk/src/net/tools/dump_cache/dump_cache.cc

Remove deprecated CommandLine API.

Cleaned up the final few callers, punting the remaining harder ones
to TODOs.

Review URL: http://codereview.chromium.org/3043033
------------------------------------------------------------------------
r54393 | arv@chromium.org | 2010-07-31 00:04:35 +0200 (Sat, 31 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr.js
   M /trunk/src/chrome/browser/resources/shared/js/cr_test.html

Cr.js: Allow cr.define to export getters and setters.

There was a bug in the export code for exporting properties since it was just doing a simple [[Get]] which breaks cr.doc as well as the option to have singletons created lazily by the getter.

BUG=None
TEST=Options and Bookmarks should still work.

Review URL: http://codereview.chromium.org/3031035
------------------------------------------------------------------------
r54392 | evan@chromium.org | 2010-07-31 00:00:38 +0200 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_unittest.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/support/test_webkit_client.cc
   M /trunk/src/webkit/tools/test_shell/run_all_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Remove some wstrings used in ui_test.cc.

This removes all switch-related wstring APIs from ui_test.cc, and
fixes all the callers.

Review URL: http://codereview.chromium.org/3066026
------------------------------------------------------------------------
r54389 | satish@chromium.org | 2010-07-30 23:52:57 +0200 (Fri, 30 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   A /trunk/src/chrome/browser/speech/enable_speech_input_switch_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/test/data/speech/enable_speech_input_switch_test.html
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1

Flip the compile-time enable switch for speech input to on and add a
command-line switch to put the functionality behind. The command-line
flag will be used both on the Chromium side and in WebKit via
WebRuntimeFeatures.

This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146

BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*

Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54235, but reverted due to tests failure.

Review URL: http://codereview.chromium.org/3064017
------------------------------------------------------------------------
r54387 | thakis@chromium.org | 2010-07-30 23:42:37 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Let task manager columns span entire window immediately.

BUG=32148
TEST=Open task manager. It should immediately look like it did if you opened it and then resized it by 1px previously.

Review URL: http://codereview.chromium.org/3056036
------------------------------------------------------------------------
r54386 | shess@chromium.org | 2010-07-30 23:37:44 +0200 (Fri, 30 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm

[Mac] Give page actions a default image when preview enabled.

During install it is possible to display (or layout) the action before
the images have come in.  Provide a default image for this case.

BUG=50771
TEST=See bug.

Review URL: http://codereview.chromium.org/3047031
------------------------------------------------------------------------
r54380 | phajdan.jr@chromium.org | 2010-07-30 23:14:03 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   D /trunk/src/chrome/browser/autocomplete/history_quick_provider.cc
   D /trunk/src/chrome/browser/autocomplete/history_quick_provider.h
   D /trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert "Incorporate 'quick' history provider index as an autocomplete ..."

Broke AutocompleteEditViewTest.DesiredTLD and AutocompleteEditView.EscapeToDefaultMatch on Linux.

TBR=mrossetti

Review URL: http://codereview.chromium.org/3052031
------------------------------------------------------------------------
r54373 | ziadh@chromium.org | 2010-07-30 22:39:31 +0200 (Fri, 30 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/gconf_titlebar_listener.h
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/tab_contents/page_navigator.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.h

Add undeclared virtual destructors part 3

Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.

These files were discovered using the -Wnon-virtual-dtor flag in g++.

r=jar
BUG=47469


Review URL: http://codereview.chromium.org/3072010
------------------------------------------------------------------------
r54359 | viettrungluu@chromium.org | 2010-07-30 21:47:47 +0200 (Fri, 30 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/base/json/json_writer.cc
   M /trunk/src/base/json/json_writer.h
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/service/cloud_print/print_system_cups.cc
   M /trunk/src/chrome/test/ui/javascript_test_util.cc
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/net/base/transport_security_state.cc

Convert DictionaryValue's keys to std::string (from wstring).

Everything now needs to be changed to avoid the deprecated wstring methods; this
includes the unit tests.

BUG=23581
TEST=all our tests still pass

Review URL: http://codereview.chromium.org/3075010
------------------------------------------------------------------------
r54357 | arv@chromium.org | 2010-07-30 21:35:01 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js
   M /trunk/src/chrome/browser/resources/shared_resources.grd

Selection model refactoring.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3025014
------------------------------------------------------------------------
r54355 | brettw@chromium.org | 2010-07-30 21:28:44 +0200 (Fri, 30 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_win.cc
   M /trunk/src/app/gfx/font_util.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util_win.cc
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/json/json_reader.cc
   M /trunk/src/base/json/json_writer.cc
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/simple_thread.cc
   M /trunk/src/base/simple_thread_unittest.cc
   A /trunk/src/base/string_number_conversions.cc
   A /trunk/src/base/string_number_conversions.h
   A /trunk/src/base/string_number_conversions_unittest.cc
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/version.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/update_observer.cc
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm
   M /trunk/src/chrome/browser/config_dir_policy_provider_unittest.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_message_unittest.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/download/drag_download_util.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_clipboard_api.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/predictor_unittest.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase_unittest.cc
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.cc
   M /trunk/src/chrome/browser/process_info_snapshot_mac.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/util/fast_dump.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/update_manifest.cc
   M /trunk/src/chrome/common/important_file_writer.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/metrics_helpers.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/sync/engine/test_id_factory.h
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome_frame/metrics_service.cc
   M /trunk/src/chrome_frame/np_proxy_service.cc
   M /trunk/src/chrome_frame/npapi_url_request.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/courgette/ensemble.cc
   M /trunk/src/gpu/command_buffer/service/program_manager.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/jingle/notifier/listener/xml_element_util.cc
   M /trunk/src/net/ftp/ftp_auth_cache_unittest.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/partial_data.cc
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/websockets/websocket_handshake.cc
   M /trunk/src/tools/memory_watcher/call_stack.cc
   M /trunk/src/tools/memory_watcher/call_stack.h
   M /trunk/src/tools/memory_watcher/memory_watcher.h
   M /trunk/src/webkit/appcache/appcache_disk_cache.cc
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.cc
   M /trunk/src/webkit/glue/plugins/pepper_var.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Move the number conversions from string_util to a new file.

Use the base namespace in the new file. Update callers.

I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.

TEST=included unit tests
BUG=none

Review URL: http://codereview.chromium.org/3056029
------------------------------------------------------------------------
r54354 | mrossetti@chromium.org | 2010-07-30 21:25:58 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   A /trunk/src/chrome/browser/autocomplete/history_quick_provider.cc
   A /trunk/src/chrome/browser/autocomplete/history_quick_provider.h
   A /trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/in_memory_url_index.cc
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Incorporate 'quick' history provider index as an autocomplete provider in preparation for the replacement of the current history_url_provider.  This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass.  Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3017008
------------------------------------------------------------------------
r54351 | chocobo@chromium.org | 2010-07-30 21:07:04 +0200 (Fri, 30 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc

Add new flimflam error codes.
BUG=chromium-os:1078
TEST=none
Review URL: http://codereview.chromium.org/3018029
------------------------------------------------------------------------
r54350 | zelidrag@chromium.org | 2010-07-30 21:05:48 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   M /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.js
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_internet_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.js
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/content_settings_ui.js
   M /trunk/src/chrome/browser/resources/options/font_settings_overlay.js
   M /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options/preferences.js
   M /trunk/src/chrome/browser/resources/options/search_engine_manager.js
   M /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.js
   M /trunk/src/chrome/browser/resources/options.html

Moved option-related JS classes behind options namespace

BUG=none
TEST=make sure options still work

Review URL: http://codereview.chromium.org/3027003
------------------------------------------------------------------------
r54349 | thakis@chromium.org | 2010-07-30 20:32:35 +0200 (Fri, 30 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   A /trunk/src/chrome/browser/cocoa/tabpose_window.h
   A /trunk/src/chrome/browser/cocoa/tabpose_window.mm
   A /trunk/src/chrome/browser/cocoa/tabpose_window_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/test_browser_window.h

Mac: Add tabpose window

The window doesn't have any contents yet, which makes its appearance look a bit janky for now.

BUG=50307
TEST=
* All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled.
* In a browser window, hit cmd-f10 or three-finger-swipe down. A grey overlay with a gradient at the top should appear.
* The overlay should cover tab contents, eventual info bars, the bookmarks bar if it's detached (but not the bookmarks bar if it's not detached), and eventual attached inspector windows. It should not cover the download shelf if it's open.
* The window should block clicks on the tab strip and the download shelf for now.
* The overlay should close on three-finger-swipe up, click, esc, enter, and space.
* Every open browser window should have its own overlay, and they should be independent of each other.
* If a browser window with an overlay window is active, most menu items should be greyed out, and all browser-related keyboard shortcuts should be disabled.
* In particular, hitting cmd-f10 twice should open only one overlay per browser window
* The overlay should have the correct size with a UI scale factor > 1

Review URL: http://codereview.chromium.org/2819070
------------------------------------------------------------------------
r54342 | phajdan.jr@chromium.org | 2010-07-30 19:59:16 +0200 (Fri, 30 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Mark BrowserFocusTest.TabInitialFocus as FLAKY.

We've seen some flaky flips July 19th, but it still
might be caused by more recent changes like my download
cleanup or other changes that have landed recently.

More data in the bug.

TBR=jcivelli,suzhe,oshima

TEST=BrowserFocusTest.TabInitialFocus
BUG=50763

Review URL: http://codereview.chromium.org/3017046
------------------------------------------------------------------------
r54340 | rohitrao@chromium.org | 2010-07-30 19:45:27 +0200 (Fri, 30 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

Exclude AutoFillManagerTest.GetBillingSuggestionsAddress1 from running in branded builds.

BUG=50537
TEST=unit_tests should pass in branded builds.
Review URL: http://codereview.chromium.org/3068013
------------------------------------------------------------------------
r54339 | evan@chromium.org | 2010-07-30 19:43:17 +0200 (Fri, 30 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h

Use a plain ASCII string for the UI locale in the plugin service.

Removes a few needless conversions.

Review URL: http://codereview.chromium.org/3075012
------------------------------------------------------------------------
r54338 | evan@chromium.org | 2010-07-30 19:42:24 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run/first_run.h
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc

Use a few more FilePaths in bookmark import.

Removes some wstrings.

BUG=24672

Review URL: http://codereview.chromium.org/2819080
------------------------------------------------------------------------
r54334 | dtseng@chromium.org | 2010-07-30 19:32:17 +0200 (Fri, 30 Jul 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   A /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views_delegate.h

Reland r54074.
Review URL: http://codereview.chromium.org/3010040
------------------------------------------------------------------------
r54332 | tony@chromium.org | 2010-07-30 19:16:11 +0200 (Fri, 30 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix a bug with detecting window sizes that match the monitor size.

The previous code was comparing the window size to the screen
size, but that doesn't work properly for twinview or other cases
where there are multiple monitors that make up a single screen.
Instead, compare the window size against all monitors (since we
don't know which monitor the window is going to be placed on)
and resize if it matches any monitor size.

Also fix a bug in BoundsMatchMonitorSize where we should just be
comparing sizes, not rectangle positions.

BUG=32347

Review URL: http://codereview.chromium.org/3060032
------------------------------------------------------------------------
r54331 | davidben@chromium.org | 2010-07-30 19:00:34 +0200 (Fri, 30 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

When running as a remote, call gdk_notify_startup_complete

Linux programs are expected to notify their launcher when they finish loading.
GTK+ does this automatically when the first GtkWindow is opened. When acting as
a remote, no window is opened, so we should manually send the notification.

This could perhaps be more thorough and pass DESKTOP_LAUNCH_ID to the remote to
call with gdk_notify_startup_complete_with_id, but a quick survey on codesearch
suggests that no one bothers anyway.

(This is reproducible in KDE. The bug report suggests some configurations of
GNOME need this as well, but not yet reproducible.)

R=estade
BUG=45392
TEST=throbber disappears on second Chrome launch in KDE

Review URL: http://codereview.chromium.org/3051023
------------------------------------------------------------------------
r54327 | skerner@chromium.org | 2010-07-30 18:16:18 +0200 (Fri, 30 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc

Give a better error when extension unpacking can't be done.

The sandbox can not allow file access to paths that contain reparse points.  Chrome tries to find a reparse point free path to the directory which will be sandboxed for extension unpacking.  However, there are cases where there is no such path.  See the bug for an example.  In this case, give a decent error message.

BUG=49530
TEST=Manually created a partition mounted in C:/mnt, mounted as drive letter, and mounted only under /Devices/HardDisk3/, tried unpacking extensions in each.

Review URL: http://codereview.chromium.org/3060026
------------------------------------------------------------------------
r54326 | johnnyg@chromium.org | 2010-07-30 18:13:33 +0200 (Fri, 30 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Notification.xib
   A /trunk/src/chrome/browser/cocoa/hover_button.h
   A /trunk/src/chrome/browser/cocoa/hover_button.mm
   M /trunk/src/chrome/browser/cocoa/hover_close_button.h
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   A /trunk/src/chrome/browser/cocoa/hover_image_button.h
   A /trunk/src/chrome/browser/cocoa/hover_image_button.mm
   A /trunk/src/chrome/browser/cocoa/hover_image_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Change mac notifications UI to match the new mocks.  Introduce a new utility view which provides an image based button that changes on hover and press.

Refer to the bug for screenshots of the current and desired UI.
 
Screenshot of what results from this patch is visible at http://www.corp.google.com/~johnnyg/49490patch.png

XIB change: change height of title bar, change bindings of buttons.

BUG=49190
TEST=notifications on the mac

Review URL: http://codereview.chromium.org/3014004
------------------------------------------------------------------------
r54325 | shess@chromium.org | 2010-07-30 17:58:34 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/popup_blocked_animation_mac.mm

[Mac] Make popup-blocked animation animate to content-setting icon.

BUG=none
TEST=www.popuptest.com, click a page to cause popups.  Animation should go to where the blocked-popup content-setting decoration is in the omnibox.

Review URL: http://codereview.chromium.org/3014029
------------------------------------------------------------------------
r54323 | skerner@chromium.org | 2010-07-30 17:33:28 +0200 (Fri, 30 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/scoped_temp_dir.cc
   M /trunk/src/base/scoped_temp_dir.h
   M /trunk/src/base/scoped_temp_dir_unittest.cc
   M /trunk/src/chrome/browser/extensions/convert_user_script.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove some debug switches:

--issue35198-crxdir-browser
--issue35198-permission

They were used to understand issue 35198.  They are no longer needed.  There is one more switch, --issue35198-logging, that is not being removed in this CL.  The logging it adds may still be useful.

BUG=50604
TEST=manual

Review URL: http://codereview.chromium.org/3052023
------------------------------------------------------------------------
r54320 | rohitrao@chromium.org | 2010-07-30 17:17:22 +0200 (Fri, 30 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

[Mac] Reposition the status bubble whenever adding it to a window.

BUG=50599
TEST=Open a window and let its webpage load.  Move the window left or right, without allowing the mouse to pass over the web area.  Then type in a new url and load it, again without letting the mouse pass over the web area.  Status bubble should appear in the proper place.
Review URL: http://codereview.chromium.org/3041028
------------------------------------------------------------------------
r54317 | rsesek@chromium.org | 2010-07-30 16:49:30 +0200 (Fri, 30 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/customization_document.cc
   M /trunk/src/chrome/browser/chromeos/customization_document.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h

Revert 54313 - OEM EULA extracted correctly from manifest.
Fixing CustomizationDocument to return full path to the pages being queried.

BUG=chromium:3178
TEST=none

Review URL: http://codereview.chromium.org/2878051

TBR=glotov@chromium.org
Review URL: http://codereview.chromium.org/3051026
------------------------------------------------------------------------
r54316 | agl@chromium.org | 2010-07-30 16:36:09 +0200 (Fri, 30 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc

Fix some bad uses of GetTempDir.

(Just a first step. I can't remove GetTempDir yet though.)

BUG=none
TEST=unit tests

http://codereview.chromium.org/3075008/show
------------------------------------------------------------------------
r54313 | glotov@chromium.org | 2010-07-30 16:28:01 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/customization_document.cc
   M /trunk/src/chrome/browser/chromeos/customization_document.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h

OEM EULA extracted correctly from manifest.
Fixing CustomizationDocument to return full path to the pages being queried.

BUG=chromium:3178
TEST=none

Review URL: http://codereview.chromium.org/2878051
------------------------------------------------------------------------
r54312 | rsesek@chromium.org | 2010-07-30 16:16:57 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm

Work around multiple bugs in the WrenchMenuControllerTest using a bit of hackery.

BUG=49206
TEST=Unit tests pass regularly.

Review URL: http://codereview.chromium.org/3017044
------------------------------------------------------------------------
r54311 | tfarina@chromium.org | 2010-07-30 16:01:59 +0200 (Fri, 30 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist_win.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/gfx/icon_util.cc
   M /trunk/src/gfx/icon_util.h
   M /trunk/src/gfx/icon_util_unittest.cc

file_util: Get rid of file_util::AppendToPath in icon_util_unittest.cc

Use AppendASCII from FilePath API instead of the deprecated AppendToPath
function.

BUG=24672
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3046020
------------------------------------------------------------------------
r54310 | avayvod@chromium.org | 2010-07-30 15:40:19 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Fixes transition from account creation screen to images login screen.

BUG=None
TEST=Create user account and verify that images login screen is shown and
the new user logs in.

Review URL: http://codereview.chromium.org/3057020
------------------------------------------------------------------------
r54309 | jochen@chromium.org | 2010-07-30 14:45:37 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm

Add title for "ask" button on mac.

TEST=unit_tests of mac
BUG=50083
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/3051025
------------------------------------------------------------------------
r54308 | jochen@chromium.org | 2010-07-30 14:01:19 +0200 (Fri, 30 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentBlockedCookies.xib
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Command line flag to disable the cookie prompt.

The XIB change re-introduces the cookie tab view item with the "ask" setting
as additinoal tab view item. The controller deletes the one not required
according to the command line flag.

BUG=50083
TEST=none

Review URL: http://codereview.chromium.org/3075013
------------------------------------------------------------------------
r54304 | andreip@chromium.org | 2010-07-30 13:09:47 +0200 (Fri, 30 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

Rename IndexedDatabase to IDBFactory to match the spec

Review URL: http://codereview.chromium.org/2808083
------------------------------------------------------------------------
r54303 | nkostylev@google.com | 2010-07-30 12:57:52 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/mock_update_library.h
   M /trunk/src/chrome/browser/chromeos/cros/update_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/update_library.h
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/update_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/update_observer.cc
   M /trunk/src/chrome/browser/chromeos/update_observer.h

Use new update API during OOBE.
Add test shortcut for register screen.

BUG= http://crosbug.com/4483 http://crosbug.com/4003 http://crosbug.com/4002
TEST=Manual - update during OOBE should work and reboot if update has been installed.

Review URL: http://codereview.chromium.org/2832088
------------------------------------------------------------------------
r54300 | apavlov@chromium.org | 2010-07-30 12:21:17 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

Show DevTools window when the Inspect shortcut is hit for the first time

BUG=50724
TEST=manual

Review URL: http://codereview.chromium.org/2819081
------------------------------------------------------------------------
r54288 | eroman@chromium.org | 2010-07-30 08:09:40 +0200 (Fri, 30 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/net/base/network_change_notifier_mac.cc
   M /trunk/src/net/base/network_change_notifier_mac.h
   A /trunk/src/net/base/network_config_watcher_mac.cc (from /trunk/src/net/base/network_change_notifier_mac.cc:54077)
   A /trunk/src/net/base/network_config_watcher_mac.h (from /trunk/src/net/base/network_change_notifier_mac.h:54077)
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_config_service_mac.cc
   M /trunk/src/net/proxy/proxy_config_service_mac.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Use notification-based API for getting system proxy settings on Mac rather than polling.

BUG=50587
Review URL: http://codereview.chromium.org/3078009
------------------------------------------------------------------------
r54286 | evan@chromium.org | 2010-07-30 08:00:38 +0200 (Fri, 30 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc

Drop usage of IntToWString in switch values; we can use ASCII now.

Review URL: http://codereview.chromium.org/3037034
------------------------------------------------------------------------
r54285 | evan@chromium.org | 2010-07-30 07:59:57 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/chrome/browser/browser_child_process_host.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/command_line_pref_store_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/first_run/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run/first_run_win.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/profile_import_process_host.cc
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/debug_flags.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/nacl/broker_thread.cc
   M /trunk/src/chrome/renderer/external_extension_uitest.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/service/service_utility_process_host.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/chrome/test/nacl/nacl_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/ui/pepper_uitest.cc
   M /trunk/src/chrome/test/ui/sandbox_uitests.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_launcher_unittest.cc
   M /trunk/src/chrome_frame/chrome_tab.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc

Convert a bunch of easy AppendSwitchWithValue to *ASCII.

For this patch, I skipped over any instance where it wasn't a nearly trivial
change.

Review URL: http://codereview.chromium.org/3069014
------------------------------------------------------------------------
r54284 | ananta@chromium.org | 2010-07-30 07:54:21 +0200 (Fri, 30 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/test/data/initialize_hidden.html

Miscellaneous ChromeFrame code cleanup. The automation client class maintained GURL members holding the url and 
referrer. We can stuff this information into the ChromeFrameLaunchParams member maintained by the client. This
reduces the complexity in the code related to detecting whether we can navigate up front or after chrome initialization.

The ChromeFrame ActiveX now launches the automation server in its implementation of IPersistPropertyBag::Load. This avoids
race conditions between launching the automation server and navigating to it via put_src.

Review URL: http://codereview.chromium.org/3038038
------------------------------------------------------------------------
r54280 | jhawkins@chromium.org | 2010-07-30 07:35:12 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc

AutoFill: Determine credit card type based on the CC number and display the
appropriate CC icon.

BUG=50080
TEST=none

Review URL: http://codereview.chromium.org/3010041
------------------------------------------------------------------------
r54262 | mrossetti@chromium.org | 2010-07-30 04:58:58 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Must clear all references to buttons representing a bookmark when that bookmark gets deleted.

BUG=50381
TEST=1) Bring up a bookmark folder which can be scrolled. 2) Scroll it a bit. 3) Cut or delete a bookmark using the contextual menu. 4) Scroll using the mouse scroll wheel. If there is no crash at this point then the bug has been fixed.

Review URL: http://codereview.chromium.org/3030029
------------------------------------------------------------------------
r54261 | huanr@chromium.org | 2010-07-30 04:51:31 +0200 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/snippet_unittest.cc

Update bug number for Snippets.FAILS_ThaiUTF8.

BUG=50705
TEST=Snippets.FAILS_ThaiUTF8

Review URL: http://codereview.chromium.org/3079010
------------------------------------------------------------------------
r54259 | tfarina@chromium.org | 2010-07-30 04:22:35 +0200 (Fri, 30 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Reland r53603 - Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.

This reverts commit 893e3e083fe8d77949860cdb1af7fc14a371651e.

It was reverted due to a LINK failure, but reverting didn't fixed either, so I'm relanding it again.

BUG=39102
TEST=trybots

Review URL: http://codereview.chromium.org/2805096/

TBR=mirandac@chromium.org

Review URL: http://codereview.chromium.org/3057018
------------------------------------------------------------------------
r54251 | phajdan.jr@chromium.org | 2010-07-30 03:11:07 +0200 (Fri, 30 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Uncrash BrowserFocusTest.*

It didn't wait for things to finish, which was clearly broken.

TBR=xji

TEST=interactive_ui_tests:BrowserFocusTest.* on Linux, no crashes
BUG=50696

Review URL: http://codereview.chromium.org/3005038
------------------------------------------------------------------------
r54249 | evan@chromium.org | 2010-07-30 02:56:10 +0200 (Fri, 30 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   D /trunk/src/chrome/browser/speech/enable_speech_input_switch_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   D /trunk/src/chrome/test/data/speech/enable_speech_input_switch_test.html

Revert "Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1"

This reverts commit r54235.
------------------------------------------------------------------------
r54235 | satish@chromium.org | 2010-07-30 02:05:23 +0200 (Fri, 30 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   A /trunk/src/chrome/browser/speech
   A /trunk/src/chrome/browser/speech/enable_speech_input_switch_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/test/data/speech
   A /trunk/src/chrome/test/data/speech/enable_speech_input_switch_test.html

Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1

Flip the compile-time enable switch for speech input to on and add a
command-line switch to put the functionality behind. The command-line
flag will be used both on the Chromium side and in WebKit via
WebRuntimeFeatures.

This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146

BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*

Review URL: http://codereview.chromium.org/3064017
------------------------------------------------------------------------
r54228 | thakis@chromium.org | 2010-07-30 01:45:59 +0200 (Fri, 30 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac_unittest.mm

Mac: Keep groups when sorting task manager, like windows does.

Also fix favicons in task manager.

BUG=32148
TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54206

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=54211

Review URL: http://codereview.chromium.org/3029041
------------------------------------------------------------------------
r54226 | evan@chromium.org | 2010-07-30 01:40:01 +0200 (Fri, 30 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_exe_main_gtk.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   A /trunk/src/chrome/browser/first_run
   A /trunk/src/chrome/browser/first_run/first_run.cc (from /trunk/src/chrome/browser/first_run.cc:54220)
   A /trunk/src/chrome/browser/first_run/first_run.h (from /trunk/src/chrome/browser/first_run.h:54220)
   A /trunk/src/chrome/browser/first_run/first_run_browsertest.cc (from /trunk/src/chrome/browser/first_run_browsertest.cc:54220)
   A /trunk/src/chrome/browser/first_run/first_run_gtk.cc (from /trunk/src/chrome/browser/first_run_gtk.cc:54220)
   A /trunk/src/chrome/browser/first_run/first_run_mac.mm (from /trunk/src/chrome/browser/first_run_mac.mm:54220)
   A /trunk/src/chrome/browser/first_run/first_run_unittest.cc (from /trunk/src/chrome/browser/first_run_unittest.cc:54220)
   A /trunk/src/chrome/browser/first_run/first_run_win.cc (from /trunk/src/chrome/browser/first_run_win.cc:54220)
   D /trunk/src/chrome/browser/first_run.cc
   D /trunk/src/chrome/browser/first_run.h
   D /trunk/src/chrome/browser/first_run_browsertest.cc
   D /trunk/src/chrome/browser/first_run_gtk.cc
   D /trunk/src/chrome/browser/first_run_mac.mm
   D /trunk/src/chrome/browser/first_run_unittest.cc
   D /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/test_location_bar.h

Move browser/first_run* into into a subdirectory.

BUG=50548

Review URL: http://codereview.chromium.org/3043030
------------------------------------------------------------------------
r54225 | tony@chromium.org | 2010-07-30 01:33:56 +0200 (Fri, 30 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix a bug where it's not possible to get out of fullscreen mode.

The bug happened when the previous state was maximized and
the monitor has no gnome-panels.  When unfullscreen'ing, the
maximized sized == the monitor size so metacity re-fullscreened.

I also fixed a bug where we assumed that screen size == monitor
size.  There's still a bug in SetWindowSize-- I'll fix that in
a follow up patch.

BUG=32347

Review URL: http://codereview.chromium.org/3077012
------------------------------------------------------------------------
r54222 | avi@chromium.org | 2010-07-30 01:19:09 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

[Win] Don't offer profiles for billing addresses that have no address
data.

BUG=http://crbug.com/50081
TEST=as in bug

Review URL: http://codereview.chromium.org/2868078
------------------------------------------------------------------------
r54219 | jhawkins@chromium.org | 2010-07-30 01:02:53 +0200 (Fri, 30 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   D /trunk/src/chrome/browser/resources/amex.png
   D /trunk/src/chrome/browser/resources/cc-generic.png
   D /trunk/src/chrome/browser/resources/diners.png
   D /trunk/src/chrome/browser/resources/discover.png
   D /trunk/src/chrome/browser/resources/jcb.png
   D /trunk/src/chrome/browser/resources/mastercard.png
   D /trunk/src/chrome/browser/resources/solo.png
   D /trunk/src/chrome/browser/resources/visa.png
   A /trunk/src/webkit/glue/resources/amex.png (from /trunk/src/chrome/browser/resources/amex.png:54209)
   A /trunk/src/webkit/glue/resources/diners.png (from /trunk/src/chrome/browser/resources/diners.png:54209)
   A /trunk/src/webkit/glue/resources/discover.png (from /trunk/src/chrome/browser/resources/discover.png:54209)
   A /trunk/src/webkit/glue/resources/jcb.png (from /trunk/src/chrome/browser/resources/jcb.png:54209)
   A /trunk/src/webkit/glue/resources/mastercard.png (from /trunk/src/chrome/browser/resources/mastercard.png:54209)
   A /trunk/src/webkit/glue/resources/solo.png (from /trunk/src/chrome/browser/resources/solo.png:54209)
   A /trunk/src/webkit/glue/resources/visa.png (from /trunk/src/chrome/browser/resources/visa.png:54209)
   M /trunk/src/webkit/glue/webkit_resources.grd

AutoFill: Move the CC icons to webkit/glue/resources. This is a temporary
location until they're moved to chrome/common.

BUG=50080
TEST=none

Review URL: http://codereview.chromium.org/3034040
------------------------------------------------------------------------
r54218 | evan@chromium.org | 2010-07-30 01:02:34 +0200 (Fri, 30 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/jumplist_win.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/pref_service_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_uitest.cc
   M /trunk/src/chrome/browser/profile_import_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/nacl_cmd_line.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/service/service_utility_process_host.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/nacl/nacl_sandbox_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/ui/npapi_test_helper.cc
   M /trunk/src/chrome/test/ui/ppapi_uitest.cc
   M /trunk/src/chrome/test/ui/sandbox_uitests.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_launcher_unittest.cc
   M /trunk/src/chrome_frame/chrome_tab.cc

CommandLine: add a CopySwitchesFrom() and AppendSwitchPath()

These are two common patterns in Chrome code: copying a
subset of switches from one CommandLine to another, and
appending a FilePath to a CommandLine.  This sets me up
to do a lot more deprecation in a follow-up change.

Review URL: http://codereview.chromium.org/3012021
------------------------------------------------------------------------
r54211 | thakis@chromium.org | 2010-07-30 00:44:07 +0200 (Fri, 30 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Revert 54206 - Mac: Keep groups when sorting task manager, like windows does.

Also fix favicons in task manager.

BUG=32148
TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block.

Review URL: http://codereview.chromium.org/3029041

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3035040
------------------------------------------------------------------------
r54209 | phajdan.jr@chromium.org | 2010-07-30 00:27:05 +0200 (Fri, 30 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Speculatively fix ChromiumOS build.

TBR=ahendrickson

TEST=compile?
BUG=48913

Review URL: http://codereview.chromium.org/3027035
------------------------------------------------------------------------
r54206 | thakis@chromium.org | 2010-07-30 00:04:59 +0200 (Fri, 30 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Keep groups when sorting task manager, like windows does.

Also fix favicons in task manager.

BUG=32148
TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block.

Review URL: http://codereview.chromium.org/3029041
------------------------------------------------------------------------
r54205 | phajdan.jr@chromium.org | 2010-07-30 00:04:57 +0200 (Fri, 30 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   A /trunk/src/chrome/browser/download/download_history.cc
   A /trunk/src/chrome/browser/download/download_history.h
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/drag_download_file.cc
   M /trunk/src/chrome/browser/download/drag_download_file.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/ui_test_utils.cc

Download code cleanup patch of death:

Separate all interactions with HistoryService out of DownloadManager
to new class DownloadHistory owned by the DownloadManager.

The goal is to create more smaller classes with clearly defined
responsibilities.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3071005
------------------------------------------------------------------------
r54201 | phajdan.jr@chromium.org | 2010-07-29 23:44:12 +0200 (Thu, 29 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/child_process_security_policy_browsertest.cc
   M /trunk/src/chrome/browser/chrome_plugin_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view_browsertest.cc
   M /trunk/src/chrome/browser/collected_cookies_uitest.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc
   M /trunk/src/chrome/browser/extensions/stubs_apitest.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/net/connection_tester_unittest.cc
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/browser/net/ftp_browsertest.cc
   M /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc
   M /trunk/src/chrome/browser/repost_form_warning_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_uitest.cc
   M /trunk/src/chrome/common/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/renderer/external_extension_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/infobars_uitest.cc
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/chrome/test/ui/ppapi_uitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/chrome_frame/test/http_server.cc
   M /trunk/src/chrome_frame/test/http_server.h
   M /trunk/src/chrome_frame/test/mock_ie_event_sink_test.h
   M /trunk/src/chrome_frame/test/test_with_web_server.cc
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/test/test_server.h
   M /trunk/src/net/tools/testserver/run_testserver.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/unittest_test_server.h

GTTF: Move more test server code from net/url_request/url_request_unittest.h
to net/test/test_server.h

No code changes, just a move.

TEST=none
BUG=49680

Review URL: http://codereview.chromium.org/3034038
------------------------------------------------------------------------
r54199 | cmasone@google.com | 2010-07-29 23:28:11 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   A /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   A /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h

OwnerManager, allows use of OwnerKeyUtils to take ownership of a device

    BUG=chromium-os:4485
    TEST=unit tests

Review URL: http://codereview.chromium.org/3058021
------------------------------------------------------------------------
r54188 | shess@chromium.org | 2010-07-29 22:58:43 +0200 (Thu, 29 Jul 2010) | 32 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

[Mac] First pass at final sizing of toolbar items.

Toolbar.xib changes:
 - buttons from 31x27 to 29x29 so that the visual is 27x27.
 - shift things left to take up opened space.
 - omnibox to 29 pixels tall.
 - wrench also to 29x29.
 - all of that raised a single pixel to recenter.
 - swap positions of home and reload.

Modify home-button-adjustment code to reflect rearranged
home/reload positions.

Increase Omnibox font size by one point to match increased field
height (and Windows Omnibox).  Revise various font clients to
recognize this.  Shift Omnibox baseline and other measurements to
account for increased height.

Shift globe/search icon in by one pixel so icons on both sides of
Omnibox are 4px from border.  Matching shift in popup.

Fix EV-bubble to use appropriate green for text, rather than black.

Push out bubble to have a single-pixel space WRT Omnibox border.
Tighten corners to tuck into Omnibox corners.  Handle different
lhs padding versus location icon (image should end up in same
spot, even though the bubble draws outside the image).

BUG=50575
TEST=none

Review URL: http://codereview.chromium.org/3046029
------------------------------------------------------------------------
r54187 | mrossetti@chromium.org | 2010-07-29 22:55:36 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Rework somewhat how the folder menu window and main view sizes and positions are calculated. Handle edge case where the top scroll arrow is not showing. Proposed window height was not taking into account the one additional vertical separation.

BUG=46101
TEST=Setup: Create a bookmark folder on the bookmark bar with plenty of bookmarks, more than enough to fill the screen, and so that it is scrollable. 1) Bring up the bookmark folder menu but do not cause it to scroll. 2) Using the contextual menu delete a bookmark midway in the menu. 3) Verify that the top of the menu window and contents do not move relative to the bookmark bar folder button. 4) Bring up the bookmark folder menu again. 5) Cause the menu to scroll up to fill the screen and then scroll it down so that the top scroll arrow is not showing. 6) Using the contextual menu delete a bookmark midway in the menu. 7) Verify that the top of the menu window and contents have not moved in relation to the screen top. 8) Bring up the bookmark folder menu and cause it to scroll such that both the top and bottom scroll arrows are showing. 9) Using the contextual menu, delete a bookmark midway in the menu. 10) Verify that the top scroll arrow, the top-most item showing in the menu, and the menu window have not changed position relative to the top of the window. Note that the contents of the folder menu below the bookmark item being delete should adjust upward to fill the slot originally occupied by the deleted bookmark.

Review URL: http://codereview.chromium.org/3050021
------------------------------------------------------------------------
r54185 | jhawkins@chromium.org | 2010-07-29 22:54:20 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc

AutoFill: Collect UMA stats for AutoFill CC InfoBar.

BUG=50573
TEST=none

Review URL: http://codereview.chromium.org/2868082
------------------------------------------------------------------------
r54183 | jhawkins@chromium.org | 2010-07-29 22:41:45 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

AutoFill: Capitalize "Options" in the AutoFill dialog title.

BUG=50378
TEST=none

Review URL: http://codereview.chromium.org/3018026
------------------------------------------------------------------------
r54178 | stuartmorgan@chromium.org | 2010-07-29 22:25:36 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/options_page.css

DOMUI prefs: Remove use of tables for layout on the Under the Hood pane.

BUG=none
TEST=DOMUI Under the Hood options still display correctly.

Review URL: http://codereview.chromium.org/3017039
------------------------------------------------------------------------
r54176 | jhawkins@chromium.org | 2010-07-29 22:22:14 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc

AutoFill: Remove a static string16.

BUG=50669
TEST=none

Review URL: http://codereview.chromium.org/3013043
------------------------------------------------------------------------
r54175 | thakis@chromium.org | 2010-07-29 22:19:49 +0200 (Thu, 29 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac_unittest.mm
   M /trunk/src/chrome/browser/task_manager.h

Mac: Add sort support for task manager.

Also fix a leak in test Init reported by valgrind. The problem was that the test called a rogue init, which didn't cause the window to be shown, and hence -close didn't send a -windowWillClose: notification. Also restore -windowWillClose:, it accidentally got deleted in http://codereview.chromium.org/536086

BUG=32148,30398
TEST=Click a column in the task manager. Should sort.

Review URL: http://codereview.chromium.org/2873075
------------------------------------------------------------------------
r54174 | pkasting@chromium.org | 2010-07-29 22:19:24 +0200 (Thu, 29 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Browser actions container layout changes for M6 theme.

In short, this:
* Eliminates the divider on the right (the new chevron has a built-in divider)
* Changes the padding between items (see updated comments in header for precise layout details)
* Updates the imagery for the new theme
* Makes the chevron respond to theme changes

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3057016
------------------------------------------------------------------------
r54170 | brettw@chromium.org | 2010-07-29 21:57:50 +0200 (Thu, 29 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/audio_handler.cc
   M /trunk/src/chrome/browser/chromeos/audio_handler.h

Revert 53992 - An earlier check-in (r51786, Issue 2769008) caused a memory leak on the build bots when PulseAudio was initialized on a separate worker thread.  This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread.  For some reason, the init finishes cleanly on one thread, but not the other.

BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141)
TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures.

Review URL: http://codereview.chromium.org/3026028

TBR=davej@chromium.org
Review URL: http://codereview.chromium.org/3013042
------------------------------------------------------------------------
r54165 | brettw@chromium.org | 2010-07-29 21:41:28 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Remove unneeded browser.h include from RVHDelegateHelper.

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3020041
------------------------------------------------------------------------
r54162 | sanjeevr@chromium.org | 2010-07-29 21:06:56 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/app/menus/button_menu_item_model.cc
   M /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

The button menu items on GTK menus honor the enabled state of the command.
BUG=None
TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise.

Review URL: http://codereview.chromium.org/3032038
------------------------------------------------------------------------
r54160 | rohitrao@chromium.org | 2010-07-29 20:47:40 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Fix a crashing PreferencesWindowController unit test (only crashes in branded builds).

BUG=50471
TEST=PreferencesWindowController.SwitchToPage should not crash in official builds.
Review URL: http://codereview.chromium.org/2836073
------------------------------------------------------------------------
r54159 | jamesr@chromium.org | 2010-07-29 20:47:09 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Add a command line switch to control accelerated 2d canvas

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2873074
------------------------------------------------------------------------
r54149 | avi@chromium.org | 2010-07-29 20:19:12 +0200 (Thu, 29 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc

[GTK] Don't offer profiles for billing addresses that have no address 
data.

BUG=http://crbug.com/50081
TEST=as in bug

Review URL: http://codereview.chromium.org/3031030
------------------------------------------------------------------------
r54147 | dhollowa@chromium.org | 2010-07-29 20:16:25 +0200 (Thu, 29 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFill suggestions for billing and credit card fields should show derived labels.

Changes suggestions for forms with billing information to show derived labels based on contents of suggestions, not the labels stored in the matched profiles.  Also, the suggestion logic has been updated to properly take account of the billing "relation" in the credit card info.  Credit card only suggestions now use derived labels as well.

BUG=50261
TEST=AutoFillManagerTest.GetBillingSuggestionsAddress1, AutoFillManagerTest.GetCreditCardSuggestions*

Review URL: http://codereview.chromium.org/3067016
------------------------------------------------------------------------
r54139 | brettw@chromium.org | 2010-07-29 18:32:46 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Mark SessionHistoryTest.JavascriptHistory as flaky.

BUG=50648
TEST=none
Review URL: http://codereview.chromium.org/3073009
------------------------------------------------------------------------
r54138 | glider@chromium.org | 2010-07-29 18:17:43 +0200 (Thu, 29 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils.h (from /trunk/src/chrome/browser/dom_ui/advanced_options_utils.h:54136)
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils_gtk.cc (from /trunk/src/chrome/browser/dom_ui/advanced_options_utils_gtk.cc:54136)
   M /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.mm
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils_win.cc (from /trunk/src/chrome/browser/dom_ui/advanced_options_utils_win.cc:54136)
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/chrome_browser.gypi

Revert 54137 - Revert 53990 - - Implement proxy settings dialog for Linux/Windows.
- Omit Network and SSL sections for ChromeOS.

BUG=49038
TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/2847061

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/2884047

TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/3023026
------------------------------------------------------------------------
r54137 | glider@chromium.org | 2010-07-29 17:29:32 +0200 (Thu, 29 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   D /trunk/src/chrome/browser/dom_ui/advanced_options_utils.h
   D /trunk/src/chrome/browser/dom_ui/advanced_options_utils_gtk.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.mm
   D /trunk/src/chrome/browser/dom_ui/advanced_options_utils_win.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/chrome_browser.gypi

Revert 53990 - - Implement proxy settings dialog for Linux/Windows.
- Omit Network and SSL sections for ChromeOS.

BUG=49038
TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/2847061

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/2884047
------------------------------------------------------------------------
r54134 | glider@chromium.org | 2010-07-29 16:38:26 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_name_edit.js

Returned chromeos_accounts_user_name_edit.js deleted at r54128

TBR=xiyuan

Review URL: http://codereview.chromium.org/3077011
------------------------------------------------------------------------
r54128 | glider@chromium.org | 2010-07-29 15:53:41 +0200 (Thu, 29 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/mock_cros_settings.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options_page.css
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js
   D /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_name_edit.js

Revert 53989 - Implement new mock for user options page per chromium-os:5028

BUG=chromium-os:5028
TEST=Verify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only.

Review URL: http://codereview.chromium.org/2868067

TBR=xiyuan@chromium.org
Review URL: http://codereview.chromium.org/3074010
------------------------------------------------------------------------
r54123 | mseaborn@chromium.org | 2010-07-29 14:53:47 +0200 (Thu, 29 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc

NaCl: Fix link time error when DISABLE_NACL is set

This fixes breakage on the ARM buildbot, introduced by r54113.
nacl::Close() is not available when DISABLE_NACL is set.

The error was:
nacl_process_host.cc: error: undefined reference to 'nacl::Close(int)'

BUG=none
TEST=none (no trybot for the ARM build)

Review URL: http://codereview.chromium.org/3023025
------------------------------------------------------------------------
r54113 | mseaborn@chromium.org | 2010-07-29 12:20:49 +0200 (Thu, 29 Jul 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/renderer/render_process_impl.cc

NaCl: Allow setting up multiple sockets for subprocess instead of just one

Remove the "channel number" parameter from messages, since this is now
fixed in the NaCl plugin code in sel_main_chrome.c.

Replace pair_ and descriptor_ with sockets_for_renderer_ and
sockets_for_sel_ldr_.

NaClProcessMsg_Start: Pass an array of FDs instead of one FD.

ViewHostMsg_LaunchNaCl:
 * Add socket count.
 * Return an array of FDs instead of one FD.

Expose this functionality to the NaCl plugin via a new function,
"launch_nacl_process_multi_fd".

BUG=50626
TEST=nacl_ui_tests

Review URL: http://codereview.chromium.org/2832093
------------------------------------------------------------------------
r54107 | markusheintz@chromium.org | 2010-07-29 10:47:42 +0200 (Thu, 29 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_provider.cc

Fix wrong line ending.

BUG=none
TEST=none
------------------------------------------------------------------------
r54106 | pam@chromium.org | 2010-07-29 10:21:13 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h

Fix line endings and set eol-style on configuration_policy* files.

BUG=none
TEST=no more patch errors on trybots
Review URL: http://codereview.chromium.org/3082003
------------------------------------------------------------------------
r54104 | dpolukhin@chromium.org | 2010-07-29 09:21:14 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Chrome OS: Prevent overlapping of title and "x" button for devtools window

BUG=46408
TEST=Title for detached devtools window doesn't overlap with "x" button for long URLs.

Review URL: http://codereview.chromium.org/2868075
------------------------------------------------------------------------
r54103 | thestig@chromium.org | 2010-07-29 09:01:58 +0200 (Thu, 29 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc

Fix the build - forgot to check in a file.

BUG=none
TEST=Bots go green.
TBR=erg
Review URL: http://codereview.chromium.org/3038035
------------------------------------------------------------------------
r54102 | thestig@chromium.org | 2010-07-29 08:46:39 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/app/animation_container.cc
   M /trunk/src/app/gfx/gl/gl_implementation_linux.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util_dummy.cc
   M /trunk/src/app/l10n_util_posix.cc
   M /trunk/src/app/linear_animation.cc
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.cc
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/language_order_table_model.cc
   M /trunk/src/chrome/browser/language_order_table_model.h
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details_linux.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/platform_util_linux.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_localization_peer.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/json_pref_store_unittest.cc
   M /trunk/src/chrome/common/time_format_unittest.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.h
   M /trunk/src/chrome/gpu/gpu_video_layer_glx.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/webkit/database/databases_table.cc
   M /trunk/src/webkit/database/quota_table.cc
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.cc

Cleanup: Remove unneeded headers from app/

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819063
------------------------------------------------------------------------
r54101 | thestig@chromium.org | 2010-07-29 08:15:44 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/net/base/auth.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/ftp/ftp_auth_cache.cc
   M /trunk/src/net/ftp/ftp_auth_cache.h
   M /trunk/src/net/ftp/ftp_auth_cache_unittest.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/ftp/ftp_transaction.h
   M /trunk/src/net/http/http_auth.h
   M /trunk/src/net/http/http_auth_cache.cc
   M /trunk/src/net/http/http_auth_cache.h
   M /trunk/src/net/http/http_auth_cache_unittest.cc
   M /trunk/src/net/http/http_auth_controller.cc
   M /trunk/src/net/http/http_auth_controller.h
   M /trunk/src/net/http/http_auth_gssapi_posix.cc
   M /trunk/src/net/http/http_auth_gssapi_posix.h
   M /trunk/src/net/http/http_auth_handler.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/http/http_auth_handler_basic.cc
   M /trunk/src/net/http/http_auth_handler_basic.h
   M /trunk/src/net/http/http_auth_handler_basic_unittest.cc
   M /trunk/src/net/http/http_auth_handler_digest.cc
   M /trunk/src/net/http/http_auth_handler_digest.h
   M /trunk/src/net/http/http_auth_handler_digest_unittest.cc
   M /trunk/src/net/http/http_auth_handler_mock.cc
   M /trunk/src/net/http/http_auth_handler_mock.h
   M /trunk/src/net/http/http_auth_handler_negotiate.cc
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   M /trunk/src/net/http/http_auth_handler_negotiate_unittest.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.h
   M /trunk/src/net/http/http_auth_handler_unittest.cc
   M /trunk/src/net/http/http_auth_sspi_win.cc
   M /trunk/src/net/http/http_auth_sspi_win.h
   M /trunk/src/net/http/http_cache_transaction.cc
   M /trunk/src/net/http/http_cache_transaction.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/socket_stream/socket_stream.h
   M /trunk/src/net/socket_stream/socket_stream_job.h
   M /trunk/src/net/socket_stream/socket_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction.cc
   M /trunk/src/net/spdy/spdy_network_transaction.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_ftp_job.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/net/websockets/websocket_job.cc
   M /trunk/src/net/websockets/websocket_job.h
   M /trunk/src/net/websockets/websocket_job_unittest.cc

Net: Convert username and password to string16.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3040016
------------------------------------------------------------------------
r54100 | akalin@chromium.org | 2010-07-29 08:02:19 +0200 (Thu, 29 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Fixed extension sync-related crash in ChromeUrlRequestContext

Made ChromeUrlRequestContext handle multiple extension unloaded
notifications gracefully.

BUG=50567
TEST=manual (see repro in bug)

Review URL: http://codereview.chromium.org/2819072
------------------------------------------------------------------------
r54098 | viettrungluu@chromium.org | 2010-07-29 06:33:47 +0200 (Thu, 29 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_posix.h
   M /trunk/src/chrome/browser/browser_main_win.cc

BrowserMain() refactoring, part 2.1.

1. Move InitializeSSL() into platform-specific files and eliminate #ifdef.
2. Add some instructions on how to add code to BrowserMain().

BUG=none
TEST=everything still works

Review URL: http://codereview.chromium.org/3073008
------------------------------------------------------------------------
r54095 | rohitrao@chromium.org | 2010-07-29 05:55:05 +0200 (Thu, 29 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Revert 54073 - Fix --kiosk to work regardless of the startup pref setting or supplied URLs.

BUG=none
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk.  Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/3061026

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3012031
------------------------------------------------------------------------
r54093 | rohitrao@chromium.org | 2010-07-29 05:24:45 +0200 (Thu, 29 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   D /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views_delegate.h

Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3015026

TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/3046031
------------------------------------------------------------------------
r54074 | dtseng@chromium.org | 2010-07-29 01:55:07 +0200 (Thu, 29 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   A /trunk/src/chrome/browser/views/browser_keyboard_accessibility_test_win.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views_delegate.h

Add initial tests for keyboard access (tabbing in some dialogs).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3015026
------------------------------------------------------------------------
r54073 | pkasting@chromium.org | 2010-07-29 01:50:37 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Fix --kiosk to work regardless of the startup pref setting or supplied URLs.

BUG=none
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk.  Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/3061026
------------------------------------------------------------------------
r54067 | sargrass@google.com | 2010-07-29 01:16:37 +0200 (Thu, 29 Jul 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   A /trunk/src/chrome/browser/dom_ui/import_data_handler.h
   A /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.cc
   A /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.h
   A /trunk/src/chrome/browser/resources/options/import_data_overlay.html
   A /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   A /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.html
   A /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.js

add files

Review URL: http://codereview.chromium.org/3052022
------------------------------------------------------------------------
r54056 | sargrass@google.com | 2010-07-29 01:00:31 +0200 (Thu, 29 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

remove the chromeos include and reland

Review URL: http://codereview.chromium.org/3069008
------------------------------------------------------------------------
r54054 | rohitrao@chromium.org | 2010-07-29 00:53:09 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

Disable AutoFillManagerTest tests in branded builds.

BUG=50537
TEST=Should not crash on official builds.
Review URL: http://codereview.chromium.org/3032034
------------------------------------------------------------------------
r54052 | jhawkins@chromium.org | 2010-07-29 00:46:41 +0200 (Thu, 29 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/autofill_helper.cc
   M /trunk/src/chrome/renderer/autofill_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webkit_resources.grd
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.cc

AutoFill: Display a right-aligned generic CC icon in the suggestions popup for
billing suggestions.

BUG=50080
TEST=none

Review URL: http://codereview.chromium.org/3071003
------------------------------------------------------------------------
r54049 | pkasting@chromium.org | 2010-07-29 00:41:05 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/wrench_menu.cc

Toolbar layout changes for M6 theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3033036
------------------------------------------------------------------------
r54048 | pkasting@chromium.org | 2010-07-29 00:40:50 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Location bar layout changes for M6 theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3067011
------------------------------------------------------------------------
r54045 | mirandac@google.com | 2010-07-29 00:37:42 +0200 (Thu, 29 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Remove tips from NTP.

BUG= 50072
TEST= no tips on NTP.
Review URL: http://codereview.chromium.org/3033032
------------------------------------------------------------------------
r54044 | jar@chromium.org | 2010-07-29 00:37:23 +0200 (Thu, 29 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/predictor_api.h
   M /trunk/src/chrome/browser/net/predictor_unittest.cc
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/browser/net/url_info.cc
   M /trunk/src/chrome/browser/net/url_info.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/net/base/load_flags_list.h

Support both preconnection, and pre-resolution for subresources

With this change, both preconnection and preresolution are
enabled when the --enable-preconnection flag is turned on.

I'm expecting to enable this feature by default soon, so
as to better tune the parameters.


BUG=42694
r=mbelshe
Review URL: http://codereview.chromium.org/3032014
------------------------------------------------------------------------
r54041 | evan@chromium.org | 2010-07-29 00:10:57 +0200 (Thu, 29 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.h
   D /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   D /trunk/src/chrome/browser/dom_ui/import_data_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   D /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.cc
   D /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.h
   D /trunk/src/chrome/browser/resources/options/import_data_overlay.html
   D /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   D /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.html
   D /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Revert "Stop Syncing Overlay and Import Data Overlay"

This reverts commit r54032, due to compile failure.
------------------------------------------------------------------------
r54032 | sargrass@google.com | 2010-07-28 23:55:15 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.h
   A /trunk/src/chrome/browser/dom_ui/import_data_handler.cc
   A /trunk/src/chrome/browser/dom_ui/import_data_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   A /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.cc
   A /trunk/src/chrome/browser/dom_ui/stop_syncing_handler.h
   A /trunk/src/chrome/browser/resources/options/import_data_overlay.html
   A /trunk/src/chrome/browser/resources/options/import_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   A /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.html
   A /trunk/src/chrome/browser/resources/options/stop_syncing_overlay.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Stop Syncing Overlay and Import Data Overlay

BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options

Review URL: http://codereview.chromium.org/3038016
------------------------------------------------------------------------
r54031 | stuartmorgan@chromium.org | 2010-07-28 23:54:31 +0200 (Wed, 28 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js

Re-land 53849 (Revert 53857) - Implement most of the startup page controls in DOMUI prefs

Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs.
Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed.

BUG=48713
TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs.

Review URL: http://codereview.chromium.org/3046025

TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/3058018

TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/3032035
------------------------------------------------------------------------
r54028 | chron@chromium.org | 2010-07-28 23:44:43 +0200 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.cc
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   A /trunk/src/chrome/browser/net/gaia/token_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.h
   A /trunk/src/chrome/common/net/gaia/gaia_constants.cc
   A /trunk/src/chrome/common/net/gaia/gaia_constants.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/test/test_notification_tracker.h

The token service should now support issuing auth tokens.
The service will fetch tokens in the background and broadcast notifications after it's done.
Move some common constants out into a new file.
Modify TestNotificationTracker to support subclassing as it doesn't properly make a deep copy of notifications on the stack.
TEST=unit tests included
BUG=47093

Review URL: http://codereview.chromium.org/3024002
------------------------------------------------------------------------
r54023 | cmasone@google.com | 2010-07-28 23:25:32 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils_unittest.cc

In real usage, we won't be exporting public keys to a file, so refactor and update the API to reflect this.  Also, add a method to find a private key, given its associated public key.

BUG=chromium-os:4485
TEST=unit tests

Review URL: http://codereview.chromium.org/3078001
------------------------------------------------------------------------
r54021 | brettw@chromium.org | 2010-07-28 23:20:48 +0200 (Wed, 28 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Remove dependency on browser. It doesn't look like this is needed any more.

TEST=it compiles
BUG=none
------------------------------------------------------------------------
r54020 | tfarina@chromium.org | 2010-07-28 23:16:30 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/automation/automation_extension_tracker.h
   M /trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.h
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.h
   M /trunk/src/chrome/browser/net/chrome_network_delegate.h
   M /trunk/src/chrome/browser/renderer_host/audio_sync_reader.h
   M /trunk/src/chrome/browser/resources_util.h
   M /trunk/src/chrome/browser/scoped_pref_update.h
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h

browser: Fix some presubmit errors.

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3026031
------------------------------------------------------------------------
r54018 | johnnyg@chromium.org | 2010-07-28 23:10:43 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm

Fix memory leaks in the balloon controller unit test by loading the NIB in the correct test-friendly way, which allows the windows to be closed correctly and the cleanup code to run as expected.

BUG=49590
TEST=unittests

Review URL: http://codereview.chromium.org/2825073
------------------------------------------------------------------------
r54017 | xiyuan@chromium.org | 2010-07-28 23:01:03 +0200 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.js

Avoid js exception in history.pushState by not changing url.

Also added a missing OptionsPage.setState call.

BUG=none
TEST=OptionsPage should work as expected when switching tabs and users/network list should be populated properly.

Review URL: http://codereview.chromium.org/3074007
------------------------------------------------------------------------
r54014 | stuartmorgan@chromium.org | 2010-07-28 22:59:12 +0200 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.h

Remove static caching of default favicon in CustomHomePagesTableModel

This fixes an assertion failure when trying to use this class on the Mac due to SkBitmap destruction happening during process exit handling.

BUG=None
TEST=Custom startup page list should still show default favicons.

Review URL: http://codereview.chromium.org/3028030
------------------------------------------------------------------------
r54006 | cmasone@google.com | 2010-07-28 22:17:50 +0200 (Wed, 28 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Fix nit for oshima

http://src.chromium.org/viewvc/chrome?view=rev&revision=53913 accidentally landed a cleaned up version of the change reviewed in http://codereview.chromium.org/2847080/show

This change introduces a style nit fix, but is also so that someone can review the ExpectCanceledFetcher (which replaces and simplifies TimedMockFetcher) in google_authenticator_unittest.cc

BUG=None
TEST=unit tests

Review URL: http://codereview.chromium.org/3077006
------------------------------------------------------------------------
r54005 | estade@chromium.org | 2010-07-28 22:17:06 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Fix some event coordinate logic

BUG=none
TEST=you can still drag the chrome window by the titlebar, and when you double click it maximizes (this did not change; it was true before this patch as well)

Review URL: http://codereview.chromium.org/3061023
------------------------------------------------------------------------
r54004 | avi@chromium.org | 2010-07-28 22:16:46 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm

[Mac] Don't offer profiles for billing addresses that have no address data.

BUG=http://crbug.com/50081
TEST=as in bug

Review URL: http://codereview.chromium.org/2868076
------------------------------------------------------------------------
r54003 | nshkrob@chromium.org | 2010-07-28 22:16:02 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Unpin deleted URLs + better deleting algorithm.

BUG=none
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2832091
------------------------------------------------------------------------
r54002 | estade@chromium.org | 2010-07-28 21:56:09 +0200 (Wed, 28 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   A /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.css
   A /trunk/src/chrome/browser/resources/options/content_settings_exceptions_area.js
   D /trunk/src/chrome/browser/resources/options/content_settings_exceptions_list.js
   M /trunk/src/chrome/browser/resources/options/content_settings_page.css
   M /trunk/src/chrome/browser/resources/options.html

Flesh out the content settings exceptions lists a bit more.

- Add "Add" button. Doesn't work.
- Add "Remove" button. Does work.
- Update the view when the model changes.

(Still only works for the images content type.)

BUG=48862
TEST=manual; unit tests

Review URL: http://codereview.chromium.org/3068005
------------------------------------------------------------------------
r53998 | ben@chromium.org | 2010-07-28 21:43:04 +0200 (Wed, 28 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Fix glitch in rendering of the stroke at the bottom of the browser toolbar.

The code that rendered this line was doing weird things (adding/removing kClientEdgeThickness from the edges?!) so I removed this and used toolbar_bounds.right() instead of toolbar_bounds.width() which is correct given that toolbar_bounds.x() > 0.

I also got rid of the use of MirroredLeftPointForRect since the flipped version of a horizontal line is... the same horizontal line.

I have also updated the glass frame not to subtract a pixel from the right edge which looks glitchy as well.

http://crbug.com/48134
TEST=see bug

Review URL: http://codereview.chromium.org/3056022
------------------------------------------------------------------------
r53997 | rsesek@chromium.org | 2010-07-28 21:38:50 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/base/mac_util_unittest.mm
   M /trunk/src/chrome/browser/cocoa/animatable_image.mm

Move NSImage-to-CGImageRef conversion code into a common helper function in base/mac_util.h.

BUG=49571
TEST=Covered by unit_tests.

Review URL: http://codereview.chromium.org/3072005
------------------------------------------------------------------------
r53994 | nick@chromium.org | 2010-07-28 21:21:45 +0200 (Wed, 28 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc

Fix leaks found by sync unit tests.

1. Fix EntryKernel leak if sync database load fails.
2. DirectoryBackingStore: always close the load handle.
3. DirectoryBackingStore unittests: free when .clear()ing test index
4. Fix real bad leak in Directory::PurgeEntriesWithTypeIn.

BUG=50334,50335,50336,50347,50348,50349
TEST=sync_unit_tests

Review URL: http://codereview.chromium.org/3026029
------------------------------------------------------------------------
r53993 | pkasting@chromium.org | 2010-07-28 21:21:40 +0200 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/star_decoration.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/chrome_dll.gypi

Modified resources for M6 theme.  This doesn't actually modify layout yet, just images and identifier names.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3035034
------------------------------------------------------------------------
r53992 | davej@chromium.org | 2010-07-28 21:19:54 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/audio_handler.cc
   M /trunk/src/chrome/browser/chromeos/audio_handler.h

An earlier check-in (r51786, Issue 2769008) caused a memory leak on the build bots when PulseAudio was initialized on a separate worker thread.  This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread.  For some reason, the init finishes cleanly on one thread, but not the other.

BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141)
TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures.

Review URL: http://codereview.chromium.org/3026028
------------------------------------------------------------------------
r53990 | csilv@chromium.org | 2010-07-28 21:15:04 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils.h
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils_gtk.cc
   D /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.mm
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils_win.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/chrome_browser.gypi

- Implement proxy settings dialog for Linux/Windows.
- Omit Network and SSL sections for ChromeOS.

BUG=49038
TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/2847061
------------------------------------------------------------------------
r53989 | xiyuan@chromium.org | 2010-07-28 21:03:55 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.cc
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/mock_cros_settings.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   D /trunk/src/chrome/browser/resources/options/chromeos_accounts_add_user_overlay.html
   D /trunk/src/chrome/browser/resources/options/chromeos_accounts_add_user_overlay.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_options_page.css
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_name_edit.js
   M /trunk/src/chrome/browser/resources/options.html

Implement new mock for user options page per chromium-os:5028

BUG=chromium-os:5028
TEST=Verify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only.

Review URL: http://codereview.chromium.org/2868067
------------------------------------------------------------------------
r53979 | erg@google.com | 2010-07-28 19:58:59 +0200 (Wed, 28 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Partially revert r53873 (and the valgrind suppression for it).

Moving DataSource destruction to the UI thread appears to just leak
memory at shutdown. Finding another way...

BUG=34115
TEST=none

Review URL: http://codereview.chromium.org/3060024
------------------------------------------------------------------------
r53977 | viettrungluu@chromium.org | 2010-07-28 19:35:07 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.h

Linux: bit hacky way to ensure Pepper plugins get loaded by zygote.

BUG=49702
TEST=Integrated PDF plugin should work on Linux Chrome, and --register-pepper-plugins works on Linux even with sandbox enabled.

Review URL: http://codereview.chromium.org/3031011
------------------------------------------------------------------------
r53972 | pfeldman@chromium.org | 2010-07-28 19:28:34 +0200 (Wed, 28 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc

DevTools: restore remote rebugging after upstream breakage.

Review URL: http://codereview.chromium.org/3052019
------------------------------------------------------------------------
r53969 | erg@google.com | 2010-07-28 19:25:28 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/process_posix.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/platform_util_common_linux.cc
   M /trunk/src/chrome/browser/process_info_snapshot_mac.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/test/live_sync/live_autofill_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_util.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome_frame/chrome_launcher_unittest.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.h
   M /trunk/src/chrome_frame/test/ie_event_sink.cc
   M /trunk/src/media/filters/ffmpeg_video_decode_engine.cc
   M /trunk/src/media/test/ffmpeg_tests/ffmpeg_tests.cc
   M /trunk/src/media/tools/media_bench/media_bench.cc
   M /trunk/src/media/tools/omx_test/omx_test.cc
   M /trunk/src/media/tools/scaler_bench/scaler_bench.cc
   M /trunk/src/media/tools/wav_ola_test/wav_ola_test.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/tools/imagediff/image_diff.cc
   M /trunk/src/views/examples/examples_main.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

base/ header cleanup. Forward declaration instead of including.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3068004
------------------------------------------------------------------------
r53961 | rsesek@chromium.org | 2010-07-28 19:12:42 +0200 (Wed, 28 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.h
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Fix the custom homepages preferences to:

1) Make it actually work again.
2) Change the model so that it doesn't get into an infinite recursion cycle
   trying to update the model, notify observers, and then re-update.

BUG=49320
TEST=Chromium-->Preferences. Add custom home pages. Close Preferences and reopen. They are still there.
TEST=Open 3 web pages in tabs. Chromium-->Preferences. Use Current homepages. Close Preferences and reopen. They are still there.
TEST=With custom homepages set, go to Chromium-->Preferences-->UtH-->Reset to Defaults. Go back to Basics. No more custom homepages.

Review URL: http://codereview.chromium.org/3023023
------------------------------------------------------------------------
r53959 | dtseng@chromium.org | 2010-07-28 18:57:38 +0200 (Wed, 28 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/views/controls/native_control.cc

Set the initial focus when the task manager first activates and shows.  Also, send our custom accessibility events in NativeControl's Focus() method.
BUG=50401
TEST=interactive UI tests BrowserKeyboardAccessibility.TabInTaskManager
Review URL: http://codereview.chromium.org/3038031
------------------------------------------------------------------------
r53958 | tfarina@chromium.org | 2010-07-28 18:48:10 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/base/ref_counted.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/common/webkit_param_traits.h

Fix lines longer than 80 characters.

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3013038
------------------------------------------------------------------------
r53950 | stuartmorgan@chromium.org | 2010-07-28 18:24:43 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc

Make product name dynamic in DOMUI pref unit tests

BUG=50466
TEST=OptionsUITest test should pass on official builder in addition to main waterfall.

Review URL: http://codereview.chromium.org/3015035
------------------------------------------------------------------------
r53948 | markusheintz@chromium.org | 2010-07-28 18:15:32 +0200 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc

Fix wrong line-ending.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2870076
------------------------------------------------------------------------
r53945 | tonyg@chromium.org | 2010-07-28 17:37:17 +0200 (Wed, 28 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer.cc
   M /trunk/src/chrome/browser/net/load_timing_observer.h
   M /trunk/src/chrome/browser/net/load_timing_observer_unittest.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h

Fix bug which caused DNS time not to be reported by LoadTimingObserver.

The problem was the LogBoundConnectJobToRequest() sets
SOCKET_POOL_BOUND_TO_CONNECT_JOB after RemoveConnectJob() ends
SOCKET_POOL_CONNECT_JOB. Since there is no chance to return to the event loop,
it is safe (although fragile), to store the last connect job record and access
that on SOCKET_POOL_BOUND_TO_CONNECT_JOB.

Also, after fixing the DNS issue, it became apparent that what was being
measured as connect time actually included more than just the TCP connect. So I
fixed that as well.

BUG=50229
TEST=LoadTimingObserverTest.*

Review URL: http://codereview.chromium.org/3028026
------------------------------------------------------------------------
r53944 | avi@chromium.org | 2010-07-28 17:27:23 +0200 (Wed, 28 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Quick fix for window sizing under resolution independence on Mac. Scrolling and the "more" arrows are still broken, but this at least makes things usable.

Re-committing of r53272, but this time with more... correctness.

Original review: http://codereview.chromium.org/3029020

BUG=http://crbug.com/19476
TEST=run app under high-res, click bookmark bar button, see that the popup is sized to hold the buttons.

Review URL: http://codereview.chromium.org/3061021
------------------------------------------------------------------------
r53943 | avi@chromium.org | 2010-07-28 17:24:28 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/upgrade_dot.pdf
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome_dll.gypi

Use a PDF for the upgrade dot.

BUG=http://crbug.com/49668
TEST=turn up resolution; make sure dot is crisp and clear

Review URL: http://codereview.chromium.org/3066009
------------------------------------------------------------------------
r53940 | pfeldman@chromium.org | 2010-07-28 16:52:00 +0200 (Wed, 28 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc

DevTools: Inspect Element doesn't select element in the Elements Panel when tools are docked.
Original CL: http://http://codereview.chromium.org/2856066/show

Review URL: http://codereview.chromium.org/3058020
------------------------------------------------------------------------
r53937 | tfarina@chromium.org | 2010-07-28 16:18:03 +0200 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.h

gtk: Make use of the gtk signal macro in HtmlDialogGtk class.

BUG=None
TEST=manually and trybots.

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3069001
------------------------------------------------------------------------
r53936 | msneck@google.com | 2010-07-28 15:59:41 +0200 (Wed, 28 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_loader.sb
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer.sb

Fully remove the hole in the Mac Sandbox that was used to support
Native Client.  This removes the special sandbox commands as well
as all special code.

This CL replaces http://codereview.chromium.org/2881016/show which
was rolled back because of problems on Mac OS X 10.5.  Those problems
were addressed in Native Client and pulled into Chrome with a DEPS
file update in http://codereview.chromium.org/2881034/show which was
committed as Chrome revision 53711.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=344
TEST=all tests pass, including nacl_ui_tests

Review URL: http://codereview.chromium.org/3077003
------------------------------------------------------------------------
r53933 | andreip@chromium.org | 2010-07-28 14:05:41 +0200 (Wed, 28 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc

Use vector::push_back() to add object store names to the vector of names and avoid a crash

Review URL: http://codereview.chromium.org/3031026
------------------------------------------------------------------------
r53924 | bauerb@chromium.org | 2010-07-28 10:31:30 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Move click-to-play behind the --enable-click-to-play switch.

BUG=50086
TEST=none

Review URL: http://codereview.chromium.org/3074005
------------------------------------------------------------------------
r53923 | darin@chromium.org | 2010-07-28 10:04:45 +0200 (Wed, 28 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/redirect_to_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/webkit/glue/plugins/pepper_url_loader.cc
   M /trunk/src/webkit/glue/plugins/pepper_url_loader.h
   M /trunk/src/webkit/glue/plugins/pepper_url_response_info.cc

Initial stream to file implementation.

This patch excludes one important detail.  This code does not cleanup temp
files yet.  That will be added in a subsequent CL.

R=brettw
BUG=49789
TEST=third_party/ppapi/tests/test_url_loader.cc:TestStreamToFile

Review URL: http://codereview.chromium.org/2806079
------------------------------------------------------------------------
r53921 | hbono@chromium.org | 2010-07-28 09:08:53 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm

An experimental fix for Bug 49590.
This change just releases the BalloonController objects used in the tests. (This change does not use autorelease since I'm not sure if we can call autorelease before initializing an NSObject.)

BUG=49590
TEST=make the "Chromium Mac (valgrind)" bot greener.
Review URL: http://codereview.chromium.org/2808056
------------------------------------------------------------------------
r53920 | dpolukhin@chromium.org | 2010-07-28 09:08:04 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h

Hide feedback button on login screen.

BUG= crosbug.com/4980
TEST=Observe no feedback button on login screen.

Review URL: http://codereview.chromium.org/3023020
------------------------------------------------------------------------
r53919 | chocobo@chromium.org | 2010-07-28 09:03:55 +0200 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/internet_options_handler.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_internet_network_list.js
   A /trunk/src/chrome/browser/resources/options/chromeos_internet_options.html
   A /trunk/src/chrome/browser/resources/options/chromeos_internet_options.js
   A /trunk/src/chrome/browser/resources/options/chromeos_internet_options_page.css
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Port network options to DOM UI. Hook up all the functionality. UI touchup work will be in another changelist.
BUG=chromium-os:4744
BUG=49030
TEST=manual
Review URL: http://codereview.chromium.org/3036020
------------------------------------------------------------------------
r53918 | satorux@chromium.org | 2010-07-28 09:02:49 +0200 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_mozc_options.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc

Add remaining stuff for Mozc configuration DOMUI.

This still lacks "Reset to default" button which original
configuration dialog has, but all configuration items
are implemented.

Review URL: http://codereview.chromium.org/3043023
Patch from Takayoshi Kochi <kochi@chromium.org>.
------------------------------------------------------------------------
r53915 | satorux@chromium.org | 2010-07-28 08:40:32 +0200 (Wed, 28 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Add logic to save input method preference based on user clicks.

Along the way, add some sanity check code in language_options_list.js
to filter bad language codes, just in case.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3051013
------------------------------------------------------------------------
r53913 | cmasone@google.com | 2010-07-28 07:54:35 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.h

Make login cancel logic load localaccount file before attempting offline login

BUG=chromium-os:5169
TEST=unit tests

Review URL: http://codereview.chromium.org/2847080
------------------------------------------------------------------------
r53912 | jrg@chromium.org | 2010-07-28 07:48:31 +0200 (Wed, 28 Jul 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm

Pulse new bookmarks (as triggered by bookmark bubble).  If not possible, 
pulse the topmost parent that is visible (e.g. "Other Bookmarks").

BUG=http://crbug.com/42028

TEST=\
Repeat this test with the following themes:
1) None, 2) Maria Carey, 3) Ocean Pacific, 4) American Apparel:
.
New profile.  Click star to 'mark something.  See bookmark pulse in bar.  Cancel.
Do that again, but set parent to "Other Bookmarks" and hit OK.
New page; click star.  Default parent is Other Bookmarks; see Other Bookmarks folder pulse.
Add enough bookmarks on bar so something falls in overflow menu (chevron appears).
Go to one of them, then click star.  (You can't see chevron pulse.. it's hidden.)
Create a folder.  Add a bookmark to the folder.  Go that page.
Click on star; see folder pulse.


Review URL: http://codereview.chromium.org/2805099
------------------------------------------------------------------------
r53902 | kkanetkar@chromium.org | 2010-07-28 05:14:37 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/common/appcache/appcache_backend_proxy.cc
   M /trunk/src/chrome/common/appcache/appcache_backend_proxy.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.cc
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.h
   M /trunk/src/webkit/appcache/appcache.cc
   M /trunk/src/webkit/appcache/appcache.h
   M /trunk/src/webkit/appcache/appcache_backend_impl.cc
   M /trunk/src/webkit/appcache/appcache_backend_impl.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host.h
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_service.h
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Chrome side of changes required to populate appcache resource list.

BUG = 2821005
TEST = Manually navigate.

Review URL: http://codereview.chromium.org/3009005
------------------------------------------------------------------------
r53894 | ziadh@chromium.org | 2010-07-28 03:29:41 +0200 (Wed, 28 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Refactor declaration order for 2 A/B tests.

Rearranged the declaration order for probability groups contained in 2 A/B
tests in a way that preserves the remaining probability space to the default
value, after the other groups receive an equal share of the sample space.

BUG=50451
r=jar


Review URL: http://codereview.chromium.org/3080004
------------------------------------------------------------------------
r53889 | michaeln@chromium.org | 2010-07-28 03:13:56 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launched_animation_win.cc

Fix a NULL ptr dereference crash. Happens when launching an "app" with no icon.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2832086
------------------------------------------------------------------------
r53888 | pkasting@chromium.org | 2010-07-28 03:09:00 +0200 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/back_mask.png
   D /trunk/src/chrome/app/theme/button_mask.png
   D /trunk/src/chrome/app/theme/forward_mask.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Remove button masks for toolbar buttons, which will no longer be needed in the new theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3063011
------------------------------------------------------------------------
r53887 | pkasting@chromium.org | 2010-07-28 03:07:28 +0200 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Swap reload and home back to how they were in Chrome <= 5.

BUG=50107
TEST=Reload should be left of home
Review URL: http://codereview.chromium.org/3056023
------------------------------------------------------------------------
r53884 | yusukes@google.com | 2010-07-28 02:58:54 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

Fix memory leak in chrome/browser/chromeos/input_method/input_method_util.cc.

BUG=chromium-os:50332
TEST=git try -b linux_chromeos_valgrind.

Review URL: http://codereview.chromium.org/2868070
------------------------------------------------------------------------
r53883 | suzhe@chromium.org | 2010-07-28 02:57:47 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc

Mark BrowserKeyEventsTest.ReservedAccelerators flaky on Mac.

BUG=50447
TEST=none

Review URL: http://codereview.chromium.org/3033034
------------------------------------------------------------------------
r53881 | satorux@chromium.org | 2010-07-28 02:41:27 +0200 (Wed, 28 Jul 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_mozc_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_mozc_options.html
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Add Mozc (Japanese IME) configuration DOM UI skeleton.
This only includes boolean settings in the dialog.
I will fill in other stuff in later CLs.

BUG=chromium-os:4809
TEST=manually check on the netbook by uncommenting TODO lines.

Review URL: http://codereview.chromium.org/3067006
Patch from Takayoshi Kochi <kochi@chromium.org>.
------------------------------------------------------------------------
r53879 | dhollowa@chromium.org | 2010-07-28 02:31:48 +0200 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFill Assert with AutoFillManager unique ids and Credit Card filling

Changes unique id matching that happens between browser and renderer.  Unique ids sent between processes are now combined in the case where credit card and address combination suggestions are supplied to popup.

BUG=50264
TEST=AutoFillManagerTest.FillCreditCardForm, AutoFillManagerTest.FillNonBillingFormSemicolon, AutoFillManagerTest.FillBillFormSemicolon

Review URL: http://codereview.chromium.org/3039031
------------------------------------------------------------------------
r53876 | tony@chromium.org | 2010-07-28 02:15:01 +0200 (Wed, 28 Jul 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_request_slow_download_job.cc

Fix ReadRawData to make the job state match the return value.

The comment for ReadRawData reads:
  // If returning true, data was read from the job.  buf will contain
  // the data, and bytes_read will receive the number of bytes read.
...
  // If returning false, an error occurred or an async IO is now pending.
  // If async IO is pending, the status of the request will be
  // URLRequestStatus::IO_PENDING, and buf must remain available until the
  // operation is completed.  See comments on URLRequest::Read for more info.

I interpret this to mean that an implementer should never set status to IO_PENDING and return true, but that's what the slow download job does:
...
    SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
    DCHECK(!is_done());
    return true;
...

Unfortunately this class is part of the Download UI tests which are already flaky/broken so it's not possible to verify that this change doesn't further break those tests. But the current implementation is clearly broken and should be fixed.

BUG=50399
TEST=ran ui_tests, verified no additional breakage

Review URL: http://codereview.chromium.org/3052016
------------------------------------------------------------------------
r53873 | erg@google.com | 2010-07-28 02:09:54 +0200 (Wed, 28 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/base/base.gypi
   A /trunk/src/base/ref_counted_memory.cc
   M /trunk/src/base/ref_counted_memory.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Speculative fix for crash in DOMUIThumbnailSource.

DOMUIThumbnailSource objects are deleted on the IO thread, while they are used
on the UI thread. The DataSource documentation says that they should not live
on the IO thread, but for almost all DataSources, the only reference held is
the one by ChromeURLDataManager, which lives on the IO thread. Since I had a racy
stack where the object was being used on the UI thread while its destructor was
running on the IO thread, forcing destruction on the UI thread should fix
the crash.

Pretty much everything but changing the templated base class of DataSource to
always DeleteOnUIThread is my usual cleanup.

BUG=34115
TEST=none

Review URL: http://codereview.chromium.org/3061009
------------------------------------------------------------------------
r53871 | nick@chromium.org | 2010-07-28 02:04:17 +0200 (Wed, 28 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc

Sync: set BASE_VERSION to entry.version() instead of 0 when changing
IDs, but also force IS_UNAPPLIED.

This allows BV to be valid in case the item is marked UNSYNCED and later commits,
but still allows the update application to proceed if it's not.

BUG=49715
TEST=See bug

Review URL: http://codereview.chromium.org/3054021
------------------------------------------------------------------------
r53870 | mirandac@google.com | 2010-07-28 02:03:38 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc

Add new search engine logos to template url data.  This CL also reorganizes the way logos and search engine type data are stored.  Because the search engine dialog is no longer an experiment running on few locales, move the data and logos into the template_url_prepopulate_data for each search engine.

BUG=42612
TEST=search engine dialog works as expected.

Review URL: http://codereview.chromium.org/3040022
------------------------------------------------------------------------
r53868 | pkasting@chromium.org | 2010-07-28 02:03:06 +0200 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.cc

Remove support for background masks.  These are no longer necessary in the new theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/2847079
------------------------------------------------------------------------
r53866 | suzhe@chromium.org | 2010-07-28 01:30:13 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc

Fix compile warning on Mac OS X 10.5

BUG=none
TEST=Make sure interactive_ui_tests can build on OS X 10.5 correctly.

Review URL: http://codereview.chromium.org/3046027
------------------------------------------------------------------------
r53862 | scherkus@chromium.org | 2010-07-28 00:57:21 +0200 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/central_roster.html

Fixing CSS and switching over to DOM properties for central_roster.html.

BUG=none
TEST=should work exactly the same

Review URL: http://codereview.chromium.org/3069006
------------------------------------------------------------------------
r53857 | stuartmorgan@chromium.org | 2010-07-28 00:19:31 +0200 (Wed, 28 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js

Revert 53849 - Implement most of the startup page controls in DOMUI prefs

Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs.
Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed.

BUG=48713
TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs.

Review URL: http://codereview.chromium.org/3046025

TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/3058018
------------------------------------------------------------------------
r53854 | victorw@chromium.org | 2010-07-27 23:43:14 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable DevToolsSanityTest.TestPauseWhenScriptIsRunning which fails on linux.
This could be caused by http://trac.webkit.org/changeset/64124/trunk.
Created a bug and assigned to pfeldman to investigate.

TBR=pfeldman
BUG=50416
TESt=unit test passes

------------------------------------------------------------------------
r53849 | stuartmorgan@chromium.org | 2010-07-27 23:31:31 +0200 (Tue, 27 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js

Implement most of the startup page controls in DOMUI prefs

Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs.
Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed.

BUG=48713
TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs.

Review URL: http://codereview.chromium.org/3046025
------------------------------------------------------------------------
r53848 | sanjeevr@chromium.org | 2010-07-27 23:31:28 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_updater.cc

Disabled internal PDF by default.
BUG=None
TEST=Verify that the internal PDF plugin is disabled by default.s

Review URL: http://codereview.chromium.org/3052015
------------------------------------------------------------------------
r53847 | pkasting@chromium.org | 2010-07-27 23:29:06 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_win.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc
   M /trunk/src/chrome/browser/views/wrench_menu.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h

Add "pushed" as a state a TextButton can show (alongside "normal" and "hover").

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3058011
------------------------------------------------------------------------
r53846 | rafaelw@chromium.org | 2010-07-27 23:28:26 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Rename ExternalProtocolHandler::OnUserGesture -> PermitLaunchUrl & call from EFD::HandleRequest.

Extension functions should be allowed to make repeat requests to external protocol handling without needing a user gesture (see bug). This allows them to do so (and changes the method name for clarity).

BUG=39178
TEST=NONE

Review URL: http://codereview.chromium.org/2884040
------------------------------------------------------------------------
r53845 | dhollowa@chromium.org | 2010-07-27 23:26:16 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/options_util.cc

Reset to defaults failed to reset the Autofill/Mac/Address Book card preference

Adds awareness of kAutoFillAuxiliaryProfilesEnabled preference to |OptionsUtil::ResetToDefaults()|, which is used to reset preferences from the "Under the Hood" / "Reset to Defaults" button.

BUG=49873
TEST=AutoFillManagerTest.AuxiliaryProfilesReset

Review URL: http://codereview.chromium.org/3054019
------------------------------------------------------------------------
r53844 | estade@chromium.org | 2010-07-27 23:24:39 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/net/base/filter.cc

Treat multiple extensions like .tar.gz as a single extension.

The logic is taken from firefox.

BUG=48346
TEST=unit tests; downloading the same .tar.gz file multiple times (see bug)

Review URL: http://codereview.chromium.org/3018011
------------------------------------------------------------------------
r53843 | evan@chromium.org | 2010-07-27 23:22:51 +0200 (Tue, 27 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h

Fix comment that refers to non-existent ReloadAll function (it got renamed
during the review of r49350).

BUG=none
TEST=recompiled

Patch from Mihai Parparita <mihaip@chromium.org>.

Review URL: http://codereview.chromium.org/2854060
------------------------------------------------------------------------
r53842 | pkasting@chromium.org | 2010-07-27 23:19:01 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc

Mirror wrench menu corner alignment in RTL mode.

BUG=50107
TEST=Run chrome --lang=he, click the wrench; the button and dropdown should align on the left edge, not the right.
Review URL: http://codereview.chromium.org/3017033
------------------------------------------------------------------------
r53841 | pkasting@chromium.org | 2010-07-27 23:18:10 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_actions_container_browsertest.cc

Cleanup: Remove pointless GetInsets() override.  Simplify |container_size_| to just be |container_width_|.  Fix indenting/alignment, especially of function parameters.  L"" -> std::wstring().  Don't handle assertion violations (style guide/simplicity).  Reduce indenting via early-return or simpler-path-return.  Streamline code where possible.  Definition order should match declaration order.  EXPECT_STREQ -> EXPECT_EQ.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3076001
------------------------------------------------------------------------
r53840 | suzhe@chromium.org | 2010-07-27 23:17:57 +0200 (Tue, 27 Jul 2010) | 27 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/keyboard_code_conversion_gtk.cc
   A /trunk/src/base/keyboard_code_conversion_mac.h
   A /trunk/src/base/keyboard_code_conversion_mac.mm
   M /trunk/src/chrome/browser/automation/ui_controls.h
   A /trunk/src/chrome/browser/automation/ui_controls_internal.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/data/keyevents_test.html
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/ui_test_utils_linux.cc
   D /trunk/src/chrome/test/ui_test_utils_mac.cc
   A /trunk/src/chrome/test/ui_test_utils_mac.mm
   M /trunk/src/chrome/test/ui_test_utils_win.cc

[Mac]Port browser_keyevents_browsertest.cc and browser_focus_uitest.cc to Mac.

This CL includes:
1. Implementation of ui_test_utils_mac.mm
2. Fix for ui_controls_mac.mm
3. Port browser_keyevents_browsertest.cc to Mac and add some new tests for Mac.
4. Partially port browser_focus_uitest.cc to Mac, now can be compiled and run
on Mac but some tests fail.
5. Add two functions into ui_test_utils.h: HideNativeWindow() and
ShowAndFocusNativeWindow(). The latter one shows a window and grabs the input
focus, which is useful for tests depending on fake keyboard/mouse events.

Because browser_keyevents_browsertests.cc and browser_focus_uitest.cc
belong to interactive_ui_tests, which is not available on Mac (see
http://crbug.com/21276), in order to test them on Mac, you may want to
move them into browser_tests locally. But it won't work on build and try
bots, because these tests must be run with screen unlocked.

This CL depends on CL: http://codereview.chromium.org/2973004
and http://codereview.chromium.org/2805075

BUG=22515 Keyboard handling needs unit tests
BUG=48671 interactive_ui_test: BrowserKeyEventsTest.NormalKeyEvents is flaky
BUG=48936 Browser window is opened inactivated when running an InProcessBrowserTest.
TEST=none

Review URL: http://codereview.chromium.org/2986004
------------------------------------------------------------------------
r53839 | akalin@chromium.org | 2010-07-27 23:14:33 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/jingle/jingle.gyp
   D /trunk/src/jingle/notifier/communicator/auto_reconnect.cc
   D /trunk/src/jingle/notifier/communicator/auto_reconnect.h
   M /trunk/src/jingle/notifier/communicator/connection_options.cc
   M /trunk/src/jingle/notifier/communicator/connection_options.h
   M /trunk/src/jingle/notifier/communicator/login.cc
   M /trunk/src/jingle/notifier/communicator/login.h
   M /trunk/src/jingle/notifier/communicator/login_connection_state.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc

Rewrote handing of auto-reconnection and network changes for sync notifier.

BUG=47883
TEST=manual (turning network connection off and on)

Review URL: http://codereview.chromium.org/2809056
------------------------------------------------------------------------
r53833 | thakis@chromium.org | 2010-07-27 22:21:55 +0200 (Tue, 27 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc

Mac: Add "Show Tab Overview" menu item.

xib changes: Add menu item with shortcut cmd-f10 for now, connect it to -commandDispatch:. Connect app controller's new outlet to the new menu item.

BUG=50307
TEST=No changes by default. If --enable-expose-for-tabs is passed, a new menu item should be visible below "prev tab" in the window menu. It should be active for normal browser windows and fullscreen windows, but not if there are no browser windows around or if the current window is a popup window or a non-browser window (e.g. prefs). Clicking the menu item doesn't do anything yet. cmd-f10 should trigger the menu item, but it shouldn't if the cmdline flag isn't passed.
TEST2=Go to a page that is busy spinning some javascript (e.g. "javascript:while(1);"), give it focus, hit cmd-f10. Menu should blink immediately.

Review URL: http://codereview.chromium.org/3020035
------------------------------------------------------------------------
r53832 | ziadh@chromium.org | 2010-07-27 22:13:51 +0200 (Tue, 27 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

We would like to refine the numbers we started off with in the first experiment (then set to [4, 6, 8, 16] connections -- see http://codereview.chromium.org/2658006). Overall, 16 connections did not compare favorably to either 6 or 8 connections. At this point we'd like to modify and narrow down our range to span 5 to 9 connections.


r=jar
BUG=44491

Review URL: http://codereview.chromium.org/3077001
------------------------------------------------------------------------
r53827 | dmazzoni@chromium.org | 2010-07-27 21:57:25 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Add keyboard shortcuts for next/previous pane on Chrome OS, and fix
alphabetization. Note that the F1 key is the "Back" key on Chrome OS,
and F2 is "Forwards".

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2878059
------------------------------------------------------------------------
r53826 | shess@chromium.org | 2010-07-27 21:57:24 +0200 (Tue, 27 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm

[Mac] Elide long Omnibox contents.

Doing the most simple eliding, which is to truncate and replace with
ellipses on a character basis.  I put this in the code rather than the
.xib because this seems like it should be a hard-wired Omnibox
behavior.

BUG=50253
TEST=Put in a very long URL and check that it elides as the window gets too small for it to fit.  You can easily craft long URLs by adding # and filling with whatever you desire after that.

Review URL: http://codereview.chromium.org/3010031
------------------------------------------------------------------------
r53824 | sanjeevr@chromium.org | 2010-07-27 21:46:04 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/menus/button_menu_item_model.cc
   M /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h

Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands.

BUG=None.
TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled.

Review URL: http://codereview.chromium.org/3026025
------------------------------------------------------------------------
r53823 | viettrungluu@chromium.org | 2010-07-27 21:45:23 +0200 (Tue, 27 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Update a suppression (and add a comment) for crbug.com/20504.

BUG=20504
TEST=greener valgrind
TBR=evan@chromium.org,mark@chromium.org

Review URL: http://codereview.chromium.org/3020036
------------------------------------------------------------------------
r53821 | dhg@chromium.org | 2010-07-27 21:35:08 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Creating download directory on chromeos when its registered as the default download directory.

BUG=4994
TEST=none
Review URL: http://codereview.chromium.org/3043024
------------------------------------------------------------------------
r53820 | darin@chromium.org | 2010-07-27 21:28:12 +0200 (Tue, 27 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

Fix unit tests for the ResourceDispatcherHost.

A field of the ViewHostMsg_Resource_Request structure was uninitialized.

Also, includes a fix for an ASSERT_EQ that listed the expected value second
instead of first.

R=oshima
BUG=50002
TEST=none

Review URL: http://codereview.chromium.org/3052014
------------------------------------------------------------------------
r53808 | phajdan.jr@chromium.org | 2010-07-27 20:16:39 +0200 (Tue, 27 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Download code cleanup:

- make the code more object-oriented, make the object expose less accessors
- make some parts of code look more obvious, use existing helpers
- make the public interfaces slightly better (less ctor parameters)
- make some names slightly better

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3029025
------------------------------------------------------------------------
r53807 | stuartmorgan@chromium.org | 2010-07-27 20:14:29 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.cc
   A /trunk/src/chrome/browser/dom_ui/search_engine_manager_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   A /trunk/src/chrome/browser/resources/options/search_engine_manager.html
   A /trunk/src/chrome/browser/resources/options/search_engine_manager.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI prefs: Add stub sub-page for search engine management

BUG=49091
TEST='Manage' button in DOMUI Basics prefs should bring up an empty sub-page.

Review URL: http://codereview.chromium.org/2806081
------------------------------------------------------------------------
r53804 | mirandac@google.com | 2010-07-27 19:56:07 +0200 (Tue, 27 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert bookmark bar promo CL, r52993

TBR: arv

BUG=49328
TEST=no bookmark bar promo on first run to empty profile.  or ever.
Review URL: http://codereview.chromium.org/3053015
------------------------------------------------------------------------
r53801 | viettrungluu@chromium.org | 2010-07-27 19:37:38 +0200 (Tue, 27 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_posix.cc

Add a comment about a leak/suppression.

BUG=29675
TEST=none
TBR=evan@chromium.org,willchan@chromium.org

Review URL: http://codereview.chromium.org/2884041
------------------------------------------------------------------------
r53799 | akalin@chromium.org | 2010-07-27 19:21:02 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/DEPS
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h

Made CacheInvalidationPacketHandler aware of XmppClient state changes.

This is a speculative/defensive fix for bug 49274.

BUG=49274
TEST=manual (checked that this didn't break normal behavior)

Review URL: http://codereview.chromium.org/3054018
------------------------------------------------------------------------
r53796 | nshkrob@chromium.org | 2010-07-27 19:05:37 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Fix the pinning algorithm so that pinned URLs are not shifted during insertions and deletions.

BUG=none
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/3039029
------------------------------------------------------------------------
r53791 | alyssad@chromium.org | 2010-07-27 18:35:42 +0200 (Tue, 27 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/translate.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New pyauto hook for the translate feature.

Review URL: http://codereview.chromium.org/3026016
------------------------------------------------------------------------
r53790 | cbentzel@chromium.org | 2010-07-27 18:35:26 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/spdy/spdy_network_transaction.cc

Remove --testing-fixed-http-port and --testing-fixed-https-port.

--host-rules seems like a reasonable enough substitute for these two command line flags, and removing them will simplifies the fairly complicated URL rewrite logic in HttpNetworkTransaction.

BUG=None
TEST=built and ran net_unittests

Review URL: http://codereview.chromium.org/3041019
------------------------------------------------------------------------
r53789 | cmasone@google.com | 2010-07-27 17:50:22 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Make canceled login fail over to offline, instead of just failing

Also, increase login timeout.

BUG=None
TEST=unit tests

Review URL: http://codereview.chromium.org/3061019
------------------------------------------------------------------------
r53785 | rsesek@chromium.org | 2010-07-27 16:22:14 +0200 (Tue, 27 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

When the kChromeUIScheme was made savable, it also broke the disabling of the
encoding menu on those pages.

BUG=48157
TEST=On the NTP, Wrench menu --> Tools --> Encoding is disabled. On normal web pages, it isn't.

Review URL: http://codereview.chromium.org/3027023
------------------------------------------------------------------------
r53783 | viettrungluu@chromium.org | 2010-07-27 15:55:21 +0200 (Tue, 27 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_posix.cc
   A /trunk/src/chrome/browser/browser_main_posix.h
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

BrowserMain() refactoring, part 2.

Add "MainMessageLoopStart()" and related platform methods to handle tasks
directly tied to the start of the main message loop.

BUG=none
TEST=everything still works

Review URL: http://codereview.chromium.org/2931007
------------------------------------------------------------------------
r53779 | pfeldman@chromium.org | 2010-07-27 15:08:26 +0200 (Tue, 27 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc

DevTools: close remote debugging connection on IO thread when inspected tab closes.

Review URL: http://codereview.chromium.org/3043020
------------------------------------------------------------------------
r53775 | dpolukhin@chromium.org | 2010-07-27 13:15:18 +0200 (Tue, 27 Jul 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   A /trunk/src/chrome/browser/chromeos/login/string_fetcher.cc
   A /trunk/src/chrome/browser/chromeos/login/string_fetcher.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   D /trunk/src/chrome/browser/chromeos/testdata/services_manifest.json
   D /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Put back 53641 - Landing OEM customization CL for Denis

Original CL http://codereview.chromium.org/3026006

Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.

BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.

Review URL: http://codereview.chromium.org/3064002

TBR= nkostylev@chromium.org

Review URL: http://codereview.chromium.org/2878056
------------------------------------------------------------------------
r53773 | jeremy@chromium.org | 2010-07-27 12:54:03 +0200 (Tue, 27 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Mac: Add nice fade effect to overflowing bookmark buttons in the bookmark bar

Port magic from GTMFadeTruncatingTextFieldCell ?\016to Chrome's GradientButtonCell, used by buttons in the bookmark bar.  Any button that inherits from this class will now get overflowing titles truncated with a nice gradient (same as tab titles), rather than the default ellipsis.

Using GTMFadeTruncatingTextFieldCell in this case wasn't feasible because bookmark buttons are subclasses of NSButtonCell and already use a bunch of specialized behavior provided by it.

BUG=45104
TEST=Add a bookmark to the bookmark bar and increase the length of it's title.  Once you get past a certain length, rather than truncate the title should fade out nicely.  Exactly in the same way long tab titles do.  Bookmark buttons with titles that aren't truncated should look exactly the same. Also test with Dolce & Gabbana theme which has inverted contrast.

Review URL: http://codereview.chromium.org/2806066
------------------------------------------------------------------------
r53770 | mnissler@chromium.org | 2010-07-27 12:45:49 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/pref_service.cc

Create factories for policy pref stores.

BUG=None
TEST=Tests that use a regular PrefService are green.

Review URL: http://codereview.chromium.org/3046023
------------------------------------------------------------------------
r53768 | nkostylev@google.com | 2010-07-27 12:08:20 +0200 (Tue, 27 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/web_page_view.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/resources/host_registration_page.html
   A /trunk/src/chrome/test/data/register_form.html

Add API on host registration page.
Add test register form page.
Added extra debug logging.

Full cycle:
1. Register screen navigates to chrome://register (host page).
2. host page requests DOMUI for register form URL: getRegistrationUrl msg on DOM load event.
3. Once URL is received it is loaded in an iframe.
4. When register form is loaded it sends get_user_info msg via postMessage to host page.
5. host page requests DOMUI for system/user info: getUserInfo msg.
6. Once info is received host page sends that to an iframe with set_user_info msg.
7. Register form notifies host page on registration success/skip status with complete_registration msg.
8. Based on registration result host page navigates to cros://register/[success|skipped] so that Out of box wizard is notified.

BUG= http://crosbug.com/4813
TEST=manual

Review URL: http://codereview.chromium.org/3058006
------------------------------------------------------------------------
r53764 | yusukes@google.com | 2010-07-27 11:43:59 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/language_preferences_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Implement the "Configure modifier keys" drop-down which enables users to swap Alt/Ctrl keys and Search/Ctrl keys.

BUG=chromium-os:2636
TEST=manually on eeepc

Review URL: http://codereview.chromium.org/3038025
------------------------------------------------------------------------
r53758 | satorux@chromium.org | 2010-07-27 07:54:13 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

Add missing resource IDs for keyboard layouts.

TEST=confirmed that the layout names added in generated_resource.grd appear in the languages and input dialog. also confirmed that error messages are gone from logs.
BUG=chromium-os:3440

Review URL: http://codereview.chromium.org/3063007
------------------------------------------------------------------------
r53757 | ananta@chromium.org | 2010-07-27 07:00:24 +0200 (Tue, 27 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

ChromeFrame cookie requests would incorrectly get routed to the first host browser connected to the renderer. This basically
meant that if the browser process exited then other popups could not query cookies from the host.

Part of the fix for http://b/issue?id=2277519

Bug=2277519

Review URL: http://codereview.chromium.org/3066004
------------------------------------------------------------------------
r53753 | satorux@chromium.org | 2010-07-27 05:27:30 +0200 (Tue, 27 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_options_util.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_pinyin_options.html

Add Simplified Chinese (Pinyin) input method DOMUI configuration.
Move utility functions into a header file (currently chewing and pinyin
are the customers).

TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4808

Review URL: http://codereview.chromium.org/3015028
Patch from Takayoshi Kochi <kochi@chromium.org>.
------------------------------------------------------------------------
r53752 | yusukes@google.com | 2010-07-27 05:23:47 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_keyboard_library.h

Support chromeos::RemapModifierKeys API.

BUG=chromium-os:2636
TEST=manually on eeepc, ran the browser_tests

Review URL: http://codereview.chromium.org/2806077
------------------------------------------------------------------------
r53741 | pkasting@chromium.org | 2010-07-27 03:48:29 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h

Cleanup: Rename gtk button state names to (a) match other platforms and (b) not be misleading (e.g. "depressed" where it should be "disabled").  Better indenting.  Inline a function that has only one caller for simplicity.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3029032
------------------------------------------------------------------------
r53740 | pkasting@chromium.org | 2010-07-27 03:47:01 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Make the throbber and tab close button correctly respond to theme changes.  This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless).

BUG=50107
TEST=Throbber responds to theme changes
Review URL: http://codereview.chromium.org/3064006
------------------------------------------------------------------------
r53739 | pkasting@chromium.org | 2010-07-27 03:46:50 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Cleanup: Remove dead code (was only called when we had app + page menus).  Nicer indenting.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3073002
------------------------------------------------------------------------
r53737 | satorux@chromium.org | 2010-07-27 03:41:59 +0200 (Tue, 27 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.js

Display the language name and the input method list dynamically.

Before this change, the language name and the input method list were
hard-coded in the HTML file. With this change, these values will be
displayed based on the underlying data from C++ world.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3008016
------------------------------------------------------------------------
r53736 | pkasting@chromium.org | 2010-07-27 03:39:13 +0200 (Tue, 27 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.cc
   M /trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_view.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/window/non_client_view.cc

Make theme change notifications auto-propagate through the view hierarchy, instead of forcing subclasses to manually call their superclass implementation.  This fixes some problems where not all views would get notified of a theme change.

Make naming for theme and locale changes consistent and clear.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/2878055
------------------------------------------------------------------------
r53733 | pkasting@chromium.org | 2010-07-27 03:00:51 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/omnibox_history_dark_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_history_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_http_dark_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_http_transparent.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

Remove IDR_OMNIBOX_*_TRANSPARENT images.  The comments for why we need them are out-of-date -- the normal images no longer have white backgrounds, and we don't need an extra "transparent" set.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3075001
------------------------------------------------------------------------
r53732 | pkasting@chromium.org | 2010-07-27 03:00:27 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/resize_gripper.png
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   A /trunk/src/views/controls/resize_area.cc (from /trunk/src/views/controls/resize_gripper.cc:53545)
   A /trunk/src/views/controls/resize_area.h (from /trunk/src/views/controls/resize_gripper.h:53731)
   D /trunk/src/views/controls/resize_gripper.cc
   D /trunk/src/views/controls/resize_gripper.h
   M /trunk/src/views/views.gyp

Make the resize gripper invisible.

BUG=50107
TEST=Resize gripper nest to browser actions container should no longer appear
Review URL: http://codereview.chromium.org/3052011
------------------------------------------------------------------------
r53729 | zelidrag@chromium.org | 2010-07-27 02:47:12 +0200 (Tue, 27 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/chromeos/DEPS
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   A /trunk/src/cros
   A /trunk/src/cros/cros_api.gyp

Checking in http://codereview.chromium.org/2806070 and http://codereview.chromium.org/3028018 on behalf of zbehan@.

third_party: add a stub cros directory and cros_api.gyp for libcros to satisfy gyp depdendencies
cros: fix more of the third_party includes, forbid similar includes for future

BUG=none
TEST=make sure both chrome and chromeos builds are happy.
TBR=zelidrag
 
Review URL: http://codereview.chromium.org/3035021
------------------------------------------------------------------------
r53723 | feldstein@chromium.org | 2010-07-27 02:20:56 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_accessibility.h
   M /trunk/src/chrome/browser/cocoa/browser_accessibility.mm
   M /trunk/src/chrome/browser/cocoa/browser_accessibility_delegate.h
   M /trunk/src/chrome/browser/cocoa/browser_accessibility_unittest.mm

Readability review for Obj-C for feldstein

Readibility review code using the cocoa browser accessibility stuff for
objective c

Review URL: http://codereview.chromium.org/2951011
------------------------------------------------------------------------
r53722 | csilv@chromium.org | 2010-07-27 02:19:48 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.cc

Remove observer from BrowsingDataRemover on destruct.

BUG=49037
TEST=Close clear browser data overlay dialog during clear operation.
Review URL: http://codereview.chromium.org/2873067
------------------------------------------------------------------------
r53721 | scherkus@chromium.org | 2010-07-27 02:19:19 +0200 (Tue, 27 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Fix acquisition of thumbnail images on Linux.

Patch by jwillcox@litl.com:
http://codereview.chromium.org/2904010/show

BUG=48066
TEST=Load a page from new tab page, then ensure the thumbnail is updated by viewing the new tab page again
------------------------------------------------------------------------
r53716 | thakis@chromium.org | 2010-07-27 01:08:24 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/active_window_watcher_x.h
   M /trunk/src/app/animation.h
   M /trunk/src/app/animation_container.h
   M /trunk/src/app/app_paths.h
   M /trunk/src/app/app_switches.h
   M /trunk/src/app/bidi_line_iterator.h
   M /trunk/src/app/clipboard/clipboard.h
   M /trunk/src/app/clipboard/clipboard_util_win.h
   M /trunk/src/app/clipboard/scoped_clipboard_writer.h
   M /trunk/src/app/combobox_model.h
   M /trunk/src/app/download_file_interface.h
   M /trunk/src/app/drag_drop_types.h
   M /trunk/src/app/gfx/font_util.h
   M /trunk/src/app/gfx/gl/gl_bindings.h
   M /trunk/src/app/gfx/gl/gl_context.h
   M /trunk/src/app/gfx/gl/gl_context_egl.h
   M /trunk/src/app/gfx/gl/gl_context_osmesa.h
   M /trunk/src/app/gfx/gl/gl_context_stub.h
   M /trunk/src/app/gfx/gl/gl_implementation.h
   M /trunk/src/app/gfx/gl/gl_interface.h
   M /trunk/src/app/gfx/gl/gl_mock.h
   M /trunk/src/app/gtk_dnd_util.h
   M /trunk/src/app/gtk_integers.h
   M /trunk/src/app/gtk_signal.h
   M /trunk/src/app/gtk_signal_registrar.h
   M /trunk/src/app/gtk_util.h
   M /trunk/src/app/hi_res_timer_manager.h
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_collator.h
   M /trunk/src/app/l10n_util_mac.h
   M /trunk/src/app/l10n_util_win.h
   M /trunk/src/app/linear_animation.h
   M /trunk/src/app/menus/accelerator.h
   M /trunk/src/app/menus/accelerator_cocoa.h
   M /trunk/src/app/menus/accelerator_gtk.h
   M /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/app/menus/menu_model.h
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/app/message_box_flags.h
   M /trunk/src/app/multi_animation.h
   M /trunk/src/app/os_exchange_data.h
   M /trunk/src/app/os_exchange_data_provider_gtk.h
   M /trunk/src/app/os_exchange_data_provider_win.h
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/scoped_handle_gtk.h
   M /trunk/src/app/slide_animation.h
   M /trunk/src/app/sql/connection.h
   M /trunk/src/app/sql/diagnostic_error_delegate.h
   M /trunk/src/app/sql/init_status.h
   M /trunk/src/app/sql/meta_table.h
   M /trunk/src/app/sql/statement.h
   M /trunk/src/app/sql/transaction.h
   M /trunk/src/app/surface/accelerated_surface_mac.h
   M /trunk/src/app/surface/io_surface_support_mac.h
   M /trunk/src/app/surface/transport_dib.h
   M /trunk/src/app/system_monitor.h
   M /trunk/src/app/table_model.h
   M /trunk/src/app/table_model_observer.h
   M /trunk/src/app/test/data/resource.h
   M /trunk/src/app/test_animation_delegate.h
   M /trunk/src/app/test_suite.h
   M /trunk/src/app/text_elider.h
   M /trunk/src/app/theme_provider.h
   M /trunk/src/app/throb_animation.h
   M /trunk/src/app/tree_model.h
   M /trunk/src/app/tree_node_iterator.h
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/app/tween.h
   M /trunk/src/app/win_util.h
   M /trunk/src/app/x11_util.h
   M /trunk/src/app/x11_util_internal.h
   M /trunk/src/base/at_exit.h
   M /trunk/src/base/atomic_ref_count.h
   M /trunk/src/base/atomic_sequence_num.h
   M /trunk/src/base/atomicops.h
   M /trunk/src/base/atomicops_internals_arm_gcc.h
   M /trunk/src/base/atomicops_internals_x86_gcc.h
   M /trunk/src/base/atomicops_internals_x86_macosx.h
   M /trunk/src/base/atomicops_internals_x86_msvc.h
   M /trunk/src/base/auto_reset.h
   M /trunk/src/base/base64.h
   M /trunk/src/base/base_drag_source.h
   M /trunk/src/base/base_drop_target.h
   M /trunk/src/base/base_paths.h
   M /trunk/src/base/base_paths_mac.h
   M /trunk/src/base/base_paths_win.h
   M /trunk/src/base/base_switches.h
   M /trunk/src/base/basictypes.h
   M /trunk/src/base/bits.h
   M /trunk/src/base/callback.h
   M /trunk/src/base/cancellation_flag.h
   M /trunk/src/base/chrome_application_mac.h
   M /trunk/src/base/cocoa_protocols_mac.h
   M /trunk/src/base/command_line.h
   M /trunk/src/base/compat_execinfo.h
   M /trunk/src/base/compiler_specific.h
   M /trunk/src/base/condition_variable.h
   M /trunk/src/base/cpu.h
   M /trunk/src/base/crypto/capi_util.h
   M /trunk/src/base/crypto/cssm_init.h
   M /trunk/src/base/crypto/encryptor.h
   M /trunk/src/base/crypto/rsa_private_key.h
   M /trunk/src/base/crypto/scoped_capi_types.h
   M /trunk/src/base/crypto/scoped_nss_types.h
   M /trunk/src/base/crypto/signature_creator.h
   M /trunk/src/base/crypto/signature_verifier.h
   M /trunk/src/base/crypto/symmetric_key.h
   M /trunk/src/base/data_pack.h
   M /trunk/src/base/debug_on_start.h
   M /trunk/src/base/debug_util.h
   M /trunk/src/base/dir_reader_fallback.h
   M /trunk/src/base/dir_reader_linux.h
   M /trunk/src/base/dir_reader_posix.h
   M /trunk/src/base/eintr_wrapper.h
   M /trunk/src/base/env_var.h
   M /trunk/src/base/event_recorder.h
   M /trunk/src/base/event_synthesis_gtk.h
   M /trunk/src/base/event_trace_consumer_win.h
   M /trunk/src/base/event_trace_controller_win.h
   M /trunk/src/base/event_trace_provider_win.h
   M /trunk/src/base/field_trial.h
   M /trunk/src/base/file_descriptor_posix.h
   M /trunk/src/base/file_descriptor_shuffle.h
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_deprecated.h
   M /trunk/src/base/file_version_info.h
   M /trunk/src/base/file_version_info_mac.h
   M /trunk/src/base/file_version_info_win.h
   M /trunk/src/base/fix_wp64.h
   M /trunk/src/base/float_util.h
   M /trunk/src/base/format_macros.h
   M /trunk/src/base/foundation_utils_mac.h
   M /trunk/src/base/global_descriptors_posix.h
   M /trunk/src/base/gtest_prod_util.h
   M /trunk/src/base/gtk_util.h
   M /trunk/src/base/hash_tables.h
   M /trunk/src/base/histogram.h
   M /trunk/src/base/hmac.h
   M /trunk/src/base/i18n/file_util_icu.h
   M /trunk/src/base/i18n/icu_encoding_detection.h
   M /trunk/src/base/i18n/icu_string_conversions.h
   M /trunk/src/base/i18n/icu_util.h
   M /trunk/src/base/i18n/number_formatting.h
   M /trunk/src/base/i18n/rtl.h
   M /trunk/src/base/i18n/time_formatting.h
   M /trunk/src/base/i18n/word_iterator.h
   M /trunk/src/base/iat_patch.h
   M /trunk/src/base/id_map.h
   M /trunk/src/base/image_util.h
   M /trunk/src/base/json/json_reader.h
   M /trunk/src/base/json/json_writer.h
   M /trunk/src/base/json/string_escape.h
   M /trunk/src/base/keyboard_code_conversion_gtk.h
   M /trunk/src/base/keyboard_codes.h
   M /trunk/src/base/keyboard_codes_posix.h
   M /trunk/src/base/keyboard_codes_win.h
   M /trunk/src/base/lazy_instance.h
   M /trunk/src/base/leak_annotations.h
   M /trunk/src/base/leak_tracker.h
   M /trunk/src/base/linked_list.h
   M /trunk/src/base/linked_ptr.h
   M /trunk/src/base/linux_util.h
   M /trunk/src/base/lock.h
   M /trunk/src/base/lock_impl.h
   M /trunk/src/base/logging.h
   M /trunk/src/base/logging_win.h
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mach_ipc_mac.h
   M /trunk/src/base/md5.h
   M /trunk/src/base/memory_debug.h
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_proxy.h
   M /trunk/src/base/message_loop_proxy_impl.h
   M /trunk/src/base/message_pump.h
   M /trunk/src/base/message_pump_default.h
   M /trunk/src/base/message_pump_glib.h
   M /trunk/src/base/message_pump_libevent.h
   M /trunk/src/base/message_pump_mac.h
   M /trunk/src/base/message_pump_win.h
   M /trunk/src/base/mime_util.h
   M /trunk/src/base/move.h
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/native_library.h
   M /trunk/src/base/no_windows2000_unittest.h
   M /trunk/src/base/non_thread_safe.h
   M /trunk/src/base/nsimage_cache_mac.h
   M /trunk/src/base/nss_util.h
   M /trunk/src/base/nss_util_internal.h
   M /trunk/src/base/nullable_string16.h
   M /trunk/src/base/object_watcher.h
   M /trunk/src/base/observer_list.h
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/path_service.h
   M /trunk/src/base/pe_image.h
   M /trunk/src/base/perftimer.h
   M /trunk/src/base/pickle.h
   M /trunk/src/base/platform_file.h
   M /trunk/src/base/platform_thread.h
   M /trunk/src/base/port.h
   M /trunk/src/base/process.h
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_unittest_mac.h
   M /trunk/src/base/profiler.h
   M /trunk/src/base/rand_util.h
   M /trunk/src/base/rand_util_c.h
   M /trunk/src/base/raw_scoped_refptr_mismatch_checker.h
   M /trunk/src/base/ref_counted.h
   M /trunk/src/base/ref_counted_memory.h
   M /trunk/src/base/registry.h
   M /trunk/src/base/resource_util.h
   M /trunk/src/base/safe_strerror_posix.h
   M /trunk/src/base/scoped_bstr_win.h
   M /trunk/src/base/scoped_cftyperef.h
   M /trunk/src/base/scoped_comptr_win.h
   M /trunk/src/base/scoped_handle.h
   M /trunk/src/base/scoped_handle_win.h
   M /trunk/src/base/scoped_native_library.h
   M /trunk/src/base/scoped_nsautorelease_pool.h
   M /trunk/src/base/scoped_nsdisable_screen_updates.h
   M /trunk/src/base/scoped_nsobject.h
   M /trunk/src/base/scoped_open_process.h
   M /trunk/src/base/scoped_ptr.h
   M /trunk/src/base/scoped_temp_dir.h
   M /trunk/src/base/scoped_variant_win.h
   M /trunk/src/base/scoped_vector.h
   M /trunk/src/base/setproctitle_linux.h
   M /trunk/src/base/sha1.h
   M /trunk/src/base/sha2.h
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/simple_thread.h
   M /trunk/src/base/singleton.h
   M /trunk/src/base/singleton_objc.h
   M /trunk/src/base/spin_wait.h
   M /trunk/src/base/stack_container.h
   M /trunk/src/base/stats_counters.h
   M /trunk/src/base/stats_table.h
   M /trunk/src/base/stl_util-inl.h
   M /trunk/src/base/string16.h
   M /trunk/src/base/string_piece.h
   M /trunk/src/base/string_split.h
   M /trunk/src/base/string_tokenizer.h
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_posix.h
   M /trunk/src/base/string_util_win.h
   M /trunk/src/base/sync_socket.h
   M /trunk/src/base/sys_info.h
   M /trunk/src/base/sys_string_conversions.h
   M /trunk/src/base/task.h
   M /trunk/src/base/template_util.h
   M /trunk/src/base/test/perf_test_suite.h
   M /trunk/src/base/test/test_file_util.h
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/base/thread.h
   M /trunk/src/base/thread_collision_warner.h
   M /trunk/src/base/thread_local.h
   M /trunk/src/base/thread_local_storage.h
   M /trunk/src/base/time.h
   M /trunk/src/base/timer.h
   M /trunk/src/base/trace_event.h
   M /trunk/src/base/trace_event_win.h
   M /trunk/src/base/tracked.h
   M /trunk/src/base/tracked_objects.h
   M /trunk/src/base/tuple.h
   M /trunk/src/base/unix_domain_socket_posix.h
   M /trunk/src/base/utf_offset_string_conversions.h
   M /trunk/src/base/utf_string_conversion_utils.h
   M /trunk/src/base/utf_string_conversions.h
   M /trunk/src/base/values.h
   M /trunk/src/base/version.h
   M /trunk/src/base/waitable_event.h
   M /trunk/src/base/waitable_event_watcher.h
   M /trunk/src/base/watchdog.h
   M /trunk/src/base/weak_ptr.h
   M /trunk/src/base/win_util.h
   M /trunk/src/base/wmi_util.h
   M /trunk/src/base/worker_pool.h
   M /trunk/src/base/worker_pool_linux.h
   M /trunk/src/base/worker_pool_mac.h
   M /trunk/src/base/xdg_util.h
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/app/breakpad_mac.h
   M /trunk/src/chrome/app/breakpad_win.h
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/chrome_exe_resource.h
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/app/hard_error_handler_win.h
   M /trunk/src/chrome/app/scoped_ole_initializer.h
   M /trunk/src/chrome/browser/accessibility_events.h
   M /trunk/src/chrome/browser/aeropeek_manager.h
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/app_controller_cppsafe_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_icon_win.h
   M /trunk/src/chrome/browser/app_launched_animation.h
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/browser/appcache/view_appcache_internals_job_factory.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_classifier.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   M /trunk/src/chrome/browser/autofill/address.h
   M /trunk/src/chrome/browser/autofill/address_field.h
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_address_sheet_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   M /trunk/src/chrome/browser/autofill/autofill_field.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_type.h
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.h
   M /trunk/src/chrome/browser/autofill/billing_address.h
   M /trunk/src/chrome/browser/autofill/contact_info.h
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/credit_card_field.h
   M /trunk/src/chrome/browser/autofill/fax_field.h
   M /trunk/src/chrome/browser/autofill/fax_number.h
   M /trunk/src/chrome/browser/autofill/field_types.h
   M /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/form_group.h
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/home_address.h
   M /trunk/src/chrome/browser/autofill/home_phone_number.h
   M /trunk/src/chrome/browser/autofill/name_field.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/phone_field.h
   M /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/browser/autofill/select_control_handler.h
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_extension_tracker.h
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/automation_provider_list.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/automation/automation_resource_routing_delegate.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.h
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/background_contents_service.h
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/bookmarks/base_bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.h
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_accessibility_manager_win.h
   M /trunk/src/chrome/browser/browser_accessibility_win.h
   M /trunk/src/chrome/browser/browser_child_process_host.h
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/browser_prefs.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_process_sub_thread.h
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_trial.h
   M /trunk/src/chrome/browser/browser_url_handler.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/certificate_viewer.h
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/chrome_browser_application_mac.h
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   M /trunk/src/chrome/browser/chrome_plugin_host.h
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chromeos/audio_handler.h
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library_loader.h
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_cros_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_library_loader.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_speech_synthesis_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_system_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_update_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.h
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/cros/syslogs_library.h
   M /trunk/src/chrome/browser/chromeos/cros/system_library.h
   M /trunk/src/chrome/browser/chromeos/cros/update_library.h
   M /trunk/src/chrome/browser/chromeos/cros_settings.h
   M /trunk/src/chrome/browser/chromeos/cros_settings_names.h
   M /trunk/src/chrome/browser/chromeos/customization_document.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.h
   M /trunk/src/chrome/browser/chromeos/drop_shadow_label.h
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.h
   M /trunk/src/chrome/browser/chromeos/external_metrics.h
   M /trunk/src/chrome/browser/chromeos/external_protocol_dialog.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.h
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/authentication_notification_details.h
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/camera.h
   M /trunk/src/chrome/browser/chromeos/login/captcha_view.h
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/image_decoder.h
   M /trunk/src/chrome/browser/chromeos/login/image_downloader.h
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.h
   M /trunk/src/chrome/browser/chromeos/login/login_html_dialog.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/message_bubble.h
   M /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/mock_screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/mock_update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_delegate.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.h
   M /trunk/src/chrome/browser/chromeos/login/owner_key_utils.h
   M /trunk/src/chrome/browser/chromeos/login/password_changed_view.h
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.h
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_loader.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_screen.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/browser/chromeos/login/user_view.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_screen.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h
   M /trunk/src/chrome/browser/chromeos/low_battery_observer.h
   M /trunk/src/chrome/browser/chromeos/mock_cros_settings.h
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.h
   M /trunk/src/chrome/browser/chromeos/network_list.h
   M /trunk/src/chrome/browser/chromeos/network_message_observer.h
   M /trunk/src/chrome/browser/chromeos/network_state_notifier.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification.h
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification_factory.h
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_page.h
   M /trunk/src/chrome/browser/chromeos/offline/offline_load_service.h
   M /trunk/src/chrome/browser/chromeos/options/cellular_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.h
   M /trunk/src/chrome/browser/chromeos/options/ip_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_util.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.h
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_container.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader.h
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.h
   M /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.h
   M /trunk/src/chrome/browser/chromeos/update_observer.h
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/chromeos/version_loader.h
   M /trunk/src/chrome/browser/chromeos/view_ids.h
   M /trunk/src/chrome/browser/chromeos/volume_bubble.h
   M /trunk/src/chrome/browser/chromeos/volume_bubble_view.h
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   M /trunk/src/chrome/browser/chromeos/wm_message_listener.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_fav_icon.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_title.h
   M /trunk/src/chrome/browser/clipboard_dispatcher.h
   M /trunk/src/chrome/browser/cocoa/about_ipc_bridge.h
   M /trunk/src/chrome/browser/cocoa/about_ipc_controller.h
   M /trunk/src/chrome/browser/cocoa/about_ipc_dialog.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/accelerators_cocoa.h
   M /trunk/src/chrome/browser/cocoa/animatable_image.h
   M /trunk/src/chrome/browser/cocoa/animatable_view.h
   M /trunk/src/chrome/browser/cocoa/authorization_util.h
   M /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/background_tile_view.h
   M /trunk/src/chrome/browser/cocoa/base_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_constants.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_state.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_model_observer_for_cocoa.h
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_browser_cell.h
   M /trunk/src/chrome/browser/cocoa/browser_accessibility.h
   M /trunk/src/chrome/browser/cocoa/browser_accessibility_delegate.h
   M /trunk/src/chrome/browser/cocoa/browser_command_executor.h
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clickhold_button_cell.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/command_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.h
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.h
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.h
   M /trunk/src/chrome/browser/cocoa/download_item_cell.h
   M /trunk/src/chrome/browser/cocoa/download_item_mac.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.h
   M /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h
   M /trunk/src/chrome/browser/cocoa/event_utils.h
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_bridge.h
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/fast_resize_view.h
   M /trunk/src/chrome/browser/cocoa/file_metadata.h
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_bar_view.h
   M /trunk/src/chrome/browser/cocoa/find_pasteboard.h
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_cppsafe.h
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/image_utils.h
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.h
   M /trunk/src/chrome/browser/cocoa/importer_lock_dialog.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.h
   M /trunk/src/chrome/browser/cocoa/infobar.h
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/install_from_dmg.h
   M /trunk/src/chrome/browser/cocoa/keystone_glue.h
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/image_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/star_decoration.h
   M /trunk/src/chrome/browser/cocoa/menu_button.h
   M /trunk/src/chrome/browser/cocoa/menu_controller.h
   M /trunk/src/chrome/browser/cocoa/multi_key_equivalent_button.h
   M /trunk/src/chrome/browser/cocoa/new_tab_button.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   M /trunk/src/chrome/browser/cocoa/nsmenuitem_additions.h
   M /trunk/src/chrome/browser/cocoa/objc_method_swizzle.h
   M /trunk/src/chrome/browser/cocoa/objc_zombie.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   M /trunk/src/chrome/browser/cocoa/reload_button.h
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.h
   M /trunk/src/chrome/browser/cocoa/restart_browser.h
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   M /trunk/src/chrome/browser/cocoa/sad_tab_controller.h
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.h
   M /trunk/src/chrome/browser/cocoa/scoped_authorizationref.h
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_tray_mac.h
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller_target.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/test_event_utils.h
   M /trunk/src/chrome/browser/cocoa/themed_window.h
   M /trunk/src/chrome/browser/cocoa/throbber_view.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.h
   M /trunk/src/chrome/browser/cocoa/ui_localizer.h
   M /trunk/src/chrome/browser/cocoa/url_drop_target.h
   M /trunk/src/chrome/browser/cocoa/vertical_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/view_id_util.h
   M /trunk/src/chrome/browser/cocoa/view_resizer.h
   M /trunk/src/chrome/browser/cocoa/view_resizer_pong.h
   M /trunk/src/chrome/browser/cocoa/web_contents_drag_source.h
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.h
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   M /trunk/src/chrome/browser/command_line_pref_store.h
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/configuration_policy_provider.h
   M /trunk/src/chrome/browser/configuration_policy_provider_mac.h
   M /trunk/src/chrome/browser/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/content_exceptions_table_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_combo_model.h
   M /trunk/src/chrome/browser/content_setting_image_model.h
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_prompt_modal_dialog_delegate.h
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/crash_handler_host_linux.h
   M /trunk/src/chrome/browser/cross_site_request_manager.h
   M /trunk/src/chrome/browser/custom_home_pages_table_model.h
   M /trunk/src/chrome/browser/debugger/debugger_host.h
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/chrome/browser/debugger/devtools_client_host.h
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_remote.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.h
   M /trunk/src/chrome/browser/debugger/devtools_toggle_action.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/browser/default_encoding_combo_model.h
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_test.h
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.h
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/dom_operation_notification_details.h
   M /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.h
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui.h
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.h
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_util.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/font_settings_handler.h
   M /trunk/src/chrome/browser/dom_ui/history2_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.h
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.h
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.h
   M /trunk/src/chrome/browser/dom_ui/remoting_ui.h
   M /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/dom_ui/slideshow_ui.h
   M /trunk/src/chrome/browser/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_item_model.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.h
   M /trunk/src/chrome/browser/download/download_request_limiter.h
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/download_started_animation.h
   M /trunk/src/chrome/browser/download/download_types.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/drag_download_file.h
   M /trunk/src/chrome/browser/download/drag_download_util.h
   M /trunk/src/chrome/browser/download/save_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_item.h
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_types.h
   M /trunk/src/chrome/browser/dummy_configuration_policy_provider.h
   M /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/extensions/autoupdate_interceptor.h
   M /trunk/src/chrome/browser/extensions/browser_action_test_util.h
   M /trunk/src/chrome/browser/extensions/convert_user_script.h
   M /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_clipboard_api.h
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.h
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_manager.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.h
   M /trunk/src/chrome/browser/extensions/extension_event_names.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_history_api.h
   M /trunk/src/chrome/browser/extensions/extension_history_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_host_mac.h
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.h
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.h
   M /trunk/src/chrome/browser/extensions/extension_idle_api.h
   M /trunk/src/chrome/browser/extensions/extension_idle_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_metrics_module.h
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_processes_api.h
   M /trunk/src/chrome/browser/extensions/extension_processes_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_protocols.h
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extensions_quota_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.h
   M /trunk/src/chrome/browser/extensions/file_reader.h
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.h
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/favicon_service.h
   M /trunk/src/chrome/browser/file_watcher.h
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/find_bar_state.h
   M /trunk/src/chrome/browser/find_notification_details.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/fonts_languages_window.h
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/fake_access_token_store.h
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/browser/geolocation/geolocation_prefs.h
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state.h
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.h
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/geolocation/osx_wifi.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/google_service_auth_error.h
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/google_util.h
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/gpu_process_host_ui_shim.h
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.h
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.h
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   M /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.h
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/cairo_cached_surface.h
   M /trunk/src/chrome/browser/gtk/certificate_dialogs.h
   M /trunk/src/chrome/browser/gtk/certificate_manager.h
   M /trunk/src/chrome/browser/gtk/certificate_viewer.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.h
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/custom_drag.h
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/gtk/extension_infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/gconf_titlebar_listener.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.h
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu.h
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.h
   M /trunk/src/chrome/browser/gtk/gtk_expanded_container.h
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/hover_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/meta_frames.h
   M /trunk/src/chrome/browser/gtk/nine_box.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.h
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/overflow_button.h
   M /trunk/src/chrome/browser/gtk/process_singleton_dialog.h
   M /trunk/src/chrome/browser/gtk/reload_button_gtk.h
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/gtk/rounded_window.h
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.h
   M /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/gtk/tabstrip_origin_provider.h
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/update_recommended_dialog.h
   M /trunk/src/chrome/browser/gtk/view_id_util.h
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.h
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.h
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/in_memory_database.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/in_memory_url_index.h
   M /trunk/src/chrome/browser/history/page_usage_data.h
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/snippet.h
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_tracker.h
   M /trunk/src/chrome/browser/history/visitsegment_database.h
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_zoom_map.h
   M /trunk/src/chrome/browser/hung_renderer_dialog.h
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/idle.h
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.h
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/importer/importer_data_types.h
   M /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/importer_messages.h
   M /trunk/src/chrome/browser/importer/mork_reader.h
   M /trunk/src/chrome/browser/importer/nss_decryptor.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_system_nss.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_win.h
   M /trunk/src/chrome/browser/importer/profile_writer.h
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/jankometer.h
   M /trunk/src/chrome/browser/js_modal_dialog.h
   M /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/jumplist_win.h
   M /trunk/src/chrome/browser/keychain_mac.h
   M /trunk/src/chrome/browser/keychain_mock_mac.h
   M /trunk/src/chrome/browser/language_combobox_model.h
   M /trunk/src/chrome/browser/language_order_table_model.h
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h
   M /trunk/src/chrome/browser/load_notification_details.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/location_bar_util.h
   M /trunk/src/chrome/browser/login_model.h
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_mac.h
   M /trunk/src/chrome/browser/mach_broker_mac.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/memory_purger.h
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/metrics/histogram_synchronizer.h
   M /trunk/src/chrome/browser/metrics/metric_event_duration_details.h
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_response.h
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/user_metrics.h
   M /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/mock_browsing_data_database_helper.h
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/mock_configuration_policy_provider.h
   M /trunk/src/chrome/browser/mock_configuration_policy_store.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service_win.h
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/browser/net/browser_url_util.h
   M /trunk/src/chrome/browser/net/chrome_cookie_notification_details.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/net/chrome_network_delegate.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/connect_interceptor.h
   M /trunk/src/chrome/browser/net/connection_tester.h
   M /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/net/load_timing_observer.h
   M /trunk/src/chrome/browser/net/metadata_url_request.h
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor.h
   M /trunk/src/chrome/browser/net/predictor_api.h
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/net/ssl_config_service_manager.h
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/net/url_info.h
   M /trunk/src/chrome/browser/net/url_request_failed_dns_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.h
   M /trunk/src/chrome/browser/net/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.h
   M /trunk/src/chrome/browser/net/url_request_tracking.h
   M /trunk/src/chrome/browser/net/view_http_cache_job_factory.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.h
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notification.h
   M /trunk/src/chrome/browser/notifications/notification_delegate.h
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.h
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   M /trunk/src/chrome/browser/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/browser/notifications/notification_test_util.h
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.h
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h
   M /trunk/src/chrome/browser/ntp_background_util.h
   M /trunk/src/chrome/browser/omnibox_search_hint.h
   M /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/options_util.h
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/page_state.h
   M /trunk/src/chrome/browser/parsers/metadata_parser.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_factory.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_manager.h
   M /trunk/src/chrome/browser/password_manager/encryptor.h
   M /trunk/src/chrome/browser/password_manager/encryptor_password_mac.h
   M /trunk/src/chrome/browser/password_manager/ie7_password.h
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.h
   M /trunk/src/chrome/browser/password_manager/native_backend_kwallet_x.h
   M /trunk/src/chrome/browser/password_manager/password_form_data.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager_delegate.h
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_change.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/password_manager/password_store_x.h
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/plugin_updater.h
   M /trunk/src/chrome/browser/popup_blocked_animation.h
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/power_save_blocker.h
   M /trunk/src/chrome/browser/pref_member.h
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_set_observer.h
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/preferences_mac.h
   M /trunk/src/chrome/browser/preferences_mock_mac.h
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_internal.h
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/process_info_snapshot.h
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/remove_rows_table_model.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_sync_reader.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_proxy.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/global_request_id.h
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.h
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/offline_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_factory.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_notification_task.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_queue.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/test/test_backing_store.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/video_layer.h
   M /trunk/src/chrome/browser/renderer_host/video_layer_proxy.h
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.h
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
   M /trunk/src/chrome/browser/renderer_preferences_util.h
   M /trunk/src/chrome/browser/repost_form_warning_controller.h
   M /trunk/src/chrome/browser/resources_util.h
   M /trunk/src/chrome/browser/rlz/rlz.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/scoped_pref_update.h
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.h
   M /trunk/src/chrome/browser/search_engines/util.h
   M /trunk/src/chrome/browser/session_startup_pref.h
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_command.h
   M /trunk/src/chrome/browser/sessions/session_id.h
   M /trunk/src/chrome/browser/sessions/session_restore.h
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.h
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/spellcheck_host_observer.h
   M /trunk/src/chrome/browser/spellchecker_platform_engine.h
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/ssl/ssl_request_info.h
   M /trunk/src/chrome/browser/ssl_client_certificate_selector.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/status_icons/status_icon.h
   M /trunk/src/chrome/browser/status_icons/status_tray.h
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.h
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/authenticator.h
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.h
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/cleanup_disabled_types_command.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   M /trunk/src/chrome/browser/sync/engine/idle_query_linux.h
   M /trunk/src/chrome/browser/sync/engine/mock_model_safe_workers.h
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/url_translator.h
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.h
   M /trunk/src/chrome/browser/sync/engine/store_timestamps_command.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.h
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/change_processor_mock.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_mock.h
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/extension_data.h
   M /trunk/src/chrome/browser/sync/glue/extension_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/extension_util.h
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator_mock.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/password_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/password_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host_mock.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_util.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.h
   M /trunk/src/chrome/browser/sync/notification_method.h
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   M /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.h
   M /trunk/src/chrome/browser/sync/notifier/invalidation_util.h
   M /trunk/src/chrome/browser/sync/notifier/registration_manager.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_observer.h
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/protocol/service_constants.h
   M /trunk/src/chrome/browser/sync/sessions/ordered_commit_set.h
   M /trunk/src/chrome/browser/sync/sessions/session_state.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/sync_constants.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_ui_util.h
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac.h
   M /trunk/src/chrome/browser/sync/syncable/blob.h
   M /trunk/src/chrome/browser/sync/syncable/dir_open_result.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_event.h
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/sync/syncable/path_name_cmp.h
   M /trunk/src/chrome/browser/sync/syncable/syncable-inl.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_changes_version.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_columns.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/browser/sync/unrecoverable_error_handler.h
   M /trunk/src/chrome/browser/sync/util/channel.h
   M /trunk/src/chrome/browser/sync/util/crypto_helpers.h
   M /trunk/src/chrome/browser/sync/util/cryptographer.h
   M /trunk/src/chrome/browser/sync/util/data_encryption.h
   M /trunk/src/chrome/browser/sync/util/dbgq.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   M /trunk/src/chrome/browser/sync/util/fast_dump.h
   M /trunk/src/chrome/browser/sync/util/nigori.h
   M /trunk/src/chrome/browser/sync/util/sync_types.h
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/tab_closeable_state_watcher.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/language_state.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/page_navigator.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/security_style.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/tab_util.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.h
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.h
   M /trunk/src/chrome/browser/tabs/pinned_tab_service.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/translate/languages_menu_model.h
   M /trunk/src/chrome/browser/translate/options_menu_model.h
   M /trunk/src/chrome/browser/translate/page_translated_details.h
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.h
   M /trunk/src/chrome/browser/translate/translate_infobar_view.h
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_prefs.h
   M /trunk/src/chrome/browser/transport_security_persister.h
   M /trunk/src/chrome/browser/upgrade_detector.h
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/accessibility_event_router_views.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/accessible_view_helper.h
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/appcache_info_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/collected_cookies_win.h
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.h
   M /trunk/src/chrome/browser/views/constrained_window_win.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h
   M /trunk/src/chrome/browser/views/cookie_info_view.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.h
   M /trunk/src/chrome/browser/views/database_info_view.h
   M /trunk/src/chrome/browser/views/database_open_info_view.h
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/dropdown_bar_view.h
   M /trunk/src/chrome/browser/views/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/views/event_utils.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_drag_data.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_bubble_host.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/generic_info_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/infobars/after_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.h
   M /trunk/src/chrome/browser/views/infobars/infobar_button_border.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/infobars/infobar_text_button.h
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.h
   M /trunk/src/chrome/browser/views/infobars/translate_message_infobar.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/list_background.h
   M /trunk/src/chrome/browser/views/local_storage_info_view.h
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.h
   M /trunk/src/chrome/browser/views/location_bar/click_handler.h
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.h
   M /trunk/src/chrome/browser/views/location_bar/ev_bubble_view.h
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.h
   M /trunk/src/chrome/browser/views/location_bar/keyword_hint_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_icon_view.h
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.h
   M /trunk/src/chrome/browser/views/location_bar/page_action_with_badge_view.h
   M /trunk/src/chrome/browser/views/location_bar/selected_keyword_view.h
   M /trunk/src/chrome/browser/views/location_bar/star_view.h
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/browser/views/modal_dialog_delegate.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_exceptions_table_view.h
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/exception_editor_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.h
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/options/plugin_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/simple_content_exceptions_view.h
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h
   M /trunk/src/chrome/browser/views/reload_button.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.h
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_gtk.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer_data.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_controller.h
   M /trunk/src/chrome/browser/views/theme_background.h
   M /trunk/src/chrome/browser/views/theme_helpers.h
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.h
   M /trunk/src/chrome/browser/views/uninstall_view.h
   M /trunk/src/chrome/browser/views/update_recommended_message_box.h
   M /trunk/src/chrome/browser/views/url_picker.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/views/wrench_menu.h
   M /trunk/src/chrome/browser/visitedlink_event_listener.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/web_applications/web_app.h
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/browser/webdata/autofill_change.h
   M /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_test_util.h
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/chrome/browser/worker_host/worker_document_set.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/common/about_handler.h
   M /trunk/src/chrome/common/app_mode_common_mac.h
   M /trunk/src/chrome/common/appcache/appcache_backend_proxy.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/automation_constants.h
   M /trunk/src/chrome/common/bindings_policy.h
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_counters.h
   M /trunk/src/chrome/common/chrome_descriptors.h
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_paths_internal.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/chrome_version_info.h
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/content_settings.h
   M /trunk/src/chrome/common/content_settings_helper.h
   M /trunk/src/chrome/common/content_settings_types.h
   M /trunk/src/chrome/common/css_colors.h
   M /trunk/src/chrome/common/database_util.h
   M /trunk/src/chrome/common/db_message_filter.h
   M /trunk/src/chrome/common/debug_flags.h
   M /trunk/src/chrome/common/default_plugin.h
   M /trunk/src/chrome/common/deprecated/event_sys-inl.h
   M /trunk/src/chrome/common/deprecated/event_sys.h
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.h
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/dom_storage_common.h
   M /trunk/src/chrome/common/edit_command.h
   M /trunk/src/chrome/common/env_vars.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_error_utils.h
   M /trunk/src/chrome/common/extensions/extension_extent.h
   M /trunk/src/chrome/common/extensions/extension_file_util.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util.h
   M /trunk/src/chrome/common/extensions/extension_localization_peer.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/common/extensions/extension_resource.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/common/extensions/update_manifest.h
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/font_descriptor_mac.h
   M /trunk/src/chrome/common/font_loader_mac.h
   M /trunk/src/chrome/common/gears_api.h
   M /trunk/src/chrome/common/geoposition.h
   M /trunk/src/chrome/common/gpu_info.h
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/gpu_native_window_handle.h
   M /trunk/src/chrome/common/gpu_plugin.h
   M /trunk/src/chrome/common/important_file_writer.h
   M /trunk/src/chrome/common/indexed_db_key.h
   M /trunk/src/chrome/common/ipc_test_sink.h
   M /trunk/src/chrome/common/json_pref_store.h
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/jstemplate_builder.h
   M /trunk/src/chrome/common/libxml_utils.h
   M /trunk/src/chrome/common/logging_chrome.h
   M /trunk/src/chrome/common/mach_message_source_mac.h
   M /trunk/src/chrome/common/main_function_params.h
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/common/metrics_helpers.h
   M /trunk/src/chrome/common/mru_cache.h
   M /trunk/src/chrome/common/nacl_cmd_line.h
   M /trunk/src/chrome/common/nacl_messages.h
   M /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_window_notification_source.h
   M /trunk/src/chrome/common/navigation_gesture.h
   M /trunk/src/chrome/common/navigation_types.h
   M /trunk/src/chrome/common/net/gaia/gaia_auth_consumer.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.h
   M /trunk/src/chrome/common/net/http_return.h
   M /trunk/src/chrome/common/net/net_resource_provider.h
   M /trunk/src/chrome/common/net/predictor_common.h
   M /trunk/src/chrome/common/net/socket_stream.h
   M /trunk/src/chrome/common/net/test_url_fetcher_factory.h
   M /trunk/src/chrome/common/net/url_fetcher.h
   M /trunk/src/chrome/common/net/url_fetcher_protect.h
   M /trunk/src/chrome/common/net/url_request_context_getter.h
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_observer.h
   M /trunk/src/chrome/common/notification_observer_mock.h
   M /trunk/src/chrome/common/notification_registrar.h
   M /trunk/src/chrome/common/notification_service.h
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/owned_widget_gtk.h
   M /trunk/src/chrome/common/page_transition_types.h
   M /trunk/src/chrome/common/page_zoom.h
   M /trunk/src/chrome/common/pepper_plugin_registry.h
   M /trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.h
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/pref_store.h
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/property_bag.h
   M /trunk/src/chrome/common/ref_counted_util.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_response.h
   M /trunk/src/chrome/common/result_codes.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.h
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac_unittest_helper.h
   M /trunk/src/chrome/common/sandbox_methods_linux.h
   M /trunk/src/chrome/common/sandbox_policy.h
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/common/serialized_script_value.h
   M /trunk/src/chrome/common/socket_stream_dispatcher.h
   M /trunk/src/chrome/common/spellcheck_common.h
   M /trunk/src/chrome/common/sqlite_compiled_statement.h
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/common/task_queue.h
   M /trunk/src/chrome/common/thumbnail_score.h
   M /trunk/src/chrome/common/time_format.h
   M /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/common/utility_messages.h
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/common/visitedlink_common.h
   M /trunk/src/chrome/common/web_database_observer_impl.h
   M /trunk/src/chrome/common/web_resource/web_resource_unpacker.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/common/webmessageportchannel_impl.h
   M /trunk/src/chrome/common/win_safe_util.h
   M /trunk/src/chrome/common/window_container_type.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_thread_ticker.h
   M /trunk/src/chrome/common/zip.h
   M /trunk/src/chrome/default_plugin/install_dialog.h
   M /trunk/src/chrome/default_plugin/plugin_database_handler.h
   M /trunk/src/chrome/default_plugin/plugin_impl_gtk.h
   M /trunk/src/chrome/default_plugin/plugin_impl_mac.h
   M /trunk/src/chrome/default_plugin/plugin_impl_win.h
   M /trunk/src/chrome/default_plugin/plugin_install_job_monitor.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx_context.h
   M /trunk/src/chrome/gpu/gpu_backing_store_win.h
   M /trunk/src/chrome/gpu/gpu_channel.h
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.h
   M /trunk/src/chrome/gpu/gpu_config.h
   M /trunk/src/chrome/gpu/gpu_idirect3d9_mock_win.h
   M /trunk/src/chrome/gpu/gpu_info_collector.h
   M /trunk/src/chrome/gpu/gpu_process.h
   M /trunk/src/chrome/gpu/gpu_thread.h
   M /trunk/src/chrome/gpu/gpu_video_layer_glx.h
   M /trunk/src/chrome/gpu/gpu_view_win.h
   M /trunk/src/chrome/gpu/gpu_view_x.h
   M /trunk/src/chrome/gpu/x_util.h
   M /trunk/src/chrome/installer/gcapi/gcapi.h
   M /trunk/src/chrome/installer/gcapi/resource.h
   M /trunk/src/chrome/installer/mini_installer/appid.h
   M /trunk/src/chrome/installer/mini_installer/mini_installer.h
   M /trunk/src/chrome/installer/mini_installer/mini_installer_resource.h
   M /trunk/src/chrome/installer/mini_installer/pe_resource.h
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/setup/setup_constants.h
   M /trunk/src/chrome/installer/setup/setup_resource.h
   M /trunk/src/chrome/installer/setup/setup_util.h
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/chrome_frame_distribution.h
   M /trunk/src/chrome/installer/util/compat_checks.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/create_dir_work_item.h
   M /trunk/src/chrome/installer/util/create_reg_key_work_item.h
   M /trunk/src/chrome/installer/util/delete_after_reboot_helper.h
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item.h
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.h
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.h
   M /trunk/src/chrome/installer/util/helper.h
   M /trunk/src/chrome/installer/util/html_dialog.h
   M /trunk/src/chrome/installer/util/install_util.h
   M /trunk/src/chrome/installer/util/installer_util_unittests_resource.h
   M /trunk/src/chrome/installer/util/l10n_string_util.h
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/lzma_util.h
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_constants.h
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/self_reg_work_item.h
   M /trunk/src/chrome/installer/util/set_reg_value_work_item.h
   M /trunk/src/chrome/installer/util/shell_util.h
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/installer/util/version.h
   M /trunk/src/chrome/installer/util/work_item.h
   M /trunk/src/chrome/installer/util/work_item_list.h
   M /trunk/src/chrome/nacl/broker_thread.h
   M /trunk/src/chrome/nacl/nacl_main_platform_delegate.h
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.h
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/plugin/npobject_base.h
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/npobject_util.h
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.h
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/profile_import/profile_import_thread.h
   M /trunk/src/chrome/renderer/about_handler.h
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/autofill_helper.h
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   M /trunk/src/chrome/renderer/automation/dom_automation_v8_extension.h
   M /trunk/src/chrome/renderer/blocked_plugin.h
   M /trunk/src/chrome/renderer/command_buffer_proxy.h
   M /trunk/src/chrome/renderer/cookie_message_filter.h
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/extension_groups.h
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/extensions/js_only_v8_extensions.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/external_extension.h
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/form_manager.h
   M /trunk/src/chrome/renderer/geolocation_dispatcher.h
   M /trunk/src/chrome/renderer/ggl/ggl.h
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.h
   M /trunk/src/chrome/renderer/localized_error.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/media/ipc_video_renderer.h
   M /trunk/src/chrome/renderer/mock_keyboard.h
   M /trunk/src/chrome/renderer/mock_keyboard_driver_win.h
   M /trunk/src/chrome/renderer/mock_printer.h
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/net/predictor_queue.h
   M /trunk/src/chrome/renderer/net/renderer_net_predictor.h
   M /trunk/src/chrome/renderer/notification_provider.h
   M /trunk/src/chrome/renderer/paint_aggregator.h
   M /trunk/src/chrome/renderer/password_autocomplete_manager.h
   M /trunk/src/chrome/renderer/pepper_devices.h
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.h
   M /trunk/src/chrome/renderer/pepper_scrollbar_widget.h
   M /trunk/src/chrome/renderer/pepper_widget.h
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_impl.h
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_visitor.h
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.h
   M /trunk/src/chrome/renderer/renderer_webcookiejar_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h
   M /trunk/src/chrome/renderer/safe_browsing/features.h
   M /trunk/src/chrome/renderer/safe_browsing/phishing_url_feature_extractor.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.h
   M /trunk/src/chrome/renderer/translate_helper.h
   M /trunk/src/chrome/renderer/user_script_idle_scheduler.h
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/renderer/visitedlink_slave.h
   M /trunk/src/chrome/renderer/webgles2context_impl.h
   M /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.h
   M /trunk/src/chrome/renderer/webmediaplayer_impl.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/websharedworkerrepository_impl.h
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_consts.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_helpers.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.h
   M /trunk/src/chrome/service/cloud_print/job_status_updater.h
   M /trunk/src/chrome/service/cloud_print/print_system.h
   M /trunk/src/chrome/service/cloud_print/printer_job_handler.h
   M /trunk/src/chrome/service/gaia/service_gaia_authenticator.h
   M /trunk/src/chrome/service/net/service_url_request_context.h
   M /trunk/src/chrome/service/service_child_process_host.h
   M /trunk/src/chrome/service/service_process.h
   M /trunk/src/chrome/service/service_utility_process_host.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_handle_tracker.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/dom_element_proxy.h
   M /trunk/src/chrome/test/automation/extension_proxy.h
   M /trunk/src/chrome/test/automation/javascript_execution_controller.h
   M /trunk/src/chrome/test/automation/javascript_message_utils.h
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/bookmark_load_observer.h
   M /trunk/src/chrome/test/browser_with_test_window_test.h
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.h
   M /trunk/src/chrome/test/chrome_process_util.h
   M /trunk/src/chrome/test/file_test_utils.h
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/injection_test_dll.h
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.h
   M /trunk/src/chrome/test/live_sync/live_autofill_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_preferences_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/menu_model_test.h
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.h
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.h
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_util.h
   M /trunk/src/chrome/test/model_test_utils.h
   M /trunk/src/chrome/test/nacl/nacl_sandbox_test.h
   M /trunk/src/chrome/test/nacl/nacl_test.h
   M /trunk/src/chrome/test/nacl/nacl_ui_test.h
   M /trunk/src/chrome/test/nacl_security_tests/commands_posix.h
   M /trunk/src/chrome/test/nacl_security_tests/nacl_security_tests_posix.h
   M /trunk/src/chrome/test/nacl_security_tests/nacl_security_tests_win.h
   M /trunk/src/chrome/test/profile_mock.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/reliability/page_load_test.h
   M /trunk/src/chrome/test/reliability/reliability_test_suite.h
   M /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/chrome/test/security_tests/ipc_security_tests.h
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.h
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.h
   M /trunk/src/chrome/test/sync/engine/proto_extension_validator.h
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h
   M /trunk/src/chrome/test/sync/engine/test_id_factory.h
   M /trunk/src/chrome/test/sync/engine/test_syncable_utils.h
   M /trunk/src/chrome/test/sync/test_http_bridge_factory.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_launcher/test_runner.h
   M /trunk/src/chrome/test/test_location_bar.h
   M /trunk/src/chrome/test/test_notification_tracker.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/testing_pref_service.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/thread_observer_helper.h
   M /trunk/src/chrome/test/ui/javascript_test_util.h
   M /trunk/src/chrome/test/ui/npapi_test_helper.h
   M /trunk/src/chrome/test/ui/ui_layout_test.h
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_test_suite.h
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/test/v8_unit_test.h
   M /trunk/src/chrome/tools/convert_dict/aff_reader.h
   M /trunk/src/chrome/tools/convert_dict/dic_reader.h
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.h
   M /trunk/src/chrome/tools/crash_service/crash_service.h
   M /trunk/src/chrome/utility/utility_thread.h
   M /trunk/src/chrome/worker/nativewebworker_impl.h
   M /trunk/src/chrome/worker/nativewebworker_stub.h
   M /trunk/src/chrome/worker/websharedworker_stub.h
   M /trunk/src/chrome/worker/webworker_stub.h
   M /trunk/src/chrome/worker/webworker_stub_base.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/chrome/worker/worker_webapplicationcachehost_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/gfx/blit.h
   M /trunk/src/gfx/brush.h
   M /trunk/src/gfx/canvas.h
   M /trunk/src/gfx/canvas_direct2d.h
   M /trunk/src/gfx/canvas_skia.h
   M /trunk/src/gfx/canvas_skia_paint.h
   M /trunk/src/gfx/codec/jpeg_codec.h
   M /trunk/src/gfx/codec/png_codec.h
   M /trunk/src/gfx/color_utils.h
   M /trunk/src/gfx/favicon_size.h
   M /trunk/src/gfx/font.h
   M /trunk/src/gfx/gdi_util.h
   M /trunk/src/gfx/gfx_paths.h
   M /trunk/src/gfx/gtk_native_view_id_manager.h
   M /trunk/src/gfx/gtk_util.h
   M /trunk/src/gfx/icon_util.h
   M /trunk/src/gfx/insets.h
   M /trunk/src/gfx/native_theme_win.h
   M /trunk/src/gfx/native_widget_types.h
   M /trunk/src/gfx/path.h
   M /trunk/src/gfx/point.h
   M /trunk/src/gfx/rect.h
   M /trunk/src/gfx/scrollbar_size.h
   M /trunk/src/gfx/size.h
   M /trunk/src/gfx/skbitmap_operations.h
   M /trunk/src/gfx/skia_util.h
   M /trunk/src/gfx/skia_utils_gtk.h
   M /trunk/src/gfx/test_suite.h
   M /trunk/src/gfx/window_impl.h
   M /trunk/src/ipc/file_descriptor_set_posix.h
   M /trunk/src/ipc/ipc_channel.h
   M /trunk/src/ipc/ipc_channel_handle.h
   M /trunk/src/ipc/ipc_channel_posix.h
   M /trunk/src/ipc/ipc_channel_proxy.h
   M /trunk/src/ipc/ipc_channel_win.h
   M /trunk/src/ipc/ipc_descriptors.h
   M /trunk/src/ipc/ipc_logging.h
   M /trunk/src/ipc/ipc_message.h
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/ipc/ipc_platform_file.h
   M /trunk/src/ipc/ipc_switches.h
   M /trunk/src/ipc/ipc_sync_channel.h
   M /trunk/src/ipc/ipc_sync_message.h
   M /trunk/src/ipc/ipc_sync_message_filter.h
   M /trunk/src/ipc/ipc_tests.h
   M /trunk/src/net/base/address_family.h
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_net_log_param.h
   M /trunk/src/net/base/auth.h
   M /trunk/src/net/base/bandwidth_metrics.h
   M /trunk/src/net/base/cache_type.h
   M /trunk/src/net/base/capturing_net_log.h
   M /trunk/src/net/base/cert_database.h
   M /trunk/src/net/base/cert_status_flags.h
   M /trunk/src/net/base/cert_test_util.h
   M /trunk/src/net/base/cert_verifier.h
   M /trunk/src/net/base/cert_verify_result.h
   M /trunk/src/net/base/completion_callback.h
   M /trunk/src/net/base/connection_type_histograms.h
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_options.h
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/cookie_store.h
   M /trunk/src/net/base/data_url.h
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/dns_util.h
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/ev_root_ca_metadata.h
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/filter_unittest.h
   M /trunk/src/net/base/forwarding_net_log.h
   M /trunk/src/net/base/gzip_filter.h
   M /trunk/src/net/base/gzip_header.h
   M /trunk/src/net/base/host_cache.h
   M /trunk/src/net/base/host_mapping_rules.h
   M /trunk/src/net/base/host_port_pair.h
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/io_buffer.h
   M /trunk/src/net/base/keygen_handler.h
   M /trunk/src/net/base/listen_socket.h
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/base/load_states.h
   M /trunk/src/net/base/mapped_host_resolver.h
   M /trunk/src/net/base/mime_sniffer.h
   M /trunk/src/net/base/mime_util.h
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/base/net_errors.h
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_unittest.h
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/net_test_suite.h
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/network_change_notifier.h
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_netlink_linux.h
   M /trunk/src/net/base/network_change_notifier_win.h
   M /trunk/src/net/base/nss_memio.h
   M /trunk/src/net/base/pem_tokenizer.h
   M /trunk/src/net/base/platform_mime_util.h
   M /trunk/src/net/base/registry_controlled_domain.h
   M /trunk/src/net/base/request_priority.h
   M /trunk/src/net/base/scoped_cert_chain_context.h
   M /trunk/src/net/base/sdch_filter.h
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/base/ssl_cert_request_info.h
   M /trunk/src/net/base/ssl_cipher_suite_names.h
   M /trunk/src/net/base/ssl_client_auth_cache.h
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_defaults.h
   M /trunk/src/net/base/ssl_config_service_mac.h
   M /trunk/src/net/base/ssl_config_service_win.h
   M /trunk/src/net/base/ssl_connection_status_flags.h
   M /trunk/src/net/base/ssl_info.h
   M /trunk/src/net/base/static_cookie_policy.h
   M /trunk/src/net/base/telnet_server.h
   M /trunk/src/net/base/test_completion_callback.h
   M /trunk/src/net/base/transport_security_state.h
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/base/upload_data_stream.h
   M /trunk/src/net/base/winsock_init.h
   M /trunk/src/net/base/x509_cert_types.h
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/disk_cache/addr.h
   M /trunk/src/net/disk_cache/backend_impl.h
   M /trunk/src/net/disk_cache/bitmap.h
   M /trunk/src/net/disk_cache/block_files.h
   M /trunk/src/net/disk_cache/cache_util.h
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/disk_cache/disk_cache_test_base.h
   M /trunk/src/net/disk_cache/disk_cache_test_util.h
   M /trunk/src/net/disk_cache/disk_format.h
   M /trunk/src/net/disk_cache/entry_impl.h
   M /trunk/src/net/disk_cache/errors.h
   M /trunk/src/net/disk_cache/eviction.h
   M /trunk/src/net/disk_cache/file.h
   M /trunk/src/net/disk_cache/file_block.h
   M /trunk/src/net/disk_cache/file_lock.h
   M /trunk/src/net/disk_cache/hash.h
   M /trunk/src/net/disk_cache/histogram_macros.h
   M /trunk/src/net/disk_cache/in_flight_backend_io.h
   M /trunk/src/net/disk_cache/in_flight_io.h
   M /trunk/src/net/disk_cache/mapped_file.h
   M /trunk/src/net/disk_cache/mem_backend_impl.h
   M /trunk/src/net/disk_cache/mem_entry_impl.h
   M /trunk/src/net/disk_cache/mem_rankings.h
   M /trunk/src/net/disk_cache/rankings.h
   M /trunk/src/net/disk_cache/sparse_control.h
   M /trunk/src/net/disk_cache/stats.h
   M /trunk/src/net/disk_cache/stats_histogram.h
   M /trunk/src/net/disk_cache/storage_block-inl.h
   M /trunk/src/net/disk_cache/storage_block.h
   M /trunk/src/net/disk_cache/trace.h
   M /trunk/src/net/ftp/ftp_auth_cache.h
   M /trunk/src/net/ftp/ftp_ctrl_response_buffer.h
   M /trunk/src/net/ftp/ftp_directory_listing_buffer.h
   M /trunk/src/net/ftp/ftp_directory_listing_parser.h
   M /trunk/src/net/ftp/ftp_directory_listing_parser_ls.h
   M /trunk/src/net/ftp/ftp_directory_listing_parser_mlsd.h
   M /trunk/src/net/ftp/ftp_directory_listing_parser_netware.h
   M /trunk/src/net/ftp/ftp_directory_listing_parser_unittest.h
   M /trunk/src/net/ftp/ftp_directory_listing_parser_vms.h
   M /trunk/src/net/ftp/ftp_directory_listing_parser_windows.h
   M /trunk/src/net/ftp/ftp_network_layer.h
   M /trunk/src/net/ftp/ftp_network_session.h
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/ftp/ftp_request_info.h
   M /trunk/src/net/ftp/ftp_response_info.h
   M /trunk/src/net/ftp/ftp_server_type_histograms.h
   M /trunk/src/net/ftp/ftp_transaction.h
   M /trunk/src/net/ftp/ftp_transaction_factory.h
   M /trunk/src/net/ftp/ftp_util.h
   M /trunk/src/net/http/des.h
   M /trunk/src/net/http/http_alternate_protocols.h
   M /trunk/src/net/http/http_auth.h
   M /trunk/src/net/http/http_auth_cache.h
   M /trunk/src/net/http/http_auth_controller.h
   M /trunk/src/net/http/http_auth_filter.h
   M /trunk/src/net/http/http_auth_filter_win.h
   M /trunk/src/net/http/http_auth_gssapi_posix.h
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/http/http_auth_handler_basic.h
   M /trunk/src/net/http/http_auth_handler_digest.h
   M /trunk/src/net/http/http_auth_handler_factory.h
   M /trunk/src/net/http/http_auth_handler_mock.h
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   M /trunk/src/net/http/http_auth_handler_ntlm.h
   M /trunk/src/net/http/http_auth_sspi_win.h
   M /trunk/src/net/http/http_basic_stream.h
   M /trunk/src/net/http/http_byte_range.h
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_transaction.h
   M /trunk/src/net/http/http_chunked_decoder.h
   M /trunk/src/net/http/http_net_log_params.h
   M /trunk/src/net/http/http_network_delegate.h
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_proxy_client_socket.h
   M /trunk/src/net/http/http_proxy_client_socket_pool.h
   M /trunk/src/net/http/http_request_headers.h
   M /trunk/src/net/http/http_request_info.h
   M /trunk/src/net/http/http_response_headers.h
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/http/http_stream.h
   M /trunk/src/net/http/http_stream_parser.h
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_factory.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/http/http_util.h
   M /trunk/src/net/http/http_vary_data.h
   M /trunk/src/net/http/http_version.h
   M /trunk/src/net/http/md4.h
   M /trunk/src/net/http/mock_gssapi_library_posix.h
   M /trunk/src/net/http/mock_sspi_library_win.h
   M /trunk/src/net/http/partial_data.h
   M /trunk/src/net/http/url_security_manager.h
   M /trunk/src/net/ocsp/nss_ocsp.h
   M /trunk/src/net/proxy/init_proxy_resolver.h
   M /trunk/src/net/proxy/mock_proxy_resolver.h
   M /trunk/src/net/proxy/multi_threaded_proxy_resolver.h
   M /trunk/src/net/proxy/polling_proxy_config_service.h
   M /trunk/src/net/proxy/proxy_bypass_rules.h
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service.h
   M /trunk/src/net/proxy/proxy_config_service_common_unittest.h
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_mac.h
   M /trunk/src/net/proxy/proxy_config_service_win.h
   M /trunk/src/net/proxy/proxy_info.h
   M /trunk/src/net/proxy/proxy_list.h
   M /trunk/src/net/proxy/proxy_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings.h
   M /trunk/src/net/proxy/proxy_resolver_mac.h
   M /trunk/src/net/proxy/proxy_resolver_request_context.h
   M /trunk/src/net/proxy/proxy_resolver_script.h
   M /trunk/src/net/proxy/proxy_resolver_script_data.h
   M /trunk/src/net/proxy/proxy_resolver_v8.h
   M /trunk/src/net/proxy/proxy_resolver_winhttp.h
   M /trunk/src/net/proxy/proxy_retry_info.h
   M /trunk/src/net/proxy/proxy_script_fetcher.h
   M /trunk/src/net/proxy/proxy_server.h
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/sync_host_resolver_bridge.h
   M /trunk/src/net/server/http_listen_socket.h
   M /trunk/src/net/server/http_server_request_info.h
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_factory.h
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_histograms.h
   M /trunk/src/net/socket/socket.h
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks5_client_socket.h
   M /trunk/src/net/socket/socks_client_socket.h
   M /trunk/src/net/socket/socks_client_socket_pool.h
   M /trunk/src/net/socket/ssl_client_socket.h
   M /trunk/src/net/socket/ssl_client_socket_mac.h
   M /trunk/src/net/socket/ssl_client_socket_mac_factory.h
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   M /trunk/src/net/socket/ssl_client_socket_nss_factory.h
   M /trunk/src/net/socket/ssl_client_socket_pool.h
   M /trunk/src/net/socket/ssl_client_socket_win.h
   M /trunk/src/net/socket/tcp_client_socket.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.h
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_win.h
   M /trunk/src/net/socket/tcp_pinger.h
   M /trunk/src/net/socket_stream/socket_stream.h
   M /trunk/src/net/socket_stream/socket_stream_job.h
   M /trunk/src/net/socket_stream/socket_stream_job_manager.h
   M /trunk/src/net/socket_stream/socket_stream_metrics.h
   M /trunk/src/net/spdy/spdy_bitmasks.h
   M /trunk/src/net/spdy/spdy_frame_builder.h
   M /trunk/src/net/spdy/spdy_framer.h
   M /trunk/src/net/spdy/spdy_http_stream.h
   M /trunk/src/net/spdy/spdy_io_buffer.h
   M /trunk/src/net/spdy/spdy_network_transaction.h
   M /trunk/src/net/spdy/spdy_protocol.h
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_session_pool.h
   M /trunk/src/net/spdy/spdy_settings_storage.h
   M /trunk/src/net/spdy/spdy_stream.h
   M /trunk/src/net/spdy/spdy_test_util.h
   M /trunk/src/net/spdy/spdy_transaction_factory.h
   M /trunk/src/net/test/test_server.h
   M /trunk/src/net/tools/dump_cache/cache_dumper.h
   M /trunk/src/net/tools/dump_cache/url_to_filename_encoder.h
   M /trunk/src/net/tools/dump_cache/url_utilities.h
   M /trunk/src/net/tools/fetch/http_listen_socket.h
   M /trunk/src/net/tools/fetch/http_server.h
   M /trunk/src/net/tools/fetch/http_server_request_info.h
   M /trunk/src/net/tools/fetch/http_server_response_info.h
   M /trunk/src/net/tools/fetch/http_session.h
   M /trunk/src/net/tools/flip_server/balsa_enums.h
   M /trunk/src/net/tools/flip_server/balsa_frame.h
   M /trunk/src/net/tools/flip_server/balsa_headers.h
   M /trunk/src/net/tools/flip_server/balsa_headers_token_utils.h
   M /trunk/src/net/tools/flip_server/balsa_visitor_interface.h
   M /trunk/src/net/tools/flip_server/buffer_interface.h
   M /trunk/src/net/tools/flip_server/create_listener.h
   M /trunk/src/net/tools/flip_server/epoll_server.h
   M /trunk/src/net/tools/flip_server/http_message_constants.h
   M /trunk/src/net/tools/flip_server/loadtime_measurement.h
   M /trunk/src/net/tools/flip_server/other_defines.h
   M /trunk/src/net/tools/flip_server/ring_buffer.h
   M /trunk/src/net/tools/flip_server/simple_buffer.h
   M /trunk/src/net/tools/flip_server/split.h
   M /trunk/src/net/tools/flip_server/string_piece_utils.h
   M /trunk/src/net/tools/flip_server/url_to_filename_encoder.h
   M /trunk/src/net/tools/flip_server/url_utilities.h
   M /trunk/src/net/tools/spdyshark/packet-spdy.h
   M /trunk/src/net/url_request/https_prober.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_about_job.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_data_job.h
   M /trunk/src/net/url_request/url_request_error_job.h
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_filter.h
   M /trunk/src/net/url_request/url_request_ftp_job.h
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_manager.h
   M /trunk/src/net/url_request/url_request_job_metrics.h
   M /trunk/src/net/url_request/url_request_job_tracker.h
   M /trunk/src/net/url_request/url_request_netlog_params.h
   M /trunk/src/net/url_request/url_request_redirect_job.h
   M /trunk/src/net/url_request/url_request_simple_job.h
   M /trunk/src/net/url_request/url_request_status.h
   M /trunk/src/net/url_request/url_request_test_job.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/net/url_request/view_cache_helper.h
   M /trunk/src/net/websockets/websocket.h
   M /trunk/src/net/websockets/websocket_frame_handler.h
   M /trunk/src/net/websockets/websocket_handshake.h
   M /trunk/src/net/websockets/websocket_handshake_draft75.h
   M /trunk/src/net/websockets/websocket_handshake_handler.h
   M /trunk/src/net/websockets/websocket_job.h
   M /trunk/src/net/websockets/websocket_throttle.h
   M /trunk/src/skia/config/SkUserConfig.h
   M /trunk/src/skia/config/win/stdint.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_control.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.h
   M /trunk/src/skia/ext/bitmap_platform_device.h
   M /trunk/src/skia/ext/bitmap_platform_device_linux.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.h
   M /trunk/src/skia/ext/bitmap_platform_device_win.h
   M /trunk/src/skia/ext/canvas_paint.h
   M /trunk/src/skia/ext/canvas_paint_linux.h
   M /trunk/src/skia/ext/canvas_paint_mac.h
   M /trunk/src/skia/ext/canvas_paint_win.h
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/platform_canvas.h
   M /trunk/src/skia/ext/platform_device.h
   M /trunk/src/skia/ext/platform_device_linux.h
   M /trunk/src/skia/ext/platform_device_mac.h
   M /trunk/src/skia/ext/platform_device_win.h
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_win.h
   M /trunk/src/skia/ext/vector_canvas.h
   M /trunk/src/skia/ext/vector_platform_device.h
   M /trunk/src/skia/ext/vector_platform_device_linux.h
   M /trunk/src/skia/ext/vector_platform_device_win.h
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.h
   M /trunk/src/views/accessibility/view_accessibility_wrapper.h
   M /trunk/src/views/animation/bounds_animator.h
   M /trunk/src/views/background.h
   M /trunk/src/views/border.h
   M /trunk/src/views/box_layout.h
   M /trunk/src/views/controls/button/button.h
   M /trunk/src/views/controls/button/button_dropdown.h
   M /trunk/src/views/controls/button/checkbox.h
   M /trunk/src/views/controls/button/custom_button.h
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/native_button_gtk.h
   M /trunk/src/views/controls/button/native_button_win.h
   M /trunk/src/views/controls/button/native_button_wrapper.h
   M /trunk/src/views/controls/button/radio_button.h
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/combobox/native_combobox_gtk.h
   M /trunk/src/views/controls/combobox/native_combobox_win.h
   M /trunk/src/views/controls/combobox/native_combobox_wrapper.h
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/controls/listbox/listbox.h
   M /trunk/src/views/controls/listbox/native_listbox_win.h
   M /trunk/src/views/controls/listbox/native_listbox_wrapper.h
   M /trunk/src/views/controls/menu/controller.h
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_config.h
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_delegate.h
   M /trunk/src/views/controls/menu/menu_gtk.h
   M /trunk/src/views/controls/menu/menu_host.h
   M /trunk/src/views/controls/menu/menu_host_gtk.h
   M /trunk/src/views/controls/menu/menu_host_root_view.h
   M /trunk/src/views/controls/menu/menu_host_win.h
   M /trunk/src/views/controls/menu/menu_item_view.h
   M /trunk/src/views/controls/menu/menu_scroll_view_container.h
   M /trunk/src/views/controls/menu/menu_separator.h
   M /trunk/src/views/controls/menu/menu_win.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/controls/menu/submenu_view.h
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/message_box_view.h
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/controls/native/native_view_host_win.h
   M /trunk/src/views/controls/native/native_view_host_wrapper.h
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/native_control_gtk.h
   M /trunk/src/views/controls/native_control_win.h
   M /trunk/src/views/controls/progress_bar.h
   M /trunk/src/views/controls/resize_gripper.h
   M /trunk/src/views/controls/scroll_view.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_gtk.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_wrapper.h
   M /trunk/src/views/controls/scrollbar/scroll_bar.h
   M /trunk/src/views/controls/separator.h
   M /trunk/src/views/controls/single_split_view.h
   M /trunk/src/views/controls/slider/native_slider_gtk.h
   M /trunk/src/views/controls/slider/native_slider_wrapper.h
   M /trunk/src/views/controls/slider/slider.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.h
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/native_table_gtk.h
   M /trunk/src/views/controls/table/native_table_win.h
   M /trunk/src/views/controls/table/native_table_wrapper.h
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view2.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/gtk_views_entry.h
   M /trunk/src/views/controls/textfield/gtk_views_textview.h
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/throbber.h
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/drag_utils.h
   M /trunk/src/views/event.h
   M /trunk/src/views/examples/button_example.h
   M /trunk/src/views/examples/combobox_example.h
   M /trunk/src/views/examples/example_base.h
   M /trunk/src/views/examples/examples_main.h
   M /trunk/src/views/examples/menu_example.h
   M /trunk/src/views/examples/message_box_example.h
   M /trunk/src/views/examples/radio_button_example.h
   M /trunk/src/views/examples/scroll_view_example.h
   M /trunk/src/views/examples/single_split_view_example.h
   M /trunk/src/views/examples/slider_example.h
   M /trunk/src/views/examples/tabbed_pane_example.h
   M /trunk/src/views/examples/table2_example.h
   M /trunk/src/views/examples/table_example.h
   M /trunk/src/views/examples/textfield_example.h
   M /trunk/src/views/examples/widget_example.h
   M /trunk/src/views/fill_layout.h
   M /trunk/src/views/focus/accelerator_handler.h
   M /trunk/src/views/focus/external_focus_tracker.h
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_search.h
   M /trunk/src/views/focus/focus_util_win.h
   M /trunk/src/views/focus/view_storage.h
   M /trunk/src/views/grid_layout.h
   M /trunk/src/views/layout_manager.h
   M /trunk/src/views/painter.h
   M /trunk/src/views/repeat_controller.h
   M /trunk/src/views/screen.h
   M /trunk/src/views/standard_layout.h
   M /trunk/src/views/view.h
   M /trunk/src/views/view_constants.h
   M /trunk/src/views/view_text_utils.h
   M /trunk/src/views/views_delegate.h
   M /trunk/src/views/widget/aero_tooltip_manager.h
   M /trunk/src/views/widget/default_theme_provider.h
   M /trunk/src/views/widget/drop_helper.h
   M /trunk/src/views/widget/drop_target_gtk.h
   M /trunk/src/views/widget/drop_target_win.h
   M /trunk/src/views/widget/gtk_views_fixed.h
   M /trunk/src/views/widget/gtk_views_window.h
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/tooltip_manager.h
   M /trunk/src/views/widget/tooltip_manager_gtk.h
   M /trunk/src/views/widget/tooltip_manager_win.h
   M /trunk/src/views/widget/tooltip_window_gtk.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_delegate.h
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/client_view.h
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/dialog_delegate.h
   M /trunk/src/views/window/hit_test.h
   M /trunk/src/views/window/native_frame_view.h
   M /trunk/src/views/window/non_client_view.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_delegate.h
   M /trunk/src/views/window/window_gtk.h
   M /trunk/src/views/window/window_resources.h
   M /trunk/src/views/window/window_shape.h
   M /trunk/src/views/window/window_win.h

`#pragma once` for app, base, chrome, gfx, ipc, net, skia, views

BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux

TBR: erg
------------------------------------------------------------------------
r53715 | pkasting@chromium.org | 2010-07-27 00:58:19 +0200 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc

Remove code to handle bogus themes.  We've had a theming system for a while and don't care about people who manually hack the DLLs.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3071002
------------------------------------------------------------------------
r53712 | rsimha@chromium.org | 2010-07-27 00:44:07 +0200 (Tue, 27 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/test/live_sync/multiple_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc

Significantly speed up sync integration tests.

The sync integration tests currently use the method AwaitSyncCycleCompletion(), which ends up waiting for a sync event before it signals the end of a sync cycle. However, if it is called after the sync cycle is already complete, it ends up waiting for several seconds for a random unrelated sync event before it returns.

This checkin fixes this unnecessary delay by checking to see if the client has any unsynced items before it waits, thereby significantly speeding up the sync integration tests.

In addition to this, a new method called AwaitQuiescence() is now available to test cases so they can wait for racy updates initiated by multiple clients to propagate across the system.

BUG=49998
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3041018
------------------------------------------------------------------------
r53707 | davidben@chromium.org | 2010-07-27 00:17:19 +0200 (Tue, 27 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h

Add DCHECKs to check PasswordStore's threading

PasswordStore can only be queried from one thread, although the implementation
doesn't immediately look it. This adds DCHECKs to ensure we don't mess this up
in future.

R=wtc,stuartmorgan
BUG=none
TEST=PasswordManagerTest.*

Review URL: http://codereview.chromium.org/3056008
------------------------------------------------------------------------
r53706 | phajdan.jr@chromium.org | 2010-07-27 00:13:42 +0200 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/background_contents_service.h
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome_frame/html_utils.h
   M /trunk/src/gfx/skbitmap_operations.h

GTTF: Use FRIEND_TEST_ALL_PREFIXES some more.

TEST=compile
BUG=44549

Review URL: http://codereview.chromium.org/3032025
------------------------------------------------------------------------
r53696 | xiyuan@chromium.org | 2010-07-26 23:56:56 +0200 (Mon, 26 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h

Make IsPopup a const function per brett.

- Make TabContentsDelegate::IsPopup a const function;
- Add a default implementation for IsPopup;
- Update all derived classes;
- Remove the bad const_cast in tab_contents.cc;

BUG=none.
TEST=none. Code quality improvement and expect no changes.

Review URL: http://codereview.chromium.org/3060013
------------------------------------------------------------------------
r53675 | nshkrob@chromium.org | 2010-07-26 22:43:32 +0200 (Mon, 26 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc

Only add Chrome App Store if the apps flag is on.

See also http://codereview.chromium.org/3048020

BUG=49972
TEST=Manually

Review URL: http://codereview.chromium.org/3007012
------------------------------------------------------------------------
r53672 | estade@chromium.org | 2010-07-26 22:34:01 +0200 (Mon, 26 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   A /trunk/src/chrome/browser/resources/options/content_settings_exceptions_list.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/resources/shared/css/list.css

First cut at content settings exceptions lists.

This only shows the existing exceptions (doesn't allow you to add or remove them). It also only works for image exceptions. It always shows the exceptions, instead of hiding/showing them when you press the exceptions button.

BUG=48862
TEST=manual

Review URL: http://codereview.chromium.org/2856058
------------------------------------------------------------------------
r53667 | dhollowa@chromium.org | 2010-07-26 22:25:47 +0200 (Mon, 26 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFill displayed CC# should include an asterisk e.g. Profile;*1234

Changes separator used in AutoFill label containing credit card info to prefix the card number with an asterisk.

BUG=50075
TEST=AutoFillManagerTest.GetCreditCardSuggestions*

Review URL: http://codereview.chromium.org/3029030
------------------------------------------------------------------------
r53662 | asargent@chromium.org | 2010-07-26 21:58:33 +0200 (Mon, 26 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   D /trunk/src/chrome/browser/chromeos/login/string_fetcher.cc
   D /trunk/src/chrome/browser/chromeos/login/string_fetcher.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   A /trunk/src/chrome/browser/chromeos/testdata/services_manifest.json (from /trunk/src/chrome/browser/chromeos/testdata/services_manifest.json:53640)
   A /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json (from /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json:53640)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 53641 - Landing OEM customization CL for Denis

Original CL http://codereview.chromium.org/3026006

Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.

BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.

Review URL: http://codereview.chromium.org/3064002

TBR=dpolukhin@chromium.org
Review URL: http://codereview.chromium.org/3030020
------------------------------------------------------------------------
r53657 | dcheng@chromium.org | 2010-07-26 21:08:37 +0200 (Mon, 26 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/clipboard_dispatcher.h
   M /trunk/src/chrome/browser/clipboard_dispatcher_gtk.cc
   M /trunk/src/chrome/browser/clipboard_dispatcher_mac.mm
   M /trunk/src/chrome/browser/clipboard_dispatcher_win.cc

Fix DOS-style line endings in ClipboardDispatcher*

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2832080
------------------------------------------------------------------------
r53654 | erg@google.com | 2010-07-26 20:45:07 +0200 (Mon, 26 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc

GTK: Unbold the labels in the crazy menu.

BUG=50240
TEST=none

Review URL: http://codereview.chromium.org/3039030
------------------------------------------------------------------------
r53653 | nshkrob@chromium.org | 2010-07-26 20:42:05 +0200 (Mon, 26 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memory leaks in TopSites.
Revert http://codereview.chromium.org/3064004

BUG=50103
TEST=memory bots, heapcheck.

Review URL: http://codereview.chromium.org/3023018
------------------------------------------------------------------------
r53650 | seh@chromium.org | 2010-07-26 20:36:44 +0200 (Mon, 26 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/central_roster.html

On a failure to load the central roster, entire html no longer reloaded,
only the troublesome script is reloaded.
Retry logic frequency on an exponential backoff.
Review URL: http://codereview.chromium.org/3019018
------------------------------------------------------------------------
r53643 | dhg@chromium.org | 2010-07-26 20:15:27 +0200 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing text truncation, by having the items automatically be able to expand.

BUG=chromium-os:3072
TEST=none
Review URL: http://codereview.chromium.org/3018013
------------------------------------------------------------------------
r53641 | dpolukhin@chromium.org | 2010-07-26 20:07:34 +0200 (Mon, 26 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   A /trunk/src/chrome/browser/chromeos/login/string_fetcher.cc
   A /trunk/src/chrome/browser/chromeos/login/string_fetcher.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   D /trunk/src/chrome/browser/chromeos/testdata/services_manifest.json
   D /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Landing OEM customization CL for Denis

Original CL http://codereview.chromium.org/3026006

Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.

BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.

Review URL: http://codereview.chromium.org/3064002
------------------------------------------------------------------------
r53637 | csilv@chromium.org | 2010-07-26 19:48:15 +0200 (Mon, 26 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.js

Small tweak to avoid pushing overlay URLs.  This prevents overlays URLs from getting put into
browser history.

BUG=none
TEST=Exercise overlays in dom-ui options window via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3017027
------------------------------------------------------------------------
r53634 | alyssad@chromium.org | 2010-07-26 19:43:02 +0200 (Mon, 26 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/test/functional/passwords.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

PyAuto hook to remove saved passwords, more info added to passwords. BUG=36179

Review URL: http://codereview.chromium.org/3054004
------------------------------------------------------------------------
r53631 | pam@chromium.org | 2010-07-26 16:40:22 +0200 (Mon, 26 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Revert 53603 - Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.

With this, this infobar gets the blue style to match with the mocks.
Also did a cleanup to get rid of INFO_TYPE that is not more needed.

[Rollback: Following this patch, the Chromium XP debug builder started
having persistent link failures (LINK1318 error). This is a test to see
if it fixes the problems.]

BUG=39102
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2805096

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2884038
------------------------------------------------------------------------
r53624 | pfeldman@chromium.org | 2010-07-26 14:28:22 +0200 (Mon, 26 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.h
   M /trunk/src/net/server/http_listen_socket.cc
   M /trunk/src/net/server/http_listen_socket.h
   M /trunk/src/net/server/http_server_request_info.h

DevTools: implement basic handshake for remote debugging.

Review URL: http://codereview.chromium.org/2870062
------------------------------------------------------------------------
r53623 | pam@chromium.org | 2010-07-26 14:16:04 +0200 (Mon, 26 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memory leaks in ExtensionPrefStore and its unit test.
Clarify comments describing the memory ownership model.

BUG=48980
TEST=valgrind and heapcheck bots no longer show related leaks
Review URL: http://codereview.chromium.org/2805094
------------------------------------------------------------------------
r53621 | pfeldman@chromium.org | 2010-07-26 13:40:58 +0200 (Mon, 26 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer_unittest.cc

DevTools: more leak fixes in LoadTimingObserverTest.
BUG=49828

Review URL: http://codereview.chromium.org/3017031
------------------------------------------------------------------------
r53617 | avayvod@chromium.org | 2010-07-26 13:05:08 +0200 (Mon, 26 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added --bwsi flag and handling of --login-user=incognito to support BWSI mode with sync and extensions disabled.

BUG=http://crosbug.com/4420
TEST=With latest session manager click on BWSI mode or just run Chrome with --login-user=incognito and --bwsi. Sync and extensions should be disabled.


Review URL: http://codereview.chromium.org/2873047
------------------------------------------------------------------------
r53615 | pfeldman@chromium.org | 2010-07-26 11:26:48 +0200 (Mon, 26 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer_unittest.cc
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

DevTools: Fix leak in LoadTimingObserverTest.
BUG=49828

Review URL: http://codereview.chromium.org/2825067
------------------------------------------------------------------------
r53614 | zork@chromium.org | 2010-07-26 11:01:40 +0200 (Mon, 26 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_input_method_library.h

Start and stop ibus-daemon on demand.

BUG=chromium-os:4460
TEST=Turn off all input methods except en-US.  Open a terminal.  run 'ps aux | grep ibus' and check that ibus isn't running.  Enable an input method.  Ensure that it works.

Review URL: http://codereview.chromium.org/3052009
------------------------------------------------------------------------
r53611 | chron@chromium.org | 2010-07-26 07:14:49 +0200 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h

Use message loop proxy to avoid null message loop crashes.
BUG=49275
TEST=Make a lot of bookmarks. Delete a huge batch and quickly close the browser.

Review URL: http://codereview.chromium.org/2868066
------------------------------------------------------------------------
r53603 | tfarina@chromium.org | 2010-07-25 03:11:14 +0200 (Sun, 25 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.

With this, this infobar gets the blue style to match with the mocks.
Also did a cleanup to get rid of INFO_TYPE that is not more needed.

BUG=39102
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2805096
------------------------------------------------------------------------
r53594 | finnur@chromium.org | 2010-07-24 15:13:38 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc

Coverity issues 9318, 9319: Uninitialized members in diagnostics_main.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3047013
------------------------------------------------------------------------
r53593 | finnur@chromium.org | 2010-07-24 15:13:12 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc

Coverity issue 9322, 8300: Uninitialized member in dom_storage classes.

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3028020
------------------------------------------------------------------------
r53592 | finnur@chromium.org | 2010-07-24 15:13:04 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

Coverity issue 8297: Uninitialized member in url_request_automation_job.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3045011
------------------------------------------------------------------------
r53591 | finnur@chromium.org | 2010-07-24 15:12:53 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc

Coverity issue 9302: Uninitialized member in focus_store_gtk.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3040017
------------------------------------------------------------------------
r53581 | finnur@chromium.org | 2010-07-24 11:20:12 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

Coverity issues 7028, 8452, 7061, 7070: Uninitialized members in browser/sync/*

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/2884036
------------------------------------------------------------------------
r53580 | finnur@chromium.org | 2010-07-24 11:19:09 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc

Coverity issue 2291: Uninitialized member in automation_provider_observers.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3033023
------------------------------------------------------------------------
r53579 | finnur@chromium.org | 2010-07-24 11:18:25 +0200 (Sat, 24 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc

Coverity issue 11612: Uninitialized member in extension_pref_store_unittest.cc
Coverity issue 11239, 11240: Uninitialized member in extension_cookies_api.cc

BUG=None (Coverity issue id listed above)
TEST=None


Review URL: http://codereview.chromium.org/3056015
------------------------------------------------------------------------
r53578 | finnur@chromium.org | 2010-07-24 11:17:23 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc

Coverity issues 9445, 9446: Uninitialized members in importer.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/2881030
------------------------------------------------------------------------
r53577 | finnur@chromium.org | 2010-07-24 11:16:15 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/upgrade_detector.cc

Wording change for the upgrade detection mechanism and increase timer to check daily (as opposed to every hour).

BUG=50070
TEST=None (everything should work as before, with new wording for the upgrade reminder and a longer timer to trigger)

Review URL: http://codereview.chromium.org/3009021
------------------------------------------------------------------------
r53570 | ziadh@chromium.org | 2010-07-24 04:47:40 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/aeropeek_manager.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/chromeos/cros_settings.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.h
   M /trunk/src/chrome/browser/content_setting_image_model.h
   M /trunk/src/chrome/browser/crash_handler_host_linux.h
   M /trunk/src/chrome/browser/extensions/extension_clipboard_api.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/notifications/notification_delegate.h
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/parsers/metadata_parser.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_factory.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/spellcheck_host_observer.h
   M /trunk/src/chrome/browser/sync/util/channel.h
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container.h
   M /trunk/src/chrome/browser/views/tabs/base_tab.h

Add undeclared virtual destructors.

Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.

r=jar

Review URL: http://codereview.chromium.org/2856051
------------------------------------------------------------------------
r53569 | sky@chromium.org | 2010-07-24 04:44:59 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

Fixes bug where PersonalDataManager wasn't setting unique_ids_ on
loading from the db, resulting in badness.

BUG=50047
TEST=make sure you can add new profiles after exiting out of chrome.

Review URL: http://codereview.chromium.org/2842067
------------------------------------------------------------------------
r53567 | nsylvain@chromium.org | 2010-07-24 04:23:08 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disable the CloseNewTab / DontCloseNewTab tests because
they leak processes and cause some of the bots to stay
in a bad state.

BUG:43066

Review URL: http://codereview.chromium.org/2806075
------------------------------------------------------------------------
r53563 | ziadh@chromium.org | 2010-07-24 03:47:56 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h

LogStoreStatus histogram modification.

Added a STORE_SUCCESS element to the LogStoreSatus histogram in order to keep track of the number of time the preferences files was successfully written to disk.

r=jar
Review URL: http://codereview.chromium.org/3026023
------------------------------------------------------------------------
r53562 | mrossetti@chromium.org | 2010-07-24 03:26:24 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

The scrollability of a bookmark menu should be reconsidered whenever there is a change in the scrollability.

BUG=44014
TEST=Perform the steps as described in the bug report and verify that the scroll arrow disappears. Then try pasting a new bookmark into the same menu and verify that the scroll arrow appears.


Review URL: http://codereview.chromium.org/3027021
------------------------------------------------------------------------
r53556 | derat@chromium.org | 2010-07-24 02:21:03 +0200 (Sat, 24 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

chromeos: Make keyboard shortcuts consistent with Windows.

This change updates the Chrome OS keyboard accelerator table
to match the order and contents of the Windows table, modulo
function-key differences and a few additional accelerators
that only make sense for Chrome OS.

BUG=chromium-os:1474
TEST=tried them

Review URL: http://codereview.chromium.org/3017028
------------------------------------------------------------------------
r53554 | jhawkins@chromium.org | 2010-07-24 02:15:39 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   A /trunk/src/chrome/browser/autofill/select_control_handler.cc
   A /trunk/src/chrome/browser/autofill/select_control_handler.h
   M /trunk/src/chrome/chrome_browser.gypi

AutoFill: Try harder to fill select controls with variations on states,
countries and months.

BUG=38222,46861
TEST=none

Review URL: http://codereview.chromium.org/2878052
------------------------------------------------------------------------
r53553 | asargent@chromium.org | 2010-07-24 02:02:35 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/multipart_uitest.cc

Fix a typo in previous attempt at disabling a test.

BUG=50060
TEST=none



------------------------------------------------------------------------
r53552 | skrul@chromium.org | 2010-07-24 01:52:16 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Surface the "Set up sync" button on ChromiumOS when sync is stopped permanently.

I need this to be LGTMed again since the last time I tried to commit this it caused a gitsplosion.

BUG=49402

Review URL: http://codereview.chromium.org/3033025
------------------------------------------------------------------------
r53548 | erikchen@google.com | 2010-07-24 01:09:15 +0200 (Sat, 24 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/socket/ssl_client_socket_pool.cc
   M /trunk/src/net/socket/ssl_client_socket_pool.h
   M /trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_session_pool.cc
   M /trunk/src/net/spdy/spdy_session_pool.h

SPDY now always uses http_network_transaction instead of spdy_network_transaction.
It was previously possible to use spdy_network_transaction using the command line flags:
--use-spdy=no-ssl
--use-spdy=no-compress
This does not affect instances of chrome that are not run with --use-spdy.
Also changed spdy_network_transaction_unittest so that all tests are run with 3 different connection configurations: spdy over npn, spdy over ssl, and spdy without ssl.
TEST=net_unittests
BUG=49082

Review URL: http://codereview.chromium.org/3048003
------------------------------------------------------------------------
r53547 | asargent@chromium.org | 2010-07-24 01:09:13 +0200 (Sat, 24 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/history/multipart_uitest.cc

Disable some failing ui tests on MacOS

This may have no impact on the real problem we're seeing on the bots since it 
may just kick the can down to make the next test fail, but I'm giving it a shot
anyway.

BUG=50060
TEST=none

TBR=thomasvl

------------------------------------------------------------------------
r53543 | skrul@chromium.org | 2010-07-24 00:52:15 +0200 (Sat, 24 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc

Add one more null check into HtmlDialogView.

Seems like every other method in this class null checks delegate_ except for the one that is crashing :)

BUG=44802

Review URL: http://codereview.chromium.org/2834067
------------------------------------------------------------------------
r53541 | finnur@chromium.org | 2010-07-24 00:42:15 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Coverity issues 11559, 9326, 9325, 9317: Uninitialized members in browser/render_host/*

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/2811067
------------------------------------------------------------------------
r53540 | finnur@chromium.org | 2010-07-24 00:42:03 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc

Coverity issue 8296: Uninitialized member in automation_resource_message_filter.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/2825066
------------------------------------------------------------------------
r53538 | finnur@chromium.org | 2010-07-24 00:41:41 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service_unittest.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc

Coverity issues 6506, 11549, 11097, 8454: Uninitialized members in various files.

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3031022
------------------------------------------------------------------------
r53536 | nshkrob@chromium.org | 2010-07-24 00:30:58 +0200 (Sat, 24 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc

Fix memory leak.

BUG=none
TEST=heapcheck

Review URL: http://codereview.chromium.org/3014032
------------------------------------------------------------------------
r53533 | estade@chromium.org | 2010-07-24 00:23:34 +0200 (Sat, 24 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

revert r53268:
------------------------------------
GTK: when closing a browser window, cancel the active drag session.

This speculatively works around an issue where users' windows would get stuck open in rare (non-reproducible, but widely reported) cases.

BUG=23733
TEST=none :(
-------------------------------------

I thought I had fixed the issue where dragging out the last tab closed the window. Apparently not.

BUG=50055

Review URL: http://codereview.chromium.org/3019024
------------------------------------------------------------------------
r53529 | phajdan.jr@chromium.org | 2010-07-23 23:23:40 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_cryptohome_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_input_method_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_keyboard_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_library_loader.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_login_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_mount_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_network_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_power_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_screen_lock_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_synaptics_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_system_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake/fake_update_library.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Green Tree Tactical Force: Revert skrul's bad commits (probably a git-cl bug).

TBR=skrul

Review URL: http://codereview.chromium.org/2847072
------------------------------------------------------------------------
r53527 | skrul@chromium.org | 2010-07-23 23:06:46 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Surface the "Set up sync" button on ChromiumOS when sync is stopped permanently.

BUG=49402

Review URL: http://codereview.chromium.org/3041016
------------------------------------------------------------------------
r53526 | skrul@chromium.org | 2010-07-23 23:06:42 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_library_loader.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_system_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_update_library.h

fix header guards
------------------------------------------------------------------------
r53525 | skrul@chromium.org | 2010-07-23 23:06:38 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/fake/fake_network_library.h

rebase
------------------------------------------------------------------------
r53524 | skrul@chromium.org | 2010-07-23 23:06:19 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_cryptohome_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_cryptohome_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_input_method_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_input_method_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_keyboard_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_keyboard_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_library_loader.h (from /trunk/src/chrome/browser/chromeos/cros/fake_library_loader.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_login_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_login_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_mount_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_mount_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_network_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_network_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_power_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_power_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_screen_lock_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_screen_lock_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_synaptics_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_synaptics_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_system_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_system_library.h:53523)
   A /trunk/src/chrome/browser/chromeos/cros/fake/fake_update_library.h (from /trunk/src/chrome/browser/chromeos/cros/fake_update_library.h:53523)
   D /trunk/src/chrome/browser/chromeos/cros/fake_cryptohome_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_input_method_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_keyboard_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_library_loader.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_login_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_mount_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_network_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_power_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_screen_lock_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_synaptics_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_system_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_update_library.h
   M /trunk/src/chrome/chrome_browser.gypi

move fakes into fake dir
------------------------------------------------------------------------
r53523 | skrul@chromium.org | 2010-07-23 23:06:14 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   D /trunk/src/chrome/browser/chromeos/cros/fake_cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_cryptohome_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_input_method_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_keyboard_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_keyboard_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_library_loader.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_library_loader.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_login_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_mount_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_mount_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_network_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_power_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_screen_lock_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_screen_lock_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_synaptics_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_synaptics_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_system_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_system_library.h
   D /trunk/src/chrome/browser/chromeos/cros/fake_update_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_update_library.h
   M /trunk/src/chrome/chrome_browser.gypi

kill .cc files
------------------------------------------------------------------------
r53522 | skrul@chromium.org | 2010-07-23 23:06:11 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/fake_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_network_library.h

reabase
------------------------------------------------------------------------
r53521 | skrul@chromium.org | 2010-07-23 23:06:07 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/fake_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/fake_network_library.h

rebase
------------------------------------------------------------------------
r53520 | skrul@chromium.org | 2010-07-23 23:06:03 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library_loader.h

whitepsace
------------------------------------------------------------------------
r53519 | skrul@chromium.org | 2010-07-23 23:05:59 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/fake_cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake_input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake_keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake_library_loader.h
   M /trunk/src/chrome/browser/chromeos/cros/fake_login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/fake_system_library.h

tweaks
------------------------------------------------------------------------
r53517 | skrul@chromium.org | 2010-07-23 23:05:55 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/fake_mount_library.h
   M /trunk/src/chrome/browser/profile_manager.cc

tweaks
------------------------------------------------------------------------
r53516 | skrul@chromium.org | 2010-07-23 23:05:50 +0200 (Fri, 23 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library_loader.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_cryptohome_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_cryptohome_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_input_method_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_input_method_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_keyboard_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_keyboard_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_library_loader.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_library_loader.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_login_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_login_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_mount_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_mount_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_network_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_network_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_power_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_power_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_screen_lock_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_screen_lock_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_synaptics_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_synaptics_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_system_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_system_library.h
   A /trunk/src/chrome/browser/chromeos/cros/fake_update_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/fake_update_library.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

fake libcros
------------------------------------------------------------------------
r53514 | sky@chromium.org | 2010-07-23 23:02:32 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc

Makes the credit card number field show obfuscated text. When the user
focus the entry the text is cleared.

BUG=49988
TEST=see bug

Review URL: http://codereview.chromium.org/3039026
------------------------------------------------------------------------
r53513 | oshima@chromium.org | 2010-07-23 22:55:15 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disable flaky FocusOnReloadCrashedTab as it crashes at the end when it fails

TBR=jcivelli@chromium.org,
BUG=50025
TEST=none

Review URL: http://codereview.chromium.org/3026021
------------------------------------------------------------------------
r53512 | thomasvl@chromium.org | 2010-07-23 22:54:19 +0200 (Fri, 23 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/notifications_apitest.cc

Disable a flaky test that seems to completely blow up with some frequency on the mac bots and seems to cause a ripple in hosing the bot in general.
BUG=42314,50060
TEST=Mac test bots stay greener
Review URL: http://codereview.chromium.org/2834069
------------------------------------------------------------------------
r53509 | phajdan.jr@chromium.org | 2010-07-23 22:38:56 +0200 (Fri, 23 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/chrome_plugin_unittest.cc
   M /trunk/src/chrome/browser/collected_cookies_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/net/connection_tester_unittest.cc
   M /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/repost_form_warning_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_uitest.cc
   M /trunk/src/chrome/common/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/renderer/external_extension_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/interactive_ui/infobars_uitest.cc
   M /trunk/src/chrome/test/ui/ppapi_uitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/chrome_frame/test/http_server.cc
   D /trunk/src/net/base/net_test_constants.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/test/test_server.cc
   M /trunk/src/net/test/test_server.h
   M /trunk/src/net/tools/testserver/run_testserver.cc
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

GTTF: test server cleanup:

- simplify the public interface
- remove unneeded methods
- make it easier to understand

TEST=none
BUG=49680

Review URL: http://codereview.chromium.org/2881028
------------------------------------------------------------------------
r53505 | agl@chromium.org | 2010-07-23 22:31:25 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc

Use ProcessRawBytes to display certificate hashes.

BUG=none
TEST=Navigate to https://mail.google.com. Click the green padlock, then Certificate Information. Verify that the certificate hashes are displayed at the bottom of the dialog.

http://codereview.chromium.org/3033024/show
------------------------------------------------------------------------
r53503 | skerner@chromium.org | 2010-07-23 22:21:08 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/black.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/common
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/common/black.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/black.html:53489)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/common/tabs_util.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/common/text.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/text.html:53489)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/common/white.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/white.html:53489)
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/tabs_util.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test_jpeg.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test_jpeg.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test_png.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test_png.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/text.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/white.html

Split captureVisibleTab() tests into jpeg and png tests, to avoid timeouts.

BUG=49040
TEST=ExtensionApiTest.CaptureVisibleTab*

Review URL: http://codereview.chromium.org/3050014
------------------------------------------------------------------------
r53502 | arv@chromium.org | 2010-07-23 22:20:55 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/array_data_model.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/array_data_model_test.html

Add push method to array data model.

BUG=None
TEST=Manual unit test.

Review URL: http://codereview.chromium.org/3019023
------------------------------------------------------------------------
r53501 | arv@chromium.org | 2010-07-23 22:15:19 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc

NTP: Only show the chrome web store when apps are enabled.

BUG=49972
TEST=Manually

Review URL: http://codereview.chromium.org/3048020
------------------------------------------------------------------------
r53500 | nshkrob@chromium.org | 2010-07-23 21:46:20 +0200 (Fri, 23 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Move blacklisting and pinned URLs from MostVisitedURLs to TopSites.

Prepopulated URLs are also moved into TopSites.
When TopSites becomes the default (without the flag), the corresponding code in MostVisitedURLs can be removed.

BUG=48564, 48566
TEST=TopSitesTest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53376

Review URL: http://codereview.chromium.org/3036003
------------------------------------------------------------------------
r53499 | phajdan.jr@chromium.org | 2010-07-23 21:45:36 +0200 (Fri, 23 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.cc

Download code cleanup:

- remove unnecessary accessors
- make more methods private

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3012023
------------------------------------------------------------------------
r53496 | mattm@chromium.org | 2010-07-23 21:40:05 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_posix.cc

Linux: Set thread name on ShutdownDetector thread.

BUG=none
TEST=enable the posix PlatformThread::SetName, cat /proc/<chromepid>/task/*/stat

Review URL: http://codereview.chromium.org/3035019
------------------------------------------------------------------------
r53492 | sky@chromium.org | 2010-07-23 21:11:33 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Makes app tabs always pinned and unpinable.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3020024
------------------------------------------------------------------------
r53489 | dhollowa@chromium.org | 2010-07-23 20:01:35 +0200 (Fri, 23 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardSheet.xib
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.mm

AutoFill credit card settings dialog should display obfuscated number in edit field

Changes the AutoFillTextField class to properly initialize obfuscated credit card text in text field on the credit card editor sheet.  Adds additional unit tests to verify that obfuscated text appears to the user.

Nib changes: Adds outlet for the credit card number text field for use in unit tests.

BUG=49988
TEST=AutoFillDialogControllerTest.CreditCardDataMutation

Review URL: http://codereview.chromium.org/2878050
------------------------------------------------------------------------
r53488 | pinkerton@chromium.org | 2010-07-23 19:56:40 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   A /trunk/src/chrome/browser/cocoa/new_tab_button.h
   A /trunk/src/chrome/browser/cocoa/new_tab_button.mm
   M /trunk/src/chrome/chrome_browser.gypi

Restrict new tab button clicks to inside the image bounds, not anywhere in the bounds of the button in the nib.
Nib change: Make the new tab button a subclass of NewTabButton instead of NSButton
BUG=45738
TEST=clicking new tab button still works as expected.
Review URL: http://codereview.chromium.org/3046016
------------------------------------------------------------------------
r53486 | rohitrao@chromium.org | 2010-07-23 19:39:04 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
   M /trunk/src/chrome/chrome_dll.gypi

[Mac] Add the findbar template pdfs back to chrome_dll.gypi.  Add a unittest to make sure the findbar images were loaded properly.

BUG=49572
TEST=Findbar buttons should have images again.  Unittest should pass.
Review URL: http://codereview.chromium.org/3028017
------------------------------------------------------------------------
r53483 | jshin@chromium.org | 2010-07-23 19:26:56 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css

Make the border between the navigation panel visible in RTL Chrome.
In addition, make the navigation bar gradient work corretly in RTL Chrome. 

BUG=NONE
TEST=Start Chrome with '--enable-tabbed-options' and '-lang=ar' (or LANGUAGES=ar chrome on Linux) and go to Options page. To the left of the navigation bar in Options page, the border (1px solid) should be visible. The gradient in the navigation bar runs opposite to the direction it runs in LTR chrome

Review URL: http://codereview.chromium.org/3039018
------------------------------------------------------------------------
r53482 | sky@chromium.org | 2010-07-23 18:54:21 +0200 (Fri, 23 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/test/render_view_test.h

Fixes crash in TabRestoreServiceTest.DontPersistPostData. The problem
is this tests ends up going into webkit (by way of
webkit_glue::RemoveFormDataFromHistoryState), and wasn't initializing
webkit. The exact crash was because WebCore::generateSequenceNumber
asks for the current time, which needs a WebKitClient set.

BUG=45977
TEST=none

Review URL: http://codereview.chromium.org/3010025
------------------------------------------------------------------------
r53480 | andybons@chromium.org | 2010-07-23 18:43:34 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

[Mac] Increase opaque-ness of bezel on templated images
within a gradient button cell. Also cleans up a tiny bit of the code surrounding it.

BUG=44574
TEST=visual

Review URL: http://codereview.chromium.org/3014022
------------------------------------------------------------------------
r53479 | stuartmorgan@chromium.org | 2010-07-23 18:42:24 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.cc
   A /trunk/src/chrome/browser/dom_ui/add_startup_page_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.html
   A /trunk/src/chrome/browser/resources/options/add_startup_page_overlay.js
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

DOMUI prefs: Add and wire up a stub overlay for adding a startup page.

BUG=49090
TEST=The "Add..." button on the Basics page of DOMUI options should bring up an empty overlay.

Review URL: http://codereview.chromium.org/3020021
------------------------------------------------------------------------
r53474 | shess@chromium.org | 2010-07-23 17:56:50 +0200 (Fri, 23 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Clamp EV bubble to max width.

Pull the full EV-cert storage down into ev_bubble_decoration.mm and
have it middle-elide in case the cert is too big.  Middle-elide to
keep the prefix and country code visible.

BUG=42856
TEST=see bug.

Review URL: http://codereview.chromium.org/3013021
------------------------------------------------------------------------
r53472 | rohitrao@chromium.org | 2010-07-23 17:49:26 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Cancel autocomplete popup animations using an AppKit bug workaround.

BUG=49125
TEST=Resize window while popup is open/animating.  Should not look horrible.
Review URL: http://codereview.chromium.org/3051002
------------------------------------------------------------------------
r53470 | oshima@chromium.org | 2010-07-23 17:40:41 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Mark BrowserFocusTest.FocusOnReloadCrashedTab flaky for chromeos debug build

TBR=jcivelli@chromium.org
BUG=50025
TEST=none

Review URL: http://codereview.chromium.org/2878049
------------------------------------------------------------------------
r53464 | finnur@chromium.org | 2010-07-23 14:21:40 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc

Coverity issues 8518, 8519, 8522: Uninitialized member in cookie_modal_dialog.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3062006
------------------------------------------------------------------------
r53463 | finnur@chromium.org | 2010-07-23 14:13:32 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/file_watcher_inotify.cc

Coverity issue 9320: Uninitialized member in file_watcher_inotify.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/3063004
------------------------------------------------------------------------
r53460 | mnissler@chromium.org | 2010-07-23 13:32:47 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc

Properly handle local state prefs for the managed prefs warning banner.

BUG=49655
TEST=Configure MetricsReportingEnabled policy and verify advanced tab in options shows the banner.

Review URL: http://codereview.chromium.org/3057007
------------------------------------------------------------------------
r53457 | mnissler@chromium.org | 2010-07-23 12:57:36 +0200 (Fri, 23 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   A /trunk/src/chrome/browser/pref_set_observer.cc
   A /trunk/src/chrome/browser/pref_set_observer.h
   A /trunk/src/chrome/browser/pref_set_observer_unittest.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Disable proxy config button and show banner if proxy prefs are managed.

Preferences.xib changes: Connect Enabled of the proxies configuration button to
a getter in PreferencesWindowController.

BUG=49538
TEST=Unit test in pref_set_observer_unittest.cc, manually configure proxy policies, check advanced options page.

Review URL: http://codereview.chromium.org/3038013
------------------------------------------------------------------------
r53456 | dpolukhin@chromium.org | 2010-07-23 12:04:07 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   A /trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.cc
   A /trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

OOBE progress bar

BUG=crosbug.com/4693
TEST=See progress bar during OOBE

Review URL: http://codereview.chromium.org/2883033
------------------------------------------------------------------------
r53452 | satorux@chromium.org | 2010-07-23 11:35:21 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_pinyin_options.html
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Add pinyin input method DOM UI option skeleton. Fill in the contents in later changelists.

TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4808

Review URL: http://codereview.chromium.org/3050013
Patch from Takayoshi Kochi <kochi@chromium.org>.
------------------------------------------------------------------------
r53451 | finnur@chromium.org | 2010-07-23 11:15:51 +0200 (Fri, 23 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.cc

Coverity: Fix a collection of uninitialized member variables, mostly in extensions code, but some random ones outside extensions code as well.

dhollowa  : issue 11558: render_view_host.cc
rafaelw   : issue 11055: extension_browser_event_router.cc
mirandac  : issue  9443: profile_import_thread.cc
estade    : issue  9321: info_bubble_gtk.cc
phajdan.jr: issue  8308: extensions_service_unittest.cc
phajdan.jr: issue  8309: extensions_service_unittest.cc
asargent  : issue  8307: extension_browsertest.cc
asargent  : issue  7610: extension_browser_actions_api.h
rafaelw   : issue  2289: extension_function.cc

BUG=None (Coverity issue id listed above)
TEST=None

Review URL: http://codereview.chromium.org/2832070
------------------------------------------------------------------------
r53443 | satorux@chromium.org | 2010-07-23 09:07:02 +0200 (Fri, 23 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_list.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.html
   A /trunk/src/chrome/browser/resources/options/chromeos_language_options.js
   M /trunk/src/chrome/browser/resources/options.html

Load preferred languages from user preferences.

Slowly making progress. :)

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/2806060
------------------------------------------------------------------------
r53442 | eroman@chromium.org | 2010-07-23 08:02:40 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/net.gyp
   A /trunk/src/net/proxy/polling_proxy_config_service.cc
   A /trunk/src/net/proxy/polling_proxy_config_service.h
   M /trunk/src/net/proxy/proxy_config_service.h
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_mac.cc
   M /trunk/src/net/proxy/proxy_config_service_mac.h
   M /trunk/src/net/proxy/proxy_config_service_win.cc
   M /trunk/src/net/proxy/proxy_config_service_win.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Change the ProxyConfigService interface to be asynchronous, and support observers.

The Windows implementation is still using a polling mechanism under the hood, however that polling has been moved to the worker pool so it won't block the IO thread in case WinHttpGetIEProxyConfigForCurrentUser is slow (crbug.com/12189).

BUG=12189

Review URL: http://codereview.chromium.org/3056011
------------------------------------------------------------------------
r53441 | satorux@chromium.org | 2010-07-23 08:01:40 +0200 (Fri, 23 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/personal_options.js

Fix DOMUI options for Chromium OS.

On Chromium OS, The DOMUI options failed at:

  $('themes_GTK_button').onclick = function(event) {
  Uncaught TypeError: Cannot set property 'onclick' of null

On Chromium OS, navigator.platform returns "Linux i686", hence we
cannot use this to distinguish Chromium OS from regular Linux desktops.
Instead we should use cr.isChromeOS.

TEST=manually
BUG=chromium-os:5063

Review URL: http://codereview.chromium.org/3037017
------------------------------------------------------------------------
r53437 | thestig@chromium.org | 2010-07-23 07:23:13 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/ipc/ipc_tests.cc
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_response_unittest.cc
   M /trunk/src/webkit/appcache/appcache_url_request_job_unittest.cc

Random bits of header and whitespace cleanup.

BUG=none
TEST=noe
Review URL: http://codereview.chromium.org/3062003
------------------------------------------------------------------------
r53429 | csilv@chromium.org | 2010-07-23 03:48:19 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.cc
   M /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   A /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.css
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.html
   M /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html

Implement the 'Clear Browser Data' dom-ui overlay.

BUG=49037
TEST=Exercise the Clear Browser Data dialog with --enable-tabbed-options.
Review URL: http://codereview.chromium.org/2856053
------------------------------------------------------------------------
r53416 | phajdan.jr@chromium.org | 2010-07-23 01:17:17 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_tracker.cc
   M /trunk/src/net/url_request/url_request_job_tracker.h
   D /trunk/src/net/url_request/url_request_job_tracker_unittest.cc

Revert "Add the actual data being read to the OnBytesRead callback."

It broke download ui tests, but was not noticed because of the FLAKY marks.

TBR=cbentzel, bmcquade@google.com

Review URL: http://codereview.chromium.org/3008022
------------------------------------------------------------------------
r53414 | jhawkins@chromium.org | 2010-07-23 01:12:55 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFill: Initialize |user_submitted_| a few more places.

TBR=oshima
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3029023
------------------------------------------------------------------------
r53409 | petkov@chromium.org | 2010-07-23 00:47:16 +0200 (Fri, 23 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/update_observer.cc

Show an error update engine status for all unknown states.

The primary reason for this patch is so that I can add a new UPDATE_STATUS
enum value to libcros without breaking the Chrome OS build with the following
error:

"Right now we get the following error with LKGR of Chrome:
update_observer.cc: In member function 'virtual void
chromeos::UpdateObserver::Changed(chromeos::UpdateLibrary*)':
update_observer.cc:26: error: enumeration value
'UPDATE_STATUS_REPORTING_ERROR_EVENT' not handled in switch"

BUG=560
TEST=emerged chromeos-chrome with modified libcros, unit tests

Review URL: http://codereview.chromium.org/3053010
------------------------------------------------------------------------
r53406 | sky@chromium.org | 2010-07-23 00:43:57 +0200 (Fri, 23 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Fixes bug in windows autofill address editor not using the correct
phone/fax fields for saving phone numbers.

BUG=49981
TEST=see bug

Review URL: http://codereview.chromium.org/3047010
------------------------------------------------------------------------
r53405 | johnnyg@chromium.org | 2010-07-23 00:35:22 +0200 (Fri, 23 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

When the user cancels the sync setup, it should not cause an unrecoverable error in the sync service.  Setting the abort-expected flag causes the resulting shutdown to be clean.

BUG=49367
TEST=see bug for procedure

Review URL: http://codereview.chromium.org/3029022
------------------------------------------------------------------------
r53403 | thestig@chromium.org | 2010-07-23 00:20:35 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/predictor.cc
   M /trunk/src/jingle/notifier/communicator/login_settings.h
   M /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/net/base/host_mapping_rules.cc
   M /trunk/src/net/base/host_mapping_rules.h
   M /trunk/src/net/base/host_mapping_rules_unittest.cc
   M /trunk/src/net/base/host_port_pair.cc
   M /trunk/src/net/base/host_port_pair.h
   M /trunk/src/net/base/mapped_host_resolver.cc
   M /trunk/src/net/http/http_alternate_protocols.cc
   M /trunk/src/net/http/http_alternate_protocols.h
   M /trunk/src/net/http/http_alternate_protocols_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_server.cc
   M /trunk/src/net/proxy/proxy_server.h
   M /trunk/src/net/proxy/proxy_server_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/spdy/spdy_http_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_session_unittest.cc

Net: Get rid of ProxyServer::host_and_port() and friends.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3032017
------------------------------------------------------------------------
r53402 | jar@chromium.org | 2010-07-23 00:20:19 +0200 (Fri, 23 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Change to (quieter) NOTREACHED() rather than (noisy) LOG(DFATAL)

bug=46576
r=thestig
Review URL: http://codereview.chromium.org/2884033
------------------------------------------------------------------------
r53396 | dhollowa@chromium.org | 2010-07-22 23:53:30 +0200 (Thu, 22 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

AutoFill memory exception when deleting text from a filled form

Changes duplicate removal logic to avoid erasure of missing unique_id element.

BUG=49872
TEST=Manual test as per bug.

Review URL: http://codereview.chromium.org/3031018
------------------------------------------------------------------------
r53395 | sky@chromium.org | 2010-07-22 23:52:23 +0200 (Thu, 22 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc

Makes the auto fill editor on linux only enable the ok button if at
least one field has text.

BUG=47742
TEST=create a new address/credit card in the autofill profile manager
and make sure the ok button is only enabled if at least one field has
text.

Review URL: http://codereview.chromium.org/3014026
------------------------------------------------------------------------
r53391 | erg@google.com | 2010-07-22 23:36:50 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/visitedlink_common.cc
   M /trunk/src/chrome/common/visitedlink_common.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc

Continual header pruning

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3029019
------------------------------------------------------------------------
r53390 | dhollowa@chromium.org | 2010-07-22 23:35:45 +0200 (Thu, 22 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_mac.mm
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

AutoFill Mac fails to fill Address Book card data

Changes the Mac implementation of auxiliary profile retrieval (Address Book data) to properly
manage unique ids assigned to profiles originating from the Address Book.

BUG=49657
TEST=PersonalDataManagerTest.*, and manual steps of (1) load a fillable HTML form, (2) click fillable field, (3) pick profile originating from Address Book, (4) observe that it fills the form.

Review URL: http://codereview.chromium.org/3055011
------------------------------------------------------------------------
r53388 | sargrass@google.com | 2010-07-22 23:31:06 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc
   D /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc:53376)
   A /trunk/src/chrome/browser/dom_ui/sync_options_handler.h (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h:53376)
   A /trunk/src/chrome/browser/resources/options/personal_options.css
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi

Add toolkit for personal stuff filter

BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options

Review URL: http://codereview.chromium.org/3056010
------------------------------------------------------------------------
r53387 | oshima@chromium.org | 2010-07-22 23:30:30 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Disble loading window icons for chromeos.

BUG=chromium-os:4996
TEST=manual: run debug build on the device. it should start without DCHECK error described in the bug above.

Review URL: http://codereview.chromium.org/2824068
------------------------------------------------------------------------
r53385 | jhawkins@chromium.org | 2010-07-22 23:26:18 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFill: Initialize form.user_submitted a few more places in the tests to
avoid memory errors.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3048012
------------------------------------------------------------------------
r53384 | jcivelli@chromium.org | 2010-07-22 23:24:17 +0200 (Thu, 22 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate_helper.cc
   M /trunk/src/chrome/renderer/translate_helper_unittest.cc

Few TranslateManager changes:
- Always show a "translating..." infobar when initiating a translation from the context menu, or when the translation is automatic (always translate option). It does not make sense not to show one, as translation may take several seconds and no having any feedback during that time is confusing (also this is what translate in toolbar does).
- Don't enable the translate context menu until we get the page language. This is an effort to ensure the translate infobar delegate always get an original language.
- Makes the translate manager deals correctly with unknown languages to avoid a crasher (bug 49018)

BUG=49018
TEST=See bug. And also, start a translation from the context menu, while the page is being translated a "translating..." infobar should be shown. Also, tests that when a language was selected for "always translate", navigating to a page in that language triggers a "translating..." infobar.

Review URL: http://codereview.chromium.org/3026002
------------------------------------------------------------------------
r53381 | bradnelson@google.com | 2010-07-22 23:09:17 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Reverting 53376

BUG=None
TEST=Non
TBR=nshkrob

Review URL: http://codereview.chromium.org/3012022
------------------------------------------------------------------------
r53376 | nshkrob@chromium.org | 2010-07-22 22:30:28 +0200 (Thu, 22 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Move blacklisting and pinned URLs from MostVisitedURLs to TopSites.

Prepopulated URLs are also moved into TopSites.
When TopSites becomes the default (without the flag), the corresponding code in MostVisitedURLs can be removed.

BUG=48564, 48566
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/3036003
------------------------------------------------------------------------
r53372 | nshkrob@chromium.org | 2010-07-22 22:00:36 +0200 (Thu, 22 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Fix a segfault in DeleteNotifications test caused by an invalid C-cast.

Re-enable the test.

BUG=49799
TEST=TopSitesTest::DeleteNotifications.

Review URL: http://codereview.chromium.org/2847066
------------------------------------------------------------------------
r53368 | sky@chromium.org | 2010-07-22 21:38:28 +0200 (Thu, 22 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Makes the auto fill editor on windows only enable the ok button if at
least one field has text. Also, fixes crash if you double click and
the table is empty.

BUG=47742
TEST=create a new address/credit card in the autofill profile manager
and make sure the ok button is only enabled if at least one field has
text.

Review URL: http://codereview.chromium.org/2809070
------------------------------------------------------------------------
r53367 | davej@chromium.org | 2010-07-22 21:34:46 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/audio_handler.cc
   M /trunk/src/chrome/browser/chromeos/audio_handler.h
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.cc
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.h

Sometimes pulseaudio is restarted if system goes into hibernation or sleep and resumes.  When
this happens, we were not reconnecting to pulse, and so could not adjust volume from that point on.

BUG=4017
TEST=In shell, kill the pulseaudio process.  It will auto-restart and volume keys should still work

Review URL: http://codereview.chromium.org/2959015
------------------------------------------------------------------------
r53361 | finnur@chromium.org | 2010-07-22 20:21:03 +0200 (Thu, 22 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc

Coverity: Check the return of GetTabId before using it.

Coverity issue 7161.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2873060
------------------------------------------------------------------------
r53360 | jhawkins@chromium.org | 2010-07-22 20:21:02 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.cc

AutoFill: Initialize |succeeded_| in the AutoFillXmlParser constructor.

CID=8457
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3033019
------------------------------------------------------------------------
r53358 | finnur@chromium.org | 2010-07-22 20:13:38 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_structure.cc

Coverity 8521: Uninitialized member vars in FormStructure.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3010024
------------------------------------------------------------------------
r53356 | jhawkins@chromium.org | 2010-07-22 19:56:51 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc

AutoFill: Always check the result of FormField::Add().

CID=8477
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2811064
------------------------------------------------------------------------
r53351 | stuartmorgan@chromium.org | 2010-07-22 19:26:05 +0200 (Thu, 22 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Revert 53342 - Switch back to disabling Core Animation for Flash (for branch merge).

This goes back to the M5 logic for managing Flash model negotiation on the Mac.

BUG=49169
TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show.

Review URL: http://codereview.chromium.org/3044015

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2832074
------------------------------------------------------------------------
r53350 | jhawkins@chromium.org | 2010-07-22 19:25:53 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/webkit/glue/form_data.h

AutoFill: Record whether the user initiated the form submission and don't save form data if the form was not user-submitted.

BUG=48225
TEST=none

Review URL: http://codereview.chromium.org/2842062
------------------------------------------------------------------------
r53347 | finnur@chromium.org | 2010-07-22 18:53:55 +0200 (Thu, 22 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_unittest.cc

Adding ASSERT to avoid crash if GetDictionary fails to find value. Also fixed some lint issues.

Minor Coverity issue (9399 and 9400).

BUG=None
TEST=Part of unit test.

Review URL: http://codereview.chromium.org/3014024
------------------------------------------------------------------------
r53345 | mazda@chromium.org | 2010-07-22 18:42:02 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_language_hangul_options.html
   D /trunk/src/chrome/browser/resources/options/chromeos_language_hangul_options.js
   M /trunk/src/chrome/browser/resources/options.html

Use the data-values attribute in Hangul options dialog and delete the corresponding js file.

BUG=chromium-os:4806
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/3017026
------------------------------------------------------------------------
r53343 | mirandac@google.com | 2010-07-22 18:20:57 +0200 (Thu, 22 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Some first run fixes:
Add missing first run bubble back to opening page.
Wait for search engines to load before displaying first run bubble, so correct search engine is displayed in first run.
Because some distributions use "skip-first-run-ui", add back the "import_items" code that passes values to this code path.  Because this code path is obsolete (most import is silent), this needs to be refactored in the long term.
Fix some spelling issues.

BUG= 42612
TEST= import with --skip-first-run-ui works 


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53198
Review URL: http://codereview.chromium.org/3042010
------------------------------------------------------------------------
r53342 | stuartmorgan@chromium.org | 2010-07-22 18:18:56 +0200 (Thu, 22 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Switch back to disabling Core Animation for Flash (for branch merge).

This goes back to the M5 logic for managing Flash model negotiation on the Mac.

BUG=49169
TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show.

Review URL: http://codereview.chromium.org/3044015
------------------------------------------------------------------------
r53328 | glotov@chromium.org | 2010-07-22 13:56:56 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   M /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

EULA screen updated to use DOMView to display EULAs,
actual EULAs are displayed. 

BUG=crosbug.com/3178 
TEST=chrome --login-manager --login-screen=eula

Review URL: http://codereview.chromium.org/3026008
------------------------------------------------------------------------
r53322 | mazda@chromium.org | 2010-07-22 12:49:55 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_chewing_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_chewing_options.html
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Add a DOM UI version of Chewing configuration dialog.

TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4807

Review URL: http://codereview.chromium.org/2921009
------------------------------------------------------------------------
r53321 | hans@chromium.org | 2010-07-22 12:27:36 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/device_orientation/enable_switch_browsertest.cc

Fix win build errors. Don't initialize FilePath with const char*.

BUG=None
TEST=Build should turn green

Review URL: http://codereview.chromium.org/2834066
------------------------------------------------------------------------
r53317 | hans@chromium.org | 2010-07-22 11:55:33 +0200 (Thu, 22 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   A /trunk/src/chrome/browser/device_orientation
   A /trunk/src/chrome/browser/device_orientation/enable_switch_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/test/data/device_orientation
   A /trunk/src/chrome/test/data/device_orientation/enable_switch_test.html

Add --enable-device-orientation switch and set ENABLE_DEVICE_ORIENTATION=1

Flip the compile-time enable switch for device orientation to on,
and add a command-line switch to put the functionality behind.

The command-line flag will be used both on the Chromium side,
and in WebKit via WebRuntimeFeatures.

BUG=44654
TEST=browser_tests --gtest_filter=DeviceOrientationEnableSwitchTest.*

Review URL: http://codereview.chromium.org/3042009
------------------------------------------------------------------------
r53315 | pfeldman@chromium.org | 2010-07-22 11:23:27 +0200 (Thu, 22 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

DevTools: render separators in context menu as separators, not items.

Review URL: http://codereview.chromium.org/3043012
------------------------------------------------------------------------
r53314 | mnissler@chromium.org | 2010-07-22 10:29:29 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix leak in DownloadManagerTest.

BUG=49268, 49307
TEST=valgrind bots should be green on DownloadManagerTest

Review URL: http://codereview.chromium.org/3038012
------------------------------------------------------------------------
r53304 | nirnimesh@chromium.org | 2010-07-22 06:55:28 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   M /trunk/src/chrome/test/functional/infobars.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Add PyAuto automation hooks to perform actions on infobars

Actions include: dismissing an infobar, accept/close-ing it

Also, enable infobars tests.

Review URL: http://codereview.chromium.org/3042012
------------------------------------------------------------------------
r53294 | sanjeevr@chromium.org | 2010-07-22 03:46:38 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Disabled zoom controls in the browser when displaying PDF using the internal PDF plugin. We want to persist zoom state for PDF separately from the zoom state for other content. As a stopgap measure, disabled all browser zoom controls in that scenario.
BUG=None
TEST=Test zooming when displaying a PDF using the Chrome PDF plugin. Then load or switch to another page (non-PDF) and check that zoom works.


Review URL: http://codereview.chromium.org/3007009
------------------------------------------------------------------------
r53292 | cmasone@google.com | 2010-07-22 03:27:13 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/owner_key_utils.cc (from /trunk/src/chrome/browser/chromeos/login/owner_manager.cc:53291)
   A /trunk/src/chrome/browser/chromeos/login/owner_key_utils.h
   A /trunk/src/chrome/browser/chromeos/login/owner_key_utils_unittest.cc (from /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc:53291)
   D /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   D /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   D /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Refactoring key generation and export util code to make mocking possible.

BUG=chromium-os:4485
TEST=unit tests

Review URL: http://codereview.chromium.org/3017020
------------------------------------------------------------------------
r53289 | chocobo@chromium.org | 2010-07-22 03:08:07 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h

Remove wait for preferred network (Google-A) connection during log in.
Oshima added a feature that will prevent pages from loading if there's no connection. We no longer need to hold up the browser from loading.
BUG=chromium-os:4034
BUG=chromium-os:4135
TEST=none
Review URL: http://codereview.chromium.org/3042016
------------------------------------------------------------------------
r53288 | zelidrag@chromium.org | 2010-07-22 03:00:21 +0200 (Thu, 22 Jul 2010) | 29 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/chromeos/DEPS
   M /trunk/src/chrome/browser/chromeos/cros/cros_api.gyp
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library_loader.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/cros/syslogs_library.h
   M /trunk/src/chrome/browser/chromeos/cros/system_library.h
   M /trunk/src/chrome/browser/chromeos/cros/update_library.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/google_update_chromeos.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.gyp
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_fav_icon.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_title.cc
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/chrome_browser.gypi

Checking in CL http://www.codereview.chromium.org/2836058 on behalf of zbehan@:


chrome: create an option for using libcros provided by the system; fix all
includes referring to libcros to not include third_party/

* Headers fix is needed to support using system libcros (installed to /usr/include)

* All includes are "", and therefore a local variant in third_party/cros/ is
always preferred, but system will also get picked up as a secondary target

* Fixed chrome/browser/chromeos/cros/synaptics_library.h comments to better
reflect the header placement

* Added a variable system_libcros defaulting to 0
* Gotten rid of duplicate cros_api.gyp
* Changed both places to either link against cros_api or libcrosapi

TEST=build in the following scenarios:
1) libcros not installed, libcros sources in third_party/, !defined system_libcros
- sucess
2) installed libcros, put #error into /usr/include/cros/chromeos_cros_api.h, repeat 1)
- success
3) BUILD_DEFINES+=system_libcros=1, removed libcros from third_party, repeat 2)
- fail (on #error in chromeos_cros_api.h)
4) Installed clean libcros, repeat 3)
- success

Review URL: http://codereview.chromium.org/3043010
------------------------------------------------------------------------
r53287 | oshima@chromium.org | 2010-07-22 02:59:33 +0200 (Thu, 22 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc

add expectations that were removed from setup in other cl.

These two expectation were removed in other CL when I added
new test.

TBR=krasimira@chromium.org
BUG=None
TEST=ScreenLockerTest.TextFullScreenExit should pass

Review URL: http://codereview.chromium.org/3051009
------------------------------------------------------------------------
r53283 | ananta@chromium.org | 2010-07-22 02:35:26 +0200 (Thu, 22 Jul 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Attempt 2 at landing this CL. The earlier one broke the build. We don't need to include the external_tab_container_win.h
file in tab_contents. That is the only change.

Links opening up in the host browser in ChromeFrame would not show up as
visited. This was because top level link navigations
are directly sent via the OpenURL mechanism to the host browser and as a result
the visited link history is not updated.

Fix is to update the navigation history in the
ExternalTabContainer::OpenURLFromTab function. We currently use the
UpdateHistoryForNavigation function in TabContents which is also used by regular
navigations initiated within the renderer.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=37262

Bug=37262
TBR=amit

Review URL: http://codereview.chromium.org/2809067
------------------------------------------------------------------------
r53282 | avi@chromium.org | 2010-07-22 02:19:39 +0200 (Thu, 22 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Revert 53272 - Quick fix for window sizing under resolution independence on Mac. Scrolling and the "more" arrows are still broken, but this at least makes things usable.

BUG=http://crbug.com/19476
TEST=run app under high-res, click bookmark bar button, see that the popup is sized to hold the buttons.

Review URL: http://codereview.chromium.org/3029020

TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/3010020
------------------------------------------------------------------------
r53277 | johnnyg@chromium.org | 2010-07-22 01:55:39 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc

Always refresh the desktop size before showing notifications.  This should prevent all the corner cases of misplacement being reported.

BUG=various
TEST=change desktop size, show notifications

Review URL: http://codereview.chromium.org/2824061
------------------------------------------------------------------------
r53276 | dhollowa@chromium.org | 2010-07-22 01:55:37 +0200 (Thu, 22 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc

AutoFill Empty profiles should not be saved from AutoFillDialog Add and Edit sheets on Mac.

Changes the AutoFillDialog on Mac to not store intermediate results of "Add" and "Edit" actions
when those actions result in empty address or credit card information.  Empty addresses and credit
card information is culled at this level now, not just after "Save" from the main dialog.

BUG=47742
TEST=AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewEmptyProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillDialogControllerTest.AddNewEmptyCreditCard

Review URL: http://codereview.chromium.org/3061001
------------------------------------------------------------------------
r53272 | avi@chromium.org | 2010-07-22 01:49:16 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Quick fix for window sizing under resolution independence on Mac. Scrolling and the "more" arrows are still broken, but this at least makes things usable.

BUG=http://crbug.com/19476
TEST=run app under high-res, click bookmark bar button, see that the popup is sized to hold the buttons.

Review URL: http://codereview.chromium.org/3029020
------------------------------------------------------------------------
r53269 | cmasone@google.com | 2010-07-22 01:46:45 +0200 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Change EXPECT_TRUE(false) to the more readable ADD_FAILURE()

BUG=None
TEST=run unit tests

Review URL: http://codereview.chromium.org/3061002
------------------------------------------------------------------------
r53268 | estade@chromium.org | 2010-07-22 01:46:20 +0200 (Thu, 22 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK: when closing a browser window, cancel the active drag session.

This speculatively works around an issue where users' windows would get stuck open in rare (non-reproducible, but widely reported) cases.

BUG=23733
TEST=none :(

Review URL: http://codereview.chromium.org/2888027
------------------------------------------------------------------------
r53265 | cmasone@google.com | 2010-07-22 01:43:59 +0200 (Thu, 22 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/owner_manager.cc

Fix valgrind error in OwnerManagerTest.ExportImportPublicKey

I was taking ownership of an object from NSS and then forgetting to free it :-/

BUG=49847
TEST=Ran unit test in question under valgrind

Now you don't even need to land http://codereview.chromium.org/2873057/show :-)

Review URL: http://codereview.chromium.org/2819060
------------------------------------------------------------------------
r53263 | tim@chromium.org | 2010-07-22 01:43:16 +0200 (Thu, 22 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html

Refactored the customize dialog UI. 

Original patch by dudley@chromium.org (http://codereview.chromium.org/2861069)

BUG=49704

Review URL: http://codereview.chromium.org/3019014
------------------------------------------------------------------------
r53256 | tim@chromium.org | 2010-07-22 00:17:36 +0200 (Thu, 22 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc

sync: fixes crash that happens when you disable a datatype while there are unsynced / unapplied items
pertaining to that type.

Added CHECKs to SafeToPurgeFromMemory to see if we catch any stack traces there and confirm that this is
indeed happening.

BUG=49278
TEST=SyncerTest.TestPurgeWhileUnsynced + TestPurgeWhileUnapplied

Review URL: http://codereview.chromium.org/2806064
------------------------------------------------------------------------
r53253 | sanjeevr@chromium.org | 2010-07-21 23:52:08 +0200 (Wed, 21 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Revert 53247 - Links opening up in the host browser in ChromeFrame would not show up as visited. This was because top level link navigations
are directly sent via the OpenURL mechanism to the host browser and as a result the visited link history is not updated.

Fix is to update the navigation history in the ExternalTabContainer::OpenURLFromTab function. We currently use the
UpdateHistoryForNavigation function in TabContents which is also used by regular navigations initiated within the renderer.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=37262

Bug=37262


Review URL: http://codereview.chromium.org/3020019

TBR=ananta@chromium.org
------------------------------------------------------------------------
r53247 | ananta@chromium.org | 2010-07-21 23:33:16 +0200 (Wed, 21 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Links opening up in the host browser in ChromeFrame would not show up as visited. This was because top level link navigations
are directly sent via the OpenURL mechanism to the host browser and as a result the visited link history is not updated.

Fix is to update the navigation history in the ExternalTabContainer::OpenURLFromTab function. We currently use the
UpdateHistoryForNavigation function in TabContents which is also used by regular navigations initiated within the renderer.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=37262

Bug=37262


Review URL: http://codereview.chromium.org/3020019
------------------------------------------------------------------------
r53246 | erg@google.com | 2010-07-21 23:30:13 +0200 (Wed, 21 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_unittest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/metrics_helpers.h

Start trimming headers included in the slowest to compile files.

Big chunk in the automation code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3056007
------------------------------------------------------------------------
r53242 | oshima@chromium.org | 2010-07-21 23:07:31 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc

fix build breakage caused by merge error.

TBR=krasimira@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2809065
------------------------------------------------------------------------
r53241 | oshima@chromium.org | 2010-07-21 22:47:03 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc

Send UnlockCompleted signal even if screen lock is already present.

BUG=chromium-os:4827
TEST=new test TestShowTwice

Review URL: http://codereview.chromium.org/2854055
------------------------------------------------------------------------
r53237 | kurrik@chromium.org | 2010-07-21 22:04:42 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/ntp/util.js

Fixes the regex used to test for the Mac platform.

BUG=49809
TEST=None

Review URL: http://codereview.chromium.org/2805097
------------------------------------------------------------------------
r53235 | oshima@chromium.org | 2010-07-21 21:55:25 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Use check item for side tab menu.

BUG=chromium-os:4948
TEST=manual: toggle side tab from wrench menu and side tab menu will be checked.

Review URL: http://codereview.chromium.org/3034021
------------------------------------------------------------------------
r53234 | jhawkins@chromium.org | 2010-07-21 21:53:23 +0200 (Wed, 21 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h

Fix for: State in small letters should be auto-filled from the profile.

BUG=38222
TEST=in the bug

Patch by George Yakovleg <georgey@chromium.org>

Review URL: http://codereview.chromium.org/2832064
------------------------------------------------------------------------
r53233 | jshin@chromium.org | 2010-07-21 21:50:58 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc

Address Finnur's review comments (variable names and comments) that were
dropped inadvertently when landing from a machine other than one where the
original CL was written.

In addition, adjust Tamil and Malayalam UI dimensions for XP.

BUG=48202
TEST=In Tamil and Malyalam Chrome on XP, content-settings dialog do not have anytruncation.
TBR=finnur
Review URL: http://codereview.chromium.org/3015011
------------------------------------------------------------------------
r53231 | davidben@chromium.org | 2010-07-21 21:34:49 +0200 (Wed, 21 Jul 2010) | 22 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/ssl_client_certificate_selector.mm
   A /trunk/src/chrome/browser/gtk/ssl_client_certificate_selector.cc (from /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_gtk.cc:53228)
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_notification_task.h
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   D /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_gtk.cc
   D /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_mac.mm
   D /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_win.cc
   A /trunk/src/chrome/browser/ssl_client_certificate_selector.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.cc
   A /trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.h
   A /trunk/src/chrome/browser/views/ssl_client_certificate_selector_win.cc (from /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_win.cc:53228)
   M /trunk/src/chrome/chrome_browser.gypi

Refactor SSLClientAuthHandler and certificate selection

This cleans up much of the code involved in displaying a certificate selection
dialog to the user.

- Adds a new inner class to RenderViewHostDelegate (later to be populated
  with more SSL things).
- Adds a helper class for TabContents' implementation.
- Moves the certificate dialogs themselves to have a common entry point.
- Makes SSLClientAuthHandler call the RVHDelegate to query the user, with the
  TabContents implementation displaying the dialogs.
- Picks the correct parent window for the dialog on all platforms, instead of
  relying on BrowserList::GetLastActive
- Makes the OS X implementation use an asynchronous sheet, now that we know the
  parent.
- Fixes an index-mismatch problem in the OS X implementation, should we fail to create an identity.

R=agl,brettw,mark
BUG=148
TEST=selecting client certificates still works

Review URL: http://codereview.chromium.org/2823038
------------------------------------------------------------------------
r53229 | oshima@chromium.org | 2010-07-21 21:20:46 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_state_notifier.cc

Increase network state change notification delay to 2seconds.

BUG=chromium-os:4825
TEST=none

Review URL: http://codereview.chromium.org/3031016
------------------------------------------------------------------------
r53227 | chocobo@chromium.org | 2010-07-21 21:11:28 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Land for njw:
Make NetworkLibrary::UpdateSystemInfo() externally usable, and invoke 
it before retrieving/displaying network information, so that we 
successfully display data that the user has just changed via another 
mechanism. 
BUG=chromium-os:3972 
TEST=Configure certificates via entd and log out. Log back in and select the 
network menu, then (immediately) the relevant SSID. Check for the proper 
certificate information, rather than unset fields.
Review URL: http://codereview.chromium.org/3019015
------------------------------------------------------------------------
r53226 | oshima@chromium.org | 2010-07-21 21:07:54 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h

Exit Fullscreen when screen is locked

BUG=chromium-os:4212
TEST=TestFullscreenExit added

Review URL: http://codereview.chromium.org/2832063
------------------------------------------------------------------------
r53224 | pinkerton@chromium.org | 2010-07-21 21:01:18 +0200 (Wed, 21 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm

Conditionally draw a bezel below text fields, used for the omnibox.
BUG=49793
TEST=visual inspection. unit tests shouldn't leak or crash on drawing.
Review URL: http://codereview.chromium.org/3042014
------------------------------------------------------------------------
r53223 | chron@chromium.org | 2010-07-21 20:58:33 +0200 (Wed, 21 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

Fix deadlock by introducing a new transaction event.

This is still going through the trybots now.

Review URL: http://codereview.chromium.org/2805095
------------------------------------------------------------------------
r53221 | sanjeevr@chromium.org | 2010-07-21 20:31:43 +0200 (Wed, 21 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc

UpdateZoomControls honors the global enabled state of the zoom commands.
BUG=None
TEST=Test zooming.

Review URL: http://codereview.chromium.org/3055006
------------------------------------------------------------------------
r53220 | jcivelli@chromium.org | 2010-07-21 20:30:05 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc

Makes the browser fetch the translate script regularly.
New versions of that script may get pushed from time to time.
Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions.

Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide).

BUG=None
TEST=Run the unit-tests.

Review URL: http://codereview.chromium.org/3034013
------------------------------------------------------------------------
r53219 | albertb@chromium.org | 2010-07-21 20:29:45 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc

Update the sync node title for classic autofill to be
"autofill_entry|$name|$value".

BUG=40876
TEST=none

Review URL: http://codereview.chromium.org/3005013
------------------------------------------------------------------------
r53217 | phajdan.jr@chromium.org | 2010-07-21 20:26:45 +0200 (Wed, 21 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc

Download code cleanup:

Changed the code to be more object-oriented. Instead of exposing 150 accessors
we should do as much as possible inside the object, exposing a nice API.
DownloadFile just got a small step closer to that.

Also, reduce amount of state duplication. For example, information about
the download progress was both in DownloadFile and DownloadFileManager
(maybe it's still somewhere else). The download path information
is still duplicated, removing it is going to be harder.

Finally, removed completely unused state variables from DownloadFile.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3026012
------------------------------------------------------------------------
r53213 | phajdan.jr@chromium.org | 2010-07-21 20:12:50 +0200 (Wed, 21 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.h

Fix the compile for good. Used a wrong value in one of FRIEND_TEST_ALL_PREFIXES declarations.

TBR=dhollowa

Review URL: http://codereview.chromium.org/3026014
------------------------------------------------------------------------
r53212 | phajdan.jr@chromium.org | 2010-07-21 20:01:29 +0200 (Wed, 21 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.h

Fix compile by using FRIEND_TEST_ALL_PREFIXES.

TBR=dhollowa

Review URL: http://codereview.chromium.org/3026013
------------------------------------------------------------------------
r53211 | mirandac@google.com | 2010-07-21 19:46:03 +0200 (Wed, 21 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Revert 53198 - Some first run fixes:
Add missing first run bubble back to opening page.
Wait for search engines to load before displaying first run bubble, so correct search engine is displayed in first run.
Because some distributions use "skip-first-run-ui", add back the "import_items" code that passes values to this code path.  Because this code path is obsolete (most import is silent), this needs to be refactored in the long term.
Fix some spelling issues.

BUG= 42612
TEST= import with --skip-first-run-ui works 

Review URL: http://codereview.chromium.org/3042010

TBR=mirandac@google.com
Review URL: http://codereview.chromium.org/3025009
------------------------------------------------------------------------
r53210 | albertb@chromium.org | 2010-07-21 19:45:45 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/user_settings_posix.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc

Load the token from the user settings DB as a blob because it might include
NULLs now that encrypt it.

BUG=49593
TEST=manually tested + updated unit tests

Review URL: http://codereview.chromium.org/3058003
------------------------------------------------------------------------
r53209 | stuartmorgan@chromium.org | 2010-07-21 19:43:12 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/browser_options.js

Strip & accelerator markers from buttons on the Basics DOMUI pref page

BUG=None
TEST=Open DOMUI prefs; Add and Remove buttons on Basics page should not show &s.

Review URL: http://codereview.chromium.org/2888025
------------------------------------------------------------------------
r53208 | dhollowa@chromium.org | 2010-07-21 19:40:49 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Marking TopSitesTest.DeleteNotifications as DISABLED

Marks TopSitesTest.DeleteNotifications as DISABLED.  This test has been failing to complete
on Mac 10.6 sporadically.  E.g. http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests/builds/5065/steps/unit_tests/logs/DeleteNotifications

BUG=49799
TEST=TopSitesTest.DeleteNotifications
TBR=nshkrob@chromium.org

Review URL: http://codereview.chromium.org/2832066
------------------------------------------------------------------------
r53204 | sky@chromium.org | 2010-07-21 19:33:03 +0200 (Wed, 21 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_location_bar.h

Attemp 2 at:

Makes the toolbar visible for apps again. Here's the set of patches I
reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for
45566) If you see anything missing, please let me know.
Also, there are some grd strings no longer necessary. I'll nuke those
separately.

BUG=49013
TEST=none
TBR=finnur

Review URL: http://codereview.chromium.org/3056003
------------------------------------------------------------------------
r53203 | phajdan.jr@chromium.org | 2010-07-21 19:19:12 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/multipart_uitest.cc

Fix build by using correct UI test function - user_data_dir()
instead of directly accessing member user_data_dir_.

TBR=huanr

Review URL: http://codereview.chromium.org/3047008
------------------------------------------------------------------------
r53199 | dhollowa@chromium.org | 2010-07-21 18:52:45 +0200 (Wed, 21 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm

AutoFill Profiles dialog handles multi-select and delete on Mac (Follow up)

Changes index set traversal logic for multi-select and delete of AutoFillDialog table
elements on Mac.  This is follow-up from Thakis' review comment in review http://codereview.chromium.org/3039014.

BUG=49344
TEST=AutoFillDialogControllerTest.DeleteMultiple

Review URL: http://codereview.chromium.org/3056005
------------------------------------------------------------------------
r53198 | mirandac@google.com | 2010-07-21 18:52:30 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Some first run fixes:
Add missing first run bubble back to opening page.
Wait for search engines to load before displaying first run bubble, so correct search engine is displayed in first run.
Because some distributions use "skip-first-run-ui", add back the "import_items" code that passes values to this code path.  Because this code path is obsolete (most import is silent), this needs to be refactored in the long term.
Fix some spelling issues.

BUG= 42612
TEST= import with --skip-first-run-ui works 

Review URL: http://codereview.chromium.org/3042010
------------------------------------------------------------------------
r53193 | evan@chromium.org | 2010-07-21 17:57:23 +0200 (Wed, 21 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/courgette/courgette_tool.cc
   M /trunk/src/media/test/ffmpeg_tests/ffmpeg_tests.cc
   M /trunk/src/media/tools/media_bench/media_bench.cc
   M /trunk/src/media/tools/player_wtl/player_wtl.cc
   M /trunk/src/media/tools/scaler_bench/scaler_bench.cc
   M /trunk/src/media/tools/wav_ola_test/wav_ola_test.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/o3d/converter/cross/converter_main.cc
   M /trunk/src/o3d/converter/cross/verifier_main.cc
   M /trunk/src/o3d/converter_edge/cross/converter_main.cc
   M /trunk/src/o3d/converter_edge/cross/verifier_main.cc
   M /trunk/src/tools/imagediff/image_diff.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Remove deprecated CommandLine::GetLooseValues(), rename to args().

It returned a wstring, when really we wanted the native encoded
strings.  Fixing the majority of callers actually simplified them
in many cases because the callers wanted native strings too.

Since I'm touching every caller, I gave it a more useful name.
I'm not sure where "loose" came from but it never made sense to me.

BUG=24672

Review URL: http://codereview.chromium.org/3028010
------------------------------------------------------------------------
r53192 | davemoore@chromium.org | 2010-07-21 17:55:48 +0200 (Wed, 21 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.h
   D /trunk/src/chrome/browser/chromeos/browser_notification_observers.cc
   D /trunk/src/chrome/browser/chromeos/browser_notification_observers.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/chrome_browser.gypi

Added file to track login times, and moved functionality to boot_times_loader.
BUG=chromium-os:4727
TEST=None

Review URL: http://codereview.chromium.org/2858061
------------------------------------------------------------------------
r53189 | oshima@chromium.org | 2010-07-21 17:45:00 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Change screen locker window type from popup to window
 WM will resize the window to fullscreen.

BUG=4399
TEST=none

Review URL: http://codereview.chromium.org/3019013
------------------------------------------------------------------------
r53188 | finnur@chromium.org | 2010-07-21 17:41:58 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc

Make sure restart due to Upgrade Notification works, even if the browser was started through ShellExecute (with a switch argument terminator).

BUG=46182
TEST=Launch Chrome on Windows by double clicking on a .htm file. Wait for Chrome to be upgraded in the background, select Update Chrome from Wrench menu and make sure your session is properly restored (even if Restore Last Session is not set).

Review URL: http://codereview.chromium.org/2868063
------------------------------------------------------------------------
r53187 | sky@chromium.org | 2010-07-21 17:41:09 +0200 (Wed, 21 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/slider/slider.cc
   M /trunk/src/views/controls/slider/slider.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_search.cc
   M /trunk/src/views/focus/focus_search.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Fixes regression in links ending up too small. The problem is that we
changed IsFocusable to check IsVisibleInRootView. This meant that any
views (like label) whose preferred size takes into account focusable
and cached the preferred size before they were visible in the root
view would end up with the wrong size because they didn't recalculate
when IsVisibleInRootView changed.

I've separated out the two states so that IsFocusable no longer checks
IsVisibleInRootView and is protected. All consumers now call
IsFocusableInRootView which checks IsFocusable and
IsVisibleInRootView.

BUG=49635
TEST=see bug.

Review URL: http://codereview.chromium.org/3046008
------------------------------------------------------------------------
r53186 | jochen@chromium.org | 2010-07-21 17:34:24 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc

Before creating a content setting, check that you actually *can* create it.

BUG=none
TEST=none
R=danno@chromium.org

Review URL: http://codereview.chromium.org/3020018
------------------------------------------------------------------------
r53185 | rsesek@chromium.org | 2010-07-21 17:33:15 +0200 (Wed, 21 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm

[Mac] Use |-performSelector:withDelay:| to execute commands from the Wrench menu.

This avoids doing work from within the menu's nested run loop, which can lead to
wonky behavior.

BUG=49716
TEST=Enter full screen from Wrench menu a few times. The overlay always appears.

Review URL: http://codereview.chromium.org/3014021
------------------------------------------------------------------------
r53184 | rdsmith@google.com | 2010-07-21 17:29:57 +0200 (Wed, 21 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_notification_details.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/glue/webcookie.h

Changed type CookieList to being a vector CanonicalCookies.

Originally, it was a vector of pair<domain_string, CanonicalCookie>.

TEST=Refactor; all relevant unit tests should still pass.
BUG=8850

Review URL: http://codereview.chromium.org/2799057
------------------------------------------------------------------------
r53182 | agl@chromium.org | 2010-07-21 16:35:34 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc

Linux certificate viewer: add SHA256 hash

BUG=none
TEST=Navigate to https://encrypted.google.com. Click the green padlock in the URL bar. Click "Certificate Information". Verify that a SHA-256 hash appears.

http://codereview.chromium.org/3005016
------------------------------------------------------------------------
r53181 | avi@chromium.org | 2010-07-21 16:19:55 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Unblackify the upgrade ball.

BUG=http://crbug.com/49370
TEST=as in bug

Review URL: http://codereview.chromium.org/3047005
------------------------------------------------------------------------
r53179 | mnissler@chromium.org | 2010-07-21 15:54:08 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/data/profiles/chrome_prefs/History
   D /trunk/src/chrome/test/data/profiles/chrome_prefs/Preferences
   A /trunk/src/chrome/test/testing_pref_service.cc
   A /trunk/src/chrome/test/testing_pref_service.h
   M /trunk/src/chrome/test/testing_profile.h

Adjust preference sync code to only sync user modifiable preferences.

Switch to the new preference value source checkers in Preference. While at it,
add a unit test and better test infrastructure for controlling preference
values in tests. Convert existing unit tests where appropriate.

BUG=48952
TEST=ProfileSyncServicePreferenceTest.ManagedPreferences

Review URL: http://codereview.chromium.org/3051001
------------------------------------------------------------------------
r53178 | cbentzel@chromium.org | 2010-07-21 15:51:32 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_tracker.cc
   M /trunk/src/net/url_request/url_request_job_tracker.h
   A /trunk/src/net/url_request/url_request_job_tracker_unittest.cc

Add the actual data being read to the OnBytesRead callback.

This is needed for code at http://code.google.com/p/page-speed/source/browse/bin/trunk/src/pagespeed/pagespeed_input_populator.cc#148

Contributed by: bmcquade@google.com

BUG=48192
TEST=Added new unit tests, ran net_unittests.

Review URL: http://codereview.chromium.org/2849041
------------------------------------------------------------------------
r53177 | nkostylev@google.com | 2010-07-21 13:41:38 +0200 (Wed, 21 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/resources/host_registration_page.html

Relanding http://codereview.chromium.org/3044001.
I've guarded all chromium-os specific stuff at register_page_ui.cc with ifdef.

Original CL description:
Add getUserInfo, getRegistrationUrl message callback for register screen.
Restrict chrome://register to OOBE wizard only.
Actually delete about:register.

BUG= http://crosbug.com/4813
TEST=none

Review URL: http://codereview.chromium.org/2825057
------------------------------------------------------------------------
r53176 | pfeldman@chromium.org | 2010-07-21 13:22:23 +0200 (Wed, 21 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer.h
   A /trunk/src/chrome/browser/net/load_timing_observer_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h

LoadTimingObserver: only send timing struct over IPC if necessary. + Added unit tests.

Review URL: http://codereview.chromium.org/3057001
------------------------------------------------------------------------
r53170 | zork@chromium.org | 2010-07-21 11:52:59 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.h

Resend ibus config data when it reconnects.
Don't start up the connection if we're only requesting active engines.

BUG=chromium-os:4244
TEST=Enable ibus-chewing.  Change the number of candidates to 8.  Kill ibus-daemon.  Go to a text window and enable ibus-chewing.  type "hol" and press space.  Check that 8 candidates show up.

Review URL: http://codereview.chromium.org/2877016
------------------------------------------------------------------------
r53169 | finnur@chromium.org | 2010-07-21 11:39:16 +0200 (Wed, 21 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/manifest.json
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/subscribe.js
   A /trunk/src/chrome/test/data/feeds/feed6.xml

RSS subscription extension: Handle HTML appended after RSS feed.

I've come across some feeds that append (a sometimes invalid) HTML/script below a valid RSS feed, which trips up the XMLHTTPRequest object (responseXML becomes NULL). I've changed it so that if the XML document returned by responseXML is null we try to DOMparse responseText instead and we don't abort if there is an error (unless the doc is still empty). This will at least show partial feed data instead of 'invalid feed' error (and show full feed data if the syntax error is below the feed).

BUG=None
TEST=Covered by automated test.

Review URL: http://codereview.chromium.org/3031014
------------------------------------------------------------------------
r53161 | nirnimesh@chromium.org | 2010-07-21 08:49:52 +0200 (Wed, 21 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   A /trunk/src/chrome/test/functional/infobars.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Fetch info about infobars

This includes user-visible info about the following types of infobars:
  - ConfirmInfoBarDelegate (includes ThemeInstalledInfoBarDelegate & CrashedExtensionInfoBarDelegate)
  - AlertInfoBarDelegate
  - LinkInfoBarDelegate
  - TranslateInfoBarDelegate

Adds a test to verify crash infobar when a (flash) plugin dies.

Review URL: http://codereview.chromium.org/2305001
------------------------------------------------------------------------
r53159 | nick@chromium.org | 2010-07-21 08:45:05 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc

Generate properly unique IDs for autofill items originating from sync.

BUG=49648
TEST=TwoClientLiveAutofillSyncTest.ProfileSteady

Review URL: http://codereview.chromium.org/3029017
------------------------------------------------------------------------
r53155 | cmasone@google.com | 2010-07-21 07:14:30 +0200 (Wed, 21 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Read chromium os localacccount file on the FILE thread

Even though the file is tiny, we should read it on the FILE thread and not the UI thread.

BUG=None
TEST=unit tests, put onto a device and verify that online, offline and localaccount logins all work.

Review URL: http://codereview.chromium.org/2873051
------------------------------------------------------------------------
r53153 | cmasone@google.com | 2010-07-21 06:46:51 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/owner_manager.cc
   A /trunk/src/chrome/browser/chromeos/login/owner_manager.h
   A /trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

The owner of a chrome os device will have an RSA keypair that we'll use for various purposes.  This CL implements some helper functions that we'll use to generate this key and store the halves in the places we need them.

BUG=chromium-os:4485
TEST=unit tests

Review URL: http://codereview.chromium.org/2891001
------------------------------------------------------------------------
r53149 | kinuko@chromium.org | 2010-07-21 05:23:56 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_item.cc
   M /trunk/src/chrome/browser/download/download_item.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h

Rename the download to its final name only after the download is finished

BUG=27687, 28928
TEST=DownloadManagerTest.DownloadRenameTest

Review URL: http://codereview.chromium.org/2877008
------------------------------------------------------------------------
r53148 | oshima@chromium.org | 2010-07-21 05:15:22 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc

Make notification panel vertically resizable.
Dismiss all non sticky when the panel is closed.

BUG=chromium-os:4771, chromium-os:3847
TEST=added new TestCloseDissmissAllNonSticky test

Review URL: http://codereview.chromium.org/3029006
------------------------------------------------------------------------
r53147 | cevans@chromium.org | 2010-07-21 05:03:05 +0200 (Wed, 21 Jul 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc:53069)
   A /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h:53069)
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   D /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   D /trunk/src/chrome/browser/dom_ui/sync_options_handler.h
   D /trunk/src/chrome/browser/resources/options/personal_options.css
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Revert 53070 - Relanding: Personal stuff page in tabbed options
Relanding issue 2819046

BUG=48883
TEST=Exercise Personal Stuff page via --enable-tabbed-options

Review URL: http://codereview.chromium.org/3042005

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3044014
------------------------------------------------------------------------
r53145 | cevans@chromium.org | 2010-07-21 05:00:35 +0200 (Wed, 21 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/personal_options.html

Revert 53126 - Fix compile on Linus Views

BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3012014

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3015013
------------------------------------------------------------------------
r53144 | cevans@chromium.org | 2010-07-21 04:59:57 +0200 (Wed, 21 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/personal_options.html

Revert 53133 - Fix Linux Views unit test failure (disable browser.custom_chrome_frame for now).

BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3017015

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3025007
------------------------------------------------------------------------
r53143 | tfarina@chromium.org | 2010-07-21 04:59:28 +0200 (Wed, 21 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/env_var.cc
   M /trunk/src/base/env_var.h
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/remoting/host/simple_host_process.cc

base: add home environment variable to env_var.h

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2847058
------------------------------------------------------------------------
r53140 | chocobo@chromium.org | 2010-07-21 03:51:55 +0200 (Wed, 21 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc

Land for jackc:
Fix for ethernet not getting detected in login screen 

Old version would always chose the last available 
ethernet service in the list. This change makes it 
so it chooses a connected service over a unconnected 
service. 

BUG=None 
TEST=Ran browser with this change 
Review URL: http://codereview.chromium.org/3027015
------------------------------------------------------------------------
r53139 | jrg@chromium.org | 2010-07-21 03:20:35 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Scroll bookmark bar folders faster.

BUG=http://crbug.com/42028
TEST=Scroll.  See scroll.  See scroll faster.

Review URL: http://codereview.chromium.org/3030008
------------------------------------------------------------------------
r53133 | csilv@chromium.org | 2010-07-21 03:13:02 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/personal_options.html

Fix Linux Views unit test failure (disable browser.custom_chrome_frame for now).

BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3017015
------------------------------------------------------------------------
r53130 | jhawkins@chromium.org | 2010-07-21 02:54:01 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc

AutoFill: Limit the size of form field data allowed to be saved in WebData as a
temporary workaround to prevent DOS'ing the browser with large profile data.

BUG=49172
TEST=WebDatabase.*

Review URL: http://codereview.chromium.org/2811059
------------------------------------------------------------------------
r53128 | andybons@chromium.org | 2010-07-21 02:20:24 +0200 (Wed, 21 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

[Mac] Give active tabs an appropriate inner highlight to reduce visual artifacts caused by the toolbar border/highlight not matching the tab's. Also clean up the tab view class a bit.

http://cl.ly/09ac3bec2f1e0eca91db

TEST=visual
BUG=44574
Review URL: http://codereview.chromium.org/2834059
------------------------------------------------------------------------
r53127 | akalin@chromium.org | 2010-07-21 02:14:50 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.h

Added checks to handle unsyncable extensions.

BUG=49346,46516
TEST=manual, unit tests

Review URL: http://codereview.chromium.org/2884027
------------------------------------------------------------------------
r53126 | csilv@chromium.org | 2010-07-21 01:59:23 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/personal_options.html

Fix compile on Linus Views

BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3012014
------------------------------------------------------------------------
r53121 | seh@chromium.org | 2010-07-21 01:07:42 +0200 (Wed, 21 Jul 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/central_roster.html

Auto reload page and add a manual reload button if plugin not loaded.
Review URL: http://codereview.chromium.org/2809059
------------------------------------------------------------------------
r53118 | jrg@chromium.org | 2010-07-21 01:05:26 +0200 (Wed, 21 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Tweak OffTheSide bookmark delete.

BUG=http://crbug.com/49638
TEST=green tree

Review URL: http://codereview.chromium.org/2824065
------------------------------------------------------------------------
r53114 | stuartmorgan@chromium.org | 2010-07-21 01:02:40 +0200 (Wed, 21 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html

Hook up the radio buttons and URL field on the DOMUI Basics prefs page

The URL field doesn't yet enable/disable based on the radio button selection; that will be a follow-up.

BUG=48713
TEST=Radio buttons and URL field on the Basics page should work.

Review URL: http://codereview.chromium.org/3025003
------------------------------------------------------------------------
r53113 | thestig@chromium.org | 2010-07-21 01:02:11 +0200 (Wed, 21 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   D /trunk/src/chrome/app/chrome_version_info.cc
   D /trunk/src/chrome/app/chrome_version_info.h
   D /trunk/src/chrome/app/chrome_version_info_posix.h.version
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/memory_details_mac.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/chrome_exe.gypi
   A /trunk/src/chrome/common/chrome_version_info.cc (from /trunk/src/chrome/app/chrome_version_info.cc:50171)
   A /trunk/src/chrome/common/chrome_version_info.h (from /trunk/src/chrome/app/chrome_version_info.h:50171)
   A /trunk/src/chrome/common/chrome_version_info_posix.h.version (from /trunk/src/chrome/app/chrome_version_info_posix.h.version:50171)
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome_frame/metrics_service.cc

Cleanup: Break another common->app dependency.

BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/3007008
------------------------------------------------------------------------
r53108 | atwilson@chromium.org | 2010-07-20 23:52:18 +0200 (Tue, 20 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list_stub.cc

Fixing compilation error (AllBrowsersClosed()->AllBrowsersClosedAndAppExiting()).

TBR=pinkerton

Review URL: http://codereview.chromium.org/2832065
------------------------------------------------------------------------
r53102 | akalin@chromium.org | 2010-07-20 23:23:26 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Disallow syncing of extensions with third-party update URLs or plugins.

BUG=49346,46516
TEST=new unit tests, manual

Review URL: http://codereview.chromium.org/2884025
------------------------------------------------------------------------
r53093 | pkasting@chromium.org | 2010-07-20 22:54:18 +0200 (Tue, 20 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

Make the sync setup throbbers animate again.

BUG=49645
TEST=Set up sync, make sure throbbers that appear spin.
Review URL: http://codereview.chromium.org/3029012
------------------------------------------------------------------------
r53092 | atwilson@chromium.org | 2010-07-20 22:52:20 +0200 (Tue, 20 Jul 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service.h
   M /trunk/src/chrome/browser/background_contents_service_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_list_gtk.cc
   M /trunk/src/chrome/browser/browser_list_mac.mm
   M /trunk/src/chrome/browser/browser_list_win.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/js_modal_dialog.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_browser_process.h

Moved code that generates APP_TERMINATING notification into BrowserList so it can be used on all platforms. Updated observers (ExtensionProcessManager,
BackgroundContents) to listen for APP_TERMINATING instead of listening for
BROWSER_CLOSED on some platforms.

APP_TERMINATING is now sent just before the main message loop exits rather than  just after, but no code depends on this timing.

Updated Mac code to always call BrowserList::CloseAllBrowsers() even if there
are no open browsers, to ensure that APP_TERMINATING is always fired.

Changed BackgroundContentsService to keep the browser process alive when there
are BackgroundContents running and updated the unit tests.

Renamed BrowserList::IsInPersistentMode() => WillShutdownWhenLastBrowserCloses() and AllBrowsersClosed() => AllBrowsersClosedAndAppExiting() to more precisely indicate their true functions.

Exposed BrowserProcess::ModuleRefCount() so BrowserList can determine when the application is going to exit so the right notifications/callbacks can be generated.

Updated background-auto-update-restart code to use new BrowserList APIs to determine whether the application is running "in the background".

Added code to cancel shutdown on all plaforms if the user selects cancel in an onbeforeunload dialog.
BUG=45275
TEST=RunInBackgroundTest (ui_test)

Review URL: http://codereview.chromium.org/2866034
------------------------------------------------------------------------
r53091 | dhollowa@chromium.org | 2010-07-20 22:49:52 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc

Sync tests cleanup, consolidate Encryptor mock calls into fixture SetUp

This is follow-up from review http://codereview.chromium.org/2835041.

BUG=none
TEST=UserSettingsTest.PersistEmptyToken, UserSettingsTest.PersistNonEmptyToken

Review URL: http://codereview.chromium.org/2854049
------------------------------------------------------------------------
r53089 | estade@chromium.org | 2010-07-20 22:40:39 +0200 (Tue, 20 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_system_nss.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/data/firefox2_profile/history.dat

Port ImporterTest to posix.

Changes:
- only compile IE stuff on Win
- delete unused vars, mismatched signage
- don't create the profile directory explicitly. CopyDirectory with recursive=true will move the directory *into* the target dir, rather than merging its contents with those of the target dir. The easiest workaround is to make the target dir non-existant, which changes the behavior to what we want.
- get rid of CRLF in the firefox2 history example, which was making the history import fail.
- relax NSSDecryptor::Decrypt.

BUG=none
TEST=ImporterTest runs/passes on all trybots

Review URL: http://codereview.chromium.org/2811036
------------------------------------------------------------------------
r53087 | jrg@chromium.org | 2010-07-20 22:32:06 +0200 (Tue, 20 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

Send away bookmark bar folder when going fullscreen with menu.

BUG=http://crbug.com/49340
TEST=Open a bookmark folder.
With the VIEW MENU (not the keystroke), go fullscreen.
 --> see "chrome" gone (unless mouse at top of screen); see bookmark menu gone.
With the VIEW MENU (not the keystroke), go normal-screen.
 --> see no bookmark menu.


Review URL: http://codereview.chromium.org/3044012
------------------------------------------------------------------------
r53083 | erg@google.com | 2010-07-20 22:08:23 +0200 (Tue, 20 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/base/crypto/rsa_private_key.cc
   M /trunk/src/base/crypto/rsa_private_key_nss.cc
   M /trunk/src/base/crypto/rsa_private_key_win.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/linked_ptr_unittest.cc
   M /trunk/src/base/string_piece.cc
   M /trunk/src/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.cc
   M /trunk/src/chrome/browser/process_info_snapshot_mac.cc
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/helper_unittest.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/shell_util_unittest.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/test_launcher/test_runner.cc
   M /trunk/src/chrome/test/v8_unit_test.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/courgette/disassembler.cc
   M /trunk/src/gfx/insets_unittest.cc
   M /trunk/src/gfx/point.cc
   M /trunk/src/gfx/rect.cc
   M /trunk/src/gfx/size.cc
   M /trunk/src/ipc/ipc_fuzzing_tests.cc
   M /trunk/src/ipc/ipc_tests.cc
   M /trunk/src/ipc/sync_socket_unittest.cc
   M /trunk/src/net/base/x509_cert_types.cc
   M /trunk/src/net/base/x509_cert_types.h
   M /trunk/src/net/tools/flip_server/balsa_frame.cc
   M /trunk/src/net/tools/flip_server/balsa_headers.cc
   M /trunk/src/net/tools/flip_server/balsa_headers.h
   M /trunk/src/net/tools/flip_server/create_listener.cc
   M /trunk/src/net/tools/flip_server/create_listener.h
   M /trunk/src/sandbox/linux/seccomp/library.cc
   M /trunk/src/sandbox/linux/seccomp/maps.cc
   M /trunk/src/sandbox/linux/seccomp/sandbox_impl.h

Remove <iostream> where possible.

<iostream> creates a static initializer. Most people don't need <iostream>
anyway--they really  need <ostream> for operator<< overloads. <iostream>
should *never* be included in a header file; <iosfwd> exists for that purpose.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3014015
------------------------------------------------------------------------
r53082 | davidben@chromium.org | 2010-07-20 21:59:01 +0200 (Tue, 20 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h

Make ResourceDispatcherHostRequestInfo own SSLClientAuthHandler and LoginHandler references

This avoids problems where the objects disappear while the
ResourceDispatcherHostRequestInfo still holds pointers. In particular,
SSLClientAuthHandler handler adds and removes a reference to itself when the
user dismisses the dialog. ResourceDispatcherHost, however, still holds a
pointer and may attempt to notify it of a cancelled request. This stray write
may NULL out a useful field and crash.

BUG=49352
TEST=steps in bug report

Review URL: http://codereview.chromium.org/3043008
------------------------------------------------------------------------
r53081 | davej@google.com | 2010-07-20 21:47:46 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.cc
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.h

In an attempt to clear up the Issue 48553 memory leak during init, I re-ordered some of the
startup calls, most important being to call pa_threaded_mainloop_start() right away instead
of after further calls, and creating pa_context_ while the lock was held.

BUG=48553
TEST=See if Valgrind stops suppressing 48553

Review URL: http://codereview.chromium.org/2948013
------------------------------------------------------------------------
r53080 | albertb@chromium.org | 2010-07-20 21:46:31 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.h

If the default theme is synced to the server, make new sync clients with custom themes "win" at model association time.

BUG=48155
TEST=manually tested

Review URL: http://codereview.chromium.org/2856040
------------------------------------------------------------------------
r53078 | ananta@chromium.org | 2010-07-20 21:24:09 +0200 (Tue, 20 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Fix a Chrome crash observed in ChromeFrame reliability test runs. The crash occurs while processing the
ViewHostMsg_UpdateRect message and occurs due to dereferencing a NULL view_ pointer. It looks that the view_
pointer got destroyed and effectively NULL'ed out in the context of the call to the MovePluginWindows function.

Fix is to add a NULL check for the same.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=39356

Bug=39356

Review URL: http://codereview.chromium.org/3043009
------------------------------------------------------------------------
r53073 | pinkerton@chromium.org | 2010-07-20 21:00:36 +0200 (Tue, 20 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_location_bar.h

Revert 53062 - Makes the toolbar visible for apps again. Here's the set of patches I
reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for
45566. If you see anything missing, please let me know.
Also, there are some grd strings no longer necessary. I'll nuke those
separately.

BUG=49013
TEST=none

Review URL: http://codereview.chromium.org/2888020

TBR=sky@chromium.org
------------------------------------------------------------------------
r53071 | suzhe@chromium.org | 2010-07-20 20:38:21 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm

Don't use VIEW_ID_PAGE_MENU, which has been removed.

BUG=none
TEST=none

TBR:pinkerton@chromium.org
------------------------------------------------------------------------
r53070 | sargrass@google.com | 2010-07-20 20:26:11 +0200 (Tue, 20 Jul 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc
   D /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc:53069)
   A /trunk/src/chrome/browser/dom_ui/sync_options_handler.h (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h:53069)
   A /trunk/src/chrome/browser/resources/options/personal_options.css
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Relanding: Personal stuff page in tabbed options
Relanding issue 2819046

BUG=48883
TEST=Exercise Personal Stuff page via --enable-tabbed-options

Review URL: http://codereview.chromium.org/3042005
------------------------------------------------------------------------
r53067 | suzhe@chromium.org | 2010-07-20 20:15:48 +0200 (Tue, 20 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_text_field.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/reload_button.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view.mm
   A /trunk/src/chrome/browser/cocoa/view_id_util.h
   A /trunk/src/chrome/browser/cocoa/view_id_util.mm
   A /trunk/src/chrome/browser/cocoa/view_id_util_browsertest.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac]Implement ViewID support. (third approach)

This CL adds several extension methods to NSView class for ViewID
support, and uses a map to store ViewIDs of views.
Each view requiring ViewID support can set its ViewID upon
initialization and unset it before destruction.
When looking up a view with a specific ViewID, just search all sub views
recursively from the root view of a window.

BUG=44692 need ViewIds on mac
TEST=none

Review URL: http://codereview.chromium.org/2878037
------------------------------------------------------------------------
r53063 | pinkerton@chromium.org | 2010-07-20 20:12:04 +0200 (Tue, 20 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Disabling test that hangs bot
BUG=39070
TEST=none
Review URL: http://codereview.chromium.org/2819058
------------------------------------------------------------------------
r53062 | sky@chromium.org | 2010-07-20 19:59:18 +0200 (Tue, 20 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_location_bar.h

Makes the toolbar visible for apps again. Here's the set of patches I
reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for
45566. If you see anything missing, please let me know.
Also, there are some grd strings no longer necessary. I'll nuke those
separately.

BUG=49013
TEST=none

Review URL: http://codereview.chromium.org/2888020
------------------------------------------------------------------------
r53058 | oshima@chromium.org | 2010-07-20 19:39:30 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h

Check localaccount when unlocking.

BUG=chromium-os:4375
TEST=manual: login using local account,lock scren using ctrl-alt-l then unlock. no password required.

Review URL: http://codereview.chromium.org/3010015
------------------------------------------------------------------------
r53055 | erg@chromium.org | 2010-07-20 19:15:03 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/notification_registrar.cc
   M /trunk/src/chrome/common/notification_registrar.h

Prevent NotificationRegistrar from pulling in platform threading stuff.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3013018
------------------------------------------------------------------------
r53054 | johnnyg@chromium.org | 2010-07-20 18:56:50 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/notification_options_menu_model.cc

Improve the notifications options menu.  If the notification came from an extension, show the option to disable the extension rather than revoke permission.  Also give a link to the notifications content settings panel.OB

BUG=49019
TEST=create notification from page & extension, open the menu

Review URL: http://codereview.chromium.org/3034015
------------------------------------------------------------------------
r53053 | phajdan.jr@chromium.org | 2010-07-20 18:56:26 +0200 (Tue, 20 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/base/task.h
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_file_manager.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h

Download code cleanup:

- choose better names for some helper methods
- move code to less random places

This change also adds bigger tuples support, up to Tuple8 in base/tuple.h.
The plan is to stop using such big number of parameters, but for now it's not
trivial.

This change also fixes some UI tests, not sure why it is so.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/2805091
------------------------------------------------------------------------
r53051 | asargent@chromium.org | 2010-07-20 18:42:37 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Add some histograms to help measure extension context menu performance

BUG=49560
TEST=none (no user-visible changes)

Review URL: http://codereview.chromium.org/3022013
------------------------------------------------------------------------
r53048 | nshkrob@chromium.org | 2010-07-20 18:30:42 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc

Clear TopSites when deleting history.

Update top_sites_ right away, then request an update from the HistoryService.

TEST=TopSitesTest
BUG=none

Review URL: http://codereview.chromium.org/2964009
------------------------------------------------------------------------
r53035 | satorux@chromium.org | 2010-07-20 12:15:41 +0200 (Tue, 20 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add "settings.language.preferred_languages" for Chromium OS's Languages and Input dialog.

Before this change, we used to get the list of preferred languages based on
the active input methods. This is tricky. Having a preference for the value
is simpler, and makes it easier for us to implement the DOM UI version.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/3012012
------------------------------------------------------------------------
r53024 | johnnyg@chromium.org | 2010-07-20 09:50:29 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm

[mac] Use the cross-platform menu model for the notifications options menu, instead of something mac-specific.

BUG=none
TEST=create notification on mac, the options menu should work normally

Review URL: http://codereview.chromium.org/3020015
------------------------------------------------------------------------
r53023 | tim@chromium.org | 2010-07-20 09:19:11 +0200 (Tue, 20 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

sync: Speculative fix for a possible trigger to bug 48502. 
If the user configures data types before the sync backend is initialized,
we wind up trying to associate models before a Directory exists, which is
badness.

BUG=48502
TEST=none

Review URL: http://codereview.chromium.org/3028013
------------------------------------------------------------------------
r53019 | jcivelli@chromium.org | 2010-07-20 08:48:04 +0200 (Tue, 20 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc

Revert 53016 - Makes the browser fetch the translate script regularly.
New versions of that script may get pushed from time to time.
Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions.

Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide).

BUG=None
TEST=Run the unit-tests. 

Original review:
http://codereview.chromium.org/3034013/show

Review URL: http://codereview.chromium.org/3041010

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2881024
------------------------------------------------------------------------
r53017 | jshin@chromium.org | 2010-07-20 08:29:19 +0200 (Tue, 20 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc

Fix the UI dimension for ContentSettings dialog for many locales.

1. Adjust the width and the height of the dialog to work both with
Windows Classic and Windows Vista theme.

2. Make the width of list box in the dialog localizable
and adjust them per locale if necessary.


Original Review: http://codereview.chromium.org/2974009/show

BUG=48202
TEST=Go to Options | Under the Hood | Content Settings in locales listed in the bug and make sure that there's no truncation and all the UI elements can be
selected/visible/clickable both on XP (or Windows Classic them on Vista)
and Vista.
Review URL: http://codereview.chromium.org/2836061
------------------------------------------------------------------------
r53016 | jcivelli@chromium.org | 2010-07-20 08:27:51 +0200 (Tue, 20 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc

Makes the browser fetch the translate script regularly.
New versions of that script may get pushed from time to time.
Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions.

Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide).

BUG=None
TEST=Run the unit-tests. 

Original review:
http://codereview.chromium.org/3034013/show

Review URL: http://codereview.chromium.org/3041010
------------------------------------------------------------------------
r53014 | akalin@chromium.org | 2010-07-20 08:12:23 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h

Fixed invalid reads when XmppClient is destroyed.

BUG=49274
TEST=manual testing with code to trigger bug repro

Review URL: http://codereview.chromium.org/3034016
------------------------------------------------------------------------
r53009 | nick@chromium.org | 2010-07-20 07:37:57 +0200 (Tue, 20 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc

Handle client-tag duplicates on server items.

The server no longer properly enforces this.  In the event of a clash, pay attention only to the item with the lexically least ID.  The lookup must be done at
ProcessUpdate time; Verify is too early (clashes within a batch can't be handled).  Add unit tests for hopefully all the corner cases.

BUG=41696,48158,36599
TEST=new sync_unit_tests

Review URL: http://codereview.chromium.org/3038008
------------------------------------------------------------------------
r53008 | satorux@chromium.org | 2010-07-20 07:35:34 +0200 (Tue, 20 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_options.css
   M /trunk/src/chrome/browser/resources/options/chromeos_language_options.html
   M /trunk/src/chrome/browser/resources/options.html

Write HTML and CSS for Languages and Input options, based on Cole's mock.

Still no logic implemented, but it's nice to have something looking pretty. :)

The current screenshot can be found at:
http://chromium-os.googlecode.com/issues/attachment?aid=6893314955718114103&name=domui.png&token=09541fa12341c817ca5b2ecff2e5d463&inline=1

BUG=chromium-os:4573
TEST=manually

Review URL: http://codereview.chromium.org/2836052
------------------------------------------------------------------------
r53007 | jrg@chromium.org | 2010-07-20 07:28:01 +0200 (Tue, 20 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Initial bookmark bar folder window tries harder to be on-screen.

BUG=http://crbug.com/48832
TEST=Move window all the way to the right of screen so a folder would spill off.
Open bookmark bar folder in question --> see it "pushed left" to get back on screen.

Review URL: http://codereview.chromium.org/2884026
------------------------------------------------------------------------
r53005 | jochen@chromium.org | 2010-07-20 07:05:02 +0200 (Tue, 20 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CollectedCookies.xib
   M /trunk/src/chrome/browser/cocoa/collected_cookies_mac.h
   M /trunk/src/chrome/browser/cocoa/collected_cookies_mac.mm

[Mac] Add buttons to the collected cookies dialog to add content exceptions.

This is the Mac side of http://codereview.chromium.org/2808053 .

Looks like this: http://imgur.com/leY4C.png

To provide user feedback, after an exception has been added, the exceptions window is shown.

XIB changes:
Add a button to the allowed cookies outline views to block cookies and two to the blocked cookies one to allow them; set the NSSplitView delegate to File's Owner.

Review URL: http://codereview.chromium.org/2884024
Patch from Bernhard Bauer <bauerb@chromium.org>.
------------------------------------------------------------------------
r53003 | mirandac@google.com | 2010-07-20 07:04:00 +0200 (Tue, 20 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Remove test which works on local Win machines but fails the Win bots (suspect test harness issues).

TBR=arv

Review URL: http://codereview.chromium.org/3040009
------------------------------------------------------------------------
r52998 | arv@chromium.org | 2010-07-20 06:18:50 +0200 (Tue, 20 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/apps.js
   A /trunk/src/chrome/browser/resources/ntp/web_store_icon.png
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

NTP: Use the store as the last thumbnail in case we have no apps installed.

1. If no apps are installed we add an item for the store to the most visited section.
2. No longer hide the most visited by default.
3. This removes the default apps on non ChromeOS

BUG=46028, 47700
TEST=With a clean profile without any apps installed you should see the store thumbnail unless you blacklist it or pin 8 ohter pages.

Review URL: http://codereview.chromium.org/3001003
------------------------------------------------------------------------
r52995 | thakis@chromium.org | 2010-07-20 06:10:04 +0200 (Tue, 20 Jul 2010) | 46 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc

Try to fix a valgrind leak.

This shows up as
Suppression:
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Znw*
   fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE11_M_get_nodeEv
   fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE14_M_create_nodeERKS7_
   fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE9_M_insertEPSt18_Rb_tree_node_baseSE_RKS7_
   fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE13insert_uniqueESt17_Rb_tree_iteratorIS7_ERKS7_
   fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEE6insertESt17_Rb_tree_iteratorIS8_ERKS8_
   fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_
   fun:_ZN23ExtensionMessageService24DispatchEventToRenderersERKSsS1_bRK4GURL
   fun:_ZL13DispatchEventP7ProfilePKcSs
   fun:_ZL26DispatchSimpleBrowserEventP7ProfileiPKc
   fun:_ZN27ExtensionBrowserEventRouter17OnBrowserRemovingEPK7Browser
   fun:_ZN11BrowserList13RemoveBrowserEP7Browser
   fun:_ZN7BrowserD0Ev
   fun:object_cxxDestructFromClass
   fun:_ZN12_GLOBAL__N_113ZombieDeallocEP11objc_objectP13objc_selector
   fun:-[NSResponder dealloc]
   fun:-[NSWindowController dealloc]
   fun:-[BrowserWindowController dealloc]
   fun:-[NSWindowController release]
   fun:__delayedPerformCleanup
   fun:CFRunLoopTimerInvalidate
   fun:CFRunLoopRunSpecific
}
, with

c++filt __ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_ being map::operator[] and the symbol above it being map::insert().

(e.g. http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20(valgrind)(3)/builds/3538/steps/memory%20test:%20ui/logs/stdio ).

Seems to happen only on mac.

This shouldn't leak, but maybe we're hitting an STL leak (I tried to build a reduced test case for a few minutes and failed). Maybe it goes away with this.

BUG=none
TEST=One fewer "Suppression:" line on mac ui_tests valgrind bots (2 instead of 3 atm).

TBR=mpcomplete

Review URL: http://codereview.chromium.org/2870060
------------------------------------------------------------------------
r52993 | mirandac@google.com | 2010-07-20 05:45:40 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add bookmark promo to NTP on first run.

BUG=49328
TEST=First tip seen on import to empty profile is import bookmarks promo. This promo appears on the first 5 browser restarts, unless bookmarks are imported.

Review URL: http://codereview.chromium.org/2805089
------------------------------------------------------------------------
r52989 | dhollowa@chromium.org | 2010-07-20 04:38:39 +0200 (Tue, 20 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm

AutoFill Profiles dialog handles multi-select and delete on Mac

Changes the AutoFill dialog on Mac to support multi-select and delete of items
in the address and credit card table.  The "Edit..." button disables when multiple
items are selected.

Nib changes in AutoFillDialog.xib: (1) Enables multi-select for the table view, (2) binds
the enabled state of the "Edit..." button to the new |multipleSelected| property, (3) connects edit button to outlet.

BUG=49344
TEST=AutoFillDialogControllerTest.DeleteMultiple.

Review URL: http://codereview.chromium.org/3039014
------------------------------------------------------------------------
r52987 | cbentzel@chromium.org | 2010-07-20 04:30:49 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Negotiate on by default on all platforms.

BUG=33033
TEST=Run chrome on POSIX plaforms without explicitly turning on Negotiate.

Review URL: http://codereview.chromium.org/3014013
------------------------------------------------------------------------
r52985 | pkasting@chromium.org | 2010-07-20 03:56:52 +0200 (Tue, 20 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   D /trunk/src/chrome/app/theme/menu_chrome.png
   D /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   D /trunk/src/chrome/app/theme/menu_chrome_rtl.png
   D /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   D /trunk/src/chrome/app/theme/menu_page.png
   D /trunk/src/chrome/app/theme/menu_page_Template.pdf
   D /trunk/src/chrome/app/theme/menu_page_rtl.png
   D /trunk/src/chrome/app/theme/menu_page_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/browser/app_menu_model.cc
   D /trunk/src/chrome/browser/app_menu_model.h
   D /trunk/src/chrome/browser/app_menu_model_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.h
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   D /trunk/src/chrome/browser/page_menu_model.cc
   D /trunk/src/chrome/browser/page_menu_model.h
   D /trunk/src/chrome/browser/page_menu_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   A /trunk/src/chrome/browser/wrench_menu_model_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/test_browser_window.h

Remove the page and app menus.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3033007
------------------------------------------------------------------------
r52983 | estade@chromium.org | 2010-07-20 03:54:44 +0200 (Tue, 20 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_linux.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc

GTK: improve clipboard compatibility with firefox + evolution.

BUG=48424
TEST=copying from the chrome bookmark manager into firefox should save the bookmark's title as well as url
TEST=copying the address from the omnibox into evolution copies text, and doesn't create an attachment

Review URL: http://codereview.chromium.org/3022004
------------------------------------------------------------------------
r52982 | rsesek@chromium.org | 2010-07-20 03:09:46 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/animatable_image.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm

Load the download animation image as an NSImage rather than a CGImageRef.

BUG=none
TEST=ui_tests don't crash

Review URL: http://codereview.chromium.org/3005018
------------------------------------------------------------------------
r52981 | andybons@chromium.org | 2010-07-20 03:07:32 +0200 (Tue, 20 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/common/notification_type.h

[Mac] Fix for a bug where extensions were not being notified when no window was in focus on the mac.

BUG=32932
TEST=check bug.
Review URL: http://codereview.chromium.org/2847062
------------------------------------------------------------------------
r52980 | jhawkins@chromium.org | 2010-07-20 03:06:05 +0200 (Tue, 20 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/renderer/render_view.cc

AutoFill: Several functional fixes:
* Don't fill CC data on non-HTTPS pages.
* Don't display non-unique suggestions in the popup.
* Fix displaying the 'AutoFill Options' suggestion (was a regression).

BUG=48499
TEST=none

Review URL: http://codereview.chromium.org/3040004
------------------------------------------------------------------------
r52979 | nirnimesh@chromium.org | 2010-07-20 03:04:46 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Some pyauto hooks crash in Debug mode.

1. GetBrowserInfo() uses a method which was supposed to run on IO thread only, so fails in Debug
2. Fix AutomationJsonReply usage in SaveTabContents()

TEST=python chrome/test/functional/pyauto_functional.py in Debug mode

Review URL: http://codereview.chromium.org/3022012
------------------------------------------------------------------------
r52978 | tfarina@chromium.org | 2010-07-20 03:01:21 +0200 (Tue, 20 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h

notifications/views: Make use of the cross platform NotificationOptionsMenuModel.

This is the second part of the implementation of the cross platform model that makes use of the implementation
in the views side and get rid of the duplicated coded.

BUG=None
TEST=Go to http://0xfe.muthanna.com/notifyme.html, request permission for notifications, notify it. Click on the wrench menu in the notification balloon, the menu should work as before.

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3023004
------------------------------------------------------------------------
r52977 | rlp@chromium.org | 2010-07-20 02:49:42 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc

Send the gpu information along with the rest of the metrics.

Note: this won't go green until issue 2857035 goes in.

BUG=38736
TEST=none (suggestions welcome)

Review URL: http://codereview.chromium.org/2895014
------------------------------------------------------------------------
r52975 | rvargas@google.com | 2010-07-20 02:42:36 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Re-enable BrowserTest.ThirtyFourTabs on mac.

BUG=49193
TEST=none
TBR=oshima


Review URL: http://codereview.chromium.org/3037009
------------------------------------------------------------------------
r52974 | mpcomplete@chromium.org | 2010-07-20 02:42:00 +0200 (Tue, 20 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/url_pattern_unittest.cc
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc

Fix some issues with extensions:
- Default to Allow file permissions for unpacked extensions.
- Fix incognito warning display when extensions are reshuffled.
- Remove SCHEMES_ALL

BUG=48124
BUG=48526
BUG=49243
TEST=no

Review URL: http://codereview.chromium.org/3039005
------------------------------------------------------------------------
r52969 | oshima@chromium.org | 2010-07-20 02:14:09 +0200 (Tue, 20 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h

Send lock ready signal after Windowmanager has drawn the screen.
Added ScreenLockerBackgroundView to re-layout lock_widget on resize.
 For 4399, we'll update WM to make lock window fullscreen,
 and update chrome to use window but not popup.

BUG=chromium-os:4078, chromium-os:4399
TEST=none

Review URL: http://codereview.chromium.org/3034012
------------------------------------------------------------------------
r52968 | oshima@chromium.org | 2010-07-20 02:12:45 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Put sidetab menu back to wrench menu (confirmed with sky)
Removed OpenTanMode (confirmed with cole)
Removed ToolbarView::SetAppMenuModel

BUG=49229
TEST=none.

Review URL: http://codereview.chromium.org/2832058
------------------------------------------------------------------------
r52965 | rsesek@chromium.org | 2010-07-20 02:03:43 +0200 (Tue, 20 Jul 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/app/theme/popup_window_animation.pdf
   A /trunk/src/chrome/browser/cocoa/animatable_image.h
   A /trunk/src/chrome/browser/cocoa/animatable_image.mm
   A /trunk/src/chrome/browser/cocoa/animatable_image_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   A /trunk/src/chrome/browser/cocoa/popup_blocked_animation_mac.mm
   A /trunk/src/chrome/browser/gtk/popup_blocked_animation_gtk.cc
   A /trunk/src/chrome/browser/popup_blocked_animation.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   A /trunk/src/chrome/browser/views/popup_blocked_animation_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Display a quick animation when a popup is blocked so the user notices it in the Omnibox.

This refactors the animation code of the DownloadStartedAnimationMac into AnimatableImage.

BUG=49341
TEST=Go to http://www.popuptest.com/popuptest3.html. When a popup is opened, see animation.
TEST=Download a file. Animation still plays.

Review URL: http://codereview.chromium.org/3014005
------------------------------------------------------------------------
r52963 | rsesek@chromium.org | 2010-07-20 01:50:09 +0200 (Tue, 20 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   M /trunk/src/chrome/browser/wrench_menu_model.h

[Mac] Minor tweaks to the Wrench menu.

* Swap the +/- zoom buttons so that minus is first.
* Invert the fullscreen arrows when in fullscreen mode.

BUG=49449
TEST=Visual
TEST=Wrench menu --> Enter full screen. Wrench menu now has inverted arrows to exit full screen.

Review URL: http://codereview.chromium.org/3008010
------------------------------------------------------------------------
r52961 | cbentzel@chromium.org | 2010-07-20 01:07:27 +0200 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card_unittest.cc

I reversed the order of the EXPECT_EQ tests so expected value is first, actual value is second.

BUG=None
TEST=unit_tests --gtest_filter="*CreditCardTest*"

Review URL: http://codereview.chromium.org/3014014
------------------------------------------------------------------------
r52960 | davidben@chromium.org | 2010-07-20 01:05:37 +0200 (Tue, 20 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Respect Spaces when dragging tabs on OS X

For 10.6 and above, we can simply filter windows out with isOnActiveSpace. For
10.5, there is another API in CoreGraphics that gives us the same information.
It is slow and causes noticeable CPU usage during a drag, so cache it per-drag.

R=pinkerton
BUG=32796
TEST=open windows on separate spaces, drag a tab over where a window is on the other space

Review URL: http://codereview.chromium.org/2962018
------------------------------------------------------------------------
r52959 | shess@chromium.org | 2010-07-20 01:01:29 +0200 (Tue, 20 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.h

[Mac] Adjust omnibox decoration dragging to keep image under mouse.

LocationBarDecoration::GetDragImageFrame() added to let decorations
specify where their GetDragImage() image is in the decoration.  The
mouse-down code ensures that the mouse drags from the expected point
within that area, or centeres the image under the mouse if the drag is
from somewhere else in the decoration.

Additionally tracked down why -isFlipped affected the drag point and
rewrote the code to be -isFlipped agnostic.

BUG=49102, 40771
TEST=Goto https://www.thawte.com/.  Drag from ev text, lock icon should be under cursor.
TEST=drag from location or lock icon should drag from point in icon mouse click was in.

Review URL: http://codereview.chromium.org/2870059
------------------------------------------------------------------------
r52957 | dhollowa@chromium.org | 2010-07-20 00:52:53 +0200 (Tue, 20 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/webdata/web_data_service.cc

AutoFill Prefs dialog on Mac should list derived labels for profiles, not summaries.

Changes the AutoFill dialog on Mac to display list of derived labels and not summaries.

BUG=49344
TEST=Manual test as in bug.  AutoFillDialogControllerTest.*

Review URL: http://codereview.chromium.org/3041007
------------------------------------------------------------------------
r52951 | thestig@chromium.org | 2010-07-19 22:58:30 +0200 (Mon, 19 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/theme/tools.png
   M /trunk/src/chrome/app/theme/tools_Template.pdf
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc

Fix svn:executable permissions.

BUG=none
TEST=checkperms.py is happy.
Review URL: http://codereview.chromium.org/3042006
------------------------------------------------------------------------
r52950 | jochen@chromium.org | 2010-07-19 22:49:30 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/collected_cookies_uitest.cc
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   M /trunk/src/chrome/browser/gtk/collected_cookies_gtk.h
   M /trunk/src/chrome/browser/views/collected_cookies_win.cc
   M /trunk/src/chrome/browser/views/collected_cookies_win.h

Buttons for the collected cookies dialog to add content exceptions.

BUG=45230
TEST=CollectedCookiesTest.*

Review URL: http://codereview.chromium.org/2808053
------------------------------------------------------------------------
r52949 | sky@chromium.org | 2010-07-19 22:46:07 +0200 (Mon, 19 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/app/multi_animation.cc
   M /trunk/src/app/multi_animation.h
   M /trunk/src/app/multi_animation_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Tweaks the pinned background tab title change animation per Nicholas's
request.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3041006
------------------------------------------------------------------------
r52945 | atwilson@chromium.org | 2010-07-19 22:26:25 +0200 (Mon, 19 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list_gtk.cc

Only auto-close dialogs when last browser closes.

Update GTK version of BrowserList::AllBrowsersClosed() to only close widgets
that pass the GTK_IS_DIALOG() filter to avoid prematurely closing status icons.

BUG=49391
TEST=none (unit test is part of a pending CL)

Review URL: http://codereview.chromium.org/3040006
------------------------------------------------------------------------
r52944 | shess@chromium.org | 2010-07-19 22:14:43 +0200 (Mon, 19 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

[Mac] fix autocomplete_text_field_cell_unittest.mm

Merge removed indirect autocomplete_text_field.h, broken build.

BUG=none
TEST=waterfall

Review URL: http://codereview.chromium.org/3050002
------------------------------------------------------------------------
r52942 | tony@chromium.org | 2010-07-19 22:01:55 +0200 (Mon, 19 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Revert "Mark tests FLAKY: HomePageLink and NTPHasThumbnails"

This reverts commit 52788 and re-enables 2 UI tests.

TBR=phajdan.jr

Review URL: http://codereview.chromium.org/2856044
------------------------------------------------------------------------
r52940 | shess@chromium.org | 2010-07-19 21:54:36 +0200 (Mon, 19 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

[Mac] Re-enable decoration tooltips in omnibox.

AutocompleteTextField clears state, then asks
AutocompleteTextFieldCell to regenerate the tooltips.

BUG=49321
TEST=tooltips for star, content settings, page actions.
TEST= AutocompleteTextFieldCellTest.UpdateToolTips

Review URL: http://codereview.chromium.org/2868058
------------------------------------------------------------------------
r52936 | markusheintz@chromium.org | 2010-07-19 21:50:48 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h

Adds the application locale police that allows to enforce the kApplicationLocale preference.

bug=44504
test=none

Review URL: http://codereview.chromium.org/2809058
------------------------------------------------------------------------
r52934 | mpcomplete@chromium.org | 2010-07-19 21:09:41 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Revert r42636. That hack is no longer needed now that we removed the compact
location bar view.

BUG=38992

Review URL: http://codereview.chromium.org/3036004
------------------------------------------------------------------------
r52933 | alyssad@chromium.org | 2010-07-19 21:07:30 +0200 (Mon, 19 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Fix for pyauto AutoFill tests on Leopard.

Review URL: http://codereview.chromium.org/2823046
------------------------------------------------------------------------
r52931 | skerner@chromium.org | 2010-07-19 21:04:45 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/red.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/text.html

Deal with alpha values when building PNG in chrome.tabs.captureVisibleTab().

BUG=44758
TEST=ExtensionApiTest.CaptureVisibleTab, try taking a snapshot of google.com on mac, linux, win.

Review URL: http://codereview.chromium.org/2819050
------------------------------------------------------------------------
r52930 | csilv@chromium.org | 2010-07-19 21:04:12 +0200 (Mon, 19 Jul 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.cc
   A /trunk/src/chrome/browser/dom_ui/clear_browser_data_handler.h
   A /trunk/src/chrome/browser/dom_ui/font_settings_handler.cc
   A /trunk/src/chrome/browser/dom_ui/font_settings_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   A /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.html
   A /trunk/src/chrome/browser/resources/options/clear_browser_data_overlay.js
   A /trunk/src/chrome/browser/resources/options/font_settings_overlay.html
   A /trunk/src/chrome/browser/resources/options/font_settings_overlay.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Add starter code for 'Clear Browser Data' and 'Font Settings' overlay dialogs.

BUG=49037,49038
TEST=Verify skeleton overlay dialogs for 'Clear Browser Data' and 'Font Settings' when using --enable-tabbed-options.
Review URL: http://codereview.chromium.org/2812063
------------------------------------------------------------------------
r52928 | shess@chromium.org | 2010-07-19 20:57:29 +0200 (Mon, 19 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Convert omnibox keyword hint to decoration.

Additionally, convert to use more basic drawing rather than
NSAttributedString, to save needing the text-attachment class.  Strip
out all of the unit-test code relating to decoration exclusion, as
those cases are no longer possible in those ways.

BUG=none
TEST=Browse to www.google.com.  Command-l, type google and should see "Press [tab] to search Google".
TEST=Should have I-beam cursor over the "Press ..." phrase.

Review URL: http://codereview.chromium.org/2854051
------------------------------------------------------------------------
r52925 | thakis@chromium.org | 2010-07-19 20:55:09 +0200 (Mon, 19 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Let PaintAtAck send an int tag instead of the TransportDIB handle.

TransportDIB handles are file descriptors on mac, which are duped when sent over IPC. Hence, they change their value, and the handle that comes back over IPC is not the same that was originally sent -- so they can't be used as map keys.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3037006
------------------------------------------------------------------------
r52915 | nshkrob@chromium.org | 2010-07-19 18:59:01 +0200 (Mon, 19 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Fix missing thumbnails for new profile with TopSites.

Store a map of temporary thumbnails for unknown URLs.

Also, remove accesses to thumbnail DB after the migration to TopSites.

TEST=TopSitesTest
BUG=none

Review URL: http://codereview.chromium.org/2948008
------------------------------------------------------------------------
r52914 | cbentzel@chromium.org | 2010-07-19 18:53:58 +0200 (Mon, 19 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm

DISABLE WrenchMenuControllerTest.Initialized.

Also made other DISABLED tests consistent with this one.

BUG=49206
TEST=None

Review URL: http://codereview.chromium.org/3008009
------------------------------------------------------------------------
r52913 | pinkerton@google.com | 2010-07-19 18:51:06 +0200 (Mon, 19 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

Mark test as flaky, disabling because it crashes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2854052
------------------------------------------------------------------------
r52911 | rsesek@chromium.org | 2010-07-19 18:14:47 +0200 (Mon, 19 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/restart_browser.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/wrench_menu_model.cc

[Mac] Implement the update available notification in the wrench menu.

The changes to restart_browser.mm also affect the sheet displayed in the About
window. Note that the badge on the wrench menu looks bad.

BUG=45147
TEST=difficult

Review URL: http://codereview.chromium.org/2856042
------------------------------------------------------------------------
r52910 | jochen@chromium.org | 2010-07-19 17:51:23 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/mock_browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.cc

Store creating url in origin nodes and use it for content settings.

BUG=none
TEST=Cookies*.*

Review URL: http://codereview.chromium.org/3048002
------------------------------------------------------------------------
r52905 | pinkerton@google.com | 2010-07-19 16:43:07 +0200 (Mon, 19 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/resources/host_registration_page.html

Revert 52902 - Add getUserInfo, getRegistrationUrl message callback for register screen.
Restrict chrome://register to OOBE wizard only.
Actually delete about:register.

BUG= http://crosbug.com/4813
TEST=none

Review URL: http://codereview.chromium.org/3044001

TBR=nkostylev@google.com
Review URL: http://codereview.chromium.org/3026007
------------------------------------------------------------------------
r52904 | nick@chromium.org | 2010-07-19 16:42:24 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/histogram_synchronizer.h
   M /trunk/src/chrome/chrome_browser.gypi

Fix two browser/broswer typos.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2913013
------------------------------------------------------------------------
r52902 | nkostylev@google.com | 2010-07-19 15:39:34 +0200 (Mon, 19 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   M /trunk/src/chrome/browser/resources/host_registration_page.html

Add getUserInfo, getRegistrationUrl message callback for register screen.
Restrict chrome://register to OOBE wizard only.
Actually delete about:register.

BUG= http://crosbug.com/4813
TEST=none

Review URL: http://codereview.chromium.org/3044001
------------------------------------------------------------------------
r52901 | allanwoj@chromium.org | 2010-07-19 15:36:22 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc

Patched from issue 2825039

BUG=44011
TEST=NoWifi and IntermittentWifi test fixtures in wifi_data_provider_common_unittest.cc

Review URL: http://codereview.chromium.org/2971006
------------------------------------------------------------------------
r52889 | bauerb@chromium.org | 2010-07-19 11:41:25 +0200 (Mon, 19 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h

compile fix.

accidentally committed an old version.

tbr=jochen

Review URL: http://codereview.chromium.org/3044010
------------------------------------------------------------------------
r52888 | bauerb@chromium.org | 2010-07-19 11:29:02 +0200 (Mon, 19 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h

Preparatory work for adding content exceptions from the tab cookie view.

Factor out HostContentSettingsMap::AddExceptionForURL() and add CookieTreeOriginNode::CreateContentException().

Review URL: http://codereview.chromium.org/2868059
------------------------------------------------------------------------
r52886 | mnaganov@chromium.org | 2010-07-19 10:27:40 +0200 (Mon, 19 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Introduce "--enable-memory-info" command-line flag to enable reporting
of JS heap size via "console.memory" (for now) and
"webkitPerformance.memory" (having Web Timing enabled).

BUG=43281
TEST=none

Review URL: http://codereview.chromium.org/3017007
------------------------------------------------------------------------
r52885 | ziadh@chromium.org | 2010-07-19 10:00:42 +0200 (Mon, 19 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/values.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/metrics_service_unittest.cc
   M /trunk/src/chrome/browser/net/url_info.cc
   M /trunk/src/chrome/common/metrics_helpers.cc
   M /trunk/src/chrome/common/metrics_helpers.h
   M /trunk/src/chrome_frame/metrics_service.cc

Compress and checksum pending logs that are going to be persisted. Persisted logs now have the following format:
[list_size, log1, log2, ..., log_n, checksum].

where each log is bzipped before being written. Upon reading the logs from disk, we verify the data and register whether we faced corruptions or not.

r=jar



Review URL: http://codereview.chromium.org/2936005
------------------------------------------------------------------------
r52884 | rlp@chromium.org | 2010-07-19 09:51:33 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc

Adding gpu_info to the breakpad info collection before sending off a crash.

BUG=38737
TEST=none

Review URL: http://codereview.chromium.org/3034004
------------------------------------------------------------------------
r52879 | tfarina@chromium.org | 2010-07-19 03:59:48 +0200 (Mon, 19 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/common/database_util.cc
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc

Remove incorrect usages of USE_SYSTEM_SQLITE.

Currently we don't provide any support to the system sqlite.

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3049001
------------------------------------------------------------------------
r52878 | rohitrao@chromium.org | 2010-07-19 02:52:09 +0200 (Mon, 19 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_loader.sb
   M /trunk/src/chrome/renderer/renderer.sb

Revert 52872 - Remove the special hole that was opened for Native Client
in order for it to do bind() and connect().
BUG=http://code.google.com/p/chromium/issues/detail?id=26781
TEST=all tests pass, especially nacl_ui_tests

Review URL: http://codereview.chromium.org/2881016

TBR=msneck@google.com
Review URL: http://codereview.chromium.org/2842059
------------------------------------------------------------------------
r52876 | jcivelli@chromium.org | 2010-07-19 02:06:23 +0200 (Mon, 19 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/common/translate_errors.h

When Chrome translates a page, the translate server might detect that the page is in a different language than the one Chrome detected.
If that language is not in the list of languages that Chrome supports for translation, then we do not know what to show and we were crashing.
This CL makes it so that we show an error infobar instead.
Note that in the future we should improve the "after translate" infobar to support showing the original language as unknown. (http://crbug.com/9390)

BUG=48918
TEST=Not sure how to test without changing the code.
Review URL: http://codereview.chromium.org/3011008
------------------------------------------------------------------------
r52875 | sky@chromium.org | 2010-07-19 01:33:22 +0200 (Mon, 19 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h

Nukes the nano tab style for views. I also consolidated code in
TabStripModel to minimize how many places I call to is_app and
pinned.

BUG=49013
TEST=none

Review URL: http://codereview.chromium.org/2877024
------------------------------------------------------------------------
r52873 | rohitrao@chromium.org | 2010-07-19 01:17:18 +0200 (Mon, 19 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Close bookmark bubbles when toggling fullscreen mode.

BUG=40716
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/1599028
------------------------------------------------------------------------
r52872 | msneck@google.com | 2010-07-19 00:42:27 +0200 (Mon, 19 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_loader.sb
   M /trunk/src/chrome/renderer/renderer.sb

Remove the special hole that was opened for Native Client
in order for it to do bind() and connect().
BUG=http://code.google.com/p/chromium/issues/detail?id=26781
TEST=all tests pass, especially nacl_ui_tests

Review URL: http://codereview.chromium.org/2881016
------------------------------------------------------------------------
r52870 | tim@chromium.org | 2010-07-19 00:02:33 +0200 (Mon, 19 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 52740 - Always show the 'Control sync from Google Dashboard' link on the sync options dialog.

BUG=48844
TEST=open Personal Stuff on any platform, see dashboard link.

Review URL: http://codereview.chromium.org/2827055

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/2881021
------------------------------------------------------------------------
r52868 | tfarina@chromium.org | 2010-07-18 23:12:44 +0200 (Sun, 18 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   D /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.cc
   D /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.h
   A /trunk/src/chrome/browser/notifications/notification_options_menu_model.cc
   A /trunk/src/chrome/browser/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

Reapply r52859

This reverts commit a3d08737344176477998ba74549b3a23a72cdc96.

This fix the win trybot by adding a missing ALLOW_THIS_IN_INITIALIZER_LIST macro necessary to silent the VS compiler.

BUG=None
TEST=trybots
TBR=johnnyg@chromium.org

Review URL: http://codereview.chromium.org/3045003
------------------------------------------------------------------------
r52867 | asargent@chromium.org | 2010-07-18 23:05:28 +0200 (Sun, 18 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.h
   M /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/contextMenus.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   D /trunk/src/chrome/test/data/extensions/context_menus/background.html
   D /trunk/src/chrome/test/data/extensions/context_menus/manifest.json
   A /trunk/src/chrome/test/data/extensions/context_menus/patterns
   A /trunk/src/chrome/test/data/extensions/context_menus/patterns/background.html
   A /trunk/src/chrome/test/data/extensions/context_menus/patterns/manifest.json
   A /trunk/src/chrome/test/data/extensions/context_menus/patterns/test.html
   A /trunk/src/chrome/test/data/extensions/context_menus/patterns/test.js
   A /trunk/src/chrome/test/data/extensions/context_menus/simple
   A /trunk/src/chrome/test/data/extensions/context_menus/simple/background.html (from /trunk/src/chrome/test/data/extensions/context_menus/background.html:52179)
   A /trunk/src/chrome/test/data/extensions/context_menus/simple/manifest.json (from /trunk/src/chrome/test/data/extensions/context_menus/manifest.json:52179)
   A /trunk/src/chrome/test/data/extensions/context_menus/simple/test.html (from /trunk/src/chrome/test/data/extensions/context_menus/test.html:52179)
   A /trunk/src/chrome/test/data/extensions/context_menus/simple/test.js (from /trunk/src/chrome/test/data/extensions/context_menus/test.js:52179)
   A /trunk/src/chrome/test/data/extensions/context_menus/simple/test2.html (from /trunk/src/chrome/test/data/extensions/context_menus/test2.html:52179)
   D /trunk/src/chrome/test/data/extensions/context_menus/test.html
   D /trunk/src/chrome/test/data/extensions/context_menus/test.js
   D /trunk/src/chrome/test/data/extensions/context_menus/test2.html

Add ability to limit when context menu items appear with url patterns.

BUG=408198
TEST=Extensions context menu API should work with changes described.

Review URL: http://codereview.chromium.org/2811049
------------------------------------------------------------------------
r52865 | pam@chromium.org | 2010-07-18 20:49:14 +0200 (Sun, 18 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc

Don't instantiate an ExtensionPrefStore.

It's not needed yet (no extensions use it), and it has memory leaks.

BUG=48980
TEST=valgrind and heapcheck don't trigger the suppressions for this bug anymore
Review URL: http://codereview.chromium.org/2835042
------------------------------------------------------------------------
r52860 | pfeldman@chromium.org | 2010-07-18 20:11:03 +0200 (Sun, 18 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   A /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.cc
   A /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.h
   D /trunk/src/chrome/browser/notifications/notification_options_menu_model.cc
   D /trunk/src/chrome/browser/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 52859.

Review URL: http://codereview.chromium.org/3013012
------------------------------------------------------------------------
r52859 | tfarina@chromium.org | 2010-07-18 19:50:07 +0200 (Sun, 18 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   D /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.cc
   D /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.h
   A /trunk/src/chrome/browser/notifications/notification_options_menu_model.cc
   A /trunk/src/chrome/browser/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

notifications: Add a cross platform NotificationOptionsMenuModel that can be shared by the views and gtk frameworks.

BUG=None
TEST=Go to http://0xfe.muthanna.com/notifyme.html, request permission for notifications, notify it. Click on the wrench menu in the notification balloon, the menu should work as before.

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2886014
------------------------------------------------------------------------
r52858 | agl@chromium.org | 2010-07-18 19:12:55 +0200 (Sun, 18 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/page_info_model.cc

Windows build fix.
------------------------------------------------------------------------
r52857 | agl@chromium.org | 2010-07-18 19:03:34 +0200 (Sun, 18 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/net/base/ssl_connection_status_flags.h

Add SSL details to the page info dialog.

BUG=27507
TEST=Navigate to https://encrypted.google.com and click the green padlock. Verify that the details presented are reasonable.

http://codereview.chromium.org/3033001
------------------------------------------------------------------------
r52850 | jeremy@chromium.org | 2010-07-18 13:14:13 +0200 (Sun, 18 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Recommit r52848 - Option-click to download should not display "Save As" UI.

Review URL: http://codereview.chromium.org/2825056
------------------------------------------------------------------------
r52849 | jeremy@chromium.org | 2010-07-18 12:54:29 +0200 (Sun, 18 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Revert r52848 - Linux x64 compile failure.

Review URL: http://codereview.chromium.org/3012008
------------------------------------------------------------------------
r52848 | jeremy@chromium.org | 2010-07-18 12:45:28 +0200 (Sun, 18 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Option-click to download should not display "Save As" UI.

The download manager has a concept of a request originating from the "Save As..." contextual menu v.s. a direct download request from the renderer, however this was't hooked up.

The Download Manager uses boolean variables named "save_as" in various locations to track whether a download originated via a contextual menu selection (in which case the save panel should be displayed) or via a renderer request (in which case no UI should be displayed).

This CL contains 3 distinct changes:

1. DownloadFileManager::OnDownloadURL() is where downloads originating from the contextual menu are dispatched, set save_as to true if the download starts here.

2. ResourceMessageFilter::OnDownloadURL() is where downloads originating from the renderer are dispatched (e.g. option-click), don't display UI for these.

3. The "save_as" variable in the DownloadCreateInfo structure doesn't really reflect the origin of the request but whether the Save panel should be displayed. This can happen for example on a name collision or if the default download location isn't writeable regardless of the action that initiated the download.  Renamed the variable and added documentation to this effect.

BUG=36775
TEST=Option-click an image, the image should be saved without prompting the user for a download locate.  Save an image via the "Save As..." context menu, you should be prompted for the save location.

Review URL: http://codereview.chromium.org/2927006
------------------------------------------------------------------------
r52843 | jcivelli@chromium.org | 2010-07-18 09:54:37 +0200 (Sun, 18 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Google translate supports some new languages, makes Chrome aware of them. That way the translation feature works with them.

BUG=None
TEST=Visit pages in the new alpha languages (see http://translate.google.com/about/intl/en_ALL/). Make sure the pages can be translated.

Original review:
http://codereview.chromium.org/3013010

Review URL: http://codereview.chromium.org/3024005
------------------------------------------------------------------------
r52842 | pfeldman@chromium.org | 2010-07-18 08:03:10 +0200 (Sun, 18 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer.cc
   M /trunk/src/chrome/browser/net/load_timing_observer.h

Re-apply r52831: "DevTools: provide SSL networks time as a part of LoadTimingInfo."

Review URL: http://codereview.chromium.org/3044008
------------------------------------------------------------------------
r52838 | georgey@chromium.org | 2010-07-18 05:04:51 +0200 (Sun, 18 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

UI changes to Autofill dialogs according to the latest mocks
Also added inferred labels implementation. Label inferred from the person name + differences in other fields to distinguish entries.
BUG=47120,46634,46635,47435,48881,47430
TEST=in the mocks: http://folder/roma/design/chrome/autofill/ and unit tested.
Review URL: http://codereview.chromium.org/2801020
------------------------------------------------------------------------
r52837 | tfarina@chromium.org | 2010-07-18 02:22:52 +0200 (Sun, 18 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/login_database.cc

Header Cleanup2: Remove another include of sqlite_utils.h that is not needed.

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2843062
------------------------------------------------------------------------
r52833 | pfeldman@chromium.org | 2010-07-17 20:00:01 +0200 (Sat, 17 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer.cc
   M /trunk/src/chrome/browser/net/load_timing_observer.h

Revert r52831: "DevTools: provide SSL networks time as a part of LoadTimingInfo."

Review URL: http://codereview.chromium.org/2847059
------------------------------------------------------------------------
r52831 | pfeldman@chromium.org | 2010-07-17 19:22:23 +0200 (Sat, 17 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/load_timing_observer.cc
   M /trunk/src/chrome/browser/net/load_timing_observer.h

DevTools: provide SSL networks time as a part of LoadTimingInfo.

Review URL: http://codereview.chromium.org/2868054
------------------------------------------------------------------------
r52830 | sky@chromium.org | 2010-07-17 18:55:43 +0200 (Sat, 17 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Nukes the nano tab style on gtk and brings back the toolbar for apps
on gtk. This is a revert of most of r52070and 51478. I've kept parts
of these changes we want in though: comments, nuking nano tab gap on
views, having app tabs use a bigger icon.

BUG=49013
TEST=none

Review URL: http://codereview.chromium.org/3011007
------------------------------------------------------------------------
r52827 | tfarina@chromium.org | 2010-07-17 17:19:36 +0200 (Sat, 17 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc

Header Cleanup: Remove unncessary include of sqlite_utils.h in some files.

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2843061
------------------------------------------------------------------------
r52816 | georgey@chromium.org | 2010-07-17 09:45:19 +0200 (Sat, 17 Jul 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/autofill_cc_infobar.h
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   A /trunk/src/chrome/browser/autofill/autofill_cc_infobar_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

New Blue style for for autofill Info-bar, to be eventually used for all info bars (for that more changes needed), it also Windows only.
BUG=47233
TEST=Mocks @ http://folder/roma/design/chrome/autofill/ page 23
Review URL: http://codereview.chromium.org/3027004
------------------------------------------------------------------------
r52815 | thestig@chromium.org | 2010-07-17 09:31:33 +0200 (Sat, 17 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc

Gtk: Set default focus to the close button in the clear browsing data dialog.

BUG=21461
TEST=GTK dialog matches Windows dialog.
Review URL: http://codereview.chromium.org/2813060
------------------------------------------------------------------------
r52814 | jam@chromium.org | 2010-07-17 08:55:22 +0200 (Sat, 17 Jul 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_updater.cc

Enable the pdf plugin by default.
Review URL: http://codereview.chromium.org/3028009
------------------------------------------------------------------------
r52812 | thestig@chromium.org | 2010-07-17 08:32:07 +0200 (Sat, 17 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc

Revert 52795 - Fix chromeos compile.

TBR=sargrass
BUG=none
TEST=chromeos builder goes green

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3032006
------------------------------------------------------------------------
r52810 | thestig@chromium.org | 2010-07-17 08:10:39 +0200 (Sat, 17 Jul 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc:52786)
   A /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h:52786)
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   D /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc
   D /trunk/src/chrome/browser/dom_ui/sync_options_handler.h
   D /trunk/src/chrome/browser/resources/options/personal_options.css
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Revert 52787 - Make the personal stuff page viewable.

BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options

Review URL: http://codereview.chromium.org/2819046

TBR=sargrass@google.com
Review URL: http://codereview.chromium.org/3012007
------------------------------------------------------------------------
r52808 | tfarina@chromium.org | 2010-07-17 06:17:05 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_installer.h

plugins: Show a help link in the "plugin needed" infobar.

BUG=6574
TEST=None

Review URL: http://codereview.chromium.org/2850031
------------------------------------------------------------------------
r52807 | shess@chromium.org | 2010-07-17 06:07:50 +0200 (Sat, 17 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/star_decoration.h

[Mac] Allow omnibox decorations to decline mouse events.

Certain decorations like the keyword-search bubble let mouse events
fall through to the field, as indicated by an i-beam cursor.  This
change causes decorations next to the text area to be aggregated into
the text-area's cursor rect.

BUG=41612
TEST=Keyword-search bubble shows I-beam cursor.
TEST=Location icon and star and page actions show arrow.

Review URL: http://codereview.chromium.org/2825048
------------------------------------------------------------------------
r52802 | eroman@chromium.org | 2010-07-17 05:37:51 +0200 (Sat, 17 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Add a command line flag to change the default number of parallel DNS requests issued by chrome.

  --host-resolver-parallelism=XXX

This is a useful debugging tool, since for some users too many parallel DNS requests results in spurious DNS failures from their resolver.

BUG=44489
Review URL: http://codereview.chromium.org/3019007
------------------------------------------------------------------------
r52800 | rogerta@google.com | 2010-07-17 05:11:21 +0200 (Sat, 17 Jul 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   M /trunk/src/chrome/browser/extensions/extension_rlz_module.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

When I specified the rlz chrome extension api, I explicitly did not include a
function to send pings to google for two reasons:

- I thought that chrome's own rlz pings would send all rlz information for all
  other products installed on the machine
- I did not want to allow an extension to DoS google by sending too many rlz
  pings

It turns out that the rlz library itself makes sure that a given product's
pings are never sent out more than once per day, as is required for rlz, so
there is no DoS danger by exposing a ping function.  Also, I was wrong in 
thinking that chrome's rlz pings would send out all rlz information about
other products installed on the machine: it sends out the other products rlz
strings, but it does not send out the other products rlz event information.
This makes sense since there are signatures and brand codes and other
information that cannot be determined by chrome for the extensions.

So adding a new rlz chrome extension function to expose sending pings.

BUG=None
TEST=See particular extension using this api

Review URL: http://codereview.chromium.org/3029001
------------------------------------------------------------------------
r52798 | shess@chromium.org | 2010-07-17 04:52:39 +0200 (Sat, 17 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Convert content settings to LocationBarDecoration, cleanup.

Cleanup removes all of the AutocompleteTextFieldIcon-based stuff from
the cell implementation.

BUG=none
TEST=content settings still appear at the right times and places.
TEST=content settings can be clicked on and the popup is positioned right.

Review URL: http://codereview.chromium.org/2888014
------------------------------------------------------------------------
r52797 | tfarina@chromium.org | 2010-07-17 04:47:52 +0200 (Sat, 17 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable-inl.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   D /trunk/src/chrome/browser/sync/util/row_iterator.h
   M /trunk/src/chrome/chrome.gyp

sync: Remove unused row_iterator.h file.

BUG=26443
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3020010
------------------------------------------------------------------------
r52795 | csilv@chromium.org | 2010-07-17 03:45:50 +0200 (Sat, 17 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc

Fix chromeos compile.

TBR=sargrass
BUG=none
TEST=chromeos builder goes green
------------------------------------------------------------------------
r52794 | oshima@chromium.org | 2010-07-17 03:31:40 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_state_notifier_browsertest.cc

Use WaitForNotification instead of busy loop.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2943006
------------------------------------------------------------------------
r52789 | rsleevi@chromium.org | 2010-07-17 02:48:48 +0200 (Sat, 17 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/net/base/ev_root_ca_metadata.cc
   M /trunk/src/net/base/ev_root_ca_metadata.h
   M /trunk/src/net/base/x509_cert_types.h
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/base/x509_certificate_unittest.cc
   M /trunk/src/net/base/x509_certificate_win.cc

Minor clean-up tasks that were TODO(snej)

Rename Principal->CertPrincipal, Policy->CertPolicy, both of which are merely syntatic fluff.

Rename Fingerprint->SHA1Fingerprint, which is more important since those using the fingerprint, such as the unit tests, were truly hardcoded against SHA-1 fingerprints, and if the fingerprint ever changed, wouldn't cause errors until run time.

R=wtc
BUG=None
TEST=Compilers stay green

Review URL: http://codereview.chromium.org/2815048
------------------------------------------------------------------------
r52788 | mmoss@google.com | 2010-07-17 02:47:48 +0200 (Sat, 17 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Mark tests FLAKY: HomePageLink and NTPHasThumbnails

BUG=49389

Review URL: http://codereview.chromium.org/2854050
------------------------------------------------------------------------
r52787 | sargrass@google.com | 2010-07-17 02:47:33 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc
   D /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/sync_options_handler.cc (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc:52776)
   A /trunk/src/chrome/browser/dom_ui/sync_options_handler.h (from /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h:52776)
   A /trunk/src/chrome/browser/resources/options/personal_options.css
   M /trunk/src/chrome/browser/resources/options/personal_options.html
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Make the personal stuff page viewable.

BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options

Review URL: http://codereview.chromium.org/2819046
------------------------------------------------------------------------
r52786 | georgey@chromium.org | 2010-07-17 02:41:14 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc

Added inferred labels implementation. Label inferred from the person name + differences in other fields to distinguish entries.
Also added it to generated previews.
TODO: adjust indices in the Credit Cards.
TEST=unit tested.
BUG=none
Review URL: http://codereview.chromium.org/2835026
------------------------------------------------------------------------
r52784 | aa@chromium.org | 2010-07-17 02:37:34 +0200 (Sat, 17 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.h
   M /trunk/src/chrome/browser/extensions/extension_context_menu_apitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/a11y.html
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   A /trunk/src/chrome/common/extensions/docs/contextMenus.html (from /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html:52776)
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/docs.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   D /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/common/extensions/docs/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/external_extensions.html
   M /trunk/src/chrome/common/extensions/docs/faq.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/idle.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/messaging.html
   M /trunk/src/chrome/common/extensions/docs/notifications.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/options.html
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   A /trunk/src/chrome/common/extensions/docs/static/contextMenus.html
   D /trunk/src/chrome/common/extensions/docs/static/experimental.contextMenus.html
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/tut_analytics.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tut_oauth.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/basics
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/basics/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/context_menus/manifest.json:52776)
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/basics/test.html (from /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.html:52776)
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/basics/test.js (from /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.js:52776)
   D /trunk/src/chrome/test/data/extensions/api_test/context_menus/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/no_perms
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/no_perms/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/no_perms/test.html (from /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.html:52776)
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/no_perms/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.js
   M /trunk/src/chrome/test/data/extensions/context_menus/manifest.json
   M /trunk/src/chrome/test/data/extensions/context_menus/test.js

Move context menu module out of experimental.

BUG=48725,39508

Review URL: http://codereview.chromium.org/2840038
------------------------------------------------------------------------
r52782 | estade@chromium.org | 2010-07-17 02:34:01 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_util.cc

GTK: fix navigation button click logic.

BUG=none
TEST=right click on new tab button should do nothing rather than crash in debug.

Review URL: http://codereview.chromium.org/3005014
------------------------------------------------------------------------
r52780 | ananta@chromium.org | 2010-07-17 02:31:29 +0200 (Sat, 17 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc

In ChromeFrame if window.open is received for a pending external tab, i.e. which has not received a connect
from the host browser, currently we end up crashing chrome due to dereferencing a NULL automation channel.

Ideally we should queue all IPC messages destined for a pending tab and send them out once we receive a connect.
However that solution is tricky as the messages carry the tab handle as one of the arguments which is only available
when we receive a connnect for the tab. The AutomationHandleTracker gives out these handles and is per automation provider.

We may have different automation provider instances in the case of IE8 and hence we cannot pre compute the tab handle.

Current solution is to add a NULL check around the offending code path which would basically drop the new contents
notification.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=49188

Bug=49188

Review URL: http://codereview.chromium.org/3021002
------------------------------------------------------------------------
r52778 | levin@chromium.org | 2010-07-17 02:30:18 +0200 (Sat, 17 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/external_extension.cc
   A /trunk/src/chrome/renderer/external_extension_uitest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/is_search_provider_installed.html

Implement IsSearchProviderInstalled and a test for it.

It is currently off by default and one must pass in a flag
(--enable-search-provider-api-v2) to use it. Api details are
in the bug.

BUG=38475
TEST=ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled

Review URL: http://codereview.chromium.org/2823042
------------------------------------------------------------------------
r52777 | arv@chromium.org | 2010-07-17 02:30:16 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Bookmarks: Remove the link from the bookmark list items.

BUG=43312
TEST=Open bookmarks manager. There bookmark list items should not longer be underlined on hover and clicking them should only select them.

Review URL: http://codereview.chromium.org/2813059
------------------------------------------------------------------------
r52774 | dmaclach@chromium.org | 2010-07-17 02:24:06 +0200 (Sat, 17 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/collected_cookies_uitest.cc

Marked 
TEST_F(CollectedCookiesTest, FAILS_TestDoubleDisplay)
and
TEST_F(CollectedCookiesTest, FAILS_NavigateAway)
because they were causing issues in the build waterfall.

http://code.google.com/p/chromium/issues/detail?id=49386

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3008007
------------------------------------------------------------------------
r52773 | cpu@chromium.org | 2010-07-17 02:15:51 +0200 (Sat, 17 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

Fix memory leak in unit test

Test is TemplateURLPrepopulateDataTest_ProvidersFromPrefs

TBR=oshima

BUG=49086
TEST=none

Review URL: http://codereview.chromium.org/2843056
------------------------------------------------------------------------
r52770 | scottbyer@chromium.org | 2010-07-17 01:35:46 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor.cc

ChromeOS PDF handling: if the built-in PDF viewer plug-in is active, don't intercept PDF opening and forward to gView, but use the plug-in instead.

BUG=chromium-os:4790
TEST=none

Review URL: http://codereview.chromium.org/2906010
------------------------------------------------------------------------
r52759 | phajdan.jr@chromium.org | 2010-07-17 00:23:57 +0200 (Sat, 17 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Fix the build on ChromeOS.

TBR=oshima

TEST=compile, please
BUG=48913
------------------------------------------------------------------------
r52752 | tfarina@chromium.org | 2010-07-16 23:46:02 +0200 (Fri, 16 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

TBR:brettw@chromium.org
------------------------------------------------------------------------
r52749 | phajdan.jr@chromium.org | 2010-07-16 23:41:16 +0200 (Fri, 16 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_mac.h
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_util_mac.mm
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   A /trunk/src/chrome/browser/download/download_file_manager.cc (from /trunk/src/chrome/browser/download/download_file.cc:52514)
   A /trunk/src/chrome/browser/download/download_file_manager.h (from /trunk/src/chrome/browser/download/download_file.h:52514)
   A /trunk/src/chrome/browser/download/download_item.cc (from /trunk/src/chrome/browser/download/download_manager.cc:52514)
   A /trunk/src/chrome/browser/download/download_item.h (from /trunk/src/chrome/browser/download/download_manager.h:52514)
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   A /trunk/src/chrome/browser/download/download_types.h (from /trunk/src/chrome/browser/download/download_file.h:52514)
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/drag_download_file.cc
   M /trunk/src/chrome/browser/download/drag_download_file.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/custom_drag.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/ui_test_utils.cc

Download code cleanup: split big files into smaller one.

It's hard to find things in the download directory. DownloadFile and DownloadFileManager
were bundled together. Similarly for DownloadItem and DownloadManager, which was much less
intuitive. Some 3-5 line structs were also in one bag with something else. I extracted them
to their own small file.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/2806054
------------------------------------------------------------------------
r52748 | estade@chromium.org | 2010-07-16 23:24:52 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

[GTK] Fix pref initialization order so options page doesn't instantly crash.

BUG=none
TEST=open options dialog

Review URL: http://codereview.chromium.org/3007004
------------------------------------------------------------------------
r52747 | csilv@chromium.org | 2010-07-16 23:14:29 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

When using SelectFileDialog::SelectFile with type SELECT_FOLDER, set button title to 'Select'
and show the 'New Folder' button.

BUG=none
TEST=From preferences select a new download folder, verify button title and new folder button.
Review URL: http://codereview.chromium.org/3028002
------------------------------------------------------------------------
r52745 | alyssad@chromium.org | 2010-07-16 22:51:57 +0200 (Fri, 16 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/passwords.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New PyAuto hook to get saved passwords. BUG=36179

Review URL: http://codereview.chromium.org/2842047
------------------------------------------------------------------------
r52741 | suzhe@chromium.org | 2010-07-16 22:47:40 +0200 (Fri, 16 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac]Handle edit commands from input methods correctly.

This CL does the following changes:

1.) It removes the EditCommandMatcher class and folds its behavior into RenderWidgetHostViewCocoa's -doCommandBySelector:. When -doCommandBySelector: is executed during execution of -keyDown: (the normal case), the commands are scheduled to be sent by -keyDown: later on, else they are sent immediately.

2.) If edit commands have been scheduled while IME composition is happening, delay delivery of the real key event (and eventual edit commands) until the fake key event(keycode 229) and IME composition have been sent to webkit. Safari sends the IME composition events first and deliver the key events after that, but according to HTML DOM Level3 Events Spec (http://www.w3.org/TR/DOM-Level-3-Events/#keyset-comp-input), the key events shall be sent before the IME composition events.

BUG=48161 I should press 'enter' twice to search korean keyword in the omnibox and web fields
BUG=48247 Pagedown/pageup inserts characters in textbox
TEST=See bug reports.

Review URL: http://codereview.chromium.org/2805075
------------------------------------------------------------------------
r52740 | tim@chromium.org | 2010-07-16 22:43:06 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Always show the 'Control sync from Google Dashboard' link on the sync options dialog.

BUG=48844
TEST=open Personal Stuff on any platform, see dashboard link.

Review URL: http://codereview.chromium.org/2827055
------------------------------------------------------------------------
r52738 | andybons@chromium.org | 2010-07-16 22:40:58 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Toolbar UI tweaks.
o 4px between wrench menu and location bar/edge of window.
o 4px between reload button and location bar.
o Adjust size of wrench menu to be the same size as every other button.
o Fix bug where location bar would be too close to the wrench menu when disabling the last visible browser action.

BUG=46738,48678
TEST=visual
Review URL: http://codereview.chromium.org/3027005
------------------------------------------------------------------------
r52737 | akalin@chromium.org | 2010-07-16 22:40:07 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   M /trunk/src/jingle/notifier/communicator/login.cc
   M /trunk/src/jingle/notifier/communicator/login.h
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.cc
   M /trunk/src/jingle/notifier/communicator/single_login_attempt.h
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/jingle/notifier/listener/mediator_thread_impl.h
   M /trunk/src/jingle/notifier/listener/talk_mediator_unittest.cc

Added switch to use ChromeAsyncSocket for sync.

BUG=45612
TEST=manual

Review URL: http://codereview.chromium.org/2819049
------------------------------------------------------------------------
r52734 | feldstein@chromium.org | 2010-07-16 22:33:53 +0200 (Fri, 16 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/before_translate_infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.h
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm

Add the always/never translate buttons

Port over the windows work onto the mac to add the button when a user presses
translate or cancel more than 3 times in a row.

BUG=48136
TEST=Cancel or accept translation more than 3 times in a row to see the button
pop up and work.

Review URL: http://codereview.chromium.org/2891015
------------------------------------------------------------------------
r52729 | mdm@chromium.org | 2010-07-16 22:30:42 +0200 (Fri, 16 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.cc
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.h

Linux: access GNOME Keyring on the GLib main thread, rather than the DB thread.
I was unable to reproduce the crash, but it's happening to a lot of people and the web suggests that moving access to GNOME Keyring to the GLib main thread should fix the problem.
BUG=48343, 25404
TEST=hopefully it won't crash for some people any more
Review URL: http://codereview.chromium.org/2953006
------------------------------------------------------------------------
r52728 | csilv@chromium.org | 2010-07-16 22:30:34 +0200 (Fri, 16 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/shared/js/local_strings.js
   A /trunk/src/chrome/browser/resources/shared/js/local_strings_test.html

Add methods to LocalStrings to fetch strings without Windows-style accelerators.

BUG=48715
TEST=View options window using --enable-tabbed-options, verify that advanced panel shows Browse button without ampersand.
Review URL: http://codereview.chromium.org/2832056
------------------------------------------------------------------------
r52727 | tfarina@chromium.org | 2010-07-16 21:48:37 +0200 (Fri, 16 Jul 2010) | 13 lines
Changed paths:
   D /trunk/src/chrome/browser/gtk/input_window_dialog_gtk.cc
   D /trunk/src/chrome/browser/gtk/input_window_dialog_gtk.h
   A /trunk/src/chrome/browser/input_window_dialog_gtk.cc (from /trunk/src/chrome/browser/input_window_dialog_gtk.cc:52720)
   A /trunk/src/chrome/browser/input_window_dialog_win.cc (from /trunk/src/chrome/browser/input_window_dialog_win.cc:52720)
   D /trunk/src/chrome/browser/views/input_window_dialog_win.cc
   D /trunk/src/chrome/browser/views/input_window_dialog_win.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 52721 - Refactor the implementation of InputWindowDialog.

- Move the implementation of each platform under its respective source directory.
- Rename the classes to match with pattern used in the chrome source.
- In the gtk side, use the gtk signal macros for the callback events.

BUG=None
TEST=open the bookmark editor dialog, everything should works as before on windows and linux.

Review URL: http://codereview.chromium.org/2832028

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2835043
------------------------------------------------------------------------
r52726 | erg@chromium.org | 2010-07-16 21:36:16 +0200 (Fri, 16 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   A /trunk/src/chrome/browser/password_manager/password_manager_delegate.h
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/password_autocomplete_manager.cc
   M /trunk/src/chrome/renderer/password_autocomplete_manager.h
   M /trunk/src/chrome/renderer/password_autocomplete_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations.h
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.h
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_unittest.cc

Separate the PasswordManagerDelegate out of PasswordManager.

Previously, anyone who included tab_contents.h would bring in a bunch of
implementation details of the password manager from webkit_glue. This breaks
the delegate interface out of the rest of password manager system and makes
FillData not an inner-class so anyone can forward declare FillData instead of
having to include the header to meet a delegate interface.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2877022
------------------------------------------------------------------------
r52723 | thestig@chromium.org | 2010-07-16 21:28:17 +0200 (Fri, 16 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc

Linux: Guess the thread id for crashing renderers in a different PID namespace.

BUG=48997
TEST=Google Chrome gets valid crash reports for about:crash most of the time.
Review URL: http://codereview.chromium.org/2961008
------------------------------------------------------------------------
r52721 | tfarina@chromium.org | 2010-07-16 21:17:55 +0200 (Fri, 16 Jul 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/input_window_dialog_gtk.cc (from /trunk/src/chrome/browser/input_window_dialog_gtk.cc:52719)
   A /trunk/src/chrome/browser/gtk/input_window_dialog_gtk.h
   D /trunk/src/chrome/browser/input_window_dialog_gtk.cc
   D /trunk/src/chrome/browser/input_window_dialog_win.cc
   A /trunk/src/chrome/browser/views/input_window_dialog_win.cc
   A /trunk/src/chrome/browser/views/input_window_dialog_win.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor the implementation of InputWindowDialog.

- Move the implementation of each platform under its respective source directory.
- Rename the classes to match with pattern used in the chrome source.
- In the gtk side, use the gtk signal macros for the callback events.

BUG=None
TEST=open the bookmark editor dialog, everything should works as before on windows and linux.

Review URL: http://codereview.chromium.org/2832028
------------------------------------------------------------------------
r52719 | lzheng@chromium.org | 2010-07-16 21:06:29 +0200 (Fri, 16 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_browsertest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/chrome_tests.gypi

First change to add safebrowsing service test. 
Right now, the test only launch the browser and makes sure no 
auto update is scheduled.

Later, the test suite server will be launched within the test
and requests will be issued,

BUG=47318
TEST=this is the test.
Review URL: http://codereview.chromium.org/2845035
------------------------------------------------------------------------
r52718 | oshima@chromium.org | 2010-07-16 21:06:26 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc

Disable AutocompleteBrowserTest.Basic instead of FLAKY_

BUG=49324
TEST=none

Review URL: http://codereview.chromium.org/3039007
------------------------------------------------------------------------
r52716 | lzheng@chromium.org | 2010-07-16 21:06:07 +0200 (Fri, 16 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Now spdy in enabled by default to 50% of users. We could remove the special case for sxs.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2861058
------------------------------------------------------------------------
r52715 | estade@chromium.org | 2010-07-16 20:58:22 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

[GTK] Don't access a destroyed widget.

BUG=49133
TEST=no DCHECKs when following bug repro steps

Review URL: http://codereview.chromium.org/2878031
------------------------------------------------------------------------
r52710 | avi@chromium.org | 2010-07-16 20:46:52 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/policy/mac/app-Manifest.plist
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/chrome_exe.gypi
   A /trunk/src/chrome/tools/build/mac/copy_mcx_manifest.sh

Stuff the MCX policy file into the app bundle where it belongs.

BUG=http://crbug.com/45334
TEST=build chromium, open the package, look in the resources folder, see either "org.chromium.Chromium.manifest" or "com.google.Chrome.manifest" (depending on the build). Open the file, see either "Chromium" or "Google Chrome" at the top (again, depending on the build).

Review URL: http://codereview.chromium.org/2809057
------------------------------------------------------------------------
r52707 | dhollowa@chromium.org | 2010-07-16 20:27:45 +0200 (Fri, 16 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillAddressSheet.xib
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardSheet.xib
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm

AutoFill labels removed from preferences dialog on Mac

This removes the labels data entry fields on the AutoFill preferences dialog on Mac.  Labels
are now derived fields so user input is not needed.

Nib changes made are AutoFillAddressSheet.xib: removed "Label" entry and status indicator, adjusted
layout to account for new space.  AutoFillCreditCardSheet.xib: removed "Label" entry and status
indicator, adjusted layout to account for new space.  AutoFillDialog.xib: removed the table header,
removed the "Label" column, adjusted sizing of remaining "Summary" column to account for new space,
move the buttons lower to top-align with table.

BUG=47430
TEST=AutoFillAddressModelTest.*, AutoFillCreditCardModelTest.*, AutoFillDialogText.*

Review URL: http://codereview.chromium.org/2813052
------------------------------------------------------------------------
r52704 | jhawkins@chromium.org | 2010-07-16 20:08:34 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc

Build Fix: Fix signature for a ChromeOS class.

TBR=mmoss
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3013009
------------------------------------------------------------------------
r52703 | oshima@chromium.org | 2010-07-16 19:47:22 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Mark CaptureVisibleTab as flaky.
 This is failing on kermic 64 machine, which only exists in tryservers.

BUG=49040
TEST=none

Review URL: http://codereview.chromium.org/2979006
------------------------------------------------------------------------
r52701 | oshima@chromium.org | 2010-07-16 19:43:56 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc

Mark AutocompleteBrowserTest.Basic as flaky.

TBR=phajdan.jr@chromium.org
BUG=49324
TEST=none

Review URL: http://codereview.chromium.org/3020007
------------------------------------------------------------------------
r52700 | stevenjb@chromium.org | 2010-07-16 19:42:38 +0200 (Fri, 16 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc

WifiConfigView::Init(): Fetch the localized string for the cert
button, rather than using the cert button ID directly, which produces
garbage.

BUG=http://crosbug.com/4490
TEST=Click network dropdown and select a 802.1x network that has not
been configured by the system (google-A when logged in to a non-corp
account, for example). Check that the button to the right of the
"Certificate:" label contains text ("Select certificate file"), rather
than the not-a-character glyph.

Review URL: http://codereview.chromium.org/2952006
Patch from Nathan Williams <njw@chromium.org>.
------------------------------------------------------------------------
r52699 | jhawkins@chromium.org | 2010-07-16 19:34:39 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.cc

AutoFill: Use unique IDs to identify the profile or credit card to fill.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3019001
------------------------------------------------------------------------
r52694 | erg@chromium.org | 2010-07-16 19:22:49 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/weak_ptr.cc
   M /trunk/src/base/weak_ptr.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/notification_details.cc
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_observer.h
   M /trunk/src/chrome/common/notification_service.cc
   A /trunk/src/chrome/common/notification_source.cc
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/webkit/glue/plugins/pepper_url_response_info.h

Remove more definitions from header files.

This patch only concerns itself with places where we have more than 100 copies of methods being generated. (For example, the destructor and other random methods in FilePath weren't being inlined, leading to several hundred copies being generated.)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3039001
------------------------------------------------------------------------
r52690 | oshima@chromium.org | 2010-07-16 19:02:00 +0200 (Fri, 16 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   D /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   D /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   D /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   D /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/browser/chromeos/view_ids.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   D /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Removing the code that are no longer in use.
* CompactNavigationBar
  this feature has been discontinued
* BrowserStatusAreaView
  status area used to have a menu, but it's gone and this
  class no longer needed.
* BrowserExtender
  used to implement chromeos specific feature,
   which has been replaced by chromeos/browser_view

BUG=49229
TEST=no functional chagne. all test should pass.

Review URL: http://codereview.chromium.org/3035004
------------------------------------------------------------------------
r52689 | albertb@chromium.org | 2010-07-16 19:00:42 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Set the options dialog as the parent window of the sync wizard when the
wizard is started from options.

BUG=19776
TEST=manually tested

Review URL: http://codereview.chromium.org/2976009
------------------------------------------------------------------------
r52687 | stevenjb@chromium.org | 2010-07-16 18:56:11 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix for Issue 4211: window.open(,, 'type=FullWindow,fullscreen') should not open full screen page.
In chromeos create a foreground tab if the width or height is 0 (instead of a tab sized popup)
http://code.google.com/p/chromium-os/issues/detail?id=4211
BUG=chromeos:4211
TEST=If a third argument is provided to window.open() and either width or height is unspecified, a new tab should be opened instead of a full screen popup.

Review URL: http://codereview.chromium.org/2947009
------------------------------------------------------------------------
r52686 | shess@chromium.org | 2010-07-16 18:51:48 +0200 (Fri, 16 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Convert page-action icons to PageActionDecoration.

Removes specific knowledge of page-actions from AutocompleteTextField
(and Cell and Editor).  LocationBarViewMac owns and manages them.
PageActionDecoration class pulls some of the specific knowledge out of
location_bar_view_mac.mm.

BUG=none
TEST=Page actions still appear in the right place.
TEST=Page action clicks work.
TEST=Page action context menus work.

Review URL: http://codereview.chromium.org/2861050
------------------------------------------------------------------------
r52684 | stevenjb@chromium.org | 2010-07-16 18:34:10 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc

Remove SetAnimation() call for tab close button.
http://code.google.com/p/chromium-os/issues/detail?id=3929
BUG=chromium-os:3929
TEST=manual (hover over close button, should fade in/out same as other hover behavior)

Review URL: http://codereview.chromium.org/2809054
------------------------------------------------------------------------
r52683 | jcivelli@chromium.org | 2010-07-16 18:32:12 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h

Adding a way for user to report errors in language detection
Adding a menu to the translate infobar that let users report when the language of a page has been incorrectly detected.
BUG=48739
TEST=Visit a page in a language that triggers the translate infobar. Select the menu to report an error. A new tab should be opened that references the page and language and let you report the error.

Review URL: http://codereview.chromium.org/2911005
------------------------------------------------------------------------
r52682 | sky@chromium.org | 2010-07-16 18:27:41 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Makes the decrement zoom button appear before the increment button.

BUG=48332
TEST=make sure the wrench menu has the decrement zoom button before
the increment zoom button.

Review URL: http://codereview.chromium.org/3008004
------------------------------------------------------------------------
r52679 | mirandac@google.com | 2010-07-16 18:16:52 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   D /trunk/src/chrome/browser/views/first_run_customize_view.cc
   D /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h
   D /trunk/src/chrome/browser/views/first_run_view.cc
   D /trunk/src/chrome/browser/views/first_run_view.h
   D /trunk/src/chrome/browser/views/first_run_view_base.cc
   D /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

New first run sequence for Windows, with no UI.  Organic builds will display the Search Engine Dialog, otherwise search engine is set to Google or silently imported, depending on master_preferences.  (see go/chromefirstrun for details).

I also removed a no-longer-used SearchSelectObserver from FirstRunSearchView.

BUG=42612
TEST=First run import works as intended (see go/chromefirstrun). master_preferences file can still turn off import of history, search engine, and home page.

Review URL: http://codereview.chromium.org/2934011
------------------------------------------------------------------------
r52677 | davemoore@chromium.org | 2010-07-16 18:10:03 +0200 (Fri, 16 Jul 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h

Ignore extraneous notification when setting find text
Because gtk generates a notification when the text is set
programatically it would end up highlighting the text even
after the find UI was dismissed. Also switch back and forth
between 2 tabs would progress the currently found item each time.
BUG=46876
TEST=On chromeos:
- Open tab 1, browse to first page
- Open tab 2, browse to different page
- Switch back to tab 1, open find UI
- Type a character that occurs in page 1
- Switch to tab 2, open find UI
- Type a character that occurs in page 2
- Switch back to page 1. Confirm that the currently selected
  found text doesn't change.
- Close the find UI
- Switch back and forth between tabs 1 & 2...tab 1 shouldn't show
  any highlights.

Review URL: http://codereview.chromium.org/3005007
------------------------------------------------------------------------
r52676 | xiyuan@chromium.org | 2010-07-16 18:00:09 +0200 (Fri, 16 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/cros_settings.cc
   A /trunk/src/chrome/browser/chromeos/cros_settings.h
   A /trunk/src/chrome/browser/chromeos/cros_settings_names.cc
   A /trunk/src/chrome/browser/chromeos/cros_settings_names.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/accounts_options_handler.h
   A /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h
   A /trunk/src/chrome/browser/chromeos/mock_cros_settings.cc
   A /trunk/src/chrome/browser/chromeos/mock_cros_settings.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_add_user_overlay.html
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_add_user_overlay.js
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.html
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_options.js
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_options_page.css
   A /trunk/src/chrome/browser/resources/options/chromeos_accounts_user_list.js
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options/preferences.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/array_data_model.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js
   M /trunk/src/chrome/chrome_browser.gypi

Initial accounts options page.

- Add a "Accounts" subpage for ChromeOS;
- Two checkboxes for allowing BWSI and allowing guest signin;
- Make measureItem in list.js returns 0 instead of -1. The itemHeight is -1
  when the list is not visible. And 0 will let redraw to call measureItem
  again;
- Add an onVisibilityChanged callback that is called when "visible" property
  is changed; And use that to trigger user list's redraw;
- Use a mock settings object so that the UI flow could be tested;

- Update options_page.css to add a few css missed from dhg's overlay cl;

BUG=chromium-os:4734
TEST=None. This is a draft version and will be changed after UX feedbacks.

Review URL: http://codereview.chromium.org/2935011
------------------------------------------------------------------------
r52675 | stuartmorgan@chromium.org | 2010-07-16 17:47:22 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/browser_options_page.css
   M /trunk/src/chrome/browser/resources/options.html

Implement search engine selection in DOMUI prefs

BUG=48713
TEST=Changing search engines in DOMUP prefs should be persisted.

Review URL: http://codereview.chromium.org/2883024
------------------------------------------------------------------------
r52671 | sky@chromium.org | 2010-07-16 17:32:54 +0200 (Fri, 16 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Fixes regression in quickly switching tabs. If
TabContentsView::SizeContents is invoked with the same size then
SetWindowPos won't generate a WM_POSCHANGED and we won't size the
contents. If the contents don't have the correct size (perhaps because
it was created in the background) then we'll get visual garbage next
time you switch to the tab.

BUG=48882
TEST=see bug

Review URL: http://codereview.chromium.org/2842052
------------------------------------------------------------------------
r52662 | tfarina@chromium.org | 2010-07-16 16:06:11 +0200 (Fri, 16 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/password_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   D /trunk/src/chrome/browser/sync/util/closure.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.h

sync: Get rid of duplicated typedef Closure definition.

The closure.h file just defines a callback type. But base/callback.h already
define a callback with the same type, but with a different name. So just use
the callback from base instead.

BUG=26443
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2966009
------------------------------------------------------------------------
r52659 | skerner@chromium.org | 2010-07-16 15:49:31 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/convert_user_script.cc

Pack content scripts in a temp directory in the profile dir.

BUG=49008
TEST=ExtensionsServiceTest.InstallUserScript

Review URL: http://codereview.chromium.org/2961006
------------------------------------------------------------------------
r52656 | danno@chromium.org | 2010-07-16 15:30:24 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc

Add policy banner to "Personal Stuff" settings when with password manager policy set

BUG=49288
TEST=none

Review URL: http://codereview.chromium.org/2806056
------------------------------------------------------------------------
r52655 | jochen@chromium.org | 2010-07-16 15:05:48 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/nibs/CollectedCookies.xib
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/collected_cookies_mac.h
   A /trunk/src/chrome/browser/cocoa/collected_cookies_mac.mm
   A /trunk/src/chrome/browser/cocoa/collected_cookies_mac_unittest.mm
   A /trunk/src/chrome/browser/collected_cookies_uitest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   A /trunk/src/chrome/browser/gtk/collected_cookies_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   A /trunk/src/chrome/browser/views/collected_cookies_win.cc
   A /trunk/src/chrome/browser/views/collected_cookies_win.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h

Reland r52486. Display a tab modal dialog of the allowed/blocked cookies.

BUG=45230
TEST=CollectedCookiesTest.*

Review URL: http://codereview.chromium.org/3034007
------------------------------------------------------------------------
r52654 | mnissler@chromium.org | 2010-07-16 14:53:40 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Handle Homepage and HomepageIsNewTabPage policies independently in Mac UI.

XIB changes: Rename radio enabled KVC getter, fix broken isPasswordMangerEnabled connection.

BUG=48469
TEST=Configure policies, check UI.

Review URL: http://codereview.chromium.org/2909014
------------------------------------------------------------------------
r52651 | apavlov@chromium.org | 2010-07-16 13:58:48 +0200 (Fri, 16 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   A /trunk/src/chrome/browser/debugger/devtools_toggle_action.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/chrome.gyp

Add "Inspect Element" shortcut to browser tabs.

If the DevTools window is closed, it gets opened, and the Inspect Element tool is enabled. If the DevTools window is opened, the inspected tab remains focused with the Inspect Element tool enabled.
If the Inspect Element tool is enabled, it gets turned off.

The shortcut is Ctrl-Shift-C for Win/Linux, Cmd-Shift-C for Mac

BUG=29532
TEST=manual

Review URL: http://codereview.chromium.org/3011002
------------------------------------------------------------------------
r52650 | pam@chromium.org | 2010-07-16 13:48:21 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/command_line_pref_store.cc
   A /trunk/src/chrome/browser/command_line_pref_store.h
   A /trunk/src/chrome/browser/command_line_pref_store_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add a PrefStore for loading prefs from command-line switches.

The first users are proxies and locale, for policies.

BUG=49162
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/3025001
------------------------------------------------------------------------
r52649 | nirnimesh@chromium.org | 2010-07-16 13:33:34 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/automation/automation_provider_json.cc
   A /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/pyautolib/pyauto.py

(Reland reverted r52628 after fix)

Refactor json automation interface for pyauto hooks.
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.

Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.

Review URL: http://codereview.chromium.org/2898001
------------------------------------------------------------------------
r52640 | tyoshino@chromium.org | 2010-07-16 11:57:58 +0200 (Fri, 16 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   D /trunk/src/chrome/browser/automation/automation_provider_json.cc
   D /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Revert 52628 - Refactor json automation interface for pyauto hooks.
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.

Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.

Reason: since startup_test of XP Perf and Vista Perf failed around this change and
this change touched automated test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52054

Review URL: http://codereview.chromium.org/2898001

TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/2812057
------------------------------------------------------------------------
r52639 | nkostylev@google.com | 2010-07-16 11:35:32 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/register_page_ui.cc
   A /trunk/src/chrome/browser/dom_ui/register_page_ui.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Switch registration page from about:register to chrome://register.
That will allow registering custom JS handlers.

BUG= http://crosbug.com/4813
NONE=none

Review URL: http://codereview.chromium.org/2870051
------------------------------------------------------------------------
r52638 | akalin@chromium.org | 2010-07-16 11:35:30 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/tools/chrome_async_socket.cc
   D /trunk/src/chrome/browser/sync/tools/chrome_async_socket.h
   D /trunk/src/chrome/browser/sync/tools/chrome_async_socket_unittest.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/jingle/jingle.gyp
   A /trunk/src/jingle/notifier/base/chrome_async_socket.cc (from /trunk/src/chrome/browser/sync/tools/chrome_async_socket.cc:52634)
   A /trunk/src/jingle/notifier/base/chrome_async_socket.h (from /trunk/src/chrome/browser/sync/tools/chrome_async_socket.h:52634)
   A /trunk/src/jingle/notifier/base/chrome_async_socket_unittest.cc (from /trunk/src/chrome/browser/sync/tools/chrome_async_socket_unittest.cc:52634)

Moved ChromeAsyncSocket to jingle/notifier/base.

Fixed some signed/unsigned warnings.

BUG=45612
TEST=existing unittests

Review URL: http://codereview.chromium.org/2857039
------------------------------------------------------------------------
r52637 | danno@chromium.org | 2010-07-16 11:33:45 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Implements policy to enable or disable the password manager, as found in the Options dialog, in the Under the Personal Stuff section.

xib changes: added an enabled binding to the policy-controlled checkboxes in the "Personal Stuff" preference pane so that they can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.

BUG=44395
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.*  Manual tests: Set the policy externally.  Check that the radio buttons and the "Show saved passwords" button in Options/Personal Stuff/Passwords are disabled.  Also check that the check box is set/unset as done by the policy.

Review URL: http://codereview.chromium.org/2848039
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
------------------------------------------------------------------------
r52636 | tyoshino@chromium.org | 2010-07-16 11:07:59 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

Revert 52624 - TTF: enable FindInPageControllerTest.FindNextInNewTabUsesPrepopulate.
This test seems to be working again.

Reason: failed on build bot again.

Review URL: http://codereview.chromium.org/2935004

TBR=dmuir@chromium.org
Review URL: http://codereview.chromium.org/3025002
------------------------------------------------------------------------
r52635 | akalin@chromium.org | 2010-07-16 10:49:49 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/protocol/autofill_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/bookmark_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/encryption.proto
   M /trunk/src/chrome/browser/sync/protocol/extension_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/nigori_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/password_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/preference_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/browser/sync/protocol/theme_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/typed_url_specifics.proto
   M /trunk/src/chrome/chrome.gyp

Switched sync protobufs to use "heavy" protobufs.

This is so that unknown fields in sync proto fields are preserved.

BUG=49107
TEST=compiled

Review URL: http://codereview.chromium.org/2951016
------------------------------------------------------------------------
r52634 | pfeldman@chromium.org | 2010-07-16 10:25:41 +0200 (Fri, 16 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_net_log.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   A /trunk/src/chrome/browser/net/load_timing_observer.cc
   A /trunk/src/chrome/browser/net/load_timing_observer.h
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/net/url_request/url_request_netlog_params.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

DevTools & WebTiming : Migrate from PassiveLogCollector to dedicated LoadTimingObserver.

Review URL: http://codereview.chromium.org/2909016
------------------------------------------------------------------------
r52632 | mnissler@chromium.org | 2010-07-16 10:05:49 +0200 (Fri, 16 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc

Fix Linux build broken due to warning triggered by r52630

BUG=none
TEST=Linux should compile
TBR=mnissler@chromium.org

Review URL: http://codereview.chromium.org/3028005
------------------------------------------------------------------------
r52630 | mnissler@chromium.org | 2010-07-16 09:53:30 +0200 (Fri, 16 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h

sync behavior of homepage options on Linux to Windows

Address several issues on Linux that were covered on Windows by the following two CLs:
http://codereview.chromium.org/2843022/show
http://codereview.chromium.org/2815021/show
In particular:
-only disable a homepage control if it is explicitly configured by a policy
-don't clear homepage location if "new tab" page is selected
-detect "chrome://newtab" URL (fix the already existingm but broken detection code)

This CL is basically a copy-past from the Windows part. The bug ID refers to the original Windows bug.

BUG=46486
TEST=manual

Review URL: http://codereview.chromium.org/2802036
Patch from Gabor Feher <gfeher@google.com>.
------------------------------------------------------------------------
r52628 | nirnimesh@chromium.org | 2010-07-16 09:35:57 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/automation/automation_provider_json.cc
   A /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Refactor json automation interface for pyauto hooks.
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.

Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52054

Review URL: http://codereview.chromium.org/2898001
------------------------------------------------------------------------
r52624 | dmuir@chromium.org | 2010-07-16 08:45:05 +0200 (Fri, 16 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

TTF: enable FindInPageControllerTest.FindNextInNewTabUsesPrepopulate.
This test seems to be working again.

Review URL: http://codereview.chromium.org/2935004
------------------------------------------------------------------------
r52623 | aa@chromium.org | 2010-07-16 08:38:59 +0200 (Fri, 16 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_apitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/a11y.html
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/build/build.py
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/docs.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html
   D /trunk/src/chrome/common/extensions/docs/experimental.cookies.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/common/extensions/docs/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/external_extensions.html
   M /trunk/src/chrome/common/extensions/docs/faq.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/idle.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/messaging.html
   M /trunk/src/chrome/common/extensions/docs/notifications.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/options.html
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   A /trunk/src/chrome/common/extensions/docs/static/cookies.html
   M /trunk/src/chrome/common/extensions/docs/static/devguide.html
   D /trunk/src/chrome/common/extensions/docs/static/experimental.cookies.html
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/tut_analytics.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tut_oauth.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/api/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/api/tab.html
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/events/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/events/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/no_permission/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/no_permission/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/cookies/api/manifest.json:52622)

Unexperimentalify the cookies API.

BUG=41663,48726

Review URL: http://codereview.chromium.org/2982008
------------------------------------------------------------------------
r52619 | yusukes@google.com | 2010-07-16 08:00:27 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/language_preferences_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add unit_tests for language_preferences.h to detect a typo in preference definition like http://codereview.chromium.org/2881015.

BUG=none
TEST=checked the test detects the typo (http://codereview.chromium.org/2881015)

Review URL: http://codereview.chromium.org/2877017
------------------------------------------------------------------------
r52618 | yusukes@google.com | 2010-07-16 07:58:47 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

Fix a typo in kMozcMultipleChoicePrefs[].

BUG=chromium-os:4841
TEST=manually

Review URL: http://codereview.chromium.org/2881015
------------------------------------------------------------------------
r52610 | shess@chromium.org | 2010-07-16 06:37:18 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/theme/blocked_cookies.png
   M /trunk/src/chrome/app/theme/blocked_images.png
   M /trunk/src/chrome/app/theme/blocked_javascript.png
   M /trunk/src/chrome/app/theme/blocked_plugins.png
   M /trunk/src/chrome/app/theme/blocked_popups.png
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm

Land new resource for content-setting images.

Additionally, note in the Mac code that the icon padding is the same
as for views.  Because that's what the bug was originally about.

BUG=42485
TEST=content settings still look right.

Review URL: http://codereview.chromium.org/3034003
------------------------------------------------------------------------
r52609 | shess@chromium.org | 2010-07-16 06:36:08 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

[Mac] Shorten -[AutocompleteTextField autocompleteTextFieldCell].

Awhile back, pink demo'ed a trick on the -delegate method, use that to
get rid of a long unruly alternate method name for -cell.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2909013
------------------------------------------------------------------------
r52607 | dhollowa@chromium.org | 2010-07-16 06:03:57 +0200 (Fri, 16 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc

Using Keychain mock in Sync unit tests.

The Encryptor on Mac can now put up blocking UI when access to the system
Keychain is requested.  This needs to be disabled for unit tests.  These
tests were missed in r52590.

BUG=none
TEST=AuthWatcherTest.AuthenticateBadAuthToken, AuthWatcherTest.AuthenticateSuccess, AuthWatcherTest.RenewAuthToken, UserSettingsTest.PersistEmptyToken, UserSettingsTest.PersistNonEmptyToken

TBR=stuartmorgan@chromium.org

Review URL: http://codereview.chromium.org/2835041
------------------------------------------------------------------------
r52606 | oshima@chromium.org | 2010-07-16 05:37:08 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Marking ExtensionApiTest.TabOnRemove flaky.

BUG=49258
TEST=none

Review URL: http://codereview.chromium.org/3011005
------------------------------------------------------------------------
r52602 | tfarina@chromium.org | 2010-07-16 05:34:25 +0200 (Fri, 16 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/base/env_var.cc
   M /trunk/src/base/env_var.h
   M /trunk/src/base/env_var_unittest.cc
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

base: Return bool instead of void in EnvVarGetter::SetEnv.

Returning bool instead of void in this function is better, because with that
we can know if we had succeeded when tried to set an environment variable or not.
Also it makes this function more testable.

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.*

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2891024
------------------------------------------------------------------------
r52601 | tfarina@chromium.org | 2010-07-16 05:09:12 +0200 (Fri, 16 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Revert 52600 - renderer_host: Remove CanBlur method.

This method was not implemented and always returns true.

(Note: this was a TODO for brettw).

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2870050

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/3033004
------------------------------------------------------------------------
r52600 | tfarina@chromium.org | 2010-07-16 04:56:47 +0200 (Fri, 16 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

renderer_host: Remove CanBlur method.

This method was not implemented and always returns true.

(Note: this was a TODO for brettw).

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2870050
------------------------------------------------------------------------
r52597 | tfarina@chromium.org | 2010-07-16 04:39:47 +0200 (Fri, 16 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/content_settings_helper.cc
   A /trunk/src/chrome/common/content_settings_helper.h
   A /trunk/src/chrome/common/content_settings_helper_unittest.cc

Factor out OriginToString into a common function in chrome/common/.

With that, notifications doesn't depend on geolocation code anymore.

(NOTE: this was a TODO for bulach).

BUG=None
TEST=out/Debug/unit_tests --gtest_filter=ContentSettingsHelperTest.*

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2910005
------------------------------------------------------------------------
r52596 | dhollowa@chromium.org | 2010-07-16 04:28:38 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/encryptor_linux.cc
   M /trunk/src/chrome/browser/password_manager/encryptor_unittest.cc

AutoFill credit cards should be obfuscated on Linux

AutoFill credit card information now gets stored in obfuscated form on disc.

BUG=42038, 49115
TEST=EncryptorTest.CypherTextDiffers, EncryptorTest.DecryptError

Review URL: http://codereview.chromium.org/2931020
------------------------------------------------------------------------
r52590 | dhollowa@chromium.org | 2010-07-16 03:51:45 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/crypto/encryptor_mac.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/keychain_mac.cc
   M /trunk/src/chrome/browser/keychain_mac.h
   M /trunk/src/chrome/browser/keychain_mock_mac.cc
   M /trunk/src/chrome/browser/keychain_mock_mac.h
   M /trunk/src/chrome/browser/password_manager/encryptor.h
   M /trunk/src/chrome/browser/password_manager/encryptor_mac.mm
   A /trunk/src/chrome/browser/password_manager/encryptor_password_mac.h
   A /trunk/src/chrome/browser/password_manager/encryptor_password_mac.mm
   A /trunk/src/chrome/browser/password_manager/encryptor_password_mac_unittest.cc
   M /trunk/src/chrome/browser/password_manager/encryptor_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill credit cards should be encrypted on the Mac

These changes add encryption support on Mac for the Encryptor class.  AES 128 bit is used for the encryption, and the auto-generated password is stored now in the Mac Keychain.  This implies the Encryptor class on Mac can now block for user input, and can fail if access is denied.

BUG=42038, 49131
TEST=EncryptorTest.CypherTextDiffers, EncryptorTest.DecryptError, EncryptorPasswordTest.*

Review URL: http://codereview.chromium.org/2943014
------------------------------------------------------------------------
r52589 | aa@chromium.org | 2010-07-16 03:47:30 +0200 (Fri, 16 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm

Disable DispatchSegmentedControl because it crashes unit tests.

TBR=rsesek@chromium.org
BUG=49206
------------------------------------------------------------------------
r52586 | arv@chromium.org | 2010-07-16 03:21:57 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/position_util.js

Bookmarks: Be a bit more cautios when positioning a menu to prevent it from being displayed outside the viewport.

BUG=None
TEST=Open bookmark manager. Make the window pretty small. The context menu should not be cut of unless the window is smaller than the menu.

Review URL: http://codereview.chromium.org/3008003
------------------------------------------------------------------------
r52585 | aa@chromium.org | 2010-07-16 03:08:29 +0200 (Fri, 16 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_apitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/a11y.html
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/docs.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/common/extensions/docs/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/external_extensions.html
   M /trunk/src/chrome/common/extensions/docs/faq.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/idle.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/messaging.html
   M /trunk/src/chrome/common/extensions/docs/notifications.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/options.html
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   D /trunk/src/chrome/common/extensions/docs/static/cookies.html
   M /trunk/src/chrome/common/extensions/docs/static/devguide.html
   A /trunk/src/chrome/common/extensions/docs/static/experimental.cookies.html
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/tut_analytics.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tut_oauth.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/api/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/api/tab.html
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/events/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/events/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/cookies/no_permission/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/cookies/no_permission/manifest.json

Revert r52581. The change seems OK, but it had the wrong
description and bug association. Will re-land with correct
information.

TBR=thakis@chromium.org
------------------------------------------------------------------------
r52583 | tony@chromium.org | 2010-07-16 02:54:11 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm

Disable DispatchSimple because it crashes unit_tests.

Simply marking it as FAILS doesn't work for crashes.

BUG=49206
TBR=dmaclach,rsesek

Review URL: http://codereview.chromium.org/3043001
------------------------------------------------------------------------
r52582 | arv@chromium.org | 2010-07-16 02:53:02 +0200 (Fri, 16 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_language_hangul_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.js
   M /trunk/src/chrome/browser/resources/options/content_settings.js
   M /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options/preferences.js
   M /trunk/src/chrome/browser/resources/shared/js/cr.js
   M /trunk/src/chrome/browser/resources/shared/js/cr_test.html

Options: Clean up some repetitive code.

1. Added cr.addSingletonGetter (same as the Closure one)
2. Use that to define the singleton getters.
3. Remove the "model" param to the OptionsPage class since it wasn't used.
4. Use cr.defineProeprty in a few places.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2870053
------------------------------------------------------------------------
r52581 | aa@chromium.org | 2010-07-16 02:52:11 +0200 (Fri, 16 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_apitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/a11y.html
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/docs.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/common/extensions/docs/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/external_extensions.html
   M /trunk/src/chrome/common/extensions/docs/faq.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/idle.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/messaging.html
   M /trunk/src/chrome/common/extensions/docs/notifications.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/options.html
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   A /trunk/src/chrome/common/extensions/docs/static/cookies.html
   M /trunk/src/chrome/common/extensions/docs/static/devguide.html
   D /trunk/src/chrome/common/extensions/docs/static/experimental.cookies.html
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/tut_analytics.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tut_oauth.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/api/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/api/tab.html
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/events/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/events/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/no_permission
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/no_permission/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/no_permission/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/cookies/api/manifest.json:52580)

Use WebCore's built in support for user styles instead of the
hack we were doing before.

This has a side-effect of fixing a bunch of content-interaction
bugs because we will be using real user-level styles (in the
CSS sense) rather than content-level styles.

BUG=29995

Review URL: http://codereview.chromium.org/2932007
------------------------------------------------------------------------
r52578 | michaeln@chromium.org | 2010-07-16 02:15:55 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Add about:appcache-internals to about:about.

BUG=49208
TEST=manual

Review URL: http://codereview.chromium.org/2842050
------------------------------------------------------------------------
r52577 | arv@chromium.org | 2010-07-16 02:10:33 +0200 (Fri, 16 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/tree.js

Bookmarks: Persist expanded state of the tree items across sessions.

This fixes the bookmark manager. The state is stored using localStorage but we should probably store this in some other way so that it can be shared with Edit Bookmark dialog.

BUG=6648
TEST=Collapse a couple of tree items in the bookmark manager. The collapsed state should be persisted after reload and restart.

Review URL: http://codereview.chromium.org/3015002
------------------------------------------------------------------------
r52576 | arv@chromium.org | 2010-07-16 02:10:18 +0200 (Fri, 16 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/options_page.css

Options: Update CSS to not use floats and add some RTL aware properties.

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/2980010
------------------------------------------------------------------------
r52575 | jam@chromium.org | 2010-07-16 02:07:34 +0200 (Fri, 16 Jul 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h

Load Pepper v2 internal pdf plugin.
Review URL: http://codereview.chromium.org/2891016
------------------------------------------------------------------------
r52573 | chocobo@chromium.org | 2010-07-16 01:35:00 +0200 (Fri, 16 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   A /trunk/src/chrome/browser/chromeos/options/cellular_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/cellular_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Add auto-connect option in cellular config dialogs.
BUG=chromium-os:4312
TEST=none
Review URL: http://codereview.chromium.org/2805079
------------------------------------------------------------------------
r52559 | pkasting@chromium.org | 2010-07-16 00:54:30 +0200 (Fri, 16 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

Don't prompt to save for filetypes marked as auto-open.

Check if the generated file extension is in the auto-open list. If so, don't bother displaying the save as dialog even if the always prompt for download option is on.

Original patch by James Simonsen (see http://codereview.chromium.org/2910003 ), r=me.

BUG=18587
TEST=Turn on prompt for download option. Mark a filetype as always open. Download a file of that type and make sure no dialog appears.
Review URL: http://codereview.chromium.org/2823043
------------------------------------------------------------------------
r52554 | mpcomplete@chromium.org | 2010-07-16 00:27:26 +0200 (Fri, 16 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_icon_manager.h

Fix executable permissions on extension_icon_manager.*

TBR=asargent

Review URL: http://codereview.chromium.org/2884021
------------------------------------------------------------------------
r52549 | oshima@chromium.org | 2010-07-15 23:50:17 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disabling crashing browser test "ThirtyFourTabs" on mac

BUG=49193
TEST=none

Review URL: http://codereview.chromium.org/2812054
------------------------------------------------------------------------
r52544 | johnnyg@chromium.org | 2010-07-15 23:40:31 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc

Fix chromeos build after rename.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3037001
------------------------------------------------------------------------
r52540 | johnnyg@chromium.org | 2010-07-15 23:35:17 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.mm
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h

Implement BalloonView::Update on all platforms to navigate a notification balloon to the new content url; this is the last piece for replace-id support in notifications.

BUG=none
TEST=use replaceId feature for notifications

Review URL: http://codereview.chromium.org/2955009
------------------------------------------------------------------------
r52538 | dmaclach@chromium.org | 2010-07-15 23:19:17 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm

Marking DispatchSimple test as flaky.

BUG=http://code.google.com/p/chromium/issues/detail?id=49206
TEST=none

Review URL: http://codereview.chromium.org/3036001
------------------------------------------------------------------------
r52537 | lzheng@chromium.org | 2010-07-15 23:15:13 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/http/http_network_layer.cc

Increase npn_spdy to 50%, npn_http 25%. 
Disable alternate protocol for npn_http case so browser don't need to fallback to
http (extra overhead) in this case.
Keep default group at 25% so we could use it to compare performance against 
alternate protocol with spdy case.

BUG=48967
TEST=none
Review URL: http://codereview.chromium.org/2904012
------------------------------------------------------------------------
r52535 | mpcomplete@chromium.org | 2010-07-15 23:13:47 +0200 (Thu, 15 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.mm
   A /trunk/src/chrome/browser/extensions/extension_icon_manager.cc
   A /trunk/src/chrome/browser/extensions/extension_icon_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.cc
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Use the extension icon for extension omnibox results instead of the generic
search icon.

I refactored the extension menu manager to separate the icon-specific bits.

BUG=46479
TEST=load the chrome search extension at
src/chrome/common/extensions/docs/examples/extensions/chrome_search/
and type "src foo" into the omnibox. You should see the extension icon instead of the magnifying glass. Switch back and forth between the "src" keyword result, other results, and other keywords and the icons should update properly.

Review URL: http://codereview.chromium.org/2973006
------------------------------------------------------------------------
r52528 | erg@chromium.org | 2010-07-15 23:03:54 +0200 (Thu, 15 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/env_var.cc
   M /trunk/src/base/env_var.h
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   A /trunk/src/base/task.cc
   M /trunk/src/base/task.h
   M /trunk/src/base/tracked.cc
   M /trunk/src/base/tracked.h
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   A /trunk/src/base/weak_ptr.cc
   M /trunk/src/base/weak_ptr.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   A /trunk/src/chrome/browser/automation/automation_resource_routing_delegate.cc
   M /trunk/src/chrome/browser/automation/automation_resource_routing_delegate.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/command_updater.cc
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/pref_member.cc
   M /trunk/src/chrome/browser/pref_member.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h

Move implementation from header to source.

This is an effort to speed up compile and link time, and also minimizing the
size of the intermediary .o files on disk. For example, just moving the
constructor/destructor from the classes in chrome/browser/pref_member.{cc,h}
netted a 368k drop in total .o file size. In aggregate, this shrinks
libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files.

A lot of this was done before I started harvesting what the most included
symbols were across all of chrome's code. Most of them are in webkit, but
there's plenty in base/ that are used everywhere to keep me busy for several
patches to come.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3012001
------------------------------------------------------------------------
r52526 | johnnyg@chromium.org | 2010-07-15 23:02:01 +0200 (Thu, 15 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc

position the balloons after closing in a way that will keep the next one's close button under your mouse; don't reposition them to the normal place until the mouse has left the balloon collection

BUG=47333
TEST=make notifications of different sizes, try to close them all; the X should remain under your mouse
Review URL: http://codereview.chromium.org/2915003
------------------------------------------------------------------------
r52525 | csilv@chromium.org | 2010-07-15 23:01:40 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.h
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/resources/shared/js/cr.js

Advanced (Under the Hood) dom-ui progress.
- Complete implementation of SSL security options for all platforms.
- Implemented the 'Clear auto-opening settings' button.
- Correctly show logging checkbox for Chrome builds only.
- Mostly-complete support for the download path section.

BUG=48482
TEST=Exercise advanced panel in options window using --enable-tabbed-options.
Review URL: http://codereview.chromium.org/2893012
------------------------------------------------------------------------
r52524 | mark@chromium.org | 2010-07-15 22:46:36 +0200 (Thu, 15 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keystone_glue.h
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_installer_util.gypi

Make UpgradeDetector work on the Mac.

This is the backend work only. There's no UI yet.

BUG=45147
TEST=manual
Review URL: http://codereview.chromium.org/3032001
------------------------------------------------------------------------
r52523 | ananta@chromium.org | 2010-07-15 22:39:07 +0200 (Thu, 15 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/test/data/fulltab_before_unload_event_main.html
   M /trunk/src/chrome_frame/test/data/fulltab_before_unload_event_test.html
   M /trunk/src/chrome_frame/test/navigation_test.cc

ChromeFrame tabs would hang at times while closing. This would randomly occur if the page had an unload handler.
We execute unload handlers in the WM_DESTROY message in the external tab and spin a nested loop waiting for the
unload handlers to finish. This causes a deadlock at times if a windows message is dispatched to IE which is blocked
in DestroyWindow.

The fix is to remove the nested loop mess from the external tab and instead send over a special automation message
to Chrome in which context we execute the unload handlers. The message contains the notification window and the
actual window message to be posted back when the unload handlers finish executing. 

The active document/activex spin a GetMessage loop waiting for this message to arrive. To ensure that we don't wait
indefinitely we have a 1 second timer and exit the loop if this timer is received.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=49132

Bug=49132
Test=Covered by existing unload event test.

Review URL: http://codereview.chromium.org/3014001
------------------------------------------------------------------------
r52515 | jrg@chromium.org | 2010-07-15 22:06:44 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Give imported bookmarks the properly themed button text.
BUG=http://crbug.com/46734

TEST=new profile.  Open bookmark bar.
Install Maria Carey theme.
Add a bookmark --> text is white.
Import bookmarks --> text of new buttons is also white (not black).

Review URL: http://codereview.chromium.org/2958016
------------------------------------------------------------------------
r52514 | pinkerton@chromium.org | 2010-07-15 21:57:10 +0200 (Thu, 15 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix uninitialized memory error caused by r50606.
BUG=48269
TEST=none
------------------------------------------------------------------------
r52513 | erg@chromium.org | 2010-07-15 21:54:40 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/wrench_menu_model.cc

GTK/Mac: Switch the zoom buttons to the opposite order.

A views implementation will be needed since it doesn't follow the model.

BUG=48332
TEST=Minus is on the left, Plus is on the right.

Review URL: http://codereview.chromium.org/3013002
------------------------------------------------------------------------
r52508 | alyssad@chromium.org | 2010-07-15 21:00:07 +0200 (Thu, 15 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Adding a new PyAuto hook for importing settings.

BUG=43231

Review URL: http://codereview.chromium.org/2923010
------------------------------------------------------------------------
r52507 | estade@chromium.org | 2010-07-15 20:50:54 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc

[GTK] correct tabstrip drag point calculation.

Must account for discrepancy between widget->window coordinates and widget coordinates.

BUG=48774
TEST=see bug

Review URL: http://codereview.chromium.org/3003001
------------------------------------------------------------------------
r52505 | dmaclach@chromium.org | 2010-07-15 20:38:33 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/nibs/CollectedCookies.xib
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   D /trunk/src/chrome/browser/cocoa/collected_cookies_mac.h
   D /trunk/src/chrome/browser/cocoa/collected_cookies_mac.mm
   D /trunk/src/chrome/browser/cocoa/collected_cookies_mac_unittest.mm
   D /trunk/src/chrome/browser/collected_cookies_uitest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   D /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   D /trunk/src/chrome/browser/gtk/collected_cookies_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   D /trunk/src/chrome/browser/views/collected_cookies_win.cc
   D /trunk/src/chrome/browser/views/collected_cookies_win.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h

Revert 52486 - Display a tab modal dialog of the allowed/blocked cookies.

BUG=45230
TEST=CollectedCookiesTest.*

Review URL: http://codereview.chromium.org/2907003

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3016003
------------------------------------------------------------------------
r52503 | erg@chromium.org | 2010-07-15 20:01:13 +0200 (Thu, 15 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_notification_observers.cc

Chrome ARM build fix.

Review URL: http://codereview.chromium.org/2870052
------------------------------------------------------------------------
r52502 | tim@chromium.org | 2010-07-15 19:54:25 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc

Add support for the "clear pending" server / storage backend state.

BUG=46807
TEST=SyncerThreadWithSyncerTest, SyncSetupWizardTest, SyncerProtoUtilTest

Review URL: http://codereview.chromium.org/2976011
------------------------------------------------------------------------
r52501 | pkasting@chromium.org | 2010-07-15 19:53:05 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Fix missing throbber in sync dialogs.  This actually does a number of things:
* Correct throbber path in choose_datatypes.html (I overlooked this)
* Change CSS style settings for throbber to a form the inliner could understand, so the image got inlined properly
* Remove references to throbber path from sync_setup_wizard.cc (no longer needed)
* Fix improper use of url_constants.* (only paths that need to be in common/ should be there) and change sync hostname constant name to match other hostnames' naming scheme

BUG=40984
TEST=Signing into GAIA in sync setup dialog should show a throbber
Review URL: http://codereview.chromium.org/2840035
------------------------------------------------------------------------
r52499 | davidben@chromium.org | 2010-07-15 19:52:36 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.cc

Display the error code when certificates fail to add

We really want to make error strings, but this is a start.

BUG=43906
TEST=none

Review URL: http://codereview.chromium.org/2859026
------------------------------------------------------------------------
r52496 | erg@chromium.org | 2010-07-15 19:23:23 +0200 (Thu, 15 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/app/animation_container_unittest.cc
   M /trunk/src/app/clipboard/clipboard_unittest.cc
   M /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_proxy_impl_unittest.cc
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/idle.h
   M /trunk/src/chrome/browser/idle_win.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/common/process_watcher_win.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/service/cloud_print/job_status_updater.h
   M /trunk/src/chrome/service/service_process.h
   M /trunk/src/chrome_frame/urlmon_bind_status_callback.h
   M /trunk/src/ipc/ipc_channel_proxy.cc
   M /trunk/src/ipc/ipc_channel_win.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/media/base/filters.h
   M /trunk/src/media/base/pipeline_impl.h
   M /trunk/src/media/base/video_frame_unittest.cc
   M /trunk/src/media/filters/ffmpeg_glue_unittest.cc
   M /trunk/src/media/filters/video_renderer_base.h
   M /trunk/src/net/base/capturing_net_log.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/server/http_listen_socket.cc
   M /trunk/src/net/server/http_server_request_info.h
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/tools/fetch/http_server_request_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Attempt four at landing the "histogram.h removed from message_loop.h" patch.

Previously committed as r52349 and r52336. Related commits: r52367, r52364
and r52343.

Rerunning trybots due to previous trybot breakage.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2965015
------------------------------------------------------------------------
r52493 | phajdan.jr@chromium.org | 2010-07-15 19:09:01 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.cc
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.h
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate_unittest.cc
   A /trunk/src/chrome/browser/download/download_request_limiter.cc (from /trunk/src/chrome/browser/download/download_request_manager.cc:52401)
   A /trunk/src/chrome/browser/download/download_request_limiter.h (from /trunk/src/chrome/browser/download/download_request_manager.h:52401)
   A /trunk/src/chrome/browser/download/download_request_limiter_unittest.cc (from /trunk/src/chrome/browser/download/download_request_manager_unittest.cc:52401)
   D /trunk/src/chrome/browser/download/download_request_manager.cc
   D /trunk/src/chrome/browser/download/download_request_manager.h
   D /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Rename DownloadRequestManager to DownloadRequestLimiter.

We already have too many classes named Manager in the download code.

This also contains some minor cleanup changes like comment updates.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3011001
------------------------------------------------------------------------
r52488 | huanr@chromium.org | 2010-07-15 18:29:29 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Send large dump file for canary build. Also fix a similar
error in comments.

BUG=49085
TEST="about:crash" in canary build. The dump file should be
of large dump type.

Review URL: http://codereview.chromium.org/2946017
------------------------------------------------------------------------
r52487 | danno@chromium.org | 2010-07-15 18:04:49 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/policy/mac/app-Manifest.plist
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/plugin_updater.h
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/common/plugin_group.cc
   M /trunk/src/chrome/common/plugin_group.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Implement disabling of plugins through policy

TEST=manual testing of plugins page, ConfigurationPolicyPrefStoreTest*
BUG=45856

Review URL: http://codereview.chromium.org/2833034
------------------------------------------------------------------------
r52486 | jochen@chromium.org | 2010-07-15 17:54:19 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/nibs/CollectedCookies.xib
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/collected_cookies_mac.h
   A /trunk/src/chrome/browser/cocoa/collected_cookies_mac.mm
   A /trunk/src/chrome/browser/cocoa/collected_cookies_mac_unittest.mm
   A /trunk/src/chrome/browser/collected_cookies_uitest.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/collected_cookies_gtk.cc
   A /trunk/src/chrome/browser/gtk/collected_cookies_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   A /trunk/src/chrome/browser/views/collected_cookies_win.cc
   A /trunk/src/chrome/browser/views/collected_cookies_win.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h

Display a tab modal dialog of the allowed/blocked cookies.

BUG=45230
TEST=CollectedCookiesTest.*

Review URL: http://codereview.chromium.org/2907003
------------------------------------------------------------------------
r52485 | rsesek@chromium.org | 2010-07-15 17:44:20 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/menu_controller.h
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   A /trunk/src/chrome/browser/cocoa/wrench_menu_controller.h
   A /trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm
   A /trunk/src/chrome/browser/cocoa/wrench_menu_controller_unittest.mm
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Put buttons into the new unified Wrench menu.

This also makes changes to MenuController to support NIB-based initialization.
Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru).

BUG=47848
TEST=Click on Wrench menu and see buttons. Buttons perform their function.

Review URL: http://codereview.chromium.org/2923009
------------------------------------------------------------------------
r52477 | mnissler@chromium.org | 2010-07-15 13:16:25 +0200 (Thu, 15 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_member.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h

allow editing of hompage preferences on Windows, that are not locked by policies

Only disable those homepage-related gui controls, that are explicitly overridden by policies.

This is a different solution than the expected behavior  described in the bug below. The main point is that it avoids the ambiguous state, when the user has HomepageIsNewTabPage=true selected, and the policies only specify the HomepageLocation URL.

BUG=46486
TEST=manual

Review URL: http://codereview.chromium.org/2843022
Patch from Gabor Feher <gfeher@google.com>.
------------------------------------------------------------------------
r52476 | joth@chromium.org | 2010-07-15 12:55:38 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_chromeos.cc

Implement wifi geolocation for Chrome OS
Update network_library to use libcros to fetch wifi access point list, and update the geolocation code to use this for wifi scanning.
Depends on changes codereview.chromium.org/2927007 and codereview.chromium.org/2958008 (will be landed after them both)

BUG=45671
TEST=Open maps.google.com/maps/m on netbook with wifi enabled, it should go to your location with a few hundred

Review URL: http://codereview.chromium.org/2905008
------------------------------------------------------------------------
r52474 | yusukes@google.com | 2010-07-15 12:45:01 +0200 (Thu, 15 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Fix GetTextForIndicatorTest.

BUG=none
TEST=manually
TBR=tyoshino

Review URL: http://codereview.chromium.org/3010002
------------------------------------------------------------------------
r52470 | jochen@chromium.org | 2010-07-15 11:53:29 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc

Only store unique entries in the canned browsing data helpers.

BUG=45230
TEST=Canned*.Unique

Review URL: http://codereview.chromium.org/2854045
------------------------------------------------------------------------
r52468 | nkostylev@google.com | 2010-07-15 11:17:13 +0200 (Thu, 15 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/registration_screen.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

API to report on registration success/skip.
Not integrated into OOBE yet.

BUG= http://crosbug.com/3653
TEST=none

Review URL: http://codereview.chromium.org/2946008
------------------------------------------------------------------------
r52467 | mnissler@chromium.org | 2010-07-15 11:13:58 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.cc
   M /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.h

Show the managed prefs warning banner for some advanced options.

BUG=48470
TEST=Configure policy, check advanced page of preferences dialog.

Review URL: http://codereview.chromium.org/2908007
------------------------------------------------------------------------
r52466 | mnissler@chromium.org | 2010-07-15 10:50:01 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Restore disable-sync flag.

r52288 accidentally nuked the --disable-sync command line flag, make it work
again.

BUG=none
TEST=Starting with --disable-sync should actually disable sync

Review URL: http://codereview.chromium.org/2943016
------------------------------------------------------------------------
r52463 | mnissler@chromium.org | 2010-07-15 10:19:05 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Relayout content pref page properly upon sync status changes.

This fixes a layouting problem that resulted in the "Stop syncing this account"
button not being sized properly after setting up sync.

BUG=48807
TEST=Open options dialog in non-synced state, configure sync, check "Stop syncing this account" button after setup.

Review URL: http://codereview.chromium.org/2980005
------------------------------------------------------------------------
r52462 | yusukes@google.com | 2010-07-15 10:00:54 +0200 (Thu, 15 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Change the label for the language indicator for Chinese.

For Pinyin, use "拼".
For Chewing, use "酷".
For Cangjie, use "倉".

For now, we use "TW" for Quick since we're not sure which Hanzi is good for the input method.

BUG=chromium-os:4696
TEST=manually checked.

Review URL: http://codereview.chromium.org/2832054
------------------------------------------------------------------------
r52461 | akalin@chromium.org | 2010-07-15 09:59:56 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc

Fixed invalid read in ExtensionsServiceTest.ReloadExtensions.

BUG=47843,47863
TEST=unittests, valgrind

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51215

Review URL: http://codereview.chromium.org/2872024
------------------------------------------------------------------------
r52459 | tyoshino@chromium.org | 2010-07-15 09:44:39 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Marking DevToolsSanityTest.TestResourceContentLength flaky

BUG=44202
TEST=none

Review URL: http://codereview.chromium.org/2827049
------------------------------------------------------------------------
r52458 | ctguil@chromium.org | 2010-07-15 09:28:26 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Wait for the initial accessibility tree to load from the renderer.

BUG=48655
TEST=interactive_ui_tests.exe --gtest_filter=AccessibilityWinBrowserTest.*

Review URL: http://codereview.chromium.org/2955008
------------------------------------------------------------------------
r52457 | akalin@chromium.org | 2010-07-15 09:11:54 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc

Relaxed check in IsValidCacheInvalidationIqPacket().

BUG=48988
TEST=tested manually with a gmail account with a canonical name including capital letters

Review URL: http://codereview.chromium.org/2805080
------------------------------------------------------------------------
r52455 | levin@chromium.org | 2010-07-15 08:53:07 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add command line switch to guard the search provider api additions in progress.

BUG=38475
TEST=None (Nothing to test yet.)

Review URL: http://codereview.chromium.org/2873044
------------------------------------------------------------------------
r52451 | yusukes@google.com | 2010-07-15 08:00:35 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc

Use "CN" for simplified Chinese and "TW" for traditonal Chinese, rather than "ZH".

BUG=chromium-os:4696
TEST=checked manually

Review URL: http://codereview.chromium.org/2979008
------------------------------------------------------------------------
r52448 | jshin@chromium.org | 2010-07-15 07:37:01 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Make the localized product name 'ungarbled'. 

BUG=4456
TEST=Change the UI languge to Japanese and log out. At the lower-left corner
of the login screen, there's no more sequence of 'black question marks'. 
Review URL: http://codereview.chromium.org/2864033
------------------------------------------------------------------------
r52447 | akalin@chromium.org | 2010-07-15 07:31:27 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/chrome_async_socket.cc
   M /trunk/src/chrome/browser/sync/tools/chrome_async_socket_unittest.cc

Fixed some minor bugs with ChromeAsyncSocket.

BUG=45612
TEST=new unit tests

Review URL: http://codereview.chromium.org/2966011
------------------------------------------------------------------------
r52446 | hbono@chromium.org | 2010-07-15 07:24:32 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/win_util.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/chrome/browser/browser_init.cc

Supports High DPI mode.
When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later.

BUG=1715,36939
TEST=Run chrome.exe on the screen resolution higher than 120 DPI.
Review URL: http://codereview.chromium.org/2867031
------------------------------------------------------------------------
r52439 | shess@chromium.org | 2010-07-15 06:07:23 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm

[Mac] Center image in keyword-search and ev bubble in omnibox.

Omnibox recently got taller on Mac, which screwed up the centering.
Visually inspect and re-center.

BUG=49101
TEST=https://www.thawte.com/, lock should be centered vertically.

Review URL: http://codereview.chromium.org/2856037
------------------------------------------------------------------------
r52438 | shess@chromium.org | 2010-07-15 05:45:33 +0200 (Thu, 15 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

[Mac] Fix page-action positioning for flipped field.

My http://codereview.chromium.org/2998004 refactored calculation of
the page-action info-bubble position, but didn't fully factor in a
coordinate-system change.

BUG=none
TEST=Page-action info-bubble position at bottom, not top.

Review URL: http://codereview.chromium.org/2980014
------------------------------------------------------------------------
r52433 | oshima@chromium.org | 2010-07-15 05:40:23 +0200 (Thu, 15 Jul 2010) | 28 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/chromeos/network_state_notifier.cc
   M /trunk/src/chrome/browser/chromeos/network_state_notifier.h
   M /trunk/src/chrome/browser/chromeos/network_state_notifier_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/offline
   A /trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc
   A /trunk/src/chrome/browser/chromeos/offline/offline_load_page.h
   A /trunk/src/chrome/browser/chromeos/offline/offline_load_page_unittest.cc
   A /trunk/src/chrome/browser/chromeos/offline/offline_load_service.cc
   A /trunk/src/chrome/browser/chromeos/offline/offline_load_service.h
   A /trunk/src/chrome/browser/renderer_host/offline_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/offline_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_queue.cc
   A /trunk/src/chrome/browser/resources/offline_load.html
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Show offline interstitial page when offline and reload when reconnected to network.
* Added OfflineResourceHandler that intercept the request and show interstitial page.
* Added OfflineLoadPage that is shown when offline.
   This gets deleted when
    - User pressed "Load now" btton to proceed or
    - User pressed "Cancel" button to cancel loading
    - Network become available.
   The page first appears as blank page (a little darker than white for now. I'll update when mock is ready),
   and then options become available after 3 seconds maximum.
* Added unit test for OfflineLoadPage class.
* OfflineLoadService class to control when/if a load request
 should proceed regardless of network status.
 The current implementation is tentative and will proceed
 if if loading was requested in a given tab.
 I'll revisit this class to improve the logic in separate CL
 later.

Known Issue:
 - thumbnail is not working yet. I'll working on this in separate Cl.
 - a tab shows URL instead of title string. I'll fix this in separate CL.
 - InitNavigationParams in offline_load_page_unittest is copied from safe_browsing_blocking_page_unittest. I'll move this to common place in separate CL. (hopefully before checking this in)

BUG=chromium-os:3605
TEST=unit test: offline_load_page_unittest
     manual: disable wifi and ethernet, then login.
             chrome will show the offline page when tab is activated. Enable network (wifi or ethernet) and all tab will start loading again.

Review URL: http://codereview.chromium.org/2931005
------------------------------------------------------------------------
r52432 | shess@chromium.org | 2010-07-15 05:23:35 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Line up omnibox field icons and text with popup.

BUG=49123
TEST=Start autocompleting something, check that things line up.

Review URL: http://codereview.chromium.org/2968012
------------------------------------------------------------------------
r52424 | sky@chromium.org | 2010-07-15 04:18:32 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc

Changes the wrench menu to calculate the width needed for the zoom
label from the strings that can be displayed. The old approach
resulted in too small a width and clipping.

BUG=chromium-os:4406
TEST=see bug

Review URL: http://codereview.chromium.org/2993005
------------------------------------------------------------------------
r52422 | shess@chromium.org | 2010-07-15 04:11:12 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/image_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/image_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/image_decoration_unittest.mm (from /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration_unittest.mm:52418)
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.mm
   D /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration_unittest.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/star_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/star_decoration.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Star as a rhs-decoration in AutocompleteTextFieldCell.

Refactor to convert star decoration to LocationBarDecoration.

BUG=none
TEST=Star icon continues to work.
TEST=Bookmark bubble pops in the right place.

Review URL: http://codereview.chromium.org/2971004
------------------------------------------------------------------------
r52421 | albertb@chromium.org | 2010-07-15 04:05:58 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Check for NULL host_ or frontend_ in the sync_backend_host.

BUG=49120
TEST=manually tested

Review URL: http://codereview.chromium.org/2950009
------------------------------------------------------------------------
r52420 | mattm@chromium.org | 2010-07-15 04:05:14 +0200 (Thu, 15 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_backend.cc

Coverity: Fix leak in SessionBackend::OpenAndWriteHeader on error conditions.

CID=9159
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2924014
------------------------------------------------------------------------
r52416 | phajdan.jr@chromium.org | 2010-07-15 00:38:11 +0200 (Thu, 15 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h

Linux: fix broken build by forward-declaring GdkPixbuf.

TBR=estade

TEST=compile, please...
BUG=42892

Review URL: http://codereview.chromium.org/2917015
------------------------------------------------------------------------
r52415 | estade@chromium.org | 2010-07-15 00:28:08 +0200 (Thu, 15 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Widen a flakiness tag.

Flaky on linux/views as well as chromeos.

BUG=48920
TEST=tree stays marginally greener
TBR=dmazzoni

Review URL: http://codereview.chromium.org/3000003
------------------------------------------------------------------------
r52412 | phajdan.jr@chromium.org | 2010-07-15 00:13:31 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h

Linux: add icon and description preview to app shortcut dialog

TEST=none
BUG=42892

Review URL: http://codereview.chromium.org/2847050
------------------------------------------------------------------------
r52411 | davemoore@chromium.org | 2010-07-15 00:12:06 +0200 (Thu, 15 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_notification_observers.cc
   M /trunk/src/chrome/browser/chromeos/browser_notification_observers.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc

Add login time metric for chromeos.

TEST=Tested by gmerge chromeos-chrome onto device and checking
about histograms.

Review URL: http://codereview.chromium.org/2899014
------------------------------------------------------------------------
r52408 | pkasting@chromium.org | 2010-07-14 23:41:12 +0200 (Wed, 14 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/app/resources/input_unknown.png
   D /trunk/src/app/resources/linux_close_mask.png
   D /trunk/src/app/resources/linux_maximize_mask.png
   D /trunk/src/app/resources/linux_minimize_mask.png
   D /trunk/src/chrome/app/theme/chromium/button_menu.png
   D /trunk/src/chrome/app/theme/chromium/button_menu_drop_down.png
   D /trunk/src/chrome/app/theme/chromium/login_splash.png
   D /trunk/src/chrome/app/theme/find_next_Template.pdf
   D /trunk/src/chrome/app/theme/find_prev_Template.pdf
   D /trunk/src/chrome/app/theme/grow_box.png
   D /trunk/src/chrome/browser/resources/extensions_ui_page_logo.png
   D /trunk/src/chrome/browser/resources/ntp_themes_promo.png
   D /trunk/src/chrome/browser/sync/resources/close.png
   D /trunk/src/chrome/browser/sync/resources/merge_and_sync.png

Remove images on disk that are not referenced by anything.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2986006
------------------------------------------------------------------------
r52403 | mattm@chromium.org | 2010-07-14 23:16:09 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc

Coverity: missing break in SyncSetupFlow::OnDialogClosed switch.

This may have lead to some bad stats in Sync.UserPerceivedAuthorizationTime histogram.

CID=11400
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2976003
------------------------------------------------------------------------
r52402 | alyssad@chromium.org | 2010-07-14 23:14:19 +0200 (Wed, 14 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/browsing_data.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Clear Browsing Data hook added and some small tests. BUG=36176

Review URL: http://codereview.chromium.org/2909005
------------------------------------------------------------------------
r52400 | cpu@chromium.org | 2010-07-14 23:07:00 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc

Upping the diagnostic mode limits for file size
- The local state and the overall size of the profile dir

BUG=42561



Review URL: http://codereview.chromium.org/2934019
------------------------------------------------------------------------
r52399 | mattm@chromium.org | 2010-07-14 23:04:17 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Coverity: fix missing break in render_sandbox_host_linux: MSCharSetToFontconfig.

CID=10885
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2942009
------------------------------------------------------------------------
r52397 | thestig@chromium.org | 2010-07-14 22:58:47 +0200 (Wed, 14 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

Linux: Add several shell script extensions to the dangerous downloads list.

BUG=none
TEST=Drive by download for foo.bash gets a dangerous download prompt.
Review URL: http://codereview.chromium.org/2906008
------------------------------------------------------------------------
r52395 | skrul@chromium.org | 2010-07-14 22:54:28 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Fix race condition in test Pause method.
Acquire a lock on the syncer thread vault before setting listener expectations so it is not possilbe to get a notification while setting expectations.

BUG=39070

Review URL: http://codereview.chromium.org/2991003
------------------------------------------------------------------------
r52394 | andybons@chromium.org | 2010-07-14 22:54:23 +0200 (Wed, 14 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

[Mac] Finish implementation of App Tabs. This takes into account the UI consolidation of pinned and nano tabs tracked in issue 49013.

TEST=none
BUG=45539,49013
Review URL: http://codereview.chromium.org/2952004
------------------------------------------------------------------------
r52392 | michaeln@chromium.org | 2010-07-14 22:51:32 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_ui_test.cc

Include a new layout test, "progress-counter.html", in the ui_test harness.

TEST=yes
BUG=39370

Review URL: http://codereview.chromium.org/2975012
------------------------------------------------------------------------
r52389 | oshima@chromium.org | 2010-07-14 22:47:09 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Moved InitNavigationParams to test_render_view_host so that other test can use it.
  Added PageTransitionType to argument to make it more general but
  I can revert this if you think this should not be changed. let me know.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2945015
------------------------------------------------------------------------
r52388 | apatrick@chromium.org | 2010-07-14 22:47:04 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/app/app_switches.cc
   M /trunk/src/app/app_switches.h
   M /trunk/src/app/gfx/gl/gl_context.h
   M /trunk/src/app/gfx/gl/gl_context_egl.cc
   M /trunk/src/app/gfx/gl/gl_context_egl.h
   M /trunk/src/app/gfx/gl/gl_context_linux.cc
   M /trunk/src/app/gfx/gl/gl_context_mac.cc
   M /trunk/src/app/gfx/gl/gl_context_osmesa.cc
   M /trunk/src/app/gfx/gl/gl_context_osmesa.h
   M /trunk/src/app/gfx/gl/gl_context_win.cc
   A /trunk/src/app/gfx/gl/gl_implementation.cc
   M /trunk/src/app/gfx/gl/gl_implementation.h
   M /trunk/src/app/gfx/gl/gl_implementation_linux.cc
   M /trunk/src/app/gfx/gl/gl_implementation_mac.cc
   M /trunk/src/app/gfx/gl/gl_implementation_win.cc
   M /trunk/src/app/surface/accelerated_surface_mac.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/third_party/mesa/MesaLib/include/GL/osmesa.h
   M /trunk/src/third_party/mesa/README.chromium

Added --use-gl command line flag to select GL implementation.
- Options are desktop, egl and osmesa.
- Also added support for bliting an OSMesa bask buffer to a GDK window.

TEST=trybots, manual verification that WebGL and Pepper 3D work
BUG=45898

Review URL: http://codereview.chromium.org/2825005
------------------------------------------------------------------------
r52385 | shess@chromium.org | 2010-07-14 22:41:09 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration_unittest.mm
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Bring back the omnibox globe for an encore.

BUG=49077
TEST=Globe is back at LHS of omnibox.  Draggable, droppable, clickable.

Review URL: http://codereview.chromium.org/2958012
------------------------------------------------------------------------
r52384 | asargent@chromium.org | 2010-07-14 22:40:13 +0200 (Wed, 14 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.js
   M /trunk/src/chrome/test/data/extensions/context_menus/test.js

More cleanup of extensions context menu API.

This changes the contextMenus.create method to synchronously return an id
instead of aysynchronously in the callback. This meant moving the generating of
id's from a globally unique integer in C++ code to an extension-unique integer
in javascript. The C++ unique id thus becomes a pair of <extension_id,int>.

Also a couple of small drive-by cleanups while I was in some of the files.


BUG=48198
TEST=The context menu API should work normally, given the changes described 
above.


Review URL: http://codereview.chromium.org/2911007
------------------------------------------------------------------------
r52382 | sky@chromium.org | 2010-07-14 22:34:33 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Adds create application shortcuts to under the tools menu as per Ben
and Glen.

BUG=48018
TEST=see bug

Review URL: http://codereview.chromium.org/2910010
------------------------------------------------------------------------
r52381 | johnnyg@chromium.org | 2010-07-14 22:27:15 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h

Run the same extra notifications code when preferences are updated either through the model associator or the change processor.

BUG=42437
TEST=enable sync on a client, verify the server-side bookmark visibility preference is reflected in the UI without opening a new tab

Review URL: http://codereview.chromium.org/2906012
------------------------------------------------------------------------
r52378 | shess@chromium.org | 2010-07-14 22:12:55 +0200 (Wed, 14 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Simplify getting page-action info-bubble point.

LocationBarViewMac::GetPageActionBubblePoint() calculates the
info-bubble point directly, rather than exposing multiple entry points
so that extension code can calculate it.

Also convert -locationBarBridge from returning |LocationBar*| to
returning |LocationBarViewMac*|.  Various code was doing
static_cast<LocationBarViewMac*>() on the result, so it wasn't safe
anyhow.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2998004
------------------------------------------------------------------------
r52377 | tommi@chromium.org | 2010-07-14 22:04:39 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc

Removing string16 global construction and conversion.
Also changing these strings to ASCII as that's all that's needed.

BUG=48097
R=ananta,jhawkins

Review URL: http://codereview.chromium.org/2942008
------------------------------------------------------------------------
r52376 | arv@chromium.org | 2010-07-14 22:01:04 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/favicon_service.cc

Extensions: Resize favicons to 16x16.

This changes the ExtensionDOMUI favicon loading to use a ImageLoadingTracker which handles reading the file in the correct thread as well as resizing it.

BUG=47964
TEST=Install one of the extensions in the bug. Open the options page for the extension. The icon in the tab should be 16x16 pixels.

Review URL: http://codereview.chromium.org/2918007
------------------------------------------------------------------------
r52367 | erg@chromium.org | 2010-07-14 20:58:17 +0200 (Wed, 14 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/app/animation_container_unittest.cc
   M /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_proxy_impl_unittest.cc
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/idle.h
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/common/process_watcher_win.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/service/cloud_print/job_status_updater.h
   M /trunk/src/chrome/service/service_process.h
   M /trunk/src/ipc/ipc_channel_win.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/media/base/filters.h
   M /trunk/src/media/base/pipeline_impl.h
   M /trunk/src/media/base/video_frame_unittest.cc
   M /trunk/src/media/filters/ffmpeg_glue_unittest.cc
   M /trunk/src/media/filters/video_renderer_base.h
   M /trunk/src/net/base/capturing_net_log.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/server/http_listen_socket.cc
   M /trunk/src/net/server/http_server_request_info.h
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/tools/fetch/http_server_request_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Revert everything related to the relanding.

Review URL: http://codereview.chromium.org/2982009
------------------------------------------------------------------------
r52360 | jhawkins@chromium.org | 2010-07-14 20:25:52 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

AutoFill: Make IDs for profiles and credit cards unique among the two sets by
using one unique ID pool.

BUG=none
TEST=PersonalDataManagerTest.SetProfilesAndCreditCards

Review URL: http://codereview.chromium.org/2938009
------------------------------------------------------------------------
r52359 | jrg@chromium.org | 2010-07-14 20:25:27 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

When about to close bookmark bar folder window, stop hover timers.

BUG=http://crbug.com/46894
TEST=tree goes green (or would go green if not swamped by unrelated redness)

Review URL: http://codereview.chromium.org/2989005
------------------------------------------------------------------------
r52358 | mpcomplete@chromium.org | 2010-07-14 20:23:54 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/chrome_search/background.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/chrome_search/manifest.json
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Add chrome.experimental.omnibox.styleUrl for highlighting text as an URL.

Update the chrome code search sample extension to have some fancier
highlighting.

TEST=none

Review URL: http://codereview.chromium.org/2944012
------------------------------------------------------------------------
r52356 | rlp@chromium.org | 2010-07-14 20:21:44 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/gpu/gpu_thread.cc

Collecting gpu information when the gpu process creates a channel. Adding the gpu_info into the messages sent between gpu process and browser and sending over the browser. Will do something with it in the browser in another CR.

BUG=38736
TEST=none

Review URL: http://codereview.chromium.org/2857035
------------------------------------------------------------------------
r52350 | rdsmith@google.com | 2010-07-14 20:17:42 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_unittest.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc

Converted CanonicalCookies over to containing a domain.
Added perftest for getters in nested subdomains.

BUG=8850
TEST=[Linux] net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.*, net_perftests --gtest_filter=CookieMonsterTest.*

Review URL: http://codereview.chromium.org/2847046
------------------------------------------------------------------------
r52349 | erg@chromium.org | 2010-07-14 20:15:28 +0200 (Wed, 14 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/app/animation_container_unittest.cc
   M /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_proxy_impl_unittest.cc
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/idle.h
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/service/cloud_print/job_status_updater.h
   M /trunk/src/chrome/service/service_process.h
   M /trunk/src/ipc/ipc_channel_win.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/media/base/filters.h
   M /trunk/src/media/base/pipeline_impl.h
   M /trunk/src/media/base/video_frame_unittest.cc
   M /trunk/src/media/filters/ffmpeg_glue_unittest.cc
   M /trunk/src/media/filters/video_renderer_base.h
   M /trunk/src/net/base/capturing_net_log.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/server/http_listen_socket.cc
   M /trunk/src/net/server/http_server_request_info.h
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/tools/fetch/http_server_request_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Reland r52336.

(I accidentally committed a previous version of the patch (the fixed version
was in codereview since I had switched to my mac to address this exact compile
failure.)

BUG=none
TEST=none
TBR=evan

Review URL: http://codereview.chromium.org/2937010
------------------------------------------------------------------------
r52343 | erg@chromium.org | 2010-07-14 19:47:13 +0200 (Wed, 14 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/app/animation_container_unittest.cc
   M /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_proxy_impl_unittest.cc
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/idle.h
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/service/cloud_print/job_status_updater.h
   M /trunk/src/chrome/service/service_process.h
   M /trunk/src/ipc/ipc_channel_win.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/media/base/filters.h
   M /trunk/src/media/base/pipeline_impl.h
   M /trunk/src/media/base/video_frame_unittest.cc
   M /trunk/src/media/filters/ffmpeg_glue_unittest.cc
   M /trunk/src/media/filters/video_renderer_base.h
   M /trunk/src/net/base/capturing_net_log.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/server/http_listen_socket.cc
   M /trunk/src/net/server/http_server_request_info.h
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/tools/fetch/http_server_request_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h

Revert 52336 - More header cleanup:

- Some cleanup to url_request.h
- Remove task.h from headers that don't need it.
- Remove histogram.h from message_loop.h

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2986002

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2969006
------------------------------------------------------------------------
r52339 | phajdan.jr@chromium.org | 2010-07-14 19:32:15 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h

Clean up download code: extract some small helpers from RDH download code.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/2944014
------------------------------------------------------------------------
r52336 | erg@chromium.org | 2010-07-14 19:31:22 +0200 (Wed, 14 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/app/animation_container_unittest.cc
   M /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_proxy_impl_unittest.cc
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/idle.h
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/service/cloud_print/job_status_updater.h
   M /trunk/src/chrome/service/service_process.h
   M /trunk/src/ipc/ipc_channel_win.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/media/base/filters.h
   M /trunk/src/media/base/pipeline_impl.h
   M /trunk/src/media/base/video_frame_unittest.cc
   M /trunk/src/media/filters/ffmpeg_glue_unittest.cc
   M /trunk/src/media/filters/video_renderer_base.h
   M /trunk/src/net/base/capturing_net_log.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/server/http_listen_socket.cc
   M /trunk/src/net/server/http_server_request_info.h
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/tools/fetch/http_server_request_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h

More header cleanup:

- Some cleanup to url_request.h
- Remove task.h from headers that don't need it.
- Remove histogram.h from message_loop.h

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2986002
------------------------------------------------------------------------
r52335 | stuartmorgan@chromium.org | 2010-07-14 19:30:58 +0200 (Wed, 14 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   A /trunk/src/chrome/browser/resources/options/browser_options_page.css
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html

Implement default browser pref in DOMUI

Also disables all the not-yet-implemented controls so it's clear what works and what doesn't.

Fixes a earlier bad merge that introduced a duplicate include of the sync options.

BUG=48713
TEST=Running with --enable-tabbed-options, default browser display and button should work in prefs.

Review URL: http://codereview.chromium.org/2945017
------------------------------------------------------------------------
r52328 | kuan@chromium.org | 2010-07-14 18:13:04 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   A /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.cc
   A /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher.h
   A /trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
   A /trunk/src/chrome/browser/tab_closeable_state_watcher.cc
   A /trunk/src/chrome/browser/tab_closeable_state_watcher.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_controller.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/ui/ui_test.cc

chromeos: except when signing off, disallow closing of last NTP of last non-incognito normal browser, in which case, the window also cannot be closed.  if the last normal browser is closeable and user closes it or the last tab in it, if it's a incognito browser, a new non-incognito browser will be opened, else the browser stays opened with all tabs closed and a NTP opened.  before-unload-handlers are also taken care of.

BUG=chromium-os:2711,chromium-os:3479,chromium-os:2568
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/2069002
------------------------------------------------------------------------
r52327 | phajdan.jr@chromium.org | 2010-07-14 18:12:37 +0200 (Wed, 14 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h

Download code cleanup:

- convert some private static members to anonymous functions
- move some methods from public to private

This should make the interface of some download classes smaller,
and hopefully easier to understand.

BUG=48913
TEST=unit_tests, browser_tests, ui_tests

Review URL: http://codereview.chromium.org/2974007
------------------------------------------------------------------------
r52322 | jeremy@chromium.org | 2010-07-14 18:09:05 +0200 (Wed, 14 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Mac: Context Menu broken when tab dragged out to new window.

The cause of this bug was that in new windows created by dragging a tab out, the content view was ending up in front of the TabStripView and eating it's right-clicks.

The reason this was happening has to do with the order that the views were reconstitued in the new window in [TabWindowController moveViewsBetweenWindowAndOverlay].

This CL also fixes a few minor spelling issues seen in passing.

BUG=44023
TEST=Drag a tab out into a new Window, right click on the bottom half of the newly dragged out tab.  Context menu should open.  Previously such a click would do nothing.  See comment #10 on the bug for a screenshot of the area that used to be problematic.

Review URL: http://codereview.chromium.org/2918009
------------------------------------------------------------------------
r52320 | stuartmorgan@chromium.org | 2010-07-14 18:07:33 +0200 (Wed, 14 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   D /trunk/src/chrome/browser/resources/options/browser_options_page.css
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html

Revert 52318 - Implement default browser pref in DOMUI

Also disables all the not-yet-implemented controls so it's clear what works and what doesn't.

BUG=48713
TEST=Running with --enable-tabbed-options, default browser display and button should work in prefs.

Review URL: http://codereview.chromium.org/2927012

TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/2891025
------------------------------------------------------------------------
r52319 | joth@chromium.org | 2010-07-14 18:00:40 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

Fix bug 4556 - ensure the SystemInfo stays in scope for durection of UpdateNetworkStatus call

BUG=crosbug.com/4556
TEST=see crbug.com/45671

Review URL: http://codereview.chromium.org/2927007
------------------------------------------------------------------------
r52318 | stuartmorgan@chromium.org | 2010-07-14 17:58:59 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   A /trunk/src/chrome/browser/resources/options/browser_options_page.css
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html

Implement default browser pref in DOMUI

Also disables all the not-yet-implemented controls so it's clear what works and what doesn't.

BUG=48713
TEST=Running with --enable-tabbed-options, default browser display and button should work in prefs.

Review URL: http://codereview.chromium.org/2927012
------------------------------------------------------------------------
r52314 | rsesek@chromium.org | 2010-07-14 16:38:35 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/throbber_view.h
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Remove fields that are unused and reference classes that do not exist.

BUG=none
TEST=compile

Review URL: http://codereview.chromium.org/2906009
------------------------------------------------------------------------
r52313 | jorlow@chromium.org | 2010-07-14 16:29:40 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/indexed_db_key.cc
   A /trunk/src/chrome/common/indexed_db_key.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/serialized_script_value.cc
   A /trunk/src/chrome/common/serialized_script_value.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbindex_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h

The Chrome half of implementing get/put/remove for object stores (https://bugs.webkit.org/show_bug.cgi?id=41250).

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2830030
------------------------------------------------------------------------
r52311 | glotov@chromium.org | 2010-07-14 14:52:23 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/eula_view.cc
   A /trunk/src/chrome/browser/chromeos/login/eula_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi

EULA screen implemented.

BUG=crosbug.com/3178, crosbug.com/2884
TEST=out/Debug/browser_tests --gtest_filter=WizardControllerFlowTest.*

Review URL: http://codereview.chromium.org/2920001
------------------------------------------------------------------------
r52310 | pfeldman@chromium.org | 2010-07-14 14:17:16 +0200 (Wed, 14 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/net/base/load_flags_list.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

DevTools: provide network log details to the WebCore's InspectorController.

Review URL: http://codereview.chromium.org/2645006
------------------------------------------------------------------------
r52307 | bauerb@chromium.org | 2010-07-14 14:03:33 +0200 (Wed, 14 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_updater.cc
   M /trunk/src/chrome/browser/plugin_updater.h
   D /trunk/src/chrome/browser/plugin_updater_unittest.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/plugin_group.cc
   A /trunk/src/chrome/common/plugin_group.h (from /trunk/src/chrome/browser/plugin_updater.h:52306)
   A /trunk/src/chrome/common/plugin_group_unittest.cc (from /trunk/src/chrome/browser/plugin_updater_unittest.cc:52306)

Factor out PluginGroup into a separate class in common/.

Moving PluginGroup into common is necessary in order to enable the renderer process to check if a plugin is outdated.

Also, make PluginUpdater static since it doesn't contain any state anymore.

BUG=47731
TEST=PluginGroupTest.*

Review URL: http://codereview.chromium.org/2955005
------------------------------------------------------------------------
r52305 | pam@chromium.org | 2010-07-14 13:42:35 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc

Add methods for determining which PrefStore contains a given preference, and for which store is currently controlling it.

BUG=48952
TEST=covered by unit tests


Review URL: http://codereview.chromium.org/2989002
------------------------------------------------------------------------
r52296 | jochen@chromium.org | 2010-07-14 11:46:39 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc

The "ask" setting is still required for geolocation and notifications.

BUG=48941
TEST=OptionsUITest.LoadOptionsByURL
TBR=nkostylev

Review URL: http://codereview.chromium.org/2910011
------------------------------------------------------------------------
r52291 | jochen@chromium.org | 2010-07-14 10:15:48 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.h
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc

Remove the cookie prompt from the settings UI and migrate prefs from ask to block.

BUG=48941
TEST=none

Review URL: http://codereview.chromium.org/2963006
------------------------------------------------------------------------
r52290 | satorux@chromium.org | 2010-07-14 10:09:46 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

First cut at adding Chromium OS's "Languages and Input" options sub page.

This is more like a boilerplate place holder.
Will add the contents in a separate change.

BUG=chromiumo-os:4573
TEST=manually

Review URL: http://codereview.chromium.org/2958003
------------------------------------------------------------------------
r52289 | akalin@chromium.org | 2010-07-14 10:00:35 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/tools/chrome_async_socket.cc
   A /trunk/src/chrome/browser/sync/tools/chrome_async_socket.h
   A /trunk/src/chrome/browser/sync/tools/chrome_async_socket_unittest.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

Added implementation of buzz::AsyncSocket that uses Chrome sockets.

BUG=45612
TEST=new unit tests

Review URL: http://codereview.chromium.org/2863030
------------------------------------------------------------------------
r52288 | mnissler@chromium.org | 2010-07-14 09:45:59 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_observer.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Implement support for disabling sync through configuration management.

BUG=45316
TEST=Configure SyncDisabled policy and check the UI.

Review URL: http://codereview.chromium.org/2905003
------------------------------------------------------------------------
r52287 | suzhe@chromium.org | 2010-07-14 09:35:30 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

[chromeos]Allow input method can get tab key when inputting in omnibox.

BUG=http://crosbug.com/4552
TEST=See the bug report.

Review URL: http://codereview.chromium.org/2925009
------------------------------------------------------------------------
r52283 | sanjeevr@chromium.org | 2010-07-14 07:08:46 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/render_messages_internal.h

Moved sending the PluginProcessMsg_AskForShutdown message to the CreateChannel method. This ensures that it gets sent before all other messages.
Also moved the font precaching code to a common place because it is needed in multiple places.
BUG=None
TEST=Test for regressions with launching the utility process.

Review URL: http://codereview.chromium.org/2906007
------------------------------------------------------------------------
r52281 | satorux@chromium.org | 2010-07-14 06:23:41 +0200 (Wed, 14 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.js

Fix runtime JavaScript errors in chrome://options.

With chrome built with CHROMEOS=1, the following error occurs
in in chrome://options as sync-button and dummy-button don't exist.
Remove the binding code to fix the error.

[28843:28843:611993994873:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot set property 'onclick' of null," source: chrome://options/system (528)

TEST=manually on ubuntu by "out/Release/chrome --test-type"
BUG=none

Review URL: http://codereview.chromium.org/2900008
------------------------------------------------------------------------
r52279 | mazda@chromium.org | 2010-07-14 05:57:47 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/language_hangul_options_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_language_hangul_options.html
   A /trunk/src/chrome/browser/resources/options/chromeos_language_hangul_options.js
   M /trunk/src/chrome/browser/resources/options/pref_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Add a DOM UI version of ibus-hangul configuration dialog.

This dialog cannot be opend from UI yet.
The execution path will be added once "Languages and Input" dialog is ready.

TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4806

Review URL: http://codereview.chromium.org/2853032
------------------------------------------------------------------------
r52275 | vandebo@chromium.org | 2010-07-14 05:37:18 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/net/base/load_flags_list.h
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket.cc
   M /trunk/src/net/http/http_proxy_client_socket.h
   M /trunk/src/net/http/http_proxy_client_socket_pool.h
   M /trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/client_socket_factory.cc
   M /trunk/src/net/socket/client_socket_factory.h
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks_client_socket_pool.h
   M /trunk/src/net/socket/ssl_client_socket.h
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.h
   M /trunk/src/net/socket/ssl_client_socket_mac_factory.cc
   M /trunk/src/net/socket/ssl_client_socket_mac_factory.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   M /trunk/src/net/socket/ssl_client_socket_nss_factory.cc
   M /trunk/src/net/socket/ssl_client_socket_nss_factory.h
   A /trunk/src/net/socket/ssl_client_socket_pool.cc
   A /trunk/src/net/socket/ssl_client_socket_pool.h
   A /trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_client_socket_win.h
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc

Implement SSLClientSocketPool.

To support SSLClientSocketPool, ClientSocketPoolBase and ClientSocketHandle require a notion of additional error state reported from the pool.  Overtime the error handling may get become more integrated, alleviating the need for some of the additional error state.
To support getting Http Proxy credentials from the user, the SSLClientSocketPool will release unauthenticated HttpProxyClientSocket's into the pool as idle.  However, it checks their authentication status when receiving one, completing the authentication once the user has provided the credentials.

BUG=30357
TEST=existing unit tests, ClientSocketPoolBaseTest.AdditionalErrorState*, SSLClientSocketPoolTest.*

Review URL: http://codereview.chromium.org/2870030
------------------------------------------------------------------------
r52274 | sky@chromium.org | 2010-07-14 05:27:11 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/auto_fill_editor_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

Makes the auto fill dialogs match the mocks.

BUG=44620 46634
TEST=Make sure the auto fill dialogs work correctly.

Review URL: http://codereview.chromium.org/2975003
------------------------------------------------------------------------
r52272 | tfarina@chromium.org | 2010-07-14 04:47:40 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/base/mime_util_xdg.cc
   M /trunk/src/base/nss_util.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_linux.cc

Use file_util::GetHomeDir instead of getenv("HOME").

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2919005
------------------------------------------------------------------------
r52271 | estade@chromium.org | 2010-07-14 04:32:31 +0200 (Wed, 14 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: reduce cpu usage of upgrade notification animation.

First, don't queue excessive draws when the animation isn't changing. This should reduce cpu usage by about 75%.
Second, don't animate the little dot when the browser window isn't active. For WMs that support _NET_ACTIVE_WINDOW, this should keep CPU usage steady no matter how many browser windows are open.

The net effect of this patch is to reduce CPU usage from 100% in certain cases (when many windows are open) to a negligible amount (on metacity on my workstation).

BUG=48909
TEST=open many windows and inspect CPU usage according to top

Review URL: http://codereview.chromium.org/2985006
------------------------------------------------------------------------
r52270 | michaeln@chromium.org | 2010-07-14 04:31:55 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job.cc
   M /trunk/src/webkit/appcache/appcache_update_job.h
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

New javascript console logging related to the appcache.
* Log an error message when an update job results in an error.
* Log info messages for progress events and other update status changed events.
* Consistently use "Application Cache" in the console messages.

TEST=existing unit tests apply for functional correctness, manual testing to see the new console output
BUG=none

Review URL: http://codereview.chromium.org/2910007
------------------------------------------------------------------------
r52269 | nick@chromium.org | 2010-07-14 04:25:59 +0200 (Wed, 14 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc

Don't set the URL on folders, even to an empty string.

This suppresses a harmless LOG(ERROR) on SPECIFICS / SERVER_SPECIFICS not
matching.  That's because the server doesn't return preserve a URL field on
folder entities, so if we set it locally (even to the empty string), it won't be
returned in the result message.

BUG=45610
TEST=create a folder, rename it, verify no 'LOG(WARNING) << "Specifics mismatch"' from syncer_util.cc

Review URL: http://codereview.chromium.org/2904013
------------------------------------------------------------------------
r52268 | chron@chromium.org | 2010-07-14 04:24:51 +0200 (Wed, 14 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Microfix to cause ChromeOS to always try to renew credentials.
BUG=43462
TEST=Login to ChromeOS, log out, log in again, sync should still work. Get into GAIA credential failure state, out and in again and it should still work.

Review URL: http://codereview.chromium.org/2978004
------------------------------------------------------------------------
r52267 | feldstein@chromium.org | 2010-07-14 04:05:29 +0200 (Wed, 14 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Fix selection of download URLs

In progress downloads would clear the selection of the url every time the
progress updates, making it impossible to copy a url.

BUG=44982
TEST=Download a large file, and select it's URL as it is downloading.  It should
stay selected.

Review URL: http://codereview.chromium.org/2966008
------------------------------------------------------------------------
r52265 | tfarina@chromium.org | 2010-07-14 03:55:03 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   D /trunk/src/chrome/browser/sync/util/path_helpers.h

sync: Remove unused path_helpers.h file.

BUG=26443
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2895007
------------------------------------------------------------------------
r52262 | johnnyg@chromium.org | 2010-07-14 03:32:56 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Button label logic on mac should match other platforms and show "stop syncing" whenever sync setup is done, regardless of error state.

BUG=48973
TEST=invalidate login creds on mac, check options panel

Review URL: http://codereview.chromium.org/2918005
------------------------------------------------------------------------
r52259 | tim@chromium.org | 2010-07-14 03:31:36 +0200 (Wed, 14 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.h
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h

Handle birthday errors by disabling sync and deleting sync data. Also added some CV broadcasts in SyncerThread, as changing vault_ fields and not signalling seems dubious (and I caught a hang in the debugger where the thread was waiting for an already true condition, thus deadlocked).

BUG=46807,39070

Review URL: http://codereview.chromium.org/2923006
------------------------------------------------------------------------
r52258 | johnnyg@chromium.org | 2010-07-14 03:31:08 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Privacy dashboard link for Mac.  Only shown when --show-privacy-dashboard-link switch present.

XIB changes: added a new link to the sync group of the preferences dialog (required adding a continuation array).  Slightly altered the spacing to fit.

BUG=48844
TEST=mac preferences pane with the above switch

Review URL: http://codereview.chromium.org/2891021
------------------------------------------------------------------------
r52257 | johnnyg@chromium.org | 2010-07-14 03:31:05 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc

Always pass along the GAIA failure event, regardless of the local authentication condition.  This is necessary since the UI is waiting for the event, and has no effect on the other listeners.

BUG=19720
TEST=let server creds expire, then login with bad password; should get an error message not a hung UI

Review URL: http://codereview.chromium.org/2988002
------------------------------------------------------------------------
r52255 | johnnyg@chromium.org | 2010-07-14 03:29:54 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h

Privacy dashboard link on linux.

BUG=48844
TEST=run with --show-privacy-dashboard-link

Review URL: http://codereview.chromium.org/2943010
------------------------------------------------------------------------
r52254 | johnnyg@chromium.org | 2010-07-14 03:29:40 +0200 (Wed, 14 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Add the new notifications content setting preference to the list of synchronized preferences.

BUG=48697
TEST=change notifications content settings with preference sync enabled

Review URL: http://codereview.chromium.org/2891012
------------------------------------------------------------------------
r52252 | jerrica@google.com | 2010-07-14 03:29:05 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h

Created method to save histogram data for future
syncing of sessions.

Created a method to track certain session modifications
in order to determine what we want to track when
syncing sessions
BUG=30519
TEST=NONE
Review URL: http://codereview.chromium.org/2930002
------------------------------------------------------------------------
r52251 | estade@chromium.org | 2010-07-14 03:24:58 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   M /trunk/src/chrome/browser/resources/options/advanced_options.js
   M /trunk/src/chrome/browser/resources/options/content_settings.html
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options.html

Add the rest of the content settings tabs.

Also, convert it to a subpage.
Also, make subpage nav items hidden when not in use.

BUG=48863
TEST=manual

Review URL: http://codereview.chromium.org/2901008
------------------------------------------------------------------------
r52250 | chron@chromium.org | 2010-07-14 03:24:45 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   A /trunk/src/chrome/browser/net/gaia
   A /trunk/src/chrome/browser/net/gaia/token_service.cc
   A /trunk/src/chrome/browser/net/gaia/token_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Add the TokenService to the chrome profile, and use it to pass the LSID from ChromiumOS login into Sync.

This is just initial groundlaying for replacing the internal sync auth stack. IssueAuthToken is not yet used in this CL.

TEST=Run chromium OS. Login using your credentials. Verify that sync works in about:sync.
BUG=47093

Review URL: http://codereview.chromium.org/2872034
------------------------------------------------------------------------
r52247 | oshima@chromium.org | 2010-07-14 03:03:33 +0200 (Wed, 14 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Disable SyncerThreadTest.Pause on Windows because it's crashing.

BUG=39070
BUG=skrul@chromium.org
TEST=none

Review URL: http://codereview.chromium.org/2981009
------------------------------------------------------------------------
r52239 | pkasting@chromium.org | 2010-07-14 00:57:54 +0200 (Wed, 14 Jul 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/app/theme/checkbox_black.png
   D /trunk/src/chrome/app/theme/checkbox_white.png
   D /trunk/src/chrome/app/theme/closed_window.png
   D /trunk/src/chrome/app/theme/downloads_section.png
   D /trunk/src/chrome/app/theme/filebrowse_back.png
   D /trunk/src/chrome/app/theme/filebrowse_fullscreen.png
   D /trunk/src/chrome/app/theme/filebrowse_menu.png
   D /trunk/src/chrome/app/theme/history_section.png
   D /trunk/src/chrome/app/theme/icon_file.png
   D /trunk/src/chrome/app/theme/icon_folder.png
   D /trunk/src/chrome/app/theme/icon_media.png
   D /trunk/src/chrome/app/theme/icon_photo.png
   D /trunk/src/chrome/app/theme/mediaplayer_full_screen.png
   D /trunk/src/chrome/app/theme/mediaplayer_next.png
   D /trunk/src/chrome/app/theme/mediaplayer_pause.png
   D /trunk/src/chrome/app/theme/mediaplayer_play.png
   D /trunk/src/chrome/app/theme/mediaplayer_playlist.png
   D /trunk/src/chrome/app/theme/mediaplayer_prev.png
   D /trunk/src/chrome/app/theme/mediaplayer_vol_high.png
   D /trunk/src/chrome/app/theme/mediaplayer_vol_mute.png
   D /trunk/src/chrome/app/theme/ntp_close.png
   D /trunk/src/chrome/app/theme/ntp_close_h.png
   D /trunk/src/chrome/app/theme/ntp_close_p.png
   D /trunk/src/chrome/app/theme/ntp_pin_off.png
   D /trunk/src/chrome/app/theme/ntp_pin_off_h.png
   D /trunk/src/chrome/app/theme/ntp_pin_off_p.png
   D /trunk/src/chrome/app/theme/ntp_pin_on.png
   D /trunk/src/chrome/app/theme/ntp_pin_on_h.png
   D /trunk/src/chrome/app/theme/ntp_pin_on_p.png
   D /trunk/src/chrome/app/theme/otr_icon_standalone.png
   D /trunk/src/chrome/app/theme/star_small.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/about_memory.html
   M /trunk/src/chrome/browser/resources/about_memory_linux.html
   M /trunk/src/chrome/browser/resources/about_memory_mac.html
   M /trunk/src/chrome/browser/resources/about_sys.html
   D /trunk/src/chrome/browser/resources/app_gallery_icon.png
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/filebrowse.html
   D /trunk/src/chrome/browser/resources/gear.png
   D /trunk/src/chrome/browser/resources/gray.png
   D /trunk/src/chrome/browser/resources/help.gif
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/history2.html
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   D /trunk/src/chrome/browser/resources/media_common.js
   M /trunk/src/chrome/browser/resources/mediaplayer.html
   D /trunk/src/chrome/browser/resources/minus.png
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   A /trunk/src/chrome/browser/resources/ntp/checkbox_black.png (from /trunk/src/chrome/app/theme/checkbox_black.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/checkbox_white.png (from /trunk/src/chrome/app/theme/checkbox_white.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/closed_window.png (from /trunk/src/chrome/app/theme/closed_window.png:52142)
   M /trunk/src/chrome/browser/resources/ntp/most_visited.css
   A /trunk/src/chrome/browser/resources/ntp/ntp_close.png (from /trunk/src/chrome/app/theme/ntp_close.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_close_h.png (from /trunk/src/chrome/app/theme/ntp_close_h.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_close_p.png (from /trunk/src/chrome/app/theme/ntp_close_p.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_pin_off.png (from /trunk/src/chrome/app/theme/ntp_pin_off.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_pin_off_h.png (from /trunk/src/chrome/app/theme/ntp_pin_off_h.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_pin_off_p.png (from /trunk/src/chrome/app/theme/ntp_pin_off_p.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_pin_on.png (from /trunk/src/chrome/app/theme/ntp_pin_on.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_pin_on_h.png (from /trunk/src/chrome/app/theme/ntp_pin_on_h.png:52142)
   A /trunk/src/chrome/browser/resources/ntp/ntp_pin_on_p.png (from /trunk/src/chrome/app/theme/ntp_pin_on_p.png:52142)
   D /trunk/src/chrome/browser/resources/phishing_icon.png
   M /trunk/src/chrome/browser/resources/plugins.html
   D /trunk/src/chrome/browser/resources/plus.png
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   A /trunk/src/chrome/browser/resources/shared/images
   A /trunk/src/chrome/browser/resources/shared/images/downloads_section.png (from /trunk/src/chrome/app/theme/downloads_section.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/filebrowse_back.png (from /trunk/src/chrome/app/theme/filebrowse_back.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/filebrowse_fullscreen.png (from /trunk/src/chrome/app/theme/filebrowse_fullscreen.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/filebrowse_menu.png (from /trunk/src/chrome/app/theme/filebrowse_menu.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/gear.png (from /trunk/src/chrome/browser/resources/gear.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/help.gif (from /trunk/src/chrome/browser/resources/help.gif:52142)
   A /trunk/src/chrome/browser/resources/shared/images/history_section.png (from /trunk/src/chrome/app/theme/history_section.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/icon_file.png (from /trunk/src/chrome/app/theme/icon_file.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/icon_folder.png (from /trunk/src/chrome/app/theme/icon_folder.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/icon_media.png (from /trunk/src/chrome/app/theme/icon_media.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/icon_photo.png (from /trunk/src/chrome/app/theme/icon_photo.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_full_screen.png (from /trunk/src/chrome/app/theme/mediaplayer_full_screen.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_next.png (from /trunk/src/chrome/app/theme/mediaplayer_next.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_pause.png (from /trunk/src/chrome/app/theme/mediaplayer_pause.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_play.png (from /trunk/src/chrome/app/theme/mediaplayer_play.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_playlist.png (from /trunk/src/chrome/app/theme/mediaplayer_playlist.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_prev.png (from /trunk/src/chrome/app/theme/mediaplayer_prev.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_vol_high.png (from /trunk/src/chrome/app/theme/mediaplayer_vol_high.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/mediaplayer_vol_mute.png (from /trunk/src/chrome/app/theme/mediaplayer_vol_mute.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/minus.png (from /trunk/src/chrome/browser/resources/minus.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/otr_icon_standalone.png (from /trunk/src/chrome/app/theme/otr_icon_standalone.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/phishing_icon.png (from /trunk/src/chrome/browser/resources/phishing_icon.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/plus.png (from /trunk/src/chrome/browser/resources/plus.png:52142)
   A /trunk/src/chrome/browser/resources/shared/images/star_small.png (from /trunk/src/chrome/app/theme/star_small.png:52142)
   A /trunk/src/chrome/browser/resources/shared/js/media_common.js (from /trunk/src/chrome/browser/resources/media_common.js:52142)
   M /trunk/src/chrome/browser/resources/slideshow.html
   M /trunk/src/chrome/browser/sync/resources/about_sync.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   D /trunk/src/chrome/browser/sync/resources/gear.png
   M /trunk/src/chrome/renderer/resources/neterror.html

Clean up browser_resources.grd:
* Flatten HTML where possible
* Move resources only referenced by files in browser/resources/ into there (and out of the theme dir)
* Remove duplicate/unreferenced resources
* Remove IDs for resources that are inlined due to flattening
* Remove IDR_CHAT_MANAGER_MANIFEST but leave the files on disk (they will be moving elsewhere some time soon)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2897015
------------------------------------------------------------------------
r52238 | pkasting@chromium.org | 2010-07-14 00:57:27 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/infobarbutton_b_h.png
   D /trunk/src/app/resources/infobarbutton_b_n.png
   D /trunk/src/app/resources/infobarbutton_b_p.png
   D /trunk/src/app/resources/infobarbutton_bl_h.png
   D /trunk/src/app/resources/infobarbutton_bl_n.png
   D /trunk/src/app/resources/infobarbutton_bl_p.png
   D /trunk/src/app/resources/infobarbutton_br_h.png
   D /trunk/src/app/resources/infobarbutton_br_n.png
   D /trunk/src/app/resources/infobarbutton_br_p.png
   D /trunk/src/app/resources/infobarbutton_c_h.png
   D /trunk/src/app/resources/infobarbutton_c_n.png
   D /trunk/src/app/resources/infobarbutton_c_p.png
   D /trunk/src/app/resources/infobarbutton_l_h.png
   D /trunk/src/app/resources/infobarbutton_l_n.png
   D /trunk/src/app/resources/infobarbutton_l_p.png
   D /trunk/src/app/resources/infobarbutton_menu_droparrow.png
   D /trunk/src/app/resources/infobarbutton_r_h.png
   D /trunk/src/app/resources/infobarbutton_r_n.png
   D /trunk/src/app/resources/infobarbutton_r_p.png
   D /trunk/src/app/resources/infobarbutton_t_h.png
   D /trunk/src/app/resources/infobarbutton_t_n.png
   D /trunk/src/app/resources/infobarbutton_t_p.png
   D /trunk/src/app/resources/infobarbutton_tl_h.png
   D /trunk/src/app/resources/infobarbutton_tl_n.png
   D /trunk/src/app/resources/infobarbutton_tl_p.png
   D /trunk/src/app/resources/infobarbutton_tr_h.png
   D /trunk/src/app/resources/infobarbutton_tr_n.png
   D /trunk/src/app/resources/infobarbutton_tr_p.png
   D /trunk/src/app/resources/input_alert.png
   A /trunk/src/chrome/app/theme/infobarbutton_b_h.png (from /trunk/src/app/resources/infobarbutton_b_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_b_n.png (from /trunk/src/app/resources/infobarbutton_b_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_b_p.png (from /trunk/src/app/resources/infobarbutton_b_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_bl_h.png (from /trunk/src/app/resources/infobarbutton_bl_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_bl_n.png (from /trunk/src/app/resources/infobarbutton_bl_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_bl_p.png (from /trunk/src/app/resources/infobarbutton_bl_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_br_h.png (from /trunk/src/app/resources/infobarbutton_br_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_br_n.png (from /trunk/src/app/resources/infobarbutton_br_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_br_p.png (from /trunk/src/app/resources/infobarbutton_br_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_c_h.png (from /trunk/src/app/resources/infobarbutton_c_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_c_n.png (from /trunk/src/app/resources/infobarbutton_c_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_c_p.png (from /trunk/src/app/resources/infobarbutton_c_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_l_h.png (from /trunk/src/app/resources/infobarbutton_l_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_l_n.png (from /trunk/src/app/resources/infobarbutton_l_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_l_p.png (from /trunk/src/app/resources/infobarbutton_l_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_menu_droparrow.png (from /trunk/src/app/resources/infobarbutton_menu_droparrow.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_r_h.png (from /trunk/src/app/resources/infobarbutton_r_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_r_n.png (from /trunk/src/app/resources/infobarbutton_r_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_r_p.png (from /trunk/src/app/resources/infobarbutton_r_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_t_h.png (from /trunk/src/app/resources/infobarbutton_t_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_t_n.png (from /trunk/src/app/resources/infobarbutton_t_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_t_p.png (from /trunk/src/app/resources/infobarbutton_t_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_tl_h.png (from /trunk/src/app/resources/infobarbutton_tl_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_tl_n.png (from /trunk/src/app/resources/infobarbutton_tl_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_tl_p.png (from /trunk/src/app/resources/infobarbutton_tl_p.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_tr_h.png (from /trunk/src/app/resources/infobarbutton_tr_h.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_tr_n.png (from /trunk/src/app/resources/infobarbutton_tr_n.png:52198)
   A /trunk/src/chrome/app/theme/infobarbutton_tr_p.png (from /trunk/src/app/resources/infobarbutton_tr_p.png:52198)
   A /trunk/src/chrome/app/theme/input_alert.png (from /trunk/src/app/resources/input_alert.png:52198)
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_button_border.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/chrome.gyp

Clean up app_resources.grd:
* Alphabetize a couple entries
* Move things to theme_resources.grd where possible; also fixes problems in chrome.gyp and theme_resources.grd that were causing "toolkit_views" to not be properly handled here, so this won't cause problems
* Scope things only used by views under an appropriate conditional

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2987003
------------------------------------------------------------------------
r52237 | seanparent@google.com | 2010-07-14 00:55:55 +0200 (Wed, 14 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/.gitignore
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/notification_update.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_update_library.h
   A /trunk/src/chrome/browser/chromeos/cros/update_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/update_library.h
   A /trunk/src/chrome/browser/chromeos/update_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/update_observer.cc
   A /trunk/src/chrome/browser/chromeos/update_observer.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Added system notification for update_engine.
BUG=chromium-os:1178 1610 2033
TEST=UpdateBrowserTest.Notifications

Review URL: http://codereview.chromium.org/2859043
------------------------------------------------------------------------
r52233 | jhawkins@chromium.org | 2010-07-14 00:19:48 +0200 (Wed, 14 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

TTF: Re-enable FindInPageControllerTest.FindInPagePrematureEnd by marking it as
FAILS_.

TBR=estade
BUG=11761
TEST=FindInPageControllerTest.FindInPagePrematureEnd

Review URL: http://codereview.chromium.org/2950007
------------------------------------------------------------------------
r52232 | shess@chromium.org | 2010-07-14 00:10:35 +0200 (Wed, 14 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm

[Mac] Fix build break with r52223.

image and pboard were always initialized, but warning that they
couldn't only happened on opt build, which I didn't, mea culpa...

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2951012
------------------------------------------------------------------------
r52228 | cpu@chromium.org | 2010-07-13 23:57:18 +0200 (Tue, 13 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Allow the default search providers to be specified by the preferences files,
overriding the built-in set.
- Per locale providers not allowed.

BUG=47440
TEST=unittest included, for manual testing see bug.


Review URL: http://codereview.chromium.org/2974001
------------------------------------------------------------------------
r52227 | pkasting@chromium.org | 2010-07-13 23:52:22 +0200 (Tue, 13 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc

Fix browser test broken by resource ID ordering change.

BUG=48912
TEST=none
Review URL: http://codereview.chromium.org/2955010
------------------------------------------------------------------------
r52226 | jhawkins@chromium.org | 2010-07-13 23:49:59 +0200 (Tue, 13 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

TTF: Re-enable BrowserFocusTest.TabsRememberFocusFindInPage by marking it as
FAILS_.

TBR=estade
BUG=23683
TEST=BrowserFocusTest.TabsRememberFocusFindInPage

Review URL: http://codereview.chromium.org/2980007
------------------------------------------------------------------------
r52224 | estade@chromium.org | 2010-07-13 23:47:51 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

GTK: own a widget that was being accessed after destruction.

BUG=48908
TEST=see bug

Review URL: http://codereview.chromium.org/2996002
------------------------------------------------------------------------
r52223 | shess@chromium.org | 2010-07-13 23:42:42 +0200 (Tue, 13 Jul 2010) | 31 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/ev_bubble_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/location_bar_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/location_bar_decoration.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   D /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac_unittest.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.h
   A /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.mm
   A /trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] First part of Omnibox decoration refactor.  Enable ev bubble.

The views implementation of the little things floating around in the
Omnibox uses nested views which are manually laid out by the
location-bar code.  The Mac code has a variety of different
implementations for these items, with the layout distributed across
many files.  This change creates something called a "decoration" which
is similar (different name because Mac has a strong sense of what a
"view" is).  Decorations are kind of like a C++ NSCell, which the
AutocompleteTextFieldCell handles generically and the
LocationBarViewMac::Layout() code will lay out.  The overall goal is
to loosely parallel the views code for decorations and Layout(), so
that future coders can do the right thing more easily.

This CL converts the left-hand items, namely:
 - the location icon
 - the search-keyword bubble
 - the ev security bubble (new)
The Layout() function does not yet deal with trimming things to fit
when space is tight.

location_bar_view_mac_unittest.mm was always a sham, so I'm going to
stop pretending.

BUG=41998
TEST=EV bubble for secure sites.
TEST=location icon can be clicked (page info panel) and dragged.
TEST=EV bubble can be clicked (page info panel) and dragged.
TEST=keyword-search mode shows appropriately.

Review URL: http://codereview.chromium.org/2805070
------------------------------------------------------------------------
r52222 | jhawkins@chromium.org | 2010-07-13 23:33:28 +0200 (Tue, 13 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

TTF: Re-enable UnloadTest.BrowserCloseTabWhenOtherTabHasListener on Win by
marking it as FAILS_.

TBR=estade
BUG=45281
TEST=UnloadTest.BrowserCloseTabWhenOtherTabHasListener

Review URL: http://codereview.chromium.org/2979004
------------------------------------------------------------------------
r52220 | derat@chromium.org | 2010-07-13 23:15:37 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

chromeos: Update key bindings for top-row keys.

BUG=chromium:45927,chromium-os:3860
TEST=none

Review URL: http://codereview.chromium.org/2963005
------------------------------------------------------------------------
r52216 | jhawkins@chromium.org | 2010-07-13 23:10:04 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd

AutoFill: Add the newly-added credit card images to browser_resources.grd.

BUG=48015
TEST=none

Review URL: http://codereview.chromium.org/2893014
------------------------------------------------------------------------
r52215 | oshima@chromium.org | 2010-07-13 22:59:33 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc

Marking AccountScreenTest.TestBasic

TBR=avayvod@chromium.org
BUG=49004
TEST=None

Review URL: http://codereview.chromium.org/2950005
------------------------------------------------------------------------
r52213 | jhawkins@chromium.org | 2010-07-13 22:42:14 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/amex.png
   A /trunk/src/chrome/browser/resources/cc-generic.png
   A /trunk/src/chrome/browser/resources/diners.png
   A /trunk/src/chrome/browser/resources/discover.png
   A /trunk/src/chrome/browser/resources/jcb.png
   A /trunk/src/chrome/browser/resources/mastercard.png
   A /trunk/src/chrome/browser/resources/solo.png
   A /trunk/src/chrome/browser/resources/visa.png

AutoFill: Add credit card images.

BUG=48015
TEST=none

Review URL: http://codereview.chromium.org/2917010
------------------------------------------------------------------------
r52209 | nick@chromium.org | 2010-07-13 22:27:11 +0200 (Tue, 13 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.h

Fix handling of undeletion within the syncer.

Accomplished by:
(a) Plumbing the const CommitMessage into process_commit_response_command.cc, so that we can know the server state better (IS_DEL is no longer authoritative if !
which spilled over into a couple test expectations.
(b) Relaxing the enforced invariants that version==0 implied !ServerKnows, for items with client tags.
(c) Use ID renaming instead of delete/recreate to handle collisions on the unique tag.
(d) Upon deletion, version number goes to 0 so that the server knows to process the item as a recreate, if it gets undeleted.  Previously, the server number would get synthesized on the client by incrementing the last known version number.
(e) Add unit tests for pretty much every ordering of delete/undelete I could come up with.

BUG=46769
TEST=unit tests; repeatedly uninstalled/installed extensions

Review URL: http://codereview.chromium.org/2844037
------------------------------------------------------------------------
r52207 | jhawkins@chromium.org | 2010-07-13 22:02:33 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h

AutoFill: Only send credit card data suggestions on HTTPS sites.

BUG=48499
TEST=AutoFillManagerTest.GetCreditCardSuggestionsNonHTTPS

Review URL: http://codereview.chromium.org/2941009
------------------------------------------------------------------------
r52204 | akalin@chromium.org | 2010-07-13 21:26:24 +0200 (Tue, 13 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.cc
   M /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.h
   A /trunk/src/chrome/browser/sync/notifier/chrome_system_resources_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Reworked ChromeSystemResources to handle callbacks properly.

Added unit tests.

BUG=48874
TEST=new unit tests

Review URL: http://codereview.chromium.org/2979003
------------------------------------------------------------------------
r52201 | johnnyg@chromium.org | 2010-07-13 21:05:33 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc

Fix valgrind failure in notifications tests.

BUG=48975
TEST=none

Review URL: http://codereview.chromium.org/2903011
------------------------------------------------------------------------
r52199 | thakis@chromium.org | 2010-07-13 20:56:32 +0200 (Tue, 13 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/base/cocoa_protocols_mac.h
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_picker_table.h
   M /trunk/src/chrome/browser/cocoa/tab_view_picker_table.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_picker_table_unittest.mm

Mac: Tweak content settings window.

Add "Features" label to source list.
xib change: Add some vertical space at the top of each tab, change outline view cell size to "small", hook up new outlet.

http://i.imgur.com/KGES6.png

BUG=45546
TEST=Content settings window still works: Current pane is still remembered, and opening the window from a bubble selects the right pane.

Review URL: http://codereview.chromium.org/2932009
------------------------------------------------------------------------
r52193 | pkasting@chromium.org | 2010-07-13 20:30:12 +0200 (Tue, 13 Jul 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Fix line endings.

------------------------------------------------------------------------
r52190 | stuartmorgan@chromium.org | 2010-07-13 20:14:35 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options.html

Fix include of sync_options.html, which shouldn't be ChromeOS-only

BUG=None
TEST=No JS errors on loading the DOMUI options.

Review URL: http://codereview.chromium.org/2979002
------------------------------------------------------------------------
r52187 | feldstein@chromium.org | 2010-07-13 20:06:46 +0200 (Tue, 13 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/after_translate_infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.h
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm

Clean up mac translate bars.

Switch buttons to use the metal style, and fix up spacing a bit.

BUG=40425
TEST=none

Review URL: http://codereview.chromium.org/2804035
------------------------------------------------------------------------
r52186 | eroman@chromium.org | 2010-07-13 20:01:50 +0200 (Tue, 13 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request_netlog_params.cc
   M /trunk/src/net/url_request/url_request_netlog_params.h

Add the URLRequest's priority to the net-log.

BUG=NONE
TEST=open about:net-internals, look at a request dump. there should be a "priority" field.
Review URL: http://codereview.chromium.org/2905007
------------------------------------------------------------------------
r52182 | andybons@chromium.org | 2010-07-13 19:24:48 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_infobar_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_infobar_apitest.cc
   A /trunk/src/chrome/browser/resources/extensions_infobar_mac.css

[Mac] Finish up extension infobar UI implementation.
o One issue under consideration is whether the HTML content of the infobar can take up the entire width. Right now on Windows it does not but with this implementation (and on Linux) it does.

BUG=43168
TEST=ExtensionApiTest.Infobars
Review URL: http://codereview.chromium.org/2973003
------------------------------------------------------------------------
r52178 | nkostylev@google.com | 2010-07-13 16:33:47 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/resources/host_registration_page.html

Resources for host register page.

BUG= http://crosbug.com/3653
TEST=none

Review URL: http://codereview.chromium.org/2903010
------------------------------------------------------------------------
r52177 | agl@chromium.org | 2010-07-13 16:30:38 +0200 (Tue, 13 Jul 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Fix ChromeOS build.
------------------------------------------------------------------------
r52176 | agl@chromium.org | 2010-07-13 16:17:28 +0200 (Tue, 13 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/sandbox/linux/suid/sandbox.c

Add about:sandbox.

(Idea from Julien Tinnes)

BUG=none
TEST=Navigate to about:sandbox on Linux and see the status of the sandbox.

http://codereview.chromium.org/2966003/show
------------------------------------------------------------------------
r52175 | pam@chromium.org | 2010-07-13 15:37:41 +0200 (Tue, 13 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/infobarbutton_b_h.png (from /trunk/src/app/resources/infobarbutton_b_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_b_n.png (from /trunk/src/app/resources/infobarbutton_b_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_b_p.png (from /trunk/src/app/resources/infobarbutton_b_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_bl_h.png (from /trunk/src/app/resources/infobarbutton_bl_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_bl_n.png (from /trunk/src/app/resources/infobarbutton_bl_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_bl_p.png (from /trunk/src/app/resources/infobarbutton_bl_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_br_h.png (from /trunk/src/app/resources/infobarbutton_br_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_br_n.png (from /trunk/src/app/resources/infobarbutton_br_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_br_p.png (from /trunk/src/app/resources/infobarbutton_br_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_c_h.png (from /trunk/src/app/resources/infobarbutton_c_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_c_n.png (from /trunk/src/app/resources/infobarbutton_c_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_c_p.png (from /trunk/src/app/resources/infobarbutton_c_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_l_h.png (from /trunk/src/app/resources/infobarbutton_l_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_l_n.png (from /trunk/src/app/resources/infobarbutton_l_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_l_p.png (from /trunk/src/app/resources/infobarbutton_l_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_menu_droparrow.png (from /trunk/src/app/resources/infobarbutton_menu_droparrow.png:52143)
   A /trunk/src/app/resources/infobarbutton_r_h.png (from /trunk/src/app/resources/infobarbutton_r_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_r_n.png (from /trunk/src/app/resources/infobarbutton_r_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_r_p.png (from /trunk/src/app/resources/infobarbutton_r_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_t_h.png (from /trunk/src/app/resources/infobarbutton_t_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_t_n.png (from /trunk/src/app/resources/infobarbutton_t_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_t_p.png (from /trunk/src/app/resources/infobarbutton_t_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_tl_h.png (from /trunk/src/app/resources/infobarbutton_tl_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_tl_n.png (from /trunk/src/app/resources/infobarbutton_tl_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_tl_p.png (from /trunk/src/app/resources/infobarbutton_tl_p.png:52143)
   A /trunk/src/app/resources/infobarbutton_tr_h.png (from /trunk/src/app/resources/infobarbutton_tr_h.png:52143)
   A /trunk/src/app/resources/infobarbutton_tr_n.png (from /trunk/src/app/resources/infobarbutton_tr_n.png:52143)
   A /trunk/src/app/resources/infobarbutton_tr_p.png (from /trunk/src/app/resources/infobarbutton_tr_p.png:52143)
   A /trunk/src/app/resources/input_alert.png (from /trunk/src/app/resources/input_alert.png:52143)
   D /trunk/src/chrome/app/theme/infobarbutton_b_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_b_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_b_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_bl_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_bl_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_bl_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_br_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_br_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_br_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_c_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_c_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_c_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_l_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_l_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_l_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_menu_droparrow.png
   D /trunk/src/chrome/app/theme/infobarbutton_r_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_r_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_r_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_t_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_t_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_t_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_tl_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_tl_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_tl_p.png
   D /trunk/src/chrome/app/theme/infobarbutton_tr_h.png
   D /trunk/src/chrome/app/theme/infobarbutton_tr_n.png
   D /trunk/src/chrome/app/theme/infobarbutton_tr_p.png
   D /trunk/src/chrome/app/theme/input_alert.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_button_border.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc

Revert 52144 - Clean up app_resources.grd:
* Alphabetize a couple entries
* Move things to theme_resources.grd where possible
* Scope things only used by views under an appropriate conditional

Reverting becasue it definitely causes ExtensionBrowserTest.Toolstrip to crash,
and apparently causes crashes in the startup_tests too.

TBR=pkasting

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2953005

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2897012
------------------------------------------------------------------------
r52169 | pam@chromium.org | 2010-07-13 08:56:32 +0200 (Tue, 13 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc

Rename "user" namespace to not conflict with ARM system header.
Rename others to match.

This fixes build breakage on
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Arm%20(dbg)/builds/4291/steps/compile/logs/stdio#error47

TBR=ncarter

BUG=none
TEST=ARM compiles work

Review URL: http://codereview.chromium.org/2924016
------------------------------------------------------------------------
r52168 | oshima@chromium.org | 2010-07-13 06:13:03 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc

FAIL_ -> FAILS_Battery{Charging|Discharging}Test

TBR=arv@chromium.org, pkasting@chromium.org
BUG=48912
TEST=none

Review URL: http://codereview.chromium.org/2962011
------------------------------------------------------------------------
r52167 | oshima@chromium.org | 2010-07-13 06:01:49 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Marked ExtensionApiTest.Tabs browsertest as flaky.

TBR=sky@chromium.org
BUG=48920
TEST=none:w

Review URL: http://codereview.chromium.org/2943008
------------------------------------------------------------------------
r52165 | jam@chromium.org | 2010-07-13 05:36:30 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc

Revert 52161 -Accidental checkin. Load Pepper v2 internal pdf plugin.

Also need to uncomment pepper_plugin_registry.cc
Review URL: http://codereview.chromium.org/2804037

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/2968007
------------------------------------------------------------------------
r52161 | jam@chromium.org | 2010-07-13 05:34:21 +0200 (Tue, 13 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc

Load Pepper v2 internal pdf plugin.

Also need to uncomment pepper_plugin_registry.cc
Review URL: http://codereview.chromium.org/2804037
------------------------------------------------------------------------
r52160 | oshima@chromium.org | 2010-07-13 05:04:57 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Disable BasicRestoreFromClosedWindow for chromeos as well.

TBR=phajdan.jr@chromium.org
BUG=14774
TEST=none

Review URL: http://codereview.chromium.org/2937006
------------------------------------------------------------------------
r52159 | oshima@chromium.org | 2010-07-13 04:47:06 +0200 (Tue, 13 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Revert "Disabling BasicRestoreFromClosedWindow for chromeos as well."

This reverts commit 7d4e4e51254eb464f0207768efde87cd9489bb89.

I'm stupid...

TBR=phajdan.jr@chromium.org

Review URL: http://codereview.chromium.org/2976005
------------------------------------------------------------------------
r52158 | oshima@chromium.org | 2010-07-13 04:37:23 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Disabling BasicRestoreFromClosedWindow for chromeos as well.

TBR=phajdan.jr@chromium.org,
BUG=14774
TEST=none

Review URL: http://codereview.chromium.org/2909011
------------------------------------------------------------------------
r52157 | oshima@chromium.org | 2010-07-13 04:36:53 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/gfx/size.cc

Disablging failing ui tests: RestoreWindow and RestoreWindowAndTab

TBR=sky@chromium.org
BUG=48911
TEST=none

Review URL: http://codereview.chromium.org/2895012
------------------------------------------------------------------------
r52156 | arv@chromium.org | 2010-07-13 04:09:56 +0200 (Tue, 13 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc

Mark failing tests with FAIL_

BUG=48912
TEST=None
TBR=pkasting
------------------------------------------------------------------------
r52155 | pkasting@chromium.org | 2010-07-13 02:59:54 +0200 (Tue, 13 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

This file got left out of r52144.

BUG=none
TEST=none

------------------------------------------------------------------------
r52152 | apatrick@chromium.org | 2010-07-13 01:46:17 +0200 (Tue, 13 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Asynchronously launches the GPU process.
- First renderer process sends IPC to browser process causing it to prelaunch the GPU process.
- IPC channel is subsequently established.
- If EstablishAsyncChannelSync is not called during this period, it will not block.
- Future renderer processes simply asynchronously establish the IPC channel.
- This also causes the GPU process to be relaunched if it crashed.

TEST=try, observed that GPU process launches even for pages without 3D content
BUG=none

Review URL: http://codereview.chromium.org/2952005
------------------------------------------------------------------------
r52150 | jrg@chromium.org | 2010-07-13 01:43:17 +0200 (Tue, 13 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   M /trunk/src/chrome/browser/extensions/extension_pref_store.h

Fix memory leak in extension pref store
BUG=none

Memory bot which will turn green with this change:
http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/4870/steps/heapcheck%20test:%20unit/logs/stdio


Review URL: http://codereview.chromium.org/2923008
------------------------------------------------------------------------
r52149 | pkasting@chromium.org | 2010-07-13 01:39:00 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc

Fix ChromeOS reliance on implicit ordering of resource IDs.  This was supposed to have landed before/with r51906, but accidentally got separated.

BUG=CROS4759
TEST=Wifi status indicator reads correctly above 80%
TBR=chocobo

------------------------------------------------------------------------
r52146 | pkasting@chromium.org | 2010-07-13 01:04:39 +0200 (Tue, 13 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals_resources.grd
   M /trunk/src/chrome/chrome_browser.gypi

Clean up net_internals_resources.grd:
* Always mark HTML/CSS as "flattenhtml" unless not possible
* Remove resources not needed due to flattening
* Simplify dom_ui code now that most resources won't be loaded that route

The change to index.html is needed to make the flattener do the right thing (otherwise the stylesheet doesn't get inlined).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2907009
------------------------------------------------------------------------
r52145 | pkasting@chromium.org | 2010-07-13 01:04:34 +0200 (Tue, 13 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmarks_favicon.png
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmarks_section.png
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr
   M /trunk/src/chrome/browser/resources/bookmark_manager_resources.grd
   M /trunk/src/chrome/browser/resources/shared/css/tree.css

Clean up bookmark_manager_resources.grd:
* Always mark HTML/CSS as "flattenhtml" unless not possible
* Remove resources not needed (due to flattening, or just extra).  I assume the "test" files don't need to ship with Chrome and are just for local testing.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2944007
------------------------------------------------------------------------
r52144 | pkasting@chromium.org | 2010-07-13 01:04:27 +0200 (Tue, 13 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/infobarbutton_b_h.png
   D /trunk/src/app/resources/infobarbutton_b_n.png
   D /trunk/src/app/resources/infobarbutton_b_p.png
   D /trunk/src/app/resources/infobarbutton_bl_h.png
   D /trunk/src/app/resources/infobarbutton_bl_n.png
   D /trunk/src/app/resources/infobarbutton_bl_p.png
   D /trunk/src/app/resources/infobarbutton_br_h.png
   D /trunk/src/app/resources/infobarbutton_br_n.png
   D /trunk/src/app/resources/infobarbutton_br_p.png
   D /trunk/src/app/resources/infobarbutton_c_h.png
   D /trunk/src/app/resources/infobarbutton_c_n.png
   D /trunk/src/app/resources/infobarbutton_c_p.png
   D /trunk/src/app/resources/infobarbutton_l_h.png
   D /trunk/src/app/resources/infobarbutton_l_n.png
   D /trunk/src/app/resources/infobarbutton_l_p.png
   D /trunk/src/app/resources/infobarbutton_menu_droparrow.png
   D /trunk/src/app/resources/infobarbutton_r_h.png
   D /trunk/src/app/resources/infobarbutton_r_n.png
   D /trunk/src/app/resources/infobarbutton_r_p.png
   D /trunk/src/app/resources/infobarbutton_t_h.png
   D /trunk/src/app/resources/infobarbutton_t_n.png
   D /trunk/src/app/resources/infobarbutton_t_p.png
   D /trunk/src/app/resources/infobarbutton_tl_h.png
   D /trunk/src/app/resources/infobarbutton_tl_n.png
   D /trunk/src/app/resources/infobarbutton_tl_p.png
   D /trunk/src/app/resources/infobarbutton_tr_h.png
   D /trunk/src/app/resources/infobarbutton_tr_n.png
   D /trunk/src/app/resources/infobarbutton_tr_p.png
   D /trunk/src/app/resources/input_alert.png
   A /trunk/src/chrome/app/theme/infobarbutton_b_h.png (from /trunk/src/app/resources/infobarbutton_b_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_b_n.png (from /trunk/src/app/resources/infobarbutton_b_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_b_p.png (from /trunk/src/app/resources/infobarbutton_b_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_bl_h.png (from /trunk/src/app/resources/infobarbutton_bl_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_bl_n.png (from /trunk/src/app/resources/infobarbutton_bl_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_bl_p.png (from /trunk/src/app/resources/infobarbutton_bl_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_br_h.png (from /trunk/src/app/resources/infobarbutton_br_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_br_n.png (from /trunk/src/app/resources/infobarbutton_br_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_br_p.png (from /trunk/src/app/resources/infobarbutton_br_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_c_h.png (from /trunk/src/app/resources/infobarbutton_c_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_c_n.png (from /trunk/src/app/resources/infobarbutton_c_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_c_p.png (from /trunk/src/app/resources/infobarbutton_c_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_l_h.png (from /trunk/src/app/resources/infobarbutton_l_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_l_n.png (from /trunk/src/app/resources/infobarbutton_l_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_l_p.png (from /trunk/src/app/resources/infobarbutton_l_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_menu_droparrow.png (from /trunk/src/app/resources/infobarbutton_menu_droparrow.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_r_h.png (from /trunk/src/app/resources/infobarbutton_r_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_r_n.png (from /trunk/src/app/resources/infobarbutton_r_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_r_p.png (from /trunk/src/app/resources/infobarbutton_r_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_t_h.png (from /trunk/src/app/resources/infobarbutton_t_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_t_n.png (from /trunk/src/app/resources/infobarbutton_t_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_t_p.png (from /trunk/src/app/resources/infobarbutton_t_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_tl_h.png (from /trunk/src/app/resources/infobarbutton_tl_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_tl_n.png (from /trunk/src/app/resources/infobarbutton_tl_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_tl_p.png (from /trunk/src/app/resources/infobarbutton_tl_p.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_tr_h.png (from /trunk/src/app/resources/infobarbutton_tr_h.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_tr_n.png (from /trunk/src/app/resources/infobarbutton_tr_n.png:51984)
   A /trunk/src/chrome/app/theme/infobarbutton_tr_p.png (from /trunk/src/app/resources/infobarbutton_tr_p.png:51984)
   A /trunk/src/chrome/app/theme/input_alert.png (from /trunk/src/app/resources/input_alert.png:51984)
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_button_border.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc

Clean up app_resources.grd:
* Alphabetize a couple entries
* Move things to theme_resources.grd where possible
* Scope things only used by views under an appropriate conditional

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2953005
------------------------------------------------------------------------
r52143 | pkasting@chromium.org | 2010-07-13 01:04:21 +0200 (Tue, 13 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc

Remove "Close tabs opened by this tab".

BUG=none
TEST=Right click a tab, "Close opened by" should not be in the context menu.
Review URL: http://codereview.chromium.org/2903004
------------------------------------------------------------------------
r52142 | skrul@chromium.org | 2010-07-13 00:50:31 +0200 (Tue, 13 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h

Make kCookiePromptExpanded a profile pref rather than a local state pref so it can be synced.

BUG=40483

Review URL: http://codereview.chromium.org/2964003
------------------------------------------------------------------------
r52141 | jhawkins@chromium.org | 2010-07-13 00:40:06 +0200 (Tue, 13 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   A /trunk/src/chrome/browser/autofill/form_group.cc
   M /trunk/src/chrome/browser/autofill/form_group.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/chrome_browser.gypi

AutoFill: Save the imported credit card data in response to the CC InfoBar.

BUG=47428
TEST=none

Review URL: http://codereview.chromium.org/2965007
------------------------------------------------------------------------
r52139 | estade@chromium.org | 2010-07-13 00:31:19 +0200 (Tue, 13 Jul 2010) | 14 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/content_settings_handler.cc
   A /trunk/src/chrome/browser/dom_ui/content_settings_handler.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/content_settings.html
   A /trunk/src/chrome/browser/resources/options/content_settings.js
   A /trunk/src/chrome/browser/resources/options/content_settings_page.css
   A /trunk/src/chrome/browser/resources/options/content_settings_ui.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

First cut at the tabbed content settings page.

Missing pieces:
- Add the other tabs besides the first two.
- The tab switching mechanism might need some work (it definitely needs to look better, and perhaps should also work with the back/forward buttons).
- none of the <button>s work
- I added the Content Settings page as one of the main options pages for now, but in the end it should show up when a user clicks the "Content Settings..." button in Under the Hood.

There is a bit of extra code because content settings don't use prefs, so I had to sort of replicate the pref_ui code.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2804039
------------------------------------------------------------------------
r52126 | shess@chromium.org | 2010-07-12 22:13:19 +0200 (Mon, 12 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest_helper.h

[Mac] Mouse clicks in omnibox close popup.

Previously a right-click in omnibox or on a page action would have a
context menu _and_ the omnibox popup.  Clicking a page action or star
would mess up the omnibox selection.  This brings things in line with
other platforms.

Also fix to not change selection if an omnibox decoration handles the click.

BUG=40145
TEST=Clicking star with omnibox popup up should close popup.
TEST=Clicking star should not change omnibox selection.
TEST=Right-click in omnibox with popup up should close popup.

Review URL: http://codereview.chromium.org/2900006
------------------------------------------------------------------------
r52125 | satish@chromium.org | 2010-07-12 22:11:04 +0200 (Mon, 12 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   A /trunk/src/media/audio/audio_io.h (from /trunk/src/media/audio/audio_output.h:52123)
   D /trunk/src/media/audio/audio_output.h
   M /trunk/src/media/audio/audio_output_controller.cc
   M /trunk/src/media/audio/audio_output_controller.h
   M /trunk/src/media/audio/audio_output_controller_unittest.cc
   M /trunk/src/media/audio/fake_audio_output_stream.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.h
   M /trunk/src/media/audio/mac/audio_manager_mac.cc
   M /trunk/src/media/audio/mac/audio_manager_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac_unittest.cc
   M /trunk/src/media/audio/openbsd/audio_manager_openbsd.cc
   M /trunk/src/media/audio/openbsd/audio_manager_openbsd.h
   M /trunk/src/media/audio/simple_sources.cc
   M /trunk/src/media/audio/simple_sources.h
   M /trunk/src/media/audio/simple_sources_unittest.cc
   A /trunk/src/media/audio/win/audio_manager_win.cc (from /trunk/src/media/audio/win/audio_output_win.cc:52123)
   M /trunk/src/media/audio/win/audio_manager_win.h
   D /trunk/src/media/audio/win/audio_output_win.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/filters/audio_renderer_impl.cc
   M /trunk/src/media/filters/audio_renderer_impl.h
   M /trunk/src/media/media.gyp
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Rename a header and some methods to make way for subsequent audio recording additions.
Renaming audio_output.h to audio_io.h as future patches will add audio recording code to this file.
Also renamed a couple of methods to make it clear that these are for audio playback/output and similar methods will be added for audio capture/recording soon.
BUG=none
TEST=no change in functionality.

Review URL: http://codereview.chromium.org/2962006
------------------------------------------------------------------------
r52124 | estade@chromium.org | 2010-07-12 22:09:17 +0200 (Mon, 12 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

Linux: remove mismatched brace

BUG=none
TEST=compile
TBR=vandebo

Review URL: http://codereview.chromium.org/2975004
------------------------------------------------------------------------
r52123 | estade@chromium.org | 2010-07-12 21:47:06 +0200 (Mon, 12 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

[Gtk] on middle click, open all bookmarks in tabs

When a subfolder (i.e. a folder in a dropdown menu, not on the bookmark bar itself) is middle clicked, it should open all sub nodes in tabs.

BUG=34416
TEST=none

Review URL: http://codereview.chromium.org/2968004
------------------------------------------------------------------------
r52122 | levin@chromium.org | 2010-07-12 21:42:29 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_idle_apitest.cc
   M /trunk/src/chrome/common/extensions/docs/idle.html
   A /trunk/src/chrome/common/extensions/docs/static/idle.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/data/extensions/api_test/idle/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/disabled/background.html

Make chrome.idle have a permission.

BUG=None
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.ExperimentalPermissionsFail

Review URL: http://codereview.chromium.org/2976002
------------------------------------------------------------------------
r52121 | levin@chromium.org | 2010-07-12 21:40:50 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_idle_api.h
   M /trunk/src/chrome/browser/extensions/extension_idle_api_constants.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/a11y.html
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/docs.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html
   M /trunk/src/chrome/common/extensions/docs/experimental.cookies.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/common/extensions/docs/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/external_extensions.html
   M /trunk/src/chrome/common/extensions/docs/faq.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   A /trunk/src/chrome/common/extensions/docs/idle.html (from /trunk/src/chrome/common/extensions/docs/experimental.infobars.html:52120)
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/messaging.html
   M /trunk/src/chrome/common/extensions/docs/notifications.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/options.html
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/tut_analytics.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tut_oauth.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/idle/test.js

Move idle from experimental.

TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Idle
BUG=None

Review URL: http://codereview.chromium.org/2930001
------------------------------------------------------------------------
r52120 | thestig@chromium.org | 2010-07-12 21:34:00 +0200 (Mon, 12 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc

Linux: Use opaque black instead of opaque white when setting the mask during a tab DnD.

BUG=48199
TEST=Manual, see bug.
Review URL: http://codereview.chromium.org/2922004
------------------------------------------------------------------------
r52116 | arv@chromium.org | 2010-07-12 21:12:19 +0200 (Mon, 12 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

History UI: Make sure the history items are not too wide.

This uncomments commented out code that used to broken due to a WebKit regression. WebKit was fixed a while ago so this now works again.

BUG=29422
TEST=Go to the history page. Resize the window and make sure you see '...' at the end of the item text.

Review URL: http://codereview.chromium.org/2912003
------------------------------------------------------------------------
r52112 | tim@chromium.org | 2010-07-12 20:35:53 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add link to privacy dashboard from sync options panel behind command line flag.

BUG=48844
TEST=Open options > Personal Stuff, see link to dashboard.

Review URL: http://codereview.chromium.org/2934010
------------------------------------------------------------------------
r52107 | vandebo@chromium.org | 2010-07-12 20:25:21 +0200 (Mon, 12 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool.cc
   M /trunk/src/net/http/http_proxy_client_socket_pool.h
   M /trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/socks_client_socket_pool.h
   M /trunk/src/net/socket/socks_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_session_unittest.cc

Make the various SocketParams reference counted.

This is so that the SSLSocketParam can hold one of any of the existing SocketParams.

BUG=30357
TEST=existing unit tests

Review URL: http://codereview.chromium.org/2848029
------------------------------------------------------------------------
r52105 | eroman@chromium.org | 2010-07-12 20:15:20 +0200 (Mon, 12 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js

Aesthetic: Make the display of "network changed events" in about:net-internals prettier.

BUG=46822
Review URL: http://codereview.chromium.org/2932008
------------------------------------------------------------------------
r52102 | shess@chromium.org | 2010-07-12 19:57:27 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

[Mac] Redraw omnibox when updating star status.

BUG=46696
TEST=Put an url on BMB.  Click to it.  Right-click delete, star in omnibox should update.

Review URL: http://codereview.chromium.org/2915002
------------------------------------------------------------------------
r52098 | willchan@chromium.org | 2010-07-12 19:40:49 +0200 (Mon, 12 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_posix.cc
   M /trunk/src/chrome/browser/browser_main_win.cc

Posix: Stop crashing on SIG{INT|HUP|TERM}.
BUG=48637

Review URL: http://codereview.chromium.org/2927008
------------------------------------------------------------------------
r52097 | jcivelli@google.com | 2010-07-12 19:38:10 +0200 (Mon, 12 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/language_state.cc
   M /trunk/src/chrome/browser/tab_contents/language_state.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations.h

Don't offer to translate pages if the page says so by
using the magic Google meta-tag.

BUG=48606
TEST=See bug.

Review URL: http://codereview.chromium.org/2960001
------------------------------------------------------------------------
r52094 | ananta@chromium.org | 2010-07-12 19:30:58 +0200 (Mon, 12 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc

ChromeFrame would leave chrome processes running if a page rendered in Chrome would open up a popup window which
opened up in IE. This is because of an orphan external tab container created to handle the popup. This tab is destroyed
in the normal case when the active document window is destroyed, which is the parent of the external tab container.

However in this case the active document is destroyed without its window being created thus resulting in the external tab
container lying around which holds a reference to the automation provider.

Fix is to pass the ChromeFrameAutomationClient window as the parent window in the AutomationMsg_ConnectExternalTab
message.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=48732

Bug=48732

Covered by ChromeFrame test FullTabNavigationTest.JavascriptWindowOpenDifferentDomain


Review URL: http://codereview.chromium.org/2911006
------------------------------------------------------------------------
r52093 | erg@chromium.org | 2010-07-12 19:30:06 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_devices.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Header cleanup: SkBitmap and other unnecessary includes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2891008
------------------------------------------------------------------------
r52090 | johnnyg@chromium.org | 2010-07-12 19:13:49 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification.cc
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification_factory.cc
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   M /trunk/src/chrome/browser/notifications/balloon.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notification.h
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.cc
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/resources/notification_1line.html
   M /trunk/src/chrome/browser/resources/notification_2line.html
   M /trunk/src/chrome/browser/resources/notification_icon.html
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/notification_provider.cc

Implement BiDi support and replace ID support for notifications.

BUG=none
TEST=layout tests

Review URL: http://codereview.chromium.org/1917004
------------------------------------------------------------------------
r52088 | pam@chromium.org | 2010-07-12 18:48:49 +0200 (Mon, 12 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_pref_store.cc
   A /trunk/src/chrome/browser/extensions/extension_pref_store.h
   A /trunk/src/chrome/browser/extensions/extension_pref_store_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   M /trunk/src/chrome/browser/pref_value_store.cc
   M /trunk/src/chrome/browser/pref_value_store.h
   M /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Add an ExtensionPrefStore, layered between the user prefs and the managed prefs, to manage preferences set by extensions.
Update various callers of the PrefValueStore constructor accordingly.

The initial user will be the proxy extension API.

BUG=266
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/2823037
------------------------------------------------------------------------
r52087 | avi@chromium.org | 2010-07-12 18:45:45 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.mm

Always draw the Sad Tab icon on pixels, never blurry.

BUG=http://crbug.com/48837
TEST=crash a tab (via task manager), sloowwwly resize window. Sad Tab icon should always draw crisp and clear.

Review URL: http://codereview.chromium.org/2966004
------------------------------------------------------------------------
r52086 | jcivelli@chromium.org | 2010-07-12 18:38:08 +0200 (Mon, 12 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Make the translate button more responsive
Makes sure we show the "translating..." infobar as soon as the user presses the translate infobar button.
We were previously delaying until the translate element script was fetched from the Google translate server, making the infobar appear unresponsive.

BUG=48692
TEST=Start Chrome, navigate to a site in a language different from
     the Chrome language, press translate. The infobar should change
     immediately to the "Translating..." infobar.

Review URL: http://codereview.chromium.org/2941005
------------------------------------------------------------------------
r52083 | dhollowa@chromium.org | 2010-07-12 18:03:22 +0200 (Mon, 12 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

AutoFill Empty profiles and credit cards should not be saved

Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database.

BUG=47742
TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard

This fixes issue in unit test...  prior review was at:
http://codereview.chromium.org/2897005

Review URL: http://codereview.chromium.org/2900005
------------------------------------------------------------------------
r52081 | agl@chromium.org | 2010-07-12 17:14:34 +0200 (Mon, 12 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Fix up a comment.

No code changes.
------------------------------------------------------------------------
r52079 | agl@chromium.org | 2010-07-12 16:49:04 +0200 (Mon, 12 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/net/base/ssl_config_service.h
   A /trunk/src/net/base/ssl_connection_status_flags.h
   M /trunk/src/net/base/ssl_info.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc

Plumb SSL connection information into the PageInfo model.

This plumbs two bits of information into the PageInfo model (the dialog
which results from clicking on the padlock icon): whether or not we
performed SSLv3 fallback and whether or not the server supported the
renegotiation extension.

It doesn't actually do anything with this information yet (except to add
histograms of them), pending future CLs.

BUG=none
TEST=none

http://codereview.chromium.org/2943001/show
------------------------------------------------------------------------
r52078 | hans@chromium.org | 2010-07-12 16:07:55 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Marking SessionHistoryTest.FrameBackForward flaky on Windows.

BUG=48833
TEST=Vista Tests (dbg)(2) should become green

Review URL: http://codereview.chromium.org/2956004
------------------------------------------------------------------------
r52075 | nkostylev@google.com | 2010-07-12 13:37:25 +0200 (Mon, 12 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   A /trunk/src/chrome/browser/chromeos/login/registration_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/registration_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

Initial commit for product registration page.
UI only, not integrated into OOBE yet.

BUG= http://crosbug.com/4645
TEST=--login-screen=register should show wizard screen with about: page.

Review URL: http://codereview.chromium.org/2924010
------------------------------------------------------------------------
r52074 | jochen@chromium.org | 2010-07-12 11:12:59 +0200 (Mon, 12 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.cc
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host.h
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler.cc
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Reland r52072. Pass notifications to the browser on access to the appcache main resource manifest.

BUG=45230
TEST=browser_tests
TBR=vandebo

Review URL: http://codereview.chromium.org/2980001
------------------------------------------------------------------------
r52073 | vandebo@chromium.org | 2010-07-12 08:04:49 +0200 (Mon, 12 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.cc
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host.h
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler.cc
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Failed compile on Chromium builder dbg

Revert 52072 - Pass notifications to the browser on access to the appcache main resource manifest.

BUG=45230
TEST=browser_tests

Review URL: http://codereview.chromium.org/2808046

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/2925008
------------------------------------------------------------------------
r52072 | jochen@chromium.org | 2010-07-12 06:00:01 +0200 (Mon, 12 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   M /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.cc
   M /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host.h
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler.cc
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Pass notifications to the browser on access to the appcache main resource manifest.

BUG=45230
TEST=browser_tests

Review URL: http://codereview.chromium.org/2808046
------------------------------------------------------------------------
r52071 | sky@chromium.org | 2010-07-12 04:48:40 +0200 (Mon, 12 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h

Attempt at fixing crash during tab dragging. The crash dumps seem to
indicate the tab being dragged is getting deleted between the time we
detach from the model and update the DraggedTabView. This could happen
if the animation were canceled (as could happen if a layout
happened). I don't see how that could happen though. None-the-less
it's easy to deal with the tab going away as it isn't needed when
dragging. This may end up shifting the crash around though, we'll see.

I'm also removing some dead code in the DraggedTabView that is no
longer needed as we only used DraggedTabView for the detached state.

BUG=48365
TEST=make sure tab dragging on windows still works.

Review URL: http://codereview.chromium.org/2924003
------------------------------------------------------------------------
r52070 | rafaelw@chromium.org | 2010-07-12 02:50:29 +0200 (Mon, 12 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Reland -- Add tab menu item to show/hide toolbar for app tabs

Also, never show bookmarks bar on app tabs.

BUG=45540
TBR=erg

original review: http://codereview.chromium.org/2854038/show

Review URL: http://codereview.chromium.org/2955006
------------------------------------------------------------------------
r52067 | vandebo@chromium.org | 2010-07-12 00:41:43 +0200 (Mon, 12 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   D /trunk/src/chrome/browser/automation/automation_provider_json.cc
   D /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Revert 52054: causing startup tests to fail on Vista and XP perf dbg

Revert 52054 - Refactor json automation interface for pyauto hooks.
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.

Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.

Review URL: http://codereview.chromium.org/2898001

TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/2977001
------------------------------------------------------------------------
r52060 | tfarina@chromium.org | 2010-07-11 19:51:10 +0200 (Sun, 11 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.mm
   M /trunk/src/chrome/browser/status_icons/status_icon.h

status_icons: Remove StatusIcon::Create method.

This method is not called by anyone. We use StatusTray::CreateStatusIcon instead
to create a new icon.

BUG=37375
TEST=manually and trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/2975002
------------------------------------------------------------------------
r52059 | erikkay@chromium.org | 2010-07-11 19:14:48 +0200 (Sun, 11 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   A /trunk/src/chrome/browser/renderer_host/test/render_process_host_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add unit test and supporting code to test process overflow case.
This test is disabled for now since we don't have a fix yet.  The point
of checkin in this CL is to make it easier for us to test alternate
approaches to fixing.

BUG=43448
TEST=RenderProcessHostTest.ProcessOverflow

Review URL: http://codereview.chromium.org/2928004
------------------------------------------------------------------------
r52054 | nirnimesh@chromium.org | 2010-07-11 08:48:40 +0200 (Sun, 11 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/automation/automation_provider_json.cc
   A /trunk/src/chrome/browser/automation/automation_provider_json.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Refactor json automation interface for pyauto hooks.
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.

Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.

Review URL: http://codereview.chromium.org/2898001
------------------------------------------------------------------------
r52046 | eroman@chromium.org | 2010-07-10 22:44:47 +0200 (Sat, 10 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Change the default number of proxy resolver threads used for evaluating PAC scripts from 1 to 4.

Also adds a command line flag to override the default: --num-pac-threads=X

BUG=11079
Review URL: http://codereview.chromium.org/2893005
------------------------------------------------------------------------
r52030 | mattm@chromium.org | 2010-07-10 02:54:40 +0200 (Sat, 10 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Coverity: fix leak when AutomationProvider::WaitForDownloadsToComplete called with zero downloads.

CID=9160
TEST=trybots
BUG=none

Review URL: http://codereview.chromium.org/2934002
------------------------------------------------------------------------
r52028 | oshima@chromium.org | 2010-07-10 02:36:56 +0200 (Sat, 10 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/chromeos/network_state_notifier.cc
   A /trunk/src/chrome/browser/chromeos/network_state_notifier.h
   A /trunk/src/chrome/browser/chromeos/network_state_notifier_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h

NetworkStateNotifier that sends notification when network stat has changed.
 This will be used to implement 3605. I created separate notification as we're planning to port to other platfrom.

BUG=chromium-os:3605
TEST=added browser test

Review URL: http://codereview.chromium.org/2913001
------------------------------------------------------------------------
r52026 | ziadh@chromium.org | 2010-07-10 02:31:27 +0200 (Sat, 10 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/common/metrics_helpers.cc

Removed some unused code. We were adding some data to std::set objects that never get read from again.

r=jar

Review URL: http://codereview.chromium.org/2925006
------------------------------------------------------------------------
r52025 | eroman@chromium.org | 2010-07-10 02:27:00 +0200 (Sat, 10 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Fix a crash when using negotiate HTTP auth.

BUG=48690

Review URL: http://codereview.chromium.org/2896007
------------------------------------------------------------------------
r52024 | nirnimesh@chromium.org | 2010-07-10 02:09:03 +0200 (Sat, 10 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/themes.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.i

PyAuto: Automation hooks to get/set theme

Add automation hooks to:
  - install a given theme
  - fetch info about the current theme
  - reset to default theme

Add a test exercising the above.

BUG=36215
TEST=python chrome/test/functional/themes.py

Review URL: http://codereview.chromium.org/2827048
------------------------------------------------------------------------
r52023 | akalin@chromium.org | 2010-07-10 02:08:28 +0200 (Sat, 10 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notification_method.cc

Set default sync notification method to "server".

BUG=34647
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51494

Review URL: http://codereview.chromium.org/2822044
------------------------------------------------------------------------
r52018 | akalin@chromium.org | 2010-07-10 01:31:33 +0200 (Sat, 10 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/sync/notifier/invalidation_util.cc
   M /trunk/src/third_party/cacheinvalidation/cacheinvalidation.gyp

Updated cache-invalidation-api to @33.

BUG=34647
TEST=built on all platforms

Review URL: http://codereview.chromium.org/2970001
------------------------------------------------------------------------
r52016 | jar@chromium.org | 2010-07-10 01:26:38 +0200 (Sat, 10 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/predictor_api.cc
   M /trunk/src/chrome/browser/net/predictor_api.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Avoid preconnect (and pre-resolution) when proxy MIGHT be present

This change detects if there is a chance that a proxy MIGHT
be used to perform a connection, and if so, it avoids doing
any speculative preconnections, or speculative DNS
pre-resolution.

For testing purposes, a flag is provided to avoid this
probe for proxy status.  If you enable --preconnect-despite-proxy
then preconnection will take place (as appropriate) even
if there is a chance that a proxy might be used
for connections to some hosts.

BUG=47906
r=eroman
Review URL: http://codereview.chromium.org/2871038
------------------------------------------------------------------------
r52015 | satish@chromium.org | 2010-07-10 01:24:12 +0200 (Sat, 10 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/audio_sync_reader.cc
   M /trunk/src/chrome/browser/renderer_host/audio_sync_reader.h
   D /trunk/src/media/audio/audio_controller.cc
   D /trunk/src/media/audio/audio_controller.h
   D /trunk/src/media/audio/audio_controller_unittest.cc
   A /trunk/src/media/audio/audio_output_controller.cc (from /trunk/src/media/audio/audio_controller.cc:52014)
   A /trunk/src/media/audio/audio_output_controller.h (from /trunk/src/media/audio/audio_controller.h:52014)
   A /trunk/src/media/audio/audio_output_controller_unittest.cc (from /trunk/src/media/audio/audio_controller_unittest.cc:52014)
   M /trunk/src/media/media.gyp

Renamed AudioController to AudioOutputController.
This is in preparation to add an AudioInputController for audio recording in subsequent changes.
BUG=none
TEST=no functional change

Review URL: http://codereview.chromium.org/2964005
------------------------------------------------------------------------
r52007 | dhg@chromium.org | 2010-07-09 22:35:31 +0200 (Fri, 09 Jul 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/sync_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.js
   M /trunk/src/chrome/browser/resources/options/options_page.js
   A /trunk/src/chrome/browser/resources/options/sync_options.html
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Adding support for sub pages and adding the sync page. 

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2812043
------------------------------------------------------------------------
r52006 | stuartmorgan@chromium.org | 2010-07-09 22:35:23 +0200 (Fri, 09 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   M /trunk/src/chrome/browser/resources/options/browser_options.html
   M /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/options_page.css

Skeleton of DOMUI implementation of Basics option page

This is just the HTML and CSS and the skeleton of some of the JavaScript. Only the checkbox for the Home button currently works. Remaining functionality will be added over time.

BUG=48713
TEST=Basics page in options should show options; "Show Home button" should work.

Review URL: http://codereview.chromium.org/2972001
------------------------------------------------------------------------
r52003 | pkasting@chromium.org | 2010-07-09 22:31:15 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc

Disable a test temporarily to avoid causing other tests problems when they run after it.

BUG=48717
TEST=none
TBR=dmazzoni
Review URL: http://codereview.chromium.org/2923004
------------------------------------------------------------------------
r51998 | zelidrag@chromium.org | 2010-07-09 22:04:05 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Made chrome: schema savable. Reenabled print context menu that was previously disabled in ChromeOS.

BUG=chrome-os:4073
TEST=open about:system, right mouse click and pick Save As menu item

Review URL: http://codereview.chromium.org/2880009
------------------------------------------------------------------------
r51995 | erg@chromium.org | 2010-07-09 21:43:09 +0200 (Fri, 09 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/page_transition_types.cc
   M /trunk/src/chrome/common/page_transition_types.h

Try to cut down Browser/TabContents header dependencies.

- Forward declare printing::PrintViewManager in TabContents
- tab_contents.h shouldn't depend on autocomplete_edit.h
- Pull logging out of Browser through PageTransitionTypes

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2934004
------------------------------------------------------------------------
r51992 | dhg@chromium.org | 2010-07-09 21:01:33 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing mistake in chrome that would cause save as to not work.

BUG=chromium-os:4659
TEST=none

Review URL: http://codereview.chromium.org/2957005
------------------------------------------------------------------------
r51987 | huanr@chromium.org | 2010-07-09 20:30:45 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/importer/profile_writer.h

Make bookmark import not to enable bookmark bar by default.

BUG=46528
TEST=mini_installer.exe --installerdata=<file_path>

Review URL: http://codereview.chromium.org/2962004
------------------------------------------------------------------------
r51985 | ananta@chromium.org | 2010-07-09 20:30:31 +0200 (Fri, 09 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h

Infobars would not show up in chrome frame rendered pages due to a change in the root view Layout code which does not give
the child views a chance to process the layout if a layout manager existed for the root view. The default layout manager for
the root view is the FillView.

Fix is to handle layout correctly in the ExternalTabContainer in the InfoBarSizeChanged notification by maintaining the current
grid view in a member and invoking layout on it.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=48569

Bug=48569

Review URL: http://codereview.chromium.org/2963002
------------------------------------------------------------------------
r51984 | alyssad@chromium.org | 2010-07-09 20:22:56 +0200 (Fri, 09 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/autofill.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

New pyauto hook to set and get autofill profiles

Review URL: http://codereview.chromium.org/2836046
------------------------------------------------------------------------
r51983 | erg@chromium.org | 2010-07-09 20:13:25 +0200 (Fri, 09 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc

GTK: Fix browser_tests ViewIDTest.Basic not to expect the page menu.

TBR=evan,estade
BUG=51974
TEST=went green locally.

Review URL: http://codereview.chromium.org/2900004
------------------------------------------------------------------------
r51981 | albertb@chromium.org | 2010-07-09 19:57:26 +0200 (Fri, 09 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.h

Theme sync: Delay the creation of the theme sync node until the user switches
away from the default theme. This is to avoid the server-wins logic from
overwriting custom themes for new sync clients. With this patch, the first
non-default theme that gets synced will be propagated to all clients.

BUG=48155
TEST=manually tested

Review URL: http://codereview.chromium.org/2946001
------------------------------------------------------------------------
r51980 | skrul@chromium.org | 2010-07-09 19:51:18 +0200 (Fri, 09 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Use TimedWait everywhere to prevent hangs.
I'm having a hard time reproing this hang locally -- I ran the test for several days on windows with no hangs.  So this change should prevent any individual test in this test from hanging and hopefully help provide some helpful info when it hangs again.

And since the tests won't hang anymore, I believe we can make them FLAKY.

BUG=39070

Review URL: http://codereview.chromium.org/2864043
------------------------------------------------------------------------
r51979 | thakis@chromium.org | 2010-07-09 19:50:49 +0200 (Fri, 09 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc

Remove unneccessary explicit blacklist.

The heuristic should catch these. Keeping the list just makes it harder to find problems
with the heuristic.

BUG=none
TEST=Still no infobars for single-word queries on any networks.

Review URL: http://codereview.chromium.org/2917007
------------------------------------------------------------------------
r51978 | johnnyg@chromium.org | 2010-07-09 19:40:57 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc

fix the notification continuous-resize problem by preventing scrollbars from being used until the maximum size is reached.

BUG=48494
TEST=create notifications of various sizes, watch for jitter

Review URL: http://codereview.chromium.org/2941003
------------------------------------------------------------------------
r51977 | sdoyon@chromium.org | 2010-07-09 19:35:08 +0200 (Fri, 09 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h

Add --allow-scripting-gallery command line switch to allow extensions
and scripts to run on the Chrome Extensions Gallery site. There are
security concerns in enabling this and so it remains off by default,
but this is needed for automation testing of the gallery.

Cleanup: Have UserScriptSlave::InjectScripts() return void instead of a bogus bool.

TEST=Visit http://chrome.google.com/extensions, check that content scripts work when the command-line switch is given, and are not injected when the switch is not given.
BUG=none

Review URL: http://codereview.chromium.org/2912002
------------------------------------------------------------------------
r51976 | johnnyg@chromium.org | 2010-07-09 19:20:53 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc

Current code will definitely crash if ACTION_DELETE is passed to ThemeChangeProcessor, since the error will clear the profile_ without returning, and the profile is accessed later.  Since the code discusses how to process deletes, I think this is the correct fix.

BUG=none
TEST=sync themes and then delete it

Review URL: http://codereview.chromium.org/2913006
------------------------------------------------------------------------
r51975 | tony@chromium.org | 2010-07-09 19:17:59 +0200 (Fri, 09 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Restore the bookmark manager favicon.

The favicon used to be loaded from a png file in
the resources directory.  Since the file is gone,
this no longer works.  Instead, check for the bookmark
manager extension earlier and load the image from the
pak file.

BUG=48218

Review URL: http://codereview.chromium.org/2960002
------------------------------------------------------------------------
r51974 | erg@chromium.org | 2010-07-09 19:16:01 +0200 (Fri, 09 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/app/menus/button_menu_item_model.cc
   M /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc

GTK: Grouped buttons should be equal sizes in new wrench menu.

This completes the linux implementation of the new wrench menu. Turning
on by default. Will watch how this goes.

BUG=45757
TEST=Look at the menu. The size of the "cut," "copy" and "paste" buttons
should be equal.

Review URL: http://codereview.chromium.org/2961001
------------------------------------------------------------------------
r51973 | sky@chromium.org | 2010-07-09 19:05:43 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Nukes the import parameters to ShowAutoFillDialog as they aren't used.

BUG=44620
TEST=none

Review URL: http://codereview.chromium.org/2920004
------------------------------------------------------------------------
r51972 | inferno@chromium.org | 2010-07-09 19:02:09 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Fix eliding, truncation issues with hostnames in security information dialog for windows, linux platforms resp.

BUG=48597
TEST=None

Review URL: http://codereview.chromium.org/2958002
------------------------------------------------------------------------
r51970 | asargent@chromium.org | 2010-07-09 18:56:00 +0200 (Fri, 09 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   D /trunk/src/chrome/common/extensions/docs/experimental.contextMenu.html
   A /trunk/src/chrome/common/extensions/docs/experimental.contextMenus.html (from /trunk/src/chrome/common/extensions/docs/experimental.contextMenu.html:51714)
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   D /trunk/src/chrome/common/extensions/docs/static/experimental.contextMenu.html
   A /trunk/src/chrome/common/extensions/docs/static/experimental.contextMenus.html (from /trunk/src/chrome/common/extensions/docs/static/experimental.contextMenu.html:51714)
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/context_menus/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.js
   M /trunk/src/chrome/test/data/extensions/context_menus/test.js

Some cleanup of the extensions context menu API. 

This CL contains the following:
-Use lower case names for enum values in the create/update properties (eg 'page' instead of 'PAGE')
-Make the top-level API name plural (contextMenus instead of contextMenu)
-Don't fire onclick handlers for a parent menu item when one of its children is clicked on.
-Remove the enabledContexts property for now, to eventually be replaced with a way to programmatically enable/disable.

There are a few more things in the bug that I'll be doing in subsequent CL's.

BUG=48198
TEST=Extensions using the context menu API should work with the changes described above.


Review URL: http://codereview.chromium.org/2887013
------------------------------------------------------------------------
r51969 | johnnyg@chromium.org | 2010-07-09 18:54:10 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc

Pass an EntitySpecifics with delete changes to generalize delete handling (and fix it for typed urls).

BUG=45883
TEST=sync extension/typed url/autofill, verify delete propagation

Review URL: http://codereview.chromium.org/2920002
------------------------------------------------------------------------
r51968 | dhollowa@chromium.org | 2010-07-09 18:28:36 +0200 (Fri, 09 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager_mac.mm

AutoFill DCHECK in AuxiliaryProfilesImpl::GetAddressBookAddresses

Fixes issue with Mac AddressBook "me" profiles where nil address returned was causing DCHECK.

BUG=48629
TEST=Manual, create AddressBook "me" card address with empty address fields but valid country, relaunch debug version of Chrome.

Review URL: http://codereview.chromium.org/2904007
------------------------------------------------------------------------
r51965 | jhawkins@chromium.org | 2010-07-09 17:56:59 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

TTF: Re-enable PrintingLayoutTextTest.Complex by marking it FAILS_.

BUG=7721
TEST=PrintingLayoutTextTest.Complex

Review URL: http://codereview.chromium.org/2939003
------------------------------------------------------------------------
r51964 | nkostylev@google.com | 2010-07-09 17:47:40 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Fix automation test login mode.

BUG=none
TEST=automation tests with --login-screen=login should work.

Review URL: http://codereview.chromium.org/2968001
------------------------------------------------------------------------
r51962 | dhollowa@chromium.org | 2010-07-09 17:34:39 +0200 (Fri, 09 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

AutoFill DCHECK in RenderViewHost::AutocompleteSuggestionsReturned fails.

Fixes case where DCHECK was failing in presence of Autocomplete cancel logic.  The DCHECK in this case was erroneous.  The new logic handles the cancel case
appropriately.

BUG=none
TEST=AutoFillManagerTest.GetFieldSuggestionsForAutocompleteOnly

Review URL: http://codereview.chromium.org/2945003
------------------------------------------------------------------------
r51959 | dhg@chromium.org | 2010-07-09 17:24:23 +0200 (Fri, 09 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/advanced_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_labs.html
   M /trunk/src/chrome/browser/resources/options/options_page.css
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/browser/resources/shared/js/cr.js

Fixing CSS to match the mocks

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2881013
------------------------------------------------------------------------
r51953 | hans@chromium.org | 2010-07-09 15:17:32 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc

Marking BrowserKeyEventsTest.NormalKeyEvents flaky.

BUG=48671
TBR=suzhe

Review URL: http://codereview.chromium.org/2945008
------------------------------------------------------------------------
r51949 | apavlov@chromium.org | 2010-07-09 13:22:46 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Clean up Chromium code to follow message loop reentrancy fix in WebKit (https://bugs.webkit.org/show_bug.cgi?id=41697)

BUG=36438
TEST=DevToolsSanityTest.TestMessageLoopReentrant

Review URL: http://codereview.chromium.org/2965002
------------------------------------------------------------------------
r51941 | ajwong@chromium.org | 2010-07-09 11:55:23 +0200 (Fri, 09 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Disable tests post webkit roll.

Disabling AccessibilityWinBrowserTest.TestRendererAccessibilityTree, and
the media/video-volume-slider.html layout test on mac.

BUG=48655
TEST=none

Review URL: http://codereview.chromium.org/2951005
------------------------------------------------------------------------
r51934 | thakis@chromium.org | 2010-07-09 07:16:20 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.h

Rerun intranet check on network changes.

BUG=35524
TEST=Open chromium while on a "normal" network. Switch to a network that does dns hijacking. Type a single-word query into omnibox and hit return. No "Did you mean to go to http://query" infobar should open.

Review URL: http://codereview.chromium.org/2910001
------------------------------------------------------------------------
r51928 | jrg@chromium.org | 2010-07-09 05:59:33 +0200 (Fri, 09 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc

Increase subprocess test timeout from 30-->45 seconds and re-enable
BrowserTest.ThirtyFourTabs on Mac.  (This test takes <3 seconds on my
machine).  Suspect low memory conditions (or whatever) on the bot;
this test is not problematic per se.

BUG=http://crbug.com/43862
TEST=bots stay green

Review URL: http://codereview.chromium.org/2900002
------------------------------------------------------------------------
r51920 | wtc@chromium.org | 2010-07-09 05:11:15 +0200 (Fri, 09 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Remove an unnecessary null pointer test for |info| in
ResourceDispatcherHost::RemovePendingRequest.

R=davidben
BUG=48210
TEST=none
Review URL: http://codereview.chromium.org/2962001
------------------------------------------------------------------------
r51915 | satorux@chromium.org | 2010-07-09 04:25:01 +0200 (Fri, 09 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.cc

Fix a potential crash in MountLibraryImpl::Init().

This is not a big deal, as the crash does not occur on the netbook.
I encountred a crash when I was trying to run chrome for chrome os with
libcros.so on my Ubuntu workstation. Note that building libcros.so outside
of chroot is very tricky, so no one else probably wants to do that.

TEST=manually
BUG=none

Review URL: http://codereview.chromium.org/2884015
------------------------------------------------------------------------
r51910 | dhollowa@chromium.org | 2010-07-09 01:09:59 +0200 (Fri, 09 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

Revert 51903 - AutoFill Empty profiles and credit cards should not be saved

Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database.

BUG=47742
TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard

Review URL: http://codereview.chromium.org/2897005

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/2904005
------------------------------------------------------------------------
r51908 | avi@chromium.org | 2010-07-09 00:34:38 +0200 (Fri, 09 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
   A /trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/chrome_browser.gypi

Add "save credit card info?" infobar for Autofill.

BUG=http://crbug.com/48114
TEST=none (depends on bug 47428)

Review URL: http://codereview.chromium.org/2949002
------------------------------------------------------------------------
r51906 | pkasting@chromium.org | 2010-07-09 00:33:16 +0200 (Fri, 09 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/bookmark_manager_resources.grd
   M /trunk/src/chrome/browser/resources/net_internals_resources.grd
   M /trunk/src/chrome/browser/resources/shared_resources.grd
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/test/data/reliability/known_crashes.txt
   M /trunk/src/chrome_frame/resources/chrome_frame_resources.grd
   M /trunk/src/net/base/net_resources.grd
   M /trunk/src/webkit/glue/webkit_resources.grd
   M /trunk/src/webkit/tools/test_shell/test_shell_resources.grd

Clean up .grds, step 1: Alphabetize.

BUG=none
TEST=none
------------------------------------------------------------------------
r51905 | oshima@chromium.org | 2010-07-09 00:22:08 +0200 (Fri, 09 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc

Add expectation for MockSystemLibrary->{Add|Remove}Observer
 This was causing gmock warning in browser tests.
Changed cros mocks to StrictMock so that uninteresting call will fail.

BUG=none
TEST=browser tests will not have gmock warning "Uninterested mock function call"

Review URL: http://codereview.chromium.org/2929001
------------------------------------------------------------------------
r51903 | dhollowa@chromium.org | 2010-07-09 00:11:12 +0200 (Fri, 09 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

AutoFill Empty profiles and credit cards should not be saved

Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database.

BUG=47742
TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard

Review URL: http://codereview.chromium.org/2897005
------------------------------------------------------------------------
r51899 | jhawkins@chromium.org | 2010-07-08 23:35:37 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h

AutoFill: Only query the AutoFill server if we've parsed any of the forms.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2880022
------------------------------------------------------------------------
r51898 | erg@chromium.org | 2010-07-08 23:28:04 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/gtk_integers.h
   D /trunk/src/app/gtk_signal.cc
   M /trunk/src/app/gtk_signal.h
   A /trunk/src/app/gtk_signal_registrar.cc (from /trunk/src/app/gtk_signal.cc:51805)
   A /trunk/src/app/gtk_signal_registrar.h
   M /trunk/src/base/basictypes.h
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/cairo_cached_surface.cc
   M /trunk/src/chrome/browser/gtk/cairo_cached_surface.h
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/hover_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.cc
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.h
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/gtk/update_recommended_dialog.cc
   M /trunk/src/chrome/browser/gtk/update_recommended_dialog.h
   M /trunk/src/views/widget/tooltip_window_gtk.cc
   M /trunk/src/views/widget/tooltip_window_gtk.h

GTK: Minimize usage of gtk headers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2891006
------------------------------------------------------------------------
r51879 | shess@chromium.org | 2010-07-08 21:55:58 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Bring https:// coloring into line with views.

BUG=43602
TEST=Good https:// sites are always green, never blue.

Review URL: http://codereview.chromium.org/2805078
------------------------------------------------------------------------
r51876 | jrg@chromium.org | 2010-07-08 21:19:18 +0200 (Thu, 08 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Fix disabled unit test.
Certain calls now go direct to barController, not parentController.
These changes bounce callbacks back to parentController in test code to be seen.

BUG=none
TEST=green tree

Review URL: http://codereview.chromium.org/2904001
------------------------------------------------------------------------
r51872 | estade@chromium.org | 2010-07-08 21:05:34 +0200 (Thu, 08 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

GTK: improve bookmark menu subfolder drag workaround.

The workaround that allows us to drag folders was causing strange behavior under certain circumstances (see bug). The solution is to select and then activate the subfolder, rather than trying to popup the submenu manually.

BUG=45891
TEST=a) see bug.
b) open bookmark folder, hover over subfolder. Repeated clicking should open/close the submenu.

Review URL: http://codereview.chromium.org/2830040
------------------------------------------------------------------------
r51870 | pkasting@chromium.org | 2010-07-08 20:49:10 +0200 (Thu, 08 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   A /trunk/src/chrome/browser/views/shell_dialogs_win_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Clean up and simplify how we deal with filename extensions on Windows.  Allow users to use any name or extension they want, and only append the "desired" extension when the user's name doesn't have any known extension.  Original patch by Jared Wein (see http://codereview.chromium.org/2825010 ), r=me.

BUG=7499
TEST=Right-click on link, choose "Save link as...", leave the file type as the default but change the file name to have a different extension.  Ensure that the browser doesn't append the original extension.
Review URL: http://codereview.chromium.org/2893001
------------------------------------------------------------------------
r51869 | thakis@chromium.org | 2010-07-08 20:37:44 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc

Gtk: Change content settings window to use a list instead of tabs.

BUG=46965
TEST=Open content settings window. Should look more like it does on windows.

Review URL: http://codereview.chromium.org/2757005
------------------------------------------------------------------------
r51868 | tony@chromium.org | 2010-07-08 20:28:26 +0200 (Thu, 08 Jul 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/tools/grit/grit/format/rc.py
   M /trunk/src/tools/grit/grit/node/include.py

Allow data_packages outputs to include flattened items without
rc_all outputs.

This fixes a bug where the code to flatten an html file was in
the rc_all output step.  So if a data_package output came before
the rc_all output in the grd file, we would get a build error.

Just refactor the code to flatten for both output types (but only
flatten once).

BUG=48253
TEST=build completes succesfully

Review URL: http://codereview.chromium.org/2889001
------------------------------------------------------------------------
r51867 | evan@chromium.org | 2010-07-08 20:25:10 +0200 (Thu, 08 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/net/base/listen_socket_unittest.cc

Mark two tests flaky.

They triy to use a timeout to reduce flakiness, but that only
makes them fail less often; they are still not completely reliable.

BUG=48562

Review URL: http://codereview.chromium.org/2901003
------------------------------------------------------------------------
r51862 | evan@chromium.org | 2010-07-08 19:49:05 +0200 (Thu, 08 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/base/file_util_deprecated.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   M /trunk/src/chrome/tools/convert_dict/dic_reader.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/printing/image.h
   M /trunk/src/tools/imagediff/image_diff.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

Deprecate most of the remaining wstring file_util functions.

These still exist on Windows due to being used by the installer,
but by moving them into the Windows-only block we prevent them
from being used in new code.  (I am already finding new code using
some of these!  I am glad to be rid of them.)

BUG=24672

Review URL: http://codereview.chromium.org/2850042
------------------------------------------------------------------------
r51860 | rsesek@chromium.org | 2010-07-08 19:37:23 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model.cc

[Mac] Disable the Encoding menu within the Wrench menu for Chromium-internal pages.

BUG=48157
TEST=Go to about:version or the NTP. Open Wrench-->Tools-->Encoding. All items are disabled.

Review URL: http://codereview.chromium.org/2928001
------------------------------------------------------------------------
r51851 | andybons@chromium.org | 2010-07-08 18:35:53 +0200 (Thu, 08 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   M /trunk/src/chrome/app/theme/reload_Template.pdf
   M /trunk/src/chrome/app/theme/stop_Template.pdf
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Tighten up the top chrome (move the buttons closer, reduce the toolbar height). Replace the stop/reload images with ones that fit the weight better. Also replace the wrench menu icon.

BUG=none
TEST=make sure dat toolbar is TIGHT.
Review URL: http://codereview.chromium.org/2811047
------------------------------------------------------------------------
r51850 | nshkrob@chromium.org | 2010-07-08 18:28:51 +0200 (Thu, 08 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_database.cc

Remove the warning during conversion to TopSites.
Set version back to non-top sites when running without the --top-sites flag.

BUG=none
TEST=chrome --top-sites

Review URL: http://codereview.chromium.org/2844045
------------------------------------------------------------------------
r51849 | skrul@chromium.org | 2010-07-08 18:19:55 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Don't sync prefs::kPerHostZoomLevels

BUG=47359
TEST=verify that page zoom level sync no longer works.

Review URL: http://codereview.chromium.org/2843052
------------------------------------------------------------------------
r51848 | phajdan.jr@chromium.org | 2010-07-08 18:17:05 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc

Linux: remove unnecessary MimeType field from application shortcuts.

BUG=47987
TEST=unit_tests

Review URL: http://codereview.chromium.org/2817052
------------------------------------------------------------------------
r51843 | rsesek@chromium.org | 2010-07-08 16:35:27 +0200 (Thu, 08 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc

[Mac] Restore the individually selected tab from a window when using the History menu,
rather than always (mistakenly) restoring the first one.

Original review: http://codereview.chromium.org/2802029 (r51748). Reverted at r51759.

BUG=47779,48489
TEST=Open a new window, navigate three tabs. Close the window. Select History-->3 Tabs and then choose the middle tab. It is restored properly.

Review URL: http://codereview.chromium.org/2815050
------------------------------------------------------------------------
r51842 | rsesek@chromium.org | 2010-07-08 16:08:25 +0200 (Thu, 08 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Reset to Defaults should reset the startup pages list.

The URLs were actually getting reset, the UI was not updating. The original
issue was that mutable list Preference values could not be observed for
changes. That was worked-around on Mac, but when the broadcast notifications
were implemented (fixing the original issue), the Mac-specific work around was
incompatible and caused an infinte loop. This removes that work-around and
uses the cross-platform functionality.

BUG=48083
TEST=Chromium-->Preferences-->Basics-->Open the following pages. Add a page. Go to Under the Hood and Reset to Defaults. Go to Basics; no pages are in the list.

Review URL: http://codereview.chromium.org/2870048
------------------------------------------------------------------------
r51840 | tfarina@chromium.org | 2010-07-08 15:32:51 +0200 (Thu, 08 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/env_var.cc
   M /trunk/src/base/env_var.h
   M /trunk/src/base/xdg_util_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

base: Add SetEnv() to EnvVarGetter class and get rid of the some ifdefs.

(Note: This was a TODO)

BUG=None
TEST=included

Review URL: http://codereview.chromium.org/2843048
------------------------------------------------------------------------
r51830 | rafaelw@chromium.org | 2010-07-08 06:20:49 +0200 (Thu, 08 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Revert "Add tab menu item to show/hide toolbar for app tabs"

This reverts commit 59293c3552de500e3672558c722c9e252ab8e8dd.

Review URL: http://codereview.chromium.org/2908001
------------------------------------------------------------------------
r51829 | tfarina@chromium.org | 2010-07-08 05:56:17 +0200 (Thu, 08 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/base/sys_info.h
   M /trunk/src/base/sys_info_posix.cc
   M /trunk/src/base/sys_info_unittest.cc
   M /trunk/src/base/sys_info_win.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/courgette/encoded_program.cc

base: Get rid of the deprecated SysInfo::GetEnvVar.

Use the new EnvVarGetter::GetEnv instead.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2876045
------------------------------------------------------------------------
r51825 | rafaelw@chromium.org | 2010-07-08 05:37:50 +0200 (Thu, 08 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add tab menu item to show/hide toolbar for app tabs

Also, never show bookmarks bar on app tabs.

BUG=45540

Review URL: http://codereview.chromium.org/2854038
------------------------------------------------------------------------
r51817 | jrg@chromium.org | 2010-07-08 04:40:44 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Disable broken test for now

TBR=tc@chromium.org


Review URL: http://codereview.chromium.org/2902001
------------------------------------------------------------------------
r51815 | arv@chromium.org | 2010-07-08 04:19:22 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmarks: Select items after user actions such as copy and paste, drag and drop, add page and add folder.

BUG=42785
TEST=Copy paste items and folders, drag and drop items and folders, add pages and folders. The newly added or moved items and folders should be selected.

Review URL: http://codereview.chromium.org/2855037
------------------------------------------------------------------------
r51811 | csilv@chromium.org | 2010-07-08 03:22:41 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc

Mark TwoCommandsOneTab test as FLAKY until it can be fixed.

TBR=jhawkins
BUG=48521
TEST=unit tests no longer red due to this change.
Review URL: http://codereview.chromium.org/2897001
------------------------------------------------------------------------
r51809 | jrg@chromium.org | 2010-07-08 03:09:25 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Fix fullscreen + bookmark bar folders.

BUG=http://crbug.com/42329
TEST=fullscreen.  Open bookmark folder.  Move mouse down.  See chrome stay on screen.

Review URL: http://codereview.chromium.org/2860051
------------------------------------------------------------------------
r51805 | erg@chromium.org | 2010-07-08 02:10:41 +0200 (Thu, 08 Jul 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK: Fix highlight and image colors in the new wrench menu.

- The states weren't being set properly to replicate the menu item
  highlight effect. The button background needs to be STATE_SELECTED
  while the actual widget needs PRELIGHT. This removes a bunch of
  crud.
- The fullscreen button needs to be tinted multiple times to the
  different label states. Now the fullscreen icon is the correct
  label color. Required adding infrastructure for GtkIconSets.

BUG=45757
TEST=All labels and images in buttons should match the normal and
prelight states of the labels in normal menu items. Make sure to
try themes that have different normal and prelight states (DarkLooks)
and themes that have the same color (Ambiance).

Review URL: http://codereview.chromium.org/2864044
------------------------------------------------------------------------
r51804 | jrg@chromium.org | 2010-07-08 02:07:22 +0200 (Thu, 08 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Fix command-click for sub-sub-folders.

BUG=http://crbug.com/45796
TEST=command-click on a bookmark folder which is not a child of the bookmark bar.
Make sure it does "open all in new tabs".

Review URL: http://codereview.chromium.org/2803040
------------------------------------------------------------------------
r51803 | michaeln@chromium.org | 2010-07-08 01:59:05 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc

Fix a crashing bug in IsSSN(str) when presented with non-ascii input.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2858052
------------------------------------------------------------------------
r51799 | jrg@chromium.org | 2010-07-08 01:40:53 +0200 (Thu, 08 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm

Fix muli-folder add in Add Page... sheet.

BUG=http://crbug.com/47877 
TEST=On Bookmark Bar, "Add Page...".
Click Bookmark Bar node, then click "Add Folder".
Click Bookmark Bar node again, then click "Add Folder".
Add any name/URL (e.g. "x" and "x"), then click "OK".
Fix is to make crash into a success.

Review URL: http://codereview.chromium.org/2836050
------------------------------------------------------------------------
r51798 | jrg@chromium.org | 2010-07-08 01:40:46 +0200 (Thu, 08 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Correct bookmark button height and spacing in folders to keep icon integrity.

BUG=http://crbug.com/48016

TEST=Add Some bookmarks that have the Google 'g' logo (e.g. www.google.com, www.google.com/chrome, etc).
Notice rounded corners.
Now place bookmarks in folder and open folder.
Icons should still hsve rounded corners.


Review URL: http://codereview.chromium.org/2815051
------------------------------------------------------------------------
r51796 | pkasting@chromium.org | 2010-07-08 01:38:31 +0200 (Thu, 08 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker_platform_engine_unittest.cc

Clean up spellchecker unittest.  In particular, this:
  * Fixes some errors -- the test is apparently not being run currently, for reasons I'm fixing separately
  * Uses narrow strings instead of wide where there isn't any reason to use wide
  * Prints out the word in question when a failure happens
  * Tries to otherwise clean up the code

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2811046
------------------------------------------------------------------------
r51794 | thakis@chromium.org | 2010-07-08 01:00:32 +0200 (Thu, 08 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver_unittest.mm

Mac: Don't restore very small windows

I'm not sure how the situation in the bug happened, but this should protect us from the effect in the future.

BUG=39625
TEST=unit test

Review URL: http://codereview.chromium.org/2864042
------------------------------------------------------------------------
r51793 | davidben@chromium.org | 2010-07-08 00:55:27 +0200 (Thu, 08 Jul 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/certificate_viewer.cc
   A /trunk/src/chrome/browser/certificate_viewer.h
   A /trunk/src/chrome/browser/cocoa/certificate_viewer.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.h
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_gtk.cc
   A /trunk/src/chrome/browser/views/certificate_viewer_win.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Refactor certificate viewer code behind ShowCertificateViewer

This abstracts away the platform-specific certificate viewer behind a common
function call.

R=wtc,mattm
BUG=none
TEST=Viewing the certificate information on an SSL session continues to work

Review URL: http://codereview.chromium.org/2815024
------------------------------------------------------------------------
r51792 | skrul@chromium.org | 2010-07-08 00:52:05 +0200 (Thu, 08 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc

Mac clients should ignore updates of kAcceptLanguages.
Also add a unit test to make sure the change processor does not explode when it sees updates from the cloud to a preference it does not know about.

BUG=44714
TEST=unit

Review URL: http://codereview.chromium.org/2805077
------------------------------------------------------------------------
r51790 | dcheng@chromium.org | 2010-07-08 00:43:41 +0200 (Thu, 08 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard.h
   A /trunk/src/chrome/browser/clipboard_dispatcher.h
   A /trunk/src/chrome/browser/clipboard_dispatcher_gtk.cc
   A /trunk/src/chrome/browser/clipboard_dispatcher_mac.mm
   A /trunk/src/chrome/browser/clipboard_dispatcher_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webclipboard_impl.h
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.cc
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_clipboard_impl.cc

Implement new Chromium IPCs for copying/dragging.

A new ClipboardDispatcher interface has been added to handle the IPC calls. The new methods don't really belong on the existing Clipboard class, since that class deals with only copy and paste. On Windows and Mac, ClipboardDispatcher will share logic for copy/paste and drag/drop. GTK will have to use two separate code paths.

BUG=31037
TEST=none

Review URL: http://codereview.chromium.org/2842016
------------------------------------------------------------------------
r51788 | asargent@chromium.org | 2010-07-08 00:25:23 +0200 (Thu, 08 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_context_menu_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/context_menus
   A /trunk/src/chrome/test/data/extensions/context_menus/background.html
   A /trunk/src/chrome/test/data/extensions/context_menus/manifest.json
   A /trunk/src/chrome/test/data/extensions/context_menus/test.html
   A /trunk/src/chrome/test/data/extensions/context_menus/test.js
   A /trunk/src/chrome/test/data/extensions/context_menus/test2.html

First cut at an end-to-end browser test for extension context menu API.

BUG=45811
TEST=(This is adding a test to browser_tests)

Review URL: http://codereview.chromium.org/2841037
------------------------------------------------------------------------
r51787 | shess@chromium.org | 2010-07-08 00:20:14 +0200 (Thu, 08 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   A /trunk/src/chrome/browser/cocoa/reload_button.h
   A /trunk/src/chrome/browser/cocoa/reload_button.mm
   A /trunk/src/chrome/browser/cocoa/reload_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/test_event_utils.h
   M /trunk/src/chrome/browser/cocoa/test_event_utils.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Don't change state from stop to reload when hovered.

Hold the reload button state change from stop to reload until the
mouse exits.  Also short-circuit the stop message when the real state
should be reload.  Also prevent multi-clicks from sending multiple
actions.

Toolbar.xib: reload button made kind of ReloadButton.

BUG=47184
TEST=Browse to a slow page, mouse over stop button.  Should not go to reload button when throbber (in tab) stops.
TEST=After page loaded, click stop.  Should not crash.
TEST=Hover over reload button.  Command-r should start a reload and change the button to stop button.

Review URL: http://codereview.chromium.org/2847051
------------------------------------------------------------------------
r51786 | scherkus@chromium.org | 2010-07-08 00:18:46 +0200 (Thu, 08 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/audio_handler.cc
   M /trunk/src/chrome/browser/chromeos/audio_handler.h
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.cc
   M /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.h
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.cc

Asynchronous threaded volume get/set/init
Non-blocking version of init is now being called, and asynchronous set/get of mute and volume is implmenented at PulseAudioMixer level.

The logic has been updated in SystemKeyEventListener so that the audio key behavior follows the latest doc 'Chrome OS Audio Scenarios':
  Increase volume key: unmutes aduio if muted, otherwise increases volume.
  Decrease volume key: do nothing if muted, otherwise decrease volume.
  Mute volume key: always mutes volume.
  UI is displayed after any volume key press.

Currently only the init is being called asynchronously, but the next step will be to add a call allowing asynchronous operation of the volume adjust/unmute sequence from SystemKeyEventListener, and move the ShowVolumeBubble() calls into AudioHandler so that the volume bubble will update once the calls complete on their own thread.

Patch by davej@chromium.org:
http://codereview.chromium.org/2769008/show

BUG=2910
Test=Play video or audio in ChromeOS, and press the system volume up, down, and mute keys to see they follow the above behavior.  Alternating Mute and Increment Volume presses should always bring the volume back to the same level and not creep it upwards.
------------------------------------------------------------------------
r51784 | hclam@chromium.org | 2010-07-08 00:16:42 +0200 (Thu, 08 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_sync_reader.cc

Fix valgrind / heapcheck error in 51743

Handles to the sync socket should be released. The leak of 4 bytes apprantly
is the leaked SyncSocket object.

BUG=51743
TBR=cbentzel

Review URL: http://codereview.chromium.org/2818047
------------------------------------------------------------------------
r51782 | feldstein@chromium.org | 2010-07-07 23:59:06 +0200 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/browser_accessibility.h
   A /trunk/src/chrome/browser/cocoa/browser_accessibility.mm
   A /trunk/src/chrome/browser/cocoa/browser_accessibility_delegate.h
   A /trunk/src/chrome/browser/cocoa/browser_accessibility_unittest.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

First semi-successful attempt at mac accessibility.

Right now the accessibility tree is shipped over at page load, so this doesn't account for any changes to the html, or scrolling/resizing.

BUG=27112
TEST=Use accessibility inspector to inspect various elements of the webpage.

Review URL: http://codereview.chromium.org/2642001
------------------------------------------------------------------------
r51779 | arv@chromium.org | 2010-07-07 23:41:06 +0200 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js

Bookmarks: Fix position of context menu when opened using the keyboard.

After fixing the contextmenu event in WebKit we can no longer rely on the bug/hack/feature that screenX was 0 when the event was generated using the keyboard. We now keep track of keydown and keyup and if the right key was down then we know it was a context menu generated by the keyboard.

BUG= 40073
TEST=Select an bookmark item (or a folder in the bookmark tree). Press Shift+F10. The context menu should be positioned relative to the selected item.

Review URL: http://codereview.chromium.org/2845042
------------------------------------------------------------------------
r51778 | csilv@chromium.org | 2010-07-07 23:32:34 +0200 (Wed, 07 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options.html

Removed extra/unused </style> tag.

BUG=none
TEST=Verify chrome:options loads when using --enable-tabbed-options.
Review URL: http://codereview.chromium.org/2888007
------------------------------------------------------------------------
r51774 | sky@chromium.org | 2010-07-07 22:26:26 +0200 (Wed, 07 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc

Fixes two bugs in wrench menu when shown rtl:
. borders of buttons were drawn incorrectly.
. I was repainting the correct bounds, resulting in mouse hover
  effects not showing up correctly.

BUG=48012
TEST=see bug

Review URL: http://codereview.chromium.org/2845040
------------------------------------------------------------------------
r51772 | davidben@chromium.org | 2010-07-07 22:19:48 +0200 (Wed, 07 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Inform the SSLClientAuthHandler that a request was cancelled

Otherwise it may access a freed URLRequest.

R=agl
BUG=48210
TEST=close tab while certificate selection dialog is open, then submit

Review URL: http://codereview.chromium.org/2858047
------------------------------------------------------------------------
r51770 | csilv@chromium.org | 2010-07-07 22:15:12 +0200 (Wed, 07 Jul 2010) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/advanced_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/advanced_options_handler.h
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.h
   A /trunk/src/chrome/browser/dom_ui/advanced_options_utils_mac.mm
   A /trunk/src/chrome/browser/dom_ui/browser_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/browser_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/dom_ui/personal_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/personal_options_handler.h
   A /trunk/src/chrome/browser/resources/options/advanced_options.html
   A /trunk/src/chrome/browser/resources/options/advanced_options.js
   A /trunk/src/chrome/browser/resources/options/browser_options.html
   A /trunk/src/chrome/browser/resources/options/browser_options.js
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   A /trunk/src/chrome/browser/resources/options/options_page.css
   A /trunk/src/chrome/browser/resources/options/personal_options.html
   A /trunk/src/chrome/browser/resources/options/personal_options.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

- First round implementation of the Advanced (Under the Hood) options panel.
  - All checkboxes are functional, partial functionality for buttons.
  - Download path controls TBD.
  - Security SSL checkboxes on non-Mac platform TBD.
- Added placeholder files for Browser and Personal option panels.
- Moved placeholder CSS into a new options_page.css file.
- Unit testing TBD.

BUG=48482
TEST=Launch browser with --enable-tabbed-options and bring up options window.
Review URL: http://codereview.chromium.org/2830036
------------------------------------------------------------------------
r51766 | rdsmith@google.com | 2010-07-07 21:58:36 +0200 (Wed, 07 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

Fix bug in DeleteAllForURL; deletes entire store instead of just
cookies related to URL (found by inspection.)  Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.

BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51544

Review URL: http://codereview.chromium.org/2857029
------------------------------------------------------------------------
r51763 | viettrungluu@chromium.org | 2010-07-07 21:46:24 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   A /trunk/src/chrome/browser/browser_main_posix.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Start at cleaning up BrowserMain().

BUG=none (or is there?)
TEST=trybots and tests

Review URL: http://codereview.chromium.org/2234006
------------------------------------------------------------------------
r51759 | rsesek@chromium.org | 2010-07-07 21:26:23 +0200 (Wed, 07 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc

Revert 51748 - [Mac] Restore the individually selected tab from a window when using the History menu, rather than always (mistakenly) restoring the first one.

BUG=47779
TEST=Open a new window, navigate three tabs. Close the window. Select History-->3 Tabs and then choose the middle tab. It is restored properly.

Review URL: http://codereview.chromium.org/2802029

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/2806051
------------------------------------------------------------------------
r51748 | rsesek@chromium.org | 2010-07-07 20:47:32 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc

[Mac] Restore the individually selected tab from a window when using the History menu, rather than always (mistakenly) restoring the first one.

BUG=47779
TEST=Open a new window, navigate three tabs. Close the window. Select History-->3 Tabs and then choose the middle tab. It is restored properly.

Review URL: http://codereview.chromium.org/2802029
------------------------------------------------------------------------
r51744 | suzhe@chromium.org | 2010-07-07 20:38:35 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

[chromeos]Update the display name of UK keyboard layout.

BUG=http://crosbug.com/2951
TEST=The name of the UK keyboard layout should be "English (UK) keyboard layout"

Review URL: http://codereview.chromium.org/2810049
------------------------------------------------------------------------
r51743 | hclam@chromium.org | 2010-07-07 20:36:51 +0200 (Wed, 07 Jul 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   A /trunk/src/chrome/browser/renderer_host/audio_sync_reader.cc
   A /trunk/src/chrome/browser/renderer_host/audio_sync_reader.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/media/audio/audio_controller.cc
   M /trunk/src/media/audio/audio_controller.h
   M /trunk/src/media/audio/fake_audio_output_stream.cc

Rewrite AudioRendererHost to use AudioController

This change will move all the audio device methods calls to
AudioController so we can move all the audio related methods calls off the IO
thread. This change will let AudioRendererHost to use the AudioController API.
This involves rewriting the whole AudioRendererHost.

After this patch we can implement proper pause operations that is only possible
if they are hosted on a separated thread due to their blocking nature.

Normal latency mode is fully covered by unit tests, including audio control
operations and data conversation.

Low latency mode using SyncSocket is tested only for stream creation and still
need to handle cases during shutdown when we want SyncSocket to return
immediately.

TEST=unit_tests --gtest_filter=AudioRendererTest.*
BUG=39885

Review URL: http://codereview.chromium.org/2850016
------------------------------------------------------------------------
r51740 | eroman@chromium.org | 2010-07-07 20:04:14 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_source_type_list.h

Log whenever the network IP address changes.

This logs to both LOG(INFO), and also to the NetLog (about:net-internals).

BUG=46822
Review URL: http://codereview.chromium.org/2815046
------------------------------------------------------------------------
r51738 | ajwong@chromium.org | 2010-07-07 20:00:39 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc

Put Chromoting plugin behind a flag.

BUG=48093
TEST=tested that plugin doesn't load w/o --enable-chromoting.

Review URL: http://codereview.chromium.org/2818043
------------------------------------------------------------------------
r51737 | andybons@chromium.org | 2010-07-07 19:57:53 +0200 (Wed, 07 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

[Mac] Initial implementation of app tabs. Loads the app and displays the correct icon (http://cl.ly/97c1b5e22eb32075d497).
Still to be done:
o there should be a much smaller overlap of app tabs with other tabs.
o The toolbar should hide when necessary.
o The context menu for the tab should have the option of hiding/showing the toolbar on a per-app basis.

TEST=none
BUG=45539
Review URL: http://codereview.chromium.org/2847052
------------------------------------------------------------------------
r51736 | dhollowa@chromium.org | 2010-07-07 19:50:58 +0200 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.h

Autocomplete and AutoFill entries are shown combined in the suggestions popup.

These changes merge popup menu suggestions for Autocomplete and AutoFill.  Suggestions are collected from both sources and returned to the renderer as a single list.  This combined list is given to WebKit to display in the suggestions popup.  When the user selects an item in the popup the appropriate result gets filled in the fields.

BUG=41328
TEST=AutoFillManagerTest.*

Review URL: http://codereview.chromium.org/2878020
------------------------------------------------------------------------
r51733 | dhg@chromium.org | 2010-07-07 19:34:51 +0200 (Wed, 07 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/labs_handler.h
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options/chromeos_labs.html
   M /trunk/src/chrome/browser/resources/options/options_page.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi

Adding labs to the chromeos options page

Review URL: http://codereview.chromium.org/2800035
------------------------------------------------------------------------
r51732 | stevenjb@chromium.org | 2010-07-07 19:34:22 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc

Replaced IsOnlyLeftMouseButton() with IsLeftMouseButton() in PanelController::TitleMousePressed.
http://code.google.com/p/chromium-os/issues/detail?id=4255
BUG=chromium-os:4255
TEST=See Issue for repro

Review URL: http://codereview.chromium.org/2834037
------------------------------------------------------------------------
r51730 | evan@chromium.org | 2010-07-07 19:32:53 +0200 (Wed, 07 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/memory_details_linux.cc

Add Iceweasel to the list of browsers shown in about:memory.

BUG=44602

Based on a patch from Giuseppe Iuculano <giuseppe@iuculano.it>.
------------------------------------------------------------------------
r51728 | nshkrob@chromium.org | 2010-07-07 19:19:02 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   D /trunk/src/chrome/browser/thumbnail_store.cc
   D /trunk/src/chrome/browser/thumbnail_store.h
   D /trunk/src/chrome/browser/thumbnail_store_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_profile.h

Remove ThumbnailStore - replaced by TopSites.

BUG=none
TEST=open New Tab page, see thumbnails. Same with chrome --top-sites.

Review URL: http://codereview.chromium.org/2815045
------------------------------------------------------------------------
r51724 | tim@chromium.org | 2010-07-07 19:05:22 +0200 (Wed, 07 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h

Fix sync startup ordering to make sense and be less broken (though not perfect yet).
Trigger OnBackendInitialized when the syncable::Directory is opened, and cue the DataTypeManager when that happens.

Fix a bug where entering the wrong password on re-login UI results in inability to log in to sync forever, as the UI gets stuck in the "Authenticating...' state.

Overhaul the tests to
1) actually use the abstract superclass and not copy/paste the same code (and redefine the same variables, shadowing protected ones in the super!),
2) to not use two SyncBackendHost objects, which makes it really confusing to follow what's happening,
3) not rely on anonymous OnStateChanged() notifications to perform crucial init tasks (which was also really confusing and brittle) by either a) removing the need to listen altogether, or b) listen for specific notifications.
4) unify root node creation, and 
5) kill verbose and self proclaimed "uninteresting" gmock output.

BUG=47957
TEST=unit_tests (ProfileSync*)

Review URL: http://codereview.chromium.org/2834032
------------------------------------------------------------------------
r51723 | sky@chromium.org | 2010-07-07 18:40:15 +0200 (Wed, 07 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_controller.h

Improves responsiveness when rapdily clicking to close tabs. If the
tab is already closing it's possible for the tab to no longer contain
the coordinates of the release event. I've changed it so that if the
tab is closing and the tab doesn't contain the mouse on the release
event we see if another tab does and if so close it.

BUG=48209
TEST=none

Review URL: http://codereview.chromium.org/2841038
------------------------------------------------------------------------
r51719 | sky@chromium.org | 2010-07-07 17:47:38 +0200 (Wed, 07 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h

Fixes menus when shown by way of pressing alt-f. I need to turn on
nested tasks as in some situations the menu may be shown when the
message loop is processing a task. If the message loop is processing a
taskand we don't set nested tasks allowed to true then none of the
tasks scheduled by the menu (paints, delays...) are processed and the
menu appears totally broken.

BUG=48102
TEST=give focus to the page, press alt-f, press arrow keys and make
     sure the menu updates appropriately.

Review URL: http://codereview.chromium.org/2836044
------------------------------------------------------------------------
r51718 | sky@chromium.org | 2010-07-07 17:38:19 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/app/theme/tab_close_dot_mask.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   D /trunk/src/chrome/browser/views/tabs/tab_strip_interactive_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/event.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h

Bye bye tab close dot, we hardly knew you.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2813045
------------------------------------------------------------------------
r51716 | dhg@chromium.org | 2010-07-07 17:20:57 +0200 (Wed, 07 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   M /trunk/src/chrome/browser/resources/options/chromeos_system_options.js

Fixing chromeos build of the options. They were asserting becuase of a lack of a setting.

BUG=none
TEST=none.
Review URL: http://codereview.chromium.org/2858048
------------------------------------------------------------------------
r51713 | bauerb@chromium.org | 2010-07-07 16:49:31 +0200 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/default_plugin_uitest.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc

Fix a bug effectively disabling the default plugin.

Also, re-enable DefaultPluginUITest.DefaultPluginLoadTest.

BUG=48388,46662
TEST=DefaultPluginUITest.DefaultPluginLoadTest

Review URL: http://codereview.chromium.org/2854041
------------------------------------------------------------------------
r51707 | jeremy@chromium.org | 2010-07-07 13:31:52 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm

Mac: Change translate infobar gradients to light grey.

BUG=39813
TEST=translate infobars should have a very light gray gradient background.

Review URL: http://codereview.chromium.org/2814049
------------------------------------------------------------------------
r51700 | yusukes@google.com | 2010-07-07 10:30:47 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc

Pass the correct flag to input_method::GetInputMethodIdsFromLanguageCode() function.

BUG=chromium-os:4575
TEST=see the bug

Review URL: http://codereview.chromium.org/2884017
------------------------------------------------------------------------
r51699 | yusukes@google.com | 2010-07-07 09:40:59 +0200 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

Remove false warning.

Obviously we don't have to write an error log when |type| is kKeyboardLayoutsOnly.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2871037
------------------------------------------------------------------------
r51698 | yusukes@google.com | 2010-07-07 08:48:54 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

Add string resources for ibus-chewing.

BUG=chromium-os:4570
TEST=started ibus-chewing, toggled properties, then verified there were no errors in /home/chronos/chrome_log.

Review URL: http://codereview.chromium.org/2836049
------------------------------------------------------------------------
r51694 | yusukes@google.com | 2010-07-07 07:41:12 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc

Fix typo in input_method_util.cc.

BUG=chromium-os:4565
TEST=none

Review URL: http://codereview.chromium.org/2888002
------------------------------------------------------------------------
r51693 | satorux@chromium.org | 2010-07-07 07:40:59 +0200 (Wed, 07 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc

Do not show shortcut labels when labels are set to empty.

In particular, we should not show shortcut labels when ibus-mozc
shows suggestions.

BUG=chromium-os:4563
TEST=manually with ibus-mozc

Review URL: http://codereview.chromium.org/2855033
------------------------------------------------------------------------
r51692 | thakis@chromium.org | 2010-07-07 07:36:38 +0200 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/DEPS
   M /trunk/src/chrome/common/default_plugin.cc
   A /trunk/src/chrome/default_plugin
   A /trunk/src/chrome/default_plugin/DEPS
   A /trunk/src/chrome/default_plugin/default_plugin.gyp (from /trunk/src/webkit/default_plugin/default_plugin.gyp:51684)
   A /trunk/src/chrome/default_plugin/default_plugin_resources.h (from /trunk/src/webkit/default_plugin/default_plugin_resources.h:51684)
   A /trunk/src/chrome/default_plugin/default_plugin_resources.rc (from /trunk/src/webkit/default_plugin/default_plugin_resources.rc:51684)
   A /trunk/src/chrome/default_plugin/install_dialog.cc (from /trunk/src/webkit/default_plugin/install_dialog.cc:51684)
   A /trunk/src/chrome/default_plugin/install_dialog.h (from /trunk/src/webkit/default_plugin/install_dialog.h:51684)
   A /trunk/src/chrome/default_plugin/plugin_database_handler.cc (from /trunk/src/webkit/default_plugin/plugin_database_handler.cc:51684)
   A /trunk/src/chrome/default_plugin/plugin_database_handler.h (from /trunk/src/webkit/default_plugin/plugin_database_handler.h:51684)
   A /trunk/src/chrome/default_plugin/plugin_impl.h (from /trunk/src/webkit/default_plugin/plugin_impl.h:51684)
   A /trunk/src/chrome/default_plugin/plugin_impl_gtk.cc (from /trunk/src/webkit/default_plugin/plugin_impl_gtk.cc:51684)
   A /trunk/src/chrome/default_plugin/plugin_impl_gtk.h (from /trunk/src/webkit/default_plugin/plugin_impl_gtk.h:51684)
   A /trunk/src/chrome/default_plugin/plugin_impl_mac.h (from /trunk/src/webkit/default_plugin/plugin_impl_mac.h:51684)
   A /trunk/src/chrome/default_plugin/plugin_impl_mac.mm (from /trunk/src/webkit/default_plugin/plugin_impl_mac.mm:51684)
   A /trunk/src/chrome/default_plugin/plugin_impl_win.cc (from /trunk/src/webkit/default_plugin/plugin_impl_win.cc:51684)
   A /trunk/src/chrome/default_plugin/plugin_impl_win.h (from /trunk/src/webkit/default_plugin/plugin_impl_win.h:51684)
   A /trunk/src/chrome/default_plugin/plugin_install_job_monitor.cc (from /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc:51684)
   A /trunk/src/chrome/default_plugin/plugin_install_job_monitor.h (from /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h:51684)
   A /trunk/src/chrome/default_plugin/plugin_main.cc (from /trunk/src/webkit/default_plugin/plugin_main.cc:51684)
   A /trunk/src/chrome/default_plugin/plugin_main.h (from /trunk/src/webkit/default_plugin/plugin_main.h:51684)
   A /trunk/src/chrome/default_plugin/plugins.xml (from /trunk/src/webkit/default_plugin/plugins.xml:51684)
   A /trunk/src/chrome/default_plugin/plugins2.xml (from /trunk/src/webkit/default_plugin/plugins2.xml:51684)
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/renderer/render_view.cc
   D /trunk/src/webkit/default_plugin/DEPS
   D /trunk/src/webkit/default_plugin/default_plugin.gyp
   D /trunk/src/webkit/default_plugin/default_plugin_resources.h
   D /trunk/src/webkit/default_plugin/default_plugin_resources.rc
   D /trunk/src/webkit/default_plugin/default_plugin_shared.h
   D /trunk/src/webkit/default_plugin/install_dialog.cc
   D /trunk/src/webkit/default_plugin/install_dialog.h
   D /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   D /trunk/src/webkit/default_plugin/plugin_database_handler.h
   D /trunk/src/webkit/default_plugin/plugin_impl.h
   D /trunk/src/webkit/default_plugin/plugin_impl_gtk.cc
   D /trunk/src/webkit/default_plugin/plugin_impl_gtk.h
   D /trunk/src/webkit/default_plugin/plugin_impl_mac.h
   D /trunk/src/webkit/default_plugin/plugin_impl_mac.mm
   D /trunk/src/webkit/default_plugin/plugin_impl_win.cc
   D /trunk/src/webkit/default_plugin/plugin_impl_win.h
   D /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc
   D /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h
   D /trunk/src/webkit/default_plugin/plugin_main.cc
   D /trunk/src/webkit/default_plugin/plugin_main.h
   D /trunk/src/webkit/default_plugin/plugins.xml
   D /trunk/src/webkit/default_plugin/plugins2.xml
   A /trunk/src/webkit/glue/plugins/default_plugin_shared.h (from /trunk/src/webkit/default_plugin/default_plugin_shared.h:51684)
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Move default_plugin from webkit/ to chrome/

Second try, first try at http://codereview.chromium.org/2803035 . Also contains http://codereview.chromium.org/2838044 , changes to DEPS files (mostly cleanups), and a change to webkit/glue/plugins/webplugin_delegate_impl_win.cc .

BUG= 48419
TEST=everything still builds

Review URL: http://codereview.chromium.org/2813047
------------------------------------------------------------------------
r51689 | yusukes@google.com | 2010-07-07 06:18:27 +0200 (Wed, 07 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc

Remove logging in SetImeConfig().
The LOG() is too verbose now since it is ensured that the call succeeds.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2803038
------------------------------------------------------------------------
r51688 | satorux@chromium.org | 2010-07-07 05:46:17 +0200 (Wed, 07 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Simplify LanguageConfigModel

Get rid of Init() method from LanguageConfigModel,
and add a call to NotifyPrefChanged() in the constructor.

Along the way, fix a sytle issue in LanguageConfigView.
Per the style guide, model should look like model_, as it's a member variable.

TEST=manually on the netbook.
BUG=none

Review URL: http://codereview.chromium.org/2872031
------------------------------------------------------------------------
r51684 | thakis@chromium.org | 2010-07-07 04:48:34 +0200 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/DEPS
   M /trunk/src/chrome/common/default_plugin.cc
   D /trunk/src/chrome/default_plugin
   M /trunk/src/chrome/renderer/render_view.cc
   A /trunk/src/webkit/default_plugin/DEPS (from /trunk/src/webkit/default_plugin/DEPS:51680)
   A /trunk/src/webkit/default_plugin/default_plugin.gyp (from /trunk/src/webkit/default_plugin/default_plugin.gyp:51680)
   A /trunk/src/webkit/default_plugin/default_plugin_resources.h (from /trunk/src/webkit/default_plugin/default_plugin_resources.h:51680)
   A /trunk/src/webkit/default_plugin/default_plugin_resources.rc (from /trunk/src/webkit/default_plugin/default_plugin_resources.rc:51680)
   A /trunk/src/webkit/default_plugin/default_plugin_shared.h (from /trunk/src/webkit/default_plugin/default_plugin_shared.h:51680)
   A /trunk/src/webkit/default_plugin/install_dialog.cc (from /trunk/src/webkit/default_plugin/install_dialog.cc:51680)
   A /trunk/src/webkit/default_plugin/install_dialog.h (from /trunk/src/webkit/default_plugin/install_dialog.h:51680)
   A /trunk/src/webkit/default_plugin/plugin_database_handler.cc (from /trunk/src/webkit/default_plugin/plugin_database_handler.cc:51680)
   A /trunk/src/webkit/default_plugin/plugin_database_handler.h (from /trunk/src/webkit/default_plugin/plugin_database_handler.h:51680)
   A /trunk/src/webkit/default_plugin/plugin_impl.h (from /trunk/src/webkit/default_plugin/plugin_impl.h:51680)
   A /trunk/src/webkit/default_plugin/plugin_impl_gtk.cc (from /trunk/src/webkit/default_plugin/plugin_impl_gtk.cc:51680)
   A /trunk/src/webkit/default_plugin/plugin_impl_gtk.h (from /trunk/src/webkit/default_plugin/plugin_impl_gtk.h:51680)
   A /trunk/src/webkit/default_plugin/plugin_impl_mac.h (from /trunk/src/webkit/default_plugin/plugin_impl_mac.h:51680)
   A /trunk/src/webkit/default_plugin/plugin_impl_mac.mm (from /trunk/src/webkit/default_plugin/plugin_impl_mac.mm:51680)
   A /trunk/src/webkit/default_plugin/plugin_impl_win.cc (from /trunk/src/webkit/default_plugin/plugin_impl_win.cc:51680)
   A /trunk/src/webkit/default_plugin/plugin_impl_win.h (from /trunk/src/webkit/default_plugin/plugin_impl_win.h:51680)
   A /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc (from /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc:51680)
   A /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h (from /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h:51680)
   A /trunk/src/webkit/default_plugin/plugin_main.cc (from /trunk/src/webkit/default_plugin/plugin_main.cc:51680)
   A /trunk/src/webkit/default_plugin/plugin_main.h (from /trunk/src/webkit/default_plugin/plugin_main.h:51680)
   A /trunk/src/webkit/default_plugin/plugins.xml (from /trunk/src/webkit/default_plugin/plugins.xml:51680)
   A /trunk/src/webkit/default_plugin/plugins2.xml (from /trunk/src/webkit/default_plugin/plugins2.xml:51680)
   D /trunk/src/webkit/glue/plugins/default_plugin_shared.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Revert 51681 - Move default_plugin out of webkit.

BUG=48419

Review URL: http://codereview.chromium.org/2803035

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2819043
------------------------------------------------------------------------
r51681 | thakis@chromium.org | 2010-07-07 03:18:58 +0200 (Wed, 07 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/DEPS
   M /trunk/src/chrome/common/default_plugin.cc
   A /trunk/src/chrome/default_plugin
   A /trunk/src/chrome/default_plugin/DEPS (from /trunk/src/webkit/default_plugin/DEPS:51680)
   A /trunk/src/chrome/default_plugin/default_plugin.gyp (from /trunk/src/webkit/default_plugin/default_plugin.gyp:51680)
   A /trunk/src/chrome/default_plugin/default_plugin_resources.h (from /trunk/src/webkit/default_plugin/default_plugin_resources.h:51680)
   A /trunk/src/chrome/default_plugin/default_plugin_resources.rc (from /trunk/src/webkit/default_plugin/default_plugin_resources.rc:51680)
   A /trunk/src/chrome/default_plugin/install_dialog.cc (from /trunk/src/webkit/default_plugin/install_dialog.cc:51680)
   A /trunk/src/chrome/default_plugin/install_dialog.h (from /trunk/src/webkit/default_plugin/install_dialog.h:51680)
   A /trunk/src/chrome/default_plugin/plugin_database_handler.cc (from /trunk/src/webkit/default_plugin/plugin_database_handler.cc:51680)
   A /trunk/src/chrome/default_plugin/plugin_database_handler.h (from /trunk/src/webkit/default_plugin/plugin_database_handler.h:51680)
   A /trunk/src/chrome/default_plugin/plugin_impl.h (from /trunk/src/webkit/default_plugin/plugin_impl.h:51680)
   A /trunk/src/chrome/default_plugin/plugin_impl_gtk.cc (from /trunk/src/webkit/default_plugin/plugin_impl_gtk.cc:51680)
   A /trunk/src/chrome/default_plugin/plugin_impl_gtk.h (from /trunk/src/webkit/default_plugin/plugin_impl_gtk.h:51680)
   A /trunk/src/chrome/default_plugin/plugin_impl_mac.h (from /trunk/src/webkit/default_plugin/plugin_impl_mac.h:51680)
   A /trunk/src/chrome/default_plugin/plugin_impl_mac.mm (from /trunk/src/webkit/default_plugin/plugin_impl_mac.mm:51680)
   A /trunk/src/chrome/default_plugin/plugin_impl_win.cc (from /trunk/src/webkit/default_plugin/plugin_impl_win.cc:51680)
   A /trunk/src/chrome/default_plugin/plugin_impl_win.h (from /trunk/src/webkit/default_plugin/plugin_impl_win.h:51680)
   A /trunk/src/chrome/default_plugin/plugin_install_job_monitor.cc (from /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc:51680)
   A /trunk/src/chrome/default_plugin/plugin_install_job_monitor.h (from /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h:51680)
   A /trunk/src/chrome/default_plugin/plugin_main.cc (from /trunk/src/webkit/default_plugin/plugin_main.cc:51680)
   A /trunk/src/chrome/default_plugin/plugin_main.h (from /trunk/src/webkit/default_plugin/plugin_main.h:51680)
   A /trunk/src/chrome/default_plugin/plugins.xml (from /trunk/src/webkit/default_plugin/plugins.xml:51680)
   A /trunk/src/chrome/default_plugin/plugins2.xml (from /trunk/src/webkit/default_plugin/plugins2.xml:51680)
   M /trunk/src/chrome/renderer/render_view.cc
   D /trunk/src/webkit/default_plugin/DEPS
   D /trunk/src/webkit/default_plugin/default_plugin.gyp
   D /trunk/src/webkit/default_plugin/default_plugin_resources.h
   D /trunk/src/webkit/default_plugin/default_plugin_resources.rc
   D /trunk/src/webkit/default_plugin/default_plugin_shared.h
   D /trunk/src/webkit/default_plugin/install_dialog.cc
   D /trunk/src/webkit/default_plugin/install_dialog.h
   D /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   D /trunk/src/webkit/default_plugin/plugin_database_handler.h
   D /trunk/src/webkit/default_plugin/plugin_impl.h
   D /trunk/src/webkit/default_plugin/plugin_impl_gtk.cc
   D /trunk/src/webkit/default_plugin/plugin_impl_gtk.h
   D /trunk/src/webkit/default_plugin/plugin_impl_mac.h
   D /trunk/src/webkit/default_plugin/plugin_impl_mac.mm
   D /trunk/src/webkit/default_plugin/plugin_impl_win.cc
   D /trunk/src/webkit/default_plugin/plugin_impl_win.h
   D /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc
   D /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h
   D /trunk/src/webkit/default_plugin/plugin_main.cc
   D /trunk/src/webkit/default_plugin/plugin_main.h
   D /trunk/src/webkit/default_plugin/plugins.xml
   D /trunk/src/webkit/default_plugin/plugins2.xml
   A /trunk/src/webkit/glue/plugins/default_plugin_shared.h (from /trunk/src/webkit/default_plugin/default_plugin_shared.h:51680)
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Move default_plugin out of webkit.

BUG=48419

Review URL: http://codereview.chromium.org/2803035
------------------------------------------------------------------------
r51680 | thakis@chromium.org | 2010-07-07 03:13:27 +0200 (Wed, 07 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm

Mac: Add tooltip to download item.

BUG=41195
TEST=Download file with long name. Dangerous download view shouldn't have tooltip, normal download button should.

Review URL: http://codereview.chromium.org/2835036
------------------------------------------------------------------------
r51678 | chron@chromium.org | 2010-07-07 00:37:59 +0200 (Wed, 07 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/common/net/gaia/gaia_auth_consumer.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.h

Add IssueAuthToken and unit tests to GaiaAuthenticator2.
GaiaAuthConsumer pure virtuals now optional since you can choose to not listen to ClientLogin subscriptions.
Renamed ClientLoginError to a general GaiaAuthError.
BUG=47093
TEST=Unit tests included

Review URL: http://codereview.chromium.org/2834042
------------------------------------------------------------------------
r51677 | dumi@chromium.org | 2010-07-07 00:09:21 +0200 (Wed, 07 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database.cc

Increase the current version of the history index DBs, because of the switch from fts2 to fts3.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/2825037
------------------------------------------------------------------------
r51674 | avayvod@chromium.org | 2010-07-06 20:43:43 +0200 (Tue, 06 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_view.cc

Adjusted both user and camera image size to 256x256.
Eliminated resizing the image upon receiving each frame.

BUG=None
TEST=Test that video image from camera is the same as the selected image on
image screen and positioned at the same level.

Review URL: http://codereview.chromium.org/2817050
------------------------------------------------------------------------
r51673 | thakis@chromium.org | 2010-07-06 20:33:40 +0200 (Tue, 06 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.cc
   M /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/browser/views/options/simple_content_exceptions_view.cc
   M /trunk/src/chrome/browser/views/options/simple_content_exceptions_view.h

Add Notifications pane to content settings.

THIS CHANGES THE BEHAVIOR OF HOW PERMISSIONS WORK:
Previosly an infobar was shown every time an application requested notification permissions.

Now, this is shown only the first time an application requests permissions, and the choice is remembered thereafter. If the kDesktopNotificationDefaultContentSetting preference is set, no infobar is shown at all.

This CL also adds content settings UI to manage the exceptions list on mac, win, and linux.

xib changes: Add a new pane to the content settings tab view, with the right title, radio box strings, actions, and bindings.

BUG=45547
TEST=Go to a site that shows notifications. It should only ask for permissions once, and remember the user choice after that. Content Settings->Notifications->Exceptions should show the exceptions list. The content settings pane should be fully functional, and the radio button options ("don't ask") should have an effect on pages that weren't visited before.

Review URL: http://codereview.chromium.org/2825028
------------------------------------------------------------------------
r51669 | thakis@chromium.org | 2010-07-06 18:45:22 +0200 (Tue, 06 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service_unittest.cc
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.cc
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.h
   M /trunk/src/chrome/browser/notifications/notification_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h

Backend changes for notifications content settings.

NotificationExceptionsTableModel is now functional, and DesktopNotificationService::GetContentSetting contains the new permission behavior. Both aren't used anywhere yet, so still no functionality change (but this is the last CL without functionality changes).

Also add a ton of tests.

BUG=45547
TEST=unit tests

Review URL: http://codereview.chromium.org/2868042
------------------------------------------------------------------------
r51667 | thakis@chromium.org | 2010-07-06 18:03:48 +0200 (Tue, 06 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.cc
   M /trunk/src/chrome/browser/views/options/simple_content_exceptions_view.cc

Rename IDS_GEOLOCATION_EXCEPTION_DIALOG to IDS_SIMPLE_CONTENT_EXCEPTION_DIALOG

Review URL: http://codereview.chromium.org/2850044
------------------------------------------------------------------------
r51666 | joth@chromium.org | 2010-07-06 17:21:42 +0200 (Tue, 06 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

chocobo's comments on http://codereview.chromium.org/2769007/show

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2847023
------------------------------------------------------------------------
r51662 | pfeldman@chromium.org | 2010-07-06 12:36:55 +0200 (Tue, 06 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc

DevTools: follow up to r51661 (64bit build fix).

Review URL: http://codereview.chromium.org/2808047
------------------------------------------------------------------------
r51661 | pfeldman@chromium.org | 2010-07-06 12:13:00 +0200 (Tue, 06 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   A /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.cc
   A /trunk/src/chrome/browser/debugger/devtools_http_protocol_handler.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/net/server/http_listen_socket.cc

DevTools: add stub for HTTP-based remote debugger interface.

Review URL: http://codereview.chromium.org/2802032
------------------------------------------------------------------------
r51657 | hbono@chromium.org | 2010-07-06 11:22:16 +0200 (Tue, 06 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm

An experimental fix for Issue 48361.
This change just adds [shadow release] to release the NSShadow object used in the function. (I'm not totally sure if it is a correct fix, though.)

BUG=48361
TEST=make the "Chromium Mac UI (valgrind)(2)" bot greener.
Review URL: http://codereview.chromium.org/2859044
------------------------------------------------------------------------
r51656 | jochen@chromium.org | 2010-07-06 10:48:23 +0200 (Tue, 06 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ContentBlockedCookies.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h

Display an info link in the blocked cookies info bubble.

The link will pop up a dialog that displays the cookies blocked and accessed by the current page.

The XIB change adds a link-styled button (cell type HyperlinkButtonCell) below the title and above the horizontal line on the bubble with the text IDS_BLOCKED_COOKIES_INFO. The button action is hooked up to showMoreInfo: in the File's Owner.

BUG=45230
TEST=none

Review URL: http://codereview.chromium.org/2799012
------------------------------------------------------------------------
r51655 | mnissler@chromium.org | 2010-07-06 09:48:58 +0200 (Tue, 06 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   A /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.cc
   A /trunk/src/chrome/browser/views/options/managed_prefs_banner_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/gfx/rect.cc
   M /trunk/src/gfx/rect.h
   A /trunk/src/views/box_layout.cc
   A /trunk/src/views/box_layout.h
   A /trunk/src/views/box_layout_unittest.cc
   D /trunk/src/views/examples/box_layout.cc
   D /trunk/src/views/examples/box_layout.h
   M /trunk/src/views/examples/widget_example.h
   M /trunk/src/views/views.gyp

Display warning banner in Win preferences dialog for managed options.

BUG=43423
TEST=box_layout_unittest.cc, manual UI tests.

Review URL: http://codereview.chromium.org/2738002
------------------------------------------------------------------------
r51654 | yusukes@google.com | 2010-07-06 07:52:23 +0200 (Tue, 06 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

ibus-hangul: Use Ctrl+Alt+F9 as a Hanja hot-key instead of F9.
Since F9 is reserved by the window manager on Chrome OS.

BUG=chromium-os:4319
TEST=manually

Review URL: http://codereview.chromium.org/2800039
------------------------------------------------------------------------
r51653 | mazda@chromium.org | 2010-07-06 06:51:56 +0200 (Tue, 06 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Enable the Configure buttons for opening the mozc configuration dialog.

TEST=manually on netbook
BUG=chromium-os:2625

Review URL: http://codereview.chromium.org/2815049
------------------------------------------------------------------------
r51644 | nkostylev@google.com | 2010-07-05 19:37:00 +0200 (Mon, 05 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/helper.cc
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   A /trunk/src/chrome/browser/chromeos/login/password_changed_view.cc
   A /trunk/src/chrome/browser/chromeos/login/password_changed_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/chrome_browser.gypi

Password changed UI.

BUG= http://crosbug.com/323
TEST=Manual. Change password for the account that was previously logged on the device. Observe dialog box.

Review URL: http://codereview.chromium.org/2834041
------------------------------------------------------------------------
r51638 | bauerb@chromium.org | 2010-07-05 15:15:53 +0200 (Mon, 05 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Implement BrowserWindowCocoa::ConfirmAddSearchProvider.

BUG=48327
TEST=Install the Google SSL search extension, click "Add as Search Engine".

Review URL: http://codereview.chromium.org/2803036
------------------------------------------------------------------------
r51636 | satorux@chromium.org | 2010-07-05 13:51:21 +0200 (Mon, 05 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Fix a bug that caused Languages and Input dialog not to be redrawn.

Note that this change works even if 51628 is reverted.

BUG=chromium-os:4555
TEST=manually

Review URL: http://codereview.chromium.org/2822045
------------------------------------------------------------------------
r51635 | pfeldman@chromium.org | 2010-07-05 13:32:40 +0200 (Mon, 05 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_remote.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome_frame/test/test_server.cc
   M /trunk/src/chrome_frame/test/test_server.h
   M /trunk/src/net/base/listen_socket.cc
   M /trunk/src/net/base/listen_socket.h
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/telnet_server.cc
   M /trunk/src/net/net.gyp
   A /trunk/src/net/server
   A /trunk/src/net/server/http_listen_socket.cc
   A /trunk/src/net/server/http_listen_socket.h (from /trunk/src/net/tools/fetch/http_listen_socket.h:51628)
   A /trunk/src/net/server/http_server_request_info.h
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/tools/fetch/http_listen_socket.h

Brushed up listen socket:
- Upstreamed support for partial results from devtools' version
- Made DidRead receive data and length (in order to support websockets data)
- Fixed all the clients.
Added net/server with http socket implementation that supports websockets. Will remove net/tools fetch client and server later.

Review URL: http://codereview.chromium.org/2868036
------------------------------------------------------------------------
r51628 | mnissler@chromium.org | 2010-07-05 09:57:10 +0200 (Mon, 05 Jul 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_am.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/button/native_button_win.h
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.h
   A /trunk/src/views/controls/tabbed_pane/tabbed_pane_unittest.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/examples/tabbed_pane_example.h
   M /trunk/src/views/grid_layout.cc
   M /trunk/src/views/grid_layout.h
   M /trunk/src/views/grid_layout_unittest.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Re-land r51526

Auto-size the views version of the options dialog.

This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery  and sanitizes layouting
of options pages.

BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.

original issuse: http://codereview.chromium.org/2812026/show

Review URL: http://codereview.chromium.org/2883022
------------------------------------------------------------------------
r51625 | mazda@chromium.org | 2010-07-05 07:35:11 +0200 (Mon, 05 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.h

Hide cancel buttons on configuration dialogs.

BUG=chromium-os:4183
TEST=manual

Review URL: http://codereview.chromium.org/2799052
------------------------------------------------------------------------
r51622 | jrg@chromium.org | 2010-07-04 21:45:18 +0200 (Sun, 04 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Cascading menus change growth dirction (right or left) when we hit the
side of the screen.

BUG=42808

TEST=Add a 100-level deep list of folders (or whatever).  
Open them --> grow to the right until side of the screen.
Keep opening subfolders --> starts growing to the left.
Keep going until left side of screen --> grows right again.

Review URL: http://codereview.chromium.org/2802025
------------------------------------------------------------------------
r51605 | tfarina@chromium.org | 2010-07-03 17:03:22 +0200 (Sat, 03 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   D /trunk/src/chrome/browser/sync/util/character_set_converters.h
   D /trunk/src/chrome/browser/sync/util/character_set_converters_posix.cc
   D /trunk/src/chrome/browser/sync/util/character_set_converters_win.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc

sync: Get rid of the now obsolete character_set_converters.h API.

No one is using the utility functions in there, with the one exception.
So fixed that case and removed the obsolete API.

BUG=26443
TEST=trybots

Review URL: http://codereview.chromium.org/2833047
------------------------------------------------------------------------
r51593 | sanjeevr@chromium.org | 2010-07-03 07:47:42 +0200 (Sat, 03 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/browser_child_process_host.cc (from /trunk/src/chrome/browser/child_process_host.cc:51385)
   A /trunk/src/chrome/browser/browser_child_process_host.h (from /trunk/src/chrome/browser/child_process_host.h:51385)
   M /trunk/src/chrome/browser/browser_process_impl.cc
   D /trunk/src/chrome/browser/child_process_host.cc
   D /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details_linux.cc
   M /trunk/src/chrome/browser/memory_details_mac.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service_win.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/profile_import_process_host.cc
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/child_process_host.cc (from /trunk/src/chrome/browser/child_process_host.cc:51385)
   A /trunk/src/chrome/common/child_process_host.h (from /trunk/src/chrome/browser/child_process_host.h:51385)

Moved common parts of ChildProcessHost into chrome/common and created a BrowserChildProcessHost with browser-specific implementation. This is in preparation of creating a ServiceChildProcessHost.
BUG=None
TEST=Test for regressions .

Review URL: http://codereview.chromium.org/2885017
------------------------------------------------------------------------
r51588 | thakis@chromium.org | 2010-07-03 05:14:44 +0200 (Sat, 03 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service_unittest.cc

Attempted build fix: Run IO blocking task actually on IO thread.

TBR=dhollowa

Review URL: http://codereview.chromium.org/2800041
------------------------------------------------------------------------
r51587 | thakis@chromium.org | 2010-07-03 04:29:52 +0200 (Sat, 03 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   A /trunk/src/chrome/browser/notifications/desktop_notification_service_unittest.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h
   A /trunk/src/chrome/browser/notifications/notifications_prefs_cache_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.h

Add a default content setting to the notifications service.

Not yet used anywhere, no behavior change.

BUG=45547
TEST=none (unit tests)

Review URL: http://codereview.chromium.org/2842043
------------------------------------------------------------------------
r51586 | dhollowa@chromium.org | 2010-07-03 04:29:25 +0200 (Sat, 03 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc

AutoFill auxiliary profiles should be off on non-Mac platforms.

These changes conditionally turn off auxiliary profiles at compile time for non-Mac platforms.

BUG=48217
TEST=Manual test on Windows: Surf to a form and trigger AutoFill suggestions.

Review URL: http://codereview.chromium.org/2832049
------------------------------------------------------------------------
r51583 | eroman@chromium.org | 2010-07-03 03:01:19 +0200 (Sat, 03 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   D /trunk/src/chrome/browser/views/about_network_dialog.cc
   D /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Cleanup: Remove about:network.

This about page was only being enabled for non-official windows builds as its UI wasn't cross platform.

Its functionality is now superceded by about:net-internals (which works cross platform and is enabled for all builds).

In fact at some point we might consider renaming about:net-internals to about:network.

BUG=25557
Review URL: http://codereview.chromium.org/2814047
------------------------------------------------------------------------
r51582 | eroman@chromium.org | 2010-07-03 03:01:00 +0200 (Sat, 03 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js

Cleanup: Reword a label from "command line switches" to "command line", as that is more accurate.

BUG=NONE
Review URL: http://codereview.chromium.org/2832048
------------------------------------------------------------------------
r51581 | dhollowa@chromium.org | 2010-07-03 02:58:19 +0200 (Sat, 03 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Remove the AutoFill enable/disable radio from the Options dialog to the AutoFill dialog

These changes remove the AutoFill enabled radio buttons from the Preferences dialog and adds a single checkbox to the AutoFill dialog to do same.  Preferences.xib changes by removing the radio buttons and moving other controls up.  AutoFillDialog.xib adds checkbox to control AutoFill enabled preference.  Also, other controls in AutoFillDialg.xib now bind their enabled states to the value of the enabled checkbox.

BUG=47435
TEST=AutoFillDialogControllerTest.AutoFillEnabled*

Review URL: http://codereview.chromium.org/2799054
------------------------------------------------------------------------
r51578 | zelidrag@chromium.org | 2010-07-03 02:43:52 +0200 (Sat, 03 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/tools/grit/grit/format/html_inline.py
   M /trunk/src/tools/grit/grit/format/rc.py
   M /trunk/src/tools/grit/grit/format/rc_unittest.py

Modified grit to support <if expr="..."> tags within included html files. Removed ChromeOS-specific sub-pages from options by using the newly added if tag. Changed <!--include file="..."--> tag to <include src="...">.

BUG=chromium-os:4450
TEST=make sure that chromeos specific pages don't show in chrome:options for other platforms

Review URL: http://codereview.chromium.org/2872028
------------------------------------------------------------------------
r51576 | vandebo@chromium.org | 2010-07-03 02:00:59 +0200 (Sat, 03 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/net/http/http_cache_transaction.cc

White space changes for grd revert

BUG=none
TEST=green tree
------------------------------------------------------------------------
r51575 | pkasting@chromium.org | 2010-07-03 01:40:58 +0200 (Sat, 03 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/bookmark_manager_resources.grd
   M /trunk/src/chrome/browser/resources/net_internals_resources.grd
   M /trunk/src/chrome/browser/resources/shared_resources.grd
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome_frame/resources/chrome_frame_resources.grd
   M /trunk/src/net/base/net_resources.grd
   M /trunk/src/webkit/glue/webkit_resources.grd
   M /trunk/src/webkit/tools/test_shell/test_shell_resources.grd

Revert 51572 - Clean up .grds, step 1: Alphabetize.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2864039
------------------------------------------------------------------------
r51572 | pkasting@chromium.org | 2010-07-03 00:49:50 +0200 (Sat, 03 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/bookmark_manager_resources.grd
   M /trunk/src/chrome/browser/resources/net_internals_resources.grd
   M /trunk/src/chrome/browser/resources/shared_resources.grd
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome_frame/resources/chrome_frame_resources.grd
   M /trunk/src/net/base/net_resources.grd
   M /trunk/src/webkit/glue/webkit_resources.grd
   M /trunk/src/webkit/tools/test_shell/test_shell_resources.grd

Clean up .grds, step 1: Alphabetize.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041
------------------------------------------------------------------------
r51568 | feldstein@chromium.org | 2010-07-02 23:47:11 +0200 (Fri, 02 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js

Stop using measurements to determine list item

Currently the list uses the list item height and the offsetTop to determine
which item was clicked on.  This doesn't work if the list has no padding, it
thinks you clicked on the one before it.  Now i attach the data item to the
element, and use that to look up the index in the model.

I was also thinking about creating a standard click handler that dispatches an
itemClicked event with that item attached, so subclasses don't all have to
implement the same code.  Do you think this is a good idea, or should we leave
the base class simpler.

BUG=none
TEST=click an item in a list with no padding.

Review URL: http://codereview.chromium.org/2813043
------------------------------------------------------------------------
r51567 | rdsmith@google.com | 2010-07-02 23:23:41 +0200 (Fri, 02 Jul 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

Revert 51544 - I think the chances are noticeably above zero that this
change is responsible for the XP tests (dbg)(4) browser_tests going
red, and we're heading into a long weekend.  I'll revert, and resubmit
next week if it turns out that it wasn't my problem.

Original description:
Fix bug in DeleteAllForURL; deletes entire store instead of just
cookies related to URL (found by inspection.)  Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.

BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)

Review URL: http://codereview.chromium.org/2857029

TBR=rdsmith@google.com
Review URL: http://codereview.chromium.org/2858046
------------------------------------------------------------------------
r51566 | dantasse@chromium.org | 2010-07-02 23:14:53 +0200 (Fri, 02 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Disallow syncing 0 datatypes.

If you try to set up or customize sync, then click "choose data types to sync" and uncheck all of them, then click OK, this will give you an error message ("you must select at least one data type to sync.") and will not start syncing.  This is what we wanted to do with the old dialog box; the only reason we couldn't is that we didn't have time to get a translated string in.

Note that there's enough room on the error message for two lines' worth of text if necessary.

Screenshot in the corresponding bug (47995).

BUG=47995
TEST=try to start syncing, click "choose data types to sync", and uncheck all of them, and click OK.  It should give you an error as described above.

Review URL: http://codereview.chromium.org/2827040
------------------------------------------------------------------------
r51565 | nshkrob@chromium.org | 2010-07-02 22:48:00 +0200 (Fri, 02 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/history/history_database.cc

Use same logic to set NTP pages as without the top-sites flag.

1. Factor out SetPagesValue - this adds prepopulated pages, pinned and blacklisted urls.
2. Add broken camera placeholder for missing thumbnails.
3. Remove 'old database' warning if running without TopSites flag.

BUG=None
TEST=chrome --top-sites; pinned, blacklisted urls work now.

Review URL: http://codereview.chromium.org/2805062
------------------------------------------------------------------------
r51564 | mirandac@google.com | 2010-07-02 22:34:09 +0200 (Fri, 02 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h

Refactor check for organic install into GoogleUpdateSettings, for use elsewhere.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2836041
------------------------------------------------------------------------
r51563 | dhg@chromium.org | 2010-07-02 22:32:05 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Moving mediaplayer and filebrowser behind a preference.  This just adds the preference and sets its default value to false.  After this we'll have to add the UI to set it.

BUG=4362
TEST=none

Review URL: http://codereview.chromium.org/2873032
------------------------------------------------------------------------
r51562 | jcivelli@chromium.org | 2010-07-02 22:29:13 +0200 (Fri, 02 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc

Fixing translate infobar background.
In some cases the infobar background was not the right color.

BUG=48191
TEST=See bug.

Review URL: http://codereview.chromium.org/2808042
------------------------------------------------------------------------
r51559 | thakis@chromium.org | 2010-07-02 22:23:52 +0200 (Fri, 02 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller.mm

Build fix.

http://codereview.chromium.org/2835031 renamed GeolocationExceptionsWindow.xib to SimpleContentExceptionsWindow.xib, but the code was still loading the old nib. This manifests itself only after a clobber build.

Review URL: http://codereview.chromium.org/2878023
------------------------------------------------------------------------
r51558 | sky@chromium.org | 2010-07-02 22:18:25 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc

Fixes bug where clicks any where around the cut/copy/paste menu would
result in a cut, or similarly any where around the zoom buttons would
result in zooming.

BUG=47933
TEST=see bug

Review URL: http://codereview.chromium.org/2872029
------------------------------------------------------------------------
r51555 | rohitrao@chromium.org | 2010-07-02 22:09:16 +0200 (Fri, 02 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds the --enable-in-memory-url-index switch to gate creation and use of the InMemoryURLIndex.

BUG=19736
TEST=No change in behavior when flag is not used.  Should not crash when flag is used.
Review URL: http://codereview.chromium.org/2861041
------------------------------------------------------------------------
r51554 | ben@chromium.org | 2010-07-02 22:03:34 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/win/window_impl.cc
   D /trunk/src/app/win/window_impl.h
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/gfx/gfx.gyp
   A /trunk/src/gfx/window_impl.cc (from /trunk/src/app/win/window_impl.cc:51425)
   A /trunk/src/gfx/window_impl.h (from /trunk/src/app/win/window_impl.h:51425)
   M /trunk/src/tools/memory_watcher/hotkey.h
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/webkit/default_plugin/plugin_impl_win.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h

Move WindowImpl to gfx so I can use it there for canvas unit tests.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2813042
------------------------------------------------------------------------
r51553 | erg@google.com | 2010-07-02 22:01:13 +0200 (Fri, 02 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   A /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Reland r51414: "GTK: Fix sorting in content exception window."

I can't reproduce the heapcheck failure locally, so add a speculative fix.
The class under test uses DeleteSoon(), so let's try adding a RunAllPending().

First Review URL: http://codereview.chromium.org/2876032
BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug. Passes valgrind+heapcheck.

Review URL: http://codereview.chromium.org/2803032
------------------------------------------------------------------------
r51552 | ben@chromium.org | 2010-07-02 21:57:26 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Fix pixel regression on window frame. I had the math here slightly wrong.

http://crbug.com/48134
TEST=none

Review URL: http://codereview.chromium.org/2836045
------------------------------------------------------------------------
r51549 | kinuko@chromium.org | 2010-07-02 21:31:13 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Mark NewTabUITest.ChromeInternalLoadsNTP flaky on all platforms.

They occasionally fail on other platforms too.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NewTabUITest.ChromeInternalLoadsNTP&testType=ui_tests

BUG=45001
TEST=green

Review URL: http://codereview.chromium.org/2825034
------------------------------------------------------------------------
r51547 | tfarina@chromium.org | 2010-07-02 21:03:55 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc

Remove the dead code in bookmark_editor_view.cc.

BUG=None
TEST=Open "Edit Bookmark" dialog. All folders should be expanded as before.

Patch from Satoshi.Matsuzaki <Satoshi.Matsuzaki@gmail.com>

Review URL: http://codereview.chromium.org/2856031
------------------------------------------------------------------------
r51545 | jochen@chromium.org | 2010-07-02 20:24:55 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_notification_task.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.cc
   A /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings.h
   A /trunk/src/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Store blocked and accessed cookies in the tab contents.

This will enable chrome to display all cookies used/blocked on the current site to the user instead of just the information that something was blocked. The cookies are collected in data structures suitable for displaying them using the cookies tree model.

BUG=45230
TEST=none

Review URL: http://codereview.chromium.org/2370001
------------------------------------------------------------------------
r51544 | rdsmith@google.com | 2010-07-02 20:18:07 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

Fix bug in DeleteAllForURL; deletes entire store instead of just
cookies related to URL (found by inspection.)  Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.

BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)

Review URL: http://codereview.chromium.org/2857029
------------------------------------------------------------------------
r51542 | jam@chromium.org | 2010-07-02 20:05:44 +0200 (Fri, 02 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.cc
   M /trunk/src/chrome/common/pepper_plugin_registry.h
   M /trunk/src/webkit/glue/plugins/pepper_url_loader.cc
   M /trunk/src/webkit/glue/plugins/pepper_url_request_info.cc
   M /trunk/src/webkit/glue/plugins/pepper_url_request_info.h

Allow Pepper plugins to make requests with relative urls.  Also allow bundled Pepper plugins to specify file extensions.

BUG=48140
Review URL: http://codereview.chromium.org/2806049
------------------------------------------------------------------------
r51540 | mpcomplete@chromium.org | 2010-07-02 19:54:31 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Add support for omnibox.onInputStarted and onInputCancelled.

Also fix a bug where we'd keep an extension's old keyword even if it changed
on upgrade/reload.

BUG=46475
BUG=48091

Review URL: http://codereview.chromium.org/2807033
------------------------------------------------------------------------
r51536 | avi@chromium.org | 2010-07-02 17:51:05 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc

Don't save SSNs--quick style fix.

BUG=http://crbug.com/46590
TEST=unit test

Review URL: http://codereview.chromium.org/2862042
------------------------------------------------------------------------
r51535 | avi@chromium.org | 2010-07-02 17:42:04 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager_unittest.cc

Don't save SSNs.

BUG=http://crbug.com/46590
TEST=unit test

Review URL: http://codereview.chromium.org/2853027
------------------------------------------------------------------------
r51532 | xiyuan@chromium.org | 2010-07-02 17:25:33 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.h

Don's show star tooltip when BookmarkBubbleView is showing.

BUG=chromium-os:4341
TEST=Verify fix for chromium-os:4341 and tooltips are still visible when bubble is not showing.

Review URL: http://codereview.chromium.org/2867037
------------------------------------------------------------------------
r51529 | mnissler@chromium.org | 2010-07-02 16:55:09 +0200 (Fri, 02 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_am.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/button/native_button_win.h
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.h
   D /trunk/src/views/controls/tabbed_pane/tabbed_pane_unittest.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/examples/tabbed_pane_example.h
   M /trunk/src/views/grid_layout.cc
   M /trunk/src/views/grid_layout.h
   M /trunk/src/views/grid_layout_unittest.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Revert r51526 (Auto-size the views version of the options dialog.)

Unexpected unit_tests crash on chromeos.

TBR: mnissler
------------------------------------------------------------------------
r51526 | mnissler@chromium.org | 2010-07-02 15:46:43 +0200 (Fri, 02 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_am.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/button/native_button_win.h
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.h
   A /trunk/src/views/controls/tabbed_pane/tabbed_pane_unittest.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/examples/tabbed_pane_example.h
   M /trunk/src/views/grid_layout.cc
   M /trunk/src/views/grid_layout.h
   M /trunk/src/views/grid_layout_unittest.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Auto-size the views version of the options dialog.

This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery  and sanitizes layouting
of options pages.

BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.

Review URL: http://codereview.chromium.org/2812026
------------------------------------------------------------------------
r51525 | jochen@chromium.org | 2010-07-02 15:25:31 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/options_util.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor_unittest.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_perftest.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   D /trunk/src/chrome/browser/resources/privacy_blacklist_block.html
   D /trunk/src/chrome/browser/resources/privacy_blacklist_block.png
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   D /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/blacklist.pbl
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   D /trunk/src/chrome/test/data/profiles/blacklist_prefs/Preferences
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Remove abonded privacy blacklist implementation.

BUG=16932
TEST=compiles

Review URL: http://codereview.chromium.org/2862041
------------------------------------------------------------------------
r51522 | jochen@chromium.org | 2010-07-02 14:09:35 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/content_setting_combo_model.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/common/content_settings.h

Add a "session only" policy to the content settings.

session only is treated as allow, but the cookies will expire after this session (the actual code to expire non-html cookies will follow).

BUG=47049
TEST=none

Review URL: http://codereview.chromium.org/2858018
------------------------------------------------------------------------
r51521 | bulach@chromium.org | 2010-07-02 14:05:02 +0200 (Fri, 02 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state_unittest.cc

URLs with repeated domain names requesting tracking information
Check URLs for repeated domain names then if there are any repeated show
the port information of the URL as before if you had two of the same domain
allowed/blocked only one would show in the bubble. Also added some unit tests for it.
(landing on behalf of allanwoj. original review at http://codereview.chromium.org/2832044/show).

BUG=40163
TEST=Two requests within a tab for tracking information with same domain but
different port eg http://www.example.com and https://www.example.com
A test fixture called ShowPortOnSameDomain is in GeolocationSettingsStateTests

Review URL: http://codereview.chromium.org/2847045
------------------------------------------------------------------------
r51515 | akalin@chromium.org | 2010-07-02 12:49:16 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notification_method.cc

Revert 51494 - Set default sync notification method to "server".

BUG=34647
TEST=manual

Review URL: http://codereview.chromium.org/2822044

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/2871035
------------------------------------------------------------------------
r51510 | bauerb@chromium.org | 2010-07-02 11:31:11 +0200 (Fri, 02 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   A /trunk/src/chrome/browser/plugin_updater.cc
   A /trunk/src/chrome/browser/plugin_updater.h
   A /trunk/src/chrome/browser/plugin_updater_unittest.cc
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Group plugins in about:plugins and show update link for out-of-date ones.

Re-landing patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>

Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.

BUG=3910,47858
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Also, if the internal PDF plugin is enabled, it should stay enabled after a restart.

Review URL: http://codereview.chromium.org/2811037
------------------------------------------------------------------------
r51509 | nkostylev@google.com | 2010-07-02 11:00:27 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.h

Update screen refactoring, exit on successful update.

BUG= http://crosbug.com/4002
TEST=Manual: execute OOBE, make sure that update is available, wait for update to complete. If update_engine returns successful update code OOBE will proceed.

Review URL: http://codereview.chromium.org/2807013
------------------------------------------------------------------------
r51507 | jochen@chromium.org | 2010-07-02 09:31:11 +0200 (Fri, 02 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/content_exceptions_table_model.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/views/options/content_exceptions_table_view.cc
   A /trunk/src/chrome/browser/views/options/content_exceptions_table_view.h
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.h

Display content settings applying to the current otr session only.

Also allow for editing them...

The XIB change adds a column at the end of the table with a NSCheckboxCell in it and the title IDS_EXCEPTIONS_OTR_HEADER

BUG=44480
TEST=manual

Review URL: http://codereview.chromium.org/2858032
------------------------------------------------------------------------
r51505 | tim@chromium.org | 2010-07-02 08:21:03 +0200 (Fri, 02 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc

Mark PauseWhenNotConnected as flaky as it keeps timing out,
and ServerDeletingFolderWeHaveAnOpenEntryIn is failing 100% of the time.

BUG=39070, 46621
TEST=Syncer unittest, SyncerThreadTest
TBR=skrul
Review URL: http://codereview.chromium.org/2873039
------------------------------------------------------------------------
r51501 | hamaji@chromium.org | 2010-07-02 07:32:38 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/printing/page_overlays_unittest.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printed_document.h
   M /trunk/src/printing/printed_document_win.cc
   M /trunk/src/printing/printed_page.cc
   M /trunk/src/printing/printed_page.h

Implement limited paged media support for win.

BUG=47277
TEST=none

Review URL: http://codereview.chromium.org/2859040
------------------------------------------------------------------------
r51494 | akalin@chromium.org | 2010-07-02 06:32:45 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notification_method.cc

Set default sync notification method to "server".

BUG=34647
TEST=manual

Review URL: http://codereview.chromium.org/2822044
------------------------------------------------------------------------
r51491 | tim@chromium.org | 2010-07-02 06:17:38 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/cleanup_disabled_types_command.cc
   A /trunk/src/chrome/browser/sync/engine/cleanup_disabled_types_command.h
   A /trunk/src/chrome/browser/sync/engine/cleanup_disabled_types_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

sync: add CleanupDisabledTypesCommand to purge data pertaining to previously
synced data types that the user has disabled.

Despite my attempt at simplifying the purge code in Directory[BackingStore], I had to go back to my first attempt with DeleteEntries (which was previously reviewed separately), with a few extra gotchas in Directory::PurgeEntriesWithTypeIn.

BUG=40252
TEST=CleanupDisabledTypesCommandTest, SyncableDirectoryTest, DirectoryBackingStoreTest

Review URL: http://codereview.chromium.org/2865022
------------------------------------------------------------------------
r51485 | suzhe@chromium.org | 2010-07-02 05:03:18 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc

[Linux]When cancelling a composition, only focus out/in the IM context when it has focus.

Re-apply: http://codereview.chromium.org/2848036
The last commit was messed up.

BUG=http://crosbug.com/4449
TEST=See bug report.

TBR:satorux@chromium.org
------------------------------------------------------------------------
r51483 | tfarina@chromium.org | 2010-07-02 05:01:43 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/extension_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator_mock.h
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h

sync: Remove unused function ChromeModelHasUserCreatedNodes.

(Note: This was a TODO for akalin).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2867036
------------------------------------------------------------------------
r51482 | yusukes@google.com | 2010-07-02 04:57:39 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Use the special language indicator for mozc-dv.

BUG=chromium-os:4157
TEST=manually

Review URL: http://codereview.chromium.org/2843044
------------------------------------------------------------------------
r51481 | kinuko@chromium.org | 2010-07-02 04:43:40 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc

Revert 51480 - [Linux]When cancelling a composition, only focus out/in the IM context when it has focus.

BUG=http://crosbug.com/4449
TEST=See bug report.

Review URL: http://codereview.chromium.org/2856028

TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/2848036
------------------------------------------------------------------------
r51480 | suzhe@chromium.org | 2010-07-02 04:29:34 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc

[Linux]When cancelling a composition, only focus out/in the IM context when it has focus.

BUG=http://crosbug.com/4449
TEST=See bug report.

Review URL: http://codereview.chromium.org/2856028
------------------------------------------------------------------------
r51478 | rafaelw@chromium.org | 2010-07-02 04:00:12 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Implement App Tabs for GTK

BUG=45540
TEST=none

Review URL: http://codereview.chromium.org/2824044
------------------------------------------------------------------------
r51477 | akalin@chromium.org | 2010-07-02 03:56:05 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/sync/notifier/registration_manager_unittest.cc
   M /trunk/src/third_party/cacheinvalidation/cacheinvalidation.gyp
   A /trunk/src/third_party/cacheinvalidation/overrides/google/cacheinvalidation/random.h

Updated cache-invalidation library to @30.

BUG=34647
TEST=sync_listen_notifications

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51330

Review URL: http://codereview.chromium.org/2880008
------------------------------------------------------------------------
r51476 | vandebo@chromium.org | 2010-07-02 03:53:53 +0200 (Fri, 02 Jul 2010) | 38 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   D /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Sorry, this is making the Heapcheck bot unhappy.  http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/4501/steps/heapcheck%20test:%20unit/logs/stdio

i.e.
The 197 largest leaks:
Leak of 128 bytes in 1 objects allocated from:
  @ ed9000 __gnu_cxx::new_allocator::allocate
  @ ed9027 std::_Vector_base::_M_allocate
  @ ed932c std::vector::_M_insert_aux
  @ ed94e4 std::vector::push_back
  @ ed59b2 HostContentSettingsMap::GetSettingsForOneType
  @ 11f2edb ContentExceptionsTableModel
  @ e491e1 ContentExceptionsWindowGtk
  @ 5fdbb7 ContentExceptionsWindowGtkUnittest::BuildWindow
  @ 5facf2 ContentExceptionsWindowGtkUnittest_TestComplexRemoval_Test::TestBody
  @ 15b7dfd testing::Test::Run
  @ 15bb5f2 testing::internal::TestInfoImpl::Run
  @ 15bb728 testing::TestCase::Run
  @ 15bc18a testing::internal::UnitTestImpl::RunAllTests
  @ 15bc301 testing::UnitTest::Run
  @ 14b7b33 TestSuite::Run
  @ 14b627d main
  @ 2b410ff7e1c4 __libc_start_main

Revert 51450 - Reland r51414: "GTK: Fix sorting in content exception window."

Don't use scoped_ptr in unit test. Manually delete the dailog (which deletes
ContentExceptionsWindowGtk.)

First Review URL: http://codereview.chromium.org/2876032
BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug. Ran valgrind on several gtk tests including new ones and fixed the memory errors.

Review URL: http://codereview.chromium.org/2881009

TBR=erg@google.com


Review URL: http://codereview.chromium.org/2876034
------------------------------------------------------------------------
r51475 | estade@chromium.org | 2010-07-02 03:51:48 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h

Hide the browser actions gripper when it's not in use.

BUG=45765
TEST=manual

Review URL: http://codereview.chromium.org/2861040
------------------------------------------------------------------------
r51474 | estade@chromium.org | 2010-07-02 03:50:02 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Add padding in a couple places on the toolbar.

-To the right of the star (inside the URL entry): add 2 pixels.
-Between the tabstrip and window controls: add 16 pixels (only when using the custom frame and the window is maximized).

BUG=47487
TEST=manual

Review URL: http://codereview.chromium.org/2881006
------------------------------------------------------------------------
r51473 | vandebo@chromium.org | 2010-07-02 03:32:09 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc

Disable ExtensionsStartupTest.NoFileAccess on Mac.

BUG=48151
TEST=green tree

Review URL: http://codereview.chromium.org/2856029
------------------------------------------------------------------------
r51466 | gman@chromium.org | 2010-07-02 02:23:37 +0200 (Fri, 02 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

Adds a temporary switch --enable-glsl-translator which 
turns on the OpenGL ES GLSL -> OpenGL GLSL translator
in WebGL.

This will be removed in a few weeks it becomes the default
but we need it now for testing.

TEST=hand tested
BUG=none

Review URL: http://codereview.chromium.org/2815008
------------------------------------------------------------------------
r51462 | dantasse@chromium.org | 2010-07-02 01:55:41 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/app/nibs/SyncCustomize.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   D /trunk/src/chrome/browser/cocoa/sync_customize_controller.h
   D /trunk/src/chrome/browser/cocoa/sync_customize_controller.mm
   D /trunk/src/chrome/browser/cocoa/sync_customize_controller_cppsafe.h
   D /trunk/src/chrome/browser/cocoa/sync_customize_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   D /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc
   D /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/resources/gaia_login_test.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   D /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   D /trunk/src/chrome/browser/views/options/customize_sync_window_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/url_constants.h

Remove the old 'customize sync' panel from win/mac/linux.  And a little bit of leftover references to "merge and sync."

BUG=48125
TEST=Start up sync, change data types, stop sync, etc, nothing should break.

Review URL: http://codereview.chromium.org/2843019
------------------------------------------------------------------------
r51461 | jcivelli@chromium.org | 2010-07-02 01:54:08 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h

Removed TransaleInfoBarDelegate2 left over.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2824047
------------------------------------------------------------------------
r51457 | albertb@chromium.org | 2010-07-02 01:43:00 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Remove NIGORI from the sync routing info.

BUG=47766
TEST=unittest

Review URL: http://codereview.chromium.org/2883015
------------------------------------------------------------------------
r51455 | dpranke@chromium.org | 2010-07-02 01:40:41 +0200 (Fri, 02 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h

Implement UMA tracking for every form that the password manager sees.

We will track how the manager first interprets the form (match found or not,
etc.), what action if any the user takes to change the values, and the result
(form submitted or not, and did it succeed or fail).

    BUG=45946
    R=jcivelli@chromium.org, jar@chromium.org
    TEST=manual testing using about:histograms/PasswordManager and verifying the stats

Review URL: http://codereview.chromium.org/2831033
------------------------------------------------------------------------
r51453 | evan@chromium.org | 2010-07-02 01:19:02 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/base/file_util_deprecated.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Deprecate more old filepath functions.

These still exist on Windows due to being used by the installer,
but by moving them into the Windows-only block we prevent them
from being used in new code.

BUG=24672

Review URL: http://codereview.chromium.org/2861042
------------------------------------------------------------------------
r51452 | andybons@chromium.org | 2010-07-02 01:18:46 +0200 (Fri, 02 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm

[Mac] Darken tab area in accordance with new top chrome refresh.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2804034
------------------------------------------------------------------------
r51451 | jcivelli@chromium.org | 2010-07-02 01:18:21 +0200 (Fri, 02 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.h

Add Never/Always translate buttons to the translate infobar on Linux.

BUG=None
TEST=Visit a page in a language different than the browser language. On the translate infobar, select 'Nope' (don't translate). Repeat 4 times, the 4th time a button 'Never translate' should be available. Test that pressing this button works as expected (further navigations to page in that specific language should not bring a translate infobar).
     Follow the same steps but now click on Translate. You should get an "Always translate" button on the 4th time.

Review URL: http://codereview.chromium.org/2811041
------------------------------------------------------------------------
r51450 | erg@google.com | 2010-07-02 01:16:16 +0200 (Fri, 02 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   A /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Reland r51414: "GTK: Fix sorting in content exception window."

Don't use scoped_ptr in unit test. Manually delete the dailog (which deletes
ContentExceptionsWindowGtk.)

First Review URL: http://codereview.chromium.org/2876032
BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug. Ran valgrind on several gtk tests including new ones and fixed the memory errors.

Review URL: http://codereview.chromium.org/2881009
------------------------------------------------------------------------
r51446 | jianli@chromium.org | 2010-07-02 00:58:03 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc

Fix a crash on XP when we drag a virtual file out of the browser and then close the window.

The fix is to have the TabContentsDragWin destructor destruct drag_source_ since it might be still used by the background dragging thread.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2811039
------------------------------------------------------------------------
r51445 | sky@chromium.org | 2010-07-02 00:51:25 +0200 (Fri, 02 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Makes all tabs openned from the omnibox inherit the opener of the
current tab.

BUG=29933
TEST=see comment #9 in bug for test case.

Review URL: http://codereview.chromium.org/2821026
------------------------------------------------------------------------
r51444 | arv@chromium.org | 2010-07-02 00:43:50 +0200 (Fri, 02 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/new_incognito_tab_theme.css
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/apps.css
   M /trunk/src/chrome/browser/resources/ntp/most_visited.css
   M /trunk/src/chrome/browser/resources_util_unittest.cc
   M /trunk/src/tools/grit/grit/format/resource_map.py

Rename chrome://theme/resource to chrome://theme/IDR_RESOURCE

BUG=47881
TEST=Unit tests

Review URL: http://codereview.chromium.org/2805050
------------------------------------------------------------------------
r51443 | thakis@chromium.org | 2010-07-02 00:43:34 +0200 (Fri, 02 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm

Build fix

TBR=johnnyg

Review URL: http://codereview.chromium.org/2805061
------------------------------------------------------------------------
r51442 | arv@chromium.org | 2010-07-02 00:42:46 +0200 (Fri, 02 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/context_menu_button.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/menu_button.js
   M /trunk/src/chrome/browser/resources/shared_resources.grd

Bookmarks: Show a drop down arrow on the list items on hover.

This is done to give some hints that there is a context menu available.

The class cr.ui.ContextMenuButton can be used to show the context menu of any of its parents.

BUG=43312
TEST=Hover over a bookmark in the bookmark manager. You should see a drop down arrow. Click on that and you should see a working context menu.

Review URL: http://codereview.chromium.org/2832041
------------------------------------------------------------------------
r51437 | chron@chromium.org | 2010-07-02 00:28:23 +0200 (Fri, 02 Jul 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   D /trunk/src/chrome/browser/chromeos/login/mock_login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/net/gaia/gaia_auth_consumer.h
   A /trunk/src/chrome/common/net/gaia/gaia_authenticator2.cc
   A /trunk/src/chrome/common/net/gaia/gaia_authenticator2.h
   A /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.cc
   A /trunk/src/chrome/common/net/gaia/gaia_authenticator2_unittest.h

Split Gaia auth out into common/net. This is in preparation for creating a new Auth service which will issue auth tokens.

I'd like to get it in and continue hacking on it so I can stop colliding so badly with merges.

I've ported over the existing unit tests. Eventually gaia_authenticator.cc is going away. For the time being, i'll be number two.

This is now done, with a pile of unit tests. I am trying to run the interactive tests but I was getting numerous unrelated failures and need to resync ChromiumOS to a working build.

TEST=unit tests, manually log in, out, enter wrong password.
BUG=47091

Review URL: http://codereview.chromium.org/2801015
------------------------------------------------------------------------
r51435 | ananta@chromium.org | 2010-07-02 00:21:10 +0200 (Fri, 02 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field.h

The Chrome form autofill code defines a number of static string16 objects in the header file resulting in
these objects being initialized wherever the form_field.h is included. All this happens during LoadLibrary of
chrome.dll.

Moving the definitions of the string objects to the source file.

Bug=48097

Review URL: http://codereview.chromium.org/2883016
------------------------------------------------------------------------
r51433 | feldstein@chromium.org | 2010-07-02 00:17:05 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm

Fix Bookmark Editor Tree

Notify the data has changed so the bookmark editor tree populates itself.

BUG=47872
TEST=Open a bookmark editor and see if there's a tree

Review URL: http://codereview.chromium.org/2832045
------------------------------------------------------------------------
r51432 | thakis@chromium.org | 2010-07-02 00:16:38 +0200 (Fri, 02 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/common/content_settings_types.h

Add notifications content settings type.

Not used anywhere yet, no functionality change.

 BUG=45547
TEST=none

Review URL: http://codereview.chromium.org/2815042
------------------------------------------------------------------------
r51430 | jhawkins@chromium.org | 2010-07-02 00:06:52 +0200 (Fri, 02 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFill: Remove duplicate suggestions when providing suggestions for a field
in a form that has already been auto-filled.

BUG=47436
TEST=AutoFillManagerTest.GetFieldSuggestionsWithDuplicateValues

Review URL: http://codereview.chromium.org/2855030
------------------------------------------------------------------------
r51427 | vandebo@chromium.org | 2010-07-01 23:44:06 +0200 (Thu, 01 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

This is still timing out.

i.e. http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(1)/builds/25113/steps/sync_unit_tests/logs/stdio

BUG=39070
TEST=SyncerThreadWithSyncerTest.Pause

Review URL: http://codereview.chromium.org/2852038
------------------------------------------------------------------------
r51424 | erg@chromium.org | 2010-07-01 22:51:34 +0200 (Thu, 01 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   D /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert 51415 - GTK: Fix sorting in content exception window.

- Wrap the model in a GtkTreeSortable. This corrects editing of
  content exception entries in the presence of sorted columns.
- Also adds unit tests for this window.

BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug

Review URL: http://codereview.chromium.org/2876032

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2838039
------------------------------------------------------------------------
r51423 | dantasse@chromium.org | 2010-07-01 22:40:36 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Make Keep Everything Synced = true by default

BUG=47756
TEST=start up chrome with a new User Data Dir.  Set up sync -> enter username/pw.  On the "choose data types" screen that comes next, the "keep everything synced" radio button should be selected.

Review URL: http://codereview.chromium.org/2854030
------------------------------------------------------------------------
r51422 | petkov@chromium.org | 2010-07-01 22:38:54 +0200 (Thu, 01 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics.cc

Measure the time it takes to collect external metrics.

As we add more metrics to Chrome OS, it makes sense to monitor this
to ensure it doesn't become a performance issue given that the
code runs every 30 seconds.

BUG=none
TEST=installed on device,looked at about:histograms,ran unit tests

Review URL: http://codereview.chromium.org/2814043
------------------------------------------------------------------------
r51421 | jcivelli@chromium.org | 2010-07-01 22:35:31 +0200 (Thu, 01 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/cocoa/translate/after_translate_infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.h
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.h
   M /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc
   M /trunk/src/chrome/browser/translate/languages_menu_model.h
   D /trunk/src/chrome/browser/translate/languages_menu_model2.cc
   D /trunk/src/chrome/browser/translate/languages_menu_model2.h
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.h
   D /trunk/src/chrome/browser/translate/options_menu_model2.cc
   D /trunk/src/chrome/browser/translate/options_menu_model2.h
   A /trunk/src/chrome/browser/translate/translate_infobar_delegate.cc (from /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc:51418)
   A /trunk/src/chrome/browser/translate/translate_infobar_delegate.h (from /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h:51418)
   D /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   D /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   D /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   D /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   D /trunk/src/chrome/browser/translate/translate_manager2.cc
   D /trunk/src/chrome/browser/translate/translate_manager2.h
   D /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/after_translate_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/after_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.h
   D /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   D /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   M /trunk/src/chrome/browser/views/infobars/translate_message_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/translate_message_infobar.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Renaming TranslateManager2 to TranslateManager
Switching to the new TranslateManager code (renaming TranslateManager2 to TranslateManager and similarly for all similar classes).

Original review:
http://codereview.chromium.org/2825032/show

BUG=40828
TEST=Make sure translate still works as expected on all platforms.

Review URL: http://codereview.chromium.org/2885015
------------------------------------------------------------------------
r51417 | andybons@chromium.org | 2010-07-01 22:25:38 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/DEPS
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   D /trunk/src/chrome/browser/cocoa/third_party/LICENSE
   D /trunk/src/chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.h
   D /trunk/src/chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.m
   D /trunk/src/chrome/browser/cocoa/third_party/README.chromium
   M /trunk/src/chrome/chrome_browser.gypi
   A /trunk/src/third_party/molokocacao
   A /trunk/src/third_party/molokocacao/LICENSE (from /trunk/src/chrome/browser/cocoa/third_party/LICENSE:51367)
   A /trunk/src/third_party/molokocacao/NSBezierPath+MCAdditions.h (from /trunk/src/chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.h:51367)
   A /trunk/src/third_party/molokocacao/NSBezierPath+MCAdditions.m (from /trunk/src/chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.m:51367)
   A /trunk/src/third_party/molokocacao/README.chromium (from /trunk/src/chrome/browser/cocoa/third_party/README.chromium:51367)

[Mac] Moving some new third party code into its proper dir. Also tweak the radius of the close button hover state circle a bit.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833050
------------------------------------------------------------------------
r51416 | skerner@chromium.org | 2010-07-01 22:24:09 +0200 (Thu, 01 Jul 2010) | 16 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/scoped_temp_dir.cc
   M /trunk/src/base/scoped_temp_dir.h
   M /trunk/src/base/scoped_temp_dir_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Loosen permission on extension temp dir when a flag is used.

Issue 35198 can not be reproduced locally.  To enable users to do experiments, three command line flags are added to chrome:

--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.

--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.

--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.

BUG=35198
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51231

Review URL: http://codereview.chromium.org/2802018
------------------------------------------------------------------------
r51415 | erg@chromium.org | 2010-07-01 22:24:00 +0200 (Thu, 01 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   A /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

GTK: Fix sorting in content exception window.

- Wrap the model in a GtkTreeSortable. This corrects editing of
  content exception entries in the presence of sorted columns.
- Also adds unit tests for this window.

BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug

Review URL: http://codereview.chromium.org/2876032
------------------------------------------------------------------------
r51414 | mirandac@google.com | 2010-07-01 22:23:04 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Add UMA logging of clicked tip links.

BUG=48030
TEST=none
Review URL: http://codereview.chromium.org/2859038
------------------------------------------------------------------------
r51409 | sky@chromium.org | 2010-07-01 22:14:50 +0200 (Thu, 01 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/app/gtk_util.h
   M /trunk/src/base/base.gypi
   A /trunk/src/base/gtk_util.cc
   A /trunk/src/base/gtk_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/gfx/canvas_skia_linux.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc

Moves gtk accelerator processing functions to base/gtk_util so I can
use them from views and gfx.

Sorry for the new patch on this and not an update. Not sure what happened.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2809047
------------------------------------------------------------------------
r51408 | sky@chromium.org | 2010-07-01 22:13:34 +0200 (Thu, 01 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc

Fixes bug in pasting bookmarks from the context menu that could result
in inserting into the wrong parent.

BUG=40544
TEST=see bug

Review URL: http://codereview.chromium.org/2856027
------------------------------------------------------------------------
r51405 | thakis@chromium.org | 2010-07-01 22:10:45 +0200 (Thu, 01 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.cc
   A /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.cc
   A /trunk/src/chrome/browser/notifications/notification_exceptions_table_model.h
   A /trunk/src/chrome/browser/notifications/notification_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add NotificationExceptionTableModel.

Methods stubbed out for now, and not used anywhere yet.

BUG=45547
TEST=none

Review URL: http://codereview.chromium.org/2847041
------------------------------------------------------------------------
r51403 | pkasting@chromium.org | 2010-07-01 21:13:52 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/menu_bookmark.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   D /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   D /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/views/controls/button/menu_button.h

Remove the bookmark menu.

BUG=none
TEST=--bookmark-menu no longer does anything
Review URL: http://codereview.chromium.org/2853024
------------------------------------------------------------------------
r51392 | thakis@chromium.org | 2010-07-01 20:26:57 +0200 (Thu, 01 Jul 2010) | 15 lines
Changed paths:
   D /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib
   A /trunk/src/chrome/app/nibs/SimpleContentExceptionsWindow.xib (from /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib:51389)
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   D /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h
   D /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm
   D /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller.h (from /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h:51389)
   A /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller.mm (from /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm:51389)
   A /trunk/src/chrome/browser/cocoa/simple_content_exceptions_window_controller_unittest.mm (from /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller_unittest.mm:51389)
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   D /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc
   D /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.h
   A /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.cc (from /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc:51389)
   A /trunk/src/chrome/browser/gtk/options/simple_content_exceptions_window.h (from /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.h:51389)
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   D /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.cc
   D /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.h
   A /trunk/src/chrome/browser/views/options/simple_content_exceptions_view.cc (from /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.cc:51389)
   A /trunk/src/chrome/browser/views/options/simple_content_exceptions_view.h (from /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.h:51389)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Rename GeolocationExceptionsView, make it more reusable.

Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)

It's now easy to use it to show desktop notification exceptions as well.

No functionality change.

BUG=45547
TEST=geolocation exceptions dialog still works

Review URL: http://codereview.chromium.org/2835031
------------------------------------------------------------------------
r51391 | dpolukhin@chromium.org | 2010-07-01 20:25:08 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Show X button on DevTools window in undocked mode.

BUG=46408
TEST=See bug description.

Review URL: http://codereview.chromium.org/2882007
------------------------------------------------------------------------
r51390 | skerner@chromium.org | 2010-07-01 20:21:54 +0200 (Thu, 01 Jul 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Un-flake and enable test.

Ran tests for a few hours on windows without seeing a failure.

BUG=44026
TEST=BrowserAppRefocusTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51362

Review URL: http://codereview.chromium.org/2870036
------------------------------------------------------------------------
r51389 | dantasse@chromium.org | 2010-07-01 20:19:44 +0200 (Thu, 01 Jul 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html

Put the focus on the OK button if displaying the choose data types page.

This means, if you press enter, it'll work the same as if you clicked OK.
BUG=47752
TEST=Set up sync -> enter username/pw, press enter on choose datatypes screen, it should start syncing and eventually get to "success".

Review URL: http://codereview.chromium.org/2876017
------------------------------------------------------------------------
r51388 | mrossetti@chromium.org | 2010-07-01 20:13:22 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/history/in_memory_url_index.cc
   A /trunk/src/chrome/browser/history/in_memory_url_index.h
   A /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add basic outline for the URL history autocompletion search provider.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2850038
------------------------------------------------------------------------
r51387 | cbentzel@chromium.org | 2010-07-01 20:12:26 +0200 (Thu, 01 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/http/http_auth_controller.cc
   M /trunk/src/net/http/http_auth_controller.h
   M /trunk/src/net/http/http_auth_gssapi_posix.cc
   M /trunk/src/net/http/http_auth_gssapi_posix.h
   M /trunk/src/net/http/http_auth_handler.cc
   M /trunk/src/net/http/http_auth_handler.h
   A /trunk/src/net/http/http_auth_handler_negotiate.cc (from /trunk/src/net/http/http_auth_handler_negotiate_win.cc:51382)
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   D /trunk/src/net/http/http_auth_handler_negotiate_posix.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_unittest.cc
   D /trunk/src/net/http/http_auth_handler_negotiate_win.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.cc
   M /trunk/src/net/http/http_auth_sspi_win.cc
   M /trunk/src/net/http/http_auth_sspi_win.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/mock_sspi_library_win.cc
   M /trunk/src/net/net.gyp

Make the Negotiate Authentication Handler a state machine.

Now that the HttpNetworkTransaction correctly handles asynchronous auth token
generation, HttpAuthHandlerNegotiate can be turned into a state machine. This
also removes the need for the externally exposed "Resolve Canonical Name"
details to users of this handler.

BUG=42222
TEST=net_unittests

Review URL: http://codereview.chromium.org/2867022
------------------------------------------------------------------------
r51384 | nshkrob@chromium.org | 2010-07-01 20:06:25 +0200 (Thu, 01 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h

Store the version info in the History DB's meta table.

Version 18 means use the Favicons file (if the TopSites flag is on).
This avoids the check for a Thumbnails DB file on startup.

BUG=None
TEST=ThumbnailDatabaseTest, HistoryBackendTest

Review URL: http://codereview.chromium.org/2884013
------------------------------------------------------------------------
r51383 | yurys@chromium.org | 2010-07-01 20:04:01 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Roll out 51377 since WebKit roll was reverted

TBR=levin

Review URL: http://codereview.chromium.org/2842039
------------------------------------------------------------------------
r51381 | vandebo@chromium.org | 2010-07-01 19:54:41 +0200 (Thu, 01 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Revert 51379 - Mark svg/W3C-SVG-1.1/filters-conv-01-f.svg as timing out

TBR=levin

Review URL: http://codereview.chromium.org/2847040

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/2858041
------------------------------------------------------------------------
r51379 | yurys@chromium.org | 2010-07-01 19:33:27 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Mark svg/W3C-SVG-1.1/filters-conv-01-f.svg as timing out

TBR=levin

Review URL: http://codereview.chromium.org/2847040
------------------------------------------------------------------------
r51377 | yurys@chromium.org | 2010-07-01 19:18:16 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Disable AccessibilityWinBrowserTest.TestRendererAccessibilityTree which is failing after WebKit roll

TBR=levin

Review URL: http://codereview.chromium.org/2806047
------------------------------------------------------------------------
r51370 | thakis@chromium.org | 2010-07-01 18:17:37 +0200 (Thu, 01 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.h
   M /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc
   A /trunk/src/chrome/browser/remove_rows_table_model.h
   M /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Introduce RemoveRowTableModel interface, let GeolocationExceptionsTableModel derive from it.

No functionality change.

This will be used to share the content settings exceptions dialog code between geolocation and notifications.

BUG=45547

Review URL: http://codereview.chromium.org/2838037
------------------------------------------------------------------------
r51369 | nkostylev@google.com | 2010-07-01 17:45:41 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Temporary fix till new update API is used - ingore update error.

BUG= http://crosbug.com/4321
TEST=Go though OOBE process. When update has initiated and failed update screen proceeds.

Review URL: http://codereview.chromium.org/2836039
------------------------------------------------------------------------
r51368 | yurys@chromium.org | 2010-07-01 17:42:01 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc

Check that BrowserProcess still exists before accessing its methods from DevToolsManager::GetInstance

BUG=47806

Review URL: http://codereview.chromium.org/2878010
------------------------------------------------------------------------
r51367 | andybons@chromium.org | 2010-07-01 17:35:46 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/close_bar.pdf
   D /trunk/src/chrome/app/theme/close_bar_h.pdf
   D /trunk/src/chrome/app/theme/close_bar_p.pdf
   M /trunk/src/chrome/browser/cocoa/hover_close_button.h
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   A /trunk/src/chrome/browser/cocoa/third_party
   A /trunk/src/chrome/browser/cocoa/third_party/LICENSE
   A /trunk/src/chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.h
   A /trunk/src/chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.m
   A /trunk/src/chrome/browser/cocoa/third_party/README.chromium
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi

[Mac] Use Core Graphics to draw the close button used within tabs, infobars, the download shelf and other places. Delete the original pdfs. This is in line with the new top chrome refresh.

BUG=44574
TEST=none
Review URL: http://codereview.chromium.org/2805055
------------------------------------------------------------------------
r51366 | sky@chromium.org | 2010-07-01 17:35:12 +0200 (Thu, 01 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Makes the TabStripModel delete any phantom tabcontents from its
destructor. This isn't really needed now that we've disabled phantom
tabs, but I'm doing in case we end up reenabling phantom tabs.

BUG=45541
TEST=covered by unit test.

Review URL: http://codereview.chromium.org/2800037
------------------------------------------------------------------------
r51365 | skerner@chromium.org | 2010-07-01 17:32:19 +0200 (Thu, 01 Jul 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Revert 51362 - Un-flake and enable test.

Ran tests for a few hours on windows without seeing a failure.

BUG=44026
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/2870036

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/2865031
------------------------------------------------------------------------
r51362 | skerner@chromium.org | 2010-07-01 17:01:23 +0200 (Thu, 01 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Un-flake and enable test.

Ran tests for a few hours on windows without seeing a failure.

BUG=44026
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/2870036
------------------------------------------------------------------------
r51358 | dpolukhin@chromium.org | 2010-07-01 13:05:17 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc

Hide login entries before removing them to prevent flickering.

BUG=none
TEST=Before this change New User sometime blinck after successful login.

Review URL: http://codereview.chromium.org/2878018
------------------------------------------------------------------------
r51355 | dpolukhin@chromium.org | 2010-07-01 12:01:32 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Replace login screen with images login.

BUG=crosbug.com/3280
TEST=See login with on Chrome OS.

Review URL: http://codereview.chromium.org/2848033
------------------------------------------------------------------------
r51347 | hamaji@chromium.org | 2010-07-01 09:04:05 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/print_web_view_helper_mac.mm
   M /trunk/src/printing/page_overlays_unittest.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printed_document.h
   M /trunk/src/printing/printed_document_mac.cc
   M /trunk/src/printing/printed_page.cc
   M /trunk/src/printing/printed_page.h

Implement limited paged media support for mac.

BUG=47277
TEST=none

Review URL: http://codereview.chromium.org/2876020
------------------------------------------------------------------------
r51342 | zork@chromium.org | 2010-07-01 07:04:41 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Preload all IMEs/Layouts for the UI Language on login, if the value has not yet been set.

BUG=chromium-os:3957
TEST=On a new install, set the language to Japanese, log in, and check that English and all Japanese IMEs are enabled.

Review URL: http://codereview.chromium.org/2804032
------------------------------------------------------------------------
r51341 | rsimha@chromium.org | 2010-07-01 07:03:28 +0200 (Thu, 01 Jul 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Nudge syncer thread when notifications are enabled.

Several sync integration tests were failing because the fact that
notifications were enabled was not detected by the sync clients. This
changelist adds a call to NudgeSyncer() in OnNotificationStateChange()
so that the syncer thread is made aware of the fact that notifications
have been enabled. This change caused the integration test pass rate to
increase from ~20% to 90+%.

BUG=47240
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/2814045
------------------------------------------------------------------------
r51340 | yusukes@google.com | 2010-07-01 06:57:50 +0200 (Thu, 01 Jul 2010) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

Implement keyboard layout switching on the login screen.

- login/user_manager.cc

Register a new Local State item, "PreferredKeyboardLayout".

- login/wizard_controller.cc

Set up keyboards for the current locale. For example, when |locale| is "en-US", enable US qwerty and US dvorak keyboard layouts.

- login/language_switch_menu.cc

Enable the keyboard layouts that are necessary for the new locale.

- login/account_screen.h

When the account creation screen is shown, enable input methods (e.g. Chinese, Japanese, Korean) so that users could input their first and last names. Disable them when the screen is closed.

- status/language_menu_button.cc

Update the Locale State when a user switches keyboard layout.

BUG=chromium-os:2619
TEST=manual & the browser_tests

Review URL: http://codereview.chromium.org/2806026
------------------------------------------------------------------------
r51339 | akalin@chromium.org | 2010-07-01 06:48:40 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h

Updated protocol for communicating with sync notifications server.

BUG=34647
TEST=sync_listen_notifications

Review URL: http://codereview.chromium.org/2834033
------------------------------------------------------------------------
r51337 | akalin@chromium.org | 2010-07-01 05:47:51 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc

Fixed crash in sync_listen_notifications on auth failure.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2824043
------------------------------------------------------------------------
r51331 | akalin@chromium.org | 2010-07-01 03:43:50 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Added checks for server-issued notifications.

BUG=34647
TEST=manual

Review URL: http://codereview.chromium.org/2835028
------------------------------------------------------------------------
r51328 | chocobo@chromium.org | 2010-07-01 03:30:52 +0200 (Thu, 01 Jul 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc

Fix login tests by setting up system library mock properly.
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/2841033
------------------------------------------------------------------------
r51327 | aa@chromium.org | 2010-07-01 03:20:59 +0200 (Thu, 01 Jul 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/extensions/api_test/app_process/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path4
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path4/empty.html
   A /trunk/src/chrome/test/data/extensions/manifest_tests/browse_urls_default.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/browse_urls_invalid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/browse_urls_invalid_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/browse_urls_invalid_3.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/browse_urls_valid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/browse_urls_wrong_type.json

Add the concept of browse extent.

BUG=46636

Review URL: http://codereview.chromium.org/2862034
------------------------------------------------------------------------
r51326 | rogerta@google.com | 2010-07-01 03:18:06 +0200 (Thu, 01 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   A /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   A /trunk/src/chrome/browser/extensions/extension_rlz_module.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/rlz
   A /trunk/src/chrome/test/data/extensions/api_test/rlz/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/rlz/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

**Reapply change that caused build break in chromeos/arm**

Add support for RLZ chrome extension api.

BUG=None
TEST=See unit tests as part of this CL.

Review URL: http://codereview.chromium.org/2864024
------------------------------------------------------------------------
r51324 | piman@chromium.org | 2010-07-01 03:06:32 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.cc
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.h

linux: add accelerated compositing.

Similar to Windows, this doesn't handle exposes currently, nor WebGL.
Other caveat: tearing off a tab causes trouble to the gpu process.

Review URL: http://codereview.chromium.org/2886003
------------------------------------------------------------------------
r51322 | jhawkins@chromium.org | 2010-07-01 02:57:33 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address.cc
   M /trunk/src/chrome/browser/autofill/address.h
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   D /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   D /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.h
   D /trunk/src/chrome/browser/autofill/autofill_infobar_delegate_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   M /trunk/src/chrome/browser/autofill/contact_info.h
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field.h
   M /trunk/src/chrome/browser/autofill/credit_card_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card_unittest.cc
   M /trunk/src/chrome/browser/autofill/field_types.h
   M /trunk/src/chrome/browser/autofill/form_group.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_number.cc
   M /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

AutoFill: Aggregate profile data. Remove the AutoFill InfoBar. Remove more remnants of shipping address and CVV.

BUG=47426,47423
TEST=PersonalDataManager.*

Review URL: http://codereview.chromium.org/2818033
------------------------------------------------------------------------
r51311 | chocobo@chromium.org | 2010-07-01 01:18:15 +0200 (Thu, 01 Jul 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_system_library.h
   A /trunk/src/chrome/browser/chromeos/cros/system_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/system_library.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Fix it so that we save timezone properly. We are now going through libcros (instead of a preference) to save the timezone.
BUG=chromium-os:1025
TEST=ClockMenuButtonTest
Review URL: http://codereview.chromium.org/2828024
------------------------------------------------------------------------
r51305 | gspencer@chromium.org | 2010-07-01 00:45:45 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/drop_shadow_label.cc
   A /trunk/src/chrome/browser/chromeos/drop_shadow_label.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.h
   A /trunk/src/chrome/browser/chromeos/wm_overview_fav_icon.cc
   A /trunk/src/chrome/browser/chromeos/wm_overview_fav_icon.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.h
   A /trunk/src/chrome/browser/chromeos/wm_overview_title.cc
   A /trunk/src/chrome/browser/chromeos/wm_overview_title.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h

Adding support for ChromeOS snapshot window titles and favicons.

TEST=build and ran with chromeos-wm
BUG=chromium-os:2866, chromium-os:2867

Review URL: http://codereview.chromium.org/2857005
------------------------------------------------------------------------
r51301 | avayvod@chromium.org | 2010-07-01 00:20:45 +0200 (Thu, 01 Jul 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Put NULL pixmap on GTK windows for login screen.

BUG=cros:4356
TEST=Verify that no window flickers with white background on initial show of login screen.

Review URL: http://codereview.chromium.org/2813040
------------------------------------------------------------------------
r51297 | ben@chromium.org | 2010-07-01 00:02:11 +0200 (Thu, 01 Jul 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/list_background.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/gfx/canvas.h
   M /trunk/src/gfx/canvas_skia.cc
   M /trunk/src/gfx/canvas_skia.h
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/window/dialog_client_view.cc

Canvas refactoring phase 4b:

Add BeginPlatformPaint/EndPlatformPaint calls to gfx::Canvas. BeginPlatformPaint() returns a gfx::NativeDrawingContext.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2840029
------------------------------------------------------------------------
r51296 | sky@chromium.org | 2010-07-01 00:00:42 +0200 (Thu, 01 Jul 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h

Fixes bug in dragging tabs around that could occassionally result in
the tab jumping around. The bug occurred if you dragged a tab from one
tabstrip to another, and was the result of the target tab strip not
knowing a drag is underway.

BUG=47930
TEST=see bug

Review URL: http://codereview.chromium.org/2858038
------------------------------------------------------------------------
r51295 | mpcomplete@chromium.org | 2010-06-30 23:52:07 +0200 (Wed, 30 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/url_pattern_unittest.cc
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Add a wildcard scheme and a special 'all_urls' pattern to URLPattern.

BUG=47179

Review URL: http://codereview.chromium.org/2884008
------------------------------------------------------------------------
r51294 | nshkrob@chromium.org | 2010-06-30 23:46:09 +0200 (Wed, 30 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/app/sql/diagnostic_error_delegate.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Rename the Thumbnails database file to Favicons.
The database will no longer store the thumbnails - TopSites is storing it's own thumbnails.

BUG=None
TEST=ThumbnailDatabaseTest

Review URL: http://codereview.chromium.org/2842034
------------------------------------------------------------------------
r51293 | jcivelli@chromium.org | 2010-06-30 23:45:17 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc

The text in the after translate infobar was incorrect due to an incorrect usage of the std::string substr() API.

BUG=47624
TEST=See bug

Review URL: http://codereview.chromium.org/2876024
------------------------------------------------------------------------
r51290 | stevenjb@chromium.org | 2010-06-30 23:03:34 +0200 (Wed, 30 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Don't generate a certificate browse button or passphrase field if cert path contains SETTINGS:
Made certificate_path_ a string instead of a FilePath.
Modify ConnectToWifiNetwork to take std::string.
BUG=None
TEST=manual

Review URL: http://codereview.chromium.org/2869019
------------------------------------------------------------------------
r51289 | davidben@chromium.org | 2010-06-30 22:19:18 +0200 (Wed, 30 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

Asynchronously generate key pairs for <keygen> tag

We currently hang up the IO thread.

R=wtc
BUG=148
TEST=verify that downloads, etc., are not interrupted by a <keygen>

Review URL: http://codereview.chromium.org/2854007
------------------------------------------------------------------------
r51288 | jcivelli@chromium.org | 2010-06-30 22:13:48 +0200 (Wed, 30 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/browser/translate/translate_manager2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/renderer/translate_helper.cc

Adds support for language detection on the server side.
Relanding: http://codereview.chromium.org/2860037 The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.

Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.

Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.

BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.

Review URL: http://codereview.chromium.org/2854032
------------------------------------------------------------------------
r51286 | mrossetti@chromium.org | 2010-06-30 21:37:53 +0200 (Wed, 30 Jun 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/history/in_memory_url_index.cc
   D /trunk/src/chrome/browser/history/in_memory_url_index.h
   D /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 51284 - Add initial url/title history indexing and search provider support -- not hooked up at this point.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2866025

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/2866035
------------------------------------------------------------------------
r51285 | estade@chromium.org | 2010-06-30 21:03:10 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Add some space to the browser actions toolbar.

This adds space between the button(s) and the overflow chevron (or the separator if there is no overflow menu). It makes the spacing match windows on the right (the left is kind of hard to judge since windows now hides the gripper).

BUG=47487
TEST=manual

Review URL: http://codereview.chromium.org/2857031
------------------------------------------------------------------------
r51284 | mrossetti@chromium.org | 2010-06-30 21:01:22 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/history/in_memory_url_index.cc
   A /trunk/src/chrome/browser/history/in_memory_url_index.h
   A /trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add initial url/title history indexing and search provider support -- not hooked up at this point.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2866025
------------------------------------------------------------------------
r51283 | mpcomplete@chromium.org | 2010-06-30 21:00:27 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fix a regression with chrome.tabs.create() with a chrome-extension URL when
only an incognito window was visible.

BUG=41087

Review URL: http://codereview.chromium.org/2881004
------------------------------------------------------------------------
r51282 | estade@chromium.org | 2010-06-30 20:59:50 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc

Fix translate manager unit test.

This failure was actually due to r51159.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2864029
------------------------------------------------------------------------
r51281 | avayvod@chromium.org | 2010-06-30 20:59:41 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/camera.cc
   M /trunk/src/chrome/browser/chromeos/login/camera.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_screen.cc

Mirror user image taken from camera.

BUG=cros:4372
TEST=Verify that both image from camera and picture taken when camera image is clicked are mirrored.

Review URL: http://codereview.chromium.org/2872021
------------------------------------------------------------------------
r51278 | estade@chromium.org | 2010-06-30 20:57:58 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: always draw popup window custom frame

BUG=47386
TEST=manual

Review URL: http://codereview.chromium.org/2799044
------------------------------------------------------------------------
r51276 | jhawkins@chromium.org | 2010-06-30 20:49:30 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/dock_info_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

TTF: Added unit test for dock_info.

BUG=NONE
TEST=DockInfoTest

Patch by Xiaotian Chen <sargrass@google.com>

Review URL: http://codereview.chromium.org/2805049
------------------------------------------------------------------------
r51272 | suzhe@chromium.org | 2010-06-30 19:49:51 +0200 (Wed, 30 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac]Revert RWHVM to use NSTextInput protocol instead of NSTextInputClient

Using NSTextInputClient protocol somehow causes beep when typing.

BUG=25037 Use NSTextInputClient instead of NSTextInput ?
BUG=47890 [Leopard] Typing any letter beeps in the normal edit box
TEST=Typing in text box should not beep.

Review URL: http://codereview.chromium.org/2810040
------------------------------------------------------------------------
r51266 | erg@chromium.org | 2010-06-30 19:06:21 +0200 (Wed, 30 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/app/menus/button_menu_item_model.cc
   M /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc
   M /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h

GTK: Cleanups to the new wrench menu.

- Make the rendering for multiple buttons pretty by unifying sequnces of
  buttons.
- Add the zoom label control and make the wrench menu model listen for
  notifications about zoom percentage changing.
- Fixes crash that would have gone away once this was taken out from behind a flag

BUG=45757
TEST=none

Review URL: http://codereview.chromium.org/2799043
------------------------------------------------------------------------
r51265 | jcivelli@chromium.org | 2010-06-30 18:59:03 +0200 (Wed, 30 Jun 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/browser/translate/translate_manager2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/renderer/translate_helper.cc

Revert 51263 (breaks the Linux views build)


Adds support for language detection on the server side.
The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.

Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.

Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.

Original review:
http://codereview.chromium.org/2859013/show

BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.

Review URL: http://codereview.chromium.org/2860037

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2873035
------------------------------------------------------------------------
r51263 | jcivelli@chromium.org | 2010-06-30 18:48:02 +0200 (Wed, 30 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   M /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/browser/translate/translate_manager2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/renderer/translate_helper.cc

Adds support for language detection on the server side.
The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.

Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.

Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.

Original review:
http://codereview.chromium.org/2859013/show

BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.

Review URL: http://codereview.chromium.org/2860037
------------------------------------------------------------------------
r51262 | dmazzoni@chromium.org | 2010-06-30 18:37:54 +0200 (Wed, 30 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h

Minor fixes to toolbar keyboard accessibility: focusing the location bar
should select all, accessibility focus should be preserved when the whole
window loses and regains focus, and clicking on the location bar should exit
accessibility focus mode.

BUG=47380
BUG=36070
BUG=47784
TEST=none

Review URL: http://codereview.chromium.org/2833040
------------------------------------------------------------------------
r51261 | stuartmorgan@chromium.org | 2010-06-30 17:57:10 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_uitest.cc

Mark ProcessSingletonTest.StartupRaceCondition as failing on Linux

TBR=erikkay

BUG=47979
TEST=Greener Linux bots

Review URL: http://codereview.chromium.org/2811038
------------------------------------------------------------------------
r51259 | stuartmorgan@chromium.org | 2010-06-30 17:05:04 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc

Mark CommandAgainGoesBackToOptionsTab as failing

TBR=zelidrag

BUG=47977
TEST=Green ChromeOS bot

Review URL: http://codereview.chromium.org/2833043
------------------------------------------------------------------------
r51257 | pinkerton@chromium.org | 2010-06-30 16:25:31 +0200 (Wed, 30 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Ben said make the tab animations faster. Pink smash tab animation!
BUG=45737
TEST=opening and closing tabs really fast
Review URL: http://codereview.chromium.org/2863033
------------------------------------------------------------------------
r51254 | bauerb@chromium.org | 2010-06-30 15:34:05 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/support/webkit_support.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Modify NPAPI::PluginList::GetPluginInfo() to return true also for disabled plugins.

GetPluginInfo() now returns true if the plugin is found, whether it's enabled or not. To find out whether the plugin is enabled, check the enabled flag in the WebPluginInfo struct output parameter. This enables getting information about disabled plugins.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2858035
------------------------------------------------------------------------
r51252 | bauerb@chromium.org | 2010-06-30 15:07:32 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_test_helper.h

Don't crash on a right-aligned link in a LinkInfoBarDelegate.

TEST=LinkInfoBarControllerTest.*
BUG=47728

Review URL: http://codereview.chromium.org/2842031
------------------------------------------------------------------------
r51251 | danno@chromium.org | 2010-06-30 14:24:46 +0200 (Wed, 30 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   M /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   M /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc

Fix multiple issues with ADM/ADMX templates

Correct descriptions in ADM/ADMX template and change registry key to "Chrome" from "Google Chrome".

Fix numerous punctuation, verbiage and wording issues.

Fix HomepageIsNewTabPage so that not checking the checkbox actually forces the hompage to the homepage URL.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2806040
------------------------------------------------------------------------
r51250 | nkostylev@google.com | 2010-06-30 14:01:07 +0200 (Wed, 30 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Mark OOBE process as completed in Local State.
Add 10% when checking for update. If image is not cached on server it will take some time.

BUG= http://crosbug.com/4208, http://crosbug.com/4003
TEST=Manual. Start with fresh install. After Sign In screen is shown, select BWSI and then Sign out. OOBE should not be started again.

Review URL: http://codereview.chromium.org/2833038
------------------------------------------------------------------------
r51249 | dpolukhin@chromium.org | 2010-06-30 13:59:46 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc

Make menu button for language selection focusable on new user login screen.

BUG=crosbug.com/4116
TEST=Language menu should be focusable by keyboard on new user login.

Review URL: http://codereview.chromium.org/2815037
------------------------------------------------------------------------
r51242 | avayvod@chromium.org | 2010-06-30 11:25:47 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

Fixed positions of label and border windows to avoid flickering on initial show of login screen.

BUG=cros:4356
TEST=Verify that no white rectangles flicker near user pods on initial show.

Review URL: http://codereview.chromium.org/2887002
------------------------------------------------------------------------
r51238 | skerner@chromium.org | 2010-06-30 09:19:11 +0200 (Wed, 30 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/scoped_temp_dir.cc
   M /trunk/src/base/scoped_temp_dir.h
   M /trunk/src/base/scoped_temp_dir_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Revert 51231 - Loosen permission on extension temp dir when a flag is used.

Issue 35198 can not be reproduced locally.  To enable users to do experiments, three command line flags are added to chrome:

--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.

--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.

--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.

BUG=35198
TEST=manual

Review URL: http://codereview.chromium.org/2802018

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/2861039
------------------------------------------------------------------------
r51231 | skerner@chromium.org | 2010-06-30 07:57:37 +0200 (Wed, 30 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/scoped_temp_dir.cc
   M /trunk/src/base/scoped_temp_dir.h
   M /trunk/src/base/scoped_temp_dir_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Loosen permission on extension temp dir when a flag is used.

Issue 35198 can not be reproduced locally.  To enable users to do experiments, three command line flags are added to chrome:

--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.

--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.

--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.

BUG=35198
TEST=manual

Review URL: http://codereview.chromium.org/2802018
------------------------------------------------------------------------
r51230 | akalin@chromium.org | 2010-06-30 07:11:53 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   M /trunk/src/chrome/browser/sync/notifier/invalidation_util.cc
   M /trunk/src/chrome/browser/sync/notifier/invalidation_util.h
   A /trunk/src/chrome/browser/sync/notifier/registration_manager.cc
   A /trunk/src/chrome/browser/sync/notifier/registration_manager.h
   A /trunk/src/chrome/browser/sync/notifier/registration_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Decomped registration logic into its own class.

Handle registration events properly.

BUG=34647
TEST=new unittests

Review URL: http://codereview.chromium.org/2861034
------------------------------------------------------------------------
r51226 | akalin@chromium.org | 2010-06-30 06:19:06 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc

Enable extensions sync by default.

BUG=32413
TEST=manual

Review URL: http://codereview.chromium.org/2833042
------------------------------------------------------------------------
r51225 | nick@chromium.org | 2010-06-30 05:57:44 +0200 (Wed, 30 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.h

Remove extended attributes.  The lame broken codepath in the DBS was causing
several tests to fail their SaveChanges()es.  Add unit test for the DBS migrations.

BUG=47466
TEST=sync_unit_tests (and included new tests).

Review URL: http://codereview.chromium.org/2830027
------------------------------------------------------------------------
r51220 | yusukes@google.com | 2010-06-30 05:28:00 +0200 (Wed, 30 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc

Add EnableInputMethodsAndKeyboardLayouts function.

I'll use the function to implement crosbug.com/2619 (Implement input language selector on the log in page)

BUG=none

Review URL: http://codereview.chromium.org/2861022
------------------------------------------------------------------------
r51216 | ajwong@chromium.org | 2010-06-30 04:30:44 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/build/all.gyp
   A /trunk/src/chrome/browser/sync/DEPS
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/DEPS
   M /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/common/net/notifier/DEPS
   D /trunk/src/chrome/common/net/notifier/base/signal_thread_task.h
   D /trunk/src/chrome/common/net/notifier/base/sigslotrepeater.h
   D /trunk/src/chrome/common/net/notifier/base/ssl_adapter.cc
   D /trunk/src/chrome/common/net/notifier/base/ssl_adapter.h
   D /trunk/src/chrome/common/net/notifier/base/static_assert.h
   D /trunk/src/chrome/common/net/notifier/base/task_pump.cc
   D /trunk/src/chrome/common/net/notifier/base/task_pump.h
   D /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.cc
   D /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.h
   D /trunk/src/chrome/common/net/notifier/communicator/connection_options.cc
   D /trunk/src/chrome/common/net/notifier/communicator/connection_options.h
   D /trunk/src/chrome/common/net/notifier/communicator/connection_settings.cc
   D /trunk/src/chrome/common/net/notifier/communicator/connection_settings.h
   D /trunk/src/chrome/common/net/notifier/communicator/const_communicator.h
   D /trunk/src/chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc
   D /trunk/src/chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.h
   D /trunk/src/chrome/common/net/notifier/communicator/login.cc
   D /trunk/src/chrome/common/net/notifier/communicator/login.h
   D /trunk/src/chrome/common/net/notifier/communicator/login_connection_state.h
   D /trunk/src/chrome/common/net/notifier/communicator/login_failure.cc
   D /trunk/src/chrome/common/net/notifier/communicator/login_failure.h
   D /trunk/src/chrome/common/net/notifier/communicator/login_settings.cc
   D /trunk/src/chrome/common/net/notifier/communicator/login_settings.h
   D /trunk/src/chrome/common/net/notifier/communicator/product_info.cc
   D /trunk/src/chrome/common/net/notifier/communicator/product_info.h
   D /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc
   D /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.h
   D /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.cc
   D /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.h
   D /trunk/src/chrome/common/net/notifier/communicator/xmpp_connection_generator.cc
   D /trunk/src/chrome/common/net/notifier/communicator/xmpp_connection_generator.h
   D /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.cc
   D /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.h
   D /trunk/src/chrome/common/net/notifier/listener/listen_task.cc
   D /trunk/src/chrome/common/net/notifier/listener/listen_task.h
   D /trunk/src/chrome/common/net/notifier/listener/mediator_thread.h
   D /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   D /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h
   D /trunk/src/chrome/common/net/notifier/listener/mediator_thread_mock.h
   D /trunk/src/chrome/common/net/notifier/listener/notification_constants.cc
   D /trunk/src/chrome/common/net/notifier/listener/notification_constants.h
   D /trunk/src/chrome/common/net/notifier/listener/notification_defines.h
   D /trunk/src/chrome/common/net/notifier/listener/send_update_task.cc
   D /trunk/src/chrome/common/net/notifier/listener/send_update_task.h
   D /trunk/src/chrome/common/net/notifier/listener/send_update_task_unittest.cc
   D /trunk/src/chrome/common/net/notifier/listener/subscribe_task.cc
   D /trunk/src/chrome/common/net/notifier/listener/subscribe_task.h
   D /trunk/src/chrome/common/net/notifier/listener/subscribe_task_unittest.cc
   D /trunk/src/chrome/common/net/notifier/listener/talk_mediator.h
   D /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.cc
   D /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.h
   D /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc
   D /trunk/src/chrome/common/net/notifier/listener/xml_element_util.cc
   D /trunk/src/chrome/common/net/notifier/listener/xml_element_util.h
   D /trunk/src/chrome/common/net/notifier/listener/xml_element_util_unittest.cc
   A /trunk/src/chrome/service/cloud_print/DEPS
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   A /trunk/src/jingle
   A /trunk/src/jingle/DEPS
   A /trunk/src/jingle/jingle.gyp
   A /trunk/src/jingle/notifier
   A /trunk/src/jingle/notifier/DEPS (from /trunk/src/chrome/common/net/notifier/DEPS:51215)
   A /trunk/src/jingle/notifier/base
   A /trunk/src/jingle/notifier/base/signal_thread_task.h (from /trunk/src/chrome/common/net/notifier/base/signal_thread_task.h:51215)
   A /trunk/src/jingle/notifier/base/sigslotrepeater.h (from /trunk/src/chrome/common/net/notifier/base/sigslotrepeater.h:51215)
   A /trunk/src/jingle/notifier/base/ssl_adapter.cc (from /trunk/src/chrome/common/net/notifier/base/ssl_adapter.cc:51215)
   A /trunk/src/jingle/notifier/base/ssl_adapter.h (from /trunk/src/chrome/common/net/notifier/base/ssl_adapter.h:51215)
   A /trunk/src/jingle/notifier/base/static_assert.h (from /trunk/src/chrome/common/net/notifier/base/static_assert.h:51215)
   A /trunk/src/jingle/notifier/base/task_pump.cc (from /trunk/src/chrome/common/net/notifier/base/task_pump.cc:51215)
   A /trunk/src/jingle/notifier/base/task_pump.h (from /trunk/src/chrome/common/net/notifier/base/task_pump.h:51215)
   A /trunk/src/jingle/notifier/communicator
   A /trunk/src/jingle/notifier/communicator/auto_reconnect.cc (from /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.cc:51215)
   A /trunk/src/jingle/notifier/communicator/auto_reconnect.h (from /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.h:51215)
   A /trunk/src/jingle/notifier/communicator/connection_options.cc (from /trunk/src/chrome/common/net/notifier/communicator/connection_options.cc:51215)
   A /trunk/src/jingle/notifier/communicator/connection_options.h (from /trunk/src/chrome/common/net/notifier/communicator/connection_options.h:51215)
   A /trunk/src/jingle/notifier/communicator/connection_settings.cc (from /trunk/src/chrome/common/net/notifier/communicator/connection_settings.cc:51215)
   A /trunk/src/jingle/notifier/communicator/connection_settings.h (from /trunk/src/chrome/common/net/notifier/communicator/connection_settings.h:51215)
   A /trunk/src/jingle/notifier/communicator/const_communicator.h (from /trunk/src/chrome/common/net/notifier/communicator/const_communicator.h:51215)
   A /trunk/src/jingle/notifier/communicator/gaia_token_pre_xmpp_auth.cc (from /trunk/src/chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc:51215)
   A /trunk/src/jingle/notifier/communicator/gaia_token_pre_xmpp_auth.h (from /trunk/src/chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.h:51215)
   A /trunk/src/jingle/notifier/communicator/login.cc (from /trunk/src/chrome/common/net/notifier/communicator/login.cc:51215)
   A /trunk/src/jingle/notifier/communicator/login.h (from /trunk/src/chrome/common/net/notifier/communicator/login.h:51215)
   A /trunk/src/jingle/notifier/communicator/login_connection_state.h (from /trunk/src/chrome/common/net/notifier/communicator/login_connection_state.h:51215)
   A /trunk/src/jingle/notifier/communicator/login_failure.cc (from /trunk/src/chrome/common/net/notifier/communicator/login_failure.cc:51215)
   A /trunk/src/jingle/notifier/communicator/login_failure.h (from /trunk/src/chrome/common/net/notifier/communicator/login_failure.h:51215)
   A /trunk/src/jingle/notifier/communicator/login_settings.cc (from /trunk/src/chrome/common/net/notifier/communicator/login_settings.cc:51215)
   A /trunk/src/jingle/notifier/communicator/login_settings.h (from /trunk/src/chrome/common/net/notifier/communicator/login_settings.h:51215)
   A /trunk/src/jingle/notifier/communicator/product_info.cc (from /trunk/src/chrome/common/net/notifier/communicator/product_info.cc:51215)
   A /trunk/src/jingle/notifier/communicator/product_info.h (from /trunk/src/chrome/common/net/notifier/communicator/product_info.h:51215)
   A /trunk/src/jingle/notifier/communicator/single_login_attempt.cc (from /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc:51215)
   A /trunk/src/jingle/notifier/communicator/single_login_attempt.h (from /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.h:51215)
   A /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.cc (from /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.cc:51215)
   A /trunk/src/jingle/notifier/communicator/ssl_socket_adapter.h (from /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.h:51215)
   A /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.cc (from /trunk/src/chrome/common/net/notifier/communicator/xmpp_connection_generator.cc:51215)
   A /trunk/src/jingle/notifier/communicator/xmpp_connection_generator.h (from /trunk/src/chrome/common/net/notifier/communicator/xmpp_connection_generator.h:51215)
   A /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.cc (from /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.cc:51215)
   A /trunk/src/jingle/notifier/communicator/xmpp_socket_adapter.h (from /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.h:51215)
   A /trunk/src/jingle/notifier/listener
   A /trunk/src/jingle/notifier/listener/listen_task.cc (from /trunk/src/chrome/common/net/notifier/listener/listen_task.cc:51215)
   A /trunk/src/jingle/notifier/listener/listen_task.h (from /trunk/src/chrome/common/net/notifier/listener/listen_task.h:51215)
   A /trunk/src/jingle/notifier/listener/mediator_thread.h (from /trunk/src/chrome/common/net/notifier/listener/mediator_thread.h:51215)
   A /trunk/src/jingle/notifier/listener/mediator_thread_impl.cc (from /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc:51215)
   A /trunk/src/jingle/notifier/listener/mediator_thread_impl.h (from /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h:51215)
   A /trunk/src/jingle/notifier/listener/mediator_thread_mock.h (from /trunk/src/chrome/common/net/notifier/listener/mediator_thread_mock.h:51215)
   A /trunk/src/jingle/notifier/listener/notification_constants.cc (from /trunk/src/chrome/common/net/notifier/listener/notification_constants.cc:51215)
   A /trunk/src/jingle/notifier/listener/notification_constants.h (from /trunk/src/chrome/common/net/notifier/listener/notification_constants.h:51215)
   A /trunk/src/jingle/notifier/listener/notification_defines.h (from /trunk/src/chrome/common/net/notifier/listener/notification_defines.h:51215)
   A /trunk/src/jingle/notifier/listener/send_update_task.cc (from /trunk/src/chrome/common/net/notifier/listener/send_update_task.cc:51215)
   A /trunk/src/jingle/notifier/listener/send_update_task.h (from /trunk/src/chrome/common/net/notifier/listener/send_update_task.h:51215)
   A /trunk/src/jingle/notifier/listener/send_update_task_unittest.cc (from /trunk/src/chrome/common/net/notifier/listener/send_update_task_unittest.cc:51215)
   A /trunk/src/jingle/notifier/listener/subscribe_task.cc (from /trunk/src/chrome/common/net/notifier/listener/subscribe_task.cc:51215)
   A /trunk/src/jingle/notifier/listener/subscribe_task.h (from /trunk/src/chrome/common/net/notifier/listener/subscribe_task.h:51215)
   A /trunk/src/jingle/notifier/listener/subscribe_task_unittest.cc (from /trunk/src/chrome/common/net/notifier/listener/subscribe_task_unittest.cc:51215)
   A /trunk/src/jingle/notifier/listener/talk_mediator.h (from /trunk/src/chrome/common/net/notifier/listener/talk_mediator.h:51215)
   A /trunk/src/jingle/notifier/listener/talk_mediator_impl.cc (from /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.cc:51215)
   A /trunk/src/jingle/notifier/listener/talk_mediator_impl.h (from /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.h:51215)
   A /trunk/src/jingle/notifier/listener/talk_mediator_unittest.cc (from /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc:51215)
   A /trunk/src/jingle/notifier/listener/xml_element_util.cc (from /trunk/src/chrome/common/net/notifier/listener/xml_element_util.cc:51215)
   A /trunk/src/jingle/notifier/listener/xml_element_util.h (from /trunk/src/chrome/common/net/notifier/listener/xml_element_util.h:51215)
   A /trunk/src/jingle/notifier/listener/xml_element_util_unittest.cc (from /trunk/src/chrome/common/net/notifier/listener/xml_element_util_unittest.cc:51215)

Move chrome/common/net/notifier to jingle/notifier so that it can be used by remoting/remoting.gyp.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/2885005
------------------------------------------------------------------------
r51215 | akalin@chromium.org | 2010-06-30 04:29:41 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fixed invalid read in ExtensionsServiceTest.ReloadExtensions.

BUG=47843,47863
TEST=unittests, valgrind

Review URL: http://codereview.chromium.org/2872024
------------------------------------------------------------------------
r51213 | rafaelw@chromium.org | 2010-06-30 04:08:15 +0200 (Wed, 30 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Reland - Fix NULL dereference in ExtensionTabsModule.

original review: http://codereview.chromium.org/2885006

----------

This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases

BUG=47808
TEST=none.
TBR=asargent

Review URL: http://codereview.chromium.org/2858036
------------------------------------------------------------------------
r51205 | thakis@chromium.org | 2010-06-30 03:03:53 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/views/controls/label.h

Windows: Replace tabs in content settings with a listbox.

Depends on http://codereview.chromium.org/2815034

BUG=45546
TEST=Open content settings dialog. Should have a list on the left instead of tabs on top. Other than that, the dialog should work as before.

Review URL: http://codereview.chromium.org/2799042
------------------------------------------------------------------------
r51204 | arv@chromium.org | 2010-06-30 02:52:26 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

NTP: Remove command line flag that allowed a local file to be used for the new tab page.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2886002
------------------------------------------------------------------------
r51203 | zelidrag@chromium.org | 2010-06-30 02:45:53 +0200 (Wed, 30 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   M /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/resources/options
   A /trunk/src/chrome/browser/resources/options/chromeos_system_options.html
   A /trunk/src/chrome/browser/resources/options/chromeos_system_options.js
   A /trunk/src/chrome/browser/resources/options/options_page.js
   A /trunk/src/chrome/browser/resources/options/pref_ui.js
   A /trunk/src/chrome/browser/resources/options/preferences.js
   M /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/tools/grit/grit/format/html_inline.py

Split options page code/html into its own set of files.

Changed grit to support generic <!--include file="..."--> tag in html files to support the scenario above.


TEST=make sure chrome:options page still shows correctly
BUG=chromium-os:4429

Review URL: http://codereview.chromium.org/2835009
------------------------------------------------------------------------
r51202 | tfarina@chromium.org | 2010-06-30 02:44:09 +0200 (Wed, 30 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

AutoFill: Add support for multi-select and delete.

BUG=46075
TEST=see bug

Review URL: http://codereview.chromium.org/2828014
------------------------------------------------------------------------
r51201 | feldstein@chromium.org | 2010-06-30 02:43:56 +0200 (Wed, 30 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/menu_item.js

Change MenuItems to use divs and add disabled property

Stops using buttons for menu items so that it doesn't conflict with the
button.css file.  Added a BOOL_ATTR disabled property so the attribute is set on
the element.  It was originally not being set and not being styled as disabled.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/2863031
------------------------------------------------------------------------
r51191 | jam@chromium.org | 2010-06-30 01:14:46 +0200 (Wed, 30 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   D /trunk/src/chrome/browser/plugin_updater.cc
   D /trunk/src/chrome/browser/plugin_updater.h
   D /trunk/src/chrome/browser/plugin_updater_unittest.cc
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 51110 because of regression 47858- Group plugins in about:plugins and show update link for out-of-date ones.

Tracking patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>

Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.

BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.

Review URL: http://codereview.chromium.org/2835018

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/2805048
------------------------------------------------------------------------
r51182 | hinoka@chromium.org | 2010-06-30 00:39:38 +0200 (Wed, 30 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Fixed about:cache in about:about page

changed about:cache to redirect to chrome://view-http-cache instead
of chrome://about/cache.


TEST=Go to about:about and click on about:cache, check that it works
BUG=44699
Review URL: http://codereview.chromium.org/2860038
------------------------------------------------------------------------
r51179 | ben@chromium.org | 2010-06-30 00:08:44 +0200 (Wed, 30 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/gfx/canvas.h
   M /trunk/src/gfx/canvas_skia.cc
   M /trunk/src/gfx/canvas_skia.h
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/root_view.cc

Canvas refactoring Phase 4a:

Move Save, SaveLayerAlpha and Restore onto gfx::Canvas.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2846035
------------------------------------------------------------------------
r51178 | akalin@chromium.org | 2010-06-29 23:53:54 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

Refactored ChromeInvalidationClient to have its own listener type.

BUG=34647
TEST=manual

Review URL: http://codereview.chromium.org/2817037
------------------------------------------------------------------------
r51177 | lzheng@chromium.org | 2010-06-29 23:53:18 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add switches and apis in safebrowsing protocol_manager that will allow end-to-end test later.

BUG=6787,47318
TEST=protocol_manager_unittest.cc

Review URL: http://codereview.chromium.org/2868030
------------------------------------------------------------------------
r51175 | tim@chromium.org | 2010-06-29 23:50:45 +0200 (Tue, 29 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Make sure sync starts up on browser restart as well as initial sync flow.

BUG=47781
TEST=enable sync. close chrome. open chrome. verify sync is working (e.g. by adding a bookmark and watching it sync to another client). sync_integration_tests also cover this.


Review URL: http://codereview.chromium.org/2824037
------------------------------------------------------------------------
r51174 | stuartmorgan@chromium.org | 2010-06-29 23:50:27 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/ui/npapi_test_helper.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/tools/pepper_test_plugin/README
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi

Add switch for specifying a directory to load plugins, so that test plugins can be loaded on the Mac without modifying the application bundle.

BUG=47305
TEST=Mac plugin tests still run. No PlugIns directory created in the app bundle.

Review URL: http://codereview.chromium.org/2814030
------------------------------------------------------------------------
r51170 | estade@chromium.org | 2010-06-29 23:30:41 +0200 (Tue, 29 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc

Disable a unit test that I broke.

Green the tree while I work on fixing it.

BUG=none
TEST=tree goes green
TBR=stuartmorgan

Review URL: http://codereview.chromium.org/2825029
------------------------------------------------------------------------
r51165 | rafaelw@google.com | 2010-06-29 22:56:23 +0200 (Tue, 29 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Revert 51161 - Fix NULL dereference in ExtensionTabsModule.

This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases

BUG=47808
TEST=none

Review URL: http://codereview.chromium.org/2885006

TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/2868039
------------------------------------------------------------------------
r51164 | willchan@chromium.org | 2010-06-29 22:51:01 +0200 (Tue, 29 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc

Reland r50296 which removes some uses of CookieMonster on the UI thread.
Removes the addition of NonThreadSafe and DCHECKs to CookieMonster.
BUG=44083

Review URL: http://codereview.chromium.org/2845031
------------------------------------------------------------------------
r51163 | mbelshe@chromium.org | 2010-06-29 22:50:48 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/preconnect.cc

Fix the construction of the pool names for preconnect.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2842033
------------------------------------------------------------------------
r51162 | stevenjb@chromium.org | 2010-06-29 22:45:25 +0200 (Tue, 29 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc

Protect NetworkScreen::OnDialogCancelled() from view() == NULL
BUG=chromium-os:4294 (http://code.google.com/p/chromium-os/issues/detail?id=4294)
TEST=unable to repro, likely an edge case

Review URL: http://codereview.chromium.org/2809043
------------------------------------------------------------------------
r51161 | rafaelw@chromium.org | 2010-06-29 22:43:37 +0200 (Tue, 29 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fix NULL dereference in ExtensionTabsModule.

This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases

BUG=47808
TEST=none

Review URL: http://codereview.chromium.org/2885006
------------------------------------------------------------------------
r51160 | michaeln@chromium.org | 2010-06-29 22:43:09 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Re-enable a previously disabled test. Failure is not reproducible.

BUG=33443
TEST=existing tests apply

Review URL: http://codereview.chromium.org/2833037
------------------------------------------------------------------------
r51159 | jam@chromium.org | 2010-06-29 22:38:38 +0200 (Tue, 29 Jun 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/third_party/npapi/bindings/npapi_extensions.h
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate.h
   M /trunk/src/webkit/glue/plugins/webplugin_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.h

Allow quering Pepper plugin for selected text for the context menu.  Also take out the ability to access the clipboard since it's not exposed to HTML for security reasons.
Review URL: http://codereview.chromium.org/2841028
------------------------------------------------------------------------
r51158 | skrul@chromium.org | 2010-06-29 22:37:06 +0200 (Tue, 29 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc
   M /trunk/src/chrome/test/sync/engine/mock_connection_manager.h

This change allows the syncer thread to be paused and resumed when the syncer thread has not yet been started or it has been started and is waiting for a connection.

From an API standpoint, the caller of SyncerThread::Pause and SyncerThread::Resume should not need to consider if the thread is already running.  The channel responses (PAUSED and RESUMED) should be the same regardless.  Furthermore, edge cases like "pause before thread is started and resume after thread is started" should be handled correctly.

This change is supposed to be fixing various offline startup problems we've been having and it includes a new integration test for this.  However, it is not yet complete but we might need to check this is before it is ready.

TEST=unit
BUG=45814

Review URL: http://codereview.chromium.org/2814014
------------------------------------------------------------------------
r51157 | estade@chromium.org | 2010-06-29 22:35:19 +0200 (Tue, 29 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model_unittest.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/default_encoding_combo_model.cc
   M /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/encoding_menu_controller.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer_messages.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/pref_member.cc
   M /trunk/src/chrome/browser/pref_member.h
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.h
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager2.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/live_sync/two_client_live_preferences_sync_test.cc

Change a bunch of string types.

Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters).

TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring.

BUG=none
TEST=try bots

Review URL: http://codereview.chromium.org/2854015
------------------------------------------------------------------------
r51156 | seh@chromium.org | 2010-06-29 22:32:35 +0200 (Tue, 29 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/central_roster.html
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json

Stretch the roster to fill its window and enable scrolling
if it exceeds its window's height.
Review URL: http://codereview.chromium.org/2834029
------------------------------------------------------------------------
r51155 | arv@chromium.org | 2010-06-29 22:32:00 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js

Bookmarks: Fix Cmd+A on Mac

BUG=47241
TEST=Navigate between a few folders and then click on the right pane. Now hit Cmd+A.

Review URL: http://codereview.chromium.org/2832034
------------------------------------------------------------------------
r51154 | pinkerton@chromium.org | 2010-06-29 22:16:50 +0200 (Tue, 29 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Create a new type of button cell for bookmark bar buttons that don't darken when pressed, leaving "standard" buttons (like used on the toolbar) to darken as expected.
BUG=44574
TEST=test bookmark buttons and toolbar buttons with different themes, make sure the appearance isn't crappy
Review URL: http://codereview.chromium.org/2866031
------------------------------------------------------------------------
r51151 | stuartmorgan@chromium.org | 2010-06-29 21:03:39 +0200 (Tue, 29 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable all UnloadTest tests using LoadUrlAndQuitBrowser on Linux

TBR=erikkay

BUG=47575
TEST=Greener bot

Review URL: http://codereview.chromium.org/2822037
------------------------------------------------------------------------
r51148 | jcivelli@chromium.org | 2010-06-29 20:45:02 +0200 (Tue, 29 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.h
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.h
   M /trunk/src/chrome/browser/views/infobars/infobar_text_button.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_text_button.h

Translate infobar always/never translate buttons
Adding extra buttons on the translate infobar to let user easily set the "never/always translate this language" property when they declined/accepted translation for a language more than 3 times.

Original review:
http://codereview.chromium.org/2825015/show

BUG=NONE
TEST=Visit a page in a foreign language, translate the page. Repeat 4 times. On the fourth time, the "before translate" infobar should show a button that says "always translate".
Similarly when declining translations 4 times.

Review URL: http://codereview.chromium.org/2835025
------------------------------------------------------------------------
r51146 | rafaelw@chromium.org | 2010-06-29 20:14:10 +0200 (Tue, 29 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc

Remove download check for web store apps (temporarily).

There's still discussion about the design for this, so to minimize breakage on the dev channel, I'm backing the check out temporarily.

BUG=47675,45542

Review URL: http://codereview.chromium.org/2815035
------------------------------------------------------------------------
r51145 | rsesek@chromium.org | 2010-06-29 20:12:40 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm

[Mac] Display the correct number of restorable tabs in the History menu.

BUG=47797
TEST=Open a new window, create 4 NTP tabs and 1 navigated tab. Close the window. The History menu has a "1 Tab" submenu with the navigated page.

Review URL: http://codereview.chromium.org/2800032
------------------------------------------------------------------------
r51144 | jrg@chromium.org | 2010-06-29 20:03:44 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

Follow-up on http://codereview.chromium.org/2861019 to address Powel's comments.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2821018
------------------------------------------------------------------------
r51143 | pinkerton@chromium.org | 2010-06-29 19:37:45 +0200 (Tue, 29 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_constants.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Toolbar facelift. Main buttons larger and more spread out, only get borders when mouse is inside. Fix to gradient button to not show border on mouseover when disabled. Adjust "overlap" between the toolbar and bookmark bar to allow for larger buttons w/out clipping.
Nib change: All buttons changed to not bordered, button cell tags are 0. Buttons are 31x31 and spread out a bit more.
BUG=44574
TEST=toolbar and bookmark bar appearance, hidden, always showing, and detached on NTP.
Review URL: http://codereview.chromium.org/2806041
------------------------------------------------------------------------
r51140 | akalin@chromium.org | 2010-06-29 19:27:20 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   M /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc

Use InvalidationClient::Create() instead of creating an Impl directly.

BUG=34647
TEST=none

Review URL: http://codereview.chromium.org/2836032
------------------------------------------------------------------------
r51138 | sky@chromium.org | 2010-06-29 19:18:49 +0200 (Tue, 29 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Removes control-alt-b accelerator. Turns out control-alt accelerators
are bad.

BUG=44797
TEST=make sure control-alt-b doesn't work.

Review URL: http://codereview.chromium.org/2885003
------------------------------------------------------------------------
r51137 | johnnyg@chromium.org | 2010-06-29 19:16:34 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc

Don't try to animate the balloon before it's been shown, it will cause a crash.

BUG=47809
TEST=notifications on windows

Review URL: http://codereview.chromium.org/2861035
------------------------------------------------------------------------
r51136 | stuartmorgan@chromium.org | 2010-06-29 19:16:34 +0200 (Tue, 29 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable another crashing unload test on Linux

TBR=erikkay

BUG=47575
TEST=Greener bots

Review URL: http://codereview.chromium.org/2887001
------------------------------------------------------------------------
r51135 | stuartmorgan@chromium.org | 2010-06-29 18:40:28 +0200 (Tue, 29 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Don't re-store deleted passwords on form submit on the Mac

Adds test coverage for the various update cases to make sure they are all handled correctly.
Also fixes a regression during the recent PasswordStore refactoring that caused the Mac implementation to run queries on the wrong thread (found by the new unit tests).

BUG=35603
TEST=See bug; other password update cases should continue to work as before.

Review URL: http://codereview.chromium.org/2818035
------------------------------------------------------------------------
r51132 | mrossetti@chromium.org | 2010-06-29 18:22:34 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Stop tracking a drag after the user drops the dragged item.

BUG=44407
TEST=Perform the steps outlined in the bug and verify that after step #5 the folders are no longer still active.

Review URL: http://codereview.chromium.org/2849026
------------------------------------------------------------------------
r51131 | jcivelli@google.com | 2010-06-29 18:20:26 +0200 (Tue, 29 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/before_translate_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h

Fix a crasher with the translate infobar.
Turns out calling Close() from an infobar class to close it is a bad idea
as it only removes its associated view so it is not displayed, but the
tab contents still belives it is showing.
RemoveInfoBar() should be called instead.
I made the InfobarContainer methods private and made InfobarContainer a friend
to prevent other people from running into the same problem.

BUG=47669
TEST=Open a www.google.de In the translate infobar, click Nope. Navigate away
     from the page, it should not crash.

Review URL: http://codereview.chromium.org/2873029
------------------------------------------------------------------------
r51129 | avayvod@chromium.org | 2010-06-29 18:12:12 +0200 (Tue, 29 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

Show tooltips only for users with identical display names.
Tooltip text is changed from email to "<display name> (<domain>)".

BUG=cros:2318
TEST=Verify that tooltips are shown only for users with equal display names. Tooltips show display name and domain.

Review URL: http://codereview.chromium.org/2877002
------------------------------------------------------------------------
r51128 | sky@chromium.org | 2010-06-29 18:05:11 +0200 (Tue, 29 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Removes debugging code added in hopes of finding crasher. The crash
doesn't appear in latest logs, so no point in keeping the code around.

BUG=44642
TEST=none

Review URL: http://codereview.chromium.org/2824036
------------------------------------------------------------------------
r51127 | stuartmorgan@chromium.org | 2010-06-29 17:48:02 +0200 (Tue, 29 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable BrowserCloseUnload on Linux

TBR=sky

BUG=47575
TEST=Green dbg-shlib Linux bot

Review URL: http://codereview.chromium.org/2827035
------------------------------------------------------------------------
r51124 | dmazzoni@chromium.org | 2010-06-29 16:12:43 +0200 (Tue, 29 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   M /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.cc
   M /trunk/src/chrome/browser/views/accessible_view_helper.cc
   M /trunk/src/chrome/browser/views/accessible_view_helper.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h

Make the location bar generate accessibility extension API events on linux/views.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2811023
------------------------------------------------------------------------
r51117 | hamaji@chromium.org | 2010-06-29 14:18:59 +0200 (Tue, 29 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages.h

Expand print-related IPCs so we can implement CSS3 paged media.

The members added into ViewMsg_Print_Params will be used to tell
printers' setting to renderer process.

Maybe ViewMsg_Print_Params::printable_size should be printable_area,
but I've just added margin_top and margin_left for now because
printable_size is used from several code so I wanted to avoid
a big change.

The members added into ViewHostMsg_DidPrintPage_Params will be used
to tell web authors' page setting to browser process.

BUG=47277
TEST=none

Review URL: http://codereview.chromium.org/2805045
------------------------------------------------------------------------
r51110 | bauerb@chromium.org | 2010-06-29 11:38:44 +0200 (Tue, 29 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   A /trunk/src/chrome/browser/plugin_updater.cc
   A /trunk/src/chrome/browser/plugin_updater.h
   A /trunk/src/chrome/browser/plugin_updater_unittest.cc
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Group plugins in about:plugins and show update link for out-of-date ones.

Tracking patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>

Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.

BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.

Review URL: http://codereview.chromium.org/2835018
------------------------------------------------------------------------
r51107 | nkostylev@google.com | 2010-06-29 10:36:56 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc

Provide more descriptive logging for OOBE update.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2886001
------------------------------------------------------------------------
r51100 | scherkus@chromium.org | 2010-06-29 05:59:09 +0200 (Tue, 29 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Add a simple UI test for --app mode.

The --app browser launch code path was previously untested, which resulted in us shipping a release where it was broken.

BUG=47544
TEST=ui_tests

Review URL: http://codereview.chromium.org/2847032
------------------------------------------------------------------------
r51094 | mdm@chromium.org | 2010-06-29 05:20:40 +0200 (Tue, 29 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/app/sql/meta_table.cc
   M /trunk/src/app/sql/meta_table.h
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_x.cc
   M /trunk/src/chrome/browser/password_manager/password_store_x_unittest.cc

Linux: delete the unencrypted login database file after a successful password store migration, since otherwise fragments of password data may be left in it.
BUG=25404
TEST=the "Login Data" file should get deleted and recreated from scratch after migration
Review URL: http://codereview.chromium.org/2866023
------------------------------------------------------------------------
r51093 | tfarina@chromium.org | 2010-06-29 04:40:54 +0200 (Tue, 29 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc

gtk: Gray out uneditable search URLs.

Change the appearence of the url entry to be like disable, so the user
doesn't begin confused.

BUG=34476
TEST=see bug

Review URL: http://codereview.chromium.org/2823030
------------------------------------------------------------------------
r51092 | suzhe@chromium.org | 2010-06-29 04:35:57 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

[chromeos]Fix input method switching shortcut keys.

BUG=http://crosbug.com/3892
TEST=manually

Review URL: http://codereview.chromium.org/2835023
------------------------------------------------------------------------
r51089 | akalin@chromium.org | 2010-06-29 03:35:29 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/chrome.gyp

Added ModelType <-> server sync type mappings and used them.

BUG=34645
TEST=manual

Review URL: http://codereview.chromium.org/2856019
------------------------------------------------------------------------
r51074 | rafaelw@chromium.org | 2010-06-29 01:56:54 +0200 (Tue, 29 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h

ExtensionInfobarGtk now take up available width.

This patch allows ExtensionInfoBarGtk to use the actual width of the infobar for display of the content.

This involves factoring out of ExtensionViewGtk a similar pattern that exists on Views -- namely a Container interface that allows containers to decide how to react to PreferredWidthChanged notifications

BUG=39916
TEST=none

Review URL: http://codereview.chromium.org/2877003
------------------------------------------------------------------------
r51069 | michaeln@chromium.org | 2010-06-29 01:34:20 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_ui_test.cc

Fix a typo.

BUG=none
TEST=none
TBR=jianli

------------------------------------------------------------------------
r51067 | akalin@chromium.org | 2010-06-29 01:31:24 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc

Fixed app name used for server-issued notifications.

BUG=34647
TEST=none

Review URL: http://codereview.chromium.org/2876014
------------------------------------------------------------------------
r51065 | eroman@chromium.org | 2010-06-29 01:11:40 +0200 (Tue, 29 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc

Prevent hitting DCHECK when multiple slashes are specified in chrome://devtools///.

BUG=47699 
Review URL: http://codereview.chromium.org/2829028
------------------------------------------------------------------------
r51064 | chocobo@chromium.org | 2010-06-29 01:02:26 +0200 (Tue, 29 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/.gitignore
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h

Push change for stevenjb:

Issue 2848016: Store wifi network in network_menu_button.cc as a path instead of as a struct.
Store wifi network in network_menu_button.cc as a path instead of as a struct. 
This should address a potential edge case where wifi network information gets updated after the menu is opened and before a network is selected. 

BUG=None 
TEST=None
Review URL: http://codereview.chromium.org/2817036
------------------------------------------------------------------------
r51061 | mirandac@google.com | 2010-06-29 00:55:55 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h

Add UMA logging of search engine selection position when the search engine logo positions have been randomized.

BUG=46604
TEST=none

Review URL: http://codereview.chromium.org/2846038
------------------------------------------------------------------------
r51059 | michaeln@chromium.org | 2010-06-29 00:32:32 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/chrome/browser/appcache/appcache_ui_test.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/data/layout_tests/layout_test_controller.html
   M /trunk/src/chrome/test/ui/ui_layout_test.cc

Run appcache layout tests in chrome using the ui test harness. 

BUG=39365
TEST=yes 

Review URL: http://codereview.chromium.org/2879003
------------------------------------------------------------------------
r51057 | skerner@chromium.org | 2010-06-29 00:10:40 +0200 (Tue, 29 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Remove #define cruft around ExtensionApiTest.TabOnRemoved.

ExtensionApiTest.TabOnRemoved was disabled on Chrome OS.  I fixed the issue a while ago, but did not remove some #defines.

BUG=43440
TEST=ExtensionApiTest.TabOnRemoved

Review URL: http://codereview.chromium.org/2872018
------------------------------------------------------------------------
r51055 | nirnimesh@chromium.org | 2010-06-29 00:04:00 +0200 (Tue, 29 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/pyautolib/pyauto.py

PyAuto: Collect branding info as a part of GetBrowserInfo()

Also, use command_line_string() from base/command_line.h which is
cross-platform now.

Review URL: http://codereview.chromium.org/2800029
------------------------------------------------------------------------
r51047 | dhollowa@chromium.org | 2010-06-28 23:31:13 +0200 (Mon, 28 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

AutoFill "me" card integration defaults to enabled on Mac

Changes the default preference setting for Mac "me" card integration to be enabled.

BUG=46695
TEST=AutoFillDialogControllerTest.AuxiliaryProfilesTrue

Review URL: http://codereview.chromium.org/2800031
------------------------------------------------------------------------
r51041 | albertb@chromium.org | 2010-06-28 22:35:10 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc

Update the Nigori node when the passphrase changes.

BUG=32410
TEST=unittests

Review URL: http://codereview.chromium.org/2858027
------------------------------------------------------------------------
r51040 | rafaelw@chromium.org | 2010-06-28 22:34:47 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc

Fix animation bug in ExtensionInfoBar would can result in orphaned instances in the view hierarchy

BUG=47576
TEST=none

Review URL: http://codereview.chromium.org/2844033
------------------------------------------------------------------------
r51039 | tfarina@chromium.org | 2010-06-28 22:27:53 +0200 (Mon, 28 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

plugins: Add crash icon into the plugin crash alert infobar.

BUG=16681
TEST=go to youtube.com, then go to a video, shift-esc, end flash process, see
the infobar. Notice the icon in the left side.

Review URL: http://codereview.chromium.org/2835020
------------------------------------------------------------------------
r51038 | hinoka@chromium.org | 2010-06-28 22:25:59 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/functional/special_tabs.py

Added about:about page.

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 

Review URL: http://codereview.chromium.org/2845027
------------------------------------------------------------------------
r51037 | creis@chromium.org | 2010-06-28 22:19:50 +0200 (Mon, 28 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Fixes a DCHECK when visiting chrome://theme.

This URL sets off an error case that calls RDH::OnReadCompleted without
calling RDH::Read.  ResourceDispatcherHost then tries to read from a failed
request.  We can avoid this by ensuring has_started_reading is true when
OnReadCompleted is called (whether Read is called or not).

BUG=40250
TEST=ResourceDispatcherHostUITest.CrossSiteFailedRequest

Review URL: http://codereview.chromium.org/2860030
------------------------------------------------------------------------
r51032 | dhollowa@chromium.org | 2010-06-28 22:04:22 +0200 (Mon, 28 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

AutoFill Help Link added on Mac

Adds a link to http://www.google.com/support/chrome/bin/answer.py?answer=142893 on the AutoFill settings dialog.
Nib changes: Adds button with link cell connected to |openHelp:| action.

BUG=42780
TEST=manual, open dialog and click help button.

Review URL: http://codereview.chromium.org/2825027
------------------------------------------------------------------------
r51031 | andybons@chromium.org | 2010-06-28 21:58:54 +0200 (Mon, 28 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   A /trunk/src/chrome/browser/cocoa/extensions/extension_infobar_controller.h
   A /trunk/src/chrome/browser/cocoa/extensions/extension_infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Base implementation of extension infobars on the mac.

BUG=43168
TEST=install an extension that has an infobar. see if one shows up.
Review URL: http://codereview.chromium.org/2858028
------------------------------------------------------------------------
r51024 | thestig@chromium.org | 2010-06-28 21:42:17 +0200 (Mon, 28 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/web_applications/web_app_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Enable unit tests in browser/web_applications/web_app_unittest.cc. I forgot this in r50897.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2863026
------------------------------------------------------------------------
r51023 | thestig@chromium.org | 2010-06-28 21:41:58 +0200 (Mon, 28 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Linux: Mark ExtensionBrowserTest.PluginLoadUnload as flaky.

BUG=47598
TEST=none
Review URL: http://codereview.chromium.org/2825025
------------------------------------------------------------------------
r51021 | sky@chromium.org | 2010-06-28 21:41:18 +0200 (Mon, 28 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.h

Fixes new wrench menu on chromeos.

BUG=none
TEST=none
TBR=oshima@chromium.org

Review URL: http://codereview.chromium.org/2812028
------------------------------------------------------------------------
r51003 | suzhe@chromium.org | 2010-06-28 20:14:53 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

[Linux]Make the whole infor bar horizontally shrinkable.

BUG=39400
TEST=Activate translate bar then try to shrink browser window.

Review URL: http://codereview.chromium.org/2858029
------------------------------------------------------------------------
r51002 | nshkrob@chromium.org | 2010-06-28 20:12:05 +0200 (Mon, 28 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Fix the race condition on TopSites initialization.

Change TopSites::GetMostVisitedURLs to take a callback. This allows TopSites to wait for the results list from the TopSitesDatabase.

BUG=none
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2811028
------------------------------------------------------------------------
r51001 | ahendrickson@google.com | 2010-06-28 20:03:04 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_auth_gssapi_posix.cc
   M /trunk/src/net/http/http_auth_gssapi_posix.h
   M /trunk/src/net/http/http_auth_handler_factory_unittest.cc
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   M /trunk/src/net/http/http_auth_handler_negotiate_posix.cc
   M /trunk/src/net/http/http_auth_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_response_headers.cc
   M /trunk/src/net/http/http_response_headers.h

Hooking GSSAPI code into HTTP authenticate Negotiate handler.

BUG=33033.
TEST=None.

Review URL: http://codereview.chromium.org/2684001
------------------------------------------------------------------------
r50999 | suzhe@chromium.org | 2010-06-28 19:43:42 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac]Avoid beep when typing in a password box.

BUG=47532 Every keystroke in a password beeps
TEST=Keystroke in a password box should not beep.

Review URL: http://codereview.chromium.org/2805038
------------------------------------------------------------------------
r50996 | pkasting@chromium.org | 2010-06-28 19:27:48 +0200 (Mon, 28 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Restore backspace and shift-backspace as accelerators on ChromeOS.

CROSBUG=4348
TEST=Backspace navigates back
Review URL: http://codereview.chromium.org/2863027
------------------------------------------------------------------------
r50990 | xiyuan@chromium.org | 2010-06-28 19:11:32 +0200 (Mon, 28 Jun 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc

Fix a couple crashes.

- chromium-os:4237 is a crash where button listener is released before
  the button. And there could be such a case in PanelController where
  close button and its listener is not coupled as other part of the code.
  Potentially, a PanelController as the button listener could be released
  before the button. The fix is to use the TitleCotnentView as button listener
  and because it's the parent view of the button, it is always valid for
  the life time of the button.
- Fix a crash in BrowserTabStripController::CreateNewTab when trying to dig
  out cause for 4237. It could happen that user clicks quickly on close tab
  and then on new tab button and model_->GetSelectedTabContents() returns
  NULL;

BUG=chromium-os:4237
TEST=No more crashes coming in as in chromius-os:4237.

Review URL: http://codereview.chromium.org/2803024
------------------------------------------------------------------------
r50982 | mirandac@google.com | 2010-06-28 18:13:33 +0200 (Mon, 28 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

Tweak first-run bubble position on Windows so that it points at text start.

BUG=none
TEST= first run bubble points at text, not half-heartedly betwixt icon and text start.
Review URL: http://codereview.chromium.org/2811035
------------------------------------------------------------------------
r50981 | sky@chromium.org | 2010-06-28 18:09:39 +0200 (Mon, 28 Jun 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/platform_util_chromeos.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_interactive_uitest.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Attempt 2 at Moving Browser::AddTypes to TabStripModel. The first
attempt caused some flakiness on the new tab warm startup test. The
only difference between this and the last is that I'm leaving some
suspcious code in TabStripModel::InsertTabContents and
Browser::AddTabWithURL. I'll try to isolate why those changes caused
flakiness after I land the rest.

Here's the description:

Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Converted InsertTabContents call in extensionstabmodule to pass in
  nothing (Rafael said old code was wrong).

BUG=29933
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/2866024
------------------------------------------------------------------------
r50980 | thakis@chromium.org | 2010-06-28 18:00:26 +0200 (Mon, 28 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm

Mac: Tweak first-run bubble position.

Review URL: http://codereview.chromium.org/2805041
------------------------------------------------------------------------
r50979 | sky@chromium.org | 2010-06-28 17:53:09 +0200 (Mon, 28 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   D /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   D /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   D /trunk/src/chrome/browser/extensions/extension_rlz_module.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   D /trunk/src/chrome/test/data/extensions/api_test/rlz

Revert 50977 - Add support for RLZ chrome extension api.

BUG=NONE
TEST=See unit tests as part of this CL.

Review URL: http://codereview.chromium.org/2804010

TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/2835022
------------------------------------------------------------------------
r50978 | sky@chromium.org | 2010-06-28 17:41:49 +0200 (Mon, 28 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disables BrowserCloseNoUnloadListeners as it is crashing.

BUG=47575
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/2853016
------------------------------------------------------------------------
r50977 | rogerta@google.com | 2010-06-28 17:21:50 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_rlz_apitest.cc
   A /trunk/src/chrome/browser/extensions/extension_rlz_module.cc
   A /trunk/src/chrome/browser/extensions/extension_rlz_module.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/rlz
   A /trunk/src/chrome/test/data/extensions/api_test/rlz/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/rlz/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/rlz/test.js

Add support for RLZ chrome extension api.

BUG=NONE
TEST=See unit tests as part of this CL.

Review URL: http://codereview.chromium.org/2804010
------------------------------------------------------------------------
r50975 | cmasone@google.com | 2010-06-28 16:55:36 +0200 (Mon, 28 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h

Update to new cryptohome apis

Also, provide the underpinning for doing cryptohome-preserving password changes.

The caller must implement a callback called OnPasswordChangeDetected,
which will be called when we notice a password worked online, but did
not decrypt the user's cryptohome.  The caller can then call
DoPasswordChange() once he has the old password, or
SkipPasswordChange() to blow away the data.

BUG=chromium-os:323
TEST=unit tests, put it on a device and try successful, failed logins, offline login and localaccount login

Review URL: http://codereview.chromium.org/2824022
------------------------------------------------------------------------
r50971 | nkostylev@google.com | 2010-06-28 15:55:33 +0200 (Mon, 28 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Move user navigation accelerators handling to Chrome.
Fix issue when accelerators were active when dialogs were opened.

Will remove accelerators in WM before submitting this CL.
(http://codereview.chromium.org/2874014)

BUG= http://crosbug.com/4215, http://crosbug.com/3939
TEST=Manual. Cycle through users using Left/Shift+Tab & Right/Tab

Review URL: http://codereview.chromium.org/2874014
------------------------------------------------------------------------
r50970 | glotov@chromium.org | 2010-06-28 13:24:04 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/audio_handler.cc
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.cc

Tiny cleanup in Volume code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2842026
------------------------------------------------------------------------
r50958 | tony@chromium.org | 2010-06-28 02:01:05 +0200 (Mon, 28 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc

Cleanup the file path normalization extension_protocol.

I had hackily put in forward slashes, but now that there's a
normalization method for filepath, I'm using it.

Review URL: http://codereview.chromium.org/2833032
------------------------------------------------------------------------
r50957 | hinoka@chromium.org | 2010-06-28 00:33:10 +0200 (Mon, 28 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/functional/special_tabs.py

Revert 50956 - Added an about:about page (recommit)

Added a new page, about:about (or chrome://about/about)

continued from http://codereview.chromium.org/2799038/show fixed typo that screwed up ChromeOS compiling

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2861028

TBR=hinoka@chromium.org
Review URL: http://codereview.chromium.org/2814035
------------------------------------------------------------------------
r50956 | hinoka@chromium.org | 2010-06-28 00:17:41 +0200 (Mon, 28 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/functional/special_tabs.py

Added an about:about page (re-commit)

Added a new page, about:about (or chrome://about/about)

continued from http://codereview.chromium.org/2799038/show fixed typo that screwed up ChromeOS compiling

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2861028
------------------------------------------------------------------------
r50952 | mad@google.com | 2010-06-27 18:23:14 +0200 (Sun, 27 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_installer_util.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/metrics_helpers.cc
   M /trunk/src/chrome/common/metrics_helpers.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome_frame/chrome_frame.gyp

Cleanup some unncessary dependencies on libxml.

As working on change committed in rev50132, instead of yet adding another project to the dependency list of libxml, I decided to abstract the dependency in the metrics helper.

BUG=0
TEST=None

Review URL: http://codereview.chromium.org/2753010
------------------------------------------------------------------------
r50951 | jar@chromium.org | 2010-06-27 08:22:01 +0200 (Sun, 27 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   D /trunk/src/chrome/browser/net/dns_global.cc
   D /trunk/src/chrome/browser/net/dns_global.h
   D /trunk/src/chrome/browser/net/dns_host_info.cc
   D /trunk/src/chrome/browser/net/dns_host_info.h
   D /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   D /trunk/src/chrome/browser/net/dns_master.cc
   D /trunk/src/chrome/browser/net/dns_master.h
   D /trunk/src/chrome/browser/net/dns_master_unittest.cc
   A /trunk/src/chrome/browser/net/predictor.cc (from /trunk/src/chrome/browser/net/dns_master.cc:50795)
   A /trunk/src/chrome/browser/net/predictor.h (from /trunk/src/chrome/browser/net/dns_master.h:50795)
   A /trunk/src/chrome/browser/net/predictor_api.cc (from /trunk/src/chrome/browser/net/dns_global.cc:50795)
   A /trunk/src/chrome/browser/net/predictor_api.h (from /trunk/src/chrome/browser/net/dns_global.h:50795)
   A /trunk/src/chrome/browser/net/predictor_unittest.cc (from /trunk/src/chrome/browser/net/dns_master_unittest.cc:50795)
   A /trunk/src/chrome/browser/net/url_info.cc (from /trunk/src/chrome/browser/net/dns_host_info.cc:50795)
   A /trunk/src/chrome/browser/net/url_info.h (from /trunk/src/chrome/browser/net/dns_host_info.h:50795)
   A /trunk/src/chrome/browser/net/url_info_unittest.cc (from /trunk/src/chrome/browser/net/dns_host_info_unittest.cc:50795)
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/common/net/dns.h
   A /trunk/src/chrome/common/net/predictor_common.h (from /trunk/src/chrome/common/net/dns.h:50795)
   A /trunk/src/chrome/renderer/net/predictor_queue.cc (from /trunk/src/chrome/renderer/net/render_dns_queue.cc:50795)
   A /trunk/src/chrome/renderer/net/predictor_queue.h (from /trunk/src/chrome/renderer/net/render_dns_queue.h:50795)
   A /trunk/src/chrome/renderer/net/predictor_queue_unittest.cc (from /trunk/src/chrome/renderer/net/render_dns_queue_unittest.cc:50795)
   D /trunk/src/chrome/renderer/net/render_dns_master.cc
   D /trunk/src/chrome/renderer/net/render_dns_master.h
   D /trunk/src/chrome/renderer/net/render_dns_master_unittest.cc
   D /trunk/src/chrome/renderer/net/render_dns_queue.cc
   D /trunk/src/chrome/renderer/net/render_dns_queue.h
   D /trunk/src/chrome/renderer/net/render_dns_queue_unittest.cc
   A /trunk/src/chrome/renderer/net/renderer_net_predictor.cc (from /trunk/src/chrome/renderer/net/render_dns_master.cc:50795)
   A /trunk/src/chrome/renderer/net/renderer_net_predictor.h (from /trunk/src/chrome/renderer/net/render_dns_master.h:50795)
   A /trunk/src/chrome/renderer/net/renderer_predictor_unittest.cc (from /trunk/src/chrome/renderer/net/render_dns_master_unittest.cc:50795)
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Rename Dns prefetching files to Predictor files

We are now doing more than DNS pre-resolution, and want
to do TCP/IP pre-warming.  This change uses the updated
class names etc., and tries to use Predictor as the
common element in most names.

r=mbelshe
Review URL: http://codereview.chromium.org/2866026
------------------------------------------------------------------------
r50940 | thakis@chromium.org | 2010-06-26 23:45:34 +0200 (Sat, 26 Jun 2010) | 12 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/FirstRunBubble.xib
   A /trunk/src/chrome/browser/cocoa/base_bubble_controller.h
   A /trunk/src/chrome/browser/cocoa/base_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   A /trunk/src/chrome/browser/cocoa/first_run_bubble_controller.h
   A /trunk/src/chrome/browser/cocoa/first_run_bubble_controller.mm
   A /trunk/src/chrome/browser/cocoa/first_run_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/l10n_util.h
   M /trunk/src/chrome/browser/cocoa/l10n_util.mm
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   A /trunk/src/chrome/browser/search_engines/util.cc
   A /trunk/src/chrome/browser/search_engines/util.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: First run bubble.

Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it.

Move some l10n stuff to l10n_util and use that, too.

Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone())

BUG=27489,36366
TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work.

Review URL: http://codereview.chromium.org/2822026
------------------------------------------------------------------------
r50938 | rsleevi@chromium.org | 2010-06-26 20:44:05 +0200 (Sat, 26 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_win.cc
   M /trunk/src/net/base/cert_test_util.cc
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_unittest.cc
   M /trunk/src/net/base/x509_certificate_win.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc

Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership

R=wtc
BUG=47463
TEST=none

Review URL: http://codereview.chromium.org/2867026
------------------------------------------------------------------------
r50929 | aa@chromium.org | 2010-06-26 08:35:02 +0200 (Sat, 26 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h
   M /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/url_pattern_unittest.cc

Re-implement app overlap detection with new extent syntax.

BUG=47445

Review URL: http://codereview.chromium.org/2876009
------------------------------------------------------------------------
r50927 | lzheng@chromium.org | 2010-06-26 05:57:57 +0200 (Sat, 26 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_response_info.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Add field trial stats for alternate_protocol. The histogram we collected are: 
http stats when alternate protocol is available but npn was not negotiated (
which means not usng spdy), and when alternate is available AND spdy is used.

Noticable changes:
1. In http_network_transaction.cc, changed the logic that always parse 
response from server for alternate protocol and remember that in 
HttpAlternateProtocols strucuture. We need to remember this to collect 
stats for servers with alternate protocol support but used http for.
2. In spdy_stream.cc, get rid of the response copy from spdy_stream. This
copy overwrites some early status in response set in http_network_transaction.


TEST=http_network_transaction_unittest.cc
BUG=46689

Review URL: http://codereview.chromium.org/2808010
------------------------------------------------------------------------
r50922 | thestig@chromium.org | 2010-06-26 04:06:02 +0200 (Sat, 26 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/functional/special_tabs.py

Revert 50917 - Added an about:about page (continuation)

continued from http://codereview.chromium.org/2754002/show
changelist disappeared after machine swap.

Added a new page, about:about (or chrome://about/about)
Includes a list of most of the about:* pages (eg. Left out about:inducebrowsercrashforrealz)

Page is constructed within browser_about_handler.cc

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 

Review URL: http://codereview.chromium.org/2799038

TBR=hinoka@chromium.org
Review URL: http://codereview.chromium.org/2813037
------------------------------------------------------------------------
r50920 | jcivelli@chromium.org | 2010-06-26 03:32:22 +0200 (Sat, 26 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc

TranslateInfoBarDelegate2 were leaked.

(Relanding, the changed unit-test was flaky.
Turns out comparing pointers in that context to see that an object changed is a bad idea as a new object might be at the exact same address as an old object.)

This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation). This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted.

BUG=None
TEST=Linux heap check bot should be green.

Review URL: http://codereview.chromium.org/2878005
------------------------------------------------------------------------
r50918 | akalin@chromium.org | 2010-06-26 03:28:57 +0200 (Sat, 26 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc

Reworked ExtensionsService::AddPendingExtension().

Made it take options for enabled/incognito enabled state to apply
on install.

BUG=46515
TEST=unittests, manual (newly-synced disabled extensions should stay
disabled)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50804

Review URL: http://codereview.chromium.org/2819023
------------------------------------------------------------------------
r50917 | hinoka@chromium.org | 2010-06-26 03:25:44 +0200 (Sat, 26 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/functional/special_tabs.py

Added an about:about page (continuation)

continued from http://codereview.chromium.org/2754002/show
changelist disappeared after machine swap.

Added a new page, about:about (or chrome://about/about)
Includes a list of most of the about:* pages (eg. Left out about:inducebrowsercrashforrealz)

Page is constructed within browser_about_handler.cc

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 

Review URL: http://codereview.chromium.org/2799038
------------------------------------------------------------------------
r50916 | aa@chromium.org | 2010-06-26 03:21:07 +0200 (Sat, 26 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Split out the bookmark permission into its own line in
ExtensionInstallUI.

Also, fix a bug where a change to the geolocation permission
wasn't triggering the privilege increase path and refactor
code to try and reduce the chance of that kind of bug in the
future.

BUG=45715

Review URL: http://codereview.chromium.org/2846034
------------------------------------------------------------------------
r50914 | jcivelli@chromium.org | 2010-06-26 02:28:19 +0200 (Sat, 26 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc

Revert 50913
TranslateManagerTest.NormalTranslate fails on Linux

TranslateInfoBarDelegate2 were leaked. (Yikes!)
This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation).
This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted.

BUG=None
TEST=Linux heap check bot should be green.

Review URL: http://codereview.chromium.org/2822032

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2879004
------------------------------------------------------------------------
r50913 | jcivelli@chromium.org | 2010-06-26 02:06:11 +0200 (Sat, 26 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc

TranslateInfoBarDelegate2 were leaked. (Yikes!)
This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation).
This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted.

BUG=None
TEST=Linux heap check bot should be green.

Review URL: http://codereview.chromium.org/2822032
------------------------------------------------------------------------
r50911 | sky@chromium.org | 2010-06-26 01:56:09 +0200 (Sat, 26 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Fixes new wrench related problems on views:
. crash when showing page menu via alt-e.
. dchecks when running on views on linux.

BUG=45734
TEST=none
TBR=erg@chromium.org

Review URL: http://codereview.chromium.org/2867029
------------------------------------------------------------------------
r50910 | akalin@chromium.org | 2010-06-26 01:44:32 +0200 (Sat, 26 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fixed memory leak in ExtensionsService.

Added coverage for disabled extensions in unit tests.

BUG=none
TEST=new unit tests

Review URL: http://codereview.chromium.org/2845025
------------------------------------------------------------------------
r50909 | derat@chromium.org | 2010-06-26 01:43:57 +0200 (Sat, 26 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

chromeos: Remove Backspace accelerator.

The people with whom I spoke (ben, glen, alcor) think that
we should expose a better method for going back in the
browser history and are okay with removing this for now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2871026
------------------------------------------------------------------------
r50908 | sky@chromium.org | 2010-06-26 01:27:50 +0200 (Sat, 26 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/common/renderer_preferences.h

Revert 50673 - Fix pinned tab link navigations.

This ties up that loose end I mentioned in http://codereview.chromium.org/2747011 (I had put this off because I expected it would require slightly more effort).

BUG=29281
TEST=manual

Review URL: http://codereview.chromium.org/2844017

TBR=estade@chromium.org
------------------------------------------------------------------------
r50902 | dantasse@chromium.org | 2010-06-26 00:38:00 +0200 (Sat, 26 Jun 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

New HTML Sync Setup UI.

Was reverted because of a valgrind error. This is try #2.

Old flow:
- type username/password. wait for Gaia auth and initial sync (with throbber)
- success! or error.

New flow:
- type username/password. wait for Gaia auth. (with throbber)
- error, or choose your datatypes. you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one.
- wait for initial sync (with throbber)
- success! or error, which brings you back to the gaia auth screen.

Smaller details:
- removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow.
- added a logging statement to log if you cancel from the Choose Data Types screen.
- added a pref to the profile for whether you want to "keep everything synced" or choose one by one.
- added a couple more strings. Not final yet, I don't think.

BUG=45869
TEST=Exercise all the different paths through the login flow.

Review URL: http://codereview.chromium.org/2880001
------------------------------------------------------------------------
r50898 | sky@chromium.org | 2010-06-25 23:46:12 +0200 (Fri, 25 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Marks BrowserCloseNoUnloadListeners flaky.

BUG=47575
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/2825024
------------------------------------------------------------------------
r50897 | thestig@chromium.org | 2010-06-25 23:39:07 +0200 (Fri, 25 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/web_applications/web_app.h
   A /trunk/src/chrome/browser/web_applications/web_app_unittest.cc

Add tests for chrome/browser/web_applications and mark some code as Win32 and/or Views only. (TTF)

BUG=none
TEST=included.
Review URL: http://codereview.chromium.org/2826019
------------------------------------------------------------------------
r50896 | erg@chromium.org | 2010-06-25 23:34:04 +0200 (Fri, 25 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/menus/button_menu_item_model.cc
   A /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/app/menus/menu_model.h
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu.cc
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu.h
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.cc
   M /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

Reapply r50859 with chromeos fixes.

GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.

Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.

Review URL: http://codereview.chromium.org/2800015
BUG=45757
TEST=none

Review URL: http://codereview.chromium.org/2879002
------------------------------------------------------------------------
r50895 | pkasting@chromium.org | 2010-06-25 23:30:38 +0200 (Fri, 25 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   D /trunk/src/chrome/browser/sync/net/network_change_notifier_io_thread.cc
   D /trunk/src/chrome/browser/sync/net/network_change_notifier_io_thread.h
   D /trunk/src/chrome/browser/sync/net/network_change_notifier_io_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/common/net/fake_network_change_notifier_thread.cc
   D /trunk/src/chrome/common/net/fake_network_change_notifier_thread.h
   D /trunk/src/chrome/common/net/fake_network_change_notifier_thread_unittest.cc
   D /trunk/src/chrome/common/net/mock_network_change_observer.h
   D /trunk/src/chrome/common/net/network_change_notifier_proxy.cc
   D /trunk/src/chrome/common/net/network_change_notifier_proxy.h
   D /trunk/src/chrome/common/net/network_change_notifier_proxy_unittest.cc
   D /trunk/src/chrome/common/net/network_change_notifier_thread.h
   D /trunk/src/chrome/common/net/network_change_observer_proxy.cc
   D /trunk/src/chrome/common/net/network_change_observer_proxy.h
   D /trunk/src/chrome/common/net/network_change_observer_proxy_unittest.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.h
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc
   D /trunk/src/chrome/common/net/thread_blocker.cc
   D /trunk/src/chrome/common/net/thread_blocker.h
   D /trunk/src/chrome/common/net/thread_blocker_unittest.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc
   D /trunk/src/chrome/service/net/service_network_change_notifier_thread.cc
   D /trunk/src/chrome/service/net/service_network_change_notifier_thread.h
   D /trunk/src/chrome/service/net/service_network_change_notifier_thread_unittest.cc
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/chrome/service/service_process.h
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   D /trunk/src/net/base/mock_network_change_notifier.h
   M /trunk/src/net/base/net_test_suite.h
   M /trunk/src/net/base/network_change_notifier.cc
   M /trunk/src/net/base/network_change_notifier.h
   M /trunk/src/net/base/network_change_notifier_linux.cc
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.cc
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/base/network_change_notifier_win.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/socks_client_socket_pool.h
   M /trunk/src/net/socket/socks_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/spdy/spdy_http_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session_pool.cc
   M /trunk/src/net/spdy/spdy_session_pool.h
   M /trunk/src/net/spdy/spdy_session_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Massively simplify the NetworkChangeNotifier infrastructure:
  * Use a process-wide object (singleton pattern)
  * Create/destroy this object on the main thread, make it outlive all consumers
  * Make observer-related functions threadsafe

As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around).

BUG=none
TEST=Unittests; network changes still trigger notifications
Review URL: http://codereview.chromium.org/2802015
------------------------------------------------------------------------
r50894 | avi@chromium.org | 2010-06-25 23:29:10 +0200 (Fri, 25 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/platform_util_common_linux.cc
   M /trunk/src/chrome/browser/platform_util_mac.mm
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Make a new yes/no messagebox wrapper function, use it in the bookmark alert.

Recommitting of r46101.

BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. A confirmation
dialog box should be shown. No other visible change.

Review URL: http://codereview.chromium.org/1745024
------------------------------------------------------------------------
r50893 | sky@chromium.org | 2010-06-25 23:28:21 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc

Enables the new wrench menu by default on windows.

BUG=45734
TEST=make sure the new wrench menu works! Make sure and exer

Review URL: http://codereview.chromium.org/2845022
------------------------------------------------------------------------
r50892 | sky@chromium.org | 2010-06-25 23:23:23 +0200 (Fri, 25 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Makes control-alt-b show the bookmark manager on linux and windows
(already works on mac).

BUG=44797
TEST=make sure control-alt-b shows the bookmark manager.

Review URL: http://codereview.chromium.org/2867027
------------------------------------------------------------------------
r50891 | asargent@chromium.org | 2010-06-25 23:16:22 +0200 (Fri, 25 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix a unit test leak.

These were introduced by revision 50779 (http://codereview.chromium.org/2867008)

BUG=47471
TEST=none


Review URL: http://codereview.chromium.org/2808027
------------------------------------------------------------------------
r50888 | estade@chromium.org | 2010-06-25 22:40:59 +0200 (Fri, 25 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/mini_installer_test/run_all_unittests.cc
   M /trunk/src/chrome/test/mini_installer_test/test.cc

Command line flag cleanup.

Move some string literals into chrome/common/chrome_switches.

There are still many uses in places that cannot depend on chrome/common.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2824008
------------------------------------------------------------------------
r50887 | thestig@chromium.org | 2010-06-25 22:40:30 +0200 (Fri, 25 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/side_tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/side_tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/side_tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/side_tab_strip_view.mm
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/test/data/extensions/icon3.png
   M /trunk/src/chrome/test/data/extensions/uitest/plugins/plugin32.so
   M /trunk/src/chrome/test/data/extensions/uitest/plugins/plugin64.so
   M /trunk/src/net/data/proxy_resolver_v8_unittest/international_domain_names.js
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_stream.cc
   M /trunk/src/net/spdy/spdy_stream.h

Cleanup: Remove svn:executable from a bunch of files.

BUG=none
TEST=checkperms.py passes
Review URL: http://codereview.chromium.org/2850030
------------------------------------------------------------------------
r50886 | estade@chromium.org | 2010-06-25 22:35:20 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/gfx/gtk_native_view_id_manager.cc
   M /trunk/src/gfx/gtk_native_view_id_manager.h

GTK: add more syncronization to GtkNativeViewIdManager to avoid a crash.

BUG=46197
TEST=manual (see bug)

Review URL: http://codereview.chromium.org/2860024
------------------------------------------------------------------------
r50885 | estade@chromium.org | 2010-06-25 22:34:25 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Cancel loading animations during shutdown.

BUG=none
TEST=debug chrome doesn't complain when shutting down a loading window

Review URL: http://codereview.chromium.org/2870025
------------------------------------------------------------------------
r50879 | jhawkins@chromium.org | 2010-06-25 21:54:36 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/renderer/render_view.cc

AutoFill: GRD strings cleanup.

BUG=47422
TEST=none

Review URL: http://codereview.chromium.org/2852025
------------------------------------------------------------------------
r50878 | tim@chromium.org | 2010-06-25 21:48:24 +0200 (Fri, 25 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

sync: Change entry purging approach to rely on SaveChanges, which is more consistent with the way
things work in general, and specifically when things fail as the transaction boundaries are well
defined.

The entries will get deleted from memory after the next successful SaveChanges operation (happens every 10 seconds), and they will get deleted from disk on the next browser restart.

Also clear the metadata bits that track whether there are any entries in the Directory for those
types to keep it in a consistent state.

BUG=40252

Review URL: http://codereview.chromium.org/2873020
------------------------------------------------------------------------
r50876 | eroman@chromium.org | 2010-06-25 21:33:37 +0200 (Fri, 25 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Don't DCHECK for resolving empty hostnames since PAC scripts can fire off such queries. 

Instead, just ignore those queries. 

BUG=47501
TEST=none

Committing patch on behalf of jochen.
Original code review: http://codereview.chromium.org/2850028/show

Review URL: http://codereview.chromium.org/2870028
------------------------------------------------------------------------
r50873 | shess@chromium.org | 2010-06-25 21:04:40 +0200 (Fri, 25 Jun 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   D /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   A /trunk/src/chrome/browser/cocoa/location_bar
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.h (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.h (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.mm (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest_helper.h (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest_helper.mm (from /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h (from /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm (from /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm:50869)
   A /trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac_unittest.mm (from /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm:50869)
   D /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   D /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   D /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Push location bar implementation into subdir.

Move these files from cocoa/ to cocoa/location_bar/:
  autocomplete_text_field.h
  autocomplete_text_field.mm
  autocomplete_text_field_cell.h
  autocomplete_text_field_cell.mm
  autocomplete_text_field_cell_unittest.mm
  autocomplete_text_field_editor.h
  autocomplete_text_field_editor.mm
  autocomplete_text_field_editor_unittest.mm
  autocomplete_text_field_unittest.mm
  autocomplete_text_field_unittest_helper.h
  autocomplete_text_field_unittest_helper.mm
  location_bar_view_mac.h
  location_bar_view_mac.mm
  location_bar_view_mac_unittest.mm

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2807024
------------------------------------------------------------------------
r50869 | mrossetti@chromium.org | 2010-06-25 20:08:20 +0200 (Fri, 25 Jun 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/history/history_index.cc
   D /trunk/src/chrome/browser/history/history_index.h
   D /trunk/src/chrome/browser/history/history_index_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 50863 - Add initial url/title history indexing and search provider support -- not hooked up at this point.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2818029

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/2811034
------------------------------------------------------------------------
r50867 | akalin@chromium.org | 2010-06-25 19:59:51 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.cc

Make extension sync change processor listen to events for disabled extensions.

BUG=46514
TEST=made sure syncing of an uninstalled disabled extension works

Review URL: http://codereview.chromium.org/2849027
------------------------------------------------------------------------
r50865 | rafaelw@google.com | 2010-06-25 19:51:47 +0200 (Fri, 25 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/menus/button_menu_item_model.cc
   D /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/app/menus/menu_model.h
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   D /trunk/src/chrome/browser/gtk/gtk_custom_menu.cc
   D /trunk/src/chrome/browser/gtk/gtk_custom_menu.h
   D /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc
   D /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.cc
   M /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 50859 - GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.

Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.

BUG=45757
TEST=none

Review URL: http://codereview.chromium.org/2800015

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2836029
------------------------------------------------------------------------
r50863 | mrossetti@chromium.org | 2010-06-25 19:40:13 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/history/history_index.cc
   A /trunk/src/chrome/browser/history/history_index.h
   A /trunk/src/chrome/browser/history/history_index_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add initial url/title history indexing and search provider support -- not hooked up at this point.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2818029
------------------------------------------------------------------------
r50860 | finnur@chromium.org | 2010-06-25 19:29:58 +0200 (Fri, 25 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix regression (crash) in launching Apps (regular ones, not Extension Apps) caused by r50489.

The function that got changed is shared by both types of Apps, but in the case of old-style apps |extension| is NULL, so dereferencing it will crash.

BUG=47484
TEST=Launch Chrome with --app=http://www.google.com and it should not crash.


Review URL: http://codereview.chromium.org/2842028
------------------------------------------------------------------------
r50859 | erg@chromium.org | 2010-06-25 19:26:18 +0200 (Fri, 25 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/menus/button_menu_item_model.cc
   A /trunk/src/app/menus/button_menu_item_model.h
   M /trunk/src/app/menus/menu_model.h
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu.cc
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu.h
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.cc
   A /trunk/src/chrome/browser/gtk/gtk_custom_menu_item.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.cc
   M /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.

Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.

BUG=45757
TEST=none

Review URL: http://codereview.chromium.org/2800015
------------------------------------------------------------------------
r50856 | shess@chromium.org | 2010-06-25 19:03:51 +0200 (Fri, 25 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/objc_zombie.mm

[Mac] Tweak CrZombie code for better crash reporting.

-performSelector:withObject: has been seen in some crashes, so expand
the dispatch methods implemented to cover that and a couple obvious
variants.

Use a local copy of |BreakDebugger()| so that the crashes top-of-stack
is more obviously intentional.  Then there can be a bug to attract
crash-triagers and explain how to handle things.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2828022
------------------------------------------------------------------------
r50855 | skerner@chromium.org | 2010-06-25 18:36:41 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc

Disallow apps with the wrong content type header.

BUG=41290
TEST=manual

Review URL: http://codereview.chromium.org/2830017
------------------------------------------------------------------------
r50854 | ben@chromium.org | 2010-06-25 18:33:23 +0200 (Fri, 25 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/helper.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/list_background.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/gfx/canvas.h
   D /trunk/src/gfx/canvas_2.h
   M /trunk/src/gfx/canvas_skia.cc
   M /trunk/src/gfx/canvas_skia.h
   M /trunk/src/gfx/canvas_skia_linux.cc
   M /trunk/src/gfx/canvas_skia_mac.mm
   M /trunk/src/gfx/canvas_skia_paint.h
   M /trunk/src/gfx/canvas_skia_win.cc
   M /trunk/src/gfx/font_mac.mm
   M /trunk/src/gfx/font_skia.cc
   M /trunk/src/gfx/font_win.cc
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/views/background.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_text_utils.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/dialog_client_view.cc

Canvas refactoring part 3.

- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.

This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.

BUG=none
TEST=none

------------------------------------------------------------------------
r50853 | thakis@chromium.org | 2010-06-25 18:27:28 +0200 (Fri, 25 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc

Fix crash when dragging thumbnail on NTP.

BUG=11457
TEST=Drag thumbnail on NTP. Shouldn't dcheck.
Review URL: http://codereview.chromium.org/2807023
------------------------------------------------------------------------
r50852 | sky@chromium.org | 2010-06-25 18:21:32 +0200 (Fri, 25 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/wrench_menu.cc
   M /trunk/src/chrome/browser/views/wrench_menu.h
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h

Changes mnemonics for bookmark menus to show the mnemonics if either
the os says we should, or focus was on the button that triggered
showing the menu. Also changes mnemonic processing to not guess at
mnemonic if menu has mnemonics.

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2831031
------------------------------------------------------------------------
r50848 | jcivelli@chromium.org | 2010-06-25 18:06:38 +0200 (Fri, 25 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/gtk/translate
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.h
   D /trunk/src/chrome/browser/gtk/translate_infobars.cc
   D /trunk/src/chrome/browser/gtk/translate_infobars.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Porting the infobars on Linux to the new TranslateInfobarDelegate2.
Each translate infobar is now its own class and most of the logic is in the delegate.

BUG=40828
TEST=Thoroughly test the translate feature on Linux.

Review URL: http://codereview.chromium.org/2867017


Review URL: http://codereview.chromium.org/2836023
------------------------------------------------------------------------
r50837 | aa@chromium.org | 2010-06-25 12:01:05 +0200 (Fri, 25 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/maps_app/manifest.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h
   M /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_has_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_lacks_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_process/manifest.json
   M /trunk/src/chrome/test/data/extensions/app1/manifest.json
   M /trunk/src/chrome/test/data/extensions/app2/manifest.json
   M /trunk/src/chrome/test/data/extensions/app3/manifest.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_default.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_3.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_wrong_type.json (from /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json:50836)

Reland r50834

TBR=tony@chromium.org
------------------------------------------------------------------------
r50835 | aa@chromium.org | 2010-06-25 10:31:43 +0200 (Fri, 25 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/maps_app/manifest.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h
   M /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_has_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_lacks_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_process/manifest.json
   M /trunk/src/chrome/test/data/extensions/app1/manifest.json
   M /trunk/src/chrome/test/data/extensions/app2/manifest.json
   M /trunk/src/chrome/test/data/extensions/app3/manifest.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json (from /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_wrong_type.json:50834)
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json (from /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_wrong_type.json:50834)
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_1.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_2.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_3.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_wrong_type.json

Revert r50834

TBR=tony@chromium.org
------------------------------------------------------------------------
r50834 | aa@chromium.org | 2010-06-25 09:50:11 +0200 (Fri, 25 Jun 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/maps_app/manifest.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h
   M /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_has_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_lacks_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_process/manifest.json
   M /trunk/src/chrome/test/data/extensions/app1/manifest.json
   M /trunk/src/chrome/test/data/extensions/app2/manifest.json
   M /trunk/src/chrome/test/data/extensions/app3/manifest.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_invalid_3.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_urls_wrong_type.json (from /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json:50832)

Allow multiple domains in app.

Subsequent changes will:

* Allow URLPatterns to specify * for scheme, so that http/https doesn't need to be repeated for each host.
* Fix the overlap detection.

Suggested review order:

- test files
- url_pattern*
- extension_extent*
- extension*
- everything else

BUG=46633

Review URL: http://codereview.chromium.org/2876007
------------------------------------------------------------------------
r50833 | arv@chromium.org | 2010-06-25 09:47:02 +0200 (Fri, 25 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/css/button.css

DOMUI: Fix css for disabled action buttons

Change the order and make the rules a bit more specific to handle disabled action buttons.

Review URL: http://codereview.chromium.org/2805028
------------------------------------------------------------------------
r50832 | hclam@chromium.org | 2010-06-25 09:30:46 +0200 (Fri, 25 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc

Revert r50804 "Reworked ExtensionsService::AddPendingExtension()."

Reverted r50804 as it seems to be related to memory error.

Review URL: http://codereview.chromium.org/2833033
------------------------------------------------------------------------
r50831 | hclam@chromium.org | 2010-06-25 09:25:52 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/file_reader_unittest.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource.h
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/icon3.png

Revert "Revert "Show extension icons next to their top-level context menu items.""

This reverts r50828 as the error is already suppressed r50793.
TBR=asargent

Review URL: http://codereview.chromium.org/2844028
------------------------------------------------------------------------
r50830 | thakis@chromium.org | 2010-06-25 09:12:22 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/drag_utils.h
   M /trunk/src/views/drag_utils_gtk.cc
   M /trunk/src/views/drag_utils_win.cc

Chrome/win: Show preview images when dragging images.

BUG=11457
TEST=Go to google.com, drag logo around. Should be attached to cursor.

Review URL: http://codereview.chromium.org/2870026
------------------------------------------------------------------------
r50829 | jochen@chromium.org | 2010-06-25 09:11:23 +0200 (Fri, 25 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookiePrompt.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc

Allow content setting changes in incognito mode.

This removes the logic to disable the "remeber" functions in the UI elements (basically reverting r44084, but leaves the incognito host content setting map in place. Changes to this map are allowed but do not get stored in preferences.

BUG=44480
TEST=none

Review URL: http://codereview.chromium.org/2811025
------------------------------------------------------------------------
r50828 | hclam@chromium.org | 2010-06-25 08:46:10 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/file_reader_unittest.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource.h
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   D /trunk/src/chrome/test/data/extensions/icon3.png

Revert r50779 as it breaks memory tests

TBR=asargent@chromium.org
TEST=Tree goes green

Review URL: http://codereview.chromium.org/2812025
------------------------------------------------------------------------
r50827 | avayvod@chromium.org | 2010-06-25 08:33:40 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Enable tooltips on users only if there're at least two users with the same display name.

BUG=cros:2318
TEST=Log in with two users with the same username but different domains. Check that tooltips are enabled on the next run of login screen. Remove one of the users. Check that tooltips are disabled and stay disabled until new user is added with duplicate username.

Review URL: http://codereview.chromium.org/2841026
------------------------------------------------------------------------
r50825 | jnd@chromium.org | 2010-06-25 07:58:40 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc

Only save pure filename in lpstrFile.
BUG=47213
TEST=manual test?


Review URL: http://codereview.chromium.org/2868031
------------------------------------------------------------------------
r50823 | scherkus@chromium.org | 2010-06-25 07:38:11 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove --enable-chat-manager and copy step for chat_manager.

BUG=none
TEST=--enable-chat-manager no longer runs the chat_manager component extension.

Review URL: http://codereview.chromium.org/2833031
------------------------------------------------------------------------
r50820 | hclam@chromium.org | 2010-06-25 06:49:51 +0200 (Fri, 25 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Revert r50774 as it introduces valgrind failures

TBR=dantasse@chromium.org
TEST=Valgrind bot goes green
BUG=none

Review URL: http://codereview.chromium.org/2827025
------------------------------------------------------------------------
r50815 | jam@chromium.org | 2010-06-25 05:36:07 +0200 (Fri, 25 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc

Turn on the pdf plugin by default for Chrome OS.

TBR=viettrungluu
Review URL: http://codereview.chromium.org/2832025
------------------------------------------------------------------------
r50814 | jam@chromium.org | 2010-06-25 05:24:06 +0200 (Fri, 25 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc

Checking in Lei's fix from http://codereview.chromium.org/2827024: Don't crash if the pdf plugin couldn't be loaded.

BUG=47362
TBR=thestig
Review URL: http://codereview.chromium.org/2852026
------------------------------------------------------------------------
r50813 | hclam@chromium.org | 2010-06-25 05:20:35 +0200 (Fri, 25 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   D /trunk/src/chrome/browser/appcache/appcache_ui_test.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/ui/ui_layout_test.cc

Revert r50798 as it seems to create ui test failures

TBR=ericu, michaeln

Review URL: http://codereview.chromium.org/2863025
------------------------------------------------------------------------
r50806 | oshima@chromium.org | 2010-06-25 03:44:06 +0200 (Fri, 25 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Screenlocker fixes.
 * Fix regression where gkt menu didn't close itself when screen is locked.
   putting gtk_add_grab() back before removing all of grab widget.
   This was also causing the problem
 * Fix copy&paste error in HandleGrabBroke. It was not checking mouse_grab_status
 * Enable double buffering to avoid flicker on native textfield.
 * Add more logging to help troubleshooting problem in release build.

BUG=chromium-os:4222
TEST=see bug for instruction how to reproduce the bug. Screen Locker should kick in even with menu opened and unlocking should work too.

Review URL: http://codereview.chromium.org/2868024
------------------------------------------------------------------------
r50805 | oshima@chromium.org | 2010-06-25 03:42:05 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc

Use io thread to send dbus message.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2814026
------------------------------------------------------------------------
r50804 | akalin@chromium.org | 2010-06-25 03:36:40 +0200 (Fri, 25 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc

Reworked ExtensionsService::AddPendingExtension().

Made it take options for enabled/incognito enabled state to apply
on install.

BUG=46515
TEST=unittests, manual (newly-synced disabled extensions should stay
disabled)

Review URL: http://codereview.chromium.org/2819023
------------------------------------------------------------------------
r50803 | suzhe@chromium.org | 2010-06-25 03:20:56 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc

[Linux]Honour GNOME's show_input_method_menu setting.

BUG=http://crosbug.com/2458
TEST=Disable desktop->gnome->interface->show_input_method_menu option in gconf-editor, and then right click in a webpage's input box. The context menu should not contain input method sub menu.

Review URL: http://codereview.chromium.org/2804024
------------------------------------------------------------------------
r50799 | shess@chromium.org | 2010-06-25 02:54:36 +0200 (Fri, 25 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Find page-action bubble point from location bar.

Push the AutocompleteTextFieldCell knowledge into LocationBarViewMac.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2806031
------------------------------------------------------------------------
r50798 | michaeln@chromium.org | 2010-06-25 02:51:38 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/chrome/browser/appcache/appcache_ui_test.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/ui/ui_layout_test.cc

Run appcache layout tests in chrome using the ui test harness.

BUG=39365
TEST=yes

Review URL: http://codereview.chromium.org/2822007
------------------------------------------------------------------------
r50797 | shess@chromium.org | 2010-06-25 02:47:03 +0200 (Fri, 25 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

[Mac] Remove knowledge of AutocompleteTextField from ToolbarController.

Concentrate the calculation in the location bar.  Was going to do this
in rewiring omnibox decorations, pulled it out before creating
cocoa/location_bar/ subdir.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2846030
------------------------------------------------------------------------
r50792 | jar@chromium.org | 2010-06-25 02:12:49 +0200 (Fri, 25 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/connect_interceptor.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/renderer/net/render_dns_master.cc
   M /trunk/src/chrome/renderer/net/render_dns_master.h
   M /trunk/src/chrome/renderer/net/render_dns_master_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Change classes and functions for DNS Prefetching to Predictor*

The DNS prefetching system has been extended to handle TCP/IP
preconnection.  As a result, class names and function names will
be migrated to variations on Predictor* and Predict* to better
indicate functionality.

This change is only meant to include name changes, comment
updates, and no semantic changes.

r=mbelshe
Review URL: http://codereview.chromium.org/2813031
------------------------------------------------------------------------
r50791 | nick@chromium.org | 2010-06-25 02:10:32 +0200 (Fri, 25 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/sync/engine/mock_connection_manager.cc (from /trunk/src/chrome/test/sync/engine/mock_server_connection.cc:50735)
   A /trunk/src/chrome/test/sync/engine/mock_connection_manager.h (from /trunk/src/chrome/test/sync/engine/mock_server_connection.h:50735)
   D /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   D /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h

A few cleanups to the sync unit tests.
I didn't want to mix these in with other changes that are due
to real expectations changes.

BUG=46769 (related work)
TEST=sync_unit_tests

Review URL: http://codereview.chromium.org/2811031
------------------------------------------------------------------------
r50790 | ben@chromium.org | 2010-06-25 01:52:00 +0200 (Fri, 25 Jun 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/list_background.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/gfx/canvas.h
   A /trunk/src/gfx/canvas_2.h (from /trunk/src/gfx/canvas_2.h:50783)
   M /trunk/src/gfx/canvas_skia.cc
   M /trunk/src/gfx/canvas_skia.h
   M /trunk/src/gfx/canvas_skia_linux.cc
   M /trunk/src/gfx/canvas_skia_mac.mm
   M /trunk/src/gfx/canvas_skia_paint.h
   M /trunk/src/gfx/canvas_skia_win.cc
   M /trunk/src/gfx/font_mac.mm
   M /trunk/src/gfx/font_skia.cc
   M /trunk/src/gfx/font_win.cc
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/views/background.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/drag_utils_win.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_text_utils.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/dialog_client_view.cc

Revert 50784 - Canvas refactoring part 3.

- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.

This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2825018

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2811032
------------------------------------------------------------------------
r50787 | johnnyg@chromium.org | 2010-06-25 01:37:26 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h

Remove the horizontal layout code from notifications logic.  This code is not used currently nor do we expect to switch to a horizontal layout anytime soon.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2818030
------------------------------------------------------------------------
r50786 | rafaelw@chromium.org | 2010-06-25 01:34:44 +0200 (Fri, 25 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Only examine host & path in gallery download url check

BUG=47425
TEST=All tests pass

Review URL: http://codereview.chromium.org/2867024
------------------------------------------------------------------------
r50784 | ben@chromium.org | 2010-06-25 01:30:26 +0200 (Fri, 25 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/list_background.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/gfx/canvas.h
   D /trunk/src/gfx/canvas_2.h
   M /trunk/src/gfx/canvas_skia.cc
   M /trunk/src/gfx/canvas_skia.h
   M /trunk/src/gfx/canvas_skia_linux.cc
   M /trunk/src/gfx/canvas_skia_mac.mm
   M /trunk/src/gfx/canvas_skia_paint.h
   M /trunk/src/gfx/canvas_skia_win.cc
   M /trunk/src/gfx/font_mac.mm
   M /trunk/src/gfx/font_skia.cc
   M /trunk/src/gfx/font_win.cc
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/views/background.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/drag_utils_win.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_text_utils.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/dialog_client_view.cc

Canvas refactoring part 3.

- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.

This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2825018
------------------------------------------------------------------------
r50783 | erg@chromium.org | 2010-06-25 01:28:53 +0200 (Fri, 25 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   A /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.cc
   A /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.h
   A /trunk/src/chrome/browser/resources/shared_resources.grd
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/installer/mini_installer/chrome.release

Reapply "Move the files in resources/shared/ into resources.pak"

Now with one line fix to fix the mac build.

BUG=35793,42770
TEST=none
TBR=tony

Review URL: http://codereview.chromium.org/2842025
------------------------------------------------------------------------
r50782 | jhawkins@chromium.org | 2010-06-25 01:23:16 +0200 (Fri, 25 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

AutoFill: Don't show labels in the suggestions popup when the user is editing a
field in an auto-filled form.

BUG=47437
TEST=AutoFillManagerTest.GetFieldSuggestionsFormIsAutoFilled

Review URL: http://codereview.chromium.org/2861025
------------------------------------------------------------------------
r50779 | asargent@chromium.org | 2010-06-25 01:20:15 +0200 (Fri, 25 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/file_reader_unittest.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource.h
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/icon3.png

Show extension icons next to their top-level context menu items.

Also fix a bug in extension icon caching where we weren't keeping track of
potential resizing done by ImageLoadingTracker before setting the cached
SkBitmap.

BUG=39494
TEST=Install an extension that includes an icon and uses the experimental
context menu API. You should see the extension's icon in the context menu
next to its top-level item.

Review URL: http://codereview.chromium.org/2867008
------------------------------------------------------------------------
r50777 | erg@chromium.org | 2010-06-25 00:34:09 +0200 (Fri, 25 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   D /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.cc
   D /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.h
   D /trunk/src/chrome/browser/resources/shared_resources.grd
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/installer/mini_installer/chrome.release

Revert 50761 - Move the files in resources/shared/ into resources.pak

BUG=35793,42770
TEST=none

Review URL: http://codereview.chromium.org/2817026

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2855021
------------------------------------------------------------------------
r50776 | sky@chromium.org | 2010-06-25 00:29:49 +0200 (Fri, 25 Jun 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/platform_util_chromeos.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_interactive_uitest.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:

. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
  wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
  TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
  ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
  nothing (Rafael said old code was wrong).

BUG=29933
TEST=none

Review URL: http://codereview.chromium.org/2863021

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2849025
------------------------------------------------------------------------
r50774 | dantasse@chromium.org | 2010-06-24 23:35:47 +0200 (Thu, 24 Jun 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/choose_datatypes.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

New HTML Sync Setup UI!  This paves the way for the Passphrase UI. (coming soon...)

Old flow:
- type username/password. wait for Gaia auth and initial sync (with throbber)
- success! or error.

New flow:
- type username/password.  wait for Gaia auth. (with throbber)
- error, or choose your datatypes.  you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one.
- wait for initial sync (with throbber)
- success! or error, which brings you back to the gaia auth screen.

Smaller details:
- removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow.
- added a logging statement to log if you cancel from the Choose Data Types screen.
- added a pref to the profile for whether you want to "keep everything synced" or choose one by one.
- added a couple more strings.  Not final yet, I don't think.

BUG=45869
TEST=Exercise all the different paths through the login flow.

Review URL: http://codereview.chromium.org/2851012
------------------------------------------------------------------------
r50773 | xji@chromium.org | 2010-06-24 23:32:14 +0200 (Thu, 24 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

This CL fixes issue 43800 - RTL/LTR eliding in Linux omnibox dropdown.

Unlike Windows, in Linux, we do not draw the strings in autocomplete popup by ourselves. Instead, we rely on Pango to draw the strings. We only need to pass the text, the attribute, and the width to Pango, and Pango will draw the text correctly (taking care of visual runs for bidi text).

The only small problems are that:
when the UI is RTL, for pure English text, we need to insert LRE mark so that the ending punctuation is drawn correctly as is (not flipped), for example "....(choose location)" will not be drawn as "(....(choose location" in RTL UI.

Also, for some (not all) pure English text, when eliding, the ellipsis appears at the very left of the string in RTL UI. I do not know the reason of such inconsistency, but looks like adding LRE mark to pure English also forces the ellipsis appears at the right of the string.


BUG=43800
TEST=Omnibox should elide long URLs, mixed LTR/RTL text, etc. correctly in both LTR and RTL locales
Review URL: http://codereview.chromium.org/2824027
------------------------------------------------------------------------
r50772 | mpcomplete@chromium.org | 2010-06-24 23:19:13 +0200 (Thu, 24 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Remove scary "Extension has access to everything you own" warning when the
extension wants to inject script into file URLs, since this requires user
opt-in now.

BUG=47180

Review URL: http://codereview.chromium.org/2810028
------------------------------------------------------------------------
r50771 | evan@chromium.org | 2010-06-24 23:19:05 +0200 (Thu, 24 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.cc

linux: work around gnome keyring memory corruption

Older versions of gnome keyring corrupt memory if you fetch too much
data from it.  Despite our best efforts, we couldn't come up with a way
to tell if you're using the broken old version so that we could blacklist
it.  Instead, we fetch passwords one-by-one, which is slow but tolerable
since we do it on a background thread anyway.

While I'm here, refactor the code a bit to simplify it.

TEST=password manager doesn't crash when using mdm's sample 100 password db
with --password-store=gnome on hardy

Review URL: http://codereview.chromium.org/2838023
------------------------------------------------------------------------
r50770 | atwilson@chromium.org | 2010-06-24 23:04:19 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/background_contents_service.cc
   M /trunk/src/chrome/browser/background_contents_service.h

Create background contents on startup.

Implement BackgroundContentsService::CreateBackgroundContents() to automatically relaunch registered BackgroundContents when the browser starts.

Review URL: http://codereview.chromium.org/2862026
------------------------------------------------------------------------
r50768 | nkostylev@google.com | 2010-06-24 22:50:31 +0200 (Thu, 24 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc

Fix crash on update screen.
Introduced in CL http://codereview.chromium.org/2842024

BUG= http://crosbug.com/4208
TEST=Execute OOBE, update screen should check for update and proceed.

Review URL: http://codereview.chromium.org/2871022
------------------------------------------------------------------------
r50762 | akalin@chromium.org | 2010-06-24 22:33:39 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc

Explicitly disallow user scripts from extensions sync.

BUG=46654
TEST=ExtensionUtilTest.IsSyncableExtension

Review URL: http://codereview.chromium.org/2803022
------------------------------------------------------------------------
r50761 | erg@chromium.org | 2010-06-24 22:32:28 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   A /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.cc
   A /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.h
   A /trunk/src/chrome/browser/resources/shared_resources.grd
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/installer/mini_installer/chrome.release

Move the files in resources/shared/ into resources.pak

BUG=35793,42770
TEST=none

Review URL: http://codereview.chromium.org/2817026
------------------------------------------------------------------------
r50758 | feldstein@chromium.org | 2010-06-24 21:48:34 +0200 (Thu, 24 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
   M /trunk/src/chrome/browser/resources/shared/css/list.css
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js

Fix BMM paste on mac and list hover artifact.

The Bookamark manager on mac would paste a url into a bookmarks url field, and
then the same paste event would propagate up to the list and paste the page as a
new bookmark.  This stops propagation of paste events from the text fields in
the list.

Also, now that the list has spacers for the dynamic rendering, the spacers would
get a 2 pixel hover effect.  This removes that.  You can see it by slowly moving
from the last bookmark down to below the bottom of the list.
BUG=43442
TEST=NONE

Review URL: http://codereview.chromium.org/2805031
------------------------------------------------------------------------
r50757 | johnnyg@chromium.org | 2010-06-24 21:45:56 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/Notification.xib
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/chrome_dll.gypi

Convert notification UI on Mac to a NIB rather than hand-coded.  Also update the UI to reflect the latest mocks.  Also improve the animation onto the screen.

BUG=34627
TEST=none

Review URL: http://codereview.chromium.org/2822019
------------------------------------------------------------------------
r50753 | mirandac@chromium.org | 2010-06-24 21:33:30 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm
   M /trunk/src/chrome/browser/importer/importer.cc

Make import from the options menu OOP on Mac OS X.

BUG=46701
TEST=import Firefox passwords from the menu once the browser is running.  Because import is OOP, FF passwords should be imported.  All other import processes should still work as advertised.
Review URL: http://codereview.chromium.org/2800026
------------------------------------------------------------------------
r50752 | sky@chromium.org | 2010-06-24 21:32:28 +0200 (Thu, 24 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/platform_util_chromeos.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_interactive_uitest.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:

. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
  wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
  TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
  ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
  nothing (Rafael said old code was wrong).

BUG=29933
TEST=none

Review URL: http://codereview.chromium.org/2863021
------------------------------------------------------------------------
r50743 | sky@chromium.org | 2010-06-24 20:15:26 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Adds comment to why we need std::min in getting selection start.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2831023
------------------------------------------------------------------------
r50737 | mpcomplete@chromium.org | 2010-06-24 19:49:08 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/test/data/extensions/good/Preferences
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Require user opt-in before allowing content script injection on file URLs.

BUG=47180

Review URL: http://codereview.chromium.org/2809034
------------------------------------------------------------------------
r50734 | mirandac@google.com | 2010-06-24 19:26:32 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_browsertest.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/installer/util/master_preferences_constants.cc
   M /trunk/src/chrome/installer/util/master_preferences_constants.h

Allow suppression of first run bubble from master preferences.

BUG=18185
TEST= add "suppress_first_run_bubble:true" to distribution section of master_preferences.  run as first_run, and watch bubble not appear.

Review URL: http://codereview.chromium.org/2812022
------------------------------------------------------------------------
r50732 | ctguil@chromium.org | 2010-06-24 19:24:04 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Fire the document load complete and focus event on the root document object.

BUG=47084,47208
TEST=none

Review URL: http://codereview.chromium.org/2822027
------------------------------------------------------------------------
r50730 | sky@chromium.org | 2010-06-24 19:21:05 +0200 (Thu, 24 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Converts the CRLF line endings to LF. I only encountered this because
I need to change this file for another patch and the try bots kept
barfing. I finally figured it out it was because of CRLF instead LF.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2837016
------------------------------------------------------------------------
r50729 | brettw@chromium.org | 2010-06-24 19:05:16 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc

Disable check for duplicate URLs. Turns out the most visited computation can generate these in some legitimate cases and we don't want to assert.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2799027
------------------------------------------------------------------------
r50728 | dantasse@chromium.org | 2010-06-24 18:59:16 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/sync/resources/choose_datatypes.html

GRD change + new HTML file for sync UI change

BUG=45869
TEST=Doesn't do anything yet

Review URL: http://codereview.chromium.org/2845019
------------------------------------------------------------------------
r50725 | mirandac@google.com | 2010-06-24 17:55:58 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble.h

Change copyright to help grd change along.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2809036
------------------------------------------------------------------------
r50724 | mirandac@google.com | 2010-06-24 17:51:09 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h

Tweak the first run search engine dialog so that it reflects Glen's mocks.  This change adds an image to the top of the dialog, and removes the text and link at the bottom.  It also removes the horizontal separators.

BUG=46716
TEST=Run Chrome in first-run with master_preferences set to load the new search engine dialog.  It should look reasonable.
Review URL: http://codereview.chromium.org/2818014
------------------------------------------------------------------------
r50722 | sky@chromium.org | 2010-06-24 17:28:17 +0200 (Thu, 24 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/browser/wrench_menu_model.h

Provides a single place to test whether the new wrench menu is
enabled. I'm doing this as I'm ready to turn it on for views and want
a single place to turn it off should we decided to do that.

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2813032
------------------------------------------------------------------------
r50721 | nkostylev@google.com | 2010-06-24 16:22:36 +0200 (Thu, 24 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc

Unsubscribe from updates notifications on exit from update screen.
Added extra debug logging for update screen.

BUG= http://crosbug.com/4208
TEST=Manually: run OOBE, press Esc on update screen, you should stay at login screen.

Review URL: http://codereview.chromium.org/2842024
------------------------------------------------------------------------
r50719 | nkostylev@google.com | 2010-06-24 15:44:40 +0200 (Thu, 24 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Pass start url to be opened after login.
Single url is enough. If needed it could be easily changed to multiple ones.
Hopefully merging login_screen & existing_user_controller will remove some of duplication.

BUG= http://crosbug.com/4214
TEST=Manual. "Can't access your account" should open BWSI with help link in it.

Review URL: http://codereview.chromium.org/2802021
------------------------------------------------------------------------
r50715 | mazda@chromium.org | 2010-06-24 12:39:15 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h

Add the Reset to defaults button to the Mozc configuration dialog.

BUG=chromium-os:2625
TEST=manual

Review URL: http://codereview.chromium.org/2861021
------------------------------------------------------------------------
r50714 | mazda@chromium.org | 2010-06-24 12:30:15 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc

Change the language indicator to the country code when using ibus-xkb.

BUG=chromium-os:4044
TEST=manually check the indicator on the netbook

Review URL: http://codereview.chromium.org/2876006
------------------------------------------------------------------------
r50713 | yusukes@google.com | 2010-06-24 12:08:36 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Don't show the tooltip for the language indicator when the indicator is hidden.

BUG=chromium-os:4227
TEST=manual

Review URL: http://codereview.chromium.org/2837015
------------------------------------------------------------------------
r50709 | yusukes@google.com | 2010-06-24 11:50:42 +0200 (Thu, 24 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h

Add IsScreenLockerMode() interface to the StatusAreaHost class.

LanguageMenuButton will use the interface to implement crosbug.com/2619 (Implement input language selector on the log in page)

BUG=none
TEST=ran try bot

Review URL: http://codereview.chromium.org/2846031
------------------------------------------------------------------------
r50708 | danno@chromium.org | 2010-06-24 10:40:36 +0200 (Thu, 24 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h

fix forgotten homepage preference on Windows

BUG=47055
TEST=manual

Review URL: http://codereview.chromium.org/2815021
Patch from Gábor Fehér <gfeher@google.com>.
------------------------------------------------------------------------
r50707 | thestig@chromium.org | 2010-06-24 10:00:40 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/uitest/plugins/manifest.json

Linux: Port the ExtensionBrowserTest.PluginLoadUnload test part 2. (TTF)

BUG=29900
TEST=ported.
Review URL: http://codereview.chromium.org/2849019
------------------------------------------------------------------------
r50706 | tony@chromium.org | 2010-06-24 09:01:19 +0200 (Thu, 24 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Fix bookmark manager on mac and windows.

Mac was failing because the resources directory
was in a different place.

Win was failing because path separators between
two filepaths are different causing the equality
check to fail.

TBR=erg

Review URL: http://codereview.chromium.org/2873017
------------------------------------------------------------------------
r50701 | tony@chromium.org | 2010-06-24 07:01:57 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc

Disable BookmarksUITest.FLAKY_ShouldRedirectToExtension while I fix

TBR=leiz

Review URL: http://codereview.chromium.org/2800025
------------------------------------------------------------------------
r50700 | nick@chromium.org | 2010-06-24 06:57:24 +0200 (Thu, 24 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/data_encryption.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/common/sqlite_utils.cc

sqlite_utils: don't dereference an empty vector.

user_settings: Add unit test intended to exercise the above path.
In practice though these tests don't hit the bug, since
EncryptData("") results in non-empty ciphertext.

bonus: don't leak a sqlite handle in one of the other sync unit tests.

TEST=none
BUG=40217

Review URL: http://codereview.chromium.org/2801017
------------------------------------------------------------------------
r50697 | suzhe@chromium.org | 2010-06-24 06:32:36 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc

Fix a potential crash issue.

BUG=47376
TEST=none

Review URL: http://codereview.chromium.org/2868033
------------------------------------------------------------------------
r50688 | rafaelw@chromium.org | 2010-06-24 04:11:40 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc

Fix copy & paste error from http://codereview.chromium.org/2855009.

TBR=aa

Review URL: http://codereview.chromium.org/2867023
------------------------------------------------------------------------
r50683 | tony@chromium.org | 2010-06-24 03:26:40 +0200 (Thu, 24 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_posix.cc
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   A /trunk/src/chrome/browser/resources/bookmark_manager_resources.grd
   M /trunk/src/chrome/browser/resources/net_internals_resources.grd
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/installer/mini_installer/chrome_frame.release

Move the bookmark manager into resources.pak.

This allows for the bookmark manager to work after upgrading
in the background on Linux.

BUG=42770
TEST=Bookmark manager still works

Review URL: http://codereview.chromium.org/2814009
------------------------------------------------------------------------
r50678 | jrg@chromium.org | 2010-06-24 02:52:49 +0200 (Thu, 24 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/content.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py
   M /trunk/src/chrome/test/pyautolib/pyautolib.i

Enable "get html from page" functionality for PyAuto.

BUG=36184
TEST=Run PyAuto's content.py and make sure it passes.

Review URL: http://codereview.chromium.org/2861019
------------------------------------------------------------------------
r50677 | dpranke@chromium.org | 2010-06-24 02:26:43 +0200 (Thu, 24 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc

Implement Password Manager aggregate metrics reporting

This patch implements UMA histograms for the total number of saved passwords and the number of usernames per site/realm.

    BUG=45946
    R=jcivelli@chromium.org
    TEST=none

Review URL: http://codereview.chromium.org/2834009
------------------------------------------------------------------------
r50675 | csilv@chromium.org | 2010-06-24 02:22:56 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix an unititialized variable that caused a mac valgrind failure.

BUG=46797
TEST=Mac valgrind stays green
Review URL: http://codereview.chromium.org/2849020
------------------------------------------------------------------------
r50674 | estade@chromium.org | 2010-06-24 02:17:32 +0200 (Thu, 24 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_unittest.cc

Make pinned tabs a little stickier.

Use the same algorithm for rewriting the window open disposition as we use for link clicking.

BUG=47190
TEST=manual; unit tests

Review URL: http://codereview.chromium.org/2807016
------------------------------------------------------------------------
r50673 | estade@chromium.org | 2010-06-24 02:16:09 +0200 (Thu, 24 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/common/renderer_preferences.h

Fix pinned tab link navigations.

This ties up that loose end I mentioned in http://codereview.chromium.org/2747011 (I had put this off because I expected it would require slightly more effort).

BUG=29281
TEST=manual

Review URL: http://codereview.chromium.org/2844017
------------------------------------------------------------------------
r50672 | csilv@chromium.org | 2010-06-24 02:07:21 +0200 (Thu, 24 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   A /trunk/src/chrome/browser/dom_ui/options_ui_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add basic UI tests for dom_ui/options.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2848012
------------------------------------------------------------------------
r50664 | ben@chromium.org | 2010-06-24 01:04:23 +0200 (Thu, 24 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   D /trunk/src/gfx/canvas.cc
   R /trunk/src/gfx/canvas.h
   D /trunk/src/gfx/canvas_linux.cc
   D /trunk/src/gfx/canvas_mac.mm
   D /trunk/src/gfx/canvas_paint.h
   A /trunk/src/gfx/canvas_skia.cc (from /trunk/src/gfx/canvas.cc:50543)
   A /trunk/src/gfx/canvas_skia.h (from /trunk/src/gfx/canvas.h:50543)
   A /trunk/src/gfx/canvas_skia_linux.cc (from /trunk/src/gfx/canvas_linux.cc:50452)
   A /trunk/src/gfx/canvas_skia_mac.mm (from /trunk/src/gfx/canvas_mac.mm:50452)
   A /trunk/src/gfx/canvas_skia_paint.h (from /trunk/src/gfx/canvas_paint.h:50452)
   A /trunk/src/gfx/canvas_skia_win.cc (from /trunk/src/gfx/canvas_win.cc:50452)
   D /trunk/src/gfx/canvas_win.cc
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/textfield/gtk_views_entry.cc
   M /trunk/src/views/controls/textfield/gtk_views_textview.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/widget/root_view_gtk.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/window_win.cc

Canvas refactoring part 2.

- Rename Canvas to CanvasSkia.
- Create a subclass Canvas that inherits from CanvasSkia for compatibility.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2862025
------------------------------------------------------------------------
r50662 | jrg@chromium.org | 2010-06-24 00:49:49 +0200 (Thu, 24 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Enable --wait-for-debugger for the browser process.
Helpful when the browser itself is a child process (e.g. of pyauto).

BUG=none
TEST=Run Chrome with --wait-for-debugger.  Make sure it waits for debugger.



Review URL: http://codereview.chromium.org/2826015
------------------------------------------------------------------------
r50655 | garykac@google.com | 2010-06-24 00:36:43 +0200 (Thu, 24 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/remoting_ui.cc
   A /trunk/src/chrome/browser/dom_ui/remoting_ui.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Add RemotingUI class to handle chrome://remoting URLs.

These URLs are handled by a plugin that is registered to the
chrome-internal-plugin/remoting MIME type.

BUG=none
TEST=verify plugin is loaded when navigating to chrome://remoting

Review URL: http://codereview.chromium.org/2812017
------------------------------------------------------------------------
r50652 | evan@chromium.org | 2010-06-23 23:48:53 +0200 (Wed, 23 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/password_manager/native_backend_kwallet_x.cc

linux: initialize glib-dbus threading during startup

Rather than scattering init calls through the code, just inititialize
it once.  (In particular, the gnome-keyring support also needs this
function called, and I didn't want to copy it one more time.)

TEST=no threading-related crash during gnome-keyring startup

Review URL: http://codereview.chromium.org/2873015
------------------------------------------------------------------------
r50650 | stuartmorgan@chromium.org | 2010-06-23 23:44:57 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_lib_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_unittest.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugininfo.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc

Convert WebPluginInfo from wstring to string16

BUG=None
TEST=No behavioral change; plugins should continue to work.

Review URL: http://codereview.chromium.org/2866014
------------------------------------------------------------------------
r50646 | albertb@chromium.org | 2010-06-23 23:35:32 +0200 (Wed, 23 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/protocol/password_specifics.proto
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Take 2: sync changes to support encryption

Attempting to resubmit this change. It looks like the reason for the build break on linux was a missing dependency (nss) in the interactive_ui_test target.

BUG=32410
TEST=unittests

Review URL: http://codereview.chromium.org/2828021
------------------------------------------------------------------------
r50643 | avayvod@chromium.org | 2010-06-23 23:20:46 +0200 (Wed, 23 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Enables tooltips on label. Sends message to wm when user image or user label
is clicked so wm knows which one to select.

BUG=cros:2318
TEST=With new wm tooltips should appear above user image and label on
unselected user pod.

Review URL: http://codereview.chromium.org/2856014
------------------------------------------------------------------------
r50641 | feldstein@chromium.org | 2010-06-23 23:12:27 +0200 (Wed, 23 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/cocoa/translate
   A /trunk/src/chrome/browser/cocoa/translate/after_translate_infobar_controller.h
   A /trunk/src/chrome/browser/cocoa/translate/after_translate_infobar_controller.mm
   A /trunk/src/chrome/browser/cocoa/translate/before_translate_infobar_controller.h
   A /trunk/src/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm
   A /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.h
   A /trunk/src/chrome/browser/cocoa/translate/translate_infobar_base.mm
   A /trunk/src/chrome/browser/cocoa/translate/translate_infobar_unittest.mm (from /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm:50624)
   A /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.h
   A /trunk/src/chrome/browser/cocoa/translate/translate_message_infobar_controller.mm
   D /trunk/src/chrome/browser/cocoa/translate_infobar.h
   D /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   D /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Refactor the translate infobars on mac to match the new windows code.

Breaks it up into 4 different classes instead of 1 class full of switches and if
statements.

BUG=none
TEST=unit_tests.TranslationInfoBarTest

Review URL: http://codereview.chromium.org/2815013
------------------------------------------------------------------------
r50640 | thakis@chromium.org | 2010-06-23 23:11:52 +0200 (Wed, 23 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_controller_unittest.mm
   M /trunk/src/chrome/common/child_process_logging_mac_unittest.mm

Add storage for static member vars.

This way, the code is standards-compliant _and_ makes clang happy.

Review URL: http://codereview.chromium.org/2870023
------------------------------------------------------------------------
r50622 | suzhe@chromium.org | 2010-06-23 19:53:04 +0200 (Wed, 23 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/ime_input.cc
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   A /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Improve input method support.

This CL fixes following issues:
BUG=23219 IME should be disabled in password box.
BUG=41876 Chinese IME is still active when current focus is not a text input control
BUG=44529 Clause segmentation information of composition text is not honored when using CJK input methods.
BUG=46326 Clicking during a composition cancels it
TEST=See individual bug report.

This CL is blocked on webkit bug: https://bugs.webkit.org/show_bug.cgi?id=40608

Review URL: http://codereview.chromium.org/2824015
------------------------------------------------------------------------
r50621 | dantasse@chromium.org | 2010-06-23 19:53:03 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

Fix line endings.  Got some CR LF's in there, somehow.  If I had a dollar for every time I hated a CR LF, I'd buy fancy overpriced cupcakes for everyone on Chrome.

BUG=45869
TEST=none

Review URL: http://codereview.chromium.org/2831025
------------------------------------------------------------------------
r50616 | mirandac@google.com | 2010-06-23 19:39:13 +0200 (Wed, 23 Jun 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/ie_importer.cc

Broken by http://codereview.chromium.org/2403001/show, which eliminated a "!" that reversed the logic of the code.
Review URL: http://codereview.chromium.org/2825017
------------------------------------------------------------------------
r50614 | thakis@chromium.org | 2010-06-23 19:28:13 +0200 (Wed, 23 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite_unittest.cc

AppendASCII returns a new object.

Found by clang.

Review URL: http://codereview.chromium.org/2840017
------------------------------------------------------------------------
r50613 | sky@chromium.org | 2010-06-23 19:27:08 +0200 (Wed, 23 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   A /trunk/src/chrome/browser/views/wrench_menu.cc
   A /trunk/src/chrome/browser/views/wrench_menu.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi

Attempt 2 at landing the following. This differs from the first in
that I wasn't setting a field in a default: of a switch where I have
a NOTREACHED.

Moves cut/copy/paste and increment/descrement/fullscreen into buttons
on views.

BUG=45734
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/2868029
------------------------------------------------------------------------
r50610 | nshkrob@chromium.org | 2010-06-23 19:13:50 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Migration to TopSites from ThumbnailDatabase.

BUG=None
TEST=TopSitesTest, HistoryBackendTest, ThumbnailDatabaseTest, HistoryTest

Review URL: http://codereview.chromium.org/2869018
------------------------------------------------------------------------
r50608 | mrossetti@chromium.org | 2010-06-23 18:55:11 +0200 (Wed, 23 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   D /trunk/src/chrome/browser/views/wrench_menu.cc
   D /trunk/src/chrome/browser/views/wrench_menu.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert 50604 - Moves cut/copy/paste and increment/descrement/fullscreen into buttons
on views.

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2803013

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2829021
------------------------------------------------------------------------
r50606 | pinkerton@chromium.org | 2010-06-23 18:37:13 +0200 (Wed, 23 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   A /trunk/src/chrome/browser/cocoa/side_tab_strip_controller.h
   A /trunk/src/chrome/browser/cocoa/side_tab_strip_controller.mm
   A /trunk/src/chrome/browser/cocoa/side_tab_strip_view.h
   A /trunk/src/chrome/browser/cocoa/side_tab_strip_view.mm
   A /trunk/src/chrome/browser/cocoa/side_tab_strip_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implement side tab view and controller and hook up their creation. Parameterize tab strip layout so it can be vertical in addition to horizontal without breaking up the code too much. Abstracted some of the side tab knowledge into TabWindowController with overrides in BrowserWindowController.
Nib change: added a SideTabStripView custom view to BrowserWindow and hooked it to an outlet. Renamed the outlets to better reflect both views.
BUG=44773
TEST=Tab layout, full screen, dragging tabs within and to other windows to make sure they reflow and draw correctly. Side tabs themselves are still behind a flag, but this cl touches many normal codepaths.
Review URL: http://codereview.chromium.org/2846028
------------------------------------------------------------------------
r50604 | sky@chromium.org | 2010-06-23 18:22:02 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   A /trunk/src/chrome/browser/views/wrench_menu.cc
   A /trunk/src/chrome/browser/views/wrench_menu.h
   M /trunk/src/chrome/browser/wrench_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi

Moves cut/copy/paste and increment/descrement/fullscreen into buttons
on views.

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2803013
------------------------------------------------------------------------
r50602 | mirandac@google.com | 2010-06-23 18:12:06 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Fix theme loading bubble which was overstaying its welcome.

Fixes problem introduced in http://codereview.chromium.org/2659004/show.

BUG=46710
TEST=Bring up a regular window, and an incognito window. Install theme from incognito window. Note that loading bubble disappears at the proper time.
Review URL: http://codereview.chromium.org/2823025
------------------------------------------------------------------------
r50601 | denisromanov@chromium.org | 2010-06-23 17:55:41 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/customization_document.cc
   M /trunk/src/chrome/browser/chromeos/customization_document.h
   M /trunk/src/chrome/browser/chromeos/customization_document_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json

Added initial_timezone attribute support for startup manifest.
Added initial_timezone=Asia/Tokyo attribute to the test manifest.

BUG=http://crosbug.com/1761
TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Press Ctrl+Alt+U to switch to update screen. Clock in status area should display Tokyo time.

Review URL: http://codereview.chromium.org/2834018
------------------------------------------------------------------------
r50599 | xiyuan@chromium.org | 2010-06-23 17:46:42 +0200 (Wed, 23 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc

Fix bookmark editor regression and host hung monitor dialog.

- Fix bookmark editor size regression because the controls on it are
  not visible and caused gtk_util::ShowDialog get the wrong size;
- Host hung monitor dialog in a Chrome window as other dialogs;

BUG=none
TEST=Verify "Add Page" or "Edit" bookmark dialog shows up correctly and verify that hung monitor shows up in a chrome window instead of full screen.

Review URL: http://codereview.chromium.org/2808021
------------------------------------------------------------------------
r50597 | brettw@chromium.org | 2010-06-23 17:35:25 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/base/i18n/rtl.cc
   M /trunk/src/base/i18n/rtl.h
   M /trunk/src/base/i18n/word_iterator.cc
   M /trunk/src/base/i18n/word_iterator.h
   M /trunk/src/base/i18n/word_iterator_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/history2_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history2_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_publisher.cc
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/history/snippet.h
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/importer_messages.h
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/views/view_text_utils.cc

Replace wstring with string16 in history. The only time wstring is used now in history is for bookmark-related stuff (the bookmarks system is still wstring-based).

The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code).

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2808017
------------------------------------------------------------------------
r50595 | oshima@chromium.org | 2010-06-23 17:12:25 +0200 (Wed, 23 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/message_bubble.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Don't propagage event on message bubble to parent.
 MesssageBubble was propagating event to the parent,
which caused problem in screen locker. This change is
harmless in login screen.

Fix a cut&paste error in CHECK in grab broke handler.

BUG=chromium-os:4213
TEST=see bug for intstruction to reproduce the crash. This should fix the crash.

Review URL: http://codereview.chromium.org/2811022
------------------------------------------------------------------------
r50590 | thakis@chromium.org | 2010-06-23 16:07:27 +0200 (Wed, 23 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/common/deprecated/event_sys_unittest.cc

Mac/clang: First pass over unit_tests

Review URL: http://codereview.chromium.org/2876002
------------------------------------------------------------------------
r50589 | danno@chromium.org | 2010-06-23 15:26:11 +0200 (Wed, 23 Jun 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Enable policy support on the Linux platform.

On the Linux platform policies are read from a configuration file directory. Depending whether the chromium build is branded or not the configuration file directory is:
/etc/opt/chromium    or
/etc/opt/chrome

The configuration file directory will contain two sub-subdirectories: policies/managed
policies/recommended

The sub-directory policies/managed will contain all managed policies that are enforced on the user.

The sub-directory policies/recommended will contain policies for recommended setting that can be changed by a user.

BUG=47278
TEST=manual

Review URL: http://codereview.chromium.org/2854005
Patch from Markus Heintz <markusheintz@google.com>.
------------------------------------------------------------------------
r50581 | mnaganov@chromium.org | 2010-06-23 11:26:55 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/heap_profiler.html

Add test for Heap profiler.

TEST=DevToolsSanityTest.TestHeapProfiler
BUG=none

Review URL: http://codereview.chromium.org/2846019
------------------------------------------------------------------------
r50580 | tkent@google.com | 2010-06-23 10:15:15 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Fix ParseFeedValidFeed4, take 2.

BUG=none
TEST=none
TBR=finnur
Review URL: http://codereview.chromium.org/2842020
------------------------------------------------------------------------
r50579 | tkent@google.com | 2010-06-23 09:34:28 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Update expectation of ParseFeedValidFeed4.
r50577 (WebKit roll) changed parsing behavior.

BUG=none
TEST=This is a test.
TBR=finnur
Review URL: http://codereview.chromium.org/2835016
------------------------------------------------------------------------
r50571 | rafaelw@chromium.org | 2010-06-23 05:29:55 +0200 (Wed, 23 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Reland - Only allow installation of extensions/apps with gallery update url via download from gallery

original review here: http://codereview.chromium.org/2855009

BUG=45542
TEST=NONE
TBR=aa

Review URL: http://codereview.chromium.org/2872013
------------------------------------------------------------------------
r50570 | tim@chromium.org | 2010-06-23 05:20:08 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

sync: Add method to Directory to remove all entries for a set of ModelTypes.

BUG=40252
TEST=SyncableDirectoryTest.PurgeEntriesWithTypeIn

Review URL: http://codereview.chromium.org/2854018
------------------------------------------------------------------------
r50569 | tfarina@chromium.org | 2010-06-23 04:47:31 +0200 (Wed, 23 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc

geolocation: Fix the InfoBarType by changing it to PAGE_ACTION_TYPE.

So it matches with the design doc. See chromium.org/user-experience/infobars for
futher refence.

BUG=39102
TEST=Go to html5rocks.com/samples/geolocation/trip_meter/, see if the InfoBar
background color is blue, not green.

Review URL: http://codereview.chromium.org/2865012
------------------------------------------------------------------------
r50568 | rafaelw@chromium.org | 2010-06-23 04:39:25 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/test/data/extensions/api_test/get_views/test.js

Require tabId for infobar.show()

BUG=41515
TEST=none

Review URL: http://codereview.chromium.org/2864017
------------------------------------------------------------------------
r50566 | thestig@chromium.org | 2010-06-23 04:22:47 +0200 (Wed, 23 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/.gitignore
   M /trunk/src/base/data/valgrind/base_unittests.gtest-drmemory_win32.txt
   M /trunk/src/chrome/app/theme/balloon_wrench.png
   M /trunk/src/chrome/app/theme/bubble_l_arrow.png
   M /trunk/src/chrome/app/theme/bubble_r_arrow.png
   M /trunk/src/chrome/app/theme/fullscreen_menu_button.png
   M /trunk/src/chrome/app/theme/locationbg_c.png
   M /trunk/src/chrome/app/theme/locationbg_l.png
   M /trunk/src/chrome/app/theme/locationbg_r.png
   M /trunk/src/chrome/app/theme/sidetabs_new_tab.png
   M /trunk/src/chrome/app/theme/tab_close_dot_mask.png
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/resources/about_memory.html
   M /trunk/src/chrome/browser/resources/app_gallery_icon.png
   M /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_interactive_uitest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/installer/mac/pkg-dmg
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_has_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_lacks_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen_invalid.json
   M /trunk/src/chrome/test/data/onload_change_favicon.html
   M /trunk/src/chrome/test/live_sync/live_autofill_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_preferences_sync_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome_frame/test/data/no_interference/empty.html
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/http/url_security_manager_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_request_context.h
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/o3d/samples/assets/poolballs.png
   M /trunk/src/o3d/samples/third_party/xmljs/COPYING
   M /trunk/src/o3d/samples/third_party/xmljs/tinyxmlsax.js
   M /trunk/src/third_party/tcmalloc/vendor/vsprojects/page_heap_test/page_heap_test.vcproj
   M /trunk/src/webkit/extensions/v8/benchmarking_extension.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/support/webkit_support_glue.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Fix files with svn:executable permissions.

BUG=none
TEST=none
------------------------------------------------------------------------
r50564 | dpranke@chromium.org | 2010-06-23 03:42:16 +0200 (Wed, 23 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc

Take #3 - attempt to resubmit the ReportMetrics() change for the PasswordStore object.

Attempting to resubmit this CL. It looks like the previous CLs failed because
of some weird issue with GMock on Windows - moving the ordering of the
method declarations in password_manager_unittest seems to fix things.

    TBR=jcivelli@chromium.org
    BUG=45946
    TEST=unit_tests stays green

Review URL: http://codereview.chromium.org/2810023
------------------------------------------------------------------------
r50563 | jar@chromium.org | 2010-06-23 03:22:43 +0200 (Wed, 23 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   A /trunk/src/chrome/browser/net/connect_interceptor.cc
   A /trunk/src/chrome/browser/net/connect_interceptor.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/net/preconnect.cc
   M /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/net/dns.h

Do speculative preconnection based on network traffic (not just DNS)

This rev also handles the triple of scheme/host/port for recording
both referrers and speculative connections, so that we
can soon support SSL warming as well as "mere" TCP/IP
preconnection.

r=mbelshe
Review URL: http://codereview.chromium.org/2563004
------------------------------------------------------------------------
r50562 | thestig@chromium.org | 2010-06-23 03:18:39 +0200 (Wed, 23 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/sandbox_policy.cc

Cleanup: Remove some unneeded webkit/glue headers from chrome.

BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2850021
------------------------------------------------------------------------
r50561 | tony@chromium.org | 2010-06-23 03:17:35 +0200 (Wed, 23 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/app_modal_dialog_win.cc
   M /trunk/src/chrome/browser/js_modal_dialog.cc

Fix a crash when we try to close a js dialog that wasn't shown.

The dialog has been queued, but it hasn't been shown because a
different dialog is already showing.  We try to close the dialog
because a page navigation has occurred.

BUG=47056
TEST=None

Review URL: http://codereview.chromium.org/2803017
------------------------------------------------------------------------
r50560 | akalin@chromium.org | 2010-06-23 03:13:56 +0200 (Wed, 23 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notification_method.cc
   M /trunk/src/chrome/browser/sync/notification_method.h
   A /trunk/src/chrome/browser/sync/notifier
   A /trunk/src/chrome/browser/sync/notifier/DEPS
   A /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   A /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h
   A /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   A /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   A /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.cc
   A /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.h
   A /trunk/src/chrome/browser/sync/notifier/invalidation_util.cc
   A /trunk/src/chrome/browser/sync/notifier/invalidation_util.h
   A /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   A /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h

Implemented initial version of server-issued notification client.

Added NOTIFICATION_SERVER notification method (use
--sync-notification-method=server to turn on).

BUG=34647
TEST=manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50479

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50550

Review URL: http://codereview.chromium.org/2827014
------------------------------------------------------------------------
r50559 | jhawkins@chromium.org | 2010-06-23 02:58:48 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/jumplist.cc
   D /trunk/src/chrome/browser/jumplist.h
   A /trunk/src/chrome/browser/jumplist_win.cc (from /trunk/src/chrome/browser/jumplist.cc:50536)
   A /trunk/src/chrome/browser/jumplist_win.h (from /trunk/src/chrome/browser/jumplist.h:50536)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

TTF: Rename jumplist.cc/h to jumplist_win.cc/h as it's a win-only
file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2836020
------------------------------------------------------------------------
r50557 | akalin@chromium.org | 2010-06-23 02:52:24 +0200 (Wed, 23 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notification_method.cc
   M /trunk/src/chrome/browser/sync/notification_method.h
   D /trunk/src/chrome/browser/sync/notifier
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h

Revert 50550 - Implemented initial version of server-issued notification client.

Added NOTIFICATION_SERVER notification method (use
--sync-notification-method=server to turn on).

BUG=34647
TEST=manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50479

Review URL: http://codereview.chromium.org/2827014

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/2860015
------------------------------------------------------------------------
r50556 | thakis@chromium.org | 2010-06-23 02:37:46 +0200 (Wed, 23 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/app/surface/transport_dib_mac.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/ipc/file_descriptor_set_posix.cc
   M /trunk/src/ipc/ipc_channel_posix.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc

Clang: Do not ignore result of HANDLE_EINTR.

Review URL: http://codereview.chromium.org/2805026
------------------------------------------------------------------------
r50554 | chocobo@chromium.org | 2010-06-23 02:34:10 +0200 (Wed, 23 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc

Fix clock to use ICU's internationalization.
BUG=chromium-os:1830
TEST=ClockMenuButtonBrowserTest, manual
Review URL: http://codereview.chromium.org/2851020
------------------------------------------------------------------------
r50550 | akalin@chromium.org | 2010-06-23 02:16:45 +0200 (Wed, 23 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notification_method.cc
   M /trunk/src/chrome/browser/sync/notification_method.h
   A /trunk/src/chrome/browser/sync/notifier
   A /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   A /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h
   A /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   A /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   A /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.cc
   A /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.h
   A /trunk/src/chrome/browser/sync/notifier/invalidation_util.cc
   A /trunk/src/chrome/browser/sync/notifier/invalidation_util.h
   A /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   A /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h

Implemented initial version of server-issued notification client.

Added NOTIFICATION_SERVER notification method (use
--sync-notification-method=server to turn on).

BUG=34647
TEST=manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50479

Review URL: http://codereview.chromium.org/2827014
------------------------------------------------------------------------
r50545 | sky@chromium.org | 2010-06-23 01:51:52 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc

Makes the bookmark bubble right aligned.

BUG=40752
TEST=make sure the bookmark bubble is now right aligned (or left
     aligned for rtl locales).

Review URL: http://codereview.chromium.org/2872012
------------------------------------------------------------------------
r50544 | sky@chromium.org | 2010-06-23 01:51:05 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Makes dragging url from omnibox use same logic as copying from
omnibox.

BUG=44736
TEST=see bug

Review URL: http://codereview.chromium.org/2809030
------------------------------------------------------------------------
r50541 | albertb@chromium.org | 2010-06-23 01:00:03 +0200 (Wed, 23 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/protocol/password_specifics.proto
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

TBR: willchan
------------------------------------------------------------------------
r50539 | skrul@chromium.org | 2010-06-23 00:37:33 +0200 (Wed, 23 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc

Refactor MergePreferences to handle null values properly.
This change allows MergePreference to handle Value::TYPE_NULL values for either the local preference or the sever value.  The old way of merging into the server parameter could no longer work since if the server value was null, the return would still need to be a list or dict.  So the new API is to return the merged value and now all parameters are const.

BUG=46719
TEST=unit

Review URL: http://codereview.chromium.org/2821015
------------------------------------------------------------------------
r50538 | albertb@chromium.org | 2010-06-23 00:33:48 +0200 (Wed, 23 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/protocol/password_specifics.proto
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.cc
   M /trunk/src/chrome/browser/sync/util/cryptographer.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

DRAFT: sync_api changes to support password encryption

BUG=32410
TEST=start two browsers with --enable-sync-passwords, verify that passwords do get synced between the two

Review URL: http://codereview.chromium.org/2302001
------------------------------------------------------------------------
r50532 | robertshield@chromium.org | 2010-06-22 23:32:29 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/repost_form_warning_uitest.cc

Marking RepostFormWarningTest.TestDoubleReload and RepostFormWarningTest.TestLoginAfterRepost as flaky on Windows.

BUG=47228
TEST=none
TBR=avi,willchan

Review URL: http://codereview.chromium.org/2848019
------------------------------------------------------------------------
r50529 | sky@chromium.org | 2010-06-22 23:22:04 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.cc
   M /trunk/src/views/controls/menu/menu_host_root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc

Fixes possible crash in menus and makes widgetgtk not send out
mousemove if the event is the result of a grab.

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2841018
------------------------------------------------------------------------
r50528 | jrg@chromium.org | 2010-06-22 23:11:45 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Fix about:ipc on Mac.
Sigh.

BUG=none
TEST=about:ipc on Mac and see the dialog

Review URL: http://codereview.chromium.org/2869017
------------------------------------------------------------------------
r50523 | scherkus@chromium.org | 2010-06-22 22:49:35 +0200 (Tue, 22 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height_invalid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height_negative.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width_invalid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width_negative.json

Unreverting 50489 - Added app.launch.width and app.launch.height keys to app manifest.
------------------------------------------------------------------------
r50518 | jhawkins@chromium.org | 2010-06-22 22:39:53 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.h
   A /trunk/src/chrome/browser/parsers/metadata_parser_filebase_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

TTF: Add tests for FileMetaDataParser.

BUG=none
TEST=FileMetaDataParserTest.*

Review URL: http://codereview.chromium.org/2814022
------------------------------------------------------------------------
r50516 | davidben@chromium.org | 2010-06-22 22:36:16 +0200 (Tue, 22 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/ie7_password.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc

Use base::SHA1HashString in ie7_password::GetUrlHash

This saves a considerable amount of code. It also removes the call to CryptAcquireContext without CRYPT_VERIFYCONTEXT which is not recommended if passing a NULL container. (We were only computing a hash, so CRYPT_VERIFYCONTEXT was sufficient.)

R=wtc
BUG=none
TEST=PasswordStoreWinTest.ConvertIE7Login

Review URL: http://codereview.chromium.org/2875002
------------------------------------------------------------------------
r50513 | jhawkins@chromium.org | 2010-06-22 22:32:53 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   A /trunk/src/chrome/browser/first_run_browsertest.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   A /trunk/src/chrome/browser/first_run_unittest.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/chrome_tests.gypi

TTF: Write tests for FirstRun.

BUG=none
TEST=FirstRunTest.*

Review URL: http://codereview.chromium.org/2862024
------------------------------------------------------------------------
r50512 | andybons@chromium.org | 2010-06-22 22:32:30 +0200 (Tue, 22 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

[Mac] Adds back in the right divider at alcor's request. Tightens up the right wrench menu in Toolbar.xib.

TEST=none
BUG=45764
Review URL: http://codereview.chromium.org/2813025
------------------------------------------------------------------------
r50511 | sky@chromium.org | 2010-06-22 22:31:10 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Disables phantom tabs. I'm not nuking all the code as Nicholas/Glen thought we may yet try them again shortly.

BUG=46852
TEST=none

Review URL: http://codereview.chromium.org/2833026
------------------------------------------------------------------------
r50505 | robertshield@chromium.org | 2010-06-22 21:43:28 +0200 (Tue, 22 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height_invalid.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height_negative.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width_invalid.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width_negative.json

Revert 50489 - Added app.launch.width and app.launch.height keys to app manifest.

This allows panels and window container types to specify initial dimensions when launching.

BUG=46501
TEST=add app.launch.width/height to an app manifest with container==panel/window

Review URL: http://codereview.chromium.org/2814016

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/2823023
------------------------------------------------------------------------
r50498 | mpcomplete@chromium.org | 2010-06-22 21:24:59 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc

Fix some issues with the omnibox extension API in incognito windows.
- Don't enter "keyword" mode unless the extension is enabled and allowed in
incognito.
- Show extension suggest results for incognito windows.

BUG=46933

Review URL: http://codereview.chromium.org/2810020
------------------------------------------------------------------------
r50490 | ctguil@chromium.org | 2010-06-22 20:50:28 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix renderer accessibility for BrowserBubble objects.

Move RenderWidgetHost::SetDocumentLoaded calls from TabContents to RenderViewHost so that renderer acessibility is requested on render views that don't have a TabContents delegate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2853009
------------------------------------------------------------------------
r50489 | scherkus@chromium.org | 2010-06-22 20:45:59 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height_invalid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_height_negative.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width_invalid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_width_negative.json

Added app.launch.width and app.launch.height keys to app manifest.

This allows panels and window container types to specify initial dimensions when launching.

BUG=46501
TEST=add app.launch.width/height to an app manifest with container==panel/window

Review URL: http://codereview.chromium.org/2814016
------------------------------------------------------------------------
r50483 | robertshield@chromium.org | 2010-06-22 20:09:06 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

Marking FindInPageControllerTest, MAYBE_NoIncognitoPrepopulate as FLAKY on Windows.

BUG=40948
TEST=none
TBR=avi,willchan


Review URL: http://codereview.chromium.org/2852017
------------------------------------------------------------------------
r50482 | akalin@chromium.org | 2010-06-22 20:00:32 +0200 (Tue, 22 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notification_method.cc
   M /trunk/src/chrome/browser/sync/notification_method.h
   D /trunk/src/chrome/browser/sync/notifier
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h

Revert 50479 - Implemented initial version of server-issued notification client.

Added NOTIFICATION_SERVER notification method (use
--sync-notification-method=server to turn on).

BUG=34647
TEST=manually

Review URL: http://codereview.chromium.org/2827014

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/2805023
------------------------------------------------------------------------
r50479 | akalin@chromium.org | 2010-06-22 19:46:04 +0200 (Tue, 22 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notification_method.cc
   M /trunk/src/chrome/browser/sync/notification_method.h
   A /trunk/src/chrome/browser/sync/notifier
   A /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc
   A /trunk/src/chrome/browser/sync/notifier/cache_invalidation_packet_handler.h
   A /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.cc
   A /trunk/src/chrome/browser/sync/notifier/chrome_invalidation_client.h
   A /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.cc
   A /trunk/src/chrome/browser/sync/notifier/chrome_system_resources.h
   A /trunk/src/chrome/browser/sync/notifier/invalidation_util.cc
   A /trunk/src/chrome/browser/sync/notifier/invalidation_util.h
   A /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.cc
   A /trunk/src/chrome/browser/sync/notifier/server_notifier_thread.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h

Implemented initial version of server-issued notification client.

Added NOTIFICATION_SERVER notification method (use
--sync-notification-method=server to turn on).

BUG=34647
TEST=manually

Review URL: http://codereview.chromium.org/2827014
------------------------------------------------------------------------
r50477 | rdsmith@google.com | 2010-06-22 19:25:26 +0200 (Tue, 22 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h

Initial commit of CookieMonster statistics.

Specifically:
* Number of cookies, recorded every ten minutes of active browsing (i.e. cookies being requested from CookieMonster)
* Last access time, recorded when cookie accessed.
* Last access time for evicted cookies, recorded on eviction
* Time until cookie expires, recorded on insertion.
* Reason for a cookie being removed from store, recorded when removed.
* Size of batch update to persistent cookie store and whether it succeeded or failed, recorded at success/failure.

BUG=4005
TEST=net_unittests CookieMonster.* on Linux

Review URL: http://codereview.chromium.org/2718011
------------------------------------------------------------------------
r50475 | mdm@chromium.org | 2010-06-22 19:22:08 +0200 (Tue, 22 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Linux: allow using GNOME Keyring and KWallet for password storage via a command line flag, disabled by default.
BUG=12351, 25404, 45896
TEST=still uses default password store unless --password-store is given with a value of detect, gnome, or kwallet
Review URL: http://codereview.chromium.org/2730008
------------------------------------------------------------------------
r50473 | arv@chromium.org | 2010-06-22 19:21:34 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js

NTP: Make sure to clear the background image for fillers.

BUG=45137
TEST=See bug

Review URL: http://codereview.chromium.org/2849017
------------------------------------------------------------------------
r50472 | albertb@chromium.org | 2010-06-22 19:18:03 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Fix line endings in sync code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2860014
------------------------------------------------------------------------
r50471 | davidben@chromium.org | 2010-06-22 19:16:07 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Don't reverse left and right scrolling in GTK

R=wtc,davemoore
BUG=47076
TEST=horizontal scroll (or shift + vertical) in Linux, left/right should not be reversed

Review URL: http://codereview.chromium.org/2860011
------------------------------------------------------------------------
r50469 | dmazzoni@chromium.org | 2010-06-22 19:04:36 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Send a focus notification in addition to a document load complete notification.

BUG=47084
TEST=none

Review URL: http://codereview.chromium.org/2840014
------------------------------------------------------------------------
r50468 | robertshield@chromium.org | 2010-06-22 18:59:52 +0200 (Tue, 22 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/gtk/translate
   A /trunk/src/chrome/browser/gtk/translate_infobars.cc (from /trunk/src/chrome/browser/gtk/translate_infobars.cc:50464)
   A /trunk/src/chrome/browser/gtk/translate_infobars.h (from /trunk/src/chrome/browser/gtk/translate_infobars.h:50464)
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 50465 - Porting the infobars on Linux to the new TranslateInfobarDelegate2.
Each translate infobar is now its own class and most of the logic is in the delegate.

BUG=40828
TEST=Thoroughly test the translate feature on Linux.

Review URL: http://codereview.chromium.org/2867017

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2870019
------------------------------------------------------------------------
r50467 | hans@chromium.org | 2010-06-22 18:45:42 +0200 (Tue, 22 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   A /trunk/src/chrome/test/data/dom_storage_empty_db.html

UI test for removal of empty DOM Storage database files.

Implement tests to make sure that database files are only created when needed,
and deleted when they are empty.

BUG=39067
TEST=ui_tests --gtest_filter=DomStorageEmptyDatabaseTest.*

Review URL: http://codereview.chromium.org/2867019
------------------------------------------------------------------------
r50465 | jcivelli@chromium.org | 2010-06-22 18:10:49 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/gtk/translate
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.h
   D /trunk/src/chrome/browser/gtk/translate_infobars.cc
   D /trunk/src/chrome/browser/gtk/translate_infobars.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Porting the infobars on Linux to the new TranslateInfobarDelegate2.
Each translate infobar is now its own class and most of the logic is in the delegate.

BUG=40828
TEST=Thoroughly test the translate feature on Linux.

Review URL: http://codereview.chromium.org/2867017
------------------------------------------------------------------------
r50464 | johnnyg@chromium.org | 2010-06-22 17:53:37 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc

linux: Add Typed URLs checkbox for sync UI.  Also refactor this code for readability and more chromey style.

BUG=46914
TEST=run with --enable-sync-typed-urls, edit sync options

Review URL: http://codereview.chromium.org/2873011
------------------------------------------------------------------------
r50463 | robertshield@chromium.org | 2010-06-22 17:48:31 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Marking SSLUITest.TestCNInvalidStickiness as FLAKY on windows.

BUG=47170
TEST=none
TBR=avi,willchan

Review URL: http://codereview.chromium.org/2875006
------------------------------------------------------------------------
r50462 | dmazzoni@chromium.org | 2010-06-22 17:45:59 +0200 (Tue, 22 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/view.h

Small tweaks to improve toolbar keyboard accessibility:  Put focus rects
around more controls (including location bar, only when in full keyboard
access mode).  Fix accessible names.  Fix spacebar to activate menu buttons.
Remove methods for child focus, they're not needed anymore.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2817022
------------------------------------------------------------------------
r50461 | dhg@chromium.org | 2010-06-22 17:31:39 +0200 (Tue, 22 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/resources/mediaplayer.html
   M /trunk/src/chrome/browser/resources/playlist.html

Fixing mediaplayer UI so it has a currently playing track name, and shows error messages to the user when a song/video is unplayable.

BUG=chromium-os:3836,chromium-os:3563
TEST=none
Review URL: http://codereview.chromium.org/2829013
------------------------------------------------------------------------
r50460 | dhg@chromium.org | 2010-06-22 17:23:11 +0200 (Tue, 22 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

adding hook to filebrowser to use slideshow application to show pictures.

BUG=chromium-os:3837
TEST=none
Review URL: http://codereview.chromium.org/2858019
------------------------------------------------------------------------
r50456 | nkostylev@google.com | 2010-06-22 16:50:33 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc

In case of successful login attempt do nothing in Cancel task.
Fixes crash introduced in http://codereview.chromium.org/2867012

BUG=chromium-os:3056
TEST=Login to CrOS. Chrome should not crash after login.

Review URL: http://codereview.chromium.org/2833027
------------------------------------------------------------------------
r50453 | tfarina@chromium.org | 2010-06-22 15:43:00 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/wrench_menu_model.cc

Windows: Show the "About" menu item on the new Wrench menu.

BUG=45734
TEST=chrome\Debug\chrome --new-wrench-menu, see if the "About Google Chrome"/"About Chromium" is there.

Review URL: http://codereview.chromium.org/2858017
------------------------------------------------------------------------
r50452 | rsesek@chromium.org | 2010-06-22 15:41:09 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/menus/accelerator_cocoa.h
   A /trunk/src/chrome/browser/cocoa/accelerators_cocoa.h
   A /trunk/src/chrome/browser/cocoa/accelerators_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/accelerators_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Give the Wrench menu keyboard shortcuts.

Note that these key equivalents are for display only and do not get fired. Commands are routed through the main menu/CommandUpdater.

BUG=45098
TEST=Open Wrench menu, see keyboard shortcuts.

Review URL: http://codereview.chromium.org/2800019
------------------------------------------------------------------------
r50450 | pinkerton@chromium.org | 2010-06-22 15:33:18 +0200 (Tue, 22 Jun 2010) | 4 lines
Changed paths:
   D /trunk/src/chrome/app/nibs/SideToolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   D /trunk/src/chrome/browser/cocoa/side_tabs_toolbar_controller.h
   D /trunk/src/chrome/browser/cocoa/side_tabs_toolbar_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi

Remove traces of a toolbar controller and xib specific to side-tabs, that mock died on the vine. Toolbar is now indented along with the rest of the window content.
BUG=44773
TEST=hidden behind flag, nothing to test.
Review URL: http://codereview.chromium.org/2824021
------------------------------------------------------------------------
r50449 | nkostylev@google.com | 2010-06-22 14:25:39 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h

Hide "Continue" button when showing connecting spinner.
Fix Sign In button focus order.

BUG= http://crosbug.com/4104
TEST=manual

Review URL: http://codereview.chromium.org/2813022
------------------------------------------------------------------------
r50447 | danno@chromium.org | 2010-06-22 13:41:13 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/policy
   A /trunk/src/chrome/app/policy/windows
   A /trunk/src/chrome/app/policy/windows/adm
   A /trunk/src/chrome/app/policy/windows/adm/en-US
   A /trunk/src/chrome/app/policy/windows/adm/en-US/chrome.adm
   A /trunk/src/chrome/app/policy/windows/admx
   A /trunk/src/chrome/app/policy/windows/admx/chrome.admx
   A /trunk/src/chrome/app/policy/windows/admx/en-US
   A /trunk/src/chrome/app/policy/windows/admx/en-US/chrome.adml
   M /trunk/src/chrome/browser/config_dir_policy_provider_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc

Correct polarity and disable value of boolean policies in ADM/ADMX files

BUG=46646
TEST=manual tests

Review URL: http://codereview.chromium.org/2817021
------------------------------------------------------------------------
r50444 | mnissler@chromium.org | 2010-06-22 12:42:27 +0200 (Tue, 22 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/vertical_gradient_view.h
   A /trunk/src/chrome/browser/cocoa/vertical_gradient_view.mm
   A /trunk/src/chrome/browser/cocoa/vertical_gradient_view_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Managed preferences warning banner for Mac preferences dialog

Add a new view to the preferences dialog in Preferences.xib that holds the
alert image and the warning message label. Update the visibility of the warning
banner when switching preference views in PreferencesWindowController.

BUG=43423
TEST=none

Review URL: http://codereview.chromium.org/2831004
------------------------------------------------------------------------
r50443 | dpolukhin@chromium.org | 2010-06-22 12:31:52 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.h

Add an ability to remove user from Chrome OS login screen.

BUG=crosbug.com/2321
TEST=On user image in top right corner there is a menu button to remove user. Need changes in WM to work properly.

Review URL: http://codereview.chromium.org/2832012
------------------------------------------------------------------------
r50440 | jochen@chromium.org | 2010-06-22 12:00:58 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_notification_task.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Move content settings related events into their own delegate.

This will allow for implementing content settings related handlers outside of the tab contents object.

BUG=45230
TEST=none

Review URL: http://codereview.chromium.org/2870015
------------------------------------------------------------------------
r50434 | aa@chromium.org | 2010-06-22 09:23:19 +0200 (Tue, 22 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json

Fix typo in Gmail sample app that was preventing it from
loading.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r50433 | tony@chromium.org | 2010-06-22 08:45:22 +0200 (Tue, 22 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/tools/build/win/FILES.cfg

Load net-internals resources from resources.pak.

This is the same as r50257 with 2 fixes:
1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will
work for things tests.
2) Add back the check in chrome_paths.cc to see if we're in a
mac bundle or not.

BUG=35793,42770
TEST=none

Review URL: http://codereview.chromium.org/2865010
------------------------------------------------------------------------
r50430 | aa@chromium.org | 2010-06-22 07:20:25 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/convert_user_script.cc
   M /trunk/src/chrome/browser/extensions/convert_user_script_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/test/data/extensions/user_script_basic.user.js

Honor @version field when converting greasemonkey scripts to
extensions.

BUG=30760

Review URL: http://codereview.chromium.org/2829011
------------------------------------------------------------------------
r50429 | zelidrag@chromium.org | 2010-06-22 07:07:41 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

Removed import data from other browsers button for ChromeOS.

TEST=open options, make sure Personal Stuff tab no longer has Browsing Data section that included 'Import data from anther browser' button.
BUG=chromium-os:4137

Review URL: http://codereview.chromium.org/2866012
------------------------------------------------------------------------
r50425 | arv@chromium.org | 2010-06-22 04:41:58 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

NTP: Add a footer with History, Downloads and Help.

This removes the "Show full history" from the "Recently closed" bar since we can now get to the history using the link in the footer.

BUG=None
TEST=There should be three links at the bottom of the NTP now.

Review URL: http://codereview.chromium.org/2712004
------------------------------------------------------------------------
r50424 | cmasone@google.com | 2010-06-22 04:36:49 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h

cancel fetch of ClientLogin if it has taken too long

Not well-tested; feel free to use this as a starting point, though.

BUG=chromium-os:3056
TEST=None

Review URL: http://codereview.chromium.org/2867012
------------------------------------------------------------------------
r50422 | jrg@chromium.org | 2010-06-22 04:14:50 +0200 (Tue, 22 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

When using context menu on bookmark bar folder item, have "open in new
tab" send the folder away.

TEST=add a bookmark folder to the bar with a 'mark in it.
Open the folder.  Right click on the mark and select "open in new tab".
Make sure the bookmark menu goes away as part of this.

BUG=http://crbug.com/41816

Review URL: http://codereview.chromium.org/2808019
------------------------------------------------------------------------
r50421 | mazda@chromium.org | 2010-06-22 04:06:23 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add a slider to the mozc configration dialog for setting the integer type of configurations.

BUG=chromium-os:2625
TEST=manual

Review URL: http://codereview.chromium.org/2856011
------------------------------------------------------------------------
r50420 | pkasting@chromium.org | 2010-06-22 04:01:57 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Make right-clicking the omnibox with nothing selected select all (just like left-clicking).
Eat middle-mouse clicks on the omnibox to avoid tripping a CRichEditCtrl bug.

Original patch by Jared Wein (see http://codereview.chromium.org/2241003 ), r=me.

BUG=6873, 30134
TEST=Middle-click the omnibox, then try to click it (or any other UI element), and make sure the click has an effect. Select a portion of the URL and right-click on the omnibox. Notice that the selection does not change. Clear the selection and right-click on the omnibox and notice that the URL is automatically selected.
------------------------------------------------------------------------
r50419 | scherkus@chromium.org | 2010-06-22 03:34:25 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json

Update chat_manager's manifest due to r50278 where launch was moved under the new app section.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2862023
------------------------------------------------------------------------
r50417 | tfarina@chromium.org | 2010-06-22 03:16:25 +0200 (Tue, 22 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/gfx/utils.h

Cleanup: Get rid of chrome/common/gfx/utils.h.

- Moved the const to autocomplete_edit_view_win.cc
- Deleted the file.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2864013
------------------------------------------------------------------------
r50416 | ananta@chromium.org | 2010-06-22 03:01:32 +0200 (Tue, 22 Jun 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container_win.cc
   M /trunk/src/chrome/browser/external_tab_container_win.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   A /trunk/src/chrome_frame/test/data/chrome_frame_target_blank.html
   M /trunk/src/chrome_frame/test/test_mock_with_web_server.cc

In pages rendered in ChromeFrame window open requests or link clicks with target blank which target a different origin
should initiate the navigation in the host browser. We achieve this by performing an origin check on the opener frame
and the URL being opened. If the origins don't match we allow the host browser to handle this navigation.

There is still one issue here as a popup window creation request is still initiated and sent out to the host browser
which initiates a dummy attach external tab navigation. Subsequently while applying policy the OpenURL IPC is sent out
to the host browser which initiates the navigation to the expected URL. This causes a dummy attach external tab entry
to be created in the host browser's history which would have to be deleted.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=46667

Bug=46667
Test=Covered by new chrome frame unit test.

Review URL: http://codereview.chromium.org/2855017
------------------------------------------------------------------------
r50413 | willchan@chromium.org | 2010-06-22 02:14:23 +0200 (Tue, 22 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm

Mac/clang: Fix warning.

Review URL: http://codereview.chromium.org/2801014
------------------------------------------------------------------------
r50411 | mpcomplete@chromium.org | 2010-06-22 01:38:45 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.cc
   M /trunk/src/chrome/browser/extensions/extension_omnibox_api.h
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/examples/extensions/chrome_search
   A /trunk/src/chrome/common/extensions/docs/examples/extensions/chrome_search/background.html
   A /trunk/src/chrome/common/extensions/docs/examples/extensions/chrome_search/manifest.json
   M /trunk/src/chrome/common/extensions/docs/experimental.omnibox.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/omnibox/test.html

Address some visual problems with the omnibox extension API:
- Remove some of the boilerplate strings.
- Allow the description field to be fully customizable and stylable.

BUG=46478
BUG=46479

Review URL: http://codereview.chromium.org/2849015
------------------------------------------------------------------------
r50406 | willchan@chromium.org | 2010-06-22 01:17:24 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/service/net/service_network_change_notifier_thread.cc
   M /trunk/src/chrome/service/net/service_network_change_notifier_thread.h
   M /trunk/src/chrome/service/net/service_network_change_notifier_thread_unittest.cc
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_source_type_list.h
   M /trunk/src/net/base/network_change_notifier.cc
   M /trunk/src/net/base/network_change_notifier.h
   M /trunk/src/net/base/network_change_notifier_linux.cc
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.cc
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/base/network_change_notifier_win.h

Revert 50402 (build failure) - Pass in NetLog to NetworkChangeNotifier.
BUG=46822

Review URL: http://codereview.chromium.org/2857009

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/2843017
------------------------------------------------------------------------
r50405 | dhg@chromium.org | 2010-06-22 00:55:48 +0200 (Tue, 22 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/slideshow_ui.cc
   A /trunk/src/chrome/browser/dom_ui/slideshow_ui.h
   A /trunk/src/chrome/browser/resources/slideshow.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Adding the slideshow application.  First revision only allows you to go through the list of files.  Have not wired this into the filebrowser yet either.

BUG=chromium-os:3837
TEST=none
Review URL: http://codereview.chromium.org/2801004
------------------------------------------------------------------------
r50403 | albertb@chromium.org | 2010-06-22 00:51:40 +0200 (Tue, 22 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc

Include the username when gerenating a client tag for a password. This is
required for password sync to support multiple logins for the same URL.

BUG=46838
TEST=ProfileSyncServicePasswordTest

Review URL: http://codereview.chromium.org/2824012
------------------------------------------------------------------------
r50402 | willchan@chromium.org | 2010-06-22 00:40:35 +0200 (Tue, 22 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/service/net/service_network_change_notifier_thread.cc
   M /trunk/src/chrome/service/net/service_network_change_notifier_thread.h
   M /trunk/src/chrome/service/net/service_network_change_notifier_thread_unittest.cc
   M /trunk/src/chrome/service/service_process.cc
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_source_type_list.h
   M /trunk/src/net/base/network_change_notifier.cc
   M /trunk/src/net/base/network_change_notifier.h
   M /trunk/src/net/base/network_change_notifier_linux.cc
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.cc
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/base/network_change_notifier_win.h

Pass in NetLog to NetworkChangeNotifier.
BUG=46822

Review URL: http://codereview.chromium.org/2857009
------------------------------------------------------------------------
r50399 | cpu@chromium.org | 2010-06-22 00:27:35 +0200 (Tue, 22 Jun 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h

Adds the plugin version on the title. This shows up
in task manager:

Before

 title                     memory
 ================================================
|Plug-in: Shockwave Flash              |  XXXXX  |

After

 title                     memory
 ============================================
|Plug-in: Shockwave Flash (10,0,3,52)  |  XXXXX  |


Some crazy plug-ins embed version string on the title so for those it shows twice. There are not many that fall into that category

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/2715001
------------------------------------------------------------------------
r50398 | tim@chromium.org | 2010-06-22 00:24:31 +0200 (Tue, 22 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc

Add method to delete entries from the Directory backing sqlite file by metahandle.

This isn't used anywhere yet, but I plan to as part of the work for bug 40252.

BUG=40252
TEST=DirectoryBackingStoreTest.DeleteEntries

Review URL: http://codereview.chromium.org/2817019
------------------------------------------------------------------------
r50396 | willchan@chromium.org | 2010-06-22 00:19:35 +0200 (Tue, 22 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Mark GeolocationBrowserTest.NoInfobarForOffTheRecord as flaky.
BUG=47103

Review URL: http://codereview.chromium.org/2869013
------------------------------------------------------------------------
r50394 | akalin@chromium.org | 2010-06-22 00:15:40 +0200 (Tue, 22 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/extension_change_processor.cc

Sync only real extensions (i.e., not themes nor apps) in extensions sync.

BUG=47079
TEST=manual: with two computers with extensions sync turned on, added an app on one computer and made sure it didn't show up on another

Review URL: http://codereview.chromium.org/2847022
------------------------------------------------------------------------
r50392 | willchan@chromium.org | 2010-06-22 00:12:39 +0200 (Tue, 22 Jun 2010) | 15 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Speculatively revert 50374 (miniinstaller breakage) - Load netinternals resources from resources.pak.

This is the same as r50257 with 2 fixes:
1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will
work for things tests.
2) Add back the check in chrome_paths.cc to see if we're in a
mac bundle or not.

BUG=35793,42770
TEST=none

Review URL: http://codereview.chromium.org/2865010

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2799022
------------------------------------------------------------------------
r50388 | jhawkins@chromium.org | 2010-06-21 23:13:35 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/parsers/metadata_parser_manager.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_manager.h

Cleanup: Use ScopedVector in MetadataParserManager.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2829014
------------------------------------------------------------------------
r50387 | shess@chromium.org | 2010-06-21 23:02:32 +0200 (Mon, 21 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

[Mac] Tracking-area hygiene.

When tracking areas have an owner different from the view they are
added to, they can exist past the owner's death.  These have not been
implicated in any crashes, but it's the best idea I have for the bug.

BUG=38441
TEST=none

Review URL: http://codereview.chromium.org/2823013
------------------------------------------------------------------------
r50384 | mdm@chromium.org | 2010-06-21 22:59:09 +0200 (Mon, 21 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.cc

Linux: detect old and broken versions of GNOME Keyring and don't use them. Also some code cleanup. (Still disabled.)
TEST=should fail to load GNOME Keyring 2.22 (e.g. Ubuntu 8.04), but will load newer versions
BUG=none
Review URL: http://codereview.chromium.org/2814020
------------------------------------------------------------------------
r50381 | arv@chromium.org | 2010-06-21 22:47:02 +0200 (Mon, 21 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/resources/about_memory.html

Removing hard-coded usages of Chromium browser name.

Patch from Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>

BUG=45445
TEST=Open about:memory in a Google Chrome build and check the mouseover help dialogs --they should refer to "Google Chrome" rather than "Chromium".

Review URL: http://codereview.chromium.org/2675006
------------------------------------------------------------------------
r50379 | huanr@chromium.org | 2010-06-21 22:41:06 +0200 (Mon, 21 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix silent import from file during install.

Regression was caused by changes made for
http://code.google.com/p/chromium/issues/detail?id=40975.
The change broke first run import 
http://code.google.com/p/chromium/issues/detail?id=41077.
A fix is made but there is a bug in the fix.

BUG=46763
TEST=mini_installer.exe --installerdata="path"


Review URL: http://codereview.chromium.org/2820014
------------------------------------------------------------------------
r50375 | andybons@chromium.org | 2010-06-21 22:07:31 +0200 (Mon, 21 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] UI changes for the Browser Actions toolbar container.
o Grippy is hidden for now pending new UI. You can still resize just fine.
o The right divider is removed since the wrench menu is now always being shown.

TEST=none
BUG=45764
Review URL: http://codereview.chromium.org/2863013
------------------------------------------------------------------------
r50374 | erg@chromium.org | 2010-06-21 22:07:17 +0200 (Mon, 21 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Load net-internals resources from resources.pak.

This is the same as r50257 with 2 fixes:
1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will
work for things tests.
2) Add back the check in chrome_paths.cc to see if we're in a
mac bundle or not.

BUG=35793,42770
TEST=none

Review URL: http://codereview.chromium.org/2865010
------------------------------------------------------------------------
r50371 | pam@chromium.org | 2010-06-21 21:13:14 +0200 (Mon, 21 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/history2_ui.cc (from /trunk/src/chrome/browser/dom_ui/history_ui.cc:50108)
   A /trunk/src/chrome/browser/dom_ui/history2_ui.h (from /trunk/src/chrome/browser/dom_ui/history_ui.h:50108)
   A /trunk/src/chrome/browser/resources/dom_ui2.css (from /trunk/src/chrome/browser/resources/dom_ui.css:50108)
   A /trunk/src/chrome/browser/resources/history2.html (from /trunk/src/chrome/browser/resources/history.html:50108)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Fork chrome://history/ for development of a new UI, currently called
chrome://history2/.

BUG=2093
TEST=launch browser, navigate to chrome://history2/

Review URL: http://codereview.chromium.org/2852015
------------------------------------------------------------------------
r50369 | arv@chromium.org | 2010-06-21 20:58:43 +0200 (Mon, 21 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/shared/css/list.css
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/array_data_model.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_item.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_model_test.html
   M /trunk/src/chrome/chrome_browser.gypi

Bookmarks/DOMUI JS: Refactor the list to use a data model.

This refactors the cr.ui.List to be backed by a data model. The data model is like an array, but it dispatches events when it changes. When the data model changes the view is updated. The view is smart enough to only draw what is in the viewport which allows large data sets to be displayed.

There are a lot of TODOs after this to make the list more reusable but this is already getting big so I'd rather get this in before moving on.

TODOs:

1. Create a *real* data model for the bookmark list.
2. Move the edit behavior from bmm.BookmarkListItem to cr.ui.ListItem and make it work better with scrolling.
3. Refactor the drag and drop code so that it can be reused.
4. Refactor the selectionModel so that it does not handle the user input events.

BUG=39528
TEST=The bookmarks manager should still work.

Review URL: http://codereview.chromium.org/2842001
------------------------------------------------------------------------
r50368 | arv@chromium.org | 2010-06-21 20:57:23 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   A /trunk/src/chrome/browser/resources/ntp/apps.css
   A /trunk/src/chrome/browser/resources/ntp/apps.js

NTP: Add ability to uninstall apps from the ntp.

BUG=44915
TEST=Start chrome with --enable-apps (and optionally --enable-accelerated-compositing). Install some apps. Now hover over the app icon and click the wrench icon.

Review URL: http://codereview.chromium.org/2832014
------------------------------------------------------------------------
r50364 | ziadh@chromium.org | 2010-06-21 20:46:00 +0200 (Mon, 21 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/net.gyp
   A /trunk/src/net/socket/client_socket_pool.cc
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc

A/B test for determining a value for unused socket timeout.  Currently the
timeout defaults to 10 seconds.  Having this value set too low won't allow us
to take advantage of idle sockets.  Setting it to too high could possibly
result in more ERR_CONNECT_RESETs, requiring one RTT to receive the RST packet
and possibly another RTT to re-establish the connection.

r=jar


Review URL: http://codereview.chromium.org/2827016
------------------------------------------------------------------------
r50359 | sky@chromium.org | 2010-06-21 18:27:23 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc

Copyright change to force builders to rebuild.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2834011
------------------------------------------------------------------------
r50357 | willchan@chromium.org | 2010-06-21 18:04:50 +0200 (Mon, 21 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h

Revert 50296 (Causes DCHECK failures) - Make CookieMonster NonThreadSafe.
Made ExtensionFunction RefCountedThreadSafe so it can be posted to different threads.
Used WaitableEvent in AutomationProvider.
BUG=44083

Review URL: http://codereview.chromium.org/2756003

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/2860012
------------------------------------------------------------------------
r50356 | sky@chromium.org | 2010-06-21 18:01:53 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Nukes the new tab animation. I'll remove the images separately.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2858015
------------------------------------------------------------------------
r50354 | glotov@chromium.org | 2010-06-21 17:14:26 +0200 (Mon, 21 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/volume_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h

InfoBubble::ShowFocusless() added not to grab the focus when being shown.
Interface taken from http://codereview.chromium.org/2682004.

BUG=http://crosbug.com/525
TEST=none

Review URL: http://codereview.chromium.org/2874004
------------------------------------------------------------------------
r50353 | dpolukhin@chromium.org | 2010-06-21 17:05:54 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc

Make welcome message multiline if needed.

BUG=crosbug.com/2279
TEST=See bug description.

Review URL: http://codereview.chromium.org/2815015
------------------------------------------------------------------------
r50349 | robertshield@chromium.org | 2010-06-21 16:44:49 +0200 (Mon, 21 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc

Use correct platform #define to mark ExtensionsLoadTest as flaky (OS_MACOSX).

BUG=46301
TEST=none
TBR=avi

Review URL: http://codereview.chromium.org/2812013
------------------------------------------------------------------------
r50348 | avayvod@chromium.org | 2010-06-21 16:33:30 +0200 (Mon, 21 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Fixed wizard screen background for OOBE mode. Made wizard screen window always transparent. Removed shadow stroke from screens.

BUG=none
TEST=Verify that there's no black border around screens in OOBE mode. Also verify that there's no light blue stroke at the edge of the screens.


Review URL: http://codereview.chromium.org/2873008
------------------------------------------------------------------------
r50347 | robertshield@chromium.org | 2010-06-21 16:01:36 +0200 (Mon, 21 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Mark GeolocationBrowserTest.NoInfobarForDeniedOrigin as flaky on the mac.

BUG=47053
TEST=none
TBR=avi

Review URL: http://codereview.chromium.org/2821013
------------------------------------------------------------------------
r50346 | joth@chromium.org | 2010-06-21 15:46:36 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix a couple small todos.

BUG=none
TEST=existing unit tests + run browser and use content blocked features.

Review URL: http://codereview.chromium.org/1513024
------------------------------------------------------------------------
r50345 | joth@chromium.org | 2010-06-21 15:45:43 +0200 (Mon, 21 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_chromeos.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_chromeos.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds wifi mac addresses and cell IDs to the corresponding network library classes.
Adds basic support to Chrome for using the wifi API, and basic test.
Does not yet provide concrete implementation of the underlying methods, this will be in follow-up CLs once I have ChromeOS device.

BUG=45671
TEST=GeolocationChromeOsWifiDataProviderTest.*

Review URL: http://codereview.chromium.org/2769007
------------------------------------------------------------------------
r50343 | dpolukhin@chromium.org | 2010-06-21 12:59:44 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc

Make language selection on network screen focusable.

BUG=crosbug.com/4116
TEST=See bug description.

Review URL: http://codereview.chromium.org/2823014
------------------------------------------------------------------------
r50341 | satorux@chromium.org | 2010-06-21 11:43:14 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/input_method_library.cc (from /trunk/src/chrome/browser/chromeos/cros/language_library.cc:50340)
   A /trunk/src/chrome/browser/chromeos/cros/input_method_library.h (from /trunk/src/chrome/browser/chromeos/cros/language_library.h:50340)
   D /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   D /trunk/src/chrome/browser/chromeos/cros/language_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_input_method_library.h (from /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h:50340)
   D /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Rename *language_library* to *input_method_library*.

TEST=trybots; make -j8 chrome unit_tests browser_tests
BUG=chromium-os:4063

Review URL: http://codereview.chromium.org/2875001
------------------------------------------------------------------------
r50340 | satorux@chromium.org | 2010-06-21 11:21:02 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc

Add strings for Mozc for US Dvorak and Google Japanese Input for US Dvorak.

TEST=wrote unit tests
BUG=chromium-os:4157

Review URL: http://codereview.chromium.org/2865009
------------------------------------------------------------------------
r50338 | yusukes@google.com | 2010-06-21 11:00:42 +0200 (Mon, 21 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   M /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Move more utility functions from language_config_model to input_method_util.

- Remove the map<string,string> argument from SortInputMethodIdsByNames() function. I'll use the reviced function to implement keyboard switching in the login window.
- Moved more utility functions from language_config_model to input_method_util.

BUG=none
TEST=trybot

Review URL: http://codereview.chromium.org/2816015
------------------------------------------------------------------------
r50336 | tony@chromium.org | 2010-06-21 09:01:34 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   A /trunk/src/chrome/browser/resources_util.cc (from /trunk/src/chrome/browser/theme_resources_util.cc:50335)
   A /trunk/src/chrome/browser/resources_util.h (from /trunk/src/chrome/browser/theme_resources_util.h:50335)
   A /trunk/src/chrome/browser/resources_util_unittest.cc (from /trunk/src/chrome/browser/theme_resources_util_unittest.cc:50335)
   D /trunk/src/chrome/browser/theme_resources_util.cc
   D /trunk/src/chrome/browser/theme_resources_util.h
   D /trunk/src/chrome/browser/theme_resources_util_unittest.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Rename ThemeResourcesUtil to ResourcesUtil.

I'll be adding a map of FilePath to resource id to this class soon.
For example, FilePath("bookmark_manager/main.html") -> id.

Review URL: http://codereview.chromium.org/2870001
------------------------------------------------------------------------
r50335 | satorux@chromium.org | 2010-06-21 08:15:40 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/build/all.gyp
   A /trunk/src/chrome/browser/chromeos/input_method/candidate_window.cc (from /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc:50328)
   A /trunk/src/chrome/browser/chromeos/input_method/candidate_window.gyp (from /trunk/src/chrome/browser/chromeos/text_input/text_input.gyp:50328)
   D /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc
   D /trunk/src/chrome/browser/chromeos/text_input/text_input.gyp

Move candidate_window.cc/gyp to input_method directory.

BUG=chromium-os:4063
TEST=make -j8 BUILDTYPE=Release candidate_window

Review URL: http://codereview.chromium.org/2818017
------------------------------------------------------------------------
r50334 | tkent@chromium.org | 2010-06-21 06:56:30 +0200 (Mon, 21 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Revert 50333 - Only allow installation of extensions/apps with gallery update url via download from gallery
Because of multiple failures of unit_tests and interactive_ui_tests.

BUG=45542
TEST=NONE

Review URL: http://codereview.chromium.org/2855009

TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/2822021
------------------------------------------------------------------------
r50333 | rafaelw@chromium.org | 2010-06-21 06:07:55 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Only allow installation of extensions/apps with gallery update url via download from gallery

BUG=45542
TEST=NONE

Review URL: http://codereview.chromium.org/2855009
------------------------------------------------------------------------
r50332 | jhawkins@chromium.org | 2010-06-21 05:41:29 +0200 (Mon, 21 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field.h
   M /trunk/src/chrome/browser/autofill/autofill_field.h
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field.h
   M /trunk/src/chrome/browser/autofill/fax_field.cc
   M /trunk/src/chrome/browser/autofill/fax_field.h
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/name_field.h
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field.h

AutoFill: Use DISALLOW_COPY_AND_ASSIGN where possible.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2872008
------------------------------------------------------------------------
r50329 | atwilson@chromium.org | 2010-06-21 03:46:08 +0200 (Mon, 21 Jun 2010) | 13 lines
Changed paths:
   A /trunk/src/chrome/browser/background_contents_service.cc
   A /trunk/src/chrome/browser/background_contents_service.h
   A /trunk/src/chrome/browser/background_contents_service_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/testing_profile.h

Added BackgroundContentsService to manage lifecycle of BackgroundContents.

If --restore-background-contents flag is passed, stores the URLs of running
BackgroundContents in preferences so they can be re-launched when the browser
restarts.

Moved logic to shutdown background contents into BackgroundContentsService so
we can use this to coordinate when to keep the browser process running.

BUG=43382
TEST=new tests

Review URL: http://codereview.chromium.org/2104018
------------------------------------------------------------------------
r50327 | tim@chromium.org | 2010-06-20 22:19:59 +0200 (Sun, 20 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc

Turn autofill sync on by default. again.
again.

BUG=46592
TEST=ProfileSyncFactoryImplTest. also, open sync customize dialog, note autofill checkbox, sync autofill entries successfully.

Review URL: http://codereview.chromium.org/2872009
------------------------------------------------------------------------
r50323 | jeremy@chromium.org | 2010-06-20 08:54:00 +0200 (Sun, 20 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

Re-commit r50321 after rollback.

Mac: Infrastructure for serialization of OS fonts over IPC. Renderer & Browser bits to send and receive IPC message for OOP font loading.

Review URL: http://codereview.chromium.org/2841019
------------------------------------------------------------------------
r50322 | jeremy@chromium.org | 2010-06-20 07:33:21 +0200 (Sun, 20 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/font_loader_mac.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

Revert "Mac: Infrastructure for serialization of OS fonts over IPC."

Review URL: http://codereview.chromium.org/2846018
------------------------------------------------------------------------
r50321 | jeremy@chromium.org | 2010-06-20 07:20:25 +0200 (Sun, 20 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/font_loader_mac.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

Mac: Infrastructure for serialization of OS fonts over IPC.

Renderer & Browser bits to send and receive IPC message for OOP font loading.

BUG=29729
TEST=All unit tests should pass.

Review URL: http://codereview.chromium.org/2811013
------------------------------------------------------------------------
r50315 | avayvod@chromium.org | 2010-06-19 11:27:36 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/helper.cc
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc

Changed gradients for background view and login screens.

BUG=none
TEST=Verify that background has radial gradient from dark blue in the center to black at the edges. Screens should have linear gradient of light greyfrom top to bottom.

Review URL: http://codereview.chromium.org/2839011
------------------------------------------------------------------------
r50314 | aa@chromium.org | 2010-06-19 07:39:10 +0200 (Sat, 19 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_has_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_lacks_permission/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/app_process/manifest.json
   M /trunk/src/chrome/test/data/extensions/app/manifest.json
   A /trunk/src/chrome/test/data/extensions/app1/manifest.json
   D /trunk/src/chrome/test/data/extensions/app1.crx
   A /trunk/src/chrome/test/data/extensions/app2/manifest.json
   D /trunk/src/chrome/test/data/extensions/app2.crx
   A /trunk/src/chrome/test/data/extensions/app3/manifest.json
   D /trunk/src/chrome/test/data/extensions/app3.crx
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_value.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_without_launch_url.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen_invalid.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_local_path.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_panel.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_and_url.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_value.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_tab.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_absolute.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_window.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_disabled.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_enabled_invalid.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_not_enabled.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_web_content_disabled.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json

Re-apply r50278.

BUG=46632
TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r50312 | tim@chromium.org | 2010-06-19 04:22:37 +0200 (Sat, 19 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc

Revert 50311 - Turn autofill sync on by default.


BUG=46952
TEST=open sync customize dialog, note autofill checkbox, sync autofill entries successfully.

Review URL: http://codereview.chromium.org/2862020

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/2816017
------------------------------------------------------------------------
r50311 | tim@chromium.org | 2010-06-19 04:07:08 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc

Turn autofill sync on by default.

BUG=46952
TEST=open sync customize dialog, note autofill checkbox, sync autofill entries successfully.

Review URL: http://codereview.chromium.org/2862020
------------------------------------------------------------------------
r50310 | jcivelli@chromium.org | 2010-06-19 03:57:22 +0200 (Sat, 19 Jun 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/gtk/translate
   A /trunk/src/chrome/browser/gtk/translate_infobars.cc (from /trunk/src/chrome/browser/gtk/translate_infobars.cc:50307)
   A /trunk/src/chrome/browser/gtk/translate_infobars.h (from /trunk/src/chrome/browser/gtk/translate_infobars.h:50307)
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 50308: still failing on Linux sh-lib tests

Porting the infobars on Linux to the new TranslateInfobarDelegate2 (relanding)
Each translate infobar is now its own class and most of the logic is in the delegate.

Original review:
http://codereview.chromium.org/2836006/show

BUG=40828
TEST=Thoroughly test the translate feature on Linux.

Review URL: http://codereview.chromium.org/2817015

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2863011
------------------------------------------------------------------------
r50308 | jcivelli@chromium.org | 2010-06-19 02:52:05 +0200 (Sat, 19 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/gtk/translate
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.h
   D /trunk/src/chrome/browser/gtk/translate_infobars.cc
   D /trunk/src/chrome/browser/gtk/translate_infobars.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Porting the infobars on Linux to the new TranslateInfobarDelegate2 (relanding)
Each translate infobar is now its own class and most of the logic is in the delegate.

Original review:
http://codereview.chromium.org/2836006/show

BUG=40828
TEST=Thoroughly test the translate feature on Linux.

Review URL: http://codereview.chromium.org/2817015
------------------------------------------------------------------------
r50307 | jhawkins@chromium.org | 2010-06-19 02:21:29 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/phone_number.cc

AutoFill: Remove an out-dated comment. We will not support phone extensions.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2811017
------------------------------------------------------------------------
r50306 | jhawkins@chromium.org | 2010-06-19 02:20:29 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profile.h

AutoFill: Remove a TODO and update a comment.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2871014
------------------------------------------------------------------------
r50305 | jhawkins@chromium.org | 2010-06-19 02:18:34 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc

AutoFill: Fix a comment, remove a TODO, simplify some code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2818016
------------------------------------------------------------------------
r50304 | jhawkins@chromium.org | 2010-06-19 02:07:24 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h

AutoFill: Remove dead code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2833020
------------------------------------------------------------------------
r50303 | oshima@chromium.org | 2010-06-19 02:02:07 +0200 (Sat, 19 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

*Add WidgetGtk::ClearNativeFocus so that subclass can implement cutomized behavior when clearning native focus.
 This is necessary in ScreenLocker as the focus has to be set to the widget that is grabbing all input focus.

* PasswordField that will set focus it itself when mouse is clicked. This is necessary again when the input is grabbed by
 other widget because the gtk textfield will never receive mouse event.
* fix minor bug : locating the grab widget in wrong place.

Review URL: http://codereview.chromium.org/2811015
------------------------------------------------------------------------
r50300 | johnnyg@chromium.org | 2010-06-19 01:40:33 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_host.cc

Fix shutdown crash by sending the close notification at a point earlier in the sequence when the NotificationService is still alive.

BUG=44110
TEST=shutdown browser with notification open (need debugger to catch crash)

Review URL: http://codereview.chromium.org/2871009
------------------------------------------------------------------------
r50296 | willchan@chromium.org | 2010-06-19 01:26:17 +0200 (Sat, 19 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h

Make CookieMonster NonThreadSafe.
Made ExtensionFunction RefCountedThreadSafe so it can be posted to different threads.
Used WaitableEvent in AutomationProvider.
BUG=44083

Review URL: http://codereview.chromium.org/2756003
------------------------------------------------------------------------
r50291 | dpranke@chromium.org | 2010-06-19 01:06:21 +0200 (Sat, 19 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc

TBR: jcivelli@chromium.org
------------------------------------------------------------------------
r50290 | pkasting@chromium.org | 2010-06-19 00:44:49 +0200 (Sat, 19 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util_unittest.cc

Make FixupURL() return a GURL instead of a string (i.e. do fixup + canonicalization).  Nearly every caller was already doing this.

This in turn allows us to do better fixup/canonicalization of view-source: URLs.  We now convert "view-source:google.com" into "view-source:http://google.com/".

With a few changes scattered through the omnibox code, this also means we can do HTTP-stripping on view-source: URLs, and support the user typing in things like the case above.  This also fixes some weirdness where if you tried to type something starting with "view-source:", the What You Typed match in the dropdown would show only a scheme, or a scheme plus "http:", in some cases.

BUG=46612
TEST="view-source:google.com" should work.
Review URL: http://codereview.chromium.org/2817011
------------------------------------------------------------------------
r50289 | dpranke@chromium.org | 2010-06-19 00:30:03 +0200 (Sat, 19 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc

Re-submit 50177 - implement stubs of reporting usage metrics for the password
manager.

    BUG=45946
    R=jcivelli
    TEST=none

Review URL: http://codereview.chromium.org/2841017
------------------------------------------------------------------------
r50286 | chocobo@chromium.org | 2010-06-19 00:10:29 +0200 (Sat, 19 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

Fix preferred network to use both Google-A and Google.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2804014
------------------------------------------------------------------------
r50284 | aa@chromium.org | 2010-06-18 23:48:55 +0200 (Fri, 18 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   D /trunk/src/chrome/test/data/extensions/app1/manifest.json
   A /trunk/src/chrome/test/data/extensions/app1.crx
   D /trunk/src/chrome/test/data/extensions/app2/manifest.json
   A /trunk/src/chrome/test/data/extensions/app2.crx
   D /trunk/src/chrome/test/data/extensions/app3/manifest.json
   A /trunk/src/chrome/test/data/extensions/app3.crx
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_value.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_without_launch_url.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen_invalid.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_local_path.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_panel.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_and_url.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_value.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_tab.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_absolute.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_window.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_disabled.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_enabled_invalid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_not_enabled.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_web_content_disabled.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json

Revert r50278.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r50279 | vandebo@chromium.org | 2010-06-18 22:54:33 +0200 (Fri, 18 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc

TTF: Reenable some disabled tests.

(recommit changes that were reverted, minus troublesome one
original CL: http://codereview.chromium.org/2819011 )

DevToolsSanityTest.TestConsoleLog seems to work
ProxyResolverV8Test.FAILS_ReturnUnicode
VectorCanvasTest.FAILS_Matrix

TEST=none
BUG=disabled tests

Review URL: http://codereview.chromium.org/2870014
------------------------------------------------------------------------
r50278 | aa@chromium.org | 2010-06-18 22:53:38 +0200 (Fri, 18 Jun 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/browser/sync/glue/extension_util.cc
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   A /trunk/src/chrome/test/data/extensions/app1
   A /trunk/src/chrome/test/data/extensions/app1/manifest.json
   D /trunk/src/chrome/test/data/extensions/app1.crx
   A /trunk/src/chrome/test/data/extensions/app2
   A /trunk/src/chrome/test/data/extensions/app2/manifest.json
   D /trunk/src/chrome/test/data/extensions/app2.crx
   A /trunk/src/chrome/test/data/extensions/app3
   A /trunk/src/chrome/test/data/extensions/app3/manifest.json
   D /trunk/src/chrome/test/data/extensions/app3.crx
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_value.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_without_launch_url.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen_invalid.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_local_path.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_panel.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_and_url.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_value.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_tab.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_absolute.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/launch_window.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_disabled.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_enabled_invalid.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_not_enabled.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   D /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_web_content_disabled.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   M /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json

Some app-related manifest cleanup:

1) Group app-related keys under a new "app" key, and change
   the implementation of IsApp() to just check that.

2) Rename IsApp() and IsTheme() -> is_app(), is_theme() to
   match style guide.

3) Remove web_content.enabled. That was a stupid idea.

4) Make some kind of launch URL required for apps.

BUG=46632

Review URL: http://codereview.chromium.org/2836012
------------------------------------------------------------------------
r50277 | vandebo@chromium.org | 2010-06-18 22:46:08 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc

TTF: Disabled test, SyncerTest.FAILS_ServerDeletingFolderWeHaveAnOpenEntryIn

BUG=46621
TEST=none

Review URL: http://codereview.chromium.org/2851013
------------------------------------------------------------------------
r50274 | sky@chromium.org | 2010-06-18 22:20:48 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes regression in opening a new tab where we would open it at the
wrong spot.

BUG=46917
TEST=see bug

Review URL: http://codereview.chromium.org/2856009
------------------------------------------------------------------------
r50272 | stuartmorgan@chromium.org | 2010-06-18 21:55:07 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix mouse handling extension-hosted plugins on the Mac

BUG=42032
TEST=Flash-hosting extensions should respond to clicks.

Review URL: http://codereview.chromium.org/2873004
------------------------------------------------------------------------
r50269 | rsesek@chromium.org | 2010-06-18 21:17:00 +0200 (Fri, 18 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm

[Mac] Hook up the Delete key, in addition to the backspace key, to the Remove cookie button.

XIB change:
Add an outlet for the Remove button.

BUG=45775
TEST=Chromium-->Preferences-->UtH-->Content Settings-->Cookies. Select a cookie. Press Delete. Select another. Press backspace. 2 cookies are deleted.

Review URL: http://codereview.chromium.org/2810012
------------------------------------------------------------------------
r50267 | avayvod@chromium.org | 2010-06-18 21:02:28 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_image_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_screen.h

Stop capturing video when screen is locked. Restart image capturing when screen is unlocked.

BUG=none
TEST=(with new screen locker on L13) Login from new user login. Notice that camera light is on. Lock the screen with Ctrl-Alt-L. Notice that camera light is off. Unlock the screen. Notice that camera light is on and video is shown.


Review URL: http://codereview.chromium.org/2847019
------------------------------------------------------------------------
r50266 | oshima@chromium.org | 2010-06-18 20:55:48 +0200 (Fri, 18 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc

Fix for ScreenLocker Flicker seen on resume.
 This was caused by X drawing white background on resume.
 Chagned to not to draw any background.

Two small changes:
  Made signout button focusable.
  Fix a bug that TryGrabAllInput was not checking mouse grab.

BUG=chromium-os:4132
TEST=none

Review URL: http://codereview.chromium.org/2841011
------------------------------------------------------------------------
r50265 | eroman@chromium.org | 2010-06-18 20:39:47 +0200 (Fri, 18 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/index.html

Add some instructions to net-internals#data on how to export the captured data.
Also re-order the Data tab to appear before the others.

Review URL: http://codereview.chromium.org/2822011
------------------------------------------------------------------------
r50264 | thestig@chromium.org | 2010-06-18 20:32:37 +0200 (Fri, 18 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/renderer/render_view_unittest_mac.mm

Cleanup: Remove some unneeded WebKit headers.

BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2830012
------------------------------------------------------------------------
r50261 | vandebo@chromium.org | 2010-06-18 20:06:09 +0200 (Fri, 18 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/sandbox/src/dep_test.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc

FAILS tests should not turn the bot red.

Revert 50258 - TTF: Reenable some disabled tests.

DevToolsSanityTest.TestConsoleLog  seems to work
ProxyResolverV8Test.FAILS_ReturnUnicode
DepTest.FAILS_TestDepDisable
VectorCanvasTest.FAILS_Matrix

TEST=none
BUG=disabled tests

Review URL: http://codereview.chromium.org/2819011

TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/2862016
------------------------------------------------------------------------
r50260 | erg@chromium.org | 2010-06-18 19:52:50 +0200 (Fri, 18 Jun 2010) | 18 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Revert 50257 - Reland r50057. This is exactly the same except with two lines cherrypicked from
tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h}
files.

Load net-internals from the newly created resources.pak file.

This patch also forces the loading of the optional DataPack for const correctness reasons

Original Review: http://codereview.chromium.org/2855003

BUG=35793,42770
TEST=none
TBR=tony

Review URL: http://codereview.chromium.org/2800014

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2811016
------------------------------------------------------------------------
r50258 | vandebo@chromium.org | 2010-06-18 19:45:33 +0200 (Fri, 18 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/sandbox/src/dep_test.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc

TTF: Reenable some disabled tests.

DevToolsSanityTest.TestConsoleLog  seems to work
ProxyResolverV8Test.FAILS_ReturnUnicode
DepTest.FAILS_TestDepDisable
VectorCanvasTest.FAILS_Matrix

TEST=none
BUG=disabled tests

Review URL: http://codereview.chromium.org/2819011
------------------------------------------------------------------------
r50257 | erg@chromium.org | 2010-06-18 19:36:39 +0200 (Fri, 18 Jun 2010) | 15 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Reland r50057. This is exactly the same except with two lines cherrypicked from
tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h}
files.

Load net-internals from the newly created resources.pak file.

This patch also forces the loading of the optional DataPack for const correctness reasons

Original Review: http://codereview.chromium.org/2855003

BUG=35793,42770
TEST=none
TBR=tony

Review URL: http://codereview.chromium.org/2800014
------------------------------------------------------------------------
r50256 | ctguil@chromium.org | 2010-06-18 19:29:51 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Ensure that AccessibilityWinBrowserTest.TestRenderAccessibility passes when a screen reader is running.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2826008
------------------------------------------------------------------------
r50252 | rsesek@chromium.org | 2010-06-18 19:12:27 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h

Allow the TabRestoreService to restore individual tabs from a window.

BUG=43787
TEST=Create a window and navigate three tabs. Close the window. Go to History-->3 Tabs and select 1 tab. It is restored, but the others are not.

Review URL: http://codereview.chromium.org/2799005
------------------------------------------------------------------------
r50250 | nkostylev@google.com | 2010-06-18 19:06:57 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h

Wait for network connection on welcome screen.
Don't ask twice for secure network credentials if connection is not yet in "connecting" state by the time "Continue" is pressed

BUG= http://crosbug.com/3999
TEST=Manually. Select secure network, enter credentials and hit "Continue" immediately.

Review URL: http://codereview.chromium.org/2871012
------------------------------------------------------------------------
r50234 | dmazzoni@chromium.org | 2010-06-18 15:53:37 +0200 (Fri, 18 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.h
   M /trunk/src/chrome/browser/views/location_bar/page_action_with_badge_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_with_badge_view.h
   M /trunk/src/chrome/browser/views/location_bar/star_view.cc
   M /trunk/src/chrome/browser/views/location_bar/star_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/button/button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_unittest.cc
   A /trunk/src/views/focus/focus_search.cc
   A /trunk/src/views/focus/focus_search.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Improve toolbar keyboard accessibility.

Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en
BUG=40745
BUG=36728
BUG=36222
TEST=New test added to focus_manager_unittest.cc

Review URL: http://codereview.chromium.org/2737010
------------------------------------------------------------------------
r50231 | avayvod@chromium.org | 2010-06-18 14:15:01 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_view.h

Adds email address tooltip over user image on the login screen.

BUG=cros:2318
TEST=Get to image login screen. Verify that over user's image there's a
tooltip that shows user's email address.

Review URL: http://codereview.chromium.org/2871010
------------------------------------------------------------------------
r50223 | yusukes@google.com | 2010-06-18 12:12:21 +0200 (Fri, 18 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   D /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc
   A /trunk/src/chrome/browser/chromeos/input_method
   A /trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc
   A /trunk/src/chrome/browser/chromeos/input_method/input_method_util.h
   A /trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_model_unittest.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   D /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc
   D /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.h
   D /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Added input_method_util.h.

- Moved all functions in language_menu_l10n_util.h to the new file.
- Moved static methods in language_library.h and  language_config_model.h to the file.

BUG=none
TEST=try bot passed

Review URL: http://codereview.chromium.org/2810008
------------------------------------------------------------------------
r50222 | hbono@chromium.org | 2010-06-18 12:10:57 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc

A quick fix for Issue 37250.
Even though r15558 adjusted the position of a tabstrip in RTL languages, I'm afraid it did not adjust the position of an avator icon. This moves the tabstrip right by the size of the avatar icon in incognito mode and prevent rendering the new tab button. This change also adjusts the position of the avatar icon in RTL languages so we can get the correct position of the tabstrip in incognito mode as well.

BUG=37250
TEST=Launch chrome.exe --lang=he --incognito; open twenty tabs, and; see if we can still see the new tab button.
Review URL: http://codereview.chromium.org/2830011
------------------------------------------------------------------------
r50214 | glotov@chromium.org | 2010-06-18 08:47:06 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/volume_bubble.cc
   M /trunk/src/chrome/browser/chromeos/volume_bubble_view.h

Set volume bubble position relative to screen size.

BUG=http://crosbug.com/4136
TEST=none

Review URL: http://codereview.chromium.org/2820013
------------------------------------------------------------------------
r50209 | thestig@chromium.org | 2010-06-18 06:09:14 +0200 (Fri, 18 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler_unittest.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/about_handler.cc
   A /trunk/src/chrome/common/about_handler.h
   M /trunk/src/chrome/renderer/about_handler.cc
   M /trunk/src/chrome/renderer/about_handler.h
   A /trunk/src/chrome/renderer/renderer_about_handler_unittest.cc

Split part of about_handler into chrome/common to break the browser-renderer dependency.

BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2814012
------------------------------------------------------------------------
r50208 | tfarina@chromium.org | 2010-06-18 05:42:30 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc

diagnostics: Implement PosixConsole::Read function.

BUG=42894
TEST=enable the "Press [enter] to continue" on Posix,
     run out/Debug/chrome --diagnostics and see if it can read the line.

Review URL: http://codereview.chromium.org/2820009
------------------------------------------------------------------------
r50203 | estade@chromium.org | 2010-06-18 04:20:30 +0200 (Fri, 18 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc

Don't allow more than one pending print dialog per browser instance.

As a future TODO, it might be nice to limit it per-tab instead of per-app.

BUG=46575
TEST=manual

Review URL: http://codereview.chromium.org/2848011
------------------------------------------------------------------------
r50202 | estade@chromium.org | 2010-06-18 04:20:04 +0200 (Fri, 18 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc

Pref service strings should be std::string.

Part 1: Convert RegisterStringPref.

BUG=none
TEST=compile

Review URL: http://codereview.chromium.org/2809022
------------------------------------------------------------------------
r50201 | jrg@chromium.org | 2010-06-18 04:19:16 +0200 (Fri, 18 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

When deleting bookmark buttons, make sure all delayed messages
(e.g. for hover-open) are cancelled.

TEST=Add 100 bookmarks to the bar.
Open overflow menu.
Use context menu to delete them.
Repeat 100 times.  Make sure no crashing.

BUG=http://crbug.com/46175

Review URL: http://codereview.chromium.org/2799015
------------------------------------------------------------------------
r50200 | estade@chromium.org | 2010-06-18 04:18:31 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h

GTK: disable "OK" in App shortcut creation dialog when appropriate.

BUG=46706
TEST=see bug

Review URL: http://codereview.chromium.org/2845014
------------------------------------------------------------------------
r50197 | michaeln@chromium.org | 2010-06-18 04:02:05 +0200 (Fri, 18 Jun 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

AppCache: add plumbing to deliver logging messages to the renderer process. These messages will be plumbed thru to the console output for the page associated with 'host_id'.BUG=13685TEST=none
Review URL: http://codereview.chromium.org/2861007
------------------------------------------------------------------------
r50195 | jrg@chromium.org | 2010-06-18 03:55:40 +0200 (Fri, 18 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Dismiss bookmark bubble on tab create/destroy.

TEST=open bookmark bubble (e.g. click on the star).  Now Cmd-T for new
tab and make sure bubble goes bye-bye.

BUG=http://crbug.com/40470

Review URL: http://codereview.chromium.org/2868011
------------------------------------------------------------------------
r50191 | csilv@chromium.org | 2010-06-18 03:29:42 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.cc
   M /trunk/src/chrome/browser/dom_ui/options_ui.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable domui options for use in browser using the switch:
  --enable-tabbed-options

BUG=none
TEST=see description
Review URL: http://codereview.chromium.org/2820007
------------------------------------------------------------------------
r50185 | dpranke@chromium.org | 2010-06-18 02:52:23 +0200 (Fri, 18 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h

Unreviewed - revert 50177, 50181, 50184

Review URL: http://codereview.chromium.org/2814018
------------------------------------------------------------------------
r50184 | dpranke@chromium.org | 2010-06-18 02:37:18 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc

Unreviewed build fix - fix typo in last unreviewd build fix :(

    R=none
    BUG=none
    TEST=none

Review URL: http://codereview.chromium.org/2850013
------------------------------------------------------------------------
r50181 | dpranke@chromium.org | 2010-06-18 02:27:13 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc

build fix in password manager unit tests.

    R=none
    TEST=none
    BUG=none

Review URL: http://codereview.chromium.org/2822018
------------------------------------------------------------------------
r50178 | mpcomplete@chromium.org | 2010-06-18 02:15:38 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Fix a bug where clicking an extension omnibox keyword suggestion would
navigate you to an error page.

BUG=46480

Review URL: http://codereview.chromium.org/2819006
------------------------------------------------------------------------
r50177 | dpranke@chromium.org | 2010-06-18 02:14:58 +0200 (Fri, 18 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h

Implement stubs of a method to report usage metrics for the password manager.
This function does nothing for now but I'm submitting it to minimize the
size of the CLs to review (there will be at least two subsequent CLs, one
for Win and Linux and one for Mac).

    BUG=45946
    R=jcivelli@chromium.org
    TEST=none

Review URL: http://codereview.chromium.org/2813013
------------------------------------------------------------------------
r50176 | albertb@chromium.org | 2010-06-18 02:05:48 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

Allow InitByTagLookup for WriteNodes.

BUG=none
TEST=Modified the Nigori permanent node.

Review URL: http://codereview.chromium.org/2844004
------------------------------------------------------------------------
r50173 | eroman@chromium.org | 2010-06-18 01:57:53 +0200 (Fri, 18 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_publisher.cc

Make sure the pointer in PageData::html remains valid while PageData is called.

BUG=46835

Review URL: http://codereview.chromium.org/2852014
------------------------------------------------------------------------
r50172 | vandebo@chromium.org | 2010-06-18 01:55:28 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

TTF: Renable TabDraggingTest.Tab1Tab{2,3}
Seems to work fine on Windows and consistently fails on Linux views.

BUG=10941
TEST=local runs

Review URL: http://codereview.chromium.org/2855012
------------------------------------------------------------------------
r50169 | shess@chromium.org | 2010-06-18 01:46:48 +0200 (Fri, 18 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm

[Mac] Round off omnibox and popup.

Round off the omnibox corners like adjacent toolbar buttons.  Round
off the popup corners reflection-like.  Put back the slight gap
between them.

BUG=45762
TEST=Above stuff.  Findbar field should not be rounded.

Review URL: http://codereview.chromium.org/2863007
------------------------------------------------------------------------
r50167 | jhawkins@chromium.org | 2010-06-18 01:44:03 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h

AutoFill: De-segregate credit card filling.

BUG=45616
TEST=AutoFillManagerTest.*

Review URL: http://codereview.chromium.org/2859006
------------------------------------------------------------------------
r50161 | chocobo@chromium.org | 2010-06-18 01:09:24 +0200 (Fri, 18 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

Fix bug where auto-connect setting is not immediately saved.
Also fix Google-A wifi auto-reconnect to also try Google if Google-A is not available or not setup to auto-connect.
BUG=chromium-os:3054
TEST=manual test. when you change auto-connect setting, make sure that it's set properly when you immediately open the network options dialog again.
Review URL: http://codereview.chromium.org/2853001
------------------------------------------------------------------------
r50157 | jcivelli@chromium.org | 2010-06-18 00:53:46 +0200 (Fri, 18 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/gtk/translate
   A /trunk/src/chrome/browser/gtk/translate_infobars.cc (from /trunk/src/chrome/browser/gtk/translate_infobars.cc:50147)
   A /trunk/src/chrome/browser/gtk/translate_infobars.h (from /trunk/src/chrome/browser/gtk/translate_infobars.h:50147)
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 50148:
It causes the unit-test, ui-tests and more to fail with a not found symbol.

- Porting the infobars on Linux to the new TranslateInfobarDelegate2.
Each translate infobar is now its own class and most of the logic is in the delegate.

BUG=40828
TEST=Thoroughly test the translate feature on Linux.

Review URL: http://codereview.chromium.org/2836006

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2805016
------------------------------------------------------------------------
r50153 | eroman@chromium.org | 2010-06-18 00:46:24 +0200 (Fri, 18 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc

Speculative workaround for a crash. Not sure how it could reach this state, but testing to see if this is the cause of the crash.

BUG=46833

Review URL: http://codereview.chromium.org/2841010
------------------------------------------------------------------------
r50149 | eroman@chromium.org | 2010-06-18 00:00:26 +0200 (Fri, 18 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc

Change PassiveLogCollector to clear before adding the |max|th entry.

That way the final entry will not be cleared once the maximum has been reached.

(This addresses an earlier review comment from willchan).
Review URL: http://codereview.chromium.org/2848005
------------------------------------------------------------------------
r50148 | jcivelli@chromium.org | 2010-06-18 00:00:14 +0200 (Fri, 18 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/gtk/translate
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/after_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/before_translate_infobar_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_infobar_base_gtk.h
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/translate/translate_message_infobar_gtk.h
   D /trunk/src/chrome/browser/gtk/translate_infobars.cc
   D /trunk/src/chrome/browser/gtk/translate_infobars.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   M /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Porting the infobars on Linux to the new TranslateInfobarDelegate2.
Each translate infobar is now its own class and most of the logic is in the delegate.

BUG=40828
TEST=Thoroughly test the translate feature on Linux.

Review URL: http://codereview.chromium.org/2836006
------------------------------------------------------------------------
r50143 | willchan@chromium.org | 2010-06-17 23:58:37 +0200 (Thu, 17 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc

Add sync requests to NetLog.
BUG=46598,42695

Review URL: http://codereview.chromium.org/2860008
------------------------------------------------------------------------
r50142 | jcivelli@chromium.org | 2010-06-17 23:56:24 +0200 (Thu, 17 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/languages_menu_model2.cc

In the translate infobars (the before and after ones), it was possible to select the original language to be the same as the target one. That would cause a DCHECK when the translation happens (in TranslateManager).
We now prevent from selecting in the original combo the same language as the target language.

BUG=46727
TEST=Open a page in a language which is not the UI one (ex: www.google.de).
     You should not be able to select English as a language in the language
     menu in the translate infobar.

Review URL: http://codereview.chromium.org/2847016
------------------------------------------------------------------------
r50137 | pinkerton@chromium.org | 2010-06-17 22:52:12 +0200 (Thu, 17 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Add a 1px white bezel under the dark line separating the tab strip and the toolbar. Tabs are now responsible for mimicing this line when drawing unselected.
BUG=44574
TEST=none.
Review URL: http://codereview.chromium.org/2833014
------------------------------------------------------------------------
r50136 | oshima@chromium.org | 2010-06-17 22:51:30 +0200 (Thu, 17 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc

Correctly remove accelerator when info bubble is closed.
 accelerator was not removed when it's closed by escape accelerator. This was causing crash in screen locker.
Use "Resume" text for unlock button.
Removed unnecessary TextButton dependency in screen_lock_view.h

BUG=none
TEST=lock screen using ctrl-alt-l, type wrong password and enter then hit escape twice.
     It will not crash.

Review URL: http://codereview.chromium.org/2872004
------------------------------------------------------------------------
r50135 | oshima@chromium.org | 2010-06-17 22:50:43 +0200 (Thu, 17 Jun 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_host_browsertest.cc
   D /trunk/src/chrome/browser/chromeos/compact_navigation_bar_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/chrome_tests.gypi

Remove compact navbar: 1st step.
 Remove menu, accelerator and tests.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2812007
------------------------------------------------------------------------
r50134 | rsesek@chromium.org | 2010-06-17 22:43:19 +0200 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm

Make the HistoryMenuBridge::HistoryItem co-own the NSMenuItem. This hopefully fixes a top-crash.

BUG=46289
TEST=Open 3 windows, with 10-12 tabs in each. Cmd+W rapidly. Chrome doesn't crash. See bug for details.

Review URL: http://codereview.chromium.org/2836008
------------------------------------------------------------------------
r50126 | seh@chromium.org | 2010-06-17 19:43:37 +0200 (Thu, 17 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/background.html

Prevent sending nil central roster jid to chat rosters on initialization.
Was incorrectly clearing a valid central roster jid.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2869007
------------------------------------------------------------------------
r50125 | jcivelli@chromium.org | 2010-06-17 19:37:25 +0200 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h

Fix for a DCHECK in the infobubble.
The InfoBubble has been changed on Windows so it is parented to its border window. That caused a change in activation changes when losing focus. This resulted in Close() been called more than once, trigerring a DCHECK. This CL ensures multiple invocation of Close don't break.

BUG=46749
TEST=Bookmark a page. Click outside the bubble.
     Click the Edit button.

Review URL: http://codereview.chromium.org/2850011
------------------------------------------------------------------------
r50124 | jhawkins@chromium.org | 2010-06-17 19:35:51 +0200 (Thu, 17 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager_unittest.cc

Re-enable ProfileManagerTest.CreateAndUseTwoProfiles which was disabled due to
a Purify error (which we no longer use).

BUG=10553
TEST=ProfileManagerTest.CreateAndUseTwoProfiles

Patch by Xiaotian Chen <sargrass@google.com>

Review URL: http://codereview.chromium.org/2803009
------------------------------------------------------------------------
r50119 | jerrica@google.com | 2010-06-17 19:16:56 +0200 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

Created notification for when a session is saved.

Created a notification for when a session is saved,
so that later we can observe this notification and 
sync a session.
BUG=30519
TEST=session_service_unittest.cc
Review URL: http://codereview.chromium.org/2858005
------------------------------------------------------------------------
r50117 | zelidrag@chromium.org | 2010-06-17 19:09:05 +0200 (Thu, 17 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/chromeos/dom_ui
   A /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.cc
   A /trunk/src/chrome/browser/chromeos/dom_ui/system_options_handler.h
   A /trunk/src/chrome/browser/dom_ui/core_options_handler.cc
   A /trunk/src/chrome/browser/dom_ui/core_options_handler.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/options_ui.cc
   A /trunk/src/chrome/browser/dom_ui/options_ui.h
   A /trunk/src/chrome/browser/resources/options.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Basic code structures for rewritten options dialogs as DOM UI. Also includes the initial implementation of System page in ChromeOS options.


BUG=chromium-os:
TEST=none yet, work in progress

Review URL: http://codereview.chromium.org/2781005
------------------------------------------------------------------------
r50113 | xiyuan@chromium.org | 2010-06-17 18:26:56 +0200 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Don't show content browser for extension/theme downloads from gallery.

BUG=chromium-os:2068
TEST=Verify that install a theme/extension from gallery will not trigger content browser per zel in chromium-os:2068.

Review URL: http://codereview.chromium.org/2823008
------------------------------------------------------------------------
r50110 | mirandac@google.com | 2010-06-17 17:44:48 +0200 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/theme_install_bubble_view.h

Copyright change to help grd change along.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2814013
------------------------------------------------------------------------
r50109 | mirandac@google.com | 2010-06-17 17:38:28 +0200 (Thu, 17 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

Change string used in First Run bubble to add a mention of the search engine chosen.

BUG=46716
TEST=new first run bubble after first run import mentions the search engine: "Search using Google from right here"
Review URL: http://codereview.chromium.org/2817009
------------------------------------------------------------------------
r50104 | nkostylev@google.com | 2010-06-17 16:39:04 +0200 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc

Add "Enable WiFi" item on welcome screen.

BUG= http://crosbug.com/4033
TEST=When WiFi was disabled through network status area button it's possible to enable it back.

Review URL: http://codereview.chromium.org/2850012
------------------------------------------------------------------------
r50100 | glotov@chromium.org | 2010-06-17 16:05:43 +0200 (Thu, 17 Jun 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/language_switch_menu.cc (from /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc:49965)
   A /trunk/src/chrome/browser/chromeos/login/language_switch_menu.h (from /trunk/src/chrome/browser/chromeos/login/language_switch_model.h:49965)
   D /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc
   D /trunk/src/chrome/browser/chromeos/login/language_switch_model.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_delegate.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi

s/LanguageSwitchModel/LanguageSwitchMenu/
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2809016
------------------------------------------------------------------------
r50095 | thomasvl@chromium.org | 2010-06-17 14:30:34 +0200 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/fax_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/common/app_mode_common_mac.h

[Mac] more -Wextra support:
- autofill: explicitly initialize in the copy constructor
- make some loops clearly use {} for empty bodies
- bump up app mode version number to 1.0 so we don't check for < 0 on the unsigned version number.

BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2856006
------------------------------------------------------------------------
r50083 | avayvod@chromium.org | 2010-06-17 10:47:06 +0200 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc

Proper autocompletion of username when textfield looses focus.
Tab key doesn't get here since it's handled by focus manager.

BUG=none
TEST=Enter a name without domain in username field on login screen. Remove
focus from the field (i.e. by hitting Tab). @gmail.com should be appended.

Review URL: http://codereview.chromium.org/2829005
------------------------------------------------------------------------
r50082 | satorux@chromium.org | 2010-06-17 10:45:28 +0200 (Thu, 17 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

Rename LanguageLibrary with InputMethodLibrary.

LanguageLibrary is a misnomer. This is actually an input method library.
Will change the file name in the next change list.

Methodology of refactoring:

1. perl -i -pe 's/LanguageLibrary/InputMethodLibrary/g' **/*.cc **/*.h
2. manually fix the lines that became longer than 80 chars.
3. grep 'language_lib' **/*.{cc,h}  |grep -v '#include'
4. manually fix the variable names.

BUG=chromium-os:4063
TEST=manually

Review URL: http://codereview.chromium.org/2868009
------------------------------------------------------------------------
r50071 | tfarina@chromium.org | 2010-06-17 04:12:19 +0200 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc

diagnostics: Add VersionTest to linux.

Now with the mac build fixed.

BUG=42894
TEST=out/Debug/chrome --diagnostics

Review URL: http://codereview.chromium.org/2821009
------------------------------------------------------------------------
r50070 | scherkus@chromium.org | 2010-06-17 04:09:40 +0200 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html

Make apps launch using their default container as specified in their manifest.

The debug options were forcefully causing apps to launch as tabs.

BUG=46502
TEST=try launching a panel or window based app, it shouldn't launch as a tab

Review URL: http://codereview.chromium.org/2844008
------------------------------------------------------------------------
r50069 | satorux@chromium.org | 2010-06-17 04:07:49 +0200 (Thu, 17 Jun 2010) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/options/language_config_model.cc
   A /trunk/src/chrome/browser/chromeos/options/language_config_model.h
   A /trunk/src/chrome/browser/chromeos/options/language_config_model_unittest.cc (from /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc:50066)
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   D /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

The second step of refactoring LanguageConfigView.

No change in the logic. Just move the code around.

- Add language_config_model.cc, .h, _test.cc
- Sort function definitions and declarations so the order match in .cc and .h files.
  Search for OCD in http://www.chromium.org/developers/coding-style

TEST=manually
BUG=chromium-os:4063

Review URL: http://codereview.chromium.org/2856005
------------------------------------------------------------------------
r50068 | akalin@chromium.org | 2010-06-17 03:59:33 +0200 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc

Fixed Extension change-handling methods to avoid unrecoverable errors/crashes on adding new extensions with extensions sync turned on.

BUG=46742
TEST=manual, trybots

Review URL: http://codereview.chromium.org/2811011
------------------------------------------------------------------------
r50066 | jam@chromium.org | 2010-06-17 03:25:09 +0200 (Thu, 17 Jun 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h

Internal plugin needs to be loaded in a different place for the Linux sandbox.
Review URL: http://codereview.chromium.org/2817012
------------------------------------------------------------------------
r50062 | aa@chromium.org | 2010-06-17 03:08:13 +0200 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   A /trunk/src/chrome/test/data/extensions/theme_i18n
   A /trunk/src/chrome/test/data/extensions/theme_i18n/_locales
   A /trunk/src/chrome/test/data/extensions/theme_i18n/_locales/en
   A /trunk/src/chrome/test/data/extensions/theme_i18n/_locales/en/messages.json
   A /trunk/src/chrome/test/data/extensions/theme_i18n/manifest.json

Allow themes to be localized. This doesn't show up anywhere
in Chrome (yet), but it is used by the gallery.

BUG=46379

Review URL: http://codereview.chromium.org/2845010
------------------------------------------------------------------------
r50059 | erg@chromium.org | 2010-06-17 02:45:34 +0200 (Thu, 17 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Revert 50057 - Load net-internals from the newly created resources.pak file.

This patch also forces the loading of the optional DataPack for const correctness reasons

BUG=35793,42770
TEST=none

Review URL: http://codereview.chromium.org/2855003

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2852011
------------------------------------------------------------------------
r50058 | jrg@chromium.org | 2010-06-17 02:33:29 +0200 (Thu, 17 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target_unittest.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

Make sure mocks are properly released by breaking retain cycles.

BUG=http://crbug.com/39282

Review URL: http://codereview.chromium.org/2842010
------------------------------------------------------------------------
r50057 | erg@chromium.org | 2010-06-17 02:29:50 +0200 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Load net-internals from the newly created resources.pak file.

This patch also forces the loading of the optional DataPack for const correctness reasons

BUG=35793,42770
TEST=none

Review URL: http://codereview.chromium.org/2855003
------------------------------------------------------------------------
r50054 | jhawkins@chromium.org | 2010-06-17 01:37:32 +0200 (Thu, 17 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

gtk: Coalesce the three name fields into a Full Name field in the AutoFill
dialog.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2799011
------------------------------------------------------------------------
r50051 | aa@chromium.org | 2010-06-17 01:25:27 +0200 (Thu, 17 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   D /trunk/src/chrome/test/data/extensions/theme_i18n

Revert 50050 - Revert r48693: This broke existing extensions that wanted to run script on XML
pages. For more info, see: http://code.google.com/p/chromium/issues/detail?id=39845#c7

TBR=rafaelw@chromium.org

TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/2812006
------------------------------------------------------------------------
r50050 | aa@chromium.org | 2010-06-17 01:20:55 +0200 (Thu, 17 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   A /trunk/src/chrome/test/data/extensions/theme_i18n
   A /trunk/src/chrome/test/data/extensions/theme_i18n/_locales
   A /trunk/src/chrome/test/data/extensions/theme_i18n/_locales/en
   A /trunk/src/chrome/test/data/extensions/theme_i18n/_locales/en/messages.json
   A /trunk/src/chrome/test/data/extensions/theme_i18n/manifest.json

Revert r48693: This broke existing extensions that wanted to run script on XML
pages. For more info, see: http://code.google.com/p/chromium/issues/detail?id=39845#c7

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r50049 | jhawkins@chromium.org | 2010-06-17 01:15:50 +0200 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

gtk: Remove the CVC from the AutoFill dialog.

BUG=46681
TEST=none

Review URL: http://codereview.chromium.org/2813015
------------------------------------------------------------------------
r50047 | jrg@chromium.org | 2010-06-17 00:39:18 +0200 (Thu, 17 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

BookmarkAllTabsControllerTest.BookmarkAllTabs fails under valgrind;
the test claims windows are left around.  Things are fine when run
normally.

For this case, sheets don't always close in time if run under valgrind.
Increase timeout to be a kinder, gentler unit test.
Remove suppression.

BUG=http://crbug.com/39282

Review URL: http://codereview.chromium.org/2814011
------------------------------------------------------------------------
r50042 | shess@chromium.org | 2010-06-17 00:09:20 +0200 (Thu, 17 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm

[Mac] Convert Omnibox border to bezier paths.

In preparation for rounding the corners.  Doing this in two pieces
because the difference between NSFrameRect*() and framing a rectangle
using NSBezierPath is a little subtle.

BUG=45762
TEST=Omnibox should look identical.

Review URL: http://codereview.chromium.org/2828008
------------------------------------------------------------------------
r50040 | georgey@chromium.org | 2010-06-17 00:00:04 +0200 (Thu, 17 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/image_button.h

Fix for UI issues on AutoFill dialog on Windows.
BUG=46525
TEST=In the bug.
Review URL: http://codereview.chromium.org/2802005
------------------------------------------------------------------------
r50034 | mdm@chromium.org | 2010-06-16 23:33:16 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.cc (from /trunk/src/chrome/browser/password_manager/password_store_gnome.cc:49824)
   A /trunk/src/chrome/browser/password_manager/native_backend_gnome_x.h (from /trunk/src/chrome/browser/password_manager/password_store_gnome.h:49824)
   A /trunk/src/chrome/browser/password_manager/native_backend_kwallet_x.cc (from /trunk/src/chrome/browser/password_manager/password_store_kwallet.cc:49824)
   A /trunk/src/chrome/browser/password_manager/native_backend_kwallet_x.h (from /trunk/src/chrome/browser/password_manager/password_store_kwallet.h:49824)
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   D /trunk/src/chrome/browser/password_manager/password_store_gnome.cc
   D /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   D /trunk/src/chrome/browser/password_manager/password_store_kwallet.cc
   D /trunk/src/chrome/browser/password_manager/password_store_kwallet.h
   A /trunk/src/chrome/browser/password_manager/password_store_x.cc
   A /trunk/src/chrome/browser/password_manager/password_store_x.h
   A /trunk/src/chrome/browser/password_manager/password_store_x_unittest.cc (from /trunk/src/chrome/browser/password_manager/password_store_default_unittest.cc:49657)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Linux: refactor GNOME Keyring and KWallet integration to allow migration from the default store, and add unit tests. Still disabled.
BUG=12351, 25404
TEST=unit tests work
Review URL: http://codereview.chromium.org/2806002
------------------------------------------------------------------------
r50032 | oshima@chromium.org | 2010-06-16 23:27:05 +0200 (Wed, 16 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   A /trunk/src/chrome/browser/chromeos/login/user_view.cc
   A /trunk/src/chrome/browser/chromeos/login/user_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor login/screen locker to use the same UserView to show user's image.
 * Created new UserView that shows the user's photo.
 * Moved common constants to helper.h with login namespace to avoid
   conflict.

BUG=none
TEST=none. CL does not change the behavior. All tests should still pass.

Review URL: http://codereview.chromium.org/2831007
------------------------------------------------------------------------
r50030 | nshkrob@chromium.org | 2010-06-16 23:03:17 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Adding TopSitesDatabase::UpdatePageRank to update rank without erasing the thumbnail. 

Also, request the thumbnails for the unknown pages when updating the top sites list.

BUG=None
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2846003
------------------------------------------------------------------------
r50025 | scottbyer@chromium.org | 2010-06-16 22:37:11 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc

Fix crashy test.
http://code.google.com/p/chromium/issues/detail?id=44547

BUG=44547
TEST=PrintDialogCloudTest.HandlersRegistered

Review URL: http://codereview.chromium.org/2241001
------------------------------------------------------------------------
r50024 | estade@chromium.org | 2010-06-16 22:36:15 +0200 (Wed, 16 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc

GTK: set chrome button xthickness to 2, regardless of theme.

In the upper chrome, we strongarm the vertical sizing of the buttons' containers, so we needn't worry about ythickness. The xthickness however affects the horizontal spacing of the buttons. This is true of both chrome theme mode and gtk+ theme mode.

Override the xthickness of the theme even in GTK+ mode because our UI is non-standard enough that it looks weird even there when the xthickness is too high.

BUG=46393
TEST=visual

Review URL: http://codereview.chromium.org/2800006
------------------------------------------------------------------------
r50023 | twiz@google.com | 2010-06-16 22:18:01 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h


Removal of an incorrect assert during the close sequence of ExtensionPopup views.  If the popup view is closing due to a change of focus event, then it is possible for an extra reference to be held onto the popup during ExtensionPopup::Close.

Bug=None
Test=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/2852002
------------------------------------------------------------------------
r50022 | mattm@chromium.org | 2010-06-16 22:12:01 +0200 (Wed, 16 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   A /trunk/src/chrome/browser/process_singleton_uitest.cc (from /trunk/src/chrome/browser/process_singleton_win_uitest.cc:49343)
   D /trunk/src/chrome/browser/process_singleton_win_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Fix ProcessSingletonWinTest using default profile.
Rename to ProcessSingletonTest.
Fix issues preventing the test from working on Linux, and enable it there.
Test both normal start up and first-run startup paths(win-only).

BUG=38572
TEST=run the test (both with and without an existing profile in the default place)

Review URL: http://codereview.chromium.org/2721007
------------------------------------------------------------------------
r50015 | albertb@chromium.org | 2010-06-16 21:40:38 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h

Reland: Client side changes to set and get nigori specifics with passing
sync_unit_tests.

BUG=none
TEST=sync_unit_tests

Review URL: http://codereview.chromium.org/2803005
------------------------------------------------------------------------
r50010 | mattm@chromium.org | 2010-06-16 21:32:17 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc

Coverity: fix wrong assignment in swap in TranslateInfoBarDelegate2::GetAfterTranslateStrings.

CID=10888
BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/2850007
------------------------------------------------------------------------
r50009 | dhg@chromium.org | 2010-06-16 21:29:03 +0200 (Wed, 16 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/mediaplayer.html

Changing mediaplayer to have a div blocker, so the context menus are not available.

BUG=chromium-os:3834
TEST=none
Review URL: http://codereview.chromium.org/2858001
------------------------------------------------------------------------
r50008 | dhollowa@chromium.org | 2010-06-16 21:28:55 +0200 (Wed, 16 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardSheet.xib
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm

AutoFill Mac UI : Validation, CVC Removal, Credit Card year list.

Implements changes based on review feedback with Jeff.  Validation icons should not appear in phone and fax input fields until text is input.  Credit card expiration date year dropdown should list 10 years at most.  CVC input fields are removed.

Nib changes to AutoFillCreditCardSheet.xib removes the CVC entry, associated label, and resize / relayout dialog to account for removal.

BUG=46681, 46635, 46634
TEST=Manual testing, AutoFillDialogControllerTest.*, AutoFillAddressViewControllerTest.*, AutoFillCreditCardViewControllerTest.*

Review URL: http://codereview.chromium.org/2873002
------------------------------------------------------------------------
r50002 | thakis@chromium.org | 2010-06-16 20:39:53 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/base/linked_list.h
   M /trunk/src/base/logging.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/third_party/dmg_fp/dtoa.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/sandbox/sandbox.gyp
   M /trunk/src/skia/skia.gyp
   M /trunk/src/testing/gmock/include/gmock/gmock-actions.h
   M /trunk/src/testing/gtest.gyp

Revert 49982 - patch

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2825006
------------------------------------------------------------------------
r50000 | thakis@chromium.org | 2010-06-16 20:37:13 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/app/surface/transport_dib_mac.cc
   M /trunk/src/base/mach_ipc_mac.h
   M /trunk/src/base/scoped_nsobject.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.mm
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   M /trunk/src/chrome/browser/cocoa/authorization_util.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   D /trunk/src/libjingle.patch
   D /trunk/src/webcore.patch

Revert 49984 - patch from issue 2762014

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2835007
------------------------------------------------------------------------
r49999 | thakis@chromium.org | 2010-06-16 20:35:43 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/base/callback.h
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

Revert 49985 - doh

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2813012
------------------------------------------------------------------------
r49998 | thakis@chromium.org | 2010-06-16 20:35:05 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Revert 49986 - crash

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2808011
------------------------------------------------------------------------
r49997 | thakis@chromium.org | 2010-06-16 20:34:34 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h

Revert 49987 - x

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2836005
------------------------------------------------------------------------
r49995 | thakis@chromium.org | 2010-06-16 20:33:29 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/objc_zombie.mm
   M /trunk/src/ipc/file_descriptor_set_posix.cc
   M /trunk/src/ipc/ipc_channel_posix.cc

Revert 49989 - x

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2822013
------------------------------------------------------------------------
r49993 | mpcomplete@chromium.org | 2010-06-16 20:31:53 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc

Allow POST requests made from an extension process to reuse the same process,
even when navigating to an external URL. See bug for details.

BUG=39025

Review URL: http://codereview.chromium.org/2800005
------------------------------------------------------------------------
r49989 | thakis@chromium.org | 2010-06-16 20:26:06 +0200 (Wed, 16 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/objc_zombie.mm
   M /trunk/src/ipc/file_descriptor_set_posix.cc
   M /trunk/src/ipc/ipc_channel_posix.cc

x
------------------------------------------------------------------------
r49987 | thakis@chromium.org | 2010-06-16 20:25:58 +0200 (Wed, 16 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h

x
------------------------------------------------------------------------
r49986 | thakis@chromium.org | 2010-06-16 20:25:54 +0200 (Wed, 16 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

crash
------------------------------------------------------------------------
r49985 | thakis@chromium.org | 2010-06-16 20:25:50 +0200 (Wed, 16 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/base/callback.h
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

doh
------------------------------------------------------------------------
r49984 | thakis@chromium.org | 2010-06-16 20:25:46 +0200 (Wed, 16 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/app/surface/transport_dib_mac.cc
   M /trunk/src/base/mach_ipc_mac.h
   M /trunk/src/base/scoped_nsobject.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.mm
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   M /trunk/src/chrome/browser/cocoa/authorization_util.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   A /trunk/src/libjingle.patch
   A /trunk/src/webcore.patch

patch from issue 2762014
------------------------------------------------------------------------
r49982 | thakis@chromium.org | 2010-06-16 20:25:37 +0200 (Wed, 16 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/base/linked_list.h
   M /trunk/src/base/logging.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/third_party/dmg_fp/dtoa.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/sandbox/sandbox.gyp
   M /trunk/src/skia/skia.gyp
   M /trunk/src/testing/gmock/include/gmock/gmock-actions.h
   M /trunk/src/testing/gtest.gyp

patch
------------------------------------------------------------------------
r49981 | pathorn@chromium.org | 2010-06-16 20:25:29 +0200 (Wed, 16 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h

Measure loading time of several tabs.

This is a new set of JSON automation calls which return the individual load times for each tab opened at startup.

BUG=44129
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49862

Review URL: http://codereview.chromium.org/2559001
------------------------------------------------------------------------
r49980 | zelidrag@chromium.org | 2010-06-16 20:15:00 +0200 (Wed, 16 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log_unittest.cc

Landing CL http://codereview.chromium.org/2767013/show on behalf of petkov@chromium.org:

Add one more Chrome OS hardware class MetricsLog unit tests. 

Since the hardware class attribute is added to the XML when the log is 
closed, it's important to test for its presence in the encoded string 
when the log contains some events. The existing unit test covers only 
the case when the log is empty. 

BUG=none 
TEST=ran unit tests 


Review URL: http://codereview.chromium.org/2814005
------------------------------------------------------------------------
r49979 | csilv@chromium.org | 2010-06-16 20:07:20 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm

Add observers to ContentSettingsDialogController so that the dialog will show
live updates in response to sycronization.

BUG=41335
TEST=Open the 'Content settings' dialog on two separate instances of Chromium
when both are synced to the same account.  Change settings on computer A,
settings should auto-update on computer B.
Review URL: http://codereview.chromium.org/2063020
------------------------------------------------------------------------
r49978 | dhollowa@chromium.org | 2010-06-16 19:55:00 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/contact_info.cc

AutoFill duplicate NAME_FULL checks.

Removes collision with NAME_FULL checks in AutoFill code.  Parallel implementations collided in the ether.  These changes consolidate the implementations.

BUG=46625
TEST=ContactInfoTest.TestSetFullName

Review URL: http://codereview.chromium.org/2849008
------------------------------------------------------------------------
r49977 | skerner@chromium.org | 2010-06-16 19:54:41 +0200 (Wed, 16 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h

Revert 49967 - Client side changes to set and get nigori specifics.

BUG=none
TEST=after patching in 2844004, I was able to successfully modify the Nigori permanent node.

Review URL: http://codereview.chromium.org/2815009

TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/2860007
------------------------------------------------------------------------
r49973 | stuartmorgan@chromium.org | 2010-06-16 19:39:51 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc

Fix argument to glTexEnvi in accelerated Mac surface

BUG=None
TEST=Core Animation plugins still work.

Review URL: http://codereview.chromium.org/2805010
------------------------------------------------------------------------
r49971 | jerrica@google.com | 2010-06-16 19:33:18 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc

Added a call to TruncateUTF8ToByteSize in build_commit_command.cc.

I added a call to TruncateUTF8ToByteSize in order to truncate the
title to 255 bytes.

BUG=43675
TEST=none
Review URL: http://codereview.chromium.org/2849002
------------------------------------------------------------------------
r49970 | glotov@chromium.org | 2010-06-16 19:26:54 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.cc
   A /trunk/src/chrome/browser/chromeos/volume_bubble.cc
   A /trunk/src/chrome/browser/chromeos/volume_bubble.h
   A /trunk/src/chrome/browser/chromeos/volume_bubble_view.cc
   A /trunk/src/chrome/browser/chromeos/volume_bubble_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Volume bubble added for ChromeOS.

BUG=crosbug.com/525
TEST=none

Review URL: http://codereview.chromium.org/2790012
------------------------------------------------------------------------
r49969 | csilv@chromium.org | 2010-06-16 19:08:28 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

TTF: Re-enable tests that rely on ClickModalDialogButton since it is now
supported on Mac.

BUG=45031
TEST=none
Review URL: http://codereview.chromium.org/2812003
------------------------------------------------------------------------
r49968 | rsesek@chromium.org | 2010-06-16 19:02:11 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

[Mac] Fix a leak in CookiesWindowControllerTest by giving BrowserTestHelper a fake IO thread.

Thanks to Randy Smith for tracking this down.

BUG=31586
TEST=Valgrind Mac unit_tests stay green.

Review URL: http://codereview.chromium.org/2798001
------------------------------------------------------------------------
r49967 | albertb@chromium.org | 2010-06-16 19:01:09 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h

Client side changes to set and get nigori specifics.

BUG=none
TEST=after patching in 2844004, I was able to successfully modify the Nigori permanent node.

Review URL: http://codereview.chromium.org/2815009
------------------------------------------------------------------------
r49965 | nkostylev@google.com | 2010-06-16 18:59:47 +0200 (Wed, 16 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   A /trunk/src/chrome/browser/chromeos/login/captcha_view.cc
   A /trunk/src/chrome/browser/chromeos/login/captcha_view.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   A /trunk/src/chrome/browser/chromeos/login/image_decoder.cc
   A /trunk/src/chrome/browser/chromeos/login/image_decoder.h
   A /trunk/src/chrome/browser/chromeos/login/image_downloader.cc
   A /trunk/src/chrome/browser/chromeos/login/image_downloader.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   M /trunk/src/chrome/chrome_browser.gypi

Show Captcha dialog.
Refactor ImageDownloader/ImageDecoder into a separate classes.

Resources submitted in http://codereview.chromium.org/2856003

BUG= http://crosbug.com/3486
TEST=Select "New User" screen, enter new account for this device. Enter incorrect password 3 times. After captcha is presented and entered login should succeed.

Review URL: http://codereview.chromium.org/2729020
------------------------------------------------------------------------
r49961 | avayvod@chromium.org | 2010-06-16 18:56:20 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Added browser test for accelerators on wizard screen.

BUG=none
TEST=Run browser_tests --gtest_filter=WizardControllerFlowTest\.Accelerators

Review URL: http://codereview.chromium.org/2862006
------------------------------------------------------------------------
r49959 | sky@chromium.org | 2010-06-16 18:50:49 +0200 (Wed, 16 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   A /trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/browser_with_test_window_test.h

Fixes bug in bookmark bar view if profile changed. If the profile
changed we didn't remove the old buttons, which meant when you clicked
on a button it might be past the bounds of the model. I don't think we
ever do this, but it's the only thing I could see that could cause the
crash.

Once I've nailed this down I'll nuke the CHECKs.

BUG=44642
TEST=none

Review URL: http://codereview.chromium.org/2822010
------------------------------------------------------------------------
r49958 | denisromanov@chromium.org | 2010-06-16 18:44:37 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json

Added setting the locale on startup to the initial_locale attribute in
startup customization manifest.

BUG=http://crosbug.com/3176
TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Welcome message should be in Italian.

Review URL: http://codereview.chromium.org/2853006
------------------------------------------------------------------------
r49957 | kkania@chromium.org | 2010-06-16 18:30:54 +0200 (Wed, 16 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc

[Linux] Enable ExtensionManagementTest.UpdatePermissions since bug 36890 has been fixed.
BUG=32906
TEST=none

Review URL: http://codereview.chromium.org/2567004
------------------------------------------------------------------------
r49952 | nkostylev@google.com | 2010-06-16 17:52:13 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc

Execute AuthenticateToLogin on UI thread.

Follow up CL to http://codereview.chromium.org/2820006

BUG=chromium-os:323
TEST=unit tests, and loading up a chromium os device and logging in

Review URL: http://codereview.chromium.org/2851006
------------------------------------------------------------------------
r49950 | mirandac@google.com | 2010-06-16 17:48:05 +0200 (Wed, 16 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/installer/util/master_preferences_constants.cc
   M /trunk/src/chrome/installer/util/master_preferences_constants.h

Allow randomized search engines in selection dialog.

Add an option in the master_preferences to randomize the order of logos in the search engine selection screen.  This allows us to cull out a small subset of users to take part in a test of the effects of logo position on search engine choice.

I also filed http://crbug.com/46606 to remind me to revert this change when testing is complete.

BUG=46302
TEST=Add the following options to master_preferences:

 "distribution": {
    "search_engine_experiment": true,
    "search_engine_experiment_randomize": true
  }

Run a few times as --first-run, and see search engines appear in random order in the selection box.

Review URL: http://codereview.chromium.org/2808006
------------------------------------------------------------------------
r49947 | dmazzoni@chromium.org | 2010-06-16 17:16:39 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/browser_accessibility.cc
   D /trunk/src/chrome/browser/browser_accessibility.h
   D /trunk/src/chrome/browser/browser_accessibility_manager.cc
   D /trunk/src/chrome/browser/browser_accessibility_manager.h
   A /trunk/src/chrome/browser/browser_accessibility_manager_win.cc (from /trunk/src/chrome/browser/browser_accessibility_manager.cc:49787)
   A /trunk/src/chrome/browser/browser_accessibility_manager_win.h (from /trunk/src/chrome/browser/browser_accessibility_manager.h:49787)
   D /trunk/src/chrome/browser/browser_accessibility_unittest.cc
   A /trunk/src/chrome/browser/browser_accessibility_win.cc (from /trunk/src/chrome/browser/browser_accessibility.cc:49787)
   A /trunk/src/chrome/browser/browser_accessibility_win.h (from /trunk/src/chrome/browser/browser_accessibility.h:49787)
   A /trunk/src/chrome/browser/browser_accessibility_win_unittest.cc (from /trunk/src/chrome/browser/browser_accessibility_unittest.cc:49787)
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Rename browser_accessibility to browser_accessibility_win, and same for
browser_accessibility_manager, to make it more clear that these are
Windows-only source files.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2830005
------------------------------------------------------------------------
r49945 | skerner@chromium.org | 2010-06-16 16:58:34 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/default_plugin_uitest.cc

Disable failing test DefaultPluginUITest.DefaultPluginLoadTest.

BUG=46662
TBR=alokp

Review URL: http://codereview.chromium.org/2858007
------------------------------------------------------------------------
r49941 | thomasvl@chromium.org | 2010-06-16 16:42:16 +0200 (Wed, 16 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm

Fix the error found by -Wextra, disable part of the test because it doesn't seem like it ever would have passed in the first place.

BUG=46663
TEST=none
Review URL: http://codereview.chromium.org/2802006
------------------------------------------------------------------------
r49939 | thomasvl@chromium.org | 2010-06-16 16:28:30 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/base/third_party/dmg_fp/README.chromium
   M /trunk/src/base/third_party/dmg_fp/dtoa.cc
   M /trunk/src/base/third_party/dmg_fp/g_fmt.cc
   A /trunk/src/base/third_party/dmg_fp/mac_wextra.patch
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/cocoa/objc_zombie.mm
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.h
   M /trunk/src/gpu/command_buffer/common/id_allocator.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/http/http_response_headers.cc

Working towards -Wextra
- Make loops use {} instead of a ';' to make it clear there is no body to the loop.
- Remove checks of unsigned values for <0
- coordinates should be CGFloat, not NSUInteger.

BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2865003
------------------------------------------------------------------------
r49938 | davemoore@chromium.org | 2010-06-16 16:19:46 +0200 (Wed, 16 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Peek at the event queue for wheel events for cros
BUG=NONE
Test=RenderWidgetHostTest.CoalescesWheelEvents (existing)

Review URL: http://codereview.chromium.org/2679003
------------------------------------------------------------------------
r49924 | danno@chromium.org | 2010-06-16 13:32:54 +0200 (Wed, 16 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_mac_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h
   A /trunk/src/chrome/browser/mock_configuration_policy_provider.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add policy code for proxy configuration

Augment ProxyConfig to fetch its configuration from preferences that are initialized by settings and policy (rather than getting its config directly from settings). Add policies for everything that is needed to configure a ProxyConfig and wire the policies up to the corresponding preferences.

Also remove CookieMode policy, it's harder to get right than we naively thought.

BUG=43458
TEST=ChromeUrlRequestContextTest*:ConfigurationPolicyPrefStoreTest*

Review URL: http://codereview.chromium.org/2459001
------------------------------------------------------------------------
r49913 | hans@chromium.org | 2010-06-16 11:38:59 +0200 (Wed, 16 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h

Implement WebKitClientImpl::databaseDeleteFile.

Calls to SQLiteFileSystem::deleteDatabaseFile() end up here. So far, this
functionality does not seem to have been used, but it is needed for deleting
empty local storage databases as per the bug below.

BUG=39067
TEST=None. Will be covered by test for the bug in question.

Review URL: http://codereview.chromium.org/2846004
------------------------------------------------------------------------
r49909 | satish@chromium.org | 2010-06-16 10:50:26 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui_browsertest.cc

Mark ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToDefault as flaky.

TEST=none
BUG=43441, 44548

Review URL: http://codereview.chromium.org/2833007
------------------------------------------------------------------------
r49902 | jcivelli@chromium.org | 2010-06-16 08:28:10 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc

Hide the translate infobar when a language/site gets blacklisted.

BUG=39222
TEST=See bug

Review URL: http://codereview.chromium.org/2822001
------------------------------------------------------------------------
r49901 | satorux@chromium.org | 2010-06-16 08:22:31 +0200 (Wed, 16 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc

The first step of refactoring LanguageConfigView.

Move non-View portions of code into LanguageConfigModel.
The patch just moves code around (i.e. no change in the logic)
To minimize the amount of diffs, functions are not moved.
We'll do more cleanup in the upcoming changes.

TEST=manually
BUG=chromium-os:4063

Review URL: http://codereview.chromium.org/2868001
------------------------------------------------------------------------
r49900 | dumi@chromium.org | 2010-06-16 06:51:45 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database.cc

Switching the history index DBs from fts2 to fts3, take #2: there was
a bug in our fts3 code that caused some tests to fail.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2838006
------------------------------------------------------------------------
r49895 | estade@chromium.org | 2010-06-16 05:17:35 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   D /trunk/src/chrome/browser/external_tab_container.cc
   D /trunk/src/chrome/browser/external_tab_container.h
   A /trunk/src/chrome/browser/external_tab_container_win.cc (from /trunk/src/chrome/browser/external_tab_container.cc:49892)
   A /trunk/src/chrome/browser/external_tab_container_win.h (from /trunk/src/chrome/browser/external_tab_container.h:49892)
   D /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   D /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.cc (from /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc:49892)
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.h (from /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h:49892)
   D /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   D /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_service_win.cc (from /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc:49892)
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_service_win.h (from /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h:49892)
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/chrome_browser.gypi

Clean up of chrome_browser.gypi/nacl_host files.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2860001
------------------------------------------------------------------------
r49894 | estade@chromium.org | 2010-06-16 05:16:23 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Don't spontaneously open new windows.

When users downgrade, they may get a chrome binary that doesn't respect --product-version; don't allow chrome binaries launched with this flag to open new windows in existing chrome processes.

BUG=46547
TEST=manual

Review URL: http://codereview.chromium.org/2814007
------------------------------------------------------------------------
r49893 | eroman@chromium.org | 2010-06-16 05:14:42 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list_net_log_param.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc

In addition to the logging the IP address that a TCP connect is made to, also include the port number.
This helps when debugging situations where the port has been changed.

Review URL: http://codereview.chromium.org/2808008
------------------------------------------------------------------------
r49892 | mattm@chromium.org | 2010-06-16 05:02:38 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.h

gtk: prefix CertificateManagerPage enum names to avoid namespace polution.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/2812004
------------------------------------------------------------------------
r49891 | akalin@chromium.org | 2010-06-16 05:01:54 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc

Combined both constructors of TalkMediatorImpl into one.

BUG=none
TEST=manual, trybots

Review URL: http://codereview.chromium.org/2835003
------------------------------------------------------------------------
r49887 | ajwong@chromium.org | 2010-06-16 04:17:23 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/base/message_pump_glib_unittest.cc
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/common/net/fake_network_change_notifier_thread.cc
   M /trunk/src/chrome/common/net/fake_network_change_notifier_thread_unittest.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/thread_blocker.cc
   M /trunk/src/chrome/common/net/thread_blocker_unittest.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/chrome_frame/test/proxy_factory_mock.cc
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_response_unittest.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/appcache_url_request_job_unittest.cc

Add DISABLE_RUNNABLE_METHOD_REFCOUNT to make disabling refcounts in RunnableMethods easier.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2830006
------------------------------------------------------------------------
r49885 | dpranke@chromium.org | 2010-06-16 04:00:46 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Add a histogram tracking the responses to the "remember password" infobar.

    BUG=45946
    R=jar@chromium.org, jcivelli@chromium.org
    TEST=none

Review URL: http://codereview.chromium.org/2729022
------------------------------------------------------------------------
r49884 | rafaelw@chromium.org | 2010-06-16 03:54:42 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Send WINDOW_ID_NONE in chrome.windows.onFocusChanged when all windows loose focus.

Note that this patch includes support for Views (Windows/chromeos) and GTK (Linux). I was going to do mac as well, but decided my objective-c skillz were too rusty.

BUG=32932
TEST=none

Review URL: http://codereview.chromium.org/2778001
------------------------------------------------------------------------
r49881 | michaeln@google.com | 2010-06-16 03:33:04 +0200 (Wed, 16 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc

Revert 49875 - diagnostics: Add VersionTest to linux.

BUG=42894
TEST=out/Debug/chrome --diagnostics

Review URL: http://codereview.chromium.org/2856004

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2827010
------------------------------------------------------------------------
r49880 | ananta@chromium.org | 2010-06-16 03:13:10 +0200 (Wed, 16 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome_frame/test/data/chrome_frame_tester_helpers.js
   M /trunk/src/chrome_frame/test/data/xmlhttprequest_authorization_header_test.html
   A /trunk/src/chrome_frame/test/data/xmlhttprequest_conditional_header_test.html
   M /trunk/src/chrome_frame/test/test_with_web_server.cc

ChromeFrame should allow conditional HTTP headers like if_match, if_modified_since, etc to pass through the host network
stack. Filtering out these issues causes POST requests issued by buzz to fail.

Fixes bug http://b/issue?id=2321282

Bug=2321282
Test=Covered by ChromeFrame unit test.

Review URL: http://codereview.chromium.org/2846005
------------------------------------------------------------------------
r49876 | jam@chromium.org | 2010-06-16 02:59:43 +0200 (Wed, 16 Jun 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc

Fix the internal plugin getting disabled after an update.
Review URL: http://codereview.chromium.org/2869003
------------------------------------------------------------------------
r49875 | tfarina@chromium.org | 2010-06-16 02:58:09 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc

diagnostics: Add VersionTest to linux.

BUG=42894
TEST=out/Debug/chrome --diagnostics

Review URL: http://codereview.chromium.org/2856004
------------------------------------------------------------------------
r49870 | michaeln@google.com | 2010-06-16 02:35:23 +0200 (Wed, 16 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h

Revert 49862 - Measure loading time of several tabs.

This is a new set of ui tests to load several tabs, and look at how long it takes for a subset to finish loading.

BUG=44129
TEST=none

Review URL: http://codereview.chromium.org/2559001

TBR=pathorn@chromium.org
Review URL: http://codereview.chromium.org/2813010
------------------------------------------------------------------------
r49865 | tim@chromium.org | 2010-06-16 02:13:35 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

sync: Point dev channel sync engines to clients4.google.com/chrome-sync/dev

BUG=none
TEST=create unofficial build or build with version string modifier equal to "dev".
start syncing.


Review URL: http://codereview.chromium.org/2847006
------------------------------------------------------------------------
r49862 | pathorn@chromium.org | 2010-06-16 02:08:34 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h

Measure loading time of several tabs.

This is a new set of ui tests to load several tabs, and look at how long it takes for a subset to finish loading.

BUG=44129
TEST=none

Review URL: http://codereview.chromium.org/2559001
------------------------------------------------------------------------
r49855 | tim@chromium.org | 2010-06-16 01:09:25 +0200 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

sync: null-check the Directory ChannelHookup before adding a new observer so we don't add observers twice.

BUG=46596
TEST=on a debug / unofficial build, re-login to sync (e.g. using --invalidate-sync-login). browser shouldn't crash.

Review URL: http://codereview.chromium.org/2799007
------------------------------------------------------------------------
r49853 | nick@chromium.org | 2010-06-16 01:01:19 +0200 (Wed, 16 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc

Add migration cleanup for autofill bug 38364.

The cleanup removes ny row with a string field larger than a reasonable size.  The string fields examined here are precisely the ones that were subject to corruption by the original bug.

BUG=38364
TEST=Manually created autofill profile entries with sizes greater and less than the limit.  Restarted browser and forced the migration code to trigger.  Verified that all the statements execute successfully, and that the too-large profiles were deleted.

Review URL: http://codereview.chromium.org/2805006
------------------------------------------------------------------------
r49849 | dtseng@chromium.org | 2010-06-16 00:54:52 +0200 (Wed, 16 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h

Add accessible_name property for info bubbles (so far added name to bookmark bubble object which implements WidgetWin).
TEST=none
BUG=9601
Review URL: http://codereview.chromium.org/2338001
------------------------------------------------------------------------
r49848 | tfarina@chromium.org | 2010-06-16 00:53:05 +0200 (Wed, 16 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

gtk: Remember which page user viewed last in the Certificate Manager window.

(Note: That was a TODO for Matt).

BUG=None
TEST=open the Certificate Manager window, select a tab, close it, open again, it
should opens in the tab you viewed last.

Review URL: http://codereview.chromium.org/2730016
------------------------------------------------------------------------
r49844 | michaeln@chromium.org | 2010-06-16 00:21:42 +0200 (Wed, 16 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc

ExtensionApiTest.Popup is flaky on windows.

TEST=none
BUG=46601
TBR=mpcomplete

Review URL: http://codereview.chromium.org/2868003
------------------------------------------------------------------------
r49843 | thakis@chromium.org | 2010-06-16 00:20:10 +0200 (Wed, 16 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h

Clang/mac: Declare stuff before using it.

In particular fullscreen_controller.mm:402:29: error: 'NSAnimation' may not respond to 'endFraction'

Review URL: http://codereview.chromium.org/2836002
------------------------------------------------------------------------
r49837 | seh@chromium.org | 2010-06-15 23:57:46 +0200 (Tue, 15 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgeeventtypes.js
   M /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgehook.js

Forward video chats to central roster.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2860002
------------------------------------------------------------------------
r49831 | mattm@chromium.org | 2010-06-15 22:42:20 +0200 (Tue, 15 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h

gtk: Certificate viewer should show both A-label and U-label for CN and SubjectAltName IDNs

Remove extraneous '\n' from ProcessGeneralNames.

BUG=43966
TEST=manual

Review URL: http://codereview.chromium.org/2733014
------------------------------------------------------------------------
r49830 | pinkerton@chromium.org | 2010-06-15 22:32:58 +0200 (Tue, 15 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Unify the page and wrench menus into one wrench menu. Remove pref to hide menu. 
Nib updates:
Toolbar.xib: Removed page menu and moved everything over to accomodate.
Prefs.xib: Removed "show options page/wrench menu" checkbox and moved everything up to accomodate.
BUG=45756
TEST=migration from having the pref hidden. It should become visible.
Review URL: http://codereview.chromium.org/2828005
------------------------------------------------------------------------
r49828 | sky@chromium.org | 2010-06-15 22:10:16 +0200 (Tue, 15 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   A /trunk/src/chrome/browser/views/tabs/tab_strip_interactive_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/event.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h

Attempt 2 at:
Changes the tab close button to a dot, unless you're near the button
or the tab is selected.

The only difference between this and the first is that I missed a
remove from the set if the view was deleted, which resulted in a
crash. I've added an interactive test case that covers this.

BUG=45743
TEST=none

Review URL: http://codereview.chromium.org/2863003
------------------------------------------------------------------------
r49825 | estade@chromium.org | 2010-06-15 21:57:07 +0200 (Tue, 15 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/upgrade_detector.cc

Fix windows build

BUG=none
TEST=compile
TBR=michaeln

Review URL: http://codereview.chromium.org/2808005
------------------------------------------------------------------------
r49824 | estade@chromium.org | 2010-06-15 21:46:50 +0200 (Tue, 15 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/installer/util/version.cc

Avoid a crash when installed version info is not obtainable.

I'm pretty sure the problem is due to users downgrading to versions where --product-version is not available. See the bug for more details.

BUG=46547
TEST=none

Review URL: http://codereview.chromium.org/2813005
------------------------------------------------------------------------
r49810 | gspencer@chromium.org | 2010-06-15 19:47:15 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc

Changes to make snapshots be in a portrait orientation.

TEST=built chrome locally, ran with chromeos-wm.
BUG=none

Review URL: http://codereview.chromium.org/2716011
------------------------------------------------------------------------
r49809 | mpcomplete@chromium.org | 2010-06-15 19:36:57 +0200 (Tue, 15 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc

Reenable InstallApps attempt #2. This time with a fix to
ManifestTest.AppsDisabledByDefault.

Don't cache the value of the CommandLine, since unit_tests can modify it while
the process is running.

BUG=41280

Review URL: http://codereview.chromium.org/2824005
------------------------------------------------------------------------
r49808 | thakis@chromium.org | 2010-06-15 19:34:59 +0200 (Tue, 15 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/background_tile_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_browser_cell.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.h
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_cell.h
   M /trunk/src/chrome/browser/cocoa/draggable_button.h
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.h
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/keystone_glue.h
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_test_helper.h
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller.h
   M /trunk/src/chrome/browser/cocoa/view_resizer_pong.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/render_process_impl.cc

Mac/clang: Possibly contentious changes.

As discussed on irc, we're getting rid of const NSObjects, and we're making all properties nonatomic.

const: All of cocoa takes nonconst NSObjects, and passing a const NSString to a function that takes NSString is a const violation. gcc doesn't complain about this, but clang intentionally does. constness is usually done via immutable base classes and mutable subclasses in cocoa anyway, so getting rid of const isn't that bad. Also, we don't really have a choice.

nonatomic: Some of our classes have custom setters that are not @synchronized. If the @property for that is not non-atomic, then the interface claims that the method is synchronized but the implementation actually isn't. That's a bug. gcc happens not to complain about this, but clang does. Since we shouldn't need atomic properties anywhere, the simple rule is now to just make all properties nonatomic.

Review URL: http://codereview.chromium.org/2769014
------------------------------------------------------------------------
r49804 | willchan@chromium.org | 2010-06-15 18:39:44 +0200 (Tue, 15 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.h
   A /trunk/src/chrome/browser/net/chrome_network_delegate.cc
   A /trunk/src/chrome/browser/net/chrome_network_delegate.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   A /trunk/src/net/http/http_network_delegate.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/spdy/spdy_http_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Add a net::HttpNetworkDelegate and a ChromeNetworkDelegate.
net::HttpNetworkDelegate is an interface for providing hooks into http network activity.  ChromeNetworkDelgate implements this interface in chrome/ code.  In the future, it might also implement other interfaces.  My only current intended consumer for this would be extensions.  There's no actual behavior change, this is all just plumbing for now.
BUG=29314

Review URL: http://codereview.chromium.org/2749015
------------------------------------------------------------------------
r49801 | sky@chromium.org | 2010-06-15 18:28:51 +0200 (Tue, 15 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/event.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h

Revert 49795 - Changes the tab close button to a dot, unless you're near the button
or the tab is selected.

I'm not to keen on the mouse near names, if you have better ideas
please say so.

BUG=45743
TEST=none

Review URL: http://codereview.chromium.org/2796006

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2823005
------------------------------------------------------------------------
r49799 | cmasone@google.com | 2010-06-15 18:09:27 +0200 (Tue, 15 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Use GetSystemSalt from the cryptohome lib instead of reading salt off disk.

We used to read the system salt from a file on disk, which meant that
we had to do a bunch of dancing to do some work during login on the
FILE thread instead of the UI thread.  Now, we no longer have to,
because there is an API to request the system's salt value from
cryptohomed over dbus.  This CL is a precursor to some of the other
login/cryptohome changes that are coming.

BUG=chromium-os:323
TEST=unit tests, and loading up a chromium os device and logging in

Review URL: http://codereview.chromium.org/2820006
------------------------------------------------------------------------
r49798 | denisromanov@chromium.org | 2010-06-15 18:07:45 +0200 (Tue, 15 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added --services-manifest switch, to provide Chrome OS OEM services customization manifest on the command line.
The manifest is parsed and specified OEM welcome page is opened on startup.

BUG=cros:3176
TEST=Run out/Debug/chrome --services-manifest=chrome/browser/chromeos/testdata/services_manifest.json. An URL specified in the manifest as the initial_start_page should be opened (presently http://localhost).

Review URL: http://codereview.chromium.org/2691003
------------------------------------------------------------------------
r49797 | avi@chromium.org | 2010-06-15 18:01:24 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc

Add the Mac policy provider to the pref service.

BUG=http://crbug.com/7147
TEST=as in bug

Review URL: http://codereview.chromium.org/2806003
------------------------------------------------------------------------
r49796 | satish@chromium.org | 2010-06-15 17:46:22 +0200 (Tue, 15 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui_browsertest.cc

TBR: phajdan.jr
------------------------------------------------------------------------
r49795 | sky@chromium.org | 2010-06-15 17:36:03 +0200 (Tue, 15 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/event.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h

Changes the tab close button to a dot, unless you're near the button
or the tab is selected.

I'm not to keen on the mouse near names, if you have better ideas
please say so.

BUG=45743
TEST=none

Review URL: http://codereview.chromium.org/2796006
------------------------------------------------------------------------
r49777 | hbono@chromium.org | 2010-06-15 11:08:27 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ime_input.cc

A dirty workaround for facebook.
Facebook deletes whitespace characters, including U+3000 (Ideographic Space) used by Traditional-Chinese IMEs as a place-holder, at the beginning of a comment box before WebKit replaces the place-holder with a Traditional-Chinese character. This prevents us from inputing characters with Tranditional-Chinese IMEs. As a workaround, this change just replaces U+3000 at the beginning of composition text with U+FF3F (Fullwidth Low Line), a place-holder character used by Japanese IMEs. (Fortunately, facebook does not delete it.)

BUG=45396
TEST=Open www.facebook.com, type text with Traditional Chinese IMEs in its comment box.
Review URL: http://codereview.chromium.org/2771008
------------------------------------------------------------------------
r49776 | yusukes@google.com | 2010-06-15 10:59:31 +0200 (Tue, 15 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc

Initialize |own_keyboard_lib_| correctly in the constructor to fix memory leak
 (and the valgrind errors below.)

BUG=chromium-os:46560
BUG=chromium-os:46558
TEST=manually

Review URL: http://codereview.chromium.org/2869001
------------------------------------------------------------------------
r49772 | tony@chromium.org | 2010-06-15 09:23:59 +0200 (Tue, 15 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_posix.cc
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/tools/build/linux/FILES
   M /trunk/src/chrome/tools/build/win/FILES

Load resources.pak, which should be located next to the chrome
binary.  resources.pak will contain all the files we currently have in the
resources subdirectory (it currently only has net-internals files).

On Linux, this is an eager load (before the zygote), but on Mac
and Win, this is lazily loaded as needed.  This isn't being used
yet, just adding the necessary plumbing for now.

BUG=42770

Review URL: http://codereview.chromium.org/2755006
------------------------------------------------------------------------
r49768 | dumi@chromium.org | 2010-06-15 08:25:08 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database.cc

Revert 49746. Looks like it caused some SQLite errors that probably
led to some perf regressions too.

BUG=none
TEST=none

------------------------------------------------------------------------
r49766 | tony@chromium.org | 2010-06-15 06:21:36 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_devtools_agent.cc

Remove a ResourceBundle::GetDataResource and convert people to
the StringPiece version.  In most cases, I didn't bother trying
to make the calling code more efficient since nothing seems to
be in time sensitive code.

Review URL: http://codereview.chromium.org/2827001
------------------------------------------------------------------------
r49762 | eroman@chromium.org | 2010-06-15 05:28:45 +0200 (Tue, 15 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc

Remove a DCHECK in PassiveLogCollector which was possible to trigger once the maximum number of sources per tracker was exceeded.

BUG=45801

Review URL: http://codereview.chromium.org/2725012
------------------------------------------------------------------------
r49761 | pkasting@chromium.org | 2010-06-15 05:09:12 +0200 (Tue, 15 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/net/url_fetcher.cc
   M /trunk/src/chrome/common/net/url_fetcher.h

Make the URLFetcher observe IO thread shutdown and auto-cancel its request, if any.

BUG=41547
TEST=none
Review URL: http://codereview.chromium.org/2849003
------------------------------------------------------------------------
r49760 | jam@chromium.org | 2010-06-15 04:52:47 +0200 (Tue, 15 Jun 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc

Try to fix build failure in chromeos builder
Review URL: http://codereview.chromium.org/2804003
------------------------------------------------------------------------
r49755 | dpranke@chromium.org | 2010-06-15 03:51:14 +0200 (Tue, 15 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc

Remove unnecessary header dependency and fix misleading comment.

PasswordFormManager() doesn't directly depend on the web_data_service, so
I'm removing the #include; doing so exposed a missing dependency of
the safe_browsing_service (which was failing to include chrome_thread.h
directly). Also, the comment above the constructor was wrong.

    R=tim@chromium.org
    BUG=none
    TEST=things still compile

Review URL: http://codereview.chromium.org/2770009
------------------------------------------------------------------------
r49754 | yusukes@google.com | 2010-06-15 03:50:03 +0200 (Tue, 15 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/keyboard_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/mock_keyboard_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Share the same keyboard layout among all windows.

- Call SetKeyboardLayoutPerWindow(false) in LanguageMenuButton::LanguageMenuButton().
- Mock Keyboard APIs so LanguageMenuButton::LanguageMenuButton() can call the function even in browser_tests.

In browser_tests, code like "if (CrosLibrary::Get()->EnsureLoaded()) SetKeyboardLayoutPerWindow(false);" does not work since the EnsureLoaded() function is replaced so it always returns true without loading libcros.so (i.e. the function pointer |SetKeyboardLayoutPerWindow| is NULL). We could fix this by either of the following:

1) Add NULL check: if (CrosLibrary::Get()->EnsureLoaded() && (SetKeyboardLayoutPerWindow != NULL)) SetKeyboardLayoutPerWindow(false);
2) Mock keyboard APIs and just call: CrosLibrary::Get()->GetKeyboardLibrary()->SetKeyboardLayoutPerWindow(false);

I'd choose 2), since 1) looks a bit error-prone and inconsistent with other libcros libraries (e.g. power, language, ...)
FYI, we can use the new cros/keyboard_library.h interface to implement the "swap ctrl/caps" feature in a clean way.

BUG=chromium-os:2433
TEST=manually

Review URL: http://codereview.chromium.org/2781006
------------------------------------------------------------------------
r49753 | jhawkins@chromium.org | 2010-06-15 03:47:59 +0200 (Tue, 15 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager_unittest.cc

AutoFill: Don't parse hidden fields for labels. Also don't count hidden fields
as being auto-fillable.

BUG=46463
TEST=AutoFillManagerTest.HiddenFields, FormManagerTest.LabelsHiddenFields,
FormManagerTest.LabelForElementHidden

Review URL: http://codereview.chromium.org/2809005
------------------------------------------------------------------------
r49750 | tfarina@chromium.org | 2010-06-15 02:26:32 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

gtk: Finish converting the gtk callbacks in TaskManagerGtk to gtk signal macros.

BUG=None
TEST=manual

Review URL: http://codereview.chromium.org/2801002
------------------------------------------------------------------------
r49746 | dumi@chromium.org | 2010-06-15 02:11:38 +0200 (Tue, 15 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database.cc

Make all new history index files use FTS3 instead of FTS2.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/2818004
------------------------------------------------------------------------
r49745 | mpcomplete@chromium.org | 2010-06-15 02:07:35 +0200 (Tue, 15 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc

Revert 49739 - Reenable InstallApps.

Don't cache the value of the CommandLine, since unit_tests can modify it while
the process is running.

BUG=41280

Review URL: http://codereview.chromium.org/2632001

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/2861001
------------------------------------------------------------------------
r49744 | oshima@chromium.org | 2010-06-15 01:48:28 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc

Use saved bounds when --chromeos-frame is specified.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2825002
------------------------------------------------------------------------
r49743 | chron@chromium.org | 2010-06-15 01:40:06 +0200 (Tue, 15 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.h

Add checkbox in customize sync to linux & windows for extensions.
Not hooked up yet pending another change.

Review URL: http://codereview.chromium.org/2733008
------------------------------------------------------------------------
r49741 | pkasting@chromium.org | 2010-06-15 01:19:21 +0200 (Tue, 15 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble_unittest.cc

Fix InfoBubble unittests to be more consistent in how they expect coordinate slop to work.

TBR=jcivelli
BUG=none
TEST=tests pass
Review URL: http://codereview.chromium.org/2859001
------------------------------------------------------------------------
r49739 | mpcomplete@chromium.org | 2010-06-15 00:42:40 +0200 (Tue, 15 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc

Reenable InstallApps.

Don't cache the value of the CommandLine, since unit_tests can modify it while
the process is running.

BUG=41280

Review URL: http://codereview.chromium.org/2632001
------------------------------------------------------------------------
r49736 | pkasting@chromium.org | 2010-06-15 00:23:45 +0200 (Tue, 15 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bubble_border.cc

Fix off-by-one error that crept into the BubbleBorder code.

BUG=46392
TEST=Star bubble arrow should point precisely at star center in both LTR and RTL modes.
Review URL: http://codereview.chromium.org/2833004
------------------------------------------------------------------------
r49734 | dhollowa@chromium.org | 2010-06-15 00:14:42 +0200 (Tue, 15 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillAddressSheet.xib
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardSheet.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm

AutoFill Mac dialog needs layout changes

Modifies entry labels with trailing colon for Mac UI.  Using correct validation icons now.  Nib changes for AutoFillAddressSheet.xib and AutoFillCreditCardSheet.xib: rearranges labels and entry fields to right align on label colons.  Changes label font to be regular size and regular weight.

BUG=46504
TEST=manual inspection of AutoFill UI.

Review URL: http://codereview.chromium.org/2842002
------------------------------------------------------------------------
r49727 | pkasting@chromium.org | 2010-06-14 23:08:53 +0200 (Mon, 14 Jun 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/locationbg.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak

Fix up the Windows omnibox after the recent endcap removal.  This fixes most of the issues, but doesn't make the app launcher match the new style.

BUG=45745
TEST=Omnibox has endcaps, insides are aligned and padded correctly, dropdown looks good
Review URL: http://codereview.chromium.org/2721009
------------------------------------------------------------------------
r49725 | dumi@chromium.org | 2010-06-14 22:54:59 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/text_database_manager.h

Remove old history index files.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2762012
------------------------------------------------------------------------
r49724 | mdm@chromium.org | 2010-06-14 22:48:55 +0200 (Mon, 14 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h

Linux: fix small memory leaks in passwords and exceptions dialog.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2817001
------------------------------------------------------------------------
r49723 | johnnyg@chromium.org | 2010-06-14 22:46:52 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/views/examples/widget_example.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc

Notification balloons don't want the WS_EX_LAYOUTRTL style flag, since the directionality of the content is specified already inside the HTML.

BUG=46170
TEST=create a notification while using an RTL language for Chrome UI.

Review URL: http://codereview.chromium.org/2794001
------------------------------------------------------------------------
r49722 | erg@chromium.org | 2010-06-14 22:33:51 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Remove KWin from the list of window managers that default to custom frame on.

BUG=15698
TEST=none

Review URL: http://codereview.chromium.org/2833003
------------------------------------------------------------------------
r49720 | skrul@chromium.org | 2010-06-14 22:31:25 +0200 (Mon, 14 Jun 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/preference_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert "Revert 48932 - Merge certain preferences during model association."

This reverts commit 392d1efa36fba717950cbfec40055939493a27b2.

Review URL: http://codereview.chromium.org/2676007
------------------------------------------------------------------------
r49715 | avi@chromium.org | 2010-06-14 22:05:21 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/configuration_policy_provider_mac.cc
   A /trunk/src/chrome/browser/configuration_policy_provider_mac.h
   A /trunk/src/chrome/browser/configuration_policy_provider_mac_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   A /trunk/src/chrome/browser/preferences_mac.cc
   A /trunk/src/chrome/browser/preferences_mac.h
   A /trunk/src/chrome/browser/preferences_mock_mac.cc
   A /trunk/src/chrome/browser/preferences_mock_mac.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Policy provider for the Mac.

BUG=http://crbug.com/7147
TEST=unit tested; not integrated yet

Review URL: http://codereview.chromium.org/2605002
------------------------------------------------------------------------
r49712 | akalin@chromium.org | 2010-06-14 21:59:15 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   A /trunk/src/chrome/browser/sync/glue/extension_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/extension_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/extension_data.cc
   A /trunk/src/chrome/browser/sync/glue/extension_data.h
   A /trunk/src/chrome/browser/sync/glue/extension_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/extension_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/extension_data_type_controller_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/extension_data_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/extension_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/extension_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/extension_util.cc
   A /trunk/src/chrome/browser/sync/glue/extension_util.h
   A /trunk/src/chrome/browser/sync/glue/extension_util_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implemented initial version of extension syncing.

BUG=32413
TEST=unit tests, trybots, manual

Review URL: http://codereview.chromium.org/2752007
------------------------------------------------------------------------
r49710 | oshima@chromium.org | 2010-06-14 21:49:35 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc

Keep the size regardless of the image size.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2722011
------------------------------------------------------------------------
r49704 | brettw@chromium.org | 2010-06-14 20:53:12 +0200 (Mon, 14 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/base
   M /trunk/src/base/allocator
   M /trunk/src/base/third_party/dynamic_annotations
   M /trunk/src/build
   M /trunk/src/build/linux
   M /trunk/src/build/temp_gyp
   M /trunk/src/build/util
   M /trunk/src/chrome
   M /trunk/src/chrome/browser/sync/protocol
   M /trunk/src/chrome/browser/sync/tools
   M /trunk/src/chrome/installer
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.cc
   M /trunk/src/chrome/renderer/pepper_plugin_delegate_impl.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/interactive_ui
   M /trunk/src/chrome/test/ui/ppapi_uitest.cc
   M /trunk/src/ipc
   M /trunk/src/media
   M /trunk/src/net
   M /trunk/src/net/third_party/nss
   M /trunk/src/webkit/support
   M /trunk/src/webkit/tools/test_shell

Add some Linux make and scons files to the svn:ignore properties.

TEST=none
BUG=none
R=thomasvl
------------------------------------------------------------------------
r49702 | estade@chromium.org | 2010-06-14 20:45:22 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Further refine the pinned tab navigation algorithm.

BUG=29281
TEST=included

Review URL: http://codereview.chromium.org/2747011
------------------------------------------------------------------------
r49700 | estade@chromium.org | 2010-06-14 20:21:00 +0200 (Mon, 14 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc

A little more automation provider cleanup.

Intention is to make it easier to see what needs porting.

BUG=44695
TEST=trybots

Review URL: http://codereview.chromium.org/2757009
------------------------------------------------------------------------
r49698 | skerner@chromium.org | 2010-06-14 20:13:06 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Remove app icon from non-app tabs.

BUG=44914
TEST=manual

Review URL: http://codereview.chromium.org/2696004
------------------------------------------------------------------------
r49695 | johnnyg@chromium.org | 2010-06-14 19:51:56 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/balloon_wrench_hover.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h

Update notifications UI on Linux to match the new mocks (wrench icon style).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2736004
------------------------------------------------------------------------
r49694 | mdm@chromium.org | 2010-06-14 19:02:24 +0200 (Mon, 14 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h

Fix two rare memory leaks in the password storage system.
They occur when canceling outstanding requests and when removing logins from a range of timestamps.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819001
------------------------------------------------------------------------
r49692 | nshkrob@chromium.org | 2010-06-14 18:55:40 +0200 (Mon, 14 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Move all database accesses to the DB thread.
The database now returns all urls and thumbnails in a single request.

BUG=None
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2764007
------------------------------------------------------------------------
r49689 | cmasone@google.com | 2010-06-14 18:21:30 +0200 (Mon, 14 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/logging_chrome.h

Allow chrome logging to pivot inside the users encrypted home dir

Allow chrome logging to pivot inside the users encrypted home dir on
chrome os, post-login.  We also set the inital logs up to be
timestamped, so that we don't lose them when crashes happen.

BUG=None
TEST=Enable chrome logging on chrome os, log in, and check for chrome logs in /home/chronos/user

Review URL: http://codereview.chromium.org/2723007
------------------------------------------------------------------------
r49688 | rsesek@chromium.org | 2010-06-14 17:56:05 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache_unittest.mm

Improve table_row_nsimage_cache_unittest.mm to get 100% code coverage.

BUG=32129
TEST=Covered by unit tests.

Review URL: http://codereview.chromium.org/2781004
------------------------------------------------------------------------
r49684 | danno@chromium.org | 2010-06-14 15:58:47 +0200 (Mon, 14 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   A /trunk/src/chrome/browser/dummy_configuration_policy_provider.h
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/reliability/page_load_test.cc

Add code to instantiate the ConfigurationPolicyPrefStore for the Windows platform.

BUG=46134
TEST=none

Review URL: http://codereview.chromium.org/2321003
Patch from Markus Heintz <markusheintz@google.com>.
------------------------------------------------------------------------
r49683 | jorlow@chromium.org | 2010-06-14 15:50:15 +0200 (Mon, 14 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h

Flesh out the rest of IDBIndex and IDBObjectStore's chromium halves.

Also refactor a bunch of the dispatcher/dispatcherHost and IndexedDBCallbacks
code to clean things up.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2749013
------------------------------------------------------------------------
r49681 | hans@chromium.org | 2010-06-14 15:09:26 +0200 (Mon, 14 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/test/data/cancelled_redirect_test.html

Fix and re-enable RedirectTest.ClientCancelled.

The hack to create and dispatch an event after a timeout to fool the browser
into thinking it is user initiated stopped working after WebKit r49827.

Changing the test to navigate to a javascript: url instead, which qualifies
as a user initiated location change.

BUG=45053
TEST=ui_tests --gtest_filter=RedirectTest.ClientCancelled

Review URL: http://codereview.chromium.org/2225007
------------------------------------------------------------------------
r49675 | danno@chromium.org | 2010-06-14 12:04:26 +0200 (Mon, 14 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Implements policies to enable or disable the five Privacy checkboxes found in the Options dialog, in the Under the Hood section.

xib changes: added an enabled binding to the policy-controlled checkboxes in the "Under the Hood" preference pane so that they can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.

BUG=44394
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.*  Manual tests: Set the policies externally.  Check that the checkbox in Options/Under the Hood/Privacy/search suggest... are disabled.  Also check that the check box is set/unset as done by the policy.

Review URL: http://codereview.chromium.org/2746006
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
------------------------------------------------------------------------
r49669 | yusukes@google.com | 2010-06-14 09:32:14 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/status/language_menu_button_unittest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.h
   M /trunk/src/chrome/chrome_tests.gypi

Use special indicator text for xkb:us:dvorak:eng, mozc, mozc-jp, m17n:t:latn-pre, and m17n:t:latn-post.

BUG=chromium-os:4001
TEST=manually

Review URL: http://codereview.chromium.org/2771013
------------------------------------------------------------------------
r49666 | yusukes@chromium.org | 2010-06-14 04:46:54 +0200 (Mon, 14 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Show "Hit Shift-Alt to switch keyboard layout" hint string in the message bubble

if more than one keyboard are active.

BUG=chromium-os:3936
TEST=manual

Review URL: http://codereview.chromium.org/2787008
------------------------------------------------------------------------
r49663 | yusukes@chromium.org | 2010-06-14 04:29:38 +0200 (Mon, 14 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc

Resume "previous input method" on unlock

BUG=chromium-os:4021
TEST=manual + browser_tests

Review URL: http://codereview.chromium.org/2717009
------------------------------------------------------------------------
r49661 | satorux@chromium.org | 2010-06-14 04:00:18 +0200 (Mon, 14 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Add text input related UserMetricsActions

- LanguageConfigView_Open (the "Languages and input dialog" is opened)
- LanguageMenuButton_Open (input language menu is opened)
- LanguageMenuButton_InputMethodChanged (input method is changed)

These are very basic actions. We'll add more.

TEST=manually
BUG=chromium-os:2637

Review URL: http://codereview.chromium.org/2730013
------------------------------------------------------------------------
r49660 | satorux@chromium.org | 2010-06-14 03:44:10 +0200 (Mon, 14 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Fix a bug that caused the candidate window to be rendered terribly.

The problem was caused by the candidate window became being too wide.
Limit the width fixes the problem.

TEST=manually
BUG=chromium-os:4018

Review URL: http://codereview.chromium.org/2716008
------------------------------------------------------------------------
r49644 | dumi@chromium.org | 2010-06-13 11:08:41 +0200 (Sun, 13 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h
   M /trunk/src/webkit/database/database_tracker_unittest.cc
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/database/vfs_backend.h
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc

Support WebSQLDatabases in incognito mode.

BUG=43232
TEST=none

Review URL: http://codereview.chromium.org/2746003
------------------------------------------------------------------------
r49634 | phajdan.jr@chromium.org | 2010-06-12 17:27:47 +0200 (Sat, 12 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   M /trunk/src/net/net.gyp

Add dependency on libevent where required.

Otherwise some portions of the code try to use
bundled libevent headers instead of the system-provided
ones if -Duse_system_libevent=1 is used.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2729012
------------------------------------------------------------------------
r49633 | tfarina@chromium.org | 2010-06-12 17:16:36 +0200 (Sat, 12 Jun 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.cc
   A /trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.h
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Split RecentlyUsedFolderComboModel into its own module, so we can share it
Views and Gtk.

BUG=None
TEST=manually

Review URL: http://codereview.chromium.org/2673005
------------------------------------------------------------------------
r49626 | tfarina@chromium.org | 2010-06-12 06:22:04 +0200 (Sat, 12 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

gtk: Make use of gtk signal macro in TaskManagerGtk dialog.

BUG=None
TEST=manually

Review URL: http://codereview.chromium.org/2657006
------------------------------------------------------------------------
r49622 | atwilson@chromium.org | 2010-06-12 04:47:26 +0200 (Sat, 12 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Added plumbing to transport the frame name between RenderViewHost and the Webkit layer.

Extended ViewMsg_New and ViewHostMsg_CreateWindow to have a new frame_name
parameter. This allows the RVH to know the initial name of the frame associated
with its RenderView, and also to set the name of the frame when creating a new
RenderView.

Review URL: http://codereview.chromium.org/2775003
------------------------------------------------------------------------
r49618 | jhawkins@chromium.org | 2010-06-12 02:00:00 +0200 (Sat, 12 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc

TTF: Update comments for a few disabled tests.

TBR=thestig
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2786015
------------------------------------------------------------------------
r49612 | jhawkins@chromium.org | 2010-06-12 01:25:16 +0200 (Sat, 12 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Build fix: Remove a duplicate MAYBE_ define.

TBR=thestig
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2784006
------------------------------------------------------------------------
r49611 | jhawkins@chromium.org | 2010-06-12 01:14:07 +0200 (Sat, 12 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

TTF: Re-enable DevToolsSanityTest.TestResouceContentLength and mark it as
failing on Linux.

TBR=thestig
BUG=44202
TEST=DevToolsSanityTest.TestResouceContentLength

Review URL: http://codereview.chromium.org/2753012
------------------------------------------------------------------------
r49608 | albertb@chromium.org | 2010-06-12 01:06:49 +0200 (Sat, 12 Jun 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/protocol/encryption.proto
   A /trunk/src/chrome/browser/sync/protocol/nigori_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   A /trunk/src/chrome/browser/sync/util/cryptographer.cc
   A /trunk/src/chrome/browser/sync/util/cryptographer.h
   A /trunk/src/chrome/browser/sync/util/cryptographer_unittest.cc
   M /trunk/src/chrome/browser/sync/util/nigori.cc
   M /trunk/src/chrome/browser/sync/util/nigori_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

This is the first patch to support encryption. The Cryptographer class
manages a map of Nigori instances and allows data encrypted using different
pass-phrase to be decrypted easily.

BUG=none
TEST=CryptographerTest, NigoriTest

Review URL: http://codereview.chromium.org/2727006
------------------------------------------------------------------------
r49606 | rvargas@google.com | 2010-06-12 00:53:43 +0200 (Sat, 12 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/profile.cc

Add histograms to track the size of the profile data.

BUG=16705
TEST=FileUtilTest.FileAndDirectorySize


Review URL: http://codereview.chromium.org/2778006
------------------------------------------------------------------------
r49605 | estade@chromium.org | 2010-06-12 00:51:37 +0200 (Sat, 12 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Fix compile failure on linux.

TBR=erg
BUG=none
TEST=waterfall

Review URL: http://codereview.chromium.org/2711013
------------------------------------------------------------------------
r49603 | creis@chromium.org | 2010-06-12 00:37:28 +0200 (Sat, 12 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc

Avoids sending about: URLs to DOM UI renderers in process-per-tab.

Since about:version, etc get translated to chrome://about/version,
we were sending them to a DOM UI renderer in process-per-tab mode.
This hit a CHECK where we ensured non-DOM-UI URLs weren't sent to
such renderers.

BUG=46290
TEST=RenderViewHostManagerTest.NonDOMUIChromeURLs

Review URL: http://codereview.chromium.org/2730014
------------------------------------------------------------------------
r49602 | estade@chromium.org | 2010-06-12 00:35:02 +0200 (Sat, 12 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Use new images for gtk location bar.

BUG=45763
TEST=visual

Review URL: http://codereview.chromium.org/2745017
------------------------------------------------------------------------
r49599 | jam@chromium.org | 2010-06-12 00:25:54 +0200 (Sat, 12 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/common/sandbox_methods_linux.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/third_party/npapi/bindings/npapi_extensions.h
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate.h

Add a font API to Pepper and implement on Linux based on agl's code from http://codereview.chromium.org/2673003.

Review URL: http://codereview.chromium.org/2794004
------------------------------------------------------------------------
r49596 | scottbyer@chromium.org | 2010-06-11 23:18:49 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc

Revert 49592 - Fix crashy test.
http://code.google.com/p/chromium/issues/detail?id=44547

BUG=44547
TEST=PrintDialogCloudTest.HandlersRegistered

TBR=scottbyer@chromium.org
Review URL: http://codereview.chromium.org/2775007
------------------------------------------------------------------------
r49595 | scottbyer@chromium.org | 2010-06-11 23:17:16 +0200 (Fri, 11 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc

Revert 49593 - Tweaks to the test.

TBR=scottbyer@chromium.org
Review URL: http://codereview.chromium.org/2753011
------------------------------------------------------------------------
r49594 | brettw@chromium.org | 2010-06-11 23:12:36 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_publisher.cc
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Convert page contents grabbing from wide to UTF16. The current code is a bit
silly because it would capture it in UTF16, then convert to wide, send it to
the browser, then convert it to UTF-8 for FTS.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2714012
------------------------------------------------------------------------
r49593 | scottbyer@chromium.org | 2010-06-11 23:11:22 +0200 (Fri, 11 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc

Tweaks to the test.
------------------------------------------------------------------------
r49592 | scottbyer@chromium.org | 2010-06-11 23:10:58 +0200 (Fri, 11 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc

Fix crashy test.
http://code.google.com/p/chromium/issues/detail?id=44547

BUG=44547
TEST=PrintDialogCloudTest.HandlersRegistered
------------------------------------------------------------------------
r49588 | derat@chromium.org | 2010-06-11 22:30:01 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h

chromeos: Remove old, unused window manager metrics code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2737008
------------------------------------------------------------------------
r49585 | jhawkins@chromium.org | 2010-06-11 22:27:04 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/browser_about_handler_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

TTF: Add tests for WillHandleBrowserAboutURL.

BUG=none
TEST=BrowserAboutHandlerTest.WillHandleBrowserAboutURL

Review URL: http://codereview.chromium.org/2712007
------------------------------------------------------------------------
r49584 | akalin@chromium.org | 2010-06-11 22:22:55 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

NULL out talk_mediator_ in Shutdown() to avoid crash.

BUG=46283
TEST=manual

Review URL: http://codereview.chromium.org/2755005
------------------------------------------------------------------------
r49580 | csilv@chromium.org | 2010-06-11 22:04:23 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Re-enable two unit unit tests that were disabled for Mac in Oct 2009.
These seem to be working fine on trybots now, so checking to see how these
behave now.  Will revert if necessary.

BUG=26035
TEST=none
Review URL: http://codereview.chromium.org/2738009
------------------------------------------------------------------------
r49578 | csilv@chromium.org | 2010-06-11 22:00:03 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

TTF: Fix SafeBrowsingDatabase unit tests for MacOS X by disabling logging of IO
stats since those are unsupported on MacOS X (and really just informative, not
critical to the function of the test.)

BUG=46040
TEST=SafeBrowsingDatabase.*
Review URL: http://codereview.chromium.org/2723003
------------------------------------------------------------------------
r49570 | thakis@chromium.org | 2010-06-11 21:19:37 +0200 (Fri, 11 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/base/crypto/signature_creator_mac.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/authorization_util.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.h
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drag_source.h
   M /trunk/src/chrome/browser/cocoa/web_drop_target.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/skia/ext/skia_utils_mac.h

Mac/clang: Uncontentious fixes.

* Remove unused variables
* Make types in h and cc files agree
* Use subclasses if we call subclass methods
* Fix one real bug (`if (a); a->foo()`)
* Fix forward declarations to be correct
* Don't mark some definitions with "extern"

Review URL: http://codereview.chromium.org/2730015
------------------------------------------------------------------------
r49569 | chocobo@chromium.org | 2010-06-11 21:13:48 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

Fix Google-A reconnect issue.
- Timeout increased to 30s.
- Correctly handle when network was previously in a failed state
- Also handle if identity/cert was cleared out and waits for the fields to be set by the enterprise daemon.
BUG=chromium-os:3262
TEST=manual testing
Review URL: http://codereview.chromium.org/2746009
------------------------------------------------------------------------
r49566 | xiyuan@chromium.org | 2010-06-11 21:01:59 +0200 (Fri, 11 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.cc
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Fix issue 3967 and a couple related issues.

- Improve gtk_util::ShowDialog to respect dialog size and resizable trait;
- Make TaskManagerGtk remember correct geometry info;
- Use gtk_util::PresentWindow instead of gek_window_present;

BUG=chromium-os:3967
TEST=Verify fix for chromium-os:3967

Review URL: http://codereview.chromium.org/2776005
------------------------------------------------------------------------
r49561 | jhawkins@chromium.org | 2010-06-11 20:40:35 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

AutoFill: Remove the default profile/CC prefs.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2762013
------------------------------------------------------------------------
r49556 | rafaelw@chromium.org | 2010-06-11 20:11:08 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Interpret typed url into an apps extent from the NTP omnibox as launch event

Note that this doesn't cover the case of a typed url that redirects into an app's extent.

BUG=44911
TEST=NONE

Review URL: http://codereview.chromium.org/2777002
------------------------------------------------------------------------
r49553 | asargent@chromium.org | 2010-06-11 19:54:18 +0200 (Fri, 11 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Tweak install and dangerous download dialogs for apps.

BUG=45155
TEST=Run chrome with the --enable-apps flag.Install an app - the confirmation
dialog should say "..this App..." instead of "...this Extension...". Install an
extension - it should stil say "Extension".


Review URL: http://codereview.chromium.org/2730002
------------------------------------------------------------------------
r49544 | shess@chromium.org | 2010-06-11 19:25:14 +0200 (Fri, 11 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

[Mac] Enable zombies for all on devchannel.

Attempt to flush out more use-after-free cases in the wild.  Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin.  Additionally, the treadmill should slightly increase the number of cases caught.

[Was reverted earlier due to Mac Perf(2).  A fix to the zombie code should improve things.]

BUG=35590,24987,45676
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48838

Review URL: http://codereview.chromium.org/2478004
------------------------------------------------------------------------
r49543 | albertb@chromium.org | 2010-06-11 19:17:36 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc

Clear the default and per-host content settings when the backing preference
is reset. This is to handle the case where two browsers are synced and one
of them does a "Reset to Default" of all the options.

BUG=46107
TEST=HostContentSettingsMapTest

Review URL: http://codereview.chromium.org/2723006
------------------------------------------------------------------------
r49541 | xiyuan@chromium.org | 2010-06-11 19:13:14 +0200 (Fri, 11 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/platform_util_chromeos.cc
   M /trunk/src/chrome/browser/platform_util_common_linux.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Add an error message when user clicks a file of unknown type.

- Replace name link with name+error message in content browser;
- Show an error message ChromeOS's openItem;
- Update SimpleErrorBox so that it runs in a Chrome window;
- Put back "Show in folder" in download page and make it work with content
  browser;

BUG=chromium-os:1637
TEST=Verify fix for chromium-os:1637 and verify error message pops up for unknown type file in downloads ui.

Review URL: http://codereview.chromium.org/2748007
------------------------------------------------------------------------
r49540 | wtc@chromium.org | 2010-06-11 19:02:20 +0200 (Fri, 11 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/client_socket_factory.cc
   A /trunk/src/net/socket/ssl_client_socket_mac_factory.cc (from /trunk/src/net/socket/ssl_client_socket_nss_factory.cc:49525)
   A /trunk/src/net/socket/ssl_client_socket_mac_factory.h (from /trunk/src/net/socket/ssl_client_socket_nss_factory.h:49525)
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Second attempt to land r49489. 

Use NSS for SSL by default on Mac OS X. 

To use Mac OS X Secure Transport in Chromium, specify the --use-system-ssl 
command-line switch, which also replaced the --use-schannel command-line 
switch for Windows. All other programs are hardcoded to use NSS for SSL. 

If SSL client authentication is requested, fall back on Mac OS X Secure 
Transport for now. 

Original review URL: http://codereview.chromium.org/2747002/show 

R=mark,mbelshe 
BUG=30689
TEST=none
Review URL: http://codereview.chromium.org/2769012
------------------------------------------------------------------------
r49539 | boliu@google.com | 2010-06-11 18:56:09 +0200 (Fri, 11 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Add enable-video-fullscreen switch.

Corresponding Webkit patch to make this work is here:
https://bugs.webkit.org/show_bug.cgi?id=40317

BUG=16735
TEST=webkitSupportsFullscreen() js call should return true with switch.
(Requires webkit patch)

Review URL: http://codereview.chromium.org/2775001
------------------------------------------------------------------------
r49536 | rsesek@chromium.org | 2010-06-11 18:29:52 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

[Mac] Don't disable all menu items if there isn't a browser window open.

BUG=46355
TEST=Close all browser windows. New Tab, New Window, History and Bookmark menus, etc are enabled.

Review URL: http://codereview.chromium.org/2767012
------------------------------------------------------------------------
r49535 | cmasone@google.com | 2010-06-11 17:57:08 +0200 (Fri, 11 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc

Fix build failure from previous change.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49503

Review URL: http://codereview.chromium.org/2796004
------------------------------------------------------------------------
r49534 | joth@chromium.org | 2010-06-11 17:47:29 +0200 (Fri, 11 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.h
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_unittest_linux.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc

convert providers to be long-lived - give them a stop method
port arbitrator over to use Start & Stop instead of creating and destroying providers

Review URL: http://codereview.chromium.org/2720004
------------------------------------------------------------------------
r49532 | darin@chromium.org | 2010-06-11 17:34:25 +0200 (Fri, 11 Jun 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h

Merge DidPaintBackingStoreRects and DidScrollBackingStoreRect
into a single DidUpdateBackingStore method so that I can move
the call to ScrollWindowEx closer to the RedrawWindow call.

This is done to minimize the opportunity for a v-sync of the
display happening between the ScrollWindowEx call and the
RedrawWindow call, which gives the appearance of tearing or
flicker in some cases.

RenderWidgetHostViewMac now just treats the scroll rect as an
additional paint rect.

Since RenderWidgetHostViewGtk was just repainting the scroll
rect, I took this opportunity to avoid double painting if a
paint rect happened to intersect the scroll rect.

R=brettw,rohitrao
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2733010
------------------------------------------------------------------------
r49529 | glider@chromium.org | 2010-06-11 16:56:17 +0200 (Fri, 11 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Fix the MAYBE_ prefixes for UnloadTest.* on Windows

Review URL: http://codereview.chromium.org/2745015
------------------------------------------------------------------------
r49521 | joth@chromium.org | 2010-06-11 13:33:07 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc

Workaround for bug 41001 - treat empty response as no location fix available

BUG=41001
TEST=Run on desktop computer on corp network (no reverse IP available). Should report 'location unavailable', not malformed response.

Review URL: http://codereview.chromium.org/2714014
------------------------------------------------------------------------
r49520 | yurys@chromium.org | 2010-06-11 13:30:41 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: enable and mark step in/out/over tests as flaky. I cannot see them time out neither locally nor on try bots: http://build.chromium.org/buildbot/try-server/builders/linux/builds/33612
so I'd like to enable them and see whether they fail on the main bots.

BUG=45080,46299

Review URL: http://codereview.chromium.org/2724015
------------------------------------------------------------------------
r49512 | glider@chromium.org | 2010-06-11 11:27:37 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Remove the MAYBE_ prefix from MAYBE_BrowserCloseBeforeUnloadOK and
MAYBE_BrowserCloseBeforeUnloadCancel on Linux.

TBR=jhawkins

Review URL: http://codereview.chromium.org/2781013
------------------------------------------------------------------------
r49511 | whesse@chromium.org | 2010-06-11 11:08:07 +0200 (Fri, 11 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Update V8 to version 2.2.16.
Update V8, and disable a test until its expectations are changed in Webkit/chromium port.  BUG=46235  TEST=none
Add a bleeding-edge revision to DEPS to upload to the try server, to find the reerror in this CL.
Review URL: http://codereview.chromium.org/2729005
------------------------------------------------------------------------
r49507 | tony@chromium.org | 2010-06-11 09:18:23 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/net_internals_resources.grd
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_exe.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/tools/grit/grit/format/resource_map.py
   M /trunk/src/tools/grit/grit/node/include.py
   M /trunk/src/tools/grit/grit/node/misc.py
   M /trunk/src/tools/grit/grit/tool/build.py

Move the resources used by net-internals into a pak file.

We don't use this yet, but the plan is to move everything in the resources directory into here.

BUG=42770

Review URL: http://codereview.chromium.org/2667001
------------------------------------------------------------------------
r49498 | oshima@chromium.org | 2010-06-11 05:24:12 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h
   M /trunk/src/chrome/common/notification_type.h

Don't ask password for bwsi mode. This will be the same for auto login mode.
Send Notification when screen lock state is changed.

BUG=chromium-os:3950, chromium-os:3675
TEST=manual: login to bwsi mode and hit ctrl-alt-l. unlock by moving mouse or type any key.

Review URL: http://codereview.chromium.org/2735008
------------------------------------------------------------------------
r49496 | hayato@chromium.org | 2010-06-11 05:12:08 +0200 (Fri, 11 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/client_socket_factory.cc
   D /trunk/src/net/socket/ssl_client_socket_mac_factory.cc
   D /trunk/src/net/socket/ssl_client_socket_mac_factory.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Revert 49489 - Use NSS for SSL by default on Mac OS X.

To use Mac OS X Secure Transport in Chromium, specify the --use-system-ssl
command-line switch, which also replaced the --use-schannel command-line
switch for Windows.  All other programs are hardcoded to use NSS for SSL.

If SSL client authentication is requested, fall back on Mac OS X Secure
Transport for now.

R=mark,mbelshe
BUG=30689
TEST=none
Review URL: http://codereview.chromium.org/2747002

TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/2775005
------------------------------------------------------------------------
r49495 | tfarina@chromium.org | 2010-06-11 04:40:49 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

gtk: Remove obsolete TODO comment.

BUG=31365
TEST=None

Review URL: http://codereview.chromium.org/2635007
------------------------------------------------------------------------
r49494 | satorux@chromium.org | 2010-06-11 04:31:05 +0200 (Fri, 11 Jun 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

Hide the input language menu if there is only one input method and it's a XKB keyboard layout.

For instance, if English USA keyboard layout is the only input method enabled,
we don't show the input language menu on the right upper corner.

On the other hand, if Japanese input method is the only input method enabled,
we still show the input language menu so users can change the intra input method
modes, like Hiragana and Katakana modes.

Note that this is a retry of r49375 that was reverted in r49393

http://src.chromium.org/viewvc/chrome?view=rev&revision=49375
http://src.chromium.org/viewvc/chrome?view=rev&revision=49393

The new fix is in chrome/browser/chromeos/login/login_browsertest.cc

-        .WillRepeatedly(Return(CreateFallbackInputMethodDescriptors()));
+        .WillRepeatedly(
+            InvokeWithoutArgs(CreateFallbackInputMethodDescriptors));

BUG=chromium-os:2275
TEST=manually on the netbook; try bots

Review URL: http://codereview.chromium.org/2787007
------------------------------------------------------------------------
r49492 | pkasting@chromium.org | 2010-06-11 04:13:45 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/SideToolbar.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   D /trunk/src/chrome/app/theme/go.png
   D /trunk/src/chrome/app/theme/go_Template.pdf
   D /trunk/src/chrome/app/theme/go_d.png
   D /trunk/src/chrome/app/theme/go_h.png
   D /trunk/src/chrome/app/theme/go_mask.png
   D /trunk/src/chrome/app/theme/go_noborder_center.png
   D /trunk/src/chrome/app/theme/go_p.png
   M /trunk/src/chrome/app/theme/reload.png
   M /trunk/src/chrome/app/theme/reload_d.png
   M /trunk/src/chrome/app/theme/reload_h.png
   D /trunk/src/chrome/app/theme/reload_mask.png
   M /trunk/src/chrome/app/theme/reload_p.png
   D /trunk/src/chrome/app/theme/stop_noborder_center.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/side_tabs_toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/side_tabs_toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   D /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   D /trunk/src/chrome/browser/gtk/go_button_gtk.h
   D /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/reload_button_gtk.cc (from /trunk/src/chrome/browser/gtk/go_button_gtk.cc:48894)
   A /trunk/src/chrome/browser/gtk/reload_button_gtk.h (from /trunk/src/chrome/browser/gtk/go_button_gtk.h:48894)
   A /trunk/src/chrome/browser/gtk/reload_button_gtk_unittest.cc (from /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc:48894)
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/theme_resources_util_unittest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   D /trunk/src/chrome/browser/views/go_button.cc
   D /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   A /trunk/src/chrome/browser/views/reload_button.cc (from /trunk/src/chrome/browser/views/go_button.cc:48894)
   A /trunk/src/chrome/browser/views/reload_button.h (from /trunk/src/chrome/browser/views/go_button.h:48894)
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_location_bar.h

Detach reload from omnibox, combine with stop, and eliminate go.

This does the basic surgery on all three OSes without trying to fix up the visual appearance.  As a result, things look pretty ugly.  My intent is to at least put endcaps on the omnibox in a subsequent patch.

BUG=45745,45762,45763
TEST=Reload and stop should be combined; go should be gone.
Review URL: http://codereview.chromium.org/2677003
------------------------------------------------------------------------
r49490 | zork@chromium.org | 2010-06-11 04:08:19 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   A /trunk/src/chrome/browser/sync/util/channel.h
   A /trunk/src/chrome/browser/sync/util/channel_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Replace changes_channel with an observer list.

BUG=none
TEST=Run unit tests

Review URL: http://codereview.chromium.org/2075012
------------------------------------------------------------------------
r49489 | wtc@chromium.org | 2010-06-11 04:02:22 +0200 (Fri, 11 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/client_socket_factory.cc
   A /trunk/src/net/socket/ssl_client_socket_mac_factory.cc (from /trunk/src/net/socket/ssl_client_socket_nss_factory.cc:49077)
   A /trunk/src/net/socket/ssl_client_socket_mac_factory.h (from /trunk/src/net/socket/ssl_client_socket_nss_factory.h:49077)
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Use NSS for SSL by default on Mac OS X.

To use Mac OS X Secure Transport in Chromium, specify the --use-system-ssl
command-line switch, which also replaced the --use-schannel command-line
switch for Windows.  All other programs are hardcoded to use NSS for SSL.

If SSL client authentication is requested, fall back on Mac OS X Secure
Transport for now.

R=mark,mbelshe
BUG=30689
TEST=none
Review URL: http://codereview.chromium.org/2747002
------------------------------------------------------------------------
r49487 | arv@chromium.org | 2010-06-11 03:55:44 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Sync shown sections across instances

This adds a pref observer for prefs::kNTPShownSections and calls a js function when these changes. This is so that instances of the NTP do not get out of sync with each other.

BUG=None
TEST=Open two or more NTPs. Hide and show different sections and the sections should be hidden and removed on all instances.

Review URL: http://codereview.chromium.org/2792004
------------------------------------------------------------------------
r49486 | arv@chromium.org | 2010-06-11 03:54:52 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

NTP/Apps: Change the order of the default apps.

Use a list of pairs instead of using a map so that the insertioj order is kept.

BUG=3995
TEST=Start chrome with --enable-apps. The Gmail app should come up first in the list.

Review URL: http://codereview.chromium.org/2754008
------------------------------------------------------------------------
r49477 | mattm@chromium.org | 2010-06-11 02:13:56 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.h
   M /trunk/src/chrome/installer/util/shell_util.cc

Win: Use different AppUserModelID for SxS installs.

BUG=44572
TEST=see bug

Review URL: http://codereview.chromium.org/2616002
------------------------------------------------------------------------
r49476 | shess@chromium.org | 2010-06-11 02:08:37 +0200 (Fri, 11 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/objc_zombie.mm

[Mac] Make CrZombie a superclass-less class.

CrZombie manually overrode all NSObject methods which weren't
overriden to throw.  Unfortunately, there were a lot of such methods
from system categories, which made startup slow.  Converting CrZombie
to an object with no superclass means there is no need to override
those methods.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2729015
------------------------------------------------------------------------
r49475 | estade@chromium.org | 2010-06-11 02:08:35 +0200 (Fri, 11 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util_unittest.cc

Download filename encoding fix [try2]:

Fall back on other charsets when using the URL to suggest a filename. The URL should be escaped UTF-8, but may use another encoding instead.

Check for empty string in DecodeWord (avoids crash).

BUG=44301
TEST=see bug. Also, net_unittests.

Review URL: http://codereview.chromium.org/2733005
------------------------------------------------------------------------
r49473 | jshin@chromium.org | 2010-06-11 02:02:14 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc

Remove MAYBE_ prefix from ExtensionStartupTesst.Test  (fixing my mistake)

TEST=NONE
BUG=NONE


Review URL: http://codereview.chromium.org/2725011
------------------------------------------------------------------------
r49472 | jshin@chromium.org | 2010-06-11 01:55:02 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc

Mark ExtensionsLoadTest.Test as flaky on Win/Mac

BUG=46301
TEST=greener tree
TBR=jcivelli
Review URL: http://codereview.chromium.org/2727007
------------------------------------------------------------------------
r49471 | dimich@chromium.org | 2010-06-11 01:28:00 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable DevToolsSanityTest.TestStepIn/Over/Out on Linux.
All 3 started to hang since WebKit roll 60950:60968, presumably due to r60965.
BUG=46299
TEST=none
TBR=yurys

Review URL: http://codereview.chromium.org/2767008
------------------------------------------------------------------------
r49470 | jhawkins@chromium.org | 2010-06-11 01:14:22 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc

Fix the chromeos build.

TBR=jcivelli
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2754010
------------------------------------------------------------------------
r49469 | erg@chromium.org | 2010-06-11 01:02:39 +0200 (Fri, 11 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Views: Respond to the --new-wrench-menu flag on windows.

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2748006
------------------------------------------------------------------------
r49468 | mbelshe@chromium.org | 2010-06-11 00:59:07 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Track whether a page was loaded via a proxy so that we can
evaluate performance.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2764004
------------------------------------------------------------------------
r49467 | thakis@chromium.org | 2010-06-11 00:57:22 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc

Gtk: Side tabs for content settings window.

UI leads-approved.

BUG=45546
TEST=Open content settings window. Tabs are now on the left.

Review URL: http://codereview.chromium.org/2717007
------------------------------------------------------------------------
r49466 | evan@chromium.org | 2010-06-11 00:56:23 +0200 (Fri, 11 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/net/spdy/spdy_frame_builder.cc

Return NULL instead of false when appropriate.

(Found by clang.)

Review URL: http://codereview.chromium.org/2725010
------------------------------------------------------------------------
r49464 | dhg@chromium.org | 2010-06-11 00:48:30 +0200 (Fri, 11 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing filebrowse for extension layering problem.

BUG=chromium-os:4014
TEST=none
Review URL: http://codereview.chromium.org/2746008
------------------------------------------------------------------------
r49463 | jhawkins@chromium.org | 2010-06-11 00:41:20 +0200 (Fri, 11 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc

AutoFill: Implement the 'AutoFill Options...' entry in the AutoFill suggestions
popup.

BUG=45144
TEST=none

Review URL: http://codereview.chromium.org/2773005
------------------------------------------------------------------------
r49462 | albertb@chromium.org | 2010-06-11 00:40:52 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/password_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h

Let DataTypeControllers determine whether their data types are ready to be
synced. In the case of passwords, wait for the cryptographer to be ready
before starting to sync.

BUG=none
TEST=ProfileSyncServicePasswordTest

Review URL: http://codereview.chromium.org/2794003
------------------------------------------------------------------------
r49461 | dhg@chromium.org | 2010-06-11 00:36:38 +0200 (Fri, 11 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc

Adding flushing of files on chromeos, so that when something is downloaded, its written out ot disk shortly after finish downloading.

BUG=chromium-os:2661
TEST=none
Review URL: http://codereview.chromium.org/2770002
------------------------------------------------------------------------
r49458 | erg@chromium.org | 2010-06-11 00:23:02 +0200 (Fri, 11 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK: Always use default frame in popup windows.

Now that glen@ has spoken, make popup windows on linux match the XP behaviour
by never using themed resources for the window frame.

BUG=43938
TEST=none

Review URL: http://codereview.chromium.org/2771011
------------------------------------------------------------------------
r49457 | dhg@chromium.org | 2010-06-11 00:14:59 +0200 (Fri, 11 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Removing fwd button, make back button take you back up to the root.

BUG=chromium-os:2558
TEST=none
Review URL: http://codereview.chromium.org/2723002
------------------------------------------------------------------------
r49456 | sky@chromium.org | 2010-06-11 00:13:57 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Makes tab icon/throbber paint in the right position for rtl. I broke
this when I refactored the rtl handling to base_tab. Since base_tab
handles the switch tab doesn't need to handle it too.

BUG=45388
TEST=see bug

Review URL: http://codereview.chromium.org/2749009
------------------------------------------------------------------------
r49454 | jhawkins@chromium.org | 2010-06-11 00:00:17 +0200 (Fri, 11 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager.h
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

AutoFill: Fix a bug that caused AutoFill to not fill the field the user is
typing in. This change also conveniently removes filling the default profile,
since this feature has been removed from AutoFill.

BUG=46219
TEST=FormManagerTest.FillFormNonEmptyField

Review URL: http://codereview.chromium.org/2766005
------------------------------------------------------------------------
r49452 | georgey@chromium.org | 2010-06-10 23:53:21 +0200 (Thu, 10 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

Fix for bug #46042: Browser Crash @ views::TableView::~TableView() 
BUG=46042
TEST=Should not crash in release anymore.
Review URL: http://codereview.chromium.org/2791004
------------------------------------------------------------------------
r49451 | estade@chromium.org | 2010-06-10 23:53:08 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

[GTK] fix a corner case where unmaximize wouldn't work.

BUG=46232
TEST=using the custom frame in hardy/compiz: resize browser window to be the same size as a maximized window; maximize window; try to restore it by pressing restore on the custom frame; it should work.

Review URL: http://codereview.chromium.org/2769009
------------------------------------------------------------------------
r49450 | evan@chromium.org | 2010-06-10 23:52:57 +0200 (Thu, 10 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc

Reduce console spam from unneeded LOG().

Review URL: http://codereview.chromium.org/2779014
------------------------------------------------------------------------
r49448 | estade@chromium.org | 2010-06-10 23:51:52 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Clean up external-tab related code in automation provider and automation proxy.

BUG=44695
TEST=compile

Review URL: http://codereview.chromium.org/2743006
------------------------------------------------------------------------
r49446 | agl@chromium.org | 2010-06-10 23:39:04 +0200 (Thu, 10 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/ipc/file_descriptor_set_posix.cc
   M /trunk/src/ipc/file_descriptor_set_posix.h
   M /trunk/src/ipc/ipc_channel_posix.cc

POSIX: make sure that we never pass directory descriptors into the sandbox.

BUG=43304

http://codereview.chromium.org/2733011/show
------------------------------------------------------------------------
r49443 | rsesek@chromium.org | 2010-06-10 23:03:59 +0200 (Thu, 10 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h

No-code change to trigger the bots.
------------------------------------------------------------------------
r49442 | thakis@chromium.org | 2010-06-10 22:11:31 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm

Mac: Faster scrolling on 10.6.

BUG=45553
TEST=Scrolling up and down still works on 10.5 and 10.6. It uses less %cpu on 10.6.

Review URL: http://codereview.chromium.org/2771010
------------------------------------------------------------------------
r49440 | erg@chromium.org | 2010-06-10 21:59:06 +0200 (Thu, 10 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/app_menu_model.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   D /trunk/src/chrome/browser/user_data_manager.cc
   D /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   D /trunk/src/chrome/browser/views/new_profile_dialog.cc
   D /trunk/src/chrome/browser/views/new_profile_dialog.h
   D /trunk/src/chrome/browser/views/select_profile_dialog.cc
   D /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/test_browser_window.h

Rip out the multiprofile implementation.

Requested by Ben. Never worked on linux or OSX and apparently broken on Windows. Removal of the multiprofile code will make switching out the old AppMenuModel with the new WrenchMenuModel trivial.

BUG=27177
TEST=none

Review URL: http://codereview.chromium.org/2736001
------------------------------------------------------------------------
r49437 | ian@chromium.org | 2010-06-10 21:45:29 +0200 (Thu, 10 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/tools/chromeactions.txt
   M /trunk/src/chrome/tools/extract_actions.py

Merging issue 2067023 for bryner@google.com
BUG=none
TEST=safe_browsing_blocking_page_unittest.cc

Review URL: http://codereview.chromium.org/2737005
------------------------------------------------------------------------
r49436 | mbelshe@chromium.org | 2010-06-10 21:36:24 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc

Add histograms for web cache manager.

BUG=none
TEST=na

Review URL: http://codereview.chromium.org/2762005
------------------------------------------------------------------------
r49430 | dantasse@chromium.org | 2010-06-10 20:45:38 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h

Plumbing data type choices through to the PSS

BUG=45869
TEST=existing unit tests

Review URL: http://codereview.chromium.org/2721003
------------------------------------------------------------------------
r49429 | jshin@chromium.org | 2010-06-10 20:41:39 +0200 (Thu, 10 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc

Mark AccountScreenTest.TestSchemeInspector as flaky. 

BUG=46274
TEST=CrOS linux bot greener
TBR=jcivelli


Review URL: http://codereview.chromium.org/2771012
------------------------------------------------------------------------
r49421 | eroman@chromium.org | 2010-06-10 20:16:36 +0200 (Thu, 10 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Silently discard invalid OnFollowDeferredRedirect requests sent by the renderer to the browser.

It is a bug if the renderer sends these, but this check prevents the browser from crashing as a consequence of it.
One situation where this can happen today (and needs to be fixed renderer-side), is when the renderer cancel's a request in response to IGNORE policy, but then later tries to follow the redirect on the cancelled request.

BUG=20470


Review URL: http://codereview.chromium.org/2793001
------------------------------------------------------------------------
r49420 | tim@chromium.org | 2010-06-10 20:13:12 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h

Add histogram coverage of session service Save() operations, namely the time between successive Save() operations.

BUG=none
TEST=about:histograms

Review URL: http://codereview.chromium.org/2732005
------------------------------------------------------------------------
r49417 | ananta@chromium.org | 2010-06-10 20:01:28 +0200 (Thu, 10 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/metrics_helpers.cc (from /trunk/src/chrome/common/metrics_helpers.cc:49381)
   A /trunk/src/chrome/common/metrics_helpers.h (from /trunk/src/chrome/common/metrics_helpers.h:49381)

Relanding this CL as the earlier attempt broke ChromeOS metrics tests.

Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean 
that metrics reporting would be done directly by ChromeFrame. Currently ChromeFrame uses Chrome to
upload this data.

Refactored the chrome metrics service and metrics logging functionality into base classes defined in 
chrome\common\metrics_helpers.cc/.h. While this refactoring is by no means complete it is a first step
to avoid needless code duplication between chrome and chrome frame.

Bug=46057
TBR=amit
Review URL: http://codereview.chromium.org/2731006
------------------------------------------------------------------------
r49411 | wtc@chromium.org | 2010-06-10 18:31:04 +0200 (Thu, 10 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

UseAlternateResourceHandler should set the non-owning pointer
to the CrossSiteResourceHandler in the extra request info to
NULL when it deletes the original ResourceHandler chain.

R=brettw,jschuh
BUG=46126
TEST=See bug report.
Review URL: http://codereview.chromium.org/2787005
------------------------------------------------------------------------
r49410 | wtc@chromium.org | 2010-06-10 18:29:35 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/page_info_model.cc

Trivial change: update a comment.

R=jcivelli
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2566004
------------------------------------------------------------------------
r49409 | chaitanyag@chromium.org | 2010-06-10 18:26:58 +0200 (Thu, 10 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_speech_synthesis_library.h
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.h

Added InitTts function to speech synthesis library. Re-make of CL 2510001 which broke build because of a missing deps
Original Issue:
http://codereview.chromium.org/2510001/show
Review URL: http://codereview.chromium.org/2769005
------------------------------------------------------------------------
r49408 | thomasvl@chromium.org | 2010-06-10 18:23:36 +0200 (Thu, 10 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/About.xib
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

[Mac] Move the two buttons under the text and put them both on the same line.  This will give more space for the update strings.  Keeping things simple at this point since there are already threads on chromium-dev about redoing the aboutbox/about:version for updates in general.

BUG=38685
TEST=see bug
Review URL: http://codereview.chromium.org/2740009
------------------------------------------------------------------------
r49406 | dhg@chromium.org | 2010-06-10 18:21:13 +0200 (Thu, 10 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Changing filebrowse so it sends the user to /home on a picasaweb upload rather than directly to the dropbox.  This is because there is no guarenteed way to send the user to the dropbox using the gdata API.

Adding some strings for passing into the javascript the state of directories which should be allowed

BUG=chromium-os:1963,chromium-os:2558
TEST=none
Review URL: http://codereview.chromium.org/2663007
------------------------------------------------------------------------
r49405 | joth@chromium.org | 2010-06-10 18:10:18 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc

Remove spurious MovementDetected functions  (follow up to http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=43339&r2=48711)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2747008
------------------------------------------------------------------------
r49401 | podivilov@chromium.org | 2010-06-10 17:35:37 +0200 (Thu, 10 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc

Fix bug with mismatching types in preferences.

When actual type of data in preferences is different from
what chrome expects (for example string instead of dictionary)
chrome crashes.

Review URL: http://codereview.chromium.org/2757007
------------------------------------------------------------------------
r49399 | rogerta@google.com | 2010-06-10 17:25:46 +0200 (Thu, 10 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/rlz/rlz.h
   M /trunk/src/chrome/browser/rlz/rlz_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi

Link with RLZ library from open source repo.

In order to pass the check dependency step in the build, I added rlz to
the include_rules in DEPS.  However, I am not sure this is the best solution.

TEST=Make sure that the RLZ pings from chrome are the sameas they were with
the old RLZ dll
BUG=none

Review URL: http://codereview.chromium.org/2755002
------------------------------------------------------------------------
r49397 | davemoore@chromium.org | 2010-06-10 16:50:04 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Send boot times to UMA.

BUG=none
TEST=gmerged on netbook, logged in/out, rebooted, inspected about:histograms

Review URL: http://codereview.chromium.org/2711009
------------------------------------------------------------------------
r49393 | thomasvl@chromium.org | 2010-06-10 16:07:43 +0200 (Thu, 10 Jun 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

BrowserTests: UserNotPassed UserPassed started failing on chromiumos builder with this cl.

Revert 49375 - Hide the input language menu if there is only one input method and it's a XKB keyboard layout.

For instance, if English USA keyboard layout is the only input method enabled,
we don't show the input language menu on the right upper corner.

On the other hand,  if Japanese input method is the only input method enabled,
we still show the input language menu so users can change the intra input method
modes, like Hiragana and Katakana modes.

BUG=chromiumos:2275
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/2729009

TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/2754007
------------------------------------------------------------------------
r49391 | thomasvl@chromium.org | 2010-06-10 15:54:08 +0200 (Thu, 10 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

This added to already failing browser_tests on the chromiumos builder on the waterfall.

Revert 49380 - Share the same keyboard layout among all windows.

BUG=chromiumos:2433
TEST=manually

Review URL: http://codereview.chromium.org/2781006

TBR=yusukes@google.com
Review URL: http://codereview.chromium.org/2738007
------------------------------------------------------------------------
r49390 | jochen@chromium.org | 2010-06-10 15:14:44 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/api
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/api/background.html (from /trunk/src/chrome/test/data/extensions/api_test/cookies/background.html:49388)
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/api/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/cookies/manifest.json:49388)
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/api/tab.html (from /trunk/src/chrome/test/data/extensions/api_test/cookies/tab.html:49388)
   D /trunk/src/chrome/test/data/extensions/api_test/cookies/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/events
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/events/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/events/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/cookies/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/cookies/tab.html

Send event on changes to the cookie monster.

BUG=38398
TEST=*.CookiesEvents

Review URL: http://codereview.chromium.org/2703004
------------------------------------------------------------------------
r49388 | jochen@chromium.org | 2010-06-10 14:55:00 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   A /trunk/src/chrome/browser/browsing_data_appcache_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   A /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Wrappers around BrowsingDataHelpers that returned canned responses.

BUG=45230
TEST=CannedBrowsingData*HelperTest.*

Review URL: http://codereview.chromium.org/2707001
------------------------------------------------------------------------
r49383 | joth@chromium.org | 2010-06-10 13:08:28 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   A /trunk/src/chrome/test/data/geolocation/two_watches.html

Add test for multiple geolocation watches in a single frame (aka bridge)

BUG=40101
TEST=GeolocationBrowserTest.TwoWatchesInOneFrame

Review URL: http://codereview.chromium.org/2740007
------------------------------------------------------------------------
r49382 | joth@chromium.org | 2010-06-10 13:04:38 +0200 (Thu, 10 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/metrics_helpers.cc
   D /trunk/src/chrome/common/metrics_helpers.h

Revert 49354 - causing regression in MetricsLogTest.ChromeOSEmptyRecord on CrOS

Original r49354 description: Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean that metrics reporting would be done directly
by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data. 

Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While
this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame.

Bug=46057

Review URL: http://codereview.chromium.org/2744003

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/2779013
------------------------------------------------------------------------
r49381 | phajdan.jr@chromium.org | 2010-06-10 12:40:46 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

[GTTF] Use FRIEND_TEST_ALL_PREFIXES in chrome/browser/sync

TEST=none
BUG=44549

Review URL: http://codereview.chromium.org/2658003
------------------------------------------------------------------------
r49380 | yusukes@google.com | 2010-06-10 12:20:28 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Share the same keyboard layout among all windows.

BUG=chromium-os:2433
TEST=manually

Review URL: http://codereview.chromium.org/2781006
------------------------------------------------------------------------
r49375 | satorux@chromium.org | 2010-06-10 11:26:00 +0200 (Thu, 10 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

Hide the input language menu if there is only one input method and it's a XKB keyboard layout.

For instance, if English USA keyboard layout is the only input method enabled,
we don't show the input language menu on the right upper corner.

On the other hand,  if Japanese input method is the only input method enabled,
we still show the input language menu so users can change the intra input method
modes, like Hiragana and Katakana modes.

BUG=chromium-os:2275
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/2729009
------------------------------------------------------------------------
r49371 | yusukes@google.com | 2010-06-10 08:13:44 +0200 (Thu, 10 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Revert the change to language_config_view.cc, which was wrongly introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=49369

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2729008
------------------------------------------------------------------------
r49369 | yusukes@google.com | 2010-06-10 07:38:25 +0200 (Thu, 10 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add checkboxes for configuring the boolean type of Mozc configurations.

The original patch was written by mazda@chromium.org.
http://codereview.chromium.org/2778002/show

BUG=chromium-os:2625
TEST=manual

Review URL: http://codereview.chromium.org/2778002
------------------------------------------------------------------------
r49367 | yusukes@google.com | 2010-06-10 05:57:38 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc

Sort input methods names in the language selector by language names.

BUG=chromium-os:3867
TEST=manual. ran the unit_test as well.

Review URL: http://codereview.chromium.org/2764001
------------------------------------------------------------------------
r49366 | yusukes@google.com | 2010-06-10 05:47:30 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

Don't use disabled (gray) state for the language indicator.

BUG=chromium-os:3683
TEST=manual

Review URL: http://codereview.chromium.org/2767001
------------------------------------------------------------------------
r49364 | zork@chromium.org | 2010-06-10 05:35:15 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc

Fix chewing layout

BUG=chromium-os:3966
TEST=Open chewing options.  Examine.

Review URL: http://codereview.chromium.org/2755003
------------------------------------------------------------------------
r49361 | yusukes@google.com | 2010-06-10 05:33:48 +0200 (Thu, 10 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Deactivate all input methods (except keyboard layouts) when screen is locked.
Reactivates them when screen is unlocked.

Note that if two or more keyboard layouts are active, you can switch layout by pressing the language hot-key (Shift+Alt), though the language indicator ("EN") is not clickable yet.

BUG=chromium-os:3936
BUG=chromium-os:2714
TEST=manual

Review URL: http://codereview.chromium.org/2771005
------------------------------------------------------------------------
r49360 | akalin@chromium.org | 2010-06-10 05:25:43 +0200 (Thu, 10 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/SyncCustomize.xib
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller.h
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller.mm

[Mac] Added (disabled) UI for extensions sync on OS X.

SyncCustomize.xib changes: Added checkbox for extensions and hooked it up
via KVO to SyncCustomizeController.

BUG=32413
TEST=manual

Review URL: http://codereview.chromium.org/2714006
------------------------------------------------------------------------
r49357 | ananta@chromium.org | 2010-06-10 04:07:07 +0200 (Thu, 10 Jun 2010) | 11 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/tools/sync_constants.cc
   D /trunk/src/chrome/browser/sync/tools/sync_constants.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

Revert 49353 - sync: Store hard coded constants into its header file.

(Note: This was a TODO for akalin).

BUG=None
TEST=trybots, and manually

Review URL: http://codereview.chromium.org/2704002

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2733009
------------------------------------------------------------------------
r49354 | ananta@chromium.org | 2010-06-10 03:21:00 +0200 (Thu, 10 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/metrics_helpers.cc
   A /trunk/src/chrome/common/metrics_helpers.h

Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean that metrics reporting would be done directly
by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data. 

Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While
this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame.

Bug=46057

Review URL: http://codereview.chromium.org/2744003
------------------------------------------------------------------------
r49353 | tfarina@chromium.org | 2010-06-10 03:13:11 +0200 (Thu, 10 Jun 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/tools/sync_constants.cc
   A /trunk/src/chrome/browser/sync/tools/sync_constants.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

sync: Store hard coded constants into its header file.

(Note: This was a TODO for akalin).

BUG=None
TEST=trybots, and manually

Review URL: http://codereview.chromium.org/2704002
------------------------------------------------------------------------
r49350 | pkasting@chromium.org | 2010-06-10 02:56:28 +0200 (Thu, 10 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/SideToolbar.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Make the reload button respond to middle-clicks like back/forward/home already do.

This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward.

BUG=none
TEST=Middle-click reload.  It should reload the page in a new background tab.
Review URL: http://codereview.chromium.org/2779011
------------------------------------------------------------------------
r49348 | mattm@chromium.org | 2010-06-10 02:48:20 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/process_singleton_win.cc

Win: Fix race possible during startup before first Browser is created.

BUG=38572
TEST=uitest, also "chrome/Debug/chrome.exe & chrome/Debug/chrome.exe"

Review URL: http://codereview.chromium.org/2664004
------------------------------------------------------------------------
r49344 | jcivelli@chromium.org | 2010-06-10 02:22:56 +0200 (Thu, 10 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc

Relanding 49339 
It was unjustly reverted due to flaky unit-test failure.
Original review:

http://codereview.chromium.org/2358003

TBR=ctguil@chromium.org

Review URL: http://codereview.chromium.org/2720003
------------------------------------------------------------------------
r49343 | jcivelli@chromium.org | 2010-06-10 02:08:32 +0200 (Thu, 10 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc

Revert 49339 - Enable renderer accessibility by default.
It seems to be breaking the ExtensionAPIClientTest.CreateWindowW unit-test.

BUG=25564
TEST=none

Review URL: http://codereview.chromium.org/2358003

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2782003
------------------------------------------------------------------------
r49339 | ctguil@chromium.org | 2010-06-10 01:02:30 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc

Enable renderer accessibility by default.

BUG=25564
TEST=none

Review URL: http://codereview.chromium.org/2358003
------------------------------------------------------------------------
r49337 | skerner@chromium.org | 2010-06-10 00:56:48 +0200 (Thu, 10 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/base/data/valgrind/base_unittests.gtest_mac.txt
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility_process_host.cc

Give the extension unpacker process a junction/symlink free path to the unpack directory.

BUG=35198,13044
TEST=FileUtilTest.NormalizeFilePathBasic,FileUtilTest. NormalizeFilePathReparsePoints,FileUtilTest.NormalizeFilePathSymlinks

Review URL: http://codereview.chromium.org/2088006
------------------------------------------------------------------------
r49336 | mirandac@chromium.org | 2010-06-10 00:52:05 +0200 (Thu, 10 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/importer/safari_importer.mm

Fix password import for OS X Firefox.

BUG=18775
TEST=import passwords from Firefox on OS X.
Review URL: http://codereview.chromium.org/2725005
------------------------------------------------------------------------
r49334 | mark@chromium.org | 2010-06-10 00:39:17 +0200 (Thu, 10 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm
   M /trunk/src/chrome/browser/platform_util_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_exe.gypi

Take Keystone keys out of the framework's Info.plist. They now live only in
the outer application's Info.plist.

This ensures that the framework and other contents of the versioned directory
can be bit-for-bit identical for a given version, regardless of configured
Keystone channel. This will enable binary diff updates, because they will not
need knowledge of the channel a user is upgrading from.

BUG=45017
TEST=Keystone still functions properly, channel still shows up in the about
     window and about:version of official builds
Review URL: http://codereview.chromium.org/2791001
------------------------------------------------------------------------
r49331 | xiyuan@chromium.org | 2010-06-10 00:05:40 +0200 (Thu, 10 Jun 2010) | 16 lines
Changed paths:
   A /trunk/src/chrome/app/theme/mediaplayer_vol_mute.png
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/mediaplayer.html

Mute when clicked on sound button in ChromeOS media player.

- Add a sound mute icon and swap between sound high and mute icon based on
  volume change;
- Change sound button click to toggle volume mute;
- Show volume control when mouse over sound button and hide it when mouse
  leaves;
- Call volumeChange after we setupPlaybackControls so that volume slider's
  value syncs with media element's volume;
- Removed "controlbutton" class from "volume" element because it is really
  a control button and "controlbutton" style sets its hight to 30px;

BUG=chromium-os:3148
TEST=Verify click on sound button mute/unmute audio and volume slider shows up when mouse over sound button.

Review URL: http://codereview.chromium.org/2722006
------------------------------------------------------------------------
r49330 | jshin@chromium.org | 2010-06-10 00:04:04 +0200 (Thu, 10 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

PageLanguageDetectionTest has the failure rate of 5 - 6% on XP/Vista. Mark it
as flaky on Windows

BUG=46198
TEST=XP/Vista bots do not turn red due to this test.
TBR=jcivelli
Review URL: http://codereview.chromium.org/2739005
------------------------------------------------------------------------
r49328 | johnnyg@chromium.org | 2010-06-09 23:47:24 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc

Properly escape user input for notifications, since URL-encoded characters are leaking through as HTML in non-HTML notifications.

BUG=45859
TEST=see bug

Review URL: http://codereview.chromium.org/2743007
------------------------------------------------------------------------
r49322 | seanparent@google.com | 2010-06-09 23:30:40 +0200 (Wed, 09 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Cleanup of about box

Removed redundent version from update string.
Added a line break to the ChromeOS version on test builds to improve appearence
(select and drag to see complete version).
Added margins to multiline edit fields without borders to make them match
single line edit fields in positioning.
Fixed an issue with setting the initial focus for GTK based windows. This
fixes the problem of the cursor showing up in the version field.

BUG=chromium-os:3571 1589 2967
TEST=none

Review URL: http://codereview.chromium.org/2620003
------------------------------------------------------------------------
r49321 | rsesek@chromium.org | 2010-06-09 23:26:41 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h

Make AutoFillDialogController conform to NSTableViewDelegate.

BUG=none
TEST=Build succeeds using 10.6 SDK

Review URL: http://codereview.chromium.org/2790005
------------------------------------------------------------------------
r49320 | willchan@chromium.org | 2010-06-09 23:20:41 +0200 (Wed, 09 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/message_pump_libevent.h
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/message_pump_win.h
   M /trunk/src/base/tracked.h
   M /trunk/src/chrome/browser/jankometer.cc

Reland r49188.
It was reverted due to breaking a valgrind test which has since been disabled.

Review URL: http://codereview.chromium.org/2763004
------------------------------------------------------------------------
r49319 | finnur@chromium.org | 2010-06-09 23:19:40 +0200 (Wed, 09 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc
   A /trunk/src/chrome/browser/gtk/extension_infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/extension_infobar_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

Infobars on GTK (first part).

I got it to a point where we show HTML content from the extension within an infobar, but there are a few things missing.

Missing pieces:
- Infobar does not size based on the height of its content (between 36px and 72px).
- Infobar content always has a fixed width, but needs to fill out into the available infobar area.
- I've put in code to asynchronously fetch the image for the Infobar, but it needs to be shown and hooked up to the ExtensionAction context menu (same context menu we use for the browser action container icons).
- The background for HTML content should have a gradient, but is just solid blue at the moment.

BUG=39916
TEST=Infobars should show up on GTK.

Review URL: http://codereview.chromium.org/2753005
------------------------------------------------------------------------
r49315 | pkasting@chromium.org | 2010-06-09 22:56:41 +0200 (Wed, 09 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Clean up bits of the toolbar code.

The reason I'm collapsing all the "create left/center/right sections" functions into one is because in the upcoming patch that moves "stop" from "go" onto "reload", I'll need to reorder bits within this unified block, and that change will be easier to review if this mechanical change lands first.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2781003
------------------------------------------------------------------------
r49314 | oshima@chromium.org | 2010-06-09 22:51:30 +0200 (Wed, 09 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Remove all grab widget in screen locker so that gtk simply propagate events,
 instead of adding window_contents_ as grab widget.
 Explicitly adding grab widget was confusing gtk and the event has been handled by grab widget rather than by the window the event is forwarded to.
 This CL fixes it by removing all grab widget and let gtk propagage event in target window.

BUG=none
TEST=open screen locker, type wrong password to show message bubble,
then close it by clicking close (x) button.

Review URL: http://codereview.chromium.org/2788001
------------------------------------------------------------------------
r49312 | csilv@chromium.org | 2010-06-09 22:43:25 +0200 (Wed, 09 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc

Change notification handling to prevent multiple 'Do you mean...?' infobars from
displaying in a tab.  This could happen when the user types in a new query before
the AlternateNavURLFetcher was able to resolve the URL.

BUG=43378
TEST=Load two single word domains within quick succession in the same tab.
Review URL: http://codereview.chromium.org/2747006
------------------------------------------------------------------------
r49310 | dhg@chromium.org | 2010-06-09 22:33:36 +0200 (Wed, 09 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/platform_util_chromeos.cc
   M /trunk/src/chrome/browser/resources/media_common.js

Adding support for .txt files.

BUG=chromium-os:3462
TEST=none
Review URL: http://codereview.chromium.org/2758004
------------------------------------------------------------------------
r49307 | jcivelli@chromium.org | 2010-06-09 22:23:15 +0200 (Wed, 09 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   A /trunk/src/chrome/browser/translate/languages_menu_model2.cc
   A /trunk/src/chrome/browser/translate/languages_menu_model2.h
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.h
   A /trunk/src/chrome/browser/translate/options_menu_model2.cc
   A /trunk/src/chrome/browser/translate/options_menu_model2.h
   A /trunk/src/chrome/browser/translate/translate_infobar_delegate2.cc
   A /trunk/src/chrome/browser/translate/translate_infobar_delegate2.h
   A /trunk/src/chrome/browser/translate/translate_infobar_view.h
   A /trunk/src/chrome/browser/translate/translate_manager2.cc
   A /trunk/src/chrome/browser/translate/translate_manager2.h
   A /trunk/src/chrome/browser/translate/translate_manager2_unittest.cc
   A /trunk/src/chrome/browser/views/infobars/after_translate_infobar.cc
   A /trunk/src/chrome/browser/views/infobars/after_translate_infobar.h
   A /trunk/src/chrome/browser/views/infobars/before_translate_infobar.cc
   A /trunk/src/chrome/browser/views/infobars/before_translate_infobar.h
   A /trunk/src/chrome/browser/views/infobars/infobar_button_border.cc
   A /trunk/src/chrome/browser/views/infobars/infobar_button_border.h
   A /trunk/src/chrome/browser/views/infobars/infobar_text_button.cc
   A /trunk/src/chrome/browser/views/infobars/infobar_text_button.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   A /trunk/src/chrome/browser/views/infobars/translate_infobar_base.cc
   A /trunk/src/chrome/browser/views/infobars/translate_infobar_base.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   A /trunk/src/chrome/browser/views/infobars/translate_message_infobar.cc
   A /trunk/src/chrome/browser/views/infobars/translate_message_infobar.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Refactored the translate infobars.
Since some work is needed on Linux and Mac to use the new translate infobar delegate, I created a new version of the refactored classes instead of replacing them. Once Linux and Mac use the new classes, we can make the swicth.
The TranslateInfoBarDelegate now contains all states, so there is no more logic on the infobar classes.
I broke down the single infobar class into multiple ones (there is now an infobar for each state: before translate, translating, after translate, error): it makes the code simpler.
I had to fix ReplaceInfoBar on Windows as it was not working properly.

BUG=40828
TEST=Test thoroughly the translate feature.

Review URL: http://codereview.chromium.org/2602003
------------------------------------------------------------------------
r49296 | evan@chromium.org | 2010-06-09 20:43:01 +0200 (Wed, 09 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/gpu/gpu_main.cc
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/profile_import/profile_import_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/service/service_main.cc
   M /trunk/src/chrome/utility/utility_main.cc
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/media/filters/video_renderer_base.cc
   M /trunk/src/sandbox/src/broker_services.cc

Rename Chrome threads to use a "Cr" prefix.

Before we carefully used the app (Chrome/Chromium) name, but:
1) these are for internal debugging use only, so why compute this name
2) on Linux the thread ids are limited to 16 characters, and "Chromium"
   is too long

Review URL: http://codereview.chromium.org/2741003
------------------------------------------------------------------------
r49294 | nshkrob@chromium.org | 2010-06-09 20:37:49 +0200 (Wed, 09 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

1. Create and use the TopSites database file.
2. Timed updates of the database based on the number of sites changed.

BUG=None
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2746002
------------------------------------------------------------------------
r49292 | eroman@chromium.org | 2010-06-09 20:34:27 +0200 (Wed, 09 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc

Cleanup: Fix an innacurate test name.

Review URL: http://codereview.chromium.org/2746005
------------------------------------------------------------------------
r49291 | evan@chromium.org | 2010-06-09 20:23:00 +0200 (Wed, 09 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h

gtk: fix 18949 on GTK ("Options" window does not fit a small display).

Change the layout of content and general page. Use the horizontal title and content layout for each option group.

BUG=18949
TEST=Open the option window, check the content and general pages.

Patch by Ningxin Hu <ningxin.hu@intel.com>.

Review URL: http://codereview.chromium.org/1969006
------------------------------------------------------------------------
r49288 | agl@chromium.org | 2010-06-09 20:10:56 +0200 (Wed, 09 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Log the errno when the zygote fails to fork.

BUG=46114
------------------------------------------------------------------------
r49287 | shess@chromium.org | 2010-06-09 20:10:04 +0200 (Wed, 09 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm

[Mac] Simplify generating composited browser-action image.

Convert from using NSBitmapImageRep plus context manipulation to
-[NSImage lockFocus].

BUG=none
TEST=Browser actions look the same as before.

Review URL: http://codereview.chromium.org/2635005
------------------------------------------------------------------------
r49284 | mirandac@chromium.org | 2010-06-09 19:53:07 +0200 (Wed, 09 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.h

Fix import crash in Mac 10.6 only.

A DictionaryValue we need to keep was being autoreleased in the Mac message loop. The import process uses only C++ code, so we just make a deep copy of the (very small, 5 strings) Dictionary when it's passed into the bridge.

BUG=46003
TEST=import works on Mac OS 10.6 and 10.5
Review URL: http://codereview.chromium.org/2715006
------------------------------------------------------------------------
r49282 | shess@chromium.org | 2010-06-09 19:48:30 +0200 (Wed, 09 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

[Mac] Remove dead underlayImage_ from GradientButtonCell.

AFAICT was being used by the star button, which is now a page action.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2675003
------------------------------------------------------------------------
r49279 | dhollowa@chromium.org | 2010-06-09 19:40:10 +0200 (Wed, 09 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_address_sheet_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm

TBR: miranda@chromium.org
------------------------------------------------------------------------
r49274 | dhollowa@chromium.org | 2010-06-09 19:19:57 +0200 (Wed, 09 Jun 2010) | 11 lines
Changed paths:
   D /trunk/src/chrome/app/nibs/AutoFillAddressFormView.xib
   A /trunk/src/chrome/app/nibs/AutoFillAddressSheet.xib
   D /trunk/src/chrome/app/nibs/AutoFillCreditCardFormView.xib
   A /trunk/src/chrome/app/nibs/AutoFillCreditCardSheet.xib
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac_unittest.mm
   A /trunk/src/chrome/browser/autofill/autofill_address_sheet_controller_mac.h (from /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.h:49273)
   A /trunk/src/chrome/browser/autofill/autofill_address_sheet_controller_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_address_sheet_controller_mac_unittest.mm (from /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac_unittest.mm:49273)
   D /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.h
   D /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.mm
   D /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h (from /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.h:49273)
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_sheet_controller_mac_unittest.mm (from /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac_unittest.mm:49273)
   D /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.h
   D /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.mm
   D /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   D /trunk/src/chrome/browser/cocoa/disclosure_view_controller.h
   D /trunk/src/chrome/browser/cocoa/disclosure_view_controller.mm
   D /trunk/src/chrome/browser/cocoa/disclosure_view_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/section_separator_view.h
   D /trunk/src/chrome/browser/cocoa/section_separator_view.mm
   D /trunk/src/chrome/browser/cocoa/section_separator_view_unittest.mm
   D /trunk/src/chrome/browser/cocoa/vertical_layout_view.h
   D /trunk/src/chrome/browser/cocoa/vertical_layout_view.mm
   D /trunk/src/chrome/browser/cocoa/vertical_layout_view_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill Profiles dialog implemented according to new mocks on Mac

New mocks are attached to bug 44622.  These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data.  Changes to the layout of fields on the sheets has been done also.
AutoFillDialog.xib changes:  Replaced disclosure based list of address and credit cards with an NSTableView of the same data.  Added buttons for "Add", "Edit", and "Remove".
Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib.
Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib.

BUG=44621
TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest

Review URL: http://codereview.chromium.org/2673006
------------------------------------------------------------------------
r49272 | andreip@chromium.org | 2010-06-09 19:04:19 +0200 (Wed, 09 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc

Set handled flag to true inside IndexedDBDispatcherHost::OnMessageReceivedWebKit()
before passing the message to IndexedDBDispatcherHost for processing.

This is a clone of

http://codereview.chromium.org/2657007/show

which was LGTM'ed by Jeremy Orlow.

Review URL: http://codereview.chromium.org/2711004
------------------------------------------------------------------------
r49271 | joth@chromium.org | 2010-06-09 19:01:13 +0200 (Wed, 09 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Clean up geolocation_dispatcher_host.h

It was pulling internal geolocation headers into resource_message_filter.cc

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2742002
------------------------------------------------------------------------
r49269 | brettw@chromium.org | 2010-06-09 18:59:42 +0200 (Wed, 09 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/webkit/glue/plugins/pepper_plugin_module.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_posix.cc
   A /trunk/src/webkit/glue/plugins/plugin_switches.cc
   A /trunk/src/webkit/glue/plugins/plugin_switches.h
   M /trunk/src/webkit/glue/webkit_glue.gypi

Add a command line switch to enable the pepper testing interface. This moves the other switch we were using in the plugins directory to the new file as well.

TEST=covered by UI test
BUG=none
Review URL: http://codereview.chromium.org/2716002
------------------------------------------------------------------------
r49268 | nkostylev@google.com | 2010-06-09 18:59:01 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc

Disable language menu during sign in process.

BUG=none
TEST=All controls are disabled on "New User" screen with login is in progress

Review URL: http://codereview.chromium.org/2774004
------------------------------------------------------------------------
r49267 | andreip@chromium.org | 2010-06-09 18:58:32 +0200 (Wed, 09 Jun 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h
   A /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.cc
   A /trunk/src/chrome/renderer/renderer_webidbobjectstore_impl.h

Implement IDBDatabase::createObjectStore. Also refactor IndexedDBCallbacks.

This CL is a clone of

http://codereview.chromium.org/2607001/show

which was reviewd and LGTM'ed by Jeremy Orlow.

Review URL: http://codereview.chromium.org/2740003
------------------------------------------------------------------------
r49264 | rsesek@chromium.org | 2010-06-09 18:30:40 +0200 (Wed, 09 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_speech_synthesis_library.h
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.h

Revert 49260 - Broke compile - Added InitTts function to speech synthesis library
Review URL: http://codereview.chromium.org/2510001

TBR=chaitanyag@chromium.org
Review URL: http://codereview.chromium.org/2770006
------------------------------------------------------------------------
r49262 | shess@chromium.org | 2010-06-09 18:22:08 +0200 (Wed, 09 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm

[Mac] Adapt browser-action image-drawing to ignore flipped.

Changed drawing to use -drawInRect: rather than -drawAtPoint: so that
the neverFlipped: flag can be passed.

BUG=38943
TEST=Browser actions draw upright in both toolbar and overflow popup.

Review URL: http://codereview.chromium.org/2685001
------------------------------------------------------------------------
r49261 | nkostylev@google.com | 2010-06-09 18:20:05 +0200 (Wed, 09 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/login/login_html_dialog.cc
   A /trunk/src/chrome/browser/chromeos/login/login_html_dialog.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Add OOBE/login html dialog.
Use it for "Can't access your account" link.

BUG= http://crosbug.com/3179
TEST=Open "Can't access your account" link from "New User" view.

Review URL: http://codereview.chromium.org/2675007
------------------------------------------------------------------------
r49260 | chaitanyag@chromium.org | 2010-06-09 18:11:57 +0200 (Wed, 09 Jun 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_speech_synthesis_library.h
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.h

Added InitTts function to speech synthesis library
Review URL: http://codereview.chromium.org/2510001
------------------------------------------------------------------------
r49258 | tim@chromium.org | 2010-06-09 18:06:01 +0200 (Wed, 09 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.cc
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/resources/about_sync.html
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h

Add routing info and unrecoverable error info to about:sync.

(Needs http://codereview.chromium.org/2002012 to build).

BUG=42695
TEST=manually visit about:sync

Review URL: http://codereview.chromium.org/1987009
------------------------------------------------------------------------
r49257 | xiyuan@chromium.org | 2010-06-09 18:04:19 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Don't allow drop to panels (pop-ups) in ChromeOS.

BUG=chromium-os:2413
TEST=Verify fix for chromium-os:2413.

Review URL: http://codereview.chromium.org/2779004
------------------------------------------------------------------------
r49254 | xiyuan@chromium.org | 2010-06-09 18:00:15 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Show theme loading info bubble and info bars in last normal browser.

BUG=chromium-os:1797
TEST=Verify fix for chromium-os:1791.

Review URL: http://codereview.chromium.org/2659004
------------------------------------------------------------------------
r49253 | sky@chromium.org | 2010-06-09 17:58:47 +0200 (Wed, 09 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/common/notification_type.h

Adds notification of when zoom level changes. I'm going to need this
for the merged menu so that I can update the zoom level in the menu
appropriately.

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2637006
------------------------------------------------------------------------
r49237 | bauerb@chromium.org | 2010-06-09 10:42:51 +0200 (Wed, 09 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h

Don't save last used locations in open and save dialogs when in incognito mode.

For "Save page as..." we simply don't store the save location in incognito mode.

For "Open File"... and file upload controls, it's a bit more complicated: because NSOpenPanel and NSSavePanel default to using the last chosen directory from NavigationServices (which we can't influence),
we provide a preference value prefs::kLastChosenDirectory as fallback there, which is not persisted in incognito mode.

BUG=45064
TEST=See bug for manual test.

Review URL: http://codereview.chromium.org/2450004
------------------------------------------------------------------------
r49236 | jshin@chromium.org | 2010-06-09 10:35:28 +0200 (Wed, 09 Jun 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/resources/locale_settings_cros.grd (from /trunk/src/chrome/app/resources/locale_settings_linux.grd:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_am.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_am.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ar.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_bg.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_bg.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_bn.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_bn.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ca.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ca.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_cs.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_cs.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_da.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_da.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_de.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_de.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_el.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_el.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_en-GB.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_en-GB.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_es-419.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_es-419.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_es.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_es.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_et.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_et.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_fi.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_fi.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_fil.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_fil.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_fr.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_fr.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_gu.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_gu.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_he.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_he.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_hi.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_hi.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_hr.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_hr.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_hu.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_hu.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_id.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_id.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_it.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_it.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ja.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ja.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_kn.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_kn.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ko.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ko.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_lt.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_lt.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_lv.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_lv.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ml.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ml.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_mr.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_mr.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_nb.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_nb.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_nl.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_nl.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_pl.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_pl.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_pt-BR.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_pt-BR.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_pt-PT.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_pt-PT.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ro.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ro.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ru.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ru.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_sk.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sk.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_sl.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sl.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_sr.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sr.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_sv.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sv.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_sw.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sw.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_ta.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ta.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_te.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_te.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_th.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_th.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_tr.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_tr.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_uk.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_uk.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_vi.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_vi.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_zh-CN.xtb:48638)
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb (from /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_zh-TW.xtb:48638)
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Add platform_locale_settings file for CrOS.  This is necessary because
fonts available on CrOS are different from fonts on typical Linux disributions.

BUG=cros:3815 (http://crosbug.com/3815)
TEST=Go to a web page that only specifies CSS generic families (e.g. sans-serif,serif, monospace) and make sure that Ascender Sans, Ascender Serif are used. 

Review URL: http://codereview.chromium.org/2702001
------------------------------------------------------------------------
r49234 | akalin@chromium.org | 2010-06-09 08:51:10 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Added extensions sync-related constants, switches, and clauses.

BUG=32413
TEST=trybots

Review URL: http://codereview.chromium.org/2749005
------------------------------------------------------------------------
r49233 | oshima@chromium.org | 2010-06-09 08:47:43 +0200 (Wed, 09 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h

Wait sending ScreenIsLocked signal until screen lock window is mapped.
 * When closing and opening the lid, chrome window is briefly visible because
   the computer is suspended before window is fully mapped and covers the
   screen.

BUG=none
TEST=manual: close and open the lid shoudl not expose the content of chrome window.

Review URL: http://codereview.chromium.org/2762001
------------------------------------------------------------------------
r49231 | akalin@chromium.org | 2010-06-09 08:26:52 +0200 (Wed, 09 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/password_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h

Changed syncable::PASSWORD to syncable::PASSWORDS for consistency
with other constants.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2770003
------------------------------------------------------------------------
r49226 | jhawkins@chromium.org | 2010-06-09 07:17:44 +0200 (Wed, 09 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

gtk: Populate the AutoFill billing address combobox with profile labels.  Also
remove handling of the default profile, which is no longer a part of the
feature.

BUG=41645
TEST=none

Review URL: http://codereview.chromium.org/2751001
------------------------------------------------------------------------
r49225 | hamaji@chromium.org | 2010-06-09 07:10:48 +0200 (Wed, 09 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/message_pump_libevent.h
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/message_pump_win.h
   M /trunk/src/base/tracked.h
   M /trunk/src/chrome/browser/jankometer.cc

Rebaseline tests whose expectations were changed by r55714.

The patch removed extra paddings inside buttons.
http://trac.webkit.org/changeset/55714

BUG=1437
TEST=none

Review URL: http://codereview.chromium.org/789003
------------------------------------------------------------------------
r49223 | akalin@chromium.org | 2010-06-09 05:06:03 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/protocol/extension_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp

Added specifics protocol buffer for extensions sync.

BUG=32413
TEST=trybots

Review URL: http://codereview.chromium.org/2762002
------------------------------------------------------------------------
r49219 | estade@chromium.org | 2010-06-09 02:00:51 +0200 (Wed, 09 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/net/base/net_util.cc

revert r49217, which caused unit test failures on win:

Download filename encoding fix:

Fall back on other charsets when using the URL to suggest a filename. The URL should be escaped UTF-8, but may use another encoding instead.

BUG=44301
TEST=see bug.

Review URL: http://codereview.chromium.org/2775002
------------------------------------------------------------------------
r49217 | estade@chromium.org | 2010-06-09 01:48:17 +0200 (Wed, 09 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/net/base/net_util.cc

Download filename encoding fix:

Fall back on other charsets when using the URL to suggest a filename. The URL should be escaped UTF-8, but may use another encoding instead.

BUG=44301
TEST=see bug.

Review URL: http://codereview.chromium.org/2635006
------------------------------------------------------------------------
r49216 | estade@chromium.org | 2010-06-09 01:40:41 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

[GTK] Don't go back twice when double-clicking the mouse's back button.

BUG=45789
TEST=see bug

Review URL: http://codereview.chromium.org/2676002
------------------------------------------------------------------------
r49215 | tim@chromium.org | 2010-06-09 01:40:06 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/password_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/password_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc
   M /trunk/src/chrome/browser/sync/glue/theme_util_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/unrecoverable_error_handler.h

sync: Add location info to unrecoverable errors, and remove the UnrecoverableErrorHandler from model associators since it's illegal to use from there anyway.

BUG=42695
TEST=data type controller unittests

Review URL: http://codereview.chromium.org/2002012
------------------------------------------------------------------------
r49211 | eroman@chromium.org | 2010-06-09 01:25:04 +0200 (Wed, 09 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_unittest.cc
   M /trunk/src/net/proxy/proxy_bypass_rules.cc
   M /trunk/src/net/proxy/proxy_bypass_rules_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_unittest.cc

Allow bypassing a block of IP addresses using CIDR notation in the proxy bypass list.

For example:

   10.3.1.3/16
   2020:ffff::/96

Note that similar to firefox, this is only applied to IP literals in URLs, and NOT to the resolved addresses of URLs.

BUG=9835

Review URL: http://codereview.chromium.org/2663001
------------------------------------------------------------------------
r49203 | pkasting@chromium.org | 2010-06-09 00:45:16 +0200 (Wed, 09 Jun 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/back_noborder.png
   D /trunk/src/chrome/app/theme/forward_noborder.png
   D /trunk/src/chrome/app/theme/go_noborder.png
   D /trunk/src/chrome/app/theme/home_noborder.png
   D /trunk/src/chrome/app/theme/reload_noborder.png
   D /trunk/src/chrome/app/theme/reload_noborder_center.png
   D /trunk/src/chrome/app/theme/stop_noborder.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak

Remove a bunch of images that don't seem to be used.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2722003
------------------------------------------------------------------------
r49197 | zelidrag@chromium.org | 2010-06-09 00:37:44 +0200 (Wed, 09 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/metrics_service_unittest.cc

Submitting CL http://codereview.chromium.org/2324001 on behalf of petkov@chromium.org:

Add the hardwareclass UMA log field for Chrome OS builds.

This field will be used to distinguish histograms across Chrome OS hardware
platforms.

BUG=none
TEST=unit tests, tested on target device by reviewing the logs


Review URL: http://codereview.chromium.org/2738003
------------------------------------------------------------------------
r49196 | zelidrag@chromium.org | 2010-06-09 00:37:33 +0200 (Wed, 09 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h

Redirected system info link from the user feedback dialog to about:system instead of the temp file. 
 
BUG=chromium-os:3947
TEST=open user feedback dialog in ChromeOS, click on 'Included system information...' link, should open about:system page

Review URL: http://codereview.chromium.org/2763002
------------------------------------------------------------------------
r49193 | rohitrao@chromium.org | 2010-06-09 00:09:21 +0200 (Wed, 09 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/find_bar.h

Makes the arguments to GetFindBarWindowInfo optional.  Corrects a comment specifying otherwise.

BUG=46074
TEST=None
Review URL: http://codereview.chromium.org/2764002
------------------------------------------------------------------------
r49190 | thomasvl@chromium.org | 2010-06-08 23:14:52 +0200 (Tue, 08 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc

Marking the test as flaky since it fails 14% of the time.

BUG=46097
TEST=none
Review URL: http://codereview.chromium.org/2724006
------------------------------------------------------------------------
r49188 | willchan@chromium.org | 2010-06-08 22:53:41 +0200 (Tue, 08 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/message_pump_libevent.h
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/message_pump_win.h
   M /trunk/src/base/tracked.h
   M /trunk/src/chrome/browser/jankometer.cc

Jankometer: Generalize the code more.  Add better support for monitoring IO thread.
Previously, the Jankometer only monitored windows messages on the UI thread (or gtk events).
I've added observers for tasks and IO events.  This lets us monitor all events on UI & IO threads (UI messages, all Tasks, and IO events).
Replaces the JankObserver with a UIJankObserver and an IOJankObserver.
Shares common code in JankObserverHelper.  The JankObserverHelper and JankWatchdog are generic enough that they can probably move out to chrome/common and be reused by the renderer.

Review URL: http://codereview.chromium.org/2098020
------------------------------------------------------------------------
r49179 | rsesek@chromium.org | 2010-06-08 21:35:33 +0200 (Tue, 08 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_picker_table.h
   M /trunk/src/chrome/browser/cocoa/tab_view_picker_table_unittest.mm

Fix some errors found when building on the 10.6 SDK.

BUG=none
TEST=Using 10.6 SDK, build succeeds.

Review URL: http://codereview.chromium.org/2717001
------------------------------------------------------------------------
r49175 | evan@chromium.org | 2010-06-08 20:33:44 +0200 (Tue, 08 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc

Revert r49169 and r49170; they didn't fix the problem.
------------------------------------------------------------------------
r49174 | senorblanco@google.com | 2010-06-08 20:24:30 +0200 (Tue, 08 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread_unittest.cc

Disable WebKitThreadTest.ExposedInChromeThread, due to subsequent assert.

BUG=46087
TEST=see bug
TBR=evan

Review URL: http://codereview.chromium.org/2777001
------------------------------------------------------------------------
r49170 | rsesek@chromium.org | 2010-06-08 19:42:31 +0200 (Tue, 08 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc

Fix the build by disabling out unused functions.
------------------------------------------------------------------------
r49169 | evan@chromium.org | 2010-06-08 19:23:08 +0200 (Tue, 08 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc

Disable the extension messages tests.
------------------------------------------------------------------------
r49165 | thomasvl@chromium.org | 2010-06-08 16:40:53 +0200 (Tue, 08 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   A /trunk/src/chrome/browser/autocomplete_history_manager_unittest.cc (from /trunk/src/chrome/browser/autocomplete_history_manager_unittest.cc:49163)
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/chrome_tests.gypi

Putting this back in since it didn't solve the failures.

Revert 49164 - Backing this out to see if it fixes the failures on the two windows bots (landed about when they started).

Revert 49030  AutoFill: Don't save credit card numbers from Autocomplete to the WebDB.

BUG=8026
TEST=AutocompleteHistoryManagerTest

Review URL: http://codereview.chromium.org/2676003

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/2748002

TBR=thomasvl@chromium.org
Review URL: http://codereview.chromium.org/2770001
------------------------------------------------------------------------
r49164 | thomasvl@chromium.org | 2010-06-08 15:43:51 +0200 (Tue, 08 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   D /trunk/src/chrome/browser/autocomplete_history_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/chrome_tests.gypi

Backing this out to see if it fixes the failures on the two windows bots (landed about when they started).

Revert 49030 - AutoFill: Don't save credit card numbers from Autocomplete to the WebDB.

BUG=8026
TEST=AutocompleteHistoryManagerTest

Review URL: http://codereview.chromium.org/2676003

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/2748002
------------------------------------------------------------------------
r49163 | thomasvl@chromium.org | 2010-06-08 15:37:08 +0200 (Tue, 08 Jun 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.h

Revert the revert to put it back in.

Revert 49162 - Doing this to see if it fixes some failing tests that started about when this landed.

Revert 49031  Ensure that the context menu items displayed in ChromeFrame rendered pages are enabled/disabled correctly. To achieve this we now
have a UpdateMenuItemStates function in the RenderViewContextMenuViews class which calls into the underlying menu's UpdateStates
function which enables/disables items correctly.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=45785

Bug=45785

Review URL: http://codereview.chromium.org/2627005

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/2768001

TBR=thomasvl@chromium.org
Review URL: http://codereview.chromium.org/2759002
------------------------------------------------------------------------
r49162 | thomasvl@chromium.org | 2010-06-08 14:33:29 +0200 (Tue, 08 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.h

Doing this to see if it fixes some failing tests that started about when this landed.

Revert 49031 - Ensure that the context menu items displayed in ChromeFrame rendered pages are enabled/disabled correctly. To achieve this we now
have a UpdateMenuItemStates function in the RenderViewContextMenuViews class which calls into the underlying menu's UpdateStates
function which enables/disables items correctly.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=45785

Bug=45785

Review URL: http://codereview.chromium.org/2627005

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/2768001
------------------------------------------------------------------------
r49155 | joth@chromium.org | 2010-06-08 12:46:01 +0200 (Tue, 08 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc

Track options per bridge rather than per dispatcher host
Also fixes a bug in arbitrator that updating options might not stop high accuracy providers

BUG=40103
TEST=unit_tests --gtest_filter=*Geol*

Review URL: http://codereview.chromium.org/2676006
------------------------------------------------------------------------
r49151 | mnissler@chromium.org | 2010-06-08 11:55:47 +0200 (Tue, 08 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   A /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/managed_prefs_banner_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h
   A /trunk/src/chrome/browser/managed_prefs_banner_base.cc
   A /trunk/src/chrome/browser/managed_prefs_banner_base.h
   A /trunk/src/chrome/browser/managed_prefs_banner_base_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Managed preferences warning banner for the Linux preferences dialog.

BUG=43423
TEST=Unit test in managed_prefs_banner_base_unittest.cc, manual UI tests

Review URL: http://codereview.chromium.org/2425006
------------------------------------------------------------------------
r49150 | mnissler@chromium.org | 2010-06-08 11:08:44 +0200 (Tue, 08 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

Remove dead sync label code from browser_toolbar_gtk.cc

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2663006
------------------------------------------------------------------------
r49148 | bauerb@chromium.org | 2010-06-08 10:22:58 +0200 (Tue, 08 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc

Directly set block_third_party_cookies_ when observing a preference change to avoid a NOTREACHED.

BUG=45644
TEST=No crash when changing "Block third-party cookies" preference with an incognito window open.

Review URL: http://codereview.chromium.org/2423003
------------------------------------------------------------------------
r49141 | oshima@chromium.org | 2010-06-08 04:51:42 +0200 (Tue, 08 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h

* Show error message when unlocking failed.
* Add "sign out" button
* Let chrome crash when grab is borken.
* send ScreenIsLocked signal after all inputs are grabbed.

BUG=chromium-os:2914,chromium-os:2614
TEST=manual:
set the content of /var/lib/power_manager/use_xscreensaver to 1,
reboot the machine and login
hit ctr-alt-l to enter screenlock mode
1) typing in wrong password should show message bubble with error message
2) pressing "Sign out" will terminate the session and move to login screen

Review URL: http://codereview.chromium.org/2685006
------------------------------------------------------------------------
r49138 | yusukes@google.com | 2010-06-08 04:13:54 +0200 (Tue, 08 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Remember the current and previous input method IDs as Chrome prefs, and restore them on startup.

BUG=chromium-os:3771
BUG=chromium-os:3378
TEST=manual

Review URL: http://codereview.chromium.org/2690005
------------------------------------------------------------------------
r49134 | arv@chromium.org | 2010-06-08 03:07:06 +0200 (Tue, 08 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js

NTP: Add back the user metrics for navigating to a page through most visited.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2737001
------------------------------------------------------------------------
r49131 | scherkus@chromium.org | 2010-06-08 02:56:37 +0200 (Tue, 08 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.cc
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.h

Add rgb_frame size tracking and resizing to fix security issue with changing sizes.
Added negative checks on signed heights and widths, added negative check for signed heights and widths in backing store for video layering.

Patch by cdn@chromium.org:
http://codereview.chromium.org/2449006/show

BUG=45267
TEST=Run on linux with --enable-video-layering and use <video> tag
------------------------------------------------------------------------
r49130 | erg@chromium.org | 2010-06-08 02:19:59 +0200 (Tue, 08 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   A /trunk/src/chrome/browser/wrench_menu_model.cc
   A /trunk/src/chrome/browser/wrench_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

First unified app menu behind the "--new-wrench-menu" flag.

Does not contain Cole's unified edit menu / zoom controls. This is just
scaffolding that should allow all the rest of the unified menu to exist, while
letting each platform implement the native-only portions in their platform
specific ways.

Only modifies the linux implementation to actually use the new model, though the command line flag and the new model should be shared between platforms.

BUG=45734,45757
TEST=Run with --new-wrench-menu on linux. Notice how long the unified menu is.

Review URL: http://codereview.chromium.org/2677006
------------------------------------------------------------------------
r49128 | jhawkins@chromium.org | 2010-06-08 02:02:12 +0200 (Tue, 08 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

TTF: Re-enable four SafeBrowsingDatabase tests.  Add a comment with bug link for the tests being disabled on Mac.

TBR=stuartmorgan
BUG=46040
TEST=SafeBrowsingDatabase.*

Review URL: http://codereview.chromium.org/2676004
------------------------------------------------------------------------
r49127 | dantasse@chromium.org | 2010-06-08 01:56:12 +0200 (Tue, 08 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Sync backend changes to allow login and initial sync to happen at two different times.

BUG=45869
TEST=syncer_thread_unittest

Review URL: http://codereview.chromium.org/2678001
------------------------------------------------------------------------
r49123 | dpranke@chromium.org | 2010-06-08 01:45:09 +0200 (Tue, 08 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/tools/chromeactions.txt

Modify the password manager code to report at startup whether it is enabled
(by generating one of two UserActions).

    BUG=none
    R=tim@chromium.org, jar@chromium.org
    TEST=none

Review URL: http://codereview.chromium.org/2638001
------------------------------------------------------------------------
r49117 | tfarina@chromium.org | 2010-06-08 01:22:57 +0200 (Tue, 08 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc

gtk: Improve the usage of Exceptions dialog.

1- Select and focus the item being added.
2- When removing an item, if there is more than one, select and focus the previous item.

BUG=None
TEST=open the Exceptions dialog, add an item, next add another item, see if the
second item is the only selected and focused item. Then remove this item, see if
the first item is selected.

Review URL: http://codereview.chromium.org/2585001
------------------------------------------------------------------------
r49113 | arv@chromium.org | 2010-06-08 00:46:12 +0200 (Tue, 08 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmarks: Make sure we remove the tree item from the tree lookup cache when we remove an item.

Change the code to do the add and removal to the cache in the addAt and remove methods to the tree and the tree items.

BUG=42239
TEST=See bug

Review URL: http://codereview.chromium.org/2696001
------------------------------------------------------------------------
r49112 | arv@chromium.org | 2010-06-08 00:44:51 +0200 (Tue, 08 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

NTP: Remove bottom promos.

BUG=None
TEST=Start chrome with a new blank profile. No bottom promos should show up.

Review URL: http://codereview.chromium.org/2637004
------------------------------------------------------------------------
r49111 | rvargas@google.com | 2010-06-08 00:42:01 +0200 (Tue, 08 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc
   M /trunk/src/webkit/appcache/appcache_disk_cache.cc
   M /trunk/src/webkit/appcache/appcache_disk_cache.h
   M /trunk/src/webkit/appcache/appcache_service.cc
   M /trunk/src/webkit/appcache/appcache_service.h
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl.h
   M /trunk/src/webkit/appcache/appcache_storage_impl_unittest.cc
   M /trunk/src/webkit/appcache/appcache_thread.cc
   M /trunk/src/webkit/appcache/appcache_thread.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.h
   A /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.cc (from /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h:48989)
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

AppCache: Use a dedicated thread for the disk cache.

BUG=26730
TEST=current tests


Review URL: http://codereview.chromium.org/2249005
------------------------------------------------------------------------
r49108 | georgey@chromium.org | 2010-06-08 00:29:24 +0200 (Tue, 08 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   M /trunk/src/chrome/browser/autofill/contact_info.h
   A /trunk/src/chrome/browser/autofill/contact_info_unittest.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/chrome_tests.gypi

Adjusted icons, control sizes, etc.
BUG=44622
TEST=in the bug
Review URL: http://codereview.chromium.org/2638003
------------------------------------------------------------------------
r49105 | dhg@chromium.org | 2010-06-08 00:21:05 +0200 (Tue, 08 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc

Fixing system so that it only closes open file browsers that currently point at the directories on that device.

BUG=chromium-os:3468
TEST=none
Review URL: http://codereview.chromium.org/2639004
------------------------------------------------------------------------
r49099 | scherkus@chromium.org | 2010-06-08 00:02:39 +0200 (Tue, 08 Jun 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/audio_handler.cc
   A /trunk/src/chrome/browser/chromeos/audio_handler.h
   A /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.cc
   A /trunk/src/chrome/browser/chromeos/pulse_audio_mixer.h
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.cc
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.h
   M /trunk/src/chrome/chrome_browser.gypi

Using PulseAudio for volume and mute key handling.

Patch by davej@chromium.org:
http://codereview.chromium.org/2285004/show

BUG=none
TEST=none
------------------------------------------------------------------------
r49093 | ananta@chromium.org | 2010-06-07 23:40:29 +0200 (Mon, 07 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/test/data/chrome_frame_window_open.html
   M /trunk/src/chrome_frame/test/test_mock_with_web_server.cc

Add Support for window.close in ChromeFrame. Currently the CloseContents notification on the TabContentsDelegate which
the ExternalTabContainer implements is ignored if the window close is not initiated from the host. 

Fix is to send over an automation message AutomationMsg_CloseExternalTab to the external host where we close the window.
Currently this functionality is only provided by the active document.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=45930

Bug=45930
Test=Covered by chrome frame unit test FullTabModeIE_WindowCloseInChrome

Review URL: http://codereview.chromium.org/2691004
------------------------------------------------------------------------
r49082 | zelidrag@chromium.org | 2010-06-07 21:17:35 +0200 (Mon, 07 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/resources/about_sys.html

Checking in http://codereview.chromium.org/2605005 on behalf of tbarzic@chromium.org:

Implemented functionality for viewing chromeOS system status


BUG=chromium-os:3807
TEST=type in about:system in the browser and system status page should appear
Review URL: http://codereview.chromium.org/2698003
------------------------------------------------------------------------
r49079 | hclam@chromium.org | 2010-06-07 21:06:49 +0200 (Mon, 07 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   A /trunk/src/media/audio/audio_controller.cc
   A /trunk/src/media/audio/audio_controller.h
   A /trunk/src/media/audio/audio_controller_unittest.cc
   M /trunk/src/media/audio/simple_sources.cc
   M /trunk/src/media/audio/simple_sources.h
   M /trunk/src/media/media.gyp

AudioController to perform audio operations on a separate thread

Added AudioController as a wrapper over AudioOutputStream to operate methods of
AudioOutputStream on a separate thread managed by AudioController. This way most
of the audio operations will be non-blocking.

Next step is to modify AudioRendererHost to use AudioController.

TEST=media_unittests --gtest_filter=AudioControllerTest.*
BUG=39885

Review URL: http://codereview.chromium.org/2477005
------------------------------------------------------------------------
r49078 | hclam@chromium.org | 2010-06-07 21:03:19 +0200 (Mon, 07 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/pepper_devices.cc

Fix audio "clicking" for strongbad demo

The strongbad demo plays an audio file of 11kHz. However we hardcoded
in the AudioRendererHost to always open an audio device of 8k samples
which happens to be too big for streams of 11khz. This makes the IPC
transport packet size much smaller than the hardware buffer size and
hardware packet is always partially filled.

This change allow the AudioRendererHost to designate the transport
packet size based on the hardware packet size. The hardware packet
size is now adjusted based on the sample rate.

BUG=46007
TEST=http://smokescreen.us/demos/sb45demo.html
The above audio plays fine.

Review URL: http://codereview.chromium.org/2651001
------------------------------------------------------------------------
r49072 | rsesek@chromium.org | 2010-06-07 19:48:35 +0200 (Mon, 07 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Hook up the "Reset to Defaults" button in Under the Hood preferences.

BUG=45660
TEST=Chromium-->Preferences-->Under the Hood. Uncheck any one of the checkboxes. Click Reset to Defaults. Previous value gets restored.

Review URL: http://codereview.chromium.org/2702003
------------------------------------------------------------------------
r49071 | albertb@chromium.org | 2010-06-07 19:46:12 +0200 (Mon, 07 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/nigori.cc
   M /trunk/src/chrome/browser/sync/util/nigori.h

Make Nigori method const and keep track of key parameters.

BUG=none
TEST=NigoriTest

Review URL: http://codereview.chromium.org/2637003
------------------------------------------------------------------------
r49068 | oshima@chromium.org | 2010-06-07 19:14:23 +0200 (Mon, 07 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/message_bubble.cc
   M /trunk/src/chrome/browser/chromeos/login/message_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

MessageBubble which does not require separate window and does not grab input on mouse press event.
 * Added new constructor to InfoBubble for chromeos which takes WidgetGtk::Type parameter
 * Made DoGrab/HandleGrabBroke so that subclass can customize its behavior.
 * Added MessageBubble::ShowNoGrab that shows a child MessageBubble which does not grab input on mouse press event.
 * Explicitly remove accelerator when closed. This is necessary for child, but doing for all case as it's harmless to do so.
 * Moved HandleGrabBroke to protected and made virtual so that sub class
   can trap the event. ScreenLocker will use this event to detect this.

This will be used for screen locker.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2682004
------------------------------------------------------------------------
r49065 | xiyuan@chromium.org | 2010-06-07 18:44:39 +0200 (Mon, 07 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc

Fix content settings window not showing up from info bubble link.

BUG=chromium-os:3791
TEST=Verify fix for chromium-os:3791

Review URL: http://codereview.chromium.org/2679002
------------------------------------------------------------------------
r49064 | denisromanov@chromium.org | 2010-06-07 18:40:55 +0200 (Mon, 07 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/customization_document.cc
   M /trunk/src/chrome/browser/chromeos/customization_document.h
   M /trunk/src/chrome/browser/chromeos/customization_document_unittest.cc
   A /trunk/src/chrome/browser/chromeos/testdata/services_manifest.json

Added implementation of partner services manifest parsing, unit test and sample manifest.

BUG=cros:3176
TEST=Run out/Debug/unit_tests

Review URL: http://codereview.chromium.org/2632004
------------------------------------------------------------------------
r49060 | joth@chromium.org | 2010-06-07 17:40:14 +0200 (Mon, 07 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   M /trunk/src/chrome/common/geoposition.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/geolocation_dispatcher.cc
   M /trunk/src/chrome/renderer/geolocation_dispatcher.h

Some simplifications, as a pre-step to http://crbug.com/40103
- simplify the y geolocation IPC protocol, by using the error code already in Geoposition
- convert Geoposition's error_message to UTF8 as this is easier alround
- simplify the dispatcher host render id set (as the process_id part is implicit from the dispatcher host instance)

BUG=40103
TEST=unit_tests --gtest_filter=*Geol*

Review URL: http://codereview.chromium.org/2648002
------------------------------------------------------------------------
r49057 | ziadh@chromium.org | 2010-06-07 17:12:59 +0200 (Mon, 07 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_network_transaction.cc

Experiment for number of persistent connections to server

Currently Chrome, Firefox, and IE8 have the number of outgoing connections to each host(server) set at 6.
 Safari uses 4, and Fasterfox (a plugin for Firefox that supposedly
 configures it to run faster) uses 8. We would like to see how much of an
 effect this value has on browsing. Too large a value might cause us to
 run into SYN flood detection mechanisms. This experiment assigns a value of (4, 6, 8, 16) at random at program launch, and uses it throughout the run.

r=jar


Review URL: http://codereview.chromium.org/2685005
------------------------------------------------------------------------
r49054 | yurys@chromium.org | 2010-06-07 16:25:33 +0200 (Mon, 07 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Do not use key expansion when saving inspector settings.

Review URL: http://codereview.chromium.org/2667003
------------------------------------------------------------------------
r49053 | yurys@chromium.org | 2010-06-07 16:18:53 +0200 (Mon, 07 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Inspector settings are now cleared before testScriptsTabIsPopulatedOnInspectedPageRefresh.

Review URL: http://codereview.chromium.org/2420003
------------------------------------------------------------------------
r49051 | cira@chromium.org | 2010-06-07 16:00:47 +0200 (Mon, 07 Jun 2010) | 36 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc

It seems all RenderView tests have issues. I'll try reverting last significant RenderView change and see if that helps.

Revert 49046 - Disable RenderViewTest.ExtensionMessages* since they consistently crash localy and on the bots.

Code in question didn't change recently (9months) so it is possible it's a WebKit problem.

You need to run all tests to get the crash. Running with --gtest_filter=RenderViewTest.* passes.

There is a possible namespace clash with other RenderViewTest class.

Stack trace:
\src\third_party\WebKit\WebCore\platform\TreeShared.h:38 WebCore::TreeShared<class WebCore::Node>::TreeShared)
Backtrace:
        WebCore::TreeShared<WebCore::Node>::TreeShared<WebCore::Node> [0x03AE8EBA+90] (d:\chromium2\src\third_party\webkit\webcore\platform\treeshared.h:38)
        WebCore::Node::Node [0x03AD4011+49] (d:\chromium2\src\third_party\webkit\webcore\dom\document.h:1280)
        WebCore::ContainerNode::ContainerNode [0x03AD3D7E+30] (d:\chromium2\src\third_party\webkit\webcore\dom\containernode.h:107)
        WebCore::Document::Document [0x03AD331A+42] (d:\chromium2\src\third_party\webkit\webcore\dom\document.cpp:403)
        WebCore::HTMLDocument::HTMLDocument [0x03DDF76E+30] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.cpp:86)
        WebCore::HTMLDocument::create [0x03E522B6+54] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.h:40)
        WebCore::DOMImplementation::createDocument [0x03E52360+112] (d:\chromium2\src\third_party\webkit\webcore\dom\domimplementation.cpp:312)
        WebCore::DocumentWriter::createDocument [0x03B9B008+280] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:88)
        WebCore::DocumentWriter::begin [0x03B9B214+52] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:99)
        WebCore::FrameLoader::init [0x03B77539+441] (d:\chromium2\src\third_party\webkit\webcore\loader\frameloader.cpp:251)
        WebCore::Frame::init [0x026D4FB9+25] (d:\chromium2\src\third_party\webkit\webcore\page\frame.h:370)
        WebKit::WebFrameImpl::initializeAsMainFrame [0x026D4EE6+118] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webframeimpl.cpp:1712)
        WebKit::WebViewImpl::initializeMainFrame [0x0270D1D1+81] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webviewimpl.cpp:209)
        RenderView::Init [0x02BB1C04+660] (d:\chromium2\src\chrome\renderer\render_view.cc:533)
        RenderView::Create [0x02BB14CB+267] (d:\chromium2\src\chrome\renderer\render_view.cc:479)
        RenderViewTest::SetUp [0x01329E49+841] (d:\chromium2\src\chrome\test\render_view_test.cc:111)
        testing::Test::Run [0x02A47DC3+163] (d:\chromium2\src\testing\gtest\src\gtest.cc:2060)
        testing::internal::TestInfoImpl::Run [0x02A48B03+339] (d:\chromium2\src\testing\gtest\src\gtest.cc:2318


TBR=cira@chromium.org

Review URL: http://codereview.chromium.org/2698005
------------------------------------------------------------------------
r49048 | mnissler@chromium.org | 2010-06-07 15:13:28 +0200 (Mon, 07 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/dummy_pref_store.cc
   M /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   A /trunk/src/chrome/browser/pref_value_store.cc
   A /trunk/src/chrome/browser/pref_value_store.h
   A /trunk/src/chrome/browser/pref_value_store_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Support multiple PrefStores

Add interface for multi_pref_store_manager.

BUG=40259
TEST=Unittests in pref_service_unittest.cc, pref_value_store_unittest.cc

Review URL: http://codereview.chromium.org/1957005
Patch from Markus Heintz <markusheintz@google.com>.
------------------------------------------------------------------------
r49046 | cira@chromium.org | 2010-06-07 14:50:00 +0200 (Mon, 07 Jun 2010) | 32 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc

Disable RenderViewTest.ExtensionMessages* since they consistently crash localy and on the bots.

Code in question didn't change recently (9months) so it is possible it's a WebKit problem.

You need to run all tests to get the crash. Running with --gtest_filter=RenderViewTest.* passes.

There is a possible namespace clash with other RenderViewTest class.

Stack trace:
\src\third_party\WebKit\WebCore\platform\TreeShared.h:38 WebCore::TreeShared<class WebCore::Node>::TreeShared)
Backtrace:
        WebCore::TreeShared<WebCore::Node>::TreeShared<WebCore::Node> [0x03AE8EBA+90] (d:\chromium2\src\third_party\webkit\webcore\platform\treeshared.h:38)
        WebCore::Node::Node [0x03AD4011+49] (d:\chromium2\src\third_party\webkit\webcore\dom\document.h:1280)
        WebCore::ContainerNode::ContainerNode [0x03AD3D7E+30] (d:\chromium2\src\third_party\webkit\webcore\dom\containernode.h:107)
        WebCore::Document::Document [0x03AD331A+42] (d:\chromium2\src\third_party\webkit\webcore\dom\document.cpp:403)
        WebCore::HTMLDocument::HTMLDocument [0x03DDF76E+30] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.cpp:86)
        WebCore::HTMLDocument::create [0x03E522B6+54] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.h:40)
        WebCore::DOMImplementation::createDocument [0x03E52360+112] (d:\chromium2\src\third_party\webkit\webcore\dom\domimplementation.cpp:312)
        WebCore::DocumentWriter::createDocument [0x03B9B008+280] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:88)
        WebCore::DocumentWriter::begin [0x03B9B214+52] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:99)
        WebCore::FrameLoader::init [0x03B77539+441] (d:\chromium2\src\third_party\webkit\webcore\loader\frameloader.cpp:251)
        WebCore::Frame::init [0x026D4FB9+25] (d:\chromium2\src\third_party\webkit\webcore\page\frame.h:370)
        WebKit::WebFrameImpl::initializeAsMainFrame [0x026D4EE6+118] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webframeimpl.cpp:1712)
        WebKit::WebViewImpl::initializeMainFrame [0x0270D1D1+81] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webviewimpl.cpp:209)
        RenderView::Init [0x02BB1C04+660] (d:\chromium2\src\chrome\renderer\render_view.cc:533)
        RenderView::Create [0x02BB14CB+267] (d:\chromium2\src\chrome\renderer\render_view.cc:479)
        RenderViewTest::SetUp [0x01329E49+841] (d:\chromium2\src\chrome\test\render_view_test.cc:111)
        testing::Test::Run [0x02A47DC3+163] (d:\chromium2\src\testing\gtest\src\gtest.cc:2060)
        testing::internal::TestInfoImpl::Run [0x02A48B03+339] (d:\chromium2\src\testing\gtest\src\gtest.cc:2318

TBR=aa,mpcomplete,senorblanco

------------------------------------------------------------------------
r49042 | yusukes@google.com | 2010-06-07 11:10:31 +0200 (Mon, 07 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_util.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add the remaining Enum types of Mozc configs.

The original patch was written by mazda@chromium.org.
http://codereview.chromium.org/2453003/show

BUG=chromium-os:2625
TEST=manual

Review URL: http://codereview.chromium.org/2453003
------------------------------------------------------------------------
r49038 | yusukes@google.com | 2010-06-07 08:49:23 +0200 (Mon, 07 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Allow users to change current input method even when no text input area is focused.

This change does not work without the corresponding libcros change:
http://codereview.chromium.org/2619005

BUG=chromium-os:3679
TEST=manual

Review URL: http://codereview.chromium.org/2704003
------------------------------------------------------------------------
r49037 | satorux@chromium.org | 2010-06-07 07:58:37 +0200 (Mon, 07 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc

Reorder input methods based on language code.

For instance, if the language code is "fr" (French),
we should list French keyboard first rather than
Belgian keyboard.

BUG=chromium-os:3822
TEST=wrote unit tests. also tested on the netbook.

Review URL: http://codereview.chromium.org/2692002
------------------------------------------------------------------------
r49036 | chocobo@chromium.org | 2010-06-07 07:39:14 +0200 (Mon, 07 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_message_observer.cc
   M /trunk/src/chrome/browser/chromeos/network_message_observer.h

Turn off network connection failure notification.
TBR=oshima
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2635008
------------------------------------------------------------------------
r49034 | jhawkins@chromium.org | 2010-06-07 04:44:06 +0200 (Mon, 07 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc

Really disable the test.

TBR=ananta
BUG=45977
TEST=none

Review URL: http://codereview.chromium.org/2704001
------------------------------------------------------------------------
r49033 | jhawkins@chromium.org | 2010-06-07 04:35:58 +0200 (Mon, 07 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc

Disable TabRestoreServiceTest.DontPersistPostData as it is crashing on Windows.

TBR=ananta
BUG=45977
TEST=none

Review URL: http://codereview.chromium.org/2664005
------------------------------------------------------------------------
r49031 | ananta@chromium.org | 2010-06-07 03:51:16 +0200 (Mon, 07 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.h

Ensure that the context menu items displayed in ChromeFrame rendered pages are enabled/disabled correctly. To achieve this we now
have a UpdateMenuItemStates function in the RenderViewContextMenuViews class which calls into the underlying menu's UpdateStates
function which enables/disables items correctly.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=45785

Bug=45785

Review URL: http://codereview.chromium.org/2627005
------------------------------------------------------------------------
r49030 | jhawkins@chromium.org | 2010-06-07 03:51:14 +0200 (Mon, 07 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   A /trunk/src/chrome/browser/autocomplete_history_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill: Don't save credit card numbers from Autocomplete to the WebDB.

BUG=8026
TEST=AutocompleteHistoryManagerTest

Review URL: http://codereview.chromium.org/2676003
------------------------------------------------------------------------
r49029 | zork@chromium.org | 2010-06-07 03:25:44 +0200 (Mon, 07 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_util.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Update combo boxes to use a template system
Add chewing hsu selection key type
Add pinyin Double Pinyin Schema box

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2565002
------------------------------------------------------------------------
r49024 | tfarina@chromium.org | 2010-06-06 15:32:27 +0200 (Sun, 06 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/cross_site_request_manager.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_file.h
   M /trunk/src/chrome/browser/download/save_item.h
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/visit_tracker.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_response.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/page_state.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.h
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/common/net/url_fetcher.h
   M /trunk/src/chrome/installer/util/install_util.h
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/about_handler.h
   M /trunk/src/chrome/renderer/net/render_dns_master.h
   M /trunk/src/chrome/renderer/net/render_dns_queue.h
   M /trunk/src/chrome/renderer/net/render_dns_queue_unittest.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_handle_tracker.h
   M /trunk/src/chrome/test/file_test_utils.h
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_util.h
   M /trunk/src/chrome/tools/crash_service/crash_service.h

Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome directory.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2657003
------------------------------------------------------------------------
r49016 | aa@chromium.org | 2010-06-06 06:49:53 +0200 (Sun, 06 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h

Add a context menu item to toggle app tab toolbars.

Review URL: http://codereview.chromium.org/2690001
------------------------------------------------------------------------
r49004 | viettrungluu@chromium.org | 2010-06-05 08:46:31 +0200 (Sat, 05 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/mach_broker_mac.h

Whitespace change to trigger bots.

TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/2670004
------------------------------------------------------------------------
r49003 | viettrungluu@chromium.org | 2010-06-05 07:56:21 +0200 (Sat, 05 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   D /trunk/src/chrome/browser/plugin_updater.cc
   D /trunk/src/chrome/browser/plugin_updater.h
   D /trunk/src/chrome/browser/plugin_updater_unittest.cc
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 48997 [causes Windows unit_tests to hang] - Group plugins in about:plugins and show update link for out-of-date ones.

Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.

Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.

BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.

Review URL: http://codereview.chromium.org/2686001

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2652002
------------------------------------------------------------------------
r49002 | viettrungluu@chromium.org | 2010-06-05 07:25:04 +0200 (Sat, 05 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/draggable_button.mm
   M /trunk/src/chrome/browser/cocoa/draggable_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller_unittest.mm

Whitespace change to trigger bots.

TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/2689005
------------------------------------------------------------------------
r48997 | viettrungluu@chromium.org | 2010-06-05 04:55:45 +0200 (Sat, 05 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   A /trunk/src/chrome/browser/plugin_updater.cc
   A /trunk/src/chrome/browser/plugin_updater.h
   A /trunk/src/chrome/browser/plugin_updater_unittest.cc
   M /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Group plugins in about:plugins and show update link for out-of-date ones.

Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.

Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.

BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.

Review URL: http://codereview.chromium.org/2686001
------------------------------------------------------------------------
r48996 | mdm@chromium.org | 2010-06-05 04:50:51 +0200 (Sat, 05 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_gnome.cc

Linux: make GNOME keyring password store able to use libgnome-keyring via dlopen. The GNOME keyring password store is still disabled.
BUG=25404
TEST=gnome keyring password store can be loaded with dlopen

Review URL: http://codereview.chromium.org/2696002
------------------------------------------------------------------------
r48994 | mlloyd@chromium.org | 2010-06-05 03:27:34 +0200 (Sat, 05 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/extensions/v8/benchmarking_extension.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/support/webkit_support_glue.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Actually clear the disk cache, and keep it enabled, between benchmark runs.

Fixes a small TODO in the benchmarking extension. Keep the disk cache
turned on during benchmarking, and doom all entries between benchmark
runs, rather than disabling it entirely.

BUG=none
TEST=All tests pass.

Review URL: http://codereview.chromium.org/669115
------------------------------------------------------------------------
r48993 | johnnyg@chromium.org | 2010-06-05 03:14:03 +0200 (Sat, 05 Jun 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/balloon_wrench.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h

Change the Windows UI for notifications one more time.  All controls at the top.  No more scrollbar overlap.  Wrench icon for the options menu.

BUG=44389
TEST=create large notification with scrollbar

Review URL: http://codereview.chromium.org/2633001
------------------------------------------------------------------------
r48990 | oshima@chromium.org | 2010-06-05 02:58:06 +0200 (Sat, 05 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host_win.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/examples/widget_example.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Add cross platform Widget::InitWithWidget(parent, const gfx::Rect& bounds);

On linux, native parent has to be either window_contents or widget depending of the type of wiget. InitWithWidget takes a parent Widget instead of native and hides these details.

I also cleaned up a few dead/duplicated code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2355003
------------------------------------------------------------------------
r48987 | dhg@chromium.org | 2010-06-05 01:01:20 +0200 (Sat, 05 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.h
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/platform_util_chromeos.cc

Adding reporting of parent browser's id, so that we can open up next to that browser if wanted.

BUG=chromium-os:3711
TEST=none
Review URL: http://codereview.chromium.org/2640002
------------------------------------------------------------------------
r48985 | dhg@chromium.org | 2010-06-05 00:26:37 +0200 (Sat, 05 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html
   A /trunk/src/chrome/browser/resources/media_common.js
   M /trunk/src/chrome/browser/resources/mediaplayer.html

Adding support for .mov.  We might have to remove this later if we find that too many are not h.264.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2622002
------------------------------------------------------------------------
r48984 | finnur@chromium.org | 2010-06-05 00:26:01 +0200 (Sat, 05 Jun 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_state.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Fix: Clearing search 'foo', closing and reopening Find
should not prepopulate with 'foo'.

We need to reset the remembered values when the user
clears the search term from the Find box to prevent
them from showing up on close+Reopen and on close+F3.

Added test to cover these cases.

This change also makes sure we don't clear the Find
string when we don't need to, which was happening on
close of the Find box and on new tab, causing the
fix not to work.

BUG=42639
TEST=Covered by new automated test.
Review URL: http://codereview.chromium.org/2322006
------------------------------------------------------------------------
r48983 | mdm@chromium.org | 2010-06-05 00:21:13 +0200 (Sat, 05 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_gnome.cc
   M /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   M /trunk/src/chrome/browser/password_manager/password_store_kwallet.cc
   M /trunk/src/chrome/browser/password_manager/password_store_kwallet.h

Linux: bring GNOME Keyring and KWallet integration back into a compilable state. Still disabled, however.
BUG=12351,25404
TEST=both now seem to work correctly when enabled (but this CL does not enable them)

Review URL: http://codereview.chromium.org/2407001
------------------------------------------------------------------------
r48981 | lzheng@chromium.org | 2010-06-05 00:11:42 +0200 (Sat, 05 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Enable 25% of the users use npn_with_spdy when possible, 
another 25% use npn_with_http to compare performance.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2683001
------------------------------------------------------------------------
r48979 | dantasse@chromium.org | 2010-06-05 00:05:33 +0200 (Sat, 05 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

Change the signin button to a submit button, so that when you fill in the username/password, then press enter, it'll have the same effect as if you clicked "sign in."

BUG:43224
TEST: Wrench->set up sync. Enter a valid username and password.  Press enter.  It should sign you in and start syncing.

Review URL: http://codereview.chromium.org/2687001
------------------------------------------------------------------------
r48974 | arv@chromium.org | 2010-06-04 23:41:43 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Bookmarks: Make sure that middle click to open works instead of autoscroll.

BUG=40924
TEST=Go to a bookmark folder in the bookmarks manager where the list has a vertical scrollbar. Middle clicking on a bookmark should open the bookmark in a background tab.

Review URL: http://codereview.chromium.org/2658004
------------------------------------------------------------------------
r48973 | sky@chromium.org | 2010-06-04 23:16:10 +0200 (Fri, 04 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc

Fixes linux browser_test do to adding new id.

BUG=44642
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/2683002
------------------------------------------------------------------------
r48972 | thakis@chromium.org | 2010-06-04 23:13:03 +0200 (Fri, 04 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view_picker_table_unittest.mm

Mac: Fix memory leak in test.

Review URL: http://codereview.chromium.org/2689001
------------------------------------------------------------------------
r48970 | sky@chromium.org | 2010-06-04 22:44:39 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Adds some logging in hopes of tracking down a crasher.

BUG=44642
TEST=none

Review URL: http://codereview.chromium.org/2629002
------------------------------------------------------------------------
r48969 | stuartmorgan@chromium.org | 2010-06-04 22:44:31 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

Switching a failing find bar test from DISABLED_ to FAILS_

BUG=22306
TEST=FindInPageControllerTest.FindMovesWhenObscuring should run (but fail) on the Mac.

Review URL: http://codereview.chromium.org/2623004
------------------------------------------------------------------------
r48965 | avi@chromium.org | 2010-06-04 22:12:06 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.h

Fix comment typo.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2631004
------------------------------------------------------------------------
r48964 | rsesek@chromium.org | 2010-06-04 22:08:21 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm

[Mac] Disable menu certain menu items when a modal dialog or sheet is present.

BUG=28755,41818
TEST=Chromium-->Clear Browsing Data. Cannot open NTP. Cannot open bookmark manager. Cannot open history.

Review URL: http://codereview.chromium.org/2605006
------------------------------------------------------------------------
r48963 | xiyuan@chromium.org | 2010-06-04 21:38:29 +0200 (Fri, 04 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

Fix autofill dialog not reshowing problem.

This is because NativeDialogHost sends GTK_RESPONSE_DELETE_EVENT and autofill dialog does not handle it.

BUG=chromium-os:3816
TEST=Verify fix for chromium-os:3816.

Review URL: http://codereview.chromium.org/2655004
------------------------------------------------------------------------
r48962 | pinkerton@chromium.org | 2010-06-04 21:07:12 +0200 (Fri, 04 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/clipboard/clipboard_mac.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   M /trunk/src/third_party/mozilla/NSPasteboard+Utils.h
   M /trunk/src/third_party/mozilla/NSPasteboard+Utils.mm
   M /trunk/src/third_party/mozilla/README.chromium

Convert RTF on the pasteboard to HTML and all it to substitute if present and no HTML is on a paste or drop. Safari does not put HTML on the pasteboard, only RTF.
BUG=44661
TEST=dropping/pasting html should retain basic structure, but fonts/colors don't seem to propagate.
Review URL: http://codereview.chromium.org/2674002
------------------------------------------------------------------------
r48956 | thakis@chromium.org | 2010-06-04 20:35:35 +0200 (Fri, 04 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   A /trunk/src/chrome/browser/cocoa/tab_view_picker_table.h
   A /trunk/src/chrome/browser/cocoa/tab_view_picker_table.mm
   A /trunk/src/chrome/browser/cocoa/tab_view_picker_table_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Change content settings from showing tabs on top to showing a list on the side.

xib changes:
* Set NSTabView's style to "Tabless" (but kept panes in an NSTabView, since it's a convenient method to handle multiple overlapping views in IB)
* Put NSTabView into a split view, put a table view in the other split pane of the split view, gave it class TabViewSwitcherTable
* changed autosize flags of all child views of the tab view items
* Made the NSTabView the tabView_ of the table view

BUG=45546
TEST=Content settings window should still work. If it's opened through an omnibox bubble, the right section should still be autoselected.

Review URL: http://codereview.chromium.org/2534001
------------------------------------------------------------------------
r48954 | shess@chromium.org | 2010-06-04 20:21:12 +0200 (Fri, 04 Jun 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/image_utils.h
   A /trunk/src/chrome/browser/cocoa/image_utils.mm
   A /trunk/src/chrome/browser/cocoa/image_utils_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Image-drawing which doesn't require image-flipping.

Snow Leopard deprecated -[NSImage setFlipped:] for good reasons.  This
implements a method similar to the new
-[NSImage drawInRect:*:respectFlipped:] method, which allows images to
be drawn so that they always look right visually regardless of the
-isFlipped status of the view being drawn.

BUG=38943
TEST=Autocomplete, download, and reload button look right.

Review URL: http://codereview.chromium.org/2587003
------------------------------------------------------------------------
r48951 | jhawkins@chromium.org | 2010-06-04 20:13:32 +0200 (Fri, 04 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Make SSLUITest.TestUnauthenticatedFramNavigation flaky for mac and linux, disabled for windows.

Contributed by tessamac@chromium.org

BUG=43437
TEST=none

Review URL: http://codereview.chromium.org/2536001
------------------------------------------------------------------------
r48950 | tfarina@chromium.org | 2010-06-04 20:12:42 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Cleanup: Remove some obsolete bookmark manager preferences.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2631001
------------------------------------------------------------------------
r48949 | sky@chromium.org | 2010-06-04 20:02:58 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Fixes layout of side tabs on windows.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2608002
------------------------------------------------------------------------
r48947 | zelidrag@chromium.org | 2010-06-04 20:02:05 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc

Added final issue categories to feedback dialog for ChromeOS.

BUG=chromium-os:3564
TEST=open the feedback/bug report dialog, check the new values in the dropdown

Review URL: http://codereview.chromium.org/2553002
------------------------------------------------------------------------
r48946 | xiyuan@chromium.org | 2010-06-04 20:00:41 +0200 (Fri, 04 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc

Make "Clear Browser Data" dialog wider for ja.

The fix is to use the size constraint as min size and let Gtk make us wider when necessary.

BUG=chromium-os:3763
TEST=Verify no button truncation in "Clear Browser Data" as in chromium-os:3763.

Review URL: http://codereview.chromium.org/2598002
------------------------------------------------------------------------
r48942 | shess@chromium.org | 2010-06-04 19:24:03 +0200 (Fri, 04 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

[Mac] Revert: Enable zombies for all on devchannel.

Reverts r48933, which broke the Mac Perf(2) bot.  The original CL's
review URL: http://codereview.chromium.org/2627001

TBR=avi
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2629003
------------------------------------------------------------------------
r48941 | skrul@chromium.org | 2010-06-04 19:22:23 +0200 (Fri, 04 Jun 2010) | 12 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   D /trunk/src/chrome/browser/sync/glue/preference_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert 48932 - Merge certain preferences during model association.
Previously, local preference values would always be clobbered by values in the cloud during model association.  This change defines a list of preferences where we will merge the local value and cloud value at association time.

Also, sync nodes are no longer created during model association when the local preference has a default value.  This also required changes in the change processor since it is not possible for a change to come from the cloud as an "add" (rather than always "updates") since a new preference sync node can be created at run time.

Finally, this change includes the first steps into creating a base class for all of the ProfileSyncService* unit tests.  The autofill and preference unit tests have been refactored to use this base class.

BUG=44772,40129

Review URL: http://codereview.chromium.org/2473004

TBR=skrul@chromium.org
------------------------------------------------------------------------
r48938 | arv@chromium.org | 2010-06-04 18:54:42 +0200 (Fri, 04 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm.js

Bookmarks: Fix a script error when deleting multiple folders.

When deleting multiple folders we get callback after each remove and this can trigger a selection change which in turn triggers a call to getSubtree for a folder that was just removed. When this happens we finish the Promise with the value undefined.

BUG=None
TEST=Create two folders and select both. Hit Delete and check that we do not get a script error. (We still get an error from the extension API that the id no longer exists but at least we do not keel over.

Review URL: http://codereview.chromium.org/2647001
------------------------------------------------------------------------
r48935 | scottbyer@chromium.org | 2010-06-04 18:35:58 +0200 (Fri, 04 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc
   A /trunk/src/chrome/test/data/printing/cloud_print_unittest.pdf

Re-enable test, add in test detail.
Add in asked-for test of getting the title through, found text-only PDF file for that test, re-enabled it.

BUG=none
TEST=CloudPrintDataSenderTest.CanSend

Review URL: http://codereview.chromium.org/2590002
------------------------------------------------------------------------
r48933 | shess@chromium.org | 2010-06-04 18:23:34 +0200 (Fri, 04 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

[Mac] Enable zombies for all on devchannel.

Attempt to flush out more use-after-free cases in the wild. Right now
messages to freed ObjC objects are binned by the object's address,
with this change they should aggregate into a bigger bin.

BUG=35590, 24987, 45676
TEST=none

Review URL: http://codereview.chromium.org/2627001
------------------------------------------------------------------------
r48932 | skrul@chromium.org | 2010-06-04 18:14:19 +0200 (Fri, 04 Jun 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/preference_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Merge certain preferences during model association.
Previously, local preference values would always be clobbered by values in the cloud during model association.  This change defines a list of preferences where we will merge the local value and cloud value at association time.

Also, sync nodes are no longer created during model association when the local preference has a default value.  This also required changes in the change processor since it is not possible for a change to come from the cloud as an "add" (rather than always "updates") since a new preference sync node can be created at run time.

Finally, this change includes the first steps into creating a base class for all of the ProfileSyncService* unit tests.  The autofill and preference unit tests have been refactored to use this base class.

BUG=44772,40129

Review URL: http://codereview.chromium.org/2473004
------------------------------------------------------------------------
r48930 | shess@chromium.org | 2010-06-04 18:12:57 +0200 (Fri, 04 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/objc_zombie.mm

[Mac] Make zombie-only mode a tiny bit more efficient.

Pull the test for zombie-only mode out of the lock.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2581003
------------------------------------------------------------------------
r48928 | mirandac@chromium.org | 2010-06-04 17:36:35 +0200 (Fri, 04 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   A /trunk/src/chrome/browser/importer/importer_messages.h
   A /trunk/src/chrome/browser/importer/importer_messages_internal.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc
   A /trunk/src/chrome/browser/profile_import_process_host.cc
   A /trunk/src/chrome/browser/profile_import_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   R /trunk/src/chrome/profile_import
   A /trunk/src/chrome/profile_import/DEPS
   A /trunk/src/chrome/profile_import/profile_import_main.cc (from /trunk/src/chrome/profile_import/profile_import_main.cc:47518)
   A /trunk/src/chrome/profile_import/profile_import_thread.cc (from /trunk/src/chrome/profile_import/profile_import_thread.cc:47518)
   A /trunk/src/chrome/profile_import/profile_import_thread.h (from /trunk/src/chrome/profile_import/profile_import_thread.h:47518)

Move import in Mac OS X into its own process.

BUG=18774
TEST=import still works.
Review URL: http://codereview.chromium.org/502045
------------------------------------------------------------------------
r48927 | glotov@chromium.org | 2010-06-04 17:22:08 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h

Update OOBE welcome screen based on latest mocks.

BUG=http://crosbug.com/3279
TEST=none

Review URL: http://codereview.chromium.org/2590001
------------------------------------------------------------------------
r48926 | joth@chromium.org | 2010-06-04 16:42:26 +0200 (Fri, 04 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.cc
   A /trunk/src/chrome/browser/geolocation/gps_location_provider_unittest_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_2_38_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_2_94_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.h
   M /trunk/src/chrome/chrome_tests.gypi

Add some basic Linux GPS tests.
Refactors the lib loader to be more of a dumb library wrapper, to avoid spreading knowledge of different library versions over multiple classes and to simplify testing.
Auto reconnect to gpsd after connection failure. Makes error handling consistent across Poll() and DataWaiting().

Review URL: http://codereview.chromium.org/2555002
------------------------------------------------------------------------
r48924 | thomasvl@chromium.org | 2010-06-04 16:39:53 +0200 (Fri, 04 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/base/third_party/dynamic_annotations
   M /trunk/src/chrome/browser/sync/protocol
   M /trunk/src/chrome/browser/sync/tools
   M /trunk/src/gpu/demos
   M /trunk/src/net/third_party/nss
   M /trunk/src/third_party/adobe/flash
   M /trunk/src/webkit/default_plugin
   M /trunk/src/webkit/support

Manual Code Review: More ignores for project files
------------------------------------------------------------------------
r48918 | avayvod@google.com | 2010-06-04 13:17:14 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Don't show image screen if we're in test mode.

BUG=none
TEST=Run Chrome with --login-manager and --login-screen=login. Verify that after login user image screen is not shown.

Review URL: http://codereview.chromium.org/2670001
------------------------------------------------------------------------
r48917 | dpolukhin@chromium.org | 2010-06-04 12:55:26 +0200 (Fri, 04 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Show guest login on images login screen.
Initial version further refactoring should remove login screen and ExistingUserController will be used for OOBE flow.

BUG=crosbug.com/2226
TEST=On Chromium OS try other user login, it should be on the same screen (it doesn't work with old window manager).

Review URL: http://codereview.chromium.org/2417006
------------------------------------------------------------------------
r48916 | avayvod@chromium.org | 2010-06-04 12:02:00 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_image_view.cc

Set selected user image instead of the last captured by camera.

BUG=none
TEST=Get to user image screen. Click on video image. Verify that selected image is what was on the video image. Put your thumb to the camera. Click OK. Verify that on login screen the picture of yourself is shown, not your thumb.

Review URL: http://codereview.chromium.org/2639002
------------------------------------------------------------------------
r48912 | bulach@chromium.org | 2010-06-04 11:56:47 +0200 (Fri, 04 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/test/data/geolocation/simple.html

Enables GeolocationBrowserTest.IFramesWithCachedPosition on mac.
Reason: Webkit has its own cache, and we also broadcast the position: this led to two alerts being displayed, which makes mac angry.

BUG=29424
TEST=GeolocationBrowserTest.IFramesWithCachedPosition

Review URL: http://codereview.chromium.org/2561004
------------------------------------------------------------------------
r48910 | tony@chromium.org | 2010-06-04 11:14:20 +0200 (Fri, 04 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/renderer/render_view.cc

Changed to tell draggin status to webkit. Also fixed mouse pointer coordinate
computation which originally assumed that source coordinate
as windows coordinate, but actually it was o screen coordinate.

This patch should wait for https://bugs.webkit.org/show_bug.cgi?id=39725.

BUG=37320
TEST=none

Original patch written by morrita@google.com
------------------------------------------------------------------------
r48906 | avayvod@chromium.org | 2010-06-04 10:27:11 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Restore browser launching logic for guest login.

BUG=none
TEST=Click "Browse without sign in" and verify that user image is not shown.

Review URL: http://codereview.chromium.org/2587001
------------------------------------------------------------------------
r48892 | asargent@chromium.org | 2010-06-04 01:20:49 +0200 (Fri, 04 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

Fix submenu support for extensions context menu API.

This fixes submenus which broke on all platforms during a recent refactor of
the RenderViewContextMenu class, and adds support for more than one level of
child menus.


BUG=39504
TEST=Create a test extension using the chrome.experimental.contextMenu API and
add multiple levels of child menu items.


Review URL: http://codereview.chromium.org/2443002
------------------------------------------------------------------------
r48889 | mpcomplete@chromium.org | 2010-06-04 00:54:43 +0200 (Fri, 04 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Disabled InstallApps while I fix the text on Linux.

BUG=41280

Review URL: http://codereview.chromium.org/2618002
------------------------------------------------------------------------
r48886 | mpcomplete@chromium.org | 2010-06-04 00:37:39 +0200 (Fri, 04 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/test/data/extensions/app1.crx
   A /trunk/src/chrome/test/data/extensions/app2.crx
   A /trunk/src/chrome/test/data/extensions/app3.crx

Prevent installation of an app if its web extent overlaps another installed app.

BUG=41280

Review URL: http://codereview.chromium.org/2469004
------------------------------------------------------------------------
r48885 | cira@chromium.org | 2010-06-04 00:34:26 +0200 (Fri, 04 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Remove BOM from js and css files in content script.

BUG=38152
TEST=Inject css file with BOM using an extension. It should be injected without BOM.

Review URL: http://codereview.chromium.org/2453005
------------------------------------------------------------------------
r48884 | erg@google.com | 2010-06-04 00:32:49 +0200 (Fri, 04 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

GTK: Repaint the toolbar after the bookmark bar has finished.

This issue has been here for forever (or at least as long as far back as the
bisect script will let me check).

BUG=44502
TEST=See bug.

Review URL: http://codereview.chromium.org/2616001
------------------------------------------------------------------------
r48883 | tfarina@chromium.org | 2010-06-04 00:26:12 +0200 (Fri, 04 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h

Wrap Sqlite utils functions into a sqlite_utils namespace.

Note: this was a TODO.

BUG=None
TEST=compiles

Review URL: http://codereview.chromium.org/2410002
------------------------------------------------------------------------
r48881 | eroman@chromium.org | 2010-06-04 00:13:56 +0200 (Fri, 04 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc

Address a TODO about renaming RequestInfo --> SourceInfo.

Review URL: http://codereview.chromium.org/2548003
------------------------------------------------------------------------
r48880 | dmuir@chromium.org | 2010-06-04 00:13:03 +0200 (Fri, 04 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

TTF: Fix and enable AppModalDialogTest on Mac.
Also remove FLAKY annotation from test for other platforms -- annotation is likely stale.

BUG=25039,5314
TEST=AutomationProxyTest.AppModalDialogTest

Review URL: http://codereview.chromium.org/2576002
------------------------------------------------------------------------
r48878 | mpcomplete@chromium.org | 2010-06-03 23:50:42 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h

Force web_origin to be present only on extension gallery installs. For
non-gallery installs, use the download URL as origin.

BUG=40848

Review URL: http://codereview.chromium.org/2517001
------------------------------------------------------------------------
r48876 | xiyuan@chromium.org | 2010-06-03 23:32:03 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Fix "under the hood" options page truncation.

BUG=chromium-os:3761
TEST=Verify fix for chromium-os:3761

Review URL: http://codereview.chromium.org/2600001
------------------------------------------------------------------------
r48875 | stuartmorgan@chromium.org | 2010-06-03 23:30:17 +0200 (Thu, 03 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/ui/sandbox_uitests.cc

Remove some test file complitation exceptions from chrome_tests.gypi

Adds bug annotation to the tests that still needs porting work.

BUG=45766,45753,45770,45771
TEST=Compling ui_tests still works

Review URL: http://codereview.chromium.org/2605001
------------------------------------------------------------------------
r48872 | mpcomplete@chromium.org | 2010-06-03 23:23:44 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fix a regression where tabs.create() would focus the tab's window even if
selected is false.

BUG=42531

Review URL: http://codereview.chromium.org/2483003
------------------------------------------------------------------------
r48871 | mattm@chromium.org | 2010-06-03 23:17:15 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/app_icon_win.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.h
   M /trunk/src/chrome/installer/util/shell_util.cc

Win SxS: Creating a new shortcut with enable-udd-profiles uses wrong icon.

BUG=44847
TEST=see bug

Review URL: http://codereview.chromium.org/2557001
------------------------------------------------------------------------
r48862 | shess@chromium.org | 2010-06-03 22:49:17 +0200 (Thu, 03 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

[Mac] Revert "Enable zombies for all on devchannel."

Is causing Perf(2) redness.

TBR=pink,avi
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2588002
------------------------------------------------------------------------
r48861 | jar@chromium.org | 2010-06-03 22:43:25 +0200 (Thu, 03 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/renderer/net/render_dns_master.cc

Fix a bunch of lint/style issues

r=willchan
Review URL: http://codereview.chromium.org/2113017
------------------------------------------------------------------------
r48858 | jhawkins@chromium.org | 2010-06-03 22:08:59 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

AutoFill: Make PersonalDataManager RefCountedThreadSafe.

BUG=40617
TEST=none

Review URL: http://codereview.chromium.org/2521001
------------------------------------------------------------------------
r48857 | shess@chromium.org | 2010-06-03 21:56:43 +0200 (Thu, 03 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/objc_zombie.mm

[Mac] Tighten up objc zombie dealloc implementation.

Enabling the zombie code in release causes Perf(2) to regress.
Reviewing |ZombieDealloc()|, I notice that object_setClass() is
implemented with a memory barrier.  The objc runtime doesn't use it in
deallocation, so move to direct access.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2605004
------------------------------------------------------------------------
r48855 | nkostylev@google.com | 2010-06-03 21:53:35 +0200 (Thu, 03 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h

On Chrome OS browse without sign in mode open only incognito windows.
As current implementation BWSI mode = "Incognito session" so only incognito windows should be open.

BUG= http://crosbug.com/3473
TEST=Open BWSI mode from "New user" screen. Ctrl+N/Shift+Ctrl+N should open only Incognito windows.

Review URL: http://codereview.chromium.org/2580001
------------------------------------------------------------------------
r48852 | mirandac@google.com | 2010-06-03 21:45:01 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc

Reusing the RegKey used to get the CurrentVersion to also get the Install Directory was causing an InvalidHandle exception, and causing FF import to fail.

BUG=45730
TEST= FF import should work.

Review URL: http://codereview.chromium.org/2581002
------------------------------------------------------------------------
r48849 | georgey@chromium.org | 2010-06-03 20:12:54 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/autofill/phone_number.cc
   M /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

New autofill UI. Still not done:
1. Countries ComboBox - need countries list.
2. Correct icons size.
TEST=in the mocks.
BUG=37816,39238,41232,41793,36601
Review URL: http://codereview.chromium.org/2500002
------------------------------------------------------------------------
r48845 | chocobo@chromium.org | 2010-06-03 19:42:37 +0200 (Thu, 03 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.h

Added scroll view to internet settings page.
Refreshing of networks will keep the scroll location.
BUG=chromium-os:3086
TEST=manually test to make sure scroll appears when the network list is long. and network changes keeps the same scroll location.
Review URL: http://codereview.chromium.org/2578002
------------------------------------------------------------------------
r48844 | rsesek@chromium.org | 2010-06-03 19:35:46 +0200 (Thu, 03 Jun 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h

[Mac] Make the History menu behave more like the NTP in its display of recently closed items.

Now, the menu will show Window entries that have a submenu of all the tabs. Currently, only
the complete window can be restored, not submenu items (representing individual tabs) as
this requires changing the TabRestoreService. That will come in a future CL.

This CL also significantly refactors the internals of the history menu.

XIB changes:
Re-assign tag values in the History menu to those used in HistoryMenuBridge::Tags enum.

BUG=43787
TEST=Open a window and navigate two tabs. Close window. In the History menu, there should be a "2 Tabs" item in the Recently Closed section. Select that to restore.
TEST=Open a window and navigate two tabs. Close one tab. In the History menu, there should be that individual tab entry. Select to restore.

Review URL: http://codereview.chromium.org/2481001
------------------------------------------------------------------------
r48841 | twiz@google.com | 2010-06-03 19:20:57 +0200 (Thu, 03 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_domui_popup_dismissal.html

A very basic fix that prevents experimental popups from living longer than the ExtensionFunctionDispatcher/RenderViewHost that launched the popup.  This is a problem, for example, when Chrome is closed while a popup is still displayed.

I also removed the code that delayed sending the onClosed popup notification.  I modified the ExtensionPopup::Obeserver interface to add methods for about-to-close, and fully-closed notifications.

BUG=None
TEST=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/2092020
------------------------------------------------------------------------
r48840 | csilv@chromium.org | 2010-06-03 19:15:22 +0200 (Thu, 03 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/platform_util_common_linux.cc
   M /trunk/src/chrome/browser/platform_util_mac.mm
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h

Changes to allow focusing the syncronization dialog, useful for the case where the user
chooses to sync, but the window is already open and obscured by another window.  For now
this only works on Mac due to how browser dialogs are handled on different platforms.

BUG=30649
TEST=Choose to 'Sync' when the sync window is already open behind a browser window.
Review URL: http://codereview.chromium.org/2121017
------------------------------------------------------------------------
r48838 | shess@chromium.org | 2010-06-03 18:53:28 +0200 (Thu, 03 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

[Mac] Enable zombies for all on devchannel.

Attempt to flush out more use-after-free cases in the wild.  Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin.  Additionally, the treadmill should slightly increase the number of cases caught.

BUG=35590,24987,45676
TEST=none

Review URL: http://codereview.chromium.org/2478004
------------------------------------------------------------------------
r48834 | tfarina@chromium.org | 2010-06-03 18:14:16 +0200 (Thu, 03 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Save/restore position for the preferences window based on prefs,

BUG=34644
TEST=Try moving the preferences window and confirm it works.

Patch from Mingmin Xie <melvinxie@gmail.com>

Review URL: http://codereview.chromium.org/2592001
------------------------------------------------------------------------
r48833 | scottbyer@chromium.org | 2010-06-03 18:06:56 +0200 (Thu, 03 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_internal.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc

Fix cloud print job title.
Use the page title as the print job title for cloud printing.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2438004
------------------------------------------------------------------------
r48831 | tfarina@chromium.org | 2010-06-03 16:49:44 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc

Close the translate infobar after selecting 'Never translate this language/site'.

BUG=39222
TEST=see bug

Review URL: http://codereview.chromium.org/2400001
------------------------------------------------------------------------
r48830 | avayvod@chromium.org | 2010-06-03 16:15:35 +0200 (Thu, 03 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

Quick fix: initializing member variable. Makes offline login work.

TBR=dpolukhin
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2564003
------------------------------------------------------------------------
r48828 | avayvod@chromium.org | 2010-06-03 15:00:40 +0200 (Thu, 03 Jun 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/camera.cc
   A /trunk/src/chrome/browser/chromeos/login/camera.h
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   A /trunk/src/chrome/browser/chromeos/login/user_image_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/user_image_screen.h
   A /trunk/src/chrome/browser/chromeos/login/user_image_view.cc
   A /trunk/src/chrome/browser/chromeos/login/user_image_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Added user image screen for new user login (or old user logging in through
new user screen). If user takes snapshot and hits OK on image screen, the
snapshot becomes user image. If user presses Cancel, his image is downloaded
via Contacts API.

BUG=cros:3175
TEST=Login via new user login window. Verify that both use cases work if you logout after the browser is shown.

Review URL: http://codereview.chromium.org/2578001
------------------------------------------------------------------------
r48827 | dpolukhin@chromium.org | 2010-06-03 14:45:52 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc

Fix crash on NetworkScreen when corresponding view was deleted.

BUG=crosbug.com/3757
TEST=none

Review URL: http://codereview.chromium.org/2575001
------------------------------------------------------------------------
r48822 | jorlow@chromium.org | 2010-06-03 12:15:01 +0200 (Thu, 03 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   A /trunk/src/chrome/renderer/renderer_webidbindex_impl.cc
   A /trunk/src/chrome/renderer/renderer_webidbindex_impl.h
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.h

Add IDBIndex support + various cleanup.

This adds IDBIndex support.  The majority of this CL was boilerplate type code in indexed_db_dispatcher_host so I did my best to factor it into template functions and split things into multiple sub-dispatcher hosts.

Review URL: http://codereview.chromium.org/2449005
------------------------------------------------------------------------
r48817 | zork@chromium.org | 2010-06-03 11:03:18 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   A /trunk/src/chrome/browser/chromeos/options/language_config_util.h
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Combine the combo box class used by mozc and chewing

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2558001
------------------------------------------------------------------------
r48811 | sergeyu@chromium.org | 2010-06-03 06:08:18 +0200 (Thu, 03 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.cc
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.h
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/net/notifier/base/task_pump.cc
   M /trunk/src/chrome/common/net/notifier/communicator/connection_settings.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.h
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.h
   M /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/listener/listen_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.h
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/third_party/libjingle/README.chromium
   D /trunk/src/third_party/libjingle/files/AUTHORS
   D /trunk/src/third_party/libjingle/files/COPYING
   D /trunk/src/third_party/libjingle/files/ChangeLog
   D /trunk/src/third_party/libjingle/files/DOCUMENTATION
   D /trunk/src/third_party/libjingle/files/INSTALL
   D /trunk/src/third_party/libjingle/files/Makefile.am
   D /trunk/src/third_party/libjingle/files/NEWS
   D /trunk/src/third_party/libjingle/files/README
   D /trunk/src/third_party/libjingle/files/README.win
   D /trunk/src/third_party/libjingle/files/config.h
   D /trunk/src/third_party/libjingle/files/configure.ac
   D /trunk/src/third_party/libjingle/files/talk/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/base/Equifax_Secure_Global_eBusiness_CA-1.h
   D /trunk/src/third_party/libjingle/files/talk/base/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/base/asyncfile.h
   D /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.h
   D /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/asyncsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc
   D /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.h
   D /trunk/src/third_party/libjingle/files/talk/base/base64.cc
   D /trunk/src/third_party/libjingle/files/talk/base/base64.h
   D /trunk/src/third_party/libjingle/files/talk/base/basicdefs.h
   D /trunk/src/third_party/libjingle/files/talk/base/basictypes.h
   D /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.cc
   D /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.h
   D /trunk/src/third_party/libjingle/files/talk/base/byteorder.h
   D /trunk/src/third_party/libjingle/files/talk/base/common.cc
   D /trunk/src/third_party/libjingle/files/talk/base/common.h
   D /trunk/src/third_party/libjingle/files/talk/base/convert.h
   D /trunk/src/third_party/libjingle/files/talk/base/criticalsection.h
   D /trunk/src/third_party/libjingle/files/talk/base/cryptstring.h
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache.cc
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache.h
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.cc
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.h
   D /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.cc
   D /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.h
   D /trunk/src/third_party/libjingle/files/talk/base/event.h
   D /trunk/src/third_party/libjingle/files/talk/base/fileutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/fileutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/helpers.cc
   D /trunk/src/third_party/libjingle/files/talk/base/helpers.h
   D /trunk/src/third_party/libjingle/files/talk/base/host.cc
   D /trunk/src/third_party/libjingle/files/talk/base/host.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpbase.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpbase.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpclient.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpclient.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpcommon-inl.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpcommon.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpcommon.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/linked_ptr.h
   D /trunk/src/third_party/libjingle/files/talk/base/logging.cc
   D /trunk/src/third_party/libjingle/files/talk/base/logging.h
   D /trunk/src/third_party/libjingle/files/talk/base/md5.h
   D /trunk/src/third_party/libjingle/files/talk/base/md5c.c
   D /trunk/src/third_party/libjingle/files/talk/base/messagequeue.cc
   D /trunk/src/third_party/libjingle/files/talk/base/messagequeue.h
   D /trunk/src/third_party/libjingle/files/talk/base/nat_unittest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/natserver_main.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.h
   D /trunk/src/third_party/libjingle/files/talk/base/nattypes.cc
   D /trunk/src/third_party/libjingle/files/talk/base/nattypes.h
   D /trunk/src/third_party/libjingle/files/talk/base/network.cc
   D /trunk/src/third_party/libjingle/files/talk/base/network.h
   D /trunk/src/third_party/libjingle/files/talk/base/openssladapter.cc
   D /trunk/src/third_party/libjingle/files/talk/base/openssladapter.h
   D /trunk/src/third_party/libjingle/files/talk/base/pathutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/pathutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/proxydetect.cc
   D /trunk/src/third_party/libjingle/files/talk/base/proxydetect.h
   D /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.cc
   D /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.h
   D /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.cc
   D /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.h
   D /trunk/src/third_party/libjingle/files/talk/base/scoped_ptr.h
   D /trunk/src/third_party/libjingle/files/talk/base/sec_buffer.h
   D /trunk/src/third_party/libjingle/files/talk/base/signalthread.cc
   D /trunk/src/third_party/libjingle/files/talk/base/signalthread.h
   D /trunk/src/third_party/libjingle/files/talk/base/sigslot.h
   D /trunk/src/third_party/libjingle/files/talk/base/socket.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketadapters.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketadapters.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddress.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddress.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketfactory.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketpool.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketpool.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketstream.h
   D /trunk/src/third_party/libjingle/files/talk/base/ssladapter.cc
   D /trunk/src/third_party/libjingle/files/talk/base/ssladapter.h
   D /trunk/src/third_party/libjingle/files/talk/base/stl_decl.h
   D /trunk/src/third_party/libjingle/files/talk/base/stream.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stream.h
   D /trunk/src/third_party/libjingle/files/talk/base/streamutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/streamutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/stringdigest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stringdigest.h
   D /trunk/src/third_party/libjingle/files/talk/base/stringencode.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stringencode.h
   D /trunk/src/third_party/libjingle/files/talk/base/stringutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stringutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/tarstream.cc
   D /trunk/src/third_party/libjingle/files/talk/base/tarstream.h
   D /trunk/src/third_party/libjingle/files/talk/base/task.cc
   D /trunk/src/third_party/libjingle/files/talk/base/task.h
   D /trunk/src/third_party/libjingle/files/talk/base/taskrunner.cc
   D /trunk/src/third_party/libjingle/files/talk/base/taskrunner.h
   D /trunk/src/third_party/libjingle/files/talk/base/testclient.cc
   D /trunk/src/third_party/libjingle/files/talk/base/testclient.h
   D /trunk/src/third_party/libjingle/files/talk/base/thread.cc
   D /trunk/src/third_party/libjingle/files/talk/base/thread.h
   D /trunk/src/third_party/libjingle/files/talk/base/time.cc
   D /trunk/src/third_party/libjingle/files/talk/base/time.h
   D /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.cc
   D /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.h
   D /trunk/src/third_party/libjingle/files/talk/base/urlencode.cc
   D /trunk/src/third_party/libjingle/files/talk/base/urlencode.h
   D /trunk/src/third_party/libjingle/files/talk/base/virtualsocket_unittest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/win32.h
   D /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.cc
   D /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.h
   D /trunk/src/third_party/libjingle/files/talk/base/win32window.cc
   D /trunk/src/third_party/libjingle/files/talk/base/win32window.h
   D /trunk/src/third_party/libjingle/files/talk/base/winfirewall.cc
   D /trunk/src/third_party/libjingle/files/talk/base/winfirewall.h
   D /trunk/src/third_party/libjingle/files/talk/base/winping.cc
   D /trunk/src/third_party/libjingle/files/talk/base/winping.h
   D /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.cc
   D /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.h
   D /trunk/src/third_party/libjingle/files/talk/pkg.m4
   D /trunk/src/third_party/libjingle/files/talk/xmllite/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/xmllite/qname.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/qname.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/xmpp/asyncsocket.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/jid.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/jid.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/plainsaslhandler.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/prexmppauth.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslcookiemechanism.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslhandler.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslplainmechanism.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclientsettings.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengine.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl_iq.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.h
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/overrides/talk/base/basictypes.h
   A /trunk/src/third_party/libjingle/overrides/talk/base/logging.h (from /trunk/src/third_party/libjingle/files/talk/base/logging.h:48807)
   A /trunk/src/third_party/libjingle/overrides/talk/base/win32socketinit.cc (from /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc:48807)
   D /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc
   A /trunk/src/third_party/libjingle/overrides/talk/xmllite
   A /trunk/src/third_party/libjingle/overrides/talk/xmllite/qname.cc
   A /trunk/src/third_party/libjingle/overrides/talk/xmllite/qname.h

New libjingle integrated to chrome.
BUG=none
TEST=Chrome Sync works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48798

Review URL: http://codereview.chromium.org/2255007
------------------------------------------------------------------------
r48806 | zork@chromium.org | 2010-06-03 05:28:21 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add Chewing integer preferences

BUG=chromium-os:2624
TEST=Open the IME settings window. Add Traditional Chinese. Open the options dialog, and check that the integer prefs are there

Review URL: http://codereview.chromium.org/2457001
------------------------------------------------------------------------
r48805 | tfarina@chromium.org | 2010-06-03 05:01:57 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc

Use sql::Statement::BindString16 in a bunch of places to get rid of UTF16ToUTF8 conversions.

BUG=41862
TEST=trybots

Review URL: http://codereview.chromium.org/2481003
------------------------------------------------------------------------
r48800 | sergeyu@chromium.org | 2010-06-03 03:19:53 +0200 (Thu, 03 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.cc
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.h
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/net/notifier/base/task_pump.cc
   M /trunk/src/chrome/common/net/notifier/communicator/connection_settings.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.h
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.h
   M /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/listener/listen_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.h
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/third_party/libjingle/README.chromium
   A /trunk/src/third_party/libjingle/files/AUTHORS (from /trunk/src/third_party/libjingle/files/AUTHORS:48797)
   A /trunk/src/third_party/libjingle/files/COPYING (from /trunk/src/third_party/libjingle/files/COPYING:48797)
   A /trunk/src/third_party/libjingle/files/ChangeLog (from /trunk/src/third_party/libjingle/files/ChangeLog:48797)
   A /trunk/src/third_party/libjingle/files/DOCUMENTATION (from /trunk/src/third_party/libjingle/files/DOCUMENTATION:48797)
   A /trunk/src/third_party/libjingle/files/INSTALL (from /trunk/src/third_party/libjingle/files/INSTALL:48797)
   A /trunk/src/third_party/libjingle/files/Makefile.am (from /trunk/src/third_party/libjingle/files/Makefile.am:48797)
   A /trunk/src/third_party/libjingle/files/NEWS (from /trunk/src/third_party/libjingle/files/NEWS:48797)
   A /trunk/src/third_party/libjingle/files/README (from /trunk/src/third_party/libjingle/files/README:48797)
   A /trunk/src/third_party/libjingle/files/README.win (from /trunk/src/third_party/libjingle/files/README.win:48797)
   A /trunk/src/third_party/libjingle/files/config.h (from /trunk/src/third_party/libjingle/files/config.h:48797)
   A /trunk/src/third_party/libjingle/files/configure.ac (from /trunk/src/third_party/libjingle/files/configure.ac:48797)
   A /trunk/src/third_party/libjingle/files/talk/Makefile.am (from /trunk/src/third_party/libjingle/files/talk/Makefile.am:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/Equifax_Secure_Global_eBusiness_CA-1.h (from /trunk/src/third_party/libjingle/files/talk/base/Equifax_Secure_Global_eBusiness_CA-1.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/Makefile.am (from /trunk/src/third_party/libjingle/files/talk/base/Makefile.am:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asyncfile.h (from /trunk/src/third_party/libjingle/files/talk/base/asyncfile.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.cc (from /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.h (from /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.cc (from /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.h (from /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asyncsocket.h (from /trunk/src/third_party/libjingle/files/talk/base/asyncsocket.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.cc (from /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.h (from /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.cc (from /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.h (from /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc (from /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.h (from /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/base64.cc (from /trunk/src/third_party/libjingle/files/talk/base/base64.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/base64.h (from /trunk/src/third_party/libjingle/files/talk/base/base64.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/basicdefs.h (from /trunk/src/third_party/libjingle/files/talk/base/basicdefs.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/basictypes.h (from /trunk/src/third_party/libjingle/files/talk/base/basictypes.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.cc (from /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.h (from /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/byteorder.h (from /trunk/src/third_party/libjingle/files/talk/base/byteorder.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/common.cc (from /trunk/src/third_party/libjingle/files/talk/base/common.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/common.h (from /trunk/src/third_party/libjingle/files/talk/base/common.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/convert.h (from /trunk/src/third_party/libjingle/files/talk/base/convert.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/criticalsection.h (from /trunk/src/third_party/libjingle/files/talk/base/criticalsection.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/cryptstring.h (from /trunk/src/third_party/libjingle/files/talk/base/cryptstring.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/diskcache.cc (from /trunk/src/third_party/libjingle/files/talk/base/diskcache.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/diskcache.h (from /trunk/src/third_party/libjingle/files/talk/base/diskcache.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.cc (from /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.h (from /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.cc (from /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.h (from /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/event.h (from /trunk/src/third_party/libjingle/files/talk/base/event.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/fileutils.cc (from /trunk/src/third_party/libjingle/files/talk/base/fileutils.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/fileutils.h (from /trunk/src/third_party/libjingle/files/talk/base/fileutils.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.cc (from /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.h (from /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/helpers.cc (from /trunk/src/third_party/libjingle/files/talk/base/helpers.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/helpers.h (from /trunk/src/third_party/libjingle/files/talk/base/helpers.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/host.cc (from /trunk/src/third_party/libjingle/files/talk/base/host.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/host.h (from /trunk/src/third_party/libjingle/files/talk/base/host.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpbase.cc (from /trunk/src/third_party/libjingle/files/talk/base/httpbase.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpbase.h (from /trunk/src/third_party/libjingle/files/talk/base/httpbase.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpclient.cc (from /trunk/src/third_party/libjingle/files/talk/base/httpclient.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpclient.h (from /trunk/src/third_party/libjingle/files/talk/base/httpclient.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpcommon-inl.h (from /trunk/src/third_party/libjingle/files/talk/base/httpcommon-inl.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpcommon.cc (from /trunk/src/third_party/libjingle/files/talk/base/httpcommon.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpcommon.h (from /trunk/src/third_party/libjingle/files/talk/base/httpcommon.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpserver.cc (from /trunk/src/third_party/libjingle/files/talk/base/httpserver.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/httpserver.h (from /trunk/src/third_party/libjingle/files/talk/base/httpserver.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/linked_ptr.h (from /trunk/src/third_party/libjingle/files/talk/base/linked_ptr.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/logging.cc (from /trunk/src/third_party/libjingle/files/talk/base/logging.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/logging.h (from /trunk/src/third_party/libjingle/files/talk/base/logging.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/md5.h (from /trunk/src/third_party/libjingle/files/talk/base/md5.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/md5c.c (from /trunk/src/third_party/libjingle/files/talk/base/md5c.c:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/messagequeue.cc (from /trunk/src/third_party/libjingle/files/talk/base/messagequeue.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/messagequeue.h (from /trunk/src/third_party/libjingle/files/talk/base/messagequeue.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/nat_unittest.cc (from /trunk/src/third_party/libjingle/files/talk/base/nat_unittest.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/natserver.cc (from /trunk/src/third_party/libjingle/files/talk/base/natserver.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/natserver.h (from /trunk/src/third_party/libjingle/files/talk/base/natserver.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/natserver_main.cc (from /trunk/src/third_party/libjingle/files/talk/base/natserver_main.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.cc (from /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.h (from /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/nattypes.cc (from /trunk/src/third_party/libjingle/files/talk/base/nattypes.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/nattypes.h (from /trunk/src/third_party/libjingle/files/talk/base/nattypes.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/network.cc (from /trunk/src/third_party/libjingle/files/talk/base/network.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/network.h (from /trunk/src/third_party/libjingle/files/talk/base/network.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/openssladapter.cc (from /trunk/src/third_party/libjingle/files/talk/base/openssladapter.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/openssladapter.h (from /trunk/src/third_party/libjingle/files/talk/base/openssladapter.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/pathutils.cc (from /trunk/src/third_party/libjingle/files/talk/base/pathutils.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/pathutils.h (from /trunk/src/third_party/libjingle/files/talk/base/pathutils.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.cc (from /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.h (from /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/proxydetect.cc (from /trunk/src/third_party/libjingle/files/talk/base/proxydetect.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/proxydetect.h (from /trunk/src/third_party/libjingle/files/talk/base/proxydetect.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.cc (from /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.h (from /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.cc (from /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.h (from /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/scoped_ptr.h (from /trunk/src/third_party/libjingle/files/talk/base/scoped_ptr.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/sec_buffer.h (from /trunk/src/third_party/libjingle/files/talk/base/sec_buffer.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/signalthread.cc (from /trunk/src/third_party/libjingle/files/talk/base/signalthread.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/signalthread.h (from /trunk/src/third_party/libjingle/files/talk/base/signalthread.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/sigslot.h (from /trunk/src/third_party/libjingle/files/talk/base/sigslot.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socket.h (from /trunk/src/third_party/libjingle/files/talk/base/socket.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketadapters.cc (from /trunk/src/third_party/libjingle/files/talk/base/socketadapters.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketadapters.h (from /trunk/src/third_party/libjingle/files/talk/base/socketadapters.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketaddress.cc (from /trunk/src/third_party/libjingle/files/talk/base/socketaddress.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketaddress.h (from /trunk/src/third_party/libjingle/files/talk/base/socketaddress.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.cc (from /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.h (from /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketfactory.h (from /trunk/src/third_party/libjingle/files/talk/base/socketfactory.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketpool.cc (from /trunk/src/third_party/libjingle/files/talk/base/socketpool.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketpool.h (from /trunk/src/third_party/libjingle/files/talk/base/socketpool.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketserver.h (from /trunk/src/third_party/libjingle/files/talk/base/socketserver.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/socketstream.h (from /trunk/src/third_party/libjingle/files/talk/base/socketstream.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/ssladapter.cc (from /trunk/src/third_party/libjingle/files/talk/base/ssladapter.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/ssladapter.h (from /trunk/src/third_party/libjingle/files/talk/base/ssladapter.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stl_decl.h (from /trunk/src/third_party/libjingle/files/talk/base/stl_decl.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stream.cc (from /trunk/src/third_party/libjingle/files/talk/base/stream.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stream.h (from /trunk/src/third_party/libjingle/files/talk/base/stream.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/streamutils.cc (from /trunk/src/third_party/libjingle/files/talk/base/streamutils.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/streamutils.h (from /trunk/src/third_party/libjingle/files/talk/base/streamutils.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stringdigest.cc (from /trunk/src/third_party/libjingle/files/talk/base/stringdigest.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stringdigest.h (from /trunk/src/third_party/libjingle/files/talk/base/stringdigest.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stringencode.cc (from /trunk/src/third_party/libjingle/files/talk/base/stringencode.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stringencode.h (from /trunk/src/third_party/libjingle/files/talk/base/stringencode.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stringutils.cc (from /trunk/src/third_party/libjingle/files/talk/base/stringutils.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/stringutils.h (from /trunk/src/third_party/libjingle/files/talk/base/stringutils.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/tarstream.cc (from /trunk/src/third_party/libjingle/files/talk/base/tarstream.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/tarstream.h (from /trunk/src/third_party/libjingle/files/talk/base/tarstream.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/task.cc (from /trunk/src/third_party/libjingle/files/talk/base/task.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/task.h (from /trunk/src/third_party/libjingle/files/talk/base/task.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/taskrunner.cc (from /trunk/src/third_party/libjingle/files/talk/base/taskrunner.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/taskrunner.h (from /trunk/src/third_party/libjingle/files/talk/base/taskrunner.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/testclient.cc (from /trunk/src/third_party/libjingle/files/talk/base/testclient.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/testclient.h (from /trunk/src/third_party/libjingle/files/talk/base/testclient.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/thread.cc (from /trunk/src/third_party/libjingle/files/talk/base/thread.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/thread.h (from /trunk/src/third_party/libjingle/files/talk/base/thread.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/time.cc (from /trunk/src/third_party/libjingle/files/talk/base/time.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/time.h (from /trunk/src/third_party/libjingle/files/talk/base/time.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.cc (from /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.h (from /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/urlencode.cc (from /trunk/src/third_party/libjingle/files/talk/base/urlencode.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/urlencode.h (from /trunk/src/third_party/libjingle/files/talk/base/urlencode.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/virtualsocket_unittest.cc (from /trunk/src/third_party/libjingle/files/talk/base/virtualsocket_unittest.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.cc (from /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.h (from /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/win32.h (from /trunk/src/third_party/libjingle/files/talk/base/win32.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.cc (from /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.h (from /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/win32window.cc (from /trunk/src/third_party/libjingle/files/talk/base/win32window.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/win32window.h (from /trunk/src/third_party/libjingle/files/talk/base/win32window.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/winfirewall.cc (from /trunk/src/third_party/libjingle/files/talk/base/winfirewall.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/winfirewall.h (from /trunk/src/third_party/libjingle/files/talk/base/winfirewall.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/winping.cc (from /trunk/src/third_party/libjingle/files/talk/base/winping.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/winping.h (from /trunk/src/third_party/libjingle/files/talk/base/winping.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.cc (from /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.h (from /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/pkg.m4 (from /trunk/src/third_party/libjingle/files/talk/pkg.m4:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/Makefile.am (from /trunk/src/third_party/libjingle/files/talk/xmllite/Makefile.am:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/qname.cc (from /trunk/src/third_party/libjingle/files/talk/xmllite/qname.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/qname.h (from /trunk/src/third_party/libjingle/files/talk/xmllite/qname.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.cc (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.h (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.cc (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.h (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.cc (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.h (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.cc (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.h (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.cc (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.h (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.cc (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.h (from /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/Makefile.am (from /trunk/src/third_party/libjingle/files/talk/xmpp/Makefile.am:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/asyncsocket.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/asyncsocket.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/jid.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/jid.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/jid.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/jid.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/plainsaslhandler.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/plainsaslhandler.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/prexmppauth.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/prexmppauth.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/saslcookiemechanism.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/saslcookiemechanism.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/saslhandler.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/saslhandler.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/saslplainmechanism.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/saslplainmechanism.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclientsettings.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclientsettings.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengine.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengine.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl_iq.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl_iq.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.h:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.cc:48797)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.h:48797)
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/overrides/talk/base/basictypes.h
   D /trunk/src/third_party/libjingle/overrides/talk/base/logging.h
   D /trunk/src/third_party/libjingle/overrides/talk/base/win32socketinit.cc
   A /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc (from /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc:48797)
   D /trunk/src/third_party/libjingle/overrides/talk/xmllite

Revert 48798 - New libjingle integrated to chrome.
BUG=none
TEST=Chrome Sync works

Review URL: http://codereview.chromium.org/2255007

TBR=sergeyu@chromium.org
------------------------------------------------------------------------
r48798 | sergeyu@chromium.org | 2010-06-03 02:56:28 +0200 (Thu, 03 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.cc
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.h
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/net/notifier/base/task_pump.cc
   M /trunk/src/chrome/common/net/notifier/communicator/connection_settings.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.h
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.h
   M /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/listener/listen_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.h
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/third_party/libjingle/README.chromium
   D /trunk/src/third_party/libjingle/files/AUTHORS
   D /trunk/src/third_party/libjingle/files/COPYING
   D /trunk/src/third_party/libjingle/files/ChangeLog
   D /trunk/src/third_party/libjingle/files/DOCUMENTATION
   D /trunk/src/third_party/libjingle/files/INSTALL
   D /trunk/src/third_party/libjingle/files/Makefile.am
   D /trunk/src/third_party/libjingle/files/NEWS
   D /trunk/src/third_party/libjingle/files/README
   D /trunk/src/third_party/libjingle/files/README.win
   D /trunk/src/third_party/libjingle/files/config.h
   D /trunk/src/third_party/libjingle/files/configure.ac
   D /trunk/src/third_party/libjingle/files/talk/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/base/Equifax_Secure_Global_eBusiness_CA-1.h
   D /trunk/src/third_party/libjingle/files/talk/base/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/base/asyncfile.h
   D /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.h
   D /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asyncpacketsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/asyncsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asynctcpsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.cc
   D /trunk/src/third_party/libjingle/files/talk/base/asyncudpsocket.h
   D /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc
   D /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.h
   D /trunk/src/third_party/libjingle/files/talk/base/base64.cc
   D /trunk/src/third_party/libjingle/files/talk/base/base64.h
   D /trunk/src/third_party/libjingle/files/talk/base/basicdefs.h
   D /trunk/src/third_party/libjingle/files/talk/base/basictypes.h
   D /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.cc
   D /trunk/src/third_party/libjingle/files/talk/base/bytebuffer.h
   D /trunk/src/third_party/libjingle/files/talk/base/byteorder.h
   D /trunk/src/third_party/libjingle/files/talk/base/common.cc
   D /trunk/src/third_party/libjingle/files/talk/base/common.h
   D /trunk/src/third_party/libjingle/files/talk/base/convert.h
   D /trunk/src/third_party/libjingle/files/talk/base/criticalsection.h
   D /trunk/src/third_party/libjingle/files/talk/base/cryptstring.h
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache.cc
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache.h
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.cc
   D /trunk/src/third_party/libjingle/files/talk/base/diskcache_win32.h
   D /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.cc
   D /trunk/src/third_party/libjingle/files/talk/base/diskcachestd.h
   D /trunk/src/third_party/libjingle/files/talk/base/event.h
   D /trunk/src/third_party/libjingle/files/talk/base/fileutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/fileutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/firewallsocketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/helpers.cc
   D /trunk/src/third_party/libjingle/files/talk/base/helpers.h
   D /trunk/src/third_party/libjingle/files/talk/base/host.cc
   D /trunk/src/third_party/libjingle/files/talk/base/host.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpbase.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpbase.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpclient.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpclient.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpcommon-inl.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpcommon.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpcommon.h
   D /trunk/src/third_party/libjingle/files/talk/base/httpserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/httpserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/linked_ptr.h
   D /trunk/src/third_party/libjingle/files/talk/base/logging.cc
   D /trunk/src/third_party/libjingle/files/talk/base/logging.h
   D /trunk/src/third_party/libjingle/files/talk/base/md5.h
   D /trunk/src/third_party/libjingle/files/talk/base/md5c.c
   D /trunk/src/third_party/libjingle/files/talk/base/messagequeue.cc
   D /trunk/src/third_party/libjingle/files/talk/base/messagequeue.h
   D /trunk/src/third_party/libjingle/files/talk/base/nat_unittest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/natserver_main.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.cc
   D /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.h
   D /trunk/src/third_party/libjingle/files/talk/base/nattypes.cc
   D /trunk/src/third_party/libjingle/files/talk/base/nattypes.h
   D /trunk/src/third_party/libjingle/files/talk/base/network.cc
   D /trunk/src/third_party/libjingle/files/talk/base/network.h
   D /trunk/src/third_party/libjingle/files/talk/base/openssladapter.cc
   D /trunk/src/third_party/libjingle/files/talk/base/openssladapter.h
   D /trunk/src/third_party/libjingle/files/talk/base/pathutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/pathutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/proxydetect.cc
   D /trunk/src/third_party/libjingle/files/talk/base/proxydetect.h
   D /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.cc
   D /trunk/src/third_party/libjingle/files/talk/base/proxyinfo.h
   D /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.cc
   D /trunk/src/third_party/libjingle/files/talk/base/schanneladapter.h
   D /trunk/src/third_party/libjingle/files/talk/base/scoped_ptr.h
   D /trunk/src/third_party/libjingle/files/talk/base/sec_buffer.h
   D /trunk/src/third_party/libjingle/files/talk/base/signalthread.cc
   D /trunk/src/third_party/libjingle/files/talk/base/signalthread.h
   D /trunk/src/third_party/libjingle/files/talk/base/sigslot.h
   D /trunk/src/third_party/libjingle/files/talk/base/socket.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketadapters.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketadapters.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddress.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddress.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketaddresspair.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketfactory.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketpool.cc
   D /trunk/src/third_party/libjingle/files/talk/base/socketpool.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/socketstream.h
   D /trunk/src/third_party/libjingle/files/talk/base/ssladapter.cc
   D /trunk/src/third_party/libjingle/files/talk/base/ssladapter.h
   D /trunk/src/third_party/libjingle/files/talk/base/stl_decl.h
   D /trunk/src/third_party/libjingle/files/talk/base/stream.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stream.h
   D /trunk/src/third_party/libjingle/files/talk/base/streamutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/streamutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/stringdigest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stringdigest.h
   D /trunk/src/third_party/libjingle/files/talk/base/stringencode.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stringencode.h
   D /trunk/src/third_party/libjingle/files/talk/base/stringutils.cc
   D /trunk/src/third_party/libjingle/files/talk/base/stringutils.h
   D /trunk/src/third_party/libjingle/files/talk/base/tarstream.cc
   D /trunk/src/third_party/libjingle/files/talk/base/tarstream.h
   D /trunk/src/third_party/libjingle/files/talk/base/task.cc
   D /trunk/src/third_party/libjingle/files/talk/base/task.h
   D /trunk/src/third_party/libjingle/files/talk/base/taskrunner.cc
   D /trunk/src/third_party/libjingle/files/talk/base/taskrunner.h
   D /trunk/src/third_party/libjingle/files/talk/base/testclient.cc
   D /trunk/src/third_party/libjingle/files/talk/base/testclient.h
   D /trunk/src/third_party/libjingle/files/talk/base/thread.cc
   D /trunk/src/third_party/libjingle/files/talk/base/thread.h
   D /trunk/src/third_party/libjingle/files/talk/base/time.cc
   D /trunk/src/third_party/libjingle/files/talk/base/time.h
   D /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.cc
   D /trunk/src/third_party/libjingle/files/talk/base/unixfilesystem.h
   D /trunk/src/third_party/libjingle/files/talk/base/urlencode.cc
   D /trunk/src/third_party/libjingle/files/talk/base/urlencode.h
   D /trunk/src/third_party/libjingle/files/talk/base/virtualsocket_unittest.cc
   D /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/virtualsocketserver.h
   D /trunk/src/third_party/libjingle/files/talk/base/win32.h
   D /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.cc
   D /trunk/src/third_party/libjingle/files/talk/base/win32filesystem.h
   D /trunk/src/third_party/libjingle/files/talk/base/win32window.cc
   D /trunk/src/third_party/libjingle/files/talk/base/win32window.h
   D /trunk/src/third_party/libjingle/files/talk/base/winfirewall.cc
   D /trunk/src/third_party/libjingle/files/talk/base/winfirewall.h
   D /trunk/src/third_party/libjingle/files/talk/base/winping.cc
   D /trunk/src/third_party/libjingle/files/talk/base/winping.h
   D /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.cc
   D /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.h
   D /trunk/src/third_party/libjingle/files/talk/pkg.m4
   D /trunk/src/third_party/libjingle/files/talk/xmllite/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/xmllite/qname.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/qname.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlbuilder.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlconstants.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlnsstack.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlparser.h
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.cc
   D /trunk/src/third_party/libjingle/files/talk/xmllite/xmlprinter.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/xmpp/asyncsocket.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/jid.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/jid.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/plainsaslhandler.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/prexmppauth.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/ratelimitmanager.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslcookiemechanism.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslhandler.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/saslplainmechanism.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclientsettings.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengine.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl_iq.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.h
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.h
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/overrides/talk/base/basictypes.h
   A /trunk/src/third_party/libjingle/overrides/talk/base/logging.h (from /trunk/src/third_party/libjingle/files/talk/base/logging.h:48797)
   A /trunk/src/third_party/libjingle/overrides/talk/base/win32socketinit.cc (from /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc:48797)
   D /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc
   A /trunk/src/third_party/libjingle/overrides/talk/xmllite
   A /trunk/src/third_party/libjingle/overrides/talk/xmllite/qname.cc
   A /trunk/src/third_party/libjingle/overrides/talk/xmllite/qname.h

New libjingle integrated to chrome.
BUG=none
TEST=Chrome Sync works

Review URL: http://codereview.chromium.org/2255007
------------------------------------------------------------------------
r48797 | eroman@chromium.org | 2010-06-03 02:49:17 +0200 (Thu, 03 Jun 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/service/net/service_url_request_context.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_source_type_list.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/socks_client_socket_pool.h
   M /trunk/src/net/socket/socks_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session_unittest.cc
   M /trunk/src/net/spdy/spdy_stream_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Rework the logging for sockets/connectjobs.

In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest).

Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams).

Some of the particular changes to the event streams:

* ConnectJobs now create their own source stream internally.
* Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event).
* The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used).
* ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events.
* ConnectJobs log the net error they failed with.
* Removed the SOCKET_BACKUP_TIMER_EXTENDED event.
Review URL: http://codereview.chromium.org/2363003
------------------------------------------------------------------------
r48796 | estade@chromium.org | 2010-06-03 02:34:44 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc

Fix chromeos build following r48795

TBR=dhg
TEST=green chromeos compile

Review URL: http://codereview.chromium.org/2544002
------------------------------------------------------------------------
r48795 | estade@chromium.org | 2010-06-03 02:17:22 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/app/throb_animation.cc
   M /trunk/src/app/throb_animation.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/update_recommended_dialog.cc
   A /trunk/src/chrome/browser/gtk/update_recommended_dialog.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/upgrade_detector.cc
   M /trunk/src/chrome/browser/upgrade_detector.h
   M /trunk/src/chrome/browser/views/update_recommended_message_box.cc
   M /trunk/src/chrome/browser/views/update_recommended_message_box.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_installer_util.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/installer/util/version.cc
   M /trunk/src/chrome/installer/util/version.h

Linux/GTK: implement update notification.

BUG=45148
TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session.

Review URL: http://codereview.chromium.org/2365003
------------------------------------------------------------------------
r48791 | akalin@chromium.org | 2010-06-03 01:32:22 +0200 (Thu, 03 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login_failure.h
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc

Refactored MediatorThread to use Chrome threads primarily.  This is in preparation for using Chrome sockets.

Made TalkMediator explicitly non-thread-safe.

BUG=45612
TEST=manual testing of notifications

Review URL: http://codereview.chromium.org/2471006
------------------------------------------------------------------------
r48790 | dhg@chromium.org | 2010-06-03 01:30:54 +0200 (Thu, 03 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h

Fixing mounting so that it remounts any devices it finds on boot.
BUG=chromium-os:3715
TEST=none

Review URL: http://codereview.chromium.org/2496002
------------------------------------------------------------------------
r48785 | seh@chromium.org | 2010-06-03 00:48:56 +0200 (Thu, 03 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json

Enable Gmail chat interception.
BUG=none
TEST=something
Review URL: http://codereview.chromium.org/2507001
------------------------------------------------------------------------
r48781 | csilv@chromium.org | 2010-06-03 00:30:46 +0200 (Thu, 03 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

Disable navigation contextual menus for Sync dialog UI.

BUG=30710,30706
TEST=Invoke a contextual menu in the Sync sign-in dialog, navigation items
should not appear.
Review URL: http://codereview.chromium.org/2487002
------------------------------------------------------------------------
r48780 | estade@chromium.org | 2010-06-03 00:29:33 +0200 (Thu, 03 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: fix site type icon dragging.

Don't connect to the drag events more than once.

BUG=45270
TEST=dragging that box in debug mode, no backtrace

Review URL: http://codereview.chromium.org/2514001
------------------------------------------------------------------------
r48777 | nshkrob@chromium.org | 2010-06-03 00:19:07 +0200 (Thu, 03 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

1. Write thumbnail to the database on SetPageThumbnail.
2. Store the thumbnail score in the database.

BUG=None
TEST=TopSitesTest



Review URL: http://codereview.chromium.org/2499003
------------------------------------------------------------------------
r48776 | oshima@chromium.org | 2010-06-03 00:16:39 +0200 (Thu, 03 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Initialize screen locker before letting user logged in.
Retry up to 30 seconds (1 sec x 30) even if it fails to grab inputs.

BUG=none
TEST=manual: scree lock should work after chrome crash.

Review URL: http://codereview.chromium.org/2458002
------------------------------------------------------------------------
r48773 | xiyuan@chromium.org | 2010-06-03 00:05:03 +0200 (Thu, 03 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc

Update dialog parent handling logic.

- Use real transient parent for hosted native dialogs since window manager
  supports transient of transient now;
- Use last active normal browser window as parent for option dialogs since
  we don't want to use panel popups as parent;

BUG=chromium-os:3708
TEST=none. This CL gives real transent parent for dialogs but we still need to way to show the dialogs, either exit fullscreen or put them on top of fullscreen.

Review URL: http://codereview.chromium.org/2501001
------------------------------------------------------------------------
r48768 | finnur@chromium.org | 2010-06-02 23:50:51 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

The browser action gripper should become visible when switching from
an app tab to a regular tab.

BUG=45480
TEST=None

Review URL: http://codereview.chromium.org/2425004
------------------------------------------------------------------------
r48767 | arv@chromium.org | 2010-06-02 23:43:56 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmarks: Disable the sort command when there are no items to sort.

BUG=39250
TEST=Select a folder with no items. The sort command should be disabled.

Review URL: http://codereview.chromium.org/2467007
------------------------------------------------------------------------
r48766 | ziadh@chromium.org | 2010-06-02 23:31:44 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/net/disk_cache/histogram_macros.h
   M /trunk/src/net/socket/client_socket_pool_histograms.cc

Refactored Histogram::FactoryGet() to be style-compliant

Currently, two (2) overloaded versions of Histogram::FactoryGet() exist. Google's C++ style guide discourages such implementations. I refactored the methods into Histogram::FactoryGet() (no name change), which takes 'Sample' types as arguments, and Histogram::FactoryTimeGet(), which takes base::TimeDelta types as arguments.

r = jar

Review URL: http://codereview.chromium.org/2423004
------------------------------------------------------------------------
r48765 | pinkerton@chromium.org | 2010-06-02 23:27:50 +0200 (Wed, 02 Jun 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/SideToolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   A /trunk/src/chrome/browser/cocoa/side_tabs_toolbar_controller.h
   A /trunk/src/chrome/browser/cocoa/side_tabs_toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi

Initial cut at scaffolding for mac sidetabs. No visible changes to browser without --enable-vertical-tabs, and even then, don't expect it to work.
BUG=44773
TEST=infobars, bookmark bar, tab strip, etc should all behave correctly when showing, hiding, and widnow resizing. This cl should have no visible impact without the above flag on the command line.
Review URL: http://codereview.chromium.org/2475002
------------------------------------------------------------------------
r48761 | oshima@chromium.org | 2010-06-02 22:52:11 +0200 (Wed, 02 Jun 2010) | 23 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/login/camera.cc
   D /trunk/src/chrome/browser/chromeos/login/camera.h
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   D /trunk/src/chrome/browser/chromeos/login/user_image_screen.cc
   D /trunk/src/chrome/browser/chromeos/login/user_image_screen.h
   D /trunk/src/chrome/browser/chromeos/login/user_image_view.cc
   D /trunk/src/chrome/browser/chromeos/login/user_image_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert r48735 "Added user image screen for new user login (or old user logging in through"

This reverts commit 4ffcb495af72106fe243c6982119d799325d86ba.

The following tests were failing with this change.

NetworkScreenTest.Basic
NetworkScreenTest.NetworksConnectedNotSelected
NetworkScreenTest.EthernetSelected
NetworkScreenTest.WifiSelected
NetworkScreenTest.CellularSelected
NetworkScreenTest.WifiWaiting
LoginScreenTest.TestBasic
LoginScreenTest.AuthenticationFailed
LoginScreenTest.IncognitoLogin

grd files are excluded from revert to avoid build failures.

TBR=avayvod@chromium.org
BUG=none
TEST=chromeos build bot should cycle green

Review URL: http://codereview.chromium.org/2498003
------------------------------------------------------------------------
r48759 | estade@chromium.org | 2010-06-02 22:16:35 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Mark a test as flaky on linux because it fails sometimes on valgrind.

BUG=32615,45675
TEST=tree greener
TBR=creis

Review URL: http://codereview.chromium.org/2450006
------------------------------------------------------------------------
r48756 | andybons@chromium.org | 2010-06-02 21:53:54 +0200 (Wed, 02 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

[Mac] Re-enable some incognito extensions tests either because they are no longer failing or to gather more data on the crashes since I cannot get them to fail on my local machine.

BUG=40002,40133
TEST=ExtensionBrowserTest, BrowserActionApiTest
Review URL: http://codereview.chromium.org/2495002
------------------------------------------------------------------------
r48754 | vangelis@chromium.org | 2010-06-02 21:51:40 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Adding command line flag for enabling accelerated compositing.
This CL cannot be checked in until the patch for:
https://bugs.webkit.org/show_bug.cgi?id=39917
has landed.
BUG=45373
Review URL: http://codereview.chromium.org/2330004
------------------------------------------------------------------------
r48751 | erg@chromium.org | 2010-06-02 21:42:42 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/js_modal_dialog.cc

Truncate very long javascript alert messages. They can overflow the UI and on Linux cause crashes.

BUG=45002
TEST=none

Review URL: http://codereview.chromium.org/2486003
------------------------------------------------------------------------
r48749 | dhg@chromium.org | 2010-06-02 21:38:07 +0200 (Wed, 02 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Changing the behavior so that clicking on an item forces a playback, and enqueueing an item is available from the menu.

Review URL: http://codereview.chromium.org/2436008
------------------------------------------------------------------------
r48745 | jhawkins@chromium.org | 2010-06-02 21:02:39 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

gtk: Collapse the three AutoFill phone/fax fields into one.

BUG=41234
TEST=none

Review URL: http://codereview.chromium.org/2464002
------------------------------------------------------------------------
r48744 | agl@chromium.org | 2010-06-02 20:47:55 +0200 (Wed, 02 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/browser_main.cc

Reset signal handlers in forked children.

If a signal is delivered to a child process in between forking and
execing then it will trigger Chrome's signal handlers. This will
likely result in sadness.

BUG=44953

http://codereview.chromium.org/2452003/show
------------------------------------------------------------------------
r48743 | arv@chromium.org | 2010-06-02 20:40:47 +0200 (Wed, 02 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmarks: Make sure we update the UI on import

We used to assume that all bookmark imports were adding a folder to "Other bookmarks". This is not always the case so now we reload the tree and the list instead.

BUG=39893
TEST=Start with an empty profile. Click "Import bookmarks" on the bookmarks toolbar. The imported bookmarks and bookmarks folders should show up.

Review URL: http://codereview.chromium.org/2485002
------------------------------------------------------------------------
r48736 | thakis@chromium.org | 2010-06-02 19:37:43 +0200 (Wed, 02 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Mac: Hook up "Clear Auto-Open Settings" button

xib change: Hook up button to new outlet and action, bind its "enabled" property to fileHandlerUIEnabled.

BUG=41794
TEST=Download a pdf and a doc file, open prefs in second window. In the download shelf, check pdf files to auto-open. Button in prefs should become active. Let doc files auto-open. Button should stay active. Disable auto-opening for both types in shelf, button should become inactive. Let pdfs auto-open, click button. Button should become inactive, pdfs should show up as non-autoopening in shelf.

Review URL: http://codereview.chromium.org/2473002
------------------------------------------------------------------------
r48735 | avayvod@google.com | 2010-06-02 19:29:47 +0200 (Wed, 02 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/chromeos/login/camera.cc
   A /trunk/src/chrome/browser/chromeos/login/camera.h
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   A /trunk/src/chrome/browser/chromeos/login/user_image_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/user_image_screen.h
   A /trunk/src/chrome/browser/chromeos/login/user_image_view.cc
   A /trunk/src/chrome/browser/chromeos/login/user_image_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Added user image screen for new user login (or old user logging in through
new user screen). If user takes snapshot and hits OK on image screen, the
snapshot becomes user image. If user presses Cancel, his image is downloaded
via Contacts API.

BUG=cros:3175
TEST=Login via new user login window. Verify that both use cases work if you logout after the browser is shown.

Review URL: http://codereview.chromium.org/2118002
------------------------------------------------------------------------
r48733 | cindylau@google.com | 2010-06-02 19:03:32 +0200 (Wed, 02 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_cookies_unittest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/tab.html

C++ readability change for cindylau.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2090008
------------------------------------------------------------------------
r48731 | thakis@chromium.org | 2010-06-02 18:50:58 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/default_plugin_uitest.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/DEPS
   A /trunk/src/chrome/common/default_plugin.cc
   A /trunk/src/chrome/common/default_plugin.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/default_plugin.html
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/webkit/default_plugin/default_plugin.gyp
   M /trunk/src/webkit/default_plugin/plugin_main.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/webkit_glue.gypi
   D /trunk/src/webkit/support/default_plugin_stubs_win.cc
   M /trunk/src/webkit/support/webkit_support.gypi
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc

Make webkit_glue not depend on default_plugin.

This removes a dependency cycle and should also make life easier for DRT.

Revert http://codereview.chromium.org/1658012

Review URL: http://codereview.chromium.org/2358001
------------------------------------------------------------------------
r48730 | pkasting@chromium.org | 2010-06-02 18:43:19 +0200 (Wed, 02 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/net/base/net_util.cc

Misc. small cleanups I ran into while working on other changes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2486004
------------------------------------------------------------------------
r48729 | mpcomplete@chromium.org | 2010-06-02 18:34:39 +0200 (Wed, 02 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/omnibox/test.html

Attempt to fix flaky OmniboxApiTest.Basic.

I'm making an educated guess that the TemplateURLModel wasn't loaded by the
time we needed a keyword, so let's just wait for it to load.

BUG=45588

Review URL: http://codereview.chromium.org/2485004
------------------------------------------------------------------------
r48727 | andybons@chromium.org | 2010-06-02 18:23:34 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view_unittest.mm

[Mac] Updates the unit test with some minor tweaks to the Browser Actions container view.

TEST=BrowserActionsContainerViewTest
BUG=none

Review URL: http://codereview.chromium.org/2426002
------------------------------------------------------------------------
r48726 | sky@chromium.org | 2010-06-02 18:14:02 +0200 (Wed, 02 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Changes session restore to throttle loading of tabs. New tabs are
loaded when a delay is reached (which is doubled with time) or after a
tab finishes loading.

BUG=none
TEST=make sure session restore still works.

Review URL: http://codereview.chromium.org/2470003
------------------------------------------------------------------------
r48723 | phajdan.jr@chromium.org | 2010-06-02 17:22:56 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/version_loader.h

[GTTF] Use FRIEND_TEST_ALL_PREFIXES in chrome/browser/chromeos

TEST=none
BUG=44549

Review URL: http://codereview.chromium.org/2484001
------------------------------------------------------------------------
r48721 | nkostylev@google.com | 2010-06-02 17:00:00 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/web_page_screen.h

Add network timeout when loading account creation page.

BUG= http://crosbug.com/3289
TEST=Connect to the network that requires web base login and open "Create account". It should timeout after 10 secs or earlier.

Review URL: http://codereview.chromium.org/2465001
------------------------------------------------------------------------
r48720 | inferno@chromium.org | 2010-06-02 16:35:48 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc

Add ftp protocol to the safebrowsing checks. Fixed the crash with canonicalization of non-standard urls in CanonicalizeUrl function. Add CanCheckUrl to a more central location. Added the null check in GeneratePathsToCheck. Remove redundant checks from resource dispatcher host.

BUG=40605
TEST=SafeBrowsingUtilTest.CanonicalizeUrl

Review URL: http://codereview.chromium.org/2471002
------------------------------------------------------------------------
r48719 | bulach@chromium.org | 2010-06-02 16:06:34 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Enables geolocation browser tests on Mac.
(this is a follow up on http://codereview.chromium.org/2474002/show)

BUG=29424
TEST=GeolocationBrowserTest.*

Review URL: http://codereview.chromium.org/2459005
------------------------------------------------------------------------
r48718 | bulach@chromium.org | 2010-06-02 16:04:49 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.cc

Removes spurious JS callback triggered by MockLocationProvider::OnPermissionGranted.
(this generated an extra alert, which is closed when test finishes on gtk/win, but hangs on mac).

BUG=29424
TEST=GeolocationBrowserTest.*

Review URL: http://codereview.chromium.org/2474002
------------------------------------------------------------------------
r48716 | avi@chromium.org | 2010-06-02 15:51:11 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/config_dir_policy_provider.cc
   M /trunk/src/chrome/browser/config_dir_policy_provider.h
   M /trunk/src/chrome/browser/config_dir_policy_provider_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.h
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc

Reduce duplication across Linux/Windows policy providers, and unify names used therein.

BUG=http://crbug.com/45344
TEST=no change

Review URL: http://codereview.chromium.org/2387003
------------------------------------------------------------------------
r48713 | nkostylev@google.com | 2010-06-02 14:34:22 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/theme/spinner.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/chromeos/login/helper.cc
   A /trunk/src/chrome/browser/chromeos/login/helper.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Show spinner on login (both images window and "New user").
Added alpha channel for spinner.

BUG= http://crosbug.com/3299
TEST=If the Sign in is longer than 500ms spinner will be shown.

Review URL: http://codereview.chromium.org/2438001
------------------------------------------------------------------------
r48711 | joth@chromium.org | 2010-06-02 14:25:55 +0200 (Wed, 02 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.h
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.h
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.h

Remove obsolete code:
- InformListenersOfMovement not required as WebKit has no way to trigger timeouts when movement is detected but cannot be resolved to a location.
- Error message in gps_open() does not have any additional information

Review URL: http://codereview.chromium.org/2450002
------------------------------------------------------------------------
r48710 | pam@chromium.org | 2010-06-02 14:24:03 +0200 (Wed, 02 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Fix line endings corrupted by git.

BUG=none
TEST=patches containing this file work on the trybots
Review URL: http://codereview.chromium.org/2494002
------------------------------------------------------------------------
r48691 | pkasting@chromium.org | 2010-06-02 04:37:40 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Strip the trailing slash from URLs like "http://google.com/".  This especially helps when the scheme has also been stripped, as it makes the hostname look less unbalanced.  We're careful to avoid stripping the slash when doing so would confuse the omnibox.

This also moves to more aggressive stripping and/or unescaping in several places.  In general, it seems like we should be as aggressive as is feasible.

BUG=43587
TEST=Visit google.com.  There should be no slash in the address bar.
Review URL: http://codereview.chromium.org/2389002
------------------------------------------------------------------------
r48690 | zork@chromium.org | 2010-06-02 04:17:02 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Tweak the horizontal mode UI in candidate_window to make it look nicer

BUG=chromium-os:2760
TEST=Use any IME, and examine the candidate window.

Review URL: http://codereview.chromium.org/2450001
------------------------------------------------------------------------
r48689 | tfarina@chromium.org | 2010-06-02 04:02:41 +0200 (Wed, 02 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h

gtk: Make use of gtk signal macros in BrowserTitleBar.

BUG=None
TEST=trybots and manually

Review URL: http://codereview.chromium.org/2448001
------------------------------------------------------------------------
r48687 | dhollowa@chromium.org | 2010-06-02 03:23:12 +0200 (Wed, 02 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillAddressFormView.xib
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardFormView.xib
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm

AutoFill remove defaults from settings dialog

The new AutoFill dialog mocks eliminate the need for a "default" address and credit card.  Removing code related to UI for these defaults.  Nib changes: Removed the "Default" radio button from each of the Nibs.

BUG=44621
TEST=AutoFillDialogControllerTest.*:-AutoFillDialogControllerTest.DefaultsChangingLogic

Review URL: http://codereview.chromium.org/2466002
------------------------------------------------------------------------
r48685 | oshima@chromium.org | 2010-06-02 02:45:02 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc

Don't focus notificaiton panel when opened.
Use new WM parameter to control initial focus of the panel window. (see http://codereview.chromium.org/2474001)

BUG=chromium-os:3408
TEST=none. This requires WM change to function properly.

Review URL: http://codereview.chromium.org/2254005
------------------------------------------------------------------------
r48684 | jshin@chromium.org | 2010-06-02 02:34:04 +0200 (Wed, 02 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable ExtensionBrowserTest.PageActionRefreshCrash on Mac. It crashes only
occassionally, but when it does, FLAKY prefix does not help because it
turns the tree red. By disabling this test, we lose the coverage for this
test on Mac. Until we have a better way to handle flaky crashes, it's better
to disable it. 

BUG=45079
TEST=Mac bots don't turn red due to this test crashing.
TBR=jrg

Review URL: http://codereview.chromium.org/2485003
------------------------------------------------------------------------
r48683 | jshin@chromium.org | 2010-06-02 02:24:35 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

Disable FindInPageControllerTest.ActivateLinkNavigatesPage and 
ExtensionApiTest.Bookmarks on Windows

BUG=45594,45595
TEST=Windows bot don't turn red with browser_test failure
TBR=jrg
Review URL: http://codereview.chromium.org/2433003
------------------------------------------------------------------------
r48675 | akalin@chromium.org | 2010-06-02 01:30:07 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Make sure XMPP logins and notification sends are done on the sync
core thread only.

BUG=none
TEST=unit tests, manual testing of notifications

Review URL: http://codereview.chromium.org/2326001
------------------------------------------------------------------------
r48673 | estade@chromium.org | 2010-06-02 01:16:04 +0200 (Wed, 02 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Mark BrowserCloseTabWhenOtherTabHasListener as flaky on Linux.

BUG=45562
TEST=tree green
TBR=jshin

Review URL: http://codereview.chromium.org/2449007
------------------------------------------------------------------------
r48670 | skrul@chromium.org | 2010-06-02 00:49:01 +0200 (Wed, 02 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h

Move destkop notification prefs to RegisterUserPrefs

Review URL: http://codereview.chromium.org/2455005
------------------------------------------------------------------------
r48666 | pkasting@chromium.org | 2010-06-02 00:05:45 +0200 (Wed, 02 Jun 2010) | 5 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/base/scoped_bstr_win_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/html_utils.cc
   M /trunk/src/chrome_frame/html_utils.h
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/gfx/icon_util.cc
   M /trunk/src/gfx/icon_util.h
   M /trunk/src/net/tools/dump_cache/cache_dumper.cc
   M /trunk/src/sandbox/src/job_unittest.cc
   M /trunk/src/sandbox/src/win_utils_unittest.cc

Implement most of the ridealong fixes/cleanups I suggested during review for enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2395001
------------------------------------------------------------------------
r48662 | denisromanov@chromium.org | 2010-06-01 23:19:47 +0200 (Tue, 01 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Changed update screen logic.
Any error during checking for update or updating returned OOBE wizard to network selection screen.
Now error checking for update causes the OOBE wizard to proceed to the login screen, and error updating - to the network selection screen.
BUG=cros:3676
TEST=Try to reproduce bug http://crosbug.com/3676. It should not reproduce.

Review URL: http://codereview.chromium.org/2470002
------------------------------------------------------------------------
r48660 | xiyuan@chromium.org | 2010-06-01 23:15:43 +0200 (Tue, 01 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/input_window_dialog_gtk.cc

Put more dialogs into chrome window.

- Bookmark entry editor;
- GtkInputWindowDialog;
- Cert manager and viewer;
- Task manager;

BUG=None.
TEST=Verify bookmark new/rename folder, add page, task manager, cert manager and viewer are inside a chrome window.

Review URL: http://codereview.chromium.org/2472003
------------------------------------------------------------------------
r48658 | jcivelli@chromium.org | 2010-06-01 23:08:33 +0200 (Tue, 01 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/base/keyboard_code_conversion_gtk.cc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Pressing the search button brings the NTP or close it if it is opened.
Note: this requires the WebKit https://bugs.webkit.org/show_bug.cgi?id=39752
to work.

BUG=3404
TEST=See bug.

Review URL: http://codereview.chromium.org/2260004
------------------------------------------------------------------------
r48656 | arv@chromium.org | 2010-06-01 23:02:44 +0200 (Tue, 01 Jun 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

TBR:
------------------------------------------------------------------------
r48652 | akalin@chromium.org | 2010-06-01 22:33:18 +0200 (Tue, 01 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/common/net/notifier/DEPS
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc

Converted TalkMediator to use a delegate instead of a channel

Simplified handling of TalkMediator events.

BUG=none
TEST=unittests + manual testing of notifications

Review URL: http://codereview.chromium.org/2232004
------------------------------------------------------------------------
r48650 | wtc@chromium.org | 2010-06-01 22:28:03 +0200 (Tue, 01 Jun 2010) | 14 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/nss_util.cc
   M /trunk/src/build/all.gyp
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   D /trunk/src/net/third_party/nss/nss.gyp
   A /trunk/src/net/third_party/nss/ssl.gyp (from /trunk/src/net/third_party/nss/nss.gyp:48533)

Use SSLClientSocketNSS on Mac OS X. By default, chrome still uses
SSLClientSocketMac. Specify the --use-nss-for-ssl command-line
option to use SSLClientSocketNSS.

The nss.gyp in src/net/third_party/nss is renamed ssl.gyp to avoid
a naming conflict with the nss.gyp in src/third_party/nss. The
GYP generator for Xcode project files disallows same-named .gyp files.

SSL client authentication doesn't work yet.

R=mark
BUG=30689
TEST=No build and test failures on Mac and Windows.
Review URL: http://codereview.chromium.org/2322008
------------------------------------------------------------------------
r48649 | estade@chromium.org | 2010-06-01 22:23:38 +0200 (Tue, 01 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/test/data/valgrind/ui_tests.gtest_linux.txt

Only disable UnloadTest.BrowserCloseTabWhenOtherTabHasListener under valgrind

(leave it enabled on non-valgrind Linux)

BUG=45562
TEST=green tree

Review URL: http://codereview.chromium.org/2428002
------------------------------------------------------------------------
r48647 | sky@chromium.org | 2010-06-01 22:17:26 +0200 (Tue, 01 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Makes side tabs render phantom state and close button when not
hovered.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2234008
------------------------------------------------------------------------
r48646 | jrg@chromium.org | 2010-06-01 21:56:25 +0200 (Tue, 01 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable UnloadTest.BrowserCloseTabWhenOtherTabHasListener
Makes Linux valgrind unhappy

http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(4)/builds/5866/steps/valgrind%20test:%20ui/logs/stdio

BUG=http://crbug.com/45562
TBR=jungshik@chromium.org

Review URL: http://codereview.chromium.org/2417003
------------------------------------------------------------------------
r48644 | gspencer@chromium.org | 2010-06-01 21:28:34 +0200 (Tue, 01 Jun 2010) | 8 lines
Changed paths:
   M /trunk/src/base/auto_reset.h
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/web_database_observer_impl.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/ipc/ipc_channel_win.cc
   M /trunk/src/views/focus/focus_util_win.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/webkit/appcache/appcache_database.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc

Fixing AutoReset to be a template.

I've run into a couple of times this week when I needed one of these, for two different types besides bool.  Time to fix the TODO.

TEST=trybots FTW, and built locally.
BUG=none

Review URL: http://codereview.chromium.org/2394001
------------------------------------------------------------------------
r48641 | chocobo@chromium.org | 2010-06-01 19:54:36 +0200 (Tue, 01 Jun 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/notification_battery_low.png
   D /trunk/src/chrome/app/theme/notification_low_battery.png
   A /trunk/src/chrome/app/theme/notification_network_failed.png
   A /trunk/src/chrome/app/theme/notification_network_open.png
   A /trunk/src/chrome/app/theme/notification_network_warning.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/chromeos/network_message_observer.cc
   A /trunk/src/chrome/browser/chromeos/network_message_observer.h
   M /trunk/src/chrome/chrome_browser.gypi

Added notification for network message.
BUG=chromium-os:2556
TEST=manually connect to network with wrong password and see notification.
Review URL: http://codereview.chromium.org/2074017
------------------------------------------------------------------------
r48639 | nshkrob@chromium.org | 2010-06-01 19:23:56 +0200 (Tue, 01 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   A /trunk/src/chrome/browser/history/top_sites_database.cc
   M /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Adding an SQLite database for TopSites.

BUG=None
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2249004
------------------------------------------------------------------------
r48638 | jcivelli@google.com | 2010-06-01 18:58:49 +0200 (Tue, 01 Jun 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc

Cleaning up the node focus notification.
The notification that the focus changed in the page now uses webkit::WebViewClient::focusedNodeChanged() implemented by RenderView.

It was previously relying on the more general webkit::WebWidgetClient::didFocus() implemented in RenderWidget. (that should ideally only be fired when the frame gets focused, not everytime the focus in the frame changes).

BUG=None
TEST=Interactive UI tests should still pass (especially BrowserFocus*)

Review URL: http://codereview.chromium.org/2301001
------------------------------------------------------------------------
r48636 | joth@chromium.org | 2010-06-01 18:07:32 +0200 (Tue, 01 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_2_38_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_2_94_wrapper_linux.cc
   M /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.cc
   M /trunk/src/chrome/common/geoposition.h

Now arbitration is supported (r48631) enable GPS.
Also updated GPS timestamp's to be based on the host machine's own clock (avoids clock drift affecting freshness calculation) and updated Geoposition's docs to clarify this.

BUG=43868
TEST=Run gpsfake nmea.nme, then ./out/Debug/chrome-wrapper --log-level=1 http://maps.google.com/maps/m (map follows GPS track)

Review URL: http://codereview.chromium.org/2438003
------------------------------------------------------------------------
r48635 | nkostylev@google.com | 2010-06-01 17:28:28 +0200 (Tue, 01 Jun 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/login_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/mock_login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.cc
   M /trunk/src/chrome/browser/chromeos/login/new_user_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Implement browse without sign in mode.
Mount tmpfs, start new session for incognito user.

Session manager change
http://codereview.chromium.org/2419001

BUG= http://crosbug.com/2849
TEST=Open BWSI mode.

Review URL: http://codereview.chromium.org/2371001
------------------------------------------------------------------------
r48634 | phajdan.jr@chromium.org | 2010-06-01 16:30:51 +0200 (Tue, 01 Jun 2010) | 7 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard.h
   M /trunk/src/base/base.gypi
   A /trunk/src/base/gtest_prod_util.h
   M /trunk/src/base/pickle.h
   M /trunk/src/base/version.h
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/views/generic_info_view.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/webdata/web_database.h

[GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacement
that works with all test prefixes (DISABLED, FLAKY, FAILS).

TEST=none
BUG=44549

Review URL: http://codereview.chromium.org/2439001
------------------------------------------------------------------------
r48631 | joth@chromium.org | 2010-06-01 15:30:01 +0200 (Tue, 01 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.h

Implement location arbitration (kudos to previous internal projects this is lifted from)

BUG=38509
TEST=GeolocationLocationArbitratorTest.Arbitration

Review URL: http://codereview.chromium.org/2376001
------------------------------------------------------------------------
r48628 | pfeldman@chromium.org | 2010-06-01 12:20:14 +0200 (Tue, 01 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

DevTools: inspector settings are now serialized into map, not a string
WebKit roll 60462:60647

Original review: http://codereview.chromium.org/2422001

Review URL: http://codereview.chromium.org/2459002
------------------------------------------------------------------------
r48627 | satorux@chromium.org | 2010-06-01 12:02:38 +0200 (Tue, 01 Jun 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Add Filipino and Spanish Latin America to Languages and Input dialog

As far as I've studied from the web, there seems to be no standard
keyboard layout for Filipino, and XKB does not have keybouard layouts
for Filipino. For now, associate Filipino with the US keyboard layout
as tt seems that US keyboard layout is widely used.

BUG=chromium-os:3644 3689
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/2456001
------------------------------------------------------------------------
r48625 | satorux@chromium.org | 2010-06-01 11:35:38 +0200 (Tue, 01 Jun 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Fix Remove button in Languages and Input dialog, and a crash bug in the dialog

- Users should not be able to remove a language that is set to the UI language
- Users should not be able to disable all input methods in Languages and Input dialog
- Languages and Input dialog should not crash even when there is no language

Along the way, associate Indonesian with the US keyboard.
This is nicer than showing "Display Chromium OS in this language" only.

BUG=chromium-os:3686 3687
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/2420002
------------------------------------------------------------------------
r48620 | yurys@chromium.org | 2010-06-01 09:10:31 +0200 (Tue, 01 Jun 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h

DevTools: disable Scripts panel if remote debugging is enabled

Review URL: http://codereview.chromium.org/2429001
------------------------------------------------------------------------
r48619 | zork@chromium.org | 2010-06-01 09:05:43 +0200 (Tue, 01 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   A /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/language_chewing_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add Chewing options window

BUG=chromium-os:2624
TEST=Open the IME settings window.  Add Traditional Chinese.  Check that there is an options dialog next to Chewing, and click on it.

Review URL: http://codereview.chromium.org/2421001
------------------------------------------------------------------------
r48614 | tfarina@chromium.org | 2010-06-01 03:57:43 +0200 (Tue, 01 Jun 2010) | 6 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util_deprecated.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc

Remove deprecated file_util::ReplaceExtension API.

BUG=24672
TEST=out/Debug/base_unittests

Review URL: http://codereview.chromium.org/2445001
------------------------------------------------------------------------
r48612 | satorux@chromium.org | 2010-06-01 02:53:18 +0200 (Tue, 01 Jun 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Re-enable the offset computation logic for the vertical candidate window.

The problem with the original change was that it didn't call
in GetHorizontalOffset() in OnSetLocationCursor().

Outside web contetns in Chrome, UpdateLookupTable signal is
followed by SetLocationCursor signal. This caused:

1. OnUpdateLookupTable() to move the candidate window
   with the offset computed
2. Then OnSetLocationCursor() to move the candidate window
   without the offset.

This resulted in a flicker of the candidate window.

BUG=chromium-os:2720
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/2423001
------------------------------------------------------------------------
r48603 | yusukes@google.com | 2010-05-31 16:03:33 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Support Indonesian UI.

BUG=chromium-os:3643
TEST=manually

Review URL: http://codereview.chromium.org/2425001
------------------------------------------------------------------------
r48600 | zork@chromium.org | 2010-05-31 14:38:57 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc

Fix test expectations for language tooltips.

BUG=none
TEST=run browser_tests

Review URL: http://codereview.chromium.org/2426001
------------------------------------------------------------------------
r48597 | avayvod@google.com | 2010-05-31 13:04:04 +0200 (Mon, 31 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   M /trunk/src/chrome/browser/chromeos/login/user_image_loader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h

Added cp service parameter to ClientLogin authentication.
Use received auth token to get user image from Contacts API.

BUG=cros:2347
TEST=Verify that correct user image is downloaded on login and shown on consequent login.

Review URL: http://codereview.chromium.org/2222007
------------------------------------------------------------------------
r48595 | zork@chromium.org | 2010-05-31 13:01:32 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc

Add Cangjie layout name.

BUG=chromium-os:3428
TEST=Open the IME config menu, check that cangjie has a readable name.

Review URL: http://codereview.chromium.org/2412001
------------------------------------------------------------------------
r48587 | jochen@chromium.org | 2010-05-31 09:58:26 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Initialize CookiesTreeModel with a cookie monster instead of a profil.

BUG=45230
TEST=unit_tests

Review URL: http://codereview.chromium.org/2369001
------------------------------------------------------------------------
r48586 | jochen@chromium.org | 2010-05-31 09:55:51 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/resources/history.html

Use seperate consumers for search and query requests.

BUG=41005
TEST=as described in the bug

Review URL: http://codereview.chromium.org/2322005
------------------------------------------------------------------------
r48584 | tfarina@chromium.org | 2010-05-31 05:28:50 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc

Remove more occurrences of FromWStringHack from code base.

BUG=24672
TEST=trybots

Review URL: http://codereview.chromium.org/2401001
------------------------------------------------------------------------
r48583 | zork@chromium.org | 2010-05-31 03:50:32 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

Change the IME config dialog to present a list of checkboxes instead of radio buttons.

BUG=chromium-os:2538
TEST=Open the IME config dialog.  Select a language with multiple input types.  Try to select more than one.

Review URL: http://codereview.chromium.org/2221005
------------------------------------------------------------------------
r48581 | tfarina@chromium.org | 2010-05-31 03:08:10 +0200 (Mon, 31 May 2010) | 6 lines
Changed paths:
   M /trunk/src/base/registry.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc

Remove deprecated versions of Registry functions.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2403001
------------------------------------------------------------------------
r48577 | tfarina@chromium.org | 2010-05-30 15:57:35 +0200 (Sun, 30 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h

windows: Move mouse pointer automatically to the default button in a dialog box.

BUG=2811
TEST=open gmail account, click on "Empty trash messages", the mouse should goes
automatically to the default "OK" button.

Review URL: http://codereview.chromium.org/1550009
------------------------------------------------------------------------
r48568 | tfarina@chromium.org | 2010-05-30 04:20:07 +0200 (Sun, 30 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   A /trunk/src/chrome/browser/location_bar_util.cc
   A /trunk/src/chrome/browser/location_bar_util.h
   M /trunk/src/chrome/browser/views/location_bar/selected_keyword_view.cc
   M /trunk/src/chrome/browser/views/location_bar/selected_keyword_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Share common location bar functions across the 3 platforms that uses them.

BUG=None
TEST=compiles, and everything should works as before.

Review URL: http://codereview.chromium.org/2125020
------------------------------------------------------------------------
r48558 | sanjeevr@chromium.org | 2010-05-29 09:18:29 +0200 (Sat, 29 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/printing/print_settings.cc
   M /trunk/src/printing/print_settings.h
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printed_document_mac.cc
   M /trunk/src/printing/printed_document_win.cc

Changed printer page setup units to be in device co-ordinates (this is pixels on Windows and points on the Mac). Also fixed a bug with Mac dpi calculation.
BUG=None.
TEST=Test printing on Windows and Mac.

Review URL: http://codereview.chromium.org/2351003
------------------------------------------------------------------------
r48544 | gspencer@chromium.org | 2010-05-29 01:48:08 +0200 (Sat, 29 May 2010) | 35 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

This tunes up some of the snapshot creation code.

Includes:

- Makes it so that the PaintAtSize message does what it should do:
  render the page at the size given and then scale (in the render
  process) the result to the desired size.

- Changed some of the timeouts for updating snapshots to help with
  performance

- Reduced the number of cases where we refresh snapshots in response
  to tabs changing.

- Removed the need to force updates whenever we switch to overview
  mode, which makes it faster, and avoids the "shuffling" effect.

- Started listening to TAB_CONTENTS_CONNECTED in order to detect new
  browsers, instead of BROWSER_WINDOW_READY, because there were still
  times when the tab contents didn't have any dimensions by the time
  BROWSER_WINDOW_READY was sent.  This helps fix the bug referenced
  below.

- Stopped updating snapshots in active mode.  Now we just invalidate
  the snapshots and render them when we enter overview mode.

- Added a parameter to indicate whether we prefer using the backing
  store or not when asking for snapshots from the thumbnail generator.

- Added tracking of a timestamp for events from the window manager so
  we can avoid racing.

TEST=ran in chromeos under WM and verified snapshot contents
BUG=chromium-os:3142, 3136
Review URL: http://codereview.chromium.org/2098006
------------------------------------------------------------------------
r48542 | michaeln@chromium.org | 2010-05-29 01:37:20 +0200 (Sat, 29 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h

Defend against messages being received prior to having been initialized.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2321002
------------------------------------------------------------------------
r48541 | davemoore@chromium.org | 2010-05-29 01:35:17 +0200 (Sat, 29 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_widget.cc

Enabled mousewheel coalescing to work better for ChromeOS.
This was important because the browser process couldn't keep up
with the input stream, resulting in poor 2 finger scroll
behavior. It's now tuned to the settings in cros.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/2239001
------------------------------------------------------------------------
r48540 | sky@chromium.org | 2010-05-29 01:28:02 +0200 (Sat, 29 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Adds enabling of experimental menu.

TBR=oshima@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2376002
------------------------------------------------------------------------
r48533 | mattm@chromium.org | 2010-05-29 00:22:44 +0200 (Sat, 29 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_mac.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/test/data/valgrind/ui_tests.gtest.txt
   M /trunk/src/chrome/test/in_process_browser_test.cc

ProcessSingleton(all): create the lock immediately after failing to connect to an existing process.
ProcessSingletonLinux: if creating the lock fails, try to notify again.

BUG=44417
TEST=manual

Review URL: http://codereview.chromium.org/2066014
------------------------------------------------------------------------
r48531 | sky@chromium.org | 2010-05-28 23:45:47 +0200 (Fri, 28 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Adds side tab layout for chromeos. As part of this I renamed the
compact location bar menu to experimental and place both items
there. The two are mutually exclusive, so toggling one untoggles the
other. Also makes the status bubble not overlap the tabstrip for side tabs.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2340001
------------------------------------------------------------------------
r48528 | michaeln@chromium.org | 2010-05-28 23:26:36 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Initialize an unititialized data member that valgrind noticed for us.

BUG=45261
TEST=none

Review URL: http://codereview.chromium.org/2319001
------------------------------------------------------------------------
r48522 | erg@chromium.org | 2010-05-28 22:46:00 +0200 (Fri, 28 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK: Fix padding of the page/app menus.

In r47478, I removed the hbox that the page and app menus were in because I
though that with the new left/right toolbar boxes, they were unnecessary.
But they're needed to group the two buttons together with no space between
them, but with padding on the right.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2375002
------------------------------------------------------------------------
r48517 | eroman@chromium.org | 2010-05-28 22:09:30 +0200 (Fri, 28 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/main.js

Change the default tab on net-internals from "requests" to "data".

(This way don't need to give separate instructions on bug reports depending on what version of chrome they are using, can still just say "copy dump from about:net-internals")

Review URL: http://codereview.chromium.org/2365002
------------------------------------------------------------------------
r48514 | asargent@chromium.org | 2010-05-28 22:02:16 +0200 (Fri, 28 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.js

Fix ability to add sub-menu items with extension context menu API.

BUG=45157
TEST=Try adding a context menu item with the chrome.experimental.contextMenu 
API, and then adding another one whose parentId is set to the id of the first 
one. This should now succeed. 

Review URL: http://codereview.chromium.org/2296002
------------------------------------------------------------------------
r48505 | zelidrag@chromium.org | 2010-05-28 20:42:03 +0200 (Fri, 28 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

File browser crash fix.

BUG=3650
TEST=none


Review URL: http://codereview.chromium.org/2343002
------------------------------------------------------------------------
r48503 | mpcomplete@chromium.org | 2010-05-28 19:45:33 +0200 (Fri, 28 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   A /trunk/src/chrome/browser/extensions/extension_omnibox_api.cc
   A /trunk/src/chrome/browser/extensions/extension_omnibox_api.h
   A /trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/views/location_bar/keyword_hint_view.cc
   M /trunk/src/chrome/browser/views/location_bar/keyword_hint_view.h
   M /trunk/src/chrome/browser/views/location_bar/selected_keyword_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/examples/api/omnibox
   A /trunk/src/chrome/common/extensions/docs/examples/api/omnibox/background.html
   A /trunk/src/chrome/common/extensions/docs/examples/api/omnibox/manifest.json
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/omnibox
   A /trunk/src/chrome/test/data/extensions/api_test/omnibox/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/omnibox/test.html

First pass at experimental omnibox API. There are plenty of rough edges and features to work on, but it's in a usable state.

When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later.

I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout
the omnibox code.

BUG=38884

Review URL: http://codereview.chromium.org/2078021
------------------------------------------------------------------------
r48499 | erg@chromium.org | 2010-05-28 19:04:23 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

GTK: Mixed content scheme should be gray.

BUG=45271
TEST=none

Review URL: http://codereview.chromium.org/2343001
------------------------------------------------------------------------
r48498 | erg@chromium.org | 2010-05-28 19:02:17 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK: More signal macro usage.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2345002
------------------------------------------------------------------------
r48491 | phajdan.jr@chromium.org | 2010-05-28 17:57:21 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h

Linux: use web application meta tags for application shortcuts where possible.

TEST=none
BUG=45124

Review URL: http://codereview.chromium.org/2263005
------------------------------------------------------------------------
r48487 | glotov@chromium.org | 2010-05-28 17:30:20 +0200 (Fri, 28 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   A /trunk/src/chrome/test/data/new_account.html

Introduces cros:// schema for web-page to chrome communication in ChromeOS.
Add test that verifies web-page to chrome communication.

BUG=cros/3177
TEST=out/Debug/browser_tests --gtest_filter=AccountScreenTest.TestSchemeInspector

Review URL: http://codereview.chromium.org/2291002
------------------------------------------------------------------------
r48485 | avi@chromium.org | 2010-05-28 16:57:54 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   M /trunk/src/chrome/browser/configuration_policy_provider_win.h
   M /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc

Rename class to comply with style guide. Tweak comments for grammar and correctness.

BUG=none
TEST=n/a

Review URL: http://codereview.chromium.org/2273003
------------------------------------------------------------------------
r48484 | darin@chromium.org | 2010-05-28 16:55:53 +0200 (Fri, 28 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   A /trunk/src/chrome/common/pepper_plugin_registry.cc (from /trunk/src/chrome/renderer/pepper_plugin_registry.cc:48155)
   A /trunk/src/chrome/common/pepper_plugin_registry.h (from /trunk/src/chrome/renderer/pepper_plugin_registry.h:48155)
   M /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   D /trunk/src/chrome/renderer/pepper_plugin_registry.cc
   D /trunk/src/chrome/renderer/pepper_plugin_registry.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/webkit/glue/plugins/pepper_webplugin_impl.cc
   M /trunk/src/webkit/glue/plugins/pepper_webplugin_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_page_delegate.h
   M /trunk/src/webkit/support/test_webplugin_page_delegate.h
   M /trunk/src/webkit/support/webkit_support.cc
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Add ppapi plugins to about:plugins

Querying the plugin path and actual mime type is moved from creation of the
WebPluginDelegate to creation of the WebPlugin.  This cleaned up some code.

R=jam
BUG=45289
TEST=none
Review URL: http://codereview.chromium.org/2262002
------------------------------------------------------------------------
r48473 | denisromanov@chromium.org | 2010-05-28 11:20:09 +0200 (Fri, 28 May 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/customization_document.cc
   A /trunk/src/chrome/browser/chromeos/customization_document.h
   A /trunk/src/chrome/browser/chromeos/customization_document_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   A /trunk/src/chrome/browser/chromeos/testdata
   A /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Re-landing mistakenly reverted CL http://codereview.chromium.org/2101021.

Adding initial implementation of the PartnerCustomization classes.

BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome --login-manager --startup-manifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.
TBR=avayvod

Review URL: http://codereview.chromium.org/2333004
------------------------------------------------------------------------
r48472 | zork@chromium.org | 2010-05-28 09:54:25 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc

Add localized values for keyboard layouts.

BUG=none
TEST=Select a language with keyboard layouts in the IME option window.

Review URL: http://codereview.chromium.org/2309001
------------------------------------------------------------------------
r48470 | hbono@chromium.org | 2010-05-28 08:29:33 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ime_input.cc
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Cancels an ongoing IME composition when receiving an IME_CANCEL_COMPOSITION event on Windows.
This change just adds ImeInput::CancelIME() and use it when receiving an IME_CANCEL_COMPOSITION event. (I'm not sure it works well with all IMEs, though.)

BUG=9883
TEST=none
Review URL: http://codereview.chromium.org/2099012
------------------------------------------------------------------------
r48459 | oshima@chromium.org | 2010-05-28 04:43:04 +0200 (Fri, 28 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

landing chaitanya's patch

Adding accessibility setting to System options

Review URL: http://codereview.chromium.org/2127014
------------------------------------------------------------------------
r48456 | chron@chromium.org | 2010-05-28 03:48:11 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator.cc
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator.h
   M /trunk/src/chrome/common/net/gaia/gaia_authenticator_unittest.cc
   D /trunk/src/chrome/common/net/gaia/signin.h
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc

Remove signin and persist from gaia_authenticator. This fixes an issue where Chromium OS did not persist sync cookies.

TEST=included unit tests
BUG=http://crosbug.com/2786

Review URL: http://codereview.chromium.org/2124020
------------------------------------------------------------------------
r48454 | estade@chromium.org | 2010-05-28 03:40:10 +0200 (Fri, 28 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

TBR: Fix OS_WINDOWS to OS_WIN.

The bad macro caused the test to be wrongly enabled on windows.
------------------------------------------------------------------------
r48444 | ctguil@chromium.org | 2010-05-28 01:00:03 +0200 (Fri, 28 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/accessibility/view_accessibility.h
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.h
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/client_view.cc
   M /trunk/src/views/window/client_view.h
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Initial work to fix the IAccessible tree in circumstances where there is a widget not at the root of the UI heirarchy.  Also contains misc fixes for setting correct name/role for controls found in the Options dialog.
BUG=9621
TEST=none
Review URL: http://codereview.chromium.org/2174002
------------------------------------------------------------------------
r48442 | estade@chromium.org | 2010-05-28 00:43:38 +0200 (Fri, 28 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc

Retry r48417.

Disable UnloadTest.BrowserCloseTabWhenOtherTabHasListener on windows because it is failing.

BUG=45281
TEST=tree is green

Review URL: http://codereview.chromium.org/2279006
------------------------------------------------------------------------
r48441 | michaeln@chromium.org | 2010-05-28 00:43:19 +0200 (Fri, 28 May 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_webapplicationcachehost_impl.cc
   M /trunk/src/webkit/appcache/appcache_backend_impl.cc
   M /trunk/src/webkit/appcache/appcache_backend_impl.h
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Fully connect the dots between workers and appcache resource loading.

* Split WorkerService CreateWorker into distinct methods for 'shared' vs 'dedicated' workers.

* Include additional appcache params in WorkerService CreateSharedWorker and CreateDedicatedWorker methods.

* Store those additional params in WorkerInstance object.

* Pass those additional params to the worker process.

* Use those additional params when initiating the appcache host for the worker when calling SelectCacheForWorker and SelectCacheForSharedWorker.

* Add browser process message handlers and dispatching for the SelectCacheForWorker and SelectCacheForSharedWorker IPC messages.

* Runtime enable the appcache feature in the worker processes.

BUG=39368
TEST=manual for now, but i need to create layout tests for this

Review URL: http://codereview.chromium.org/2238001
------------------------------------------------------------------------
r48439 | thakis@chromium.org | 2010-05-28 00:18:43 +0200 (Fri, 28 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Mac: Let download shelf slide out to bottom instead of just clamping its height.

Review URL: http://codereview.chromium.org/2303002
------------------------------------------------------------------------
r48438 | rvargas@google.com | 2010-05-28 00:06:31 +0200 (Fri, 28 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/view_http_cache_job_factory.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/view_cache_helper.cc
   M /trunk/src/net/url_request/view_cache_helper.h
   A /trunk/src/net/url_request/view_cache_helper_unittest.cc

view-cache: Refactor ViewCacheHelper and ViewHttpCacheJobFactory
to use asynchronous interfaces.

BUG=26730
TEST=unittest


Review URL: http://codereview.chromium.org/2168004
------------------------------------------------------------------------
r48437 | estade@chromium.org | 2010-05-28 00:05:13 +0200 (Fri, 28 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Inform the command updater of the tab restore state.

BUG=14428
TEST=TabRestoreUITest.*

Review URL: http://codereview.chromium.org/2228004
------------------------------------------------------------------------
r48435 | jhawkins@chromium.org | 2010-05-27 23:49:27 +0200 (Thu, 27 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Make SSLUITest.TestHTTPSExpiredCertAndDontProceed flaky for mac and linux, and disabled for windows.

Contributed by tessamac@chromium.org

BUG=43575
TEST=none

Review URL: http://codereview.chromium.org/2224004
------------------------------------------------------------------------
r48434 | andybons@chromium.org | 2010-05-27 23:31:30 +0200 (Thu, 27 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

[Mac] Fixes a bug where uninstalling visible extensions when others are hidden would leave blank spaces instead of re-arranging the remaining ones.

BUG=42792
TEST=Manual
Review URL: http://codereview.chromium.org/2286003
------------------------------------------------------------------------
r48433 | jrg@chromium.org | 2010-05-27 23:18:33 +0200 (Thu, 27 May 2010) | 38 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc

Revert 48417 - More test enabling.

 RedirectTest.ClientServerServer passes locally so I'm trying reenabling it.
 file a bug for RedirectTest.ClientCancelledByNewNavigationAfterProvisionalLoad .
 file a bug for SessionHistoryTest.CrossFrameFormBackForward
 mark SessionHistoryTest.LocationReplace as failing rather than disabled
 fix UnloadTest.BrowserCloseTabWhenOtherTabHasListener (the popup was being caught by the popup blocker)

TEST=buildbots
BUG=12913

Review URL: http://codereview.chromium.org/2264001

TBR=estade@chromium.org




Looks like UnloadTest.BrowserCloseTabWhenOtherTabHasListener still unhappy on bot?

http://buildbot.jail.google.com/buildbot/chromium/builders/XP%20Tests/builds/20319/steps/ui_tests/logs/stdio

[----------] Global test environment tear-down
[==========] 315 tests from 72 test cases ran. (1089094 ms total)
[  PASSED  ] 308 tests.
[  FAILED  ] 7 tests, listed below:
[  FAILED  ] MouseLeaveTest.FLAKY_TestOnMouseOut
[  FAILED  ] HistoryTester.FAILS_VerifyHistoryLength2
[  FAILED  ] HistoryTester.FAILS_VerifyHistoryLength3
[  FAILED  ] WorkerTest.FLAKY_WorkerHttpLayoutTests
[  FAILED  ] UnloadTest.BrowserCloseTabWhenOtherTabHasListener
[  FAILED  ] SessionHistoryTest.FAILS_LocationReplace
[  FAILED  ] SessionHistoryTest.FLAKY_HistorySearchXSS




Review URL: http://codereview.chromium.org/2225009
------------------------------------------------------------------------
r48430 | mbelshe@chromium.org | 2010-05-27 22:32:06 +0200 (Thu, 27 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/net/base/load_states.h
   M /trunk/src/net/http/http_network_transaction.cc

Change the proxy waiting-for message to:
    "Waiting for proxy tunnel..."
Add a message for waiting for the SSL Handshake to complete:
    "Establishing secure connection..."
Also make the waiting messages work for SPDY connections.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2262003
------------------------------------------------------------------------
r48429 | dhollowa@chromium.org | 2010-05-27 22:24:46 +0200 (Thu, 27 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager_unittest.cc

AutoFill <dl> label scraping and dynamic html in forms.

The mcphee.com site demonstrates two issues.  One is label scraping for forms that use <dl> <dt> and <dd> elements to partition labels and input elements.  The other is dynamic html where JavaScript is used to manipulate the form elements dynamically as the user proceeds through checkout.  These changes address both.  Label scraping is implemented for <dl> <dt> and <dd> elements.  Form filling, both at the FormManager and AutoFillManager levels are now more robust in the face of changing form structure between the time of page load and form fill.

This does not "fix" the mcphee page though, as we still do not fill the elements that are added to the page after the initial page load.

BUG=44323
TEST=AutoFillManagerTest.FormChangesRemoveField, AutoFillManagerTest.FormChangesAddField, FormManagerTest.LabelsInferredFromTableCellNested, FormManagerTest.LabelsInferredFromDefinitionList, FormManagerTest.FillFormChangedFormDataFields, manual tests using mphee.html and mcphee2.html sample files attached to bug report and original bug steps using live mcphee checkout.

Review URL: http://codereview.chromium.org/2240004
------------------------------------------------------------------------
r48428 | jrg@chromium.org | 2010-05-27 22:03:32 +0200 (Thu, 27 May 2010) | 32 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/customization_document.cc
   D /trunk/src/chrome/browser/chromeos/customization_document.h
   D /trunk/src/chrome/browser/chromeos/customization_document_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   D /trunk/src/chrome/browser/chromeos/testdata
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 48424 - Adding initial implementation of the PartnerCustomization classes.

BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome loginmanager startupmanifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.

Review URL: http://codereview.chromium.org/2101021

TBR=denisromanov@chromium.org


Build error below.  I don't immediately see how this CL caused the
problem, but the only other things on the blamelist are valgrind
suppressions which don't change code.

Linking...
LINK : warning LNK4224: /OPT:NOWIN98 is no longer supported;  ignored
   Creating library C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\npchrome_frame.lib and object C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\npchrome_frame.exp
chrome_tab.obj : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
chrome_frame_ie.lib(chrome_active_document.obj) : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
chrome_frame_npapi.lib(utils.obj) : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
C:\b\slave\chromium-rel-builder\build\src\build\Release\servers\npchrome_frame.dll : fatal error LNK1120: 1 unresolved externals

Error executing link.exe (tool returned code: 1120)
 
2 build system warning(s):
   - VS settings folder not found
   - Interoperability reenabled
 



Review URL: http://codereview.chromium.org/2224008
------------------------------------------------------------------------
r48424 | denisromanov@chromium.org | 2010-05-27 21:44:53 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/customization_document.cc
   A /trunk/src/chrome/browser/chromeos/customization_document.h
   A /trunk/src/chrome/browser/chromeos/customization_document_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   A /trunk/src/chrome/browser/chromeos/testdata
   A /trunk/src/chrome/browser/chromeos/testdata/startup_manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adding initial implementation of the PartnerCustomization classes.

BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome --login-manager --startup-manifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.

Review URL: http://codereview.chromium.org/2101021
------------------------------------------------------------------------
r48420 | eroman@chromium.org | 2010-05-27 21:37:45 +0200 (Thu, 27 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/main.js

net-internals: Display a "(P)" beside entries which were passively logged. This should help reduce confusion when reading logs that have a mixture of passive and actively captured events (since there may have been some loss of information along the boundaries).

Review URL: http://codereview.chromium.org/2094020
------------------------------------------------------------------------
r48417 | estade@chromium.org | 2010-05-27 21:21:15 +0200 (Thu, 27 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc

More test enabling.

- RedirectTest.ClientServerServer passes locally so I'm trying re-enabling it.
- file a bug for RedirectTest.ClientCancelledByNewNavigationAfterProvisionalLoad .
- file a bug for SessionHistoryTest.CrossFrameFormBackForward
- mark SessionHistoryTest.LocationReplace as failing rather than disabled
- fix UnloadTest.BrowserCloseTabWhenOtherTabHasListener (the popup was being caught by the popup blocker)

TEST=buildbots
BUG=12913

Review URL: http://codereview.chromium.org/2264001
------------------------------------------------------------------------
r48416 | estade@chromium.org | 2010-05-27 21:18:18 +0200 (Thu, 27 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc

Re-enable some disabled tests that pass locally.

Can't be sure these aren't flaky, but surely they should not be DISABLED.

BUG=21321,14731,19394

Review URL: http://codereview.chromium.org/2230002
------------------------------------------------------------------------
r48415 | estade@chromium.org | 2010-05-27 21:12:59 +0200 (Thu, 27 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h

Enable passing unload tests on Linux.

Also make one execute significantly faster.

BUG=45021
TEST=they pass consistently

Review URL: http://codereview.chromium.org/2296001
------------------------------------------------------------------------
r48413 | jshin@chromium.org | 2010-05-27 20:48:35 +0200 (Thu, 27 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Fix two incorrect uses of string conversion to/from ASCII when strings in
questions can contain non-ASCII characters. 

They lead the error message to be garbled and an non-ASCII path to turn
empty. 

BUG=44145,45009
TEST=See bugs

Review URL: http://codereview.chromium.org/2148004
------------------------------------------------------------------------
r48405 | dpolukhin@chromium.org | 2010-05-27 19:44:03 +0200 (Thu, 27 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_chromeos.cc
   D /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   D /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   D /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/login/login_screen.cc (from /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc:48303)
   A /trunk/src/chrome/browser/chromeos/login/login_screen.h (from /trunk/src/chrome/browser/chromeos/login/login_manager_view.h:48303)
   A /trunk/src/chrome/browser/chromeos/login/login_screen_browsertest.cc (from /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc:48303)
   A /trunk/src/chrome/browser/chromeos/login/new_user_view.cc (from /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc:48303)
   A /trunk/src/chrome/browser/chromeos/login/new_user_view.h (from /trunk/src/chrome/browser/chromeos/login/login_manager_view.h:48303)
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Refactoring of LoginManagerView in two separate classes NewUserView and LoginScreen.
NewUserView will be reused for other user login on images login screen.

TEST=No visible changes.
BUG=crosbug.com/2320

Review URL: http://codereview.chromium.org/2253004
------------------------------------------------------------------------
r48404 | lzheng@chromium.org | 2010-05-27 19:35:25 +0200 (Thu, 27 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.h


Enable the spdy A/B test for SxS installations. npn_with_http and npn_with_spdy 
will be enabled at 50% of chance.

BUG=45022
TEST=Use command-line flag --chrome-sxs to force the browser as SxS, go to gmail.com,
login/logout, check about:histograms, you should see xx_spdytrial_xxx histograms.

Review URL: http://codereview.chromium.org/2188001
------------------------------------------------------------------------
r48403 | oshima@chromium.org | 2010-05-27 19:32:01 +0200 (Thu, 27 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_host.cc

Allow a profile without extension service to show notification.
 ChromeOS needs to be able to show notification before a user logged in (such as battery, update notification).
 Currently, all attempt to show notification results in crash because BalloonHost assume all profile has
 extension service, which is not the case for login profile that ChromeOS uses.

 John, I didn't ifdef'ed because BalloonHost is not assuming extension_function_dispacher is allways present.
 Please let me now if I should limit this change to OS_CHROMEOS.

BUG=http://crosbug.com/3491
TEST=none

Review URL: http://codereview.chromium.org/2221003
------------------------------------------------------------------------
r48401 | erg@chromium.org | 2010-05-27 19:12:04 +0200 (Thu, 27 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK: Redo button tints in GTK+ mode.

Use separate tints for icons in the omnibox and the other icons like page/app menu. We don't pick the tinting color to be the skyline accent color, but instead create one based off the accent color and the contrast between the window background and the label color.

BUG=43853
TEST=1) Darklooks should have white icons (both the page icons and in the omnibox) 2) DarkRoom should have page/app menu icons that match the label color on the "Other Bookmarks" button while the icons in the omnibox which are on a white background should visually be more orange and contrast with the white. 3) Ambiance/Radiance should have icons that contrast with their background instead of fading into it. 4) New Wave should have dark rust orange instead of light neon orange (again, contrasting with the background).

Review URL: http://codereview.chromium.org/2266004
------------------------------------------------------------------------
r48400 | mad@google.com | 2010-05-27 19:07:12 +0200 (Thu, 27 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

GetEnabledExtensions should also return Loaded Extensions.

We use to not need them since we would simply overinstall them all the time.
But now that overinstall is allowed and reset the extension state (e.g., close and reopen the background page), we can't simply install exploded extensions at will anymore, we must first check if it was already installed or not (which means GetEnabledExtensions must return them) and only install them when they are not already there.

BUG=0
TEST=none

Review URL: http://codereview.chromium.org/2303004
------------------------------------------------------------------------
r48395 | mbelshe@chromium.org | 2010-05-27 17:38:07 +0200 (Thu, 27 May 2010) | 8 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/app/win/window_impl.h
   M /trunk/src/base/crypto/scoped_capi_types.h
   M /trunk/src/base/event_trace_consumer_win_unittest.cc
   M /trunk/src/base/event_trace_controller_win_unittest.cc
   M /trunk/src/base/event_trace_provider_win_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/iat_patch.cc
   M /trunk/src/base/lock_impl_win.cc
   M /trunk/src/base/scoped_bstr_win_unittest.cc
   M /trunk/src/base/thread_local.h
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/installer/util/l10n_string_util.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/function_stub_unittest.cc
   M /trunk/src/chrome_frame/html_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/exception_barrier_unittest.cc
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc
   M /trunk/src/chrome_frame/test/util_unittests.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/gfx/icon_util.cc
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/tools/dump_cache/cache_dumper.cc
   M /trunk/src/net/tools/dump_cache/upgrade.cc
   M /trunk/src/sandbox/src/file_policy_test.cc
   M /trunk/src/sandbox/src/interception_unittest.cc
   M /trunk/src/sandbox/src/job_unittest.cc
   M /trunk/src/sandbox/src/restricted_token_unittest.cc
   M /trunk/src/sandbox/src/win_utils_unittest.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc

Enable warning 4389 as an error on windows builds. This will make 
windows builds more similar to linux/mac, which already treat signed/ 
unsigned equality comparisons as warnings (and hence errors). 

BUG=44471
TEST=none 

Review URL: http://codereview.chromium.org/2222002
------------------------------------------------------------------------
r48394 | stuartmorgan@chromium.org | 2010-05-27 17:34:14 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_win_uitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Add a bug link to DISABLED_WorkerLifecycle, and change StartupRaceCondition to FAILS

BUG=38572,45168
TEST=N/A

Review URL: http://codereview.chromium.org/2280005
------------------------------------------------------------------------
r48393 | joth@chromium.org | 2010-05-27 17:26:18 +0200 (Thu, 27 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   A /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.cc
   A /trunk/src/chrome/browser/geolocation/gps_location_provider_linux.h
   A /trunk/src/chrome/browser/geolocation/libgps_2_38_wrapper_linux.cc
   A /trunk/src/chrome/browser/geolocation/libgps_2_94_wrapper_linux.cc
   A /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.cc
   A /trunk/src/chrome/browser/geolocation/libgps_wrapper_linux.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/chrome_browser.gypi

First cut at GPS support in chrome linux

Uses libgps / gpsd to get gps fixes. Modified the location arbitrator to use GPS instead of network location provider.
Current version requires manual code edit to enable (ENABLE_LIBGPS_LOCATION_PROVIDER)  See http://docs.google.com/View?id=dfbnm49n_1g8ktswhr for demo instructions (work in progress)

BUG=43868
TEST=Built with ENABLE_LIBGPS_LOCATION_PROVIDER and used gpsd's gpsfake script (see linked doc above)

Review URL: http://codereview.chromium.org/2032010
------------------------------------------------------------------------
r48392 | jochen@chromium.org | 2010-05-27 17:21:00 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc

Allow for non-HTTP schemes in URLs to OSDD entries.

BUG=45203
TEST=as described in the bug

Review URL: http://codereview.chromium.org/2265003
------------------------------------------------------------------------
r48390 | sky@chromium.org | 2010-05-27 16:54:49 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Makes unpinning a phantom tab close it.

BUG=45050
TEST=see bug

Review URL: http://codereview.chromium.org/2285001
------------------------------------------------------------------------
r48389 | sky@chromium.org | 2010-05-27 16:54:15 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/sidetabs_new_tab.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/tabs/base_tab.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab.h
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Adds the new tab button to side tabs.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2224003
------------------------------------------------------------------------
r48388 | davemoore@chromium.org | 2010-05-27 16:52:11 +0200 (Thu, 27 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Increase default mouse speed sensitivity
BUG=chromium-os:3601
TEST=Log in as new user, confirm mouse is faster
(can check with "synclient -l" on the command line...MaxSpeed
should be "1")

TBR:chocobo

Review URL: http://codereview.chromium.org/2296003
------------------------------------------------------------------------
r48387 | jorlow@chromium.org | 2010-05-27 16:41:27 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   M /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.h

Handle IDBDatabase sync calls.
Remove modify_database flag.
Make sure we delete data structures on the WebKit thread.
Handle single process mode.

Review URL: http://codereview.chromium.org/2125017
------------------------------------------------------------------------
r48385 | bulach@chromium.org | 2010-05-27 14:36:39 +0200 (Thu, 27 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm
   D /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.cc
   D /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.h
   D /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model_unittest.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.cc (from /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.cc:48372)
   A /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model.h (from /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.h:48372)
   A /trunk/src/chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc (from /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model_unittest.cc:48372)
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.h
   M /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.cc
   M /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Renames GeolocationContentSettingsTableModel to GeolocationExceptionsTableModel
TEST=Compiles
BUG=40286

Review URL: http://codereview.chromium.org/2069016
------------------------------------------------------------------------
r48382 | yurys@chromium.org | 2010-05-27 14:01:36 +0200 (Thu, 27 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h

DevTools: implement WebDevToolsAgentClient::WebKitClientMessageLoop. Also make sure that devtools client is detached from devtools agent if inspected render view is closing. It is necessary because render thread may be blocked by a script staying on a breakpoint in which case close message will never be dispatched(close message is posted as a non nestable task so it cannot be processed in the message loop in ScriptDebugServer).

Review URL: http://codereview.chromium.org/2238002
------------------------------------------------------------------------
r48371 | mnissler@chromium.org | 2010-05-27 10:21:54 +0200 (Thu, 27 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/importer/profile_writer.cc
   M /trunk/src/chrome/browser/pref_member.cc
   M /trunk/src/chrome/browser/pref_member.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Update UI, sync and importer to properly handle managed homepage prefs

The change in Preferences.xib binds the homepage options container's enabled state to the new property PreferencesWindowController.IsHomepageManaged

BUG=43423
TEST=Manual, especially homepage options on general page of options dialog

Review URL: http://codereview.chromium.org/2059001
------------------------------------------------------------------------
r48369 | finnur@chromium.org | 2010-05-27 08:29:27 +0200 (Thu, 27 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/upgrade_detector.cc

Fix warning: Unused variable.

TBR=ananta
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2225006
------------------------------------------------------------------------
r48368 | finnur@chromium.org | 2010-05-27 08:21:58 +0200 (Thu, 27 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/upgrade_detector.cc

Make sure the upgrade notification only happens on the official build, not on Chromium.

TBR=ben
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2282005
------------------------------------------------------------------------
r48367 | ananta@chromium.org | 2010-05-27 08:21:28 +0200 (Thu, 27 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Attempt 2 at landing this as this broke ui_tests on linux.

The desktop notification service infobar would not display in ChromeFrame rendered pages as the code assumed the existing of a BrowserList
and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab
contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913

Bug=44913


Review URL: http://codereview.chromium.org/2266005
------------------------------------------------------------------------
r48365 | oshima@chromium.org | 2010-05-27 08:05:36 +0200 (Thu, 27 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc

Don't shrink notification.
 * There is a known issue where notification gets resized repeatedly.
   This generates a lot of X/WM events which fills up message loop, and eventually cause freeze.
   This CL fixes the flickering and freeze caused by above issue.
   (See chrome/browser/notifications/balloon_collection.cc)
   The resize issue will be tracked and fixed separately.
Correctly shutdown notificatino UI when browser exits.
 * When restoring session, browser emits BROWSER_CLOSED notification and there is no last active window,
   and BalloonCollectionImpl was incorrectly shutting down    NotificationUI.

BUG=chromium-os:3410
TEST=manual: no freeze when calendar notification is shown.

Review URL: http://codereview.chromium.org/2307001
------------------------------------------------------------------------
r48364 | akalin@chromium.org | 2010-05-27 07:49:31 +0200 (Thu, 27 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/plainsaslhandler.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/prexmppauth.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/saslhandler.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.h

Recombined buzz::PreXmppAuth and buzz::SaslHandler to be compatible
with upstream libjingle again.

Changed GaiaOnlySaslHandler to GaiaTokenPreXmppAuth to match
libjingle changes.

BUG=none
TEST=made sure sync worked with an @google.com account.

Review URL: http://codereview.chromium.org/2221004
------------------------------------------------------------------------
r48363 | finnur@chromium.org | 2010-05-27 07:27:26 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/upgrade_detector.cc

Add initialization for a member variable.

TEST=None
BUG=None
TBR=huanr
Review URL: http://codereview.chromium.org/2283004
------------------------------------------------------------------------
r48357 | thakis@chromium.org | 2010-05-27 05:14:02 +0200 (Thu, 27 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm

Whitespace change to cycle testers.

Review URL: http://codereview.chromium.org/2224006
------------------------------------------------------------------------
r48355 | sky@chromium.org | 2010-05-27 04:46:15 +0200 (Thu, 27 May 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Fixes a couple of tab related bugs:

. When to resize tabs during close didn't match old behavior. In
  particular because of unload handlers I can't track whether the
  close was user initiated but instead need to set a flag when the
  user initiates it and reset it later on.
. When the user initiates a close if the tab is already closed I
  should start closing the next tab. This matches what the old code
  does and allows users to rapdily click the middle button to close a
  bunch of tabs.
. For user initiated closes the animation should preserve existing
  bounds, otherwise things may shift around by a pixel or so.

BUG=44785 44782 44781
TEST=make sure tab animations work smoothly, especially when removing tabs

Review URL: http://codereview.chromium.org/2145005
------------------------------------------------------------------------
r48354 | tonyg@chromium.org | 2010-05-27 04:43:20 +0200 (Thu, 27 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Revert 48348 - Broke ui_tests on linux.

The desktop notification service infobar would not display in ChromeFrame rendered pages as the code assumed the existing of a BrowserList
and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab
contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913

Bug=44913


Review URL: http://codereview.chromium.org/2294002

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/2222005
------------------------------------------------------------------------
r48353 | satorux@chromium.org | 2010-05-27 04:35:38 +0200 (Thu, 27 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Widen the preferred language table in the "Languages and Input".

The change is for fixng trauncation that occurs with German.

BUG=chromium-os:3356
TEST=manually

Review URL: http://codereview.chromium.org/2220004
------------------------------------------------------------------------
r48352 | scherkus@chromium.org | 2010-05-27 04:07:27 +0200 (Thu, 27 May 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/chat_manager/128.png
   A /trunk/src/chrome/browser/resources/chat_manager/24.png
   A /trunk/src/chrome/browser/resources/chat_manager/32.png
   A /trunk/src/chrome/browser/resources/chat_manager/48.png
   M /trunk/src/chrome/browser/resources/chat_manager/background.html
   M /trunk/src/chrome/browser/resources/chat_manager/central_roster_viewer.html
   D /trunk/src/chrome/browser/resources/chat_manager/js/centralrosterhook.js
   M /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgeeventtypes.js
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi

Modified chat manager extension to become an app extension.

Patch by seh@chromium.org:
http://codereview.chromium.org/2249001/show

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2252004
------------------------------------------------------------------------
r48348 | ananta@chromium.org | 2010-05-27 03:33:04 +0200 (Thu, 27 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

The desktop notification service infobar would not display in ChromeFrame rendered pages as the code assumed the existing of a BrowserList
and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab
contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913

Bug=44913


Review URL: http://codereview.chromium.org/2294002
------------------------------------------------------------------------
r48347 | jhawkins@chromium.org | 2010-05-27 03:09:30 +0200 (Thu, 27 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc

Disable ExtensionOverrideTest.OverrideHistory on Windows, because it's consistenly hanging.

TBR=rafaelw
BUG=45173
TEST=ExtensionOverrideTest.OverrideHistory

Review URL: http://codereview.chromium.org/2240006
------------------------------------------------------------------------
r48346 | mrossetti@chromium.org | 2010-05-27 02:55:17 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Check for bookmark bar visibility before showing any deletion animations.

BUG=44967
TEST=1) Hide bookmark bar. 2) Show bookmark manager. 3) Delete a bookmark which would show on the bookmark bar. 4) Verify no 'poof' occurs. 5) Type an URL into the omnibox. 6) Click on the Star to bookmark. 7) Press the 'Remove' button. 8) Verify no 'poof' occurs. 9) Show the bookmark bar. 10) Delete a bookmark which shows on the bookmark bar. 11) Verify that the 'poof' animation occurs.

Review URL: http://codereview.chromium.org/2294001
------------------------------------------------------------------------
r48345 | viettrungluu@chromium.org | 2010-05-27 02:47:56 +0200 (Thu, 27 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc

Slight cleanup of some first-run/master-prefs stuff.

- let AddFirstRunNewTabs() run as elsewhere on Mac (the list of first-run tabs
  will be empty)
- move various #if defined(OS_MACOSX) stuff to (existing!) Mac-specific files
  instead
- remove an essentially-unused argument to FirstRun::ProcessMasterPreferences()
  (the location of the master prefs was never specified, so the standard
  location was always used)

BUG=none
TEST=everything still works

Review URL: http://codereview.chromium.org/2077025
------------------------------------------------------------------------
r48344 | rvargas@google.com | 2010-05-27 02:47:47 +0200 (Thu, 27 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h

net-internals: use the async interface for displaying cache statistics.

BUG=26729
TEST=none

Review URL: http://codereview.chromium.org/2279003
------------------------------------------------------------------------
r48335 | sky@chromium.org | 2010-05-27 00:11:07 +0200 (Thu, 27 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc

Changes session restore so that if the last tab is closed explicitly
(control-w, middle click ...) the tab is not restored. OTOH if the
user closes the window, then the tab is restored.

BUG=4923
TEST=turn on session restore and close the last tab by clicking the
tab close button, it shouldn't be restored. Then close the last window
with one tab by way of alt-f4 (or clicking the window close button)
and make sure the tab is restored.

Review URL: http://codereview.chromium.org/2251002
------------------------------------------------------------------------
r48330 | finnur@chromium.org | 2010-05-26 23:44:19 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

ExtApps: Show the bookmark bar again on NTP (except inside the App Launcher panel).

BUG=44077
TEST=Bookmark bar should always be visible on the NTP if extension apps are disabled (default) and should be visible if attached when extension apps are enabled.

Review URL: http://codereview.chromium.org/2225004
------------------------------------------------------------------------
r48327 | jam@chromium.org | 2010-05-26 23:35:42 +0200 (Wed, 26 May 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc

Disable internal plugin on all platforms by default.
Review URL: http://codereview.chromium.org/2291003
------------------------------------------------------------------------
r48321 | jcivelli@chromium.org | 2010-05-26 22:52:18 +0200 (Wed, 26 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Enabling default apps in officials ChromeOS builds so that the app launcher is not empty.

BUG=None
TEST=Start an official ChromeOS build, open the NTP.
     GMail, Calendar and Docs should be available as apps.

Review URL: http://codereview.chromium.org/2237003
------------------------------------------------------------------------
r48318 | finnur@chromium.org | 2010-05-26 22:11:54 +0200 (Wed, 26 May 2010) | 30 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/app_menu_model.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/upgrade_detector.cc
   A /trunk/src/chrome/browser/upgrade_detector.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   A /trunk/src/chrome/browser/views/update_recommended_message_box.cc
   A /trunk/src/chrome/browser/views/update_recommended_message_box.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/test_browser_window.h

Implement upgrade notifications.

When we detect that the installed version is newer than the version you are
running we show a little throbbing orange dot over the wrench menu.

If you open the wrench menu and close it again, the throbbing will stop.

However, if you look at the contents of the wrench menu you'll notice that
the About box menu item has been removed and in its place is a menu item
"Update Chrome Now" with a bright orange icon to draw your attention to it.

Clicking on the icon shows a dialog box asking whether you want to restart
Chrome. If you do, the browser restarts with your session restored 
(even if you have Session Restore turned off).

Known issues:

- Currently this is Windows only. We'll have to port this to Linux and do
something differnet for Mac (which doesn't have the wrench menu).

- Showing an icon in front of Update Chrome causes the checkbox for the
bookmark bar menu to go away. Given that we will soon redesign the menus I'm
not going to spend much time trying to fix it.

BUG=27941
TEST=Wait for Chrome to be upgraded in the background, an orange dot should
appear over the wrench menu and if you select Update Chrome your session should
be retained.

Review URL: http://codereview.chromium.org/2225003
------------------------------------------------------------------------
r48316 | mrossetti@chromium.org | 2010-05-26 22:09:18 +0200 (Wed, 26 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.mm

Resize the "For quick access..." and "Import bookmarks now..." components shown in the bookmark bar when there are no bookmarks in the bar, when the window resizes. Show ellipses when each gets trimmed and hide them when they get too small.

BookmarkBar.xib changes: Connect the "Import bookmarks now..." button up to the importBookmarksButton_ outlet in the BookmarkBarView.

BUG=32557
TEST=1) Start up a browser with no bookmarks on the bookmarks bar.
2) Verify that the "For quick access..." and "Import bookmarks now..." test fully shows.
3) Start shrinking the width of the browser window.
4) Verify that the "Import bookmarks now..." text is shrunk/clipped and finally disappears as the window gets narrower.
5) Continue shrinking the width and verify that the "For quick access..." text is shrunk/clipped with ellipses as the window gets narrower.
6) Grow the window and verify that the "For quick access..." reappears and then the "Import book now..." does.

Review URL: http://codereview.chromium.org/2243002
------------------------------------------------------------------------
r48303 | rafaelw@chromium.org | 2010-05-26 21:01:56 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sanity_uitest.cc

spelling error FLAKEY->FLAKY. EarlyReturnTest.ToastCrasher

BUG=45115
TBR=jhawkins

Review URL: http://codereview.chromium.org/2249003
------------------------------------------------------------------------
r48302 | stuartmorgan@chromium.org | 2010-05-26 20:59:46 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Switch hanging session restore tests from FAILS to RESTORE

TBR=mark

BUG=45108
TEST=Greener Mac UI test bots.

Review URL: http://codereview.chromium.org/2238003
------------------------------------------------------------------------
r48298 | dpolukhin@chromium.org | 2010-05-26 20:46:38 +0200 (Wed, 26 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/browser/chromeos/login/web_page_view.cc
   M /trunk/src/chrome/browser/chromeos/login/web_page_view.h

Fix leak of CreateWizardBorder instance in WebPageView.
WizardBorder won't paint border it will be done by WizardPainter, WizardBorder will provide only insets.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2281002
------------------------------------------------------------------------
r48297 | stuartmorgan@chromium.org | 2010-05-26 20:21:39 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Enable the SessionRestoreUITest tests on the Mac

Changes the shutdown type in the test on the Mac, since closing the last window (the default) destroys the session on the Mac. Marks two tests that fail consistently accordingly.

BUG=45108
TEST=SessionRestoreUITest tests should run.

Review URL: http://codereview.chromium.org/2280002
------------------------------------------------------------------------
r48296 | jabdelmalek@google.com | 2010-05-26 20:17:48 +0200 (Wed, 26 May 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/renderer/pepper_scrollbar_widget.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_mac.mm

Get the internal plugin working on Mac.
Review URL: http://codereview.chromium.org/2271002
------------------------------------------------------------------------
r48295 | tonyg@chromium.org | 2010-05-26 20:17:35 +0200 (Wed, 26 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable TestStepOut and TestStepIn on win because they timeout.

r48279 did this for TestStepOver, but all of the TestStep* tests are timing out
on win, not just TestStepOver.

TEST=DevToolsSanityTest.TestStep*
BUG=45080

Review URL: http://codereview.chromium.org/2240003
------------------------------------------------------------------------
r48294 | xiyuan@chromium.org | 2010-05-26 20:15:11 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/web_applications/web_app.cc

Allow "chrome-extension://" to be used as web app url.

BUG=29201
TEST=Verify a web app shortcut for "chrome-extension://" url could be created.

Review URL: http://codereview.chromium.org/2193002
------------------------------------------------------------------------
r48292 | sky@chromium.org | 2010-05-26 20:09:59 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes visual glitch in new tab animation.

BUG=44780
TEST=see bug

Review URL: http://codereview.chromium.org/2226002
------------------------------------------------------------------------
r48288 | pkasting@chromium.org | 2010-05-26 19:44:19 +0200 (Wed, 26 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

Clamp the location bar font's height so it doesn't overflow the bar, even if the user has enormous standard fonts.

BUG=43268
TEST=Set your system fonts to enormous sizes.  Type in the location bar.  The font should be small enough to fit.
Review URL: http://codereview.chromium.org/2132027
------------------------------------------------------------------------
r48287 | pkasting@chromium.org | 2010-05-26 19:42:53 +0200 (Wed, 26 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Use some built-in methods on the Font object to avoid storing so many data members on the AutocompleteEdit.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2182002
------------------------------------------------------------------------
r48286 | rafaelw@chromium.org | 2010-05-26 19:33:04 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sanity_uitest.cc

Marking EarlyReturnTest.ToastCrasher as flaky

BUG=45115
TBR=cpu

Review URL: http://codereview.chromium.org/2234004
------------------------------------------------------------------------
r48283 | erg@chromium.org | 2010-05-26 19:05:48 +0200 (Wed, 26 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Clean up calls like "gfx::Rect(0, 0, size().width(), size().height()".

The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect
has a constructor that just takes a Size.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2204001
------------------------------------------------------------------------
r48282 | ctguil@chromium.org | 2010-05-26 18:59:21 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Fix TestRendererAccessibilityTree test.

Update role check to reflect recent accessibility changes.

BUG=44546
TEST=none

Review URL: http://codereview.chromium.org/2243003
------------------------------------------------------------------------
r48281 | arv@chromium.org | 2010-05-26 18:51:10 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/css/button.css

Add an inset border to the action button.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2248001
------------------------------------------------------------------------
r48279 | tonyg@chromium.org | 2010-05-26 18:46:05 +0200 (Wed, 26 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevToolsSanityTest.TestStepOver needs to be disabled (not just marked FLAKY)
because it is timing out rather than failing.

BUG=45080
TEST=DevToolsSanityTest.TestStepOver

Review URL: http://codereview.chromium.org/2263004
------------------------------------------------------------------------
r48273 | joth@chromium.org | 2010-05-26 16:41:57 +0200 (Wed, 26 May 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc

Fix for 44892: use scoped_array to avoid leak
------------------------------------------------------------------------
r48270 | mhm@chromium.org | 2010-05-26 14:55:19 +0200 (Wed, 26 May 2010) | 10 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h

Invalid URLs are no longer mangled when reopening the Options window.

If the homepage URL is changed to an invalid URL, the homepage preference is swapped to a blank URL and NTP is shown.

BUG=40996
TEST=Set homepage to http://www.google.com, close Chromium, restart Chromium and see homepage set to http://www.google.com. Set homepage to http://, close Chromium, restart Chromium and see homepage set to New Tab Page.

Patch by Jared Wein <weinjared@gmail.com>

Review URL: http://codereview.chromium.org/2102019
------------------------------------------------------------------------
r48269 | pam@chromium.org | 2010-05-26 14:53:54 +0200 (Wed, 26 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Mark tests as flaky based on recent buildbot runs.
Windows: three tests in DevToolsSanityTest
Mac: one in ExtensionBrowserTest

TBR=tonyg

BUG=45079, 45080
TEST=covered by buildbots

Review URL: http://codereview.chromium.org/2258003
------------------------------------------------------------------------
r48261 | ctguil@chromium.org | 2010-05-26 11:23:57 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Re-enabling TestChromeWindowAccObj.

This test appears to be passing fine in interactive_ui_tests.

BUG=44486
TEST=none
TBR=dmazzoni@chromium.org

------------------------------------------------------------------------
r48257 | yusukes@google.com | 2010-05-26 08:25:20 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Change language name for Cangjie and Quick input methods from zh to zh-TW

BUG=chromium-os:2540
TEST=ran the unittest

Review URL: http://codereview.chromium.org/2229002
------------------------------------------------------------------------
r48247 | mad@google.com | 2010-05-26 05:17:15 +0200 (Wed, 26 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.h

Propagate a change made to a base class virtual method.

rev 47972 made a modification to a virtual method signature but the derived class in these file wasn't updated. Now it is...

And I also did a few lint fixes.

BUG=0
TEST=Testing alone isn't enough, sometimes a code search is safer!

Review URL: http://codereview.chromium.org/2200002
------------------------------------------------------------------------
r48243 | yusukes@google.com | 2010-05-26 04:39:30 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   A /trunk/src/chrome/browser/chromeos/status/language_menu_button_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add tooltip to the language indicator.

When UI locale is set to US, "Hebrew: Standard input method" would be shown for the Hebrew input method, and "Japanese: Google Japanese Input" for Japanese.

BUG=chromium-os:2539
TEST=manually

Review URL: http://codereview.chromium.org/2178002
------------------------------------------------------------------------
r48242 | satorux@chromium.org | 2010-05-26 04:22:08 +0200 (Wed, 26 May 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Fix a bug that caused some Chinese characters be shown at lower positions.

For some reason, Chinese characters like 时 \u65F6 are shown at wrong
positions lower than it should be (see the screenshot in crosbug.com/2303).

The root cause seemed be that pango_layout_get_pixel_size() returned
larger height values for certain characters, but hopefully, I found that
we can fix the rendering weirdness by changing the grid layout alighment.

Along the way, change the logging behavior from APPEND_TO_OLD_LOG_FILE
to DELETE_OLD_LOG_FILE, as appending causes more confusion than it helps.

BUG=chromium-os:2303
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/2254001
------------------------------------------------------------------------
r48238 | rafaelw@chromium.org | 2010-05-26 03:52:40 +0200 (Wed, 26 May 2010) | 15 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/app/win/window_impl.h
   M /trunk/src/base/crypto/scoped_capi_types.h
   M /trunk/src/base/event_trace_consumer_win_unittest.cc
   M /trunk/src/base/event_trace_controller_win_unittest.cc
   M /trunk/src/base/event_trace_provider_win_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/iat_patch.cc
   M /trunk/src/base/lock_impl_win.cc
   M /trunk/src/base/scoped_bstr_win_unittest.cc
   M /trunk/src/base/thread_local.h
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/installer/util/l10n_string_util.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/function_stub_unittest.cc
   M /trunk/src/chrome_frame/html_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/exception_barrier_unittest.cc
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc
   M /trunk/src/chrome_frame/test/util_unittests.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/gfx/icon_util.cc
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/tools/dump_cache/cache_dumper.cc
   M /trunk/src/net/tools/dump_cache/upgrade.cc
   M /trunk/src/sandbox/src/file_policy_test.cc
   M /trunk/src/sandbox/src/interception_unittest.cc
   M /trunk/src/sandbox/src/job_unittest.cc
   M /trunk/src/sandbox/src/restricted_token_unittest.cc
   M /trunk/src/sandbox/src/win_utils_unittest.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc

Revert "Another dependency the bbot missed!!!"

This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98.

Revert "Missed a file as part of checkin for r48186"

This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b.

Revert "Enable warning 4389 as an error on windows builds.  This will make"

This reverts commit c78936bcfc65b98edf288191d927a495b0364621.

TBR=mbelshe

Review URL: http://codereview.chromium.org/2253001
------------------------------------------------------------------------
r48231 | feldstein@chromium.org | 2010-05-26 02:18:44 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/shared/css/button.css
   M /trunk/src/chrome/chrome_browser.gypi

Add styling for buttons.

Adds the CSS that follows roma's button design.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2159004
------------------------------------------------------------------------
r48230 | estade@chromium.org | 2010-05-26 02:12:42 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

GTK: add NULL check in StatusBubbleGtk to fix crasher.

I couldn't actually repro the crash and after inspecting the code, I'm not sure why it's occuring. The only possibility seems that the status bubble widget is getting unparented at some point (probably shutdown). This check matches checks elsewhere in StatusBubbleGtk.

BUG=44971
TEST=none

Review URL: http://codereview.chromium.org/2199001
------------------------------------------------------------------------
r48229 | zelidrag@chromium.org | 2010-05-26 02:08:54 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h

Added new chromeos-specific values for bug type dropdown in user feedback dialog.  Removed system info checkbox, fixed alignment of the link.

BUG=chromium-os:3564
TEST=open the feedback/bug report dialog, check the new values in the dropdown 
 
Review URL: http://codereview.chromium.org/2220001
------------------------------------------------------------------------
r48227 | ctguil@chromium.org | 2010-05-26 02:04:32 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Re-enabling TestAboutChromeViewAccObj.

This test appears to be passing fine in interactive_ui_tests.

BUG=44486
TEST=none
TBR=dmazzoni@chromium.org

------------------------------------------------------------------------
r48226 | ctguil@chromium.org | 2010-05-26 02:00:27 +0200 (Wed, 26 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Fix flakyness of browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj

Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible.

BUG=44486
TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj 

Review URL: http://codereview.chromium.org/2092011
------------------------------------------------------------------------
r48224 | jhawkins@chromium.org | 2010-05-26 01:47:45 +0200 (Wed, 26 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc

Disable RenderViewHostManagerTest.ChromeURLAfterDownload because it hangs flakily in Windows.

TBR=tonyg
BUG=45040
TEST=none

Review URL: http://codereview.chromium.org/2240001
------------------------------------------------------------------------
r48220 | jhawkins@chromium.org | 2010-05-26 01:12:23 +0200 (Wed, 26 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Don't run the BrowserAppRefocusTests under Linux Views.

TBR=tonyg
BUG=43061
TEST=none

Review URL: http://codereview.chromium.org/2231001
------------------------------------------------------------------------
r48219 | nshkrob@chromium.org | 2010-05-26 01:04:41 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memory leaks in TopSites.

BUG=44979
TEST=TopSitesTest, memory.

Review URL: http://codereview.chromium.org/2178003
------------------------------------------------------------------------
r48211 | rafaelw@chromium.org | 2010-05-26 00:41:58 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/tabs.html

Prevent tabs.move from moving tabs to or from anything but normal (tabbed) windows

BUG=22651
TEST=NONE

Review URL: http://codereview.chromium.org/2173003
------------------------------------------------------------------------
r48210 | stuartmorgan@chromium.org | 2010-05-26 00:31:35 +0200 (Wed, 26 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Build unload_uitest.cc on the Mac, with a few of the tests disabled

Enables all the unload UI tests on the Mac that don't put up modal dialogs. Disables those
that do, and adds a tracking bug for them.
Also switches the hanging Linux test to DISABLED instead of not being compiled.

BUG=45021,45031
TEST=More tests run

Review URL: http://codereview.chromium.org/2202001
------------------------------------------------------------------------
r48207 | erg@chromium.org | 2010-05-26 00:05:01 +0200 (Wed, 26 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/renderer/render_view.cc

GTK: Invalidate the web content when we change system colors.

BUG=none
TEST=Change GTK+ theme while text is selected. The text selection colors
should change.

Review URL: http://codereview.chromium.org/2190001
------------------------------------------------------------------------
r48206 | jhawkins@chromium.org | 2010-05-26 00:01:59 +0200 (Wed, 26 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Fix build.  Duh mistake.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2212001
------------------------------------------------------------------------
r48203 | estade@chromium.org | 2010-05-25 23:50:09 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc

Don't let bookmark navigations change content of pinned tab.

This works for the bookmark bar + bookmark menus, but doesn't work for the bookmark manager. Fixing it for the bookmark manager is probably Not Easy.

BUG=29281
TEST=manual

Review URL: http://codereview.chromium.org/2128021
------------------------------------------------------------------------
r48202 | jhawkins@chromium.org | 2010-05-25 23:49:39 +0200 (Tue, 25 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

TTF: Re-enable BrowserAppRefocusTest.* tests on Linux, as the crashes are only happening on Mac.

TBR=stuartmorgan
BUG=42865
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/2185003
------------------------------------------------------------------------
r48197 | michaeln@chromium.org | 2010-05-25 23:15:31 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job.cc
   M /trunk/src/webkit/appcache/appcache_update_job.h
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Provide more info to the renderer process in appcache progress events.

BUG=39370
TEST= yes, updated unittests

Review URL: http://codereview.chromium.org/2166006
------------------------------------------------------------------------
r48195 | tonyg@chromium.org | 2010-05-25 23:11:58 +0200 (Tue, 25 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc

RestoreOnNewWindowWithNoTabbedBrowsers actually needs to be DISABLED_ not just
FAILS_ because it crashes.

BUG=39476
TEST=SessionRestoreTest.RestoreOnNewWindowWithNoTabbedBrowsers

Review URL: http://codereview.chromium.org/2194001
------------------------------------------------------------------------
r48193 | scottbyer@chromium.org | 2010-05-25 23:10:35 +0200 (Tue, 25 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_internal.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc

Fix cloud print dialog bug.
Add some unit tests, and fix the exposed issue - the cloud print dialog wasn't allowing the hosted code to close the window.

BUG=none
TEST=CloudPrintHtmlDialogDelegateTest

Review URL: http://codereview.chromium.org/2149007
------------------------------------------------------------------------
r48192 | nirnimesh@chromium.org | 2010-05-25 23:09:14 +0200 (Tue, 25 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   M /trunk/src/chrome/test/functional/browser.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Fetch a bunch of info from the browser

This includes info about the browser/renderer/extension/other PIDs, window size.

Add a method to set window size.
Add tests to verify window size, and verify flash loading.

BUG=43234
TEST=python chrome/test/functional/browser.py

Review URL: http://codereview.chromium.org/2133013
------------------------------------------------------------------------
r48191 | jhawkins@chromium.org | 2010-05-25 22:51:27 +0200 (Tue, 25 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h

Build fix: Update a FRIEND_TEST needed from r48189.

TBR=tonyg
BUG=none
TEST=none
------------------------------------------------------------------------
r48190 | xji@chromium.org | 2010-05-25 22:41:06 +0200 (Tue, 25 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Keyboard layout change inside DefWindowProc() in AutocompleteEditViewWin::HandleKeystroke(). Restore keyboard layout after DefWindowProc().

BUG=14049
TEST=open LTR and RTL chrome, type in pure Hebrew, pure English and bidi characters inside omnibox, press HOME/END/shift-HOME/shift-END, keyboard layout should not be changed.
Review URL: http://codereview.chromium.org/2143006
------------------------------------------------------------------------
r48189 | jhawkins@chromium.org | 2010-05-25 22:34:38 +0200 (Tue, 25 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc

TTF: Re-enable WebCacheManagerBrowserTest.CrashOnceOnly by marking it flaky.

TBR=stuartmorgan
BUG=15288
TEST=WebCacheManagerBrowserTest.CrashOnceOnly
------------------------------------------------------------------------
r48187 | jhawkins@chromium.org | 2010-05-25 22:25:02 +0200 (Tue, 25 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc

TTF: Re-enable RenderViewHostManagerTest.ChromeURLAfterDownload which was written for a bug that is now fixed.

TBR=stuartmorgan
BUG=14505
TEST=RenderViewHostManagerTest.ChromeURLAfterDownload
------------------------------------------------------------------------
r48186 | mbelshe@chromium.org | 2010-05-25 22:21:16 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/app/win/window_impl.h
   M /trunk/src/base/crypto/scoped_capi_types.h
   M /trunk/src/base/event_trace_consumer_win_unittest.cc
   M /trunk/src/base/event_trace_controller_win_unittest.cc
   M /trunk/src/base/event_trace_provider_win_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/iat_patch.cc
   M /trunk/src/base/lock_impl_win.cc
   M /trunk/src/base/scoped_bstr_win_unittest.cc
   M /trunk/src/base/thread_local.h
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/function_stub_unittest.cc
   M /trunk/src/chrome_frame/html_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/exception_barrier_unittest.cc
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc
   M /trunk/src/chrome_frame/test/util_unittests.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/gfx/icon_util.cc
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/tools/dump_cache/cache_dumper.cc
   M /trunk/src/net/tools/dump_cache/upgrade.cc
   M /trunk/src/sandbox/src/file_policy_test.cc
   M /trunk/src/sandbox/src/interception_unittest.cc
   M /trunk/src/sandbox/src/job_unittest.cc
   M /trunk/src/sandbox/src/restricted_token_unittest.cc
   M /trunk/src/sandbox/src/win_utils_unittest.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc

Enable warning 4389 as an error on windows builds.  This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).

BUG=44471
TEST=none

Review URL: http://codereview.chromium.org/2081007
------------------------------------------------------------------------
r48185 | jcivelli@chromium.org | 2010-05-25 22:13:54 +0200 (Tue, 25 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_unittest.cc

Bound checkingon TableView

Adding bound checking to View <-> Model methods to investigate unit-tests failures.
BUG=None
TEST=unit-tests should still pass

Review URL: http://codereview.chromium.org/2069019
------------------------------------------------------------------------
r48179 | zelidrag@chromium.org | 2010-05-25 21:48:39 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/bug_report_view.cc

Fixed dialog size due to description field height increase.

BUG=chromium-os:3350
TEST=open user feedback dialog, make sure that all fields are displayed properly

Review URL: http://codereview.chromium.org/2146002
------------------------------------------------------------------------
r48178 | chocobo@chromium.org | 2010-05-25 21:40:32 +0200 (Tue, 25 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/mock_login_utils.h

Auto-connect to Google-A when Google-A is available, set up with identity and certpath, set to auto-connect, and there is no ethernet connection.
This prevents the browser from starting up until the connection is made, failed, or times out within 15 seconds.
BUG=chromium-os:3262
TEST=manually try logging in and see that there's a wait while connecting to Google-A
Review URL: http://codereview.chromium.org/2147004
------------------------------------------------------------------------
r48176 | tonyg@chromium.org | 2010-05-25 21:35:58 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc

Marking RestoreOnNewWindowWithNoTabbedBrowsers as FAILS_ on non-Windows.

It was enabled in r48104, but fails on linux views dbg.

BUG=39476
TEST=SessionRestoreTest.RestoreOnNewWindowWithNoTabbedBrowsers 

Review URL: http://codereview.chromium.org/2165006
------------------------------------------------------------------------
r48173 | mbelshe@chromium.org | 2010-05-25 21:25:04 +0200 (Tue, 25 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/net/base/load_states.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h

Eliminate the establishing_tunnel_ internal state and move to explicit
states in the state machine for proxy tunnel establishment.

Original work from svandebo.

BUG=none
TEST=existing

Review URL: http://codereview.chromium.org/2101014
------------------------------------------------------------------------
r48166 | xiyuan@chromium.org | 2010-05-25 20:52:56 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc

Put "Add Language" dialog into chrome window on ChromeOS.

BUG=none
TEST=Go to "Options" -> "Under the hood" tab -> "Font and language" -> "Languages" tab -> "Add" to see "Add language" dialog and verify it has a window frame and not take up the whole screen.

Review URL: http://codereview.chromium.org/2135016
------------------------------------------------------------------------
r48162 | viettrungluu@chromium.org | 2010-05-25 19:08:42 +0200 (Tue, 25 May 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   D /trunk/src/chrome/browser/dom_ui/print_ui.cc
   D /trunk/src/chrome/browser/dom_ui/print_ui.h
   M /trunk/src/chrome/browser/history/history.cc
   D /trunk/src/chrome/browser/resources/print_tab.css
   D /trunk/src/chrome/browser/resources/print_tab.html
   D /trunk/src/chrome/browser/resources/print_tab.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc

Remove previous print preview work in preparation for new work.

The new work will take a very different approach (using a component extension,
similar to the bookmark manager).

This basically reverts the following commits:
- http://src.chromium.org/viewvc/chrome?view=rev&revision=20595
  (http://codereview.chromium.org/155067)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19918
  (http://codereview.chromium.org/155051)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19906
  (http://codereview.chromium.org/150207)

BUG=173
TEST=everything still builds

Review URL: http://codereview.chromium.org/2156003
------------------------------------------------------------------------
r48161 | sky@chromium.org | 2010-05-25 19:03:36 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/views/screen_gtk.cc

Fixes a couple of leaks in use of gdk_get_property.

BUG=44945
TEST=none

Review URL: http://codereview.chromium.org/2089024
------------------------------------------------------------------------
r48156 | georgey@chromium.org | 2010-05-25 18:48:01 +0200 (Tue, 25 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_number.cc
   M /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/browser/autofill/phone_number_unittest.cc

Fix for autofill crash (all systems) - created unit tests for all touched code as well.
BUG=44594
TEST=in the bug: the phone should be *empty* (or shorter than 3 characters) to cause the old crash.
Review URL: http://codereview.chromium.org/2066013
------------------------------------------------------------------------
r48153 | brettw@chromium.org | 2010-05-25 18:15:52 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc

Swap the check for "same page" navigations to happen after the check for "auto
subframes". Previously, we would check for SAME_PAGE first, which would catch
auto subframe navigations when there was a pending new navigation, which would
confuse the current navigation state.

TEST=covered by unit test
BUG=43967
Review URL: http://codereview.chromium.org/2180001
------------------------------------------------------------------------
r48152 | zelidrag@chromium.org | 2010-05-25 18:15:29 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bug_report_util.cc

Flipped feedback URL to production servers.

TEST=submit feedback from chrome, check production feedback UI for the submitted report
BUG=chromium-os:3463

Review URL: http://codereview.chromium.org/2153007
------------------------------------------------------------------------
r48149 | jcivelli@chromium.org | 2010-05-25 17:56:26 +0200 (Tue, 25 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Relanding 48042.

I reverted http://codereview.chromium.org/1986006 as part of that change, after talking with Ben and Aaron. (it breaks the UI tests on ChromeOS now that apps are enabled).

Disabling app launcher and enabling apps by default on ChromeOS .

BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
     app should be showing in there.

Review URL: http://codereview.chromium.org/2149003
------------------------------------------------------------------------
r48148 | pam@chromium.org | 2010-05-25 17:56:16 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Disable tests timing out or crashing on Vista, and flaky on XP.
Four tests in TaskManagerBrowserTest.* now disabled on Windows;
one test in NewTabUITest.* marked flaky on Windows.

BUG=44991, 45001
TEST=covered by buildbots (browser_tests and ui_tests)

Review URL: http://codereview.chromium.org/2157007
------------------------------------------------------------------------
r48146 | nkostylev@google.com | 2010-05-25 15:50:44 +0200 (Tue, 25 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/network_list.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h

Update welcome screen based on mocks.
- Wizard is proceed to the next screen once "Continue" button is clicked and selected network is connected.
- Preselect Ethernet if it's connected.
- Clear selection when encrypted network dialog has been cancelled.
- Ask for network selection when connection timed out.
- Support list of connected/connecting networks.

BUG=cros:3279, cros:3306
TEST=Welcome screen & network selection should work.

Review URL: http://codereview.chromium.org/2077019
------------------------------------------------------------------------
r48143 | jochen@chromium.org | 2010-05-25 13:21:26 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc

Always ask the user when adding a search engine from JS.

When adding a search provider from JS, and the autogenerated keyword clashes with an existing search engine, ask the user.

BUG=15060
TEST=as described in the bug

Review URL: http://codereview.chromium.org/2155001
------------------------------------------------------------------------
r48135 | satorux@chromium.org | 2010-05-25 11:32:38 +0200 (Tue, 25 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Add --logtofile option to candidate_window.

This will be used for debugging. To enable logging, we can modify
/usr/share/ibus/component/candidate_window.xml as follows.

-  <exec>/opt/google/chrome/candidate_window</exec>
+  <exec>/opt/google/chrome/candidate_window --logtofile=/tmp/log.cw</exec>

BUG=chromium-os:3395
TEST=manually

Review URL: http://codereview.chromium.org/2101020
------------------------------------------------------------------------
r48132 | satorux@chromium.org | 2010-05-25 10:07:18 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc

Sort language names in the "Languages and Input" dialog.

BUG=chromium-os:2563
TEST=wrote unit tests and manually

Review URL: http://codereview.chromium.org/2116012
------------------------------------------------------------------------
r48129 | yusukes@google.com | 2010-05-25 08:32:49 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc

Use localized string for Input method names in the text input config dialog.

BUG=chromium-os:3428
TEST=manually

Review URL: http://codereview.chromium.org/2168002
------------------------------------------------------------------------
r48128 | viettrungluu@chromium.org | 2010-05-25 07:43:11 +0200 (Tue, 25 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Mac: Make quitting from AppleScript more reliable.

For some reason, doing
  osascript -e 'tell application "Chromium" to quit'
wasn't resulting in our AE handler being called.

I decided that Cocoa's default handling for quitting would call [NSApp
terminate] in all cases anyway, which is exactly what we want.

BUG=44965
TEST=Make sure the above works. Make sure quitting by right-clicking on the Dock icon and selecting Quit works (that sends an aevt/quit, which was correctly handled before). Make sure that onbeforeunload handlers still prevent window closure and quitting (go to about:blank, enter 'javascript:window.onbeforeunload=function () { return "please stay"; }' in the Omnibox, choose to stay on the page when the dialog comes up).

Review URL: http://codereview.chromium.org/2154004
------------------------------------------------------------------------
r48119 | akalin@chromium.org | 2010-05-25 05:36:33 +0200 (Tue, 25 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/net/notifier/base/posix/time_posix.cc
   M /trunk/src/chrome/common/net/notifier/base/task_pump.cc
   M /trunk/src/chrome/common/net/notifier/base/task_pump.h
   D /trunk/src/chrome/common/net/notifier/base/time.h
   D /trunk/src/chrome/common/net/notifier/base/time_unittest.cc
   D /trunk/src/chrome/common/net/notifier/base/timer.cc
   D /trunk/src/chrome/common/net/notifier/base/timer.h
   D /trunk/src/chrome/common/net/notifier/base/win/time_win32.cc
   M /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.cc
   M /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.h
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.h
   A /trunk/src/chrome/common/net/notifier/communicator/login_connection_state.h
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h
   M /trunk/src/third_party/libjingle/files/talk/base/taskrunner.h

Made Login and AutoReconnect use base/timer.h.

Rewrote TaskPump to use Chrome message loops.

Removed now-unused notifier code.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2067021
------------------------------------------------------------------------
r48118 | scherkus@chromium.org | 2010-05-25 05:28:52 +0200 (Tue, 25 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json

Disabling chat_manager content scripts for mail.google.com domain.

BUG=none
TEST=none
TBR=seh

Review URL: http://codereview.chromium.org/2074026
------------------------------------------------------------------------
r48117 | tony@chromium.org | 2010-05-25 04:20:10 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc

When we get an IME_CANCEL_COMPOSITION event from the renderer,
clear the IME state in GTK+.

BUG=9883

Review URL: http://codereview.chromium.org/2110019
------------------------------------------------------------------------
r48116 | yusukes@google.com | 2010-05-25 04:18:36 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Do not #include obsolete header files.

BUG=none
TEST=checked the patched code can compile with libcros v35.

Review URL: http://codereview.chromium.org/2101018
------------------------------------------------------------------------
r48107 | erg@chromium.org | 2010-05-25 02:07:05 +0200 (Tue, 25 May 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK: Use label colors for our tinted buttons.

Decisions to tint the buttons the color of the selection color was made back
in the Hardy era, in a desire to match the Windows theming system, and this
worked OK with the themes as they were written at the time. In Lucid, this
means too light or too dark buttons. Instead of trying to match the
selection color, try to match the label color. This works well in all the
themes I've tried so far on Lucid.

This kind of sucks that it's not as colorful, but the buttons are now as
legible as text.

BUG=43853
TEST=none

Review URL: http://codereview.chromium.org/2159003
------------------------------------------------------------------------
r48106 | viettrungluu@chromium.org | 2010-05-25 02:02:58 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h

Remove some unneeded #includes.

BUG=none
TEST=everything builds

Review URL: http://codereview.chromium.org/2089025
------------------------------------------------------------------------
r48105 | tonyg@chromium.org | 2010-05-25 01:40:05 +0200 (Tue, 25 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc

Don't clear user_gesture_observed_ when navigating within a page.

This fixes a bug which incorrectly classifies client redirects following an in
page navigation as an auto navigation.

TEST=NavigationControllerTest.ClientRedirectAfterInPageNavigation
BUG=40395

Review URL: http://codereview.chromium.org/2077023
------------------------------------------------------------------------
r48104 | jhawkins@chromium.org | 2010-05-25 01:37:10 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc

TTF: Enable RestoreOnNewWindowWithNoTabbedBrowsers, as it seems to be working now.

BUG=39476
TEST=SessionRestoreTest.RestoreOnNewWindowWithNoTabbedBrowsers

Patch by Doug Muir <dmuir@google.com>.

Review URL: http://codereview.chromium.org/2063016
------------------------------------------------------------------------
r48103 | jhawkins@chromium.org | 2010-05-25 01:32:52 +0200 (Tue, 25 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc

TTF: Enable the FavIconPermission test, as it appears to be working.

BUG=41027
TEST=ExtensionApiTest.FavIconPermission

Patch by Doug Muir <dmuir@google.com>

Review URL: http://codereview.chromium.org/2132019
------------------------------------------------------------------------
r48099 | nshkrob@chromium.org | 2010-05-25 01:24:17 +0200 (Tue, 25 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   A /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Adding a mock database layer.
Testing support of storage in TopSites.

BUG=None
TEST=TopSitesTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48061
Review URL: http://codereview.chromium.org/2133011
------------------------------------------------------------------------
r48098 | ctguil@chromium.org | 2010-05-25 01:13:13 +0200 (Tue, 25 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Mark AccessibilityWinBrowserTest.TestRendererAccessibilityTree as FAILS.

BUG=44546
TEST=none
TBR=dmazzoni@chromium.org

------------------------------------------------------------------------
r48097 | jam@chromium.org | 2010-05-25 00:51:02 +0200 (Tue, 25 May 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc

Do case-insensitive checks for the plugin paths in case a user has different shortcuts to the Chrome binary.
Review URL: http://codereview.chromium.org/2155004
------------------------------------------------------------------------
r48096 | mrossetti@chromium.org | 2010-05-25 00:46:09 +0200 (Tue, 25 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Re-evaluate the visibility of the "Bookmarks go here..." text visibility when moving a bookmark from and to the Other Bookmarks folder.

BUG=44712
TEST=1) Start with a fresh Chrome and do not import bookmarks.
2) Show the bookmarks bar.
3) Verify that the "For quick access..." text appears in the bookmark bar.
4) Add a bookmark to Other Bookmarks.
5) Verify that the "For quick access..." text still appears in the bookmark bar.
6) Drag the bookmark from Other Bookmarks onto the bookmark bar.
7) Verify that the "For quick access..." text does not appear in the bookmark bar.
8) Drag the bookmark back to the Other Bookmarks.
9) Verify that the "For quick access..." text appears in the bookmark bar.

Review URL: http://codereview.chromium.org/2080022
------------------------------------------------------------------------
r48093 | erg@chromium.org | 2010-05-25 00:34:31 +0200 (Tue, 25 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h

GTK: Mirror the close button when on the left.

There is a small notch in the top right corner of the button when it is on the
left so mirror it so the notch is on the left when the button is on the left.

BUG=44647
TEST=none

Review URL: http://codereview.chromium.org/2086023
------------------------------------------------------------------------
r48086 | stuartmorgan@chromium.org | 2010-05-24 23:28:53 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc

Fix visibilty handling for accelerated Mac plugins

BUG=44453
TEST=Hidden CA plugins shouldn't draw.

Review URL: http://codereview.chromium.org/2147002
------------------------------------------------------------------------
r48084 | ctguil@chromium.org | 2010-05-24 23:17:49 +0200 (Mon, 24 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Change TestRendererAccessibilityTree from disabled to flaky.

Check that document_accessible is non null so that the test doesn't crash.

BUG=44546
TEST=NONE

Review URL: http://codereview.chromium.org/2070017
------------------------------------------------------------------------
r48083 | dcheng@chromium.org | 2010-05-24 23:06:53 +0200 (Mon, 24 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc

Don't populate WebDropData with file URLs when dragging files.

This is the Linux patch. There will be separate patches for Windows and Linux.

BUG=42685
TEST=none

Review URL: http://codereview.chromium.org/2123014
------------------------------------------------------------------------
r48080 | sky@chromium.org | 2010-05-24 22:58:36 +0200 (Mon, 24 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

More side tabs tweaks:
. gets dragging of side tabs to work.
. gets icons to render correctly.
. adds animation support.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2100013
------------------------------------------------------------------------
r48074 | sky@chromium.org | 2010-05-24 22:32:08 +0200 (Mon, 24 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h

Makes normal tabbed browsers on chromeos initially size to full screen
so that they we don't get an ugly resize on first run.

BUG=44218
TEST=none

Review URL: http://codereview.chromium.org/2144004
------------------------------------------------------------------------
r48070 | erg@chromium.org | 2010-05-24 21:51:11 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

GTK: Don't leak the Pango font metrics object.

BUG=44885
TEST=Valgrind is green.

Review URL: http://codereview.chromium.org/2164002
------------------------------------------------------------------------
r48068 | skrul@chromium.org | 2010-05-24 21:39:16 +0200 (Mon, 24 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   D /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Revert 48061 - Adding a mock database layer.
Testing support of storage in TopSites.

BUG=None
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2133011

TBR=nshkrob@chromium.org
Review URL: http://codereview.chromium.org/2128024
------------------------------------------------------------------------
r48064 | michaeln@chromium.org | 2010-05-24 21:19:23 +0200 (Mon, 24 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc

Browser process scaffolding to support having appcache work in workers.

* Associate a RequestContext with a WorkerProcessHost. This corresponds to themain request context of the profile for which the worker process is running. Also associate the context with each WorkerInstance which comes into existance priorto the WorkerProcessHost that will host the instance.

* Give the WorkerProcessHost an AppCacheDispatcherHost.

* Fix up some recently botched IPC plumbing for ViewHostMsg_CreateWorker_Params.


BUG=39368
TEST=there are no worker unit tests

Review URL: http://codereview.chromium.org/2010010
------------------------------------------------------------------------
r48063 | bauerb@chromium.org | 2010-05-24 21:12:26 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Add a comment explaining why we call Browser::InProgressDownloadResponse asynchronously.

BUG=44454
TEST=see bug

Review URL: http://codereview.chromium.org/2128023
------------------------------------------------------------------------
r48061 | nshkrob@chromium.org | 2010-05-24 20:32:49 +0200 (Mon, 24 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   A /trunk/src/chrome/browser/history/top_sites_database.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Adding a mock database layer.
Testing support of storage in TopSites.

BUG=None
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2133011
------------------------------------------------------------------------
r48058 | agl@chromium.org | 2010-05-24 20:22:34 +0200 (Mon, 24 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

On ARM, only blit the needed rects from the TransportDIB.

See the comments in the bug: this is an important code path for
performance and we've found that different code works best for
notebook platforms, but regresses on desktops/laptops.

We could implement a lot of complex code to measure the speed at
run-time and select the best algorithm, but it appears that we can get
good results from just an #ifdef, so we'll start simple.

BUG=44124

http://codereview.chromium.org/2110022/show
------------------------------------------------------------------------
r48056 | thakis@chromium.org | 2010-05-24 20:11:39 +0200 (Mon, 24 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Mac: Fix renderer idle cpu usage regression.

Since polling is required only for the preferred height and mac only needs preferred width, add a flag that specifies if the client is interested in width and/or height.

This is a band-aid, the Real Fix is tracked in 44850.

BUG=44494
TEST=Open chrome's task manager. Idle renderer processes should take close to 0 %cpu instead of ~1.5 before.

Review URL: http://codereview.chromium.org/2145002
------------------------------------------------------------------------
r48049 | bauerb@chromium.org | 2010-05-24 19:12:49 +0200 (Mon, 24 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/download/download_uitest.cc

Call Browser::InProgressDownloadResponse asynchronously on Mac.

TabStripModel::InternalCloseTabs calls Browser::CanCloseContentsAt, which could end up closing a tab before trying to close it again, which causes a crash.

The fix is to call Browser::InProgressDownloadResponse asynchronously from BrowserWindowCocoa::ConfirmBrowserCloseWithPendingDownloads.

TEST=DownloadTest.NewWindow; See bug description for manual test.
BUG=44454

Review URL: http://codereview.chromium.org/2095012
------------------------------------------------------------------------
r48044 | jcivelli@chromium.org | 2010-05-24 18:38:40 +0200 (Mon, 24 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Revert 48042: it breaks unit-tests and UI tests on ChromeOS

 Disabling app launcher and enabling apps by default on ChromeOS .

BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
     app should be showing in there.

Review URL: http://codereview.chromium.org/2135011

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2077020
------------------------------------------------------------------------
r48042 | jcivelli@chromium.org | 2010-05-24 18:06:24 +0200 (Mon, 24 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Disabling app launcher and enabling apps by default on ChromeOS .

BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
     app should be showing in there.

Review URL: http://codereview.chromium.org/2135011
------------------------------------------------------------------------
r48039 | bulach@chromium.org | 2010-05-24 17:15:24 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Adds tests for GeolocationContentSettingsTableModelTest.

TEST=GeolocationContentSettingsTableModelTest.*
BUG=40286

Review URL: http://codereview.chromium.org/2109006
------------------------------------------------------------------------
r48038 | stuartmorgan@chromium.org | 2010-05-24 17:12:43 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   M /trunk/src/base/scoped_cftyperef.h
   M /trunk/src/base/scoped_nsobject.h
   M /trunk/src/chrome/browser/cocoa/scoped_authorizationref.h

Add unused return warnings to the release() methods of some scoped Mac objects

BUG=43608
TEST=None

Review URL: http://codereview.chromium.org/2083021
------------------------------------------------------------------------
r48037 | agl@chromium.org | 2010-05-24 16:55:55 +0200 (Mon, 24 May 2010) | 5 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Small fix to r45696

(Patch from Ningxin Hu)

http://codereview.chromium.org/2097003
------------------------------------------------------------------------
r48034 | dpolukhin@chromium.org | 2010-05-24 14:31:59 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h

Recreate native button on login screen on language switch.

BUG=cros:2876
TEST=See the issue.

Review URL: http://codereview.chromium.org/2092024
------------------------------------------------------------------------
r48021 | yusukes@google.com | 2010-05-24 10:18:44 +0200 (Mon, 24 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h
   A /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/language_mozc_config_view.h (from /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h:48010)
   M /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Initial implementation of a config dialog for ibus-mozc.

- Implemented the dialog which shows 4 pref items: Input method (Romaji/Kana), keymap (MSIME/ATOK/Kotoeri), punctuation style, and symbol style.
- Added string resources for the dialog to generated_resources.grd.
- Added chrome prefs to pref_names.cc.
- Added mappings from the mozc engine name to the dialog to language_config_view.cc while it's commented out now.
- Added comments to sync/glue/synchronized_preferences.h.

BUG=chromium-os:2625
TEST=manual

Review URL: http://codereview.chromium.org/2068014
------------------------------------------------------------------------
r48017 | tony@chromium.org | 2010-05-24 07:09:49 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

When we get a IME_CANCEL_COMPOSITION event on OSX, clear the
ime state.

BUG=9883

Review URL: http://codereview.chromium.org/2095024
------------------------------------------------------------------------
r48016 | dcheng@chromium.org | 2010-05-24 06:45:27 +0200 (Mon, 24 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target.h
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm
   M /trunk/src/third_party/mozilla/NSPasteboard+Utils.h
   M /trunk/src/third_party/mozilla/NSPasteboard+Utils.mm
   M /trunk/src/third_party/mozilla/README.chromium

Don't populate WebDropData with file URLs when dragging files.

This is the OS X patch. There will be separate patches for Windows and Linux.

BUG=42685
TEST=unit_tests --gtest_filter=WebDropTargetTest.*

Review URL: http://codereview.chromium.org/2095011
------------------------------------------------------------------------
r48014 | tfarina@chromium.org | 2010-05-24 05:49:01 +0200 (Mon, 24 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc

Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.

BUG=24672
TEST=compiles

Review URL: http://codereview.chromium.org/2110021
------------------------------------------------------------------------
r48012 | dhollowa@chromium.org | 2010-05-24 05:11:34 +0200 (Mon, 24 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc

Small correction in comment.

Trivial change to test commit from alternate network.

BUG=none
TEST=none
TBR=georgey@chromium.org

Review URL: http://codereview.chromium.org/2117028
------------------------------------------------------------------------
r47986 | xiyuan@chromium.org | 2010-05-22 07:36:33 +0200 (Sat, 22 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   A /trunk/src/views/controls/textfield/gtk_views_textview.cc
   A /trunk/src/views/controls/textfield/gtk_views_textview.h
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/views.gyp

Add multiline support to views::TextField.

- Add a GtkViewsTextView derived from GtkTextView and supports border and
  info text when empty;
- Update NativeTextfieldGtk to use GtkViewsTextView for multiline text;
- Remove the multiline suppression in BugReportView;

BUG=chromium-os:3426
TEST=Verify feedback dialog on ChromeOS uses multiline text edit for description field.

Review URL: http://codereview.chromium.org/2138003
------------------------------------------------------------------------
r47981 | jam@chromium.org | 2010-05-22 04:25:09 +0200 (Sat, 22 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc

Try to fix the crash in SyncResourceHandler by using receiver_ earlier.  I can't reproduce this crash, so we'll keep an eye on crashes.

BUG=43815

Review URL: http://codereview.chromium.org/2144001
------------------------------------------------------------------------
r47980 | arv@chromium.org | 2010-05-22 03:08:16 +0200 (Sat, 22 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Change the code based on Raf's feedback.

BUG=None
TEST=Unit tests
Review URL: http://codereview.chromium.org/2074022
------------------------------------------------------------------------
r47977 | eroman@chromium.org | 2010-05-22 02:36:46 +0200 (Sat, 22 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/net/base/net_log.h
   A /trunk/src/net/base/net_log_source_type_list.h
   M /trunk/src/net/net.gyp

Address a TODO about not duplicating the name --> value mapping for NetLog::Source.

Review URL: http://codereview.chromium.org/2131024
------------------------------------------------------------------------
r47976 | chron@chromium.org | 2010-05-22 02:24:34 +0200 (Sat, 22 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_posix.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add logging and remove pref for bootstrapping. ChromeOS always bootstraps now.
Fixes a mystery hang, or at least should help diagnose it.
BUG=http://crosbug.com/3315
TEST=manual testing

Review URL: http://codereview.chromium.org/2068013
------------------------------------------------------------------------
r47975 | creis@chromium.org | 2010-05-22 02:22:43 +0200 (Sat, 22 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Fixes a bug in slow cross-site navigations.

If a sub-frame navigated while we were waiting for a cross-site
navigation, we would abort the navigation and leave the tab in
an unusual state.  This CL prevents sub-frame navigations from
pre-empting the navigation.

BUG=42029
TEST=TabContentsTest.CrossSiteNavigationNotPreemptedByFrame

Review URL: http://codereview.chromium.org/2134010
------------------------------------------------------------------------
r47973 | jam@chromium.org | 2010-05-22 02:14:28 +0200 (Sat, 22 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_view.cc

Don't use command line flags for enabling the internal pdf plugin.  Instead, disable it by default using the same mechanism that we use for about:plugins.  Once we enable it by default, we just need to flip a boolean in the code and it'll be enabled for everyone.

Review URL: http://codereview.chromium.org/2080016
------------------------------------------------------------------------
r47972 | arv@chromium.org | 2010-05-22 01:30:15 +0200 (Sat, 22 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_clipboard_api.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/extensions/extension_metrics_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_processes_api.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extensions_quota_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_quota_service.h
   M /trunk/src/chrome/browser/extensions/extensions_quota_service_unittest.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/background_contents.cc
   M /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Update extension functions to always pass a list of arguments, even when one argument was passed.

BUG=36301
TEST=Updated tests and ran all the existing tests.

Review URL: http://codereview.chromium.org/2137012
------------------------------------------------------------------------
r47970 | rafaelw@chromium.org | 2010-05-22 01:11:44 +0200 (Sat, 22 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h

Prevent extensions api windows.onFocusChange from firing more than once with same windowId.

For some reason (on windows, at least) BrowserList::SetLastActive seems to get called for every click in the content area of a window.

This ensures that ExtensionBrowserEventRouter only fires once when the focus changes.

BUG=39882
TEST=none

Review URL: http://codereview.chromium.org/2076013
------------------------------------------------------------------------
r47969 | rafaelw@chromium.org | 2010-05-22 01:09:37 +0200 (Sat, 22 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Remove histogram collection evaluating impact of changing extension url resolution.

This reverts the histogram collection part of http://codereview.chromium.org/1605005.

BUG=21909
TEST=none

Review URL: http://codereview.chromium.org/2082016
------------------------------------------------------------------------
r47968 | michaeln@chromium.org | 2010-05-22 01:05:27 +0200 (Sat, 22 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/io_thread.cc

Kill all child processes at IO thread shutdown time.

BUG=none 
TEST=wrapper-map-gc.html leaks a WorkerProcessHost which this cleanup logic takes care of

Review URL: http://codereview.chromium.org/2063015
------------------------------------------------------------------------
r47966 | oshima@chromium.org | 2010-05-22 01:03:20 +0200 (Sat, 22 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc

Fix a assertion failure caused by new asserion in simple_menu_model.cc.
  * command id now has to be positive.

BUG=none
TEST=manual: clicking options menu on notification shows menu instead of crashing

Review URL: http://codereview.chromium.org/2066017
------------------------------------------------------------------------
r47963 | pkasting@chromium.org | 2010-05-22 00:56:25 +0200 (Sat, 22 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc

Size the EV bubble after calculating the space taken by the star/page actions/content settings, so we won't take as much space for users with a lot of these.

BUG=42856
TEST=Elided EV bubble should take less space when there are lots of icons in the omnibox.
Review URL: http://codereview.chromium.org/2073019
------------------------------------------------------------------------
r47959 | davemoore@chromium.org | 2010-05-22 00:21:11 +0200 (Sat, 22 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Ensure that the default profile for cros has no extension service
BUG=chromeium-os:3232
TEST=LoginProfileTest.UserNotPassed

Review URL: http://codereview.chromium.org/2094018
------------------------------------------------------------------------
r47958 | ananta@chromium.org | 2010-05-22 00:20:37 +0200 (Sat, 22 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Fix a chrome crash seen at times in chrome frame reliability test runs. It appears that the crash occurs because we attempt to
unregister focus manager accelerators registered by the external tab container twice as the Uninitialize function gets invoked
twice in WM_DESTROY and in the destructor.

Fix is to set the focus_manager_ pointer to NULL after unregistering the accelerators.

Bug=42365

Review URL: http://codereview.chromium.org/2069015
------------------------------------------------------------------------
r47953 | erg@chromium.org | 2010-05-22 00:15:29 +0200 (Sat, 22 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gconf_titlebar_listener.cc

GTK: Prevent double free by not deleting gconf object we don't own.

BUG=none
TEST=Set to GTK+ theme and then try to change the system theme 4 times to 4 different themes. It shouldn't crash on the 2nd, 3rd or 4th time.

Review URL: http://codereview.chromium.org/2070020
------------------------------------------------------------------------
r47937 | xji@chromium.org | 2010-05-21 20:32:35 +0200 (Fri, 21 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Fix problem of displaying title with parenthesis in extension.
Wrap title with correctly bidi control characters in windows for display purpose.

BUG=43485
TEST=1. open RTL chrome.
2. install Google dictionary extension.
3. extension title "Google Dictionary (by Google)" should be displayed as is in chrome://extensions page, 
4. right click the extension icon, title "Google Dictionary (by Google)" should be displayed in extension context menu, 
5. extension title should be displayed correctly in other places, such as task manager, etc.

Review URL: http://codereview.chromium.org/2015004
------------------------------------------------------------------------
r47936 | rvargas@google.com | 2010-05-21 20:29:45 +0200 (Fri, 21 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h

Update BrowsingDataRemover to use only the asynchronous
interface of the http/disk cache.

BUG=26729
TEST=none

Review URL: http://codereview.chromium.org/2063017
------------------------------------------------------------------------
r47929 | erg@chromium.org | 2010-05-21 19:46:39 +0200 (Fri, 21 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: Elide the EV bubble to approximately half of the location bar when really long.

This only counts the non-icon area of the location bar. Unlike the windows
implementation, the minimum size of the EV bubble is 10 characters instead of
150px.

BUG=42856
TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller.

Review URL: http://codereview.chromium.org/2123015
------------------------------------------------------------------------
r47926 | maruel@chromium.org | 2010-05-21 19:14:57 +0200 (Fri, 21 May 2010) | 8 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/main.js

Fixed a TODO in data export of net-internals, added Chrome version and command line.

BUG=none
TEST=Go to about:net-internals click on dump to text, check if version and command line are good.

Patch contributed by malavv

Review URL: http://codereview.chromium.org/2104012
------------------------------------------------------------------------
r47923 | sky@chromium.org | 2010-05-21 18:58:39 +0200 (Fri, 21 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc

Adds ability to determine if a tab was explicitly closed by the
user. This will be used to determine if the tab should be restored on
startup or not.

BUG=4923
TEST=none

Review URL: http://codereview.chromium.org/2087012
------------------------------------------------------------------------
r47922 | dmazzoni@chromium.org | 2010-05-21 18:54:36 +0200 (Fri, 21 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/browser_accessibility_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Windows accessibility improvements: 1. All WebKit roles are now passed to the
browser and then converted to MSAA roles - this is both because the
logic needs to be more complicated, and so we can support Mac accessibility,
too. 2. The serializable object used to pass accessibility info from the
renderer to the browser now uses a map for uncommon attributes, rather than
having a bunch of fields that are almost always empty. 3. Handles the
accSelect method with TAKE_FOCUS, allowing assistive technology to set focus
to a particular control. 4. Implements several other IAccessible2 interfaces.

BUG=25564
BUG=13291
TEST=None

Review URL: http://codereview.chromium.org/2121004
------------------------------------------------------------------------
r47921 | xiyuan@chromium.org | 2010-05-21 18:38:34 +0200 (Fri, 21 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Land dhg's CL 2109011

Fixing download case, adding new method to download manager to support chromeos downloads.
Original Review: http://codereview.chromium.org/2109011

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2112012
------------------------------------------------------------------------
r47915 | sanjeevr@chromium.org | 2010-05-21 17:01:35 +0200 (Fri, 21 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   D /trunk/src/chrome/browser/json_pref_store.cc
   D /trunk/src/chrome/browser/json_pref_store.h
   D /trunk/src/chrome/browser/json_pref_store_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_service.h
   D /trunk/src/chrome/browser/pref_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/json_pref_store.cc (from /trunk/src/chrome/browser/json_pref_store.cc:47818)
   A /trunk/src/chrome/common/json_pref_store.h (from /trunk/src/chrome/browser/json_pref_store.h:47818)
   A /trunk/src/chrome/common/json_pref_store_unittest.cc (from /trunk/src/chrome/browser/json_pref_store_unittest.cc:47812)
   A /trunk/src/chrome/common/pref_store.h (from /trunk/src/chrome/browser/pref_store.h:47812)
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Removed dependency on ChromeThread from JsonPrefStore and moved JsonPrefStore and PrefStore to chrome/common. This is because JsonPrefStore is needed in the service process 
BUG=None.
TEST=Updated unit-tests

Review URL: http://codereview.chromium.org/2066015
------------------------------------------------------------------------
r47914 | skerner@chromium.org | 2010-05-21 16:09:41 +0200 (Fri, 21 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/a.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/echo.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js:47913)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json:47913)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/relative.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/tabs_util.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/get_current
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/get_current/a.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/a.html:47913)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/get_current/background.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/background.html:47913)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/get_current/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/get_current/test.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/test.js:47913)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/d.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/e.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/tabs_util.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_removed/test.js

Break extension tab api test into multiple parts, to reduce the odds of a timeout.

BUG=43440
TEST=ExtensionApiTest.Tab*

Review URL: http://codereview.chromium.org/2072007
------------------------------------------------------------------------
r47913 | dpolukhin@chromium.org | 2010-05-21 13:23:31 +0200 (Fri, 21 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.cc

Revert revisions 47902 and 47900.

Chrome UI blinks after replacement of gtk_widget_set_size_request with
gtk_widget_size_allocate on resizing or infobar appearing animation.
It happens because gtk_widget_size_allocate results in background resizing
on message loop idle. It looks like we can't use gtk_widget_size_allocate at
this place at all.

Review URL: http://codereview.chromium.org/2131021
------------------------------------------------------------------------
r47910 | danno@chromium.org | 2010-05-21 13:04:50 +0200 (Fri, 21 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   M /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.h
   A /trunk/src/chrome/browser/configuration_policy_provider_win.cc
   A /trunk/src/chrome/browser/configuration_policy_provider_win.h
   A /trunk/src/chrome/browser/configuration_policy_provider_win_unittest.cc
   M /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Win] Implement core mechanism to honor Windows Group Policy

BUG=42640
TEST=--gtest_filter=WinConfigurationPolicyProviderTest*

Review URL: http://codereview.chromium.org/2119005
------------------------------------------------------------------------
r47908 | nkostylev@google.com | 2010-05-21 12:46:53 +0200 (Fri, 21 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc

Do nothing when "No selection" entry is selected.
That entry is at index=0.

BUG=cros:3361
TEST=Select secure network and cancel dialog. Select first entry at network combobox. It should not crash.

Review URL: http://codereview.chromium.org/2074020
------------------------------------------------------------------------
r47907 | jorlow@chromium.org | 2010-05-21 12:45:48 +0200 (Fri, 21 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.cc
   M /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.h

IndexedDB should use WebSecurityOrigins rather than passing origin strings

The Chromium side of https://bugs.webkit.org/show_bug.cgi?id=39216 which (among other things) switches WebCore/WebKit to use SecurityOrigin/WebSecurityOrigins.  I'm also switching it to use databaseIdentifiers (rather than just toString) since its semantics match HTML5's origins (and toStrings do not).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2097005
------------------------------------------------------------------------
r47902 | dpolukhin@chromium.org | 2010-05-21 11:48:29 +0200 (Fri, 21 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc

Disable flack check in FindInPageTest.CrashEscHandlers on Linux views.

See http://codereview.chromium.org/2068006 for details.

BUG=none
TEST=none
TBR=jcivelli@chromium.org, sky@chromium.org

Review URL: http://codereview.chromium.org/2135010
------------------------------------------------------------------------
r47901 | yusukes@google.com | 2010-05-21 11:22:35 +0200 (Fri, 21 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util_unittest.cc

Update language_menu_l10n_util.cc data.

- Added DIRECT_INPUT for ibus-mozc.
- Removed ROMAN and KANA since they're for ibus-anthy.

BUG=chromium-os:3452
TEST=Checked ../chrome_log manually.

Review URL: http://codereview.chromium.org/2110018
------------------------------------------------------------------------
r47899 | satorux@chromium.org | 2010-05-21 10:32:40 +0200 (Fri, 21 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc

Add tests for AddLanguageComboboxModel.

TEST=out/Release/unit_tests --gtest_filter='LanguageConfigViewTest*'
BUG=chromium-os:3432

Review URL: http://codereview.chromium.org/2104015
------------------------------------------------------------------------
r47898 | ukai@chromium.org | 2010-05-21 09:20:35 +0200 (Fri, 21 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Specify --chromium flag to run new-run-webkit-websocketserver

WebKit r59595,r59823 adds --chromium flag in new-run-webkit-websocketserver.
It is necessary to use Chromium port obj in the script to set up
cygwin environment on win bot.

BUGS=41319,40995
TEST=none

Review URL: http://codereview.chromium.org/1710007
------------------------------------------------------------------------
r47896 | lzheng@chromium.org | 2010-05-21 08:56:53 +0200 (Fri, 21 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_response_info.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/ssl_client_socket.h
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

This change enables FieldTrial for SPDY. When --use-spdy=npn is used, field test won't be enabled.
However, when that flag is missing, A/B test is added to browser_main.cc. Trial A: use npn and spdy. B: use npn but no spdy. C: do nothing. A and B are set to zero for now
The histograms we collect are: 
1. Page begin to finish time when spdy is enabled/disabled across all sites;
2. Page begin to finish time when spdy is used on sites that support spdy and when spdy is intentionally ignored. 


BUG=43997
TEST=Don't use --use-spdy=npn, manually change _npn_nospdy and _npn_withspdy percentile and go to spdy supported sites.

Review URL: http://codereview.chromium.org/2036012
------------------------------------------------------------------------
r47893 | thestig@chromium.org | 2010-05-21 07:56:17 +0200 (Fri, 21 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_mac.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/test/data/valgrind/ui_tests.gtest.txt

Revert 47875 - ProcessSingleton(all): create the lock immediately after failing to connect to an existing process.
ProcessSingletonLinux: if creating the lock fails, try to notify again.

BUG=44417
TEST=manual

Review URL: http://codereview.chromium.org/2066014

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/2125015
------------------------------------------------------------------------
r47888 | satorux@chromium.org | 2010-05-21 06:42:22 +0200 (Fri, 21 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Fix major UI ugliness in the "Languages and Input" dialog.

Before this change, clicking on "Add..." button opened a sub dialog,
that only contained a combobox. The behavior was ugly.

After this change, users can add new languages directly from the
"Language and Input" dialog, without opening the ugly sub dialog.

TEST=manually
BUG=chromium-os:3432

Review URL: http://codereview.chromium.org/2092017
------------------------------------------------------------------------
r47887 | satorux@chromium.org | 2010-05-21 06:24:13 +0200 (Fri, 21 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Get rid of the hack for ibus-pinyin.

Before this change, the code assumed that the orientation is vertical,
if the number of candidates is 5, which is an ugly hack.

After this change, we'll use orientation information in InputMethodLookupTable.
To be compatible with IBus's standard candidate window, the default
orientation is set to horizontal.

BUG=chromium-os:2724
TEST=manually

Review URL: http://codereview.chromium.org/2120010
------------------------------------------------------------------------
r47875 | mattm@chromium.org | 2010-05-21 03:52:28 +0200 (Fri, 21 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_mac.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/test/data/valgrind/ui_tests.gtest.txt

ProcessSingleton(all): create the lock immediately after failing to connect to an existing process.
ProcessSingletonLinux: if creating the lock fails, try to notify again.

BUG=44417
TEST=manual

Review URL: http://codereview.chromium.org/2066014
------------------------------------------------------------------------
r47870 | dcheng@chromium.org | 2010-05-21 02:53:12 +0200 (Fri, 21 May 2010) | 8 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_util_win.cc
   M /trunk/src/app/clipboard/clipboard_util_win.h
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/webkit/glue/webdropdata_win.cc

Don't populate WebDropData with file URLs when dragging files.

This is the Windows patch. There will be separate patches for Mac and Linux.

BUG=42685
TEST=none

Review URL: http://codereview.chromium.org/2126010
------------------------------------------------------------------------
r47868 | tony@chromium.org | 2010-05-21 02:42:46 +0200 (Fri, 21 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Remove a NOTREACHED() that I'm triggering when I right
click on a text field.

BUG=None
TEST=Right click on a text field with an IME installed.

Review URL: http://codereview.chromium.org/2108023
------------------------------------------------------------------------
r47866 | dhg@chromium.org | 2010-05-21 01:48:01 +0200 (Fri, 21 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc

Fixing mounting case.

BUG=chromium-os:3292
TEST=none

Review URL: http://codereview.chromium.org/2102013
------------------------------------------------------------------------
r47863 | mirandac@google.com | 2010-05-21 01:44:09 +0200 (Fri, 21 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Speculative fix for blank status bubble.

Fixes a codepath which could possibly lead to an empty status bubble.  I haven't been able to repro, but calling SetText instead of SetTextAndAnimate looks like the one spot that doesn't check for an empty string before displaying.  Eliminating this loophole by consolidating into a single method, SetText, that always triggers the "hide" animation on an empty string, and only triggers animate if |should_animate| is set.  This is actually closer to the SetText method before I added the status bubble expansion code.

BUG=43640
TEST=no more empty link target bubbles floating on the screen.
Review URL: http://codereview.chromium.org/2111013
------------------------------------------------------------------------
r47861 | zelidrag@chromium.org | 2010-05-21 01:31:03 +0200 (Fri, 21 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Made feedback icon hidden on login screen.

BUG=chromium-os:3348
TEST=make sure feedback icon does not show on login mgr screens

Review URL: http://codereview.chromium.org/2081015
------------------------------------------------------------------------
r47847 | estade@chromium.org | 2010-05-20 23:14:46 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

GTK: delete text when cutting from the omnibox.

BUG=44232
TEST=cut all the contents from the omnibox. The url (along with the protocol) should be on both PRIMARY and CLIPBOARD selections. The omnibox should now lay empty.

Review URL: http://codereview.chromium.org/2108014
------------------------------------------------------------------------
r47840 | mattm@chromium.org | 2010-05-20 22:25:52 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gconf_titlebar_listener.cc

Gtk: fix GConfValue leak in GConfTitlebarListener.

BUG=none
TEST=tools/valgrind/chrome_tests.sh -t ui --gtest_filter=ProcessSingletonLinuxTest.\*  (Probably any ui test will work.)

Review URL: http://codereview.chromium.org/2106018
------------------------------------------------------------------------
r47839 | robertshield@chromium.org | 2010-05-20 22:21:01 +0200 (Thu, 20 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Marking DevToolsSanityTest.TestStepOut as flaky on Linux too.

BUG=43479
TEST=none
TBR=cbentzel

Review URL: http://codereview.chromium.org/2111014
------------------------------------------------------------------------
r47838 | mrossetti@chromium.org | 2010-05-20 22:19:43 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Simple code rearranging to better group by function area and protocol.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2136020
------------------------------------------------------------------------
r47837 | arv@chromium.org | 2010-05-20 22:17:19 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/shared/css/menu.css

NTP: use the shared menu.css for the options menu.

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/2063014
------------------------------------------------------------------------
r47833 | oshima@chromium.org | 2010-05-20 21:47:40 +0200 (Thu, 20 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc

Implement full screen lock functionality.
 * Send Unlock request to PM when authentication succeeds.
 * Re-enable input when Unlock request failed.
 * Changed if (screen_locker_) to assertion in Show method: state is controlled in PowerManager now,
   and duplicated Show request should not happen.
 * Send Unlock/Lock complete to PowerManager.

BUG=http://crosbug.com/2914
TEST=none

locker

Review URL: http://codereview.chromium.org/2126008
------------------------------------------------------------------------
r47829 | dhollowa@chromium.org | 2010-05-20 21:30:20 +0200 (Thu, 20 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc

AutoFill telephone number prefix and suffix heuristics.

Extends matching of telephone number prefix and suffix fields to include fields explicitly labeled with "prefix" and "suffix" strings.

BUG=40694
TEST=PhoneFieldTest.ThreePartPhoneNumberPrefixSuffix

Review URL: http://codereview.chromium.org/2129016
------------------------------------------------------------------------
r47827 | mirandac@chromium.org | 2010-05-20 21:25:35 +0200 (Thu, 20 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   A /trunk/src/chrome/browser/importer/importer_data_types.h
   M /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/importer_data_types.h
   D /trunk/src/chrome/common/url_row_type.cc
   D /trunk/src/chrome/common/url_row_type.h

Revert 47675.

Instead of moving data types into common/, create a special class of IPC messages that live in the browser directory, specifically for importing browser-related data.

BUG=18774
TEST=none
Review URL: http://codereview.chromium.org/2095020
------------------------------------------------------------------------
r47823 | dhg@chromium.org | 2010-05-20 21:09:51 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing overlap problem when a download in dangerous.

BUG=chromium-os:2773
TEST=none

Review URL: http://codereview.chromium.org/2079013
------------------------------------------------------------------------
r47819 | pkasting@chromium.org | 2010-05-20 20:28:00 +0200 (Thu, 20 May 2010) | 5 lines
Changed paths:
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider.h
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/ev_bubble_view.cc
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.cc
   M /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.h
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/widget/tooltip_manager.cc

Elide the EV bubble when it's extremely long.  This limits it to half the location bar width, unless eliding to that would result in a width of less than 150 px.

BUG=42856
TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller.  The EV bubble should shrink, eliding in middle, until it hits a minimum size.
Review URL: http://codereview.chromium.org/2084012
------------------------------------------------------------------------
r47818 | sanjeevr@chromium.org | 2010-05-20 20:20:29 +0200 (Thu, 20 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   D /trunk/src/chrome/browser/important_file_writer.cc
   D /trunk/src/chrome/browser/important_file_writer.h
   D /trunk/src/chrome/browser/important_file_writer_unittest.cc
   M /trunk/src/chrome/browser/json_pref_store.cc
   M /trunk/src/chrome/browser/json_pref_store.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/important_file_writer.cc (from /trunk/src/chrome/browser/important_file_writer.cc:47690)
   A /trunk/src/chrome/common/important_file_writer.h (from /trunk/src/chrome/browser/important_file_writer.h:47690)
   A /trunk/src/chrome/common/important_file_writer_unittest.cc (from /trunk/src/chrome/browser/important_file_writer_unittest.cc:47690)

Moved ImportantFileWriter to chrome/common in preparation of moving JsonPrefStore to chrome/common.
BUG=None.
TEST=Unit-tests moved and modified.

Review URL: http://codereview.chromium.org/2128014
------------------------------------------------------------------------
r47817 | robertshield@chromium.org | 2010-05-20 20:14:07 +0200 (Thu, 20 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Marking BrowserEncodingTest.TestOverrideEncoding as FLAKY.

Bug=44668
TEST=none
TBR=cbentzel

Review URL: http://codereview.chromium.org/2106020
------------------------------------------------------------------------
r47814 | robertshield@chromium.org | 2010-05-20 19:56:00 +0200 (Thu, 20 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Marking BrowserEncodingTest.TestEncodingAutoDetect as FLAKY. 

BUG=44666
TEST=none
TBR=cbentzel

Review URL: http://codereview.chromium.org/2071021
------------------------------------------------------------------------
r47807 | rsesek@chromium.org | 2010-05-20 18:32:36 +0200 (Thu, 20 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

[Mac] Add a preference for the tab key cycling between just form fields, or links as well.

XIB change:
Add a checkbox bound to FilesOwner.tabsToLinks underneath the translate webpages
preference.

BUG=31177
TEST=Uncheck Chromium-->Preferences-->Under the Hood-->Pressing Tab... Then press Tab on Google.com and the links don't get focus; it alternates between search field and location bar.

Review URL: http://codereview.chromium.org/2082011
------------------------------------------------------------------------
r47805 | davemoore@chromium.org | 2010-05-20 18:20:09 +0200 (Thu, 20 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.h

Boot times weren't getting displayed
BUG=NONE
TEST=Ensure that boot times are shown at startup.

Review URL: http://codereview.chromium.org/2102011
------------------------------------------------------------------------
r47804 | nkostylev@google.com | 2010-05-20 18:06:35 +0200 (Thu, 20 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

BUG=chromium-os:3362
TEST=After bubble is shown select another window/open dialog.

Review URL: http://codereview.chromium.org/2111012
------------------------------------------------------------------------
r47800 | cbentzel@chromium.org | 2010-05-20 17:38:33 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Marking ExtensionTestRoundTripApiCall.RunTest as FLAKY.

BUG=44650
TEST=None

Review URL: http://codereview.chromium.org/2083017
------------------------------------------------------------------------
r47799 | mrossetti@chromium.org | 2010-05-20 17:34:54 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

Prevent valgrind errors due to incomplete animations by providing a test setting to have animations ignored. Apply it to the BookmarkBarControllerTest.OffTheSideButtonHidden unit test. BookmarkBarController and BookmarkBarFolderController now have a -[setIgnoreAnimations:] function for accomplishing this.

BUG=44563
TEST=None

Review URL: http://codereview.chromium.org/2095017
------------------------------------------------------------------------
r47785 | nkostylev@google.com | 2010-05-20 13:04:48 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/views/widget/widget_delegate.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Clear password field when navigating though users on the login screen.

BUG=chromium-os:2319
TEST=Enter password on the login screen. Navigate to the left/right user window. Navigate back. Password field should be empty.

Review URL: http://codereview.chromium.org/2132011
------------------------------------------------------------------------
r47784 | cbentzel@chromium.org | 2010-05-20 12:53:37 +0200 (Thu, 20 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Revert 47746 - Reenabling TestAboutChromeViewAccObj.

This test appears to be passing fine.

TEST=NONE
BUG=NONE

TBR=dmazzoni@chromiun.org


TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2124013
------------------------------------------------------------------------
r47783 | cbentzel@chromium.org | 2010-05-20 12:52:16 +0200 (Thu, 20 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Revert 47739 - Fix failure of browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj

This still failed on the continuous builds.

Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible.

BUG=44486
TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj
TBR=dmazzoni@chromium.org

Review URL: http://codereview.chromium.org/2119010

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2075022
------------------------------------------------------------------------
r47777 | zelidrag@chromium.org | 2010-05-20 07:55:06 +0200 (Thu, 20 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_api.gyp
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/syslogs_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/syslogs_library.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Submitting http://codereview.chromium.org/2081006/show on behalf of rkc@chromium.org:

Changes for sending user e-mail along with the feedback
Changes to implement complete userfeedback stack.

TBR=zelidrag@chromium.org
TEST=none
BUG=chromium-os:2761

Review URL: http://codereview.chromium.org/2090011
------------------------------------------------------------------------
r47776 | jam@chromium.org | 2010-05-20 07:42:59 +0200 (Thu, 20 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc

Show the extension name in the task manager for extension created worker processes.

BUG=30713
Review URL: http://codereview.chromium.org/2108015
------------------------------------------------------------------------
r47775 | ukai@chromium.org | 2010-05-20 06:53:11 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.h

Run WebSocket experiment if reporting is active.

BUG=44626
TEST=none

Review URL: http://codereview.chromium.org/2093009
------------------------------------------------------------------------
r47771 | akalin@chromium.org | 2010-05-20 06:15:35 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
   M /trunk/src/chrome/test/sync/test_http_bridge_factory.h
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fixed sync unit test leak and removed suppression.

BUG=44540
TEST=ran valgrind on sync unit tests

Review URL: http://codereview.chromium.org/2105011
------------------------------------------------------------------------
r47769 | satorux@chromium.org | 2010-05-20 06:05:34 +0200 (Thu, 20 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Share the same label between the language selector and the options dialog.

The "Language and Input" dialog is opened from two places.
We should share the same label in the two places.

BUG=3431
TEST=manually

Review URL: http://codereview.chromium.org/2094014
------------------------------------------------------------------------
r47762 | zelidrag@chromium.org | 2010-05-20 04:07:08 +0200 (Thu, 20 May 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/statusbar_feedback.png
   A /trunk/src/chrome/app/theme/statusbar_feedback_pressed.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   A /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.cc
   A /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Integrated new bug icon in status bar. It opens bug reporting dialog.

BUG=chromium-os:3348
TEST=click on the new bug icon in the status bar, it should open bug reporting dialog


Review URL: http://codereview.chromium.org/2134009
------------------------------------------------------------------------
r47760 | twiz@google.com | 2010-05-20 03:08:17 +0200 (Thu, 20 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h

Simple change that re-positions the arrow location on displayed extension popup views.  This change allows popups to re-orient themselves if they are partially clipped by the working monitor.  Note that this only applies to popups created via the experimental extension popup API.
BUG=42779
TEST=None

Review URL: http://codereview.chromium.org/1774012
------------------------------------------------------------------------
r47754 | oshima@chromium.org | 2010-05-20 02:13:57 +0200 (Thu, 20 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc

Create gdk_event right way to elimination compilation error in chroot environment.
 I didn't bother allocating new one because i thought none is using event object except for our code, but i was wrong.
 TextField is copying the struct, which was causing the warning.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2086017
------------------------------------------------------------------------
r47751 | cbentzel@chromium.org | 2010-05-20 02:00:20 +0200 (Thu, 20 May 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/app/theme/statusbar_feedback.png
   D /trunk/src/chrome/app/theme/statusbar_feedback_pressed.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   D /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.cc
   D /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 47749 - Integrated new bug icon in status bar. It opens bug reporting dialog.

BUG=chromiumos:3348
TEST=click on the new bug icon in the status bar, it should open bug reporting dialog

Review URL: http://codereview.chromium.org/2135005

TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/2125013
------------------------------------------------------------------------
r47750 | johnnyg@chromium.org | 2010-05-20 01:51:17 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/notification_icon.html
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h

For notifications, use the same shadow border that the autocomplete dropdown uses rather than using images.  This looks a lot sharper.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2078019
------------------------------------------------------------------------
r47749 | zelidrag@chromium.org | 2010-05-20 01:43:30 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/statusbar_feedback.png
   A /trunk/src/chrome/app/theme/statusbar_feedback_pressed.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   A /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.cc
   A /trunk/src/chrome/browser/chromeos/status/feedback_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Integrated new bug icon in status bar. It opens bug reporting dialog.

BUG=chromium-os:3348
TEST=click on the new bug icon in the status bar, it should open bug reporting dialog

Review URL: http://codereview.chromium.org/2135005
------------------------------------------------------------------------
r47748 | derat@chromium.org | 2010-05-20 01:32:06 +0200 (Thu, 20 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h

chromeos: Add _CHROME_LOGGED_IN property on root window.

This gets set to either 1 or 0 depending on whether the user
is currently logged in or not.  I'm doing this as a step towards
using the same window manager process during and after login;
this will let the WM know which log file it should be using, for
instance.

BUG=chromium-os:2790
TEST=tried it, and will add an autotest for this soon

Review URL: http://codereview.chromium.org/2078017
------------------------------------------------------------------------
r47746 | ctguil@chromium.org | 2010-05-20 01:16:45 +0200 (Thu, 20 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Re-enabling TestAboutChromeViewAccObj.

This test appears to be passing fine.

TEST=NONE
BUG=NONE

TBR=dmazzoni@chromiun.org

------------------------------------------------------------------------
r47745 | albertb@chromium.org | 2010-05-20 01:14:34 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/nigori_unittest.cc

Add unit tests for Nigori permute and decrypt.

BUG=none
TEST=NigoriTest.*

Review URL: http://codereview.chromium.org/2089019
------------------------------------------------------------------------
r47740 | aa@chromium.org | 2010-05-20 00:27:06 +0200 (Thu, 20 May 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension_file_util.h
   M /trunk/src/chrome/common/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages.h

Allow extensions to be overinstalled with extensions of same
version. This is useful during development, for switching
themes, and for user scripts (since user scripts have no
development mode).

Since we can't always immediately delete the version directory
for an extension after unloading it (because some files might
be in use), this required changing the directory layout of the
extensions directory to allow multiple copies of the same
version of the same extension to be present at once. This was
done by adding a counter to the version directory name.

Also get rid of all the old "Current Version" cruft, since we
no longer use that.

BUG=26538

Review URL: http://codereview.chromium.org/1521039
------------------------------------------------------------------------
r47739 | ctguil@chromium.org | 2010-05-20 00:20:51 +0200 (Thu, 20 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Fix failure of browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj

Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible.

BUG=44486
TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj
TBR=dmazzoni@chromium.org

Review URL: http://codereview.chromium.org/2119010
------------------------------------------------------------------------
r47736 | arv@chromium.org | 2010-05-20 00:18:11 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/shared/css/menu.css

DOMUI shared resources: Update menu style to follow Roma's spec for menus

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2104011
------------------------------------------------------------------------
r47734 | arv@chromium.org | 2010-05-20 00:11:36 +0200 (Thu, 20 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmarks: Reorganize the HTML a bit to reduce loading flicker.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2097011
------------------------------------------------------------------------
r47732 | shess@chromium.org | 2010-05-19 23:56:32 +0200 (Wed, 19 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm

Cleanup a bunch of TODO(shess).

The TODO on AutocompleteEditViewMac about the popup needing the field
for placement and font got half done.  The placement part just seemed
too intrusive to be worthwhile, but the font part seemed reasonable to
get rid of.

The others are all either not sensible anymore, or were addressed
without being removed, or have been in there long enough that if
nobody has complained by now, their subject must not matter.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2127009
------------------------------------------------------------------------
r47731 | dhollowa@chromium.org | 2010-05-19 23:56:18 +0200 (Wed, 19 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h

AutoFill fill billing address when credit card settings specify a billing address.

Fixes address type matching in |AddressField::AddressTypeFromText| method.  Also, extends |AutoFillManager::FillAutoFillFormData| method to fill associated billing address when filling a credit card that has billing information set in preferences.  Adds new unit test AutoFillManagerTest.FillCreditCardFormWithBilling and fixes others.

BUG=44227
TEST=AddressFieldTest.ParseOneLineAddress, \
AddressFieldTest.ParseOneLineAddressBilling, \
AddressFieldTest.ParseOneLineAddressShipping, \
AutoFillManagerTest.FillCreditCardForm, \
AutoFillManagerTest.FillCreditCardFormWithBilling, \
FormStructureTest.HeuristicsSample8, \
and manual test with everything2.html bug file.

Review URL: http://codereview.chromium.org/2078016
------------------------------------------------------------------------
r47724 | robertshield@chromium.org | 2010-05-19 23:27:15 +0200 (Wed, 19 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Marking ExtensionTestSimpleApiCall, RunTest as flaky after failure on Vista Tests.

BUG=44599
TEST=none
TBR=cbentzel,joi

Review URL: http://codereview.chromium.org/2071019
------------------------------------------------------------------------
r47723 | fbarchard@chromium.org | 2010-05-19 23:06:27 +0200 (Wed, 19 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/media/base/media_switches.cc
   M /trunk/src/media/base/media_switches.h
   M /trunk/src/media/filters/ffmpeg_video_decode_engine.cc
   M /trunk/src/media/filters/ffmpeg_video_decode_engine_unittest.cc
   M /trunk/src/media/test/ffmpeg_tests/ffmpeg_tests.cc

Change default to three threads for video decoding and add command line --video-threads.
BUG=44128
TEST=player_wtl.exe --video-threads=6 d:\mediatests\crowd\crowd2.mp4

Review URL: http://codereview.chromium.org/2080008
------------------------------------------------------------------------
r47722 | finnur@chromium.org | 2010-05-19 23:04:48 +0200 (Wed, 19 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtA
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtA/background.html
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtA/icon.png
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtA/manifest.json
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtA/popup.html
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtB
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtB/background.html
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtB/icon.png
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtB/manifest.json
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_44415/ExtB/popup.html

Fix browser crash when refreshing extensions.

If you have two extensions with page actions, you can get into
a state where it crashes if you refresh Extension A, then
Extension B and Extension A again.

BUG=http://crbug.com/44415
TEST=Covered by new test ExtensionBrowserTest.PageActionRefreshCrash


Review URL: http://codereview.chromium.org/2134008
------------------------------------------------------------------------
r47717 | rafaelw@chromium.org | 2010-05-19 22:26:25 +0200 (Wed, 19 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/browserThenRendererInitiated
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/browserThenRendererInitiated/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/browserThenRendererInitiated/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/iframeNavigated
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/iframeNavigated/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/iframeNavigated/iframe1.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/iframeNavigated/iframe2.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/iframeNavigated/iframe3.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/internalAnchorNavigated
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/internalAnchorNavigated/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/on_updated/test.html

fix chrome.tabs.onUpdated bugs, add browsertest.

This CL addresses a few issues related to the behavior of the onUpdated event.

Issue 1: The page re-entering the load state and the completing was causing multiple 'complete' status events to be fired. We now only report the first 'complete' after the didNavigate message is fired (iframe navigation, for example).

Issue 2: We were initializing the URL when the TabEntry was created, and this caused us to fail to send the url with the first navigation because we thought it wasn't changing.

BUG=27208,37149

Review URL: http://codereview.chromium.org/2111010
------------------------------------------------------------------------
r47710 | avayvod@google.com | 2010-05-19 22:07:40 +0200 (Wed, 19 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Fix for flickering of images on login screen.
Changed image resizing logic to show full size ghost and question mark
images.

BUG=chromiumos:2856
TEST=Login and logout. Check that user images are not shown partially for
short period of time before drawn correctly.

Review URL: http://codereview.chromium.org/2136018
------------------------------------------------------------------------
r47703 | seanparent@google.com | 2010-05-19 21:44:50 +0200 (Wed, 19 May 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/app/theme/notification_low_battery.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/low_battery_observer.cc
   M /trunk/src/chrome/browser/chromeos/low_battery_observer.h
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification.cc
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification.h

Added support for critical notification on low battery.
Added support for urgent system notifications
Added support for icons in system notifications and added a low battery icon.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=2692
TEST=none

Review URL: http://codereview.chromium.org/2067016
------------------------------------------------------------------------
r47699 | jrg@chromium.org | 2010-05-19 21:08:53 +0200 (Wed, 19 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Another bookmark sync issue.

If deleting a bookmark button (due to sync) while a bookmark folder is
open, be sure to close the folder.  Surprisingly this is among the top
browser crashes.

BUG=37782

Review URL: http://codereview.chromium.org/2113014
------------------------------------------------------------------------
r47697 | robertshield@chromium.org | 2010-05-19 21:02:08 +0200 (Wed, 19 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Disabling GeolocationBrowserTest.NoInfobarForSecondTab which crashes on Vista as well as on Mac.

BUG=44589
TEST=none
TBR=bulach,cbentzel,rjkroege

Review URL: http://codereview.chromium.org/2110011
------------------------------------------------------------------------
r47689 | aa@chromium.org | 2010-05-19 20:27:05 +0200 (Wed, 19 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix a bug in unit test where we were not resetting state
properly. At some point, somebody fixed the test to pass, but
it wasn't really doing what was originally intended.

Review URL: http://codereview.chromium.org/2121009
------------------------------------------------------------------------
r47688 | davemoore@chromium.org | 2010-05-19 20:22:20 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc

Fix new gcc error. This only happens on the ARM build, using
a different compiler.

TBR: sky

Review URL: http://codereview.chromium.org/2104008
------------------------------------------------------------------------
r47686 | zork@chromium.org | 2010-05-19 20:06:14 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   A /trunk/src/chrome/browser/sync/glue/password_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/password_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/password_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/password_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/password_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/password_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/password_model_worker.cc
   A /trunk/src/chrome/browser/sync/glue/password_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/profile_mock.h

Adding sync support for Passwords

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1851004
------------------------------------------------------------------------
r47683 | erg@chromium.org | 2010-05-19 19:36:08 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model.cc

GTK: Add "Show as Tab" to popup windows.

BUG=44004
TEST=none

Review URL: http://codereview.chromium.org/2099007
------------------------------------------------------------------------
r47682 | davemoore@chromium.org | 2010-05-19 19:36:06 +0200 (Wed, 19 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.h
   M /trunk/src/chrome/browser/chromeos/browser_notification_observers.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

- Made the writing of boot times happen on the file thread.
- Also combined two different ways of writing these times into
common code.
- Tweaked the color / font of the output

BUG=NONE
TEST=Ensure that boot times still display on login screen.

Review URL: http://codereview.chromium.org/2112006
------------------------------------------------------------------------
r47675 | mirandac@chromium.org | 2010-05-19 18:42:13 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   D /trunk/src/chrome/browser/importer/importer_data_types.h
   M /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/importer_data_types.h (from /trunk/src/chrome/browser/importer/importer_data_types.h:47566)
   A /trunk/src/chrome/common/url_row_type.cc
   A /trunk/src/chrome/common/url_row_type.h

Move data types used in the importer process to common/, in preparation for import to run out of process.

BUG= 18774
TEST= none.

Review URL: http://codereview.chromium.org/2106015
------------------------------------------------------------------------
r47674 | shess@chromium.org | 2010-05-19 18:25:13 +0200 (Wed, 19 May 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   A /trunk/src/chrome/browser/cocoa/objc_zombie.h
   A /trunk/src/chrome/browser/cocoa/objc_zombie.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Implement NSObject zombies.

Apple's NSZombieEnabled setting makes it easier to catch messages to
freed objects, but is mostly only useful in debugging environments.
This implements a facility like NSZombieEnabled with the following
additions:

 - The number of outstanding zombies can be configured.
 - Classes can opt-in to becoming zombies.
 - C++ destructors are correctly called on Leopard.

The goal is to allow us to enable zombies in certain production builds
to help debug some of the message-after-free bugs we have.

BUG=35590,24987
TEST=everything

Review URL: http://codereview.chromium.org/660411
------------------------------------------------------------------------
r47671 | brettw@chromium.org | 2010-05-19 18:03:42 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/testing_profile.h

Add command line flag --top-sites to replace the thumbnail store flag.
Use the flag for querying for thumbnails.
Add timer to update TopSites (every second for now).

BUG=None
TEST='chrome --top-sites'
------------------------------------------------------------------------
r47668 | robertshield@chromium.org | 2010-05-19 17:38:49 +0200 (Wed, 19 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Mark DevToolsSanityTest.TestStepOut as flaky on Chrome OS.

BUG=43479
TEST=none
TBR=cbentzel

Review URL: http://codereview.chromium.org/2071018
------------------------------------------------------------------------
r47666 | cbentzel@chromium.org | 2010-05-19 17:02:41 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Disabling AccessibilityWinBrowserTest.TestRenderereAccessibilityTree.

BUG=44546
TEST=None

Review URL: http://codereview.chromium.org/2105010
------------------------------------------------------------------------
r47657 | cbentzel@chromium.org | 2010-05-19 15:07:47 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Mark TestAboutViewChromeAccObj as FAILS.

BUG=44486
TEST=None

Review URL: http://codereview.chromium.org/2131017
------------------------------------------------------------------------
r47651 | yusukes@google.com | 2010-05-19 13:12:20 +0200 (Wed, 19 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

Key names for ibus-gconf (and ibus-memconf) were wrong.
I was using those for Pytyhon version of ibus-pinyin. C++ version uses CamelCase strings.

BUG=chromium-os:3266
TEST=see the bug

Review URL: http://codereview.chromium.org/2094011
------------------------------------------------------------------------
r47646 | phajdan.jr@chromium.org | 2010-05-19 11:45:50 +0200 (Wed, 19 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.h

Fix the build by updating FRIEND_TEST line.

TBR=maruel

BUG=44547

Review URL: http://codereview.chromium.org/2083013
------------------------------------------------------------------------
r47645 | phajdan.jr@chromium.org | 2010-05-19 11:43:30 +0200 (Wed, 19 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui_browsertest.cc

Disable ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToDefault because of crashiness.

TBR=satish

TEST=crashy
BUG=44548

Review URL: http://codereview.chromium.org/2085011
------------------------------------------------------------------------
r47644 | phajdan.jr@chromium.org | 2010-05-19 11:38:05 +0200 (Wed, 19 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc

Disable PrintDialogCloudTest.HandlersRegistered because of crashiness.

TBR=maruel

TEST=disabled
BUG=44547

Review URL: http://codereview.chromium.org/2117016
------------------------------------------------------------------------
r47643 | phajdan.jr@chromium.org | 2010-05-19 11:28:34 +0200 (Wed, 19 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Mark AccessibilityWinBrowserTest.TestRendererAccessibilityTree as flaky.

There was some fix recently, but it wasn't fully effective. The test
has failed again today.

TBR=ctguil

TEST=flaky
BUG=44546

Review URL: http://codereview.chromium.org/2108019
------------------------------------------------------------------------
r47641 | phajdan.jr@chromium.org | 2010-05-19 11:22:57 +0200 (Wed, 19 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Disable SSLUITest.TestGoodFrameNavigation, it flakily exceeds test timeout.

TBR=jrg

BUG=18626
TEST=disabled

Review URL: http://codereview.chromium.org/2116009
------------------------------------------------------------------------
r47640 | yusukes@google.com | 2010-05-19 11:22:16 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

Support "Kana Eisu" key in Japanese keyboard for Chrome OS.

BUG=chromium-os:2543
TEST=manual

Review URL: http://codereview.chromium.org/2067017
------------------------------------------------------------------------
r47635 | yusukes@google.com | 2010-05-19 10:16:54 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Handle "bopomofo" in LanguageLibrary::GetLanguageCodeFromDescriptor().

BUG=none
TEST=ran tests in language_library_test.cc.

Review URL: http://codereview.chromium.org/2103010
------------------------------------------------------------------------
r47633 | phajdan.jr@chromium.org | 2010-05-19 08:26:52 +0200 (Wed, 19 May 2010) | 32 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_apitest.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/ui/history_uitest.cc

[GTTF] [TTF] Test marks maintenance CL:

* The following tests are no longer flaky:

    BrowserTest.PageLanguageDetection (bug 42095)
    AppApiTest.AppProcess (bug 42497)
    ExtensionApiTest.Infobars (bug 40141)
    FindInPageControllerTest.FindMovesWhenObscuring (bug 41124)
    SessionRestoreUITest.TwoWindowsCloseOneRestoreOnlyOne (bug 39905)
    RenderViewTest.OnHandleKeyboardEvent (no bug)
    RenderViewTest.DidFailProvisionalLoadWithErrorForError (no bug)
    AutomatedUITestBase.CloseTab (bug 14774)
    AutomatedUITestBase.CloseBrowserWindow (bug 14774)
    PluginTest.FlashLayoutWhilePainting (bug 21538)
    HistoryTester.VerifyHistoryLength1 (bug 39785)
    HistoryTester.ConsiderRedirectAfterGestureAsUserInitiated (bug 39785)
    HistoryTester.ConsiderSlowRedirectAsUserInitiated (bug 39785)

* The following tests are not flaky, but disabled due to hangs:

    BrowserAppRefocusTest.OpenTab (bug 44026)

* The following tests are not flaky, but seem to fail consistently:

    ProcessSingletonLinuxTest.NotifyOtherProcessSuccess (bug 30953)
    ProcessSingletonLinuxTest.NotifyOtherProcessHostChanged (bug 30953)
    BrowserViewsAccessibilityTest.TestChromeWindowAccObj (bug 44486)

BUG=42095, 44026, 42497, 40141, 41124, 30953, 39905, 14774, 21538, 39785, 44486
TEST=this touches a lot of tests

Review URL: http://codereview.chromium.org/2128009
------------------------------------------------------------------------
r47632 | jrg@chromium.org | 2010-05-19 07:48:00 +0200 (Wed, 19 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_model_observer_for_cocoa.h

Speculative bookmark crash fix.

The crash in http://crbug.com/43881 might be a reference to a dangling pointer. 

One theory for this crash is:
- use bookmark sync
- 1st machine: open a context menu on a bookmark button
- 2nd machine: delete that bookmark (or it's parent), or rearrange things somehow
- 1st machine: select Delete on the menu

Fix is to close context menus when we see a model change.

BUG=43881

Review URL: http://codereview.chromium.org/2132012
------------------------------------------------------------------------
r47631 | yusukes@google.com | 2010-05-19 07:41:31 +0200 (Wed, 19 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

The language menu button should be disabled (i.e. grayed out) by default
since the language menu (and libcros) might not have input_context when Chrome is started.

For example, if Chrome initially focuses a password input area, ibus-daemon does not raise the FocusIn signal for the input area.

BUG=chromium-os:3341
BUG=chromium-os:2639
TEST=manual

Review URL: http://codereview.chromium.org/2074016
------------------------------------------------------------------------
r47627 | oshima@chromium.org | 2010-05-19 07:06:55 +0200 (Wed, 19 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h

Make chromium compilable with screen lock change.

TBR=zelidrag@chromium.org,davidjames@chromium.org
BUG=3340
TEST=none

Review URL: http://codereview.chromium.org/2084010
------------------------------------------------------------------------
r47624 | estade@chromium.org | 2010-05-19 05:39:27 +0200 (Wed, 19 May 2010) | 8 lines
Changed paths:
   M /trunk/src/base/base.gypi
   A /trunk/src/base/event_synthesis_gtk.cc
   A /trunk/src/base/event_synthesis_gtk.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/test/render_view_test.cc

enable RenderViewTest.OnHandleKeyboardEvent on Linux.

Rearrange some existing automation code and write some new code.

BUG=none
TEST=runs

Review URL: http://codereview.chromium.org/2083012
------------------------------------------------------------------------
r47615 | akalin@chromium.org | 2010-05-19 04:31:10 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome.gyp

Replaced AddressWatcherTask with net::NetworkChangeNotifier.

BUG=none
TEST=disconnected/reconnected network, made sure sync detected it (tested on Windows, Linux, OS X)

Review URL: http://codereview.chromium.org/1522001
------------------------------------------------------------------------
r47609 | tfarina@chromium.org | 2010-05-19 03:04:54 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/default_encoding_combo_model.cc
   A /trunk/src/chrome/browser/default_encoding_combo_model.h
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

gtk: Split DefaultEncodingComboboxModel into its own file so it can be shared with the views UI side.

BUG=None
TEST=manually, everything should works as before.

Review URL: http://codereview.chromium.org/1993004
------------------------------------------------------------------------
r47607 | arv@chromium.org | 2010-05-19 02:55:22 +0200 (Wed, 19 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc

DOMUI - Simplify DOMMessageHandler::Extract{Integer,String}Value.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2074011
------------------------------------------------------------------------
r47601 | georgey@chromium.org | 2010-05-19 02:12:47 +0200 (Wed, 19 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc

Do not show "save password" infobar on broken pages, which we cannot autofill.
BUG=33992
TEST=For the second page in the bug InfoBar should not appear anymore.
Review URL: http://codereview.chromium.org/2089014
------------------------------------------------------------------------
r47600 | huanr@chromium.org | 2010-05-19 02:06:23 +0200 (Wed, 19 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.h
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h

Using different Version environment variable for SxS.

BUG=44474
TEST=mini_installer.exe --chrome-sxs. The first run
should start regardless what is set for CHROME_VERSION.
  

Review URL: http://codereview.chromium.org/2101006
------------------------------------------------------------------------
r47594 | ctguil@chromium.org | 2010-05-19 01:56:42 +0200 (Wed, 19 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Revert 47582 - Fix flakyness of browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj

1. Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible.
2. Use ScopedComPtr in this file.

BUG=44486
TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj

Review URL: http://codereview.chromium.org/2092011

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2132013
------------------------------------------------------------------------
r47587 | dhg@chromium.org | 2010-05-19 01:10:23 +0200 (Wed, 19 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Adding double click to select mode in the filebrowser.

BUG=chromium-os:3357
TEST=none
Review URL: http://codereview.chromium.org/2129012
------------------------------------------------------------------------
r47582 | ctguil@chromium.org | 2010-05-19 00:57:34 +0200 (Wed, 19 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Fix flakyness of browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj

1. Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible.
2. Use ScopedComPtr in this file.

BUG=44486
TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj

Review URL: http://codereview.chromium.org/2092011
------------------------------------------------------------------------
r47575 | finnur@chromium.org | 2010-05-18 23:54:49 +0200 (Tue, 18 May 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.h
   M /trunk/src/chrome/browser/views/location_bar/star_view.h

Implement fading in for the InfoBubble base class.

For bubbles that are not shown as a direct result of
a mouse click, we use fade in. This applies to
the FirstRun bubble and the extension installed
bubble.

For bubbles that have controls (buttons/links) we
fade out if interacting with those controls closes
the bubble. This applies to the first run bubble,
app launcher, extension installed bubble, bookmark
bubble and the content settings bubble.

BUG=None
TEST=Make sure the above-mentioned bubbles fade in
and out during hide and show as described above.

Review URL: http://codereview.chromium.org/2079008
------------------------------------------------------------------------
r47569 | glotov@chromium.org | 2010-05-18 23:20:13 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/system_key_event_listener.cc

Small fix: volume up and down are mixed up.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2107011
------------------------------------------------------------------------
r47568 | pkasting@chromium.org | 2010-05-18 23:19:50 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Forget zoom levels set/changed in incognito mode when exiting incognito.  This mostly reverts r37595.

BUG=43107
TEST=Go incognito.  Modify the zoom level for a site.  Restart Chrome.  That site's zoom level should not reflect the change made in incognito mode.
Review URL: http://codereview.chromium.org/2079010
------------------------------------------------------------------------
r47565 | sky@chromium.org | 2010-05-18 23:12:23 +0200 (Tue, 18 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fixes regression in reverting a tab drag. I was animating to the wrong
location.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2123004
------------------------------------------------------------------------
r47564 | rvargas@google.com | 2010-05-18 22:58:01 +0200 (Tue, 18 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/http/http_cache.h

Create a dedicated cache thread and use it to create the
Http cache.

BUG=26730
TEST=none

Review URL: http://codereview.chromium.org/1989014
------------------------------------------------------------------------
r47558 | cmasone@google.com | 2010-05-18 22:42:56 +0200 (Tue, 18 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Add better error reporting for Chromium OS login

Review URL: http://codereview.chromium.org/2128006
------------------------------------------------------------------------
r47557 | thestig@chromium.org | 2010-05-18 22:39:58 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Fix typos for defined(OS_XXX).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2121006
------------------------------------------------------------------------
r47556 | eroman@chromium.org | 2010-05-18 22:38:25 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js

Fix a typo.

The typo led to access of undefined javascript variable on chrome://net-internals when the load flags were 0.

Review URL: http://codereview.chromium.org/2089015
------------------------------------------------------------------------
r47554 | eroman@chromium.org | 2010-05-18 22:16:30 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js

Aesthetic: fix an awkward formatting of netlog.

The start/end events would get smashed together when the start event had extra parameters (the case where the end event had extra parameters was already being handled properly).

Review URL: http://codereview.chromium.org/2068008
------------------------------------------------------------------------
r47552 | eroman@chromium.org | 2010-05-18 22:02:23 +0200 (Tue, 18 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/net/base/load_flags.h
   A /trunk/src/net/base/load_flags_list.h (from /trunk/src/net/base/load_flags.h:47428)
   M /trunk/src/net/net.gyp

Annotate load flags and net errors with their symbolic name.

Here are some examples showing what it looks like now (the stuff in parenthesis is new):

  --> load_flags = 8240 (DISABLE_CACHE | DISABLE_INTERCEPT | DO_NOT_SAVE_COOKIES)

  --> net_error = -105 (NAME_NOT_RESOLVED)

BUG=37421

Review URL: http://codereview.chromium.org/2115007
------------------------------------------------------------------------
r47549 | dhg@chromium.org | 2010-05-18 21:54:32 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/net/base/platform_mime_util_linux.cc

Adding some known mime types to the platform_mime_utils on linux.  This might not be a perfect solution right now, but its a simple stopgap.

BUG=chromium-os:3242
TEST=none
Review URL: http://codereview.chromium.org/2077006
------------------------------------------------------------------------
r47548 | erg@chromium.org | 2010-05-18 21:51:12 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Themes should change placeholder thumnails and notification boxes on the NTP.

BUG=31584
TEST=none

Review URL: http://codereview.chromium.org/2113005
------------------------------------------------------------------------
r47546 | mrossetti@chromium.org | 2010-05-18 21:40:19 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

If the off-the-side menu is showing and one of its bookmarks is removed then also remove the associated button.

BUG=43351
TEST=Add enough bookmarks to the bookmar bar to cause the off-the-side chevron to appear. Pop up the off-the-side folder menu. Delete one of the bookmarks shown therein using the contextual menu. Verify that the bookmark button disappears. Mouse over other bookmarks in the menu and verify no crash occurs.

Review URL: http://codereview.chromium.org/2122010
------------------------------------------------------------------------
r47545 | estade@chromium.org | 2010-05-18 21:19:42 +0200 (Tue, 18 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.h

GTK: more toolbar corner rounding polish.

DO round the corners AND draw the correct shadow in GTK+ theme mode.
DONT round the corners OR draw the shadow if the browser is maximized or using the system frame (regardless of theme mode).

BUG=43632
TEST=manual

Review URL: http://codereview.chromium.org/2109005
------------------------------------------------------------------------
r47544 | estade@chromium.org | 2010-05-18 21:14:50 +0200 (Tue, 18 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

GTK: prepend protocol to cuts/copies from the omnibox.

I messed this up with r46767

BUG=44244
TEST=cut and copy both prepend the protocol when used on the entire omnibox contents.

Review URL: http://codereview.chromium.org/2081005
------------------------------------------------------------------------
r47540 | cindylau@google.com | 2010-05-18 20:52:29 +0200 (Tue, 18 May 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_cookies_api.cc
   A /trunk/src/chrome/browser/extensions/extension_cookies_api.h
   A /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_cookies_api_constants.h
   A /trunk/src/chrome/browser/extensions/extension_cookies_apitest.cc
   A /trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc
   A /trunk/src/chrome/browser/extensions/extension_cookies_helpers.h
   A /trunk/src/chrome/browser/extensions/extension_cookies_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenu.html
   A /trunk/src/chrome/common/extensions/docs/experimental.cookies.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/cookies/tab.html

Add the new cookies API to Chrome Extensions, minus the event
handler.

BUG=38398
TEST=none

Review URL: http://codereview.chromium.org/841006
------------------------------------------------------------------------
r47534 | scottbyer@chromium.org | 2010-05-18 20:45:25 +0200 (Tue, 18 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_internal.h
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc
   M /trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Turn on cloud print for Chromium OS.

Turn on cloud print for Chromium OS by default.  Replace the placeholder URL of the URL for the to-be service.  Add in a profile item for the cloud print service root URL.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2078010
------------------------------------------------------------------------
r47533 | pkasting@chromium.org | 2010-05-18 20:38:09 +0200 (Tue, 18 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_request_info.h
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/extensions/extension_localization_peer.cc (from /trunk/src/chrome/common/extensions/extension_message_filter_peer.cc:47425)
   A /trunk/src/chrome/common/extensions/extension_localization_peer.h (from /trunk/src/chrome/common/extensions/extension_message_filter_peer.h:47425)
   A /trunk/src/chrome/common/extensions/extension_localization_peer_unittest.cc (from /trunk/src/chrome/common/extensions/extension_message_filter_peer_unittest.cc:47425)
   D /trunk/src/chrome/common/extensions/extension_message_filter_peer.cc
   D /trunk/src/chrome/common/extensions/extension_message_filter_peer.h
   D /trunk/src/chrome/common/extensions/extension_message_filter_peer_unittest.cc
   D /trunk/src/chrome/common/filter_policy.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/resource_response.h
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h

Remove the mostly-unused FilterPolicy class.  Convert the only actually-used bit, FILTER_EXTENSION_MESSAGES, into a bool that's only passed to places that really need it.

Also renames ExtensionMessageFilterPeer to ExtensionLocalizationPeer in hopes of making its one use more apparent.  I added a couple comments too.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2105006
------------------------------------------------------------------------
r47532 | albertb@chromium.org | 2010-05-18 20:36:05 +0200 (Tue, 18 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc

Disable PasswordStoreWinTest.MultipleWDSQueriesOnDifferentThreads while I
investigate why it hangs every now and then.

BUG=43836
TEST=none

Review URL: http://codereview.chromium.org/2051012
------------------------------------------------------------------------
r47531 | pkasting@chromium.org | 2010-05-18 20:28:48 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/common/filter_policy.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/ssl/page_displays_insecure_content.html (from /trunk/src/chrome/test/data/ssl/page_displays_mixed_content.html:47442)
   D /trunk/src/chrome/test/data/ssl/page_displays_mixed_content.html
   A /trunk/src/chrome/test/data/ssl/page_runs_insecure_content.html (from /trunk/src/chrome/test/data/ssl/page_runs_mixed_content.html:47442)
   D /trunk/src/chrome/test/data/ssl/page_runs_mixed_content.html
   A /trunk/src/chrome/test/data/ssl/page_with_dynamic_insecure_content.html (from /trunk/src/chrome/test/data/ssl/page_with_dynamic_mixed_contents.html:47175)
   D /trunk/src/chrome/test/data/ssl/page_with_dynamic_mixed_contents.html
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc

Rename "mixed content" to "insecure content" in as many places as possible, to standardize on a consistent naming scheme.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2069005
------------------------------------------------------------------------
r47529 | rsesek@chromium.org | 2010-05-18 20:06:59 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm

[Mac] Make the size text field in the font settings editable.

BUG=33406
TEST=Chromium-->Preferences-->Under the Hood-->Change font settings-->Change. Type into the size field. The font size changes.

Review URL: http://codereview.chromium.org/2136014
------------------------------------------------------------------------
r47528 | chron@chromium.org | 2010-05-18 20:00:54 +0200 (Tue, 18 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Reverse shutdown order for data type manager. Fix race condition.

Review URL: http://codereview.chromium.org/2068007
------------------------------------------------------------------------
r47527 | mrossetti@chromium.org | 2010-05-18 19:58:37 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm

Don't delete and re-add bookmark nodes which have been edited, instead, update its URL and title and then move to its new parent only if necessary.

BUG=44094
TEST=1) Edit a bookmark on the bookmark bar without changing its parent (moving it to a folder) and verify that there is no 'poof' animation. 2) Edit a bookmark on the bookmark bar but change its parent to be a folder and verify that it moved to the last place in the new parent and does not show the poof animation. 3) Edit a bookmark in a folder moving it to the bookmark bar and verify that it moves to the last position on the bar and does not show a poof animation.

Review URL: http://codereview.chromium.org/2120006
------------------------------------------------------------------------
r47525 | dhg@chromium.org | 2010-05-18 19:25:19 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing setdownloads so it gets downloads that are OTR, and downloads that are save as (such as images)

BUG=chromium-os:1581
TEST=none

Review URL: http://codereview.chromium.org/2074009
------------------------------------------------------------------------
r47523 | mrossetti@chromium.org | 2010-05-18 19:11:02 +0200 (Tue, 18 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_unittest_helper.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h

Implement drag from bookmark manager to bookmark bar or a folder thereof. Implement drag of other bookmark and URL sources such as from the Desktop or a text selection.

BUG=39884,44228
TEST=Note: For all drag operations verify that the appropriate drop indicator is presented while dragging. When dragging onto a bookmark bar folder the folder button should be highlighted and, after a short delay, open into a menu. When dragging between folders or on top of a non-folder bookmark an insertion bar (vertical when in the bookmark bar, horizontal when in a folder menu) should be presented. For 'copy' moves the drag image should be adorned with a plus sign in a green circle. A non-copy move should show no such tag. 
1) Drag a non-folder bookmark from the bookmark manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the bookmark is moved to be on the bar just before the bookmark upon which is was dropped. 
2) Drag a folder bookmark from the manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the folder (as a folder) is moved to be on the bar just before the bookmark upon which is was dropped. 
3) Drag a bookmark from the manager to a folder on the bookmark bar. Verify that the bookmark is added to the folder at the end and removed from the old location in the manager. 
4) Drag a bookmark from the manager to a folder on the bookmark bar and wait for the folder to open and then drag to within the folder. Verify that dropping places the bookmark and removes it from the old location in the manager. 
5) Drag a bookmark from the bar to the manager and verify that the manager now shows the dragged bookmark. (Note that this should be a 'move' but is currently a 'copy'. See http://crbug.com/44039.) 
6) Drag a bookmark clipping from the Finder Desktop to the bookmark bar. Verify that it is added to the bar as a new bookmark. 
7) Drag a bookmark clipping from the Finder Desktop to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder as a new bookmark. 
8) Create a URL in TextEdit or Stickies, select it and drag to the bookmark bar. Verify that it is added to the bar. 
9) Create a URL in TextEdit or Stickies, select it and drag to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder. 
Review URL: http://codereview.chromium.org/2066001
------------------------------------------------------------------------
r47522 | tonyg@chromium.org | 2010-05-18 19:09:33 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

Wire sending/receiving cacheable metadata from the renderer
to the disk cache.

BUG=32407
TEST=None
Review URL: http://codereview.chromium.org/1698001
------------------------------------------------------------------------
r47510 | arv@chromium.org | 2010-05-18 15:58:48 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc

NTP: Fix warnings on Mac.

BUG=None
TEST=None
TBR=finnur

------------------------------------------------------------------------
r47508 | arv@chromium.org | 2010-05-18 15:29:15 +0200 (Tue, 18 May 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/app_launched_animation.h
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/download/download_started_animation.h
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   A /trunk/src/chrome/browser/views/app_launched_animation_win.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/chrome_browser.gypi

NTP: Adds an app launched animation.

This uses a popup window that is carefully positioned to be placed over the icon on the NTP. The popup fades out after a short delay.

BUG=None
TEST=Start with --enable-apps and launch an app. The icon should *stick* for a very short period and then fade out.

Review URL: http://codereview.chromium.org/2095008
------------------------------------------------------------------------
r47507 | tfarina@chromium.org | 2010-05-18 15:06:38 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h

gtk: Make use of gtk signal macros in FirstRunDialog.

BUG=None
TEST=manually. Run out/Debug/chrome --first-run. Everything should works as before.

Review URL: http://codereview.chromium.org/1998013
------------------------------------------------------------------------
r47504 | satorux@chromium.org | 2010-05-18 13:40:01 +0200 (Tue, 18 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Handle pinyin's zh as zh-CN.

This is to make it compatible with the UI language code used in Chrome.
zh-CN is used for UI language code of Simplified Chinese.

BUG=chromium-os:2843
TEST=added a unit test and ran out/Release/unit_tests --gtest_filter='LanguageLibrary*'

Review URL: http://codereview.chromium.org/2102008
------------------------------------------------------------------------
r47503 | nkostylev@google.com | 2010-05-18 12:06:49 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Check if current screen is already showing during OOBE.

BUG= http://crosbug.com/3053
TEST=N/A

Review URL: http://codereview.chromium.org/2076002
------------------------------------------------------------------------
r47499 | eroman@chromium.org | 2010-05-18 08:38:33 +0200 (Tue, 18 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/httpcacheview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js

Removed the "Reload" button from the HTTP cache tab of the net-internals page.

The "Reload" button was used to refresh the stats + cache listings.
With this change, I poll the statistics for updates, so the reload button is unecessary.

Note that the cache listing is too expensive to poll, so I replaced it with a link to a listings page.

Lastly, updated the text dump to include the http cache statistics.

BUG=37421

Review URL: http://codereview.chromium.org/2085005
------------------------------------------------------------------------
r47493 | satorux@chromium.org | 2010-05-18 06:21:10 +0200 (Tue, 18 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Make the font size in the candidate window bigger again.

Even with r47236, the Chinese characters look still small on the netbook.

BUG=chromium-os:2904
TEST=manually

Review URL: http://codereview.chromium.org/2136006
------------------------------------------------------------------------
r47489 | satorux@chromium.org | 2010-05-18 05:57:01 +0200 (Tue, 18 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Fix a bug that caused two status areas are shown when ibus-mozc is used.

The root cause of the problem was a hack for ibus-anthy, that is no longer
necessary. Get rid of the hack.

Change the code to show the auxiliary text in the footer area when the
orientation is vertical.

BUG=chromium-os:3301
TEST=manually

Review URL: http://codereview.chromium.org/2087008
------------------------------------------------------------------------
r47482 | tfarina@chromium.org | 2010-05-18 03:13:41 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove --omnibox-popup-count flag.

BUG=40083
TEST=compiles

Review URL: http://codereview.chromium.org/2013008
------------------------------------------------------------------------
r47479 | jar@chromium.org | 2010-05-18 02:39:18 +0200 (Tue, 18 May 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   A /trunk/src/chrome/browser/net/preconnect.cc
   A /trunk/src/chrome/browser/net/preconnect.h
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/net/base/host_port_pair.cc
   M /trunk/src/net/base/host_port_pair.h

Support speculative pre-connection to search URLs

Implement several flavors of TCP/IP speculative preconnection
under a command line flag (not yet on by default).

The first area of preconnection takes place when a user types
a query into the omnibox, as we preconnect to the search service
when the omnibox suggests it is going to do a search.

The second area involves subresources, such as images.
When a navigation takes place, and we've seen navigations
to that domain/port before, and the history-based 
probabability that we'll need to make a connection to
a second site (host/port) is sufficiently large, then we
preconnect to that second site while we are still connecting
to the primary site (and before we've gotten content from
the primary site.

We also fall-back to mere DNS pre-resolution of subresource
hostnames when the probability of a connection to the
subresource is not high enough.

BUG=42694
r=pkasting,willchan,mbelshe
Review URL: http://codereview.chromium.org/1585029
------------------------------------------------------------------------
r47478 | erg@chromium.org | 2010-05-18 02:35:27 +0200 (Tue, 18 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: Allow users to override fonts and font sizes in gtk-mode.

This works on both the location bar and the find bar, the only places I could
find where we do weird stuff with widgets. We still force font sizes in
chrome-theme mode.

Effectively, while this doesn't completely solve 22614, it should mitigate the
symptoms in a lot of cases.

BUG=12195,22614
TEST=In GNOME, change your system font while chrome is in gtk-theme mode. The font in the location bar and in the find bar should match the application font.

Review URL: http://codereview.chromium.org/2124005
------------------------------------------------------------------------
r47475 | eroman@chromium.org | 2010-05-18 01:53:09 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/url_request/url_request.cc

Fix the logging of URL_REQUEST_START, so the nesting is correct on redirects.

(It was possible to get unmatched start/end before).

Also renamed the event to URL_REQUEST_START_JOB, since it is really a superset of URLRequest::Start().
Review URL: http://codereview.chromium.org/2091009
------------------------------------------------------------------------
r47473 | sky@chromium.org | 2010-05-18 01:44:34 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   A /trunk/src/chrome/browser/views/tabs/base_tab.cc (from /trunk/src/chrome/browser/views/tabs/base_tab_renderer.cc:47448)
   A /trunk/src/chrome/browser/views/tabs/base_tab.h (from /trunk/src/chrome/browser/views/tabs/base_tab_renderer.h:47448)
   D /trunk/src/chrome/browser/views/tabs/base_tab_renderer.cc
   D /trunk/src/chrome/browser/views/tabs/base_tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   R /trunk/src/chrome/browser/views/tabs/tab.cc (from /trunk/src/chrome/browser/views/tabs/tab_renderer.cc:47448)
   R /trunk/src/chrome/browser/views/tabs/tab.h (from /trunk/src/chrome/browser/views/tabs/tab_renderer.h:47448)
   A /trunk/src/chrome/browser/views/tabs/tab_controller.h
   D /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   D /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactors renderer related classes for better sharing.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2089012
------------------------------------------------------------------------
r47471 | mpcomplete@chromium.org | 2010-05-18 01:32:05 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Fix a bug where incognito renderer hosts would not receive updates for
extensions.

BUG=42787

Review URL: http://codereview.chromium.org/2110007
------------------------------------------------------------------------
r47470 | nirnimesh@chromium.org | 2010-05-18 01:22:12 +0200 (Tue, 18 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Omnibox automation should wait for page load after selecting a popup item.

TEST=python chrome/test/functional/omnibox.py omnibox.OmniboxTest.testSelect

Review URL: http://codereview.chromium.org/2136010
------------------------------------------------------------------------
r47467 | arv@chromium.org | 2010-05-18 00:51:31 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmarks: Localize Recent and Search tree items.

BUG=42116
TEST=None

Review URL: http://codereview.chromium.org/2102007
------------------------------------------------------------------------
r47466 | oshima@chromium.org | 2010-05-18 00:26:24 +0200 (Tue, 18 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h

removing unnecessary null check for delete.
fix variable name that seems to be cut&copy error. (loader_  makes sense only for library_loader, and others should be lib_)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2128007
------------------------------------------------------------------------
r47463 | rsesek@chromium.org | 2010-05-18 00:07:28 +0200 (Tue, 18 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

Replace hard-coded strings in CookiesWindowControllerTest with their GRIT values.

BUG=none
TEST=CookiesWindowControllerTest.*

Review URL: http://codereview.chromium.org/2129006
------------------------------------------------------------------------
r47460 | jcivelli@chromium.org | 2010-05-17 23:46:31 +0200 (Mon, 17 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h

Disable app launcher animation on ChromeOS. It causing the app launcher to resize to a wrong size.

BUG=None
TEST=On ChromeOS, press the new tab button, the app launcher should show
     correctly.

Review URL: http://codereview.chromium.org/2108007
------------------------------------------------------------------------
r47454 | ctguil@chromium.org | 2010-05-17 23:09:13 +0200 (Mon, 17 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/accessibility/view_accessibility.h
   M /trunk/src/views/accessibility/view_accessibility_wrapper.h
   M /trunk/src/views/window/dialog_delegate.h
   M /trunk/src/views/window/window_delegate.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Provide accessibility support for Window_win.
TEST=Ensure that the About Chrome dialog has proper accessibility role.
BUG=none
Review URL: http://codereview.chromium.org/1838002
------------------------------------------------------------------------
r47452 | stuartmorgan@chromium.org | 2010-05-17 23:04:35 +0200 (Mon, 17 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.cc
   M /trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.h

Add 64-bit guards to the Carbon plugin interpose code

We already don't compile the code to load the library for 64-bit, this makes it so we also don't try to build anything into it.

BUG=None
TEST=Eventually we should be able to compile for 64-bit on the Mac.

Review URL: http://codereview.chromium.org/2090007
------------------------------------------------------------------------
r47451 | scherkus@chromium.org | 2010-05-17 23:04:02 +0200 (Mon, 17 May 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/chromeos/system_key_event_listener.cc
   A /trunk/src/chrome/browser/chromeos/system_key_event_listener.h
   M /trunk/src/chrome/chrome_browser.gypi

Handling volume up/down/mute keypresses within Chrome.

When Window Manager sends us a NOTIFY_SYSKEY_CLICKED message,
we adjust the volume accordingly.  Currently just calling
amixer as WM was doing before.  There will be a different
change submitted for WM to send this message instead of
calling amixer itself.

Patch by davej@chromium.org:
http://codereview.chromium.org/2102001/show

BUG=cros/525
TEST=none

Related to issue 2107001.

Review URL: http://codereview.chromium.org/2107010
------------------------------------------------------------------------
r47450 | eroman@chromium.org | 2010-05-17 23:03:44 +0200 (Mon, 17 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js

On the net-internals text dump, display times as unix timestamps rather than timeticks.
Also use a prettier display for the DNS cache and "bad proxy" cache.

BUG=37421

Review URL: http://codereview.chromium.org/2120002
------------------------------------------------------------------------
r47445 | chron@chromium.org | 2010-05-17 22:31:14 +0200 (Mon, 17 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Attempt to recommit issue 2013017. Switch sync servers based on channel.

This time around i've tested it on the mac with a full build. Fixed string16 issues.

Review URL: http://codereview.chromium.org/2133002
------------------------------------------------------------------------
r47442 | brettw@chromium.org | 2010-05-17 21:37:49 +0200 (Mon, 17 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Adding HistoryService::QueryMostVisitedURLs and tests. 

BUG=None
TEST=HistoryTest::MostVisitedURLs
Original review: http://codereview.chromium.org/2099004
Checked in for Nik Sckrob
------------------------------------------------------------------------
r47439 | suzhe@chromium.org | 2010-05-17 20:48:58 +0200 (Mon, 17 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.cc

[Linux]Fix a redraw issue when expanding a GtkChromeShrinkableHBox.

BUG=44379 gtk_chrome_shrinkable_hbox may redraw children with incorrect size allocation.
TEST=see bug report.

Review URL: http://codereview.chromium.org/2120005
------------------------------------------------------------------------
r47432 | thestig@chromium.org | 2010-05-17 20:10:26 +0200 (Mon, 17 May 2010) | 5 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_linux.cc
   M /trunk/src/app/clipboard/clipboard_unittest.cc
   M /trunk/src/app/clipboard/scoped_clipboard_writer.cc
   M /trunk/src/app/clipboard/scoped_clipboard_writer.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc

Linux: Null terminate text/html data we send to the clipboard. Change WriteHyperlink to take string16 anchor text.

BUG=42624
TEST=none
Review URL: http://codereview.chromium.org/2036013
------------------------------------------------------------------------
r47431 | estade@chromium.org | 2010-05-17 20:07:50 +0200 (Mon, 17 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Reinstate separator before Inspect Elements in debugger context menu.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2083007
------------------------------------------------------------------------
r47430 | thomasvl@chromium.org | 2010-05-17 20:05:25 +0200 (Mon, 17 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] stop the animation during window close and clear the animation delegate to avoid stale weak references.

BUG=44225
TEST=see bug
Review URL: http://codereview.chromium.org/2122008
------------------------------------------------------------------------
r47429 | estade@chromium.org | 2010-05-17 20:01:57 +0200 (Mon, 17 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: size popup windows by their content, not outer bounds.

This regressed in r43790 (my fault, as I reviewed it). There used to be a test that covered this functionality, but the test was removed in r37819.

BUG=44107
TEST=none.

Review URL: http://codereview.chromium.org/2109004
------------------------------------------------------------------------
r47428 | pkasting@chromium.org | 2010-05-17 19:38:47 +0200 (Mon, 17 May 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   A /trunk/src/chrome/test/data/ssl/page_displays_mixed_content.html (from /trunk/src/chrome/test/data/ssl/page_displays_mixed_content.html:47356)
   A /trunk/src/chrome/test/data/ssl/page_runs_mixed_content.html (from /trunk/src/chrome/test/data/ssl/page_runs_mixed_content.html:47356)
   D /trunk/src/chrome/test/data/ssl/page_with_http_script.html
   D /trunk/src/chrome/test/data/ssl/page_with_mixed_contents.html
   M /trunk/src/chrome_frame/chrome_active_document.cc

Reland r47347 [was reverted in r47357], this time without re-enabling a DISABLED test that times out on Mac. (Original patch reviewed at http://codereview.chromium.org/2067003 )

Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".

Make the "display" state only affect the current tab (not the entire host).

Fix an SSL browser test by supplying the appropriate SiteInstance*.

Move a test from "disabled" to "flaky" since it at least passes for me.

Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.

BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
Review URL: http://codereview.chromium.org/2126005
------------------------------------------------------------------------
r47427 | jcivelli@chromium.org | 2010-05-17 19:33:27 +0200 (Mon, 17 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/common/notification_type.h

Animates the app launcher when it is shown.
Also, made the info-bubble HWND on Windows owned by its border widget so that it shows on top. That way we don't have to create a hole in the border widget to make it visible.

BUG=None
TEST=Make sure other info-bubble (bookmark bubble, extension bubbles...) work as expected. Test that when tarting Chrome with --app-panel, creating a new tab shows the apps launcher with an animation.

Review URL: http://codereview.chromium.org/2096004
------------------------------------------------------------------------
r47424 | ctguil@chromium.org | 2010-05-17 18:58:42 +0200 (Mon, 17 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Mark BrowserViewsAccessibilityTest.TestChromeWindowAccObj as flaky.

I've seen this fail on my local machine as well as on the try server. Looks like there's a race condition.

BUG=none
TEST=none
TBR=dmazonni@chromium.org

------------------------------------------------------------------------
r47423 | xiyuan@chromium.org | 2010-05-17 18:49:57 +0200 (Mon, 17 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

Close options dialog when "Get Theme" is clicked.

BUG=chromium-os:3061
TEST=Verify options dialog is closed when "Get Theme" link is clicked per chromium-os:3061.

Review URL: http://codereview.chromium.org/2090003
------------------------------------------------------------------------
r47415 | satish@chromium.org | 2010-05-17 16:13:16 +0200 (Mon, 17 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Re-enable layout test for web storage quota.

Since WebKit r59457, this test is rebaselined and can be enabled again.

Landing http://codereview.chromium.org/2078009/show

BUG=42740
TEST=ui_tests --gtest_filter=DOMStorageTest.RootLayoutTests
TEST=run_webkit_tests.sh --debug storage/domstorage/quota.html

Review URL: http://codereview.chromium.org/2066006
------------------------------------------------------------------------
r47413 | dpolukhin@chromium.org | 2010-05-17 14:24:02 +0200 (Mon, 17 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/message_bubble.cc

Show error message for authenticator in info bubbles.
For now this extra text is not localized.
Added max width for info bubble, text will be wrapped.

BUG=crosbug.com/3274
TEST=On Chrome OS login type wrong password.

Review URL: http://codereview.chromium.org/2084006
------------------------------------------------------------------------
r47408 | bulach@chromium.org | 2010-05-17 12:25:10 +0200 (Mon, 17 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/test/data/geolocation/simple.html

Adds tests to ensure Geolocation requests permission happens at the right time.
It needs to be after calling navigator.geolocation.getCurrentPosition()/watchPosition() rather than just accessing navigator.geolocation.
Depends on https://bugs.webkit.org/show_bug.cgi?id=38323.

BUG=42789
TEST=GeolocationBrowserTest.NoInfoBarBeforeStart

Review URL: http://codereview.chromium.org/1950001
------------------------------------------------------------------------
r47404 | satorux@chromium.org | 2010-05-17 11:42:07 +0200 (Mon, 17 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Fix a bug that caused buttons in "Languages and Input" dialog to be truncated.

Change the layout so the input method configure button will be shown right
next to the input method name (the layout was bad as the row was sharing the
same columnset with the huge the "Display Google Chrome in this language"
button).

Also widen the width of the dialog from 96 to 106, so the "Display Google
Chrome in this language" button does not get truncated. To do this, define
separate dialog size settings for this dialog.

BUG=chromium-os:3235
TEST=manually

Review URL: http://codereview.chromium.org/2106008
------------------------------------------------------------------------
r47397 | tyoshino@chromium.org | 2010-05-17 09:07:01 +0200 (Mon, 17 May 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc

Revert 47396 - Revert 47363  Fix build on ChromeOS by adding required return value checks.

Relands. It's irrelative.

http://buildbot.jail.google.com/buildbot/waterfall/builders/Mac10.5%20Tests%20(dbg)(2)/builds/16790

TBR=sky

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2098007

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/2076004

TBR=tyoshino@chromium.org
Review URL: http://codereview.chromium.org/2073009
------------------------------------------------------------------------
r47396 | tyoshino@chromium.org | 2010-05-17 08:53:33 +0200 (Mon, 17 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc

Revert 47363 - Fix build on ChromeOS by adding required return value checks.

It looks that this change caused lots of test failures. Reverts for now and wait and see.

http://buildbot.jail.google.com/buildbot/waterfall/builders/Mac10.5%20Tests%20(dbg)(2)/builds/16790

TBR=sky

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2098007

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/2076004
------------------------------------------------------------------------
r47390 | eroman@chromium.org | 2010-05-17 01:54:28 +0200 (Mon, 17 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js

Aesthetic: fix a formatting issue where certain log entries were not prefixed with '+'.
TBR=willchan

Review URL: http://codereview.chromium.org/2098008
------------------------------------------------------------------------
r47387 | sky@chromium.org | 2010-05-17 00:13:22 +0200 (Mon, 17 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/views/tabs/base_tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

More TabStrip refactoring.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2124003
------------------------------------------------------------------------
r47386 | eroman@chromium.org | 2010-05-16 21:42:46 +0200 (Sun, 16 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/host_resolver_proc.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc

Log the OS error that getaddrinfo() failed with.
- Display it on the about:net-internals page
- Collect it in the histogram Net.OSErrorsForGetAddrinfo.

Review URL: http://codereview.chromium.org/2134004
------------------------------------------------------------------------
r47376 | willchan@chromium.org | 2010-05-16 02:59:10 +0200 (Sun, 16 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_session_pool.cc

Reland 47342.

Fixes the merge issue this time.  Also fixes a TODO in another change that was blocked on this one.
Support SpdySession as a new NetLog source type. Start logging some more SPDY control frames.
Original code review: http://codereview.chromium.org/2102003/show
BUG=43237

Review URL: http://codereview.chromium.org/2114003
------------------------------------------------------------------------
r47371 | sky@chromium.org | 2010-05-15 17:06:57 +0200 (Sat, 15 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Fixes bug in tabstrip where close was always treated as if the user
closed the tab by way of mouse.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2106006
------------------------------------------------------------------------
r47370 | tfarina@chromium.org | 2010-05-15 16:31:14 +0200 (Sat, 15 May 2010) | 6 lines
Changed paths:
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer_data_types.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Use FilePath in ProfileInfo struct.

BUG=24672
TEST=out/Debug/unit_tests

Review URL: http://codereview.chromium.org/1741012
------------------------------------------------------------------------
r47363 | phajdan.jr@chromium.org | 2010-05-15 10:43:42 +0200 (Sat, 15 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc

Fix build on ChromeOS by adding required return value checks.

TBR=sky

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2098007
------------------------------------------------------------------------
r47362 | phajdan.jr@chromium.org | 2010-05-15 10:33:24 +0200 (Sat, 15 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/cross_origin_xhr_apitest.cc
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_clipboard_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_history_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_javascript_url_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/fragment_navigation_apitest.cc
   M /trunk/src/chrome/browser/extensions/isolated_world_apitest.cc
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/test/automation/dom_automation_browsertest.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

[GTTF] Check the result value of StartHTTPServer to avoid
test hangs in cases when the server fails to start.

The tests will still fail in that case, obviously,
but will no longer hang (or crash), which is an
improvement.

TEST=browser_tests
BUG=none

Review URL: http://codereview.chromium.org/2095004
------------------------------------------------------------------------
r47357 | rvargas@google.com | 2010-05-15 04:59:07 +0200 (Sat, 15 May 2010) | 29 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   D /trunk/src/chrome/test/data/ssl/page_displays_mixed_content.html
   D /trunk/src/chrome/test/data/ssl/page_runs_mixed_content.html
   A /trunk/src/chrome/test/data/ssl/page_with_http_script.html (from /trunk/src/chrome/test/data/ssl/page_with_http_script.html:47346)
   A /trunk/src/chrome/test/data/ssl/page_with_mixed_contents.html (from /trunk/src/chrome/test/data/ssl/page_with_mixed_contents.html:47346)
   M /trunk/src/chrome_frame/chrome_active_document.cc

Revert 47347 - (Original patch reviewed at http://codereview.chromium.org/2067003 )

Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".

Make the "display" state only affect the current tab (not the entire host).

Fix an SSL browser test by supplying the appropriate SiteInstance*.

Move a test from "disabled" to "flaky" since it at least passes for me.

Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.


Falied TestGoodFrameNavigation on Mac 10.5 browser tests

among other things:
/b/slave/chromium-rel-mac-builder/build/src/chrome/browser/ssl/ssl_browser_tests.cc:43: Failure
Value of: entry->ssl().displayed_mixed_content()
  Actual: false
Expected: displayed_mixed_content
Which is: true


BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2095006
------------------------------------------------------------------------
r47349 | scherkus@chromium.org | 2010-05-15 02:47:17 +0200 (Sat, 15 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/chat_manager/background.html
   A /trunk/src/chrome/browser/resources/chat_manager/central_roster.html
   A /trunk/src/chrome/browser/resources/chat_manager/central_roster_viewer.html
   A /trunk/src/chrome/browser/resources/chat_manager/js/centralrosterhook.js
   M /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgeeventtypes.js
   M /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgehook.js
   M /trunk/src/chrome/browser/resources/chat_manager/js/gmailbridgehook.js
   M /trunk/src/chrome/browser/resources/chat_manager/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi

Reworked extension to leverage magic iframes for speedy load times
and modified communication with chat engine for increased reliability.

Patch by seh@chromium.org:
http://codereview.chromium.org/2065004/show

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2094007
------------------------------------------------------------------------
r47348 | mattm@chromium.org | 2010-05-15 02:42:57 +0200 (Sat, 15 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc

Posix: implement diagnostics mode console output.

BUG=42894,42345
TEST=chrome --diagnostics

Review URL: http://codereview.chromium.org/2115001
------------------------------------------------------------------------
r47347 | pkasting@chromium.org | 2010-05-15 02:38:36 +0200 (Sat, 15 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   A /trunk/src/chrome/test/data/ssl/page_displays_mixed_content.html (from /trunk/src/chrome/test/data/ssl/page_with_mixed_contents.html:47323)
   A /trunk/src/chrome/test/data/ssl/page_runs_mixed_content.html (from /trunk/src/chrome/test/data/ssl/page_with_http_script.html:47323)
   D /trunk/src/chrome/test/data/ssl/page_with_http_script.html
   D /trunk/src/chrome/test/data/ssl/page_with_mixed_contents.html
   M /trunk/src/chrome_frame/chrome_active_document.cc

(Original patch reviewed at http://codereview.chromium.org/2067003 )

Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".

Make the "display" state only affect the current tab (not the entire host).

Fix an SSL browser test by supplying the appropriate SiteInstance*.

Move a test from "disabled" to "flaky" since it at least passes for me.

Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.

BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
------------------------------------------------------------------------
r47344 | akalin@chromium.org | 2010-05-15 02:36:16 +0200 (Sat, 15 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/common/net/notifier/base/async_network_alive.h
   D /trunk/src/chrome/common/net/notifier/base/linux/async_network_alive_linux.cc
   D /trunk/src/chrome/common/net/notifier/base/mac/network_status_detector_task_mac.cc
   D /trunk/src/chrome/common/net/notifier/base/mac/network_status_detector_task_mac.h
   D /trunk/src/chrome/common/net/notifier/base/mac/network_status_detector_task_mac_unittest.cc
   D /trunk/src/chrome/common/net/notifier/base/network_status_detector_task.cc
   D /trunk/src/chrome/common/net/notifier/base/network_status_detector_task.h
   D /trunk/src/chrome/common/net/notifier/base/network_status_detector_task_mt.cc
   D /trunk/src/chrome/common/net/notifier/base/network_status_detector_task_mt.h
   D /trunk/src/chrome/common/net/notifier/base/win/async_network_alive_win32.cc
   M /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.cc
   M /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.h
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.h
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc

Replaced NetworkStatusDetector with use of NetworkChangeNotifier
from net/.

Removed NetworkStatusDetector files and related.

Cleaned up some test-related code.

BUG=19784
TEST=manually

Review URL: http://codereview.chromium.org/1451001
------------------------------------------------------------------------
r47343 | willchan@chromium.org | 2010-05-15 02:28:32 +0200 (Sat, 15 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_session_pool.cc

Revert 47342 - Support SpdySession as a new NetLog source type. Start logging some more SPDY control frames.
BUG=43237

Review URL: http://codereview.chromium.org/2102003

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/2118003
------------------------------------------------------------------------
r47342 | willchan@chromium.org | 2010-05-15 02:21:00 +0200 (Sat, 15 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_session_pool.cc

Support SpdySession as a new NetLog source type. Start logging some more SPDY control frames.
BUG=43237

Review URL: http://codereview.chromium.org/2102003
------------------------------------------------------------------------
r47338 | oshima@chromium.org | 2010-05-15 01:48:27 +0200 (Sat, 15 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_screen_lock_library.h
   A /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   A /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   A /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Hook up ScreenLocker to screen lock cros library.
 * Added ScreenLockerLibrary and its mock class.
 * Call NotifyScreenLockCompleted when screen locker is shown
 * Call NotifyScreenUnlocked when authentication is sucessful.
 * Replace includes in cros_in_process_browser_test.cc with forward declarations.
  * Added ScreenLockerTester for testing
  * Added new browser test ScreenLockerTest.TestBasic

BUG=2914
TEST=added ScreenLockerTest.TestBasic browser test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47216

Review URL: http://codereview.chromium.org/2025009
------------------------------------------------------------------------
r47332 | aa@chromium.org | 2010-05-15 01:04:41 +0200 (Sat, 15 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Make app icons even wider.

TBR=arv@chromium.org
------------------------------------------------------------------------
r47331 | dhollowa@chromium.org | 2010-05-15 01:04:37 +0200 (Sat, 15 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field.h
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc

AutoFill filling billing address and company name from profile.

The lego.com page represents a couple different issues.  (1) is that the address fields are identified as billing address fields.  So when filling from a profile and not a credit card those fields did not get filled.  Based on discussion with Jeff Chang we're changing this so that when filling a profile, billing fields get treated as normal address fields and will be filled.  In the code the distinction of billing versus "home" address information has now been removed as it is no longer applicable.  (2)  Company fields now get heuristically matched and filled.

BUG=40683
TEST=Manual testing of https://shop.lego.com/Checkout/Address/, \
Unit tests: AddressFieldTest.ParseCompany, AddressFieldTest.ParseCompanyEcml \
FormStructureTest.HeuristicsWithBilling FormStructureTest.HeuristicsSample6

Review URL: http://codereview.chromium.org/2085006
------------------------------------------------------------------------
r47322 | finnur@chromium.org | 2010-05-15 00:08:35 +0200 (Sat, 15 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h

Add missing virtual functions for ChromeOS.

TBR=jcivelli
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2069003
------------------------------------------------------------------------
r47321 | eroman@chromium.org | 2010-05-14 23:52:36 +0200 (Fri, 14 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request.cc
   A /trunk/src/net/url_request/url_request_netlog_params.cc
   A /trunk/src/net/url_request/url_request_netlog_params.h

Add the URLRequest's method and load flags to the NetLog.

BUG=37421

Review URL: http://codereview.chromium.org/2108003
------------------------------------------------------------------------
r47320 | rsesek@chromium.org | 2010-05-14 23:45:51 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm

Fix a Memcheck:Cond caused by not setting |cert_id_| in the PageInfoWindowMac testing ctor.

BUG=none
TEST=Mac Valgrind unit goes green.

Review URL: http://codereview.chromium.org/2088005
------------------------------------------------------------------------
r47318 | finnur@chromium.org | 2010-05-14 23:40:42 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.h
   M /trunk/src/chrome/browser/views/location_bar/star_view.h

Add fade-out animation to the app launcher.

BUG=None
TEST=App launcher panel should fade away instead of disappearing immediately.

Review URL: http://codereview.chromium.org/2109003
------------------------------------------------------------------------
r47315 | akalin@chromium.org | 2010-05-14 23:38:41 +0200 (Fri, 14 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/common/net/notifier/base/async_dns_lookup.cc
   M /trunk/src/chrome/common/net/notifier/base/network_status_detector_task_mt.cc
   M /trunk/src/chrome/common/net/notifier/base/signal_thread_task.h
   M /trunk/src/chrome/common/net/notifier/base/win/async_network_alive_win32.cc
   M /trunk/src/chrome/common/net/notifier/base/win/time_win32.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login_failure.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login_settings.cc
   M /trunk/src/chrome/common/net/notifier/communicator/mailbox.cc
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/common/net/test_url_fetcher_factory.h

Changed used of ASSERT() to DCHECK().

Removed dead code.

Cleaned up some tests.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2128001
------------------------------------------------------------------------
r47314 | jcivelli@chromium.org | 2010-05-14 23:29:26 +0200 (Fri, 14 May 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/app/theme/app_launcher_button.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/view_ids.h
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Removing the app launcher button in the ChromeOS browser and making the app launcher pinned to the location bar.

BUG=3190
TEST=The app launcher icon on the top-left corner of the browser should
     be gone.  Opening a new tab by pressing the + button or typing
     CTRL-T should bring the app launcher, it should be located on top
     of the location bar.

Review URL: http://codereview.chromium.org/2060004
------------------------------------------------------------------------
r47313 | pvalchev@google.com | 2010-05-14 23:27:32 +0200 (Fri, 14 May 2010) | 4 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/webkit/glue/webkit_resources.grd

cleaner grd files: use os.find('bsd') instead of listing all the version
of freebsd, openbsd and possibly netbsd in the future
via sprewell
Review URL: http://codereview.chromium.org/2099003
------------------------------------------------------------------------
r47311 | nirnimesh@chromium.org | 2010-05-14 23:10:58 +0200 (Fri, 14 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/omnibox.py
   A /trunk/src/chrome/test/pyautolib/omnibox_info.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Add automation hooks for fetching info about omnibox

1. Make the use of browser explicit for each json handler so that handlers
that need access to Browser* can have it. Omnibox needs it.
2. Add a simple test

TEST=python chrome/test/functional/omnibox.py

Review URL: http://codereview.chromium.org/2015010
------------------------------------------------------------------------
r47310 | erg@chromium.org | 2010-05-14 23:03:27 +0200 (Fri, 14 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h

GTK: Polish find bar in gtk mode.

- Remove font constraints in GTK+ mode.
- Prevent Clearlooks engine from drawing over widgets.

BUG=43141
TEST=none

Review URL: http://codereview.chromium.org/2095005
------------------------------------------------------------------------
r47305 | eroman@chromium.org | 2010-05-14 22:23:55 +0200 (Fri, 14 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc

Delete code: Remove support from PassiveLogCollector for "unbounded passive logging".
This is no longer needed, since the new net-internals receives the full event stream while it is open.

Review URL: http://codereview.chromium.org/2113002
------------------------------------------------------------------------
r47301 | rsesek@chromium.org | 2010-05-14 21:47:28 +0200 (Fri, 14 May 2010) | 12 lines
Changed paths:
   D /trunk/src/chrome/app/nibs/PageInfo.xib
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   D /trunk/src/chrome/browser/cocoa/page_info_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   A /trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Rewrite the page info window to be built dynamically.

Rather than using a XIB, the window is now built entirely in code. The Controller's
unit test has been removed because after this it is functionally useless. A new test
for the bridge has been added.

This also fixes the text clipping bug for the mixed content warning.

BUG=23438,30843
TEST=No functional change; partially covered by unit tests.

Review URL: http://codereview.chromium.org/2066003
------------------------------------------------------------------------
r47297 | dhollowa@chromium.org | 2010-05-14 21:21:18 +0200 (Fri, 14 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/fax_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/name_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/password_form_dom_manager.cc

Form AutoFill Phone number should be displayed as xxx-xxx-xxxx

Modifies the AutoFill label inferencing logic to skip over <img> tags when deriving labels.  It is common to use
small images as spacers between elements.  Also, extends the phone number heuristics to recognize numbers that are
split into three fields of the form [xxx]-[yyy]-[zzzz] where xxx is the area code, yyy is the phone number prefix and zzz
is the phone number suffix.

Note: This change has a dependency on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=38825.
Will need to wait for that to land before committing this change.

BUG=38218
TEST=FormManagerTest.LabelsInferredWithImageTags:FormStructureTest.ThreePartPhoneNumber:PhoneFieldTest.ThreePartPhoneNumber

Review URL: http://codereview.chromium.org/1979008
------------------------------------------------------------------------
r47293 | erg@chromium.org | 2010-05-14 21:08:55 +0200 (Fri, 14 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK: Match link colors.

- Realize our fake window in the GtkThemeProvider so we can access the style
  properties.
- Make sure we don't generate the markup for a GtkChromeLinkButton until
  after it is realized.
- Make sure GtkChromeLinkButton responds to system wide style theme changes.

BUG=43850
TEST=Open up chrome to the NTP with an empty bookmark bar in GTK+ theme mode. The links on the NTP should match the GTK+ link color, and so should the import bookmark link in the bookmark bar. Change your GTK+ theme to one with a different link color. The NTP and import bookmark link should change to the new color.

Review URL: http://codereview.chromium.org/2067007
------------------------------------------------------------------------
r47292 | yurys@chromium.org | 2010-05-14 21:04:47 +0200 (Fri, 14 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Temporarily disable DevToolsSanityTest.TestResourceContentLength

Temporarily disable DevToolsSanityTest.TestResourceContentLength which started to fail on Linux after WebKit roll.

BUG=44202

Review URL: http://codereview.chromium.org/2084004
------------------------------------------------------------------------
r47286 | mirandac@chromium.org | 2010-05-14 20:06:59 +0200 (Fri, 14 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   A /trunk/src/chrome/browser/importer/profile_writer.cc
   A /trunk/src/chrome/browser/importer/profile_writer.h
   M /trunk/src/chrome/chrome_browser.gypi

Move the profile_writer out of importer in preparation for OOP import on Mac.

BUG=18774
TEST=import works exactly the same as before.
Review URL: http://codereview.chromium.org/2136002
------------------------------------------------------------------------
r47285 | estade@chromium.org | 2010-05-14 20:06:18 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

GTK: expand status bar when user hovers over a link for long enough.

BUG=43192
TEST=none

Review URL: http://codereview.chromium.org/2033010
------------------------------------------------------------------------
r47283 | arv@chromium.org | 2010-05-14 19:46:51 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Make sure we don't "hang" when the bookmarks extension API does not work. Also, make sure we don't "hang" when the chrome url override failed.

BUG=43448
TEST=Manually

Review URL: http://codereview.chromium.org/2108001
------------------------------------------------------------------------
r47280 | suzhe@chromium.org | 2010-05-14 19:07:00 +0200 (Fri, 14 May 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

TBR:yusukes@chromium.org
------------------------------------------------------------------------
r47277 | msneck@google.com | 2010-05-14 18:11:43 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_loader.sb

Allow Native Client applications to use Posix semaphores:
sem_init(), sem_destroy(), sem_wait(), etc.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=471
TEST=nacl_ui_tests still pass

Review URL: http://codereview.chromium.org/2091002
------------------------------------------------------------------------
r47274 | dhg@chromium.org | 2010-05-14 17:40:42 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Chaning filebrowse so when the user downloads a dangerous URL, it doesn't show the updates about the download until the user presses allow. (much like the standard UI)

BUG=chromium-os:2773
TEST=none

Review URL: http://codereview.chromium.org/2130001
------------------------------------------------------------------------
r47272 | sky@chromium.org | 2010-05-14 16:50:39 +0200 (Fri, 14 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Fixes regression in keyword editor. If the selection became empty
clicking the edit button would crash.

BUG=none
TEST=clear the selection in the keyword editor (on windows), make sure
the edit button is disabled.

Review URL: http://codereview.chromium.org/2078006
------------------------------------------------------------------------
r47269 | mnissler@chromium.org | 2010-05-14 15:17:40 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   A /trunk/src/chrome/browser/config_dir_policy_provider.cc
   A /trunk/src/chrome/browser/config_dir_policy_provider.h
   A /trunk/src/chrome/browser/config_dir_policy_provider_unittest.cc
   A /trunk/src/chrome/browser/configuration_policy_provider.cc
   M /trunk/src/chrome/browser/configuration_policy_provider.h
   A /trunk/src/chrome/browser/mock_configuration_policy_store.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Preference provider implementation backed by JSON files in a directory.

BUG=42412
TEST=Unit tests in chrome/browser/value_tree_policy_decoder.cc and base/values_unittest.cc

Review URL: http://codereview.chromium.org/2027010
------------------------------------------------------------------------
r47268 | jorlow@chromium.org | 2010-05-14 14:59:11 +0200 (Fri, 14 May 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.cc
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_callbacks.h
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.cc
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_context.h
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
   A /trunk/src/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/indexed_db_dispatcher.cc
   A /trunk/src/chrome/renderer/indexed_db_dispatcher.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   A /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.cc
   A /trunk/src/chrome/renderer/renderer_webidbdatabase_impl.h
   A /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.cc
   A /trunk/src/chrome/renderer/renderer_webindexeddatabase_impl.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Implement IndexedDatabase::open up until re-entrance into WebKit.  That (and the
rest of IndexedDB) will be done in subsequent patches.  Included in this patch
is a lot of other infrastructure for making IndexedDB work.  Included is a
conversion from the DOMStorageDispatcherHost into a dispatcher host for all APIs
that have a backend in WebKit.

I named it WebKitAPIDispatcherHost.  Since it's in browser/in_process_webkit and
it is for APIs that connect up to the WebKit API and it's used for APIs whose
backend is implemented in WebKit I thought the name was decent and not _too_
confusing, but if you have better ideas, please let me know.

This includes some code that you've already reviewed (darin), but a lot has
changed so please take a look at all of it.

TEST=Not much to test yet + behind a flag.
BUG=none

Review URL: http://codereview.chromium.org/1599009
------------------------------------------------------------------------
r47256 | dpolukhin@chromium.org | 2010-05-14 11:41:31 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Remove error message on login screen as soon as user starts typing.

BUG=crosbug.com/1853
TEST=Try to login with wrong password, see error message in bubble, start typing new password, bubble should close on typing.

Review URL: http://codereview.chromium.org/2074004
------------------------------------------------------------------------
r47255 | oshima@chromium.org | 2010-05-14 11:13:14 +0200 (Fri, 14 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc

fix build breakage

BUG=none
TEST=none
TBR=tyoshino@chromium.org

Review URL: http://codereview.chromium.org/2080003
------------------------------------------------------------------------
r47253 | oshima@chromium.org | 2010-05-14 10:53:40 +0200 (Fri, 14 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   D /trunk/src/chrome/browser/chromeos/cros/mock_screen_lock_library.h
   D /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc
   D /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   D /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   D /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   D /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert "Hook up ScreenLocker to screen lock cros library."

This reverts commit ffa6827263fb5e6b4017a5f1655b683c806498fd.

TBR=dpolukhin@chromium.org

Review URL: http://codereview.chromium.org/2126002
------------------------------------------------------------------------
r47252 | timurrrr@chromium.org | 2010-05-14 10:24:42 +0200 (Fri, 14 May 2010) | 3 lines
Changed paths:
   M /trunk/src/base/allocator/allocator.gyp
   M /trunk/src/base/atomic_ref_count.h
   M /trunk/src/base/base.gypi
   D /trunk/src/base/dynamic_annotations.cc
   D /trunk/src/base/dynamic_annotations.h
   M /trunk/src/base/lazy_instance.cc
   M /trunk/src/base/lazy_instance.h
   M /trunk/src/base/singleton.h
   A /trunk/src/base/third_party/dynamic_annotations
   A /trunk/src/base/third_party/dynamic_annotations/LICENSE
   A /trunk/src/base/third_party/dynamic_annotations/README.chromium
   A /trunk/src/base/third_party/dynamic_annotations/dynamic_annotations.c
   A /trunk/src/base/third_party/dynamic_annotations/dynamic_annotations.h
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread_unittest.cc
   M /trunk/src/base/tools_sanity_unittest.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.cc
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/net/socket/tcp_pinger.h

Update dynamic annotations and move them to base/third_party

Review URL: http://codereview.chromium.org/1992005
------------------------------------------------------------------------
r47251 | oshima@chromium.org | 2010-05-14 09:45:23 +0200 (Fri, 14 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Valgrind cond error fix.  Initialize uninitialized member variable.

BUG=44147
TEST=valgrind bot should stay gree.
TBR=tyoshino@chromium.org,rvargas@chromium.org

Review URL: http://codereview.chromium.org/2071006
------------------------------------------------------------------------
r47249 | jochen@chromium.org | 2010-05-14 09:25:03 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h

Only attempt once to autogenerate a keyword for search engines.

BUG=none
TEST=Add a search engine provider for which no keyword can be generated

Review URL: http://codereview.chromium.org/2008017
------------------------------------------------------------------------
r47246 | dpolukhin@chromium.org | 2010-05-14 08:40:47 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h

Clear password filed on failed login.

BUG=crosbug.com/1853
TEST=Type wrong password and press Enter.

Review URL: http://codereview.chromium.org/2086001
------------------------------------------------------------------------
r47244 | zelidrag@chromium.org | 2010-05-14 07:45:26 +0200 (Fri, 14 May 2010) | 14 lines
Changed paths:
   M /trunk/src/app/x11_util.cc
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/base/mac_util_unittest.mm
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   A /trunk/src/chrome/browser/userfeedback
   A /trunk/src/chrome/browser/userfeedback/proto
   A /trunk/src/chrome/browser/userfeedback/proto/annotations.proto
   A /trunk/src/chrome/browser/userfeedback/proto/common.proto
   A /trunk/src/chrome/browser/userfeedback/proto/config.proto
   A /trunk/src/chrome/browser/userfeedback/proto/dom.proto
   A /trunk/src/chrome/browser/userfeedback/proto/extension.proto
   A /trunk/src/chrome/browser/userfeedback/proto/math.proto
   A /trunk/src/chrome/browser/userfeedback/proto/web.proto
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Commiting http://codereview.chromium.org/2017007/show on behalf of rkc@chromium.org.
This change hooks issue report dialog with Google Feedback backend for ChromeOS.

The dialog is going to be used only for Chrome OS at the moment, the previous mechanism is kept intact for other operating systems.

Image and System Info reporting is disabled at the moment; for image, we need
feedback to get their changes in production, for reporting, the system scripts
need to be added (basic Chrome and OS version info is being sent with the report)

BUG=chromium-os:2761
TEST=none, work in progress
TBR=zelidrag

Review URL: http://codereview.chromium.org/2068004
------------------------------------------------------------------------
r47239 | darin@chromium.org | 2010-05-14 05:40:26 +0200 (Fri, 14 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/renderer/pepper_plugin_registry.cc
   A /trunk/src/chrome/renderer/pepper_plugin_registry.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/webkit/glue/plugins/pepper_webplugin_impl.cc
   M /trunk/src/webkit/glue/plugins/pepper_webplugin_impl.h

Add support for registering new-style pepper plugins on the command line.

Command line looks like this:
  chrome.exe --register-pepper-plugins="c:\foo\bar.dll;application/x-bar"

This causes the registered plugins to be loaded on startup before the sandbox
is engaged.  As a result, registered plugins can function within the sandbox.

R=brettw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2104002
------------------------------------------------------------------------
r47236 | satorux@chromium.org | 2010-05-14 04:49:31 +0200 (Fri, 14 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Make the font size in the candidate window bigger.

This is to make Chinese characters more readable.

BUG=chromium-os:2904
TEST=manually

Review URL: http://codereview.chromium.org/2070002
------------------------------------------------------------------------
r47235 | eroman@chromium.org | 2010-05-14 04:39:14 +0200 (Fri, 14 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js

Refactor: Remove the PassiveLogCollector::RequestInfo::url field.
This field is unnecessary since it can be inferred from the list of log entries.

Review URL: http://codereview.chromium.org/2129001
------------------------------------------------------------------------
r47228 | maruel@chromium.org | 2010-05-14 02:38:12 +0200 (Fri, 14 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_util.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_util.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   A /trunk/src/chrome/browser/printing/print_dialog_cloud.cc
   A /trunk/src/chrome/browser/printing/print_dialog_cloud.h
   A /trunk/src/chrome/browser/printing/print_dialog_cloud_internal.h
   A /trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc
   A /trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/select_file_dialog.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   A /trunk/src/chrome/test/data/printing/cloud_print_emptytest.pdf
   A /trunk/src/chrome/test/data/printing/cloud_print_uitest.html

[Large; Chromium OS] Work to host the cloud print dialog when built
for Chromium OS.  Currently disabled by default behind a command line
switch, and containing a non-real URL for now, this code is at
prototype level.  It works (when enabled and pointed at a functioning
cloud print service URL), has the beginnings of some unit tests, and
has the beginnings of deeper communication with the dialog contents,
and it shuts off the DOM UI access from the dialog contents.

Patch contributed by Scott Byer

Review URL: http://codereview.chromium.org/1769006
------------------------------------------------------------------------
r47227 | jianli@chromium.org | 2010-05-14 02:21:47 +0200 (Fri, 14 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Fix the problem that FileReader does not work on Mac/Linux. The fix
is to pass the file handle with magic FileDescriptor over IPC for POSIX.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2123001
------------------------------------------------------------------------
r47226 | mirandac@chromium.org | 2010-05-14 02:21:41 +0200 (Fri, 14 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_types.h

Add a constructor to initialize a URLRow with a URLID.  This is needed when passing a URLRow across IPC for out of process import.

BUG=18774
TEST=NONE
Review URL: http://codereview.chromium.org/2127002
------------------------------------------------------------------------
r47222 | dhg@chromium.org | 2010-05-14 01:43:45 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/platform_util_chromeos.cc

Changing platform util for chromeos to open a gmail when the user clicks mailto

BUG=chromium-os:59
TEST=none

Review URL: http://codereview.chromium.org/2085004
------------------------------------------------------------------------
r47216 | oshima@chromium.org | 2010-05-14 00:53:29 +0200 (Fri, 14 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_screen_lock_library.h
   A /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/screen_lock_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   A /trunk/src/chrome/browser/chromeos/login/screen_locker_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.cc
   A /trunk/src/chrome/browser/chromeos/login/screen_locker_tester.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Hook up ScreenLocker to screen lock cros library.
 * Added ScreenLockerLibrary and its mock class.
 * Call NotifyScreenLockCompleted when screen locker is shown
 * Call NotifyScreenUnlocked when authentication is sucessful.
 * Replace includes in cros_in_process_browser_test.cc with forward declarations.
  * Added ScreenLockerTester for testing
  * Added new browser test ScreenLockerTest.TestBasic

BUG=2914
TEST=added ScreenLockerTest.TestBasic browser test.

Review URL: http://codereview.chromium.org/2025009
------------------------------------------------------------------------
r47215 | xiyuan@chromium.org | 2010-05-14 00:44:14 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Ensure that we use a normal browser window as parent for HTML dialogs on ChromeOS.

BUG=chromium-os:2671
TEST=Verify fix for chromius-os:2671.

Review URL: http://codereview.chromium.org/2085003
------------------------------------------------------------------------
r47207 | eroman@chromium.org | 2010-05-14 00:28:10 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings_unittest.cc
   A /trunk/src/chrome/test/data/firefox3_pref_pac_url.js

Fix retrieval of Firefox proxy settings when it is using an autoconfig URL.

BUG=44119,44005
TEST=FirefoxProxySettingsTest.TestParseAutoConfigUrl

Review URL: http://codereview.chromium.org/2089004
------------------------------------------------------------------------
r47206 | brettw@chromium.org | 2010-05-14 00:17:17 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc

Add TopSites::GetMostVisitedURLs and unittest for it using MockHistoryService.

BUG=none
TEST=TopSitesTest
Original review=http://codereview.chromium.org/2057008
Patch by Nik Shkrob
------------------------------------------------------------------------
r47204 | avi@chromium.org | 2010-05-14 00:13:04 +0200 (Fri, 14 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/webkit/glue/webmenurunner_mac.h
   M /trunk/src/webkit/glue/webmenurunner_mac.mm
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm

Do right-alignment of popups when WebKit indicates to do so.

BUG=http://crbug.com/23106
TEST=as in bug

Review URL: http://codereview.chromium.org/1992006
------------------------------------------------------------------------
r47202 | sky@chromium.org | 2010-05-14 00:11:03 +0200 (Fri, 14 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   A /trunk/src/chrome/browser/views/tabs/base_tab_renderer.cc
   A /trunk/src/chrome/browser/views/tabs/base_tab_renderer.h
   A /trunk/src/chrome/browser/views/tabs/base_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   D /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   A /trunk/src/chrome/browser/views/tabs/tab_renderer_data.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   A /trunk/src/chrome/browser/views/tabs/tab_strip_controller.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Refactors TabStrip code for better sharing between TabStrip and
SideTabStrip. I still have a bunch of cleanup to do, but this is a
good checkpoint.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2037012
------------------------------------------------------------------------
r47201 | pvalchev@google.com | 2010-05-14 00:06:01 +0200 (Fri, 14 May 2010) | 4 lines
Changed paths:
   M /trunk/src/app/app_paths.cc
   M /trunk/src/app/clipboard/clipboard_linux.cc
   M /trunk/src/app/gtk_util.cc
   M /trunk/src/app/gtk_util.h
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/browser/icon_loader_linux.cc

Move non-linux specific code from base/linux_util to app/gtk_util
from sprewell

Review URL: http://codereview.chromium.org/2058004
------------------------------------------------------------------------
r47198 | arv@chromium.org | 2010-05-13 23:56:54 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/ui/menu_button.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/position_util.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/position_util_test.html
   M /trunk/src/chrome/chrome_browser.gypi

Add smarter popup position code to DOM UI Shared Resources.

BUG=None
TEST=js unit tests as well as manually ensuring the menu button in the bookmarks manager flips side when the window gets small.

Review URL: http://codereview.chromium.org/2042017
------------------------------------------------------------------------
r47196 | akalin@chromium.org | 2010-05-13 23:37:14 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h

Folded TestingProfileSyncService class into TestProfileSyncService.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2064002
------------------------------------------------------------------------
r47195 | erg@chromium.org | 2010-05-13 23:36:59 +0200 (Thu, 13 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   A /trunk/src/chrome/browser/gtk/gconf_titlebar_listener.cc
   A /trunk/src/chrome/browser/gtk/gconf_titlebar_listener.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: Support Ambiance/Radiance and Dust button ordering.

When running under GNOME, read the gconf key that defines the button placement
and lay the close, minimize and maximize buttons out. This can even handle
bizarre combinations like putting the close button on the left and the
minimize/maximize buttons on the right.

When running under anything else, use the default button ordering.

BUG=39406
TEST=none

Review URL: http://codereview.chromium.org/2095001
------------------------------------------------------------------------
r47187 | estade@chromium.org | 2010-05-13 22:43:43 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc

Only use IDC_ values for command ids in the render view context menu.

BUG=43816
TEST=none

Review URL: http://codereview.chromium.org/1981014
------------------------------------------------------------------------
r47183 | eroman@chromium.org | 2010-05-13 22:20:26 +0200 (Thu, 13 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/net/base/net_log.h

Minor refactor: rename "extra_parameters" --> "params".

(The "extra" was redundant. And "params" is a well understood abbreviation of "parameters").

Review URL: http://codereview.chromium.org/2110001
------------------------------------------------------------------------
r47177 | finnur@chromium.org | 2010-05-13 21:31:14 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

The BookmarkBarView should not be visible for extension apps.

BUG=http://crbug.com/44076
TEST=Open an extensio app and make sure that the bookmark bar never becomes visible.

Review URL: http://codereview.chromium.org/2090002
------------------------------------------------------------------------
r47175 | oshima@chromium.org | 2010-05-13 21:22:39 +0200 (Thu, 13 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc

Fix uninitialized mock_cryptohome_library_
Use InitMockCryptohomeLibrary in LoginManagerViewTest

BUG=none
TEST=LoginManagerView test should pass.

Review URL: http://codereview.chromium.org/2027011
------------------------------------------------------------------------
r47170 | pkasting@chromium.org | 2010-05-13 20:59:32 +0200 (Thu, 13 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

L"" -> std::wstring(), try to avoid line breaks in the middle of statements, and other misc. cleanup.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2100001
------------------------------------------------------------------------
r47168 | pkasting@chromium.org | 2010-05-13 20:55:39 +0200 (Thu, 13 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h

Remove more dead code/strings relating to mixed/unsafe content.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2098001
------------------------------------------------------------------------
r47166 | dpolukhin@chromium.org | 2010-05-13 20:26:41 +0200 (Thu, 13 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc

Make missing/wrong croslib nonfatal error.

Mitsuru landed CL http://codereview.chromium.org/2032006 that always creates
GoogleAuthenticator if --login_manager switch is enabled. GoogleAuthenticator
constructor has check for croslib that fails if croslib version doesn't match
or you are debugging login manager on Linux. So it broke previous behavior that
missing croslib was not a fatal error and user was able to see error message on
login screen (now user can't - only black screen after several Chrome restarts).

BUG=none
TEST=Run Chrome built for Chrome OS on Linux with --login_manager command line switch, it shouldn't crash with CHECK fail about croslib.

Review URL: http://codereview.chromium.org/2082001
------------------------------------------------------------------------
r47162 | mattm@chromium.org | 2010-05-13 19:59:22 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.h
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc

Fix gtk_tree::GetSelectedIndicies spelling.

BUG=none
TEST=dict indicies indices

Review URL: http://codereview.chromium.org/2065001
------------------------------------------------------------------------
r47161 | arv@chromium.org | 2010-05-13 19:58:52 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Make the apps icons wider.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2072002
------------------------------------------------------------------------
r47159 | nirnimesh@chromium.org | 2010-05-13 19:33:05 +0200 (Thu, 13 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/browser.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Add hooks for fetching basic info from the browser.

This includes info like version string, executable name, path, and so on.

Review URL: http://codereview.chromium.org/2009013
------------------------------------------------------------------------
r47156 | nick@chromium.org | 2010-05-13 19:18:15 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Defensive checks for backend_ existence.
BUG=3231
(chromium-os)
http://code.google.com/p/chromium-os/issues/detail?id=3231

Review URL: http://codereview.chromium.org/2058006
------------------------------------------------------------------------
r47155 | sanjeevr@chromium.org | 2010-05-13 19:18:01 +0200 (Thu, 13 May 2010) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/printing/cloud_print/cloud_print_consts.cc
   D /trunk/src/chrome/browser/printing/cloud_print/cloud_print_consts.h
   D /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.cc
   D /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.h
   D /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_backend.cc
   D /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_backend.h
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
   D /trunk/src/chrome/browser/printing/cloud_print/job_status_updater.cc
   D /trunk/src/chrome/browser/printing/cloud_print/job_status_updater.h
   D /trunk/src/chrome/browser/printing/cloud_print/printer_info.h
   D /trunk/src/chrome/browser/printing/cloud_print/printer_info_linux.cc
   D /trunk/src/chrome/browser/printing/cloud_print/printer_info_mac.cc
   D /trunk/src/chrome/browser/printing/cloud_print/printer_info_win.cc
   D /trunk/src/chrome/browser/printing/cloud_print/printer_job_handler.cc
   D /trunk/src/chrome/browser/printing/cloud_print/printer_job_handler.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   A /trunk/src/chrome/service/cloud_print/cloud_print_consts.cc (from /trunk/src/chrome/browser/printing/cloud_print/cloud_print_consts.cc:47057)
   A /trunk/src/chrome/service/cloud_print/cloud_print_consts.h (from /trunk/src/chrome/browser/printing/cloud_print/cloud_print_consts.h:47057)
   A /trunk/src/chrome/service/cloud_print/cloud_print_helpers.cc (from /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.cc:47057)
   A /trunk/src/chrome/service/cloud_print/cloud_print_helpers.h (from /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.h:47057)
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy.cc
   M /trunk/src/chrome/service/cloud_print/cloud_print_proxy.h
   A /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc (from /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_backend.cc:47057)
   A /trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.h (from /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_backend.h:47057)
   A /trunk/src/chrome/service/cloud_print/job_status_updater.cc (from /trunk/src/chrome/browser/printing/cloud_print/job_status_updater.cc:47057)
   A /trunk/src/chrome/service/cloud_print/job_status_updater.h (from /trunk/src/chrome/browser/printing/cloud_print/job_status_updater.h:47057)
   A /trunk/src/chrome/service/cloud_print/printer_info.h (from /trunk/src/chrome/browser/printing/cloud_print/printer_info.h:47057)
   A /trunk/src/chrome/service/cloud_print/printer_info_linux.cc (from /trunk/src/chrome/browser/printing/cloud_print/printer_info_linux.cc:47057)
   A /trunk/src/chrome/service/cloud_print/printer_info_mac.cc (from /trunk/src/chrome/browser/printing/cloud_print/printer_info_mac.cc:47057)
   A /trunk/src/chrome/service/cloud_print/printer_info_win.cc (from /trunk/src/chrome/browser/printing/cloud_print/printer_info_win.cc:47057)
   A /trunk/src/chrome/service/cloud_print/printer_job_handler.cc (from /trunk/src/chrome/browser/printing/cloud_print/printer_job_handler.cc:47057)
   A /trunk/src/chrome/service/cloud_print/printer_job_handler.h (from /trunk/src/chrome/browser/printing/cloud_print/printer_job_handler.h:47057)

Moved cloud print code from the chrome/browser/printing/cloud_print to chrome/service/cloud_print
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/2007012
------------------------------------------------------------------------
r47154 | xiyuan@chromium.org | 2010-05-13 19:04:10 +0200 (Thu, 13 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.cc

Fix native dialog size regression

A few sub options dialog has wrong size because OnCheckResize always applys
Gtk's default size regardless of what we set. Fix the problem by only do
auto resize when we are asked to (i.e. requested size_'s height is 0).

Also make sure that auto resize repects the given minimum size.

BUG=none
TEST=Verify sub options dialogs such as autofill, search engine manager etc has the right size.

Review URL: http://codereview.chromium.org/2053006
------------------------------------------------------------------------
r47141 | nkostylev@google.com | 2010-05-13 16:10:49 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc

Fix crash on login for debug version of Chrome.

BUG= http://crosbug.com/3247
TEST=Use debug version of Chrome on the device. It should not crash on login.

Review URL: http://codereview.chromium.org/2087001
------------------------------------------------------------------------
r47137 | nkostylev@google.com | 2010-05-13 12:43:47 +0200 (Thu, 13 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc

Don't prefill username on "Other user" screen.

Old login screen now is only used as "Other user" screen.
Rare case is when you specifically pass --login-screen=[login|oobe|network] and it's not prefilled with the last user. But that's dev test case.

BUG= http://crosbug.com/2853
TEST=Select "Other user" screen from the login screen with avatars. Username field should be empty.

Review URL: http://codereview.chromium.org/2077001
------------------------------------------------------------------------
r47136 | dpolukhin@chromium.org | 2010-05-13 12:07:43 +0200 (Thu, 13 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   A /trunk/src/chrome/browser/chromeos/login/message_bubble.cc
   A /trunk/src/chrome/browser/chromeos/login/message_bubble.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

Show login error in bubble.

Because window manager on login screen ignores window position the bubble is shown on the center of screen. It can be closed by ESC or clicking on x-button.

BUG=crosbug.com/2800
TEST=On Chrome OS type wrong password and see the bubble.

Review URL: http://codereview.chromium.org/1990003
------------------------------------------------------------------------
r47132 | nkostylev@google.com | 2010-05-13 12:00:06 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h

Refresh network combobox on locale change.

BUG= http://crosbug.com/3162
TEST=Change UI language on welcome screen. Combobox should show "No selection" message when network hasn't been selected previously.

Review URL: http://codereview.chromium.org/2011014
------------------------------------------------------------------------
r47128 | tyoshino@chromium.org | 2010-05-13 10:23:07 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Revert 47064 - Switch sync servers depending on whether you're running stable or dev. Initially just use the same url twice.

Review URL: http://codereview.chromium.org/2013017

TBR=chron@chromium.org
Review URL: http://codereview.chromium.org/2074001
------------------------------------------------------------------------
r47125 | nkostylev@google.com | 2010-05-13 08:42:38 +0200 (Thu, 13 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/select_file_dialog.cc

Fix crash when opening "Select certificate file" in OOBE.
Pass default profile and correct top window in OOBE.

BUG=http://crosbug.com/2978
TEST=On welcome screen select encrypted 802.1X network and open "select certificate" dialog. It should open withot crash.

Review URL: http://codereview.chromium.org/2053001
------------------------------------------------------------------------
r47124 | phajdan.jr@chromium.org | 2010-05-13 08:35:35 +0200 (Thu, 13 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Use just TimeTicks::Now in the chrome/browser/sync test code.

The situations when we need to use HighResNow are really rare,
and I believe this is not one of them.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2042013
------------------------------------------------------------------------
r47123 | phajdan.jr@chromium.org | 2010-05-13 08:13:02 +0200 (Thu, 13 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h

Flip ExpireHistoryTest.DeleteURLAndFavicon from FAILS back to FLAKY
per James Hawkins' request from http://codereview.chromium.org/2055014/show

The problem is that this test does not appear on the flakiness dashboard,
but hopefully the new flakiness bot will help with that.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2012012
------------------------------------------------------------------------
r47122 | suzhe@chromium.org | 2010-05-13 08:05:05 +0200 (Thu, 13 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Refine language preferences.

This CL removes the code related to following unconfigurable ibus configs:
general/use_global_engine
general/hotkey/trigger

Their default values will be correctly initialized in ibus.

Also renames following configs:
next_engine renames to next_engine_in_menu
prev_engine renames to previous_engine
------------------------------------------------------------------------
r47119 | finnur@chromium.org | 2010-05-13 06:22:22 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/test_location_bar.h

Make sure the Omnibox is hidden when toolbar is collapsed.

BUG=None
TEST=Visual inspection. The Omnibox should never become visible for tabs with a collapsed toolbar (app tabs). F11 twice should not show the Omnibox.

Review URL: http://codereview.chromium.org/2032015
------------------------------------------------------------------------
r47112 | akalin@chromium.org | 2010-05-13 04:17:52 +0200 (Thu, 13 May 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/net/network_change_notifier_io_thread.cc
   A /trunk/src/chrome/browser/sync/net/network_change_notifier_io_thread.h
   A /trunk/src/chrome/browser/sync/net/network_change_notifier_io_thread_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Added NetworkChangeNotifierIOThread, which will be used by the
sync/notifier threads to pass into NetworkChangeNotifierProxy.

Refactored unit tests a bit.

BUG=19784
TEST=unit tests

Review URL: http://codereview.chromium.org/1987013
------------------------------------------------------------------------
r47111 | dhollowa@chromium.org | 2010-05-13 04:16:53 +0200 (Thu, 13 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/name_field_unittest.cc

AutoFill heuristics extended to include multiple separator characters.

AutoFill heuristics were successfully matching labels such as "First Name" but not "First    Name".  Extra whitespace and other separator characters are now allowed.  There are examples of this in the sample3.html test file.

BUG=38257
TEST=Manual testing against sample3.html, sample6.html, and sample8.html.
     NameFieldTest.FirstLastMiddleWithSpaces

Review URL: http://codereview.chromium.org/1993013
------------------------------------------------------------------------
r47110 | akalin@chromium.org | 2010-05-13 04:15:37 +0200 (Thu, 13 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/SyncCustomize.xib
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller.h
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller.mm

[Mac] Automatically wrap the Customize Sync dialog to fit contents

xib changes: Adjusted customize sync text field to be as wide as the content view and made it wrap.  Created customizeSyncDescriptionTextField_ outlet and hooked it up.

BUG=43945
TEST=manual with French

Review URL: http://codereview.chromium.org/2001018
------------------------------------------------------------------------
r47109 | akalin@chromium.org | 2010-05-13 04:12:07 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/common/net/notifier/listener/listen_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/xml_element_util.cc
   M /trunk/src/chrome/common/net/notifier/listener/xml_element_util_unittest.cc
   M /trunk/src/third_party/libjingle/files/talk/xmllite/qname.cc
   M /trunk/src/third_party/libjingle/files/talk/xmllite/qname.h
   M /trunk/src/third_party/libjingle/files/talk/xmllite/xmlelement.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/saslcookiemechanism.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.cc

Removed non-thread-safe QName ad-hoc interning.

BUG=43467
TEST=made sure sync_integration_tests don't have any more ~QName crashes

Review URL: http://codereview.chromium.org/2012014
------------------------------------------------------------------------
r47108 | mattm@chromium.org | 2010-05-13 04:06:55 +0200 (Thu, 13 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/custom_home_pages_table_model.cc
   M /trunk/src/chrome/browser/custom_home_pages_table_model.h
   D /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   D /trunk/src/chrome/browser/gtk/list_store_favicon_loader.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Gtk: update options "Open on startup" to match new behavior.

Also, change "use current" to allow new tab page.

BUG=43802
TEST=manual

Review URL: http://codereview.chromium.org/2012016
------------------------------------------------------------------------
r47107 | yusukes@google.com | 2010-05-13 04:05:07 +0200 (Thu, 13 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Switch to preferred XKB layout when current input method is changed.

libcros part: http://codereview.chromium.org/2051009

BUG=chromium-os:3226
TEST=manual

Review URL: http://codereview.chromium.org/2003014
------------------------------------------------------------------------
r47104 | aa@chromium.org | 2010-05-13 03:18:07 +0200 (Thu, 13 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc

Re-land r47079: Shorten several appsrelated flags.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r47103 | zelidrag@chromium.org | 2010-05-13 03:14:24 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Fix for popup menu assert.

BUG=chromium-os:3237
TEST=get debug build, open content browser, right click on a file 

Review URL: http://codereview.chromium.org/2025011
------------------------------------------------------------------------
r47100 | davemoore@chromium.org | 2010-05-13 02:13:58 +0200 (Thu, 13 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.cc

Native dialogs need to send GTK_RESPONSE_DELETE_EVENT on close
BUG=chromium-os:3211
TEST=Use html in bug, click "test" and then click close button.
     App shouldn't freeze.

We will write new tests to cover this. The current ones bypass
the native dialog code and send the events directly. That's
why they didn't catch the regression.

Review URL: http://codereview.chromium.org/2053007
------------------------------------------------------------------------
r47097 | davemoore@chromium.org | 2010-05-13 01:53:47 +0200 (Thu, 13 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc

Make boottime delay not block file thread
BUG=None
TEST=Boot on ARM...boottimes shouldn't display but chrome should
     still work. We will be stating a file every half second though
     until /tmp/uptime-login-prompt-ready is emited.

Review URL: http://codereview.chromium.org/2007010
------------------------------------------------------------------------
r47089 | xiyuan@chromium.org | 2010-05-13 01:15:57 +0200 (Thu, 13 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc

Fix the flaky crash in FileBrowseBrowserTest.InputFileTriggerFileBrowse

CheckFileBrowseClosed could crash if the delayed execution happens after
FileBrowse popup is destroied. Change the wait to use notification.

BUG=none
TEST=FileBrowseBrowserTest.InputFileTriggerFileBrowse should not crash.

Review URL: http://codereview.chromium.org/2006013
------------------------------------------------------------------------
r47084 | mpcomplete@chromium.org | 2010-05-13 00:51:03 +0200 (Thu, 13 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Mark BrowserAppRefocusTest.OpenTab as flaky since it has been hanging off and
on the past 2 days.

BUG=44026
TBR=huanr

Review URL: http://codereview.chromium.org/2012015
------------------------------------------------------------------------
r47083 | willchan@chromium.org | 2010-05-13 00:47:14 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/net/base/host_mapping_rules.cc (from /trunk/src/net/base/mapped_host_resolver.cc:47081)
   A /trunk/src/net/base/host_mapping_rules.h
   A /trunk/src/net/base/host_mapping_rules_unittest.cc
   M /trunk/src/net/base/mapped_host_resolver.cc
   M /trunk/src/net/base/mapped_host_resolver.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/net.gyp

Add --host-rules support.

The format for --host-rules is identical to --host-resolver-rules.
The difference is that --host-rules affects the endpoint of the HttpNetworkTransaction, not just the host resolver.  So, this means the host passed to the host resolver and the TCP connect(), the tunnel CONNECT, and the SOCKS connect will be different.

Review URL: http://codereview.chromium.org/2057007
------------------------------------------------------------------------
r47082 | mattm@chromium.org | 2010-05-13 00:44:46 +0200 (Thu, 13 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc

ProcessSingletonLinux.NotifyOtherProcessNoSuicide removes socket instead of sending SIGSTOP.

Should be a more reliable way of preventing the existing browser from being notified, fixing valgrind flake.

BUG=43976
TEST=tools/valgrind/chrome_tests.sh -t ui --gtest_filter=ProcessSingletonLinuxTest.NotifyOtherProcessNoSuicide

Review URL: http://codereview.chromium.org/2013020
------------------------------------------------------------------------
r47081 | aa@chromium.org | 2010-05-13 00:18:28 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc

Revert 47079 - Shorten several appsrelated flags. "256 characters should be enough for anyone's shortcut flags!"

Review URL: http://codereview.chromium.org/1991009

TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/2010013
------------------------------------------------------------------------
r47079 | aa@chromium.org | 2010-05-13 00:08:40 +0200 (Thu, 13 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc

Shorten several apps-related flags. "256 characters should be enough for anyone's shortcut flags!"

Review URL: http://codereview.chromium.org/1991009
------------------------------------------------------------------------
r47078 | zelidrag@chromium.org | 2010-05-13 00:07:24 +0200 (Thu, 13 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Fixed crash on closing of content window. The original code tried to re-Show() the same browser window for the current content browser panel.

BUG=chromium-os:2650,chromium-os:3069
TEST=Press ctrl-O to open content browser. Select file, click on it, close content browser windows (that's where we used to crash before).

Review URL: http://codereview.chromium.org/2052010
------------------------------------------------------------------------
r47076 | willchan@chromium.org | 2010-05-12 23:54:59 +0200 (Wed, 12 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_network_layer.cc

Enable Alternate-Protocol support by default when NPN support is enabled.

Review URL: http://codereview.chromium.org/2015019
------------------------------------------------------------------------
r47075 | estade@chromium.org | 2010-05-12 23:44:36 +0200 (Wed, 12 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: custom frame/drop shadow updates.

- round top corners of toolbar (in chrome theme mode only)
- round bottom corners of window (custom frame)

FWIW, our shadow was actually broken by r44177; you can notice this by using xmag on the top right corner of the toolbar on current dev builds.

BUG=43632
TEST=manual

Review URL: http://codereview.chromium.org/1985016
------------------------------------------------------------------------
r47073 | michaeln@chromium.org | 2010-05-12 23:23:06 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Store a reference to the profile's DatabaseTracker in the request context too.

BUG=39368
TEST=existing tests apply

Review URL: http://codereview.chromium.org/2048010
------------------------------------------------------------------------
r47069 | thomasvl@chromium.org | 2010-05-12 23:02:59 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm

[Mac] If the clear all button is wider then the content view, size up the bubble to fit.
Also fix the button leak that was in here.

BUG=43950
TEST=see bug
Review URL: http://codereview.chromium.org/1996017
------------------------------------------------------------------------
r47064 | chron@chromium.org | 2010-05-12 22:33:11 +0200 (Wed, 12 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Switch sync servers depending on whether you're running stable or dev. Initially just use the same url twice.

Review URL: http://codereview.chromium.org/2013017
------------------------------------------------------------------------
r47061 | eroman@chromium.org | 2010-05-12 22:23:34 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/browser/resources/net_internals/testview.js

Allow hitting enter in the connection tests "URL" box to start the tests.

BUG=44005

Review URL: http://codereview.chromium.org/1995015
------------------------------------------------------------------------
r47060 | asargent@chromium.org | 2010-05-12 22:20:15 +0200 (Wed, 12 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_api.h
   A /trunk/src/chrome/browser/extensions/extension_context_menu_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/context_menus/test.js

Add update and removeAll functions to extensions context menu API

BUG=39505
TEST=Should be able to add a bunch of context menu items and then change or
remove them using update and removeAll respectively.

Review URL: http://codereview.chromium.org/1736028
------------------------------------------------------------------------
r47056 | avi@chromium.org | 2010-05-12 21:26:40 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/printer_query.cc
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/gfx/native_widget_types.h
   M /trunk/src/printing/printing_context.h
   M /trunk/src/printing/printing_context_cairo.cc
   M /trunk/src/printing/printing_context_mac.mm
   M /trunk/src/printing/printing_context_win.cc

Set the job name for the print job on the Mac.

BUG=http://crbug.com/29188
TEST=as in bug

Review URL: http://codereview.chromium.org/1997016
------------------------------------------------------------------------
r47053 | jcivelli@chromium.org | 2010-05-12 20:57:45 +0200 (Wed, 12 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   A /trunk/src/chrome/browser/views/info_bubble_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

This CL makes the InfoBubble not change the arrow when parts of it
is offscreen if it makes it even more offscreen.

BUG=None
TEST=Open the app launcher on ChromeOS. It should display correctly.

Review URL: http://codereview.chromium.org/2025008
------------------------------------------------------------------------
r47052 | ericdingle@google.com | 2010-05-12 20:51:26 +0200 (Wed, 12 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_a.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_b.html

Disallow display of multiple experimental.extension.popup(...) windows 

This is a duplicate of http://codereview.chromium.org/2027006 which was accidentally created in a read-only client.

BUG=None
TEST=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/2003016
------------------------------------------------------------------------
r47051 | ctguil@chromium.org | 2010-05-12 20:47:23 +0200 (Wed, 12 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/notification_type.h

Fix the TestRendererAccessibilityTree browser test so that it's not flaky.

Add a new notification for when the render view host's accessibility tree is updated and verify the tree in the test after that notification is received.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1986009
------------------------------------------------------------------------
r47050 | rvargas@google.com | 2010-05-12 20:40:10 +0200 (Wed, 12 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/connection_tester.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Http Cache: Add a backend factory class so that the caller
has more control about the backend instantiation.

BUG=none
TEST=current unit tests.


Review URL: http://codereview.chromium.org/2000011
------------------------------------------------------------------------
r47049 | eroman@chromium.org | 2010-05-12 20:29:50 +0200 (Wed, 12 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js

Cleanup: extract common code between two functions.

Review URL: http://codereview.chromium.org/1992014
------------------------------------------------------------------------
r47048 | rafaelw@chromium.org | 2010-05-12 20:24:19 +0200 (Wed, 12 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Hide NTP app launcher debug link behind a flag.

Review URL: http://codereview.chromium.org/2061004
------------------------------------------------------------------------
r47044 | kkania@chromium.org | 2010-05-12 20:02:24 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc

[Linux] Disable crashing extension UpdatePermission test.
BUG=32906
TEST=none

Review URL: http://codereview.chromium.org/2015018
------------------------------------------------------------------------
r47037 | jar@chromium.org | 2010-05-12 18:43:16 +0200 (Wed, 12 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/chromeos/external_protocol_dialog.h
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h

Second round of transition of Time to TimeTicks for histogramming

The first CL was getting too large, and was being held back by
some platform specific changes.  I pulled out the problems into
this CL to make it easier ot focus on getting them all right.

BUG=14193
r=eroman
Review URL: http://codereview.chromium.org/2033005
------------------------------------------------------------------------
r47036 | kkania@chromium.org | 2010-05-12 18:03:38 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc

[Linux] Enable extension AutoUpdate and UpdatePermissions tests after fixing a related crash.
BUG=31737,32906
TEST=none

Review URL: http://codereview.chromium.org/2018006
------------------------------------------------------------------------
r47035 | oshima@chromium.org | 2010-05-12 17:53:06 +0200 (Wed, 12 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h

Use username and password in MockAuthenticator instead of authenticate_result_ flag.

added #include for gtest.h as it uses has EXPECT_EQ.

BUG=none
TEST=login_manager_view_browsertest should pass.

Review URL: http://codereview.chromium.org/2002016
------------------------------------------------------------------------
r47034 | phajdan.jr@chromium.org | 2010-05-12 17:32:23 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h

[TTF] [GTTF] Flip tests that fail predictably from FLAKY to FAILS.

TBR=jhawkins

Review URL: http://codereview.chromium.org/2055014
------------------------------------------------------------------------
r47033 | finnur@chromium.org | 2010-05-12 17:31:55 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Allow the gallery url passed through the command line to be referrer for actual gallery downloads.

BUG=None
TEST=Pass in a gallery url through the command line and make sure the dangerous download warning does not show when downloading from that gallery.

Review URL: http://codereview.chromium.org/1997019
------------------------------------------------------------------------
r47032 | skerner@chromium.org | 2010-05-12 17:13:57 +0200 (Wed, 12 May 2010) | 10 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host.cc

Use realpath() to find the path to the extension unpack dir on posix systems.

Extensions are unpacked by a sandboxed utility process.  The sandbox forbids file access outside the directory the extension will be unpacked in.  If the path to that directory contains a symbolic link, then unpacking will fail because following the link will cause file system access outside the sandbox path.  Use realpath() to get a symlink free path to the directory where the extension will be unpacked.

A similar issue exists on windows, with junctions instead of symlinks.  This will be fixed in another change.

BUG=13044,35198
TEST=FileUtilTest.RealPath

Review URL: http://codereview.chromium.org/2001013
------------------------------------------------------------------------
r47030 | danno@chromium.org | 2010-05-12 17:03:32 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/configuration_policy_pref_store.cc
   A /trunk/src/chrome/browser/configuration_policy_pref_store.h
   A /trunk/src/chrome/browser/configuration_policy_pref_store_unittest.cc
   A /trunk/src/chrome/browser/configuration_policy_provider.h
   A /trunk/src/chrome/browser/configuration_policy_store.h
   M /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/json_pref_store.h
   M /trunk/src/chrome/browser/json_pref_store_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_store.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implementation of managed policy abstraction on top of a preference store. This is preparation work for implementing platform-specific policy.

BUG=none
TEST=--gtest_filter=ConfigurationPolicyPrefStoreTest*

Review URL: http://codereview.chromium.org/1692011
------------------------------------------------------------------------
r47027 | yusukes@chromium.org | 2010-05-12 16:25:58 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Fix build break caused by cros_deps/DEPS update (2nd try).

TBR=satorux

Review URL: http://codereview.chromium.org/2044009
------------------------------------------------------------------------
r47025 | yusukes@chromium.org | 2010-05-12 16:03:14 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc

Fix build break caused by cros_deps/DEPS update.

TBR=satorux

Review URL: http://codereview.chromium.org/2007011
------------------------------------------------------------------------
r47020 | satish@chromium.org | 2010-05-12 13:14:39 +0200 (Wed, 12 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Pass quota parameter to WebStorageNamespace::createSessionStorageNamespace().

Put a per-origin quota on session storage since it is using memory in the browser process, and should not be allowed to grow arbitrarily large.

Landing on behalf of hans@chromium.org from http://codereview.chromium.org/1998003/show

BUG=42740
TEST=none

Review URL: http://codereview.chromium.org/1995014
------------------------------------------------------------------------
r47006 | dumi@chromium.org | 2010-05-12 05:27:39 +0200 (Wed, 12 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/common/database_util.cc
   M /trunk/src/chrome/common/database_util.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/database/vfs_backend.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/support/test_webkit_client.cc
   M /trunk/src/webkit/support/test_webkit_client.h
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Remove the dirfd parameter from all Chromium code. The POSIX VFS
doesn't need it.

BUG=43489
TEST=none

Review URL: http://codereview.chromium.org/2055009
------------------------------------------------------------------------
r47001 | estade@chromium.org | 2010-05-12 04:22:40 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

fix mac compile

TBR=jam

Review URL: http://codereview.chromium.org/2003013
------------------------------------------------------------------------
r46999 | estade@chromium.org | 2010-05-12 04:05:16 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Avoid DCHECK in RenderViewContextMenu following r46987

BUG=none
TEST=none
TBR=sky
------------------------------------------------------------------------
r46997 | akalin@chromium.org | 2010-05-12 03:53:35 +0200 (Wed, 12 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h

Revert 46996 - Removed redundant TestingProfileSyncService class.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2008015

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/1979011
------------------------------------------------------------------------
r46996 | akalin@chromium.org | 2010-05-12 03:28:23 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h

Removed redundant TestingProfileSyncService class.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2008015
------------------------------------------------------------------------
r46993 | mattm@chromium.org | 2010-05-12 02:19:05 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/custom_home_pages_table_model.cc (from /trunk/src/chrome/browser/views/options/general_page_view.cc:46960)
   A /trunk/src/chrome/browser/custom_home_pages_table_model.h (from /trunk/src/chrome/browser/views/options/general_page_view.cc:46960)
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Split CustomHomePagesTableModel into its own file so it can be shared with the Gtk UI.

BUG=43802
TEST=manual

Review URL: http://codereview.chromium.org/2061003
------------------------------------------------------------------------
r46988 | pkasting@chromium.org | 2010-05-12 01:58:05 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc

Fix logic error in SSLPolicy::UpdateStateForMixedContent().

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2052007
------------------------------------------------------------------------
r46987 | estade@chromium.org | 2010-05-12 01:51:20 +0200 (Wed, 12 May 2010) | 15 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/menu_controller_unittest.mm
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   D /trunk/src/chrome/browser/gtk/standard_menus.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/page_menu_model.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.cc
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.h
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_gtk.cc
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_gtk.h
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.cc
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_views.h
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/examples/menu_example.h

Re-organize RenderViewContextMenu to the use cross-platform MenuModel class.

Benefits:
- less code
- more straightforward code
- more shared code

unresolved issues:
- RenderViewContextMenu{Gtk,Mac,Views} should not be a subclass of RenderViewContextMenu
- On Linux, IMEs are added in the wrong place (not near the other editable stuff)

BUG=31365
TEST=manual + trybots

Review URL: http://codereview.chromium.org/2017001
------------------------------------------------------------------------
r46986 | jhawkins@chromium.org | 2010-05-12 01:43:07 +0200 (Wed, 12 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

gtk: Don't set the GDK_WINDOW_TYPE_HINT_NORMAL hint on the AutoFill dialog
window.  This matches other options sub-dialogs.

BUG=41196
TEST=none

Review URL: http://codereview.chromium.org/2012010
------------------------------------------------------------------------
r46981 | oshima@chromium.org | 2010-05-12 01:26:57 +0200 (Wed, 12 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc

Made the grab widget transparent so that label's background is same as background.
Make window popup to avoid animation and keep it on top of the window stack.

BUG=http://crosbug.com/2914
TEST=none

Review URL: http://codereview.chromium.org/2032012
------------------------------------------------------------------------
r46980 | finnur@chromium.org | 2010-05-12 01:24:10 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

For extension apps, disable the bookmark bar from the launcher page.

BUG=None
TEST=With --enable-extension-apps, make sure you don't get the bookmark bar.

Review URL: http://codereview.chromium.org/1990015
------------------------------------------------------------------------
r46979 | rafaelw@chromium.org | 2010-05-12 01:18:27 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/app_background_page_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_has_permission
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_has_permission/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_lacks_permission
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/app_lacks_permission/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/basic
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/basic/content_script.js
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/basic/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/basic/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/common
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/common/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/common/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/common/bg.html
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/common/common.js
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/lacks_permission
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/lacks_permission/content_script.js
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/lacks_permission/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/app_background_page/lacks_permission/test.html

BackgroundContents browser test

BUG=41275

Review URL: http://codereview.chromium.org/2013015
------------------------------------------------------------------------
r46978 | zork@chromium.org | 2010-05-12 01:15:23 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h

Update password store for sync

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1999005
------------------------------------------------------------------------
r46977 | mattm@chromium.org | 2010-05-12 01:05:19 +0200 (Wed, 12 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc

ProcessSingletonLinux: check if lock pid is part of the current Chrome instance.

If it is, it must be an orphaned lock file that just happens to have an unfortunate pid, since we haven't tried to create a lockfile ourselves yet.

Also, don't allow kill with pid 0, which would be another way to theoretically kill ourselves.

BUG=42568,43594
TEST=ui_tests, manual testing

Review URL: http://codereview.chromium.org/1981009
------------------------------------------------------------------------
r46976 | dhg@chromium.org | 2010-05-12 01:03:36 +0200 (Wed, 12 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/platform_util_chromeos.cc

Fixing opening files on chromeos.

BUG=chromium-os:2743
TEST=trying to open a file

Review URL: http://codereview.chromium.org/2040008
------------------------------------------------------------------------
r46975 | chocobo@chromium.org | 2010-05-12 01:01:04 +0200 (Wed, 12 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc

Check in for njw@chromium.org:
http://codereview.chromium.org/1994012

Pass certificate authentication information back up to the network UI from libcros. 
Save the certificate authentication information with the passphrase. 
Display the right string in front of the private key password entry box. 

TEST=Manual. Log into a certificate-protected wireless network, then re-open the network dialog for that network and note that the information is still present. 
BUG=none
TBR=njw
Review URL: http://codereview.chromium.org/2048009
------------------------------------------------------------------------
r46974 | sky@chromium.org | 2010-05-12 00:54:26 +0200 (Wed, 12 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/controls/button/menu_button.cc

Fixes possible crash when menus were destroyed. I wasn't resetting a
pointer, leading to bad data write on destruction.

BUG=42513
TEST=see bug

Review URL: http://codereview.chromium.org/2013016
------------------------------------------------------------------------
r46973 | jhawkins@chromium.org | 2010-05-12 00:54:17 +0200 (Wed, 12 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker_platform_engine_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

TTF: Only compile and run spellchecker_platform_engine_unittest.cc for Mac only,
as this feature only exists for Mac. Remove logic that disabled the tests on
other platforms.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2051007
------------------------------------------------------------------------
r46972 | chocobo@chromium.org | 2010-05-12 00:52:30 +0200 (Wed, 12 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

Added an about:network page for ChromeOS.
Also removed some unnecessary repeated comments.
BUG=none
TEST=Try loading about:network
Review URL: http://codereview.chromium.org/1985015
------------------------------------------------------------------------
r46971 | dhg@chromium.org | 2010-05-12 00:35:48 +0200 (Wed, 12 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Fixing bug in url fetching. So it cleans up on the correct thread.  

Changing how we use the url fetcher so that the fetcher is cleaned up right after use.  If the fetcher still exists at shutdown, it tries to tell the IO thread to clean it up.
Review URL: http://codereview.chromium.org/2008013
------------------------------------------------------------------------
r46970 | georgey@chromium.org | 2010-05-12 00:34:03 +0200 (Wed, 12 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Fix 41010 on Windows: AutoFill profile shouldn't be saved when cancelled during initial setup
BUG=41010
TEST=in the bug.
Review URL: http://codereview.chromium.org/2015008
------------------------------------------------------------------------
r46969 | zork@chromium.org | 2010-05-12 00:27:00 +0200 (Wed, 12 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

patch from issue 2023004:
Fix Chrome OS pre-initial-sync options messaging.

When you first logged in to Chrome OS, it used to say "your account is not set up to sync" until you downloaded the initial sync. Now it follows the regular sync signup flow where it's "account details are not yet entered" until the authentication happens, then it's "setup in progress" while downloading the initial download, then it's "your account is set up to sync."

BUG=maybe in chrome OS tracker?
TEST=build chrome OS. log in to chrome OS with a new account. Immediately check wrench->options->personal stuff. It should not say "your account is not set up to sync..."

Review URL: http://codereview.chromium.org/2046005
------------------------------------------------------------------------
r46968 | jhawkins@chromium.org | 2010-05-11 23:45:46 +0200 (Tue, 11 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Tree fix: Initialize tab, which may be used uninitialized with certain code paths.

TBR=huanr
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1996013
------------------------------------------------------------------------
r46967 | aa@chromium.org | 2010-05-11 23:35:51 +0200 (Tue, 11 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/calendar_app/128.png
   M /trunk/src/chrome/browser/resources/calendar_app/24.png
   M /trunk/src/chrome/browser/resources/calendar_app/32.png
   M /trunk/src/chrome/browser/resources/calendar_app/48.png
   M /trunk/src/chrome/browser/resources/docs_app/128.png
   M /trunk/src/chrome/browser/resources/docs_app/24.png
   M /trunk/src/chrome/browser/resources/docs_app/32.png
   M /trunk/src/chrome/browser/resources/docs_app/48.png
   M /trunk/src/chrome/browser/resources/gmail_app/128.png
   M /trunk/src/chrome/browser/resources/gmail_app/24.png
   M /trunk/src/chrome/browser/resources/gmail_app/32.png
   M /trunk/src/chrome/browser/resources/gmail_app/48.png

Update icons for pre-installed apps.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r46965 | pkasting@chromium.org | 2010-05-11 23:32:20 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc

Remove vestiges of has_unsafe_content(), which is no longer used.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2049008
------------------------------------------------------------------------
r46964 | arv@chromium.org | 2010-05-11 23:30:49 +0200 (Tue, 11 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/resources/ntp/most_visited.css

NTP: a couple small tweaks

1. Change app image size to 96x96
2. Add 10px horizontal margins
3. Decrease font size a bit
4. Fix text color of the app icons

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2033007
------------------------------------------------------------------------
r46961 | akalin@chromium.org | 2010-05-11 23:09:04 +0200 (Tue, 11 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc

Added --use-ssl-tcp switch to sync_listen_notifications.

This lets us test connecting to the google talk servers with the
"magic" handshake on port 443.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/1934002
------------------------------------------------------------------------
r46955 | zork@chromium.org | 2010-05-11 22:04:01 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc

Remove an extra include.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1989010
------------------------------------------------------------------------
r46952 | jhawkins@chromium.org | 2010-05-11 21:32:26 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/snippet_unittest.cc

TTF: Mark Snippets.ThaiUTF8 as flaky instead of disabling the test.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1991007
------------------------------------------------------------------------
r46950 | skerner@chromium.org | 2010-05-11 21:23:37 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Move the refocus check so that the ntp code path hits it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2042006
------------------------------------------------------------------------
r46949 | eroman@chromium.org | 2010-05-11 21:17:54 +0200 (Tue, 11 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc

Fix-up the URL provided to the connection test runner, so users can enter partial URLs like "www.google.com" (instead of the exact URL, "http://www.google.com").

Review URL: http://codereview.chromium.org/1985012
------------------------------------------------------------------------
r46947 | mpcomplete@chromium.org | 2010-05-11 21:14:33 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Actually disable BrowserTest.ThirtyFourTabs on Mac.

TBR=bauerb
BUG=43862

Review URL: http://codereview.chromium.org/2023007
------------------------------------------------------------------------
r46946 | akalin@chromium.org | 2010-05-11 21:12:38 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/third_party/libjingle/libjingle.gyp

Added win-specific direct-dependent settings to libjingle.gyp.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/2042010
------------------------------------------------------------------------
r46944 | dpolukhin@chromium.org | 2010-05-11 20:30:24 +0200 (Tue, 11 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

Fix default info_bubble arrow location for RTL.

Review URL: http://codereview.chromium.org/2008011
------------------------------------------------------------------------
r46943 | willchan@chromium.org | 2010-05-11 20:13:39 +0200 (Tue, 11 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc

Add the response headers to net-internals.
BUG=43812

Review URL: http://codereview.chromium.org/2015011
------------------------------------------------------------------------
r46942 | oshima@chromium.org | 2010-05-11 20:13:26 +0200 (Tue, 11 May 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.h
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   A /trunk/src/chrome/browser/chromeos/login/mock_authenticator.h
   D /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   D /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added AuthenticateToUnlock which is to be used for screen lock.
 * Renamed Authenticate to AuthenticateToLogin
 * Removed obsolete PamGoogleAuthenticator and InChromeAuth option
 * Changed ScreenLocker to use AuthenticatToUnlock

Other changes:
  * Removed StubAuthenticator
  * Removed Profile from ScreenLock as it's no longer necessary
  * Moved MockAuthenticator to separate mock_authenticator file
  * added mock files to gyp file.

BUG=http://crosbug.com/2914
TEST=none yet
test will be added along with cros library

Review URL: http://codereview.chromium.org/2032006
------------------------------------------------------------------------
r46938 | erg@chromium.org | 2010-05-11 19:46:08 +0200 (Tue, 11 May 2010) | 9 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

Speed up the Task Manager on linux.

- Unify the calls to get shared memory and private memory. On Linux, these call the same API and on Linux, it takes >10ms to fetch both values each time it is called.
- Cache the returned memory values. While sorting the task manager by memory, it would make the expensive memory call for each row on each sort operation.

BUG=40033
TEST=Existing task manager tests.

Review URL: http://codereview.chromium.org/2047009
------------------------------------------------------------------------
r46936 | bulach@chromium.org | 2010-05-11 19:38:28 +0200 (Tue, 11 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Geolocation: fixes leak on tests after r46910

New tests weren't destroying the extra infobar:
http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/2066

TEST=GeolocationPermissionContextTests.*

Review URL: http://codereview.chromium.org/2017009
------------------------------------------------------------------------
r46932 | sky@chromium.org | 2010-05-11 19:19:03 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc

Fixes bug in BrowserList::FindBrowserWithFeature.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2014009
------------------------------------------------------------------------
r46930 | finnur@chromium.org | 2010-05-11 19:18:11 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

When in collapsed mode, the toolbar should not show the resize gripper.

BUG=None
TEST=With one or more browser action installed, look at the toolbar while a nano tab is selected and make sure there are no vertical lines right below the tabstrip.

Review URL: http://codereview.chromium.org/1998016
------------------------------------------------------------------------
r46929 | stuartmorgan@chromium.org | 2010-05-11 19:14:16 +0200 (Tue, 11 May 2010) | 8 lines
Changed paths:
   M /trunk/src/app/sql/statement.cc
   M /trunk/src/app/sql/statement.h
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   D /trunk/src/chrome/browser/meta_table_helper.cc
   D /trunk/src/chrome/browser/meta_table_helper.h
   D /trunk/src/chrome/browser/meta_table_helper_unittest.cc
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Get rid of MetaTableHelper class and make use of the app/sql API in the LoginDatabase.

BUG=None
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1700017
------------------------------------------------------------------------
r46925 | zelidrag@chromium.org | 2010-05-11 18:15:27 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Disabled full text indexing of page content on ChromeOS. We need to figure out better index cleanup strategy for these devices if we re-enable it in the future.

BUG=chromium-os:2808
TEST=none

Review URL: http://codereview.chromium.org/1990011
------------------------------------------------------------------------
r46924 | zelidrag@chromium.org | 2010-05-11 18:05:09 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/select_file_dialog.cc

Fix for assert in SavePackage::ContinueSave(): save package type index outside of allowed bounds. 

BUG=chromium-os:3180
TEST=see repro steps

Review URL: http://codereview.chromium.org/2029007
------------------------------------------------------------------------
r46921 | nkostylev@google.com | 2010-05-11 17:13:52 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Fix crash when switching to "Other user".

BUG=http://crosbug.com/3181
TEST=At login screen click "Other user". Login screen should be shown.

Review URL: http://codereview.chromium.org/1990014
------------------------------------------------------------------------
r46916 | dmazzoni@chromium.org | 2010-05-11 16:31:09 +0200 (Tue, 11 May 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   A /trunk/src/chrome/browser/browser_accessibility_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/third_party/iaccessible2
   A /trunk/src/third_party/iaccessible2/ia2_api_all.idl
   A /trunk/src/third_party/iaccessible2/iaccessible2.gyp
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h
   D /trunk/src/webkit/glue/webaccessibilitymanager.h
   M /trunk/src/webkit/glue/webkit_glue.gypi

Reimplement accessibility of web content by caching the entire 
accessibility tree in the browser process.

Adds new RPCs for a browser tab to request accessibility info from
a renderer; the renderer responds with a complete tree of
accessibility metadata for the entire DOM, which is then cached
in the RenderWidgetHostView. This part is cross-platform and will
help with accessibility on both Windows and Mac OS X.

For Windows, MSAA support for web content has been rewritten to
use this new cache. Tested in JAWS and NVDA screen readers.
Using Chrome with a screen reader is now fast and stable,
unlike the previous implementation. However, note that most
advanced functionality is still not supported, and much work remains
to make Chrome work well with a screen reader. This is a necessary
step to improve stability first.

BUG=25564
BUG=13291
TEST=See http://codereview.chromium.org/1806001

Review URL: http://codereview.chromium.org/1637018
------------------------------------------------------------------------
r46915 | bauerb@chromium.org | 2010-05-11 16:26:17 +0200 (Tue, 11 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Revert r46909: "Reland r46681: Use IPC to wait for download in DownloadTest."

TBR=bauerb
TEST=ui_tests on 10.6 and ChromiumOS should go green.
BUG=43066

Review URL: http://codereview.chromium.org/1985014
------------------------------------------------------------------------
r46913 | bauerb@chromium.org | 2010-05-11 16:01:12 +0200 (Tue, 11 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

fix compile error.

Review URL: http://codereview.chromium.org/2027005
------------------------------------------------------------------------
r46912 | bauerb@chromium.org | 2010-05-11 15:51:02 +0200 (Tue, 11 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_json_validity_unittest.cc

Disable BrowserTest.ThirtyFourTabs on Mac.

Also, add a comment to the previously disabled ExtensionApiJsonValidityTest.WithV8 test.

TBR=phajdan.jr
BUG=43862
TEST=Chromium Mac going green.

Review URL: http://codereview.chromium.org/2057005
------------------------------------------------------------------------
r46911 | bulach@chromium.org | 2010-05-11 15:28:16 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_settings_state.h
   A /trunk/src/chrome/browser/geolocation/geolocation_settings_state_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds GeolocationSettingsState

TEST=geolocation_settings_state_unittest.cc

Review URL: http://codereview.chromium.org/1540034
------------------------------------------------------------------------
r46910 | bulach@chromium.org | 2010-05-11 15:08:52 +0200 (Tue, 11 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/test/testing_profile.h

Geolocation: checks pending requests with the same origin when receiving the infobar response.

Moves GeolocationPermissionContext from GeolocationDispatcherHost up to profile.

TEST=GeolocationPermissionContextTests.MultipleOrigins or manual: open two tabs from the same origin with geolocation. Check both info bars are created. Reply to only one of them, check the other is gone.

BUG=40527

Review URL: http://codereview.chromium.org/1585036
------------------------------------------------------------------------
r46909 | bauerb@chromium.org | 2010-05-11 14:42:51 +0200 (Tue, 11 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Reland r46681: Use IPC to wait for download in DownloadTest.

Add AutomationMsg_WaitForDownloadShelfVisibilityChange and use it in UITestBase for the download tests.

This should decrease flakiness of download tests.

TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab*
BUG=43066

Review URL: http://codereview.chromium.org/2051002
------------------------------------------------------------------------
r46901 | bulach@chromium.org | 2010-05-11 11:28:02 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Uses GetOrigin() when setting the Geolocation state for the tab.

BUG=42869
TEST=GeolocationPermissionContextTests.*

Review URL: http://codereview.chromium.org/1789012
------------------------------------------------------------------------
r46896 | yusukes@google.com | 2010-05-11 09:36:47 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Temporarily disabled the window position adjustment since it does not work fine with ibus-mozc.

BUG=none
TEST=manual. checked that the window does not flicker.

Review URL: http://codereview.chromium.org/1987011
------------------------------------------------------------------------
r46895 | phajdan.jr@chromium.org | 2010-05-11 08:48:38 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Fix ChromeOS build (one missing #include).

TBR=brettw

Review URL: http://codereview.chromium.org/2054008
------------------------------------------------------------------------
r46894 | phajdan.jr@chromium.org | 2010-05-11 08:42:14 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/language_combobox_model.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.h

Reduce header dependencies in chrome/

TEST=if it compiles, it is perfect
BUG=none

Review URL: http://codereview.chromium.org/2001007
------------------------------------------------------------------------
r46893 | eroman@chromium.org | 2010-05-11 08:14:51 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/testview.js

Aesthetic change to about:net-internals -- make the tables look less ugly by collapsing the border.

TBR=willchan

Review URL: http://codereview.chromium.org/1987010
------------------------------------------------------------------------
r46891 | yusukes@google.com | 2010-05-11 07:47:24 +0200 (Tue, 11 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc

Remove the too chatty LOG(INFO):

INFO:chrome/browser/chromeos/cros/language_library.cc(277)] No connection to IBus. # of pending set config commands: NN

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2007008
------------------------------------------------------------------------
r46889 | craig.schlenter@chromium.org | 2010-05-11 06:36:05 +0200 (Tue, 11 May 2010) | 12 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.cc

Linux: fix compilation error with gcc 4.5.

Avoid a gcc 4.5 warning/error for values that aren't part
of NPNVariable. Also drop some unnecessary static_casts by
swapping from an int to a size_t in TemplateURLRef's
Replacement struct and use platform specific NULL or 0
constants in a couple of places.

BUG=43341
TEST=chrome target compiles with gcc 4.5.

Review URL: http://codereview.chromium.org/2019002
------------------------------------------------------------------------
r46882 | johnnyg@chromium.org | 2010-05-11 03:00:07 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc

Resize sprites on linux to match the new images checked in.

BUG=43795
TEST=none
Review URL: http://codereview.chromium.org/2001010
------------------------------------------------------------------------
r46881 | eroman@chromium.org | 2010-05-11 02:58:24 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/main.css

Aesthetic changes to the tabstrip at the top of about:net-internals (make the tabs smaller so it doesn't overflow all the time).

BUG=37421

Review URL: http://codereview.chromium.org/2050006
------------------------------------------------------------------------
r46878 | eroman@chromium.org | 2010-05-11 02:08:39 +0200 (Tue, 11 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_net_log.cc

Make ChromeNetLog::HaListener() work under the new about:net-internals implementation.

Review URL: http://codereview.chromium.org/2036009
------------------------------------------------------------------------
r46877 | eroman@chromium.org | 2010-05-11 02:07:41 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js

Add custom formatting for the HTTP request headers.

BUG=37421

Review URL: http://codereview.chromium.org/2025005
------------------------------------------------------------------------
r46875 | pkasting@chromium.org | 2010-05-11 01:44:06 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Attempted ChromiumOS compile fix.

BUG=none
TEST=none

------------------------------------------------------------------------
r46874 | jianli@chromium.org | 2010-05-11 01:42:59 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h

Fix bug REGRESSION: Extension settings / options / preferences are not being saved

BUG=43561
TEST=Will be added later

Review URL: http://codereview.chromium.org/2020006
------------------------------------------------------------------------
r46873 | evan@chromium.org | 2010-05-11 01:42:40 +0200 (Tue, 11 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_util.cc

gtk: fix setting minimum window size to not produce conflicting info

Before we could potentially set a minimum size greater than the
maximum size.  Now we take whichever is larger: the size requested
in the resources and the actual size of the content.  This allows
the resource size to grow the window larger without chopping off
the content if the content is larger than the specified resources size.

BUG=40580
TEST=verified it looked ok in en, pt, and de (all three cases are different)

Review URL: http://codereview.chromium.org/2034005
------------------------------------------------------------------------
r46872 | estade@chromium.org | 2010-05-11 01:32:14 +0200 (Tue, 11 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc

GTK: use IDS_BROWSER_HANGMONITOR_RENDERER_TITLE as the hung renderer dialog title.

BUG=43103
TEST=none

Review URL: http://codereview.chromium.org/2011011
------------------------------------------------------------------------
r46869 | pkasting@chromium.org | 2010-05-11 01:15:21 +0200 (Tue, 11 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/resize_gripper.cc
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Eliminate View::UILayoutIsRightToLeft() to standardize on base::i18n::IsRTL().  Was only needed for EnableUIMirroringForRTLLanguages(), which was only used by Views::Label, which already had this capability via set_rtl_alignment_mode().

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1991002
------------------------------------------------------------------------
r46868 | eroman@chromium.org | 2010-05-11 01:13:56 +0200 (Tue, 11 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   A /trunk/src/chrome/browser/net/view_http_cache_job_factory.cc (from /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc:46824)
   A /trunk/src/chrome/browser/net/view_http_cache_job_factory.h (from /trunk/src/chrome/browser/net/view_net_internals_job_factory.h:46824)
   D /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   D /trunk/src/chrome/browser/net/view_net_internals_job_factory.h
   M /trunk/src/chrome/browser/resources/net_internals/httpcacheview.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/net_log.h
   D /trunk/src/net/base/net_log_util.cc
   D /trunk/src/net/base/net_log_util.h
   D /trunk/src/net/base/net_log_util_unittest.cc
   M /trunk/src/net/net.gyp
   D /trunk/src/net/tools/dns_trace_formatter

Replace about:net-internals with the javascript-based frontend.

(DNS request tracing is the only feature lost in this transition; it needs to be added back under the new framework).

BUG=37421

Review URL: http://codereview.chromium.org/2008007
------------------------------------------------------------------------
r46866 | eroman@chromium.org | 2010-05-11 00:45:56 +0200 (Tue, 11 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js

Display the text dump for chrome://net2#data inline, rather than in a new window, to avoid having to use a data:URL (large data URLs do not work in Chrome).

Also gets rid of the JSON output (since it isn't needed right now, and just adds clutter).

BUG=37421

Review URL: http://codereview.chromium.org/2052003
------------------------------------------------------------------------
r46863 | jcivelli@chromium.org | 2010-05-11 00:33:56 +0200 (Tue, 11 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h

Adding a way to pin the info bubble arrow.
It is useful with the app launcher that should
always stay at the same location.

BUG=43754
TEST=Open the app launcher with the Chrome window at the bottom of
     the screen.  The app launcher bubble should be displayed in the browser,
     with the app launcher location bar aligned with the browser's one.

Review URL: http://codereview.chromium.org/2000005
------------------------------------------------------------------------
r46860 | sky@chromium.org | 2010-05-11 00:19:24 +0200 (Tue, 11 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_unittest.cc

Changes autocomplete to only prefix with http if haven't modified
host.

BUG=43585
TEST=see bug

Review URL: http://codereview.chromium.org/1993006
------------------------------------------------------------------------
r46858 | dhg@chromium.org | 2010-05-10 23:05:35 +0200 (Mon, 10 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Fixing upload case to picasaweb

Review URL: http://codereview.chromium.org/2034004
------------------------------------------------------------------------
r46856 | suzhe@chromium.org | 2010-05-10 22:53:37 +0200 (Mon, 10 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac]Refactor input method related code.

BUG=30670 Cannot input any characters after typing CTRL+H on IME
BUG=33824 Shortcut key Ctrl+K in Japanese IME reset cursor position to end of the string
BUG=42690 first ime keydown has the wrong keycode on Mac
BUG=43087 1st time type CJK character with IME in any text input field of websites,1st character is always deleted.
BUG=43454 When converting a Hangul to Chinese character, a new line is inserted before the character to convert.
TEST=See bug reports.

Review URL: http://codereview.chromium.org/1908006
------------------------------------------------------------------------
r46855 | pkasting@chromium.org | 2010-05-10 22:52:04 +0200 (Mon, 10 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Elide text runs properly in the omnibox dropdown.

This turned out to be far more complex than I had expected, but it handles the following edge cases correctly where neither the old code nor the patch at http://codereview.chromium.org/1774018 did:
* RTL substrings in LTR UI
* Drawing a complete classification that leaves too little room for the next to fit even an ellipsis
* Strings where kerning makes the string width != the sum of the character widths

BUG=41716
TEST=Omnibox should elide long URLs, mixed LTR/RTL text, etc. correctly in both LTR and RTL locales.
Review URL: http://codereview.chromium.org/1992002
------------------------------------------------------------------------
r46854 | pkasting@chromium.org | 2010-05-10 22:51:15 +0200 (Mon, 10 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Show titles instead of URLs in the "show on startup" table, and add tooltips containing title and URL.

BUG=43259
TEST=Add items to "show these URLs on startup" option table.  They should show as titles.  Hover one.  You should see a tooltip with the title and URL.
Review URL: http://codereview.chromium.org/2048006
------------------------------------------------------------------------
r46853 | sky@chromium.org | 2010-05-10 22:50:19 +0200 (Mon, 10 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Changes tab renderer to always show app icon.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2055007
------------------------------------------------------------------------
r46852 | mrossetti@chromium.org | 2010-05-10 22:49:44 +0200 (Mon, 10 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Update comments to clarify purpose of a function.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2022005
------------------------------------------------------------------------
r46850 | thestig@chromium.org | 2010-05-10 22:46:54 +0200 (Mon, 10 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome_frame/crash_reporting/nt_loader_unittest.cc
   M /trunk/src/chrome_frame/vtable_patch_manager_unittest.cc
   M /trunk/src/media/tools/player_wtl/movie.h
   M /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_thread_async_call_test.cc

Cleanup: Add a bunch of missing includes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2018001
------------------------------------------------------------------------
r46847 | dmazzoni@chromium.org | 2010-05-10 22:21:41 +0200 (Mon, 10 May 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   D /trunk/src/chrome/browser/browser_accessibility_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/third_party/iaccessible2
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h
   A /trunk/src/webkit/glue/webaccessibilitymanager.h (from /trunk/src/webkit/glue/webaccessibilitymanager.h:46841)
   M /trunk/src/webkit/glue/webkit_glue.gypi

Revert 46842 - Reimplement accessibility of web content by caching the entire 
accessibility tree in the browser process.

Adds new RPCs for a browser tab to request accessibility info from
a renderer; the renderer responds with a complete tree of
accessibility metadata for the entire DOM, which is then cached
in the RenderWidgetHostView. This part is crossplatform and will
help with accessibility on both Windows and Mac OS X.

For Windows, MSAA support for web content has been rewritten to
use this new cache. Tested in JAWS and NVDA screen readers.
Using Chrome with a screen reader is now fast and stable,
unlike the previous implementation. However, note that most
advanced functionality is still not supported, and much work remains
to make Chrome work well with a screen reader. This is a necessary
step to improve stability first.

BUG=25564
BUG=13291
TEST=See http://codereview.chromium.org/1806001

Review URL: http://codereview.chromium.org/1637018

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/1989009
------------------------------------------------------------------------
r46842 | dmazzoni@chromium.org | 2010-05-10 21:35:42 +0200 (Mon, 10 May 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   A /trunk/src/chrome/browser/browser_accessibility_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/third_party/iaccessible2
   A /trunk/src/third_party/iaccessible2/ia2_api_all.idl
   A /trunk/src/third_party/iaccessible2/iaccessible2.gyp
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h
   D /trunk/src/webkit/glue/webaccessibilitymanager.h
   M /trunk/src/webkit/glue/webkit_glue.gypi

Reimplement accessibility of web content by caching the entire 
accessibility tree in the browser process.

Adds new RPCs for a browser tab to request accessibility info from
a renderer; the renderer responds with a complete tree of
accessibility metadata for the entire DOM, which is then cached
in the RenderWidgetHostView. This part is cross-platform and will
help with accessibility on both Windows and Mac OS X.

For Windows, MSAA support for web content has been rewritten to
use this new cache. Tested in JAWS and NVDA screen readers.
Using Chrome with a screen reader is now fast and stable,
unlike the previous implementation. However, note that most
advanced functionality is still not supported, and much work remains
to make Chrome work well with a screen reader. This is a necessary
step to improve stability first.

BUG=25564
BUG=13291
TEST=See http://codereview.chromium.org/1806001

Review URL: http://codereview.chromium.org/1637018
------------------------------------------------------------------------
r46840 | tim@chromium.org | 2010-05-10 21:17:16 +0200 (Mon, 10 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

sync: add default constructor to EntryKernel to avoid UMR of dirty_ bit.

Also add comments as requested by chron's post-submit code review.

BUG=43613
TEST=SyncableDirectoryTest

Review URL: http://codereview.chromium.org/2013011
------------------------------------------------------------------------
r46836 | estade@chromium.org | 2010-05-10 20:56:09 +0200 (Mon, 10 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc

GTK: swap ok/cancel button order in sync personalization dialog.

BUG=43625
TEST=none

Review URL: http://codereview.chromium.org/2026007
------------------------------------------------------------------------
r46833 | finnur@chromium.org | 2010-05-10 20:27:12 +0200 (Mon, 10 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Get rid of the transparent line at the top of the nano tabs.

BUG=42154
TEST=Visual inspection. Make sure you have a dark background below the Chrome window to see the transparency.

Review URL: http://codereview.chromium.org/2008006
------------------------------------------------------------------------
r46827 | mrossetti@chromium.org | 2010-05-10 19:52:41 +0200 (Mon, 10 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h

Discontinue tracking folder menus as soon as any bookmark is clicked.

BUG=43622
TEST=Pop open a folder on the bookmark bar and verify that mousing over various folders causes their menus to appear. Find a bookmark within one of those folders and click on it. Verify that mousing over folders in the bookmark bar no longer cause the folder menus to appear.

Review URL: http://codereview.chromium.org/2044006
------------------------------------------------------------------------
r46826 | eroman@chromium.org | 2010-05-10 19:52:02 +0200 (Mon, 10 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   A /trunk/src/chrome/browser/resources/net_internals/httpcacheview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/chrome_browser.gypi

Add the http cache info to chrome://net2.

BUG=37421

Review URL: http://codereview.chromium.org/2011009
------------------------------------------------------------------------
r46825 | rsesek@chromium.org | 2010-05-10 19:28:32 +0200 (Mon, 10 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

[Mac] Plumb the pinned tab flag through TabController so the context menu uses the correct state.

BUG=42339
TEST=Create tab, pin it. Unpin it. Context menu works as before.

Review URL: http://codereview.chromium.org/2057002
------------------------------------------------------------------------
r46821 | jar@chromium.org | 2010-05-10 18:35:47 +0200 (Mon, 10 May 2010) | 8 lines
Changed paths:
   M /trunk/src/base/spin_wait.h
   M /trunk/src/base/tracked.cc
   M /trunk/src/base/tracked.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/test/chrome_process_util.cc
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/disk_cache/block_files.cc

Switch to using TimeTicks for profiling and histograms

Avoid using wall clock time, which can be changed by the user,
or impacted by Daylight Savings transitions etc.

BUG=14193
r=eroman
Review URL: http://codereview.chromium.org/1253005
------------------------------------------------------------------------
r46818 | jcivelli@chromium.org | 2010-05-10 18:09:20 +0200 (Mon, 10 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc

Make the app launcher location bar's height match the browser's one.

BUG=None
TEST=Open the app launcher. The browser and app launcher location bars
     should be exactly the same height.

Review URL: http://codereview.chromium.org/2056001
------------------------------------------------------------------------
r46817 | sky@chromium.org | 2010-05-10 17:51:54 +0200 (Mon, 10 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Fixes two bugs in mini tab title animation:
. Once stopped the animation would never restart.
. The animation wouldn't stop when a tab went phantom.

BUG=43573
TEST=none

Review URL: http://codereview.chromium.org/2047004
------------------------------------------------------------------------
r46816 | sky@chromium.org | 2010-05-10 17:35:38 +0200 (Mon, 10 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

I don't know how it could happen, but according to this bug it's
possible for a phantom tab to show the crashed icons. This should make
it so that can never happen.

BUG=40118
TEST=none

Review URL: http://codereview.chromium.org/2035008
------------------------------------------------------------------------
r46810 | aa@chromium.org | 2010-05-10 08:31:22 +0200 (Mon, 10 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   A /trunk/src/chrome/browser/resources/app_gallery_icon.png
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add first cut at gallery integration.

Review URL: http://codereview.chromium.org/1989007
------------------------------------------------------------------------
r46809 | yusukes@google.com | 2010-05-10 07:38:24 +0200 (Mon, 10 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Don't sync IME prefs that are not user-configurable (2nd patch).
The first one is: http://src.chromium.org/viewvc/chrome?view=rev&revision=46679

- Removed prefs::kLanguagePinyinDoublePinyinSchema and prefs::kLanguagePinyinLookupTablePageSize to fix issue 3009. I should've removed them in the first patch...
- Added a comment.
- Sorted prefs by name.

BUG=chromium-os:3009
TEST=none

Review URL: http://codereview.chromium.org/2043007
------------------------------------------------------------------------
r46804 | arv@chromium.org | 2010-05-09 21:17:55 +0200 (Sun, 09 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html

NTP: Fix issue where hiding the tips did not work.

BUG=43254
TEST=Open the drop down menu and toggle the tips.

Review URL: http://codereview.chromium.org/1981001
------------------------------------------------------------------------
r46800 | zork@chromium.org | 2010-05-09 16:28:58 +0200 (Sun, 09 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc

Fix crash when signing in with certain desktop notification settings.

BUG=42216
TEST=See bug

Review URL: http://codereview.chromium.org/2045007
------------------------------------------------------------------------
r46798 | dpolukhin@chromium.org | 2010-05-09 06:12:24 +0200 (Sun, 09 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

Fix default arrow location as it was before.

TBR=jcivelli
BUG=none
TEST=On Windows, start Chromium with --app-launcher-new-tab --enable-extension-apps and press newtab button. The bubble shouldn't jump and arrow location should be somewhere in the middle.
Review URL: http://codereview.chromium.org/1990008
------------------------------------------------------------------------
r46794 | aa@chromium.org | 2010-05-09 04:39:11 +0200 (Sun, 09 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Experiment: reuse an existing NTP if one exists.

Review URL: http://codereview.chromium.org/1986006
------------------------------------------------------------------------
r46791 | sky@chromium.org | 2010-05-08 21:31:25 +0200 (Sat, 08 May 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Converts dragged tab controller to only create the drag window when
detached. Otherwise the dragged tab remains in the tab strip, it's
just moved around. I also made it so the tab that originated the drag
can be deleted.

I'm doing this for a couple of reasons:
. make it easier to use dragged tab controller with side tabs.
. chromeos doesn't allow detaching, and only created the window when
  we really need it makes for a better experience there.
. no flicker!

BUG=none
TEST=thoroughly test tab dragging to make sure I haven't broken
anything.

Review URL: http://codereview.chromium.org/1998009
------------------------------------------------------------------------
r46783 | jhawkins@chromium.org | 2010-05-08 10:35:09 +0200 (Sat, 08 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

gtk: Delay load the AutoFill profiles and credit cards.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2041005
------------------------------------------------------------------------
r46782 | phajdan.jr@chromium.org | 2010-05-08 10:31:01 +0200 (Sat, 08 May 2010) | 7 lines
Changed paths:
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc

Replace #if 0 used to disable test, the DISABLED_ and FLAKY_
prefixes, so the code doesn't rot.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2035009
------------------------------------------------------------------------
r46778 | finnur@chromium.org | 2010-05-08 05:02:51 +0200 (Sat, 08 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Disable extension app tab throbber if command line flag set.

This is a temporary measure until we have a better throbber for
extension app tabs (or we remove them).

BUG=None
TEST=Pass in --disable-throbber-for-extension-apps and make
sure the icon for nano tabs don't get replaced by a throbber.

Review URL: http://codereview.chromium.org/2032003
------------------------------------------------------------------------
r46775 | aa@chromium.org | 2010-05-08 04:48:33 +0200 (Sat, 08 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Collapse toolbars in app tabs.

Review URL: http://codereview.chromium.org/2016002
------------------------------------------------------------------------
r46768 | estade@chromium.org | 2010-05-08 02:48:43 +0200 (Sat, 08 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc

GTK: don't accept DnD drops of size 0 in the render view.

BUG=43347
TEST=none

Review URL: http://codereview.chromium.org/2044005
------------------------------------------------------------------------
r46767 | estade@chromium.org | 2010-05-08 02:45:42 +0200 (Sat, 08 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

GTK: add http:// to cuts as well as copies in the omnibox.

BUG=43569
TEST=manual

Review URL: http://codereview.chromium.org/2021006
------------------------------------------------------------------------
r46765 | michaeln@chromium.org | 2010-05-08 02:32:44 +0200 (Sat, 08 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/worker/DEPS
   M /trunk/src/chrome/worker/websharedworker_stub.cc
   M /trunk/src/chrome/worker/websharedworker_stub.h
   M /trunk/src/chrome/worker/webworker_stub.cc
   M /trunk/src/chrome/worker/webworker_stub.h
   M /trunk/src/chrome/worker/webworker_stub_base.cc
   M /trunk/src/chrome/worker/webworker_stub_base.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   A /trunk/src/chrome/worker/worker_webapplicationcachehost_impl.cc
   A /trunk/src/chrome/worker/worker_webapplicationcachehost_impl.h

Add some more IPC plumbing and scaffolding to support having appcache work in workers. Everything is still stubbed out at runtime (runtime feature is still disabled in the worker process, and the values in the IPC messages are all zero'd out).

* Widen the CreateWorker IPC message sent from the browser to the worker process to contain additional data needed to initialize an appcache for that worker.

* Add a new worker specific WorkerWebApplicationCacheHostImpl class and instantiate one with the initialization data received in the IPC.

* Give the WorkerThread an AppCacheDispatcher.

* Propagate the cmd-line argument to disable the appcache to the worker process.

* Fixup DEPs to show that chrome/workers depends on webkit/appcache

BUG=39368
TEST=thinking about what tests to put together for this CL
Review URL: http://codereview.chromium.org/1719007
------------------------------------------------------------------------
r46763 | aa@chromium.org | 2010-05-08 02:15:24 +0200 (Sat, 08 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Add the geolocation permission to the extension install dialog.

BUG=43172

Review URL: http://codereview.chromium.org/2044002
------------------------------------------------------------------------
r46759 | arv@chromium.org | 2010-05-08 01:48:04 +0200 (Sat, 08 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   D /trunk/src/chrome/browser/resources/shared/js/cr/event.js
   M /trunk/src/chrome/browser/resources/shared/js/cr/event_target_test.html
   M /trunk/src/chrome/browser/resources/shared/js/cr/promise_test.html
   M /trunk/src/chrome/browser/resources/shared/js/cr.js
   M /trunk/src/chrome/browser/resources/shared/js/cr_test.html
   M /trunk/src/chrome/chrome_browser.gypi

Move cr.Event into cr.js since that file should not depend on any other files.

BUG=None
TEST=Manually ran the js tests

Review URL: http://codereview.chromium.org/2014005
------------------------------------------------------------------------
r46755 | oshima@chromium.org | 2010-05-08 01:21:47 +0200 (Sat, 08 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h

Add UpdateAndShowNotification API to BallonCollectionIml
  I was going to do Show(std::stringi d), but it'd require some refactoring on notification framework,
  so I decided to have UPdateAndShow first. I'll do refactoring once I finish screen lock and will
  update the code accordingly.

other minor changes:
 * removed is_visible() as it's unnecessary.
 * cleanup browsertests code.

BUG=http://crosbug.com/2692
TEST=added test cases to existing browser tests.

Review URL: http://codereview.chromium.org/1933008
------------------------------------------------------------------------
r46753 | pkasting@chromium.org | 2010-05-08 01:15:00 +0200 (Sat, 08 May 2010) | 5 lines
Changed paths:
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/table_view.cc

Remove a few stray bits of win2k support.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1998012
------------------------------------------------------------------------
r46752 | willchan@chromium.org | 2010-05-08 01:14:25 +0200 (Sat, 08 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/net/url_fetcher.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Pass HttpRequestHeaders to URLRequest::SetExtraRequestHeaders().
BUG=22588

Review URL: http://codereview.chromium.org/1998008
------------------------------------------------------------------------
r46749 | arv@chromium.org | 2010-05-08 01:09:01 +0200 (Sat, 08 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

NTP: Update theme colors

Set the color of the text for the app icons.
Since we do not have a background on sections any more

BUG=43578
TEST=None

Review URL: http://codereview.chromium.org/2016007
------------------------------------------------------------------------
r46748 | eroman@chromium.org | 2010-05-08 01:00:15 +0200 (Sat, 08 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/chrome/browser/resources/net_internals/util.js

Add the requests dumps to the text summary on chrome://net2#data

BUG=37421
Review URL: http://codereview.chromium.org/1994006
------------------------------------------------------------------------
r46747 | albertb@chromium.org | 2010-05-08 00:50:29 +0200 (Sat, 08 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   A /trunk/src/chrome/browser/sync/protocol/password_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/chrome.gyp

Re-land the protocol extension for syncing passwords patch.

BUG=34176
TEST=none

Review URL: http://codereview.chromium.org/2024006
------------------------------------------------------------------------
r46746 | xiyuan@chromium.org | 2010-05-08 00:42:53 +0200 (Sat, 08 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc

Put CustomizeSyncWindowGtk in NativeDialogHost for ChromeOS.

BUG=none
TEST=Verify that "Customize" button on "Personal Stuff" options page brings you the dialog with a Chrome window frame and not occupy the full screen.

Review URL: http://codereview.chromium.org/2043005
------------------------------------------------------------------------
r46744 | mrossetti@chromium.org | 2010-05-08 00:14:06 +0200 (Sat, 08 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Refactor menu window height, position, and presence of scrolling arrows code out of configureWindow and into a new adjustWindowForHeight: method. Call this method when adding or removing bookmark nodes to the menu, such as for dropping or pasting. When adjusting the button widths consider the best cell width, which may be less than the current button width, so that folder menus can shrink as well as grow. When adding the first bookmark to an empty folder remove the '(empty)' placeholder and when removing the last real bookmark from a folder insert the '(empty)' placeholder.

BUG=42868,43227
TEST=In addition to attempting to recreate the problems as described in the bug reports: 1) Add (by dragging in or pasting) a new bookmark to a folder which is on the edge of being too big and needing to scroll and verify that it does become scrollable, 2) remove a bookmark (by cutting or deleting) from the folder which just became scrollable and verify that it is no longer scrollable, 3) create a new, empty folder and verify that it shows '(empty)' , 4) add a bookmark (by dragging or pasting) to the newly created empty folder and verify that there is only one bookmark shown and that it is not the '(empty)' placeholder, and 5) remove the single bookmark just added to the folder (by cutting or deleting) and verify that the menu now shows the '(empty)' placeholder.
Review URL: http://codereview.chromium.org/2024004
------------------------------------------------------------------------
r46739 | sanjeevr@chromium.org | 2010-05-07 23:39:55 +0200 (Fri, 07 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chrome_plugin_unittest.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h
   M /trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   M /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   D /trunk/src/chrome/browser/net/test_url_fetcher_factory.cc
   D /trunk/src/chrome/browser/net/test_url_fetcher_factory.h
   D /trunk/src/chrome/browser/net/url_fetcher.cc
   D /trunk/src/chrome/browser/net/url_fetcher.h
   D /trunk/src/chrome/browser/net/url_fetcher_protect.cc
   D /trunk/src/chrome/browser/net/url_fetcher_protect.h
   D /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   D /trunk/src/chrome/browser/net/url_request_context_getter.cc
   D /trunk/src/chrome/browser/net/url_request_context_getter.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.cc
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_backend.h
   M /trunk/src/chrome/browser/printing/cloud_print/job_status_updater.h
   M /trunk/src/chrome/browser/printing/cloud_print/printer_job_handler.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/net/test_url_fetcher_factory.cc (from /trunk/src/chrome/browser/net/test_url_fetcher_factory.cc:46651)
   A /trunk/src/chrome/common/net/test_url_fetcher_factory.h (from /trunk/src/chrome/browser/net/test_url_fetcher_factory.h:46651)
   A /trunk/src/chrome/common/net/url_fetcher.cc (from /trunk/src/chrome/browser/net/url_fetcher.cc:46651)
   A /trunk/src/chrome/common/net/url_fetcher.h (from /trunk/src/chrome/browser/net/url_fetcher.h:46651)
   A /trunk/src/chrome/common/net/url_fetcher_protect.cc (from /trunk/src/chrome/browser/net/url_fetcher_protect.cc:46651)
   A /trunk/src/chrome/common/net/url_fetcher_protect.h (from /trunk/src/chrome/browser/net/url_fetcher_protect.h:46651)
   A /trunk/src/chrome/common/net/url_fetcher_unittest.cc (from /trunk/src/chrome/browser/net/url_fetcher_unittest.cc:46651)
   A /trunk/src/chrome/common/net/url_request_context_getter.cc (from /trunk/src/chrome/browser/net/url_request_context_getter.cc:46651)
   A /trunk/src/chrome/common/net/url_request_context_getter.h (from /trunk/src/chrome/browser/net/url_request_context_getter.h:46651)
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Moved URLFetcher and related classes to chrome/common/net.
BUG=None
TEST=Build and Unittests
Review URL: http://codereview.chromium.org/1995008
------------------------------------------------------------------------
r46737 | nick@chromium.org | 2010-05-07 22:43:20 +0200 (Fri, 07 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h

Revert 46735 - Fix Chrome OS preinitialsync options messaging.

When you first logged in to Chrome OS, it used to say "your account is not set up to sync" until you downloaded the initial sync.  Now it follows the regular sync signup flow where it's "account details are not yet entered" until the authentication happens, then it's "setup in progress" while downloading the initial download, then it's "your account is set up to sync."

BUG=maybe in chrome OS tracker?
TEST=build chrome OS.  log in to chrome OS with a new account.  Immediately check wrench>options>personal stuff.  It should not say "your account is not set up to sync..."

Review URL: http://codereview.chromium.org/2023004

TBR=dantasse@chromium.org
Review URL: http://codereview.chromium.org/2049002
------------------------------------------------------------------------
r46735 | dantasse@chromium.org | 2010-05-07 22:37:31 +0200 (Fri, 07 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h

Fix Chrome OS pre-initial-sync options messaging.

When you first logged in to Chrome OS, it used to say "your account is not set up to sync" until you downloaded the initial sync.  Now it follows the regular sync signup flow where it's "account details are not yet entered" until the authentication happens, then it's "setup in progress" while downloading the initial download, then it's "your account is set up to sync."

BUG=maybe in chrome OS tracker?
TEST=build chrome OS.  log in to chrome OS with a new account.  Immediately check wrench->options->personal stuff.  It should not say "your account is not set up to sync..."

Review URL: http://codereview.chromium.org/2023004
------------------------------------------------------------------------
r46730 | thestig@chromium.org | 2010-05-07 21:36:15 +0200 (Fri, 07 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_utils_gtk_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

gtk: Fix bookmark_utils::GetNodesFromSelection to not crash on invalid data.

BUG=43347
TEST=included
Review URL: http://codereview.chromium.org/2048002
------------------------------------------------------------------------
r46729 | shess@chromium.org | 2010-05-07 21:27:36 +0200 (Fri, 07 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Fix omnibox popup for scaling.

Make it so that the code carefully shuffled rects, points, and sizes
through the right conversions as it moves from view coordinates to
screen coordinates (to position the popup).

This only really comes up when you're debuggin whether your pretty
scalable PDF graphics really work by using Quartz Debug to set the
scale factor to 3 or something.

BUG=40999
TEST=See bug

Review URL: http://codereview.chromium.org/2028004
------------------------------------------------------------------------
r46727 | jar@chromium.org | 2010-05-07 21:22:39 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Reduce inter-upload interval for UMA logs to 30 minutes

Reduce the rate at which we upload UMA stats.

r=laforge
Review URL: http://codereview.chromium.org/1999003
------------------------------------------------------------------------
r46724 | agl@chromium.org | 2010-05-07 20:54:50 +0200 (Fri, 07 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Don't try and adjust the oom_adj of renderers on SELinux systems.

https://bugzilla.redhat.com/show_bug.cgi?id=581256

The SELinux policy doesn't let chrome_sandbox touch other processes' oom_adj
and we're spamming the log.

(See comments in the patch for details)

http://codereview.chromium.org/2005006/show
------------------------------------------------------------------------
r46723 | albertb@chromium.org | 2010-05-07 20:52:53 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   D /trunk/src/chrome/browser/sync/protocol/password_specifics.proto
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/chrome.gyp

Revert "Protocol extension for syncing passwords."

This reverts commit 4ab711db8ace2106fea6a95e12d2da6fbe4f78f7.

TBR=tommi

Review URL: http://codereview.chromium.org/2014004
------------------------------------------------------------------------
r46720 | albertb@chromium.org | 2010-05-07 20:36:18 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   A /trunk/src/chrome/browser/sync/protocol/password_specifics.proto
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/chrome.gyp

Protocol extension for syncing passwords.

BUG=34176
TEST=none

Review URL: http://codereview.chromium.org/1794009
------------------------------------------------------------------------
r46719 | jhawkins@chromium.org | 2010-05-07 20:35:46 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h

TTF: Re-enable coverage of ExpireHistoryTest.DeleteURLAndFavicon by marking it
flaky instead of disabled.  Add the corresponding bug to the comment.

BUG=43586
TEST=none

Review URL: http://codereview.chromium.org/1979004
------------------------------------------------------------------------
r46712 | tim@chromium.org | 2010-05-07 20:12:26 +0200 (Fri, 07 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

sync: only add to the dirty_metahandles index when marking an item dirty, rather than for every
item in a WriteTransaction originals array, and make sure to restore items into dirty_metahandles
on save changes failure to avoid data loss.

This prevents a situation where after a SaveChanges, a "clean" (not dirty) item will pass the
SafeToPurgeFromMemory filter because is_dirty is false, but it is in fact still in dirty_metahandles,
and we yank it from metahandles_index.  This causes a crash later on as GetByHandle will return NULL
for items in this boat.  The other part of this fix makes sure we don't lose a bookmark change on
browser restart due to a single sqlite operation failing during SaveChanges by restoring items into the 
dirty index.

BUG=43047,40341

Review URL: http://codereview.chromium.org/2043002
------------------------------------------------------------------------
r46711 | akalin@chromium.org | 2010-05-07 20:10:53 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

Added sync_tools.gyp to all.gyp.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/1735018
------------------------------------------------------------------------
r46705 | xiyuan@chromium.org | 2010-05-07 19:29:08 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Split BrowserTest.CommandCreateAppShortcut so that it does not flakily times out.

BUG=43434
TEST=Verify the splitted tests no longer flakily times out on try bots and build bots.

Review URL: http://codereview.chromium.org/2040003
------------------------------------------------------------------------
r46704 | jrg@chromium.org | 2010-05-07 19:27:29 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/test/functional/history.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Add an AddHistoryItem() API to PyAuto with example use.
Change GetHistory time value from int to float to keep precision.

BUG=none
TEST=run pyautolib

Review URL: http://codereview.chromium.org/2036004
------------------------------------------------------------------------
r46703 | jrg@chromium.org | 2010-05-07 19:25:57 +0200 (Fri, 07 May 2010) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Crashes, bookmark text, menu hiding.

Make sure "bookmarks go here" text goes away when adding the 1st
  bookmark (and comes back when deleting the last one).

When deleting the last item from an "off the side menu" (which would
  cause the "off the side" chevron button to go away), close that menu.

Make sure the "off the side" button is deleted in the autorelease
  pool, like all other buttons, in case "just one more" event is about to come in.  
  This is an attempt at fixing the top Mac browser crash.


BUG=43345,43501,43502

TEST=\
1)
New profile.
Open bookmark bar --> see "bookmarks go here"
Add bookmark --> text goes away
Delete bookmark --> text comes back.
2)
Add enough bookmarks so the "off the side" menu just barely appears.
Open the off the side menu, and right click --> delete the bookmark.
Expect to see the menu go away and the off-the-side button to go away.


Review URL: http://codereview.chromium.org/2025002
------------------------------------------------------------------------
r46702 | kkania@chromium.org | 2010-05-07 19:22:40 +0200 (Fri, 07 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h

[Linux] Fix race in ZygoteHost where socket read and writes were getting interleaved.
BUG=31737
TEST=none

Review URL: http://codereview.chromium.org/1921006
------------------------------------------------------------------------
r46701 | jhawkins@chromium.org | 2010-05-07 19:22:28 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

AutoFill: Parse the ignored fields at the end of ParseAddress, so we don't
accidentally match an ignored field instead of matching a field we care about.

BUG=43260
TEST=FormStructureTest.HeuristicsStateWithProvince

Review URL: http://codereview.chromium.org/2006005
------------------------------------------------------------------------
r46700 | agl@chromium.org | 2010-05-07 19:21:48 +0200 (Fri, 07 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc

Don't bother returning the directory descriptor for SQLite.

(Reviewed by dumi.)
------------------------------------------------------------------------
r46698 | jhawkins@chromium.org | 2010-05-07 19:14:34 +0200 (Fri, 07 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field_unittest.cc

AutoFill: Credit card filling fixes.
* Widen the regexp for Expiration Month.
* DCHECK that the number of fields matches between the FormStructure and the FormData results.
* Remove the awful N^2 loop that was too paranoid now that we verify the field counts are the same.

BUG=43365
TEST=CreditCardFieldTest.*,AutoFillManagerTest.*

Review URL: http://codereview.chromium.org/2048003
------------------------------------------------------------------------
r46697 | vangelis@chromium.org | 2010-05-07 19:10:46 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Adding a new IPC message to notify the browser process when a render widget is using the gpu process for painting its contents so that the browser will stop rendering from its own backing surface. This will currently only trigger if a page
uses the accelerated compositing path.
This patch can only land _after_ https://bugs.webkit.org/show_bug.cgi?id=38220

BUG=42677
TEST=NONE
Review URL: http://codereview.chromium.org/1696014
------------------------------------------------------------------------
r46696 | ctguil@chromium.org | 2010-05-07 19:04:57 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Add back comment explaining why kEnableRendererAccessibility is used.

This time reference the external bug number.

Bug=none
Test=none

------------------------------------------------------------------------
r46695 | viettrungluu@chromium.org | 2010-05-07 18:53:10 +0200 (Fri, 07 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm

Get rid of a couple more wstrings.

This one was really easy, since they weren't even used.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/2042004
------------------------------------------------------------------------
r46694 | sky@chromium.org | 2010-05-07 18:47:02 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Makes tab loading animation centered for bigger tab icons (as happens
with app tabs).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2043003
------------------------------------------------------------------------
r46693 | johnnyg@chromium.org | 2010-05-07 18:32:55 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/notification_1line.html
   M /trunk/src/chrome/browser/resources/notification_2line.html
   M /trunk/src/chrome/browser/resources/notification_icon.html

Leftover code review: move doctype to the right place.

BUG=none
TEST=none
TBR=arv

Review URL: http://codereview.chromium.org/1989006
------------------------------------------------------------------------
r46691 | phajdan.jr@chromium.org | 2010-05-07 18:19:07 +0200 (Fri, 07 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Disable SSLUITest.TestHTTPSExpiredCertAndDontProceed, it flakily
exceeds test timeout.

TBR=jcivelli

TEST=none
BUG=43575

Review URL: http://codereview.chromium.org/2019004
------------------------------------------------------------------------
r46690 | johnnyg@chromium.org | 2010-05-07 18:04:42 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/balloon_close.png
   M /trunk/src/chrome/app/theme/balloon_close_hover.png
   M /trunk/src/chrome/app/theme/balloon_frame.png
   M /trunk/src/chrome/app/theme/balloon_shelf.png
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/resources/notification_1line.html
   M /trunk/src/chrome/browser/resources/notification_2line.html
   M /trunk/src/chrome/browser/resources/notification_icon.html
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/views/painter.cc

New visuals for notifications on Windows.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1980005
------------------------------------------------------------------------
r46689 | jcivelli@google.com | 2010-05-07 18:00:55 +0200 (Fri, 07 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc

The wrong TabContents' delegate was being NULLed when the app launcher was
closed (the browser's current tab instead of the app launcher's one).
This was causing a crasher with the context menu and possibly way more
bad things.

BUG=43480
TEST=See bug
Review URL: http://codereview.chromium.org/1979002
------------------------------------------------------------------------
r46685 | bauerb@chromium.org | 2010-05-07 16:39:56 +0200 (Fri, 07 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Revert 46681 - Add AutomationMsg_WaitForDownloadShelfVisibilityChange and use it in UITestBase for the download tests.

This should decrease flakiness of download tests.

TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab*
BUG=43066

Review URL: http://codereview.chromium.org/1933005

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/2037003
------------------------------------------------------------------------
r46681 | bauerb@chromium.org | 2010-05-07 13:49:08 +0200 (Fri, 07 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add AutomationMsg_WaitForDownloadShelfVisibilityChange and use it in UITestBase for the download tests.

This should decrease flakiness of download tests.

TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab*
BUG=43066

Review URL: http://codereview.chromium.org/1933005
------------------------------------------------------------------------
r46680 | nkostylev@google.com | 2010-05-07 13:31:38 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   A /trunk/src/chrome/browser/chromeos/login/web_page_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/web_page_screen.h
   A /trunk/src/chrome/browser/chromeos/login/web_page_view.cc
   A /trunk/src/chrome/browser/chromeos/login/web_page_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor account creation screen.
Create set of interfaces/base classes for other screens that load web pages.

BUG=None
TEST=Open "Create account" screen. Loading spinner should be visible and page should render afterthat.

Review URL: http://codereview.chromium.org/1949002
------------------------------------------------------------------------
r46679 | yusukes@chromium.org | 2010-05-07 13:18:34 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Don't sync IME prefs that are not user-configurable.

BUG=chromium-os:3009
TEST=none

Review URL: http://codereview.chromium.org/2032007
------------------------------------------------------------------------
r46678 | yusukes@chromium.org | 2010-05-07 13:15:19 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Tiny cleanup. Removed unnecessary RebuildModel() calls.

BUG=none
TEST=manual.

Review URL: http://codereview.chromium.org/2028005
------------------------------------------------------------------------
r46672 | nkostylev@google.com | 2010-05-07 11:56:41 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Hiding status area on welcome screen.
Avoid confusion when network is connected.

BUG=http://crosbug.com/2322
TEST=Launch for the fist time (or just press Ctrl+Alt+N) and observe that status area is not shown. Status area is shown on other screens.

Review URL: http://codereview.chromium.org/1927002
------------------------------------------------------------------------
r46666 | aa@chromium.org | 2010-05-07 10:32:29 +0200 (Fri, 07 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc

Close NTP on app launch. I don't really like the way this feels, but figured others would want to try it.

cc'ing parties who said they wanted this ;)

Review URL: http://codereview.chromium.org/2016003
------------------------------------------------------------------------
r46663 | dpolukhin@chromium.org | 2010-05-07 09:12:43 +0200 (Fri, 07 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h

Put back info_bubble with left&right arrows.

Original CL: http://codereview.chromium.org/1820002

After submitting resources in separate CL, try servers pass on all platforms and locally tests all pass so submitting without any new changes.


BUG=crosbug.com/2800
TEST=Should be no visible changes with info bubble, everything should work as before.
TBR=pkasting

Review URL: http://codereview.chromium.org/2012003
------------------------------------------------------------------------
r46660 | yusukes@google.com | 2010-05-07 07:07:47 +0200 (Fri, 07 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

Tiny cleanup. Remove an obsolete TODO.

We'll add locale specific hot-keys like Kana, Eisu, .. to ibus engines, not to this file.

BUG=chromium-os:2543
TEST=none

Review URL: http://codereview.chromium.org/1997006
------------------------------------------------------------------------
r46655 | tfarina@chromium.org | 2010-05-07 04:55:16 +0200 (Fri, 07 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h

gtk: Make use of gtk signal macros in SelectionChange events.

BUG=None
TEST=manually

Patch from Thiago Farina <thiag.farina@gmail.com>

Review URL: http://codereview.chromium.org/1999004
------------------------------------------------------------------------
r46654 | sanjeevr@chromium.org | 2010-05-07 04:53:55 +0200 (Fri, 07 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   D /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   D /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   D /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc
   D /trunk/src/chrome/browser/sync/engine/net/http_return.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   D /trunk/src/chrome/browser/sync/util/signin.h
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/net/gaia
   A /trunk/src/chrome/common/net/gaia/gaia_authenticator.cc (from /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc:46543)
   A /trunk/src/chrome/common/net/gaia/gaia_authenticator.h (from /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h:46543)
   A /trunk/src/chrome/common/net/gaia/gaia_authenticator_unittest.cc (from /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc:46543)
   A /trunk/src/chrome/common/net/gaia/signin.h (from /trunk/src/chrome/browser/sync/util/signin.h:46408)
   A /trunk/src/chrome/common/net/http_return.h (from /trunk/src/chrome/browser/sync/engine/net/http_return.h:46408)
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.cc
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.h
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator_unittest.cc

Moved GaiaAuthenticator from chrome/browser/sync/engine/net to chrome/common/net/gaia.
BUG=None
TEST=None, no functional change.

Review URL: http://codereview.chromium.org/1998004
------------------------------------------------------------------------
r46653 | estade@chromium.org | 2010-05-07 04:07:59 +0200 (Fri, 07 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc

Fix unit test compile.

TBR=evan

Review URL: http://codereview.chromium.org/1992004
------------------------------------------------------------------------
r46652 | estade@chromium.org | 2010-05-07 03:40:52 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.h

More gtk signal handler macro conversion.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1981006
------------------------------------------------------------------------
r46650 | estade@chromium.org | 2010-05-07 03:04:20 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc

GTK: limit of one page info per URL.

BUG=41659
TEST=manual

Review URL: http://codereview.chromium.org/2010005
------------------------------------------------------------------------
r46645 | evan@chromium.org | 2010-05-07 02:57:27 +0200 (Fri, 07 May 2010) | 7 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/base/base_drop_target.h
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/webkit/tools/test_shell/drag_delegate.cc

Remove/update a bunch of references to the Google-internal bug tracker.

Many of our references turn out to just be context for a given workaround,
e.g. "Set the foobar here because the destructor dereferences it, see
http://private-bug-url".

Review URL: http://codereview.chromium.org/2004004
------------------------------------------------------------------------
r46644 | jrg@chromium.org | 2010-05-07 02:55:49 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm

Icon-only (titleless) bookmarks are squeezed closer.

BUG=42516
TEST=change some bookmark titles to "" and watch them get Kate Mossified.

Review URL: http://codereview.chromium.org/2045002
------------------------------------------------------------------------
r46643 | ananta@chromium.org | 2010-05-07 02:55:25 +0200 (Fri, 07 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc

Opening new chrome frame tabs would fail randomly. This was because of a race condition between processing the connect external
tab ack in chrome frame and receiving requests for the tab. As a result the new tabs would not render anything.

Fix is to resume the pending views in the OnReinitialize task in the ExternalTabContainer.

I also added a NOTREACHED when we fail to find the TabProxy for a tab handle in the chrome frame automation code to help
catch future instances of this issue.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=43376

Bug=43376

Review URL: http://codereview.chromium.org/2011006
------------------------------------------------------------------------
r46642 | zork@chromium.org | 2010-05-07 02:39:41 +0200 (Fri, 07 May 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   D /trunk/src/chrome/browser/browser_accessibility_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/third_party/iaccessible2
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h
   A /trunk/src/webkit/glue/webaccessibilitymanager.h (from /trunk/src/webkit/glue/webaccessibilitymanager.h:46566)
   M /trunk/src/webkit/glue/webkit_glue.gypi

Revert 46567 - Reimplement accessibility of web content by caching the entire 
accessibility tree in the browser process.

Adds new RPCs for a browser tab to request accessibility info from
a renderer; the renderer responds with a complete tree of
accessibility metadata for the entire DOM, which is then cached
in the RenderWidgetHostView. This part is crossplatform and will
help with accessibility on both Windows and Mac OS X.

For Windows, MSAA support for web content has been rewritten to
use this new cache. Tested in JAWS and NVDA screen readers.
Using Chrome with a screen reader is now fast and stable,
unlike the previous implementation. However, note that most
advanced functionality is still not supported, and much work remains
to make Chrome work well with a screen reader. This is a necessary
step to improve stability first.

BUG=25564
BUG=13291
TEST=See http://codereview.chromium.org/1806001

Review URL: http://codereview.chromium.org/1637018

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/2031004
------------------------------------------------------------------------
r46639 | cevans@chromium.org | 2010-05-07 01:11:30 +0200 (Fri, 07 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Handle CBF_SMBITMAP in the async version of the IPC.

BUG=43307
TEST=NONE

Review URL: http://codereview.chromium.org/1973002
------------------------------------------------------------------------
r46638 | zork@chromium.org | 2010-05-07 00:51:04 +0200 (Fri, 07 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_a.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_b.html

Revert 46592 - Disallow display of multiple experimental.extension.popup(...) windows.

Patch 1 contains twiz@'s code reviewed implementation from http://codereview.chromium.org/1512007.
This CL is to address the failure of release tests.

BUG=None 
TEST=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/1921003

TBR=ericdingle@google.com
Review URL: http://codereview.chromium.org/2036002
------------------------------------------------------------------------
r46637 | thestig@chromium.org | 2010-05-07 00:50:49 +0200 (Fri, 07 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Mark DevToolsSanityTest.TestStepIn as flaky on CrOS.

BUG=43479
TEST=none
Review URL: http://codereview.chromium.org/2013007
------------------------------------------------------------------------
r46636 | zork@chromium.org | 2010-05-07 00:48:02 +0200 (Fri, 07 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc

Revert 46611 - Quick fix to browser tests failure for http://codereview.chromium.org/1921003
Bug=none
Test=none

Review URL: http://codereview.chromium.org/2030004

TBR=ericdingle@google.com
Review URL: http://codereview.chromium.org/1981005
------------------------------------------------------------------------
r46635 | sanjeevr@chromium.org | 2010-05-07 00:32:35 +0200 (Fri, 07 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc

Changed URLFetcher unittests to use MessageLoopProxyImpl instead of ChromeThread.
BUG=None
TEST=URLFetcher unittests

Review URL: http://codereview.chromium.org/2006004
------------------------------------------------------------------------
r46634 | akalin@chromium.org | 2010-05-06 23:59:55 +0200 (Thu, 06 May 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread.cc
   D /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread.h
   D /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread_unittest.cc
   D /trunk/src/chrome/browser/sync/net/mock_network_change_observer.h
   D /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.cc
   D /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.h
   D /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy_unittest.cc
   D /trunk/src/chrome/browser/sync/net/network_change_notifier_thread.h
   D /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.cc
   D /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.h
   D /trunk/src/chrome/browser/sync/net/network_change_observer_proxy_unittest.cc
   D /trunk/src/chrome/browser/sync/net/thread_blocker.cc
   D /trunk/src/chrome/browser/sync/net/thread_blocker.h
   D /trunk/src/chrome/browser/sync/net/thread_blocker_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/net/fake_network_change_notifier_thread.cc (from /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread.cc:46603)
   A /trunk/src/chrome/common/net/fake_network_change_notifier_thread.h (from /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread.h:46603)
   A /trunk/src/chrome/common/net/fake_network_change_notifier_thread_unittest.cc (from /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread_unittest.cc:46603)
   A /trunk/src/chrome/common/net/mock_network_change_observer.h (from /trunk/src/chrome/browser/sync/net/mock_network_change_observer.h:46603)
   A /trunk/src/chrome/common/net/network_change_notifier_proxy.cc (from /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.cc:46603)
   A /trunk/src/chrome/common/net/network_change_notifier_proxy.h (from /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.h:46603)
   A /trunk/src/chrome/common/net/network_change_notifier_proxy_unittest.cc (from /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy_unittest.cc:46603)
   A /trunk/src/chrome/common/net/network_change_notifier_thread.h (from /trunk/src/chrome/browser/sync/net/network_change_notifier_thread.h:46603)
   A /trunk/src/chrome/common/net/network_change_observer_proxy.cc (from /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.cc:46603)
   A /trunk/src/chrome/common/net/network_change_observer_proxy.h (from /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.h:46603)
   A /trunk/src/chrome/common/net/network_change_observer_proxy_unittest.cc (from /trunk/src/chrome/browser/sync/net/network_change_observer_proxy_unittest.cc:46603)
   A /trunk/src/chrome/common/net/thread_blocker.cc (from /trunk/src/chrome/browser/sync/net/thread_blocker.cc:46603)
   A /trunk/src/chrome/common/net/thread_blocker.h (from /trunk/src/chrome/browser/sync/net/thread_blocker.h:46603)
   A /trunk/src/chrome/common/net/thread_blocker_unittest.cc (from /trunk/src/chrome/browser/sync/net/thread_blocker_unittest.cc:46603)
   D /trunk/src/chrome/common/net/url_util_unittest.cc

Moved everything in browser/sync/net to common/net.

This is so it can be used by both common/net/notifier and browser/sync.

Removed unused and rotted unittest file.

BUG=42606
TEST=trybots

Review URL: http://codereview.chromium.org/2022001
------------------------------------------------------------------------
r46632 | rohitrao@chromium.org | 2010-05-06 23:55:08 +0200 (Thu, 06 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Fixes janky animations in the omnibox popup.

BUG=None
TEST=Hold down 'a' in the omnibox.  The animation should be smooth and not flickery.
Review URL: http://codereview.chromium.org/2010002
------------------------------------------------------------------------
r46627 | xiyuan@chromium.org | 2010-05-06 23:17:42 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Use normal browser window as PageInfoView's parent rather than the popup browser window.

BUG=<http://crosbug.com/2783>
TEST=Verify fix for ChromeOS issue 2783.

Review URL: http://codereview.chromium.org/2007004
------------------------------------------------------------------------
r46626 | mrossetti@chromium.org | 2010-05-06 23:10:57 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Mousing over the bookmark bar now behaves properly when traversing a non-folder item; this would previously cause folder menus to discontinue appearing. Now once the bar folder menus are showing they will continue showing even when a non-folder bookmark bar item is traversed. Folder menus will discontinue showing when 1) a bar folder button is clicked, 2) a bookmark choice is made, 3) a click is made somewhere else in the browser window, 4) when the window loses focus, etc.

BUG=None
TEST=1) Mouse over the bar without clicking and verify that no folder menus appear. 2) Click on a folder button in the bar and verify that its folder menu appears. 3) Mouse over other folders in the bar and verify that the old menu closes and a new one opens. 4) Mouse over a non-folder button in the bar and verify that the old menu closes and another does not appear. 5) Mouse over a folder button and verify that the folder's menu appears. 6) Click on a folder button in the bar and verify that the menu closes. 7) Mouse over other folder buttons and verify no menu appears.

Review URL: http://codereview.chromium.org/1912008
------------------------------------------------------------------------
r46625 | jianli@chromium.org | 2010-05-06 23:08:59 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   A /trunk/src/webkit/glue/webfilesystem_impl.cc
   A /trunk/src/webkit/glue/webfilesystem_impl.h
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Add Chromium side implementation for WebFileSystem interface in WebKit.

BUG=none
TEST=non

Review URL: http://codereview.chromium.org/1748015
------------------------------------------------------------------------
r46624 | viettrungluu@chromium.org | 2010-05-06 23:06:48 +0200 (Thu, 06 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc

Get rid of some dead bookmark context menu code.

(Continuing fallout of native bookmark manager deletion.)

More refactoring still to come.

BUG=38908
TEST=bookmark bar context menu still works as before

Review URL: http://codereview.chromium.org/1986003
------------------------------------------------------------------------
r46622 | estade@chromium.org | 2010-05-06 23:00:46 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/views/window/window_delegate.cc
   M /trunk/src/views/window/window_delegate.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_win.cc

some more fixes for ignored scoped_ptr::release() calls

BUG=42904
TEST=bots

Review URL: http://codereview.chromium.org/1982001
------------------------------------------------------------------------
r46621 | xiyuan@chromium.org | 2010-05-06 23:00:40 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc

Use normal browser window as parent for extension prompt window.

BUG=<http://crosbug.com/1587>
TEST=Verify fix for ChromeOS issue 1587.

Review URL: http://codereview.chromium.org/2011001
------------------------------------------------------------------------
r46620 | xiyuan@chromium.org | 2010-05-06 22:57:54 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc

Host reset options dialog with NativeDialogHost on ChromeOS

BUG=none
TEST=Verify that "Reset to default" button on "Under the hook" options tab bring up the dialog in a Chrome window.

Review URL: http://codereview.chromium.org/1950002
------------------------------------------------------------------------
r46619 | xiyuan@chromium.org | 2010-05-06 22:56:36 +0200 (Thu, 06 May 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.cc
   M /trunk/src/chrome/browser/chromeos/native_dialog_window.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/js_modal_dialog_gtk.cc
   M /trunk/src/views/widget/widget_gtk.cc

Host cookie modal dialog and js modal modal dialog in NativeDialogHost

- Enable modal dialog in NativeDialogHost. This is not fully work in ChromeOS
  because e.g. user could still alt-tab away. However, setting modal would
  block user from interacting with relevant browser window and avoid crashes;
- Move dialog close code from NativeHostDialog's destructor to WindowClosing
  because a dialog's "response" signal handler could rely on the contents;
- Add "check-resize" signal handler to make GtkExpander work nicely with
  NativeDialogHost;
- Add ShowModalDialogWithMinLocalizedWidth to gtk_util for cookie and js
  modal dialog;
- Change in WidgetGtk::SetBounds to call gtk_window_move/resize always to
  keep GtkWindow's geometry info up-to-date;

BUG=none
TEST=Verify cookie prompt and js dialog on ChromeOS is hosted in a Chrome window and not occupy the whole screen.

Review URL: http://codereview.chromium.org/1995001
------------------------------------------------------------------------
r46618 | akalin@chromium.org | 2010-05-06 22:54:50 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/tools/DEPS
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

Implemented cache invalidation listener in sync_listen_notifications.

BUG=34645
TEST=manual

Review URL: http://codereview.chromium.org/1694023
------------------------------------------------------------------------
r46616 | viettrungluu@chromium.org | 2010-05-06 22:44:42 +0200 (Thu, 06 May 2010) | 11 lines
Changed paths:
   M /trunk/src/app/l10n_util_mac.h
   M /trunk/src/app/l10n_util_mac.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Mac: add a l10n_util::GetNSStringF() which gets offsets as well.

... and get rid of a wstring.

(More string16 versions of GetStringF() and corresponding versions
GetNSStringF() should be implemented.)

BUG=none
TEST=on a branded build (on Mac), in the about dialog, make sure the text is still correct and the links still work correctly

Review URL: http://codereview.chromium.org/2042002
------------------------------------------------------------------------
r46615 | dmazzoni@chromium.org | 2010-05-06 22:44:09 +0200 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Check for null pointer that can occur when tab is closed quickly after
opening. Fixes crash and fixes BrowserKeyEventsTest.ReservedAccelerators.

BUG=none
TEST=BrowserKeyEventsTest.ReservedAccelerators
TBR=sky

Review URL: http://codereview.chromium.org/2038002
------------------------------------------------------------------------
r46614 | evan@chromium.org | 2010-05-06 22:43:36 +0200 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc

Fix a possible crash introduced by r46412 by not accessing the result variable before the NULL check

BUG=43408
TEST=none

Patch by Benjamin Jemlich <pcgod99@gmail.com>.

Review URL: http://codereview.chromium.org/2035003
------------------------------------------------------------------------
r46612 | willchan@chromium.org | 2010-05-06 22:42:12 +0200 (Thu, 06 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/net/http/http_request_headers.cc
   M /trunk/src/net/http/http_request_headers.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc

Use net::HttpRequestHeaders instead of std::string in URLRequest and friends.
BUG=22588

Review URL: http://codereview.chromium.org/1998001
------------------------------------------------------------------------
r46611 | ericdingle@google.com | 2010-05-06 22:41:29 +0200 (Thu, 06 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc

Quick fix to browser tests failure for http://codereview.chromium.org/1921003
Bug=none
Test=none

Review URL: http://codereview.chromium.org/2030004
------------------------------------------------------------------------
r46601 | evan@chromium.org | 2010-05-06 21:22:23 +0200 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/app/gfx/gl/gl_context_linux.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_expanded_container.cc
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/ggl/ggl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/net/spdy/spdy_framer.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.cc

Fix NULL vs 0 problems which break the build with -Werror using GCC 4.5

BUG=none
TEST=try to compile with gcc 4.5

Patch by Benjamin Jemlich <pcgod99@gmail.com>.

Review URL: http://codereview.chromium.org/2007003
------------------------------------------------------------------------
r46598 | chocobo@chromium.org | 2010-05-06 20:59:25 +0200 (Thu, 06 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Refactor WifiNetwork, CellularNetwork, and EthernetNetwork into classes to make the code cleaner.
BUG=none
TEST=ran browser tests and also manually made sure everything still works.
Review URL: http://codereview.chromium.org/2010001
------------------------------------------------------------------------
r46592 | ericdingle@google.com | 2010-05-06 20:35:29 +0200 (Thu, 06 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_a.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_b.html

Disallow display of multiple experimental.extension.popup(...) windows.

Patch 1 contains twiz@'s code reviewed implementation from http://codereview.chromium.org/1512007.
This CL is to address the failure of release tests.

BUG=None 
TEST=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/1921003
------------------------------------------------------------------------
r46591 | sanjeevr@chromium.org | 2010-05-06 20:34:24 +0200 (Thu, 06 May 2010) | 5 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/message_loop_proxy.h
   A /trunk/src/base/message_loop_proxy_impl.cc
   A /trunk/src/base/message_loop_proxy_impl.h
   A /trunk/src/base/message_loop_proxy_impl_unittest.cc
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/chrome_plugin_unittest.cc
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/net/url_request_context_getter.cc
   M /trunk/src/chrome/browser/net/url_request_context_getter.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc

Created a stock implementation of the MessageLoopProxy interface than can be used to create an implementation that targets the current thread's message loop.
BUG=None
TEST=Unit tests provided.

Review URL: http://codereview.chromium.org/1837003
------------------------------------------------------------------------
r46589 | dpolukhin@chromium.org | 2010-05-06 20:25:05 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Fix crash in tab_contents_view_gtk.cc when delegate is NULL.

BUG=none
TEST=On Chrome OS open app launcher and set focus back to page by mouse click.

Review URL: http://codereview.chromium.org/2003003
------------------------------------------------------------------------
r46588 | jcivelli@google.com | 2010-05-06 20:23:24 +0200 (Thu, 06 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/common/view_types.cc
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/render_view.cc

The app launcher had a height of zero as it was not getting preferred size updates
notifications.
The wrong render was getting told to report preferred size updates.
We now make sure we enable preferred size notifications when the render view host is created.
Also removed a check for the view type in render_view.cc that was preventing us from
polling the preferred size for regular tabs. This check is not needed since the notifications
need to be explictly enabled and they are only enabled by extensions related render views (and
the app launcher).

TEST=Open the app launcher, it should display correctly.
BUG=None

Review URL: http://codereview.chromium.org/1989002
------------------------------------------------------------------------
r46587 | phajdan.jr@chromium.org | 2010-05-06 19:55:04 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui_browsertest.cc

Mark ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToDefault as flaky.

TBR=bulach

TEST=none
BUG=43441
Review URL: http://codereview.chromium.org/1998005
------------------------------------------------------------------------
r46586 | phajdan.jr@chromium.org | 2010-05-06 19:46:47 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Disable ExtensionApiTest.Tabs, it flakily exceeds test timeout.

TBR=skerner

TEST=none
BUG=43440
Review URL: http://codereview.chromium.org/1988004
------------------------------------------------------------------------
r46580 | phajdan.jr@chromium.org | 2010-05-06 19:39:00 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Disable SSLUITest.TestUnauthenticatedFrameNavigation, it flakily exceeds test timeout.

TBR=sky

TEST=none
BUG=43437
Review URL: http://codereview.chromium.org/2040002
------------------------------------------------------------------------
r46578 | phajdan.jr@chromium.org | 2010-05-06 19:16:45 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disable BrowserTest.CommandCreateAppShortcut, it flakily times out.

TBR=xiyuan

TEST=none
BUG=43434
Review URL: http://codereview.chromium.org/2035005
------------------------------------------------------------------------
r46577 | tommi@chromium.org | 2010-05-06 19:12:29 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Changing a NOTREACHED to a DLOG(ERROR) since we hit this when running the net tests with chrome frame.
See revision 42240 for more details: http://codereview.chromium.org/1107013

TEST=n/a
BUG=none

Review URL: http://codereview.chromium.org/1987001
------------------------------------------------------------------------
r46576 | aa@chromium.org | 2010-05-06 19:03:08 +0200 (Thu, 06 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Rename all occurrences of "app extension" with "extension app" since we were using both and consistency is nice.

Review URL: http://codereview.chromium.org/1924002
------------------------------------------------------------------------
r46575 | davemoore@chromium.org | 2010-05-06 18:55:31 +0200 (Thu, 06 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc

Allows browser tests to run with recent change
http://codereview.chromium.org/2003001 broke browser tests for
login / wizard screens. This fixes them.

Review URL: http://codereview.chromium.org/1995005
------------------------------------------------------------------------
r46574 | dmazzoni@chromium.org | 2010-05-06 18:54:23 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_win_browsertest.cc

Add debugging statement and mark recently-added test as flaky
until we figure out the reason for the failure.
BUG=none
TEST=none
TBR=ctguil@chromium.org

Review URL: http://codereview.chromium.org/2004002
------------------------------------------------------------------------
r46571 | mrossetti@chromium.org | 2010-05-06 17:44:16 +0200 (Thu, 06 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Removed drek left over from an earlier expirement.

BUG=None
TEST=None

------------------------------------------------------------------------
r46570 | mrossetti@chromium.org | 2010-05-06 17:42:11 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

The button was being told to highlight but then it was not being told it needed to be redrawn.

BUG=43225
TEST=Drag a bookmark into a bar folder and then a subfolder and verify that the buttons in the path to the open subfolder are all highlighted.

Review URL: http://codereview.chromium.org/2006001
------------------------------------------------------------------------
r46567 | dmazzoni@chromium.org | 2010-05-06 16:49:40 +0200 (Thu, 06 May 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   A /trunk/src/chrome/browser/browser_accessibility_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/render_messages_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/third_party/iaccessible2
   A /trunk/src/third_party/iaccessible2/ia2_api_all.idl
   A /trunk/src/third_party/iaccessible2/iaccessible2.gyp
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h
   D /trunk/src/webkit/glue/webaccessibilitymanager.h
   M /trunk/src/webkit/glue/webkit_glue.gypi

Reimplement accessibility of web content by caching the entire 
accessibility tree in the browser process.

Adds new RPCs for a browser tab to request accessibility info from
a renderer; the renderer responds with a complete tree of
accessibility metadata for the entire DOM, which is then cached
in the RenderWidgetHostView. This part is cross-platform and will
help with accessibility on both Windows and Mac OS X.

For Windows, MSAA support for web content has been rewritten to
use this new cache. Tested in JAWS and NVDA screen readers.
Using Chrome with a screen reader is now fast and stable,
unlike the previous implementation. However, note that most
advanced functionality is still not supported, and much work remains
to make Chrome work well with a screen reader. This is a necessary
step to improve stability first.

BUG=25564
BUG=13291
TEST=See http://codereview.chromium.org/1806001

Review URL: http://codereview.chromium.org/1637018
------------------------------------------------------------------------
r46565 | dpolukhin@chromium.org | 2010-05-06 15:38:19 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h

Rollback http://codereview.chromium.org/1820002

BUG=crosbug.com/2800
TEST=none

Review URL: http://codereview.chromium.org/2003004
------------------------------------------------------------------------
r46564 | dpolukhin@chromium.org | 2010-05-06 14:36:01 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/bubble_l_arrow.png
   A /trunk/src/chrome/app/theme/bubble_r_arrow.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.cc
   M /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h

Add ability to place bubble arrow on left and right side of the bubble or make it float with top edge.

BUG=crosbug.com/2800
TEST=Should be no visible changes with info bubble, everything should work as before. Bubble is used for example in bookmarking.

Review URL: http://codereview.chromium.org/1820002
------------------------------------------------------------------------
r46560 | yusukes@chromium.org | 2010-05-06 13:06:12 +0200 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Add some defensive checks.

Added code that detects array out-of-bounds errors. This should help to debug regressions like http://code.google.com/p/chromium-os/issues/detail?id=2878#c11 .

BUG=chromium-os:2878
TEST=see the bug 2878. confirmed that with this change, chrome does not crash.

Review URL: http://codereview.chromium.org/2018002
------------------------------------------------------------------------
r46559 | pfeldman@chromium.org | 2010-05-06 12:10:56 +0200 (Thu, 06 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

DevTools: keep manual docked state update until corresponding webkit change lands.

Review URL: http://codereview.chromium.org/2036001
------------------------------------------------------------------------
r46555 | pfeldman@chromium.org | 2010-05-06 11:56:58 +0200 (Thu, 06 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h

DevTools: inspector tabs are initially drawn in the undocked style even for docked inspectors
BUG=40804

Review URL: http://codereview.chromium.org/2009002
------------------------------------------------------------------------
r46553 | nirnimesh@chromium.org | 2010-05-06 10:17:05 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   A /trunk/src/chrome/test/functional/plugins.py
   A /trunk/src/chrome/test/pyautolib/plugins_info.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Add hooks to fetch about:plugins info for PyAuto.

Also, hooks for to enable/disable a plugin.
Add a test which excercises them.

Review URL: http://codereview.chromium.org/1935003
------------------------------------------------------------------------
r46552 | jcivelli@chromium.org | 2010-05-06 06:37:56 +0200 (Thu, 06 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

A var was not initialized.

Original review:
http://codereview.chromium.org/2016001/show
 
BUG=None
TEST=Valgrind bots should be green.

Review URL: http://codereview.chromium.org/2025001
------------------------------------------------------------------------
r46551 | jcivelli@chromium.org | 2010-05-06 06:32:58 +0200 (Thu, 06 May 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc

Fix a crasher withe the AppLauncher on Linux.
On Linux, the WidgetGTK destruction is asynchronous.
The AppLauncher is deleted when the bubble is closing,
but the bubble is deleted when the WidgetGtk is destroyed.
So the bubble (and its DOMUI) is going away after the app launcher.
Since the app launcher is the TabContentsDelegate of the bubble tab,
the deleted app launcher could still be notified.
This CL ensures we NULL the TabContents' delegate when the AppLauncher
is deleted so it is not accessed.

Original review:
http://codereview.chromium.org/1985003/show

BUG=3068
TEST=On ChromeOS, open the app launcher and close it while it is loading.
Try several times, it should not crash. 
Review URL: http://codereview.chromium.org/1996005
------------------------------------------------------------------------
r46544 | rafaelw@chromium.org | 2010-05-06 05:00:40 +0200 (Thu, 06 May 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   A /trunk/src/chrome/browser/tab_contents/background_contents.cc
   A /trunk/src/chrome/browser/tab_contents/background_contents.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Initial support for web-extent background pages.

This patch adds a new RVH container: BackgroundContents. The idea is that apps can open a live web-page as a "background" page using window.open('<url>', '<name>', 'background');

If 'background' is specified and the opener is within the app's extent, a BackgroundContents will be used. Otherwise, the 'background' feature is ignored and it is treated as a regular popup call.

Note that as of this patch the following are explicitly not-yet addressed:

1) Session storage for BackgroundContents
2) SSL (or other failures) requiring UI
3) Javascript messages (alert, etc...)
4) Session restore

TEST=All tests should pass
BUG=41275

Review URL: http://codereview.chromium.org/1734014
------------------------------------------------------------------------
r46543 | sanjeevr@chromium.org | 2010-05-06 04:45:20 +0200 (Thu, 06 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc

Removed some dependencies on sync from GaiaAuthenticator so that it can be moved to common.
BUG=None
TEST=Test Bookmarks Sync

Review URL: http://codereview.chromium.org/1964005
------------------------------------------------------------------------
r46541 | mark@chromium.org | 2010-05-06 04:39:12 +0200 (Thu, 06 May 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/platform_util_mac.mm

Branded stable channel builds should not display any text after the version
number in the About window or about:version.

The existing code assumed that KSChannelID would be set to "stable" on the
stable channel, but this is incorrect. On the stable channel, KSChannelID is
not set at all.

Originally, the code was correct, but it broke in r36375.

BUG=43357
TEST=1. Check the About window in a stable-channel build. It should show the
        version number without being adorned by the word "unknown" or any
        other text.
     2. In the same stable-channel builds, visit about:version. The Google
        Chrome line should show something like 5.0.375.29 (Official Build
        46008) without the word "unknown" or any other text.
Review URL: http://codereview.chromium.org/1990002
------------------------------------------------------------------------
r46539 | scherkus@chromium.org | 2010-05-06 03:44:48 +0200 (Thu, 06 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Tweak the chat manager ifdef condition.

BUG=none
TEST=none
------------------------------------------------------------------------
r46536 | arv@chromium.org | 2010-05-06 02:59:26 +0200 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Bounce the app icon after it is installed.

This also has a small fix to the shrink wrap CSS for the launcher.

BUG=None
TEST=Install an app, the launcher should show up and the icon should bounce.

Review URL: http://codereview.chromium.org/2014001
------------------------------------------------------------------------
r46535 | eroman@chromium.org | 2010-05-06 02:56:48 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Add an UMA histogram that counts the types of network error codes that main frame page loads fail with:

   Net.ErrorCodesForMainFrame

BUG=41811

Review URL: http://codereview.chromium.org/1568024
------------------------------------------------------------------------
r46534 | jhawkins@chromium.org | 2010-05-06 02:51:44 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

gtk: Use the new ShowAutoFillDialog interface to load imported profiles/CCs in
the AutoFill dialog.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1988003
------------------------------------------------------------------------
r46530 | jhawkins@chromium.org | 2010-05-06 02:22:33 +0200 (Thu, 06 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download.cc
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h

AutoFill: Clean up the server response handling code.
* Move the server response handler to FormStructure.
* Update the |autofill_count_| when we receive server data.

TBR=georgey (vacation)
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1965002
------------------------------------------------------------------------
r46527 | arv@chromium.org | 2010-05-06 02:10:55 +0200 (Thu, 06 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/ntp/most_visited.css

NTP: Fix issue where we have a visual glitch when hovering the thumbnails

We need to set the transition for border-top-left-radius as well
border-top-right-radius. Setting the transition to border-radius is not
sufficient.

BUG=43092
TEST=Hover the thumbnails on the most visited section. There should be no gaps in the upper corners.

Review URL: http://codereview.chromium.org/1994001
------------------------------------------------------------------------
r46526 | davemoore@chromium.org | 2010-05-06 01:50:16 +0200 (Thu, 06 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   M /trunk/src/chrome/browser/chromeos/boot_times_loader.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Add time for when chrome's main() is called.
Also output chrome's time to launch on the login screen.

Review URL: http://codereview.chromium.org/2003001
------------------------------------------------------------------------
r46524 | akalin@chromium.org | 2010-05-06 01:44:06 +0200 (Thu, 06 May 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread.cc
   A /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread.h
   A /trunk/src/chrome/browser/sync/net/fake_network_change_notifier_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.cc
   M /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.h
   M /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy_unittest.cc
   A /trunk/src/chrome/browser/sync/net/network_change_notifier_thread.h
   M /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.cc
   M /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.h
   M /trunk/src/chrome/browser/sync/net/network_change_observer_proxy_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Added NetworkChangeNotifierThread interface.

Also made NetworkChange{Observer,Notifier}Proxy use it instead of
managing the source message loop and NetworkChangeNotifier themselves.

BUG=42606
TEST=unit tests

Review URL: http://codereview.chromium.org/1973001
------------------------------------------------------------------------
r46521 | eroman@chromium.org | 2010-05-06 01:25:29 +0200 (Thu, 06 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/connection_tester_unittest.cc
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest.txt

Fix a unit-test that was crashing on valgrind bot.

The problem is that ClientSocketPoolBaseHelper holds a pointer to a task, and tries to call a method on that pointer during destruction.
However, if destruction of ClientSocketPoolBaseHelper occurs during message loop destruction, then pending tasks are deleted, so this "backup_task" pointer that it accesses may be invalid.

I worked around the problem here by avoiding this destruction code-path in the unit-test. It would be good to make ClientSocketPoolBaseHelper able to handle this case though.

BUG=43291

Review URL: http://codereview.chromium.org/1920003
------------------------------------------------------------------------
r46519 | jhawkins@chromium.org | 2010-05-06 01:19:42 +0200 (Thu, 06 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

AutoFill: Use PrefService::FindPreference instead of PrefService::HasPrefPath.
HasPrefPath will crash if the preference is not registered.

BUG=42358
TEST=none

Review URL: http://codereview.chromium.org/2007002
------------------------------------------------------------------------
r46517 | sky@chromium.org | 2010-05-06 01:13:32 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h

Changes DraggedTabController to operate on a View instead of a Tab.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1905005
------------------------------------------------------------------------
r46516 | stuartmorgan@chromium.org | 2010-05-06 01:10:31 +0200 (Thu, 06 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_impl.cc

Update Mac plugins for SetFocus changes, and remove old workaround messages

Now that WebKit is sending unfocus events, rework Mac plugins to correctly track plugin focus as a function of WebKit element focus and window-level view focus. Remove message plumbing for the old workarounds that were used to partially simulate focus switching for Mac plugins.

Windows and Linux will currently ignore the new focus loss notifications so their behavior is unchanged.

BUG=32721
TEST=Mac plugins should stop reacting to keyboard events once another control on the page, or the omnibox, is focused. They should also regain keyboard focus when switching back to their tab if they had it when the tab was hidden.

Review URL: http://codereview.chromium.org/1736007
------------------------------------------------------------------------
r46515 | skerner@chromium.org | 2010-05-06 01:07:27 +0200 (Thu, 06 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

When an app window gets a new tab, show the window.

BUG=43126
TEST=none

Review URL: http://codereview.chromium.org/1999001
------------------------------------------------------------------------
r46512 | tommi@chromium.org | 2010-05-06 00:49:26 +0200 (Thu, 06 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager.h

Make the other GetProfile() method public.

The way the default profiles, extensions and services are initialized has changed in a way that makes it hard or even impossible to tweak profile preferences before extensions are initialized.  For example SafeWeb is initialized as part of referencing the default profile. Upon being initialized, it refers back to the default profile and its preferences (that are currently being constructed), so there's no 'public' way of fetching the default profile, tweak preferences and and _then_ initialize services.  However, by allowing calls to GetProfile(path, init_extensions), we can again do two phased profile/extension initialization as we used to.
Note that GetProfile(path) is already public.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1986001
------------------------------------------------------------------------
r46511 | viettrungluu@chromium.org | 2010-05-06 00:47:27 +0200 (Thu, 06 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Make disabled internal plugins stay disabled even when the version of Chrome changes.

This change is a bit hacky, but the proper change is to re-factor the plugins
stuff (and such a change wouldn't be M5-able).

BUG=42393
TEST=On Chrome with this CL, disable internal Flash. Update Chrome to a newer version (also with this CL). Check that internal Flash remains disabled. (Or hack the prefs file to test manually....)

Review URL: http://codereview.chromium.org/1969007
------------------------------------------------------------------------
r46510 | sky@chromium.org | 2010-05-06 00:43:22 +0200 (Thu, 06 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

Second attempt at fix for Browser::AddTabWithURL. My first fix fixed
the crash, but I don't think it was really what you were after. I
believe this is it.

I've changed various places in Browser to use CanSupportWindowFeature
rather than SupportsWindowFeature. This gives us the old behavior while
allowing app windows to have tabs, which I believe is what you wanted.

BUG=42914
TEST=see bug

Review URL: http://codereview.chromium.org/1932005
------------------------------------------------------------------------
r46507 | mattm@chromium.org | 2010-05-06 00:38:13 +0200 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc

gtk: Make use of gtk signal macros in AddLanguageDialog.

BUG=None
TEST=manually

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1903002
------------------------------------------------------------------------
r46506 | gspencer@chromium.org | 2010-05-06 00:29:49 +0200 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc

This filters out all of the non-toplevel windows from the browser list
so that they don't produce snapshots for overview mode.

This also fixes the bug below.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=3064
TEST=ran chrome with window manager
Review URL: http://codereview.chromium.org/1907001
------------------------------------------------------------------------
r46497 | aa@chromium.org | 2010-05-05 23:28:10 +0200 (Wed, 05 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/browser/resources/new_new_tab.html

Make the default launch container always be a tab. I think this
is less confusing for users and the app tab is currently better,
anyway.

Review URL: http://codereview.chromium.org/1914001
------------------------------------------------------------------------
r46496 | erg@chromium.org | 2010-05-05 23:28:06 +0200 (Wed, 05 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix popups from onunload handlers.

These popups should be checked against the page that created them and not the
page that we're currently navigating to.

BUG=40718
TEST=none

Review URL: http://codereview.chromium.org/1906007
------------------------------------------------------------------------
r46491 | pkasting@chromium.org | 2010-05-05 23:06:11 +0200 (Wed, 05 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Fix RTL-mode display of table of URLs to load on startup.  The table itself should still be mirrored (items are laid out right-to-left), we just want to mark the text contents as LTR (since they're URLs).

BUG=7215
TEST=In Hebrew UI, go to first page of options and add URLs to table of URLs to load on startup.  Check that they're laid out right-to-left with favicon first, but actual URLs are still drawn LTR.
Review URL: http://codereview.chromium.org/1962004
------------------------------------------------------------------------
r46485 | sky@chromium.org | 2010-05-05 22:02:18 +0200 (Wed, 05 May 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/multi_animation.cc
   A /trunk/src/app/multi_animation.h
   A /trunk/src/app/multi_animation_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Changes the mini tab title animation.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1902005
------------------------------------------------------------------------
r46482 | jcivelli@google.com | 2010-05-05 21:58:07 +0200 (Wed, 05 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   M /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h
   M /trunk/src/chrome/renderer/render_view.cc

Make the app launcher bubble fit its contents.
It remains at least as wide as the browser location bar (that way it can always point at the + button).

InfoBubble was modified so it can be resized.

BUG=42260
TEST=Open the app launcher multiple-times. The app launcher
     should fit its contents nicely.

Review URL: http://codereview.chromium.org/1739020
------------------------------------------------------------------------
r46480 | mark@chromium.org | 2010-05-05 21:57:24 +0200 (Wed, 05 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Remove NOTIMPLEMENTED log spew for BrowserWindowCocoa::ShelfVisibilityChanged().

BUG=43196
TEST=Spew gone.
Review URL: http://codereview.chromium.org/1960002
------------------------------------------------------------------------
r46477 | mark@chromium.org | 2010-05-05 21:46:26 +0200 (Wed, 05 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc

Fix bustage after:

r46472 | aa@chromium.org | 2010-05-05 14:47:30 -0400 (Wed, 05 May 2010)

BUG=none
TEST=green
TBR=aa
Review URL: http://codereview.chromium.org/1965004
------------------------------------------------------------------------
r46475 | arv@chromium.org | 2010-05-05 21:00:46 +0200 (Wed, 05 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Tabbed Bookmark Manager: match the context menu items with the bookmarks bar.

BUG=None
TEST=right click on a bookmark in the bookmarks bar (see the order of items),
right click on a bookmark in the bookmark manager (see the order).
They should match.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1843001
------------------------------------------------------------------------
r46472 | aa@chromium.org | 2010-05-05 20:47:30 +0200 (Wed, 05 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/url_constants.cc

Tell the app launcher about any newly installed apps. This is intended to be used for a nice animation.

Review URL: http://codereview.chromium.org/1906004
------------------------------------------------------------------------
r46470 | phajdan.jr@chromium.org | 2010-05-05 20:46:07 +0200 (Wed, 05 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Remove the flaky mark from ErrorPage tests. Apparently
the tests are no longer flaky on the buildbots.

TEST=ErrorPageTest.*
BUG=22877
Review URL: http://codereview.chromium.org/1951007
------------------------------------------------------------------------
r46458 | thomasvl@chromium.org | 2010-05-05 14:48:02 +0200 (Wed, 05 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm

Ensure the directory for the brand file exists before trying to write to it.

BUG=42988
TEST=see bug
Review URL: http://codereview.chromium.org/1903004
------------------------------------------------------------------------
r46445 | oshima@chromium.org | 2010-05-05 10:11:42 +0200 (Wed, 05 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc

temprarily commented out the dcheck that is causing try bot failures.
This is trybot only issue because build bot builds release binary.

TBR=derat@chromium.org
BUG=http://crosbug.com/3064
TEST=trybot should pass for changes that should pass.

Review URL: http://codereview.chromium.org/1919003
------------------------------------------------------------------------
r46442 | oshima@chromium.org | 2010-05-05 09:18:27 +0200 (Wed, 05 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   A /trunk/src/chrome/browser/chromeos/login/screen_lock_view.cc
   A /trunk/src/chrome/browser/chromeos/login/screen_lock_view.h
   A /trunk/src/chrome/browser/chromeos/login/screen_locker.cc
   A /trunk/src/chrome/browser/chromeos/login/screen_locker.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/chrome_browser.gypi

Screen Locker: 1st step
 * ScreenLocker screen currently reuses Background from Login screen.
 * GrabWidget is created to grab keyboard/mouse events.
 * Modified StubAuthentiator to fail when an empty password is entered.
 * Changed UserManager to explicitly remember the currently logged in user.
UI is not hooked yet.

BUG=43131, http://crosbug.com/2914
TEST=none

Review URL: http://codereview.chromium.org/1897001
------------------------------------------------------------------------
r46438 | skrul@chromium.org | 2010-05-05 06:13:24 +0200 (Wed, 05 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_data_service_test_util.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_unittest.cc

Add integration test for autofill profiles.
I also expanded on the orignial autofill "steady" test to include removals.  Plus a little refactoring of the WDS test.

Review URL: http://codereview.chromium.org/1963001
------------------------------------------------------------------------
r46434 | estade@chromium.org | 2010-05-05 05:55:45 +0200 (Wed, 05 May 2010) | 9 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

Add icons to SimpleMenuModel.

Also get rid of one of the MenuGtk constructors (now down to 2).
Also, stamp out one more use of MenuGtk::Delegate as a controller class.

BUG=31365
TEST=manual (in debug mode) + trybots

Review URL: http://codereview.chromium.org/1915004
------------------------------------------------------------------------
r46433 | sky@chromium.org | 2010-05-05 05:43:55 +0200 (Wed, 05 May 2010) | 8 lines
Changed paths:
   M /trunk/src/app/animation.cc
   M /trunk/src/app/animation.h
   M /trunk/src/app/animation_container.cc
   M /trunk/src/app/animation_container.h
   M /trunk/src/app/animation_container_unittest.cc
   M /trunk/src/app/animation_unittest.cc
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/linear_animation.cc
   A /trunk/src/app/linear_animation.h
   M /trunk/src/app/slide_animation.cc
   M /trunk/src/app/slide_animation.h
   M /trunk/src/app/test_animation_delegate.h
   M /trunk/src/app/throb_animation.cc
   A /trunk/src/app/tween.cc
   A /trunk/src/app/tween.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_started_animation_gtk.cc
   M /trunk/src/chrome/browser/gtk/hover_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/animation/bounds_animator.cc
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/text_button.cc

Refactors animation to allow for cleaner subclassing. I'm doing this
for creating a different animation subclass (which you'll see
shortly).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1961001
------------------------------------------------------------------------
r46430 | dhollowa@chromium.org | 2010-05-05 04:47:37 +0200 (Wed, 05 May 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

AutoFill profile shouldn't be saved when cancelled during initial setup.

Relanding after revert of: 46424
http://codereview.chromium.org/1902003
Fixing compile error on Windows.

For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted()
call now passes the new profile and credit card information to the dialog directly
instead of saving it to the database and then invoking the dialog.  This facilitates
"Cancel" in the dialog where the new information is not persisted.

This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic
out of the preferences dialog and into the AutoFillDialogController itself.

This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog()
call.  More work is required on Linux and Windows to properly conform to this interface and
fix bug 41010.  The Linux and Windows implementations will need to respect the new input
parameters |imported_profile| and |imported_credit_card|.

BUG=41010
TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters

Review URL: http://codereview.chromium.org/1952002
------------------------------------------------------------------------
r46429 | kkania@chromium.org | 2010-05-05 04:41:38 +0200 (Wed, 05 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/common/notification_type.h

Revert 46384 - Fix race in zygote_host_linux where socket was being read from and written to on different threads.

Made ZygoteHost methods all run on PROCESS_LAUNCHER thread. PostTask in linux from UI thread to PROCESS_LAUNCHER thread for DidProcessCrash. Changed DidProcessCrash to answer via a callback, which occurs asynchronously on linux. Rework cases in nacl_host, browser_render_process_host, and child_process_host where this method was being called to fit the callback model.

BUG=31737
TEST=none

Review URL: http://codereview.chromium.org/1695026

TBR=kkania@chromium.org
Review URL: http://codereview.chromium.org/1933007
------------------------------------------------------------------------
r46427 | pkasting@chromium.org | 2010-05-05 03:39:56 +0200 (Wed, 05 May 2010) | 5 lines
Changed paths:
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/views/controls/label.cc

Use GetDisplayStringInLTRDirectionality() in more places to simplify code.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1928004
------------------------------------------------------------------------
r46426 | dhollowa@chromium.org | 2010-05-05 03:15:15 +0200 (Wed, 05 May 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

Revert 46424 - AutoFill profile shouldn't be saved when cancelled during initial setup.

For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted()
call now passes the new profile and credit card information to the dialog directly
instead of saving it to the database and then invoking the dialog.  This facilitates
"Cancel" in the dialog where the new information is not persisted.

This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic
out of the preferences dialog and into the AutoFillDialogController itself.

This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog()
call.  More work is required on Linux and Windows to properly conform to this interface and
fix bug 41010.  The Linux and Windows implementations will need to respect the new input
parameters |imported_profile| and |imported_credit_card|.

BUG=41010
TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters

Review URL: http://codereview.chromium.org/1930002

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/1902003
------------------------------------------------------------------------
r46424 | dhollowa@chromium.org | 2010-05-05 02:56:17 +0200 (Wed, 05 May 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

AutoFill profile shouldn't be saved when cancelled during initial setup.

For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted()
call now passes the new profile and credit card information to the dialog directly
instead of saving it to the database and then invoking the dialog.  This facilitates
"Cancel" in the dialog where the new information is not persisted.

This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic
out of the preferences dialog and into the AutoFillDialogController itself.

This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog()
call.  More work is required on Linux and Windows to properly conform to this interface and
fix bug 41010.  The Linux and Windows implementations will need to respect the new input
parameters |imported_profile| and |imported_credit_card|.

BUG=41010
TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters

Review URL: http://codereview.chromium.org/1930002
------------------------------------------------------------------------
r46423 | erg@chromium.org | 2010-05-05 02:47:45 +0200 (Wed, 05 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

GTK: More signal overhaul.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1920002
------------------------------------------------------------------------
r46422 | evan@chromium.org | 2010-05-05 02:43:22 +0200 (Wed, 05 May 2010) | 6 lines
Changed paths:
   M /trunk/src/app/x11_util.cc
   M /trunk/src/base/bzip2_error_handler.cc
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/thread_local_win.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/net/proxy/init_proxy_resolver_unittest.cc

Replace CHECK(false) by LOG(FATAL) where appropriate.

The difference is that the error message doesn't contain
"Assertion failed: false".

Review URL: http://codereview.chromium.org/1970001
------------------------------------------------------------------------
r46419 | pkasting@chromium.org | 2010-05-05 02:24:20 +0200 (Wed, 05 May 2010) | 5 lines
Changed paths:
   M /trunk/src/base/i18n/rtl.cc
   M /trunk/src/base/i18n/rtl.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/gfx/canvas.h
   M /trunk/src/gfx/canvas_win.cc

Small cleanups/style fixes.  Simplifies RTL functions slightly.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1932006
------------------------------------------------------------------------
r46416 | dantasse@chromium.org | 2010-05-05 01:58:45 +0200 (Wed, 05 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

so it fits the "customize sync" text in all languages.

BUG=42769
TEST=click "set up sync" in chrome in any language, make sure the "customize sync" text fits inside the button.

For a screenshot of how it'll look: http://chromium.googlecode.com/issues/attachment?aid=-4915103749708609065&name=customize_sync_button.jpg&token=1393e02a3f3cd5e36e332205f24bf6d1&inline=1

Review URL: http://codereview.chromium.org/1712022
------------------------------------------------------------------------
r46413 | sanjeevr@chromium.org | 2010-05-05 01:46:46 +0200 (Wed, 05 May 2010) | 5 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   D /trunk/src/chrome/browser/sync/notifier
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/net/notifier (from /trunk/src/chrome/browser/sync/notifier:46353)
   M /trunk/src/chrome/common/net/notifier/base/async_dns_lookup.cc
   M /trunk/src/chrome/common/net/notifier/base/async_dns_lookup.h
   M /trunk/src/chrome/common/net/notifier/base/async_network_alive.h
   M /trunk/src/chrome/common/net/notifier/base/fastalloc.h
   M /trunk/src/chrome/common/net/notifier/base/linux/async_network_alive_linux.cc
   M /trunk/src/chrome/common/net/notifier/base/mac/network_status_detector_task_mac.cc
   M /trunk/src/chrome/common/net/notifier/base/mac/network_status_detector_task_mac.h
   M /trunk/src/chrome/common/net/notifier/base/mac/network_status_detector_task_mac_unittest.cc
   M /trunk/src/chrome/common/net/notifier/base/nethelpers.cc
   M /trunk/src/chrome/common/net/notifier/base/nethelpers.h
   M /trunk/src/chrome/common/net/notifier/base/network_status_detector_task.cc
   M /trunk/src/chrome/common/net/notifier/base/network_status_detector_task.h
   M /trunk/src/chrome/common/net/notifier/base/network_status_detector_task_mt.cc
   M /trunk/src/chrome/common/net/notifier/base/network_status_detector_task_mt.h
   M /trunk/src/chrome/common/net/notifier/base/posix/time_posix.cc
   M /trunk/src/chrome/common/net/notifier/base/signal_thread_task.h
   M /trunk/src/chrome/common/net/notifier/base/sigslotrepeater.h
   M /trunk/src/chrome/common/net/notifier/base/ssl_adapter.cc
   M /trunk/src/chrome/common/net/notifier/base/ssl_adapter.h
   M /trunk/src/chrome/common/net/notifier/base/static_assert.h
   M /trunk/src/chrome/common/net/notifier/base/task_pump.cc
   M /trunk/src/chrome/common/net/notifier/base/task_pump.h
   M /trunk/src/chrome/common/net/notifier/base/time.cc
   M /trunk/src/chrome/common/net/notifier/base/time.h
   M /trunk/src/chrome/common/net/notifier/base/time_unittest.cc
   M /trunk/src/chrome/common/net/notifier/base/timer.cc
   M /trunk/src/chrome/common/net/notifier/base/timer.h
   M /trunk/src/chrome/common/net/notifier/base/utils.h
   M /trunk/src/chrome/common/net/notifier/base/win/async_network_alive_win32.cc
   M /trunk/src/chrome/common/net/notifier/base/win/time_win32.cc
   M /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.cc
   M /trunk/src/chrome/common/net/notifier/communicator/auto_reconnect.h
   M /trunk/src/chrome/common/net/notifier/communicator/connection_options.cc
   M /trunk/src/chrome/common/net/notifier/communicator/connection_options.h
   M /trunk/src/chrome/common/net/notifier/communicator/connection_settings.cc
   M /trunk/src/chrome/common/net/notifier/communicator/connection_settings.h
   M /trunk/src/chrome/common/net/notifier/communicator/const_communicator.h
   M /trunk/src/chrome/common/net/notifier/communicator/login.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login.h
   M /trunk/src/chrome/common/net/notifier/communicator/login_failure.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login_failure.h
   M /trunk/src/chrome/common/net/notifier/communicator/login_settings.cc
   M /trunk/src/chrome/common/net/notifier/communicator/login_settings.h
   M /trunk/src/chrome/common/net/notifier/communicator/mailbox.cc
   M /trunk/src/chrome/common/net/notifier/communicator/mailbox.h
   M /trunk/src/chrome/common/net/notifier/communicator/mailbox_unittest.cc
   M /trunk/src/chrome/common/net/notifier/communicator/product_info.h
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/common/net/notifier/communicator/single_login_attempt.h
   M /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_connection_generator.h
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_log.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_log.h
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/common/net/notifier/communicator/xmpp_socket_adapter.h
   M /trunk/src/chrome/common/net/notifier/listener/listen_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/listen_task.h
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread.h
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/mediator_thread_mock.h
   M /trunk/src/chrome/common/net/notifier/listener/notification_constants.cc
   M /trunk/src/chrome/common/net/notifier/listener/notification_constants.h
   M /trunk/src/chrome/common/net/notifier/listener/notification_defines.h
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task.h
   M /trunk/src/chrome/common/net/notifier/listener/send_update_task_unittest.cc
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/common/net/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/common/net/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/common/net/notifier/listener/xml_element_util.cc
   M /trunk/src/chrome/common/net/notifier/listener/xml_element_util.h
   M /trunk/src/chrome/common/net/notifier/listener/xml_element_util_unittest.cc

Moved XMPP notifier library from chrome/browser/sync to chrome/common/net.
BUG=None
TEST=No functional change

Review URL: http://codereview.chromium.org/1956001
------------------------------------------------------------------------
r46412 | albertb@chromium.org | 2010-05-05 01:44:10 +0200 (Wed, 05 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_win.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc

Migrate web data service logins to the login database correctly on win.

BUG=43054
TEST=PasswordStoreWinTest.Migration

Review URL: http://codereview.chromium.org/1874001
------------------------------------------------------------------------
r46410 | jhawkins@chromium.org | 2010-05-05 01:30:37 +0200 (Wed, 05 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h

autofill: Implement a TODO.

Avoids 3 conversions to UTF8 by converting |form_name_| from std::string to
string16.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1845001
------------------------------------------------------------------------
r46408 | jcivelli@google.com | 2010-05-05 01:29:46 +0200 (Wed, 05 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/test/data/firefox3_pref.js

The Firefox pref file may contain some non properly UTF-8
encoded values.  For now we simply ignore them to prevent
a DCHECK.

BUG=None
TEST=Run the FirefoxProxySettingsTest.TestParse unit-test

Review URL: http://codereview.chromium.org/1938002
------------------------------------------------------------------------
r46407 | shess@chromium.org | 2010-05-05 01:26:48 +0200 (Wed, 05 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h

[Mac] Unify drag and copy from Omnibox.

Previously drags went through the NSText code, which allowed drag of
rich text out of the Omnibox.  Modify so that both drag and copy use
the same core code.

Also undo the drag-all-like-location-bar-icon effect from an earlier
change.

BUG=41414, 43183, 41218
TEST=Compare Copy with drag&drop into TextEdit with various selections.

Review URL: http://codereview.chromium.org/1936002
------------------------------------------------------------------------
r46406 | sky@chromium.org | 2010-05-05 01:26:47 +0200 (Wed, 05 May 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Lands http://codereview.chromium.org/1744011/show for Hans:

Make reopened tabs with "about:" URLs display properly. 

- Rename TabNavigation::url_ to virtual_url_. 
Make it more explicit that a TabNavigation stores the *virtual* URL of
a 
NavigationEntry. 

- Translate virtual URLs when restoring tabs. 
Instead of putting the virtual URL in the URL proper field when
creating a 
NavigationEntry from a TabNavigation, put it in the virtual URL field,
and 
then translate this to a proper URL in 
NavigationController::CreateNavigationEntriesFromTabNavigations(). 
This fixes bug 31905. 

Contributed by Hans Wennborg <hans@chromium.org> 

BUG=31905
TEST=ui_tests --gtest_filter=TabRestoreUITest.RestoreTabWithSpecialURL*

Review URL: http://codereview.chromium.org/1946002
------------------------------------------------------------------------
r46404 | shess@chromium.org | 2010-05-05 01:23:35 +0200 (Wed, 05 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Always reset attributes as Omnibox changes.

r45524 regressed things so that color and other attributes could
"leak" through as the omnibox text was changed to values which where
those attributes were no longer appropriate.  For instance
strike-through or https coloring.  This resets the text attributes for
the in-focus case.

BUG=43149
TEST=See bug report.

Review URL: http://codereview.chromium.org/1938004
------------------------------------------------------------------------
r46402 | mrossetti@chromium.org | 2010-05-05 01:21:46 +0200 (Wed, 05 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target_unittest.mm

Should not just always close a folder menu unless there is a true need to change menus.

BUG=42982
TEST=1) Drag a couple of populated folders into the "Other Bookmarks" folder. Open one of those folders. Drag a bookmark from that folder out to be on top of the contain folder's button but don't release. Verify that the subfolder from which the bookmark came does not automatically close. Continue dragging so that the bookmark is now over the other folder. Verify that the old subfolder closes and the new folder opens. Drop the bookmark and verify that the bookmark is now in the second folder.
2) Locate a bookmark in a subfolder in a regular bar folder. Hover over it and verify that it opens automatically. Click once and verify that the folder closes. Click again and verify that it opens again.

Review URL: http://codereview.chromium.org/1935001
------------------------------------------------------------------------
r46400 | kkania@chromium.org | 2010-05-05 00:45:24 +0200 (Wed, 05 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc

Remove recently added DCHECK in 46384 which is causing some test crashes.
BUG=none
TEST=none
TBR=estade

Review URL: http://codereview.chromium.org/1912006
------------------------------------------------------------------------
r46395 | akalin@chromium.org | 2010-05-04 23:42:00 +0200 (Tue, 04 May 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/net/mock_network_change_observer.h
   A /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.cc
   A /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy.h
   A /trunk/src/chrome/browser/sync/net/network_change_notifier_proxy_unittest.cc
   M /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.h
   M /trunk/src/chrome/browser/sync/net/network_change_observer_proxy_unittest.cc
   A /trunk/src/chrome/browser/sync/net/thread_blocker.cc
   A /trunk/src/chrome/browser/sync/net/thread_blocker.h
   A /trunk/src/chrome/browser/sync/net/thread_blocker_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Wrote NetworkChangeNotifierProxy, which lets objects that don't live on
the same thread as a NetworkChangeNotifier safely listen to notifications.

Cleaned up unit tests.  Moved ThreadBlocker and MockNetworkChangeObserver
into their own files.

BUG=42606
TEST=unittests

Review URL: http://codereview.chromium.org/1909001
------------------------------------------------------------------------
r46393 | cmasone@google.com | 2010-05-04 23:14:49 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

[chromium os] Add support for an internal two-factor login scheme

BUG=chromium-os:1883
TEST=Unit tests

Review URL: http://codereview.chromium.org/1911001
------------------------------------------------------------------------
r46392 | viettrungluu@chromium.org | 2010-05-04 23:02:24 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Make HandleCrossAppNavigation() handle the case when there's no source tab.

E.g., Browser::OpenURL() will call OpenURLFromTab() (etc.) with no TabContents.

BUG=43040
TEST=Go to Prefs/Options dialog -> Under the Hood -> Privacy, click on "Learn more"; this should work and not crash.

Review URL: http://codereview.chromium.org/1917003
------------------------------------------------------------------------
r46391 | xiyuan@chromium.org | 2010-05-04 22:53:13 +0200 (Tue, 04 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   A /trunk/src/chrome/browser/chromeos/native_dialog_window.cc
   A /trunk/src/chrome/browser/chromeos/native_dialog_window.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

Host native gtk dialog in a Chrome window.

- Add a NativeDialogWindow as container for native dialog contents;
- Host native option dialogs in NativeDialogWindow;

BUG=<http://crosbug.com/1885>
TEST=Verify sub dialogs from options dialog have a frame and no longer full screen.

Review URL: http://codereview.chromium.org/1702018
------------------------------------------------------------------------
r46390 | mpcomplete@chromium.org | 2010-05-04 22:49:19 +0200 (Tue, 04 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc

Prevent chrome extension URL overrides from applying in incognito mode.

BUG=39372

Review URL: http://codereview.chromium.org/1940002
------------------------------------------------------------------------
r46389 | kkania@chromium.org | 2010-05-04 22:46:54 +0200 (Tue, 04 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

Enable BrowserActionApiTest.BrowserActionPopup test after fixing some flaky/crash problems.
BUG=39158
TEST=none

Review URL: http://codereview.chromium.org/1872002
------------------------------------------------------------------------
r46387 | eroman@chromium.org | 2010-05-04 22:41:24 +0200 (Tue, 04 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.cc
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings.h
   M /trunk/src/chrome/browser/importer/firefox_proxy_settings_unittest.cc
   A /trunk/src/chrome/browser/net/connection_tester.cc
   A /trunk/src/chrome/browser/net/connection_tester.h
   A /trunk/src/chrome/browser/net/connection_tester_unittest.cc
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   A /trunk/src/chrome/browser/resources/net_internals/testview.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/url_request/url_request_context.h

Add a tool for testing your network setup.

It runs a series of experiments using alternate network settings, to try and discover what the misconfiguration is.

DESIGN=http://docs.google.com/Doc?id=dfhcnb2v_22cjtdznvg

TEST=ConnectionTesterTest.*

Review URL: http://codereview.chromium.org/1937001
------------------------------------------------------------------------
r46384 | kkania@chromium.org | 2010-05-04 22:23:36 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/common/notification_type.h

Fix race in zygote_host_linux where socket was being read from and written to on different threads.

Made ZygoteHost methods all run on PROCESS_LAUNCHER thread. PostTask in linux from UI thread to PROCESS_LAUNCHER thread for DidProcessCrash. Changed DidProcessCrash to answer via a callback, which occurs asynchronously on linux. Rework cases in nacl_host, browser_render_process_host, and child_process_host where this method was being called to fit the callback model.

BUG=31737
TEST=none

Review URL: http://codereview.chromium.org/1695026
------------------------------------------------------------------------
r46381 | arv@chromium.org | 2010-05-04 22:14:45 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Don't update the input text if the input is focused/

BUG=42953
TEST=Type in the search field. We should never get into a state where we drop characters or replace what the user is typing.

Review URL: http://codereview.chromium.org/1912004
------------------------------------------------------------------------
r46380 | wtc@chromium.org | 2010-05-04 21:56:40 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Use NSS for SSL by default in chrome.exe.

R=agl,willchan
BUG=43142
TEST=All unit tests should pass on Windows.
Review URL: http://codereview.chromium.org/1911002
------------------------------------------------------------------------
r46376 | estade@chromium.org | 2010-05-04 21:24:42 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/base/basictypes.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/certificate_dialogs.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc

Fix various uses of release() that did not check its value

BUG=42904
TEST=compile, unit tests

Review URL: http://codereview.chromium.org/1730024
------------------------------------------------------------------------
r46369 | scherkus@chromium.org | 2010-05-04 20:28:03 +0200 (Tue, 04 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/profile.cc
   A /trunk/src/chrome/browser/resources/chat_manager
   A /trunk/src/chrome/browser/resources/chat_manager/background.html
   A /trunk/src/chrome/browser/resources/chat_manager/js
   A /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgeeventtypes.js
   A /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgehook.js
   A /trunk/src/chrome/browser/resources/chat_manager/js/gmailbridgehook.js
   A /trunk/src/chrome/browser/resources/chat_manager/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Checking in chat_manager built-in extension, this time behind --enable-chat-manager flag.

Patch by seh@chromium.org
http://codereview.chromium.org/1719023/show

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1904003
------------------------------------------------------------------------
r46363 | skrul@chromium.org | 2010-05-04 19:55:19 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc

Change autofill profile notifications to use WDS as source
I had made this change for regular autofill but didn't carry it all the way through and broke autofill profile sync :(

BUG=43110

Review URL: http://codereview.chromium.org/1863004
------------------------------------------------------------------------
r46360 | evan@chromium.org | 2010-05-04 19:10:34 +0200 (Tue, 04 May 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk_unittest.cc

linux: build fix
------------------------------------------------------------------------
r46359 | phajdan.jr@chromium.org | 2010-05-04 19:01:05 +0200 (Tue, 04 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Enable more parts of automation on all platforms:

- overriding encoding
- printing

Initially we couldn't compile them on all platforms,
now it's possible. Overriding of encoding works fully
everywhere (this also enables a test for that),
printing might hit some NOTIMPLEMENTEDs on non-Windows
platforms.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1943001
------------------------------------------------------------------------
r46358 | davemoore@chromium.org | 2010-05-04 18:58:07 +0200 (Tue, 04 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/boot_times_loader.cc
   A /trunk/src/chrome/browser/chromeos/boot_times_loader.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/chrome_browser.gypi

Put version and boot times on login screen.

BUG=chromium-os:2793, chromium-os:2980
TEST=None

When we went to login images we lost the version on the main screen.
This change moves it to the background so all wizard panels will show it.
Also we currently show the time it took to boot the system. We may change
this later but it's useful for now to keep us aware of regressions.
In addition, any issues with loading libcros are displayed here as well.

Review URL: http://codereview.chromium.org/1827001
------------------------------------------------------------------------
r46357 | evan@chromium.org | 2010-05-04 18:57:08 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.h

gtk: Make use of gtk signal macro in StatusIconGtk.

BUG=37375
TEST=out/Debug/chrome --long-lived-extensions, everything should works as before.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1839001
------------------------------------------------------------------------
r46347 | skerner@chromium.org | 2010-05-04 17:08:40 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc

Focus an existing app tab when an app is clicked on the new tab page or invoked using --app-id=...

BUG=none
TEST=BrowserAppRefocusTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46208

Review URL: http://codereview.chromium.org/1693006
------------------------------------------------------------------------
r46344 | danno@chromium.org | 2010-05-04 16:07:08 +0200 (Tue, 04 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

[Mac] Disable FindNextInNewTabUsesPrepopulate due to timeout

TBR=finnur@chromium.org
TEST=less redness
BUG=43070

Review URL: http://codereview.chromium.org/1944002
------------------------------------------------------------------------
r46339 | danno@chromium.org | 2010-05-04 11:35:54 +0200 (Tue, 04 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

[Mac] Mark FindInPageControllerTest.FindDisappearOnNewTabAndHistory as FLAKY_

TBR=finnur@chromium.org
TEST=less build redness
BUG=43072

Review URL: http://codereview.chromium.org/1915002
------------------------------------------------------------------------
r46337 | bauerb@chromium.org | 2010-05-04 10:43:35 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Mark all DownloadTest.[Dont]CloseNewTab* tests as flaky.

TEST=less redness
BUG=43066

Review URL: http://codereview.chromium.org/1933002
------------------------------------------------------------------------
r46336 | mnissler@chromium.org | 2010-05-04 10:05:54 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc

Enable preference change notifications for OTR HostContentSettingsMap s.t. changes to the content settings actually take effect. Make sure we access the original profile when displaying the host content settings dialog.

BUG=42887
TEST=manual

Review URL: http://codereview.chromium.org/1868001
------------------------------------------------------------------------
r46335 | mnissler@chromium.org | 2010-05-04 09:58:59 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/profile.cc

Make PROFILE_DESTROYED notifications work with OTR profiles.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1848003
------------------------------------------------------------------------
r46333 | inferno@chromium.org | 2010-05-04 08:47:00 +0200 (Tue, 04 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove unneeded clipboard command line switch.

BUG=43152

Review URL: http://codereview.chromium.org/1922002
------------------------------------------------------------------------
r46332 | aa@chromium.org | 2010-05-04 07:57:06 +0200 (Tue, 04 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Prevent navigations inside an app tab from clobbering the app tab.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r46331 | viettrungluu@chromium.org | 2010-05-04 07:38:44 +0200 (Tue, 04 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Mac: Don't run nested loop for browser_tests (matching Windows and Linux).

See sky's commit at r44412.

Also fix loading of MainMenu.nib when running browser_tests. (These two fixes are mutually dependent.)

BUG=43148
TEST=browser_tests still pass (or pass even more)

Review URL: http://codereview.chromium.org/1689001
------------------------------------------------------------------------
r46330 | inferno@chromium.org | 2010-05-04 06:58:58 +0200 (Tue, 04 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_clipboard_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc

Enable clipboard in extensions. re-enable the disabled clipboard test.

BUG=43147

Review URL: http://codereview.chromium.org/1933001
------------------------------------------------------------------------
r46329 | jhawkins@chromium.org | 2010-05-04 06:15:26 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

AutoFill: Fix IsAutoFillable to only count fields that are heuristically
matched.  Move heuristic matching into the constructor of FormStructure and
update the tests accordingly.

BUG=41255
TEST=FormStructureTest.*

Review URL: http://codereview.chromium.org/1906001
------------------------------------------------------------------------
r46322 | inferno@chromium.org | 2010-05-04 04:22:28 +0200 (Tue, 04 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_clipboard_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/clipboard/test.js

Disable clipboard test until I enable back clipboard for extensions. My recent webkit fix disabled clipboard completely, unfortunately.

Review URL: http://codereview.chromium.org/1925001
------------------------------------------------------------------------
r46311 | mrossetti@chromium.org | 2010-05-04 03:18:53 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Keep all parent folders highlighted in an active bookmark menu folder structure.

BUG=40284
TEST=Click on a folder in the bookmark bar which itself has subfolders. Move the mouse to hover over a subfolder. Verify that the folder in the bookmark bar remains highlighted. Move the mouse into the subfolder being hovered. Verify that the subfolder button remains highlighted. Move the mouse onto a different bookmark within the main parent folder. Verify that the originally highlighted subfolder is no longer highlighted.

Review URL: http://codereview.chromium.org/1784012
------------------------------------------------------------------------
r46308 | arv@chromium.org | 2010-05-04 02:52:08 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Fix race condition in find as you type.

BUG=42953
TEST=manual

Review URL: http://codereview.chromium.org/1910001
------------------------------------------------------------------------
r46304 | nick@chromium.org | 2010-05-04 02:30:10 +0200 (Tue, 04 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc

Disable autofill sync; there are too many crashes.
BUG=None
TEST=Run chrome, see that autofill is not an option.

Review URL: http://codereview.chromium.org/1833002
------------------------------------------------------------------------
r46302 | estade@chromium.org | 2010-05-04 02:26:52 +0200 (Tue, 04 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

GTK: make browser action container behave better in RTL.

a) fix gripper resize
b) fix browser action drag movement

BUG=42697
TEST=LANG=he_IL chrome

Review URL: http://codereview.chromium.org/1789005
------------------------------------------------------------------------
r46299 | inferno@chromium.org | 2010-05-04 02:19:17 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Update Webkit 58626:58719. Make use of new setting for disabling clipboard access, already added in webkit as part of fix - https://bugs.webkit.org/show_bug.cgi?id=27751. Enable the setting in Test framework. Also, provide a command-line switch for this setting.

BUG=41654
TEST=None

Review URL: http://codereview.chromium.org/1815005
------------------------------------------------------------------------
r46296 | finnur@chromium.org | 2010-05-04 01:31:24 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Duplicating a nano-tab should create another nano-tab, not a regular tab.

BUG=43129
TEST=Duplicate a nano-tab and observe that a nano-tab is created.

Review URL: http://codereview.chromium.org/1898001
------------------------------------------------------------------------
r46295 | rafaelw@chromium.org | 2010-05-04 00:56:17 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h

Include App pages in chrome://extensions "active views" list.

This changes the implementation such that the extensions_ui now iterates over all the RVHs in the process, rather than maintain an explicit list of ExtensionFunctionDispatchers (live app pages don't have EFDs).

TEST=none
BUG=42605

Review URL: http://codereview.chromium.org/1827002
------------------------------------------------------------------------
r46291 | finnur@chromium.org | 2010-05-04 00:34:35 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Fix dragging icon in Extension App Windows (it was enlarged while dragging).

The tab contents changes are purely cosmetic (readability).

BUG=43114
TEST=Drag a tab in an Extension App Window. It should have a regular sized icon.

Review URL: http://codereview.chromium.org/1889001
------------------------------------------------------------------------
r46290 | aa@chromium.org | 2010-05-04 00:21:18 +0200 (Tue, 04 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Fix regression in position of OTR icon.

BUG=43099
TEST=visual inspection

Review URL: http://codereview.chromium.org/1839004
------------------------------------------------------------------------
r46285 | stuartmorgan@chromium.org | 2010-05-04 00:14:47 +0200 (Tue, 04 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Enable Core Animation for Flash by default

Enabling this now on the Dev channel will give us better coverage to find any issues we don't know about yet

BUG=38932
TEST='gpu' and 'direct' wmode Flash instances should use CA on 10.6 (renderer CPU should be very low during video playback)

Review URL: http://codereview.chromium.org/1877004
------------------------------------------------------------------------
r46283 | thestig@chromium.org | 2010-05-03 23:49:31 +0200 (Mon, 03 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/profile.cc
   D /trunk/src/chrome/browser/resources/chat_manager
   M /trunk/src/chrome/chrome_browser.gypi

Revert 46232 - Checking in chat_manager builtin extension.

Patch by seh@chromium.org
http://codereview.chromium.org/1719023/show

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1875001

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/1892001
------------------------------------------------------------------------
r46282 | sanjeevr@chromium.org | 2010-05-03 23:46:19 +0200 (Mon, 03 May 2010) | 5 lines
Changed paths:
   M /trunk/src/base/message_loop_proxy.h
   M /trunk/src/chrome/browser/chrome_plugin_unittest.cc
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/net/url_request_context_getter.cc
   M /trunk/src/chrome/browser/net/url_request_context_getter.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc

Changed UrlFetcher to use a MessageLoopProxy instead of directly relying on ChromeThread. This will allow us to make UrlFetcher independent of ChromeThread and we can then move it to chrome/common.
BUG=None
TEST=UrlFetcher unit-tests

Review URL: http://codereview.chromium.org/1702016
------------------------------------------------------------------------
r46280 | akalin@chromium.org | 2010-05-03 23:42:19 +0200 (Mon, 03 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Size the sync row in Personal Stuff pane of Preferences horizontally.
This fixes I18N issues.

BUG=42537
TEST=manual (English and German)

Review URL: http://codereview.chromium.org/1886001
------------------------------------------------------------------------
r46276 | sanjeevr@chromium.org | 2010-05-03 23:27:06 +0200 (Mon, 03 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_mock.h
   M /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.h
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util.h
   M /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util_unittest.cc
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc

Changed namespace of the TalkMediator and related classes from browser_sync to notifier.
BUG=None
TEST=None, no functional change.

Review URL: http://codereview.chromium.org/1869002
------------------------------------------------------------------------
r46275 | akalin@chromium.org | 2010-05-03 23:23:58 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

added workaround for NULL defaultProfile in app_controller_mac.mm.

BUG=43048
TEST=manual, although couldn't repro original problem

Review URL: http://codereview.chromium.org/1845002
------------------------------------------------------------------------
r46272 | finnur@chromium.org | 2010-05-03 22:46:10 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Make reopen tabs work in Extension Windows.

BUG=http://crbug.com/43101
TEST=Close a tab within an Extension Window and reopen it. It should work just like restoring a tab works today.

Review URL: http://codereview.chromium.org/1884001
------------------------------------------------------------------------
r46271 | wtc@chromium.org | 2010-05-03 22:43:23 +0200 (Mon, 03 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h

Add an SSLBlockingPage::ErrorLevel enum type to make the
code more readable than using an "overridable" bool argument.

R=jcivelli
BUG=41360
TEST=None. Covered by existing tests.
Review URL: http://codereview.chromium.org/1862002
------------------------------------------------------------------------
r46270 | suzhe@chromium.org | 2010-05-03 22:37:45 +0200 (Mon, 03 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox_unittest.cc

Fix issue 42379

Improve GtkChromeShrinkableHBox to show invisible children properly when some children are removed or shrunk.

BUG=42379 gtk_chrome_shrinkable_hbox does not always show children that should be visisble
TEST=See bug report.

Review URL: http://codereview.chromium.org/1703024
------------------------------------------------------------------------
r46269 | skrul@chromium.org | 2010-05-03 22:33:05 +0200 (Mon, 03 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Delete map items before overwriting in AutoFillProfile::Clone().

BUG=42153,42965

Review URL: http://codereview.chromium.org/1866002
------------------------------------------------------------------------
r46266 | arv@chromium.org | 2010-05-03 22:00:33 +0200 (Mon, 03 May 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Remove height 100% from NTP when in the app launcher.

This is done by using chrome://newtab/#app-launcher and then map the hash to an attribute which is later used in the CSS. I investigated several alternative methods but they all lead to either a higher memory footprint (due to two copies of the NTP source in memory) or slowdown of NTP. No caching of the resource.

During my refactoring I *accidentally* fixed 35783 so I'm keeping that in there.

BUG=35783
TEST=Launch chrome with a new profile with the app launcher turned on.

Review URL: http://codereview.chromium.org/1846003
------------------------------------------------------------------------
r46265 | erg@chromium.org | 2010-05-03 21:19:57 +0200 (Mon, 03 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Fix toolbar internal-padding.

The widget is called "GtkToolbar", not "GtkToolBar". Capitalization
matters. This could have been a simple one character fix, but after looking at
it, I've set the internal-padding to 1 pixel and wrapped the "Other Bookmarks"
button so that it has one pixel of padding above and below it to
match. Otherwise, it can draw into BrowserAction area.

BUG=20495
TEST=Bookmark bar doesn't look ridiculously constrained on Radiance or Ambiance GTK+ theme.

Review URL: http://codereview.chromium.org/1843002
------------------------------------------------------------------------
r46263 | sky@chromium.org | 2010-05-03 21:12:05 +0200 (Mon, 03 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes crash in Browser::AddTabWithURL. The crash would happen if
GetOrCreateTabbedBrowser returned this.

BUG=42914
TEST=see bug

Review URL: http://codereview.chromium.org/1812009
------------------------------------------------------------------------
r46259 | erg@google.com | 2010-05-03 21:04:11 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc

GTK: Content exceptions dialog should be sortable by actions or patterns.

BUG=42909
TEST=none

Review URL: http://codereview.chromium.org/1692020
------------------------------------------------------------------------
r46256 | finnur@chromium.org | 2010-05-03 20:56:01 +0200 (Mon, 03 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix DuplicateTab browser crash with Extension Window found during debugging.

|browser| would be NULL because we don't check if browser
supports tabstrip. So it would crash on line 2070 of browser.cc.

Also fixed some lint issues with include orders and duplication.

BUG=http://crbug.com/43095
TEST=Open Extension window, duplicate the tab in it (it should not crash).

Review URL: http://codereview.chromium.org/1878001
------------------------------------------------------------------------
r46241 | mattm@chromium.org | 2010-05-03 19:55:11 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/chrome_exe.rc
   M /trunk/src/chrome/browser/app_icon_win.cc

Win: Fix wrong default icon being shown on chrome.exe.

BUG=42977
TEST=build official exe, look at it in explorer

Review URL: http://codereview.chromium.org/1736029
------------------------------------------------------------------------
r46238 | ctguil@chromium.org | 2010-05-03 19:33:14 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/accessibility_win_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add browser test to verify that MSAA clients can correctly retrieve accessibility tree from renderer.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1806001
------------------------------------------------------------------------
r46235 | mirandac@google.com | 2010-05-03 19:23:00 +0200 (Mon, 03 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Change hover time to 1600 ms, and resize more quickly for smaller width change.

BUG= 1455
TEST= hover over link which is too long for status bubble.  bubble should expand.
Review URL: http://codereview.chromium.org/149474
------------------------------------------------------------------------
r46232 | scherkus@chromium.org | 2010-05-03 19:11:04 +0200 (Mon, 03 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/profile.cc
   A /trunk/src/chrome/browser/resources/chat_manager
   A /trunk/src/chrome/browser/resources/chat_manager/background.html
   A /trunk/src/chrome/browser/resources/chat_manager/js
   A /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgeeventtypes.js
   A /trunk/src/chrome/browser/resources/chat_manager/js/chatbridgehook.js
   A /trunk/src/chrome/browser/resources/chat_manager/js/gmailbridgehook.js
   A /trunk/src/chrome/browser/resources/chat_manager/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi

Checking in chat_manager built-in extension.

Patch by seh@chromium.org
http://codereview.chromium.org/1719023/show

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1875001
------------------------------------------------------------------------
r46225 | bauerb@chromium.org | 2010-05-03 18:09:15 +0200 (Mon, 03 May 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller_unittest.mm

Reland r46049: [Mac] Make exceptions dialog a sheet.

Now with added unit tests!

XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.

At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.

The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.

BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.

Review URL: http://codereview.chromium.org/1817003
------------------------------------------------------------------------
r46224 | sky@chromium.org | 2010-05-03 17:52:29 +0200 (Mon, 03 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Adds ability for newly inserted tabs to appear before other tabs. I'll
wire this up to vertical tabs shortly.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1687020
------------------------------------------------------------------------
r46221 | phajdan.jr@chromium.org | 2010-05-03 16:53:29 +0200 (Mon, 03 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Disable crashy TaskManagerBrowserTest.ReloadExtension

TBR=erikkay

TEST=crashy
BUG=42315

Review URL: http://codereview.chromium.org/1857003
------------------------------------------------------------------------
r46216 | danno@chromium.org | 2010-05-03 13:59:51 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

Mark FindNextInNewTabUsesPrepopulate as FLAKY on Mac

TEST=less redness
BUG=43070

Review URL: http://codereview.chromium.org/1864001
------------------------------------------------------------------------
r46214 | bauerb@chromium.org | 2010-05-03 13:33:52 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Mark DownloadTest.CloseNewTab1 as flaky.

TEST=less redness
BUG=43066

Review URL: http://codereview.chromium.org/1863001
------------------------------------------------------------------------
r46213 | phajdan.jr@chromium.org | 2010-05-03 11:37:13 +0200 (Mon, 03 May 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

[GTTF] Mark the following tests as no longer flaky:

AutocompleteEditViewTest.EnterToSearch (bug 31732)
BrowserTest.SingleBeforeUnloadAfterWindowClose (bug 27039)
FindInPageControllerTest.PreferPreviousSearch (bug 32312)
SessionRestoreUITest.DontRestoreWhileIncognito (bug 39490)
SessionRestoreUITest.ShareProcessesOnRestore (bug 40181)
TabRestoreUITest.RestoreToDifferentWindow (bug 14132, the other test is still flaky)

TEST=no longer flaky
BUG=31732, 27039, 32312, 39490, 40181, 14132

Review URL: http://codereview.chromium.org/1697021
------------------------------------------------------------------------
r46212 | pfeldman@chromium.org | 2010-05-03 08:13:14 +0200 (Mon, 03 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

DevTools: focus devtools on breakpoint while docked (Linux & Mac fix).

Review URL: http://codereview.chromium.org/1846001
------------------------------------------------------------------------
r46211 | skerner@chromium.org | 2010-05-03 05:33:21 +0200 (Mon, 03 May 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc

Revert 46208 - Focus an existing app tab when an app is clicked on the new tab page or invoked using appid=...

Reverting due to massive buildbot failure.

BUG=none
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/1693006

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1836002
------------------------------------------------------------------------
r46210 | skerner@chromium.org | 2010-05-03 05:31:54 +0200 (Mon, 03 May 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Revert 46209 - Disable tests on chromeos, while test failures are being investigated.

Revert this along with the initial change (r46208).

TBR=erikkay
BUG=43061
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/1840001

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1842001
------------------------------------------------------------------------
r46209 | skerner@chromium.org | 2010-05-03 05:13:49 +0200 (Mon, 03 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disable tests on chromeos, while test failures are being investigated.

TBR=erikkay
BUG=43061
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/1840001
------------------------------------------------------------------------
r46208 | skerner@chromium.org | 2010-05-03 04:11:47 +0200 (Mon, 03 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc

Focus an existing app tab when an app is clicked on the new tab page or invoked using --app-id=...

BUG=none
TEST=BrowserAppRefocusTest.*

Review URL: http://codereview.chromium.org/1693006
------------------------------------------------------------------------
r46187 | yusukes@chromium.org | 2010-05-02 01:57:45 +0200 (Sun, 02 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h

Modify SetImeConfig() method so it queues a config request when ibus connection is not ready yet.

This trick is necessary since chrome for the login screen calls SetImeConfig() before ibus-daemon starts. This is the first step to fix crosbug.com/2670.

BUG=crosbug.com/2670
TEST=manual

Review URL: http://codereview.chromium.org/1758014
------------------------------------------------------------------------
r46186 | yusukes@chromium.org | 2010-05-02 01:31:10 +0200 (Sun, 02 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc

Moving strings for the Korean input method from C++ file to .grd file.

* Use translated English strings rather than transliterated Korean strings.
* Drop "3-set 2-set" keyboard support since it's not widely used.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/1718018
------------------------------------------------------------------------
r46184 | phajdan.jr@chromium.org | 2010-05-01 10:07:50 +0200 (Sat, 01 May 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_a.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_b.html

Revert "Clean-up of the asynchronous behaviour of the experimental extension popup API. "

This reverts http://codereview.chromium.org/1512007

TBR=twiz

Review URL: http://codereview.chromium.org/1735026
------------------------------------------------------------------------
r46177 | viettrungluu@chromium.org | 2010-05-01 04:55:59 +0200 (Sat, 01 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Revert 46168 to try to fix browser_tests - Mac: Try to make sure BrowserWindowCocoa::Close() only actually closes on the main event loop.

[I have my doubts this revert will fix anything.]

Otherwise, we might *add* browsers synchronously in Close(), which modifies the
browser list, which is not allowed.

BUG=42102
TEST=enable popups, go to popuptest.com, click on multipopuptest or whatever it's called, quit, make sure it quit cleanly, repeat a few times

Review URL: http://codereview.chromium.org/1759017

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/1730026
------------------------------------------------------------------------
r46174 | sanjeevr@chromium.org | 2010-05-01 04:01:42 +0200 (Sat, 01 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc

Redo of http://codereview.chromium.org/1700003/show which was reverted. We check for a sync specific service URL (or an empty) one before acting on a notification from TalkMediator. 
BUG=None 
TEST=Test Bookmarks Sync Notifications. 

Review URL: http://codereview.chromium.org/1817006
------------------------------------------------------------------------
r46170 | arv@chromium.org | 2010-05-01 02:52:14 +0200 (Sat, 01 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

When apps are enabled we hide the most visited and recent changes at first run.

This is done by a new pref kNTPAppLauncherFirstRun to ensure we only hide them once.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1763022
------------------------------------------------------------------------
r46168 | viettrungluu@chromium.org | 2010-05-01 02:46:26 +0200 (Sat, 01 May 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Mac: Try to make sure BrowserWindowCocoa::Close() only actually closes on the main event loop.

Otherwise, we might *add* browsers synchronously in Close(), which modifies the
browser list, which is not allowed.

BUG=42102
TEST=enable popups, go to popuptest.com, click on multi-popup-test or whatever it's called, quit, make sure it quit cleanly, repeat a few times

Review URL: http://codereview.chromium.org/1759017
------------------------------------------------------------------------
r46153 | estade@chromium.org | 2010-05-01 01:35:44 +0200 (Sat, 01 May 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/gfx/point.h
   M /trunk/src/gfx/rect.cc
   M /trunk/src/gfx/rect.h

GTK: unify the bookmark dragging icon generation code into bookmark utils.

this also has the effect of standardizing the appearance of boomkark drags. On compositing window managers, the drag widget will have no background.

BUG=42147
TEST=manual

Review URL: http://codereview.chromium.org/1780016
------------------------------------------------------------------------
r46151 | kkania@chromium.org | 2010-05-01 01:25:57 +0200 (Sat, 01 May 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/storage/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/storage/tab.html

Attempt to fix AppApiTest.AppProcess and ExtensionApiTest.Storage flakiness.
BUG=42497,42943
TEST=none

Review URL: http://codereview.chromium.org/1705025
------------------------------------------------------------------------
r46141 | georgey@chromium.org | 2010-05-01 00:51:46 +0200 (Sat, 01 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_unittest.cc

Fix for bug 37909: "Clear All" in incognito downloads window will clear all, including non-incognito downloads.
BUG=37909
TEST=Open regular and incognito download pages. "Clear all" on incognito will clear all, but pending downloads. In regular window it would clear all, but pending and incognito.
Review URL: http://codereview.chromium.org/1807007
------------------------------------------------------------------------
r46139 | oshima@chromium.org | 2010-05-01 00:47:34 +0200 (Sat, 01 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h

Fix crash bug when mouse hovers over system notification.

BUG=http://crosbug.com/2940
TEST=new test NotificationTest.TestActivateDeactivate is added to cover this.

Review URL: http://codereview.chromium.org/1824001
------------------------------------------------------------------------
r46137 | erg@google.com | 2010-05-01 00:47:08 +0200 (Sat, 01 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

GTK: Use signal macros for most of BrowserWindowGtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1747023
------------------------------------------------------------------------
r46136 | twiz@chromium.org | 2010-05-01 00:39:22 +0200 (Sat, 01 May 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_a.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_b.html

Clean-up of the asynchronous behaviour of the experimental extension popup API. 

 - It was previously possible to programmatically launch two popups from the same extension.  (Simply call popup.show twice in a row, or in a callback chain.)  

 I removed this incorrect funcationality by registering ExtensionPopupHost to listen for EXTENSION_HOST_CREATED notifications.  If a popup is shown, and a new ExtensionHost is constructed of type EXTENSION_POPUP, then the presently displayed popup is dismissed. 

 - The callback function for popup.show(...) was  previously called in response to EXTENSION_POPUP_VIEW_READY, as processed in  response to a ViewHostMsg_DocumentAvailableInMainFrame message.  This message wassent after PARSING of the conent of the popup view.  Because of this behaviour, the API was difficult to use because one could not meaningfully interact with the popup page 
during the callback:  The callback would race with completion of the onload handler within the popup, so some sort of polling for onload-complete was required.
  I fixed the problem by adding new notifications and messages so that EXTENSION_POPUP_VIEW_READY is now sent only after all onload handlers have been invoked.Corresponding unit-tests have also been added.

BUG=None
TEST=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/1512007
------------------------------------------------------------------------
r46132 | albertb@chromium.org | 2010-05-01 00:29:42 +0200 (Sat, 01 May 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default_unittest.cc

Send out notifications when logins are changed on Win and Linux.

BUG=35039
TEST=PasswordStoreDefaultTest.Notifications

Review URL: http://codereview.chromium.org/1758020
------------------------------------------------------------------------
r46131 | chocobo@chromium.org | 2010-05-01 00:29:42 +0200 (Sat, 01 May 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc

Add ability to disconnect from network and changing passwords.
BUG=chromiumos:2981
TEST=manually tested both functionality in the UI.
Review URL: http://codereview.chromium.org/1723022
------------------------------------------------------------------------
r46129 | mirandac@google.com | 2010-05-01 00:16:46 +0200 (Sat, 01 May 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc

Tweak the First Run Search Engine dialog to improve look of text label views, by making text labels bold, and a little bit larger.

Review URL: http://codereview.chromium.org/1725020
------------------------------------------------------------------------
r46127 | xiyuan@chromium.org | 2010-04-30 23:54:58 +0200 (Fri, 30 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc

Fix a potential crash in ChromeOS options dialog.

This is because the gtk-based options page is based on NativeViewHost
which does not provide CanClose function. The fix bypasses the check of
CanClose for gtk-base options pages since this seems not supported.
The crash does not happen now because OptionsWindowView does not set
accept_ flag and thus CanClose is not called. However, we might want to
patch this just in case.

BUG=none
TEST=Verify Chrome does not crash on ChromeOs when user presses "ESC" on gtk-based options page.

Review URL: http://codereview.chromium.org/1825001
------------------------------------------------------------------------
r46125 | viettrungluu@chromium.org | 2010-04-30 23:51:58 +0200 (Fri, 30 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/app_mode_common_mac.h (from /trunk/src/chrome/common/app_mode_constants_mac.h:46109)
   A /trunk/src/chrome/common/app_mode_common_mac.mm (from /trunk/src/chrome/common/app_mode_constants_mac.mm:46109)
   D /trunk/src/chrome/common/app_mode_constants_mac.h
   D /trunk/src/chrome/common/app_mode_constants_mac.mm

Mac: rename app_mode_constants_mac.*.

I foolishly gave these files a too-specialized name.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1727019
------------------------------------------------------------------------
r46123 | chocobo@chromium.org | 2010-04-30 23:50:45 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   A /trunk/src/chrome/browser/chromeos/options/wifi_config_view_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add UI for changing auto-connect option on network.
Fixed crashing bug and ethernet not updating bug.
BUG=chromiumos:2896,2939,2996
TEST=manual, in network options dialog, the new auto-connect checkbox should now control whether or not we automatically connect to this network.
Review URL: http://codereview.chromium.org/1755013
------------------------------------------------------------------------
r46121 | erg@google.com | 2010-04-30 23:35:43 +0200 (Fri, 30 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

GTK: Popup windows that use the custom frame should use the tab image instead of the frame.

This is how mac does things, and Miranda is going to change the windows
version, too.

BUG=21672
TEST=none

Review URL: http://codereview.chromium.org/1775012
------------------------------------------------------------------------
r46116 | feldstein@chromium.org | 2010-04-30 23:09:57 +0200 (Fri, 30 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

Remove Draggability of browser extensions in incognito mode

There is a crash when you hide icons in incognito mode by dragging the container
to zero width.  Since these resizes aren't even persisted, and it would be a
decent sized and possibly dangerous change this close to M5, I'm just disabling
the draggability.

BUG=42848
TEST=Shouldn't be able to drag in incognito mode, nor crash as per bug.

Review URL: http://codereview.chromium.org/1817005
------------------------------------------------------------------------
r46114 | jrg@chromium.org | 2010-04-30 22:59:53 +0200 (Fri, 30 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBarFolderWindow.xib
   A /trunk/src/chrome/app/theme/menu_overflow_down.pdf
   A /trunk/src/chrome/app/theme/menu_overflow_up.pdf
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/chrome_dll.gypi

Vertical scrolling arrows in bookmark bar folder windows when needed.

pdfs from Cole.
BUG=42026

TEST=\
1) Small folders --> no arrows.
2) Big folders --> arrow at bottom initially.
3) Move browser to bottom of screen so a small folder falls off the bottom and has an arrow.
Open it and gently use scroll wheel to scroll.  Make sure transition to "no arrow" looks good.
Close and reopen.  Scroll super-fast.  Make sure it ends up in the same nice place.
4) Open big big folder.  Scroll so top goes offscreen so you now have 2 scroll arrows.
Use scroll wheel to gently go up and down (arrow hides and shows).  Make sure transitions OK.
Scroll all the way so bottom arrow disappears.  Gently up and down; watch for transitions.
Now FAST up and down.  Make sure destination looks OK.

BookmarkBarFolderWindow.xib change: BookmarkBarFolderWindowScrollView border turned off.

Review URL: http://codereview.chromium.org/1813003
------------------------------------------------------------------------
r46112 | suzhe@chromium.org | 2010-04-30 22:45:32 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac]Fix issue 34343: "Tab to search" hint on omnibox disappears on drag dropped tab.

This CL is just a clone of http://codereview.chromium.org/1519005. As I just rebuilt my working environment.

BUG=34343
TEST=Input www.google.com to trigger "tab to search" hint, then drag the tab into a new window, then check if "tab to search" hint is still there.

Review URL: http://codereview.chromium.org/1523016
------------------------------------------------------------------------
r46109 | sanjeevr@chromium.org | 2010-04-30 21:52:35 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_mock.h
   M /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.h
   M /trunk/src/chrome/browser/sync/notifier/listener/notification_defines.h
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   A /trunk/src/chrome/browser/sync/sync_constants.cc
   A /trunk/src/chrome/browser/sync/sync_constants.h
   M /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   M /trunk/src/chrome/browser/sync/tools/sync_tools.gyp
   M /trunk/src/chrome/chrome_browser.gypi

More refactoring of TalkMediator and related classes to make them generic. There is only one functional change in this changelist. This is the removal of the  mediator_thread_->SendNotification call from TalkMediatorImpl::OnSubscriptionSuccess. Please review this part extra carefully.
BUG=None
TEST=Test Bookmarks Sync, sync unit-tests have been modified.

Review URL: http://codereview.chromium.org/1790004
------------------------------------------------------------------------
r46108 | avi@chromium.org | 2010-04-30 21:43:18 +0200 (Fri, 30 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/platform_util_common_linux.cc
   M /trunk/src/chrome/browser/platform_util_mac.mm
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc

Revert 46101 - Make a new yes/no messagebox wrapper function, use it in the bookmark alert.

BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. An confirmation
dialog box should be shown. No other visible change.

Review URL: http://codereview.chromium.org/1687017

TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/1783014
------------------------------------------------------------------------
r46106 | erg@google.com | 2010-04-30 21:25:41 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.h

GTK: Fix color/theme logic on the instructions label on the bookmark bar.

BUG=42957
TEST=none

Review URL: http://codereview.chromium.org/1816005
------------------------------------------------------------------------
r46103 | prasadt@chromium.org | 2010-04-30 20:55:53 +0200 (Fri, 30 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/chrome_exe_main_gtk.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/test/testing_browser_process.h

r46025 reverted r46023 which caused a build break on chromeos.
This change reverts r46025 and fixes the build break which is just a one line
change in chrome/browser/first_run_gtk.cc to move the definition of
Upgrade::new_command_line_ to be inside a #if.  Details on the change and code
review feedback for the original CL can be found at
http://codereview.chromium.org/1633021.

BUG=40975
TEST=none

Review URL: http://codereview.chromium.org/1691022
------------------------------------------------------------------------
r46101 | avi@chromium.org | 2010-04-30 20:54:43 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/platform_util.h
   M /trunk/src/chrome/browser/platform_util_common_linux.cc
   M /trunk/src/chrome/browser/platform_util_mac.mm
   M /trunk/src/chrome/browser/platform_util_win.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc

Make a new yes/no messagebox wrapper function, use it in the bookmark alert.

BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. An confirmation
dialog box should be shown. No other visible change.

Review URL: http://codereview.chromium.org/1687017
------------------------------------------------------------------------
r46099 | avi@chromium.org | 2010-04-30 20:38:15 +0200 (Fri, 30 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Fix contextual menu crash by disabling the contextual menu.

BUG=http://crbug.com/42743
TEST=as in bug


Review URL: http://codereview.chromium.org/1687025
------------------------------------------------------------------------
r46096 | willchan@chromium.org | 2010-04-30 20:30:09 +0200 (Fri, 30 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc

Mark AppApiTest.AppProcess as flaky.
BUG=42497

Review URL: http://codereview.chromium.org/1691023
------------------------------------------------------------------------
r46091 | mark@chromium.org | 2010-04-30 20:16:18 +0200 (Fri, 30 Apr 2010) | 18 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/authorization_util.cc
   M /trunk/src/chrome/browser/cocoa/authorization_util.h
   A /trunk/src/chrome/browser/cocoa/authorization_util.mm (from /trunk/src/chrome/browser/cocoa/authorization_util.cc:45937)
   A /trunk/src/chrome/browser/cocoa/install.sh
   M /trunk/src/chrome/browser/cocoa/install_from_dmg.mm
   M /trunk/src/chrome/browser/cocoa/keystone_glue.h
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm
   M /trunk/src/chrome/browser/cocoa/keystone_promote_postflight.sh
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi

Allow authenticated installs from the disk image.

When launching from a read-only disk image, if no installed copy exists in
/Applications, and the user chooses to install from the disk image:

If it appears that there isn't permission to write to /Applications, prompt
the user to authenticate as an administrator.  If authentication is
successful, copy the application as root, set its permissions, and promote
Keystone to use a system ticket.

BUG=40265
TEST=Remove the application from /Applications and test, as both an admin
     user and a normal user, installation directly from the disk image.  When
     installation occurs after authentication, Chrome should be on a system
     ticket.
     Also, make sure that normal in-app Keystone promotion continues to work
     as expected.
Review URL: http://codereview.chromium.org/1792013
------------------------------------------------------------------------
r46086 | erg@google.com | 2010-04-30 19:42:38 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h

gtk: Make use of gtk signal macros in EditSearchEngineDialog.

BUG=None
TEST=manually

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1741016
------------------------------------------------------------------------
r46085 | zork@chromium.org | 2010-04-30 19:33:18 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/protocol/typed_url_specifics.proto

Update typed_url sync to support visits.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1775004
------------------------------------------------------------------------
r46083 | kkania@chromium.org | 2010-04-30 19:31:42 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

[Linux] Mark ExtensionApiTest.Storage as flaky.
BUG=42943
TEST=none
TBR=rafaelw

Review URL: http://codereview.chromium.org/1810012
------------------------------------------------------------------------
r46080 | skrul@chromium.org | 2010-04-30 19:07:40 +0200 (Fri, 30 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   A /trunk/src/chrome/browser/webdata/web_data_service_test_util.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   A /trunk/src/chrome/test/live_sync/two_client_live_autofill_sync_unittest.cc
   A /trunk/src/chrome/test/thread_observer_helper.h

Adds TwoClientLiveAutofillSyncTest to test old school autofill.  Includes some refactoring of the WebDataServiceTest to allow some code sharing between the two.

Review URL: http://codereview.chromium.org/1739017
------------------------------------------------------------------------
r46078 | skerner@chromium.org | 2010-04-30 19:00:09 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/scoped_temp_dir.cc
   M /trunk/src/base/scoped_temp_dir.h
   M /trunk/src/base/scoped_temp_dir_unittest.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_file_util.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Unpack extensions inside chrome's profile directory.

Other users of the temp directory will be altered in a subsequent CL.

BUG=13044
TEST=SandboxedExtensionUnpackerTest.*, ScopedTempDir.UniqueTempDirUnderPath, FileUtilTest.CreateNewTempDirInDirTest, manual testing on win, linux, mac.

Review URL: http://codereview.chromium.org/1582022
------------------------------------------------------------------------
r46076 | mpcomplete@chromium.org | 2010-04-30 18:42:59 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Have extension call windows.getLastFocused include incognito windows if the
extension is enabled for incognito.

BUG=39113

Review URL: http://codereview.chromium.org/1789010
------------------------------------------------------------------------
r46075 | albertb@chromium.org | 2010-04-30 18:39:42 +0200 (Fri, 30 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_form_data.h
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   A /trunk/src/chrome/browser/password_manager/password_store_default_unittest.cc (from /trunk/src/chrome/browser/password_manager/password_store_linux_unittest.cc:46072)
   D /trunk/src/chrome/browser/password_manager/password_store_linux.cc
   D /trunk/src/chrome/browser/password_manager/password_store_linux.h
   D /trunk/src/chrome/browser/password_manager/password_store_linux_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   A /trunk/src/chrome/browser/password_manager/password_store_win_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Refactor PasswordStoreWin to store logins in a LoginDatabase instead of
the WebDataService.

BUG=35038
TEST=PasswordStoreDefaultTest.*

Review URL: http://codereview.chromium.org/1572040
------------------------------------------------------------------------
r46074 | kkania@chromium.org | 2010-04-30 18:39:36 +0200 (Fri, 30 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

[Mac] Small change to get the BrowserActionApiTest.IncognitoDragging test running.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1810008
------------------------------------------------------------------------
r46071 | sky@chromium.org | 2010-04-30 17:05:10 +0200 (Fri, 30 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h

Attempt 2 at relanding your patch. I believe the problem was the removal of the observer in ~TabStrip. By the time TabStrip's destructor was run the model's destructor had already run. I've changed BrowserView to explicitly delete the TabStrip before the browser. See the change between v1 and v2 of this patch in BrowserView for the relevant part.

BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/1817001
------------------------------------------------------------------------
r46070 | timurrrr@chromium.org | 2010-04-30 16:50:58 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_test_util.cc
   A /trunk/src/net/tools/testserver/chromiumsync.py
   A /trunk/src/net/tools/testserver/chromiumsync_test.py
   M /trunk/src/net/tools/testserver/testserver.py
   A /trunk/src/third_party/protobuf2/__init__.py
   A /trunk/src/third_party/protobuf2/descriptor_pb2.py
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Re-apply http://codereview.chromium.org/1622012
It was reverted as http://codereview.chromium.org/1822001 the fix in Valgrind scripts has been commited as http://codereview.chromium.org/1736026
TEST=trybots

Review URL: http://codereview.chromium.org/1763023
------------------------------------------------------------------------
r46068 | gdk@chromium.org | 2010-04-30 16:23:04 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Create a command-line switch for enabling touch events.

BUG=36415
TEST=none

Review URL: http://codereview.chromium.org/1575033
------------------------------------------------------------------------
r46062 | yurys@chromium.org | 2010-04-30 13:37:05 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-fake-workers.html
   A /trunk/src/chrome/browser/debugger/manual_tests/resources/primes.js
   A /trunk/src/chrome/browser/debugger/manual_tests/resources/worker-primes.js

Manual test for debugging workers in Dev Tools. Original patch by caseq: http://codereview.chromium.org/1731019

TBR=pfeldman

Review URL: http://codereview.chromium.org/1758019
------------------------------------------------------------------------
r46060 | bauerb@chromium.org | 2010-04-30 13:36:43 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Fix shift-clicking on a delete history checkbox.

Shift-clicking on a checkbox in the history editing mode now sets all checkboxes from the last click to the current click to the state of the just clicked checkbox. Also, the last clicked checkbox is focused to indicate the anchoring.

BUG=42827
TEST=See bug.

Review URL: http://codereview.chromium.org/1718021
------------------------------------------------------------------------
r46059 | yurys@chromium.org | 2010-04-30 13:33:00 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Reenable some devtools tests. Original patch by caseq: http://codereview.chromium.org/1819004

TBR=pfeldman

Review URL: http://codereview.chromium.org/1796006
------------------------------------------------------------------------
r46058 | bulach@chromium.org | 2010-04-30 13:18:15 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

Don't trigger auto fill setup when submitting empty forms.

(landing on behalf of satish@chromium.org from http://codereview.chromium.org/1769008/show)

BUG=41015
TEST=Open the test page given in the bug and hit submit, verify that the autofill setup infobar does not pop up.

Review URL: http://codereview.chromium.org/1822002
------------------------------------------------------------------------
r46050 | bauerb@chromium.org | 2010-04-30 10:45:58 +0200 (Fri, 30 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm

Revert 46049 - [Mac] Make exceptions dialog a sheet.

XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.

At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.

The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.

BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.

Review URL: http://codereview.chromium.org/1760001

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1790009
------------------------------------------------------------------------
r46049 | bauerb@chromium.org | 2010-04-30 10:37:22 +0200 (Fri, 30 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm

[Mac] Make exceptions dialog a sheet.

XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.

At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.

The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.

BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.

Review URL: http://codereview.chromium.org/1760001
------------------------------------------------------------------------
r46048 | phajdan.jr@chromium.org | 2010-04-30 10:15:31 +0200 (Fri, 30 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   D /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_test_util.cc
   D /trunk/src/net/tools/testserver/chromiumsync.py
   D /trunk/src/net/tools/testserver/chromiumsync_test.py
   M /trunk/src/net/tools/testserver/testserver.py
   D /trunk/src/third_party/protobuf2/__init__.py
   D /trunk/src/third_party/protobuf2/descriptor_pb2.py
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Revert "[Third time landing] Python implementation of sync server, for testing."

This broke the memory waterfall, failed to import protobuf.

TBR=nick

Review URL: http://codereview.chromium.org/1822001
------------------------------------------------------------------------
r46046 | phajdan.jr@chromium.org | 2010-04-30 09:26:15 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/multipart_uitest.cc

Fix the build, missed a remaining TestServerPageW in code
that is compiled only in Release builds.

TBR=eroman

Review URL: http://codereview.chromium.org/1687024
------------------------------------------------------------------------
r46045 | aa@chromium.org | 2010-04-30 09:19:51 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Unbreak app tab icons. The bigger app tab icons weren't showing up.

TBR=finnur@chromium.org

Review URL: http://codereview.chromium.org/1808004
------------------------------------------------------------------------
r46044 | phajdan.jr@chromium.org | 2010-04-30 09:17:30 +0200 (Fri, 30 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/repost_form_warning_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/infobars_uitest.cc
   M /trunk/src/chrome_frame/test/http_server.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Remove deprecated things from net test suite:

 - URLRequestTestContext (from now on use TestURLRequestContext)
 - TestServerPageW (use TestServerPage).

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1814002
------------------------------------------------------------------------
r46040 | nick@chromium.org | 2010-04-30 07:37:51 +0200 (Fri, 30 Apr 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_test_util.cc
   A /trunk/src/net/tools/testserver/chromiumsync.py
   A /trunk/src/net/tools/testserver/chromiumsync_test.py
   M /trunk/src/net/tools/testserver/testserver.py
   A /trunk/src/third_party/protobuf2/__init__.py
   A /trunk/src/third_party/protobuf2/descriptor_pb2.py
   M /trunk/src/third_party/protobuf2/protobuf.gyp

[Third time landing] Python implementation of sync server, for testing.

Implement the server side of chromium sync inside of testserver.py.  The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.

Make the sync_integration_tests run by default against the test server.  An externally-provided --sync-url will give the old behavior.

Protocol buffers stuff: The test sync server requires Python generated code for .proto files.  I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf).

Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory.  The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.

Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port.  Very useful if a test failure leaves a server running.  Tested this against all combos of protocols, and it seems to work.

Flakiness fix: Port sync_integration_tests to the out-of-process test runner.

Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.

BUG=20905,40980

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45916

Review URL: http://codereview.chromium.org/1622012
------------------------------------------------------------------------
r46038 | aa@chromium.org | 2010-04-30 06:25:05 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Unbreak app launch container overriding. Before, you could choose what kind of app container you wanted to launch in so that we could try out different things.

My change to window affinity change broke this for tabs. This should fix it.

Review URL: http://codereview.chromium.org/1811005
------------------------------------------------------------------------
r46037 | akalin@chromium.org | 2010-04-30 06:23:00 +0200 (Fri, 30 Apr 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/net
   A /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.cc
   A /trunk/src/chrome/browser/sync/net/network_change_observer_proxy.h
   A /trunk/src/chrome/browser/sync/net/network_change_observer_proxy_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Added NetworkChangeObserverProxy class.

This class forwards notifications from a NetworkChangeNotifier on one
thread to an observer on another.  This will be used to enable
the sync threads to listen to NCN notifications from the IO thread.

BUG=42606
TEST=unittests

Review URL: http://codereview.chromium.org/1704014
------------------------------------------------------------------------
r46032 | mrossetti@chromium.org | 2010-04-30 04:35:21 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Pasting on a folder now puts the pasted bookmark item in the folder as the last bookmark within the folder. Bringing up a contextual menu on an open bookmark bar folder no longer closes the folder.

BUG=32064
TEST=1) Copy a bookmark item. Using the contextual menu, paste the bookmark item just copied onto the top of a folder in the bookmark bar. Open that folder and verify that the pasted item appears as the last bookmark therein. 2) Copy a bookmark item. Pop open a bookmark bar folder which itself contains a folder. Paste the bookmark item onto the top of that subfolder. Verify that the subfolder now contains the pasted bookmark item as its last bookmark. 3) Pop open a bookmark folder. Bring up the contextual menu on that folder. Verify that the folder window is not automatically closed when the contextual menu is presented.

Review URL: http://codereview.chromium.org/1732029
------------------------------------------------------------------------
r46029 | viettrungluu@chromium.org | 2010-04-30 04:19:50 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm

Mac: add encoding meta-tag to HTML provided with NSHTMLPboardType.

Otherwise, US-ASCII is assumed.

BUG=42661
TEST=dragging text from, e.g., Chinese-language web sites into TextEdit works

Review URL: http://codereview.chromium.org/1820001
------------------------------------------------------------------------
r46028 | aa@chromium.org | 2010-04-30 04:06:19 +0200 (Fri, 30 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Unbreak app windows. The signature to AddTabWithURL had changed, but in a compatible way. This was causing the initial tab to get added to an app window with some odd properties.

Review URL: http://codereview.chromium.org/1703023
------------------------------------------------------------------------
r46027 | arv@chromium.org | 2010-04-30 03:49:57 +0200 (Fri, 30 Apr 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js:46022)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarktree.js:46022)
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarktree.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/tree_iterator.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/treeiterator.js:46022)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/tree_iterator_test.html (from /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/treeiterator_test.html:46022)
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/treeiterator.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/treeiterator_test.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   A /trunk/src/chrome/browser/resources/shared/js/cr/event_target.js (from /trunk/src/chrome/browser/resources/shared/js/cr/eventtarget.js:46022)
   A /trunk/src/chrome/browser/resources/shared/js/cr/event_target_test.html (from /trunk/src/chrome/browser/resources/shared/js/cr/eventtarget_test.html:46022)
   D /trunk/src/chrome/browser/resources/shared/js/cr/eventtarget.js
   D /trunk/src/chrome/browser/resources/shared/js/cr/eventtarget_test.html
   A /trunk/src/chrome/browser/resources/shared/js/cr/link_controller.js (from /trunk/src/chrome/browser/resources/shared/js/cr/linkcontroller.js:46022)
   A /trunk/src/chrome/browser/resources/shared/js/cr/link_controller_test.html (from /trunk/src/chrome/browser/resources/shared/js/cr/linkcontroller_test.html:46022)
   D /trunk/src/chrome/browser/resources/shared/js/cr/linkcontroller.js
   D /trunk/src/chrome/browser/resources/shared/js/cr/linkcontroller_test.html
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js (from /trunk/src/chrome/browser/resources/shared/js/cr/ui/contextmenuhandler.js:46022)
   D /trunk/src/chrome/browser/resources/shared/js/cr/ui/contextmenuhandler.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_item.js (from /trunk/src/chrome/browser/resources/shared/js/cr/ui/listitem.js:46022)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/list_selection_model.js (from /trunk/src/chrome/browser/resources/shared/js/cr/ui/listselectionmodel.js:46022)
   D /trunk/src/chrome/browser/resources/shared/js/cr/ui/listitem.js
   D /trunk/src/chrome/browser/resources/shared/js/cr/ui/listselectionmodel.js
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/menu_button.js (from /trunk/src/chrome/browser/resources/shared/js/cr/ui/menubutton.js:46022)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/menu_item.js (from /trunk/src/chrome/browser/resources/shared/js/cr/ui/menuitem.js:46022)
   D /trunk/src/chrome/browser/resources/shared/js/cr/ui/menubutton.js
   D /trunk/src/chrome/browser/resources/shared/js/cr/ui/menuitem.js
   D /trunk/src/chrome/browser/resources/shared/js/i18ntemplate.js
   M /trunk/src/chrome/browser/resources/shared/js/local_strings.js
   D /trunk/src/chrome/browser/resources/shared/js/localstrings.js
   M /trunk/src/chrome/chrome_browser.gypi

Rename a bunch of DOMUI shared resources.

BUG=None
TEST=manual

------------------------------------------------------------------------
r46025 | willchan@chromium.org | 2010-04-30 03:23:32 +0200 (Fri, 30 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/chrome_exe_main_gtk.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/test/testing_browser_process.h

Revert r46023: "Detect new instance of the browser when running in the background in persistent"
Broke the build.

Review URL: http://codereview.chromium.org/1718024
------------------------------------------------------------------------
r46023 | prasadt@chromium.org | 2010-04-30 02:57:48 +0200 (Fri, 30 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/chrome_exe_main_gtk.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/test/testing_browser_process.h

Detect new instance of the browser when running in the background in persistent
mode, shutdown and restart the new instance.  This is already done for Windows,
this CL enables the functionality for Linux.

We don't yet have a unit test for this.  Local testing is done by:
1) Reducing the timer to 30 seconds.
2) Changing BrowserList::IsInPersistentMode to return true.
3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval.
4) Running "touch" command on chrome exe to pretend there is an update.

BUG=40975
TEST=none

Review URL: http://codereview.chromium.org/1633021
------------------------------------------------------------------------
r46021 | arv@chromium.org | 2010-04-30 02:41:37 +0200 (Fri, 30 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   A /trunk/src/chrome/browser/resources/ntp/most_visited.css
   M /trunk/src/chrome/browser/resources/ntp/most_visited.js
   A /trunk/src/chrome/browser/resources/ntp/util.js
   A /trunk/src/chrome/browser/resources/shared/js/class_list.js
   A /trunk/src/chrome/browser/resources/shared/js/class_list_test.html
   M /trunk/src/tools/grit/grit/format/html_inline.py

NTP - Refactor the most visited code to uncouple it from the rest of the NTP.

The goal of this refactoring is to allow splitting the different parts of the NTP into different reusable components.

BUG=None
TEST=Manually

Review URL: http://codereview.chromium.org/1695022
------------------------------------------------------------------------
r46009 | dhg@chromium.org | 2010-04-30 01:27:07 +0200 (Fri, 30 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/mediaplayer.html

Changing the mediaplayer so it starts over when the clip is finished.
Review URL: http://codereview.chromium.org/1745004
------------------------------------------------------------------------
r46006 | feldstein@chromium.org | 2010-04-30 01:20:30 +0200 (Fri, 30 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Fix Dropping in the bookmark manager

Originally we were clearing the dragData member in a few places, including
experimental.bookmarkManager.onDrop.  This was triggered before the javascripts
drop event so when it got to that point to drop a valid bookmark, it had already
cleared itself out.  Now it just posts a task with 0ms delay to let the real
drop event handle the data before clearing it.  Also clear the data on mouse up,
which wasn't being handled in the case where you drag an element just a tiny
bit, and no action is performed.

BUG=none
TEST=Ensure you can still drop stuff in the bmm

Review URL: http://codereview.chromium.org/1780015
------------------------------------------------------------------------
r46005 | jrg@chromium.org | 2010-04-30 01:08:30 +0200 (Fri, 30 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/base/keyboard_codes_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   A /trunk/src/chrome/browser/automation/ui_controls_mac.mm
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar_browsertest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/ui_test_utils_mac.cc
   M /trunk/src/views/event.h

Implement UI automation on the Mac.

Code is untested.  From gChat:
  me: do you have a good test I can use to make sure mac impl of
    ui_controls for sending events works OK?  Or would you prefer I send
    you CLs to play with and we iterate by hand?
  Joe: I would like the CL to play with to see if I can get it to work
    with the code I wrote

Warning to Joe: mouse moved events currently use the Mac coordinate
frame (0,0 is bottom-left not top-left). That's easy to switch; I'd
like to do whatever is easiest to get WebDriver working.

BUG=26102

Review URL: http://codereview.chromium.org/1701006
------------------------------------------------------------------------
r46004 | dhg@chromium.org | 2010-04-30 01:06:56 +0200 (Fri, 30 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Changing filebrowser to append a number on the end of an existing directory.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1736006
------------------------------------------------------------------------
r45995 | arv@chromium.org | 2010-04-30 00:28:21 +0200 (Fri, 30 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Tweak the top bar behavior a bit.

Empty searches are not shown now, instead we go to "Bookmarks bar" folder.
Clicking the logo button clears the search and takes the user to the "Bookmarks bar" folder.

BUG=None
TEST=See above

Review URL: http://codereview.chromium.org/1816001
------------------------------------------------------------------------
r45991 | mrossetti@chromium.org | 2010-04-29 23:58:13 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Remove accidental #if's. Make old folder window menu go away when mousing over a non-folder bookmark in the bookmark bar.

BUG=None.
TEST=Pop up a folder bookmark item on the bookmark bar then mouse over a non-folder bookmark and verify that the old folder menu is dismissed.

Review URL: http://codereview.chromium.org/1752020
------------------------------------------------------------------------
r45986 | dhg@chromium.org | 2010-04-29 23:44:24 +0200 (Thu, 29 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   A /trunk/src/chrome/browser/extensions/extension_error_reporter.cc (from /trunk/src/chrome/common/extensions/extension_error_reporter.cc:45485)
   A /trunk/src/chrome/browser/extensions/extension_error_reporter.h (from /trunk/src/chrome/common/extensions/extension_error_reporter.h:45485)
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   A /trunk/src/chrome/browser/platform_util.h (from /trunk/src/chrome/common/platform_util.h:45485)
   A /trunk/src/chrome/browser/platform_util_chromeos.cc
   A /trunk/src/chrome/browser/platform_util_common_linux.cc
   A /trunk/src/chrome/browser/platform_util_linux.cc (from /trunk/src/chrome/common/platform_util_linux.cc:45485)
   A /trunk/src/chrome/browser/platform_util_mac.mm (from /trunk/src/chrome/common/platform_util_mac.mm:45485)
   A /trunk/src/chrome/browser/platform_util_win.cc (from /trunk/src/chrome/common/platform_util_win.cc:45485)
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   D /trunk/src/chrome/common/extensions/extension_error_reporter.cc
   D /trunk/src/chrome/common/extensions/extension_error_reporter.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   D /trunk/src/chrome/common/platform_util.h
   D /trunk/src/chrome/common/platform_util_linux.cc
   D /trunk/src/chrome/common/platform_util_mac.mm
   D /trunk/src/chrome/common/platform_util_win.cc

Changing linux platform for chromeos.  This involved moving platform_util and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1705009
------------------------------------------------------------------------
r45983 | arv@chromium.org | 2010-04-29 23:07:28 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmark_bar_folder_mac.png
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_closed.png
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_closed_rtl.png
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_open.png
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_open_rtl.png
   M /trunk/src/chrome/chrome_browser.gypi

Add shared images from bookmark manager to chrome://resources/images/

This fixes a bug where we would have missing images in the bookmark manager.

BUG=42817
TEST=Open the bookmark manager. No icons should be missing.

Review URL: http://codereview.chromium.org/1697017
------------------------------------------------------------------------
r45982 | pinkerton@chromium.org | 2010-04-29 22:59:13 +0200 (Thu, 29 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Fix dragging a tab out of a window when the only tabs left behind are phantom tabs.
BUG=42698
TEST=per bug. Might want to re-test dragging single tabs and dragging tabs out when there are pinned tabs (not phantoms).
Review URL: http://codereview.chromium.org/1727013
------------------------------------------------------------------------
r45974 | rvargas@google.com | 2010-04-29 21:14:29 +0200 (Thu, 29 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/webkit/appcache/appcache_disk_cache.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Http cache: Add support for a dedicated cache thread.

This is an interface-only change, nothing is really moving to another thread yet.

BUG=26730
TEST=none


Review URL: http://codereview.chromium.org/983007
------------------------------------------------------------------------
r45973 | skerner@chromium.org | 2010-04-29 21:09:41 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix runtime exception.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1708016
------------------------------------------------------------------------
r45971 | zork@chromium.org | 2010-04-29 20:48:52 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/dir_open_result.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h

Remove CHECK()s from directory backing store and check return values.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1739019
------------------------------------------------------------------------
r45967 | eroman@chromium.org | 2010-04-29 20:35:14 +0200 (Thu, 29 Apr 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/net_internals/dataview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/chrome_browser.gypi

Add the ability to export the captured NetLog data to a formatted text file, or to JSON.

This is similar to the display of about:net-internals, and is intended to be used when attaching log info to bug reports.

The formatting is still fairly crude, and there are some remaining TODOs.

BUG=37421

Review URL: http://codereview.chromium.org/1703018
------------------------------------------------------------------------
r45966 | estade@chromium.org | 2010-04-29 20:30:39 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.cc
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc

GTK: more signal handler foolproofing.

BUG=40735
TEST=manual clicking about, trybots

Review URL: http://codereview.chromium.org/1783010
------------------------------------------------------------------------
r45965 | mrossetti@chromium.org | 2010-04-29 20:24:32 +0200 (Thu, 29 Apr 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_unittest_helper.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_unittest_helper.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/model_test_utils.cc
   A /trunk/src/chrome/test/model_test_utils.h

Add and implement cut/copy/paste to the bookmark bar and folder context menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. Add test helpers for easing comparison of bookmark model changes.

BUG=41217,36614,32064, 41404
Add and implement cut/copy/paste to the bookmark bar and folder context menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. 

TEST=1) Present the context menu for the bookmark bar in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled.
2) Present the context menu for a folder menu in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled.
3) Perform cut/copy/paste/delete operations in a folder menu and subfolder menu and verify that the menu remains presented after the operation completes.
4) Drag a bookmark item from the bar to another location on the bar and verify that the button no longer shows up in the old location but does show up in the new location.
5) Drag a bookmark item from the bar to be within a folder located _after_ the item being dragged. Verify the bar no longer shows the bookmark item.  Verify the folder does show the bookmark item. Verify that the folder window has shifted to the left so that it remains aligned with it corresponding bar folder indicator.
6) Drag a bookmark item from the bar to be within a folder located _before_ the item being dragged. Verify the bar no longer shows the bookmark item.  Verify the folder does show the bookmark item. Verify that the folder window has _not_ shifted to the left and that it remains aligned with it corresponding bar folder indicator.
7) Drag a bookmark around within the same folder and verify that the folder window does not move.
8) Drag a bookmark item from a folder to the bar in a position _after_ the folder form which the item comes. The folder menu window should close.
9) Drag a bookmark item from a folder to a different folder and verify that the original folder closes and the new folder remains open.
10) Drag an item from a parent folder to a child folder and verify that both folders remain open. Verify that the subfolder remains aligned to its associated folder icon in the parent folder.
11) Drag an item from a child folder to a parent folder. Verify that the child folder closes and the parent folder remains open.
12) Try dragging a parent folder onto a child folder and verify that the drag is not allowed to complete.
13) Hover over a folder item in a folder menu window. Verify that the folder opens up a subview menu window. Now drag the original folder (the one being hovered over) and verify that its subfolder menu automatically closes.
14) Slowly shrink window width until "off the side" menu appears; make sure it appears as soon as the last button gets removed.  Now slowly grow window and make sure it goes away at the right time.
15) Add enough bookmarks to the bookmark bar to nearly fill the width of the window. Verify that the off-the-side chevron is not showing. Slowly shrink the width of the window until the off-the-side-chevron appears. Verify that the right-most bookmark button has disappeared and does not draw over the top of the chevron. Continue to shrink the window and verify that bookmark buttons disappear. View the contents of the chevron and verify that the bookmark buttons which previously appeared on the bar now appear in the chevron. Slowly grow the window and verify that bookmark buttons reappear without drawing over the top of the chevron. Verify that those bookmark buttons no longer appear in the chevron when it is popped up. Continue growing the window until all bookmark buttons appear in the bar and the chevron disappears.
16) Shrink the window so that the off-the-side chevron appears and contains three or more bookmarks. Pop open the chevron. Drag bookmarks up and down in the chevron menu and verify that moves and copies are performed. Drag a bar bookmark into the chevron and verify that the chevron pops up and allows the drag. Verify that the bar and chevron contents rearrange such that buttons on the bar fill but do not overflow the bar. Drag a chevron bookmark out onto the bar. Once again verify that the bar and chevron buttons rearrange such that the bar is full but not overflowing.
Review URL: http://codereview.chromium.org/1742003
------------------------------------------------------------------------
r45964 | derat@chromium.org | 2010-04-29 20:17:42 +0200 (Thu, 29 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/chromeos/DEPS
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.cc
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc

chromeos: Make Chrome use enums from libcros to talk to WM.

We currently have two copies of these enums, one in Chrome
and one in Chrome OS. I'm switching us to have a single
copy in the libcros repo.

This reverts r45955, which reverted r45952.  I've added
third_party/cros to the browser directory's DEPS file to fix
the checkdeps.py failure.

http://codereview.chromium.org/1811002/show contains the
review of the original change.

BUG=none
TEST=built it and ran checkdeps.py manually

Review URL: http://codereview.chromium.org/1705017
------------------------------------------------------------------------
r45963 | pkasting@chromium.org | 2010-04-29 20:17:29 +0200 (Thu, 29 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/base/observer_list.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

Clean up some Observer code.  Original patch by Thiago Farina (see http://codereview.chromium.org/1725007 ), r=me.

BUG=none
TEST=none
------------------------------------------------------------------------
r45962 | stuartmorgan@chromium.org | 2010-04-29 20:15:33 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/base_view.h
   M /trunk/src/chrome/browser/cocoa/base_view.mm

Enable mouse enter/exit events for the content area on Mac

Fixes mouse-exit events for plugins touching the edge of the content area; likely also fixes similar bugs in HTML.

BUG=33100
TEST=Plugins should receive mouse exit events on edges touching the content area edge.

Review URL: http://codereview.chromium.org/1774014
------------------------------------------------------------------------
r45957 | jcivelli@chromium.org | 2010-04-29 19:57:17 +0200 (Thu, 29 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   A /trunk/src/chrome/browser/views/location_bar (from /trunk/src/chrome/browser/views/location_bar:45936)
   D /trunk/src/chrome/browser/views/location_bar_view.cc
   D /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Relanding http://codereview.chromium.org/1746009/show
(fixed the ChromeOS build).

The app launcher now uses the location bar (instead of the autocomplete edit), so
it has "tab to search" and the icons on the left side,
Also split location_bar_view.cc so that every inner-class gets its own .h and .cc
file.

BUG=None
TEST=Make sure the location bar works as expected (tab to search, bookmark star,
page actions...).
Open the app launcher, make sure "tab to search" works as expected.
	 
Review URL: http://codereview.chromium.org/1792010
------------------------------------------------------------------------
r45956 | nirnimesh@chromium.org | 2010-04-29 19:56:47 +0200 (Thu, 29 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   M /trunk/src/chrome/test/functional/prefs.py
   A /trunk/src/chrome/test/pyautolib/prefs_info.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py
   M /trunk/src/chrome/test/pyautolib/pyautolib.i

Add automation hooks for setting/gettting preferences.

Add a test which excercises this, update old test.

Also,
  - Remove some old prefs hooks. They were not easy to use and required the user to know what a preference type was, with no way of listing them out.
  - replace if-else statements for json handlers with a map.
  - Fix json error strings. json prefers " over ' (automation_provider.cc)

BUG=42701
TEST=python chrome/test/functional/prefs.py

Review URL: http://codereview.chromium.org/1712019
------------------------------------------------------------------------
r45955 | willchan@chromium.org | 2010-04-29 19:53:22 +0200 (Thu, 29 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/DEPS
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.cc
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc

Revert r45952: broke checkdeps.

Review URL: http://codereview.chromium.org/1692017
------------------------------------------------------------------------
r45954 | cmasone@google.com | 2010-04-29 19:50:06 +0200 (Thu, 29 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/base/nss_util.cc
   M /trunk/src/base/nss_util.h
   A /trunk/src/base/nss_util_internal.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/net/base/keygen_handler_nss.cc
   M /trunk/src/net/base/keygen_handler_unittest.cc

Enable Chrome OS to load the user's nssdb later.
Review URL: http://codereview.chromium.org/1730001
------------------------------------------------------------------------
r45953 | maruel@chromium.org | 2010-04-29 19:44:42 +0200 (Thu, 29 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/process.h
   A /trunk/src/base/process_util.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/base/shared_memory.h
   M /trunk/src/chrome/browser/memory_details_mac.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/process_singleton_win_uitest.cc
   M /trunk/src/chrome/test/chrome_process_util.cc
   M /trunk/src/chrome_frame/test_utils.cc

Move common code into process_util.cc.
Fix namespace usage.
Change ProcessEntry to have a common interface accross platforms and change ProcessFilter::Includes() to make use of it.
Split NamedProcessIterator in two.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1689012
------------------------------------------------------------------------
r45952 | derat@chromium.org | 2010-04-29 19:26:54 +0200 (Thu, 29 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/DEPS
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   M /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   M /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.cc
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc

chromeos: Make Chrome use enums from libcros to talk to WM.

We currently have two copies of these enums, one in Chrome
and one in Chrome OS.  I'm switching us to have a single
copy in the libcros repo.

BUG=none
TEST=built it

Review URL: http://codereview.chromium.org/1811002
------------------------------------------------------------------------
r45950 | finnur@chromium.org | 2010-04-29 19:20:24 +0200 (Thu, 29 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Minor polish to the Extensions management page.

The space after the extension name was included in the
link.

BUG=29739
TEST=chrome://extensions, make sure the link does not
contain a space.

Review URL: http://codereview.chromium.org/1699025
------------------------------------------------------------------------
r45948 | phajdan.jr@chromium.org | 2010-04-29 19:14:16 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Mark ExtensionApiTest.Incognito as flaky.

TBR=mpcomplete

TEST=flaky
BUG=42844

Review URL: http://codereview.chromium.org/1705014
------------------------------------------------------------------------
r45947 | phajdan.jr@chromium.org | 2010-04-29 19:08:13 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Mark ExtensionTestBrowserEvents.RunTest as flaky.

TBR=rogerta

TEST=flaky
BUG=37554

Review URL: http://codereview.chromium.org/1695024
------------------------------------------------------------------------
r45939 | viettrungluu@chromium.org | 2010-04-29 18:31:43 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc

Get rid of BookmarkEditor::Handler entirely.

(Part of aftermath of eliminating the native bookmark managers.)

BUG=38908
TEST=everything keeps working

Review URL: http://codereview.chromium.org/1745021
------------------------------------------------------------------------
r45937 | jcivelli@chromium.org | 2010-04-29 18:15:49 +0200 (Thu, 29 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   D /trunk/src/chrome/browser/views/location_bar
   A /trunk/src/chrome/browser/views/location_bar_view.cc (from /trunk/src/chrome/browser/views/location_bar_view.cc:45935)
   A /trunk/src/chrome/browser/views/location_bar_view.h (from /trunk/src/chrome/browser/views/location_bar_view.h:45935)
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 45936 - The app launcher now uses the location bar (instead of the autocomplete edit), so
it has "tab to search" and the icons on the left side,
Also split location_bar_view.cc so that every innerclass gets its own .h and .cc
file.

BUG=None
TEST=Make sure the location bar works as expected (tab to search, bookmark star,
     page actions...).
     Open the app launcher, make sure "tab to search" works as expected.

Review URL: http://codereview.chromium.org/1746009

TBR=jcivelli@google.com
Review URL: http://codereview.chromium.org/1737021
------------------------------------------------------------------------
r45936 | jcivelli@google.com | 2010-04-29 18:07:48 +0200 (Thu, 29 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   A /trunk/src/chrome/browser/views/location_bar
   A /trunk/src/chrome/browser/views/location_bar/click_handler.cc
   A /trunk/src/chrome/browser/views/location_bar/click_handler.h
   A /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.cc
   A /trunk/src/chrome/browser/views/location_bar/content_setting_image_view.h
   A /trunk/src/chrome/browser/views/location_bar/ev_bubble_view.cc
   A /trunk/src/chrome/browser/views/location_bar/ev_bubble_view.h
   A /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.cc
   A /trunk/src/chrome/browser/views/location_bar/icon_label_bubble_view.h
   A /trunk/src/chrome/browser/views/location_bar/keyword_hint_view.cc
   A /trunk/src/chrome/browser/views/location_bar/keyword_hint_view.h
   A /trunk/src/chrome/browser/views/location_bar/location_bar_view.cc (from /trunk/src/chrome/browser/views/location_bar_view.cc:45584)
   A /trunk/src/chrome/browser/views/location_bar/location_bar_view.h (from /trunk/src/chrome/browser/views/location_bar_view.h:45584)
   A /trunk/src/chrome/browser/views/location_bar/location_icon_view.cc
   A /trunk/src/chrome/browser/views/location_bar/location_icon_view.h
   A /trunk/src/chrome/browser/views/location_bar/page_action_image_view.cc
   A /trunk/src/chrome/browser/views/location_bar/page_action_image_view.h
   A /trunk/src/chrome/browser/views/location_bar/page_action_with_badge_view.cc
   A /trunk/src/chrome/browser/views/location_bar/page_action_with_badge_view.h
   A /trunk/src/chrome/browser/views/location_bar/selected_keyword_view.cc
   A /trunk/src/chrome/browser/views/location_bar/selected_keyword_view.h
   A /trunk/src/chrome/browser/views/location_bar/star_view.cc
   A /trunk/src/chrome/browser/views/location_bar/star_view.h
   D /trunk/src/chrome/browser/views/location_bar_view.cc
   D /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi

The app launcher now uses the location bar (instead of the autocomplete edit), so
it has "tab to search" and the icons on the left side,
Also split location_bar_view.cc so that every inner-class gets its own .h and .cc
file.

BUG=None
TEST=Make sure the location bar works as expected (tab to search, bookmark star,
     page actions...).
     Open the app launcher, make sure "tab to search" works as expected.

Review URL: http://codereview.chromium.org/1746009
------------------------------------------------------------------------
r45931 | jeremy@chromium.org | 2010-04-29 16:06:14 +0200 (Thu, 29 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Cleanup: Rename OnLoadFont->OnPreCacheFont

I'm working on a Mac specific change where we'll need an IPC message to load a font and pass the font data back to the renderer process.

To prevent confusion this CL preemptively renames a Windows message which actually causes a font to be cached by the browser.

The distinction between these two operations is subtle but I thought it best to try to prevent future confusion by making sure the IPC messages don't have similar names.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1805002
------------------------------------------------------------------------
r45920 | oshima@chromium.org | 2010-04-29 09:39:23 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h

Adding dchecks that may help diagnose the issue http://crosbug.com/2743

BUG=http://crosbug.com/2743
TEST=none

Review URL: http://codereview.chromium.org/1711017
------------------------------------------------------------------------
r45919 | oshima@chromium.org | 2010-04-29 09:37:48 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc

Memory leak fix.
  We're releasing panel controller but never deleted.
Handle edge case where a renderer requests resize after the panel is closed.

BUG=none
TEST=added new test case TestCloseOpen to verify it.

Review URL: http://codereview.chromium.org/1687011
------------------------------------------------------------------------
r45918 | nick@chromium.org | 2010-04-29 08:25:41 +0200 (Thu, 29 Apr 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   D /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_test_util.cc
   D /trunk/src/net/tools/testserver/chromiumsync.py
   D /trunk/src/net/tools/testserver/chromiumsync_test.py
   M /trunk/src/net/tools/testserver/testserver.py
   D /trunk/src/third_party/protobuf2/__init__.py
   D /trunk/src/third_party/protobuf2/descriptor_pb2.py
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Revert 45916 - Python implementation of sync server, for testing.

Implement the server side of chromium sync inside of testserver.py.  The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.

Make the sync_integration_tests run by default against the test server.  An externallyprovided syncurl will give the old behavior.

Protocol buffers stuff: The test sync server requires Python generated code for .proto files.  I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf).  This might be a bad place, or a bad name  open to suggestions.  The main thing is that there will be runtime dependencies on it, so it didn't seem right to put it in obj/.

Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory.  The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.

Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port.  Very useful if a test failure leaves a server running.  Tested this against all combos of protocols, and it seems to work.

Flakiness fix: Port sync_integration_tests to the outofprocess test runner.

Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.

BUG=20905,40980

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708

Review URL: http://codereview.chromium.org/1622012

TBR=nick@chromium.org
------------------------------------------------------------------------
r45917 | viettrungluu@chromium.org | 2010-04-29 08:03:48 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Remove some more BookmarkEditor::Handlers (in Mac code this time).

(Continuing aftermath of native bookmark manager removal....)

BUG=38908
TEST=everything continues to work

Review URL: http://codereview.chromium.org/1747020
------------------------------------------------------------------------
r45916 | nick@chromium.org | 2010-04-29 07:52:50 +0200 (Thu, 29 Apr 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_test_util.cc
   A /trunk/src/net/tools/testserver/chromiumsync.py
   A /trunk/src/net/tools/testserver/chromiumsync_test.py
   M /trunk/src/net/tools/testserver/testserver.py
   A /trunk/src/third_party/protobuf2/__init__.py
   A /trunk/src/third_party/protobuf2/descriptor_pb2.py
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Python implementation of sync server, for testing.

Implement the server side of chromium sync inside of testserver.py.  The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.

Make the sync_integration_tests run by default against the test server.  An externally-provided --sync-url will give the old behavior.

Protocol buffers stuff: The test sync server requires Python generated code for .proto files.  I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf).  This might be a bad place, or a bad name -- open to suggestions.  The main thing is that there will be run-time dependencies on it, so it didn't seem right to put it in obj/.

Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory.  The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.

Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port.  Very useful if a test failure leaves a server running.  Tested this against all combos of protocols, and it seems to work.

Flakiness fix: Port sync_integration_tests to the out-of-process test runner.

Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.

BUG=20905,40980

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708

Review URL: http://codereview.chromium.org/1622012
------------------------------------------------------------------------
r45915 | sky@chromium.org | 2010-04-29 07:37:53 +0200 (Thu, 29 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h

Revert 45906 - Relands your patch to have an option for enabling vertical tabs. I've
added the following additions:
. made the layout work for opaque_browser_frame.
. Only show the menu if the user supplied enableverticaltabs.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1708014

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1795010
------------------------------------------------------------------------
r45914 | aa@chromium.org | 2010-04-29 06:41:37 +0200 (Thu, 29 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Re-land 45894. http://codereview.chromium.org/1732015

TBR=erikkay@chromium.org

Review URL: http://codereview.chromium.org/1705012
------------------------------------------------------------------------
r45908 | feldstein@chromium.org | 2010-04-29 05:35:23 +0200 (Thu, 29 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/page_menu_model.cc

Change report bad webpage to be a web tab instead of native dialog

Change all 3 implementations of the report broken page dialog to just use one
web form.

BUG=none
TEST=Make sure you can report bad pages on each platform

Review URL: http://codereview.chromium.org/1737016
------------------------------------------------------------------------
r45907 | sanjeevr@chromium.org | 2010-04-29 05:31:34 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/base.gypi
   A /trunk/src/base/message_loop_proxy.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc

Created a MessageLoopProxy interface. This provides a thread-safe refcounted interface to the Post* methods
 of a message loop. This class can outlive the target message loop. Changed ChromeThread to vend an implementation of this proxy.
BUG=None
TEST=ChromeThread unit-tests modified.

Review URL: http://codereview.chromium.org/1800008
------------------------------------------------------------------------
r45906 | sky@chromium.org | 2010-04-29 05:20:27 +0200 (Thu, 29 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h

Relands your patch to have an option for enabling vertical tabs. I've
added the following additions:
. made the layout work for opaque_browser_frame.
. Only show the menu if the user supplied --enable-vertical-tabs.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1708014
------------------------------------------------------------------------
r45902 | sky@chromium.org | 2010-04-29 03:55:38 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Nukes one of the AddTabWithURL variants.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1736022
------------------------------------------------------------------------
r45901 | arv@chromium.org | 2010-04-29 03:25:35 +0200 (Thu, 29 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmarks_section_32.png
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Update layout of the header part.

Remove the search button, use input[type=search] and set a placeholder text.

BUG=42214
TEST=Open bookmarks manager and do some searching


Review URL: http://codereview.chromium.org/1737020
------------------------------------------------------------------------
r45900 | estade@chromium.org | 2010-04-29 03:23:55 +0200 (Thu, 29 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: avoid a dcheck

don't use an OwnedWidgetGtk for GtkWindows, which are no longer floating by the time the constructor returns.

BUG=42807
TEST=launch a debug build in a compositing window manager

Review URL: http://codereview.chromium.org/1795009
------------------------------------------------------------------------
r45898 | aa@chromium.org | 2010-04-29 03:12:46 +0200 (Thu, 29 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Revert 45894 - First cut at window affinity for apps. Window affinity means that app URLs tend to open in the window associated with them, and nonapp URLs tend to not open in app windows.

After playing with this first attempt, I find it is unsatisfying because spreadsheets.google.com doesn't open in the docs app (different origin) and logging out of gmail directs you back to the browser.

So I'm going to fix that by adding a browse extent, separately.

But I still think this is a worthwhile stepping stone to check in.

Review URL: http://codereview.chromium.org/1732015

TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/1759013
------------------------------------------------------------------------
r45894 | aa@chromium.org | 2010-04-29 03:03:07 +0200 (Thu, 29 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

First cut at window affinity for apps. Window affinity means that app URLs tend to open in the window associated with them, and non-app URLs tend to not open in app windows.

After playing with this first attempt, I find it is unsatisfying because spreadsheets.google.com doesn't open in the docs app (different origin) and logging out of gmail directs you back to the browser.

So I'm going to fix that by adding a browse extent, separately.

But I still think this is a worthwhile stepping stone to check in.

Review URL: http://codereview.chromium.org/1732015
------------------------------------------------------------------------
r45887 | creis@chromium.org | 2010-04-29 02:11:40 +0200 (Thu, 29 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Relax the DOM UI navigation CHECK.

We ensure that non-DOM-UI URLs are not sent to DOM UI renderers.
This patch makes an exception for about:blank, which can happen
if the user gets the renderer to go to any about: URL (e.g.,
using the web inspector).

BUG=42547
TEST=Type location='about:cache' into NTP's web inspector, then Reload.

Review URL: http://codereview.chromium.org/1790005
------------------------------------------------------------------------
r45885 | feldstein@chromium.org | 2010-04-29 01:52:56 +0200 (Thu, 29 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   D /trunk/src/chrome/browser/resources/bookmark_manager/css/list.css
   D /trunk/src/chrome/browser/resources/bookmark_manager/css/menu.css
   D /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css
   D /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/event.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget_test.html
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/linkcontroller.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/linkcontroller_test.html
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise_test.html
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/command.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/contextmenuhandler.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listitem.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menu.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menubutton.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menuitem.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/splitter.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr_test.html
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/i18ntemplate.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/localstrings.js
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/util.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json
   A /trunk/src/chrome/browser/resources/shared/css
   A /trunk/src/chrome/browser/resources/shared/css/list.css (from /trunk/src/chrome/browser/resources/bookmark_manager/css/list.css:45879)
   A /trunk/src/chrome/browser/resources/shared/css/menu.css (from /trunk/src/chrome/browser/resources/bookmark_manager/css/menu.css:45879)
   A /trunk/src/chrome/browser/resources/shared/css/tree.css (from /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css:45879)
   A /trunk/src/chrome/browser/resources/shared/css/tree.css.js (from /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr
   A /trunk/src/chrome/browser/resources/shared/js/cr/event.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/event.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/eventtarget.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/eventtarget_test.html (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget_test.html:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/linkcontroller.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/linkcontroller.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/linkcontroller_test.html (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/linkcontroller_test.html:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/promise.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/promise_test.html (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise_test.html:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/command.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/command.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/contextmenuhandler.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/contextmenuhandler.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/list.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/listitem.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listitem.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/listselectionmodel.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/menu.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menu.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/menubutton.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menubutton.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/menuitem.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menuitem.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/splitter.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/splitter.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui/tree.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr/ui.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/cr_test.html (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr_test.html:45879)
   A /trunk/src/chrome/browser/resources/shared/js/i18ntemplate.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/i18ntemplate.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/localstrings.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/localstrings.js:45879)
   A /trunk/src/chrome/browser/resources/shared/js/util.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/util.js:45879)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   A /trunk/src/chrome/test/data/extensions/manifest_tests/permission_chrome_resources_url.json

Rework of the shared resources patch for checkin

Implement shared resources and use them in bookmark manager

I had an issue with git when moving files so i had to create a new patch to
delete/readd them here.  See code review 1564034.  This is just for
trybots/checkins.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1694019
------------------------------------------------------------------------
r45884 | snej@chromium.org | 2010-04-29 01:48:46 +0200 (Thu, 29 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager.cc

Fix memory leak introduced in r45841.
BUG=none
TEST=PasswordManagerTest::FormSubmitFailedLogin + valgrind

Review URL: http://codereview.chromium.org/1795008
------------------------------------------------------------------------
r45877 | rafaelw@chromium.org | 2010-04-29 00:53:11 +0200 (Thu, 29 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/window_container_type.cc
   A /trunk/src/chrome/common/window_container_type.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

This is the second side of a multi-sided webkit patch that will allow experimental window.open feature strings to be captured and passed to the client.

It should wait for: https://bugs.webkit.org/show_bug.cgi?id=38013 to land. This is required because this patch needs to use the WebWindowFeature binding struct in WebKit.

Once this is landed, a webkit patch to change the call signature for WebViewClient::createView to include the WebWindowFeatures will be submitted (and after that another chromium patch to remove the old call signature).

This patch implements old and new WebViewClient::createView signatures, and additionally passes the vector all the way to RenderViewHostDelegateHelper who will eventually use it to observe the 'background' feature.

BUG=41275
TEST=all tests should pass

Review URL: http://codereview.chromium.org/1758004
------------------------------------------------------------------------
r45875 | dimich@chromium.org | 2010-04-29 00:52:15 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Fix browser process crash in WorkerTest.WorkerContextMultiPort.
Also enable that test. Crash caused by using stl::map[unexisting_key] which inserts a dummy element. Added a check.
BUG=42783
TEST=WorkerTest.WorkerContextMultiPort

Review URL: http://codereview.chromium.org/1737019
------------------------------------------------------------------------
r45874 | aa@chromium.org | 2010-04-29 00:51:59 +0200 (Thu, 29 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Always use opaque frame for extension app windows. It hasn't been implemented for the glass frame yet.

Review URL: http://codereview.chromium.org/1727009
------------------------------------------------------------------------
r45873 | albertb@chromium.org | 2010-04-29 00:46:24 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/common/notification_type.h

Re-land 1752007: Send out notifications when logins are changed through PasswordStoreMac so that the sync backend can register as an observer.

BUG=35038
TEST=none

Review URL: http://codereview.chromium.org/1803006
------------------------------------------------------------------------
r45872 | oshima@chromium.org | 2010-04-29 00:46:16 +0200 (Thu, 29 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_speech_synthesis_library.h
   A /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/speech_synthesis_library.h
   M /trunk/src/chrome/chrome_browser.gypi

Adding speech synthesis library to access TTS feature in libcros.

The patch contributed by chaitanya@chromium.org
Original review URL: http://codereview.chromium.org/1775006

Review URL: http://codereview.chromium.org/1774013
------------------------------------------------------------------------
r45871 | erg@chromium.org | 2010-04-29 00:42:17 +0200 (Thu, 29 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

GTK: Put options dialogs in a different window group.

GTK grabs work on a per window group basis, so when a modal dialog comes up
(which performs a grab) and the user then clicks on something in the main
browser window that spawns an InfoBubble, the InfoBubble's code that handles
hiding the currently grabbed widget will hide the modal dialog and it is lost
until restart.

Since we need to remove the centering in ContentSettingsWindowGtk for this to
work, also change the centering behaviour for FontsLanguagesWindowGtk, which
has bothered me for a while.

BUG=41815
TEST=none

Review URL: http://codereview.chromium.org/1727012
------------------------------------------------------------------------
r45867 | gspencer@chromium.org | 2010-04-28 23:55:47 +0200 (Wed, 28 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc

This fixes an InvalidRead error that valgrind found.

TEST=ran valgrind on chromeos version of chrome.
BUG=none
Review URL: http://codereview.chromium.org/1807006
------------------------------------------------------------------------
r45863 | erikkay@chromium.org | 2010-04-28 23:36:46 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc

fix linux build

TEST=none
TBR=aa

Review URL: http://codereview.chromium.org/1705011
------------------------------------------------------------------------
r45862 | erikkay@chromium.org | 2010-04-28 23:21:53 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_fullscreen_invalid.json

fullscreen window app launch container

BUG=42447
TEST=none

Review URL: http://codereview.chromium.org/1730013
------------------------------------------------------------------------
r45854 | xiyuan@chromium.org | 2010-04-28 22:29:41 +0200 (Wed, 28 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/tooltip_manager_gtk.cc
   M /trunk/src/views/widget/tooltip_manager_gtk.h
   A /trunk/src/views/widget/tooltip_window_gtk.cc
   A /trunk/src/views/widget/tooltip_window_gtk.h

Use customized RGBA-enabled tooltip window for tooltip on ChroemOS

- Add a TooltipWindowGtk which uses RGBA colormap and has a label;
- Use TooltipWindowGtk for tooltip for both WidgetGtk and
  RenderWidgetHostViewGtk

After this change, we will get back shadow and rounded corner for tooltip
in theme engine.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1708015
------------------------------------------------------------------------
r45851 | eroman@chromium.org | 2010-04-28 22:12:27 +0200 (Wed, 28 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_unittest.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/init_proxy_resolver.cc
   M /trunk/src/net/proxy/init_proxy_resolver.h
   M /trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session_unittest.cc
   M /trunk/src/net/spdy/spdy_stream_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing NULL in place of a const BoundNetLog&.

BUG=37421
Review URL: http://codereview.chromium.org/1783008
------------------------------------------------------------------------
r45850 | estade@chromium.org | 2010-04-28 22:02:56 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/hover_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/hover_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h

GTK: make more use of gtk_signal convenience macros/signal registrar.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1708013
------------------------------------------------------------------------
r45849 | mpcomplete@chromium.org | 2010-04-28 21:59:54 +0200 (Wed, 28 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc

Force extensions to run in their shared processes, even with --process-per-tab.

BUG=36617

Review URL: http://codereview.chromium.org/1723016
------------------------------------------------------------------------
r45847 | dhollowa@chromium.org | 2010-04-28 21:53:03 +0200 (Wed, 28 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm

Mac BookmarkBubbleController updateBookmarkNode crash.

It is possible that due to model change the bookmark bubble window has been closed
but the popup is still showing and able to notify the controller of a folder change.
We ignore the sender in this case.

A better fix would be to close the popup programatically, but this is not a cocoa-friendly
thing to do.  I recommend this fix for M5, and for M6 we revisit to close the popup.

BUG=41257, 42766
TEST=Manual testing according to but report.  Requires two machines.  Will only crash under 10.6.

Review URL: http://codereview.chromium.org/1739015
------------------------------------------------------------------------
r45846 | estade@chromium.org | 2010-04-28 21:47:13 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: Add a drag icon for site icon drags.

BUG=42147
TEST=manual

Review URL: http://codereview.chromium.org/1725011
------------------------------------------------------------------------
r45841 | snej@chromium.org | 2010-04-28 21:20:41 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Fix password mgr heuristics for sites that keep the login form around after signin
The test for whether the login form reappeared on the next page load now ignores invisible forms.
BUG=28911
TEST=none (manual testing with reduced web pages)

Review URL: http://codereview.chromium.org/1656005
------------------------------------------------------------------------
r45832 | pinkerton@chromium.org | 2010-04-28 20:11:45 +0200 (Wed, 28 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Make sure to check for in-progress downloads when quitting. Adds back in code
removed during quit refactoring.
BUG=41675
TEST=quit while downloading, can cancel and quit app, as well as cancel the quit to allow the download to complete. When download completes, closing all windows shouldn't quit (normal behavior).
Review URL: http://codereview.chromium.org/1746013
------------------------------------------------------------------------
r45824 | gspencer@chromium.org | 2010-04-28 19:26:49 +0200 (Wed, 28 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/app/surface/transport_dib.h
   M /trunk/src/app/x11_util.cc
   M /trunk/src/app/x11_util.h
   M /trunk/src/base/file_descriptor_posix.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   A /trunk/src/chrome/browser/chromeos/wm_overview_controller.cc
   A /trunk/src/chrome/browser/chromeos/wm_overview_controller.h
   A /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.cc
   A /trunk/src/chrome/browser/chromeos/wm_overview_snapshot.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/gfx/skbitmap_operations.h
   M /trunk/src/views/widget/widget_gtk.cc

This adds in the ability for Chrome to generate windows with snapshots
of all currently open tabs in all browsers.

This is needed for overview mode on ChromeOS.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=1170
TEST=Ran Chrome under ChromeOS with updated window manager.
Review URL: http://codereview.chromium.org/661237
------------------------------------------------------------------------
r45818 | erg@chromium.org | 2010-04-28 19:02:23 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

GTK: The cookie prompt should allow the user to set expire date for HTML cookies

BUG=42403
TEST=none

Review URL: http://codereview.chromium.org/1774005
------------------------------------------------------------------------
r45817 | erg@chromium.org | 2010-04-28 18:52:30 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc

GTK: Make content options window non-resizable.

BUG=41341
TEST=none

Review URL: http://codereview.chromium.org/1758011
------------------------------------------------------------------------
r45816 | albertb@chromium.org | 2010-04-28 18:50:40 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/crypto/symmetric_key_mac.cc
   M /trunk/src/chrome/browser/sync/util/nigori.h

Make the Nigori user salt key 128-bits to be FIPS compliant.

BUG=none
TEST=NigoriTest.*

Review URL: http://codereview.chromium.org/1697010
------------------------------------------------------------------------
r45813 | viettrungluu@chromium.org | 2010-04-28 18:46:35 +0200 (Wed, 28 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc

Get rid of BookmarkEditor::Show()'s BookmarkEditor::Handler argument.

Still to do: get rid of things which hang on to a handler just so they can pass
it to Show().

BUG=38908
TEST=everything still works

Review URL: http://codereview.chromium.org/1795007
------------------------------------------------------------------------
r45812 | finnur@chromium.org | 2010-04-28 18:41:03 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fix HighlightCloseButton crash.

BUG=42737
TEST=Don't have it consistently repro'ing (nor a test case for it).

Review URL: http://codereview.chromium.org/1687016
------------------------------------------------------------------------
r45808 | xiyuan@chromium.org | 2010-04-28 18:02:04 +0200 (Wed, 28 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc

Fix the missing gtk options bug.

Native gtk options pages rely on host to call gtk_widget_show_all. Doing
this after options dialog's size allocated. This is because the
WrapLabelAtAllocationHack trick in ContentPageGtk needs container's size
allocated when the label is being shown.

BUG=<http://crosbug.com/2859>
TEST=Verify fix for ChromeOS issue 2859 and in sync status message in "Peronal Stuff" tab is wrapped correctly.

Review URL: http://codereview.chromium.org/1773006
------------------------------------------------------------------------
r45807 | finnur@chromium.org | 2010-04-28 17:43:23 +0200 (Wed, 28 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Reland: Link the name of the extension on the management page to the
gallery page, if the extension is from the gallery.

BUG=29739
TEST=Install a gallery extension and a third-party extension and make sure the
gallery extension name is a link (whereas the third party extension name is
static text).

Review URL: http://codereview.chromium.org/1780009
------------------------------------------------------------------------
r45804 | sky@chromium.org | 2010-04-28 17:01:54 +0200 (Wed, 28 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Adds comment to AdjustTextForCopy. I saw your request for a
description after I landed the change.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1734011
------------------------------------------------------------------------
r45803 | jorlow@chromium.org | 2010-04-28 16:09:41 +0200 (Wed, 28 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Mark tests that started failing after WebKit roll as DISABLED
and not FLAKY, because they fail every time.

TEST=none
BUG=42641,42718 

Review URL: http://codereview.chromium.org/1725012
------------------------------------------------------------------------
r45801 | bulach@chromium.org | 2010-04-28 15:26:29 +0200 (Wed, 28 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Marks TestEvalOnCallFrame, TestSetBreakpoint, QueuedSharedWorkerShutdown as flaky.

(they started failing after rolling WebKit 58304:58400 on
http://src.chromium.org/viewvc/chrome?view=rev&revision=45795)

BUG=42641,42718

Review URL: http://codereview.chromium.org/1801005
------------------------------------------------------------------------
r45779 | dhollowa@chromium.org | 2010-04-28 04:35:04 +0200 (Wed, 28 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_hover_state_unittest.mm

Mac Bookmarks hover unit tests leak.

Removes extra retains in unit tests that are now unneeded.  Triggered valgrind report.

BUG=42051
TEST=BookmarkBarFolderHoverStateTest.HoverState

Review URL: http://codereview.chromium.org/1756016
------------------------------------------------------------------------
r45778 | estade@chromium.org | 2010-04-28 04:27:48 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc

GTK: make tabbed bookmark manager compatible with more types of drops.

BUG=42466
TEST=see bug. Also, drags from firefox bookmark bar to tabbed bookmark manager should work.

Review URL: http://codereview.chromium.org/1691018
------------------------------------------------------------------------
r45776 | viettrungluu@chromium.org | 2010-04-28 04:12:07 +0200 (Wed, 28 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   D /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_manager.h
   D /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   D /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   D /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   D /trunk/src/chrome/browser/views/bookmark_folder_tree_view.h
   D /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   D /trunk/src/chrome/browser/views/bookmark_manager_view.h
   D /trunk/src/chrome/browser/views/bookmark_table_view.cc
   D /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Windows/Views: delete native bookmark manager code.

Context menu code still needs cleanup/refactoring.
String resources still need to be deleted.

BUG=38908
TEST=everything still works

Review URL: http://codereview.chromium.org/1730015
------------------------------------------------------------------------
r45773 | evan@chromium.org | 2010-04-28 03:50:30 +0200 (Wed, 28 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/manpage.1.in
   M /trunk/src/chrome/browser/browser_about_handler.cc

linux: unify proxy config docs

We had some info in the man page and other info in the about page.
This change makes the about page refer to the man page, and updates
the man page with missing info.

While I'm at it, make the HTML slightly prettier.

Review URL: http://codereview.chromium.org/1695023
------------------------------------------------------------------------
r45765 | evan@chromium.org | 2010-04-28 02:52:09 +0200 (Wed, 28 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/tools/licenses.py

licenses: don't double-include NSS in about:credits

Just manually blacklist one of the copies.  We already do
this for some other modules.

BUG=42663

Review URL: http://codereview.chromium.org/1803004
------------------------------------------------------------------------
r45751 | finnur@chromium.org | 2010-04-28 01:24:51 +0200 (Wed, 28 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Revert 45749 - (missing test fix)

Link the name of the extension on the management page to the
gallery page, if the extension is from the gallery.

BUG=29739
TEST=Install a gallery extension and a thirdparty extension and make sure the gallery extension name is a link (whereas the third party extension name is static text).

Review URL: http://codereview.chromium.org/1792006

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/1807001
------------------------------------------------------------------------
r45750 | eroman@chromium.org | 2010-04-28 01:20:45 +0200 (Wed, 28 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_util.cc
   M /trunk/src/net/base/net_log_util_unittest.cc
   M /trunk/src/net/proxy/init_proxy_resolver.cc
   M /trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socks5_client_socket.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/url_request/url_request.cc

Cleanup: Address some of the todos in net_log.h
 - Get rid of the AddString() and AddStringLiteral() methods.
 - Make EventParameters able to serialize to JSON, instead of a string.

BUG=37421

Review URL: http://codereview.chromium.org/1716007
------------------------------------------------------------------------
r45749 | finnur@chromium.org | 2010-04-28 01:20:42 +0200 (Wed, 28 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Link the name of the extension on the management page to the
gallery page, if the extension is from the gallery.

BUG=29739
TEST=Install a gallery extension and a third-party extension and make sure the gallery extension name is a link (whereas the third party extension name is static text).

Review URL: http://codereview.chromium.org/1792006
------------------------------------------------------------------------
r45748 | jcivelli@google.com | 2010-04-28 01:19:47 +0200 (Wed, 28 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   A /trunk/src/chrome/browser/importer/firefox_proxy_settings.cc
   A /trunk/src/chrome/browser/importer/firefox_proxy_settings.h
   A /trunk/src/chrome/browser/importer/firefox_proxy_settings_unittest.cc
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/firefox3_pref.js

Adding a way to retrieve Firefox proxy settings.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1703010
------------------------------------------------------------------------
r45747 | sky@chromium.org | 2010-04-28 01:15:23 +0200 (Wed, 28 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Changes mac to call into AutocompleteEditModel method for
determining text to copy to clipboard.

BUG=41493
TEST=see bug

Review URL: http://codereview.chromium.org/1765008
------------------------------------------------------------------------
r45741 | avi@chromium.org | 2010-04-27 23:29:29 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm

Explicitly tag the "cancel" button as being triggered by escape.

BUG=http://crbug.com/42321
TEST=as in bug

Review URL: http://codereview.chromium.org/1758012
------------------------------------------------------------------------
r45740 | dhollowa@chromium.org | 2010-04-27 23:25:28 +0200 (Tue, 27 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm

Crash: Moving bookmarks into subfolder in incognito window

Fixes issue with bookmark hover where button target is dealloc'd without properly
cancelling delayed hover button open.

BUG=42051
TEST=Manual according to steps in bug.

Review URL: http://codereview.chromium.org/1706017
------------------------------------------------------------------------
r45738 | asargent@chromium.org | 2010-04-27 23:21:34 +0200 (Tue, 27 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   A /trunk/src/chrome/browser/extensions/test_extension_prefs.cc
   A /trunk/src/chrome/browser/extensions/test_extension_prefs.h
   M /trunk/src/chrome/chrome_tests.gypi

Adding ExtensionPrefs methods for storing update-when-idle data.

This includes adding a few methods to ExtensionPrefs that I'm going to need to
use inside ExtensionUpdater for implementing the "do updates at idle" feature.
Instead of adding more call-through stubs to the interface that 
ExtensionsService providers to the ExtensionUpdater, I instead decided it was 
time to do some refactoring to expose a ExtensionPrefs getter in the interface.

TEST=(Should be covered by unit/browser tests)
BUG=37971


Review URL: http://codereview.chromium.org/1695018
------------------------------------------------------------------------
r45731 | finnur@chromium.org | 2010-04-27 20:59:59 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/tab_inactive_nano_center.png
   A /trunk/src/chrome/app/theme/tab_inactive_nano_left.png
   A /trunk/src/chrome/app/theme/tab_inactive_nano_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Now drawing background for inactive app tabs.

BUG=None
TEST=Visual inspection.

Review URL: http://codereview.chromium.org/1701015
------------------------------------------------------------------------
r45725 | yusukes@chromium.org | 2010-04-27 20:10:30 +0200 (Tue, 27 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/language_pinyin_config_view.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi

Adding a configuration dialog for Pinyin input method.

BUG=crosbug.com/491
BUG=crosbug.com/2623
TEST=manual

Review URL: http://codereview.chromium.org/1694017
------------------------------------------------------------------------
r45719 | jhawkins@chromium.org | 2010-04-27 19:37:01 +0200 (Tue, 27 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/name_field_unittest.cc
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate_helper.cc

AutoFill: Notify the renderer when the page has finished translating.  Extract
the forms once translation has occurred.  This change also includes another
variaton of the Name field, with tests.  In addition, this change fixes parsing
labels whose text element is not the first child of the label element.

BUG=41694
TEST=FormManagerTest.LabelsWithSpans,NameFieldTest.FirstLast

Review URL: http://codereview.chromium.org/1801002
------------------------------------------------------------------------
r45714 | viettrungluu@chromium.org | 2010-04-27 19:29:14 +0200 (Tue, 27 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FindBar.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   D /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   D /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm
   D /trunk/src/chrome/browser/cocoa/toolbar_button_cell_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Remove ToolbarButtonCell (and associated files).

.xib changes: change all ToolbarButtonCells to GradientButtonCells.

(Previously committed at r45698, reverted at r45703. I don't know why the local
build and the try succeeded. This time, I fixed the slightly-broken include.)

BUG=42582
TEST=builds properly *and* toolbar buttons and find bar buttons still work as before

Review URL: http://codereview.chromium.org/1762012
------------------------------------------------------------------------
r45713 | davemoore@chromium.org | 2010-04-27 19:26:58 +0200 (Tue, 27 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/onload_change_favicon.html

Add support for new webkit capability allowing us to update
favicons when changed via Javascript.

BUG=none
TEST=BrowserTest.FaviconChange

Review URL: http://codereview.chromium.org/1747015
------------------------------------------------------------------------
r45712 | albertb@chromium.org | 2010-04-27 19:17:05 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc

Delete and recreate the sync database if it is corrupt.

BUG=40020
TEST=DirectoryBackingStoreTest.Corruption

Review URL: http://codereview.chromium.org/1733008
------------------------------------------------------------------------
r45703 | avi@chromium.org | 2010-04-27 18:22:16 +0200 (Tue, 27 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FindBar.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h (from /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h:45697)
   A /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm (from /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm:45697)
   A /trunk/src/chrome/browser/cocoa/toolbar_button_cell_unittest.mm (from /trunk/src/chrome/browser/cocoa/toolbar_button_cell_unittest.mm:45697)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 45698 - Mac: Remove ToolbarButtonCell (and associated files).

.xib changes: change all ToolbarButtonCells to GradientButtonCells.

BUG=42582
TEST=toolbar buttons and find bar buttons still work as before

Review URL: http://codereview.chromium.org/1697011

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/1695020
------------------------------------------------------------------------
r45700 | sky@chromium.org | 2010-04-27 17:49:56 +0200 (Tue, 27 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Changes Linux to call into AutocompleteEditModel method for
determining text to copy to clipboard. I also added call to
WriteBookmark and fixed up setting selected_text_.

BUG=41493
TEST=make sure copy/paste from the omnibox work sanely on linux. Seriously
     though, see the three bugs for specifics.

Review URL: http://codereview.chromium.org/1801001
------------------------------------------------------------------------
r45699 | pfeldman@chromium.org | 2010-04-27 17:33:37 +0200 (Tue, 27 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

DevTools: always use theme data for devtools looks.

Review URL: http://codereview.chromium.org/1725010
------------------------------------------------------------------------
r45698 | viettrungluu@chromium.org | 2010-04-27 17:22:05 +0200 (Tue, 27 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FindBar.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   D /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   D /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm
   D /trunk/src/chrome/browser/cocoa/toolbar_button_cell_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Remove ToolbarButtonCell (and associated files).

.xib changes: change all ToolbarButtonCells to GradientButtonCells.

BUG=42582
TEST=toolbar buttons and find bar buttons still work as before

Review URL: http://codereview.chromium.org/1697011
------------------------------------------------------------------------
r45696 | agl@chromium.org | 2010-04-27 16:59:05 +0200 (Tue, 27 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/skia/ext/SkFontHost_fontconfig.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.h
   M /trunk/src/skia/skia.gyp

Skia roll 536:560

This also includes Evan's patch: http://codereview.chromium.org/1611033

This roll sits after a revert to Skia's hairline change so,
hopefully, doesn't need any rebaselines. The try servers mostly agree
although there's one (clip-path-text-and-shape.svg on Windows) that I
need to keep on eye on. (That's why I'm landing this before MTV is
active.)
------------------------------------------------------------------------
r45694 | avi@chromium.org | 2010-04-27 16:42:26 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Use the native Mac localization bundle utility functions.

BUG=none
TEST=no change

Review URL: http://codereview.chromium.org/1791004
------------------------------------------------------------------------
r45687 | thomasvl@chromium.org | 2010-04-27 14:53:12 +0200 (Tue, 27 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keystone_glue.h
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm
   M /trunk/src/chrome/browser/cocoa/keystone_promote_preflight.sh
   M /trunk/src/chrome/tools/build/mac/keystone_install.sh

[Mac] Brand code support on the Mac:
- During keystone registration pull in the brand file at user to system level.
- Clean up old user level brand files after moving to a system ticket.
- During keystone ticket promotion, use the pref flight script to copy the brand information out to the system level.
- When updating check to see if the user had manually updated the app and gotten a new brand code, if so, migrate that code into the right location.

BUG=39131
TEST=email from tvl to QA with details.
Review URL: http://codereview.chromium.org/1687012
------------------------------------------------------------------------
r45683 | nkostylev@google.com | 2010-04-27 13:08:50 +0200 (Tue, 27 Apr 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/spinner.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/controls/throbber.h

Show spinner on network response in OOBE welcome screen, account creation screen.
Block buttons/keyboard on login window when sign in is in process.

BUG= http://crosbug.com/2573, http://crosbug.com/2528
TEST=Run through OOBE screens and observe spinner when network response is more than 0.5 seconds.

Review URL: http://codereview.chromium.org/1755006
------------------------------------------------------------------------
r45681 | pfeldman@chromium.org | 2010-04-27 12:21:51 +0200 (Tue, 27 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

DevTools: Respect theme in undocked mode.

Review URL: http://codereview.chromium.org/1800002
------------------------------------------------------------------------
r45674 | ukai@chromium.org | 2010-04-27 07:26:49 +0200 (Tue, 27 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc

Ignore *.corp.google.* as GoogleBaseURL

On Mac (prior EasyStreet), http://www.google.com might be redirected to
wifi.corp.google.com, so that google:baseURL would be set to
wifi.corp.google.com, but user might want to use the URL for default search.

BUG=38472
TEST=GoogleURLTrackerTest.CheckAndConvertURL passes

Review URL: http://codereview.chromium.org/1780006
------------------------------------------------------------------------
r45672 | thestig@chromium.org | 2010-04-27 06:31:04 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc

Views: Disable BrowserKeyEventsTests.AccessKeys. It's crashing on Linux views.

BUG=40037
TEST=Linux Views bot goes green?
TBR=oshima
Review URL: http://codereview.chromium.org/1792004
------------------------------------------------------------------------
r45671 | thestig@chromium.org | 2010-04-27 06:15:36 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Views: Disable a failing test on the Linux CrOS bot. Fix my mistake in r45662.

BUG=42514
TEST=CrOS bot goes green.
TBR=oshima
Review URL: http://codereview.chromium.org/1726010
------------------------------------------------------------------------
r45667 | sky@chromium.org | 2010-04-27 05:33:59 +0200 (Tue, 27 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/chrome_tests.gypi

Tweaks to copy/paste of omnibox on windows:
. Makes copy prefix the text with http if the user hasn't edited the
  text, and the scheme is http but the text doesn't include http.
. Makes copying use the url as the text if the user hasn't edited the
  text and it's http/https.
. Makes control-insert/shift-insert use our copy/paste.

BUG=41639 41489 41493
TEST=make sure copy/paste from the omnibox work sanely. Seriously
     though, see the three bugs for specifics.

Review URL: http://codereview.chromium.org/1761002
------------------------------------------------------------------------
r45664 | finnur@chromium.org | 2010-04-27 04:35:12 +0200 (Tue, 27 Apr 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Two changes to extension app icons:

1) When one of the mini tabs is an app (nano) tab, we
now increase the margin between the mini tabs and the
regular tabs by a few pixels.

This is because with the large icons for nano tabs, it
looks a little squished against the regular tabs in the
tabstrip.

2) When dragging a nano tab within the tab strip, the
background "handle" would grow to be as large as a
regular tab (while dragging) due to the fact that
UpdateData (that DraggedTabView calls) was not
transferring the app tab bit to the new Tab.

BUG=None
TEST=Visual inspection.

Review URL: http://codereview.chromium.org/1700016
------------------------------------------------------------------------
r45662 | thestig@chromium.org | 2010-04-27 04:11:59 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Views: Disable a failing test on the Linux views bot.

BUG=42514
TEST=Bot goes green.
TBR=oshima
Review URL: http://codereview.chromium.org/1794003
------------------------------------------------------------------------
r45661 | akalin@chromium.org | 2010-04-27 03:58:39 +0200 (Tue, 27 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/common/notification_type.h

Revert 45640 - Send out notifications when logins are changed through PasswordStoreMac
so that the sync backend can register as an observer.

BUG=35038
TEST=none

Review URL: http://codereview.chromium.org/1752007

TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/1763013
------------------------------------------------------------------------
r45659 | thestig@chromium.org | 2010-04-27 03:50:39 +0200 (Tue, 27 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/theme/app_launcher_button.png
   M /trunk/src/chrome/app/theme/back_Template.pdf
   M /trunk/src/chrome/app/theme/find_next_Template.pdf
   M /trunk/src/chrome/app/theme/find_prev_Template.pdf
   M /trunk/src/chrome/app/theme/forward_Template.pdf
   M /trunk/src/chrome/app/theme/go_Template.pdf
   M /trunk/src/chrome/app/theme/home_Template.pdf
   M /trunk/src/chrome/app/theme/login_default.png
   M /trunk/src/chrome/app/theme/login_other.png
   M /trunk/src/chrome/app/theme/mediaplayer_playlist.png
   M /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/menu_page_Template.pdf
   M /trunk/src/chrome/app/theme/menu_page_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/omnibox_history.pdf
   M /trunk/src/chrome/app/theme/omnibox_http.pdf
   M /trunk/src/chrome/app/theme/omnibox_https_invalid.pdf
   M /trunk/src/chrome/app/theme/omnibox_https_valid.pdf
   M /trunk/src/chrome/app/theme/omnibox_https_warning.pdf
   M /trunk/src/chrome/app/theme/omnibox_more.pdf
   M /trunk/src/chrome/app/theme/omnibox_search.pdf
   M /trunk/src/chrome/app/theme/omnibox_star.pdf
   M /trunk/src/chrome/app/theme/omnibox_star_lit.pdf
   M /trunk/src/chrome/app/theme/reload_Template.pdf
   M /trunk/src/chrome/app/theme/stop_Template.pdf
   M /trunk/src/chrome/app/theme/tab_alpha_new_tab.png
   M /trunk/src/chrome/app/theme/tab_new_tab_shadow.png
   M /trunk/src/chrome/browser/chromeos/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/resources/about_os_credits.html
   M /trunk/src/chrome/browser/resources/calendar_app/128.png
   M /trunk/src/chrome/browser/resources/calendar_app/24.png
   M /trunk/src/chrome/browser/resources/calendar_app/32.png
   M /trunk/src/chrome/browser/resources/calendar_app/48.png
   M /trunk/src/chrome/browser/resources/docs_app/128.png
   M /trunk/src/chrome/browser/resources/docs_app/24.png
   M /trunk/src/chrome/browser/resources/docs_app/32.png
   M /trunk/src/chrome/browser/resources/docs_app/48.png
   M /trunk/src/chrome/browser/resources/gmail_app/128.png
   M /trunk/src/chrome/browser/resources/gmail_app/24.png
   M /trunk/src/chrome/browser/resources/gmail_app/32.png
   M /trunk/src/chrome/browser/resources/gmail_app/48.png
   M /trunk/src/chrome/browser/resources/notification_1line.html
   M /trunk/src/chrome/browser/resources/notification_2line.html
   M /trunk/src/chrome/browser/resources/notification_icon.html
   M /trunk/src/chrome/browser/sync/engine/store_timestamps_command.cc
   M /trunk/src/chrome/browser/sync/engine/store_timestamps_command.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.h
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/css/ApiRefStyles.css
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_page_color/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/api/history/showHistory/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/screenshot.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/fx/bg.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/fx/bg.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/fx/content.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/fx/icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/fx/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/fx/options.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/README
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/background.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/chrome_ex_oauth.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/chrome_ex_oauth.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/chrome_ex_oauthsimple.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/options.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gdocs/popup.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/ar/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/bg/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/ca/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/cs/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/da/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/de/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/el/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/en_GB/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/es_419/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/et/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/fi/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/fil/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/fr/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/he/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/hi/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/hr/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/hu/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/id/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/it/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/ja/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/ko/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/lt/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/lv/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/nb/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/nl/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/pl/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/pt_BR/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/pt_PT/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/ro/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/ru/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/sk/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/sl/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/sr/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/sv/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/th/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/tr/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/uk/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/vi/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/zh_CN/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/_locales/zh_TW/messages.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/README.txt
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/app/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/conf/irc.xml
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/conf/jetty.xml
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/conf/webdefault.xml
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/WEB-INF/web.xml
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/addChannel.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/addServer.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/irc.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/jstemplate/jsevalcontext.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/jstemplate/jstemplate.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/jstemplate/util.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/notification.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/src/org/chromium/IRCProxyWebSocket.java
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/styles.css
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/irc/servlet/util.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/background.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/mappy_content_script.js
   M /trunk/src/chrome/common/extensions/docs/examples/tutorials/getstarted/manifest.json
   M /trunk/src/chrome/common/extensions/docs/images/code_labs_logo.gif
   M /trunk/src/chrome/common/extensions/docs/images/hello-world-1.gif
   M /trunk/src/chrome/common/extensions/docs/images/hello-world-2.gif
   M /trunk/src/chrome/common/extensions/docs/images/hw-1.gif
   M /trunk/src/chrome/common/extensions/docs/images/hw-2.gif
   M /trunk/src/chrome/common/extensions/docs/images/hw-3.gif
   M /trunk/src/chrome/common/extensions/docs/images/news.gif
   M /trunk/src/chrome/common/extensions/docs/images/package-success.gif
   M /trunk/src/chrome/common/extensions/docs/images/themes-1.gif
   M /trunk/src/chrome/common/extensions/docs/images/themes-2.gif
   M /trunk/src/chrome/common/extensions/docs/images/themes-3.gif
   M /trunk/src/chrome/common/extensions/docs/images/toolsmenu.gif
   M /trunk/src/chrome/common/extensions/docs/images/update-success.gif
   M /trunk/src/chrome/common/extensions/docs/js/api_page_generator.js
   M /trunk/src/chrome/common/extensions/docs/js/bootstrap.js
   M /trunk/src/chrome/common/extensions/docs/static/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/static/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/static/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/static/tut_oauth.html

Remove svn:executable property from more files that don't need it.
Review URL: http://codereview.chromium.org/1723014
------------------------------------------------------------------------
r45651 | johnnyg@chromium.org | 2010-04-27 02:34:31 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc

This test is no longer flaky now that it is run as an interactive UI test.  Changing the name to match.

BUG=32807
TEST=none

Review URL: http://codereview.chromium.org/1727008
------------------------------------------------------------------------
r45650 | dhollowa@chromium.org | 2010-04-27 02:22:23 +0200 (Tue, 27 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_type.cc
   M /trunk/src/chrome/browser/autofill/autofill_type.h
   A /trunk/src/chrome/browser/autofill/autofill_type_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill crash in CreditCard::SetInfo().

Fix for crash seen in the field.  The AutoFillType class was not thread-safe.  These changes
make it so.  Also adds unit tests that cover mappings from type to group and subgroup, and
out of range conditions.

BUG=42341
TEST=AutoFillTypeTest

Review URL: http://codereview.chromium.org/1789001
------------------------------------------------------------------------
r45644 | eroman@chromium.org | 2010-04-27 02:01:41 +0200 (Tue, 27 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/test/data/reliability/known_crashes.txt

Make sure the "cancel leaked host resolver requests shutdown hack" gets run before the message loop is destroyed.

BUG=41966

Review URL: http://codereview.chromium.org/1798001
------------------------------------------------------------------------
r45643 | michaeln@chromium.org | 2010-04-27 01:52:47 +0200 (Tue, 27 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/webkit/glue/resource_type.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Ground work for making appcaches work in workers.

Add ResourceRequest target types for worker and shared worker resources. This is the first patch of a two-sided change that involves WebKit API changes which haven't been made yet.

BUG=39368
TEST=none


Review URL: http://codereview.chromium.org/1666002
------------------------------------------------------------------------
r45641 | evan@chromium.org | 2010-04-27 01:50:32 +0200 (Tue, 27 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.h

gtk: Disable the "Import" button on Import Bookmarks dialog if there is no checkbox checked.

BUG=30401
TEST=open Import Bookmarks dialog, uncheck all checkboxes, see if the "Import" button is disabled.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1604025
------------------------------------------------------------------------
r45640 | albertb@chromium.org | 2010-04-27 01:00:56 +0200 (Tue, 27 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/common/notification_type.h

Send out notifications when logins are changed through PasswordStoreMac
so that the sync backend can register as an observer.

BUG=35038
TEST=none

Review URL: http://codereview.chromium.org/1752007
------------------------------------------------------------------------
r45636 | jhawkins@chromium.org | 2010-04-27 00:38:05 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc

Cleanup: Order the methods in WebDataService. Rename a method to match current style.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1701012
------------------------------------------------------------------------
r45631 | arv@chromium.org | 2010-04-27 00:30:44 +0200 (Tue, 27 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/browser/resources/history.html
   D /trunk/src/chrome/browser/resources/i18n_template.js
   D /trunk/src/chrome/browser/resources/local_strings.js
   M /trunk/src/chrome/browser/resources/mediaplayer.html
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   A /trunk/src/chrome/browser/resources/ntp
   A /trunk/src/chrome/browser/resources/ntp/most_visited.js (from /trunk/src/chrome/browser/resources/new_new_tab.js:45471)
   M /trunk/src/chrome/browser/resources/playlist.html
   A /trunk/src/chrome/browser/resources/shared
   A /trunk/src/chrome/browser/resources/shared/js
   A /trunk/src/chrome/browser/resources/shared/js/i18n_template.js
   A /trunk/src/chrome/browser/resources/shared/js/local_strings.js
   A /trunk/src/chrome/browser/resources/shared/js/parse_html_subset.js (from /trunk/src/chrome/browser/resources/new_new_tab.js:45471)
   A /trunk/src/chrome/browser/resources/shared/js/parse_html_subset_test.html
   M /trunk/src/chrome/common/common_resources.grd

Refactor parts of the NTP to split things into more managable chunks.

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/1759007
------------------------------------------------------------------------
r45630 | mpcomplete@chromium.org | 2010-04-27 00:29:36 +0200 (Tue, 27 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc

Fix flaky AppApiTest.AppProcess.

BUG=42497

Review URL: http://codereview.chromium.org/1745016
------------------------------------------------------------------------
r45628 | mark@chromium.org | 2010-04-27 00:27:14 +0200 (Tue, 27 Apr 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Honor the select_all argument to AutocompleteEditViewMac::FocusLocation.

Calling -[NSWindow makeFirstResponder:] to give focus to the
AutocompleteTextField will select the entire contents of the field. If the
field is already focused and "select all" is not desired, avoid making this
call. If "select all" is desired, or if the field is not focused (regardless
of the value of select_all), the field will be focused and its entire contents
selected.

BUG=40322, 40682
TEST=With a profile primed so that "google.com" is the first suggestion when
     typing "g" in the location bar, and no windows open, quickly press
     command-N and begin typing "google" while the tab is being created.
     Expect all of the entered characters to make it to the location bar. When
     the bug occurs, the location bar in its entirety will be selected at some
     point during or immediately following tab creation, which will cause
     previously-typed text to be lost or the first autocomplete suggestion to
     be chosen, and something like "ogle" or "google.com/ogle" to appear in
     the location bar.
Review URL: http://codereview.chromium.org/1709010
------------------------------------------------------------------------
r45626 | sanjeevr@chromium.org | 2010-04-27 00:17:37 +0200 (Tue, 27 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   D /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   D /trunk/src/chrome/browser/sync/util/event_sys.h
   D /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/deprecated
   A /trunk/src/chrome/common/deprecated/event_sys-inl.h (from /trunk/src/chrome/browser/sync/util/event_sys-inl.h:45209)
   A /trunk/src/chrome/common/deprecated/event_sys.h (from /trunk/src/chrome/browser/sync/util/event_sys.h:45209)
   A /trunk/src/chrome/common/deprecated/event_sys_unittest.cc (from /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc:45209)
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc

Move event_sys.h, event_sys-inl.h and event_sys_unittest.cc to chrome/common in preparation of moving TalkMediator and GaiaAuthenticator to chrome/common. No functional change, only file locations have changed.
BUG=None
TEST=Test Bookmakrs Sync

Review URL: http://codereview.chromium.org/1739004
------------------------------------------------------------------------
r45625 | arv@chromium.org | 2010-04-27 00:04:50 +0200 (Tue, 27 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js

Bookmark manager: partial fix position of context menu for trees.

When the user presses the context menu key we ask the tree for the rect where the context menu should be placed at. We incorrectly returned the rec for whole tree item, including its children. With this change we only return the rect for the row of the tree item.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1758009
------------------------------------------------------------------------
r45624 | arv@chromium.org | 2010-04-26 23:55:00 +0200 (Mon, 26 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/list.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css

Bookmark manager: Make sure we do not collapse whitespace in bookmark names.

BUG=41911
TEST=Create a bookmark and a bookmark folder with the name " ". The item should still be shown in both the tree and the list.


Review URL: http://codereview.chromium.org/1793002
------------------------------------------------------------------------
r45615 | avi@chromium.org | 2010-04-26 22:47:48 +0200 (Mon, 26 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm

Put an "(empty)" into the submenus of empty folders in the bookmark menu, to match the same in the non-menubar menus.

BUG=http://crbug.com/41768
TEST=as in bug

Review URL: http://codereview.chromium.org/1718016
------------------------------------------------------------------------
r45612 | viettrungluu@chromium.org | 2010-04-26 22:35:51 +0200 (Mon, 26 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.cc
   D /trunk/src/chrome/browser/gtk/bookmark_manager_browsertest.cc
   D /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   D /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Linux/GTK: delete native bookmark manager code.

Views code still to be deleted; some cleanup will take place then.

BUG=38908
TEST=everything keeps working as before

Review URL: http://codereview.chromium.org/1753009
------------------------------------------------------------------------
r45609 | rohitrao@chromium.org | 2010-04-26 22:16:54 +0200 (Mon, 26 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

[Mac] Ignore rapp events when the browser is shutting down.

BUG=42430
TEST=Suspected test case is to click on the dock icon immediately after quitting, but before the quit has finished.  This is very timing-dependent, and I have never actually been able to reproduce the crash.
Review URL: http://codereview.chromium.org/1796001
------------------------------------------------------------------------
r45606 | erg@chromium.org | 2010-04-26 22:04:56 +0200 (Mon, 26 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK: Support themes in the devtools window in GTK mode too.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1762009
------------------------------------------------------------------------
r45602 | sky@chromium.org | 2010-04-26 21:17:41 +0200 (Mon, 26 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/animation/bounds_animator.cc
   M /trunk/src/views/animation/bounds_animator.h
   M /trunk/src/views/animation/bounds_animator_unittest.cc

Attempt at fixing crash in BoundsAnimator. This patch largely just
cleans things up and fixes some possible usage problems by
TabStrip. I'm not confident this fixes the crash, but we'll see.

BUG=41538
TEST=none

Review URL: http://codereview.chromium.org/1710003
------------------------------------------------------------------------
r45601 | erg@chromium.org | 2010-04-26 21:08:38 +0200 (Mon, 26 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Don't display bookmark right click menu when bookmark bar is hidden.

Because the event box is still visible when the bookmark bar is hidden and the
event box is connected to the button-press-event, if you right click under the
location bar or the browser action icons, you'll show the bookmark menu even
if you have it hidden.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1704010
------------------------------------------------------------------------
r45599 | estade@chromium.org | 2010-04-26 20:47:05 +0200 (Mon, 26 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h

Fix save complete web page crasher

Repeatedly saving a page may cause a crash. See the bug for a full discussion. This fixes that by making sure the curretn SavePackage is the same one that called into SaveFileManager::RenameAllFiles.

One more hack on the giant, teetering pile of hacks that is the SavePackage system. Can't hurt, right?

BUG=42454
TEST=see bug

Review URL: http://codereview.chromium.org/1729016
------------------------------------------------------------------------
r45595 | mirandac@chromium.org | 2010-04-26 20:08:55 +0200 (Mon, 26 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc

Search Engine experiment will crash if the user is importing to a non-empty profile, and has fewer than 3 default search engines *combined* in the non-empty chrome profile and the browser from which they are importing.

BUG= 42554
TEST= Run with the search engine experiment enabled, importing from a browser with only 1 search engine in the list.  Make sure the user data dir you are running from is non-empty, *and* that it has a profile with only 1 search engine in its list. Chrome should not crash (experiment will also not appear).



Review URL: http://codereview.chromium.org/1736015
------------------------------------------------------------------------
r45590 | erikkay@chromium.org | 2010-04-26 18:47:11 +0200 (Mon, 26 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_geolocation_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   D /trunk/src/chrome/test/data/extensions/api_test/geolocation/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/has_permission
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/has_permission/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/has_permission/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/geolocation/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/no_permission
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/no_permission/background.html (from /trunk/src/chrome/test/data/extensions/api_test/geolocation/background.html:45584)
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/no_permission/manifest.json

Add geolocation permission to extensions/apps.

BUG=41278
TEST=None

Review URL: http://codereview.chromium.org/1695013
------------------------------------------------------------------------
r45587 | mark@chromium.org | 2010-04-26 18:25:15 +0200 (Mon, 26 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h

Declare TranslateInfobarController as implementing NSMenuDelegate, required
for the 10.6 SDK build after r45553.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1733018
------------------------------------------------------------------------
r45584 | avayvod@google.com | 2010-04-26 17:59:45 +0200 (Mon, 26 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Added more keyboard shortcuts for other wizard screens.

BUG=37068
TEST=Boot so that any wizard is shown. Verify that Ctrl-Alt-{n, u, l, a} switch to network, update, login and account screens correspondingly.

Review URL: http://codereview.chromium.org/1696011
------------------------------------------------------------------------
r45582 | dglazkov@chromium.org | 2010-04-26 17:49:58 +0200 (Mon, 26 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc

RenderView::UpdateTargetURL should not look at GURL::spec().
Doing so causes a DCHECK to fail if GURL does not consider it a valid URL.

Contributed by Hans Wennborg <hans@chromium.org>.

BUG=41562
TEST=unit_tests --gtest_filter=RenderViewTest.UpdateTargetURLWithInvalidURL

Review URL: http://codereview.chromium.org/1718013
------------------------------------------------------------------------
r45581 | sky@chromium.org | 2010-04-26 17:39:20 +0200 (Mon, 26 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Changes the tab menu to use pin and unpin instead of a check. The mac
changes to use the right thing (pinned vs mini) will be done separately.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1725006
------------------------------------------------------------------------
r45580 | thomasvl@chromium.org | 2010-04-26 17:38:21 +0200 (Mon, 26 Apr 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/google_update_settings_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Kill off google_update_settings_mac.mm.  It's functions are empty and nothing actually calls it.  If we ever support rlz, we might need to add something back, but rlz.cc is pretty Windows heavy, so there doesn't seem to be a reason to have this empty shell in the mean time.

BUG=39131
TEST=none
Review URL: http://codereview.chromium.org/1729013
------------------------------------------------------------------------
r45578 | pfeldman@chromium.org | 2010-04-26 17:16:36 +0200 (Mon, 26 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h

DevTools: support themes.

Review URL: http://codereview.chromium.org/1584016
------------------------------------------------------------------------
r45575 | jochen@chromium.org | 2010-04-26 14:51:22 +0200 (Mon, 26 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

Remove empty nodes when deleting cookies.

BUG=39389
TEST=none

Review URL: http://codereview.chromium.org/1751013
------------------------------------------------------------------------
r45571 | jochen@chromium.org | 2010-04-26 09:32:14 +0200 (Mon, 26 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h

Clear non-wildcard content settings before setting from bubble or prompt.

BUG=42359
TEST=manual

Review URL: http://codereview.chromium.org/1707011
------------------------------------------------------------------------
r45570 | aa@chromium.org | 2010-04-26 08:19:36 +0200 (Mon, 26 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Allow user to choose what kind of container to launch
applications in.

Review URL: http://codereview.chromium.org/1784001
------------------------------------------------------------------------
r45568 | tony@chromium.org | 2010-04-26 06:43:36 +0200 (Mon, 26 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/common/chrome_plugin_util.cc

Get rid of more calls to FromWStringHack.

BUG=24672
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1750013
------------------------------------------------------------------------
r45566 | aa@chromium.org | 2010-04-26 06:06:43 +0200 (Mon, 26 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Reland r45520. This adds a new browser type: EXTENSION_APP that
has a larger titlebar and a big icon, along with a tabstrip,
but no titlebar.

Review URL: http://codereview.chromium.org/1774003
------------------------------------------------------------------------
r45553 | jeremy@chromium.org | 2010-04-25 11:14:11 +0200 (Sun, 25 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm

Mac: Fix use-after-free in translate infobar options menu.

The "About Translate" command opens a new tab which closes the infobar, we where trying to update the options menu which acccessed an already released object.

The fix is to match Windows behavior and only rebuild the options menu when clicked.

Thanks to Rohit for diagnosing the problem!

BUG=42030
TEST=repro in bug description.

Review URL: http://codereview.chromium.org/1756006
------------------------------------------------------------------------
r45546 | nsylvain@chromium.org | 2010-04-25 04:31:51 +0200 (Sun, 25 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/app_process_apitest.cc

mark AppApiTest.AppProcess as flaky

TBR:mpcomplete
BUG:42497

Review URL: http://codereview.chromium.org/1752015
------------------------------------------------------------------------
r45545 | viettrungluu@chromium.org | 2010-04-25 04:31:02 +0200 (Sun, 25 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Mac cleanup: get rid of probably-stale TODOs.

See comments at <http://codereview.chromium.org/1737013>.

TBR=jrg@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1726007
------------------------------------------------------------------------
r45543 | viettrungluu@chromium.org | 2010-04-24 22:17:35 +0200 (Sat, 24 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Mac cleanup: remove a TODO and add ToolbarControllerTest.NoLocationBar (another TODO).

BUG=none
TEST=ToolbarControllerTest.NoLocationBar passes

Review URL: http://codereview.chromium.org/1737013
------------------------------------------------------------------------
r45541 | viettrungluu@chromium.org | 2010-04-24 20:49:39 +0200 (Sat, 24 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Mac cleanup: Put consts and enums in info_bubble_view.h in a namespace.

BUG=none
TEST=everything still builds

Review URL: http://codereview.chromium.org/1787001
------------------------------------------------------------------------
r45538 | finnur@chromium.org | 2010-04-24 18:27:53 +0200 (Sat, 24 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h

No-op change to force a build (should fix the build).

(Previous cl included a grd change, so the build broke).

BUG=None
TEST=None

------------------------------------------------------------------------
r45537 | finnur@chromium.org | 2010-04-24 18:03:23 +0200 (Sat, 24 Apr 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/button/checkbox.h

Add a first run bubble to show after installing an extension app.

This is similar to what we show when installing a page action or
browser action, albeit with a slightly different text.

Also disable the install warning for extension apps, for the time
being.

And finally, in tab_strip.cc I accidentally checked in a comment,
which I had commented out during testing. It was supposed to be
on (related to my last cl).

BUG=None
TEST=Install an extension app, notice a first run bubble instead
of a installation warning. The first run bubble should have a
checkbox allowing you to create a desktop shortcut.

Review URL: http://codereview.chromium.org/1693008
------------------------------------------------------------------------
r45531 | viettrungluu@chromium.org | 2010-04-24 10:59:39 +0200 (Sat, 24 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm

Minor style fixes.

TBR=feldstein
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1712012
------------------------------------------------------------------------
r45524 | suzhe@chromium.org | 2010-04-24 04:05:59 +0200 (Sat, 24 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

[Mac] Fix issue 19421: IMEs do not work well in the omnibox due to a race condition

This CL makes following major changes:
1. Exclude marked text from GetText()'s result.
2. When the text field is in editing mode, EmphasizeURLComponents() changes its attributes through its editor rather than reseting its content.
3. When the text field is in editing mode, SetText() sets its content through its editor.

BUG=19421
TEST=See bug report.

Review URL: http://codereview.chromium.org/1549033
------------------------------------------------------------------------
r45523 | aa@chromium.org | 2010-04-24 02:59:23 +0200 (Sat, 24 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Sigh. Revert r45520. Breaks ChromeOS.

TBR=jamesr@chromium.org
------------------------------------------------------------------------
r45521 | estade@chromium.org | 2010-04-24 02:54:24 +0200 (Sat, 24 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

GTK: Browser actions container tweak.

don't change the show/hide state of the overflow chevron while animating the browser actions toolbar.

BUG=none
TEST=Don't regress:
1) correct display of browser actions toolbar on startup
 - when some browser actions are showing
 - when all browser actions are showing
2) dragging the slider correctly sets the overflow icon, still
Fixes:
1) adding an action while the container is fully expanded does not temporarily show the overflow chevron

Review URL: http://codereview.chromium.org/1751015
------------------------------------------------------------------------
r45520 | aa@chromium.org | 2010-04-24 02:28:01 +0200 (Sat, 24 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   M /trunk/src/chrome/browser/resources/docs_app/manifest.json
   M /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

This adds a new kind of browser window: EXTENSION_APP. EXTENSION_APP windows have a bigger titlebar with a giant icon and title, and supports tabs.

Review URL: http://codereview.chromium.org/1730010
------------------------------------------------------------------------
r45518 | sky@chromium.org | 2010-04-24 01:43:56 +0200 (Sat, 24 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Fixes possible crash if the window hosting a menu was closed while the
menu was showing. When this happens the window the menu creates is
implicitly destroyed (because the parent is going away).

BUG=none
TEST=Use the test case in 25563, but instead of opening a bookmark
menu open either the page or wrench menus.

Review URL: http://codereview.chromium.org/1739002
------------------------------------------------------------------------
r45517 | dantasse@chromium.org | 2010-04-24 01:42:48 +0200 (Sat, 24 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Make sure that the sync backend host doesn't exist in a post-shutdown state, and make sure the preference is cleared before shutting down the backend.

BUG=42269
TEST=none

Review URL: http://codereview.chromium.org/1750010
------------------------------------------------------------------------
r45513 | akalin@chromium.org | 2010-04-24 01:11:37 +0200 (Sat, 24 Apr 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/tools
   A /trunk/src/chrome/browser/sync/tools/DEPS
   A /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   A /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

Added sync_listen_notifications, a utility that connects to an XMPP
server and listens for sync notifications.  It is also useful for
debugging libjingle issues.

BUG=none
TEST=compiled and ran on all platforms

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45484

Review URL: http://codereview.chromium.org/1712002
------------------------------------------------------------------------
r45512 | pkasting@chromium.org | 2010-04-24 01:10:47 +0200 (Sat, 24 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/controls/button/button.h
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/progress_bar.h
   M /trunk/src/views/controls/resize_gripper.h
   M /trunk/src/views/controls/single_split_view.h
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/window/non_client_view.h

Remove unused local variables now that subclasses don't need to track their own accessibile name.  (In other words, I forgot to do this in r43558.)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1751018
------------------------------------------------------------------------
r45510 | mirandac@google.com | 2010-04-24 01:09:34 +0200 (Sat, 24 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h

Fix XP crasher in Search Engine Experiment.

This was causing a crash because the View "owns" its images, and was trying to delete the ImageView which had already been deleted in a scoped_ptr.  Solution: put the ImageView in a regular pointer instead.

BUG= 42346
TEST=run with search engine experiment enabled in XP, don't crash.

Review URL: http://codereview.chromium.org/1696010
------------------------------------------------------------------------
r45506 | evan@chromium.org | 2010-04-24 00:48:56 +0200 (Sat, 24 Apr 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc

I fail at merging.  Build fix.
------------------------------------------------------------------------
r45504 | johnnyg@chromium.org | 2010-04-24 00:31:16 +0200 (Sat, 24 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/views/widget/widget_delegate.h
   M /trunk/src/views/widget/widget_win.cc

Add a widget delegate handler for the WM_SETTINGCHANGE message in windows.  This is sent when the size/position of the taskbar changes, and we need to move the desktop notifications if that happens.

BUG=35464
TEST=open notifications and move taskbar

Review URL: http://codereview.chromium.org/1622018
------------------------------------------------------------------------
r45503 | estade@chromium.org | 2010-04-24 00:27:32 +0200 (Sat, 24 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h

GTK: Support transparent web image drags.

This depends on a webkit side change before it has any effect.

This only works on compositing WMs; non-compositing WMs will just not get a transparent image (it actually will appear slightly darkened).

BUG=11457
TEST=manul

Review URL: http://codereview.chromium.org/1756008
------------------------------------------------------------------------
r45502 | evan@chromium.org | 2010-04-24 00:27:10 +0200 (Sat, 24 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/tools/build/make_version_cc.py

Minor code issues found by Clang.

Mostly that "extern const ... = ...;" is not legal.
You need two lines to make a non-static const declaration.

Review URL: http://codereview.chromium.org/1739005
------------------------------------------------------------------------
r45500 | shess@chromium.org | 2010-04-24 00:21:07 +0200 (Sat, 24 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Update location-bar icon as user types.

Update in |OnChanged()|, just like Windows.

NOTE: This CL requires the following change else it breaks the build:
  http://src.chromium.org/viewvc/chrome?view=rev&revision=44775
[Didn't think to put this note on that change, sorry.]

BUG=41362
TEST=Type "www.google.com".  You should have a globe icon.
TEST=Add a space after first 'w'.  Should get search icon.
TEST=Generally, icon will switch around as you type.

Originally committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44572

Review URL: http://codereview.chromium.org/1640012
------------------------------------------------------------------------
r45498 | johnnyg@chromium.org | 2010-04-24 00:08:00 +0200 (Sat, 24 Apr 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/notifications/notifications_interactive_uitest.cc (from /trunk/src/chrome/browser/notifications/notifications_uitest.cc:45383)
   D /trunk/src/chrome/browser/notifications/notifications_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Run the notifications info bar tests as interactive ui tests rather than just ui tests.

BUG=32807
TEST=included

Review URL: http://codereview.chromium.org/1699007
------------------------------------------------------------------------
r45494 | albertb@chromium.org | 2010-04-23 23:46:39 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/crypto/symmetric_key_mac.cc
   M /trunk/src/chrome/browser/sync/util/nigori.cc
   M /trunk/src/chrome/browser/sync/util/nigori.h
   M /trunk/src/chrome/browser/sync/util/nigori_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Enable Nigori unit tests on all platforms.

BUG=none
TEST=NigoriTest.*

Review URL: http://codereview.chromium.org/1736008
------------------------------------------------------------------------
r45493 | akalin@chromium.org | 2010-04-23 23:35:05 +0200 (Fri, 23 Apr 2010) | 11 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/tools

Revert 45484 - Added sync_listen_notifications, a utility that connects to an XMPP
server and listens for sync notifications.  It is also useful for
debugging libjingle issues.

BUG=none
TEST=compiled and ran on all platforms

Review URL: http://codereview.chromium.org/1712002

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/1739006
------------------------------------------------------------------------
r45492 | xiyuan@chromium.org | 2010-04-23 23:30:33 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Abort shortcut update on interstitial page.

BUG=42254
TEST=Verify fix for issue 42254.

Review URL: http://codereview.chromium.org/1699006
------------------------------------------------------------------------
r45491 | cpu@chromium.org | 2010-04-23 23:26:03 +0200 (Fri, 23 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc

Enable silent import of bookmarks for Linux

Patch contributed by Brian G. Merrell (bgmerrell)

- Add ImportBookmarks first run function for Linux, which implements only a 
piece of Windows' ImportSettings function 
- Use string16 instead of wstring, which required changing some code in the 
master_preferences files and the Windows-specific first run code. 

With this patch, bookmarks can be silently imported the same way that they 
are silently imported in Windows. See the bug below for specifics. 

BUG=32728
TEST=unit test or specify "import_bookmarks_from_file" in the 
master_preferences file and run chromium with --first-run (see 
http://code.google.com/p/chromium/issues/detail?id=32728#c11 for details)


Review URL: http://codereview.chromium.org/1733012
------------------------------------------------------------------------
r45488 | dhg@chromium.org | 2010-04-23 23:19:29 +0200 (Fri, 23 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc

Changing chromeos so that ctrl-o opens the filebrowser

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1756009
------------------------------------------------------------------------
r45487 | arv@chromium.org | 2010-04-23 23:17:39 +0200 (Fri, 23 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js

Bookmark manager: Fix issue with mouse events on the scrollbar as well as clicking on empty areas with keyboard modifiers.

In case where a mouse event originates on the scrollbar we exit early.

On Window, if the user clicks on an empty area and holds down a key modifier we should do nothing.
On Mac, we always clear the selection when clicking on an empty area, no matter if any keys are pressed.

BUG=42371
TEST=Select some items in the list. Scrolling the list using the mouse and scrollbar should not change the selection.
     Shift and/or ctrl clicking on an empty area should clear selection on mac and do nothing on windows.


Review URL: http://codereview.chromium.org/1694013
------------------------------------------------------------------------
r45486 | arv@chromium.org | 2010-04-23 23:16:00 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/command.js

Bookmark manager: Make sure that commands can be prevented by stopping the keydown event propagation.

BUG=40823
TEST=Open the context menu for a bookmark. Highlight edit and press enter. The bookmark should not open in a new tab.

Review URL: http://codereview.chromium.org/1707010
------------------------------------------------------------------------
r45484 | akalin@chromium.org | 2010-04-23 23:02:50 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/tools
   A /trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc
   A /trunk/src/chrome/browser/sync/tools/sync_tools.gyp

Added sync_listen_notifications, a utility that connects to an XMPP
server and listens for sync notifications.  It is also useful for
debugging libjingle issues.

BUG=none
TEST=compiled and ran on all platforms

Review URL: http://codereview.chromium.org/1712002
------------------------------------------------------------------------
r45483 | dantasse@chromium.org | 2010-04-23 23:02:37 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc

Make an Unrecoverable Error during sign-in spit you back out to the sign-in page again.

BUG=40881
TEST=none

Review URL: http://codereview.chromium.org/1713002
------------------------------------------------------------------------
r45482 | thakis@chromium.org | 2010-04-23 23:02:12 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/animatable_view.mm

Mac: Slomo for download shelf/info bars.

BUG=41393
TEST=shift-click close button in download shelf/info bars. Animation should slow down.

Review URL: http://codereview.chromium.org/1719015
------------------------------------------------------------------------
r45479 | jhawkins@chromium.org | 2010-04-23 22:55:36 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

AutoFill: Try to parse a third address line and discard it if it exists.

BUG=38327
TEST=FormManagerTest.ThreeAddressLines

Review URL: http://codereview.chromium.org/1746004
------------------------------------------------------------------------
r45474 | shess@chromium.org | 2010-04-23 22:01:00 +0200 (Fri, 23 Apr 2010) | 104 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resources/frame_default.png
   M /trunk/src/app/resources/frame_default_inactive.png
   M /trunk/src/app/resources/window_bottom_left_corner.png
   M /trunk/src/app/resources/window_bottom_right_corner.png
   A /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/content_top_left_corner.png
   A /trunk/src/chrome/app/theme/content_top_left_corner_mask.png
   M /trunk/src/chrome/app/theme/content_top_right_corner.png
   A /trunk/src/chrome/app/theme/content_top_right_corner_mask.png
   D /trunk/src/chrome/app/theme/ev_secure.png
   M /trunk/src/chrome/app/theme/geolocation_allowed_locationbar_icon.png
   M /trunk/src/chrome/app/theme/geolocation_denied_locationbar_icon.png
   M /trunk/src/chrome/app/theme/location_bar_keyword_search_c.png
   M /trunk/src/chrome/app/theme/location_bar_keyword_search_l.png
   M /trunk/src/chrome/app/theme/location_bar_keyword_search_r.png
   D /trunk/src/chrome/app/theme/lock_small.png
   D /trunk/src/chrome/app/theme/o2_globe.png
   D /trunk/src/chrome/app/theme/o2_globe_selected.png
   D /trunk/src/chrome/app/theme/o2_globe_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_history.png
   D /trunk/src/chrome/app/theme/o2_history_selected.png
   D /trunk/src/chrome/app/theme/o2_history_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_more.png
   D /trunk/src/chrome/app/theme/o2_more_selected.png
   D /trunk/src/chrome/app/theme/o2_more_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_search.png
   D /trunk/src/chrome/app/theme/o2_search_selected.png
   D /trunk/src/chrome/app/theme/o2_search_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_star.png
   D /trunk/src/chrome/app/theme/o2_star_selected.png
   D /trunk/src/chrome/app/theme/o2_star_selected_dark.png
   A /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_c.png
   A /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_l.png
   A /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_r.png
   A /trunk/src/chrome/app/theme/omnibox_history.pdf
   A /trunk/src/chrome/app/theme/omnibox_history.png
   A /trunk/src/chrome/app/theme/omnibox_history_dark.png
   A /trunk/src/chrome/app/theme/omnibox_history_dark_transparent.png
   A /trunk/src/chrome/app/theme/omnibox_history_selected.png
   A /trunk/src/chrome/app/theme/omnibox_history_transparent.png
   A /trunk/src/chrome/app/theme/omnibox_http.pdf
   A /trunk/src/chrome/app/theme/omnibox_http.png
   A /trunk/src/chrome/app/theme/omnibox_http_dark.png
   A /trunk/src/chrome/app/theme/omnibox_http_dark_transparent.png
   A /trunk/src/chrome/app/theme/omnibox_http_selected.png
   A /trunk/src/chrome/app/theme/omnibox_http_transparent.png
   A /trunk/src/chrome/app/theme/omnibox_https_invalid.pdf
   A /trunk/src/chrome/app/theme/omnibox_https_invalid.png
   A /trunk/src/chrome/app/theme/omnibox_https_valid.pdf
   A /trunk/src/chrome/app/theme/omnibox_https_valid.png
   A /trunk/src/chrome/app/theme/omnibox_https_warning.pdf
   A /trunk/src/chrome/app/theme/omnibox_https_warning.png
   A /trunk/src/chrome/app/theme/omnibox_more.pdf
   A /trunk/src/chrome/app/theme/omnibox_more.png
   A /trunk/src/chrome/app/theme/omnibox_more_dark.png
   A /trunk/src/chrome/app/theme/omnibox_more_selected.png
   A /trunk/src/chrome/app/theme/omnibox_search.pdf
   A /trunk/src/chrome/app/theme/omnibox_search.png
   A /trunk/src/chrome/app/theme/omnibox_search_dark.png
   A /trunk/src/chrome/app/theme/omnibox_search_selected.png
   A /trunk/src/chrome/app/theme/omnibox_star.pdf
   A /trunk/src/chrome/app/theme/omnibox_star.png
   A /trunk/src/chrome/app/theme/omnibox_star_dark.png
   A /trunk/src/chrome/app/theme/omnibox_star_lit.pdf
   A /trunk/src/chrome/app/theme/omnibox_star_lit.png
   A /trunk/src/chrome/app/theme/omnibox_star_selected.png
   M /trunk/src/chrome/app/theme/reload.png
   M /trunk/src/chrome/app/theme/reload_d.png
   M /trunk/src/chrome/app/theme/reload_h.png
   A /trunk/src/chrome/app/theme/reload_mask.png (from /trunk/src/chrome/app/theme/star_mask.png:45471)
   A /trunk/src/chrome/app/theme/reload_noborder_center.png
   M /trunk/src/chrome/app/theme/reload_p.png
   D /trunk/src/chrome/app/theme/secure.png
   D /trunk/src/chrome/app/theme/security_error.png
   D /trunk/src/chrome/app/theme/security_warning.png
   D /trunk/src/chrome/app/theme/star.png
   D /trunk/src/chrome/app/theme/star_Template.pdf
   D /trunk/src/chrome/app/theme/star_d.png
   D /trunk/src/chrome/app/theme/star_h.png
   D /trunk/src/chrome/app/theme/star_mask.png
   D /trunk/src/chrome/app/theme/star_noborder.png
   D /trunk/src/chrome/app/theme/star_noborder_center.png
   D /trunk/src/chrome/app/theme/star_p.png
   D /trunk/src/chrome/app/theme/starred.pdf
   D /trunk/src/chrome/app/theme/starred.png
   D /trunk/src/chrome/app/theme/starred_h.png
   D /trunk/src/chrome/app/theme/starred_noborder.png
   D /trunk/src/chrome/app/theme/starred_noborder_center.png
   D /trunk/src/chrome/app/theme/starred_p.png
   A /trunk/src/chrome/app/theme/tab_active_nano_center.png
   A /trunk/src/chrome/app/theme/tab_active_nano_left.png
   A /trunk/src/chrome/app/theme/tab_active_nano_right.png
   A /trunk/src/chrome/app/theme/tab_alpha_nano_left.png
   A /trunk/src/chrome/app/theme/tab_alpha_nano_right.png
   A /trunk/src/chrome/app/theme/tab_alpha_new_tab.png
   A /trunk/src/chrome/app/theme/tab_new_tab_shadow.png
   M /trunk/src/chrome/app/theme/theme_frame_default.png
   M /trunk/src/chrome/app/theme/theme_frame_default_inactive.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/app/theme/theme_toolbar_default.png
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_classifier.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_classifier.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   D /trunk/src/chrome/browser/bubble_positioner.h
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   D /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   D /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/net/browser_url_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   D /trunk/src/chrome/browser/search_versus_navigate_classifier.cc
   D /trunk/src/chrome/browser/search_versus_navigate_classifier.h
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/theme_resources_util_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   A /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   A /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   D /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   D /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/chrome/test/test_location_bar.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/gfx/gtk_util.cc
   M /trunk/src/gfx/gtk_util.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/views/animation/bounds_animator.cc
   M /trunk/src/views/animation/bounds_animator.h
   A /trunk/src/views/animation/bounds_animator_unittest.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/custom_frame_view.cc
   A /trunk/src/views/window/window_shape.cc
   A /trunk/src/views/window/window_shape.h

Re-instate the temporary revert from r45267.  That reverted certain
Omnibox, toolbar, tab animations, and other UI changes for purposes of
testing and merging into mstone-5.

Additionally reverts these CLs to fix the earlier revert:
r45271: [Mac] Image references missing from Omnibox revert.
r45268: GTK fix merge failure in uber-revert.

Additional revert which fixed a bug for the branch:
r45381: [Mac] Omnibox popup icons and text lined up under toolbar.

Slight merge conflict which should be good:
r45322: GTK: Implement OnDragCanceled() for autocomplete...

Also ++kThemePackVersion and regenerate the cached theme pak.

Re-instated changes:
r45213: GTK: Override cursor colors in chrome-theme mode.
r45103: Support drawing nano tabs in the tabstrip.
r45084: GTK: Position the EV certificate stuff inside a green bubble.
r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon...
r44957: GTK: Tint the geolocation icons in gtk mode.
r44943: Changes FormatURL to not strip http if the host starts with ft...
r44930: Remove an icon that is no longer used.
r44929: SSL UI changes, Windows, code side (images are separate).
r44859: SSL UI changes (icons).  TBRed since trybots hate binary patches.
r44822: GTK: Select better greens in the native omnibox popup.
r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat...
r44789: [Mac] Bookmark star missing on NTP and BMM.
r44775: [Mac] Centralize hack to make tests work with AutocompleteClas...
r44678: Display the SECURITY_WARNING status in the location bar for the
r44648: [Mac] Add an arrow cursor rect for the location image.
r44615: Revert r44611 because it may have broken "unit_tests" on "Vist...
r44611: Display the SECURITY_WARNING status in the location bar for the
r44577: Revert 44572 - [Mac] Update locationbar icon as user types.
r44572: [Mac] Update location-bar icon as user types.
r44555: GTK: Use correct button mask on reload button.
r44545: [Mac] Omnibox text drag drag URL when select-all.
r44523: GTK: Prevent inappropriate drag of location bar location icon.
r44519: GTK: make the primary selection include the url's scheme when ...
r44492: [Mac] Fix search icon in keyword search to be right-side-up.
r44415: GTK: Update top padding on icons in the autocomplete popup.
r44401: GTK: Tint omnibox icons in GTK mode differently.
r44380: GTK: Move reload in gtk mode and fix omnibox popup location.
r44282: Fixes crash in autocomplete when typing some URLs. The problem
r44273: [Mac] PDF icons for omnibox nits.
r44269: Fix build break due to bad merge resolve
r44268: Shift omnibox dropdown in and up on Windows, and square off th...
r44178: GTK: fix TTS padding.
r44177: Round the top left and right edges of the toolbar.
r44171: Images only checkin for try server goodness.
r44163: GTK: fix padding of autocomplete popup.
r44152: [Mac] PDF icons for omnibox.
r44145: GTK: Theme the icons in the location bar and use GTK colors fo...
r44140: Strips http from the omnibox
r44131: Fixes bugs in new tab strip animations where they weren't doin...
r44116: Change the default theme colors.
r44117: Add newline to EOF to fix CrOS builder.
r44115: Make the bottom edges of the opaque frame rounded.
r44091: [Mac] No star icon or page actions in omnibox on popups.
r44087: Don't allow drag or click on location icon when editing in omn...
r44021: [GTK] Add TTS lens graphic to linux TTS box.
r44008: [Mac] Tweak location icon spacing in omnibox.
r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca...
r43972: Make the firstrun bubble point at a better spot now that the l...
r43971: [Mac] Location icon in omnibox as drag source.
r43970: Make the star and page action icons not appear on popup windows.
r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly
r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip:
r43787: Allow location icon to be dragged & dropped.  This also fixes ...
r43759: Changes end cap of tab-to-search images.
r43740: Change bookmark bar toggle to ctrl-shift-b.
r43723: Show Page Info dialog on mouse up, not mouse down.
r43677: Fix Mac build failure.
r43676: Replace omnibox icons with new set that are all the same size ...
r43596: Fix browser test TestStarButtonAccObj.
r43593: Disables TestStarButtonAccObj.
r43582: Changes tab strip to use BoundsAnimator for tab strip animatio...
r43563: GTK: don't show reload button for popup/app windows.
r43562: Star/reload shuffle, Windows version.
r43540: [Mac] Magnifying glass in keyword-search bubble.
r43482: Adds images needed for new tab animation. I'm separating this ...
r43422: Add reload mask resource.
r43392: GTK: make the location icon a drag source.
r43376: [Mac] Move star button into page-actions area of omnibox.
r43357: [Mac] Line up omnibox popup under field.
r43290: gtk: fix display of icons in omnibox popup
r43269: GTK: fix reload button.
r43249: [Mac] Rearrange SSL status icon/label in omnibox.
r43248: BrowserThemePack: Adds persistant ids for the reload endcaps.
r43241: GTK: more location bar updates.
r43191: Fix memory leak in BrowserThemePack.
r43154: GTK: set the new star button's ID
r43151: Fix bad conflict resolution for r43146.
r43146: GTK: toolbar reload/star shuffle.
r43025: Show the location bar icon (almost) all the time, and have its...
r43023: Add new images for new reload button. No code change.
r42782: Remove this icon, now that it's no longer used (due to my secu...
r42502: Omnibox M5 work, part 1: Security changes
r42245: Check in new icons for omnibox security changes alone, so that...

BUG=none
TEST=People go back to complaining about missing http://.
R=pkasting@chromium.org,beng@chromium.org
------------------------------------------------------------------------
r45467 | sky@chromium.org | 2010-04-23 20:16:32 +0200 (Fri, 23 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h

Fixes bug in app launcher. If the url is specified for the launcher
and the page tried to open a popup it would get eaten.

BUG=Chrome OS bug 2770
TEST=see bug

Review URL: http://codereview.chromium.org/1695012
------------------------------------------------------------------------
r45462 | viettrungluu@chromium.org | 2010-04-23 19:46:40 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/nibs/BookmarkManager.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   D /trunk/src/chrome/browser/cocoa/bookmark_item.h
   D /trunk/src/chrome/browser/cocoa/bookmark_item.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_item_unittest.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   D /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_manager_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   D /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Delete native Mac bookmark manager. Remove --disable-tabbed-bookmark-manager (everywhere).

Still to do: delete native bookmark managers on other platforms.

BUG=38908
TEST=Everything else still works.

Review URL: http://codereview.chromium.org/1751011
------------------------------------------------------------------------
r45458 | tim@chromium.org | 2010-04-23 19:25:37 +0200 (Fri, 23 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   A /trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_tests.gypi

Add PasswordManager tests to verify basic form observation / submit cases.
This patch includes basic tests for infobar triggering, PasswordStore
interaction, and autofilling.

Now that the plumbing is sufficiently mocked / de-coupled from the dreaded
TabContents stack using RenderViewHostTestHarness and Google Mock, it is
pretty easy to add more tests and I plan to!

TEST=PasswordManagerTest (new), PasswordFormManagerTest (existing)
BUG=none

Review URL: http://codereview.chromium.org/1745006
------------------------------------------------------------------------
r45457 | aa@chromium.org | 2010-04-23 19:24:22 +0200 (Fri, 23 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/profile.cc
   A /trunk/src/chrome/browser/resources/calendar_app/manifest.json
   A /trunk/src/chrome/browser/resources/docs_app/manifest.json
   A /trunk/src/chrome/browser/resources/gmail_app/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Install some simple apps by default to make dev easier.

Review URL: http://codereview.chromium.org/1688006
------------------------------------------------------------------------
r45455 | evan@chromium.org | 2010-04-23 19:18:14 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/tools/licenses.py

Check in a new generated about:credits.

We still don't cover every library, but this is better than what we have.
Modify the credits-generator to only warn about missing entries.

BUG=39240

Review URL: http://codereview.chromium.org/1719011
------------------------------------------------------------------------
r45454 | oshima@chromium.org | 2010-04-23 19:17:20 +0200 (Fri, 23 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc

Fix the layout of control buttons on notification.
 Adjust margin and fixed horizontal alignment.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1687009
------------------------------------------------------------------------
r45453 | arv@chromium.org | 2010-04-23 19:06:02 +0200 (Fri, 23 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Revert 41461 - Bookmark manager: Remove find as you type

BUG=42214
TEST=None

Review URL: http://codereview.chromium.org/894002

TBR=arv@chromium.org
Review URL: http://codereview.chromium.org/1762005
------------------------------------------------------------------------
r45449 | vandebo@chromium.org | 2010-04-23 18:44:02 +0200 (Fri, 23 Apr 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_factory.cc
   M /trunk/src/net/socket/client_socket_factory.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks5_client_socket.cc
   M /trunk/src/net/socket/socks5_client_socket.h
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket.cc
   M /trunk/src/net/socket/socks_client_socket.h
   M /trunk/src/net/socket/socks_client_socket_pool.cc
   M /trunk/src/net/socket/socks_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_client_socket_win.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.h
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/socket/tcp_client_socket_win.h
   M /trunk/src/net/socket/tcp_pinger.h
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/spdy/spdy_session.cc

Add net log entries that summarize transmit and receive byte counts.

Tx/Rx summaries are integrated into the net log at the last point that bytes were transmitted or received.

Hopefully this will help resolve http://crbug.com/37729 by showing if we've received bytes over the network when we hit the "Waiting for cache" bug.

This change also modernizes the use of NetLog:
 - ClientSocket now has a net_log() accessor
 - ClientSocket::Connect no longer takes a NetLog, instead the TCPClientSocket constructor takes one, others use their transport socket's NetLog
 - TCPClientSocket creates a new source id with source type SOCKET

Also updates PassiveLogCollector infrastructure:
 - The LiveRequestsObserver lets a RequestTracker update a RequestInfo just before it is displayed.  This allows ConnectJobs to be associated with URLRequests while connecting and then reassociated if they are late-bound to a different request.

BUG=37729
TEST=tx/rx lines show up in chrome://net-internals/

Review URL: http://codereview.chromium.org/1696005
------------------------------------------------------------------------
r45444 | dhollowa@chromium.org | 2010-04-23 17:42:16 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Mac BookmarkBarFolderController side scrolling disabled.

Fixes a small cosmetic bug where mousing down over an open BookmarkBarFolder's contents caused subtle side scrolling.

BUG=none
TEST=On Mac, (1) click on bookmark bar folder, (2) drag a bookmark to the left or right edge of the open folder's menu, (3) notice that subtle side scrolling happens as you get close to the edge.  Expect: no side scrolling.

Review URL: http://codereview.chromium.org/1756010
------------------------------------------------------------------------
r45443 | bulach@chromium.org | 2010-04-23 17:36:17 +0200 (Fri, 23 Apr 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/geolocation/geoposition.cc
   D /trunk/src/chrome/browser/geolocation/geoposition.h
   D /trunk/src/chrome/browser/geolocation/location_provider_pool.cc
   D /trunk/src/chrome/browser/geolocation/location_provider_pool.h
   M /trunk/src/chrome/chrome_browser.gypi

Removes obsolete geolocation-related files.

TEST=Compiles

Review URL: http://codereview.chromium.org/1731006
------------------------------------------------------------------------
r45441 | bulach@chromium.org | 2010-04-23 16:36:52 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Re-enables some geolocation tests

(WebKit change has rolled and a flaky test seems to be stable).

TEST=GeolocationBrowserTest.*
BUG=40099

Review URL: http://codereview.chromium.org/1687002
------------------------------------------------------------------------
r45440 | bauerb@chromium.org | 2010-04-23 14:58:50 +0200 (Fri, 23 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h

Add API to find out whether a preference is managed.

Add a method |IsManaged()| to the |PrefStore::Preference| class that returns true if the preference cannot be set by the user. Because we currently don't actually implement managed preferences yet, the implementation always returns false.

BUG=40260

Review URL: http://codereview.chromium.org/1744002
------------------------------------------------------------------------
r45434 | danno@chromium.org | 2010-04-23 13:33:18 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

innerHTML usage in history pages with explicit DOM manipulation

BUG=42072
TEST=manual tetsting, existing automated tests

Review URL: http://codereview.chromium.org/1631029
------------------------------------------------------------------------
r45427 | dpolukhin@chromium.org | 2010-04-23 11:46:21 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc

Fix fonts size for OOBE screens. Most controls use default system font from
/etc/gtk-2.0/gtkrc. This CL fixes explicitly set fonts to use predefined
fonts from ResourceBundle.

BUG=crosbug.com/2795
TEST=See font size of login and welcome screens.

Review URL: http://codereview.chromium.org/1748008
------------------------------------------------------------------------
r45424 | jochen@chromium.org | 2010-04-23 09:17:54 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.h
   M /trunk/src/chrome/browser/host_zoom_map_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Send content settings based on the URL to the renderer instead of just the host.

BUG=36025
TEST=manual

Review URL: http://codereview.chromium.org/1744003
------------------------------------------------------------------------
r45407 | pkasting@chromium.org | 2010-04-23 03:59:31 +0200 (Fri, 23 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Attempt to fix Mac build

BUG=41466
TEST=none

------------------------------------------------------------------------
r45406 | pkasting@chromium.org | 2010-04-23 03:48:58 +0200 (Fri, 23 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_location_bar.h

Don't select all when autofocusing the location bar on New Tab creation.  Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten.

BUG=41466
TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading.
Review URL: http://codereview.chromium.org/1738004
------------------------------------------------------------------------
r45400 | estade@chromium.org | 2010-04-23 03:24:12 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Only show one of {Cancel, Remove from list} for each download in downloads page.

BUG=39215
TEST=manual

Review URL: http://codereview.chromium.org/1747010
------------------------------------------------------------------------
r45399 | tony@chromium.org | 2010-04-23 03:22:46 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_member.cc
   M /trunk/src/chrome/browser/pref_member.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.h

Introduce FilePathPrefMember so we can get rid of some FromWString conversions.

BUG=24672
TEST=download a file and verify that works as before.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1646015
------------------------------------------------------------------------
r45395 | oshima@chromium.org | 2010-04-23 03:05:09 +0200 (Fri, 23 Apr 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h

Use WidgetGtk as viewport of ScrollView to make scrolling renderers smoother.
 Changed the layout of buttons on notification.
 This fits nicer because a notification can be shorter and menu requires more hight.
Enable double buffer where necessary to avoid flicker.
Fixed a condition to close ControlViewHost.
  It should be closed when renderer is deleted.
Fixed notification_browsertest so that it passes on chromeos device.

Note: changes to native_view_host_gtk and widget_gtk are being done separately in

http://codereview.chromium.org/1725005

so you do not need to review them. I won't check this in unless that one is approved.

BUG=23445,33306
TEST=no functional change. all tests must still pass.

Review URL: http://codereview.chromium.org/1754003
------------------------------------------------------------------------
r45393 | ananta@chromium.org | 2010-04-23 02:57:50 +0200 (Fri, 23 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

Fix a Chrome crash reported in chrome frame reliability test runs. The crash happens when the ExternalTabContainer is destroyed
and it attempts to unregister the accelerators via the focus manager. The call to GetFocusManager which is implemented by the widget
causes a pure virtual function error. I was able to repro this crash once and it looks like the ExternalTabContainer is valid at this
point.

Workaround is to remember the focus manager pointer during initialization and use the same during tear down.

Should fix bug http://code.google.com/p/chromium/issues/detail?id=42365

Bug=42365

Review URL: http://codereview.chromium.org/1734007
------------------------------------------------------------------------
r45388 | mattm@chromium.org | 2010-04-23 02:20:44 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/chrome_exe.rc
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   A /trunk/src/chrome/browser/app_icon_win.cc
   A /trunk/src/chrome/browser/app_icon_win.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.h

Win: Use different icon for SxS

BUG=37119
TEST=build official exe, run with --chrome-sxs

Review URL: http://codereview.chromium.org/1727006
------------------------------------------------------------------------
r45384 | mpcomplete@chromium.org | 2010-04-23 01:56:30 +0200 (Fri, 23 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   A /trunk/src/chrome/browser/extensions/app_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   A /trunk/src/chrome/test/data/extensions/api_test/app_process
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path1
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path1/empty.html
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path2
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path2/empty.html
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path3
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/path3/empty.html
   A /trunk/src/chrome/test/data/extensions/api_test/app_process/test.html

Implement app process model isolation.

The process grouping logic is unfortunately duplicated in SiteInstance and
RenderView. URLs that are part of extension X's web extent get converted into
a pseudo URL of the form chrome-extension://X/path. This groups pages from an
extension app and its offline resources into the same process.

The rest is mostly plumbing and passing data around.

BUG=41273

Review URL: http://codereview.chromium.org/1735004
------------------------------------------------------------------------
r45381 | shess@chromium.org | 2010-04-23 01:37:32 +0200 (Fri, 23 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Omnibox popup icons and text lined up under toolbar.

Make the icons line up under the star icon, and the text line up under
the field text.

BUG=42338
TEST=Start typing, verify that things like up.  Use Pixie.app if you need magnification.

Review URL: http://codereview.chromium.org/1729007
------------------------------------------------------------------------
r45380 | evan@chromium.org | 2010-04-23 01:28:05 +0200 (Fri, 23 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/app/gtk_util.cc
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/base_paths_posix.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   D /trunk/src/base/linux_util_unittest.cc
   D /trunk/src/base/mime_util_linux.cc
   A /trunk/src/base/mime_util_xdg.cc (from /trunk/src/base/mime_util_linux.cc:45378)
   A /trunk/src/base/xdg_util.cc
   A /trunk/src/base/xdg_util.h (from /trunk/src/base/linux_util.h:45378)
   A /trunk/src/base/xdg_util_unittest.cc (from /trunk/src/base/linux_util_unittest.cc:45378)
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/common/chrome_paths_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc

bsd: refactor XDG bits of linux_util into a shared file.

This allows the shared code to build on the BSDs without
them needing to build _linux files.

Review URL: http://codereview.chromium.org/1701005
------------------------------------------------------------------------
r45378 | evan@chromium.org | 2010-04-23 01:17:27 +0200 (Fri, 23 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h

gtk: Disable the "Clear browsing data" button on the Clear Browsing Data dialog
if there is no checkbox checked.

BUG=30401
TEST=open Clear Browsing Data dialog, unckeck all checkboxes,
see if the "Clear browsing data" button is disabled.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1602007
------------------------------------------------------------------------
r45368 | estade@chromium.org | 2010-04-23 00:46:42 +0200 (Fri, 23 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_drag.cc
   M /trunk/src/chrome/browser/gtk/custom_drag.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

GTK: make download shelf drags use the download icon.

This matches drags originating in the tabbed download manager.

BUG=42147
TEST=manual

Review URL: http://codereview.chromium.org/1690002
------------------------------------------------------------------------
r45363 | dhg@chromium.org | 2010-04-23 00:14:47 +0200 (Fri, 23 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h

Changing how we get the profile for filebrowser and mediaplayer popups.
Review URL: http://codereview.chromium.org/1700006
------------------------------------------------------------------------
r45362 | sky@chromium.org | 2010-04-23 00:12:11 +0200 (Fri, 23 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes bug in duplicating pinned tabs where duplicating a pinned tab
would only make the duplicated tab pinned if it was the last pinned
tab. Now the duplicated tab is always pinned.

BUG=41418
TEST=create two pinned tabs, duplicate the first and make sure the
newly duplicated tab is pinned and between the first and second tabs.

Review URL: http://codereview.chromium.org/1694010
------------------------------------------------------------------------
r45358 | davemoore@chromium.org | 2010-04-22 23:36:23 +0200 (Thu, 22 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc

Need to get profile after the login-user flag is processed
BUG=chromiumos:2212
TEST=LoginProfileTest.UserPassed

Review URL: http://codereview.chromium.org/1714005
------------------------------------------------------------------------
r45356 | arv@chromium.org | 2010-04-22 23:26:46 +0200 (Thu, 22 Apr 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/splitpane.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/splitter.js (from /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/splitpane.js:45197)
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/chrome_browser.gypi

Refactor the split pane element into a splitter element.

The reason for the refactoring is so that the splitter can be used in cases where there are multiple columns.

This also adds a workaround for https://bugs.webkit.org/show_bug.cgi?id=32230 which causes the splitter to not work correctly when the page is zoomed.

BUG=42282, 42290
TEST=Open the bookmark manager. Zoom the page. Then drag the splitter.

Review URL: http://codereview.chromium.org/1763004
------------------------------------------------------------------------
r45355 | aa@chromium.org | 2010-04-22 23:25:09 +0200 (Thu, 22 Apr 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/calendar_app
   A /trunk/src/chrome/browser/resources/calendar_app/128.png
   A /trunk/src/chrome/browser/resources/calendar_app/24.png
   A /trunk/src/chrome/browser/resources/calendar_app/32.png
   A /trunk/src/chrome/browser/resources/calendar_app/48.png
   A /trunk/src/chrome/browser/resources/docs_app
   A /trunk/src/chrome/browser/resources/docs_app/128.png
   A /trunk/src/chrome/browser/resources/docs_app/24.png
   A /trunk/src/chrome/browser/resources/docs_app/32.png
   A /trunk/src/chrome/browser/resources/docs_app/48.png
   A /trunk/src/chrome/browser/resources/gmail_app
   A /trunk/src/chrome/browser/resources/gmail_app/128.png
   A /trunk/src/chrome/browser/resources/gmail_app/24.png
   A /trunk/src/chrome/browser/resources/gmail_app/32.png
   A /trunk/src/chrome/browser/resources/gmail_app/48.png

Add new binary files for sample apps. Need to submit these separately
because try servers don't like binary files.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r45349 | erikkay@chromium.org | 2010-04-22 22:48:07 +0200 (Thu, 22 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc

respect app launch container

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1743003
------------------------------------------------------------------------
r45343 | japhet@chromium.org | 2010-04-22 22:25:18 +0200 (Thu, 22 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc

Move code to size a restored tab on initialization from SessionRestore::RestoreTabsToBrowser()
to Browser::AddRestoredTab().

BUG=40232
TEST=none

Review URL: http://codereview.chromium.org/1642013
------------------------------------------------------------------------
r45333 | dhollowa@chromium.org | 2010-04-22 20:27:16 +0200 (Thu, 22 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/fax_field.cc
   M /trunk/src/chrome/browser/autofill/fax_field.h
   M /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field.h

AutoFill crash in FormStructure::GetHeuristicAutoFillTypes().

Fixes over-delete in FormStructure::GetHeuristicFieldInfo and adds defensive checks for NULL in FormStructure::GetHeuristicAutoFillTypes().
Also makes explicit copy constructors for various form field types.

BUG=42211
TEST=FormStructureTest

Review URL: http://codereview.chromium.org/1744005
------------------------------------------------------------------------
r45331 | bulach@chromium.org | 2010-04-22 20:23:18 +0200 (Thu, 22 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   A /trunk/src/chrome/browser/extensions/extension_install_ui_browsertest.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/chrome_tests.gypi

Before creating a theme info bar, check if one is already visible for the same theme.

(landing for satish@chromium.org, original http://codereview.chromium.org/1745003/show)
This allows user to easily undo a theme install if they accidentally installed the same theme multiple times.
BUG=40856
TEST=visit the themes gallery, install the same theme twice and hit 'Undo' in the theme info bar to verify that it rolls back to the correct previous theme.

Review URL: http://codereview.chromium.org/1771001
------------------------------------------------------------------------
r45330 | georgey@chromium.org | 2010-04-22 20:15:03 +0200 (Thu, 22 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc

Fix memory leak for autofil profiles and credit cards.
BUG=42185
TEST=In the bug.
Review URL: http://codereview.chromium.org/1732004
------------------------------------------------------------------------
r45323 | arv@chromium.org | 2010-04-22 19:20:26 +0200 (Thu, 22 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP Apps - provide a tooltip in case the app name does not fit.

BUG=None
TEST=Install an app with a long enough title to show the ellipsis. Hower over the icon and a tooltip should be shown.

Review URL: http://codereview.chromium.org/1728006
------------------------------------------------------------------------
r45322 | erg@chromium.org | 2010-04-22 19:10:27 +0200 (Thu, 22 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h

GTK: Implement OnDragCanceled() for autocomplete popup view on linux.

Pressing escape while performing a drag inside the autocomplete popup should
abort the drag and not changed the selected item. This is a rewrite of
pkasting's r37724 for GTK instead of views.

BUG=35710
TEST=none

Review URL: http://codereview.chromium.org/1758002
------------------------------------------------------------------------
r45319 | phajdan.jr@chromium.org | 2010-04-22 18:23:51 +0200 (Thu, 22 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init_browsertest.cc

Mark BrowserInitTest.OpenURLsPopup as flaky.

TBR=avi

TEST=flaky
BUG=42318

Review URL: http://codereview.chromium.org/1735005
------------------------------------------------------------------------
r45316 | sky@chromium.org | 2010-04-22 17:24:14 +0200 (Thu, 22 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Makes tests on chromeos not run a nested message loop.

I had to do two changes to existing tests to get these to work:

. Wizard tests wait until all the wizard related classes have been destroyed. At the time the tests want to quit the wizard classes haven't been shut down, so I needed to add an event to know when this happens. See comment as to why this is the case.
. PanelBrowserTests were flakey because they were waiting for page to load, which can happen before javascript finishes completing.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1735001
------------------------------------------------------------------------
r45315 | phajdan.jr@chromium.org | 2010-04-22 17:11:15 +0200 (Thu, 22 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Disable crashy TaskManagerBrowserTest.ReloadExtension on Windows.

TBR=aa

TEST=still crashy on Windows
BUG=42315

Review URL: http://codereview.chromium.org/1737004
------------------------------------------------------------------------
r45313 | phajdan.jr@chromium.org | 2010-04-22 16:59:26 +0200 (Thu, 22 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/notifications_apitest.cc

Mark ExtensionApiTest.Notifications as flaky.

TBR=rafaelw

TEST=still flaky
BUG=42314

Review URL: http://codereview.chromium.org/1690006
------------------------------------------------------------------------
r45309 | bauerb@chromium.org | 2010-04-22 15:09:45 +0200 (Thu, 22 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   A /trunk/src/chrome/browser/dummy_pref_store.cc
   A /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/browser/json_pref_store.cc
   A /trunk/src/chrome/browser/json_pref_store.h
   A /trunk/src/chrome/browser/json_pref_store_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   A /trunk/src/chrome/browser/pref_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/pref_service/invalid.json
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Reland "Factor out reading and writing of preferences into |PrefStore|."

The CL now applies after r45225 (Throw out preferences files that are corrupt rather than keeping them in read-only mode), which means that the changes in that commit moved to JsonPrefStore.

I updated JsonPrefStoreTest.InvalidFile to test the new behavior.

***

In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.

Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.

BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*

Review URL: http://codereview.chromium.org/1717007
------------------------------------------------------------------------
r45308 | phajdan.jr@chromium.org | 2010-04-22 14:59:25 +0200 (Thu, 22 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Disable crashy TaskManagerBrowserTest.PopulateWebCacheFields

TBR=jamesr

TEST=still crashy
BUG=42301

Review URL: http://codereview.chromium.org/1722005
------------------------------------------------------------------------
r45298 | yusukes@google.com | 2010-04-22 11:31:36 +0200 (Thu, 22 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Tiny cleanup. Remove an unnecessary call in ChangeLocale().
We don't have to update input method descriptors since they are not related to locales.

BUG=none
TEST=ran browser_tests.

Review URL: http://codereview.chromium.org/1723008
------------------------------------------------------------------------
r45297 | satorux@chromium.org | 2010-04-22 10:51:43 +0200 (Thu, 22 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Compute the horizontal offset at run time in the candidate window.

We used to use a magic number 30 to do the aligning but
with this change, we'll compute the horizontal offset at run time.
This is much cleaner, and more precise.

TEST=manually
BUG=crosbug.com/2720

Review URL: http://codereview.chromium.org/1711007
------------------------------------------------------------------------
r45296 | kinuko@chromium.org | 2010-04-22 08:13:16 +0200 (Thu, 22 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Marks TestRedirectHTTPToBadHTTPS as flaky.

BUG=40932
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/1747009
------------------------------------------------------------------------
r45295 | joth@chromium.org | 2010-04-22 08:07:03 +0200 (Thu, 22 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm

Possible fix / workaround for issue where infobar fails to show

BUG=41712
TEST=as per bug comment 8 http://crbug.com/41712#c8

Review URL: http://codereview.chromium.org/1679002
------------------------------------------------------------------------
r45292 | yusukes@google.com | 2010-04-22 06:29:28 +0200 (Thu, 22 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

- Adding Chrome preferences for ibus-pinyin.
- Moving all input method related constants from preferences.cc to language_preferences.h.

This change is necessary to implement a configuration dialog for Pinyin input method.

BUG=crosbug.com/488
TEST=ran browser_tests

Review URL: http://codereview.chromium.org/1631030
------------------------------------------------------------------------
r45286 | sanjeevr@google.com | 2010-04-22 05:59:55 +0200 (Thu, 22 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h

Removed dependency on AuthWatcher in the TalkMediator class. So now the TalkMediator::Login method has to be explicitly called.
BUG=None
TEST=Test Bookmarks Sync notifications.

Review URL: http://codereview.chromium.org/1737002
------------------------------------------------------------------------
r45279 | dhollowa@chromium.org | 2010-04-22 05:17:40 +0200 (Thu, 22 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_hover_state.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm

Bookmark Hover: Introduced an over-delete with attempt at timer safety.

Removing redundant timer supspension.  This was causing an over delete when dragging to parent folder.

BUG=40006
TEST=BookmarkBarFolderControllerTest.HoverState

Review URL: http://codereview.chromium.org/1766003
------------------------------------------------------------------------
r45273 | jamesr@chromium.org | 2010-04-22 03:25:42 +0200 (Thu, 22 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc

Revert 45263 - We check for a sync specific service URL (or an empty) one before acting on a notification from TalkMediator.
BUG=None
TEST=Test Bookmarks Sync Notifications.

Review URL: http://codereview.chromium.org/1700003

TBR=sanjeevr@google.com
Review URL: http://codereview.chromium.org/1694009
------------------------------------------------------------------------
r45272 | jamesr@chromium.org | 2010-04-22 03:24:55 +0200 (Thu, 22 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc

Revert 45257 - Delete and recreate the sync database if it is corrupt.

BUG=40020
TEST=DirectoryBackingStoreTest.Corruption

Review URL: http://codereview.chromium.org/1733008

TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/1733009
------------------------------------------------------------------------
r45268 | shess@chromium.org | 2010-04-22 02:16:20 +0200 (Thu, 22 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

GTK fix merge failure in uber-revert.

BookmarkBubbleGtk::Show()'s signature changed but was mis-merged in
revert of r43146 (http://codereview.chromium.org/1491003).

BUG=none
TEST=waterfall
TBR=pkasting@chromium.org

Review URL: http://codereview.chromium.org/1695005
------------------------------------------------------------------------
r45267 | shess@chromium.org | 2010-04-22 02:03:07 +0200 (Thu, 22 Apr 2010) | 93 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resources/frame_default.png
   M /trunk/src/app/resources/frame_default_inactive.png
   M /trunk/src/app/resources/window_bottom_left_corner.png
   M /trunk/src/app/resources/window_bottom_right_corner.png
   D /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/content_top_left_corner.png
   D /trunk/src/chrome/app/theme/content_top_left_corner_mask.png
   M /trunk/src/chrome/app/theme/content_top_right_corner.png
   D /trunk/src/chrome/app/theme/content_top_right_corner_mask.png
   A /trunk/src/chrome/app/theme/ev_secure.png
   M /trunk/src/chrome/app/theme/geolocation_allowed_locationbar_icon.png
   M /trunk/src/chrome/app/theme/geolocation_denied_locationbar_icon.png
   M /trunk/src/chrome/app/theme/location_bar_keyword_search_c.png
   M /trunk/src/chrome/app/theme/location_bar_keyword_search_l.png
   M /trunk/src/chrome/app/theme/location_bar_keyword_search_r.png
   A /trunk/src/chrome/app/theme/lock_small.png
   A /trunk/src/chrome/app/theme/o2_globe.png
   A /trunk/src/chrome/app/theme/o2_globe_selected.png
   A /trunk/src/chrome/app/theme/o2_globe_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_history.png
   A /trunk/src/chrome/app/theme/o2_history_selected.png
   A /trunk/src/chrome/app/theme/o2_history_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_more.png
   A /trunk/src/chrome/app/theme/o2_more_selected.png
   A /trunk/src/chrome/app/theme/o2_more_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_search.png
   A /trunk/src/chrome/app/theme/o2_search_selected.png
   A /trunk/src/chrome/app/theme/o2_search_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_star.png
   A /trunk/src/chrome/app/theme/o2_star_selected.png
   A /trunk/src/chrome/app/theme/o2_star_selected_dark.png
   D /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_c.png
   D /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_l.png
   D /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_r.png
   D /trunk/src/chrome/app/theme/omnibox_history.pdf
   D /trunk/src/chrome/app/theme/omnibox_history.png
   D /trunk/src/chrome/app/theme/omnibox_history_dark.png
   D /trunk/src/chrome/app/theme/omnibox_history_dark_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_history_selected.png
   D /trunk/src/chrome/app/theme/omnibox_history_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_http.pdf
   D /trunk/src/chrome/app/theme/omnibox_http.png
   D /trunk/src/chrome/app/theme/omnibox_http_dark.png
   D /trunk/src/chrome/app/theme/omnibox_http_dark_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_http_selected.png
   D /trunk/src/chrome/app/theme/omnibox_http_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_https_invalid.pdf
   D /trunk/src/chrome/app/theme/omnibox_https_invalid.png
   D /trunk/src/chrome/app/theme/omnibox_https_valid.pdf
   D /trunk/src/chrome/app/theme/omnibox_https_valid.png
   D /trunk/src/chrome/app/theme/omnibox_https_warning.pdf
   D /trunk/src/chrome/app/theme/omnibox_https_warning.png
   D /trunk/src/chrome/app/theme/omnibox_more.pdf
   D /trunk/src/chrome/app/theme/omnibox_more.png
   D /trunk/src/chrome/app/theme/omnibox_more_dark.png
   D /trunk/src/chrome/app/theme/omnibox_more_selected.png
   D /trunk/src/chrome/app/theme/omnibox_search.pdf
   D /trunk/src/chrome/app/theme/omnibox_search.png
   D /trunk/src/chrome/app/theme/omnibox_search_dark.png
   D /trunk/src/chrome/app/theme/omnibox_search_selected.png
   D /trunk/src/chrome/app/theme/omnibox_star.pdf
   D /trunk/src/chrome/app/theme/omnibox_star.png
   D /trunk/src/chrome/app/theme/omnibox_star_dark.png
   D /trunk/src/chrome/app/theme/omnibox_star_lit.pdf
   D /trunk/src/chrome/app/theme/omnibox_star_lit.png
   D /trunk/src/chrome/app/theme/omnibox_star_selected.png
   M /trunk/src/chrome/app/theme/reload.png
   M /trunk/src/chrome/app/theme/reload_d.png
   M /trunk/src/chrome/app/theme/reload_h.png
   D /trunk/src/chrome/app/theme/reload_mask.png
   D /trunk/src/chrome/app/theme/reload_noborder_center.png
   M /trunk/src/chrome/app/theme/reload_p.png
   A /trunk/src/chrome/app/theme/secure.png
   A /trunk/src/chrome/app/theme/security_error.png
   A /trunk/src/chrome/app/theme/security_warning.png
   A /trunk/src/chrome/app/theme/star.png
   A /trunk/src/chrome/app/theme/star_Template.pdf
   A /trunk/src/chrome/app/theme/star_d.png
   A /trunk/src/chrome/app/theme/star_h.png
   A /trunk/src/chrome/app/theme/star_mask.png (from /trunk/src/chrome/app/theme/reload_mask.png:45263)
   A /trunk/src/chrome/app/theme/star_noborder.png
   A /trunk/src/chrome/app/theme/star_noborder_center.png
   A /trunk/src/chrome/app/theme/star_p.png
   A /trunk/src/chrome/app/theme/starred.pdf
   A /trunk/src/chrome/app/theme/starred.png
   A /trunk/src/chrome/app/theme/starred_h.png
   A /trunk/src/chrome/app/theme/starred_noborder.png
   A /trunk/src/chrome/app/theme/starred_noborder_center.png
   A /trunk/src/chrome/app/theme/starred_p.png
   D /trunk/src/chrome/app/theme/tab_active_nano_center.png
   D /trunk/src/chrome/app/theme/tab_active_nano_left.png
   D /trunk/src/chrome/app/theme/tab_active_nano_right.png
   D /trunk/src/chrome/app/theme/tab_alpha_nano_left.png
   D /trunk/src/chrome/app/theme/tab_alpha_nano_right.png
   D /trunk/src/chrome/app/theme/tab_alpha_new_tab.png
   D /trunk/src/chrome/app/theme/tab_new_tab_shadow.png
   M /trunk/src/chrome/app/theme/theme_frame_default.png
   M /trunk/src/chrome/app/theme/theme_frame_default_inactive.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/app/theme/theme_toolbar_default.png
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   D /trunk/src/chrome/browser/autocomplete/autocomplete_classifier.cc
   D /trunk/src/chrome/browser/autocomplete/autocomplete_classifier.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   A /trunk/src/chrome/browser/bubble_positioner.h
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   A /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   A /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/net/browser_url_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/search_versus_navigate_classifier.cc
   A /trunk/src/chrome/browser/search_versus_navigate_classifier.h
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/theme_resources_util_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   D /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   D /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   A /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   A /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/chrome/test/test_location_bar.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/gfx/gtk_util.cc
   M /trunk/src/gfx/gtk_util.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/views/animation/bounds_animator.cc
   M /trunk/src/views/animation/bounds_animator.h
   D /trunk/src/views/animation/bounds_animator_unittest.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/custom_frame_view.cc
   D /trunk/src/views/window/window_shape.cc
   D /trunk/src/views/window/window_shape.h

Temporarily revert certain Omnibox, toolbar, tab animations, and other
UI changes for purposes of testing and merging into mstone-5.

Also ++kThemePackVersion and regenerate the cached theme pak.

Reverted changes:
r45213: GTK: Override cursor colors in chrome-theme mode.
r45103: Support drawing nano tabs in the tabstrip.
r45084: GTK: Position the EV certificate stuff inside a green bubble.
r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon...
r44957: GTK: Tint the geolocation icons in gtk mode.
r44943: Changes FormatURL to not strip http if the host starts with ft...
r44930: Remove an icon that is no longer used.
r44929: SSL UI changes, Windows, code side (images are separate).
r44859: SSL UI changes (icons).  TBRed since trybots hate binary patches.
r44822: GTK: Select better greens in the native omnibox popup.
r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat...
r44789: [Mac] Bookmark star missing on NTP and BMM.
r44775: [Mac] Centralize hack to make tests work with AutocompleteClas...
r44678: Display the SECURITY_WARNING status in the location bar for the
r44648: [Mac] Add an arrow cursor rect for the location image.
r44615: Revert r44611 because it may have broken "unit_tests" on "Vist...
r44611: Display the SECURITY_WARNING status in the location bar for the
r44577: Revert 44572 - [Mac] Update locationbar icon as user types.
r44572: [Mac] Update location-bar icon as user types.
r44555: GTK: Use correct button mask on reload button.
r44545: [Mac] Omnibox text drag drag URL when select-all.
r44523: GTK: Prevent inappropriate drag of location bar location icon.
r44519: GTK: make the primary selection include the url's scheme when ...
r44492: [Mac] Fix search icon in keyword search to be right-side-up.
r44415: GTK: Update top padding on icons in the autocomplete popup.
r44401: GTK: Tint omnibox icons in GTK mode differently.
r44380: GTK: Move reload in gtk mode and fix omnibox popup location.
r44282: Fixes crash in autocomplete when typing some URLs. The problem
r44273: [Mac] PDF icons for omnibox nits.
r44269: Fix build break due to bad merge resolve
r44268: Shift omnibox dropdown in and up on Windows, and square off th...
r44178: GTK: fix TTS padding.
r44177: Round the top left and right edges of the toolbar.
r44171: Images only checkin for try server goodness.
r44163: GTK: fix padding of autocomplete popup.
r44152: [Mac] PDF icons for omnibox.
r44145: GTK: Theme the icons in the location bar and use GTK colors fo...
r44140: Strips http from the omnibox
r44131: Fixes bugs in new tab strip animations where they weren't doin...
r44116: Change the default theme colors.
r44117: Add newline to EOF to fix CrOS builder.
r44115: Make the bottom edges of the opaque frame rounded.
r44091: [Mac] No star icon or page actions in omnibox on popups.
r44087: Don't allow drag or click on location icon when editing in omn...
r44021: [GTK] Add TTS lens graphic to linux TTS box.
r44008: [Mac] Tweak location icon spacing in omnibox.
r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca...
r43972: Make the firstrun bubble point at a better spot now that the l...
r43971: [Mac] Location icon in omnibox as drag source.
r43970: Make the star and page action icons not appear on popup windows.
r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly
r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip:
r43787: Allow location icon to be dragged & dropped.  This also fixes ...
r43759: Changes end cap of tab-to-search images.
r43740: Change bookmark bar toggle to ctrl-shift-b.
r43723: Show Page Info dialog on mouse up, not mouse down.
r43677: Fix Mac build failure.
r43676: Replace omnibox icons with new set that are all the same size ...
r43596: Fix browser test TestStarButtonAccObj.
r43593: Disables TestStarButtonAccObj.
r43582: Changes tab strip to use BoundsAnimator for tab strip animatio...
r43563: GTK: don't show reload button for popup/app windows.
r43562: Star/reload shuffle, Windows version.
r43540: [Mac] Magnifying glass in keyword-search bubble.
r43482: Adds images needed for new tab animation. I'm separating this ...
r43422: Add reload mask resource.
r43392: GTK: make the location icon a drag source.
r43376: [Mac] Move star button into page-actions area of omnibox.
r43357: [Mac] Line up omnibox popup under field.
r43290: gtk: fix display of icons in omnibox popup
r43269: GTK: fix reload button.
r43249: [Mac] Rearrange SSL status icon/label in omnibox.
r43248: BrowserThemePack: Adds persistant ids for the reload endcaps.
r43241: GTK: more location bar updates.
r43191: Fix memory leak in BrowserThemePack.
r43154: GTK: set the new star button's ID
r43151: Fix bad conflict resolution for r43146.
r43146: GTK: toolbar reload/star shuffle.
r43025: Show the location bar icon (almost) all the time, and have its...
r43023: Add new images for new reload button. No code change.
r42782: Remove this icon, now that it's no longer used (due to my secu...
r42502: Omnibox M5 work, part 1: Security changes
r42245: Check in new icons for omnibox security changes alone, so that...

BUG=none
TEST=Eyjafjallajokull
R=pkasting@chromium.org,beng@chromium.org
------------------------------------------------------------------------
r45263 | sanjeevr@google.com | 2010-04-22 01:48:28 +0200 (Thu, 22 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc

We check for a sync specific service URL (or an empty) one before acting on a notification from TalkMediator.
BUG=None
TEST=Test Bookmarks Sync Notifications.

Review URL: http://codereview.chromium.org/1700003
------------------------------------------------------------------------
r45257 | albertb@chromium.org | 2010-04-22 01:17:44 +0200 (Thu, 22 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc

Delete and recreate the sync database if it is corrupt.

BUG=40020
TEST=DirectoryBackingStoreTest.Corruption

Review URL: http://codereview.chromium.org/1733008
------------------------------------------------------------------------
r45256 | jmikhail@google.com | 2010-04-22 01:07:22 +0200 (Thu, 22 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Add delete cookie option to Automation Proxy

BUG=none
TEST=none

------------------------------------------------------------------------
r45255 | dantasse@chromium.org | 2010-04-22 01:03:14 +0200 (Thu, 22 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.h

Put Autofill after Themes on Windows and Linux too, to match Mac, in the Customize Sync dialog.  (this is because we're shipping Themes first)

BUG=41833
TEST=visual inspection: bring up the Customize Sync dialog.  The Themes checkbox should be before the Autofill one.

Review URL: http://codereview.chromium.org/1715002
------------------------------------------------------------------------
r45251 | cmasone@google.com | 2010-04-22 00:16:15 +0200 (Thu, 22 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

[chromium os] Add a bit more gmail-specific email address canonicalization

When canonicalizing email addresses for login on chromium OS, we want to make sure that we're using a user's canonical gmail addres, so we ignore interstitial '.' characters already.  This adds ignoring +-suffixes, ensuring that cmasone@gmail.com == cmasone+cc@gmail.com

Review URL: http://codereview.chromium.org/1765001
------------------------------------------------------------------------
r45250 | arv@chromium.org | 2010-04-22 00:11:55 +0200 (Thu, 22 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark Manager: Fix issue where we the user could drop text on the bmm.

The problem was that we were not clearing the |dragData| so if it ever got set by doing drag and drop, further drag and drop of non bookarks used the old drag data so the UI code thought you were able to drop the old dragged bookmarks.

BUG=42241
TEST=Do some drag and dropping in the bmm. Then start to rename a folder in the tree. Now drag the selected text in the text input. You should not be able to drop this text in the tree nor on the list but you should be able to drop the text on the search text input.


Review URL: http://codereview.chromium.org/1733007
------------------------------------------------------------------------
r45248 | xiyuan@chromium.org | 2010-04-21 23:57:18 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/options_window_view.cc

Part 2 of making options dialog white on ChromeOS

BUG=<http://crosbug.com/1885>
TEST=Verify ChromeOS options dialog background if white as in mock http://www.chromium.org/chromium-os/user-experience/settings

Review URL: http://codereview.chromium.org/1725004
------------------------------------------------------------------------
r45246 | evan@chromium.org | 2010-04-21 23:41:30 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util_deprecated.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc

Remove the wstring versions of GetFileInfo, GetFileSize, GetTempDir.

TEST=compiles
BUG=24672

Review URL: http://codereview.chromium.org/1753004
------------------------------------------------------------------------
r45245 | erg@chromium.org | 2010-04-21 23:41:08 +0200 (Wed, 21 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK: Use GtkWindows instead of GtkFixed when rendering icons.

There is some weird interaction with the gtk-qt-engine. If we don't use a
GtkWindow to render the icons, we will render the GNOME default folder icon
instead of the folder icon of the current KDE theme.

BUG=37494
TEST=none

Review URL: http://codereview.chromium.org/1687006
------------------------------------------------------------------------
r45234 | chocobo@chromium.org | 2010-04-21 22:36:47 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics.cc

Landing http://codereview.chromium.org/1735003

Fixed histogram creation and retrieval for dynamic histogram samples.

TEST=none
BUG=none
TBR=semenzato
Review URL: http://codereview.chromium.org/1710006
------------------------------------------------------------------------
r45232 | xiyuan@chromium.org | 2010-04-21 22:29:27 +0200 (Wed, 21 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc

Make all options dialogs have a parent

Use last active browser window as options dialogs parent because
window manager only repsect top-level window as parent for now. That is,
we could not use options dialog as its sub dialoags' parent.

BUG=none
TEST=Verify all sub dialogs from options are not treated as toplevel window (ie they do not occupy the fulll screen).

Review URL: http://codereview.chromium.org/1751003
------------------------------------------------------------------------
r45231 | viettrungluu@chromium.org | 2010-04-21 22:29:02 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix a deprecated use of wstring/GetSwitchValue() for --file-descriptor-limit.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1764001
------------------------------------------------------------------------
r45229 | chocobo@chromium.org | 2010-04-21 22:19:04 +0200 (Wed, 21 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

2nd attempt to land http://codereview.chromium.org/1676002 for njw

WifiConfigView - support networks with 802.1x authentication by prompting the user to enter an ID, select a certificate/private key file, and enter a password for the key file, if any. 
Pass these values down the stack into ConnectToWifiNetwork(). 

TEST=Compiles and login dialog shows new fields when security is 802.1x.
BUG=none
TBR=njw
Review URL: http://codereview.chromium.org/1692005
------------------------------------------------------------------------
r45228 | mirandac@chromium.org | 2010-04-21 22:10:57 +0200 (Wed, 21 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm

Fix bug whereby an installed page action bubble points not at the page action icon.

BUG= 41374
TEST= install a page action extension. "installed bubble" points at the icon that was installed. it should work for multiple icons.
Review URL: http://codereview.chromium.org/1762001
------------------------------------------------------------------------
r45227 | avi@chromium.org | 2010-04-21 22:09:11 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Put a button to link to proxy setup into the prefs dialog.

nib changes: Added two static strings, button.

BUG=http://crbug.com/22009
TEST=as in bug

Review URL: http://codereview.chromium.org/1759001
------------------------------------------------------------------------
r45225 | erikkay@chromium.org | 2010-04-21 22:06:38 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h

Throw out preferences files that are corrupt rather than keeping them in read-only mode.  Also improve data collection a little.  See bug for details.

BUG=42151
TEST=none

Review URL: http://codereview.chromium.org/1691002
------------------------------------------------------------------------
r45222 | erg@chromium.org | 2010-04-21 21:37:54 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser_theme_pack.cc

Make sure tint for frame_incognito is stored in "Cached Theme.pak".

BUG=41743
TEST=See bug

Review URL: http://codereview.chromium.org/1758001
------------------------------------------------------------------------
r45218 | arv@chromium.org | 2010-04-21 21:14:55 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

NTP: Add some spacing between the app icons.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1707005
------------------------------------------------------------------------
r45214 | erg@chromium.org | 2010-04-21 21:06:46 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc

GTK: Fix app-modality of the cookie ask dialog.

We need to change the window groupings before we make the new dialog.

BUG=37426
TEST=none

Review URL: http://codereview.chromium.org/1732002
------------------------------------------------------------------------
r45213 | erg@chromium.org | 2010-04-21 21:05:18 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/gfx/gtk_util.cc
   M /trunk/src/gfx/gtk_util.h

GTK: Override cursor colors in chrome-theme mode.

On dark gtk themes with light text, the cursor is often white, so in chrome-theme mode we had a white cursor on white background.

BUG=40094
TEST=none

Review URL: http://codereview.chromium.org/1723001
------------------------------------------------------------------------
r45209 | jhawkins@chromium.org | 2010-04-21 20:24:29 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Revert 45203 - Land http://codereview.chromium.org/1676002 for njw
tbr:njw
TEST=Compiles and login dialog shows new fields when security is 802.1x
BUG=none
Review URL: http://codereview.chromium.org/1712003

TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/1743002
------------------------------------------------------------------------
r45208 | jhawkins@chromium.org | 2010-04-21 20:23:18 +0200 (Wed, 21 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h

Revert 45206 - fix chromium os build.

TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/1697005
------------------------------------------------------------------------
r45206 | chocobo@chromium.org | 2010-04-21 20:17:21 +0200 (Wed, 21 Apr 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h

fix chromium os build.
------------------------------------------------------------------------
r45204 | xiyuan@chromium.org | 2010-04-21 19:47:01 +0200 (Wed, 21 Apr 2010) | 24 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/options/options_window_view.cc
   A /trunk/src/chrome/browser/chromeos/options/options_window_view.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/window_delegate.h

Polish ChromeOS options dialog:

- Add a chromeos OptionsWindowView that hosts options pages in a ChromeWindow
  so that it has a frame; This piece of code is based on Chrome's
  OptionsWindowView. Ideally, we should use Chrome's options view but
  we still missing underlying controls such as Tree and Table.
- Use last active browser window as options dialog's parent;
  This makes optiosn dialog transient for the browser window and window
  manager will no longer treat it as top-level window and will not move
  and resize it;
- If user switches to a new browser window and invokes options dialog again,
  close the existing one and re-opens it for the current browser window.
  This is currently supported by window manager;
- Update CustomerFrameView and WindowDelegate to make client edge optionaly;
  Options dialog has no client area padding and does not have a client
  edge per UI mock;
- Make NativeViewHost respects its background. This solves the problem that
  tab pane background is not properly cleared when hosting a native GtkVBox
  pane in TabbedPane;

BUG=<http://crosbug.com/1885>
TEST=Verify ChromeOS settings dialog looks like the mocks in http://www.chromium.org/chromium-os/user-experience/settings

Review URL: http://codereview.chromium.org/1672003
------------------------------------------------------------------------
r45203 | chocobo@chromium.org | 2010-04-21 19:45:51 +0200 (Wed, 21 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Land http://codereview.chromium.org/1676002 for njw
tbr:njw
TEST=Compiles and login dialog shows new fields when security is 802.1x
BUG=none
Review URL: http://codereview.chromium.org/1712003
------------------------------------------------------------------------
r45202 | erikkay@chromium.org | 2010-04-21 19:32:52 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc

Revert 45169 - Fix compile error in ShownSectionsHandlerTest.

TBR=bauerb

Review URL: http://codereview.chromium.org/1716002

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1735002
------------------------------------------------------------------------
r45201 | nick@chromium.org | 2010-04-21 19:26:53 +0200 (Wed, 21 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/mock_model_safe_workers.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/history_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc

Sync: Check that the current thread is a ModelSafeWorker's home thread.

Use this in sync_backend_host.cc to avoid dispatching to a data type
controller except when we're on the DTC's home thread.

BUG=41824
TEST=during manual testing of 2-client sync; this code is never active
during add/deletes and associates/disassociates.

Review URL: http://codereview.chromium.org/1741001
------------------------------------------------------------------------
r45200 | erikkay@chromium.org | 2010-04-21 19:24:42 +0200 (Wed, 21 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   D /trunk/src/chrome/browser/dummy_pref_store.cc
   D /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   D /trunk/src/chrome/browser/json_pref_store.cc
   D /trunk/src/chrome/browser/json_pref_store.h
   D /trunk/src/chrome/browser/json_pref_store_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   D /trunk/src/chrome/browser/pref_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/data/pref_service/invalid.json
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Revert 45168 - Reland r45028: Factor out reading and writing of preferences into |PrefStore|.

In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.

Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.

BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*

Review URL: http://codereview.chromium.org/1687001

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1688004
------------------------------------------------------------------------
r45196 | jrg@chromium.org | 2010-04-21 18:19:43 +0200 (Wed, 21 Apr 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBarFolderWindow.xib
   A /trunk/src/chrome/app/theme/menu_hierarchy_arrow.pdf
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/chrome_dll.gypi

(
Retry of http://codereview.chromium.org/1731001
Try servers not helpful since this includes a binary file.
Unfortunately I did a --gtest_filter=BookmarkBar\* to self-test
which did not include BookmarkButton* tests :-(
Only change is "size" to "cellSize" on 2nd to last line of TEST_F(BookmarkButtonCellTest, FolderArrow)
)


UI review follow-up for m5 bookmark bar deliverables

Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
works; has a little leak-thru)

BUG=42026
TEST=see description

xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView 


Review URL: http://codereview.chromium.org/1709004
------------------------------------------------------------------------
r45195 | avi@chromium.org | 2010-04-21 18:18:20 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fix spelling of Flickr.

BUG=none
TEST=make sure file uploading to Flickr still works.

Review URL: http://codereview.chromium.org/1718005
------------------------------------------------------------------------
r45190 | dhg@chromium.org | 2010-04-21 17:29:04 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h

Changing the system to only close browser windows which currently are pointed to by the filebrowser.

BUG=chromium-os:2547
TEST=NONE

Review URL: http://codereview.chromium.org/1690001
------------------------------------------------------------------------
r45189 | sky@chromium.org | 2010-04-21 17:13:47 +0200 (Wed, 21 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/external_metrics.cc
   M /trunk/src/chrome/browser/chromeos/external_metrics.h
   M /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/user_metrics.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h

Lands http://codereview.chromium.org/1610030/show from Luigi:

This changes makes histograms dynamically defined by external metrics
clients,
instead of hardcoding them in Chrome source. This is important because
making even simple changes to Chrome is laborious and takes a fair
amount of
learning. Unfortunately user actions still require code in Chrome,
because
of a pre-processing script that extracts them from the source.

BUG=NONE
TEST=the included unit test

Review URL: http://codereview.chromium.org/1718003
------------------------------------------------------------------------
r45186 | bulach@chromium.org | 2010-04-21 16:07:24 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Rename OnBlockedContentChange to OnContentSettingsChange.

BUG=None
TEST=compiles

(Patch from Thiago Farina <thiago.farina@gmail.com> http://codereview.chromium.org/1664003/show)

Review URL: http://codereview.chromium.org/1750002
------------------------------------------------------------------------
r45172 | glotov@google.com | 2010-04-21 11:39:54 +0200 (Wed, 21 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/mock_screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Implementation details of 1596023 (UI Language switch implemented).

DEPENDS_ON=1648004 (http://codereview.chromium.org/1648004/show)
DEPENDS_ON=1596023 (http://codereview.chromium.org/1596023/show)
DEPENDS_ON=1568033 (http://codereview.chromium.org/1568033/show)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1551029
------------------------------------------------------------------------
r45169 | bauerb@chromium.org | 2010-04-21 11:05:02 +0200 (Wed, 21 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc

Fix compile error in ShownSectionsHandlerTest.

TBR=bauerb

Review URL: http://codereview.chromium.org/1716002
------------------------------------------------------------------------
r45168 | bauerb@chromium.org | 2010-04-21 10:49:53 +0200 (Wed, 21 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   A /trunk/src/chrome/browser/dummy_pref_store.cc
   A /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/browser/json_pref_store.cc
   A /trunk/src/chrome/browser/json_pref_store.h
   A /trunk/src/chrome/browser/json_pref_store_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   A /trunk/src/chrome/browser/pref_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/pref_service/invalid.json
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Reland r45028: Factor out reading and writing of preferences into |PrefStore|.

In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.

Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.

BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*

Review URL: http://codereview.chromium.org/1687001
------------------------------------------------------------------------
r45158 | bauerb@chromium.org | 2010-04-21 09:31:11 +0200 (Wed, 21 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/download_page1.html
   A /trunk/src/chrome/test/data/download_page2.html
   A /trunk/src/chrome/test/data/download_page3.html
   A /trunk/src/chrome/test/data/download_page4.html

Close a newly opened (by cmd-clicking on a link) tab if it resulted in a download.

To test this, the CL adds an automation message AutomationMsg_NavigateAsyncWithDisposition, and a method NavigateToURLAsyncWithDisposition to TabProxy.

The only functional change is in TabContents::OnStartDownload, the rest of the changes is for testing.

BUG=10764
TEST=DownloadTest.CloseNewTab
Manual test: go to http://build.chromium.org/buildbot/continuous/mac/LATEST/, open the link "chrome-mac.zip" in a new tab. The tab should close as soon as the download starts.

Review URL: http://codereview.chromium.org/1151007
------------------------------------------------------------------------
r45155 | yusukes@google.com | 2010-04-21 08:33:24 +0200 (Wed, 21 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

Change input method hot-keys.

- Remove Shift+space following alcor's offline suggestion. He said we should not use the key combination since it will be used if the user holds down shift while TYPING A STRING.
- Add Shift+Alt. The combination seems to be popular at least in Windows:
http://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts (see the "Toggle between installed keyboard languages" part.)

Let's ship R7 with "Alt+`" and "Shift+Alt" and then get feedback from users.

BUG=crosbug.com/492
TEST=manual

Review URL: http://codereview.chromium.org/1568041
------------------------------------------------------------------------
r45153 | yusukes@google.com | 2010-04-21 08:15:01 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

Disable the language menu button when no text input area is focused.

BUG=crosbug.com/2639
TEST=ran browser_tests

Review URL: http://codereview.chromium.org/1645012
------------------------------------------------------------------------
r45152 | jrg@chromium.org | 2010-04-21 07:45:50 +0200 (Wed, 21 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBarFolderWindow.xib
   D /trunk/src/chrome/app/theme/menu_hierarchy_arrow.pdf
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/chrome_dll.gypi

Revert 45151 - UI review followup for m5 bookmark bar deliverables

Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
  works; has a little leakthru)

BUG=42026
TEST=see description

xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView 
 
Review URL: http://codereview.chromium.org/1731001

TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/1727004
------------------------------------------------------------------------
r45151 | jrg@chromium.org | 2010-04-21 07:31:07 +0200 (Wed, 21 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBarFolderWindow.xib
   A /trunk/src/chrome/app/theme/menu_hierarchy_arrow.pdf
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/chrome_dll.gypi

UI review follow-up for m5 bookmark bar deliverables

Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
  works; has a little leak-thru)

BUG=42026
TEST=see description

xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView 
 
Review URL: http://codereview.chromium.org/1731001
------------------------------------------------------------------------
r45147 | feldstein@chromium.org | 2010-04-21 06:23:53 +0200 (Wed, 21 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc

Fix crash in bookmark manager dropping code

Right now whenever you drag bookmarks into the bookmark manager, the extension
code tells it there is new dragData via bookmarkManager.onDragEnter.  This data
sticks around and is never cleared for various reasons, and when you drop random
text onto "Other bookmarks" the JS thinks it has valid drag data, but the data
in the actual dragging clipboard is invalid.  This just checks for that and
bails early.

The reason onDragEnded is never called is because we call preventDefault during
onDragStart.  Fixing this won't be sufficient because the JS dragdata will still
be populated if you drag in from an external app.

BUG=41087
TEST=See bug for repro steps.

Review URL: http://codereview.chromium.org/1717003
------------------------------------------------------------------------
r45146 | jhawkins@chromium.org | 2010-04-21 06:09:58 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/fax_field.cc
   A /trunk/src/chrome/browser/autofill/fax_field.h
   A /trunk/src/chrome/browser/autofill/fax_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill: Add a simple heuristic to match fax fields.

BUG=40062
TEST=FaxFieldTest

Review URL: http://codereview.chromium.org/1706005
------------------------------------------------------------------------
r45144 | satorux@chromium.org | 2010-04-21 05:52:56 +0200 (Wed, 21 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Use new APIs in candidate_window.cc

BUG=crosbug.com/2717

Review URL: http://codereview.chromium.org/1551040
------------------------------------------------------------------------
r45139 | estade@chromium.org | 2010-04-21 03:16:14 +0200 (Wed, 21 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Task Manager sorting:

- remove dead code that papered over the fact certain columns don't sort, replace with NOTREACHED pothole
- allow sorting by the javascript memory column.
- allow sorting by goats teleported (useful for debugging)
- stabilize \# of goats teleported (remove observer effect)

BUG=42037
TEST=sort by these columns in the task manager

Review URL: http://codereview.chromium.org/1706002
------------------------------------------------------------------------
r45133 | aa@chromium.org | 2010-04-21 02:54:10 +0200 (Wed, 21 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Put apps in app tab when launched from NTP or launcher.

Also add some space between apps.

Review URL: http://codereview.chromium.org/1744001
------------------------------------------------------------------------
r45129 | mirandac@chromium.org | 2010-04-21 02:35:01 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc

Check for proper locale before recording search engine data, or offering the search engine experimental dialog.

BUG= 37564
TEST= none

Review URL: http://codereview.chromium.org/1709003
------------------------------------------------------------------------
r45126 | stuartmorgan@chromium.org | 2010-04-21 01:47:20 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Prevent accelerated Mac plugin frame changes from being animated

BUG=42093
TEST=Open a Core Animation plugin in one tab, and the NTP (with floating bookmark bar) in another. Change back and forth. The plugin should not animate to the correct location.

Review URL: http://codereview.chromium.org/1729002
------------------------------------------------------------------------
r45123 | cmasone@google.com | 2010-04-21 01:37:56 +0200 (Wed, 21 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_notification_observers.cc
   M /trunk/src/chrome/browser/chromeos/browser_notification_observers.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc

[chromium os] Uses login notification to log uptime of login success

Landing http://codereview.chromium.org/1701002/show for sosa@chromium.org

Moves the emission of the event indicating that login has succeded to a time before we've mounted teh user's encrypted home directory, and also touches a file on disk to indicate that this has occurred.

Review URL: http://codereview.chromium.org/1713003
------------------------------------------------------------------------
r45119 | chocobo@chromium.org | 2010-04-21 01:32:49 +0200 (Wed, 21 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.h
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc

Add remembered networks. Reworked network options UI.
BUG=chromium-os:2555
TEST=none
Review URL: http://codereview.chromium.org/1662004
------------------------------------------------------------------------
r45112 | feldstein@chromium.org | 2010-04-21 01:24:25 +0200 (Wed, 21 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm

Fix crash when closing incognito window with extension

The extension_context_menu_controller was removing the pref observer in its
dealloc method, but since incognito windows have their profile destroyed when
the window is closed this would crash the browser when we try to access it. Now
it is accessed during the browser_closed notification

BUG=41025
TEST=See bug

Review URL: http://codereview.chromium.org/1619030
------------------------------------------------------------------------
r45111 | sanjeevr@google.com | 2010-04-21 01:19:39 +0200 (Wed, 21 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_mock.h
   A /trunk/src/chrome/browser/sync/notifier/listener/notification_defines.h
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Changes made to TalkMediator so that its functionality is generic (non sync-specific) and can be used by other services needing XMPP notifications. This is in preparatoion of moving these set of classes to common.
BUG=None
TEST=Test Bookmarks sync. The sync unit-tests have been modified accordingly.

Review URL: http://codereview.chromium.org/1650009
------------------------------------------------------------------------
r45110 | erg@chromium.org | 2010-04-21 01:18:35 +0200 (Wed, 21 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

GTK: Fix the sensitivity of the "end process" button.

When no task is selected, the end process button shouldn't be enabled. When
an entry is removed, we should check to see if we removed the currently
selected item.

BUG=40836
TEST=none

Review URL: http://codereview.chromium.org/1723002
------------------------------------------------------------------------
r45109 | cmasone@google.com | 2010-04-21 01:17:14 +0200 (Wed, 21 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc

Extra logging for in-chrome-auth
Review URL: http://codereview.chromium.org/1710001
------------------------------------------------------------------------
r45107 | glotov@google.com | 2010-04-21 01:15:41 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

LocaleChanged() added to update the view after the UI language was switched.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1568033
------------------------------------------------------------------------
r45106 | sky@chromium.org | 2010-04-21 01:15:21 +0200 (Wed, 21 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.h

Lands http://codereview.chromium.org/1649009/show from Thiago:

Use BaseBookmarkModelObserver when all events funel into a single method.

Using it, instead of BookmarkModelObserver, we can simplify the
BookmarkContextMenuController.

BUG=None
TEST=everything should works as before.

Review URL: http://codereview.chromium.org/1692001
------------------------------------------------------------------------
r45104 | jhawkins@chromium.org | 2010-04-21 01:12:31 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc

AutoFill: Don't match empty profile values with empty field values.

BUG=none
TEST=AutoFillManagerTest.*

Review URL: http://codereview.chromium.org/1733001
------------------------------------------------------------------------
r45103 | finnur@chromium.org | 2010-04-21 01:12:18 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/tab_active_nano_center.png
   A /trunk/src/chrome/app/theme/tab_active_nano_left.png
   A /trunk/src/chrome/app/theme/tab_active_nano_right.png
   A /trunk/src/chrome/app/theme/tab_alpha_nano_left.png
   A /trunk/src/chrome/app/theme/tab_alpha_nano_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Support drawing nano tabs in the tabstrip.

BUG=42146
TEST=Launch an Extension App and make sure it is visually differently drawn than anything else. 

Review URL: http://codereview.chromium.org/1689002
------------------------------------------------------------------------
r45095 | mattm@chromium.org | 2010-04-21 00:14:07 +0200 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertTrust.cpp
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertTrust.h

Linux: Populate certificate manager with certificates.

BUG=19991
TEST=manual

Review URL: http://codereview.chromium.org/1660007
------------------------------------------------------------------------
r45094 | jcivelli@google.com | 2010-04-21 00:14:06 +0200 (Wed, 21 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/translate.js
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate_helper.cc
   M /trunk/src/chrome/renderer/translate_helper.h
   M /trunk/src/chrome/renderer/translate_helper_unittest.cc

Translate now supports translating pages for which we
don't know the original language: if the browser specifies undefined for the source language, we use the translate element in the page to detect the language.

BUG=40857
TEST=See bug.

Review URL: http://codereview.chromium.org/1508030
------------------------------------------------------------------------
r45092 | mirandac@chromium.org | 2010-04-21 00:08:50 +0200 (Wed, 21 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   M /trunk/src/chrome/browser/views/first_run_search_engine_view.h
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

1. Add more search engine types.
2. Change "GetSearchEngineType" function to use the short name to get the search engine type if we can't choose by prepopulate_id. 
3. Disable the close button. (Next CL will remove it, if possible, but this requires adding a method to window_delegate.h).
4. Close the search engine view immediately if the user launches the keyword editor view.  Pass the SearchEngineViewObserver object (the FirstRunView) to the keyword editor, who will call back to the waiting observer when closed.


BUG= none
TEST= none
Review URL: http://codereview.chromium.org/1539044
------------------------------------------------------------------------
r45087 | jhawkins@chromium.org | 2010-04-21 00:01:17 +0200 (Wed, 21 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   A /trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill: Segregate profile and credit card filling.
* Refactor suggestions filling into Get[Profile,CreditCard]Suggestions.
* Don't fill the default credit card when the AutoFill shortcut is initiated.
* Don't fill the default credit card when filling the profile.

BUG=41334
TEST=none

Review URL: http://codereview.chromium.org/1619029
------------------------------------------------------------------------
r45086 | nirnimesh@chromium.org | 2010-04-21 00:00:43 +0200 (Wed, 21 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/test/pyautolib/history_info.py

Add info about starred history items.

This is the last bit of info we needed from the chrome://history/ page (
the one I forgot to add in the last CL).

With this, we can write tests combining history and bookmarks!

Review URL: http://codereview.chromium.org/1618032
------------------------------------------------------------------------
r45084 | erg@chromium.org | 2010-04-20 23:57:35 +0200 (Tue, 20 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.h

GTK: Position the EV certificate stuff inside a green bubble.

This patch explicitly doesn't move the EV certificate bubble one pixel to the
left; that's hairier than expected and will be a separate patch.

BUG=41999
TEST=none

Review URL: http://codereview.chromium.org/1528046
------------------------------------------------------------------------
r45077 | ben@chromium.org | 2010-04-20 22:50:14 +0200 (Tue, 20 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/test/test_browser_window.h

Revert 45065 - Relanding this. Originally landed as http://codereview.chromium.org/1001003 but reverted due to reliability crashes.
Relanding so I can see what those crashes are. Please do not revert without informing me.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1655010

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/1715001
------------------------------------------------------------------------
r45072 | estade@chromium.org | 2010-04-20 22:03:29 +0200 (Tue, 20 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

GTK: fix task manager grouped row selection

more sorted-path/unsorted-path conversion hoop jumping

BUG=41564
TEST=manual

Review URL: http://codereview.chromium.org/1630031
------------------------------------------------------------------------
r45070 | arv@chromium.org | 2010-04-20 22:01:02 +0200 (Tue, 20 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc
   M /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Add app section to NTP.

This changes the NTP to closer match Cole's mocks. Here are some of the differences:

1. Show app icons if the user has any extension apps installed
2. Remove most visited list. Only thumbnail support from now on.
3. Remove the checkboxes for list vs thumb mode.
4. Add a caption for the most visited section.
5. Make the captions click targets for toggling the sections.
6. Multiple collapsed sections are on the same line
7. Move tips to the upper right.
8. Fix bug where we always reserved padding for the promo messages which lead to scrollbars showing up in cases where we don't want them.
9. Use the App icon instead of a dummy icon

BUG=41270

TEST=Start with --enable-extension-apps and install some apps. These should show up on the NTP

Review URL: http://codereview.chromium.org/1646014
------------------------------------------------------------------------
r45068 | arv@chromium.org | 2010-04-20 21:57:56 +0200 (Tue, 20 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

    NTP theme change

    Submitting the css file separately due to SVN issues.

    BUG=41270
    TEST=None
    TBR=miranda
------------------------------------------------------------------------
r45066 | twiz@chromium.org | 2010-04-20 21:44:53 +0200 (Tue, 20 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup_sizing.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/tabs_util.js


Correction of sizing of experimental.extension.popup.* windows. When displaying a popup with 'rectangle' chrome, the system makes use of views::Border. The code was not accounting for the decrease in client area due to the border insets when responding to preferred size notifications. 

BUG=40688
TEST=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/1524019
------------------------------------------------------------------------
r45065 | ben@chromium.org | 2010-04-20 21:42:19 +0200 (Tue, 20 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/test/test_browser_window.h

Re-landing this. Originally landed as http://codereview.chromium.org/1001003 but reverted due to reliability crashes.
Re-landing so I can see what those crashes are. Please do not revert without informing me.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1655010
------------------------------------------------------------------------
r45064 | thestig@chromium.org | 2010-04-20 21:38:51 +0200 (Tue, 20 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc

Add a NULL check in syncable::Directory::TakeSnapshotForSaveChanges.

BUG=41994
TEST=none

Review URL: http://codereview.chromium.org/1519039
------------------------------------------------------------------------
r45063 | pinkerton@chromium.org | 2010-04-20 21:30:24 +0200 (Tue, 20 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model.cc

Unify "create app shortcut" string ids in page menu and main menubar.
BUG=41785
TEST=see bug.
Review URL: http://codereview.chromium.org/1703001
------------------------------------------------------------------------
r45062 | inferno@chromium.org | 2010-04-20 21:20:41 +0200 (Tue, 20 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Trim whitespace and check for unsafe scheme before adding a url in context menu "Go To" item. 

BUG=41778
TEST=None

Review URL: http://codereview.chromium.org/1594039
------------------------------------------------------------------------
r45060 | wtc@chromium.org | 2010-04-20 21:17:58 +0200 (Tue, 20 Apr 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/security/resources/ssl_error.html
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc

Use the same code to handle both overridable and fatal
certificate errors.  The only difference is that the SSL
interstial page for fatal certificate errors has only one
button ("Back").

Copy ssl_roadpage.html to ssl_error.html, remove the
"proceed" button, and rename the "exit" button to "back".

The local variable |html| in SSLBlockingPage::GetHTMLContents
should not be declared as static.

Remove SSLPolicy::ShowErrorPage and
RenderViewHost::LoadAlternateHTMLString.

R=abarth,jcivelli
BUG=41360
TEST=Type https://test-ssev.verisign.com:2443/test-SSEV-revoked-verisign.html
in the location bar and hit Enter. The location bar should display that URL
with a broken certificate error status, and the Back button on the SSL
interstitial page should work.
Review URL: http://codereview.chromium.org/1613016
------------------------------------------------------------------------
r45057 | glotov@google.com | 2010-04-20 20:22:12 +0200 (Tue, 20 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc

UI Language switch implemented by propagating LocaleChanged()
notification to all the views currently active. 
Before this CL, all views were recreated instead. That was very refactoring-unsafe.

Note, this is first part of the change. It prepares overall architecture means and can be committed first.
The other part contains implementation details and is here: http://codereview.chromium.org/1551029/show

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1596023
------------------------------------------------------------------------
r45053 | dhollowa@chromium.org | 2010-04-20 19:48:59 +0200 (Tue, 20 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_hover_state.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_hover_state.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_hover_state_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac Bookmarks Folder Bar hover state refactor.

Refactoring to encapsulate hover state in a separate class.

BUG=40006
TEST=BookmarkBarFolderHoverStateTest.HoverState

Review URL: http://codereview.chromium.org/1676001
------------------------------------------------------------------------
r45052 | rohitrao@chromium.org | 2010-04-20 19:47:45 +0200 (Tue, 20 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm

[Mac] Clean up references to parentWindow_ when closing an extension popup.

BUG=40057
TEST=Install aniweather extension.  Open popup and Cmd-Q while popup is still open.  Should not crash.
Review URL: http://codereview.chromium.org/1659009
------------------------------------------------------------------------
r45041 | phajdan.jr@chromium.org | 2010-04-20 18:17:51 +0200 (Tue, 20 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Mark BrowserTest.PageLanguageDetection as flaky.

TBR=jcivelli

TEST=still flaky
BUG=42095

Review URL: http://codereview.chromium.org/1686001
------------------------------------------------------------------------
r45040 | erikkay@chromium.org | 2010-04-20 18:12:08 +0200 (Tue, 20 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js

fixing flakiness in getRecent() by spacing node creation 1ms apart so
that they have unique sequential timestamps.

BUG=40837
TEST=ExtensionApiTest.Bookmarks

Review URL: http://codereview.chromium.org/1642017
------------------------------------------------------------------------
r45038 | thomasvl@chromium.org | 2010-04-20 17:29:58 +0200 (Tue, 20 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   D /trunk/src/chrome/browser/dummy_pref_store.cc
   D /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   D /trunk/src/chrome/browser/json_pref_store.cc
   D /trunk/src/chrome/browser/json_pref_store.h
   D /trunk/src/chrome/browser/json_pref_store_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   D /trunk/src/chrome/browser/pref_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Revert 45028 - Factor out reading and writing of preferences into |PrefStore|.

In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.

Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.

BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*

Review URL: http://codereview.chromium.org/1523023

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1682001
------------------------------------------------------------------------
r45037 | thomasvl@chromium.org | 2010-04-20 17:27:12 +0200 (Tue, 20 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/json_pref_store_unittest.cc

Revert 45029 - Fix JsonPrefStoreTest.NonExistentFile.

For a nonexistent file, the PrefStore is *not* readonly, and writing would create the pref file.

I'm going to add a second test for reading a broken file afterwards.

TBR=pam@chromium.org
TEST=JsonPrefStoreTest.NonExistentFile

Review URL: http://codereview.chromium.org/1521041

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1525041
------------------------------------------------------------------------
r45034 | bulach@chromium.org | 2010-04-20 16:37:09 +0200 (Tue, 20 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/extension_proxy_uitest.cc
   A /trunk/src/chrome/test/interactive_ui/infobars_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.i

Close previous theme info bars when resetting to default theme
Select and close previous theme info bars when resetting to default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well.
(landing for satish@chromium.org / http://codereview.chromium.org/1622017/show)

BUG=35607
TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry)

Review URL: http://codereview.chromium.org/1650016
------------------------------------------------------------------------
r45031 | jochen@chromium.org | 2010-04-20 15:29:12 +0200 (Tue, 20 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc

Make radios in the content bubble a radio group.

BUG=41224
TEST=manual

Review URL: http://codereview.chromium.org/1568043
------------------------------------------------------------------------
r45029 | bauerb@chromium.org | 2010-04-20 15:16:01 +0200 (Tue, 20 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/json_pref_store_unittest.cc

Fix JsonPrefStoreTest.NonExistentFile.

For a non-existent file, the PrefStore is *not* read-only, and writing would create the pref file.

I'm going to add a second test for reading a broken file afterwards.

TBR=pam@chromium.org
TEST=JsonPrefStoreTest.NonExistentFile

Review URL: http://codereview.chromium.org/1521041
------------------------------------------------------------------------
r45028 | bauerb@chromium.org | 2010-04-20 14:54:38 +0200 (Tue, 20 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   A /trunk/src/chrome/browser/dummy_pref_store.cc
   A /trunk/src/chrome/browser/dummy_pref_store.h
   M /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/browser/json_pref_store.cc
   A /trunk/src/chrome/browser/json_pref_store.h
   A /trunk/src/chrome/browser/json_pref_store_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/pref_member_unittest.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   A /trunk/src/chrome/browser/pref_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Factor out reading and writing of preferences into |PrefStore|.

In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.

Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.

BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*

Review URL: http://codereview.chromium.org/1523023
------------------------------------------------------------------------
r45024 | jochen@chromium.org | 2010-04-20 14:03:42 +0200 (Tue, 20 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc

Adds support to collect UMA data for the mostvisited feature
TEST=Covered by standard UI tests
BUG=none

Review URL: http://codereview.chromium.org/1574032
Patch from Frank Mantek <fmantek@google.com>.
------------------------------------------------------------------------
r45023 | danno@chromium.org | 2010-04-20 14:02:46 +0200 (Tue, 20 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Re-enable history items after remove cancelled

BUG=42075
TEST=manual testing

Review URL: http://codereview.chromium.org/1627029
------------------------------------------------------------------------
r45022 | avayvod@google.com | 2010-04-20 13:51:30 +0200 (Tue, 20 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.h
   A /trunk/src/chrome/browser/chromeos/login/user_image_downloader.cc
   A /trunk/src/chrome/browser/chromeos/login/user_image_downloader.h
   A /trunk/src/chrome/browser/chromeos/login/user_image_loader.cc
   A /trunk/src/chrome/browser/chromeos/login/user_image_loader.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h

User image is downloaded from user's Google Profile if it exists upon login.
The image is used on user's view of new login screen.
Image decoding is done in sandboxed utility process.

BUG=chromiumos:2347
TEST=Run Chromium under Chromium OS with --enable-login-images and login. Check that on subsequent login screen user has an image from his/her Google Profile. Image should not be resized.

Review URL: http://codereview.chromium.org/1630012
------------------------------------------------------------------------
r45013 | eroman@chromium.org | 2010-04-20 07:24:31 +0200 (Tue, 20 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/resizableverticalsplitview.js

Minor aesthetic change on new net internals page: when you resize the window and it is in the requests view, grow the right box (details view) to fit the new space, rather than growing the left box.

BUG=37421

Review URL: http://codereview.chromium.org/1627026
------------------------------------------------------------------------
r45005 | yusukes@google.com | 2010-04-20 05:33:34 +0200 (Tue, 20 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Don't use too much space for the language indicator.

Now our indicator always uses 2-letter code like "EN", "JP" and the indicator is always written in ASCII characters in all locales (Chinese ideograms are not used, for example). So the "spacer" could be narrower now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1660013
------------------------------------------------------------------------
r45000 | sanjeevr@google.com | 2010-04-20 04:03:48 +0200 (Tue, 20 Apr 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/printing/cloud_print
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_consts.cc
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_consts.h
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.cc
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_helpers.h
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_backend.cc
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_backend.h
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc
   A /trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
   A /trunk/src/chrome/browser/printing/cloud_print/job_status_updater.cc
   A /trunk/src/chrome/browser/printing/cloud_print/job_status_updater.h
   A /trunk/src/chrome/browser/printing/cloud_print/printer_info.h
   A /trunk/src/chrome/browser/printing/cloud_print/printer_info_linux.cc
   A /trunk/src/chrome/browser/printing/cloud_print/printer_info_mac.cc
   A /trunk/src/chrome/browser/printing/cloud_print/printer_info_win.cc
   A /trunk/src/chrome/browser/printing/cloud_print/printer_job_handler.cc
   A /trunk/src/chrome/browser/printing/cloud_print/printer_job_handler.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h

First cut of Cloud Print Proxy implementation. The code is not enabled for now. Soon the cloud print proxy code will move from the browser process to a background process called the service process.
BUG=None
TEST=None for now

Review URL: http://codereview.chromium.org/1566047
------------------------------------------------------------------------
r44997 | sanjeevr@google.com | 2010-04-20 03:07:27 +0200 (Tue, 20 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h

Changed the definition of time_t in the header file for Windows. Long-term solution is to use base::Time.
BUG=None
TEST=Test Bookmarks Sync signin

Review URL: http://codereview.chromium.org/1660006
------------------------------------------------------------------------
r44993 | zork@chromium.org | 2010-04-20 02:56:03 +0200 (Tue, 20 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Add IME prefs to sync.

BUG=crosbug.com/488
TEST=Run two instances of ChromeOS with sync logged in.  Check that changes to the IME settings propagate.

Review URL: http://codereview.chromium.org/1572046
------------------------------------------------------------------------
r44985 | georgey@chromium.org | 2010-04-20 01:43:00 +0200 (Tue, 20 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes for bugs ##29090 "Downloads turns into zombies, if Incognito window is opened" and 30419 "Renderer crash triggers Chrome Exit event in particular use case"
BUG=29090,30419
TEST=Now the prompt will appear before last window of the type (incognito or not) is closed.
Review URL: http://codereview.chromium.org/1654011
------------------------------------------------------------------------
r44984 | georgey@chromium.org | 2010-04-20 01:28:32 +0200 (Tue, 20 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/encryptor_mac.mm

Removed NOTIMPLEMENTED() from Encryptor::EncryptString() and Encryptor::DecryptString() in
chrome/browser/password_manager/encryptor_mac.mm, so it does exactly the same thing as on Linux: copies unencrypted text.
BUG=25404
TEST=Filling out Autofill for CC on Mac should not assert.
Review URL: http://codereview.chromium.org/1613024
------------------------------------------------------------------------
r44979 | finnur@chromium.org | 2010-04-20 01:09:07 +0200 (Tue, 20 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   A /trunk/src/chrome/browser/views/pinned_contents_info_bubble.cc
   A /trunk/src/chrome/browser/views/pinned_contents_info_bubble.h
   M /trunk/src/chrome/chrome_browser.gypi

Subclassing the InfoBubble to handle anchoring bubbles basedon their content, not what they point to, like the one we wantto show for the extension apps.

BUG=41270
TEST=Run Chrome with --enable-extension-apps --app-launcher-new-tab and press the NewTab button. A panel should open that has a mini omnibox which should be situated right on top of the underlying omnibox.
Review URL: http://codereview.chromium.org/1572045
------------------------------------------------------------------------
r44978 | oshima@chromium.org | 2010-04-20 01:09:04 +0200 (Tue, 20 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/browser/notifications/balloon.h

Scroll notification panel so that new/updated notification is visible.
 * Updated the test so that the notifications have some text and reasonable size. (Empty string was making them smaller.)
 * Don't leave KEEPS_SIZE state when new notification is added. (test updated)
 * A couple of clean ups
   - const
   - removed unused code
   - Added utility function to avoid repeating static_cast.

BUG=41011
TEST=new TestScrollBalloonToVisible test is added. updated TestKeepSizeState.

Review URL: http://codereview.chromium.org/1638017
------------------------------------------------------------------------
r44964 | nirnimesh@chromium.org | 2010-04-19 23:41:36 +0200 (Mon, 19 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   A /trunk/src/chrome/test/functional/history.py
   A /trunk/src/chrome/test/pyautolib/history_info.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py

Add automation hooks for fetching history.

Adding a test which exercises the GetHistoryInfo() hooks.

BUG=39275
TEST=python chrome/test/functional/history.py

Review URL: http://codereview.chromium.org/1648015
------------------------------------------------------------------------
r44963 | georgey@chromium.org | 2010-04-19 23:41:32 +0200 (Mon, 19 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/webdata/web_database.cc

Encrypt credit card number in storage.
BUG=41427
TEST=In the bug.
Review URL: http://codereview.chromium.org/1576040
------------------------------------------------------------------------
r44962 | skrul@chromium.org | 2010-04-19 23:39:31 +0200 (Mon, 19 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   A /trunk/src/chrome/browser/sync/resources/gaia_login_test.html

Tweak sync setup dialog.  The goal here is to make it look more like the old version (see bug for screenshots).
BUG=41708

Changes include:
- Justify the introduction text
- Align customize/cancel buttons to the bottom of the window.

I uploaded a screen shot of the changed window to the bug.

I also created a test page that iframes the html of the login dialog so it makes it easier to work on the layer without having to compile and run chrome to see it.

Review URL: http://codereview.chromium.org/1654020
------------------------------------------------------------------------
r44960 | arv@chromium.org | 2010-04-19 23:38:28 +0200 (Mon, 19 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js

Bookmark manager: Partial fix for RTL bookmark list items.

In RTL mode we were not correctly marking the URL as LTR.

Also, since we were using two consecutive spans (display: inline) the numbers in the title could get moved to after the URL.

BUG=41709
TEST=See bug. On the bookmarks page (in RTL mode) add a page with a title with Hebrew or Arabic as well as some numbers. The title should not be split up.

Review URL: http://codereview.chromium.org/1519040
------------------------------------------------------------------------
r44957 | erg@chromium.org | 2010-04-19 23:28:34 +0200 (Mon, 19 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/geolocation_allowed_locationbar_icon.png
   M /trunk/src/chrome/app/theme/geolocation_denied_locationbar_icon.png
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Tint the geolocation icons in gtk mode.

BUG=41701
TEST=none

Review URL: http://codereview.chromium.org/1659005
------------------------------------------------------------------------
r44956 | davemoore@chromium.org | 2010-04-19 23:27:55 +0200 (Mon, 19 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos/login/login_browsertest.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/chrome_tests.gypi

Have to get the default profile before processing the -login-user
command line options to ensure that ProfileManager registers for
the necessary notifications.

BUG=chromiumos:2212
TEST=LoginProfileTest.UserPassed

Review URL: http://codereview.chromium.org/1605036
------------------------------------------------------------------------
r44955 | estade@chromium.org | 2010-04-19 23:26:37 +0200 (Mon, 19 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_drag.cc

GTK: allow bookmark manager to MOVE as well as COPY.

BUG=41601
TEST=manual

Review URL: http://codereview.chromium.org/1610035
------------------------------------------------------------------------
r44951 | ananta@chromium.org | 2010-04-19 23:01:18 +0200 (Mon, 19 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_plugin.h

Context menu operations like Cut/Copy/Paste etc would not work in pages rendered by ChromeFrame. The context menu is displayed
by the ChromeFrame plugin which grabs focus to ensure that the menu has focus, and then restores focus back once we select an
item. The latter step sends over a notification to Chrome via an automation message which then informs the view. This resets the
webview item selection which results in this bug.

Fix is to send over an additional flag to Chrome in the SetInitialFocus which indicates whether we need to inform the view about
the focus change or not.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=41523

Bug=41523

Review URL: http://codereview.chromium.org/1574033
------------------------------------------------------------------------
r44948 | aa@chromium.org | 2010-04-19 22:50:29 +0200 (Mon, 19 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Auto-launch apps after installation.

Review URL: http://codereview.chromium.org/1619026
------------------------------------------------------------------------
r44945 | davemoore@chromium.org | 2010-04-19 22:29:36 +0200 (Mon, 19 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc

Added new arg to google_authenticator_unittest so it would build.
TBR:cmasone

Revert "Revert 44935 - Allow mocking of cros api without automatically deleting the mocks"

This reverts commit 6113af35343e47bb584395d387aba96b7c435277.

Review URL: http://codereview.chromium.org/1627028
------------------------------------------------------------------------
r44942 | dhg@chromium.org | 2010-04-19 22:24:55 +0200 (Mon, 19 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing upload case to picasaweb.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1591036
------------------------------------------------------------------------
r44940 | erg@chromium.org | 2010-04-19 22:23:56 +0200 (Mon, 19 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

GTK: Calling chrome.browserAction.setIcon shouldn't hide tooltips.

Previously, when a browser action's icon changes, it caused the gtk widget
tree to be modified, which hid all tooltips. This was a problem because
several popular extensions called setIcon on a timer of a few seconds.

BUG=37489
TEST=none

Review URL: http://codereview.chromium.org/1547036
------------------------------------------------------------------------
r44938 | mmoss@chromium.org | 2010-04-19 21:50:45 +0200 (Mon, 19 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc

Revert 44935 - Allow mocking of cros api without automatically deleting the mocks

Review URL: http://codereview.chromium.org/1653011

TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/1637022
------------------------------------------------------------------------
r44935 | davemoore@chromium.org | 2010-04-19 21:24:28 +0200 (Mon, 19 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc

Allow mocking of cros api without automatically deleting the mocks

Review URL: http://codereview.chromium.org/1653011
------------------------------------------------------------------------
r44934 | jhawkins@chromium.org | 2010-04-19 21:23:22 +0200 (Mon, 19 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

AutoFill: Don't send suggestions for empty field values.

BUG=41265
TEST=none

Review URL: http://codereview.chromium.org/1574037
------------------------------------------------------------------------
r44933 | dhollowa@chromium.org | 2010-04-19 21:23:15 +0200 (Mon, 19 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillAddressFormView.xib
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm

AutoFill Mac UI telephone/fax fields now one.

Changes telephone and fax number entries in the Mac AutoFill dialog to be a single
text field for all three (1) country code, (2) area code, (3) number.

Renames address model fields city, state, country to be addressCity, addressState,
addressCountry.  This was due to subtle name clash with 'state' as a selector.

Nib changes: (1) changes bindings to reflect the renaming of city, state, and country
in the model.  (2)  collapse telephone and fax numbers from three fields each to a single field.

BUG=41233
TEST=AutoFillAddressModelTest, AutoFillCreditCardModelTest, AutoFillAddressViewControllerTest, AutoFillCreditCardViewControllerTest

Review URL: http://codereview.chromium.org/1625020
------------------------------------------------------------------------
r44929 | pkasting@chromium.org | 2010-04-19 21:01:14 +0200 (Mon, 19 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

SSL UI changes, Windows, code side (images are separate).

* Remove "Type to search" hint
* Remove "Untrusted website" label
* Add EV cert bubble, make it function like a location icon for clicks/drags
* Modify spacing for EV/tab-to-search bubbles to keep icons and text aligned with dropdown
* Change non-EV HTTPS coloring from blue to green

Mac and Linux should compile, but only some of the above changes have been made for them.  Specifically, there is no EV cert bubble, the non-EV scheme color isn't changed, and the icon/text alignment in the tab-to-search bubble hasn't been touched.

BUG=41481
TEST=paypal.com should generate a bubble around the lock and cert holder name, which responds to clicks and drags like the location icon would
Review URL: http://codereview.chromium.org/1585043
------------------------------------------------------------------------
r44926 | mpcomplete@chromium.org | 2010-04-19 20:25:04 +0200 (Mon, 19 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_iframe
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.html
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/script.js
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_iframe/test.html

Give chrome-extension frames in regular renderers access to messaging APIs,
but nothing else. This is the chrome-side of webkit bug
https://bugs.webkit.org/show_bug.cgi?id=37681

BUG=37920

Review URL: http://codereview.chromium.org/1663003
------------------------------------------------------------------------
r44925 | jhawkins@chromium.org | 2010-04-19 20:03:08 +0200 (Mon, 19 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

gtk: Store the original credit card number and save that if the user has not
edited the obfuscated cc number.

BUG=41649
TEST=none

Review URL: http://codereview.chromium.org/1672001
------------------------------------------------------------------------
r44922 | evan@chromium.org | 2010-04-19 19:26:23 +0200 (Mon, 19 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

extensions: test if the external provider exists before reading it

Cut down on some WARNING spam in the common case of no file.

BUG=41839

Review URL: http://codereview.chromium.org/1618031
------------------------------------------------------------------------
r44916 | jrg@chromium.org | 2010-04-19 18:41:24 +0200 (Mon, 19 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Paste of URL into PowerPoint2008 fails.
BUG=http://crbug.com/41842
TEST=Copy entire string from Omnibox and paste into PowerPoint2008 document.

Review URL: http://codereview.chromium.org/1671001
------------------------------------------------------------------------
r44914 | dmazzoni@chromium.org | 2010-04-19 18:12:25 +0200 (Mon, 19 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   A /trunk/src/chrome/browser/views/accessibility_event_router_views.cc
   A /trunk/src/chrome/browser/views/accessibility_event_router_views.h
   A /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc
   A /trunk/src/chrome/browser/views/accessible_view_helper.cc
   A /trunk/src/chrome/browser/views/accessible_view_helper.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add infrastructure for supporting Views to the accessibility extension api.
Only a few controls actually generate accessibility events to make sure
it works, this is mostly to get the infrastructure in place.

Note that the new files are analogous to:

  chrome/browser/gtk/accessibility_event_router_gtk.cc
  chrome/browser/gtk/accessibility_event_router_gtk.h
  chrome/browser/gtk/accessibile_widget_helper_gtk.cc
  chrome/browser/gtk/accessibile_widget_helper_gtk.h

Any design changes should be made to both sets of classes.

BUG=none
TEST=Added new unit test.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44907
Review URL: http://codereview.chromium.org/1518029
------------------------------------------------------------------------
r44913 | agl@chromium.org | 2010-04-19 18:12:05 +0200 (Mon, 19 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Fix typo which was causing unneeded logging messages.

BUG=41970

http://codereview.chromium.org/1591039
------------------------------------------------------------------------
r44909 | dmazzoni@chromium.org | 2010-04-19 17:13:38 +0200 (Mon, 19 Apr 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   D /trunk/src/chrome/browser/views/accessibility_event_router_views.cc
   D /trunk/src/chrome/browser/views/accessibility_event_router_views.h
   D /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc
   D /trunk/src/chrome/browser/views/accessible_view_helper.cc
   D /trunk/src/chrome/browser/views/accessible_view_helper.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

 Revert 44907 - Add infrastructure for supporting Views to the accessibility extension api.
Only a few controls actually generate accessibility events to make sure
it works, this is mostly to get the infrastructure in place.

Note that the new files are analogous to:

  chrome/browser/gtk/accessibility_event_router_gtk.cc
  chrome/browser/gtk/accessibility_event_router_gtk.h
  chrome/browser/gtk/accessibile_widget_helper_gtk.cc
  chrome/browser/gtk/accessibile_widget_helper_gtk.h

Any design changes should be made to both sets of classes.

BUG=none
TEST=Added new unit test.
TBR=thomasvl

Review URL: http://codereview.chromium.org/1518029

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/1664004
------------------------------------------------------------------------
r44908 | agl@chromium.org | 2010-04-19 16:51:13 +0200 (Mon, 19 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/ipc/ipc_channel_posix.cc
   A /trunk/src/sandbox/linux/selinux
   A /trunk/src/sandbox/linux/selinux/README
   A /trunk/src/sandbox/linux/selinux/chromium-browser.if
   A /trunk/src/sandbox/linux/selinux/chromium-browser.te

SELinux: add basic policy.

This patch removes the chromium_zygote_t type and adds a
chromium_renderer_t type. Also, a basic policy for chromium_renderer_t
is included.

I decided not to try to have a different policy for the zygote since
it just makes things more complex for little reason.

BUG=none
TEST=none

http://codereview.chromium.org/1104002
------------------------------------------------------------------------
r44907 | dmazzoni@chromium.org | 2010-04-19 16:33:09 +0200 (Mon, 19 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   A /trunk/src/chrome/browser/views/accessibility_event_router_views.cc
   A /trunk/src/chrome/browser/views/accessibility_event_router_views.h
   A /trunk/src/chrome/browser/views/accessibility_event_router_views_unittest.cc
   A /trunk/src/chrome/browser/views/accessible_view_helper.cc
   A /trunk/src/chrome/browser/views/accessible_view_helper.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add infrastructure for supporting Views to the accessibility extension api.
Only a few controls actually generate accessibility events to make sure
it works, this is mostly to get the infrastructure in place.

Note that the new files are analogous to:

  chrome/browser/gtk/accessibility_event_router_gtk.cc
  chrome/browser/gtk/accessibility_event_router_gtk.h
  chrome/browser/gtk/accessibile_widget_helper_gtk.cc
  chrome/browser/gtk/accessibile_widget_helper_gtk.h

Any design changes should be made to both sets of classes.

BUG=none
TEST=Added new unit test.

Review URL: http://codereview.chromium.org/1518029
------------------------------------------------------------------------
r44904 | hbono@chromium.org | 2010-04-19 07:50:13 +0200 (Mon, 19 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h

A quick fix for Issue 34970.
This issue is caused by r34322 that changes text composed by an IME. (It makes Windows reset the IME.) As a quick fix, this changes adds a new method TextField::IMEIsComposing() and call it before changing text in FindBarView::UpdateForResult().

BUG=34970
TEST=Type Ctrl+F, enable a Japanese IME, and type shift+a, return, and shift+a. Verify if the find box has two As, i.e. 'AA'. 
Review URL: http://codereview.chromium.org/1630014
------------------------------------------------------------------------
r44903 | jcivelli@chromium.org | 2010-04-19 07:29:14 +0200 (Mon, 19 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Attempt at fixing flakyness of the browser test:
BrowserTest.PageLanguageDetection.

BUG=40962
TEST=The test should not be flaky anymore.


Review URL: http://codereview.chromium.org/1642002
------------------------------------------------------------------------
r44886 | jorlow@chromium.org | 2010-04-18 10:32:31 +0200 (Sun, 18 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/extension_proxy_uitest.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.i
   D /trunk/src/chrome/test/ui/infobars_uitest.cc

Revert 44885 - Select and close previous theme info bars when resetting to default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well.

BUG=35607
TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry)

Landing http://codereview.chromium.org/1622017/show for Satish.


Review URL: http://codereview.chromium.org/1600030

TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/1599038
------------------------------------------------------------------------
r44885 | jorlow@chromium.org | 2010-04-18 07:38:54 +0200 (Sun, 18 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/extension_proxy_uitest.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.i
   A /trunk/src/chrome/test/ui/infobars_uitest.cc

Select and close previous theme info bars when resetting to default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well.

BUG=35607
TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry)

Landing http://codereview.chromium.org/1622017/show for Satish.


Review URL: http://codereview.chromium.org/1600030
------------------------------------------------------------------------
r44870 | dumi@chromium.org | 2010-04-17 04:20:14 +0200 (Sat, 17 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc

Roll WebKit's version to 57768 to pick up a change to
WebSecurityOrigin::createFromDatabaseIdentifier(), and fix all its
callers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1646013
------------------------------------------------------------------------
r44863 | evan@chromium.org | 2010-04-17 02:02:55 +0200 (Sat, 17 Apr 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/about_credits.tmpl
   A /trunk/src/chrome/browser/resources/about_credits_entry.tmpl
   M /trunk/src/tools/licenses.py

First pass at generating about:credits.

Modify the license script to have a "credits" mode, which uses
two templates derived from the existing about:credits HTML.

BUG=39240

Review URL: http://codereview.chromium.org/1520039
------------------------------------------------------------------------
r44861 | oshima@chromium.org | 2010-04-17 01:59:55 +0200 (Sat, 17 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/views/widget/widget_gtk.cc

Hover buttons for notification.
 * Chagned WidgetGtk so that any GtkFixed can be parent of WidgetGtk.
 * Close button and Options menu is moved to separate TYPE_CHILD WidgetGtk
   which is shown/hidden as mouse moves.

TODO: host Widget is not transparent right now. I'll address this in separate CL.

BUG=41011
TEST=none

Review URL: http://codereview.chromium.org/1654006
------------------------------------------------------------------------
r44860 | arv@chromium.org | 2010-04-17 01:39:26 +0200 (Sat, 17 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/dom_ui/app_launcher_handler.cc (from /trunk/src/chrome/browser/dom_ui/app_launcher_ui.cc:44702)
   A /trunk/src/chrome/browser/dom_ui/app_launcher_handler.h (from /trunk/src/chrome/browser/dom_ui/app_launcher_ui.h:44702)
   D /trunk/src/chrome/browser/dom_ui/app_launcher_ui.cc
   D /trunk/src/chrome/browser/dom_ui/app_launcher_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   D /trunk/src/chrome/browser/resources/app_launcher.html
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Use the new tab page instead of chrome://apps/ in the app launcher

BUG=None
TEST=Start chrome with --enable-extension-apps --app-launcher-new-tab. Pressing Ctrl+T should show the NTP in the overlay.

Review URL: http://codereview.chromium.org/1660005
------------------------------------------------------------------------
r44858 | estade@chromium.org | 2010-04-17 01:31:55 +0200 (Sat, 17 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc

GTK: let the extension install prompt permissions line wrap.

Changed from GtkEntry's to GtkTextViews.

BUG=41364
TEST=manual

Review URL: http://codereview.chromium.org/1582028
------------------------------------------------------------------------
r44844 | evan@chromium.org | 2010-04-17 01:00:15 +0200 (Sat, 17 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc

posix: handle the return value of close() in more places.

Generally, we don't expect it to fail and there isn't much we
can do anyway, but it's good to at least consider each case and
do something so we can continue to receive warnings in situations
where we forgot to check the return code.

(Bonus extra bugfix: use int where we previously had bool.
I think it compiles to the same thing but the old code was
definitely wrong.)

Review URL: http://codereview.chromium.org/1564037
------------------------------------------------------------------------
r44843 | jrg@chromium.org | 2010-04-17 00:57:28 +0200 (Sat, 17 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm

Fix left alignment of icons in bookmark button if title is "".
BUG=http://crbug.com/41690

TEST=\
Create a bookmark with an empty title.  Add to subfolder.  Open it -->
see it left aligned.

Review URL: http://codereview.chromium.org/1540040
------------------------------------------------------------------------
r44842 | evan@chromium.org | 2010-04-17 00:46:43 +0200 (Sat, 17 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h

Fix class/struct forward-declare mixups.

GCC doesn't mind, but clang does.

Review URL: http://codereview.chromium.org/1631025
------------------------------------------------------------------------
r44841 | evan@chromium.org | 2010-04-17 00:45:53 +0200 (Sat, 17 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_history_api.h

Remove needless friend declaration.

(It confuses Clang, since NewRunnableMethod is a function.
I've filed a Clang bug, but we didn't need it in our code anyway.)

Review URL: http://codereview.chromium.org/1658009
------------------------------------------------------------------------
r44833 | jianli@chromium.org | 2010-04-17 00:17:05 +0200 (Sat, 17 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc

Fix 2 drag-out problems:
1) Does not work if dragging out to XP desktop. We need to return an error code
   when waiting for XP Shell to start a background thread.
2) Occasional crash due to regression caused by r43726. Fix it by holding a
   local reference to drag_source_.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1619023
------------------------------------------------------------------------
r44830 | feldstein@chromium.org | 2010-04-17 00:01:25 +0200 (Sat, 17 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/draggable_button.h
   M /trunk/src/chrome/browser/cocoa/draggable_button.mm
   M /trunk/src/chrome/browser/cocoa/draggable_button_unittest.mm

Fix stuck highlight state when dragging other bookmarks folder, or when dragging something from the download shelf.

DraggingButton.mm was setting up non-draggable buttons to be ready for drag.

DownloadShelfButtons never called endDrag.

BUG=40594
TEST=Try to drag the Other Bookmarks button.  It shouldn't stay highlighted.

Review URL: http://codereview.chromium.org/1648003
------------------------------------------------------------------------
r44824 | jeremy@chromium.org | 2010-04-16 23:21:23 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm

Mac: Fix enabling & checkmarks in translate infobar options menu.

BUG=39819
TEST=Selecting "always translate" from the translate infobar options menu, a checkmark should appear next to it and the "never translate" options should be grayed out.

Review URL: http://codereview.chromium.org/1559036
------------------------------------------------------------------------
r44822 | erg@chromium.org | 2010-04-16 23:15:13 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

GTK: Select better greens in the native omnibox popup.

BUG=40126
TEST=none

Review URL: http://codereview.chromium.org/1539042
------------------------------------------------------------------------
r44821 | estade@chromium.org | 2010-04-16 23:10:32 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/gtk_signal.cc
   M /trunk/src/app/gtk_signal.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

GTK: Add a scoping class for g signals.

BUG=40735
TEST=compile; trybots; manually opening and closing a lot of infobubbles

Review URL: http://codereview.chromium.org/1652005
------------------------------------------------------------------------
r44820 | estade@chromium.org | 2010-04-16 23:09:00 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h

GTK: raise old browser windows when adding a new tab

BUG=38166
TEST=`google-chrome http://google.com` should raise the browser window.

Review URL: http://codereview.chromium.org/1646011
------------------------------------------------------------------------
r44816 | mirandac@chromium.org | 2010-04-16 22:30:14 +0200 (Fri, 16 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h

Add UMA calls to record search engine choice during first run.

BUG= 37565
TEST= UMA calls should be recorded correctly.
Review URL: http://codereview.chromium.org/1528037
------------------------------------------------------------------------
r44814 | estade@chromium.org | 2010-04-16 22:25:58 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

GTK: navigate to URL on PRIMARY when middle-clicking the location icon.

BUG=40610
TEST=manual

Review URL: http://codereview.chromium.org/1549043
------------------------------------------------------------------------
r44813 | kbr@google.com | 2010-04-16 22:24:26 +0200 (Fri, 16 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc

Addressed review feedback on previous CL introducing --in-process-webgl
flag.

BUG=39721
TEST=none

Review URL: http://codereview.chromium.org/1658007
------------------------------------------------------------------------
r44811 | ahendrickson@chromium.org | 2010-04-16 22:22:30 +0200 (Fri, 16 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/http/http_auth_handler_factory.cc
   M /trunk/src/net/http/http_auth_handler_factory.h
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   M /trunk/src/net/http/http_auth_handler_negotiate_posix.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_win.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.h
   M /trunk/src/net/http/http_auth_handler_ntlm_portable.cc
   M /trunk/src/net/http/http_auth_handler_ntlm_win.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/url_security_manager.cc
   M /trunk/src/net/http/url_security_manager.h
   M /trunk/src/net/http/url_security_manager_posix.cc
   M /trunk/src/net/http/url_security_manager_win.cc

Refactored to pass the URLSecurityManager via the HttpAuthFactory class to the HttpNetworkSession.

Fixed a bug where the command-line whitelist was not being propagated down to the URLSecurityManager.

BUG=29596
TEST=None

Review URL: http://codereview.chromium.org/1634005
------------------------------------------------------------------------
r44808 | dhg@chromium.org | 2010-04-16 21:41:56 +0200 (Fri, 16 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h
   M /trunk/src/chrome/browser/resources/filebrowse.html

fixing issues with filebrowser namely, namely allowing it to grow on mount, and fixing download cases so the flow is better.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1527036
------------------------------------------------------------------------
r44807 | sky@chromium.org | 2010-04-16 21:38:33 +0200 (Fri, 16 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   A /trunk/src/views/controls/menu/menu_host.h
   M /trunk/src/views/controls/menu/menu_host_gtk.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.h
   M /trunk/src/views/controls/menu/menu_host_root_view.cc
   M /trunk/src/views/controls/menu/menu_host_win.cc
   M /trunk/src/views/controls/menu/menu_host_win.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/menu/submenu_view.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/views_delegate.h
   M /trunk/src/views/widget/widget_gtk.cc

Fixes possible crash if the window hosting a menu was closed while the
menu was showing. When this happens the window the menu creates is
implicitly destroyed (because the parent is going away).

BUG=25563
TEST=see bug

Review URL: http://codereview.chromium.org/1664001
------------------------------------------------------------------------
r44804 | jeremy@chromium.org | 2010-04-16 21:09:11 +0200 (Fri, 16 Apr 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/nacl-loader.sb
   A /trunk/src/chrome/browser/nacl_loader.sb
   M /trunk/src/chrome/browser/utility.sb
   M /trunk/src/chrome/browser/worker.sb
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/common.sb (from /trunk/src/chrome/browser/worker.sb:44803)
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer.sb

Mac: Refactor sandbox profiles to use a common base configuration file.

Eliminate rule duplication in our sandbox profiles by creating a new common.sb file which we include implicitly at the start of all other sandbox configuration files.

BUG=39987
TEST=Chrome on Mac should continue to render pages, all unit tests should pass.

Review URL: http://codereview.chromium.org/1656006
------------------------------------------------------------------------
r44799 | zork@chromium.org | 2010-04-16 20:06:48 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Check if the icon handle has become invalid when the load callback is invoked.

BUG=40875
TEST=See bug.

Review URL: http://codereview.chromium.org/1660004
------------------------------------------------------------------------
r44798 | sky@chromium.org | 2010-04-16 20:06:27 +0200 (Fri, 16 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc

Fixes bug where GetSubtreeBookmarkManagerFunction would crash if
the node no longer exists.

BUG=41630
TEST=see bug

Review URL: http://codereview.chromium.org/1521036
------------------------------------------------------------------------
r44792 | japhet@chromium.org | 2010-04-16 19:50:07 +0200 (Fri, 16 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore.cc

Size TabContents being restored during a session restore.

BUG=40232
TEST=none


Review URL: http://codereview.chromium.org/1658004
------------------------------------------------------------------------
r44789 | shess@chromium.org | 2010-04-16 19:10:51 +0200 (Fri, 16 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm

[Mac] Bookmark star missing on NTP and BMM.

Fix to let bookmark star, page actions, and content settings show up
even when there is a search hint.  Tries to mimic Windows
LocationBarView::Layout() code.  Keyword-search mode superceeds the
location icon.  Keyword-search bubble, search hint, and ssl label can
all be omitted if there is not room for them.

BUG=40463
TEST=See bug.

Review URL: http://codereview.chromium.org/1530038
------------------------------------------------------------------------
r44783 | dhollowa@chromium.org | 2010-04-16 18:55:14 +0200 (Fri, 16 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Mac Bookmarks bar crash hovering from one folder to another.

Fix for race condition where the BookmarkBarFolderController was trying to
simultaneously open and close its hover view.  This code serializes the opening
and closing.

BUG=40006
TEST=BookmarkBarFolderControllerTest.HoverState

Review URL: http://codereview.chromium.org/1593031
------------------------------------------------------------------------
r44781 | mpcomplete@chromium.org | 2010-04-16 18:53:22 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fix a bug where opening an extension options tab from a sole incognito window
would fail to show the new window.

BUG=41526

Review URL: http://codereview.chromium.org/1545041
------------------------------------------------------------------------
r44778 | kkania@chromium.org | 2010-04-16 18:34:15 +0200 (Fri, 16 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/renderer/resources/dom_automation.js
   M /trunk/src/chrome/test/automation/dom_automation_browsertest.cc
   M /trunk/src/chrome/test/automation/dom_element_proxy.cc
   M /trunk/src/chrome/test/automation/dom_element_proxy.h
   M /trunk/src/chrome/test/automation/javascript_execution_controller.cc
   M /trunk/src/chrome/test/automation/javascript_execution_controller.h
   A /trunk/src/chrome/test/automation/javascript_message_utils.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/dom_automation/wait
   A /trunk/src/chrome/test/data/dom_automation/wait/test.html
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Add ability to manipulate DOM elements from the automation proxy. Rework the way that javascript is packaged and parsed in the JavascriptExecutionController, and add some waiting methods.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1632001
------------------------------------------------------------------------
r44775 | shess@chromium.org | 2010-04-16 18:08:56 +0200 (Fri, 16 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm

[Mac] Centralize hack to make tests work with AutocompleteClassifier.

A recent change added AutocompleteClassifier, which had to be hacked
into the testing profile to make tests with real location bars work.
Unfortunately, more code is tripping over this, so I'm moving the hack
to a central location rather than adding it case-by-case.

Issue 39725 is about removing the need for this.

BUG=39725
TEST=trybots.

Review URL: http://codereview.chromium.org/1618028
------------------------------------------------------------------------
r44756 | jcivelli@chromium.org | 2010-04-16 08:52:10 +0200 (Fri, 16 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

This CL makes the translate context menu disabled when the
page language is the same as the UI language.

BUG=39506
TEST=With Chrome configure to be in English, Visit www.google.com.
     Right click on the page, the context menu "Translate to English"
     should be disabled. Do the same on www.google.fr, the menu should
     be enabled.


Review URL: http://codereview.chromium.org/1619014
------------------------------------------------------------------------
r44755 | jrg@chromium.org | 2010-04-16 07:43:44 +0200 (Fri, 16 Apr 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBarFolderWindow.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h

Improve bookmark bar folder scroll.

BUG=39791

TEST=\
Create bookmark folders with various quantites of bookmarks.
Make sure normal folders work.
Open some that don't fit on the screen.
See rounded corners on bottom.
Try and move mouse to bottom of screen --> window grows and scrolls.
Move mouse to top of screen --> window does NOT change size but does scroll.
Move mouse off folder while scrolling --> scrolling stops.
Make sure no buttons get "stuck" with a mouse-enter (highlit).
Make sure no "getting stuck" or "window scrolls off the screen".
Briefly test subfolders.

xib changes:
- Window content view is now BookmarkBarFolderWindowContentView
- BookmaerkBarFolderView now wrapped in an NSScrollView
- Some view autosizing changed 

Review URL: http://codereview.chromium.org/1593025
------------------------------------------------------------------------
r44745 | nick@chromium.org | 2010-04-16 04:32:11 +0200 (Fri, 16 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 44712 - Merge the enableapplauncher flag with the enable
extensionapps flag since we will be using them together.

Review URL: http://codereview.chromium.org/1659004

TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/1654015
------------------------------------------------------------------------
r44742 | dcheng@chromium.org | 2010-04-16 04:16:44 +0200 (Fri, 16 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc

Fix DCHECK in web_drop_target_win.cc.
Relax the DCHECK for asserting that only one drag op is set. WebKit occasionally only sets DragOperationMove to indicate a drag move, even though the usual convention is to set both DragOperationMove and DragOperationGeneric.

BUG=41670
TEST=none

Review URL: http://codereview.chromium.org/1513044
------------------------------------------------------------------------
r44736 | akalin@chromium.org | 2010-04-16 03:41:26 +0200 (Fri, 16 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc

Made ThemeChangeProcessor handle multiple updates to work around
a problem with the syncapi.

BUG=41439
TEST=manual

Review URL: http://codereview.chromium.org/1622030
------------------------------------------------------------------------
r44732 | mattm@chromium.org | 2010-04-16 03:05:32 +0200 (Fri, 16 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Use LaunchAnotherBrowserBlockUntilClosed in SessionRestoreUITest to reduce flake.

Re-enables FLAKY_RestoreAfterClosingTabbedBrowserWithAppAndLaunching on linux.

(Using LaunchBrowser caused the process_id_ of UITest to get overwritten with the pid of the short-lived browser that sent a notification to the existing browser, so when it came time to shut down the existing browser it wouldn't send the proper shutdown commands.)

BUG=40946,39490,29110
TEST=run SessionRestoreUITest.FLAKY_RestoreAfterClosingTabbedBrowserWithAppAndLaunching and FLAKY_DontRestoreWhileIncognito a bunch

Review URL: http://codereview.chromium.org/1648012
------------------------------------------------------------------------
r44730 | skrul@chromium.org | 2010-04-16 03:05:06 +0200 (Fri, 16 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Remove extra notification from BookmarkModel::Copy.
This was causing duplicate bookmarks to be created in the sync database when a mac user uses option drag to duplicate a bookmark.

I have not run this yet on a mac to make sure it works, but I am in progress of compiling on my macbook :)

BUG=41398
TEST=unittest

Review URL: http://codereview.chromium.org/1599035
------------------------------------------------------------------------
r44729 | kbr@google.com | 2010-04-16 03:03:27 +0200 (Fri, 16 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Added --in-process-webgl command line argument to select the WebGL
implementation which runs in process rather than making the decision
based on the presence of --no-sandbox. Made this argument implicitly
disable the sandbox. Added it as an unsupported command line argument
so it pops up the infobar.

BUG=39721
TEST=ran WebGL demos on Mac and Windows with and without --in-process-webgl

Review URL: http://codereview.chromium.org/1599034
------------------------------------------------------------------------
r44726 | oshima@chromium.org | 2010-04-16 02:58:55 +0200 (Fri, 16 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc

Fix panel resize flicker:
  When adding new notification, its size is unknown until WebKit finish rendering the contents
  , so no need to update panel at this point.
  Removed BalloonViewImpl::GetPreferredSize as this is not used. (this was copied from desktop impl)

BUG=33306
TEST=none

Review URL: http://codereview.chromium.org/1519036
------------------------------------------------------------------------
r44725 | mattm@chromium.org | 2010-04-16 02:57:03 +0200 (Fri, 16 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

ProcessSingletonLinux: Allow kill to fail with "no such process".

BUG=40946
TEST=SessionRestoreUITest.FLAKY_RestoreAfterClosingTabbedBrowserWithAppAndLaunching

Review URL: http://codereview.chromium.org/1521034
------------------------------------------------------------------------
r44719 | eroman@chromium.org | 2010-04-16 02:07:48 +0200 (Fri, 16 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc

Revert 43821 - Add some temporary instrumentation to help track down a crasher.

BUG=40447
TBR=huanr
Review URL: http://codereview.chromium.org/1585019

TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/1602026
------------------------------------------------------------------------
r44714 | nick@chromium.org | 2010-04-16 00:28:18 +0200 (Fri, 16 Apr 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   D /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_test_util.cc
   D /trunk/src/net/tools/testserver/chromiumsync.py
   D /trunk/src/net/tools/testserver/chromiumsync_test.py
   M /trunk/src/net/tools/testserver/testserver.py
   D /trunk/src/third_party/protobuf2/__init__.py
   D /trunk/src/third_party/protobuf2/descriptor_pb2.py
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Revert 44708 - Python implementation of sync server, for testing.

Implement the server side of chromium sync inside of testserver.py.  The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.

Make the sync_integration_tests run by default against the test server.  An externallyprovided syncurl will give the old behavior.

Protocol buffers stuff: The test sync server requires Python generated code for .proto files.  I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf).  This might be a bad place, or a bad name  open to suggestions.  The main thing is that there will be runtime dependencies on it, so it didn't seem right to put it in obj/.

Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory.  The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.

Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port.  Very useful if a test failure leaves a server running.  Tested this against all combos of protocols, and it seems to work.

Flakiness fix: Port sync_integration_tests to the outofprocess test runner.

Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.

BUG=20905,40980

Review URL: http://codereview.chromium.org/1622012

TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/1633015
------------------------------------------------------------------------
r44712 | aa@chromium.org | 2010-04-16 00:03:25 +0200 (Fri, 16 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Merge the --enable-app-launcher flag with the --enable-
extension-apps flag since we will be using them together.

Review URL: http://codereview.chromium.org/1659004
------------------------------------------------------------------------
r44709 | erg@chromium.org | 2010-04-16 00:01:30 +0200 (Fri, 16 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h

Create a valid RendererPreferences for notification windows.

On linux, Notifications now have the correct select color, scrollbar properties and
font anti-aliasing properties.

BUG=41674
TEST=Try to highlight text in a notification. It should be highlighted.

Review URL: http://codereview.chromium.org/1613019
------------------------------------------------------------------------
r44708 | nick@chromium.org | 2010-04-15 23:56:14 +0200 (Thu, 15 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/protocol/sync_proto.gyp
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/ssl_test_util.cc
   A /trunk/src/net/tools/testserver/chromiumsync.py
   A /trunk/src/net/tools/testserver/chromiumsync_test.py
   M /trunk/src/net/tools/testserver/testserver.py
   A /trunk/src/third_party/protobuf2/__init__.py
   A /trunk/src/third_party/protobuf2/descriptor_pb2.py
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Python implementation of sync server, for testing.

Implement the server side of chromium sync inside of testserver.py.  The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.

Make the sync_integration_tests run by default against the test server.  An externally-provided --sync-url will give the old behavior.

Protocol buffers stuff: The test sync server requires Python generated code for .proto files.  I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf).  This might be a bad place, or a bad name -- open to suggestions.  The main thing is that there will be run-time dependencies on it, so it didn't seem right to put it in obj/.

Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory.  The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.

Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port.  Very useful if a test failure leaves a server running.  Tested this against all combos of protocols, and it seems to work.

Flakiness fix: Port sync_integration_tests to the out-of-process test runner.

Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.

BUG=20905,40980

Review URL: http://codereview.chromium.org/1622012
------------------------------------------------------------------------
r44704 | jabdelmalek@google.com | 2010-04-15 23:11:46 +0200 (Thu, 15 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_host.cc

Make handled set to true if ResourceDispatcherHost uses a message.

Review URL: http://codereview.chromium.org/1648013
------------------------------------------------------------------------
r44702 | erg@chromium.org | 2010-04-15 22:54:56 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc

GTK: Disable contradictory commands in the translate infobar.

This is kuan's r43097, ported to the linux version of translate_infobars.cc.

BUG=39821
TEST=see bug.

Review URL: http://codereview.chromium.org/1611031
------------------------------------------------------------------------
r44688 | jcivelli@google.com | 2010-04-15 22:00:00 +0200 (Thu, 15 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/dom_view.h

Making the app launcher use a DOMView.
This makes the contents now work properly.

BUG=41270
TEST=Start Chrome with --app-launcher-new-tab --enable-extension-apps and
     some apps installed. Open a new tab, the app launcher should show.
     Click on an app, it should be opened in a new tab.

Review URL: http://codereview.chromium.org/1619020
------------------------------------------------------------------------
r44686 | dantasse@chromium.org | 2010-04-15 21:54:08 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/SyncCustomize.xib
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller.h
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller.mm
   M /trunk/src/chrome/browser/cocoa/sync_customize_controller_unittest.mm

Mac: Added logic to prevent the user from clicking OK unless he has selected at least one datatype to sync.

xib changes: made the OK button get grayed out if you deselect all the checkboxes in the Customize Sync dialog box. (it re-enables if you select one of the checkboxes)

BUG=40880
TEST=sync_customize_unittest, included

Review URL: http://codereview.chromium.org/1578033
------------------------------------------------------------------------
r44684 | tim@chromium.org | 2010-04-15 21:33:49 +0200 (Thu, 15 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc

Only associate autofill entries in sync if the action is ADD and not update.

BUG=41412

Review URL: http://codereview.chromium.org/1627023
------------------------------------------------------------------------
r44681 | skerner@chromium.org | 2010-04-15 21:08:22 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/black.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/red.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/tabs_util.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/white.html

Fix chrome os flakyness for test ExtensionApiTest.CaptureVisibleTab. 

While in the code, add tests for PNG capture, and make code test that the resulting image is the right color. 

BUG=41380
TEST=ExtensionApiTest.CaptureVisibleTab 

Review URL: http://codereview.chromium.org/1631015
------------------------------------------------------------------------
r44680 | rafaelw@chromium.org | 2010-04-15 21:05:07 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h

Add ExtensionFunctionDispatcher::Delegate::GetAssociatedTabContents.

Following work from: http://codereview.chromium.org/1521032/show, based on comments from aa here: http://codereview.chromium.org/1521032/diff/4002/9004#newcode639

BUG=40428
TEST=All tests should pass

Review URL: http://codereview.chromium.org/1627024
------------------------------------------------------------------------
r44679 | albertb@chromium.org | 2010-04-15 21:02:58 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/password_manager/password_form_data.cc
   A /trunk/src/chrome/browser/password_manager/password_form_data.h
   A /trunk/src/chrome/browser/password_manager/password_store_change.h
   A /trunk/src/chrome/browser/password_manager/password_store_linux.cc
   A /trunk/src/chrome/browser/password_manager/password_store_linux.h
   A /trunk/src/chrome/browser/password_manager/password_store_linux_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Refactor PasswordStoreDefault on Linux to store the logins in a LoginDatabase
instead of using WebDataService. Once PasswordStoreWin is migrated as well,
PasswordStoreLinux will likely be folded back into PasswordStoreDefault.

BUG=35038
TEST=PasswordStoreLinuxTest.*

Review URL: http://codereview.chromium.org/1525026
------------------------------------------------------------------------
r44678 | wtc@chromium.org | 2010-04-15 21:02:07 +0200 (Thu, 15 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h

Display the SECURITY_WARNING status in the location bar for the
ERR_CERT_UNABLE_TO_CHECK_REVOCATION certificate error. Do not 
display an info bar.

Remove the unused ToolbarModel::GetIconHoverText function.

Note: chrome/app/generated_resources.grd was removed from the
changelist to avoid unit_tests failures on the Windows buildbots.

Originial review URL: http://codereview.chromium.org/1653003

R=pkasting,jcivelli
BUG=27125
TEST=Visit port 452 on the chrometws server.
Review URL: http://codereview.chromium.org/1594033
------------------------------------------------------------------------
r44675 | avayvod@google.com | 2010-04-15 20:31:22 +0200 (Thu, 15 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/common/utility_messages_internal.h
   M /trunk/src/chrome/utility/DEPS
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h

Added decoding of any supported image format into vector of chars.
This is used for decoding user's image downloaded from Google Profile
in sandboxed process upon user's login to Chromium OS.
This required adding dependency on webkit/glue/ in chrome/utility. Approved
by Brett.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1646004
------------------------------------------------------------------------
r44670 | mark@chromium.org | 2010-04-15 20:19:13 +0200 (Thu, 15 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.mm

10.6 SDK build fix.

A DCHECK_EQ comparing self (id) to -[NSWindow delegate] (id prior to the 10.6
SDK and id<NSWindowDelegate> after) introduced in r44383 fails with the 10.6
SDK because the types aren't compatible.  Add a "do what I mean" cast.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1653005
------------------------------------------------------------------------
r44668 | huanr@chromium.org | 2010-04-15 20:14:37 +0200 (Thu, 15 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Start up extension event routers later in BrowserMain, so
bookmarks is loaded after bookmark import in first run.

I am not familiar with the extension code. It seems currently
ExtensionHistoryEventRouter and ExtensionAccessibilityEventRouter
are always initialized while ExtensionBrowserEventRouter
and ExtensionBookmarkEventRouter are initialized on demand. Since
we have a build in bookmark manager extension, I start all event
routers by default in this change. Let me know if this is an
issue.

BUG=40144
TEST=chrome.exe --first-run

Review URL: http://codereview.chromium.org/1578032
------------------------------------------------------------------------
r44664 | nirnimesh@chromium.org | 2010-04-15 20:06:39 +0200 (Thu, 15 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/test/pyautolib/download_info.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py
   A /trunk/src/chrome/test/pyautolib/pyauto_errors.py

Add automation hooks to get info about downloads.

Makes info about downloads available to pyauto.
Also add JSONInterfaceError to represent an error in the json ipc interace.

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/1637008
------------------------------------------------------------------------
r44663 | willchan@chromium.org | 2010-04-15 20:06:06 +0200 (Thu, 15 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_alternate_protocols.cc
   M /trunk/src/net/http/http_alternate_protocols.h
   M /trunk/src/net/http/http_alternate_protocols_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc

SPDY: Alternate-Protocol changes.
Change chromium to expect npn-spdy/1 instead of npn-spdy to match server-side changes.
Move the use of Alternate-Protocol to be behind command line flag: "--use-alternate-protocols".

Review URL: http://codereview.chromium.org/1593029
------------------------------------------------------------------------
r44660 | skrul@chromium.org | 2010-04-15 18:21:05 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/change_processor_mock.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/chrome_tests.gypi

AutofillDataTypeController should invoke start callback on abort.  Also gracefully handle stopping the data type startup while waiting for the PDM, WDS, and association.

BUG=41361
TEST=unittest

Review URL: http://codereview.chromium.org/1513034
------------------------------------------------------------------------
r44655 | evan@chromium.org | 2010-04-15 17:18:15 +0200 (Thu, 15 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm
   M /trunk/src/chrome/browser/shell_integration_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   A /trunk/src/third_party/mozilla/NSPasteboard+Utils.h (from /trunk/src/third_party/mozilla/include/NSPasteboard+Utils.h:44648)
   A /trunk/src/third_party/mozilla/NSPasteboard+Utils.mm (from /trunk/src/third_party/mozilla/include/NSPasteboard+Utils.mm:44648)
   A /trunk/src/third_party/mozilla/NSScreen+Utils.h (from /trunk/src/third_party/mozilla/include/NSScreen+Utils.h:44648)
   A /trunk/src/third_party/mozilla/NSScreen+Utils.m (from /trunk/src/third_party/mozilla/include/NSScreen+Utils.m:44648)
   A /trunk/src/third_party/mozilla/NSString+Utils.h (from /trunk/src/third_party/mozilla/include/NSString+Utils.h:44648)
   A /trunk/src/third_party/mozilla/NSString+Utils.m (from /trunk/src/third_party/mozilla/include/NSString+Utils.m:44648)
   A /trunk/src/third_party/mozilla/NSURL+Utils.h (from /trunk/src/third_party/mozilla/include/NSURL+Utils.h:44648)
   A /trunk/src/third_party/mozilla/NSURL+Utils.m (from /trunk/src/third_party/mozilla/include/NSURL+Utils.m:44648)
   A /trunk/src/third_party/mozilla/NSWorkspace+Utils.h (from /trunk/src/third_party/mozilla/include/NSWorkspace+Utils.h:44648)
   A /trunk/src/third_party/mozilla/NSWorkspace+Utils.m (from /trunk/src/third_party/mozilla/include/NSWorkspace+Utils.m:44648)
   A /trunk/src/third_party/mozilla/README.chromium (from /trunk/src/third_party/mozilla/include/README.chromium:44648)
   D /trunk/src/third_party/mozilla/include/NSPasteboard+Utils.h
   D /trunk/src/third_party/mozilla/include/NSPasteboard+Utils.mm
   D /trunk/src/third_party/mozilla/include/NSScreen+Utils.h
   D /trunk/src/third_party/mozilla/include/NSScreen+Utils.m
   D /trunk/src/third_party/mozilla/include/NSString+Utils.h
   D /trunk/src/third_party/mozilla/include/NSString+Utils.m
   D /trunk/src/third_party/mozilla/include/NSURL+Utils.h
   D /trunk/src/third_party/mozilla/include/NSURL+Utils.m
   D /trunk/src/third_party/mozilla/include/NSWorkspace+Utils.h
   D /trunk/src/third_party/mozilla/include/NSWorkspace+Utils.m
   D /trunk/src/third_party/mozilla/include/README.chromium
   D /trunk/src/webkit/glue/plugins/DEPS

Move third_pary/mozilla/include up one directory.

This allows the license checker to find the README.

BUG=39240

Review URL: http://codereview.chromium.org/1596025
------------------------------------------------------------------------
r44650 | jeremy@chromium.org | 2010-04-15 16:49:21 +0200 (Thu, 15 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Mac: Improve behavior of "Add Folder" contextual menu item.

* "Add Folder" on a current folder now inserts the new folder as the last child of the parent folder rather than it's sibling.
* "Add Folder" on the "others" folder works as above.

This matches Windows behavior.
BUG=40722
TEST=See bug.

Review URL: http://codereview.chromium.org/1659003
------------------------------------------------------------------------
r44648 | rohitrao@chromium.org | 2010-04-15 16:16:12 +0200 (Thu, 15 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h

[Mac] Add an arrow cursor rect for the location image.

BUG=41229
TEST=Mouse over the location image.  Should show the arrow cursor, not an ibeam cursor.
Review URL: http://codereview.chromium.org/1574028
------------------------------------------------------------------------
r44643 | yusukes@google.com | 2010-04-15 12:58:46 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Don't show the "Configure IME..." menu item on the login screen.
Note that network and clock buttons don't show this kind of menu item as well.

BUG=crosbug.com/2268
BUG=crosbug.com/2619
TEST=manual

Review URL: http://codereview.chromium.org/1612021
------------------------------------------------------------------------
r44638 | phajdan.jr@chromium.org | 2010-04-15 10:31:58 +0200 (Thu, 15 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disable BrowserTest.PageLanguageDetection, it's crashy.

TBR=jcivelli
TEST=still crashy
BUG=40962

Review URL: http://codereview.chromium.org/1591033
------------------------------------------------------------------------
r44637 | yusukes@google.com | 2010-04-15 10:25:18 +0200 (Thu, 15 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc

Initialize |current_input_method_| in the constructor.
This patch is necessary for http://codereview.chromium.org/1568033 to work.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/1566045
------------------------------------------------------------------------
r44636 | mnaganov@chromium.org | 2010-04-15 10:11:50 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Remove stale comment line.

BUG=41291
TEST=none

TBR=pfeldman@chromium.org

Review URL: http://codereview.chromium.org/1660001
------------------------------------------------------------------------
r44635 | thestig@chromium.org | 2010-04-15 10:08:07 +0200 (Thu, 15 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/base/cancellation_flag_unittest.cc
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/file_reader.cc
   M /trunk/src/chrome/browser/important_file_writer.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h
   M /trunk/src/chrome/common/worker_thread_ticker.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/worker/nativewebworker_impl.cc
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.h
   M /trunk/src/net/proxy/single_threaded_proxy_resolver.cc
   M /trunk/src/net/tools/hresolv/hresolv.cc

Cleanup: Explicitly add a bunch of missing includes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1623014
------------------------------------------------------------------------
r44634 | mnaganov@chromium.org | 2010-04-15 10:04:51 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/test/data/devtools/js_page.html

Update and enable DevToolsSanityTest.TestProfilerTab.

BUG=41291
TEST=DevToolsSanityTest.TestProfilerTab

TBR=pfeldman@chromium.org

Review URL: http://codereview.chromium.org/1604037
------------------------------------------------------------------------
r44626 | satorux@chromium.org | 2010-04-15 07:24:16 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Fix a bug that caused the Dvorak layout to be broken.

TEST=unit_tests and manually confirmed dvorak worked.
BUG=crosbug.com/2449

Review URL: http://codereview.chromium.org/1523024
------------------------------------------------------------------------
r44622 | yusukes@google.com | 2010-04-15 07:03:18 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h

Remove an unused function, SetInputMethodActivated.

BUG=none
TEST=ran browser_tests

Review URL: http://codereview.chromium.org/1576039
------------------------------------------------------------------------
r44615 | wtc@chromium.org | 2010-04-15 05:16:13 +0200 (Thu, 15 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h

Revert r44611 because it may have broken "unit_tests" on "Vista Tests".

BUG=27125
TEST=none
Review URL: http://codereview.chromium.org/1655008
------------------------------------------------------------------------
r44611 | wtc@chromium.org | 2010-04-15 04:32:23 +0200 (Thu, 15 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h

Display the SECURITY_WARNING status in the location bar for the 
ERR_CERT_UNABLE_TO_CHECK_REVOCATION certificate error. Do not 
display an info bar.

Remove the unused ToolbarModel::GetIconHoverText function.

R=pkasting,jcivelli
BUG=27125
TEST=Visit port 452 on the chrometws server.
Review URL: http://codereview.chromium.org/1653003
------------------------------------------------------------------------
r44609 | akalin@chromium.org | 2010-04-15 04:19:43 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.h

Fixed potential crash on OnUnrecoverableError() in
theme_change_processor.cc.  Basically, it should do nothing else
(e.g., StartObserving()) after it calls OnUnrecoverableError().

BUG=41569,41575
TEST=manual

Review URL: http://codereview.chromium.org/1604036
------------------------------------------------------------------------
r44594 | kbr@google.com | 2010-04-15 02:58:03 +0200 (Thu, 15 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/webplugin.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Made Pepper 3D plugins' output opaque on Mac OS X by filling the
plugin region's alpha channel with 1.0 and then overwriting just the
color channels. Core Animation plugins, though they currently always
overlay HTML output, remain translucent.

BUG=41424
TEST=ran Pepper 3D sample and verified its background is opaque

Review URL: http://codereview.chromium.org/1547034
------------------------------------------------------------------------
r44593 | jhawkins@chromium.org | 2010-04-15 02:46:55 +0200 (Thu, 15 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

AutoFill: Handle non-unique profile labels by appending an increasing number to
the label in the PersonalDatabaseManager.

BUG=41002
TEST=PersonalDatabaseManager.SetUnique*

Review URL: http://codereview.chromium.org/1657003
------------------------------------------------------------------------
r44590 | arv@chromium.org | 2010-04-15 02:27:47 +0200 (Thu, 15 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Add work around for layout bug that some users are hitting.

In some rare cases the reported window.innerWidth and the media query reports different widths. This is most likely due to some timing issues. This work around keeps track of what layout mode we are using (wasSmallGrid) and when we get the data as well as on DOMContentLoaded we double check to ensure that the mode is correct and if not we do another layout. So in worst case we do one more layout in the case where the layout was wrong.


BUG=25329
TEST=I haven't been able to repro so when testing this I introduced the *wrong* case manually in code.

Review URL: http://codereview.chromium.org/1650008
------------------------------------------------------------------------
r44587 | nsylvain@chromium.org | 2010-04-15 02:21:33 +0200 (Thu, 15 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html:44569)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html:44569)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/black.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html:44569)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/red.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/tabs_util.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/white.html

Revert 44570 - Fix chrome os flakyness for test ExtensionApiTest.CaptureVisibleTab.

While in the code, add tests for PNG capture, and make code test that the resulting image is the right color.

BUG=41380
TEST=ExtensionApiTest.CaptureVisibleTab

Review URL: http://codereview.chromium.org/1631015

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1525035
------------------------------------------------------------------------
r44586 | eroman@chromium.org | 2010-04-15 02:15:39 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h

Don't delete the IOThread globals until all of the MessageLoop::DestructionObservers have run (in case they try to access one of these pointers)

BUG=39723


Review URL: http://codereview.chromium.org/1638011
------------------------------------------------------------------------
r44583 | mirandac@chromium.org | 2010-04-15 02:01:46 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Change prepopulated search engines to reflect new data.

BUG= 41532
TEST= Chrome install for countries in question should offer the new set of search engines.

Review URL: http://codereview.chromium.org/1530039
------------------------------------------------------------------------
r44581 | pkasting@chromium.org | 2010-04-15 01:51:45 +0200 (Thu, 15 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h

Fix memory smash, take 2.

Fix freed-memory accesses of members of a destroyed object while unwinding the callstack.  This avoids introducing a different memory corruption issue at shutdown by using WeakPtr to hold the object that the OS can delete out from under us.  It also clarifies and simplifies the shutdown sequence by moving the AutocompleteController::Stop() call into the controller's destructor, and avoiding notifying observers of changes; this actually altogether sidesteps the problematic codepath for which I needed the WeakPtr, but I'm not sure whether the OS still might be able to destroy the object at another time, so I'm leaving the WeakPtr in.

BUG=41274
TEST=Run Chrome with full page heap on.  Clicking an item in the omnibox dropdown should not crash.
Review URL: http://codereview.chromium.org/1657002
------------------------------------------------------------------------
r44580 | zelidrag@chromium.org | 2010-04-15 01:49:03 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc

Fix for LoginPromptTesti.CancelRedundantAuths and related tests on linux views.

BUG=27585
TEST=run ui_test for linux views build

Review URL: http://codereview.chromium.org/1599030
------------------------------------------------------------------------
r44577 | nsylvain@chromium.org | 2010-04-15 01:25:51 +0200 (Thu, 15 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Revert 44572 - [Mac] Update locationbar icon as user types.

Update in |OnChanged()|, just like Windows.

BUG=41362
TEST=Type "www.google.com".  You should have a globe icon.
TEST=Add a space after first 'w'.  Should get search icon.
TEST=Generally, icon will switch around as you type.

Review URL: http://codereview.chromium.org/1640012

TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/1600027
------------------------------------------------------------------------
r44572 | shess@chromium.org | 2010-04-15 00:55:48 +0200 (Thu, 15 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Update location-bar icon as user types.

Update in |OnChanged()|, just like Windows.

BUG=41362
TEST=Type "www.google.com".  You should have a globe icon.
TEST=Add a space after first 'w'.  Should get search icon.
TEST=Generally, icon will switch around as you type.

Review URL: http://codereview.chromium.org/1640012
------------------------------------------------------------------------
r44571 | dantasse@chromium.org | 2010-04-15 00:54:53 +0200 (Thu, 15 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h

Make it impossible to click OK if you've selected 0 datatypes.
BUG=40880
TEST=try to Customize Sync so you're syncing 0 datatypes.  You shouldn't be able to.

Review URL: http://codereview.chromium.org/1641001
------------------------------------------------------------------------
r44570 | skerner@chromium.org | 2010-04-15 00:49:18 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/black.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/red.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/tabs_util.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/white.html

Fix chrome os flakyness for test ExtensionApiTest.CaptureVisibleTab.

While in the code, add tests for PNG capture, and make code test that the resulting image is the right color.

BUG=41380
TEST=ExtensionApiTest.CaptureVisibleTab

Review URL: http://codereview.chromium.org/1631015
------------------------------------------------------------------------
r44560 | arv@chromium.org | 2010-04-15 00:32:23 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/linkcontroller.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/linkcontroller_test.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise_test.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/chrome_browser.gypi

Bookmark manager: Middle click, Ctrl click, Shift+Control click should open bookmark link in a background tab etc..

BUG=40359
TEST=Middle click on a bookmark link. It should open in a background tab

Review URL: http://codereview.chromium.org/1553026
------------------------------------------------------------------------
r44559 | joth@chromium.org | 2010-04-15 00:27:18 +0200 (Thu, 15 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm

Fix for OSX 10.6 wifi crash: can't call [CWInterface +interface] on a machine that has no wifi adapter.
Instead enumerate all adapters and open each one explicitly. Has the benefit that it will get more comprehensive results on a machine with multiple adapters


BUG=41337
TEST=opened maps.google.com/maps/m on 10.6 desktop & laptop machines

Review URL: http://codereview.chromium.org/1545035
------------------------------------------------------------------------
r44558 | tim@chromium.org | 2010-04-15 00:25:44 +0200 (Thu, 15 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/tools/valgrind/tsan/suppressions.txt

Land http://codereview.chromium.org/1621010

My first chrome patch :) -- 

Data race on boole in chrome/browser/sync/engine/syncer.cc 

Fix uses Lock class to avoid any compiler/hardware optimizations. 

BUG=37408
TEST=Ran Valgrind/ThreadSanitizer 

Original Patch by raz@chromium.org
http://codereview.chromium.org/1621010


Review URL: http://codereview.chromium.org/1518023
------------------------------------------------------------------------
r44555 | erg@chromium.org | 2010-04-15 00:13:56 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK: Use correct button mask on reload button.

BUG=41530
TEST=Install GoodSmile theme. The right corners of the reload button shouldn't be rounded.

Review URL: http://codereview.chromium.org/1625014
------------------------------------------------------------------------
r44551 | aa@chromium.org | 2010-04-15 00:06:50 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc

Fix bug that caused us to have many duplicate registrations
recorded in extension prefs for override pages.

BUG=41442

Review URL: http://codereview.chromium.org/1518028
------------------------------------------------------------------------
r44548 | jhawkins@chromium.org | 2010-04-15 00:03:22 +0200 (Thu, 15 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

AutoFill: Don't send suggestions or fill forms that are not auto-fillable.

BUG=41506
TEST=none

Review URL: http://codereview.chromium.org/1607019
------------------------------------------------------------------------
r44545 | shess@chromium.org | 2010-04-14 23:46:48 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Omnibox text drag drag URL when select-all.

If the entire field is selected, make the drag contents match those
which would be dragged from the location icon.

BUG=41218
TEST=Browser to www.google.com.  Select-all, drag&drop to bookmarks.

Review URL: http://codereview.chromium.org/1622024
------------------------------------------------------------------------
r44542 | rafaelw@chromium.org | 2010-04-14 23:30:41 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/history.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/infobars/infobarA.html
   M /trunk/src/chrome/test/data/extensions/api_test/infobars/infobarB.html
   M /trunk/src/chrome/test/data/extensions/api_test/infobars/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics2/test.js

Add chrome.tabs.getCurrent() api call to extensions.

This is primarily so that code running in an infobar can discover what tab the info is inserted in. It also works for code running directly in a TabContents. The call will return undefined if called from a background page or popup view.

BUG=40428
TEST=All tests should pass (additional tests included)

Review URL: http://codereview.chromium.org/1521032
------------------------------------------------------------------------
r44541 | avi@chromium.org | 2010-04-14 23:28:25 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/disclosure_view_controller.mm

Add an accessor for KVO.

BUG=http://crbug.com/41366
TEST=no visible change, disclosure views in AutoFill prefs still work

Review URL: http://codereview.chromium.org/1530033
------------------------------------------------------------------------
r44530 | estade@chromium.org | 2010-04-14 22:32:40 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc

Fix linux views build

BUG=none
TEST=buildbot
TBR=cbentzel

Review URL: http://codereview.chromium.org/1566043
------------------------------------------------------------------------
r44527 | zelidrag@chromium.org | 2010-04-14 22:15:29 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h

Fixed ESC handling on constrained dialogs on GTK. We used to stop the entire page navigation previously instead of continuing with other page elements if some can't be loaded. This change makes GTK implementation consistent with other platforms.

BUG=27585
TEST=go to http://www/~thakis/cgi-bin/test.html, press ESC when login dialog appears, observe broken image #1, press ESC on the next dialog, observe broken image #2.

Review URL: http://codereview.chromium.org/1627022
------------------------------------------------------------------------
r44526 | cbentzel@chromium.org | 2010-04-14 22:12:45 +0200 (Wed, 14 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/http/http_auth_handler.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/http/http_auth_handler_factory.h
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   M /trunk/src/net/http/http_auth_handler_negotiate_posix.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_win.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.h
   M /trunk/src/net/http/http_auth_handler_ntlm_win.cc
   M /trunk/src/net/http/http_auth_sspi_win.cc
   M /trunk/src/net/http/http_auth_sspi_win.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc

Kerberos uses an SPN (Service Principal Name) to identify a server. This is typically in the form "HTTP/host:port", with the ":port" suffix being optional, and the "HTTP/" prefix is fixed regardless of whether the service is accessed over HTTP or HTTPS.

The issue this is fixing is that the URL host may be an incomplete domain name, a numerical address, or an alias for a canonical DNS name.

By default, Chrome will skip adding the optional port to the SPN, and will use the canonical DNS name for the server (which may be the original server name if it is an A or AAAA record). This matches IE and Firefox's default behavior.

Some intranets are set up so the original host name should be used rather than the canonical name. The canonical name resolution can be disabled with the --disable-spnego-cname-lookup command line flag.

Some intranets are also set up so the optional port should be specified when it is non-standard (non 80 or 443). Use the --enable-spnego-port command line flag.

BUG=29862
TEST=net_unittests.exe --gtest_filter="*CanonicalName*"

Review URL: http://codereview.chromium.org/1535019
------------------------------------------------------------------------
r44524 | estade@chromium.org | 2010-04-14 22:08:20 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h

Add download item tooltips on linux/win.

BUG=41195
TEST=manual

Review URL: http://codereview.chromium.org/1528032
------------------------------------------------------------------------
r44523 | estade@chromium.org | 2010-04-14 22:05:35 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: Prevent inappropriate drag of location bar location icon.

BUG=40840
TEST=manual

Review URL: http://codereview.chromium.org/1607018
------------------------------------------------------------------------
r44519 | estade@chromium.org | 2010-04-14 21:53:13 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

GTK: make the primary selection include the url's scheme when an entire URL is selected.

sometimes the scheme will be hidden, which is the reason we need this workaround.

BUG=41173
TEST=manual

Review URL: http://codereview.chromium.org/1638007
------------------------------------------------------------------------
r44517 | nsylvain@chromium.org | 2010-04-14 21:35:57 +0200 (Wed, 14 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Remove the second part of SetPageTitle since it's used only for debugging, if at all, 
and it causes some crashes on the reliability bots.

Review URL: http://codereview.chromium.org/1611028
------------------------------------------------------------------------
r44516 | thomasvl@chromium.org | 2010-04-14 21:35:37 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

[Mac] Fix MouseDown/MouseUp error for Steve animation effects
- Pull in new GTM with Animation fixes
- Switch masks to be mouse up, not down.
- Remove the steve effect from places where users don't really trigger the animation, so the effect doesn't seem "random"
- Move the animation duration set to be per click in the prefs window instead of binding the time at window open.

BUG=41393
TEST=Steve animation effects are back.
Review URL: http://codereview.chromium.org/1618021
------------------------------------------------------------------------
r44508 | akalin@chromium.org | 2010-04-14 20:46:11 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc

Fixed possible crash in {Bookmark,Preference}DataTypeController
when OnUnrecoverableError() is called after Start().

BUG=41438
TEST=unittests

Review URL: http://codereview.chromium.org/1630021
------------------------------------------------------------------------
r44506 | skrul@chromium.org | 2010-04-14 20:37:31 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   D /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/chrome_tests.gypi

Revert 44504 - AutofillDataTypeController should invoke start callback on abort.
BUG=41361

Review URL: http://codereview.chromium.org/1513034

TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/1564032
------------------------------------------------------------------------
r44505 | mrossetti@chromium.org | 2010-04-14 20:32:57 +0200 (Wed, 14 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/app/nibs/BookmarkBarFolderWindow.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h

Implement cut and paste and rework copy and delete bookmark actions from context menus. Eliminate bifurcated 'parentController_' data member (leaving this common behavior to the BookmarkFolderTarget class). Provide context menus (one for button and another for folder) for the folder controller thus allowing far easier identification of the target of the action.

BookmarkBar.xib changes: Added Cut and Paste menu items to the button and folder contextual menus. Reconfigured the menus with separators and some rearranging to match Windows.

BookmarkBarFolderWindow.xib changes: Copied the button and folder contextual menus from the BookmarkBar.xib and wired them up to the folder controller instead.

BUG=23541
TEST=Present context menu for bookmark bar and verify the presence of Cut/Copy/Paste/Delete. Verify proper enabling (i.e. Paste should not be enabled until a bookmark or folder has been Cut or Copied). Perform each action Cut, Copy, Delete and Paste. Perform these tests for the contents of a folder coming off of the bookmark bar and for subfolders, too. Insure that pasting can be performed from the bar to a folder, a folder to the bar, bar to bar, folder to folder, at the beginning and at the end of each.

Review URL: http://codereview.chromium.org/1611027
------------------------------------------------------------------------
r44504 | skrul@chromium.org | 2010-04-14 20:32:06 +0200 (Wed, 14 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/chrome_tests.gypi

AutofillDataTypeController should invoke start callback on abort.
BUG=41361

Review URL: http://codereview.chromium.org/1513034
------------------------------------------------------------------------
r44502 | hclam@chromium.org | 2010-04-14 20:27:16 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/media/audio/mac/audio_output_mac.cc

Looping for audio / video

Fixed the looping problem with audio / video.
BUG=39478
TEST=audio plays with looping

Review URL: http://codereview.chromium.org/1620010
------------------------------------------------------------------------
r44501 | jcivelli@google.com | 2010-04-14 20:13:40 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Show an error infobar when we fail to retrieve the translate script.

BUG=41349
TEST=Visit a page in a language different than the Chrome UI language.
     Disconnect the network cable. Click Translate in the infobar.
     After some time an error infobar should be shown.

Review URL: http://codereview.chromium.org/1602024
------------------------------------------------------------------------
r44499 | atwilson@chromium.org | 2010-04-14 20:06:20 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/status_icons/status_icon.cc
   M /trunk/src/chrome/browser/status_icons/status_icon.h
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.h
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win.h

status_icons: Fix include issues.

BUG=None
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1547020
------------------------------------------------------------------------
r44497 | rohitrao@chromium.org | 2010-04-14 19:55:19 +0200 (Wed, 14 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm

[Mac] Adds a BookmarkButtonDelegate method to retrieve the top-level browser window.  Used to lock bar visibility when dragging.

BUG=40740
TEST=Go Fullscreen.  Drag a bookmark button that is inside a folder.  When the folder disappears, the overlay bar should stay visible.
Review URL: http://codereview.chromium.org/1610023
------------------------------------------------------------------------
r44496 | joth@chromium.org | 2010-04-14 19:46:12 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc

Fix IDN urls in geolocation infobars and bubbles (but not exceptions dialog)

BUG=40278
TEST=As per adhoc method in the bug. Open infobar & bubble, check they show URL in arabic

Review URL: http://codereview.chromium.org/1612017
------------------------------------------------------------------------
r44493 | tim@chromium.org | 2010-04-14 19:36:20 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Acquire registrar_lock_ before [de]activating data types in the sync backend host.

BUG=37153


Review URL: http://codereview.chromium.org/1286004
------------------------------------------------------------------------
r44492 | shess@chromium.org | 2010-04-14 19:34:58 +0200 (Wed, 14 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

[Mac] Fix search icon in keyword search to be right-side-up.

The search icon (magnifying glass) in the keyword-search bubble was
inverted.  The icon was shared with other code which called
|-setFlipped:| incompatibly.

Also line up the icon above the popup icons, and match the text baseline with the field's baseline.

BUG=41012
TEST=Type "google.com" then TAB.  Mag glass is upright (like in popup).

Review URL: http://codereview.chromium.org/1574026
------------------------------------------------------------------------
r44489 | oshima@chromium.org | 2010-04-14 19:08:05 +0200 (Wed, 14 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc

Revert "r44062 Fix issue where the size of notification on
        linux/views gets created bigger than max size."

This is not right fix.

This reverts commit ef67a340932fffa116b72413c7e5e425019f32a1.

BUG=none
TEST=none
TBR=johnnyg@chromium.org

Review URL: http://codereview.chromium.org/1618016
------------------------------------------------------------------------
r44488 | oshima@chromium.org | 2010-04-14 19:07:03 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/notification_1line.html
   M /trunk/src/chrome/browser/resources/notification_2line.html
   M /trunk/src/chrome/browser/resources/notification_icon.html

Revert "r43732 Use CSS word-wrap property to prevent long
        single words from causing ugly notifications."

This reverts commit 0f42cfcc13c6d060fe8e43f6d8b5f069849f08f0.

This change makes the balloon's intial size bigger.

Review URL: http://codereview.chromium.org/1629015
------------------------------------------------------------------------
r44486 | dhg@chromium.org | 2010-04-14 19:01:43 +0200 (Wed, 14 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/theme/mediaplayer_full_screen.png
   M /trunk/src/chrome/app/theme/mediaplayer_menu.png
   M /trunk/src/chrome/app/theme/mediaplayer_next.png
   M /trunk/src/chrome/app/theme/mediaplayer_pause.png
   M /trunk/src/chrome/app/theme/mediaplayer_play.png
   A /trunk/src/chrome/app/theme/mediaplayer_playlist.png
   M /trunk/src/chrome/app/theme/mediaplayer_prev.png
   M /trunk/src/chrome/app/theme/mediaplayer_vol_high.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/resources/mediaplayer.html

Resource changes to the mediaplayer

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1627017
------------------------------------------------------------------------
r44482 | erg@chromium.org | 2010-04-14 18:20:49 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

GTK: Set the selection colors on the omnibox.

This prevents GTK theme colors from bleeding into the omnibox.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1605026
------------------------------------------------------------------------
r44481 | bauerb@chromium.org | 2010-04-14 18:19:40 +0200 (Wed, 14 Apr 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.h
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.mm
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/repost_form_warning_controller.cc
   M /trunk/src/chrome/browser/repost_form_warning_controller.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h

Ensure proper teardown of repost form warning objects.

Make sure a repost form warning is closed properly even when the constrained window is closed from underneath us.
To do this, its controller now calls |Cancel| in its destructor.

We now have a potential cycle of methods calling each other:
* |RepostFormWarningController::CloseDialog| closes the |ConstrainedWindow|.
* This eventually calls |RepostFormWarningWin::DeleteDelegate|, which destroys |RepostFormWarningWin| and |RepostFormWarningController|.
* In its destructor, |RepostFormWarningController| calls |Cancel|, which calls |CloseDialog|.

Therefore, there are some checks in place to make sure we do everything during the teardown exactly once:
* After calling |NavigationController::CancelPendingReload|, we set |tab_contents| to null to make sure we don't call it again.
* During destruction, we set |window_| to null to make sure we don't call |CloseConstrainedWindow| again.

BUG=41367
TEST=RepostFormWarningTest.*

Review URL: http://codereview.chromium.org/1530032
------------------------------------------------------------------------
r44477 | brettw@chromium.org | 2010-04-14 17:47:00 +0200 (Wed, 14 Apr 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/net/metadata_url_request.cc

Try to fix CrOS build.
------------------------------------------------------------------------
r44476 | brettw@chromium.org | 2010-04-14 17:34:54 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/net/metadata_url_request.cc
   M /trunk/src/chrome/common/googleurl_dummy.cc
   M /trunk/src/chrome/common/url_constants.cc

Remove registration of the extension protocol late in the init process. This
protocol is already getting registered by url_util.cc super early in the
process, so this extra registration is redundant. Re-adding the protocol later
apparently modifies the set that url_util uses, and when this happens there
could be other threads reading it.

BUG=41150
TEST=none
Review URL: http://codereview.chromium.org/1545029
------------------------------------------------------------------------
r44475 | albertb@chromium.org | 2010-04-14 17:14:24 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/profile.cc

Schedule PasswordStore tasks on the DB thread on Windows and Linux; add a
NOTREACHED in the profile initialization when the password store fails to
initialize correctly.

BUG=35038
TEST=PasswordStoreMacTest.*

Review URL: http://codereview.chromium.org/1528036
------------------------------------------------------------------------
r44471 | satorux@chromium.org | 2010-04-14 13:28:08 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc

Open the languages dialog, rather than the system option.

TEST=manually
BUG=crosbug.com/2137

Review URL: http://codereview.chromium.org/1640010
------------------------------------------------------------------------
r44470 | jochen@chromium.org | 2010-04-14 12:51:19 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url/test.html

Reland 44348 Add support for restricting broadcasting events to extensions based on host permissions

BUG=38398
TEST=none
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/1528038
------------------------------------------------------------------------
r44469 | satorux@chromium.org | 2010-04-14 12:46:16 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc

Add LanguageConfigView::Show()

Along the way, refactor some related code.

BUG=now
TEST=manually

Review URL: http://codereview.chromium.org/1605029
------------------------------------------------------------------------
r44467 | yusukes@google.com | 2010-04-14 12:01:42 +0200 (Wed, 14 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Language menu improvements.

- Use ISO 639-1 language code for input method indicator.
- Do not use raw language codes in the drop-down menu.

BUG=crosbug.com/2428
BUG=crosbug.com/2564
TEST=manual

Review URL: http://codereview.chromium.org/1622025
------------------------------------------------------------------------
r44463 | bulach@chromium.org | 2010-04-14 11:36:55 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

The geolocation icon must be displayed even if the current origin change its document or query params.
We should only remove the icon when visiting a new origin or the underlying setting has changed.

BUG=40742

Review URL: http://codereview.chromium.org/1640004
------------------------------------------------------------------------
r44462 | satorux@chromium.org | 2010-04-14 11:31:40 +0200 (Wed, 14 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Add logic to change UI language.

At this moment, this requires a browser restart, thus shows
a dialog about it.

DPENDS_ON http://codereview.chromium.org/1595026/show

BUG=crosbug.com/2336
TEST=manually

Review URL: http://codereview.chromium.org/1645007
------------------------------------------------------------------------
r44461 | akalin@chromium.org | 2010-04-14 11:20:14 +0200 (Wed, 14 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

This change adds a single pref to sync: you can find it in
the UI by Options->Change AutoFill settings->click on an
address->click on "Make this my default profile" flag.

( Original patch by raz@chromium.org )

BUG=41247
TEST=Set this pref in one browser, sync it in the other

Review URL: http://codereview.chromium.org/1612019
------------------------------------------------------------------------
r44460 | satorux@chromium.org | 2010-04-14 11:19:10 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/chrome_browser.gypi

Replace HWND with gfx::NativeWindow in RestartMessageBox so it works on Linux.

TEST=confirmed it worked on linux and didn't break the windows build by trybots
BUG=none

Review URL: http://codereview.chromium.org/1595026
------------------------------------------------------------------------
r44457 | tony@chromium.org | 2010-04-14 09:45:48 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove the --enable-user-stylesheet flag.

Startup perf was not impacted in an earlier test run, so this should be safe.

BUG=38182

Review URL: http://codereview.chromium.org/1530031
------------------------------------------------------------------------
r44454 | yusukes@google.com | 2010-04-14 09:35:00 +0200 (Wed, 14 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h

Change IME hot-key.

Removed Control+space since it's just for testing. Added Alt+~ which is popular for Japanese IME users on Windows.

We will add more hot-keys like 'Right-Alt+Right-Shift' and 'Zenkaku_Hankaku' later (in a separate CL).

BUG=crosbug/492
TEST=manual

Review URL: http://codereview.chromium.org/1593026
------------------------------------------------------------------------
r44452 | satorux@chromium.org | 2010-04-14 07:43:00 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Change "OK" button to "Done" button, to follow the mock from UX.

Along the way, remove "Cance" button.  If really needed,
we could adding support for canceling in the future.

BUG=crosbug.com/2074
TEST=manually

Review URL: http://codereview.chromium.org/1612018
------------------------------------------------------------------------
r44451 | akalin@chromium.org | 2010-04-14 07:20:36 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc

Fixed crash in ThemeDataTypeController when OnUnrecoverableError()
is called after Start().

BUG=41359
TEST=unittests

Review URL: http://codereview.chromium.org/1547033
------------------------------------------------------------------------
r44450 | satorux@chromium.org | 2010-04-14 06:37:55 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

First cut at adding UI for changing the UI language.

For now, the logic for UI language switching is not yet implemented.
Will add the logic in a separate patch.

TEST=manually
BUG=crosbug.com/2336

Review URL: http://codereview.chromium.org/1652002
------------------------------------------------------------------------
r44445 | sky@chromium.org | 2010-04-14 05:37:15 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Removes assert in autocomplete test that is no longer valid. The
reason the assert is no longer valid is that browser tests no longer
run a nested message loop.

BUG=none
TEST=none
TBR=suzhe@chromium.org

Review URL: http://codereview.chromium.org/1645006
------------------------------------------------------------------------
r44444 | tony@chromium.org | 2010-04-14 05:10:15 +0200 (Wed, 14 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 44443 - Try removing the enableuserstylesheet flag.

This is a test run to see how it impacts startup perf (if any).

BUG=38182
TBR=chase

Review URL: http://codereview.chromium.org/1595027

TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/1560034
------------------------------------------------------------------------
r44443 | tony@chromium.org | 2010-04-14 05:00:31 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Try removing the --enable-user-stylesheet flag.

This is a test run to see how it impacts startup perf (if any).

BUG=38182
TBR=chase

Review URL: http://codereview.chromium.org/1595027
------------------------------------------------------------------------
r44436 | satorux@chromium.org | 2010-04-14 03:50:22 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Add LanguageLibrary::GetLanguageCodeFromDescriptor().

This encapsulates differences between the language codes used in
InputMethodDescriptor and Chrome's application locale codes.

TEST=unit_tests
BUG=crosbug.com/2336

Review URL: http://codereview.chromium.org/1611026
------------------------------------------------------------------------
r44435 | tony@chromium.org | 2010-04-14 03:46:43 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   D /trunk/src/base/file_version_info.cc
   M /trunk/src/base/file_version_info.h
   D /trunk/src/base/file_version_info_linux.cc
   D /trunk/src/base/file_version_info_linux.h.version
   A /trunk/src/base/file_version_info_mac.h
   M /trunk/src/base/file_version_info_mac.mm
   M /trunk/src/base/file_version_info_unittest.cc
   A /trunk/src/base/file_version_info_win.cc (from /trunk/src/base/file_version_info.cc:44432)
   A /trunk/src/base/file_version_info_win.h
   A /trunk/src/chrome/app/chrome_version_info.cc
   A /trunk/src/chrome/app/chrome_version_info.h
   A /trunk/src/chrome/app/chrome_version_info_posix.h.version (from /trunk/src/base/file_version_info_linux.h.version:44432)
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/memory_details_mac.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_exe.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/chrome_frame/test/util_unittests.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_win.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Refactor FileVersionInfo into an interface with platform implementations.
This allows us to move the chrome specific version informaton used by
Linux into src/chrome.

Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome.

In src/webkit/glue, add a new glue method for getting the product version.  When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell.

Review URL: http://codereview.chromium.org/1560027
------------------------------------------------------------------------
r44430 | ukai@chromium.org | 2010-04-14 03:11:38 +0200 (Wed, 14 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Disabled WebSocket tests on Windows,
but enabled on other platform.

new-run-webkit-websocketserver won't run on Windows
because of https://bugs.webkit.org/show_bug.cgi?id=37518

BUG=40976,40995,41319
TEST=trybots pass

Review URL: http://codereview.chromium.org/1630019
------------------------------------------------------------------------
r44429 | cpu@chromium.org | 2010-04-14 02:59:17 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_test.h
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.h

Add diagnostic check for the Preferences file
- Parses the json file

BUG=27885
TEST=test modified

Review URL: http://codereview.chromium.org/1609022
------------------------------------------------------------------------
r44421 | nsylvain@chromium.org | 2010-04-14 02:15:48 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc

Revert 44407 - Fix freedmemoryread (and maybe writes later?) due to accessing members of a destroyed object while unwinding the callstack.

BUG=41274
TEST=Run Chrome with full page heap on.  Clicking an item in the omnibox dropdown should not crash.
Review URL: http://codereview.chromium.org/1566040

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/1589033
------------------------------------------------------------------------
r44419 | hclam@chromium.org | 2010-04-14 01:20:40 +0200 (Wed, 14 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/media/audio/mac/audio_output_mac.cc

Too many audio hangs Leopard

BUG=30242
TEST=Go to this page:
http://weston.ruter.net/projects/test-cases/chrome-mp3-audio-crash/
Click play and it won't hang.

Opening (not) too many audio streams in Leopard will cause a
deadlock in AudioQueue, freezing the browser process. Unfortunately
there isn't a way to detect that in the AudioQueue API. So this
change limits the number of streams allowed.

The limit for Leopard is set to 15 and other OSes are 50.

Review URL: http://codereview.chromium.org/1559024
------------------------------------------------------------------------
r44418 | arv@chromium.org | 2010-04-14 01:09:18 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js

Bookmark manager: More workarounds for buggy flex box layout code.

BUG=40902
TEST=Go to a folder with not enough items to show a vertical scrollbars. Copy and paste items so that the scrollbar is shown. The scrollbar should be next to the window edge. Also try resizing the window.

Review URL: http://codereview.chromium.org/1625013
------------------------------------------------------------------------
r44417 | aa@chromium.org | 2010-04-14 01:08:46 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Shorten text next to checkmark. Use yellow text instead of an alert dialog.

See screen cap in bug.

BUG=41356

Review URL: http://codereview.chromium.org/1642006
------------------------------------------------------------------------
r44416 | mirandac@chromium.org | 2010-04-14 01:01:07 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   A /trunk/src/chrome/browser/views/first_run_search_engine_view.cc
   A /trunk/src/chrome/browser/views/first_run_search_engine_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/installer/util/master_preferences_constants.cc
   M /trunk/src/chrome/installer/util/master_preferences_constants.h
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc
   M /trunk/src/chrome/test/test_location_bar.h

Add new search engine dialog for first run process.

BUG= 37564
TEST= start Chrome with --first-run enabled -- you should see a new search engine selection dialog.


Review URL: http://codereview.chromium.org/1586005
------------------------------------------------------------------------
r44415 | erg@chromium.org | 2010-04-14 00:54:44 +0200 (Wed, 14 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

GTK: Update top padding on icons in the autocomplete popup.

Technically, this still isn't centered (there's one more pixel below the
icon then there is over it). But being off-center one pixel up looks better
than being off-centere one pixel down. (And both look better than the
current trunk.)

BUG=41189
TEST=none

Review URL: http://codereview.chromium.org/1568031
------------------------------------------------------------------------
r44414 | albertb@chromium.org | 2010-04-14 00:38:12 +0200 (Wed, 14 Apr 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/password_manager/password_form_data.cc
   D /trunk/src/chrome/browser/password_manager/password_form_data.h
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   D /trunk/src/chrome/browser/password_manager/password_store_change.h
   D /trunk/src/chrome/browser/password_manager/password_store_linux.cc
   D /trunk/src/chrome/browser/password_manager/password_store_linux.h
   D /trunk/src/chrome/browser/password_manager/password_store_linux_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert "Refactor PasswordStoreDefault on Linux to store the logins in a LoginDatabase"

This reverts commit 2fa9a35a2e607688e7c2f8908c0d1e4c31ff5c96.

TBR=stuartmorgan
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1545033
------------------------------------------------------------------------
r44413 | feldstein@chromium.org | 2010-04-14 00:32:26 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix flickering mac extension bubbles

The extension bubble animation would trigger an infinite loop of resizing of the web content between two heights.  By deferring the call to render_widget_host->WasResized() it seems to allow the height to settle and gets rid of the flickering.  This was mostly prevalent on 10.5, but occasionally showed up on 10.6 when using devtools to inspect the popup.

BUG=31970
TEST=Using RSS extension, open the rss popup at www.aaronboodman.com

Review URL: http://codereview.chromium.org/1596013
------------------------------------------------------------------------
r44412 | sky@chromium.org | 2010-04-14 00:30:01 +0200 (Wed, 14 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Changes browser_tests to not run a nested message loop.

BUG=none
TEST=none
TBR=jcivelli
Review URL: http://codereview.chromium.org/1606018
------------------------------------------------------------------------
r44410 | skerner@chromium.org | 2010-04-14 00:23:11 +0200 (Wed, 14 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js

Mark ExtensionApiTest.CaptureVisibleTab as flaky in Chrome OS.  Make the error check clearer.

BUG=41380
TEST=ExtensionApiTest.CaptureVisibleTab


Review URL: http://codereview.chromium.org/1545031
------------------------------------------------------------------------
r44409 | albertb@chromium.org | 2010-04-14 00:23:10 +0200 (Wed, 14 Apr 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/password_manager/password_form_data.cc
   A /trunk/src/chrome/browser/password_manager/password_form_data.h
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   A /trunk/src/chrome/browser/password_manager/password_store_change.h
   A /trunk/src/chrome/browser/password_manager/password_store_linux.cc
   A /trunk/src/chrome/browser/password_manager/password_store_linux.h
   A /trunk/src/chrome/browser/password_manager/password_store_linux_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Refactor PasswordStoreDefault on Linux to store the logins in a LoginDatabase
instead of using WebDataService. Once PasswordStoreWin is migrated as well,
PasswordStoreLinux will likely be folded back into PasswordStoreDefault.

BUG=35038
TEST=PasswordStoreLinuxTest.*

Review URL: http://codereview.chromium.org/1525026
------------------------------------------------------------------------
r44407 | pkasting@chromium.org | 2010-04-14 00:20:11 +0200 (Wed, 14 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc

Fix freed-memory-read (and maybe writes later?) due to accessing members of a destroyed object while unwinding the callstack.

BUG=41274
TEST=Run Chrome with full page heap on.  Clicking an item in the omnibox dropdown should not crash.
Review URL: http://codereview.chromium.org/1566040
------------------------------------------------------------------------
r44401 | erg@chromium.org | 2010-04-13 23:49:43 +0200 (Tue, 13 Apr 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/app/theme/omnibox_history_dark_transparent.png
   A /trunk/src/chrome/app/theme/omnibox_history_transparent.png
   A /trunk/src/chrome/app/theme/omnibox_http_dark_transparent.png
   A /trunk/src/chrome/app/theme/omnibox_http_transparent.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK: Tint omnibox icons in GTK mode differently.

- Tint highlighted icons (the *_DARK variety) the color of highlighted text.
- Use new variants of the IDR_OMNIBOX_HTTP* and IDR_OMNIBOX_HISTORY* icons in
  GTK mode where there isn't a white background.

BUG=41189
TEST=none

Review URL: http://codereview.chromium.org/1559029
------------------------------------------------------------------------
r44400 | thakis@chromium.org | 2010-04-13 23:37:57 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm

Mac: Let infobar text survive window resizes and fullscreen toggles.

BUG=40604
TEST=Do something that shows an infobar (e.g. go to youtube and kill flash). Switch to and from fullscreen, resize window. Infobar text should stay visible. For infobars with links (e.g. geolocation infobar), the link should still show a hand cursor.

Review URL: http://codereview.chromium.org/1654004
------------------------------------------------------------------------
r44395 | arv@chromium.org | 2010-04-13 23:10:22 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js

Bookmark manager: Workaround for invalid flex box layout which caused the width to be incorrect.

BUG=40902
TEST=Switch between two folders. One that has enough items to show a scrollbar and one that does not show

Review URL: http://codereview.chromium.org/1549040
------------------------------------------------------------------------
r44392 | rafaelw@chromium.org | 2010-04-13 22:56:48 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.html

The code was assuming that the BalloonViewHost's lifetime would be managed by the views hierarchy, but it was only taking ownership of the BalloonViewHost's native_view.

This was manifesting as a crasher when the chrome://extensions page attempted to access an EFD whose RVH was dead.

BUG=40967

Review URL: http://codereview.chromium.org/1619012
------------------------------------------------------------------------
r44390 | avi@chromium.org | 2010-04-13 22:33:35 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Cancel any mouse events pending when tabs are switched.

BUG=http://crbug.com/39105
TEST=as in bug


Review URL: http://codereview.chromium.org/1513022
------------------------------------------------------------------------
r44389 | gwilson@google.com | 2010-04-13 22:32:25 +0200 (Tue, 13 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Adds brand codes CHHS and CHHM to "organic" list.

R=cpu
BUG=none
TEST=Install with brand code CHHS or CHHM --> no RLZ.


Review URL: http://codereview.chromium.org/1613013
------------------------------------------------------------------------
r44388 | rafaelw@chromium.org | 2010-04-13 22:31:22 +0200 (Tue, 13 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/notifications_apitest.cc
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/notification.html
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_manifest
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.html (from /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/background.html:44386)
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/manifest.json:44386)
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/notification.html (from /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/notification.html:44386)
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_prefs
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.html (from /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/background.html:44386)
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_prefs/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission_prefs/notification.html (from /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/notification.html:44386)

Add a browser test to ensure that notifications that are requested via requestPermission work in extensions.

BUG=40495

Review URL: http://codereview.chromium.org/1568028
------------------------------------------------------------------------
r44387 | albertb@chromium.org | 2010-04-13 22:21:22 +0200 (Tue, 13 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h

Revert "Schedule PasswordStore tasks on the DB thread on Windows and Linux."

This reverts commit 20226b236864eebd7af84703cc5a70056babd34a.

Revert "Fix conditional in PasswordStoreMac initialization"

This reverts commit 0d07a3783fc100c2cfe2a4d2f1c8f52ee94e3da7.

TBR=stuartmorgan
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1604033
------------------------------------------------------------------------
r44386 | rohitrao@chromium.org | 2010-04-13 22:00:19 +0200 (Tue, 13 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

[Mac] Remove all pending timers and callbacks before destroying the fullscreen controller.

BUG=41263
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/1654002
------------------------------------------------------------------------
r44383 | jrg@chromium.org | 2010-04-13 21:46:14 +0200 (Tue, 13 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ExtensionInstallPrompt.xib
   M /trunk/src/chrome/app/nibs/ExtensionInstallPromptNoWarnings.xib
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

A common pattern for Chrome is for dialogs to "own themselves"
(e.g. fire and forget).  As implemented on the Mac, the termination
chain (e.g. when OK is pressed) is to call [NSApp endSheet:].
didEndSheet then closes the window, and the controller (set as the
delegate of the window) gets a windowWillClose: callback (so the
controller knows to delete itself).

The problem here was that the window was ordered out (offscreen) but
not actually closed, so we didn't clean up properly.

BUG=40429
TEST=no valgrind suppression needed and unit_tests stay happy.

nib change: window controller (file's owner) is the delegate of the window
(for both nibs)

Review URL: http://codereview.chromium.org/1654003
------------------------------------------------------------------------
r44380 | erg@chromium.org | 2010-04-13 21:36:20 +0200 (Tue, 13 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

GTK: Move reload in gtk mode and fix omnibox popup location.

- The reload button in GTK mode now is the normal stock gtk icon again.
- The horizontal bounds of the omnibox popup are now the equal to the location
  bar box in GTK mode.

BUG=41189
TEST=none

Review URL: http://codereview.chromium.org/1604028
------------------------------------------------------------------------
r44379 | jeremy@chromium.org | 2010-04-13 21:06:01 +0200 (Tue, 13 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm

Make the "Try again" button in the translate infobar not trigger a DCHECK .

Loosen up a DCHECK and add a unit test.

BUG=41315
TEST=Repro steps in Bug.

Review URL: http://codereview.chromium.org/1525030
------------------------------------------------------------------------
r44378 | stuartmorgan@chromium.org | 2010-04-13 21:04:42 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc

Fix conditional in PasswordStoreMac initialization

BUG=41332
TEST=Mac version should use keychain to read/store passwords.

Review URL: http://codereview.chromium.org/1528035
------------------------------------------------------------------------
r44373 | dantasse@chromium.org | 2010-04-13 20:33:43 +0200 (Tue, 13 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.h

Make it impossible to click OK if you've selected 0 datatypes.
BUG=40880
TEST=try to Customize Sync so you're syncing 0 datatypes.  You shouldn't be able to.

Review URL: http://codereview.chromium.org/1641001
------------------------------------------------------------------------
r44367 | dantasse@chromium.org | 2010-04-13 19:06:26 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Remove the option to stop syncing if you're in Chrome OS.  Also hide the "Customize" button in case of an error.

BUG=none
TEST=build and run Chrome for Linux.  Start syncing.  Then build for Chrome OS.  Try to stop syncing.  Note that you cannot.

Review URL: http://codereview.chromium.org/1578020
------------------------------------------------------------------------
r44362 | johnnyg@chromium.org | 2010-04-13 18:36:01 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm

On Mac, notifications needs the uninverted coordinate space, because we invert already within the layout code.  This change puts notifications in the correct place regardless of the height of the dock.

BUG=40593
TEST=notifications on mac, with dock set to NOT auto-hide

Review URL: http://codereview.chromium.org/1593017
------------------------------------------------------------------------
r44359 | zelidrag@chromium.org | 2010-04-13 18:00:39 +0200 (Tue, 13 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/select_file_dialog.cc

Fixed crash in bookmark manager crashes when closing file browser window

BUG=39109
TEST=open bookmark manager, select Tools/Import/export, click on cancel, make sure it does not crash
Review URL: http://codereview.chromium.org/1521024
------------------------------------------------------------------------
r44356 | avi@chromium.org | 2010-04-13 17:07:00 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix popups on secondary monitors.

BUG=http://crbug.com/40956
TEST=as in bug

Review URL: http://codereview.chromium.org/1613012
------------------------------------------------------------------------
r44355 | jochen@chromium.org | 2010-04-13 17:02:53 +0200 (Tue, 13 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url

Revert 44351 - Reland 44348 Add support for restricting broadcasting events to extensions based on host permissions

BUG=38398
TEST=none
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/1642005

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1521027
------------------------------------------------------------------------
r44354 | nsylvain@chromium.org | 2010-04-13 17:00:35 +0200 (Tue, 13 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc

Disable WebSocket tests because they broke with the last webkit merge
BUG:41319
Review URL: http://codereview.chromium.org/1508034
------------------------------------------------------------------------
r44352 | pinkerton@chromium.org | 2010-04-13 16:51:10 +0200 (Tue, 13 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.h
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm

Share pasteboard population code between the BookmarkBarController and the BookmarkBarFolderController. Now all bookmarks can be dragged to the desktop, the tab strip, or other windows to load, even ones in folders.
BUG=40834
TEST=see bug. Test bookmarks on the bookmark bar didn't regress.
Review URL: http://codereview.chromium.org/1549037
------------------------------------------------------------------------
r44351 | jochen@chromium.org | 2010-04-13 16:43:02 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url/test.html

Reland 44348 Add support for restricting broadcasting events to extensions based on host permissions

BUG=38398
TEST=none
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/1642005
------------------------------------------------------------------------
r44349 | jochen@chromium.org | 2010-04-13 15:18:10 +0200 (Tue, 13 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url

Revert 44348 - Add support for restricting broadcasting events to extensions based on host permissions.

BUG=38398
TEST=none

Review URL: http://codereview.chromium.org/1095002

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1575036
------------------------------------------------------------------------
r44348 | jochen@chromium.org | 2010-04-13 14:54:10 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/event_url/test.html

Add support for restricting broadcasting events to extensions based on host permissions.

BUG=38398
TEST=none

Review URL: http://codereview.chromium.org/1095002
------------------------------------------------------------------------
r44347 | avayvod@google.com | 2010-04-13 14:33:56 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc

Fixed alpha channel for Welcome to Chromium OS label color.
Updated it so it matches with what we have on the mocks.

BUG=none
TEST=Run with --login-manager --login-screen=oobe and check that Welcome to Chromium OS label is visible and has the right color.

Review URL: http://codereview.chromium.org/1611025
------------------------------------------------------------------------
r44346 | bulach@chromium.org | 2010-04-13 14:16:06 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   A /trunk/src/chrome/test/data/geolocation/invalid_request_url.html

Adds a browser test to exercise WebKit::WebGeolocationServiceBridgeImpl::stopUpdating().
(depends on the fix provided by http://trac.webkit.org/changeset/57335).

BUG=40660,40478
TEST=GeolocationBrowserTest.InvalidUrlRequest

Review URL: http://codereview.chromium.org/1626011
------------------------------------------------------------------------
r44342 | satorux@chromium.org | 2010-04-13 13:08:08 +0200 (Tue, 13 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Rework NormalizeLanguageCode() so it returns codes compatible with Chrome's application locale codes.

The change is necessary to integrate UI language selection in the language
settings dialog. In short, input languages and UI languaes (application
locale codes are used for UI languages) need to be compatible.

TEST=unit_tests
BUG=2336

Review URL: http://codereview.chromium.org/1575034
------------------------------------------------------------------------
r44341 | satorux@chromium.org | 2010-04-13 13:01:20 +0200 (Tue, 13 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Remove a hack that prohibits users from removing English.

Along the way, refactor the code to use tags in ButtonPressed(),
and remove members that are no longer necessary by the change.

TEST=manually
BUG=crosbug.com/2545

Review URL: http://codereview.chromium.org/1525028
------------------------------------------------------------------------
r44333 | mnaganov@chromium.org | 2010-04-13 08:53:15 +0200 (Tue, 13 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Temporarily disable DevToolsSanityTest.TestProfilerTab

BUG=41291
TEST=DevToolsSanityTest.TestProfilerTab

TBR=pfeldman@chromium.org

Review URL: http://codereview.chromium.org/1578028
------------------------------------------------------------------------
r44319 | jhawkins@chromium.org | 2010-04-13 05:00:50 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card.h

AutoFill: Remove one incorrect comment and one useless comment.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1653001
------------------------------------------------------------------------
r44317 | tonyg@chromium.org | 2010-04-13 04:55:08 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h

Factoring out a CancelRequestInternal() method which
avoids unnecessarily performing a second map lookup
in many cases.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1631012
------------------------------------------------------------------------
r44312 | arv@chromium.org | 2010-04-13 03:36:43 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/contextmenuhandler.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js

Bookmark manager: Let the element participate in the context menu positioning.

BUG=40073
TEST=Focus the list or the tree. Press the context menu keyboard key. The menu should be positioned relative to the selected item.

Review URL: http://codereview.chromium.org/1542027
------------------------------------------------------------------------
r44306 | jar@chromium.org | 2010-04-13 02:43:15 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc

Reduce experiment percentages in preparation for a beta cut.

I have an SDCH experiment, and a DNS prefetch experiment running.
I reduced both percentages to 1 in 1000.

r=wtc
Review URL: http://codereview.chromium.org/1528031
------------------------------------------------------------------------
r44304 | georgey@chromium.org | 2010-04-13 02:20:28 +0200 (Tue, 13 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/webdata/web_database.cc

Fixes for several bugs including #41196 on Windows, and #38364 (all systems)
BUG=41196,38364
TEST=In the bugs
Review URL: http://codereview.chromium.org/1519033
------------------------------------------------------------------------
r44302 | mrossetti@chromium.org | 2010-04-13 02:06:20 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm

Once the initial URL is opened in a new window, insure that subsequent URLs are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.

BUG=39901,41104
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, top-most window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".

Review URL: http://codereview.chromium.org/1633009
------------------------------------------------------------------------
r44300 | dhollowa@chromium.org | 2010-04-13 01:57:22 +0200 (Tue, 13 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc

AutoFill unit test cleanup for AutoFillProfileTest.

Swap expected verus actual value in unit test.  A small cleanup item.

BUG=none
TEST=AutoFillProfileTest

Review URL: http://codereview.chromium.org/1651001
------------------------------------------------------------------------
r44298 | zork@chromium.org | 2010-04-13 01:55:22 +0200 (Tue, 13 Apr 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc

TBR: skrul@chromium.org
------------------------------------------------------------------------
r44297 | albertb@chromium.org | 2010-04-13 01:54:52 +0200 (Tue, 13 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h

Since the host content settings preferences can be updated by the sync backend,
make sure HostContentSettingsMap correctly fires off notifications whenever
it modifies them, and re-loads them when they are modified.

Take 2...

BUG=40484,41003
TEST=HostContentSettingsMapTest.*

Review URL: http://codereview.chromium.org/1604020
------------------------------------------------------------------------
r44291 | albertb@chromium.org | 2010-04-13 01:13:50 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h

Schedule PasswordStore tasks on the DB thread on Windows and Linux.

BUG=35038
TEST=PasswordStoreMacTest

Review URL: http://codereview.chromium.org/1524011
------------------------------------------------------------------------
r44289 | albertb@chromium.org | 2010-04-13 00:46:37 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm

Add a UI thread and message loop to the cookie prompt controller test. This is needed by <http://codereview.chromium.org/1604020> because the host_content_settings now registers as an observer of the profile and needs to unregister itself on the UI thread.

BUG=none
TEST=CookiePromptWindowControllerTest.*

Review URL: http://codereview.chromium.org/1527028
------------------------------------------------------------------------
r44286 | cmasone@google.com | 2010-04-13 00:15:43 +0200 (Tue, 13 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Canonicalize email addresses for chrome OS.

According to http://mail.google.com/support/bin/answer.py?hl=en&ctx=mail&answer=10313#, gmail ignores period characters and case differences in the username portion of an email address. Follow those rules. 

BUG=chromiumos:2260 
TEST=unit tests, also run on device and log in with user@google.com and user@GOOGLE.COM; verify that you get the same tab state, etc. in both sessions.
Review URL: http://codereview.chromium.org/1539030
------------------------------------------------------------------------
r44285 | arv@chromium.org | 2010-04-13 00:09:18 +0200 (Tue, 13 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm_test.html

Bookmark manager: Only load the relevant subtree to update the commands.

BUG=41184
TEST=None

Review URL: http://codereview.chromium.org/1610022
------------------------------------------------------------------------
r44283 | zork@chromium.org | 2010-04-12 23:48:10 +0200 (Mon, 12 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h

Add notifications to allow desktop notification permissions to be synced.
Fix a bug where sites can be added to allow and deny lists multiple times.

BUG=none
TEST=Open two browsers with separate profiles.  Request permission for notifications on a site on one.  Check that the permissions are the same on the other browser.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44234

Review URL: http://codereview.chromium.org/1578023
------------------------------------------------------------------------
r44282 | sky@chromium.org | 2010-04-12 23:45:22 +0200 (Mon, 12 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc

Fixes crash in autocomplete when typing some URLs. The problem
occurred because HistoryURLProvider used the url to determine what to
markup vs the actual text.

BUG=41054
TEST=see bug

Review URL: http://codereview.chromium.org/1562023
------------------------------------------------------------------------
r44281 | sky@chromium.org | 2010-04-12 23:41:02 +0200 (Mon, 12 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_folder_editor_controller.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/chrome_browser.gypi

Lands http://codereview.chromium.org/1600010/show for Thiago:

Refactor EditFolderController into BookmarkFolderEditorController
class. 

BUG=None 
TEST=Add and/or edit a bookmark folder. It should works as before. 

Review URL: http://codereview.chromium.org/1640007
------------------------------------------------------------------------
r44278 | zork@chromium.org | 2010-04-12 23:20:49 +0200 (Mon, 12 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc

Add logging statements to ssl_socket_adapter.cc to watch for unexpected conditions.

BUG=40724
TEST=none

Review URL: http://codereview.chromium.org/1602022
------------------------------------------------------------------------
r44275 | jcivelli@chromium.org | 2010-04-12 22:40:25 +0200 (Mon, 12 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc

Fix the "Show original" button of the translate infobar on Linux.

BUG=41203
TEST=See bug.

Review URL: http://codereview.chromium.org/1520034
------------------------------------------------------------------------
r44273 | shess@chromium.org | 2010-04-12 22:20:17 +0200 (Mon, 12 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] PDF icons for omnibox nits.

A couple of post-mortem nits from Trung.

BUGS=none
TEST=trybots

Review URL: http://codereview.chromium.org/1542024
------------------------------------------------------------------------
r44269 | pkasting@chromium.org | 2010-04-12 21:05:28 +0200 (Mon, 12 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix build break due to bad merge resolve

------------------------------------------------------------------------
r44268 | pkasting@chromium.org | 2010-04-12 20:57:03 +0200 (Mon, 12 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   D /trunk/src/chrome/browser/bubble_positioner.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h

Shift omnibox dropdown in and up on Windows, and square off the top, so it connects to the location bar.  Also fix info bubble positioning against location bar icons to put the arrow "up against the icon edge" (fixes the arrow overlapping some page action icons).

Remove BubblePositioner, which is now no longer needed.

BUG=27570,40730
TEST=Omnibox dropdown should line up with editable area edges, icons and text should line up with icon and text in the omnibox.  Info bubbles should still be positioned correctly 
Review URL: http://codereview.chromium.org/1578021
------------------------------------------------------------------------
r44266 | eroman@chromium.org | 2010-04-12 20:35:04 +0200 (Mon, 12 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js

Initialize the new net internals page using the passively collected log entries.

BUG=37421

Review URL: http://codereview.chromium.org/1560025
------------------------------------------------------------------------
r44264 | phajdan.jr@chromium.org | 2010-04-12 20:33:04 +0200 (Mon, 12 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

[GTTF] Make automation calls for Downloads, Extensions, and History pages
reliable.

This way we'll be able to write good pyauto tests for them.

TEST=ui_tests
BUG=none

Review URL: http://codereview.chromium.org/1562021
------------------------------------------------------------------------
r44259 | pkasting@chromium.org | 2010-04-12 19:53:24 +0200 (Mon, 12 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.cc

Trivial: Change STL-container-is-empty check from "size() > 0" to "!empty()".

TBR=thakis
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1575029
------------------------------------------------------------------------
r44256 | bulach@chromium.org | 2010-04-12 19:28:54 +0200 (Mon, 12 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Deny geolocation access for invalid URL in geolocation_permission_context.
(this is to avoid triggering a DCHECK on geolocation_host_content_settings_map).

Note: the bug will be fully fixed after we roll webkit to:
http://trac.webkit.org/changeset/57335

BUG=40660
TEST=GeolocationPermissionContextTests.InvalidURL

Review URL: http://codereview.chromium.org/1632006
------------------------------------------------------------------------
r44255 | dhg@chromium.org | 2010-04-12 19:26:10 +0200 (Mon, 12 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html


Review URL: http://codereview.chromium.org/1631006
------------------------------------------------------------------------
r44250 | jhawkins@chromium.org | 2010-04-12 18:49:47 +0200 (Mon, 12 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/name_field_unittest.cc

AutoFill: Add another variation of a middle name field for heuristics.

BUG=40818
TEST=NameFieldTest.FirstMiddleLast2

Review URL: http://codereview.chromium.org/1612013
------------------------------------------------------------------------
r44249 | arv@chromium.org | 2010-04-12 18:36:17 +0200 (Mon, 12 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/list.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager UI fixes

1. Make the list items a single row.
2. Make the title of the bookmark a link
3. Make the blue bar at the top slightly higher
4. Fix indentation bug of the tree.
5. Fix hover effect for performance.
6. Use default lnf for text inputs when renaming/editing items
7. Reorder context menu items ot better match the organize menu.
8. Don't show the path in search and recent.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1643001
------------------------------------------------------------------------
r44241 | yusukes@google.com | 2010-04-12 15:00:15 +0200 (Mon, 12 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h

Simplify Preferences::SetPreloadEngines() function.

Stop using SetInputMethodActivated cros API and use the generic API, SetImeConfig, instead. This fix greatly reduces total number of ibus_config_set_value() calls.

I'm still not 100% certain, but this change might fix crosbug.com/2471, "Fails to activate an input method occasionally."  ibus-daemon seems to ignore too frequent ibus_config_set_value("general", "preload_engines", ...) calls.

BUG=crosbug.com/2471
TEST=see the bug

Review URL: http://codereview.chromium.org/1596021
------------------------------------------------------------------------
r44235 | zork@chromium.org | 2010-04-12 07:41:39 +0200 (Mon, 12 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h

Revert 44234 - Add notifications to allow desktop notification permissions to be synced.
Fix a bug where sites can be added to allow and deny lists multiple times.

BUG=none
TEST=Open two browsers with separate profiles.  Request permission for notifications on a site on one.  Check that the permissions are the same on the other browser.

Review URL: http://codereview.chromium.org/1578023

TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/1607012
------------------------------------------------------------------------
r44234 | zork@chromium.org | 2010-04-12 07:16:20 +0200 (Mon, 12 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h

Add notifications to allow desktop notification permissions to be synced.
Fix a bug where sites can be added to allow and deny lists multiple times.

BUG=none
TEST=Open two browsers with separate profiles.  Request permission for notifications on a site on one.  Check that the permissions are the same on the other browser.

Review URL: http://codereview.chromium.org/1578023
------------------------------------------------------------------------
r44233 | mdm@chromium.org | 2010-04-12 05:56:24 +0200 (Mon, 12 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Linux: suppress calling gdk_window_raise() on titlebar click when running compiz. It can cause a really weird bug in the version of compiz in Ubuntu 8.04, which we still want to support.
BUG=19291
TEST=drag a window partially offscreen when using compiz in 8.04, then click in the title bar - it will not disappear or move
Review URL: http://codereview.chromium.org/1564024
------------------------------------------------------------------------
r44232 | yusukes@google.com | 2010-04-12 05:13:13 +0200 (Mon, 12 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc

Remove the obsolete function, RemoveDummyInputMethod.
Depends on http://codereview.chromium.org/1523019.

BUG=crosbug.com/2403
TEST=ran browser_tests.

Review URL: http://codereview.chromium.org/1519030
------------------------------------------------------------------------
r44230 | yusukes@google.com | 2010-04-12 04:39:37 +0200 (Mon, 12 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Retry of r44072, which is partially reverted by r44077.

BUG=none
TEST=ran browser_tests on the linux_chromeos try bot.

Review URL: http://codereview.chromium.org/1566036
------------------------------------------------------------------------
r44226 | viettrungluu@chromium.org | 2010-04-12 03:42:26 +0200 (Mon, 12 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc

Mark FindInPageControllerTest.FindMovesWhenObscuring (browser_tests) as flaky on Windows.

BUG=41124
TEST=slightly greener Windows browser_tests
TBR=finnur@chromium.org

Review URL: http://codereview.chromium.org/1634008
------------------------------------------------------------------------
r44217 | mirandac@chromium.org | 2010-04-12 01:16:02 +0200 (Mon, 12 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Commit fix for import from dbelenko.

See http://codereview.chromium.org/1623007/

BUG= 41077
TEST= none
Review URL: http://codereview.chromium.org/1517031
------------------------------------------------------------------------
r44216 | joth@chromium.org | 2010-04-12 00:25:56 +0200 (Mon, 12 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc

Work-around for DBus crash due to timers firing on the wrong thread.

BUG=40803
TEST=run browser & use geolocation.

Review URL: http://codereview.chromium.org/1604023
------------------------------------------------------------------------
r44202 | mrossetti@chromium.org | 2010-04-11 04:10:26 +0200 (Sun, 11 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm

Revert 44201 - Once the initial URL is opened in a new window, insure that subsequent URLs are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.

BUG=39901
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, topmost window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".

Review URL: http://codereview.chromium.org/1634004

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/1520032
------------------------------------------------------------------------
r44201 | mrossetti@chromium.org | 2010-04-11 03:54:33 +0200 (Sun, 11 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm

Once the initial URL is opened in a new window, insure that subsequent URLs are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.

BUG=39901
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, top-most window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".

Review URL: http://codereview.chromium.org/1634004
------------------------------------------------------------------------
r44187 | arv@chromium.org | 2010-04-10 08:34:21 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc

Disable ExtensionApiTest.FavIconPermission on Linux

BUG=41027
TEST=None
TBR=erikkay

------------------------------------------------------------------------
r44186 | thakis@chromium.org | 2010-04-10 07:22:54 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.cc

Geo exceptions: Disable "Remove" button if no row is selected.

BUG=40750
TEST=see bug

Review URL: http://codereview.chromium.org/1542025
------------------------------------------------------------------------
r44182 | skrul@chromium.org | 2010-04-10 06:11:33 +0200 (Sat, 10 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Delay the nudge when syncing only preferences.
BUG=37365

Review URL: http://codereview.chromium.org/1611019
------------------------------------------------------------------------
r44180 | viettrungluu@chromium.org | 2010-04-10 04:58:06 +0200 (Sat, 10 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/resources/plugins.html

Make a JavaScript hook to open a new window to about:terms from chrome://plugins/.

We need it for Flash, and we can't link directly.

BUG=none
TEST=later

Review URL: http://codereview.chromium.org/1642001
------------------------------------------------------------------------
r44179 | estade@chromium.org | 2010-04-10 04:53:47 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc

Linux: open shared memory in browser rather than renderer (like on mac).

BUG=40448
TEST=copy image into gimp from sandboxed chrome. also, gtk_clipboard_dump shows image data on clipboard

Review URL: http://codereview.chromium.org/1517029
------------------------------------------------------------------------
r44178 | estade@chromium.org | 2010-04-10 04:53:37 +0200 (Sat, 10 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: fix TTS padding.

I finished my other bugs so I had some more time to look at this. We were hiding the wrong widget.

BUG=40483
TEST=TTS box doesn't have so much blank space on the left

Review URL: http://codereview.chromium.org/1568029
------------------------------------------------------------------------
r44177 | glen@chromium.org | 2010-04-10 03:44:21 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Round the top left and right edges of the toolbar.

BUG=40022
TEST=Make sure the top left and right eges of the toolbar are rounded.

Review URL: http://codereview.chromium.org/1606021
------------------------------------------------------------------------
r44175 | eroman@chromium.org | 2010-04-10 03:39:43 +0200 (Sat, 10 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix a memory error writing to a deleted URLFetcher instance.

BUG=40505
TEST=existing test under valgrind.
Review URL: http://codereview.chromium.org/1589028
------------------------------------------------------------------------
r44174 | rohitrao@chromium.org | 2010-04-10 03:27:12 +0200 (Sat, 10 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac] Do not schedule more than one delayed call to setNeedsDisplayInRect.  Turns out queuing up a million of these is a bad bad thing.

BUG=40970
TEST=See test in bug.
Review URL: http://codereview.chromium.org/1568027
------------------------------------------------------------------------
r44173 | feldstein@chromium.org | 2010-04-10 03:17:50 +0200 (Sat, 10 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Only show search item when there is a search

Don't show search item until we do a search.  Leave the item there unless the user explicitly clears the search.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1619010
------------------------------------------------------------------------
r44169 | arv@chromium.org | 2010-04-10 02:26:07 +0200 (Sat, 10 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css.js

Bookmark manager - Change the tree expand icon behavior to match Brian's requests.

BUG=None
TEST=Open bookmarks manager. The tree should show the expand icons all the time (given that there are nested folders).


Review URL: http://codereview.chromium.org/1639001
------------------------------------------------------------------------
r44168 | arv@chromium.org | 2010-04-10 02:24:03 +0200 (Sat, 10 Apr 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/resources/bookmark_manager/images/default_favicon.png
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json

Add favicons to the bookmark manager.

This depends on http://codereview.chromium.org/1610011/show

BUG=37802
TEST=Open the bookmark manager. It should now show favicons.

Review URL: http://codereview.chromium.org/1574021
------------------------------------------------------------------------
r44167 | arv@chromium.org | 2010-04-10 02:23:37 +0200 (Sat, 10 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern_unittest.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/favicon
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/favicon/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/favicon/test.html

Allow extensions to access chrome://favicon/.

An extension needs to add chrome://favicon/ to its permission to able to load
favicon images.

WebKit changes: https://bugs.webkit.org/show_bug.cgi?id=37228

BUG=37802
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.*


Review URL: http://codereview.chromium.org/1610011
------------------------------------------------------------------------
r44163 | estade@chromium.org | 2010-04-10 02:05:16 +0200 (Sat, 10 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

GTK: fix padding of autocomplete popup.

This doesn't fix the TTS padding, unfortunately I have more pressing mstone5 bugs to attend to for now (and fixing that padding doesn't look trivial).

BUG=40843
TEST=visual --- text in omnibox and popup should align; images should align as well.

Review URL: http://codereview.chromium.org/1576031
------------------------------------------------------------------------
r44162 | erikkay@chromium.org | 2010-04-10 02:05:03 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc

loosen origin requirements for apps for now

BUG=40848
TEST=none

Review URL: http://codereview.chromium.org/1530027
------------------------------------------------------------------------
r44158 | avi@chromium.org | 2010-04-10 01:23:07 +0200 (Sat, 10 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillAddressFormView.xib
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardFormView.xib
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi

Add "Use as default" checkboxes to the autofill dialogs on the Mac.

Nib change: in each nib, added a checkbox with the correct title and bindings to the file owner of enabled<=>canAlterDefault and value<=>isDefault

BUG=http://crbug.com/38263
TEST=as in bug

Review URL: http://codereview.chromium.org/1527022
------------------------------------------------------------------------
r44157 | akalin@chromium.org | 2010-04-10 01:15:13 +0200 (Sat, 10 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc

Show Infobar on new synced theme even if the theme was already
installed (but not loaded).

Refactored theme handling code in ExtensionInstallerUI.

BUG=40847
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44134

Review URL: http://codereview.chromium.org/1625007
------------------------------------------------------------------------
r44156 | skrul@chromium.org | 2010-04-10 01:13:09 +0200 (Sat, 10 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc

At some UMA counters to log when various failures happen.
BUG=40950

Review URL: http://codereview.chromium.org/1634006
------------------------------------------------------------------------
r44152 | shess@chromium.org | 2010-04-10 01:04:08 +0200 (Sat, 10 Apr 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/app/theme/omnibox_history.pdf
   A /trunk/src/chrome/app/theme/omnibox_http.pdf
   A /trunk/src/chrome/app/theme/omnibox_https_green.pdf
   A /trunk/src/chrome/app/theme/omnibox_https_invalid.pdf
   A /trunk/src/chrome/app/theme/omnibox_https_valid.pdf
   A /trunk/src/chrome/app/theme/omnibox_https_warning.pdf
   A /trunk/src/chrome/app/theme/omnibox_more.pdf
   A /trunk/src/chrome/app/theme/omnibox_search.pdf
   A /trunk/src/chrome/app/theme/omnibox_star.pdf
   A /trunk/src/chrome/app/theme/omnibox_star_lit.pdf
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome_dll.gypi

[Mac] PDF icons for omnibox.

Replaces the various resources used for omnibox icons with PDF images.
The use of copies is because the field is flipped while the popup is
unflipped (and the icons get flipped to match).

BUG=37865
TEST=Icons don't look suck, look awesome when scale factor is changed under Quartz Debug.

Review URL: http://codereview.chromium.org/1629010
------------------------------------------------------------------------
r44149 | jhawkins@chromium.org | 2010-04-10 00:56:34 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/form_data.h

AutoFill: Fill the default profile when the AutoFill accelerator combo is pressed (ctrl-shift-a).

BUG=39491
TEST=none

Review URL: http://codereview.chromium.org/1521020
------------------------------------------------------------------------
r44148 | johnnyg@chromium.org | 2010-04-10 00:53:48 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc

Make sure small notifications get shown.  Previous change to make sure notifications don't shrink caused a regression when the notification is of minimal size (like the one from html5rocks.com), since this is the same as the pre-show size.

BUG=40817
TEST=see bug

Review URL: http://codereview.chromium.org/1558031
------------------------------------------------------------------------
r44147 | viettrungluu@chromium.org | 2010-04-10 00:47:05 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   D /trunk/src/chrome/browser/dom_ui/eula_ui.cc
   D /trunk/src/chrome/browser/dom_ui/eula_ui.h
   M /trunk/src/chrome/browser/plugin_service.cc
   D /trunk/src/chrome/browser/resources/eula.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

No longer display EULA when internal Flash enabled (revert r42783 and most of r42674).

BUG=none
TEST=Run (branded, official) Google Chrome build with --enable-internal-flash; EULA "dialog" tab should no longer be shown, and our Flash should be enabled (check about:plugins). Without --enable-internal-flash, it should still not appear in about:plugins.

Review URL: http://codereview.chromium.org/1527023
------------------------------------------------------------------------
r44145 | erg@chromium.org | 2010-04-10 00:28:58 +0200 (Sat, 10 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Theme the icons in the location bar and use GTK colors for the autocomplete dropdown.

BUG=40855
TEST=none

Review URL: http://codereview.chromium.org/1631010
------------------------------------------------------------------------
r44144 | tonyg@chromium.org | 2010-04-10 00:28:01 +0200 (Sat, 10 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Fix silly DCHECK introduced by me in r44019.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1625009
------------------------------------------------------------------------
r44140 | sky@chromium.org | 2010-04-10 00:20:40 +0200 (Sat, 10 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/net/browser_url_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Strips http from the omnibox

BUG=none
TEST=type in urls and make sure once loaded we don't show http. Make sure we do show https (and other schemes) though.
Review URL: http://codereview.chromium.org/1513023
------------------------------------------------------------------------
r44139 | akalin@chromium.org | 2010-04-10 00:10:11 +0200 (Sat, 10 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc

Revert 44134 - Show Infobar on new synced theme even if the theme was already
installed (but not loaded).

Refactored theme handling code in ExtensionInstallerUI.

BUG=40847
TEST=manual

Review URL: http://codereview.chromium.org/1625007

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/1599024
------------------------------------------------------------------------
r44136 | estade@chromium.org | 2010-04-09 23:58:02 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h

GTK: fix corner case where we'd show the overflow chevron for the browser action toolbar even without overflow.

The show/hide is async following the size_request change, so gtk_chrome_shrinkable_hbox_get_visible_child_count was not appropriate. Instead, show/hide the chevron when buttons show/hide.

BUG=40763
TEST=see bug. Also, removing extensions still updates the chevron state.

Review URL: http://codereview.chromium.org/1558035
------------------------------------------------------------------------
r44135 | arv@chromium.org | 2010-04-09 23:57:41 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager - Add blue line and move menu button into the summary header. This also makes the splitter use the same color as the blue header.

BUG=38004 
TEST=Launch bookmark manager and see the blue header and blue splitter

Review URL: http://codereview.chromium.org/1513029
------------------------------------------------------------------------
r44134 | akalin@chromium.org | 2010-04-09 23:53:48 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/sync/glue/theme_util.cc

Show Infobar on new synced theme even if the theme was already
installed (but not loaded).

Refactored theme handling code in ExtensionInstallerUI.

BUG=40847
TEST=manual

Review URL: http://codereview.chromium.org/1625007
------------------------------------------------------------------------
r44133 | estade@chromium.org | 2010-04-09 23:49:19 +0200 (Fri, 09 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

GTK: fix <select> dropdown corner case behaviors caused by WebKit changeset 56449

They should also now work better in extension popups than they ever did previously.

known issue: the <select> box keeps the focus ring while the dropdown is open (affects all platforms)

BUG=39937
TEST=
1) Using https://chrome.google.com/extensions/detail/jiannbmldmbdmkhkdknlaemanjcobdko , the select popup should work as expected.
2) Using <select> should work as expected; in particular, while using focus-follows-mouse, mousing over other toplevel windows while the dropdown is showing should not close the dropdown

Review URL: http://codereview.chromium.org/1558014
------------------------------------------------------------------------
r44132 | aa@chromium.org | 2010-04-09 23:41:05 +0200 (Fri, 09 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/alert_apitest.cc
   M /trunk/src/chrome/browser/js_modal_dialog.cc
   M /trunk/src/chrome/browser/js_modal_dialog.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h

Revert r44125
BUG=40439

TBR=sky@chromium.org
------------------------------------------------------------------------
r44131 | sky@chromium.org | 2010-04-09 23:30:20 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/animation/bounds_animator.cc

Fixes bugs in new tab strip animations where they weren't doing the
right thing when rtl.

BUG=40920
TEST=make sure the tabstrip draws correctly when running rtl and
closing/moving/inserting tabs.

Review URL: http://codereview.chromium.org/1613009
------------------------------------------------------------------------
r44128 | chocobo@chromium.org | 2010-04-09 23:12:06 +0200 (Fri, 09 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/gfx/canvas_linux.cc
   M /trunk/src/gfx/canvas_mac.mm

Status area improvements:
- text is now 70% alpha
- font is 1 size larger
- 6 pixels between status icons
- icon and text are lined up better
- when clock changes text, bounds are reset properly

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1589021
------------------------------------------------------------------------
r44127 | dumi@chromium.org | 2010-04-09 23:07:48 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc

Disable this test on Linux, because it will fail as soon as WebKit's
version is rolled forward.

TEST=none
BUG=40976


Review URL: http://codereview.chromium.org/1610016
------------------------------------------------------------------------
r44125 | aa@chromium.org | 2010-04-09 23:06:10 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/alert_apitest.cc
   M /trunk/src/chrome/browser/js_modal_dialog.cc
   M /trunk/src/chrome/browser/js_modal_dialog.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h

Attempt fix for crash bug when alert closes while owning host
is invalid.

I can't actually repro this bug, but I think this should fix it.

BUG=40439

Review URL: http://codereview.chromium.org/1540024
------------------------------------------------------------------------
r44122 | cpu@chromium.org | 2010-04-09 22:40:11 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_test.h
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc

Allow specifiying a different user-data-dir for diagnostic mode

- Polish the db tests a little bit, now there are critical and non-critical and it handles better is chrome is already running

BUG=27885
TEST=none

Review URL: http://codereview.chromium.org/1540027
------------------------------------------------------------------------
r44121 | atwilson@chromium.org | 2010-04-09 22:32:42 +0200 (Fri, 09 Apr 2010) | 21 lines
Changed paths:
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/test/testing_browser_process.h

Auto restart when update available while running in the background on windows.

Landing on behalf of dbelenko@google.com.

This is a new version of the older patch. Main changes include: 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are    blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit    cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc).

This patch adds a timer which fires every 6 hours and checks whether the
browser is in the "persistent" (background) mode, and whether there's an
update pending restart. If both conditions are true, the browser is
restarted with blacklisted command line keys and all loose values stripped. In order to
restart the browser in the background mode, the --long-lived-extensions
key is also added to the command line.

This change is Windows-only, and it won't become fully functional until
Drew (atwilson) checks in his work that enables Chrome to go into background.

Additionally, this addresses an issue where a restarted browser might load its profile data before the previous browser process exited - we now load the profile data *after* trying to contact the other browser. This exposed a race condition in SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching, so we disabled that test and logged http://crbug.com/40946.

BUG=40975,40946

Review URL: http://codereview.chromium.org/1618012
------------------------------------------------------------------------
r44120 | sky@chromium.org | 2010-04-09 22:30:45 +0200 (Fri, 09 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

More flakyness

BUG=40932
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1591028
------------------------------------------------------------------------
r44116 | glen@chromium.org | 2010-04-09 21:49:48 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resources/frame_default.png
   M /trunk/src/app/resources/frame_default_inactive.png
   M /trunk/src/chrome/app/theme/theme_frame_default.png
   M /trunk/src/chrome/app/theme/theme_frame_default_inactive.png
   M /trunk/src/chrome/app/theme/theme_toolbar_default.png
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Change the default theme colors.

BUG=40023
TEST=Make sure toolbar is grey

Review URL: http://codereview.chromium.org/1566009
------------------------------------------------------------------------
r44115 | glen@chromium.org | 2010-04-09 21:49:32 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/app/resources/window_bottom_left_corner.png
   M /trunk/src/app/resources/window_bottom_right_corner.png
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/custom_frame_view.cc
   A /trunk/src/views/window/window_shape.cc
   A /trunk/src/views/window/window_shape.h

Make the bottom edges of the opaque frame rounded.

BUG=40024
TEST=On a non-AeroGlass Windows machine, verify that the bottom edges of the Window are rounded.

Review URL: http://codereview.chromium.org/1560021
------------------------------------------------------------------------
r44114 | rsesek@chromium.org | 2010-04-09 21:42:59 +0200 (Fri, 09 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm

Fixed a Memcheck:Cond in content_blocked_bubble_controller_unittest.mm caused by r44084.

TBR=mnissler
BUG=none
TEST=Valgrind Mac unit goes green

Review URL: http://codereview.chromium.org/1632008
------------------------------------------------------------------------
r44112 | creis@chromium.org | 2010-04-09 21:39:58 +0200 (Fri, 09 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/test/data/reliability/known_crashes.txt

Adds an updated safety check for DOM UI renderers. 

We should not be passing web URLs to DOM UI renderers. This CL
adds a check to ensure that we only navigate to DOM-UI-permitted
URLs in such renderers. 

BUG=40575, 40893
TEST=none 

Review URL: http://codereview.chromium.org/1631009
------------------------------------------------------------------------
r44111 | viettrungluu@chromium.org | 2010-04-09 21:29:52 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc

Revert 43410 - Add Flash EULA to about box on Linux/GTK (for branded builds).

BUG=none
TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link.

Review URL: http://codereview.chromium.org/1593006

TBR=viettrungluu@chromium.org, cpu@chromium.org, estade@chromium.org
Review URL: http://codereview.chromium.org/1539028
------------------------------------------------------------------------
r44110 | arv@chromium.org | 2010-04-09 21:23:56 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/menu.css
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Update the look and feel of NTP and bookmark menus based on Cole's feedback.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1540029
------------------------------------------------------------------------
r44109 | viettrungluu@chromium.org | 2010-04-09 21:21:50 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Revert 43443 - Add Flash EULA to about box on Mac (for branded builds).

BUG=none
TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link.

Review URL: http://codereview.chromium.org/1610001

TBR=viettrungluu@chromium.org, cpu@chromium.org, dhollowa@chromium.org
Review URL: http://codereview.chromium.org/1574022
------------------------------------------------------------------------
r44108 | viettrungluu@chromium.org | 2010-04-09 21:17:19 +0200 (Fri, 09 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Revert 43545 - Add Flash EULA to about box on Windows/Views (for branded builds).

BUG=none
TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Te rms of Service, with "License Agreement" an appropriate link.

Review URL: http://codereview.chromium.org/1561010

TBR=viettrungluu@chromium.org, cpu@chromium.org, finnur@chromium.org

Review URL: http://codereview.chromium.org/1558036
------------------------------------------------------------------------
r44107 | avi@chromium.org | 2010-04-09 21:03:43 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/views/generic_info_view.cc
   M /trunk/src/media/base/callback.h
   M /trunk/src/o3d/samples/manipulators/manipsample.js
   M /trunk/src/o3d/samples/primitives.html
   M /trunk/src/o3d/samples/vertex-shader.html
   M /trunk/src/o3d/tests/selenium/tests/pixel-perfection.html
   M /trunk/src/tools/code_coverage/process_coverage.py
   M /trunk/src/tools/xcodebodge/xcodebodge.py

Hierarchy. Hierarchy. Hierarchy!!!

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1561020
------------------------------------------------------------------------
r44104 | rohitrao@chromium.org | 2010-04-09 20:13:53 +0200 (Fri, 09 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   A /trunk/src/chrome/browser/find_bar_state.cc
   A /trunk/src/chrome/browser/find_bar_state.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.h

Do not prepopulate the findbar with incognito search terms.

BUG=32021
TEST=On win/linux, open an incognito window and search for some term.  Then open a new normal tab and press Ctrl-F.  Findbar should not be prepopoulated with your incognito search term.
Review URL: http://codereview.chromium.org/1561018
------------------------------------------------------------------------
r44101 | sky@chromium.org | 2010-04-09 19:41:16 +0200 (Fri, 09 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Yet another flaky ssl test.

BUG=40932
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1604021
------------------------------------------------------------------------
r44100 | creis@chromium.org | 2010-04-09 19:25:16 +0200 (Fri, 09 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Revert 43962 - Adds a safety check for DOM UI renderers.
(Currently crashing on reliability bot.)

We should not be passing web URLs to DOM UI renderers.  This CL adds a
check to ensure that we only navigate to DOM UI URLs in such renderers.

BUG=40575
TEST=none

Review URL: http://codereview.chromium.org/1549027

TBR=brettw
Review URL: http://codereview.chromium.org/1626012
------------------------------------------------------------------------
r44098 | sky@chromium.org | 2010-04-09 19:04:47 +0200 (Fri, 09 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Marks handful of ssl ui tests as flaky.

BUG=40932
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1551022
------------------------------------------------------------------------
r44096 | viettrungluu@chromium.org | 2010-04-09 19:02:50 +0200 (Fri, 09 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list.cc
   A /trunk/src/chrome/browser/browser_list_mac.mm
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/chrome_browser_application_mac.h
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi

Mac: reform our shutdown routine.

Make shutdown be more like other platforms. Moreover:
- Cancelling quit from an onbeforeunload dialog shouldn't mess up the browser.
- Having quit cancelled due to a window pop up on the closure of another window
  shouldn't break the browser. [With this patch, it will result in the browser
  being in a quirky state in which the closure of the last browser window will
  cause a quit. But the browser won't be broken.]

BUG=34384,37813,37927
TEST=See bugs.

Review URL: http://codereview.chromium.org/1520006
------------------------------------------------------------------------
r44091 | shess@chromium.org | 2010-04-09 18:08:28 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] No star icon or page actions in omnibox on popups.

BUG=40730
TEST=install "lights out" extension.  Go to www.popuptest.com.  See if the page-action and the star are still in a popup.

Review URL: http://codereview.chromium.org/1627012
------------------------------------------------------------------------
r44090 | skrul@chromium.org | 2010-04-09 18:03:39 +0200 (Fri, 09 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Preferences cleanup.

Review URL: http://codereview.chromium.org/1609004
------------------------------------------------------------------------
r44089 | mnissler@chromium.org | 2010-04-09 17:58:20 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h

Delete testing profile on UI thread.

Fixes a MAC-only test caused by the changes of r44036.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1512031
------------------------------------------------------------------------
r44087 | shess@chromium.org | 2010-04-09 17:41:51 +0200 (Fri, 09 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/test_location_bar.h

Don't allow drag or click on location icon when editing in omnibox.

After editing the omnibox, clicking the location icon would provide
the page info for the page being shown, though the rest of the omnibox
might be inconsistent with that page.  Exposes the logic used by
AutocompleteEditView::GetIcon() to determine when there's a real URL
for page-info (or drag).

BUG=none
TEST=Navigate to a page.  Click location icon to see page info.  Edit the omnibox, click should not show page info.

Review URL: http://codereview.chromium.org/1594012
------------------------------------------------------------------------
r44086 | glotov@google.com | 2010-04-09 17:33:58 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc
   M /trunk/src/chrome/browser/chromeos/login/language_switch_model.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/mock_screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Language selection is added to the login view.

BUG=39803, cros/1537
TEST=none

Review URL: http://codereview.chromium.org/1559018
------------------------------------------------------------------------
r44085 | rsesek@chromium.org | 2010-04-09 17:33:43 +0200 (Fri, 09 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Re-land r43741 - broke browser_tests.
[Mac] Make Mac phantom tabs match the appearance of the other platforms.

BUG=none
TEST=Open a new tab, navigate, and pin it. Open a new tab. Close the pinned tab. No tab background should be drawn, just the favicon.

Review URL: http://codereview.chromium.org/1632007
------------------------------------------------------------------------
r44084 | mnissler@chromium.org | 2010-04-09 17:29:17 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookiePrompt.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc

Disable remember option in cookie prompt and content blocked notification bubbles when running OTR.

BUG=37525
TEST=Manual, check cookie prompt and bubbles in OTR session

Review URL: http://codereview.chromium.org/1629011
------------------------------------------------------------------------
r44083 | sky@chromium.org | 2010-04-09 17:25:57 +0200 (Fri, 09 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Marks handful of ssl ui tests as flaky.

BUG=40932
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1605020
------------------------------------------------------------------------
r44082 | mnissler@chromium.org | 2010-04-09 16:59:23 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc

Destroy testing profile on UI thread.

This fixes the failing tests caused by r44036 (cf. http://codereview.chromium.org/1589026).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1594024
------------------------------------------------------------------------
r44081 | phajdan.jr@chromium.org | 2010-04-09 16:27:24 +0200 (Fri, 09 Apr 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/browsing_data_database_helper_browsertest.cc (from /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc:43944)
   D /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper_browsertest.cc (from /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc:43944)
   D /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   D /trunk/src/chrome/browser/child_process_security_policy_browser_test.cc
   A /trunk/src/chrome/browser/child_process_security_policy_browsertest.cc (from /trunk/src/chrome/browser/child_process_security_policy_browser_test.cc:43944)
   A /trunk/src/chrome/browser/extensions/extension_management_browsertest.cc (from /trunk/src/chrome/browser/extensions/extension_management_tests.cc:43944)
   D /trunk/src/chrome/browser/extensions/extension_management_tests.cc
   A /trunk/src/chrome/browser/extensions/extension_shelf_model_browsertest.cc (from /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc:43944)
   D /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc (from /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc:44062)
   D /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_toolbar_model_browsertest.cc (from /trunk/src/chrome/browser/extensions/extension_toolbar_model_unittest.cc:43944)
   D /trunk/src/chrome/browser/extensions/extension_toolbar_model_unittest.cc
   A /trunk/src/chrome/browser/views/browser_actions_container_browsertest.cc (from /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc:43944)
   D /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/renderer/form_autocomplete_browsertest.cc (from /trunk/src/chrome/renderer/form_autocomplete_unittest.cc:43944)
   D /trunk/src/chrome/renderer/form_autocomplete_unittest.cc

Fix file names so that for browser tests the suffix is _browsertest.

TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1549028
------------------------------------------------------------------------
r44080 | kuan@chromium.org | 2010-04-09 15:32:12 +0200 (Fri, 09 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.h

redesign and reimplement auto-translate preferences
- old prefs
  - one source lang could be auto-translated to several target langs
  - storage: list of target langs
- new prefs
  - one source lang can only be auto-translated to one target lang, the latest option overwriting previous one
  - storage: a single string value of target lang
- besides using new format, also migrate old to new format when registering user prefs

BUG=37313
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/1551021
------------------------------------------------------------------------
r44079 | jochen@chromium.org | 2010-04-09 15:10:21 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc
   M /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.cc
   A /trunk/src/chrome/renderer/renderer_webapplicationcachehost_impl.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   M /trunk/src/webkit/appcache/appcache_frontend_impl.h
   M /trunk/src/webkit/appcache/appcache_group.cc
   M /trunk/src/webkit/appcache/appcache_group.h
   M /trunk/src/webkit/appcache/appcache_group_unittest.cc
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host.h
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_request_handler.cc
   M /trunk/src/webkit/appcache/appcache_request_handler.h
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_storage.h
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl.h
   M /trunk/src/webkit/appcache/appcache_storage_impl_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/mock_appcache_storage.cc
   M /trunk/src/webkit/appcache/mock_appcache_storage_unittest.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Indicate in the tab UI if appcache creation was blocked by privacy settings.

TEST=manual
BUG=38362

Review URL: http://codereview.chromium.org/1600002
------------------------------------------------------------------------
r44077 | yusukes@google.com | 2010-04-09 14:18:15 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc

Fix build break (browser_test failure on Chromium OS bot).
This is partial revert of r44072.

TBR=satorux

Review URL: http://codereview.chromium.org/1619009
------------------------------------------------------------------------
r44074 | bauerb@chromium.org | 2010-04-09 13:59:02 +0200 (Fri, 09 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.h
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   A /trunk/src/chrome/browser/repost_form_warning_controller.cc
   A /trunk/src/chrome/browser/repost_form_warning_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h

Refactor common, platform-independent code for the repost form warning dialog on all platforms into a delegate.

The platform-dependent ConstrainedWindow{Gtk,Mac,Win} classes each have their own platform-dependent |ConstrainedWindowDelegate| to inherit from, so instead of a common superclass they now have a RepostFormWarningDelegate.

Also, change the RELOADING notification to REPOST_WARNING_SHOWN to avoid trying to close the dialog while it's already in the process of being closed.

BUG=none
TEST=RepostFormWarningTest.*

Review URL: http://codereview.chromium.org/1520023
------------------------------------------------------------------------
r44073 | joth@chromium.org | 2010-04-09 12:48:26 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc

Simplify the geolocation content settings map: it's only ever used from the UI thread, so no need for it to cache a copy of the prefs values

BUG=none
TEST=GeolocationContentSettingsMapTests.*

Review URL: http://codereview.chromium.org/1525018
------------------------------------------------------------------------
r44072 | yusukes@google.com | 2010-04-09 12:35:55 +0200 (Fri, 09 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adding 2 preferences for configuring "NextEngine" and "Trigger" hot-keys.

This change also disables the latter hot-key so that users can't disable IBus. This is preferable since "current input method is xkb:us::eng (for example) and it is enabled" and "current one is xkb:us::eng but it's disabled" are almost indistinguishable.

This change depends on http://codereview.chromium.org/1528023 and http://codereview.chromium.org/1610013.

BUG=none
TEST=boot chrome os, activate English and Chinese, click omnibox, press lang menu, press English to enable "xkb:us::eng", press omnibox, press ctrl+space, verify that the menu shows "Chi" (not "Eng").

Review URL: http://codereview.chromium.org/1553018
------------------------------------------------------------------------
r44071 | glotov@google.com | 2010-04-09 12:35:47 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h

Fixing possobility of some wizard View outlive its controller.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1595014
------------------------------------------------------------------------
r44070 | bulach@chromium.org | 2010-04-09 12:21:10 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h

Simplify content settings bubble model "radio groups" to a single radio group.

There's no longer a use case for multiple radio groups (was originally planned for Geolocation), simplify the model and its views.

BUG=39073
TEST=content_setting_bubble_model_unittest

Review URL: http://codereview.chromium.org/1575022
------------------------------------------------------------------------
r44065 | satorux@chromium.org | 2010-04-09 11:11:26 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc

Convert some spcial three-letter codes in NormalizeLanguageCode().

The conversion is necessary so we can show language names properly in UI.

TEST=unit_tests
BUG=none

Review URL: http://codereview.chromium.org/1607010
------------------------------------------------------------------------
r44062 | oshima@chromium.org | 2010-04-09 09:00:08 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc

Fix issue where the size of notification on linux/views gets created bigger than max size.

BUG=none
TEST=manual: run linux/view build or chromeos build and create a web notification. The size of balloon should be same as one in Windows.

Review URL: http://codereview.chromium.org/1631007
------------------------------------------------------------------------
r44057 | eroman@chromium.org | 2010-04-09 06:34:47 +0200 (Fri, 09 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.cc
   M /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/chrome/browser/resources/net_internals/loggrouper.js
   M /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/base/net_log_event_type_list.h
   M /trunk/src/net/base/net_log_unittest.h
   M /trunk/src/net/base/net_log_util.cc
   M /trunk/src/net/base/net_log_util.h
   M /trunk/src/net/base/net_log_util_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/url_request/url_request.cc

Add support for attaching custom parameters to NetLog events.

BUG=37421

Review URL: http://codereview.chromium.org/1556018
------------------------------------------------------------------------
r44056 | skrul@chromium.org | 2010-04-09 06:25:31 +0200 (Fri, 09 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.h
   A /trunk/src/chrome/browser/host_zoom_map_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Make HostZoomMap play nicely with preference sync.

Review URL: http://codereview.chromium.org/1560023
------------------------------------------------------------------------
r44052 | georgey@chromium.org | 2010-04-09 05:33:33 +0200 (Fri, 09 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Fixes for several crashing bugs ##40674,40720,40744
BUG=40674,40720,40744
TEST=In the bugs.
Review URL: http://codereview.chromium.org/1594021
------------------------------------------------------------------------
r44051 | skrul@chromium.org | 2010-04-09 05:00:08 +0200 (Fri, 09 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/theme_model_associator.cc

At some point we changed the synchronous model associator methods to not call OnUnrecoverableError on errors and rather just return "false".  However, we seem to have regressed and this makes bad stuff happen when there are errors when starting sync.

BUG=40867

Review URL: http://codereview.chromium.org/1558034
------------------------------------------------------------------------
r44045 | tim@chromium.org | 2010-04-09 04:23:26 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

Fix for autofill profile setup through infobar where the "imported" profile would
not get persisted.  The problem was ImportFormData was assigning ID, which was causing
SetProfile to think it was an update, rather than an Add, and the update would then fail.

BUG=40297
TEST=PersonalDataManagerTest.ImportFormData (added)

Review URL: http://codereview.chromium.org/1589025
------------------------------------------------------------------------
r44043 | jhawkins@chromium.org | 2010-04-09 04:03:07 +0200 (Fri, 09 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

AutoFill: Initiate AutoFill for all fields, not just the name field.
Fix a case issue when matching names.

BUG=40299
TEST=none

Review URL: http://codereview.chromium.org/1575023
------------------------------------------------------------------------
r44041 | atwilson@chromium.org | 2010-04-09 03:18:35 +0200 (Fri, 09 Apr 2010) | 22 lines
Changed paths:
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/test/testing_browser_process.h

Revert 43989 - This is a new version of the older patch. Main changes include:
1. Rebased to a never Git revision to make things easier to land.
2. Chrome will now preserve the command line switches except for those that are
   blacklisted.
3. Fixed a race condition that would cause the browser to think it didn't exit
   cleanly after it's been restarted.
4. Fixed minor nits and omissions (indentation, etc).

This patch adds a timer which fires every 6 hours and checks whether the
browser is in the "persistent" (background) mode, and whether there's an
update pending restart. If both conditions are true, the browser is
restarted with blacklisted command line keys and all loose values stripped. In order to
restart the browser in the background mode, the longlivedextensions
key is also added to the command line.

This change is Windowsonly, and it won't become fully functional until
Drew (atwilson) checks in his work that enables Chrome to go into background.

Review URL: http://codereview.chromium.org/1617001

TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/1517027
------------------------------------------------------------------------
r44039 | viettrungluu@chromium.org | 2010-04-09 02:59:07 +0200 (Fri, 09 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Revert 44036 [unit_tests failed] - Since the host content settings preferences can be updated by the sync backend,
make sure HostContentSettingsMap correctly fires off notifications whenever
it modifies them, and reloads them when they are modified.

BUG=none
TEST=HostContentSettingsMapTest.*

Review URL: http://codereview.chromium.org/1540026

TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/1589026
------------------------------------------------------------------------
r44036 | albertb@chromium.org | 2010-04-09 02:28:39 +0200 (Fri, 09 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h

Since the host content settings preferences can be updated by the sync backend,
make sure HostContentSettingsMap correctly fires off notifications whenever
it modifies them, and re-loads them when they are modified.

BUG=none
TEST=HostContentSettingsMapTest.*

Review URL: http://codereview.chromium.org/1540026
------------------------------------------------------------------------
r44035 | dantasse@chromium.org | 2010-04-09 02:28:23 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Fix bug 40555.  Make sure to nudge the syncer if you're syncing new data types, so it will download updates.

BUG=40555
TEST= Set up sync with some data types.  Then customize sync to add or subtract some.  Chrome should not crash or display command-line errors.

Review URL: http://codereview.chromium.org/1566032
------------------------------------------------------------------------
r44033 | mattm@chromium.org | 2010-04-09 02:23:00 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model.cc
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc

Tentative fix for crash in EncodingMenuController::IsItemChecked.

BUG=36180
TEST=unittest

Review URL: http://codereview.chromium.org/1591026
------------------------------------------------------------------------
r44029 | ben@chromium.org | 2010-04-09 02:16:08 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/views/window/window_win.cc

Fix client edge insets for fullscreen mode. we were incorrectly insetting the client area in fullscreen mode even though there are no non-client edges in fullscreen mode. This involves:

1. adding a check for IsFullscreen to the BrowserFrameWin code that calculates the client area insets for fullscreen state, just as it currently checks for maximized state.
2. bypass the WindowWin's sanity check for default insets in the Fullscreen case - in fullscreen mode the window should have zero non-client, not default restored non-client.

http://crbug.com/37588
http://crbug.com/39076

Review URL: http://codereview.chromium.org/1618009
------------------------------------------------------------------------
r44028 | oshima@chromium.org | 2010-04-09 02:11:56 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc

Delete all RenderViewHost in BalloonViewImpl on exit.
 Not deleting them was causing assertion failure. See the bug description for details.
* Added TestCleanExit
* Removed empty test that was checked in by my mistake.

BUG=40810
TEST=Added NotificationTest.TestCleanExit

Review URL: http://codereview.chromium.org/1600018
------------------------------------------------------------------------
r44022 | evan@chromium.org | 2010-04-09 01:52:31 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

gtk: remove a "fast path" that wasn't actually correct

The function involved relied on internals of how the toolbar worked;
apparently in my version of GTK it was not correct.

BUG=40862
TEST=hit ctl-shift-B, chrome no longer hangs (on my system)

Review URL: http://codereview.chromium.org/1578024
------------------------------------------------------------------------
r44021 | estade@chromium.org | 2010-04-09 01:51:07 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

[GTK] Add TTS lens graphic to linux TTS box.

BUG=40654
TEST=visual

Review URL: http://codereview.chromium.org/1637002
------------------------------------------------------------------------
r44019 | tonyg@chromium.org | 2010-04-09 01:47:25 +0200 (Fri, 09 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Fix a bug which caused a hang when loading a resource with
a content-type that triggers a download and a response code
other than 2xx.

This modifies the fix introduced in r7703 for crbug.com/5800.
I've verified that crbug.com/5800 is not reintroduced.

This patch leaves the confusing ERR_FILE_NOT_FOUND message in
place. I plan to improve that message in a subsequent patch.

BUG=31266
TEST=ResourceDispatcherHostTest.ForbiddenDownload
Review URL: http://codereview.chromium.org/1545026
------------------------------------------------------------------------
r44016 | dspringer@google.com | 2010-04-09 00:35:38 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Fix Pepper2D on the Mac so that it runs in the sandbox.  Note that trusted
plugins still have to run outside of the sandbox (this is not a regression).
This CL allows untrusted Pepper 2D plugins to run in the sandbox on the Mac.

BUG=40701
TEST=pepper_test_plugin (has to run w/ --no-sandbox on Mac), run any untrusted
    .nexe that uses Pepper 2D or 3D (examples are inthe NaCl SDK).

Review URL: http://codereview.chromium.org/1558032
------------------------------------------------------------------------
r44014 | johnnyg@chromium.org | 2010-04-09 00:14:39 +0200 (Fri, 09 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.mm
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notification_test_util.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/common/notification_type.h

Add notification processes to the task manager.

BUG=29332
TEST=notifications in task manager

Review URL: http://codereview.chromium.org/1610006
------------------------------------------------------------------------
r44012 | sky@chromium.org | 2010-04-09 00:10:01 +0200 (Fri, 09 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Revert 44004 - Changes browser_tests to not run a nested message loop.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1513014

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1558033
------------------------------------------------------------------------
r44008 | shess@chromium.org | 2010-04-08 23:55:01 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

[Mac] Tweak location icon spacing in omnibox.

BUG=40419
TEST=Icons and text line up between field and popup.
TEST=Compare mock at http://crbug.com/27570

Review URL: http://codereview.chromium.org/1525021
------------------------------------------------------------------------
r44006 | mpcomplete@chromium.org | 2010-04-08 23:39:48 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc

Reenable PluginLoadUnload after fixing a race condition that made it fail in
Release mode. The problem was that we would attempt to restart the plugin
process as it was shutting down.

BUG=40588

Review URL: http://codereview.chromium.org/1585021
------------------------------------------------------------------------
r44004 | sky@chromium.org | 2010-04-08 23:30:42 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Changes browser_tests to not run a nested message loop.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1513014
------------------------------------------------------------------------
r44002 | jcivelli@google.com | 2010-04-08 23:11:12 +0200 (Thu, 08 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/options_util.cc

Landing Thiago patch.
See original review:
http://codereview.chromium.org/1529009

BUG=None
TEST=None
TBR=kuan
Review URL: http://codereview.chromium.org/1620006
------------------------------------------------------------------------
r44001 | finnur@chromium.org | 2010-04-08 23:02:53 +0200 (Thu, 08 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Make ExtensionContextMenuModel hold on to a reference to itself
while waiting for the results from the uninstall dialog. Otherwise
uninstallation will be cancelled because the observer went away.

BUG=40066
TEST=None

Review URL: http://codereview.chromium.org/1593016
------------------------------------------------------------------------
r44000 | aa@chromium.org | 2010-04-08 22:58:35 +0200 (Thu, 08 Apr 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/alert_apitest.cc (from /trunk/src/chrome/browser/extensions/extension_apitest_misc.cc:43999)
   D /trunk/src/chrome/browser/extensions/extension_apitest_misc.cc
   M /trunk/src/chrome/chrome_tests.gypi

Rename extension_apitests_misc.cc => alert_apitest.cc because
I am going to add another alert-related test and because I
hate grab bags.

Review URL: http://codereview.chromium.org/1620004
------------------------------------------------------------------------
r43999 | rafaelw@chromium.org | 2010-04-08 22:37:43 +0200 (Thu, 08 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/file_after_close
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/file_after_close/extension_page.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/file_after_close/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/file_after_close/script.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/file_after_close/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/file_after_close/web_page1.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/file_after_close/web_page2.html

Move GetExtension() from ExtensionFunctionDispatcher to ExtensionFunction.

EFD's can expire during the processing of AsyncExtensionFunctions, so this change enables them to retain access to their extension to complete their work.

This fixes a bug in executeScript where when a file source was used, but the call was made from a popup which which had closed, by the time the file source was loaded, the EFD had been destroyed. Go boom.

BUG=32431
TEST=All tests should pass

Review URL: http://codereview.chromium.org/1549026
------------------------------------------------------------------------
r43998 | eroman@chromium.org | 2010-04-08 22:35:24 +0200 (Thu, 08 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   A /trunk/src/chrome/browser/resources/net_internals/dnsview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/chrome_browser.gypi

Add the host resolver cache to the new net internals page.

BUG=37421

Review URL: http://codereview.chromium.org/1558027
------------------------------------------------------------------------
r43994 | phajdan.jr@chromium.org | 2010-04-08 21:55:34 +0200 (Thu, 08 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc

Fix build (trivial syntax error).

TBR=vtl

Review URL: http://codereview.chromium.org/1576027
------------------------------------------------------------------------
r43992 | phajdan.jr@chromium.org | 2010-04-08 21:51:12 +0200 (Thu, 08 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc

Do not make the tests fail on failed file deletes.

The checks were added very recently, and apparently can fail sometimes.
Added a TODO to investigate later.

TBR=vtl

Review URL: http://codereview.chromium.org/1585025
------------------------------------------------------------------------
r43990 | mattm@chromium.org | 2010-04-08 21:48:46 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Windows: Fix remove button being enabled when cookies view opens and nothing is selected.

BUG=40813
TEST=manual

Review URL: http://codereview.chromium.org/1560020
------------------------------------------------------------------------
r43989 | atwilson@chromium.org | 2010-04-08 21:42:54 +0200 (Thu, 08 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/test/testing_browser_process.h

This is a new version of the older patch. Main changes include:
1. Rebased to a never Git revision to make things easier to land.
2. Chrome will now preserve the command line switches except for those that are
   blacklisted.
3. Fixed a race condition that would cause the browser to think it didn't exit
   cleanly after it's been restarted.
4. Fixed minor nits and omissions (indentation, etc).

This patch adds a timer which fires every 6 hours and checks whether the
browser is in the "persistent" (background) mode, and whether there's an
update pending restart. If both conditions are true, the browser is
restarted with blacklisted command line keys and all loose values stripped. In order to
restart the browser in the background mode, the --long-lived-extensions
key is also added to the command line.

This change is Windows-only, and it won't become fully functional until
Drew (atwilson) checks in his work that enables Chrome to go into background.

Review URL: http://codereview.chromium.org/1617001
------------------------------------------------------------------------
r43988 | pkasting@chromium.org | 2010-04-08 21:40:13 +0200 (Thu, 08 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Clean up some of the command-initializing code.  No functional change.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1610012
------------------------------------------------------------------------
r43986 | skerner@chromium.org | 2010-04-08 21:21:32 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fix build failure.

TEST=none
TBR=rafaelw
BUG=none

Review URL: http://codereview.chromium.org/1589023
------------------------------------------------------------------------
r43985 | skerner@chromium.org | 2010-04-08 21:06:15 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Support PNG and quality control in chrome.tabs.captureVisibleTab().

BUG=21072
TEST=ExtensionAPIClientTest.CaptureVisibleTab

Review URL: http://codereview.chromium.org/1527015
------------------------------------------------------------------------
r43983 | hclam@chromium.org | 2010-04-08 21:01:38 +0200 (Thu, 08 Apr 2010) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/media/audio/simple_sources.cc
   M /trunk/src/media/audio/simple_sources.h
   M /trunk/src/media/audio/simple_sources_unittest.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc

Flush audio data after seek

There is about 400 to 600 ms of audio that needs to be flushed
after seek, this have a pretty UX effect. This is partially
fixed in this patch by reducing the amount of data down to
about at most 500 ms stored in the hardware buffer.

This patch clears data in the software buffer in the browser
process when seek happens. We could reduce the amount of
hardware buffer to further reduce the amount of lag but that
can be fixed by subsequent patch.

BUG=24150
TEST=audio still works, audio still play after seek
     the playback of old data after seek is substantially
     reduced.

Few changes in this patch:
1. Flush software buffer after seek in browser process
2. Get rid of prerolling, this actually has not effect at all, so getting rid of useless code

Needs to be done after this patch:
1. Further reduce the remaining data after seek and pause
2. Still hit the DCHECK in ClockImpl::Play(), this doesn't seem to be a new problem introduced in this patch

Review URL: http://codereview.chromium.org/1508021
------------------------------------------------------------------------
r43982 | evan@chromium.org | 2010-04-08 20:53:05 +0200 (Thu, 08 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc

gtk: sort languages in translate info by locale name

Since we can no longer rely on the index in the input array, I
added a column to the datastore used by the combo box.

Editorial: you would think it would be appropriate for the
model to sort these in advance, rather than implementing the
sort once per platform, but I am just an observer.

BUG=40251

Review URL: http://codereview.chromium.org/1595011
------------------------------------------------------------------------
r43980 | mattm@chromium.org | 2010-04-08 20:45:08 +0200 (Thu, 08 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Linux: fix crash on incognito opening extensions after reordering non-incognito browser action.

The std::map operator[] inserted default (NULL) pointer on not-found elements which later caused the crash.

BUG=40498
TEST=see bug

Review URL: http://codereview.chromium.org/1517025
------------------------------------------------------------------------
r43979 | mattm@chromium.org | 2010-04-08 20:43:41 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Linux: Fix browser actions overflow menu on incognito windows.

BUG=40757
TEST=drag handle so overflow menu shows (only when it actually should), click on icons from overflow.

Review URL: http://codereview.chromium.org/1539026
------------------------------------------------------------------------
r43977 | estade@chromium.org | 2010-04-08 20:41:11 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: don't show the star or page actions in ShouldOnlyShowLocation situations.

BUG=40204
TEST=manual

Review URL: http://codereview.chromium.org/1549024
------------------------------------------------------------------------
r43976 | estade@chromium.org | 2010-04-08 20:39:52 +0200 (Thu, 08 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h

GTK: slightly change how we display drag images.

We use a popup window for the drag because in many window managers it looks better.

Ideally we would implement the alpha-channel fading that some other WebKit ports use, but gtk_drag_set_icon_* don't seem to support transparency (dragged tabs can be transparent because they use a different approach that avoids this problem, but is more complicated in other ways).

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/1519019
------------------------------------------------------------------------
r43974 | ojan@chromium.org | 2010-04-08 20:23:33 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Revert 43964 - Webkit roll 57171:57214. All the breakages are already fixed in
later revisions. Rolling to this one because I believe 57215 caused
a perf/memory regression and I'd like to be sure.
Review URL: http://codereview.chromium.org/1605018

TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/1629009
------------------------------------------------------------------------
r43972 | pkasting@chromium.org | 2010-04-08 20:13:23 +0200 (Thu, 08 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Make the firstrun bubble point at a better spot now that the location icon has been added.

BUG=27570
TEST=chrome --first-run produces a bubble that points at the text in the address bar.
Review URL: http://codereview.chromium.org/1591024
------------------------------------------------------------------------
r43971 | shess@chromium.org | 2010-04-08 20:10:35 +0200 (Thu, 08 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Location icon in omnibox as drag source.

Wire up location icon to allow dragging if the user click-drags or
click-holds.  Otherwise falls through to the page-info display.

BUG=37865
TEST=When omnibox shows an URL, click-drag the globe initiates an URL drag.
TEST=Drop it in web content.
TEST=Drop it in safari.
TEST=Drop it on bookmark bar.

Review URL: http://codereview.chromium.org/1567023
------------------------------------------------------------------------
r43970 | pkasting@chromium.org | 2010-04-08 20:06:27 +0200 (Thu, 08 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Make the star and page action icons not appear on popup windows.

BUG=40730
TEST=Open a popup window.  There should be no star in the address bar.
Review URL: http://codereview.chromium.org/1520024
------------------------------------------------------------------------
r43967 | oshima@chromium.org | 2010-04-08 19:45:32 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc

ifdef'ed debug only code

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1600015
------------------------------------------------------------------------
r43966 | jochen@chromium.org | 2010-04-08 19:42:47 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/cookie_info_view.cc

Register the cookie info view as listener to the expiry date combobox.

BUG=39066
TEST=manual

Review URL: http://codereview.chromium.org/1542021
------------------------------------------------------------------------
r43964 | ojan@chromium.org | 2010-04-08 19:30:00 +0200 (Thu, 08 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Webkit roll 57171:57214. All the breakages are already fixed in
later revisions. Rolling to this one because I believe 57215 caused
a perf/memory regression and I'd like to be sure.
Review URL: http://codereview.chromium.org/1605018
------------------------------------------------------------------------
r43962 | creis@chromium.org | 2010-04-08 19:26:39 +0200 (Thu, 08 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Adds a safety check for DOM UI renderers.

We should not be passing web URLs to DOM UI renderers.  This CL adds a
check to ensure that we only navigate to DOM UI URLs in such renderers.

BUG=40575
TEST=none

Review URL: http://codereview.chromium.org/1549027
------------------------------------------------------------------------
r43955 | joth@chromium.org | 2010-04-08 19:01:09 +0200 (Thu, 08 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc

Landing on behald of tfarina. Original review: http://codereview.chromium.org/1593008/show

geolocation: Implement a TODO to share a function with other copies. 

Instead, use the function from base/win_util.h that does the same thing. Also do some cleanups. 

BUG=None 
TEST=compiles
TBR=thiago.farina@gmail.com


------------------------------------------------------------------------
r43954 | sky@chromium.org | 2010-04-08 18:57:03 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes bug in TabStrip where dragging tab out then back in rapidly
could cause the tabstrip to get out of sync with the model.

BUG=40714
TEST=thorougly test dragging tabs around in tab strip.

Review URL: http://codereview.chromium.org/1556020
------------------------------------------------------------------------
r43951 | viettrungluu@chromium.org | 2010-04-08 18:16:55 +0200 (Thu, 08 Apr 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Revert 43950 - Revert 43931  [GTTF] Clean up browser tests:
[original revert broke compile; will disable tests in another CL instead]

 use more ui_test_utils functions to simplify the code
 expose more consistent and powerful utilities in ui_test_utils
 minor style improvements
 move some tests from DISABLED to FLAKY so we don't lose coverage
 remove redundant timeouts
 check more return values

TEST=browser_tests
BUG=none

Review URL: http://codereview.chromium.org/1571002

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1520026

TBR=viettrungluu@chromium.org, phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1518020
------------------------------------------------------------------------
r43950 | viettrungluu@chromium.org | 2010-04-08 18:07:16 +0200 (Thu, 08 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Revert 43931 - [GTTF] Clean up browser tests:

 use more ui_test_utils functions to simplify the code
 expose more consistent and powerful utilities in ui_test_utils
 minor style improvements
 move some tests from DISABLED to FLAKY so we don't lose coverage
 remove redundant timeouts
 check more return values

TEST=browser_tests
BUG=none

Review URL: http://codereview.chromium.org/1571002

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1520026
------------------------------------------------------------------------
r43949 | maruel@chromium.org | 2010-04-08 17:52:45 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/memory_details_mac.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/test/chrome_process_util.cc
   M /trunk/src/chrome/test/chrome_process_util.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome_frame/test_utils.cc

Move ProcessEntry and IoCounters inside namespace base.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1599007
------------------------------------------------------------------------
r43947 | cbentzel@chromium.org | 2010-04-08 17:35:13 +0200 (Thu, 08 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/base/address_family.h
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_cache.h
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/host_resolver_proc.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc

HostResolver now adds AI_CANONNAME to the hint flags if a requester needs the information.

Requests which want the canonical name should be treated differently from requests that do not for the same host in both the HostCache as well as in the HostResolver when combining multiple outstanding requests into a job.

The motivation for this is that Kerberos SPN's for a web server are typically generated using the canonical name of the server rather than a DNS alias (both Firefox and IE have this behavior).

(note: I had to revert http://codereview.chromium.org/1566012/show because net_unittests were crashing/hanging on the main buildbot, even though they weren't on the trybots. Trying to figure out why).
BUG=29862
TEST=net_unittests

Review URL: http://codereview.chromium.org/1593015
------------------------------------------------------------------------
r43946 | tonyg@chromium.org | 2010-04-08 17:29:17 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h

Minor cleanup, factor out a bit of duplicate code in BufferedResourceHandler.

This is in preparation for a fix for crbug.com/31266.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1530024
------------------------------------------------------------------------
r43945 | joth@chromium.org | 2010-04-08 14:54:02 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc

Make the prefs reading more robust to poorly formed URLs

BUG=39685
TEST=GeolocationContentSettingsMapTests.IgnoreInvalidURLsInPrefs

Review URL: http://codereview.chromium.org/1566027
------------------------------------------------------------------------
r43943 | bulach@chromium.org | 2010-04-08 14:09:36 +0200 (Thu, 08 Apr 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Adds geolocation_permission_context_unittest.cc
(most of this code is already covered by the more complex geolocation_browsertest.cc which traverses far more layers. this is a more specific unittest).

This fixes the valgrind issues with the previous attempt http://codereview.chromium.org/1596012/show
(need to call InfoBarClosed() to actually destroy the infobar).

TEST=geolocation_permission_context_unittest.cc
BUG=40699

Review URL: http://codereview.chromium.org/1560017
------------------------------------------------------------------------
r43940 | hbono@chromium.org | 2010-04-08 12:40:26 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

A quick fix for Issue 32024.
This change just prevents sending keyboard events when we type a 'Fn' key or a 'NumLock' key. This code is mostly copied from -[WebHTMLView flagsChanged:] of Safari.

BUG=32024
TEST=Open <http://www.danilatos.com/event-test/ExperimentTest.html> on Mac Chrome, press a 'Fn' key, and verify that Chrome doesn't send any events.
Review URL: http://codereview.chromium.org/1622006
------------------------------------------------------------------------
r43939 | jeremy@chromium.org | 2010-04-08 12:37:45 +0200 (Thu, 08 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h

Update Mac translate infobars

Since the translate infobars where first implemented for the Mac, the underlying code and UI design has evolved quite a bit, this CL supdates the Mac code to match other platforms.

There are still some missing pieces, but I'll follow up on thos in future CLs.

Notable changes:
* Use new translate states internally and match UI on other platforms.
* Gray background color rather than blue.
* Options menu now populated correctly.
* Remove wierd gap between label and "from language" popup  menu.
* Updated unit tests to match.

BUG=39627,39813,39807,39810,39822
TEST=1.Options menu should no longer be blank. 2. Infobar background should be gray 3. Translate infobar should display errors when translation fails. 4. After clicking "translate" for the first time, the "Show original" button should

Review URL: http://codereview.chromium.org/1578016
------------------------------------------------------------------------
r43937 | yusukes@google.com | 2010-04-08 11:35:40 +0200 (Thu, 08 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h

chromeos_language cleanup (Chrome part).

- Stopped using deprecated APIs: GetSupportedLanguages, GetActiveLanguages, ChangeLanguage, and SetLanguageActivated.
- Use new APIs insted: GetSupportedInputMethods, GetActiveInputMethods, ChangeInputMethod, and SetInputMethodActivated
- Use "InputMethodDescriptor(s)" instead of "InputLanguage(List)"
- Stopped using the word "IME" as much as possible. Use "input method" instead.
- Removed all LANGUAGE_CATEGORY_XXXs.

This change depends on the cros DEPS roll: http://codereview.chromium.org/1593014

BUG=crosbug.com/2403
TEST=ran browser_tests

Review URL: http://codereview.chromium.org/1540019
------------------------------------------------------------------------
r43936 | jochen@chromium.org | 2010-04-08 11:18:29 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/content_exceptions_table_model.h
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Implement patterns for content setting exceptions.

BUG=37394
TEST=unit_tests + manual

Review URL: http://codereview.chromium.org/1567010
------------------------------------------------------------------------
r43934 | tony@chromium.org | 2010-04-08 10:00:02 +0200 (Thu, 08 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc

Browser and unit test cases for patch submitted for Issue 23584 under
http://codereview.chromium.org/660264.

BUG=23584
TEST=covered by unit tests and browser tests

Original patch by Chamal De Silva <chamal.desilva@gmail.com> at
http://codereview.chromium.org/669262/show

Review URL: http://codereview.chromium.org/1562017
------------------------------------------------------------------------
r43933 | jochen@chromium.org | 2010-04-08 09:24:19 +0200 (Thu, 08 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h

Revert 43890 - Use ScopedPrefUpdate to correctly send out notifications when the host
content settnigs are update.

BUG=none
TEST=HostContentSettingsMapTest

Review URL: http://codereview.chromium.org/1606016

TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/1528024
------------------------------------------------------------------------
r43932 | phajdan.jr@chromium.org | 2010-04-08 09:15:16 +0200 (Thu, 08 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/nacl/nacl_test.cc
   M /trunk/src/chrome/test/nacl/nacl_test.h
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/ui/npapi_test_helper.h
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/chrome/test/ui/pepper_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

[GTTF] Tests cleanup:

- use timeouts correctly
- use more automation methods to make test code more clear
- use more reliable ways of waiting
- remove unnecessary automation calls

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1553016
------------------------------------------------------------------------
r43931 | phajdan.jr@chromium.org | 2010-04-08 08:41:43 +0200 (Thu, 08 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

[GTTF] Clean up browser tests:

- use more ui_test_utils functions to simplify the code
- expose more consistent and powerful utilities in ui_test_utils
- minor style improvements
- move some tests from DISABLED to FLAKY so we don't lose coverage
- remove redundant timeouts
- check more return values

TEST=browser_tests
BUG=none

Review URL: http://codereview.chromium.org/1571002
------------------------------------------------------------------------
r43925 | dcheng@chromium.org | 2010-04-08 07:09:49 +0200 (Thu, 08 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc

Return an approximately correct drop effect from WebDragTarget::OnDrop.

This isn't actually guaranteed to be correct, since it's the cached value from previous dragenter / dragover results, but hopefully it's somewhat correct part of the time. To prevent potential data loss, all moves are mapped to copies. A future improvement might to fire a ViewHostMsg_UpdateDragCursor after the renderer processes the drop event.

BUG=39399
TEST=Manual testing using the attached test case on the bug.

Review URL: http://codereview.chromium.org/1572027
------------------------------------------------------------------------
r43923 | georgey@chromium.org | 2010-04-08 06:52:02 +0200 (Thu, 08 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download.cc

Possible fix for 40234 + changed one of the DCHECK to CHECK
BUG=40234
TEST=Should not crash
Review URL: http://codereview.chromium.org/1594019
------------------------------------------------------------------------
r43917 | oshima@chromium.org | 2010-04-08 04:26:26 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

TestResoruceContentLength is flaky on linux_views,chromeos

BUG=40764
TEST=interactive_ui_tests on linux_views/chromeos should stay green.
TBR=pfeldman@chromium.org

Review URL: http://codereview.chromium.org/1553017
------------------------------------------------------------------------
r43916 | jhawkins@chromium.org | 2010-04-08 04:11:36 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc
   A /trunk/src/chrome/browser/autofill/name_field_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill: Only match the exact string 'mi' when matching a middle initial field.

BUG=38325
TEST=NameFieldTest.FirstMiddleLast

Review URL: http://codereview.chromium.org/1530025
------------------------------------------------------------------------
r43909 | oshima@chromium.org | 2010-04-08 03:49:30 +0200 (Thu, 08 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/common/notification_type.h

notification panel fix on chromeos.
 * Changed to use NotificationService instead of delegate to notify the panel state change.
 * Cleanup the client event signal handler so that event won't get fired on closed instance.
 * Added chromeos mode. Under ChromeOS, it will wait a message from WindowManager that tells the state of panel.
 * The StateTransition2 test relies on the fact that Panel state change takes longer than stale timeout, so we can't use zero stale timeout. Changed to explicitly update the stale state.

BUG=http://crosbug.com/2346
TEST=NotificationPanelTest.TestStateTransition2 should pass on chromeos device.

Review URL: http://codereview.chromium.org/1523012
------------------------------------------------------------------------
r43906 | jhawkins@chromium.org | 2010-04-08 03:20:13 +0200 (Thu, 08 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager_unittest.cc

AutoFill: A few fixes.
* Match both the name and the label when sending FormData values for the renderer to fill.
* Use a vector of bools to indicate which WebFormControlElements are extracted instead of matching on element name, which is not guaranteed to be unique.

BUG=38325
TEST=FormManagerTest.InferredLabelsWithSameName

Review URL: http://codereview.chromium.org/1558029
------------------------------------------------------------------------
r43905 | eroman@chromium.org | 2010-04-08 03:16:12 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/detailsview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/browser/resources/net_internals/tabswitcherview.js

Make it possible to switch between views of the new net-internals page by using #fragments in the URL.
(This way you can link to the DNS tab for example).

BUG=37421

Review URL: http://codereview.chromium.org/1525016
------------------------------------------------------------------------
r43903 | feldstein@chromium.org | 2010-04-08 03:05:08 +0200 (Thu, 08 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Reorganize the BMM Menus

Removed Tools
Put Import/Export at the bottom of "organize"
Moved Add Page/Folder to top of "organize"
Moved Delete into the group with cut/copy/paste

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1559020
------------------------------------------------------------------------
r43901 | albertb@chromium.org | 2010-04-08 02:53:04 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h

Use ScopedPrefUpdate to correctly send out notifications when Geolocation settings are updated.

BUG=none
TEST=GeolocationContentSettingsTest

Review URL: http://codereview.chromium.org/1570015
------------------------------------------------------------------------
r43899 | jrg@chromium.org | 2010-04-08 02:27:54 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

When doing bookmark sync and nodes are deleted, close any open bookmark
bar folders.

BUG=http://crbug.com/40430
TEST=see bug

Review URL: http://codereview.chromium.org/1613006
------------------------------------------------------------------------
r43898 | dantasse@chromium.org | 2010-04-08 02:03:07 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc

Turn on theme sync by default.

BUG:none
TEST: click the "customize sync" button in the sync setup wizard or in options->personal stuff.  There should be a Themes checkbox.  Theme sync still has a bug (see http://codereview.chromium.org/1633002/show) but will be fixed soon.

Review URL: http://codereview.chromium.org/1508025
------------------------------------------------------------------------
r43897 | jcivelli@google.com | 2010-04-08 01:48:49 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

The autofill popups were activated causing an assert on Mac.

BUG=40739
TEST=See steps in bug.

Review URL: http://codereview.chromium.org/1600014
------------------------------------------------------------------------
r43895 | zork@chromium.org | 2010-04-08 01:39:08 +0200 (Thu, 08 Apr 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc

TBR: chron@chromium.org
------------------------------------------------------------------------
r43894 | skrul@chromium.org | 2010-04-08 01:31:58 +0200 (Thu, 08 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.h

Get translate prefs syncing
Add a ScopedPrefUpdate in various places as well as fix a bug that prevented the live update of the main translate pref in the options dialog.

Review URL: http://codereview.chromium.org/1547025
------------------------------------------------------------------------
r43893 | estade@chromium.org | 2010-04-08 01:10:30 +0200 (Thu, 08 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

GTK: speculative fix for browser test crashes on buildbot.

Disconnect some more signal handlers on shutdown.

BUG=40735
TEST=watch waterfall

Review URL: http://codereview.chromium.org/1542019
------------------------------------------------------------------------
r43892 | georgey@chromium.org | 2010-04-08 01:04:04 +0200 (Thu, 08 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Added "Learn More" link to autofill on Windows.
TEST=Should appear on the bottom left in autofill dialog and should work when clicked :)
BUG=none
Review URL: http://codereview.chromium.org/1551020
------------------------------------------------------------------------
r43890 | albertb@chromium.org | 2010-04-08 00:45:28 +0200 (Thu, 08 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h

Use ScopedPrefUpdate to correctly send out notifications when the host
content settnigs are update.

BUG=none
TEST=HostContentSettingsMapTest

Review URL: http://codereview.chromium.org/1606016
------------------------------------------------------------------------
r43889 | zork@chromium.org | 2010-04-08 00:42:48 +0200 (Thu, 08 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc

Send a notification when we connect to p2p

BUG=38563
TEST=Follow the instructions on the bug.

Review URL: http://codereview.chromium.org/1545024
------------------------------------------------------------------------
r43886 | akalin@chromium.org | 2010-04-08 00:16:00 +0200 (Thu, 08 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_cppsafe.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc

Integrated customize sync dialog with sync setup wizard on OS X.

Changed ShowHtmlDialog() on OS X to return the created window.

BUG=34209
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43796

Review URL: http://codereview.chromium.org/1535018
------------------------------------------------------------------------
r43883 | estade@chromium.org | 2010-04-07 23:38:44 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/app/gtk_signal.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

GTK: add more general gtk_signal macros.

Convert ACEViewGtk to use the macros.

BUG=none
TEST=compile + click around

Review URL: http://codereview.chromium.org/1591021
------------------------------------------------------------------------
r43881 | evan@chromium.org | 2010-04-07 23:22:41 +0200 (Wed, 07 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

linux: use white-on-blue for selection color in classic theme mode

This is closer to what Windows does, and makes the text much more readable.

BUG=40135

Review URL: http://codereview.chromium.org/1595015
------------------------------------------------------------------------
r43880 | jhawkins@chromium.org | 2010-04-07 23:17:03 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/contact_info.cc

AutoFill: Handle NAME_MIDDLE_INITIAL when setting field info.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1584017
------------------------------------------------------------------------
r43879 | brettw@chromium.org | 2010-04-07 23:08:51 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc

Set the site instance in all cases when we start a new load. If you navigate away from the new tab page (or another DOMUI page) before the DOMUI page commits, the subsequent page will inherit the SiteInstance of the original page.

BUG=12718,40575
TEST=included unit test
Review URL: http://codereview.chromium.org/1519025
------------------------------------------------------------------------
r43876 | estade@chromium.org | 2010-04-07 23:00:33 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   D /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   D /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h
   A /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.cc (from /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc:43766)
   A /trunk/src/chrome/browser/gtk/content_setting_bubble_gtk.h (from /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h:43766)
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.h
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTK: position info bubbles relative to a subwidget, rather than the toplevel window.

(Client code can still use a toplevel widget as the anchor.)

BUG=40068
TEST=tried all popups in LTR and RTL

Review URL: http://codereview.chromium.org/1575019
------------------------------------------------------------------------
r43875 | rohitrao@chromium.org | 2010-04-07 22:59:00 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.h
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm

[Mac] Fix themes drawing code to properly position the theme in fullscreen windows and to properly blend transparent themes with black.  Also adds a way to pass an offset in to the theme drawing code.

BUG=40213
TEST=Android robot theme should draw properly, not be pure black.
Review URL: http://codereview.chromium.org/1527020
------------------------------------------------------------------------
r43872 | georgey@chromium.org | 2010-04-07 22:36:23 +0200 (Wed, 07 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   A /trunk/src/chrome/browser/views/list_background.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

CL #1530013 by Thiago Farina <thiago.farina@gmail.com>
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1542015
------------------------------------------------------------------------
r43871 | thestig@chromium.org | 2010-04-07 22:31:24 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/renderer/about_handler.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc

Use chrome::kAboutCrashURL in a few most places.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1612008
------------------------------------------------------------------------
r43870 | skrul@chromium.org | 2010-04-07 22:17:53 +0200 (Wed, 07 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/language_order_table_model.cc

Enable live update of language list
The old way this was written was trying to re-use the Add() method to "merge" the new langauge string with the existing list.  But in the case when a syncd browser sends a re-ordering or delete change, this would not detect the change and never fire the observer.  I changed this to simply make SetAcceptLanguagesString replace the current langages_ list.

BUG=40486
TEST=Language lists should stay in sync between two browsers.

Review URL: http://codereview.chromium.org/1566024
------------------------------------------------------------------------
r43869 | zork@google.com | 2010-04-07 22:13:47 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc

Fix svn properties on typed_url*

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1625005
------------------------------------------------------------------------
r43868 | johnnyg@chromium.org | 2010-04-07 22:00:46 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h

notifications: Simplify the callback handler for the close button event.

BUG=None
TEST=compiles and the close button still works as before

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1575018
------------------------------------------------------------------------
r43866 | johnnyg@chromium.org | 2010-04-07 21:55:00 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h

notifications: No need to override no pure virtual functions.

BUG=None
TEST=compiles and the menu still works as before.
Review URL: http://codereview.chromium.org/1601007
------------------------------------------------------------------------
r43864 | sky@chromium.org | 2010-04-07 21:27:24 +0200 (Wed, 07 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/slide_animation_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/views/animation/bounds_animator.cc
   M /trunk/src/views/animation/bounds_animator.h
   A /trunk/src/views/animation/bounds_animator_unittest.cc

Tweaks to BoundsAnimator/SlideAnimation and TabStrip:
. Adds unit test for BoundsAnimator and SlideAnimation.
. Fixes leak in BoundsAnimator.
. Fixes possibility of deleting delegate twice.
. Makes sure delegate is notified when new animation is set for view.
. Fixes crashes in TabStrip that resulted from dragging a tab back in.

BUG=40475
TEST=make sure dragging tabs out/in to a tabstrip doesn't cause
  problems.

Review URL: http://codereview.chromium.org/1585020
------------------------------------------------------------------------
r43863 | mpcomplete@chromium.org | 2010-04-07 21:26:41 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/plugin_service.cc

Revert "Temporary CL to debug test failure on the buildbot."

This reverts commit 5c19b0409f047111de901755b5670efa5a2d4e8c.

Review URL: http://codereview.chromium.org/1517020
------------------------------------------------------------------------
r43862 | mattm@chromium.org | 2010-04-07 21:16:06 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc

gtk: Avoid duplicating functions in anonymous namespaces by moving them to gtk_util.h

BUG=None
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1610003
------------------------------------------------------------------------
r43861 | mpcomplete@chromium.org | 2010-04-07 21:10:09 +0200 (Wed, 07 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/plugin_service.cc

Temporary CL to debug test failure on the buildbot.

Review URL: http://codereview.chromium.org/1545023
------------------------------------------------------------------------
r43857 | johnnyg@chromium.org | 2010-04-07 20:49:03 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc

Only allow notifications to grow in size (as the content size is determined).  Mac OS sometimes rapidly reports two alternating sizes, causing the animations to seize up and flicker.

BUG=38083
TEST=visit http://www/~johnnyg/38083.html, or otherwise invoke the javascript in the bug.  there should be no animation problems.

Review URL: http://codereview.chromium.org/1589020
------------------------------------------------------------------------
r43853 | evan@chromium.org | 2010-04-07 20:01:48 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h

gtk: Use the new callback macros in more places.

BUG=None
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1564011
------------------------------------------------------------------------
r43849 | bulach@chromium.org | 2010-04-07 19:34:16 +0200 (Wed, 07 Apr 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert 43836 - Adds geolocation_permission_context_unittest.cc
(most of this code is already covered by the more complex geolocation_browsertest.cc which traverses far more layers. this is a more specific unittest).

TEST=geolocation_permission_context_unittest.cc
Valgrind error: http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/3857/steps/valgrind%20test:%20unit/logs/stdio
Review URL: http://codereview.chromium.org/1596012

TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/1629006
------------------------------------------------------------------------
r43848 | dhollowa@chromium.org | 2010-04-07 19:33:10 +0200 (Wed, 07 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc

AutoFill credit card filling when initiated from an address fill.

When user initiates AutoFill for an address we also fill in credit card information
from the designated default credit card if one exists.

BUG=38320
TEST=PersonalDataManagerTest, manual testing with cc.html (attached).

Review URL: http://codereview.chromium.org/1527018
------------------------------------------------------------------------
r43846 | oshima@chromium.org | 2010-04-07 19:13:22 +0200 (Wed, 07 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc

Fix initialization bug in BalloonViewHsotView.
 A view and its renderer in chromeos never get initialized because of this.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1582015
------------------------------------------------------------------------
r43845 | jcivelli@google.com | 2010-04-07 19:03:12 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_host_mac.h
   M /trunk/src/chrome/browser/extensions/extension_host_mac.mm
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Adding the new WebPopupType to the RenderWidget creation.

BUG=None
TEST=Tests that all popups (select popup, autofill, browser actions, bookmark bubble...)
     work as expected and get the focus correctly.
Review URL: http://codereview.chromium.org/1523013
------------------------------------------------------------------------
r43844 | joth@chromium.org | 2010-04-07 18:55:21 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc

Change the Clear these settings... link to be a reload page hint message when a clear is pending.
Also adds some unit tests for the geolocation bubble, and refactors the tests a bit to make this new test neater.

BUG=40263
TEST=a) unit_tests --gtest_filter=ContentSettingBubbleModelTest*   b) open a page using geolocation and test different combinations of global permission & exceptions for that page.


Review URL: http://codereview.chromium.org/1605016
------------------------------------------------------------------------
r43840 | satorux@chromium.org | 2010-04-07 17:51:11 +0200 (Wed, 07 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

First cut at adding support for keyboard layout switching.

With this change, users will be able to use non-US keyboard layouts
by adding languages from the "Languages and Input" dialog.
At this moment, French is only tested.

TEST=manually confirmed that I can change the keyboard layout to French from the language selector, as well as IBus's "Next input method" hotkey.
BUG=crosbug.com/967

Review URL: http://codereview.chromium.org/1524017
------------------------------------------------------------------------
r43837 | denisromanov@chromium.org | 2010-04-07 17:38:16 +0200 (Wed, 07 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/mock_update_screen.h
   A /trunk/src/chrome/browser/chromeos/login/update_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Refactored update view to separate update UI and logic between view class (UI) and screen class (logic).
BUG=37070
TEST=Make out/Debug/chrome. Run chrome --login-manager --login-screen=update. Press escape. Update should cancel. On the actual hardware when connected to corpnet, update should succeed and proceed to the login screen.
Review URL: http://codereview.chromium.org/1591015
------------------------------------------------------------------------
r43836 | bulach@chromium.org | 2010-04-07 17:21:56 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Adds geolocation_permission_context_unittest.cc
(most of this code is already covered by the more complex geolocation_browsertest.cc which traverses far more layers. this is a more specific unittest).

TEST=geolocation_permission_context_unittest.cc

Review URL: http://codereview.chromium.org/1596012
------------------------------------------------------------------------
r43835 | satorux@chromium.org | 2010-04-07 16:57:52 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   A /trunk/src/chrome/browser/chromeos/cros/language_library_test.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc
   M /trunk/src/chrome/chrome_tests.gypi

Move NormalizeLanguageCode() and IsKeyboardLayout() to LanguageLibrary.

So that we can use these functions outside of LanguageConfigView.

TEST=unit_tests
BUG=none

Review URL: http://codereview.chromium.org/1562015
------------------------------------------------------------------------
r43833 | cbentzel@chromium.org | 2010-04-07 16:41:40 +0200 (Wed, 07 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/base/address_family.h
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_cache.h
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/host_resolver_proc.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc

Revert 43826 - HostResolver now adds AI_CANONNAME to the hint flags if a requester needs the information.

Requests which want the canonical name should be treated differently from requests that do not for the same host in both the HostCache as well as in the HostResolver when combining multiple outstanding requests into a job.

The motivation for this is that Kerberos SPN's for a web server are typically generated using the canonical name of the server rather than a DNS alias (both Firefox and IE have this behavior).

BUG=29862
TEST=net_unittests

Review URL: http://codereview.chromium.org/1566012

TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/1629005
------------------------------------------------------------------------
r43826 | cbentzel@chromium.org | 2010-04-07 15:34:40 +0200 (Wed, 07 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/base/address_family.h
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_cache.h
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/host_resolver_proc.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc

HostResolver now adds AI_CANONNAME to the hint flags if a requester needs the information.

Requests which want the canonical name should be treated differently from requests that do not for the same host in both the HostCache as well as in the HostResolver when combining multiple outstanding requests into a job.

The motivation for this is that Kerberos SPN's for a web server are typically generated using the canonical name of the server rather than a DNS alias (both Firefox and IE have this behavior).

BUG=29862
TEST=net_unittests

Review URL: http://codereview.chromium.org/1566012
------------------------------------------------------------------------
r43823 | pfeldman@chromium.org | 2010-04-07 13:02:05 +0200 (Wed, 07 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h

Dev Tools: show console when inspector is opened in docked mode.
BUG=40453

Review URL: http://codereview.chromium.org/1553013
------------------------------------------------------------------------
r43821 | eroman@chromium.org | 2010-04-07 12:32:05 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc

Add some temporary instrumentation to help track down a crasher.

BUG=40447
TBR=huanr
Review URL: http://codereview.chromium.org/1585019
------------------------------------------------------------------------
r43820 | satorux@chromium.org | 2010-04-07 11:42:59 +0200 (Wed, 07 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Clean up code in LanguageConfigView.

The changes were mostly done in a mechanical way
- language_id -> input_method_id (language_id was so misleading)
- LanguageID -> InputMethodId
- InputLanguage -> InputMethod

TEST=manually
BUG=crosbug.com/2403

Review URL: http://codereview.chromium.org/1629003
------------------------------------------------------------------------
r43819 | ukai@chromium.org | 2010-04-07 10:37:52 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc

Run websocket experiment for new protocol

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1618003
------------------------------------------------------------------------
r43818 | satorux@chromium.org | 2010-04-07 10:07:48 +0200 (Wed, 07 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Use radio buttons for input methods, rather than checkboxes.

This means we'll have one active input method per one language,
and things will be simpler. We could revisit this if the restriction
turns out to be a problem.

TEST=manually
BUG=crosbug.com/2432

Review URL: http://codereview.chromium.org/1630007
------------------------------------------------------------------------
r43814 | satorux@chromium.org | 2010-04-07 09:12:38 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Fix a minor bug that allowed users to remove English from the language config.

For now, we don't allow English to be removed.

BUG=crosbug.com/2430
TEST=manually

Review URL: http://codereview.chromium.org/1595012
------------------------------------------------------------------------
r43804 | satorux@chromium.org | 2010-04-07 04:49:18 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc

Add LanguageconfigView::IsKeyboardLayout()

TEST=wrote unit tests
BUG=none

Review URL: http://codereview.chromium.org/1519024
------------------------------------------------------------------------
r43803 | jhawkins@chromium.org | 2010-04-07 04:36:43 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc

gtk: Add the 'Learn more' link to the AutoFill dialog.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1622009
------------------------------------------------------------------------
r43801 | mattm@chromium.org | 2010-04-07 04:21:15 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_mac.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc

Linux: fix startup race between creating the SingletonLock and listening on SingletonSocket.

BUG=39922
TEST=see bug

Review URL: http://codereview.chromium.org/1612006
------------------------------------------------------------------------
r43799 | akalin@chromium.org | 2010-04-07 03:58:11 +0200 (Wed, 07 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_cppsafe.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h

Revert 43796 - Integrated customize sync dialog with sync setup wizard on OS X.

Changed ShowHtmlDialog() on OS X to return the created window.

BUG=34209
TEST=manual

Review URL: http://codereview.chromium.org/1535018

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/1553014
------------------------------------------------------------------------
r43796 | akalin@chromium.org | 2010-04-07 03:42:06 +0200 (Wed, 07 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_cppsafe.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h

Integrated customize sync dialog with sync setup wizard on OS X.

Changed ShowHtmlDialog() on OS X to return the created window.

BUG=34209
TEST=manual

Review URL: http://codereview.chromium.org/1535018
------------------------------------------------------------------------
r43795 | jhawkins@chromium.org | 2010-04-07 03:16:00 +0200 (Wed, 07 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.h

AutoFill: Add a 'Learn more' link to the AutoFill InfoBar that contains a link
to the soon-to-be-created help page for AutoFill.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1574018
------------------------------------------------------------------------
r43790 | tony@chromium.org | 2010-04-07 02:44:19 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Only place popup windows if the position is not 0,0.

BUG=36650

Review URL: http://codereview.chromium.org/1520019
------------------------------------------------------------------------
r43789 | jrg@chromium.org | 2010-04-07 02:44:13 +0200 (Wed, 07 Apr 2010) | 50 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Experimental change to fix perf bot.
Full history:

------------------------------
1st CL intended to fix a problem with a failing pyauto test on ChromeOS.
http://codereview.chromium.org/1461001
browser_view.cc:
bool BrowserView::IsBookmarkBarVisible()
  active_bookmark_bar_->GetPreferredSize().height() != 0); -->
  browser_->profile()->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar);
----------
That broke NTP bookmark bar.  Fixed like this:
http://codereview.chromium.org/1594009
browser_view_layout.cc:
int BrowserViewLayout::LayoutBookmarkBar(int top) {
   if (!browser_view_->IsBookmarkBarVisible()) { -->

   if (!browser_view_->IsBookmarkBarVisible() &&
   !active_bookmark_bar_->OnNewTabPage()) {
----------
Caused perf regression:
Reverted with
http://codereview.chromium.org/1539017
----------
Fixed a different way
http://codereview.chromium.org/1540015
browser_view.cc:
   browser_->profile()->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar);   ->
   active_bookmark_bar_->GetPreferredSize().height() != 0);
(revert 1st CL so test broken again)
automation_provider.cc:
   *visible = browser->window()->IsBookmarkBarVisible(); -->
    *visible = browser->profile()->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar);
----------
ALSO a perf regression (duh; is same path for automation provider).
So made it ChromeOS only:
http://codereview.chromium.org/1602008
#if defined(TOOLKIT_VIEWS) && defined(OS_LINUX)
...
#endif
----------
But didn't fix perf????
Making that #if 0 to see if XP perf fixes.
It'll break pyauto but too bad for now I guess.





Review URL: http://codereview.chromium.org/1606013
------------------------------------------------------------------------
r43788 | pkasting@chromium.org | 2010-04-07 02:32:06 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Do not enable the home button by default on new installs.  This doesn't affect the default home page.

BUG=27570
TEST=A new install of Chrome should not have a home button on first run.
Review URL: http://codereview.chromium.org/1519023
------------------------------------------------------------------------
r43787 | pkasting@chromium.org | 2010-04-07 02:27:19 +0200 (Wed, 07 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Allow location icon to be dragged & dropped.  This also fixes all location bar icons that trigger on mouseup to only do so if the user is still pointing at the icon.

BUG=27570
TEST=Load a webpage, drag the location icon to the desktop; dropping it should create a link.
Review URL: http://codereview.chromium.org/1630003
------------------------------------------------------------------------
r43786 | evan@chromium.org | 2010-04-07 02:27:06 +0200 (Wed, 07 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

linux: explicitly unhighlight buttons before disabling

If your mouse is hovering the back button when the button is disabled
(i.e. you click back and it takes some time for the navigate to go
through), when the button is re-enabled GTK restores the highlighted
state to the button.

I reproduced this in a very simplified naive app on the bug and had
the same result, so I think this workaround is ok.

BUG=13729
TEST=do the actions listed in the bug

Review URL: http://codereview.chromium.org/1521016
------------------------------------------------------------------------
r43785 | tim@chromium.org | 2010-04-07 02:26:46 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Make the Autofill glue components capable of handling both types based on the NotificationType (for chrome -> sync) and the existence of certain AutofillSpecifics sub messages (for sync -> chrome).

Handle duplicate chrome profile labels by generating a unique label using current time (happens during association as well as change processing).

Handle relabelling by Remove/Add of the sync node.
Review URL: http://codereview.chromium.org/1541005
------------------------------------------------------------------------
r43783 | mrossetti@chromium.org | 2010-04-07 02:01:51 +0200 (Wed, 07 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

REVISION BACKED OUT

Revert 43779 - linux: explicitly unhighlight buttons before disabling

If your mouse is hovering the back button when the button is disabled
(i.e. you click back and it takes some time for the navigate to go
through), when the button is reenabled GTK restores the highlighted
state to the button.

I reproduced this in a very simplified naive app on the bug and had
the same result, so I think this workaround is ok.

BUG=13729
TEST=do the actions listed in the bug

Review URL: http://codereview.chromium.org/1521016

TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/1599021
------------------------------------------------------------------------
r43782 | asargent@chromium.org | 2010-04-07 01:33:04 +0200 (Wed, 07 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   A /trunk/src/chrome/browser/extensions/extension_prefs_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/chrome_tests.gypi

Fix errors in ExtensionPrefs with storing the blacklist last ping day.


This moves where we were storing the blacklist last ping day so that we aren't
storing an invalid extension id in the prefs, and adds code to keep invalid ids
from being stored. It also removes some warnings in cases that aren't errors, 
and finally adds  some unit tests for extension_prefs to try and keep similar 
problems from happening in the future.

BUG=40017
TEST=Should not get any DCHECK failures in Debug builds when you do an
extension update manually (via the chrome://extensions page) and then restart
the browser.


Review URL: http://codereview.chromium.org/1596008
------------------------------------------------------------------------
r43781 | avi@chromium.org | 2010-04-07 01:25:41 +0200 (Wed, 07 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Make sure to draw the overlay image even if it is derived.

BUG=http://crbug.com/40592
TEST=as in bug

Review URL: http://codereview.chromium.org/1606015
------------------------------------------------------------------------
r43779 | evan@chromium.org | 2010-04-07 01:07:23 +0200 (Wed, 07 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

linux: explicitly unhighlight buttons before disabling

If your mouse is hovering the back button when the button is disabled
(i.e. you click back and it takes some time for the navigate to go
through), when the button is re-enabled GTK restores the highlighted
state to the button.

I reproduced this in a very simplified naive app on the bug and had
the same result, so I think this workaround is ok.

BUG=13729
TEST=do the actions listed in the bug

Review URL: http://codereview.chromium.org/1521016
------------------------------------------------------------------------
r43775 | akalin@chromium.org | 2010-04-07 00:49:47 +0200 (Wed, 07 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/app/nibs/SyncCustomize.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/sync_customize_controller.h
   A /trunk/src/chrome/browser/cocoa/sync_customize_controller.mm
   A /trunk/src/chrome/browser/cocoa/sync_customize_controller_cppsafe.h
   A /trunk/src/chrome/browser/cocoa/sync_customize_controller_unittest.mm
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implemented customize sync dialog for OS X (except for integration
with the Sync Setup Wizard).

Added "Customize..." button in Sync group of "Personal Stuff" in Preferences. (Preferences.xib)

Added new customize sync dialog (SyncCustomize.xib) called by button above.

BUG=34209
TEST=manual

Review URL: http://codereview.chromium.org/1525007
------------------------------------------------------------------------
r43774 | sky@chromium.org | 2010-04-07 00:38:08 +0200 (Wed, 07 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h

Lands http://codereview.chromium.org/1543007 for Thiago:

views: Disable the "Import" button on Import Bookmarks dialog if there
is no checkbox checked. 

BUG=30401
TEST=open Import Bookmarks dialog, uncheck all checkboxes, see if the
"Import" button is disabled. 

Review URL: http://codereview.chromium.org/1566022
------------------------------------------------------------------------
r43768 | jcivelli@google.com | 2010-04-07 00:21:02 +0200 (Wed, 07 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   D /trunk/src/chrome/browser/renderer_host/translation_service.cc
   D /trunk/src/chrome/browser/renderer_host/translation_service.h
   D /trunk/src/chrome/browser/renderer_host/translation_service_unittest.cc
   A /trunk/src/chrome/browser/resources/translate.js
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/renderer/translate/page_translator.cc
   D /trunk/src/chrome/renderer/translate/page_translator.h
   D /trunk/src/chrome/renderer/translate/page_translator_unittest.cc
   D /trunk/src/chrome/renderer/translate/text_translator.h
   D /trunk/src/chrome/renderer/translate/text_translator_impl.cc
   D /trunk/src/chrome/renderer/translate/text_translator_impl.h
   A /trunk/src/chrome/renderer/translate_helper.cc
   A /trunk/src/chrome/renderer/translate_helper.h
   A /trunk/src/chrome/renderer/translate_helper_unittest.cc
   D /trunk/src/chrome/test/data/translate/basic_ORIGINAL.html
   D /trunk/src/chrome/test/data/translate/basic_TRANSLATED.html
   D /trunk/src/chrome/test/data/translate/reverse_text.py

Changing the translate back-end to use the Google Translate element.
When the user indicates that a page should be translated, the browser first fetches the Google Translate Element JS code.
It then sends it to the renderer, which injects the script in the page, waits for the Translate element to be initialized and then calls the translate method on it.

The TranslationService class previously used to translate text chunks is now unused and has been removed. Some of its static methods that are still used have been moved to the TranslateManager class.

This CL also implements the "revert" translation behavior.


BUG=35474,37778,35553,39375
TEST=Test the translation feature extensively.
Review URL: http://codereview.chromium.org/1599016
------------------------------------------------------------------------
r43765 | mpcomplete@chromium.org | 2010-04-06 23:58:14 +0200 (Tue, 06 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable PluginLoadUnload while I look into the failure.

BUG=40588

Review URL: http://codereview.chromium.org/1527014
------------------------------------------------------------------------
r43763 | georgey@chromium.org | 2010-04-06 23:48:34 +0200 (Tue, 06 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Fix for bug #38260 AutoFill needs to obfuscate the saved credit card info in the AutoFill dialog
BUG=38260
TEST=in the bug. When user starts typing in obfuscated field, the text should clear.
Review URL: http://codereview.chromium.org/1567026
------------------------------------------------------------------------
r43759 | sky@chromium.org | 2010-04-06 23:15:43 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Changes end cap of tab-to-search images.

BUG=27570
TEST=none

Review URL: http://codereview.chromium.org/1528019
------------------------------------------------------------------------
r43758 | thestig@chromium.org | 2010-04-06 23:05:25 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/env_vars.cc
   M /trunk/src/chrome/common/env_vars.h
   A /trunk/src/chrome/test/startup/shutdown_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add some shutdown perf tests. We measure shutdown for the combination of
shutdown method: {Close all windows, clicking exit, terminating process}
and number of tabs open: {just about:blank, twenty tabs}

BUG=23118
TEST=This CL adds a test.
Review URL: http://codereview.chromium.org/1594008
------------------------------------------------------------------------
r43757 | estade@chromium.org | 2010-04-06 23:04:55 +0200 (Tue, 06 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK: Change menu delegate callback from CommandWasExecuted to CommandWillBeExecuted.

Both the menu itself and the delegate were being destroyed in ExecuteCommand, double whammy!

BUG=40477
TEST=disable browser action extension via context menu

Review URL: http://codereview.chromium.org/1593012
------------------------------------------------------------------------
r43756 | mpcomplete@chromium.org | 2010-04-06 22:51:16 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/plugin_channel_host.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Fix problems with unloading/reloading/updating extensions that contain NPAPI
plugins, by ensuring that an extension's plugins are shut down and unloaded when the extension unloads.

BUG=34670
BUG=32806

Review URL: http://codereview.chromium.org/1596009
------------------------------------------------------------------------
r43755 | dhollowa@chromium.org | 2010-04-06 22:47:02 +0200 (Tue, 06 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field.h

AutoFill address filling when labels are missing.

When labels are missing but 'name' attributes are set we now fill addresses correctly.

BUG=38320
TEST=AddressFieldTest, FormStructureTest, manual testing with cc.html (attached).

Review URL: http://codereview.chromium.org/1517019
------------------------------------------------------------------------
r43753 | thakis@chromium.org | 2010-04-06 22:37:59 +0200 (Tue, 06 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   A /trunk/src/chrome/browser/cocoa/l10n_util.h
   A /trunk/src/chrome/browser/cocoa/l10n_util.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

Mac: Improve content settings dialog in some languages.

xib changes:
* Get rid of all GTMWidthBasedTweakers in the xib
* Change labels from "clip" to "wrap"

BUG=39390
TEST=See bug

Review URL: http://codereview.chromium.org/1605013
------------------------------------------------------------------------
r43752 | jabdelmalek@google.com | 2010-04-06 22:33:36 +0200 (Tue, 06 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/database_util.cc
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/db_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/ipc/ipc.gypi
   M /trunk/src/ipc/ipc_sync_channel.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/ipc/ipc_sync_message.cc
   M /trunk/src/ipc/ipc_sync_message.h
   A /trunk/src/ipc/ipc_sync_message_filter.cc
   A /trunk/src/ipc/ipc_sync_message_filter.h

Allow synchronous messages to be sent from threads other than the main thread.  This simplifies code that needs to do this (i.e. webkit db and file threads).

BUG=23423
Review URL: http://codereview.chromium.org/1601005
------------------------------------------------------------------------
r43750 | erikkay@chromium.org | 2010-04-06 22:25:54 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc

quiet noisy preferences log during unit tests
(also fixes a lint error)

BUG=40577
TEST=none

Review URL: http://codereview.chromium.org/1600011
------------------------------------------------------------------------
r43748 | arv@chromium.org | 2010-04-06 22:05:09 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Rename kChromeUIFavIconPath to kChromeUIFavIconHost for consistency.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1568015
------------------------------------------------------------------------
r43746 | mark@chromium.org | 2010-04-06 21:56:03 +0200 (Tue, 06 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm

Theme delegate fixes for the 10.6 SDK folllowing r43708.

In the 10.6 SDK, -[NSWindow delegate] returns id<NSWindowDelegate>, not just
id, and the three selectors used in r43708 are not declared in
NSWindowDelegate.  This results in errors such as "warning: '-themeProvider'
not found in protocol(s)".

Testing the selectors before using them is safe and not incorrect, but you
guys might actually want to make more of an assertion about what it means to
be a ChromeBrowserWindow's or FullscreenWindow's delegate, or perhaps even
a ChromeEventProcessingWindow's delegate.  Alternatively, it may be
appropriate to add a ChromeThemedWindow layer as a subclass of CEPW and
superclass of CBW and FW.  (CEPW's other subclass is InfoBubbleWindow.)

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1630001
------------------------------------------------------------------------
r43744 | rsesek@chromium.org | 2010-04-06 21:43:07 +0200 (Tue, 06 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Revert 43741 - [Mac] Make Mac phantom tabs match the appearance of the other platforms.

BUG=none
TEST=Open a new tab, navigate, and pin it. Open a new tab. Close the pinned tab. No tab background should be drawn, just the favicon.

Review URL: http://codereview.chromium.org/1562014

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/1627004
------------------------------------------------------------------------
r43742 | dhg@chromium.org | 2010-04-06 21:19:18 +0200 (Tue, 06 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h

Cl for readability
Review URL: http://codereview.chromium.org/1290001
------------------------------------------------------------------------
r43741 | rsesek@chromium.org | 2010-04-06 21:12:33 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

[Mac] Make Mac phantom tabs match the appearance of the other platforms.

BUG=none
TEST=Open a new tab, navigate, and pin it. Open a new tab. Close the pinned tab. No tab background should be drawn, just the favicon.

Review URL: http://codereview.chromium.org/1562014
------------------------------------------------------------------------
r43740 | pkasting@chromium.org | 2010-04-06 21:10:03 +0200 (Tue, 06 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Change bookmark bar toggle to ctrl-shift-b.

BUG=40565
TEST=ctrl-b does nothing; ctrl-shift-b toggles bookmark bar.
Review URL: http://codereview.chromium.org/1567025
------------------------------------------------------------------------
r43738 | thestig@chromium.org | 2010-04-06 20:50:51 +0200 (Tue, 06 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/common/env_vars.cc
   M /trunk/src/chrome/common/env_vars.h
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/common/process_watcher_win.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc

Convert variables in chrome/common/env_vars.cc from wchar_t to char. Enable ChromeLoggingTest along the way.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1559016
------------------------------------------------------------------------
r43736 | rafaelw@chromium.org | 2010-04-06 20:47:20 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Fix extension checkPermission for notifications.

This fixes checkPermission for chrome-extension: urls that are granted the permission via requestPermission (which is stored in the prefs).

BUG=40495

Review URL: http://codereview.chromium.org/1517018
------------------------------------------------------------------------
r43732 | johnnyg@chromium.org | 2010-04-06 20:23:40 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/notification_1line.html
   M /trunk/src/chrome/browser/resources/notification_2line.html
   M /trunk/src/chrome/browser/resources/notification_icon.html

Use CSS word-wrap property to prevent long single words from causing ugly notifications.

BUG=32847
TEST=create notification with a very long word, should be no horizontal scroll

Review URL: http://codereview.chromium.org/1613005
------------------------------------------------------------------------
r43730 | kkania@chromium.org | 2010-04-06 19:52:19 +0200 (Tue, 06 Apr 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/automation/automation_extension_tracker.cc
   A /trunk/src/chrome/browser/automation/automation_extension_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   A /trunk/src/chrome/test/automation/extension_proxy.cc
   A /trunk/src/chrome/test/automation/extension_proxy.h
   A /trunk/src/chrome/test/automation/extension_proxy_uitest.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc

Add support for basic extension automation through the Automation Proxy.
BUG=36171
TEST=none
Review URL: http://codereview.chromium.org/1048002
------------------------------------------------------------------------
r43729 | cmasone@google.com | 2010-04-06 19:40:44 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memcheck valgrind error

BUG=40481

TEST=The leaking code is only called in a GoogleAuthenticator unit test, so I ran `sh tools/valgrind/chrome_tests.sh -t unit "--gtest_filter=GoogleAuthenticatorTest.*"` and it passed

Review URL: http://codereview.chromium.org/1606014
------------------------------------------------------------------------
r43728 | evan@chromium.org | 2010-04-06 19:35:48 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.cc

linux: properly handle pixbuf refcount

gfx::GdkPixbufFromSkBitmap() returns an image with a refcount of 1.
Fixes heapcheck error seen on buildbots.

Review URL: http://codereview.chromium.org/1578012
------------------------------------------------------------------------
r43726 | dcheng@chromium.org | 2010-04-06 18:58:34 +0200 (Tue, 06 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.h
   A /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.cc
   A /trunk/src/chrome/browser/tab_contents/web_drag_utils_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Win32 plumbing for dragend event.

This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. Note that this only helps with drags that start in Chrome and end outside of Chrome. Since WebDropTarget always lies and claims that no drop occurred, drags that start in Chrome and end in Chrome will still be incorrect.

BUG=39399
TEST=Manual testing using the attached test case on the bug.

Review URL: http://codereview.chromium.org/1136007
------------------------------------------------------------------------
r43723 | pkasting@chromium.org | 2010-04-06 18:50:19 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Show Page Info dialog on mouse up, not mouse down.

BUG=40229
TEST=Visit a page.  Click down, then up on the location bar icon.  The 
dialog should only appear on mouse up.
Review URL: http://codereview.chromium.org/1621003
------------------------------------------------------------------------
r43722 | georgey@chromium.org | 2010-04-06 18:46:33 +0200 (Tue, 06 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

Fixe for #38367 AutoFill UI bug: extra-long fields behaved incorrectly.
BUG=38367
TEST=In the bug.
Review URL: http://codereview.chromium.org/1625002
------------------------------------------------------------------------
r43721 | evan@chromium.org | 2010-04-06 18:36:46 +0200 (Tue, 06 Apr 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.cc
   A /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.h
   A /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.cc
   A /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.h
   A /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

gtk: Implement status icons on linux.

(Retry with less build breakage this time.)

BUG=37375
TEST=out/Debug/unit_tests --gtest_filter=StatusTrayGtkTest.*

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1421001
------------------------------------------------------------------------
r43720 | rsesek@chromium.org | 2010-04-06 18:24:42 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

[Mac] Add a call to |-layoutTabs| so that restored pinned tabs look as they should.

BUG=39900
TEST=Open a new tab, navigate, and pin it. Close the window. Restore the window. Tab should still appear pinned.

Review URL: http://codereview.chromium.org/1628004
------------------------------------------------------------------------
r43719 | dantasse@chromium.org | 2010-04-06 18:08:30 +0200 (Tue, 06 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc

Linux UI tweaks: adjust spacing, add a string, make Customize button invisible instead of disabled

Review URL: http://codereview.chromium.org/1591017
------------------------------------------------------------------------
r43715 | erikkay@chromium.org | 2010-04-06 17:42:39 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/json/json_reader.cc
   M /trunk/src/base/json/json_reader.h
   M /trunk/src/base/json/json_reader_unittest.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/pref_service_uitest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/json_value_serializer.cc
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/json_value_serializer_perftest.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_json_validity_unittest.cc
   M /trunk/src/chrome/test/automation/javascript_execution_controller.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/javascript_test_util.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

detect preferences errors

BUG=38352
TEST=none

Review URL: http://codereview.chromium.org/1120006
------------------------------------------------------------------------
r43711 | glotov@google.com | 2010-04-06 16:41:17 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/language_switch_model.cc
   A /trunk/src/chrome/browser/chromeos/login/language_switch_model.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_delegate.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Abstracted language switch logic to its model class.

BUG=37070
TEST=none

Review URL: http://codereview.chromium.org/1596007
------------------------------------------------------------------------
r43709 | mnissler@chromium.org | 2010-04-06 16:11:44 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h

Fix docking behaviour for devtools windows that don't have an associated browser window

BUG=40090
TEST=none

Review URL: http://codereview.chromium.org/1567014
------------------------------------------------------------------------
r43708 | rohitrao@chromium.org | 2010-04-06 16:09:20 +0200 (Tue, 06 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm

[Mac] Get theme providers from a window's delegate, not its window controller.  These are actually the same object, but they are set at different times during the switch to fullscreen.

BUG=39323
TEST=Go fullscreen with the Android Robot theme installed.  Tab text for unselected tabs should be grey, not black.
Review URL: http://codereview.chromium.org/1576019
------------------------------------------------------------------------
r43707 | dmazzoni@chromium.org | 2010-04-06 15:46:24 +0200 (Tue, 06 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_events.cc
   M /trunk/src/chrome/browser/accessibility_events.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.h
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   M /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.cc
   M /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h

Add menu and menu item events to the accessibility extension api, and
generate menu item notifications for gtk menus.

The code to generate menu open and close events is a little more complicated
and will come in a future patch.

BUG=none
TEST=navigated menus with keyboard, watched notifications fire

Review URL: http://codereview.chromium.org/1585011
------------------------------------------------------------------------
r43706 | phajdan.jr@chromium.org | 2010-04-06 15:03:47 +0200 (Tue, 06 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc

Make DidProcessCrash a bit more solid and accurate on Windows

I hit the NOTREACHED() inside it while debugging an unrelated problem.

Also, now there is one less special case in this function's contract.

TEST=none
BUG=38048

Review URL: http://codereview.chromium.org/1315009
------------------------------------------------------------------------
r43705 | satorux@chromium.org | 2010-04-06 14:02:53 +0200 (Tue, 06 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc

Add NormalizeLanguageCode() to normalize language codes.

The normalization is needed to avoid duplicates in the language table in
the language config diloag, as well as the combobox in the "add language"
dialog, when engines return "jpn" and "ja" as language codes.

Along the way, fixed typos in function names.

TEST=added unit tests, and manually

Review URL: http://codereview.chromium.org/1512022
------------------------------------------------------------------------
r43701 | oshima@chromium.org | 2010-04-06 10:02:42 +0200 (Tue, 06 Apr 2010) | 20 lines
Changed paths:
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/test/ui_test_utils_linux.cc

Enable interactive_ui_tests

 * changed DCHECK in tree_node_model to make it easy to find how it failed.
 * Fixed compilation error in find_bar_host_interactive_uitest.cc on linux/views.
 * Disabled BrowserKeyEventsTest.AccessKeys for Chromeos
   Added/Changed ui_test_utils::RunAllPendingInMessageLoop where necessary.
 * Disabled tab_dragging_tests. I included the source so that we can catch
   compilation error even if tests do not run. Changed the comment from // -> /*
   as GCC complains the use of "\" (and potentially dangerous)
 * Added SleepInMessageLoop to allow event loop to execute the tasks/events
   while waiting.
 * For RunAllPendingInMessageLoop change, please see
   http://codereview.chromium.org/1591004

BUG=39736
TEST=interactive_ui_tests should pass with following cls
http://codereview.chromium.org/1594003
http://codereview.chromium.org/1545011.

Review URL: http://codereview.chromium.org/1576008
------------------------------------------------------------------------
r43700 | oshima@chromium.org | 2010-04-06 07:56:48 +0200 (Tue, 06 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/views/controls/menu/menu_controller.cc

Relanding:
BookmarkBarView tests fixes
 * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking,
    so we can't use RunAllPending().
 * Convert gtk keycode to Win when checking accelerator.

BUG=39736
TEST=none (interactive_ui_tests should pass once enabled
it'll be enabled by http://codereview.chromium.org/1576008

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43699

Review URL: http://codereview.chromium.org/1545011
------------------------------------------------------------------------
r43698 | thakis@chromium.org | 2010-04-06 06:18:04 +0200 (Tue, 06 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentBlockedCookies.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedImages.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedJavaScript.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPopups.xib
   M /trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm

Mac: Make content bubbles wider in languages that have long translations of "Manage" and "Done.

xib changes: Anchor bubble view on right side, make it autoresize horizontally. Same for divider line, radio groups, and title. Make widthbased tweakers at bottom horizontally autoresize. Hook up manage and done buttons to controller.

BUG=39393
TEST=See bug.

Review URL: http://codereview.chromium.org/1527012
------------------------------------------------------------------------
r43696 | sky@chromium.org | 2010-04-06 05:45:21 +0200 (Tue, 06 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/views/animation/bounds_animator.cc

Revert 43692 - Adds some debugging info in hopes of tracking leak in
bounds_animator/tab_strip.

BUG=40475
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1609008

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1512021
------------------------------------------------------------------------
r43694 | mrossetti@chromium.org | 2010-04-06 05:36:36 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.mm

Change how the calculation is performed for determining the location of the arrow tip in a bubble window.

BUG=40406
TEST=1) Not in full-screen and with language set to English, press Cmd-D and verify bubble is properly positioned with arrow tip pointing to star. Change language to Espanol and repeat test. 2) Now in full-screen, repeat the tests.

Review URL: http://codereview.chromium.org/1623002
------------------------------------------------------------------------
r43692 | sky@chromium.org | 2010-04-06 05:23:04 +0200 (Tue, 06 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/views/animation/bounds_animator.cc

Adds some debugging info in hopes of tracking leak in
bounds_animator/tab_strip.

BUG=40475
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1609008
------------------------------------------------------------------------
r43685 | estade@chromium.org | 2010-04-06 03:40:20 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Don't show toolbar border without the toolbar.

BUG=39172
TEST=visual

Review URL: http://codereview.chromium.org/1549021
------------------------------------------------------------------------
r43683 | arv@chromium.org | 2010-04-06 03:01:11 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js

Bookmark manager: Fix tree indentation

BUG=39228
TEST=Create lots of nested folders (more than 10 levels deep).

Review URL: http://codereview.chromium.org/1539023
------------------------------------------------------------------------
r43679 | dcheng@chromium.org | 2010-04-06 01:58:16 +0200 (Tue, 06 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/app/gtk_dnd_util.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc

GTK plumbing for dragend.

This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect.

BUG=39399
TEST=Manual testing using the attached test case on the bug.

Review URL: http://codereview.chromium.org/1589015
------------------------------------------------------------------------
r43678 | chron@chromium.org | 2010-04-06 01:56:16 +0200 (Tue, 06 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/pref_service.h
   A /trunk/src/chrome/browser/scoped_pref_update.cc
   A /trunk/src/chrome/browser/scoped_pref_update.h
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Add a scoped notifier for pref dictionaries / lists.
Other options included subclassing the pref value types, making the firenotifications public, or just friend classing.

Since values can contain other values, such as dictionary within dictionary, it didn't seem like a good idea to subclass. We might want to consider combining the scoped lookup with the GetMutableList call at some point, but some callers keep a long reference so that might be a bad idea.

BUG=38557
TEST=manual

Review URL: http://codereview.chromium.org/1549020
------------------------------------------------------------------------
r43677 | pkasting@chromium.org | 2010-04-06 01:47:31 +0200 (Tue, 06 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Fix Mac build failure.

BUG=27570
TEST=none

------------------------------------------------------------------------
r43676 | pkasting@chromium.org | 2010-04-06 01:36:45 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/app/theme/ev_secure.png
   D /trunk/src/chrome/app/theme/o2_globe.png
   D /trunk/src/chrome/app/theme/o2_globe_selected.png
   D /trunk/src/chrome/app/theme/o2_globe_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_history.png
   D /trunk/src/chrome/app/theme/o2_history_selected.png
   D /trunk/src/chrome/app/theme/o2_history_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_more.png
   D /trunk/src/chrome/app/theme/o2_more_selected.png
   D /trunk/src/chrome/app/theme/o2_more_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_search.png
   D /trunk/src/chrome/app/theme/o2_search_selected.png
   D /trunk/src/chrome/app/theme/o2_search_selected_dark.png
   D /trunk/src/chrome/app/theme/o2_star.png
   D /trunk/src/chrome/app/theme/o2_star_selected.png
   D /trunk/src/chrome/app/theme/o2_star_selected_dark.png
   A /trunk/src/chrome/app/theme/omnibox_history.png (from /trunk/src/chrome/app/theme/o2_history.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_history_dark.png (from /trunk/src/chrome/app/theme/o2_history_selected_dark.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_history_selected.png (from /trunk/src/chrome/app/theme/o2_history_selected.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_http.png (from /trunk/src/chrome/app/theme/o2_globe.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_http_dark.png (from /trunk/src/chrome/app/theme/o2_globe_selected_dark.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_http_selected.png (from /trunk/src/chrome/app/theme/o2_globe_selected.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_https_green.png (from /trunk/src/chrome/app/theme/ev_secure.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_https_invalid.png (from /trunk/src/chrome/app/theme/security_error.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_https_valid.png (from /trunk/src/chrome/app/theme/secure.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_https_warning.png (from /trunk/src/chrome/app/theme/security_warning.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_more.png (from /trunk/src/chrome/app/theme/o2_more.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_more_dark.png (from /trunk/src/chrome/app/theme/o2_more_selected_dark.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_more_selected.png (from /trunk/src/chrome/app/theme/o2_more_selected.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_search.png (from /trunk/src/chrome/app/theme/o2_search.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_search_dark.png (from /trunk/src/chrome/app/theme/o2_search_selected_dark.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_search_selected.png (from /trunk/src/chrome/app/theme/o2_search_selected.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_star.png (from /trunk/src/chrome/app/theme/o2_star.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_star_dark.png (from /trunk/src/chrome/app/theme/o2_star_selected_dark.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_star_lit.png (from /trunk/src/chrome/app/theme/starred.png:43646)
   A /trunk/src/chrome/app/theme/omnibox_star_selected.png (from /trunk/src/chrome/app/theme/o2_star_selected.png:43646)
   D /trunk/src/chrome/app/theme/secure.png
   D /trunk/src/chrome/app/theme/security_error.png
   D /trunk/src/chrome/app/theme/security_warning.png
   D /trunk/src/chrome/app/theme/star.png
   D /trunk/src/chrome/app/theme/star_Template.pdf
   D /trunk/src/chrome/app/theme/starred.pdf
   D /trunk/src/chrome/app/theme/starred.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/theme_resources_util_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Replace omnibox icons with new set that are all the same size (19x19).

TBR=jnj
BUG=27570
TEST=Type "paypal.com", watch as it loads, ensure address doesn't shift sideways when the lock appears.
Review URL: http://codereview.chromium.org/1560015
------------------------------------------------------------------------
r43674 | oshima@chromium.org | 2010-04-06 01:18:30 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/views/controls/menu/menu_controller.cc

Revert "BookmarkBarView tests fixes"

I don't understand why this is still causing the problem, but reverting this for now.

This reverts commit 6bb4f22703226e093644c28afe34d975cc7d549d.

Review URL: http://codereview.chromium.org/1612005
------------------------------------------------------------------------
r43673 | zork@chromium.org | 2010-04-06 01:06:27 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc

Don't compare wchar_t *s

BUG=38559
TEST=Manual test.

Review URL: http://codereview.chromium.org/1562011
------------------------------------------------------------------------
r43671 | feldstein@chromium.org | 2010-04-06 01:03:21 +0200 (Tue, 06 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Delete bookmarks with backspace on mac

Safari deletes bookmarks using the backspace key, so we should too.

BUG=39211
TEST=Highlight a bookmark and press the backspace key, the delete key, or
meta+backspace.  All should delete the bookmark.

Review URL: http://codereview.chromium.org/1513017
------------------------------------------------------------------------
r43669 | pkasting@chromium.org | 2010-04-06 00:50:13 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.h
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc
   M /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.h
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   A /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.cc
   A /trunk/src/chrome/browser/views/options/geolocation_exceptions_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Geolocation exceptions window, Windows.

This also makes some correctness/consistency fixes to the model that affect other OSes, e.g. we now allow "remove" on the selected exception set iff all selected exceptions are removable.

BUG=39817
TEST=Geolocation exceptions window exists on windows, allows sorting by either column
Review URL: http://codereview.chromium.org/1539021
------------------------------------------------------------------------
r43667 | albertb@chromium.org | 2010-04-06 00:30:47 +0200 (Tue, 06 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/login_database_mac.cc
   D /trunk/src/chrome/browser/password_manager/login_database_mac.h
   A /trunk/src/chrome/browser/password_manager/login_database_posix.cc
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   A /trunk/src/chrome/browser/password_manager/login_database_win.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement LoginDatabase on all platforms.

BUG=35038
TEST=LoginDatabaseTest

Review URL: http://codereview.chromium.org/1567022
------------------------------------------------------------------------
r43658 | oshima@chromium.org | 2010-04-06 00:02:39 +0200 (Tue, 06 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Revert the unnecessary change.   I forgot to remove this test code when I created the cl.

BUG=39736
TEST=interactive_ui_tests shoudl cycle green
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/1602009
------------------------------------------------------------------------
r43652 | ctguil@chromium.org | 2010-04-05 23:40:01 +0200 (Mon, 05 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Browser action icons not displayed in detached browser window

Regression from this revision
http://src.chromium.org/viewvc/chrome?view=rev&revision=43044 

BUG=40272
TEST=Verify installed browser actions are visible in browser window created by detaching a tab.

Review URL: http://codereview.chromium.org/1530019
------------------------------------------------------------------------
r43651 | jrg@chromium.org | 2010-04-05 22:59:40 +0200 (Mon, 05 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Fix perf regression (again)

Review URL: http://codereview.chromium.org/1602008
------------------------------------------------------------------------
r43649 | dhollowa@chromium.org | 2010-04-05 22:54:13 +0200 (Mon, 05 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

AutoFill credit card field filling, with nameoncard field.

Enables credit card filling when "Name on Card" field is present.  This adds
to existing method of clicking on card number to fill.

Note: this fixes up unit test changes with recent migration to FormData from
FormFieldValues.

BUG=38320
TEST=CreditCardFieldTest, FormStructureTest, manual testing with cc.html (attached).

Related to:
		http://codereview.chromium.org/1518017
		http://codereview.chromium.org/1605011


Review URL: http://codereview.chromium.org/1512018
------------------------------------------------------------------------
r43645 | arv@chromium.org | 2010-04-05 22:11:01 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Add F2 shortcut to rename folder and edit bookmark.

BUG=20992
TEST=Press F2 to rename folder or edit a bookmark.

Review URL: http://codereview.chromium.org/1612003
------------------------------------------------------------------------
r43643 | mirandac@chromium.org | 2010-04-05 22:01:59 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Update Flash EULA positioning code to use new view_text_utils instead of old local method.  TBR=finnur

BUG= none
TEST= chrome for chromeos about box looks fine.

Review URL: http://codereview.chromium.org/1615004
------------------------------------------------------------------------
r43638 | jrg@chromium.org | 2010-04-05 21:50:25 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix pyauto test on ChromeOS withOUT introducing a perf regression on XP.

BUG=http://crbug.com/39559
BUG=http://crbug.com/40225

Review URL: http://codereview.chromium.org/1540015
------------------------------------------------------------------------
r43636 | eroman@chromium.org | 2010-04-05 21:28:36 +0200 (Mon, 05 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   A /trunk/src/chrome/browser/resources/net_internals/proxyview.js
   M /trunk/src/chrome/browser/resources/net_internals/requestsview.js
   M /trunk/src/chrome/chrome_browser.gypi

Add the proxy information to the new net internals page.
BUG=37421

Review URL: http://codereview.chromium.org/1607004
------------------------------------------------------------------------
r43635 | finnur@chromium.org | 2010-04-05 21:18:58 +0200 (Mon, 05 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Fix regression for browser action container width on Toolkit
Views.

Once we introduced the model for keeping track of the number of
visible icons, there was a race that was introduced where the 
toolbar could get constructed before the model knew about any
icons, so on startup the width of the container was 0.

This CL hooks up the newly added ModelLoaded notification and
sets the width on receiving that notification, if the width
hasn't been set already.

BUG=40329
TEST=None

Review URL: http://codereview.chromium.org/1547021
------------------------------------------------------------------------
r43634 | mirandac@chromium.org | 2010-04-05 20:57:01 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   A /trunk/src/views/view_text_utils.cc
   A /trunk/src/views/view_text_utils.h
   M /trunk/src/views/views.gyp

Move utility method for embedding links in texts from about_chrome_view to a generic class, for future use in other classes.

BUG= none
TEST= chrome "about" dialog still works the same, in ltr and rtl languages.

Review URL: http://codereview.chromium.org/1508018
------------------------------------------------------------------------
r43633 | craig.schlenter@chromium.org | 2010-04-05 20:54:32 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details_linux.cc

Linux: fix about:memory for epiphany and add iceweasel.

BUG=40370
TEST=Run epiphany and iceweasel and check that they appear in about:memory.

Review URL: http://codereview.chromium.org/1611007
------------------------------------------------------------------------
r43632 | rohitrao@chromium.org | 2010-04-05 20:50:11 +0200 (Mon, 05 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

Fixes bug numbers for disabled tests.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1594006
------------------------------------------------------------------------
r43631 | thakis@chromium.org | 2010-04-05 20:45:33 +0200 (Mon, 05 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.h
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/skia/ext/skia_utils_mac.mm

Mac: Make image dragging 162.4% more awesome.

Also needs a webkit patch to do anything ( https://bugs.webkit.org/show_bug.cgi?id=37069 ), but can be landed independently.

BUG=11457,18992
TEST=(all require the webkit patch, so this won't work yet)
http://html5demos.com/drag and http://ljouanneau.com/lab/html5/demodragdrop.html
  Dragging should show image
http://www.google.com/
  Dragging google image should show image
http://www.travelvivi.com/wp-content/uploads/2009/09/Eiffel_Tower.jpg
  Dragging image should work, drag image should be smaller than image itself
Random website
  Mark some text, drag it. Should show drag cursor and no image

Review URL: http://codereview.chromium.org/1539018
------------------------------------------------------------------------
r43630 | dhollowa@chromium.org | 2010-04-05 20:15:49 +0200 (Mon, 05 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

Revert 43627 - AutoFill credit card field filling, with nameoncard field.

Enables credit card filling when "Name on Card" field is present.  This adds
to existing method of clicking on card number to fill.

BUG=38320
TEST=CreditCardFieldTest, FormStructureTest, manual testing with cc.html (attached).

Review URL: http://codereview.chromium.org/1518017

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/1605011
------------------------------------------------------------------------
r43629 | cmasone@google.com | 2010-04-05 20:11:18 +0200 (Mon, 05 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h
   A /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc (from /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc:43477)
   A /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h (from /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h:43477)
   A /trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc (from /trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc:43477)
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   A /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc (from /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc:43477)
   M /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Re-land 43382, which was reverted in 43478 due to valgrind problems.

Valgrind issues failures addressed, trying to land this again.

Move fetching of fullfledged auth cookies to a time when we have the user's real profile available. Also, enable the use of a localaccount on Chrome OS.

Initial CL: http://codereview.chromium.org/1515003
Revert CL: http://codereview.chromium.org/1517015


Review URL: http://codereview.chromium.org/1567020
------------------------------------------------------------------------
r43628 | oshima@chromium.org | 2010-04-05 20:10:34 +0200 (Mon, 05 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/views/controls/menu/menu_controller.cc

BookmarkBarView tests fixes
 * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking,
    so we can't use RunAllPending().
 * Convert gtk keycode to Win when checking accelerator.

BUG=39736
TEST=none (interactive_ui_tests should pass once enabled
it'll be enabled by http://codereview.chromium.org/1576008

Review URL: http://codereview.chromium.org/1545011
------------------------------------------------------------------------
r43627 | dhollowa@chromium.org | 2010-04-05 20:09:24 +0200 (Mon, 05 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

AutoFill credit card field filling, with nameoncard field.

Enables credit card filling when "Name on Card" field is present.  This adds
to existing method of clicking on card number to fill.

BUG=38320
TEST=CreditCardFieldTest, FormStructureTest, manual testing with cc.html (attached).

Review URL: http://codereview.chromium.org/1518017
------------------------------------------------------------------------
r43625 | mhm@chromium.org | 2010-04-05 19:40:10 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc

Bookmark Bubble Accessible Info.

BUG=9601
TEST=Inspect32 through the fields.

Review URL: http://codereview.chromium.org/1591012
------------------------------------------------------------------------
r43620 | finnur@chromium.org | 2010-04-05 19:08:07 +0200 (Mon, 05 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h

Fix prepopulate value for Find and add browser tests for it.

Notable changes:

FindBarController now sets the prepopulate text during Show for the Find dialog, to fix regression 40121. It also checks not just the current find string (find_text()) but the previous one also (previous_find_text()) in MaybeSetPrepopulateText() because the current find string is blanked out when closing the Find window. And TabContents now makes sure previous_find_text() is never overwritten with an empty find_text value (to prevent the last search from being cleared if you open Find, close it without searching and open it again).

This changelist also adds automated tests for the codepaths above, which results in adding a GetFindText method to the FindBarTesting interface, to allow the tests to check what string is being shown to the user when the Find box opens.

BUG=40121
TEST=FindInPageControllerTest.Prepopulate* (three tests)

Review URL: http://codereview.chromium.org/1560012
------------------------------------------------------------------------
r43618 | dantasse@chromium.org | 2010-04-05 18:29:39 +0200 (Mon, 05 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Turn on autofill and prefs sync by default
BUG: 34209
TEST: behavior should be the same as if you had set the --enable-sync-preferences and --enable-sync-autofill flags.

Review URL: http://codereview.chromium.org/1551014
------------------------------------------------------------------------
r43617 | oshima@chromium.org | 2010-04-05 18:20:34 +0200 (Mon, 05 Apr 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

A patch to fix a couple of issues in interactive_ui_tests on ChromeOS

* Removed two static SkBitmap objects.
 - default_favicion does not seem to be in use. Removed along with InitClass.
 - Moved to local static and moved to heap. SkBitmap destructor was failing on
   exit (in pthread_mutex_lock)

* Set VIEW_ID_TAB_CONTAINER_FOCUS_VIEW to the tab container (this ID is required in the test)

* Use FocusManager and call TabContentsDelegate::TakeFocus
  in TabContentsViewGtk::TakeFocus.

BUG=39736
TEST=none (interactive_ui_tests needs more patch to run)

Review URL: http://codereview.chromium.org/1594003
------------------------------------------------------------------------
r43614 | satorux@chromium.org | 2010-04-05 17:38:54 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Remove horizontal lines from the language config view.

BUG=crosbug.com/2349
TEST=manually checked the appearance

Review URL: http://codereview.chromium.org/1572021
------------------------------------------------------------------------
r43613 | satorux@chromium.org | 2010-04-05 17:33:47 +0200 (Mon, 05 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Deprecate Activate/DeactivateImeProperty and Activate/DeactivateLanguage.

This is just code cleanup.

BUG=crosbug.com/2356.
TEST=manually confirmed the ime stuff works with chrome

Review URL: http://codereview.chromium.org/1570012
------------------------------------------------------------------------
r43612 | dmazzoni@chromium.org | 2010-04-05 17:04:18 +0200 (Mon, 05 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

NULL-check before accessing toplevel_window_ to avoid race-condition crash.
To reliably reproduce (before this patch), run browser_tests
--gtest_filter=ExtensionApiTest.ShowPageActionPopup and then move the
mouse pointer outside of the browser window.

BUG=none
TEST=fixes ExtensionApiTest.ShowPageActionPopup

Review URL: http://codereview.chromium.org/1555006
------------------------------------------------------------------------
r43611 | thakis@chromium.org | 2010-04-05 16:39:02 +0200 (Mon, 05 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm

Mac: Make geolocation exceptions dialog remove buttons actually work.

xib changes: Change controls size in "Action" column from 'small' to 'regular'.

BUG=39818
TBR=trungl

Review URL: http://codereview.chromium.org/1609005
------------------------------------------------------------------------
r43610 | thakis@chromium.org | 2010-04-05 16:25:30 +0200 (Mon, 05 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   A /trunk/src/chrome/app/nibs/GeolocationExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   A /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.h
   A /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/geolocation_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Implement geolocation exceptions dialog.

xib changes:
Content settings window: Enable & hook up "exceptions" button.

The dialog is not "live" (i.e. if it's open while settings are deleted through the bubble, the window is only updated after closing & reopening it). It's not possible to do any editing in the window, only deleting. This matches windows/linux.

http://imgur.com/q7qMK

BUG=39818
TEST=Go to a few geolocation pages, click allow/deny. Then go to content settings->locations->exceptions, the visited pages should be listed.

Review URL: http://codereview.chromium.org/1566015
------------------------------------------------------------------------
r43609 | dpolukhin@chromium.org | 2010-04-05 13:47:38 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc

Added browser test for login screen if authentication is failed.

BUG=chromiumos:2036
TEST=Run test LoginManagerViewTest.AuthentionFailed

Review URL: http://codereview.chromium.org/1594016
------------------------------------------------------------------------
r43608 | yusukes@google.com | 2010-04-05 13:41:38 +0200 (Mon, 05 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Use "preload_engines" pref on Chrome side to save the list of active IMEs (2nd try).

Original review: http://codereview.chromium.org/1576010

BUG=crosbug.com/488
TEST=manual
TBR=satorux

Review URL: http://codereview.chromium.org/1606010
------------------------------------------------------------------------
r43607 | hbono@chromium.org | 2010-04-05 12:30:25 +0200 (Mon, 05 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Disables AeroPeek by default.
Because my AeroPeek code caused lots of usability problems, this change disables the AeroPeek code by default and add an "--enable-aero-peek-tabs" option, which enables this code, until we find solutions that avoid flooding users with tab thumbnails. 

BUG=37957
TEST=Open two tabs, and verify we can see only one thumbnail on Windows 7.
Review URL: http://codereview.chromium.org/1571008
------------------------------------------------------------------------
r43605 | ukai@chromium.org | 2010-04-05 11:09:16 +0200 (Mon, 05 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.h
   M /trunk/src/net/websockets/websocket.cc
   M /trunk/src/net/websockets/websocket.h
   M /trunk/src/net/websockets/websocket_unittest.cc

Update new WebSocket API.

Add new readyState CLOSING.
Fix close() to match the API spec.
OnError reports WebSocket error, and OnSocketError reports socket level error
OnClose reports was_clean.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1587008
------------------------------------------------------------------------
r43603 | yusukes@chromium.org | 2010-04-05 10:30:34 +0200 (Mon, 05 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adding "preload_engines" and "use_global_engine" preferences to Chrome side (2nd try; see r43475 and r43481).

Modified chrome/browser/chromeos/cros/cros_in_process_browser_test.cc not to break browser_tests. Other files are not modified since the previous CL (r43475).

BUG=crosbug.com/488
TEST=none

Review URL: http://codereview.chromium.org/1599017
------------------------------------------------------------------------
r43596 | mhm@chromium.org | 2010-04-05 03:57:45 +0200 (Mon, 05 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix browser test TestStarButtonAccObj.

Fixes the disabled test by setting the accessible name after we set the tooltip.

BUG=40391
TEST=The following test passes browser_tests.exe --gtest_filter=BrowserViewsAccessibilityTest.TestStarButtonAccObj

Review URL: http://codereview.chromium.org/1530020
------------------------------------------------------------------------
r43594 | mhm@chromium.org | 2010-04-05 01:54:54 +0200 (Mon, 05 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Replace string conversion header with the UTF version.

TBR=jhawkins
BUG=40343
TEST=None

Review URL: http://codereview.chromium.org/1619001
------------------------------------------------------------------------
r43593 | sky@chromium.org | 2010-04-05 00:45:13 +0200 (Mon, 05 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc

Disables TestStarButtonAccObj.

BUG=40391
TEST=none
TBR=pkastking@chromium.org, mhm@chromium.org

Review URL: http://codereview.chromium.org/1569020
------------------------------------------------------------------------
r43585 | mhm@chromium.org | 2010-04-04 06:15:56 +0200 (Sun, 04 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Fix build break on chromeos and linux views.

String conversion fix due to r43584.

TBR=pkasting
TEST=none

Review URL: http://codereview.chromium.org/1528017
------------------------------------------------------------------------
r43584 | mhm@chromium.org | 2010-04-04 05:51:23 +0200 (Sun, 04 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h

Fix Regression for Accessible Names appearing as NAMELESS.

The refactoring in r43558 caused SetAccessibleName and GetAccessibleName to be none virtual causing couple of components not having accessible names since they depend on overriding it. The following change sets the accessible name directly since view now stores it.

BUG=40343
TEST=With AccExplorer32 check if accessible names have been resolved.

Review URL: http://codereview.chromium.org/1616004
------------------------------------------------------------------------
r43582 | sky@chromium.org | 2010-04-04 01:54:07 +0200 (Sun, 04 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/animation/bounds_animator.cc

Changes tab strip to use BoundsAnimator for tab strip animations and
adds a new animation when inserting a tab. I've changed the code to
make it clear when an index is in terms of the model, and when it is
in terms of tab_data_. I may replace using an index for tab data with
an actual int wrapper class to avoid mistakes, but I'll do that
separately.

BUG=27783
TEST=thorougly test all animations in the tab strip, as well as
dragging tabs in an out.

Review URL: http://codereview.chromium.org/1553008
------------------------------------------------------------------------
r43576 | aa@chromium.org | 2010-04-03 10:33:10 +0200 (Sat, 03 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc
   M /trunk/src/chrome/chrome_browser.gypi

Fix build break in linux_views from r43575.

BUG=29633
TBR=jrg@chromium.org
------------------------------------------------------------------------
r43575 | aa@chromium.org | 2010-04-03 09:03:34 +0200 (Sat, 03 Apr 2010) | 11 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/ExtensionInstallPrompt.xib
   A /trunk/src/chrome/app/nibs/ExtensionInstallPromptNoWarnings.xib
   A /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.h
   A /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller.mm
   A /trunk/src/chrome/browser/cocoa/extensions/extension_install_prompt_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/install_prompt
   A /trunk/src/chrome/test/data/extensions/install_prompt/extension.json
   A /trunk/src/chrome/test/data/extensions/install_prompt/icon.png

Add the new extension install dialog for mac.

There are two xibs in this change.

ExtensionInstallPrompt.xib: This handles the more common case of installing an extension with one or more permission warnings. There is an NSBox with room for the warnings which are separated by \n\n.

ExtensionInstallPromptNoWarnings.xib: It is also possible to install an extension with zero permission warnings. This is currently rare, but we hope to make it more common in the coming quarters. In this case, there is no NSBox and the layout is slightly different.

BUG=29633

Review URL: http://codereview.chromium.org/1540013
------------------------------------------------------------------------
r43573 | aa@chromium.org | 2010-04-03 08:02:34 +0200 (Sat, 03 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/notifications_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/notifications_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/storage_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/storage_old.json

Fix a few places where we were incorrectly classifying
notifications and storage permissions as "access to your
browsing history".

Review URL: http://codereview.chromium.org/1526007
------------------------------------------------------------------------
r43568 | georgey@chromium.org | 2010-04-03 06:27:17 +0200 (Sat, 03 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Fix crash in some network situations
BUG=40234
TEST=In the bug.
Review URL: http://codereview.chromium.org/1549018
------------------------------------------------------------------------
r43567 | georgey@chromium.org | 2010-04-03 06:21:06 +0200 (Sat, 03 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/views/controls/button/radio_button.cc

Adds 'default' check to profiles, allows opening/closing profile by clicking on the label
BUG=38284,38263
TEST=in the bugs
Review URL: http://codereview.chromium.org/1607005
------------------------------------------------------------------------
r43563 | estade@chromium.org | 2010-04-03 03:19:29 +0200 (Sat, 03 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK: don't show reload button for popup/app windows.

BUG=40204
TEST=manual

Review URL: http://codereview.chromium.org/1601006
------------------------------------------------------------------------
r43562 | pkasting@chromium.org | 2010-04-03 03:15:43 +0200 (Sat, 03 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/theme/reload.png
   M /trunk/src/chrome/app/theme/reload_d.png
   D /trunk/src/chrome/app/theme/reload_endcap.png
   D /trunk/src/chrome/app/theme/reload_endcap_h.png
   D /trunk/src/chrome/app/theme/reload_endcap_p.png
   M /trunk/src/chrome/app/theme/reload_h.png
   M /trunk/src/chrome/app/theme/reload_p.png
   M /trunk/src/chrome/app/theme/star.png
   D /trunk/src/chrome/app/theme/star_d.png
   D /trunk/src/chrome/app/theme/star_h.png
   D /trunk/src/chrome/app/theme/star_mask.png
   D /trunk/src/chrome/app/theme/star_noborder.png
   D /trunk/src/chrome/app/theme/star_noborder_center.png
   D /trunk/src/chrome/app/theme/star_p.png
   M /trunk/src/chrome/app/theme/starred.png
   D /trunk/src/chrome/app/theme/starred_h.png
   D /trunk/src/chrome/app/theme/starred_noborder.png
   D /trunk/src/chrome/app/theme/starred_noborder_center.png
   D /trunk/src/chrome/app/theme/starred_p.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   D /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   D /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak

Star/reload shuffle, Windows version.

BUG=27570
TEST=Star should be moved to right hand end of location bar, reload to left endcap.
Review URL: http://codereview.chromium.org/1561009
------------------------------------------------------------------------
r43560 | inferno@chromium.org | 2010-04-03 03:10:07 +0200 (Sat, 03 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc

Patch local file traversal bug by removing query, ref in path consideration in URLToFilePath()

BUG=40136
TEST=None
Review URL: http://codereview.chromium.org/1611004
------------------------------------------------------------------------
r43559 | thestig@chromium.org | 2010-04-03 03:05:39 +0200 (Sat, 03 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/app/gtk_util.cc
   M /trunk/src/base/base.gypi
   M /trunk/src/base/base_paths_posix.cc
   A /trunk/src/base/env_var.cc
   A /trunk/src/base/env_var.h
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/base/sys_info.h
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/common/chrome_paths_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

Move EnvironmentVariableGetter from base/linux_util.h to base/env_var.h and rename it EnvVarGetter. Label base::SysInfo::{Get,Has}EnvVar as deprecated.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1606007
------------------------------------------------------------------------
r43558 | pkasting@chromium.org | 2010-04-03 02:56:12 +0200 (Sat, 03 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/controls/button/button.cc
   M /trunk/src/views/controls/button/button.h
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/progress_bar.h
   M /trunk/src/views/controls/resize_gripper.cc
   M /trunk/src/views/controls/resize_gripper.h
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/single_split_view.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Eliminate a lot of duplicated implementations of Get/SetAccessibleName() by just putting it on the base class.  Also cleans up a couple other misc. accessibility functions in view.h.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1512012
------------------------------------------------------------------------
r43557 | dpranke@chromium.org | 2010-04-03 02:49:55 +0200 (Sat, 03 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Change ui_tests to pull the directories it needs from the upstream webkit
tree directly rather than relying on webkit/data/layout_tests for the
baselines. This requires us to change a few spots in the source code
because the directory naming conventions for platform-specific baselines
is different upstream (it's platform/chromium-win/foo rather than
platform/chromium-win/LayoutTests/foo).

Once this test lands we can (in theory) remove the downstream layout test baselines.

    BUG=none
    TEST=none
    R=dimich@chromium.org

Review URL: http://codereview.chromium.org/1547009
------------------------------------------------------------------------
r43556 | evan@chromium.org | 2010-04-03 02:37:28 +0200 (Sat, 03 Apr 2010) | 1 line
Changed paths:
   D /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.cc
   D /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.h
   D /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.cc
   D /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.h
   D /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert.
------------------------------------------------------------------------
r43555 | jhawkins@chromium.org | 2010-04-03 02:30:59 +0200 (Sat, 03 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/credit_card_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/form_autocomplete_unittest.cc
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager.h
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/form_data.h
   D /trunk/src/webkit/glue/form_field_values.cc
   D /trunk/src/webkit/glue/form_field_values.h
   M /trunk/src/webkit/glue/webkit_glue.gypi

AutoFill: Use the FormManager cache to send forms to the AutoFillManager.
Remove the FormFieldValues class and replace its usage with FormData.

BUG=38325,33032
TEST=none

Review URL: http://codereview.chromium.org/1606005
------------------------------------------------------------------------
r43553 | evan@chromium.org | 2010-04-03 02:17:35 +0200 (Sat, 03 Apr 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/status_icons
   A /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.cc
   A /trunk/src/chrome/browser/gtk/status_icons/status_icon_gtk.h
   A /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.cc
   A /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk.h
   A /trunk/src/chrome/browser/gtk/status_icons/status_tray_gtk_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

gtk: Implement status icons on linux.

BUG=37375
TEST=out/Debug/unit_tests --gtest_filter=StatusTrayGtkTest.*

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1421001
------------------------------------------------------------------------
r43552 | dantasse@chromium.org | 2010-04-03 02:16:37 +0200 (Sat, 03 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc

Added themes to CustomizeSyncWindowGtk

Review URL: http://codereview.chromium.org/1589014
------------------------------------------------------------------------
r43551 | arv@chromium.org | 2010-04-03 02:12:15 +0200 (Sat, 03 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Move the 'activate' part out of list and add an activate-command with keyboard shortcuts set on the command. This solves the issue of having platform specific activation keyboard shortcuts and move that to the command.

BUG=39715
TEST=Try double clicking on bookmarks and folders in the list. Also try selecting one or multiple items (including folders). If a single folder is selected we should navigate to the folder instead of opening the items in the folder.

Review URL: http://codereview.chromium.org/1569019
------------------------------------------------------------------------
r43548 | kuan@chromium.org | 2010-04-03 01:01:37 +0200 (Sat, 03 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm

mac translate infobar: fix incorrect language selected
- mac was using index of menu item to manipulate languages; this was broken when i sorted the languages by application locale
- this cl fixes the problem by manipulating languages with command ids which directly map into the languages arrays in translate delegate. 

BUG=40271
TEST=verify per bug report

Review URL: http://codereview.chromium.org/1585016
------------------------------------------------------------------------
r43545 | viettrungluu@chromium.org | 2010-04-03 00:53:04 +0200 (Sat, 03 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Add Flash EULA to about box on Windows/Views (for branded builds).

BUG=none
TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Te rms of Service, with "License Agreement" an appropriate link.

Review URL: http://codereview.chromium.org/1561010
------------------------------------------------------------------------
r43544 | dhg@chromium.org | 2010-04-03 00:51:41 +0200 (Sat, 03 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.cc

updating test
Review URL: http://codereview.chromium.org/1551015
------------------------------------------------------------------------
r43543 | feldstein@chromium.org | 2010-04-03 00:51:06 +0200 (Sat, 03 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js

Add batchAdd functions to JS List

BMM can be really slow to render when there are hundreds of bookmarks in the
bookmark bar.  This will hide the list while it's rendering the new elements
which increases performance by a lot since it doesn't have to do any
measurements while it's adding all the elements.

BUG=39865
TEST=Load BMM with over 500 bookmarks in the bookmark bar

Review URL: http://codereview.chromium.org/1540014
------------------------------------------------------------------------
r43542 | dantasse@chromium.org | 2010-04-03 00:48:00 +0200 (Sat, 03 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Fix some Sync strings

Review URL: http://codereview.chromium.org/1600004
------------------------------------------------------------------------
r43541 | dhg@chromium.org | 2010-04-03 00:47:45 +0200 (Sat, 03 Apr 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.h
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc

CHanging the mount library to mount the drives explicitly. Adding the notion of parent devices as well.
Review URL: http://codereview.chromium.org/1608004
------------------------------------------------------------------------
r43540 | shess@chromium.org | 2010-04-03 00:39:50 +0200 (Sat, 03 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm

[Mac] Magnifying glass in keyword-search bubble.

Abstract the image-in-attributed-string code into a helper function so
everyone makes the same mistakes.  The keyword-search string's
baseline became wrong at some point, adjust it to match the rest of
the field.

BUG=37865
TEST=Type "google.com" until "press tab to search" appears, hit TAB.  "Search Google:" bubble should have a magnifying glass on the LHS.
TEST=Add a bunch of text to search.  Resizing smaller should first remove the image, then change to shorter text ("Search Go..." or somesuch).

Review URL: http://codereview.chromium.org/1581011
------------------------------------------------------------------------
r43534 | michaeln@chromium.org | 2010-04-03 00:12:56 +0200 (Sat, 03 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/sql/diagnostic_error_delegate.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h
   M /trunk/src/webkit/appcache/appcache_database.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.cc
   M /trunk/src/webkit/appcache/appcache_interfaces.h
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/database/database_tracker.cc

Include the appcache and database tracker databases into the sql diagnostics fold. 

TEST=manual 
BUG=none


Review URL: http://codereview.chromium.org/1508016
------------------------------------------------------------------------
r43532 | mark@chromium.org | 2010-04-03 00:02:30 +0200 (Sat, 03 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

#include what you use: <Security/Security.h> for SecKeychainAddCallback and
friends following r43492.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1570010
------------------------------------------------------------------------
r43531 | georgey@chromium.org | 2010-04-03 00:01:20 +0200 (Sat, 03 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download.cc
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   M /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.h
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser_unittest.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Behaving nice with AutoFill servers: Adjusting upload rate, processing 500, 502 and 503 responses, etc.
TEST=Unit-tested + by setting up the response from AutoFill server.
BUG=39921
Review URL: http://codereview.chromium.org/1535011
------------------------------------------------------------------------
r43530 | mpcomplete@chromium.org | 2010-04-02 23:49:53 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_apitest_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/alert
   A /trunk/src/chrome/test/data/extensions/api_test/alert/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/alert/test.html

Fix a crash when an extension bg page calls alert(). Add regression tests this
time.

BUG=37567

Review URL: http://codereview.chromium.org/1602005
------------------------------------------------------------------------
r43529 | mattm@chromium.org | 2010-04-02 23:47:13 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc
   A /trunk/src/chrome/browser/gtk/options/geolocation_content_exceptions_window.h
   M /trunk/src/chrome/chrome_browser.gypi

Linux: Add geolocation exceptions window.

BUG=39820
TEST=manual

Review URL: http://codereview.chromium.org/1518010
------------------------------------------------------------------------
r43528 | jrg@chromium.org | 2010-04-02 23:40:24 +0200 (Fri, 02 Apr 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc

New tab perfbot didn't like this.
Reverting to confirm this was the cause.

Even if proven the cause my plan is to re-land since this fixes a
visible bug but fix perf in a different way.

BUG=40225


Revert 43419 - Fix floating bookmark bar on windows.

IsBookmarkBarVisible() continues to have a consistent meaning across
platforms, but extra logic has been added to windows to be smarter
about when to show the bar.  Such extra logic also is consistent
across platforms (e.g. see browser_window_gtk.cc and
bookmark_bar_gtk.cc).

Problem introduced with http://codereview.chromium.org/1461001
BUG=http://crbug.com/39559

Review URL: http://codereview.chromium.org/1594009

TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/1539017
------------------------------------------------------------------------
r43527 | mark@chromium.org | 2010-04-02 23:26:58 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   A /trunk/src/chrome/browser/cocoa/install_from_dmg.h
   A /trunk/src/chrome/browser/cocoa/install_from_dmg.mm
   M /trunk/src/chrome/chrome_browser.gypi

In-app installation when running from a disk image.

BUG=28986
TEST=Launch from a disk image without having a copy already installed in
     /Applications, and with permission to write to /Applications.
Review URL: http://codereview.chromium.org/1599011
------------------------------------------------------------------------
r43523 | rafaelw@chromium.org | 2010-04-02 23:01:39 +0200 (Fri, 02 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Add calling frame's source_url to extension and dom ui requests.

Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url.

Review URL: http://codereview.chromium.org/1605005
------------------------------------------------------------------------
r43519 | mrossetti@chromium.org | 2010-04-02 22:54:58 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Insure that the bookmark bubble comes up properly aligned when the browser is in full-screen mode and the floating bar is not showing by having the floating bar come up.

BUG=39428
TEST=1) Enter full-screen mode. Press Cmd-D and verify that the floating bar appears and that the bubble is properly aligned. Press 'Remove' and verify that the floating bar goes away.  Repeat but this time press 'Done'.  Repeat once again and this time press 'Edit' and verify that the bubble goes away but the floating bar remains until the bookmark editor is dismissed with the editor pane appearsing off the bottom of the floating bar.

2) Exit full-screen mode and perform the above exercises to insure that the bookmark bubble and bookmark edit window are still presented as expected: Press Cmd-D and verify that the bubble is properly aligned. Press 'Remove' and verify that the bubble goes away.  Repeat but this time press 'Done'.  Repeat once again and this time press 'Edit' and verify that the bubble goes and that the bookmark editor pane is presented off the bottom of the Chrome toolbar.
Review URL: http://codereview.chromium.org/1539011
------------------------------------------------------------------------
r43518 | viettrungluu@chromium.org | 2010-04-02 22:51:50 +0200 (Fri, 02 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/plugins.html

Make plugin descriptions, etc. in chrome://plugins display as LTR.

Otherwise parentheses, periods, etc. look wrong with RTL languages.

Note that for RTL languages, tables should still be layed out right-to-left (and
cells should be aligned to the right).

BUG=34306
TEST=Set your language to your favourite RTL language. Go to chrome://plugins/. Everything should look correct. Expand Details -- everything should look correct. Everything should still look correct in LTR languages as well.

Review URL: http://codereview.chromium.org/1593010
------------------------------------------------------------------------
r43515 | estade@chromium.org | 2010-04-02 22:16:32 +0200 (Fri, 02 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK browser actions toolbar fiddling:

- make the toolbar size restore properly when the toolbar is created before the model is loaded
- allow the user to right click menu items in the overflow menu

BUG=40068 (sorta)
TEST=manual

Review URL: http://codereview.chromium.org/1602003
------------------------------------------------------------------------
r43511 | mrossetti@chromium.org | 2010-04-02 21:36:20 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_button_cell.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Remove the themeing from the folder menu background, text in the folder menu items, and no longer needed calls. Changed the menu button stroke color to a lighter shade of black. Did a bit of refactoring of how bookmark buttons are created.

BUG=39428
TEST=Pop up a folder menu and insure that the background does not adopt any theme settings.

Review URL: http://codereview.chromium.org/1589005
------------------------------------------------------------------------
r43510 | feldstein@chromium.org | 2010-04-02 21:35:05 +0200 (Fri, 02 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm

Fix copying/dragging of empty folders in BMM on mac

The code was assuming there was at least one url.  There is still a js error in
the BMM on all platforms that I've run into a couple of times, but I want to
check this in while I look into that.

BUG=39229
TEST=Copy or drag an empty bookmarks folder

Review URL: http://codereview.chromium.org/1456003
------------------------------------------------------------------------
r43509 | viettrungluu@chromium.org | 2010-04-02 21:30:57 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Mac cleanup: avoid double-conversion of URL string.

BUG=none
TEST=home page text field in prefs continues to work as before

Review URL: http://codereview.chromium.org/1529011
------------------------------------------------------------------------
r43508 | dpolukhin@chromium.org | 2010-04-02 21:20:48 +0200 (Fri, 02 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h

Polish new user login screen:
- create new account should looks like link
- removed username and password labels, they should be visible as
  background text in input fields if user hasn't typed anything yet.

BUG=none
TEST=Create new account should be link on Chromium OS login screen.

Review URL: http://codereview.chromium.org/1593005
------------------------------------------------------------------------
r43503 | arv@chromium.org | 2010-04-02 20:38:53 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc

Make sure that we go to existing open bookmark manager when pressing Shift+Ctrl+B

BUG=37354
TEST=ui_test.exe --gtest_filter=BookmarksUITest.*

Review URL: http://codereview.chromium.org/1519015
------------------------------------------------------------------------
r43502 | eroman@chromium.org | 2010-04-02 20:28:52 +0200 (Fri, 02 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/net_internals/detailsview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   D /trunk/src/chrome/browser/resources/net_internals/layoutmanager.js
   M /trunk/src/chrome/browser/resources/net_internals/main.css
   M /trunk/src/chrome/browser/resources/net_internals/main.js
   M /trunk/src/chrome/browser/resources/net_internals/requestsview.js
   A /trunk/src/chrome/browser/resources/net_internals/resizableverticalsplitview.js (from /trunk/src/chrome/browser/resources/net_internals/layoutmanager.js:43430)
   A /trunk/src/chrome/browser/resources/net_internals/tabswitcherview.js
   A /trunk/src/chrome/browser/resources/net_internals/topmidbottomview.js (from /trunk/src/chrome/browser/resources/net_internals/layoutmanager.js:43430)
   M /trunk/src/chrome/browser/resources/net_internals/util.js
   A /trunk/src/chrome/browser/resources/net_internals/view.js
   M /trunk/src/chrome/chrome_browser.gypi

Add extra views to the new net internals page. This adds tabs along the top for proxy, dns, sockets, requests, and http cache subsections. The actual subviews are placeholders.

BUG=37421
Review URL: http://codereview.chromium.org/1593009
------------------------------------------------------------------------
r43498 | tonyg@chromium.org | 2010-04-02 19:48:14 +0200 (Fri, 02 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h

Upgrade fonts to receive MEDIUM request priority like scripts and
stylesheets. A detailed discussion can be found here:
http://www.stevesouders.com/blog/2009/10/13/font-face-and-performance/
http://paulirish.com/2009/fighting-the-font-face-fout/

Also, factor out resource priorities and ensure that all types are
considered.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1572013
------------------------------------------------------------------------
r43497 | skrul@chromium.org | 2010-04-02 19:36:18 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/pref_service_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/synchronized_preferences.h
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.h
   M /trunk/src/chrome/chrome_browser.gypi

Add a bunch of preferences to sync.
This includes a fix for not crashing when we encounter a preference that is not registered.

BUG=39958

Review URL: http://codereview.chromium.org/1571006
------------------------------------------------------------------------
r43492 | snej@chromium.org | 2010-04-02 19:25:43 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Mac: Register for keychain notifications on the main thread.
Fixes issues where SSL doesn't notice changes made to keychains, like
plugging in a crypto-card after Chrome launches.
BUG=37766,34767
TEST=None (manual testing)

Review URL: http://codereview.chromium.org/1575016
------------------------------------------------------------------------
r43489 | dmazzoni@chromium.org | 2010-04-02 18:05:13 +0200 (Fri, 02 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Mark OtherRedirectsDontForkProcess as FLAKY because it crashed at least
twice this morning - revisions 43472 and 43474.

BUG=32799
TEST=greenify the tree
TBR=rohitrao

Review URL: http://codereview.chromium.org/1574011
------------------------------------------------------------------------
r43487 | skrul@chromium.org | 2010-04-02 18:04:38 +0200 (Fri, 02 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/sessions/session_state.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc

Update routing info and nudge syncer in ConfigureDataTypes().
Here is an incomplete change that will reconfigure the routing info when the DTM calls ConfigureDataTypes.  Some open questions:

- How will the SBH actually nudge the syncer?  I can add a SyncManager::Nudge method if that makes sense.

- Looking at the nudge code, it looks like it is possible for nudges to get dropped on the floor.  This could be really bad since sync can't start until the syncer thread runs and downloads updates for new data types.  Is there a better way to make sure the syncer thread runs at this point?

Also, I changed the callback method used for the SBH to notify the DTM that downloads are ready by switching the raw CancelableTask instance with a RunnableMethod.  The previous version has the DTM touching the CancelableTask pointer after it was handed over to the SBH which was bad.  This should be better.

Review URL: http://codereview.chromium.org/1484001
------------------------------------------------------------------------
r43484 | kuan@chromium.org | 2010-04-02 17:53:44 +0200 (Fri, 02 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_collator.h
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc

translate infobar: sort languages in menus by application locale
- provide string16 sorting methods (there were only std::wstring sorting methods before)
- problem is fixed on win, mac, linux and chromeos

BUG=39850
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/1542009
------------------------------------------------------------------------
r43483 | tonyg@chromium.org | 2010-04-02 17:51:13 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

Fix bug which causes proxy authentication requests
to crash Debug builds.

BUG=39329
TEST=Mocking a proxy isn't trivial. Ideas?
Review URL: http://codereview.chromium.org/1355001
------------------------------------------------------------------------
r43481 | rohitrao@chromium.org | 2010-04-02 17:48:12 +0200 (Fri, 02 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 43475 - Adding "preload_engines" and "use_global_engine" preferences to Chrome side.

BUG=crosbug.com/488
TEST=none

Review URL: http://codereview.chromium.org/1546010

TBR=yusukes@chromium.org
Review URL: http://codereview.chromium.org/1520012
------------------------------------------------------------------------
r43480 | rohitrao@chromium.org | 2010-04-02 17:47:30 +0200 (Fri, 02 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Revert 43476 - Use "preload_engines" pref on Chrome side to save the list of active IMEs.
This change depends on http://codereview.chromium.org/1546010.

BUG=crosbug.com/488
TEST=manual

Review URL: http://codereview.chromium.org/1576010

TBR=yusukes@chromium.org
Review URL: http://codereview.chromium.org/1540012
------------------------------------------------------------------------
r43478 | jar@chromium.org | 2010-04-02 17:45:28 +0200 (Fri, 02 Apr 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h
   D /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc
   D /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h
   D /trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   D /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 43382 - Move fetching of fullfledged auth cookies to a time when we have the user's real profile available.  Also, enable the use of a localaccount on Chrome OS

[Valgrind was red, per investigation by rohitrao]

many of the changes here are just callsite fixes, because I changed the signature of a function.  I also moved my code into the chromeos namespace, which accounts for several other files.  The important stuff is in:

1) google_authenticator*
2) cookie_fetcher*
3) login_utils.cc
Review URL: http://codereview.chromium.org/1515003

TBR=cmasone@google.com
Review URL: http://codereview.chromium.org/1517015
------------------------------------------------------------------------
r43476 | yusukes@chromium.org | 2010-04-02 16:36:46 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Use "preload_engines" pref on Chrome side to save the list of active IMEs.
This change depends on http://codereview.chromium.org/1546010.

BUG=crosbug.com/488
TEST=manual

Review URL: http://codereview.chromium.org/1576010
------------------------------------------------------------------------
r43475 | yusukes@chromium.org | 2010-04-02 16:35:26 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adding "preload_engines" and "use_global_engine" preferences to Chrome side.

BUG=crosbug.com/488
TEST=none

Review URL: http://codereview.chromium.org/1546010
------------------------------------------------------------------------
r43473 | msneck@google.com | 2010-04-02 16:01:42 +0200 (Fri, 02 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/base/rand_util_c.h
   A /trunk/src/chrome/browser/nacl-loader.sb
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer.sb
   M /trunk/src/chrome/test/nacl/nacl_test.cc

1. Create a new sandbox type which allows access to Unix sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code)
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "--nosandbox" flag when running Mac tests.

See http://codereview.chromium.org/1234003/show and
http://codereview.chromium.org/1525005/show which were both reverted because
of problems on Mac 10.6. This change is identical except for the ";NACL"
lines in renderer.sb files and the corresponding lines in nacl-loader.sb.
Unix socket support for the sandbox changed considerably from 10.5 to 10.6.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.

Review URL: http://codereview.chromium.org/1559012
------------------------------------------------------------------------
r43465 | nkostylev@google.com | 2010-04-02 11:33:54 +0200 (Fri, 02 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/network_list.cc

Add remaining test cases for NetworkScreen.
Connecting Ethernet & Cellular network test cases.
Fix language library mock warning for CrosInProcessBrowserTest (SetImeConfig).

BUG=crosbug.com/2037
TEST=out/Debug/browser_tests --gtest_filter=NetworkScreenTest*

Review URL: http://codereview.chromium.org/1604005
------------------------------------------------------------------------
r43464 | yurys@chromium.org | 2010-04-02 10:24:26 +0200 (Fri, 02 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Repair DevTools in docked mode on Gtk. After http://codereview.chromium.org/1025005 browser hangs when switching between tabs with docked devtools or inspecting an element in a tab with docked devtools.

BUG=39716,39883

Review URL: http://codereview.chromium.org/1539008
------------------------------------------------------------------------
r43461 | feldstein@chromium.org | 2010-04-02 08:45:31 +0200 (Fri, 02 Apr 2010) | 13 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.cc
   A /trunk/src/chrome/browser/extensions/extension_bookmark_helpers.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   A /trunk/src/chrome/browser/extensions/extension_bookmarks_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarktree.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json

Add a folders_only and subtree api to bookmark manager

Adds a new API to the experimental.bookmarkManager namespace

getSubtree(id, foldersOnly, callback)

Which returns any subtree, and if foldersOnly is true, only returns the folders.
At this point, only the bookmark tree is using the new call.

BUG=39877
TEST=ExtensionBookmarksTest.*

Review URL: http://codereview.chromium.org/1611001
------------------------------------------------------------------------
r43460 | ukai@chromium.org | 2010-04-02 08:38:45 +0200 (Fri, 02 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add --websocket-live-experiment-host flag to debug websocket live experiment.

If --websocket-live-experiment-host is specified, it is used for host of websocket live experiment in debug build.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1524005
------------------------------------------------------------------------
r43454 | mattm@chromium.org | 2010-04-02 07:49:10 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h
   A /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_content_settings_table_model.h
   M /trunk/src/chrome/chrome_browser.gypi

Add TableModel for geolocation settings.

BUG=39817,39820
TEST=manual

Review URL: http://codereview.chromium.org/1534013
------------------------------------------------------------------------
r43445 | zork@chromium.org | 2010-04-02 05:45:56 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h

Fix syncing deleted autofills and properly associate when an autofill is added.

BUG=39957
TEST=Manually test.

Review URL: http://codereview.chromium.org/1546009
------------------------------------------------------------------------
r43443 | viettrungluu@chromium.org | 2010-04-02 05:29:51 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Add Flash EULA to about box on Mac (for branded builds).

BUG=none
TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link.

Review URL: http://codereview.chromium.org/1610001
------------------------------------------------------------------------
r43440 | nick@chromium.org | 2010-04-02 04:58:05 +0200 (Fri, 02 Apr 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Move enable/disable storage to prefs.

The ProfileSyncService will manage the enabled/disabled types.  Remove
CustomizeSyncWindowView's DataTypeManager dependency; it should really
just be operating on the preferences via the ProfileSyncService.

Clarify the difference between types being enabled (meaning the user
wants to sync them) versus being advertisable (meaning we support the
datatype, and advertise that the user has the option of syncing it).

BUG=34209,38340
TEST=After syncing, open the options dialog and recustomize your
options.  Verify that the enabled types from the wizard match the
initial state of the options window.  After changing the options and
hitting "accept", observe that a breakpoint in DTM::Configure gets
triggered, with exactly the new configuration set.  Verify that the
preferences are preserved on restart, as well as across Stop
Syncing / Start Syncing.

Review URL: http://codereview.chromium.org/1556009
------------------------------------------------------------------------
r43438 | tim@chromium.org | 2010-04-02 04:31:10 +0200 (Fri, 02 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc

Fix AutoFillProfile leaks in WebDataService.
TBR=akalin

Review URL: http://codereview.chromium.org/1569016
------------------------------------------------------------------------
r43437 | kbr@google.com | 2010-04-02 04:25:28 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/io_thread.cc

Fixed bugs related to the GPU process terminating unexpectedly.

BUG=40173
TEST=ran WebGL tests, killed GPU process, and reloaded page
TBR=jam

Review URL: http://codereview.chromium.org/1549013
------------------------------------------------------------------------
r43436 | jrg@chromium.org | 2010-04-02 04:24:04 +0200 (Fri, 02 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/functional/PYAUTO_TESTS
   M /trunk/src/chrome/test/functional/downloads.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.i

Add generic "json dict" entry point for pyauto commands.  Will prevent
the need to modify the automation proxy anymore.  New pyauto commands
will only need to edit pyauto.py (to add a new SendJSONCommand() call)
and browser_proxy.cc (to implement the other side).  Contrast with the
normal editing of ~8 files.

Also added WaitForAllDownloadsToComplete using new JSON path.

BUG=http://crbug.com/39274


Review URL: http://codereview.chromium.org/1547012
------------------------------------------------------------------------
r43435 | rohitrao@chromium.org | 2010-04-02 04:23:35 +0200 (Fri, 02 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Mark SessionRestoreUITest.ShareProcessesOnRestore as flaky.

BUG=40181
TEST=None
Review URL: http://codereview.chromium.org/1569015
------------------------------------------------------------------------
r43432 | dhollowa@chromium.org | 2010-04-02 04:09:37 +0200 (Fri, 02 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm

AutoFillDialogController leak fixed.

The AutoFillDialogController was leaking view controllers when dynamically adding
and removing AutoFillAddressViewController and AutoFillCreditCardViewController 
views.  Ownership of the controllers was not getting relinquished to the
NSArray containers correctly.

New checks in the unit tests now explicitly check that the controllers have a single owner.

BUG=39720
TEST=AutoFillDialogControllerTest.DeleteAddress, AutoFillDialogControllerTest.DeleteCreditCard
TBR=avi@chromium.org

Review URL: http://codereview.chromium.org/1551011
------------------------------------------------------------------------
r43428 | arv@chromium.org | 2010-04-02 03:31:01 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menubutton.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Disable most commands at startup.

Make sure we do not show the menu on right mouse botton.

BUG=40078
TEST=Open the bookmark manager and right click
Review URL: http://codereview.chromium.org/1518011
------------------------------------------------------------------------
r43427 | ericu@google.com | 2010-04-02 03:30:08 +0200 (Fri, 02 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   A /trunk/src/chrome/common/database_util.cc
   A /trunk/src/chrome/common/database_util.h
   A /trunk/src/chrome/common/web_database_observer_impl.cc (from /trunk/src/chrome/renderer/renderer_web_database_observer.cc:42568)
   A /trunk/src/chrome/common/web_database_observer_impl.h (from /trunk/src/chrome/renderer/renderer_web_database_observer.h:42568)
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   D /trunk/src/chrome/renderer/renderer_web_database_observer.cc
   D /trunk/src/chrome/renderer/renderer_web_database_observer.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h

Changes to the Browser to support Database access from Workers.
This changelist should have no visible effect until the V8
bindings for the Database get added to the Worker context in WebKit.

BUG=none
TEST=webkit layout tests

Review URL: http://codereview.chromium.org/1387001
------------------------------------------------------------------------
r43426 | tim@chromium.org | 2010-04-02 03:25:24 +0200 (Fri, 02 Apr 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/webdata/autofill_change.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/test/profile_mock.h

Changes to web database and autofill components required
to sync profiles / addresses.

The main part here is adding Refresh to the PersonalDataManager.
It changes the expectation that the PDM is the only thing modifying autofill,
which is necessary as the sync engine connects directly to the WebDatabase
on the DB thread.

The tricky part is ID generation, which I spent a great deal of time harping
over in my sync change to make sure that everything is in an eventually
consistent state.  Note that because of the way the autofill window takes an
isolated copy of the data, there *are* extremely rare cases where an edit will
get dropped - I cover this case in PersonalDataManagerTest.Refresh.

TEST=WebDataServiceTest, PersonalDataManagerTest.

Review URL: http://codereview.chromium.org/1550007
------------------------------------------------------------------------
r43424 | jrg@chromium.org | 2010-04-02 03:08:37 +0200 (Fri, 02 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Keyboard events of any kind end bookmark bar folder menus.

BUG=http://crbug.com/38268

Review URL: http://codereview.chromium.org/1572018
------------------------------------------------------------------------
r43423 | georgey@chromium.org | 2010-04-02 03:02:53 +0200 (Fri, 02 Apr 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Fix for focus issues in the AutoFill windows dialog, including #37817
BUG=37817
TEST=You should be successfully able to navigate all controls and buttons with keyboard. + info in the bug.
Review URL: http://codereview.chromium.org/1560006
------------------------------------------------------------------------
r43421 | dhollowa@chromium.org | 2010-04-02 02:54:18 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc

Remove bookmarks log message.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/1524008
------------------------------------------------------------------------
r43420 | rohitrao@chromium.org | 2010-04-02 02:44:36 +0200 (Fri, 02 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disable BrowserTest.FLAKY_SingleBeforeUnloadAfterWindowClose on mac.  It is crashy.

BUG=40150
TEST=No crashy.
Review URL: http://codereview.chromium.org/1545015
------------------------------------------------------------------------
r43419 | jrg@chromium.org | 2010-04-02 02:39:32 +0200 (Fri, 02 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc

Fix floating bookmark bar on windows.

IsBookmarkBarVisible() continues to have a consistent meaning across
platforms, but extra logic has been added to windows to be smarter
about when to show the bar.  Such extra logic also is consistent
across platforms (e.g. see browser_window_gtk.cc and
bookmark_bar_gtk.cc).

Problem introduced with http://codereview.chromium.org/1461001
BUG=http://crbug.com/39559

Review URL: http://codereview.chromium.org/1594009
------------------------------------------------------------------------
r43416 | zork@chromium.org | 2010-04-02 02:26:12 +0200 (Fri, 02 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Revert 43413 - Add a notification when the list of startup URLs change.

BUG=38557
TEST=Run two instances of chromes with difference profiles that are syncing.  Change the startup pages.  Check that the change propagates.

Review URL: http://codereview.chromium.org/1562008

TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/1539014
------------------------------------------------------------------------
r43414 | inferno@chromium.org | 2010-04-02 02:04:32 +0200 (Fri, 02 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Patch xss in nodeURL_ in chrome://downloads.

BUG=40138
Test=None
Review URL: http://codereview.chromium.org/1585012
------------------------------------------------------------------------
r43413 | zork@chromium.org | 2010-04-02 02:02:10 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service.h
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Add a notification when the list of startup URLs change.

BUG=38557
TEST=Run two instances of chromes with difference profiles that are syncing.  Change the startup pages.  Check that the change propagates.

Review URL: http://codereview.chromium.org/1562008
------------------------------------------------------------------------
r43412 | glen@chromium.org | 2010-04-02 01:50:55 +0200 (Fri, 02 Apr 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Remove the distributor logo.

Review URL: http://codereview.chromium.org/1366002
------------------------------------------------------------------------
r43411 | rsesek@chromium.org | 2010-04-02 01:50:16 +0200 (Fri, 02 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/KeywordEditor.xib
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm

[Mac] Polish the keyword/search engine editor based on feedback from the UI team.

XIB changes:
* Make the button bar 35px tall.
* Change the buttons to have Rounded Textured style.

BUG=none
TEST=Chromium --> Preferences --> Basic --> [Manage]. Bottom button bar should have a textured appearance.

Review URL: http://codereview.chromium.org/1519014
------------------------------------------------------------------------
r43410 | viettrungluu@chromium.org | 2010-04-02 01:39:37 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc

Add Flash EULA to about box on Linux/GTK (for branded builds).

BUG=none
TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link.

Review URL: http://codereview.chromium.org/1593006
------------------------------------------------------------------------
r43409 | akalin@chromium.org | 2010-04-02 01:25:40 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/plainsaslhandler.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/saslhandler.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Fix for a problem introduced by 41865 which causes sync notifications
to break for non-gmail.com accounts.

BUG=40054
TEST=manual testing

Review URL: http://codereview.chromium.org/1558013
------------------------------------------------------------------------
r43407 | sky@chromium.org | 2010-04-02 01:20:52 +0200 (Fri, 02 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/app/animation.cc
   M /trunk/src/app/animation.h
   A /trunk/src/app/animation_container.cc
   A /trunk/src/app/animation_container.h
   A /trunk/src/app/animation_container_unittest.cc
   M /trunk/src/app/animation_unittest.cc
   M /trunk/src/app/app.gyp
   M /trunk/src/app/app_base.gypi
   M /trunk/src/app/slide_animation.h
   A /trunk/src/app/test_animation_delegate.h
   M /trunk/src/app/throb_animation.cc
   M /trunk/src/app/throb_animation.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/views/animation/bounds_animator.cc
   M /trunk/src/views/animation/bounds_animator.h

Adds AnimationContainer, which can be used to group a set of
animations to have the same timer. By default each animation has one
animationcontainer, but I'm going to change the tab renderer to share
the animationcontainer so that the pulse effects happen in unison.

Also updated the BoundsAnimator so that I can use it by the TabStrip.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1575011
------------------------------------------------------------------------
r43406 | estade@chromium.org | 2010-04-02 01:19:52 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: inspect page action popups.

Forgot page actions when I wrote r42389

BUG=24477
TEST=manual
Review URL: http://codereview.chromium.org/1558019
------------------------------------------------------------------------
r43405 | arv@chromium.org | 2010-04-02 01:09:20 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/splitpane.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Add a split pane between the tree and the list.

BUG=39093
TEST=Drag the splitter. Reload the bookmark manager and the size of the tree should be persisted.

Review URL: http://codereview.chromium.org/1519016
------------------------------------------------------------------------
r43403 | ben@chromium.org | 2010-04-02 01:05:55 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc

Remove the side tab shadow. I thought I had committed this last week but I guess I did not. sky already reviewed this.

BUG=none
TEST=vista glass, make sure there's no shadow over-painting the buttons at the right of the toolbar

Review URL: http://codereview.chromium.org/1576007
------------------------------------------------------------------------
r43399 | gwilson@google.com | 2010-04-02 00:46:35 +0200 (Fri, 02 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/rlz/rlz.h

Chrome-side change to call new RLZ API.

R=cpu
BUG=none
TEST=RLZ pings should go out at most twice, and not have a time delay between

Review URL: http://codereview.chromium.org/1577006
------------------------------------------------------------------------
r43397 | nick@chromium.org | 2010-04-02 00:39:59 +0200 (Fri, 02 Apr 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/download_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/store_timestamps_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/session_state.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller.cc
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h

Make last_download_timestamp and initial_sync_ended per-datatype.

Persist them on a per-datatype basis.  Add a migration from the old
database scheme.

In DownloadUpdates, pick the datatype(s) with the lowest
last_download_timestamp; and fetch those. Keep running
DownloadUpdatesCommand until we've gotten a "no-timestamp" result when
requesting all datatypes.

BUG=33065,37359,37331,37369,37373
TEST=included unit tests.  Also, ran with Bookmark sync enabled, then added autofill the next time I started up, and observed that the incremental GetUpdates happened for autofill only, and that eventually the timestamps for bookmarks and autofill coalesced.

Review URL: http://codereview.chromium.org/1521005
------------------------------------------------------------------------
r43394 | dumi@chromium.org | 2010-04-02 00:28:49 +0200 (Fri, 02 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc

Allow cookies and other storage data in extensions even when the user
chose to block them on websites.

BUG=39454
TEST=none


Review URL: http://codereview.chromium.org/1561008
------------------------------------------------------------------------
r43393 | skerner@chromium.org | 2010-04-02 00:23:17 +0200 (Fri, 02 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Enable tests of chrome.tab.captureVisibleTab() on mac, and all tab tests on linux.

BUG=39746,37387

Review URL: http://codereview.chromium.org/1540010
------------------------------------------------------------------------
r43392 | estade@chromium.org | 2010-04-02 00:21:47 +0200 (Fri, 02 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: make the location icon a drag source.

BUG=37866
TEST=manual

Review URL: http://codereview.chromium.org/1584006
------------------------------------------------------------------------
r43388 | danno@chromium.org | 2010-04-01 23:46:42 +0200 (Thu, 01 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm

[Mac] Appearance tweaks for browser data exceptions window

Changed the appearance of the window to incorporate Alcor's feedback (see bug).

xib changes: modified the layout, size and spacing of the buttons so that they look like this: http://img59.imageshack.us/img59/1087/picture5lr.png

BUG=38208
TEST=manual tests

Review URL: http://codereview.chromium.org/1584002
------------------------------------------------------------------------
r43387 | skerner@chromium.org | 2010-04-01 23:17:00 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.h
   M /trunk/src/chrome/browser/extensions/extension_history_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_history_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/docs.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   M /trunk/src/chrome/common/extensions/docs/experimental.contextMenu.html
   D /trunk/src/chrome/common/extensions/docs/experimental.history.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/experimental.processes.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/external_extensions.html
   M /trunk/src/chrome/common/extensions/docs/faq.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   A /trunk/src/chrome/common/extensions/docs/history.html (from /trunk/src/chrome/common/extensions/docs/experimental.history.html:43366)
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n-messages.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/messaging.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/options.html
   M /trunk/src/chrome/common/extensions/docs/override.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/samples.html
   D /trunk/src/chrome/common/extensions/docs/static/experimental.history.html
   M /trunk/src/chrome/common/extensions/docs/static/experimental.html
   A /trunk/src/chrome/common/extensions/docs/static/history.html (from /trunk/src/chrome/common/extensions/docs/static/experimental.history.html:43366)
   M /trunk/src/chrome/common/extensions/docs/static/override.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/tut_analytics.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tut_oauth.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   A /trunk/src/chrome/common/page_transition_types.cc
   M /trunk/src/chrome/common/page_transition_types.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/history/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/history/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/override/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/downloads.html
   A /trunk/src/chrome/test/data/extensions/api_test/override/history
   A /trunk/src/chrome/test/data/extensions/api_test/override/history/background.html (from /trunk/src/chrome/test/data/extensions/api_test/override/history.html:43366)
   A /trunk/src/chrome/test/data/extensions/api_test/override/history/history.html
   A /trunk/src/chrome/test/data/extensions/api_test/override/history/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/override/history.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/override/newtab
   A /trunk/src/chrome/test/data/extensions/api_test/override/newtab/background.html (from /trunk/src/chrome/test/data/extensions/api_test/override/newtab.html:43366)
   A /trunk/src/chrome/test/data/extensions/api_test/override/newtab/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/override/manifest.json:43366)
   A /trunk/src/chrome/test/data/extensions/api_test/override/newtab/newtab.html (from /trunk/src/chrome/test/data/extensions/api_test/override/nonexistant.html:43366)
   D /trunk/src/chrome/test/data/extensions/api_test/override/newtab.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/nonexistant.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/test.js
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/disabled/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/enabled/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/enabled/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/experimental_disabled
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/experimental_disabled/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/experimental_disabled/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/permissions/enabled/manifest.json:43366)
   A /trunk/src/chrome/test/data/extensions/manifest_tests/override_history.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/override_invalid_page.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/override_new_tab.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/override_newtab_and_history.json

Move history API out of experimental.  Allow extensions to override history page.

BUG=32362
TEST=ExtensionApiTest.History, ExtensionApiTest.Overrides, manual testing.

Review URL: http://codereview.chromium.org/1530002
------------------------------------------------------------------------
r43385 | viettrungluu@chromium.org | 2010-04-01 23:07:02 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Mac: use chrome::k...URL constants for about box.

BUG=none
TEST=links in about dialog work as before

Review URL: http://codereview.chromium.org/1601004
------------------------------------------------------------------------
r43384 | finnur@chromium.org | 2010-04-01 22:55:44 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_infobar_apitest.cc

Mark a test as flaky on ChromeOS.

BUG=40141
TEST=None

Review URL: http://codereview.chromium.org/1575015
------------------------------------------------------------------------
r43382 | cmasone@google.com | 2010-04-01 22:47:09 +0200 (Thu, 01 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h
   A /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc
   A /trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h
   A /trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/issue_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/login_utils.cc
   M /trunk/src/chrome/browser/chromeos/login/login_utils.h
   A /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc
   M /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Move fetching of full-fledged auth cookies to a time when we have the user's real profile available.  Also, enable the use of a localaccount on Chrome OS

many of the changes here are just callsite fixes, because I changed the signature of a function.  I also moved my code into the chromeos namespace, which accounts for several other files.  The important stuff is in:

1) google_authenticator*
2) cookie_fetcher*
3) login_utils.cc
Review URL: http://codereview.chromium.org/1515003
------------------------------------------------------------------------
r43378 | oshima@chromium.org | 2010-04-01 22:25:13 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/ui_test_utils.cc

Rename RunAllPendingEvents -> RunAllPendingInMessageLoop

Looks like I screwed my git repository when I submitted a change before
and checked in only header change in ui_test_utils.h. Sorry about that.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1591004
------------------------------------------------------------------------
r43376 | shess@chromium.org | 2010-04-01 21:47:18 +0200 (Thu, 01 Apr 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

[Mac] Move star button into page-actions area of omnibox.

Removes the star button from the toolbar entirely.  Adds a
LocationBarImageView subclass for the star icon and wires it to the
RHS of the field.  Adjust the bookmark bubble to move the arrow to the
RHS and position appropriately.

BookmarkBubble.xib: outlet to view so that controller can change the arrow from left to right.

Toolbar.xib: Move reload icon to where star was, remove star icon, adjust spacing.  All spacing was adjusted to specific positions in the relevant inspector, not by mouse drag, so hopefully there's nothing awry there.

BUG=37865
TEST=No star icon on toolbar.
TEST=Optional home button adjustments should work right.
TEST=Star action in omnibox when showing an URL.
TEST=Star action can be clicked to bookmark current page.
TEST=Bookmark bubble arrow points at star like before.
TEST=Command-d brings up bookmark bubble.
TEST=Star action changes from blank to yellow depending on state.
TEST=Star action tooltip changes depending on state.

Review URL: http://codereview.chromium.org/1540009
------------------------------------------------------------------------
r43374 | tonyg@chromium.org | 2010-04-01 21:41:13 +0200 (Thu, 01 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/net/base/auth.h

Notify all active login prompts when one login prompt is submitted. This allows 
identical login prompts to dismiss themselves. 

This was originally submitted as r42770 but had to be rolled back because I
copied from a FLAKY test. Now that r43266 fixed the flakiness, this should be
good to go.

The code is exactly the same as r42770 with one exception. I added a
WaitForNavigation guard to the tab the other tab in the new test cases. This
could have also caused flakiness in the initial revision.

BUG=8914
TEST=ui_tests --gtest_filter=LoginPromptTest.*

Review URL: http://codereview.chromium.org/1528012
------------------------------------------------------------------------
r43372 | zork@chromium.org | 2010-04-01 21:40:32 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   A /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/customize_sync_window_gtk.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/chrome_browser.gypi

Add linux UI for enabling sync types.

BUG=none
TEST=Go to the sync options on Linux, and click customize

Review URL: http://codereview.chromium.org/1606003
------------------------------------------------------------------------
r43370 | rohitrao@chromium.org | 2010-04-01 21:38:39 +0200 (Thu, 01 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Fix OS_MAC -> OS_MACOSX.

Properly disables ExtensionApiTest.IncognitoPopup and BrowserActionApiTest.IncognitoBasic on Mac.  Adds BrowserActionApiTest.BrowserActionAddPopup to the list of disabled tests on mac.

BUG=42002
TEST=No test for you!
Review URL: http://codereview.chromium.org/1603003
------------------------------------------------------------------------
r43369 | sky@chromium.org | 2010-04-01 21:21:06 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Makes app tabs use the app icon instead of favicon.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1572011
------------------------------------------------------------------------
r43368 | bulach@chromium.org | 2010-04-01 21:13:15 +0200 (Thu, 01 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/geolocation_dispatcher.cc
   M /trunk/src/chrome/renderer/geolocation_dispatcher.h
   M /trunk/src/chrome/test/data/geolocation/iframes_different_origin.html

Follow-up on https://bugs.webkit.org/show_bug.cgi?id=35031:
Implements cancelGeolocationPermissionRequestForFrame()
Queues infobars.

BUG=39686,39804
TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/1573002
------------------------------------------------------------------------
r43366 | albertb@chromium.org | 2010-04-01 21:05:48 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   D /trunk/src/base/nigori.cc
   D /trunk/src/base/nigori.h
   D /trunk/src/base/nigori_unittest.cc
   A /trunk/src/chrome/browser/sync/util/nigori.cc (from /trunk/src/base/nigori.cc:43355)
   A /trunk/src/chrome/browser/sync/util/nigori.h (from /trunk/src/base/nigori.h:43355)
   A /trunk/src/chrome/browser/sync/util/nigori_unittest.cc (from /trunk/src/base/nigori_unittest.cc:43355)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Move the Nigori classes from base to sync.

BUG=none
TEST=NigoriTest

Review URL: http://codereview.chromium.org/1549012
------------------------------------------------------------------------
r43364 | estade@chromium.org | 2010-04-01 20:39:13 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h

Fix chromeos build.

Use gfx/ not base/gfx/.

BUG=none
TEST=none
TBR=rohitrao

Review URL: http://codereview.chromium.org/1523009
------------------------------------------------------------------------
r43363 | feldstein@chromium.org | 2010-04-01 20:29:29 +0200 (Thu, 01 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Enable inspection of extension popups

When developer mode is enabled from the extensions page, you can right click on
browser actions or page actions to inspect the popup.  It will stay open until
you close the Inspector (or open another popup, or close the main window, etc).

BUG=24477
TEST=Inspect the popup

Review URL: http://codereview.chromium.org/1606001
------------------------------------------------------------------------
r43362 | estade@chromium.org | 2010-04-01 20:18:03 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   D /trunk/src/base/gfx
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/notifications/notification_test_util.h
   M /trunk/src/gfx/point.h
   M /trunk/src/gfx/rect.h
   M /trunk/src/gfx/size.h

Remove base/gfx/.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/1570005
------------------------------------------------------------------------
r43361 | viettrungluu@chromium.org | 2010-04-01 20:09:42 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Show an infobar when the user is using an unsupported flag.

Patch stolen from Evan and a translatable string added:
<http://codereview.chromium.org/490019>.

BUG=40113
TEST=Run Chromium with --no-sandbox; should get an infobar warning that you're going to die young.

Review URL: http://codereview.chromium.org/1599010
------------------------------------------------------------------------
r43357 | shess@chromium.org | 2010-04-01 19:22:25 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

[Mac] Line up omnibox popup under field.

Also line up the icons.  Spacing can be adjusted later.

BUG=37865
TEST=Popup edges line up under field edges.
TEST=Popup icons and text should line up under field icon and text.

Review URL: http://codereview.chromium.org/1608001
------------------------------------------------------------------------
r43356 | jrg@chromium.org | 2010-04-01 19:17:23 +0200 (Thu, 01 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Fix bookmarks on subfolder.  Introduced with http://codereview.chromium.org/1547010
Thx to rsesek for noticing quick

BUG=40110


Review URL: http://codereview.chromium.org/1585010
------------------------------------------------------------------------
r43354 | aa@chromium.org | 2010-04-01 18:40:01 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc

Ignore invalid-looking extension ids when loading extensions.
We should also consider whether to revert the original change
so this doesn't get onto trunk.

TBR=asargent@chromium.org
BUG=40017
------------------------------------------------------------------------
r43353 | viettrungluu@chromium.org | 2010-04-01 18:20:06 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/plugins.html

Make chrome://plugins treat MIME type descriptions as HTML.

BUG=40036
TEST=MIME type descriptions should mostly show up as before. On Linux (especially?), the descriptions for the MIME type of the Java plug-in should have proper "TM" characters instead of "&#153".

Review URL: http://codereview.chromium.org/1591008
------------------------------------------------------------------------
r43349 | skerner@chromium.org | 2010-04-01 16:56:19 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/tabs_util.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js

Break the test of chrome.tab.captureVisibleTab() out of ExtensionApiTest.Tabs.

Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate.  Breaking the test this way makes the 10.6 failure easier to debug.

BUG=37387

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43101

Review URL: http://codereview.chromium.org/1520005
------------------------------------------------------------------------
r43347 | joth@chromium.org | 2010-04-01 15:42:27 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/options_util.cc

Make "Reset to Defaults" reset geolocation permissions too

BUG=38626
TEST=Allow or block a site using geolocation, select Reset To Defaults, reload page. It should re-prompt.

Review URL: http://codereview.chromium.org/1530014
------------------------------------------------------------------------
r43346 | andybons@chromium.org | 2010-04-01 15:42:20 +0200 (Thu, 01 Apr 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Fixes bug where disabling the last browser action would cause the location bar and go button to overlap with the page and wrench menus (if they were visible).

TEST=none
BUG=40003
Review URL: http://codereview.chromium.org/1555004
------------------------------------------------------------------------
r43345 | sky@chromium.org | 2010-04-01 15:38:57 +0200 (Thu, 01 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Makes tab contents look for extension whose extent contains the
current url and fetches the smallish icon if the extension is found.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1576006
------------------------------------------------------------------------
r43343 | joth@chromium.org | 2010-04-01 15:26:53 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Workaround for 40099 - disable failing test

BUG=40099
TEST=none

Review URL: http://codereview.chromium.org/1549009
------------------------------------------------------------------------
r43339 | joth@chromium.org | 2010-04-01 13:31:00 +0200 (Thu, 01 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h

Defer sending wifi data via the network provider until permission has been granted to use geolocaiton.
Also fixes a long standing todos/bugs that the host sent in the network request was not set correctly, and
location results were not always tagged against the correct source data in the cache.

BUG=39171
TEST=run with --geolocation-enabled and --log-level=0, check from logs that no location request sent until authorized.

Review URL: http://codereview.chromium.org/1541008
------------------------------------------------------------------------
r43338 | danno@chromium.org | 2010-04-01 12:57:57 +0200 (Thu, 01 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   M /trunk/src/chrome/browser/cocoa/cookie_details.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm

[Mac] add additional fields to cookie prompt for web databases

xib changes: added two new lines to the web database cookie prompt subview of the cookie details NSView, one for database description and one for expected database size. Wired bindings to the appropriate methods in the cookie details object in the same style as the existing fields.

Web database cookie prompt now looks like this: http://img208.imageshack.us/img208/9703/picture6j.png

BUG=36435
TEST=augmented unit tests and manual tests

Review URL: http://codereview.chromium.org/1582003
------------------------------------------------------------------------
r43337 | joth@chromium.org | 2010-04-01 12:48:18 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_geolocation_apitest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Flip the flag to enable geolocation by default.

BUG=39808
TEST=run browser with & withou --disable-geolocaiton.

Review URL: http://codereview.chromium.org/1534008
------------------------------------------------------------------------
r43327 | timurrrr@chromium.org | 2010-04-01 10:49:33 +0200 (Thu, 01 Apr 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc

Annotate benign race in SyncherThread::IsSyncingCurrentlySilenced()

Example of TSan report is:
WARNING: Possible data race during write of size 8 at 0xEBC2AF0: {{{
   T24 (SyncEngine_SyncerThread) (locks held: {L780}):
    #0  base::TimeTicks::operator=(base::TimeTicks) base/time.h:442
    #1  browser_sync::SyncerThread::SyncMain(browser_sync::Syncer*) chrome/browser/sync/engine/syncer_thread.cc:418
    #2  browser_sync::SyncerThread::ThreadMainLoop() chrome/browser/sync/engine/syncer_thread.cc:288
    #3  browser_sync::SyncerThread::ThreadMain() chrome/browser/sync/engine/syncer_thread.cc:408
    #4  void DispatchToMethod<browser_sync::SyncerThread, void (browser_sync::SyncerThread::*)()>(browser_sync::SyncerThread*, void (browser_sync::SyncerThread::*)(), Tuple0 const&) base/tuple.h:412
    ...
  Concurrent read(s) happened at (OR AFTER) these points:
   T0 (locks held: {}):
    #0  base::TimeTicks::operator-(base::TimeTicks) const base/time.h:447
    #1  browser_sync::SyncerThread::IsSyncingCurrentlySilenced() chrome/browser/sync/engine/syncer_thread.cc:202
    #2  browser_sync::SyncerThreadWithSyncerTest::WaitForThrottle() chrome/browser/sync/engine/syncer_thread_unittest.cc:81
    #3  browser_sync::SyncerThreadWithSyncerTest_Throttling_Test::TestBody() chrome/browser/sync/engine/syncer_thread_unittest.cc:666
    #4  testing::Test::Run() testing/gtest/src/gtest.cc:2095
}}}
Review URL: http://codereview.chromium.org/1575007
------------------------------------------------------------------------
r43325 | satorux@chromium.org | 2010-04-01 09:57:10 +0200 (Thu, 01 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   A /trunk/src/chrome/browser/chromeos/options/language_config_view_test.cc
   M /trunk/src/chrome/chrome_tests.gypi

Fix a bug where we were showing "t" in language config dialog.

Instead, we'll be showing "Others"

BUG=crosbug.com/2167

Review URL: http://codereview.chromium.org/1608002
------------------------------------------------------------------------
r43324 | ukai@chromium.org | 2010-04-01 09:48:50 +0200 (Thu, 01 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Enable disabled WebSocket tests (ExtensionApiTest.WebSocket and WorkerWebSocketLayoutTests).

These tests were not worked well, because of some bugs in websocket server
implementation for tests, in Windows XP.
This was fixed in webkit r56614 and r56774.

BUG=38225,33247,36630
TEST=pass ExtensionApiTest.WebSocket and WorkerWebSocketLayoutTests

Review URL: http://codereview.chromium.org/1575003
------------------------------------------------------------------------
r43321 | satorux@chromium.org | 2010-04-01 08:49:21 +0200 (Thu, 01 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Fix a bug that caused the add language dialog to have a huge combobox button.

With this change, the add language dialog will look just like the hangul
configuration dialog. There should be a better UI design, but this is
at least much nicer than having the huge combobox.

BUG=crosbug.com/2166
TEST=manually on netbook

Review URL: http://codereview.chromium.org/1572010
------------------------------------------------------------------------
r43320 | satorux@chromium.org | 2010-04-01 08:32:02 +0200 (Thu, 01 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc
   M /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc

Fix build errors that occur on Ubuntu 9.10

With g++ 4.4.1, ignoring return values from write() results in compilation errors:

error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result

BUG=none
TEST=built and ran the tests
out/Release/unit_tests --gtest_filter='PipeReaderTest*'
out/Release/unit_tests --gtest_filter='ExternalMetricsTest*'

Review URL: http://codereview.chromium.org/1564005
------------------------------------------------------------------------
r43319 | cevans@chromium.org | 2010-04-01 07:51:57 +0200 (Thu, 01 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Make the browser survive massive data: URIs, via various techniques:
1) Drop the URL limit from 10MB to 2MB. The browser survives without this,
but that final tweaks makes the whole data: URI attack fairly smooth (on my
admittedly powerful machine).
2) Elide the title string at kMaxTitleChars. We already have a hard title limit
but there was a path whereby the title is implied by the URL (e.g. file: and
data: etc).
3) For massive URLs, limit the length shown in URL bar. We need to support them,
because someone might redirect to a data: URI with e.g. an image in it.
However, attempting to show them would kill the browser. We can't elide them
because eliding URLs is a security risk (and would lead to correctness issues
with an edit/press enter cycle). So we show at least the origin (minus path) or
just the scheme for data: URIs


BUG=33952
TEST=NONE

Review URL: http://codereview.chromium.org/1569011
------------------------------------------------------------------------
r43314 | ukai@chromium.org | 2010-04-01 06:23:48 +0200 (Thu, 01 Apr 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.h

Refactor WebSocket Live experiment code.

Move saving result in WebSocketExperimentTask.
Add net::WebSocket::ProtocolVersion in WebSocketExperimentTask::Config.
Change Histgram managements.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1539007
------------------------------------------------------------------------
r43312 | dantasse@chromium.org | 2010-04-01 05:04:51 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   M /trunk/src/chrome/browser/views/options/customize_sync_window_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add themes to new sync UI.

BUG=34209,32414
TEST=none

Review URL: http://codereview.chromium.org/1582006
------------------------------------------------------------------------
r43309 | finnur@chromium.org | 2010-04-01 04:29:01 +0200 (Thu, 01 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc

Fix ChromeOS build (function was renamed)

TEST=None
BUG=None
TBR=oshima

Review URL: http://codereview.chromium.org/1534011
------------------------------------------------------------------------
r43308 | finnur@chromium.org | 2010-04-01 04:10:42 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h

Wire up Ctrl+Enter for Find on ToolkitViews to match GTK.

BUG=38366
TEST=Find a link, press Ctrl+Enter. Find box should close chrome should navigate the link.

Review URL: http://codereview.chromium.org/1562006
------------------------------------------------------------------------
r43307 | mattm@chromium.org | 2010-04-01 04:06:18 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Linux: On unsupported DE, show local help page about configuring proxies.

BUG=30657
TEST=unset GNOME_DESKTOP_SESSION_ID; run chrome and try to launch proxy config.

Review URL: http://codereview.chromium.org/1541007
------------------------------------------------------------------------
r43306 | jnd@chromium.org | 2010-04-01 03:53:19 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h

Add encoding override support for Chrome frame. With this change, users can override current page encoding in Chrome Frame via clicking IE's encoding menu.
Unfortunately this change does not work on IE8 since the encoding menu is off on IE8.

This change was from http://codereview.chromium.org/460036/show, which was on a temporary machine which I can not access from China now. I will re-create the patch, make some modifications according to previous reviewers' comments. now I send to you for review.

BUG=24040
TEST=none

Review URL: http://codereview.chromium.org/1530012
------------------------------------------------------------------------
r43303 | jrg@chromium.org | 2010-04-01 03:23:03 +0200 (Thu, 01 Apr 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Set bookmark bar menu windows to the correct level.

Fixes some menu awkwardness (e.g. is below the menubar and dock).
Fixes some scroll awkwardness related dock overlap.

Does NOT cause awkwardness if you Expose' which is smart enough to
hide popup menus when exposeeing.

BUG=http://crbug.com/36225


Review URL: http://codereview.chromium.org/1547010
------------------------------------------------------------------------
r43295 | andybons@chromium.org | 2010-04-01 02:26:36 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Revert 43282 - [Mac] Prep for animating the Browser Action Buttons in and out.
Also fixes bug where the go button would overlap with the page/wrench menus upon uninstalling the last extension.

BUG=40003,39200
TEST=none
Review URL: http://codereview.chromium.org/1551009

TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/1589009
------------------------------------------------------------------------
r43294 | evan@chromium.org | 2010-04-01 02:24:47 +0200 (Thu, 01 Apr 2010) | 20 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc

Port the option to import bookmarks from a file to Linux

- Call ImportNow from browser_main.cc
- Move necessary functions and a class from first_run_win.cc to
first_run.cc and update first_run.h accordingly.
- Add some #defines for different OSes and some TODO(port) comments.

These changes will allow the use of the --import-from-file option to
import bookmarks from a file at first run.

I have built and tested this on Linux and Windows.

BUG=32728
TEST=run with --import-from-file

Patch from Brian G. Merrell <bgmerrell@gmail.com>

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43277

Review URL: http://codereview.chromium.org/1515004
------------------------------------------------------------------------
r43291 | mpcomplete@chromium.org | 2010-04-01 02:15:09 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Use the infobar for installed extensions in incognito, since the browser
action will not be visible.

BUG=39763

Review URL: http://codereview.chromium.org/1535007
------------------------------------------------------------------------
r43290 | evan@chromium.org | 2010-04-01 02:12:05 +0200 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

gtk: fix display of icons in omnibox popup

This regressed in r43025.  I don't know this code; I just made it behave
like it did before that change.

BUG=40056
TEST=highlight icons in the omnibox drop-down; make sure you can see them

Review URL: http://codereview.chromium.org/1584007
------------------------------------------------------------------------
r43286 | shess@chromium.org | 2010-04-01 01:37:17 +0200 (Thu, 01 Apr 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

[Mac] Fix DCHECK() on page actions in preview.

Page actions can be image-less for a bit until their image loads.  The
image is visible and a default size is used.  The DCHECK() just wanted
to make sure that we weren't accidentally drawing an image of one size
into a rect of a different size.

BUG=37865
TEST=No DCHECK installing an extension.

Review URL: http://codereview.chromium.org/1605002
------------------------------------------------------------------------
r43285 | arv@chromium.org | 2010-04-01 01:34:30 +0200 (Thu, 01 Apr 2010) | 24 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc

Revert 43277 - Port the option to import bookmarks from a file to Linux

 Call ImportNow from browser_main.cc
 Move necessary functions and a class from first_run_win.cc to
first_run.cc and update first_run.h accordingly.
 Add some #defines for different OSes and some TODO(port) comments.

These changes will allow the use of the importfromfile option to
import bookmarks from a file at first run.

I have built and tested this on Linux and Windows.

BUG=32728
TEST=run with importfromfile

Patch from Brian G. Merrell <bgmerrell@gmail.com>

Review URL: http://codereview.chromium.org/1515004

TBR=evan@chromium.org

This broke BookmarkBarGtkBrowserTest.ClickOnFloatingTest

Review URL: http://codereview.chromium.org/1591005
------------------------------------------------------------------------
r43282 | andybons@chromium.org | 2010-04-01 01:28:41 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Prep for animating the Browser Action Buttons in and out.
Also fixes bug where the go button would overlap with the page/wrench menus upon uninstalling the last extension.

BUG=40003,39200
TEST=none
Review URL: http://codereview.chromium.org/1551009
------------------------------------------------------------------------
r43277 | evan@chromium.org | 2010-04-01 01:11:46 +0200 (Thu, 01 Apr 2010) | 18 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc

Port the option to import bookmarks from a file to Linux

- Call ImportNow from browser_main.cc
- Move necessary functions and a class from first_run_win.cc to
first_run.cc and update first_run.h accordingly.
- Add some #defines for different OSes and some TODO(port) comments.

These changes will allow the use of the --import-from-file option to
import bookmarks from a file at first run.

I have built and tested this on Linux and Windows.

BUG=32728
TEST=run with --import-from-file

Patch from Brian G. Merrell <bgmerrell@gmail.com>

Review URL: http://codereview.chromium.org/1515004
------------------------------------------------------------------------
r43275 | ctguil@chromium.org | 2010-04-01 00:43:10 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Reference external accessibility bug in comments.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/652070
------------------------------------------------------------------------
r43273 | zork@chromium.org | 2010-04-01 00:33:59 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc

Send out a notification when the bookmark bar changes.

BUG=38559
TEST=Turn on preference sync.  Run two chromes.  Press ctrl+b on one.  Ensure that the bookmark bar changes on the other.

Review URL: http://codereview.chromium.org/1589007
------------------------------------------------------------------------
r43271 | dhollowa@chromium.org | 2010-04-01 00:20:34 +0200 (Thu, 01 Apr 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Fetch AutoFill form data from server only when user data is present.

Adds code to only query the AutoFill server if the user has AutoFill profile or credit card information set up in their preferences.

BUG=39923
TEST=NONE

Review URL: http://codereview.chromium.org/1517009
------------------------------------------------------------------------
r43269 | estade@chromium.org | 2010-04-01 00:14:35 +0200 (Thu, 01 Apr 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK: fix reload button.

BUG=37866,40044
TEST=click on it

Review URL: http://codereview.chromium.org/1550005
------------------------------------------------------------------------
r43266 | tonyg@chromium.org | 2010-04-01 00:06:10 +0200 (Thu, 01 Apr 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/test/data/valgrind/ui_tests.gtest_mac.txt
   M /trunk/src/net/tools/testserver/testserver.py

Removing a clock dependent behavior in testserver which caused
TestTwoAuths and TestDigestAuth to fail when they take more than 10
seconds to send auth (which happens sometimes under valgrind).

Now the unittest can control whether it wants to receive a stale
nonce reply by requesting /auth-digest/stale. I plan to add a test
for the stale flow in a subsequent patch.

Also, this patch cleans up NavigateToURL calls in LoginPromptTest
so that they are all in-place ASSERTs. This makes the messages more
useful.

BUG=36163,25794,38580
TEST=sh tools/valgrind/chrome_tests.sh -t ui --gtest_filter=LoginPromptTest.*
Review URL: http://codereview.chromium.org/1508001
------------------------------------------------------------------------
r43265 | rohitrao@chromium.org | 2010-04-01 00:03:56 +0200 (Thu, 01 Apr 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Do not focus the location bar if it is not editable.

This brings the mac code in line with the windows code, which ignores the focus request for non-editable fields.

BUG=37387
TEST=No visible impact.
Review URL: http://codereview.chromium.org/1589004
------------------------------------------------------------------------
r43263 | jrg@chromium.org | 2010-04-01 00:02:49 +0200 (Thu, 01 Apr 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm

Make the "off the side" menu (chevron) behave like the other bookmark
bar folders.  E.g. supports DragAndDrop.

BUG=34910

TEST=Make sure you can DnD items to/from the "off the side" chevron.
Make sure context menus on those buttons work as well (e.g. delete).
Make sure the chevron is NOT draggable.
Make sure the chevron works properly as a "hover open" button when
  dragging something else around; e.g. it pops open if you hover over
  it.  (It's small so this may take patience).
Drop a folder from the bar into itself.  Make sure we don't crash.

xib change:
- chevron button is now BookmarkButton, not MenuButton.
  Also has BookmarkButtonCell in it.
- "off the side" menu removed.

Review URL: http://codereview.chromium.org/1520003
------------------------------------------------------------------------
r43262 | arv@chromium.org | 2010-03-31 23:38:45 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Fix type in test name s/DISABLE/DISABLED/

BUG=None
TEST=None
TBR=dmaclach

------------------------------------------------------------------------
r43259 | dmaclach@chromium.org | 2010-03-31 23:11:16 +0200 (Wed, 31 Mar 2010) | 20 lines
Changed paths:
   M /trunk/src/base/rand_util_c.h
   D /trunk/src/chrome/browser/nacl-loader.sb
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer.sb
   M /trunk/src/chrome/test/nacl/nacl_test.cc

Revert 43253 - 1. Create a new sandbox type which allows access to Unix sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code)
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "nosandbox" flag when running Mac tests.

See http://codereview.chromium.org/1234003/show which was reverted because of
problems on Mac 10.6. This change is identical except for the ";NACL" lines
in the *.sb files. I've removed the 10.6specific sandbox commands and used
the generic commands that work on 10.5 and 10.6. I will work on adding the
10.6specific commands in a different change list.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.

Review URL: http://codereview.chromium.org/1525005

TBR=msneck@google.com
Review URL: http://codereview.chromium.org/1572009
------------------------------------------------------------------------
r43258 | dantasse@chromium.org | 2010-03-31 23:00:56 +0200 (Wed, 31 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc

fix the build

TBR=ncarter

Review URL: http://codereview.chromium.org/1551010
------------------------------------------------------------------------
r43256 | dantasse@chromium.org | 2010-03-31 22:49:04 +0200 (Wed, 31 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   D /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac.mm
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac_unittest.mm
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   A /trunk/src/chrome/browser/views/options/customize_sync_window_view.cc
   A /trunk/src/chrome/browser/views/options/customize_sync_window_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

The "Customize Sync" dialog will let users select to sync or not sync each data type (bookmarks, preferences, etc).

The Customize Sync dialog appears if you click a button on the gaia login or the Options->Personal Stuff tab.  This button only appears if you've set the --enable-sync-preferences or --enable-sync-autofill command-line flag.
On the Gaia login, the Customize Sync button grays out when you click 'sign in'.  If the "customize sync" dialog is open, it closes when you click "cancel" on the Gaia login, and it accepts when you log in to Gaia.

Removed "Merge and Sync" from the login sequence.  Also deleted the 'merge_allowed' parameter from DataTypeController and its subclasses.

Fixed strings so they all refer to "Google Chrome/Chromium sync" instead of "Bookmark sync".

BUG=34209,27259
TEST=none

Review URL: http://codereview.chromium.org/1134002
------------------------------------------------------------------------
r43255 | sky@chromium.org | 2010-03-31 22:48:33 +0200 (Wed, 31 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc

Fixes bug in ImageLoadintTracker where it would incorrectly hit a
DCHECK if the extension doesn't have an image for a particular
resource.

BUG=none
TEST=none
TBR=aa

Review URL: http://codereview.chromium.org/1559010
------------------------------------------------------------------------
r43253 | msneck@google.com | 2010-03-31 22:35:05 +0200 (Wed, 31 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/base/rand_util_c.h
   A /trunk/src/chrome/browser/nacl-loader.sb
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer.sb
   M /trunk/src/chrome/test/nacl/nacl_test.cc

1. Create a new sandbox type which allows access to Unix sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code)
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "--nosandbox" flag when running Mac tests.

See http://codereview.chromium.org/1234003/show which was reverted because of
problems on Mac 10.6. This change is identical except for the ";NACL" lines
in the *.sb files. I've removed the 10.6-specific sandbox commands and used
the generic commands that work on 10.5 and 10.6. I will work on adding the
10.6-specific commands in a different change list.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.

Review URL: http://codereview.chromium.org/1525005
------------------------------------------------------------------------
r43251 | aa@chromium.org | 2010-03-31 22:12:26 +0200 (Wed, 31 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc

Fix NOTREACHED() in extension_prefs.cc.

BUG=40017
TBR=evan@chromium.org
------------------------------------------------------------------------
r43250 | arv@chromium.org | 2010-03-31 22:11:55 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

Fix typo

BUG=None
TEST=None
TBR=mpcomplete

------------------------------------------------------------------------
r43249 | shess@chromium.org | 2010-03-31 22:07:13 +0200 (Wed, 31 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Rearrange SSL status icon/label in omnibox.

Refactor action icons with an eye towards adding additional icons in
the future.  Renames the SSL status icon to be compatible with
pkasting's upcoming changes, and splits it between the icon on the
left and the label floating on the right.

BUG=37865
TEST=SSL icon should be to the left, and clickable.
TEST=SSL label should float to the left of page actions and not be clickable.

Review URL: http://codereview.chromium.org/1566004
------------------------------------------------------------------------
r43248 | erg@chromium.org | 2010-03-31 21:18:10 +0200 (Wed, 31 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak

BrowserThemePack: Adds persistant ids for the reload endcaps.

This makes the new reload button tinted when themed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1601002
------------------------------------------------------------------------
r43247 | finnur@chromium.org | 2010-03-31 21:16:45 +0200 (Wed, 31 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Don't apply toolstrip theming stylesheet to popups.

BUG=33284
TEST=Install a theme that uses white fonts and make
sure popup text for extension HCalendar is visible.

Tiesto theme:
https://tools.google.com/chrome/intl/en/themes/theme_at_djtiesto.html

Review URL: http://codereview.chromium.org/1517008
------------------------------------------------------------------------
r43246 | arv@chromium.org | 2010-03-31 21:13:03 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc

Disable SessionRestoreTest.RestoreOnNewWindowWithNoTabbedBrowsers on Mac and Linux since it crashes.

BUG=39476
TEST=None
TBR=dmaclach

------------------------------------------------------------------------
r43244 | thomasvl@chromium.org | 2010-03-31 20:41:26 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Use the two side by side buttons in the Under the Hood prefs as another things to force the window wider.
Also put in replacement stub text in the sync status text field so it is always two lines at layout time, the code already set it to the correct state during initialization (prevents a DCHECK in some languages).

BUG=39391
TEST=see bug
Review URL: http://codereview.chromium.org/1535009
------------------------------------------------------------------------
r43243 | thomasvl@chromium.org | 2010-03-31 20:40:53 +0200 (Wed, 31 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ClearBrowsingData.xib
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm

[Mac] Collect the max anything in the window had to grow, and grow the window to match.

BUG=39388
TEST=see bug
Review URL: http://codereview.chromium.org/1602001
------------------------------------------------------------------------
r43241 | estade@chromium.org | 2010-03-31 20:28:39 +0200 (Wed, 31 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: more location bar updates.

- resize/move the autocomplete popup.
- move the location icon to the left.
- adjust some padding values.

BUG=37866
TEST=visual

Review URL: http://codereview.chromium.org/1577003
------------------------------------------------------------------------
r43238 | glotov@google.com | 2010-03-31 20:14:19 +0200 (Wed, 31 Mar 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/mock_login_utils.h
   A /trunk/src/chrome/browser/chromeos/login/mock_update_screen.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Control flow test family added.
BUG=none
TEST=out/Debug/browser_tests --gtest_filter=WizardControllerFlowTest.ControlFlow*

Review URL: http://codereview.chromium.org/1513005
------------------------------------------------------------------------
r43237 | evan@chromium.org | 2010-03-31 20:03:35 +0200 (Wed, 31 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

gtk: Show confirmation dialog while opening a lot of bookmarks.

BUG=34481, 35911
TEST=have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. An confirmation
dialog box should be shown.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1535001
------------------------------------------------------------------------
r43236 | arv@chromium.org | 2010-03-31 20:02:49 +0200 (Wed, 31 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Disable BrowserActionApiTest.IncognitoBasic and ExtensionApiTest.IncognitoPopup on Mac since they crash intermittingly.

BUG=40002
TEST=None
TBR=dmaclach

Review URL: http://codereview.chromium.org/1558008
------------------------------------------------------------------------
r43233 | dhollowa@chromium.org | 2010-03-31 19:43:01 +0200 (Wed, 31 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field.h
   A /trunk/src/chrome/browser/autofill/credit_card_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill credit card field filling.

Adds logic to heuristically determine when credit card fields are present in a 
form and fills in user-provided credit card data into form fields when
appropriate.

BUG=38320
TEST=CreditCardFieldTest, FormStructureTest, manual testing with cc.html (attached).

Review URL: http://codereview.chromium.org/1534005
------------------------------------------------------------------------
r43230 | erg@chromium.org | 2010-03-31 19:17:29 +0200 (Wed, 31 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc

GTK translation infobar: Add break to fix tests.

TBR=kuan

Review URL: http://codereview.chromium.org/1581006
------------------------------------------------------------------------
r43229 | arv@chromium.org | 2010-03-31 19:15:18 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc

Mark SessionRestoreTest.RestoreOnNewWindowWithNoTabbedBrowsers as flaky on non windows.

BUG=39476
TEST=None
TBR=dmaclach

------------------------------------------------------------------------
r43227 | erg@chromium.org | 2010-03-31 18:58:54 +0200 (Wed, 31 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/gtk/translate_infobars.h

GTK: Match several new things that the translate toolbar does on Windows:

- Displays an error when translation fails
- Hide buttons and show a "Translating..." label while waiting for the server.
- Allow infobars to have colors other than yellow.
- Display a "Show original" button after translation

BUG=39808,39811,39814,39823
TEST=none

Review URL: http://codereview.chromium.org/1600001
------------------------------------------------------------------------
r43225 | arv@chromium.org | 2010-03-31 18:44:20 +0200 (Wed, 31 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc

Mark some incognito extension tests as flaky

ExtensionApiTest.IncognitoPopup
BrowserActionApiTest.IncognitoBasic

BUG=40002
TEST=None
TBR=dmaclach

------------------------------------------------------------------------
r43223 | nkostylev@google.com | 2010-03-31 18:29:01 +0200 (Wed, 31 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h

Clear password field on login error.
Clear error message once username/password are changed.
Change "Network not connected" error to more descriptive "Offline login failed and network not connected".

BUG=crosbug.com/1811, crosbug.com/1853
TEST=On any login error password field is cleared and focus is set to it. Error message is cleared once you time anything.

Review URL: http://codereview.chromium.org/1576005
------------------------------------------------------------------------
r43222 | skrul@chromium.org | 2010-03-31 18:23:55 +0200 (Wed, 31 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host_mock.h

Revert "Revert 42551 "Add a "download" step into the DataTypeManager""
This is just reverting a previous revert, no code changes.  This change was originally reverted due to valgrid issues that have been fixed elsewhere.

Review URL: http://codereview.chromium.org/1528010
------------------------------------------------------------------------
r43221 | dhg@chromium.org | 2010-03-31 18:19:59 +0200 (Wed, 31 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc

Changing mediaplayer so it doesn't get all the downloads, it was interfearing with playbacks.
Review URL: http://codereview.chromium.org/1541006
------------------------------------------------------------------------
r43219 | evan@chromium.org | 2010-03-31 18:08:56 +0200 (Wed, 31 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/status_icons/status_icon.cc
   M /trunk/src/chrome/browser/status_icons/status_icon.h
   M /trunk/src/chrome/browser/status_icons/status_icon_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.h
   M /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc
   M /trunk/src/chrome/browser/views/status_icons/status_tray_win_unittest.cc

Simplify the Observer Pattern used in status icons implementation.

BUG=None
TEST=compiles and everything still works as before.

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1518002
------------------------------------------------------------------------
r43216 | dmazzoni@chromium.org | 2010-03-31 17:33:01 +0200 (Wed, 31 Mar 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Keyboard accessibility for the page and app menus.
Works on Windows, and on Linux with toolkit_views.

The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.

Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.

Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.

A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.

BUG=none
TEST=New keyboard accessibility interactive ui test.

Review URL: http://codereview.chromium.org/660323
------------------------------------------------------------------------
r43207 | bulach@chromium.org | 2010-03-31 15:01:05 +0200 (Wed, 31 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h

Adds a geolocation tab in the content settings dialog on Linux.
This is based on http://codereview.chromium.org/1526004/show.

BUG=39816
TEST=Open content settings dialog, observe Location tab. (Note: Exceptions button is not wired up.)

Review URL: http://codereview.chromium.org/1590002
------------------------------------------------------------------------
r43205 | yusukes@chromium.org | 2010-03-31 14:12:42 +0200 (Wed, 31 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/language_preferences.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Moving Korean IME (ibus-hangul) preferences from IBus side (ibus-gconf & ibus-memconf) to Chrome side. This change should make it easier to sync the IME preferences with cloud.

BUG=crosbug.com/2299
BUG=crosbug.com/488
TEST=manual

Review URL: http://codereview.chromium.org/1599005
------------------------------------------------------------------------
r43202 | nkostylev@google.com | 2010-03-31 12:37:56 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/network_list.cc

Add exit test cases for Network selection screen (Ethernet & Wifi).

BUG=crosbug.com/2037
TEST=out/Debug/browser_tests --gtest_filter=NetworkScreenTest*

Review URL: http://codereview.chromium.org/1545002
------------------------------------------------------------------------
r43201 | avayvod@google.com | 2010-03-31 12:24:12 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Direct call of SetCurrentScreen instead of ShowFirstScreen for accelerator.

BUG=None
TEST=Verify that Ctrl+Alt+L switches to login screen from every other screen.

Review URL: http://codereview.chromium.org/1584004
------------------------------------------------------------------------
r43197 | satorux@chromium.org | 2010-03-31 12:00:50 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Generalize the logic for adding "configure" buttons for input methods.

BUG=crosbug.com/2001
TEST=manually

Review URL: http://codereview.chromium.org/1565003
------------------------------------------------------------------------
r43191 | thestig@chromium.org | 2010-03-31 11:05:10 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc

Fix memory leak in BrowserThemePack.

BUG=37866
TEST=Linux/CrOS Valgrind unit goes green.
TBR=estade,erg
Review URL: http://codereview.chromium.org/1551008
------------------------------------------------------------------------
r43190 | thestig@chromium.org | 2010-03-31 10:56:47 +0200 (Wed, 31 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/child_process_security_policy_browser_test.cc
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc
   M /trunk/src/chrome/test/ui/history_uitest.cc
   M /trunk/src/chrome/test/ui/layout_plugin_uitest.cc
   M /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/chrome/test/ui/pepper_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/worker/worker_uitest.cc

Merge UiTest::GetTest* and ui_test_utils::GetTest*. Convert these utility functions to use FilePaths.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1567009
------------------------------------------------------------------------
r43185 | jochen@chromium.org | 2010-03-31 10:09:45 +0200 (Wed, 31 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Reland 43183. Block database access on allowDatabase instead of databaseOpenFile. BUG=36435 TEST=Set cookie settings to ASK and open a page with web databases. Review URL: http://codereview.chromium.org/1338001
------------------------------------------------------------------------
r43184 | jochen@chromium.org | 2010-03-31 09:58:40 +0200 (Wed, 31 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Revert 43183 - Block database access on allowDatabase instead of databaseOpenFile.

BUG=36435
TEST=Set cookie settings to ASK and open a page with web databases.

Review URL: http://codereview.chromium.org/1338001

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1595003
------------------------------------------------------------------------
r43183 | jochen@chromium.org | 2010-03-31 09:36:24 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Block database access on allowDatabase instead of databaseOpenFile.

BUG=36435
TEST=Set cookie settings to ASK and open a page with web databases.

Review URL: http://codereview.chromium.org/1338001
------------------------------------------------------------------------
r43180 | jar@chromium.org | 2010-03-31 07:14:15 +0200 (Wed, 31 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_stream_parser.cc

Remove packet split experiment, and add coalescing histogram

The effort to split the packet proved to not work (presumably 
showing that the RTO was reasonably set by a SYN packet reception).
The test did show that splitting the first packet had a negative
consequence, and so the question is: How often can we coalesce
2 packets in a request into 1 packet?  The most common cause would
be a login, using a POST method to send a body, where the body is 
small.  This change creates a histogram to show percentages of 
requests that can be coalesced.

r=wtc
Review URL: http://codereview.chromium.org/1539003
------------------------------------------------------------------------
r43177 | brettw@chromium.org | 2010-03-31 06:32:30 +0200 (Wed, 31 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   M /trunk/src/webkit/glue/plugins/mac_accelerated_surface_container.cc
   M /trunk/src/webkit/glue/plugins/mac_accelerated_surface_container_manager.cc
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_stream_url.cc
   M /trunk/src/webkit/glue/plugins/plugin_stream_url.h
   A /trunk/src/webkit/glue/plugins/webplugin.cc (from /trunk/src/webkit/glue/webplugin.cc:43121)
   A /trunk/src/webkit/glue/plugins/webplugin.h (from /trunk/src/webkit/glue/webplugin.h:43121)
   A /trunk/src/webkit/glue/plugins/webplugin_delegate.h (from /trunk/src/webkit/glue/webplugin_delegate.h:43123)
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   A /trunk/src/webkit/glue/plugins/webplugin_impl.cc (from /trunk/src/webkit/glue/webplugin_impl.cc:43121)
   A /trunk/src/webkit/glue/plugins/webplugin_impl.h (from /trunk/src/webkit/glue/webplugin_impl.h:43121)
   A /trunk/src/webkit/glue/plugins/webplugin_impl_unittest.cc (from /trunk/src/webkit/glue/webplugin_impl_unittest.cc:43121)
   A /trunk/src/webkit/glue/plugins/webplugin_page_delegate.h (from /trunk/src/webkit/glue/webplugin_page_delegate.h:43121)
   A /trunk/src/webkit/glue/plugins/webplugininfo.h (from /trunk/src/webkit/glue/webplugininfo.h:43121)
   M /trunk/src/webkit/glue/webkit_glue.gypi
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   D /trunk/src/webkit/glue/webplugin.cc
   D /trunk/src/webkit/glue/webplugin.h
   D /trunk/src/webkit/glue/webplugin_delegate.h
   D /trunk/src/webkit/glue/webplugin_impl.cc
   D /trunk/src/webkit/glue/webplugin_impl.h
   D /trunk/src/webkit/glue/webplugin_impl_unittest.cc
   D /trunk/src/webkit/glue/webplugin_page_delegate.h
   D /trunk/src/webkit/glue/webplugininfo.h
   M /trunk/src/webkit/support/test_webplugin_page_delegate.h
   M /trunk/src/webkit/support/webkit_support.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Move plugin-related files in webkit/glue to webkit/glue/plugins to make them
easier to find. With a random subset of files in webkit/glue, it's impossible
to predict where you should find a file. No code change

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1559008
------------------------------------------------------------------------
r43176 | finnur@chromium.org | 2010-03-31 06:24:17 +0200 (Wed, 31 Mar 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_get_views_apitest.cc
   A /trunk/src/chrome/browser/extensions/extension_infobar_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module_constants.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/get_views
   A /trunk/src/chrome/test/data/extensions/api_test/get_views/infobar.html
   A /trunk/src/chrome/test/data/extensions/api_test/get_views/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/get_views/options.html
   A /trunk/src/chrome/test/data/extensions/api_test/get_views/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/get_views/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/infobars
   A /trunk/src/chrome/test/data/extensions/api_test/infobars/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/infobars/infobarA.html
   A /trunk/src/chrome/test/data/extensions/api_test/infobars/infobarB.html
   A /trunk/src/chrome/test/data/extensions/api_test/infobars/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/infobars/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/infobars/test.js

Adding API tests for getViews and infobars.

Also fixing a bug where the wrong window id was returned
back after creating the infobar, and changing html path param
when calling show() from htlpPath to path as requrested by aa.

TEST=See chrome_tests.gypi
BUG=26463

Review URL: http://codereview.chromium.org/1561003
------------------------------------------------------------------------
r43172 | scherkus@chromium.org | 2010-03-31 04:52:04 +0200 (Wed, 31 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Added item to Show/Hide video controls in the context menu for <video>.

Patch by sergeyu@chromium.org

http://codereview.chromium.org/1081011/show

BUG=19848
TEST=Right-click on video, toggle "Show Controls". For audio the item must be disabled.

Review URL: http://codereview.chromium.org/1589003
------------------------------------------------------------------------
r43169 | cpu@chromium.org | 2010-03-31 04:22:54 +0200 (Wed, 31 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h

Re-land sqlite diagnostics
- Forgot to update a stupid number in the tests

See http://codereview.chromium.org/1548005

BUG=27885
TEST=included


Review URL: http://codereview.chromium.org/1543006
------------------------------------------------------------------------
r43163 | thestig@chromium.org | 2010-03-31 03:11:59 +0200 (Wed, 31 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/pref_service_uitest.cc
   M /trunk/src/chrome/test/nacl/nacl_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc

cleanup: Include base/path_service.h in tests that use it.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1571004
------------------------------------------------------------------------
r43162 | rafaelw@chromium.org | 2010-03-31 03:09:42 +0200 (Wed, 31 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/notification_provider.cc
   M /trunk/src/chrome/renderer/notification_provider.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Hook up extension apps notification permission, take two

This is the chromium side of a change which will wait to land on the webkit side landing. (https://bugs.webkit.org/show_bug.cgi?id=36625)

It changes the NotificationPresenter to pass the sourceURL, rather than the SecurityOrigin in checking permission.

The full URL is required to match the app extent.

BUG=32361, 31024
TEST=NONE

Review URL: http://codereview.chromium.org/1383001
------------------------------------------------------------------------
r43161 | zelidrag@chromium.org | 2010-03-31 03:06:06 +0200 (Wed, 31 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Commiting for rginda@ cl http://codereview.chromium.org/1390003

add keyboard acclerators to login wizard 

This is to make it possible to put the login wizard into a known state for testing purposes. 
Ctrl-Alt-L navigates to the login screen, from there 
Atl-U focuses the username field 
Alt-P focuses the password field 

BUG=none
TEST=none
TBR=zelidrag@chromium.org

------------------------------------------------------------------------
r43159 | sky@chromium.org | 2010-03-31 03:04:04 +0200 (Wed, 31 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc

Fixes leak in image_loading_tracker_unittest.

TBR=aa@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1512006
------------------------------------------------------------------------
r43158 | atwilson@chromium.org | 2010-03-31 03:02:54 +0200 (Wed, 31 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.cc

views: Implemet tooltip for status icons on windows.

BUG=38993
TEST=run chrome\Debug\chrome --long-lived-extensions, move mouse through the status icon, see if a tooltip text
appears.

Patch from Thiago Farina <thiago.farina@gmail.com>

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43099

Landed as r43099.

Review URL: http://codereview.chromium.org/1378007
------------------------------------------------------------------------
r43157 | rsesek@chromium.org | 2010-03-31 03:02:17 +0200 (Wed, 31 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] Select the previous node when the last cookie in the list is deleted.

Also recursively bubble up the delete if removing a child node will leave the
parent empty. Empty parents look awkward.

BUG=33320
TEST=See bug report. Partially covered by unit tests.

Review URL: http://codereview.chromium.org/1598001
------------------------------------------------------------------------
r43156 | arv@chromium.org | 2010-03-31 02:56:57 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Mark TabRestoreUITest.RestoreIntoSameWindow as flaky.

BUT=39925
TEST=None
TBR=dmaclach

------------------------------------------------------------------------
r43155 | arv@chromium.org | 2010-03-31 02:56:38 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Mark SessionRestoreUITest.TwoWindowsCloseOneRestoreOnlyOne as flaky

BUG=39905
TEST=None
TBR=dmaclach

------------------------------------------------------------------------
r43154 | estade@chromium.org | 2010-03-31 02:53:13 +0200 (Wed, 31 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: set the new star button's ID

Fixes ViewIDTest.Basic

BUG=none
TEST=ViewIDTest.Basic
r=arv

Review URL: http://codereview.chromium.org/1578005
------------------------------------------------------------------------
r43152 | arv@chromium.org | 2010-03-31 02:11:41 +0200 (Wed, 31 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h

Revert 43143 - Implement db corruption tests for diagnostic mode
 Uses sqlite's pragma integrity_check
 Tests the 5 main databases

BUG=27885
TEST=none

Review URL: http://codereview.chromium.org/1548005

TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/1539006
------------------------------------------------------------------------
r43151 | estade@chromium.org | 2010-03-31 02:08:15 +0200 (Wed, 31 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Fix bad conflict resolution for r43146.

TBR=arv
TEST=local compile
BUG=none

Review URL: http://codereview.chromium.org/1586006
------------------------------------------------------------------------
r43147 | mpcomplete@chromium.org | 2010-03-31 01:52:24 +0200 (Wed, 31 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/base/pickle.cc
   M /trunk/src/base/pickle_unittest.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_drag_data.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_drag_data.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_drag_data_unittest.cc
   M /trunk/src/ipc/ipc_fuzzing_tests.cc

Don't allow dragging browser actions between regular and incognito windows.
This fixes a crash.

Also small fix to Pickle::ReadBytes to fix up the iterator if it is NULL.

BUG=39340

Review URL: http://codereview.chromium.org/1542007
------------------------------------------------------------------------
r43146 | estade@chromium.org | 2010-03-31 01:51:44 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   D /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   D /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: toolbar reload/star shuffle.

BUG=37866
TEST=manual

Review URL: http://codereview.chromium.org/1491003
------------------------------------------------------------------------
r43144 | estade@chromium.org | 2010-03-31 01:48:43 +0200 (Wed, 31 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   A /trunk/src/chrome/browser/gtk/extension_install_prompt2_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTK: New extension install prompt ui.

BUG=29633
TEST=manual

Review URL: http://codereview.chromium.org/1513002
------------------------------------------------------------------------
r43143 | cpu@chromium.org | 2010-03-31 01:46:17 +0200 (Wed, 31 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h

Implement db corruption tests for diagnostic mode
- Uses sqlite's pragma integrity_check
- Tests the 5 main databases

BUG=27885
TEST=none


Review URL: http://codereview.chromium.org/1548005
------------------------------------------------------------------------
r43142 | asargent@chromium.org | 2010-03-31 01:44:06 +0200 (Wed, 31 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Send ping days parameter for extension blacklist update checks

BUG=39745
TEST=Extension update in general, and blacklisting, should still work normally.


Review URL: http://codereview.chromium.org/1540003
------------------------------------------------------------------------
r43137 | brettw@chromium.org | 2010-03-30 23:02:13 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/html_dialog_view.cc

Fix potential NULL pointer error in HtmlDialogView::InitDialog.

BUG=37275
TEST=None
Checked in for jaysoffian@gmail.com
Original review: http://codereview.chromium.org/661439
------------------------------------------------------------------------
r43136 | pkasting@chromium.org | 2010-03-30 22:51:19 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc

Convert Label::GetFont() to unix_hacker style.  Original patch by Thiago Farina (see http://codereview.chromium.org/1580002 ), r=me.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1528009
------------------------------------------------------------------------
r43134 | wtc@chromium.org | 2010-03-30 22:48:15 +0200 (Tue, 30 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Do not set the whiltelist filter on the default auth handler
factory unless the --auth-server-whitelist command-line option
is specified.

R=ahendrickson,cbentzel
BUG=29596
TEST=HTTP NTLM or Negotiate authentication should work again.
Review URL: http://codereview.chromium.org/1569007
------------------------------------------------------------------------
r43133 | atwilson@chromium.org | 2010-03-30 22:44:52 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.cc

Revert 43099 - Windows implementation of StatusIcon::SetToolTip()
I will resubmit with the proper patch attribution.

TBR=atwilson@google.com
Review URL: http://codereview.chromium.org/1558006
------------------------------------------------------------------------
r43132 | pkasting@chromium.org | 2010-03-30 22:42:33 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   A /trunk/src/chrome/browser/views/options/plugin_filter_page_view.cc
   A /trunk/src/chrome/browser/views/options/plugin_filter_page_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Adds a geolocation tab in the content settings dialog (on Windows).  Also refactors the various views for this dialog in hopes of simplifying a few things.

BUG=none
TEST=Open content settings dialog, observe Location tab.  (Note: Exceptions button is not wired up.)
Review URL: http://codereview.chromium.org/1526004
------------------------------------------------------------------------
r43130 | sky@chromium.org | 2010-03-30 22:40:18 +0200 (Tue, 30 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   A /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc (from /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc:43007)
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h

Attempt 2 at landing this. Patch is exactly same as last time around.

Adds ability for ImageLoadingTracker to cache images.

BUG=none
TEST=none
TBR=aa@chromium.org

Review URL: http://codereview.chromium.org/1534006
------------------------------------------------------------------------
r43129 | zork@chromium.org | 2010-03-30 22:37:03 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc

Fix and resubmit 42959

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1508005
------------------------------------------------------------------------
r43128 | akalin@chromium.org | 2010-03-30 22:35:15 +0200 (Tue, 30 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc

Fixed a bug where themes wouldn't sync properly if it had been installed
before.

Did some refactoring and fixed comments.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/1543004
------------------------------------------------------------------------
r43125 | andybons@chromium.org | 2010-03-30 22:30:50 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

[Mac] Get rid of the custom run loop for dragging the Browser Actions container, update cursors properly and fix a bug where a newly added extension would be put in the overflow menu if all extensions were shown.

BUG=36697
TEST=none
Review URL: http://codereview.chromium.org/1581003
------------------------------------------------------------------------
r43124 | brettw@chromium.org | 2010-03-30 22:07:59 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Prevent warning on Mac about uninitialized variable by initializing the
variable in the failure case.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1534007
------------------------------------------------------------------------
r43123 | brettw@chromium.org | 2010-03-30 21:52:47 +0200 (Tue, 30 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/third_party/npapi/bindings/npapi_extensions.h
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   A /trunk/src/webkit/glue/plugins/webplugin_file_delegate.h
   M /trunk/src/webkit/glue/webplugin_delegate.h

Extend the file browser/chooser to support more modes of operation, and plumb
it through to the pepper API. This pepper API just supports adding the filename
to the "upload files" whitelist and returning it to the plugin, but it does not
actually give any ability for a sandboxed plugin to read the file (this will
come in a separate changelist).

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1094004
------------------------------------------------------------------------
r43122 | evan@chromium.org | 2010-03-30 21:47:41 +0200 (Tue, 30 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   M /trunk/src/chrome/test/nacl/nacl_test.cc

linux: enable seccomp sandbox by default

It seems the best way to keep the seccomp sandbox working is to have
everyone's development environment have it on by default.  So we turn
on the seccomp sandbox, but only for non-official builds.

If the build-time flag is set: --disable-seccomp-sandbox turns it off.
If the build-time flag is *not* set: --enable-seccomp-sandbox turns it on.

BUG=36133

Review URL: http://codereview.chromium.org/1558003
------------------------------------------------------------------------
r43119 | arv@chromium.org | 2010-03-30 21:13:58 +0200 (Tue, 30 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js

BMM: Wait until the the text input gets focus before updating its size.

BUG=39364
TEST=Select the "Bookmarks bar" tree item. Right click and do new folder. The text "New folder" should not be clipped.


Review URL: http://codereview.chromium.org/1534004
------------------------------------------------------------------------
r43118 | avayvod@google.com | 2010-03-30 21:11:40 +0200 (Tue, 30 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/login/mock_screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/login/wizard_in_process_browser_test.cc
   A /trunk/src/chrome/browser/chromeos/login/wizard_in_process_browser_test.h
   M /trunk/src/chrome/chrome_tests.gypi

Fixed flakiness of AccountScreenTest:
- test server to serve account creation page
- deferred creation of login windows to tune account screen for testing
- refactored InProcessBrowserTest to shutdown test reliably.

BUG=39310
TEST=Run browser_tests with --gtest_filter=AccountScreenTest.*

Review URL: http://codereview.chromium.org/1452001
------------------------------------------------------------------------
r43116 | pkasting@chromium.org | 2010-03-30 20:32:32 +0200 (Tue, 30 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm

Revert 43111 - Make the location content setting tab be dependent on the enablegeolocation switch

BUG=39806
TEST=run browser with and without the enablegeolocation flag, and open the content settings page. (restart browser when Location tab was selected as current tab)

Review URL: http://codereview.chromium.org/1575005

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/1540006
------------------------------------------------------------------------
r43114 | arv@chromium.org | 2010-03-30 20:30:01 +0200 (Tue, 30 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Use dropEffect move now that it works.

BUG=38591
TEST=Drag bookmarks inside the bookmark manager. The move cursor should be shown.
     Rearrange thumbnails on the new tab page using DnD. The move icon should be used.

Review URL: http://codereview.chromium.org/1563003
------------------------------------------------------------------------
r43112 | bauerb@chromium.org | 2010-03-30 20:16:52 +0200 (Tue, 30 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h

Make repost form warning tab-modal on Windows.

Also, add a type ConstrainedDialogDelegate that is used for constrained windows that show a dialog. In a future CL, Mac and Gtk will be changed to use that type.

BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should hitting the reload button again, or bringing up the warning while a login form is shown.

Review URL: http://codereview.chromium.org/1138009
------------------------------------------------------------------------
r43111 | joth@chromium.org | 2010-03-30 20:15:32 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm

Make the location content setting tab be dependent on the --enable-geolocation switch

BUG=39806
TEST=run browser with and without the --enable-geolocation flag, and open the content settings page. (restart browser when Location tab was selected as current tab)

Review URL: http://codereview.chromium.org/1575005
------------------------------------------------------------------------
r43110 | mpcomplete@chromium.org | 2010-03-30 20:14:40 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Fix a bug where an open incognito window's browser actions would not update
when enabling an extension to run in incognito mode.

BUG=39355

Review URL: http://codereview.chromium.org/1569003
------------------------------------------------------------------------
r43109 | skerner@chromium.org | 2010-03-30 20:03:42 +0200 (Tue, 30 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab

Revert 43101 - Break the test of chrome.tab.captureVisibleTab() out of ExtensionApiTest.Tabs.

Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate.  Breaking the test this way makes the 10.6 failure easier to debug.

BUG=37387

Review URL: http://codereview.chromium.org/1520005

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1577002
------------------------------------------------------------------------
r43102 | skrul@chromium.org | 2010-03-30 19:45:46 +0200 (Tue, 30 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix sync leaks and some more good stuff.
This is a continuation of zork's change http://codereview.chromium.org/1354001 that adds some preventitive DCHECKs througout the sync code to make sure stuff happens on the UI thread.

This also includes a leak fix in the ProfileSyncServiceTypedUrlTest.

The final change is changing the TestingProfile to return a ProfileSyncServiceMock rather than a real ProfileSyncService.  This should help prevent random test failes due to other tests that need to use the PSS.

BUG=38490,38487

Review URL: http://codereview.chromium.org/1383002
------------------------------------------------------------------------
r43101 | skerner@chromium.org | 2010-03-30 19:40:22 +0200 (Tue, 30 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/tabs_util.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js

Break the test of chrome.tab.captureVisibleTab() out of ExtensionApiTest.Tabs.

Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate.  Breaking the test this way makes the 10.6 failure easier to debug.

BUG=37387

Review URL: http://codereview.chromium.org/1520005
------------------------------------------------------------------------
r43100 | inferno@chromium.org | 2010-03-30 19:40:00 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc

Canonicalize the url based on Section 6.1 Safe Browsing Spec.

BUG=7713
TEST=SafeBrowsingUtilTest.CanonicalizeUrl
Review URL: http://codereview.chromium.org/1275002
------------------------------------------------------------------------
r43099 | atwilson@google.com | 2010-03-30 19:39:51 +0200 (Tue, 30 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/browser/views/status_icons/status_icon_win.cc

Windows implementation of StatusIcon::SetToolTip()

------------------------------------------------------------------------
r43098 | evan@chromium.org | 2010-03-30 19:29:27 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/tuple_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_xml_parser.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/common/process_watcher_posix.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h
   M /trunk/src/third_party/libjingle/files/talk/base/stringutils.h
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.cc

Minor C++ fixes found by Clang.

In cases where I've added an #include, it's generally due to Clang being
more picky about templates being available during expansions.

Review URL: http://codereview.chromium.org/1432003
------------------------------------------------------------------------
r43097 | kuan@chromium.org | 2010-03-30 19:25:35 +0200 (Tue, 30 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

en/dis-able conflicting translate infobar options
- if "always translate" options is checked, both "never translate" options are disabled
- if either or both "never translate" options are checked, "always translate" option is disabled

BUG=39174
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/1569004
------------------------------------------------------------------------
r43096 | mrossetti@chromium.org | 2010-03-30 19:24:00 +0200 (Tue, 30 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm

Revert 43041 - Remove the themeing from the folder menu background, text in the folder menu items, and no longer needed calls.

I found an easier, simpler change.

BUG=39428
TEST=Pop up a folder menu and insure that the background does not adopt any theme settings.

Review URL: http://codereview.chromium.org/1548003

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/1596001
------------------------------------------------------------------------
r43094 | nirnimesh@chromium.org | 2010-03-30 19:17:23 +0200 (Tue, 30 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/chrome_tests.gypi

Port some omnibox provider methods to Mac.

Well, I didn't really port. I just uncommented out some methods marked
UNIMPLEMENTED(). They seem to work just fine.

TEST=ui_tests --gtest_filter=OmniboxTest.* --run_omnibox_test

Review URL: http://codereview.chromium.org/1513003
------------------------------------------------------------------------
r43093 | dmaclach@chromium.org | 2010-03-30 19:12:13 +0200 (Tue, 30 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/base/rand_util_c.h
   D /trunk/src/chrome/browser/most-restrictive.sb
   A /trunk/src/chrome/browser/worker.sb (from /trunk/src/chrome/browser/worker.sb:43085)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer.sb
   M /trunk/src/chrome/test/nacl/nacl_test.cc

Revert 43086 - 1. Create a new sandbox type which allows access to Unix sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "nosandbox" flag when running Mac tests.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1234003

TBR=msneck@google.com
------------------------------------------------------------------------
r43091 | mark@chromium.org | 2010-03-30 19:03:13 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h

InfoBarController needs to be an NSTextViewDelegate after r42985.

BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/1552004
------------------------------------------------------------------------
r43086 | msneck@google.com | 2010-03-30 18:21:18 +0200 (Tue, 30 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/base/rand_util_c.h
   A /trunk/src/chrome/browser/most-restrictive.sb (from /trunk/src/chrome/browser/worker.sb:42751)
   D /trunk/src/chrome/browser/worker.sb
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer.sb
   M /trunk/src/chrome/test/nacl/nacl_test.cc

1. Create a new sandbox type which allows access to Unix sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "--nosandbox" flag when running Mac tests.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1234003
------------------------------------------------------------------------
r43084 | andybons@chromium.org | 2010-03-30 18:16:27 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host_mac.h
   M /trunk/src/chrome/browser/extensions/extension_host_mac.mm

[Mac] If a popup for an extension is shown and then the extension is killed or crashes, the popup should close for that extension.

BUG=35940
TEST=See bug for repro steps.
Review URL: http://codereview.chromium.org/1528006
------------------------------------------------------------------------
r43083 | mark@chromium.org | 2010-03-30 18:11:50 +0200 (Tue, 30 Mar 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

-[AutocompleteTextFieldEditor delegate] cleanup.

AutocompleteTextFieldEditor* requires its delegate to be an
AutocompleteTextField*.  Override the return type of -delegate and the
parameter type of -setDelegate:.  This is safe because NSTextView,
AutocompleteTextFieldEditor's superclass, uses id<NSTextViewDelegate> as the
delegate type (as of the 10.6 SDK, and just id prior), and
AutocompleteTextField* implements NSTextViewDelegate (and of course is
descended from id).

This change allows some casts and scattered type checks in this file to be
removed in favor of the cast and type check in one central location.  It also
fixes another 10.6 SDK build error caused because -delegate is more specific
than just id in that SDK.  It provides future-proofing against further errors
of this sort.

BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/1550002
------------------------------------------------------------------------
r43070 | phajdan.jr@chromium.org | 2010-03-30 12:21:27 +0200 (Tue, 30 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_win_uitest.cc
   M /trunk/src/chrome/browser/repost_form_warning_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc
   M /trunk/src/chrome/test/ui/history_uitest.cc
   M /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/v8_benchmark_uitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

[GTTF] Miscellanous UI tests cleanups:

- use built-in timeouts instead of "inventing" them in each test case
- avoid unneeded checks and operations
- use automation calls more effectively
- use FLAKY mark instead of DISABLED to maintain test coverage
- split some tests to make the above possible

TEST=UI test based
BUG=39785

Review URL: http://codereview.chromium.org/1547003
------------------------------------------------------------------------
r43064 | danno@chromium.org | 2010-03-30 10:18:41 +0200 (Tue, 30 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] display appcaches in cookie tree

xib changes:
- Added a new NSView for showing detailed information about appcaches in the cookie tree. The new view uses the same pattern as the existing views.
- Added bindings for the new view to control its visibility and the values displayed, also using the same style as the existing detail information subviews.

BUG=37459
TEST=new unit test and manual tests

Review URL: http://codereview.chromium.org/1555001
------------------------------------------------------------------------
r43062 | phajdan.jr@chromium.org | 2010-03-30 10:08:05 +0200 (Tue, 30 Mar 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/nacl/nacl_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/dromaeo_benchmark_uitest.cc
   M /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/chrome/test/ui/sunspider_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/v8_benchmark_uitest.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

[GTTF] Unify polling interval in some of the polling functions
in the UI test framework:

- WaitUntilCookieValue
- WaitUntilCookieNonEmpty
- WaitUntilJavaScriptCondition

This helps reduce number of arbitrary "magic timeouts" which are different
in each test.

We don't remove the test timeout parameter, because it varies depending on test case,
and for now we don't have a better solution. Trying a "naive" way leads to hangs
on flaky tests.

TEST=UI-based tests
BUG=none

Review URL: http://codereview.chromium.org/1557001
------------------------------------------------------------------------
r43061 | satorux@chromium.org | 2010-03-30 10:00:51 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc

Fix a bug in LanguageConfigView where it didn't update the view when a language is removed.

BUG=crosbug.com/2297
TEST=manually

Review URL: http://codereview.chromium.org/1585002
------------------------------------------------------------------------
r43059 | satorux@chromium.org | 2010-03-30 08:40:55 +0200 (Tue, 30 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Add support for multiple input methods per language in LanguageConfigView.

Along the way, refactor the code by adding SetLanguageActivated(),
This is simpler than having ActivateLanguage() and DeactivateLanguage().
The idea comes from View::SetEnabled(bool enabled).

BUG=crosbug.com/2001
TEST=manually

Review URL: http://codereview.chromium.org/1546002
------------------------------------------------------------------------
r43058 | jcivelli@chromium.org | 2010-03-30 08:34:06 +0200 (Tue, 30 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Making the translate context menu reset the blacklisting.

BUG=None
TEST=Select a site in a language different than the Chrome
     language, select never translate this site/language.
     Visit that site again, use the context menu to translate.
     The site and language should not be blacklisted for translation
     anymore.

Review URL: http://codereview.chromium.org/1551001
------------------------------------------------------------------------
r43055 | tim@chromium.org | 2010-03-30 06:55:34 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/glue/abstract_autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert 43009 - This change isn't as bad as it looks, basically it's templating the AutofillModelAssociator code so we can use it for both formfill (what I'm calling autofillV1 in this patch), and "profiles".  Since the diffs didn't line up so well from having to move some implementation to the .h (template), I'm breaking up the review here with just the formfill code rearranged and no autofill++ impl.
Review URL: http://codereview.chromium.org/1521002

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/1559005
------------------------------------------------------------------------
r43051 | twiz@chromium.org | 2010-03-30 05:45:26 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc

CL fixing a race-condition during experimental popup extension API pop-up closure.  The dismissal notification is sent asynchronously, after which the pop-up is entirely destructed.  The ExtensionPopupHost now holds a reference to the pop-up, so that it can safely make use of it during ExtensionPopupHost::DispatchPopupClosedEvent.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1512002
------------------------------------------------------------------------
r43050 | sky@chromium.org | 2010-03-30 05:40:34 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h

Makes deletion of ExtensionInstallUI happen on ui thread.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1578003
------------------------------------------------------------------------
r43049 | finnur@chromium.org | 2010-03-30 05:37:33 +0200 (Tue, 30 Mar 2010) | 37 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.h

Fix a crash when creating tabs from an Infobar by making sure 
the Infobar is not set as the Container when the Infobar dies or
its delegate dies (so that we don't get calls from the
ExtensionView after our destruction).

Some background: 

Our ExtensionInfobarDelegate owns the Infobar state, including the
ExtensionView/Host. This is because Infobars in Chrome are deleted
and recreated when you switch away from the tab and come back (and
we don't want to lose state doing so).

We also have an ExtensionInfobar object, which is set as a
"Container" for the ExtensionView, so that it can responds to
resize events from the ExtensionView.

The problem is that once chrome.tabs.create is called, a new tab
is created, which deletes the Infobar object that has yet to
receive an OnMouseLeave message from the View. Hence the crash.

We therefore null the Container in the destructor for the
ExtensionInfobar, to make sure the ExtensionView doesn't report
more events to us after we are deleted.

The only problem with this is that using the delegate_ pointer
in the destructor for ExtensionInfobar is not safe, because the
delegate may be deleted before us. Therefore, we also now observe
when the delegate is destroyed, so we can null the Container
through it.

BUG=http://crbug.com/39755
TEST=Using tabs.create should not crash the extension. Also,
opening two tabs, both with an infobar should not crash if you
switch to the first tab and close it.


Review URL: http://codereview.chromium.org/1583002
------------------------------------------------------------------------
r43044 | ctguil@chromium.org | 2010-03-30 03:49:39 +0200 (Tue, 30 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/accessibility/view_accessibility.h

[accessibility] Extension toolbar and infobar container views should not have state visible if they are not rendered on screen.

Add the ROLE_PANE role to viewsaccessibility types.

Provide accessible role and name for BrowserActionsContainer, InfoBarContainer, and InfoBar.

Set BrowserActionsContainer view visibility to true only when it contains browser actions.

Set ExtensionShelf vew visibility to true only when it has non-zero height.

BUG=36224
TEST=Verify extension toolbar and infobar container accessibility info within AccExplore32.exe

Review URL: http://codereview.chromium.org/669275
------------------------------------------------------------------------
r43043 | mrossetti@chromium.org | 2010-03-30 03:33:35 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Have the background for the URL text field in the bookmark editor present as red when the URL is not properly formed.

BUG=17612
TEST=Type an unacceptable character in the URL field or leave the URL field blank and observe a red background.

Review URL: http://codereview.chromium.org/837010
------------------------------------------------------------------------
r43042 | tim@chromium.org | 2010-03-30 03:33:07 +0200 (Tue, 30 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/protocol/autofill_specifics.proto

New autofill_specifics for autofill++ support.


Review URL: http://codereview.chromium.org/1581001
------------------------------------------------------------------------
r43041 | mrossetti@chromium.org | 2010-03-30 03:33:07 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm

Remove the themeing from the folder menu background, text in the folder menu items, and no longer needed calls.

BUG=39428
TEST=Pop up a folder menu and insure that the background does not adopt any theme settings.

Review URL: http://codereview.chromium.org/1548003
------------------------------------------------------------------------
r43038 | scherkus@chromium.org | 2010-03-30 03:26:28 +0200 (Tue, 30 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/media/video_renderer_impl.cc
   M /trunk/src/webkit/glue/media/video_renderer_impl.h
   M /trunk/src/webkit/support/webkit_support.cc

Added --enable-video-logging, which will log the presentation timestamp of video frames.

In conjunction with a log parser we can detect dropped frames and our display jitter.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1398001
------------------------------------------------------------------------
r43037 | pkasting@chromium.org | 2010-03-30 03:23:52 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host_browsertest.cc

Temporarily disable a failing piece of a ChromeOS test.  My location bar changes changed how things get focus, so it's not clear to me what the desired behavior here is.  I'll get this worked out tomorrow.

TBR=sky
BUG=none
TEST=Unittests don't fail
Review URL: http://codereview.chromium.org/1587001
------------------------------------------------------------------------
r43033 | ananta@chromium.org | 2010-03-30 02:48:45 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_manager.cc

Fix build error on Chromium Linux

TBR=inferno

Review URL: http://codereview.chromium.org/1568006
------------------------------------------------------------------------
r43031 | ananta@chromium.org | 2010-03-30 02:40:34 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_manager.cc

Fix a UMR reported on the valgrind linux build bots while running the DownloadRequestManagerTest.Allow test

TBR=inferno

Review URL: http://codereview.chromium.org/1545004
------------------------------------------------------------------------
r43029 | kbr@google.com | 2010-03-30 02:31:22 +0200 (Tue, 30 Mar 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   A /trunk/src/chrome/browser/gpu_process_host_ui_shim.cc
   A /trunk/src/chrome/browser/gpu_process_host_ui_shim.h
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_proxy.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_proxy.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/video_layer_proxy.cc
   M /trunk/src/chrome/browser/renderer_host/video_layer_proxy.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h
   M /trunk/src/chrome/renderer/gpu_channel_host.cc
   M /trunk/src/chrome/renderer/render_thread.cc

Split GpuProcessHost into GpuProcessHostUIShim, which runs on the UI
thread, and GpuProcessHost, which now runs on the IO thread and
derives from ChildProcessHost. This split was necessary in order to
service synchronous messages from the renderer process. Moved message
handlers for GPU messages from renderer to browser from
BrowserRenderProcessHost to ResourceMessageFilter.

Stopped sending multiple ViewHostMsg_EstablishGpuChannel messages from
the same renderer if the connection was already established. Resetting
the channel was causing failures in Send, and every other page reload
containing WebGL content to fail. This cleanup will allow further
simplification in the GPU process, but this is being left for a
subsequent CL.

Fixed bug in sandboxing of GPU process. Fixed latent bugs in cleanup
code in GpuChannel and GpuChannelHost. Fixed crashes in
ChildProcessHost if resource_dispatcher_host_ was NULL. Fixed apparent
latent race conditions in creation of BackingStoreProxy and
VideoLayerProxy.

With these changes, WebGL content is running in the sandbox on both
Mac and Windows. Linux support will be added in a following CL.

BUG=29120
TEST=ran WebGL demos on Mac and Windows

Review URL: http://codereview.chromium.org/1546001
------------------------------------------------------------------------
r43025 | pkasting@chromium.org | 2010-03-30 02:19:18 +0200 (Tue, 30 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_classifier.cc (from /trunk/src/chrome/browser/search_versus_navigate_classifier.cc:42491)
   A /trunk/src/chrome/browser/autocomplete/autocomplete_classifier.h (from /trunk/src/chrome/browser/search_versus_navigate_classifier.h:42491)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   D /trunk/src/chrome/browser/search_versus_navigate_classifier.cc
   D /trunk/src/chrome/browser/search_versus_navigate_classifier.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Show the location bar icon (almost) all the time, and have its contents match what the user is doing.

There are a couple major moving parts here:

* Change AutocompletePopupModel::URLsForCurrentText() to InfoForCurrentText() and have it return an AutocompleteMatch, which callers can use to parse out whatever they want.  I needed to get at the match type for the current text and found the proliferation of arguments here ridiculous.  This had major ripple effects throughout the codebase, including changing the name and location of SearchVersusNavigateClassifier as it no longer had an "is_search" parameter directly, so the name became misleading and too narrow.  I also ended up adding a null constructor for AutocompleteMatch because it was too cumbersome otherwise.

* Change the name of the "SecurityImageView" (or similar) to reflect its broader purpose, and plumb it to the edit to get an icon instead of to the toolbar model.

* Add an AutocompleteMatch::Type to icon mapping function, and use it not only in the new code but also to simplify showing the popup contents.

BUG=27570,39725
TEST=An icon should appear next to the address at all times.  It should be a globe on non-secure pages, a magnifying glass on the NTP, and a match for whatever the user is typing as he types.
Review URL: http://codereview.chromium.org/1457002
------------------------------------------------------------------------
r43024 | viettrungluu@chromium.org | 2010-03-30 02:09:42 +0200 (Tue, 30 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm

Delete unneeded scoped_nsautoreleasepool.h includes.

Presumably, people keep copying stuff from other files.

BUG=none
TEST=everything still builds

Review URL: http://codereview.chromium.org/1519009
------------------------------------------------------------------------
r43022 | erg@chromium.org | 2010-03-30 02:05:52 +0200 (Tue, 30 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc

gtk: Align the notification buttons in the right side.

BUG=34514
TEST=None

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1519001
Patch from thiago.farina@gmail.com.
------------------------------------------------------------------------
r43021 | atwilson@chromium.org | 2010-03-30 02:04:41 +0200 (Tue, 30 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/tools/valgrind/chrome_tests.py

Broke out shared worker tests into individual tests and increased worker test timeout.
Layout tests run in ui_tests can now have their timeout set via the cmd line,
and a longer timeout is passed in when valgrind is run.
BUG=39570
TEST=existing tests suffice

Review URL: http://codereview.chromium.org/1518001
------------------------------------------------------------------------
r43020 | pkasting@chromium.org | 2010-03-30 02:03:38 +0200 (Tue, 30 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Focus the location bar on any navigation to the NTP.  Specifically, this focuses it on back/forward navigations.

This becomes important for some upcoming omnibox M5 changes, and was what Glen and Scott and I agreed was the right behavior.

BUG=none
TEST=ctrl-t + navigate + click in page + hit back button = location bar focused
Review URL: http://codereview.chromium.org/1423003
------------------------------------------------------------------------
r43018 | erg@chromium.org | 2010-03-30 01:54:51 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc

GTK: Left justify label in content blocking bubble.

BUG=39540
TEST=none

Review URL: http://codereview.chromium.org/1578002
------------------------------------------------------------------------
r43017 | erg@chromium.org | 2010-03-30 01:54:18 +0200 (Tue, 30 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc

GTK: Fix notification animation so it scrolls up from the bottom right.

We need to give the window an initial position from which to animate from.

BUG=34514
TEST=Play around with http://www.html5rocks.com/samples/notifications/quick/ and make sure the notifications animate up from the bottom.

Review URL: http://codereview.chromium.org/1578001
------------------------------------------------------------------------
r43016 | ananta@chromium.org | 2010-03-30 01:52:06 +0200 (Tue, 30 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc

Marking the DownloadRequestManagerTest.Allow test as flaky as it fails randomly on the Chromium Linux 64
builder.

Bug=39753
TBR=amit

Review URL: http://codereview.chromium.org/1583001
------------------------------------------------------------------------
r43009 | tim@chromium.org | 2010-03-30 00:53:14 +0200 (Tue, 30 Mar 2010) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/glue/abstract_autofill_model_associator.h (from /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc:42880)
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

This change isn't as bad as it looks, basically it's templating the AutofillModelAssociator code so we can use it for both formfill (what I'm calling autofillV1 in this patch), and "profiles".  Since the diffs didn't line up so well from having to move some implementation to the .h (template), I'm breaking up the review here with just the formfill code re-arranged and no autofill++ impl.
Review URL: http://codereview.chromium.org/1521002
------------------------------------------------------------------------
r43008 | sky@chromium.org | 2010-03-30 00:47:57 +0200 (Tue, 30 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   D /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h

Revert 43005 - Adds ability for ImageLoadingTracker to cache images.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1251011

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1526003
------------------------------------------------------------------------
r43007 | andybons@chromium.org | 2010-03-30 00:36:52 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

[Mac] Constrain the user (for now) to only be able to reorder the visible buttons and sync the order of buttons across windows when a drag has completed.
Also fixes an issue where drag events were being intercepted by other buttons when they were not supposed to be and so stuff got shuffled around as a result.

TEST=none
BUG=39199
Review URL: http://codereview.chromium.org/1569002
------------------------------------------------------------------------
r43006 | inferno@chromium.org | 2010-03-30 00:33:15 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.h

Patch the Browser GDI crash with excessive downloads by restricting maximum number of downloads allowed at one time. When this limit is reached, we re-prompt the user.

BUG=39277
TEST=None

Review URL: http://codereview.chromium.org/1539002
------------------------------------------------------------------------
r43005 | sky@chromium.org | 2010-03-30 00:27:26 +0200 (Tue, 30 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   A /trunk/src/chrome/browser/extensions/image_loading_tracker_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_extent.cc
   M /trunk/src/chrome/common/extensions/extension_extent.h
   A /trunk/src/chrome/test/data/extensions/image_loading_tracker
   A /trunk/src/chrome/test/data/extensions/image_loading_tracker/16.png
   A /trunk/src/chrome/test/data/extensions/image_loading_tracker/24.png
   A /trunk/src/chrome/test/data/extensions/image_loading_tracker/app.json

Adds ability for ImageLoadingTracker to cache images.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1251011
------------------------------------------------------------------------
r43004 | ananta@chromium.org | 2010-03-30 00:26:20 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Disabling the ExtensionApiTest.Tabs test on linux and mac as it fails there. This test was originally
disabled for chrome os and mac.

TBR=amit
Review URL: http://codereview.chromium.org/1574002
------------------------------------------------------------------------
r43003 | davemoore@chromium.org | 2010-03-30 00:12:06 +0200 (Tue, 30 Mar 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   M /trunk/src/chrome/chrome_tests.gypi

Created test for panels

Review URL: http://codereview.chromium.org/1543001
------------------------------------------------------------------------
r43002 | inferno@chromium.org | 2010-03-30 00:09:37 +0200 (Tue, 30 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc

Fix the GTK crash by eliding extra long url,command strings in external protocol launch message.

BUG=35168
TEST=None
Review URL: http://codereview.chromium.org/1518003
------------------------------------------------------------------------
r42997 | akalin@chromium.org | 2010-03-29 23:26:25 +0200 (Mon, 29 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Changed AddPendingExtension() to treat adding an already-installed
extension as an error.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/1517001
------------------------------------------------------------------------
r42996 | zork@chromium.org | 2010-03-29 23:19:33 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc

Use the invalid file handle value instead of 0 when creating pipes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1409002
------------------------------------------------------------------------
r42994 | arv@chromium.org | 2010-03-29 23:02:00 +0200 (Mon, 29 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js

Some small bookmark manager fixes.

1. Do not limit search results to 50 items.
2. Middle clicking a bookmark should open it in a new tab
3. Clear lead/anchor item when clearing the selection.

BUG=39589, 39704, 39611
TEST=1. Search for http (or some other common term). The number of items in the result should not be limited to 50 items.
     2. Middle click on a bookmark. It should open in a new tab.
     3. See crbug.com/39611

Review URL: http://codereview.chromium.org/1508004
------------------------------------------------------------------------
r42991 | jcivelli@google.com | 2010-03-29 22:23:40 +0200 (Mon, 29 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

This CL ensures the interstitial when hidden does not call
Show on the RenderWidgetHostView.  on Windows this would cause
the tab HWND to be parented to the desktop (as Show was called
when Hide had not been called).

BUG=36290
TEST=See bug for steps.

Review URL: http://codereview.chromium.org/1388002
------------------------------------------------------------------------
r42986 | evan@chromium.org | 2010-03-29 22:18:29 +0200 (Mon, 29 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

linux: make seccomp sandbox also use OOP font loading

Within the SUID sandbox, we IPC up to the browser process when
we need to open font files.  We should do the same thing within
the seccomp sandbox.  (Note that in test_shell and in SELinux,
which uses finer grained file access permissions, we don't
need to do such a thing.)

BUG=26522

Review URL: http://codereview.chromium.org/1541002
------------------------------------------------------------------------
r42985 | thakis@chromium.org | 2010-03-29 22:14:44 +0200 (Mon, 29 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/infobar_text_field.h
   D /trunk/src/chrome/browser/cocoa/infobar_text_field.mm
   D /trunk/src/chrome/browser/cocoa/infobar_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Give links in infobars a reliable hand cursor.

Do this by switching the text from a NSTextField to a NSTextView.

xib changes: Make text field an ordinary NSTextField instead of our own subclass, connect it to labelPlaceholder_ instead of to label_.

BUG=?,22187
TEST=Open an infobar with a link (e.g. the new geolocation infobars). The cursor should become a hand on hover, and clicking the info bar should no longer put a caret in there. Other infobars (e.g. "Flash plugin crashed" when you kill the flash process on youtube) should look exactly as before. The cursor should still not become an ibeam.

Review URL: http://codereview.chromium.org/1552001
------------------------------------------------------------------------
r42984 | akalin@chromium.org | 2010-03-29 22:04:05 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/glue/theme_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/theme_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/theme_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/theme_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/theme_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/theme_util.cc
   A /trunk/src/chrome/browser/sync/glue/theme_util.h
   A /trunk/src/chrome/browser/sync/glue/theme_util_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   A /trunk/src/chrome/browser/sync/protocol/theme_specifics.proto
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Implemented initial version of themes syncing (behind a flag).

BUG=32414
TEST=manual,unittests,trybot

Review URL: http://codereview.chromium.org/1399001
------------------------------------------------------------------------
r42983 | jrg@chromium.org | 2010-03-29 22:03:46 +0200 (Mon, 29 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Dragging a file from desktop to bookmark bar should now create a bookmark.

BUG=37419

TEST=Dragging a file from desktop to bookmark bar --> creates a bookmark.
Dragging a link from content area to bookmark bar --> creates a bookmark.

Review URL: http://codereview.chromium.org/1504002
------------------------------------------------------------------------
r42982 | andybons@chromium.org | 2010-03-29 22:03:35 +0200 (Mon, 29 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm

[Mac] If the user clicks a Browser Action button when its popup is visible, the popup should close.

BUG=32161
TEST=none
Review URL: http://codereview.chromium.org/1571001
------------------------------------------------------------------------
r42981 | vandebo@chromium.org | 2010-03-29 21:58:36 +0200 (Mon, 29 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/net/base/upload_data.cc
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/base/upload_data_stream.h
   M /trunk/src/net/base/upload_data_stream_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc

Report unreadable files as size zero when uploading.
Upload zero bytes if the file size shrinks.

BUG=30850
TEST=uploading an unreadable file works

Review URL: http://codereview.chromium.org/1250002
------------------------------------------------------------------------
r42979 | erg@chromium.org | 2010-03-29 21:52:24 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc

GTK: Force the labels in the translate infobar to black.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1519007
------------------------------------------------------------------------
r42976 | kuan@chromium.org | 2010-03-29 21:40:16 +0200 (Mon, 29 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/translate/page_translated_details.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h

reland cl that implement error state for translate infobar
- original review URL: http://codereview.chromium.org/1321003
- this reland fixes uniitest build break in translate_manager_unittest.cc

BUG=38548
TEST=none yet (details in original review url)

Review URL: http://codereview.chromium.org/1542003
------------------------------------------------------------------------
r42974 | bauerb@chromium.org | 2010-03-29 21:19:06 +0200 (Mon, 29 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Fix a regression appearing in r41875 where navigating back from an interstitial page wouldn't work.

Also, factor out a method WindowDispositionShouldOpenNewTab that's used to decide if a given window disposition opens in a new tab or the current tab.

BUG=39248
TEST=SSLUITest.TestHTTPSExpiredCertAndGoBackViaButton, SSLUITest.TestHTTPSExpiredCertAndGoBackViaMenu, manual test: Go to www.google.com, then to https://ebay.com to show the HTTPS interstitial, then navigate back using the toolbar.

Review URL: http://codereview.chromium.org/1406001
------------------------------------------------------------------------
r42972 | ananta@chromium.org | 2010-03-29 21:09:43 +0200 (Mon, 29 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.h

Reverting to fix chromium linux 64 unit tests

Revert 42971 - Patch the Browser GDI crash with excessive downloads by restricting maximum number of downloads allowed at one time. When this limit is reached, we reprompt the user.

BUG=39277
TEST=None
Review URL: http://codereview.chromium.org/1417001

TBR=inferno@chromium.org
Review URL: http://codereview.chromium.org/1572001
------------------------------------------------------------------------
r42971 | inferno@chromium.org | 2010-03-29 20:41:48 +0200 (Mon, 29 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_infobar_delegate.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.h

Patch the Browser GDI crash with excessive downloads by restricting maximum number of downloads allowed at one time. When this limit is reached, we re-prompt the user.

BUG=39277
TEST=None
Review URL: http://codereview.chromium.org/1417001
------------------------------------------------------------------------
r42970 | denisromanov@chromium.org | 2010-03-29 20:34:33 +0200 (Mon, 29 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Added keyboard accelerator and hint label to skip update during OOBE by pressing ESCAPE key.
Accelerator and label are active only in non-official builds.

BUG=39279
TEST=Build Chrome with macro OFFICIAL_BUILD undefined. Run out/Debug/chrome --login-manager --login-screen=update. Label "Press ESCAPE..." should be visible, and pressing escape should cancel the update and proceed to the login screen. Build Chrome with OFFICIAL_BUILD macro defined. Run previous command, label should not be visible and pressing ESCAPE should have no effect.

Review URL: http://codereview.chromium.org/1222007
------------------------------------------------------------------------
r42968 | ananta@chromium.org | 2010-03-29 20:32:47 +0200 (Mon, 29 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc

Reverting to fix the vista sync_unit_tests failures.

Revert 42959 - Make sure we poll immediately on the first syncer loop.

BUG=36460
TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds

Review URL: http://codereview.chromium.org/1421003

TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/1568003
------------------------------------------------------------------------
r42967 | arv@chromium.org | 2010-03-29 20:30:39 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Fix issue where consecutive searches did not work.

BUG=39557
TEST=Search for a, then search for b. The list should now show the results of b.

Review URL: http://codereview.chromium.org/1537001
------------------------------------------------------------------------
r42962 | viettrungluu@chromium.org | 2010-03-29 20:07:23 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm

Minor style fixes to bookmark_pasteboard_helper_mac.mm.

BUG=none
TEST=the world keeps turning

Review URL: http://codereview.chromium.org/1538001
------------------------------------------------------------------------
r42959 | zork@chromium.org | 2010-03-29 19:57:55 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc

Make sure we poll immediately on the first syncer loop.

BUG=36460
TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds

Review URL: http://codereview.chromium.org/1421003
------------------------------------------------------------------------
r42957 | joth@chromium.org | 2010-03-29 19:46:09 +0200 (Mon, 29 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h

Fix crash: geolocation arbitrator may get deleted on wrong thread.
No need for permission context to hold scoped ref to the arbitrator, so I remvoed it.
(Note this fix still reveals bug https://bugs.webkit.org/show_bug.cgi?id=36535)

BUG=39405
TEST=open page with 2 embedded frames using geolocaiton, answer infobar prompts out of order. Should not crash

Review URL: http://codereview.chromium.org/1542002
------------------------------------------------------------------------
r42956 | erg@chromium.org | 2010-03-29 19:39:49 +0200 (Mon, 29 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc

gtk: remove obsolete TODO comment.

(The feature that the TODO states is already implemented.)

BUG=None
TEST=None

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1526002
Patch from thiago.farina@gmail.com.
------------------------------------------------------------------------
r42955 | phajdan.jr@chromium.org | 2010-03-29 19:14:32 +0200 (Mon, 29 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   D /trunk/src/chrome/browser/translate/page_translated_details.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h

Revert "implement error state for translate infobar"

Due to broken build (compile).

TBR=kuan
BUG=38548

Review URL: http://codereview.chromium.org/1567001
------------------------------------------------------------------------
r42953 | kuan@chromium.org | 2010-03-29 18:41:53 +0200 (Mon, 29 Mar 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/translate/page_translated_details.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/translate_errors.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h

implement error state for translate infobar

- this cl implements the UI on Windows and the partial backend of IPC messaging to include error type 
  - implement error state
    - add translate error types
    - use a structure as details for IPC messaging between render view and browser so as to include error type (was using std::pair)
    - translate delegate handles error state and provides mapping to error messages
    - infobar handles visual error states
    - modify background painting to handle normal and error backgrounds, and animation of cross-fading between the 2 backgrounds
  - infobar now stores state (and translation_pending flag) that it's currently displaying to user, instead of just relying on TransateInfoBarDelegate's
    - if infobar receives PAGE_TRANSLAED notification before delegate does (possible because order is not fixed), delegate's state won't be updated to be used by infobar.
    - after all the observers have received the notification, both infobar and delegate will end up with matching states, so there's no worries of out-of-sync.
  - update unittests accordingly
  - update mac and linux code accordingly to make build pass
- jay will implement the remaining backend to pass actual translate error types to the IPC message (tracked by bug 37778)

BUG=38548
TEST=none yet, until bug 37778 is also fixed.

Review URL: http://codereview.chromium.org/1321003
------------------------------------------------------------------------
r42952 | shess@chromium.org | 2010-03-29 18:41:26 +0200 (Mon, 29 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm

[Mac] Remove inappropriate checks on |preview_enabled|.

|LocationBarViewMac::PageActionImageView::UpdateVisibility()| updates
|visible_| based on |preview_enabled|.  It is called immediately after
|preview_enabled| is set.  This means that the only case
where |IsVisible()| is false but |preview_enabled| is true will be the
unit test which contrives that situation to exist.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1511001
------------------------------------------------------------------------
r42951 | bulach@chromium.org | 2010-03-29 18:38:41 +0200 (Mon, 29 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc

Fixes http://code.google.com/p/chromium/issues/detail?id=39687
On the geolocation bubble, need to StartRow() before AddView() per host.

TEST=As described in the bug.
BUG=39687

Review URL: http://codereview.chromium.org/1522002
------------------------------------------------------------------------
r42949 | phajdan.jr@chromium.org | 2010-03-29 18:21:23 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/locale_tests_uitest.cc

Re-enable locale tests on Mac. They work fine now.

TEST=ui_tests
BUG=9758

Review URL: http://codereview.chromium.org/1528004
------------------------------------------------------------------------
r42945 | viettrungluu@chromium.org | 2010-03-29 16:44:38 +0200 (Mon, 29 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm

Mac: Properly put the NSURLs on the pasteboard when dragging from web content.

Don't use the Mozilla code which (a) wasn't designed for lazy writes, and (b) is weird and kind of broken for file URLs.

BUG=29911
TEST=Should be able to drag images (from a local web page) to Finder. Other drag-and-drop functionality (from web content) should continue to work as before.

Review URL: http://codereview.chromium.org/1223005
------------------------------------------------------------------------
r42942 | nkostylev@google.com | 2010-03-29 15:15:34 +0200 (Mon, 29 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc

Add test cases for NetworkScreenTest.
Refactor CrosInProcessBrowserTest - granular mocks and expectations.
Fix PowerMenuButtonTest.

Review URL: http://codereview.chromium.org/1405001
------------------------------------------------------------------------
r42939 | yurys@chromium.org | 2010-03-29 11:11:13 +0200 (Mon, 29 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Fix console errors logged from chrome://extensions page. void is a unary operator and it shouldn't be called as 0-arguments function.

BUG=29062

Review URL: http://codereview.chromium.org/1516003
------------------------------------------------------------------------
r42937 | danno@chromium.org | 2010-03-29 10:20:10 +0200 (Mon, 29 Mar 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   M /trunk/src/chrome/browser/cocoa/cookie_details.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.mm

[Mac] Implement cookie prompt for appcaches

xib changes:
- Add a new subview to the details view for displaying appcache information in the cookie prompt. It is in the style of the existing views.
- The new view has a single info line for the manifest url.
- The label of this line is ^IDS_COOKIES_APPLICATION_CACHE_MANIFEST_LABEL
- The value is bound to content.details.manifestURL
- "hidden" binding set to content.details.shouldShowAppCachePromptDetailsView with a NSBNegateBoolean transformer OR selection.@count with a NSNegateBoolean transformer.
- Adjusted the layout of all of the details subviews, labels and values slightly to improve spacing and make it consistent

Screenshot of prompt for appcache available here:
http://img156.imageshack.us/img156/5941/picture2hj.png
http://img404.imageshack.us/img404/3747/picture3bi.png
Screenshot of adjusted cookie prompt with settable expiration:
http://img337.imageshack.us/img337/2296/picture4g.png

BUG=39288
TEST=manual testing, new unit tests

Review URL: http://codereview.chromium.org/1296005
------------------------------------------------------------------------
r42936 | jochen@chromium.org | 2010-03-29 09:53:54 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc

Show detail link and Accept/Cancel buttons should be on same horizontal line in cookie prompt.

BUG=38979
TEST=set cookie settings to ask, go to google.com

Review URL: http://codereview.chromium.org/1394004
------------------------------------------------------------------------
r42935 | jochen@chromium.org | 2010-03-29 09:21:13 +0200 (Mon, 29 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   A /trunk/src/chrome/browser/browsing_data_database_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/chrome_tests.gypi

Don't show extension state in cookie tree list.

BUG=38659
TEST=Unit tests in browsing_data_local_storage_helper_unittest.cc and browsing_data_database_helper_unittest.cc

Review URL: http://codereview.chromium.org/1405002
Patch from Mattias Nissler.
------------------------------------------------------------------------
r42933 | georgey@chromium.org | 2010-03-29 07:50:37 +0200 (Mon, 29 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download.cc
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   A /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/chrome_tests.gypi

Reverted back change #1337001, fixing the unit tests in chromium builds:
Second part of the integration with autofill servers.
1. Corrected signature calculations.
2. Added unit-test
3. Fixed numerous issues, including multiple forms on the page, etc.
BUG=none
TEST=should work correctly with more servers. 
Review URL: http://codereview.chromium.org/1516001
------------------------------------------------------------------------
r42932 | jcivelli@chromium.org | 2010-03-29 07:48:25 +0200 (Mon, 29 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Fixing the translate menu behavior.
The correct behavior is to always have the menu showing,
it is disabled when the page is translated or a Chrome page
(new tab page, history...).
Selecting the translate menu triggers a translation of the
page to the Chrome UI language.

BUG=35480
TEST=Open the page context menu on the new tab page. There
     should be a translate menu and it should be disabled.
     Navigate to a page in a foreign language. Opne the
     context menu. The translate menu should be enabled.
     Select it. The page should be translated. Open the
     context menu again on the translated page. The
     translate menu should be disabled.
     
Review URL: http://codereview.chromium.org/1402003
------------------------------------------------------------------------
r42924 | hbono@chromium.org | 2010-03-29 05:45:07 +0200 (Mon, 29 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

A workaround fix for Issue 26880.
Same as Safari, this change just finishes an ongoing IME composition and reset the IME state when a renderer requests.

BUG=26880
TEST=Enable a Chinese IME, type "baobao", click outside from the candidate window, and check if the candidate window is closed.
Review URL: http://codereview.chromium.org/661069
------------------------------------------------------------------------
r42923 | thakis@chromium.org | 2010-03-29 03:53:43 +0200 (Mon, 29 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm

Mac: Fill in geolocation bubble from model.

xib changes: Removed everything above the horizontal line and put an empty NSView there, as container for the geo stuff (maybe later, there should be only one xib file for all bubble types and the container should be filled from the bubble model in all cases. Not in this CL.)

http://imgur.com/AtXiq

BUG=11246
TEST=Start chromium with --enable-geolocation. Go to http://maxheapsize.com/static/html5geolocationdemo.html , click "Allow" or "Deny". Bubble should appear. It should behave like on windows or linux (except that it has buttons instead of links. We only use links for stuff that opens web pages on clicking on OS X.)

Review URL: http://codereview.chromium.org/1542001
------------------------------------------------------------------------
r42921 | oshima@chromium.org | 2010-03-28 18:28:52 +0200 (Sun, 28 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/test/ui_test_utils.h

* Add / exhanced tests for state transition.
* Found and fixed the following bug in this test. (yay!)
   minimize if no sticky / new notification exists after Remove
* Replaced RunAllPending with InProcessBrowserTest::RunAllPendingEvents

BUG=http://crosbug/2027
TEST=two new browser tests and one updated browser test.

Review URL: http://codereview.chromium.org/1357005
------------------------------------------------------------------------
r42920 | oshima@chromium.org | 2010-03-28 18:10:37 +0200 (Sun, 28 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/chrome_tests.gypi

Added two browser tests for CompactLocationBarHost.
Changed to use ui_controls::SendKeyPress instead of its own.

BUG=http://crosbug.com/2028
TEST=two new browser tests for CompactLocationBarHost.

Review URL: http://codereview.chromium.org/1463002
------------------------------------------------------------------------
r42915 | viettrungluu@chromium.org | 2010-03-28 01:55:05 +0100 (Sun, 28 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/app_launcher_ui.cc
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/browser/resources/mediaplayer.html

Style (indent/spacing) fixes in DOM UI + comment fix.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1529001
------------------------------------------------------------------------
r42913 | akalin@chromium.org | 2010-03-27 23:28:41 +0100 (Sat, 27 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Fixed memory leak in unittest introduced by 42899.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/1528001
------------------------------------------------------------------------
r42899 | akalin@chromium.org | 2010-03-27 07:39:31 +0100 (Sat, 27 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Fill in a default update_url for extensions with none.

Refactored ManifestFetchesBuilder for unit tests.  Added a few
unit tests.

BUG=28750
TEST=unittests

Review URL: http://codereview.chromium.org/1402001
------------------------------------------------------------------------
r42891 | jhawkins@chromium.org | 2010-03-27 03:19:15 +0100 (Sat, 27 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager.h
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_unittest.cc

AutoFill: Handle filling select controls.

BUG=38222
TEST=none

Review URL: http://codereview.chromium.org/1309003
------------------------------------------------------------------------
r42888 | kkanetkar@chromium.org | 2010-03-27 02:36:43 +0100 (Sat, 27 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/appcache/view_appcache_internals_job_factory.cc
   A /trunk/src/chrome/browser/appcache/view_appcache_internals_job_factory.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/net/url_request/url_request_simple_job.h
   A /trunk/src/webkit/appcache/view_appcache_internals_job.cc
   A /trunk/src/webkit/appcache/view_appcache_internals_job.h
   M /trunk/src/webkit/appcache/webkit_appcache.gypi

A basic implementation of information about appcache. Lists manifest files, time and size information.


BUG=38463
TEST=Run chrome, navigate to about:appcache-internals.

Review URL: http://codereview.chromium.org/1109009
------------------------------------------------------------------------
r42886 | jam@chromium.org | 2010-03-27 02:06:01 +0100 (Sat, 27 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_view.cc

Use internal pdf plugin with --internal-pdf
Review URL: http://codereview.chromium.org/1462001
------------------------------------------------------------------------
r42884 | thestig@chromium.org | 2010-03-27 01:56:43 +0100 (Sat, 27 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_shutdown.cc

POSIX: Re-enable browser shutdown measurements. We should write the measurements to the user data directory instead of the temp directory.

BUG=39098
TEST=none
Review URL: http://codereview.chromium.org/1253006
------------------------------------------------------------------------
r42882 | jhawkins@chromium.org | 2010-03-27 01:49:48 +0100 (Sat, 27 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

gtk: Implement handling for the "Default Profile/Credit Card" buttons in the
AutoFill dialog.  Add two new prefs to track the default profile and credit
card.

BUG=38975
TEST=none

Review URL: http://codereview.chromium.org/1480001
------------------------------------------------------------------------
r42881 | tim@chromium.org | 2010-03-27 01:46:05 +0100 (Sat, 27 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card.h
   D /trunk/src/chrome/browser/webdata/autofill_change.cc
   M /trunk/src/chrome/browser/webdata/autofill_change.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h

Hook autofill++ WebDatabase changes up to the NotificationService.

TEST=WebDataServiceAutofillTest

Review URL: http://codereview.chromium.org/1385002
------------------------------------------------------------------------
r42879 | kbr@google.com | 2010-03-27 01:23:34 +0100 (Sat, 27 Mar 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h
   M /trunk/src/chrome/renderer/ggl/ggl.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   A /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc
   A /trunk/src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Added command buffer implementation of WebGL which runs in the sandbox.
Added synchronous initialization of the channel to the GPU process, needed
to obey WebGL startup semantics. There are problems with this on the
Windows platform which will be addressed via refactoring in the
GpuProcessHost in a subsequent CL. Implemented offscreen rendering code
path in GGL / GLES2CmdDecoder for Mac OS X.

This new code path is not yet complete for all platforms and is still being
stress tested. The previous in-process WebGL implementation is currently
used when the sandbox is disabled; it will be removed in a subsequent CL.

A one-line code change in WebKit is needed after this CL lands to enable
the new code path.

BUG=29120
TEST=ran WebGL demos on command buffer implementation on Mac

Review URL: http://codereview.chromium.org/1328001
------------------------------------------------------------------------
r42869 | feldstein@chromium.org | 2010-03-27 00:54:02 +0100 (Sat, 27 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Fix an exception thrown when pasting in BMM

Since the handle(e) function is called by a separate function instead of as an
event handler when pasting, it was trying to call preventDefault on a
non-existant event and throwing an exception.

Do we need to do something for paste to prevent the system beep? I'm not sure
how to cause the beep to test it out.

Review URL: http://codereview.chromium.org/1473001
------------------------------------------------------------------------
r42853 | ananta@chromium.org | 2010-03-26 23:56:32 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc

Marking the BookmarksUITest.ShouldRedirectToExtension test as flaky as this has failed randomly on
the vista and XP builders.

Bug=39532
TBR=arv


Review URL: http://codereview.chromium.org/1429003
------------------------------------------------------------------------
r42852 | jrg@chromium.org | 2010-03-26 23:54:57 +0100 (Fri, 26 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_model_observer_for_cocoa.h
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm

Better cancel bookmark edit dialogs when needed.

BUG=39333

TEST=Create 2 windows.
Add a new folder on the bookmark bar.
Add Page... on it.
In 2nd window delete --> dialog should ben canceled.
Add a new folder on the bookmark bar.
Add Folder... on it.
In 2nd window delete it --> dialog should ben canceled.

Review URL: http://codereview.chromium.org/1476001
------------------------------------------------------------------------
r42851 | jrg@chromium.org | 2010-03-26 23:54:09 +0100 (Fri, 26 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Be more specific with bookmark bar visibility to mirror other platforms.
Fixes pyauto bookmark bar visibility test on ChromeOS.

Review URL: http://codereview.chromium.org/1461001
------------------------------------------------------------------------
r42850 | amit@chromium.org | 2010-03-26 23:53:53 +0100 (Fri, 26 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download.cc
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   D /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/chrome_tests.gypi

Reverting due to test failures on Interactive tests on Mac and Linux

Revert 42846 - Second part of the integration with autofill servers.
1. Corrected signature calculations.
2. Added unittest
3. Fixed numerous issues, including multiple forms on the page, etc.
BUG=none
TEST=should work correctly with more servers.
Review URL: http://codereview.chromium.org/1337001

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/1478001
------------------------------------------------------------------------
r42848 | mpcomplete@chromium.org | 2010-03-26 23:44:31 +0100 (Fri, 26 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Fix the logic in extensions GetCurrentWindow:
- We try to find an associated window for the calling extension page.
- If there is none (bg pages), fallback to the topmost browser window.
- If the extension is enabled in incognito, include incognito windows in the
search for "topmost".

This fixes a bug where clicking a browser action in an incognito window might open a tab in a normal window, which is confusing.

BUG=39113

Review URL: http://codereview.chromium.org/1422001
------------------------------------------------------------------------
r42846 | georgey@chromium.org | 2010-03-26 23:31:59 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_download.cc
   M /trunk/src/chrome/browser/autofill/autofill_download.h
   A /trunk/src/chrome/browser/autofill/autofill_download_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/chrome_tests.gypi

Second part of the integration with autofill servers.
1. Corrected signature calculations.
2. Added unit-test
3. Fixed numerous issues, including multiple forms on the page, etc.
BUG=none
TEST=should work correctly with more servers.
Review URL: http://codereview.chromium.org/1337001
------------------------------------------------------------------------
r42845 | andybons@chromium.org | 2010-03-26 23:31:24 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Enables drag N' drop for the buttons within the Browser Actions container. Also fixes an issue where the grippy was being shown when no Browser Actions were installed.
Known issue: You can drag the buttons outside of the container, even though they will recover by snapping back into place. This will be fixed in a further revision.

TEST=try dragging browser action buttons in order to reorder them.
BUG=26990
Review URL: http://codereview.chromium.org/1418003
------------------------------------------------------------------------
r42843 | mpcomplete@chromium.org | 2010-03-26 23:20:55 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fix a bug with incognito extensions like RSS Subscription that try to open an
extension URL in a new tab. Since we don't allow extension URLs in incognito
tabs, we need to force the tab to be in a regular window.

BUG=39351

Review URL: http://codereview.chromium.org/1392001
------------------------------------------------------------------------
r42839 | xiyuan@chromium.org | 2010-03-26 23:10:28 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc

Land Satoshi.Matsuzaki's patch for issue 16197.

BUG=16197
TEST=Verify fix for 16197.

Review URL: http://codereview.chromium.org/1448001
------------------------------------------------------------------------
r42831 | ctguil@chromium.org | 2010-03-26 22:51:04 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/accessibility/view_accessibility.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/view.h

views: [accessibility] Add support for Accessibility Value.

BUG=9604
TEST=point AccExplorer to Edit Bookmark dialog, see if everything has a MSAA information, like: Name, Role, State, Value.

Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/928001
------------------------------------------------------------------------
r42828 | finnur@chromium.org | 2010-03-26 22:44:32 +0100 (Fri, 26 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/view_types.cc
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc

Add two Extension view types: Notification and Infobars.

Also hooked them up to GetExtensionViews and consolidated
various methods of getting views into one (getViews, which
now takes an optional param type).

BUG=26463
TEST=None

Review URL: http://codereview.chromium.org/1397002
------------------------------------------------------------------------
r42827 | thakis@chromium.org | 2010-03-26 22:44:17 +0100 (Fri, 26 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm

Mac: Add geolocation content setting.

The radio button seems to be non-functional; probably the backend probably isn't there yet.

xib changes: Added a location tab to contentsettings.xib, bind its radio buttons and normal button to the new methods in the controller. In the bubble, enable the "settings" button.

BUG=11246
TEST=content settings now has a "location" tab.

Review URL: http://codereview.chromium.org/1428002
------------------------------------------------------------------------
r42826 | ananta@chromium.org | 2010-03-26 22:42:20 +0100 (Fri, 26 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Marking the CrossSiteInfiniteBeforeUnloadAsync test as flaky as it fails randomly on the valgrind
Linux builder.

It appears that this was already marked flaky in revision 42358. I synced to head and still can't get
that change.

Bug=39057
TBR=amit

Review URL: http://codereview.chromium.org/1468002
------------------------------------------------------------------------
r42825 | feldstein@chromium.org | 2010-03-26 22:40:55 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/override.html

Move onImportBegan/Ended to the regular bookmarks api

It used to live in the experimental.bookmarkManager namespace.

BUG=35320
TEST=none

Review URL: http://codereview.chromium.org/1353004
------------------------------------------------------------------------
r42820 | sky@chromium.org | 2010-03-26 22:26:06 +0100 (Fri, 26 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes bug where highlighting the close XXX menu items in the context
menu should flash mini-tabs.

BUG=none
TEST=create three tabs, pin the first two, right click on the first 
and hover over the context menu item close tabs to right,
make sure the second tab (which is pinned) doesn't highlight.

Review URL: http://codereview.chromium.org/1439001
------------------------------------------------------------------------
r42818 | jrg@chromium.org | 2010-03-26 21:46:33 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Allow scrolling of bookmark bar menus even if dock is open.
Not perfect (doesn't handle custom sized docks) but helps in the short term.
Long term fix is to finish http://crbug.com/38268


Review URL: http://codereview.chromium.org/1458002
------------------------------------------------------------------------
r42814 | shess@chromium.org | 2010-03-26 21:28:10 +0100 (Fri, 26 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Refactor page-action context menus.

Push the code to handle finding menus into the cell, which knows most
about page actions.  Also more thoroughly work around issues with
Control-click context menus.

BUG=none
TEST=Right-click and Control-click work the same in the Omnibox proper.
TEST=Right-click and control-click bring up appropriate menu on page actions.

Review URL: http://codereview.chromium.org/1431001
------------------------------------------------------------------------
r42813 | estade@chromium.org | 2010-03-26 21:27:17 +0100 (Fri, 26 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h

Re-apply r42703 which was reverted because of a conflict with another patch that was being reverted:
TBR=ananta
Views: fix a crash where in the browser actions container.

This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return).

BUG=38964
TEST=crash an extension while the context menu for it is showing.
original review: http://codereview.chromium.org/1237004/show

Review URL: http://codereview.chromium.org/1449001
------------------------------------------------------------------------
r42809 | jrg@chromium.org | 2010-03-26 21:13:41 +0100 (Fri, 26 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm

New folders in the bookmarks bar are created at the end of it

BUG=http://crbug.com/9340

TEST=Empty bookmark bar.  Context menu --> Add Folder named "one".  Do it.
   (Note you can only click on left side; I will file bug about that).
Repeat on bar, add folder named "three" --> adds to end.
Repeat with menu OVER "one" --> adds folder between one and three.
Add a bookmark (however; e.g. with *) in a folder.  Call it SUB.
Right click on SUB --> Add folder ENDO.  Should put after SUB.
Right click on SUB --> Add folder.  Should put after SUB but before ENDO.


Review URL: http://codereview.chromium.org/1339002
------------------------------------------------------------------------
r42804 | erg@chromium.org | 2010-03-26 21:04:06 +0100 (Fri, 26 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/test/data/profiles/chrome_prefs/Preferences
   M /trunk/src/chrome/test/data/profiles/custom_frame/Default/Preferences
   M /trunk/src/chrome/test/data/profiles/sample/Preferences
   M /trunk/src/chrome/test/data/profiles/typical_history/Default/Preferences
   M /trunk/src/net/proxy/proxy_config_service_linux.cc

GTK: Turn on the GTK+ integration by default.

This will regress default startup time for users by 50ms. This doesn't matter
because this is what the users want--I've lost count of the number bloggers,
people on twitter, and people in our IRC channel complaining about the lack of
GTK+ integration...when it's just not on by default.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1442001
------------------------------------------------------------------------
r42800 | mad@chromium.org | 2010-03-26 20:58:32 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi_unittest.cc
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   M /trunk/src/chrome_frame/delete_chrome_history.cc
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h

Committing for Eric Dingle.

http://codereview.chromium.org/890005

BUG=0
TEST=none

------------------------------------------------------------------------
r42796 | bulach@chromium.org | 2010-03-26 19:58:35 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h

Uses GeolocationContentSettingsMap on GeolocationPermissionContext to persist settings
This is a second try for http://codereview.chromium.org/1141004/show
Fixed the tests flakyness for the case where there's no infobar (that is, adding a geolocation watch will trigger a popup).

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/1415001
------------------------------------------------------------------------
r42795 | ananta@chromium.org | 2010-03-26 19:56:04 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Marking the PosixSessionEnd test as flaky..

Bug=39500
TBR=phajdan.jr

Review URL: http://codereview.chromium.org/1422003
------------------------------------------------------------------------
r42792 | rohitrao@chromium.org | 2010-03-26 19:49:42 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/HttpAuthLoginSheet.xib
   M /trunk/src/chrome/browser/login_prompt_mac.h
   M /trunk/src/chrome/browser/login_prompt_mac.mm

[Mac] Disconnect buttons from the login sheet when the login sheet goes away, in case they try to call back later.

Xib file changes:
- Connect the loginButton_ and cancelButton_ IBOutlets.

BUG=29462
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/1376001
------------------------------------------------------------------------
r42791 | estade@chromium.org | 2010-03-26 19:47:55 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.h
   M /trunk/src/chrome/browser/gtk/hover_controller_gtk.cc

GTK: fix hover state of chrome buttons in some border cases.

Most notably, with Chrome theme mode, the browser actions toolbar buttons will not stay hovered after showing/hiding the context menu for them.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/1338005
------------------------------------------------------------------------
r42790 | joth@chromium.org | 2010-03-26 19:47:04 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h

Implement the geolocation bubble for GTK
This is a port of http://src.chromium.org/viewvc/chrome?view=rev&revision=42749

BUG=11246
TEST=run with --enable-geolocation and open http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html then click the location bar icon


Review URL: http://codereview.chromium.org/1360007
------------------------------------------------------------------------
r42786 | arv@chromium.org | 2010-03-26 19:34:51 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/dom_ui/app_launcher_ui.cc (from /trunk/src/chrome/browser/dom_ui/bookmarks_ui.cc:42489)
   A /trunk/src/chrome/browser/dom_ui/app_launcher_ui.h (from /trunk/src/chrome/browser/dom_ui/bookmarks_ui.h:42489)
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/resources/app_launcher.html
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Initial add of app launcher DOM UI.

BUG=None
TEST=Go to chrome://apps


Review URL: http://codereview.chromium.org/1353005
------------------------------------------------------------------------
r42785 | chocobo@chromium.org | 2010-03-26 19:31:26 +0100 (Fri, 26 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   M /trunk/src/views/controls/slider/slider.h

Fix compiler warnings.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1349005
------------------------------------------------------------------------
r42783 | viettrungluu@chromium.org | 2010-03-26 19:27:07 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/eula_ui.cc
   A /trunk/src/chrome/browser/dom_ui/eula_ui.h
   A /trunk/src/chrome/browser/resources/eula.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Temporary EULA display for internal plugin.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1389002
------------------------------------------------------------------------
r42780 | phajdan.jr@chromium.org | 2010-03-26 19:08:48 +0100 (Fri, 26 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Mark SessionRestoreUITest.DontRestoreWhileIncognito as flaky.

It triggers sqlite diagnostic errors. More details in the bug.

TBR=sky
TEST=still flaky
BUG=39490

Review URL: http://codereview.chromium.org/1438001
------------------------------------------------------------------------
r42779 | ananta@chromium.org | 2010-03-26 18:41:47 +0100 (Fri, 26 Mar 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Reverting this CL to fix the interactive ui test failures.

Revert 42498 - Keyboard accessibility for the page and app menus.
Works on Windows, and on Linux with toolkit_views.

The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.

Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.

Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.

A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.

BUG=none
TEST=New keyboard accessibility interactive ui test.

Review URL: http://codereview.chromium.org/660323

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/1428001
------------------------------------------------------------------------
r42778 | ananta@chromium.org | 2010-03-26 18:36:57 +0100 (Fri, 26 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h

estade:- This revert is to fix interactive ui test failures which have been broken since Wednesday. Your CL
is not at fault though. 42498 seems to be the culprit. I had to revert your CL as it leads to conflicts while
reverting 42498

Revert 42703 - Views: fix a crash where in the browser actions container.

This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return).

BUG=38964
TEST=crash an extension while the context menu for it is showing.

Review URL: http://codereview.chromium.org/1237004

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/1423002
------------------------------------------------------------------------
r42776 | tonyg@chromium.org | 2010-03-26 18:15:51 +0100 (Fri, 26 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/net/base/auth.h

Revert 42770 - Notify all active login prompts when one login prompt is submitted. This allows
identical login prompts to dismiss themselves.

BUG=8914
TEST=ui_tests gtest_filter=LoginPromptTest*
Review URL: http://codereview.chromium.org/1039004

TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/1410002
------------------------------------------------------------------------
r42772 | sky@chromium.org | 2010-03-26 17:52:11 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc

Disabling newly added test as failed on linux views. Will investigate
after landing.

BUG=none
TEST=none
TBR=brettw@chromium.org

Review URL: http://codereview.chromium.org/1394006
------------------------------------------------------------------------
r42770 | tonyg@chromium.org | 2010-03-26 17:31:24 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/net/base/auth.h

Notify all active login prompts when one login prompt is submitted. This allows
identical login prompts to dismiss themselves.

BUG=8914
TEST=ui_tests --gtest_filter=LoginPromptTest*
Review URL: http://codereview.chromium.org/1039004
------------------------------------------------------------------------
r42769 | xiyuan@chromium.org | 2010-03-26 17:13:39 +0100 (Fri, 26 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/web_applications/web_app.cc

Append a number to make app shortcut name unique.

- Move DownloadManager's unique path helpers into download utils;
- Use those functions to make shortcut file name unqiue.

BUG=642
TEST=Verify fixes for issue 642.

Review URL: http://codereview.chromium.org/1276003
------------------------------------------------------------------------
r42768 | avi@chromium.org | 2010-03-26 17:12:55 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardFormView.xib
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_text_field_mac.mm
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/credit_card_unittest.cc

Adds obscuring to credit card numbers when displayed.

xib change: added tag to fields that are used for credit card numbers.

BUG=http://crbug.com/38259
TEST=as in bug

Review URL: http://codereview.chromium.org/1219009
------------------------------------------------------------------------
r42767 | phajdan.jr@chromium.org | 2010-03-26 17:12:10 +0100 (Fri, 26 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

[GTTF] Various ui tests cleanups:

- unify timeout handling
- remove unneccessary assertions that clutter the code

They were mostly there because earlier the automation
framework was less reliable. Now the same checks (or
equivalent) are always done in the framework itself.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1377001
------------------------------------------------------------------------
r42766 | sky@chromium.org | 2010-03-26 16:58:08 +0100 (Fri, 26 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore.h
   A /trunk/src/chrome/browser/sessions/session_restore_browsertest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Fixes bug where triggering session restore while the browser was
already running would end up creating an extra tab.

BUG=11594
TEST=open chrome with a single tabbed browser, turn on session
  restore, navigate to a page with a popup, close the tabbed browser,
  create a new window ala control-n (or double click on the desktop),
  and make the restored window doesn't end upw 

Review URL: http://codereview.chromium.org/1371002
------------------------------------------------------------------------
r42764 | mirandac@chromium.org | 2010-03-26 16:53:55 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Fix crasher in LocationBarViewMac::PageActionImageView::OnImageLoaded.

Scott's insight in comment 18 on the bug report was correct; fixed by relinquishing control on call to UpdatePageActions, so that we don't try to look at the private variables of a dying this ptr.

BUG= 35864
TEST= no crash.

Review URL: http://codereview.chromium.org/1397001
------------------------------------------------------------------------
r42759 | bulach@chromium.org | 2010-03-26 15:55:11 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h

Revert 42757 - Uses GeolocationContentSettingsMap on GeolocationPermissionContext to persist settings.

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/1141004

TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/1394005
------------------------------------------------------------------------
r42757 | bulach@chromium.org | 2010-03-26 15:20:02 +0100 (Fri, 26 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h

Uses GeolocationContentSettingsMap on GeolocationPermissionContext to persist settings.

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/1141004
------------------------------------------------------------------------
r42756 | thakis@chromium.org | 2010-03-26 15:14:25 +0100 (Fri, 26 Mar 2010) | 12 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi

Mac: Initial Geolocation UI.

For now, an in-progress version of the bubble/omnibox icon. The bubble shows up, but doesn't do much yet. The two buttons are disabled because they both don't do anything yet. Since this is behind a flag, I think checking in work-in-progress UI is fine.

Parts of this CL were merged in from http://codereview.chromium.org/1369002 . Ignore the files from that CL.

http://imgur.com/tWJhg

BUG=11246
TEST=Start chrome with --enable-geolocation, go to http://maxheapsize.com/static/html5geolocationdemo.html , click allow or deny, observe that an icon appears. Click icon, a bubble appears.

Review URL: http://codereview.chromium.org/1345005
------------------------------------------------------------------------
r42755 | joth@chromium.org | 2010-03-26 15:09:49 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Clarify a comment about the geolocation content settings map

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1361004
------------------------------------------------------------------------
r42753 | pinkerton@chromium.org | 2010-03-26 14:57:16 +0100 (Fri, 26 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

Don't allow drops on the omnibox for popup windows.
BUG=33071
TEST=drags to omnibox in popup should be denied. drags to omnibox in normal window should be allowed and load the url.
Review URL: http://codereview.chromium.org/1225007
------------------------------------------------------------------------
r42752 | jochen@chromium.org | 2010-03-26 14:55:19 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Rework ordering in ExtensionsService::UninstallExtension()

BUG=39147
TEST=Existing tests in extensions_service_unittest.cc

Review URL: http://codereview.chromium.org/1278003
Patch from Mattias Nissler.
------------------------------------------------------------------------
r42750 | dpolukhin@chromium.org | 2010-03-26 13:41:22 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   A /trunk/src/chrome/browser/chromeos/login/login_manager_view_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/login/login_utils.cc (from /trunk/src/chrome/browser/chromeos/login/utils.cc:42598)
   A /trunk/src/chrome/browser/chromeos/login/login_utils.h (from /trunk/src/chrome/browser/chromeos/login/utils.h:42598)
   D /trunk/src/chrome/browser/chromeos/login/utils.cc
   D /trunk/src/chrome/browser/chromeos/login/utils.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

In process browser test for login screen.

BUG=chromiumos:2036
TEST=Run out/Debug/browser_tests --gtest_filter=LoginManagerViewTest.TestBasic

Review URL: http://codereview.chromium.org/1256004
------------------------------------------------------------------------
r42749 | joth@chromium.org | 2010-03-26 13:27:22 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h

First cut at implementing the windows geolocaiton bubble view.
Depends on http://codereview.chromium.org/1369002

BUG=11246
TEST=--enable-geolocation and open http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html


Review URL: http://codereview.chromium.org/1348002
------------------------------------------------------------------------
r42746 | jorlow@chromium.org | 2010-03-26 12:44:57 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc

Stop abusing cookie strings for local storage and database.
We did the original abuse because we were past the 4.1 string freeze and needed
to add new features, but we can fix this for chrome 5.

TEST=The labels should be things like "Key:" instead of "Name:" and so on.
BUG=34669

Review URL: http://codereview.chromium.org/1317004
------------------------------------------------------------------------
r42739 | joth@chromium.org | 2010-03-26 10:32:20 +0100 (Fri, 26 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_image_model.cc

Re-attempt at http://codereview.chromium.org/1344002

Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180

TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)


BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.

Review URL: http://codereview.chromium.org/1369002
------------------------------------------------------------------------
r42738 | nick@chromium.org | 2010-03-26 09:31:57 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h

Fix for negative routing info problem.  We were replacing tokens after
failure multiple times.

BUG=39214
TEST=included new fancy unit test

Review URL: http://codereview.chromium.org/1294002
------------------------------------------------------------------------
r42736 | ukai@chromium.org | 2010-03-26 08:35:55 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/websockets/websocket.cc
   M /trunk/src/net/websockets/websocket.h
   M /trunk/src/net/websockets/websocket_handshake.cc
   M /trunk/src/net/websockets/websocket_handshake.h
   A /trunk/src/net/websockets/websocket_handshake_draft75.cc (from /trunk/src/net/websockets/websocket_handshake.cc:42735)
   A /trunk/src/net/websockets/websocket_handshake_draft75.h (from /trunk/src/net/websockets/websocket_handshake.h:42735)
   A /trunk/src/net/websockets/websocket_handshake_draft75_unittest.cc (from /trunk/src/net/websockets/websocket_handshake_unittest.cc:42735)
   M /trunk/src/net/websockets/websocket_handshake_unittest.cc
   M /trunk/src/net/websockets/websocket_unittest.cc

Implement new websocket handshake based on draft-hixie-thewebsocketprotocol-76

BUG=none
TEST=net_unittests passes

Review URL: http://codereview.chromium.org/1108002
------------------------------------------------------------------------
r42732 | slightlyoff@chromium.org | 2010-03-26 05:16:20 +0100 (Fri, 26 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/bho.h
   M /trunk/src/chrome_frame/bho.rgs
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   M /trunk/src/chrome_frame/chrome_launcher.cc
   A /trunk/src/chrome_frame/delete_chrome_history.cc
   A /trunk/src/chrome_frame/delete_chrome_history.h
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/chrome_frame/test/automation_client_mock.h
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.h
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/chrome_frame/utils.h

3rd try. *sigh*

See: http://codereview.chromium.org/858003

TBR=tommi
BUG=22846
TEST=On IE 8, clear the cache entirely, watch GCF launch (via task manager)


Review URL: http://codereview.chromium.org/1343004
------------------------------------------------------------------------
r42725 | brettw@chromium.org | 2010-03-26 04:04:51 +0100 (Fri, 26 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Move a few more things out of BrowserMain into helper functions.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1368001
------------------------------------------------------------------------
r42720 | dhollowa@chromium.org | 2010-03-26 02:58:09 +0100 (Fri, 26 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager.h
   M /trunk/src/chrome/renderer/form_manager_unittest.cc

Label scraping for AutoFill.

Adds label scraping to AutoFill.  Infers labels from surrounding context of
input fields in the WebKit DOM.  Specific cases added are:
  - Text element immediately preceeding INPUT element.
    Eg. First name:<INPUT type="text" id="firstname" value="John"/>
  - Paragraph element containing text immediately preceeding INPUT element.
    Eg. <P>First name:</P><INPUT type="text" id="firstname" value="John"/>

BUG=33031
TEST=FormManagerTest.LabelsFromInferredParagraph,
     FormManagerTest.LabelsFromInferredText,
     FormStructureTest.HeuristicsLabelsOnly

Review URL: http://codereview.chromium.org/1380002
------------------------------------------------------------------------
r42715 | dhollowa@chromium.org | 2010-03-26 02:33:21 +0100 (Fri, 26 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate_unittest.cc
   M /trunk/src/chrome/browser/autofill/billing_address_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_field_unittest.cc


Removing AutoFill Death Tests.

The gunit ASSERT_DEBUG_DEATH check is causing long timeouts on Mac.  Removing.

BUG=NONE
TEST=AutoFill unit tests.


Review URL: http://codereview.chromium.org/1400001
------------------------------------------------------------------------
r42711 | akalin@chromium.org | 2010-03-26 02:26:33 +0100 (Fri, 26 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Added support for pending extensions to ExtensionsService and
ExtensionUpdater.  This is needed for theme syncing.

Basically a pending extension is an (id, update_url) pair.  This change
makes it so that one can pass pending extensions to the extension service
and they will be installed if necessary on the next auto-update cycle.

BUG=32414
TEST=unittests, trybots, in-progress theme syncing change

Review URL: http://codereview.chromium.org/1232003
------------------------------------------------------------------------
r42708 | zork@chromium.org | 2010-03-26 01:36:43 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc

Scope the WriteTransactions during model association so that we don't lock the UI thread

BUG=34206
TEST=none

Review URL: http://codereview.chromium.org/1361002
------------------------------------------------------------------------
r42707 | arv@chromium.org | 2010-03-26 01:36:06 +0100 (Fri, 26 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc

Add some more EXPECT_TRUE to track down the valgrind issue.

BUG=39401
TEST=ui_test --gtest_filter BookmarksUITest.*
TBR=dhollowa

Review URL: http://codereview.chromium.org/1365003
------------------------------------------------------------------------
r42705 | erg@chromium.org | 2010-03-26 01:29:09 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h

GTK: Provide GTK+ themed notifications.

BUG=34514
TEST=none

Review URL: http://codereview.chromium.org/1353003
------------------------------------------------------------------------
r42703 | estade@chromium.org | 2010-03-26 01:10:58 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h

Views: fix a crash where in the browser actions container.

This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return).

BUG=38964
TEST=crash an extension while the context menu for it is showing.

Review URL: http://codereview.chromium.org/1237004
------------------------------------------------------------------------
r42701 | skerner@chromium.org | 2010-03-26 01:06:05 +0100 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc

Disable test AccountScreenTest.TestBasic .

BUG=39404
TEST=none
TBR=avayvod

------------------------------------------------------------------------
r42696 | dhg@chromium.org | 2010-03-26 00:48:14 +0100 (Fri, 26 Mar 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   A /trunk/src/chrome/browser/chromeos/usb_mount_observer_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Adding new test for mount observer. Also changing the usb mounter to only reload the correct tab, not the full browser.

BUG=chromium-os:2057
Review URL: http://codereview.chromium.org/1238006
------------------------------------------------------------------------
r42695 | chocobo@chromium.org | 2010-03-26 00:43:16 +0100 (Fri, 26 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   A /trunk/src/chrome/browser/chromeos/status/power_menu_button_browsertest.cc (from /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc:42551)
   M /trunk/src/chrome/chrome_tests.gypi

Add test for power_menu_button.
BUG=none
TEST=power_menu_button_browsertest
Review URL: http://codereview.chromium.org/1338003
------------------------------------------------------------------------
r42692 | skerner@chromium.org | 2010-03-26 00:20:24 +0100 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/common/ipc_test_sink.cc
   M /trunk/src/chrome/common/ipc_test_sink.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   M /trunk/src/ipc/ipc_channel.h

Revert 42656 - Add a Pepper audio basic functionality unit test.

Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.

Review URL: http://codereview.chromium.org/1207005

TBR=neb@chromium.org
Review URL: http://codereview.chromium.org/1344003
------------------------------------------------------------------------
r42691 | ananta@chromium.org | 2010-03-26 00:16:39 +0100 (Fri, 26 Mar 2010) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/bho.h
   M /trunk/src/chrome_frame/bho.rgs
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   D /trunk/src/chrome_frame/delete_chrome_history.cc
   D /trunk/src/chrome_frame/delete_chrome_history.h
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/chrome_frame/test/automation_client_mock.h
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.h
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/chrome_frame/utils.h

Reverting this CL to see if this fixes chrome frame unit test failures.

Revert 42684 - Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF directory for nonpriv mode users on IE < 8.

Implementation notes:

Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change:

"Delete Browsing History":

	IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual.

	IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8.

"InPrivate Filtering":

	IE 8 (only): more testing required.

"InPrivate Browsing":

	IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected.

BUG=22846
TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming)
Review URL: http://codereview.chromium.org/858003

TBR=slightlyoff@chromium.org
Review URL: http://codereview.chromium.org/1353002
------------------------------------------------------------------------
r42684 | slightlyoff@chromium.org | 2010-03-25 23:30:03 +0100 (Thu, 25 Mar 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/bho.h
   M /trunk/src/chrome_frame/bho.rgs
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   A /trunk/src/chrome_frame/delete_chrome_history.cc
   A /trunk/src/chrome_frame/delete_chrome_history.h
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/chrome_frame/test/automation_client_mock.h
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.h
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/chrome_frame/utils.h

Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF directory for non-priv mode users on IE < 8.

Implementation notes:

Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change:

"Delete Browsing History":

	IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual.

	IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8.

"InPrivate Filtering":

	IE 8 (only): more testing required.

"InPrivate Browsing":

	IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected.

BUG=22846
TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming)
Review URL: http://codereview.chromium.org/858003
------------------------------------------------------------------------
r42679 | apatrick@chromium.org | 2010-03-25 23:08:35 +0100 (Thu, 25 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_channel.h
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.cc
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.h
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/renderer/command_buffer_proxy.cc
   M /trunk/src/chrome/renderer/command_buffer_proxy.h
   M /trunk/src/chrome/renderer/ggl/ggl.cc
   M /trunk/src/chrome/renderer/ggl/ggl.h
   M /trunk/src/chrome/renderer/gpu_channel_host.cc
   M /trunk/src/chrome/renderer/gpu_channel_host.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/gpu/command_buffer/build_gles2_cmd_buffer.py
   M /trunk/src/gpu/command_buffer/client/cmd_buffer_helper_test.cc
   M /trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc
   M /trunk/src/gpu/command_buffer/client/gles2_demo.cc
   M /trunk/src/gpu/command_buffer/client/gles2_implementation.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor.h
   M /trunk/src/gpu/command_buffer/service/gpu_processor_linux.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor_mac.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor_unittest.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor_win.cc
   M /trunk/src/gpu/command_buffer/service/texture_manager.cc
   M /trunk/src/gpu/command_buffer/service/texture_manager.h
   M /trunk/src/gpu/demos/framework/window.cc
   M /trunk/src/gpu/gpu.gyp

Calling OpenGL from the renderer process
- Added ability for renderer processes to render to a real window (Windows only so far).
- Added ability to create offscreen frame buffer objects that can be resized later.
- OpenGL context can have a "parent" context that can access its last swapped back buffer through a texture ID.
- Moved code to establish GPU channel from RenderWidget to RenderThread.
- Changed way service size command buffer object lifetimes are managed.
TEST=trybot and visual verification that OpenGL can clear the browser window to magenta.
BUG=none

Review URL: http://codereview.chromium.org/1136006
------------------------------------------------------------------------
r42678 | zork@chromium.org | 2010-03-25 23:07:45 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc

Clean up read FDs in async network alive.  This prevents chrome from eating all FDs.

BUG=35229
TEST=Let Chrome idle with a flakey net connection, and check that the number of open FDs is not increasing.

Review URL: http://codereview.chromium.org/1336004
------------------------------------------------------------------------
r42674 | viettrungluu@chromium.org | 2010-03-25 23:02:44 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Temporary stuff for internal plugins, part 1.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1320002
------------------------------------------------------------------------
r42672 | xiyuan@chromium.org | 2010-03-25 22:19:27 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/file_browse_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/input_file.html

Add a basic FileBrowseUI browser test to verify <input type=file..> would bring up FileBrowseUI.

<http://crosbugs.com/2056>
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1315003
------------------------------------------------------------------------
r42671 | aa@chromium.org | 2010-03-25 22:15:02 +0100 (Thu, 25 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/fragment_navigation_apitest.cc
   A /trunk/src/chrome/browser/extensions/notifications_apitest.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/notification.html
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/notification.html

Re-land 42631: The problem was that notifications aren't implemented on linux/views yet.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r42670 | xiyuan@chromium.org | 2010-03-25 22:14:09 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h

Convert tab to app after user clicks "create" button per issue 27905.

BUG=27905
TEST=Verify fix for 27095.

Review URL: http://codereview.chromium.org/1351001
------------------------------------------------------------------------
r42668 | joth@chromium.org | 2010-03-25 21:59:27 +0100 (Thu, 25 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_image_model.cc

Revert 42665 - broke build as I missed a unit test when building locally.

Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180

TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)


BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.


Review URL: http://codereview.chromium.org/1344002

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/1367002
------------------------------------------------------------------------
r42665 | joth@chromium.org | 2010-03-25 21:46:02 +0100 (Thu, 25 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/content_setting_bubble_model.cc
   M /trunk/src/chrome/browser/content_setting_bubble_model.h
   M /trunk/src/chrome/browser/content_setting_image_model.cc

Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180

TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)


BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.


Review URL: http://codereview.chromium.org/1344002
------------------------------------------------------------------------
r42664 | erg@chromium.org | 2010-03-25 21:46:01 +0100 (Thu, 25 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h

GTK: Notifications shouldn't crash when gtk notification is destroyed.

(Use callbacks, while I'm at it.)

BUG=34515
TEST=none

Review URL: http://codereview.chromium.org/1372001
------------------------------------------------------------------------
r42663 | arv@chromium.org | 2010-03-25 21:37:40 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/browser/dom_ui/bookmarks_ui_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

A pretty lame initial UITest for bookmark manager.

BUG=None
TEST=ui_test.exe --gtest_filter=BookmarksUITest.*


Review URL: http://codereview.chromium.org/1292002
------------------------------------------------------------------------
r42656 | neb@chromium.org | 2010-03-25 20:39:57 +0100 (Thu, 25 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/common/ipc_test_sink.cc
   M /trunk/src/chrome/common/ipc_test_sink.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   M /trunk/src/ipc/ipc_channel.h

Add a Pepper audio basic functionality unit test.

Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.

Review URL: http://codereview.chromium.org/1207005
------------------------------------------------------------------------
r42655 | jshin@chromium.org | 2010-03-25 20:38:23 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/app/l10n_util_win.cc
   M /trunk/src/app/resources/app_locale_settings.grd
   D /trunk/src/app/resources/app_locale_settings_or.xtb
   M /trunk/src/app/resources/app_strings.grd
   D /trunk/src/app/resources/app_strings_or.xtb
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/locales/locales.gyp
   D /trunk/src/chrome/app/resources/generated_resources_or.xtb
   D /trunk/src/chrome/app/resources/google_chrome_strings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_linux.grd
   M /trunk/src/chrome/app/resources/locale_settings_mac.grd
   M /trunk/src/chrome/app/resources/locale_settings_win.grd
   D /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_or.xtb
   D /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_or.xtb
   D /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_or.xtb
   D /trunk/src/chrome/app/resources/terms/terms_or.html
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/installer/util/l10n_string_util.cc
   D /trunk/src/webkit/glue/resources/webkit_strings_or.xtb
   M /trunk/src/webkit/glue/webkit_strings.grd

Remove Oriya from the list of UI languages for now because we're not getting Oriya translation updated any more.

BUG=37562
TEST=On Windows, 'chrome --lang=or' will bring up English Chrome.


Review URL: http://codereview.chromium.org/1144001
------------------------------------------------------------------------
r42654 | erg@chromium.org | 2010-03-25 20:34:39 +0100 (Thu, 25 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h

GTK: Clean up visual appearance of HTML5 notifications.

All widgets are now displayed and the notification has a curved border.

BUG=34514
TEST=none

Review URL: http://codereview.chromium.org/1247005
------------------------------------------------------------------------
r42652 | erg@chromium.org | 2010-03-25 20:16:41 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h

GTK: Allow double clicking on an exception to open the edit dialog.

BUG=38349
TEST=none

Review URL: http://codereview.chromium.org/1320001
------------------------------------------------------------------------
r42650 | twiz@chromium.org | 2010-03-25 20:14:17 +0100 (Thu, 25 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc

Basic change correcting the coordinate space of the reference anchor point for the extension popup API when using borderStyle=rectangle.

I will submit a follow-up CL containing tests that will catch future regressions on the positioning of the pop-up.

BUG=39235
TEST=None

Review URL: http://codereview.chromium.org/1217009
------------------------------------------------------------------------
r42648 | andybons@chromium.org | 2010-03-25 20:11:36 +0100 (Thu, 25 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm

[Mac] Clean up the icon loading code for extensions after finnur's change (r42471) which made the interface a lot cleaner.

TEST=none
BUG=38521
Review URL: http://codereview.chromium.org/1251004
------------------------------------------------------------------------
r42645 | estade@chromium.org | 2010-03-25 20:08:28 +0100 (Thu, 25 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

GTK: hide the current grab widget when showing an info bubble.

Problem:
Extension popups can take a while to appear after the user clicks the icon. If the user clicks something else that causes a grab (like a context or dropdown menu, or another info bubble), then that grab is shadowed and the widget behaves oddly (having two info bubbles open simultaneously, having an unclosable menu, etc.)

Solution:
Hide any widget that has a grab when the info bubble is being created. Delete info bubbles that get hidden.

Etc.:
You can still pretty easily get into a weird trapped state when the delayed info bubble interacts with tab dragging.

BUG=none
TEST=left click then quickly right click a browser action with extension popup

Review URL: http://codereview.chromium.org/1317001
------------------------------------------------------------------------
r42644 | aa@chromium.org | 2010-03-25 19:23:41 +0100 (Thu, 25 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/fragment_navigation_apitest.cc
   D /trunk/src/chrome/browser/extensions/notifications_apitest.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/notification.html
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/notification.html

Revert 42631 as it seems to have broken browser tests on linux_views.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r42643 | danno@chromium.org | 2010-03-25 19:08:22 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm

fix forgotton release that upsets valgrind on the mac unit tests

BUG=none
TEST=manual step-through of code

Review URL: http://codereview.chromium.org/1344001
------------------------------------------------------------------------
r42639 | aa@chromium.org | 2010-03-25 18:50:59 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   A /trunk/src/chrome/browser/views/extensions/extension_install_prompt2.cc
   M /trunk/src/chrome/chrome_browser.gypi

First part of new install dialog on Windows. Later changes will
add tooltips and implementations on other platforms.

BUG=29633

Review URL: http://codereview.chromium.org/1299002
------------------------------------------------------------------------
r42637 | brettw@chromium.org | 2010-03-25 18:47:45 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix the offical build by passing local state to the initialize metrics function.

TEST=none
BUG=none
TBR=mmoss
Review URL: http://codereview.chromium.org/1341001
------------------------------------------------------------------------
r42636 | mpcomplete@chromium.org | 2010-03-25 18:42:22 +0100 (Thu, 25 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Fix BrowserActionsContainerTest.Visibility for chromeos and reenable it.

BUG=38992

Review URL: http://codereview.chromium.org/1310001
------------------------------------------------------------------------
r42633 | joth@chromium.org | 2010-03-25 18:31:27 +0100 (Thu, 25 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/common/content_settings_types.h

Add Geolocation to the content types. This adds several special case guards so we can still build & run whilst the full implementation is being worked on (in parallel)

(Some code taken from http://codereview.chromium.org/650180)

BUG=11246
TEST=Built & ran on all three platforms. Used geolocation & open content setting dialog.

Review URL: http://codereview.chromium.org/1241006
------------------------------------------------------------------------
r42632 | arv@chromium.org | 2010-03-25 18:29:52 +0100 (Thu, 25 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/command.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

TBR:
------------------------------------------------------------------------
r42631 | aa@chromium.org | 2010-03-25 18:29:03 +0100 (Thu, 25 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/fragment_navigation_apitest.cc
   A /trunk/src/chrome/browser/extensions/notifications_apitest.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon_host.cc
   M /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/notifications
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_not_permission/notification.html
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/notifications/has_permission/notification.html

Finish wiring up notifications in extensions.

Review URL: http://codereview.chromium.org/1076004
------------------------------------------------------------------------
r42629 | brettw@chromium.org | 2010-03-25 18:06:53 +0100 (Thu, 25 Mar 2010) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc

Move some stuff from BrowserMain into helper functions.

This patch changes the behavior slightly. We used to skip creation of the
metrics service at all if it was disabled on the command line. But this was
pretty confusing because it was still possible for it to be disabled by way of
not uploading any data. And there were two places in the rest of the function
that would crash if the metrics service was NULL (because you used the command
line switch).

After some archaeology, I discovered the command line switch was from before
we had preferences and was then the only way to disable the metrics. Since we
have prefs now and it defaults to off, I think the command line switch isn't
useful, and the fact that it crashes sometimes further indicates this. So I
just removed it.

This does not remove the actual constant since that's used by ChromeFrame:
once to make sure it's passed through when Chrome is spawend, and once in a
test that command line switches are passed through. We'll have to remove these
in a separate patch before removing the constant declaration.

This also moves the WebSocketExperimentRunner starting from outside the
"disable metrics" block. I think the intent was that it wouldn't be enabled
if we weren't collecting metrics, but it wasn't actually working that way,
so I just pulled it out to the top level of BrowserMain.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1251007
------------------------------------------------------------------------
r42628 | sky@chromium.org | 2010-03-25 18:06:12 +0100 (Thu, 25 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.h

Makes adding a new folder from the bookmark context menu add the
folder right after the selected item (when possible) rather than as
the last element.

BUG=9240
TEST=see bug

Review URL: http://codereview.chromium.org/1253004
------------------------------------------------------------------------
r42626 | glotov@google.com | 2010-03-25 18:05:26 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   A /trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

LanguageSwitch test.

BUG=2039
TEST=out/Debug/browser_tests --gtest_filter=WizardControllerTest.SwitchLanguage

Review URL: http://codereview.chromium.org/1239005
------------------------------------------------------------------------
r42623 | pfeldman@chromium.org | 2010-03-25 17:30:43 +0100 (Thu, 25 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h

DevTools: Fix devtools crasher related to unsuccessful extensions reload with opened devtools window.
BUG=31081

Review URL: http://codereview.chromium.org/1328003
------------------------------------------------------------------------
r42618 | nkostylev@google.com | 2010-03-25 16:29:13 +0100 (Thu, 25 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   A /trunk/src/chrome/browser/chromeos/login/network_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/network_screen.h
   M /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/login/network_screen_delegate.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/network_list.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor network selection screen.
Move model and controller logic to NetworkScreen class.
Move Refresh() method out of view to controller.

Make network selection obligatory on OOBE even if Ethernet is connected.

BUG=37070
TEST=Running with --login-manager --login-screen=oobe should initiate normal out of box flow. After selecting network from combobox update is initiated.

Review URL: http://codereview.chromium.org/1058004
------------------------------------------------------------------------
r42617 | skerner@chromium.org | 2010-03-25 16:28:00 +0100 (Thu, 25 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc

Mark AccountScreenTest.TestBasic as flaky.

TBR=avayvod

------------------------------------------------------------------------
r42613 | joth@chromium.org | 2010-03-25 16:02:52 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc

Possible fix / workaround for geolocation wifi hanging bug
Also pre-emptively fixes a reported issue with NULL bss list being returned from WlanGetNetworkBssList

BUG=39300
TEST=run browser on desktop with dodgy wifi adapter....

Review URL: http://codereview.chromium.org/1256005
------------------------------------------------------------------------
r42611 | jochen@chromium.org | 2010-03-25 15:38:32 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   A /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Reland r42467. Clear cookies, local storage and databases when an extension gets uninstalled.

BUG=27938,39177
TEST=Unittest in extension_service_unitttest.cc

Review URL: http://codereview.chromium.org/1257005
Patch from Mattias Nissler.
------------------------------------------------------------------------
r42607 | dpolukhin@chromium.org | 2010-03-25 14:28:33 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc

OOBE screens stroke should on pixel boundary to looks less blurry.

BUG=none
TEST=On Chrome OS login screen edge is sharp and blue.

Review URL: http://codereview.chromium.org/1278002
------------------------------------------------------------------------
r42603 | joth@chromium.org | 2010-03-25 13:22:22 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h

Preparatory step for implementing http://crbug.com/39171
Refactor the way the location arbitrator is obtained by the dispatched host, so that it is co-ordinated by the permission context.

BUG=39171
TEST=none

Review URL: http://codereview.chromium.org/1283002
------------------------------------------------------------------------
r42600 | ahendrickson@google.com | 2010-03-25 13:17:44 +0100 (Thu, 25 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/http/http_auth_filter.cc
   M /trunk/src/net/http/http_auth_filter.h
   M /trunk/src/net/http/http_auth_filter_unittest.cc
   A /trunk/src/net/http/http_auth_filter_win.h
   M /trunk/src/net/http/http_auth_handler_factory_unittest.cc
   M /trunk/src/net/http/http_auth_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/net.gyp

HttpAuthFilterWhitelist is now getting entries from the Windows
registry, and adding them to whatever is in the command line.

Added a basic IsIntranetHost() member function to HttpNetworkTransaction.
Removed it until we figure out what to do with it.

Added unit tests.
Refactored SetFilters() to be less confusing.
Unit tests now use a dummy registry key.

BUG=29596
TEST=net_unittests.exe --gtest_filter=HttpAuthFilterTest.*

Review URL: http://codereview.chromium.org/669068
------------------------------------------------------------------------
r42597 | danno@chromium.org | 2010-03-25 12:00:04 +0100 (Thu, 25 Mar 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookiePrompt.xib
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookie_modal_dialog.h

[Mac] Make cookie prompt dialog more Mac-like

As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular.

Also added unit tests.

xib changes:
- Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly.
- Change the size of the radio buttons in the "remember" choice to be small rather than regular.
- Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string
- Move the details view to be below the accept/block buttons.
- Change the style of the disclosure control to be a button rather than triangle.

Before: http://img257.yfrog.com/img257/3066/picture3fx.png
After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png

BUG=38208
TEST=manual testing, added unit test for remember/block/accept controls

Review URL: http://codereview.chromium.org/1102005
------------------------------------------------------------------------
r42596 | satorux@chromium.org | 2010-03-25 11:59:37 +0100 (Thu, 25 Mar 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Fix a bug that caused candidate_window to crash at startup time.

The problem was that CommandLine::ForCurrentProcess() was called
despite candidate_window did not parse the command line flags.

	StackTrace::StackTrace() [0x45a312]
	logging::LogMessage::~LogMessage() [0x40abb7]
	CommandLine::ForCurrentProcess() [0x40b3b5]
	l10n_util::GetApplicationLocale() [0x4cd3f7]
	ResourceBundle::LoadResources() [0x4c935d]
	ResourceBundle::InitSharedInstance() [0x4c5ed7]
	main [0x402a5f]
	0x7ffff2aa6abd
	0x4002a9

BUG=crosbug.com/2254
TEST=manually

Review URL: http://codereview.chromium.org/1238008
------------------------------------------------------------------------
r42595 | avayvod@google.com | 2010-03-25 11:26:11 +0100 (Thu, 25 Mar 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/account_screen_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Initial unittest for AccountScreen.

BUG=None
TEST=Run browser_tests with --gtest_filter=AccountScreenTest.*
Review URL: http://codereview.chromium.org/1123008
------------------------------------------------------------------------
r42594 | joth@chromium.org | 2010-03-25 11:12:56 +0100 (Thu, 25 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/test/data/geolocation/iframes_different_origin.html

Adds GeolocationContentSettings on TabContents. 

This data structure and the notification flow will be used to populate the location bar icon and its bubble. 

 - this was originally part of http://codereview.chromium.org/650180
 - Fully reviewed as http://codereview.chromium.org/1143002 I'm just landing on Marcus's behalf

TBR=bulach
BUG=11246
TEST=geolocation_browsertest.cc


Review URL: http://codereview.chromium.org/1320005
------------------------------------------------------------------------
r42590 | danno@chromium.org | 2010-03-25 10:38:02 +0100 (Thu, 25 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   M /trunk/src/chrome/browser/cocoa/cookie_details.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.h
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_details_view_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Allow user to change cookie expiration date in cookie prompt

Added the necessary code and madde xib changes to make it possible to select "When I close my browser" as the expiration for a cookie in the cookie prompt dialog.

xib changes:
  - Add explicit outlet to details view controller for the layout tweaker so that can be called explicitly from code.
 - Modify already existing popup menu for selecting cookie expiration to have the right menu items: item 1 is content.details.expires and item 2 is ^IDS_COOKIES_COOKIE_EXPIRES_SESSION.
 - Wire the hidden binding of the expiration menu to the key value path content.details.canEditExpiration with a NSNegateBoolean transformer.
 - Wire the visibility of the "expires" text in cookie details to the key value path content.details.canEditExpiration.

BUG=http://crbug.com/38405
TEST=manual testing, new units tests

Review URL: http://codereview.chromium.org/1134005
------------------------------------------------------------------------
r42586 | jochen@chromium.org | 2010-03-25 09:31:47 +0100 (Thu, 25 Mar 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/net/chrome_cookie_notification_details.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Reland r42473. Add a delegate to CookieMonster and broadcast notifications about changes to cookies.

This change will allow implementing the experimental cookie extension API, specifically the cookies.onChaned event

BUG=none
TEST=net_unittests
TBR=jochen@

Review URL: http://codereview.chromium.org/1287001
------------------------------------------------------------------------
r42582 | jcivelli@chromium.org | 2010-03-25 07:44:41 +0100 (Thu, 25 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Adding a context menu to bring up or bring back the translate infobar
when it is not showing.

BUG=35480
TEST=Open a page so that the translate infobar is shown. Close the
     infobar. Use the page translate context menu, make sure it
     works. Do the same thing but make sure you translate the page
     first.
     Make sure the menu is not enabled on Chrome specific pages (new
     tab, history, downloads...) as well as on interstitials.

Review URL: http://codereview.chromium.org/1151003
------------------------------------------------------------------------
r42580 | chocobo@chromium.org | 2010-03-25 04:51:02 +0100 (Thu, 25 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

Fix infinite loop bug that crashes Chrome when selected "Disable Wifi".
BUG=chromium-os:1685
TEST=Selecting "Disable Wifi" in networm menu does not crash Chrome
Review URL: http://codereview.chromium.org/1305002
------------------------------------------------------------------------
r42578 | finnur@chromium.org | 2010-03-25 04:00:49 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource.h

Ensure all callers to GetFilePath are on the File thread
by DCHECKing based on the thread type.

TEST=Extensions and automated tests should work as before
BUG=http://crbug.com/38521

Review URL: http://codereview.chromium.org/1293001
------------------------------------------------------------------------
r42575 | eroman@chromium.org | 2010-03-25 03:43:18 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Move the cancellation of blocked requests code from ResourceDispatcherHost::~ResourceDispatcherHost() to ResourceDispatcherHost::OnShutdown().

This causes the requests to be cancelled on the IO thread rather than the UI thread, which is important since cancellation may delete the URLRequest (and URLRequests should not outlive the IO thread).

BUG=39243
Review URL: http://codereview.chromium.org/1213004
------------------------------------------------------------------------
r42571 | maruel@chromium.org | 2010-03-25 02:48:18 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host_mock.h

Revert 42551 "Add a "download" step into the DataTypeManager"

TEST=valgrind test: unit should turn green
BUG=none

Review URL: http://codereview.chromium.org/1313004
------------------------------------------------------------------------
r42569 | maruel@chromium.org | 2010-03-25 02:34:14 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   D /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Reverts 42520 and 42477. It back red again when adding this change back.

TEST=valgrind test: unit should turn green
BUG=38398
BUG=39177

Review URL: http://codereview.chromium.org/1313003
------------------------------------------------------------------------
r42559 | jianli@chromium.org | 2010-03-25 00:37:50 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/translate/page_translator_unittest.cc
   M /trunk/src/chrome_frame/urlmon_upload_data_stream.cc
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/base/upload_data_stream.h
   M /trunk/src/net/base/upload_data_stream_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/spdy/spdy_network_transaction.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/glue_serialize_unittest.cc
   M /trunk/src/webkit/glue/mock_resource_loader_bridge.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Support sending a sliced file in chromium.

BUG=none
TEST=The WebKit Layout test.

Review URL: http://codereview.chromium.org/594036
------------------------------------------------------------------------
r42558 | sky@chromium.org | 2010-03-25 00:30:24 +0100 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc

Makes the password field show the text 'Password' when empty.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1222003
------------------------------------------------------------------------
r42556 | cpu@chromium.org | 2010-03-25 00:22:52 +0100 (Thu, 25 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc

Diagnostic mode shows wrong size for certain paths
- See the bug, it has a screenshot

The problem is that we need to recourse over the directory.

TEST=none
BUG=39130

Review URL: http://codereview.chromium.org/1252002
------------------------------------------------------------------------
r42554 | jrg@chromium.org | 2010-03-25 00:17:31 +0100 (Thu, 25 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Fix bookmarks in the chevron "off the side" menu.

BUG=39196

TEST=bookmarks in the chevron "off the side" menu now work.
Context menu over a folder of bookmarks has "open all..." enabled.
Context menu over an empty bookmark folder has "open all..." DISabled.

Review URL: http://codereview.chromium.org/1223004
------------------------------------------------------------------------
r42553 | jrg@chromium.org | 2010-03-25 00:13:35 +0100 (Thu, 25 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm

Fix DCHECK if dragging bookmarks around on detached bar.

BUG=39071
TEST=NTP, detach bookmark bar.  Drag and drop something.


Review URL: http://codereview.chromium.org/1315004
------------------------------------------------------------------------
r42551 | skrul@chromium.org | 2010-03-24 23:55:01 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host_mock.h

Add a "download" step into the DataTypeManager
The download step invokies SBH::ConfigureDataTypes() and waits for the task callback.  Currently SBH::ConfigureDataTypes() is stubbed out, it will be implemented in the next change.

I also added some additional unit tests to the DTMImpl to make sure Stop() works while pasue and resume are pending, and to make sure the SYNC_CONFIGURE_DONE notification is always sent.

Review URL: http://codereview.chromium.org/1311001
------------------------------------------------------------------------
r42548 | rsesek@chromium.org | 2010-03-24 23:33:08 +0100 (Wed, 24 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tab_menu_model.cc

[Mac] Re-enable pinned tabs; add support for mini-tabs and phantom tabs.

This CL rewires the old support for pinned tabs to support mini-tabs. This also
removes the kEnablePinnedTabs browser default now that all platforms support it.
Note that pinning is now only accessible through the context menu; drag-to-pin
has been removed.

BUG=36798, 32845
TEST=Right-click and pin two tabs. Test dragging on and off and around the tab strip.
TEST=Cmd+W a pinned tab and it should go phantom (renderer closes down) and the tab is made alpha.

Review URL: http://codereview.chromium.org/1119005
------------------------------------------------------------------------
r42546 | jrg@chromium.org | 2010-03-24 23:06:06 +0100 (Wed, 24 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   A /trunk/src/chrome/browser/cocoa/bookmark_folder_target.h
   A /trunk/src/chrome/browser/cocoa/bookmark_folder_target.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_folder_target_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Cmd-click in bookmark subfolders will open all.
Refactor code for better sharing.

BUG=http://crbug.com/26380 (cmd-click in subfolders now opens all)
BUG=http://crbug.com/35966 (code dup reduced)

TEST=\
Cmd-click a folder in the bar --> open all
Cmd-click a folder in a SUBfolder of the bar --> open all

Review URL: http://codereview.chromium.org/1134008
------------------------------------------------------------------------
r42545 | huanr@chromium.org | 2010-03-24 23:01:25 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_constants.cc
   M /trunk/src/chrome/installer/util/master_preferences_constants.h
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc

Add import_bookmarks_from_file option to master pref that
sliently import bookmarks from file in first run.

BUG=32728
TEST=unit test

Review URL: http://codereview.chromium.org/1257001
------------------------------------------------------------------------
r42544 | jar@chromium.org | 2010-03-24 22:58:31 +0100 (Wed, 24 Mar 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/net_util.cc

Add IPv6 probe support for Windows

This is meant to test to see if AI_ADDRCONFIG is doing its
job in windows, or if we have to do the scans when there is
a network change.

Also switch to always doing probe support on Mac/Linux platforms.
There appears to be (on aggregate) around a 40% degradation of
DNS resolution times on the Mac, and about 17% degration on
Linux, when we don't probe.  It is likely that a few users
are greatly impacted by this, and are able to move the average
of the whole user population.


BUG=12754
BUG=25680
r=wtc
Review URL: http://codereview.chromium.org/1210003
------------------------------------------------------------------------
r42538 | atwilson@google.com | 2010-03-24 22:29:05 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac_unittest.mm
   A /trunk/src/chrome/browser/cocoa/status_icons/status_tray_mac.h
   A /trunk/src/chrome/browser/cocoa/status_icons/status_tray_mac.mm
   A /trunk/src/chrome/browser/status_icons/status_icon.cc
   M /trunk/src/chrome/browser/status_icons/status_icon.h
   A /trunk/src/chrome/browser/status_icons/status_icon_unittest.cc
   M /trunk/src/chrome/browser/status_icons/status_tray.cc
   M /trunk/src/chrome/browser/status_icons/status_tray.h
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc
   A /trunk/src/chrome/browser/views/status_icons
   A /trunk/src/chrome/browser/views/status_icons/status_icon_win.cc
   A /trunk/src/chrome/browser/views/status_icons/status_icon_win.h
   A /trunk/src/chrome/browser/views/status_icons/status_tray_win.cc
   A /trunk/src/chrome/browser/views/status_icons/status_tray_win.h
   A /trunk/src/chrome/browser/views/status_icons/status_tray_win_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Implement status icons on windows.
Refactor existing status icon code to allow platform-specific StatusTray implementation to
track common state for all status icons.

BUG=37375
TEST=new unit tests
Review URL: http://codereview.chromium.org/1136005
------------------------------------------------------------------------
r42535 | estade@chromium.org | 2010-03-24 22:15:53 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc

views/gtk: Set the tooltip text for tab strip and new tab button. 

BUG=25442
TEST=hover the mouse through either the tab strip close button or the new tab button, see if a tooltip appears. 
Patch by Thiago Farina
original review: http://codereview.chromium.org/669246
Review URL: http://codereview.chromium.org/1254002
------------------------------------------------------------------------
r42533 | viettrungluu@chromium.org | 2010-03-24 22:08:22 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.h

Add link to disable individual plug-ins in Plug-ins tab of Content Settings (Windows/Views part).

BUG=736
TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/.

Review URL: http://codereview.chromium.org/1309001
------------------------------------------------------------------------
r42530 | mirandac@chromium.org | 2010-03-24 21:54:14 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm

Add "import bookmarks" link to bookmark bar when it is devoid of folders or links.

The link itself was added to the nib as an NSButton; the link and "no bookmarks" text were both embedded in a GTMWidthTweaker to keep them nicely positioned when localized.

BUG= 28753
TEST= create browser with empty profile or remove all bookmarks. Link should appear that creates a dialog box which allows you to import data from other browsers, as in Windows version.
Review URL: http://codereview.chromium.org/1246001
------------------------------------------------------------------------
r42529 | rafaelw@chromium.org | 2010-03-24 21:52:22 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Add instructions to chrome://extensions page for inspecting popups.

Under "Inspect Active Views", any extension that has a browser or page action will show grayed text directing the developer to right click on the icon and select 'Inspect Popup'

BUG=24477
TEST=Install an extension with a page or browser action. Go to chrome://extensions, turn on developer mode. Verify that under "inspect active views", the new instructions appear.

Review URL: http://codereview.chromium.org/1198002
------------------------------------------------------------------------
r42528 | brettw@chromium.org | 2010-03-24 21:50:34 +0100 (Wed, 24 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/browser_process_impl.cc

Do some browser_main cleanup. This moves ChromeOS login manager and some first
run UI stuff to new helper functions. It renames CheckForWin2000 to a generic
one that each platform can implement according to its needs. I removed the
Platform namespace which was improperly named, and didn't seem to be helping
anything anyway.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1139009
------------------------------------------------------------------------
r42525 | michaeln@chromium.org | 2010-03-24 21:38:29 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/browser/cocoa/cookie_details.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/views/appcache_info_view.cc
   M /trunk/src/chrome/browser/views/appcache_info_view.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   A /trunk/src/chrome/browser/views/generic_info_view.cc
   A /trunk/src/chrome/browser/views/generic_info_view.h
   A /trunk/src/chrome/browser/views/generic_info_view_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Put up a prompt to create appcaches if the Content Settings indicate to do so. Done for windows and linux (sorry mac, you're out of luck). Also put in place a GenericInfoView class.

BUG=38362
TEST=manual and generic_info_view_unittest.cc

Review URL: http://codereview.chromium.org/1115005
------------------------------------------------------------------------
r42522 | jcivelli@chromium.org | 2010-03-24 21:32:52 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc

Some layout adjustements to the app launcher so it shows
properly on ChromeOS.

BUG=None
TEST=Open the app launcher on ChromeOS it should show
     entirely without any scrollbar.
 
Review URL: http://codereview.chromium.org/1297001
------------------------------------------------------------------------
r42521 | arv@chromium.org | 2010-03-24 21:31:53 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Remove work arounds for drop/dragend order.

This was recently fixed in Chrome.

BUG=31292
TEST=Dragging and dropping items in the NTP and bookmarks still works.

Review URL: http://codereview.chromium.org/1306001
------------------------------------------------------------------------
r42520 | maruel@chromium.org | 2010-03-24 21:19:16 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   A /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Reapply 42467 by reverting 42499 and added suppression.
"Clear cookies, local storage and databases when an extension gets uninstalled."

BUG=39177
BUG=38398

Review URL: http://codereview.chromium.org/1210004
------------------------------------------------------------------------
r42519 | aa@chromium.org | 2010-03-24 20:59:41 +0100 (Wed, 24 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Generalize the ExtensionFunctionDispatcher::Delegate interface a bit more. In particular remove GetExtensionHost() and GetExtensionDOMUI(). I'm going to add a new type of EFD::Delegate soon that is neither of these, and I don't think it makes sense to have the code assume that EFD::Delegate must be one of the two of them.

Some code still does RTTI stuff through RenderViewHostDelegate::GetRenderViewType(), but in that case it is more clear that there are a long list of potential view types, and that the caller must be more careful.

Review URL: http://codereview.chromium.org/1149003
------------------------------------------------------------------------
r42517 | nkostylev@google.com | 2010-03-24 20:52:05 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.cc
   A /trunk/src/chrome/browser/chromeos/cros/cros_in_process_browser_test.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_power_library.h
   A /trunk/src/chrome/browser/chromeos/login/network_screen_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Create trivial test for OOBE network selection screen.
Create base class for Chromium OS tests mocking CrosLibrary.
Fix CrosLibrary mocks.

TEST=out/Debug/browser_tests --gtest_filter=NetworkScreenTest*

Review URL: http://codereview.chromium.org/1279002
------------------------------------------------------------------------
r42516 | viettrungluu@chromium.org | 2010-03-24 20:51:58 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.h

Add link to disable individual plug-ins in Plug-ins tab of Content Settings (Linux gtk part).

BUG=736
TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/.

Review URL: http://codereview.chromium.org/1303002
------------------------------------------------------------------------
r42515 | davemoore@chromium.org | 2010-03-24 20:49:43 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h

Don't initialize extensions for the wizard profile
The extensions services can't be run in multiple profiles.
The team is working on a fix, but this keeps it from happening.

BUG=38929
TEST=Install extension in cros without crashing.

Review URL: http://codereview.chromium.org/1213003
------------------------------------------------------------------------
r42513 | estade@chromium.org | 2010-03-24 20:40:47 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

Gtk: add a separator at the right of the browser actions toolbar.

The spacing changes in browser_toolbar_gtk are necessary to get the spacing between the separator and the page menu correct. It shouldn't affect the spacing in any other circumstance.

BUG=none
TEST=visual

Review URL: http://codereview.chromium.org/1248001
------------------------------------------------------------------------
r42512 | evan@chromium.org | 2010-03-24 20:38:33 +0100 (Wed, 24 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

linux: swap buttons in sync cancel dialog

Primary action goes on the right.

Review URL: http://codereview.chromium.org/1252001
------------------------------------------------------------------------
r42511 | andybons@chromium.org | 2010-03-24 20:38:25 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   A /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Finish up the resizing code for the Browser Actions container complete with animations and all. Also added basic skeleton unit test for container.
Polish bugs to be filed:
o Resizing the container is not synced across windows.
o Buttons do not animate in/out when added/removed.

TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1198001
------------------------------------------------------------------------
r42510 | evan@chromium.org | 2010-03-24 20:37:22 +0100 (Wed, 24 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

linux: allow options dialog to be resized smaller

BUG=37786

Review URL: http://codereview.chromium.org/1253001
------------------------------------------------------------------------
r42509 | pkasting@chromium.org | 2010-03-24 20:24:51 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc

Try to fix compile failure.

BUG=27570
TEST=none
TBR=estade
Review URL: http://codereview.chromium.org/1302001
------------------------------------------------------------------------
r42502 | pkasting@chromium.org | 2010-03-24 20:00:55 +0100 (Wed, 24 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Omnibox M5 work, part 1: Security changes

* Remove yellow background
* Move lock icon from right side to left side (only on Win)
* Change iconography
* Change scheme colors
* Add label for "Untrusted website"
* Remove tooltip on label

This also simplifies the LocationBarView code on Windows now that LocationBarImageView is unnecessary, and reorders a few things to try and be in more consistent/physical order.

BUG=27570
TEST=Visit various https sites and see that the security icon is on the left, the scheme is colored, and there is no yellow background.
Review URL: http://codereview.chromium.org/1056002
------------------------------------------------------------------------
r42500 | mpcomplete@chromium.org | 2010-03-24 19:53:01 +0100 (Wed, 24 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Adjust the spacing and alignment on the extension management page a bit.

Review URL: http://codereview.chromium.org/1232001
------------------------------------------------------------------------
r42499 | maruel@chromium.org | 2010-03-24 19:45:45 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   D /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Revert r42467: "Clear cookies, local storage and databases when an extension gets uninstalled."

It introduced a memory leak, causing a regression on valgrind test: unit.

TBR=jochen

Review URL: http://codereview.chromium.org/1295001
------------------------------------------------------------------------
r42498 | dmazzoni@chromium.org | 2010-03-24 19:36:03 +0100 (Wed, 24 Mar 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   A /trunk/src/chrome/test/interactive_ui/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Keyboard accessibility for the page and app menus.
Works on Windows, and on Linux with toolkit_views.

The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.

Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.

Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.

A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.

BUG=none
TEST=New keyboard accessibility interactive ui test.

Review URL: http://codereview.chromium.org/660323
------------------------------------------------------------------------
r42497 | bauerb@chromium.org | 2010-03-24 19:20:37 +0100 (Wed, 24 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc

Make repost form warning tab-modal on Gtk.

This is the Gtk version of http://codereview.chromium.org/969003.

Trying this again after it broke the Chrome OS build the first time (which was http://src.chromium.org/viewvc/chrome?view=rev&revision=42474).

BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown.

Review URL: http://codereview.chromium.org/1279003
------------------------------------------------------------------------
r42495 | bulach@chromium.org | 2010-03-24 19:02:41 +0100 (Wed, 24 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/test/data/geolocation/iframes_different_origin.html

Tentative fix for geolocation test with iframes: loads frame one by one.

Mark as "flaky" to analyze how it behaves, will fully enable it once it's proven stable.

Restructure the tests a bit in order to simplify the usage of mocks.

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/1081012
------------------------------------------------------------------------
r42494 | erg@chromium.org | 2010-03-24 18:57:12 +0100 (Wed, 24 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Revert "Fix browser side handling of moveTo by resizing the content area; not the window."

This reverts commit 2ce3ea80b627f58acb97802b0cc182b3a2bdf809 (r40386).

This seems to tickle some weird race condition where the renderer and the
browser process disagree about the size of the window. I'm reverting this
change as 38685 is scarier then 27365.

TEST=none
BUG=38785,27365

Review URL: http://codereview.chromium.org/1259004
------------------------------------------------------------------------
r42490 | stuartmorgan@chromium.org | 2010-03-24 18:44:27 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc

Fix resizing handling for accelerated Mac plugins

BUG=39185
TEST=Toggle size on YouTube video with CA enabled.

Review URL: http://codereview.chromium.org/1259002
------------------------------------------------------------------------
r42489 | arv@chromium.org | 2010-03-24 18:41:28 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/plugins.html

Fix HTML errors in plugins and extension UIs

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1261001
------------------------------------------------------------------------
r42488 | arv@chromium.org | 2010-03-24 18:38:33 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/chrome/browser/resources/about_memory.html
   M /trunk/src/chrome/browser/resources/about_memory_linux.html
   M /trunk/src/chrome/browser/resources/about_memory_mac.html
   M /trunk/src/chrome/browser/resources/about_os_credits.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/list.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   M /trunk/src/chrome/browser/security/resources/ssl_error.html
   M /trunk/src/chrome/browser/security/resources/ssl_roadblock.html
   M /trunk/src/chrome/browser/sync/resources/about_sync.html
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

Remove vendor specific CSS prefixes.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1182001
------------------------------------------------------------------------
r42486 | skerner@chromium.org | 2010-03-24 18:38:24 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/test/data/extensions/api_test/history/test.js

History APIs that parse a time as a number of milliseconds need to allow integer numbers.

BUG=38994
TEST=ExtensionApiTest.FLAKY_History

Review URL: http://codereview.chromium.org/1221001
------------------------------------------------------------------------
r42483 | dhg@chromium.org | 2010-03-24 18:26:51 +0100 (Wed, 24 Mar 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/mediaplayer_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Adding test for basic uses of mediaplayer.

Review URL: http://codereview.chromium.org/1213001
------------------------------------------------------------------------
r42482 | skerner@chromium.org | 2010-03-24 18:21:07 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api_constants.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.history.html
   M /trunk/src/chrome/test/data/extensions/api_test/history/test.js
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/disabled/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/permissions/enabled/background.html

Change chrome.experimental.history.search's first param to use 'text' for text search.

BUG=38995
TEST=ExtensionApiTest.FLAKY_History'

Review URL: http://codereview.chromium.org/1102007
------------------------------------------------------------------------
r42481 | viettrungluu@chromium.org | 2010-03-24 18:14:02 +0100 (Wed, 24 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm

Add link to disable individual plug-ins in Plug-ins tab of Content Settings (Mac part).

.xib change: Add hyperlink button with text "^IDS_PLUGIN_SELECTIVE_DISABLE" and
hooked up to -openPluginsPage: of file's owner.

BUG=736
TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/.

Review URL: http://codereview.chromium.org/1285002
------------------------------------------------------------------------
r42479 | dhollowa@chromium.org | 2010-03-24 18:02:15 +0100 (Wed, 24 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Revert 42474 - Make repost form warning tabmodal on Gtk.

This is the Gtk version of http://codereview.chromium.org/969003.

BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perlcgi/programs/form1POST.html, hit Submit, then refresh. The warning sheet should be tabmodal, not windowmodal. Opening a login form (which is also tabmodal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown.

Review URL: http://codereview.chromium.org/660434

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1247004
------------------------------------------------------------------------
r42478 | dhollowa@chromium.org | 2010-03-24 17:33:22 +0100 (Wed, 24 Mar 2010) | 11 lines
Changed paths:
   D /trunk/src/chrome/browser/net/chrome_cookie_notification_details.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Revert 42473 - Add a delegate to CookieMonster and broadcast notifications about changes to cookies.

This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event

BUG=38398
TEST=net_unittests

Review URL: http://codereview.chromium.org/1023004

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1256003
------------------------------------------------------------------------
r42474 | bauerb@chromium.org | 2010-03-24 17:11:59 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Make repost form warning tab-modal on Gtk.

This is the Gtk version of http://codereview.chromium.org/969003.

BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown.

Review URL: http://codereview.chromium.org/660434
------------------------------------------------------------------------
r42473 | jochen@chromium.org | 2010-03-24 17:06:01 +0100 (Wed, 24 Mar 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/net/chrome_cookie_notification_details.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Add a delegate to CookieMonster and broadcast notifications about changes to cookies.

This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event

BUG=38398
TEST=net_unittests

Review URL: http://codereview.chromium.org/1023004
------------------------------------------------------------------------
r42471 | finnur@chromium.org | 2010-03-24 17:00:34 +0100 (Wed, 24 Mar 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource.h

Eliminate all UI thread decoding of extension images. 

Except one, that is. We have one location we need to 
take a look at (I've added a comment). This changelist 
converts UI usage of DecodeImage on the UI thread to 
a revamped and simplified ImageLoadingTracker class. 

I plan on adding to GetFilePath a DCHECK for the File 
thread but decided to do so in another changelist, 
since it has a high likelyhood of flushing something 
out and be backed out because of that. This started 
out as issue 38521 (make infobar use cached icons) 
but grew in scope to just eliminate all UI thread 
access to DecodeImage and GetFilePath. 

BUG=http://crbug.com/38521 
TEST=None (extensions should work as before)

Review URL: http://codereview.chromium.org/1075006
------------------------------------------------------------------------
r42468 | dmazzoni@chromium.org | 2010-03-24 16:16:10 +0100 (Wed, 24 Mar 2010) | 29 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   D /trunk/src/chrome/test/ui/keyboard_access_uitest.cc
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Revert 42465 - Keyboard accessibility for the page and app menus.

Reverting because newly added Test*MenuKeyboardAccess tests fail on
some of the Windows buildbots, and possibly a XP Perf regression.

Works on Windows, and on Linux with toolkit_views.

The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.

Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.

Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.

A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.

BUG=none
TEST=New keyboard accessibility ui test.

Review URL: http://codereview.chromium.org/660323

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/1257003
------------------------------------------------------------------------
r42467 | jochen@chromium.org | 2010-03-24 15:47:31 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_data_deleter.cc
   A /trunk/src/chrome/browser/extensions/extension_data_deleter.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Clear cookies, local storage and databases when an extension gets uninstalled.

BUG=27938
TEST=Unittest in extension_service_unitttest.cc

Review URL: http://codereview.chromium.org/1095003
Patch from Mattias Nissler.
------------------------------------------------------------------------
r42465 | dmazzoni@chromium.org | 2010-03-24 15:27:08 +0100 (Wed, 24 Mar 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   A /trunk/src/chrome/test/ui/keyboard_access_uitest.cc
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Keyboard accessibility for the page and app menus.
Works on Windows, and on Linux with toolkit_views.

The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.

Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.

Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.

A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.

BUG=none
TEST=New keyboard accessibility ui test.

Review URL: http://codereview.chromium.org/660323
------------------------------------------------------------------------
r42461 | phajdan.jr@chromium.org | 2010-03-24 14:31:24 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

Disable BrowserActionApiTest.BrowserActionPopup, it's crashy.

TEST=greener tree
BUG=39158

Review URL: http://codereview.chromium.org/1266002
------------------------------------------------------------------------
r42460 | avayvod@google.com | 2010-03-24 14:17:50 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Expose current_screen() for tests.
Removed duplicated windows closing from OnLoginSignInSelected().

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1267002
------------------------------------------------------------------------
r42458 | pinkerton@chromium.org | 2010-03-24 13:58:41 +0100 (Wed, 24 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Open bookmarks from clicks in background windows in the correct window, not the active window.
BUG=37832
TEST=cmd-clicking in background windows should open in bg window, foreground window bookmark loading should be unaffected.
Review URL: http://codereview.chromium.org/1202001
------------------------------------------------------------------------
r42455 | phajdan.jr@chromium.org | 2010-03-24 13:55:12 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.h

Update FRIEND_TEST to fix the build.

TBR=maruel
TEST=none
BUG=38522

Review URL: http://codereview.chromium.org/1267003
------------------------------------------------------------------------
r42453 | phajdan.jr@chromium.org | 2010-03-24 13:39:50 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Mark BrowserTest.RestorePinnedTabs as crashy on Mac OS X.

TEST=make tree greener
BUG=38522

Review URL: http://codereview.chromium.org/1216003
------------------------------------------------------------------------
r42441 | jochen@chromium.org | 2010-03-24 09:40:49 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Enforce extension permissions in C++ (instead of Javascript).

BUG=38920
TEST=ExtensionApiTest.Incognito

Review URL: http://codereview.chromium.org/1148009
------------------------------------------------------------------------
r42434 | viettrungluu@chromium.org | 2010-03-24 07:36:19 +0100 (Wed, 24 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   D /trunk/src/chrome/browser/resources/about_plugins.html
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Replace about:plugins page with new page.

Do this by "remapping" about:plugins to chrome://plugins/. Also delete old
about:plugins page and associated strings.

BUG=736
TEST=Go to about:plugins; should get new plugins page (same as chrome://plugins/).

Review URL: http://codereview.chromium.org/1219005
------------------------------------------------------------------------
r42433 | hbono@chromium.org | 2010-03-24 06:47:17 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/aeropeek_manager.cc

A quick fix for Issue 38587.
This issue is caused by my bonehead mistake that forgot setting the parent windows of AeroPeek windows. This change just sets the BrowserFrame object (which owns AeroPeek windows) to their parent window so we can minimize AeroPeek windows when we minimize the BrowserFrame.

BUG=38597
TEST=Open two or more tabs, minimize Chrome, and verify there are not any garbage windows on Desktop.
Review URL: http://codereview.chromium.org/1120011
------------------------------------------------------------------------
r42432 | suzhe@chromium.org | 2010-03-24 06:07:52 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.h
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

[Linux] Always enable emacs key bindings.

BUG=37852 C-u views source in password entries
TEST=See bug report.

Review URL: http://codereview.chromium.org/1113008
------------------------------------------------------------------------
r42430 | oshima@chromium.org | 2010-03-24 05:41:54 +0100 (Wed, 24 Mar 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/compact_navigation_bar_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
   A /trunk/src/chrome/browser/chromeos/view_ids.h
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

basic browser tests for compact navigation bar.
 * Tests if Browser::ToggleCompactNavigationBar() turns on/off
 compact navigation bar and tool bar.
 * Tests if the accelerator works.

BUG=http://crosbug.com/2028
TEST=new tests CompactNativationBarTest.TestBasic/TestAccelerator should pass.

Review URL: http://codereview.chromium.org/1200001
------------------------------------------------------------------------
r42427 | dpranke@google.com | 2010-03-24 04:55:32 +0100 (Wed, 24 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Revert r42426 - tests are failing because the WebKit LayoutTests directories
aren't checked out on the bots. We need to figure out how to deal with this
since we don't want to keep expectations downstream if we can avoid it.

    BUG=none
    R=none
    TEST=bots stay green

Review URL: http://codereview.chromium.org/1253002
------------------------------------------------------------------------
r42426 | dpranke@google.com | 2010-03-24 04:47:48 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Use upstream layout_test baselines since the downstream ones are going away.

    BUG=none
    TEST=bots stay green
    R=eroman@chromium.org

Review URL: http://codereview.chromium.org/1214001
------------------------------------------------------------------------
r42425 | cevans@chromium.org | 2010-03-24 04:37:40 +0100 (Wed, 24 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc

Up the safe browsing timeout from 1s to 5s.
After a conversation with Eric, we're not worried about attacker pages loading
down the local machine or network (because such pages would themselves be
candidates for being flagged).
The concern is users with slow network connections, or random network / server
jitter.

BUG=36774
TEST=NONE

Review URL: http://codereview.chromium.org/1242001
------------------------------------------------------------------------
r42424 | mhm@chromium.org | 2010-03-24 04:12:10 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Add MSAA Accessible information to Find bar.

BUG=9606
TEST=Inspect32 has accessible names for those components.

Review URL: http://codereview.chromium.org/1110013
------------------------------------------------------------------------
r42421 | eroman@chromium.org | 2010-03-24 03:00:41 +0100 (Wed, 24 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc

Avoid calling ExecuteCode() on a NULL TabContents. The problem was an extra set of parens were missing, so the "not" operator only applied to the GetTabById() return value.

BUG=34778

Review URL: http://codereview.chromium.org/1238001
------------------------------------------------------------------------
r42419 | zelidrag@chromium.org | 2010-03-24 02:29:46 +0100 (Wed, 24 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc

Fixed loader issue in unit tests caused by some test not using that mock and causing the library to appear already loaded in a failed state.


Review URL: http://codereview.chromium.org/1251001
------------------------------------------------------------------------
r42418 | maruel@chromium.org | 2010-03-24 02:28:40 +0100 (Wed, 24 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src
   M /trunk/src/chrome/browser/autofill

Add out and chrome/browser/autofill/internal to svn:ignore.

------------------------------------------------------------------------
r42413 | nick@chromium.org | 2010-03-24 01:27:18 +0100 (Wed, 24 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils.h
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.h
   A /trunk/src/chrome/browser/sync/engine/store_timestamps_command.cc
   A /trunk/src/chrome/browser/sync/engine/store_timestamps_command.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc
   M /trunk/src/chrome/browser/sync/sessions/session_state.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller.cc
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/ipc_test_sink.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/webmessageportchannel_impl.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Make it clear what last_sync_timestamp actually tracks.  Update
last_sync_timestamp from the new_timestamp only, never from per-entry
timestamps.  Use what the server sends us to know whether or not there
are more updates to fetch.  Eliminate some unnecessarily complicated
logic having to do with the # of updates returned -- that's always a red
herring; with server-side filtering, it is indeed possible for 0 updates
to be returned along with a new timestamp.

BUG=37373
TEST=manual testing of 2 browser sync; unit tests.

Review URL: http://codereview.chromium.org/1161006
------------------------------------------------------------------------
r42412 | viettrungluu@chromium.org | 2010-03-24 01:21:34 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/plugins_ui.cc
   A /trunk/src/chrome/browser/dom_ui/plugins_ui.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   A /trunk/src/chrome/browser/resources/plugins.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/webkit/glue/plugins/plugin_lib_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_lib_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/webplugininfo.h

Implement chrome://plugins page that can disable plugins.

BUG=736
TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions.

Review URL: http://codereview.chromium.org/1085003
------------------------------------------------------------------------
r42411 | feldstein@chromium.org | 2010-03-24 01:16:36 +0100 (Wed, 24 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js

Add multiple item selection to BMM on mac

BMM was originally only checking for the control key on non-mac platforms.

BUG=39085
TEST=Select some non-contiguous bookmarks and copy and paste them, without the
elements in between

Review URL: http://codereview.chromium.org/1225001
------------------------------------------------------------------------
r42409 | jrg@chromium.org | 2010-03-24 01:04:24 +0100 (Wed, 24 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Automation provider IsBookmarkBarVisible() always returned yes!

BUG=39013

TEST=pyautolib bookmark_bar.py script will now work on Linux

Review URL: http://codereview.chromium.org/1227003
------------------------------------------------------------------------
r42408 | dhg@chromium.org | 2010-03-24 01:00:50 +0100 (Wed, 24 Mar 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/app/theme/mediaplayer_full_screen.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/resources/mediaplayer.html

adding fullscreen support to the mediaplayer.

Tested by loading on device and clicking fullscreen button.  (needs most recent codebase)
Review URL: http://codereview.chromium.org/1034002
------------------------------------------------------------------------
r42405 | zelidrag@chromium.org | 2010-03-24 00:44:24 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros/cros_library_loader.cc
   A /trunk/src/chrome/browser/chromeos/cros/cros_library_loader.h
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/language_library.h
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_cros_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_language_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_library_loader.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_login_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_mount_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_network_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_power_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/google_update_chromeos.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/utils.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/ip_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc
   M /trunk/src/chrome/browser/chromeos/text_input/text_input.gyp
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi

Mocks for all libcros elements. Added library registry object that provides access to all *Libray classes that used to be singletons. This registry adds an indirection layer that will let is replace the actual objects with mocks during test runs. 

BUG=chromium-os:2026
TEST=none

Review URL: http://codereview.chromium.org/1142005
------------------------------------------------------------------------
r42404 | johnnyg@chromium.org | 2010-03-24 00:39:09 +0100 (Wed, 24 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.mm
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   A /trunk/src/chrome/browser/notifications/balloon_host.cc
   A /trunk/src/chrome/browser/notifications/balloon_host.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor BalloonViewHost, removing a lot of duplicate code that crept into notifications during the port to mac & linux and making behavior more consistent.

BUG=34826
TEST=notifications on each platform.

Review URL: http://codereview.chromium.org/1055005
------------------------------------------------------------------------
r42400 | jcivelli@google.com | 2010-03-24 00:35:49 +0100 (Wed, 24 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Don't autotranslate in incognito mode (so we don't send information
to the translation server without the user consent).
Also added unit-tests for prefs.

BUG=38107
TEST=Visit a page that triggers the translate infobar. Translate the
     page. Select "Always translate <lang1> to <lang2>".
     Open a page in lang1. The page should automatically be translated
     to lang2.
     Open an incognito window. Navigate to a page in lang1, the page
     should not automcatically be translated, an infobar should ask
     if the user wants to translate the page.

Review URL: http://codereview.chromium.org/1184001
------------------------------------------------------------------------
r42394 | mpcomplete@chromium.org | 2010-03-23 23:44:08 +0100 (Tue, 23 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Fix 2 bugs related to remembering loaded unpacked extensions.
- Extension disabled infobar was being shown at startup.
- Crashed extensions were persisted as unpacked extensions, regardless of how
they were installed.

BUG=30116
BUG=38856

Review URL: http://codereview.chromium.org/1157005
------------------------------------------------------------------------
r42389 | estade@chromium.org | 2010-03-23 23:20:47 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.h
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc

GTK: allow inspecting of extension popups.

BUG=24477
TEST=manual

Review URL: http://codereview.chromium.org/1170001
------------------------------------------------------------------------
r42384 | skrul@chromium.org | 2010-03-23 22:47:04 +0100 (Tue, 23 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_manager.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

This is basically a rewrite of the DataTypeManager to support dynamic data type configuration.  DTM::Start() has been replaced with DTM::Configure().  Note that the callback is also gone, replaced with notification service style notifications to tell listeners that configuration has started or finished.

I also added some stuff to prepare for adding the "initial download" step for new datatype into the configure process.

Review URL: http://codereview.chromium.org/1128012
------------------------------------------------------------------------
r42383 | jcivelli@chromium.org | 2010-03-23 22:45:43 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/app_launcher.cc
   M /trunk/src/chrome/browser/views/app_launcher.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome_browser.gypi

Some layout related fixes for the app launchers.

BUG=None
TEST=Check that the app launcher is displayed correctly on ChromeOS
     and Windows (when using the --app-launcher-new-tab)

Review URL: http://codereview.chromium.org/1171002
------------------------------------------------------------------------
r42380 | kbr@google.com | 2010-03-23 22:05:52 +0100 (Tue, 23 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc

Fixed missing code in EnqueueTextureForDeletion.

BUG=38945
TEST=reloaded Pepper 3D plugins repeatedly

NOTE: encountered unrelated problems while testing. These changes
should be stress tested with CA plugins.

Review URL: http://codereview.chromium.org/1110011
------------------------------------------------------------------------
r42378 | joi@chromium.org | 2010-03-23 21:51:01 +0100 (Tue, 23 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi_unittest.cc
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h

Revert 42366 - Allow TabContentsDelegate classes to specify whether InfoBars are enabled.
Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer.
BUG=2444936

Patch contributed by ericdingle@google.com
Original review at http://codereview.chromium.org/890005


TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/1205001
------------------------------------------------------------------------
r42375 | kbr@google.com | 2010-03-23 21:09:49 +0100 (Tue, 23 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/gpu/gpu_channel.cc
   M /trunk/src/chrome/gpu/gpu_main.cc
   M /trunk/src/chrome/renderer/render_widget.cc

Fixed bugs in GPU process startup on POSIX platforms. Added
--gpu-startup-dialog command line option to allow debugging of GPU
process.

BUG=none
TEST=none (tested manually in development workspace)

Review URL: http://codereview.chromium.org/1095005
------------------------------------------------------------------------
r42374 | avi@chromium.org | 2010-03-23 20:52:22 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Alter the "get themes" action on Mac to behave like other platforms; fix bugs.

BUG=http://crbug.com/38002
TEST=as in bug

Review URL: http://codereview.chromium.org/1105010
------------------------------------------------------------------------
r42371 | tim@chromium.org | 2010-03-23 20:28:47 +0100 (Tue, 23 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h

Fix bustage by adding friend decl.

TBR=nick
Review URL: http://codereview.chromium.org/1192001
------------------------------------------------------------------------
r42369 | tim@chromium.org | 2010-03-23 20:20:04 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Disable SyncerThreadWithSyncerTest.Pause.  It's timing out, so I can't use FLAKY :(

TBR=skrul
BUG=39070

Review URL: http://codereview.chromium.org/1189001
------------------------------------------------------------------------
r42368 | tonyg@chromium.org | 2010-03-23 20:18:10 +0100 (Tue, 23 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_win.cc

Factoring duplicate code from platform-specific LoginHandlers into a base 
LoginHandler class. As pointed out by erg, it would be cleaner to use a 
separate controller class, but this simple refactor should make that easier. 

Originally submitted as 41739, however that patch had to be reverted because
I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in
the LoginHandler ctor. That is fixed now.

BUG=14909
TEST=ui_tests --gtest_filter=LoginPromptTest*

Review URL: http://codereview.chromium.org/995004
------------------------------------------------------------------------
r42366 | joi@chromium.org | 2010-03-23 20:08:02 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi_unittest.cc
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h

Allow TabContentsDelegate classes to specify whether InfoBars are enabled.
Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer.
BUG=2444936

Patch contributed by ericdingle@google.com
Original review at http://codereview.chromium.org/890005

------------------------------------------------------------------------
r42365 | stuartmorgan@chromium.org | 2010-03-23 19:57:35 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix Cocoa variable names from accelerated plugin changes

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1180001
------------------------------------------------------------------------
r42364 | chocobo@chromium.org | 2010-03-23 19:50:06 +0100 (Tue, 23 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   A /trunk/src/chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/chrome_tests.gypi

Add tests for ClockMenuButton.
Review URL: http://codereview.chromium.org/1130008
------------------------------------------------------------------------
r42362 | evan@chromium.org | 2010-03-23 19:14:28 +0100 (Tue, 23 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/external_metrics.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h
   M /trunk/src/chrome/browser/options_page_base.cc
   M /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/tools/extract_actions.py

UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.
That way it is easier to keep track of those constants in reporting tools.

TEST=Covered with standard ui tests

Patch by Frank Mantek <fmantek@google.com>.

Review URL: http://codereview.chromium.org/811005
------------------------------------------------------------------------
r42361 | arv@chromium.org | 2010-03-23 19:12:17 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.h

HTML5: Make sure that the drop event fires before the dragend event.

BUG=31292
TEST=bookmark_bar_view_test and I also ran the test case. NTP and Bookmark manager also works.

Review URL: http://codereview.chromium.org/1084014
------------------------------------------------------------------------
r42358 | eroman@chromium.org | 2010-03-23 18:49:35 +0100 (Tue, 23 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Mark a test which has been failing regularly on the valgrind UI bot as FLAKY_.
BUG=39057

Review URL: http://codereview.chromium.org/1074010
------------------------------------------------------------------------
r42357 | eroman@chromium.org | 2010-03-23 18:47:49 +0100 (Tue, 23 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   A /trunk/src/chrome/browser/resources/net_internals/detailsview.js
   M /trunk/src/chrome/browser/resources/net_internals/index.html
   A /trunk/src/chrome/browser/resources/net_internals/layoutmanager.js
   A /trunk/src/chrome/browser/resources/net_internals/loggrouper.js
   A /trunk/src/chrome/browser/resources/net_internals/logviewpainter.js
   A /trunk/src/chrome/browser/resources/net_internals/main.css
   A /trunk/src/chrome/browser/resources/net_internals/main.js
   A /trunk/src/chrome/browser/resources/net_internals/requestsview.js
   A /trunk/src/chrome/browser/resources/net_internals/sourceentry.js
   A /trunk/src/chrome/browser/resources/net_internals/timelineviewpainter.js
   A /trunk/src/chrome/browser/resources/net_internals/util.js
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/net/base/net_log.cc
   M /trunk/src/net/base/net_log.h
   M /trunk/src/net/socket/client_socket_pool_base.cc

Add an initial implementation of net-internals inspector in javascript.

BUG=37421

Review URL: http://codereview.chromium.org/1088007
------------------------------------------------------------------------
r42356 | stuartmorgan@chromium.org | 2010-03-23 18:46:07 +0100 (Tue, 23 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Add a temporary flag to enable Core Animation mode for Flash (when possible)

This makes our Mac wmode hack--which prevents Flash from using "accelerated" QuickDraw mode, which is incredibly slow for us, but also prevents Flash 10.1 from using Core Animation in the same cases--conditional based on having both support for Core Animation mode in both Flash and Chromium, and on having a flag.

Once we are confident that there are no regressions preventing us from allowing Core Animation by default, the flag will be removed.

BUG=38932
TEST=Run with --enable-flash-core-animation and the current Flash 10.1 beta on 10.6; sites like YouTube should have negligable CPU usage.

Review URL: http://codereview.chromium.org/1115010
------------------------------------------------------------------------
r42354 | finnur@chromium.org | 2010-03-23 18:41:48 +0100 (Tue, 23 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Revert 42283 - Adds the source ImageLoadingTracker to OnImageLoaded. I need this in a
callback so that I can identify where the image is coming from.

[Reverter's note: There is nothing wrong with this CL per se, except that I'm going to
make it obsolete in my next checkin, so since noone is relying on this change yet, it
is better to revert it than to have a painful merge]

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1167004

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1077011
------------------------------------------------------------------------
r42348 | sky@chromium.org | 2010-03-23 17:16:16 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.h

Modifies friend for test so mac build compiles again.

BUG=none
TEST=none
TBR=maruel@chromium.org

Review URL: http://codereview.chromium.org/1173002
------------------------------------------------------------------------
r42347 | brettw@chromium.org | 2010-03-23 17:12:40 +0100 (Tue, 23 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Move some random groups of functions out of BrowserMain into helper functions.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1146007
------------------------------------------------------------------------
r42344 | sky@chromium.org | 2010-03-23 17:05:29 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Reall disables BrowserTest::RestorePinnedTabs on a mac.

BUG=38522
TBR=maruel

Review URL: http://codereview.chromium.org/1081015
------------------------------------------------------------------------
r42338 | joth@chromium.org | 2010-03-23 13:03:13 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_test_helper.h

Implement the confirm infobar with link for mac.

BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*

Review URL: http://codereview.chromium.org/1127001
------------------------------------------------------------------------
r42337 | joth@chromium.org | 2010-03-23 12:45:19 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h

Implement ConfirmInfoBar link support on GTK
this is the follow up to http://codereview.chromium.org/1037006 which added it on windows, and http://codereview.chromium.org/1127001 which added it to Mac.

BUG=11246
TEST=run browser with --enable-geolocation, open maps.google.com and click my location.

Review URL: http://codereview.chromium.org/1081007
------------------------------------------------------------------------
r42326 | jeremy@chromium.org | 2010-03-23 09:29:43 +0100 (Tue, 23 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Disable "Language Settings..." context menu on OS X.

It doesn't make sense to make this open the "Language Settings" preferenes windows (like on other platforms), since that panel
isn't implemented yet - http://crbug.com/23828.

Once that bug is fixed we can decide whether it make sense to
re-enable this item or change the context menu on OS X.

BUG=34512
TEST=Right click on a text input field on OS X, Spell Checking->Language settings menu item should be disabled.  On Windows the item should be enabled.

Review URL: http://codereview.chromium.org/1161003
------------------------------------------------------------------------
r42324 | dcheng@chromium.org | 2010-03-23 09:09:34 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc

Update WebDropTarget::OnDragEnter to use drag_cursor_ as well.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1139006
------------------------------------------------------------------------
r42322 | hbono@chromium.org | 2010-03-23 08:09:30 +0100 (Tue, 23 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/native_button_win.cc

This change adds shield icons to the buttons that need elevation to fix Issue 29631. This change adds a bool flag |need_elevation_| to notify when a button needs elevation to the NativeButton class and add shield icons to the following buttons.
- on the "Start Chromium" button on the first-run dialog when the "Make Chromium the default browser" checkbox is enabled.
- on the "Set as Default" button on the default browser infobar.
- on the "Make Google Chrome my default browser" button on the Basics tab of options.

BUG=29631
TEST=Launch Chrome when it is not set as a default browser and see the "Set as Default" button has a shield icon.
TEST=Launch Chrome when it is not set as a default browser and open the "Options" dialog, and see its "Make Google Chrome my default browser" button has a shield icon.
TEST=Launch Chrome with a '--first-run' option when it is not set as a default browser, and see its "Launch Chrome" button has a shield icon.
Review URL: http://codereview.chromium.org/661165
------------------------------------------------------------------------
r42321 | asargent@chromium.org | 2010-03-23 07:52:41 +0100 (Tue, 23 Mar 2010) | 38 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   A /trunk/src/chrome/browser/extensions/extension_context_menu_api.cc
   A /trunk/src/chrome/browser/extensions/extension_context_menu_api.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_menu_manager.cc
   A /trunk/src/chrome/browser/extensions/extension_menu_manager.h
   A /trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Initial version of an experimental Extensions Context Menu API.


The proposal for the API is documented at:

http://dev.chromium.org/developers/design-documents/extensions/context-menu-api


Notable limitations in this initial implementation:

-No reliable way to get at the unique, actual node clicked on in contexts like 
 IMAGE/LINK/etc. We'll need to fix this in the long run - see the API proposal
 page for some notes on this.

-No update or deleteAll methods ; the only way you can change items is to delete
 by id and re-add.

-We aren't yet matching the UI goal of having the extension items at the
 top level include the extension icon on the left. This will require a
 refactoring of RenderViewContextMenu to steal some of the code from the
 bookmarks bar context menus, which can display favicons.

-The only kind of parent->child menu that currently works is if you have
 a single top-level parent, and only one level of children. (This is because
 of how RenderViewContextMenu currently works)

-No browser tests that the menu items actually get drawn (will wait on those
 until the above mentioned refactor is complete), or API tests (the API may
 change a bit based on feedback, at which point I'll write more tests).

-Unit tests need to cover some more cases.



BUG=32363
TEST=Should be able to create context menus with this API.

Review URL: http://codereview.chromium.org/1042003
------------------------------------------------------------------------
r42313 | akalin@chromium.org | 2010-03-23 05:14:50 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   D /trunk/src/third_party/libjingle/files/talk/base/win32socketserver.cc
   D /trunk/src/third_party/libjingle/files/talk/base/win32socketserver.h
   M /trunk/src/third_party/libjingle/libjingle.gyp

Removed win32socketserver and its use in mediator_thread_impl.cc.

BUG=38595
TEST=trybots, manual

Review URL: http://codereview.chromium.org/1110007
------------------------------------------------------------------------
r42312 | ben@chromium.org | 2010-03-23 05:05:01 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/gfx/canvas.cc
   D /trunk/src/app/gfx/canvas.h
   D /trunk/src/app/gfx/canvas_linux.cc
   D /trunk/src/app/gfx/canvas_mac.mm
   D /trunk/src/app/gfx/canvas_paint.h
   D /trunk/src/app/gfx/canvas_win.cc
   D /trunk/src/app/gfx/font.h
   D /trunk/src/app/gfx/font_gtk.cc
   D /trunk/src/app/gfx/font_mac.mm
   D /trunk/src/app/gfx/font_skia.cc
   D /trunk/src/app/gfx/font_unittest.cc
   M /trunk/src/app/gfx/font_util.cc
   D /trunk/src/app/gfx/font_win.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle_dummy.cc
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_posix.cc
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider.h
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_container.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/ntp_background_util.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/cookie_info_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/theme_background.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   A /trunk/src/gfx/canvas.cc (from /trunk/src/app/gfx/canvas.cc:42297)
   A /trunk/src/gfx/canvas.h (from /trunk/src/app/gfx/canvas.h:42297)
   A /trunk/src/gfx/canvas_linux.cc (from /trunk/src/app/gfx/canvas_linux.cc:42297)
   A /trunk/src/gfx/canvas_mac.mm (from /trunk/src/app/gfx/canvas_mac.mm:42297)
   A /trunk/src/gfx/canvas_paint.h (from /trunk/src/app/gfx/canvas_paint.h:42297)
   A /trunk/src/gfx/canvas_win.cc (from /trunk/src/app/gfx/canvas_win.cc:42297)
   A /trunk/src/gfx/font.h (from /trunk/src/app/gfx/font.h:42311)
   A /trunk/src/gfx/font_gtk.cc (from /trunk/src/app/gfx/font_gtk.cc:42311)
   A /trunk/src/gfx/font_mac.mm (from /trunk/src/app/gfx/font_mac.mm:42297)
   A /trunk/src/gfx/font_skia.cc (from /trunk/src/app/gfx/font_skia.cc:42311)
   A /trunk/src/gfx/font_unittest.cc (from /trunk/src/app/gfx/font_unittest.cc:42297)
   A /trunk/src/gfx/font_win.cc (from /trunk/src/app/gfx/font_win.cc:42297)
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printed_document_win.cc
   M /trunk/src/views/background.cc
   M /trunk/src/views/border.cc
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_config.h
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_gtk.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/drag_utils_gtk.cc
   M /trunk/src/views/drag_utils_win.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view_gtk.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/tooltip_manager_gtk.cc
   M /trunk/src/views/widget/tooltip_manager_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window_win.cc

Move app/gfx/canvas and app/gfx/font to gfx/.

TBR=darin
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1132006
------------------------------------------------------------------------
r42308 | akalin@chromium.org | 2010-03-23 04:26:31 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

Set the details field of the BROWSER_THEME_CHANGED notification to
the relevant Extension*.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/1117008
------------------------------------------------------------------------
r42306 | tony@chromium.org | 2010-03-23 04:18:28 +0100 (Tue, 23 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/app/gtk_dnd_util.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Fix HTML5 effectAllowed and dragEffect on Chrome Linux.

This hooks up all the chrome side plumbing, but there are a couple
webkit changes that need to happen for this to fully work.

BUG=14654

Review URL: http://codereview.chromium.org/1084003
------------------------------------------------------------------------
r42304 | jhawkins@chromium.org | 2010-03-23 04:00:37 +0100 (Tue, 23 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h

gtk: Tie the AutoFill button in the options dialog to the kEnableAutoFill pref.

BUG=38681
TEST=none
Review URL: http://codereview.chromium.org/1124005
------------------------------------------------------------------------
r42302 | mattm@chromium.org | 2010-03-23 03:31:58 +0100 (Tue, 23 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/gfx/gtk_util.h
   M /trunk/src/tools/heapcheck/suppressions.txt
   M /trunk/src/views/controls/menu/native_menu_gtk.cc

Linux: Fix some GdkPixbuf leaks.

Also expand some documentation for functions that returned a GdkPixbuf about
who owns the reference

BUG=38895
TEST=manual test that nothing is broken, will watch bot for leak results

Review URL: http://codereview.chromium.org/1075014
------------------------------------------------------------------------
r42301 | tc@google.com | 2010-03-23 03:28:48 +0100 (Tue, 23 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Hook up HTML5 effectAllowed and dragEffect on Windows.

This is the chrome side plumbing, but some patches need to
land on the WebKit side.

BUG=14654

Review URL: http://codereview.chromium.org/1132003
------------------------------------------------------------------------
r42298 | mpcomplete@chromium.org | 2010-03-23 02:31:09 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc

Temporarily disable BrowserActionsContainerTest.Basic in chromeos while I work
on fixing it.

TBR=finnur
BUG=38992

Review URL: http://codereview.chromium.org/1092009
------------------------------------------------------------------------
r42295 | dpranke@google.com | 2010-03-23 01:53:29 +0100 (Tue, 23 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_context_menu_model.h
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/custom_drag.cc
   M /trunk/src/chrome/browser/gtk/custom_drag.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/sync/notifier/base/sigslotrepeater.h
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.html
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json
   M /trunk/src/chrome/common/extensions/docs/images/intermediate
   M /trunk/src/chrome/renderer/resources/extension_toolstrip.css
   M /trunk/src/chrome/test/data/History/history_length_test_page_11.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_12.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_21.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_22.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js
   M /trunk/src/chrome/test/data/extensions/bad/Extensions/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/fast_shutdown/on_before_unloader.html
   M /trunk/src/chrome/test/data/fast_shutdown/on_unloader.html
   M /trunk/src/chrome/test/data/template_url_scraper
   M /trunk/src/gears/SConscript.browser
   M /trunk/src/net/base/cert_test_util.cc
   M /trunk/src/skia/skia_Prefix.pch
   M /trunk/src/third_party/ffmpeg/include/libavcodec/avcodec.h
   M /trunk/src/third_party/ffmpeg/include/libavcodec/opt.h
   M /trunk/src/third_party/ffmpeg/include/libavcodec/vdpau.h
   M /trunk/src/third_party/ffmpeg/include/libavcodec/xvmc.h
   M /trunk/src/third_party/ffmpeg/include/libavformat/avformat.h
   M /trunk/src/third_party/ffmpeg/include/libavformat/avio.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/adler32.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/avstring.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/avutil.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/base64.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/common.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/crc.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/fifo.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/intfloat_readwrite.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/log.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/lzo.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/mathematics.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/md5.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/mem.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/pixfmt.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/rational.h
   M /trunk/src/third_party/ffmpeg/include/libavutil/sha1.h
   M /trunk/src/third_party/libevent/linux/config.h
   M /trunk/src/third_party/libjingle/files/talk/base/win32window.cc
   M /trunk/src/third_party/sqlite/safe-tolower.patch
   M /trunk/src/tools/perf_expectations/tests/perf_expectations_unittest.py
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux (from /trunk/src/webkit/data/layout_tests/platform/chromium-linux:42289)
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac (from /trunk/src/webkit/data/layout_tests/platform/chromium-mac:42289)
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win (from /trunk/src/webkit/data/layout_tests/platform/chromium-win:42289)
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win-7 (from /trunk/src/webkit/data/layout_tests/platform/chromium-win-7:42289)
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win-vista (from /trunk/src/webkit/data/layout_tests/platform/chromium-win-vista:42289)
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp (from /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp:42289)

Revert 42290 - restore the layout test baselines because apparently we use
them in the ui_tests.

    BUG=none
    R=none
    TEST=bots go green again


------------------------------------------------------------------------
r42293 | arv@chromium.org | 2010-03-23 01:18:12 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/event.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget.js

Bookmark manager js lib: Some cleanup of the event class docs.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1141007
------------------------------------------------------------------------
r42292 | tony@chromium.org | 2010-03-23 01:13:51 +0100 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Try and force the font size for the bookmarks bar and some hint
text in the omnibox.

BUG=26354

Review URL: http://codereview.chromium.org/1149002
------------------------------------------------------------------------
r42291 | neb@chromium.org | 2010-03-23 01:08:59 +0100 (Tue, 23 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/pepper_devices.cc

Add a parameter to CreateAudioStream to choose between standard and low-latency mode.

Review URL: http://codereview.chromium.org/661386
------------------------------------------------------------------------
r42289 | mhm@chromium.org | 2010-03-23 00:58:18 +0100 (Tue, 23 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/views/controls/resize_gripper.cc
   M /trunk/src/views/controls/resize_gripper.h

Allow Extensions to have MSAA information.

The whole extension shelf and its items were missing MSAA information. Some of them were uninitialized due to the custom components not having any AccessibleRole.

Some extensions have no name, this could happen where the user didn't put a name for their browser action in the manifest. If such case happens, we will use the extension name itself.

BUG=36289
TEST=Extension shelf now has MSAA information according to Inspect32. Screenshot available on the issue tracker.

Review URL: http://codereview.chromium.org/1105008
------------------------------------------------------------------------
r42286 | arv@chromium.org | 2010-03-23 00:29:14 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Fix an issue with drag and drop over the tree.

BUG=None
TEST=Drag a folder in the tree. You should not be able to drop it on itself. You should only be able to drop it when there is a drop marker.


Review URL: http://codereview.chromium.org/1161004
------------------------------------------------------------------------
r42283 | sky@chromium.org | 2010-03-23 00:27:14 +0100 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Adds the source ImageLoadingTracker to OnImageLoaded. I need this in a
callback so that I can identify where the image is coming from.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1167004
------------------------------------------------------------------------
r42282 | oshima@chromium.org | 2010-03-23 00:25:22 +0100 (Tue, 23 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h

Add KEEP_SIZE state to panel and fixed misc bugs.
  * Replaced "closed_by_user, update_pane_on_leave_" flags with KEEP_SIZE state. The panel moves to this state when a user interacts with the panel. It keeps its size unless a notification is added, or removed, or it has more space than neccessary when mouse leaves the panel.
  * Fixed the crash when the preferred size is calculated to zero (can happen depending on timing) by adding minimum size.
  * fixed wrong return type (bool -> int)
  * GetNewBounds was using the panel's bounds instead of notification's bounds.
  * Refactored and clean up in tests..

BUG=33306
TEST=added two more browser tests for state transition.

Review URL: http://codereview.chromium.org/1164004
------------------------------------------------------------------------
r42280 | jcivelli@google.com | 2010-03-23 00:12:33 +0100 (Tue, 23 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   D /trunk/src/chrome/browser/chromeos/app_launcher.cc
   D /trunk/src/chrome/browser/chromeos/app_launcher.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   A /trunk/src/chrome/browser/views/app_launcher.cc (from /trunk/src/chrome/browser/chromeos/app_launcher.cc:41617)
   A /trunk/src/chrome/browser/views/app_launcher.h (from /trunk/src/chrome/browser/chromeos/app_launcher.h:41617)
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Porting the app launcher to Windows, and adding an experimental flag
so the app launcher shows when you open a new tab.
Also removing the graying-out of the browser when the app launcher is showng for now, as
it is not clear how to make it cross-platform.

BUG=None
TEST=Start Chrome with --app-launcher-new-tab. Opening a new tab
     should bring the app launcher (still a prototype at this point).

Review URL: http://codereview.chromium.org/1145001
------------------------------------------------------------------------
r42279 | davemoore@chromium.org | 2010-03-23 00:08:30 +0100 (Tue, 23 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

We had a problem where if chrome crashed on cros and was relaunched
it would always run with the Default profile. This meant that two
different users could see the same data...a big problem.
We patched in the OS by deleting the profile directory each time
but this is the right fix.
When the session_manager reruns Chrome on a crash it will now
pass a new flag (--login-user). Chrome uses this and ensures that
the profile dir (specified by --login-profile) is mounted as an
encrypted drive. If this flag isn't specified then Chrome uses the
Default profile, but in incognito mode so no data is written.

BUG=chromiumos:1967
TEST=Login to chromeos as user1, in a terminal kill the browser process, chrome relaunches, log into gmail, sign out (using menu or power button). Login as user2, kill browser process, chrome relaunches, go to gmail. Ensure that user1 isn't logged in.

Review URL: http://codereview.chromium.org/1094009
------------------------------------------------------------------------
r42276 | rohitrao@chromium.org | 2010-03-22 23:54:03 +0100 (Mon, 22 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Makes ctrl-return follow links when finding in page.

Enables the FindInPageControllerTest browser test on Mac.

BUG=38365,37808
TEST=Do a find in page for text in a link.  Pressing ctrl-return while the findbar has focus should follow the link.
Review URL: http://codereview.chromium.org/1061003
------------------------------------------------------------------------
r42274 | ctguil@chromium.org | 2010-03-22 23:42:52 +0100 (Mon, 22 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/importer_view.cc

views: [accessibility] Connect the combobox to its label in the Import Bookmarks and Settings dialog.

BUG=9617
TEST=see bug

Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1126009
------------------------------------------------------------------------
r42273 | stuartmorgan@chromium.org | 2010-03-22 23:39:53 +0100 (Mon, 22 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix handling of Mac accelerated plugin layers across tab switch.

A few related changes to make tab switching work with accelerated plugins:
- Re-attach our layer to the view layer whenever it changes; using setWantsLayer: creates a layer that AppKit manages at will, so we can't rely on it.
- Override setFrame: on our layer to ignore bogus values sent by the view's layer.
- Notify the accelerated surface when our parent (and thus drawing context) changes, so it can associate its texture with the new context.

BUG=37701
TEST=Load the pepper test plugin (or a CA plugin in a build with CA enabled) and switch tabs away and back. The plugin should still be visible.

Review URL: http://codereview.chromium.org/1166002
------------------------------------------------------------------------
r42271 | estade@chromium.org | 2010-03-22 23:36:20 +0100 (Mon, 22 Mar 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   D /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.h
   A /trunk/src/chrome/browser/extensions/extension_context_menu_model.cc (from /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc:41960)
   A /trunk/src/chrome/browser/extensions/extension_context_menu_model.h (from /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.h:41960)
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h
   D /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   D /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor ExtensionActionContextMenuModel.

- Simplify constructor
- Rename to ExtensionContextMenuModel.*
- Remove views/extension_action_context_menu.*

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1107007
------------------------------------------------------------------------
r42266 | huanr@chromium.org | 2010-03-22 23:31:27 +0100 (Mon, 22 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add the option of importing bookmarks from file to first run.

BUG=32728
TEST=run with --import-from-file

Review URL: http://codereview.chromium.org/1077007
------------------------------------------------------------------------
r42265 | nick@chromium.org | 2010-03-22 22:52:29 +0100 (Mon, 22 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

Refactor Directory/Directory::Kernel to eliminate some duplicate variable declarations.

Add a PersistedKernelInfo member to the directory kernel, rather than having parallel members.

BUG=37331
TEST=unit tests.

Review URL: http://codereview.chromium.org/1078004
------------------------------------------------------------------------
r42264 | dcheng@chromium.org | 2010-03-22 22:50:04 +0100 (Mon, 22 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/test/data/extensions/api_test/clipboard/test.js

Enable DOM paste for extensions with clipboard access.

BUG=none
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Clipboard

Review URL: http://codereview.chromium.org/1121004
------------------------------------------------------------------------
r42263 | andybons@chromium.org | 2010-03-22 22:35:33 +0100 (Mon, 22 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

[Mac] Draw the icons within the browser actions overflow menu. Also...
o Fix an issue where the grippy was too far to the right when no browser actions were shown.
o Maintain the correct order of extensions within the overflow menu.

Still to be done:
o Animating once resize is complete.
o Syncing the size of the container accross windows.

TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1165002
------------------------------------------------------------------------
r42262 | ben@chromium.org | 2010-03-22 22:34:29 +0100 (Mon, 22 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/app/gfx/canvas_mac.mm
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_win.cc
   M /trunk/src/chrome/browser/browser_main.cc

Make gfx::Font use callbacks to perform locale-dependent font adjustments. Also cleans up some of the last remaining l10n_util usages within app/gfx in preparation for moving these files to toplevel gfx.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1110008
------------------------------------------------------------------------
r42260 | georgey@chromium.org | 2010-03-22 22:23:18 +0100 (Mon, 22 Mar 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/autofill_download.cc
   A /trunk/src/chrome/browser/autofill/autofill_download.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/chrome_browser.gypi

Integration with Toolbar autofill servers.
Still to do:
  1. Update upload rates based on response
  2. Differentiate autofilled/not uploads
  3. Do not query if there is no items in autofill
  4. Fix forms to correspond to the data queried by toolbar
BUG=none
TEST=Should request data from toolbar servers
Review URL: http://codereview.chromium.org/1119004
------------------------------------------------------------------------
r42257 | nick@chromium.org | 2010-03-22 22:16:52 +0100 (Mon, 22 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Eliminate a race between the syncerthread delivering PAUSED
notifications and the syncmanager subscribing to them.

Review URL: http://codereview.chromium.org/1096006
------------------------------------------------------------------------
r42253 | ctguil@chromium.org | 2010-03-22 22:11:57 +0100 (Mon, 22 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bug_report_view.cc

views: [accessibility] Fix the first three issues pointed in the bug for the Report Bug dialog.

BUG=9614
TEST=see bug

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1154002
------------------------------------------------------------------------
r42250 | mpcomplete@chromium.org | 2010-03-22 21:19:45 +0100 (Mon, 22 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Use the new number-of-browser-actions pref instead of width-in-pixels to
save and restore the browser action toolbar's size. Linux already does this.

Also fixes a regression where Windows would ignore the pref and always show
all browser actions on startup.

Review URL: http://codereview.chromium.org/1081009
------------------------------------------------------------------------
r42249 | jrg@chromium.org | 2010-03-22 21:18:58 +0100 (Mon, 22 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Don't touch the pasteboard when the browser may be shutting down
(bookmark model being deleted).

BUG=38665


Review URL: http://codereview.chromium.org/1165001
------------------------------------------------------------------------
r42246 | pkasting@chromium.org | 2010-03-22 21:05:59 +0100 (Mon, 22 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Make various types of input work better with ctrl-enter.  If we detected that the hostname without adding the TLD was illegal, we'd sometimes fail to allow the TLD to be added.

BUG=38605
TEST=Should be able to hit ctrl-enter on "401k" and "999999999999" to open them with www. and .com attached.
Review URL: http://codereview.chromium.org/1088004
------------------------------------------------------------------------
r42240 | ananta@chromium.org | 2010-03-22 20:13:53 +0100 (Mon, 22 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

ChromeFrame net tests would crash on startup while initializing the extensions service. The crash
occured while dereferencing a NULL manifest. Fix is to check for the same and avoid initializing
the extension if we don't have a manifest.

TBR=aa

Review URL: http://codereview.chromium.org/1107013
------------------------------------------------------------------------
r42239 | maruel@chromium.org | 2010-03-22 19:31:48 +0100 (Mon, 22 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/automated_ui_tests/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Revert "Keyboard accessibility for the page and app menus.", rev 42234 and 42236.

TBR=dmazzoni

Review URL: http://codereview.chromium.org/1158004
------------------------------------------------------------------------
r42236 | dmazzoni@chromium.org | 2010-03-22 18:55:02 +0100 (Mon, 22 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Fix typo in Mac merge

------------------------------------------------------------------------
r42234 | dmazzoni@chromium.org | 2010-03-22 18:39:35 +0100 (Mon, 22 Mar 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/automated_ui_tests/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Keyboard accessibility for the page and app menus.
Works on Windows, and on Linux with toolkit_views.

The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.

Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.

Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.

A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.

BUG=none
TEST=New keyboard accessibility ui test.

Review URL: http://codereview.chromium.org/660323
------------------------------------------------------------------------
r42230 | skrul@chromium.org | 2010-03-22 18:16:32 +0100 (Mon, 22 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

Pass the raw history backend pointer to the gmock action rather than the refptr.

Review URL: http://codereview.chromium.org/1072009
------------------------------------------------------------------------
r42228 | arv@chromium.org | 2010-03-22 18:15:03 +0100 (Mon, 22 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Fix the order of the context menu in the tabbed bookmark manager.

The "Delete" menu item should be right after the "Paste" menu item.
As it's in the bookmarks bar and in the old bookmarks manager.

BUG=None
TEST=open the tabbed bookmarks manager and see if the "Delete" menu item is right after the "Paste".

Patch from Thiago Farina <thiago.farina@gmail.com>

Review URL: http://codereview.chromium.org/1159001
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r42227 | jcampan@chromium.org | 2010-03-22 18:07:24 +0100 (Mon, 22 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

Merging the translate manager UMA stats from the 249 branch to the trunk.

Original review:
http://codereview.chromium.org/853010

BUG=None
TEST=None
TBR=kuan
Review URL: http://codereview.chromium.org/1111006
------------------------------------------------------------------------
r42226 | xiyuan@chromium.org | 2010-03-22 18:02:45 +0100 (Mon, 22 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/app/gtk_signal.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Reland r41641 "Make DevTools open docked by default..."

- Fix DevToolsSanityTest time out.
  The timeout is because the tests wait for Browser closed notification.
  However, docked DevTools does not have its own Browser object and
  hence the wait times out.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1025005
------------------------------------------------------------------------
r42225 | jrg@chromium.org | 2010-03-22 17:49:10 +0100 (Mon, 22 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Command-click on a bookmark folder button will now open all in
background tabs.

BUG=34288

TEST=\
1) Make sure normal clicking will open bookmarks, bookmark folders.
2) Make sure right-click opens context menus on folders
3) command-click a folder --> opens all the marks in that folder in
  background tabs

Review URL: http://codereview.chromium.org/1115004
------------------------------------------------------------------------
r42224 | mirandac@chromium.org | 2010-03-22 17:42:07 +0100 (Mon, 22 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   A /trunk/src/chrome/browser/importer/importer_data_types.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Move importer data types into a separate file to prepare for moving importer
into its own process.

BUG= 18774
TEST= none
Review URL: http://codereview.chromium.org/1110005
------------------------------------------------------------------------
r42222 | jar@chromium.org | 2010-03-22 17:35:32 +0100 (Mon, 22 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Make SDCH experiment significant on the dev channel population

The experiment was reduced to a low level to avoid impacing much of
the standard release population.  Now that we've adjusted the definition
of the page-load-time metrics, I'd like to see the results of the
experiment, and I need a larger participation rate to be visible on the
dev channel.

r=willchan
Review URL: http://codereview.chromium.org/1162001
------------------------------------------------------------------------
r42221 | phajdan.jr@chromium.org | 2010-03-22 17:27:01 +0100 (Mon, 22 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Clean up the extensions service after fixing the bug.

This removes excessive debugging code I added to gather more
info about the crashes. They have now disappeared, and the
checks obscure the code now.

TEST=extension browser tests, unit_tests, etc
BUG=30405

Review URL: http://codereview.chromium.org/1078006
------------------------------------------------------------------------
r42218 | maruel@chromium.org | 2010-03-22 16:50:27 +0100 (Mon, 22 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/automated_ui_tests/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Revert "Keyboard accessibility for the page and app menus."

This reverts commit 42217.

TBR=dmzazzoni

Review URL: http://codereview.chromium.org/1154003
------------------------------------------------------------------------
r42217 | dmazzoni@chromium.org | 2010-03-22 16:29:20 +0100 (Mon, 22 Mar 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/automated_ui_tests/keyboard_access_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_win.cc

Keyboard accessibility for the page and app menus.
Works on Windows, and on Linux with toolkit_views.

The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.

Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.

Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.

A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.

BUG=none
TEST=New keyboard accessibility ui test.

Review URL: http://codereview.chromium.org/660323
------------------------------------------------------------------------
r42215 | bulach@chromium.org | 2010-03-22 15:39:50 +0100 (Mon, 22 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Disables temporarily IFramesWithFreshPosition.

Review URL: http://codereview.chromium.org/1082009
------------------------------------------------------------------------
r42214 | bulach@chromium.org | 2010-03-22 14:43:04 +0100 (Mon, 22 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc

Disables Geolocation tests for mac
(follow on up http://codereview.chromium.org/1134001)

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/1149007
------------------------------------------------------------------------
r42213 | phajdan.jr@chromium.org | 2010-03-22 14:26:46 +0100 (Mon, 22 Mar 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

[GTTF] Reduce number of automation methods ending with WithTimeout.

They are just too easy to misuse. People started inventing their own
hardcoded timeouts all over the place.

Also, the is_timeout return parameter was not checked consistently.

Additionally, some calls actually had no timeout at all, making
hangs possible.

This change also removes useless DLOG statements. We should get the
required info from the ASSERT/EXPECT macros in test code, which is
quite well checked by WARN_UNUSED_RESULT.

TEST=all ui-based
BUG=none

Review URL: http://codereview.chromium.org/1076005
------------------------------------------------------------------------
r42212 | bulach@chromium.org | 2010-03-22 14:14:16 +0100 (Mon, 22 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   A /trunk/src/chrome/test/data/geolocation/iframes_different_origin.html
   M /trunk/src/chrome/test/data/geolocation/simple.html

Adds browser tests exercising multiple iframes for geolocation.
Adds a disabled test waiting for rolling https://bugs.webkit.org/show_bug.cgi?id=36315

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/1134001
------------------------------------------------------------------------
r42210 | kuan@chromium.org | 2010-03-22 13:56:47 +0100 (Mon, 22 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   M /trunk/src/views/controls/button/menu_button.h

tweak translate infobar ui

- remove button from options menu and only show it on hover
  - allow MenuButton to be created with or without border for normal state
- make font size and color of all labels, buttons and dropdowns black and medium font respectively
  - extract creation of label into private function to reduce code
- use new special image for all menu drop arrows
  - modify base class MenuButton's menu_marker_ image to a non-const and allow it to be set

BUG=38296
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/1150002
------------------------------------------------------------------------
r42206 | jhawkins@chromium.org | 2010-03-22 02:04:24 +0100 (Mon, 22 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

AutoFill: For now only import data from the uploaded form.

BUG=38104
TEST=none
------------------------------------------------------------------------
r42193 | ben@chromium.org | 2010-03-21 02:52:50 +0100 (Sun, 21 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_util.cc

Fix WindowGetViewBounds bustage... I had the sense of this conditional inverted.
------------------------------------------------------------------------
r42191 | erg@chromium.org | 2010-03-20 23:13:11 +0100 (Sat, 20 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

GTK: More transitions to thunk definition macros.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1118005
------------------------------------------------------------------------
r42189 | joi@chromium.org | 2010-03-20 13:37:07 +0100 (Sat, 20 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

When testing, we don't want to know about 'component' or 'external'
extensions, and if there are loaded extensions we probably loaded them
explicitly (and got a notification thereof) so don't list them either.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1081008
------------------------------------------------------------------------
r42182 | ben@chromium.org | 2010-03-20 07:37:01 +0100 (Sat, 20 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/app/gfx/canvas.h
   M /trunk/src/app/gfx/canvas_win.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_dummy.cc
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/app/l10n_util_win.cc
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/text_elider.cc
   M /trunk/src/app/text_elider.h
   M /trunk/src/app/text_elider_unittest.cc
   M /trunk/src/app/win_util.cc
   M /trunk/src/base/base.gyp
   M /trunk/src/base/file_path.h
   A /trunk/src/base/i18n/rtl.cc
   A /trunk/src/base/i18n/rtl.h
   A /trunk/src/base/i18n/rtl_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/encoding_menu_controller.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/menu/menu.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/tooltip_manager_win.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_win.cc

Move RTL related functions from app/l10n_util to base/i18n/rtl

TBR=darin
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1073005
------------------------------------------------------------------------
r42181 | jar@chromium.org | 2010-03-20 06:41:42 +0100 (Sat, 20 Mar 2010) | 33 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_stream_parser.cc

2 experiments: DNS prefetch limit concurrency: TCP split a packet

Some firewalls apparently try to preclude a "syn flood to host" by limiting
the number of syn's (used to open a TCP/IP socket) that are outstanding
without having received a syn-ack.  Presumably this is to prevent a user
from participating in a syn-flood attack (which traditional sends a lot
of syn packets, with false return addresses, resulting in no responses).

Apparently this firewall technology has in some cases been extended
to include UDP sessions for which there has been no response, and this
may include DNS resolutions.  Since the prefetcher currently resolves
as many as 8 names simultaneously, this is remarkably close to the 
reported threshold of 10 un-answered connections.  This test attempts
to limit connections to 2, 4, or 6, so that we can see if this helps
users.

In TCP, the RTO remains (under windows) at a full 3 seconds until after the
first ack is received.  As a result, if the first data packet sent (after
the SYN) is lost, then TCP won't resend until after 3 seconds without an ack.
As a test, we split up the first packet into two parts (the second part
containing only one byte).  This is done as an A/B test, and we'll see
if we get a measurable improvement in page-load-time latency.

Finally, to get better page load stats, I adjusted the PLT histograms
so that we record a "final" time for abandoned pages when they are
closed (even if they didn't finish rendering, etc.).  This should give
a much more fair PLT comparison for all network latency experiments.


BUG=3041
BUG=12754
r=mbelshe,darin
Review URL: http://codereview.chromium.org/1088002
------------------------------------------------------------------------
r42176 | thestig@chromium.org | 2010-03-20 01:19:19 +0100 (Sat, 20 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/test/test_browser_window.h

Revert r42156, r42157, r42160. Allow dynamic switching in and out of sidetabs mode.

Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1141005
------------------------------------------------------------------------
r42165 | arv@chromium.org | 2010-03-19 23:57:33 +0100 (Fri, 19 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_management_tests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable tabbed bookmark manager by default.

Second try with the following changes:

- Remove FLAKY_ from Feed tests and makes sure they pass.

BUG=4890,38609
TEST=browser_test.exe
     Run Chrome, Press Ctrl+Shift+B. The new bookmark manager should open in a tab.

Review URL: http://codereview.chromium.org/1127006
------------------------------------------------------------------------
r42162 | thestig@chromium.org | 2010-03-19 23:49:05 +0100 (Fri, 19 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

gtk: Fix menu display logic for people with top/down xinerama setups, part 2.

BUG=14184
TEST=see bug
Review URL: http://codereview.chromium.org/1105006
------------------------------------------------------------------------
r42161 | oshima@chromium.org | 2010-03-19 23:43:31 +0100 (Fri, 19 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h

Don't change the panel state when deleting notifications (and mouse is on the panel)
 so that a user can delete multiple notification by clicking mouse on the same position.

BUG=33306
TEST=none. I will add tests next week.

Review URL: http://codereview.chromium.org/1147003
------------------------------------------------------------------------
r42160 | ben@chromium.org | 2010-03-19 23:39:56 +0100 (Fri, 19 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm

fix bustage
------------------------------------------------------------------------
r42157 | ben@chromium.org | 2010-03-19 23:34:27 +0100 (Fri, 19 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

fix bustage
------------------------------------------------------------------------
r42156 | ben@chromium.org | 2010-03-19 23:22:56 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/test/test_browser_window.h

Allow dynamic switching in and out of sidetabs mode.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1001003
------------------------------------------------------------------------
r42155 | arv@chromium.org | 2010-03-19 23:18:29 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Incognito download appearance for items in Incognito downloads page

BUG=36587
TEST=Open an incognito window and open the Downloads page for it. Now download something in the OTR window. The item should show up in the downloads page but it should be lighter and have a OTR icon background.

Review URL: http://codereview.chromium.org/1126005
------------------------------------------------------------------------
r42153 | seanparent@google.com | 2010-03-19 22:59:01 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/.gitignore
   M /trunk/src/base/base.gypi
   A /trunk/src/base/move.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/chromeos/low_battery_observer.cc
   A /trunk/src/chrome/browser/chromeos/low_battery_observer.h
   A /trunk/src/chrome/browser/chromeos/notifications/system_notification.cc
   A /trunk/src/chrome/browser/chromeos/notifications/system_notification.h
   M /trunk/src/chrome/browser/chromeos/notifications/system_notification_factory.h
   M /trunk/src/chrome/chrome_browser.gypi

Notification for battery with <= 15 minutes remaining.

BUG=521
TEST=none

Review URL: http://codereview.chromium.org/1079007
------------------------------------------------------------------------
r42147 | feldstein@chromium.org | 2010-03-19 22:09:33 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm

Add a dcheck to make sure we launch the dialog box on the main UI

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1075010
------------------------------------------------------------------------
r42146 | aa@chromium.org | 2010-03-19 21:45:46 +0100 (Fri, 19 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   A /trunk/src/chrome/common/extensions/extension_extent.cc
   A /trunk/src/chrome/common/extensions/extension_extent.h
   A /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   A /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/data/extensions/app/manifest.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_value.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_without_launch_url.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_default.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_local_path.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_panel.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_and_url.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_value.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_tab.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_absolute.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_window.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_disabled.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_enabled_invalid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_not_enabled.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_web_content_disabled.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json

Resubmit 1025006: Refactor app-related manifest properties
so that they don't include the name 'app'.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r42139 | jhawkins@chromium.org | 2010-03-19 21:06:51 +0100 (Fri, 19 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

AutoFill: Set the kAutoFillInfoBarShown pref to true if the user opens the AutoFill dialog.  If the user has opened the dialog, AutoFill is implicitly enabled.

BUG=38538
TEST=none
Review URL: http://codereview.chromium.org/1077003
------------------------------------------------------------------------
r42134 | tim@chromium.org | 2010-03-19 20:36:34 +0100 (Fri, 19 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc

Improve the integration test harness by using the max_local_timestamp
from the sync engine rather than waiting for "a couple syncs" to happen
before declaring sync "done".

BUG=37351

Review URL: http://codereview.chromium.org/1042008
------------------------------------------------------------------------
r42133 | chocobo@chromium.org | 2010-03-19 20:32:20 +0100 (Fri, 19 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h

Add ability to show/hide password in login dialog.
BUG=none
TEST=open login dialog, type in password, and click on the lock image to toggle showing password.
Review URL: http://codereview.chromium.org/1113004
------------------------------------------------------------------------
r42130 | huanr@chromium.org | 2010-03-19 19:58:37 +0100 (Fri, 19 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc

Removing AddDefaultBookmark related code as we are taking
bookmark import approach.

BUG=32728
TEST=existing test passes

Review URL: http://codereview.chromium.org/1122002
------------------------------------------------------------------------
r42128 | ctguil@chromium.org | 2010-03-19 19:50:40 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h

views: Add accessibility support to the Textfield control.

BUG=9619
TEST=open AccExplorer.exe, open bookmarks manager dialog, point it to the search Textfield (edit box)
and see it if has the correct information for role (editable text), name (the label within it's connected) and state (read only).
Review URL: http://codereview.chromium.org/1058002
------------------------------------------------------------------------
r42125 | rvargas@google.com | 2010-03-19 19:39:48 +0100 (Fri, 19 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc

Fixing a constant which was the hardcoded value of 2*kNumBytesToSniff. When I 
changed kNumBytesToSniff in 41687, it was left behind. 

Contributed by tonyg@chromium.org 
(original review http://codereview.chromium.org/1111003/show)

BUG=15314
TEST=There is no clear way to test this, ideas?

Review URL: http://codereview.chromium.org/1153002
------------------------------------------------------------------------
r42120 | mpcomplete@chromium.org | 2010-03-19 18:38:07 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_listener.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Fix a crash due to UserScriptListener unregistering notifications on the wrong
thread, then being sent a notification after it was deleted.

BUG=38374

Review URL: http://codereview.chromium.org/995007
------------------------------------------------------------------------
r42116 | cmasone@google.com | 2010-03-19 18:14:25 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   A /trunk/src/chrome/browser/chromeos/login/auth_response_handler.cc
   A /trunk/src/chrome/browser/chromeos/login/auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/authenticator.h
   A /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc
   A /trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   A /trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc
   A /trunk/src/chrome/browser/chromeos/login/issue_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   A /trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/utils.cc
   M /trunk/src/chrome/browser/chromeos/login/utils.h
   M /trunk/src/chrome/chrome_browser.gypi

Enables chrome to do programmatic auth without helper binaries/pam modules.

Functionality protected behind --in-chrome-auth flag.

TEST=unittests, also run on Chromium OS with --in-chrome-auth flag.  Log in should work.
Review URL: http://codereview.chromium.org/1026001
------------------------------------------------------------------------
r42112 | phajdan.jr@chromium.org | 2010-03-19 17:35:54 +0100 (Fri, 19 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

[GTTF] Make automation timeouts more sane.

Do not expose command execution timeout outside ui_test.cc. This way
people have less timeouts to choose from, which leaves less space
for confusion.

The option to manipulate the command execution timeout is still
available, because it's still used and makes sense.

Also updated misleading comments and names in ui_test.cc.

TEST=ui_tests
BUG=none

Review URL: http://codereview.chromium.org/1078003
------------------------------------------------------------------------
r42111 | oshima@chromium.org | 2010-03-19 17:17:41 +0100 (Fri, 19 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/app_launcher.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc

AppLauncher cleanup.
  Pass browser to ctor as AppLauncher is created per browser instance.

BUG=chromium-os:1795
TEST=none

Review URL: http://codereview.chromium.org/1085006
------------------------------------------------------------------------
r42110 | mirandac@chromium.org | 2010-03-19 17:14:39 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Fix extension installed bubble, so that it points to the correct page action icon when more than one page action is visible.

BUG= 38255
TEST= see bug report; this should no longer be reproducible.

Review URL: http://codereview.chromium.org/1083002
------------------------------------------------------------------------
r42108 | sky@chromium.org | 2010-03-19 17:04:46 +0100 (Fri, 19 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/views/widget/widget_gtk.cc

Tweaks for login panels:
. Allows widget to go transparent even if wm says it isn't
  supported. See comment I added as to why I'm allowing it.
. Makes font bold.
. Sets property on window so window manager knows chrome has
  painted. This avoids the gray flash.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1149001
------------------------------------------------------------------------
r42104 | andybons@chromium.org | 2010-03-19 16:22:20 +0100 (Fri, 19 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   D /trunk/src/chrome/common/extensions/extension_extent.cc
   D /trunk/src/chrome/common/extensions/extension_extent.h
   D /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   D /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   D /trunk/src/chrome/test/data/extensions/manifest_tests

Revert 42091 - Refactor apprelated manifest properties so that they don't
include the name 'app'. I think these will be useful for normal
extensions, too.

Also extract an ExtensionExtent class out of Extension. I think
this will be useful for passing by value to the IO thread.

Review URL: http://codereview.chromium.org/1025006

TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/1120005
------------------------------------------------------------------------
r42103 | andybons@chromium.org | 2010-03-19 15:57:43 +0100 (Fri, 19 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_management_tests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 42061 - Enable tabbed bookmark manager by default due to browser_tests and chrome frame breaking. 

BUG=4890
TEST=None 
		
Review URL: http://codereview.chromium.org/1139001

TBR=arv@chromium.org
Review URL: http://codereview.chromium.org/1146004
------------------------------------------------------------------------
r42101 | pinkerton@chromium.org | 2010-03-19 15:01:33 +0100 (Fri, 19 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/surface
   A /trunk/src/app/surface/accelerated_surface_mac.cc (from /trunk/src/chrome/common/accelerated_surface_mac.cc:41716)
   A /trunk/src/app/surface/accelerated_surface_mac.h (from /trunk/src/chrome/common/accelerated_surface_mac.h:41716)
   A /trunk/src/app/surface/io_surface_support_mac.cc (from /trunk/src/chrome/common/io_surface_support_mac.cc:41716)
   A /trunk/src/app/surface/io_surface_support_mac.h (from /trunk/src/chrome/common/io_surface_support_mac.h:41716)
   A /trunk/src/app/surface/transport_dib.h (from /trunk/src/chrome/common/transport_dib.h:41716)
   A /trunk/src/app/surface/transport_dib_linux.cc (from /trunk/src/chrome/common/transport_dib_linux.cc:41716)
   A /trunk/src/app/surface/transport_dib_mac.cc (from /trunk/src/chrome/common/transport_dib_mac.cc:41716)
   A /trunk/src/app/surface/transport_dib_win.cc (from /trunk/src/chrome/common/transport_dib_win.cc:41716)
   A /trunk/src/app/x11_util.cc (from /trunk/src/chrome/common/x11_util.cc:41716)
   A /trunk/src/app/x11_util.h (from /trunk/src/chrome/common/x11_util.h:41716)
   A /trunk/src/app/x11_util_internal.h (from /trunk/src/chrome/common/x11_util_internal.h:41716)
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/video_layer.h
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.cc
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/accelerated_surface_mac.cc
   D /trunk/src/chrome/common/accelerated_surface_mac.h
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/gpu_messages.h
   D /trunk/src/chrome/common/io_surface_support_mac.cc
   D /trunk/src/chrome/common/io_surface_support_mac.h
   M /trunk/src/chrome/common/render_messages.h
   D /trunk/src/chrome/common/transport_dib.h
   D /trunk/src/chrome/common/transport_dib_linux.cc
   D /trunk/src/chrome/common/transport_dib_mac.cc
   D /trunk/src/chrome/common/transport_dib_win.cc
   D /trunk/src/chrome/common/x11_util.cc
   D /trunk/src/chrome/common/x11_util.h
   D /trunk/src/chrome/common/x11_util_internal.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx_context.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_win.h
   M /trunk/src/chrome/gpu/gpu_video_layer_glx.h
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/media/ipc_video_renderer.h
   M /trunk/src/chrome/renderer/mock_render_process.cc
   M /trunk/src/chrome/renderer/nacl_desc_wrapper_chrome.cc
   M /trunk/src/chrome/renderer/pepper_devices.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/gpu/DEPS
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.h
   A /trunk/src/webkit/glue/plugins/mac_accelerated_surface_container.cc (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.cc:41207)
   A /trunk/src/webkit/glue/plugins/mac_accelerated_surface_container.h (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.h:41207)
   A /trunk/src/webkit/glue/plugins/mac_accelerated_surface_container_manager.cc (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.cc:41207)
   A /trunk/src/webkit/glue/plugins/mac_accelerated_surface_container_manager.h (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.h:41207)
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h

Remove dependency from webkit on chrome/common by moving files to src/app.
BUG=37985
TEST=no functional change.
Review URL: http://codereview.chromium.org/1060001
------------------------------------------------------------------------
r42099 | bulach@chromium.org | 2010-03-19 14:19:57 +0100 (Fri, 19 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/geolocation_dispatcher.cc

Uses GURL instead of host for requesting Geolocation permission.
Tidy up GeolocationPermissionContext.
(in preparation for http://codereview.chromium.org/1033004).

Review URL: http://codereview.chromium.org/1074004
------------------------------------------------------------------------
r42092 | glotov@google.com | 2010-03-19 10:50:04 +0100 (Fri, 19 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc

Status area update fix on language switches.

BUG=35248
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard. 
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"): 
out/Debug/chrome --login-manager --login-screen=network 

Review URL: http://codereview.chromium.org/1107003
------------------------------------------------------------------------
r42091 | aa@chromium.org | 2010-03-19 09:58:12 +0100 (Fri, 19 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tabs/pinned_tab_codec.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   A /trunk/src/chrome/common/extensions/extension_extent.cc
   A /trunk/src/chrome/common/extensions/extension_extent.h
   A /trunk/src/chrome/common/extensions/extension_extent_unittest.cc
   A /trunk/src/chrome/common/extensions/extension_manifests_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/manifest_tests
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_invalid_value.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_container_without_launch_url.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_default.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_local_path.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_panel.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_and_url.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_path_invalid_value.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_tab.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_absolute.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/launch_window.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/valid_app.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_disabled.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_enabled_invalid.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_content_not_enabled.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_invalid_3.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_web_content_disabled.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_origin_wrong_type.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_1.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_invalid_path_2.json
   A /trunk/src/chrome/test/data/extensions/manifest_tests/web_paths_wrong_type.json

Refactor app-related manifest properties so that they don't
include the name 'app'. I think these will be useful for normal
extensions, too.

Also extract an ExtensionExtent class out of Extension. I think
this will be useful for passing by value to the IO thread.

Review URL: http://codereview.chromium.org/1025006
------------------------------------------------------------------------
r42090 | ben@chromium.org | 2010-03-19 09:20:56 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/gfx/text_elider.cc
   D /trunk/src/app/gfx/text_elider.h
   D /trunk/src/app/gfx/text_elider_unittest.cc
   A /trunk/src/app/text_elider.cc (from /trunk/src/app/gfx/text_elider.cc:42054)
   A /trunk/src/app/text_elider.h (from /trunk/src/app/gfx/text_elider.h:42054)
   A /trunk/src/app/text_elider_unittest.cc (from /trunk/src/app/gfx/text_elider_unittest.cc:42054)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/printing/page_overlays.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/widget/tooltip_manager.cc

Move text_elider from app/gfx to app/

TBR=darin
BUG=none
TEST=none

------------------------------------------------------------------------
r42085 | tony@chromium.org | 2010-03-19 08:27:24 +0100 (Fri, 19 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Honor select-all on tab-away when omnibar is empty (gtk)

Also added a browser test for this case.
The bug is an ordering error, possibly because the
programmer was unaware that GetStateForTabSwitch
can actually mutate the selection state, for the
odd case outlined in bug 38385.

BUG=38385
TEST=Delete URL from omnibar.  Create tab, delete tab.  URL should be reverted and selected.

Patch by Matthew Willis <appamatto@gmail.com>

Review URL: http://codereview.chromium.org/1047004
------------------------------------------------------------------------
r42071 | ben@chromium.org | 2010-03-19 04:23:15 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/gfx/color_utils.cc
   D /trunk/src/app/gfx/color_utils.h
   D /trunk/src/app/gfx/color_utils_unittest.cc
   D /trunk/src/app/gfx/favicon_size.h
   D /trunk/src/app/gfx/gdi_util.cc
   D /trunk/src/app/gfx/gdi_util.h
   D /trunk/src/app/gfx/native_theme_win.cc
   D /trunk/src/app/gfx/native_theme_win.h
   D /trunk/src/app/gfx/native_theme_win_unittest.cc
   D /trunk/src/app/gfx/skbitmap_operations.cc
   D /trunk/src/app/gfx/skbitmap_operations.h
   D /trunk/src/app/gfx/skbitmap_operations_unittest.cc
   D /trunk/src/app/gfx/skia_util.cc
   D /trunk/src/app/gfx/skia_util.h
   D /trunk/src/app/gfx/skia_utils_gtk.cc
   D /trunk/src/app/gfx/skia_utils_gtk.h
   M /trunk/src/app/win_util.cc
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/ntp_background_util.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/appcache_info_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/cookie_info_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/database_info_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/local_storage_info_view.cc
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_win.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   A /trunk/src/gfx/color_utils.cc (from /trunk/src/app/gfx/color_utils.cc:41909)
   A /trunk/src/gfx/color_utils.h (from /trunk/src/app/gfx/color_utils.h:41909)
   A /trunk/src/gfx/color_utils_unittest.cc (from /trunk/src/app/gfx/color_utils_unittest.cc:41909)
   A /trunk/src/gfx/favicon_size.h (from /trunk/src/app/gfx/favicon_size.h:41909)
   A /trunk/src/gfx/gdi_util.cc (from /trunk/src/app/gfx/gdi_util.cc:41909)
   A /trunk/src/gfx/gdi_util.h (from /trunk/src/app/gfx/gdi_util.h:41909)
   M /trunk/src/gfx/gfx.gyp
   A /trunk/src/gfx/native_theme_win.cc (from /trunk/src/app/gfx/native_theme_win.cc:41909)
   A /trunk/src/gfx/native_theme_win.h (from /trunk/src/app/gfx/native_theme_win.h:41909)
   A /trunk/src/gfx/native_theme_win_unittest.cc (from /trunk/src/app/gfx/native_theme_win_unittest.cc:41909)
   A /trunk/src/gfx/skbitmap_operations.cc (from /trunk/src/app/gfx/skbitmap_operations.cc:41909)
   A /trunk/src/gfx/skbitmap_operations.h (from /trunk/src/app/gfx/skbitmap_operations.h:41909)
   A /trunk/src/gfx/skbitmap_operations_unittest.cc (from /trunk/src/app/gfx/skbitmap_operations_unittest.cc:41909)
   A /trunk/src/gfx/skia_util.cc (from /trunk/src/app/gfx/skia_util.cc:41909)
   A /trunk/src/gfx/skia_util.h (from /trunk/src/app/gfx/skia_util.h:41909)
   A /trunk/src/gfx/skia_utils_gtk.cc (from /trunk/src/app/gfx/skia_utils_gtk.cc:41909)
   A /trunk/src/gfx/skia_utils_gtk.h (from /trunk/src/app/gfx/skia_utils_gtk.h:41909)
   M /trunk/src/printing/emf_win.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/views/background.cc
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_config_win.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/glue/webthemeengine_impl_win.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_platform_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Move more files to toplevel gfx.

TBR=darin
BUG=none
TEST=none

------------------------------------------------------------------------
r42070 | rafaelw@chromium.org | 2010-03-19 03:38:05 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc

Extension popups now stay open and drag while inspector is open, when browser is dragged

BUG=24477
TEST=go to chrome://extensions, turn on dev mode. install an extension with a browser action. right click->inspect popup, then drag browser window. popup should stay open and follow browser window

Review URL: http://codereview.chromium.org/1109006
------------------------------------------------------------------------
r42069 | rolandsteiner@chromium.org | 2010-03-19 03:26:35 +0100 (Fri, 19 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc

Fix Issue 33145: Content Editable Move Image or Selected Block of Text Broken

The cause was that the original source mask only specified "Copy" as allowed operations, while the destination operation is "Move".

Changed the code to allow both "Copy" and "Move" (in line with the GTK implementation). Note that this patch does not touch or implement the TODO(snej) issues, i.e., allow for operations other than move or copy.

BUG=33145
TEST=see bug description

Review URL: http://codereview.chromium.org/1097001
------------------------------------------------------------------------
r42066 | mhm@chromium.org | 2010-03-19 03:10:58 +0100 (Fri, 19 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc

Win7: Show download progress in superbar.

Use ITaskbarList3 interface to show progress bar when downloading items.

BUG=8039
TEST=Download a couple of files, notice it progress. Look at the screenshot in the main issue.

Review URL: http://codereview.chromium.org/944001
------------------------------------------------------------------------
r42064 | pkasting@chromium.org | 2010-03-19 02:52:45 +0100 (Fri, 19 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map.h
   A /trunk/src/chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/content_settings.cc
   M /trunk/src/chrome/common/content_settings.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h

Add GeolocationContentSettingsMap, a geolocation-specific variant of HostContentSettingsMap.

This was originally written by bulach and posted at http://codereview.chromium.org/1033004 ; modified and landed by me.

BUG=37206
TEST=Tested by unittests
TBR=bulach,joth
Review URL: http://codereview.chromium.org/1084005
------------------------------------------------------------------------
r42061 | arv@chromium.org | 2010-03-19 02:39:19 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_management_tests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable tabbed bookmark manager by default. 

BUG=4890
TEST=None 
		
Review URL: http://codereview.chromium.org/1139001
------------------------------------------------------------------------
r42057 | twiz@chromium.org | 2010-03-19 02:23:54 +0100 (Fri, 19 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/automation/automation_resource_routing_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h

Modification of ExtensionPopup views to allow for pop-up views to share the same network stack as their hosting views. 

A new RenderViewHostDelegate interface has been added, AutomationRequestRouting, which can be implemented on RenderViewHost objects to return the data-structures used to pass network requests through Chrome-Frame host networking, or the native Chrome network stack. 

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/906003
------------------------------------------------------------------------
r42049 | jschuh@google.com | 2010-03-19 01:56:03 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Removing unnecessary DCHECK from SafeBrowsing interstitial.

BUG=30079
TEST=None.

Review URL: http://codereview.chromium.org/1131003
------------------------------------------------------------------------
r42048 | zork@chromium.org | 2010-03-19 01:52:02 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/test/profile_mock.h

Combine similar code from sync unit tests and add additional unit tests for typed url syncing.

BUG=none
TEST=run unit tests

Review URL: http://codereview.chromium.org/1124002
------------------------------------------------------------------------
r42039 | jhawkins@chromium.org | 2010-03-19 01:12:04 +0100 (Fri, 19 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Disable SessionHistoryTest.HistoryLength as it's hanging the Win Dbg bot.

BUG=38583
TEST=none
Review URL: http://codereview.chromium.org/1092004
------------------------------------------------------------------------
r42036 | shess@chromium.org | 2010-03-19 01:08:22 +0100 (Fri, 19 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm

[Mac] Prevent entering raw control characters in Omnibox.

The code already intercepted some of the shady ways for entering raw
control characters.  This also handles some cases which weren't
intercepted by doCommandBySelector:.

BUG=38345
TEST=Try to enter Ctrl-Q Enter, C-Q TAB, Ctrl-Alt-Enter and Ctrl-Alt-TAB in Omnibox.

Review URL: http://codereview.chromium.org/1008003
------------------------------------------------------------------------
r42035 | arv@chromium.org | 2010-03-19 01:06:55 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Remove button padding work around now that WebKit has been fixed.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1128005
------------------------------------------------------------------------
r42032 | thestig@chromium.org | 2010-03-19 01:00:01 +0100 (Fri, 19 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

ChromeOS: Label LoginPromptTest.TestDigestAuth as flaky. It's failing under Valgrind sometimes.

BUG=38580
TEST=ChromeOS Valgrind stays consistently green.
Review URL: http://codereview.chromium.org/1123003
------------------------------------------------------------------------
r42028 | feldstein@chromium.org | 2010-03-19 00:46:33 +0100 (Fri, 19 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm

Fix launching Clear Browsing Data dialog from the history page.

The problem here was that the modal dialog would block, while it didn't block on
windows.  Since it was launched from a standard Chrome task (the DOMUI call), it
would block all other Chrome tasks.  The callbacks from the BrowsingDataRemover
to let the window know to close was a Chrome task, and so would deadlock since
it couldn't tell the dialog to close until the dialog was closed.

I spun it off into a cocoa event using |performSelector:afterDelay:| with 0 delay which freed up
Chrome tasks to be processed again.

BUG=37976
TEST=Launch clear browsing data dialog from history and make sure you can clear
the history and it closes itself.  Also ensure it still works as expected from
menu and preferences.

Review URL: http://codereview.chromium.org/1129002
------------------------------------------------------------------------
r42027 | jrg@chromium.org | 2010-03-19 00:45:58 +0100 (Fri, 19 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm

When adding a new page in the bookmark bar, allow the "new folder" to be the parent.

BUG=36531

TEST=\
1) In bookmark bar, "Add Page" from context menu.
Create a new folder, select it.
Type something in the URL and name then OK.
Make sure the new bookmark is in the new folder.
2) Same thing but make 2 (nested) "add folder"s with the bookmark down in there.

Review URL: http://codereview.chromium.org/1136001
------------------------------------------------------------------------
r42024 | jhawkins@chromium.org | 2010-03-19 00:32:47 +0100 (Fri, 19 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_win_uitest.cc

Disable ProcessSingletonWinTest.StartupRaceCondition as it's failing consistently.

TBR=thestig
BUG=38572
TEST=none
Review URL: http://codereview.chromium.org/1139002
------------------------------------------------------------------------
r42022 | darin@chromium.org | 2010-03-19 00:03:00 +0100 (Fri, 19 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/session_history/record_length.html

Send session history offset and length parameters in the Navigate message to
keep the renderer's notion of those values properly synchronized with the
NavigationController.

R=brettw
BUG=18062
TEST=see session_history_uitest.cc

Review URL: http://codereview.chromium.org/1090002
------------------------------------------------------------------------
r42019 | chocobo@chromium.org | 2010-03-18 23:45:52 +0100 (Thu, 18 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc

Move clock menu button to the right as per UI design.
BUG=none
TEST=The order of status menu buttons from left to right are: language, network, power, clock
Review URL: http://codereview.chromium.org/1134003
------------------------------------------------------------------------
r42018 | ctguil@chromium.org | 2010-03-18 23:40:09 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

[Accessibility] Chrome's main window is missing an accessible name

BUG=36732
TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. 

Review URL: http://codereview.chromium.org/661054
------------------------------------------------------------------------
r42014 | michaeln@chromium.org | 2010-03-18 23:34:24 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc
   M /trunk/src/webkit/appcache/appcache_thread.cc
   M /trunk/src/webkit/appcache/appcache_thread.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Plumbing for providing a cache thread MessageLoop to the DiskCache backend.

BUG=26730
TEST=none

Review URL: http://codereview.chromium.org/1115002
------------------------------------------------------------------------
r42013 | mpcomplete@chromium.org | 2010-03-18 23:34:05 +0100 (Thu, 18 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   M /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc

Enable the incognito extension toggle by default. No more flag.

BUG=32365

Review URL: http://codereview.chromium.org/1075005
------------------------------------------------------------------------
r42011 | chocobo@chromium.org | 2010-03-18 23:33:01 +0100 (Thu, 18 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

Fix so that encrypted networks are marked as such.
BUG=none
TEST=After connecting to a secure network, the network still shows up as secure. (lock icon is still there)
Review URL: http://codereview.chromium.org/1128003
------------------------------------------------------------------------
r42009 | chocobo@chromium.org | 2010-03-18 23:16:11 +0100 (Thu, 18 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h

When updating timezone, the clock now updates right away.
BUG=1650
TEST=none
Review URL: http://codereview.chromium.org/1081005
------------------------------------------------------------------------
r42008 | jamesr@google.com | 2010-03-18 23:00:41 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Disable XSSAuditor on trunk until perf issues are resolved

BUG=35723
TEST=none

Review URL: http://codereview.chromium.org/1068001
------------------------------------------------------------------------
r42004 | mpcomplete@chromium.org | 2010-03-18 22:55:05 +0100 (Thu, 18 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Update allow-extension-in-incognito warning dialog text based on UI feedback.

Also fix a small issue with double-clicking a link in the extensions UI.

BUG=37789

Review URL: http://codereview.chromium.org/1042009
------------------------------------------------------------------------
r42001 | estade@chromium.org | 2010-03-18 22:50:39 +0100 (Thu, 18 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: tweak visibility calculation for bookmark bar items.

Also vastly simplify the code for the common case where |extra_space| is 0.

Also fix a graphical imperfection that's been nagging me for a while where the bookmark bar looks kind of weird when you start dragging out of it. (the buttons jiggle around)

BUG=38186
TEST=manual

Review URL: http://codereview.chromium.org/1101003
------------------------------------------------------------------------
r42000 | andybons@chromium.org | 2010-03-18 22:50:01 +0100 (Thu, 18 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   D /trunk/src/chrome/browser/cocoa/extensions/browser_actions_overflow_menu.h
   D /trunk/src/chrome/browser/cocoa/extensions/browser_actions_overflow_menu.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Implement a basic overflow menu for hidden Browser Action buttons.
Known issues:
o The ordering of the Browser Actions is not consistent within the menu.
o Icons for the actions within the menu are not implemented yet.
o It is a standard NSMenu, so drag and drop will not work and right click does not work for now.

TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1083001
------------------------------------------------------------------------
r41998 | chocobo@chromium.org | 2010-03-18 22:49:05 +0100 (Thu, 18 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc

Update timezone with a default list of timezones.
BUG=none
TEST=manually change timezones in the options page and see the clock change to the correct timezone (after a minute)
Review URL: http://codereview.chromium.org/1107004
------------------------------------------------------------------------
r41997 | chocobo@chromium.org | 2010-03-18 22:48:53 +0100 (Thu, 18 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Uses new libcros network monitoring.
Fixes enable/disable network devices.
BUG=chromium-os:1818,chromium-os:1682
TEST=none
Review URL: http://codereview.chromium.org/1016003
------------------------------------------------------------------------
r41994 | aa@chromium.org | 2010-03-18 22:43:34 +0100 (Thu, 18 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h

Force an app's orgin to be the origin of the URL the crx is
downloaded from. Added machinery to be able to switch this
behavior off, so that in the future, we can turn it off for
the gallery.

BUG=32361

Review URL: http://codereview.chromium.org/890002
------------------------------------------------------------------------
r41990 | finnur@chromium.org | 2010-03-18 22:30:32 +0100 (Thu, 18 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   M /trunk/src/chrome/browser/extensions/extension_infobar_module.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   D /trunk/src/chrome/common/extensions/docs/experimental.infoBar.html
   A /trunk/src/chrome/common/extensions/docs/experimental.infobars.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Minor extension infobar changes.

Addressing review comments that were submitted after I checked in.

BUG=26463
TEST=None

Review URL: http://codereview.chromium.org/1097002
------------------------------------------------------------------------
r41989 | jhawkins@chromium.org | 2010-03-18 22:26:42 +0100 (Thu, 18 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Don't use the TabContents in the AutoFillInfoBarDelegateTest.  Fixes a few leaks.

BUG=38481
TEST=none
Review URL: http://codereview.chromium.org/1109005
------------------------------------------------------------------------
r41980 | dpolukhin@chromium.org | 2010-03-18 19:38:23 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Create new GMail account on OOBE screen and set user name on login screen.

BUG=35157
TEST=Run chrome with --login-manager and press button create an account.

Review URL: http://codereview.chromium.org/910003
------------------------------------------------------------------------
r41977 | sky@chromium.org | 2010-03-18 19:33:42 +0100 (Thu, 18 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disables browser test on chromeos as chromeos defaults to restoring
last session, which means my test doesn't test what I want it to. I
could make the test exercise the paths I want on chromeos by changing
what to do on startup, but it didn't seem worth it given the default.

BUG=NONE
TBR=erikkay@chromium.org

Review URL: http://codereview.chromium.org/1079002
------------------------------------------------------------------------
r41976 | snej@chromium.org | 2010-03-18 19:30:07 +0100 (Thu, 18 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Mac bookmark mgr: Work around NSOutlineView column-width bug.
BUG=35031
TEST=see steps to reproduce in bug report

Review URL: http://codereview.chromium.org/1023009
------------------------------------------------------------------------
r41966 | jrg@chromium.org | 2010-03-18 18:59:20 +0100 (Thu, 18 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Drop bookmark onto a folder --> goes in folder.

BUG=36955

TEST=\
Drop some bookmarks onto folders; make sure they go in (at the end).
Try both bookmark bar folders and sub-sub-folders.
Try marks from a folder onto a bar folder.
Drop a mark onto it's own parent folder.
Go both quick (before hover-open) and slow (after).


Review URL: http://codereview.chromium.org/1002012
------------------------------------------------------------------------
r41965 | sky@chromium.org | 2010-03-18 18:45:04 +0100 (Thu, 18 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Marks new browser test as flakey on mac as it seems to tickle a mac
bug unrelated to my cl.

TBR=erikkay@chromium.org
BUG=38522

Review URL: http://codereview.chromium.org/1118003
------------------------------------------------------------------------
r41962 | jianli@chromium.org | 2010-03-18 18:34:26 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix the problem that a Save As dialog pops up on drag-out when "Ask where to save each file before downloading" option is checked. 

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1050006
------------------------------------------------------------------------
r41959 | estade@chromium.org | 2010-03-18 18:10:18 +0100 (Thu, 18 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   A /trunk/src/chrome/browser/gtk/custom_drag.cc (from /trunk/src/chrome/browser/gtk/download_item_drag.cc:41804)
   A /trunk/src/chrome/browser/gtk/custom_drag.h (from /trunk/src/chrome/browser/gtk/download_item_drag.h:41804)
   D /trunk/src/chrome/browser/gtk/download_item_drag.cc
   D /trunk/src/chrome/browser/gtk/download_item_drag.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTK: implement extension bookmark manager drag api.

Also, cross-platform: eschew RenderViewHostDelegate:BookmarkDrag::DragData type in favor of BookmarkDragData.

BUG=37702
TEST=manual

Review URL: http://codereview.chromium.org/1029004
------------------------------------------------------------------------
r41958 | sky@chromium.org | 2010-03-18 17:46:40 +0100 (Thu, 18 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/tabs/pinned_tab_codec.cc
   A /trunk/src/chrome/browser/tabs/pinned_tab_codec.h
   A /trunk/src/chrome/browser/tabs/pinned_tab_codec_unittest.cc
   A /trunk/src/chrome/browser/tabs/pinned_tab_service.cc
   A /trunk/src/chrome/browser/tabs/pinned_tab_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Makes pinned tab restore on startup if you haven't enabled session
restore.

BUG=23613
TEST=turn off session restore, pin a tab, restart chrome and make sure
you get back the pinned tab.

Review URL: http://codereview.chromium.org/1026005
------------------------------------------------------------------------
r41956 | joth@chromium.org | 2010-03-18 17:05:35 +0100 (Thu, 18 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm

Fix broken tree: makes correct fix (in follow up to r41955)
(sigh)

BUG=none
TEST=unit_tests
TBR=bulach

------------------------------------------------------------------------
r41955 | joth@chromium.org | 2010-03-18 16:43:02 +0100 (Thu, 18 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm

Fix valgrind failure: member used before set.
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/3821/steps/valgrind%20test:%20unit/logs/stdio

BUG=none
TEST=unit_tests (Mac valgrind)
TBR=bulach

------------------------------------------------------------------------
r41954 | danno@chromium.org | 2010-03-18 16:26:54 +0100 (Thu, 18 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc

Fix GtkThemeProviderTest.UsingGtkValues unittest

Check against the correct color field when validating the colors loaded from GTK.

BUG=http://crbug.com/38420
TEST=verified with unit tests

Review URL: http://codereview.chromium.org/985008
------------------------------------------------------------------------
r41953 | estade@chromium.org | 2010-03-18 16:24:41 +0100 (Thu, 18 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/app_launcher.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Retry r41799:

Basic DragImage implementation.

Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit.

TODO later:
- use the image on windows, mac
- implement the other DragImageRef functions

TEST=drag an image from the render view in GTK
BUG=11457
Review URL: http://codereview.chromium.org/668125

The problem was an incorrect method signature in RenderView.

Review URL: http://codereview.chromium.org/1037008
------------------------------------------------------------------------
r41951 | joth@chromium.org | 2010-03-18 14:48:02 +0100 (Thu, 18 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h

Finish implementing the geolocation infobar; adds a Learn more link pointing to the (placeholder) help center page.
This extends ConfirmInfoBar to support to have optional link support (simple support, i.e. not the inserted mid-label link that LinkInfoBar sports)

Note 1: this does not exactly match the mock; the allow/deny buttons and link are swapped. I think this looks nicer, is more consistent with other confirm infobars, and happens to be easier to code
Note 2: linux & mac will need follow-up CLs, but will simply ignore the link in the meantime

BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*


Review URL: http://codereview.chromium.org/1037006
------------------------------------------------------------------------
r41949 | danno@chromium.org | 2010-03-18 14:11:41 +0100 (Thu, 18 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   A /trunk/src/chrome/browser/cocoa/cookie_details.h
   A /trunk/src/chrome/browser/cocoa/cookie_details.mm
   A /trunk/src/chrome/browser/cocoa/cookie_details_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.h
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Better code sharing between cookie tree and cookie prompt

Refactored code so that the class that encapsulates cookies details
is shared between the cookie tree and cookie prompt on the mac.

xib changes: Fixed the bindings in all of the subviews in the details view to use the new shared details class. Also added a currently hidden popup menu for selecting the cookie expiration time in the prompt details view--this needs to be wired up in a separate CL.

BUG=http://crbug.com/38348
TEST=added unit tests for the new class, manual testing of cookie tree and cookie prompt dialog

Review URL: http://codereview.chromium.org/1025003
------------------------------------------------------------------------
r41948 | dpolukhin@chromium.org | 2010-03-18 13:59:02 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h

Allow DomView derived classes to substitute TabContents with derived class.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1089002
------------------------------------------------------------------------
r41943 | satorux@chromium.org | 2010-03-18 12:36:58 +0100 (Thu, 18 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Major rework of the language settings dialog.

With this changes, users can add and remove preferred languages using the
table on the left, that used to be just saying "Not yet implemented".

TEST=manually
BUG=crosbug.com/1688

Review URL: http://codereview.chromium.org/1104001
------------------------------------------------------------------------
r41940 | joth@chromium.org | 2010-03-18 12:22:18 +0100 (Thu, 18 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Change the mac content blocked bubble to use the new bubble model rather than duplicate its logic
This is a follow up to http://codereview.chromium.org/668075 which made the corresponding changes in win & linux

BUG=none
TEST=chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm

Review URL: http://codereview.chromium.org/1018003
------------------------------------------------------------------------
r41934 | thestig@chromium.org | 2010-03-18 11:00:14 +0100 (Thu, 18 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Delete an out of date comment and include header cleanup.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/838008
------------------------------------------------------------------------
r41928 | yurys@chromium.org | 2010-03-18 08:22:36 +0100 (Thu, 18 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc

Repair remote debugging

Original change http://codereview.chromium.org/982008 by luoyx.

Change the first letter of two const strings to lowercase, to make them
consistent with message from WebKit. Otherwise, debugger output messages
won't be pushed out to remote clients.
Contributed by Yuxiang Luo (luoyx@google.com)

BUG=38387
TEST=Attach a remote debugger client to chrome, then open a testing page that has exception. Make sure exception information can be received.

Review URL: http://codereview.chromium.org/1103001
------------------------------------------------------------------------
r41920 | denisromanov@chromium.org | 2010-03-18 07:06:16 +0100 (Thu, 18 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/progress_bar.h

Added actual GoogleUpdate functionality to the OOBE update screen.
Added AddProgress method to the progress bar control.

BUG=35249
TEST=Run out/Debug/chrome --login-manager --login-screen=update. Update screen should remain visible for at least 3 seconds. As there is no network available in this mode yet, login wizard should return back to the network selection screen.

Review URL: http://codereview.chromium.org/1061004
------------------------------------------------------------------------
r41912 | thestig@chromium.org | 2010-03-18 05:30:14 +0100 (Thu, 18 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/base/debug_util_posix.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

In release mode, trigger a SIGABRT rather than a SIGTRAP for fatal log errors, i.e. CHECK(false). Also enable tests to make sure we assert/crash as expected.

BUG=none
TEST=Chrome in release mode generates crash dumps when CHECK() fails. See UI tests: AssertionTest.*:CheckFalseTest.*:RendererCrashTest.*
Review URL: http://codereview.chromium.org/830003
------------------------------------------------------------------------
r41911 | ben@chromium.org | 2010-03-18 05:28:06 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/gfx/codec/DEPS
   D /trunk/src/app/gfx/codec/jpeg_codec.cc
   D /trunk/src/app/gfx/codec/jpeg_codec.h
   D /trunk/src/app/gfx/codec/jpeg_codec_unittest.cc
   D /trunk/src/app/gfx/codec/png_codec.cc
   D /trunk/src/app/gfx/codec/png_codec.h
   D /trunk/src/app/gfx/codec/png_codec_unittest.cc
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/win_util.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/icon_loader_linux.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/tools/profiles/generate_profile.cc
   A /trunk/src/gfx/codec
   A /trunk/src/gfx/codec/DEPS (from /trunk/src/app/gfx/codec/DEPS:41810)
   A /trunk/src/gfx/codec/jpeg_codec.cc (from /trunk/src/app/gfx/codec/jpeg_codec.cc:41810)
   A /trunk/src/gfx/codec/jpeg_codec.h (from /trunk/src/app/gfx/codec/jpeg_codec.h:41810)
   A /trunk/src/gfx/codec/jpeg_codec_unittest.cc (from /trunk/src/app/gfx/codec/jpeg_codec_unittest.cc:41810)
   A /trunk/src/gfx/codec/png_codec.cc (from /trunk/src/app/gfx/codec/png_codec.cc:41810)
   A /trunk/src/gfx/codec/png_codec.h (from /trunk/src/app/gfx/codec/png_codec.h:41810)
   A /trunk/src/gfx/codec/png_codec_unittest.cc (from /trunk/src/app/gfx/codec/png_codec_unittest.cc:41810)
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/printing/emf_win.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/tools/imagediff/image_diff.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Move image codec stuff to toplevel gfx.

TBR=darin
BUG=none
TEST=none

------------------------------------------------------------------------
r41904 | jhawkins@chromium.org | 2010-03-18 02:02:43 +0100 (Thu, 18 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   A /trunk/src/chrome/browser/autofill/autofill_xml_parser.cc
   A /trunk/src/chrome/browser/autofill/autofill_xml_parser.h
   A /trunk/src/chrome/browser/autofill/autofill_xml_parser_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implement AutoFillXmlParser, used to parse responses from the AutoFill server.

BUG=none
TEST=AutoFillQueryXmlParserTest
Review URL: http://codereview.chromium.org/1014008
------------------------------------------------------------------------
r41903 | jrg@chromium.org | 2010-03-18 01:38:11 +0100 (Thu, 18 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_unittest.mm

Bookmark context menus reference bookmark IDs, not pointers, in case
they go away while the menu is open.

BUG=34522

TEST=\
1) Confirm bookmark context menus continue to work (e.g. rename, delete).
2) Repeat the "sync and delete while context menu" is open test from the
  bug; make sure the op is ignored (and we don't crash).

Review URL: http://codereview.chromium.org/1041003
------------------------------------------------------------------------
r41901 | zork@chromium.org | 2010-03-18 01:27:29 +0100 (Thu, 18 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   A /trunk/src/chrome/browser/sync/glue/history_model_worker.cc
   A /trunk/src/chrome/browser/sync/glue/history_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/typed_url_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/typed_url_model_associator.h
   A /trunk/src/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
   A /trunk/src/chrome/browser/sync/protocol/typed_url_specifics.proto
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/profile_mock.h

Update sync to support syncing of typed urls

Review URL: http://codereview.chromium.org/896001
------------------------------------------------------------------------
r41898 | bauerb@chromium.org | 2010-03-18 01:15:12 +0100 (Thu, 18 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.h
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   A /trunk/src/chrome/browser/repost_form_warning_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/form.html

Make repost form warning tab-modal on Mac.

Reloading a page for the second time dismisses the warning before showing it again.

CLs for other platforms forthcoming.

BUG=26271
TEST=RepostFormWarningTest.TestDoubleReload
Manual test: Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then reload. The warning sheet should be tab-modal, not window-modal. Hit reload again. The warning sheet should close and immediately reopen.

Review URL: http://codereview.chromium.org/969003
------------------------------------------------------------------------
r41894 | estade@chromium.org | 2010-03-18 00:56:12 +0100 (Thu, 18 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Gtk: fix context menu positioning, take 2.

Find correct screen (based on current position of mouse pointer) and monitor.

BUG=27800
Review URL: http://codereview.chromium.org/399101
------------------------------------------------------------------------
r41891 | thestig@chromium.org | 2010-03-17 23:41:41 +0100 (Wed, 17 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Linux: Pass --user-data-dir to the Zygote. (Reland r41369 now that the directory creation race has been fixed.)

BUG=none
TEST=On Linux, "chrome --enable-logging --user-data-dir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME.

TBR=evan
Original review: http://codereview.chromium.org/885003
Review URL: http://codereview.chromium.org/1060002
------------------------------------------------------------------------
r41890 | gregoryd@google.com | 2010-03-17 23:40:52 +0100 (Wed, 17 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/common/child_process_info.cc

Add support for showing NaCl 64-bit processes in Chrome's task manager and about:memory page

BUG=37732
TEST=none
Review URL: http://codereview.chromium.org/807005
------------------------------------------------------------------------
r41889 | finnur@chromium.org | 2010-03-17 23:39:16 +0100 (Wed, 17 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc

Fix crash when reloading/unloading extension after an infobar has been shown.

BUG=26463
TEST=Reload/shoot down the extension process hosting the extension/infobar and
make sure the browser doesn't crash.
 
Review URL: http://codereview.chromium.org/1001004
------------------------------------------------------------------------
r41888 | rafaelw@chromium.org | 2010-03-17 23:32:16 +0100 (Wed, 17 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc

Fix for ExtensionApiTest.Popup flakiness

This fires the OnPopupClosed event in a later event via PostTask. This gives the popup time to complete closing before the OnPopupClosed is received by the extension

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/1041004
------------------------------------------------------------------------
r41887 | jhawkins@chromium.org | 2010-03-17 23:30:55 +0100 (Wed, 17 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Enable AutoFill when in incognito mode.  The infobar will not be shown, but profiles can be manipulated in the AutoFill dialog, and the data from those profiles can be used to fill forms in an incognito window.

BUG=38009
TEST=none
Review URL: http://codereview.chromium.org/1064002
------------------------------------------------------------------------
r41886 | kuan@chromium.org | 2010-03-17 23:28:57 +0100 (Wed, 17 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

translate infobar: modify options menu

- show the same options menu regardless of infobar's states
- changes are made for win, linux and mac
- modified mac unittest so that it passes:
  - provide testing api to create options menu items
  - modify testing of menu items

BUG=38109
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/976009
------------------------------------------------------------------------
r41885 | ctguil@chromium.org | 2010-03-17 23:16:04 +0100 (Wed, 17 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/non_client_view.cc

Revert 41882 - [Accessibility] Chrome's main window is missing an accessible name

checkdeps.py failed

BUG=36732
TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. 

Review URL: http://codereview.chromium.org/661054

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/1063004
------------------------------------------------------------------------
r41883 | skrul@chromium.org | 2010-03-17 22:56:00 +0100 (Wed, 17 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/glue/sync_backend_host_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h

Pause the sync thread while starting data types.
A few things to note:
- I ended the plubming (it's-a me, mario!) at the SyncBackendHost (the PSS does not know about pausing).  The SyncBackendHost now has RequestPause/RequestResume methods.  The notifications that are sent when pause and resume is complete are dispatched to the notification service by the SyncBackendHost.
- Calls to SHB::Request(Pause|Resume) go directly to the similar named methods on the SyncerThread.  This is unlike other methods on the SHB which are usually dispatched to the "core" thread before calling deeper into the onion.  I did this to avoid having to deal with callbacks to carry the result value of pause/resume (since the methods can fail and return false).  If this is a problem I can change the way it works.
- There is a little trickery regarding the integration unit tests since we typically use a specially initialized SBH for these tests, and the syncer thread does not really run for these tests.  Since the thread is not running, pause and resume won't work properly.  To get around this, the DataTypeManagerImpl in these tests is constructed with a mock SBH that will respond properly to pause and resume requests.

BUG=37154,37553

Review URL: http://codereview.chromium.org/1063002
------------------------------------------------------------------------
r41882 | ctguil@chromium.org | 2010-03-17 22:41:07 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/non_client_view.cc

[Accessibility] Chrome's main window is missing an accessible name

BUG=36732
TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. 

Review URL: http://codereview.chromium.org/661054
------------------------------------------------------------------------
r41879 | andybons@chromium.org | 2010-03-17 22:12:05 +0100 (Wed, 17 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   A /trunk/src/chrome/browser/cocoa/extensions/browser_actions_overflow_menu.h
   A /trunk/src/chrome/browser/cocoa/extensions/browser_actions_overflow_menu.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Adds button and menu class skeleton for the chevron in the Browser Actions container.

TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1037007
------------------------------------------------------------------------
r41876 | estade@chromium.org | 2010-03-17 22:00:47 +0100 (Wed, 17 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/app_launcher.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Revert r41803 and r41799

BUG=38414
TEST=none
TBR=jam

Review URL: http://codereview.chromium.org/1039006
------------------------------------------------------------------------
r41875 | bauerb@chromium.org | 2010-03-17 21:50:29 +0100 (Wed, 17 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.mm

[Mac] Honor modifier keys in back/forward menu.

Add a method ActivatedAtWithDisposition to BackForwardMenuModel that navigates to a history item with a certain window disposition (current tab, new background/foreground tab).

Change BackForwardMenuController to call ActivatedAtWithDisposition with the disposition created from the current NSEvent.

Also, factor out some common code in Browser::GoBack and GoForward.

BUG=37984
TEST=Navigate to a history item in the back/forward menu while holding down the command key. The item should open in a new tab. Likewise, holding down cmd-shift should open it in a new foreground tab.

Review URL: http://codereview.chromium.org/910001
------------------------------------------------------------------------
r41874 | brg@chromium.com | 2010-03-17 21:41:58 +0100 (Wed, 17 Mar 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_clipboard_api.cc
   A /trunk/src/chrome/browser/extensions/extension_clipboard_api.h
   A /trunk/src/chrome/browser/extensions/extension_clipboard_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/experimental.clipboard.html
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   A /trunk/src/chrome/common/extensions/docs/static/experimental.clipboard.html
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/clipboard
   A /trunk/src/chrome/test/data/extensions/api_test/clipboard/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/clipboard/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/clipboard/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/clipboard/test_helper.js

Committing for dcheng@
Original review: http://codereview.chromium.org/882003
Review URL: http://codereview.chromium.org/1042004
------------------------------------------------------------------------
r41873 | aa@chromium.org | 2010-03-17 21:36:05 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/common/utility_messages_internal.h
   M /trunk/src/chrome/utility/utility_thread.cc

This looks like it was causing the pipe to sometimes overfill.

BUG=38220
TEST=See bug

Review URL: http://codereview.chromium.org/1003004
------------------------------------------------------------------------
r41872 | jhawkins@chromium.org | 2010-03-17 21:31:07 +0100 (Wed, 17 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_number.cc
   M /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

AutoFill: Implement set_whole_number and use it to load whole phone numbers from the WebDB.

BUG=38218
TEST=WebDatabaseTest.AutoFillProfile
Review URL: http://codereview.chromium.org/1043003
------------------------------------------------------------------------
r41869 | arv@chromium.org | 2010-03-17 21:19:57 +0100 (Wed, 17 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/favicon_service.cc
   M /trunk/src/chrome/browser/favicon_service.h
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/jumplist.h
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Change so that the extension favicon is read on the UI thread since extension objects should only be accessed on the UI thread.

This also fixes erg's todo to make favicons use RefCountedMemory instead of RefCountedBytes in all places.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1028001
------------------------------------------------------------------------
r41867 | agl@chromium.org | 2010-03-17 21:08:01 +0100 (Wed, 17 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: fix SELinux support.

(First of a series to improve our SELinux support)

http://codereview.chromium.org/1000008
------------------------------------------------------------------------
r41865 | akalin@chromium.org | 2010-03-17 21:01:37 +0100 (Wed, 17 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc
   A /trunk/src/chrome/browser/sync/notifier/base/sigslotrepeater.h (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h:41848)
   D /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.cc
   D /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.h
   D /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.cc
   D /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/inet_aton.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/third_party/libjingle/files/talk/base/win32window.cc (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc:41848)
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Removed auth_task.* and talk_auth_task.* (dead code)

Removed GaiaAuth class.  Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth.

Removed now-unneeded parameters.

BUG=38034
TEST=manual with and without --invalidate-sync-xmpp-login

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41790

Review URL: http://codereview.chromium.org/885008
------------------------------------------------------------------------
r41859 | creis@chromium.org | 2010-03-17 20:07:25 +0100 (Wed, 17 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable failing Unload UI test until fixed.

TBR=stuartmorgan
BUG=34827
TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent

Review URL: http://codereview.chromium.org/1000009
------------------------------------------------------------------------
r41857 | skrul@chromium.org | 2010-03-17 19:28:33 +0100 (Wed, 17 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Change observer expectations
This should prevent some test flakyness we saw on vista.

Review URL: http://codereview.chromium.org/977003
------------------------------------------------------------------------
r41855 | thestig@chromium.org | 2010-03-17 19:23:26 +0100 (Wed, 17 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

gtk: Fix menu display logic for people with top/down xinerama setups.

BUG=14184
TEST=see bug
Review URL: http://codereview.chromium.org/1026006
------------------------------------------------------------------------
r41854 | rafaelw@chromium.org | 2010-03-17 19:20:31 +0100 (Wed, 17 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   D /trunk/src/chrome/browser/extensions/extension_popup_host.cc
   D /trunk/src/chrome/browser/extensions/extension_popup_host.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   M /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h

Initial support for inspecting extension popups.

The primary change in this CL is a refactor which makes ExtensionPopup a bit more self-contained WRT its clients. It adds the ability to specify an "inspect_with_devtools" flag to its Show() method which will cause the popup to remain open regardless of losing focus and to focus a devtools window on the popup's render view host.

This CL also pulls apart some aspects of the extension_popup_api from ExtensionFunctionDispatcher and ExtensionHost.

Still remaining to be done are:

1) Also the popup to stay open when the host window drags (it current closes)
2) Support for GTK
3) Support for Mac

BUG=24477

Review URL: http://codereview.chromium.org/1001002
------------------------------------------------------------------------
r41852 | dimich@chromium.org | 2010-03-17 19:12:40 +0100 (Wed, 17 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/debug_flags.cc
   M /trunk/src/chrome/worker/worker_main.cc

Adding debugging switches to Worker process startup on POSIX systems.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1023005
------------------------------------------------------------------------
r41850 | darin@chromium.org | 2010-03-17 18:58:43 +0100 (Wed, 17 Mar 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Add chromium-side support for history.{push,replace}State.

Enables the feature so that all but 2 of the related layout tests pass.

Modifies TestShell to correctly update its location bar as navigations occur.
It was incorrectly showing firstPartyForCookies for some crazy reason.

Modifies glue_serialize.cc to store the state object associated with a session
history entry.

Modifies navigation_controller.cc to always replace the current navigation
entry when observing an in-page navigation.  This is required since the page ID
isn't changing for an in-page navigation.

BUG=29393
R=brettw
TEST=covered by layout tests

Review URL: http://codereview.chromium.org/1036003
------------------------------------------------------------------------
r41845 | thakis@chromium.org | 2010-03-17 18:02:59 +0100 (Wed, 17 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/webkit/glue/webmenurunner_mac.h
   M /trunk/src/webkit/glue/webmenurunner_mac.mm
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm

[Mac] Match popup contents to page zoom size.

Fix the size of the font used in popups presented by the browser UI
thread.  WebKit was modified to add a field containing the font size,
the font size is then propagated in the message sent to the browser,
and the web menu runner sets that font size on the popup button
resonsible for running the popup menu.

Requires WebKit release >= 55897.  See WebKit bug https://bugs.webkit.org/show_bug.cgi?id=35990

BUG=14010
TEST=none

Review URL: http://codereview.chromium.org/996001
Patch from scottbyer@chromium.org.
------------------------------------------------------------------------
r41844 | creis@chromium.org | 2010-03-17 17:49:10 +0100 (Wed, 17 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc

Fixes a timeout issue in RenderWidgetHost.
Before, each call to StartHangMonitorTimeout would reset the timer,
possibly postponing it indefinitely.

BUG=11007
BUG=16535
TEST=RenderWidgetHostTest.DontPostponeHangMonitorTimeout
TEST=RenderWidgetHostTest.StopAndStartHangMonitorTimeout
TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent

Review URL: http://codereview.chromium.org/1034001
------------------------------------------------------------------------
r41840 | tim@chromium.org | 2010-03-17 16:35:14 +0100 (Wed, 17 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker.h

Add a lock to read |state_| in UIModelWorker::DoWorkAndWait.  We don't
strictly need to acquire the lock here because this can only get called
while !syncapi_has_shutdown_ and STOPPED could only get set after that
bool is false (and that bool is protected by locks), the purpose of this
DCHECK/return is for catching developer error in extraordinary cases,
so in a way, adding ANNOTATE_UNPROTECTED_READ would seem hypocritical.

BUG=32892
TEST=UIModelWorkerTest

Review URL: http://codereview.chromium.org/965002
------------------------------------------------------------------------
r41836 | avi@chromium.org | 2010-03-17 15:05:05 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Drop a comment that's no longer valid.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1002005
------------------------------------------------------------------------
r41823 | phajdan.jr@chromium.org | 2010-03-17 10:36:11 +0100 (Wed, 17 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

[GTTF] Remove the internal timeout of extension browser tests.

Now we have a global timeout for browser tests enforced by
out of process test launcher.

Having too many different timeouts all over the place makes
debugging issues harder.

TEST=browser_tests
BUG=none

Review URL: http://codereview.chromium.org/1046001
------------------------------------------------------------------------
r41819 | tony@chromium.org | 2010-03-17 08:35:56 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/file_watcher_unittest.cc

Add more sync calls to try to make the FileWatcher test not
flaky on OSX.

BUG=38188

Review URL: http://codereview.chromium.org/1045004
------------------------------------------------------------------------
r41818 | ukai@chromium.org | 2010-03-17 08:29:54 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/socket_stream/socket_stream.h
   D /trunk/src/net/socket_stream/socket_stream_throttle.cc
   D /trunk/src/net/socket_stream/socket_stream_throttle.h
   M /trunk/src/net/websockets/websocket_job.cc
   M /trunk/src/net/websockets/websocket_job.h
   M /trunk/src/net/websockets/websocket_job_unittest.cc
   M /trunk/src/net/websockets/websocket_throttle.cc
   M /trunk/src/net/websockets/websocket_throttle.h
   M /trunk/src/net/websockets/websocket_throttle_unittest.cc

Refactor WebSocket throttling feature.

Protocol specific handling should be done in SocketStreamJob subclasss,
so websocket throttling should be handled in WebSocketJob.

Review URL: http://codereview.chromium.org/669157
------------------------------------------------------------------------
r41814 | ben@chromium.org | 2010-03-17 08:05:22 +0100 (Wed, 17 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc

fixing bustage... file was moved
------------------------------------------------------------------------
r41813 | ben@chromium.org | 2010-03-17 07:48:08 +0100 (Wed, 17 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h

forgot a couple of files... moved gfx stuff to toplevel dir
------------------------------------------------------------------------
r41812 | ben@chromium.org | 2010-03-17 07:40:57 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/gfx/blit.cc
   D /trunk/src/app/gfx/blit.h
   D /trunk/src/app/gfx/gtk_native_view_id_manager.cc
   D /trunk/src/app/gfx/gtk_native_view_id_manager.h
   D /trunk/src/app/gfx/gtk_util.cc
   D /trunk/src/app/gfx/gtk_util.h
   D /trunk/src/app/gfx/insets.cc
   D /trunk/src/app/gfx/insets.h
   D /trunk/src/app/gfx/insets_unittest.cc
   D /trunk/src/app/gfx/native_widget_types.h
   D /trunk/src/app/gfx/native_widget_types_gtk.cc
   D /trunk/src/app/gfx/path.cc
   D /trunk/src/app/gfx/path.h
   D /trunk/src/app/gfx/path_gtk.cc
   D /trunk/src/app/gfx/path_win.cc
   D /trunk/src/app/gfx/scrollbar_size.cc
   D /trunk/src/app/gfx/scrollbar_size.h
   M /trunk/src/app/menus/menu_model.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/win/window_impl.h
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/browser/aeropeek_manager.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_host.h
   M /trunk/src/chrome/browser/cocoa/download_util_mac.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_bridge.h
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extension_popup_host.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/fonts_languages_window.h
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.h
   M /trunk/src/chrome/browser/gtk/certificate_viewer.h
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_drag.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/native_window_notification_source.h
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/gpu/gpu_backing_store_win.h
   M /trunk/src/chrome/gpu/gpu_command_buffer_stub.h
   M /trunk/src/chrome/gpu/gpu_thread.h
   M /trunk/src/chrome/gpu/gpu_view_win.h
   M /trunk/src/chrome/gpu/gpu_view_x.h
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h
   A /trunk/src/gfx/blit.cc (from /trunk/src/app/gfx/blit.cc:41613)
   A /trunk/src/gfx/blit.h (from /trunk/src/app/gfx/blit.h:41613)
   M /trunk/src/gfx/gfx.gyp
   A /trunk/src/gfx/gtk_native_view_id_manager.cc (from /trunk/src/app/gfx/gtk_native_view_id_manager.cc:41613)
   A /trunk/src/gfx/gtk_native_view_id_manager.h (from /trunk/src/app/gfx/gtk_native_view_id_manager.h:41613)
   A /trunk/src/gfx/gtk_util.cc (from /trunk/src/app/gfx/gtk_util.cc:41613)
   A /trunk/src/gfx/gtk_util.h (from /trunk/src/app/gfx/gtk_util.h:41613)
   A /trunk/src/gfx/insets.cc (from /trunk/src/app/gfx/insets.cc:41613)
   A /trunk/src/gfx/insets.h (from /trunk/src/app/gfx/insets.h:41613)
   A /trunk/src/gfx/insets_unittest.cc (from /trunk/src/app/gfx/insets_unittest.cc:41613)
   A /trunk/src/gfx/native_widget_types.h (from /trunk/src/app/gfx/native_widget_types.h:41613)
   A /trunk/src/gfx/native_widget_types_gtk.cc (from /trunk/src/app/gfx/native_widget_types_gtk.cc:41613)
   A /trunk/src/gfx/path.cc (from /trunk/src/app/gfx/path.cc:41613)
   A /trunk/src/gfx/path.h (from /trunk/src/app/gfx/path.h:41613)
   A /trunk/src/gfx/path_gtk.cc (from /trunk/src/app/gfx/path_gtk.cc:41613)
   A /trunk/src/gfx/path_win.cc (from /trunk/src/app/gfx/path_win.cc:41613)
   A /trunk/src/gfx/scrollbar_size.cc (from /trunk/src/app/gfx/scrollbar_size.cc:41613)
   A /trunk/src/gfx/scrollbar_size.h (from /trunk/src/app/gfx/scrollbar_size.h:41613)
   M /trunk/src/gpu/command_buffer/service/gpu_processor.h
   M /trunk/src/gpu/demos/framework/window.h
   M /trunk/src/printing/printed_document.h
   M /trunk/src/printing/printing_context.h
   M /trunk/src/views/border.h
   M /trunk/src/views/controls/button/native_button_wrapper.h
   M /trunk/src/views/controls/combobox/native_combobox_wrapper.h
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/slider/native_slider_gtk.cc
   M /trunk/src/views/controls/slider/native_slider_wrapper.h
   M /trunk/src/views/controls/table/native_table_gtk.cc
   M /trunk/src/views/controls/table/native_table_wrapper.h
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/drag_utils_gtk.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/grid_layout.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/screen.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/widget/tooltip_manager_win.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/plugin_instance.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webplugin_page_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h

Move some more files to toplevel gfx dir.

TBR=darin
BUG=none
TEST=none

------------------------------------------------------------------------
r41808 | hbono@google.com | 2010-03-17 05:17:53 +0100 (Wed, 17 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc
   D /trunk/src/chrome/browser/sync/notifier/base/sigslotrepeater.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.cc (from /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.cc:41789)
   A /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.h (from /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.h:41789)
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.cc (from /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.cc:41789)
   A /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.h (from /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.h:41789)
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc:41789)
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h:41789)
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc:41789)
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.h (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.h:41789)
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/inet_aton.h (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/inet_aton.h:41789)
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h:41789)
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc:41789)
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/third_party/libjingle/files/talk/base/win32window.cc
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Revert 41790 - Removed auth_task.* and talk_auth_task.* (dead code) because Windows XP doesn't have inet_pton and it crashes XP bots.

Removed GaiaAuth class.  Gtalk login will now fail immediately instead of trying (in vain) to gaiaauth.

Removed nowunneeded parameters.

BUG=38034
TEST=manual with and without invalidatesyncxmpplogin

Review URL: http://codereview.chromium.org/885008

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/983005
------------------------------------------------------------------------
r41806 | finnur@chromium.org | 2010-03-17 03:34:08 +0100 (Wed, 17 Mar 2010) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc
   A /trunk/src/chrome/browser/extensions/extension_infobar_delegate.h
   A /trunk/src/chrome/browser/extensions/extension_infobar_module.cc
   A /trunk/src/chrome/browser/extensions/extension_infobar_module.h
   A /trunk/src/chrome/browser/extensions/extension_infobar_module_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_infobar_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   A /trunk/src/chrome/browser/resources/extensions_infobar.css
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   A /trunk/src/chrome/browser/views/infobars/extension_infobar.cc
   A /trunk/src/chrome/browser/views/infobars/extension_infobar.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/experimental.html
   A /trunk/src/chrome/common/extensions/docs/experimental.infoBar.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/view_types.cc
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

First cut at adding Extension Infobars to the experimental API.

Originally described here:
http://code.google.com/p/chromium/wiki/InfoBarExtensionAPI

The API is simple:

chrome.experimental.infoBar.show(
  {"htmlPath": "infobar.html"}, function(window) {
  // |window| is where the infobar was shown.
});

To close it, you can simply call window.close() from within the InfoBar (infoBar.hide is not provided).

The api is privileged (not available to content scripts directly).

The minimum height for the infobar is regular height for our infobars (32 pixels), maximum is twice that and the actual size is determined by the content (within these constraints mentioned).

See screenshot in bug. The icon on the far left is an extension icon with a dropdown menu showing the menu that shows when you right-click on the extension icon in the Omnibox/browser action container.

BUG=26463
TEST=None (for now).

Review URL: http://codereview.chromium.org/1049001
------------------------------------------------------------------------
r41804 | gregoryd@google.com | 2010-03-17 03:06:33 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/nacl/broker_thread.cc

Don't keep a pointer to NaClBrokerHost in NaClBrokerService - use ChildProcessHost::Iterator instead. This change fixes the crash that occured if the browser was closed while the NaCl module was still running (found by nacl_ui_tests).
Also make nacl_ui_tests depend on nacl win64 binary (required to run the tests on Win64)

BUG=none
TEST=nacl_ui_tests
Review URL: http://codereview.chromium.org/875005
------------------------------------------------------------------------
r41803 | estade@chromium.org | 2010-03-17 02:54:52 +0100 (Wed, 17 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/app_launcher.h

Fix chromeos build

BUG=none
TEST=build works again

Review URL: http://codereview.chromium.org/1051002
------------------------------------------------------------------------
r41801 | oshima@chromium.org | 2010-03-17 02:19:06 +0100 (Wed, 17 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   A /trunk/src/chrome/browser/chromeos/notifications/notification_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   A /trunk/src/chrome/browser/chromeos/notifications/system_notification_factory.cc
   A /trunk/src/chrome/browser/chromeos/notifications/system_notification_factory.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.h
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon.cc
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/notification.h
   A /trunk/src/chrome/browser/notifications/notification_delegate.h
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.cc
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   M /trunk/src/chrome/browser/notifications/notification_test_util.h
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

* Moved sticky/controls frag to chromeos::BalloonViewImpl
* Added AddSystemNotification to add system notification
and  UpdateNotification to update a notification.
* refactored NotificationObjectProxy and added NotificationDelegate class.
* Added notification_browser.cc.

BUG=33306
TEST=added notification_browser.cc with minimal test. I'll add more in next step.

Review URL: http://codereview.chromium.org/1013002
------------------------------------------------------------------------
r41800 | estade@chromium.org | 2010-03-17 02:13:37 +0100 (Wed, 17 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add a pref for the number of showing icons in the browser actions toolbar.

Also fix some issues on GTK concerning the proper behavior when adding/removing browser actions (container sizing + chevron visibility).

Windows uses a different pref (kBrowserActionContainerWidth), which is measured in pixels; it should be migrated to the new pref.

Also, register extension prefs during startup.

BUG=32101
TEST=manual

Review URL: http://codereview.chromium.org/841007
------------------------------------------------------------------------
r41799 | estade@chromium.org | 2010-03-17 02:13:11 +0100 (Wed, 17 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Basic DragImage implementation.

Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit.

TODO later:
- use the image on windows, mac
- implement the other DragImageRef functions

TEST=drag an image from the render view in GTK
BUG=11457

Review URL: http://codereview.chromium.org/668125
------------------------------------------------------------------------
r41798 | jhawkins@chromium.org | 2010-03-17 02:10:41 +0100 (Wed, 17 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc

More AutoFill heuristics fixes.
* Match addr1, addr2 for Address Line 1/2.
* Match pcode for postal/zip code.
* Fix the termination condition for the address matching loop.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1006004
------------------------------------------------------------------------
r41791 | eroman@chromium.org | 2010-03-17 01:26:51 +0100 (Wed, 17 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/net_internals_ui.cc
   A /trunk/src/chrome/browser/dom_ui/net_internals_ui.h
   A /trunk/src/chrome/browser/resources/net_internals
   A /trunk/src/chrome/browser/resources/net_internals/index.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Add a DOMUI datasource that will handle the net-internals page.

Right now it is bound to the temporary URL "chrome://net2", since the frontend is under construction.
(Loading this page right now just shows a dummy HTML page.)

This change is a first step to transitioning the about:net-internals  / about:network pages from C++ to javascript.
Note that the network stuff needs to run on the IO thread, however the DOMUI infrastructure is all set up to run on the UI thread.
I work around this by proxying things back and forth through the IO thread. Hopefully in subsequent iterations this overhead can be removed, by exposing a sort of "IO thread DOMUI".

BUG=37421

Review URL: http://codereview.chromium.org/1036001
------------------------------------------------------------------------
r41790 | akalin@chromium.org | 2010-03-17 01:24:19 +0100 (Wed, 17 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc
   A /trunk/src/chrome/browser/sync/notifier/base/sigslotrepeater.h (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h:41764)
   D /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.cc
   D /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.h
   D /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.cc
   D /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/inet_aton.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/third_party/libjingle/files/talk/base/win32window.cc (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc:41764)
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Removed auth_task.* and talk_auth_task.* (dead code)

Removed GaiaAuth class.  Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth.

Removed now-unneeded parameters.

BUG=38034
TEST=manual with and without --invalidate-sync-xmpp-login

Review URL: http://codereview.chromium.org/885008
------------------------------------------------------------------------
r41788 | oshima@chromium.org | 2010-03-17 01:16:53 +0100 (Wed, 17 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc

Fix a crash when a moust observer got a mouse event on a wnidow that has already been destroyed.

BUG=chromium-os:1697
TEST=manual: switch to compact nav bar mode (ctrl-shift-c), move mouse to a tab to open compact location bar,
   then open app launcher. Type in something in the address bar and select from suggestion list.

Review URL: http://codereview.chromium.org/1048003
------------------------------------------------------------------------
r41787 | mpcomplete@chromium.org | 2010-03-17 01:16:02 +0100 (Wed, 17 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Spruced up the warning dialog for when you enable an extension in incognito.

I hijacked the extension install/uninstall dialog, and added another type that
it can transmogrify into.

BUG=32365

Review URL: http://codereview.chromium.org/1041002
------------------------------------------------------------------------
r41782 | estade@chromium.org | 2010-03-16 23:50:23 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h

Finish porting FindInPageControllerTest to linux.

BUG=37809,268629
TEST=test passes

Review URL: http://codereview.chromium.org/997004
------------------------------------------------------------------------
r41780 | georgey@chromium.org | 2010-03-16 23:39:29 +0100 (Tue, 16 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc

Fixes first and third points in the bug "Autofill profile dialog box polish items". 
Adds correct expand icons to the AutoFill dialog. The icons were added in a separate CL.
Moves asynchronous access to the database inside the dialog (it now shows "Loading..." while db is being connected)
Also fixes memory leak.
BUG=36601
TEST=in the bug
Review URL: http://codereview.chromium.org/669076
------------------------------------------------------------------------
r41779 | arv@chromium.org | 2010-03-16 23:27:17 +0100 (Tue, 16 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Remove eval/new Function from file browser.

Review URL: http://codereview.chromium.org/969005
------------------------------------------------------------------------
r41773 | inferno@chromium.org | 2010-03-16 23:05:15 +0100 (Tue, 16 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc

This patch strips out the http auth credentials before storing it in History DB.

BUG=20318
TEST=Visit a url having auth credentials. Check history db to see url stored without credentials.
Review URL: http://codereview.chromium.org/1012001
------------------------------------------------------------------------
r41772 | estade@chromium.org | 2010-03-16 23:02:35 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc

Add a couple more drop targets to the render view.

BUG=35063
TEST=see bug

Review URL: http://codereview.chromium.org/1030001
------------------------------------------------------------------------
r41770 | dhg@chromium.org | 2010-03-16 22:56:50 +0100 (Tue, 16 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Changing filebrowse html to delete pause when file is finished.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/845003
------------------------------------------------------------------------
r41768 | eroman@chromium.org | 2010-03-16 22:41:10 +0100 (Tue, 16 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Move over another legacy "LoadLog-style" event generator to routing its messages through the NetLog.

BUG=37421

Review URL: http://codereview.chromium.org/1052002
------------------------------------------------------------------------
r41767 | sky@chromium.org | 2010-03-16 22:34:01 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Nukes changing the size of the icon on hover, and instead changes
the size of the icon when the tab is in the background and the title
changes.

BUG=37333
TEST=none

Review URL: http://codereview.chromium.org/974003
------------------------------------------------------------------------
r41765 | jhawkins@chromium.org | 2010-03-16 22:24:29 +0100 (Tue, 16 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h

AutoFill: Load the imported form data into the AutoFill dialog when the user accepts the AutoFill InfoBar.  Save a one-time initial profile to the WebDB if the user dismisses the InfoBar or the InfoBar closes.

BUG=38104,38096
TEST=AutoFillInfoBarDelegateTest
Review URL: http://codereview.chromium.org/974004
------------------------------------------------------------------------
r41764 | mpcomplete@chromium.org | 2010-03-16 22:18:04 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc

Fix 2 issues with incognito extensions on linux:
- Drag and drop of browser actions wouldn't work properly from an incognito
window.
- Installing an extension from an incognito window raised a DCHECK.

Review URL: http://codereview.chromium.org/983004
------------------------------------------------------------------------
r41761 | akalin@chromium.org | 2010-03-16 21:54:02 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/prexmppauth.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.h
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Split up PreXmppAuth and SaslHandler.

Created a X-GOOGLE-TOKEN-only SaslHandler class for use by sync.

BUG=38034
TEST=manual

Review URL: http://codereview.chromium.org/904006
------------------------------------------------------------------------
r41760 | arv@chromium.org | 2010-03-16 21:45:22 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/local_strings.js
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Unify LocalStrings.

The main difference is that we are now using $1 - $9 instead of %s. This is more consistent with the C++ code as well.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/1045003
------------------------------------------------------------------------
r41758 | thomasvl@chromium.org | 2010-03-16 21:36:36 +0100 (Tue, 16 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FirstRunDialog.xib
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm

[Mac] First run dialog cleanup
- coding style fixes for ivars
- fixed some 10.6 toolchain warnings from the xib
- provide custom getters for two properties to always return false when the matching controls are hidden.
- Autosize the window to handle any possible l10n now
  - Make headers, buttons, and all by the stats/breakpad checkbox force the window to grow as needed.
  - Wrap the stats/breakpad checkbox to the resulting width (it will never fit otherwise).
  - Layout/shuffling things based on the views that get hidden (no other browsers to import from, not stats pref).

BUG=37743
TEST=text isn't clipped in any language
Review URL: http://codereview.chromium.org/995002
------------------------------------------------------------------------
r41753 | thakis@chromium.org | 2010-03-16 21:11:58 +0100 (Tue, 16 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm

Obj-C readability review for thakis.

Review URL: http://codereview.chromium.org/790006
------------------------------------------------------------------------
r41749 | arv@chromium.org | 2010-03-16 20:42:29 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/chrome_dll.gypi

Bookmark manager: Use the default favicon until chrome://favicon/ works for extensions.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/898004
------------------------------------------------------------------------
r41748 | avi@chromium.org | 2010-03-16 20:31:32 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Fix bubbles (bookmark, status, blocked content, both extension ones) in resolution independence.

BUG=http://crbug.com/19476, http://crbug.com/36366
TEST=click the star in RI and the bubble should position itself correctly; status bubble should have adequate height for text

Review URL: http://codereview.chromium.org/851009
------------------------------------------------------------------------
r41746 | erg@chromium.org | 2010-03-16 20:23:09 +0100 (Tue, 16 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_win.cc

Revert 41739 - Factoring duplicate code from platformspecific LoginHandlers into a base
LoginHandler class. As pointed out by erg, it would be cleaner to use a
separate controller class, but this simple refactor should make that easier.

Contributed by tonyg@chromium.org

BUG=14909
TEST=ui_tests gtest_filter=LoginPromptTest*

Review URL: http://codereview.chromium.org/834001
Patch from tonyg@chromium.org.

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/989004
------------------------------------------------------------------------
r41744 | ctguil@chromium.org | 2010-03-16 20:20:13 +0100 (Tue, 16 Mar 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.h
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

[accessibility] Bookmarks bar is missing some MSAA information

Return the link role for the Link view.

Return the grouping role for BookmarkBarInstructionsView.

Support the link role in views accessibility types.

Updated browser views accessibility tests.
- Verify BrowserRootView accessibility info.
- Verify BrowserView accessibility info.
- Verify BookmarkBarView accessibility info.
- In TestViewAccessibilityObject don't SetAccessible name, we should be testing that this name is correctly set.

Set the accessible name for the application in BrowserRootView instead of OpaqueBrowserFrameView

BUG=36281
TEST=Verify bookmarks bar tree in AccExplorer32.exe 

Review URL: http://codereview.chromium.org/652156
------------------------------------------------------------------------
r41743 | jar@chromium.org | 2010-03-16 20:06:03 +0100 (Tue, 16 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/net_util.cc

Refine IPv6 probe to require that the client has an IPv6 address on an interface

This currently only works on Posix, not windows.

Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).

The test performed is performed on a worker thread, so latency should not
be an issue (even if we created much slower tests).

The current test appears to takes in the raneg of 50-100ms, and probably
(under the covers) does some reading from files).

BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/1006001
------------------------------------------------------------------------
r41739 | erg@chromium.org | 2010-03-16 19:44:21 +0100 (Tue, 16 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_win.cc

Factoring duplicate code from platform-specific LoginHandlers into a base
LoginHandler class. As pointed out by erg, it would be cleaner to use a
separate controller class, but this simple refactor should make that easier.

Contributed by tonyg@chromium.org

BUG=14909
TEST=ui_tests --gtest_filter=LoginPromptTest*

Review URL: http://codereview.chromium.org/834001
Patch from tonyg@chromium.org.
------------------------------------------------------------------------
r41738 | thestig@chromium.org | 2010-03-16 19:43:49 +0100 (Tue, 16 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc

Linux: Fix test crash expectations for MetricsServiceTest.CrashRenderers.

BUG=none
TEST=MetricsServiceTest.CrashRenderers passes on Linux with and without breakpad.
Review URL: http://codereview.chromium.org/1010001
------------------------------------------------------------------------
r41732 | jhawkins@chromium.org | 2010-03-16 17:52:41 +0100 (Tue, 16 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc

Don't use the empty string to try to match against an empty text field.  Add FormField::ParseEmptyText which encapsulates matching an empty text field.

BUG=38264
TEST=FormStructureTest.HeuristicsSample6
Review URL: http://codereview.chromium.org/994002
------------------------------------------------------------------------
r41730 | avayvod@google.com | 2010-03-16 17:36:31 +0100 (Tue, 16 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   M /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Fixed view deletion on language switch.
Enhanced screen bounds determination.

BUGS=none
TEST=Launch with --login-manager --login-screen-size=1024,600 and verify
that wizard screen is centered within the background window and the window
is centered within the monitor. Launch with --login-manager
--login-screen=network and change language. Verify that nothing craches with
segmentation fault.

Review URL: http://codereview.chromium.org/971002
------------------------------------------------------------------------
r41726 | viettrungluu@chromium.org | 2010-03-16 16:42:55 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Mac: toggle between "Enter/Exit Full Screen" in menus.

BUG=24390
TEST=When *not* fullscreen, menu items (under View in main menu and in app menu) should be "Enter Full Screen"; when fullscreen, they should be "Exit Full Screen"; menu items should still work; keyboard shortcuts should still work.

Review URL: http://codereview.chromium.org/1011002
------------------------------------------------------------------------
r41724 | tim@chromium.org | 2010-03-16 16:12:30 +0100 (Tue, 16 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h

Change MediatorThreadImpl::Run to process messages forever and periodically call PumpAuxiliaryLoops to run the 3 (!!:(!!) other loops associated with this thread. There was previously a race where
quit would be called and set a cancellation flag before the posted task would 
get executed.

BUG=37771

Review URL: http://codereview.chromium.org/984001
------------------------------------------------------------------------
r41722 | joth@chromium.org | 2010-03-16 15:58:41 +0100 (Tue, 16 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/mock_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   M /trunk/src/chrome/common/geoposition.cc
   M /trunk/src/chrome/common/geoposition.h
   M /trunk/src/chrome/renderer/geolocation_dispatcher.cc
   M /trunk/src/chrome/renderer/geolocation_dispatcher.h

Switch from using custom time / epoch handling code (inherited from gears) to base::Time


BUG=http://code.google.com/p/chromium/issues/detail?id=37510
TEST=unit_tests --gtest_filter=geol*

Review URL: http://codereview.chromium.org/776001
------------------------------------------------------------------------
r41721 | yusukes@chromium.org | 2010-03-16 15:52:05 +0100 (Tue, 16 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Chrome OS language menu localization.

- use localized strings for IME properties.
- use std::wstring in FormatInputLanguage() function so that an input language string is trimmed at a character boundary.

This CL depends on http://codereview.chromium.org/948001 .

BUG=none
TEST=manual.

Review URL: http://codereview.chromium.org/882004
------------------------------------------------------------------------
r41720 | yusukes@chromium.org | 2010-03-16 15:50:21 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Handle all checkboxes. Currently, the ButtonPressed() handler ignores checkboxes other than the last one.

BUG=none
TEST=open the configuration dialog, click all checkboxes, verify that all IMEs are activated.

Review URL: http://codereview.chromium.org/1024002
------------------------------------------------------------------------
r41718 | yusukes@chromium.org | 2010-03-16 14:49:13 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc

Add string resources for ibus-pinyin and ibus-hangul.

BUG=none
TEST=manual.

Review URL: http://codereview.chromium.org/1042001
------------------------------------------------------------------------
r41707 | satorux@chromium.org | 2010-03-16 12:04:45 +0100 (Tue, 16 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc

chromeos: Implement a TODO to rename the class TextInputSection as well
the section name in System Options.

BUG=None
TEST=compiles

Review URL: http://codereview.chromium.org/935001
------------------------------------------------------------------------
r41704 | phajdan.jr@chromium.org | 2010-03-16 11:35:51 +0100 (Tue, 16 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc

Disable ExtensionApiTest.WebSocket due to a timeout.

TBR=ukai
TEST=disabled
BUG=38225

Review URL: http://codereview.chromium.org/1002003
------------------------------------------------------------------------
r41699 | oshima@chromium.org | 2010-03-16 10:30:32 +0100 (Tue, 16 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   A /trunk/src/chrome/browser/notifications/notification_test_util.h
   M /trunk/src/chrome/chrome_tests.gypi

Factored out common classes used in notification tests.
Replaced TestQueueing with one that makes more sense on ChromeOS.

BUG=33306
TEST=Replaced TestQueueing with TestManyNotifications.

Review URL: http://codereview.chromium.org/791004
------------------------------------------------------------------------
r41698 | satorux@chromium.org | 2010-03-16 10:19:25 +0100 (Tue, 16 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Fix a crash in LanguageConfigView with the debug build.

To workaround crbug.com/38266, implment TableModel as part of
LanguageConfigView, rather than a separate class.

TEST=manually
BUG=38266

Review URL: http://codereview.chromium.org/992004
------------------------------------------------------------------------
r41696 | phajdan.jr@chromium.org | 2010-03-16 09:39:54 +0100 (Tue, 16 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/dromaeo_benchmark_uitest.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc
   M /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/chrome/test/ui/sunspider_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/v8_benchmark_uitest.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

[GTTF] Make automation framework more solid by making sure that
important return values are not ignored.

The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC,
but that's enough since we have bots for all platforms.

Adding these warnings already detected some cases where a return value
was ignored. In some of them the test was trying to get the information
about success "some other way", in some it could sometimes confuse test
failure with test success.

TEST=ui_tests
BUG=none

Review URL: http://codereview.chromium.org/948002
------------------------------------------------------------------------
r41695 | eroman@chromium.org | 2010-03-16 08:53:10 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/passive_log_collector.cc
   M /trunk/src/chrome/browser/net/passive_log_collector.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc

Try to fix some regressions after landing 41689.
The changes to passive_log_collector.cc are a speculative fix for crash seen in dom_perf.

TBR=willchan

Review URL: http://codereview.chromium.org/969004
------------------------------------------------------------------------
r41693 | yusukes@chromium.org | 2010-03-16 08:39:14 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.cc
   A /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util.h
   A /trunk/src/chrome/browser/chromeos/status/language_menu_l10n_util_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Translate a string sent from IBus IME engines.

IBus IME engines send some strings written in English (e.g. IME names and IME property names) to its language bar module (i.e. Chrome). This change adds a function that converts the english string into a Chrome's resource ID, then converts the ID into a localized string, and returns it.

BUG=crosbug.com/1699
TEST=run the unittest

Review URL: http://codereview.chromium.org/948001
------------------------------------------------------------------------
r41691 | tony@chromium.org | 2010-03-16 08:24:49 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/app/gtk_signal.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Revert "Make DevTools open docked by default for chrome os."

This reverts commit r41641 because all the devtools interactive_ui_tests
are failing.

TBR=xiyuan

Review URL: http://codereview.chromium.org/1007004
------------------------------------------------------------------------
r41690 | tony@chromium.org | 2010-03-16 08:05:23 +0100 (Tue, 16 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/file_watcher_mac.cc
   M /trunk/src/chrome/browser/file_watcher_unittest.cc

Re-enable FileWatcher tests on mac, but mark them as flaky.

Review URL: http://codereview.chromium.org/1021002
------------------------------------------------------------------------
r41689 | eroman@chromium.org | 2010-03-16 08:03:53 +0100 (Tue, 16 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   A /trunk/src/chrome/browser/net/chrome_net_log.cc
   A /trunk/src/chrome/browser/net/chrome_net_log.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_master.cc
   A /trunk/src/chrome/browser/net/passive_log_collector.cc (from /trunk/src/net/url_request/request_tracker.h:41560)
   A /trunk/src/chrome/browser/net/passive_log_collector.h
   A /trunk/src/chrome/browser/net/passive_log_collector_unittest.cc (from /trunk/src/net/url_request/request_tracker_unittest.cc:41560)
   M /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   D /trunk/src/net/base/load_log.cc
   D /trunk/src/net/base/load_log.h
   D /trunk/src/net/base/load_log_event_type_list.h
   D /trunk/src/net/base/load_log_unittest.cc
   D /trunk/src/net/base/load_log_unittest.h
   D /trunk/src/net/base/load_log_util.cc
   D /trunk/src/net/base/load_log_util.h
   D /trunk/src/net/base/load_log_util_unittest.cc
   M /trunk/src/net/base/mapped_host_resolver.cc
   M /trunk/src/net/base/mapped_host_resolver.h
   M /trunk/src/net/base/mapped_host_resolver_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   A /trunk/src/net/base/net_log.cc (from /trunk/src/net/base/load_log.cc:40318)
   A /trunk/src/net/base/net_log.h (from /trunk/src/net/base/load_log.h:40318)
   A /trunk/src/net/base/net_log_event_type_list.h (from /trunk/src/net/base/load_log_event_type_list.h:40318)
   A /trunk/src/net/base/net_log_unittest.h (from /trunk/src/net/base/load_log_unittest.h:40318)
   A /trunk/src/net/base/net_log_util.cc (from /trunk/src/net/base/load_log_util.cc:40318)
   A /trunk/src/net/base/net_log_util.h (from /trunk/src/net/base/load_log_util.h:40318)
   A /trunk/src/net/base/net_log_util_unittest.cc (from /trunk/src/net/base/load_log_util_unittest.cc:40318)
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/ftp/ftp_transaction.h
   M /trunk/src/net/http/http_basic_stream.cc
   M /trunk/src/net/http/http_basic_stream.h
   M /trunk/src/net/http/http_cache_transaction.cc
   M /trunk/src/net/http/http_cache_transaction.h
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_stream_parser.cc
   M /trunk/src/net/http/http_stream_parser.h
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/init_proxy_resolver.cc
   M /trunk/src/net/proxy/init_proxy_resolver.h
   M /trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/mock_proxy_resolver.h
   M /trunk/src/net/proxy/proxy_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings.cc
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_mac.cc
   M /trunk/src/net/proxy/proxy_resolver_mac.h
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.h
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver.h
   M /trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks5_client_socket.cc
   M /trunk/src/net/socket/socks5_client_socket.h
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket.cc
   M /trunk/src/net/socket/socks_client_socket.h
   M /trunk/src/net/socket/socks_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_client_socket_win.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.h
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/socket/tcp_client_socket_win.h
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/socket_stream/socket_stream.h
   M /trunk/src/net/socket_stream/socket_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction.cc
   M /trunk/src/net/spdy/spdy_network_transaction.h
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_stream.cc
   M /trunk/src/net/spdy/spdy_stream.h
   D /trunk/src/net/url_request/request_tracker.h
   D /trunk/src/net/url_request/request_tracker_unittest.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc

Generalize the net module's LoadLog facility from a passive container, to an event stream (NetLog).

This makes it possible to associate a single NetLog with a URLRequestContext, and then attach observers to that log to watch the stream of events.

This changelist attempts to do the most direct translation, so there will be subsequent iterations to clean up.

The user-visible behavior should remain unchanged.

BUG=37421

Review URL: http://codereview.chromium.org/848006
------------------------------------------------------------------------
r41687 | abarth@chromium.org | 2010-03-16 07:34:56 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/mime_sniffer.h
   M /trunk/src/net/base/mime_sniffer_unittest.cc

Increase the mime sniffer's limit for searching for binary looking bytes from
512 to 1024 bytes.

Contributed by tonyg@chromium.org

BUG=15314
TEST=net_unittests --gtest_filter=MimeSnifferTest.LooksBinary 

------------------------------------------------------------------------
r41683 | ajwong@chromium.org | 2010-03-16 06:45:33 +0100 (Tue, 16 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h

Reapply r41640.

Original patch by thiago.farina@gmail.com

Revision r41640 was reverted in r41676 because it looked like it might have been responsible for Interactive UI test failures in linux and windows.  However, reverting didn't fix, so I'm reapplying it.

Review URL: http://codereview.chromium.org/982004
------------------------------------------------------------------------
r41678 | jrg@chromium.org | 2010-03-16 06:03:02 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Quick and dirty bookmark folder/menu scrolling for Beta.
Intended as a temporary fix.

BUG=36225



Review URL: http://codereview.chromium.org/998004
------------------------------------------------------------------------
r41677 | jrg@chromium.org | 2010-03-16 05:53:10 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm

If no explicit parent node there is no need to watch out for it to be invalid.

BUG=38242
TEST=Right-click on bar (not button); pick "add folder".  Does not DCHECK in debug build.

Review URL: http://codereview.chromium.org/992002
------------------------------------------------------------------------
r41676 | ajwong@chromium.org | 2010-03-16 05:48:43 +0100 (Tue, 16 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h

Revert "Landing tfarina CL. " because it broke Interactive UI tests on Linux and Windows.

This reverts r41640.

Review URL: http://codereview.chromium.org/1037001
------------------------------------------------------------------------
r41667 | joi@chromium.org | 2010-03-16 03:18:43 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi.h
   M /trunk/src/chrome_frame/chrome_tab.idl

Adds an automation message to retrieve the list of enabled extensions, and CF bindings for it.

TEST=unit test to follow
BUG=none

Review URL: http://codereview.chromium.org/901002
------------------------------------------------------------------------
r41662 | ctguil@chromium.org | 2010-03-16 01:24:20 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/single_split_view.h

Provide Web Contents accessibility info.

BUG=36286
TEST=Verify accessibility info in AccExplorer32.exe. 

Review URL: http://codereview.chromium.org/652199
------------------------------------------------------------------------
r41661 | brg@chromium.com | 2010-03-16 01:19:34 +0100 (Tue, 16 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_idle_api.cc
   A /trunk/src/chrome/browser/extensions/extension_idle_api.h
   A /trunk/src/chrome/browser/extensions/extension_idle_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_idle_api_constants.h
   A /trunk/src/chrome/browser/extensions/extension_idle_apitest.cc
   A /trunk/src/chrome/browser/idle.h
   A /trunk/src/chrome/browser/idle_linux.cc
   A /trunk/src/chrome/browser/idle_mac.cc
   A /trunk/src/chrome/browser/idle_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/idle
   A /trunk/src/chrome/test/data/extensions/api_test/idle/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/idle/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/idle/test.js

Idle API for the extension system
Tests=ExtensionApiTest.Idle
Bug=one
Review URL: http://codereview.chromium.org/845005
------------------------------------------------------------------------
r41659 | arv@chromium.org | 2010-03-16 00:52:45 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/default_favicon.png

Bookmark manager: Image for default favicon.

BUG=None
TEST=None
TBR=feldstein@chromium.org

------------------------------------------------------------------------
r41658 | jhawkins@chromium.org | 2010-03-16 00:51:24 +0100 (Tue, 16 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/form_manager.h
   M /trunk/src/chrome/renderer/form_manager_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/form_data.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_unittest.cc

FormFieldValues -> FormData consolidation: Use webkit_glue::FormField to store field data in FormData instead of storing the field data separately in the struct.

BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/847002
------------------------------------------------------------------------
r41656 | arv@chromium.org | 2010-03-16 00:48:52 +0100 (Tue, 16 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Fix issue where search did not select the search tree item. This also fixes an issue with reloading after a search.

BUG=4890
TEST=Enter some search terms. Hitting enter should select the search tree item and show the search results. Noew, hit F5 to reload. The search term should be filled in and the search tree item should be selected and the search results should be shown.

Review URL: http://codereview.chromium.org/837011
------------------------------------------------------------------------
r41653 | dumi@chromium.org | 2010-03-16 00:19:30 +0100 (Tue, 16 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/storage/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/storage/tab.html

Fix ExtensionApiTest.Storage. openDatabase() always takes at least 4
parameters.

BUG=22006
TEST=none


Review URL: http://codereview.chromium.org/982003
------------------------------------------------------------------------
r41648 | thakis@chromium.org | 2010-03-15 23:34:30 +0100 (Mon, 15 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm

Mac: Fix close/min/zoom buttons highlighting on bookmark hover.

The default mouseEntered: implementation forwards to the next responder, and this ends up being the window. Cells don't usually forward this to their view (views only get this if they install tracking areas). So don't forward this to super.

TEST=mouse over a bookmark. Close button shouldn't highlight.
BUG=36814

Review URL: http://codereview.chromium.org/998003
------------------------------------------------------------------------
r41644 | andybons@chromium.org | 2010-03-15 23:06:45 +0100 (Mon, 15 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Add support for showing extensions in incognito mode, while fixing a bug where the Browser Actions container was displayed and sized in a popup window.

TEST=none.
BUG=38094
Review URL: http://codereview.chromium.org/1001001
------------------------------------------------------------------------
r41642 | mrossetti@chromium.org | 2010-03-15 22:58:24 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Have any open folder menu go away if the bookmark bar is hidden.

BUG=37912
TEST=Insure the bookmark bar is showing. Click on a folder in the bookmark bar such that the folder contents are shown in a folder menu. Press <cmd-shift-B> and insure that the folder menu is withdrawn as the bookmark bar is hidden.

Review URL: http://codereview.chromium.org/887004
------------------------------------------------------------------------
r41641 | xiyuan@chromium.org | 2010-03-15 22:57:03 +0100 (Mon, 15 Mar 2010) | 23 lines
Changed paths:
   M /trunk/src/app/gtk_signal.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Make DevTools open docked by default for chrome os.

- Change prefs::kDevToolsOpenDocked default to "true" for chrome os;
- Fix a problem on chrome os that DevTools occupies the whole client area.
  This is because BrowserView::Show is called before gtk size allocated
  event and thus divider offset is calculated wrongly to 0. The fix is
  to move the "restore split offset" logic to UpdateDevToolsForContents
  before we do contents_split_ layout for show up DevTools;
- Fix a problem that DevTools becomes invisible after undock then dock
  for linux toolkit_view/chromeos build. This is because
  browser/views/tab_contents/TabContentsViewGtk does not show/hide its
  contained TabContents like TabContentsViewWin. As mentioned in
  BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up
  gtk show/hide signal and notify the contained TabContents about the
  visibility change. After the fix, remove the manual ShowContents for
  DevTools in BrowserWindowGtk::UpdateDevToolsForContents.

<http://crosbug.com/333>

BUG=333
TEST=Verify that DevTools show up as docked by default.

Review URL: http://codereview.chromium.org/880003
------------------------------------------------------------------------
r41640 | ctguil@chromium.org | 2010-03-15 22:54:51 +0100 (Mon, 15 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h

Landing tfarina CL. 

Original patch by thiago.farina@gmail.com

See original review at:
http://codereview.chromium.org/820001/show

BUG=9616, 36281
TEST=point AccExplorer to the clear browsing data dialog, every control should be identified and should have the correct values. 

------------------------------------------------------------------------
r41639 | kuan@chromium.org | 2010-03-15 22:48:50 +0100 (Mon, 15 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h

2nd attempt at landing cl to implement enhancements for translate infobar
- cl was previously committed at r41510 but reverted at r41520 - grd changes broke the buildbot.
- so this cl will revert r41520.
- this cl is the original cl which has been lgtm'ed, so i just tbr this.

BUG=35553,36682
TEST=verify per bug reports.
TBR=jcampan
Review URL: http://codereview.chromium.org/980001
------------------------------------------------------------------------
r41630 | jcampan@chromium.org | 2010-03-15 22:03:13 +0100 (Mon, 15 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Making browser bubble notifies to its delegate whether it
lost focus to a child window.  This is used to prevent
closing browser/page action bubble when they lose focus
to a select popup or alert box.

BUG=37784
TEST=Start Chrome with extensions that have a page action
     and browser action that contains selects (combobox)
     and a way to show an alert box.  Verify that showing
     the select popup or the alert dialog does not cause
     the bubble to close.

Review URL: http://codereview.chromium.org/899002
------------------------------------------------------------------------
r41628 | skrul@chromium.org | 2010-03-15 22:00:35 +0100 (Mon, 15 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h

Implement SyncerThread::RequestPause and SyncerThread::RequestResume
Basic functionality with unit test.  More plumbing later :)

Review URL: http://codereview.chromium.org/847004
------------------------------------------------------------------------
r41625 | dhollowa@chromium.org | 2010-03-15 21:40:30 +0100 (Mon, 15 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   A /trunk/src/chrome/browser/autofill/phone_field_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill phone field unit tests.

Adds unit tests for AutoFill phone_field.cc/h.  Coverage for Ecml and heuristic based phone field matching.

BUG=none
TEST=PhoneFieldTest

Review URL: http://codereview.chromium.org/985002
------------------------------------------------------------------------
r41612 | gwilson@google.com | 2010-03-15 19:45:23 +0100 (Mon, 15 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

windows: Add UMA metrics for first-run bubble. 

So we will know which of the buttons the user clicked on. 

BUG=23643
TEST=none 

Patch from Thiago Farina <thiago.farina@gmail.com> 

TBR=ben
Review URL: http://codereview.chromium.org/975002
------------------------------------------------------------------------
r41610 | oshima@chromium.org | 2010-03-15 19:33:45 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h

Fixing method signatures.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/973002
------------------------------------------------------------------------
r41604 | glotov@google.com | 2010-03-15 19:04:01 +0100 (Mon, 15 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

BUG=35248
TEST=none

Review URL: http://codereview.chromium.org/899006
------------------------------------------------------------------------
r41591 | bulach@chromium.org | 2010-03-15 17:24:45 +0100 (Mon, 15 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/geolocation_dispatcher.cc
   M /trunk/src/chrome/renderer/geolocation_dispatcher.h

Adds host for Geolocation OnStartUpdating.
This change blocks https://bugs.webkit.org/show_bug.cgi?id=36012
A follow-up will:
+ Remove the overloaded method (once WebKit lands).
+ Actually use the host.

Review URL: http://codereview.chromium.org/848003
------------------------------------------------------------------------
r41590 | rohitrao@chromium.org | 2010-03-15 17:18:33 +0100 (Mon, 15 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac] Fix recursive drawing in DidPaintRect() to defer painting of the second invalid rect.

BUG=http://crbug.com/24779
TEST=See test case in bug.  Gmail should paint correctly when returning from fullscreen.
Review URL: http://codereview.chromium.org/335029
------------------------------------------------------------------------
r41589 | rohitrao@chromium.org | 2010-03-15 16:57:39 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm

[Mac] Do not lock bar visibility when the bookmark bar is detached.

BUG=37271,37433,37937
TEST=Go fullscreen on the NTP with the bookmark bar detached. Drag a bookmark around.  Overlay should not open.
TEST=Go fullscreen on the NTP with the bookmark bar detached. Open a bookmark folder.  Overlay should not open.
Review URL: http://codereview.chromium.org/881003
------------------------------------------------------------------------
r41587 | avayvod@google.com | 2010-03-15 16:17:29 +0100 (Mon, 15 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc

chromeos: remove some variables that are now not more necessary. 

BUG=37069
TEST=build works

Checking in patch from Thiago Farina <thiago.farina@gmail.com>, reviewed as:
http://codereview.chromium.org/945001/show

Review URL: http://codereview.chromium.org/970001
------------------------------------------------------------------------
r41583 | nkostylev@google.com | 2010-03-15 15:39:08 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Introduce full OOBE flow.

BUG=38192
TEST=Run chrome with --login-manager --login-screen=oobe should always trigger full OOBE flow (including network selection and update screens). Once user is signed in OOBE flow is not shown.

Review URL: http://codereview.chromium.org/964001
------------------------------------------------------------------------
r41581 | bulach@chromium.org | 2010-03-15 14:29:33 +0100 (Mon, 15 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/test/data/geolocation/simple.html

Uses MockLocationProvider on GeolocationBrowserTest.

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/661371
------------------------------------------------------------------------
r41580 | avayvod@google.com | 2010-03-15 13:39:13 +0100 (Mon, 15 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/views/controls/progress_bar.cc
   M /trunk/src/views/controls/progress_bar.h
   M /trunk/src/views/controls/progress_bar_unittest.cc

Switched progress bar to integral positions (from 0 to 100).

BUG=none
TEST=Launch with --login-manager --login-screen=update and verify that
progress bar shows increasing progress and login screen is shown at the
end.

Review URL: http://codereview.chromium.org/945003
------------------------------------------------------------------------
r41579 | jeremy@chromium.org | 2010-03-15 13:16:30 +0100 (Mon, 15 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   A /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/chrome_tests.gypi

Reland translate toolbar unit tests (originally landed as r41274, rolled back at r41284).

BUG=None
TEST=New unit tests, tree should stay green after this checkin.
Revert "Reland translate toolbar unit tests (originally landed as r41274, rolled back at r41284)."

Revert r41569 - 10.6 unit tests not passing.

Review URL: http://codereview.chromium.org/962001
------------------------------------------------------------------------
r41576 | danno@chromium.org | 2010-03-15 11:57:18 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm

Mac: fix enabling of remove button in cookie tree when there is a selection
Change in xib file disables "avoid empty selection" which leads to an item in the tree already being selected when the dialog opens.
BUG=http://crbug/38069
TEST=manual testing and existing flaky unit test FLAKY_RemoveButtonEnabled

Review URL: http://codereview.chromium.org/841004
------------------------------------------------------------------------
r41575 | dpolukhin@google.com | 2010-03-15 11:39:19 +0100 (Mon, 15 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Return back all changes in tab_contents_view_win.cc about root view layout.

BUG=37533,36280
TEST=In RTL layout drop down menues should be within Chrome window.


Review URL: http://codereview.chromium.org/782006
------------------------------------------------------------------------
r41574 | nkostylev@google.com | 2010-03-15 11:20:13 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc

Support RTL for compact navbar mode location bar.

BUG=35596
TEST=export LANGUAGE=he. Launch chrome and enable compact nav bar. Location bar should appear under tabs.

Review URL: http://codereview.chromium.org/594059
------------------------------------------------------------------------
r41570 | jeremy@chromium.org | 2010-03-15 10:50:51 +0100 (Mon, 15 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   D /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert "Reland translate toolbar unit tests (originally landed as r41274, rolled back at r41284)."

Revert r41569 - 10.6 unit tests not passing.

Review URL: http://codereview.chromium.org/959001
------------------------------------------------------------------------
r41569 | jeremy@chromium.org | 2010-03-15 10:38:43 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   A /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/chrome_tests.gypi

Reland translate toolbar unit tests (originally landed as r41274, rolled back at r41284).

BUG=None
TEST=New unit tests, tree should stay green after this checkin.

Review URL: http://codereview.chromium.org/938001
------------------------------------------------------------------------
r41568 | tony@chromium.org | 2010-03-15 10:09:04 +0100 (Mon, 15 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/file_watcher_unittest.cc

Disable FileWatcher unittests on mac, they're flakey.

TBR=phajdan.jr

Review URL: http://codereview.chromium.org/957001
------------------------------------------------------------------------
r41566 | satorux@chromium.org | 2010-03-15 08:55:14 +0100 (Mon, 15 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   A /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/language_hangul_config_view.h (from /trunk/src/chrome/browser/chromeos/options/language_config_view.h:41562)
   M /trunk/src/chrome/chrome_browser.gypi

Move Hangul IME settings to a separate dialog.

We'll have a separate dialog for each input method that has settings.

Review URL: http://codereview.chromium.org/889002
------------------------------------------------------------------------
r41561 | tony@chromium.org | 2010-03-15 04:39:50 +0100 (Mon, 15 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/user_style_sheet_watcher.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h

Connect UserStyleSheetWatcher to FileWatcher to have changes to
Default/User StyleSheets/Custom.css instantly change layout in
all your tabs.

BUG=2393

Review URL: http://codereview.chromium.org/799005
------------------------------------------------------------------------
r41560 | tony@chromium.org | 2010-03-15 02:57:07 +0100 (Mon, 15 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   D /trunk/src/base/file_watcher.h
   D /trunk/src/base/file_watcher_inotify.cc
   D /trunk/src/base/file_watcher_mac.cc
   D /trunk/src/base/file_watcher_stub.cc
   D /trunk/src/base/file_watcher_unittest.cc
   D /trunk/src/base/file_watcher_win.cc
   A /trunk/src/chrome/browser/file_watcher.h (from /trunk/src/base/file_watcher.h:41559)
   A /trunk/src/chrome/browser/file_watcher_inotify.cc (from /trunk/src/base/file_watcher_inotify.cc:41559)
   A /trunk/src/chrome/browser/file_watcher_mac.cc (from /trunk/src/base/file_watcher_mac.cc:41559)
   A /trunk/src/chrome/browser/file_watcher_stub.cc (from /trunk/src/base/file_watcher_stub.cc:41559)
   A /trunk/src/chrome/browser/file_watcher_unittest.cc (from /trunk/src/base/file_watcher_unittest.cc:41559)
   A /trunk/src/chrome/browser/file_watcher_win.cc (from /trunk/src/base/file_watcher_win.cc:41559)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Move FileWatcher from src/base/ to src/chrome/browser/ and switch
it from using MessageLoop to post tasks to using
ChromeThread::PostTask, which is safer.

Review URL: http://codereview.chromium.org/864001
------------------------------------------------------------------------
r41559 | ben@chromium.org | 2010-03-15 00:30:59 +0100 (Mon, 15 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/animation.cc
   M /trunk/src/app/clipboard/clipboard.cc
   M /trunk/src/app/clipboard/clipboard_linux.cc
   M /trunk/src/app/clipboard/clipboard_mac.mm
   M /trunk/src/app/clipboard/clipboard_unittest.cc
   M /trunk/src/app/clipboard/clipboard_win.cc
   M /trunk/src/app/clipboard/scoped_clipboard_writer.cc
   M /trunk/src/app/gfx/blit.cc
   M /trunk/src/app/gfx/blit.h
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/canvas_mac.mm
   M /trunk/src/app/gfx/canvas_win.cc
   M /trunk/src/app/gfx/font_util.h
   M /trunk/src/app/gfx/gdi_util.h
   M /trunk/src/app/gfx/gtk_native_view_id_manager.cc
   M /trunk/src/app/gfx/gtk_util.cc
   M /trunk/src/app/gfx/native_theme_win.cc
   M /trunk/src/app/gfx/native_theme_win.h
   M /trunk/src/app/gfx/skia_util.cc
   M /trunk/src/app/os_exchange_data_provider_gtk.h
   M /trunk/src/app/win/window_impl.h
   M /trunk/src/app/win_util.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   D /trunk/src/base/gfx/point.cc
   D /trunk/src/base/gfx/rect.cc
   D /trunk/src/base/gfx/rect_unittest.cc
   D /trunk/src/base/gfx/size.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/browser/cocoa/base_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_mac.mm
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/find_notification_details.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_started_animation_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/gtk/tabstrip_origin_provider.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/icon_loader_win.cc
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/notifications/balloon.cc
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc
   M /trunk/src/chrome/browser/ntp_background_util.cc
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/browser/pref_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_proxy.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/video_layer.h
   M /trunk/src/chrome/browser/renderer_host/video_layer_proxy.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.h
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/common/accelerated_surface_mac.cc
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/transport_dib_linux.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx_context.h
   M /trunk/src/chrome/gpu/gpu_backing_store_win.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/media/ipc_video_renderer.h
   M /trunk/src/chrome/renderer/mock_render_process.cc
   M /trunk/src/chrome/renderer/paint_aggregator.h
   M /trunk/src/chrome/renderer/pepper_devices.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/ui/fast_shutdown_uitest.cc
   M /trunk/src/chrome/test/ui/history_uitest.cc
   M /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/gfx/gfx.gyp
   M /trunk/src/gfx/icon_util.cc
   M /trunk/src/gfx/icon_util_unittest.cc
   A /trunk/src/gfx/point.cc (from /trunk/src/base/gfx/point.cc:41521)
   A /trunk/src/gfx/point.h (from /trunk/src/base/gfx/point.h:41558)
   A /trunk/src/gfx/rect.cc (from /trunk/src/base/gfx/rect.cc:41521)
   A /trunk/src/gfx/rect.h (from /trunk/src/base/gfx/rect.h:41558)
   A /trunk/src/gfx/rect_unittest.cc (from /trunk/src/base/gfx/rect_unittest.cc:41521)
   A /trunk/src/gfx/size.cc (from /trunk/src/base/gfx/size.cc:41521)
   A /trunk/src/gfx/size.h (from /trunk/src/base/gfx/size.h:41558)
   M /trunk/src/printing/DEPS
   M /trunk/src/printing/emf_win.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/printing/image.h
   M /trunk/src/printing/page_setup.h
   M /trunk/src/printing/pdf_metafile_mac.cc
   M /trunk/src/printing/pdf_metafile_mac_unittest.cc
   M /trunk/src/printing/print_settings.h
   M /trunk/src/printing/printed_page.h
   M /trunk/src/tools/memory_watcher/DEPS
   M /trunk/src/tools/memory_watcher/hotkey.h
   M /trunk/src/views/animation/bounds_animator.h
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/controls/table/table_view2.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils_gtk.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/screen.h
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/aero_tooltip_manager.cc
   M /trunk/src/views/widget/drop_target_gtk.cc
   M /trunk/src/views/widget/drop_target_win.cc
   M /trunk/src/views/widget/tooltip_manager_win.h
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/webkit/DEPS
   M /trunk/src/webkit/glue/dom_operations.h
   M /trunk/src/webkit/glue/image_decoder.h
   M /trunk/src/webkit/glue/image_resource_fetcher.cc
   M /trunk/src/webkit/glue/media/video_renderer_impl.h
   M /trunk/src/webkit/glue/plugins/plugin_instance.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/mac/accelerated_surface_stub.cc
   M /trunk/src/webkit/tools/test_shell/mac/test_shell_webview.mm
   M /trunk/src/webkit/tools/test_shell/mac/webview_host.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_win.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Move base/gfx contents to gfx/

TBR=darin
BUG=none
TEST=none

------------------------------------------------------------------------
r41551 | mirandac@chromium.org | 2010-03-14 19:08:06 +0100 (Sun, 14 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Reenable first run dialog on Mac by commenting out MasterPreferences reading stuff, which is not yet available for OS X.  While this is not commented out, first run dialog will *always* be bypassed.

BUG= none
TEST= you can get the 1st run dialog on Mac again.

Review URL: http://codereview.chromium.org/929001
------------------------------------------------------------------------
r41539 | jhawkins@chromium.org | 2010-03-14 06:34:18 +0100 (Sun, 14 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_gtk.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/gtk/translate_infobars.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/combobox/native_combobox_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/table/native_table_gtk.cc
   M /trunk/src/views/controls/table/table_view_unittest.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/widget/drop_target_gtk.cc
   M /trunk/src/views/widget/tooltip_manager_gtk.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/window/window_gtk.cc

chromeos: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/851010
------------------------------------------------------------------------
r41538 | abarth@chromium.org | 2010-03-14 01:16:15 +0100 (Sun, 14 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/transport_security_persister.cc
   M /trunk/src/chrome/browser/transport_security_persister.h
   M /trunk/src/net/base/transport_security_state.cc
   M /trunk/src/net/base/transport_security_state.h

Remove locks from StrictTransportSecurityState.

These locks can cause the IO thread to block on the FILE thread writing to
disk, which is bad news bears.

BUG=21518
TEST=No behavior change.

Review URL: http://codereview.chromium.org/904005
------------------------------------------------------------------------
r41534 | rsesek@chromium.org | 2010-03-13 19:46:42 +0100 (Sat, 13 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm

Copyright change to tickle the bots.
------------------------------------------------------------------------
r41533 | rsesek@chromium.org | 2010-03-13 18:58:22 +0100 (Sat, 13 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm

[Mac] Show the contextual menu for page actions on Ctrl+Click.

BUG=32072
TEST=Ctrl+Click on a page action opens the context menu. A real right-click still does the same.

Review URL: http://codereview.chromium.org/894004
------------------------------------------------------------------------
r41528 | ben@chromium.org | 2010-03-13 09:26:32 +0100 (Sat, 13 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/app_base.gypi
   D /trunk/src/app/gfx/icon_util.cc
   D /trunk/src/app/gfx/icon_util.h
   D /trunk/src/app/gfx/icon_util_unittest.cc
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/aeropeek_manager.cc
   M /trunk/src/chrome/browser/icon_loader_win.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/gfx
   A /trunk/src/gfx/DEPS
   A /trunk/src/gfx/empty.cc
   A /trunk/src/gfx/gfx.gyp
   A /trunk/src/gfx/icon_util.cc (from /trunk/src/app/gfx/icon_util.cc:41521)
   A /trunk/src/gfx/icon_util.h (from /trunk/src/app/gfx/icon_util.h:41521)
   A /trunk/src/gfx/icon_util_unittest.cc (from /trunk/src/app/gfx/icon_util_unittest.cc:41521)
   A /trunk/src/gfx/run_all_unittests.cc
   M /trunk/src/views/DEPS
   M /trunk/src/views/controls/table/native_table_win.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/test_page.html

Create a toplevel gfx/ dir and seed it with icon_util.

TBR=darin
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/915002
------------------------------------------------------------------------
r41520 | ajwong@chromium.org | 2010-03-13 02:45:34 +0100 (Sat, 13 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h

Revert "implement improvements for translate infobar"

This reverts commit r41510.

Review URL: http://codereview.chromium.org/854012
------------------------------------------------------------------------
r41518 | thestig@chromium.org | 2010-03-13 02:30:47 +0100 (Sat, 13 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

This should stop the random hangs due to chrome/app/chrome_dll_main.cc(616)] Check failed: PathService::Override(chrome::DIR_USER_DATA, user_data_dir)??

Revert 41369 - Linux: Pass userdatadir to the Zygote.

BUG=none
TEST=On Linux, "chrome enablelogging userdatadir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME.
Review URL: http://codereview.chromium.org/885003

TBR=thestig@chromium.org

Review URL: http://codereview.chromium.org/848009
------------------------------------------------------------------------
r41516 | stuartmorgan@chromium.org | 2010-03-13 02:16:16 +0100 (Sat, 13 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix Mac window frame coordinate conversion on multiple monitor setups

The same bug exists in our event coordinate conversion code in WebInputEventFactory, so this is half of a two-sided patch; WebKit side is:
https://bugs.webkit.org/show_bug.cgi?id=35950

BUG=36621
TEST=In conjuction with the WebKit patch, mouseovers in Carbon plugins will work when the plugin is on a non-primary monitor with a different height than the primary monitor.

Review URL: http://codereview.chromium.org/751002
------------------------------------------------------------------------
r41512 | chocobo@chromium.org | 2010-03-13 01:29:33 +0100 (Sat, 13 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc

Implement connect to hidden networks. And show passphrase in wifi config dialog.
Review URL: http://codereview.chromium.org/913003
------------------------------------------------------------------------
r41510 | kuan@chromium.org | 2010-03-13 01:24:30 +0100 (Sat, 13 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h

implement improvements for translate infobar
- add "Show original" button to revert translated page (backend is currently a TODO for jay)
- modify state machine of translate infobar to show "Translating..." when subsequent translations are triggered for a page i.e. when the user modifies the source or target languages
- remove obsolete strings (introduced when privacy dialog was thought to be needed)

BUG=35553,36682
TEST=verify per bug reports.
Review URL: http://codereview.chromium.org/845006
------------------------------------------------------------------------
r41509 | kinuko@chromium.org | 2010-03-13 01:22:53 +0100 (Sat, 13 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc

Don't fail when default download folder doesn't exist

BUG=37836
TEST=as described in the bug

Review URL: http://codereview.chromium.org/871001
------------------------------------------------------------------------
r41508 | erg@google.com | 2010-03-13 00:59:24 +0100 (Sat, 13 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.h

GTK: More transition to CHROMEGTK macros.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/840005
------------------------------------------------------------------------
r41507 | jcampan@chromium.org | 2010-03-13 00:54:18 +0100 (Sat, 13 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/app_launcher.cc

Making the location by visible in the app launcher
BUG=None
TEST=Open the app launcher, the location bar should show.

Review URL: http://codereview.chromium.org/873004
------------------------------------------------------------------------
r41506 | akalin@chromium.org | 2010-03-13 00:49:22 +0100 (Sat, 13 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added switch to invalidate the sync xmpp auth token for testing.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/883003
------------------------------------------------------------------------
r41505 | denisromanov@google.com | 2010-03-13 00:19:44 +0100 (Sat, 13 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/update_view.cc
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Added progress bar to the update screen.
Corrected login wizard screens transitions logic.

BUG=35249
TEST=Run out/Debug/chrome --login-manager --login-screen=update. Progress bar should be visible and login screen should appear after it comes to 100%.

Review URL: http://codereview.chromium.org/853006
------------------------------------------------------------------------
r41503 | aa@chromium.org | 2010-03-13 00:09:16 +0100 (Sat, 13 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Mechanical refactor of CrxInstaller signatures. This will make
it easier to add additional configuration features to
CrxInstaller.

Review URL: http://codereview.chromium.org/875003
------------------------------------------------------------------------
r41499 | thestig@chromium.org | 2010-03-12 23:36:28 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc

Linux: Fix official build breakage from r41451.

BUG=none
TEST=Linux official builds succeed.
Review URL: http://codereview.chromium.org/842008
------------------------------------------------------------------------
r41494 | sky@chromium.org | 2010-03-12 22:56:17 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/login_default.png
   A /trunk/src/chrome/app/theme/login_other.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/background_view.cc
   A /trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc
   A /trunk/src/chrome/browser/chromeos/login/existing_user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   A /trunk/src/chrome/browser/chromeos/login/user_controller.cc
   A /trunk/src/chrome/browser/chromeos/login/user_controller.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h
   M /trunk/src/chrome/browser/chromeos/login/utils.cc
   M /trunk/src/chrome/browser/chromeos/login/utils.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds the remaining chunks for the login panels. It's currently not the
defualt and hidden behind a switch.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/906001
------------------------------------------------------------------------
r41492 | estade@chromium.org | 2010-03-12 22:40:49 +0100 (Fri, 12 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h

Re-apply r41458 | estade@chromium.org | 2010-03-12 11:28:50 -0800 (Fri, 12 Mar 2010) | 8 lines

Fix the rest of the gtk/options directory to use new callback macros.

Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D:

BUG=None
TEST=compile

with fix for unit test

Review URL: http://codereview.chromium.org/846005
------------------------------------------------------------------------
r41490 | aarya@google.com | 2010-03-12 22:33:10 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc

Patch makes sure that only text fields are saved in Auto-fill "Web Data" file on disk. This prevent passwords from being saved on disk without user content as part of autofill history.

BUG=36553
TEST=Login on a web site with password field (no autocomplete=off). Check "Web Data" file on disk to see password saved without user content.
Review URL: http://codereview.chromium.org/855005
------------------------------------------------------------------------
r41487 | rogerta@chromium.org | 2010-03-12 22:19:34 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_metrics_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_metrics_module.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/metrics/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/metrics/test.js
   M /trunk/src/chrome_frame/chrome_launcher.cc

Move metrics api to the experimental name space.

BUG=0
TEST=n/a

Review URL: http://codereview.chromium.org/899003
------------------------------------------------------------------------
r41484 | oshima@chromium.org | 2010-03-12 22:04:39 +0100 (Fri, 12 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.h
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Autoslide/hide notifications after timeout.
 * Introduced panel's state to manage which notifications will be shown.'
 * Added "OnPanelStateChanged" to PanelController::Delegate method to monitor the panel's state.
 * Removed unnecessary SetSize in BalloonViewImpl. The size is set in BalloonViewImpl::Layout.

BUG=33306
TEST=This requires chromeos's wm and system notification to test (which does not exit yet).
     None for now but I am writing unittest now.

Review URL: http://codereview.chromium.org/874004
------------------------------------------------------------------------
r41480 | thakis@chromium.org | 2010-03-12 21:58:05 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Mac: Clicking bookmark bar should dismiss open folder menus as well.

BUG=36487
TEST=Open bookmark folder. Clicking both the bookmark bar and its opening folder should dismiss it.

Review URL: http://codereview.chromium.org/857009
------------------------------------------------------------------------
r41479 | skerner@chromium.org | 2010-03-12 21:53:33 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h

If fetching a bitmap from the backing store fails, try to get an image from the renderer.

BUG=35204
TEST=Manual testing with screenshot extension.

Review URL: http://codereview.chromium.org/885006
------------------------------------------------------------------------
r41478 | finnur@chromium.org | 2010-03-12 21:53:24 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Remove the feed sniffing testing part of the RSS extension.

I suspect it is the cause of the flakiness.

BUG=37109
TEST=Watch the bots to see if it is still flaky.

Review URL: http://codereview.chromium.org/870008
------------------------------------------------------------------------
r41475 | skerner@chromium.org | 2010-03-12 21:42:26 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Add CanAccuratelyCopyFromBackingStore() to the backing store class.

Use the new method to avoid using CopyFromBackingStore() for screen captures when CopyFromBackingStore() will not give a flawless copy.

BUG=35204
TEST=Manual testing with example screenshot extension.

Review URL: http://codereview.chromium.org/830001
------------------------------------------------------------------------
r41466 | sky@chromium.org | 2010-03-12 21:31:13 +0100 (Fri, 12 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc

Lands http://codereview.chromium.org/669132 for Thiago:

windows: Add UMA metrics for each time that the bookmarks toolbar menu
button it's clicked.

Since it isn't fully supported we need this to know how many people
are using it.

BUG=36191
TEST=none

Review URL: http://codereview.chromium.org/885005
------------------------------------------------------------------------
r41465 | estade@chromium.org | 2010-03-12 21:01:47 +0100 (Fri, 12 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h

Revert: r41458 | estade@chromium.org | 2010-03-12 11:28:50 -0800 (Fri, 12 Mar 2010) | 8 lines

Fix the rest of the gtk/options directory to use new callback macros.

Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D:

BUG=None
TEST=compile

it's breaking unit tests


Review URL: http://codereview.chromium.org/886005
------------------------------------------------------------------------
r41464 | willchan@chromium.org | 2010-03-12 20:57:16 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm
   M /trunk/src/net/base/network_change_notifier_mac.h

Revert r41459:
"Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time."
Apparently NetworkChangeNotifierMac's observers are still getting leaked in ExtensionApiTest.ShowPageActionPopup.

Review URL: http://codereview.chromium.org/871007
------------------------------------------------------------------------
r41462 | arv@chromium.org | 2010-03-12 20:37:52 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/favicon_service.cc
   M /trunk/src/chrome/browser/favicon_service.h

Show favicons for extensions.

This uses the 16x16 icon as defined in the manifest for extension pages.

BUG=36514
TEST=Open the new bookmark manager. It should now show its favicon.

Review URL: http://codereview.chromium.org/650185
------------------------------------------------------------------------
r41461 | arv@chromium.org | 2010-03-12 20:36:22 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Remove find as you type

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/894002
------------------------------------------------------------------------
r41459 | willchan@chromium.org | 2010-03-12 20:30:00 +0100 (Fri, 12 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm
   M /trunk/src/net/base/network_change_notifier_mac.h

Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time.

Review URL: http://codereview.chromium.org/870003
------------------------------------------------------------------------
r41458 | estade@chromium.org | 2010-03-12 20:28:50 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h

Fix the rest of the gtk/options directory to use new callback macros.

Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D:

BUG=None
TEST=compile

Review URL: http://codereview.chromium.org/857006
------------------------------------------------------------------------
r41452 | avi@chromium.org | 2010-03-12 19:34:06 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Fix prefs dialog to size properly under RI.

BUG=19476
TEST=prefs dialog is usable under RI (scrolling Under the Hood is wonky; don't think we can fix that)

Review URL: http://codereview.chromium.org/915001
------------------------------------------------------------------------
r41451 | thestig@chromium.org | 2010-03-12 19:32:10 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/child_process_host.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc

Use env_vars::kHeadless instead of hard coded strings.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/876002
------------------------------------------------------------------------
r41450 | jrg@chromium.org | 2010-03-12 19:27:53 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   A /trunk/src/chrome/test/functional/bookmarks.py
   A /trunk/src/chrome/test/functional/pyauto_test_utils.py
   A /trunk/src/chrome/test/pyautolib/bookmark_model.py
   M /trunk/src/chrome/test/pyautolib/pyauto.py
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.i
   M /trunk/src/ipc/ipc_message_macros.h

Add pyauto hooks for bookmarks.
Get model, add/remove, add folder, reparent, change title/url.

BUG=34492

Review URL: http://codereview.chromium.org/792003
------------------------------------------------------------------------
r41448 | mpcomplete@chromium.org | 2010-03-12 19:12:44 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Fix a bug with persistent unpacked extensions where we would not pick up
manifest changes on browser restart.

BUG=24850

Review URL: http://codereview.chromium.org/789007
------------------------------------------------------------------------
r41446 | mpcomplete@chromium.org | 2010-03-12 18:57:09 +0100 (Fri, 12 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/test/data/extensions/api_test/incognito/apis/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/incognito/apis/manifest.json

Add chrome.extension.inIncognitoTab for content scripts.

Review URL: http://codereview.chromium.org/822008
------------------------------------------------------------------------
r41445 | glotov@google.com | 2010-03-12 18:50:01 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc

Implemented saving of the chosen language for the next boot.

BUG=35248
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-screen=nework

Review URL: http://codereview.chromium.org/912001
------------------------------------------------------------------------
r41443 | dhg@chromium.org | 2010-03-12 18:40:13 +0100 (Fri, 12 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   M /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h

Adding a hook to be a sink for media content in chrome.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/903001
------------------------------------------------------------------------
r41442 | phajdan.jr@chromium.org | 2010-03-12 18:34:27 +0100 (Fri, 12 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc

Revert "Mark BrowserActionsContainerTest.Basic as flaky."

Finnur fixed the test a few days ago.

TBR=finnur
TEST=none
BUG=38065

Review URL: http://codereview.chromium.org/854009
------------------------------------------------------------------------
r41441 | erikkay@chromium.org | 2010-03-12 18:28:56 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Support app tabs as a launch point for apps.  Also, move the logic for launching into Browser for easier access by the launcher.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/668245
------------------------------------------------------------------------
r41440 | phajdan.jr@chromium.org | 2010-03-12 18:20:41 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc

Mark BrowserActionsContainerTest.Basic as flaky.

TBR=finnur
TEST=none
BUG=38065

Review URL: http://codereview.chromium.org/897004
------------------------------------------------------------------------
r41439 | skrul@chromium.org | 2010-03-12 18:19:59 +0100 (Fri, 12 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Additional unit tests for autofill
Unit tests for the autofill change processor.  This includes changes from the  chrome side -- a user adding, updating, and removing an autofill entry.  Also tests handing of errors during change processing.  Includes a bug fix for autofill remove.

Review URL: http://codereview.chromium.org/837005
------------------------------------------------------------------------
r41438 | thakis@chromium.org | 2010-03-12 18:16:27 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Mac: Clicking a bookmark bar folder should close its menu if it's open.

The code for that was already there, but it didn't fire, because clicking on a bookmark button dismissed the bookmark folder controller.

BUG=36487
TEST=click bookmark bar folder twice. first click should open menu, second should close.

Review URL: http://codereview.chromium.org/870006
------------------------------------------------------------------------
r41437 | avi@chromium.org | 2010-03-12 17:57:16 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Fix resolution independence in theming. Improve from "pretty broken" to "broken but pretty".

BUG=http://crbug.com/19476
TEST=run in RI and see themes. Still broken a bit but a lot better.

Review URL: http://codereview.chromium.org/879003
------------------------------------------------------------------------
r41435 | pinkerton@chromium.org | 2010-03-12 17:45:33 +0100 (Fri, 12 Mar 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.cc (from /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_mac.cc:41430)
   A /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_mac.h (from /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_mac.h:41430)
   A /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc (from /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_manager_mac.cc:41430)
   A /trunk/src/chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h (from /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_manager_mac.h:41430)
   D /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_mac.cc
   D /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_mac.h
   D /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_manager_mac.cc
   D /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_manager_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h

Rename uses of GPUPlugin in class names and IPC to AcceleratedSurface.
BUG=none
TEST=Purely cleanup, no functional changes.
Review URL: http://codereview.chromium.org/855003
------------------------------------------------------------------------
r41431 | viettrungluu@chromium.org | 2010-03-12 15:46:38 +0100 (Fri, 12 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm

Mac: disable minimize in fullscreen mode.

If it's set (in System Prefs) to minimize windows on double-click (on the title
bar), double-clicking on the blank area of the floating bar will beep.

BUG=37972
TEST=Make sure Minimize is disabled in the Window menu, Cmd-M shouldn't work, and double-clicking on the blank area of the floating bar shouldn't minimize (it should beep if System Prefs is set as described above).

Review URL: http://codereview.chromium.org/862007
------------------------------------------------------------------------
r41430 | joth@chromium.org | 2010-03-12 15:00:00 +0100 (Fri, 12 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   M /trunk/src/chrome/chrome_browser.gypi

First cut at implementing wifi bindigns for linux, using glib-dbus to NetworkManager

NOTE: Adds a new build dependency on dbus-glib, on ubuntu you can meet this with:
$ sudo aptitude install dbus-glib-1-dev 


BUG=http://crbug.com/37199
TEST=use browser with --enable-geolocation

Review URL: http://codereview.chromium.org/787003
------------------------------------------------------------------------
r41428 | phajdan.jr@chromium.org | 2010-03-12 12:15:13 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_unittest.cc

Fix one other build failure. Only include linux_util.h on Linux.

TBR=evan
BUG=30785
TEST=none

Review URL: http://codereview.chromium.org/840004
------------------------------------------------------------------------
r41427 | phajdan.jr@chromium.org | 2010-03-12 12:03:24 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/web_applications/web_app.cc

Fix build. linux_util.h caused a weird compile error when #included on Windows.

TBR=evan
BUG=30785
TEST=none

Review URL: http://codereview.chromium.org/874005
------------------------------------------------------------------------
r41423 | phajdan.jr@chromium.org | 2010-03-12 11:29:04 +0100 (Fri, 12 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc

Add missing tests for Linux desktop shortcuts logic.

This also makes the code use EnvironmentVariableGetter
instead of calling getenv directly because we need the control
in tests.

This is a follow-up after http://codereview.chromium.org/607001

TEST=ShellIntegrationTest.GetDesktopShortcutTemplate
BUG=30785

Review URL: http://codereview.chromium.org/798002
------------------------------------------------------------------------
r41422 | aa@chromium.org | 2010-03-12 10:10:29 +0100 (Fri, 12 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Add "origin" to the app object in the extension manifest.

Review URL: http://codereview.chromium.org/897002
------------------------------------------------------------------------
r41419 | thakis@chromium.org | 2010-03-12 09:04:29 +0100 (Fri, 12 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Fix mac unit tests

Review URL: http://codereview.chromium.org/884003
------------------------------------------------------------------------
r41418 | yusukes@chromium.org | 2010-03-12 09:00:27 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Remove "(IME)" and "(Layout)" strings from the language status menu.
I think we no longer need these debug print strings.

BUG=none
TEST=start chrome for chromium, click the language button, check if an "US" entry.

Review URL: http://codereview.chromium.org/888004
------------------------------------------------------------------------
r41413 | viettrungluu@chromium.org | 2010-03-12 08:28:17 +0100 (Fri, 12 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Mac: move should-double-click-to-minimize code into mac_util.

Also make the fullscreen code do the right thing in theory, even though it
doesn't work and I'll probably shortly remove it.

BUG=none
TEST=Double-clicking on the tab strip should or should not minimize the window according to the system prefs setting; click in the area beside the tabs.

Review URL: http://codereview.chromium.org/859004
------------------------------------------------------------------------
r41411 | jhawkins@chromium.org | 2010-03-12 08:25:31 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/name_field.cc

Fix form heuristic for registration.crgevents.com.  Match on 'mi' anywhere in the field name.  It's safe to assume that if we match both the first and last name, it's safe to match mi anywhere in the field name.

BUG=37990
TEST=none
Review URL: http://codereview.chromium.org/850005
------------------------------------------------------------------------
r41410 | dhollowa@chromium.org | 2010-03-12 08:23:41 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/name_field.cc

AutoFill form filling on myspace.com

Field matching for "fullname" field on http://signups.myspace.com/index.cfm?fuseaction=signup.  Extends the full name matching to succeed when text field matches "fullname" string.

BUG=37990
TEST=Manual steps as described in bug using http://signups.myspace.com/index.cfm?fuseaction=signup as test form.

Review URL: http://codereview.chromium.org/904003
------------------------------------------------------------------------
r41409 | thakis@chromium.org | 2010-03-12 07:57:52 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm

Mac: Improve bookmark bar menus.

Make them a bit smaller, and make them stay on-screen horizontally (like normal menus)

BUG=36487
TEST=open menu while its folder is close to the screen edge.

Review URL: http://codereview.chromium.org/857007
------------------------------------------------------------------------
r41408 | danno@chromium.org | 2010-03-12 07:54:09 +0100 (Fri, 12 Mar 2010) | 13 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/CookieDetailsView.xib
   A /trunk/src/chrome/app/nibs/CookiePrompt.xib
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   A /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.h
   A /trunk/src/chrome/browser/cocoa/cookie_details_view_controller.mm
   A /trunk/src/chrome/browser/cocoa/cookie_details_view_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.h
   A /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/cookie_prompt_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.h
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/js_modal_dialog.h
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] augment modal cookie prompt on mac to include details pane

Added two new xibs. The first is a cookie info view that is shared between the tree that shows browser data and the cookie modal prompt to block accepting cookies. The second is a window to replace the NSAlert modal dialog for the cookie prompt. Modified cookie tree code and added cookie prompt code to use new xibs.

Changed "hidden" handling of cookie detail view to use bindings rather than explicit code.

TODOs for http://crbug.com/36948 not in this CL:
- changing the expiration for cookies isn't implemented

TEST=manually testing of modal cookie prompt, new unit tests
BUG=http://crbug.com/36948

Review URL: http://codereview.chromium.org/669127
------------------------------------------------------------------------
r41403 | jhawkins@chromium.org | 2010-03-12 06:57:53 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Reset the AutoFillManager's cache of forms when the main page is loaded, not when forms are sent to be stored.

BUG=37990
TEST=Form at ebay.com; in bug.
Review URL: http://codereview.chromium.org/906002
------------------------------------------------------------------------
r41402 | yusukes@chromium.org | 2010-03-12 06:55:59 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Move a hard-coded string to grd file and use l10n_util to get it.

Patch from Yasuhiro Matsuda <mazda@chromium.org>
Original review: http://codereview.chromium.org/690002

BUG=None
TEST=works as before

------------------------------------------------------------------------
r41401 | ben@chromium.org | 2010-03-12 06:42:26 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/win_util.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/app/win_util_unittest.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc

Remove some unnecessary dependencies on net from app/win_util and app/resource_bundle.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/858006
------------------------------------------------------------------------
r41400 | sanjeevr@chromium.org | 2010-03-12 06:29:07 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/printer_query.cc
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/printing/emf_win.cc
   M /trunk/src/printing/print_settings.cc
   M /trunk/src/printing/print_settings.h
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printing_context.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

Changes made to the printing logic to allow plugins to participate in the browser's print workflow. These changes mainly involve allowing the plugin to specify
whether it wants the browser to use overlays and also changes to the EMF code on Windows to decompress JPEGs/PNGs in the metafile.
The related webkit change is https://bugs.webkit.org/show_bug.cgi?id=35550
BUG=None
TEST=Test printing with new Pepper plugins that support custom printing.

Review URL: http://codereview.chromium.org/745001
------------------------------------------------------------------------
r41397 | dhollowa@chromium.org | 2010-03-12 06:16:29 +0100 (Fri, 12 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc

AutoFill form name matching.

This fixes first name and last name field matching for AutoFill when the form identifies first name and last name using "bill.first" and "bill.last" as seen in the sample8.html form.

BUG=37990
TEST=FormStructureTest.HeuristicsSample8


Review URL: http://codereview.chromium.org/900003
------------------------------------------------------------------------
r41396 | jrg@chromium.org | 2010-03-12 06:13:20 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Same as http://codereview.chromium.org/836004 but without extra crap falling in.
BUG=34522
TEST=see bug; it's quite clear.

TBR=mrossetti@chromium.org

Review URL: http://codereview.chromium.org/902004
------------------------------------------------------------------------
r41395 | jrg@chromium.org | 2010-03-12 06:09:28 +0100 (Fri, 12 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Revert 41392 - Cancel drag if the bookmark model changes.

When we rebuild the bookmark bar (e.g. something changed), clear the
dragging pasteboard to avoid stale pointers.

BUG=34522
TEST=see bug; it's quite clear.

Review URL: http://codereview.chromium.org/836004

TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/904002
------------------------------------------------------------------------
r41392 | jrg@chromium.org | 2010-03-12 06:01:49 +0100 (Fri, 12 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Cancel drag if the bookmark model changes.

When we rebuild the bookmark bar (e.g. something changed), clear the
dragging pasteboard to avoid stale pointers.

BUG=34522
TEST=see bug; it's quite clear.

Review URL: http://codereview.chromium.org/836004
------------------------------------------------------------------------
r41387 | jrg@chromium.org | 2010-03-12 04:12:49 +0100 (Fri, 12 Mar 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm

Bookmark bar menu/folder button text is left-aligned, not centered.
Bookmark bar menu/folder maximum window width is now 1000, not 150.

High cosmetic impact.

BUG=36487, 17608

TEST=\
1) Add bookmarks on the bar with small (e.g. 'x') and big titles.
Make sure all looks OK (e.g. small ones are small.)
2) Add bookmarks in a folder.
Make sure text is left aligned on the menus.
3) Add bookmarks in a folder with long names (e.g. 100 characters).
Make sure folder/menus are now much wider.
4) Add bookmarks in a folder with mega long names (e.g. 4000 characters).
Make sure menus have a maximum size of ~1000 pixes (no need to be exact but 'no limit' is fail).
5) In a folder, add a subfolder named 'x' and a bookmark with a REAL long name.
Make sure the "button" (menu item) is the full width of the menu.

Review URL: http://codereview.chromium.org/842005
------------------------------------------------------------------------
r41385 | arv@chromium.org | 2010-03-12 03:56:20 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Bookmark manager: Make sure we open the tabbed bookmark manager in a non OTR window.

BUG=38008
TEST=Press Ctrl+Shift+B when in an incognito window

Review URL: http://codereview.chromium.org/909001
------------------------------------------------------------------------
r41384 | mrossetti@chromium.org | 2010-03-12 03:49:06 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h

Cleanup.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/905001
------------------------------------------------------------------------
r41382 | pkasting@chromium.org | 2010-03-12 03:46:33 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.cc

Last set of tweaks to icon positioning code.  Clarifies positioning algorithm, and for non-Windows, modifies sizing algorithm to just make the icon size be the same as the titlebar font size, minimum 16 px, since the old crazy code just seemed wrong.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/807001
------------------------------------------------------------------------
r41380 | aa@chromium.org | 2010-03-12 02:39:09 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_creator.cc

extensions: Internationalize error code messages.

BUG=23086
TEST=see bug

Review URL: http://codereview.chromium.org/682001
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r41378 | aa@chromium.org | 2010-03-12 02:31:08 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h

Make notifications from extension URLs use extension process.
Future changes will hook up extension APIs and add testing.

BUG=27247

Review URL: http://codereview.chromium.org/868001
------------------------------------------------------------------------
r41375 | sky@chromium.org | 2010-03-12 01:53:12 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h

Updates wm_ipc to be in sync with chrome os.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/877002
------------------------------------------------------------------------
r41374 | jcampan@chromium.org | 2010-03-12 01:49:58 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h

Nothing had the focus by default in the "Clear browsing data"
dialog.  Making the Close button the default focused view.

BUG=33942
TEST=Open the "Clear browsing data" dialog.  The close
     button should be focused.

Review URL: http://codereview.chromium.org/778004
------------------------------------------------------------------------
r41373 | jrg@chromium.org | 2010-03-12 01:49:20 +0100 (Fri, 12 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm

Take 2: make bubble more tolerant of notification order when quitting.

BUG=37807

TEST=\
Run a debug build of Chrome like this:  
  NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium 
Open a bubble then Cmd-Q.
Make sure you don't see a line like this:
  2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.

Review URL: http://codereview.chromium.org/851005
------------------------------------------------------------------------
r41372 | estade@chromium.org | 2010-03-12 01:47:43 +0100 (Fri, 12 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/app/gfx/gtk_util.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h

GTK: more browser action toolbar functionality. 

- Resize smartly after dragging (animate to the "right" size) 
- Add the overflow menu (it is clickable, but you can't drag to/from it) 
- Resize appropriately after adding/removing buttons 

still TODO: 
- persist the #icons that are visible 

BUG=32101
TEST=manual

Review URL: http://codereview.chromium.org/897001
------------------------------------------------------------------------
r41369 | thestig@chromium.org | 2010-03-12 01:33:34 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Linux: Pass --user-data-dir to the Zygote.

BUG=none
TEST=On Linux, "chrome --enable-logging --user-data-dir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME.
Review URL: http://codereview.chromium.org/885003
------------------------------------------------------------------------
r41368 | aa@chromium.org | 2010-03-12 01:33:24 +0100 (Fri, 12 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h

This DCHECK occurs when an installed extension that declares the notification permission is loaded.

Review URL: http://codereview.chromium.org/842002
------------------------------------------------------------------------
r41364 | jhawkins@chromium.org | 2010-03-12 01:24:18 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc

autofill: Tweak the heuristic matching to lower-case form field labels and names.  This is a stop-gap until a fix is made for WebKit.  Add another variation of middle initial.

BUG=37988
TEST=See repro steps in the bug.
Review URL: http://codereview.chromium.org/904001
------------------------------------------------------------------------
r41361 | arv@chromium.org | 2010-03-12 01:09:47 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Open tabbed bookmark manager from menus as well.

This is the Mac part of issue 826002.

BUG=37372
TEST=Start chrome with --enable-tabbed-bookmark-manage and open the BMM from the app menu, as well as bookmark bar context menu etc. All entries should take you to the tabbed bookmark manager.

Review URL: http://codereview.chromium.org/871003
------------------------------------------------------------------------
r41359 | jrg@chromium.org | 2010-03-12 01:07:55 +0100 (Fri, 12 Mar 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Only create bookmark bar buttons that we need, not "for all".
Create the "off the side" menu on demand (since that has "all the rest" in it).

BUG= http://crbug.com/32843

TEST=1) Do the "sync 1000+ bookmarks" test from the bug and watch Chrome NOT run out of memory.
Make sure these bookmarks are all children of the bar for it to be even harder.
2) Add about 5 bookmarks.  Make sure you can grow and shrink (in
width) the window to cause the off-the-side chevron to appear and
disappear as appropriate, and that the off-the-side menu always has
the right contents (bookmarks which fall off the side).
3) Change theme then relaunch; make sure theme set on launch for bookmarks.
4) Using both a big and a small width, make sure the chevron shows (or
not, as appropriate) on launch of Chrome.

Review URL: http://codereview.chromium.org/853001
------------------------------------------------------------------------
r41357 | tony@chromium.org | 2010-03-12 01:06:44 +0100 (Fri, 12 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_mac.cc (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.cc:41355)
   A /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_mac.h (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.h:41355)
   A /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_manager_mac.cc (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.cc:41355)
   A /trunk/src/chrome/browser/renderer_host/gpu_plugin_container_manager_mac.h (from /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.h:41355)
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/chrome_browser.gypi
   D /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.cc
   D /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.h
   D /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.cc
   D /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.h
   M /trunk/src/webkit/webkit.gyp

Move MacGPUPluginContainer from src/webkit/ to src/chrome/.  It
was including files from chrome and only used in
chrome/browser/renderer_host, so it should live in src/chrome/.

TEST=compiles

Review URL: http://codereview.chromium.org/852001
------------------------------------------------------------------------
r41356 | arv@chromium.org | 2010-03-12 01:06:26 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc

Make all entry points to opening the bookmark manager go through Browser::ShowBookmarkManager.

This covers views and gtk.

BUG=37372
TEST=None

Review URL: http://codereview.chromium.org/826002
------------------------------------------------------------------------
r41352 | jcampan@chromium.org | 2010-03-12 00:51:54 +0100 (Fri, 12 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Adding a new unit-test that ensures we are showing a
translate info-bar for all supported languages, as they
are reported by the CLD.

BUG=None
TEST=Run the unit-test.

Review URL: http://codereview.chromium.org/856001
------------------------------------------------------------------------
r41350 | jrg@chromium.org | 2010-03-12 00:43:05 +0100 (Fri, 12 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm

Revert 41342 - Make bubble more tolerant of notification order when quitting.

BUG=http://crbug.com/37807

TEST=\
Run a debug build of Chrome like this:  
  NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium 
Open a bubble then CmdQ.
Make sure you don't see a line like this:
  20100310 19:24:20.381 Chromium[73024:903] *** [ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.


Review URL: http://codereview.chromium.org/839003

TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/902001
------------------------------------------------------------------------
r41347 | chocobo@chromium.org | 2010-03-12 00:34:07 +0100 (Fri, 12 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   D /trunk/src/chrome/browser/chromeos/status/password_dialog_view.cc
   D /trunk/src/chrome/browser/chromeos/status/password_dialog_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Remove obsolute password_dialog_view.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/883002
------------------------------------------------------------------------
r41346 | chocobo@chromium.org | 2010-03-12 00:33:31 +0100 (Fri, 12 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Don't show enable/disable network menu items on login.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/847003
------------------------------------------------------------------------
r41345 | andybons@chromium.org | 2010-03-12 00:30:20 +0100 (Fri, 12 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm

[Mac] Properly cleans up any open info bubble popup windows upon app shutdown.

BUG=37717
TEST=none
Review URL: http://codereview.chromium.org/863005
------------------------------------------------------------------------
r41343 | pkasting@chromium.org | 2010-03-12 00:24:17 +0100 (Fri, 12 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_win.cc
   M /trunk/src/chrome/browser/message_box_handler.cc

Fix some issues with text size calculation and message boxes.

First, size calculations for multi-line, character-breaking strings with no prespecified width were returning useless values, and when given pathological input, could take extremely long time.

Second, the flag calculations for text layout were a bit odd.  For example, we wouldn't add an ending ellipsis on elided text if it was multi-line, and we wouldn't add an ellipsis on a clipped word if character breaking was off.  Fixed these and reordered the calculations to match the order in which the header declares the flags.

Third, message boxes shouldn't need to trim their inputs, or add an ellipsis character, as both of these should now be handled safely by the underlying code.

BUG=34721
TEST=alert("AAAAA") for strings of As that are, say, 4000 characters long should not cause the UI to hang up for noticeable lengths of time
Review URL: http://codereview.chromium.org/810003
------------------------------------------------------------------------
r41342 | jrg@chromium.org | 2010-03-12 00:23:23 +0100 (Fri, 12 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm

Make bubble more tolerant of notification order when quitting.

BUG=http://crbug.com/37807

TEST=\
Run a debug build of Chrome like this:  
  NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium 
Open a bubble then Cmd-Q.
Make sure you don't see a line like this:
  2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.


Review URL: http://codereview.chromium.org/839003
------------------------------------------------------------------------
r41341 | erg@google.com | 2010-03-12 00:21:40 +0100 (Fri, 12 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/gtk_signal.h (from /trunk/src/chrome/common/gtk_signal.h:41336)
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/translate_infobars.h
   D /trunk/src/chrome/common/gtk_signal.h

GTK: Move chrome/common/gtk_signal.h to app/ so views-gtk can use it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/856003
------------------------------------------------------------------------
r41340 | jrg@chromium.org | 2010-03-12 00:21:05 +0100 (Fri, 12 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/draggable_button.mm

Fix "drag cancel" semantics.

BUG=37967

TEST=\
1) make sure bookmark buttons still work (click to open)
2) make sure basic DnD of bookmark buttons still works
3) In Debug build, drag a bookmark button.  ESC to cancel.  Then mouse up.
   Make sure no crash.

Review URL: http://codereview.chromium.org/871002
------------------------------------------------------------------------
r41336 | thakis@chromium.org | 2010-03-12 00:08:42 +0100 (Fri, 12 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm

Mac: Improve window look from "completely broken" to "pretty broken" when RI is enabled.

From http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/HiDPIOverview/HiDPISupport/HiDPISupport.html:

"Because of scaling, the coordinates of the window frame and its top-level view (the frame view) are not always the same. [...] These methods provide the means to transform geometry to and from a base coordinate space that is pixel-aligned with the backing store into which the view is being drawn."

Stuff is still pretty broken with this patch (it used to be better), but it's a low-hanging fruit.

BUG=19476
TEST=Open QuartzDebug, set scale factor to e.g. 1.5. Reopen Chrome. Tabs should be visible.

Review URL: http://codereview.chromium.org/893001
------------------------------------------------------------------------
r41332 | erg@google.com | 2010-03-11 23:50:31 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.h
   A /trunk/src/chrome/browser/gtk/translate_infobars.cc
   A /trunk/src/chrome/browser/gtk/translate_infobars.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: Implement translate toolbar. Tested on spiegel.de, www.lemonde.fr and mainichi.jp (from an English profile).

BUG=36714,37528
TEST=Open up a page that's not in your current language. You should be presented with a toolbar offering to apply Google Translate to the page.

Review URL: http://codereview.chromium.org/830005
------------------------------------------------------------------------
r41331 | dhollowa@chromium.org | 2010-03-11 23:49:04 +0100 (Thu, 11 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/address_field.h
   A /trunk/src/chrome/browser/autofill/address_field_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/form_structure_unittest.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field.cc
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill field parser fixes.

This fixes a number of form field parsing issues.  Ecml field name matching.  Adds country field parsing.  Adds state field parsing.  Multi-line address parsing.  Fixes issue with empty field names confusing the parser.  Fixes issue with phone field parsing.  Adds unit tests in form_structure_unittest.cc to verify parsing order issues.  Adds new unit tests address_field_unittest.cc that cover parsing of each address component as well as Ecml variants.

BUG=37776
TEST=FormStructureTest.Heuristics:AddressFieldTest.*, as well as manual steps described in bug report.

Review URL: http://codereview.chromium.org/867003
------------------------------------------------------------------------
r41329 | chase@chromium.org | 2010-03-11 23:46:49 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Revert 41230 - gtk: Notify the TabContents when the browser window has been moved or resized.  This is used to close the AutoFill popup in the renderer.

BUG=31865
TEST=none
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/878003
------------------------------------------------------------------------
r41328 | chase@chromium.org | 2010-03-11 23:45:40 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Revert 41316 - gtk: Only notify the TabContents that the browser window has moved or resized if the window has actually moved or resized.  This fixes a ~20ms startup performance regression.

BUG=37975
TEST=none
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/868002
------------------------------------------------------------------------
r41327 | rohitrao@chromium.org | 2010-03-11 23:38:24 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

[Mac] Do not hide the menubar if going fullscreen on a secondary monitor.

BUG=37989
TEST=Go fullscreen on a secondary monitor.  Should not hide the menubar.
Review URL: http://codereview.chromium.org/872003
------------------------------------------------------------------------
r41317 | rohitrao@chromium.org | 2010-03-11 22:03:43 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm

[Mac] Fix an infobar crash.

BUG=37797
TEST=See test cases in bug.
Review URL: http://codereview.chromium.org/801008
------------------------------------------------------------------------
r41316 | jhawkins@chromium.org | 2010-03-11 21:45:35 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

gtk: Only notify the TabContents that the browser window has moved or resized if the window has actually moved or resized.  This fixes a ~20ms startup performance regression.

BUG=37975
TEST=none
Review URL: http://codereview.chromium.org/844004
------------------------------------------------------------------------
r41315 | sky@chromium.org | 2010-03-11 21:27:33 +0100 (Thu, 11 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc

Fixes bug in wm_ipc where we were passing ints to XChangeProperty when
we should have been passing longs.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/879002
------------------------------------------------------------------------
r41314 | erg@google.com | 2010-03-11 21:14:13 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h

GTK: Fix crash because of wrong prototype.

BUG=37950
TEST=none

Review URL: http://codereview.chromium.org/837006
------------------------------------------------------------------------
r41311 | estade@chromium.org | 2010-03-11 20:38:08 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h

Convert the first half of gtk/options/* to use the new signal handler macros.

BUG=NONE
TEST=trybots

Review URL: http://codereview.chromium.org/859003
------------------------------------------------------------------------
r41306 | avi@chromium.org | 2010-03-11 20:34:47 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Move all the PrefObserverBridges into namespaces (like is already done with ToolbarController's) so we stop violating the ODR and things start working properly.

BUG=http://crbug.com/37898
TEST=as in bug

Review URL: http://codereview.chromium.org/887002
------------------------------------------------------------------------
r41305 | estade@chromium.org | 2010-03-11 20:32:10 +0100 (Thu, 11 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.h
   A /trunk/src/chrome/browser/gtk/overflow_button.cc
   A /trunk/src/chrome/browser/gtk/overflow_button.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: make browser actions container resizable.

TODO: persist the size of the browser actions container to the profile.
TODO: implement the overflow menu.

BUG=32101
TEST=manual

Review URL: http://codereview.chromium.org/800003
------------------------------------------------------------------------
r41304 | creis@chromium.org | 2010-03-11 20:19:10 +0100 (Thu, 11 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc

Fixes navigation issues with interstitial pages.

Updates NavigationController so that the back and forward menus can
be used while an interstitial page is showing.  Also fixes tab cloning
while an interstitial page is showing, so that the cloned tab does not
have the interstitial navigation entry.

BUG=37215
BUG=37894
TEST=SSLUITest.TestHTTPSExpiredCertAndGo{Back,Forward}
TEST=NavigationControllerTest.CloneOmitsInterstitials

Review URL: http://codereview.chromium.org/861001
------------------------------------------------------------------------
r41299 | estade@chromium.org | 2010-03-11 20:05:07 +0100 (Thu, 11 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix linux perf compile:

fix "may be used uninitialized" error

BUG=NONE
TEST=buildbot compiles
TBR=finnur

Review URL: http://codereview.chromium.org/880002
------------------------------------------------------------------------
r41295 | thomasvl@chromium.org | 2010-03-11 19:39:13 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/animatable_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Pick up a GTM roll and update the apis that changed in this roll.

BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/793003
------------------------------------------------------------------------
r41294 | jhawkins@chromium.org | 2010-03-11 19:34:40 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Rename RenderViewHostDelegate::FormFieldHistory to Autocomplete.

BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/815004
------------------------------------------------------------------------
r41293 | arv@chromium.org | 2010-03-11 19:34:14 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css

Bookmark manager: Update the top section to have same positions and spacing as downloads and history.

BUG=37371,4890
TEST=Open three tabs, History, Downloads and Bookmarks. Ctrl+tab between them and notice how the section icon, input and button all stay in the same position.

Review URL: http://codereview.chromium.org/837003
------------------------------------------------------------------------
r41292 | jhawkins@google.com | 2010-03-11 19:25:45 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_util_win.cc
   M /trunk/src/app/clipboard/clipboard_win.cc
   M /trunk/src/app/l10n_util_dummy.cc
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/app/os_exchange_data_win_unittest.cc
   M /trunk/src/app/sql/connection.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/history/in_memory_database.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/appcache_info_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/database_info_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/local_storage_info_view.cc
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/browser/webdata/web_database_win.cc
   M /trunk/src/chrome/common/child_process_logging_win.cc
   M /trunk/src/chrome/common/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/common/zip.cc
   M /trunk/src/chrome/installer/util/lzma_util.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_util.cc
   M /trunk/src/chrome/tools/profiles/generate_profile.cc
   M /trunk/src/chrome_frame/com_message_event.cc
   M /trunk/src/chrome_frame/np_event_listener.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/media/filters/file_data_source.cc
   M /trunk/src/media/filters/file_data_source_unittest.cc
   M /trunk/src/media/tools/player_wtl/movie.cc
   M /trunk/src/net/base/mime_util.cc
   M /trunk/src/net/base/net_util_win.cc
   M /trunk/src/net/base/platform_mime_util_win.cc
   M /trunk/src/net/base/x509_certificate_win.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/examples/menu_example.h
   M /trunk/src/views/examples/textfield_example.h
   M /trunk/src/views/view.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   M /trunk/src/webkit/glue/plugins/plugin_stream.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

win: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/830002
------------------------------------------------------------------------
r41291 | estade@chromium.org | 2010-03-11 19:19:00 +0100 (Thu, 11 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_controller.h
   A /trunk/src/chrome/browser/find_bar_host_browsertest.cc (from /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc:41081)
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   D /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/find_in_page/link.html

Allow users to close the find session and activate the current link via ctrl-enter.

this only hooks up ctrl-enter on gtk for now, but adding it on windows/mac should be trivial

webkit side, which needs to land first, is here:
https://bugs.webkit.org/show_bug.cgi?id=35407

This also enables the FindInPageControllerTest tests on linux/gtk.

BUG=29500
TEST=FindInPageControllerTest.ActivateLinkNavigatesPage

Review URL: http://codereview.chromium.org/660137
------------------------------------------------------------------------
r41284 | thomasvl@chromium.org | 2010-03-11 18:34:41 +0100 (Thu, 11 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   D /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert 41274 - Unit Tests for OS X Translte infobars.

This has had a few tests crash on the bots, so its starting out flaky/bad.

BUG=None
TEST=New unit tests, tree should stay green after this checkin.

Review URL: http://codereview.chromium.org/669276

TBR=jeremy@chromium.org
Review URL: http://codereview.chromium.org/885001
------------------------------------------------------------------------
r41282 | finnur@chromium.org | 2010-03-11 18:18:27 +0100 (Thu, 11 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disabling browser test that is crashing on the Mac bots.

BUG=29424
TEST=Disabling JavascriptAlertActivatesTab.
TBR=pamg

Review URL: http://codereview.chromium.org/866004
------------------------------------------------------------------------
r41278 | skrul@chromium.org | 2010-03-11 17:25:59 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/profile_mock.h

Refactor synchronous error handling
This is the first of hopefully only two changes to improve our error handling situation.  This change changes the way we use OnUnrecoverableError -- previously this was called whenever there was some kind of error in the MA or CP, but now it is only used for asynchronous errors.  It has been removed from synchronous methods in favor of boolean return values to report errors.  This simplifies some of the error handling.

The next step is to make sure asynchronous usage of OnUnrecoverableError actually works as it should.

Review URL: http://codereview.chromium.org/778002
------------------------------------------------------------------------
r41274 | jeremy@chromium.org | 2010-03-11 15:41:54 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   A /trunk/src/chrome/browser/cocoa/translate_infobar_unittest.mm
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/chrome_tests.gypi

Unit Tests for OS X Translte infobars.

BUG=None
TEST=New unit tests, tree should stay green after this checkin.

Review URL: http://codereview.chromium.org/669276
------------------------------------------------------------------------
r41273 | phajdan.jr@chromium.org | 2010-03-11 15:26:31 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/notifications/notifications_uitest.cc
   M /trunk/src/chrome/browser/pref_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc

[GTTF] Add more NULL-checks to UI tests that were lacking them to avoid crashiness.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/841002
------------------------------------------------------------------------
r41255 | mrossetti@chromium.org | 2010-03-11 07:44:31 +0100 (Thu, 11 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

Long string continuation lines require an 'L' on each continuation.

Build broke by commit for http://codereview.chromium.org/790001. Revision 41252. 

BUG=None
Test=None

Review URL: http://codereview.chromium.org/869001
------------------------------------------------------------------------
r41253 | mrossetti@chromium.org | 2010-03-11 07:14:38 +0100 (Thu, 11 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm

Fix bookmark_bar_view_unittest's BookmarkButtonDragAndDrop test by adding the missing draggingSourceOperationMask method to the FakeBookmarkDraggingInfo class.

Broke by commit for http://codereview.chromium.org/790001.
Revision 41252.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/860002
------------------------------------------------------------------------
r41252 | mrossetti@chromium.org | 2010-03-11 06:21:35 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h

Add bookmark copying while dragging by holding down the <option> key.

BUG=35969
TEST=Hold down the <option> key while dragging a bookmark to a new location. Repeat with the following: 1) From bookmark bar to bookmark bar, 2) from bookmark bar into a folder, 3) from within a folder to a different place within the same folder, 4) from within a folder to the bookmark bar, 5) from within a folder to a different folder. Check to insure that the original bookmark (and its contents if it was a folder) are in both the original location and the new location.

Review URL: http://codereview.chromium.org/790001
------------------------------------------------------------------------
r41251 | satorux@chromium.org | 2010-03-11 05:57:56 +0100 (Thu, 11 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/language_config_view.h

Add a table for the preferred languages to the languages settings dialog.

For now, it does nothing, but we'll add code for the table in the
subsequent changes.

TEST=manually
BUG=none

Review URL: http://codereview.chromium.org/807002
------------------------------------------------------------------------
r41250 | arv@chromium.org | 2010-03-11 04:34:38 +0100 (Thu, 11 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise.js

Bookmark manager: make the URL field lighter.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/850001
------------------------------------------------------------------------
r41249 | rohitrao@chromium.org | 2010-03-11 03:57:05 +0100 (Thu, 11 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Revert 41245 - [Mac] Allow the overlay to animate out when a bookmarkbar folder closes.  This matches the effect when finishing dragging a button.

BUG=None
TEST=Go fullscreen.  Omnibox should not have focus.  Open a folder on the bookmarkbar and hover over one of its subentries.  Overlay should not scroll back up.  Dismiss the overlay.  Overlay should animate out, not disappear instantly.
Review URL: http://codereview.chromium.org/803002

TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/854002
------------------------------------------------------------------------
r41248 | rohitrao@chromium.org | 2010-03-11 03:41:24 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm

[Mac] Save window position into the SessionService, so we can restore it after a crash.

BUG=20909
TEST=Start chrome, load some pages/tabs, move the window somewhere else. Click away and back to the window (to trigger saving window position). Kill chrome (you may have to use kill -9 to actually kill it uncleanly). Restart, click to restore pages. Window should jump to where it was before the crash.
Review URL: http://codereview.chromium.org/660395
------------------------------------------------------------------------
r41245 | rohitrao@chromium.org | 2010-03-11 03:33:07 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

[Mac] Allow the overlay to animate out when a bookmarkbar folder closes.  This matches the effect when finishing dragging a button.

BUG=None
TEST=Go fullscreen.  Omnibox should not have focus.  Open a folder on the bookmarkbar and hover over one of its subentries.  Overlay should not scroll back up.  Dismiss the overlay.  Overlay should animate out, not disappear instantly.
Review URL: http://codereview.chromium.org/803002
------------------------------------------------------------------------
r41230 | jhawkins@chromium.org | 2010-03-11 02:02:06 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

gtk: Notify the TabContents when the browser window has been moved or resized.  This is used to close the AutoFill popup in the renderer.

BUG=31865
TEST=none
Review URL: http://codereview.chromium.org/805006
------------------------------------------------------------------------
r41229 | andybons@chromium.org | 2010-03-11 01:39:39 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm

[Mac] If an info bubble window is open when the app is terminating, cancel the fadeout animation to prevent the window object from leaking.

BUG=37717
TEST=none
Review URL: http://codereview.chromium.org/822007
------------------------------------------------------------------------
r41227 | cmasone@google.com | 2010-03-11 01:33:58 +0100 (Thu, 11 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/utils.cc

Code got moved out from under me, and when I merged, I missed a line.  People not using my new code will be unaffected, but this change makes it so the new stuff works again.
Review URL: http://codereview.chromium.org/826003
------------------------------------------------------------------------
r41223 | cmasone@google.com | 2010-03-11 01:05:02 +0100 (Thu, 11 Mar 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.cc
   A /trunk/src/chrome/browser/chromeos/cros/cryptohome_library.h
   A /trunk/src/chrome/browser/chromeos/cros/mock_cryptohome_library.h
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   A /trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Enable chrome to mount cryptohomes on its own as a part of auth, as well as handle offline login.

TEST=Unittests, and also run on chromium OS device with --in-chrome-auth

Review URL: http://codereview.chromium.org/822006
------------------------------------------------------------------------
r41219 | sky@chromium.org | 2010-03-11 00:10:43 +0100 (Thu, 11 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/authentication_notification_details.h
   A /trunk/src/chrome/browser/chromeos/login/background_view.cc
   A /trunk/src/chrome/browser/chromeos/login/background_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   A /trunk/src/chrome/browser/chromeos/login/utils.cc
   A /trunk/src/chrome/browser/chromeos/login/utils.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h
   D /trunk/src/chrome/browser/chromeos/login/wizard_window.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h

Refactors the login manager code to have two windows:
. background window containing the status and visual background.
. WizardController creates it's own window for showing the various
  wizard dialogs.

I needed to separate these two out as if you have logged in once I
still want the background, and may end up showing the
wizardcontrollers later.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/832002
------------------------------------------------------------------------
r41216 | jar@chromium.org | 2010-03-10 23:55:01 +0100 (Wed, 10 Mar 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Switch to continuous reporting of uptime

Uptime was being reported only at startup, and then, for the previous session.
This meant that folks with a long uptime would be very slow to report.
This change moves the reporting to an incremental reporting, done as
often as we report pageloads etc. (i.e., in each UMA upload).

This also fixes several bugs relating to uptime calculation, by using
TimeTicks (which show process time) rather than Time (which shows wall
clock time, and is subject to corruption if the user changes the will
clock time on the computer).  It also resolves a bug that may have caused
negative uptimes to be reported.

BUG=37630
r=hunar
Review URL: http://codereview.chromium.org/675001
------------------------------------------------------------------------
r41211 | atwilson@chromium.org | 2010-03-10 22:44:41 +0100 (Wed, 10 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.h
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac_unittest.mm
   M /trunk/src/chrome/browser/status_icons/status_icon.h
   M /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   M /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc

Added monochrome status icons for the mac.
Added support for setting an alternate "pressed" image for status icons.

BUG=37375
TEST=updated unit tests

Review URL: http://codereview.chromium.org/752002
------------------------------------------------------------------------
r41210 | akalin@chromium.org | 2010-03-10 22:36:59 +0100 (Wed, 10 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/connection_settings.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/connection_settings.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/candidate.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/common.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/constants.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/constants.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/p2ptransport.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/p2ptransport.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/p2ptransportchannel.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/p2ptransportchannel.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/port.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/port.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/port_unittest.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/portallocator.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/pseudotcp.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/pseudotcp.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/rawtransport.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/rawtransport.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/rawtransportchannel.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/rawtransportchannel.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/relayport.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/relayport.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/relayserver.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/relayserver.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/relayserver_main.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/session.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/session.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/session_unittest.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/sessionclient.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/sessiondescription.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/sessionid.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/sessionmanager.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/sessionmanager.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stun.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stun.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunport.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunport.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunrequest.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunrequest.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunserver.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunserver.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunserver_main.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/stunserver_unittest.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/tcpport.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/tcpport.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/transport.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/transport.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/transportchannel.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/transportchannel.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/transportchannelimpl.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/transportchannelproxy.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/transportchannelproxy.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/udpport.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/base/udpport.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/Makefile.am
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/basicportallocator.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/basicportallocator.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/httpportallocator.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/httpportallocator.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/sessionmanagertask.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/sessionsendtask.h
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/socketmonitor.cc
   D /trunk/src/third_party/libjingle/files/talk/p2p/client/socketmonitor.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclientsettings.h
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Ripped out talk/p2p directory from third_party/libjingle.

Fixed a few compile errors as a result.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/790002
------------------------------------------------------------------------
r41202 | erg@chromium.org | 2010-03-10 21:47:40 +0100 (Wed, 10 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.h
   A /trunk/src/chrome/common/gtk_signal.h

GTK: Use new macros to hide thunk declaration and cleanup callback declaration.

We have two conventions for declaring GTK+ callbacks in our code: We either
declare a bunch of static thunks in the header that redirect to the correct
object (and bloat up the header) OR we declare the callback methods static and
pass the object as the final parameter (and litter the implementation with
"context->"). The two styles are now about half/half...including mixing these
two styles in the same files. This madness must end!

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/661010
------------------------------------------------------------------------
r41199 | pam@chromium.org | 2010-03-10 21:25:21 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Add comment about flaky test.

BUG=27039
TEST=none
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/778006
------------------------------------------------------------------------
r41198 | pam@chromium.org | 2010-03-10 21:19:12 +0100 (Wed, 10 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm

Implement missing method and re-enable three browser_tests on Mac.

BUG=29424
TEST=covered by browser_tests
Review URL: http://codereview.chromium.org/669133
------------------------------------------------------------------------
r41197 | avi@chromium.org | 2010-03-10 21:13:11 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Use more theming methods on gray frame.

BUG=none
TEST=no appearance change

Review URL: http://codereview.chromium.org/823001
------------------------------------------------------------------------
r41194 | pinkerton@chromium.org | 2010-03-10 21:01:35 +0100 (Wed, 10 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/accelerated_surface_mac.cc (from /trunk/src/chrome/common/accelerated_surface_mac.cc:41158)
   A /trunk/src/chrome/common/accelerated_surface_mac.h (from /trunk/src/chrome/common/accelerated_surface_mac.h:41158)
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/webplugin.h
   A /trunk/src/webkit/tools/test_shell/mac/accelerated_surface_stub.cc (from /trunk/src/webkit/tools/test_shell/mac/accelerated_surface_stub.cc:41158)
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi
   M /trunk/src/webkit/webkit.gyp

Implement the CoreAnimation drawing model for plug-ins, sharing IPC and some rendering code with the GPU Plug-in. The drawing model negotiation is currently disabled so this should have no visible impact to plug-ins. 
BUG=32012 
TEST=make sure the pepper GPU plug-ins still work.
------------------------------------------------------------------------
r41193 | arv@chromium.org | 2010-03-10 20:54:41 +0100 (Wed, 10 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Bookmark manager: Open in incognito window.

Make IsIncognitoEnabled take an Extension* as an argument as well and use that where possible.

BUG=4890
TEST=Select one more bookmarks and right click/tools and select "Open in incognito". The bookmarks should open in an incognito window.

Review URL: http://codereview.chromium.org/750001
------------------------------------------------------------------------
r41191 | dhg@chromium.org | 2010-03-10 20:48:23 +0100 (Wed, 10 Mar 2010) | 4 lines
Changed paths:
   A /trunk/src/chrome/app/theme/mediaplayer_menu.png
   A /trunk/src/chrome/app/theme/mediaplayer_next.png
   A /trunk/src/chrome/app/theme/mediaplayer_pause.png
   A /trunk/src/chrome/app/theme/mediaplayer_play.png
   A /trunk/src/chrome/app/theme/mediaplayer_prev.png
   A /trunk/src/chrome/app/theme/mediaplayer_vol_high.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   A /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.cc
   A /trunk/src/chrome/browser/dom_ui/mediaplayer_ui.h
   M /trunk/src/chrome/browser/resources/filebrowse.html
   A /trunk/src/chrome/browser/resources/mediaplayer.html
   A /trunk/src/chrome/browser/resources/playlist.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Adding initial version of the mediaplayer. This only hooks into the system if the user selects a file via the filebrowser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/749001
------------------------------------------------------------------------
r41188 | mark@chromium.org | 2010-03-10 20:26:00 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

10.6 SDK fixes related to NSColor* and NSSize following r41031.  See also
r26348.

BUG=35578 (sort of), 35569 (when I fixed some of these in the past)
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/822003
------------------------------------------------------------------------
r41187 | oshima@chromium.org | 2010-03-10 20:22:03 +0100 (Wed, 10 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Initial focus fix on x11/gtk
 The initial focus on x11/gtk was not working propertly. It was jsut
 working by coincident, and chromeos's compact location bar revealed
 the bug. This CL fixes by setting a focus when the window itself gets focus.

BUG=34159
TEST=on chromeos build, omnibox should have a focus on a new window.

Review URL: http://codereview.chromium.org/756002
------------------------------------------------------------------------
r41186 | thomasvl@chromium.org | 2010-03-10 20:19:07 +0100 (Wed, 10 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

[Mac] autosize the dangerous download info to always fit the text.
- DEPS roll to pick up newer GTM with wrapping support.
- Bring the Mac dangerous download closer inline with what windows does, already have mail out to UX about a real spec since all 3 platforms do different things in different cases.

BUG=28705
TEST=see bug
Review URL: http://codereview.chromium.org/787004
------------------------------------------------------------------------
r41185 | dpolukhin@google.com | 2010-03-10 20:18:31 +0100 (Wed, 10 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Temporary revert CLs due to perf regression on New Tab Warm:

http://codereview.chromium.org/660087
http://codereview.chromium.org/669238

BUG=37533
TEST=none

Review URL: http://codereview.chromium.org/829001
------------------------------------------------------------------------
r41184 | nkostylev@google.com | 2010-03-10 20:11:06 +0100 (Wed, 10 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/network_list.h

Use NetworkConfigView for encrypted Wifi networks.
Bring network library observer back.
Fix rare crash when connecting Ethernet on network selection screen.

BUG=35016
TEST=With --login-manager=network screen should be shown and when accessing encrypted Wifi network dialog box with password field should appear.

Review URL: http://codereview.chromium.org/726001
------------------------------------------------------------------------
r41183 | viettrungluu@chromium.org | 2010-03-10 20:11:03 +0100 (Wed, 10 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Mac: Make background tabs draw properly in fullscreen mode.

(Things still look a bit off due to the lack of a gradient, but that's a
separate issue.)

BUG=35960
TEST=Make sure background tabs look the same as before in normal (non-fullscreen) mode, both when the window is active and when it isn't. Make sure background tabs look approximately correct in fullscreen mode, both when the fullscreen window is active and when it isn't (for the latter, make the floating bar visible by focusing the Omnibox, and switch to another app using Cmd-`); note that it won't look exactly right since we're still missing a gradient.

Review URL: http://codereview.chromium.org/661295
------------------------------------------------------------------------
r41179 | finnur@chromium.org | 2010-03-10 19:36:58 +0100 (Wed, 10 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_test_util.h

Function WaitForBrowserActionUpdated is only implemented on Views.

Added ifdef.

BUG=None
TEST=None
TBR=kkania

Review URL: http://codereview.chromium.org/822004
------------------------------------------------------------------------
r41177 | phajdan.jr@chromium.org | 2010-03-10 19:32:14 +0100 (Wed, 10 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/app/gtk_dnd_util.h
   A /trunk/src/app/gtk_util.cc
   A /trunk/src/app/gtk_util.h
   M /trunk/src/app/os_exchange_data_provider_gtk.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_drag.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_util.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/process_singleton_dialog.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/js_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/common/DEPS
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/common/sandbox_policy.h
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/views/widget/drop_target_gtk.cc

Final removal of the bad dependency of chrome/common on chrome/browser

Also convert app/gtk_dnd_util.h from a class to a namespace for consistency
with added app/gtk_util.h.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669268
------------------------------------------------------------------------
r41174 | chocobo@chromium.org | 2010-03-10 19:21:18 +0100 (Wed, 10 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Do not show network settings menu option for login.
BUG=1683
TEST=none
Review URL: http://codereview.chromium.org/793001
------------------------------------------------------------------------
r41172 | arv@chromium.org | 2010-03-10 19:00:10 +0100 (Wed, 10 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Disable the remove button in the history page when no entries are checked.

This also fixes a bug where we could end up with two sets of buttons after a reload.

BUG=37804
TEST=Go into edit mode and select and deselect a bunch of entries. The disabled state of the remove button should be in sync.

Review URL: http://codereview.chromium.org/815001
------------------------------------------------------------------------
r41166 | estade@chromium.org | 2010-03-10 17:42:58 +0100 (Wed, 10 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h

GTK: allow drags on bookmark menu folder nodes.

Note that the folder menu can't be showing its submenu when the user starts the drag. Since the submenu shows automatically, the user actually has to click once to get rid of it before starting the drag.

BUG=30066
TEST=put a folder node in the other bookmarks folder. Drag it out of the other bookmarks folder and onto the bookmarks bar.

Review URL: http://codereview.chromium.org/799004
------------------------------------------------------------------------
r41165 | thakis@chromium.org | 2010-03-10 17:29:45 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: Gratuitous fullscreen animation.

BUG=19791
TEST=Hit cmd-shift-f. Drool.

Review URL: http://codereview.chromium.org/661045
------------------------------------------------------------------------
r41159 | pinkerton@chromium.org | 2010-03-10 15:36:51 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/accelerated_surface_mac.cc
   D /trunk/src/chrome/common/accelerated_surface_mac.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/webplugin.h
   D /trunk/src/webkit/tools/test_shell/mac/accelerated_surface_stub.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi
   M /trunk/src/webkit/webkit.gyp

Revert 41158 - Implement the CoreAnimation drawing model for plugins, sharing IPC and some rendering code with the GPU Plugin. The drawing model negotiation is currently disabled so this should have no visible impact to plugins.
BUG=32012
TEST=make sure the pepper GPU plugins still work.
Review URL: http://codereview.chromium.org/673001

TBR=pinkerton@chromium.org
------------------------------------------------------------------------
r41158 | pinkerton@chromium.org | 2010-03-10 15:26:16 +0100 (Wed, 10 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/accelerated_surface_mac.cc
   A /trunk/src/chrome/common/accelerated_surface_mac.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/webplugin.h
   A /trunk/src/webkit/tools/test_shell/mac/accelerated_surface_stub.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gypi
   M /trunk/src/webkit/webkit.gyp

Implement the CoreAnimation drawing model for plug-ins, sharing IPC and some rendering code with the GPU Plug-in. The drawing model negotiation is currently disabled so this should have no visible impact to plug-ins.
BUG=32012
TEST=make sure the pepper GPU plug-ins still work.
Review URL: http://codereview.chromium.org/673001
------------------------------------------------------------------------
r41155 | joth@chromium.org | 2010-03-10 14:50:47 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm

Experimental fix for 10.6 SDK builds: convert to weak dependecy on the kCWScanKeyMerge 

BUG=http://crbug.com/37703
TEST={build on 10.5 & 10.6 } x {run browser on 10.5 & 10.6 }

Review URL: http://codereview.chromium.org/691005
------------------------------------------------------------------------
r41149 | phajdan.jr@chromium.org | 2010-03-10 12:02:32 +0100 (Wed, 10 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Add more tests for extension crash recovery.

This should cover most cases I'd like to cover.

TEST=none
BUG=30405

Review URL: http://codereview.chromium.org/718002
------------------------------------------------------------------------
r41144 | finnur@chromium.org | 2010-03-10 08:50:06 +0100 (Wed, 10 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_test_util.h
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc
   M /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Icons are loaded asynchronously for browser actions, so the
test must wait on the extension being updated if no icon is
found. 

I think this should fix the flakiness in the test.

BUG=None
TEST=Fixing a browser test (hopefully).

Review URL: http://codereview.chromium.org/772001
------------------------------------------------------------------------
r41133 | hbono@chromium.org | 2010-03-10 07:23:35 +0100 (Wed, 10 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/base/base.gyp
   M /trunk/src/base/scoped_handle_win.h
   A /trunk/src/base/scoped_native_library.h
   A /trunk/src/base/scoped_native_library_unittest.cc
   A /trunk/src/chrome/browser/aeropeek_manager.cc
   A /trunk/src/chrome/browser/aeropeek_manager.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Implements AeroPeek of Windows 7.
This change integrates the custom AeroPeek implementation into Chromium, which shows the thumbnail list of all tabs and the preview image of the tab selected from the thumbnail list. It uses the AeroPeekManager object, which is a proxy between TabStripModel and Windows to translate events from TabStripModel for Windows, and vice versa. To listen events from TabStripModel without changing the existing part of Chromium, this AeroPeekManager class implements the TabStripModelObserver interface.
Even though this change doesn't include any automated tests for AeroPeek, I would like to send its automated UI test as a separate change. Nevertheless, it just creates/deletes a tab and see this AeroPeekManager can create its thumbnail window correctly.

BUG=6337
TEST=base_unittests.exe --gtest_filter=ScopedNativeLibrary.Basic
Review URL: http://codereview.chromium.org/303033
------------------------------------------------------------------------
r41131 | tony@chromium.org | 2010-03-10 05:45:54 +0100 (Wed, 10 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_exe.gypi
   M /trunk/src/chrome/installer/installer.gyp
   M /trunk/src/chrome/installer/installer_util.gypi
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util_unittest.cc

Allow the use of the master_preferences file in Linux.

Also refactor FirstRunTabs to use GURL instead of wstring.

BUG=none
TEST=Add master_preferences file to directory containing the chrome binary and
execute chrome with the --first-run option.

Original patch by bgmerrell@gmail.com at
http://codereview.chromium.org/551160

Review URL: http://codereview.chromium.org/796001
------------------------------------------------------------------------
r41130 | sky@chromium.org | 2010-03-10 05:32:10 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/automation/automation_provider_chromeos.cc
   A /trunk/src/chrome/browser/chromeos/login/authentication_notification_details.h

Adds files I forgot to svn add when landing http://codereview.chromium.org/668105.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/813001
------------------------------------------------------------------------
r41129 | sky@chromium.org | 2010-03-10 05:14:57 +0100 (Wed, 10 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_window.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h

Lands http://codereview.chromium.org/668105 for sosa:

Changes to add basic automation proxy support to chromeos login wizard

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/783003
------------------------------------------------------------------------
r41128 | ben@chromium.org | 2010-03-10 05:04:06 +0100 (Wed, 10 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h

fix bustage by defining a function in a cros class
------------------------------------------------------------------------
r41127 | ben@chromium.org | 2010-03-10 04:54:24 +0100 (Wed, 10 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc

fix bustage by removing unused variable
------------------------------------------------------------------------
r41126 | ben@chromium.org | 2010-03-10 04:48:18 +0100 (Wed, 10 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc

fix bustage by defining a function
------------------------------------------------------------------------
r41125 | ben@chromium.org | 2010-03-10 04:36:56 +0100 (Wed, 10 Mar 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/app/theme/sidetabs_shadow_bottom.png
   A /trunk/src/chrome/app/theme/sidetabs_shadow_middle.png
   A /trunk/src/chrome/app/theme/sidetabs_shadow_top.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   A /trunk/src/chrome/browser/views/tabs/side_tab_strip_model.h
   M /trunk/src/chrome/chrome_browser.gypi

1. Correct shapes for side tabs.
2. Adjust transparency of background tabs a little.
3. Implement loading animation for side tabs.
4. Deeper shadow for side tabstrip between browser view and side tabstrip.

http://crbug.com/34509
TEST=none

Review URL: http://codereview.chromium.org/610002
------------------------------------------------------------------------
r41114 | andybons@chromium.org | 2010-03-10 03:00:10 +0100 (Wed, 10 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] More progress towards resizing the Browser Actions container.
o Icons fade out as they are moved off screen by resizing the window.
o Dragging the resizer actually resizes the container.
o Known issues include:
  + no chevron.
  + no updating of other windows if the size of the container changes.
  + the cursor is a bit wonky in updating its state.
o Fixes a slew of janky UI bugs relating to having a lot of extensions installed.

BUG=26990,29838
TEST=none
Review URL: http://codereview.chromium.org/657038
------------------------------------------------------------------------
r41113 | jam@chromium.org | 2010-03-10 02:55:04 +0100 (Wed, 10 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Send mouse events to the renderer before changing mouse capture, so that the mousecapturelost arrives after mouseup.

Review URL: http://codereview.chromium.org/743003
------------------------------------------------------------------------
r41109 | mpcomplete@chromium.org | 2010-03-10 02:40:34 +0100 (Wed, 10 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/incognito/apis/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/incognito/content_scripts/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/incognito/popup/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Fix few remaining issues with incognito extensions.
- Open the options page in a regular browser window.
- Rip out the "incognito" permission and revise the warning dialog.

BUG=37677

Review URL: http://codereview.chromium.org/749002
------------------------------------------------------------------------
r41102 | chocobo@chromium.org | 2010-03-10 01:41:49 +0100 (Wed, 10 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h

Disable login button on login dialog until user enters ssid/password.
BUG=1006
TEST=none
Review URL: http://codereview.chromium.org/788001
------------------------------------------------------------------------
r41100 | jhawkins@chromium.org | 2010-03-10 01:35:05 +0100 (Wed, 10 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/password_manager/encryptor_mac.mm
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/sandbox_mac_unittest.mm
   M /trunk/src/webkit/glue/plugins/plugin_lib_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm

mac: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/745003
------------------------------------------------------------------------
r41094 | arv@chromium.org | 2010-03-10 00:59:41 +0100 (Wed, 10 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json

Fix key in bookmark manager manifest

BUG=4890
TEST=Start with --enable-tabbed-bookmark-manager

Review URL: http://codereview.chromium.org/780001
------------------------------------------------------------------------
r41092 | jcampan@chromium.org | 2010-03-10 00:56:31 +0100 (Wed, 10 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h

This CL ensures the SafeBrowsingService is only notified once
by the SafeBrowsingInterstitialPage.
The interstitial page logic makes sure its Proceed/DontProceed
are called only once, but the DontProceed could also be called
when navigating back.  Since the SafeBrowsingService::Client
is deleted when the SafeBrowsingService is notified, that would
cause a crasher on the 2nd notification.

BUG=http://crbug.com/30079
TEST=See bug.

Review URL: http://codereview.chromium.org/697002
------------------------------------------------------------------------
r41089 | willchan@chromium.org | 2010-03-10 00:33:19 +0100 (Wed, 10 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_shutdown.cc

Fix APP_TERMINATING on Mac to fire while the UI loop is still alive.
BUG=34391

Review URL: http://codereview.chromium.org/748002
------------------------------------------------------------------------
r41084 | avi@chromium.org | 2010-03-09 23:51:53 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.h
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/themed_window.h
   M /trunk/src/chrome/browser/cocoa/themed_window.mm

Fix theming on popup windows (Mac).

BUG=http://crbug.com/37690
TEST=as in comment 3 on the bug

Review URL: http://codereview.chromium.org/729002
------------------------------------------------------------------------
r41080 | evan@chromium.org | 2010-03-09 22:44:44 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/sync/sessions/ordered_commit_set.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/renderer/mock_printer.h

More code cleanups found by -Wextra.

(I'm still waiting on a v8 change to turn this on for the whole codebase...)

Review URL: http://codereview.chromium.org/746001
------------------------------------------------------------------------
r41079 | shess@chromium.org | 2010-03-09 22:41:14 +0100 (Tue, 09 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Clean up SafeBrowsingDatabaseTest setup/teardown.

Pull handling of the database setup, teardown, and memory management
up into the test class.  Push a bunch of global functions into the
test class.  Use helper functions for dealing with hashes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/755001
------------------------------------------------------------------------
r41075 | thestig@chromium.org | 2010-03-09 22:25:19 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details_linux.cc

Linux: Fix about:memory for SUID sandbox + pid namespaces.

BUG=36934
TEST=about:memory works on Linux machines with pid namespaces enabled.
Review URL: http://codereview.chromium.org/752001
------------------------------------------------------------------------
r41073 | viettrungluu@chromium.org | 2010-03-09 22:05:27 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

Mac: fix fullscreen floating bar in popup windows.

BUG=37699
TEST=Make sure the following types of windows look correct in fullscreen mode (in particular, the toolbar/menu should slide down properly and look nice): (1) normal windows (with tab strip), (2) popup windows with location bar, (3) "app" windows such as the dev tools window. Also make sure these things show correctly with themes and the bookmark bar enabled.

Review URL: http://codereview.chromium.org/747001
------------------------------------------------------------------------
r41071 | tim@chromium.org | 2010-03-09 21:45:15 +0100 (Tue, 09 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Revert 40521 - Fix attempt for bug 34158. Reset the TalkMediator after calling Logout to ensure it is destroyed from the
core thread.  This ensures the task to destroy the GaiaAuth object is run on
the core thread and not the UI thread.

Fred and I debugged this together and actually saw a second crash appear to result
from this change, but then we did a clean build and were unable to repro that crash,
so I think this as a net win at the moment.

BUG=34158,37771

Review URL: http://codereview.chromium.org/660437

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/738002
------------------------------------------------------------------------
r41068 | mpcomplete@chromium.org | 2010-03-09 20:55:19 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Persistent "Load unpacked extension" extensions across browser restarts.

BUG=24850

Review URL: http://codereview.chromium.org/681001
------------------------------------------------------------------------
r41067 | pvalchev@google.com | 2010-03-09 20:52:16 +0100 (Tue, 09 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/gpu_native_window_handle.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

BSD ifdefs, etc. necessary for chrome/
Review URL: http://codereview.chromium.org/656009
------------------------------------------------------------------------
r41065 | tim@chromium.org | 2010-03-09 20:20:05 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h

Speculative fix for bug 37709.  Don't use a MutableEntry (and hence add something to the transaction's originals_ array) in apply updates until we know it's a safe type.

BUG=37709,36822

Review URL: http://codereview.chromium.org/705001
------------------------------------------------------------------------
r41064 | tim@chromium.org | 2010-03-09 20:19:37 +0100 (Tue, 09 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.h
   A /trunk/src/chrome/browser/sync/engine/verify_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/chrome_tests.gypi

Make VerifyUpdatesCommand a ModelChanging variant for now as we can end
up in AttemptReuniteLostCommitResponse, change IDs, and wind up trying
to move a bookmark as a result from the wrong thread.  I haven't seen
a case where it's actually _moving_, but we still call into the BookmarkModel.
It's a no-op call except for a threading assertion.

Add check to BookmarkChangeProcessor that we're on the UI thread.

BUG=37723
TEST=VerifyUpdatesCommandUnittest (added)

Review URL: http://codereview.chromium.org/689001
------------------------------------------------------------------------
r41061 | glotov@google.com | 2010-03-09 20:08:43 +0100 (Tue, 09 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/language_combobox_model.h

Language selection menu rearranged to main menu with main languages and sub-menu with all others.

BUG=35248
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-name=nework

Review URL: http://codereview.chromium.org/732001
------------------------------------------------------------------------
r41056 | mseaborn@chromium.org | 2010-03-09 19:58:00 +0100 (Tue, 09 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc

Run NaCl itself in Chromium's Linux sandbox

This is achieved by forking the NaCl loader process (Chromium's
compiled-in sel_ldr) from the Zygote process.

This leaves the sel_ldr with a little excess authority, because it has
access to the IPC methods (e.g. for fonts) implemented in
render_sandbox_host_linux.cc.

BUG=36676
TEST=nacl_ui_tests

Review URL: http://codereview.chromium.org/669274
------------------------------------------------------------------------
r41054 | mpcomplete@chromium.org | 2010-03-09 19:55:48 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h

Fix crash when a background page calls alert().

BUG=37567

Review URL: http://codereview.chromium.org/691001
------------------------------------------------------------------------
r41052 | xiyuan@chromium.org | 2010-03-09 19:48:14 +0100 (Tue, 09 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Open new tab in foreground from app window

Make "Open in new tab" menu in an app window opens the tab in foreground
per issue 22214.

BUG=22214
TEST=Verify fix for 22214.

Review URL: http://codereview.chromium.org/688001
------------------------------------------------------------------------
r41050 | skrul@chromium.org | 2010-03-09 19:15:08 +0100 (Tue, 09 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h

Add tests to the ProfileSyncServiceAutofillTest for association merge.
This include two bug fixes for the AutofillModelAssociator -- there was a call to OnUnrecoverableError on the PSS which should have been error_handler, plus the sync node's timestamps were got getting written when an association merge took place.

Review URL: http://codereview.chromium.org/671022
------------------------------------------------------------------------
r41047 | glotov@google.com | 2010-03-09 18:54:05 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc

Update screen view is reset while language is switched.

BUG=none
TODO=none

Review URL: http://codereview.chromium.org/736001
------------------------------------------------------------------------
r41041 | dhollowa@chromium.org | 2010-03-09 18:39:44 +0100 (Tue, 09 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   A /trunk/src/chrome/browser/autofill/personal_data_manager_mac.mm
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

AutoFill Mac Address Book "me" card data translation.

Implements Mac Address Book "me" card integration with AutoFill feature.  When the kAutoFillAuxiliaryProfilesEnabled preference is enabled, via the AutoFill preferences dialog, the active user's designated "me" card becomes available to AutoFill.  That is, forms become aware of any name, address, email, and telephone number information residing in the user's "me" card.  Small change to AutoFillDialog.xib to resize the preference check-box label width to accommodate new string.

BUG=36496
TEST=PersonalDataManagerTest


Review URL: http://codereview.chromium.org/668247
------------------------------------------------------------------------
r41034 | skrul@chromium.org | 2010-03-09 18:16:35 +0100 (Tue, 09 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h

Remove unused persist code.

Review URL: http://codereview.chromium.org/679001
------------------------------------------------------------------------
r41033 | dhg@chromium.org | 2010-03-09 17:47:10 +0100 (Tue, 09 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing my localization laziness.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/683001
------------------------------------------------------------------------
r41031 | viettrungluu@chromium.org | 2010-03-09 16:58:37 +0100 (Tue, 09 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Mac: incognito badge fixes.

1. Make the incognito badge appear in fullscreen mode.
2. Make the new tab button not run into the incognito badge.

BUG=37574, 37745
TEST=Make an incognito window and go to fullscreen mode; incognito badge should be visible in upper right. Make an incognito window with lots of tabs; new tab button (and tabs) shouldn't run into the badge; resize the window and make sure the badge stays in the right place.

Review URL: http://codereview.chromium.org/691003
------------------------------------------------------------------------
r41026 | jeremy@chromium.org | 2010-03-09 15:18:09 +0100 (Tue, 09 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Add enable/disable translate pref to "Under the Hood".

NIB change: Added checkbox for pref into web content section of "Under the Hood" and moved other controls down to match.

BUG=37527
TEST=navigate to www.google.co.il using a branded build translate infobar should appear/not appear based on pref.

Review URL: http://codereview.chromium.org/722004
------------------------------------------------------------------------
r41025 | glotov@google.com | 2010-03-09 14:26:36 +0100 (Tue, 09 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h

Language switch implemented.

BUG=35248
DEPENDS=668067, 668068
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-name=nework

Review URL: http://codereview.chromium.org/661475
------------------------------------------------------------------------
r41024 | jorlow@chromium.org | 2010-03-09 13:53:54 +0100 (Tue, 09 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h

Use the WebViewClient* passed in from the StorageAreaProxy instead of using
RenderThread::RoutingIDForCurrentContext() whenever possible. In addition,
call OnContentBlocked directly from within the browser instead of sending
another IPC message. Lastly, make sure that we don't crash in the event
that we can't determine the routing id.

WebKit side: https://bugs.webkit.org/show_bug.cgi?id=35758

(Landing again after reverting in 40922)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/671001
------------------------------------------------------------------------
r41021 | bulach@chromium.org | 2010-03-09 12:34:51 +0100 (Tue, 09 Mar 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/content_setting_bubble_model.cc
   A /trunk/src/chrome/browser/content_setting_bubble_model.h
   A /trunk/src/chrome/browser/content_setting_bubble_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds ContentSettingBubbleModel.

Review URL: http://codereview.chromium.org/668075
------------------------------------------------------------------------
r41017 | suzhe@chromium.org | 2010-03-09 11:49:08 +0100 (Tue, 09 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

[Linux] Improve DownloadShelfGtk to use GtkShrinkableHBox, and fix a label wrap issue.

This CL depends on CL 661364.

BUG=37293 With RTL UI, items in download shelf can't be hidden correctly when shrinking the browser window.
BUG=37392 Chinese dangerous warning message of download items overflows its boundary.
TEST=See bug report.

Review URL: http://codereview.chromium.org/668053
------------------------------------------------------------------------
r41016 | jeremy@chromium.org | 2010-03-09 11:37:47 +0100 (Tue, 09 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm

Handle the case where the infobar can be instantiated in a state other than "Beginning Translate".

A complete layout is now done on each state transition, since we can't rely on always being instantiated in the "Beginning translation" state.

This CL also updates the code to pickup changes made on the Windows side, most notable the infobar now no longer updates the model state explicitly.

Quoting from Kuan's fix on the Windows side:
"""
problem happened because infobars are destructed when switching between tabs, only the delegates persist.  without the infobar to receive the PAGE_TRANSLATED notification to update the translate state, the infobar gets stuck at translating state when user switches back to the associated tab.
"""

BUG=36895
TEST=See bug description.

Review URL: http://codereview.chromium.org/668241
------------------------------------------------------------------------
r41014 | dpolukhin@google.com | 2010-03-09 09:19:33 +0100 (Tue, 09 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Fix performance regression New Tab Warm introduced in http://codereview.chromium.org/660087

Prevents extra layouts and setting window size.

BUG=37533
TEST=Difference perf regression should be fixed, see perf monitor here http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150&rev=-1

Review URL: http://codereview.chromium.org/669238
------------------------------------------------------------------------
r41012 | satorux@chromium.org | 2010-03-09 08:16:20 +0100 (Tue, 09 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Show language names rather than input method names.

For instance, we'll show "Japanese" instead of "Anthy".

Depends on http://codereview.chromium.org/652106

TEST=manually
BUG=none

Review URL: http://codereview.chromium.org/652222
------------------------------------------------------------------------
r41011 | ananta@chromium.org | 2010-03-09 07:57:10 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/multipart_uitest.cc

Disabling the MultipartResponseUITest.SingleVisit for debug ui test runs as it fails on the builder. This needs to be
debugged.

Bug=37746

Review URL: http://codereview.chromium.org/692002
------------------------------------------------------------------------
r41010 | satorux@chromium.org | 2010-03-09 07:39:10 +0100 (Tue, 09 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/options/language_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/language_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Move the input language settings to a separate dialog.

Just move the code. No logic is changed.
This is the first step towards implmenting the input language settings.

TEST=manually
BUG=none

Review URL: http://codereview.chromium.org/668061
------------------------------------------------------------------------
r41003 | ananta@chromium.org | 2010-03-09 06:57:04 +0100 (Tue, 09 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Attempting to reland this CL as this does not seem related to the ui test failures. Will watch the build
after I commit.

Revert 40994 - Revert "Launching Chrome with a userdatadir command line switch containing a non ASCII ..."

Speculative revert to try to fix win dbg MultipartResponseUITest.SingleVisit failures.

This reverts commit r40981

TBR=tony

Review URL: http://codereview.chromium.org/707001

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/712001
------------------------------------------------------------------------
r41002 | thakis@chromium.org | 2010-03-09 06:50:25 +0100 (Tue, 09 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm

Fix mac valgrind.

Review URL: http://codereview.chromium.org/700001
------------------------------------------------------------------------
r40999 | yusukes@chromium.org | 2010-03-09 05:56:17 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Don't show IME properties when current language is set to XKB.

BUG=1727
TEST=see the bug

Review URL: http://codereview.chromium.org/669265
------------------------------------------------------------------------
r40998 | ctguil@chromium.org | 2010-03-09 05:28:48 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Notify MSAA clients when a state change notification is received. 

BUG=36165
TEST=The screen reader JAWS should speak the checked state of a check box when it is toggled. 

Review URL: http://codereview.chromium.org/693002
------------------------------------------------------------------------
r40996 | kinuko@chromium.org | 2010-03-09 05:01:36 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h

Start a download in the user's download directory to lower rename failure possibilities

BUG=8737
TEST=Check 'Ask where to save each file before downloading' true in the 'Under the Hood' preference and start a download.  A temporary file org.chromium.XXXXXX or com.google.chrome.XXXXXX should appear in the user's download directory (e.g. ~/Downloads).  After selecting the final destination file the temporary file should go away (and be renamed to the final name).

Review URL: http://codereview.chromium.org/672020
------------------------------------------------------------------------
r40994 | mattm@chromium.org | 2010-03-09 04:47:46 +0100 (Tue, 09 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Revert "Launching Chrome with a user-data-dir command line switch containing a non ASCII ..."

Speculative revert to try to fix win dbg MultipartResponseUITest.SingleVisit failures.

This reverts commit r40981

TBR=tony

Review URL: http://codereview.chromium.org/707001
------------------------------------------------------------------------
r40993 | mattm@chromium.org | 2010-03-09 04:30:02 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/gtk/certificate_dialogs.cc
   A /trunk/src/chrome/browser/gtk/certificate_dialogs.h
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/chrome_browser.gypi

Linux: Add export option to certificate viewer.

BUG=18119
TEST=Export some certs, compare files with exports from firefox.

Review URL: http://codereview.chromium.org/669137
------------------------------------------------------------------------
r40991 | pkasting@chromium.org | 2010-03-09 03:34:14 +0100 (Tue, 09 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src
   M /trunk/src/app/active_window_watcher_x.cc
   M /trunk/src/app/active_window_watcher_x.h
   M /trunk/src/app/app_switches.cc
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/codec/jpeg_codec.cc
   M /trunk/src/app/gfx/codec/jpeg_codec.h
   M /trunk/src/app/gfx/codec/jpeg_codec_unittest.cc
   M /trunk/src/app/gfx/codec/png_codec.cc
   M /trunk/src/app/gfx/codec/png_codec.h
   M /trunk/src/app/gfx/codec/png_codec_unittest.cc
   M /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/app/gfx/gdi_util.cc
   M /trunk/src/app/gfx/gdi_util.h
   M /trunk/src/app/gfx/gtk_native_view_id_manager.cc
   M /trunk/src/app/gfx/gtk_native_view_id_manager.h
   M /trunk/src/app/gfx/native_widget_types.h
   M /trunk/src/app/gfx/native_widget_types_gtk.cc
   M /trunk/src/app/gfx/skbitmap_operations.cc
   M /trunk/src/app/gfx/skbitmap_operations.h
   M /trunk/src/app/gfx/skbitmap_operations_unittest.cc
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/app/gfx/text_elider.h
   M /trunk/src/app/gfx/text_elider_unittest.cc
   M /trunk/src/app/message_box_flags.h
   M /trunk/src/app/resources/browser_action_badge_center.png
   M /trunk/src/app/resources/browser_action_badge_left.png
   M /trunk/src/app/resources/browser_action_badge_right.png
   M /trunk/src/app/resources/frame_app_panel_default.png
   M /trunk/src/app/resources/linux_close.png
   M /trunk/src/app/resources/linux_close_h.png
   M /trunk/src/app/resources/linux_close_mask.png
   M /trunk/src/app/resources/linux_close_p.png
   M /trunk/src/app/resources/linux_maximize.png
   M /trunk/src/app/resources/linux_maximize_h.png
   M /trunk/src/app/resources/linux_maximize_mask.png
   M /trunk/src/app/resources/linux_maximize_p.png
   M /trunk/src/app/resources/linux_minimize.png
   M /trunk/src/app/resources/linux_minimize_h.png
   M /trunk/src/app/resources/linux_minimize_mask.png
   M /trunk/src/app/resources/linux_minimize_p.png
   M /trunk/src/app/resources/linux_restore.png
   M /trunk/src/app/resources/linux_restore_h.png
   M /trunk/src/app/resources/linux_restore_p.png
   M /trunk/src/app/resources/menu_arrow.png
   M /trunk/src/app/resources/menu_check.png
   M /trunk/src/app/run_all_unittests.cc
   M /trunk/src/app/test/data/icon_util/128_X_128_icon.ico
   M /trunk/src/app/test/data/icon_util/16_X_16_icon.ico
   M /trunk/src/app/tree_model.h
   M /trunk/src/app/tree_node_iterator.h
   M /trunk/src/app/tree_node_iterator_unittest.cc
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/app/win/window_impl.cc
   M /trunk/src/app/win/window_impl.h
   M /trunk/src/base/allocator/allocator.gyp
   M /trunk/src/base/atomic_ref_count.h
   M /trunk/src/base/atomicops_internals_arm_gcc.h
   M /trunk/src/base/callback.h
   M /trunk/src/base/cancellation_flag.cc
   M /trunk/src/base/cancellation_flag.h
   M /trunk/src/base/cancellation_flag_unittest.cc
   M /trunk/src/base/crypto/signature_creator.h
   M /trunk/src/base/crypto/signature_creator_mac.cc
   M /trunk/src/base/crypto/signature_creator_unittest.cc
   M /trunk/src/base/eintr_wrapper.h
   M /trunk/src/base/file_descriptor_shuffle.cc
   M /trunk/src/base/file_descriptor_shuffle_unittest.cc
   M /trunk/src/base/global_descriptors_posix.cc
   M /trunk/src/base/global_descriptors_posix.h
   M /trunk/src/base/gmock_unittest.cc
   M /trunk/src/base/i18n/file_util_icu.cc
   M /trunk/src/base/i18n/icu_string_conversions.cc
   M /trunk/src/base/i18n/icu_string_conversions.h
   M /trunk/src/base/i18n/icu_string_conversions_unittest.cc
   M /trunk/src/base/i18n/icu_util.cc
   M /trunk/src/base/i18n/icu_util.h
   M /trunk/src/base/i18n/number_formatting.cc
   M /trunk/src/base/i18n/time_formatting.cc
   M /trunk/src/base/i18n/time_formatting.h
   M /trunk/src/base/i18n/word_iterator.cc
   M /trunk/src/base/i18n/word_iterator.h
   M /trunk/src/base/i18n/word_iterator_unittest.cc
   M /trunk/src/base/id_map_unittest.cc
   M /trunk/src/base/json/json_reader.cc
   M /trunk/src/base/json/json_reader.h
   M /trunk/src/base/json/json_reader_unittest.cc
   M /trunk/src/base/json/json_writer.cc
   M /trunk/src/base/json/json_writer.h
   M /trunk/src/base/json/json_writer_unittest.cc
   M /trunk/src/base/json/string_escape.cc
   M /trunk/src/base/json/string_escape.h
   M /trunk/src/base/json/string_escape_unittest.cc
   M /trunk/src/base/native_library_linux.cc
   M /trunk/src/base/native_library_mac.mm
   M /trunk/src/base/native_library_win.cc
   M /trunk/src/base/platform_file.h
   M /trunk/src/base/platform_file_posix.cc
   M /trunk/src/base/platform_file_win.cc
   M /trunk/src/base/process_linux.cc
   M /trunk/src/base/rand_util_c.h
   M /trunk/src/base/raw_scoped_refptr_mismatch_checker.h
   M /trunk/src/base/scoped_bstr_win.cc
   M /trunk/src/base/scoped_bstr_win.h
   M /trunk/src/base/scoped_bstr_win_unittest.cc
   M /trunk/src/base/scoped_comptr_win.h
   M /trunk/src/base/scoped_comptr_win_unittest.cc
   M /trunk/src/base/scoped_nsdisable_screen_updates.h
   M /trunk/src/base/scoped_variant_win_unittest.cc
   M /trunk/src/base/sys_info_unittest.cc
   M /trunk/src/base/sys_string_conversions_mac.mm
   M /trunk/src/base/test/perf_test_suite.h
   M /trunk/src/base/test/run_all_perftests.cc
   M /trunk/src/base/test/run_all_unittests.cc
   M /trunk/src/base/test/test_file_util.h
   M /trunk/src/base/test/test_file_util_linux.cc
   M /trunk/src/base/test/test_file_util_mac.cc
   M /trunk/src/base/test/test_file_util_posix.cc
   M /trunk/src/base/test/test_file_util_win.cc
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/base/third_party/icu/icu_utf.cc
   M /trunk/src/base/third_party/icu/icu_utf.h
   M /trunk/src/base/third_party/nspr/prcpucfg_openbsd.h
   M /trunk/src/base/third_party/valgrind/valgrind.h
   M /trunk/src/base/third_party/xdg_mime/xdgmime.c
   M /trunk/src/base/third_party/xdg_mime/xdgmime.h
   M /trunk/src/base/third_party/xdg_mime/xdgmimealias.c
   M /trunk/src/base/third_party/xdg_mime/xdgmimealias.h
   M /trunk/src/base/third_party/xdg_mime/xdgmimecache.c
   M /trunk/src/base/third_party/xdg_mime/xdgmimecache.h
   M /trunk/src/base/third_party/xdg_mime/xdgmimeglob.c
   M /trunk/src/base/third_party/xdg_mime/xdgmimeglob.h
   M /trunk/src/base/third_party/xdg_mime/xdgmimeicon.c
   M /trunk/src/base/third_party/xdg_mime/xdgmimeicon.h
   M /trunk/src/base/third_party/xdg_mime/xdgmimeint.c
   M /trunk/src/base/third_party/xdg_mime/xdgmimeint.h
   M /trunk/src/base/third_party/xdg_mime/xdgmimemagic.c
   M /trunk/src/base/third_party/xdg_mime/xdgmimemagic.h
   M /trunk/src/base/third_party/xdg_mime/xdgmimeparent.c
   M /trunk/src/base/third_party/xdg_mime/xdgmimeparent.h
   M /trunk/src/base/time_win_unittest.cc
   M /trunk/src/base/unix_domain_socket_posix.cc
   M /trunk/src/base/utf_offset_string_conversions.cc
   M /trunk/src/base/utf_offset_string_conversions.h
   M /trunk/src/base/utf_string_conversion_utils.cc
   M /trunk/src/base/utf_string_conversions.cc
   M /trunk/src/base/utf_string_conversions.h
   M /trunk/src/base/worker_pool_linux.h
   M /trunk/src/base/worker_pool_linux_unittest.cc
   M /trunk/src/breakpad/linux/generate-test-dump.cc
   M /trunk/src/chrome/app/hard_error_handler_win.h
   M /trunk/src/chrome/app/theme/back_noborder.png
   M /trunk/src/chrome/app/theme/balloon_close.png
   M /trunk/src/chrome/app/theme/balloon_close_hover.png
   M /trunk/src/chrome/app/theme/balloon_options_arrow.png
   M /trunk/src/chrome/app/theme/balloon_options_arrow_hover.png
   M /trunk/src/chrome/app/theme/blocked_cookies.png
   M /trunk/src/chrome/app/theme/blocked_images.png
   M /trunk/src/chrome/app/theme/blocked_javascript.png
   M /trunk/src/chrome/app/theme/blocked_plugins.png
   M /trunk/src/chrome/app/theme/blocked_popups.png
   M /trunk/src/chrome/app/theme/chromium/chromium.ico
   M /trunk/src/chrome/app/theme/chromium/product_logo_128.png
   M /trunk/src/chrome/app/theme/chromium/product_logo_22.png
   M /trunk/src/chrome/app/theme/chromium/product_logo_24.png
   M /trunk/src/chrome/app/theme/chromium/product_logo_64.png
   M /trunk/src/chrome/app/theme/filebrowse_upload.png
   M /trunk/src/chrome/app/theme/forward_noborder.png
   M /trunk/src/chrome/app/theme/geolocation_allowed_locationbar_icon.png
   M /trunk/src/chrome/app/theme/geolocation_denied_locationbar_icon.png
   M /trunk/src/chrome/app/theme/geolocation_infobar_icon.png
   M /trunk/src/chrome/app/theme/go_noborder.png
   M /trunk/src/chrome/app/theme/go_noborder_center.png
   M /trunk/src/chrome/app/theme/home_noborder.png
   M /trunk/src/chrome/app/theme/locationbg_readonly_edge.png
   M /trunk/src/chrome/app/theme/reload_noborder.png
   M /trunk/src/chrome/app/theme/star_noborder.png
   M /trunk/src/chrome/app/theme/star_noborder_center.png
   M /trunk/src/chrome/app/theme/starred_noborder.png
   M /trunk/src/chrome/app/theme/starred_noborder_center.png
   M /trunk/src/chrome/app/theme/statusbar_menu.png
   M /trunk/src/chrome/app/theme/stop_noborder.png
   M /trunk/src/chrome/app/theme/stop_noborder_center.png
   M /trunk/src/chrome/app/theme/theme_frame_default2.png
   M /trunk/src/chrome/app/theme/theme_frame_default_inactive2.png
   M /trunk/src/chrome/app/theme/theme_frame_default_incognito2.png
   M /trunk/src/chrome/app/theme/theme_frame_default_incognito_inactive2.png
   M /trunk/src/chrome/app/theme/theme_tab_background2.png
   M /trunk/src/chrome/app/theme/theme_toolbar_default2.png
   M /trunk/src/chrome/app/theme/throbber_waiting_light.png
   M /trunk/src/chrome/app/theme/vista_frame_throbber_01.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_02.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_03.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_04.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_05.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_06.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_07.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_08.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_09.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_10.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_11.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_12.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_13.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_14.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_15.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_16.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_17.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_18.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_19.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_20.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_21.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_22.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_23.ico
   M /trunk/src/chrome/app/theme/vista_frame_throbber_24.ico
   M /trunk/src/chrome/browser/app_controller_cppsafe_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   M /trunk/src/chrome/browser/automation/automation_provider_list_generic.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser_list_gtk.cc
   M /trunk/src/chrome/browser/browser_process_sub_thread.cc
   M /trunk/src/chrome/browser/browser_process_sub_thread.h
   M /trunk/src/chrome/browser/browser_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/chromeos/cros/cros_api.gyp
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/chromeos/google_update_chromeos.cc
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   M /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_window.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.h
   M /trunk/src/chrome/browser/chromeos/wm_ipc.cc
   M /trunk/src/chrome/browser/chromeos/wm_ipc.h
   M /trunk/src/chrome/browser/chromeos/wm_message_listener.cc
   M /trunk/src/chrome/browser/chromeos/wm_message_listener.h
   M /trunk/src/chrome/browser/cocoa/browser_command_executor.h
   M /trunk/src/chrome/browser/cocoa/browser_frame_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h
   M /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_pasteboard.h
   M /trunk/src/chrome/browser/cocoa/find_pasteboard.mm
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_cppsafe.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.h
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/objc_method_swizzle.h
   M /trunk/src/chrome/browser/cocoa/objc_method_swizzle.mm
   M /trunk/src/chrome/browser/cocoa/objc_method_swizzle_unittest.mm
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper_unittest.mm
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model.h
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.h
   M /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/command_updater.cc
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/command_updater_unittest.cc
   M /trunk/src/chrome/browser/content_setting_image_model.cc
   M /trunk/src/chrome/browser/content_setting_image_model.h
   M /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.h
   M /trunk/src/chrome/browser/crash_handler_host_linux_stub.cc
   M /trunk/src/chrome/browser/debugger/devtools_client_host.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_message_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.cc
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/download/download_started_animation.h
   M /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/encoding_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/convert_user_script.h
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/isolated_world_apitest.cc
   M /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/geolocation/geoposition.cc
   M /trunk/src/chrome/browser/geolocation/geoposition.h
   M /trunk/src/chrome/browser/google_update_settings_mac.mm
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_browsertest.cc
   M /trunk/src/chrome/browser/gtk/cairo_cached_surface.h
   M /trunk/src/chrome/browser/gtk/download_started_animation_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox_unittest.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/tabstrip_origin_provider.h
   M /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/chrome/browser/hung_renderer_dialog.h
   M /trunk/src/chrome/browser/icon_loader_win.cc
   M /trunk/src/chrome/browser/icon_manager_linux.cc
   M /trunk/src/chrome/browser/icon_manager_win.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.mm
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc
   M /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.mm
   M /trunk/src/chrome/browser/importer/nss_decryptor_system_nss.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_system_nss.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/login_prompt_unittest.cc
   M /trunk/src/chrome/browser/metrics/metric_event_duration_details.h
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_response.cc
   M /trunk/src/chrome/browser/metrics/metrics_response.h
   M /trunk/src/chrome/browser/metrics/metrics_response_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h
   M /trunk/src/chrome/browser/net/ftp_browsertest.cc
   M /trunk/src/chrome/browser/net/metadata_url_request.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_system.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/net/url_fetcher_protect.cc
   M /trunk/src/chrome/browser/net/url_fetcher_protect.h
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.cc
   M /trunk/src/chrome/browser/net/url_request_mock_util.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.h
   M /trunk/src/chrome/browser/notifications/notifications_uitest.cc
   M /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/parsers/metadata_parser.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_manager.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_manager.h
   M /trunk/src/chrome/browser/password_manager/encryptor.h
   M /trunk/src/chrome/browser/password_manager/encryptor_mac.mm
   M /trunk/src/chrome/browser/password_manager/encryptor_unittest.cc
   M /trunk/src/chrome/browser/password_manager/encryptor_win.cc
   M /trunk/src/chrome/browser/password_manager/ie7_password.cc
   M /trunk/src/chrome/browser/password_manager/ie7_password.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.h
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.h
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_backend_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_id.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_restore.h
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/download_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/notification_method.cc
   M /trunk/src/chrome/browser/sync/notification_method.h
   M /trunk/src/chrome/browser/sync/notifier/base/mac/network_status_detector_task_mac.h
   M /trunk/src/chrome/browser/sync/notifier/base/mac/network_status_detector_task_mac_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/base/ssl_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/base/ssl_adapter.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.h
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util.h
   M /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/session_state.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.h
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac.h
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac.mm
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac_unittest.mm
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_columns.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/page_navigator.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/security_style.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_util.h
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.h
   M /trunk/src/chrome/browser/theme_resources_util.cc
   M /trunk/src/chrome/browser/theme_resources_util.h
   M /trunk/src/chrome/browser/theme_resources_util_unittest.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.cc
   M /trunk/src/chrome/browser/user_style_sheet_watcher.h
   M /trunk/src/chrome/browser/user_style_sheet_watcher_unittest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/appcache_info_view.cc
   M /trunk/src/chrome/browser/views/appcache_info_view.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/browser/views/database_info_view.cc
   M /trunk/src/chrome/browser/views/database_info_view.h
   M /trunk/src/chrome/browser/views/database_open_info_view.cc
   M /trunk/src/chrome/browser/views/database_open_info_view.h
   M /trunk/src/chrome/browser/views/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/views/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/local_storage_info_view.cc
   M /trunk/src/chrome/browser/views/local_storage_info_view.h
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/automation_constants.cc
   M /trunk/src/chrome/common/automation_constants.h
   M /trunk/src/chrome/common/chrome_descriptors.h
   M /trunk/src/chrome/common/css_colors.h
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/common/edit_command.h
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/icon1.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/icon2.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/icon3.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/icon4.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/icon5.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_page_color/icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/i18n/getMessage/icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/pageAction/set_icon/icon1.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/pageAction/set_icon/icon2.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/camera.png
   M /trunk/src/chrome/common/extensions/docs/examples/api/windows/merge_windows/arrow_in.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/buildbot/chromium.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/buildbot/icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/gmail/icon_128.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/marker.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/news/news_action.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/news/news_icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/news_i18n/news_action.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/news_i18n/news_icon.png
   M /trunk/src/chrome/common/extensions/docs/examples/tutorials/getstarted/icon.png
   M /trunk/src/chrome/common/extensions/docs/images/browser-action.png
   M /trunk/src/chrome/common/extensions/docs/images/buildbot-capture.png
   M /trunk/src/chrome/common/extensions/docs/images/google-mail-checker-capture.png
   M /trunk/src/chrome/common/extensions/docs/images/icon.png
   M /trunk/src/chrome/common/extensions/docs/images/index/gmail.png
   M /trunk/src/chrome/common/extensions/docs/images/index/news.png
   M /trunk/src/chrome/common/extensions/docs/images/index/rss.png
   M /trunk/src/chrome/common/extensions/docs/images/intermediate/bookmarks.png
   M /trunk/src/chrome/common/extensions/docs/images/intermediate/hello-world.png
   M /trunk/src/chrome/common/extensions/docs/images/intermediate/tabs.png
   M /trunk/src/chrome/common/extensions/docs/images/intermediate/themes-1.jpg
   M /trunk/src/chrome/common/extensions/docs/images/intermediate/themes-2.jpg
   M /trunk/src/chrome/common/extensions/docs/images/intermediate/themes-3.jpg
   M /trunk/src/chrome/common/extensions/docs/images/intermediate/windows.png
   M /trunk/src/chrome/common/extensions/docs/images/subscribe-cap1.png
   M /trunk/src/chrome/common/extensions/docs/images/subscribe-cap2.png
   M /trunk/src/chrome/common/extensions/docs/images/tabs.png
   M /trunk/src/chrome/common/extensions/docs/images/windows.png
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/extension_action_unittest.cc
   M /trunk/src/chrome/common/native_window_notification_source.h
   M /trunk/src/chrome/common/net/net_resource_provider.cc
   M /trunk/src/chrome/common/net/net_resource_provider.h
   M /trunk/src/chrome/common/net/socket_stream.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/owned_widget_gtk.h
   M /trunk/src/chrome/common/page_zoom.h
   M /trunk/src/chrome/common/process_watcher_mac.cc
   M /trunk/src/chrome/common/process_watcher_unittest.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac_unittest.mm
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/common/zip.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx_context.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_glx_context.h
   M /trunk/src/chrome/gpu/gpu_backing_store_win.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_win.h
   M /trunk/src/chrome/gpu/gpu_view_x.cc
   M /trunk/src/chrome/gpu/gpu_view_x.h
   M /trunk/src/chrome/gpu/x_util.h
   M /trunk/src/chrome/installer/mini_installer/mini_installer.ico
   M /trunk/src/chrome/installer/mini_installer.gyp
   M /trunk/src/chrome/installer/setup/run_all_unittests.cc
   M /trunk/src/chrome/installer/setup/setup.ico
   M /trunk/src/chrome/installer/setup/setup_util.h
   M /trunk/src/chrome/installer/setup/setup_util_unittest.cc
   M /trunk/src/chrome/installer/util/browser_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/installer_util_unittests_resource.h
   M /trunk/src/chrome/installer/util/lzma_util_unittest.cc
   M /trunk/src/chrome/installer/util/self_reg_work_item.cc
   M /trunk/src/chrome/installer/util/self_reg_work_item.h
   M /trunk/src/chrome/profile_import/profile_import_main.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.cc
   M /trunk/src/chrome/profile_import/profile_import_thread.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/chrome/renderer/extensions/js_only_v8_extensions.cc
   M /trunk/src/chrome/renderer/extensions/js_only_v8_extensions.h
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.h
   M /trunk/src/chrome/renderer/mock_keyboard.cc
   M /trunk/src/chrome/renderer/mock_keyboard.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process_impl.cc
   M /trunk/src/chrome/renderer/render_process_impl.h
   M /trunk/src/chrome/renderer/render_view_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_unittest.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.h
   M /trunk/src/chrome/test/chrome_process_util_uitest.cc
   M /trunk/src/chrome/test/data/dromaeo/favicon.ico
   M /trunk/src/chrome/test/data/dromaeo/favicon.png
   M /trunk/src/chrome/test/data/dromaeo/images/bg.png
   M /trunk/src/chrome/test/data/dromaeo/images/clouds.png
   M /trunk/src/chrome/test/data/dromaeo/images/clouds2.png
   M /trunk/src/chrome/test/data/dromaeo/images/comets.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino1.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino2.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino3.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino4.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino5.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino6.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino7.png
   M /trunk/src/chrome/test/data/dromaeo/images/dino8.png
   M /trunk/src/chrome/test/data/dromaeo/images/left.png
   M /trunk/src/chrome/test/data/dromaeo/images/logo.png
   M /trunk/src/chrome/test/data/dromaeo/images/logo2.png
   M /trunk/src/chrome/test/data/dromaeo/images/logo3.png
   M /trunk/src/chrome/test/data/dromaeo/images/right.png
   M /trunk/src/chrome/test/data/dromaeo/images/top.png
   M /trunk/src/chrome/test/data/dromaeo/images/water.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/icon.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon2.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/chromium.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/remove_popup/icon.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon1.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon2.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon3.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon4.png
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon5.png
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/add_popup/icon.png
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/icon.png
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/icon.png
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/icon.png
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/remove_popup/icon.png
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/icon_128.png
   M /trunk/src/chrome/test/data/extensions/icon1.png
   M /trunk/src/chrome/test/data/extensions/icon2.png
   M /trunk/src/chrome/test/data/extensions/icon_size_test/icon.png
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/feed-icon-128x128.png
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/proto_extension_validator.h
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h
   M /trunk/src/chrome/test/sync/engine/test_syncable_utils.cc
   M /trunk/src/chrome/test/sync/engine/test_syncable_utils.h
   M /trunk/src/chrome/test/sync/test_http_bridge_factory.h
   M /trunk/src/chrome_frame/support.gyp
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.h
   M /trunk/src/chrome_frame/test/perf/silverlight.cc
   M /trunk/src/courgette/adjustment_method.h
   M /trunk/src/courgette/adjustment_method_unittest.cc
   M /trunk/src/courgette/assembly_program.h
   M /trunk/src/courgette/crc.h
   M /trunk/src/courgette/difference_estimator.cc
   M /trunk/src/courgette/difference_estimator.h
   M /trunk/src/courgette/disassembler.cc
   M /trunk/src/courgette/disassembler.h
   M /trunk/src/courgette/ensemble.cc
   M /trunk/src/courgette/ensemble.h
   M /trunk/src/courgette/ensemble_create.cc
   M /trunk/src/courgette/image_info.h
   M /trunk/src/courgette/memory_monitor.cc
   M /trunk/src/courgette/region.h
   M /trunk/src/courgette/simple_delta.cc
   M /trunk/src/courgette/simple_delta.h
   M /trunk/src/courgette/third_party/bsdiff.h
   M /trunk/src/courgette/third_party/bsdiff_apply.cc
   M /trunk/src/courgette/third_party/bsdiff_create.cc
   M /trunk/src/courgette/win32_x86_generator.h
   M /trunk/src/courgette/win32_x86_patcher.h
   M /trunk/src/gears/gears.gyp
   M /trunk/src/ipc/ipc.gyp
   M /trunk/src/ipc/ipc_descriptors.h
   M /trunk/src/ipc/ipc_message_unittest.cc
   M /trunk/src/ipc/ipc_switches.cc
   M /trunk/src/ipc/ipc_switches.h
   M /trunk/src/media/audio/linux/alsa_wrapper.cc
   M /trunk/src/media/audio/linux/alsa_wrapper.h
   M /trunk/src/media/base/clock_impl.h
   M /trunk/src/media/base/clock_impl_unittest.cc
   M /trunk/src/media/base/media_switches.cc
   M /trunk/src/media/base/media_switches.h
   M /trunk/src/media/base/mock_filters.cc
   M /trunk/src/media/base/mock_reader.h
   M /trunk/src/media/ffmpeg/file_protocol.h
   M /trunk/src/media/filters/audio_renderer_algorithm_ola_unittest.cc
   M /trunk/src/media/omx/mock_omx.cc
   M /trunk/src/media/omx/mock_omx.h
   M /trunk/src/media/omx/omx_codec_unittest.cc
   M /trunk/src/media/omx/omx_configurator.cc
   M /trunk/src/media/omx/omx_configurator.h
   M /trunk/src/media/omx/omx_input_buffer.cc
   M /trunk/src/media/omx/omx_input_buffer.h
   M /trunk/src/media/omx/omx_input_buffer_unittest.cc
   M /trunk/src/media/omx/omx_output_sink.h
   M /trunk/src/media/omx/omx_unittest.cc
   M /trunk/src/media/omx/run_all_unittests.cc
   M /trunk/src/media/tools/omx_test/color_space_util.cc
   M /trunk/src/media/tools/omx_test/color_space_util.h
   M /trunk/src/media/tools/omx_test/file_reader_util.h
   M /trunk/src/media/tools/omx_test/file_sink.cc
   M /trunk/src/media/tools/omx_test/file_sink.h
   M /trunk/src/media/tools/omx_test/omx_test.cc
   M /trunk/src/media/tools/player_wtl/player_wtl.ico
   M /trunk/src/media/tools/player_wtl/wtl_renderer.h
   M /trunk/src/media/tools/player_x11/gl_video_renderer.cc
   M /trunk/src/media/tools/player_x11/gl_video_renderer.h
   M /trunk/src/media/tools/player_x11/gles_video_renderer.cc
   M /trunk/src/media/tools/player_x11/gles_video_renderer.h
   M /trunk/src/media/tools/player_x11/player_x11.cc
   M /trunk/src/media/tools/player_x11/x11_video_renderer.cc
   M /trunk/src/media/tools/player_x11/x11_video_renderer.h
   M /trunk/src/net/base/cert_verifier.cc
   M /trunk/src/net/base/cert_verifier.h
   M /trunk/src/net/base/dns_util_unittest.cc
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/filter_unittest.h
   M /trunk/src/net/base/https_prober.cc
   M /trunk/src/net/base/https_prober.h
   M /trunk/src/net/base/mock_network_change_notifier.h
   M /trunk/src/net/base/net_test_constants.h
   M /trunk/src/net/base/network_change_notifier.cc
   M /trunk/src/net/base/network_change_notifier.h
   M /trunk/src/net/base/network_change_notifier_linux.cc
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.cc
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_netlink_linux.cc
   M /trunk/src/net/base/network_change_notifier_netlink_linux.h
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/base/network_change_notifier_win.h
   M /trunk/src/net/base/platform_mime_util_win.cc
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/base/ssl_client_auth_cache.cc
   M /trunk/src/net/base/ssl_client_auth_cache.h
   M /trunk/src/net/base/test_certificate_data.h
   M /trunk/src/net/ftp/ftp_auth_cache.cc
   M /trunk/src/net/ftp/ftp_auth_cache.h
   M /trunk/src/net/ftp/ftp_server_type_histograms.h
   M /trunk/src/net/ftp/ftp_util.h
   M /trunk/src/net/http/http_auth_filter.cc
   M /trunk/src/net/http/http_auth_filter.h
   M /trunk/src/net/http/http_auth_filter_unittest.cc
   M /trunk/src/net/http/http_byte_range.cc
   M /trunk/src/net/http/http_byte_range.h
   M /trunk/src/net/http/http_byte_range_unittest.cc
   M /trunk/src/net/http/http_stream_parser.cc
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service.h
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/proxy/proxy_config_service_win.cc
   M /trunk/src/net/proxy/proxy_config_service_win.h
   M /trunk/src/net/proxy/proxy_info.cc
   M /trunk/src/net/proxy/proxy_info.h
   M /trunk/src/net/proxy/proxy_list.cc
   M /trunk/src/net/proxy/proxy_list.h
   M /trunk/src/net/proxy/proxy_list_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver.h
   M /trunk/src/net/proxy/proxy_retry_info.h
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_client_socket_win.h
   M /trunk/src/net/third_party/nss/nss.gyp
   M /trunk/src/net/third_party/nss/ssl/authcert.c
   M /trunk/src/net/third_party/nss/ssl/bodge/alghmac.h
   M /trunk/src/net/third_party/nss/ssl/bodge/blapi.h
   M /trunk/src/net/third_party/nss/ssl/bodge/ec.h
   M /trunk/src/net/third_party/nss/ssl/bodge/genload.c
   M /trunk/src/net/third_party/nss/ssl/bodge/loader.c
   M /trunk/src/net/third_party/nss/ssl/bodge/loader.h
   M /trunk/src/net/third_party/nss/ssl/bodge/nssrenam.h
   M /trunk/src/net/third_party/nss/ssl/bodge/secure_memcmp.c
   M /trunk/src/net/third_party/nss/ssl/cmpcert.c
   M /trunk/src/net/third_party/nss/ssl/derive.c
   M /trunk/src/net/third_party/nss/ssl/nsskea.c
   M /trunk/src/net/third_party/nss/ssl/os2_err.c
   M /trunk/src/net/third_party/nss/ssl/os2_err.h
   M /trunk/src/net/third_party/nss/ssl/preenc.h
   M /trunk/src/net/third_party/nss/ssl/prelib.c
   M /trunk/src/net/third_party/nss/ssl/ssl.h
   M /trunk/src/net/third_party/nss/ssl/ssl3con.c
   M /trunk/src/net/third_party/nss/ssl/ssl3ecc.c
   M /trunk/src/net/third_party/nss/ssl/ssl3ext.c
   M /trunk/src/net/third_party/nss/ssl/ssl3gthr.c
   M /trunk/src/net/third_party/nss/ssl/ssl3prot.h
   M /trunk/src/net/third_party/nss/ssl/sslauth.c
   M /trunk/src/net/third_party/nss/ssl/sslcon.c
   M /trunk/src/net/third_party/nss/ssl/ssldef.c
   M /trunk/src/net/third_party/nss/ssl/sslenum.c
   M /trunk/src/net/third_party/nss/ssl/sslerr.c
   M /trunk/src/net/third_party/nss/ssl/sslerr.h
   M /trunk/src/net/third_party/nss/ssl/sslgathr.c
   M /trunk/src/net/third_party/nss/ssl/sslimpl.h
   M /trunk/src/net/third_party/nss/ssl/sslinfo.c
   M /trunk/src/net/third_party/nss/ssl/sslmutex.c
   M /trunk/src/net/third_party/nss/ssl/sslmutex.h
   M /trunk/src/net/third_party/nss/ssl/sslnonce.c
   M /trunk/src/net/third_party/nss/ssl/sslproto.h
   M /trunk/src/net/third_party/nss/ssl/sslreveal.c
   M /trunk/src/net/third_party/nss/ssl/sslsecur.c
   M /trunk/src/net/third_party/nss/ssl/sslsnce.c
   M /trunk/src/net/third_party/nss/ssl/sslsock.c
   M /trunk/src/net/third_party/nss/ssl/sslt.h
   M /trunk/src/net/third_party/nss/ssl/ssltrace.c
   M /trunk/src/net/third_party/nss/ssl/sslver.c
   M /trunk/src/net/third_party/nss/ssl/unix_err.c
   M /trunk/src/net/third_party/nss/ssl/unix_err.h
   M /trunk/src/net/third_party/nss/ssl/win32err.c
   M /trunk/src/net/third_party/nss/ssl/win32err.h
   M /trunk/src/net/tools/fetch/fetch_server.cc
   M /trunk/src/net/tools/fetch/http_listen_socket.cc
   M /trunk/src/net/tools/fetch/http_server.cc
   M /trunk/src/net/tools/fetch/http_server.h
   M /trunk/src/net/tools/fetch/http_server_request_info.h
   M /trunk/src/net/tools/fetch/http_server_response_info.h
   M /trunk/src/net/tools/fetch/http_session.cc
   M /trunk/src/net/tools/spdyshark/moduleinfo.h
   M /trunk/src/net/tools/spdyshark/packet-spdy.c
   M /trunk/src/net/tools/spdyshark/packet-spdy.h
   M /trunk/src/net/url_request/request_tracker.h
   M /trunk/src/net/url_request/request_tracker_unittest.cc
   M /trunk/src/net/websockets/websocket.h
   M /trunk/src/o3d/import/test_data/crate.jpg
   M /trunk/src/o3d/installer/mac/O3D_Stats/O3D_StatsPane.m
   M /trunk/src/o3d/samples/GoogleIO-2009/assets/colorbar.png
   M /trunk/src/o3d/samples/assets/four_pixel.png
   M /trunk/src/o3d/samples/assets/hi.jpg
   M /trunk/src/o3d/samples/assets/old-school-shadow.png
   M /trunk/src/o3d/samples/assets/rock_bumps.jpg
   M /trunk/src/o3d/samples/assets/rock_texture.jpg
   M /trunk/src/o3d/samples/assets/shaving_cream.jpg
   M /trunk/src/o3d/samples/assets/shaving_cream_300x300.jpg
   M /trunk/src/o3d/samples/assets/texture_b3.jpg
   M /trunk/src/o3d/samples/beachdemo/assets/pe_fire.jpg
   M /trunk/src/o3d/samples/home-configurators/cb_images/cb_item_thumbnails.jpg
   M /trunk/src/o3d/samples/home-configurators/craftsmanassets/craftsman_item_thumbnails.jpg
   M /trunk/src/o3d/samples/home-configurators/searsassets/sears_item_thumbnails.jpg
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/sprites2.jpg
   M /trunk/src/o3d/samples/io/ui/bgtile.jpg
   M /trunk/src/o3d/samples/io/ui/book_capbottom.jpg
   M /trunk/src/o3d/samples/io/ui/book_capleft.jpg
   M /trunk/src/o3d/samples/io/ui/book_capright.jpg
   M /trunk/src/o3d/samples/io/ui/book_captop.jpg
   M /trunk/src/o3d/samples/io/ui/book_cover.jpg
   M /trunk/src/o3d/samples/io/ui/book_innercover.jpg
   M /trunk/src/o3d/samples/io/ui/book_page1.jpg
   M /trunk/src/o3d/samples/io/ui/book_page2.jpg
   M /trunk/src/o3d/samples/io/ui/book_page3.jpg
   M /trunk/src/o3d/samples/io/ui/book_pageblank.jpg
   M /trunk/src/o3d/samples/trends/assets/clouds.jpg
   M /trunk/src/o3d/samples/trends/assets/earth-large.jpg
   M /trunk/src/o3d/samples/trends/assets/earth.jpg
   M /trunk/src/o3d/samples/trends/assets/moon.jpg
   M /trunk/src/o3d/samples/trends/assets/night-large.jpg
   M /trunk/src/o3d/samples/trends/assets/night.jpg
   M /trunk/src/o3d/samples/waterdemo/assets/rock_tile_normal_x.jpg
   M /trunk/src/o3d/samples/waterdemo/assets/rock_tile_rgb.jpg
   M /trunk/src/o3d/tests/archive_files/keyboard.jpg
   M /trunk/src/o3d/tests/bitmap_test/5kx5k.jpg
   M /trunk/src/o3d/tests/bitmap_test/jpeg-256x256.jpg
   M /trunk/src/o3d/tests/bitmap_test/png-20x14-4bit-palette.png
   M /trunk/src/o3d/tests/bitmap_test/png-2x2-24bit-drawimage-src.png
   M /trunk/src/o3d/tests/bitmap_test/png-4x4-24bit-drawimage-argb8-src.png
   M /trunk/src/o3d/tests/bitmap_test/png-4x4-24bit-drawimage-src.png
   M /trunk/src/o3d/tests/bitmap_test/png-8x4-24bit-drawimage-argb8-dest.png
   M /trunk/src/o3d/tests/bitmap_test/png-8x4-24bit-drawimage-dest.png
   M /trunk/src/o3d/tests/bitmap_test/png-8x8-24bit-drawimage-src.png
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h
   M /trunk/src/printing/pdf_ps_metafile_cairo_unittest.cc
   M /trunk/src/printing/printed_document_cairo.cc
   M /trunk/src/printing/printed_document_mac.cc
   M /trunk/src/printing/printed_document_win.cc
   M /trunk/src/printing/printing_context_cairo.cc
   M /trunk/src/printing/printing_context_mac.mm
   M /trunk/src/printing/units.cc
   M /trunk/src/printing/units.h
   M /trunk/src/printing/units_unittest.cc
   M /trunk/src/sandbox/linux/suid/suid_unsafe_environment_variables.h
   M /trunk/src/sandbox/sandbox_poc/sandbox.ico
   M /trunk/src/sdch/bsd/config.h
   M /trunk/src/skia/config/SkUserConfig.h
   M /trunk/src/skia/config/win/stdint.h
   M /trunk/src/skia/ext/bitmap_platform_device.h
   M /trunk/src/skia/ext/bitmap_platform_device_linux.cc
   M /trunk/src/skia/ext/bitmap_platform_device_linux.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/bitmap_platform_device_mac.h
   M /trunk/src/skia/ext/bitmap_platform_device_win.cc
   M /trunk/src/skia/ext/bitmap_platform_device_win.h
   M /trunk/src/skia/ext/canvas_paint_mac.h
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/platform_canvas.cc
   M /trunk/src/skia/ext/platform_canvas.h
   M /trunk/src/skia/ext/platform_canvas_linux.cc
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   M /trunk/src/skia/ext/platform_canvas_unittest.cc
   M /trunk/src/skia/ext/platform_canvas_win.cc
   M /trunk/src/skia/ext/platform_canvas_win.h
   M /trunk/src/skia/ext/platform_device.h
   M /trunk/src/skia/ext/platform_device_linux.cc
   M /trunk/src/skia/ext/platform_device_linux.h
   M /trunk/src/skia/ext/platform_device_mac.cc
   M /trunk/src/skia/ext/platform_device_mac.h
   M /trunk/src/skia/ext/platform_device_win.cc
   M /trunk/src/skia/ext/platform_device_win.h
   M /trunk/src/skia/ext/skia_utils_win.cc
   M /trunk/src/skia/ext/skia_utils_win.h
   M /trunk/src/skia/ext/vector_canvas.cc
   M /trunk/src/skia/ext/vector_canvas.h
   M /trunk/src/skia/ext/vector_canvas_linux.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/skia/ext/vector_canvas_win.cc
   M /trunk/src/skia/ext/vector_platform_device.h
   M /trunk/src/skia/ext/vector_platform_device_linux.cc
   M /trunk/src/skia/ext/vector_platform_device_linux.h
   M /trunk/src/skia/ext/vector_platform_device_win.cc
   M /trunk/src/skia/ext/vector_platform_device_win.h
   M /trunk/src/third_party/ffmpeg/ffmpeg.gyp
   M /trunk/src/tools/imagediff/image_diff.gyp
   M /trunk/src/tools/xdisplaycheck/xdisplaycheck.cc
   M /trunk/src/tools/xdisplaycheck/xdisplaycheck.gyp
   M /trunk/src/views/controls/button/button.cc
   M /trunk/src/views/controls/button/button.h
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/button_dropdown.h
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/button/checkbox.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/custom_button.h
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/radio_button.cc
   M /trunk/src/views/controls/button/radio_button.h
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/controls/menu/controller.h
   M /trunk/src/views/controls/menu/menu.cc
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_delegate.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/menu_win.h
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/menu/submenu_view.h
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/message_box_view.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native/native_view_host_win.h
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scroll_view.cc
   M /trunk/src/views/controls/scroll_view.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar.h
   M /trunk/src/views/controls/scrollbar/scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/scroll_bar.h
   M /trunk/src/views/controls/separator.cc
   M /trunk/src/views/controls/separator.h
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/single_split_view.h
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc
   M /trunk/src/views/controls/tabbed_pane/tabbed_pane.h
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_unittest.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/controls/throbber.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/fill_layout.cc
   M /trunk/src/views/focus/accelerator_handler.h
   M /trunk/src/views/focus/external_focus_tracker.cc
   M /trunk/src/views/focus/external_focus_tracker.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/focus/focus_util_win.h
   M /trunk/src/views/focus/view_storage.cc
   M /trunk/src/views/focus/view_storage.h
   M /trunk/src/views/views_delegate.h
   M /trunk/src/views/widget/aero_tooltip_manager.cc
   M /trunk/src/views/widget/aero_tooltip_manager.h
   M /trunk/src/views/widget/drop_helper.cc
   M /trunk/src/views/widget/drop_helper.h
   M /trunk/src/views/widget/drop_target_win.cc
   M /trunk/src/views/widget/drop_target_win.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/root_view_gtk.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/tooltip_manager.h
   M /trunk/src/views/widget/tooltip_manager_win.cc
   M /trunk/src/views/widget/tooltip_manager_win.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_delegate.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/client_view.cc
   M /trunk/src/views/window/client_view.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/dialog_delegate.cc
   M /trunk/src/views/window/dialog_delegate.h
   M /trunk/src/views/window/hit_test.h
   M /trunk/src/views/window/native_frame_view.cc
   M /trunk/src/views/window/native_frame_view.h
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_delegate.cc
   M /trunk/src/views/window/window_delegate.h
   M /trunk/src/views/window/window_resources.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/animations/3d/change-transform-in-end-event-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/animations/3d/state-at-end-event-transform-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/compositing/overflow/overflow-positioning-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/deleting/delete-br-013-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/indent-paragraphs-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/selectAll-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/pasteboard/paste-blockquote-after-blockquote-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/background-clip-text-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-border-radius-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/box-shadow/transform-fringing-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/clip/overflow-border-radius-clip-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css/attribute-selector-dynamic-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css/nested-layers-with-hover-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css/percent-top-value-with-relative-position-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css/rem-dynamic-scaling-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css/rem-units-on-root-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css-generated-content/beforeAfter-interdocument-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/caret-rtl-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/lists/w3-css3-list-styles-numeric-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/multicol/client-rects-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/block-no-inflow-children-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/repaint-during-scroll-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/bidi-AN-after-L-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/bidi-AN-after-empty-run-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/bidi-CS-after-AN-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/bidi-linebreak-001-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/bidi-linebreak-002-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/bidi-linebreak-003-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/complex-character-based-fallback-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/danda-space-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/hindi-spacing-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/khmer-selection-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/text/international/thai-baht-space-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/transforms/transformed-focused-text-input-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/media/audio-no-installed-engines-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/media/video-aspect-ratio-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/plugins/netscape-dom-access-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/text/foreignObject-text-clipping-bug-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/zoom/text/zoom-hixie-mixed-008-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/animations/3d/change-transform-in-end-event-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/animations/3d/state-at-end-event-transform-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/5138441-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/5481523-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/indent-selection-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/encoding/invalid-UTF-8-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/lists/w3-css3-list-styles-numeric-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/multicol/client-rects-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/repaint/block-no-inflow-children-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/repaint/line-flow-with-floats-1-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/repaint/line-flow-with-floats-6-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/repaint/repaint-during-scroll-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/video-aspect-ratio-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/video-layer-crash-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/video-transformed-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/text/foreignObject-text-clipping-bug-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/zoom/text/zoom-svg-float-border-padding-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/delete-br-013-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-blockquote-after-blockquote-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/background-clip-text-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/block-mask-overlay-image-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/fieldsetBorderRadius-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/inline-mask-overlay-image-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/box-shadow/transform-fringing-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/attribute-selector-dynamic-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/nested-floating-relative-position-percentages-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/positioned-overflow-scroll-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/rem-dynamic-scaling-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/rem-units-on-root-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/remove-shorthand-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/lists/w3-css3-list-styles-numeric-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/client-rects-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/block-no-inflow-children-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/repaint-during-scroll-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/media/audio-no-installed-engines-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/platform/mac/fast/forms/input-list-button-size-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/platform/qt/fast/events/event-sender-keydown-frame-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/text/foreignObject-text-clipping-bug-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/css2.1/t1202-counter-09-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/css2.1/t1202-counters-09-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/multicol/client-rects-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/bidi-embedding-pop-and-push-same-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/international/complex-character-based-fallback-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/international/danda-space-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/international/hindi-spacing-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/international/hindi-whitespace-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/international/khmer-selection-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/international/thai-baht-space-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/fast/text/international/thai-line-breaks-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win-xp/LayoutTests/svg/W3C-SVG-1.1/text-intro-05-t-expected.png
   M /trunk/src/webkit/default_plugin/default_plugin.ico
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.h
   M /trunk/src/webkit/extensions/v8/benchmarking_extension.h
   M /trunk/src/webkit/extensions/v8/heap_profiler_extension.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.h
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container.h
   M /trunk/src/webkit/glue/plugins/plugin_lib_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_unittest.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_posix.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_create_instance_in_paint.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_create_instance_in_paint.h
   M /trunk/src/webkit/glue/plugins/test/plugin_private_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_windowless_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_windowless_test.h
   M /trunk/src/webkit/glue/resources/linux-checkbox-disabled-off.png
   M /trunk/src/webkit/glue/resources/linux-checkbox-disabled-on.png
   M /trunk/src/webkit/glue/resources/linux-radio-disabled-off.png
   M /trunk/src/webkit/glue/resources/linux-radio-disabled-on.png
   M /trunk/src/webkit/glue/resources/media_slider_thumb.png
   M /trunk/src/webkit/glue/resources/media_volume_slider_thumb.png
   M /trunk/src/webkit/glue/webdropdata_win.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/websocketstreamhandle_bridge.h
   M /trunk/src/webkit/glue/websocketstreamhandle_impl.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/support/webkit_support.gyp
   M /trunk/src/webkit/tools/test_shell/accessibility_controller.h
   M /trunk/src/webkit/tools/test_shell/accessibility_ui_element.h
   M /trunk/src/webkit/tools/test_shell/resources/small.ico
   M /trunk/src/webkit/tools/test_shell/resources/test_shell.ico
   M /trunk/src/webkit/tools/test_shell/simple_socket_stream_bridge.cc
   M /trunk/src/webkit/tools/test_shell/simple_socket_stream_bridge.h
   M /trunk/src/webkit/tools/test_shell/test_shell_x11.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_x11.h

svn prop fixes.  Applied to all files not in third_party.
* Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type.
* Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF.

TBR=evanm
BUG=none
TEST=none

------------------------------------------------------------------------
r40981 | ananta@chromium.org | 2010-03-09 02:20:14 +0100 (Tue, 09 Mar 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Launching Chrome with a user-data-dir command line switch containing a non ASCII character in the
path like "Test Chrome Gï¿½ldine" would cause a DCHECK to fire in the
BrowserRenderProcessHost::AppendRendererCommandLine function while retrieving the
user-data-dir switch value from the browser's command line and setting it back to the renderer's
command line. This was because we would retrieve the value as ASCII which would not work because
of the presence of a non ASCII character in the value. The end result is that a CHECK fires in
the renderer when it tries to validate the existence of the user-data-dir path.

Fix is to use the CommandLine::GetSwitchValuePath function instead which returns a FilePath which
does the right thing.

Test=Covered by a ui test.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=29245

Bug=29245

Review URL: http://codereview.chromium.org/671027
------------------------------------------------------------------------
r40979 | estade@chromium.org | 2010-03-09 02:03:37 +0100 (Tue, 09 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   A /trunk/src/chrome/browser/gtk/hover_controller_gtk.cc (from /trunk/src/chrome/browser/gtk/throb_controller_gtk.cc:40919)
   A /trunk/src/chrome/browser/gtk/hover_controller_gtk.h (from /trunk/src/chrome/browser/gtk/throb_controller_gtk.h:40919)
   D /trunk/src/chrome/browser/gtk/throb_controller_gtk.cc
   D /trunk/src/chrome/browser/gtk/throb_controller_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/owned_widget_gtk.cc

GTK: Add hover effects for GtkChromeButtons.

Similar to the previous patch for CustomButtons.

BUG=36760
TEST=manual

Review URL: http://codereview.chromium.org/676001
------------------------------------------------------------------------
r40978 | estade@chromium.org | 2010-03-09 02:02:08 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: tweak where widget-anchored menus appear.

BUG=15443
TEST=see bug. Page/app menus + download item menus + bookmark bar menus should be fixed.

Review URL: http://codereview.chromium.org/672024
------------------------------------------------------------------------
r40977 | kinuko@chromium.org | 2010-03-09 01:58:30 +0100 (Tue, 09 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc

Fix file permissions in save_as mode on POSIX.

BUG=36107
TEST=Check 'Ask where to save each file before downloading' in 'Under the Hood' preference, start a download and check the file permission.

Review URL: http://codereview.chromium.org/672019
------------------------------------------------------------------------
r40976 | aa@chromium.org | 2010-03-09 01:56:12 +0100 (Tue, 09 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json

Update bookmark manager key. Accidentally copied Google
Translate's first time, which caused very interesting bugs.

This key was generated using pack extension, so should be
unique.

Review URL: http://codereview.chromium.org/680001
------------------------------------------------------------------------
r40974 | pvalchev@google.com | 2010-03-09 01:53:03 +0100 (Tue, 09 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/js_modal_dialog.h
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

BSD port: Another chunk of chrome/ ifdef changes
Review URL: http://codereview.chromium.org/652186
------------------------------------------------------------------------
r40973 | thakis@chromium.org | 2010-03-09 01:49:36 +0100 (Tue, 09 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm

Mac: Fix another crash in content exceptions dialog.

Also add a couple unit tests. Also fix another potential crash and other problems uncovered by the tests.

BUG=37208
TEST=See bug. Also, unittests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40810

Review URL: http://codereview.chromium.org/668046
------------------------------------------------------------------------
r40968 | stoyan@chromium.org | 2010-03-09 00:51:32 +0100 (Tue, 09 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

Avoid unregistering automation job twice.
Review URL: http://codereview.chromium.org/672016
------------------------------------------------------------------------
r40966 | pkasting@chromium.org | 2010-03-09 00:34:07 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_gtk.cc
   M /trunk/src/app/os_exchange_data_provider_gtk.h
   M /trunk/src/base/gfx/rect.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/button/button.cc
   M /trunk/src/views/controls/button/button.h
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/button_dropdown.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/custom_button.h
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_delegate.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/resize_gripper.cc
   M /trunk/src/views/controls/resize_gripper.h
   M /trunk/src/views/controls/scroll_view.cc
   M /trunk/src/views/controls/scroll_view.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.h
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/single_split_view.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/drag_utils.h
   M /trunk/src/views/drag_utils_gtk.cc
   M /trunk/src/views/drag_utils_win.cc
   M /trunk/src/views/examples/scroll_view_example.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/tooltip_manager_gtk.cc
   M /trunk/src/views/widget/tooltip_manager_win.cc
   M /trunk/src/views/widget/widget_gtk.cc

Replace lots of "int x, int y" with gfx::Point.  Also use gfx::Size and gfx::Rect in a few more places.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669130
------------------------------------------------------------------------
r40964 | jhawkins@chromium.org | 2010-03-09 00:28:58 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/encoding_menu_controller.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_unittest.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   M /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   M /trunk/src/chrome/tools/convert_dict/convert_dict_unittest.cc

chrome 6: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/671025
------------------------------------------------------------------------
r40963 | jhawkins@chromium.org | 2010-03-09 00:28:41 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/input_window_dialog_gtk.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/password_manager/encryptor_linux.cc
   M /trunk/src/chrome/browser/password_manager/encryptor_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc

chrome 5: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/671024
------------------------------------------------------------------------
r40962 | xiyuan@chromium.org | 2010-03-09 00:28:35 +0100 (Tue, 09 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/views/window/window_delegate.cc
   M /trunk/src/views/window/window_delegate.h
   M /trunk/src/views/window/window_win.cc

Use web app icon as ICON_BIG for Windows

- Add a WindowDelegate::GetWindowAppIcon for BrowserView to expose an
  icon to use as ICON_BIG;
- Add an app_icon_ memeber and accessor functions to TabContents;
- Update/Set the app_icon_ of TabContents when web app icon is
  downloaded for converting a tab to app or for chrome web app shortcuts
  update (this happens when chrome is opened as an app;
- Use the app icon as ICON_BIG in WindowWin::UpdateWindowIcon;

BUG=32039
TEST=Verify fix for issue 32039 and also Alt-Tab list on XP/Vista uses big icon.

Review URL: http://codereview.chromium.org/668265
------------------------------------------------------------------------
r40961 | mpcomplete@chromium.org | 2010-03-09 00:25:12 +0100 (Tue, 09 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js

Expose 'type' and 'incognito' bits to the extension window object, and make
them settable in chrome.windows.create().

BUG=12658
BUG=28599

Review URL: http://codereview.chromium.org/669189
------------------------------------------------------------------------
r40960 | jhawkins@chromium.org | 2010-03-09 00:12:48 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_drag.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc

chrome 4: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/671019
------------------------------------------------------------------------
r40959 | jhawkins@chromium.org | 2010-03-09 00:12:15 +0100 (Tue, 09 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_tree.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/net/browser_url_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/net/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/pref_service.cc
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc

chrome 3: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/671014
------------------------------------------------------------------------
r40955 | eroman@chromium.org | 2010-03-08 23:52:11 +0100 (Mon, 08 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h

Fix a crash due to CHECK() hit in SafeBrowsingResourceHandler.

The problem was the CHECK() doesn't apply when the resource request has been cancelled via the interstitial page -- if you close the tab displaying the warning, the request is cancelled leading to OnResponseCompleted() firing with an error status, so state_ == STATE_DISPLAYING_BLOCKING_PAGE.
Also made sure this code path handles cancellation of any outstanding url check.

BUG=37674
TEST=Open a URL that causes the safe browsing warning page to be display. Now close the tab containing the warning; should not crash.

Review URL: http://codereview.chromium.org/671009
------------------------------------------------------------------------
r40950 | pkasting@chromium.org | 2010-03-08 23:11:01 +0100 (Mon, 08 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h

Clean up/fix more frame code.  In general this is bringing the less-common frame classes up to speed with recent changes in OpaqueBrowserFrameView, but there's also some other fixing of bustage, old patches that didn't make it into all the classes, etc.

This isn't perfect yet: the calculations of icon and titlebar size/position for really large icons need to have more padding in them.  But this change is already so large I'd rather get it in and then patch that up.

BUG=6961
TEST=Sysmenu works on all frame types, app panels can be maximized, all frame types handle larger titlebar sizes and/or fonts
Review URL: http://codereview.chromium.org/669291
------------------------------------------------------------------------
r40949 | rohitrao@chromium.org | 2010-03-08 23:06:04 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac] When scrolling a webpage, invalidate the web content area instead of painting immediately.  This should prevent us from painting twice per scroll event.

BUG=37442
TEST=See scrolling test case in bug 28947, comment 29.  Should match Safari, not be jerky.
Review URL: http://codereview.chromium.org/668093
------------------------------------------------------------------------
r40947 | scherkus@chromium.org | 2010-03-08 23:02:09 +0100 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h

Propagate logging command line switches from browser process to GPU process.

BUG=33329
TEST=try out --log-level=0, you should see log messages

Review URL: http://codereview.chromium.org/668195
------------------------------------------------------------------------
r40945 | jhawkins@chromium.org | 2010-03-08 22:49:15 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/language_order_table_model.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc

chrome 2: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/672007
------------------------------------------------------------------------
r40944 | rohitrao@chromium.org | 2010-03-08 22:47:59 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm

[Mac] Lock bar visibility during a bookmark button drag, forcing the fullscreen overlay to stay shown.

BUG=37433
TEST=Go fullscreen.  Open a folder on the bookmark bar and drag a button around such that the folder closes.  The overlay should not disappear.
Review URL: http://codereview.chromium.org/669166
------------------------------------------------------------------------
r40942 | shess@chromium.org | 2010-03-08 22:43:16 +0100 (Mon, 08 Mar 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Refactor chunk ownership in SafeBrowsing code.

This attempts to clean up ownership so that it's more clear who
creates and deletes the chunk data between parsing and storage in the
database.  SBChunkList replaces std::deque<SBChunk>, mostly to add
correct cleanup in the destructor rather than requiring FreeChunks()
to be called manually.  Additionally remove deletion of chunk info
from the database layer, now it processes const data.

Additionally remove the need for SafeBrowsingDatabase to have a
chunk-inserted callback by having the caller handle it directly.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/668123
------------------------------------------------------------------------
r40941 | gregoryd@google.com | 2010-03-08 22:41:28 +0100 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/nacl/broker_thread.cc
   M /trunk/src/chrome/nacl/broker_thread.h

Terminate NaCl broker process when no loader processes are running
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40744
Review URL: http://codereview.chromium.org/669019
------------------------------------------------------------------------
r40937 | jhawkins@chromium.org | 2010-03-08 22:21:36 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/js_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/spellchecker_platform_engine_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_gtk.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.cc
   M /trunk/src/chrome/test/ui/javascript_test_util.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

chrome 1: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/672001
------------------------------------------------------------------------
r40933 | estade@chromium.org | 2010-03-08 22:05:29 +0100 (Mon, 08 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Windows: fix some graphical glitches with render view deemphasis.

This doesn't fix bullet points 3 or 4 from the bug report, which are cross-platform. This only fixes the windows-specific painting issues.

BUG=37563
TEST=manual

Review URL: http://codereview.chromium.org/669228
------------------------------------------------------------------------
r40932 | davemoore@chromium.org | 2010-03-08 21:53:06 +0100 (Mon, 08 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/cros_library.h
   M /trunk/src/chrome/browser/chromeos/cros/login_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/login_library.h
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/mount_library.h
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/cros/power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/power_library.h
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_window.cc
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc

Use new libcros loading api to display better error messages.
Also remove all EnsureLoaded() methods except one.

Review URL: http://codereview.chromium.org/671004
------------------------------------------------------------------------
r40927 | jhawkins@chromium.org | 2010-03-08 21:04:54 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/common/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/common/time_format.cc

chrome/common: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668244
------------------------------------------------------------------------
r40922 | jorlow@chromium.org | 2010-03-08 20:37:07 +0100 (Mon, 08 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h

Revert 40920 - Use the WebViewClient* passed in from the StorageAreaProxy instead of using
RenderThread::RoutingIDForCurrentContext() whenever possible.  In addition,
call OnContentBlocked directly from within the browser instead of sending
another IPC message.  Lastly, make sure that we don't crash in the event
that we can't determine the routing id.

WebKit side: https://bugs.webkit.org/show_bug.cgi?id=35758

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/669084

TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/669293
------------------------------------------------------------------------
r40921 | jschuh@google.com | 2010-03-08 20:29:41 +0100 (Mon, 08 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/net/base/dns_util.cc
   M /trunk/src/net/base/dns_util.h

Correctly handle trailing dots in hostname blacklist. 

Submitted for inferno@chromium.org

BUG=35510
TEST=HostContentSettingsMapTest.HostTrimEndingDotCheck

Review URL: http://codereview.chromium.org/669284
------------------------------------------------------------------------
r40920 | jorlow@chromium.org | 2010-03-08 20:28:32 +0100 (Mon, 08 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h

Use the WebViewClient* passed in from the StorageAreaProxy instead of using
RenderThread::RoutingIDForCurrentContext() whenever possible.  In addition,
call OnContentBlocked directly from within the browser instead of sending
another IPC message.  Lastly, make sure that we don't crash in the event
that we can't determine the routing id.

WebKit side: https://bugs.webkit.org/show_bug.cgi?id=35758

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/669084
------------------------------------------------------------------------
r40914 | cpu@chromium.org | 2010-03-08 19:42:25 +0100 (Mon, 08 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc

Add support for auto-installing extensions at first run via master prefs

This a even lower impact method, with no new fields added. 

This is how it works: 
1- The extension pared down manifest goes into the master prefs 
2- The master prefs become the prefs at first run 
3- First run notices an extensions block, an triggers an extensions check
4- The full extension gets updated then 

BUG=37573
TEST=ut included, also see bug


Review URL: http://codereview.chromium.org/669218
------------------------------------------------------------------------
r40908 | skrul@chromium.org | 2010-03-08 19:01:59 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/autofill_model_associator_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Fix KeyToTag and add unit test

BUG=37559

Review URL: http://codereview.chromium.org/669211
------------------------------------------------------------------------
r40906 | viettrungluu@chromium.org | 2010-03-08 18:56:29 +0100 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/view_resizer.h
   M /trunk/src/chrome/browser/cocoa/view_resizer_pong.h
   M /trunk/src/chrome/browser/cocoa/view_resizer_pong.mm

Mac: clean-up of incognito badge code and float -> CGFloat.

BUG=none
TEST=everything still builds and works

Review URL: http://codereview.chromium.org/669277
------------------------------------------------------------------------
r40905 | rsesek@chromium.org | 2010-03-08 18:44:48 +0100 (Mon, 08 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm

[Mac] Minor adjustments to the history menu, per the UI team.

* Increase the number of Recently Closed items to 10.
* Move the "Show Full History" item to be at the end of the menu (XIB change).

BUG=37209
TEST=Open and navigate 12 tabs. Close 10 of them; History menu should be full. Close one more; history menu stays at 10.
TEST="Show Full History" is the last item in the menu.

Review URL: http://codereview.chromium.org/660438
------------------------------------------------------------------------
r40904 | skrul@chromium.org | 2010-03-08 18:33:19 +0100 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Add unit test for the "aborted by shutdown" case.
This unit test would crash the code that is on the current dev branch, however with the addition of the DataTypeManager this is no longer a problem on trunk.  In the dev version, the PSS would try to try to stop a data type in mid startp causing it to abort, which then rasies and error and tries to stop the same data type again.  With the DTM, it knows how to handle aborting a data type startup at shutdown by not letting an aborted stop raise an error.

BUG=37243

Review URL: http://codereview.chromium.org/668183
------------------------------------------------------------------------
r40903 | dhg@chromium.org | 2010-03-08 18:33:03 +0100 (Mon, 08 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing extension install case.  Changing the file browser to only get the list of current downloads, not the history.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669186
------------------------------------------------------------------------
r40901 | sky@chromium.org | 2010-03-08 18:10:10 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.h

Adds display name and image to UserManager::User.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668193
------------------------------------------------------------------------
r40899 | pinkerton@google.com | 2010-03-08 18:05:25 +0100 (Mon, 08 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Fix possible race condition with updating close-tab/window key equivalents from a thread that's not the main thread. Go back to performSelector:withObject:afterDelay: if we are on the main thread because moving to performSelectorOnMainThread: made drag and drop really janky.
BUG=37111, 37091, 32786
TEST=close-window/close tab command key regression testing, visuals dragging a tab should suck less.
Review URL: http://codereview.chromium.org/668260
------------------------------------------------------------------------
r40897 | stoyan@chromium.org | 2010-03-08 17:26:11 +0100 (Mon, 08 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/chrome_launcher.cc

ChromeFrame now uses host provided popup blocker.
It does not work in all scenarions since from Chrome side an empty string is passed as target url.
Note in IE6 "Tools/Popup Blocker" menu is not visible if ChromeFrame is the activedocument. Have to support some IOleCommandTarget command..

BUG=34823

Review URL: http://codereview.chromium.org/668168
------------------------------------------------------------------------
r40896 | sky@chromium.org | 2010-03-08 17:16:19 +0100 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/wm_message_listener.cc
   M /trunk/src/chrome/browser/chromeos/wm_message_listener.h

Adds the ability to observer messages from the window manager.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/668192
------------------------------------------------------------------------
r40894 | mseaborn@chromium.org | 2010-03-08 13:55:57 +0100 (Mon, 08 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Zygote: Clarify relationship between HandleForkRequest() and ChromeMain()

HandleForkRequest() returns to ChromeMain() multiple times, once per
fork().  Add comments to indicate this, because this type of control
flow is unusual.

HandleReapRequest() and HandleDidProcessCrash() never spawn a new
renderer, so remove the possibility that these can do "return true" to
do so.

Review URL: http://codereview.chromium.org/669065
------------------------------------------------------------------------
r40891 | joth@chromium.org | 2010-03-08 12:11:24 +0100 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.h
   M /trunk/src/chrome/chrome_browser.gypi

Add support for geolocation wifi scanning on OSX 10.6

BUG=http://crbug.com/37198
TEST=Run browser with --enable-geolocation on OSX 10.6, open maps.google.com

Review URL: http://codereview.chromium.org/669083
------------------------------------------------------------------------
r40884 | tony@chromium.org | 2010-03-08 08:37:46 +0100 (Mon, 08 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/user_style_sheet_watcher_unittest.cc

Fix a memory leak in the new unittest.

TBR=darin

Review URL: http://codereview.chromium.org/668250
------------------------------------------------------------------------
r40882 | tony@chromium.org | 2010-03-08 06:18:06 +0100 (Mon, 08 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   A /trunk/src/chrome/browser/user_style_sheet_watcher.cc
   A /trunk/src/chrome/browser/user_style_sheet_watcher.h
   A /trunk/src/chrome/browser/user_style_sheet_watcher_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/webkit/glue/webpreferences.h

First cut at custom user style sheets.

Enabled with the --enable-user-stylesheet flag which
causes chrome to read
<user-data-dir>/<profile>/User StyleSheet/Custom.css
at startup and set it as the user style sheet.

This version never reloads the user style sheet, I'll
have to bring back FileWatcher for that.  I also put the user
stylesheet in a subdir because the implementation of
FileWatcher will watch the parent dir (this is what the OS
apis give me) and watching the profile dir will cause
lots of activity.

BUG=2393

Review URL: http://codereview.chromium.org/660349
------------------------------------------------------------------------
r40881 | arv@chromium.org | 2010-03-08 05:55:17 +0100 (Mon, 08 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc

Fix missing favicon for chrome://extensions/

It was mistakenly removed in r40468.

BUG=None
TEST=None
TBR=aa@chromium.org

Review URL: http://codereview.chromium.org/669261
------------------------------------------------------------------------
r40880 | yusukes@chromium.org | 2010-03-08 05:49:54 +0100 (Mon, 08 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/language_library.cc

Automatically recovers an IME connection.

Depends on: http://codereview.chromium.org/668142

BUG=crosbug.com/1768
TEST=see the bug

Review URL: http://codereview.chromium.org/668144
------------------------------------------------------------------------
r40879 | yusukes@chromium.org | 2010-03-08 05:47:22 +0100 (Mon, 08 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc

Remove obsolete TODOs. No code change.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/668238
------------------------------------------------------------------------
r40876 | jhawkins@chromium.org | 2010-03-07 22:44:29 +0100 (Sun, 07 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_field.cc
   M /trunk/src/chrome/browser/autofill/autofill_field.h
   A /trunk/src/chrome/browser/autofill/autofill_field_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add tests for AutoFillField.

BUG=none
TEST=AutoFillFieldTest
Review URL: http://codereview.chromium.org/669203
------------------------------------------------------------------------
r40872 | jhawkins@chromium.org | 2010-03-07 21:53:33 +0100 (Sun, 07 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/cpp_bound_class.cc
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webframe_unittest.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webpreferences.cc

Reland r40855 with chromeos fix.

webkit/glue: string_util.h -> utf_string_conversions.h fix.

TBR=bradnelson
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668242
------------------------------------------------------------------------
r40867 | jeremy@chromium.org | 2010-03-07 13:14:35 +0100 (Sun, 07 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/utility.sb
   M /trunk/src/chrome/browser/worker.sb
   M /trunk/src/chrome/renderer/renderer.sb

Tighten down OS X sandbox a bit.

BUG=None
TEST=Browsing to popular websites on OS X 10.5 & 10.6 should continue to work.
Be sure to test on both 10.5 and 10.6

Review URL: http://codereview.chromium.org/660444
------------------------------------------------------------------------
r40859 | abarth@chromium.org | 2010-03-07 05:40:32 +0100 (Sun, 07 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

Add ocx to the dangerous extensions list

BUG=37447
TEST=Serve an .ocx via content-disposition attachment header. Check if the warning message appears.

Patch by the great and powerful Inferno.

------------------------------------------------------------------------
r40858 | feldstein@chromium.org | 2010-03-07 04:43:51 +0100 (Sun, 07 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   A /trunk/src/chrome/browser/cocoa/bookmark_drag_source.h
   A /trunk/src/chrome/browser/cocoa/bookmark_drag_source.mm
   A /trunk/src/chrome/browser/cocoa/web_contents_drag_source.h
   A /trunk/src/chrome/browser/cocoa/web_contents_drag_source.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/chrome_browser.gypi

Initial implementation of Drag and Drop for the extension BMM.

Review URL: http://codereview.chromium.org/660139
------------------------------------------------------------------------
r40856 | bradnelson@google.com | 2010-03-07 03:28:12 +0100 (Sun, 07 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/cpp_bound_class.cc
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webframe_unittest.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webpreferences.cc

Revert 40855 - webkit/glue: string_util.h > utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668229

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/669251
------------------------------------------------------------------------
r40855 | jhawkins@chromium.org | 2010-03-07 02:26:36 +0100 (Sun, 07 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/cpp_bound_class.cc
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webframe_unittest.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webpreferences.cc

webkit/glue: string_util.h -> utf_string_conversions.h fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668229
------------------------------------------------------------------------
r40847 | atwilson@chromium.org | 2010-03-06 23:02:04 +0100 (Sat, 06 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   A /trunk/src/chrome/browser/cocoa/status_icons
   A /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.h
   A /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac.mm
   A /trunk/src/chrome/browser/cocoa/status_icons/status_icon_mac_unittest.mm
   A /trunk/src/chrome/browser/status_icons
   A /trunk/src/chrome/browser/status_icons/status_icon.h
   A /trunk/src/chrome/browser/status_icons/status_tray.cc
   A /trunk/src/chrome/browser/status_icons/status_tray.h
   A /trunk/src/chrome/browser/status_icons/status_tray_manager.cc
   A /trunk/src/chrome/browser/status_icons/status_tray_manager.h
   A /trunk/src/chrome/browser/status_icons/status_tray_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_browser_process.h

Initial implementation of status tray functionality (mac-only, currently).

Added Mac implementation of StatusIcon, and added a simple click callback that
displays the "extensions" tab when clicked on, to allow us to dogfood long-lived
extensions.

BUG=37375

Review URL: http://codereview.chromium.org/661454
------------------------------------------------------------------------
r40842 | finnur@chromium.org | 2010-03-06 18:56:32 +0100 (Sat, 06 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   M /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   A /trunk/src/chrome/browser/chromeos/login/update_view.cc
   A /trunk/src/chrome/browser/chromeos/login/update_view.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

Added OOBE update screen stub.
Moved OOBE views classes to the chromeos namespace.

BUG=35249
TEST=run out/Debug/chrome --login-manager --login-screen=update
TBR=denisromanov

(Checking in patch for Denis Romanov, previously reviewed here:
http://codereview.chromium.org/669089/show)

Review URL: http://codereview.chromium.org/669241
------------------------------------------------------------------------
r40840 | suzhe@chromium.org | 2010-03-06 16:09:50 +0100 (Sat, 06 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc

[Linux] Fix BookmarkBarGtkBrowserTest.ClickOnFloatingTest

BUG=37591
TEST=none

Review URL: http://codereview.chromium.org/668224
------------------------------------------------------------------------
r40839 | suzhe@chromium.org | 2010-03-06 14:30:55 +0100 (Sat, 06 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc

Disable broken test: BookmarkBarGtkBrowserTest.ClickOnFloatingTest

BUG=37591 
TEST=none

TBR=estade
Review URL: http://codereview.chromium.org/668223
------------------------------------------------------------------------
r40834 | phajdan.jr@chromium.org | 2010-03-06 13:13:47 +0100 (Sat, 06 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/mach_broker_mac.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/notification_registrar.cc
   M /trunk/src/chrome/common/notification_registrar.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc

Next part of removing the dependency of chrome/common on chrome/browser

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669184
------------------------------------------------------------------------
r40826 | bauerb@chromium.org | 2010-03-06 07:58:34 +0100 (Sat, 06 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

Fix some tests failing after revision 40818.

I already had a patch for this.

BUG=160,33038
TEST=Some tests (don't remember which ones) that were failing before should now pass.

Review URL: http://codereview.chromium.org/669235
------------------------------------------------------------------------
r40818 | brettw@chromium.org | 2010-03-06 06:06:20 +0100 (Sat, 06 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/url_request/request_tracker_unittest.cc

Pulls the latest googleurl to get the fix for
BUG=http://crbug.com/160
and integrates the update to IsStandard in that version. Adds several internal
schemes as "standard" and initializes them at startup. Fixes a few hardcoded
URL schemes I noticed.

Make typing "//foo" into the URL bar treat slashes in "strict" mode on Windows,
which means we'll only accept UNC if you use backslashes. This matches IE's
behavior.

BUG=http://crbug.com/33038
TEST=covered by unit tests
------------------------------------------------------------------------
r40816 | suzhe@chromium.org | 2010-03-06 05:12:44 +0100 (Sat, 06 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Fix bug 36699: Alt+Enter in windows XP+Chrome gives incorrect keycodes!!

BUG=36699
TEST=See bug report.

Review URL: http://codereview.chromium.org/660167
------------------------------------------------------------------------
r40815 | suzhe@chromium.org | 2010-03-06 05:00:03 +0100 (Sat, 06 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.cc
   A /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.cc
   A /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox.h
   A /trunk/src/chrome/browser/gtk/gtk_chrome_shrinkable_hbox_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Linux] Make bookmark bar instructions shrinkable.

BUG=36876
BUG=34479
TEST=Delete all bookmarks and show bookmark bar, then shirnk the browser window, the bookmark bar instructions should be shrinkable.

Review URL: http://codereview.chromium.org/661364
------------------------------------------------------------------------
r40813 | brettw@chromium.org | 2010-03-06 03:53:28 +0100 (Sat, 06 Mar 2010) | 17 lines
Changed paths:
   M /trunk/src/base/id_map.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/transport_dib.h
   A /trunk/src/chrome/renderer/mock_render_process.cc (from /trunk/src/chrome/renderer/mock_render_process.cc:40493)
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_devices.h
   A /trunk/src/chrome/renderer/pepper_devices_unittest.cc (from /trunk/src/chrome/renderer/pepper_devices_unittest.cc:40493)
   M /trunk/src/chrome/renderer/render_process.h
   R /trunk/src/chrome/renderer/render_process_impl.cc (from /trunk/src/chrome/renderer/render_process.cc:40762)
   R /trunk/src/chrome/renderer/render_process_impl.h (from /trunk/src/chrome/renderer/render_process.h:40762)
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Make the pepper 2D flush callback actually function as advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting. This also adds a lot of
infrastructure for running tests on pepper devices, and includes a unit test
for the new flush behavior. I made the existing RenderProcess object an
abstract interface and made the existing MockProcess (renamed to be more clear)
implement that. This avoids a static cast that would actually crash during a
unit test because some code was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.

TEST=Unit test included
BUG=none
Original review URL: http://codereview.chromium.org/661124

Review URL: http://codereview.chromium.org/664001
------------------------------------------------------------------------
r40811 | thakis@chromium.org | 2010-03-06 03:18:02 +0100 (Sat, 06 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm

Revert 40810 (broke 10.6 bots) - Mac: Fix another crash in content exceptions dialog.

Also add a couple unit tests. Also fix another potential crash and other problems uncovered by the tests.

BUG=37208
TEST=See bug. Also, unittests.

Review URL: http://codereview.chromium.org/668046

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/668211
------------------------------------------------------------------------
r40810 | thakis@chromium.org | 2010-03-06 03:06:15 +0100 (Sat, 06 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm

Mac: Fix another crash in content exceptions dialog.

Also add a couple unit tests. Also fix another potential crash and other problems uncovered by the tests.

BUG=37208
TEST=See bug. Also, unittests.

Review URL: http://codereview.chromium.org/668046
------------------------------------------------------------------------
r40809 | gregoryd@google.com | 2010-03-06 02:56:28 +0100 (Sat, 06 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc

Add support for starting NaCl win64 process if nacl64.exe is in the version directory.
We now assume that nacl64.exe is in the same directory as chrome.dll (and not as chrome.exe as we assumed before).

BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/668130
------------------------------------------------------------------------
r40807 | chocobo@chromium.org | 2010-03-06 02:41:00 +0100 (Sat, 06 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc

Set the focus on the first field for login.
Review URL: http://codereview.chromium.org/668194
------------------------------------------------------------------------
r40803 | dhollowa@chromium.org | 2010-03-06 01:35:09 +0100 (Sat, 06 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/vertical_layout_view.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

AutoFill Mac preference for enabling Address Book "me" card usage.

Adds a boolean preference to specify whether to use the Mac user's Address Book "me" card as a source of information for AutoFill addresses.  This CL adds the Mac UI and the preference setup only.  It does not cover the functionality for fetching the actual Address Book data.  The changes to AutoFillDialog.xib add the checkbox UI and bind the checkbox to the |auxiliaryEnabled| property in the controller class.  The |addressSection_| outlet is set to the spacer following the new checkbox.  Unit tests are included for the addition of the preference at the mac dialog controller level.

BUG=36496
TEST=PersonalDataManagerTest, AutoFillDialogControllerTest

Review URL: http://codereview.chromium.org/668171
------------------------------------------------------------------------
r40802 | rafaelw@chromium.org | 2010-03-06 01:22:30 +0100 (Sat, 06 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc

Minor extensions code cleanup

This removes an extraneous ALLOW_THIS_IN_INITIALIZER, and also adds to a comment in browser_init.cc the relevant bug.

TBR=aa,tfarina

Review URL: http://codereview.chromium.org/668181
------------------------------------------------------------------------
r40801 | oshima@chromium.org | 2010-03-06 01:06:06 +0100 (Sat, 06 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   A /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc
   A /trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/chrome_tests.gypi

Display sticky and non sticky notifications separately.
 Added separate containers for sitcky, non sticky notifications.
 I copied most of desktop notification unittest. I'll refactor it and reduce duplicate in next CL.

BUG=33306
TEST=added desktop_notification_unittests for chromeos.

Review URL: http://codereview.chromium.org/661289
------------------------------------------------------------------------
r40797 | snej@chromium.org | 2010-03-06 00:44:45 +0100 (Sat, 06 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_win.cc
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/base/x509_certificate_unittest.cc
   M /trunk/src/net/base/x509_certificate_win.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_test_util.cc

Thread-safety for X509Certificate's intermediate-certs list.
BUG=32553,30001
TEST=none

Review URL: http://codereview.chromium.org/661223
------------------------------------------------------------------------
r40796 | michaeln@chromium.org | 2010-03-06 00:40:02 +0100 (Sat, 06 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.cc
   M /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/views/appcache_info_view.cc
   M /trunk/src/chrome/browser/views/appcache_info_view.h
   M /trunk/src/webkit/appcache/appcache_group.cc
   M /trunk/src/webkit/appcache/appcache_group.h
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_service.cc
   M /trunk/src/webkit/appcache/appcache_service.h
   M /trunk/src/webkit/appcache/appcache_storage.h
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl.h
   M /trunk/src/webkit/appcache/mock_appcache_storage.h

Hook up the content settings UI to the appcache.

* Populate the tree view with appcaches
* Delete selected appcaches from the tree view
* Delete the date range indicated in the browsing data remover

TEST=manual
BUG=34634

Review URL: http://codereview.chromium.org/660423
------------------------------------------------------------------------
r40790 | chocobo@chromium.org | 2010-03-05 23:43:42 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h

Refactor libcros calls for ChromeOS
- better UI for why libcros failed to load
- fix enable/disable wifi menu item
- call new ConnectToNetwork method that works with cellular
BUG=1682
TEST=none
Review URL: http://codereview.chromium.org/661392
------------------------------------------------------------------------
r40787 | jhawkins@chromium.org | 2010-03-05 23:02:12 +0100 (Fri, 05 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address.cc
   M /trunk/src/chrome/browser/autofill/billing_address_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_group.h

Add more tests for BillingAddress and fix the issues found by the tests.

BUG=none
TEST=BillingAddressTest
Review URL: http://codereview.chromium.org/669141
------------------------------------------------------------------------
r40783 | apatrick@chromium.org | 2010-03-05 22:53:50 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_renderer.gypi
   D /trunk/src/chrome/common/command_buffer_messages.h
   D /trunk/src/chrome/common/command_buffer_messages_internal.h
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/gpu/DEPS
   A /trunk/src/chrome/gpu/gpu_channel.cc (from /trunk/src/chrome/plugin/plugin_channel.cc:39232)
   A /trunk/src/chrome/gpu/gpu_channel.h (from /trunk/src/chrome/plugin/plugin_channel.h:39232)
   A /trunk/src/chrome/gpu/gpu_command_buffer_stub.cc (from /trunk/src/chrome/plugin/command_buffer_stub.cc:39232)
   A /trunk/src/chrome/gpu/gpu_command_buffer_stub.h (from /trunk/src/chrome/plugin/command_buffer_stub.h:39232)
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/command_buffer_stub_win.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/command_buffer_proxy.cc
   M /trunk/src/chrome/renderer/command_buffer_proxy.h
   A /trunk/src/chrome/renderer/gpu_channel_host.cc (from /trunk/src/chrome/renderer/plugin_channel_host.cc:39232)
   A /trunk/src/chrome/renderer/gpu_channel_host.h (from /trunk/src/chrome/renderer/plugin_channel_host.h:39232)
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor_win.cc
   M /trunk/src/gpu/gpu.gyp
   M /trunk/src/ipc/ipc_channel_handle.h
   M /trunk/src/ipc/ipc_message_utils.h

Added support for opening a GPU command buffer from a renderer processes through a GPU channel.
Probably only works in windows only so far.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/657046
------------------------------------------------------------------------
r40782 | jrg@chromium.org | 2010-03-05 22:52:58 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/test/functional/bookmark_bar.py
   M /trunk/src/chrome/test/pyautolib/pyautolib.cc
   M /trunk/src/chrome/test/pyautolib/pyautolib.h
   M /trunk/src/chrome/test/pyautolib/pyautolib.i
   M /trunk/src/chrome/test/test_browser_window.h

Add some bookmark bar hooks for pyauto.
Refactor the implementation for x-platform happiness.

Add simple pyauto script that uses it (but needs http://crbug.com32292
fixed before it works without tweaking).

Review URL: http://codereview.chromium.org/670001
------------------------------------------------------------------------
r40781 | zork@google.com | 2010-03-05 22:31:25 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc

Use a common call to WriteAutofill in AutofillModelAssociator, add a proper
update to the sync model on model association.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/661337
------------------------------------------------------------------------
r40780 | oshima@chromium.org | 2010-03-05 22:19:26 +0100 (Fri, 05 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Lazy AppLauncher creation to make tests stable.
 There seems to be a timing issue in renderer deletion and io thread
 deletion, and the resource that has to be deleted before io thread are not
 deleted by the time io thread is deleted. Since this will soon be changed,
 i just chagned this to be created on demand for now.

 This also reverts commit dd6c4ab11002a308bf8eede36bb632e95d3a1382.

TBR=sky@chromium.org
BUG=32641
TEST=none

Review URL: http://codereview.chromium.org/669196
------------------------------------------------------------------------
r40777 | andybons@chromium.org | 2010-03-05 21:58:21 +0100 (Fri, 05 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc

Mark MetricsServiceTest.CrashRenderers as FLAKY.

TEST=ui tests should pass.
BUG=32048
------------------------------------------------------------------------
r40776 | finnur@chromium.org | 2010-03-05 21:49:19 +0100 (Fri, 05 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Revert 40769 - Remove flaky label from RSS tests.

Looks like I was not reading it correctly, or maybe I just
started seeing what I want to see...

TBR=cira
BUG=37109
TEST=None

Review URL: http://codereview.chromium.org/668178

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/668180
------------------------------------------------------------------------
r40775 | mbelshe@chromium.org | 2010-03-05 21:49:02 +0100 (Fri, 05 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/spdy/spdy_session_pool.cc
   M /trunk/src/net/spdy/spdy_session_pool.h

Add command line option for changing the max number of SPDY sessions per
domain.  The default remains at 1.

Command line usage to set it to 13:
   chrome.exe --use-spdy --max-spdy-sessions-per-domain=13

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/669169
------------------------------------------------------------------------
r40774 | zork@chromium.org | 2010-03-05 21:47:19 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Remove DeleteOnIOThread from Datatype controller to fix Valgrind and remove the suppression

BUG=37168
TEST=Run Valgrind

Review URL: http://codereview.chromium.org/661428
------------------------------------------------------------------------
r40771 | avi@chromium.org | 2010-03-05 21:40:50 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bubble_view.h
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Make sure we adjust the theme source for the status bubble when moving between windows.

BUG=http://crbug.com/37445
TEST=as in bug

Review URL: http://codereview.chromium.org/669185
------------------------------------------------------------------------
r40769 | finnur@chromium.org | 2010-03-05 21:37:28 +0100 (Fri, 05 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Remove flaky label from RSS tests. Looks like my changes worked.

I have been monitoring the buildbots to see if it has flaked out
in the last two days and it looks like it has not.

TBR=cira
BUG=37109
TEST=This CL is about enabling automated tests.

Review URL: http://codereview.chromium.org/668178
------------------------------------------------------------------------
r40767 | sky@chromium.org | 2010-03-05 21:16:53 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Implements mini-tab support for linux.

BUG=36797
TEST=make sure pinned tabs work on linux.

Review URL: http://codereview.chromium.org/669163
------------------------------------------------------------------------
r40766 | rohitrao@chromium.org | 2010-03-05 21:13:41 +0100 (Fri, 05 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm

[Mac] Do not redraw the status bubble if nothing has changed.

BUG=None
TEST=No visible impact.  Status bubble should look exactly the same as before when moving the mouse around.
Review URL: http://codereview.chromium.org/669179
------------------------------------------------------------------------
r40760 | albertb@chromium.org | 2010-03-05 19:51:46 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Under Chromium OS, keep track of whether sync auth has been bootstrapped
already to avoid re-enabling sync everytime the machine boots.

BUG=37164
TEST=unit test

Review URL: http://codereview.chromium.org/669099
------------------------------------------------------------------------
r40759 | ananta@chromium.org | 2010-03-05 19:49:39 +0100 (Fri, 05 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h

Fix a Chrome crash which occured in a chrome frame reliability test run. The crash happens while 
sending the AutomationMsg_GetCookiesFromHost request for a NULL channel. Fix is to use the
AutomationResourceMessageFilter::Send method which checks for the same and also deletes the message
if the channel is NULL.

The AutomationResourceMessageFilter also implements the OnFilterRemoved notification on the IPC message
filter to clear out the channel just in case.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=37512

Bug=37512

Review URL: http://codereview.chromium.org/668163
------------------------------------------------------------------------
r40756 | erg@chromium.org | 2010-03-05 19:42:23 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h

GTK: Add details display to the cookie modal dialog.

BUG=37418
TEST=none

Review URL: http://codereview.chromium.org/668122
------------------------------------------------------------------------
r40755 | rafaelw@chromium.org | 2010-03-05 19:33:58 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/common/notification_type.h

extensions_ui: update "active views" for popups & TabContents

This creates notifications when ExtensionFunctionDispatcher is created and destroyed. This mirrors the creation of any extension view. extensions_ui now listens to this to update it's list of active views.

BUG=28423

Review URL: http://codereview.chromium.org/669028
------------------------------------------------------------------------
r40754 | jcampan@chromium.org | 2010-03-05 19:27:01 +0100 (Fri, 05 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Fix for bug 36463. Reloading a page by pressing enter in the
location bar would not bring back the translate infobar.

BUG=36463
TEST=Navigate to a page in a different language so it brings up
     the translate infobar, close the infobar. Click on the
     location bar and press enter. The page should be reloaded
     and the translation infobar should be shown again.
    
Review URL: http://codereview.chromium.org/661301
------------------------------------------------------------------------
r40751 | glotov@google.com | 2010-03-05 19:18:59 +0100 (Fri, 05 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/language_combobox_model.h

Separated basic language-list code from the combobox model
implementation.  This is because we needed a menu (not combobox) with
languages in another part of Chromium (CL 661475).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/668068
------------------------------------------------------------------------
r40749 | shess@chromium.org | 2010-03-05 19:09:03 +0100 (Fri, 05 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h

On-the-fly migration from SafeBrowsingStoreSqlite -> *File.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40605

Review URL: http://codereview.chromium.org/666001
------------------------------------------------------------------------
r40747 | thomasvl@chromium.org | 2010-03-05 19:04:01 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

[Mac] Change when we trigger a download shelf layout
As part of awakeFromNib a dangerous download would set it's state and trigger a layout grabbing the initial size before the proper localized text was loaded and the view sized.  This made the item "stick" at the wrong size.  Now setState: doesn't trigger a layout and instead only force a layout when the dangerous state is cleared.

BUG=28446,28705,32775
TEST=see bugs
Review URL: http://codereview.chromium.org/668161
------------------------------------------------------------------------
r40746 | gregoryd@google.com | 2010-03-05 18:50:43 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/nacl/broker_thread.cc
   M /trunk/src/chrome/nacl/broker_thread.h

Revert 40744 - Terminate NaCl broker process when no loader processes are running
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669019

TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/668165
------------------------------------------------------------------------
r40744 | gregoryd@google.com | 2010-03-05 18:27:12 +0100 (Fri, 05 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/child_process_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/nacl/broker_thread.cc
   M /trunk/src/chrome/nacl/broker_thread.h

Terminate NaCl broker process when no loader processes are running
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669019
------------------------------------------------------------------------
r40743 | snej@chromium.org | 2010-03-05 18:17:57 +0100 (Fri, 05 Mar 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_win.cc
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/base/x509_certificate_unittest.cc
   M /trunk/src/net/base/x509_certificate_win.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_test_util.cc

Revert my last commit 'cause it breaks net unit tests on OS X 10.6 :(
------------------------------------------------------------------------
r40742 | snej@chromium.org | 2010-03-05 17:59:54 +0100 (Fri, 05 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_win.cc
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/base/x509_certificate_unittest.cc
   M /trunk/src/net/base/x509_certificate_win.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_test_util.cc

Thread-safety for X509Certificate's intermediate-certs list.
BUG=32553,30001
TEST=none

Review URL: http://codereview.chromium.org/661223
------------------------------------------------------------------------
r40741 | rohitrao@chromium.org | 2010-03-05 17:23:07 +0100 (Fri, 05 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h

[Mac] Comment fix for browserWindowControllerForView.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/668080
------------------------------------------------------------------------
r40740 | rohitrao@chromium.org | 2010-03-05 17:22:54 +0100 (Fri, 05 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h

[Mac] Lock open the fullscreen overlay when browsing bookmark folders.

BUG=37271
TEST=Go fullscreen.  Open a folder on the bookmarkbar and hover over one of its subentries.  Overlay should not scroll back up.
Review URL: http://codereview.chromium.org/669086
------------------------------------------------------------------------
r40738 | avi@chromium.org | 2010-03-05 16:52:29 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm

Cleaning up, removing a path not taken.

BUG=none
TEST=no change visually

Review URL: http://codereview.chromium.org/668159
------------------------------------------------------------------------
r40734 | nkostylev@google.com | 2010-03-05 13:15:48 +0100 (Fri, 05 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/network_list.cc
   M /trunk/src/chrome/browser/chromeos/network_list.h

Provide notification on network connecting.

Review URL: http://codereview.chromium.org/646022
------------------------------------------------------------------------
r40732 | bulach@chromium.org | 2010-03-05 12:40:08 +0100 (Fri, 05 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   A /trunk/src/chrome/browser/content_setting_image_model.cc
   A /trunk/src/chrome/browser/content_setting_image_model.h
   A /trunk/src/chrome/browser/content_setting_image_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/test_location_bar.h

Renames ContentBlockedImageView to ContentSettingImageView.
Adds ContentSettingImageModel to provide icon and tooltips for platform-specific ContentBlockedImageView.

(in preparation for:
http://codereview.chromium.org/650180/show
)

TEST=chrome/browser/content_setting_image_model_unittest.cc

Review URL: http://codereview.chromium.org/660279
------------------------------------------------------------------------
r40731 | jorlow@chromium.org | 2010-03-05 12:12:10 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc

Switch to using the CookieMessageFilter when pumping messages for StorageArea::setItem.

TEST=none
BUG=37350

Review URL: http://codereview.chromium.org/669072
------------------------------------------------------------------------
r40724 | jochen@chromium.org | 2010-03-05 10:33:13 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc

When --no-referrers is given, also remove Referer header on WebKit side of the world.

TEST=Start with --no-referrers, neither headers nor document.referrer should ever get set
BUG=none

Review URL: http://codereview.chromium.org/668065
------------------------------------------------------------------------
r40722 | jochen@chromium.org | 2010-03-05 09:15:53 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/resources/history.html

Implement edit mode for history page.

BUG=35338
TEST=none

Review URL: http://codereview.chromium.org/660283
------------------------------------------------------------------------
r40709 | tony@chromium.org | 2010-03-05 04:18:42 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/history/multipart_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/net/tools/testserver/testserver.py

Add a UI test to make sure that each frame of a multipart
request does not generate a separate row in the history
database.

BUG=34350

Review URL: http://codereview.chromium.org/668051
------------------------------------------------------------------------
r40708 | nsylvain@chromium.org | 2010-03-05 04:07:44 +0100 (Fri, 05 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/login_view.cc

This patch fixes the truncation issue in the hostname url for HTTP Auth Dialog. It was a trivial fix that set the SetAllowCharacterBreak property to true for the message label. As a result, the hostname url does not truncate and wraps to the next line. 

Original patch by Abhishek Arya <aarya@google.com>

BUG=36772
TEST=Try a hostname url longer than 42 chars to see that it wraps correctly and wraps to the next line.

------------------------------------------------------------------------
r40707 | bauerb@chromium.org | 2010-03-05 03:26:28 +0100 (Fri, 05 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix crash when opening a bookmark without an open window.

This fixes a regression appearing in revision 39455 by adding an additional NULL check.

TEST=Open Chromium, close all open windows, open bookmark manager, double click any bookmark. Chromium shouldn't crash.
BUG=37386

Review URL: http://codereview.chromium.org/669078
------------------------------------------------------------------------
r40702 | jhawkins@chromium.org | 2010-03-05 02:51:44 +0100 (Fri, 05 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Enable AutoFill++ by default for new profiles.

BUG=37466
TEST=none
Review URL: http://codereview.chromium.org/668126
------------------------------------------------------------------------
r40697 | mpcomplete@chromium.org | 2010-03-05 01:33:24 +0100 (Fri, 05 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Update the extensions management page to match mock attached to bug 36292.

Also changed the way we reload an extension when toggling it for incognito.

Also fixed a small bug this exposed with the browser action container where it
would shrink to 0 size when reloading an extension.

BUG=36292

Review URL: http://codereview.chromium.org/668107
------------------------------------------------------------------------
r40695 | tony@chromium.org | 2010-03-05 01:33:10 +0100 (Fri, 05 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Fix pickle mismatch when getting redirects fails.

Review URL: http://codereview.chromium.org/669044
------------------------------------------------------------------------
r40694 | tony@chromium.org | 2010-03-05 01:27:49 +0100 (Fri, 05 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Clean up phantom tabs that are leaked in the unit test.

Review URL: http://codereview.chromium.org/669042
------------------------------------------------------------------------
r40690 | michaeln@chromium.org | 2010-03-05 01:20:57 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Simple fix for a crashing bug.

TEST=none
BUG=37440

Review URL: http://codereview.chromium.org/669097
------------------------------------------------------------------------
r40684 | eroman@chromium.org | 2010-03-05 00:54:44 +0100 (Fri, 05 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc

Remove a CHECK() which was firing.

The problem was the load state poller may call OnUploadProgress() while a redirect is in progress.
It should be safe to remove the CHECK(), since it was recently added and execution used to pass through previously in this case.

BUG=37035
TBR=wtc

Review URL: http://codereview.chromium.org/669117
------------------------------------------------------------------------
r40683 | aa@chromium.org | 2010-03-05 00:48:34 +0100 (Fri, 05 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Load the bookmark manager extension at Chrome startup.

Review URL: http://codereview.chromium.org/660232
------------------------------------------------------------------------
r40677 | avi@chromium.org | 2010-03-05 00:07:24 +0100 (Fri, 05 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Only paint the top of the window. Fixes flickering, probably improves performance too.

BUG=http://crbug.com/29874
TEST=as in bug

Review URL: http://codereview.chromium.org/669009
------------------------------------------------------------------------
r40676 | johnnyg@chromium.org | 2010-03-04 23:47:02 +0100 (Thu, 04 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h

Fix linking as well as compiling.

TBR=oshima
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/669106
------------------------------------------------------------------------
r40675 | johnnyg@chromium.org | 2010-03-04 23:38:33 +0100 (Thu, 04 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/views/widget/widget_gtk.cc

Fix build break.

TBR=oshima
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/668095
------------------------------------------------------------------------
r40670 | johnnyg@chromium.org | 2010-03-04 23:12:02 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/views/widget/widget.h
   A /trunk/src/views/widget/widget_delegate.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

On Windows, detect the WM_DISPLAYCHANGE message which indicates the desktop size is changing.  Pass this event using the NotificationService, and listen for it in desktop notification code in order to adjust metrics properly for the corner of the screen.

BUG=35464
TEST=resize desktop after starting chrome; create notifications.

Review URL: http://codereview.chromium.org/606007
------------------------------------------------------------------------
r40669 | mattm@chromium.org | 2010-03-04 23:02:30 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/page_info_window_view.cc

Linux views: Hook up gtk certificate viewer to page info window.

BUG=18119
TEST=load https site, click page info then certificate info button.

Review URL: http://codereview.chromium.org/669030
------------------------------------------------------------------------
r40666 | jhawkins@chromium.org | 2010-03-04 22:57:01 +0100 (Thu, 04 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Use the TestTabContents provided by RenderViewHostTestHarness instead of rolling our own TestTabContents.  Fixes a leak in the tests.

BUG=37385
TEST=AutoFillInfoBarDelegateTest
Review URL: http://codereview.chromium.org/668088
------------------------------------------------------------------------
r40655 | dhollowa@chromium.org | 2010-03-04 22:20:15 +0100 (Thu, 04 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/phone_number.cc
   M /trunk/src/chrome/browser/autofill/phone_number.h
   A /trunk/src/chrome/browser/autofill/phone_number_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

AutoFill phone number parser changes.

Moved the PersonalDataManager::ParsePhoneNumber() method into the PhoneNumber class.  Made some bug fixes to the parser.  Extended its functionality to strip separator characters.  Added unit tests to cover the parser.

BUG=none
TEST=PhoneNumberTest

Review URL: http://codereview.chromium.org/669026
------------------------------------------------------------------------
r40649 | andybons@chromium.org | 2010-03-04 21:30:57 +0100 (Thu, 04 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Disabling SessionHistoryTest.LocationReplace since it has been failing consistently for a while.

TEST=none
BUG=22560
Review URL: http://codereview.chromium.org/669081
------------------------------------------------------------------------
r40648 | oshima@chromium.org | 2010-03-04 21:20:28 +0100 (Thu, 04 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/app_launcher.cc
   M /trunk/src/chrome/browser/chromeos/app_launcher.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h

Fix leaks caused by main menu singleton.
 Simply creating & deleting it per window instance for now.
 No delay on dev machine, but may cause a delay on netbook.
 MainMenu(aka AppMenu) is to be rewritten, so we'll revisit  the performance issue (if any) later.

BUG=32624,37334
TEST=no crash on exit.

Review URL: http://codereview.chromium.org/668076
------------------------------------------------------------------------
r40647 | agl@chromium.org | 2010-03-04 21:18:55 +0100 (Thu, 04 Mar 2010) | 18 lines
Changed paths:
   A /trunk/src/base/rand_util_c.h
   M /trunk/src/base/rand_util_posix.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/common/sandbox_methods_linux.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h

Add support for running the NaCl plugin in the Linux SUID sandbox

 * Add a function for getting the pre-opened FD for /dev/urandom.
   This needs to be a C function because it will be used by
   nacl_secure_random.c.
 * Add an IPC message for creating shared memory segments, since
   /dev/shm is not available inside the sandbox.

The corresponding NaCl change is http://codereview.chromium.org/669056

BUG=36676
TEST=nacl_ui_tests in conjunction with NaCl changes

http://codereview.chromium.org/669055

Patch by Mark Seaborn.

Signed-off-by: Adam Langley
------------------------------------------------------------------------
r40642 | rohitrao@chromium.org | 2010-03-04 20:11:02 +0100 (Thu, 04 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Rewrite [-BWC browserWindowControllerForView:] to handle views in child windows.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/668074
------------------------------------------------------------------------
r40641 | gwilson@google.com | 2010-03-04 20:04:24 +0100 (Thu, 04 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Changes RLZ organic wildcards to include GGR*

BUG=37411
R=cpu
TEST=RLZ should not occur with GGR* brand codes

Review URL: http://codereview.chromium.org/669074
------------------------------------------------------------------------
r40636 | erg@chromium.org | 2010-03-04 18:55:25 +0100 (Thu, 04 Mar 2010) | 18 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.cc
   A /trunk/src/chrome/browser/gtk/gtk_chrome_cookie_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTK: Split out the cookie display into its own component for reuse in the cookie ask dialog.

This patch is fairly different from my previous attempt:
- It's implemented not as a C++ object, but as a gobject. This was originally
  done because there were very weird memory errors and I assume there were
  ownership issues (see point 3), but I'm leaving it this way since I think
  it's a bit simpler to integrate.
- Several details of when it initializes style are now done in response to the
  frame being realized, instead of having to realize widgets in the CookiesView
  to pass in GtkStyles*.
- The CookieView class and its unit tests have been modified with a flag that
  allows it to be stack allocated, which is what the unit tests do. It looks
  like it only accidentally worked previously.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/669015
------------------------------------------------------------------------
r40629 | mad@chromium.org | 2010-03-04 17:16:19 +0100 (Thu, 04 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_win.cc
   A /trunk/src/chrome/browser/process_singleton_win_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Fixed a startup race condition.

Although the new test was written in a platform independent way, it is only added to the Widows specific portion of the ui_test target in the gyp file because it wasn't tried yet on the other platforms.

The bug was found and the fix was written in the windows specific version of the process singleton anyway... But if people working on the other platforms would like to try the test there, that would be great. :-)

BUG=9593
TEST=A new test have been created to validate this.

Review URL: http://codereview.chromium.org/661339
------------------------------------------------------------------------
r40627 | avayvod@google.com | 2010-03-04 17:13:27 +0100 (Thu, 04 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   A /trunk/src/chrome/browser/chromeos/login/account_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/account_screen.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/browser/chromeos/login/view_screen.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc
   M /trunk/src/chrome/browser/chromeos/login/wizard_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

Moved logic from AccountCreationView to AccountScreen.
Added RoundedRectBorder to use instead of background for DOMView.
Refactored rounded_rect_painter.h/cc to share code and encapsulate most of
constants.
Modified Gaia page by injecting CSS and JS so it looks better for Chrome OS.

BUG=35157,37069,37070.
TEST=Launch with --login-screen=account. Customized Gaia account creation
page should appear.

Review URL: http://codereview.chromium.org/661398
------------------------------------------------------------------------
r40625 | skerner@chromium.org | 2010-03-04 16:01:37 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Disable scroll bars for popups that will grow on windows and linux_view.

BUG=30247
TEST=Manual testing on windows and linux using GYP_DEFINES=chromeos=1.

Review URL: http://codereview.chromium.org/660290
------------------------------------------------------------------------
r40621 | joth@chromium.org | 2010-03-04 12:12:43 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_geolocation_apitest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   A /trunk/src/chrome/browser/geolocation/mock_location_provider.cc (from /trunk/src/chrome/browser/geolocation/location_provider.cc:40524)
   A /trunk/src/chrome/browser/geolocation/mock_location_provider.h (from /trunk/src/chrome/browser/geolocation/location_provider.h:40277)
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/geolocation/manifest.json

Fix crash when permission request received from extension.

BUG=http://crbug.com/37196
TEST=TODO

Review URL: http://codereview.chromium.org/667006
------------------------------------------------------------------------
r40616 | jochen@chromium.org | 2010-03-04 10:35:16 +0100 (Thu, 04 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Disable ExtensionApiTest.Tabs on Mac.
TEST=no random redness on Mac OS X 10.6 bot
BUG=37387
TBR=skerner@
------------------------------------------------------------------------
r40608 | eroman@chromium.org | 2010-03-04 07:45:43 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   A /trunk/src/chrome/browser/net/view_net_internals_job_factory.cc (from /trunk/src/net/url_request/url_request_view_net_internals_job.cc:40555)
   A /trunk/src/chrome/browser/net/view_net_internals_job_factory.h (from /trunk/src/net/url_request/url_request_view_net_internals_job.h:40555)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/net.gyp
   D /trunk/src/net/url_request/url_request_view_net_internals_job.cc
   D /trunk/src/net/url_request/url_request_view_net_internals_job.h

Refactor: Move the code that handles "chrome://net-internals/*" from the net module to the chrome module.
This is in preparation for making a javascript frontend to it, and merging in the functionality from about:network.

There is no behavior change here, just moving code around.

Review URL: http://codereview.chromium.org/668039
------------------------------------------------------------------------
r40607 | shess@chromium.org | 2010-03-04 07:45:43 +0100 (Thu, 04 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h

Revert "On-the-fly migration from SafeBrowsingStoreSqlite -> *File."

Broke the build.  Sorry.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/669043
------------------------------------------------------------------------
r40605 | shess@chromium.org | 2010-03-04 07:13:10 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h

On-the-fly migration from SafeBrowsingStoreSqlite -> *File.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/666001
------------------------------------------------------------------------
r40597 | mattm@chromium.org | 2010-03-04 04:35:51 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h

Linux certificate viewer: add decoding of rsa public key.

BUG=18119
TEST=compare to firefox

Review URL: http://codereview.chromium.org/669032
------------------------------------------------------------------------
r40596 | estade@chromium.org | 2010-03-04 04:30:55 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

GTK: disable "edit search engines" and "paste and go" in location bar view when appropriate.

BUG=29089
TEST=see bug

Review URL: http://codereview.chromium.org/667009
------------------------------------------------------------------------
r40595 | estade@chromium.org | 2010-03-04 04:30:34 +0100 (Thu, 04 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

GTK/Mac: show security warning on correct part of url.

Where "security warning" means "diagonal red line".

This change just copies the relevant code from Windows; my suspicion is that when the windows code was updated, mac and linux had already copied the old, incorrect code, but the bug didn't become apparent until the security UI was implemented on those platforms.

BUG=26280
TEST=manual

Review URL: http://codereview.chromium.org/668016
------------------------------------------------------------------------
r40590 | jhawkins@chromium.org | 2010-03-04 02:58:30 +0100 (Thu, 04 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.h
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.h
   A /trunk/src/chrome/browser/autofill/autofill_infobar_delegate_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add tests for AutoFillInfoBarDelegate, with a fix to only return a button label if the button type is valid.

BUG=none
TEST=AutoFillInfoBarDelegateTest
Review URL: http://codereview.chromium.org/668002
------------------------------------------------------------------------
r40589 | estade@chromium.org | 2010-03-04 02:58:20 +0100 (Thu, 04 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

GTK: fix a tab dragging crasher.

The crash was a result of the early exit in EndDragImpl. When EndDragImpl is called due to a TAB_CONTENTS_DESTROYED notification and we exit early the DragController() doesn't get destroyed. We get a Drag() call afterwords, and call into a stale dragged_contents_. I fixed this by removing the early exit (instead checking dragged_tab_ before trying to clean up the drag, in case it hadn't started).

The change to EnsureDraggedTab() should not have any functional effect; it just makes the control flow clearer.

The new dragged_controller_ check should also not have any functional effect; it just seems safer to check it.

BUG=25326
TEST=manual (see bug for repro steps)
Review URL: http://codereview.chromium.org/668010
------------------------------------------------------------------------
r40587 | mattm@chromium.org | 2010-03-04 02:46:57 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertificate.cpp
   M /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertificate.h
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsUsageArrayHelper.cpp (from /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertificate.cpp:40584)
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsUsageArrayHelper.h (from /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertificate.h:40584)

Linux: implement Client SSL Certificate selection UI

BUG=25241
TEST=Visit site for which you have a client certificate, verify that dialog comes up and you can select your cert (or cancel)

Review URL: http://codereview.chromium.org/661241
------------------------------------------------------------------------
r40584 | chron@google.com | 2010-03-04 02:07:03 +0100 (Thu, 04 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sessions/session_state.h

Fix one valgrind bug.

Review URL: http://codereview.chromium.org/668024
------------------------------------------------------------------------
r40583 | mattm@chromium.org | 2010-03-04 01:48:42 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/uninstall_view.cc

Win: Grey out/remove default browser choices in side by side installs.

BUG=37125
TEST=run mini_installer.exe --chrome-sxs, should display message about being a secondary install instead of having a default browser checkbox.  In SxS options it should display the same message and have the default browser button greyed out.  Uninstall of SxS should not show default browser setting.

Review URL: http://codereview.chromium.org/661440
------------------------------------------------------------------------
r40580 | ian@chromium.org | 2010-03-04 01:47:37 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Enable "Remove All" button even if nothing is selected.

BUG=34886
TEST=Make sure "remove all" button is enabled even if nothing is selected in cookie manager.

Review URL: http://codereview.chromium.org/669003
------------------------------------------------------------------------
r40578 | feldstein@chromium.org | 2010-03-04 01:27:44 +0100 (Thu, 04 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Eliminate duplicate search result entries.

The history page renders each set of history results incrementally.  It adds any
results it gets back to the views "currentPages_" array.  On any following
search query result it will go through and render the entire currentPages_
array.  This sets an isRendered flag on any pages that have already been
rendered.

This method is already used in the regular history service response.

BUG=35933
TEST=In a profile with a few months of history, search for something unique that
only would show up once.

Review URL: http://codereview.chromium.org/668007
------------------------------------------------------------------------
r40575 | darin@chromium.org | 2010-03-04 01:27:01 +0100 (Thu, 04 Mar 2010) | 36 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_mac.mm
   A /trunk/src/chrome/browser/cookie_modal_dialog_uitest.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_views.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   A /trunk/src/chrome/test/data/cookie2.html

Test cookie prompting.

Adds automation plumbing to support changing the content settings.

This change also fixes WaitForNavigation to watch for the LOAD_STOP event
instead of the NAV_ENTRY_COMMITTED event.  This better matches the intent (I
think) of the automation interface, and it also matches the similar function
defined in ui_test_utils (used by browser tests).  This also better matches the
NavigationNotificationObserver, which seems desirable given the implementation
of AutomationProvider::WaitForNavigation.

It turns out that only one UI test was using WaitForNavigation, and I confirmed
that it still functions properly.

This change also modifies the NavigationNotificationObserver to allow it to
watch for the current page load to complete.  Normally, it waits for the first
LOAD_START or NAV_ENTRY_COMMITTED event to switch into the mode where it
watches for LOAD_STOP.  However, that makes it not so useful for
WaitForNavigation, which is intended to be called after triggering the start of
a new navigation.

This change also makes it so that the cookie prompt supports the automation
message box 'OK' and 'Cancel' buttons, so that we can remotely press those
buttons.

Leveraging all of these changes enables some basic cookie prompting tests to be
written.

I had to modify browser_frame_win.cc to ensure that BrowserList::SetLastActive
is called even while running under remote desktop.

R=phajdan.jr@chromium.org
BUG=37182
TEST=cookie_modal_dialog_uitest.cc

Review URL: http://codereview.chromium.org/661102
------------------------------------------------------------------------
r40573 | jcampan@chromium.org | 2010-03-04 01:26:44 +0100 (Thu, 04 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/chromium/app_launcher_button.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/chromeos/app_launcher.cc (from /trunk/src/chrome/browser/chromeos/main_menu.cc:39897)
   A /trunk/src/chrome/browser/chromeos/app_launcher.h (from /trunk/src/chrome/browser/chromeos/main_menu.h:39897)
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   D /trunk/src/chrome/browser/chromeos/main_menu.cc
   D /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/chrome_browser.gypi

First pass at revamping the main menu, now called app launcher.

BUG=None
TEST=Click the app launcher button (top left). The app launcher
     should be shown.

Review URL: http://codereview.chromium.org/661286
------------------------------------------------------------------------
r40572 | arv@chromium.org | 2010-03-04 01:23:00 +0100 (Thu, 04 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc

Hide the URL for all chrome_url_overrides.

BUG=37356
TEST=None


Review URL: http://codereview.chromium.org/669012
------------------------------------------------------------------------
r40570 | rvargas@google.com | 2010-03-04 00:51:19 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/net/http/http_cache_transaction.cc
   M /trunk/src/net/url_request/url_request_http_job.cc

Remove debug info used to diagnose bug 31723.

BUG=31723
TEST=none

Review URL: http://codereview.chromium.org/660431
------------------------------------------------------------------------
r40567 | jhawkins@chromium.org | 2010-03-04 00:33:51 +0100 (Thu, 04 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h

Fix a bug that was causing the AutoFill infobar to not show.  Initially the AutoFillEnabled preference is false, so we were bailing out before giving the chance to enable AutoFill.  This changes to guard to |personal_data_|, which is necessary for DeterminePossibleFieldTypes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/667018
------------------------------------------------------------------------
r40565 | arv@chromium.org | 2010-03-04 00:26:41 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc

Remove strings that are no longer used by the NTP.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/666007
------------------------------------------------------------------------
r40564 | johnnyg@chromium.org | 2010-03-04 00:22:30 +0100 (Thu, 04 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc

Initialize the GTK style for the balloon toolbar before creating any view objects.  Otherwise the first balloon doesn't get the style applied, although subsequent balloons do.

BUG=37355
TEST=create several notifications on linux, compare visually

Review URL: http://codereview.chromium.org/669001
------------------------------------------------------------------------
r40563 | chocobo@chromium.org | 2010-03-04 00:17:27 +0100 (Thu, 04 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/ip_config_view.cc
   M /trunk/src/chrome/browser/chromeos/options/ip_config_view.h
   A /trunk/src/chrome/browser/chromeos/options/network_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/network_config_view.h
   A /trunk/src/chrome/browser/chromeos/options/wifi_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/wifi_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/chrome_browser.gypi

Implement new wifi login dialog for ChromeOS.
Support for logging in to hidden networks.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661435
------------------------------------------------------------------------
r40558 | jcampan@chromium.org | 2010-03-04 00:01:10 +0100 (Thu, 04 Mar 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/test/testing_browser_process.h

The browser would crash when pressing the translate button in the infobar when the locale is Norvegian,
Filipino or any Chrome languages that the translation server does not support.
The crash would happen in the translate infobar, the source index would be
-1 and would cause us to crash accessing that index in a vector.
This CL fixes that by cleaning up the list of supported languages, so they
match Chrome's locales.
Also it makes sure we don't create an infobar if for any reason one of the
language (source or target) is not supported.

BUG=37218
TEST=For each language Chrome can be run into, select that language and open
     www.google.com. Check that the info-bar is shown for languages supported
     by the Google translate server (see the list at http://translate.google.com/)
     and for the supported language translating works.

Review URL: http://codereview.chromium.org/661434
------------------------------------------------------------------------
r40549 | finnur@chromium.org | 2010-03-03 23:14:40 +0100 (Wed, 03 Mar 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Adjust the test for the RSS extensions a little.

Do the testing in two steps instead of one:

1) Load the feed data and just verify that the extension detects the
   feed and shows a new tab. If that passes:
2) Directly load the feed data synchronously into the preview tab and
   validate the data.

Using this approach I can immediately validate the data after navigating
and don't have to rely on polling.

I'll look into removing the FLAKY label after I'm confident this works
on the build bots.

BUG=http://crbug.com/37109
TEST=This contains test changes.

Review URL: http://codereview.chromium.org/667004
------------------------------------------------------------------------
r40548 | xiyuan@chromium.org | 2010-03-03 23:11:33 +0100 (Wed, 03 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc

Fix issue 29996

WM_SETICON with NULL does not restore the icon on taskbar and caused
issue 29996. The fix is to figure out an icon to use after throbber
animation finishes and use that icon with WM_SETICON.

BUG=29996
TEST=Verify fix for issue 29996.

Review URL: http://codereview.chromium.org/660410
------------------------------------------------------------------------
r40543 | oshima@chromium.org | 2010-03-03 22:44:58 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.cc

This fixes the crash that happens when opening dev tools/javascript console.

BUG=37316
TEST=opening one of dev tools/javascript console won't crash chrome

Review URL: http://codereview.chromium.org/664002
------------------------------------------------------------------------
r40541 | asargent@chromium.org | 2010-03-03 22:42:07 +0100 (Wed, 03 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Make the js console open by default when you click to inspect an extension view

This has been a long-time pet peeve of mine that it takes an extra click for
the common case when you want to see console.log() output in the inspector for
a background page.

BUG=none
TEST=Load an extension with a background page in Developer Mode. Under "Inspect
active views", click on the link. The inspector should come up with the
javascript console shown.


Review URL: http://codereview.chromium.org/661418
------------------------------------------------------------------------
r40537 | erg@chromium.org | 2010-03-03 22:01:45 +0100 (Wed, 03 Mar 2010) | 1 line
Changed paths:
   D /trunk/src/chrome/browser/gtk/cookie_display_gtk.cc
   D /trunk/src/chrome/browser/gtk/cookie_display_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Reverting 40536 and 40535
------------------------------------------------------------------------
r40535 | erg@chromium.org | 2010-03-03 21:37:35 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/cookie_display_gtk.cc
   A /trunk/src/chrome/browser/gtk/cookie_display_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTK: Split out the cookie display into its own component for reuse in the cookie ask dialog.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/660459
------------------------------------------------------------------------
r40534 | avi@chromium.org | 2010-03-03 21:14:28 +0100 (Wed, 03 Mar 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Turns out making this opaque breaks the findbar overlapping... reverting 40532.

------------------------------------------------------------------------
r40533 | avi@chromium.org | 2010-03-03 21:08:31 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Remove ancient comments that aren't valid any more. The details have been filled in.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/664006
------------------------------------------------------------------------
r40532 | avi@chromium.org | 2010-03-03 21:00:56 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Fix flicker of themed window background by making the tab contents opaque (it doesn't draw but its children always cover the area)

BUG=http://crbug.com/29874
TEST=as in bug

Review URL: http://codereview.chromium.org/665004
------------------------------------------------------------------------
r40529 | rohitrao@chromium.org | 2010-03-03 20:27:28 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc

[Mac] When in fullscreen mode, ties the menubar shown state to the overlay shown state.

BUG=36610
TEST=Go fullscreen.  Menubar should only be shown when the overlay is fully visible.
TEST=While in fullscreen mode, fullscreen a youtube video.  Menubar should be autohidden (mousing to the top of the screen should show it).
Review URL: http://codereview.chromium.org/661380
------------------------------------------------------------------------
r40524 | skrul@chromium.org | 2010-03-03 19:41:05 +0100 (Wed, 03 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h

Improve autofill unit test
With chron's help, I was able to get rid of the whole TestModelAssocator thing and use the low level syncapi directly to create the server tagged autofill node before model association starts.  Because of this, I was able to revert to the original AutofillModelAssociator::AssociateModels() code that zork had and it now works fine in a test.

Review URL: http://codereview.chromium.org/661410
------------------------------------------------------------------------
r40522 | jrg@chromium.org | 2010-03-03 18:59:49 +0100 (Wed, 03 Mar 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_model_observer_for_cocoa.h
   A /trunk/src/chrome/browser/cocoa/bookmark_model_observer_for_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Cancel bookmark editing when changes happen suddenly.

BUG=http://crbug.com/32896, http://crbug.com/29122,
	   http://crbug.com/34369, http://crbug.com/34513,
	   http://crbug.com/34522

TEST=1)
Add some bookmarks.
Go to one of them.
Open the bookmark manager so that the current item is visible.
Click STAR to open the bubble.
Right-click on the item in the bookmark manager and pick Delete.
Watch bubble go away safely.
2) 
Create a bookmark folder.
Open the bookmark manager so that the folder is visible.
In Browser, right-click on folder in bar and pick Rename (to open sheet).
Now right-click that folder in the bookmark manager to edit it.
  And edit it in there...
On "return", the Edit sheet in the main browser window goes away.
3)
Right click any existing folder on BMB and Choose "Rename" option
(Leave sheet open...)
Open other new window via menu or dock and "Delete" the folder which we tried to "rename"  on first window
See sheet close in 1st window

Review URL: http://codereview.chromium.org/661335
------------------------------------------------------------------------
r40521 | tim@chromium.org | 2010-03-03 18:47:13 +0100 (Wed, 03 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Fix attempt for bug 34158. Reset the TalkMediator after calling Logout to ensure it is destroyed from the
core thread.  This ensures the task to destroy the GaiaAuth object is run on
the core thread and not the UI thread.

Fred and I debugged this together and actually saw a second crash appear to result
from this change, but then we did a clean build and were unable to repro that crash,
so I think this as a net win at the moment.

BUG=34158

Review URL: http://codereview.chromium.org/660437
------------------------------------------------------------------------
r40519 | avi@chromium.org | 2010-03-03 17:19:07 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm

Base coordinate system != Window base coordinate system. Fixing.

BUG=http://crbug.com/36485
TEST=everything should still work

Review URL: http://codereview.chromium.org/661322
------------------------------------------------------------------------
r40506 | bulach@chromium.org | 2010-03-03 12:18:18 +0100 (Wed, 03 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/geolocation_dispatcher.cc

Renames route_id to render_view_id
Uses host instead of origin
(in preparation for http://codereview.chromium.org/650180).

Review URL: http://codereview.chromium.org/661273
------------------------------------------------------------------------
r40502 | kasperl@google.com | 2010-03-03 11:33:44 +0100 (Wed, 03 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/dom/DOMException/prototype-object-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/DOMException/prototype-object-expected.txt
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Update WebKit to r55424. Rebaseline fast/dom/DOMException/prototype-object.html 
expectations after r55416 which fixed the V8 code generator to use the correct 
visible name for DOMException.

To make the WebGL layout tests continue to run on the Mac bots, I've pulled
in http://codereview.chromium.org/660354 and made sure that WebGL is also
enabled in the test shell.

BUG=37098
TEST=None
Review URL: http://codereview.chromium.org/660446
------------------------------------------------------------------------
r40494 | brettw@chromium.org | 2010-03-03 06:45:55 +0100 (Wed, 03 Mar 2010) | 22 lines
Changed paths:
   M /trunk/src/base/id_map.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/transport_dib.h
   D /trunk/src/chrome/renderer/mock_render_process.cc
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_devices.h
   D /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   A /trunk/src/chrome/renderer/render_process.cc (from /trunk/src/chrome/renderer/render_process.cc:40489)
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Revert 40490 - Make the pepper 2D flush callback actually function as advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.

This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.

I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.

This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.

TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/660439
------------------------------------------------------------------------
r40490 | brettw@chromium.org | 2010-03-03 06:03:22 +0100 (Wed, 03 Mar 2010) | 19 lines
Changed paths:
   M /trunk/src/base/id_map.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/transport_dib.h
   A /trunk/src/chrome/renderer/mock_render_process.cc
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_devices.h
   A /trunk/src/chrome/renderer/pepper_devices_unittest.cc
   D /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   A /trunk/src/chrome/renderer/render_process_impl.cc (from /trunk/src/chrome/renderer/render_process.cc:40132)
   A /trunk/src/chrome/renderer/render_process_impl.h (from /trunk/src/chrome/renderer/render_process.h:40132)
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Make the pepper 2D flush callback actually function as advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.

This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.

I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.

This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.

TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
------------------------------------------------------------------------
r40489 | skrul@chromium.org | 2010-03-03 05:39:25 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Fix autofill test hang
The common TestProfileSyncService did some unexpected things with message loops, so use a custom version for this test.  Hopfully in a more testable future we won't need magic testing classes such as this.

BUG=37244

Review URL: http://codereview.chromium.org/661423
------------------------------------------------------------------------
r40487 | finnur@chromium.org | 2010-03-03 05:01:11 +0100 (Wed, 03 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Attempt to fix remaining 3 tests for RSS.

I think the reason the negative feed parsing tests failed on the
bots is because the RSS extension has a generated ID that is
different from when you load it on a dev machine. So I now ask the
ExtensionService to provide the id during the run.

BUG=http://crbug.com/37109
TEST=Enabling test (although as flaky for now, until I get more
confidence that they are working).

Review URL: http://codereview.chromium.org/660424
------------------------------------------------------------------------
r40480 | rohitrao@chromium.org | 2010-03-03 03:03:08 +0100 (Wed, 03 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

[Mac] Deregister for the old windowWillClose/windowDidResignMain notifications when moving the BookmarkBar between windows.

BUG=37228
TEST=Go fullscreen and back.  Find a bookmarkbar folder with a subfolder.  Hover over the subfolder to open it, then move the mouse away.  Should not crash.
Review URL: http://codereview.chromium.org/661425
------------------------------------------------------------------------
r40479 | jschuh@google.com | 2010-03-03 02:57:38 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/net/base/net_util.cc

Handle CreateFile() trimming trailing dots and spaces in downloads.

BUG=37007
TEST=unit_tests --gtest_filter=DownloadManagerTest.*

Review URL: http://codereview.chromium.org/660297
------------------------------------------------------------------------
r40477 | jhawkins@chromium.org | 2010-03-03 02:57:07 +0100 (Wed, 03 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address.h
   M /trunk/src/chrome/browser/autofill/autofill_field.h
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   M /trunk/src/chrome/browser/autofill/contact_info.h
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/credit_card_unittest.cc
   M /trunk/src/chrome/browser/autofill/form_group.h
   M /trunk/src/chrome/browser/autofill/phone_number.h

Where possible, use return-by-const-ref for accessors in AutoFill data structures.  In addition, I fixed the access levels of many of the modified methods.

BUG=31775
TEST=none
Review URL: http://codereview.chromium.org/661421
------------------------------------------------------------------------
r40471 | arv@chromium.org | 2010-03-03 02:17:09 +0100 (Wed, 03 Mar 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css
   A /trunk/src/chrome/browser/resources/bookmark_manager/css/bmm.css.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager: Add drop down arrows to the drop down buttons.

This also moves the CSS out of main.html

BUG=4890
TEST=The "Organize" and "Tools" buttons should now have arrows next to them.


Review URL: http://codereview.chromium.org/661427
------------------------------------------------------------------------
r40470 | viettrungluu@chromium.org | 2010-03-03 01:53:25 +0100 (Wed, 03 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

Mac: Clean up fullscreen tracking rectangle code.

BUG=none
TEST=Make sure sliding bar still works properly in fullscreen mode.

Review URL: http://codereview.chromium.org/660419
------------------------------------------------------------------------
r40469 | albertb@chromium.org | 2010-03-03 01:46:31 +0100 (Wed, 03 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   A /trunk/src/chrome/browser/sync/unrecoverable_error_handler.h

Make DTCs implement the UnrecoverableErrorHandler interface so they can be
notified when model association fails.

BUG=36824
TEST=unit test

Review URL: http://codereview.chromium.org/660148
------------------------------------------------------------------------
r40468 | arv@chromium.org | 2010-03-03 01:40:40 +0100 (Wed, 03 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/dom_ui/bookmarks_ui.cc
   A /trunk/src/chrome/browser/dom_ui/bookmarks_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Add command line option to use a tabbed bookmark manager.

Start with --enable-tabbed-bookmark-manager. This will show chrome://bookmarks in a tab instead of the old bookmark manager. However, to get the bookmark manager extension to show you need to use --load-extension=path_to_extension. The extension uses the chrome_url_override to show the extension instead of the bookmark manager.

BUG=4890
TEST=See description

Review URL: http://codereview.chromium.org/661019
------------------------------------------------------------------------
r40465 | mbelshe@chromium.org | 2010-03-03 01:30:50 +0100 (Wed, 03 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h

Don't ignore certificate errors with SPDY.

For benchmarking and testing, we still want to be able to ignore the 
certificate errors, so I added a flag to the use-spdy option to do so:

   --ignore-certificate-errors

BUG=32020
TEST=none

Review URL: http://codereview.chromium.org/661375
------------------------------------------------------------------------
r40460 | oshima@chromium.org | 2010-03-03 00:47:09 +0100 (Wed, 03 Mar 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.cc
   A /trunk/src/chrome/browser/chromeos/notifications/balloon_collection_impl.h
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   A /trunk/src/chrome/browser/notifications/balloon_collection_impl.h (from /trunk/src/chrome/browser/notifications/balloon_collection.h:40459)
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.cc
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Refactoring balloon collection and added chromeos's BalloonCollection.
 * Separated BalloonCollection and BalloonCollectionImpl
 * Moved BalloonSpaceChangeListener to BalloonCollection from BalloonCollectionImpl as this listener is used by NotificationUIManager.
 * Added BalloonCollectionImpl for chromeos. (chromeos/notifications/balloon_collectino_impl.{h,cc})
 * Changed NotificationPanel to use ScrollView to show all notifications in the panel.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/660111
------------------------------------------------------------------------
r40459 | stuartmorgan@chromium.org | 2010-03-03 00:45:21 +0100 (Wed, 03 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/framework.order
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   A /trunk/src/webkit/glue/plugins/carbon_plugin_window_tracker_mac.cc (from /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc:40441)
   A /trunk/src/webkit/glue/plugins/carbon_plugin_window_tracker_mac.h
   D /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc
   D /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/webkit.gyp

Rename FakePluginWindowTracker

Removes confusion with the new "fake window" code related to the GPU process, and makes the name better reflect the reality of how the Carbon plugin windows are actually used since we no longer expect to replace them entirely with interposing.

BUG=none
TEST=none (no behavioral changes)

Review URL: http://codereview.chromium.org/660407
------------------------------------------------------------------------
r40457 | shess@chromium.org | 2010-03-03 00:32:41 +0100 (Wed, 03 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc

Checksum SafeBrowsingStoreFile.

MD5 checksum verifies that the file read is the file that was written.
Also added sanity checks for the file header to prevent interpretting
random garbage as a valid count.  Unit test corruption-detection.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/660334
------------------------------------------------------------------------
r40455 | estade@chromium.org | 2010-03-03 00:22:45 +0100 (Wed, 03 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

GTK: fix a task manager crasher.

When OnItemsRemoved() is called, we remove the items one by one. If there is more than one item being removed, we may ask the model about items that no longer exist.

This fix is speculative in the sense that I couldn't repro the crash.

BUG=37115
TEST=none

Review URL: http://codereview.chromium.org/660351
------------------------------------------------------------------------
r40454 | estade@chromium.org | 2010-03-03 00:22:32 +0100 (Wed, 03 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_drag.cc

GTK: fix hypothetical leak.

"Hypothetical" because the way this object is used right now, |event| will always be NULL anyway.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/660208
------------------------------------------------------------------------
r40451 | jhawkins@chromium.org | 2010-03-03 00:16:32 +0100 (Wed, 03 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete_history_manager.cc
   M /trunk/src/chrome/browser/autocomplete_history_manager.h
   M /trunk/src/chrome/browser/browser_prefs.cc

Fix the remaining instance of the obsolete kFormAutofillEnabled.

BUG=36640
TEST=none
Review URL: http://codereview.chromium.org/661393
------------------------------------------------------------------------
r40450 | jam@chromium.org | 2010-03-03 00:10:18 +0100 (Wed, 03 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Disable ProfileSyncServiceAutofillTest since they're causing hangs.

BUG=37244
Review URL: http://codereview.chromium.org/661411
------------------------------------------------------------------------
r40447 | davemoore@chromium.org | 2010-03-02 23:10:30 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Removed logic which made the container size 0 when recreating a tab contents

BUG=37048
TEST=Run browser, kill the renderer to get the sad tab, refresh the tab.
     The contents of the tab should be displayed.

Review URL: http://codereview.chromium.org/660262
------------------------------------------------------------------------
r40446 | erg@chromium.org | 2010-03-02 23:06:27 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/content_setting_combo_model.cc
   A /trunk/src/chrome/browser/content_setting_combo_model.h
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Moves ActionComboboxModel class to its own header so we can share common code between windows and linux.

BUG=None
TEST=compiles, and still works as before.

Review URL: http://codereview.chromium.org/661225
Patch from thiago.farina@gmail.com.
------------------------------------------------------------------------
r40444 | rsesek@chromium.org | 2010-03-02 23:02:54 +0100 (Tue, 02 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h

[Mac] Reduce jank in the cookie manager by batching updates from the model.

Subclass TreeModelObserver specifically for the CookiesTreeModel so that we can
send TreeModelBatchBegin() and BatchEnd() notifications before and after local
storage, databases, and appcache entries load, respectively.

This also rewrites CookiesTreeModelObserverBridge::FindCocoaNode() to do
breadth-first search, rather than a pre-order traversal as we most often search
for origin nodes, which are at depth 1.

BUG=35134
TEST=Get a profile with 1K local storage entries. Chromium-->Preferences-->Under the Hood-->Content Settings-->Cookies should not be slow/janky.

Review URL: http://codereview.chromium.org/660251
------------------------------------------------------------------------
r40441 | avi@chromium.org | 2010-03-02 22:53:33 +0100 (Tue, 02 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm

Fixing missed renamed variable.

TBR=pinkerton

Review URL: http://codereview.chromium.org/661403
------------------------------------------------------------------------
r40439 | avi@chromium.org | 2010-03-02 22:46:47 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Aggressively cache theme image pattern colors.

BUG=http://crbug.com/37106 (I hope)
TEST=no visible change, just faster

Review URL: http://codereview.chromium.org/661396
------------------------------------------------------------------------
r40436 | chron@google.com | 2010-03-02 22:38:53 +0100 (Tue, 02 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc

Move a debug string util to syncer proto util. Add better getupdates logging in debug builds.

Review URL: http://codereview.chromium.org/660346
------------------------------------------------------------------------
r40434 | scherkus@chromium.org | 2010-03-02 22:23:11 +0100 (Tue, 02 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   A /trunk/src/chrome/browser/renderer_host/video_layer_proxy.cc
   A /trunk/src/chrome/browser/renderer_host/video_layer_proxy.h
   M /trunk/src/chrome/browser/renderer_host/video_layer_x.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gpu_messages_internal.h
   A /trunk/src/chrome/gpu/gpu_video_layer_glx.cc
   A /trunk/src/chrome/gpu/gpu_video_layer_glx.h
   M /trunk/src/chrome/gpu/gpu_view_x.cc
   M /trunk/src/chrome/gpu/gpu_view_x.h

Laying down the groundwork for GPU video layers.

This gets --enable-video-layering working when using the GPU backing store.  No actual visuals yet, just IPC message passing and a lot of NOTIMPLEMENTED messages.

BUG=33329
TEST=try it out and see if you get lots of NOTIMPLEMENTED messages corresponding with video playback

Review URL: http://codereview.chromium.org/661344
------------------------------------------------------------------------
r40433 | arv@chromium.org | 2010-03-02 22:22:36 +0100 (Tue, 02 Mar 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/list.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/menu.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarktree.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/treeiterator.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/treeiterator_test.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm_test.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget_test.html
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise.js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/promise_test.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark manager fixes

1. Implement "Add page" and "Add folder".
2. Fix issue where dragging a folder to a subfolder regressed.
3. Disable "Open ..." on folders that have no bookmark descendandts.
4. Add bmm.TreeLoader so we can reuse the call to getTree.
5. Add bmm.TreeIterator so we do not have to duplicate tree traversal code.
6. Fix issue where fast changes in the tree caused infinite navigation hangs.
7. Add some more strings.
8. Remove old temporary hack for the strings since we really need the experimental API at this point anyway.
9. Prevent system beep on copy and cut.

BUG=32194, 36457, 36459
TEST=None

Review URL: http://codereview.chromium.org/660196
------------------------------------------------------------------------
r40431 | finnur@chromium.org | 2010-03-02 22:19:34 +0100 (Tue, 02 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Attempt to fix RSS feed tests that became flaky due to recent changes.

I left the tests marked Flaky, since I want to run on the bots to see
if it works before removing the label.

BUG=37109
TEST=This contains test changes.

Review URL: http://codereview.chromium.org/661394
------------------------------------------------------------------------
r40426 | eroman@chromium.org | 2010-03-02 21:58:44 +0100 (Tue, 02 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc

Fix a CHECK() being hit when the safebrowsing check times out (passing in empty URL but expecting the deferred URL).

BUG=37195,33572
TBR=wtc
Review URL: http://codereview.chromium.org/660396
------------------------------------------------------------------------
r40415 | shess@chromium.org | 2010-03-02 21:27:56 +0100 (Tue, 02 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

[Mac] Re-enable BrowserWindowFullScreenControllerTest.*.

r40185 (bug 36677) changed cocoa_test_helper.mm to allow more scalable
timeouts for valgrind.

BUG=36736
TEST=valgrind bots keep trucking.

Review URL: http://codereview.chromium.org/660389
------------------------------------------------------------------------
r40412 | scherkus@chromium.org | 2010-03-02 21:19:00 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add --enable-gpu-rendering instead of relying on a hardcoded constant.

BUG=33329
TEST=try it out on linux!!

Review URL: http://codereview.chromium.org/661331
------------------------------------------------------------------------
r40411 | dspringer@google.com | 2010-03-02 21:13:08 +0100 (Tue, 02 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/nacl_cmd_line.cc
   M /trunk/src/chrome/test/nacl/nacl_test.cc

Remove the --enable-nacl-on-mac flag, since the syscall thunking code is secure
now.  The mac no longer needs 2 flags in order to load .nexes, it is only
behind the --internal-nacl flag like everyone else.

BUG=328 (tracked in the Native Client project)
TEST=Run Chrome on a Mac without the --enable-nacl-on-mac flag, and load a
   .nexe.  It should work.

Review URL: http://codereview.chromium.org/661370
------------------------------------------------------------------------
r40408 | jhawkins@chromium.org | 2010-03-02 20:55:45 +0100 (Tue, 02 Mar 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autocomplete_history_manager.cc (from /trunk/src/chrome/browser/form_field_history_manager.cc:40291)
   A /trunk/src/chrome/browser/autocomplete_history_manager.h (from /trunk/src/chrome/browser/form_field_history_manager.h:40291)
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/form_field_history_manager.cc
   D /trunk/src/chrome/browser/form_field_history_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi

Rename FormFieldHistoryManager to AutocompleteHistory manager to better reflect its relation to the Autocomplete feature.

BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/661323
------------------------------------------------------------------------
r40407 | pkasting@chromium.org | 2010-03-02 20:37:16 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Clean up some of the frame code a bit.

The only functional change should be that the app panel close button width is now its preferred width, not its preferred width + 4.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660128
------------------------------------------------------------------------
r40406 | sky@chromium.org | 2010-03-02 20:36:25 +0100 (Tue, 02 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h

Lands http://codereview.chromium.org/652010 for Thiago:

views: refactor out the "Alt" TableView feature.

BUG=34181
TEST=open bookmarks manager, type something in the search text-field, see if a
message is showed when there is no match and see if everything still works as
before.

Review URL: http://codereview.chromium.org/660380
------------------------------------------------------------------------
r40404 | finnur@chromium.org | 2010-03-02 20:18:28 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Marking parse feed tests as flaky while I investigate.

BUG=http://crbug.com/37109
TEST=None
TBR=nsylvain

Review URL: http://codereview.chromium.org/661383
------------------------------------------------------------------------
r40403 | mpcomplete@chromium.org | 2010-03-02 20:14:45 +0100 (Tue, 02 Mar 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   M /trunk/src/chrome/common/notification_type.h

Further tweaks to incognito extensions.
- Add a warning to the incognito new tab page that your extensions are
disabled in that mode.
- Toggling an extension in incognito will reload the extension, fixing a bug
where browser actions in existing incognito windows would not get updated.

BUG=36292
BUG=32365
TEST=run chrome with --enable-experimental-extension-apis and some extensions loaded, and open an incognito window. Enable some extensions in incognito and make sure things work.

Review URL: http://codereview.chromium.org/660220
------------------------------------------------------------------------
r40402 | ananta@chromium.org | 2010-03-02 20:13:00 +0100 (Tue, 02 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi.h
   M /trunk/src/chrome_frame/npapi_url_request.cc
   M /trunk/src/chrome_frame/npapi_url_request.h
   M /trunk/src/chrome_frame/plugin_url_request.h
   M /trunk/src/chrome_frame/test/automation_client_mock.h
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/chrome_frame/test/test_mock_with_web_server.cc
   M /trunk/src/chrome_frame/test/url_request_test.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/chrome_frame/urlmon_url_request.h

ChromeFrame should honor the host browser's cookie policy. To achieve this we always read the cookies from
the host browser when the renderer requests them. This also cleans up the mess with the host network stack
code parsing cookies from the host looking for persistent cookies.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151

Bug=34151
Test=Covered by existing host network stack tests and chrome frame cookie tests.

Review URL: http://codereview.chromium.org/661290
------------------------------------------------------------------------
r40396 | albertb@google.com | 2010-03-02 20:00:19 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Wrap InternalSessionRequest in a scoped_refptr.

BUG=37138
TEST=Valgrind reports no errors

Review URL: http://codereview.chromium.org/660322
------------------------------------------------------------------------
r40391 | erg@chromium.org | 2010-03-02 19:26:56 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Experimental fix to fix the flaky AutomatedUITestBase.CloseTab.

BUG=14774
TEST=AutoamtedUITestBase.FLAKY_CloseTab stops being flaky?

Review URL: http://codereview.chromium.org/660324
------------------------------------------------------------------------
r40388 | finnur@chromium.org | 2010-03-02 19:07:51 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disabling three tests that I had marked flaky to get debug info.

TEST=None
BUG=None
TBR=mmoss
Review URL: http://codereview.chromium.org/661374
------------------------------------------------------------------------
r40387 | snej@chromium.org | 2010-03-02 18:47:02 +0100 (Tue, 02 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
   A /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.cc
   A /trunk/src/chrome/browser/ssl/ssl_add_cert_handler.h
   A /trunk/src/chrome/browser/ssl/ssl_add_cert_handler_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/cert_database.h
   M /trunk/src/net/base/cert_database_mac.cc
   M /trunk/src/net/base/cert_database_nss.cc
   M /trunk/src/net/base/cert_database_win.cc
   M /trunk/src/net/base/keygen_handler.h
   M /trunk/src/net/base/keygen_handler_mac.cc
   M /trunk/src/net/base/keygen_handler_nss.cc
   A /trunk/src/net/base/keygen_handler_unittest.cc
   M /trunk/src/net/base/keygen_handler_win.cc
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/net.gyp

Mac: implement <keygen> support, including adding generated cert to the Keychain.
BUG=34607
TEST=KeygenHandlerTest.SmokeTest

Review URL: http://codereview.chromium.org/652137
------------------------------------------------------------------------
r40386 | erg@chromium.org | 2010-03-02 18:41:44 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Fix browser side handling of moveTo by resizing the content area; not the window.

BUG=27365
TEST=none

Review URL: http://codereview.chromium.org/661187
------------------------------------------------------------------------
r40384 | dhg@chromium.org | 2010-03-02 17:35:00 +0100 (Tue, 02 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Adding support for selecting a directory.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660345
------------------------------------------------------------------------
r40383 | avi@chromium.org | 2010-03-02 16:26:25 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Fix background tabs in themes that don't specify a background tab image.

BUG=http://crbug.com/37117
TEST=as in comment 2 of bug.

Review URL: http://codereview.chromium.org/661310
------------------------------------------------------------------------
r40382 | avi@chromium.org | 2010-03-02 16:25:06 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Dragged tabs should be themed.

BUG=http://crbug.com/37077
TEST=as in bug; drag off a tab and it should stay themed

Review URL: http://codereview.chromium.org/660302
------------------------------------------------------------------------
r40381 | avi@chromium.org | 2010-03-02 16:24:27 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Update the default color for background tab text.

BUG=http://crbug.com/37078
TEST=as in bug

Review URL: http://codereview.chromium.org/660307
------------------------------------------------------------------------
r40380 | avi@chromium.org | 2010-03-02 16:23:58 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.h
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Pinstripe the top of the browser window to give it that 3D effect.

BUG=http://crbug.com/36794
TEST=as in bug

Review URL: http://codereview.chromium.org/660305
------------------------------------------------------------------------
r40378 | shess@chromium.org | 2010-03-02 15:22:29 +0100 (Tue, 02 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm

[Mac] Spin event loop longer for tearing down test windows.

BookmarkBubbleControllerTest needs _three_ passes.  I believe it's
because the bubble is a child window.

BUG=none
TEST=allows test to run on tsan bots.

Review URL: http://codereview.chromium.org/661347
------------------------------------------------------------------------
r40376 | dpolukhin@google.com | 2010-03-02 13:50:15 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Relayout root view in OnWindowPosChanged because when we process this message without calling DefWindowProc we don't get OnSize notification.

BUG=36280
TEST=See steps to reproduce in the bug.

Review URL: http://codereview.chromium.org/660087
------------------------------------------------------------------------
r40369 | phajdan.jr@chromium.org | 2010-03-02 10:16:44 +0100 (Tue, 02 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/certificate_manager.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   A /trunk/src/chrome/browser/gtk/gtk_tree.cc (from /trunk/src/chrome/common/gtk_tree.cc:40221)
   A /trunk/src/chrome/browser/gtk/gtk_tree.h (from /trunk/src/chrome/common/gtk_tree.h:40221)
   A /trunk/src/chrome/browser/gtk/gtk_util.cc (from /trunk/src/chrome/common/gtk_util.cc:40221)
   A /trunk/src/chrome/browser/gtk/gtk_util.h (from /trunk/src/chrome/common/gtk_util.h:40221)
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/process_singleton_dialog.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/js_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_preferences_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/gtk_tree.cc
   D /trunk/src/chrome/common/gtk_tree.h
   D /trunk/src/chrome/common/gtk_util.cc
   D /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc

Next part of bad dependency removal (chrome/common -> chrome/browser)

This change introduces one more dependency on chrome/browser,
but it seems simpler to move gtk_util first and then fix it.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661271
------------------------------------------------------------------------
r40364 | brettw@chromium.org | 2010-03-02 06:51:17 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc

The search terms escaping respect forward slash: it is not escaped if the replacement preceeds ? sign. 

BUG=19718
Patch by glotov@chromium.org
Original review http://codereview.chromium.org/601004
TEST=Verify that slash is escaped as stated in description; example: create
search engine en.wikipedia.org/%s and search it with parameters wiki/hi
------------------------------------------------------------------------
r40362 | thakis@chromium.org | 2010-03-02 06:22:54 +0100 (Tue, 02 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/base/cocoa_protocols_mac.h
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm

Mac: Select right tab in content settings dialog.

Also fix an unrelated TODO in this area.

xib change: Make ContentSettingsWindowController the NSTabView's delegate and hook the controller's IBOutlet up to the NSTabView.

BUG=36949
TEST=Open content settings via a blocked popups bubble. Popup tab should be selected. Select javascript tab, close window. Reopen window, javascript tab should still be selected.

Review URL: http://codereview.chromium.org/661354
------------------------------------------------------------------------
r40359 | skrul@chromium.org | 2010-03-02 06:00:03 +0100 (Tue, 02 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/chrome_tests.gypi

Unit test for autofill sync.
Including some changes to make things testable, including adding WebDatabase* to the ctor of the MA and PC, plus making some methods virtual on WebDatabase.

Review URL: http://codereview.chromium.org/661316
------------------------------------------------------------------------
r40358 | eroman@chromium.org | 2010-03-02 05:53:31 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_queue_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.h

Make all of the methods of ResourceHandler pure virtual.

This forces implementations to consider each case, and avoids subtle bugs that can happen by using the default no-op implementation (like bug 36964).

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/661236
------------------------------------------------------------------------
r40354 | finnur@chromium.org | 2010-03-02 05:10:59 +0100 (Tue, 02 Mar 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/common.js
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/options.html
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/subscribe.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

RSS feed subscription localization, part 2. 

Re-enabling the tests that were disabled in the first pass.

Also changing how we substitute localization values (using direct method that avoids flashing __MSG__const while the page is loading).

Also made some minor fixes after testing various locales.

BUG=37109
TEST=This CL is about enabling automated tests.

Review URL: http://codereview.chromium.org/660328
------------------------------------------------------------------------
r40346 | chron@google.com | 2010-03-02 03:01:54 +0100 (Tue, 02 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc

Add home button to synced prefs.

Review URL: http://codereview.chromium.org/661343
------------------------------------------------------------------------
r40345 | jhawkins@chromium.org | 2010-03-02 02:51:05 +0100 (Tue, 02 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Fix the content page of the options dialog to use kAutoFillEnabled instead of the obsolete kFormAutofillEnabled.

BUG=36640
TEST=none
Review URL: http://codereview.chromium.org/661327
------------------------------------------------------------------------
r40344 | thakis@chromium.org | 2010-03-02 02:50:15 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm

Mac: Fix crash in content settings exceptions window.

BUG=37137
TEST=See bug. Also, hit "add" and "remove" in succession, shouldn't crash either.

Review URL: http://codereview.chromium.org/661326
------------------------------------------------------------------------
r40343 | johnnyg@chromium.org | 2010-03-02 02:43:13 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc

Change some desktop notifications layout parameters to be per-platform rather than universal, and put mac notifications in the upper right as requested.

BUG=34826
TEST=create notifications on all platforms

Review URL: http://codereview.chromium.org/661333
------------------------------------------------------------------------
r40342 | estade@chromium.org | 2010-03-02 02:38:48 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Spellchecker: make it work with memory purge button.

BUG=30463
TEST=see bug

Review URL: http://codereview.chromium.org/661234
------------------------------------------------------------------------
r40341 | zork@google.com | 2010-03-02 02:35:02 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc

Add database model worker to worker registry and remove deprecated thread
check.

BUG=29926
TEST=Attempt to sync Autofill with a dev server.

Review URL: http://codereview.chromium.org/660343
------------------------------------------------------------------------
r40340 | dhollowa@chromium.org | 2010-03-02 02:15:38 +0100 (Tue, 02 Mar 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h

Add extra DCHECKs to the AutoFillManager class.  This is follow-up for review http://codereview.chromium.org/661297.

BUG=36938
TEST=none


Review URL: http://codereview.chromium.org/660329
------------------------------------------------------------------------
r40338 | tony@chromium.org | 2010-03-02 02:14:02 +0100 (Tue, 02 Mar 2010) | 14 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/download/save_package.cc

Modified SavePackage(TabContents* tab_contents) of save_package.cc.
Used the same fix provided for issue 12748.

This is done to retrieve actual url of the web page displayed in tab instead of displayed url.
Displayed url is different from actual url when viewing source of a web page.
ex: view-source:http://www.google.lk/
This is the reason why chrome fails to save source of web page.

BUG = 23584
TEST= Visit a web page. Right click and select "view page source". Right click and select Save as. Select web page complete
      in save dialog. Click save. Source is saved without being cancelled.
      Repeat the above steps, but select web page only instead of complete in save dialog. Source is saved without chrome getting crashed.

Review URL: http://codereview.chromium.org/660264
------------------------------------------------------------------------
r40323 | skrul@chromium.org | 2010-03-02 00:51:46 +0100 (Tue, 02 Mar 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Fix crash in ProfileSyncService on ChromiumOS.

Review URL: http://codereview.chromium.org/661306
------------------------------------------------------------------------
r40321 | cira@google.com | 2010-03-02 00:44:31 +0100 (Tue, 02 Mar 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Revert 40313 - Revert 40305  Fix for cases when info bar is stealing focus on Windows

Flaky test, going back to original.

TEST=in the bug
BUG=36943
Review URL: http://codereview.chromium.org/660218

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/661312

TBR=cira@google.com
Review URL: http://codereview.chromium.org/661320
------------------------------------------------------------------------
r40317 | slightlyoff@chromium.org | 2010-03-02 00:33:56 +0100 (Tue, 02 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds a command line flag to suppress flashing blinking for those who really, REALLY want it to stop.

BUG=None
TEST=load tons of tabs after starting with --disable-backing-store-limit and observe no blinking and HUGE memory usage.

Review URL: http://codereview.chromium.org/660224
------------------------------------------------------------------------
r40313 | cira@google.com | 2010-03-01 23:53:43 +0100 (Mon, 01 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Revert 40305 - Fix for cases when info bar is stealing focus on Windows

Breaking Mac 10.5 tests.

TEST=in the bug
BUG=36943
Review URL: http://codereview.chromium.org/660218

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/661312
------------------------------------------------------------------------
r40308 | rsesek@chromium.org | 2010-03-01 23:30:51 +0100 (Mon, 01 Mar 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm

Re-land r40275 (broke TabRestoreUITest.RestoreIntoSameWindow).

[Mac] Add favicons to the history menu.

BUG=20464
TEST=Open History menu, see icons.
Original CL: http://codereview.chromium.org/660250

As a side effect of fixing the bustage, we no longer list duplicate sites in
the "Recently Closed" section.

BUG=21314
TEST=Open and navigate two three different sites. Close the first one. History menu has 1 closed site. Close second tab. Should see both sites listed under "Recently Closed" exactly once.

Review URL: http://codereview.chromium.org/660282
------------------------------------------------------------------------
r40305 | georgey@chromium.org | 2010-03-01 23:12:52 +0100 (Mon, 01 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Fix for cases when info bar is stealing focus on Windows
TEST=in the bug
BUG=36943
Review URL: http://codereview.chromium.org/660218
------------------------------------------------------------------------
r40304 | zork@google.com | 2010-03-01 23:06:21 +0100 (Mon, 01 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   A /trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/autofill_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/autofill_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/autofill_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/webdata/autofill_entry.cc
   M /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add autofill Change Processor and Model Associator

BUG=29926
TEST=none

Review URL: http://codereview.chromium.org/628003
------------------------------------------------------------------------
r40302 | jhawkins@chromium.org | 2010-03-01 22:45:06 +0100 (Mon, 01 Mar 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Check for a non-NULL PersonalDataManager when determining if AutoFill is enabled.  The PersonalDataManager is NULL when OTR.

BUG=36938
TEST=New incognito window. gmail.com logged in. Compose mail. Type in subject line. No crash.
Review URL: http://codereview.chromium.org/661297
------------------------------------------------------------------------
r40293 | avi@chromium.org | 2010-03-01 21:24:06 +0100 (Mon, 01 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm

Fix crash when download shelf had no theme.

BUG=http://crbug.com/36951
TEST=quit with download shelf open; don't crash

Review URL: http://codereview.chromium.org/660300
------------------------------------------------------------------------
r40290 | cira@google.com | 2010-03-01 21:01:05 +0100 (Mon, 01 Mar 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ar
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ar/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/bg
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/bg/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ca
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ca/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/cs
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/cs/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/da
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/da/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/de
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/de/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/el
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/el/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/en
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/en/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/en_GB
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/en_GB/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/es
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/es/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/es_419
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/es_419/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/et
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/et/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/fi
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/fi/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/fil
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/fil/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/fr
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/fr/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/he
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/he/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/hi
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/hi/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/hr
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/hr/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/hu
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/hu/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/id
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/id/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/it
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/it/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ja
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ja/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ko
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ko/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/lt
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/lt/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/lv
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/lv/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/nb
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/nb/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/nl
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/nl/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/pl
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/pl/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/pt_BR
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/pt_BR/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/pt_PT
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/pt_PT/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ro
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ro/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ru
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/ru/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sk
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sk/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sl
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sl/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sr
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sr/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sv
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/sv/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/th
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/th/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/tr
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/tr/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/uk
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/uk/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/vi
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/vi/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/zh_CN
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/zh_CN/messages.json
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/zh_TW
   A /trunk/src/chrome/test/data/extensions/subscribe_page_action/_locales/zh_TW/messages.json
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/common.js
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/manifest.json
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/options.html
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/popup.html
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/subscribe.html
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/subscribe.js

Adding l10n to rss subscription extension.
Disabling ExtensionBrowserTest.ParseFeed* tests. Will file P1 against Finnur.

Review URL: http://codereview.chromium.org/660147
------------------------------------------------------------------------
r40285 | agl@chromium.org | 2010-03-01 19:50:22 +0100 (Mon, 01 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Fix SSLUITest.TestHTTPSErrorWithNoNavEntry

TEST=SSLUITest.TestHTTPSErrorWithNoNavEntry
BUG=none

http://codereview.chromium.org/660206
------------------------------------------------------------------------
r40284 | albertb@google.com | 2010-03-01 19:44:38 +0100 (Mon, 01 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc

Added a new method to SessionService that returns a snapshot of the current
session. The snapshot is computed directly from memory or, if there are
pending closed windows, by reading the session commands from disk.

BUG=35040
TEST=unit tests

Review URL: http://codereview.chromium.org/661055
------------------------------------------------------------------------
r40277 | rsesek@chromium.org | 2010-03-01 16:30:31 +0100 (Mon, 01 Mar 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm

Revert 40275 - Maybe broke TabRestoreUITest.RestoreIntoSameWindow? - [Mac] Add favicons to the history menu

BUG=20464
TEST=Open History menu, see icons.

Review URL: http://codereview.chromium.org/660250

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/660277
------------------------------------------------------------------------
r40275 | rsesek@chromium.org | 2010-03-01 15:56:07 +0100 (Mon, 01 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm

[Mac] Add favicons to the history menu

BUG=20464
TEST=Open History menu, see icons.

Review URL: http://codereview.chromium.org/660250
------------------------------------------------------------------------
r40274 | avayvod@google.com | 2010-03-01 15:55:22 +0100 (Mon, 01 Mar 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   D /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   D /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   D /trunk/src/chrome/browser/chromeos/login/test_renderer_screen.cc
   D /trunk/src/chrome/browser/chromeos/login/test_renderer_screen.h
   A /trunk/src/chrome/browser/chromeos/login/view_screen.h
   A /trunk/src/chrome/browser/chromeos/login/wizard_controller.cc (from /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc:40107)
   A /trunk/src/chrome/browser/chromeos/login/wizard_controller.h (from /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h:40107)
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h
   A /trunk/src/chrome/browser/chromeos/login/wizard_window.cc (from /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc:40107)
   M /trunk/src/chrome/chrome_browser.gypi

Separated wizard and screens from actual views.
Removed --login-screen switch and unused files.
Implemented loading of mobile account creation gaia page.

BUG=None
TEST=If user logged in at least once, login screen should appear on startup.
Otherwise network selection screen should appear first. All the rest should
work as usual.

Review URL: http://codereview.chromium.org/650141
------------------------------------------------------------------------
r40255 | suzhe@chromium.org | 2010-03-01 05:49:06 +0100 (Mon, 01 Mar 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/chrome/common/native_web_keyboard_event_win.cc

[Linux]Improve keyboard event handling code of RWHV.

Just like what Mac port already did, this CL changes the method to determine if a keyboard event should be processed by the browser to use a boolean field instead of setting the keyval of os_event to GDK_VoidSymbol. Because in some cases, GDK_VoidSymbol might be valid key value, for example ctrl-b on Arabic keyboard.

BUG=35117 Emacs key binding ctrl-b doesn't work in web page when using Arabic keyboard layout.
TEST=Enable Emacs key theme and switch to Arabic keyboard layout, then try ctrl-b (move cursor backwards) in web page's text area.

Review URL: http://codereview.chromium.org/661149
------------------------------------------------------------------------
r40254 | tony@chromium.org | 2010-03-01 05:24:30 +0100 (Mon, 01 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc

chromeos: Move hard-coded strings to grd file and use l10n_util to get them.

BUG=None
TEST=works as before.

Review URL: http://codereview.chromium.org/652019
------------------------------------------------------------------------
r40251 | suzhe@chromium.org | 2010-03-01 03:41:54 +0100 (Mon, 01 Mar 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac]Fix crash when inserting special characters from "Characters" dialog.

BUG=36780
TEST=Try to insert any special character into a web page from the "Characters" dialog.

Review URL: http://codereview.chromium.org/660076
------------------------------------------------------------------------
r40250 | ukai@chromium.org | 2010-03-01 03:37:13 +0100 (Mon, 01 Mar 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/socket_stream/socket_stream.h
   A /trunk/src/net/socket_stream/socket_stream_job.cc
   A /trunk/src/net/socket_stream/socket_stream_job.h
   A /trunk/src/net/socket_stream/socket_stream_job_manager.cc
   A /trunk/src/net/socket_stream/socket_stream_job_manager.h
   A /trunk/src/net/websockets/websocket_job.cc
   A /trunk/src/net/websockets/websocket_job.h
   A /trunk/src/net/websockets/websocket_job_unittest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/layout_tests/webkitpy/layout_tests/layout_package/websocket_server.py
   M /trunk/src/webkit/tools/test_shell/simple_socket_stream_bridge.cc

Support HttpOnly cookie on Web Socket

Web Socket should send "HttpOnly" cookie when handshaking.
In WebKit/WebCore, WebSocketHandshake uses cookieRequestHeaderFieldValue() to
get cookies including HttpOnly cookie.  However, Chrome doesn't trunk renderer
process, so we're not allowed to access HttpOnly cookie in WebCore.
Thus, we handle HttpOnly cookies in browser process.

Add SocketStreamJob as interface for protocol specific handling on
SocketStream.
WebSocketJob implements Web Socket specific handling.  For now, it handles
cookies in Web Socket.  It checks Web Socket handshake request message
from renderer process, and replaces Cookie: header to include HttpOnly cookies.
It also checks Web Socket handshake response message, sets cookies if any,
and strips Set-Cookie: header, so that renderer process couldn't see
Set-Cookie: header.

BUG=35660
TEST=net_unittests and layout_tests passes

Review URL: http://codereview.chromium.org/601077
------------------------------------------------------------------------
r40245 | evan@chromium.org | 2010-02-28 18:33:31 +0100 (Sun, 28 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc

linux: touchups on the cookie prompt dialog

Just random polish while I have a few minutes left today...

Review URL: http://codereview.chromium.org/660182
------------------------------------------------------------------------
r40224 | phajdan.jr@chromium.org | 2010-02-27 15:34:12 +0100 (Sat, 27 Feb 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/appcache
   A /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.cc (from /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc:40009)
   A /trunk/src/chrome/browser/appcache/appcache_dispatcher_host.h (from /trunk/src/chrome/common/appcache/appcache_dispatcher_host.h:40009)
   A /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.cc (from /trunk/src/chrome/common/appcache/appcache_frontend_proxy.cc:40221)
   A /trunk/src/chrome/browser/appcache/appcache_frontend_proxy.h (from /trunk/src/chrome/common/appcache/appcache_frontend_proxy.h:40221)
   A /trunk/src/chrome/browser/appcache/chrome_appcache_service.cc (from /trunk/src/chrome/common/appcache/chrome_appcache_service.cc:40009)
   A /trunk/src/chrome/browser/appcache/chrome_appcache_service.h (from /trunk/src/chrome/common/appcache/chrome_appcache_service.h:40009)
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc
   D /trunk/src/chrome/common/appcache/appcache_dispatcher_host.h
   D /trunk/src/chrome/common/appcache/appcache_frontend_proxy.cc
   D /trunk/src/chrome/common/appcache/appcache_frontend_proxy.h
   D /trunk/src/chrome/common/appcache/chrome_appcache_service.cc
   D /trunk/src/chrome/common/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc

Continue removing bad dependency of chrome/common on chrome/browser

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661178
------------------------------------------------------------------------
r40208 | eroman@chromium.org | 2010-02-27 04:43:40 +0100 (Sat, 27 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h

Make sure SafeBrowsingResourceHandler overrides ResourceHandler::OnRequestClosed() so it doesn't inherit the default (unfortunately the base class doesn't define it as pure virtual).

BUG=36964
TBR=rvargas

Review URL: http://codereview.chromium.org/660240
------------------------------------------------------------------------
r40206 | cmasone@google.com | 2010-02-27 04:27:43 +0100 (Sat, 27 Feb 2010) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/login/image_background.h
   M /trunk/src/chrome/chrome_browser.gypi

Removing some now-unused headers.
Review URL: http://codereview.chromium.org/658001
------------------------------------------------------------------------
r40205 | michaeln@chromium.org | 2010-02-27 04:22:45 +0100 (Sat, 27 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h

Clearly identify extension and file:// resources in the cookie tree view.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/660236
------------------------------------------------------------------------
r40203 | huanr@chromium.org | 2010-02-27 03:34:04 +0100 (Sat, 27 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_sxs_distribution.h
   M /trunk/src/chrome/installer/util/shell_util.cc

Disable registering, unregistering, and setting default browser
for sxs install.

BUG=35574
TEST="setup.exe --chrome-sxs"

Review URL: http://codereview.chromium.org/660168
------------------------------------------------------------------------
r40202 | thakis@chromium.org | 2010-02-27 03:30:09 +0100 (Sat, 27 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedCookies.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedImages.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedJavaScript.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPopups.xib
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc

Rename button from "Close" to "Done" on bookmark bubble and content bubbles.

xib changes: Change ^IDS_CLOSE to ^IDS_DONE.

BUG=36959
TEST=Open bookmark bubble. Button should read "Done". Go to popuptest.com, click "popups blocked" icon. Button in bubble should read "Done".

Review URL: http://codereview.chromium.org/661235
------------------------------------------------------------------------
r40194 | nsylvain@chromium.org | 2010-02-27 02:35:16 +0100 (Sat, 27 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc

Fix compile error : " error: open with O_CREAT in second argument needs 3 arguments"

Review URL: http://codereview.chromium.org/660191
------------------------------------------------------------------------
r40190 | dumi@chromium.org | 2010-02-27 02:22:44 +0100 (Sat, 27 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/test/data/extensions/storage_quota
   A /trunk/src/chrome/test/data/extensions/storage_quota/limited_quota
   A /trunk/src/chrome/test/data/extensions/storage_quota/limited_quota/1.0
   A /trunk/src/chrome/test/data/extensions/storage_quota/limited_quota/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/storage_quota/unlimited_quota
   A /trunk/src/chrome/test/data/extensions/storage_quota/unlimited_quota/1.0
   A /trunk/src/chrome/test/data/extensions/storage_quota/unlimited_quota/1.0/manifest.json
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h
   M /trunk/src/webkit/database/database_util.cc
   M /trunk/src/webkit/database/database_util.h

Reset the default quota limit for extensions to 5MB, but add a
unlimited_quota permission that extensions can use to request
unlimited quota.

TEST=ExtensionsServiceTest.StorageQuota
BUG=27688


Review URL: http://codereview.chromium.org/660113
------------------------------------------------------------------------
r40188 | chocobo@chromium.org | 2010-02-27 02:09:37 +0100 (Sat, 27 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc

Fix ChromeOS crash when device_path is NULL.
TEST=None
BUG=1698
Review URL: http://codereview.chromium.org/661230
------------------------------------------------------------------------
r40186 | shess@chromium.org | 2010-02-27 01:39:24 +0100 (Sat, 27 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h

Convert SafeBrowsingStoreFile to do bulk reads and writes.

Read/write the data in the style of fread/fwrite, rather than doing
I/O element by element.  This lays the groundwork for adding
checksumming.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39619

Review URL: http://codereview.chromium.org/650113
------------------------------------------------------------------------
r40185 | shess@chromium.org | 2010-02-27 01:37:42 +0100 (Sat, 27 Feb 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm

[Mac] Make CocoaTest::TearDown() more scalable in the face of valgrind.

Changes from std::vector<> to std::set<> because set_difference()
works on sorted inputs.

The loop is broken into two parts.  The outer loop continues
while progress is being made.  The inner loop spins the event
loop while:
 - no progress has been made; and
   - it hasn't spun enough times; or
   - it hasn't spun for long enough

The odd timeout calculation is because some sequences need the
event loop spun after a timeout, not until a timeout (difference
between taking the time at the start and at the end).

As long as I was changing comments, I (hopefully) removed the
royal "We" in appeasement of The Mentovai.

BUG=36677
TEST=tests continue to work, even under valgrind

Review URL: http://codereview.chromium.org/660213
------------------------------------------------------------------------
r40184 | eroman@chromium.org | 2010-02-27 01:37:41 +0100 (Sat, 27 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h

Rework SafeBrowsingResourceHandler.

Most notably, don't start the request until the URL has been verified.

The previous behavior was to overlap the retrieval of the request's headers with the URL check.
This meant that cookies from blocked pages got applied, and also that the renderer received the headers for blocked pages, and other awkwardness.

Blocking before the request has started also has the advantage of protecting against malware URLs that might exploit bugs in the HTTP stack itself (as the request is never started).

In terms of performance, overlapping had the benefit that the request gets a head start while the URL is being verified.
In practice I don't think this is actually significant, since we rely on low bloom filter false positives to avoid these extended checks in the first place. Hence optimizing for the uncommon case of extended checks isn't fruitful, especially when it comes at the cost of complexity.

I don't have unit-tests for this yet since there wasn't an existing framework to put them in (apparantly there are no safe browsing unit tests for ResourceDispatcherHost?).
I will follow up with another CL that does the necessary surgery to add such tests in resource_dispatcher_host_unittest.cc.

BUG=33572,36046
TEST=see bugs.
Review URL: http://codereview.chromium.org/661072
------------------------------------------------------------------------
r40181 | michaeln@chromium.org | 2010-02-27 00:45:35 +0100 (Sat, 27 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/browsing_data_appcache_helper.cc
   A /trunk/src/chrome/browser/browsing_data_appcache_helper.h
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   A /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.cc
   A /trunk/src/chrome/browser/mock_browsing_data_appcache_helper.h
   A /trunk/src/chrome/browser/views/appcache_info_view.cc (from /trunk/src/chrome/browser/views/local_storage_info_view.cc:39380)
   A /trunk/src/chrome/browser/views/appcache_info_view.h (from /trunk/src/chrome/browser/views/local_storage_info_view.h:39380)
   M /trunk/src/chrome/browser/views/database_info_view.cc
   M /trunk/src/chrome/browser/views/database_info_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Teach the cookie tree view and model about appcaches. Not hooked up to real data yet, but the view and model pieces are in place for windows and gtk (not yet done for the mac).

Also adds a 'name' attribute to database details pane, cleans up the layout of the detail panes on windows.

BUG=25977
TEST=manual

Review URL: http://codereview.chromium.org/650110
------------------------------------------------------------------------
r40179 | chron@google.com | 2010-02-27 00:43:05 +0100 (Sat, 27 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc

Use syncable hashes that are base64.

Review URL: http://codereview.chromium.org/660209
------------------------------------------------------------------------
r40173 | avi@chromium.org | 2010-02-26 23:41:00 +0100 (Fri, 26 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   D /trunk/src/chrome/browser/cocoa/GTMTheme.h
   D /trunk/src/chrome/browser/cocoa/GTMTheme.m
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.h
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   D /trunk/src/chrome/browser/cocoa/browser_theme_provider_init.h
   D /trunk/src/chrome/browser/cocoa/browser_theme_provider_init.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/themed_window.h
   M /trunk/src/chrome/browser/cocoa/themed_window.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view.mm
   M /trunk/src/chrome/chrome_browser.gypi

Finishing removal of GTMTheme. All incognito drawing is now correct, themed or not.

BUG=http://crbug.com/35554 ; http://crbug.com/18568
TEST=everything should still work, all themes should draw correctly

Review URL: http://codereview.chromium.org/661206
------------------------------------------------------------------------
r40172 | mattm@chromium.org | 2010-02-26 23:38:20 +0100 (Fri, 26 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/chrome_browser.gypi
   A /trunk/src/chrome/third_party/mozilla_security_manager
   A /trunk/src/chrome/third_party/mozilla_security_manager/README.chromium
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertificate.cpp
   A /trunk/src/chrome/third_party/mozilla_security_manager/nsNSSCertificate.h

Linux: Add decoding for a bunch of certificate extensions.

BUG=18119
TEST=open https site in firefox and chrome, compare certificate extension details

Review URL: http://codereview.chromium.org/557046
------------------------------------------------------------------------
r40170 | thestig@chromium.org | 2010-02-26 23:25:38 +0100 (Fri, 26 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc

gtk: Add the experimental purge memory button. Also add a GRD entry for the button.

BUG=none
TEST=The --purge-memory-button switch adds a purge memory button to the task manager.
Review URL: http://codereview.chromium.org/661200
------------------------------------------------------------------------
r40164 | skrul@chromium.org | 2010-02-26 23:02:38 +0100 (Fri, 26 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   A /trunk/src/chrome/browser/sync/glue/data_type_manager.h
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Un-reverting 33964 - turns out the problem here was that I used DCHECKs with mocked methods in it, and in release mode my expectations no longer matched.  See added #ifdef in data_type_manager_impl_unittest.cc.

Review URL: http://codereview.chromium.org/661111
------------------------------------------------------------------------
r40161 | estade@chromium.org | 2010-02-26 22:34:11 +0100 (Fri, 26 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

GTK: remove extra padding for extension popups.

Users of InfoBubbleGtk are now responsible for controlling the padding around the content.

BUG=32549
TEST=looking at the various info bubbles

Review URL: http://codereview.chromium.org/660151
------------------------------------------------------------------------
r40157 | cbentzel@chromium.org | 2010-02-26 22:07:45 +0100 (Fri, 26 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/net/http/http_auth_filter.cc
   A /trunk/src/net/http/http_auth_filter.h
   A /trunk/src/net/http/http_auth_filter_unittest.cc
   M /trunk/src/net/http/http_auth_handler_factory.cc
   M /trunk/src/net/http/http_auth_handler_factory.h
   M /trunk/src/net/http/http_auth_handler_factory_unittest.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_win.cc
   M /trunk/src/net/http/http_auth_handler_ntlm_portable.cc
   M /trunk/src/net/http/http_auth_handler_ntlm_win.cc
   M /trunk/src/net/http/http_auth_unittest.cc
   M /trunk/src/net/net.gyp

Added HttpAuthFilter.

Original patch by ahendrickson@chromium.org (http://codereview.chromium.org/646068)

BUG=29596
TEST=net_unittests.exe --gtest_filter="*HttpAuthFilterTest*"

Review URL: http://codereview.chromium.org/660193
------------------------------------------------------------------------
r40156 | thakis@chromium.org | 2010-02-26 21:43:14 +0100 (Fri, 26 Feb 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentBlockedImages.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedJavaScript.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPopups.xib
   A /trunk/src/chrome/app/nibs/ContentExceptionsWindow.xib
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   A /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.h
   A /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/content_exceptions_table_model.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Content Settings Exceptions dialog.

xib changes:

ContentSettings.xib: Connect the various "Exceptions" buttons to their handlers and enable them.
ContentBlocked*.xib: Now that exceptions can be edited, enable the radio buttons.
ContentExceptionsWindow.xib: Add a xib with an exceptions window.

Screenshot: http://imgur.com/fLwKA
Screenshot on windows: http://imgur.com/UltQp

Adding and editing exceptions doesn't work yet. I'll probably do this inline like in the bookmarks manager instead of with a sheet.

BUG=34894
TEST=prefs->content settings->exceptions. if you set e.g. the cookie setting to "ask" and then say "remember" in the cookie dialog, these exceptions should show up in the cookie exceptions list. Likewise, if you use the radio group in the popup blocker bubble to override the blocking setting, that should show up there too. Also test this:
1.) Set cookie settings for www.tagesschau.de to "ask", leave window open
2.) Go to tagesschau.de
3.) In dialog, say "remember" and "block"
4.) in exceptions window, the setting should now say "block".
Check that all buttons work as expected. Return should enter renaming mode for the current line, esc should stop editing, delete should delete the current line.

Review URL: http://codereview.chromium.org/660150
------------------------------------------------------------------------
r40152 | wtc@chromium.org | 2010-02-26 21:26:14 +0100 (Fri, 26 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc

Remove obsolete "using WebKit::WebConsoleMessage" statements.

R=jcampan
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/661192
------------------------------------------------------------------------
r40151 | joth@chromium.org | 2010-02-26 21:21:49 +0100 (Fri, 26 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h

Speculative fix for valgrind memory lead

BUG=http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20(valgrind)(2)/builds/1888/steps/valgrind%20test:%20ui/logs/stdio
TEST=none
TBR=bulach@chromium.org


------------------------------------------------------------------------
r40150 | cpu@chromium.org | 2010-02-26 21:21:40 +0100 (Fri, 26 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc

First part of the pre-set bookmarks feature

- master prefs format (just url)
- defer actual bookmark fu, because early on the bookmarkmodel and other services are not yet running.
- cleanup master prefs test, too much code duplication
- cleanup ProcessMasterPreferences it had too many params

BUG=32728
TEST=unit test included

Review URL: http://codereview.chromium.org/660116
------------------------------------------------------------------------
r40140 | oshima@chromium.org | 2010-02-26 20:08:54 +0100 (Fri, 26 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm

fix mac build breakage

TBR=johnnyg@chromium.org
BUG=none
TEST=mac debug build should cycle green

Review URL: http://codereview.chromium.org/660192
------------------------------------------------------------------------
r40139 | oshima@chromium.org | 2010-02-26 19:56:17 +0100 (Fri, 26 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/notification.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Adding sticky field to Notification

BUG=33306
TEST=modified and added new test (TestSticky) to DesktopNotificationsTest

Review URL: http://codereview.chromium.org/661155
------------------------------------------------------------------------
r40137 | scherkus@chromium.org | 2010-02-26 19:50:11 +0100 (Fri, 26 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   A /trunk/src/chrome/browser/renderer_host/video_layer.cc
   A /trunk/src/chrome/browser/renderer_host/video_layer.h
   A /trunk/src/chrome/browser/renderer_host/video_layer_x.cc
   A /trunk/src/chrome/browser/renderer_host/video_layer_x.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/media/ipc_video_renderer.cc
   A /trunk/src/chrome/renderer/media/ipc_video_renderer.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/glue/media/video_renderer_impl.cc
   M /trunk/src/webkit/glue/media/video_renderer_impl.h
   A /trunk/src/webkit/glue/media/web_video_renderer.h
   M /trunk/src/webkit/glue/webmediaplayer_impl.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/webkit.gyp

Initial work for cross-process video rendering using layers.

Introduces VideoLayer, which is similar to BackingStore except handles YUV surfaces and conversion to RGB.

BUG=33329
TEST=N/A

Review URL: http://codereview.chromium.org/597066
------------------------------------------------------------------------
r40136 | sky@chromium.org | 2010-02-26 19:47:56 +0100 (Fri, 26 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fixes bug in extensions where we wouldn't allow an extension to select
a pinned tab.

BUG=33123
TEST=see bug

Review URL: http://codereview.chromium.org/661128
------------------------------------------------------------------------
r40135 | kuan@chromium.org | 2010-02-26 19:43:09 +0100 (Fri, 26 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

fix bug where translate infobar gets stuck at "Loading..." between switching tabs.

- problem happened because infobars are destructed when switching between tabs, only the delegates persist.  without the infobar to receive the PAGE_TRANSLATED notification to update the translate state, the infobar gets stuck at translating state when user switches back to the associated tab.
- fix was to update the state in the infobar delegate on receiving PAGE_TRANSLATE notification so that when a new translate infobar is created, its visual display will reflect the updated after-translate state.

BUG=36895
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/660187
------------------------------------------------------------------------
r40130 | rogerta@chromium.org | 2010-02-26 19:08:43 +0100 (Fri, 26 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_metrics_apitest.cc
   A /trunk/src/chrome/browser/extensions/extension_metrics_module.cc
   A /trunk/src/chrome/browser/extensions/extension_metrics_module.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/metrics
   A /trunk/src/chrome/test/data/extensions/api_test/metrics/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/metrics/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/metrics/test.js
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc

Add a metrics extensions API.

See http://docs.google.com/View?id=dd4ngnpz_0dpsb8n96 for API proposal.

BUG=0
TEST=See unit tests as part of this CL

Review URL: http://codereview.chromium.org/657037
------------------------------------------------------------------------
r40128 | jcampan@chromium.org | 2010-02-26 18:42:13 +0100 (Fri, 26 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adding a preference to turn off the translate feature.

BUG=None
TEST=Visit a page in a language other than the Chrome's language.
     A translate infobar should be shown.
     In the options/Under the Hood tab, unselect "Offer to translate
     pages that aren't in a language I read". Navigate again to a
     page in a non Chrome-UI language. No translate infobar should be
     shown.

Review URL: http://codereview.chromium.org/661095
------------------------------------------------------------------------
r40120 | evan@chromium.org | 2010-02-26 16:11:55 +0100 (Fri, 26 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_deprecated.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/printing/printed_document.cc

Deprecate file_util::AppendToPath() on non-Windows.

We still have ~150 callers to AppendToPath in our code, but most of
them are in the installer and I'm reluctant to fiddle with that code
without having an easy way to test it.

BUG=24672

Review URL: http://codereview.chromium.org/654013
------------------------------------------------------------------------
r40118 | joth@chromium.org | 2010-02-26 15:29:12 +0100 (Fri, 26 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/renderer/geolocation_dispatcher.cc

Bring Geolocation to life!
Bolt the geolocation dispatcher host up to the location arbitrator
Introduces a new method for fetching a singleton default location arbitrator with minimal fuss.
Fix bug in the geolocation dispatcher where bridge id & route id were swapped on send.

BUG=http://crbug.com/11246
TEST=run browser with --enable-geolocaiton & Open http://maps.google.co.uk/maps/m

Review URL: http://codereview.chromium.org/658005
------------------------------------------------------------------------
r40108 | avayvod@google.com | 2010-02-26 11:35:21 +0100 (Fri, 26 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Necessary modifications for rendering web page on login screen: getting the
default user profile and starting login wizard after necessary
initialization happens. Also renamed first-login-screen-name switch to
just login-screen.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/660080
------------------------------------------------------------------------
r40104 | joth@chromium.org | 2010-02-26 09:42:22 +0100 (Fri, 26 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h

Misc tidy up:
- rename NewPolicyPolicy to NewPollingPolicy
- log content of json request string, rather than its address

BUG=none
TEST=run browser, looked at logging output

Review URL: http://codereview.chromium.org/661091
------------------------------------------------------------------------
r40101 | jar@chromium.org | 2010-02-26 07:07:25 +0100 (Fri, 26 Feb 2010) | 29 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/net_util.cc

Revert 40099 - Revert 39998  Revert 39996  Refine IPv6 probe to require that the client has an IPv6 address on an interface

It is indeed causing a perf regression in startup on Linux...
I'll need to rearchitect to do the probes asynchronously, and get
off the startup-critical-path.

This currently only works on Posix, not windows.

Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).

The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection.  If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.

BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660073

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/661164

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660165
------------------------------------------------------------------------
r40099 | jar@chromium.org | 2010-02-26 06:33:45 +0100 (Fri, 26 Feb 2010) | 29 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/net_util.cc

Revert 39998 - Revert 39996  Refine IPv6 probe to require that the client has an IPv6 address on an interface

This is a second attempt to land a reviewed change. It was reverted because
the tree got very red (for other reasons), and it was plausible that this
change was causing startup latency in Mac and Linux (causing both perf bots
 to go red).  If this landing turns those perf-bots red (tonight) I'll need
to revert.  (... and I'll need to rearchitect to do the probes
 asynchronously, and get off the startup-critical-path.

This currently only works on Posix, not windows.

Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).

The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection.  If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.

BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660073

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/661164
------------------------------------------------------------------------
r40085 | suzhe@chromium.org | 2010-02-26 02:15:28 +0100 (Fri, 26 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Only send unprocessed key events upwards if the RenderWidgetHost is not hidden.

BUG=36661 Ctrl-1 gets queued while Ctrl-tab doesn't
TEST=See bug report.

Review URL: http://codereview.chromium.org/660069
------------------------------------------------------------------------
r40083 | pkasting@chromium.org | 2010-02-26 01:47:59 +0100 (Fri, 26 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/gfx/skia_utils_gtk.cc (from /trunk/src/skia/ext/skia_utils_gtk.cc:40057)
   A /trunk/src/app/gfx/skia_utils_gtk.h (from /trunk/src/skia/ext/skia_utils_gtk.h:40057)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/chromeos/options/settings_page_view.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   D /trunk/src/skia/ext/skia_utils_gtk.cc
   D /trunk/src/skia/ext/skia_utils_gtk.h
   M /trunk/src/skia/skia.gyp
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/window/dialog_client_view.cc

Move skia_utils_gtk.cc/.h to app/gfx/.  Original patch by Thiago Farina (see http://codereview.chromium.org/660063 ), r=me.

BUG=22853
TEST=none
------------------------------------------------------------------------
r40080 | thestig@chromium.org | 2010-02-26 01:31:08 +0100 (Fri, 26 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/leak_annotations.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/build/build_config.h
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chrome_exe_main_gtk.cc
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/extensions/v8/heap_profiler_extension.cc

Merge the LINUX_TC_MALLOC #define with the existing TC_MALLOC #define.

BUG=36687
TEST=about:tcmalloc, etc, works when tcmalloc is enabled on Linux.
Review URL: http://codereview.chromium.org/660118
------------------------------------------------------------------------
r40075 | dhollowa@chromium.org | 2010-02-26 01:07:04 +0100 (Fri, 26 Feb 2010) | 31 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

AutoFill dialog UI polish.  Based on feedback from thakis.

Change to AutoFillDialog.xib was window anchoring flags to better position dialog in different window sizes on first run.

> 1.) The initial position of the dialog is half off-screen on my 15'' MBP. It should probably be 
> more on the left.
> 

Done.  Auto centering now.

> 2.) Furthermore, the dialog should autosave its position. See e.g. 
> keyword_editor_cocoa_controller.mm on how to do this (the |if (g_browser_process...)| block in 
> |initWithProfile| – it takes only a couple lines).
> 

Done.

> 3.) When clicking "Add an address", I find it weird that the new address starts in the collapsed 
> state. That makes it hard to see how to delete it again, and chances are that when I'm adding a 
> new address I want to edit it immediately.
> 

Done.


BUG=36441
TEST=see manual repro steps above.



Review URL: http://codereview.chromium.org/660130
------------------------------------------------------------------------
r40072 | stoyan@chromium.org | 2010-02-26 00:59:57 +0100 (Fri, 26 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Give UITest ability to have MessageLoopforUI message loop instead of the default one. 
ExternalTabContainer tests create the host window and the automationproxy in the main thread, that will cause deadlock (especially when host window is visible).
Added test for openening popup windows.

TEST=ui_tests
Review URL: http://codereview.chromium.org/661028
------------------------------------------------------------------------
r40069 | chron@google.com | 2010-02-26 00:56:44 +0100 (Fri, 26 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer.h

Remove unused header declaration. Not defined in syncer.cc. Was moved into syncer util a while ago.

Review URL: http://codereview.chromium.org/661123
------------------------------------------------------------------------
r40068 | tim@chromium.org | 2010-02-26 00:54:41 +0100 (Fri, 26 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc

When applying updates, the UpdateApplicator should check ServerModelType and not
the local version, as it may not have been set yet.  I messed this up as part of my multi-pass syncer command change yesterday.

BUG=36822

Review URL: http://codereview.chromium.org/661133
------------------------------------------------------------------------
r40065 | chron@google.com | 2010-02-26 00:22:02 +0100 (Fri, 26 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc

Temporary fix for commit ID problem. Hex encode IDs so we use ASCII.

Review URL: http://codereview.chromium.org/660108
------------------------------------------------------------------------
r40057 | mpcomplete@chromium.org | 2010-02-25 23:10:50 +0100 (Thu, 25 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_processes_api.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   D /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/incognito
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/apis
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/apis/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/apis/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/apis_disabled
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/apis_disabled/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/apis_disabled/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/content_scripts
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/content_scripts/change_page_title.js (from /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script/change_page_title.js:40052)
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/content_scripts/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script/manifest.json:40052)
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/popup
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/popup/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/incognito/popup/popup.html
   D /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script/change_page_title.js
   D /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Allow users to enable extensions in incognito. Requires
--enable-experimental-extension-apis . The UI needs work. Tab and window
events are hooked up so that they work with incognito tabs/windows when
enabled.

BUG=32365
BUG=36292

Review URL: http://codereview.chromium.org/657041
------------------------------------------------------------------------
r40055 | kuan@chromium.org | 2010-02-25 23:06:47 +0100 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

fix crash when translate infobar is instantiated with Translating state

translate infobar was expected to always be instantiated with BeforeTranslate state, but if connection is slow and infobar remains at Translating state when user switches to another tab then switches back to the "Translating" tab, all controls need to be created.

BUG=36812
TEST=On a slow connection, open a page that shows translate infobar, click to translate; while it's still translating, switch to another tab then switch back to the translating tab, it shouldn't crash.

Review URL: http://codereview.chromium.org/661103
------------------------------------------------------------------------
r40054 | albertb@google.com | 2010-02-25 23:04:38 +0100 (Thu, 25 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc

When creating preference sync node, set the node title to the name of the
preference.

BUG=none
TEST=unit tests

Review URL: http://codereview.chromium.org/661113
------------------------------------------------------------------------
r40053 | thakis@chromium.org | 2010-02-25 23:04:21 +0100 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

Mac: Fix cert text y pos.

This regressed in http://codereview.chromium.org/427009/diff/4020/11020 , when the offset was applied relative to the icon instead of the view, but the number wasn't updated.

BUG=31956
TEST=Go to https://addons.mozilla.org/en-US/firefox/addon/5890 , look at omnibox. Nothing should look bad.

Review URL: http://codereview.chromium.org/661116
------------------------------------------------------------------------
r40051 | estade@chromium.org | 2010-02-25 22:52:52 +0100 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc

Don't make pause/resume item in download context menu a check item (the name already toggles between pause and resume)

also, share more code between windows and linux. DownloadShelfContextMenu{Win,Linux} don't need to both implement menus::SimpleMenuModel::Delegate.

BUG=24759
TEST=download item context menu still works.

Review URL: http://codereview.chromium.org/652200
------------------------------------------------------------------------
r40050 | avi@chromium.org | 2010-02-25 22:43:25 +0100 (Thu, 25 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.h
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.mm

Removal of GTMTheme gradient use. Unthemed incognito windows now are fully drawn as they should be.

BUG=http://crbug.com/35554 ; http://crbug.com/26983
TEST=no visible change in normal mode; themed incognito windows should look almost correct (missing theme header)

Review URL: http://codereview.chromium.org/661097
------------------------------------------------------------------------
r40045 | erg@chromium.org | 2010-02-25 22:12:46 +0100 (Thu, 25 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Theoretical crash fix: deleted |blocked_popups_| sticks around un-NULLed.

ContentBlockedBubbleGtk looks at tab_contents->blocked_popup_container(), and
all I can think of is that people are clicking on the icon after
DidNavigateMainFramePostCommit() occurred.

BUG=35909
TEST=none

Review URL: http://codereview.chromium.org/660098
------------------------------------------------------------------------
r40041 | estade@chromium.org | 2010-02-25 21:30:54 +0100 (Thu, 25 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h

GTK: add hover glow effect to toolbar buttons

- CustomDrawButton
- ToolbarStarToggle
- GoButton

BUG=36760
TEST=manual

Review URL: http://codereview.chromium.org/661063
------------------------------------------------------------------------
r40036 | skerner@chromium.org | 2010-02-25 20:28:10 +0100 (Thu, 25 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Disable scroll bars on resizing popups below a maximum size.

This CL requires a patch to webkit to compile.  That patch is tracked here:
   https://bugs.webkit.org/show_bug.cgi?id=35257

This CL makes a change on Mac and Linux.  Windows will follow in a sepperate change.

BUG=30247
TEST=Manual testing using the test case attached to the bug and the sample extensions.

Review URL: http://codereview.chromium.org/657012
------------------------------------------------------------------------
r40034 | jeremy@chromium.org | 2010-02-25 19:53:38 +0100 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   A /trunk/src/chrome/browser/cocoa/translate_infobar.h
   A /trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/chrome_browser.gypi

Translate Infobars for OS X.

Infobars.xib changes - Connect and fix class for close button since the translate infobar needs to know where it is to position the "Options" menu to it's left.

BUG=34466
TEST=Translate infobars should continue to workon Windows.

Review URL: http://codereview.chromium.org/594056
------------------------------------------------------------------------
r40032 | joth@chromium.org | 2010-02-25 19:21:56 +0100 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc

Fix an issue in the common wifi data provider to make esp. mac wifi work correctly:-
it was waiting for the initial polling policy interval before making the initial scan, on windows this means a 10s latency in getting first fix, but on mac this was creating a 2min latency.
Adds detailed logging for the mac wifi data provider as this is the easiest way to debug on Mac it seems.

BUG=none
TEST=run browser with --enable-geolocation. open maps.google.com & click my location dot.

Review URL: http://codereview.chromium.org/661084
------------------------------------------------------------------------
r40027 | joth@chromium.org | 2010-02-25 18:15:38 +0100 (Thu, 25 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Add iStumbler license to the about:credits page

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/660083
------------------------------------------------------------------------
r40026 | avi@chromium.org | 2010-02-25 18:15:14 +0100 (Thu, 25 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm

Base coordinate system != Window base coordinate system. Marking things to be fixed.

BUG=http://crbug.com/36485
TEST=none; marking things to be fixed

Review URL: http://codereview.chromium.org/661047
------------------------------------------------------------------------
r40014 | joi@chromium.org | 2010-02-25 14:56:39 +0100 (Thu, 25 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc

Make utility process succeed in unpacking .crx file with
'experimental' in the permissions section of its manifest file, if
--enable-experimental-extension-apis was provided to Chrome on the
command line.

BUG=36702
TEST=as per repro in bug 36702

Review URL: http://codereview.chromium.org/661013
------------------------------------------------------------------------
r40013 | evan@chromium.org | 2010-02-25 13:41:34 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller.h
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.mm
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.h
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.mm
   M /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

[Mac] fix license nits found by the presubmit scripts in mac-specific code

Patch from Daniel Clifford <danno@google.com>.

Review URL: http://codereview.chromium.org/661077
------------------------------------------------------------------------
r40004 | joth@chromium.org | 2010-02-25 11:15:23 +0100 (Thu, 25 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   A /trunk/src/chrome/browser/geolocation/osx_wifi.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.h
   M /trunk/src/chrome/chrome_browser.gypi

Port the gears OSX wifi data provider into chrome
Pulls in the custom header file uesd to access these functions in gears

BUG=11246
TEST=unit_tests.exe --gtest_filer=Geoloc* 

Review URL: http://codereview.chromium.org/600146
------------------------------------------------------------------------
r40001 | evan@chromium.org | 2010-02-25 11:04:16 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h

linux: pretty up cookie exceptions window

Move the buttons to the right to improve the balance of the window.

Review URL: http://codereview.chromium.org/652230
------------------------------------------------------------------------
r40000 | jrg@chromium.org | 2010-02-25 09:18:52 +0100 (Thu, 25 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm

BUG=none

When merging in GTMTheme/ThemeProvider changes I missed one.  Adding
in a patch to make correct since the "half converted" state makes the
code unhappy.

Error was seen as bookmark bar folder windows with themed text but NOT
with a themed background.

Review URL: http://codereview.chromium.org/660071
------------------------------------------------------------------------
r39998 | jar@chromium.org | 2010-02-25 08:40:28 +0100 (Thu, 25 Feb 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/net_util.cc

Revert 39996 - Refine IPv6 probe to require that the client has an IPv6 address on an interface

This currently only works on Posix, not windows.

Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).

The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection.  If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.

BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660073
------------------------------------------------------------------------
r39996 | jar@chromium.org | 2010-02-25 07:42:19 +0100 (Thu, 25 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/net_util.cc

Refine IPv6 probe to require that the client has an IPv6 address on an interface

This currently only works on Posix, not windows.

Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).

The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection.  If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.

BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072
------------------------------------------------------------------------
r39992 | jrg@chromium.org | 2010-02-25 07:39:39 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

BUG=http://crbug.com/36763
Fix valgrind by changing destructor order.
2nd item, parentBarController, references objects in 1st item, helper_.

Review URL: http://codereview.chromium.org/660070
------------------------------------------------------------------------
r39990 | rsesek@chromium.org | 2010-02-25 07:16:15 +0100 (Thu, 25 Feb 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/cookie_storage.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/cookies_tree_model.cc

Add an icon for local storage and web databses in the cookie manager.

BUG=33196
TEST=Go to http://webkit.org/misc/DatabaseExample.html. Open cookie manager and find entry for webkit.org. See database icon.
TEST=Go to http://demos.hacks.mozilla.org/openweb/todo/ and repeat above steps. Same icon.

Review URL: http://codereview.chromium.org/661064
------------------------------------------------------------------------
r39989 | suzhe@chromium.org | 2010-02-25 07:13:43 +0100 (Thu, 25 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_host_mac.h
   M /trunk/src/chrome/browser/extensions/extension_host_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Handle keyboard events correctly in extension popups.

BUG=33221 Keyboard shortcuts doesn't work on extension bubble popups
TEST=Open an extension popup with a text box in it, then try to copy/paste text in the text box with cmd-c/v.

Review URL: http://codereview.chromium.org/654005
------------------------------------------------------------------------
r39987 | estade@chromium.org | 2010-02-25 06:19:55 +0100 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Windows: deemphasize render view when tab contents is blocked due to constrained window.

Since this pushes the SetVisuallyDeemphasized call into TabContents, it should also cover linux/views.

BUG=32399
TEST=see bug (http auth)

Review URL: http://codereview.chromium.org/650184
------------------------------------------------------------------------
r39985 | jhawkins@chromium.org | 2010-02-25 04:29:15 +0100 (Thu, 25 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   A /trunk/src/chrome/browser/autofill/form_structure_unittest.cc

Only load text fields in the form structure.  This prevents us from trying to autofill username/password forms.

BUG=none
TEST=FormStructureTest
TEST=log in to gmail.  AutoFill infobar should not show up.
Review URL: http://codereview.chromium.org/661026
------------------------------------------------------------------------
r39983 | willchan@chromium.org | 2010-02-25 04:09:41 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/base/observer_list.h
   M /trunk/src/base/observer_list_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   D /trunk/src/net/base/network_change_notifier_helper.cc
   D /trunk/src/net/base/network_change_notifier_helper.h
   M /trunk/src/net/base/network_change_notifier_linux.cc
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/base/network_change_notifier_win.h
   M /trunk/src/net/net.gyp
   M /trunk/src/webkit/appcache/appcache_group.cc
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Reland 39942 - Switch NetworkChangeNotifier implementations to use ObserverList.
Fixed build problem with database_tracker.(cc|h).
BUG=36590

Review URL: http://codereview.chromium.org/660039
------------------------------------------------------------------------
r39982 | rafaelw@chromium.org | 2010-02-25 03:38:44 +0100 (Thu, 25 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc

Flakify ExtensionApiTest.WebSocket

Has been flaky on windows

TBR=markus

Review URL: http://codereview.chromium.org/660064
------------------------------------------------------------------------
r39977 | chron@chromium.org | 2010-02-25 02:47:54 +0100 (Thu, 25 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   D /trunk/src/chrome/browser/sync/glue/data_type_manager.h
   D /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   D /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   D /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   D /trunk/src/chrome/browser/sync/glue/data_type_manager_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Revert 39964 - Move data type start/stop management into DataTypeManager
This change introduces a new interface/class called DataTypeManager whose job is to choreograph the start up and shut down of all registered data types.  It starts each data type serially, waiting for each data type to finish starting before starting the next one.  If anything goes wrong on startup, all data types are stopped.

Note that this change also simplifies the ProfileSyncServiceStartupTest as many of the cases it tested for are now the responsibility of the DataTypeManagerImpl (and these are thoroughly tested in its unit test).

I also killed off the TestProfileSyncFactory in the ProfileSyncServiceTest since it was lame and could be done with the mock.

BUG=36506

Review URL: http://codereview.chromium.org/650175

TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/661053
------------------------------------------------------------------------
r39976 | chron@chromium.org | 2010-02-25 02:44:38 +0100 (Thu, 25 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc

Revert 39966 - Fix mac build bustage

Review URL: http://codereview.chromium.org/660049

TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/661052
------------------------------------------------------------------------
r39966 | skrul@chromium.org | 2010-02-25 02:07:00 +0100 (Thu, 25 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc

Fix mac build bustage

Review URL: http://codereview.chromium.org/660049
------------------------------------------------------------------------
r39965 | snej@chromium.org | 2010-02-25 01:43:19 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Mac bookmark mgr: Fix an intermittent exception after right-clicking.
BUG=36334
TEST=none

Review URL: http://codereview.chromium.org/661030
------------------------------------------------------------------------
r39964 | skrul@chromium.org | 2010-02-25 01:42:55 +0100 (Thu, 25 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   A /trunk/src/chrome/browser/sync/glue/data_type_manager.h
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_impl.h
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_impl_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/data_type_manager_mock.h
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Move data type start/stop management into DataTypeManager
This change introduces a new interface/class called DataTypeManager whose job is to choreograph the start up and shut down of all registered data types.  It starts each data type serially, waiting for each data type to finish starting before starting the next one.  If anything goes wrong on startup, all data types are stopped.

Note that this change also simplifies the ProfileSyncServiceStartupTest as many of the cases it tested for are now the responsibility of the DataTypeManagerImpl (and these are thoroughly tested in its unit test).

I also killed off the TestProfileSyncFactory in the ProfileSyncServiceTest since it was lame and could be done with the mock.

BUG=36506

Review URL: http://codereview.chromium.org/650175
------------------------------------------------------------------------
r39963 | xiyuan@chromium.org | 2010-02-25 01:37:02 +0100 (Thu, 25 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/app/win_util.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc

Fix issue 32106

Issue 32106 happens when user creates a browser window without creating
desktop shortcut. In this case, Windows does not have sufficient
relaunching info to support pinning the browser window. The fix is to
create a shortcut in "User Pinned" folder which Win7 watches and would
get relaunch info from it.

Also fix a minor bug in win_util::SetAppIdForWindow that would make the
function only work for Win7 but not above.

BUG=32106
TEST=Verify fix for 32106. See comemnts #1 and #5 for repro steps.

Review URL: http://codereview.chromium.org/660038
------------------------------------------------------------------------
r39961 | rafaelw@chromium.org | 2010-02-25 01:33:11 +0100 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_websocket_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/websocket
   A /trunk/src/chrome/test/data/extensions/api_test/websocket/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/websocket/test.html
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/worker/worker_uitest.cc

Add an WebSocket extension browsertest.

This adds a simple browsertest that sanity checks that WebSockets can be opened and used from extension processes.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/660011
------------------------------------------------------------------------
r39959 | skrul@chromium.org | 2010-02-25 01:31:47 +0100 (Thu, 25 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/autofill_entry.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Implement WebDatabase::UpdateAutofillEntries()
This new method will replace existing autofill entries with the list provided as the argument.  Provided entries that don't exist are added.

BUG=36713

Review URL: http://codereview.chromium.org/660023
------------------------------------------------------------------------
r39958 | rohitrao@chromium.org | 2010-02-25 01:28:27 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Disable two tests that fail on the Mac tsan bots.

BUG=36736
TEST=None
Review URL: http://codereview.chromium.org/660045
------------------------------------------------------------------------
r39957 | tim@chromium.org | 2010-02-25 01:26:41 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.cc
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/sessions/session_state.cc
   M /trunk/src/chrome/browser/sync/sessions/session_state.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller.cc
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc

Multi-pass ModelChangingSyncerCommands.

BUG=31911

Review URL: http://codereview.chromium.org/638001
------------------------------------------------------------------------
r39955 | snej@chromium.org | 2010-02-25 01:17:18 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm

Fix broken cert-info sheets on Mac.
BUG=34811
TEST=none

Review URL: http://codereview.chromium.org/661034
------------------------------------------------------------------------
r39953 | thestig@chromium.org | 2010-02-25 00:55:55 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc

Posix: Set download file's permissions correctly.

BUG=36107
TEST=see bug.
Review URL: http://codereview.chromium.org/661025
------------------------------------------------------------------------
r39949 | pvalchev@google.com | 2010-02-25 00:40:30 +0100 (Thu, 25 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.h
   D /trunk/src/chrome/browser/importer/nss_decryptor_linux.cc
   D /trunk/src/chrome/browser/importer/nss_decryptor_linux.h
   A /trunk/src/chrome/browser/importer/nss_decryptor_system_nss.cc (from /trunk/src/chrome/browser/importer/nss_decryptor_linux.cc:39744)
   A /trunk/src/chrome/browser/importer/nss_decryptor_system_nss.h (from /trunk/src/chrome/browser/importer/nss_decryptor_linux.h:39744)
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/chrome_browser.gypi

- USE_NSS instead of LINUX where applicable
- Rename nss_decryptor_linux to nss_decryptor_posix as it's more appropriate
Review URL: http://codereview.chromium.org/656012
------------------------------------------------------------------------
r39948 | pkasting@chromium.org | 2010-02-25 00:31:18 +0100 (Thu, 25 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Mirror sysmenu target rect on RTL UIs.

BUG=36091
TEST=Start Chrome in Hebrew, click upper left corner, no sysmenu should appear.
Review URL: http://codereview.chromium.org/661033
------------------------------------------------------------------------
r39947 | jrg@chromium.org | 2010-02-25 00:26:27 +0100 (Thu, 25 Feb 2010) | 42 lines
Changed paths:
   M /trunk/src/base/chrome_application_mac.h
   M /trunk/src/base/chrome_application_mac.mm
   A /trunk/src/chrome/app/nibs/BookmarkBarFolderWindow.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_folder_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/test_event_utils.h
   M /trunk/src/chrome/browser/cocoa/test_event_utils.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Custom "menus" for the bookmark bar folders.  

Full behavior: http://JRG_WRITE_FULL_DOC_AND_TEST_PLAN_TOMORROW

BUG=17608 (and a slew of others)

Brief details on how to test:
- add some bookmarks and bookmark folders.
- at a basic level, make sure bookmark folders feel like menus e.g. 
  -- click to open
  -- can open "submenus" and sub-sub-menus
  -- can open (click on) bookmarks in any of these submenus
- click-drag does NOT open a menu (different than Mac menus); it initiates a Drag
- click on folder in bookmark bar initiates "hover open"; moving mouse
  over other folders will pop them open immediately (much like Mac menus)
- Bookmark bar non-drag hover-open is immediate, but bookmark folder
  hover-open has a brief delay so quick "move down" a folder does not
  trigger them all to open while you travel (much like Mac menus).
- DnD of bookmarks and folders on bookmark bar.
- While doing DnD of bookmark, "hover" over a folder and see it open.
- Bookmark folder menus have normal DnD "drop indicators" like the bookmark bar.
- Can "hover open" a nested subfolder.
- Can drag a bookmark from one deep sub-sub-folder to a different deep one.
- Confirm buttons and folders in submenus are themed, both with the
  theme set at launch time and the theme we change to after launch.
- Empty folders have an "(empty)" item which is not selectable.
- Intentional delay in closing a sub-sub-folder when hovering over
  another one.  E.g. When moving to a sub-sub-menu, 'brief' travel
  over a different submenu does not close the destination sub-menu.
- can use bookmark context menus in folder "menus".
- confirm DnD from "Other bookmarks" to any other random folder and
  vice versa.
- While non-drag hover open is active, clicking anywhere other than
  the bookmark bar or folder (e.g. the main web view) turns it off.

TODO:
- random bugs (e.g. "add folder" over a folder doesn't put it in there)
- (empty) needs to be revisited, both visually and for a drop indication
- core animations instead of drop indicators
- ...

Review URL: http://codereview.chromium.org/551226
------------------------------------------------------------------------
r39945 | willchan@chromium.org | 2010-02-24 23:53:51 +0100 (Wed, 24 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/base/observer_list.h
   M /trunk/src/base/observer_list_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   A /trunk/src/net/base/network_change_notifier_helper.cc (from /trunk/src/net/base/network_change_notifier_helper.cc:39941)
   A /trunk/src/net/base/network_change_notifier_helper.h (from /trunk/src/net/base/network_change_notifier_helper.h:39941)
   M /trunk/src/net/base/network_change_notifier_linux.cc
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/base/network_change_notifier_win.h
   M /trunk/src/net/net.gyp
   M /trunk/src/webkit/appcache/appcache_group.cc

Revert 39942 - Switch NetworkChangeNotifier implementations to use ObserverList.
Fix up observer list so we can use FOR_EACH_OBSERVER when check_empty is set.
Clean up the ObserverList API a bit, replacing GetElementAt() with HasObserver() and Clear().
BUG=36590

Review URL: http://codereview.chromium.org/652205

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/661029
------------------------------------------------------------------------
r39942 | willchan@chromium.org | 2010-02-24 23:41:47 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/base/observer_list.h
   M /trunk/src/base/observer_list_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   D /trunk/src/net/base/network_change_notifier_helper.cc
   D /trunk/src/net/base/network_change_notifier_helper.h
   M /trunk/src/net/base/network_change_notifier_linux.cc
   M /trunk/src/net/base/network_change_notifier_linux.h
   M /trunk/src/net/base/network_change_notifier_mac.h
   M /trunk/src/net/base/network_change_notifier_win.cc
   M /trunk/src/net/base/network_change_notifier_win.h
   M /trunk/src/net/net.gyp
   M /trunk/src/webkit/appcache/appcache_group.cc

Switch NetworkChangeNotifier implementations to use ObserverList.
Fix up observer list so we can use FOR_EACH_OBSERVER when check_empty is set.
Clean up the ObserverList API a bit, replacing GetElementAt() with HasObserver() and Clear().
BUG=36590

Review URL: http://codereview.chromium.org/652205
------------------------------------------------------------------------
r39939 | asargent@chromium.org | 2010-02-24 23:34:06 +0100 (Wed, 24 Feb 2010) | 17 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/fragment_navigation_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/user_script_idle_scheduler.cc
   M /trunk/src/chrome/renderer/user_script_idle_scheduler.h
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/fragment
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/fragment/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/fragment/content_script.js
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/fragment/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/fragment
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/fragment/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/fragment/content_script.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/fragment/execute_script.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/fragment/manifest.json

Don't re-run content scripts on fragment navigations.

This regression was inadvertently introduced by a fix to make executeScript 
run after a fragment navigation (bug 29541). That patch was:

http://codereview.chromium.org/566041

The problem is that on frame navigations (didChangeLocationWithinPage), we end
up creating a new UserScriptIdleScheduler, so this patch keeps track of the 
previous has_run state and propagates that to the new UserScriptIdleScheduler.


BUG=35924
TEST=Steps to verify are outlined in bug report


Review URL: http://codereview.chromium.org/646017
------------------------------------------------------------------------
r39938 | finnur@chromium.org | 2010-02-24 23:28:14 +0100 (Wed, 24 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/hash_change
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/hash_change/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/hash_change/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/hash_change/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/hash_change/script.js
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/hash_change/test_page_A.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/hash_change/test_page_B.html

Make sure in-page navigations don't make the page actions disappear.

Also added unit test to catch future regressions.

BUG=35935
TEST=ExtensionBrowserTest.PageActionInPageNavigation

Review URL: http://codereview.chromium.org/660012
------------------------------------------------------------------------
r39931 | pkasting@chromium.org | 2010-02-24 23:00:50 +0100 (Wed, 24 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/browser/views/options/exception_editor_view.h

Add a host validity status icon to the content settings exception editor. Original patch by Thiago Farina (see http://codereview.chromium.org/650011 ), r=me.

BUG=34181
TEST=Open the content settings exception editor, hit add, type a hostname, observe how status icon changes.
------------------------------------------------------------------------
r39925 | jhawkins@chromium.org | 2010-02-24 22:27:02 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations.h

Remove ViewMsg_FormFill and the underlying implementation FillForm which are not used anymore.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/657059
------------------------------------------------------------------------
r39914 | erg@chromium.org | 2010-02-24 21:05:13 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   A /trunk/src/chrome/browser/cookie_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/js_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Add modal cookies confirmation prompt.

BUG=35178,36183
TEST=none

Review URL: http://codereview.chromium.org/652172
------------------------------------------------------------------------
r39913 | mattm@chromium.org | 2010-02-24 21:02:29 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Linux: Move some duplicated code to gtk_util::CreateBoldLabel and LeftAlignMisc.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/657065
------------------------------------------------------------------------
r39912 | pinkerton@chromium.org | 2010-02-24 20:59:32 +0100 (Wed, 24 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker_platform_engine_unittest.cc

Remove words that are valid in other languages as 10.6 enables non-English dictionaries by default.
BUG=34785
TEST=unit tests pass on 10.6
Review URL: http://codereview.chromium.org/652204
------------------------------------------------------------------------
r39911 | skerner@chromium.org | 2010-02-24 20:47:31 +0100 (Wed, 24 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Update some windows-only browser tests to run on all platforms.

TEST=Ran affected browser tests.
BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39642

Review URL: http://codereview.chromium.org/618010
------------------------------------------------------------------------
r39910 | estade@chromium.org | 2010-02-24 20:29:28 +0100 (Wed, 24 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/resources/downloads.html

This change makes incognito downloads show up in the downloads page of an incognito window. These downloads are not persisted to history; hence they do not persist between incognito sessions.

There is no special UI for the incognito downloads. That can be added later.

BUG=28702

Review URL: http://codereview.chromium.org/650065
------------------------------------------------------------------------
r39908 | darin@chromium.org | 2010-02-24 20:23:13 +0100 (Wed, 24 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/cookie_message_filter.cc
   A /trunk/src/chrome/renderer/cookie_message_filter.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc

Only pump messages during a cookie query if it results in a user prompt.

Note: I left LocalStorage intact.  I want to first confirm that this CL
resolves the Intl2 performance regression.  If so, then I'll follow-up
with a CL to add similar treatment for LocalStorage.

R=jam
BUG=36310
TEST=none

Review URL: http://codereview.chromium.org/657074
------------------------------------------------------------------------
r39904 | snej@chromium.org | 2010-02-24 20:01:54 +0100 (Wed, 24 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_mac.mm
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc

Mac client-side SSL cert improvements.
Allow Netscape-style client certs.
Remember which identity the user chooses for a domain, and put it at the top of the list next time.
BUG=36316,36446
TEST=none

Review URL: http://codereview.chromium.org/651090
------------------------------------------------------------------------
r39895 | kuan@chromium.org | 2010-02-24 16:50:04 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

fix bug to not trigger translation when source language is modified in before-translate infobar

BUG=36666
TEST=verify per bug report.
TBR=jeremy
Review URL: http://codereview.chromium.org/652229
------------------------------------------------------------------------
r39892 | evan@chromium.org | 2010-02-24 14:25:58 +0100 (Wed, 24 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc

gtk: improve look of content exceptions edit dialog

Adds some padding and improves resize behavior; same code as
other dialogs.

Just noticed this while clicking around.

Review URL: http://codereview.chromium.org/657079
------------------------------------------------------------------------
r39891 | evan@chromium.org | 2010-02-24 14:04:22 +0100 (Wed, 24 Feb 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Fix style issue mentioned in previous review that I overlooked.
------------------------------------------------------------------------
r39890 | evan@chromium.org | 2010-02-24 13:59:19 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Use FilePaths in the SafeBrowsing unit tests.

BUG=24672

Review URL: http://codereview.chromium.org/652225
------------------------------------------------------------------------
r39885 | bulach@chromium.org | 2010-02-24 13:35:32 +0100 (Wed, 24 Feb 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   M /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   M /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   M /trunk/src/chrome/chrome_tests.gypi

Adds Geolocation browser test.

Note: they're disabled on Mac pending my investigation (it seems to be a similar issue to http://code.google.com/p/chromium/issues/detail?id=29424).
This will at least get some coverage for geolocation on win and linux for the time being.

TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/650134
------------------------------------------------------------------------
r39884 | joth@chromium.org | 2010-02-24 13:07:34 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc

Fix bug found in the location arbitrator whilst doing trial integration: need to make callback when new observer registers. + add a test for it.

BUG=none
TEST=GeolocationLocationArbitratorTest.RegistrationAfterFixArrives

Review URL: http://codereview.chromium.org/652136
------------------------------------------------------------------------
r39883 | jorlow@chromium.org | 2010-02-24 12:48:53 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Turn on session storage by default.

TEST=none
BUG=4360

Review URL: http://codereview.chromium.org/551098
------------------------------------------------------------------------
r39882 | evan@chromium.org | 2010-02-24 12:45:17 +0100 (Wed, 24 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.h
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] Implement HTML5 database items in "Cookies and Other Data" dialog.

Code changes to support a new variant of CocoaCookieTreeNode that displays the information about web databases.

Changes to Cookies.xib: Added a new NSView "Database" in the existing information summary view for items selected in the cookie tree. This Database view provides the details for selected items that are web databases, and is in the same implement + layout style as the existing "Cookie" and "Local Storage" views. Added a key "databaseDescription" to the CocoaCookieTreeNode to support the display of the new node type.

TEST=manual testing in the "Cookies and Other Data" dialog
BUG=http://crbug.com/35191
Patch from Dan Clifford <danno@google.com>.

Review URL: http://codereview.chromium.org/596058
------------------------------------------------------------------------
r39877 | phajdan.jr@chromium.org | 2010-02-24 10:54:13 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/extension_file_util.cc
   D /trunk/src/chrome/browser/extensions/extension_file_util.h
   D /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   A /trunk/src/chrome/browser/metrics/histogram_synchronizer.cc (from /trunk/src/chrome/common/histogram_synchronizer.cc:39714)
   A /trunk/src/chrome/browser/metrics/histogram_synchronizer.h (from /trunk/src/chrome/common/histogram_synchronizer.h:39714)
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   A /trunk/src/chrome/common/extensions/extension_file_util.cc (from /trunk/src/chrome/browser/extensions/extension_file_util.cc:39714)
   A /trunk/src/chrome/common/extensions/extension_file_util.h (from /trunk/src/chrome/browser/extensions/extension_file_util.h:39714)
   A /trunk/src/chrome/common/extensions/extension_file_util_unittest.cc (from /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc:39714)
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   D /trunk/src/chrome/common/histogram_synchronizer.cc
   D /trunk/src/chrome/common/histogram_synchronizer.h
   M /trunk/src/chrome/common/render_messages.h
   A /trunk/src/chrome/common/resource_response.h
   M /trunk/src/chrome/renderer/render_view.cc

Further reduce the bad dependency of chrome/common on chrome/browser.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/656011
------------------------------------------------------------------------
r39876 | evan@chromium.org | 2010-02-24 10:20:02 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

linux: eliminate some now-redundant code

We removed the label, but not the stuff that was positioning the label.

Review URL: http://codereview.chromium.org/657076
------------------------------------------------------------------------
r39867 | thakis@chromium.org | 2010-02-24 06:10:34 +0100 (Wed, 24 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   A /trunk/src/chrome/browser/cookie_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi

Mac: Cookie confirmation dialog.

This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.

BUG=34894
TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39756

Review URL: http://codereview.chromium.org/650206
------------------------------------------------------------------------
r39863 | rohitrao@chromium.org | 2010-02-24 05:04:18 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

[Mac] Remove the 14px vertical offset for fullscreen windows that are not on the primary monitor.

BUG=36579
TEST=Fullscreen a window on a secondary monitor.  The tab strip should not be taller than normal.
Review URL: http://codereview.chromium.org/652203
------------------------------------------------------------------------
r39853 | dhollowa@chromium.org | 2010-02-24 04:21:58 +0100 (Wed, 24 Feb 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/disclosure_view_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/section_separator_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/vertical_layout_view_unittest.mm

Fix for tab key view loop issue with Autofill dialog.

As sub-views got added and removed from the Autofill dialog the window's key view loop was not getting updated correctly.  This manifested where tab cycling between text fields would not see the new address or credit card.  After adding or removing an item we now tell the dialog's window to recompute the key view loop.

Also including small cleanup to unit tests.  Using scoped_nsobject<> at John's request.  Also spotted that the dialog title was not internationalized properly.  That is the change to AutoFillDialog.xib.  Specifically, changed the dialog window title to be "^IDS_AUTOFILL_DIALOG_TITLE".

BUG=36567
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.*

TEST=1. Launch Chrome on Mac,
2. Open Preferences dialog,
3. Navigate to Personal Stuff panel,
4. Click on "Setup Autofill..." button,
5. Click in an address label text field,
6. Hit the tab key.
7. Create a new address with the "Add an Address" button,
8. Click in new address label text field,
9. Hit the tab key.
Expect: focus to change to the next text field.

Review URL: http://codereview.chromium.org/657036
------------------------------------------------------------------------
r39844 | jhawkins@chromium.org | 2010-02-24 03:13:03 +0100 (Wed, 24 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

windows: Theme the popup window with the incognito theme when we are in the incognito mode.

BUG=20373
TEST=see bug

Patch by Thiago Farina <thiago.farina@gmail.com>
Original review at http://codereview.chromium.org/606060

Review URL: http://codereview.chromium.org/657042
------------------------------------------------------------------------
r39842 | rohitrao@chromium.org | 2010-02-24 03:10:15 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm

[Mac] Fix themes for fullscreen windows.

BUG=None
TEST=Omnibox focus ring for fullscreen windows should not be black.
Review URL: http://codereview.chromium.org/657053
------------------------------------------------------------------------
r39840 | thakis@chromium.org | 2010-02-24 03:07:08 +0100 (Wed, 24 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h

Preparation for mac content confirmation dialog. More tidy in general as well.

Patch mostly by sky.

BUG=34894

Review URL: http://codereview.chromium.org/652178
------------------------------------------------------------------------
r39834 | avi@chromium.org | 2010-02-24 02:49:00 +0100 (Wed, 24 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm

Reverting the revert, reinstating 39825. FindBarTextFieldCellTest.FocusedDisplay is flaky.

------------------------------------------------------------------------
r39830 | avi@chromium.org | 2010-02-24 02:41:13 +0100 (Wed, 24 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm

Reverting r39825.

------------------------------------------------------------------------
r39828 | jcampan@chromium.org | 2010-02-24 02:39:35 +0100 (Wed, 24 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Landing Chris Guillory CL.
See original review at:
http://codereview.chromium.org/626014/show

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/657020
------------------------------------------------------------------------
r39825 | avi@chromium.org | 2010-02-24 02:22:15 +0100 (Wed, 24 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm

Next batch of changes to kill GTMTheme.

BUG=http://crbug.com/35554
TEST=no visible change in normal mode; incognito mode still being worked on


Review URL: http://codereview.chromium.org/652179
------------------------------------------------------------------------
r39820 | rohitrao@chromium.org | 2010-02-24 01:43:23 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

[Mac] Register for screen changed notifications and resize the fullscreen window appropriately.  Also register for main status notifications, allowing us to move some code out of BWC and into FSC.

BUG=None
TEST=Fullscreen a window on a 1024x768 monitor.  Go into display preferences and change the monitor resolution to something higher.  The fullscreen window should continue to fill the whole screen.
Review URL: http://codereview.chromium.org/656020
------------------------------------------------------------------------
r39818 | eroman@chromium.org | 2010-02-24 01:20:48 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/init_proxy_resolver.cc
   M /trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service_common_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_common_unittest.h
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_mac.cc
   M /trunk/src/net/proxy/proxy_config_service_win.cc
   M /trunk/src/net/proxy/proxy_config_service_win_unittest.cc
   M /trunk/src/net/proxy/proxy_config_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

ProxyConfig behaved like a struct, but was defined as a class.

Changed it to be a proper class with hidden implementation variables, setters etc.

Also seized this opportunity to move the bypass list from being a member of ProxyConfig, to being a member of ProxyRules. This is a more correct hiearchy, since the bypass rules only apply to the manual settings. Lastly, this makes it possible to have the manual rules evaluation be a method on ProxyRules, and shift some more code out of proxy_service.
Review URL: http://codereview.chromium.org/651070
------------------------------------------------------------------------
r39815 | estade@chromium.org | 2010-02-24 01:16:43 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/app/gtk_dnd_util.h
   M /trunk/src/chrome/browser/download/download_util.cc
   A /trunk/src/chrome/browser/gtk/download_item_drag.cc
   A /trunk/src/chrome/browser/gtk/download_item_drag.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: handle dom_ui-generated download drag events.

BUG=36512
TEST=drag a file out of the downloads page

Review URL: http://codereview.chromium.org/657026
------------------------------------------------------------------------
r39806 | finnur@chromium.org | 2010-02-24 00:59:53 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Fix wrapping on extensions page (for locale nl).

BUG=32402
TEST=See bug.

Review URL: http://codereview.chromium.org/657024
------------------------------------------------------------------------
r39804 | georgey@chromium.org | 2010-02-24 00:54:47 +0100 (Wed, 24 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc

Fixes Issue 34722: Meaningless value in 'Save as type' combobox of 'Save page as...' dialog
Adds extension base don MIME type of the page.
Adds capability of the complete save of the "application/xhtml+xml" pages
BUG=34722
TEST=In the bug + try pages with other MIME types, such as "text/xml", "text/plain" or "text/css"
Review URL: http://codereview.chromium.org/650176
------------------------------------------------------------------------
r39802 | erg@chromium.org | 2010-02-24 00:46:50 +0100 (Wed, 24 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   M /trunk/src/chrome/browser/gtk/options/content_exception_editor.h

linux: Show an icon to the right indicating if the host is valid or not.

BUG=34181
TEST=open the exceptions editor, type some text in the host textfield, see the indication.

Review URL: http://codereview.chromium.org/650122
Patch from thiago.farina@gmail.com.
------------------------------------------------------------------------
r39799 | jhawkins@chromium.org | 2010-02-24 00:34:38 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.h
   M /trunk/src/chrome/browser/autofill/credit_card_field.h
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/name_field.h
   M /trunk/src/chrome/browser/autofill/phone_field.h

Remove FormField::priority as it's not used by AutoFill++.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/657015
------------------------------------------------------------------------
r39798 | jhawkins@chromium.org | 2010-02-24 00:34:27 +0100 (Wed, 24 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc

Remove dead code from AutoFill++ that are vestiges of the toolbar autofill.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652165
------------------------------------------------------------------------
r39794 | jshin@chromium.org | 2010-02-23 23:58:23 +0100 (Tue, 23 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc

When building the accept-language list for translation, exclude English
unless the UI language is English. 
This is a temporary measure until we're sure that removing English from 
the default value of A-L for most non-English locale is safe in terms of
web compatibility.

BUG=36182
TEST=1. Run Chrome in English and go to any English page. Translation info-bar does not show up.
2. Run a non-English version of Chrome and go to any English page. Translation info-bar does show up. 


Review URL: http://codereview.chromium.org/652138
------------------------------------------------------------------------
r39793 | agl@chromium.org | 2010-02-23 23:58:18 +0100 (Tue, 23 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Rename constants to be consistent with the names used in
sandbox/linux/suid/sandbox.c, in order to make the source more
greppable.

With inconsistent constant names it was harder to find who sends the
message that sandbox.c receives.

http://codereview.chromium.org/652108

(Patch from mseaborn@chromium.org)
------------------------------------------------------------------------
r39790 | thakis@chromium.org | 2010-02-23 23:53:32 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc

Revert 39779 - Part of http://codereview.chromium.org/650206

Review URL: http://codereview.chromium.org/657004

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/657022
------------------------------------------------------------------------
r39787 | dhollowa@chromium.org | 2010-02-23 23:47:42 +0100 (Tue, 23 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/AutoFillAddressFormView.xib
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardFormView.xib
   M /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/browser/autofill/autofill_address_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/disclosure_view_controller.h
   M /trunk/src/chrome/browser/cocoa/disclosure_view_controller.mm
   A /trunk/src/chrome/browser/cocoa/disclosure_view_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/section_separator_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/vertical_layout_view_unittest.mm
   M /trunk/src/chrome/chrome_tests.gypi

These changes connect the AutoFill UI on the Mac with the back-end data store.  Changes to a user's address and credit card information are now persisted.  Other changes are:
 - Selectively disables the preferences "Setup autofill..." button when the PersonalDataManager is not available.
 - Allows the user to add or remove address or credit card entries in the AutoFill dialog.
 - The billing and shipping popup menus in the credit card entries now properly reflect the list of addresses.

Notes on nib changes:
 - AutoFillAddressFormView.xib : added Delete button, wired to trigger |deleteAddress:| action.
 - AutoFillDialog.xib changed window size to encompass new controls.  Added "Add Address" and "Add Credit Card" buttons.  Wired them up to |addNewAddress:| and |addNewCreditCard:| actions, respectively.
 - Preferences.xib : |autoFillSettingsButton_| outlet wired up to facilitate disabling when no |PersonalDataManager| is available.
 - AutoFillCreditCardFormView.xib : added "Delete" button and wired up to |deleteCreditCard:| action.  Removed outlets to menus that were only there for temporary disablement reasons.  Set up bindings for billing and shipping address menu items and for their selected item.

BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*

Note new: Google Test filter = AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.*


Review URL: http://codereview.chromium.org/650163
------------------------------------------------------------------------
r39784 | chocobo@chromium.org | 2010-02-23 23:25:05 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/theme/statusbar_battery10d.png
   M /trunk/src/chrome/app/theme/statusbar_battery12d.png
   M /trunk/src/chrome/app/theme/statusbar_battery1d.png
   M /trunk/src/chrome/app/theme/statusbar_battery3d.png
   M /trunk/src/chrome/app/theme/statusbar_battery5d.png
   M /trunk/src/chrome/app/theme/statusbar_battery_charged.png
   A /trunk/src/chrome/app/theme/statusbar_battery_pressed.png
   M /trunk/src/chrome/app/theme/statusbar_network_bars0.png
   M /trunk/src/chrome/app/theme/statusbar_network_bars0b.png
   M /trunk/src/chrome/app/theme/statusbar_network_bars5.png
   M /trunk/src/chrome/app/theme/statusbar_network_bars8b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars_pressed.png
   A /trunk/src/chrome/app/theme/statusbar_network_secure.png
   A /trunk/src/chrome/app/theme/statusbar_network_wired_pressed.png
   D /trunk/src/chrome/app/theme/statusbar_pressed.png
   M /trunk/src/chrome/app/theme/statusbar_wired.png
   M /trunk/src/chrome/app/theme/statusbar_wiredb.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.h

New status bar images for ChromeOS.
Added icons to network options page.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/657001
------------------------------------------------------------------------
r39780 | darin@chromium.org | 2010-02-23 23:14:16 +0100 (Tue, 23 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Revert 39732 due to reliability bot failures.

Sometimes there is not a current context.

TBR=jochen
BUG=36600
TEST=none

Review URL: http://codereview.chromium.org/652158
------------------------------------------------------------------------
r39779 | thakis@chromium.org | 2010-02-23 23:13:13 +0100 (Tue, 23 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc

Part of http://codereview.chromium.org/650206

Review URL: http://codereview.chromium.org/657004
------------------------------------------------------------------------
r39778 | jhawkins@chromium.org | 2010-02-23 23:11:54 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_structure.cc

Fix a crash in FormStructure when parsing a form with zero fields.  Use field_count() instead of directly accessing the size of |fields_| because we NULL-terminate the field vector.

BUG=none
TEST=fox.com/24 doesn't crash the browser.
Review URL: http://codereview.chromium.org/657010
------------------------------------------------------------------------
r39776 | mark@chromium.org | 2010-02-23 23:01:29 +0100 (Tue, 23 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/nsmenuitem_additions.h
   M /trunk/src/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm

Make unit_tests NSMenuItemAdditionsTest.TestMOnDifferentLayouts pass on Mac
OS X 10.6.  10.6 adds two new keyboard layouts where the "m" key has a
different key code than expected.  These layouts are "Dvorak - Left" and
"Dvorak - Right".

TEST=unit_tests '--gtest_filter=NSMenuItemAdditionsTest.*' on 10.6
BUG=34784
Review URL: http://codereview.chromium.org/652151
------------------------------------------------------------------------
r39771 | davemoore@chromium.org | 2010-02-23 22:43:43 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc

Move cookie handling to login success
BUG=chromium-os:1625
TEST=Login and go to gmail and confirm you don't need to login again.

Review URL: http://codereview.chromium.org/657005
------------------------------------------------------------------------
r39770 | jcampan@chromium.org | 2010-02-23 22:38:06 +0100 (Tue, 23 Feb 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h

Displaying a JavaScript message box (such as an alert) from
an extension popup was causing the popup to lose focus and
be dismissed, causing other problems.
This CL fixes it on Windows with the following:
- the message box is now parented to the popup, not the tab
- the popup is not disimissed when losing focus to a window for
  which it is the owner.

BUG=29147
TEST=Create an extension with a popup that contains a combo-box
     and a button to show an alert and confirm box. Click on the
     combobox and select an item. Click the button to show the
     alert and confirm message box. The popup should not be closed
     when you do that.


Review URL: http://codereview.chromium.org/650045
------------------------------------------------------------------------
r39766 | thakis@chromium.org | 2010-02-23 21:55:15 +0100 (Tue, 23 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   D /trunk/src/chrome/browser/cookie_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert 39756 - Mac: Cookie confirmation dialog.

This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.

BUG=34894
TEST=Go to Preferences>under the hood>content settings>cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.

Review URL: http://codereview.chromium.org/650206

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/652150
------------------------------------------------------------------------
r39761 | thomasvl@chromium.org | 2010-02-23 21:15:55 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm

[Mac] Skip the failing test on 10.6 so we can spin up bots as green while the code is fixed.

BUG=34784
TEST=test still runs on mac 10.5 bots
Review URL: http://codereview.chromium.org/652134
------------------------------------------------------------------------
r39760 | thomasvl@chromium.org | 2010-02-23 21:15:38 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker_platform_engine_unittest.cc

[Mac] skip a test that fails on 10.6 so we can spin up the 10.6 tester bots.

BUG=34785
TEST=tests still run on the 10.5 bots and passes.
Review URL: http://codereview.chromium.org/652131
------------------------------------------------------------------------
r39757 | ananta@chromium.org | 2010-02-23 20:36:10 +0100 (Tue, 23 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Speculatve fix for a chrome crash caused in a chrome frame instance while processing an automation message
to focus through an external tab. Based on the crash dump, it appears that the tab_contents_ member is destroyed
and set to NULL in the context of a call to TabContents::Focus which calls the Windows API SetFocus on the native
HWND, which could dispatch messages like WM_DESTROY for the external tab.

Fix is to add a second NULL check for tab_contents_ after the call to TabContents::Focus. Added a comment
describing this scenario in the code.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=29246

Bug=29246

Review URL: http://codereview.chromium.org/653005
------------------------------------------------------------------------
r39756 | thakis@chromium.org | 2010-02-23 20:35:09 +0100 (Tue, 23 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   A /trunk/src/chrome/browser/cookie_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/chrome_browser.gypi

Mac: Cookie confirmation dialog.

This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.

BUG=34894
TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.

Review URL: http://codereview.chromium.org/650206
------------------------------------------------------------------------
r39755 | jhawkins@chromium.org | 2010-02-23 20:25:20 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Remove the --enable-new-autofill switch.  This enables the AutoFillManager to show the infobar asking the user to enable/disable AutoFill++.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/650169
------------------------------------------------------------------------
r39753 | mpcomplete@chromium.org | 2010-02-23 20:20:57 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Fix a crash when 2 extension uninstall dialogs were open and then confirmed.

BUG=36456

Review URL: http://codereview.chromium.org/656010
------------------------------------------------------------------------
r39749 | avi@chromium.org | 2010-02-23 19:36:12 +0100 (Tue, 23 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/bubble_view.h
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   A /trunk/src/chrome/browser/cocoa/themed_window.h
   A /trunk/src/chrome/browser/cocoa/themed_window.mm
   M /trunk/src/chrome/chrome_browser.gypi

Another pass at removal of GTMTheme. Also fixes unreadability of bookmark bar/status bubble in unthemed incognito mode.

BUG=http://crbug.com/35554 ; http://crbug.com/29845
TEST=no visible change in normal mode; themed incognito windows should look ugly still but in a different way


Review URL: http://codereview.chromium.org/650092
------------------------------------------------------------------------
r39748 | arv@chromium.org | 2010-02-23 19:30:55 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark Manager: Set the direction and the font size based on the language.

BUG=36457
TEST=Change the language to Hebrew (for example) and notice the RTL UI.

Review URL: http://codereview.chromium.org/652079
------------------------------------------------------------------------
r39746 | kuan@chromium.org | 2010-02-23 19:25:17 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/resources/about_memory_linux.html

do not mention other browsers in about:memory for chromeos

BUG=34839
TEST=verify per bug report

Review URL: http://codereview.chromium.org/650161
------------------------------------------------------------------------
r39744 | dspringer@google.com | 2010-02-23 19:00:07 +0100 (Tue, 23 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/gpu/command_buffer/client/gles2_demo_cc.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.h
   M /trunk/src/gpu/command_buffer/service/gpu_processor.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor.h
   M /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.cc
   M /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.h
   M /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.cc
   M /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.h

Add 3D support for the Mac on Leopard (OS X 10.5) and earlier.  This CL uses
FBO rendering with glGetTexImage() into a TransportDIB that is then used as
a texture for rendering the final image in the render view in the browser.
While not optimal, it works and can be optimized later, after the new GPU
process work is completed.

This CL also enables stencil buffer support on the Mac.  All the Pepper3D
demos run on the Mac with these changes.

BUG=none
TEST=3D rendering unit tests.

Review URL: http://codereview.chromium.org/647043
------------------------------------------------------------------------
r39743 | skrul@chromium.org | 2010-02-23 18:51:52 +0100 (Tue, 23 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc

Fix mac builder bustage

Review URL: http://codereview.chromium.org/656003
------------------------------------------------------------------------
r39742 | skrul@chromium.org | 2010-02-23 18:36:34 +0100 (Tue, 23 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Landing this patch on behalf of Mark Hahnenberg <mhahnenb(at)gmail.com>

Added a vector of Time objects to the AutofillEntry object for storingthe results retrieved from the date_created field of the autofill_datestable corresponding to the AutofillKey retrieved from the autofill table.

Also modified the old GetAllAutofillEntries test to account for this newlystored data.

BUG=35230

TEST=WebDatabaseTest.GetAllAutofillEntries

Review URL: http://codereview.chromium.org/600070
------------------------------------------------------------------------
r39740 | mark@chromium.org | 2010-02-23 18:28:42 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/nsmenuitem_additions.mm

Whitespace!

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652127
------------------------------------------------------------------------
r39738 | dmazzoni@chromium.org | 2010-02-23 18:04:35 +0100 (Tue, 23 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/accessibility_events.cc
   M /trunk/src/chrome/browser/accessibility_events.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.h
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   M /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.cc
   M /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json

Add support for more types of controls and events to GTK implementation of
accessibility extension API.  Enable accessibility API for all subdialogs
of the main Options dialog.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/651037
------------------------------------------------------------------------
r39734 | joth@chromium.org | 2010-02-23 17:50:41 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h

Fix some bugs discovered whilst making trial integration of geolocaiton pieces (http://codereview.chromium.org/650060/) & add tests for these cases.

BUG=none
TEST=GeolocationNetworkProviderTest.{NoRequestOnStartupUntilWifiData|NewDataReplacesExistingNetworkRequest}

Review URL: http://codereview.chromium.org/652066
------------------------------------------------------------------------
r39732 | jochen@chromium.org | 2010-02-23 17:31:14 +0100 (Tue, 23 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Notify when database access is blocked due to content settings.

Note that this code relies on the fact that the render thread is blocked and
waits for the database thread to open the database in order to get the routing
id.

BUG=36435
TEST=block all cookies, go to html5 database demo, icon should appear.

Review URL: http://codereview.chromium.org/652113
------------------------------------------------------------------------
r39708 | joth@chromium.org | 2010-02-23 11:27:36 +0100 (Tue, 23 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cancelable_request.cc
   M /trunk/src/chrome/browser/cancelable_request.h

Improve example code for cancelable request -- pass consumer base class pointer in StartRequest as it is more general

Make a small optimization: passing an iterator in CancelRequestLocked rather than Handle can avoid a call to map::find()

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/650143
------------------------------------------------------------------------
r39707 | joth@chromium.org | 2010-02-23 11:26:27 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Remove usages of obsolete WebSettings::setGeolocation so it can be removed from webkit

BUG=https://bugs.webkit.org/show_bug.cgi?id=35242
TEST=none

Review URL: http://codereview.chromium.org/650148
------------------------------------------------------------------------
r39705 | chocobo@chromium.org | 2010-02-23 10:52:55 +0100 (Tue, 23 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h

Fix badge icon logic.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/652094
------------------------------------------------------------------------
r39703 | phajdan.jr@chromium.org | 2010-02-23 10:10:13 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/accessibility_events.cc (from /trunk/src/chrome/common/accessibility_events.cc:39428)
   A /trunk/src/chrome/browser/accessibility_events.h (from /trunk/src/chrome/common/accessibility_events.h:39428)
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   A /trunk/src/chrome/browser/child_process_host.cc (from /trunk/src/chrome/common/child_process_host.cc:39428)
   A /trunk/src/chrome/browser/child_process_host.h (from /trunk/src/chrome/common/child_process_host.h:39428)
   A /trunk/src/chrome/browser/chrome_plugin_unittest.cc (from /trunk/src/chrome/common/chrome_plugin_unittest.cc:39428)
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   M /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details_linux.cc
   M /trunk/src/chrome/browser/memory_details_mac.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   M /trunk/src/chrome/browser/nacl_host/nacl_process_host.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/common/accessibility_events.cc
   D /trunk/src/chrome/common/accessibility_events.h
   D /trunk/src/chrome/common/child_process_host.cc
   D /trunk/src/chrome/common/child_process_host.h
   D /trunk/src/chrome/common/chrome_plugin_unittest.cc

Move more files from chrome/common to chrome/browser
to further reduce bad dependencies on chrome/browser.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652051
------------------------------------------------------------------------
r39702 | suzhe@chromium.org | 2010-02-23 10:01:08 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

[Linux]Fix text justification of find bar.

BUG=34724 Text in omnibox and find bar is not right justified correct under RTL locale.
TEST=Run chrome with LTR locale, the text in find bar should always be left justified, regardless of the text's direction. With RTL locale, the text should always be right justified. It matches the behavior of windows version.

Review URL: http://codereview.chromium.org/652105
------------------------------------------------------------------------
r39700 | jcampan@chromium.org | 2010-02-23 08:26:32 +0100 (Tue, 23 Feb 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/language_state.cc
   M /trunk/src/chrome/browser/tab_contents/language_state.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Make the translation bar not show up again when you closed it in a page 
and navigate in page. This is the case with web apps like GMail where 
many actions result in an in-page navigation. It would originally bring 
back the translation infobar, which is very anoying. 

This CL fixes the is_in_page state of LoadCommittedDetails, it was always false. 
This triggered a bug in the SSLManager that was wrongly not setting the SSL states when an in-page navigation is performed. 
Since we create a new navigation entry for in-page navigations, not setting these states would make a bad page being reported as OK after an in-page navigation. 

See original review:
http://codereview.chromium.org/650146/show

BUG=36304
TEST=Login to gmail, change the GMail language to a language different than 
the Chrome language. When a translate infobar shows up, close it. 
Click on the different links in GMail (inbox, drafts, select email...) 
the translate infobar should not show again. 

Review URL: http://codereview.chromium.org/650207
------------------------------------------------------------------------
r39696 | thakis@chromium.org | 2010-02-23 06:02:06 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc

Small preparation for the cookie confirmation dialog on linux/osx.

BUG=34894,35178

Review URL: http://codereview.chromium.org/650204
------------------------------------------------------------------------
r39690 | cpu@chromium.org | 2010-02-23 02:43:04 +0100 (Tue, 23 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Fix for crash on early return from browser_main.cc

BrowserImpl dtor assumes full construction of all sub-objects, this is not true
at least in one case (the try chrome again toast). See bug for more details

- Added a UI test to detect these shenaningans in all platforms
- had to hack ui_tests a bit, I hope is palatable

BUG=34799
TEST= UI test included


Review URL: http://codereview.chromium.org/571017
------------------------------------------------------------------------
r39687 | estade@chromium.org | 2010-02-23 02:21:04 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

GTK: adjust OTR spy spacing in titlebar.

BUG=36474
TEST=visual comparison with windows

Review URL: http://codereview.chromium.org/650192
------------------------------------------------------------------------
r39686 | xiyuan@chromium.org | 2010-02-23 02:17:35 +0100 (Tue, 23 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc

Fix app shortcut mess up per issue 31789

Issue 31789 is caused by a longer than MAX_PATH chars web app
description. Fix it by limiting the description string size to MAX_PATH.

Note:
1. MSDN mentions that the size limitation for Win2000 or later is
INFOTIPSIZE but the limit on my vista dev machine is MAX_PATH.
<http://msdn.microsoft.com/en-us/library/bb774955(VS.85).aspx>
2. The size limit includes the terminating NULL.

BUG=31789
TEST=Verify fix for issue 31789. facebook.com has a 261-char description and chromium should be able to create a working shortcut for it.

Review URL: http://codereview.chromium.org/650186
------------------------------------------------------------------------
r39685 | rohitrao@chromium.org | 2010-02-23 02:11:23 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

[Mac] Only hide the menubar if the fullscreen window is on the main screen.

BUG=35973
TEST=Fullscreen a window on a non-main screen.  Menubar should still be visible on the main screen.
Review URL: http://codereview.chromium.org/650187
------------------------------------------------------------------------
r39684 | cevans@chromium.org | 2010-02-23 02:03:10 +0100 (Tue, 23 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/transport_security_persister.cc
   M /trunk/src/net/base/transport_security_state.cc
   M /trunk/src/net/base/transport_security_state.h
   M /trunk/src/net/base/transport_security_state_unittest.cc

Tie the lifetime of persisted transport-security metatdata to clearing cookies,
thus giving the user control over it.
This involved adding in a "creation" date to the metadata so we can respect the
user's choice of how far back to go when deleting browsing data. Care is taken
to handle older metadata without the creation date set.
Also fix a bug whereby we weren't making sure to persist the removed metadata
when it expires.

BUG=33445
TEST=TransportSecurityStateTest.DeleteSince, TransportSecurityStateTest.SerializeOld

Review URL: http://codereview.chromium.org/652035
------------------------------------------------------------------------
r39682 | arv@chromium.org | 2010-02-23 01:54:06 +0100 (Tue, 23 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Make sure bookmarks_drag_ is initialized to NULL to prevent crash.

BUG=36473
TEST=None


Review URL: http://codereview.chromium.org/652092
------------------------------------------------------------------------
r39681 | erg@chromium.org | 2010-02-23 01:37:27 +0100 (Tue, 23 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK: Change the vertical offsets in non-custom tab background images depending on how the window is configured.

This fixes the vertical positioning of transparent tabs when no tab background image was specified.

BUG=34815
TEST=none

Review URL: http://codereview.chromium.org/650076
------------------------------------------------------------------------
r39676 | ian@chromium.org | 2010-02-23 01:08:17 +0100 (Tue, 23 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Fixes a bug where the "remove" and "remove all" buttons are
enabled in the "Cookies" page even when there is nothing
selected in the tree view.

BUG=34886
TEST=open cookies view, see that remove and remove all are not enabled until you select something.
Review URL: http://codereview.chromium.org/650173
------------------------------------------------------------------------
r39669 | estade@chromium.org | 2010-02-23 00:47:46 +0100 (Tue, 23 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

Add "deb" and "rpm" to dangerous extension list on linux.

BUG=31144
TEST=download a .deb or .rpm file, download shelf should warn

Review URL: http://codereview.chromium.org/650165
------------------------------------------------------------------------
r39667 | estade@chromium.org | 2010-02-23 00:45:09 +0100 (Tue, 23 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/throb_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/throb_controller_gtk.h

GTK: only throb twice when a bookmark is added to a bookmark bar folder.

TODO=to match windows better, throb continuously when bookmark bubble is open

BUG=36450
TEST=see bug

Review URL: http://codereview.chromium.org/652065
------------------------------------------------------------------------
r39665 | viettrungluu@chromium.org | 2010-02-23 00:37:12 +0100 (Tue, 23 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/app_mode_constants_mac.h
   A /trunk/src/chrome/common/app_mode_constants_mac.mm

Mac: record location of Chromium.app (or Google Chrome.app) bundle.

This will be needed by the app mode loader.

BUG=13148
TEST=Run Chromium; do (from command line): "defaults read org.chromium.Chromium LastRunAppBundlePath" -- should get path to Chromium.app; move Chromium.app to another location and run it again; do "defaults ..." again -- should get path to Chromium.app at new location.

Review URL: http://codereview.chromium.org/651061
------------------------------------------------------------------------
r39660 | rohitrao@chromium.org | 2010-02-23 00:22:09 +0100 (Tue, 23 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm

[Mac] Fix a crash when switching to a fullscreen window after rearranging monitor positions.

BUG=36467
TEST=See test case in bug.  Should not crash.
Review URL: http://codereview.chromium.org/652061
------------------------------------------------------------------------
r39657 | skerner@chromium.org | 2010-02-23 00:16:30 +0100 (Tue, 23 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert 39642 - Update some windowsonly browser tests to run on all platforms.

TEST=Ran affected browser tests.
BUG=None

Review URL: http://codereview.chromium.org/618010

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/652084
------------------------------------------------------------------------
r39653 | sky@chromium.org | 2010-02-23 00:14:21 +0100 (Tue, 23 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Fixes bug where close other tabs would not show the correct enabled
state.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/650147
------------------------------------------------------------------------
r39650 | oshima@chromium.org | 2010-02-22 23:56:57 +0100 (Mon, 22 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Build breakage fix

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/650179
------------------------------------------------------------------------
r39649 | albertb@google.com | 2010-02-22 23:49:00 +0100 (Mon, 22 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_preference_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   A /trunk/src/chrome/browser/sync/profile_sync_test_util.h
   M /trunk/src/chrome/chrome_tests.gypi

Refactored parts of the PSS unit tests to allow for preference sync to be tested the same way bookmark sync is.

BUG=32409
TEST=Unit tests

Review URL: http://codereview.chromium.org/614009
------------------------------------------------------------------------
r39648 | oshima@chromium.org | 2010-02-22 23:35:03 +0100 (Mon, 22 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Build breakage fix

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/652078
------------------------------------------------------------------------
r39646 | jhawkins@chromium.org | 2010-02-22 23:22:01 +0100 (Mon, 22 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address.cc
   M /trunk/src/chrome/browser/autofill/address.h
   M /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc
   A /trunk/src/chrome/browser/autofill/billing_address_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add tests for BillingAddress::GetPossibleFieldTypes.  Fix a few issues that popped up as a result of writing the tests.  Remove an unnecessary test fixture from the AutoFillProfile unit test.

BUG=none
TEST=BillingAddress.GetPossibleFieldTypes
Review URL: http://codereview.chromium.org/652057
------------------------------------------------------------------------
r39645 | oshima@chromium.org | 2010-02-22 23:21:57 +0100 (Mon, 22 Feb 2010) | 11 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/frame/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.h
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.h
   A /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.cc
   A /trunk/src/chrome/browser/chromeos/frame/normal_browser_frame_view.h (from /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h:39642)
   D /trunk/src/chrome/browser/views/frame/browser_extender.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   D /trunk/src/chrome/browser/views/frame/standard_extender.cc
   M /trunk/src/chrome/chrome_browser.gypi

BrowserFrameView for ChromeOS.
 * Introduced NormalBrowserFrameView, which can place OTR avatar icon in the right place.
   - This is based on OpaqueBrowserFrameView, but a lot of stuff that are unnecessary in ChromeOS has been removed.
   - Moved OTR Avatar icon view to BrowserView for now as this is much simpler to implement the above change. I'll revisit the possibility to refactor layout code to GetBoundsForXXX later.
 * removed most of browser extender stuff.

BUG=chromium-os:1007
TEST=open incognito window and switch to compact navigation mode (ctrl-shift-c). incognito icon should be placed between
     tabstrip and status area.

Review URL: http://codereview.chromium.org/593098
------------------------------------------------------------------------
r39642 | skerner@chromium.org | 2010-02-22 23:16:00 +0100 (Mon, 22 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Update some windows-only browser tests to run on all platforms.

TEST=Ran affected browser tests.
BUG=None

Review URL: http://codereview.chromium.org/618010
------------------------------------------------------------------------
r39641 | cmasone@google.com | 2010-02-22 23:01:26 +0100 (Mon, 22 Feb 2010) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/login/authenticator.h
   A /trunk/src/chrome/browser/chromeos/login/google_authenticator.cc
   A /trunk/src/chrome/browser/chromeos/login/google_authenticator.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   A /trunk/src/chrome/browser/chromeos/login/login_status_consumer.h
   A /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.cc
   A /trunk/src/chrome/browser/chromeos/login/pam_google_authenticator.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Refactor the authenticate-with-google code to prep for doing it inside chrome
Review URL: http://codereview.chromium.org/650097
------------------------------------------------------------------------
r39640 | shess@chromium.org | 2010-02-22 22:56:23 +0100 (Mon, 22 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h

Revert: Convert SafeBrowsingStoreFile to do bulk reads and writes.

TBR=eroman@chromium.org

---------------

Read/write the data in the style of fread/fwrite, rather than doing
I/O element by element. This lays the groundwork for adding
checksumming.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39619

Review URL: http://codereview.chromium.org/652073
------------------------------------------------------------------------
r39639 | gregoryd@google.com | 2010-02-22 22:56:00 +0100 (Mon, 22 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   M /trunk/src/chrome/nacl/broker_thread.cc

Fix bugs in the broker that cause the browser to crash when trying to unload a NaCl module or to load another one.
Review URL: http://codereview.chromium.org/650088
------------------------------------------------------------------------
r39634 | chocobo@chromium.org | 2010-02-22 22:30:29 +0100 (Mon, 22 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_view.cc

Add "Network settings..." menu item to network menu button for ChromeOS.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/650151
------------------------------------------------------------------------
r39633 | pinkerton@chromium.org | 2010-02-22 22:23:37 +0100 (Mon, 22 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Remove more TODOs that are un-necessary
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652047
------------------------------------------------------------------------
r39632 | cmasone@google.com | 2010-02-22 22:19:54 +0100 (Mon, 22 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore.cc

Makes Synchronous session restore work with the login manager
Review URL: http://codereview.chromium.org/650160
------------------------------------------------------------------------
r39631 | arv@chromium.org | 2010-02-22 22:18:57 +0100 (Mon, 22 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html
   M /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json

Bookmark manager drag and drop.

This is the HTML part of http://codereview.chromium.org/596105

BUG=4890 
TEST=Try the following:
   Dragging and dropping within the bookmark manager
   Dragging and dropping from/to the bookmark bar
   Dragging and dropping from/to the old bookmark manager
   Dragging and dropping from/to the bookmark manager from another instance of Chrome. This should copy the items instead of moving them.

Review URL: http://codereview.chromium.org/646076
------------------------------------------------------------------------
r39629 | joth@chromium.org | 2010-02-22 21:58:12 +0100 (Mon, 22 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc

Fix geolocation network request to not send/save cookies or send authentication data when accessing the network location server. This is to conserve user privacy.
Remove obsolete todos whilst in there.

BUG=http://crbug.com/11246
TEST=use wireshark to inspect request headers sent.


Review URL: http://codereview.chromium.org/650144
------------------------------------------------------------------------
r39627 | twiz@chromium.org | 2010-02-22 21:51:27 +0100 (Mon, 22 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc

Temporary fix for issue 34061.

Change that signals that drag-drop operations are immediately terminated in ExtensionHost views.  Previously, the view would become unresponsive, because the RenderViewHost would remain 'stuck' in the dragging logic, and all input events would be disregarded.

This fixes the issue described in the bug, but the long-term solution is to properly implement drag-drop operations for extension-views.

BUG=34061.
TEST=None.

Review URL: http://codereview.chromium.org/650059
------------------------------------------------------------------------
r39620 | rohitrao@chromium.org | 2010-02-22 21:25:33 +0100 (Mon, 22 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm

[Mac] Request/Release the fullscreen lock whenever a window gains or loses main status.

BUG=35973
TEST=Fullscreen one window, then Cmd-N to open a new window.  Menubar should be visible.
Review URL: http://codereview.chromium.org/628006
------------------------------------------------------------------------
r39619 | shess@chromium.org | 2010-02-22 21:07:48 +0100 (Mon, 22 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h

Convert SafeBrowsingStoreFile to do bulk reads and writes.

Read/write the data in the style of fread/fwrite, rather than doing
I/O element by element.  This lays the groundwork for adding
checksumming.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/650113
------------------------------------------------------------------------
r39617 | erg@chromium.org | 2010-02-22 21:03:30 +0100 (Mon, 22 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h

gtk: fix a typo in content_exceptions_window_gtk.

BUG=None
TEST=compiles

Review URL: http://codereview.chromium.org/650125
Patch from thiago.farina@gmail.com.
------------------------------------------------------------------------
r39616 | agl@chromium.org | 2010-02-22 20:53:33 +0100 (Mon, 22 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/common/sandbox_methods_linux.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

WebKit roll 55080:55089

Also merging in this Chromium side patch to match:

Linux: add plumbing for fontconfig on per-strike basis

fontconfig on Linux can change the render preferences on a per strike
basis (a strike a combination of face and size). Because of this, we
need to query fontconfig each time a new FontPlatformData is created
for a new size.

This is the Chromium side of https://bugs.webkit.org/show_bug.cgi?id=33065

BUG=18159
TEST=A new renderer should respect settings in ~/.fonts.conf
------------------------------------------------------------------------
r39611 | ananta@chromium.org | 2010-02-22 19:15:34 +0100 (Mon, 22 Feb 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc

Initial HTTP requests issued by ChromeFrame popups could bypass the host network stack. The host network
stack in ChromeFrame intercepts HTTP requests based on registered render views. When a popup window is created
we register it in the AddNewContents notification on the TabContentsDelegate. This is a little late as network
requests could be issued before the view actually becomes visible.

To fix this we now have a new method in the TabContentsDelegate interface called TabContentsCreated which
notifies the delegate about the creation of a new TabContents. The ExternalTabContainer implements this
method and registers the render view as pending. I also changed the signature of the
RenderViewHostDelegateViewHelper::CreateNewWindow method to return the new TabContents.

As part of this fix we also unregister the render view when the ExternalTabContainer is deleted. The
container registers for the NotificationType::RENDER_VIEW_HOST_DELETED notification. However we end up
deleting the TabContents in WM_DESTROY, which results in the container never receiving this notification.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=36323

Bug=36323
Test=Will be covered by the automation proxy test which Stoyan is adding

Review URL: http://codereview.chromium.org/652009
------------------------------------------------------------------------
r39610 | evan@chromium.org | 2010-02-22 19:05:00 +0100 (Mon, 22 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/mork_reader.h

Convert a bunch more of importer into FilePath.

I thought this would be a small job but I pulled the thread
and it kept coming.  :(

BUG=24672

Review URL: http://codereview.chromium.org/650034
------------------------------------------------------------------------
r39604 | sky@chromium.org | 2010-02-22 17:59:24 +0100 (Mon, 22 Feb 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/app/theme/new_browser_window.png
   D /trunk/src/chrome/app/theme/tab_overview.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   A /trunk/src/chrome/browser/chromeos/wm_ipc.cc (from /trunk/src/chrome/browser/views/tabs/tab_overview_types.cc:39376)
   A /trunk/src/chrome/browser/chromeos/wm_ipc.h (from /trunk/src/chrome/browser/views/tabs/tab_overview_types.h:39376)
   A /trunk/src/chrome/browser/chromeos/wm_message_listener.cc (from /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc:39376)
   A /trunk/src/chrome/browser/chromeos/wm_message_listener.h (from /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.h:39376)
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   D /trunk/src/chrome/browser/views/new_browser_window_widget.cc
   D /trunk/src/chrome/browser/views/new_browser_window_widget.h
   D /trunk/src/chrome/browser/views/tabs/grid.cc
   D /trunk/src/chrome/browser/views/tabs/grid.h
   D /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   D /trunk/src/chrome/browser/views/tabs/tab_overview_cell.h
   D /trunk/src/chrome/browser/views/tabs/tab_overview_container.cc
   D /trunk/src/chrome/browser/views/tabs/tab_overview_container.h
   D /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   D /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   D /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   D /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.h
   D /trunk/src/chrome/browser/views/tabs/tab_overview_grid.cc
   D /trunk/src/chrome/browser/views/tabs/tab_overview_grid.h
   D /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   D /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.h
   D /trunk/src/chrome/browser/views/tabs/tab_overview_types.cc
   D /trunk/src/chrome/browser/views/tabs/tab_overview_types.h
   M /trunk/src/chrome/chrome_browser.gypi

Removes tab overview related classes and renames TabOverviewTypes to
WmIpc.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/646079
------------------------------------------------------------------------
r39601 | thakis@chromium.org | 2010-02-22 17:47:07 +0100 (Mon, 22 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   M /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   M /trunk/src/chrome/browser/cookie_modal_dialog_views.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc

Mac: Implement most of the content settings dialog.

xib changes: Added a tab view with all the UI, set up bindings for radio groups and checkboxes. Hooked up buttons.

Missing for now:
* "Exception" dialogs ("exception" buttons are disabled until then)
* Some polish
* The cookie "ask" dialog

BUG=34894
TEST=Open content settings dialog. Set different things, click various things, and make sure they all have the expected effect.

Review URL: http://codereview.chromium.org/652037
------------------------------------------------------------------------
r39597 | craig.schlenter@chromium.org | 2010-02-22 16:13:36 +0100 (Mon, 22 Feb 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/printing/printer_query_linux.cc
   M /trunk/src/chrome/chrome_browser.gypi

Compile more printing code on Linux and nuke some stubs.

BUG=none
TEST=compiles on bots

Review URL: http://codereview.chromium.org/619008
------------------------------------------------------------------------
r39595 | jochen@chromium.org | 2010-02-22 12:02:42 +0100 (Mon, 22 Feb 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc

Clobber bots. TBR:bauerb
------------------------------------------------------------------------
r39593 | satorux@chromium.org | 2010-02-22 09:49:34 +0100 (Mon, 22 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc

Use two columns for listing input languages to avoid an overflow.

This is a temporary workaround. We'll implement better options page
for input languages.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/652036
------------------------------------------------------------------------
r39588 | thakis@chromium.org | 2010-02-22 02:53:41 +0100 (Mon, 22 Feb 2010) | 31 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ClearBrowsingData.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedCookies.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedImages.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedJavaScript.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   M /trunk/src/chrome/app/nibs/ContentBlockedPopups.xib
   A /trunk/src/chrome/app/nibs/ContentSettings.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h
   A /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm
   A /trunk/src/chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Move prefs around in preparation for the content settings window.

Also introduce scaffolding for the actual content settings dialog.

xib changes:
+ Personal stuff
* Move "Clear browsing data" button to under the hood tab
* Move themes stuff up a bit to cover hole left by missing button

+ under the hood:
* Created "Content Settings..." button
* Got rid of cookie settings
* Moved stuff around

+ clear data:
* Added horizontal rule and flash player settings link, linked its action to
  new method.

+ content settings:
* Added mostly empty window that contains "This is not implemented yet" label and a button that shows cookies (since I removed that from the prefs, so that it's still available). This window will be fleshed out very soon (in my next CL).
* The window _is_ set up for l10n

+ bubble xibs:
* Enable "Manage" links now that they open a window

Four screenshots at http://imgur.com/axGiR&78O8g&wgk3p&6oOHj

BUG=34656,34894
TEST="Clear data" button has moved from "Personal Stuff" to "Under the hood" in prefs. There's a "Content Settings" button next to it that opens a mostly empty window. The "Clear data" dialog now has a link to flash's privacy settings (which hang if one has the AdThwart extension installed, heh).

Review URL: http://codereview.chromium.org/650124
------------------------------------------------------------------------
r39587 | tony@chromium.org | 2010-02-22 01:59:23 +0100 (Mon, 22 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

An attempt to fix windows going fullscreen on startup.  My
best guess is that the size we're trying to restore is bigger
than the current monitor causing the window to be sized to the
monitor, triggering the fullscreen behavior.

BUG=31199

Review URL: http://codereview.chromium.org/651018
------------------------------------------------------------------------
r39581 | thakis@chromium.org | 2010-02-21 17:59:19 +0100 (Sun, 21 Feb 2010) | 13 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/ContentBlockedCookies.xib
   A /trunk/src/chrome/app/nibs/ContentBlockedImages.xib
   A /trunk/src/chrome/app/nibs/ContentBlockedJavaScript.xib
   A /trunk/src/chrome/app/nibs/ContentBlockedPlugins.xib
   A /trunk/src/chrome/app/nibs/ContentBlockedPopups.xib
   A /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h
   A /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm
   A /trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Show content blocked bubbles.

Two screenshots at http://imgur.com/5NDoC&pJJwP .

xib changes: All 5 xibs contain a window of type InfoBubbleWindow with a custom InfoBubbleView. The view is connected to the controller's |bubble_| outlet. The controller is the window's |delegate|, and the window is the controller's |window|. The window is not visible at launch. It autorecalculates its key view loop. For the non-cookie xibs, the two buttons at the bottom are in GTMWidthBasedTweakers.

Issues:
* Clicking "blocked" icon with open bubble doesn't close the bubble

BUG=35594,34894
TEST=Go to popuptest.com, start test. Click "Popups blocked" icon in omnibox. Bubble should appear. It should look sane in multiple locales (I tried English and German). The left button and the radio buttons are disabled at the moment, but the close button and the popup links should be functional.

Review URL: http://codereview.chromium.org/650073
------------------------------------------------------------------------
r39566 | viettrungluu@chromium.org | 2010-02-21 01:55:11 +0100 (Sun, 21 Feb 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm

Mac: when only minimized windows present, various commands should unminimize ...

... and use an existing window rather than create a new one. Also, when a dialog
box (e.g., Preferences, Bookmark Manager, etc.) is active, those commands should
activate an existing window (if one exists) instead of always creating a new
window.

The complete list of commands which should activate a miniaturized window if
possible (otherwise create a new window):
- File->New Tab (Cmd-T)
- File->Open Location... (Cmd-L)
- Edit->Find->Search the Web... (Opt-Cmd-F)
- History->History (Cmd-Y)
- Window->Downloads (Shift-Cmd-J)
- Window->Extensions
- Help->Chromium/Google Chrome Help
For now, I'm letting File->Open File... (Cmd-O) always create a new window,
which is consistent with Safari.

BUG=21434
TEST=Close all windows; try one of the commands above (in commit message/CL description); a new window should be created and the command should work; this is all as before this CL. Create a window (if necessary) and minimize all browser windows; try one of the commands above; the last-active browser window should unminimize and the command should execute in that window.

Review URL: http://codereview.chromium.org/652018
------------------------------------------------------------------------
r39564 | ben@chromium.org | 2010-02-20 22:19:42 +0100 (Sat, 20 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc

Fix truncation issues for new Privacy UI. Also, make the checkbox for the "clear cookie on exit" item wrap.

http://crbug.com/35118
TEST=none

Review URL: http://codereview.chromium.org/646059
------------------------------------------------------------------------
r39561 | phajdan.jr@chromium.org | 2010-02-20 20:01:59 +0100 (Sat, 20 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc

Fix the memset call from my previous CL.

TBR=wtc
BUG=35670
TEST=none

Review URL: http://codereview.chromium.org/652020
------------------------------------------------------------------------
r39559 | phajdan.jr@chromium.org | 2010-02-20 19:50:38 +0100 (Sat, 20 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/nss_memio.c
   M /trunk/src/net/base/nss_memio.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks5_client_socket.cc
   M /trunk/src/net/socket/socks5_client_socket.h
   M /trunk/src/net/socket/socks_client_socket.cc
   M /trunk/src/net/socket/socks_client_socket.h
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_client_socket_win.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/socket/tcp_client_socket_win.h
   M /trunk/src/net/socket_stream/socket_stream.cc

Really connect to the same server in FTP network transaction.

Also create necessary infrastructure to know the address
a client socket is connected to.

TEST=Covered by net_unittests.
BUG=35670

Review URL: http://codereview.chromium.org/598071
------------------------------------------------------------------------
r39558 | jorlow@chromium.org | 2010-02-20 18:58:32 +0100 (Sat, 20 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_prompt_modal_dialog_delegate.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h

Pass in the HostContentSettingsMap to the CookieModalDialog so IsValid can make its decision.  Before, it used the TabContents to get the profile to get the map, but this was incorrect because the current tab isn't necessarily from the same profile as the original request.

As long as we have the HostContentSettingsMap, we might as well handle "remember" in CookieModalDialog.

This bug exists in 4.1.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/651023
------------------------------------------------------------------------
r39557 | viettrungluu@chromium.org | 2010-02-20 17:34:43 +0100 (Sat, 20 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm

Mac: make Esc close the Search Engines dialog.

BUG=24494
TEST=Open Preferences... -> Basics -> Manage; Search Engines dialog box pops up; press Esc; Search Engines dialog box should close.

Review URL: http://codereview.chromium.org/650114
------------------------------------------------------------------------
r39556 | finnur@chromium.org | 2010-02-20 17:14:29 +0100 (Sat, 20 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Show extension action context menus on mouse up
instead of mouse down.

BUG=33155
TEST=Make sure right-click menus for Page Actions
still work. Then right-click a Page Action and
while the context menu is up, right click a 
browser action/bookmark bar (the right menu should
show).

Review URL: http://codereview.chromium.org/650087
------------------------------------------------------------------------
r39550 | aa@chromium.org | 2010-02-20 09:21:19 +0100 (Sat, 20 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Pull gallery special case down into Extension::CanAccessHost() to avoid duplicating it in multiple places.

Also rename that method to better reflect what it is used for.

BUG=35382

Review URL: http://codereview.chromium.org/650086
------------------------------------------------------------------------
r39543 | avayvod@chromium.org | 2010-02-20 05:38:50 +0100 (Sat, 20 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Bound page reloading ignoring cache to the following user actions:
- pressing Ctrl+F5 or Shift+F5 or Ctrl+Shift+R
- Shift- or Ctrl-clicking the Reload button.
Should work on Windows and Chrome OS (including compact navigation mode).

BUG=36244
TEST=Verify that everything works as described above.

Review URL: http://codereview.chromium.org/650048
------------------------------------------------------------------------
r39540 | arv@chromium.org | 2010-02-20 03:06:16 +0100 (Sat, 20 Feb 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json

Bookmark Manager Drag and Drop backend.

This adds the following methods to chrome.experimental.bookmarkManager:

startDrag(idList)
drop(parentId, opt_index)

as well as the following events:

onDragEnter(function(BookmarkDragData))
onDragLeave(function(BookmarkDragData))
onDrop(function(BookmarkDragData))

BUG=32194
TEST=None

Review URL: http://codereview.chromium.org/596105
------------------------------------------------------------------------
r39533 | jhawkins@chromium.org | 2010-02-20 02:04:48 +0100 (Sat, 20 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/form_manager.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/form_field_values.cc

AutoFill forms.  We do this by responding to a message from WebKit which sends the (name, label) key requested to fill out a specific field.  The RenderView finds the form to AutoFill using the FormManager and requests the AutoFillManager to fill in the data for the form.  At the end, the FormManager uses this data to fill out the fields in the form on the web page.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/651002
------------------------------------------------------------------------
r39524 | pkasting@chromium.org | 2010-02-20 01:29:29 +0100 (Sat, 20 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/context_menu.h

Disable the "Copy Image" context menu option when the user right-clicks a blocked image.

BUG=36021
TEST=Right-click a blocked image, "copy image" should be greyed out
Review URL: http://codereview.chromium.org/651075
------------------------------------------------------------------------
r39519 | darin@chromium.org | 2010-02-20 01:11:38 +0100 (Sat, 20 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc

Speculative crash fix.

While investigating another bug, I tried changing the PostTask(CloseNow)
to a PostDelayedTask(CloseNow) in WidgetWin.  This exposed a crash in the
cookie prompt if I clicked the Allow or Block buttons more than once.

R=sky
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/650067
------------------------------------------------------------------------
r39516 | chocobo@chromium.org | 2010-02-20 00:48:12 +0100 (Sat, 20 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/app/menus/menu_model.h
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc

New network menu button UI for ChromeOS.
Added ability to change label font in gtk menu item.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/650074
------------------------------------------------------------------------
r39513 | sky@chromium.org | 2010-02-20 00:29:02 +0100 (Sat, 20 Feb 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/view.cc

Attempt 2 at landing this. The first attempt failed because
View::MirroredX is defined inline in the .cc, which apparently means
gcc won't export it for callers outside of view.cc.

Changes the rendering of mini-tabs slightly:

. the icons of mini-tabs scales up to 24x24 on mouse over.
. phantom tabs are rendered in their own layer behind other tabs at
  40% opacity. The icon for phantom tabs are rendered at 60% opactiy.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/650066
------------------------------------------------------------------------
r39512 | shess@chromium.org | 2010-02-20 00:28:08 +0100 (Sat, 20 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc

Drop duplicate SBPrefix from full-hash elements.

SafeBrowsingDatabaseBloom stores a integer prefix column and a blob
hash column, where the first four bytes of the hash are the prefix.
This isn't necessary, so getting rid of the duplication rather than
propagating it into the future.

[Previously this was left alone because it wasn't too harmful because
the code could always drop the duplication from the file format.  A
future change for SafeBrowsingStoreFile will write an array of hashes,
making the duplication unavoidable.]

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/651057
------------------------------------------------------------------------
r39501 | kuan@chromium.org | 2010-02-19 23:52:16 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/frame/browser_view.cc

fix bug to not show context menu when mouse is between tabstrip and toolbar.

BUG=33454
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/650071
------------------------------------------------------------------------
r39498 | ananta@chromium.org | 2010-02-19 22:49:04 +0100 (Fri, 19 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

The ExternalTabContainer should only invoke unload handlers on the page in its OnDestroy handler. Doing it
in the destructor as well causes DCHECKs to fire in the code path which checks if it is the innermost ExternalTab
for which we received a CloseContents notification and if not post the task back to be handled later. Posting 
a task from the destructor causes the DCHECK as it tries to grab a ref on the object.

Part of the fix for http://code.google.com/p/chromium/issues/detail?id=35729

Bug=35279

Review URL: http://codereview.chromium.org/651051
------------------------------------------------------------------------
r39496 | estade@chromium.org | 2010-02-19 22:47:34 +0100 (Fri, 19 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h

Make use of SimpleMenuModel in DownloadShelfContextMenuWin and DownloadShelfContextMenuGtk. 

BUG=31365
TEST=manually

patch by Thiago Farina
original review at http://codereview.chromium.org/552251/show

Review URL: http://codereview.chromium.org/647059
------------------------------------------------------------------------
r39493 | jar@chromium.org | 2010-02-19 22:31:57 +0100 (Fri, 19 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log_unittest.cc

Switch to putting appversion at top level of XML

This change puts appversion at the same level as buildtime, and
so it is avalable (now) for use in histogram versioning, as well
as stability versioning (or user metrics versioning).

r=huanr
Review URL: http://codereview.chromium.org/650017
------------------------------------------------------------------------
r39490 | sky@chromium.org | 2010-02-19 21:50:43 +0100 (Fri, 19 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Revert 39489 - Changes the rendering of minitabs slightly:

. the icons of minitabs scales up to 24x24 on mouse over.
. phantom tabs are rendered in their own layer behind other tabs at
  40% opacity. The icon for phantom tabs are rendered at 60% opactiy.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/646067

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/650062
------------------------------------------------------------------------
r39489 | sky@chromium.org | 2010-02-19 21:35:32 +0100 (Fri, 19 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Changes the rendering of mini-tabs slightly:

. the icons of mini-tabs scales up to 24x24 on mouse over.
. phantom tabs are rendered in their own layer behind other tabs at
  40% opacity. The icon for phantom tabs are rendered at 60% opactiy.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/646067
------------------------------------------------------------------------
r39488 | eroman@chromium.org | 2010-02-19 21:27:02 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/mapped_host_resolver.cc
   M /trunk/src/net/base/mapped_host_resolver.h
   M /trunk/src/net/url_request/url_request_view_net_internals_job.cc

Make MappedHostResolver display its internals on the about:net-internals page (so use of the --host-resolver-rules flag doesn't limit features), and run through the Shutdown() method on exit.

This reworks the "IsHostResolverImpl()" hack to be a bit more general.

BUG=36053
Review URL: http://codereview.chromium.org/646003
------------------------------------------------------------------------
r39486 | eroman@chromium.org | 2010-02-19 21:24:06 +0100 (Fri, 19 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/net/net.gyp
   A /trunk/src/net/proxy/proxy_bypass_rules.cc
   A /trunk/src/net/proxy/proxy_bypass_rules.h
   A /trunk/src/net/proxy/proxy_bypass_rules_unittest.cc
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service_common_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_common_unittest.h
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_mac.cc
   M /trunk/src/net/proxy/proxy_config_service_win.cc
   M /trunk/src/net/proxy/proxy_config_service_win_unittest.cc
   M /trunk/src/net/proxy/proxy_config_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Split out the handling of proxy bypass rules into ProxyBypassRules. There are some pretty complicated rules, and this helps isolate that code and better test it.

This also lays a framework for addressing bug 9835 (IP/CIDR matching)

Lastly, adds support for the exclusion format ".domain" on all platforms, which is interpreted as "*.domain".

BUG=28112
TEST=ProxyBypassRulesTest.*
Review URL: http://codereview.chromium.org/601070
------------------------------------------------------------------------
r39483 | vangelis@chromium.org | 2010-02-19 20:56:28 +0100 (Fri, 19 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Adding command line flag (--show-composited-render-layers) to enable the showDebugBorders setting in WebKit which is
used for displaying a border around composited layers.
BUG=35613
TEST=NONE
Review URL: http://codereview.chromium.org/593099
------------------------------------------------------------------------
r39482 | rohitrao@chromium.org | 2010-02-19 20:55:30 +0100 (Fri, 19 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

[Mac] Always update the status bubble size when going fullscreen.

BUG=36273
TEST=Switch to fullscreen with the status bubble hidden, then mouseover a link.  Status bubble should have the proper width.
Review URL: http://codereview.chromium.org/650050
------------------------------------------------------------------------
r39471 | viettrungluu@chromium.org | 2010-02-19 20:11:51 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm

Mac: enable minimize in fullscreen mode.

BUG=36109
TEST=Enter fullscreen mode. Make sure Cmd-M and Window->Minimize work. Also make sure fullscreen windows are restored properly.

Review URL: http://codereview.chromium.org/646005
------------------------------------------------------------------------
r39468 | erg@chromium.org | 2010-02-19 20:01:47 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/content_exceptions_table_model.cc (from /trunk/src/chrome/browser/views/options/content_exceptions_table_model.cc:39465)
   A /trunk/src/chrome/browser/content_exceptions_table_model.h (from /trunk/src/chrome/browser/views/options/content_exceptions_table_model.h:39465)
   A /trunk/src/chrome/browser/gtk/options/content_exception_editor.cc
   A /trunk/src/chrome/browser/gtk/options/content_exception_editor.h
   A /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   D /trunk/src/chrome/browser/views/options/content_exceptions_table_model.cc
   D /trunk/src/chrome/browser/views/options/content_exceptions_table_model.h
   M /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gtk_tree.cc
   M /trunk/src/chrome/common/gtk_tree.h

GTK: Implement the exceptions dialog for the content filtering settings.

BUG=35178
TEST=none

Review URL: http://codereview.chromium.org/646060
------------------------------------------------------------------------
r39466 | shess@chromium.org | 2010-02-19 19:52:24 +0100 (Fri, 19 Feb 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc

Modify SafeBrowsingStore interface to explicitly use 32-bit times.

Existing code stores the |time_t| from |base::Time::ToTimeT()| using
|bind_int64()|.  But |time_t| is an unsigned 32-bit value so this
didn't add anything.

Also changed |SafeBrowsingStoreSqlite| to have the singleton writers
use the array writers, rather than vice versa.  The only tie-in is
that otherwise it wanted a helper writer taking an int32 for the time
component to share between |WriteAddHash()| and |WriteAddHashes()|.

[This CL is a prelude to bulk-writing arrays of |SBAddFullHash| to the
database, so making |SBAddFullHash.received| an explicitly simple type
is worthwhile.]

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/646030
------------------------------------------------------------------------
r39462 | chocobo@chromium.org | 2010-02-19 19:40:00 +0100 (Fri, 19 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/theme/statusbar_battery10c.png
   M /trunk/src/chrome/app/theme/statusbar_battery10d.png
   M /trunk/src/chrome/app/theme/statusbar_battery11c.png
   M /trunk/src/chrome/app/theme/statusbar_battery11d.png
   M /trunk/src/chrome/app/theme/statusbar_battery12c.png
   M /trunk/src/chrome/app/theme/statusbar_battery12d.png
   D /trunk/src/chrome/app/theme/statusbar_battery13c.png
   D /trunk/src/chrome/app/theme/statusbar_battery13d.png
   D /trunk/src/chrome/app/theme/statusbar_battery14c.png
   D /trunk/src/chrome/app/theme/statusbar_battery14d.png
   D /trunk/src/chrome/app/theme/statusbar_battery15c.png
   D /trunk/src/chrome/app/theme/statusbar_battery15d.png
   D /trunk/src/chrome/app/theme/statusbar_battery16c.png
   D /trunk/src/chrome/app/theme/statusbar_battery16d.png
   M /trunk/src/chrome/app/theme/statusbar_battery1c.png
   M /trunk/src/chrome/app/theme/statusbar_battery1d.png
   M /trunk/src/chrome/app/theme/statusbar_battery2c.png
   M /trunk/src/chrome/app/theme/statusbar_battery2d.png
   M /trunk/src/chrome/app/theme/statusbar_battery3c.png
   M /trunk/src/chrome/app/theme/statusbar_battery3d.png
   M /trunk/src/chrome/app/theme/statusbar_battery4c.png
   M /trunk/src/chrome/app/theme/statusbar_battery4d.png
   M /trunk/src/chrome/app/theme/statusbar_battery5c.png
   M /trunk/src/chrome/app/theme/statusbar_battery5d.png
   M /trunk/src/chrome/app/theme/statusbar_battery6c.png
   M /trunk/src/chrome/app/theme/statusbar_battery6d.png
   M /trunk/src/chrome/app/theme/statusbar_battery7c.png
   M /trunk/src/chrome/app/theme/statusbar_battery7d.png
   M /trunk/src/chrome/app/theme/statusbar_battery8c.png
   M /trunk/src/chrome/app/theme/statusbar_battery8d.png
   M /trunk/src/chrome/app/theme/statusbar_battery9c.png
   M /trunk/src/chrome/app/theme/statusbar_battery9d.png
   M /trunk/src/chrome/app/theme/statusbar_battery_charged.png
   M /trunk/src/chrome/app/theme/statusbar_battery_missing.png
   M /trunk/src/chrome/app/theme/statusbar_battery_unknown.png
   D /trunk/src/chrome/app/theme/statusbar_container.png
   D /trunk/src/chrome/app/theme/statusbar_container_hover.png
   D /trunk/src/chrome/app/theme/statusbar_container_pressed.png
   A /trunk/src/chrome/app/theme/statusbar_network_3g.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars0.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars0b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars1.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars1b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars2.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars2b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars3.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars3b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars4.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars4b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars5.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars5b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars6.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars6b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars7.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars7b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars8.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars8b.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars9.png
   A /trunk/src/chrome/app/theme/statusbar_network_bars9b.png
   M /trunk/src/chrome/app/theme/statusbar_network_disconnected.png
   A /trunk/src/chrome/app/theme/statusbar_network_edge.png
   A /trunk/src/chrome/app/theme/statusbar_network_warning.png
   A /trunk/src/chrome/app/theme/statusbar_pressed.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_dot.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_down1.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_down1p.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_down2.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_down2p.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_down3.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_down3p.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_up1.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_up1p.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_up2.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_up2p.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_up3.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_up3p.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_warning.png
   M /trunk/src/chrome/app/theme/statusbar_wired.png
   A /trunk/src/chrome/app/theme/statusbar_wiredb.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.cc
   M /trunk/src/chrome/browser/chromeos/status/status_area_button.h

New network icons for ChromeOS
TEST=none
BUGS=none
Review URL: http://codereview.chromium.org/634001
------------------------------------------------------------------------
r39461 | mirandac@chromium.org | 2010-02-19 19:39:37 +0100 (Fri, 19 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Fix bookmark star button theming. Patch by Thiago Farina.

BUG= 35028
TEST= Apply a theme. Restart Chrome. Reset to default theme. Bookmark button is correctly returned to default. (see bug report)



Review URL: http://codereview.chromium.org/630006
------------------------------------------------------------------------
r39455 | bauerb@chromium.org | 2010-02-19 18:24:29 +0100 (Fri, 19 Feb 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Allow opening multiple bookmarks with external links from the same page.

Right now, to avoid "carpet bombing" (where a malicious site initiates multiple
downloads), opening an external URL is blocked after the first access until the
user somehow interacts with the page (for example by clicking somewhere).
This doesn't account for opening external links from bookmarks though.

This patch fixes that, by resetting the block state whenever an external URL is
opened by typing it or selecting it from bookmarks.

BUG=31021

TEST=Add a bookmark like mailto://user@hostname to the bookmarks bar and click on it
multiple times in a row (without clicking anywhere else on the page in
between). Depending on your settings, *every time* either a window should open
asking you if you want to open the URL with an external application or your
mail application itself should open.

Review URL: http://codereview.chromium.org/622002
------------------------------------------------------------------------
r39454 | dglazkov@chromium.org | 2010-02-19 18:19:58 +0100 (Fri, 19 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Revert 39450 - Disable 3 interactive tests for now.  They started failing after the last WebKit roll.

TEST=none
BUG=36262

Review URL: http://codereview.chromium.org/651035

TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/650037
------------------------------------------------------------------------
r39451 | joth@chromium.org | 2010-02-19 17:37:42 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc
   M /trunk/src/chrome/browser/geolocation/fake_access_token_store.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc

Fix threading problems in the access token store impl, and majorly simplify the API in process

BUG=http://code.google.com/p/chromium/issues/detail?id=36068
TEST=GeolocationAccessTokenStoreTest.SetAcrossInstances 

Review URL: http://codereview.chromium.org/646044
------------------------------------------------------------------------
r39450 | jorlow@chromium.org | 2010-02-19 17:24:01 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable 3 interactive tests for now.  They started failing after the last WebKit roll.

TEST=none
BUG=36262

Review URL: http://codereview.chromium.org/651035
------------------------------------------------------------------------
r39445 | craig.schlenter@chromium.org | 2010-02-19 16:37:27 +0100 (Fri, 19 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h

Move MockLocationProvider to location_provider.cc to fix Linux shared build.

Error was:
out/Release/lib.target/chrome/libbrowser.so: undefined reference to `NewMockLocationProvider()'

MockLocationProvider is used by location_arbitrator.cc resulting in the
above error.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/644002
------------------------------------------------------------------------
r39444 | bauerb@chromium.org | 2010-02-19 15:57:06 +0100 (Fri, 19 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Added Shift-Reload support for Mac.

On Mac, holding down shift while pressing the reload button now reloads the
page ignoring any caches.

Command-Shift-R doesn't do anything, just like in Safari.

BUG=36245
TEST=visit astronomy picture of the day; hit reload, picture pops
up quickly; hit shift-reload, picture loads slowly

Review URL: http://codereview.chromium.org/651033
------------------------------------------------------------------------
r39441 | evan@chromium.org | 2010-02-19 14:32:16 +0100 (Fri, 19 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/importer_list.cc

importer: use FilePath instead of wstring in some places

Added API to DictionaryValue to use ASCII where appropriate.

BUG=24672
TEST=profile import still got my bookmarks

Review URL: http://codereview.chromium.org/647016
------------------------------------------------------------------------
r39435 | bulach@chromium.org | 2010-02-19 13:11:28 +0100 (Fri, 19 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   A /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   A /trunk/src/chrome/common/geoposition.cc
   A /trunk/src/chrome/common/geoposition.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/geolocation_dispatcher.cc
   A /trunk/src/chrome/renderer/geolocation_dispatcher.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/geolocation
   A /trunk/src/chrome/test/data/geolocation/simple.html

Second try for:
http://src.chromium.org/viewvc/chrome?view=rev&revision=39374
Initial Geolocation implementation
Adds IPC plumbing.
Adds Infobar buttons for requesting permission

This change specifically:
ui_test_utils::WaitForAppModalDialog registers for listening to notifications too late, i.e., after the dialog had been triggered.
Exposes AppModalDialogObserver so that we can register, trigger the dialog, then wait for it.

Review URL: http://codereview.chromium.org/647048
------------------------------------------------------------------------
r39430 | evan@chromium.org | 2010-02-19 11:51:16 +0100 (Fri, 19 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

linux: plumb shift-reload down into new shift-reload API

Currently Linux-only, but the Mac/Win bits should now be trivial.

While I was add it, I tweaked a NavigationController function
that took a bare boolean into an enum to make the call sites more
explicit about what they're doing.

(In most places I added new functions that call into a shared
backing function; this is so I don't need to change every single
caller of e.g. Reload() to pass through an extra flag that will
be the same for almost every caller.)

BUG=1906
TEST=visit astronomy picture of the day; hit reload, picture pops
up quickly; hit shift-reload, picture loads slowly

Review URL: http://codereview.chromium.org/594063
------------------------------------------------------------------------
r39428 | phajdan.jr@chromium.org | 2010-02-19 10:43:08 +0100 (Fri, 19 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.h
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver.mm
   M /trunk/src/chrome/browser/cocoa/window_size_autosaver_unittest.mm
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/encoding_menu_controller.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/form_field_history_manager.cc
   M /trunk/src/chrome/browser/form_field_history_manager.h
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.cc
   A /trunk/src/chrome/browser/important_file_writer.cc (from /trunk/src/chrome/common/important_file_writer.cc:39206)
   A /trunk/src/chrome/browser/important_file_writer.h (from /trunk/src/chrome/common/important_file_writer.h:39206)
   A /trunk/src/chrome/browser/important_file_writer_unittest.cc (from /trunk/src/chrome/common/important_file_writer_unittest.cc:39206)
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/intranet_redirect_detector.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/options_page_base.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/possible_url_model.cc
   A /trunk/src/chrome/browser/pref_member.cc (from /trunk/src/chrome/common/pref_member.cc:39206)
   A /trunk/src/chrome/browser/pref_member.h (from /trunk/src/chrome/common/pref_member.h:39206)
   A /trunk/src/chrome/browser/pref_member_unittest.cc (from /trunk/src/chrome/common/pref_member_unittest.cc:39206)
   A /trunk/src/chrome/browser/pref_service.cc (from /trunk/src/chrome/common/pref_service.cc:39206)
   A /trunk/src/chrome/browser/pref_service.h (from /trunk/src/chrome/common/pref_service.h:39241)
   A /trunk/src/chrome/browser/pref_service_uitest.cc (from /trunk/src/chrome/common/pref_service_uitest.cc:39206)
   A /trunk/src/chrome/browser/pref_service_unittest.cc (from /trunk/src/chrome/common/pref_service_unittest.cc:39206)
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_prefs.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/common/important_file_writer.cc
   D /trunk/src/chrome/common/important_file_writer.h
   D /trunk/src/chrome/common/important_file_writer_unittest.cc
   D /trunk/src/chrome/common/pref_member.cc
   D /trunk/src/chrome/common/pref_member.h
   D /trunk/src/chrome/common/pref_member_unittest.cc
   D /trunk/src/chrome/common/pref_service.cc
   D /trunk/src/chrome/common/pref_service.h
   D /trunk/src/chrome/common/pref_service_uitest.cc
   D /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/chrome_frame/test/reliability/page_load_test.cc

Move pref_{member,service} and important_file_writer from chrome/common
to chrome/browser.

This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.

TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
------------------------------------------------------------------------
r39425 | tony@chromium.org | 2010-02-19 06:14:38 +0100 (Fri, 19 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Ignore titlebar drags if the window is maximized and matches the screen
size.  This is to work around a case that would normally fullscreen
the window.

BUG=23480
TEST=maximize chrome on a desktop w/o gnome panels and try to drag
  the area behind the tabs.  nothing should happen.

Review URL: http://codereview.chromium.org/651005
------------------------------------------------------------------------
r39423 | jar@chromium.org | 2010-02-19 05:42:16 +0100 (Fri, 19 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc

Revert 39421 - Switch to putting appversion at top level of XML

This change puts appversion at the same level as buildtime, and
so it is avalable (now) for use in histogram versioning, as well
as stability versioning (or user metrics versioning).

r=huanr
Review URL: http://codereview.chromium.org/646056

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/651012
------------------------------------------------------------------------
r39421 | jar@chromium.org | 2010-02-19 05:22:25 +0100 (Fri, 19 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc

Switch to putting appversion at top level of XML

This change puts appversion at the same level as buildtime, and
so it is avalable (now) for use in histogram versioning, as well
as stability versioning (or user metrics versioning).

r=huanr
Review URL: http://codereview.chromium.org/646056
------------------------------------------------------------------------
r39419 | akalin@chromium.org | 2010-02-19 04:15:59 +0100 (Fri, 19 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   A /trunk/src/base/callback.h
   A /trunk/src/base/callback_unittest.cc (from /trunk/src/base/task_unittest.cc:39418)
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/task.h
   D /trunk/src/base/task_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/version_loader.h
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/file_reader.h
   M /trunk/src/chrome/browser/extensions/file_reader_unittest.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/mock_browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/mock_browsing_data_database_helper.h
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_notification_task.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   M /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/util/closure.h
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/select_file_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/web_applications/web_app.h
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/sync_msg_reply_dispatcher.h
   M /trunk/src/chrome_frame/test/automation_client_mock.cc
   M /trunk/src/gpu/command_buffer/client/cmd_buffer_helper_test.cc
   M /trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc
   M /trunk/src/gpu/command_buffer/client/gles2_demo.cc
   M /trunk/src/gpu/command_buffer/service/command_buffer_service.cc
   M /trunk/src/gpu/command_buffer/service/command_buffer_service.h
   M /trunk/src/gpu/command_buffer/service/command_buffer_service_unittest.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
   M /trunk/src/gpu/command_buffer/service/gpu_processor.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor.h
   M /trunk/src/gpu/demos/framework/window.cc
   M /trunk/src/media/base/callback.h
   M /trunk/src/media/base/filters.h
   M /trunk/src/media/base/mock_filters.h
   M /trunk/src/media/base/mock_reader.h
   M /trunk/src/media/base/pipeline.h
   M /trunk/src/media/base/pipeline_impl.cc
   M /trunk/src/media/base/pipeline_impl_unittest.cc
   M /trunk/src/media/filters/audio_renderer_algorithm_base.h
   M /trunk/src/media/filters/audio_renderer_algorithm_ola_unittest.cc
   M /trunk/src/media/filters/audio_renderer_base.cc
   M /trunk/src/media/filters/audio_renderer_base_unittest.cc
   M /trunk/src/media/filters/decoder_base.h
   M /trunk/src/media/filters/ffmpeg_demuxer.cc
   M /trunk/src/media/filters/ffmpeg_demuxer.h
   M /trunk/src/media/filters/ffmpeg_demuxer_unittest.cc
   M /trunk/src/media/filters/file_data_source_unittest.cc
   M /trunk/src/media/filters/omx_video_decode_engine.cc
   M /trunk/src/media/filters/omx_video_decode_engine.h
   M /trunk/src/media/filters/omx_video_decoder.cc
   M /trunk/src/media/filters/video_decoder_impl_unittest.cc
   M /trunk/src/media/filters/video_renderer_base.cc
   M /trunk/src/media/filters/video_renderer_base_unittest.cc
   M /trunk/src/media/omx/omx_codec.cc
   M /trunk/src/media/omx/omx_codec.h
   M /trunk/src/media/omx/omx_codec_unittest.cc
   M /trunk/src/media/omx/omx_output_sink.h
   M /trunk/src/media/tools/omx_test/omx_test.cc
   M /trunk/src/media/tools/wav_ola_test/wav_ola_test.cc
   M /trunk/src/net/base/completion_callback.h
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/static_cookie_policy.h
   M /trunk/src/net/base/test_completion_callback.h
   M /trunk/src/net/disk_cache/disk_cache_test_util.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/ssl_client_socket.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket_stream/socket_stream_unittest.cc
   M /trunk/src/net/websockets/websocket_unittest.cc
   M /trunk/src/sandbox/src/crosscall_server.h
   M /trunk/src/sandbox/src/sandbox_policy_base.cc
   M /trunk/src/sandbox/src/sharedmem_ipc_server.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/repeat_controller.h
   M /trunk/src/webkit/appcache/appcache_host.h
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_response.h
   M /trunk/src/webkit/appcache/appcache_storage_impl.h
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.cc
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.h
   M /trunk/src/webkit/glue/cpp_bound_class.h
   M /trunk/src/webkit/glue/image_resource_fetcher.cc
   M /trunk/src/webkit/glue/image_resource_fetcher.h
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.h
   M /trunk/src/webkit/glue/media/buffered_data_source_unittest.cc
   M /trunk/src/webkit/glue/media/simple_data_source_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher.h
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.cc
   M /trunk/src/webkit/tools/test_shell/accessibility_ui_element.cc
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc

Pulled out Callback code into base/callback.h.  This is the first step towards redoing the Callback interfaces.

Added and removed includes as needed.

BUG=35223
TEST=trybots

Review URL: http://codereview.chromium.org/646061
------------------------------------------------------------------------
r39415 | ananta@chromium.org | 2010-02-19 02:57:41 +0100 (Fri, 19 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/chrome.dll.deps
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Fix a Chrome crash caused in a ChromeFrame instance while displaying the inspector window. The inspector window uses the browser view 
which instantiates the whole view including the ToolBar, which in turn instantiates the Autocomplete edit bar which uses Richedit on Windows. 
The auto complete edit bar dynamically loads and unloads the richedit control and it uses ATL to superclass the richedit control. If the
rich edit dll loads at a different base address it causes a crash in Chrome while creating the window as ATL caches the wndproc address for a class.

Fix is to setup an implicit dependency on the riched20.dll and not load and free it all the time. To achieve this we use #pragma comment for the 
riched20.lib and a dummy call to the CreateTextServices function exported by the dll to ensure that the linker does not discard the import.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=33308

Bug=33308

Review URL: http://codereview.chromium.org/646043
------------------------------------------------------------------------
r39412 | dantasse@chromium.org | 2010-02-19 02:28:03 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h

check if ModelNeutralExecuteImpl succeeded before running ModelChangingExecuteImpl

BUG:36200
TEST:manual

Review URL: http://codereview.chromium.org/646078
------------------------------------------------------------------------
r39411 | shess@chromium.org | 2010-02-19 02:19:15 +0100 (Fri, 19 Feb 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Refactor omnibox popup to fix click-drag display.

Fix the confusion between highlighted and selected cells by
overriding |-mouseDown:| and directly implementing the desired
behaviors.  Which are:

 - while mouse is down in the view, the item under the mouse
   looks selected, like it would if you used the arrow keys to
   move it around (rather than highlighted).
 - dragging off with mouse down reverts to previous
   selection (the one matching the field's contents).
 - releasing while mouse is off-view reverts to previous
   selection.
 - dragging back with mouse still down selects the cell under the
   mouse.

Additionally, refactor to remove useless utility object.  The
custom matrix now just messages the C++ object directly.

BUG=25435
TEST=See bug.

Review URL: http://codereview.chromium.org/646063
------------------------------------------------------------------------
r39410 | scherkus@chromium.org | 2010-02-19 02:10:16 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Extracted non-XRender painting path from BackingStoreX into PutARGBImage().

BUG=n/a
TEST=everything should stay the same

Review URL: http://codereview.chromium.org/647062
------------------------------------------------------------------------
r39409 | johnnyg@chromium.org | 2010-02-19 02:02:46 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   D /trunk/src/chrome/browser/resources/notification.html
   A /trunk/src/chrome/browser/resources/notification_1line.html
   A /trunk/src/chrome/browser/resources/notification_2line.html
   A /trunk/src/chrome/browser/resources/notification_icon.html

Instead of using a single template file and leaving some parts of it out, use template files for each configuration.  this allows for better presentation of small notifications without a lot of empty space.

BUG=36081
TEST=create notification with a short string

Review URL: http://codereview.chromium.org/628010
------------------------------------------------------------------------
r39408 | mpcomplete@chromium.org | 2010-02-19 01:57:35 +0100 (Fri, 19 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc

Fix a crash when installing an extension from incognito mode.

BUG=36077

Review URL: http://codereview.chromium.org/646072
------------------------------------------------------------------------
r39406 | avi@chromium.org | 2010-02-19 01:39:50 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/dock_icon.mm

Fix dock icon while downloading.

BUG=http://crbug.com/35791
TEST=paste on a new app icon, download something, switch between apps, app icon should always be right

Review URL: http://codereview.chromium.org/646036
------------------------------------------------------------------------
r39405 | jianli@chromium.org | 2010-02-19 01:36:58 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/app/gtk_dnd_util.h
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/download/drag_download_file.cc
   M /trunk/src/chrome/browser/download/drag_download_util.cc
   M /trunk/src/chrome/browser/download/drag_download_util.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h

Support dragging a virtual file out of the browser on Linux. This is based on the discussion of drag-out feature on whatwg: http://list.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html

BUG=none
TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder.

Review URL: http://codereview.chromium.org/600154
------------------------------------------------------------------------
r39399 | sky@chromium.org | 2010-02-19 00:54:54 +0100 (Fri, 19 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc

Fixes bug in about:memory that resulted in showing null for browser if
you had a crashed tab or phantom tab.

BUG=none
TEST=create two tabs, pin one, close it (so that it goes phantom),
  navigate to about:memory and make sure you don't see an entry for
  the
  phantom tab.

Review URL: http://codereview.chromium.org/646035
------------------------------------------------------------------------
r39398 | shess@chromium.org | 2010-02-19 00:53:11 +0100 (Fri, 19 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc

Remove dead code from safe_browsing_util.h/cc.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/630012
------------------------------------------------------------------------
r39397 | cpu@chromium.org | 2010-02-19 00:51:39 +0100 (Fri, 19 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Have rlz record first search event in a corner case

1- start chrome do nothing for 90+ seconds
2- close chrome
3- relaunch chrome
4- type in the omnimbox before 90 seconds
5- observe (with debuger) that first search event is not recorded

BUG=b\1812626
TEST=see bug for testing details.


Review URL: http://codereview.chromium.org/646031
------------------------------------------------------------------------
r39396 | finnur@chromium.org | 2010-02-19 00:12:56 +0100 (Fri, 19 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc

Fix 33138: Clicking on the extension name for an extension downloaded
off the web (non-gallery) goes to the Gallery page (and shows id not
found). We now disable this link for non-gallery extensions.

BUG=33138
TEST=Download an extension from a non-gallery source. Right click the
icon, the name menu item should be grayed out. For extensions from the
gallery, it should not be grayed out. It should link to the gallery.

Review URL: http://codereview.chromium.org/646026
------------------------------------------------------------------------
r39393 | eroman@chromium.org | 2010-02-19 00:06:27 +0100 (Fri, 19 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove the command line flag --testing-fixed-host.
This has been superceded by --host-resolver-rules.

(Instead of --testing-fixed-host="foobar" one would use --host-resolver-rules="MAP * foobar")

BUG=36053

Review URL: http://codereview.chromium.org/647005
------------------------------------------------------------------------
r39392 | darin@chromium.org | 2010-02-19 00:04:40 +0100 (Fri, 19 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc

The PromptDelegate needs to delete itself once it gets a reply.

R=jorlow
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/646021
------------------------------------------------------------------------
r39389 | snej@chromium.org | 2010-02-18 23:45:05 +0100 (Thu, 18 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   A /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_gtk.cc
   A /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_mac.mm
   A /trunk/src/chrome/browser/ssl/ssl_client_auth_handler_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.h

Client-side SSL cert support for Mac.
This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen.
BUG=16831
TEST=none

Review URL: http://codereview.chromium.org/604067
------------------------------------------------------------------------
r39388 | jcampan@chromium.org | 2010-02-18 23:39:21 +0100 (Thu, 18 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

We need to traverse the infobars with a reverse loop as
we remove them (as after removal the index is pointing
too far by 1, so the next immediate infobar won't be removed).

BUG=None
TEST=Get to a page with 2 infobars (for ex: crash the
     browser and restart (so you get the browser crashed
     infobar and make it not your default browser so you
     get the default browser infobar), kill the page process
     with the task manager. The sad page should be shown
     and the infobars should disappear.

Review URL: http://codereview.chromium.org/646045
------------------------------------------------------------------------
r39385 | cira@chromium.org | 2010-02-18 23:25:15 +0100 (Thu, 18 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/common/extensions/extension_message_filter_peer.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc

Adding @@extension_id reserved message to l10n message map for extension.

It's added outside of ExtensionMessageBundle so that non-localized extensions can use it. Developer doesn't have to define default_locale in the manifest in order to get it working.

With this change every extension css file will go through message replacement process (only localized extensions went through that before).

This change will allow following construct in extension css:

body {

  background-image:url('chrome-extension://__MSG_@@extension_id__/background.png');

}

BUG=35208
TEST=Add an background image to your extension, and refer to it from css file using __MSG_@@extension_id__. Image should show up in the background.

Review URL: http://codereview.chromium.org/628009
------------------------------------------------------------------------
r39384 | jcampan@chromium.org | 2010-02-18 23:21:18 +0100 (Thu, 18 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h

This CL makes switching the target back to the original language
revert the translation.
It also simplifies the page translator logic. We are initializing the PageTranslator states when a new page is translated.  Further translations reuse the text nodes already retrieved.
Also an unused method has been removed from RenderView.

BUG=36073
TEST=See bug. Thoroughly test the translation feature.

Review URL: http://codereview.chromium.org/647030
------------------------------------------------------------------------
r39382 | viettrungluu@chromium.org | 2010-02-18 23:11:55 +0100 (Thu, 18 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm

Mac fullscreen: prevent mouse clicks on overlay from passing through to content.

Also make it so that double-clicks on overlay should (theoretically) minimize.

BUG=36108
TEST=Enter fullscreen mode. With content having links or similar (e.g., NTP bookmark bar), click at various locations on the (slide-down) overlay bar. Clicks should not pass through. Mouse cursor should not reflect web content underneath.

Review URL: http://codereview.chromium.org/646004
------------------------------------------------------------------------
r39381 | jcampan@chromium.org | 2010-02-18 23:10:54 +0100 (Thu, 18 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Remove all infobars from a tab when its renderer crashes.
They are irrelevant in the sad tab.

BUG=36035
TEST=Navigate to a foreign page so the translate infobar shows up.
     From the task manager, kill the renderer process for that page.
     The translate infobar should disappear.

Review URL: http://codereview.chromium.org/646023
------------------------------------------------------------------------
r39374 | bulach@chromium.org | 2010-02-18 20:33:11 +0100 (Thu, 18 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   D /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   D /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   D /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   D /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   A /trunk/src/chrome/browser/geolocation/geoposition.cc (from /trunk/src/chrome/browser/geolocation/geoposition.cc:39365)
   A /trunk/src/chrome/browser/geolocation/geoposition.h (from /trunk/src/chrome/browser/geolocation/geoposition.h:39365)
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   D /trunk/src/chrome/common/geoposition.cc
   D /trunk/src/chrome/common/geoposition.h
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/renderer/geolocation_dispatcher.cc
   D /trunk/src/chrome/renderer/geolocation_dispatcher.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/geolocation

Revert 39366 - Initial Geolocation implementation
Adds IPC plumbing.
Adds Infobar buttons for requesting permission

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/548188

TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/646027
------------------------------------------------------------------------
r39368 | finnur@chromium.org | 2010-02-18 18:42:51 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc

Test SetAcrossInstances crashed on Mac also. Disabling.

BUG=36068
TEST=None
TBR=joth

Review URL: http://codereview.chromium.org/647025
------------------------------------------------------------------------
r39366 | bulach@chromium.org | 2010-02-18 17:44:22 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h
   A /trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_permission_context.h
   D /trunk/src/chrome/browser/geolocation/geoposition.cc
   D /trunk/src/chrome/browser/geolocation/geoposition.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/common_param_traits_unittest.cc
   A /trunk/src/chrome/common/geoposition.cc
   A /trunk/src/chrome/common/geoposition.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/geolocation_dispatcher.cc
   A /trunk/src/chrome/renderer/geolocation_dispatcher.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/geolocation
   A /trunk/src/chrome/test/data/geolocation/simple.html

Initial Geolocation implementation
Adds IPC plumbing.
Adds Infobar buttons for requesting permission

TEST=geolocation_browsertest.cc

Review URL: http://codereview.chromium.org/548188
------------------------------------------------------------------------
r39365 | sky@chromium.org | 2010-02-18 17:41:31 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Fixes close other tabs regression. It needed to check overall tab
count too.

BUG=35576
TEST=see bug

Review URL: http://codereview.chromium.org/629006
------------------------------------------------------------------------
r39360 | evan@chromium.org | 2010-02-18 16:56:16 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/power_save_blocker_stub.cc

convert power_save_blocker NOTIMPLEMENTED into a bug

Warning everyone about this every time we run the app is not helpful.

BUG=33605,34081

Review URL: http://codereview.chromium.org/646012
------------------------------------------------------------------------
r39359 | evan@chromium.org | 2010-02-18 16:53:36 +0100 (Thu, 18 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc

Revert "linux: enable seccomp sandbox by default"

This reverts commit r39358.
------------------------------------------------------------------------
r39358 | evan@chromium.org | 2010-02-18 16:25:55 +0100 (Thu, 18 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc

linux: enable seccomp sandbox by default

This is an experiment.  Hopefully it will flush out problems.
Use --disable-seccomp-sandbox to turn it off.

BUG=36133

Review URL: http://codereview.chromium.org/647017
------------------------------------------------------------------------
r39352 | joth@chromium.org | 2010-02-18 13:11:14 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc

Switch browser prefs to use the higher level geolocation::RegisterPrefs method rather than call into random internal component of geolocaiton (and so avoid the associated header file dependency bloat)
geolocation_prefs.h was already added in http://src.chromium.org/viewvc/chrome?view=rev&revision=39232 I just forgot to include this edit

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/618016
------------------------------------------------------------------------
r39346 | jochen@chromium.org | 2010-02-18 11:02:26 +0100 (Thu, 18 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/time.h
   M /trunk/src/base/time_posix.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.cc
   M /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h
   M /trunk/src/webkit/database/database_tracker_unittest.cc

Actually delete databases in CookiesTreeModel.

BUG=34633
TEST=delete a database while it's opened in the renderer

Review URL: http://codereview.chromium.org/600104
------------------------------------------------------------------------
r39345 | evan@chromium.org | 2010-02-18 10:30:24 +0100 (Thu, 18 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

linux: clean up a bit of redundant logic

I noticed this while looking for something else.  In theory, this
will reduce flashing when the dialog comes up (since we first do
all the layout of the contents and then once that's all done we
show the window), but I haven't verified that.

Review URL: http://codereview.chromium.org/608034
------------------------------------------------------------------------
r39343 | cevans@chromium.org | 2010-02-18 09:11:11 +0100 (Thu, 18 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/webkit/glue/webpreferences.h

Flip the "unique file:// URI origin" flag to on. Add the
--allow-file-access-from-files developer switch. Turn on this flag for the UI
tests, which depend on the old behaviour.

BUG=4197
TEST=WebKit test submitted upstream
TBR=abarth

Review URL: http://codereview.chromium.org/648003
------------------------------------------------------------------------
r39342 | eroman@chromium.org | 2010-02-18 09:03:38 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/net/base/fixed_host_resolver.cc
   D /trunk/src/net/base/fixed_host_resolver.h
   M /trunk/src/net/base/host_resolver.h
   A /trunk/src/net/base/mapped_host_resolver.cc
   A /trunk/src/net/base/mapped_host_resolver.h
   A /trunk/src/net/base/mapped_host_resolver_unittest.cc
   M /trunk/src/net/net.gyp

Add a command-line flag to remap hostnames based on patterns.
This is a generalization of the --testing-fixed-server flag.

BUG=36053
TEST=MappedHostResolverTest.*

Review URL: http://codereview.chromium.org/647001
------------------------------------------------------------------------
r39340 | nick@chromium.org | 2010-02-18 08:56:19 +0100 (Thu, 18 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Add a unit test verifying the merge behavior when there are two
duplicate URLs.  I promised this test a long time ago for an old bug.

TEST=ran this unittest; passes at trunk, fails if you change "multiset"
to "set" in the BookmarkNodeFinder.
BUG=24995

Review URL: http://codereview.chromium.org/640002
------------------------------------------------------------------------
r39339 | davemoore@chromium.org | 2010-02-18 07:44:42 +0100 (Thu, 18 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   A /trunk/src/chrome/browser/chromeos/login/test_renderer_screen.cc
   A /trunk/src/chrome/browser/chromeos/login/test_renderer_screen.h
   M /trunk/src/chrome/browser/chromeos/login/user_manager.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h

Use regular message loop for cros login window

First we have to allow the regular initialization to happen.
This will permit the login wizard screens to use the network
and rendering capabilities of chrome safely. Once a user logs in
and cros mounts their encrypted directory as a profile, we
change the default profile to that one and create a new browser
window with it as well. This ought to make launching the
first browser window even faster.

Review URL: http://codereview.chromium.org/604052
------------------------------------------------------------------------
r39338 | ukai@chromium.org | 2010-02-18 07:21:09 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc

Use net::LOAD_IGNORE_CERT_AUTHORITY_INVALID for websocket experiment
to avoid Mac SSL issue.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/648001
------------------------------------------------------------------------
r39337 | viettrungluu@chromium.org | 2010-02-18 07:08:02 +0100 (Thu, 18 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: allow Esc in the Omnibox to give up focus in fullscreen mode.

(Use the same "signal" as for stopping load: if we'd allow Esc to stop loading
the current page, we'll let Esc dismiss the Omnibox.)

BUG=35961
TEST=Enter fullscreen mode, Cmd-L to focus the Omnibox (and thus show it), Esc should revert to the original URL and give up focus (hiding the Omnibox). In normal, non-fullscreen mode, Esc should work as before.

Review URL: http://codereview.chromium.org/601091
------------------------------------------------------------------------
r39329 | finnur@chromium.org | 2010-02-18 04:58:42 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc

Turns out the test crashes on Linux, not just Linux with toolkit_views.

BUG=http://crbug.com/36068
TEST=None
TBR=joth

Review URL: http://codereview.chromium.org/645002
------------------------------------------------------------------------
r39328 | sky@chromium.org | 2010-02-18 04:51:50 +0100 (Thu, 18 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h

Fixes two bugs in cookie prompting:

. In certain situations we could crash because we weren't letting
  CookiePromptView::Init complete and then attempting to reference
  some NULL fields. I've fixed this by adding AppModalDialog::IsValid
  and moving the logic that was in Init to IsValid. This way we only create
  CookiePromptView when needed.
. We were leaking AppModalDialogs. I've made CookiePromptView own the
  AppModalDialog and delete it when the CookiePromptView is deleted.

BUG=36079
TEST=enable prompting for cookies, go to a bunch of sites make sure
     you don't crash.

Review URL: http://codereview.chromium.org/632006
------------------------------------------------------------------------
r39318 | dhollowa@chromium.org | 2010-02-18 03:03:10 +0100 (Thu, 18 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Incremental addition to preferences_window_controller that handles the button click for changing autofill settings from the preferences dialog on Mac.  Due to the deferred loading of the PesonalDataManager data we install an observer that waits for the data to load before bringing up the dialog for the user.  This is a precondition for having the PersonalDataManager data available for display in the dialog.

These changes do not address sending the actual data down to the dialog for display.  That will be addressed in future change.

BUG=33029
TEST=none


Review URL: http://codereview.chromium.org/620006
------------------------------------------------------------------------
r39310 | jhawkins@chromium.org | 2010-02-18 02:29:24 +0100 (Thu, 18 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h

Send suggestions from the AutoFillManager to the AutoFillSuggestionsPopup in WebKit.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/627005
------------------------------------------------------------------------
r39309 | estade@chromium.org | 2010-02-18 02:28:05 +0100 (Thu, 18 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

GTK: add some interactive tests to catch common bookmark bar regressions.

BUG=33220, 34564
TEST=test passes

Review URL: http://codereview.chromium.org/606009
------------------------------------------------------------------------
r39308 | estade@chromium.org | 2010-02-18 02:27:56 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

GTK: make selections in task manager apply to all members of resource group

BUG=33087
TEST=manual


Review URL: http://codereview.chromium.org/614008
------------------------------------------------------------------------
r39307 | chron@google.com | 2010-02-18 02:25:00 +0100 (Thu, 18 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc

Add unique hashing to sync API.

TEST=included unit test
BUG=35586

Review URL: http://codereview.chromium.org/593094
------------------------------------------------------------------------
r39304 | cevans@chromium.org | 2010-02-18 01:07:28 +0100 (Thu, 18 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Revert 39287 - Chromium pieces to use the WebKit support for isolation file:// documents in
their own unique domains.
By default, we use this isolation for security. We provide a command line switch
override for developers: allowfileaccessfromfiles

BUG=4197
TEST=WebKit test pending

Review URL: http://codereview.chromium.org/625001

TBR=abarth@chromium.org
Review URL: http://codereview.chromium.org/625007
------------------------------------------------------------------------
r39303 | finnur@chromium.org | 2010-02-18 01:06:58 +0100 (Thu, 18 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc

Disabling a test that crashes on Linux Views bot.

BUG=http://crbug.com/36068
TEST=None
TBR=joth

Review URL: http://codereview.chromium.org/630008
------------------------------------------------------------------------
r39296 | kuan@chromium.org | 2010-02-18 00:27:51 +0100 (Thu, 18 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

previous cl (r39286) only disables commands in fullscreen mode for chromeos=1, this cl adds another variant toolkit_views=1.

BUG=34340
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/629005
------------------------------------------------------------------------
r39295 | viettrungluu@chromium.org | 2010-02-18 00:24:13 +0100 (Thu, 18 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Make Esc in Omnibox *not* stop loading if it has reverted editing.

BUG=none
TEST=Begin loading a slow-loading web page. While it's loading, begin editing in the Omnibox. While it's still loading, press Esc. The text should revert to the original URL and be all selected, but the page should continue loading. A second Esc at this point should stop loading.

Review URL: http://codereview.chromium.org/628005
------------------------------------------------------------------------
r39287 | cevans@chromium.org | 2010-02-17 23:58:43 +0100 (Wed, 17 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Chromium pieces to use the WebKit support for isolation file:// documents in
their own unique domains.
By default, we use this isolation for security. We provide a command line switch
override for developers: --allow-file-access-from-files

BUG=4197
TEST=WebKit test pending

Review URL: http://codereview.chromium.org/625001
------------------------------------------------------------------------
r39286 | kuan@chromium.org | 2010-02-17 23:42:37 +0100 (Wed, 17 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

disable comamnds in full screen mode

original bug was to disable CTRL+B (toggling of bookmark bar) in full screen mode; turns out there's a method that other platforms call to disable specific comamnds in full screen mode

BUG=34340
TEST=verify per bug report.

Review URL: http://codereview.chromium.org/626007
------------------------------------------------------------------------
r39285 | zelidrag@chromium.org | 2010-02-17 23:40:56 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/js_modal_dialog.cc

Fixed regression due to refactoring change from http://codereview.chromium.org/560030/show

BUG=33698
TEST=see the bug for repro steps

Review URL: http://codereview.chromium.org/621005
------------------------------------------------------------------------
r39282 | skrul@chromium.org | 2010-02-17 23:26:33 +0100 (Wed, 17 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   A /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/testing_profile.cc

This change will include preferences as part of the usual startup sequence of the PSS that already includes bookmarks.  This is a temporary solution until we have a proper component to manage the startup and shutdown of multiple data types.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39143

Review URL: http://codereview.chromium.org/601037
------------------------------------------------------------------------
r39279 | avi@chromium.org | 2010-02-17 23:15:13 +0100 (Wed, 17 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_theme_provider_init.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Allow the Mac theme provider to give default colors/tints if requested. Switch the download shelf's "open downloads" link to directly use the theme provider.

BUG=http://crbug.com/35554
TEST=no visible change in normal mode; incognito mode still being worked on
Review URL: http://codereview.chromium.org/630002
------------------------------------------------------------------------
r39275 | dpolukhin@chromium.org | 2010-02-17 23:03:26 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Prevent resizing tab content to 0.

BUG=33440
TEST=Content of duplicated tab should be visible on Chrome OS.

Review URL: http://codereview.chromium.org/616002
------------------------------------------------------------------------
r39274 | atwilson@chromium.org | 2010-02-17 23:00:51 +0100 (Wed, 17 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc

Fixes a race condition when a shared worker exits while one parent is loading
it.
Changed the shared worker startup code to assign a route ID at the time that we
initially lookup the worker, and pass that same route ID in when we later try
to create the worker, to gracefully handle this race condition.

BUG=29243

TEST=existing tests suffice (can't reproduce race condition in tests)

Review URL: http://codereview.chromium.org/600103
------------------------------------------------------------------------
r39270 | jorlow@chromium.org | 2010-02-17 22:35:08 +0100 (Wed, 17 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc

When we're initializing the modal dialog box which asks whether the page has permission to access a "cookie", double check that the value has not since been set.  If it has, close the window before it's even shown.

This is a stop-gap solution.  We should probably come up with something more elegent long term.

TEST=Go to a page that starts a database transaction and immediately sets a local storage value.  You should get one prompt instead of 2.
BUG=36006


Review URL: http://codereview.chromium.org/619009
------------------------------------------------------------------------
r39269 | joth@chromium.org | 2010-02-17 22:31:59 +0100 (Wed, 17 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/geolocation/fake_access_token_store.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc

Fix valgrind memory leak. Adding missing virtual on a destructor.
 ~AccessTokenStoreFactory() was the culprit, the others are for completeness.

BUG=none
TEST=linux_valgrind try server
TBR=bulach@chromium.org

Review URL: http://codereview.chromium.org/632001
------------------------------------------------------------------------
r39266 | avi@chromium.org | 2010-02-17 22:11:35 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/dock_icon.mm

Fix dock icon to properly pick up pasted-on app icons.

BUG=http://crbug.com/35791
TEST=paste on a new app icon, download something, make sure icon stays in the dock as is

Review URL: http://codereview.chromium.org/628001
------------------------------------------------------------------------
r39265 | jcampan@chromium.org | 2010-02-17 22:06:36 +0100 (Wed, 17 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/language_state.cc
   M /trunk/src/chrome/browser/tab_contents/language_state.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

Makes sure we don't display several times the translate infobar for a page.
We can get several PAGE_DETERMINED notifications for one page.
The user might have closed the translate infobar between these multiple
notifications.  This CL ensures we don't show the infobar again in such
cases.

BUG=35919
TEST=See bug.

Review URL: http://codereview.chromium.org/613002
------------------------------------------------------------------------
r39264 | jhawkins@chromium.org | 2010-02-17 22:04:36 +0100 (Wed, 17 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Relanding r38479.  The underlying memory leak in WebKit has been fixed.

Send forms seen in the renderer to the AutoFillManager.

TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/623003
------------------------------------------------------------------------
r39262 | jcampan@chromium.org | 2010-02-17 21:56:38 +0100 (Wed, 17 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h

Calls InfoBarClosed on InfoBarDelegates in unit-tests to
ensure the InfoBarDelegates are not leaked.

BUG=35614
TEST=No leak in valgrind when running unit-tests.

Review URL: http://codereview.chromium.org/600157
------------------------------------------------------------------------
r39259 | chron@google.com | 2010-02-17 21:44:52 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h
   M /trunk/src/chrome/test/sync/test_http_bridge_factory.h

Add support for the Update-Client-Auth header to sync. Add a mutex to the auth token in ServerConnectionManager.

TEST=manually tested using fiddler2 script.
BUG=35321

Review URL: http://codereview.chromium.org/605010
------------------------------------------------------------------------
r39258 | viettrungluu@chromium.org | 2010-02-17 21:40:49 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm

Mac: prevent the overlay from sliding in and out on fullscreen mode switch.

BUG=35959
TEST=Go to various web pages, focus various things, switch in and out of fullscreen mode; overlay should never slide in and then out (it should either be and stay in, if appropriate, or be out and stay out).

Review URL: http://codereview.chromium.org/601090
------------------------------------------------------------------------
r39257 | erg@google.com | 2010-02-17 21:38:45 +0100 (Wed, 17 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc

GTK: Prevent chrome from hanging at shutdown after clicking flash player settings.

When I copied the Windows dialogs, I copied this Windows bug, too. Merge
the fix for linux.

BUG=34941
TEST=none

Review URL: http://codereview.chromium.org/601096
------------------------------------------------------------------------
r39255 | erg@google.com | 2010-02-17 21:37:34 +0100 (Wed, 17 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

GTK: Fix corrupted tab edges when theme changes.

The tab renderer caches composited images, but this means that pieces of the
old theme hang around when we switch themes. Drop the cache when we hear
a BROWSER_THEME_CHANGED notification.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/601095
------------------------------------------------------------------------
r39251 | jhawkins@chromium.org | 2010-02-17 20:32:10 +0100 (Wed, 17 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Linux: Implement the new AutoFill section of the Options dialog.

* Updated the text of the radio buttons.
* Added a button that opens the AutoFill dialog.

BUG=33025
TEST=manually

Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/579020
Review URL: http://codereview.chromium.org/610003
------------------------------------------------------------------------
r39250 | estade@chromium.org | 2010-02-17 20:20:45 +0100 (Wed, 17 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h

Bookmark manager: don't unset |model_| when executing a command.

It's valid to reuse the same BookmarkContextMenuModel more than once.

BUG=35438
TEST=manual

Review URL: http://codereview.chromium.org/609009
------------------------------------------------------------------------
r39248 | arv@chromium.org | 2010-02-17 20:10:24 +0100 (Wed, 17 Feb 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmarks_favicon.png
   M /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmarks_section.png

Updating the bookmark manager icons.

TBR=glen
BUG=34618
TEST=Look and behold. The section image is now showing a star.

Review URL: http://codereview.chromium.org/618013
------------------------------------------------------------------------
r39241 | jrg@chromium.org | 2010-02-17 19:24:46 +0100 (Wed, 17 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc


BUG=http://crbug.com/34161

TEST=On Win (debug build only), go to about:ipc.  Make sure dialog
  opens and does not hang.

Review URL: http://codereview.chromium.org/600159
------------------------------------------------------------------------
r39240 | mirandac@chromium.org | 2010-02-17 19:23:27 +0100 (Wed, 17 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_theme_provider_init.mm

This fixes the Mac regression in the startup perf tests by removing the
HasCustomImage check from GetNSImageNamed.  The source of the problem was that
HCI was throwing off "nil" for inactive images (which is correct, as they don't
appear in a theme's original image pack), and therefore ignoring the already
created inactive frames, thus creating them twice.

BUG= 34775
TEST= Mac startup regression goes away from perf bots.

Review URL: http://codereview.chromium.org/608023
------------------------------------------------------------------------
r39239 | georgey@chromium.org | 2010-02-17 19:20:15 +0100 (Wed, 17 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

Minor UI updates on the windows auto-fill UI
TEST=Box around CC info/address appears now when they expanded. Items are collapsed by default
BUG=33026
Review URL: http://codereview.chromium.org/613003
------------------------------------------------------------------------
r39235 | erg@google.com | 2010-02-17 18:49:19 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h

GTK: Add a link to flash settings from the clear browsing history dialog.

BUG=35183
TEST=none

Review URL: http://codereview.chromium.org/606070
------------------------------------------------------------------------
r39232 | joth@chromium.org | 2010-02-17 18:33:56 +0100 (Wed, 17 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/access_token_store.cc
   M /trunk/src/chrome/browser/geolocation/access_token_store.h
   A /trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc
   A /trunk/src/chrome/browser/geolocation/fake_access_token_store.h
   A /trunk/src/chrome/browser/geolocation/geolocation_prefs.cc
   A /trunk/src/chrome/browser/geolocation/geolocation_prefs.h
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   A /trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Add unit tests for locaiton arbitrator and browser tests for the access token store (as it integrates with browser singletons)
Fixes a few bugs discovered along the way, and make large-ish redesign of the access token API in order to allow sane use with threading restrictions.

BUG=None 
TEST=unit_tests.exe --gtest_filter=Geol* --gtest_repeat=10000 --gtest_break_on_failure 

Review URL: http://codereview.chromium.org/600141
------------------------------------------------------------------------
r39231 | andybons@chromium.org | 2010-02-17 18:33:01 +0100 (Wed, 17 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Adds grippys to the left side of the Browser Actions container to resize the container (they do not work yet), refactors a bunch of code out of toolbar_controller.mm and adds a slight gradient'ed divider between the container and the page/wrench menus buttons.

http://imgur.com/OqKGF.png

TEST=none
BUG=26990
Review URL: http://codereview.chromium.org/606079
------------------------------------------------------------------------
r39229 | derat@chromium.org | 2010-02-17 18:26:26 +0100 (Wed, 17 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

chromeos: Re-init IPC code when window manager starts.

Chrome's code to look up the WM's window and notify it about
which version of the IPC protocol Chrome supports stopped
firing at the correct time, probably due to the login manager
change.  Additionally, this code wasn't getting re-run if the
window manager crashed and was restarted.

This change makes us watch for MANAGER ClientMessage events
on the root window so that we can reinitialize as needed.

BUG=none
TEST=checked that panel-dragging works after logging in and after killing chromeos-wm

Review URL: http://codereview.chromium.org/610004
------------------------------------------------------------------------
r39227 | viettrungluu@chromium.org | 2010-02-17 18:13:06 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Mac: move status bubble to fullscreen window (and back) when switching modes.

BUG=35962
TEST=Switch to/from fullscreen mode with (or without) the status bubble showing (also in various states of showing -- fading in/out/changing/etc.). Status bubble should appear in new mode, with the appropriate size and in the appropriate place.

Review URL: http://codereview.chromium.org/621001
------------------------------------------------------------------------
r39222 | joth@chromium.org | 2010-02-17 17:16:56 +0100 (Wed, 17 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/net/url_fetcher_protect.h
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/in_process_browser_test.h

Misc. tidy up of various comments found whilst learning the codebase.
Fix a lint warning in render_messages.h (supersedes http://codereview.chromium.org/464072/show)
Also implement a couple comments in geolocaiton/ in follow up to http://codereview.chromium.org/604019 

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/600128
------------------------------------------------------------------------
r39214 | jorlow@chromium.org | 2010-02-17 12:29:45 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_prompt_modal_dialog_delegate.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   M /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   A /trunk/src/chrome/browser/views/database_open_info_view.cc (from /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc:39074)
   A /trunk/src/chrome/browser/views/database_open_info_view.h (from /trunk/src/chrome/browser/views/local_storage_set_item_info_view.h:39074)
   M /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement CONTENT_SETTING_ASK for database.  Also some cleanup of the dialog for local storage.

BUG=34628
TEST=none

Review URL: http://codereview.chromium.org/605028
------------------------------------------------------------------------
r39206 | jeremy@chromium.org | 2010-02-17 08:49:53 +0100 (Wed, 17 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

Translate: Move label parsing logic into common code.

* Add a string16 & Cocoa version of GetStringF().
* Move logic for parsing translate infobar label into translate_infobars_delegates.
* Make views variant of translate infobars use new code.

BUG=34466
TEST=Translate infobars should continue to workon Windows.

Review URL: http://codereview.chromium.org/597042
------------------------------------------------------------------------
r39189 | thestig@chromium.org | 2010-02-17 05:05:59 +0100 (Wed, 17 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: Only close kZygoteIdDescriptor when using the SUID sandbox.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/608020
------------------------------------------------------------------------
r39180 | chron@google.com | 2010-02-17 02:52:42 +0100 (Wed, 17 Feb 2010) | 14 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

We dump all of the originals_ metahandles to the dirty_metahandles index and then check later to see if they are actually dirty.  Arguably this is unnecessary, but I've been lead to believe (and my quick debugging has shown) that metahandles used in a WriteTransaction tend to get dirtied.  The majority of times the TakeSnapshot... loop executes now, the dirty_metahandles set is empty.There's also the benefit that it's pretty clear that the ScopedKernelLock, which is needed to look up an entry by metahandle, is held when we're iterating through the [possibly] dirty_metahandles in the TakeSnapshot... function.  This is arguably less true of the WriteTransaction deconstructor.  But if there's a different way to get the new dirty flag from an original  then that's probably the way to go.  I found out the hard way that checking the dirty flag of the original means nothing as I was leaking away metahandles.I added a short protected function to Directory that acts as a wrapper for the kernel_->dirty_metahandles->insert function.  It seemed like the thing to do to decouple it somewhat.  Plus we can check there to see if it's actually dirty if that's what we decide to do.We piggy-back on the transaction lock to save us thread-safety concerns in dealing with the dirty_metahandles set.

One more thing: if I'm screwing up any meta-stuff here please don't be afraid to share.  I'd hate to be writing too much, too little, or about the wrong stuff in these things :)
Added two unit tests to ensure that the WriteTransaction deconstructor and TakeSnapshotForSaveChanges function were cooperating.  One makes sure that all of the dirty metahandles show up again and the other makes sure that the non-dirty dirty_metahandles are disgarded.  I had to move some things out of the anonymous namespace in order for the FRIEND_TEST macro to work correctly.

Old patch: http://codereview.chromium.org/585007

BUG=19901
TEST=SyncableDirectoryTest.TakeSnapshotGetsAllDirtyHandlesTest, SyncableDirectoryTest.TakeSnapshotGetsOnlyDirtyHandlesTest
AUTHOR=Alex Gartrell (AlexGartrell@gmail.com)

chron submitting on original author's behalf.

Review URL: http://codereview.chromium.org/598006
------------------------------------------------------------------------
r39177 | dhg@chromium.org | 2010-02-17 02:21:59 +0100 (Wed, 17 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing the open dialog of the filebrowser
Review URL: http://codereview.chromium.org/606071
------------------------------------------------------------------------
r39174 | finnur@chromium.org | 2010-02-17 01:58:20 +0100 (Wed, 17 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h

Support tooltips in MenuItemView. Use that tooltip support in the 
Browser Action Container overflow menu.

BUG=35345
TEST=None

Review URL: http://codereview.chromium.org/611009
------------------------------------------------------------------------
r39173 | chocobo@chromium.org | 2010-02-17 01:49:50 +0100 (Wed, 17 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros/network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   A /trunk/src/chrome/browser/chromeos/options/ip_config_view.cc
   A /trunk/src/chrome/browser/chromeos/options/ip_config_view.h
   M /trunk/src/chrome/browser/chromeos/status/password_dialog_view.cc
   M /trunk/src/chrome/browser/chromeos/status/password_dialog_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Lookup ipconfig for networks.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/608016
------------------------------------------------------------------------
r39171 | dpolukhin@chromium.org | 2010-02-17 01:38:49 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Revert r39148 because it broke new tab for some kind of links (context menu "open in new tab" works).

BUG=33440
TEST=none

Review URL: http://codereview.chromium.org/606077
------------------------------------------------------------------------
r39165 | sky@chromium.org | 2010-02-17 01:10:59 +0100 (Wed, 17 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc

Lands http://codereview.chromium.org/596029 from Thiago Farina <thiago.farina@gmail.com>.

linux/mac: fix the location of delete menu item in bookmark context menu. 

By moving it right after the paste menu item. 

BUG=16760
TEST=see bug

Review URL: http://codereview.chromium.org/615001
------------------------------------------------------------------------
r39164 | jam@chromium.org | 2010-02-17 00:58:27 +0100 (Wed, 17 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard.cc
   M /trunk/src/app/clipboard/clipboard_unittest.cc
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/base/shared_memory_unittest.cc
   M /trunk/src/base/shared_memory_win.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/common/command_buffer_messages_internal.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/command_buffer_proxy.cc
   M /trunk/src/chrome/renderer/mock_printer.cc
   M /trunk/src/chrome/renderer/mock_printer.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_mac.mm
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/gpu/command_buffer/service/command_buffer_service.cc
   M /trunk/src/printing/emf_win.cc
   M /trunk/src/printing/emf_win.h
   M /trunk/src/printing/emf_win_unittest.cc
   M /trunk/src/printing/pdf_metafile_mac.cc
   M /trunk/src/printing/pdf_metafile_mac.h
   M /trunk/src/printing/pdf_metafile_mac_unittest.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.cc
   M /trunk/src/printing/pdf_ps_metafile_cairo.h
   M /trunk/src/printing/pdf_ps_metafile_cairo_unittest.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printed_document.h

Make SharedMemory use uint32 instead of size_t.  This removes the remaining size_t's from the IPC code.

Review URL: http://codereview.chromium.org/581001
------------------------------------------------------------------------
r39163 | mpcomplete@chromium.org | 2010-02-17 00:58:21 +0100 (Wed, 17 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc

Fix flaky ExtensionBrowserTest.IncognitoYesScript.

BUG=35885

Review URL: http://codereview.chromium.org/611002
------------------------------------------------------------------------
r39161 | dhollowa@chromium.org | 2010-02-17 00:53:47 +0100 (Wed, 17 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AutoFillAddressFormView.xib
   M /trunk/src/chrome/app/nibs/AutoFillCreditCardFormView.xib
   A /trunk/src/chrome/browser/autofill/autofill_text_field_mac.h
   A /trunk/src/chrome/browser/autofill/autofill_text_field_mac.mm
   M /trunk/src/chrome/browser/cocoa/disclosure_view_controller.h
   M /trunk/src/chrome/browser/cocoa/disclosure_view_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

Adding UI behavioral improvements for managing tabbing between form fields where the form is embedded within an NSScrollView. Also, when a disclosure view closes, its "content" should be disabled from the point-of-view of receiving tabbing focus. 

Nib file changes add the new |detailsView_| outlet to disclosure views. Also changed text fields to AutoFillTextFields to pick up auto-scrolling behavior. 

BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*

Review URL: http://codereview.chromium.org/606067
------------------------------------------------------------------------
r39160 | erg@google.com | 2010-02-17 00:51:24 +0100 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Content blocking icon visibility should change on tab switching.

BUG=35861
TEST=none

Review URL: http://codereview.chromium.org/612001
------------------------------------------------------------------------
r39159 | andybons@chromium.org | 2010-02-17 00:50:51 +0100 (Wed, 17 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Adds a NULL check for the RenderViewHost pointer within TabContents::ExecuteCode since render_view_host() can return NULL when a tab has crashed (or in some other edge cases).

BUG=34778
TEST=none
Review URL: http://codereview.chromium.org/612002
------------------------------------------------------------------------
r39158 | thakis@chromium.org | 2010-02-17 00:45:38 +0100 (Wed, 17 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/base/scoped_vector.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Mac: Content blocked icons.

Also rewrite how omnibox icons are handled, to make it less repetitive to add the content blocked icons. Remove a O(n^2) while I'm at it.

BUG=35594,34894
TEST=Go to a page with popups. "popups blocked" icon should appear in omnibox. It should have a tooltip, and a normal arrow cursor on mouse over.  Switching tabs should make it go away, coming back to the tab with the blocked popup should make it go back. Page actions should still work (tooltips, clicking, context menu, display). Security icon should still work. Install rss extension; the preview bubble should point to the right icon.

http://imgur.com/Yo0Ss

Review URL: http://codereview.chromium.org/600133
------------------------------------------------------------------------
r39155 | finnur@chromium.org | 2010-02-17 00:25:48 +0100 (Wed, 17 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   D /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   D /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   D /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome_tests.gypi

Reverting change: broke unit tests on chrome OS.

Revert 39143 - This change will include preferences as part of the usual startup sequence of the PSS that already includes bookmarks.  This is a temporary solution until we have a proper component to manage the startup and shutdown of multiple data types.

Review URL: http://codereview.chromium.org/601037

TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/611006
------------------------------------------------------------------------
r39151 | finnur@chromium.org | 2010-02-16 23:48:29 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc

Fix anchoring of the menu. It was flipped.

BUG=35568
TEST=None

Review URL: http://codereview.chromium.org/600155
------------------------------------------------------------------------
r39149 | derat@chromium.org | 2010-02-16 23:36:56 +0100 (Tue, 16 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

chromeos: Replace WM_FOCUS_WINDOW with _NET_ACTIVE_WINDOW.

The Chrome OS window manager previously gave Chrome two
ways to tell it to focus a window; I'm trying to cut that
down to one.  Note that I'm pretty sure that this is all
dead code in Chrome at this point -- the tab summary ("tab
overview" here) doesn't get displayed now that the window
manager is using the new overview mode.

BUG=chromium-os:1495
TEST=compiled

Review URL: http://codereview.chromium.org/598023
------------------------------------------------------------------------
r39148 | dpolukhin@chromium.org | 2010-02-16 23:36:06 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Remember initial size of new created tab content and use it when GTK widget size is not available.

BUG=33440
TEST=On Chrome OS duplicate tab context menu, new created tab content should be visible.

Review URL: http://codereview.chromium.org/606058
------------------------------------------------------------------------
r39144 | rohitrao@chromium.org | 2010-02-16 23:21:10 +0100 (Tue, 16 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

[Mac] Enable fullscreen

BUG=31638
TEST=Should be able to toggle fullscreen mode.
Review URL: http://codereview.chromium.org/567029
------------------------------------------------------------------------
r39143 | skrul@chromium.org | 2010-02-16 23:20:26 +0100 (Tue, 16 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/data_type_controller_mock.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   A /trunk/src/chrome/browser/sync/test_profile_sync_service.h
   M /trunk/src/chrome/chrome_tests.gypi

This change will include preferences as part of the usual startup sequence of the PSS that already includes bookmarks.  This is a temporary solution until we have a proper component to manage the startup and shutdown of multiple data types.

Review URL: http://codereview.chromium.org/601037
------------------------------------------------------------------------
r39142 | estade@chromium.org | 2010-02-16 23:06:14 +0100 (Tue, 16 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

GTK: visually de-emphasize the render view contents when a constrained window is showing.

To make this work consistently, I had to adjust the painting code in RenderWidgetHostViewGtk to always use gtk's painting path. This should have the added benefit of coalescing paints.

BUG=32399
TEST=see bug

Review URL: http://codereview.chromium.org/598052
------------------------------------------------------------------------
r39141 | rohitrao@chromium.org | 2010-02-16 22:56:18 +0100 (Tue, 16 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

[Mac] Prevent a fullscreen crash by destroying the GTMWindowSheetController in setFullscreen.

BUG=31638
TEST=Trigger a sheet (ex: http auth dialog) after going fullscreen.  Should not crash.
Review URL: http://codereview.chromium.org/606029
------------------------------------------------------------------------
r39139 | tim@chromium.org | 2010-02-16 22:40:05 +0100 (Tue, 16 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   A /trunk/src/chrome/browser/sync/engine/mock_model_safe_workers.h
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.cc
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   A /trunk/src/chrome/browser/sync/sessions/ordered_commit_set.cc
   A /trunk/src/chrome/browser/sync/sessions/ordered_commit_set.h
   A /trunk/src/chrome/browser/sync/sessions/ordered_commit_set_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/session_state.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller.cc
   M /trunk/src/chrome/browser/sync/sessions/status_controller.h
   M /trunk/src/chrome/browser/sync/sessions/status_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/sync/engine/syncer_command_test.h

For sync, make ProcessCommitResponseCommand handle commit entries one ModelSafeGroup at a time.

Enforce ModelSafeGroup restrictions in the StatusController by DCHECKing if out-of-bounds.
Move OrderedCommitSet to its own file.
Removed some unused error counters and ResetTransientState calls that were useless.

BUG=31911
TEST=ProcessCommitResponseTest, OrderedCommitSetTest

Review URL: http://codereview.chromium.org/604045
------------------------------------------------------------------------
r39135 | finnur@chromium.org | 2010-02-16 21:49:17 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc

Adding missing comment linking to bug.

BUG=35885
TEST=None
TBR=mpcomplete

------------------------------------------------------------------------
r39133 | pkasting@chromium.org | 2010-02-16 21:44:08 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc

Don't return CONTENT_SETTING_DEFAULT from GetContentSetting() under any conditions.

BUG=35775
TEST=Covered by unittests
TBR=jorlow
Review URL: http://codereview.chromium.org/609008
------------------------------------------------------------------------
r39131 | finnur@chromium.org | 2010-02-16 21:32:13 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc

Marking IncognitoYesScript as flaky.

BUG=35885
TEST=None
TBR=mpcomplete

------------------------------------------------------------------------
r39129 | finnur@chromium.org | 2010-02-16 21:15:00 +0100 (Tue, 16 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc

Disabling flaky ExtensionBrowserTest.IncognitoYesScript test.

BUG=35885
TEST=None
TBR=mpcomplete


Review URL: http://codereview.chromium.org/604065
------------------------------------------------------------------------
r39125 | dhg@chromium.org | 2010-02-16 21:00:33 +0100 (Tue, 16 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Adding a confirm before deleting a file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/600107
------------------------------------------------------------------------
r39106 | jcampan@chromium.org | 2010-02-16 19:46:56 +0100 (Tue, 16 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/language_state.cc
   M /trunk/src/chrome/browser/tab_contents/language_state.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h

Reloading a page would not show a translate infobar.
This CL fixes that bug.

BUG=35602, 35482
TEST=Navigate to a page in a foreign language. The tranlate infobar
     is shown. Reload the page, the infobar should be shown again.

Review URL: http://codereview.chromium.org/597065
------------------------------------------------------------------------
r39104 | erg@google.com | 2010-02-16 19:20:47 +0100 (Tue, 16 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

linux: Match the sections in Under the Hood tab with Windows version.

BUG=None
TEST=opens Options dialog, go to the Under the Hood tab, see if the order of the sections are the
same as in Windows.

Review URL: http://codereview.chromium.org/596113
Patch from thiago.farina@gmail.com.
------------------------------------------------------------------------
r39100 | pfeldman@chromium.org | 2010-02-16 18:35:08 +0100 (Tue, 16 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Add restriction to ViewHostMsg_GetRawCookies to block access from untrusted renderers.
BUG=35575

Review URL: http://codereview.chromium.org/600137
------------------------------------------------------------------------
r39096 | stuartmorgan@chromium.org | 2010-02-16 17:11:00 +0100 (Tue, 16 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/third_party/npapi/bindings/npapi.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Fix some issues with compiling Mac plugin code with deprecation defines set

Makes the code compile under NP_NO_QUICKDRAW and NP_NO_CARBON (modulo some gyp stuff that 64-bit builds will need to prevent compiling the shim library), and makes the tweaking of DYLD_INSERT_LIBRARIES 32-bit only.
Also removes a QuickDraw variable left over from an earlier version of the QuickDraw support.

BUG=none
TEST=none; supports future 64-bit compilation

Review URL: http://codereview.chromium.org/597053
------------------------------------------------------------------------
r39092 | jochen@chromium.org | 2010-02-16 15:17:14 +0100 (Tue, 16 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc

Change hardcoded "chrome" scheme to constant.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/604030
Patch from Bernhard Bauer <bauerb@google.com>.
------------------------------------------------------------------------
r39091 | joth@chromium.org | 2010-02-16 14:56:20 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h

linux: fix shared build

provide an empty d'tor for the abstract base class, so sub-classes can be instantiated.


Review URL: http://codereview.chromium.org/606059
------------------------------------------------------------------------
r39088 | evan@chromium.org | 2010-02-16 11:24:13 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_arbitrator.h

linux: fix shared build

Without this, the linker wants the vtable for GeolocationArbitrator
to exist, despite it never having a definition.

Review URL: http://codereview.chromium.org/606052
------------------------------------------------------------------------
r39085 | phajdan.jr@chromium.org | 2010-02-16 11:12:12 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc

[Linux] Add better error reporting for creating application shortcuts.

TEST=none
BUG=30785

Review URL: http://codereview.chromium.org/607001
------------------------------------------------------------------------
r39077 | twiz@chromium.org | 2010-02-16 03:24:18 +0100 (Tue, 16 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h
   A /trunk/src/chrome/browser/views/frame/browser_bubble_host.cc
   A /trunk/src/chrome/browser/views/frame/browser_bubble_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_activex.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/chrome_frame_plugin.h

Clone of issue 600130. (http://codereview.chromium.org/600130)

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/593111
------------------------------------------------------------------------
r39074 | evan@chromium.org | 2010-02-15 17:59:41 +0100 (Mon, 15 Feb 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/printing/print_job_manager_linux.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   D /trunk/src/chrome/browser/printing/print_view_manager_linux.cc
   M /trunk/src/chrome/chrome_browser.gypi

linux: readjust some stubbed files

This removes a bunch of NOTIMPLEMENTEDs and stub files,
moving them to a different place.

TEST=it compiles

Review URL: http://codereview.chromium.org/594057
------------------------------------------------------------------------
r39067 | joth@chromium.org | 2010-02-15 16:15:22 +0100 (Mon, 15 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/geolocation/access_token_store.cc
   A /trunk/src/chrome/browser/geolocation/access_token_store.h
   M /trunk/src/chrome/browser/geolocation/geoposition.h
   A /trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   A /trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add support for top level geolocation arbitrator, and access token persistence (via local state prefs)


BUG=11246
TEST=unit_tests.exe --gtest_filer=Geoloc* 

Review URL: http://codereview.chromium.org/603040
------------------------------------------------------------------------
r39065 | cbentzel@chromium.org | 2010-02-15 15:25:50 +0100 (Mon, 15 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/http/http_auth.cc
   M /trunk/src/net/http/http_auth.h
   M /trunk/src/net/http/http_auth_cache_unittest.cc
   M /trunk/src/net/http/http_auth_handler.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/http/http_auth_handler_basic.cc
   M /trunk/src/net/http/http_auth_handler_basic.h
   M /trunk/src/net/http/http_auth_handler_basic_unittest.cc
   M /trunk/src/net/http/http_auth_handler_digest.cc
   M /trunk/src/net/http/http_auth_handler_digest.h
   M /trunk/src/net/http/http_auth_handler_digest_unittest.cc
   A /trunk/src/net/http/http_auth_handler_factory.cc
   A /trunk/src/net/http/http_auth_handler_factory.h
   A /trunk/src/net/http/http_auth_handler_factory_unittest.cc
   A /trunk/src/net/http/http_auth_handler_negotiate.cc
   M /trunk/src/net/http/http_auth_handler_negotiate.h
   M /trunk/src/net/http/http_auth_handler_negotiate_posix.cc
   M /trunk/src/net/http/http_auth_handler_negotiate_win.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.h
   M /trunk/src/net/http/http_auth_sspi_win.cc
   M /trunk/src/net/http/http_auth_sspi_win.h
   M /trunk/src/net/http/http_auth_unittest.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/socket_stream/socket_stream.h
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_stream_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Added factories for HttpAuthHandler.

The driving rationale for this change was to prevent choosing an AuthHandler when it
is not supported on the system due to a missing runtime component (such as not being
able to locate a gssapi shared library when seeing a Negotiate scheme).

It also has the advantage (currently unused) of determining some per-auth-scheme properties
only the first time that a challenge for that scheme is seen (such as maximum token length for
the SSPI implementation of NTLM).

Finally, it may make unit tests easier to generate since the factory can be easily mocked.

BUG=34795
TEST=New unit test for HttpAuthHandlerDispatchFactory.

Review URL: http://codereview.chromium.org/582007
------------------------------------------------------------------------
r39064 | nkostylev@google.com | 2010-02-15 15:07:08 +0100 (Mon, 15 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   A /trunk/src/chrome/browser/chromeos/network_list.cc
   A /trunk/src/chrome/browser/chromeos/network_list.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor network selection screen. Add Ethernet network to the list.

BUG=35016
TEST=With --login-manager=network screen should be shown. Ethernet and Wifi networks are shown and could be selected.

Review URL: http://codereview.chromium.org/597046
------------------------------------------------------------------------
r39046 | satorux@chromium.org | 2010-02-15 07:45:24 +0100 (Mon, 15 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Fix a bug that where the horizontal candidate window was not rendered properly.

This is a non-deterministic issue. After some investigation, we learned that
the following callback functions are called before the horizontal candidate
window is rendered.

  OnUpdateLookupTable()
  OnUpdateAuxiliaryText()
  OnSetCursorLocation()

As shown, OnSetCursorLocation() is the last function to be called.
We should request a resize and a paint in OnSetCursorLocation() to
to ensure that the candidate window is always rendered properly.

TEST=manually
BUG=crosbug.com/1560

Review URL: http://codereview.chromium.org/594046
------------------------------------------------------------------------
r39044 | satorux@chromium.org | 2010-02-15 07:39:16 +0100 (Mon, 15 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc

Get rid of use of deprecated members in ImeLookupTable.

Namely:

- current_page_index
- cursor_row_index
- num_candidates_in_current_page
- num_pages (not used in candidate_window.cc, but this will also be deleted in libcros)

These members will be deleted from libcros in a separate CL.

TEST=manually
BUG=none

Review URL: http://codereview.chromium.org/606012
------------------------------------------------------------------------
r39038 | craig.schlenter@chromium.org | 2010-02-15 05:41:15 +0100 (Mon, 15 Feb 2010) | 13 lines
Changed paths:
   D /trunk/src/chrome/browser/printing/print_job_linux.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/printing/printing_context_cairo.cc

Linux: fix shared build.

The demise of temp scaffolding has left the shared build in
an unhappy state where the compiler complains about vtable
issues with PrintJob because only half the class is implemented.

Fix this by compiling some more printing files on linux and
stubbing out AskUserForSettings.

BUG=none
TEST=linux shared build compiles. Other builds still ok too.

Review URL: http://codereview.chromium.org/598066
------------------------------------------------------------------------
r39036 | tony@chromium.org | 2010-02-15 02:27:06 +0100 (Mon, 15 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Make popups opened from app mode windows use the system frame.

BUG=23368

Review URL: http://codereview.chromium.org/596081
------------------------------------------------------------------------
r39035 | ananta@chromium.org | 2010-02-15 01:47:25 +0100 (Mon, 15 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

Fix a Chrome crash caused in a ChromeFrame instance in the automation job used for routing network requests
to the host. The crash happens while dereferencing a NULL AutomationResourceMessageFilter pointer in a pending
job.

We already NULL check the pointer in the if block above. Moving this check at the top.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=35728

Bug=35728

Review URL: http://codereview.chromium.org/605022
------------------------------------------------------------------------
r39018 | jorlow@chromium.org | 2010-02-13 19:18:41 +0100 (Sat, 13 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h

Only ask the user on setItems whether they want to allow dom storage.
Also add some plumbing for popping up an icon when it's blocked.

TEST=Turn on the ask content setting for a domain and set local storage and then clear it.  Only the set should prompt you.
BUG=34668

Review URL: http://codereview.chromium.org/600078
------------------------------------------------------------------------
r39003 | finnur@chromium.org | 2010-02-13 06:30:09 +0100 (Sat, 13 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc

Fix problem with test on Linux Views Toolkit.

The extension was not initializing the being_upgraded_
value, causing it to randomly not increase the size
of the browser action container.

BUG=35593
TEST=This is enabling a test

Review URL: http://codereview.chromium.org/593100
------------------------------------------------------------------------
r39002 | dhollowa@chromium.org | 2010-02-13 03:58:20 +0100 (Sat, 13 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_address_model_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_common_unittest.cc
   A /trunk/src/chrome/browser/autofill/autofill_common_unittest.h
   M /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   A /trunk/src/chrome/browser/autofill/autofill_profile_unittest.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   A /trunk/src/chrome/browser/autofill/credit_card_unittest.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Adding summary string generation for the AutoFill feature.

Includes a small modification to the generated resources, needed additional whitespace
in credit card summary.  Added summary generation to autofill_profile.* and modified
summary generation in credit_card.* to match.  credit_card.* modifications were largely
to use string16 instead of std::wstring.

Factored out common unit testing utilities into autofill_common_unittest.*, and added
unit tests for summary string generation for credit_card.* and autofill_profile.*.

BUG=35551
TEST=unit_tests --gtest_filter=AutoFillProfileTest.*:CreditCardTest.*


Review URL: http://codereview.chromium.org/606031
------------------------------------------------------------------------
r39001 | estade@chromium.org | 2010-02-13 03:40:01 +0100 (Sat, 13 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Enable BookmarkContextMenuControllerTest (browser/views/bookmark_context_menu_controller_unittest), which I added recently but failed to enable.

The rename is to match the file name and avoid name conflicts with BookmarkContextMenuTest (in browser/views).

Also mac apparently doesn't like having a member var that has a type defined in an anonymous namespace.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/600106
------------------------------------------------------------------------
r39000 | mattm@chromium.org | 2010-02-13 03:39:48 +0100 (Sat, 13 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/gtk/certificate_manager.cc
   A /trunk/src/chrome/browser/gtk/certificate_manager.h
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.h
   M /trunk/src/chrome/chrome_browser.gypi

Linux: Certificate Manager skeleton.

Not actually hooked up to the options dialog since it doesn't do anything useful yet.

BUG=19991
TEST=none

Review URL: http://codereview.chromium.org/593076
------------------------------------------------------------------------
r38999 | estade@chromium.org | 2010-02-13 03:39:33 +0100 (Sat, 13 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h

GTK: let call stack unwind before hiding browser action popup.

The crash was in RenderViewHost::OnMsgShowView:

    // This line ends up destroying |this|
    view->ShowCreatedWindow(route_id, disposition, initial_pos, user_gesture);
    // This line then causes a segfault
    Send(new ViewMsg_Move_ACK(route_id));

Not sure why this wasn't a problem with the other extension I was testing with.

BUG=35577
TEST=see bug

Review URL: http://codereview.chromium.org/606037
------------------------------------------------------------------------
r38995 | jcampan@chromium.org | 2010-02-13 03:03:41 +0100 (Sat, 13 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/browser/translate/translate_manager_unittest.cc

Fix the TranslateManager and unit-tests.
There was a bug that was initialy turning on translate all the time.
When fixed it made the unit-tests fail, revealing another bug.
The test was calling a virtual method in its constructor, which was bad and not turning on translate for the tests.

BUG=None
TEST=UI tests, browser tests, unit-tests should pass.

Review URL: http://codereview.chromium.org/601069
------------------------------------------------------------------------
r38991 | oshima@chromium.org | 2010-02-13 02:08:28 +0100 (Sat, 13 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Layout of the Navigation entry's border and its autocomplete popup was broken in RTL.
 This fixes the issue.

BUG=none
TEST=manual: start chromeos build of chrome in RTL. ($LAGNUAGE=he chrome) switch to compact nav bar mode,
    open main menu and confirm the layout is correct.

Review URL: http://codereview.chromium.org/593090
------------------------------------------------------------------------
r38985 | jcampan@chromium.org | 2010-02-13 01:16:17 +0100 (Sat, 13 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc

Revert my previous fix for UI tests, it breaks the unit-tests.

BUG=None
TEST=None
TBR=kuan

Review URL: http://codereview.chromium.org/606040
------------------------------------------------------------------------
r38984 | darin@chromium.org | 2010-02-13 00:55:47 +0100 (Sat, 13 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/cookie_info_view.cc
   M /trunk/src/chrome/browser/views/cookie_info_view.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h

Avoid showing the user a garbage path attribute when the cookie doesn't have an
explicit path set.  This CL also ensures that we set the expiry info properly.

This means using CanonPath and CanonExpiration from cookie_monster.cc.  Instead
of exposing those methods, I just expose a CanonicalCookie constructor that
takes a ParsedCookie.

R=pkasting
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/597031
------------------------------------------------------------------------
r38983 | jcampan@chromium.org | 2010-02-13 00:53:40 +0100 (Sat, 13 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc

Fix the UI tests.
The translate manager enabling code was incorrect.

BUG=None
TEST=UI tests should pass.
TBR=kuan

Review URL: http://codereview.chromium.org/604042
------------------------------------------------------------------------
r38980 | oshima@chromium.org | 2010-02-13 00:32:42 +0100 (Sat, 13 Feb 2010) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   D /trunk/src/chrome/browser/chromeos/browser_view.cc
   D /trunk/src/chrome/browser/chromeos/browser_view.h
   A /trunk/src/chrome/browser/chromeos/frame
   A /trunk/src/chrome/browser/chromeos/frame/browser_extenders.cc (from /trunk/src/chrome/browser/chromeos/browser_extenders.cc:38979)
   A /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.cc
   A /trunk/src/chrome/browser/chromeos/frame/browser_frame_chromeos.h
   A /trunk/src/chrome/browser/chromeos/frame/browser_view.cc (from /trunk/src/chrome/browser/chromeos/browser_view.cc:38979)
   A /trunk/src/chrome/browser/chromeos/frame/browser_view.h (from /trunk/src/chrome/browser/chromeos/browser_view.h:38979)
   A /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.cc (from /trunk/src/chrome/browser/chromeos/panel_browser_view.cc:38979)
   A /trunk/src/chrome/browser/chromeos/frame/panel_browser_view.h (from /trunk/src/chrome/browser/chromeos/panel_browser_view.h:38979)
   A /trunk/src/chrome/browser/chromeos/frame/panel_controller.cc (from /trunk/src/chrome/browser/chromeos/panel_controller.cc:38979)
   A /trunk/src/chrome/browser/chromeos/frame/panel_controller.h (from /trunk/src/chrome/browser/chromeos/panel_controller.h:38979)
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   D /trunk/src/chrome/browser/chromeos/panel_browser_view.cc
   D /trunk/src/chrome/browser/chromeos/panel_browser_view.h
   D /trunk/src/chrome/browser/chromeos/panel_controller.cc
   D /trunk/src/chrome/browser/chromeos/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Moved chromeos's frame classes under chromeos/frame.
 - Made Init in BrowserFrameGtk virtual so that chromeos can use it's own frame view.
 - Introduced BrowserFrameChromeos (which is currently empty)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/606014
------------------------------------------------------------------------
r38979 | erg@google.com | 2010-02-13 00:26:41 +0100 (Sat, 13 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.h

Themes: Fix some of the documentation for BrowserThemePack.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/604039
------------------------------------------------------------------------
r38975 | nick@chromium.org | 2010-02-13 00:19:40 +0100 (Sat, 13 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h

Per-datatype filtering of change notifications.

Review URL: http://codereview.chromium.org/606023
------------------------------------------------------------------------
r38972 | oshima@chromium.org | 2010-02-13 00:15:16 +0100 (Sat, 13 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Use BrowserFrame::TitleFont in OpaqueBrowserFrameView as well.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/605014
------------------------------------------------------------------------
r38971 | dpolukhin@chromium.org | 2010-02-13 00:14:12 +0100 (Sat, 13 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h

Set initial focus to password if we have user names on login screen.

Review URL: http://codereview.chromium.org/596091
------------------------------------------------------------------------
r38970 | oshima@chromium.org | 2010-02-13 00:11:42 +0100 (Sat, 13 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h

Fix the problem where accelerator key was not working in compact navbar.
 * Explicitly set the focus ownership to FocusManager when AutocompleteEditView gets focus.
 * Close the compact location bar on ESC key press, or when new page is opened.
 * Apply the same fix to main menu's AutocompleteEditView
 * Adjust layout of compact location bar.

BUG=32853
TEST=none

Review URL: http://codereview.chromium.org/593071
------------------------------------------------------------------------
r38969 | xiyuan@chromium.org | 2010-02-13 00:08:20 +0100 (Sat, 13 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc

Handle DEVICE_REMOVED in the same way as DISK_REMOVED

BUG=none
TEST=On ChromeOS, insert USB stick and pull it out before it gets mounted. The "scanning device" pop up should go away automatically.

Review URL: http://codereview.chromium.org/603048
------------------------------------------------------------------------
r38967 | mpcomplete@chromium.org | 2010-02-13 00:06:55 +0100 (Sat, 13 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc

Modify the incognito content script test to verify that a crash no longer
occurs with multiple extensions installed with varying incognito enabledness.

See r38933 for the actual fix.

Review URL: http://codereview.chromium.org/596101
------------------------------------------------------------------------
r38962 | ananta@chromium.org | 2010-02-12 22:55:48 +0100 (Fri, 12 Feb 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h

Fix an IE7 crash caused when ChromeFrame would pass keystrokes to be processed as accelerators. The crash
occured in the call to IBrowserService2::v_MayTranslateAccelerator which takes in a MSG as a parameter.
This message contains the hwnd of the ChromeRenderWidgetHost. Eventually this method tries to DispatchMessage
this message to the same hwnd, which causes a crash possibly because this window is in a different process.

Fix is to switch the hwnd to the parent of the ChromeFrame ActiveX.

The other fix is to send over all keystrokes from the ExternalTabContainer instead of filtering them. With
this fix in BackSpace works correctly in IE7, i.e. it goes back in history. However the other keystrokes like
Shift Backspace, etc don't work. They are probably processed by mshtml. It appears that we may have to 
prcess these accelerators in our active document and do the right thing there. That in a separate CL.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=35355

Bug=35355

Review URL: http://codereview.chromium.org/603041
------------------------------------------------------------------------
r38961 | jcampan@chromium.org | 2010-02-12 22:53:55 +0100 (Fri, 12 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   A /trunk/src/chrome/browser/tab_contents/language_state.cc
   A /trunk/src/chrome/browser/tab_contents/language_state.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h
   A /trunk/src/chrome/browser/translate/translate_manager_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implements the auto-translate on click: if you have translated
a page and are navigating to a new page in the same language by
clicking a link, the new page is automatically translated.
In order to do that I moved the language state from the navigation
entry to some dedicated class that each TabContents owns.
Also added some basic unit-testing for good measure.

BUG=35477
TEST=See bug steps. Run unit-tests.
 
Review URL: http://codereview.chromium.org/596092
------------------------------------------------------------------------
r38959 | finnur@chromium.org | 2010-02-12 22:44:45 +0100 (Fri, 12 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_test_util.h
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   A /trunk/src/chrome/browser/views/browser_actions_container_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Browser Action Container should not shrink when visible extension is disabled.

We now calculate the visible actions before removing them from the vector
so we can maintain the same number after deletion occurs.

Also added unit tests and fixed a bug in GetTooltip where we were hard-coding
the index to be 0.

BUG=35349
TEST=Covered by new unit test.

Review URL: http://codereview.chromium.org/606008
------------------------------------------------------------------------
r38958 | mark@chromium.org | 2010-02-12 22:40:52 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_button.h

10.6 SDK compatibility fix for DownloadItemButton following r37621.

DownloadItemButton should implement the NSMenuDelegate protocol.

BUG=35569
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/606028
------------------------------------------------------------------------
r38957 | mark@chromium.org | 2010-02-12 22:40:36 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/base/cocoa_protocols_mac.h
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

10.6 SDK compatibility fix for SelectFileDialogBridge following r37693.

SelectFileDialogBridge should implement the NSOpenSavePanelDelegate protocol.

BUG=35569
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/601060
------------------------------------------------------------------------
r38956 | mark@chromium.org | 2010-02-12 22:40:30 +0100 (Fri, 12 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/dock_icon.mm

10.6 SDK compatibility fix for DockIcon following r37698.

See r26348, "Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize
conversions": The SDK has gotten stupider in 10.6, and has conspired with the
compiler, which now thinks that when the receiver is held in a scoped_nsobject,
NSColor and NSSize arguments should be converted to their CG cousins.

BUG=35569
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/606027
------------------------------------------------------------------------
r38955 | mark@chromium.org | 2010-02-12 22:40:25 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h

10.6 SDK compatibility fix for BookmarkMenuCocoaController following r37056.

BookmarkMenuCocoaController should implement the NSMenuDelegate protocol.

BUG=35569
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/603045
------------------------------------------------------------------------
r38954 | mark@chromium.org | 2010-02-12 22:40:19 +0100 (Fri, 12 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm

10.6 SDK compatibility fix for BrowserActionCell following r38278.

See r26348, "Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize
conversions": The SDK has gotten stupider in 10.6, and has conspired with the
compiler, which now thinks that when the receiver is held in a scoped_nsobject,
NSColor and NSSize arguments should be converted to their CG cousins.

BUG=35569
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/604038
------------------------------------------------------------------------
r38953 | erg@chromium.org | 2010-02-12 22:39:56 +0100 (Fri, 12 Feb 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   D /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.h
   A /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc (from /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc:38952)
   A /trunk/src/chrome/browser/gtk/options/passwords_exceptions_page_gtk.h (from /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.h:38952)
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: Rename ambiguous "exceptions_page_gtk.cc" before making the content exceptions page.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/597051
------------------------------------------------------------------------
r38952 | jorlow@chromium.org | 2010-02-12 22:38:56 +0100 (Fri, 12 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_views.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h
   A /trunk/src/chrome/browser/views/local_storage_set_item_info_view.cc (from /trunk/src/chrome/browser/views/local_storage_info_view.cc:38896)
   A /trunk/src/chrome/browser/views/local_storage_set_item_info_view.h (from /trunk/src/chrome/browser/views/local_storage_info_view.h:38896)
   M /trunk/src/chrome/chrome_browser.gypi

Make the setItem CONTENT_SETTING_ASK dialog more useful by showing the actual key and value.  Unfortunately, we're going to have to abuse cookie strings for 4.1  Once this goes in, I'll add new strings for the actual fields.

This also cleans up the code some.

TEST=Instead of size/modified information you'll see "name" and "content" in the dialog that comes up when asking whether to allow local storage.
BUG=none

Review URL: http://codereview.chromium.org/597061
------------------------------------------------------------------------
r38951 | willchan@chromium.org | 2010-02-12 22:38:37 +0100 (Fri, 12 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/observer_list_unittest.cc
   M /trunk/src/base/task.h
   M /trunk/src/base/tracked_objects.cc
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc

Fix up some style guide violations wrt aligning function arguments.

Review URL: http://codereview.chromium.org/593084
------------------------------------------------------------------------
r38948 | pkasting@chromium.org | 2010-02-12 22:28:01 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Misc. cleanups noticed while working on another change.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/601059
------------------------------------------------------------------------
r38942 | nick@chromium.org | 2010-02-12 22:10:20 +0100 (Fri, 12 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc

Various model associator fixes from preferences bringup.

Use JSONReader to extract simple values (the previous interface
would only parse dict or list values).

ReadNode should be Init()'ed only once.

Add better handling of deletion; we haven't seen it happen yet, but
I found an issue by inspection and added a TODO suggesting how we
might make it work correctly.

BUG=32409
TEST=manual testing using a hacked up server running locally

Review URL: http://codereview.chromium.org/600102
------------------------------------------------------------------------
r38939 | darin@chromium.org | 2010-02-12 21:58:49 +0100 (Fri, 12 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Change ViewHostMsg_SetCookie to be routed so we can show the blocked cookie
notification.

We get the RenderView identifier by looking at the current WebFrame.
This will need to be changed since we do not always have a current
WebFrame (e.g., when processing a <META http-equiv="set-cookie">).
I'd like to proceed with this temporary fix for now since I think it
is actually good enough for a 4.1 release.  I'll work to make the
necessary webkit changes to expose the WebFrame properly in parallel.

R=jorlow
BUG=34573
TEST=none

Review URL: http://codereview.chromium.org/605003
------------------------------------------------------------------------
r38935 | pam@chromium.org | 2010-02-12 21:44:46 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/resources/about_version.html

Add command line to about:version.

BUG=18577
TEST=open about:version, see full command line (executable and switches)
Review URL: http://codereview.chromium.org/603017
------------------------------------------------------------------------
r38934 | dhg@chromium.org | 2010-02-12 21:43:55 +0100 (Fri, 12 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/filebrowse_menu.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Adding deletion to filebrowser, adding pause/resume to shelf.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/597055
------------------------------------------------------------------------
r38927 | twiz@chromium.org | 2010-02-12 21:27:10 +0100 (Fri, 12 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/app/win/window_impl.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   M /trunk/src/views/controls/native/native_view_host.cc

Clone of issue 577015.

See http://codereview.chromium.org/577015 for the review status of this CL.

BUG=None
TEST=ExtensionApiTest.Popup

Review URL: http://codereview.chromium.org/600101
------------------------------------------------------------------------
r38925 | jcampan@chromium.org | 2010-02-12 21:02:02 +0100 (Fri, 12 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.h
   M /trunk/src/chrome/browser/renderer_host/translation_service_unittest.cc

Making the parsing of the response received from the translate server
deal with more bad results.
The server can send unmatched and duplicated tags. It's paramount for
us to get as many text chunks out as we sent in.
This is now we are trying to do when parsing the response.

BUG=34854
TEST=Run the unit-tests. Reproduce steps in bug.

Review URL: http://codereview.chromium.org/603037
------------------------------------------------------------------------
r38924 | pkasting@chromium.org | 2010-02-12 21:00:42 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/linux_close_glen.png
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

Remove "Glen" close button joke now that it's had a long and happy life.

String removal coming in a future patch.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/600075
------------------------------------------------------------------------
r38922 | avi@chromium.org | 2010-02-12 20:55:19 +0100 (Fri, 12 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Resizing is good as we do it today; alter the comment and close a bug.

BUG=http://crbug.com/8285
TEST=comment change; no behavior change

Review URL: http://codereview.chromium.org/606026
------------------------------------------------------------------------
r38921 | thomasvl@chromium.org | 2010-02-12 20:52:32 +0100 (Fri, 12 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/chrome/browser/cocoa/GTMTheme.h
   A /trunk/src/chrome/browser/cocoa/GTMTheme.m
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_theme_provider_init.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] GTMTheme is going to die!
- DEPS roll to pick up new GTM without GTMTheme
- GTMTheme within chrome until someone gets the cycles to completely remove it and use the core chrome theme objects
- Update all the includes of GTMTheme for the new copy.

BUG=35554
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/596095
------------------------------------------------------------------------
r38920 | timurrrr@chromium.org | 2010-02-12 20:52:29 +0100 (Fri, 12 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc

Annotate test-only data race as benign
BUG=35560
Review URL: http://codereview.chromium.org/606022
------------------------------------------------------------------------
r38919 | kuan@chromium.org | 2010-02-12 20:51:34 +0100 (Fri, 12 Feb 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc

first part of fix for dual translate infobars

bug is caused by 2 problems when happen during reload of a translated page:
1) infobar container was removing the wrong infobar, which this cl fixes.
2) notification NAV_ENTRY_COMMITTED is being processed by translate-manager first, then tab-contents
   - translate manager would remove all infobars, then add before-translate infobar
   - tab contents then removes expired infobars -- since a reload renders an infobar irrelevant, the before-translate that just got added during the same notification is removed
   - b4 this cl, because of the bug in infobar container, dual infobars were displayed
   - with this cl, removing the correct infobar means no translate infobar is shown, which is also wrong.

BUG=35482
TEST=none for now.

Review URL: http://codereview.chromium.org/604028
------------------------------------------------------------------------
r38914 | pkasting@chromium.org | 2010-02-12 20:43:32 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove --disable-images and --disable-javascript now that we have UI that does that.

This doesn't remove --disable-plugins or --disable-popup-blocking as various different test executables pass those and I'm not sure there's a way for them to set default pref values instead.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/593064
------------------------------------------------------------------------
r38911 | dumi@chromium.org | 2010-02-12 20:24:04 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/db_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/webkit/database/database_connections.cc
   M /trunk/src/webkit/database/database_connections.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h
   M /trunk/src/webkit/database/database_tracker_unittest.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.h

Ask renderers to immediately close all DB handles to a database file
when the file needs to be deleted.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/594002
------------------------------------------------------------------------
r38909 | oshima@chromium.org | 2010-02-12 20:06:20 +0100 (Fri, 12 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h

Make sure the main menu is positioned right.
 This is necessary because the chromeos window manager moves the window off the screen when  in overview mode, and also
 WM resize/relocate the chrome window when a panel is attached to the side.
 Adjust the button layout so that back/forward button and main menu align nicely.

BUG=none
TEST=manual: open main menu, then preess F12 to switch to overview mode. quit the overview mode,
 and main menu should work.

Review URL: http://codereview.chromium.org/600086
------------------------------------------------------------------------
r38906 | erg@chromium.org | 2010-02-12 19:24:07 +0100 (Fri, 12 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

GTK: Make the cookies view modal to its parent since its parent will always be modal.

BUG=35461
TEST=none

Review URL: http://codereview.chromium.org/600089
------------------------------------------------------------------------
r38903 | willchan@chromium.org | 2010-02-12 19:04:27 +0100 (Fri, 12 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Pass NetworkChangeNotifier to ProxyService so it gets network change notifications.
BUG=12293

Review URL: http://codereview.chromium.org/596074
------------------------------------------------------------------------
r38902 | pkasting@chromium.org | 2010-02-12 19:03:41 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Use TabContents::GetDefaultTitle() everywhere we need a title for an untitled tab/page.  This will let us remove a couple of duplicate strings.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/604021
------------------------------------------------------------------------
r38901 | pinkerton@chromium.org | 2010-02-12 18:50:21 +0100 (Fri, 12 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm

Handle updating the menu in the case where all the entries get removed from the tab restore service. Increase the # of recently closed items to 5.
BUG=35290
TEST=per bug, history menu should work as before.
Review URL: http://codereview.chromium.org/596086
------------------------------------------------------------------------
r38899 | viettrungluu@chromium.org | 2010-02-12 17:50:25 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/browser_theme_provider_init.h
   A /trunk/src/chrome/browser/cocoa/browser_theme_provider_init.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/browser_window_controller_private.h
   A /trunk/src/chrome/browser/cocoa/browser_window_controller_private.mm
   M /trunk/src/chrome/chrome_browser.gypi

Mac: Part 1 of browser_window_controller.* re-organization.

BUG=35543
TEST=everything still builds and works
Review URL: http://codereview.chromium.org/606002
------------------------------------------------------------------------
r38898 | evan@chromium.org | 2010-02-12 17:42:43 +0100 (Fri, 12 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_version.html

Remove pixel size from about:version.

It was needless, and causes ugly wrapping if you don't have the
exact fonts specified.

Review URL: http://codereview.chromium.org/601057
------------------------------------------------------------------------
r38892 | pinkerton@chromium.org | 2010-02-12 15:51:35 +0100 (Fri, 12 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/app/gfx/font_mac.mm
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Remove TODOs or add bug numbers to TODOs
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/606016
------------------------------------------------------------------------
r38891 | pinkerton@chromium.org | 2010-02-12 15:02:15 +0100 (Fri, 12 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Remove outdated comments, add reference to design doc.
BUG=34659
TEST=none
Review URL: http://codereview.chromium.org/600080
------------------------------------------------------------------------
r38890 | joth@chromium.org | 2010-02-12 13:52:04 +0100 (Fri, 12 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc (from /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc:38486)
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h
   M /trunk/src/chrome/chrome_tests.gypi

Refactor the state-machine & threading out of the windows wifi provider into a cross platform base class
This will make the linux & mac impementations much simpler

BUG=11246
TEST=Aded wifi_data_provider_common_unittest.cc. Run: unit_tests.exe --gtest_filer=Geoloc*


Review URL: http://codereview.chromium.org/604019
------------------------------------------------------------------------
r38877 | thakis@chromium.org | 2010-02-12 07:33:49 +0100 (Fri, 12 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Send "content blocked" ipc messages more reliably.

I believe that the bug happened in this sequence of events:

1.) JS gets blocked on the web page, icon appears. The renderer (correctly) thinks js is blocked.
2.) User hits "reload"
3.) RenderView::didCommitProvisionalLoad() calls RenderView::UpdateURL() which sends ViewHostMsg_FrameNavigate to the browser which clears the content settings images in the location bar
4.) RenderView::allowScripts() gets called during page loading. The renderer still thinks that js is blocked and hence doesn't notify the browser.
5.) RenderView::didReceiveResponse() clears the content blocked flags (too late)

This CL moves the content blocked flags into navigationstate, which should prevent this "race" because there's one new navigationstate per page.

BUG=35011
TEST=See bug.

Review URL: http://codereview.chromium.org/596039
------------------------------------------------------------------------
r38875 | suzhe@chromium.org | 2010-02-12 05:52:35 +0100 (Fri, 12 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

[Linux] Handles Entery key correctly in find bar.

BUG=35219
TEST=See bug report.

Review URL: http://codereview.chromium.org/600066
------------------------------------------------------------------------
r38873 | dhollowa@chromium.org | 2010-02-12 05:24:08 +0100 (Fri, 12 Feb 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/nibs/AutoFillAddressFormView.xib
   A /trunk/src/chrome/app/nibs/AutoFillCreditCardFormView.xib
   A /trunk/src/chrome/app/nibs/AutoFillDialog.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/browser/autofill/autofill_address_model_mac.h
   A /trunk/src/chrome/browser/autofill/autofill_address_model_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.h
   A /trunk/src/chrome/browser/autofill/autofill_address_view_controller_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.h
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_model_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.h
   A /trunk/src/chrome/browser/autofill/autofill_credit_card_view_controller_mac.mm
   D /trunk/src/chrome/browser/autofill/autofill_dialog.cc
   A /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.h
   A /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac.mm
   A /trunk/src/chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm
   A /trunk/src/chrome/browser/autofill/autofill_dialog_mac.mm
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   A /trunk/src/chrome/browser/cocoa/disclosure_view_controller.h
   A /trunk/src/chrome/browser/cocoa/disclosure_view_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/section_separator_view.h
   A /trunk/src/chrome/browser/cocoa/section_separator_view.mm
   A /trunk/src/chrome/browser/cocoa/vertical_layout_view.h
   A /trunk/src/chrome/browser/cocoa/vertical_layout_view.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Autofill dialog for the Mac.  This is UI only at this point.  The UI is not hooked up to the back end yet.  The UI demonstrates manipulation of one address and one credit card record.  Eventually buttons will be added to add and remove additional records.  The additions in this CL are:
  - Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
  - The autofill settings dialog now exists and allows the user to manipulate form autofill data.  Specifically address information and credit card information.
  - Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
  - The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
  - Sections are delimited visually with the SectionSeparatorView.  There are currently two sections, one for addresses and one for credit cards.
  - Unit tests are present that exercise the invocation of the dialog and check basic functionality.  Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
  - There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
  - Cocoa databinding is utilized to syncronize dependent parts of the UI.
  - All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).

The things remaining to do are:

  - Hook the UI up to the backend model, specifically the PersonalDataManager data.
  - Add support for arbitrary number of address and credit card records.  I.e. Add and Delete buttons.
  - Scroll-to-Point support for autoscrolling when tabbing between fields.
  - Billing and shipping address popups in the credit card section.
  - Any validation of input (need to circle back with UI folks on this).
  - Input validation unit tests.
  - String concatenation of the summary label needs to be internationalized.

BUG=33029
TEST=none

Review URL: http://codereview.chromium.org/558066
------------------------------------------------------------------------
r38870 | dpolukhin@chromium.org | 2010-02-12 02:58:57 +0100 (Fri, 12 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   M /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h

Add gradient shadow to login panel.
Review URL: http://codereview.chromium.org/603024
------------------------------------------------------------------------
r38868 | pkasting@chromium.org | 2010-02-12 02:52:16 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Fix the remaining issues with showing the app menu for the top left part of the window:
* Works on opaque mode frames
* Miscalculated bounds on glass frame now fixed

BUG=6961
TEST=Clicking in the upper left corner of any Chrome window, where an icon would normally be, should show the app menu.  Double-clicking should close the window.
Review URL: http://codereview.chromium.org/596073
------------------------------------------------------------------------
r38865 | pkasting@chromium.org | 2010-02-12 02:06:13 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Use the same string resource everywhere for the "Show Passwords" button.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/594039
------------------------------------------------------------------------
r38860 | mirandac@chromium.org | 2010-02-12 01:18:10 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FontLanguageSettings.xib
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.h
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller_unittest.mm

Make fonts not be clipped at large sizes in fonts and languages panel.  Also, left-align fonts and vertical-align them so that their baseline lines up with the baseline of their labels.

BUG= 33296
TEST= adjust fonts and languages.  name of font size should not be clipped.
Review URL: http://codereview.chromium.org/572046
------------------------------------------------------------------------
r38859 | pkasting@chromium.org | 2010-02-12 01:14:55 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.mm
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc

Use the generic IDS_CANCEL resource for Cancel buttons that say "Cancel".  This will let us remove a few strings.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596064
------------------------------------------------------------------------
r38856 | ben@chromium.org | 2010-02-12 00:46:04 +0100 (Fri, 12 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/app/gfx/canvas.h
   A /trunk/src/app/gfx/skia_util.cc
   A /trunk/src/app/gfx/skia_util.h
   M /trunk/src/chrome/browser/ntp_background_util.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   D /trunk/src/skia/ext/skia_utils.cc
   D /trunk/src/skia/ext/skia_utils.h
   M /trunk/src/skia/skia.gyp

Make clicking on side tabs to select them work. 
Use a simple round rect for the visual treatment. 
Add some rect conversion utils. 

http://crbug.com/34509 
TEST=none 

Review URL: http://codereview.chromium.org/597012
------------------------------------------------------------------------
r38852 | mpcomplete@chromium.org | 2010-02-12 00:25:21 +0100 (Fri, 12 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script/manifest.json

Initial work on making extensions work in incognito mode.

This merely adds a way to enable content scripts and browser actions in incognito windows. They still don't work properly because none of the APIs work with incognito tabs.

The way to enable an extension is to add an "incognito" bit in the user prefs file. My plan is to add UI for this later.

BUG=32365

Review URL: http://codereview.chromium.org/567037
------------------------------------------------------------------------
r38850 | brg@chromium.com | 2010-02-12 00:21:23 +0100 (Fri, 12 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_history_apitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Fix spelling error on history transition type.
Also mark the history test as flaky.
BUG=35430, 26296
TEST=ExtensionApiTest.FLAKY_History
Review URL: http://codereview.chromium.org/601049
------------------------------------------------------------------------
r38849 | gregoryd@google.com | 2010-02-12 00:09:29 +0100 (Fri, 12 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/WATCHLISTS
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   M /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   A /trunk/src/chrome/browser/nacl_host/nacl_process_host.cc (from /trunk/src/chrome/browser/nacl_process_host.cc:37844)
   A /trunk/src/chrome/browser/nacl_host/nacl_process_host.h (from /trunk/src/chrome/browser/nacl_process_host.h:37844)
   D /trunk/src/chrome/browser/nacl_process_host.cc
   D /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_browser.gypi

Move nacl_process_host files into browser/nacl_host

Review URL: http://codereview.chromium.org/566023
------------------------------------------------------------------------
r38847 | nick@chromium.org | 2010-02-12 00:03:37 +0100 (Fri, 12 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Two fixes from preference sync bringup: (a) Nudge the syncer on more
than just bookmarks, and (b) set the client_unique_tag during commits.

BUG=none
TEST=hack-enabled prefs, saw commit go through.

Review URL: http://codereview.chromium.org/606004
------------------------------------------------------------------------
r38838 | jianli@chromium.org | 2010-02-11 23:25:16 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.h
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/drag_download_util.h

Support dragging a virtual file out of the browser on MacOSX. This is based on the discussion of drag-out feature on whatwg: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html

BUG=none
TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder.

Review URL: http://codereview.chromium.org/598043
------------------------------------------------------------------------
r38836 | erg@chromium.org | 2010-02-11 23:19:05 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h

GTK: Add images and "Loading..." in popup blocking bubble like window's r38745.

BUG=35178
TEST=none

Review URL: http://codereview.chromium.org/601048
------------------------------------------------------------------------
r38834 | ben@chromium.org | 2010-02-11 23:10:00 +0100 (Thu, 11 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/app/gfx/canvas.h
   D /trunk/src/app/gfx/skia_util.cc
   D /trunk/src/app/gfx/skia_util.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   A /trunk/src/skia/ext/skia_utils.cc (from /trunk/src/skia/ext/skia_utils.cc:38827)
   A /trunk/src/skia/ext/skia_utils.h (from /trunk/src/skia/ext/skia_utils.h:38827)
   M /trunk/src/skia/skia.gyp

Revert 38828 - Make clicking on side tabs to select them work.
Use a simple round rect for the visual treatment.
Add some rect conversion utils.

http://crbug.com/34509
TEST=none

Review URL: http://codereview.chromium.org/597012

TBR=ben@chromium.org
------------------------------------------------------------------------
r38828 | ben@chromium.org | 2010-02-11 23:00:17 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/app/gfx/canvas.h
   A /trunk/src/app/gfx/skia_util.cc
   A /trunk/src/app/gfx/skia_util.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   D /trunk/src/skia/ext/skia_utils.cc
   D /trunk/src/skia/ext/skia_utils.h
   M /trunk/src/skia/skia.gyp

Make clicking on side tabs to select them work.
Use a simple round rect for the visual treatment.
Add some rect conversion utils.

http://crbug.com/34509
TEST=none

Review URL: http://codereview.chromium.org/597012
------------------------------------------------------------------------
r38825 | pkasting@chromium.org | 2010-02-11 22:54:33 +0100 (Thu, 11 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/browser/views/url_picker.h

Remove unused "show title" functionality in UrlPicker.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596063
------------------------------------------------------------------------
r38822 | jcampan@chromium.org | 2010-02-11 22:47:40 +0100 (Thu, 11 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/translate/translate_manager.h

Don't translate pages which are in the accept language list.

BUG=35073
TEST=Add a language (for example French) to the accept list
     (Options/Under the Hood tab/Change Font and language Settings button/
      language tab). Visit a french site (ex: www.voila.fr), the translate
      info-bar should not be shown. Without restarting Chrome, add Chinese
      to the accept language list and visit a Chinese site (ex: wwww.baidu.com),
      the info-bar should not be shown.

Review URL: http://codereview.chromium.org/602009
------------------------------------------------------------------------
r38821 | pkasting@chromium.org | 2010-02-11 22:46:35 +0100 (Thu, 11 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc

Format the "?" match like our other search matches.  This never got changed over during the Omnibox 2 changes.

BUG=none
TEST=Entering "?" in the address bar should show "<enter query> - Google Search"
Review URL: http://codereview.chromium.org/598076
------------------------------------------------------------------------
r38820 | akalin@chromium.org | 2010-02-11 22:44:03 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notification_method.cc

Changed default notification method to 'transitional'.

BUG=33261
TEST=manual

Review URL: http://codereview.chromium.org/597035
------------------------------------------------------------------------
r38816 | oshima@chromium.org | 2010-02-11 22:29:50 +0100 (Thu, 11 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/views/widget/widget_gtk.cc

Move compact navigation bar('s entry view) to main menu.
 * Chagned main menu to use TYPE_WINDOW instead of POPUP.
 * Added hooks to close main menu when a user clicked non content area.    (see MainMenuContainer::OnMousePressed and MainMenu::ActiveWindowChanged)
 * removed entry view from CompactNavigationBar view. We probably should rename this class (later).
 * Fixed a mouse coordinates issue in WidgetGtk: A location in the mouse event may not be in    its gdk_window when it's originated from child gdk_window.
 * UIStyle's enum has to start with 0  * removed DLOG thas I checked in by accident.

BUG=31766
TEST=manual: switch to compact navigation bar using ctrl-shift-c and confirm that no navigation entry in title bar.
  main menu has the navigation entry instead.

Review URL: http://codereview.chromium.org/604015
------------------------------------------------------------------------
r38815 | skrul@chromium.org | 2010-02-11 22:29:26 +0100 (Thu, 11 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/preference_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   M /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.cc
   M /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc

Create preferences DTC and wire it into the profile sync factory.
Also includes a small valgrind error fix.

Review URL: http://codereview.chromium.org/598046
------------------------------------------------------------------------
r38814 | johnnyg@chromium.org | 2010-02-11 22:24:18 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc

Fix a regression in the display of notifications on Windows: the TOPMOST bit needs to be set before the windows get shown (in Init()), otherwise the windows are not displayed topmost.

BUG=35426
TEST=create a notification and focus a window over it

Review URL: http://codereview.chromium.org/604020
------------------------------------------------------------------------
r38813 | jshin@chromium.org | 2010-02-11 22:16:46 +0100 (Thu, 11 Feb 2010) | 19 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/language_combobox_model.cc

Maps our internal Chinese locale codes to those expected by the ICU API for 
the display name of a locale and expected by Google (in case of 'nb vs no').

1. Map zh-CN and zh-TW to zh-Hans and zh-Hant in GetDisplay
2. Map nb to no before adding 'hl' param for Google services. This will be removed once Google begins to honor 'nb'. 
3. While doing so, I found that language_combox_model.cc has the exactly the
   same code as in l10n_util.cc and refactored it.

BUG=34531
TEST=1. app_unittest: L10nUt*.LocaleDispla* 
     2. See the bug 34531
     3. On Windows, the language menu in 
        Options | Under the hood | Fonts & Language Menu | Language tab lists
        'Chinese (Simplified Han)' and 'Chinese (Traditional Han)' for Simplified
         Chinese and Traditional Chinese in English Chrome along with 
         Chinese names for those two languages. This is the behavior
         without this CL and it should't change with the refactoring.

Review URL: http://codereview.chromium.org/596033
------------------------------------------------------------------------
r38812 | viettrungluu@chromium.org | 2010-02-11 22:11:15 +0100 (Thu, 11 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm

Mac: (for fullscreen mode) make key redispatch handle "misdirected" events.

Moving things between windows can lead to the key redispatch getting an event
for the wrong window. This makes the redispatcher synthesize new events in that
case.

BUG=31638
TEST=Compiles/unit tests. Enable fullscreen mode (in code), and switch back and forth between regular and fullscreen mode (esp. while loading slow web pages) like mad.

Review URL: http://codereview.chromium.org/594025
------------------------------------------------------------------------
r38809 | rvargas@google.com | 2010-02-11 22:07:08 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc

Enable URLFetcherBadHTTPSTest.BadHTTPSTest for Linux and Mac

BUG=2468
TEST=this test

Review URL: http://codereview.chromium.org/598069
------------------------------------------------------------------------
r38807 | avayvod@chromium.org | 2010-02-11 21:56:48 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h

Fixed alignment of button dropdowns for RTL languages.

BUG=none
TEST=Run chrome with LANGUAGE=ar or with --lang=ar. Verify that all status
area menus as well as main menu are aligned properly (go to the right, not
to the left).

Review URL: http://codereview.chromium.org/601032
------------------------------------------------------------------------
r38803 | tim@chromium.org | 2010-02-11 21:49:23 +0100 (Thu, 11 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   A /trunk/src/chrome/browser/sync/engine/model_safe_worker.cc
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/chrome.gyp

For sync, add OrderedCommitSet::Projection, a helper for iterating over
commit IDs one ModelSafeGroup at a time.

BUG=31911
TEST=SyncerTest.OrderedCommitSetProjections

Review URL: http://codereview.chromium.org/603025
------------------------------------------------------------------------
r38800 | darin@chromium.org | 2010-02-11 21:04:13 +0100 (Thu, 11 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Revert 38777 - Change ViewHostMsg_SetCookie to be routed so we can show the blocked cookie
notification.

We get the RenderView identifier by looking at the current WebFrame.

R=jorlow
BUG=34573
TEST=none

Review URL: http://codereview.chromium.org/596050

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/597047
------------------------------------------------------------------------
r38797 | dglazkov@chromium.org | 2010-02-11 20:28:56 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Revert 38479 - Send forms seen in the renderer to the AutoFillManager.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/584009

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/597045
------------------------------------------------------------------------
r38792 | jhawkins@chromium.org | 2010-02-11 19:42:57 +0100 (Thu, 11 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/form_field_history_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h

Rename RenderViewHost::FormFieldHistorySuggestionsReturned to the more accurate AutocompleteSuggestionsReturned.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/601036
------------------------------------------------------------------------
r38788 | viettrungluu@chromium.org | 2010-02-11 19:06:29 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: make tab strip taller in fullscreen mode (still disabled).

Make enough room so that the main menu (which also slides down) doesn't overlap the tabs.

BUG=31638
TEST=none (things should work normally in normal mode; unit tests should pass)

Review URL: http://codereview.chromium.org/603023
------------------------------------------------------------------------
r38783 | jorlow@chromium.org | 2010-02-11 18:46:13 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   A /trunk/src/chrome/browser/renderer_host/database_permission_request.cc
   A /trunk/src/chrome/browser/renderer_host/database_permission_request.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/webkit/database/database_util.cc
   M /trunk/src/webkit/database/database_util.h
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/database/vfs_backend.h

Add support for CONTENT_SETTING_ASK to database.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/572001
------------------------------------------------------------------------
r38782 | rohitrao@chromium.org | 2010-02-11 18:21:21 +0100 (Thu, 11 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Modifies GetRestoredBounds() to return the bounds of the hidden regular window when a window is in fullscreen mode.

BUG=31638
TEST=Once fullscreen mode is enabled on trunk, make a window fullscreen, then Cmd-N to open a new window.  The new window should be the same size as the original, non-fullscreen window.
Review URL: http://codereview.chromium.org/577051
------------------------------------------------------------------------
r38777 | darin@chromium.org | 2010-02-11 17:41:57 +0100 (Thu, 11 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc

Change ViewHostMsg_SetCookie to be routed so we can show the blocked cookie
notification.

We get the RenderView identifier by looking at the current WebFrame.

R=jorlow
BUG=34573
TEST=none

Review URL: http://codereview.chromium.org/596050
------------------------------------------------------------------------
r38771 | rohitrao@chromium.org | 2010-02-11 16:01:23 +0100 (Thu, 11 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm

[Mac] Fixes floating bar pattern drawing.

BUG=31638
TEST=Install the Topography theme. When in fullscreen mode, the background in the tabs should line up with the window background.
Review URL: http://codereview.chromium.org/593041
------------------------------------------------------------------------
r38770 | rohitrao@chromium.org | 2010-02-11 16:00:29 +0100 (Thu, 11 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm

[Mac] Do not resize devtools when showing if it is already open.

BUG=34494
TEST=Open devtools and resize.  Right-click on the webpage and "Inspect element."  Devtools should not resize to its original size.
Review URL: http://codereview.chromium.org/565040
------------------------------------------------------------------------
r38765 | joth@chromium.org | 2010-02-11 14:22:55 +0100 (Thu, 11 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h

Simplify (honest!) the threading design for data providers: the API is now single threaded, and worker
threads are encapsulated within the data provider implementation.

BUG=None
TEST=unit_tests.exe --gtest_filter=Geol* --gtest_repeat=10000 --gtest_break_on_failure

Review URL: http://codereview.chromium.org/598017
------------------------------------------------------------------------
r38752 | jeremy@chromium.org | 2010-02-11 11:14:17 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm

Allow gradient color override.

Translate infobars are blue, allow override.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/583010
------------------------------------------------------------------------
r38751 | darin@chromium.org | 2010-02-11 09:45:06 +0100 (Thu, 11 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   D /trunk/src/webkit/glue/glue_util.cc
   D /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/webkit.gyp

Remove webkit/glue/glue_util.{h,cc} now that the WebKit API is complete!

R=jorlow
BUG=24607
TEST=none

Review URL: http://codereview.chromium.org/601029
------------------------------------------------------------------------
r38745 | pkasting@chromium.org | 2010-02-11 07:05:38 +0100 (Thu, 11 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h

Better popup list display:
* When a popup has no URL or title yet, display "Loading..." instead of a blank line.
* Show favicons next to the links, and make the favicons clickable like the links.

BUG=35095,35096
TEST=Visit popuptest.com, start a test, and immediately click the blocked icon.  There should be no blank lines.  Close the bubble and click again now that everything has loaded.  All the entries should have clickable favicons.
Review URL: http://codereview.chromium.org/600065
------------------------------------------------------------------------
r38740 | akalin@chromium.org | 2010-02-11 05:27:00 +0100 (Thu, 11 Feb 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/notification_method.cc
   A /trunk/src/chrome/browser/sync/notification_method.h
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_mock.h
   A /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/notification_constants.h
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.h
   A /trunk/src/chrome/browser/sync/notifier/listener/send_update_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.h
   A /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util.h
   A /trunk/src/chrome/browser/sync/notifier/listener/xml_element_util_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Implemented new notification methods.

Added a NotificationMethod enum, which defines NOTIFICATION_LEGACY, NOTIFICATION_TRANSITIONAL, NOTIFICATION_NEW (see bug for details).

Made SendUpdateTask and SubscribeTask take a NotificationMethod and use it.

Added command-line switch to override default notification method (currently NOTIFICATION_LEGACY).

Added a bunch of unittests.

BUG=33261
TEST=trybots, manual testing with notification client pythons scripts and browsers with different notification methods

Review URL: http://codereview.chromium.org/573046
------------------------------------------------------------------------
r38739 | avayvod@chromium.org | 2010-02-11 05:12:22 +0100 (Thu, 11 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added separate flag for start login screen since login-manager is added by
session_manager and can't be overriden correctly from
session_manager_setup.sh

BUG=none
TEST=Modify /sbin/session_manager_setup.sh by adding
--login-screen=create_account switch to chrome command line at the end of
the file. Reboot. Verify that account creation screen is launched.

Review URL: http://codereview.chromium.org/600064
------------------------------------------------------------------------
r38737 | suzhe@chromium.org | 2010-02-11 04:36:24 +0100 (Thu, 11 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

[Linux]Fix text justification of omnibox.

Without this CL, the omnibox inherits the default behavior of GtkTextView on handling text direction and justification, that is:
1. If the justification is set to left justification, then the content will be left justified if the content's text direction is LTR, otherwise it'll be right justified.
2. If the justification is set to right justification, then the content will be right justified if the content's text direction is LTR, otherwise it'll be left justified.

And if the content doesn't have a strong text direction, the keymap's direction will be used. If the keymap doesn't have a strong text direction either, the widget's direction (UI language direction) will be used.

This behavior is different than Chrome windows. On windows, if the UI language direction is LTR, then the content is always left justified, otherwise it's always right justified.

To achieve the same behavior, this CL adjust the justification automatically according to the content's (or keymap's) text direction and the widget direction, to make sure the justification is always in sync with the UI language direction.

BUG=34724 Text in omnibox and find bar is not right justified correct under RTL locale.
TEST=Run chrome with LTR locale, the text in omnibox should always be left justified, regardless of the text's direction. With RTL locale, the text should always be right justified. It matches the behavior of windows version.

Review URL: http://codereview.chromium.org/595021
------------------------------------------------------------------------
r38736 | arv@chromium.org | 2010-02-11 04:20:56 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarktree.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui.js
   M /trunk/src/chrome/browser/resources/bookmark_manager/main.html

Bookmark Manager: Hook up edit and rename commands.

This adds support for rename/edit to the tree and list.

BUG=4890
TEST=Right click and rename folders. Right click to edit bookmarks.

Review URL: http://codereview.chromium.org/600025
------------------------------------------------------------------------
r38735 | ananta@chromium.org | 2010-02-11 03:33:18 +0100 (Thu, 11 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

Fix an ExternalTabContainer leak caused in the code path which attaches an ExternalTabContainer to
an IE tab, which connects to it. The leak occurs because of a refcount leak. This causes the AutomationProvider
to not get released thus resulting in a running chrome.exe instance even after we shutdown IE.

Review URL: http://codereview.chromium.org/600063
------------------------------------------------------------------------
r38733 | avayvod@chromium.org | 2010-02-11 03:05:16 +0100 (Thu, 11 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   M /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/chromeos/login/wizard_screen.h

Hooked up network selection and account creation screens to login wizard so
when these screens exit, login screen is shown.
Separated loading l10n strings to simplify implementation of ui language
switch.
Fixed some style issues.

BUG=none
TEST=Start with --login-manager=network and connect to network - login
screen should appear. Start with --login-manager=create_account and hit
Enter or click Create Account - login screen should appear.

Review URL: http://codereview.chromium.org/596041
------------------------------------------------------------------------
r38728 | eroman@chromium.org | 2010-02-11 02:11:25 +0100 (Thu, 11 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Revert the revert... This has the cumulative effect of relanding 38694.
The chrome frame failure appears to be unrelated.

Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly.

Review URL: http://codereview.chromium.org/600040

TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/596048

TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/604012
------------------------------------------------------------------------
r38726 | nick@chromium.org | 2010-02-11 02:05:38 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.h
   A /trunk/src/chrome/browser/sync/engine/download_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   A /trunk/src/chrome/browser/sync/syncable/model_type.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   A /trunk/src/chrome/test/sync/engine/proto_extension_validator.h

Hook up client side of per-datatype GetUpdates.

Which datatypes are fetched is dictated by the ModelSafeRoutingInfo.  We change the semantic of the ModelSafeRoutingInfo so that datatypes which should not be synced are not in the map.  We will do GetUpdates for GROUP_PASSIVE datatypes.

BUG=29905
TEST=included unit tests

Review URL: http://codereview.chromium.org/594024
------------------------------------------------------------------------
r38723 | jochen@chromium.org | 2010-02-11 01:59:18 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc

Do not delete cookies when deleting history.

BUG=35302
TEST=delete history of last day, check cookies

Review URL: http://codereview.chromium.org/593046
------------------------------------------------------------------------
r38721 | jochen@chromium.org | 2010-02-11 01:25:44 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ClearBrowsingData.xib
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc

Add option to delete browsing history of the last hour.

BUG=35302
TEST=manually test

Review URL: http://codereview.chromium.org/596047
------------------------------------------------------------------------
r38718 | jhawkins@chromium.org | 2010-02-11 01:20:43 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Fix recently added FormField constructors that I missed in the last commit.

TBR=zork
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/598047
------------------------------------------------------------------------
r38717 | cira@chromium.org | 2010-02-11 01:20:09 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc
   A /trunk/src/chrome/common/extensions/extension_message_filter_peer.cc
   A /trunk/src/chrome/common/extensions/extension_message_filter_peer.h
   A /trunk/src/chrome/common/extensions/extension_message_filter_peer_unittest.cc
   M /trunk/src/chrome/common/filter_policy.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc

Replace __MSG_some_name__ template within extension css files with localized messages.

We avoid replacing messages within html and js extension files for security reasons. Also, developers can already localize messages in html/js using chrome.i18n.getMessage calls.

TEST=Localize extension, try body{direction: __MSG_@@bidi_reversed_dir__;} in popup.css, while using non-rtl locale. Text should be alligned to the right (as if we were using rtl locale).

BUG=26144
Review URL: http://codereview.chromium.org/570007
------------------------------------------------------------------------
r38712 | finnur@chromium.org | 2010-02-11 01:11:07 +0100 (Thu, 11 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h
   M /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Make context menu in Browser Action overflow menu do something.

In a previous reorg change the lifetime of the context menu
changed, causing it to get deleted before executing its 
actions. This change makes the browser action container
own the context menu, lazily create it and reuse it for
every browser action from that point on.

Also delaying a bit when we clear the drop indicator
(it shouldn't go away until the dropdown menu appears).

BUG=34796
TEST=Context menu off of the Browser Action Container
overflow menu should now work. Dragging and dropping
between the container and the overflow menu should still
work (and reordering within both as well).

Review URL: http://codereview.chromium.org/601033
------------------------------------------------------------------------
r38711 | jhawkins@chromium.org | 2010-02-11 01:09:32 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_field.cc
   M /trunk/src/chrome/browser/form_field_history_manager.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc

Reland r38570.  The underlying bug has been fix.

Move conditions of FormField creation to FormFieldHistoryManager; AutoFill does not have the same conditions. This required manipulating the FormField data structure to add necessary field data.

TBR=tony
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/603015
------------------------------------------------------------------------
r38707 | eroman@chromium.org | 2010-02-11 00:56:23 +0100 (Thu, 11 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Revert 38694 - For some reason this seems to be hanging chrome frame tests, even though this should be a strictly no-op change...

Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly.

Review URL: http://codereview.chromium.org/600040

TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/596048
------------------------------------------------------------------------
r38705 | mattm@chromium.org | 2010-02-11 00:47:58 +0100 (Thu, 11 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Linux: fix clicking on security or blocked contents of non-active window showing wrong data.

Change the location bar code on all platforms to not use BrowserList::GetLastActive.

Makes GetTabContents part of the LocationBar interface.

BUG=none
TEST=open two windows that show security or blocked popups.  click the icon in the non-focused one.

Review URL: http://codereview.chromium.org/573038
------------------------------------------------------------------------
r38704 | kuan@chromium.org | 2010-02-11 00:44:55 +0100 (Thu, 11 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h

translate infobars: reimplement, fix bugs
- 35077: redesign and reimplement infobars and infobars delegates to merge before- and after-translate infobars into one, whose state transitions from before-translate to translating to after-translate
- 35080: modify gradient of blue infobar per roma (to differentiate from default chrome theme)
- 35052: fix white-pixel lines in infobar buttons by stretching image sets instead of tiling them

BUG=35052,35080,35077
TEST=verify per all bug reports.

Review URL: http://codereview.chromium.org/604001
------------------------------------------------------------------------
r38703 | chron@google.com | 2010-02-11 00:42:44 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Refactor PostClientToServer message, include new unit tests for it. In prep for adding auth filter changes.

TEST=unit tests included
BUG=35321

Review URL: http://codereview.chromium.org/597025
------------------------------------------------------------------------
r38702 | erg@chromium.org | 2010-02-11 00:40:01 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK: Fix label color and text color for DarkRoom.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/596046
------------------------------------------------------------------------
r38699 | skrul@chromium.org | 2010-02-11 00:29:36 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/webdata/autofill_entry.cc
   M /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Added the GetAllAutofillEntries function to the WebDatabase class in preparation for autofill sync.

BUG=30959
TEST=WebDatabaseTest.GetAllAutofillEntries

Review URL: http://codereview.chromium.org/598004
------------------------------------------------------------------------
r38697 | davemoore@chromium.org | 2010-02-11 00:08:47 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/google_update_chromeos.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Use Chrome update UI for Chrome OS updates.

BUG=279 (Chromium OS) (Not Complete)
TEST=none

Review URL: http://codereview.chromium.org/587006
------------------------------------------------------------------------
r38696 | rsesek@chromium.org | 2010-02-11 00:08:46 +0100 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

Mark CookiesWindowControllerTest.RemoveButtonEnabled as flaky.

BUG=35327
TEST=Flaky on Mac Valgrind unit

Review URL: http://codereview.chromium.org/603013
------------------------------------------------------------------------
r38694 | eroman@chromium.org | 2010-02-11 00:00:40 +0100 (Thu, 11 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly.

Review URL: http://codereview.chromium.org/600040
------------------------------------------------------------------------
r38688 | georgey@chromium.org | 2010-02-10 23:52:34 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Dialog showed now only if profiles are loaded - if not it waits until they are.
Added capability of multiple observers for profile loading.
BUG=33026
TEST=If loading of profiles takes time (slow connection, for example), dialog does not appear until they are loaded.
Review URL: http://codereview.chromium.org/601010
------------------------------------------------------------------------
r38685 | twiz@chromium.org | 2010-02-10 23:46:47 +0100 (Wed, 10 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_host.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

CL implementing focus-dismissal of the chrome.experimental.popup set of extension APIs.  

Specifically, these changes cause a displayed pop-up to be dismissed when the focus shifts away from both the pop-up view, and the extension-view that launched the pop-up.I had to do a lot of investigating and trial-and-error to converge to the solution present here.  I was hoping to be able to piggy-back on the existing FocusManager's various listener routines, but because the pop-up is hosted in a BubbleWidget, which is a separate top-level window with its own focus manager, I could not rely on a given focus manager to take care of the focus change notifications. To get around the above issue, I added a new type of focus listener that can listen on native-window focus change events.  I added invocations to this listener throughout the Widget classes in the system so that registered listeners will be notified on focus change.  

I found some of the focus change events problematic, as the system will arbitrarily reassign the focus to the main browser window when shifting activation between chrome windows.  (SeefocusManagerWin::ClearNativeFocus).  To prevent this focus bounce from confusing focus listeners, I added a means to suppress notification of focus change during these operations.

I added GTK and Mac stubs for the new widget functions that will assert when called.  GTK and Cocoa development is not my expertise, so I thought // TODO(port) would be wiser.I'm uncertain of the best means to unit-test these changes.  Direction in this regard would be appreciated.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/552167
------------------------------------------------------------------------
r38684 | estade@chromium.org | 2010-02-10 23:45:45 +0100 (Wed, 10 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK: lighten the color of the download item status/label text.

This doesn't use the same technique as windows/mac, which both draw the text first, then draw the download item shading over it. To do that for GTK results in very delicate and complicated code, so instead I just alpha-blended the text color manually with hard-coded values.

BUG=21176
TEST=see bug

Review URL: http://codereview.chromium.org/598033
------------------------------------------------------------------------
r38682 | erg@chromium.org | 2010-02-10 23:39:45 +0100 (Wed, 10 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   A /trunk/src/chrome/browser/gtk/meta_frames.cc
   A /trunk/src/chrome/browser/gtk/meta_frames.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: Use color data from the MetaFrames class in newer versions of GTK+.

When codereviewing my r36867, evmar suggested that I implement our trying to
match WM frames in terms of gtk_rc_get_style_by_paths(). This worked...  on the
version of gtk+ included with hardy. It notably doesn't work under the version
included with Karmic. This is the original patch from CL 552092 with some
cleanup, before I rewrote it.

BUG=32173
TEST=New Wave has a dark border color under GNOME on Karmic.

Review URL: http://codereview.chromium.org/564048
------------------------------------------------------------------------
r38672 | mark@chromium.org | 2010-02-10 23:01:38 +0100 (Wed, 10 Feb 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.cc
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.h
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_gtk.cc (from /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.cc:38669)
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_gtk.h (from /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.h:38669)
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc (from /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.cc:38669)
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h (from /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.h:38669)
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Attempt to fix the Linux Views and ChromiumOS builds following r38658.

chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to
be a views file, not a Windows file, so why is it named with _win.cc?  This is
a speculative change.

BUG=none
TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps
     turn green
Review URL: http://codereview.chromium.org/600049
------------------------------------------------------------------------
r38669 | mark@chromium.org | 2010-02-10 22:41:25 +0100 (Wed, 10 Feb 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.cc (from /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc:38668)
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu.h (from /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h:38668)
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.h
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc
   D /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Attempt to fix the Linux Views and ChromiumOS builds following r38658.
chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to
be a views file, not a Windows file, so why is it named with _win.cc?  This is
a speculative change.

BUG=none
TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps
     turn green
Review URL: http://codereview.chromium.org/596040
------------------------------------------------------------------------
r38666 | avayvod@chromium.org | 2010-02-10 22:15:03 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc

Better alignment for Star button and location bar.

BUG=none
TEST=Toggle compact location bar. Star button should be now aligned with
Reload button, not be above it.
Review URL: http://codereview.chromium.org/601012
------------------------------------------------------------------------
r38661 | pkasting@chromium.org | 2010-02-10 21:56:04 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc

Per brakowski, the cookie prompt default should be "remember" and not "ask".

BUG=none
TEST=Turn on cookie prompting.  The prompt default should be "remember".
Review URL: http://codereview.chromium.org/593043
------------------------------------------------------------------------
r38657 | sky@chromium.org | 2010-02-10 21:30:10 +0100 (Wed, 10 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/common/notification_type.h

Adds code to restore application extensions. I'm also enabling tab
pinning on views again as everything in place, except a couple of
bugs.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/598027
------------------------------------------------------------------------
r38656 | zork@chromium.org | 2010-02-10 21:19:47 +0100 (Wed, 10 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/protocol/autofill_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/preference_specifics.proto

Change the name fields back to their previous name to unbreak the build

BUG=none
TEST=build chrome
------------------------------------------------------------------------
r38655 | skrul@chromium.org | 2010-02-10 21:13:43 +0100 (Wed, 10 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.cc
   A /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/change_processor_mock.h
   A /trunk/src/chrome/browser/sync/glue/data_type_controller.h
   A /trunk/src/chrome/browser/sync/glue/model_associator_mock.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/profile_sync_factory.h
   A /trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc
   A /trunk/src/chrome/browser/sync/profile_sync_factory_impl.h
   A /trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc
   A /trunk/src/chrome/browser/sync/profile_sync_factory_mock.cc
   A /trunk/src/chrome/browser/sync/profile_sync_factory_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_mock.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

First stab at a DataTypeController.
This is my first stab at a DataTypeController, plus a BookmarkDataTypeController implementation.  It is not fully wired into the PSS yet :)

Review URL: http://codereview.chromium.org/545074
------------------------------------------------------------------------
r38654 | zork@chromium.org | 2010-02-10 21:05:12 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/protocol/autofill_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/preference_specifics.proto

Update the .proto files to change the fields to optional.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/598035
------------------------------------------------------------------------
r38653 | jhawkins@chromium.org | 2010-02-10 20:49:46 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address_field.cc

Fix a crash when parsing address fields.  It's possible we've run out of fields while parsing the zip code.  The other fields check this in ParseText, but ParseZipCode opens up the field to get at the name.

BUG=35176
TEST=none
Review URL: http://codereview.chromium.org/604002
------------------------------------------------------------------------
r38650 | albertb@google.com | 2010-02-10 20:33:52 +0100 (Wed, 10 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi

Fill in the preference sync TODOs using the preference specifics proto and
client tags.

BUG=32409
TEST=none

Review URL: http://codereview.chromium.org/593029
------------------------------------------------------------------------
r38648 | phajdan.jr@chromium.org | 2010-02-10 20:26:59 +0100 (Wed, 10 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/browser/extensions/extensions_service_unittest.h
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_queue.cc
   M /trunk/src/chrome/chrome_tests.gypi

Make sure that ResourceQueue is shut down before destruction.

Rewrite UserScriptListener unit test to not use ResourceDispatcherHost.

Share more code with ExtensionsServiceTest.

TEST=Covered by unit_tests.
BUG=none

Review URL: http://codereview.chromium.org/601005
------------------------------------------------------------------------
r38644 | erg@chromium.org | 2010-02-10 20:11:33 +0100 (Wed, 10 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc

GTK: Build fix

TBR=sheriff
------------------------------------------------------------------------
r38642 | erg@chromium.org | 2010-02-10 19:58:54 +0100 (Wed, 10 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/content_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   A /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.h
   A /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/cookie_filter_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Implements the content settings window and the minor changes to the options dialog.

The "Exceptions" dialogs are still not implemented; they're the next step but
this changelist is already getting pretty huge.

BUG=35178
TEST=none

Review URL: http://codereview.chromium.org/602005
------------------------------------------------------------------------
r38641 | jochen@chromium.org | 2010-02-10 19:56:18 +0100 (Wed, 10 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

Make path absolute so URL Fixer Upper unittest does not fail if invoked using something like ../../out/Debug/unit_tests

BUG=none
TEST=Run the unit_tests executable with a path containing a "/../". It should pass.

Review URL: http://codereview.chromium.org/595005
Patch from Bernhard Bauer.
------------------------------------------------------------------------
r38640 | ian@chromium.org | 2010-02-10 19:44:48 +0100 (Wed, 10 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/app/tree_model.h
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/common/gtk_tree.cc
   M /trunk/src/views/controls/tree/tree_view.cc

Fixes a bug where if there are only localstorage nodes, but nocookies nodes, the Remove and Remove All buttons are disabled.BUG=34886
TEST=clear all cookies, go to www.ianfette.com/localstorage.html and open cookies dialog, check that remove button is enabled.
Review URL: http://codereview.chromium.org/596002
------------------------------------------------------------------------
r38639 | phajdan.jr@chromium.org | 2010-02-10 19:40:33 +0100 (Wed, 10 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/PRESUBMIT.py
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list_gtk.cc
   A /trunk/src/chrome/browser/browser_list_stub.cc
   A /trunk/src/chrome/browser/browser_list_win.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm
   A /trunk/src/chrome/browser/dock_info_mac.cc
   A /trunk/src/chrome/browser/jankometer_mac.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   A /trunk/src/chrome/browser/printing/print_job_linux.cc
   A /trunk/src/chrome/browser/printing/print_job_manager_linux.cc
   A /trunk/src/chrome/browser/printing/print_view_manager_linux.cc
   A /trunk/src/chrome/browser/printing/printer_query_linux.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   D /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove the temporary scaffolding stubs.

They have served they purpose well, but now it's time to retire.
It's one of the things that draggen in the bad dependency of chrome/common
on chrome/browser, and is sufficiently small now to stub things out individually.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/593037
------------------------------------------------------------------------
r38637 | jcampan@chromium.org | 2010-02-10 19:26:11 +0100 (Wed, 10 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h

This CL addresses 2 issues:
- we were not computing the max request text size correctly in some cases (by forgetting the size of the &q= string) causing assertions.
- the translate server might send inconsistent response in some cases, this CL makes sure we deal with them.
A common case is when sending separators only strings, which
we are not doing now anymore.
Other more complicated case are less clear.

BUG=35055
TEST=Visit www.spiegel.de and translate the page. The page
     should be translated correctly.

Review URL: http://codereview.chromium.org/594023
------------------------------------------------------------------------
r38636 | erg@chromium.org | 2010-02-10 19:15:56 +0100 (Wed, 10 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak

This reverts r38541, which reverts previous reverts.

This will re-introduce a mac performance regression but will make the code
correct.

R=mirandac (over shoulder)
BUG=34775,34078
TEST=none

Review URL: http://codereview.chromium.org/600045
------------------------------------------------------------------------
r38635 | jochen@chromium.org | 2010-02-10 19:13:40 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/browsing_data_database_helper.cc
   A /trunk/src/chrome/browser/browsing_data_database_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   A /trunk/src/chrome/browser/mock_browsing_data_database_helper.cc
   A /trunk/src/chrome/browser/mock_browsing_data_database_helper.h
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.h
   A /trunk/src/chrome/browser/views/database_info_view.cc
   A /trunk/src/chrome/browser/views/database_info_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Add support for HTML5 databases to the cookie tree model.

BUG=34633
TEST=create local databases, open cookie tree view from prefs.

Review URL: http://codereview.chromium.org/596009
------------------------------------------------------------------------
r38634 | nkostylev@google.com | 2010-02-10 19:05:13 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   A /trunk/src/chrome/browser/chromeos/login/network_selection_view.cc
   A /trunk/src/chrome/browser/chromeos/login/network_selection_view.h
   M /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   A /trunk/src/chrome/browser/chromeos/login/wizard_screen.h
   M /trunk/src/chrome/chrome_browser.gypi

Initial implementation of Network selection/welcome screen for OOBE.

BUG=35016
TEST=With --login-manager=network screen should be shown. Currently this screen is not used in wizard process. Network selection is not fully supported.

Review URL: http://codereview.chromium.org/570041
------------------------------------------------------------------------
r38633 | creis@chromium.org | 2010-02-10 18:58:27 +0100 (Wed, 10 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Adds a UI test for WebKit fix to beforeunload bug.

The issue with Gmail warnings on cross-site navigations has been fixed upstream, and a recent WebKit DEPS roll pulled it in.  This just adds an automated test for it in Chrome.

BUG=32615
TEST=UnloadTest.BrowserCloseWithInnerFocusedFrame

Review URL: http://codereview.chromium.org/594014
------------------------------------------------------------------------
r38632 | andybons@chromium.org | 2010-02-10 18:57:01 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Use the ExtensionToolbarModel for ordering of the Browser Actions. Prep for drag and drop for re-ordering.
Also fixes crashers where if you tried to disable an extension via its context menu while an incognito window was key, boom.

BUG=26990
TEST=none
Review URL: http://codereview.chromium.org/595017
------------------------------------------------------------------------
r38631 | dhg@chromium.org | 2010-02-10 18:54:55 +0100 (Wed, 10 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/theme/filebrowse_back.png
   M /trunk/src/chrome/app/theme/filebrowse_forward.png
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Initial Feedback from UX on the filebrowser
Review URL: http://codereview.chromium.org/596025
------------------------------------------------------------------------
r38630 | phajdan.jr@chromium.org | 2010-02-10 18:53:04 +0100 (Wed, 10 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Mark download tests as flaky on all platform, just the sad truth.

TBR=dglazkov, kuchhal
TEST=still flaky
BUG=35275, 20809

Review URL: http://codereview.chromium.org/601030
------------------------------------------------------------------------
r38629 | erg@chromium.org | 2010-02-10 18:47:41 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/app/gfx/font_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/process_singleton_dialog.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/input_window_dialog_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/o3d/plugin/linux/main_linux.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/combobox/native_combobox_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc

Remove redundant casts in g_signal_connect() throughout all gtk code we have.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/600033
------------------------------------------------------------------------
r38628 | jianli@chromium.org | 2010-02-10 18:47:39 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc

Fix a bug in DownloadFile::Rename where we need to seek to the end of the file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/601018
------------------------------------------------------------------------
r38625 | dantasse@chromium.org | 2010-02-10 18:40:09 +0100 (Wed, 10 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Fix for bug 26397: Bookmark manager in Incognito mode doesn't show Sync Bookmarks button

The bug exists because the BookmarkManagerView checks the profile to see if it has a ProfileSyncService set up to see whether it should show the "Sync Bookmarks" button.  Incognito profiles do not have a ProfileSyncService, even if the corresponding "original profile" has a PSS.  So the fix is to check the original profile (here called "profile_"), not the profile.

This is already fixed in Linux (bookmark_manager_gtk.cc).  Also, all native versions are scheduled to be replaced by a common bookmark manager soon.

BUG=26397
TEST=manual

Review URL: http://codereview.chromium.org/574022
------------------------------------------------------------------------
r38624 | xiyuan@chromium.org | 2010-02-10 18:08:15 +0100 (Wed, 10 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h

Only show one FileBrowse pop up for the same folder

Check existing FileBrowse pop ups before opening new one so that we only
show one per folder;

BUG=none
TEST=On ChromeOS, download multiple files to default downloads dir and there should be only one FileBrowse pop up showing up.

Review URL: http://codereview.chromium.org/601013
------------------------------------------------------------------------
r38622 | sky@chromium.org | 2010-02-10 18:00:51 +0100 (Wed, 10 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_views.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Couple of tweaks to the cookie prompt dialog:

. Fixes bug that lead to randomly expanding and not (expanded_view_
  wasn't in the member initializer list).
. Fixed bug where expanding/collapsing would result in dialog changing
  to wrong size.
. Persist expanded state to prefs.

BUG=35092, 35165 
TEST=see bugs

Review URL: http://codereview.chromium.org/595014
------------------------------------------------------------------------
r38619 | rsesek@chromium.org | 2010-02-10 16:30:36 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix a leak in CookiesWindowControllerTest and remove the appropriate suppression

BUG=31586
TEST=Mac Valgrind unit tests

Review URL: http://codereview.chromium.org/597015
------------------------------------------------------------------------
r38615 | phajdan.jr@chromium.org | 2010-02-10 14:10:03 +0100 (Wed, 10 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/notification_type.h

Remove poll'n'loop code from extension_browsertest.cc.

Also use a common wait function from extension_browsertest
in the page action popup test.

BUG=34339
TEST=browser_tests

Review URL: http://codereview.chromium.org/582013
------------------------------------------------------------------------
r38611 | phajdan.jr@chromium.org | 2010-02-10 12:35:27 +0100 (Wed, 10 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Revert the part of http://codereview.chromium.org/593018 touching unload_uitest.cc

The test started to hang mysteriously on Linux Tests(dbg)(1) and I remember some
past problems about this test. Would need more investigation. The test is
fine on all other platforms and bots, including Linux Tests(dbg)(2).

TBR=brettw
TEST=stop hanging
BUG=none

Review URL: http://codereview.chromium.org/597020
------------------------------------------------------------------------
r38605 | phajdan.jr@chromium.org | 2010-02-10 10:33:21 +0100 (Wed, 10 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/test/data/cross-origin-redirect-blocked.html
   M /trunk/src/chrome/test/data/window.close.html

Make several tests more snappy, less sleepy.

Some also say it's good for reducing flakiness.

TEST=Changing ui_tests.
BUG=none

Review URL: http://codereview.chromium.org/593018
------------------------------------------------------------------------
r38604 | phajdan.jr@chromium.org | 2010-02-10 10:26:16 +0100 (Wed, 10 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   A /trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add basic tests for extension crash recovery.

Also update the test infrastructure to support the required features.

TEST=browser_tests
BUG=30405

Review URL: http://codereview.chromium.org/572038
------------------------------------------------------------------------
r38588 | avayvod@chromium.org | 2010-02-10 08:22:54 +0100 (Wed, 10 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/login/account_creation_view.cc
   A /trunk/src/chrome/browser/chromeos/login/account_creation_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Added initial implementation of account creation view.

BUG=35157
TEST=Run chrome with --login-manager=create_accout and verify that screen
works as intended.

Review URL: http://codereview.chromium.org/600003
------------------------------------------------------------------------
r38587 | jochen@chromium.org | 2010-02-10 08:22:40 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_network_transaction.cc

Add option to suppress HTTP Referer header.

BUG=none
TEST=start chrome and run tcpdump -A. Should be contain any referer header.

Review URL: http://codereview.chromium.org/600008
------------------------------------------------------------------------
r38583 | ananta@chromium.org | 2010-02-10 07:41:02 +0100 (Wed, 10 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Fix a Chrome crash which occurs in a ChromeFrame instance while servicing a read request in the automation job.

The crash based on the dump occurs while dereferencing a NULL message filter, which means that we received
a read request for a disconnected/terminated job. This happens when a request is paused while waiting for
the renderer to ack sent data packets 

Following fixes:-
1. NULL check the message_filter pointer before dereferencing it in URLRequestAutomationJob::ReadRawData.
2. Only complete the job when we receive a Read request for it or if we have a pending read.

Added ASSERTS in OnDataAvailable to check if we receive unexpected data.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=34819

Bug=34819
Test=Covered by ui test.

Review URL: http://codereview.chromium.org/577033
------------------------------------------------------------------------
r38574 | viettrungluu@chromium.org | 2010-02-10 05:26:23 +0100 (Wed, 10 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Mac: fullscreen mode work (still not enabled).

Change the way different things ensure the floating bar is visible. The new
model is that things can "lock bar visibility" (and this locking can continue
even outside fullscreen mode). Set up explicit timers for showing/hiding.

BUG=31638
TEST=Things still work normally.

Review URL: http://codereview.chromium.org/587015
------------------------------------------------------------------------
r38573 | tony@chromium.org | 2010-02-10 04:59:11 +0100 (Wed, 10 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_field.cc
   M /trunk/src/chrome/browser/form_field_history_manager.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc

Revert "Move conditions of FormFields creation to FormFieldHistoryManager;
AutoFill does not have the same conditions.  This required manipulating
the FormField data structure to add necessary field data."

This reverts commit r38570.

TBR=jhawkins

Review URL: http://codereview.chromium.org/602014
------------------------------------------------------------------------
r38570 | jhawkins@chromium.org | 2010-02-10 04:06:54 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_field.cc
   M /trunk/src/chrome/browser/form_field_history_manager.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc

Move conditions of FormFields creation to FormFieldHistoryManager; AutoFill does not have the same conditions.  This required manipulating the FormField data structure to add necessary field data.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/602008
------------------------------------------------------------------------
r38568 | pkasting@chromium.org | 2010-02-10 03:14:46 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Try to make spacing/indenting of Privacy section clearer.

BUG=35088
TEST=Open preferences window, go to third page, top two buttons shouldn't look related to stuff below them.
Review URL: http://codereview.chromium.org/598030
------------------------------------------------------------------------
r38563 | pkasting@chromium.org | 2010-02-10 02:21:50 +0100 (Wed, 10 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Remove descriptive text above import settings button.  This also removes it for GTK, although GTK has not yet moved the Clear Data button to the third page of the options.

This also eliminates a number of not-referenced strings, and makes the options dialog shorter now that we have the space to do so.

BUG=35085
TEST=Open options dialog, look on second page, Import button should have no text above it.
Review URL: http://codereview.chromium.org/597013
------------------------------------------------------------------------
r38561 | pkasting@chromium.org | 2010-02-10 02:19:55 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc

Make sure there's padding between the "manage" link and the close button, even for short hostnames.

BUG=35083
TEST=Visit b/ with image blocking on, click the content blocked icon, bottom link and button shouldn't be smashed together.
Review URL: http://codereview.chromium.org/593030
------------------------------------------------------------------------
r38560 | estade@chromium.org | 2010-02-10 02:06:07 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc

GTK: fix DCHECK triggered when multiple ExtensionPopupGtks existed concurrently.

BUG=35211
TEST=see bug

Review URL: http://codereview.chromium.org/601014
------------------------------------------------------------------------
r38559 | estade@chromium.org | 2010-02-10 02:05:55 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.h

GTK: Close extension popup when its browser window changes the focus widget.

BUG=29375
TEST=see bug

Review URL: http://codereview.chromium.org/594020
------------------------------------------------------------------------
r38558 | jianli@chromium.org | 2010-02-10 02:04:37 +0100 (Wed, 10 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disable DownloadTest.DownloadMimeType for now.

BUG=none
TEST=none
TBR=mpcomplete

Review URL: http://codereview.chromium.org/595015
------------------------------------------------------------------------
r38555 | arv@chromium.org | 2010-02-10 02:00:29 +0100 (Wed, 10 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js

Make it so that chrome.bookmarks.update can update the URL of a bookmark.

This changes the API slightly. Previously, if someone called update with an empty object ({}) it would set the title to "". This was only documented in the code and not on the API page. Now that we support updating both the url and title it seems more reasonable to ignore a missing title.

BUG=34841
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks

Review URL: http://codereview.chromium.org/591006
------------------------------------------------------------------------
r38553 | andybons@chromium.org | 2010-02-10 01:47:13 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc

[Mac] Enables extension browser tests previously disabled for the mac due to lack of implementation.

BUG=29898
TEST=Run ExtensionBrowserTest.* and PageActionPopupTest.* and make sure they all pass.
Review URL: http://codereview.chromium.org/601011
------------------------------------------------------------------------
r38549 | atwilson@chromium.org | 2010-02-10 01:09:01 +0100 (Wed, 10 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   A /trunk/src/chrome/test/data/workers/many_shared_workers.html
   A /trunk/src/chrome/test/data/workers/queued_shared_worker_shutdown.html
   A /trunk/src/chrome/test/data/workers/shutdown_shared_worker.html
   A /trunk/src/chrome/test/data/workers/single_shared_worker.html
   A /trunk/src/chrome/test/data/workers/worker_close.html
   M /trunk/src/chrome/test/data/workers/worker_common.js
   M /trunk/src/chrome/worker/worker_uitest.cc

Changed CreateWorker to coalesce any matching queued shared workers when a
shared worker is started.

Added tests for worker close and queued shared worker cases.
BUG=29998
TEST=new UI tests added.

Review URL: http://codereview.chromium.org/580007
------------------------------------------------------------------------
r38545 | jianli@chromium.org | 2010-02-10 01:00:32 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/download_file_interface.h
   M /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data.h
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/app/os_exchange_data_provider_win.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   A /trunk/src/chrome/browser/download/drag_download_file.cc (from /trunk/src/chrome/browser/download/drag_download_file_win.cc:38135)
   A /trunk/src/chrome/browser/download/drag_download_file.h (from /trunk/src/chrome/browser/download/drag_download_file_win.h:38135)
   D /trunk/src/chrome/browser/download/drag_download_file_win.cc
   D /trunk/src/chrome/browser/download/drag_download_file_win.h
   A /trunk/src/chrome/browser/download/drag_download_util.cc
   A /trunk/src/chrome/browser/download/drag_download_util.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webdropdata.cc
   M /trunk/src/webkit/glue/webdropdata.h

Refactor DragDownloadFile so that it can be used by both Windows and MacOSX.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/572014
------------------------------------------------------------------------
r38541 | erg@chromium.org | 2010-02-10 00:32:24 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak

Revert r38006 and r38018 to try to fix the mac perf regression.

BUG=34755,34078
TEST=none

Review URL: http://codereview.chromium.org/600026
------------------------------------------------------------------------
r38536 | pkasting@chromium.org | 2010-02-10 00:25:49 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/content_settings.h

Whitelist all content for various internal schemes.

BUG=34805
TEST=New Tab page should still work if you disable script + images
Review URL: http://codereview.chromium.org/588011
------------------------------------------------------------------------
r38535 | estade@chromium.org | 2010-02-10 00:22:38 +0100 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

GTK: don't show drag indicator for invalid drags over recently added/search rows in bookmark manager.

BUG=32239
TEST=manual

Review URL: http://codereview.chromium.org/587010
------------------------------------------------------------------------
r38534 | pkasting@chromium.org | 2010-02-10 00:22:20 +0100 (Wed, 10 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/test/test_browser_window.h

Make the content settings dialog dependent on its parent.  This re-plumbs the "show" function to work more like a number of our other dialogs (i.e. delcared in browser_dialogs.h), and adds a TabContentsDelegate function so the content blocked info bubbles can ask the appropriate window to show the dialog.

BUG=35084
TEST=Open the content settings dialog from either the options or a content blocked info bubble. Click its parent window.  The dialog should stay on top of the parent.
Review URL: http://codereview.chromium.org/597009
------------------------------------------------------------------------
r38533 | johnnyg@chromium.org | 2010-02-10 00:16:56 +0100 (Wed, 10 Feb 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/notifications
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/renderer/render_thread.cc

Desktop Notifications for the mac

BUG=23066
TEST=notify_demo.html


Review URL: http://codereview.chromium.org/548208
------------------------------------------------------------------------
r38530 | davemoore@chromium.org | 2010-02-09 23:55:28 +0100 (Tue, 09 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/defaults.cc

Added SignOut for chromium OS.

Review URL: http://codereview.chromium.org/548221
------------------------------------------------------------------------
r38527 | darin@chromium.org | 2010-02-09 23:41:20 +0100 (Tue, 09 Feb 2010) | 22 lines
Changed paths:
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   A /trunk/src/chrome/browser/renderer_host/render_view_host_notification_task.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Trigger the blocked cookie notification UI.

This change involves two significant bits:

1- Add URLRequest::Delegate methods to report a blocked attempt to set a cookie
or get cookies, respectively.

2- Generalize the mechanisms we use to proxy notifications to the RenderViewHost
from the IO thread.  See render_view_host_notification_task.h.

Finally, these are used together in ResourceDispatcherHost.

Note: Additional work is required to notify when JS attempts to set a cookie
fail.

R=brettw,eroman
BUG=34573
TEST=Configure the browser to block cookies, and then visit a site that tries to
set a cookie (e.g., cnn.com).  You should see a cookie icon appear in the location
bar.  If you click that it should report that cookies were blocked.

Review URL: http://codereview.chromium.org/600009
------------------------------------------------------------------------
r38524 | avi@chromium.org | 2010-02-09 23:34:19 +0100 (Tue, 09 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Revert r38514; huge startup hit.

------------------------------------------------------------------------
r38520 | stuartmorgan@chromium.org | 2010-02-09 23:12:06 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Don't send frame update messages for non-browser RWHVs

BUG=35141
TEST=Trigger an autocomplete popup; watch the renderer not crash.

Review URL: http://codereview.chromium.org/594015
------------------------------------------------------------------------
r38518 | chron@google.com | 2010-02-09 23:00:06 +0100 (Tue, 09 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   A /trunk/src/chrome/browser/sync/engine/syncapi_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_columns.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Added UNIQUE_CLIENT_TAG to sync engine. Added some syncapi unit tests. Added new index to syncable. Added new DB col to syncable. Renamed singleton tag to UNIQUE_CLIENT_TAG. Added syncapi layer support for unique client tags.

Hooked up wire protocol to use this index.
Downintegrate of sync.proto from trunk.

TEST=unit tests included
BUG=32636

Review URL: http://codereview.chromium.org/558015
------------------------------------------------------------------------
r38516 | pkasting@chromium.org | 2010-02-09 22:58:22 +0100 (Tue, 09 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/exceptions_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_view.h

Prevent the user from triggering multiple copies of a particular exceptions window.

BUG=34692
TEST=Open the content settings dialog to any page, hit "Exceptions", move the exceptions window and hit "Exceptions" again; we shouldn't spawn another window.
Review URL: http://codereview.chromium.org/596020
------------------------------------------------------------------------
r38515 | wtc@chromium.org | 2010-02-09 22:55:51 +0100 (Tue, 09 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/client_socket_factory.cc
   M /trunk/src/net/socket/client_socket_factory.h
   A /trunk/src/net/socket/ssl_client_socket_nss_factory.h (from /trunk/src/net/socket/client_socket_factory.h:37931)

Add the ssl_client_socket_nss_factory.h header and declare
the SSLClientSocketNSSFactory function there.

Put the --use-nss-for-ssl command-line switch inside ifdefs
for the platforms that need it.

Call EnsureNSPRInit on the main thread so that PR_Cleanup
will be called on the main thread.

R=mark
BUG=28744
TEST=No build errors.
Review URL: http://codereview.chromium.org/573041
------------------------------------------------------------------------
r38514 | avi@chromium.org | 2010-02-09 22:55:21 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Allow opacity in themes.

BUG=http://crbug.com/34855
TEST=as in bug

Review URL: http://codereview.chromium.org/600021
------------------------------------------------------------------------
r38513 | tim@chromium.org | 2010-02-09 22:48:04 +0100 (Tue, 09 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h

Make SyncerThread stop polling if an AUTH_INVALID response is parsed.

BUG=34396
TEST=SyncerTHreadWithSyncerTest.AuthInvalid


Review URL: http://codereview.chromium.org/596007
------------------------------------------------------------------------
r38512 | davemoore@chromium.org | 2010-02-09 22:40:29 +0100 (Tue, 09 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/page_menu_model.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Add back disabled menu items
Bug=chromiumos:1275
Test=There should be no "Create Application Shortcuts" menu item.
All others should be the same as Chrome, except that Print...
should be disabled. This is true for both the page menu and the
content area menu.

Review URL: http://codereview.chromium.org/596014
------------------------------------------------------------------------
r38509 | arv@chromium.org | 2010-02-09 22:27:55 +0100 (Tue, 09 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc

Implement BookmarkModel::SetUrl

BUG=10603
TEST=*_test.exe --gtest_filter=*Bookmark*
     Also manually tested changing the URL through the bookmarks extension API, bookmark manager, bookmark bar and saw it update in all places and correctly sync to another chrome instance.

Review URL: http://codereview.chromium.org/582022
------------------------------------------------------------------------
r38508 | akalin@chromium.org | 2010-02-09 22:15:41 +0100 (Tue, 09 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Moved all sync-related command-line logic to profile_sync_service.

Moved --invalidate-sync-login switch logic to profile_sync_service.

Removed unneeded command_line.h includes.

BUG=none
TEST=trybots, manual

Review URL: http://codereview.chromium.org/582017
------------------------------------------------------------------------
r38504 | rsesek@chromium.org | 2010-02-09 22:04:28 +0100 (Tue, 09 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.h
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] Add local storage nodes to the cookie manager

* Add local storage getters to CookieTreeNode
* XIB: Embed cookie info labels into an NSView (inside the NSBox) and add
  another for info NSView for local storage.
* Roll GTM r280:293

BUG=33068
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Find and click on a local storage node. Info should be displayed.

Review URL: http://codereview.chromium.org/599003
------------------------------------------------------------------------
r38500 | sky@chromium.org | 2010-02-09 21:54:48 +0100 (Tue, 09 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc

Fixes leak in cookie filter page view and clear browsing data view
that lead to chrome not shutting down.

BUG=34941
TEST=bring up clear browsing data dialog, click on link, close
  windows, make sure no chrome processes still around.

Review URL: http://codereview.chromium.org/594012
------------------------------------------------------------------------
r38499 | dhg@chromium.org | 2010-02-09 21:54:24 +0100 (Tue, 09 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixing html for filebrowser
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/588013
------------------------------------------------------------------------
r38493 | johnnyg@chromium.org | 2010-02-09 21:09:01 +0100 (Tue, 09 Feb 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/notifications
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/renderer/render_thread.cc

Revert 38469 - Desktop Notifications for the mac!

BUG=23066
TEST=notify_demo.html

Review URL: http://codereview.chromium.org/548208

TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/600015
------------------------------------------------------------------------
r38490 | nick@chromium.org | 2010-02-09 20:42:34 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc

Mark dirty in PutParentIdPropertyOnly.

BUG=33081
TEST=none

Review URL: http://codereview.chromium.org/594010
------------------------------------------------------------------------
r38486 | zelidrag@chromium.org | 2010-02-09 20:14:05 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/modal_dialog_delegate.cc

Potential fix for reliability test crash.

BUG=34971
TEST=run reliabilty tests

Review URL: http://codereview.chromium.org/588001
------------------------------------------------------------------------
r38485 | dpolukhin@chromium.org | 2010-02-09 20:11:18 +0100 (Tue, 09 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   A /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.cc
   A /trunk/src/chrome/browser/chromeos/login/rounded_rect_painter.h
   M /trunk/src/chrome/chrome_browser.gypi

Fixed cropping issue for round rect shadow.
Moved RoundRectPainter to common place to be reusable in other login screens.

BUG=none
TEST=Tested login screen.

Review URL: http://codereview.chromium.org/587001
------------------------------------------------------------------------
r38483 | jhawkins@chromium.org | 2010-02-09 20:05:18 +0100 (Tue, 09 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Check for personal_data_ being NULL, as this is the case when we're OTR.

BUG=35051
TEST=none
Review URL: http://codereview.chromium.org/596015
------------------------------------------------------------------------
r38479 | jhawkins@chromium.org | 2010-02-09 19:52:50 +0100 (Tue, 09 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Send forms seen in the renderer to the AutoFillManager.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/584009
------------------------------------------------------------------------
r38472 | nick@chromium.org | 2010-02-09 18:41:51 +0100 (Tue, 09 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/process_commit_response_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/sync/engine/syncer_command_test.h

Fix a bug where positions inside of a newly-committed folder would be
reversed if the children of the folder weren't committed in the same
batch as the folder.

Refactor ApplyUpdatesCommandTest, pulling out functionality that would
be useful for any SyncerCommand test, into syncer_command_test.h.

Add a test case for ProcessCommitResponseCommand using the new
SyncerCommandTest framework.  Add a test for the bug.

BUG=33081
TEST=sync_unit_tests. Also, manual testing, using the reduced repro
instructions described in comment #26 of the bug.

Review URL: http://codereview.chromium.org/572021
------------------------------------------------------------------------
r38469 | johnnyg@chromium.org | 2010-02-09 18:21:06 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/notifications
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_controller.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_bridge.mm
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.h
   A /trunk/src/chrome/browser/cocoa/notifications/balloon_view_host_mac.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/renderer/render_thread.cc

Desktop Notifications for the mac!

BUG=23066
TEST=notify_demo.html

Review URL: http://codereview.chromium.org/548208
------------------------------------------------------------------------
r38467 | phajdan.jr@chromium.org | 2010-02-09 15:38:08 +0100 (Tue, 09 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Do the remaining renames after http://codereview.chromium.org/585008

TBR=brettw
TEST=you can possibly break the tree, right?
BUG=none

Review URL: http://codereview.chromium.org/602002
------------------------------------------------------------------------
r38464 | phajdan.jr@chromium.org | 2010-02-09 12:49:14 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Fix Linux/views/ChromeOS build. There are two tab_contents_view_gtk.cc files
in the tree, and earlier I only fixed one. This fixes the second one.

TBR=brettw

Review URL: http://codereview.chromium.org/602001
------------------------------------------------------------------------
r38463 | phajdan.jr@chromium.org | 2010-02-09 12:36:16 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/child_process_security_policy_browser_test.cc
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_processes_api.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/form_field_history_manager.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/ui_test_utils.cc

[GTTF] Reduce header dependencies in chrome.

BUG=none
TEST=If it compiles it is perfect.

Review URL: http://codereview.chromium.org/585008
------------------------------------------------------------------------
r38461 | phajdan.jr@chromium.org | 2010-02-09 11:30:25 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host.h
   M /trunk/src/webkit/appcache/appcache_request_handler.h
   M /trunk/src/webkit/appcache/appcache_request_handler_unittest.cc
   M /trunk/src/webkit/appcache/appcache_response_unittest.cc
   M /trunk/src/webkit/appcache/appcache_storage.cc
   M /trunk/src/webkit/appcache/appcache_storage.h
   M /trunk/src/webkit/appcache/appcache_storage_impl_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/appcache_url_request_job.cc
   M /trunk/src/webkit/appcache/appcache_url_request_job_unittest.cc
   M /trunk/src/webkit/glue/bookmarklet_unittest.cc
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/plain_text_controller.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

[GTTF] Reduce header dependencies in webkit

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/582015
------------------------------------------------------------------------
r38456 | phajdan.jr@chromium.org | 2010-02-09 09:14:38 +0100 (Tue, 09 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   D /trunk/src/base/directory_watcher.h
   D /trunk/src/base/directory_watcher_inotify.cc
   D /trunk/src/base/directory_watcher_mac.cc
   D /trunk/src/base/directory_watcher_stub.cc
   D /trunk/src/base/directory_watcher_unittest.cc
   D /trunk/src/base/directory_watcher_win.cc
   M /trunk/src/base/mac_util_unittest.mm
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/profile.cc

Remove DirectoryWatcher and the only thing using it.

DirectoryWatcher was problematic. We couldn't get it right on Linux,
it can hit the disk on UI thread on Windows (Really Bad, tm). And
finally, the UserScriptMaster didn't work right with it.

TEST=Covered by unit_tests and browser_tests
BUG=8968, 6051, 6080, 20832

Review URL: http://codereview.chromium.org/586010
------------------------------------------------------------------------
r38446 | thakis@chromium.org | 2010-02-09 06:55:50 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Fix browser crash.

BUG=34147
TEST=Fewer crash reports in RenderWidgetHost::ForwardInputEvent

Review URL: http://codereview.chromium.org/598005
------------------------------------------------------------------------
r38441 | jochen@chromium.org | 2010-02-09 04:38:20 +0100 (Tue, 09 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc

Close deleting browsing data window after deleting data.

This behavior was disabled by debugging code introduced in r38379

BUG=none
TEST=delete browsing data on windows. The dialog should close eventually.
R=sky

Review URL: http://codereview.chromium.org/595003
------------------------------------------------------------------------
r38440 | mattm@chromium.org | 2010-02-09 04:08:38 +0100 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/certificate_viewer.cc

Linux: Use fixed width font for certificate details.

BUG=18119
TEST=open cert info, look at details

Review URL: http://codereview.chromium.org/596005
------------------------------------------------------------------------
r38432 | pkasting@chromium.org | 2010-02-09 02:44:30 +0100 (Tue, 09 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc

Remember the last selected tab in the content settings dialog.

BUG=35068
TEST=Open content settings dialog, select a different tab, close and reopen it, the same tab should be selected.
Review URL: http://codereview.chromium.org/596003
------------------------------------------------------------------------
r38409 | estade@chromium.org | 2010-02-09 00:09:10 +0100 (Tue, 09 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

GTK: use appropriate bookmark manager menus

also, always show cut/copy/paste for bookmark menus (see bug 32064)
also, don't add "Show in folder" on menus that aren't going to enable it anyway

BUG=32830
TEST=manual

Review URL: http://codereview.chromium.org/580018
------------------------------------------------------------------------
r38407 | finnur@chromium.org | 2010-02-08 23:58:31 +0100 (Mon, 08 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   A /trunk/src/chrome/browser/extensions/extension_toolbar_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/none
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/none/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/none/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/none/manifest.json

Preserve order of extensions when they auto-update.

Also added tests for the ExtensionToolbarModel.

BUG=33401
TEST=ExtensionToolbarModelTest (new test).

Review URL: http://codereview.chromium.org/587002
------------------------------------------------------------------------
r38402 | jar@chromium.org | 2010-02-08 23:15:54 +0100 (Mon, 08 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h

Add IPv6 probing support, and disable IPv6 resolution when it is useless 

I've added minimal probing to check if IPv6 is at all possible, and when it is not, then we disable IPv6 resolution. 

I've also added histograms and A/B test support to evaluate the impact of 
this change. 

(I landed originally, but had tree problems, and this is a new CL to tryto reland).

Note that I've switched back to MACRO style enums as well, per http://dev.chromium.org/developers/coding-style
(search for "enum").

This version now does the conditional testing at a higher level (in io_thread.h), so that it should interfere less with other testing.

r=wtc,eroman 
Review URL: http://codereview.chromium.org/585005
------------------------------------------------------------------------
r38398 | georgey@chromium.org | 2010-02-08 22:49:55 +0100 (Mon, 08 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Changed validation based on the discussion
TEST="Save" is always enabled, if user changes address/CC label it changes to "Address"/"Credit Card" after saving 
BUG=33026
Review URL: http://codereview.chromium.org/577037
------------------------------------------------------------------------
r38396 | sky@chromium.org | 2010-02-08 22:42:43 +0100 (Mon, 08 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Fixes bug where we weren't sending out TabClosingAt when removing a
tab as a result of uninstalling an extension.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/580011
------------------------------------------------------------------------
r38395 | sky@chromium.org | 2010-02-08 22:30:29 +0100 (Mon, 08 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Changes TabStrip's drop indicator not to allow dropping on
mini-tabs.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/587005
------------------------------------------------------------------------
r38394 | phajdan.jr@chromium.org | 2010-02-08 22:28:31 +0100 (Mon, 08 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc

Update bug reference link in ExtensionApiTest.Toolstrip

TBR=erikkay
TEST=no code change
BUG=30151, 35034

Review URL: http://codereview.chromium.org/580015
------------------------------------------------------------------------
r38393 | darin@chromium.org | 2010-02-08 22:10:55 +0100 (Mon, 08 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cookie_modal_dialog.cc
   M /trunk/src/chrome/browser/cookie_modal_dialog.h
   M /trunk/src/chrome/browser/cookie_modal_dialog_views.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/message_box_handler.cc
   M /trunk/src/chrome/browser/message_box_handler.h
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   M /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/views/cookie_info_view.cc
   M /trunk/src/chrome/browser/views/cookie_info_view.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h

Show an app modal dialog when the cookie policy is ASK.

This hooks up the dialog for cookies and localstorage.  It also includes
support for remembering the decision, and in the case of cookies, support is
added for forcing a cookie to be a stored as a session cookie.

BUG=34625,34572

Review URL: http://codereview.chromium.org/583004
------------------------------------------------------------------------
r38392 | neb@chromium.org | 2010-02-08 22:08:19 +0100 (Mon, 08 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_devices.h

Implement low-latency audio on Pepper.

BUG=28292
TEST=none

Review URL: http://codereview.chromium.org/577019
------------------------------------------------------------------------
r38391 | phajdan.jr@chromium.org | 2010-02-08 21:52:16 +0100 (Mon, 08 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc

Disable ExtensionApiTest.Toolstrip, crashy.

TBR=erikkay
TEST=stop crashing
BUG=30151

Review URL: http://codereview.chromium.org/588004
------------------------------------------------------------------------
r38388 | pkasting@chromium.org | 2010-02-08 21:46:00 +0100 (Mon, 08 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc

Set the initial state of the content blocked bubble radio buttons correctly.

BUG=34781
TEST=Go to a page where content is blocked, open the bubble, change the radio button to "allow", open the bubble again, and make sure it's still "allow".
Review URL: http://codereview.chromium.org/587003
------------------------------------------------------------------------
r38386 | mbelshe@chromium.org | 2010-02-08 21:37:30 +0100 (Mon, 08 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/load_log_event_type_list.h
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_bitmasks.h
   M /trunk/src/net/spdy/spdy_frame_builder.cc
   M /trunk/src/net/spdy/spdy_frame_builder.h
   M /trunk/src/net/spdy/spdy_framer.cc
   M /trunk/src/net/spdy/spdy_framer.h
   M /trunk/src/net/spdy/spdy_framer_test.cc
   M /trunk/src/net/spdy/spdy_io_buffer.cc
   M /trunk/src/net/spdy/spdy_io_buffer.h
   M /trunk/src/net/spdy/spdy_network_transaction.cc
   M /trunk/src/net/spdy/spdy_network_transaction.h
   M /trunk/src/net/spdy/spdy_network_transaction_unittest.cc
   M /trunk/src/net/spdy/spdy_protocol.h
   M /trunk/src/net/spdy/spdy_protocol_test.cc
   M /trunk/src/net/spdy/spdy_session.cc
   M /trunk/src/net/spdy/spdy_session.h
   M /trunk/src/net/spdy/spdy_session_pool.cc
   M /trunk/src/net/spdy/spdy_session_pool.h
   M /trunk/src/net/spdy/spdy_session_unittest.cc
   M /trunk/src/net/spdy/spdy_stream.cc
   M /trunk/src/net/spdy/spdy_stream.h
   M /trunk/src/net/spdy/spdy_stream_unittest.cc
   M /trunk/src/net/spdy/spdy_transaction_factory.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

The great Flip -> Spdy rename.

BUG=30747
TEST=none

Review URL: http://codereview.chromium.org/580009
------------------------------------------------------------------------
r38380 | estade@chromium.org | 2010-02-08 21:10:32 +0100 (Mon, 08 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: support dynamic labels in GtkMenus

BUG=32115
TEST=show app menu, then toggle bookmark sync (on->off or off->on), show app menu again and confirm that the sync label has changed

Review URL: http://codereview.chromium.org/573037
------------------------------------------------------------------------
r38379 | sky@chromium.org | 2010-02-08 21:06:11 +0100 (Mon, 08 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/dialog_delegate.h

Fixes bug in clear browsing data dialog where throbber would overlap
flash link.

BUG=35009
TEST=bring up clear browsing data, click clear browsing data and make
     sure throbber doesn't overlap flash link.

Review URL: http://codereview.chromium.org/577054
------------------------------------------------------------------------
r38372 | estade@chromium.org | 2010-02-08 19:56:54 +0100 (Mon, 08 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

accept NETSCAPE_URL drags in gtk tabstrip

BUG=34141
TEST=see bug

Review URL: http://codereview.chromium.org/570044
------------------------------------------------------------------------
r38371 | estade@chromium.org | 2010-02-08 19:56:29 +0100 (Mon, 08 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   A /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.cc
   A /trunk/src/chrome/browser/views/bookmark_context_menu_controller_views.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/chrome_browser.gypi

Bookmark context menu unforking:

- create cross-platform BookmarkContextMenuController
- use the new class on GTK (replacing BookmarkContextMenuControllerGtk)
- keep using the old class on views (now named BookmarkContextMenuControllerViews)
- add tests for the new BookmarkContextMenuController

Review URL: http://codereview.chromium.org/577016
------------------------------------------------------------------------
r38369 | shess@chromium.org | 2010-02-08 19:47:16 +0100 (Mon, 08 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Fix valgrind AutocompleteTextFieldTest.

http://codereview.chromium.org/577028 caught the change to the cell
unit test, but didn't catch the field version.  Pull in that change.

BUG=34110
TEST=Valgrind stops complaining.

Review URL: http://codereview.chromium.org/570061
------------------------------------------------------------------------
r38364 | joth@chromium.org | 2010-02-08 17:20:03 +0100 (Mon, 08 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc

Fix flaky win32 wifi provider test.
There was a race condition in provider startup; first call back might arrive before the listener was registerd.
This was previous hidden by fact that - until r37850 - an empty wifi result set was always condidered 'different' to another set and so it would create constant stream of update callbacks (hiding the fact the first one maybe missed)

BUG=http://crbug.com/34832
TEST=unit_tests.exe  --gtest_filter=Win32* --gtest_repeat=10000 --gtest_break_on_failure


Review URL: http://codereview.chromium.org/577047
------------------------------------------------------------------------
r38363 | sky@chromium.org | 2010-02-08 17:06:29 +0100 (Mon, 08 Feb 2010) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Fixes crash in making a tab phantom. Here was the sequence when making
a tab phantom:
1. close the old contents (sending out TabClosingAt).
2. TabSelectedAt
3. TabReplatedAt

The problem is is Browser::TabSelectedAt processes updates for the old
contents, resulting in:

1. close the old contents (sending out TabClosingAt).
2. TabSelectedAt
a    UpdateTabContentsStateAt (for old tabcontents)
b    TabChangedAt             (for old tabcontents)
3. TabReplatedAt

So, 2b is sent for a tabcontents that observers was already told
closed in step 1. This triggered a DCHECK in extensions code.

I've changed it so we send out TabSelectedAt after the new contents
are swapped in.

I also fixed a bug where I wasn't telling observers the tab strip
empty if the last non-phantom tab is made phantom.

BUG=34137
TEST=none

Review URL: http://codereview.chromium.org/579024
------------------------------------------------------------------------
r38362 | nkostylev@google.com | 2010-02-08 17:02:56 +0100 (Mon, 08 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Export bookmark favicon (base64 encoded png). 
Code for importing icons from bookmarks HTML file is already in place.

BUG=11362
TEST=Export bookmarks to HTML file, delete all existing bookmarks, import file.

Review URL: http://codereview.chromium.org/543202
------------------------------------------------------------------------
r38361 | stuartmorgan@chromium.org | 2010-02-08 16:52:13 +0100 (Mon, 08 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Send window frame information to Mac plugins via IPC

Sends any window frame and relevent content view location changes to the plugin process via IPC, so that the plugin process always knows where the plugin is rather than only knowing when the mouse is within the plugin area. This will be necessary for supporting NPN_ConvertPoint, and for supporting Java2 as currently implemented.

Related changes:
- Now that window information is being sent on init and un-hide, use that to get correct initial window focus information.
- Add a missing window focus change notification uncovered by the above.
- Use live mouse location for idle events, instead of a cached location, now that we have live plugin frame information.
- Refactor and simplify the logic for moving the plugin.

Note that containing_window_frame_ is currently unused, but will be shortly for NPN_ConvertPoint, and is so closely related to the added IPC that I added it now rather than having to immediately change the new messages and functions.

BUG=34046,31858,31543,29457
TEST=Mouse tracking in Carbon plugins should still work correctly, even across window moves, info/bookmark bar show/hides, etc. (Automated tests of location tracking will follow shortly with full NPN_ConvertPoint implementation.)

Review URL: http://codereview.chromium.org/573015
------------------------------------------------------------------------
r38355 | phajdan.jr@chromium.org | 2010-02-08 15:31:53 +0100 (Mon, 08 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc

Mark ExtensionApiTest.ExecuteScript DISABLED because it's not only flaky,
but crashy and it has been ignored for weeks!

It's EXTREMELY flaky, #1 flaky test of all time with over 600 flips
in the last three weeks. This test seriously needs some love.

TBR=rafaelw
TEST=none
BUG=28630

Review URL: http://codereview.chromium.org/574030
------------------------------------------------------------------------
r38354 | joth@chromium.org | 2010-02-08 14:17:26 +0100 (Mon, 08 Feb 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Hopefully final attempt at landing http://src.chromium.org/viewvc/chrome?view=rev&revision=38207
Adds tests for network geolocation provider.

In the end, it seems templated static methods cannot be called from gtest's SetUp method on a Mac Release build. Beats me. I'm doing my stuff in the c'tor for now, and made a note to come back to it.

BUG=http://crbug.com/11246 
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure 


Review URL: http://codereview.chromium.org/578017
------------------------------------------------------------------------
r38347 | suzhe@chromium.org | 2010-02-08 10:29:54 +0100 (Mon, 08 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Fix issue 34343: "Tab to search" hint on omnibox disappears on drag dropped tab.

BUG=34343
TEST=Input www.google.com to trigger "tab to search" hint, then drag the tab into a new window, then check if "tab to search" hint is still there.

Review URL: http://codereview.chromium.org/576013
------------------------------------------------------------------------
r38345 | satorux@chromium.org | 2010-02-08 09:02:12 +0100 (Mon, 08 Feb 2010) | 14 lines
Changed paths:
   M /trunk/src/build/all.gyp
   A /trunk/src/chrome/browser/chromeos/text_input
   A /trunk/src/chrome/browser/chromeos/text_input/candidate_window.cc
   A /trunk/src/chrome/browser/chromeos/text_input/text_input.gyp

Move candidate_window from third_party/chromeos_text_input to chrome/browser/chromeos/text_input.

Turned out there is no benefit of having this in a separate git repository.

No code change in candidate_window.cc, but modified the copyright notice
from Chromium OS Authors to Chromium Authors.
Slightly modified text_input.gyp to make it compile.

We'll also change cros_deps/DEPS in a separate CL.

BUG=none
TEST=confirmed candidate_window compiles as before.

Review URL: http://codereview.chromium.org/579026
------------------------------------------------------------------------
r38330 | sky@chromium.org | 2010-02-07 18:23:14 +0100 (Sun, 07 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/app/animation.cc
   M /trunk/src/app/animation.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/grid.cc
   M /trunk/src/chrome/browser/views/tabs/grid.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Adds Animation::CurrentValueBetween and gets rid of a bunch of
duplicate code.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/570055
------------------------------------------------------------------------
r38327 | jar@chromium.org | 2010-02-07 08:04:05 +0100 (Sun, 07 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h

Revert 38323 - Add IPv6 probing support, and disable IPv6 resolution when it is useless

I've added minimal probing to check if IPv6 is at all possible, and when
it is not, then we disable IPv6 resolution.

I've also added histograms and A/B test support to evaluate the impact of
this change.

r=wtc,eroman
Review URL: http://codereview.chromium.org/579010

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/582011
------------------------------------------------------------------------
r38323 | jar@chromium.org | 2010-02-07 07:40:06 +0100 (Sun, 07 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h

Add IPv6 probing support, and disable IPv6 resolution when it is useless

I've added minimal probing to check if IPv6 is at all possible, and when
it is not, then we disable IPv6 resolution.

I've also added histograms and A/B test support to evaluate the impact of
this change.

r=wtc,eroman
Review URL: http://codereview.chromium.org/579010
------------------------------------------------------------------------
r38316 | ben@chromium.org | 2010-02-06 22:52:54 +0100 (Sat, 06 Feb 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc

fix bustage
------------------------------------------------------------------------
r38314 | ben@chromium.org | 2010-02-06 22:44:08 +0100 (Sat, 06 Feb 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc

fix bustage
------------------------------------------------------------------------
r38313 | ben@chromium.org | 2010-02-06 22:30:51 +0100 (Sat, 06 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h

Fix ChromeOS Bustage: Use string16 instead of wstring.

BUG=none
TEST=none
TBR=sky

Review URL: http://codereview.chromium.org/573048
------------------------------------------------------------------------
r38312 | ben@chromium.org | 2010-02-06 22:18:54 +0100 (Sat, 06 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   A /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.cc
   A /trunk/src/chrome/browser/views/tabs/browser_tab_strip_controller.h
   M /trunk/src/chrome/browser/views/tabs/side_tab.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab.h
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/chrome_browser.gypi

Make basic side tabs actually appear.

http://crbug.com/34509
TEST=none

Review URL: http://codereview.chromium.org/572041
------------------------------------------------------------------------
r38308 | jar@chromium.org | 2010-02-06 17:26:31 +0100 (Sat, 06 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Revert 38307 - Test to see if IPv6 can be disabled: Will roll back ASAP

This tests to see what happens if the command line option disables 
IPv6.  I will roll back as soon as the builders start.

TBR=eroman
Review URL: http://codereview.chromium.org/579022

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/579023
------------------------------------------------------------------------
r38307 | jar@chromium.org | 2010-02-06 17:24:20 +0100 (Sat, 06 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Test to see if IPv6 can be disabled: Will roll back ASAP

This tests to see what happens if the command line option disables 
IPv6.  I will roll back as soon as the builders start.

TBR=eroman
Review URL: http://codereview.chromium.org/579022
------------------------------------------------------------------------
r38301 | pkasting@chromium.org | 2010-02-06 06:15:03 +0100 (Sat, 06 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/native_frame_view.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Rework nonclient hittest plumbing so the NonClientFrameView is responsible for the whole window's hit testing.  Make use of this in the glass frame to add support for HTSYSMENU.  Doing this in the opaque frame will be more complex, so that's coming next.

BUG=6961
TEST=Single- and double-clicks on the upper left corner of a Chrome window in Aero glass mode should trigger the system menu and the window closing, respectively.
Review URL: http://codereview.chromium.org/573042
------------------------------------------------------------------------
r38300 | pkasting@chromium.org | 2010-02-06 06:10:55 +0100 (Sat, 06 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Change how the opaque frame lays out its titlebar.  This takes advantage of a system metric I didn't know about to both simplify the code and correctly handle (by which I mean "lay out more like a native window") the case when the user's theme has a large titlebar height but not a large titlebar font.

Doing this makes icon layout simpler and more native, which will help when trying to modify hittesting to return HTSYSMENU.

BUG=none
TEST=In Classic mode, setting the Active Title Bar height larger and then running Chrome should cause popup and app windows' icons to scale up like native windows' icons do.
Review URL: http://codereview.chromium.org/573040
------------------------------------------------------------------------
r38299 | shess@chromium.org | 2010-02-06 05:59:52 +0100 (Sat, 06 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Fix use-after-free when dragging tabs with page-actions.

When dragging and dropping a tab who's window is going away entirely, the LocationBarViewMac instance and the PageActionViewList w/in go away before the cell.  Sometimes windows can re-display while being closed, then BANG.

Converted page_action_view_list_ from a pointer because it didn't seem to need to be one anywhere.  Also plug leak of views_ elements.

BUG=34110
TEST=Install an extension which shows a page action (*).  Bring up two
tabs, drag one with the page action off to a separate window.  Drag it
back into the first window.

(*) For instance, the "Subscribe in Feed Reader" example at
http://code.google.com/chrome/extensions/samples.html , then browse to
Google News to get a page action.

Review URL: http://codereview.chromium.org/577028
------------------------------------------------------------------------
r38297 | avayvod@chromium.org | 2010-02-06 05:41:21 +0100 (Sat, 06 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h
   A /trunk/src/chrome/browser/chromeos/login/screen_observer.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi

Pass login-manager switch value to login wizard to determine which screen to
start with.
Refactored LoginObserver to ScreenObserver that could be used by other
screens as well.

BUG=34716
TEST=Currently there just should be no regression for Chrome based login
manager.
Review URL: http://codereview.chromium.org/574014
------------------------------------------------------------------------
r38296 | jochen@chromium.org | 2010-02-06 04:08:04 +0100 (Sat, 06 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Delete HTML5 database in BrowsingDataRemover, part 1.

This part deletes databases except for when they're currently used by a renderer.

BUG=34633
TEST=open the webkit html5 database demo, create some notes. close the tab. clear browsing data. open the demo again. notes should be gone.

Review URL: http://codereview.chromium.org/570032
------------------------------------------------------------------------
r38290 | hclam@chromium.org | 2010-02-06 01:51:17 +0100 (Sat, 06 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc

Disable a flaky unit test

This test is flaky and is disabled:
Win32WifiDataProviderTest.StartThreadViaDeviceDataProvider

BUG=34832
TEST=none
TBR=joth

Review URL: http://codereview.chromium.org/577036
------------------------------------------------------------------------
r38287 | sky@chromium.org | 2010-02-06 01:43:16 +0100 (Sat, 06 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Makes mini-tabs work on the UI side (at least for views). I still have
a handful of things to resolve before I turn on pinning.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/579011
------------------------------------------------------------------------
r38286 | feldstein@chromium.org | 2010-02-06 01:39:25 +0100 (Sat, 06 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement copy/paste of bookmarks for mac

Implements Copy, paste, and can paste as extension apis for use in the extension bookmark manager.

BUG=33461
TEST=Copy and paste single and multiple bookmarks in the extension bookmark manager, and between it safari's bookmark manager and plain text fields.

Review URL: http://codereview.chromium.org/562010
------------------------------------------------------------------------
r38285 | andybons@chromium.org | 2010-02-06 01:37:22 +0100 (Sat, 06 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix for bug where reloading an extension from an infobar when another window does not have that infobar open but has another crashed extension's infobar hoses the browser. Phew.

BUG=34683
TEST=follow repro steps in bug. should not crash.

Review URL: http://codereview.chromium.org/572045
------------------------------------------------------------------------
r38284 | jhawkins@chromium.org | 2010-02-06 01:32:42 +0100 (Sat, 06 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc

Remove the AutoFillManager as an observer of the PersonalDataManager in the constructor.  In rare circumtances, the user can close the browser (and shutdown the AutoFillManager) after we've set ourselves as observers of the PersonalDataManager and before the PersonalDataManager has called us back.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/579013
------------------------------------------------------------------------
r38281 | xiyuan@chromium.org | 2010-02-06 01:16:40 +0100 (Sat, 06 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/app_menu_model.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc

Rebuild app menu in ToolbarView::RunAppMenu

When "enable-udd-profiles" switch is set, update profile submenu and
rebuild app menu if necessary.

BUG=30417
TEST=Verify that comment 5 in issue 30417 is fixed.

Review URL: http://codereview.chromium.org/571015
------------------------------------------------------------------------
r38280 | shess@chromium.org | 2010-02-06 00:40:07 +0100 (Sat, 06 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Don't let omnibox popup text tighten while resizing.

Sets the tightening factor to 0.0 so that the popup text doesn't
tighten then rebound after being elided.

BUG=24296
TEST=Get the omnibox popup up, resize the window smaller, all the
left-hand-side text which stays should be rendered in a stable
position (right-hand-side text may shift as LHS text is elided, but
the spacing between characters should stay the same).

Review URL: http://codereview.chromium.org/577029
------------------------------------------------------------------------
r38279 | erg@chromium.org | 2010-02-06 00:35:20 +0100 (Sat, 06 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Revert debugging crud I added while trying to track down bug 31719.

Revert "Speculative fix for the windows theme crasher." (r36036)
Revert "More debugging statements to try to track down BrowserThemePack crash." (r37259).

BUG=31719
TEST=none

Review URL: http://codereview.chromium.org/573036
------------------------------------------------------------------------
r38278 | andybons@chromium.org | 2010-02-06 00:30:58 +0100 (Sat, 06 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   A /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h
   A /trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] o Adds a slight drop shadow to the drawn images within Browser Action buttons.
o Adds initial BrowserActionsContainerView class that simply draws a right border at this time but will be used for more complex UI later.
o Alters Toolbar.xib to use the new view class instead of a plain NSView.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/565048
------------------------------------------------------------------------
r38273 | avayvod@chromium.org | 2010-02-06 00:06:34 +0100 (Sat, 06 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   D /trunk/src/chrome/browser/views/star_toggle.cc
   D /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Added Star button to compact navigation mode.

BUG=32326
TEST=Switch Chrome to compact mode by pressing Ctrl-Shift-C. Test that Star
icon works.

Review URL: http://codereview.chromium.org/577026
------------------------------------------------------------------------
r38269 | jochen@chromium.org | 2010-02-05 23:50:41 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Check for the existance of a profile manager. Might not exist during early shutdown.

BUG=34652
TEST=Execute chrome. Run chrome --uninstall. Should not crash.

Review URL: http://codereview.chromium.org/572043
------------------------------------------------------------------------
r38268 | zelidrag@chromium.org | 2010-02-05 23:32:14 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/app_modal_dialog_win.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   A /trunk/src/chrome/browser/cookie_modal_dialog.cc
   A /trunk/src/chrome/browser/cookie_modal_dialog.h
   A /trunk/src/chrome/browser/cookie_modal_dialog_views.cc
   A /trunk/src/chrome/browser/cookie_prompt_modal_dialog_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   A /trunk/src/chrome/browser/js_modal_dialog.cc
   A /trunk/src/chrome/browser/js_modal_dialog.h
   A /trunk/src/chrome/browser/js_modal_dialog_gtk.cc
   A /trunk/src/chrome/browser/js_modal_dialog_mac.mm
   A /trunk/src/chrome/browser/js_modal_dialog_win.cc
   D /trunk/src/chrome/browser/jsmessage_box_handler.cc
   D /trunk/src/chrome/browser/jsmessage_box_handler.h
   A /trunk/src/chrome/browser/message_box_handler.cc (from /trunk/src/chrome/browser/jsmessage_box_handler.cc:38012)
   A /trunk/src/chrome/browser/message_box_handler.h (from /trunk/src/chrome/browser/jsmessage_box_handler.h:38012)
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/cookie_info_view.cc
   M /trunk/src/chrome/browser/views/cookie_info_view.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   A /trunk/src/chrome/browser/views/modal_dialog_delegate.cc
   A /trunk/src/chrome/browser/views/modal_dialog_delegate.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactored out JS specific part of modal dialog stack into its own class, exposed cookie/storage prompt as a modal dialog.

BUG=32719
TEST=none, requires Darin to hook this with his code.

Review URL: http://codereview.chromium.org/560030
------------------------------------------------------------------------
r38266 | evan@chromium.org | 2010-02-05 23:23:20 +0100 (Fri, 05 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/stack_container.h
   M /trunk/src/base/string_util.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/build/external_code.gypi
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autofill/address.cc
   M /trunk/src/chrome/browser/autofill/address_field.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/phone_number.cc
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/media/base/filters.h
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/printing/printed_document.h
   M /trunk/src/third_party/libjingle/files/talk/base/httpcommon.h
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/candidate.h
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/stunrequest.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/stunrequest.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/webkit/appcache/appcache_group.h

linux: build with -Wextra

95% of this is removing "const" from return types, but turning this
on found one bug!  (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)

BUG=34160

Review URL: http://codereview.chromium.org/570012
------------------------------------------------------------------------
r38263 | oshima@chromium.org | 2010-02-05 23:12:12 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc

Make open tab items check item.
  and fixed comment in simple_menu_model.h

BUG=chromium-os:1217
TEST=none

Review URL: http://codereview.chromium.org/575012
------------------------------------------------------------------------
r38258 | estade@chromium.org | 2010-02-05 23:02:47 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

GTK: Fix tab strip width calculation for RTL

BUG=34763
TEST=see bug

Review URL: http://codereview.chromium.org/579006
------------------------------------------------------------------------
r38257 | estade@chromium.org | 2010-02-05 23:02:36 +0100 (Fri, 05 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Toggle set-above property on bookmark bar event box when showing it.

BUG=34564
TEST=In both normal theme mode and gtk theme mode,
a) doesn't regress 33220
b) floating bookmark bar accepts input

Review URL: http://codereview.chromium.org/577005
------------------------------------------------------------------------
r38255 | oshima@chromium.org | 2010-02-05 23:02:18 +0100 (Fri, 05 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/notifications
   A /trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc
   A /trunk/src/chrome/browser/chromeos/notifications/balloon_view.h
   A /trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc
   A /trunk/src/chrome/browser/chromeos/notifications/notification_panel.h
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/chrome_browser.gypi

1st step to implement notification panel for chromeos
 - re-using views implementation, but removed layout related code
 - add NotificationPanel
 - added SetSize in BalloonViewHost. I needed this because I removed animation code and NativeViewHostGtk doesn't know about render view. I need to think a bit more to find out how to deal wit this.
 It's using existing balloon collection, but we may need one for chromeos (or may not).

BUG=33306
TEST=none

Review URL: http://codereview.chromium.org/572018
------------------------------------------------------------------------
r38251 | mattm@chromium.org | 2010-02-05 22:24:01 +0100 (Fri, 05 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc

Page Info dialog button HIG fixes.

All: Remove ellipses from IDS_PAGEINFO_CERT_INFO_BUTTON, as it does not require further action to display the info.
Add use_titlecase version.

Linux: Place button in the primary area instead of secondary to match HIG (I guess).

BUG=34425
TEST=read Gnome HIG (and MSDN "Command Buttons" guidelines), open Page Info for some page, compare

Review URL: http://codereview.chromium.org/561079
------------------------------------------------------------------------
r38248 | jochen@chromium.org | 2010-02-05 22:15:18 +0100 (Fri, 05 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h

When clearing browsing data modified since a certain time, do not delete extension data.

You can use the cookie tree model to really delete all data.

BUG=34598
TEST=install an extension that uses local storage, delete browsing data, check that the extension data still exist.

Review URL: http://codereview.chromium.org/573030
------------------------------------------------------------------------
r38246 | erg@chromium.org | 2010-02-05 22:10:38 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   A /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc
   A /trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/chrome_browser.gypi

GTK: Implement the new content blocking address bar bubbles on Linux.

BUG=33314
TEST=none

Review URL: http://codereview.chromium.org/573023
------------------------------------------------------------------------
r38245 | georgey@chromium.org | 2010-02-05 21:59:59 +0100 (Fri, 05 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.h

Added validation for non-emptiness of the label.
TEST=If any label (in address or credit card) is empty, the save button is disabled. Otherwise it is enabled.
BUG=33026
Review URL: http://codereview.chromium.org/575027
------------------------------------------------------------------------
r38243 | eroman@chromium.org | 2010-02-05 21:57:33 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/fixed_host_resolver.h
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/socket/socks_client_socket_unittest.cc

Remove the HostResolver::Shutdown() method.
While this doesn't entirely remove the hack, it limits the scope of it to HostResolverImpl.
Hopefully in the future HostResolver will not be refcounted so this can go away altogether.

BUG=18373

Review URL: http://codereview.chromium.org/569035
------------------------------------------------------------------------
r38242 | erg@chromium.org | 2010-02-05 21:52:56 +0100 (Fri, 05 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Don't crash when a theme specifies a non-existant image.

Fixes the current TopCrasher.

BUG=31719
TEST=BrowserThemePackTest.TestNonExistantImages

Review URL: http://codereview.chromium.org/572039
------------------------------------------------------------------------
r38240 | davemoore@chromium.org | 2010-02-05 21:38:14 +0100 (Fri, 05 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc

skia is absolute coords for rects

Review URL: http://codereview.chromium.org/575017
------------------------------------------------------------------------
r38239 | mpcomplete@chromium.org | 2010-02-05 21:36:52 +0100 (Fri, 05 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   A /trunk/src/chrome/test/data/extensions/api_test/cookies
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/cookies/tab.html

Add an extension API test to catch cookie regressions.

BUG=34649

Review URL: http://codereview.chromium.org/573032
------------------------------------------------------------------------
r38237 | sky@chromium.org | 2010-02-05 21:31:33 +0100 (Fri, 05 Feb 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Yet more tab strip model changes. I'm hoping this is the last of
it. I'm now going with:

// . Mini-tab. Mini tabs are locked to the left side of the tab strip and
//   rendered differently (small tabs with only a favicon). The model makes
//   sure all mini-tabs are at the beginning of the tab strip. For example,
//   if a non-mini tab is added it is forced to be with non-mini tabs. Requests
//   to move tabs outside the range of the tab type are ignored. For example,
//   a request to move a mini-tab after non-mini-tabs is ignored.
//   You'll notice there is no explcit api for making a tab a mini-tab, rather
//   there are two tab types that are implicitly mini-tabs:
//   . App. Corresponds to an extension that wants an app tab. App tabs are
//     identified by TabContents::is_app().
//   . Pinned. Any tab can be pinned. A pinned tab is made phantom when closed.
//     Non-app tabs whose pinned state is changed are moved to be with other
//     mini-tabs or non-mini tabs.

I'm going with a more neutral name like mini-tabs so that we can
change the meaning if we need to without changing around all the UI
code. I'll convert the UI code next.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/570043
------------------------------------------------------------------------
r38234 | thestig@chromium.org | 2010-02-05 20:56:39 +0100 (Fri, 05 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Tab strip model: Fix an off by one error where we do not check the first tab.

BUG=33323
TEST=see bug
Review URL: http://codereview.chromium.org/561066
------------------------------------------------------------------------
r38229 | cmasone@google.com | 2010-02-05 20:19:59 +0100 (Fri, 05 Feb 2010) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/login/ipc_message.h
   M /trunk/src/chrome/browser/chromeos/login/login_manager_view.h

Don't need ipc_message.h any more
Review URL: http://codereview.chromium.org/577025
------------------------------------------------------------------------
r38228 | ananta@chromium.org | 2010-02-05 20:13:44 +0100 (Fri, 05 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h

This CL adds support for displaying Chrome InfoBars in pages rendered via ChromeFrame. To achieve this
the ExternalTabContainer now creates a view which comprises of the InfoBarContainer and the TabContentsContainer
view. It uses the GridLayout manager to layout this view.

The InfoBarContainer no longer depends on the BrowserView. It now passes notifications to the InfoBarContainerDelegate
interface which is implemented by the BrowserView and the ExternalTabContainer.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=24051

Bug=24051

Review URL: http://codereview.chromium.org/573022
------------------------------------------------------------------------
r38225 | mirandac@chromium.org | 2010-02-05 19:42:15 +0100 (Fri, 05 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Fix crasher in LocationBarView when browser is closed with page action install bubble showing.

BUG= 34282
TEST= in release version, create a page action. close browser window while page action install bubble is showing. no crash, ever.
Review URL: http://codereview.chromium.org/561028
------------------------------------------------------------------------
r38222 | xiyuan@chromium.org | 2010-02-05 19:19:25 +0100 (Fri, 05 Feb 2010) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Show the filebrowse ui rather than the download shelf in chromeos.

This cl displays the filebrowse ui rather than download shelf for
downloads in chrom(e|ium) os. It conditionally replaces (with
preprocessor macros) the Browser::OnStartDownload method to do this.

The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument),
which opens the file browse ui and passes it the provided hash argument.
This is invoked directly from Browser::OnStartDownload. The
USBMountObserver code was changed to call this static method, rather
than open the popup by hand as it had been doing.

I'm not sure about ownership of the Browser* returned by OpenPopup, but
based on other code in the tree I assume chrome will deal with freeing
it when appropriate.

Before this change, USBMountObserver would add the window to registrar_
*before* showing it. Now that FileBrowseUI::OpenPopup returns a which
which is already visible, this is no longer the case. I assume this
won't be a problem.

Commit this for rginda.
Original review: http://codereview.chromium.org/555167

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/564022
------------------------------------------------------------------------
r38215 | sky@chromium.org | 2010-02-05 18:21:34 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Makes example.com resolve to localhost for test.

BUG=32845
TEST=none
TBR=erikkay

Review URL: http://codereview.chromium.org/573029
------------------------------------------------------------------------
r38213 | joth@chromium.org | 2010-02-05 17:46:23 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc

Split out of reverted change http://src.chromium.org/viewvc/chrome?view=rev&revision=38207
Commit fixes to code under test, whilst tests themselves are still pending.

BUG=http://crbug.com/11246
TEST=see http://codereview.chromium.org/578006

Review URL: http://codereview.chromium.org/571014
------------------------------------------------------------------------
r38212 | sky@chromium.org | 2010-02-05 17:01:49 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/test/data/extensions/app
   A /trunk/src/chrome/test/data/extensions/app/manifest.json

Wires TabContents to app extensions.

BUG=32845
TEST=none

Review URL: http://codereview.chromium.org/566032
------------------------------------------------------------------------
r38211 | pinkerton@chromium.org | 2010-02-05 16:57:29 +0100 (Fri, 05 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_factory.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.mm
   M /trunk/src/chrome/browser/cocoa/menu_controller.h
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm

Add bugs, update, and remove TODOs that are no longer valid
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/577021
------------------------------------------------------------------------
r38209 | cevans@chromium.org | 2010-02-05 16:19:04 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc

Avoid out-of-bounds array access.

TEST=NONE
BUG=34710

Review URL: http://codereview.chromium.org/572031
------------------------------------------------------------------------
r38208 | joth@chromium.org | 2010-02-05 14:01:55 +0100 (Fri, 05 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   D /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert 38207 - bah. still can't work out why this passes fine on local machine & try bots.

Reattempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 
(asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show)

Add tests for the geolocation network provider. 
Also some small tidy up a few other files. 

BUG=http://crbug.com/11246 
TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure 


Review URL: http://codereview.chromium.org/578006

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/575021
------------------------------------------------------------------------
r38207 | joth@chromium.org | 2010-02-05 13:37:57 +0100 (Fri, 05 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   A /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/chrome_tests.gypi

Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 
(asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show)

Add tests for the geolocation network provider. 
Also some small tidy up a few other files. 

BUG=http://crbug.com/11246 
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure 


Review URL: http://codereview.chromium.org/578006
------------------------------------------------------------------------
r38204 | jeremy@chromium.org | 2010-02-05 12:51:27 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/context_menu.h

WebKit side is in https://bugs.webkit.org/show_bug.cgi?id=34524

 BUG=NONE
 TEST=Right clicking on a text input field in Web content on OS X should now show a Writing Direction submenu.  Clicking on "Left To Right" should align the input to the left, and "Right To Left" should do the opposit.  The "Default" menu item should always be disabled.

Review URL: http://codereview.chromium.org/566031
------------------------------------------------------------------------
r38203 | joth@chromium.org | 2010-02-05 12:42:30 +0100 (Fri, 05 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc

Split out of reverted change http://src.chromium.org/viewvc/chrome?view=rev&revision=37989

Tidy up assertions to use CHECKs
(Already reviewed as part of above change)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/578013
------------------------------------------------------------------------
r38192 | jam@chromium.org | 2010-02-05 07:39:06 +0100 (Fri, 05 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl_unittest.cc
   M /trunk/src/chrome/renderer/pepper_devices.cc
   M /trunk/src/chrome/renderer/pepper_devices.h
   M /trunk/src/media/audio/audio_output.h
   M /trunk/src/media/audio/fake_audio_output_stream.cc
   M /trunk/src/media/audio/fake_audio_output_stream.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac_unittest.cc
   M /trunk/src/media/audio/simple_sources.cc
   M /trunk/src/media/audio/simple_sources.h
   M /trunk/src/media/audio/simple_sources_unittest.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/filters/audio_renderer_algorithm_base.cc
   M /trunk/src/media/filters/audio_renderer_algorithm_base.h
   M /trunk/src/media/filters/audio_renderer_algorithm_default.cc
   M /trunk/src/media/filters/audio_renderer_algorithm_default.h
   M /trunk/src/media/filters/audio_renderer_algorithm_ola.cc
   M /trunk/src/media/filters/audio_renderer_algorithm_ola.h
   M /trunk/src/media/filters/audio_renderer_base.cc
   M /trunk/src/media/filters/audio_renderer_base.h
   M /trunk/src/media/filters/audio_renderer_base_unittest.cc
   M /trunk/src/media/filters/audio_renderer_impl.cc
   M /trunk/src/media/filters/audio_renderer_impl.h

Remove size_t from audio IPC code.

The change got to this size because I had to modify the surrounding code (I didn't want to just cast at the last minute).
Review URL: http://codereview.chromium.org/577006
------------------------------------------------------------------------
r38187 | pkasting@chromium.org | 2010-02-05 06:02:43 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/native_frame_view.cc
   M /trunk/src/views/window/native_frame_view.h
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Support app menu and double-click close on upper left corner of window, part one.

This makes things work right for windows that have an icon.  The behavior of the main window is unchanged because right now it never returns HTSYSMENU anywhere.  Part two of this change will be figuring out how to return that at the right place, which will make things Just Work.

BUG=6961
TEST=Open an app or popup window.  Single click the icon.  The app menu should appear.  Close it, then click-and-drag into the app menu.  The item you release on should execute.  Double-click the icon.  The window should close.
Review URL: http://codereview.chromium.org/577018
------------------------------------------------------------------------
r38184 | rafaelw@chromium.org | 2010-02-05 05:45:50 +0100 (Fri, 05 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Implement launch disposition for extension-apps.

This change adds an --app-id command switch that signifies that the extension-app with the given id should be launched according to its configuration.

It also adds parsing for app.window_type in the manifest and the behavior that when installed and a desktop shortcut is created, the --app-id switch is used rather than the --app switch.

BUG=32361

Review URL: http://codereview.chromium.org/573016
------------------------------------------------------------------------
r38179 | darin@chromium.org | 2010-02-05 05:27:47 +0100 (Fri, 05 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_options.h
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Implement backend support for forcing cookies to be saved as
session cookies.

Introduces a new CookiePolicy result code OK_FOR_SESSION_ONLY.

R=eroman
BUG=34571
TEST=none

Review URL: http://codereview.chromium.org/577013
------------------------------------------------------------------------
r38178 | darin@chromium.org | 2010-02-05 05:27:02 +0100 (Fri, 05 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Fix crash when extensions try to set cookies.  It is valid for
the cookie policy to be NULL, in which case we should default
to allowing cookies to be set.

R=eroman
BUG=34649
TEST=Try to install extension AniWeather from official gallery site

Review URL: http://codereview.chromium.org/578007
------------------------------------------------------------------------
r38176 | cpu@chromium.org | 2010-02-05 05:01:08 +0100 (Fri, 05 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.h

More work on diagnostics mode
- Clean up a bit, reduce windows specific code
- Add disk space test
- Add Chrome version test
- Make OS version readable, cross platform mostly

This concludes the minimal sanity tests.

BUG=27885
TEST= run chrome with --diagnostics , no test should fail.

Review URL: http://codereview.chromium.org/561078
------------------------------------------------------------------------
r38174 | finnur@chromium.org | 2010-02-05 04:34:54 +0100 (Fri, 05 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc

Now showing the browser action image (including badge) when dragging and
showing the badge in the overflow menu.

BUG=26990
TEST=Browser actions in container/overflow should show image and badge and
also while dragging back and forth.

Review URL: http://codereview.chromium.org/575016
------------------------------------------------------------------------
r38171 | pkasting@chromium.org | 2010-02-05 03:38:19 +0100 (Fri, 05 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   A /trunk/src/chrome/browser/views/star_toggle.cc (from /trunk/src/chrome/browser/views/star_toggle.cc:38165)
   A /trunk/src/chrome/browser/views/star_toggle.h (from /trunk/src/chrome/browser/views/star_toggle.h:38165)
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Revert 38166 - Added Star button to compact navigation mode.

BUG=32326
TEST=Switch Chrome to compact mode by pressing CtrlShiftC. Test that Star
icon works.

Review URL: http://codereview.chromium.org/543215

TBR=avayvod@chromium.org
Review URL: http://codereview.chromium.org/561081
------------------------------------------------------------------------
r38166 | avayvod@chromium.org | 2010-02-05 03:09:52 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   D /trunk/src/chrome/browser/views/star_toggle.cc
   D /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Added Star button to compact navigation mode.

BUG=32326
TEST=Switch Chrome to compact mode by pressing Ctrl-Shift-C. Test that Star
icon works.

Review URL: http://codereview.chromium.org/543215
------------------------------------------------------------------------
r38165 | huanr@chromium.org | 2010-02-05 02:55:09 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_win.cc

Fix 33130 by checking whether the tab is closed when
closing login propmt

BUG=33130 
TEST=existing test passes

Review URL: http://codereview.chromium.org/576010
------------------------------------------------------------------------
r38163 | viettrungluu@chromium.org | 2010-02-05 02:49:28 +0100 (Fri, 05 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Mac: Set fixed maximum line height in Omnibox.

(Otherwise, e.g., Arabic text can make the line shift downwards.)

BUG=31115
TEST=Make sure Omnibox works/looks/feels normal (and that normal text is displayed in it correctly). Then paste in something containing appropriate Arabic characters (see bug report for some samples); make sure text doesn't shift down.

Review URL: http://codereview.chromium.org/573002
------------------------------------------------------------------------
r38162 | jhawkins@chromium.org | 2010-02-05 02:44:17 +0100 (Fri, 05 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/autofill/phone_number.cc

Implement RemoveChars, a function to remove a list of characters from a string, and use it in PhoneNumber to remove extra phone number characters.

BUG=none
TEST=StringUtilTest.RemoveChars
Review URL: http://codereview.chromium.org/572015
------------------------------------------------------------------------
r38160 | ben@chromium.org | 2010-02-05 02:34:34 +0100 (Fri, 05 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc

Make the side tabstrip participate in the layout of the BrowserView.
Turn on the side tabstrip by default when --enable-vertical-tabs is specified, for ease of testing/debugging.
Adjust glass rendering in this mode.

http://crbug.com/34509
TEST=none

Review URL: http://codereview.chromium.org/570029
------------------------------------------------------------------------
r38159 | pkasting@chromium.org | 2010-02-05 02:31:51 +0100 (Fri, 05 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Fix some goofiness when arrowing around the popup with control down by canceling control-enter once the user starts moving around the popup.

BUG=32547
TEST=Type something in the omnibox, hold control, arrow down to a different entry, release control, press enter.  You should visit the entry that's selected, not something else.
Review URL: http://codereview.chromium.org/577008
------------------------------------------------------------------------
r38151 | estade@chromium.org | 2010-02-05 00:35:26 +0100 (Fri, 05 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: unbreak right click on bookmark bar folders.

BUG=34416
TEST=right, middle, and left click on bookmark bar folder all do what they should

Review URL: http://codereview.chromium.org/576008
------------------------------------------------------------------------
r38148 | sky@chromium.org | 2010-02-05 00:18:47 +0100 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/dialog_delegate.h

Adds link to flash settings on clear browser data panel.

BUG=none
TEST=bring up clear browsing data dialog and make sure it has a link
  to flash storage settings.

Review URL: http://codereview.chromium.org/570030
------------------------------------------------------------------------
r38145 | ananta@chromium.org | 2010-02-05 00:10:00 +0100 (Fri, 05 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h

Add support for the IE File->Save As command. This eventually ends up in Chrome via the new automation
message AutomationMsg_SaveAsAsync. Rest of the changes are to plumb this message across from IE to Chrome.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=24039

Bug=24039
Test=Launch IE with OptinUrls set to *. Navigate to google.com and select File->Save As. The dialog should
     popup.

Review URL: http://codereview.chromium.org/563025
------------------------------------------------------------------------
r38142 | georgey@chromium.org | 2010-02-04 23:43:59 +0100 (Thu, 04 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc

Fixed some of UI issues with AutofillSettings dialog: separators, preview and indents should be correct.
Sizes and alignments should be mostly correct. Known issue is large size of the month field in credit view.
TEST=general autofill test, all functionality is there
BUG=33026
Review URL: http://codereview.chromium.org/567038
------------------------------------------------------------------------
r38139 | snej@chromium.org | 2010-02-04 23:13:10 +0100 (Thu, 04 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Mac: fix crash deleting bookmark while bookmark editor is open.
(xib change: enable 'preserve selection' in NSOutlineView.)
BUG=33333
TEST=BookmarkEditorBaseControllerTest.SelectedFolderDeleted et al

Review URL: http://codereview.chromium.org/566005
------------------------------------------------------------------------
r38137 | finnur@chromium.org | 2010-02-04 22:53:28 +0100 (Thu, 04 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Fixing paint issue with browser actions not being updated in one window when dragged around in another.

BUG=34506
TEST=See bug (make sure you specify a zip code for the weather extension when testing).

Review URL: http://codereview.chromium.org/570028
------------------------------------------------------------------------
r38135 | finnur@chromium.org | 2010-02-04 22:38:07 +0100 (Thu, 04 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_win.cc

Adding drag-drop support in and out of the Browser Action overflow menu.

BUG=26990
TEST=Drag icons into and out of (and within) both the Browser Action container and its overflow menu.

Review URL: http://codereview.chromium.org/570014
------------------------------------------------------------------------
r38133 | oshima@chromium.org | 2010-02-04 22:36:49 +0100 (Thu, 04 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc

Browser action for compact loc bar, plus several visual fixes.
 - added browser action container to compact location bar
 - use toolbar background to match with bookmark bar (when visible)
 - use given bounds to compute window edge

BUG=32327
TEST=none

Review URL: http://codereview.chromium.org/573017
------------------------------------------------------------------------
r38130 | chocobo@chromium.org | 2010-02-04 22:30:37 +0100 (Thu, 04 Feb 2010) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/image_background.h
   D /trunk/src/chrome/browser/chromeos/ipc_message.h
   A /trunk/src/chrome/browser/chromeos/login
   A /trunk/src/chrome/browser/chromeos/login/image_background.h (from /trunk/src/chrome/browser/chromeos/image_background.h:38117)
   A /trunk/src/chrome/browser/chromeos/login/ipc_message.h (from /trunk/src/chrome/browser/chromeos/ipc_message.h:38117)
   A /trunk/src/chrome/browser/chromeos/login/login_manager_view.cc (from /trunk/src/chrome/browser/chromeos/login_manager_view.cc:38128)
   A /trunk/src/chrome/browser/chromeos/login/login_manager_view.h (from /trunk/src/chrome/browser/chromeos/login_manager_view.h:38117)
   A /trunk/src/chrome/browser/chromeos/login/login_wizard_view.cc (from /trunk/src/chrome/browser/chromeos/login_wizard_view.cc:38128)
   A /trunk/src/chrome/browser/chromeos/login/login_wizard_view.h (from /trunk/src/chrome/browser/chromeos/login_wizard_view.h:38127)
   A /trunk/src/chrome/browser/chromeos/login/user_manager.cc (from /trunk/src/chrome/browser/chromeos/user_manager.cc:38117)
   A /trunk/src/chrome/browser/chromeos/login/user_manager.h (from /trunk/src/chrome/browser/chromeos/user_manager.h:38117)
   D /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   D /trunk/src/chrome/browser/chromeos/login_manager_view.h
   D /trunk/src/chrome/browser/chromeos/login_wizard_view.cc
   D /trunk/src/chrome/browser/chromeos/login_wizard_view.h
   D /trunk/src/chrome/browser/chromeos/user_manager.cc
   D /trunk/src/chrome/browser/chromeos/user_manager.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor chromeos login files into subdir 'login'
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/577007
------------------------------------------------------------------------
r38128 | chocobo@chromium.org | 2010-02-04 22:07:15 +0100 (Thu, 04 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos/cros
   A /trunk/src/chrome/browser/chromeos/cros/cros_api.gyp (from /trunk/src/chrome/browser/chromeos/cros_api.gyp:38117)
   A /trunk/src/chrome/browser/chromeos/cros/cros_library.cc (from /trunk/src/chrome/browser/chromeos/cros_library.cc:38117)
   A /trunk/src/chrome/browser/chromeos/cros/cros_library.h (from /trunk/src/chrome/browser/chromeos/cros_library.h:38117)
   A /trunk/src/chrome/browser/chromeos/cros/language_library.cc (from /trunk/src/chrome/browser/chromeos/language_library.cc:38117)
   A /trunk/src/chrome/browser/chromeos/cros/language_library.h (from /trunk/src/chrome/browser/chromeos/language_library.h:38117)
   A /trunk/src/chrome/browser/chromeos/cros/login_library.cc (from /trunk/src/chrome/browser/chromeos/login_library.cc:38117)
   A /trunk/src/chrome/browser/chromeos/cros/login_library.h (from /trunk/src/chrome/browser/chromeos/login_library.h:38117)
   A /trunk/src/chrome/browser/chromeos/cros/mount_library.cc (from /trunk/src/chrome/browser/chromeos/mount_library.cc:38117)
   A /trunk/src/chrome/browser/chromeos/cros/mount_library.h (from /trunk/src/chrome/browser/chromeos/mount_library.h:38117)
   A /trunk/src/chrome/browser/chromeos/cros/network_library.cc (from /trunk/src/chrome/browser/chromeos/network_library.cc:38117)
   A /trunk/src/chrome/browser/chromeos/cros/network_library.h (from /trunk/src/chrome/browser/chromeos/network_library.h:38117)
   A /trunk/src/chrome/browser/chromeos/cros/power_library.cc (from /trunk/src/chrome/browser/chromeos/power_library.cc:38117)
   A /trunk/src/chrome/browser/chromeos/cros/power_library.h (from /trunk/src/chrome/browser/chromeos/power_library.h:38117)
   A /trunk/src/chrome/browser/chromeos/cros/synaptics_library.cc (from /trunk/src/chrome/browser/chromeos/synaptics_library.cc:38117)
   A /trunk/src/chrome/browser/chromeos/cros/synaptics_library.h (from /trunk/src/chrome/browser/chromeos/synaptics_library.h:38117)
   D /trunk/src/chrome/browser/chromeos/cros_api.gyp
   D /trunk/src/chrome/browser/chromeos/cros_library.cc
   D /trunk/src/chrome/browser/chromeos/cros_library.h
   D /trunk/src/chrome/browser/chromeos/language_library.cc
   D /trunk/src/chrome/browser/chromeos/language_library.h
   D /trunk/src/chrome/browser/chromeos/login_library.cc
   D /trunk/src/chrome/browser/chromeos/login_library.h
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.cc
   D /trunk/src/chrome/browser/chromeos/mount_library.cc
   D /trunk/src/chrome/browser/chromeos/mount_library.h
   D /trunk/src/chrome/browser/chromeos/network_library.cc
   D /trunk/src/chrome/browser/chromeos/network_library.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/options/system_page_view.cc
   D /trunk/src/chrome/browser/chromeos/power_library.cc
   D /trunk/src/chrome/browser/chromeos/power_library.h
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   M /trunk/src/chrome/browser/chromeos/status/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status/power_menu_button.h
   D /trunk/src/chrome/browser/chromeos/synaptics_library.cc
   D /trunk/src/chrome/browser/chromeos/synaptics_library.h
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/chrome_browser.gypi

Refactor chromeos cros files into subdir 'cros'
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/572012
------------------------------------------------------------------------
r38127 | chocobo@chromium.org | 2010-02-04 21:36:41 +0100 (Thu, 04 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   D /trunk/src/chrome/browser/chromeos/browser_status_area_view.cc
   D /trunk/src/chrome/browser/chromeos/browser_status_area_view.h
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h
   D /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   D /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   D /trunk/src/chrome/browser/chromeos/language_menu_button.cc
   D /trunk/src/chrome/browser/chromeos/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.h
   D /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   D /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc
   D /trunk/src/chrome/browser/chromeos/password_dialog_view.cc
   D /trunk/src/chrome/browser/chromeos/password_dialog_view.h
   D /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   D /trunk/src/chrome/browser/chromeos/power_menu_button.h
   A /trunk/src/chrome/browser/chromeos/status
   A /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.cc (from /trunk/src/chrome/browser/chromeos/browser_status_area_view.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/browser_status_area_view.h (from /trunk/src/chrome/browser/chromeos/browser_status_area_view.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc (from /trunk/src/chrome/browser/chromeos/clock_menu_button.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/clock_menu_button.h (from /trunk/src/chrome/browser/chromeos/clock_menu_button.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/language_menu_button.cc (from /trunk/src/chrome/browser/chromeos/language_menu_button.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/language_menu_button.h (from /trunk/src/chrome/browser/chromeos/language_menu_button.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/network_menu_button.cc (from /trunk/src/chrome/browser/chromeos/network_menu_button.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/network_menu_button.h (from /trunk/src/chrome/browser/chromeos/network_menu_button.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/password_dialog_view.cc (from /trunk/src/chrome/browser/chromeos/password_dialog_view.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/password_dialog_view.h (from /trunk/src/chrome/browser/chromeos/password_dialog_view.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/power_menu_button.cc (from /trunk/src/chrome/browser/chromeos/power_menu_button.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/power_menu_button.h (from /trunk/src/chrome/browser/chromeos/power_menu_button.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/status_area_button.cc (from /trunk/src/chrome/browser/chromeos/status_area_button.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/status_area_button.h (from /trunk/src/chrome/browser/chromeos/status_area_button.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/status_area_host.h (from /trunk/src/chrome/browser/chromeos/status_area_host.h:38117)
   A /trunk/src/chrome/browser/chromeos/status/status_area_view.cc (from /trunk/src/chrome/browser/chromeos/status_area_view.cc:38117)
   A /trunk/src/chrome/browser/chromeos/status/status_area_view.h (from /trunk/src/chrome/browser/chromeos/status_area_view.h:38117)
   D /trunk/src/chrome/browser/chromeos/status_area_button.cc
   D /trunk/src/chrome/browser/chromeos/status_area_button.h
   D /trunk/src/chrome/browser/chromeos/status_area_host.h
   D /trunk/src/chrome/browser/chromeos/status_area_view.cc
   D /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactor chromeos status area files into subdirectory status
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/561077
------------------------------------------------------------------------
r38124 | michaeln@chromium.org | 2010-02-04 20:58:31 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.h

Some preliminary ground work for respecting the "Content Settings" in the appcache, and an implementation of the "ClearLocalState" function.

TEST=none
BUG=34344,32719


Review URL: http://codereview.chromium.org/565012
------------------------------------------------------------------------
r38122 | chocobo@chromium.org | 2010-02-04 20:36:02 +0100 (Thu, 04 Feb 2010) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/internet_page_view.cc
   D /trunk/src/chrome/browser/chromeos/internet_page_view.h
   A /trunk/src/chrome/browser/chromeos/options
   A /trunk/src/chrome/browser/chromeos/options/internet_page_view.cc (from /trunk/src/chrome/browser/chromeos/internet_page_view.cc:38113)
   A /trunk/src/chrome/browser/chromeos/options/internet_page_view.h (from /trunk/src/chrome/browser/chromeos/internet_page_view.h:38113)
   A /trunk/src/chrome/browser/chromeos/options/settings_page_view.cc (from /trunk/src/chrome/browser/chromeos/settings_page_view.cc:38113)
   A /trunk/src/chrome/browser/chromeos/options/settings_page_view.h (from /trunk/src/chrome/browser/chromeos/settings_page_view.h:38113)
   A /trunk/src/chrome/browser/chromeos/options/system_page_view.cc (from /trunk/src/chrome/browser/chromeos/system_page_view.cc:38113)
   A /trunk/src/chrome/browser/chromeos/options/system_page_view.h (from /trunk/src/chrome/browser/chromeos/system_page_view.h:38113)
   D /trunk/src/chrome/browser/chromeos/settings_page_view.cc
   D /trunk/src/chrome/browser/chromeos/settings_page_view.h
   D /trunk/src/chrome/browser/chromeos/system_page_view.cc
   D /trunk/src/chrome/browser/chromeos/system_page_view.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

Refactor chromeos options page into its own directory
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/572009
------------------------------------------------------------------------
r38119 | viettrungluu@chromium.org | 2010-02-04 20:16:28 +0100 (Thu, 04 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

Mac: fullscreen mode find bar positioning fix.

Always position the find bar (if visible) below the visually contiguous toolbar
(i.e., toolbar + maybe bookmark bar). In fullscreen mode, this may mean that it
hangs off the top of the screen, which is intended.

BUG=31638
TEST=Find bar still works normally (and is positioned correctly) in non-fullscreen mode. For developers who know how to enable fullscreen mode, it should be positioned as described above and work correctly.

Review URL: http://codereview.chromium.org/572006
------------------------------------------------------------------------
r38117 | avayvod@chromium.org | 2010-02-04 20:08:35 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.h
   M /trunk/src/chrome/browser/chromeos/status_area_host.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.h

Removed Timezone settings menu item from Clock menu for login wizard view.

BUG=34374
TEST=Switch to Chrome-based login manager, click on the clock button. Only
the date should be shown here, nothing like Settings... menu item.

Review URL: http://codereview.chromium.org/562044
------------------------------------------------------------------------
r38115 | oshima@chromium.org | 2010-02-04 20:06:06 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Refactor BrowserActionsContainer so that it can be used
 in other context (CompactLocationBar in chromeos)

BUG=32327
TEST=none. no functional change.

Review URL: http://codereview.chromium.org/565025
------------------------------------------------------------------------
r38111 | ben@chromium.org | 2010-02-04 18:28:56 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h

Fix bustage. The app panel frame change went in moments before mine :-(

BUG=none
TEST=none
TBR=sky

Review URL: http://codereview.chromium.org/577002
------------------------------------------------------------------------
r38110 | ben@chromium.org | 2010-02-04 18:23:18 +0100 (Thu, 04 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   A /trunk/src/chrome/browser/views/tabs/base_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/chrome_browser.gypi

Create a new base class BaseTabStrip that is the intermediary between BrowserView/etc and the specific active TabStrip implementation in use.

This simplifies things a lot. I don't need separate view IDs etc.

http://crbug.com/34509
TEST=none

Review URL: http://codereview.chromium.org/571002
------------------------------------------------------------------------
r38109 | gwilson@chromium.org | 2010-02-04 18:05:34 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/group_policy.cc
   D /trunk/src/chrome/browser/group_policy.h
   D /trunk/src/chrome/browser/group_policy_settings.cc
   D /trunk/src/chrome/browser/group_policy_settings.h
   D /trunk/src/chrome/browser/group_policy_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 38108 - Basic group policy support, third try.  Doesn't wire any group policy to preferences yet.

In this iteration, I modified the unit test to require full access (read+write) to the necessary registry keys before running.

TBR=hclam

Review URL: http://codereview.chromium.org/570025
------------------------------------------------------------------------
r38108 | gwilson@google.com | 2010-02-04 17:48:10 +0100 (Thu, 04 Feb 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/group_policy.cc
   A /trunk/src/chrome/browser/group_policy.h
   A /trunk/src/chrome/browser/group_policy_settings.cc
   A /trunk/src/chrome/browser/group_policy_settings.h
   A /trunk/src/chrome/browser/group_policy_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Basic group policy support, third try.  Doesn't wire any group policy to preferences yet.

In this iteration, I modified the unit test to require full access (read+write) to the necessary registry keys before running.

R=kuchhal,cpu
BUG=19374
TEST=unit test included


Review URL: http://codereview.chromium.org/555057
------------------------------------------------------------------------
r38107 | rafaelw@chromium.org | 2010-02-04 17:08:29 +0100 (Thu, 04 Feb 2010) | 17 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/frame_app_panel_default.png
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/task_manager.cc
   A /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.cc
   A /trunk/src/chrome/browser/views/frame/app_panel_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Step 1 in Implementing/Prototyping App Panels.

In this first step we

1) Create a new Browser::Type::TYPE_APP_PANEL which is observed in various places
2) Create an AppPanelBrowserFrame which is created in BrowserFrameWin when the TYPE_APP_PANEL is observed. AppPanelBrowserFrame draws itself per glen's mocks and will ultimately behave substantially different from regular browser windows.
3) Create a temporary command switch called --app-launch-as-panel which can be used until we implement actual app launching.

Note that there is still work to be done "bit-twiddling" to match glen's mocks and to implement the "inactive" look for these windows.

Steps 2 through N may include: different sizing behavior (based either on the content size or an api call), different min/maximize behavior, docking to the os taskbar, auto order & placement of app panels.

A screen capture of the current implementation is attached to the bug.

BUG=32361

Review URL: http://codereview.chromium.org/553143
------------------------------------------------------------------------
r38105 | rafaelw@chromium.org | 2010-02-04 16:49:46 +0100 (Thu, 04 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Use strict json formating in extension_uitest.

This is in anticipation of the new, strict, JSON.parse landing in v8.

Review URL: http://codereview.chromium.org/560040
------------------------------------------------------------------------
r38101 | joth@chromium.org | 2010-02-04 14:08:55 +0100 (Thu, 04 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc

Fix shared linux build
Split out of reverted change http://src.chromium.org/viewvc/chrome?view=rev&revision=37989

supersedes changes http://codereview.chromium.org/563030 and http://codereview.chromium.org/570020

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/570023
------------------------------------------------------------------------
r38087 | akalin@chromium.org | 2010-02-04 08:59:58 +0100 (Thu, 04 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc

Fixed notifications-related bug on network reconnections.

Tied talk_mediator logged_in state to mediator_thread instead of
auth_watcher.

Added some extra logging.

BUG=34117
TEST=see bug

Review URL: http://codereview.chromium.org/566028
------------------------------------------------------------------------
r38086 | jar@chromium.org | 2010-02-04 08:52:40 +0100 (Thu, 04 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

Revert 38085 - A brief test of whether we can safely disable ipv6. Will rollback asap.

Having had trouble with a probe based disabling of ipv6, I wanted
to understand if globally disabling IPv6 is problematic.

I'll rollback this chance as soon as the buildbots begin to test it.

tbr=wtc
Review URL: http://codereview.chromium.org/573004

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/561070
------------------------------------------------------------------------
r38085 | jar@chromium.org | 2010-02-04 08:49:14 +0100 (Thu, 04 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc

A brief test of whether we can safely disable ipv6. Will rollback asap.

Having had trouble with a probe based disabling of ipv6, I wanted
to understand if globally disabling IPv6 is problematic.

I'll roll-back this chance as soon as the build-bots begin to test it.

tbr=wtc
Review URL: http://codereview.chromium.org/573004
------------------------------------------------------------------------
r38084 | dpolukhin@chromium.org | 2010-02-04 07:44:38 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Move options dialog to the desktop of last active browser window.
Prevent moving options dialog out of monitor boundaries.

BUG=1143
TEST=Tested on Linux with multiple desktops.

Review URL: http://codereview.chromium.org/555151
------------------------------------------------------------------------
r38076 | ben@chromium.org | 2010-02-04 04:28:45 +0100 (Thu, 04 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   A /trunk/src/chrome/browser/views/tabs/side_tab.cc
   A /trunk/src/chrome/browser/views/tabs/side_tab.h
   A /trunk/src/chrome/browser/views/tabs/side_tab_strip.cc
   A /trunk/src/chrome/browser/views/tabs/side_tab_strip.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Start making a vertical tabstrip. Does nothing right now.

The option to enable the vertical tabstrip will appear when Chrome is run with:

--enable-vertical-tabs

and a pref is set. There is presently no UI to set this pref.

http://crbug.com/34509
TEST=none

Review URL: http://codereview.chromium.org/561004
------------------------------------------------------------------------
r38074 | derat@chromium.org | 2010-02-04 03:50:10 +0100 (Thu, 04 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc

gtk: Remove Backspace and Shift-Backspace accelerators.

I am doing this for platform compatibility on Linux: per
http://kb.mozillazine.org/Browser.backspace_action, these
accelerators have been disabled by default in Firefox
since 2006-12-07.  They are also not present in Epiphany
or Midori.

BUG=30699
TEST=tried them; they do nothing now

Review URL: http://codereview.chromium.org/565050
------------------------------------------------------------------------
r38070 | rvargas@google.com | 2010-02-04 03:04:19 +0100 (Thu, 04 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/net/http/http_cache_transaction.cc
   M /trunk/src/net/url_request/url_request_http_job.cc

Add debug info to track a crash when sleeping.

BUG=31723
TEST=none

Review URL: http://codereview.chromium.org/560039
------------------------------------------------------------------------
r38069 | ian@chromium.org | 2010-02-04 03:03:19 +0100 (Thu, 04 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Adding libevent to about:credits

BUG=22301
TEST=Go to about:credits and verify that libevent is listed.
Review URL: http://codereview.chromium.org/564053
------------------------------------------------------------------------
r38068 | suzhe@chromium.org | 2010-02-04 02:59:49 +0100 (Thu, 04 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

[Linux] FindBarGtk: Fix an issue caused by CL 560006.

This CL fixes an issue caused by CL 560006, which prevents the ctrl-Home/End key bindings from being sent to the renderer when the focus is inside the find bar.

BUG=none
TEST=Open a long web page and focus find bar then test if ctrl-Home/End still work.


Review URL: http://codereview.chromium.org/561017
------------------------------------------------------------------------
r38065 | chase@chromium.org | 2010-02-04 02:44:30 +0100 (Thu, 04 Feb 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_gtk.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc (from /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc:38055)
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h (from /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h:38055)
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 38056 - Unfork BookmarkMenuGtk and BookmarkMenuController.

This is step 2 of 3. bookmark_context_menu_controller_gtk will eventually replace bookmark_context_menu_controller; for now it is separate because getting Windows to use it is another huge hassle.

BUG=32830
TEST=manual + trybots
Review URL: http://codereview.chromium.org/563017

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/567041
------------------------------------------------------------------------
r38056 | estade@chromium.org | 2010-02-04 01:43:29 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_gtk.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

Unfork BookmarkMenuGtk and BookmarkMenuController.

This is step 2 of 3. bookmark_context_menu_controller_gtk will eventually replace bookmark_context_menu_controller; for now it is separate because getting Windows to use it is another huge hassle.

BUG=32830
TEST=manual + trybots
Review URL: http://codereview.chromium.org/563017
------------------------------------------------------------------------
r38054 | dantasse@chromium.org | 2010-02-04 01:27:11 +0100 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Switch the order of two checks to avoid dereferencing a null RequestContext

TBR=tim@chromium.org
BUG=32085,32084
TEST=none

Review URL: http://codereview.chromium.org/561064
------------------------------------------------------------------------
r38052 | willchan@chromium.org | 2010-02-04 01:24:51 +0100 (Thu, 04 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome_frame/test/test_server_test.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/network_change_notifier.cc
   M /trunk/src/net/base/network_change_notifier.h
   M /trunk/src/net/flip/flip_network_transaction_unittest.cc
   M /trunk/src/net/flip/flip_stream_unittest.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Pass the NetworkChangeNotifier to HostResolver.
This requires the following refactors:
  (1) NetworkChangeNotifier moves out of HttpNetworkSession into IOThread.
  (2) HostResolver gets initialized with NetworkChangeNotifier.
  (3) NetworkChangeNotifier needs to get passed into HttpCache and HttpNetworkSession (required updating a lot of files).
  (4) NetworkChangeNotifier is no longer reference counted.  It is owned by IOThread.
  (5) IOThread gains a new struct: Globals.  It can only be used on the io thread.
  (6) ChromeURLRequestContextFactory uses IOThread::Globals to initialize ChromeURLRequest objects with the host resolver and network change notifier.
BUG=26159

Review URL: http://codereview.chromium.org/552117
------------------------------------------------------------------------
r38051 | estade@chromium.org | 2010-02-04 01:22:13 +0100 (Thu, 04 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

linux: Use SimpleMenuModel::Delegate in TaskManager instead of MenuGtk::Delegate. 

BUG=31365
TEST=manually
patch by tfarina <thiago.farina [at] gmail>
original review ==> http://codereview.chromium.org/557072/show

Review URL: http://codereview.chromium.org/562040
------------------------------------------------------------------------
r38048 | jochen@chromium.org | 2010-02-04 01:10:01 +0100 (Thu, 04 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Make sure locally stored site data is deleted after DB and WebKit threads are gone.

BUG=32719
TEST=none

Review URL: http://codereview.chromium.org/564050
------------------------------------------------------------------------
r38042 | dantasse@chromium.org | 2010-02-04 00:42:59 +0100 (Thu, 04 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Check the LSID before starting up a ProfileSyncService.  This will stop memory leaks in tests.  It will also stop us from starting Sync in Chromium OS UI tests.

BUG=32085,32084
TEST=none

Review URL: http://codereview.chromium.org/560033
------------------------------------------------------------------------
r38035 | oshima@chromium.org | 2010-02-04 00:12:40 +0100 (Thu, 04 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h

Clip compact location bar's window when animating.
 - Moved window clipping code to DropdownBarHost so that CompactLocationBar can use it.
 - Changed CompactLocationBar to do clipping when animating.
 - Adjust the location of compact location bar when bookmark bar is visible.

CompactLocationBar's shape will be different from one for find bar.
I'll change the UpdateWindowEdge so that i can handle different shapes later.

BUG=31766
TEST=none

Review URL: http://codereview.chromium.org/560036
------------------------------------------------------------------------
r38034 | ben@chromium.org | 2010-02-03 23:46:52 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove the "On top" display mode of the extension shelf, it is no longer used or supported.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/566035
------------------------------------------------------------------------
r38033 | zork@google.com | 2010-02-03 23:42:37 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/protocol/autofill_specifics.proto
   M /trunk/src/chrome/chrome.gyp

Add autofill proto buffer for sync.

BUG=34203
TEST=none

Review URL: http://codereview.chromium.org/562027
------------------------------------------------------------------------
r38030 | viettrungluu@chromium.org | 2010-02-03 23:29:35 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

Mac: fix Esc-killing-Omnibox-focus problem (after find bar shown).

BUG=33094
TEST=Open a new browser window; Cmd-F to show the find bar; Esc to hide the find bar; focus the Omnibox; press Esc a few times (with or without editing its contents); focus should remain in the Omnibox. Make sure showing/hiding/using the find bar works normally.

Review URL: http://codereview.chromium.org/561055
------------------------------------------------------------------------
r38028 | darin@chromium.org | 2010-02-03 23:14:15 +0100 (Wed, 03 Feb 2010) | 36 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc
   A /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   A /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/cookie_store.h
   M /trunk/src/net/base/static_cookie_policy.cc
   M /trunk/src/net/base/static_cookie_policy.h
   M /trunk/src/net/base/static_cookie_policy_unittest.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/webcookie.h

Revert 38001 and 38002.

Modify CookiePolicy to work asynchronously

This change will enable us to prompt the user before setting a cookie.  While
we only need to prompt before setting, we actually need to make both
CanSetCookie and CanGetCookies asynchronous.  This is necessary in order to
preserve FIFO ordering since the value returned by GetCookies depends on the
changes made to the cookie DB by SetCookie.

This change also includes some simplification of CookieStore.  Instead of N
virtual functions, I distilled it down to only 4.  The remaining functions are
instead expressed in terms of those.

While studying all the places where we currently use CookiePolicy, I found that
some of them were not appropriate.  After discussing with Amit, I decided to
remove the policy checks in URLRequestAutomationJob.  See the comments in the
code regarding this.

I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL
to better match GetAllCookies.  Related to this change webkit/glue/webcookie.h
grows a constructor that takes a CanonicalCookie to help clean up some code.

On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy
object.  That object is threadsafe ref counted because it is passed between the
UI and IO threads.  It is responsible for implementing the queuing logic
described above.  It will also in the future trigger the Chrome UI code to
actually show the setcookie prompt.

Please review the state machinery changes in URLRequestHttpJob carefully.

R=eroman
BUG=34331
TEST=no tests yet for prompting.

Review URL: http://codereview.chromium.org/564045
------------------------------------------------------------------------
r38022 | ananta@chromium.org | 2010-02-03 22:38:08 +0100 (Wed, 03 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

The ExternalTabContainer enters a modal loop while waiting for the unload events on the tab to complete.
If multiple ChromeFrame tabs were closed together then we end up in a nested loop hierarchy. In this case
the innermost message loop ends up dispatching the TabContents::Close method which then calls its
delegate which is the ExternalTabContainer for the other ExternalTabs as well. As a result the outer loops
never exit, which causes IE tabs to hang.

Fix is to use a local global stack of ExternalTabContainers. If we receive a CloseContents call for any other
container but the innermost one, we post it back to the loop.

Bug=31853

Review URL: http://codereview.chromium.org/560034
------------------------------------------------------------------------
r38017 | estade@chromium.org | 2010-02-03 22:14:29 +0100 (Wed, 03 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK bookmark bar button throbbing tweaks

a) initialize throbbing_widget_ (fixes crasher http://crbug.com/34313)
b) throb "Other Bookmarks" button when appropriate

BUG=34313
TEST=manual

Review URL: http://codereview.chromium.org/561051
------------------------------------------------------------------------
r38015 | skerner@chromium.org | 2010-02-03 21:58:50 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/static/browserAction.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/a_popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/another_popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/change_popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/add_popup/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/remove_popup
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/remove_popup/a_popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/remove_popup/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/remove_popup/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/remove_popup/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/remove_popup/remove_popup.html

Implement chrome.browserAction.setPopup().

BUG=27526
TEST=Unit tests BrowserActionApiTest.BrowserAction*Popup .

Review URL: http://codereview.chromium.org/552263
------------------------------------------------------------------------
r38010 | jcampan@chromium.org | 2010-02-03 21:36:00 +0100 (Wed, 03 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc

Don't show a translate infobar when the page is in a language
not supported by the translation server.

BUG=34365
TEST=Visit http://www.breizh.net/brezhoneg/, no translation
     infobar should be shown.

Review URL: http://codereview.chromium.org/568028
------------------------------------------------------------------------
r38006 | erg@google.com | 2010-02-03 21:28:18 +0100 (Wed, 03 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc

Themes: HasCustomImage() must only return true for images that were provided
by the extension and not for images that were autogenerated.

Since this adds data to the theme pack file, bump the version number.

BUG=34078
TEST=BrowserThemePackTest.TestHasCustomImage

Review URL: http://codereview.chromium.org/562025
------------------------------------------------------------------------
r38004 | pvalchev@google.com | 2010-02-03 21:13:06 +0100 (Wed, 03 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

BSD port: another chunk of chrome/browser ifdef cleaning
Review URL: http://codereview.chromium.org/553153
------------------------------------------------------------------------
r38003 | estade@chromium.org | 2010-02-03 21:11:30 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: middle click on a bookmark bar folder should open all in tabs.

BUG=34416
TEST=try it

Review URL: http://codereview.chromium.org/569031
------------------------------------------------------------------------
r38002 | mark@chromium.org | 2010-02-03 20:58:57 +0100 (Wed, 03 Feb 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   D /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   D /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/cookie_store.h
   M /trunk/src/net/base/static_cookie_policy.cc
   M /trunk/src/net/base/static_cookie_policy.h
   M /trunk/src/net/base/static_cookie_policy_unittest.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/webcookie.h

Back out trunk r37998.

Modify CookiePolicy to work asynchronously

This change will enable us to prompt the user before setting a cookie.  While we only need to prompt before setting, we actually need to make both CanSetCookie and CanGetCookies asynchronous.  This is necessary in order to preserve FIFO ordering since the value returned by GetCookies depends on the changes made to the cookie DB by SetCookie.

This change also includes some simplification of CookieStore.  Instead of N virtual functions, I distilled it down to only 4.  The remaining functions are instead expressed in terms of those.

While studying all the places where we currently use CookiePolicy, I found that some of them were not appropriate.  After discussing with Amit, I decided to remove the policy checks in URLRequestAutomationJob.  See the comments in the code regarding this.

I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL to better match GetAllCookies.  I also filed a bug about making it even closer in functionality.  Related to this change webkit/glue/webcookie.h grows a constructor that takes a CanonicalCookie to help clean up some code.

On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy object.  That object is threadsafe ref counted because it is passed between the UI and IO threads.  It is responsible for implementing the queuing logic described above.  It will also in the future trigger the Chrome UI code to actually show the setcookie prompt.

Please review the state machinery changes in URLRequestHttpJob carefully.

R=eroman
BUG=34331
TEST=no tests yet for prompting.
Review URL: http://codereview.chromium.org/567015

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/562037
------------------------------------------------------------------------
r38001 | mark@chromium.org | 2010-02-03 20:56:54 +0100 (Wed, 03 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc

Back out trunk r38000.

Fix ChromiumOS build.

TBR=eroman

Review URL: http://codereview.chromium.org/569030

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/565036
------------------------------------------------------------------------
r38000 | darin@chromium.org | 2010-02-03 20:50:25 +0100 (Wed, 03 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc

Fix ChromiumOS build.

TBR=eroman

Review URL: http://codereview.chromium.org/569030
------------------------------------------------------------------------
r37999 | avayvod@chromium.org | 2010-02-03 20:32:40 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.cc
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.h

Added status area to login wizard view.
Separated objects construction and initialization.

BUG=34374
TEST=Chrome based login now should have status area buttons in the right-top corner.
Review URL: http://codereview.chromium.org/564027
------------------------------------------------------------------------
r37998 | darin@chromium.org | 2010-02-03 20:19:15 +0100 (Wed, 03 Feb 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   A /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   A /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/cookie_store.h
   M /trunk/src/net/base/static_cookie_policy.cc
   M /trunk/src/net/base/static_cookie_policy.h
   M /trunk/src/net/base/static_cookie_policy_unittest.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/webcookie.h

Modify CookiePolicy to work asynchronously

This change will enable us to prompt the user before setting a cookie.  While we only need to prompt before setting, we actually need to make both CanSetCookie and CanGetCookies asynchronous.  This is necessary in order to preserve FIFO ordering since the value returned by GetCookies depends on the changes made to the cookie DB by SetCookie.

This change also includes some simplification of CookieStore.  Instead of N virtual functions, I distilled it down to only 4.  The remaining functions are instead expressed in terms of those.

While studying all the places where we currently use CookiePolicy, I found that some of them were not appropriate.  After discussing with Amit, I decided to remove the policy checks in URLRequestAutomationJob.  See the comments in the code regarding this.

I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL to better match GetAllCookies.  I also filed a bug about making it even closer in functionality.  Related to this change webkit/glue/webcookie.h grows a constructor that takes a CanonicalCookie to help clean up some code.

On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy object.  That object is thread-safe ref counted because it is passed between the UI and IO threads.  It is responsible for implementing the queuing logic described above.  It will also in the future trigger the Chrome UI code to actually show the set-cookie prompt.

Please review the state machinery changes in URLRequestHttpJob carefully.

R=eroman
BUG=34331
TEST=no tests yet for prompting.
Review URL: http://codereview.chromium.org/567015
------------------------------------------------------------------------
r37996 | dhg@chromium.org | 2010-02-03 20:17:21 +0100 (Wed, 03 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Adding catches to states of the UI to only allow button pushes in certain states. Basically adding error catching.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/562005
------------------------------------------------------------------------
r37992 | joth@chromium.org | 2010-02-03 20:05:29 +0100 (Wed, 03 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   D /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   M /trunk/src/chrome/chrome_tests.gypi

Revert 37989 - unit test failed on Mac builder despite passing on try server
Original change:
Add tests for the geolocation network provider.
Also some small tidy up a few other files.

BUG=http://crbug.com/11246 
TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure

Review URL: http://codereview.chromium.org/556106

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/570006
------------------------------------------------------------------------
r37989 | joth@chromium.org | 2010-02-03 19:35:09 +0100 (Wed, 03 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   A /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   M /trunk/src/chrome/chrome_tests.gypi

Add tests for the geolocation network provider.
Also some small tidy up a few other files.

BUG=http://crbug.com/11246 
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure

Review URL: http://codereview.chromium.org/556106
------------------------------------------------------------------------
r37980 | arv@chromium.org | 2010-02-03 18:22:15 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/bookmark_manager
   A /trunk/src/chrome/browser/resources/bookmark_manager/css
   A /trunk/src/chrome/browser/resources/bookmark_manager/css/list.css (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/list.css:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/css/menu.css (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/menu.css:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/tree.css:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/css/tree.css.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/tree.css.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmark_bar_folder_mac.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmark_bar_folder_mac.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmark_manager_recent.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmark_manager_recent.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmark_manager_search.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmark_manager_search.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/bookmarks_section.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmarks_section.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_closed.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_closed.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_closed_rtl.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_closed_rtl.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_open.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_open.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/images/folder_open_rtl.png (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_open_rtl.png:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/bmm/bookmarklist.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm/bookmarktree.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/bmm/bookmarktree.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/bmm.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/bmm.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/event.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/event.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/eventtarget.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/eventtarget_test.html (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/eventtarget_test.html:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/command.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/command.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/contextmenuhandler.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/contextmenuhandler.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/list.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/list.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listitem.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/listitem.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/listselectionmodel.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menu.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/menu.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menubutton.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/menubutton.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/menuitem.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/menuitem.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/tree.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr/ui.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/cr_test.html (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr_test.html:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/i18ntemplate.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/i18ntemplate.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/localstrings.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/localstrings.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/js/util.js (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/util.js:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/main.html (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/main.html:37978)
   A /trunk/src/chrome/browser/resources/bookmark_manager/manifest.json (from /trunk/src/chrome/test/data/extensions/bookmarkmanager/manifest.json:37978)
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/list.css
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/menu.css
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/tree.css
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/css/tree.css.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmark_bar_folder_mac.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmark_manager_recent.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmark_manager_search.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/bookmarks_section.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_closed.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_closed_rtl.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_open.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/images/folder_open_rtl.png
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/bmm/bookmarklist.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/bmm/bookmarktree.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/bmm.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/event.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/eventtarget.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/eventtarget_test.html
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/command.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/contextmenuhandler.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/list.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/listitem.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/listselectionmodel.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/menu.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/menubutton.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/menuitem.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui/tree.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr/ui.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/cr_test.html
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/i18ntemplate.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/localstrings.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/js/util.js
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/main.html
   D /trunk/src/chrome/test/data/extensions/bookmarkmanager/manifest.json

Move bookmark manager

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/560023
------------------------------------------------------------------------
r37979 | kuan@chromium.org | 2010-02-03 18:21:50 +0100 (Wed, 03 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc

a little code cleanup for translate infobars
- use index of selected language menu item (which corresponds to index in array of languages) to check if selection has changed; was retrieving, converting and comparing text, which is more expensive and slower
- only call backend to translate when source and target languages are different

BUG=31297
TEST=verify that selection of languages in translate infobars still work as expected.
Review URL: http://codereview.chromium.org/563018
------------------------------------------------------------------------
r37978 | pfeldman@chromium.org | 2010-02-03 18:08:19 +0100 (Wed, 03 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

DevTools: CookieMonster::GetRawCookies should return keys as well as cookies.

Review URL: http://codereview.chromium.org/565035
------------------------------------------------------------------------
r37976 | jcampan@chromium.org | 2010-02-03 17:57:27 +0100 (Wed, 03 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.h
   M /trunk/src/chrome/browser/renderer_host/translation_service_unittest.cc
   M /trunk/src/chrome/browser/translate/translate_manager.cc

Some minor change to the translate classes to address the remarks
from Jungshik review:
http://codereview.chromium.org/552216/show

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/566024
------------------------------------------------------------------------
r37973 | thakis@chromium.org | 2010-02-03 17:34:47 +0100 (Wed, 03 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

To comply better with the Apple hig I changed the menu from showing a checkmark icon next to Pause to alternating the words "Pause" and "Resume".

XIB change: unset the 'On Image' on the Pause button.

BUG=23069
TEST=Download large file and verify that the menu item says "Pause."  Click "Pause" and the menu item should now say "Resume".

Review URL: http://codereview.chromium.org/563001
------------------------------------------------------------------------
r37970 | jeremy@chromium.org | 2010-02-03 15:34:50 +0100 (Wed, 03 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm

Support disabling items in submenus of a context menu.

Without this change, items in submenus of a context menu where always enabled.  With this change, the value we use for [NSMenuItem setEnabled:] is respected.

This change is required for an upcoming change that needs this to work.

BUG=none
TEST=Right-click on a text input field, Spell Checker Options->Show spelling panel shouldn't be disabled.

Review URL: http://codereview.chromium.org/567031
------------------------------------------------------------------------
r37961 | georgey@chromium.org | 2010-02-03 10:30:22 +0100 (Wed, 03 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h

Added Credit card preview in the form ******[last four digits], Exp: [Date - month and year]
BUG=33026
TEST=should appear like in mocks, when dialog is finished
Review URL: http://codereview.chromium.org/566027
------------------------------------------------------------------------
r37955 | kinuko@chromium.org | 2010-02-03 07:40:21 +0100 (Wed, 03 Feb 2010) | 17 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_mac.mm
   M /trunk/src/app/clipboard/clipboard_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h

Copy percent-escaped URL when copying all the text from the address bar (Mac)

BUG=31104
TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 and select entire text in Omnibox, then copy the text.
Paste the copied text into other applications such as notepad and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 上地.
Paste the copied text into Safari's URL bar and type return. Check if you are navigated to the same website.
Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0.
Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 上地.
Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0".
Paste the copied text into TextEdit and check if the pasted text isn't garbled and correctly contains 上地.
Check if the link in TextEdit is pointing to encoded URL (http://www.google.com/...%E4%B8%8A%E5%9C%B0).
TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 again and select "q=上地" in Omnibox, then copy the text.
Paste it into somewhere and check if you see "q=上地".
TEST=Copy "上地" from somewhere and paste it into Omnibox.
Copy from Omnibox and paste it into notepad. Then check if the pasted text is NOT encoded.

Review URL: http://codereview.chromium.org/549172
------------------------------------------------------------------------
r37952 | ben@chromium.org | 2010-02-03 06:06:50 +0100 (Wed, 03 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/browser_status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_status_area_view.h
   A /trunk/src/chrome/browser/chromeos/browser_view.cc (from /trunk/src/chrome/browser/chromeos/browser_view.cc:37927)
   A /trunk/src/chrome/browser/chromeos/browser_view.h (from /trunk/src/chrome/browser/chromeos/browser_view.h:37927)
   D /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   D /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/frame/browser_view_layout.cc (from /trunk/src/chrome/browser/views/frame/browser_view_layout.cc:37927)
   A /trunk/src/chrome/browser/views/frame/browser_view_layout.h (from /trunk/src/chrome/browser/views/frame/browser_view_layout.h:37927)
   D /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h
   D /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc
   D /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h
   M /trunk/src/chrome/chrome_browser.gypi

Move ChromeBrowserView* -> BrowserView* and ChromeosBrowserView* -> chromeos::BrowserView*

Now has all build fixes integrated.

BUG=none
TEST=none
TBR=oshima
Review URL: http://codereview.chromium.org/568030
------------------------------------------------------------------------
r37951 | thakis@chromium.org | 2010-02-03 05:52:35 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Let renderer notify browser if content gets blocked.

BUG=
TEST=Go to a page with blocked stuff. Icons should appear in omnibox.

Review URL: http://codereview.chromium.org/565010
------------------------------------------------------------------------
r37939 | tkent@chromium.org | 2010-02-03 03:46:03 +0100 (Wed, 03 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/renderer/render_view.cc

Change the behavior of ViewMsg_Replace. It replaces a word around the
caret if there is no selected text.
See http://webkit.org/b/33364

BUG=8841
TEST=Open www.google.com on Windows or Linux (not Mac OS)
  type "qeury"
  Right-click on the text field
  Select "query"
  Confirm that qeury is replaced with "query"

Review URL: http://codereview.chromium.org/562014
------------------------------------------------------------------------
r37936 | jochen@chromium.org | 2010-02-03 03:35:08 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Reland 37913.  Clear local state on exit.

BUG=32719
TEST=none

Review URL: http://codereview.chromium.org/560024
------------------------------------------------------------------------
r37934 | kbr@google.com | 2010-02-03 03:28:48 +0100 (Wed, 03 Feb 2010) | 26 lines
Changed paths:
   M /trunk/src/app/gfx/native_widget_types.h
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/command_buffer_messages_internal.h
   M /trunk/src/chrome/common/gpu_plugin.cc
   A /trunk/src/chrome/common/io_surface_support_mac.cc
   A /trunk/src/chrome/common/io_surface_support_mac.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/command_buffer_proxy.cc
   M /trunk/src/chrome/renderer/command_buffer_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/gpu/DEPS
   M /trunk/src/gpu/command_buffer/client/gles2_demo_cc.cc
   M /trunk/src/gpu/command_buffer/common/cmd_buffer_common.cc
   M /trunk/src/gpu/command_buffer/common/cmd_buffer_common.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.h
   M /trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
   M /trunk/src/gpu/command_buffer/service/gpu_processor.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor.h
   A /trunk/src/gpu/command_buffer/service/gpu_processor_mac.cc
   M /trunk/src/gpu/gpu.gyp
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.cc
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.h
   A /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.cc
   A /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container.h
   A /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.cc
   A /trunk/src/webkit/glue/plugins/mac_gpu_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp
   M /trunk/src/webkit/tools/pepper_test_plugin/plugin_object.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/test_page.html
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/webkit.gyp

[GPU] Get GPU process running on the mac

Initial port of GPU process / plugin to Mac OS X. Uses new IOSurface
APIs and therefore currently runs only on 10.6. Alternate strategy
will need to be devised for 10.5.

Slight UI issues remain such as GPU plugins initially showing up in
the wrong place on the page. These will be fixed in follow-on bugs.

Minimal changes made to command buffer code to get it to compile on
Mac OS X. Commented out use of nested anonymous namespaces in
gles2_cmd_decoder.cc which were causing the linker to crash with a seg
fault.

Refactored gyp files so the OS test enabling the GPU plugin is in one
place, common.gypi, and other files test only the variable enable_gpu.

Slight change to gles2_demo_cc.cc to add some simple animation to
verify that updates from the GPU plugin are reaching the screen.
Changed Pepper test plugin to use 3D view by default and commented out
use of audio context because of recent issues.

TEST=none (ran Pepper Test Plugin with 3D view enabled)
BUG=http://crbug.com/25988

Review URL: http://codereview.chromium.org/558035
------------------------------------------------------------------------
r37932 | rohitrao@chromium.org | 2010-02-03 03:11:32 +0100 (Wed, 03 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.h
   A /trunk/src/chrome/browser/cocoa/floating_bar_backing_view.mm
   A /trunk/src/chrome/browser/cocoa/floating_bar_backing_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/fullscreen_controller.h
   A /trunk/src/chrome/browser/cocoa/fullscreen_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Adds code for fullscreen mode, including a floating dropdown toolbar and tabstrip.  This change does not enable the fullscreen menu item; a future CL will do that.

BUG=31638
TEST=No visible changes.  Unittests should pass.
Review URL: http://codereview.chromium.org/542013
------------------------------------------------------------------------
r37931 | wtc@chromium.org | 2010-02-03 03:09:36 +0100 (Wed, 03 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket/client_socket_factory.cc
   M /trunk/src/net/socket/client_socket_factory.h
   A /trunk/src/net/socket/ssl_client_socket_nss_factory.cc

Use NSS instead of the system SSL library for SSL if
the --use-nss-for-ssl or --use-flip command-line switch
is specified.

R=mark,mbelshe
BUG=28744
TEST=Run chrome.exe with and without --use-nss-for-ssl.
SSL should work in both cases.
Review URL: http://codereview.chromium.org/555186
------------------------------------------------------------------------
r37930 | mattm@chromium.org | 2010-02-03 03:08:45 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc

Linux: Font options handle font fallback better.

BUG=31381
TEST=see bug

Review URL: http://codereview.chromium.org/549216
------------------------------------------------------------------------
r37928 | ben@chromium.org | 2010-02-03 02:45:08 +0100 (Wed, 03 Feb 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/browser_view.cc
   D /trunk/src/chrome/browser/chromeos/browser_view.h
   A /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc (from /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc:37913)
   A /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h (from /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h:37913)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   D /trunk/src/chrome/browser/views/frame/browser_view_layout.cc
   D /trunk/src/chrome/browser/views/frame/browser_view_layout.h
   A /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h (from /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h:37913)
   A /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc (from /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc:37913)
   A /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h (from /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h:37913)
   M /trunk/src/chrome/chrome_browser.gypi

Revert 37914 - Move ChromeBrowserView* > BrowserView* and ChromeosBrowserView* > chromeos::BrowserView*

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/569019

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/562030
------------------------------------------------------------------------
r37927 | ben@chromium.org | 2010-02-03 02:43:41 +0100 (Wed, 03 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/browser_status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_status_area_view.h

Revert 37917 - Fix ChromeOS bustage.

BUG=none
TEST=none
TBR=oshima

Review URL: http://codereview.chromium.org/562028

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/561039
------------------------------------------------------------------------
r37926 | ben@chromium.org | 2010-02-03 02:43:04 +0100 (Wed, 03 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h

Revert 37923 - More Cros bustage fixing

TBR=oshima

Review URL: http://codereview.chromium.org/564026

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/563016
------------------------------------------------------------------------
r37925 | ben@chromium.org | 2010-02-03 02:42:26 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc

Revert 37924 - Final fix. Scope was wrong. TBR=oshima

Review URL: http://codereview.chromium.org/561038

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/563015
------------------------------------------------------------------------
r37924 | ben@chromium.org | 2010-02-03 02:35:15 +0100 (Wed, 03 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc

Final fix. Scope was wrong. TBR=oshima

Review URL: http://codereview.chromium.org/561038
------------------------------------------------------------------------
r37923 | ben@chromium.org | 2010-02-03 02:19:39 +0100 (Wed, 03 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_view.h

More Cros bustage fixing

TBR=oshima

Review URL: http://codereview.chromium.org/564026
------------------------------------------------------------------------
r37922 | finnur@chromium.org | 2010-02-03 02:17:26 +0100 (Wed, 03 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   A /trunk/src/chrome/browser/views/extensions/browser_action_drag_data.cc
   A /trunk/src/chrome/browser/views/extensions/browser_action_drag_data.h
   A /trunk/src/chrome/browser/views/extensions/browser_action_drag_data_unittest.cc
   M /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Support reordering of Browser Actions within the container. Currently does not support dragging to/from the chevron menu.

Also fixed two bugs in the same code:
- the container would be 0 width if a value for it hasn't been saved (part of bug 32101).
- the default icon was not used when a tab specific icon was not found (bug 34317).

BUG=http://crbug.com/26990, http://crbug.com/32101, http://crbug.com/34317
TEST=In both LTR and RTL locale, try reordering the browser actions and make sure to test dragging to the ends with and without a chevron visible. Install Send to Gmail extension and make sure it has an icon while in the overflow menu.
Review URL: http://codereview.chromium.org/549224
------------------------------------------------------------------------
r37921 | estade@chromium.org | 2010-02-03 02:16:27 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: fix some memory leaks, streamline a common operation.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/562019
------------------------------------------------------------------------
r37920 | oshima@chromium.org | 2010-02-03 02:15:07 +0100 (Wed, 03 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h

Hide compact location bar when a content area is clicked,
instead of when losing focus.

BUG=chromium-os:1264
TEST=manual. switch to compact nav bar mode, move mouse over to a tab to show
   a compact location bar, and copy the text in the text field.

Review URL: http://codereview.chromium.org/568014
------------------------------------------------------------------------
r37919 | andybons@chromium.org | 2010-02-03 02:13:21 +0100 (Wed, 03 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Page action icons were not being properly marked as needing to be redrawn when they were updated.

BUG=none
TEST=Install any page action that changes its icon based on clicking something in the popup (FlashBlock) and make sure that the icon updates without having to click within the location bar or change windows.
Review URL: http://codereview.chromium.org/561035
------------------------------------------------------------------------
r37917 | ben@chromium.org | 2010-02-03 02:10:32 +0100 (Wed, 03 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/browser_status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/browser_status_area_view.h

Fix ChromeOS bustage.

BUG=none
TEST=none
TBR=oshima

Review URL: http://codereview.chromium.org/562028
------------------------------------------------------------------------
r37915 | chase@chromium.org | 2010-02-03 01:55:28 +0100 (Wed, 03 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Revert 37913 - Clear local state (cookies, databases, local storage) on exit.

BUG=32719
TEST=none

Review URL: http://codereview.chromium.org/564012

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/564023
------------------------------------------------------------------------
r37914 | ben@chromium.org | 2010-02-03 01:37:48 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/browser_view.cc (from /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc:37896)
   A /trunk/src/chrome/browser/chromeos/browser_view.h (from /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h:37896)
   D /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   D /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/frame/browser_view_layout.cc (from /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc:37896)
   A /trunk/src/chrome/browser/views/frame/browser_view_layout.h (from /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h:37896)
   D /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h
   D /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc
   D /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h
   M /trunk/src/chrome/chrome_browser.gypi

Move ChromeBrowserView* -> BrowserView* and ChromeosBrowserView* -> chromeos::BrowserView*

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/569019
------------------------------------------------------------------------
r37913 | jochen@chromium.org | 2010-02-03 01:37:18 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h

Clear local state (cookies, databases, local storage) on exit.

BUG=32719
TEST=none

Review URL: http://codereview.chromium.org/564012
------------------------------------------------------------------------
r37912 | rsesek@chromium.org | 2010-02-03 01:36:07 +0100 (Wed, 03 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.h
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

Remove CookieTreeNode(UglyHacks) category because, as the name implies, it's ugly.

BUG=34267
TEST=Covered by unit tests

Review URL: http://codereview.chromium.org/561029
------------------------------------------------------------------------
r37911 | arv@chromium.org | 2010-02-03 01:35:23 +0100 (Wed, 03 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h

Clean up bookmark manager extension api code a bit.

The macros used to verify the extension adds a return false but our function used to return a BookmarkNode*. I now changed this to a helper funciton that returns a pointer and NULL in the case of failure.

I also added a GetBookmarkNodesFromArguments which returns a vector.

BUG=None
TEST=Bookmark manager copy/paste should still work.

Review URL: http://codereview.chromium.org/561024
------------------------------------------------------------------------
r37899 | sky@chromium.org | 2010-02-02 23:50:07 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc

Fixes leak in bookmark unit test.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/566022
------------------------------------------------------------------------
r37884 | skerner@chromium.org | 2010-02-02 22:37:45 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc

Move repetive testing code into a method of the base class used for testing extension actions.

BUG=None
TEST=Run unit tests that were altered.

Review URL: http://codereview.chromium.org/558046
------------------------------------------------------------------------
r37881 | sky@chromium.org | 2010-02-02 22:24:55 +0100 (Tue, 02 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc

Lands http://codereview.chromium.org/542006 for Thiago:

views: Add Cut/Copy/Paste items to the bookmark bar context menu. 

Based on this patch: http://codereview.chromium.org/536001/show 

BUG=32063
TEST=manually 

Review URL: http://codereview.chromium.org/563011
------------------------------------------------------------------------
r37880 | sky@chromium.org | 2010-02-02 22:20:54 +0100 (Tue, 02 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Adjusts tab strip model to deal with app tabs. There were a couple of
places where I left them using the variable with pinned when it should
be app because those places need to be radically whacked. I'll do that
next.

BUG=32845
TEST=none yet

Review URL: http://codereview.chromium.org/555173
------------------------------------------------------------------------
r37878 | chocobo@chromium.org | 2010-02-02 22:19:09 +0100 (Tue, 02 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/internet_page_view.cc
   M /trunk/src/chrome/browser/chromeos/settings_page_view.cc

Initial work for internet settings page.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/561027
------------------------------------------------------------------------
r37877 | estade@chromium.org | 2010-02-02 22:18:55 +0100 (Tue, 02 Feb 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.cc

Revert r37814 because it caused the "import bookmarks" link to be right-justified and caused the overflow button to appear when there was no overflow.

TBR=suzhe

r37814 | suzhe@chromium.org | 2010-02-02 00:30:24 -0800 (Tue, 02 Feb 2010) | 6 lines

[Linux] Make bookmark bar shrinkable when there is no bookmark.

BUG=none
TEST=Where there is no bookmark, an instruction will be displayed in the bookmark bar, which should be shrinkable when resizing the browser window.


Review URL: http://codereview.chromium.org/568025
------------------------------------------------------------------------
r37876 | estade@chromium.org | 2010-02-02 22:15:08 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: bookmark bar - fix z order of find bar in certain situations

BUG=33220
TEST=see bug

Review URL: http://codereview.chromium.org/567008
------------------------------------------------------------------------
r37873 | andybons@chromium.org | 2010-02-02 21:59:20 +0100 (Tue, 02 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_mac.mm

[Mac] Make the extension popup a singleton instance to avoid maintaining multiple pointer references to a class that, by design, can only have one popup open at a time.

The bug fixed in this change has to do with PageActionView having a dirty pointer to a popup if it was closed via losing its key state. Once a notification like EXTENSION_HOST_VIEW_SHOULD_CLOSE was fired, then the PageActionView would assume the pointer was valid and call on dirty memory.

TEST=none
BUG=29492,33590
Review URL: http://codereview.chromium.org/561013
------------------------------------------------------------------------
r37866 | shess@chromium.org | 2010-02-02 21:11:04 +0100 (Tue, 02 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac] Revert diagnostics for content popup bug.

Revert pamg's commit.

> Insert diagnostics in an attempt to track down a crash in popup menus
> in RenderWidgetHostViewMac::ShowPopupWithItems().

BUG=31716
TEST=none

Review URL: http://codereview.chromium.org/566018
------------------------------------------------------------------------
r37865 | albertb@google.com | 2010-02-02 21:00:51 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/chrome.gyp

Sync api changes to support preferences.

BUG=34174
TEST=none

Review URL: http://codereview.chromium.org/561010
------------------------------------------------------------------------
r37860 | arv@chromium.org | 2010-02-02 20:13:21 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

NTP: Make sure that hidden elements cannot be dragged.

BUG=34124
TEST=Hide thumbnails on NTP. Reload. Make sure you cannot drag the hidden thumbnails.

Review URL: http://codereview.chromium.org/568006
------------------------------------------------------------------------
r37856 | jorlow@chromium.org | 2010-02-02 20:01:42 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/base/nullable_string16.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.cc
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_permission_request.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi

Add support for fine grained permissions to use LocalStorage.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/565004
------------------------------------------------------------------------
r37855 | oshima@chromium.org | 2010-02-02 20:00:32 +0100 (Tue, 02 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc

Cleanup the code to adjust the size/location of compact navigation bar.
 Clipping happens when the location is not in Root's vibible rect.
 I think this is good and general enough to be used with different layouts.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/553177
------------------------------------------------------------------------
r37854 | avayvod@chromium.org | 2010-02-02 19:55:36 +0100 (Tue, 02 Feb 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/browser_status_area_view.cc (from /trunk/src/chrome/browser/chromeos/status_area_view.cc:37691)
   A /trunk/src/chrome/browser/chromeos/browser_status_area_view.h (from /trunk/src/chrome/browser/chromeos/status_area_view.h:37691)
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/language_menu_button.h
   A /trunk/src/chrome/browser/chromeos/status_area_host.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Made StatusAreaView and its buttons independent of BrowserWindow.
StatusAreaHost interface introduced so its other implementation can be used
for login wizard status area.

BUG=33197
TEST=No regression should be visible when logged in.

Review URL: http://codereview.chromium.org/552215
------------------------------------------------------------------------
r37851 | stuartmorgan@chromium.org | 2010-02-02 19:40:14 +0100 (Tue, 02 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Hide plugins in minimized/hidden windows on the Mac

Watch for window minizing and app hiding so we know when pages aren't visible for reasons other than being in background tabs. Manually hide plugins in non-visible windows, as a temporary workaround for bug 34266.

BUG=30838
TEST=Minimize a window or hide the application while a Flash or Quicktime movie is playing; CPU usage should be the same as if it were in a background tab.

Review URL: http://codereview.chromium.org/563010
------------------------------------------------------------------------
r37850 | joth@chromium.org | 2010-02-02 19:28:08 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/geolocation/backoff_manager.cc
   D /trunk/src/chrome/browser/geolocation/backoff_manager.h
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   A /trunk/src/chrome/browser/geolocation/geoposition.cc
   A /trunk/src/chrome/browser/geolocation/geoposition.h
   M /trunk/src/chrome/browser/geolocation/location_provider.cc
   M /trunk/src/chrome/browser/geolocation/location_provider.h
   M /trunk/src/chrome/browser/geolocation/location_provider_pool.cc
   M /trunk/src/chrome/browser/geolocation/location_provider_pool.h
   M /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   M /trunk/src/chrome/browser/geolocation/network_location_provider.h
   M /trunk/src/chrome/browser/geolocation/network_location_request.cc
   M /trunk/src/chrome/browser/geolocation/network_location_request.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   M /trunk/src/chrome/chrome_browser.gypi

Port the gears geolocation network provider to Chromium

BUG=http://crbug.com/11246
TEST=See http://codereview.chromium.org/556106

Review URL: http://codereview.chromium.org/552250
------------------------------------------------------------------------
r37848 | davemoore@chromium.org | 2010-02-02 19:25:56 +0100 (Tue, 02 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_wizard_view.cc

Change root pointer to arrow

Review URL: http://codereview.chromium.org/561011
------------------------------------------------------------------------
r37847 | davemoore@chromium.org | 2010-02-02 19:25:05 +0100 (Tue, 02 Feb 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   A /trunk/src/chrome/browser/chromeos/user_manager.cc
   A /trunk/src/chrome/browser/chromeos/user_manager.h
   M /trunk/src/chrome/chrome_browser.gypi

Remember logged in users

Review URL: http://codereview.chromium.org/553172
------------------------------------------------------------------------
r37841 | avi@chromium.org | 2010-02-02 18:04:55 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.mm

Hide/show cursor according to NSCursor requests.

BUG=http://crbug.com/32703
TEST=when hiding cursor (Flash 10.1), cursor hides (but doesn't stay hidden; that's a different bug)

Review URL: http://codereview.chromium.org/560003
------------------------------------------------------------------------
r37831 | pfeldman@chromium.org | 2010-02-02 16:48:52 +0100 (Tue, 02 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc

DevTools: fix TimelineApi test (followup fix for dispatchToApu rename).
TBR=knorton

Review URL: http://codereview.chromium.org/560014
------------------------------------------------------------------------
r37828 | pfeldman@chromium.org | 2010-02-02 15:52:47 +0100 (Tue, 02 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc

DevTools: Fixes Speed Tracer after message renames in r37251.
Original review: http://codereview.chromium.org/564006
TBR=knorton

------------------------------------------------------------------------
r37819 | pkasting@chromium.org | 2010-02-02 11:40:49 +0100 (Tue, 02 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   D /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   D /trunk/src/chrome/browser/blocked_popup_container_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.h
   D /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   D /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
   D /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   D /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_views.h
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Wire popup blocking UI to the new machinery and port over the user's old whitelist.

Notably, this removes the UI entirely for Mac and Linux.  We need to rebuild it.

This also guts the old system's testing, since most of it disappeared or changed radically.  We should test the new stuff.  I will file a followup bug for that.

There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears.  We can fix that sort of thing.  The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what.

BUG=33314
TEST=Go visit some sites with popups and play with things
Review URL: http://codereview.chromium.org/562013
------------------------------------------------------------------------
r37818 | pkasting@chromium.org | 2010-02-02 11:19:33 +0100 (Tue, 02 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/cookie_prompt_view.h
   A /trunk/src/chrome/browser/views/local_storage_info_view.cc
   A /trunk/src/chrome/browser/views/local_storage_info_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/cookie_monster.h

Modified cookie alert prompt window to suport displaying of local storage info as well.

Original patch by Zelidrag Hornung, r=me, tweaked.

BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/563007
------------------------------------------------------------------------
r37815 | jcampan@chromium.org | 2010-02-02 10:05:05 +0100 (Tue, 02 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h

Add the capability to translate an already translated page to
a different language.
We are keeping the text nodes and their original text around.  If another translate request arrives, we translate directly based on the text nodes and text stored.
The text nodes and original text chunks are deleted when a navigation to a new page occurs. 

BUG=None
TEST=Visit a page in a foreign language.  Have it translated.
     On the resulting infobar, change the target language.
     Make sure the page is translated correctly to the new
     selected language.

Review URL: http://codereview.chromium.org/567014
------------------------------------------------------------------------
r37814 | suzhe@chromium.org | 2010-02-02 09:30:24 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.cc

[Linux] Make bookmark bar shrinkable when there is no bookmark.

BUG=none
TEST=Where there is no bookmark, an instruction will be displayed in the bookmark bar, which should be shrinkable when resizing the browser window.

Review URL: http://codereview.chromium.org/552211
------------------------------------------------------------------------
r37813 | jcampan@chromium.org | 2010-02-02 09:23:53 +0100 (Tue, 02 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.h
   M /trunk/src/chrome/browser/translate/translate_manager.cc

Translating from the English locale would translate to Afrikaans.
This is because the English locale 'en-US' would not match the English
language code 'en' and we would default to the 1st language, Afrikaan.

BUG=None
TEST=Test that translate when Chrome is configured in English (US and UK),
     Spanish, Portuguese (Brazil and Portugal) does translate to the
     language Chrome is configured to be in.
TBR=kuan

Review URL: http://codereview.chromium.org/563005
------------------------------------------------------------------------
r37809 | kuan@chromium.org | 2010-02-02 07:42:11 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.h
   M /trunk/src/chrome/browser/translate/languages_menu_model.cc
   M /trunk/src/chrome/browser/translate/options_menu_model.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h

implement proper localized display names for translate languages
- in the process, modify to use indexes into vector of languages to communicate between infobars and delegates

BUG=31297
TEST=verify that language names in translate infobars' language buttons, dropdown lists and options are properly localized.
Review URL: http://codereview.chromium.org/566012
------------------------------------------------------------------------
r37797 | sky@chromium.org | 2010-02-02 06:13:31 +0100 (Tue, 02 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   A /trunk/src/chrome/browser/views/options/content_exceptions_table_model.cc
   A /trunk/src/chrome/browser/views/options/content_exceptions_table_model.h
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   A /trunk/src/chrome/browser/views/options/exception_editor_view.cc
   A /trunk/src/chrome/browser/views/options/exception_editor_view.h
   A /trunk/src/chrome/browser/views/options/exceptions_view.cc
   A /trunk/src/chrome/browser/views/options/exceptions_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Adds content exception dialog.

BUG=NONE
TEST=Make sure the content exception dialog (options->under the
  hood->content settings->exceptions (for all tabs)) and editor work
  correctly. Specifically try adding/removing and make sure they persist
  correctly.

Review URL: http://codereview.chromium.org/564007
------------------------------------------------------------------------
r37795 | mattm@chromium.org | 2010-02-02 05:43:14 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Fix bookmark bar observer callbacks accessing gtk widgets after they are destroyed.

BUG=none
TEST=run browser_tests, look for Gtk-CRITICAL errors.

Review URL: http://codereview.chromium.org/562009
------------------------------------------------------------------------
r37790 | jorlow@chromium.org | 2010-02-02 03:50:28 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Add a runtime flag for Indexed Database.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/553161
------------------------------------------------------------------------
r37789 | jorlow@chromium.org | 2010-02-02 03:46:14 +0100 (Tue, 02 Feb 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/storage/domstorage/localstorage/string-conversion-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/storage/domstorage/sessionstorage/string-conversion-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/storage/domstorage/localstorage/string-conversion-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/storage/domstorage/sessionstorage/string-conversion-expected.txt

Update the DOM Storage UI test to run all the layout tests that currently run.

2 of the comented out ones crash and need investigation.

The rest have output that are too big for a cookie.  It's a low-priority todo to find a better solution for these since there's a decent amount of coverage provided by the tests that do run and the runs in test shell.

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/548174
------------------------------------------------------------------------
r37788 | thakis@chromium.org | 2010-02-02 03:36:25 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/notification_type.h

Send a message to the renderers when content settings change.

BUG=32719
TEST=none

Review URL: http://codereview.chromium.org/551225
------------------------------------------------------------------------
r37785 | suzhe@chromium.org | 2010-02-02 03:28:02 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

[Linux] Allows find bar's GtkEntry to handle the key events first.

BUG=32384: IME within search box doesn't accept text properly
TEST=See the bug report.

Review URL: http://codereview.chromium.org/560006
------------------------------------------------------------------------
r37781 | evan@chromium.org | 2010-02-02 02:24:49 +0100 (Tue, 02 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/base/sys_string_conversions_linux.cc
   M /trunk/src/base/unix_domain_socket_posix.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/ipc/ipc_message.h
   M /trunk/src/net/base/address_list.cc

linux: uncontroversial cleanups found by clang

Part of a larger patch to use clang to warning-check our code.

Review URL: http://codereview.chromium.org/561008
------------------------------------------------------------------------
r37776 | eroman@chromium.org | 2010-02-02 01:56:35 +0100 (Tue, 02 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/io_thread.cc
   M /trunk/src/net/base/fixed_host_resolver.h
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_unittest.cc
   M /trunk/src/net/url_request/url_request_view_net_internals_job.cc

Add fine grain tracing to HostResolverImpl.

This will help in diagnosing the "slow resolving host" bugs.

Users can now click an "Enable tracing" button on "chrome://net-internals/hostresolver".
This logs detailed information on the DNS requests flowing through the browser (when they were received, when they were posted to the thread pool, when they started running on the worker thread, etc...).

BUG=12754

Review URL: http://codereview.chromium.org/556094
------------------------------------------------------------------------
r37775 | pkasting@chromium.org | 2010-02-02 01:55:01 +0100 (Tue, 02 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Migrate old cookie setting to new system.

Also, do a better job of making sure we don't write useless default values to disk, and we force the in-memory copy of the default prefs to never say "DEFAULT" even if a caller provides that to SetDefaultContentSetting().

BUG=32719
TEST=unittests
Review URL: http://codereview.chromium.org/562003
------------------------------------------------------------------------
r37772 | estade@chromium.org | 2010-02-02 01:39:30 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

GTK: bookmark manager - fix coordinate check in multi-row drag workaround.

BUG=33907
TEST=see bug

Review URL: http://codereview.chromium.org/565005
------------------------------------------------------------------------
r37771 | estade@chromium.org | 2010-02-02 01:39:01 +0100 (Tue, 02 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: fix sign of comparison in bookmark bar

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557088
------------------------------------------------------------------------
r37770 | finnur@chromium.org | 2010-02-02 01:34:15 +0100 (Tue, 02 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Looks like the fix I did last time did work. According to the
flakiness dashboard this hasn't failed since the day I checked
in the fix (Jan 26th).

BUG=http://crbug.com/16447
TEST=None (making a change to a test)

Review URL: http://codereview.chromium.org/565006
------------------------------------------------------------------------
r37763 | pkasting@chromium.org | 2010-02-02 00:30:07 +0100 (Tue, 02 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

A few miscellaneous changes in the Template URL Prepopulate area:
* Make sure that when migrating away from the old pref the old pref gets erased.
* Make sure the unittest is testing all the countries in the data file.
* Make sure we explicitly handle or don't handle all the countries the unittest tests.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/565003
------------------------------------------------------------------------
r37762 | pkasting@chromium.org | 2010-02-02 00:18:52 +0100 (Tue, 02 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Fix a pet peeve: Big empty hole in Chromium builds where the UMA checkbox would be.

BUG=none
TEST=Open advanced prefs in a Chromium build, note no big gaps.
Review URL: http://codereview.chromium.org/556096
------------------------------------------------------------------------
r37761 | albertb@google.com | 2010-02-02 00:15:12 +0100 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/protocol/preference_specifics.proto

Proto extenions to sync preferences.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/561003
------------------------------------------------------------------------
r37754 | thomasvl@chromium.org | 2010-02-01 23:29:49 +0100 (Mon, 01 Feb 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host

Manual code review: added Xcode ignore
------------------------------------------------------------------------
r37746 | jcampan@chromium.org | 2010-02-01 22:52:15 +0100 (Mon, 01 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_manager.cc

The "after infobar" could be sticky in some cases.
Make sure we always remove it before showing a new "before translate" infobar.

BUG=34076 
TEST=See bug.

Review URL: http://codereview.chromium.org/552258
------------------------------------------------------------------------
r37743 | stuartmorgan@chromium.org | 2010-02-01 22:23:43 +0100 (Mon, 01 Feb 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Add tab switch notification to the Mac plugin plumbing.

Using the new notification:
- Update plugin clip rect when it's not in a visible tab.
- Update plugin idle event rate when it's not in a visible tab.
- Switch the unfocus-on-tab-switch event to be based on the this new notification, instead of a browser-level broadcast.

Related changes:
- Stop sending redundant focus events to plugins.
- Send window activation to Carbon event plugins too, not just Cocoa.
- Now that plugins are getting window and tab de-focus events directly, remove the older hack to force all plugins to lose focus any window or tab loses focus.

BUG=29371, 32229, 30838
TEST=Flash should still only register keystrokes when it is in the active window+tab. Plugins in background tabs should use less CPU.

Review URL: http://codereview.chromium.org/548224
------------------------------------------------------------------------
r37736 | snej@chromium.org | 2010-02-01 21:39:06 +0100 (Mon, 01 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm

Fix Mac browser crash in BookmarkMenuBridge::UpdateMenu.
BUG=33890
TEST=none (see steps to repro in bug report)

Review URL: http://codereview.chromium.org/557085
------------------------------------------------------------------------
r37732 | georgey@chromium.org | 2010-02-01 21:24:48 +0100 (Mon, 01 Feb 2010) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/autofill/autofill_dialog_win.cc
   D /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.cc
   D /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.h
   A /trunk/src/chrome/browser/views/autofill_profiles_view_win.cc (from /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.cc:37562)
   A /trunk/src/chrome/browser/views/autofill_profiles_view_win.h (from /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.h:37562)
   M /trunk/src/chrome/chrome_browser.gypi

Moved Autofill view to appropriate browser/views folder.
BUG=33026
TEST=none
Review URL: http://codereview.chromium.org/558051
------------------------------------------------------------------------
r37731 | shess@chromium.org | 2010-02-01 21:21:36 +0100 (Mon, 01 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Enable some left-behind unit tests.

NavicationControllerTest, TaskManagerTest and BackFwdMenuModelTest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/557063
------------------------------------------------------------------------
r37727 | estade@chromium.org | 2010-02-01 20:33:02 +0100 (Mon, 01 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

task manager gtk:

When sorting by a column that is shared by resources in a group (e.g. process id or CPU, but not network), make sure those rows are grouped.

Also get rid of the confusing grid lines. I think we want separators between groups, but getting them to draw properly without introducing huge complexity to the code is hard.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/555177
------------------------------------------------------------------------
r37726 | estade@chromium.org | 2010-02-01 20:32:47 +0100 (Mon, 01 Feb 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Task manager model: Make a find quicker.

Given a list such as

00000222223333

and an index i into that list, find the first occurrence of the value of list[i]. The current code just does a plain search. The new code does a reverse search starting at i.

The reason I am bothering to optimize this is because it is used in TaskManagerGtk::CompareImpl, pending my other cl.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/553155
------------------------------------------------------------------------
r37725 | estade@chromium.org | 2010-02-01 20:32:31 +0100 (Mon, 01 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Make page and app menus shortcut control flow match windows more closely.

BUG=33471
TEST=alt+f, alt+e

Review URL: http://codereview.chromium.org/551214
------------------------------------------------------------------------
r37724 | pkasting@chromium.org | 2010-02-01 20:31:30 +0100 (Mon, 01 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Make pressing <esc> while dragging in the omnibox correctly cancel dragging.  Original patch by Philippe Beaudoin (see http://codereview.chromium.org/554143 ), r=me, tweaked.

BUG=33460
TEST=Write goog in the omnibox, drag around, while pressing the left mouse button hit ESC.  The selection should return to the first entry and not move as you continue to drag.
------------------------------------------------------------------------
r37722 | erg@google.com | 2010-02-01 20:04:54 +0100 (Mon, 01 Feb 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak

Don't store IDR ids in ThemePack files as they change whenever the grd is modified.

Instead, add an association table at the top of browser_theme_pack.cc that maps
the JSON string name and IDR# to a stable constant that won't change between
releases.

The ThemePack version number has been bumped to two, forcing a rebuild.

BUG=33416
TEST=none

Review URL: http://codereview.chromium.org/548207
------------------------------------------------------------------------
r37720 | gregoryd@google.com | 2010-02-01 19:57:09 +0100 (Mon, 01 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/dummy_main_functions.cc
   M /trunk/src/chrome/browser/memory_details.cc
   A /trunk/src/chrome/browser/nacl_host
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/nacl_cmd_line.cc
   A /trunk/src/chrome/common/nacl_cmd_line.h
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_win.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   A /trunk/src/chrome/nacl/broker_thread.cc
   A /trunk/src/chrome/nacl/broker_thread.h
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl.gypi
   M /trunk/src/chrome/renderer/render_process.cc

Implement the broker process that launches NaCl loader processes on 64-bit Windows systems. 

BUG=28176
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37578
Review URL: http://codereview.chromium.org/542030
------------------------------------------------------------------------
r37718 | asargent@chromium.org | 2010-02-01 19:52:18 +0100 (Mon, 01 Feb 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc

Get rid of check that caused redirects to fail extension updates.

When the extension autoupdater downloads .crx files, we rely on the UrlFetcher 
class to do it for us. Inside OnCrxFetchComplete I had put a sanity check that 
the url we finished with was the same one we started with, but of course this 
breaks the case of redirects and wasn't needed because the API of UrlFetcher is
that there's one UrlFetcher per outstanding fetch.

BUG=26177
TEST=Extension Autoupdate should keep working normally, and work with redirects
such as the example mentioned in the bug.


Review URL: http://codereview.chromium.org/549215
------------------------------------------------------------------------
r37717 | xiyuan@chromium.org | 2010-02-01 19:51:41 +0100 (Mon, 01 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/select_file_dialog.cc

Allow FileBrowse to change title of open/save dialog

Add a DOMMessageHandler to FileBrowse based SelectFileDialog that supports
a "setDialogTitle" call from javascript.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/554136
------------------------------------------------------------------------
r37716 | xiyuan@chromium.org | 2010-02-01 19:48:40 +0100 (Mon, 01 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/select_file_dialog.cc

Fix type of file_type_index_ from size_t to int to get rid of printf format warning.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/552253
------------------------------------------------------------------------
r37714 | pvalchev@google.com | 2010-02-01 19:37:14 +0100 (Mon, 01 Feb 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc

BSD port: chrome/app and chrome/browser ifdef cleaning
Review URL: http://codereview.chromium.org/548203
------------------------------------------------------------------------
r37703 | mirandac@chromium.org | 2010-02-01 18:56:11 +0100 (Mon, 01 Feb 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm

Fix Valgrind error in ExtensionInstalledBubble unit test.

BUG= 34052
TEST= no valgrind error.
Review URL: http://codereview.chromium.org/555199
------------------------------------------------------------------------
r37702 | albertb@google.com | 2010-02-01 18:51:03 +0100 (Mon, 01 Feb 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/database_model_worker.cc
   A /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   A /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implementation of the DatabaseModelWorker, take 2.

BUG=none
TEST=unit tests

Review URL: http://codereview.chromium.org/557043
------------------------------------------------------------------------
r37701 | thakis@chromium.org | 2010-02-01 18:44:39 +0100 (Mon, 01 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_button.h
   M /trunk/src/chrome/browser/cocoa/download_item_button.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

Show download item menu on mouse down instead of mouse up.

BUG=20812
TEST=
* Click right part of download item. Menu should appear on mouse down.
* After menu is closed, mousing over the menu should not show the depressed state.
* Click left part of download item. File should be opened on mouse up.
* http://crbug.com/28215 should not have regressed.

Review URL: http://codereview.chromium.org/380002
------------------------------------------------------------------------
r37700 | tim@chromium.org | 2010-02-01 18:43:57 +0100 (Mon, 01 Feb 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Speculative fix for thread sanitizer failures in ProfileSyncServiceTest.
We should not raise an "auth needed" event if we're not supposed to attempt
auth in the first place.

TBR=albertb

Review URL: http://codereview.chromium.org/549222
------------------------------------------------------------------------
r37698 | avi@chromium.org | 2010-02-01 17:30:47 +0100 (Mon, 01 Feb 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/dock_icon.h
   A /trunk/src/chrome/browser/cocoa/dock_icon.mm
   M /trunk/src/chrome/browser/cocoa/download_util_mac.mm
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/chrome_browser.gypi

Add temporary download progress overlay to the dock icon for the Mac (real UI coming soon), and provide the hooks for the Win7 implementation.

BUG=http://crbug.com/8039
TEST=download; see progress in the dock icon

Review URL: http://codereview.chromium.org/545157
------------------------------------------------------------------------
r37695 | rsesek@chromium.org | 2010-02-01 17:11:27 +0100 (Mon, 01 Feb 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.h
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] Reduce jank in the cookie manager by lazily creating child nodes for the UI.

Also selects the first cookie node whene expanding an origin node.

BUG=33248
TEST=With a lot of cookies in your profile: Chromium-->Preferences-->Under the Hood-->Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily.

Review URL: http://codereview.chromium.org/554151
------------------------------------------------------------------------
r37693 | avi@chromium.org | 2010-02-01 16:54:24 +0100 (Mon, 01 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

Keep packages from being selected in a Cocoa open single file dialog.

Patch from Vernon Tang.

BUG=33483
TEST=Check that user can't select an .app using an html file input element. Check that the "load unpacked extension" and "pack extension" browse dialogs in chrome://extensions/ continue to work as expected.

Review URL: http://codereview.chromium.org/548199

------------------------------------------------------------------------
r37689 | jeremy@chromium.org | 2010-02-01 11:56:53 +0100 (Mon, 01 Feb 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome_tests.gypi

OS X: Import settings dialog cleanup.

* Make Import settings dialog app modal.
* No longer allow display of multiple dialogs at once.
* For some reason, unit test was present but missing from .gyp file - re-added and freshened up.

BUG=33011
TEST=selecting Chrome->Import Bookmarks and settings multiple times should only open bookmarks once.

Review URL: http://codereview.chromium.org/556097
------------------------------------------------------------------------
r37688 | jcampan@chromium.org | 2010-02-01 09:45:15 +0100 (Mon, 01 Feb 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   A /trunk/src/chrome/browser/translate/translate_manager.cc
   A /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h
   M /trunk/src/chrome/renderer/translate/page_translator_unittest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Relanding the hooking of the translate feature UI.
See http://codereview.chromium.org/549217

Review URL: http://codereview.chromium.org/558065
------------------------------------------------------------------------
r37686 | kinuko@chromium.org | 2010-02-01 08:47:06 +0100 (Mon, 01 Feb 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Always percent-escape the copied URL when all the text in the address bar is selected.

BUG=29397
TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 and select entire text in Omnibox, then copy the text.
Paste the copied text into other applications such as gedit and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 上地.
Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website.
Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0.
TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 again and select "q=上地" in Omnibox, then copy the text.
Paste it into somewhere and check if you see "q=上地".
TEST=Copy "上地" from somewhere and paste it into Omnibox.
Copy from Omnibox and paste it into other apps such as gedit. Then check if the pasted text is NOT encoded.
TEST=Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 上地.                                                      Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0".
TEST=Steps described in http://codereview.chromium.org/173098.

Review URL: http://codereview.chromium.org/465053
------------------------------------------------------------------------
r37680 | tony@chromium.org | 2010-02-01 02:42:04 +0100 (Mon, 01 Feb 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix a bug where we were only checking the screen size of
the default monitor, not the current monitor when disabling the
full screen hack in metacity/compiz.

This is just a guess, I don't have a multimonitor setup here.

BUG=32347

Review URL: http://codereview.chromium.org/557056
------------------------------------------------------------------------
r37676 | thakis@chromium.org | 2010-01-31 23:51:44 +0100 (Sun, 31 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm

Mac: Theme status text of download items.

Slightly complicated because the default theme's "clicked" gradient is not transparent.

BUG=21176
TEST=Start long download (e.g. ubuntu disk image), then go through a lot of themes and make sure the status text stays readable, both in normal and clicked states. Also check with default theme.

Review URL: http://codereview.chromium.org/551224
------------------------------------------------------------------------
r37675 | jcampan@chromium.org | 2010-01-31 23:38:44 +0100 (Sun, 31 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   D /trunk/src/chrome/browser/translate/translate_manager.cc
   D /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h
   M /trunk/src/chrome/renderer/translate/page_translator_unittest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Revert 37674 - Hooking the UI part to the translate feature.

Review URL: http://codereview.chromium.org/549217

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/555195
------------------------------------------------------------------------
r37674 | jcampan@chromium.org | 2010-01-31 23:31:04 +0100 (Sun, 31 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   A /trunk/src/chrome/browser/translate/translate_manager.cc
   A /trunk/src/chrome/browser/translate/translate_manager.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h
   M /trunk/src/chrome/renderer/translate/page_translator_unittest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Hooking the UI part to the translate feature.

Review URL: http://codereview.chromium.org/549217
------------------------------------------------------------------------
r37672 | mirandac@chromium.org | 2010-01-31 23:06:50 +0100 (Sun, 31 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm

Initialize arrowPoint so that warnings don't break Mac compile in new extension bubble.

BUG= none
TEST= none

Review URL: http://codereview.chromium.org/556098
------------------------------------------------------------------------
r37671 | mirandac@chromium.org | 2010-01-31 22:45:17 +0100 (Sun, 31 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/nibs/ExtensionInstalledBubble.xib
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   A /trunk/src/chrome/browser/cocoa/extension_installed_bubble_bridge.h
   A /trunk/src/chrome/browser/cocoa/extension_installed_bubble_bridge.mm
   A /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.h
   A /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm
   A /trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

ExtensionInstalledBubble for Mac.

Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields).

BUG= 26974
TEST= Install an extension. Bubble should show same information as windows bubble.
Review URL: http://codereview.chromium.org/527012
------------------------------------------------------------------------
r37665 | davemoore@chromium.org | 2010-01-31 21:08:44 +0100 (Sun, 31 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login_manager_view.h
   A /trunk/src/chrome/browser/chromeos/login_wizard_view.cc
   A /trunk/src/chrome/browser/chromeos/login_wizard_view.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi

Initial implementation for wizard.

BUG=1426
TEST=Enable Chrome based login-manager. Login should work.

Review URL: http://codereview.chromium.org/553132
------------------------------------------------------------------------
r37659 | darin@chromium.org | 2010-01-31 09:14:09 +0100 (Sun, 31 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc

Re-enable the cookie policy browser tests.

This is a simple change to replace the old preference-using code w/
code that just pokes the HostContentSettingsMap directly to toggle
the third-party cookie blocking setting.

R=pkasting

Review URL: http://codereview.chromium.org/548218
------------------------------------------------------------------------
r37654 | aa@chromium.org | 2010-01-31 01:58:14 +0100 (Sun, 31 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

The upstream change to make popup shrinking work properly is a big project, so I'm doing a quick hack here so that we don't ship more builds with it broken.

BUG=30291
TEST=Install news sample extension. Expand a section, then contract it. Popup should contract too.

Review URL: http://codereview.chromium.org/556058
------------------------------------------------------------------------
r37652 | pkasting@chromium.org | 2010-01-31 01:36:23 +0100 (Sun, 31 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc

Fix some bugs related to default-clearing in the HostContentSettingsMap, and clean up various other bits.

This also adds some functionality useful to the Exceptions dialogs.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557074
------------------------------------------------------------------------
r37651 | arv@chromium.org | 2010-01-31 01:10:31 +0100 (Sun, 31 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Ignore ref (hash fragment) in URL when opening singleton tabs based on URLs.

I renamed the method name in preparation of using this for opening the bookmark manager extension.

BUG=None
TEST=Open History. Do a search and open history again. We should not create a new tab but go to the existing one.

Review URL: http://codereview.chromium.org/553151
------------------------------------------------------------------------
r37649 | darin@chromium.org | 2010-01-30 22:48:57 +0100 (Sat, 30 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc

If the URLRequestContext has no CookiePolicy, then we should
allow cookies instead of denying them.

I broke this yesterday when I made the CookiePolicy be an optional
element of the URLRequestContext.  See r37624.

R=pkasting
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/557073
------------------------------------------------------------------------
r37648 | arv@chromium.org | 2010-01-30 22:45:18 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/bookmark_manager/test.js
   M /trunk/src/chrome/test/data/extensions/bookmarkmanager/main.html

Expose sortChildren to the bookmark manager extension API and use that from the bookmark manager.

BUG=32194
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.BookmarkManager

Review URL: http://codereview.chromium.org/551220
------------------------------------------------------------------------
r37647 | arv@chromium.org | 2010-01-30 22:44:42 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Add work around for recent changes to HTML5 DnD behavior.

BUG=33657
TEST=Drag and drop thumbnails on the NTP to reorder them.

Review URL: http://codereview.chromium.org/558055
------------------------------------------------------------------------
r37641 | viettrungluu@chromium.org | 2010-01-30 18:06:59 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

Trivial fix: static -> const.

BUG=none
TEST=still compiles

Review URL: http://codereview.chromium.org/555189
------------------------------------------------------------------------
r37639 | viettrungluu@chromium.org | 2010-01-30 17:58:40 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target.h
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm

Mac: fix crash when blank URL lists dragged to/over web content.

BUG=33696
TEST=See bug report for repro steps and make sure they no longer apply. Verify that dragging stuff to web contents works as before.

Review URL: http://codereview.chromium.org/551221
------------------------------------------------------------------------
r37631 | pkasting@chromium.org | 2010-01-30 11:02:16 +0100 (Sat, 30 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/common/content_settings.h
   M /trunk/src/chrome/common/content_settings_types.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Hook up some of the content settings UI to the actual settings map object.  This also rewrites the affected UI bits to make it easier to do this, get rid of unnecessary code, and be more consistent with the blocked content bubble code.

BUG=32719
TEST=Content settings windows now have radio buttons that work, and remember their settings.  The Flash link works too.
Review URL: http://codereview.chromium.org/558060
------------------------------------------------------------------------
r37628 | thakis@chromium.org | 2010-01-30 10:31:01 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/common/common_param_traits.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

IPC per-host content settings to the renderers.

BUG=32719
TEST=none

Review URL: http://codereview.chromium.org/549218
------------------------------------------------------------------------
r37625 | darin@chromium.org | 2010-01-30 09:39:25 +0100 (Sat, 30 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc

Fix compilation error.  Oops!

TBR=pkasting

Review URL: http://codereview.chromium.org/552247
------------------------------------------------------------------------
r37624 | darin@chromium.org | 2010-01-30 09:24:12 +0100 (Sat, 30 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/net/base/cookie_policy.h
   A /trunk/src/net/base/static_cookie_policy.cc (from /trunk/src/net/base/cookie_policy.cc:37557)
   A /trunk/src/net/base/static_cookie_policy.h (from /trunk/src/net/base/cookie_policy.h:37557)
   A /trunk/src/net/base/static_cookie_policy_unittest.cc (from /trunk/src/net/base/cookie_policy_unittest.cc:37557)
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Changes to support new cookie policy.

Changes:
1- net::CookiePolicy becomes an interface.
2- Old implementaiton of CookiePolicy copied to StaticCookiePolicy.
3- ChromeULRRequestContext implements CookiePolicy.
4- HostContentSettingsMap gets a global "BlockThirdPartyCookies" pref.

R=pkasting

Review URL: http://codereview.chromium.org/556095
------------------------------------------------------------------------
r37621 | thakis@chromium.org | 2010-01-30 07:37:36 +0100 (Sat, 30 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm
   A /trunk/src/chrome/browser/cocoa/download_item_button.h
   A /trunk/src/chrome/browser/cocoa/download_item_button.mm
   A /trunk/src/chrome/browser/cocoa/download_item_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   A /trunk/src/chrome/browser/cocoa/draggable_button.h
   A /trunk/src/chrome/browser/cocoa/draggable_button.mm
   A /trunk/src/chrome/browser/cocoa/draggable_button_unittest.mm (from /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm:37619)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Make download items drag sources on OS X.

Extract button dragging out of BookmarkButton into DraggableButton. Make BookmarkButton a subclass of DraggableButton. Create new class DownloadItemButton and make it a subclass of DraggableButton.

xib change: Make download item a DownloadItemButton instead of an NSButton.

BUG=15776
TEST=Download something, wait for it to complete, then drag it from the download shelf to somewhere. It should now work. Bookmarks should still be draggable in the bookmarks bar.

Review URL: http://codereview.chromium.org/180036
------------------------------------------------------------------------
r37614 | pkasting@chromium.org | 2010-01-30 06:31:35 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc

Third take at fixing Linux views build

TBR=darin
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/558056
------------------------------------------------------------------------
r37611 | pkasting@chromium.org | 2010-01-30 05:47:59 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc

Fix some signedness issues.

TBR=darin
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/557069
------------------------------------------------------------------------
r37609 | pkasting@chromium.org | 2010-01-30 05:29:52 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc
   A /trunk/src/chrome/browser/views/content_blocked_bubble_contents.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/test_location_bar.h

Add basic support for Content Blocked icons in the omnibox.  Not yet 
hooked to anything, so they'll never appear.

BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/556077
------------------------------------------------------------------------
r37605 | rohitrao@chromium.org | 2010-01-30 04:33:18 +0100 (Sat, 30 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc

Fix build break.

BUG=None
TEST=Build builds
Review URL: http://codereview.chromium.org/556088
------------------------------------------------------------------------
r37603 | pkasting@chromium.org | 2010-01-30 03:53:39 +0100 (Sat, 30 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/host_content_settings_map.cc
   M /trunk/src/chrome/browser/host_content_settings_map.h
   M /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/content_permission_types.h
   A /trunk/src/chrome/common/content_settings.h (from /trunk/src/chrome/common/content_permission_types.h:37532)
   A /trunk/src/chrome/common/content_settings_types.h
   M /trunk/src/chrome/test/testing_profile.h

Rewrite the HostContentSettingsMap to address some issues:
* Interface not well-designed for the actual uses
* Objects in URL request context must be refcounted since Profile is destroyed before the UI thread

BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/555184
------------------------------------------------------------------------
r37602 | pkasting@chromium.org | 2010-01-30 03:42:39 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/host_zoom_map.cc

One more place I forgot to lock.

TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557068
------------------------------------------------------------------------
r37601 | pkasting@chromium.org | 2010-01-30 03:30:42 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_perftest.cc

Fix silly failure to actually initialize the scoped_refptrs.

TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553162
------------------------------------------------------------------------
r37600 | pkasting@chromium.org | 2010-01-30 02:56:17 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_perftest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc

Didn't realize the RefCountedThreadSafe means "no more stack-allocated objects".

TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553160
------------------------------------------------------------------------
r37598 | cpu@chromium.org | 2010-01-30 02:29:45 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

More brands for rlz

BUG=33606
TEST=none

Review URL: http://codereview.chromium.org/548210
------------------------------------------------------------------------
r37597 | estade@chromium.org | 2010-01-30 02:18:56 +0100 (Sat, 30 Jan 2010) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.h
   A /trunk/src/chrome/browser/extensions/extension_accessibility_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   A /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   A /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.cc
   A /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/accessibility_events.cc
   A /trunk/src/chrome/common/accessibility_events.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Add an accessibility API for events raised outside of the web content.

BUG=none
TEST=none
patch by Dominic Mazzoni <dmazzoni [at] google>
review url: http://codereview.chromium.org/402099/show

------------------------------------------------------------------------
r37596 | pkasting@chromium.org | 2010-01-30 02:17:54 +0100 (Sat, 30 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h

Make the Blacklist in the URL request context refcounted, since the Profile gets destroyed before the IO thread.

Also some other random misc. cleanup.

TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/554140
------------------------------------------------------------------------
r37595 | pkasting@chromium.org | 2010-01-30 02:09:33 +0100 (Sat, 30 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/host_zoom_map.cc
   M /trunk/src/chrome/browser/host_zoom_map.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

A few fixes for the HostZoomMap:
* Persist changes from Incognito (per UI leads)
* Clear the zoom settings when the user does "reset to defaults" in prefs

BUG=none
TEST=Open incognito, change a zoom level, restart, see that it's persisted
Review URL: http://codereview.chromium.org/551213
------------------------------------------------------------------------
r37585 | ananta@chromium.org | 2010-01-30 01:47:06 +0100 (Sat, 30 Jan 2010) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome_frame/test/net/test_automation_provider.cc

In IE8 new windows opened within ChromeFrame via window.open calls at times bypass the host network stack.

In this case we don't get control over the navigation as window.open calls expect to carry the opener
relationship over to the new window. This basically means that navigation occurs in Chrome and the 
new tab/window created by the host attaches to the newly created ExternalTabContainer instance.

In IE8 the new tab opens in a new IE process, which basically uses a new automation channel to talk to
Chrome. The host network stack implementation routes network requests issued by registered render views
to the host browser over the automation channel. There is a timing window between the new window getting
created and issuing network requests and the channel being established with the new iexplore instance.
As a result network requests issued by the new window don't use the host network stack.

Fix is to register the render view and process as a pending view when we get notified about the new TabContents
in the original ExternalTabContainers implementation of TabContentsDelegate::AddNewContents. Any network requests
issued for this view would result in the corresponding URLRequestAutomationJob instances getting created as 
pending as well. When the host browser connects to the new ExternalTabContainer instance, we pass over the new
automation channel and tab handle to the URLRequestAutomationJob instances and resume them.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=33516

Bug=33516
Test=Login to gmail in IE8 in ChromeFrame. Open up a new conversation and click on New Window which opens up
     a tear off window. This should not bring up the login prompt again.

Will think about a good approach to write a unit test for this behavior and send out a separate CL for that.

Review URL: http://codereview.chromium.org/554134
------------------------------------------------------------------------
r37583 | jcampan@chromium.org | 2010-01-30 01:40:58 +0100 (Sat, 30 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/page_translator.h

Implemented the undo translation in the renderer. 
This reverts the page's text to its original (pre-translation) value. 

BUG=None 
TEST=None 

Review http://codereview.chromium.org/554104/show

Review URL: http://codereview.chromium.org/555175
------------------------------------------------------------------------
r37580 | gregoryd@google.com | 2010-01-30 01:29:54 +0100 (Sat, 30 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/dummy_main_functions.cc
   M /trunk/src/chrome/browser/memory_details.cc
   D /trunk/src/chrome/browser/nacl_host
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/chrome/common/nacl_cmd_line.cc
   D /trunk/src/chrome/common/nacl_cmd_line.h
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_win.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   D /trunk/src/chrome/nacl/broker_thread.cc
   D /trunk/src/chrome/nacl/broker_thread.h
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl.gypi
   M /trunk/src/chrome/renderer/render_process.cc

Revert 37578 - Implement the broker process that launches NaCl loader processes on 64bit Windows systems. 

BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/542030

TBR=gregoryd@google.com
------------------------------------------------------------------------
r37579 | davemoore@chromium.org | 2010-01-30 01:12:58 +0100 (Sat, 30 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc

Keep loginwindow from flashing at startup

Review URL: http://codereview.chromium.org/554138
------------------------------------------------------------------------
r37578 | gregoryd@google.com | 2010-01-30 01:10:10 +0100 (Sat, 30 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/dummy_main_functions.cc
   M /trunk/src/chrome/browser/memory_details.cc
   A /trunk/src/chrome/browser/nacl_host
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_host.cc
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_host.h
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_service.cc
   A /trunk/src/chrome/browser/nacl_host/nacl_broker_service.h
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/nacl_cmd_line.cc
   A /trunk/src/chrome/common/nacl_cmd_line.h
   M /trunk/src/chrome/common/nacl_messages_internal.h
   M /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_linux.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_win.cc
   M /trunk/src/chrome/common/sandbox_policy.cc
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   A /trunk/src/chrome/nacl/broker_thread.cc
   A /trunk/src/chrome/nacl/broker_thread.h
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl.gypi
   M /trunk/src/chrome/renderer/render_process.cc

Implement the broker process that launches NaCl loader processes on 64-bit Windows systems. 

BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/542030
------------------------------------------------------------------------
r37570 | andybons@chromium.org | 2010-01-30 01:00:10 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/common/notification_type.h

If an extension crashes or is killed by the task manager then reloaded, the info bar telling the user that the extension has crashed should disappear in ALL windows should the user choose to hit the 'reload' button.
NOTE: If the user 'x's out the info bar, the bars in the other windows will remain.

BUG=33396
TEST=none
Review URL: http://codereview.chromium.org/548206
------------------------------------------------------------------------
r37569 | arv@chromium.org | 2010-01-30 00:54:57 +0100 (Sat, 30 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/bookmark_manager/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/bookmark_manager/test.js

Add clipboard hooks to the bookmark manager extension API.

This adds the following functions:

  copy(idList)
  cut(idList)
  paste(parentId)
  canPaste(parentId, callback)

BUG=32194
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.BookmarkManager

Review URL: http://codereview.chromium.org/557050
------------------------------------------------------------------------
r37567 | kuan@chromium.org | 2010-01-30 00:48:06 +0100 (Sat, 30 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc

use stubs for yet-to-be-implemented non-windows translate infobars

BUG=31297
TEST=none.
Review URL: http://codereview.chromium.org/557064
------------------------------------------------------------------------
r37563 | johnnyg@chromium.org | 2010-01-30 00:41:08 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Notification permissions for non extension situations still work on an origin basis.

BUG=none
TEST=get permission and create notifications

Review URL: http://codereview.chromium.org/553144
------------------------------------------------------------------------
r37562 | georgey@chromium.org | 2010-01-30 00:39:46 +0100 (Sat, 30 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.cc
   M /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Finished all windows functionality for autofill dialog
Still lacks UI polish
BUG=33026
TEST=can be tested for functionality and UI presence, but not for controls size/position/color
Review URL: http://codereview.chromium.org/549208
------------------------------------------------------------------------
r37560 | thakis@chromium.org | 2010-01-30 00:33:56 +0100 (Sat, 30 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Selecting a row in taskman should select other rows in the same process.

BUG=33077
TEST=See bug.

Review URL: http://codereview.chromium.org/556082
------------------------------------------------------------------------
r37559 | aa@chromium.org | 2010-01-30 00:33:21 +0100 (Sat, 30 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/url_pattern.h

Replace the "origins" key in the manifest with "extent". The items in the extent are URLPatterns, like other parts of the extension system.

Review URL: http://codereview.chromium.org/552209
------------------------------------------------------------------------
r37556 | darin@chromium.org | 2010-01-29 23:42:48 +0100 (Fri, 29 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   D /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   D /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   D /trunk/src/chrome/browser/net/chrome_cookie_policy_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Revert r37535.

There was no LGTM, and there was still open discussion in the code review.  See
http://codereview.chromium.org/554119.  This was not ready to land.

TBR=pkasting
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/553154
------------------------------------------------------------------------
r37551 | sky@chromium.org | 2010-01-29 23:09:21 +0100 (Fri, 29 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Fixes compile warning on linux/views when building 64 bit.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551208
------------------------------------------------------------------------
r37547 | xiyuan@chromium.org | 2010-01-29 23:03:57 +0100 (Fri, 29 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   A /trunk/src/chrome/browser/views/select_file_dialog.cc
   M /trunk/src/chrome/chrome_browser.gypi

Replace GtkFileChooser with file browser for ChromeOS

- Remove dialogs_gtk.cc and add select_file_dialog.cc for chrome os build;
- select_file_dialog.cc provides a SelectFileDialogImpl that serves file
  browse html via HTMLDialogUI;

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/543137
------------------------------------------------------------------------
r37546 | gregoryd@google.com | 2010-01-29 23:03:21 +0100 (Fri, 29 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Rename NaCl flag for Mac to avoid confusion with --internal-nacl

Review URL: http://codereview.chromium.org/549197
------------------------------------------------------------------------
r37537 | finnur@chromium.org | 2010-01-29 22:34:01 +0100 (Fri, 29 Jan 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/iframe.js
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/manifest.json
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/subscribe.js

A little more polish on the RSS extension.

- Fix previewing of sites the contain html in the title. Example feed:
  http://code.google.com/feeds/p/chromium/updates/basic
- The [ Feed ] link now links to the view-source, killing three birds
  with one stone (gives people access to raw feed, doesn't open the
  same feed again in a new tab and shows the feed url in the address
  bar so people don't have to  right-click the link).
- Make sure the title links we create don't show inline in the iframe
  by setting the target to _top.

BUG=None
TEST=None (already has feed parsing tests).


Review URL: http://codereview.chromium.org/551201
------------------------------------------------------------------------
r37536 | rohitrao@chromium.org | 2010-01-29 22:12:00 +0100 (Fri, 29 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Revert previously disabled mac tests.

Reverts the following cls: 37467, 37475, 37481, 37486, 37488, 37489, 37494

BUG=33451
TEST=Please please pass.
Review URL: http://codereview.chromium.org/558047
------------------------------------------------------------------------
r37535 | jochen@chromium.org | 2010-01-29 22:00:34 +0100 (Fri, 29 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   A /trunk/src/chrome/browser/net/chrome_cookie_policy.cc
   A /trunk/src/chrome/browser/net/chrome_cookie_policy.h
   A /trunk/src/chrome/browser/net/chrome_cookie_policy_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Implement extended cookie controls.

BUG=32782
TEST=none

Review URL: http://codereview.chromium.org/554119
------------------------------------------------------------------------
r37526 | jochen@chromium.org | 2010-01-29 20:49:45 +0100 (Fri, 29 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/content_settings_types.h
   A /trunk/src/chrome/browser/host_content_settings_map.cc
   A /trunk/src/chrome/browser/host_content_settings_map.h
   A /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/content_permission_types.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h

Reland r37508. Implement HostContentSettingsMap.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/555172
------------------------------------------------------------------------
r37521 | snej@chromium.org | 2010-01-29 19:09:41 +0100 (Fri, 29 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm

Mac bookmark manager: Crash after deleting folder in left pane
BUG=33083
TEST=BookmarkTreeControllerTest.Deletion

------------------------------------------------------------------------
r37520 | pkasting@chromium.org | 2010-01-29 19:07:40 +0100 (Fri, 29 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Clean up some things about LocationBarView:
* PageActionViews can be parent-owned, simplifying things.
* Using iterators in some loops could make a few things less verbose.
* Misc. other tiny bits like removed extra qualifiers or unneeded blank lines.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557053
------------------------------------------------------------------------
r37519 | evan@chromium.org | 2010-01-29 19:03:38 +0100 (Fri, 29 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/content_settings_types.h
   D /trunk/src/chrome/browser/host_content_settings_map.cc
   D /trunk/src/chrome/browser/host_content_settings_map.h
   D /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/common/content_permission_types.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/testing_profile.h

Revert "Implement HostContentSettingsMap"

This reverts commit r37508, as it was crashing on the reliability bots.

Review URL: http://codereview.chromium.org/556076
------------------------------------------------------------------------
r37508 | jochen@chromium.org | 2010-01-29 13:41:28 +0100 (Fri, 29 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/content_settings_types.h
   A /trunk/src/chrome/browser/host_content_settings_map.cc
   A /trunk/src/chrome/browser/host_content_settings_map.h
   A /trunk/src/chrome/browser/host_content_settings_map_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/common/content_permission_types.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/testing_profile.h

Implement HostContentSettingsMap

This map stores whether a given host may load images or use plugins and javascript. And makes this information available to the render view

BUG=32782
TEST=none

Review URL: http://codereview.chromium.org/551149
------------------------------------------------------------------------
r37505 | yurys@chromium.org | 2010-01-29 11:09:48 +0100 (Fri, 29 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc

DevTools: remove obsolete references to chrome://inspector/

Review URL: http://codereview.chromium.org/558040
------------------------------------------------------------------------
r37498 | sky@chromium.org | 2010-01-29 05:32:30 +0100 (Fri, 29 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.cc

Fixes scrolling bug in autofill profiles. The problem was during
layout you can't set the origin to a location or 0x0, otherwise you
blow away the scroll.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/552225
------------------------------------------------------------------------
r37493 | davemoore@chromium.org | 2010-01-29 04:45:02 +0100 (Fri, 29 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc

bad call to Init() TBR(cmasone)

Review URL: http://codereview.chromium.org/552230
------------------------------------------------------------------------
r37491 | davemoore@chromium.org | 2010-01-29 04:36:16 +0100 (Fri, 29 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc

Fix bad var use. TBR:cmasone

allow login without network

Review URL: http://codereview.chromium.org/549202
------------------------------------------------------------------------
r37490 | davemoore@chromium.org | 2010-01-29 04:26:39 +0100 (Fri, 29 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc

allow login without network
This allows locally cached logins and admin logins to work.

Review URL: http://codereview.chromium.org/548196
------------------------------------------------------------------------
r37482 | nick@chromium.org | 2010-01-29 02:56:00 +0100 (Fri, 29 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Fixed bug 21102 where shutdown while starting Sync leaves things weird.
Specifically, it leaves the Sync Data folder around, which causes problems later where it thinks we're already logged into sync.

Patch contributed by Dan Tasse (dantasse@google.com)

TEST=create new Sync Data files with nonsense data, enable sync for a user, make sure those files were replaced with real Sync Data files.
BUG=21102

Review URL: http://codereview.chromium.org/557010
------------------------------------------------------------------------
r37481 | victorw@chromium.org | 2010-01-29 02:49:20 +0100 (Fri, 29 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Disable NewTabUITest.HomePageLink

TBR=aa
BUG=33451
TEST=mac bot ui test green

Review URL: http://codereview.chromium.org/552226
------------------------------------------------------------------------
r37479 | jcampan@chromium.org | 2010-01-29 02:44:42 +0100 (Fri, 29 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/test_url_fetcher_factory.h
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.cc
   M /trunk/src/chrome/browser/renderer_host/translation_service.h
   A /trunk/src/chrome/browser/renderer_host/translation_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/translate/page_translator.cc
   M /trunk/src/chrome/renderer/translate/text_translator_impl.cc

This CL makes the TranslationService class send the text to be translated to the translation
server.  It groups requests as to limit the number of requests sent to the server.
Also this CL adds a flag to automatically turn on translation on pages that are not in the
language Chrome is configured in.

BUG=None
TEST=Run the unit-tests. Add the --auto-translate flag then navigate to pages in a language
     which is not the language Chrome is configured. They should get translated.

Review URL: http://codereview.chromium.org/552216
------------------------------------------------------------------------
r37477 | pkasting@chromium.org | 2010-01-29 02:24:05 +0100 (Fri, 29 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Support dragging within the omnibox dropdown.  Original patch by Philippe Beaudoin (see http://codereview.chromium.org/555145 ), r=me.

BUG=13703
TEST=Click and drag the left or middle buttons in the omnibox dropdown.  The selection or hover should track your movement and the appropriate entry should be activated on mouse up.
------------------------------------------------------------------------
r37476 | oshima@chromium.org | 2010-01-29 02:22:39 +0100 (Fri, 29 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/panel_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/panel_browser_view.h
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/panel_controller.h

Refactor panel controller so that notification window can use panel_controller.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/548194
------------------------------------------------------------------------
r37475 | victorw@chromium.org | 2010-01-29 02:19:12 +0100 (Fri, 29 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Temporaily disable crashing NewTabUITest

TBR=aa
BUG=33451
TEST=mac bot green

Review URL: http://codereview.chromium.org/554126
------------------------------------------------------------------------
r37467 | aa@chromium.org | 2010-01-29 01:20:53 +0100 (Fri, 29 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Temporarily disable crashing UI test.

TBR=darin@chromium.org
------------------------------------------------------------------------
r37465 | oshima@chromium.org | 2010-01-29 01:11:59 +0100 (Fri, 29 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h

Use the same app menu items for status area menu and toolbar menu.
  - removed import settings as it's not necessary in chromeos

BUG=chromium-os:1095
TEST=manual: switch ui mode using ctrl-shift-c and see if app menus are the same.

insert

Review URL: http://codereview.chromium.org/551182
------------------------------------------------------------------------
r37464 | oshima@chromium.org | 2010-01-29 01:09:36 +0100 (Fri, 29 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/panel_controller.h

Cleanup: Removing old gtk code from panel controller .

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/555157
------------------------------------------------------------------------
r37456 | aa@chromium.org | 2010-01-29 00:04:27 +0100 (Fri, 29 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/notification_provider.cc
   M /trunk/src/chrome/renderer/notification_provider.h

Enable apps to request the HTML5 notification permission.

Note: the big change to chrome_url_request_context.h was mostly to swap the order of ChromeURLRequestContext and ChromeURLRequestContextGetter so that the latter could reference an inner struct of the former.

BUG=32361

Review URL: http://codereview.chromium.org/545149
------------------------------------------------------------------------
r37450 | pkasting@chromium.org | 2010-01-28 23:25:45 +0100 (Thu, 28 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h

Implement a TODO: Combine BrowserToolbarModel with ToolbarModel.  Also make all ToolbarModel methods const.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/556064
------------------------------------------------------------------------
r37448 | nick@chromium.org | 2010-01-28 23:14:05 +0100 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc

Don't acquire a database lock in syncable::DirectoryBackingStore::SaveChanges if there is nothing to save.

Patch contributed by vt (p155off@gmail.com).

BUG=33367
TEST=SyncData.sqlite3-journal isn't written to every 10 seconds with sync enabled; sync_unit_tests continue to pass

Review URL: http://codereview.chromium.org/558019
------------------------------------------------------------------------
r37444 | snej@chromium.org | 2010-01-28 22:46:40 +0100 (Thu, 28 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Mac bookmark mgr: Restore previously selected group when search field is cleared.
BUG=32734
TEST=none

Review URL: http://codereview.chromium.org/555112
------------------------------------------------------------------------
r37443 | kuan@chromium.org | 2010-01-28 22:46:07 +0100 (Thu, 28 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   M /trunk/src/chrome/browser/views/infobars/translate_infobars.h

tweak spacings in infobars per latest specs

BUG=31297
TEST=none.
Review URL: http://codereview.chromium.org/555153
------------------------------------------------------------------------
r37438 | snej@chromium.org | 2010-01-28 22:24:12 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix Mac crash when page goes away while a pop-up menu is active.
This may also fix the older related bug 31716.
BUG=33250
TEST=see steps to reproduce in the bug report

Review URL: http://codereview.chromium.org/558021
------------------------------------------------------------------------
r37436 | joth@chromium.org | 2010-01-28 21:58:11 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc

Fix flaky test causing tree to go red

BUG=http://crbug.com/33410
TEST=Run whilst loading machine: unit_tests.exe --gtest_filter=Win32* --gtest_repeat=9000 --gtest_break_on_failure

Review URL: http://codereview.chromium.org/554122
------------------------------------------------------------------------
r37435 | shess@chromium.org | 2010-01-28 21:56:03 +0100 (Thu, 28 Jan 2010) | 16 lines
Changed paths:
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

SafeBrowsingStore storage abstraction for SafeBrowsing database.

First bit of refactoring safe-browsing to use a flat file format.
SafeBrowsingStore implements just what is needed for
SafeBrowsingDatabase using straight-forward read/modify/write code.

There will be a follow-on change to layer in on-the-fly format
migration and integrate with SafeBrowsingDatabase.  This CL only adds
new classes and tests for same.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36615

Review URL: http://codereview.chromium.org/545053
------------------------------------------------------------------------
r37433 | viettrungluu@chromium.org | 2010-01-28 21:14:24 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Fix extension remove tab crasher.

BUG=30592
TEST=See bug (includes test extension). Try also on other platforms. See further posted notes.

Review URL: http://codereview.chromium.org/554087
------------------------------------------------------------------------
r37428 | pkasting@chromium.org | 2010-01-28 20:46:00 +0100 (Thu, 28 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc

Fix broken pref usage; I changed the registration to a user pref but didn't change the read.

BUG=32719
TEST=Invoking the content settings window doesn't crash
Review URL: http://codereview.chromium.org/551192
------------------------------------------------------------------------
r37425 | ananta@chromium.org | 2010-01-28 20:36:58 +0100 (Thu, 28 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   M /trunk/src/chrome_frame/test/data/chrome_frame_window_open.html

Window.open calls issued by pages within ChromeFrame which use the NEW_WINDOW/NEW_POPUP
dispositions open up as regular Chrome windows, which results in them not using the host network stack,
which means that HTTP sessions/cookies, etc established by the main page will not work for the popup.

Fix is to ensure that these dispositions also get routed back to the host browser where a new tab
would be created which would attach itself to the newly created ExternalTabContainer instance.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=33324

Bug=33324
Test=Covered by ChromeFrame unit test.

Review URL: http://codereview.chromium.org/549183
------------------------------------------------------------------------
r37424 | sky@chromium.org | 2010-01-28 20:36:46 +0100 (Thu, 28 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_delegate.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/menu/submenu_view.h

Makes it so deleting a bookmark from the context menu doesn't close
the bookmark menu.

BUG=2469
TEST=click on a bookmark folder on the bookmark bar, right click on an
 item and chose delete. Make sure the folder stays up and still works
 correctly (and the item you deleted isn't there).

Review URL: http://codereview.chromium.org/551178
------------------------------------------------------------------------
r37421 | sky@chromium.org | 2010-01-28 20:14:33 +0100 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tab_menu_model.cc
   M /trunk/src/chrome/browser/tab_menu_model.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Disables pinned tabs until I land apps. I've #ifdef parts that are
going to stay around, but need to be disabled for now.

BUG=32845
TEST=make sure pinned tabs are disabled for now.

Review URL: http://codereview.chromium.org/557026
------------------------------------------------------------------------
r37417 | shess@chromium.org | 2010-01-28 19:53:08 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac] Prevent script-initiated tab close while a content select menu is up.

BUG=31716
TEST=test.html from the bug, page shouldn't close while select popup is up.

Review URL: http://codereview.chromium.org/555144
------------------------------------------------------------------------
r37414 | erg@google.com | 2010-01-28 19:24:56 +0100 (Thu, 28 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Added a "Reload Frame" command to context menu of a frame in the html page.
It was nessessary to add a IPC Message with no Paramter for the reload frame
request to the webkit renderer and to add a menu string. The command should
only reload the frame clicked in for opening the context menu and let the
other parts of the webpage unmodified and unrefreshed.

BUG=3858
TEST=Try to click on "Reload Frame" in the context menu of a frame and see if that frame reloads.

Review URL: http://codereview.chromium.org/552126
Patch from alexander@sulfrian.net.
------------------------------------------------------------------------
r37411 | creis@chromium.org | 2010-01-28 18:29:35 +0100 (Thu, 28 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_processes_api.cc
   A /trunk/src/chrome/browser/extensions/extension_processes_api.h
   A /trunk/src/chrome/browser/extensions/extension_processes_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_processes_api_constants.h
   A /trunk/src/chrome/browser/extensions/extension_processes_apitest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/processes
   A /trunk/src/chrome/test/data/extensions/api_test/processes/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/processes/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/processes/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/processes/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/processes/test.js

Adds an experimental processes module to the extensions API.

This first step adds only a Process object with an id, along with a
getProcessForTab function.

BUG=32303
TEST=browser_test.exe --gtest_filter=ExtensionAPITest.Processes

Review URL: http://codereview.chromium.org/551090
------------------------------------------------------------------------
r37409 | brettw@chromium.org | 2010-01-28 17:18:57 +0100 (Thu, 28 Jan 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gpu_messages_internal.h
   M /trunk/src/chrome/gpu/gpu_backing_store_glx.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_glx_context.cc
   M /trunk/src/chrome/gpu/gpu_backing_store_glx_context.h
   M /trunk/src/chrome/gpu/gpu_view_x.cc
   M /trunk/src/chrome/gpu/gpu_view_x.h

Add scrolling to the GPU-accelerated backing store. This also fixes some bugs
in the regular painting mode and adds handling for expose events. Accelerated
tabs now seem to look and behave properly as far as I can tell.

Scrolling works by keeping a secondary texture which the current backing store
is painted into. To save copies and excess texture creation, the current
texture and the newly generated one are just swapped whan scrolling completes.

Scrolling does not actually trigger painting to the screen. This is because
scrolling is always followed by a paint to the exposed area, which then
triggers copying the GPU backing store to the screen.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552207
------------------------------------------------------------------------
r37404 | yusukes@chromium.org | 2010-01-28 16:32:33 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_library.cc
   M /trunk/src/chrome/browser/chromeos/language_library.h
   M /trunk/src/chrome/browser/chromeos/system_page_view.cc

Implement config dialog for the Hangul IME.

BUG=none
TEST=manual. Open the ChromeOS config dialog and try to change the Hangul keyboard layout setting.

Review URL: http://codereview.chromium.org/546148
------------------------------------------------------------------------
r37403 | craig.schlenter@chromium.org | 2010-01-28 15:54:44 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/base/message_pump_glib.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h

Remove some unnecessary includes.

BUG=NONE
TEST=compiles

Review URL: http://codereview.chromium.org/557001
------------------------------------------------------------------------
r37400 | joth@chromium.org | 2010-01-28 14:50:04 +0100 (Thu, 28 Jan 2010) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation/backoff_manager.cc
   A /trunk/src/chrome/browser/geolocation/backoff_manager.h
   A /trunk/src/chrome/browser/geolocation/location_provider.cc
   A /trunk/src/chrome/browser/geolocation/location_provider.h
   A /trunk/src/chrome/browser/geolocation/location_provider_pool.cc
   A /trunk/src/chrome/browser/geolocation/location_provider_pool.h
   A /trunk/src/chrome/browser/geolocation/network_location_provider.cc
   A /trunk/src/chrome/browser/geolocation/network_location_provider.h
   A /trunk/src/chrome/browser/geolocation/network_location_request.cc
   A /trunk/src/chrome/browser/geolocation/network_location_request.h

Add more gears geolocaiton files into chromium: locaiton provider, network location provider, and backoff maanger.

All files are from svn checkout http://gears.googlecode.com/svn/trunk/ gears-read-only r3414

Only modification is #if 0 around each file, to avoid build / checkdeps breakage.

BUG=11246
TEST=None (just importing code, tests to follow)

Review URL: http://codereview.chromium.org/555148
------------------------------------------------------------------------
r37396 | joth@chromium.org | 2010-01-28 13:24:24 +0100 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/geolocation/device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   M /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.h
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.h
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.cc
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   M /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.cc
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Update Gears wifi data providers to Chrome style & APIs.
Add wifi data provider to project.
Add tests for windows provider. (More to follow)

BUG=11246
TEST=unit_tests - wifi_data_provider_win_unittest.cc

Review URL: http://codereview.chromium.org/543174
------------------------------------------------------------------------
r37383 | asargent@chromium.org | 2010-01-28 06:58:05 +0100 (Thu, 28 Jan 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/common/extensions/update_manifest.cc
   M /trunk/src/chrome/common/extensions/update_manifest.h
   M /trunk/src/chrome/common/extensions/update_manifest_unittest.cc
   M /trunk/src/chrome/common/utility_messages.h
   M /trunk/src/chrome/common/utility_messages_internal.h

Refactor extension autoupdater.

This includes two changes:

1) Stop sending the Omaha UID to the gallery in favor of a "ping" parameter
included at most once per day in a update manifest fetch, indicating the 
number of days since the last time we sent the ping parameter. The calculation
of this parameter is based on the offset from now to a value in the *previous* 
response from the server where it indicated it's notion of when that day had 
started.

2) Batch update manifest requests for extensions with the same update url. The
server and protocol have supported this for a while but this is the first time
we've added support in the client.


BUG=b/2367191
TEST=Extension updates should still work normally.

Review URL: http://codereview.chromium.org/558005
------------------------------------------------------------------------
r37380 | viettrungluu@chromium.org | 2010-01-28 05:42:28 +0100 (Thu, 28 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   D /trunk/src/chrome/browser/sync/glue/database_model_worker.cc
   D /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   D /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 37367 - Implementation of the database safe worker model.

BUG=none
TEST=unit test

Review URL: http://codereview.chromium.org/546138

TBR=albertb@google.com, victorw@chromium.org, rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/557032
------------------------------------------------------------------------
r37379 | viettrungluu@chromium.org | 2010-01-28 05:40:16 +0100 (Thu, 28 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc

Revert 37372 - Fix leak in DatabaseWorkerModelTest.

BUG=none
TEST=none
TBR=tim

Review URL: http://codereview.chromium.org/557029

TBR=albertb@google.com, victorw@chromium.org, rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/548175
------------------------------------------------------------------------
r37372 | albertb@google.com | 2010-01-28 03:32:04 +0100 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc

Fix leak in DatabaseWorkerModelTest.

BUG=none
TEST=none
TBR=tim

Review URL: http://codereview.chromium.org/557029
------------------------------------------------------------------------
r37371 | estade@chromium.org | 2010-01-28 03:08:14 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: uninstall signal handlers when MenuGtk goes down so that they don't get called after destruction.

BUG=33335
TEST=none

Review URL: http://codereview.chromium.org/549185
------------------------------------------------------------------------
r37368 | pkasting@chromium.org | 2010-01-28 02:44:30 +0100 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/content_settings_types.h (from /trunk/src/chrome/browser/content_settings_window.h:37167)
   D /trunk/src/chrome/browser/content_settings_window.h
   M /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   M /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Make content settings type enum something I can use in more code than just the content settings window.

Also register the content settings last tab pref.

BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/556049
------------------------------------------------------------------------
r37367 | albertb@google.com | 2010-01-28 02:36:17 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/database_model_worker.cc
   A /trunk/src/chrome/browser/sync/glue/database_model_worker.h
   A /trunk/src/chrome/browser/sync/glue/database_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implementation of the database safe worker model.

BUG=none
TEST=unit test

Review URL: http://codereview.chromium.org/546138
------------------------------------------------------------------------
r37365 | atwilson@chromium.org | 2010-01-28 02:28:49 +0100 (Thu, 28 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   A /trunk/src/chrome/browser/worker_host/worker_document_set.cc
   A /trunk/src/chrome/browser/worker_host/worker_document_set.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   A /trunk/src/chrome/test/data/workers/shared_worker_auth.html
   A /trunk/src/chrome/test/data/workers/worker_auth.html
   M /trunk/src/chrome/test/data/workers/worker_common.js
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Refactored code to allow associating workers with multiple renderers.
SharedWorkers now gracefully handle http auth requests after their
initial window has closed.

BUG=27660
TEST=WorkerHttpAuth,SharedWorkerHttpAuth uitests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36888

Reverted and reopened due to valgrind failures.

Review URL: http://codereview.chromium.org/509016
------------------------------------------------------------------------
r37364 | estade@chromium.org | 2010-01-28 02:25:51 +0100 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h

Make BookmarkContextMenuGtk use a SimpleMenuModel. Also separate controller and view responsibilities.

This is the first step in re-merging bookmark context menus across platforms.

BUG=32830
TEST=manual

Review URL: http://codereview.chromium.org/555142
------------------------------------------------------------------------
r37363 | davemoore@chromium.org | 2010-01-28 02:19:28 +0100 (Thu, 28 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_library.h

Make gmail.com be the default domain for login.
Also add some error messages when login fails.

Review URL: http://codereview.chromium.org/549184
------------------------------------------------------------------------
r37362 | estade@chromium.org | 2010-01-28 02:18:29 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h
   A /trunk/src/chrome/browser/gtk/throb_controller_gtk.cc
   A /trunk/src/chrome/browser/gtk/throb_controller_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

GTK: throb a bookmark folder button when a URL is added to it.

BUG=16782
TEST=add bookmark as a descendant of a bookmark bar folder node, watch it throb. Clicking it should make the throbbing stop.

Review URL: http://codereview.chromium.org/543201
------------------------------------------------------------------------
r37360 | cpu@chromium.org | 2010-01-28 01:41:04 +0100 (Thu, 28 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/google_update_settings_posix.cc

Record chrome's startup time, to be used in future retention experiments

- For windows in the registry
- not implemented for posix

BUG=32474
TEST=none


Review URL: http://codereview.chromium.org/558009
------------------------------------------------------------------------
r37357 | georgey@chromium.org | 2010-01-28 01:32:08 +0100 (Thu, 28 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog.cc
   A /trunk/src/chrome/browser/autofill/autofill_dialog_win.cc
   A /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.cc
   A /trunk/src/chrome/browser/autofill/autofill_profiles_view_win.h
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/chrome_browser.gypi

First revision of the AutoFill settings dialog.
What works:
1. Layout (for the most part)
2. Editing and saving the items
What does not
1. Scroll
2. Delete/Add buttons
3. some layout quirks
4. collapsible editable sets.
BUG=33026
TEST=none for now.
Review URL: http://codereview.chromium.org/554081
------------------------------------------------------------------------
r37353 | skerner@chromium.org | 2010-01-28 01:10:29 +0100 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/static/pageAction.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Allow extensions to add, remove, or change their page action popup.

A similar change will be made for browser action popups.

BUG=27526
TEST=Added unit tests.  Manual testing on linux.

Review URL: http://codereview.chromium.org/545068
------------------------------------------------------------------------
r37351 | feldstein@chromium.org | 2010-01-28 01:04:56 +0100 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_observer.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json

Add import/export extension apis

This is a duplicate of 543094.  That code review seems to have gotten corrupted as i can no longer publish anything from their web UI.  It was LGTM'd+nits by arv, which i've fixed here.

BUG=32194
TEST=Import and export bookmarks from the extension

Review URL: http://codereview.chromium.org/548167
------------------------------------------------------------------------
r37342 | zork@chromium.org | 2010-01-28 00:41:50 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   A /trunk/src/chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc
   D /trunk/src/chrome/browser/sync/notifier/base/linux/network_status_detector_task_linux.cc
   M /trunk/src/chrome/chrome.gyp

Add an implementation for async_network_alive to Linux

BUG=33091
TEST=none

Review URL: http://codereview.chromium.org/552162
------------------------------------------------------------------------
r37339 | snej@chromium.org | 2010-01-28 00:17:51 +0100 (Thu, 28 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkManager.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Mac bookmark mgr: Remove bold style for root folders. Thin window border.
(Xib change: move left/right edges of outer splitview out 1 pixel.)
BUG=33119
TEST=none (visual appearance only)

Review URL: http://codereview.chromium.org/556048
------------------------------------------------------------------------
r37337 | estade@chromium.org | 2010-01-28 00:07:47 +0100 (Thu, 28 Jan 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   D /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   D /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.cc
   D /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.h
   D /trunk/src/chrome/browser/extensions/extension_accessibility_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   D /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   D /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   D /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.cc
   D /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/common/accessibility_events.cc
   D /trunk/src/chrome/common/accessibility_events.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

revert 37335:

Add an accessibility API for events raised outside of the web content.

BUG=none
TEST=none

patch by Dominic Mazzoni <dmazzoni [at] google>
review url: http://codereview.chromium.org/402099/show

------------------------------------------------------------------------
r37335 | estade@chromium.org | 2010-01-27 23:41:03 +0100 (Wed, 27 Jan 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api.cc
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api.h
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_accessibility_api_constants.h
   A /trunk/src/chrome/browser/extensions/extension_accessibility_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.cc
   A /trunk/src/chrome/browser/gtk/accessibility_event_router_gtk.h
   A /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.cc
   A /trunk/src/chrome/browser/gtk/accessible_widget_helper_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/accessibility_events.cc
   A /trunk/src/chrome/common/accessibility_events.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Add an accessibility API for events raised outside of the web content.

BUG=none
TEST=none

patch by Dominic Mazzoni <dmazzoni [at] google>
review url: http://codereview.chromium.org/402099/show
Review URL: http://codereview.chromium.org/549182
------------------------------------------------------------------------
r37334 | mirandac@chromium.org | 2010-01-27 23:40:23 +0100 (Wed, 27 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Add promo for extensions and bookmark sync back into the Mac NTP.  Also, fix font size bug
that snuck in with a recent webkit roll.

BUG= 33291
TEST= run a Mac build with a new profile.  See the extension / sync promo line and the puzzle piece on the NTP.

Review URL: http://codereview.chromium.org/552193
------------------------------------------------------------------------
r37333 | oshima@chromium.org | 2010-01-27 23:36:45 +0100 (Wed, 27 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.cc
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Insert methods for SimpleMenuModel
Don't recreate AppMenuModel in ToolbarView as it now supports updating  label dynamically.

BUG=none
TEST=manual: enabling/disabling bookmark sync will update the bookmark sync label correcty.

Review URL: http://codereview.chromium.org/551171
------------------------------------------------------------------------
r37332 | oshima@chromium.org | 2010-01-27 23:32:38 +0100 (Wed, 27 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   D /trunk/src/chrome/browser/views/notifications/balloon_view_host_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/renderer/render_thread.cc

Enable notification for Chromeos/Linux view build.
 The notification behavir is same as one in windows/linux_gtk and no  integration with panels yet.

BUG=33306
TEST=enabled two tests in desktop_notification_unittests for linux view config.
manual test: goto http://www.corp.google.com/~johnnyg/notify_demo.html and
confirm text/html notification works.

Review URL: http://codereview.chromium.org/552196
------------------------------------------------------------------------
r37328 | jschuh@google.com | 2010-01-27 23:23:27 +0100 (Wed, 27 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init_browsertest.cc

Disabling BrowserInitTest.BlockBadURLs until I can get it to run consistently on the BuildBot systems.

BUG=32804
TEST=None.


Review URL: http://codereview.chromium.org/557020
------------------------------------------------------------------------
r37322 | erg@google.com | 2010-01-27 23:03:44 +0100 (Wed, 27 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Fix theme overlay in off the record mode.

We weren't detecting whether we were in OTR mode like we were in
opaque_browser_frame_view.cc.

BUG=21046
TEST=none

Review URL: http://codereview.chromium.org/553125
------------------------------------------------------------------------
r37311 | willchan@chromium.org | 2010-01-27 22:27:29 +0100 (Wed, 27 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc

Switch on socket late binding - Take 2.
Re-enable socket late binding.  The mac valgrind errors happened due to threading bugs in test_shell_tests.  The ui thread would TearDown() the test object, which deleted the TestURLRequestContext, which eventually deletes the TCPClientSocketPool, which deletes its ConnectJobs.  However, those ConnectJobs might be running simultaneously on the io thread.  Therefore, we have a race condition.  This change fixes that.

Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.

Review URL: http://codereview.chromium.org/549093
------------------------------------------------------------------------
r37302 | estade@chromium.org | 2010-01-27 21:40:44 +0100 (Wed, 27 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

re-try r37061 with fix for browser tests

----------------------------------------

Views: use ExtensionToolbarModel for ordering of browser action buttons.

This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup.

BUG=26990

Review URL: http://codereview.chromium.org/553084
------------------------------------------------------------------------
r37299 | derat@chromium.org | 2010-01-27 21:17:07 +0100 (Wed, 27 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

gtk: Update PRIMARY selection on Ctrl-X in omnibox.

We already do this when copying text; I forgot to do
the same for cutting.

BUG=33230
TEST=checked that both PRIMARY and CLIPBOARD get updated on Ctrl-X and Ctrl-C now (and cut via context menu)

Review URL: http://codereview.chromium.org/555135
------------------------------------------------------------------------
r37298 | sky@chromium.org | 2010-01-27 21:14:10 +0100 (Wed, 27 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   M /trunk/src/views/controls/menu/menu_2.h

Fixes unintialized read in networkmenu. Menu's constructor calls into
the delegate, making using 'this' in the member intializer list for
creating a menu problematic. I've changed it to a scoped_ptr and
created as needed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/552187
------------------------------------------------------------------------
r37292 | davemoore@chromium.org | 2010-01-27 20:47:38 +0100 (Wed, 27 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login_manager_view.h

Add version to login

Review URL: http://codereview.chromium.org/549180
------------------------------------------------------------------------
r37290 | rohitrao@chromium.org | 2010-01-27 20:45:15 +0100 (Wed, 27 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Hook up AutocompleteEditViewMac delegate calls properly.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/546107
------------------------------------------------------------------------
r37283 | rohitrao@chromium.org | 2010-01-27 20:09:19 +0100 (Wed, 27 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

[Mac] Makes BrowserWindowCocoa use the proper window, regardless of current fullscreen settings.  Prereq for fullscreen mode.

BUG=31638
TEST=No visible changes.
Review URL: http://codereview.chromium.org/555133
------------------------------------------------------------------------
r37281 | kuan@chromium.org | 2010-01-27 20:04:55 +0100 (Wed, 27 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   A /trunk/src/chrome/browser/translate
   A /trunk/src/chrome/browser/translate/languages_menu_model.cc
   A /trunk/src/chrome/browser/translate/languages_menu_model.h
   A /trunk/src/chrome/browser/translate/options_menu_model.cc
   A /trunk/src/chrome/browser/translate/options_menu_model.h
   A /trunk/src/chrome/browser/translate/translate_infobars_delegates.cc
   A /trunk/src/chrome/browser/translate/translate_infobars_delegates.h
   A /trunk/src/chrome/browser/translate/translate_prefs.cc
   A /trunk/src/chrome/browser/translate/translate_prefs.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   A /trunk/src/chrome/browser/views/infobars/translate_infobars.cc
   A /trunk/src/chrome/browser/views/infobars/translate_infobars.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h

implement infobars and delegates placeholders for translate feature.

Review URL: http://codereview.chromium.org/546132
------------------------------------------------------------------------
r37280 | derat@chromium.org | 2010-01-27 20:03:18 +0100 (Wed, 27 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Remap F1 to back and F2 to forward for Chrome OS Views builds.

(Note that this isn't intended to introduce behavior that
diverges from other platforms -- rather, some of the existing
function key scancodes are being used by new keys.)

BUG=chromium-os:101
TEST=tried it

Review URL: http://codereview.chromium.org/543220
------------------------------------------------------------------------
r37279 | dspringer@google.com | 2010-01-27 19:52:13 +0100 (Wed, 27 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/nacl/nacl_main.cc

Make NaCl run in Chrome on the Mac.

Note: this is a *slight* rework of CL 555082, which accidentally broke the
build.  That CL was reviewed and LGTM'd byt sehr@ and bsy@.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/551172
------------------------------------------------------------------------
r37275 | erg@google.com | 2010-01-27 19:39:49 +0100 (Wed, 27 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   A /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_bar_instructions_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

gtk: Implements bookmark bar import promotion link, that when clicked imports bookmarks.

Based on this patch: http://codereview.chromium.org/440029

BUG=28754
TEST=manually

Review URL: http://codereview.chromium.org/549001
Patch from thiago.farina@gmail.com.
------------------------------------------------------------------------
r37266 | twiz@google.com | 2010-01-27 19:07:22 +0100 (Wed, 27 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json

Correction of permissions of extension manifest file for the extension_popup_apitest.cc unit test.

I also removed the flaky designator from this test, as I was able to run the test (under stress conditions of 10 concurrent instances) without failure.

BUG=27271
TEST=extension_popup_apitest.cc (ExtensionApiTest.Popup)
Review URL: http://codereview.chromium.org/548157
------------------------------------------------------------------------
r37262 | skrul@chromium.org | 2010-01-27 18:57:07 +0100 (Wed, 27 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/tools/valgrind/chrome_tests.py

Enable valgrind for sync tests (and fix valgrind errors)

BUG=32871

Review URL: http://codereview.chromium.org/548156
------------------------------------------------------------------------
r37259 | erg@google.com | 2010-01-27 18:45:44 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc

More debugging statements to try to track down BrowserThemePack crash.

BUG=31719
TEST=none

Review URL: http://codereview.chromium.org/552174
------------------------------------------------------------------------
r37257 | skerner@chromium.org | 2010-01-27 18:13:15 +0100 (Wed, 27 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/extension_action_unittest.cc

Page actions should be able to change the popup on a per-tab basis.

This change is a prerequisite to change 545068.

BUG=27526
TEST=Added unit tests, manual testing on mac, linux, windows.

Review URL: http://codereview.chromium.org/543176
------------------------------------------------------------------------
r37255 | viettrungluu@chromium.org | 2010-01-27 17:54:38 +0100 (Wed, 27 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/nacl/nacl_main.cc

Revert 37254 - Make NaCl run in Chrome on the Mac.

NOTE: This uses some assembly that is NOT SECURE. This CL is for development
ONLY.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/555082

TBR=dspringer@google.com
Review URL: http://codereview.chromium.org/548163
------------------------------------------------------------------------
r37254 | dspringer@google.com | 2010-01-27 17:40:05 +0100 (Wed, 27 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/nacl/nacl_main.cc

Make NaCl run in Chrome on the Mac.

NOTE: This uses some assembly that is NOT SECURE. This CL is for development
ONLY.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/555082
------------------------------------------------------------------------
r37253 | nick@chromium.org | 2010-01-27 17:08:08 +0100 (Wed, 27 Jan 2010) | 25 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/app/sql/connection.h
   M /trunk/src/app/sql/statement.h
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   A /trunk/src/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_columns.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/third_party/protobuf2/config.h
   M /trunk/src/third_party/protobuf2/protobuf.gyp

In the sync database, use protobuf-based storage.  Drop the old
bookmark-only columns.  Add getters and setters for BookmarkSpecifics to
syncapi as well as syncable entries.  Make the datatype be a required
property when creating a syncapi node.  Add a datatype for the 'google
chrome' top level folder.  Add database migrations from version 67 to
the new schema.  Add infrastructure to support migrations generically.
Add unit tests for the migrations.

Pull a new version of the protobuf library to pick up a fix for a
bug that this change exposed (I upstreamed the fix).

Fix some example code in the sql helpers so that it would actually
compile.

BUG=29899,30041

TEST=New unit tests for migrations: unit tests are based on actual
database dumps.  Additionally, I manually tested 2-client sync using
combos of old-protocol servers, new-protocol servers, and initial
database versions v67, v68, and v0 (new client).  I manually verified
that add/edit/delete works in these combination cases.  Afterwards I
verified (by inspecting the sync databases) that the ModelTypes are
consistent across the various migration/protocol paths.

Review URL: http://codereview.chromium.org/554066
------------------------------------------------------------------------
r37252 | rsesek@chromium.org | 2010-01-27 16:52:58 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

Fix an invalid read in CocoaCookieTreeNode that occurs when filtering cookies by origin.

BUG=none
TEST=Mac Valgrind unit_tests

Review URL: http://codereview.chromium.org/555124
------------------------------------------------------------------------
r37250 | avayvod@chromium.org | 2010-01-27 15:53:13 +0100 (Wed, 27 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.h

Made clock button work when browser is not initialized.

BUG=33197
TEST=Verified that Chrome builds.
Review URL: http://codereview.chromium.org/549163
------------------------------------------------------------------------
r37249 | avayvod@chromium.org | 2010-01-27 15:52:47 +0100 (Wed, 27 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/language_menu_button.h

Made language menu button independent of whether initialized browser object
was passed to it or not. In the latter case 'Configure IME' menu is not
shown.

BUG=33197
TEST=Could be tested on login manager screen later. Right now browser can be set
to NULL in debugger manually.
Review URL: http://codereview.chromium.org/553096
------------------------------------------------------------------------
r37247 | jeremy@chromium.org | 2010-01-27 11:24:59 +0100 (Wed, 27 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard.cc
   M /trunk/src/app/clipboard/clipboard.h
   M /trunk/src/app/clipboard/clipboard_linux.cc
   M /trunk/src/app/clipboard/clipboard_mac.mm
   M /trunk/src/app/clipboard/clipboard_unittest.cc
   M /trunk/src/app/clipboard/clipboard_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/scoped_clipboard_writer_glue.h
   M /trunk/src/webkit/tools/test_shell/simple_clipboard_impl.cc

POSIX: Use Shared Mem transport to copy images.

Prior to this change images where copied inline in IPC messages on non-Windows platforms.  Copying an oversized image would cause the IPC system to bork and crash the renderer.

Changes in this CL:
* All platforms use a unified mechanism to copy images using shared memory.
* Introduced a new IPC message so the renderer can allocated a shared memory segment on OS X.
* On OS X tried to keep as few copies of the image data in memory as possible.

BUG=26822
TEST=1)On all platforms: navigate to a webpage, right click on an image and copy.  Then try pasting into an image editor. 2)Repro steps in bug should no longer crash the Renderer on Mac/Linux

Review URL: http://codereview.chromium.org/552129
------------------------------------------------------------------------
r37242 | finnur@chromium.org | 2010-01-27 08:26:05 +0100 (Wed, 27 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/feed_finder.js
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/manifest.json
   A /trunk/src/chrome/test/data/feeds/feed_multi_rel.html

RSS extension was not finding feeds specified with 
rel="updates alternate". Now it is.

BUG=None
TEST=Covered by automated browser test (included).

Review URL: http://codereview.chromium.org/555127
------------------------------------------------------------------------
r37239 | finnur@chromium.org | 2010-01-27 07:29:25 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/test/data/find_in_page/move_if_obscuring.html

Fix remaining flakiness in FindMoveIfObscuring browser test. 

BUG=http://crbug.com/16447
TEST=Covered by automated tests.

Review URL: http://codereview.chromium.org/549168
------------------------------------------------------------------------
r37232 | finnur@chromium.org | 2010-01-27 05:55:57 +0100 (Wed, 27 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   A /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc
   A /trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h
   M /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   M /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/controls/resize_gripper.cc
   M /trunk/src/views/controls/resize_gripper.h

Add overflow menu to the browser action container (part 2 of
supporting resize for the container).

Also improved RTL support a bit (the divider wasn't drawn on
the right side of the container and resizing was reversed).

BUG=32101
TEST=Overflow menu for browser action container should now work.
Make sure to test also right-clicking on a menu item in the overflow
menu to bring up a context menu for that item. And resizing the
container in RTL locales should work.

Review URL: http://codereview.chromium.org/557006
------------------------------------------------------------------------
r37231 | suzhe@chromium.org | 2010-01-27 05:40:18 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/test/test_browser_window.h

[Mac]Implement Cut, Copy and Paste from page menu

BUG=none
TEST=Cut/Copy/Paste items in page menu should work in both omnibox and web content.

Review URL: http://codereview.chromium.org/556016
------------------------------------------------------------------------
r37226 | ananta@chromium.org | 2010-01-27 04:26:02 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

The FindMovesWhenObscuring test is still flaky on the builders. Marking it accordingly.

Bug=16447
TBR=finnur

Review URL: http://codereview.chromium.org/543223
------------------------------------------------------------------------
r37219 | akalin@chromium.org | 2010-01-27 03:20:28 +0100 (Wed, 27 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h

Fixed bug involving destruction order in GaiaAuth.

See bug for more details.

BUG=33120
TEST=Put sleep(15) before post of on_work_done_task, made sure OnAuthDone doesn't get called on shutdown.

Review URL: http://codereview.chromium.org/548147
------------------------------------------------------------------------
r37206 | akalin@chromium.org | 2010-01-27 02:27:19 +0100 (Wed, 27 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/base/base_paths_mac.mm
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/base/mac_util_unittest.mm
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.mm
   M /trunk/src/chrome/common/chrome_paths_mac.mm

Moved GetUserDirectory() into mac_util.mm.

Made mac_util.mm and chrome_paths_mac.mm use GetUserDirectory().

Made firefox_importer_utils_mac.mm use PathService.

Added unittests for GetUserDirectory().

BUG=22045
TEST=trybots

Review URL: http://codereview.chromium.org/548123
------------------------------------------------------------------------
r37202 | kuchhal@chromium.org | 2010-01-27 02:21:48 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc

Do not try to swap chrome.exe if machine is shutting down.

BUG=18063
TEST=Installer an update while Chrome is running. Log out of machine without closing Chrome first and make sure sure Chrome gets updated cleanly whenever it is launched next.

Review URL: http://codereview.chromium.org/553079
------------------------------------------------------------------------
r37201 | evan@chromium.org | 2010-01-27 02:20:55 +0100 (Wed, 27 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc

linux: also load plugins from ~/.config/google-chrome/Plugins

This matches Mozilla, which uses ~/.mozilla/plugins.

BUG=22261
TEST=watch an strace, see that it hits the appropriate dir when loading plugins

Review URL: http://codereview.chromium.org/553102
------------------------------------------------------------------------
r37198 | oshima@chromium.org | 2010-01-27 02:15:04 +0100 (Wed, 27 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.cc

Don't emit focus event when moving focus around when re-creating fixed widget.
 - This fixes the crash in compact navigation bar without a adjustment.
 - I didn't remove the adjustment because ths is   necessary to make the compact navigation bar transparent.   (currently, the clipping code assumes that the fixed widget and   the actual opaque child have the same side, which is not the case   for AutocompleteEditView.

BUG=chromium-os:1010
TEST=manual: compact nav bar does not crash.

Review URL: http://codereview.chromium.org/548151
------------------------------------------------------------------------
r37197 | ananta@chromium.org | 2010-01-27 02:11:02 +0100 (Wed, 27 Jan 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   A /trunk/src/chrome_frame/test/data/fulltab_before_unload_event_main.html
   A /trunk/src/chrome_frame/test/data/fulltab_before_unload_event_test.html

Unload and BeforeUnload handlers would not get invoked within pages inside ChromeFrame. This was because
the ExternalTabContainer would close the underlying tab contents in its OnDestroy handler without invoking
unload handlers on the page if any. In Chrome the TabStripModel invokes the RunUnloadListenerBeforeClosing
on the delegate which is implemented by the browser. We need to mimic this in the external tab container.

To achieve this we now have a static helper function RunUnloadListenerBeforeClosingHelper in the browser
class which is called by the ExternalTabContainer and the Browser::RunUnloadListenerBeforeClosing function.

The ExternalTabContainer also needs to wait for the unload handlers on the page to return before it returns
control back to the host browser. To achieve this we enter a nested modal loop which is exited when the
underlying tab is closed.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=31853

Bug=31853
Test=Covered by ChromeFrame unit test.

Review URL: http://codereview.chromium.org/543183
------------------------------------------------------------------------
r37196 | pkasting@chromium.org | 2010-01-27 02:07:19 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

Change hardcoded strings (!) in Mac unittest to match real string changes.

TBR=rsesek
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/556033
------------------------------------------------------------------------
r37193 | erg@google.com | 2010-01-27 02:03:10 +0100 (Wed, 27 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/renderer_preferences_util.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/renderer/render_view.cc
   A /trunk/src/webkit/data/layout_tests/LayoutTests
   A /trunk/src/webkit/data/layout_tests/LayoutTests/fast
   A /trunk/src/webkit/data/layout_tests/LayoutTests/fast/linux_selection_color.html
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/linux_selection_color-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/linux_selection_color-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/linux_selection_color-expected.txt
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.h

GTK: Use GTK+ theme selection colors and plumb them into webkit. [Chromium side of patch]

BUG=25831
TEST=none

Review URL: http://codereview.chromium.org/554004
------------------------------------------------------------------------
r37163 | rafaelw@chromium.org | 2010-01-26 23:50:40 +0100 (Tue, 26 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Code Cleanup: Browser::CreateForApp can no longer create TYPE_APP_POPUP windows

This cleans up the interface for BrowserCreateForApp() which now longer takes a final argument of is_popup. The code has changed so that it is no caller is ever passing in true, so the code has been simplified.

BUG=5739
TEST=Ensure steps in bug report still no longer produce the bug.

Review URL: http://codereview.chromium.org/556024
------------------------------------------------------------------------
r37162 | estade@chromium.org | 2010-01-26 23:49:55 +0100 (Tue, 26 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc

Add infobar warning user of extension install failure when trying to install in incognito mode.

BUG=27945

Review URL: http://codereview.chromium.org/543155
------------------------------------------------------------------------
r37161 | rohitrao@chromium.org | 2010-01-26 23:44:51 +0100 (Tue, 26 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm

[Mac] Possibly prevent crashes by properly handling missing/invalid favicons in HungRendererController.

BUG=33160
TEST=None.  (No repro case.  Hopefully crashes will go away.)
Review URL: http://codereview.chromium.org/556022
------------------------------------------------------------------------
r37159 | estade@chromium.org | 2010-01-26 23:43:47 +0100 (Tue, 26 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

GTK: disable the find bar error bell.

this is potentially temporary

BUG=27635
TEST=search for something that doesn't exist in the page

Review URL: http://codereview.chromium.org/548154
------------------------------------------------------------------------
r37156 | andybons@chromium.org | 2010-01-26 23:33:58 +0100 (Tue, 26 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Prevents a crash that occurs when multiple ExtensionHost objects point to the same Extension object and then crash (or are killed by the Task manager). Since the first ExtensionHost RenderViewGone will cause the Extension to be unloaded, the subsequent call will try and unload a dirty pointer. This is prevented by NULLing out the Extension pointer in the host and checking it upon RenderViewGone before sending a notification to have it unloaded (again).

TEST=none
BUG=32613,32653
Review URL: http://codereview.chromium.org/555103
------------------------------------------------------------------------
r37155 | chocobo@chromium.org | 2010-01-26 23:32:06 +0100 (Tue, 26 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   A /trunk/src/chrome/browser/chromeos/internet_page_view.cc
   A /trunk/src/chrome/browser/chromeos/internet_page_view.h
   M /trunk/src/chrome/browser/chromeos/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   D /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   D /trunk/src/chrome/browser/chromeos/settings_contents_view.h
   M /trunk/src/chrome/browser/chromeos/settings_page_view.cc
   M /trunk/src/chrome/browser/chromeos/settings_page_view.h
   A /trunk/src/chrome/browser/chromeos/system_page_view.cc
   A /trunk/src/chrome/browser/chromeos/system_page_view.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

Split chromeos options page into system and internet.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/548152
------------------------------------------------------------------------
r37154 | akalin@chromium.org | 2010-01-26 22:16:45 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Fixed race condition with AddressWatchTask and ServerConnectionManager.

BUG=33162
TEST=manually with sleep()

Review URL: http://codereview.chromium.org/552157
------------------------------------------------------------------------
r37153 | zelidrag@chromium.org | 2010-01-26 22:00:54 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   A /trunk/src/chrome/browser/content_settings_window.h
   M /trunk/src/chrome/browser/options_util.cc
   A /trunk/src/chrome/browser/views/cookie_info_view.cc
   A /trunk/src/chrome/browser/views/cookie_info_view.h
   A /trunk/src/chrome/browser/views/cookie_prompt_view.cc
   A /trunk/src/chrome/browser/views/cookie_prompt_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   A /trunk/src/chrome/browser/views/options/content_filter_page_view.cc
   A /trunk/src/chrome/browser/views/options/content_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   A /trunk/src/chrome/browser/views/options/content_settings_window_view.cc
   A /trunk/src/chrome/browser/views/options/content_settings_window_view.h
   A /trunk/src/chrome/browser/views/options/cookie_filter_page_view.cc
   A /trunk/src/chrome/browser/views/options/cookie_filter_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Content Settings dialog and related Options UI changes.

BUG=32719
TEST=none

Review URL: http://codereview.chromium.org/554045
------------------------------------------------------------------------
r37152 | thestig@chromium.org | 2010-01-26 21:56:04 +0100 (Tue, 26 Jan 2010) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/util/path_helpers.cc
   D /trunk/src/chrome/browser/sync/util/path_helpers_linux.cc
   D /trunk/src/chrome/browser/sync/util/path_helpers_mac.cc
   D /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc
   D /trunk/src/chrome/browser/sync/util/path_helpers_unittest.cc
   D /trunk/src/chrome/browser/sync/util/path_helpers_win.cc
   D /trunk/src/net/base/wininet_util.cc
   D /trunk/src/net/base/wininet_util.h
   D /trunk/src/net/base/wininet_util_unittest.cc
   D /trunk/src/net/tools/flip_server/create_listener_test.cc
   D /trunk/src/net/url_request/url_request_ftp_job.cc
   D /trunk/src/net/url_request/url_request_ftp_job.h
   D /trunk/src/net/url_request/url_request_inet_job.cc
   D /trunk/src/net/url_request/url_request_inet_job.h

Remove a bunch of 0 byte files. (due to git-svn misbehavior?)

BUG=none
TEST=none
------------------------------------------------------------------------
r37150 | michaeln@chromium.org | 2010-01-26 21:42:37 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Enable the appcache by default and add a cmd line switch to optionally disable it.

BUG=25977
TEST=manual, verified disabled with --disable-application-cache

Review URL: http://codereview.chromium.org/548122
------------------------------------------------------------------------
r37149 | dimich@chromium.org | 2010-01-26 21:35:54 +0100 (Tue, 26 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Enable extension tests now that upstream r53815 has fixed the crash in pthread_join on Linux.
BUG=33085
TEST=none
Review URL: http://codereview.chromium.org/552155
------------------------------------------------------------------------
r37148 | sky@chromium.org | 2010-01-26 21:34:57 +0100 (Tue, 26 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Fixes flakiness in session restore test. I'm adding two things:
. Make the newly created popup navigate to a url. Without this session
  restore won't restore the tab.
. Before exiting manually shutdown the session service. Without this
  the windows are closed, which, depending upon timing, is treated as
  though the user closed the window so that session restore won't
  restore the window.

BUG=32716
TEST=this is only a test fix

Review URL: http://codereview.chromium.org/552134
------------------------------------------------------------------------
r37143 | erg@google.com | 2010-01-26 21:19:29 +0100 (Tue, 26 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.cc
   M /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Associate popups with the top level frame instead of the security origin.

No longer send the creator from the renderer to the browser since this was all it was used for.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/543199
------------------------------------------------------------------------
r37139 | rsesek@chromium.org | 2010-01-26 21:10:08 +0100 (Tue, 26 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] Give the cookies manager a search field.

XIB changes:
* Add an NSSearchField and adjust window size.
* Add an outlet for the NSOutlineView so we can clear the delegate to avoid
  potential crashes during sheet closing.
* Change the control size of the NSOutlineView to small (looks better).

BUG=32328
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Enter a domain or domain substring and, without hitting enter, results should be filtered.

Review URL: http://codereview.chromium.org/557002
------------------------------------------------------------------------
r37137 | thestig@chromium.org | 2010-01-26 21:00:42 +0100 (Tue, 26 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/PRESUBMIT.py

ChromiumOS: Automatically send try jobs to the linux_chromeos try bot for changes in chrome/browser/chromeos.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549139
------------------------------------------------------------------------
r37136 | zork@chromium.org | 2010-01-26 20:50:54 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/build/install-build-deps.sh
   A /trunk/src/chrome/browser/sync/engine/idle_query_linux.cc
   A /trunk/src/chrome/browser/sync/engine/idle_query_linux.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_common.gypi

Add support for UserIdleTime to Linux.

BUG=32421
TEST=none

Review URL: http://codereview.chromium.org/553051
------------------------------------------------------------------------
r37135 | dpolukhin@chromium.org | 2010-01-26 20:47:44 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

Fix GTK version of options dialog to place it to the center of last active browser window.

BUG=1143
TEST=Tested on Linux with two monitors.

Review URL: http://codereview.chromium.org/551094
------------------------------------------------------------------------
r37126 | avayvod@chromium.org | 2010-01-26 20:06:23 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h

Remove literal dependencies on browser for network menu button (actually
just renamed a couple of things).

BUG=0
TEST=Just a rename so doesn't change anything.
Review URL: http://codereview.chromium.org/551153
------------------------------------------------------------------------
r37121 | snej@chromium.org | 2010-01-26 19:33:27 +0100 (Tue, 26 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/BookmarkManager.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm

Mac bookmark mgr: Add tooltips to buttons.
BUG=32735
TEST=Hover cursor over +/-/gear buttons

Review URL: http://codereview.chromium.org/549143
------------------------------------------------------------------------
r37117 | joth@chromium.org | 2010-01-26 18:59:34 +0100 (Tue, 26 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   A /trunk/src/chrome/browser/geolocation
   A /trunk/src/chrome/browser/geolocation/device_data_provider.h
   A /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   A /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.h

(Second attempt at http://codereview.chromium.org/553069/show -- this time including DEPS exclusion)

These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/

NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.

BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)

Review URL: http://codereview.chromium.org/556003
------------------------------------------------------------------------
r37114 | thakis@chromium.org | 2010-01-26 18:56:59 +0100 (Tue, 26 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Improve task manager column resizing, set min window size.

xib changes: Set min window size to 300x200, change table view column resizing to "Uniform".

Give task manager columns min max widths.

BUG=33133,33134
TEST=See bugs.

Review URL: http://codereview.chromium.org/551148
------------------------------------------------------------------------
r37112 | finnur@chromium.org | 2010-01-26 18:46:00 +0100 (Tue, 26 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Install/uninstall dialog had stopped showing Uninstall
when you uninstall from the context menu for Browser Actions.

So, I am undo-ing some changes that to me look accidental.

BUG=None
TEST=Uninstall browser actions from the context menu and
make sure the dialog says "Uninstall", not "Install".

Review URL: http://codereview.chromium.org/543204
------------------------------------------------------------------------
r37110 | snej@chromium.org | 2010-01-26 18:30:22 +0100 (Tue, 26 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm

Fix for Mac tooltip crasher.
BUG=23397
TEST=none

Review URL: http://codereview.chromium.org/543200
------------------------------------------------------------------------
r37101 | jeremy@chromium.org | 2010-01-26 10:59:37 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Enable "Import Settings" button in preferences dialog.

BUG=29819
TEST=Open settings dialog, go to "Personal Stuff" Tab, Import Data... button should function

Review URL: http://codereview.chromium.org/555065
------------------------------------------------------------------------
r37100 | yurys@chromium.org | 2010-01-26 09:40:39 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: fix and reenable DevToolsSanityTest.TestShowScriptsTab. Only check that main page script is present when the tab is shown.

BUG=33107
TBR=pfeldman

Review URL: http://codereview.chromium.org/553086
------------------------------------------------------------------------
r37088 | brettw@chromium.org | 2010-01-26 06:15:42 +0100 (Tue, 26 Jan 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/gpu_process_host.cc
   M /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   D /trunk/src/chrome/browser/renderer_host/backing_store_gl.cc
   D /trunk/src/chrome/browser/renderer_host/backing_store_glx.h
   D /trunk/src/chrome/browser/renderer_host/backing_store_manager_glx.cc
   D /trunk/src/chrome/browser/renderer_host/backing_store_manager_glx.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/gpu_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/gpu_messages.h
   M /trunk/src/chrome/common/gpu_messages_internal.h
   A /trunk/src/chrome/common/gpu_native_window_handle.h
   D /trunk/src/chrome/gpu/gpu_backing_store.cc
   D /trunk/src/chrome/gpu/gpu_backing_store.h
   A /trunk/src/chrome/gpu/gpu_backing_store_glx.cc (from /trunk/src/chrome/browser/renderer_host/backing_store_gl.cc:36364)
   A /trunk/src/chrome/gpu/gpu_backing_store_glx.h (from /trunk/src/chrome/browser/renderer_host/backing_store_glx.h:36364)
   A /trunk/src/chrome/gpu/gpu_backing_store_glx_context.cc (from /trunk/src/chrome/browser/renderer_host/backing_store_manager_glx.cc:36364)
   A /trunk/src/chrome/gpu/gpu_backing_store_glx_context.h (from /trunk/src/chrome/browser/renderer_host/backing_store_manager_glx.h:36364)
   A /trunk/src/chrome/gpu/gpu_backing_store_win.cc (from /trunk/src/chrome/gpu/gpu_backing_store.cc:36364)
   A /trunk/src/chrome/gpu/gpu_backing_store_win.h (from /trunk/src/chrome/gpu/gpu_backing_store.h:36364)
   M /trunk/src/chrome/gpu/gpu_main.cc
   M /trunk/src/chrome/gpu/gpu_thread.cc
   M /trunk/src/chrome/gpu/gpu_thread.h
   M /trunk/src/chrome/gpu/gpu_view_win.cc
   M /trunk/src/chrome/gpu/gpu_view_win.h
   A /trunk/src/chrome/gpu/gpu_view_x.cc (from /trunk/src/chrome/gpu/gpu_view_win.cc:36364)
   A /trunk/src/chrome/gpu/gpu_view_x.h (from /trunk/src/chrome/gpu/gpu_view_win.h:36364)
   A /trunk/src/chrome/gpu/x_util.cc
   A /trunk/src/chrome/gpu/x_util.h

Create initial GPU backing store in the GPU process for X windows applications.
This gets the window from the RenderWidgetHostViewGtk and just does OpenGL
calls directly into it. There are a lot of bugs, especially around expose
events, which aren't really processed at all, and also tab teardown and
reparenting.

The new backing store defaults to off.

This does some refactoring of the existing Windows GPU process backing store
implementation to make some of it sharable by this Linux verion.

This removes some previously defunct in-process GL backing store code and moves
it to the GPU process.

This patch does some refactoring around how child processes are created using
zygoes or not. I found there were many places where a command line would be
checked with special logic to know whether to enable zygote code or not. I
tried to unify this so it could be computed once for each process type. This is
what most of the changed files in chrome/browser are related to.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/548112
------------------------------------------------------------------------
r37076 | jorlow@chromium.org | 2010-01-26 02:31:22 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Handle storage events locally when possible.

TEST=none
BUG=33108

Review URL: http://codereview.chromium.org/543168
------------------------------------------------------------------------
r37075 | jorlow@chromium.org | 2010-01-26 01:55:41 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Revert 37061 because it caused ui_tests to not finish.

TBR=estade
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/549155
------------------------------------------------------------------------
r37067 | jorlow@chromium.org | 2010-01-26 01:33:18 +0100 (Tue, 26 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable failing browser test.

BUG=33107
TEST=none

Review URL: http://codereview.chromium.org/549154
------------------------------------------------------------------------
r37061 | estade@chromium.org | 2010-01-26 00:35:50 +0100 (Tue, 26 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

re-try r37025 with fix for incognito mode

----------------------------------------

Views: use ExtensionToolbarModel for ordering of browser action buttons.

This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup.

BUG=26990


Review URL: http://codereview.chromium.org/549151
------------------------------------------------------------------------
r37056 | snej@chromium.org | 2010-01-26 00:12:02 +0100 (Tue, 26 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm

Mac: Rebuild Bookmarks menu only when it's pulled down.
BUG=30600
TEST=BookmarkMenuBridgeTest

Review URL: http://codereview.chromium.org/555079
------------------------------------------------------------------------
r37046 | sky@chromium.org | 2010-01-25 22:56:51 +0100 (Mon, 25 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc

Lands http://codereview.chromium.org/552136 for bryeung:

(Re-)Add a delete context menu item for bookmarks. 

BUG=32825
TEST=manually
Review URL: http://codereview.chromium.org/554067
------------------------------------------------------------------------
r37045 | rohitrao@chromium.org | 2010-01-25 22:30:31 +0100 (Mon, 25 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

[Mac] Add methods to prevent tab detaching or window moving if needed.  Modify tab view to respect these new settings.  Prereq for fullscreen.

(Changes really made by viettrungluu@chromium.org.) 

BUG=31638
TEST=Tab dragging and window moving should still work when not in fullscreen mode.
Review URL: http://codereview.chromium.org/554064
------------------------------------------------------------------------
r37038 | rohitrao@chromium.org | 2010-01-25 21:52:06 +0100 (Mon, 25 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

[Mac] Makes the tab strip left-side indent changeable.  Prereq for fullscreen.

(Changes really made by viettrungluu@chromium.org.)

BUG=31638
TEST=Tab strip should still draw with the proper indent.

Review URL: http://codereview.chromium.org/551145
------------------------------------------------------------------------
r37037 | bulach@chromium.org | 2010-01-25 21:48:11 +0100 (Mon, 25 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.cc
   M /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.h

Fixes valgrind following 37001:
+ makes the callback mock a scoped_ptr
+ adds a virtual dtor (so that the vector in the mock is destroyed)
+ the mock needs to be friend of the base class
Review URL: http://codereview.chromium.org/546131
------------------------------------------------------------------------
r37036 | jhawkins@chromium.org | 2010-01-25 21:47:20 +0100 (Mon, 25 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Implement adding, updating and removing credit cards from the web database through the gtk AutoFill dialog.

BUG=18201
TEST=WebDatabaseTest.CreditCard, PersonalDataManagerTest.SetCreditCards
Review URL: http://codereview.chromium.org/555068
------------------------------------------------------------------------
r37032 | evan@chromium.org | 2010-01-25 21:38:53 +0100 (Mon, 25 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/bidi_line_iterator.cc
   A /trunk/src/app/bidi_line_iterator.h
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   A /trunk/src/app/l10n_util_collator.h
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/app/table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc

remove ICU includes from l10n_util.h

95% of users of l10n_util use it for some functions; the other 5%
want some complicated templates that pull in a ton of ICU headers
as well.

Before this change, the average includer of l10n_util.h pulled in
an additional 80 subheaders because of it.

Additionally, #including ICU headers from a header makes the includee
depend on having the ICU include path in the -I header.

Review URL: http://codereview.chromium.org/515059
------------------------------------------------------------------------
r37030 | dimich@google.com | 2010-01-25 21:34:48 +0100 (Mon, 25 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Temporarily disabled some browser tests that fail because of r53715 upstream.
BUG=33085
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/555080
------------------------------------------------------------------------
r37029 | rohitrao@chromium.org | 2010-01-25 21:34:39 +0100 (Mon, 25 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.h
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window_unittest.mm

[Mac] Changes to enable performClose: for fullscreen windows.

(Changes really made by viettrungluu@chromium.org.) 

BUG=31638
TEST=None.  (Unittests should still pass.)
Review URL: http://codereview.chromium.org/552133
------------------------------------------------------------------------
r37028 | avi@chromium.org | 2010-01-25 21:32:56 +0100 (Mon, 25 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/framework.order
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.h
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webcursor_mac.mm

Plumb Carbon SetCursor through.

BUG=http://crbug.com/32703
TEST=when hiding cursor (Flash 10.0), cursor hides (but doesn't stay hidden; that gets fixed later)

Review URL: http://codereview.chromium.org/552132
------------------------------------------------------------------------
r37026 | estade@chromium.org | 2010-01-25 20:42:34 +0100 (Mon, 25 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Revert r37025, which (may have) caused workertest redness

Views: use ExtensionToolbarModel for ordering of browser action buttons. This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup. BUG=26990 Review URL: http://codereview.chromium.org/554057

TBR=amanda

Review URL: http://codereview.chromium.org/546133
------------------------------------------------------------------------
r37025 | estade@chromium.org | 2010-01-25 20:05:49 +0100 (Mon, 25 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Views: use ExtensionToolbarModel for ordering of browser action buttons.

This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup.

BUG=26990

Review URL: http://codereview.chromium.org/554057
------------------------------------------------------------------------
r37023 | dimich@google.com | 2010-01-25 19:18:20 +0100 (Mon, 25 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_paths_internal.h
   M /trunk/src/chrome/common/chrome_paths_win.cc

Default to FOLDERID_Downloads on Windows Vista/7 when safe.
Landing for DCheng@.
Codereview: http://codereview.chromium.org/553040
TEST=none
BUG=13610
------------------------------------------------------------------------
r37018 | finnur@chromium.org | 2010-01-25 18:38:16 +0100 (Mon, 25 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Remove flaky label for a test. My fix seems to have worked (hasn't
been failing for a few days now -- used to fail regularly).

BUG=16447
TEST=None (making a change to a test)
TBR=jcampan

Review URL: http://codereview.chromium.org/553070
------------------------------------------------------------------------
r37017 | johnnyg@chromium.org | 2010-01-25 18:37:46 +0100 (Mon, 25 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/renderer/render_thread.cc

Make sure notifications are only enabled on GTK builds of linux, since that's what's supported so far.

BUG=23954
TEST=none

Review URL: http://codereview.chromium.org/552122
------------------------------------------------------------------------
r37015 | joth@chromium.org | 2010-01-25 18:26:58 +0100 (Mon, 25 Jan 2010) | 14 lines
Changed paths:
   D /trunk/src/chrome/browser/geolocation

Revert 37009 - Adding geolocation data provider infrastructure to Chrome.
Rolling back as it seems to have broken the Mac build

These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/

NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.

BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)

Review URL: http://codereview.chromium.org/546116

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/553069
------------------------------------------------------------------------
r37010 | viettrungluu@chromium.org | 2010-01-25 18:00:17 +0100 (Mon, 25 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Mac: fix yet another TabStripController index/model index bug (crasher).

BUG=29906
TEST=Create a bunch of tabs; click on some close tab button while holding shift down to slow down animation; while animating, select another tab; repeat many, many times. Should not crash.

Review URL: http://codereview.chromium.org/553068
------------------------------------------------------------------------
r37009 | joth@chromium.org | 2010-01-25 17:47:24 +0100 (Mon, 25 Jan 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/geolocation
   A /trunk/src/chrome/browser/geolocation/device_data_provider.h
   A /trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   A /trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.cc
   A /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.h

Adding geolocation data provider infrastructure to Chrome.
These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/

NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.

BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)

Review URL: http://codereview.chromium.org/546116
------------------------------------------------------------------------
r37001 | bulach@chromium.org | 2010-01-25 14:50:48 +0100 (Mon, 25 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   A /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.cc
   A /trunk/src/chrome/browser/mock_browsing_data_local_storage_helper.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds local storage nodes to cookie tree model and cookies view.

BUG=none
TEST=The show cookie dialog box should have a new node "local storage" when appropriate. When selected, it should display details of local storage (name, size on disk, last modified) in the details frame.
Review URL: http://codereview.chromium.org/523139
------------------------------------------------------------------------
r36989 | suzhe@chromium.org | 2010-01-25 05:46:23 +0100 (Mon, 25 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

[Linux]Implement Cut, Copy and Paste from page menu.

BUG=18030
TEST=The Cut, Copy and Paste commands in page menu should work in both web content and location bar.

Review URL: http://codereview.chromium.org/552125
------------------------------------------------------------------------
r36987 | satorux@chromium.org | 2010-01-25 05:30:22 +0100 (Mon, 25 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_library.cc
   M /trunk/src/chrome/browser/chromeos/language_library.h

Retry starting monitoring language changes.

Before the change, monitoring was started when LanguageLibrary object
was first created. This assumes that ibus-daemon is already running
by the time LanguageLibrary is created, which is not necessarily true
on Chromium OS. This change adds some retry logic to fix the issue.

BUG=1362
TEST=manually

Review URL: http://codereview.chromium.org/543170
------------------------------------------------------------------------
r36982 | viettrungluu@chromium.org | 2010-01-24 21:49:57 +0100 (Sun, 24 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Mac: make pinned tab title change alert more noticeable.

Make the alert glow fade in to look like a selected tab, which should be quite
visible on all themes, including the default theme (i.e., no theme).

BUG=32791
TEST=Go to <http://www.surflocal.net/Awards/submit/animatedtitle.html>, pin that tab, and create and select a new tab. Watch the pinned tab "glow" in and out quite visibly (but smoothly). Check that it behaves properly when the mouse moves over it. Check with lots of different themes.

Review URL: http://codereview.chromium.org/549144
------------------------------------------------------------------------
r36978 | jhawkins@chromium.org | 2010-01-24 09:32:55 +0100 (Sun, 24 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   A /trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Add the ability to save and remove AutoFill profiles from the AutoFillDialog.

BUG=18201
TEST=PersonalDataManagerTest.SetProfiles
Review URL: http://codereview.chromium.org/545175
------------------------------------------------------------------------
r36977 | suzhe@chromium.org | 2010-01-24 08:58:08 +0100 (Sun, 24 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc

[Linux] Implement input methods context menu.

BUG=31008
TEST=Right click in the content area, there will be an "Input Method" submenu.

Review URL: http://codereview.chromium.org/549100
------------------------------------------------------------------------
r36964 | sky@chromium.org | 2010-01-23 17:38:18 +0100 (Sat, 23 Jan 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Extension tweaks for phantom tabs. I did the following modifications:

. Modified chrome.tabs.executeScript so that it sends error message if
  failure in sending message (which happens with phantom tabs).
. When a tab is made phantom we send TabInsertedAt event.
. Made connecting to a phantom tab send disconnect.
. Disallow changing the url of pinned tabs.
. Disallow closing phantom tabs.
. Detect language fails for phantom tabs.

And I removed the flag for phantom tabs.

BUG=25309
TEST=on windows or chromeos create a window with a couple of tabs, pin
the first, then close it. Selection should change to another tab and
the favicon of the closed tab should remain, but not the tab
border. control-tab should not select the phantom tab, but if you
click on the phantom tab it should become live again and the border
should reappear.

Review URL: http://codereview.chromium.org/552110
------------------------------------------------------------------------
r36963 | sky@chromium.org | 2010-01-23 17:37:56 +0100 (Sat, 23 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Removes DCHECK that is hit on showing options dialog.

BUG=32927
TEST=make sure you can bring up the options dialog without hitting a
  DCHECK (only on debug builds).

Review URL: http://codereview.chromium.org/546119
------------------------------------------------------------------------
r36962 | jochen@chromium.org | 2010-01-23 17:22:14 +0100 (Sat, 23 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_perftest.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   D /trunk/src/chrome/test/data/blacklist_samples/annoying_ads.pbl
   D /trunk/src/chrome/test/data/blacklist_samples/block_flash.pbl
   D /trunk/src/chrome/test/data/blacklist_samples/combine3.pbr
   D /trunk/src/chrome/test/data/blacklist_samples/host.pbl
   D /trunk/src/chrome/test/data/blacklist_samples/other_ads.pbl
   D /trunk/src/chrome/test/data/blacklist_samples/session_cookies.pbl
   D /trunk/src/chrome/test/data/blacklist_small.pbl
   D /trunk/src/chrome/test/data/blacklist_small.pbr
   A /trunk/src/chrome/test/data/profiles/blacklist_prefs
   A /trunk/src/chrome/test/data/profiles/blacklist_prefs/Preferences

Load filter rules from preferences.

BUG=32782
TEST=unit_tests

Review URL: http://codereview.chromium.org/555033
------------------------------------------------------------------------
r36951 | snej@chromium.org | 2010-01-23 06:46:45 +0100 (Sat, 23 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm

Mac bookmark mgr: Enable menu cmd when no window's open.
Also fixes a related bug not mentioned in the report: app global commands like New Window etc. are disabled when the bookmark manager is active.
BUG=32200
TEST=none (see bug description)
Review URL: http://codereview.chromium.org/551100
------------------------------------------------------------------------
r36946 | thestig@chromium.org | 2010-01-23 04:56:09 +0100 (Sat, 23 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_notification_observers.cc

ChromiumOS: read /proc/uptime without using system().

BUG=32938
TEST=ChromiumOS valgrind becomes happier.
Review URL: http://codereview.chromium.org/553062
------------------------------------------------------------------------
r36937 | thestig@chromium.org | 2010-01-23 03:15:56 +0100 (Sat, 23 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/DEPS
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Linux: Revert r33888. We no longer need to collect the list of loaded plugins since we do not unload them now, thus they already show up in the module list.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551122
------------------------------------------------------------------------
r36929 | pkasting@chromium.org | 2010-01-23 01:25:04 +0100 (Sat, 23 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   D /trunk/src/chrome/browser/worker_host/worker_document_set.cc
   D /trunk/src/chrome/browser/worker_host/worker_document_set.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   D /trunk/src/chrome/test/data/workers/shared_worker_auth.html
   D /trunk/src/chrome/test/data/workers/worker_auth.html
   M /trunk/src/chrome/test/data/workers/worker_common.js
   M /trunk/src/chrome/worker/worker_uitest.cc

Revert 36888 - Refactored code to allow associating workers with multiple renderers.
SharedWorkers now gracefully handle http auth requests after their
initial window has closed.

BUG=27660
TEST=WorkerHttpAuth,SharedWorkerHttpAuth uitests

Review URL: http://codereview.chromium.org/509016

TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/549138
------------------------------------------------------------------------
r36926 | jar@chromium.org | 2010-01-23 00:50:40 +0100 (Sat, 23 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Modulate the UMA version to specify a 64bit build on Linux

There is currently no distinction between the 32 and 64 bit 
build, so this extends the UMA used version to include a postfix "-64" for 64 bit architecture.

This will currently only appear in the stability reports,
but RSN we'll have separate histograms as well.

r=evanm
Review URL: http://codereview.chromium.org/552028
------------------------------------------------------------------------
r36922 | oshima@chromium.org | 2010-01-23 00:37:22 +0100 (Sat, 23 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_extender.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc

3rd step to remove BrowserExtender and to refactor BrowerView for sidebar.
 * defined UIStyle enum
 * fixed #if for compact navbar so that it's enabled only on chromeos
 * Moved view initialization and layouts code from NormalExtender to chromeosBrowserView and ChromeosBrowsrViewLayoutManager respectively.
 * Removed unnecessary extender code from BrowserView.
 * no functional change
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/553059
------------------------------------------------------------------------
r36914 | akalin@chromium.org | 2010-01-22 23:56:53 +0100 (Fri, 22 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

sync: remove unused function.

CreateSyncErrorButton is not unused anywhere.

Original CL by thiago.farina@gmail.com: http://codereview.chromium.org/549003/edit

BUG=None
TEST=compiles

Review URL: http://codereview.chromium.org/552095
------------------------------------------------------------------------
r36908 | feldstein@chromium.org | 2010-01-22 23:08:51 +0100 (Fri, 22 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm

Fix js alert crasher when window is closed by js

There was a problem with pages that call window.close() then immediately open a js alert.  The problem was that the TabContents would get destroyed, but the alert would stick around, and when you closed the alert, it would try to call back to the tab contents' js, crashing chrome.  The other OSs got around this by closing the alert immediately, but mac didn't implement the CloseModalDialog method.  This CL implements that.

BUG=29580
TEST=Run the html attached to the bug

Review URL: http://codereview.chromium.org/549126
------------------------------------------------------------------------
r36907 | rsesek@chromium.org | 2010-01-22 23:02:57 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Fix a bunch of crahes related to opening preferences from an incognito window

BUG=32827
TEST=Open incognito window. Wrench menu --> Preferences --> Basics --> Manage. Don't crash.

Review URL: http://codereview.chromium.org/545177
------------------------------------------------------------------------
r36905 | finnur@chromium.org | 2010-01-22 23:00:09 +0100 (Fri, 22 Jan 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   A /trunk/src/views/controls/resize_gripper.cc
   A /trunk/src/views/controls/resize_gripper.h
   M /trunk/src/views/views.gyp

Resize and overflow for browser actions (part 1).

This changelist implements the following:

- A resize gripper and chevron in the browser action container
- Overflow when icons don't fit
- Snap to multiple of icon size (no excess pixels)
- Animation when resizing container / adding&removing icons (disable, enable).
- Persists the last width of the browser action container.

Known issues:
- No menu (yes, the chevron button doesn't do anything yet).

BUG=32101
TEST=Install and uninstall browser actions & make sure install bubble appears in
the right location. Make sure browser action container does not expand if
chevron is showing when you add browser action. Make sure container loses
chevron when no overflow occurs. Make sure browser action icons never disappear
due to shrinking when you release the mouse (when resizing). Make sure snapping
works.

Review URL: http://codereview.chromium.org/553039
------------------------------------------------------------------------
r36904 | munjal@chromium.org | 2010-01-22 23:00:05 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.h

Remove SYNC_EXPORT macro and all it's uses.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/555044
------------------------------------------------------------------------
r36902 | viettrungluu@chromium.org | 2010-01-22 22:51:21 +0100 (Fri, 22 Jan 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_main_mac.mm

Mac: improve situation with respect to launching/DnD local files.

This is half the solution, but it should make some stuff work. This should make
double-clicking on local HTML files (when Chromium is set as default browser)
work more correctly, both when Chromium is already running and when it's not.
(The same, but easier to check: dragging a file or files to the Chromium
application icon.) You should no longer be told that Chromium can't open HTML
files. It's not the full solution since an extraneous (NTP/home page) tab -- or
worse -- will be created if Chromium is not already running; solving this will
require modifying browser startup.

BUG=14808
TEST=Drag a file to the Chromium application icon, both when it's already running and when it's not; file should open in a tab. Do the same, but select multiple files; selected files should open in tabs. Check the same for the Chromium Dock icon (when Chromium is already running). Note that if Chromium is not running, there will be an extraneous (NTP or home page) tab.

Review URL: http://codereview.chromium.org/552109
------------------------------------------------------------------------
r36901 | eroman@chromium.org | 2010-01-22 22:49:45 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc

Fix improper cancellation when URLFetcher has started throttling requests.

BUG=32844
TEST=URLFetcherCancelTest.CancelWhileDelayedStartTaskPending

Review URL: http://codereview.chromium.org/552107
------------------------------------------------------------------------
r36896 | thestig@chromium.org | 2010-01-22 22:32:00 +0100 (Fri, 22 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

temp_scaffolding_stubs cleanup.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/546110
------------------------------------------------------------------------
r36892 | mark@chromium.org | 2010-01-22 21:54:47 +0100 (Fri, 22 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Add one more cast to placate the 10.6 SDK.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543158
------------------------------------------------------------------------
r36888 | atwilson@chromium.org | 2010-01-22 21:34:25 +0100 (Fri, 22 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   A /trunk/src/chrome/browser/worker_host/worker_document_set.cc
   A /trunk/src/chrome/browser/worker_host/worker_document_set.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   A /trunk/src/chrome/test/data/workers/shared_worker_auth.html
   A /trunk/src/chrome/test/data/workers/worker_auth.html
   M /trunk/src/chrome/test/data/workers/worker_common.js
   M /trunk/src/chrome/worker/worker_uitest.cc

Refactored code to allow associating workers with multiple renderers.
SharedWorkers now gracefully handle http auth requests after their
initial window has closed.

BUG=27660
TEST=WorkerHttpAuth,SharedWorkerHttpAuth uitests

Review URL: http://codereview.chromium.org/509016
------------------------------------------------------------------------
r36884 | kkania@chromium.org | 2010-01-22 21:09:14 +0100 (Fri, 22 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_tests.cc

Disable UpdatePermissions because of flakiness on linux 64.
BUG=none
TEST=none
TBR=asargent
Review URL: http://codereview.chromium.org/553058
------------------------------------------------------------------------
r36883 | hclam@chromium.org | 2010-01-22 20:56:14 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/media/base/media_switches.cc
   M /trunk/src/media/base/media_switches.h
   M /trunk/src/media/filters/ffmpeg_demuxer.cc
   M /trunk/src/media/tools/player_x11/player_x11.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.cc

Switches to enable OpenMAX for video decoding in Chrome

Added a --enable-openmax switch to enable OpenMAX for video
decoding.

Review URL: http://codereview.chromium.org/555046
------------------------------------------------------------------------
r36878 | andybons@chromium.org | 2010-01-22 20:22:53 +0100 (Fri, 22 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

[Mac] Fixes crash where killing an extension via the task manager while a popup is shown would hose the browser.

BUG=32653
TEST=none
Review URL: http://codereview.chromium.org/554044
------------------------------------------------------------------------
r36877 | oshima@chromium.org | 2010-01-22 20:01:41 +0100 (Fri, 22 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h
   M /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc
   M /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h

Move NonClientHitTest impl to BrowserViewLayoutManager because
it depends on how child views are laid out.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/553035
------------------------------------------------------------------------
r36876 | brettw@chromium.org | 2010-01-22 19:58:16 +0100 (Fri, 22 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/chromeos/browser_notification_observers.cc
   A /trunk/src/chrome/browser/chromeos/browser_notification_observers.h
   M /trunk/src/chrome/chrome_browser.gypi

Add a notification observer for the first tab load for Chrome OS.
It simply records the uptime into the tmp directory for metrics collection

BUG=none
TEST=none
Original review: http://codereview.chromium.org/548044
Patch by sosa@chromium.org
------------------------------------------------------------------------
r36875 | snej@chromium.org | 2010-01-22 19:58:10 +0100 (Fri, 22 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm

Mac bookmark mgr: Fix crash with New Folder when Recents selected. Enable New Folder when Bookmark Bar or Others selected.
BUG=32732,32733
TEST=BookmarkTreeControllerTest.NewFolder
Review URL: http://codereview.chromium.org/549125
------------------------------------------------------------------------
r36873 | sky@chromium.org | 2010-01-22 19:35:32 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Makes sure the phantom state of a tab is updated correctly.

BUG=25309
TEST=none

Review URL: http://codereview.chromium.org/551118
------------------------------------------------------------------------
r36870 | cmasone@google.com | 2010-01-22 18:59:18 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/login_library.cc
   M /trunk/src/chrome/browser/chromeos/login_library.h
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc

The login manager didn't gracefully degrade in the event that libcros.so couldn't be loaded.  it segfaulted.  This makes it not die, disable login, and tell the user.  Not so much so that a user could do anything about it, but so that devs can run chromeos chrome on their linux machines and develop the login UI there.

BUG=NONE
TEST=run chromium for chromium OS on your linux box with the --login-manager flag, and watch it not segfault :-)

Review URL: http://codereview.chromium.org/555036
------------------------------------------------------------------------
r36868 | kkania@chromium.org | 2010-01-22 18:51:40 +0100 (Fri, 22 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_tests.cc

Re-enable UninstallDisabled and UpdatePermissions tests. Do not check for infobars.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551106
------------------------------------------------------------------------
r36867 | erg@google.com | 2010-01-22 18:47:14 +0100 (Fri, 22 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK: Use color data from the MetaFrames class in gtk+ theme mode.

Most themes have specific data for a "MetaFrames" class that we weren't using. This fixes the titlebar color
for the xfce themes. I suspect that this also fixes 32173, but I don't have
a Karmic machine yet so I can't test.

BUG=32173
TEST=Themes with different titlebar and selection colors (Xfce-b5 was what I
tested with) shouldn't use the selection color for the titlebar.

Review URL: http://codereview.chromium.org/552092
------------------------------------------------------------------------
r36866 | willchan@chromium.org | 2010-01-22 18:46:27 +0100 (Fri, 22 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   A /trunk/src/chrome/browser/browser_process_sub_thread.cc
   A /trunk/src/chrome/browser/browser_process_sub_thread.h
   M /trunk/src/chrome/browser/gpu_process_host.cc
   A /trunk/src/chrome/browser/io_thread.cc
   A /trunk/src/chrome/browser/io_thread.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/ui/ui_test.cc

Pull IOThread out of BrowserProcessImpl. Move the dns prefetching initialization into IOThread.
The global host resolver and dns master have changed to be member variables of IOThread.
BUG=26156,26159

Review URL: http://codereview.chromium.org/553026
------------------------------------------------------------------------
r36852 | tim@chromium.org | 2010-01-22 07:04:56 +0100 (Fri, 22 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc

Fix leaks due to not deleting closures.

TBR=nick@chromium.org

Review URL: http://codereview.chromium.org/552102
------------------------------------------------------------------------
r36849 | tony@chromium.org | 2010-01-22 06:26:06 +0100 (Fri, 22 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/locales/locales.gyp
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_am.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   A /trunk/src/chrome/app/resources/locale_settings_linux.grd
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   A /trunk/src/chrome/app/resources/locale_settings_mac.grd
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   A /trunk/src/chrome/app/resources/locale_settings_win.grd
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_am.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ar.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_bg.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_bn.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ca.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_cs.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_da.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_de.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_el.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_en-GB.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_es-419.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_es.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_et.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_fi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_fil.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_fr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_gu.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_he.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_hi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_hr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_hu.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_id.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_it.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ja.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_kn.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ko.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_lt.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_lv.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ml.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_mr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_nb.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_nl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_or.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_pl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_pt-BR.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_pt-PT.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ro.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ru.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sk.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sv.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_sw.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_ta.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_te.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_th.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_tr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_uk.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_vi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_zh-CN.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_linux_zh-TW.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_am.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ar.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_bg.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_bn.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ca.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_cs.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_da.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_de.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_el.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_en-GB.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_es-419.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_es.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_et.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_fi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_fil.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_fr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_gu.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_he.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_hi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_hr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_hu.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_id.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_it.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ja.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_kn.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ko.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_lt.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_lv.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ml.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_mr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_nb.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_nl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_or.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_pl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_pt-BR.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_pt-PT.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ro.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ru.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_sk.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_sl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_sr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_sv.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_sw.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_ta.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_te.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_th.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_tr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_uk.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_vi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-CN.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-TW.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_am.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ar.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_bg.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_bn.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ca.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_cs.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_da.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_de.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_el.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_en-GB.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_es-419.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_es.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_et.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_fi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_fil.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_fr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_gu.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_he.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_hi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_hr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_hu.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_id.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_it.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_kn.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ko.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_lt.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_lv.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ml.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_mr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_nb.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_nl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_or.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_pl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_pt-BR.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_pt-PT.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ro.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ru.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_sk.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_sl.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_sr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_sv.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_sw.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_ta.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_te.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_th.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_tr.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_uk.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_vi.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb
   A /trunk/src/chrome/app/resources/platform_locale_settings/locale_settings_win_zh-TW.xtb
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/tools/build/repack_locales.py

Split platform specific settings out from locale_settings.grd so we can
have per platform config and overrides.  This is easier to manage
than the mess of <if>'s in the existing grd and xtb files.

Each platform only builds its locale_settings_{win,mac,linux}.grd file.
All the grd files generate the same platform_locale_settings.h
header (for easy inclusion in .cc files).

We use the fallback feature of grit to only specify locale specific values
in xtb files if we want to override the default for the locale.

BUG=28590

Review URL: http://codereview.chromium.org/545132
------------------------------------------------------------------------
r36838 | tim@chromium.org | 2010-01-22 03:27:24 +0100 (Fri, 22 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h

Fix stupid mistake in sync_session.h, I thought the tests were run on mac/linux (and they
were green) but they aren't. 

TBR=nick@chromium.org


Review URL: http://codereview.chromium.org/552098
------------------------------------------------------------------------
r36835 | tim@chromium.org | 2010-01-22 03:15:42 +0100 (Fri, 22 Jan 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   D /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   D /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h
   D /trunk/src/chrome/browser/sync/glue/bookmark_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/glue/ui_model_worker.cc (from /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc:35972)
   A /trunk/src/chrome/browser/sync/glue/ui_model_worker.h (from /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h:35972)
   A /trunk/src/chrome/browser/sync/glue/ui_model_worker_unittest.cc (from /trunk/src/chrome/browser/sync/glue/bookmark_model_worker_unittest.cc:35972)
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   M /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   A /trunk/src/chrome/browser/sync/syncable/model_type.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Support for multiple sync ModelSafeWorkers.

- Introduce an equivalence class enum to group sync model types that live on the same
chrome native model together.
- Remove ModelSafeWorkerBridge as it is no longer needed.
- Rename BookmarkModelWorker -> UIModelWorker, and make it use the new stuff.
- Allow syncable entries belonging to an "unsynced" model type to be just
processed "passively" from
the SyncerThread (rather than dispatching), and allow this to change as a result
of enable/disabling.
- Experimenting with a way to complete issue 31909 (the CLASS_UNASSOCIATED
stuff).

BUG=31925,31911,31909
Review URL: http://codereview.chromium.org/553015
------------------------------------------------------------------------
r36831 | tommi@chromium.org | 2010-01-22 03:01:50 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   M /trunk/src/chrome_frame/test/html_util_unittests.cc

Fix for FullTabModeIE_ChromeFrameDeleteCookieTest and issues with deleting persistent cookies as reported in bug 30786.

TEST=Run FullTabModeIE_ChromeFrameDeleteCookieTest.
BUG=32546,30786

Review URL: http://codereview.chromium.org/551101
------------------------------------------------------------------------
r36829 | tim@chromium.org | 2010-01-22 02:15:29 +0100 (Fri, 22 Jan 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

fix 32718
------------------------------------------------------------------------
r36817 | estade@chromium.org | 2010-01-22 01:21:44 +0100 (Fri, 22 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_gtk.cc

GTK: remove superflous focus grabbing calls that cause crashes in debug mode.

The body of OnPromptShown handles default focus.

BUG=none
TEST=middle click on a link that requires http auth in debug mode, the browser shouldn't crash

Review URL: http://codereview.chromium.org/554042
------------------------------------------------------------------------
r36815 | sky@chromium.org | 2010-01-22 01:15:17 +0100 (Fri, 22 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

 Adds support for phantom tabs. A pinned tab becomes a phantom tab when
it is closed, and effectively unloads the renderer and replaces it
with a new TabContents that loads when selected. A phantom tab is
currently rendered without a border. Phantom tabs do not prevent a
window from closing.

Long term only pinned app tabs will have the ability to be made
phantom, but this allows us to test the feature until app support is
all wired in.

BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/553008
------------------------------------------------------------------------
r36812 | estade@chromium.org | 2010-01-22 00:43:31 +0100 (Fri, 22 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc

GTK: don't get stuck in render view drag.

Everyone once in a while gtk_drag_begin() returns NULL meaning the drag failed to start. Inform webkit of this.

BUG=30580
TEST=see bug

Review URL: http://codereview.chromium.org/548108
------------------------------------------------------------------------
r36811 | sky@chromium.org | 2010-01-22 00:36:01 +0100 (Fri, 22 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h

Fixes bug where needs_reload_ was not getting set to false in some
situations, leading to a stuck throbber.

BUG=31462
TEST=see bug

Review URL: http://codereview.chromium.org/554025
------------------------------------------------------------------------
r36810 | avi@chromium.org | 2010-01-22 00:35:55 +0100 (Fri, 22 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Remove a comment long-obsolete.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/545160
------------------------------------------------------------------------
r36807 | finnur@chromium.org | 2010-01-22 00:22:49 +0100 (Fri, 22 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix browser crash in extensions due to painting badges on PageActions.

It is possible this will move the crash location elsewhere, but since we don't even support showing badges on PageActions, we have no reason to attempt it.

BUG=http://crbug.com/31080
TEST=Monitor the crash rate and see if the crash is fixed. Badges should still work on BrowserActions.

Review URL: http://codereview.chromium.org/551105
------------------------------------------------------------------------
r36805 | munjal@chromium.org | 2010-01-21 23:53:46 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

More bookmarks string1t work.

TEST=exists
BUG=32013

Review URL: http://codereview.chromium.org/546094
------------------------------------------------------------------------
r36800 | akalin@chromium.org | 2010-01-21 23:37:10 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm

Implemented Esc/Command-. shortcuts for HTML dialogs.

BUG=32216
TEST=manually

Review URL: http://codereview.chromium.org/548051
------------------------------------------------------------------------
r36799 | akalin@chromium.org | 2010-01-21 23:22:40 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc

Removed #ifdef in IncrementErrorCount() now that it's platform-independent.

BUG=30728
TEST=trybots

Review URL: http://codereview.chromium.org/548062
------------------------------------------------------------------------
r36797 | finnur@chromium.org | 2010-01-21 23:06:21 +0100 (Thu, 21 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Take 2: Disable the test (I accidentally modified the file before checking in in my last checkin and added things I was working on but didn't want checked in yet). :/

TBR=oshima
BUG=http://crbug.com/28629, http://crbug.com/16447
TEST=None

Review URL: http://codereview.chromium.org/554041
------------------------------------------------------------------------
r36796 | rsesek@chromium.org | 2010-01-21 23:04:23 +0100 (Thu, 21 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] Fix a crash in the cookies manager that was caused by an invalid selection.

XIB change: Change the "Remove" button's |enabled| binding from just looking at
the count of the selection to FilesOwner.removeButtonEnabled.

BUG=32627
TEST=Covered by unit tests.
TEST=Open cookies manager. Select one item, make sure "Remove" is enabled.
TEST=Open cookies manager. Try to select two items. You shouldn't be able to.

Review URL: http://codereview.chromium.org/546102
------------------------------------------------------------------------
r36795 | finnur@chromium.org | 2010-01-21 23:01:37 +0100 (Thu, 21 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Disable a test on Linux Views. It was marked as flaky, but it is failing all the time.

See http://crbug.com/28629 for details.

TBR=pkasting
BUG=http://crbug.com/28629, http://crbug.com/16447
TEST=None

Review URL: http://codereview.chromium.org/552086
------------------------------------------------------------------------
r36793 | thomasvl@chromium.org | 2010-01-21 23:00:44 +0100 (Thu, 21 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] relayout the import data and clear browser data buttons in the prefs for the string changes that already landed.  more work will be needed to make the window match the new wants, but this gets the tests passing again.

BUG=32719
TEST=unittests green up
Review URL: http://codereview.chromium.org/551103
------------------------------------------------------------------------
r36791 | oshima@chromium.org | 2010-01-21 22:55:50 +0100 (Thu, 21 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/app_menu_model.h

Simplifying appmenu impl.
 Using command id instead of index.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/554038
------------------------------------------------------------------------
r36790 | pam@chromium.org | 2010-01-21 22:55:40 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Insert diagnostics in an attempt to track down a crash in popup menus
in RenderWidgetHostViewMac::ShowPopupWithItems().

BUG=31716
TEST=should have no user-visible effect; see crash reports
Review URL: http://codereview.chromium.org/545159
------------------------------------------------------------------------
r36789 | andybons@chromium.org | 2010-01-21 22:51:35 +0100 (Thu, 21 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Hide browser action buttons when they would otherwise overflow with the omnibar.

TEST=none
BUG=29838
Review URL: http://codereview.chromium.org/553038
------------------------------------------------------------------------
r36784 | nick@chromium.org | 2010-01-21 22:29:13 +0100 (Thu, 21 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Fix an observed shutdown crash after downgrading to an older Chrome release.

Review URL: http://codereview.chromium.org/548105
------------------------------------------------------------------------
r36783 | albertb@google.com | 2010-01-21 22:13:30 +0100 (Thu, 21 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Update the kHasSyncSetupCompleted preference when the bootstraped
authentication is succesful in Chrome OS.

BUG=1220
TEST=The menu option in the wrench menu should indicate that bookmarks are
synced on startup, and it should be possible to disable sync through the
options dialog.

Review URL: http://codereview.chromium.org/551053
------------------------------------------------------------------------
r36781 | finnur@chromium.org | 2010-01-21 21:53:53 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/test/data/find_in_page/move_if_obscuring.html

Try to fix flaky test (FindMovesIfObscuring). I've run this through the try bots three times and they seemed to like the patch.

BUG=16447
TEST=The change is to a test. 

Review URL: http://codereview.chromium.org/553042
------------------------------------------------------------------------
r36780 | andybons@chromium.org | 2010-01-21 21:52:09 +0100 (Thu, 21 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc

[Mac] Wallpaper fix for crasher when an alert is called from an extension popup window.

BUG=29355
TEST=none
Review URL: http://codereview.chromium.org/552084
------------------------------------------------------------------------
r36779 | jhawkins@chromium.org | 2010-01-21 21:39:28 +0100 (Thu, 21 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/autofill_dialog.cc
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/chrome_browser.gypi

Notify the AutoFillManager when the user clicks "Apply" or "OK".  Adds an AutoFillDialogObserver interface that is used to send the profile information back to clients.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555023
------------------------------------------------------------------------
r36774 | timsteele@google.com | 2010-01-21 20:29:25 +0100 (Thu, 21 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   A /trunk/src/base/string_split.cc
   A /trunk/src/base/string_split.h
   A /trunk/src/base/string_split_unittest.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc

Move two generic string split functions from sync API to their own API in base/string_split.

BUG=None 
TEST=base_unittests

Original patch by Thiago Farina
Original Review: http://codereview.chromium.org/464075

Review URL: http://codereview.chromium.org/502074
------------------------------------------------------------------------
r36772 | snej@chromium.org | 2010-01-21 20:25:50 +0100 (Thu, 21 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm

Mac bookmark mgr: Fix crash after closing incognito window.
BUG=32594
TEST=none (see steps to reproduce)
Review URL: http://codereview.chromium.org/554034
------------------------------------------------------------------------
r36769 | feldstein@chromium.org | 2010-01-21 20:18:22 +0100 (Thu, 21 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm

Fix crash in tab's close button.

If you click and hold on a close button that is being animated closed, it will crash if you release it after the tab is completely closed.  The button is being freed when the |super mouseDown| call is in it's tracking loop, so we need to hold on to it with a scoped_nsobject until we're done with it.  The checkImageState call is called unnecessarily, but it shouldn't hurt anything.

BUG=28220
TEST=Click and hold on the close button of a tab that is animating closed.  Release it a couple of seconds after the tab is fully hidden.  To help test, you can change the kAnimationDuration in tab_strip_controller.mm to a higher value.

Review URL: http://codereview.chromium.org/555018
------------------------------------------------------------------------
r36767 | estade@chromium.org | 2010-01-21 20:06:48 +0100 (Thu, 21 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc

GTK: restore ctr+shift+i for devtools (was accidentally changed to ctrl+i).

BUG=32803
TEST=use it
TBR=thestig

Review URL: http://codereview.chromium.org/553046
------------------------------------------------------------------------
r36766 | rsesek@chromium.org | 2010-01-21 19:50:23 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Localize the cookie manager. Also rolls GTM r259:280.

BUG=32338
TEST=Preferences-->Under the Hood-->Show cookies... should now be localized.

Review URL: http://codereview.chromium.org/543128
------------------------------------------------------------------------
r36763 | estade@chromium.org | 2010-01-21 19:29:37 +0100 (Thu, 21 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Disable a failing test on chrome os.

This test was disabled except on linux until I enabled it in r36676. It passes on normal linux, but not chromeos. Further investigation is warranted, but it is not actually a regression.

BUG=32799
TEST=none
TBR=pkasting

Review URL: http://codereview.chromium.org/552083
------------------------------------------------------------------------
r36762 | cpu@chromium.org | 2010-01-21 19:27:43 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc

Position the the inactive toast to the left in RTL machines.

BUG=32474
TEST=see bug for details

Review URL: http://codereview.chromium.org/545144
------------------------------------------------------------------------
r36756 | rohitrao@chromium.org | 2010-01-21 18:07:23 +0100 (Thu, 21 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm

[Mac] Beep when unable to find any matches.

BUG=32790
TEST=Search for something that doesn't exist.  Hear beep.
Review URL: http://codereview.chromium.org/545154
------------------------------------------------------------------------
r36755 | pinkerton@google.com | 2010-01-21 18:00:29 +0100 (Thu, 21 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Ensure method to set up cmd-w/cmd-shift-w runs on the main thread, add a DCHECK to try to catch instances where it is called away from the main thread.
BUG=32786
TEST=cmd-w/cmd-shift-w should always be correct.
Review URL: http://codereview.chromium.org/546106
------------------------------------------------------------------------
r36754 | stuartmorgan@chromium.org | 2010-01-21 17:47:08 +0100 (Thu, 21 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/framework.order
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.h
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Send Cocoa NPAPI plugins an initial window activation event

Until we have real window activation status, just send a window focus event so that Cocoa plugins always think their window is active (as is currently the case with Carbon plugins).

Also wire up the Carbon interposing on window activation checks to talk to the delegate, so once the delegate has correct information Carbon will Just Work.

BUG=31847
TEST=Flash 10.1 should track the mouse when the plugin is loaded, without having to click in it first.

Review URL: http://codereview.chromium.org/552067
------------------------------------------------------------------------
r36749 | tommi@chromium.org | 2010-01-21 16:37:11 +0100 (Thu, 21 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome_frame/http_negotiate.cc
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   M /trunk/src/chrome_frame/test/data/fulltab_delete_cookie_test.html
   M /trunk/src/chrome_frame/urlmon_url_request.cc

Fix FullTabModeIE_ChromeFrameDeleteCookieTest.  The problem was that a domain cookie was being set twice although only set once by the server.
The test itself needed fixing as well as an extra check for domain cookies set by a different url than the current url.

There's one other problem remaining however which was initially reported in bug 30786 and I'll get on that next (bug reopened).

TEST=Run the FullTabModeIE_ChromeFrameDeleteCookieTest test.
BUG=32546, 30786

Review URL: http://codereview.chromium.org/546104
------------------------------------------------------------------------
r36748 | jochen@chromium.org | 2010-01-21 14:10:32 +0100 (Thu, 21 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc

Whitespace change to clobber bots

BUG=none
TEST=none
TBR=thomasvl

Review URL: http://codereview.chromium.org/545152
------------------------------------------------------------------------
r36743 | avayvod@chromium.org | 2010-01-21 10:58:47 +0100 (Thu, 21 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc

Removed restriction for {} so that javascript blocks can be used in the url.
Added unittests for TemplateURLRef::ParseParameter and TemplateURLRef::ParseURL methods.

BUG=2238
TEST=Try adding urls with different combinations of {}, they all should work.

Review URL: http://codereview.chromium.org/555012
------------------------------------------------------------------------
r36736 | thestig@chromium.org | 2010-01-21 06:31:42 +0100 (Thu, 21 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Don't accidentally add downloads with db_handle = kUninitializedHandle, which can happen if the sqlite history db is corrupt / offline.

BUG=25492
TEST=none
Review URL: http://codereview.chromium.org/492017
------------------------------------------------------------------------
r36735 | snej@chromium.org | 2010-01-21 06:28:09 +0100 (Thu, 21 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_item.mm

Mac bookmark manager: Prevents the Recents group from losing its custom icon.
BUG=32740
TEST=Click Recents in bookmark manager, verify it still has a star icon.
Review URL: http://codereview.chromium.org/554029
------------------------------------------------------------------------
r36733 | jorlow@chromium.org | 2010-01-21 05:43:46 +0100 (Thu, 21 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ClearBrowsingData.xib
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 36098 because the UI team has decided on a different long-term direction for
the clear browsing data dialog.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/542126
------------------------------------------------------------------------
r36726 | satorux@chromium.org | 2010-01-21 04:51:32 +0100 (Thu, 21 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc

Add "Text Input" section to the Chromium OS tab.

The section is used to activate and deactivate input languages.

See the design doc for details about the text input support.
http://sites.google.com/a/chromium.org/dev/chromium-os/chromiumos-design-docs/text-input

TEST=manually
BUG=none

Review URL: http://codereview.chromium.org/549082
------------------------------------------------------------------------
r36707 | jcampan@chromium.org | 2010-01-21 01:32:45 +0100 (Thu, 21 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/english_page.html
   A /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

One more attempt at landing this CL.
There are now memory errors in the CLD library that cause memory crashers in reliability tests.
I will add reliability failures to the know_crashes.txt file while the memory errors are being fixed.

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unit-tests.
TBR=brettw

Review URL: http://codereview.chromium.org/555014
------------------------------------------------------------------------
r36697 | kkania@chromium.org | 2010-01-21 00:45:09 +0100 (Thu, 21 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_management_tests.cc

Disable UninstallDisabled and UpdatePermissions temporarily.
BUG=none
TEST=none
TBR=asargent
Review URL: http://codereview.chromium.org/552077
------------------------------------------------------------------------
r36696 | cpu@chromium.org | 2010-01-21 00:14:03 +0100 (Thu, 21 Jan 2010) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/google_update_settings_posix_unittest.cc
   A /trunk/src/chrome/browser/google_update_settings_unittest.cc (from /trunk/src/chrome/browser/google_update_settings_posix_unittest.cc:36463)
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h

Adds a way to record the last run time in the GoogleUpdateSettings class
- to be used as a way to know how long ago chrome was started
- windows only
- enabled unit tests for GoogleUpdateSettings for windows.

BUG=none
TEST=unit test included


Review URL: http://codereview.chromium.org/554017
------------------------------------------------------------------------
r36695 | pinkerton@chromium.org | 2010-01-21 00:12:25 +0100 (Thu, 21 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc

Disable app mode in the model on Mac so it is disabled in the page menu.
BUG=32559
TEST=menu item should be disabled on mac, enabled on win/linux
Review URL: http://codereview.chromium.org/552070
------------------------------------------------------------------------
r36692 | evan@chromium.org | 2010-01-20 23:38:08 +0100 (Wed, 20 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

linux: let first run dialog size itself

Normally we'd rely on the sizes from our resources file, but
in this once case it makes a dialog much larger than necessary
due to different widgets in the Windows dialog.

TEST=first run dialog goes back to being small like it was last month

Review URL: http://codereview.chromium.org/548096
------------------------------------------------------------------------
r36689 | cpu@chromium.org | 2010-01-20 23:25:57 +0100 (Wed, 20 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Include the EUB* and EUC* brands to be excluded from RLZ

BUG=32295
TEST=See bug for testing info

Review URL: http://codereview.chromium.org/555007
------------------------------------------------------------------------
r36687 | thakis@chromium.org | 2010-01-20 23:13:09 +0100 (Wed, 20 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Mac: Enable "Task Manager" menu item even if no browser is open.

BUG=32731
TEST=Close all browser windows. View->Developer->Task Manager should still be active and still work (it should also still be active and work if browser windows are open of course)

Review URL: http://codereview.chromium.org/549113
------------------------------------------------------------------------
r36684 | jhawkins@chromium.org | 2010-01-20 22:57:13 +0100 (Wed, 20 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h

Hook up AutoFill profile DB handling in WebDataService.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552072
------------------------------------------------------------------------
r36682 | snej@chromium.org | 2010-01-20 22:50:48 +0100 (Wed, 20 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Unit test for Mac bookmark pop-up menu item indentation.
BUG=32427
TEST=BookmarkBubbleControllerTest.TestMenuIndentation

Review URL: http://codereview.chromium.org/545139
------------------------------------------------------------------------
r36681 | jcampan@chromium.org | 2010-01-20 22:50:28 +0100 (Wed, 20 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/options_window_view.cc

Landing Dmitry patch:

Place options dialog to the center of last active browser window or monitor if browser window is maximized.

BUG=1143
TEST=Tested on Windows with two monitors.

See original review at http://codereview.chromium.org/536076


Review URL: http://codereview.chromium.org/555009
------------------------------------------------------------------------
r36679 | kkania@chromium.org | 2010-01-20 22:50:03 +0100 (Wed, 20 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   A /trunk/src/chrome/browser/extensions/extension_management_tests.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Add 3 tests for extension installation. Fix and re-enable UpdatePermissions test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/547017
------------------------------------------------------------------------
r36677 | estade@chromium.org | 2010-01-20 22:46:20 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc

GTK: Add back more missing accelerators.

hopefully this is the last of them. I feel like I've left my children at walmart.

BUG=32032
TEST=press them

Review URL: http://codereview.chromium.org/555005
------------------------------------------------------------------------
r36676 | estade@chromium.org | 2010-01-20 22:46:07 +0100 (Wed, 20 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Remove some obsolete ifdefs that excluded certain tests on linux + mac.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/549096
------------------------------------------------------------------------
r36675 | xiyuan@chromium.org | 2010-01-20 22:42:44 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/app/theme/filebrowse_fullscreen.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Adding tab browsing for filebrowser.

Committing this CL on dhg's behalf.
Original Review: http://codereview.chromium.org/542083

BUG=none
TEST=none

------------------------------------------------------------------------
r36671 | mpcomplete@chromium.org | 2010-01-20 22:15:15 +0100 (Wed, 20 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h

Revert an old change where I added a bunch of CHECKs to track down a crash.
The CHECKS were unhelpful, but we don't see the crash anymore.

BUG=15607

Review URL: http://codereview.chromium.org/553022
------------------------------------------------------------------------
r36667 | cmasone@google.com | 2010-01-20 21:39:34 +0100 (Wed, 20 Jan 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos/login_library.cc
   A /trunk/src/chrome/browser/chromeos/login_library.h
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login_manager_view.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi

Change to DBus-based IPC to talk to the Chromium OS session manager
Review URL: http://codereview.chromium.org/551066
------------------------------------------------------------------------
r36666 | thakis@chromium.org | 2010-01-20 21:38:26 +0100 (Wed, 20 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/task_manager.cc

Mac: Don't crash on "Stats for nerds" link if no browser window is open.

BUG=32659
TEST=see bug

Review URL: http://codereview.chromium.org/554023
------------------------------------------------------------------------
r36664 | jhawkins@chromium.org | 2010-01-20 21:15:25 +0100 (Wed, 20 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Implement initial support for saving and loading AutoFill profiles to the WebDB.

BUG=18201
TEST=WebDatabaseTest.AutoFillProfile
Review URL: http://codereview.chromium.org/548078
------------------------------------------------------------------------
r36661 | oshima@chromium.org | 2010-01-20 20:58:18 +0100 (Wed, 20 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   A /trunk/src/chrome/browser/chromeos/chromeos_browser_view.h
   A /trunk/src/chrome/browser/chromeos/panel_browser_view.cc
   A /trunk/src/chrome/browser/chromeos/panel_browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc
   M /trunk/src/chrome/chrome_browser.gypi

refactor browser extender: 2nd step
 * Introducing PanleBrowserView for panel.
 * removed show/close/updatetitlebar/activatechanged and
   moved them to BrowserView subclasses
 * Fixed a bug that I missed in my last change in
   ChromeosBrowserView::LayoutTabStrip

I'm going to get rid of BrowserExtender with a few more
refactoring.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/552046
------------------------------------------------------------------------
r36660 | kkania@chromium.org | 2010-01-20 20:49:56 +0100 (Wed, 20 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/popup.html

Wait for the test extension to notify us instead of the EXTENSION_HOST_DID_STOP_LOADING notification before examining the popup size.
BUG=32724
TEST=none
Review URL: http://codereview.chromium.org/553029
------------------------------------------------------------------------
r36657 | kuchhal@chromium.org | 2010-01-20 20:42:19 +0100 (Wed, 20 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

Mark ExtensionApiTest.BrowserActionPopup as flaky.

BUG=32724
TEST=ExtensionApiTest.BrowserActionPopup
TBR=dpranke

Review URL: http://codereview.chromium.org/543135
------------------------------------------------------------------------
r36654 | skerner@chromium.org | 2010-01-20 20:39:59 +0100 (Wed, 20 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/notification_type.h

Update comments to reflect the removal of class ExtensionActionState, which no longer exists.

BUG=NONE
TEST=Built code after change.


Review URL: http://codereview.chromium.org/543122
------------------------------------------------------------------------
r36652 | jorlow@chromium.org | 2010-01-20 20:26:20 +0100 (Wed, 20 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   D /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   D /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert last 3 patches.  Sorry guys.  :-(


------------------------------------------------------------------------
r36651 | jorlow@chromium.org | 2010-01-20 20:19:40 +0100 (Wed, 20 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc

Sigh...fix the warning.


------------------------------------------------------------------------
r36646 | jorlow@chromium.org | 2010-01-20 19:54:40 +0100 (Wed, 20 Jan 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper.cc
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper.h
   A /trunk/src/chrome/browser/browsing_data_local_storage_helper_unittest.cc

Forgot files.


------------------------------------------------------------------------
r36644 | jorlow@chromium.org | 2010-01-20 19:50:00 +0100 (Wed, 20 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds local storage nodes to cookie tree model and cookies view. 

BUG=none 
TEST=The show cookie dialog box should have a new node "local storage" when appropriate. When selected, it should display details of local storage (name, size on disk, last modified) in the details frame.

Landing for Marcus
Original CL: http://codereview.chromium.org/523139/show

Review URL: http://codereview.chromium.org/546081
------------------------------------------------------------------------
r36632 | phajdan.jr@chromium.org | 2010-01-20 16:24:22 +0100 (Wed, 20 Jan 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/chrome/common/net/net_resource_provider.cc
   M /trunk/src/net/base/dir_header.html
   M /trunk/src/net/ftp/ftp_server_type_histograms.h
   M /trunk/src/net/net.gyp
   D /trunk/src/net/third_party/parseftp/ParseFTPList.cpp
   D /trunk/src/net/third_party/parseftp/ParseFTPList.h
   D /trunk/src/net/third_party/parseftp/README.chromium
   D /trunk/src/net/third_party/parseftp/bugfixes.patch
   D /trunk/src/net/third_party/parseftp/chromium.patch
   M /trunk/src/webkit/glue/DEPS
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Remove the fallback Mozilla code for parsing FTP LIST response.

The new parser seems to be compatible enough to do that. The Mozilla code was very
helpful in the process of developing the new parser.

Also add UI encouraging users to submit bug reports when we can't parse the listings,
and an option to see the raw data sent by the server. This should allow us to fix
remaining compatibility problems with very rare listing types or variations.

When ?raw is found at the end of an FTP url and it is a directory listing, the parsing logic is bypassed and the data is displayed as-is with text/plain MIME type.

TEST=none
BUG=25520

Review URL: http://codereview.chromium.org/549053
------------------------------------------------------------------------
r36631 | joth@chromium.org | 2010-01-20 16:17:08 +0100 (Wed, 20 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/build/features_override.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_thread.cc

Enable geolocation at build time, and update the flag to configure it at runtime.
Depends on https://bugs.webkit.org/show_bug.cgi?id=33467

BUG=29182
TEST=Run with & without --enable-geolocation and open LayoutTests/fast/dom/Geolocation/resources/enabled.js

Review URL: http://codereview.chromium.org/545084
------------------------------------------------------------------------
r36630 | craig.schlenter@chromium.org | 2010-01-20 16:12:37 +0100 (Wed, 20 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Initialize is_extension_install_ properly.

BUG=32541
TEST=Start chromium a couple of times, click on downloaded PDFs and
make sure none of them are misinterpreted as an extension install.

Review URL: http://codereview.chromium.org/542114
------------------------------------------------------------------------
r36628 | jochen@chromium.org | 2010-01-20 15:59:44 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/test/data/blacklist_small.pbl
   M /trunk/src/chrome/test/data/blacklist_small.pbr
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Remove support for filtering by MIME-type.

Also merge kDontSendCookies and kDontStoreCookies to kNoCookies.

BUG=16932
TEST=unit_tests

Review URL: http://codereview.chromium.org/542056
------------------------------------------------------------------------
r36627 | jochen@chromium.org | 2010-01-20 15:17:24 +0100 (Wed, 20 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc

Whitespace change to clobber build bots.

BUG=none
TEST=none
TBR=maruel

Review URL: http://codereview.chromium.org/545133
------------------------------------------------------------------------
r36626 | phajdan.jr@chromium.org | 2010-01-20 10:21:50 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor_unittest.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_listener.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_listener.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_listener_unittest.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.h
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_test_util.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_test_util.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/notification_type.h
   D /trunk/src/chrome/test/data/extensions/common/privacy_blacklist/manifest.json
   D /trunk/src/chrome/test/data/extensions/common/privacy_blacklist/privacy_blacklist.pbl
   D /trunk/src/chrome/test/data/extensions/privacy_blacklists/invalid_blacklist/manifest.json
   D /trunk/src/chrome/test/data/extensions/privacy_blacklists/invalid_blacklist/privacy_blacklist.pbl
   D /trunk/src/chrome/test/data/extensions/privacy_blacklists/missing_blacklist/manifest.json
   M /trunk/src/chrome/test/testing_profile.h

Drop the code allowing privacy blacklists to be shipped in extensions.

The plan is to implement it in a different way.

TEST=Covered by unit_tests.
BUG=21541

Review URL: http://codereview.chromium.org/552025
------------------------------------------------------------------------
r36622 | satorux@chromium.org | 2010-01-20 08:40:49 +0100 (Wed, 20 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_library.cc
   M /trunk/src/chrome/browser/chromeos/language_library.h
   M /trunk/src/chrome/browser/chromeos/language_menu_button.cc

Rename LanguageLibrary::GetLanguages() to GetActiveLanguages().

TEST=built locally
BUG=none

Review URL: http://codereview.chromium.org/546076
------------------------------------------------------------------------
r36617 | shess@chromium.org | 2010-01-20 08:03:18 +0100 (Wed, 20 Jan 2010) | 17 lines
Changed paths:
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite_unittest.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 36615 - SafeBrowsingStore storage abstraction for SafeBrowsing database.

First bit of refactoring safebrowsing to use a flat file format.
SafeBrowsingStore implements just what is needed for
SafeBrowsingDatabase using straightforward read/modify/write code.

There will be a followon change to layer in onthefly format
migration and integrate with SafeBrowsingDatabase.  This CL only adds
new classes and tests for same.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/545053

TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/549105
------------------------------------------------------------------------
r36615 | shess@chromium.org | 2010-01-20 07:29:28 +0100 (Wed, 20 Jan 2010) | 14 lines
Changed paths:
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_sqlite_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

SafeBrowsingStore storage abstraction for SafeBrowsing database.

First bit of refactoring safe-browsing to use a flat file format.
SafeBrowsingStore implements just what is needed for
SafeBrowsingDatabase using straight-forward read/modify/write code.

There will be a follow-on change to layer in on-the-fly format
migration and integrate with SafeBrowsingDatabase.  This CL only adds
new classes and tests for same.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/545053
------------------------------------------------------------------------
r36612 | akalin@chromium.org | 2010-01-20 05:53:15 +0100 (Wed, 20 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Implemented AddressWatchTask for OS X.

Added some utility methods to ServerConnectionManager.

BUG=32430
TEST=Manual testing with a laptop

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36586

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36604

Review URL: http://codereview.chromium.org/543098
------------------------------------------------------------------------
r36611 | jorlow@chromium.org | 2010-01-20 05:48:29 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc

The final step in making session storage cross-process.  Remove dead code and do a bit of refactoring.  Use the recently added session_storage_namespace_id_.

Next steps: a bit more testing then I think we're ready to take it out from behind its flag!

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/523117
------------------------------------------------------------------------
r36607 | yusukes@google.com | 2010-01-20 05:11:25 +0100 (Wed, 20 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_library.cc
   M /trunk/src/chrome/browser/chromeos/language_library.h
   M /trunk/src/chrome/browser/chromeos/language_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/language_menu_button.h

Support intra-IME switcing (e.g. "Japanese Hiragana mode" to "Japanese HalfWidthKatakana mode").
Displays IME properties on the language menu.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/517064
------------------------------------------------------------------------
r36605 | akalin@chromium.org | 2010-01-20 04:17:37 +0100 (Wed, 20 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h

Revert 36604 - Implemented AddressWatchTask for OS X.

Added some utility methods to ServerConnectionManager.

BUG=32430
TEST=Manual testing with a laptop

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36586

Review URL: http://codereview.chromium.org/543098

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/553025
------------------------------------------------------------------------
r36604 | akalin@chromium.org | 2010-01-20 03:59:01 +0100 (Wed, 20 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h

Implemented AddressWatchTask for OS X.

Added some utility methods to ServerConnectionManager.

BUG=32430
TEST=Manual testing with a laptop

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36586

Review URL: http://codereview.chromium.org/543098
------------------------------------------------------------------------
r36603 | jcampan@chromium.org | 2010-01-20 03:32:24 +0100 (Wed, 20 Jan 2010) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/english_page.html
   D /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Revert 36589 - Still failing the reliability tests.

Another try at landing this.
It caused several tests to fails previously.
There was a crasher in some Windows code in the CLD that has been removed by the port of the CLD code to Linux and Mac.
That should hopefully make everything work now.

Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unittests.
TBR=brettw

Review URL: http://codereview.chromium.org/552049

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/554015
------------------------------------------------------------------------
r36602 | jhawkins@chromium.org | 2010-01-20 03:24:45 +0100 (Wed, 20 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc

Connect the 'changed' signal on the label entry and change the expander title as the user types.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/554012
------------------------------------------------------------------------
r36598 | estade@chromium.org | 2010-01-20 03:09:10 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Gtk: don't crash when a dragged tab gets deleted.

Unfortunately, the more correct seeming gtk_grab_remove(gtk_grab_get_current()); doesn't seem to work.

BUG=30592
TEST=see bug

Review URL: http://codereview.chromium.org/542139
------------------------------------------------------------------------
r36592 | tony@chromium.org | 2010-01-20 02:34:12 +0100 (Wed, 20 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

Allow link drags from the bookmark manager out to the Gnome desktop
(nautilus).  This should create a shortcut to the site rather than
downloading the file to the desktop.

I didn't do this before because of the menu crasher.

BUG=24210

Review URL: http://codereview.chromium.org/553024
------------------------------------------------------------------------
r36589 | jcampan@chromium.org | 2010-01-20 02:19:56 +0100 (Wed, 20 Jan 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/english_page.html
   A /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Another try at landing this.
It caused several tests to fails previously.
There was a crasher in some Windows code in the CLD that has been removed by the port of the CLD code to Linux and Mac.
That should hopefully make everything work now.

Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unit-tests.
TBR=brettw

Review URL: http://codereview.chromium.org/552049
------------------------------------------------------------------------
r36588 | akalin@chromium.org | 2010-01-20 02:17:32 +0100 (Wed, 20 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h

Revert 36586 - Implemented AddressWatchTask for OS X.

Added some utility methods to ServerConnectionManager.

BUG=32430
TEST=Manual testing with a laptop

Review URL: http://codereview.chromium.org/543098

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/546083
------------------------------------------------------------------------
r36586 | akalin@chromium.org | 2010-01-20 01:46:13 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h

Implemented AddressWatchTask for OS X.

Added some utility methods to ServerConnectionManager.

BUG=32430
TEST=Manual testing with a laptop

Review URL: http://codereview.chromium.org/543098
------------------------------------------------------------------------
r36585 | tony@chromium.org | 2010-01-20 01:27:42 +0100 (Wed, 20 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

Allow link drags from the star, bookmarks bar, and bookmark bar menus
to the Gnome desktop (nautilus).  These should create shortcuts.
Other drag operations should be the same as before.

BUG=24210

Review URL: http://codereview.chromium.org/548067
------------------------------------------------------------------------
r36583 | tony@chromium.org | 2010-01-20 01:23:12 +0100 (Wed, 20 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

Style cleanup of member variable in FindBarGtk.

I missed this during review.

Review URL: http://codereview.chromium.org/543112
------------------------------------------------------------------------
r36582 | snej@chromium.org | 2010-01-20 01:22:10 +0100 (Wed, 20 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkManager.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Bookmark manager: Implemented new button bar.
(Nib changes: Removed toolbar, added segmented control and pop-up button, removed focus highlighting for outline views.)
BUG=32442
TEST=Verify activation and behavior of + and - buttons and 'gear' menu items.

Review URL: http://codereview.chromium.org/543116
------------------------------------------------------------------------
r36580 | snej@chromium.org | 2010-01-20 01:16:07 +0100 (Wed, 20 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm

Indent menu items in add-bookmark pop-up, to show folder hierarchy.
BUG=32427
TEST=Click 'star' button; click 'Folder:' pop-up. Verify that menu item indentation matches folder nesting.

Review URL: http://codereview.chromium.org/545094
------------------------------------------------------------------------
r36579 | estade@chromium.org | 2010-01-20 01:12:25 +0100 (Wed, 20 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: respect menu model's radio button groupings.

(don't just group by proximity)

BUG=32222
TEST=see bug

Review URL: http://codereview.chromium.org/548074
------------------------------------------------------------------------
r36577 | willchan@chromium.org | 2010-01-20 00:59:20 +0100 (Wed, 20 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Posix: try to make signal handler async signal safe again.
There used to be freezes in browser_tests and ui_tests on the trybots and buildbots, but I've tried the trybots many times and haven't seen this repro, so I'm going to try committing again.
This change is mostly a revert of r35192.

Review URL: http://codereview.chromium.org/546035
------------------------------------------------------------------------
r36570 | georgey@chromium.org | 2010-01-20 00:09:09 +0100 (Wed, 20 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_profile.cc
   M /trunk/src/chrome/browser/autofill/autofill_profile.h

Added public copy constructor to AutoFillProfile to allow it to be used in std containers.
TEST=no
BUG=none
Review URL: http://codereview.chromium.org/553019
------------------------------------------------------------------------
r36562 | snej@chromium.org | 2010-01-19 23:44:34 +0100 (Tue, 19 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_item.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_item_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm

Mac bookmark manager: Make URLs editable.
BUG=32028
TEST=BookmarkItemTest.URL*. Manually: click the URL of a selected item and it will become editable. Type new value and hit Return/Enter.

Review URL: http://codereview.chromium.org/551055
------------------------------------------------------------------------
r36559 | estade@chromium.org | 2010-01-19 23:15:22 +0100 (Tue, 19 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Gtk: fix reference counting/destruction of GtkMenu* in MenuGtk. 

regression caused by r35404 

credit to Bryan Yeung for finding the bug 

BUG=31977, 31765, 32514, 31988
TEST=see bugs

Review URL: http://codereview.chromium.org/552044
------------------------------------------------------------------------
r36557 | thakis@chromium.org | 2010-01-19 23:10:53 +0100 (Tue, 19 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/KeywordEditor.xib
   M /trunk/src/chrome/app/nibs/PageInfo.xib
   M /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   D /trunk/src/chrome/browser/cocoa/nswindow_local_state.h
   D /trunk/src/chrome/browser/cocoa/nswindow_local_state.mm
   D /trunk/src/chrome/browser/cocoa/nswindow_local_state_unittest.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   A /trunk/src/chrome/browser/cocoa/window_size_autosaver.h
   A /trunk/src/chrome/browser/cocoa/window_size_autosaver.mm
   A /trunk/src/chrome/browser/cocoa/window_size_autosaver_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Save/restore task manager window pos and size.

Make window size remembering mechanism easier to use and more compatible with windows's chrome profiles.

Nib changes: Unset "show at startup" so that the initial repositioning isn't visible.

BUG=32147
TEST=Move & size taskman window, quit chrome, reopen chrome. Size & pos should've stayed. Same for keyword editor. Page info dialog should behave as it did before.

Review URL: http://codereview.chromium.org/536086
------------------------------------------------------------------------
r36552 | jshin@chromium.org | 2010-01-19 22:32:42 +0100 (Tue, 19 Jan 2010) | 31 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/french_sentence.html
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_scopedptr.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.h
   M /trunk/src/third_party/cld/base/string_util.h
   M /trunk/src/third_party/cld/cld.gyp

Reland r36541 (which went in without any commit log by some magic). Was reverted in r36550. Now I'm relanding with the full description. 

Port back CLD to Linux and Mac by replacing Windows API calls with ICU's equivalent APIs for normalization. 

I also fixed bug 23553 (Traditional Chinese is not detected) by calling LanguageCode instead of LanguageCode_ISO_639_1. The latter covers only ISO 639-1, but there are languages detected by CLD not covered by ISO 639-1. In that case, ISO 639-2 is used. In case even ISO 639-2 does not cover (e.g. Traditional Chinese), another fallback is taken by LanguageCode. 

The html file for CLD testing (french_sentence.html) is explicitly labelled with charset=ISO-8859-1.

Original Review: http://codereview.chromium.org/523108

BUG=25206,23553
TEST=1. CLD is built on Linux/Mac
     2. The following test pass:
       - unit_tests: Extension*.DetectTabLang* and CompactLangDet*.* 
       - browser_tests: ExtensionBrowserTest.Toolstrip 
     3. Install the 'cld extension' in chrome/common/extensions/docs/examples/api/i18n/cld and go to http://news.google.com.tw and 'zh-TW' shows up in the language badge at the upper right (upper-left in he/ar Chrome) corner. 
TBR=jcampan







Review URL: http://codereview.chromium.org/545123

TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/551070

TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/549091
------------------------------------------------------------------------
r36550 | jshin@chromium.org | 2010-01-19 22:23:27 +0100 (Tue, 19 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/french_sentence.html
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_scopedptr.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.h
   M /trunk/src/third_party/cld/base/string_util.h
   M /trunk/src/third_party/cld/cld.gyp

Revert 36541 (which went in without any commit log by some black magic). 
Reland it with the commit log for the record.


Review URL: http://codereview.chromium.org/545123

TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/551070
------------------------------------------------------------------------
r36549 | jar@chromium.org | 2010-01-19 22:19:13 +0100 (Tue, 19 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Use buildtime to ensure stability stats

r=huanr
Review URL: http://codereview.chromium.org/548058
------------------------------------------------------------------------
r36547 | jhawkins@chromium.org | 2010-01-19 22:15:26 +0100 (Tue, 19 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/common/gtk_util.h

Implement the remaining UI of the gtk AutoFill dialog.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551065
------------------------------------------------------------------------
r36545 | andybons@chromium.org | 2010-01-19 22:14:13 +0100 (Tue, 19 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h
   A /trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Refactors BrowserActionButton to be within its own file, also breaking a circular dependency on BrowserActionsController.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543117
------------------------------------------------------------------------
r36544 | estade@chromium.org | 2010-01-19 22:09:14 +0100 (Tue, 19 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_test_util.h
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_gtk.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h

Port BrowserActionApiTest.BrowserActionPopup to linux.

Also make the test proprely wait for the EXTENSION_HOST_DID_STOP_LOADING signal.

BUG=29710
TEST=compiles

Review URL: http://codereview.chromium.org/515065
------------------------------------------------------------------------
r36541 | jshin@chromium.org | 2010-01-19 21:57:14 +0100 (Tue, 19 Jan 2010) | 2 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/french_sentence.html
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_scopedptr.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.h
   M /trunk/src/third_party/cld/base/string_util.h
   M /trunk/src/third_party/cld/cld.gyp


Review URL: http://codereview.chromium.org/545123
------------------------------------------------------------------------
r36540 | zork@chromium.org | 2010-01-19 21:49:24 +0100 (Tue, 19 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Fix the linux perf build by checking the return value on write()

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/542116
------------------------------------------------------------------------
r36539 | zork@chromium.org | 2010-01-19 21:19:54 +0100 (Tue, 19 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Add an implementation of AddressWatchTask for linux.

BUG=32429
TEST=none
Review URL: http://codereview.chromium.org/545114
------------------------------------------------------------------------
r36534 | estade@chromium.org | 2010-01-19 20:36:40 +0100 (Tue, 19 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/accelerators_gtk.cc

GTK: Re-add keypad accelerators for zoom level.

these got lost in the shuffle.

BUG=32592
TEST=zoom with keypad +,-,0

Review URL: http://codereview.chromium.org/549087
------------------------------------------------------------------------
r36533 | avi@chromium.org | 2010-01-19 20:24:24 +0100 (Tue, 19 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/framework.order
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.h
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.mm
   M /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc
   M /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

(Mac) Allow the tracking of the "active" plugin delegate separate from the fake windows.

BUG=http://crbug.com/20717
TEST=none; no visible change

Review URL: http://codereview.chromium.org/549085
------------------------------------------------------------------------
r36532 | oshima@chromium.org | 2010-01-19 20:10:30 +0100 (Tue, 19 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc

The test was failing in chromeos build.

TBR=evan@chromium.org
BUG=none
TEST=PageMenuModelTest.Basics shoud pass .

Review URL: http://codereview.chromium.org/542100
------------------------------------------------------------------------
r36530 | estade@chromium.org | 2010-01-19 19:46:31 +0100 (Tue, 19 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Escape the '&' character in the back/forward menu entries.

BUG=17660
TEST=See 17660 for reproduction steps.

patch by Aaron Kemp <kemp [at] chromium>
original review: http://codereview.chromium.org/541053/show

Review URL: http://codereview.chromium.org/542113
------------------------------------------------------------------------
r36529 | cpu@chromium.org | 2010-01-19 19:08:39 +0100 (Tue, 19 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/first_run_win.cc

New headline for the inactive toast dialog
- features extensions for US only installs.

BUG=32474
TEST= see bug for details

Review URL: http://codereview.chromium.org/553010
------------------------------------------------------------------------
r36527 | estade@chromium.org | 2010-01-19 18:52:42 +0100 (Tue, 19 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/app/menus/accelerator_gtk.h
   A /trunk/src/chrome/browser/gtk/accelerators_gtk.cc
   A /trunk/src/chrome/browser/gtk/accelerators_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   D /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/page_menu_model.cc
   M /trunk/src/chrome/browser/page_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi

Make a MenuModel for the popup favicon menu. For now only GTK uses it. Consolidate all accelerators for browser commands into one place.

BUG=28212,27535
TEST=1. enable custom frame and a popup window and test that the popup contains all the same (non-system) menu items as windows.
2. all context menus still display the correct shortcuts and the shortcuts work

Review URL: http://codereview.chromium.org/551032
------------------------------------------------------------------------
r36526 | estade@chromium.org | 2010-01-19 18:51:38 +0100 (Tue, 19 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

GTK: don't repaint render view on focus events.

similar to http://codereview.chromium.org/546051

BUG=none
TEST=gtkparasite

Review URL: http://codereview.chromium.org/536066
------------------------------------------------------------------------
r36525 | rogerta@chromium.org | 2010-01-19 18:05:34 +0100 (Tue, 19 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h

Move constants related to chrome.tabs.executeScript() from the .cc file to
the .h file with all the other chrome.tabs.* constants.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/545119
------------------------------------------------------------------------
r36518 | yurys@chromium.org | 2010-01-19 11:12:11 +0100 (Tue, 19 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inject_dispatch.js
   M /trunk/src/webkit/glue/devtools/js/inspector_controller_impl.js
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc

DevTools: prepare to injectiong inspector script into the inspected context.

BUG=29068

Review URL: http://codereview.chromium.org/552033
------------------------------------------------------------------------
r36514 | aa@chromium.org | 2010-01-19 08:43:18 +0100 (Tue, 19 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Fix compile error from 36513.

BUG=32361
TBR=tony@chromium.org
------------------------------------------------------------------------
r36513 | aa@chromium.org | 2010-01-19 08:18:45 +0100 (Tue, 19 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Only create a desktop shortcut for apps if the user requests.

BUG=32361

Review URL: http://codereview.chromium.org/551052
------------------------------------------------------------------------
r36512 | satorux@chromium.org | 2010-01-19 07:17:30 +0100 (Tue, 19 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/language_library.cc
   M /trunk/src/chrome/browser/chromeos/language_library.h

Add GetSupportedLanguages(), ActiveLanguage(), and DeactivateLanguage().

These are wrappers for functions added in libcros

http://git.chromium.org/cgi-bin/gitweb.cgi?p=cros.git;a=commit;h=adc84eae83d75cc6c2a59c89e5276d072ca69c8d

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/542108
------------------------------------------------------------------------
r36503 | aa@chromium.org | 2010-01-19 01:50:49 +0100 (Tue, 19 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc

Fix one more case where we could theoretically intall an extension
without a prompt. See also r36501.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r36501 | aa@chromium.org | 2010-01-19 01:28:07 +0100 (Tue, 19 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Fix a case where we could theoretically install an extension without prompt.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r36500 | rsesek@chromium.org | 2010-01-19 01:23:34 +0100 (Tue, 19 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm

Fix a leak in -[CookiesWindowContrller loadTreeModelFromProfile] from r36497.

TBR=jrg
BUG=none
TEST=Mac Valgrind unit_tests

Review URL: http://codereview.chromium.org/552036
------------------------------------------------------------------------
r36497 | rsesek@chromium.org | 2010-01-19 00:04:52 +0100 (Tue, 19 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] If a user clears browsing data with the cookie manager open, update the UI

BUG=32030
TEST=See repro steps in bug report.

Review URL: http://codereview.chromium.org/551058
------------------------------------------------------------------------
r36490 | jcampan@chromium.org | 2010-01-18 09:20:38 +0100 (Mon, 18 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Moving the page contents message processing to the RenderViewHost.
It was currently processed as a control message.

This is an actual part of the previous CLD related CL:
http://codereview.chromium.org/548057
It kept failing on the bots for some tests, I am not sure why yet and cannot repro locally. Hopefully splitting it will help pinpoint the issue.
 
TEST=All unit-tests, ui tests should still work.
     Navigate to a page with some specific words in it, then go
     to the history tab and search for pages with these specific
     words.  Make sure the page you navigated is shown in the results.
TBR=brettw
 
Review URL: http://codereview.chromium.org/553012
------------------------------------------------------------------------
r36489 | jar@chromium.org | 2010-01-18 07:45:45 +0100 (Mon, 18 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Change default congestion limit for DNS preresolution

UMA data suggests that a 500ms limit on queue duration
(before assuming congestion) provides better user
experience.  This change sets 500ms as the default,
and reduces the percentage of users that have other
experimental values.

BUG=3041,15479
r=eroman
Review URL: http://codereview.chromium.org/543083
------------------------------------------------------------------------
r36488 | jar@chromium.org | 2010-01-18 07:45:38 +0100 (Mon, 18 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc

Add GMT restriction to buildtime calculation

Make sure the buildtime is interpretted the same in all time zones.

r=dpranke
Review URL: http://codereview.chromium.org/546067
------------------------------------------------------------------------
r36485 | oshima@chromium.org | 2010-01-18 03:39:20 +0100 (Mon, 18 Jan 2010) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   D /trunk/src/chrome/browser/views/frame/browser_layout_manager.cc
   D /trunk/src/chrome/browser/views/frame/browser_layout_manager.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h (from /trunk/src/chrome/browser/views/frame/browser_layout_manager.h:36470)
   A /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc
   A /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactoring to reduce chromeos dependency in chrome.
  * renamed BrowserLayoutManager to more explicit, BrowserViewLayoutManager.
  * Added factory method to create chromeos specific tab/tabstrip and layoutmanagers.
  * Introduced ChromeosBrowserView and chromeos specific tab/tabstrip and layoutmanager, and moved chromeos specifi code into them.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36452

Review URL: http://codereview.chromium.org/543095
------------------------------------------------------------------------
r36468 | gregoryd@google.com | 2010-01-17 11:09:39 +0100 (Sun, 17 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc
   D /trunk/src/chrome/browser/sandbox_policy.cc
   D /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/sandbox_policy.cc (from /trunk/src/chrome/browser/sandbox_policy.cc:36119)
   A /trunk/src/chrome/common/sandbox_policy.h (from /trunk/src/chrome/browser/sandbox_policy.h:36119)

Moving sandbox_policy files into chrome/common .
In the next CL (http://codereview.chromium.org/542030/show) NaCl broker code will need to include sandbox_policy.h from chrome/nacl, and without this move check_deps test fails.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543042
------------------------------------------------------------------------
r36463 | finnur@chromium.org | 2010-01-17 00:32:48 +0100 (Sun, 17 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc

Reuse the existing tab when opening the Manage Extensions page and the Options page for an extension.

Thanks to Phistuck for pointing this out.

Also, use IDS_MANAGE_EXTENSIONS for all locales on dev (it will get translated in the next run).

BUG=None
TEST=Use the extension context menu and Manage Extensions and Configure should not open new tabs if that tab already exists.


Review URL: http://codereview.chromium.org/551056
------------------------------------------------------------------------
r36461 | oshima@chromium.org | 2010-01-16 20:04:59 +0100 (Sat, 16 Jan 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   A /trunk/src/chrome/browser/views/frame/browser_layout_manager.cc
   A /trunk/src/chrome/browser/views/frame/browser_layout_manager.h (from /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h:36460)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   D /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h
   D /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc
   D /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert "Refactoring to reduce chromeos dependency in chrome."

This reverts commit 8ae39b4c6290397c03661b59619e125f416a9af8.

TBR=sky@chromium.org
BUG=none
TEST=interactive_ui_tests on windows should pass with revert.

Review URL: http://codereview.chromium.org/542098
------------------------------------------------------------------------
r36455 | oshima@chromium.org | 2010-01-16 12:22:53 +0100 (Sat, 16 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc

revert the revert

Revert "Revert "Revert part of r35312 now that ChromeOS is fixed.""

This reverts commit 6717ffb85f34b1de756f9a703a68ab7ef8336651.

TBR=evan@chromium.org
BUG=none
TEST=unit_tests should pass except for chromeos build.

Review URL: http://codereview.chromium.org/553007
------------------------------------------------------------------------
r36453 | oshima@chromium.org | 2010-01-16 11:36:49 +0100 (Sat, 16 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc

Revert "Revert part of r35312 now that ChromeOS is fixed."

This reverts commit 78422af7d04c5a0244677f8f80258ee1173ba0d3.

TBR=evan@chromium.org
BUG=none
TEST=Basic in ui_tests should pass

Review URL: http://codereview.chromium.org/548065
------------------------------------------------------------------------
r36452 | oshima@chromium.org | 2010-01-16 10:10:20 +0100 (Sat, 16 Jan 2010) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/chromeos_browser_view.cc
   D /trunk/src/chrome/browser/views/frame/browser_layout_manager.cc
   D /trunk/src/chrome/browser/views/frame/browser_layout_manager.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/frame/browser_view_layout_manager.h (from /trunk/src/chrome/browser/views/frame/browser_layout_manager.h:36447)
   A /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.cc
   A /trunk/src/chrome/browser/views/frame/chrome_browser_view_layout_manager.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/chrome_browser.gypi

Refactoring to reduce chromeos dependency in chrome.
  * renamed BrowserLayoutManager to more explicit, BrowserViewLayoutManager.
  * Added factory method to create chromeos specific tab/tabstrip and layoutmanagers.
  * Introduced ChromeosBrowserView and chromeos specific tab/tabstrip and layoutmanager, and moved chromeos specifi code into them.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/543095
------------------------------------------------------------------------
r36447 | jcampan@chromium.org | 2010-01-16 02:59:20 +0100 (Sat, 16 Jan 2010) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/english_page.html
   D /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Revert 36442 - Still causing test failures

4th attempt at landing this.
It caused several tests to fails previously.
Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow).
No code change.

Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unittests. 
TBR=brettw
Review URL: http://codereview.chromium.org/548057

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/536085
------------------------------------------------------------------------
r36446 | oshima@chromium.org | 2010-01-16 02:46:56 +0100 (Sat, 16 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Fix 2 memcheck errors
 * TabData.blocked is not initialized.
 * logo_icon_ was leaking because it's not added to the view tree.

BUG=none
TEST=valgrind failure for these two should be gone with this patch.

Review URL: http://codereview.chromium.org/553004
------------------------------------------------------------------------
r36445 | rsesek@chromium.org | 2010-01-16 02:46:43 +0100 (Sat, 16 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Fix Linux Valgrind bots reporting a Memcheck:Cond from r36415.

TBR=zelidrag
BUG=none
TEST=Linux Valgrind

Review URL: http://codereview.chromium.org/543100
------------------------------------------------------------------------
r36444 | chron@google.com | 2010-01-16 02:36:54 +0100 (Sat, 16 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   A /trunk/src/chrome/browser/sync/protocol/bookmark_specifics.proto
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   M /trunk/src/chrome/browser/sync/sessions/sync_session.h
   M /trunk/src/chrome/chrome.gyp

Merge protocol buffer changes from server back into client.
Use new style protocol in addition to old style protocol when talking to the server in preparation for new data type synchronization.

original patch from issue 487011

TEST=manually tested old client new client new server mixes
BUG=30032

Review URL: http://codereview.chromium.org/549029
------------------------------------------------------------------------
r36443 | rsesek@chromium.org | 2010-01-16 02:35:30 +0100 (Sat, 16 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm

[Mac] Fix beta-blocking bugs in the cookies manager

* Auto-expand the Cookies folder after expanding a domain-level folder
* XIB change: disable multiple selection (and removal) of cookies to prevent a crash
* Auto-select the next cookie after deletion

BUG=31678,32002,32022

TEST=Open cookies manager. Expand a domain and Cookies folder should auto-expand.
TEST=Open cookies manager. Should not be able to perform multiple selection or deletion.
TEST=Open cookies manager. Expand domain with multiple cookies. Delete the first cookie. Second cookie should now be selected.

Review URL: http://codereview.chromium.org/542091
------------------------------------------------------------------------
r36442 | jcampan@chromium.org | 2010-01-16 02:30:48 +0100 (Sat, 16 Jan 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/english_page.html
   A /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

4th attempt at landing this.
It caused several tests to fails previously.
Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow).
No code change.

Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unit-tests. 
TBR=brettw
Review URL: http://codereview.chromium.org/548057
------------------------------------------------------------------------
r36441 | snej@chromium.org | 2010-01-16 02:30:13 +0100 (Sat, 16 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm

Mac bookmark manager: Fix memory leak
BUG=none
TEST=all the bookmark mgr test under valgrind...

Review URL: http://codereview.chromium.org/549075
------------------------------------------------------------------------
r36438 | estade@chromium.org | 2010-01-16 01:31:12 +0100 (Sat, 16 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

GTK: fix sizing of js alert dialogs.

Determine the size request after showing the dialog for the first time. For one reason or another, the size request before that point doesn't take into account the checkbox label text.

BUG=32394
TEST=see bug

Review URL: http://codereview.chromium.org/549073
------------------------------------------------------------------------
r36437 | snej@chromium.org | 2010-01-16 01:31:01 +0100 (Sat, 16 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm

Mac: "Bookmark Manager" menu command closes window if it's already frontmost.
BUG=32331
TEST=Open bookmark manager, choose "Bookmark Manager" menu command again: it should close. Or open, then activate browser window, then choose command again: it'll come to the front.

Review URL: http://codereview.chromium.org/536072
------------------------------------------------------------------------
r36435 | akalin@chromium.org | 2010-01-16 01:11:44 +0100 (Sat, 16 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac.mm

mac/sync: Use sync_ui_util::GetStatus when we just want to know the status.

(patch by thiago.farina@gmail.com ; original code review is http://codereview.chromium.org/541006 )

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/541059
------------------------------------------------------------------------
r36434 | johnnyg@chromium.org | 2010-01-16 00:58:34 +0100 (Sat, 16 Jan 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/notifications
   A /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc
   A /trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.h
   A /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.cc
   A /trunk/src/chrome/browser/gtk/notifications/balloon_view_host_gtk.h
   A /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.cc
   A /trunk/src/chrome/browser/gtk/notifications/notification_options_menu_model.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/renderer/render_thread.cc

Port notifications to linux.  BalloonView and BalloonViewHost should be equivalent to their counterparts under browser/views/notifications; CL also enables the exposure of notifications in WebKit on linux platform.

BUG=23954
TEST=none

Review URL: http://codereview.chromium.org/525050
------------------------------------------------------------------------
r36432 | snej@chromium.org | 2010-01-16 00:18:20 +0100 (Sat, 16 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkManager.xib
   D /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.h
   D /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_groups_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_item.h
   M /trunk/src/chrome/browser/cocoa/bookmark_item.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_item_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac bookmark mgr: UI overhaul, and adding Recents and Search features.
The list views now match the Windows version: left one is a tree that only shows folders, right one is a flat list.
In BookmarkManager.xib: left pane changed to BookmarkTreeController, 'folder' column added to right outline view, toolbar added.
BUG=31969,32080
TEST=new unit tests on BookmarkManagerController, BookmarkItem, BookmarkTreeController.

Review URL: http://codereview.chromium.org/536063
------------------------------------------------------------------------
r36429 | evan@chromium.org | 2010-01-15 23:39:27 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc

Revert part of r35312 now that ChromeOS is fixed.

The test used to rely on menu item #3, while the change made it use the
last item; the last item on Linux is a submenu so the test was failing.
Go back to menu item #3.

Review URL: http://codereview.chromium.org/545098
------------------------------------------------------------------------
r36427 | cpu@chromium.org | 2010-01-15 23:34:57 +0100 (Fri, 15 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/common/render_messages_internal.h

Low latency audio render host preliminaries

- adds a second transport, existing mode is unchanged
- switching logic for transport according to packet size
- new message to render so it can use the syncsocket
- non operational yet, so no tests included yet, however bits 
  are already tested in media-audio unittests.

TEST=none
BUG=28292


Review URL: http://codereview.chromium.org/515046
------------------------------------------------------------------------
r36423 | erg@google.com | 2010-01-15 23:17:48 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK: Theme the NTP with GTK+ colors.

BUG=29948
TEST=none

Review URL: http://codereview.chromium.org/551051
------------------------------------------------------------------------
r36422 | thakis@chromium.org | 2010-01-15 23:15:52 +0100 (Fri, 15 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc

Mac: Coalesce scroll events.

Based on work by trungl, codereview issue 502056. He's busy, but I think this is an important patch, so I'll try to get it through review for him.

BUG=28954
TEST=On a MacBook (Pro) -- the slower the better -- go to <http://www.starcraft2.com/faq.xml> and make sure that scrolling using a two-fingered swipe on the trackpad is much faster than before. Also make sure that using the mouse wheel to scroll remains okay with various devices on all platforms.

Review URL: http://codereview.chromium.org/536059
------------------------------------------------------------------------
r36416 | avi@chromium.org | 2010-01-15 22:51:19 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/framework.order
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.h
   M /trunk/src/chrome/plugin/plugin_interpose_util_mac.mm
   M /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc
   M /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webcursor_mac.mm

(Mac) Intercept (Carbon) cursor setting by plugins and forward it on properly.

BUG=http://crbug.com/20717
TEST=as in bug; this covers old Flash

Review URL: http://codereview.chromium.org/550062
------------------------------------------------------------------------
r36415 | zelidrag@google.com | 2010-01-15 22:49:44 +0100 (Fri, 15 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.h
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.h
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/view.cc

Tab-modal dialog improvements:
- treat constrained dialogs as tab-modal - only one shows at the time
- added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog
- blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs

This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018.


BUG=456,27585,27620
TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc.

Review URL: http://codereview.chromium.org/541056
------------------------------------------------------------------------
r36414 | aa@chromium.org | 2010-01-15 22:46:56 +0100 (Fri, 15 Jan 2010) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js

Revert r36407
TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r36411 | evan@chromium.org | 2010-01-15 22:37:08 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model.cc

linux: re-disable the report bug menu item

(I've mailed some people separately about now-duplicated code.)

BUG=11600

Review URL: http://codereview.chromium.org/550018
------------------------------------------------------------------------
r36407 | aa@chromium.org | 2010-01-15 22:19:30 +0100 (Fri, 15 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js

Re-land r36338: Add the ability to focus a window to chrome.window.update().

BUG=31434
TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r36402 | jhawkins@chromium.org | 2010-01-15 21:58:44 +0100 (Fri, 15 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Simplify the gtk AutoFill dialog and bring it more in line with the mocks.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551034
------------------------------------------------------------------------
r36398 | avayvod@google.com | 2010-01-15 21:09:19 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc

The search terms are escaped using + or %20 for space depending on whether replacement is in query part of the URL or not.
Removed duplicate EscapeQueryParamValue functions without |use_plus| argument.

BUG=24571
TEST=Verify that space is escaped as stated in description; see bug description for example with search on Wikipedia.
Review URL: http://codereview.chromium.org/543077
------------------------------------------------------------------------
r36396 | akalin@chromium.org | 2010-01-15 21:05:55 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Don't show sad tab page for TabContents in browser shutdown.

BUG=28625
TEST=Manual; made sure quitting (on any platform) doesn't cause sad tab to flash on HTML dialogs

Review URL: http://codereview.chromium.org/546058
------------------------------------------------------------------------
r36395 | jschuh@chromium.org | 2010-01-15 21:03:29 +0100 (Fri, 15 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Make --app switch URL restrictions match normal command line restrictions.

My change for issue 9862 made --app switch more restrictive than for normal command line URLs. This doesn't seem to have any additional security benefit and breaks stand-alone chrome extensions. So, I'm removing the additional restrictions on the --app URLs.

BUG=32377
TEST=None.

Review URL: http://codereview.chromium.org/545082
------------------------------------------------------------------------
r36393 | oshima@chromium.org | 2010-01-15 20:48:04 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Fixing cut&paste error in my change to accelerator table.

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/548060
------------------------------------------------------------------------
r36384 | sky@chromium.org | 2010-01-15 20:25:53 +0100 (Fri, 15 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Lands http://codereview.chromium.org/545058 for Dmitry:

Preserve short_name for search engine from OSDD file and generate
keyword from URL in OSDD for JS added search engines. 

BUG=7851
TEST=Try adding search engine via JS and autodetected search engines. 

------------------------------------------------------------------------
r36382 | jianli@chromium.org | 2010-01-15 20:05:54 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.h

Fix build break.

TBR=dimich
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/550060
------------------------------------------------------------------------
r36380 | oshima@chromium.org | 2010-01-15 19:56:58 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

Removing obsolete code for chromeos.
Adding/removing chromeos specific accelerator from accelerator_table_gtk.cc.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/548040
------------------------------------------------------------------------
r36378 | jianli@chromium.org | 2010-01-15 19:49:58 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/app/clipboard/clipboard_util_win.cc
   M /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data.h
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/app/os_exchange_data_provider_win.h
   M /trunk/src/app/os_exchange_data_win_unittest.cc
   M /trunk/src/base/base_drag_source.cc
   M /trunk/src/base/base_drag_source.h
   M /trunk/src/base/base_drop_target.cc
   M /trunk/src/base/base_drop_target.h
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/message_pump_win.h
   M /trunk/src/chrome/browser/cocoa/download_item_mac.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.h
   A /trunk/src/chrome/browser/download/drag_download_file_win.cc
   A /trunk/src/chrome/browser/download/drag_download_file_win.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source_win.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.cc
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_drag_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/webkit/glue/webdropdata.cc
   M /trunk/src/webkit/glue/webdropdata.h

Support dragging a virtual file out of the browser.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/351029
------------------------------------------------------------------------
r36377 | oshima@chromium.org | 2010-01-15 19:44:42 +0100 (Fri, 15 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   A /trunk/src/chrome/browser/views/frame/browser_layout_manager.cc
   A /trunk/src/chrome/browser/views/frame/browser_layout_manager.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Factoring out the layout code from browser_view in preparation to implement side bar. (and this will also allow us to clean up browser extender)
 - BrowserLayoutManager interface with extra layout methods for BrowserView
 - ChromeLayoutManager implements the same layout policy as of today.
 - Added new view IDs so that layout manager can identify comoponents added to the BrowserView.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36276

Review URL: http://codereview.chromium.org/543035
------------------------------------------------------------------------
r36374 | brettw@chromium.org | 2010-01-15 19:31:17 +0100 (Fri, 15 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_proxy.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_proxy.h
   A /trunk/src/chrome/browser/renderer_host/gpu_view_host.cc (from /trunk/src/chrome/browser/renderer_host/gpu_view_host_win.cc:36076)
   A /trunk/src/chrome/browser/renderer_host/gpu_view_host.h (from /trunk/src/chrome/browser/renderer_host/gpu_view_host_win.h:36076)
   D /trunk/src/chrome/browser/renderer_host/gpu_view_host_win.cc
   D /trunk/src/chrome/browser/renderer_host/gpu_view_host_win.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/chrome_browser.gypi

Make the browser-side of the GPU backing store work on Linux (and should now
work for Mac with trivial hooks into RenderViewHostMac).

The GPU process end of it is still unimplemented, and it will fail if you
actually try to use this mode.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543068
------------------------------------------------------------------------
r36370 | andybons@chromium.org | 2010-01-15 19:16:28 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm

[Mac] Fixes two Browser Action popup sizing issues. One is caused by WebCore sending 0 as a preferred width for a WebView after the correct dimensions have been already received. The other involves a core animation race condition where my code to check for an existing animation was simply incorrect.

TEST=none
BUG=32162

Review URL: http://codereview.chromium.org/551030
------------------------------------------------------------------------
r36369 | asargent@chromium.org | 2010-01-15 19:12:59 +0100 (Fri, 15 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc

Fix cases where we weren't expecting a NULL preference.

This both fixes a specific crash and possibly one or two others that were 
waiting to happen since we weren't always checking for NULL return values from 
PrefService::GetDictionary.


BUG=32079
TEST=(crash should no longer show up)


Review URL: http://codereview.chromium.org/545070
------------------------------------------------------------------------
r36367 | brettw@chromium.org | 2010-01-15 19:05:16 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Enable the context menu and developer menu "View source" items at the same time.
This fixes issue 2028 which didn't enable the context menu item for new tabs.

BUG=2028
TEST=Open a new tab and verify that the 'View page source' context menu is enabled.
Original review: http://codereview.chromium.org/541016
Patch by Aaron Kemp
------------------------------------------------------------------------
r36364 | jcampan@chromium.org | 2010-01-15 18:38:19 +0100 (Fri, 15 Jan 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/english_page.html
   D /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Revert 36362 - It breaks NACLTests and Chrome Frame Tests

3rd attempt at landing the language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unittests.

Review URL: http://codereview.chromium.org/518075

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/546062
------------------------------------------------------------------------
r36362 | jcampan@chromium.org | 2010-01-15 18:05:46 +0100 (Fri, 15 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/english_page.html
   A /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

3rd attempt at landing the language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unit-tests.

Review URL: http://codereview.chromium.org/518075
------------------------------------------------------------------------
r36355 | sky@chromium.org | 2010-01-15 17:10:28 +0100 (Fri, 15 Jan 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/state_tracker.cc
   D /trunk/src/chrome/browser/state_tracker.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome_browser.gypi

Removes debugging code that proved unnecessary.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552005
------------------------------------------------------------------------
r36351 | jschuh@chromium.org | 2010-01-15 15:21:32 +0100 (Fri, 15 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Remove URL command line filtering from main startup path.

Update to fix startup performance regression for http://codereview.chromium.org/550008

BUG=9862
TEST=browser_tests --gtest_filter=BrowserInitTest.BlockBadURLs

Review URL: http://codereview.chromium.org/542076
------------------------------------------------------------------------
r36345 | apavlov@chromium.org | 2010-01-15 11:52:44 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

Hide the View Page Source/Info and other irrelevant actions in the DevTools page context menu

BUG=32073
TEST=none

Review URL: http://codereview.chromium.org/542057
------------------------------------------------------------------------
r36340 | aa@chromium.org | 2010-01-15 09:47:48 +0100 (Fri, 15 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Reland 36337: Add launch configuration to apps. Create a desktop shortcut if launch configuration is present. Future
changes will add UI asking if the user wants to create a shortcut first, and change the presentation when the shortcut is
launched.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r36339 | aa@chromium.org | 2010-01-15 09:24:59 +0100 (Fri, 15 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js

Revert 36337 and 36338. Compile failure.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r36338 | aa@chromium.org | 2010-01-15 09:05:14 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js

Add the ability to focus a window to chrome.window.update().
Also, enable the tabs api test on linux. I'm probably going
to regret that, but it seems to work with one line removed.

BUG=31434

Review URL: http://codereview.chromium.org/545044
------------------------------------------------------------------------
r36337 | aa@chromium.org | 2010-01-15 09:04:36 +0100 (Fri, 15 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h

Add launch configuration to apps. Create a desktop shortcut
if launch configuration is present.

Future changes will add UI asking if the user wants to create
a shortcut first, and change the presentation when the
shortcut is launched.

Review URL: http://codereview.chromium.org/543055
------------------------------------------------------------------------
r36331 | jorlow@chromium.org | 2010-01-15 05:50:34 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_factory.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_factory.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/common/dom_storage_common.h
   D /trunk/src/chrome/common/dom_storage_type.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Introduce all the plumbing for Session Storage.  This mostly consists of creating and tracking namespace ids in conjunction with the tabs.  This is essentially just a bunch of dead code at the moment, but the next patch will get rid of the old way of generating/cloning IDs (initiated by the renderer) and instead use these IDs.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/550017
------------------------------------------------------------------------
r36321 | tony@chromium.org | 2010-01-15 02:27:13 +0100 (Fri, 15 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/app/gtk_dnd_util.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc

Allow link drags from Chrome to create a shortcut on the desktop.

This required adding the netscape link+title format to the drag data
(we were already doing this on windows) and adding GDK_ACTION_LINK
to the GdkDragAction passed into gtk_drag_begin.

BUG=27337
TEST=Drag a link to the desktop, it should create a shortcut (.desktop file).

Review URL: http://codereview.chromium.org/542072
------------------------------------------------------------------------
r36316 | rsesek@chromium.org | 2010-01-15 01:43:43 +0100 (Fri, 15 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Revert 36314 - Failed unit tests - Fix a leak in CookiesWindowControllerTest and remove the appropriate suppression

BUG=31586
TEST=Mac Valgrind unit tests

Review URL: http://codereview.chromium.org/527001

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/545073
------------------------------------------------------------------------
r36314 | rsesek@chromium.org | 2010-01-15 01:21:51 +0100 (Fri, 15 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix a leak in CookiesWindowControllerTest and remove the appropriate suppression

BUG=31586
TEST=Mac Valgrind unit tests

Review URL: http://codereview.chromium.org/527001
------------------------------------------------------------------------
r36313 | erg@google.com | 2010-01-15 01:19:56 +0100 (Fri, 15 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Draw background color on the toolbar to deal with small theme bitmaps.

(Plus some gdk_cairo_rectangle() cleanups)

BUG=26255
TEST=none

Review URL: http://codereview.chromium.org/542084
------------------------------------------------------------------------
r36311 | apatrick@chromium.org | 2010-01-15 01:10:09 +0100 (Fri, 15 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.cc
   A /trunk/src/webkit/glue/webplugin.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/webkit.gyp

Set disabled style on GPU window and plugin intermediate window so mouse messages pass through to the browser window.
TEST=trybots
BUG=none

Review URL: http://codereview.chromium.org/549025
------------------------------------------------------------------------
r36306 | ericu@google.com | 2010-01-15 00:48:42 +0100 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Mark PreferPreviousSearch as flaky on ChromeOS.

BUG=32312
TBR=jshin
TEST=NONE

Review URL: http://codereview.chromium.org/550052
------------------------------------------------------------------------
r36300 | jshin@chromium.org | 2010-01-15 00:10:11 +0100 (Fri, 15 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   D /trunk/src/chrome/browser/views/frame/browser_layout_manager.cc
   D /trunk/src/chrome/browser/views/frame/browser_layout_manager.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert 36276 - Factoring out the layout code from browser_view in preparation to implement side bar. (and this will also allow us to clean up browser extender)
  BrowserLayoutManager interface with extra layout methods for BrowserView
  ChromeLayoutManager implements the same layout policy as of today.
  Added new view IDs so that layout manager can identify comoponents added to the BrowserView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/543035

TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/550050
------------------------------------------------------------------------
r36291 | mattm@chromium.org | 2010-01-14 23:36:35 +0100 (Thu, 14 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/crypto/rsa_private_key_nss.cc
   M /trunk/src/base/crypto/signature_creator_nss.cc
   M /trunk/src/base/crypto/signature_verifier_nss.cc
   M /trunk/src/base/hmac_nss.cc
   D /trunk/src/base/nss_init.cc
   D /trunk/src/base/nss_init.h
   A /trunk/src/base/nss_util.cc (from /trunk/src/base/nss_init.cc:36283)
   A /trunk/src/base/nss_util.h (from /trunk/src/base/nss_init.h:36283)
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/gtk/certificate_viewer.cc
   A /trunk/src/chrome/browser/gtk/certificate_viewer.h
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_linux.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/net/base/cert_database_nss.cc
   M /trunk/src/net/base/keygen_handler_nss.cc
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/http/des.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/url_request/url_request_unittest.cc

Linux: Add Certificate Info dialog (part 1)

Rename base/nss_init.{h,cc} to base/nss_util.{h,cc}, move PRTimeToBaseTime there.

BUG=18119
TEST=Load https://www.google.com, compare to firefox cert dialog.

Review URL: http://codereview.chromium.org/500141
------------------------------------------------------------------------
r36287 | pinkerton@chromium.org | 2010-01-14 23:33:05 +0100 (Thu, 14 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/event_utils.h
   M /trunk/src/chrome/browser/cocoa/event_utils.mm

Fix command-click on buttons in background windows to perform their action in the context of the background window's controller, not the one associated with the foreground window. Command-click on back/fwd button in a background window doesn't have any special open disposition like it does in fg window.
BUG=16191
TEST=menus, key commands, button command dispatching should all still work for foreground and background windows. Test cmd-clicking buttons in a browser when a non-browser is the foreground window.
Review URL: http://codereview.chromium.org/543044
------------------------------------------------------------------------
r36278 | cpu@chromium.org | 2010-01-14 23:12:59 +0100 (Thu, 14 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc
   M /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc

Improvements to the diagnostic mode
- bettet banner
- init ICU
- size checks on the critical paths

BUG=none
TEST=included


Review URL: http://codereview.chromium.org/521050
------------------------------------------------------------------------
r36276 | oshima@chromium.org | 2010-01-14 23:09:19 +0100 (Thu, 14 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   A /trunk/src/chrome/browser/views/frame/browser_layout_manager.cc
   A /trunk/src/chrome/browser/views/frame/browser_layout_manager.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Factoring out the layout code from browser_view in preparation to implement side bar. (and this will also allow us to clean up browser extender)
 - BrowserLayoutManager interface with extra layout methods for BrowserView
 - ChromeLayoutManager implements the same layout policy as of today.
 - Added new view IDs so that layout manager can identify comoponents added to the BrowserView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/543035
------------------------------------------------------------------------
r36265 | oshima@chromium.org | 2010-01-14 21:59:35 +0100 (Thu, 14 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Use image_view to draw distributor/otr avatar icons
to make it easy to change component layout in the frame.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/545049
------------------------------------------------------------------------
r36259 | andybons@chromium.org | 2010-01-14 20:40:00 +0100 (Thu, 14 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_mac.mm

[Mac] Fixes issues with browser action popups.
o If you click on a browser action with a popup repeatedly and rapidly, the popups will "stick around."
o If you click a browser action button with a popup already open, it should close the popup instead of opening it.

TEST=none
BUG=32161,31097
Review URL: http://codereview.chromium.org/548037
------------------------------------------------------------------------
r36258 | jcampan@chromium.org | 2010-01-14 20:36:32 +0100 (Thu, 14 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_posix.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/string_util_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/renderer_host/translation_service.cc
   A /trunk/src/chrome/browser/renderer_host/translation_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/renderer/translate
   A /trunk/src/chrome/renderer/translate/page_translator.cc
   A /trunk/src/chrome/renderer/translate/page_translator.h
   A /trunk/src/chrome/renderer/translate/page_translator_unittest.cc
   A /trunk/src/chrome/renderer/translate/text_translator.h
   A /trunk/src/chrome/renderer/translate/text_translator_impl.cc
   A /trunk/src/chrome/renderer/translate/text_translator_impl.h
   A /trunk/src/chrome/test/data/translate
   A /trunk/src/chrome/test/data/translate/basic_ORIGINAL.html
   A /trunk/src/chrome/test/data/translate/basic_TRANSLATED.html
   A /trunk/src/chrome/test/data/translate/chrome_wikipedia_ORIGINAL.html
   A /trunk/src/chrome/test/data/translate/chrome_wikipedia_TRANSLATED.html
   A /trunk/src/chrome/test/data/translate/reverse_text.py

This CL contains the back-end implementation of the translate feature. It adds a Translate method to the renderer.
On invocation this method triggers a traversal of the DOM page to retrieve the text nodes.  The text node contents are then sent to the browser for actual translation (at this point, we just up-case the text for testing purpose).
The browser sends back the translated text to the renderer that replace the DOM text node values with the translated text.

BUG=None
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/547013
------------------------------------------------------------------------
r36253 | sky@chromium.org | 2010-01-14 19:54:24 +0100 (Thu, 14 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Lands http://codereview.chromium.org/551010 for avayvod:

Disabled Remove button if there's only one URL in the list.
Added requirement for the default search engine URL to have %s when
editing.

BUG=2714
TEST=See the bug description for reproduction steps.

Review URL: http://codereview.chromium.org/543061
------------------------------------------------------------------------
r36250 | erg@google.com | 2010-01-14 19:25:57 +0100 (Thu, 14 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Use themed warning icon in GTK+ theme mode.

BUG=18340
TEST=none

Review URL: http://codereview.chromium.org/551020
------------------------------------------------------------------------
r36243 | jochen@chromium.org | 2010-01-14 17:45:08 +0100 (Thu, 14 Jan 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_perftest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Meassure performance of matching URLs against a sample filter list.

BUG=31827
TEST=perf_tests

Review URL: http://codereview.chromium.org/524063
------------------------------------------------------------------------
r36240 | ananta@chromium.org | 2010-01-14 16:25:13 +0100 (Thu, 14 Jan 2010) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_list.cc

Fix a Chrome crash which occurs when the chrome instance launched via ChromeFrame is shutting down.
I was not able to reproduce this locally. Based on the crash dump, it looks like the crash occurs
when the sync channel used by the automation provider is shutting down and it is attempting a PostTask
of OnChannelClosed. The crash occurs while posting the task to the message loop, because the message loop
is invalid.

This could occur if the message loop has been destroyed. The message loop is destroyed when the module
refcount drops to zero. The automation provider releases the module ref count in OnChannelError. In theory
there is a race condition here, i.e. the message loop could be destroyed before the ExternalTabContainer,
etc are destroyed.

Suggested fix is to call AddRefModule which grabs a reference on the UI message loop in the automation provider
constructor and release it in the destructor. We also close the channel before invoking ReleaseModule in the
destructor.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=31621

Bug=31621

Review URL: http://codereview.chromium.org/542036
------------------------------------------------------------------------
r36239 | jschuh@chromium.org | 2010-01-14 16:15:54 +0100 (Thu, 14 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc

Limit URL schemes passed on the command line to file: and those allowed by RendererSecurityPolicy::IsWebSafeScheme

BUG=9862
TEST=browser_tests --gtest_filter=BrowserInitTest.BlockBadURLs

Review URL: http://codereview.chromium.org/550008
------------------------------------------------------------------------
r36231 | willchan@chromium.org | 2010-01-14 09:14:36 +0100 (Thu, 14 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc

Revert 36230 - Switch on socket late binding.
Broke mac valgrind for test_shell_tests.  Various errors.  I also missed fixing a bug that eroman pointed out in review.  Total brainfart.
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets.  Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly.  It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways.  A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.

Review URL: http://codereview.chromium.org/543051

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/549047
------------------------------------------------------------------------
r36230 | willchan@chromium.org | 2010-01-14 07:31:32 +0100 (Thu, 14 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc

Switch on socket late binding.
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets.  Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly.  It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways.  A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.

Review URL: http://codereview.chromium.org/543051
------------------------------------------------------------------------
r36213 | arv@chromium.org | 2010-01-14 02:40:04 +0100 (Thu, 14 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc
   A /trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.h
   A /trunk/src/chrome/browser/extensions/extension_bookmark_manager_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/bookmark_manager
   A /trunk/src/chrome/test/data/extensions/api_test/bookmark_manager/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/bookmark_manager/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/bookmark_manager/test.js

Add an experimental bookmark manager API to extensions.

BUG=32194
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.BookmarkManager

Review URL: http://codereview.chromium.org/550021
------------------------------------------------------------------------
r36208 | mbelshe@chromium.org | 2010-01-14 02:02:53 +0100 (Thu, 14 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/webkit/extensions/v8/benchmarking_extension.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Rename CloseIdleConnections -> CloseCurrentConnections.

This method is (and was) just for debugging; while it was closing
idle connections, that was not aggressive enough; the benchmark needs
to close all connections, not just the idle ones.

To ensure connections are abandoned, create a new pool; leaving the old pool
to languish as any pending sockets die.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/549031
------------------------------------------------------------------------
r36206 | chocobo@chromium.org | 2010-01-14 02:00:39 +0100 (Thu, 14 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h

Add cellular networks to network menu button.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/536055
------------------------------------------------------------------------
r36197 | erg@chromium.org | 2010-01-14 01:16:46 +0100 (Thu, 14 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Reapplying "Extensions: tab.title should not be undefined."

I can no longer replicate the Vista unit test failures locally; I am assuming
it was flake on the part of the tests.

(If you request tab information while the page is loading, the tab.title
is undefined and it shouldn't be.)

Original Review URL: http://codereview.chromium.org/196125

BUG=22288
TEST=none

Review URL: http://codereview.chromium.org/542065
------------------------------------------------------------------------
r36195 | snej@chromium.org | 2010-01-14 01:13:13 +0100 (Thu, 14 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkManager.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_item.h
   A /trunk/src/chrome/browser/cocoa/bookmark_item.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_item_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Change bookmark manager object model.

This is in preparation for adding Recents/Search. Apologies for the number of diffs, but most of them are basically just renaming, especially 'id' --> 'BookmarkItem*' and 'node'-->'item'.

The code now has a real Objective-C BookmarkItem class instead of using opaque 'id's. This allows all the C++ BookmarkNode calls to be collected into one source file. It will also in the future allow creating fake collections of bookmarks, necessary for the Recents and Search features.

Also some refactoring of the drag/clipboard code, which now uses a static array instead of an instance variable to hold dragged items; this will be necessary to handle moves between trees (coming in the next checkin.)

Minor xib changes: Shorten URLs in the middle not at the end, and remove borders of table/outline views.

BUG=32080
TEST=Added BookmarkItemTest, modified existing unit tests.

Review URL: http://codereview.chromium.org/551013
------------------------------------------------------------------------
r36193 | xiyuan@chromium.org | 2010-01-14 00:53:48 +0100 (Thu, 14 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_win.cc

Ensure existing user pinned chrome shortcuts have correct app id.

On Win7, check if user has pinned chrome shortcuts and ensure they have correct app id.

BUG=28104
TEST=On Win7, install chrome prior 4.0.266.0 and pin chrome shortcut (browser with default profile, browser with non-default profile, web apps etc).  Then update to a version with this fix. After update, running chrome should not have duplicate icon spawned.

Review URL: http://codereview.chromium.org/548008
------------------------------------------------------------------------
r36182 | stuartmorgan@chromium.org | 2010-01-13 23:26:10 +0100 (Wed, 13 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/framework.order
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc
   M /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Fix clicking in QuickTime content on the Mac

QuickTime uses FindWindow in its click handling to get the WindowRef, so we need to interpose it to give back the plugin window (which isn't actually on screen). This makes clicks work except for the menu button in the control strip.

BUG=24952
TEST=Click/double-click in a QuickTime video to pause/play, or use the control strip (except for the menu button).

Review URL: http://codereview.chromium.org/536047
------------------------------------------------------------------------
r36181 | michaeln@chromium.org | 2010-01-13 23:14:46 +0100 (Wed, 13 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/webkit/appcache/appcache_service.h

Introduce a notification to trigger memory purging on the IO thread and use it in ChromeAppCacheService.

TEST=manual
BUG=none

Review URL: http://codereview.chromium.org/547016
------------------------------------------------------------------------
r36179 | jhawkins@chromium.org | 2010-01-13 23:08:28 +0100 (Wed, 13 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/autofill/autofill_dialog.h
   A /trunk/src/chrome/browser/autofill/autofill_dialog_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement a bare-bones AutoFill dialog for gtk.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/542045
------------------------------------------------------------------------
r36176 | akalin@chromium.org | 2010-01-13 22:51:11 +0100 (Wed, 13 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Draw background color (if necessary) for sync status and sync link.

Aligned left edges of sync status text and the relogin link text.

BUG=30159
TEST=manual testing

Review URL: http://codereview.chromium.org/542025
------------------------------------------------------------------------
r36164 | avi@chromium.org | 2010-01-13 21:47:47 +0100 (Wed, 13 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.h
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm
   M /trunk/src/chrome/browser/cocoa/menu_button.h
   M /trunk/src/chrome/browser/cocoa/menu_button.mm

Fix crash caused by having accessibility turned on.

BUG=http://crbug.com/31007
TEST=as in bug

Review URL: http://codereview.chromium.org/548015
------------------------------------------------------------------------
r36154 | thakis@chromium.org | 2010-01-13 20:42:49 +0100 (Wed, 13 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

Be more frugal with goats in these challenging economic times.

BUG=31482
TEST=Use chrome for some time. Fewer goats should appear in bearontheroof's place.

Review URL: http://codereview.chromium.org/543045
------------------------------------------------------------------------
r36146 | xiyuan@chromium.org | 2010-01-13 19:50:11 +0100 (Wed, 13 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/web_applications/web_app.cc

Update/repair legacy gears web app shortcuts

r34332 has a bug that web app data dir could be missing for legacy gears
shortcut. The fix is to make sure the data dir exists.

BUG=8539
TEST=Create a legacy gears web app shortcuts and then update to a version with this fix and launching chrome should update the shortcuts with new icon locations.

Review URL: http://codereview.chromium.org/551008
------------------------------------------------------------------------
r36137 | thakis@chromium.org | 2010-01-13 19:30:03 +0100 (Wed, 13 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/HungRendererDialog.xib
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Add favicons to hung renderer dialog.

Nib change: Changed data cell from NSFieldTextCell to NSButtonCell with checkbox style.

BUG=none
TEST=Go to wikipedia, cmd-click a couple links, enter "about:hang" in omnibox. After a while, the hung renderer dialog should show up and have a favicon for all the tabs you opened by cmd-clicking.

Review URL: http://codereview.chromium.org/545040
------------------------------------------------------------------------
r36125 | sky@chromium.org | 2010-01-13 18:01:03 +0100 (Wed, 13 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes regression in placement of new tab button.

BUG=32159
TEST=see bug
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/543043
------------------------------------------------------------------------
r36122 | pfeldman@chromium.org | 2010-01-13 17:22:34 +0100 (Wed, 13 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h

DevTools crash: DevToolsWindow::SetDocked(bool)
BUG=32035

Review URL: http://codereview.chromium.org/541046
------------------------------------------------------------------------
r36121 | sky@chromium.org | 2010-01-13 17:10:45 +0100 (Wed, 13 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Gets the loading theme bubble to work on views/gtk.

CROS_BUG=1080
TEST=install a theme on chrome os and make sure you get the
     'Loading...' bubble.

Review URL: http://codereview.chromium.org/543024
------------------------------------------------------------------------
r36119 | phajdan.jr@chromium.org | 2010-01-13 15:37:38 +0100 (Wed, 13 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/chrome_process_util.cc
   M /trunk/src/chrome/test/chrome_process_util.h
   D /trunk/src/chrome/test/chrome_process_util_linux.cc
   M /trunk/src/chrome/test/chrome_process_util_mac.cc
   M /trunk/src/chrome/test/chrome_process_util_uitest.cc
   D /trunk/src/chrome/test/chrome_process_util_win.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc

Make running chrome process detection in ui tests more reliable.

Also drops fragile code.

TEST=Covered by ui_tests.
BUG=10840

Review URL: http://codereview.chromium.org/545006
------------------------------------------------------------------------
r36115 | suzhe@chromium.org | 2010-01-13 11:41:56 +0100 (Wed, 13 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h

Fix issue: 32015: Keyboard shortcuts doesn't work when Devtool is docked

BUG=32015
TEST=Open devtool window and dock it into the browser window and move the focus into the devtool tab, then try if shortcut keys like ctrl-t are still work.

Review URL: http://codereview.chromium.org/542049
------------------------------------------------------------------------
r36114 | ukai@chromium.org | 2010-01-13 11:25:53 +0100 (Wed, 13 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc

Add LayoutTests/websocket/tests/worker support.

BUG=27618
TEST=none

Review URL: http://codereview.chromium.org/460106
------------------------------------------------------------------------
r36113 | abarth@chromium.org | 2010-01-13 10:30:22 +0100 (Wed, 13 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

Finish the plumbing for cookiesEnabled.

BUG=1850

Review URL: http://codereview.chromium.org/549005
------------------------------------------------------------------------
r36106 | rolandsteiner@chromium.org | 2010-01-13 07:39:56 +0100 (Wed, 13 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_util.cc

Fix by gdk (Garret Kelly)

Resolve issue 30641

Extension files were being selected for auto-open even though an install of the
extension was not requested. This patch changes this behaviour so that download
an extension (that's not explicitly requested as an extension install) does not
force an attempt to install it.

BUG=30641
TEST=Right-click an extension link and "Save Link As...". Download appears in shelf.

------------------------------------------------------------------------
r36105 | thestig@chromium.org | 2010-01-13 07:36:55 +0100 (Wed, 13 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h

Remove an unneeded forward declaration. (This is really a dummy commit to trigger the bots to test r36104.)

TBR=oshima
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/542051
------------------------------------------------------------------------
r36098 | jorlow@chromium.org | 2010-01-13 06:05:24 +0100 (Wed, 13 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ClearBrowsingData.xib
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adds "Delete Local Storage" option to "Clear Browsing Data" for Windows and GTK. 
NOTE: This change does not contain src/chrome/app/nibs/ClearBrowsingData.xib. It'll be edited by someone who knows about Mac. 

BUG=none 
TEST=The clear browser data dialog box should have a new option: Delete local storage"

Landing for Marcus
Original CL: http://codereview.chromium.org/524026

Review URL: http://codereview.chromium.org/542048
------------------------------------------------------------------------
r36096 | thakis@chromium.org | 2010-01-13 05:55:06 +0100 (Wed, 13 Jan 2010) | 20 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

Mac: UI tweaks for task manager.

Nib change: Reduce row height, make scrollbars smaller.

Make text in task manager table slightly smaller.

Show in decimal digit for %cpu.

Show memory in KB/MB, not always in K.

Change update frequency from 1s to 2s to match Activity Monitor's default.

(all mac-only. ui team is fine with this.)

Finally, turn taskman on.

BUG=13156
TEST=Open task manager, look at it. Should look & feel similar to Activity Monitor.

Review URL: http://codereview.chromium.org/536038
------------------------------------------------------------------------
r36087 | thakis@chromium.org | 2010-01-13 04:26:13 +0100 (Wed, 13 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.h
   A /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache.mm
   A /trunk/src/chrome/browser/cocoa/table_row_nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_mac.mm

Mac: Add favicons to task manager.

Pull NSImage cache out of search engine dialog into its own class, reuse that.

Implement browser icon code in task_manager_resource_provider's browser resource provider.

BUG=13156
TEST=Open task manager. You should see icons. Open search engine manager, should still show icons.

Review URL: http://codereview.chromium.org/549021
------------------------------------------------------------------------
r36086 | tony@chromium.org | 2010-01-13 04:25:09 +0100 (Wed, 13 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

re-enable ErrorPage UI tests.

They are fixed now and can be re-enabled.

BUG=32125

TBR=johnnyg

Review URL: http://codereview.chromium.org/542047
------------------------------------------------------------------------
r36076 | tim@chromium.org | 2010-01-13 01:55:39 +0100 (Wed, 13 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc

Show the sync login dialog in response to NTP sync link being clicked when the sync
service is showing an INVALID_GAIA_CREDENTIALS or CAPTCHA_REQUIRED auth error,
instead of just showing the 'Synced to ...' yellowbox.

BUG=32116
TEST=manually generated auth error, observed NTP sync error, clicked re-login link,
observed login dialog opened.

Review URL: http://codereview.chromium.org/541038
------------------------------------------------------------------------
r36075 | brettw@chromium.org | 2010-01-13 01:55:37 +0100 (Wed, 13 Jan 2010) | 28 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/dummy_main_functions.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   A /trunk/src/chrome/browser/gpu_process_host.cc
   A /trunk/src/chrome/browser/gpu_process_host.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   A /trunk/src/chrome/browser/renderer_host/backing_store_glx.h
   A /trunk/src/chrome/browser/renderer_host/backing_store_mac.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   A /trunk/src/chrome/browser/renderer_host/backing_store_proxy.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_proxy.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_win.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_x.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   A /trunk/src/chrome/browser/renderer_host/gpu_view_host_win.cc
   A /trunk/src/chrome/browser/renderer_host/gpu_view_host_win.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   A /trunk/src/chrome/browser/renderer_host/test/test_backing_store.cc
   A /trunk/src/chrome/browser/renderer_host/test/test_backing_store.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_common.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/gpu_messages.h
   A /trunk/src/chrome/common/gpu_messages_internal.h
   A /trunk/src/chrome/gpu
   A /trunk/src/chrome/gpu/gpu_backing_store.cc
   A /trunk/src/chrome/gpu/gpu_backing_store.h
   A /trunk/src/chrome/gpu/gpu_main.cc
   A /trunk/src/chrome/gpu/gpu_process.cc
   A /trunk/src/chrome/gpu/gpu_process.h
   A /trunk/src/chrome/gpu/gpu_thread.cc
   A /trunk/src/chrome/gpu/gpu_thread.h
   A /trunk/src/chrome/gpu/gpu_view_win.cc
   A /trunk/src/chrome/gpu/gpu_view_win.h
   M /trunk/src/ipc/ipc_message_utils.h

Add the ability for the GPU process to be used to paint the backing store of a
tab. This is the first pass and is currently a bit buggy and incomplete.

This patch refactors the backing store to make it a virtual interface which is
then implemented by the platform-specific backing stores. This cleans up the
multi-platform aspects of the old code, and also makes it possible to create
different backing stores (such as ones in another process).

This renames the BackingStore::PaintRect function to PaintToBackingStore which
clears up what it does. I would often get confused and think that it paints
the backing store to the screen.

This makes a common way to capture backing store information and adds it to the
backing store API. This removed a bunch of ugly ifdefs.

This adds the ability for a backing store to specify that the TransportDIB
should not be freed by RenderWidgetHost when painting is complete. This is
necessary since the out-of-process version needs to use it after the
RenderWidget paint function has returned.

This pushes up the vector of copy_rect from RenderWidgetHost to the actual
BackingStores. This prevents us from sending duplicate data over IPC. It also
makes the common non-IPC case more efficient, since we end up setting up various
surfaces only once when there are multiple update rects.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/523028
------------------------------------------------------------------------
r36069 | johnnyg@chromium.org | 2010-01-13 01:22:24 +0100 (Wed, 13 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/media/audio-controls-rendering-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/media/audio-controls-rendering-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/media/video-poster-scale-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/media/video-poster-scale-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/audio-controls-rendering-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/audio-controls-rendering-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/video-poster-scale-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/video-poster-scale-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/media/video-poster-scale-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/media/audio-controls-rendering-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/media/audio-controls-rendering-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/media/video-poster-scale-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/media/video-poster-scale-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/media/video-poster-scale-expected.txt

Webkit update to 53151.

TBR=atwilson
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/546020
------------------------------------------------------------------------
r36060 | jamesr@chromium.org | 2010-01-13 00:42:10 +0100 (Wed, 13 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Enables the javascript memory column in the task manager in Linux

Review URL: http://codereview.chromium.org/543019
------------------------------------------------------------------------
r36058 | sky@chromium.org | 2010-01-13 00:17:01 +0100 (Wed, 13 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Makes the new tab button extend to the top of the tab strip on chromeos.

CROS_BUG=310
TEST=see bug

Review URL: http://codereview.chromium.org/550020
------------------------------------------------------------------------
r36056 | albertb@google.com | 2010-01-12 23:27:57 +0100 (Tue, 12 Jan 2010) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/glue/preference_change_processor.cc
   A /trunk/src/chrome/browser/sync/glue/preference_change_processor.h
   A /trunk/src/chrome/browser/sync/glue/preference_model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/preference_model_associator.h
   M /trunk/src/chrome/chrome_browser.gypi

Change processor and model associator for preferences.

Review URL: http://codereview.chromium.org/437028
------------------------------------------------------------------------
r36055 | mark@chromium.org | 2010-01-12 23:10:29 +0100 (Tue, 12 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Cocoa bookmarks manager and autocomplete text field editor: in the 10.6 SDK,
delegates implement protocols, and -delegate methods no longer return type
|id|.  Add casts as needed.

BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/550022
------------------------------------------------------------------------
r36045 | jcampan@chromium.org | 2010-01-12 22:31:13 +0100 (Tue, 12 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Moving the CLD code to the renderer so it runs sanboxed.

BUG=
TEST=Run the unit-tests.

Review URL: http://codereview.chromium.org/541013
------------------------------------------------------------------------
r36037 | ananta@chromium.org | 2010-01-12 21:38:49 +0100 (Tue, 12 Jan 2010) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.cc
   A /trunk/src/chrome/browser/views/unhandled_keyboard_event_handler.h
   M /trunk/src/chrome/chrome_browser.gypi

Unhandled keyboard messages coming back from the host browser running ChromeFrame need to process
accelerators. Currently accelerators are processed by the focus manager. We already have code in browser_view
to process unhandled keyboard messages coming back from the renderer. Moved this code to a new class
UnhandledKeyboardEventHandler which maintains state about whether the next character event has to be ignored, etc.

This class is now used by BrowserView and the ExternalTabContainer to process unhandled keyboard messages.

To support accelerators in ChromeFrame, the ExternalTabContainer needs to implement an Accelerator target. I also
added a minimal accelerator table for Chromeframe in the chrome_dll.rc and chrome_dll_resource.h files. 

This fixes bug http://code.google.com/p/chromium/issues/detail?id=31672

Bug=31672

Review URL: http://codereview.chromium.org/536023
------------------------------------------------------------------------
r36036 | erg@chromium.org | 2010-01-12 21:38:41 +0100 (Tue, 12 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Speculative fix for the windows theme crasher.

I have no good ideas about this, so I'm moving the theme building to the
UI thread to remove the possibility of clobbering the memory of the
Task*. If THAT doesn't work, I've tried to get the theme name into the
stack trace and therefore the minidumps.

BUG=31719
TEST=none

Review URL: http://codereview.chromium.org/536024
------------------------------------------------------------------------
r36032 | sky@chromium.org | 2010-01-12 20:49:56 +0100 (Tue, 12 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc

Fixes crash in dragging a tab out in overview mode. This regression
was introduced when adding the views/gtk support. As we don't need
non-views/gtk support anymore, I'm nuking the defines in this file.

BUG=32057
TEST=see bug

Review URL: http://codereview.chromium.org/546019
------------------------------------------------------------------------
r36030 | jhawkins@chromium.org | 2010-01-12 20:41:27 +0100 (Tue, 12 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/autofill_dialog.h

Add the AutoFillDialog header, needed by the cross-platform implementations to implement the autofill dialog.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549014
------------------------------------------------------------------------
r36021 | andybons@chromium.org | 2010-01-12 19:12:51 +0100 (Tue, 12 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   A /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h
   A /trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm
   M /trunk/src/chrome/chrome_browser.gypi

[Mac] Implements context menus for Page and Browser Actions. Introduces a reusable subclass of NSMenu that is used by both.

BUG=30655
TEST=Right click on any Page action or Browser Action, observe a context menu appears.
Review URL: http://codereview.chromium.org/525098
------------------------------------------------------------------------
r36020 | thakis@chromium.org | 2010-01-12 19:12:22 +0100 (Tue, 12 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

Mac: Tell task manager model to stop updating when the task manager window is closed.

Also change how the controller is deallocated, which should fix a valgrind bug.

Nib change: Make TaskManagerWindowController the delegate of the window in the nib, so that its windowWillClose: gets called.

TFR=trungl

BUG=13156,30398
TEST=Open Activity Monitor, look at browser %cpu. Open chrome's task manager, note %cpu goes up slightly. Close task manager again, %cpu should go down again. Open task manager again, should still work.

Review URL: http://codereview.chromium.org/536026
------------------------------------------------------------------------
r36019 | asargent@chromium.org | 2010-01-12 19:06:44 +0100 (Tue, 12 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Fix a crash with application mode windows and extensions tab API.

From an application mode window, if you call chrome.tabs.create and specify a
index for the new tab (and had no other windows open), chrome will crash.

BUG=29810
TEST=Crash should no longer happen when following steps in the bug report.


Review URL: http://codereview.chromium.org/542018
------------------------------------------------------------------------
r36016 | stuartmorgan@chromium.org | 2010-01-12 17:58:22 +0100 (Tue, 12 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Support pinch to zoom on the Mac

BUG=16305
TEST=Pinch on a multi-touch-capable trackpad; page should zoom in or out.

Review URL: http://codereview.chromium.org/545020
------------------------------------------------------------------------
r36015 | jochen@chromium.org | 2010-01-12 17:57:12 +0100 (Tue, 12 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/test/data/blacklist_small.pbl
   M /trunk/src/chrome/test/data/blacklist_small.pbr

Take filter exceptions into account when matching against resource requests.

BUG=16932
TEST=BlacklistTest.Generic

Review URL: http://codereview.chromium.org/541025
------------------------------------------------------------------------
r36013 | jochen@chromium.org | 2010-01-12 17:31:00 +0100 (Tue, 12 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/test/data/blacklist_small.pbl
   M /trunk/src/chrome/test/data/blacklist_small.pbr

Also match against the query string if present.

BUG=none
TEST=BlacklistTest.QueryStringMatch

Review URL: http://codereview.chromium.org/523137
------------------------------------------------------------------------
r36012 | sky@chromium.org | 2010-01-12 17:26:56 +0100 (Tue, 12 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h

Fixes bug where app menu would get stuck if user clicked and
dragged. This was happening because the renderer would think we were
doing a drag operation. We need to tell the renderer to end the drag,
otherwise the renderer thinks the drag operation is ongoing.

BUG=31259
TEST=see bug

Review URL: http://codereview.chromium.org/548006
------------------------------------------------------------------------
r36004 | tkent@chromium.org | 2010-01-12 12:49:14 +0100 (Tue, 12 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc

Mark the following tests FLAKY on Windows.
- NPAPITester.NoHangIfInitCrashes
- MetricsServiceTest.CrashRenderers
- ResourceDispatcherTest.CrossSiteAfterCrash
- RendererCrashTest.Crash

BUG=32048
TEST=none
TBR=jar, nsylvain
Review URL: http://codereview.chromium.org/548009
------------------------------------------------------------------------
r35999 | jochen@chromium.org | 2010-01-12 10:07:42 +0100 (Tue, 12 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.h
   M /trunk/src/chrome/test/data/blacklist_small.pbr

Introduce exception filter rules.

Allow for patterns to start with a - to mark exceptions. A URL matches a
filter, if it matches at least one pattern and no exception.

BUG=16932
TEST=covered by unit_tests

Review URL: http://codereview.chromium.org/541009
------------------------------------------------------------------------
r35997 | tony@chromium.org | 2010-01-12 09:01:44 +0100 (Tue, 12 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/test/testing_profile.h

Revert "Take 2: Preload the visited link db on the file thread if"

This reverts commit r35991 due to a perf regression to New Tab Cold
on Mac.

TBR=thakis

Review URL: http://codereview.chromium.org/545024
------------------------------------------------------------------------
r35992 | xiyuan@chromium.org | 2010-01-12 05:08:15 +0100 (Tue, 12 Jan 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/user_data_manager.cc

Fix Win7 issues for non-default profile:

- Fix case A reported by Satoshi.Matsuzaki where a 2nd icon is created
  on launching chromium in non-default profile. This is because the
  shortcuts for non-default profile is created with wrong app id. The
  old use uses user data dir to generate the app id while the
  GetChromiumAppId expects profile path;
- Fix an issue in jump list for non-default profile where the
  recently close/most visted pages are always opened in the default
  profile because the underlying shortcuts does not have the correct
  user-data-dir arguments.

BUG=30414
TEST=Verify case A of Satoshi's comments @5 is fixed; Verify the jump list items are opened with correct profile;

Review URL: http://codereview.chromium.org/547011
------------------------------------------------------------------------
r35991 | tony@chromium.org | 2010-01-12 04:39:53 +0100 (Tue, 12 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/test/testing_profile.h

Take 2: Preload the visited link db on the file thread if
the file exists. Otherwise, just load like normal on the UI thread.

This failed before because the browser may have shutdown before the
posted task ran.  When the posted task finally runs, it tried to
use the profile, but the profile was already deleted.  Make a small
change to VisitedLinkMaster so GetDatabaseFileName no longer depends
on the profile.

BUG=24163

Review URL: http://codereview.chromium.org/507047
------------------------------------------------------------------------
r35989 | rafaelw@chromium.org | 2010-01-12 03:17:02 +0100 (Tue, 12 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.cc
   A /trunk/src/chrome/browser/gtk/extension_installed_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

Implement Linux/GTK ExtensionInstalledBubble

BUG=26973
TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.

Review URL: http://codereview.chromium.org/547010
------------------------------------------------------------------------
r35988 | akalin@chromium.org | 2010-01-12 03:09:24 +0100 (Tue, 12 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Added link control to sync preferences UI, which is shown when there
is a sync authentication error.

Changed sync group's layout behavior to VerticalToFit and added explanatory comment.

BUG=30159
TEST=tested with sync disabled, sync enabled, induced sync error, made sure UI looks right

Review URL: http://codereview.chromium.org/501101
------------------------------------------------------------------------
r35977 | thakis@chromium.org | 2010-01-12 01:39:15 +0100 (Tue, 12 Jan 2010) | 28 lines
Changed paths:
   M /trunk/src/base/base.gypi
   A /trunk/src/base/mach_ipc_mac.h (from /trunk/src/chrome/common/mach_ipc_mac.h:35891)
   A /trunk/src/base/mach_ipc_mac.mm (from /trunk/src/chrome/common/mach_ipc_mac.mm:35891)
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/mach_broker_mac.cc
   M /trunk/src/chrome/browser/mach_broker_mac.h
   D /trunk/src/chrome/common/mach_ipc_mac.h
   D /trunk/src/chrome/common/mach_ipc_mac.mm

Mac: Other approach for IPCing child task_ts.

Also move mach_ipc_mac to base, where it's now used.

Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , but uses a named connection instead. Do the IPC right after fork-time, so that the sandbox is not yet in effect.

See the codereview comments for a benchmark that proves that this shouldn't be expensive, and for pros and cons for using a named connection vs temporarily switching out the bootstrap port.

Works for worker processes too and seems more reliable in general.

Measured perf impact in http://src.chromium.org/viewvc/chrome?view=rev&revision=35888 , it's negligible.

BUG=13156
TEST=(requires that one enables the task manager in browser.cc)
1.) Open one tab that plays a youtube video
2.) Open a second and visit http://www.whatwg.org/demos/workers/primes/page.html
3.) Install e.g. the gmail checker extension
4.) Open the task manager
It should report metrics for
* one browser process
* two renderer processes
* one plugin process
* one worker process
* one extension process
Check that %cpu etc more or less match what Activity Monitor displays if you filter for "Chromium".
Also choose "Open all bookmarks" on the bookmarks bar with the task manager open and check that metrics for all tabs appear immediately.

Review URL: http://codereview.chromium.org/549002
------------------------------------------------------------------------
r35974 | sky@chromium.org | 2010-01-12 01:12:14 +0100 (Tue, 12 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Fixes bug in background tabs not getting sized correctly. The bug
turned out to be that TabContentsView::GetContainerBounds() was
returning the actual bounds, not the requested bounds, which are not
always the same. We need to return the requested bounds from this
call, otherwise bad things happen.

BUG=31132
TEST=see bug

Review URL: http://codereview.chromium.org/549009
------------------------------------------------------------------------
r35972 | sky@chromium.org | 2010-01-12 00:54:45 +0100 (Tue, 12 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc

Lands 536001 for bryenug:

Add Cut/Copy/Paste items to the bookmark bar menu.

Also, removes Remove. This is a Linux only change.

BUG=25640
TEST=manually

Review URL: http://codereview.chromium.org/545015
------------------------------------------------------------------------
r35967 | sky@chromium.org | 2010-01-12 00:16:58 +0100 (Tue, 12 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/chromeos/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/mount_library.h
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   M /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/resources/filebrowse.html

Lands http://codereview.chromium.org/505031 for dhg:

Browser should pop up status when usb is inserted.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/547009
------------------------------------------------------------------------
r35965 | viettrungluu@chromium.org | 2010-01-12 00:12:55 +0100 (Tue, 12 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Mac: don't scale theme overlay image.

BUG=27214
TEST=Install Porsche theme. Change the window size. The silhouette of the Porsche should stay the same size (and not be stretche), remain the same absolute distance from the left, and be clipped off (and not shown) when the window is too narrow. Compare the behaviour on Windows.

Review URL: http://codereview.chromium.org/545018
------------------------------------------------------------------------
r35964 | munjal@chromium.org | 2010-01-12 00:10:55 +0100 (Tue, 12 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/app/tree_model.h
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h

Use string16 instead of wstring in bookmark data model.
Add overloads to bookmark model for string16. Wrap wstring
versions in #if !defined since string16 is just a typedef of
wstring on windows.

TEST=exist
BUG=32013

Review URL: http://codereview.chromium.org/536013
------------------------------------------------------------------------
r35963 | mattm@chromium.org | 2010-01-12 00:09:22 +0100 (Tue, 12 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Correct the URL loaded when proxy config binary couldn't be found.

Thanks to wrar42 for pointing it out.

BUG=30657
TEST=set nonexistant PATH, run chrome, try to open proxy configuration

Review URL: http://codereview.chromium.org/541014
------------------------------------------------------------------------
r35959 | feldstein@chromium.org | 2010-01-11 23:53:46 +0100 (Mon, 11 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm

Fix mis-sized download shelf close button

In an earlier checkin I had removed the images from the IB files that used HoverCloseButtons, relying on them to be set programmatically.  It seems that this causes a flaky sizing problem when loading from a NIB, which only manifested in the DownloadShelf for some reason.

Also change DownloadShelf.xib so that the close button is a child of the main view, not of the GTMWidthTweaker, which seems to eat redraw messages.

BUG=31785
TEST=Try out the download shelf a few times.  You need to quit the whole app a few times to ensure it doesn't come back.

Review URL: http://codereview.chromium.org/540001
------------------------------------------------------------------------
r35951 | skerner@chromium.org | 2010-01-11 23:40:34 +0100 (Mon, 11 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

If a backing store is not available, chrome.tabs.captureVisibleTab() asks the renderer for a snapshot of the page.

BUG=19274
TEST=Manual testing on Mac,Linux,Win
Review URL: http://codereview.chromium.org/502034
------------------------------------------------------------------------
r35950 | pinkerton@chromium.org | 2010-01-11 23:27:03 +0100 (Mon, 11 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm

Display folder icons for folder items in the menu and submenus.
BUG=26947
TEST=bookmark menu should behave normally but folders should now have icons too.
------------------------------------------------------------------------
r35949 | snej@chromium.org | 2010-01-11 23:21:22 +0100 (Mon, 11 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm

Implemented bookmark manager context menus.
BUG=31857
TEST=none

Mike Pinkerton recommended I use the cross-platform menu utilities for this; I decided not to do that yet, in this patch, for a few reasons:
(1) I'm in the midst of doing heavy refactoring of the tree/list controller classes in a local branch, so anything I do now would have to get changed a lot in that branch anyway.
(2) The Windows and GTK bookmark managers don't use them, so there's not existing common code to hook into. This means I'd have to write all that code, and presumably retrofit the other platform managers to use it. But we really want to get this patch into the upcoming (tonight?) dev-channel build to avoid user confusion.

I have not added a menu to the nib. I've added code to BookmarkManagerController to create the NSMenu programmatically. I can switch to the cross-platform utilities after my refactoring.

Another note: Yes, there is some duplication of code between the Groups and Tree controller classes. I'm not worrying about this because the Groups controller class is going away completely in my refactoring, so it only has a few more days to live. :-)

Review URL: http://codereview.chromium.org/549010
------------------------------------------------------------------------
r35943 | mbelshe@google.com | 2010-01-11 22:34:46 +0100 (Mon, 11 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/net/flip/flip_network_transaction_unittest.cc
   M /trunk/src/net/flip/flip_session.cc
   M /trunk/src/net/http/http_response_info.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Enable JS detection of whether SPDY was used to load a web page.
Augments the loadTimes() API with a new field, "wasFetchedViaSpdy".

BUG=31615
TEST=flip_network_transaction_unittest


Review URL: http://codereview.chromium.org/518039
------------------------------------------------------------------------
r35938 | aa@chromium.org | 2010-01-11 21:42:31 +0100 (Mon, 11 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Fix a bug where we don't recognize user script declarations
if they aren't at the beginning of a line. Greasemonkey
allows this.

BUG=31076
TEST=Install http://userscripts.org/scripts/review/29876. The
install dialog should say 'Sans-serif default', not
29876.user.js.

Review URL: http://codereview.chromium.org/545002
------------------------------------------------------------------------
r35935 | phajdan.jr@chromium.org | 2010-01-11 21:35:09 +0100 (Mon, 11 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Prevent a crash and add debugging code for cases where things go wrong
when trying to unload a half-crashed extension.

TEST=none
BUG=30405

Review URL: http://codereview.chromium.org/523163
------------------------------------------------------------------------
r35933 | jhawkins@chromium.org | 2010-01-11 21:13:45 +0100 (Mon, 11 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h

Resolve issue 22731

The RenderViewHost for the TabContents of a DraggedGtkTab was changing,
and the dragged tab was using the backing store associated with the invalidated
RenderViewHost.

BUG=22731
TEST=See issue description

Patch from Garret Kelly <gdk@chromium.org>
Review URL: http://codereview.chromium.org/550002
------------------------------------------------------------------------
r35932 | akalin@chromium.org | 2010-01-11 21:08:35 +0100 (Mon, 11 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h

Made GaiaAuth use Chrome threads instead of libjingle threads.

This partially solves the issue in 30721, as it makes sure that
there is a Chrome message loop for the SSL socket adapter on
OS X/Linux.  However, although it has stopped crashing, gaia
authentication still times out.

Renamed GaiaAuth::WorkerThread to GaiaAuth::WorkerTask and cleaned
it up.

BUG=30721
TEST=manual

Review URL: http://codereview.chromium.org/542003
------------------------------------------------------------------------
r35930 | mark@chromium.org | 2010-01-11 20:53:48 +0100 (Mon, 11 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Cocoa bookmarks manager fixes:
 - -[NSTableView selectRow:byExtendingSelection:] was deprecated in 10.3 and
   is superseded by -[NSTableView selectRowIndexes:byExtendingSelection:].
 - -[BookmarkGroupsController tableView:shouldEditTableColumn:row:] must be
   declared in an @interface if it is to be called.
 - In BookmarksOutlineView, -[NSOutlineView delegate]'s
   id<NSOutlineViewDelegate> must be cast to BookmarkTreeController* before
   using as a BookmarkTreeController*.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549008
------------------------------------------------------------------------
r35929 | oshima@chromium.org | 2010-01-11 20:48:52 +0100 (Mon, 11 Jan 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar.h
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc (from /trunk/src/chrome/browser/chromeos/compact_location_bar.cc:35921)
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h (from /trunk/src/chrome/browser/chromeos/compact_location_bar.h:35921)
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome_browser.gypi

Use dropdown bar for compact location bar.
 * Refactored CompactLocationBar to Host/View to use DropdownBarHost/View.
 * Changed the logic to show/hide. Per cole's request, losing focus now hides the location bar.
Following features are not implemented yet.
 * Window cripping while animating.
 * Adjust location when toolbar is shown (it's always under tab)
 * clipping autocomplete dropdown.

Timer code is no longer used right now, but is left intentionally as we may put it back.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35674

Review URL: http://codereview.chromium.org/525018
------------------------------------------------------------------------
r35923 | eroman@chromium.org | 2010-01-11 20:13:08 +0100 (Mon, 11 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/host_cache.h
   M /trunk/src/net/base/host_cache_unittest.cc

Clear the host cache when closing the last incognito window.
This avoids retaining navigation history relating to the incognito window.

I piggy-back off of the dns prefetcher's OffTheRecordObserver to do this. In the future I hope to have a separate host resolver for off the record mode, so this won't be necessary.

BUG=24629

Review URL: http://codereview.chromium.org/523076
------------------------------------------------------------------------
r35917 | jhawkins@chromium.org | 2010-01-11 19:49:40 +0100 (Mon, 11 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add two AutoFill prefs.  autofill.infobar_shown is true if the autofill infobar has been shown to the user.  autofill.enabled is true if the user has accepted the autofill confirmation infobar.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/541001
------------------------------------------------------------------------
r35908 | jshin@chromium.org | 2010-01-11 18:34:42 +0100 (Mon, 11 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/resources/downloads.html

1. Increase the width for 'date-container' in download.html to 110px to make room for dates in some languages. Increase the margin-left (LTR) and margin-rigth(RTL) accordingly. 

2. Decrease the web font size (dom UI font size) for Bengali on Vista or later to 84% (the same value as used for English) while using 110% for XP. This is done by introducing a new 'string' (IDS_WEB_FONT_SIZE_XP) on Windows (other platforms won't get this). 


BUG=21699
TEST=Run Chrome with '--lang=ml' (--lang=kn, --lang=bn) on Windows and go to the download page. Make sure that dates are in a single line. 


Review URL: http://codereview.chromium.org/381009
------------------------------------------------------------------------
r35906 | andybons@chromium.org | 2010-01-11 17:47:39 +0100 (Mon, 11 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm

[Mac] Fixes regression where the I-Beam was not being shown when hovering over the Omnibox while it was out of focus.

BUG=31449
TEST=Hover over the omnibox when it is out of focus (but the app is in focus). Observe that the I-Beam is shown instead of the arrow cursor.
Review URL: http://codereview.chromium.org/544007
------------------------------------------------------------------------
r35905 | sky@chromium.org | 2010-01-11 17:29:39 +0100 (Mon, 11 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Fixes two fullscreen bugs on views/gtk:

. On X changing fullscreen is asynchronous. This means we have to ask
  the window to change it's fullscreen state, then once changed update
  the necessary things.
. ExtensionShelf is needlessly triggering a bunch of layouts when we
  toggle fullscreen state.

BUG=31143
TEST=see bug

Review URL: http://codereview.chromium.org/542001
------------------------------------------------------------------------
r35902 | suzhe@chromium.org | 2010-01-11 05:22:01 +0100 (Mon, 11 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h

Implement HandleKeyboardEvent() method in HtmlDialog implementations.

To send unhandled keyboard events to the system default handler, so that system accelerators can work as normal.

BUG=30707: Keyboard shortcuts failed to work on Bookmark sync Sign in Authentication dialog
TEST=See bug report.

Review URL: http://codereview.chromium.org/525112
------------------------------------------------------------------------
r35901 | sky@chromium.org | 2010-01-11 05:21:22 +0100 (Mon, 11 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Fixes regression where bookmark bar context menu wouldn't show when
clicking on the bookmark bar. The regression is the result of
introducing AccessibleToolbarView as a superclass of BookmarkBarView
and having it override ShowContextMenu.

BUG=none
TEST=right click on an empty spot of the bookmark bar and make sure
you get a context menu.

Review URL: http://codereview.chromium.org/544001
------------------------------------------------------------------------
r35890 | thakis@chromium.org | 2010-01-10 07:48:18 +0100 (Sun, 10 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc

Revert 35888 - Mac: Other approach for IPCing child task_ts.

Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality.

Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.

Next try: Submitting to get perf numbers, will revert.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883

Review URL: http://codereview.chromium.org/549002

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/536009
------------------------------------------------------------------------
r35888 | thakis@chromium.org | 2010-01-10 06:23:49 +0100 (Sun, 10 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc

Mac: Other approach for IPCing child task_ts.

Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality.

Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.

Next try: Submitting to get perf numbers, will revert.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883

Review URL: http://codereview.chromium.org/549002
------------------------------------------------------------------------
r35884 | thakis@chromium.org | 2010-01-10 04:51:15 +0100 (Sun, 10 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/browser.cc

Revert 35883 - Mac: Other approach for IPCing child task_ts.

Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality.

Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.

Submitting to get perf numbers, will revert.

Review URL: http://codereview.chromium.org/549002

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/544004
------------------------------------------------------------------------
r35883 | thakis@chromium.org | 2010-01-10 04:44:46 +0100 (Sun, 10 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/browser.cc

Mac: Other approach for IPCing child task_ts.

Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality.

Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.

Submitting to get perf numbers, will revert.

Review URL: http://codereview.chromium.org/549002
------------------------------------------------------------------------
r35879 | nick@chromium.org | 2010-01-09 23:56:12 +0100 (Sat, 09 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

EntryKernel: change from assignable refs to puts.

Make EntryKernel have only private data members.

When we switch to protobuf based storage, we'll need to use getters and
setters.

BUG=30041
TEST=unit tests

Review URL: http://codereview.chromium.org/500113
------------------------------------------------------------------------
r35864 | tyoshino@google.com | 2010-01-09 04:40:49 +0100 (Sat, 09 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_browsertest.cc

Disable TaskManagerBrowserTest.NoticeExtensionChanges on XP until it is stable.

TaskManagerBrowserTest.NoticeExtensionChanges is crashing occasionally on XP.

BUG=31663
TBR=japhet,lzheng

Review URL: http://codereview.chromium.org/536007
------------------------------------------------------------------------
r35862 | derat@chromium.org | 2010-01-09 02:44:57 +0100 (Sat, 09 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Update Chrome OS build to support panel-dragging change.

The window manager side of this change (already committed) is
described at http://codereview.chromium.org/527005.  This
change also makes Chrome report the version of the IPC messages
that it's using to the window manager at startup.

TEST=built and tested that panel-dragging works as expected
BUG=none

Review URL: http://codereview.chromium.org/521070
------------------------------------------------------------------------
r35859 | evan@chromium.org | 2010-01-09 02:24:46 +0100 (Sat, 09 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

linux: prompt before overwriting a file in downloads

We rename implicit downloads so they don't conflict with existing
files, but we should prompt if you manually type in an existing
filename.

BUG=26117

Review URL: http://codereview.chromium.org/537005
------------------------------------------------------------------------
r35858 | oshima@chromium.org | 2010-01-09 02:16:57 +0100 (Sat, 09 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi

official build and buildbots are now chromeos=1
valgrind bots are up (they're still red tho).
I believe it's ready to check this in.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/487003
------------------------------------------------------------------------
r35855 | evan@chromium.org | 2010-01-09 01:52:19 +0100 (Sat, 09 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

linux: set a minimum size for dialogs based on locale resources

GTK dialogs size to their contents, but sometimes the title is the
longest string available.

BUG=28024

Review URL: http://codereview.chromium.org/534006
------------------------------------------------------------------------
r35853 | oshima@chromium.org | 2010-01-09 01:28:30 +0100 (Sat, 09 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/theme_background.cc

Don't theme app/popup window

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/535005
------------------------------------------------------------------------
r35852 | jshin@chromium.org | 2010-01-09 01:15:57 +0100 (Sat, 09 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Fix build error. 


------------------------------------------------------------------------
r35851 | jshin@chromium.org | 2010-01-09 01:03:15 +0100 (Sat, 09 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/resources/about_plugins.html

Make about:plugin page get rendered properly in Hebrew and Arabic Chrome. Also make it use the same font as other 'domUI' pages.

While doing so, get rid of some unnecessary string conversions in browser_about_handler.cc

BUG=31782
TEST=Run Chrome with --lang=ar / --lang=he on Windows (or LANGUAGE=ar or LANGUAGE=he on Linux) and go to 'about:plugins' page. The page should be properly 'RTLized'.


Review URL: http://codereview.chromium.org/523153
------------------------------------------------------------------------
r35850 | sky@chromium.org | 2010-01-09 00:57:41 +0100 (Sat, 09 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore.cc

Changes synchronous session restore to create windows after nested
message loop returns. The problem with the old approach was we created
a bunch of windows than exited the nested message loop. But because
exit isn't processed immediately it meant someone could also ask for
the nested loop to be exited and then you're hosed (one nested message
loop still running).

BUG=22878
TEST=none

Review URL: http://codereview.chromium.org/519090
------------------------------------------------------------------------
r35843 | mpcomplete@chromium.org | 2010-01-09 00:14:12 +0100 (Sat, 09 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/page.js
   M /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/test.html
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/background.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/good/Preferences
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Move the extension messaging tests to be ExtensionApiTests. Remove the old
tests.

Review URL: http://codereview.chromium.org/519087
------------------------------------------------------------------------
r35840 | rsesek@chromium.org | 2010-01-09 00:05:43 +0100 (Sat, 09 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

Switch GTK's cookie_view_unittest.cc to use the TestingProfile's new Create/GetRequestContext()

BUG=None
TEST=Unit tests

Review URL: http://codereview.chromium.org/529003
------------------------------------------------------------------------
r35836 | asargent@chromium.org | 2010-01-09 00:00:27 +0100 (Sat, 09 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Re-enable ExtensionBrowserTest.AutoUpdate on non-linux platforms.

BUG=31737
TEST=(this is re-enabling a test on win/mac)

Review URL: http://codereview.chromium.org/537001
------------------------------------------------------------------------
r35831 | sky@chromium.org | 2010-01-08 22:42:51 +0100 (Fri, 08 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fixes bug in RenderWidgetHostViewGtk that occurs if during paint
obtaining the backing store triggers a scroll.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/523155
------------------------------------------------------------------------
r35828 | oshima@chromium.org | 2010-01-08 22:39:15 +0100 (Fri, 08 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   A /trunk/src/chrome/browser/views/theme_background.cc
   A /trunk/src/chrome/browser/views/theme_background.h
   M /trunk/src/chrome/chrome_browser.gypi

ThemeBackground class.
 This simplifies the background painting of components on the frame  in various tab modes. Removed unused code in status_are_view, as it's always compiled with views now.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/517076
------------------------------------------------------------------------
r35826 | snej@chromium.org | 2010-01-08 22:38:24 +0100 (Fri, 08 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkManager.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_groups_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm

Bookmark Manager key-equivalent improvements

The changes to the xib are:
1. Autosave splitter position
2. Disable empty-selection in left table view, so it comes up with the first row
(bookmarks bar) selected
3. Wire up each table view as the other's nextKeyView.
4. Wire up right outline view as window's initialFirstResponder.

BUG=31844
TEST=none

Review URL: http://codereview.chromium.org/518089
------------------------------------------------------------------------
r35825 | sky@chromium.org | 2010-01-08 22:30:28 +0100 (Fri, 08 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc

Lands http://codereview.chromium.org/527033 for bryenug:

Allow URLs to be pasted as text.

BUG=31776
TEST=see bug

Review URL: http://codereview.chromium.org/529001
------------------------------------------------------------------------
r35822 | jhawkins@chromium.org | 2010-01-08 22:14:53 +0100 (Fri, 08 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/browser/autofill/name_field.cc
   M /trunk/src/chrome/browser/autofill/phone_field.cc

Fix a few pieces of the heuristic autofill:
* Escape a parenthesis.
* Add firstname, lastname to the regular expressions for first and last name fields.
* Compare the result of WebRegularExpression.match to -1 to mean not found.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/530006
------------------------------------------------------------------------
r35821 | akalin@chromium.org | 2010-01-08 21:51:14 +0100 (Fri, 08 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/app_menu_model.h
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm

Made MenuController handle dynamic labels.

Made AppMenuModel handle sync item dynamically.

BUG=31691
TEST=made sure wrench menu item dynamically updates sync menu item

Review URL: http://codereview.chromium.org/523147
------------------------------------------------------------------------
r35813 | cmasone@google.com | 2010-01-08 20:40:32 +0100 (Fri, 08 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos/ipc_message.h
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login_manager_view.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Changes to support communication with a privileged process

This change allows the chrome-login code to talk back to a privileged process and ask it to emit upstart signals and such.  Eventually, this IPC will be changed to use DBus, probably when cryptohomed lands.
Review URL: http://codereview.chromium.org/518086
------------------------------------------------------------------------
r35808 | jhawkins@chromium.org | 2010-01-08 20:12:58 +0100 (Fri, 08 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_field.cc
   M /trunk/src/chrome/browser/autofill/autofill_field.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h

Implement ImportFormData and GetPossibleFieldTypes for PersonalDataManager, used by the AutoFillManager.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/521067
------------------------------------------------------------------------
r35807 | pkasting@chromium.org | 2010-01-08 20:12:47 +0100 (Fri, 08 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/extensions/cross_origin_xhr_apitest.cc
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_history_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_javascript_url_apitest.cc
   M /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc
   M /trunk/src/chrome/browser/first_run.h
   A /trunk/src/chrome/browser/intranet_redirect_detector.cc
   A /trunk/src/chrome/browser/intranet_redirect_detector.h
   M /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/net/base/host_resolver_proc.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h

Add autodetection of "intranet" redirection, for ISPs etc. that send typos and nonexistent addresses to custom pages, and plumb it to the code that puts up infobars when users type in a search that appears to be an intranet address, so we don't show these for erroneous cases.

BUG=31556
TEST=none
Review URL: http://codereview.chromium.org/525079
------------------------------------------------------------------------
r35803 | oshima@chromium.org | 2010-01-08 19:35:54 +0100 (Fri, 08 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h

Simplified the api by replacing them with single Show(false) call and cleaned up linux/mac code.

BUG=22036
TEST=None

Review URL: http://codereview.chromium.org/523125
------------------------------------------------------------------------
r35801 | viettrungluu@chromium.org | 2010-01-08 19:26:19 +0100 (Fri, 08 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Mac: temporarily disable Full Screen and Task Manager.

We need to do it in Browser, since the new common menu code (for the App and
Page menus) doesn't look to the BrowserWindowController for their enabled
status.

BUG=31768
TEST=On Mac, make sure the Full Screen and Task Manager menu items are disabled in both the main menu and in the App and Page menus. On other platforms, make sure they still work as usual.

Review URL: http://codereview.chromium.org/518085
------------------------------------------------------------------------
r35796 | sky@chromium.org | 2010-01-08 17:47:25 +0100 (Fri, 08 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Fixes bug in background tabs not getting sized correctly. We need to
set the size request, which triggers a layout. The old code wasn't
updating the size request, so the hosting widget never changed the
size.

BUG=31132
TEST=see bug

Review URL: http://codereview.chromium.org/523145
------------------------------------------------------------------------
r35795 | pinkerton@chromium.org | 2010-01-08 17:41:22 +0100 (Fri, 08 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Hook up the "show certificates" button in under the hood to launch the keychain access app.
Change to the xib is to hook up the button's target/action and enable it.
BUG=none
TEST=click the button, watch the app launch.
Review URL: http://codereview.chromium.org/523104
------------------------------------------------------------------------
r35787 | jochen@chromium.org | 2010-01-08 15:09:33 +0100 (Fri, 08 Jan 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc

revert 35785. TBR=phajdan.jr@
------------------------------------------------------------------------
r35786 | jochen@chromium.org | 2010-01-08 14:53:04 +0100 (Fri, 08 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc

Add DCHECK for error_string so future NULL pointers can be caught

Review URL: http://codereview.chromium.org/523138
------------------------------------------------------------------------
r35785 | jochen@chromium.org | 2010-01-08 14:52:58 +0100 (Fri, 08 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc

Also match against the query string if present.

BUG=none
TEST=BlacklistTest.QueryStringMatch
------------------------------------------------------------------------
r35784 | tyoshino@google.com | 2010-01-08 12:32:12 +0100 (Fri, 08 Jan 2010) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Marking ExtensionApiTest.Storage flaky only on Linux.

http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2628/steps/browser_tests/logs/Storage

http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2604/steps/browser_tests/logs/Storage

ExtensionApiTest.Storage:
Got EXTENSION_LOADED notification.
Got EXTENSION_HOST_DID_STOP_LOADING notification.
C:\b\slave\chromium-dbg-builder\build\src\chrome\test\in_process_browser_test.cc(293): error: Test timed out. Each test runs for a max of 30000 ms (kInitialTimeoutInMS).
C:\b\slave\chromium-dbg-builder\build\src\chrome\browser\extensions\extension_storage_apitest.cc(8): error: Value of: RunExtensionTest("storage")
  Actual: false
Expected: true
No response from message loop.

BUG=22006
TBR=lzheng,japhet

Review URL: http://codereview.chromium.org/525110
------------------------------------------------------------------------
r35778 | ananta@chromium.org | 2010-01-08 06:55:50 +0100 (Fri, 08 Jan 2010) | 29 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi_entrypoints.cc
   A /trunk/src/chrome_frame/chrome_frame_npapi_entrypoints.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   A /trunk/src/chrome_frame/test/data/fulltab_delete_cookie_test.html
   A /trunk/src/chrome_frame/test/data/fulltab_delete_cookie_test.html.mock-http-headers
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/net/base/cookie_store.h

Attempt 2 at landing this.

Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame
with the host network stack enabled. When we receive a response in the host browser (IE) we send over the
response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie
API. We call this API to retrieve the persistent cookies and send them over to Chrome.

However this API returns session cookies as well as persistent cookies. There is no documented way to return
only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused
this issu.e. To workaround this issue when we receive the response in the url request automation job which
handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie.

When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However
this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786

The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they
conflict with similar functions in NACL.

Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight.

Bug=30786
Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added
    URLRequestAutomationJob::IsCookiePresentInCookieHeader function

TBR=amit

Review URL: http://codereview.chromium.org/521072
------------------------------------------------------------------------
r35776 | rsesek@chromium.org | 2010-01-08 06:36:04 +0100 (Fri, 08 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Move code duplicated in two tests up into the TestingProfile.

Move TestURLRequestContextGetter and friends from CookieTreeModelTest and
CookiesWindowControllerTest into TestingProfile. In the TestingProfile, return
a valid CookieMonster and URLRequstContextGetter, if CreateRequestContext() is
called.

Original CL: http://codereview.chromium.org/525072/show

BUG=None
TEST=Covered by unit tests

Review URL: http://codereview.chromium.org/525106
------------------------------------------------------------------------
r35772 | eroman@chromium.org | 2010-01-08 05:05:10 +0100 (Fri, 08 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Adds a NetworkChangeNotifier dependency to ProxyService; when we observer a network change through the notifier, the ProxyService re-configures itself.

So for example, if you were to switch to VPN and are using a custom PAC URL, we will re-download that URL on the new network.
Similarly if you are using auto-detect PAC settings, we will re-run the autodiscovery steps for the next resolve.

Note that Chromium is still passing a NULL NetworkChangeNotifier dependency into its ProxyService -- until it passes a real implementation, this will not impact Chrome.

BUG=12293
TEST=ProxyServiceTest.NetworkChangeTriggersPacRefetch
Review URL: http://codereview.chromium.org/525104
------------------------------------------------------------------------
r35771 | tyoshino@chromium.org | 2010-01-08 04:38:29 +0100 (Fri, 08 Jan 2010) | 38 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi_entrypoints.cc
   D /trunk/src/chrome_frame/chrome_frame_npapi_entrypoints.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   D /trunk/src/chrome_frame/test/data/fulltab_delete_cookie_test.html
   D /trunk/src/chrome_frame/test/data/fulltab_delete_cookie_test.html.mock-http-headers
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/net/base/cookie_store.h

Reason:
Linux Builder (ChromiumOS) failed.

http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(ChromiumOS)/builds/2050/steps/compile/logs/stdio

Please add changes to external_cookie_handler_unittest.cc no to break compilation
and reland?

----

Revert 35769 - Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame
with the host network stack enabled. When we receive a response in the host browser (IE) we send over the
response headers which include the SetCookie header and a list of cookies retreived via the InternetGetCookie
API. We call this API to retrieve the persistent cookies and send them over to Chrome.

However this API returns session cookies as well as persistent cookies. There is no documented way to return
only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused
this issu.e. To workaround this issue when we receive the response in the url request automation job which
handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie.

When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However
this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786

The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they
conflict with similar functions in NACL.

Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight.

Bug=30786
Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added
     URLRequestAutomationJob::IsCookiePresentInCookieHeader function

Review URL: http://codereview.chromium.org/518054

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/517070
------------------------------------------------------------------------
r35770 | tkent@chromium.org | 2010-01-08 04:01:41 +0100 (Fri, 08 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc

Fix a bug of unnecessary "Confirm form resubmission" dialog.

If a URL is requested by the POST method and then the page is
redirected to another URL, NavigationEntry::has_post_data_ is not
cleared correctly with the prior code. So "Confirm form resubmission"
dialog is shown when a user asks reloading the redirected page.


TEST=Add a unit test
BUG=21245

Review URL: http://codereview.chromium.org/524057
------------------------------------------------------------------------
r35769 | ananta@chromium.org | 2010-01-08 03:57:03 +0100 (Fri, 08 Jan 2010) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi_entrypoints.cc
   A /trunk/src/chrome_frame/chrome_frame_npapi_entrypoints.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   A /trunk/src/chrome_frame/test/data/fulltab_delete_cookie_test.html
   A /trunk/src/chrome_frame/test/data/fulltab_delete_cookie_test.html.mock-http-headers
   M /trunk/src/chrome_frame/test/html_util_unittests.cc
   M /trunk/src/net/base/cookie_store.h

Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame
with the host network stack enabled. When we receive a response in the host browser (IE) we send over the
response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie
API. We call this API to retrieve the persistent cookies and send them over to Chrome.

However this API returns session cookies as well as persistent cookies. There is no documented way to return
only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused
this issu.e. To workaround this issue when we receive the response in the url request automation job which
handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie.

When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However
this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786

The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they
conflict with similar functions in NACL.

Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight.

Bug=30786
Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added
     URLRequestAutomationJob::IsCookiePresentInCookieHeader function

Review URL: http://codereview.chromium.org/518054
------------------------------------------------------------------------
r35768 | oshima@chromium.org | 2010-01-08 03:55:12 +0100 (Fri, 08 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc

Revert "Reverting workaround for focus issue in WidgetGtk."

 Spoke too soon. It's still crashing.

This reverts commit 005f42a518774136337cd4be88431f21c50aba68.

BUG=chromium-os:1010
TEST=None
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/518077
------------------------------------------------------------------------
r35766 | pkasting@chromium.org | 2010-01-08 02:22:15 +0100 (Fri, 08 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/autofill/address.cc
   M /trunk/src/chrome/browser/autofill/contact_info.cc
   M /trunk/src/chrome/browser/autofill/credit_card.cc
   M /trunk/src/chrome/browser/autofill/form_group.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/webkit/appcache/appcache_group.h
   M /trunk/src/webkit/appcache/appcache_host.cc
   M /trunk/src/webkit/appcache/appcache_host_unittest.cc
   M /trunk/src/webkit/appcache/appcache_request_handler.cc
   M /trunk/src/webkit/appcache/appcache_storage_impl.cc
   M /trunk/src/webkit/appcache/appcache_storage_unittest.cc
   M /trunk/src/webkit/appcache/appcache_update_job_unittest.cc
   M /trunk/src/webkit/appcache/appcache_url_request_job_unittest.cc
   M /trunk/src/webkit/appcache/manifest_parser_unittest.cc
   M /trunk/src/webkit/appcache/mock_appcache_storage.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   M /trunk/src/webkit/database/database_tracker.h
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and EmptyGURL(), since the code in question can just use the default constructor.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517054
------------------------------------------------------------------------
r35765 | zork@google.com | 2010-01-08 02:21:33 +0100 (Fri, 08 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   D /trunk/src/chrome/browser/sync/util/query_helpers.cc
   D /trunk/src/chrome/browser/sync/util/query_helpers.h
   D /trunk/src/chrome/browser/sync/util/query_helpers_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Finish removing query_helpers.*

BUG=none
TEST=Run sync_unit_tests

Review URL: http://codereview.chromium.org/526002
------------------------------------------------------------------------
r35763 | finnur@chromium.org | 2010-01-08 02:15:28 +0100 (Fri, 08 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h

We should not return the raw Google Update branch code if we fail to determine what branch we are on. We should just assume stable.

We should also not add the branch code information to the version string, since it needs to be parsable by Version object. If we append the raw branch code, it might contain dots, which confuses the parsing done by the Version object.

BUG=31772
TEST=Change your branch code to something like 3.0-dev or 2.0-dev-somerandomstring. Chrome should not crash when you open the About box.
Review URL: http://codereview.chromium.org/523151
------------------------------------------------------------------------
r35753 | jcampan@chromium.org | 2010-01-08 00:25:52 +0100 (Fri, 08 Jan 2010) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   D /trunk/src/chrome/browser/cld_helper.cc
   D /trunk/src/chrome/browser/cld_helper.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/english_page.html
   D /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Revert 35735 - Relanding the language detection code.
Still causes redness on the reliability bot.

The code would crash if multiple PageContents notifications
were received rapidly.  The CLDHelper now notifies the
TabContents directly and the TabContents ensures only one
language detection can be performed at a time.
Added unittests to validate these cases in web_contents_unittest.cc.

Note that patch set 1 is the original patch, patch set 2 contains the new changes.

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unittests.

Review URL: http://codereview.chromium.org/504051

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/523149
------------------------------------------------------------------------
r35751 | jhawkins@chromium.org | 2010-01-08 00:13:09 +0100 (Fri, 08 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/address.cc
   M /trunk/src/chrome/browser/autofill/address_field.cc
   A /trunk/src/chrome/browser/autofill/autofill_profile.cc
   A /trunk/src/chrome/browser/autofill/autofill_profile.h
   M /trunk/src/chrome/browser/autofill/autofill_type.cc
   M /trunk/src/chrome/browser/autofill/autofill_type.h
   M /trunk/src/chrome/browser/autofill/billing_address.h
   M /trunk/src/chrome/browser/autofill/fax_number.h
   M /trunk/src/chrome/browser/autofill/field_types.h
   M /trunk/src/chrome/browser/autofill/home_address.h
   M /trunk/src/chrome/browser/autofill/home_phone_number.h
   M /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/chrome_browser.gypi

Implement AutoFillProfile, a collection of form groups that stores profile information.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517066
------------------------------------------------------------------------
r35743 | kkania@chromium.org | 2010-01-07 23:27:24 +0100 (Thu, 07 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js:35736)
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/connect

Revert 35737 (Chrome OS failing) - Include more extension browser tests on mac and linux. Some minor changes and reorganization.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/504064

TBR=kkania@chromium.org
Review URL: http://codereview.chromium.org/518068
------------------------------------------------------------------------
r35737 | kkania@chromium.org | 2010-01-07 22:50:23 +0100 (Thu, 07 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/echo.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js:34954)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/tabs_util.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/connect/test.html

Include more extension browser tests on mac and linux. Some minor changes and reorganization.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/504064
------------------------------------------------------------------------
r35735 | jcampan@chromium.org | 2010-01-07 22:41:50 +0100 (Thu, 07 Jan 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   A /trunk/src/chrome/browser/cld_helper.cc
   A /trunk/src/chrome/browser/cld_helper.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/english_page.html
   A /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Relanding the language detection code.

The code would crash if multiple PageContents notifications
were received rapidly.  The CLDHelper now notifies the
TabContents directly and the TabContents ensures only one
language detection can be performed at a time.
Added unit-tests to validate these cases in web_contents_unittest.cc.

Note that patch set 1 is the original patch, patch set 2 contains the new changes.

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unit-tests.

Review URL: http://codereview.chromium.org/504051
------------------------------------------------------------------------
r35723 | cpu@chromium.org | 2010-01-07 21:23:34 +0100 (Thu, 07 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/rlz/rlz.h

Disable RLZ for organic chrome installs
- Uses a table of approved brandcodes

BUG=30948
TEST= see bug for testing details

Review URL: http://codereview.chromium.org/518062
------------------------------------------------------------------------
r35721 | jhawkins@chromium.org | 2010-01-07 20:35:57 +0100 (Thu, 07 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/billing_address.h
   A /trunk/src/chrome/browser/autofill/home_address.h
   M /trunk/src/chrome/chrome_browser.gypi

Add HomeAddress and BillingAddress, specializations of Address.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/523112
------------------------------------------------------------------------
r35716 | jcampan@chromium.org | 2010-01-07 20:00:51 +0100 (Thu, 07 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/third_party/cld/bar/common/scopedptr.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/cldutil.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/cldutil.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/cldutil_dbg.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/cldutil_dbg_empty.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det.h
   D /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_generated_cjkbis_0.cc
   D /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_generated_ctjkvz.cc
   D /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_generated_longwords8_0.cc
   D /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_generated_meanscore.h
   D /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_generated_quads_128.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_impl.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_impl.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/ext_lang_enc.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/ext_lang_enc.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_cjkbis_0.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_ctjkvz.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_ctjkvz_0.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_longwords8_0.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_meanscore.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_quads_0.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_quads_128.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/compact_lang_det_generated_quads_256.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/getonescriptspan.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/getonescriptspan.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/letterscript_enum.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/subsetsequence.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/subsetsequence.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/tote.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/tote.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/utf8propjustletter.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/utf8propletterscriptnum.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/utf8scannotjustletterspecial.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_commandlineflags.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_dynamicstate.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_dynamicstate.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_google.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_htmlutils_windows.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_loadpolicy.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_loadpolicy.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_loadpolicyinterface.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_logging.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_macros.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_resourceids.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_scoped_ptr.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_scopedptr.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_service.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_service.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_serviceinterface.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_strtoint.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_tables.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_tables.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unilib_google3.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unilib_windows.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_utf8statetable.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_utf8statetable.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_utf8utils.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_utf8utils_windows.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/normalizedunicodetext.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/normalizedunicodetext.h
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/resourceinmemory.cc
   A /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/resourceinmemory.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/internal/encodings.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/lang_enc.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/encodings/public/encodings.h
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/languages/internal/languages.cc
   M /trunk/src/third_party/cld/bar/toolbar/cld/i18n/languages/public/languages.h
   A /trunk/src/third_party/cld/base/basictypes.h
   A /trunk/src/third_party/cld/base/build_config.h
   M /trunk/src/third_party/cld/base/casts.h
   M /trunk/src/third_party/cld/base/commandlineflags.h
   M /trunk/src/third_party/cld/base/log_severity.h
   M /trunk/src/third_party/cld/base/logging.h
   M /trunk/src/third_party/cld/base/macros.h
   A /trunk/src/third_party/cld/base/port.h
   A /trunk/src/third_party/cld/base/string_util.h
   M /trunk/src/third_party/cld/base/type_traits.h
   M /trunk/src/third_party/cld/base/vlog_is_on.h
   M /trunk/src/third_party/cld/cld.gyp

Merging a newer version of the CLD code.
Also removed the dependency with Chrome base and fixed the include path so that files don't need to reference third_paty/cld/...

BUG=None
TEST=Make sure unit-tests still pass.

Review URL: http://codereview.chromium.org/519071
------------------------------------------------------------------------
r35712 | erg@google.com | 2010-01-07 19:18:54 +0100 (Thu, 07 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/renderer_preferences_util.cc
   M /trunk/src/chrome/browser/renderer_preferences_util.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Only calculate the GTK scrollbar colors once and then update all RenderPreferences on theme change.

BUG=10949
TEST=none

Review URL: http://codereview.chromium.org/525016
------------------------------------------------------------------------
r35711 | phajdan.jr@chromium.org | 2010-01-07 19:16:58 +0100 (Thu, 07 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   M /trunk/src/net/base/listen_socket.cc
   M /trunk/src/net/base/telnet_server.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/third_party/libevent/libevent.gyp

Allow using system libevent instead of the bundled one.

Patch by Bernard Cafarelli <voyageur@gentoo.org>

TEST=none
BUG=22140

Review URL: http://codereview.chromium.org/524061
------------------------------------------------------------------------
r35704 | rsesek@chromium.org | 2010-01-07 15:19:35 +0100 (Thu, 07 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Revert 35703 - Move code duplicated in two tests up into the TestingProfile.

Move TestURLRequestContextGetter and friends from CookieTreeModelTest and
CookiesWindowControllerTest into TestingProfile. In the TestingProfile, return
a valid CookieMonster and URLRequstContextGetter.

BUG=None
TEST=Covered by unit tests

Review URL: http://codereview.chromium.org/525072

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/521056
------------------------------------------------------------------------
r35703 | rsesek@chromium.org | 2010-01-07 14:21:08 +0100 (Thu, 07 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Move code duplicated in two tests up into the TestingProfile.

Move TestURLRequestContextGetter and friends from CookieTreeModelTest and
CookiesWindowControllerTest into TestingProfile. In the TestingProfile, return
a valid CookieMonster and URLRequstContextGetter.

BUG=None
TEST=Covered by unit tests

Review URL: http://codereview.chromium.org/525072
------------------------------------------------------------------------
r35697 | tyoshino@google.com | 2010-01-07 10:49:22 +0100 (Thu, 07 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable ExtensionBrowserTest AutoUpdate until it's stable.
It's now not only flaky but crashing.

http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(Views%20dbg)/builds/6168/steps/browser_tests/logs/stdio

http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(Views%20dbg)/builds/6158/steps/browser_tests/logs/stdio

BUG=31737
TBR=japhet,lzheng

Review URL: http://codereview.chromium.org/518057
------------------------------------------------------------------------
r35696 | tyoshino@google.com | 2010-01-07 08:51:18 +0100 (Thu, 07 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Mark AutocompleteEditViewTest::EnterToSearch flaky.
interactive_ui_tests is flaky since
http://build.chromium.org/buildbot/waterfall/builders/Interactive%20Tests%20(dbg)/builds/19495
due to EnterToSearch.

BUG=31732
TBR=japhet,lzheng

Review URL: http://codereview.chromium.org/518055
------------------------------------------------------------------------
r35686 | rsesek@chromium.org | 2010-01-07 03:24:22 +0100 (Thu, 07 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   A /trunk/src/chrome/browser/chromeos/compact_location_bar.cc (from /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc:35680)
   A /trunk/src/chrome/browser/chromeos/compact_location_bar.h (from /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h:35680)
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome_browser.gypi

Revert r35674: "Use dropdown bar for compact location bar."

Review URL: http://codereview.chromium.org/525081
------------------------------------------------------------------------
r35678 | feldstein@chromium.org | 2010-01-07 02:31:08 +0100 (Thu, 07 Jan 2010) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hover_close_button.h
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Fix stuck hover states on tab close buttons

Use the |bounds| property instead of the |frame| property when updating tracking rectangles and deciding whether the button has the mouse over it.  We used to do this from the parent views context, but moved the code into the button itself and this broke.

Check the image state when the mouseDown event loop finishes.  We can get into a weird state when the tabs resize and the close button is placed under the cursor.  We update the image to highlight it, but if we click/hold the mouse button without moving the mouse, there are no mouseMove events and thus no mouseEntered, and thus no mouseExited (just assuming that's what is happening).

BUG=31279
TEST=Open a bunch of tabs, Click/hold on the last close button, then let go. Wit
hout moving the mouse at all, click/hold on the next button that moves under the
 mouse. Drag mouse away from tab strip area and let go. It should unhighlight it
self.

Review URL: http://codereview.chromium.org/524016
------------------------------------------------------------------------
r35677 | akalin@chromium.org | 2010-01-07 02:20:05 +0100 (Thu, 07 Jan 2010) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/notifier/base/ssl_adapter.cc
   A /trunk/src/chrome/browser/sync/notifier/base/ssl_adapter.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/third_party/libjingle/README.chromium
   M /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.cc
   M /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.h
   M /trunk/src/third_party/libjingle/files/talk/base/socketfactory.h
   M /trunk/src/third_party/libjingle/files/talk/base/socketpool.cc
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Use the right SSL adapter on Linux/OS X.  This is a partial fix for the crash in 30721.

Added method for creating ssl socket adapters to libjingle socket factories and made callers use it.

Added SSLSocketAdapterFactory class, which uses the right SSL socket adapter for Linux/OS X.

Fixed bug in asynchttprequest.cc where ignore_bad_cert_ was being left uninitialized.

BUG=30721
TEST=trybots, manual testing

Review URL: http://codereview.chromium.org/503087
------------------------------------------------------------------------
r35676 | tim@chromium.org | 2010-01-07 02:00:33 +0100 (Thu, 07 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

Fix for sync bug 31566. Return const& rather than a copy from
syncable Blob accessor to avoid danger with assigning the return
value _address_ to a pointer (which was done by r34993).

BUG=31566
TEST=SyncableDirectoryTest.TestSimpleFieldsPreservedDuringSaveChanges

Review URL: http://codereview.chromium.org/527014
------------------------------------------------------------------------
r35675 | georgey@chromium.org | 2010-01-07 01:55:16 +0100 (Thu, 07 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h

Addded notification when ancestor gets changed. So windows that lack focus manager, because of being
created on inactive tab, could do the necessary work when focus manager is actually attached.
This is relevant for Windows only, but some support functions (FindAllRootViews) could be useful for
other architectures as well.
BUG=22481
TEST=in the bug
Review URL: http://codereview.chromium.org/492025
------------------------------------------------------------------------
r35674 | oshima@chromium.org | 2010-01-07 01:52:31 +0100 (Thu, 07 Jan 2010) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar.cc
   D /trunk/src/chrome/browser/chromeos/compact_location_bar.h
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_host.cc
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_host.h
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_view.cc (from /trunk/src/chrome/browser/chromeos/compact_location_bar.cc:35673)
   A /trunk/src/chrome/browser/chromeos/compact_location_bar_view.h (from /trunk/src/chrome/browser/chromeos/compact_location_bar.h:35673)
   M /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   M /trunk/src/chrome/browser/views/dropdown_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome_browser.gypi

Use dropdown bar for compact location bar.
 * Refactored CompactLocationBar to Host/View to use DropdownBarHost/View.
 * Changed the logic to show/hide. Per cole's request, losing focus now hides the location bar.
Following features are not implemented yet.
 * Window cripping while animating.
 * Adjust location when toolbar is shown (it's always under tab)
 * clipping autocomplete dropdown.

Timer code is no longer used right now, but is left intentionally as we may put it back.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/525018
------------------------------------------------------------------------
r35673 | erikkay@chromium.org | 2010-01-07 01:40:19 +0100 (Thu, 07 Jan 2010) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/permissions_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/test/data/extensions/api_test/permissions
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/disabled
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/disabled/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/disabled/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/enabled
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/enabled/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/permissions/enabled/manifest.json

Fix issue where we weren't requiring the command-line flag for
experimental API use and weren't requiring that it be declared in the
manifest.

BUG=31537
TEST=none

Review URL: http://codereview.chromium.org/526011
------------------------------------------------------------------------
r35671 | estade@chromium.org | 2010-01-07 01:37:53 +0100 (Thu, 07 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h

GTK: Use page and app menu models.

- implement more MenuModel support for MenuGtk
- copy some accelerators around

TODO: centralize accelerator list (currently they are all listed twice)
TODO: get rid of standard_menus.cc (it is still used by the popup favicon menu)

BUG=NONE
TEST=page and app menus still work, still display accelerators, accelerators still work

Review URL: http://codereview.chromium.org/523105
------------------------------------------------------------------------
r35670 | jhawkins@chromium.org | 2010-01-07 01:35:39 +0100 (Thu, 07 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/fax_number.h
   A /trunk/src/chrome/browser/autofill/home_phone_number.h
   A /trunk/src/chrome/browser/autofill/phone_number.cc
   A /trunk/src/chrome/browser/autofill/phone_number.h
   M /trunk/src/chrome/chrome_browser.gypi

Add PhoneNumber, a form group that stores phone numbers.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/523100
------------------------------------------------------------------------
r35667 | estade@chromium.org | 2010-01-07 01:33:11 +0100 (Thu, 07 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK: Refresh the visibliity of other download items when removing a download item from the shelf.

BUG=31612
TEST=1. navigate to cygwin.com
2. save page
3. make page just narrow enough to only hold a dangerous download dialog
4. click on the cygwin.exe link
5. discard
6. save page item should reappear

Review URL: http://codereview.chromium.org/523111
------------------------------------------------------------------------
r35656 | akalin@chromium.org | 2010-01-06 23:27:39 +0100 (Wed, 06 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

sync: Add two functions to sync_ui_util header and update the callers accordingly.

* ShouldShowSyncErrorButton: added.
* GetSyncMenuLabel: added.

(original code review: http://codereview.chromium.org/501142 , patch by thiago.farina@gmail.com )

Review URL: http://codereview.chromium.org/519069
------------------------------------------------------------------------
r35655 | oshima@chromium.org | 2010-01-06 23:25:55 +0100 (Wed, 06 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/page_menu_model.cc
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc

Copy, Cut&Paste for chromeos
 Not enabled for linux as ctrl-c/x/v may not be copy/cut/paste. See bug for details.

BUG=18030
TEST=None

Review URL: http://codereview.chromium.org/519068
------------------------------------------------------------------------
r35651 | dumi@chromium.org | 2010-01-06 22:15:55 +0100 (Wed, 06 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   A /trunk/src/webkit/database/database_connections.cc
   A /trunk/src/webkit/database/database_connections.h
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker.h
   M /trunk/src/webkit/database/database_tracker_unittest.cc
   M /trunk/src/webkit/database/databases_table.cc
   M /trunk/src/webkit/database/databases_table.h
   M /trunk/src/webkit/database/databases_table_unittest.cc
   A /trunk/src/webkit/database/quota_table.cc
   A /trunk/src/webkit/database/quota_table.h
   A /trunk/src/webkit/database/quota_table_unittest.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_database_system.h
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/webkit.gyp

Adding methods that will be used by the quota management UI.

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/507014
------------------------------------------------------------------------
r35645 | jhawkins@chromium.org | 2010-01-06 21:25:41 +0100 (Wed, 06 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/credit_card.cc
   A /trunk/src/chrome/browser/autofill/credit_card.h
   M /trunk/src/chrome/chrome_browser.gypi

Add CreditCard, a form group that stores credit card information.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/518031
------------------------------------------------------------------------
r35636 | oshima@chromium.org | 2010-01-06 19:33:59 +0100 (Wed, 06 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc

Reverting workaround for focus issue in WidgetGtk.

BUG=chromium-os:1010
TEST=None

Review URL: http://codereview.chromium.org/527004
------------------------------------------------------------------------
r35634 | xiyuan@chromium.org | 2010-01-06 19:11:15 +0100 (Wed, 06 Jan 2010) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/jumplist.h
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/web_applications/web_app.h

Append profile info to win7 app id per issue 30414

Add profile info to app id for non-default profile so that win7 could
group chrome icons based on profile.
- Add a new chrome/common/win_util.h/cc to hold app id functions that
  would include profile info for non-default profiles;
- Add unit test to the new GetChromiumAppId function;
- Browser and JumpList to use the GetChromiumAppId for BrowserWindow
  and JumpList;
- UserDataManager to use it for shortcuts it creates;
- Make app id for web apps include profile info as well;
- Change web_app::UpdateShortcuts to just update shortcuts description,
  icon and app id;

BUG=30414
TEST=Verify fix for issue 30414.

Review URL: http://codereview.chromium.org/506079
------------------------------------------------------------------------
r35632 | evan@chromium.org | 2010-01-06 19:03:46 +0100 (Wed, 06 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc

linux: use a newer string

BUG=31680

Review URL: http://codereview.chromium.org/517051
------------------------------------------------------------------------
r35630 | jar@chromium.org | 2010-01-06 18:35:19 +0100 (Wed, 06 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Reduce SDCH experiment to have 0.05% holdback

This matches some adjustments already made in the current stable release.

r=mbelshe
Review URL: http://codereview.chromium.org/525047
------------------------------------------------------------------------
r35629 | jar@chromium.org | 2010-01-06 18:35:17 +0100 (Wed, 06 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log_unittest.cc

Add buildtime to UMA upload data

r=tigerf
Review URL: http://codereview.chromium.org/519017
------------------------------------------------------------------------
r35628 | viettrungluu@chromium.org | 2010-01-06 18:31:39 +0100 (Wed, 06 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h

Delete mysterious and spurious ^K character in bug_report_window_controller.h.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/527002
------------------------------------------------------------------------
r35617 | oshima@chromium.org | 2010-01-06 08:34:34 +0100 (Wed, 06 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc

Place main menu and otr icon in right places.
 Changed opaque frame to use main menu's width as offset
 Extender simply places the main menu on left edge.
Moved extender's Init call to browser view so that
 Init can use extender inside (just to be more safe).

BUG=chromium-os:985
TEST=None

Review URL: http://codereview.chromium.org/518033
------------------------------------------------------------------------
r35606 | suzhe@chromium.org | 2010-01-06 03:50:54 +0100 (Wed, 06 Jan 2010) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

[Linux] Improve LocationBarViewGtk.

This CL improves LocationBarViewGtk:
1. Add type to search hint.
2. Show/hide selected keyword, keyword hint and type to search hint automatically when resizing the browser window.
3. Use weak gray to display hint text, instead of black.

BUG=11258
TEST=Resize the browser window when one of selected keyword, keyword hint and type to search hint is visible, to see if the hint can be shown or hidden automatically.

Review URL: http://codereview.chromium.org/508008
------------------------------------------------------------------------
r35589 | arv@chromium.org | 2010-01-06 01:43:36 +0100 (Wed, 06 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Make sure that we do not focus the thumbnails on mouse down.

We used to focus the thumbnail on mousedown which makes the thumbmail hover
effect show up which confuses users.

BUG=31361
TEST=Right click on a thumbnail and dismiss the context menu. The thumbnail
should not be focused.

Review URL: http://codereview.chromium.org/525045
------------------------------------------------------------------------
r35587 | finnur@chromium.org | 2010-01-06 01:27:54 +0100 (Wed, 06 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/iframe.js
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/manifest.json
   A /trunk/src/chrome/test/data/feeds/feed_nolinks.xml

When RSS feed has no links, show the title (but don't create an anchor).

This used to show up as blank preview.

BUG=None
TEST=Covered by (new) automatic tests.

Review URL: http://codereview.chromium.org/523029
------------------------------------------------------------------------
r35585 | cevans@chromium.org | 2010-01-06 01:19:36 +0100 (Wed, 06 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc

Avoid excessive nesting / recursion in browser URL handling.

BUG=31517
TEST=ChildProcessSecurityPolicyTest

Review URL: http://codereview.chromium.org/525038
------------------------------------------------------------------------
r35576 | thakis@chromium.org | 2010-01-06 00:20:30 +0100 (Wed, 06 Jan 2010) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabContents.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/ipc/ipc_message.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js

Mac: Make devtools window dockable.

xib change: Deleted NSBox, added NSSplitView instead (with a thin divider and without any child views).

I added the devtools tabcontents to TabContentsController; windows and linux instead add it to the browser window and switch it on every tab change. What I've done makes more sense to me and might work better with a) dragging a tab with docked devtools into a new window and b) toggling fullscreen.

BUG=17368
TEST=
* Inspect element, click the "attach" item in the lower left corner. Devtools should attach to the tab. Click it again, should detach. Re-attach, switch tabs. Should only be in the tab it was attached to. Open another devtools window in another tab, should be attached there. Drag tab with attached devtools into a new window, should work.

* Inspect element with docked devtools, close devtools, inspect another element. devtools should open with the same size it had when it was closed, and should still be docked.

* Hover link with docked devtools. Status bubble should not overlap devtools.

* Go to http://www.pagetutor.com/keeper/http_authentication/index.html and make sure the http auth sheet still shows up

Review URL: http://codereview.chromium.org/526001
------------------------------------------------------------------------
r35575 | johnnyg@chromium.org | 2010-01-06 00:15:21 +0100 (Wed, 06 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc

Refactor the calculation of desktop size to use an existing common method rather than windows-specific logic.  Part of notifications port to linux.

BUG=23954
TEST=none

Review URL: http://codereview.chromium.org/524039
------------------------------------------------------------------------
r35573 | snej@chromium.org | 2010-01-06 00:09:30 +0100 (Wed, 06 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm

Add additional pasteboard tests to BookmarkTreeControllerTest.
Split up one method in BookmarkTreeController to improve testability.
BUG=13149
TEST=BookmarkTreeControllerTest.MoveNodes

Review URL: http://codereview.chromium.org/523069
------------------------------------------------------------------------
r35569 | estade@chromium.org | 2010-01-05 23:49:58 +0100 (Tue, 05 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/menus/accelerator_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

GTK: make tab context menu use tab_menu_model

flesh out some more menu model implementation for MenuGtk

BUG=28977
TEST=menu still works as before

Review URL: http://codereview.chromium.org/523049
------------------------------------------------------------------------
r35568 | feldstein@chromium.org | 2010-01-05 23:39:53 +0100 (Tue, 05 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/hover_close_button.h
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm

Fix Popup Blockers close button

The change at http://codereview.chromium.org/484006 changed all the close buttons to use a single HoverCloseButton class, but this didn't work for the popup blocker.  The reason is that all the initialization was done in awakeFromNib since in most other cases, the button was created in a nib, but was done with initWithFrame for the popup blocker case.  I refactored the initialization code out into -initButton to be called from both initWithFrame and awakeFromNib.

I also removed the references to the images and alt images from each of the xib files.  The images are specified in the class itself so it was redundant to have it in the xibs, and could probably cause confusion if we change the images later on.

BUG=16041
TEST=Ensure that the popup blocker button has rollover image changing, and that it works correctly still for TabView, InfoBar, and DownloadShelf

Review URL: http://codereview.chromium.org/521010
------------------------------------------------------------------------
r35563 | viettrungluu@chromium.org | 2010-01-05 23:18:42 +0100 (Tue, 05 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Mac: fix bookmark bar hide animation; also some clean-up.

As a mass-drive-by, I also got rid of unneeded |? YES : NO| (etc.), since
apparently |bool| and |BOOL| are interchangeable.

BUG=31635
TEST=Navigate to non-NTP page; switch theme to, say, "Anna Sui" (or be prepared to look very carefully); toggle bookmark bar (Cmd-Shift-B), back and forth; make sure that it looks correct when hiding.

Review URL: http://codereview.chromium.org/523070
------------------------------------------------------------------------
r35559 | jorlow@chromium.org | 2010-01-05 22:44:37 +0100 (Tue, 05 Jan 2010) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.cc (from /trunk/src/chrome/browser/in_process_webkit/storage_area.cc:34304)
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_area.h (from /trunk/src/chrome/browser/in_process_webkit/storage_area.h:34304)
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.cc (from /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc:34304)
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h (from /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h:34304)
   D /trunk/src/chrome/browser/in_process_webkit/storage_area.cc
   D /trunk/src/chrome/browser/in_process_webkit/storage_area.h
   D /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   D /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/chrome_browser.gypi

Rename StorageNamespace and StorageArea to DOMStorageNamespace and DOMStorageArea.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/488014
------------------------------------------------------------------------
r35557 | jorlow@chromium.org | 2010-01-05 22:21:24 +0100 (Tue, 05 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread_unittest.cc

Write the webkit thread unittests.  (Er...test.)
If you have any suggestions for other unit tests I can write for this, please
suggest them!

TEST=none
BUG=16155

Review URL: http://codereview.chromium.org/491035
------------------------------------------------------------------------
r35548 | rohitrao@chromium.org | 2010-01-05 21:07:09 +0100 (Tue, 05 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/window_sizer_mac.mm

[Mac] Implement WindowSizer::GetDefaultPopupOrigin()

BUG=http://crbug.com/30239
TEST=Popups should not appear under the Dock when the Dock is on the left.
Review URL: http://codereview.chromium.org/510001
------------------------------------------------------------------------
r35546 | snej@chromium.org | 2010-01-05 20:46:04 +0100 (Tue, 05 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/nibs/BookmarkManager.xib
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_groups_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_manager_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Native Cocoa bookmark manager, part 1
Most features are implemented, but Recents, Search and Undo are still missing.
MainMenu.xib: Just added "Bookmark Manager" menu item at top of "Bookmarks" menu.
BookmarkManager.xib: New file, containing Bookmark Manager panel, owned by BookmarkManagerController class.
BUG=13149
TEST=New unit tests for each new class.

Review URL: http://codereview.chromium.org/501073
------------------------------------------------------------------------
r35542 | johnnyg@chromium.org | 2010-01-05 20:06:04 +0100 (Tue, 05 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc

Add a configurable amount of space between the notification balloons.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/521030
------------------------------------------------------------------------
r35540 | pkasting@chromium.org | 2010-01-05 19:50:15 +0100 (Tue, 05 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc

I forgot that GURL doesn't do fixup.

BUG=31043
TEST=none
Review URL: http://codereview.chromium.org/521026
------------------------------------------------------------------------
r35539 | johnnyg@chromium.org | 2010-01-05 19:21:11 +0100 (Tue, 05 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Alter NineBox so that it can accept a single sprite resource with insets that define the size of the nine sub-areas.  This makes it consistent with views's ImagePainter.  Part of notifications port to linux.

BUG=23954
TEST=none

Review URL: http://codereview.chromium.org/524025
------------------------------------------------------------------------
r35538 | phajdan.jr@chromium.org | 2010-01-05 19:14:49 +0100 (Tue, 05 Jan 2010) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor_unittest.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_listener.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_listener.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_listener_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_test_util.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_test_util.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blocked_response.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blocked_response.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/resources/privacy_blacklist_block.html
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Implement delaying resource requests until privacy blacklists are ready.

Associate a BlacklistRequestInfo with each URLRequest started by ResourceDispatcherHost so that in various places we get access to the right BlacklistManager (each Profile has its own), and lazily cache a Blacklist::Match.

BlacklistListener controls delaying requests until the privacy blacklist is ready for the request.

BlacklistInterceptor handles substituting real response with a blocking page or blocking image. I've temporarily removed support for unblocking things. It was too hacky.

This change also removes a large block of blacklist-related code from RDH to more focused classes. Should make it a little more readable.

This should also make BlacklistManagerBrowserTest not flaky.

TEST=Covered by browser_tests and unit_tests.
BUG=21541, 29113

Review URL: http://codereview.chromium.org/501082
------------------------------------------------------------------------
r35537 | zork@google.com | 2010-01-05 19:00:21 +0100 (Tue, 05 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Fix a crash when enabling bookmark sync.

BUG=31560
TEST=Enable bookmark sync, then attempt to add a bookmark.

Review URL: http://codereview.chromium.org/526007
------------------------------------------------------------------------
r35525 | kinuko@chromium.org | 2010-01-05 10:49:12 +0100 (Tue, 05 Jan 2010) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

Make cmd-{/} shortcut keys work on any keyboard layouts (including non-US ones) on Mac.

BUG=25946
TEST=GlobalKeyboardShortcuts.ShortcutsToWindowCommand
TEST=Go to a Web page, open several tabs and press Cmd-{/}.  Make sure the browser tab switches to next or prev.  This should work on any keyboards (including ones with non-US layout).

Review URL: http://codereview.chromium.org/503080
------------------------------------------------------------------------
r35524 | phajdan.jr@chromium.org | 2010-01-05 09:56:21 +0100 (Tue, 05 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_ftp_job.h
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.h
   M /trunk/src/net/url_request/url_request_job_manager.cc

Remove WinInet FTP code.

TEST=none
BUG=25520

Review URL: http://codereview.chromium.org/523034
------------------------------------------------------------------------
r35519 | kinuko@chromium.org | 2010-01-05 06:38:13 +0100 (Tue, 05 Jan 2010) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc
   A /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm (from /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc:35518)
   M /trunk/src/chrome/chrome_tests.gypi

Rename global_keyboard_shortcuts_mac_unittest.cc into .mm

This was necessary for me to use objc types/classes in the unittest.
Separated from http://codereview.chromium.org/503080 to make the rename trackable.

BUG=none (indirectly related to 25946)
TEST=none

Review URL: http://codereview.chromium.org/525023
------------------------------------------------------------------------
r35512 | rsesek@chromium.org | 2010-01-05 05:42:00 +0100 (Tue, 05 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/base/cocoa_protocols_mac.h
   M /trunk/src/chrome/DEPS
   A /trunk/src/chrome/app/nibs/Cookies.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/browser/cocoa/cookie_tree_node.h
   A /trunk/src/chrome/browser/cocoa/cookie_tree_node.mm
   A /trunk/src/chrome/browser/cocoa/cookies_window_controller.h
   A /trunk/src/chrome/browser/cocoa/cookies_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_dll.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Implement the cookie manager

This CL creates the basic cookie management interface, allowing users to view
and delete cookies from Chromium. TODO: (1) Add the filtering by domain
capability. (2) Localize the NIB.

BUG=15360
TEST=Chromium-->Preferences-->Under the Hood-->Show Cookies. Also covered by unit tests.

Review URL: http://codereview.chromium.org/523025
------------------------------------------------------------------------
r35502 | estade@chromium.org | 2010-01-05 02:13:06 +0100 (Tue, 05 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK: fix regression where MenuGtk::Delegate GetLabel() method was erroneously removed.

got overzealous deleting code in r35389

BUG=31391
TEST=see bug


------------------------------------------------------------------------
r35501 | thakis@chromium.org | 2010-01-05 02:11:52 +0100 (Tue, 05 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

style

bug=test=none
tbr=pink

Review URL: http://codereview.chromium.org/526006
------------------------------------------------------------------------
r35499 | evan@chromium.org | 2010-01-05 01:49:47 +0100 (Tue, 05 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

views/gtk: Add missing keyboard accelerators to Search Engines dialog.

BUG=16380
TEST=manual

Patch from Thiago Farina <thiago.farina@gmail.com>.

Review URL: http://codereview.chromium.org/518028
------------------------------------------------------------------------
r35496 | akalin@chromium.org | 2010-01-05 01:22:08 +0100 (Tue, 05 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc

Added check for Chrome message loop in SSLSocketAdapter::BeginSSL().

BUG=none
TEST=made sure this doesn't trigger with normal sync operations

Review URL: http://codereview.chromium.org/523041
------------------------------------------------------------------------
r35494 | andybons@chromium.org | 2010-01-05 00:41:25 +0100 (Tue, 05 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

[Mac] Fixes bug where clicking a Browser Action button twice quickly will result in a sticky popup from the original click.

BUG=31097
TEST=Click on a browser action button (with a popup) twice very quickly. A popup should show up, but once you click outside of it, it should not remain.
Review URL: http://codereview.chromium.org/524023
------------------------------------------------------------------------
r35493 | pkasting@chromium.org | 2010-01-05 00:36:11 +0100 (Tue, 05 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc

Blacklist particular TLD+1s for accidental search infobars, to avoid showing the user an infobar on all kinds of searches.

BUG=31043
TEST=Legit intranet sites should still produce infobars.  Search terms which previously generated infobars on Comcast/Verizon should not.
Review URL: http://codereview.chromium.org/523043
------------------------------------------------------------------------
r35492 | pkasting@chromium.org | 2010-01-05 00:26:14 +0100 (Tue, 05 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Correctly enable the Copy item on the popup window omnibox context menu.  Original patch by Thiago Farina (see http://codereview.chromium.org/522031), r=finnur,me.

BUG=29092
TEST=Select some text in a popup window omnibox, then right-click it.  "Copy" should be enabled.
------------------------------------------------------------------------
r35488 | jhawkins@chromium.org | 2010-01-04 23:57:19 +0100 (Mon, 04 Jan 2010) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/address.cc
   A /trunk/src/chrome/browser/autofill/address.h
   M /trunk/src/chrome/chrome_browser.gypi

Add AddressField, a form group that stores address information.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517028
------------------------------------------------------------------------
r35483 | oshima@chromium.org | 2010-01-04 22:39:50 +0100 (Mon, 04 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc

Add space under the tabstrip when the compact navbar is active.
This was in gtk impl, but missing in toolkit_view impl.

BUG=None
TEST=None

test

Review URL: http://codereview.chromium.org/517024
------------------------------------------------------------------------
r35480 | finnur@chromium.org | 2010-01-04 22:28:57 +0100 (Mon, 04 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Permission escalation when extension updates should trigger the install warning
when enabling the extension through the Extensions Management UI.

TBR=mpcomplete
BUG=http://crbug.com/30752
TEST=This requires an extension that autoupdates _and_ increases its
permissions. If you ignore the infobar that says it has been disabled, you
should still get the Install Warning dialog when you try to enable the
extension.

------------------------------------------------------------------------
r35479 | andybons@chromium.org | 2010-01-04 22:27:59 +0100 (Mon, 04 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc

Fixes bug where recreating the document element via altering |documentElement.innerHTML| would cause ExtensionHost::DocumentAvailableInMainFrame to be called more than once for a single RenderViewHost. Since setup is performed within that function that does not need to be done more than once (and cannot be since it registers for notifications from all sources), we check to see if setup has been performed and bail if so.

BUG=31170
TEST=Install the eBay extension (id khhckppjhonfmcpegdjdibmngahahhck ) and click on the browser action button in Debug mode. It should not hit the DCHECK from registering redundant notifications.
Review URL: http://codereview.chromium.org/519036
------------------------------------------------------------------------
r35475 | jhawkins@chromium.org | 2010-01-04 21:27:25 +0100 (Mon, 04 Jan 2010) | 5 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/autofill/address_field.h
   A /trunk/src/chrome/browser/autofill/contact_info.cc
   A /trunk/src/chrome/browser/autofill/contact_info.h
   M /trunk/src/chrome/browser/autofill/credit_card_field.h
   M /trunk/src/chrome/browser/autofill/form_group.h
   M /trunk/src/chrome/chrome_browser.gypi

Implement ContactInfo, the FormGroup that stores contact information.

BUG=none
TEST=StringUtilTest.Tokenizer
Review URL: http://codereview.chromium.org/502103
------------------------------------------------------------------------
r35472 | estade@chromium.org | 2010-01-04 21:08:37 +0100 (Mon, 04 Jan 2010) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

GTK: Allow infobubbles to be programtically shrunk.

This should only actually affect ExtensionPopups as other infobubbles never resize.

BUG=30294
TEST=chromed bird extension resizes after reverting http://trac.webkit.org/changeset/51492

Review URL: http://codereview.chromium.org/526003
------------------------------------------------------------------------
r35467 | zork@google.com | 2010-01-04 20:22:57 +0100 (Mon, 04 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/sync/util/user_settings_posix.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_win.cc

Updated user_settings.* to use Chromium's sqlite helper functions.

BUG=none
TEST=Run sync_unit_tests

Review URL: http://codereview.chromium.org/518026
------------------------------------------------------------------------
r35462 | skrul@chromium.org | 2010-01-04 19:40:25 +0100 (Mon, 04 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc

Fix leak from cl 524003 (Change WDS to use the DB thread...)
This is a second try of cl 524003 -- the previous version caused a leak.  The only change in this patch is the addition of the ui_thread_ member in TemplateURLModelTest and the corresponding initializer.  This allows the DeleteOnUIThread trait of the WebDataService to do its job.

Review URL: http://codereview.chromium.org/522025
------------------------------------------------------------------------
r35459 | agl@chromium.org | 2010-01-04 19:03:33 +0100 (Mon, 04 Jan 2010) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/common/sandbox_methods_linux.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

This reverts commit r35458.

(I screwed up and committed in the wrong terminal.)
------------------------------------------------------------------------
r35458 | agl@chromium.org | 2010-01-04 19:01:13 +0100 (Mon, 04 Jan 2010) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/common/sandbox_methods_linux.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h

...
------------------------------------------------------------------------
r35456 | viettrungluu@chromium.org | 2010-01-04 17:17:13 +0100 (Mon, 04 Jan 2010) | 12 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/chrome/browser/process_info_snapshot.h
   M /trunk/src/chrome/browser/process_info_snapshot_mac.cc

Mac: stop zombie ps processes from being created.

This fixes two bugs:
- the output buffer for the ps command being run could be too small (fix: buffer
  enlargened); and
- if the output buffer was too small, waitpid() wouldn't be called (fix: always
  call waitpid(), obviously).

BUG=31378
TEST=On a big, long-running Chrome/Chromium (with many processes, e.g., renderers), check that there are no zombie ps processes (with PPID the browser process); looking at about:memory may help speed up the creation of such zombies. Also, run the new test, ProcessUtilTest.GetAppOutputRestrictedNoZombies.

Review URL: http://codereview.chromium.org/523033
------------------------------------------------------------------------
r35455 | viettrungluu@chromium.org | 2010-01-04 16:43:20 +0100 (Mon, 04 Jan 2010) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Mac: fix crashes related to detaching tabs.

There are actually two problems, with two fixes:
- Remove TabStripController as observer when removing a tab. (Otherwise, there's a race condition which can result in a stale observation.)
- Make sure the TabController (and its TabView) aren't deleted while handling a torn-off tab.

BUG=31138
TEST=Attach/re-attach/move/close tabs under a variety of circumstances (see in particular the situation described in the bug). Do so till the cows come home. It should hopefully not crash. (Perhaps also check a debug build, and make sure no assertions fail.)

Review URL: http://codereview.chromium.org/515066
------------------------------------------------------------------------
r35448 | mdm@chromium.org | 2010-01-04 01:23:57 +0100 (Mon, 04 Jan 2010) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Linux: print the sandbox binary path in use when it fails. Helps pinpoint sandbox path mismatches.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/519033
------------------------------------------------------------------------
r35440 | thakis@chromium.org | 2010-01-03 01:51:44 +0100 (Sun, 03 Jan 2010) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: Cmd-three finger swipe should open	  prev/next page in new tab.

BUG=29804
TEST=surf around, hold cmd, three-finger-swipe to the left. previous page should open in new tab. switch to new	tab, hold cmd, three-finger-swipe to the right. original page should open in yet another tab.

Review URL: http://codereview.chromium.org/525002
------------------------------------------------------------------------
r35438 | derat@chromium.org | 2010-01-02 17:35:14 +0100 (Sat, 02 Jan 2010) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

chromeos: Rename panel content window enum.

This is just to match up with http://codereview.chromium.org/525001 ,
a change to make some of the window manager code a bit clearer.

TEST=sent to try servers
BUG=none

Review URL: http://codereview.chromium.org/517026
------------------------------------------------------------------------
r35406 | oshima@chromium.org | 2009-12-31 03:47:41 +0100 (Thu, 31 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc

Don't show app menu when wrench menu is shown at startup.

BUG=chromium-os:1095
TEST=None

Review URL: http://codereview.chromium.org/524008
------------------------------------------------------------------------
r35404 | estade@chromium.org | 2009-12-31 03:08:06 +0100 (Thu, 31 Dec 2009) | 35 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK: Remove OwnedWidgetGtk wrapper for the GtkMenu* in MenuGtk.

The "execute the command later" workaround, which was in place to avoid OwnedWidget-DCHECKing when selecting menu items that might cause cascading object-destruction effects, caused problems with the Browser::SetBlockCommandExecution() workaround, the reasoning for which can be found in BrowserWindowGtk and is reproduced here:

    // This piece of code is based on the fact that calling
    // gtk_window_activate_key() method against |window_| may only trigger a
    // browser command execution, by matching either a global accelerator
    // defined in above |kAcceleratorMap| or the accelerator key of a menu
    // item defined in chrome/browser/gtk/standard_menus.cc.
    //
    // Here we need to retrieve the command id (if any) associated to the
    // keyboard event. Instead of looking up the command id in above
    // |kAcceleratorMap| table by ourselves, we block the command execution of
    // the |browser_| object then send the keyboard event to the |window_| by
    // calling gtk_window_activate_key() method, as if we are activating an
    // accelerator key. Then we can retrieve the command id from the
    // |browser_| object.
    //
    // Pros of this approach:
    // 1. We can handle accelerators defined not only in above
    //    |kAcceleratorMap| table, but also those in standard_menus.cc.
    // 2. We don't need to care about keyboard layout problem, as
    //    gtk_window_activate_key() method handles it for us.
    //
    // Cons:
    // 1. The logic is a little complicated.
    // 2. We should be careful not to introduce any accelerators that trigger
    //    customized code instead of browser commands.

The easiest and cleanest thing is just to remove the OwnedWidgetGtk.

BUG=none
TEST=interactive ui tests pass again

Review URL: http://codereview.chromium.org/522028
------------------------------------------------------------------------
r35401 | estade@chromium.org | 2009-12-31 01:22:07 +0100 (Thu, 31 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK: implement page action context menus.

BUG=30656
TEST=manual

Review URL: http://codereview.chromium.org/515073
------------------------------------------------------------------------
r35400 | estade@chromium.org | 2009-12-31 01:13:20 +0100 (Thu, 31 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   M /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.h

Implement browser action context menu on linux.

BUG=30656
TEST=manual (right click on browser actions and test the actions)

Review URL: http://codereview.chromium.org/521016
------------------------------------------------------------------------
r35393 | cevans@chromium.org | 2009-12-30 23:07:24 +0100 (Wed, 30 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Use https for GAIA URL.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/522022
------------------------------------------------------------------------
r35391 | ajwong@chromium.org | 2009-12-30 22:25:05 +0100 (Wed, 30 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/filters-example-01-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/batik/text/textEffect-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/batik/text/textEffect-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/batik/text/textEffect3-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/batik/text/textEffect3-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/focus-ring-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/focus-ring-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/batik/filters/filterRegions-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/batik/text/textEffect-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/batik/text/textEffect3-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/batik/text/textFeatures-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/batik/text/textProperties-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/custom/feDisplacementMap-01-expected.txt
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.txt (from /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.txt:35383)
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/custom/non-opaque-filters-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/filters/big-sized-filter-2-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/filters/feMerge-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/filters/feOffset-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/filters/subRegion-in-userSpace-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/filters/subRegion-one-effect-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/svg/filters/subRegion-two-effects-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/filters/feTile-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/filters/filterRegions-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textEffect-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textEffect-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textEffect-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textEffect3-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textEffect3-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textEffect3-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textFeatures-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/text/textProperties-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/clip-path-display-none-child-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/clip-path-referencing-use-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/empty-merge-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feDisplacementMap-01-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/focus-ring-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/focus-ring-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/focus-ring-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-clipPath-and-object-creation-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-clipPath-creation-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/non-opaque-filters-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/text-clip-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/text-filter-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/big-sized-filter-2-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/big-sized-filter-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/feGaussianBlur-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/feMerge-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/feOffset-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/feTile-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/filterRes-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/shadow-on-filter-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/sourceAlpha-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/subRegion-in-userSpace-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/subRegion-one-effect-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/filters/subRegion-two-effects-expected.txt
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Roll webkit 52633 -> 52667.

Rebaseline a bunch of SVG test broken to due webkit r52647.

BUG=25977,31028,29737,31350
TEST=mostly green layout test try runs.

Review URL: http://codereview.chromium.org/515067
------------------------------------------------------------------------
r35390 | evan@chromium.org | 2009-12-30 22:18:07 +0100 (Wed, 30 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

linux: use XShmPutImage when SHM Pixmap APIs unavailable

SHM Pixmaps were frequently unavailable (which makes some
sense: you're asking for a shared memory handle into a
graphics-card-side memory buffer).  But we can still do
an SHM copy from pixels->pixmap as long as we only go in
write only direction, via the XShmPutImage API.

BUG=31301

Review URL: http://codereview.chromium.org/522023
------------------------------------------------------------------------
r35389 | estade@chromium.org | 2009-12-30 21:51:36 +0100 (Wed, 30 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   D /trunk/src/chrome/browser/back_forward_menu_model_views.cc
   D /trunk/src/chrome/browser/back_forward_menu_model_views.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.mm
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   D /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   D /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Make back forward menu model a MenuModel.

On Linux, implement just enough MenuModel support in GtkMenu. On Linux + windows, remove wrapper classes. On Mac, just change a few function calls around.

BUG=none
TEST=unit test + manually clicking around on it in debug mode

Review URL: http://codereview.chromium.org/501168
------------------------------------------------------------------------
r35388 | dumi@chromium.org | 2009-12-30 21:36:01 +0100 (Wed, 30 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Re-enable the ExtensionApiTest.Storage test.

BUG=27216
TEST=none


Review URL: http://codereview.chromium.org/523021
------------------------------------------------------------------------
r35384 | thakis@chromium.org | 2009-12-30 19:57:38 +0100 (Wed, 30 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

Added pause button to DownloadItemMac via IB and IBAction to receive the event.
BUG=23069
TEST=Download large file, click pause in download item's menu to pause/unpause.

Review URL: http://codereview.chromium.org/524009
Patch from sig11@reprehensible.net.
------------------------------------------------------------------------
r35383 | mhm@chromium.org | 2009-12-30 18:55:56 +0100 (Wed, 30 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Apply style guideline for variable names for browser action container.

Change arrowLocation to arrow_location, to follow Chromium code standards.

BUG=494008
TEST=None

Review URL: http://codereview.chromium.org/522027
------------------------------------------------------------------------
r35381 | apavlov@chromium.org | 2009-12-30 18:17:28 +0100 (Wed, 30 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Revert enabled DevToolsSanityTest.TestConsoleLog test.
Fails on Linux

TBR=pfeldman@chromium.org

Review URL: http://codereview.chromium.org/519028
------------------------------------------------------------------------
r35380 | apavlov@chromium.org | 2009-12-30 17:55:01 +0100 (Wed, 30 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Enable DevToolsSanityTest.TestConsoleLog test (seems flaky)

TBR=pfeldman@chromium.org
BUG=none
TEST=DevToolsSanityTest.TestConsoleLog

Review URL: http://codereview.chromium.org/521015
------------------------------------------------------------------------
r35377 | jschuh@chromium.org | 2009-12-30 15:49:41 +0100 (Wed, 30 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc

Replaces the % character with \x when generating Windows shortcuts via 
File->"Create application shortcuts." The \x is converted back to % in 
handling the --app switch.

BUG=23693
TEST=None

Review URL: http://codereview.chromium.org/515028
------------------------------------------------------------------------
r35375 | thomasvl@chromium.org | 2009-12-30 15:13:42 +0100 (Wed, 30 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

[Mac] Fixup the new tab button images

- Don't set the images in the xib since cocoa can't find them in the other bundle during tests (and maybe not during normal app runtime)
- Make sure the images are setup during view start.
- Create constants for the image names since some are used in more then one place.

BUG=30342
TEST=no longer get the error messages on test runs
Review URL: http://codereview.chromium.org/515061
------------------------------------------------------------------------
r35373 | jar@chromium.org | 2009-12-30 08:47:01 +0100 (Wed, 30 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Fix linux/mac tree

non-debug builds had unused static function

tbr=mbelshe
Review URL: http://codereview.chromium.org/523023
------------------------------------------------------------------------
r35372 | jar@chromium.org | 2009-12-30 08:31:45 +0100 (Wed, 30 Dec 2009) | 18 lines
Changed paths:
   M /trunk/src/base/tracked.cc
   M /trunk/src/base/tracked_objects.cc
   M /trunk/src/base/tracked_objects.h
   M /trunk/src/chrome/browser/browser_about_handler.cc

Provide a quick and dirty way to reset about:objects data

To make it easier to use the about:object profiling facility,
I put in a quick/dirty way to reset all profile stats to 0 (as if
there were no births, deaths, etc.). This code is only activated
under debug builds (or if a developer inists in a private build).  
These stats don't impact semantics of the browser, so the hackish
approach to clearing the data counts can't instigate a crash, and 
it makes it much easier to look at changes in the stats.

While changing the code, I also added a lot of comments, and did
a few minor cleanups items.

I also officially added about:tasks as a replacement for about:objects,
as this is really how the service is used in Chrome. 

r=mbelshe
Review URL: http://codereview.chromium.org/100297
------------------------------------------------------------------------
r35365 | michaeln@chromium.org | 2009-12-30 04:29:10 +0100 (Wed, 30 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable interactive ui test DevToolsSanityTest.TestConsoleLog which went red with a webkit roll.

TEST=none
BUG=31302
TBR=pam

Review URL: http://codereview.chromium.org/518024
------------------------------------------------------------------------
r35356 | michaeln@google.com | 2009-12-30 00:40:52 +0100 (Wed, 30 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc

Revert 35339 - Change WDS to use the DB thread rather than its own thread.
This cleanup was requested by brettw and was started to make it easier for the sync service to post tasks to the WDS thread (now the DB thread).  This simplifies the WDS a bit since it no longer has to manage its own thread, and can assume that the DB thread is running throughout its lifetime.

One change in behavior that is significant is that previous to this change, the WDS worker thread would always be joined when Shutdown() was called from Profile::~Profile().  Now the Shutdown() method schedules a task that can extend the lifetime of the WDS past the lifetime of the Profile instance.

Review URL: http://codereview.chromium.org/524003

TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/521013
------------------------------------------------------------------------
r35353 | zork@google.com | 2009-12-29 23:24:19 +0100 (Tue, 29 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable-inl.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h

Continue migration from query_helpers.* to sqlite_utils.*

BUG=none
TEST=Run sync_unit_tests
Review URL: http://codereview.chromium.org/509023
------------------------------------------------------------------------
r35347 | andybons@chromium.org | 2009-12-29 22:12:54 +0100 (Tue, 29 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Implementation of Page Action tooltips. Also adds cursor rects to the address bar for any icon you can click within it so that the default pointer is shown instead of the I-beam.

BUG=12281
TEST=Hover over a Page Action that has a tooltip, observe that the tooltip shows up and that the cursor is a pointer, not an I-Beam.
Review URL: http://codereview.chromium.org/523015
------------------------------------------------------------------------
r35346 | zork@chromium.org | 2009-12-29 22:06:54 +0100 (Tue, 29 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h

Fix SSL Socket adapter to handle the case where StartSSL is called before the socket is connected.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/515018
------------------------------------------------------------------------
r35345 | evan@chromium.org | 2009-12-29 21:51:43 +0100 (Tue, 29 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

linux: clip max tooltip length

BUG=30487
TEST=see bug for test case

Review URL: http://codereview.chromium.org/519019
------------------------------------------------------------------------
r35344 | thomasvl@chromium.org | 2009-12-29 21:40:43 +0100 (Tue, 29 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Add the extension to the image name so we avoid warnings from ns_image_cache and so we share the image between the place we used it with and without an extension.

BUG=none
TEST=no longer get info lines about wanting the extension on the image name.
Review URL: http://codereview.chromium.org/523017
------------------------------------------------------------------------
r35341 | jhawkins@chromium.org | 2009-12-29 21:09:29 +0100 (Tue, 29 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/app/resource_bundle_dummy.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc

atl: Remove unused <atlbase.h> header from some source files.

BUG=5027
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/519022
------------------------------------------------------------------------
r35339 | skrul@chromium.org | 2009-12-29 20:12:41 +0100 (Tue, 29 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc

Change WDS to use the DB thread rather than its own thread.
This cleanup was requested by brettw and was started to make it easier for the sync service to post tasks to the WDS thread (now the DB thread).  This simplifies the WDS a bit since it no longer has to manage its own thread, and can assume that the DB thread is running throughout its lifetime.

One change in behavior that is significant is that previous to this change, the WDS worker thread would always be joined when Shutdown() was called from Profile::~Profile().  Now the Shutdown() method schedules a task that can extend the lifetime of the WDS past the lifetime of the Profile instance.

Review URL: http://codereview.chromium.org/524003
------------------------------------------------------------------------
r35336 | evan@chromium.org | 2009-12-29 19:05:42 +0100 (Tue, 29 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h

find_bar: Update the behavior of FindNext/FindPrevious on Windows to match the Linux version.

Now they are enabled all the time.

BUG=None
TEST=open a web page, search for text that is in the page or not
(doesn't matter).  See that the buttons are enabled.

Patch from Thiago Farina <thiago.farina@gmail.com>.

Review URL: http://codereview.chromium.org/518009
------------------------------------------------------------------------
r35335 | evan@chromium.org | 2009-12-29 18:56:34 +0100 (Tue, 29 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.h

linux: simplify sad tab

Remove unused gradient.
Remove unnecessary singleton.
Restores centered text.
Allows tab to be resized small (a regression caused by a recent change,
no bug filed for that).

BUG=29507

Review URL: http://codereview.chromium.org/517012
------------------------------------------------------------------------
r35326 | evan@chromium.org | 2009-12-29 02:13:23 +0100 (Tue, 29 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/app/gfx/native_widget_types.h
   A /trunk/src/app/scoped_handle_gtk.h (from /trunk/src/base/scoped_handle_gtk.h:35323)
   M /trunk/src/app/theme_provider.h
   M /trunk/src/base/scoped_handle.h
   D /trunk/src/base/scoped_handle_gtk.h
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/views/view.cc
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webcursor_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/webkit.gyp

linux: reduce header interdependencies

By analyzing gcc -H output, I found some of our worst offenders for
headers bringing in other headers.  native_web_keyboard_event.h was
responsible for just under 60,000 extra includes!

This change will in theory make the build faster.

Review URL: http://codereview.chromium.org/524004
------------------------------------------------------------------------
r35322 | evan@chromium.org | 2009-12-29 01:53:55 +0100 (Tue, 29 Dec 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/icon_loader.cc

Build fix.
------------------------------------------------------------------------
r35319 | ananta@chromium.org | 2009-12-29 00:29:19 +0100 (Tue, 29 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   A /trunk/src/chrome_frame/test/data/xmlhttprequest_authorization_header_test.html
   M /trunk/src/chrome_frame/test/data/xmlhttprequest_test.html

Authorization headers set using XHR with ChromeFrame were stripped in the outgoing HTTP
requests sent via the host network stack.

Fix is to remove the authorization header from the list of filtered headers.

Added a unit test for this.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=23103

Bug=23103
Test=Covered by unit test.

Review URL: http://codereview.chromium.org/519013
------------------------------------------------------------------------
r35317 | davemoore@chromium.org | 2009-12-28 23:32:47 +0100 (Mon, 28 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

send the pngs on cros

Added code to stream screenshots

gtk screenshot support

Review URL: http://codereview.chromium.org/517017
------------------------------------------------------------------------
r35313 | evan@chromium.org | 2009-12-28 22:51:40 +0100 (Mon, 28 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm

Include the reason in the notice for blocked content (for Mac, Win and Linux include it already).

BUG=none
TEST=Setup a blacklist for cookies, load a site, check that the reason is displayed in the blocking notice.

Patch from Jochen Eisinger <eisinger@google.com>.

Review URL: http://codereview.chromium.org/523007
------------------------------------------------------------------------
r35312 | davemoore@chromium.org | 2009-12-28 22:47:37 +0100 (Mon, 28 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model.cc
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc

Remove cut / copy / paste from cros build and fix PageMenuModelTest

Review URL: http://codereview.chromium.org/523009
------------------------------------------------------------------------
r35311 | avi@chromium.org | 2009-12-28 22:40:13 +0100 (Mon, 28 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm

Make infobars into accessibility groups.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/517015
------------------------------------------------------------------------
r35310 | avi@chromium.org | 2009-12-28 22:40:05 +0100 (Mon, 28 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Cleaning up the tab accessibility model.

BUG=http://crbug.com/28286
TEST=As in bug

Review URL: http://codereview.chromium.org/519012
------------------------------------------------------------------------
r35306 | avi@chromium.org | 2009-12-28 21:45:12 +0100 (Mon, 28 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Tagging a whole bunch of buttons with descriptions (via code; OS bug prevents us from doing it via nib).

BUG=http://crbug.com/28286
TEST=As in bug

Review URL: http://codereview.chromium.org/518010
------------------------------------------------------------------------
r35305 | gregoryd@google.com | 2009-12-28 21:30:46 +0100 (Mon, 28 Dec 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/app/dummy_main_functions.cc
   A /trunk/src/chrome/browser/renderer_host/render_process_host_dummy.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/chrome_dll.gypi
   A /trunk/src/chrome/chrome_exe.gypi
   A /trunk/src/chrome/common/resource_dispatcher_dummy.cc
   A /trunk/src/chrome/common/socket_stream_dispatcher_dummy.cc
   A /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/nacl/sel_main.cc
   A /trunk/src/chrome/nacl.gypi
   A /trunk/src/webkit/glue/webkit_glue_dummy.cc

Split more targets from chrome.gyp to add support for building Native Client for 64-bit Windows. 

This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries.
For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. 

TEST=none
BUG=28176


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35237
Review URL: http://codereview.chromium.org/384068
------------------------------------------------------------------------
r35302 | davemoore@chromium.org | 2009-12-28 19:24:09 +0100 (Mon, 28 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/page_menu_model.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Adjust the menu items available in cros
Bug: 28054
Test: None

Review URL: http://codereview.chromium.org/516016
------------------------------------------------------------------------
r35295 | jar@chromium.org | 2009-12-28 07:59:52 +0100 (Mon, 28 Dec 2009) | 25 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/histogram_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   M /trunk/src/chrome/browser/chrome_browser_application_mac_unittest.mm
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/net/base/connection_type_histograms.cc
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/disk_cache/histogram_macros.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_server_type_histograms.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket_stream/socket_stream_metrics.cc
   M /trunk/src/net/socket_stream/socket_stream_metrics_unittest.cc

Cleanup histogram classes mixing SetFlags into FactoryGet arguments

Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet,
along with reformatting.

The macros were cleaned up to use common sub-macros rather than
repeating code as much.

Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros)
since this class was not getting used.

I introduced UMA_HISTOGRAM_ENUMERATION to support the common use
of LinearHistograms to count various enumerated values.

I added a Flags argument to all the FactoryGet routines to help avoid 
needing to call SetFlags each time a new sample is Add()ed.  This also
simplifies the code.

This will all help prepare for a "don't histogram at all" macro setting
so that I can test the impact of the histogram macro calls on
performance (since there are now so many active histograms).

BUG=31206
r=raman.tenneti
Review URL: http://codereview.chromium.org/515033
------------------------------------------------------------------------
r35282 | suzhe@chromium.org | 2009-12-26 10:44:35 +0100 (Sat, 26 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

[Linux] Fix issue 30995: window resizes vertically when scrolling in a long page

BUG=30995
TEST=See bug report.

Review URL: http://codereview.chromium.org/515030
------------------------------------------------------------------------
r35281 | jam@chromium.org | 2009-12-26 09:26:53 +0100 (Sat, 26 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Take out a debugging DCHECK that I had added when switching process startup to be asynchronous.  It sometimes fire when navigating between origins while the task manager is up.  That's the only time it fires, and it is ok in that case, since an IPC message later will update the task manager.

TBR=brettw
Review URL: http://codereview.chromium.org/518001
------------------------------------------------------------------------
r35276 | pfeldman@chromium.org | 2009-12-25 16:06:46 +0100 (Fri, 25 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: restore devtools tests.
BUG=515032
TBR=yurys

------------------------------------------------------------------------
r35275 | apavlov@chromium.org | 2009-12-25 12:22:46 +0100 (Fri, 25 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Forbid reloading the Inspector window.

This CL disables reloading from the system menu, tab popup menu, and page context menu.

BUG=27254,6902
TEST=none

Review URL: http://codereview.chromium.org/391036
------------------------------------------------------------------------
r35272 | hamaji@chromium.org | 2009-12-25 10:33:38 +0100 (Fri, 25 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable 2 tests in DevToolsSanityTest

DevToolsSanityTest.TestExpandScope and DevToolsSanityTest.TestDebugIntrinsicProperties are failing due to timeout.

TBR=pamg
TEST=none
BUG=31149

Review URL: http://codereview.chromium.org/515032
------------------------------------------------------------------------
r35269 | kinuko@chromium.org | 2009-12-25 07:50:57 +0100 (Fri, 25 Dec 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Handle extensions correctly when the default download location is not writable

BUG=28668
TEST=Set the Download location a NON-writable location (such as '/Application' on Mac) in 'Under the Hood' preferences.  Make sure 'Ask where to save...' is kept unchecked.
Go to 'https://tools.google.com/chrome/intl/en/themes/index.html' and click 'apply theme'.
Make sure 'Save as...' dialog opens to ask users for an alternative download location.  Save the file in a writable directory.
Make sure the theme applies (or an extension installation dialog opens for extensions).
Make sure the download does NOT appear in Downloads history.
Make sure it also works for chrome extensions.

TEST=(regression) Make sure theme/extension installation works as expected in normal cases (when the default download location is pointing to a writable location and 'Ask where to save...' is unchecked in 'Under the Hood' preferences.)     Make sure the download does NOT appear in Downloads history.                    Make sure the same thing happens for chrome extensions.
TEST=(regression) Make sure right-clicking on theme/extension files and selecting 'Save link as...' works as a normal download.
Make sure the file is downloaded and saved with the given name.
Make sure the theme does NOT apply and an extension installation dialog does NOT open.
Make sure the download appears in Downloads history.

Review URL: http://codereview.chromium.org/486009
------------------------------------------------------------------------
r35261 | jeremy@chromium.org | 2009-12-24 13:50:29 +0100 (Thu, 24 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ImportSettingsDialog.xib
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm

Remove "Import Cookies" option from "Import Bookmarks & Settings" dialog since we none of the importers support importing cookies and likely won't in the future.

* Modified nib to remove relevant checkbox and move the rest of the UI up to fill the space.

BUG=29125
Test=Open dialog in question, make sure "Import Cookies" option is no longer displayed and that profile import still works correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35069

Review URL: http://codereview.chromium.org/500066
------------------------------------------------------------------------
r35259 | jeremy@chromium.org | 2009-12-24 12:05:21 +0100 (Thu, 24 Dec 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/app/dummy_main_functions.cc
   D /trunk/src/chrome/browser/renderer_host/render_process_host_dummy.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/chrome_dll.gypi
   D /trunk/src/chrome/chrome_exe.gypi
   D /trunk/src/chrome/common/resource_dispatcher_dummy.cc
   D /trunk/src/chrome/common/socket_stream_dispatcher_dummy.cc
   D /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/nacl/sel_main.cc
   D /trunk/src/chrome/nacl.gypi
   D /trunk/src/webkit/glue/webkit_glue_dummy.cc

revert r35237 since it causes Mac unit tests to fail.

"Split more targets from chrome.gyp to add support for building Native Client for 64-bit Windows. "
BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/520006
------------------------------------------------------------------------
r35252 | andybons@chromium.org | 2009-12-24 03:44:26 +0100 (Thu, 24 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Fixes bug where a Page Action icon was not being properly displayed upon page load unless the Omnibar was being forced to redraw (via clicking within it).

BUG=12281
TEST=Load a page that has a page action, observe that it appears without having to select the text in the omnibar.
Review URL: http://codereview.chromium.org/515027
------------------------------------------------------------------------
r35251 | rvargas@google.com | 2009-12-24 02:12:45 +0100 (Thu, 24 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Mark ExtensionApiTest.Storage as flaky.

BUG=27216
TEST=none


Review URL: http://codereview.chromium.org/515026
------------------------------------------------------------------------
r35237 | gregoryd@google.com | 2009-12-24 00:12:08 +0100 (Thu, 24 Dec 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/app/dummy_main_functions.cc
   A /trunk/src/chrome/browser/renderer_host/render_process_host_dummy.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/chrome_dll.gypi
   A /trunk/src/chrome/chrome_exe.gypi
   A /trunk/src/chrome/common/resource_dispatcher_dummy.cc
   A /trunk/src/chrome/common/socket_stream_dispatcher_dummy.cc
   A /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/nacl/sel_main.cc
   A /trunk/src/chrome/nacl.gypi
   A /trunk/src/webkit/glue/webkit_glue_dummy.cc
   M /trunk/src/webkit/glue/websocketstreamhandle_delegate.h

Split more targets from chrome.gyp to add support for building Native Client for 64-bit Windows. 

This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries.
For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. 

TEST=none
BUG=28176

Review URL: http://codereview.chromium.org/384068
------------------------------------------------------------------------
r35232 | gregoryd@google.com | 2009-12-23 22:20:16 +0100 (Wed, 23 Dec 2009) | 13 lines
Changed paths:
   D /trunk/src/chrome/app/dummy_main_functions.cc
   D /trunk/src/chrome/browser/renderer_host/render_process_host_dummy.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/chrome_dll.gypi
   D /trunk/src/chrome/chrome_exe.gypi
   D /trunk/src/chrome/common/resource_dispatcher_dummy.cc
   D /trunk/src/chrome/common/socket_stream_dispatcher_dummy.cc
   D /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/nacl/sel_main.cc
   D /trunk/src/chrome/nacl.gypi
   D /trunk/src/webkit/glue/webkit_glue_dummy.cc
   M /trunk/src/webkit/glue/websocketstreamhandle_delegate.h

Revert 35230 - Split more targets from chrome.gyp to add support for building Native Client for 64bit Windows. 

This CL is required for supporting Native Client on 64bit Windows. On Win64 we will use a 64bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32bit Chrome binaries.
For the targets that are required for both 32bit and 64bit builds, this CL moves the shared parts of the target definitions into targetspecific gypi files (such as base.gypi). New 64bit only targets are added. Since we would like to port as few code as possible at this point, some 64bit targets include less source files or less dependencies than the original 32bit targets. These targets will have nacl_win64 in their name  to emphasize that they should be used for NaCl only. Some 64bit targets are identical to the 32bit targets in everything except for the target platform  these will have only win64 in their name. 

TEST=none
BUG=28176

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34983
Review URL: http://codereview.chromium.org/384068

TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/516013
------------------------------------------------------------------------
r35230 | gregoryd@google.com | 2009-12-23 21:57:26 +0100 (Wed, 23 Dec 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/app/dummy_main_functions.cc
   A /trunk/src/chrome/browser/renderer_host/render_process_host_dummy.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/chrome_dll.gypi
   A /trunk/src/chrome/chrome_exe.gypi
   A /trunk/src/chrome/common/resource_dispatcher_dummy.cc
   A /trunk/src/chrome/common/socket_stream_dispatcher_dummy.cc
   A /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/nacl/sel_main.cc
   A /trunk/src/chrome/nacl.gypi
   A /trunk/src/webkit/glue/webkit_glue_dummy.cc
   M /trunk/src/webkit/glue/websocketstreamhandle_delegate.h

Split more targets from chrome.gyp to add support for building Native Client for 64-bit Windows. 

This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries.
For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. 

TEST=none
BUG=28176

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34983
Review URL: http://codereview.chromium.org/384068
------------------------------------------------------------------------
r35225 | thakis@chromium.org | 2009-12-23 20:39:01 +0100 (Wed, 23 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Double-clicking tabs in the task manager should focus that tab.

BUG=13156
TEST=Hook up task manager. Open it, double-click tabs. They should become active.

Review URL: http://codereview.chromium.org/521005
------------------------------------------------------------------------
r35223 | jar@chromium.org | 2009-12-23 18:42:41 +0100 (Wed, 23 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc

Enable UMA data upload in ChromeFrame

BUG=30508
r=ananta
Review URL: http://codereview.chromium.org/502019
------------------------------------------------------------------------
r35220 | oshima@chromium.org | 2009-12-23 18:14:28 +0100 (Wed, 23 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native/native_view_host_win.h
   M /trunk/src/views/controls/native/native_view_host_wrapper.h
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/widget/widget_gtk.cc

Fix crash/leak issue in native_view_host_gtk.cc.
 * There are two path to NativeViewDetaching and we need to handle them differently.
  1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted.
  2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached().
 * Fix NativeControlGtk not to destroy the native view because it's now destoryed by  NativeViewHostGtk.
 * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached.
 * Added more checks so that test can catch regression.

BUG=26154
TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists.

Review URL: http://codereview.chromium.org/510004
------------------------------------------------------------------------
r35216 | yaar@chromium.org | 2009-12-23 12:55:07 +0100 (Wed, 23 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations.h
   D /trunk/src/webkit/glue/dom_operations_private.h
   D /trunk/src/webkit/glue/dom_serializer.cc
   D /trunk/src/webkit/glue/dom_serializer.h
   D /trunk/src/webkit/glue/dom_serializer_delegate.h
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   D /trunk/src/webkit/glue/entity_map.cc
   D /trunk/src/webkit/glue/entity_map.h
   M /trunk/src/webkit/webkit.gyp

Chromium to use upstream WebPageSerializer instead of glue/DomSerializer.

See corresponding changes in webkit here: https://bugs.webkit.org/show_bug.cgi?id=31737

Review URL: http://codereview.chromium.org/434087
------------------------------------------------------------------------
r35203 | rafaelw@chromium.org | 2009-12-23 04:28:51 +0100 (Wed, 23 Dec 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/incognito_noscript_apitest.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script
   A /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script/change_page_title.js
   A /trunk/src/chrome/test/data/extensions/api_test/incognito_no_script/manifest.json

Don't inject content scripts into incognito browsers.

This patch prevents content scripts from being injected into incognito profile tabs by only injecting into the same profile in which the extension is running.

BUG=21392
TEST=Load chrome/test/data/extensions/api/incognito_no_script and open any url in incognito browser. No page titles should be modified to "modified".

Review URL: http://codereview.chromium.org/502079
------------------------------------------------------------------------
r35202 | rafaelw@chromium.org | 2009-12-23 03:45:48 +0100 (Wed, 23 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/renderer/render_view.cc

(fix merge error).

Reland Disallow chrome.tabs.executeScript from injecting code into gallery

TBR=aa
BUG=30146
TEST=browertest is pending: http://codereview.chromium.org/506066

Original review: http://codereview.chromium.org/501098/

Review URL: http://codereview.chromium.org/518005
------------------------------------------------------------------------
r35201 | rafaelw@chromium.org | 2009-12-23 03:24:58 +0100 (Wed, 23 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/renderer/render_view.cc

Revert "Disallow chrome.tabs.executeScript from injecting code into gallery"

This reverts commit 699f771db23a92c9966fd9af92f0c69886d58136.

TBR=rvargas

Review URL: http://codereview.chromium.org/516005
------------------------------------------------------------------------
r35200 | rafaelw@chromium.org | 2009-12-23 03:15:11 +0100 (Wed, 23 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/renderer/render_view.cc

Disallow chrome.tabs.executeScript from injecting code into gallery

BUG=30146
TEST=browertest is pending: http://codereview.chromium.org/506066

Review URL: http://codereview.chromium.org/501098
------------------------------------------------------------------------
r35197 | finnur@chromium.org | 2009-12-23 01:50:53 +0100 (Wed, 23 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc

Fix utf8 issue in extension action context menu.

BUG=29538
TEST=Extensions with utf8 encoded names should appear correctly named in the context menu.

Review URL: http://codereview.chromium.org/520001
------------------------------------------------------------------------
r35192 | willchan@chromium.org | 2009-12-23 01:11:17 +0100 (Wed, 23 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/browser_main.cc

Revert 35189 (caused test_shell_tests crashes on valgrind bot):
Take 2: Reenable TCMalloc on Linux and make POSIX signal handling async signal safe.
Reinstates r34096 and r34036, which were reverted by r34632 due to hanging ui_tests and browser_tests on bots.
I've been unable to repro on the trybots despite hitting them with a ton of try jobs, so I'm trying on the buildbots again.
BUG=http://crbug.com/30501

Review URL: http://codereview.chromium.org/505068

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/517001
------------------------------------------------------------------------
r35189 | willchan@chromium.org | 2009-12-23 00:57:16 +0100 (Wed, 23 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/browser_main.cc

Take 2: Re-enable TCMalloc on Linux and make POSIX signal handling async signal safe.
Reinstates r34096 and r34036, which were reverted by r34632 due to hanging ui_tests and browser_tests on bots.
I've been unable to repro on the trybots despite hitting them with a ton of try jobs, so I'm trying on the buildbots again.
BUG=http://crbug.com/30501

Review URL: http://codereview.chromium.org/505068
------------------------------------------------------------------------
r35188 | sky@chromium.org | 2009-12-23 00:55:44 +0100 (Wed, 23 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc

Gets the extension popup/bubble to work correctly on Chrome OS.

BUG=30358
TEST=see bug
Review URL: http://codereview.chromium.org/501179
------------------------------------------------------------------------
r35187 | levin@chromium.org | 2009-12-23 00:47:33 +0100 (Wed, 23 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Revert 35184 - This seemed to cause BlacklistedExtensionWillNotInstall
to fail.


TBR=finnur@chromium.org
TEST=BlacklistedExtensionWillNotInstall

Review URL: http://codereview.chromium.org/514001
------------------------------------------------------------------------
r35186 | oshima@chromium.org | 2009-12-23 00:30:18 +0100 (Wed, 23 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/views/widget/widget_gtk.cc

Change chromeos build to use views

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/508025
------------------------------------------------------------------------
r35185 | apatrick@google.com | 2009-12-23 00:28:15 +0100 (Wed, 23 Dec 2009) | 18 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/command_buffer_messages_internal.h
   A /trunk/src/chrome/common/gpu_plugin.cc
   A /trunk/src/chrome/common/gpu_plugin.h
   M /trunk/src/chrome/plugin/command_buffer_stub.cc
   M /trunk/src/chrome/plugin/command_buffer_stub.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/command_buffer_proxy.cc
   M /trunk/src/chrome/renderer/command_buffer_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/gpu/command_buffer/client/cmd_buffer_helper.cc
   M /trunk/src/gpu/command_buffer/client/cmd_buffer_helper.h
   M /trunk/src/gpu/command_buffer/client/cmd_buffer_helper_test.cc
   M /trunk/src/gpu/command_buffer/client/fenced_allocator.h
   M /trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc
   M /trunk/src/gpu/command_buffer/client/gles2_cmd_helper.h
   M /trunk/src/gpu/command_buffer/client/gles2_demo.cc
   M /trunk/src/gpu/command_buffer/client/gles2_implementation.h
   M /trunk/src/gpu/command_buffer/client/id_allocator.h
   M /trunk/src/gpu/command_buffer/client/id_allocator_test.cc
   A /trunk/src/gpu/command_buffer/common/buffer.h
   M /trunk/src/gpu/command_buffer/common/command_buffer.h
   M /trunk/src/gpu/command_buffer/common/command_buffer_mock.h
   M /trunk/src/gpu/command_buffer/common/gles2_cmd_format.h
   M /trunk/src/gpu/command_buffer/common/resource.h
   M /trunk/src/gpu/command_buffer/service/cmd_buffer_engine.h
   M /trunk/src/gpu/command_buffer/service/command_buffer_service.cc
   M /trunk/src/gpu/command_buffer/service/command_buffer_service.h
   M /trunk/src/gpu/command_buffer/service/command_buffer_service_unittest.cc
   M /trunk/src/gpu/command_buffer/service/common_decoder.cc
   M /trunk/src/gpu/command_buffer/service/common_decoder_unittest.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor.h
   M /trunk/src/gpu/command_buffer/service/gpu_processor_mock.h
   M /trunk/src/gpu/command_buffer/service/gpu_processor_unittest.cc
   M /trunk/src/gpu/command_buffer/service/gpu_processor_win.cc
   M /trunk/src/gpu/gpu.gyp
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.cc
   M /trunk/src/gpu/gpu_plugin/gpu_plugin.h
   M /trunk/src/third_party/npapi/bindings/npapi_extensions.h
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   M /trunk/src/webkit/glue/plugins/plugin_constants_win.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_3d_device_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   A /trunk/src/webkit/tools/pepper_test_plugin/DEPS
   A /trunk/src/webkit/tools/pepper_test_plugin/command_buffer_pepper.cc
   A /trunk/src/webkit/tools/pepper_test_plugin/command_buffer_pepper.h
   M /trunk/src/webkit/tools/pepper_test_plugin/main.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp
   M /trunk/src/webkit/tools/pepper_test_plugin/plugin_object.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/plugin_object.h
   M /trunk/src/webkit/tools/pepper_test_plugin/test_page.html
   M /trunk/src/webkit/webkit.gyp

Added Pepper 3D device that instantiates the GPU plugin and sends GLES2 commands to it via a command buffer.

Added API for managing buffers to Pepper 3D device.

Removed DCHECK from WebPluginImpl::SetWindow that checks against a windowless plugin being given a window handle. Please check this! Now an initially windowless plugin instance gets a handle when it requests a Pepper 3D context. Perhaps the window handle should be concealed from the underlying plugin isntance.

Removed enable_gpu gyp variable and C macro. GPU code is always built on windows but not mac or linux. It is enabled at runtime with the --enable-gpu-plugin switch.

Redesigned CommandBuffer interface so it exposes shared memory through a Buffer. This was necessary because Pepper has no notion of shared memory handles. The Buffer exposes the shared memory as both a handle (through base::SharedMemory) and the mapped address and size.

Refactored CommandBufferEngine so mapped shared memory addresses and sizes are returned with a single call rather than two separate calls.
	
Added 3D demo to pepper test plugin.

TEST=try servers
BUG=none

Review URL: http://codereview.chromium.org/367002
------------------------------------------------------------------------
r35184 | finnur@chromium.org | 2009-12-23 00:25:14 +0100 (Wed, 23 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Permission escalation when extension updates should trigger the install warning when enabling the extension through the Extensions Management UI.

BUG=30752
TEST=This requires an extension that autoupdates _and_ increases its permissions. If you ignore the infobar that says it has been disabled, you should still get the Install Warning dialog when you try to enable the extension.

Review URL: http://codereview.chromium.org/501137
------------------------------------------------------------------------
r35180 | oshima@chromium.org | 2009-12-22 23:52:58 +0100 (Tue, 22 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Putting back tests that are excluded in bug 28808

BUG=28808
TEST=Run ui_tests

Review URL: http://codereview.chromium.org/502071
------------------------------------------------------------------------
r35176 | aa@chromium.org | 2009-12-22 23:21:20 +0100 (Tue, 22 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/permissions
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/permissions/empty.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/permissions/frames.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/permissions/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/permissions/script.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/permissions/test.html

Check permissions for chrome.tabs.executeScript() in the
renderer just before injection to avoid races.

BUG=30937

Review URL: http://codereview.chromium.org/509032
------------------------------------------------------------------------
r35175 | sky@chromium.org | 2009-12-22 23:03:45 +0100 (Tue, 22 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes bug on removing last pinned tab that left new tab button
indented too much. When a tab is removed we don't actually remove the
tab until the animation is done. This means the value returned by
GetTabHOffset isn't correct until after the tab is removed. I'm fixing
by forcing layout when done, which triggers calling GetTabHOffset.

The bug exists on both gtk and views, this fixes both.

BUG=22934
TEST=see bug

Review URL: http://codereview.chromium.org/505071
------------------------------------------------------------------------
r35172 | thakis@chromium.org | 2009-12-22 22:42:43 +0100 (Tue, 22 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Mac: Hook up "End process" button on task manager.

Nib changes: Connect "End process" button to action and outlet, allow multiple selection on the table, make TaskManagerWindowController the delegate of the table view.

BUG=13156
TEST=Hook up task manager in menu, open it. Button should be enabled if at least one task is selected, clicking the button should terminate the selected processes.

Review URL: http://codereview.chromium.org/505073
------------------------------------------------------------------------
r35169 | zork@chromium.org | 2009-12-22 22:14:53 +0100 (Tue, 22 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc

Fix a crash when you use incorrect credentials to log into bookmark sync.

BUG=none
TEST=Attempt to sync your bookmarks, but supply an incorrect password.

Review URL: http://codereview.chromium.org/501177
------------------------------------------------------------------------
r35166 | xiyuan@chromium.org | 2009-12-22 21:34:42 +0100 (Tue, 22 Dec 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/app_menu_model.cc
   M /trunk/src/chrome/browser/app_menu_model.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc

Fix racing condition that blocks profiles menu showing up

Chrome should show profiles menu when "enable-udd-profiles" is supplied
on command line. This is broken while refactoring app menu code from
ToolbarView into AppMenuModel. Previously, the profile submenu model is
kept in ToolbarView and profiles menu would show up on 2nd time app menu
showing up. After the refactoring, profile menu is moved into
AppMenuModel, which is re-created everytime before we show app menu. In
AppMenuModel, it requests profiles data from GetProfilesHelper which
will later invoke OnGetProfilesDone. However, app menu is created on the
UI thread and blocks the callback until it shows up. This makes the
profiles mneu empty.
The fix is to leverage an existing profile list in BrowserProcess. When
"enable-udd-profiles" is on, BrowserInit will get the initial profile
list and NewProfileDialog will refresh it if user creates new profile.
And AppMenuModel just use the list to populate the profile menu.

BUG=30417
TEST=Verify profiles menu exists when "enable-udd-profiles" is on command line for issue 30417.

Review URL: http://codereview.chromium.org/503062
------------------------------------------------------------------------
r35165 | avi@chromium.org | 2009-12-22 21:11:40 +0100 (Tue, 22 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_view.mm

Make our toolbar tell accessibility it is a toolbar.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/501176
------------------------------------------------------------------------
r35157 | avi@chromium.org | 2009-12-22 19:54:00 +0100 (Tue, 22 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

The bookmark bar with zero height should be explicitly hidden. This is required for parts of the system not taking visibility into account (e.g. accessibility)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/506078
------------------------------------------------------------------------
r35151 | sky@chromium.org | 2009-12-22 17:15:09 +0100 (Tue, 22 Dec 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes possible crash in closing window. The sequence when closing a
window ends like:

~TabStrip
~View
~Tab
~Tab::TabContextMenuContents
~TabStrip::TabContextMenuContents
TabStrip::StopAllHighlighting

This is problematic as StopAllHighlighting references objects whose
destructor has already run. This crashes on Linux, but not on windows
(probably because of different implementation of stl).

I've fixed this by deleting all child views from ~TabStrip so that if
they end up calling into the TabStrip every is still valid.

BUG=none
TEST=create a couple of tabs, bring up the context menu for each,
     close the context menu, close the window and make sure you don't get a
     crash. Be sure and test this on both windows and Chrome OS.

Review URL: http://codereview.chromium.org/505066
------------------------------------------------------------------------
r35139 | brettw@chromium.org | 2009-12-22 06:12:32 +0100 (Tue, 22 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   A /trunk/src/chrome/browser/renderer_host/backing_store_gl.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_manager_glx.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_manager_glx.h

Create an OpenGL backing store. This version works for all the basic operations
except for scrolling. There are a lot of future enhancements which I have put
TODOs in to cover.

This is currently not built with Chrome as I'm not checking in the build file
changes yet.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/502001
------------------------------------------------------------------------
r35138 | viettrungluu@chromium.org | 2009-12-22 06:06:20 +0100 (Tue, 22 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_mac.mm

Revert 35137 - Getting perf numbers. Will revert.

BUG=none
TEST=none
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/502099

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/504080
------------------------------------------------------------------------
r35137 | viettrungluu@chromium.org | 2009-12-22 05:52:56 +0100 (Tue, 22 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_mac.mm

Getting perf numbers. Will revert.

BUG=none
TEST=none
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/502099
------------------------------------------------------------------------
r35131 | jhawkins@chromium.org | 2009-12-22 03:02:58 +0100 (Tue, 22 Dec 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/form_group.h
   M /trunk/src/chrome/chrome_browser.gypi

Add FormGroup, an interface that represents a collection of form fields grouped by type.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/509014
------------------------------------------------------------------------
r35122 | sky@chromium.org | 2009-12-22 01:34:08 +0100 (Tue, 22 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Fixes bug in tabstrip that could result in no tooltip text for pinned
tab. This happened because we weren't setting the title_bounds_, which
is used to determine if a tab should have tooltip text.

BUG=26079
TEST=see bug

Review URL: http://codereview.chromium.org/507062
------------------------------------------------------------------------
r35114 | davemoore@chromium.org | 2009-12-22 00:31:07 +0100 (Tue, 22 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/browser/chromeos/login_manager_view.h

Remove title from cros login window

Review URL: http://codereview.chromium.org/501163
------------------------------------------------------------------------
r35112 | sky@chromium.org | 2009-12-21 23:12:14 +0100 (Mon, 21 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Attempt 2 at landing this:

Removes TabStrip::CanUpdateDisplay as it lead to crashes on the
windows side.

BUG=24132
TEST=none

Review URL: http://codereview.chromium.org/502064
------------------------------------------------------------------------
r35109 | andybons@chromium.org | 2009-12-21 22:55:36 +0100 (Mon, 21 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Fixes a bug where an ExtensionPopupController object's pointer was never being nil'd out when it resigned its key state, leading to a obj_msgSend from a dirty pointer. Also makes sure that other areas of Page Action code are properly using nil instead of NULL where necessary.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/508010
------------------------------------------------------------------------
r35108 | skrul@chromium.org | 2009-12-21 22:48:40 +0100 (Mon, 21 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Differentiate between ADD and CHANGED when adding new autofill entries.
Adding a new autofill entry can either result in an ADD (when the name/value par was never seen before) or with an UPDATE (when the name/value pair already exists).

Review URL: http://codereview.chromium.org/507053
------------------------------------------------------------------------
r35102 | mark@chromium.org | 2009-12-21 21:41:52 +0100 (Mon, 21 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h

Make AutocompleteTextField adhere to NSTextViewDelegate.

BUG=30154
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/501156
------------------------------------------------------------------------
r35101 | pkasting@chromium.org | 2009-12-21 21:36:53 +0100 (Mon, 21 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc

Make View Source and Search Web For inherit group properly.  Original patch by John Spiegel (see http://codereview.chromium.org/466086 ), r=me.

BUG=1922
TEST="View Page Source" in context menu should open to the immediate right of the current tab.
------------------------------------------------------------------------
r35100 | jrg@chromium.org | 2009-12-21 21:34:26 +0100 (Mon, 21 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_unittest.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

Fix some valgrind failures.
BUG=http://crbug.com/18158, http://crbug.com/30381, http://crbug.com/30371, http://crbug.com/30373
TEST=valgrind bots green.  Bookmark bubble still works.

Review URL: http://codereview.chromium.org/503064
------------------------------------------------------------------------
r35092 | thakis@chromium.org | 2009-12-21 18:44:20 +0100 (Mon, 21 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_mac.mm
   A /trunk/src/chrome/browser/mach_broker_mac.cc
   A /trunk/src/chrome/browser/mach_broker_mac.h
   A /trunk/src/chrome/browser/mach_broker_mac_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: Create a pid->task_t mapping in the browser process.

Since nothing writes to this map in the browser atm, this does not have any visible effect.

BUG=13156,25454
TEST=unittest

Review URL: http://codereview.chromium.org/501138
------------------------------------------------------------------------
r35091 | avi@chromium.org | 2009-12-21 18:18:57 +0100 (Mon, 21 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Make the tab strip and tabs first-class accessibility objects.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/504059
------------------------------------------------------------------------
r35089 | pfeldman@chromium.org | 2009-12-21 17:24:43 +0100 (Mon, 21 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: fix devtools sanity test that was affected by the inspector redesign.
TBR=yurys

------------------------------------------------------------------------
r35079 | suzhe@chromium.org | 2009-12-21 06:59:08 +0100 (Mon, 21 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   A /trunk/src/chrome/browser/gtk/gtk_expanded_container.cc
   A /trunk/src/chrome/browser/gtk/gtk_expanded_container.h
   A /trunk/src/chrome/browser/gtk/gtk_expanded_container_unittest.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Re-land http://codereview.chromium.org/507022.

Fix failed Linux Views and ChromeOS build.

BUG=11258
TEST=See bug report.

Review URL: http://codereview.chromium.org/503065
------------------------------------------------------------------------
r35078 | darin@chromium.org | 2009-12-21 05:42:05 +0100 (Mon, 21 Dec 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC.

The combined IPC means that scrolling only requires one transport DIB instead
of two.  Previously, we'd use one in the ScrollRect IPC to pass up the pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC to
pass up the pixels for the updated scroll bar rendering.  Now all paints are
done using a single transport DIB.

Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects.  Then only those rects are copied from the backing store.

The same optimization is not done for Linux or Mac yet.

R=brettw
BUG=29591
TEST=none

Originally reviewed at http://codereview.chromium.org/506013

Review URL: http://codereview.chromium.org/509005
------------------------------------------------------------------------
r35070 | jeremy@chromium.org | 2009-12-20 13:51:01 +0100 (Sun, 20 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ImportSettingsDialog.xib
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm

Revert r35069

Review URL: http://codereview.chromium.org/509002
------------------------------------------------------------------------
r35069 | jeremy@chromium.org | 2009-12-20 12:23:54 +0100 (Sun, 20 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/ImportSettingsDialog.xib
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.h
   M /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm

Remove "Import Cookies" option
and corresponding strings from "Import Bookmarks & Settings" dialog since we none of the importers support importing cookies and likely won't in the future.

* Removed IDS_IMPORT_COOKIES string since it isn't used by any other part of the change.
* Modified nib to remove relevant checkbox and move the rest of the UI up to fill the space.

BUG=29125
Test=Open dialog in question, make sure "Import Cookies" option is no longer displayed and that profile import still works correctly.

Review URL: http://codereview.chromium.org/500066
------------------------------------------------------------------------
r35065 | viettrungluu@chromium.org | 2009-12-20 08:42:23 +0100 (Sun, 20 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

Mac: Fourth half of CL 481012 (reverted at r35038).

This introduces code to properly enable DnD to the Omnibox without adding a
trivial |-updateDragTypeRegistration| to |AutocompleteTextFieldEditor| (so that
it falls through to the text field), but rather letting the field editor accept
DnD directly.

We'll see whether or not it turns Mac Perf(2) red (by regressing startup times).

BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org

Review URL: http://codereview.chromium.org/500157
------------------------------------------------------------------------
r35063 | viettrungluu@chromium.org | 2009-12-20 08:17:14 +0100 (Sun, 20 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

Revert 35062 - Mac: Third half of CL 481012 (reverted at r35038). Will it blend?

This is an experiment. I expect the startup times to regress and Mac Perf(2) to
turn red, at which point I'll revert this. If not, the TEST below applies.

[Yes, indeed, it turned red. Crazy!]

BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.

Review URL: http://codereview.chromium.org/500155

TBR=viettrungluu@chromium.org, shess@chromium.org
Review URL: http://codereview.chromium.org/502086
------------------------------------------------------------------------
r35062 | viettrungluu@chromium.org | 2009-12-20 07:29:16 +0100 (Sun, 20 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

Mac: Third half of CL 481012 (reverted at r35038). Will it blend?

This is an experiment. I expect the startup times to regress and Mac Perf(2) to
turn red, at which point I'll revert this. If not, the TEST below applies.

BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org

Review URL: http://codereview.chromium.org/500155
------------------------------------------------------------------------
r35061 | viettrungluu@chromium.org | 2009-12-20 05:46:50 +0100 (Sun, 20 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Second half of CL 481012 (reverted at r35038).

CL 481012 was: Mac: implement DnD of URLs onto Omnibox.

It was reverted due to a startup (perf) regression. The first half was re-committed at r35044. (Committing this at r35053, reverting at r35054, showed that this CL really does cause a regression.)

I don't know what causes this, so I'm committing it with the functionality turned off. So all that's changed is that some methods have been added and some protocols conformed to. If startup test times regress, something really weird is going on.

BUG=24631
TEST=Mac perf(2) doesn't turn red.
TBR=shess@chromium.org

Review URL: http://codereview.chromium.org/508001
------------------------------------------------------------------------
r35057 | cpu@chromium.org | 2009-12-20 04:57:10 +0100 (Sun, 20 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_test.h
   A /trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc
   A /trunk/src/chrome/browser/diagnostics/recon_diagnostics.h
   M /trunk/src/chrome/chrome_browser.gypi

Add some diagnostic test to diagnostic mode
- Move the one existing test to final location
- Test more critical paths to be accessilbe and writable
- Test the OS version
- Test user or systemwide install type

BUG=27885
TEST=unit test updated


Review URL: http://codereview.chromium.org/504028
------------------------------------------------------------------------
r35054 | viettrungluu@chromium.org | 2009-12-19 19:06:11 +0100 (Sat, 19 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Revert 35053 - Second half of CL 481012 (reverted at r35038). Will revert if Mac perf turns red.

Well, it turned red.

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/502084
------------------------------------------------------------------------
r35053 | viettrungluu@chromium.org | 2009-12-19 18:20:30 +0100 (Sat, 19 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Second half of CL 481012 (reverted at r35038). Will revert if Mac perf turns red.

CL 481012 was: Mac: implement DnD of URLs onto Omnibox.

It was reverted due to a startup (perf) regression. The first half was re-committed at r35044. I can't for the life of me reproduce the regression locally, so I'm re-committing and watching the bots.

BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org

Review URL: http://codereview.chromium.org/500153
------------------------------------------------------------------------
r35044 | viettrungluu@chromium.org | 2009-12-19 07:11:06 +0100 (Sat, 19 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.h
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm

Half of CL 481012 (reverted at r35038).

CL 481012 was: Mac: implement DnD of URLs onto Omnibox.

This is the half consisting of mild refactoring and no new functionality.

BUG=none
TEST=Dragging and dropping URLs onto the tab strip should still work as before. More important is whether this regresses the startup tests.
TBR=shess@chromium.org

Review URL: http://codereview.chromium.org/505057
------------------------------------------------------------------------
r35043 | viettrungluu@chromium.org | 2009-12-19 05:50:04 +0100 (Sat, 19 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/common/mach_ipc_mac.h
   M /trunk/src/chrome/common/mach_ipc_mac.mm
   M /trunk/src/chrome/test/chrome_process_util.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc

Revert 35025 - Revert 34994, maybe it regressed startup perf  Fix cpu/memory measurements on OS X.

Right now, this only works for the current process; support for child processes will be added in a later CL.

BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.

Review URL: http://codereview.chromium.org/500118

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/505056
------------------------------------------------------------------------
r35038 | thakis@chromium.org | 2009-12-19 04:30:19 +0100 (Sat, 19 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.h
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm

Revert 34998, more stabbing in the dark to find a perf regression - Mac: implement DnD of URLs onto Omnibox.

(DnD of text coming in another patch.)

BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.

Review URL: http://codereview.chromium.org/481012

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/501135
------------------------------------------------------------------------
r35030 | mark@chromium.org | 2009-12-19 03:09:40 +0100 (Sat, 19 Dec 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keystone_glue.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/tools/build/mac/keystone_install.sh
   M /trunk/src/chrome/tools/build/mac/keystone_install_test.sh

Adapt Chrome to use KeystoneRegistration 1.0.7.1306.  Use "tag path" and "tag
key" to direct Keystone to use a tag stored in the application as opposed to
in its ticket.

BUG=30730
TEST= - ksadmin --print-ticket --productid com.google.Chrome should show
        tagPath pointing to GC.app/Contents/Info.plist, and
        tagKey of KSChannelID;
      - ksadmin --print-tag --productid com.google.Chrome should show the
        value of the KSChannelID key in GC.app/Contents/Info.plist;
        this should be the tag that is used for auto-updates
     The above steps should be validated after the following operations:
      - launching Chrome when on a user ticket,
      - promoting Chrome from a user ticket to a system ticket, and
      - when a Chrome update is applied (using this version of
        keystone_install.sh) when on either a user or a system ticket.
     The tagPath and tagKey will NOT be set when launching Chrome on a
     system (promoted) ticket, but they WILL be set when the ticket is
     initially promoted and also when an update is applied using this version
     of keystone_install.sh.
Review URL: http://codereview.chromium.org/506061
------------------------------------------------------------------------
r35029 | jrg@chromium.org | 2009-12-19 03:07:02 +0100 (Sat, 19 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Remove svn revision from branded builds.
BUG=htp://crbug.com/30173

Review URL: http://codereview.chromium.org/504065
------------------------------------------------------------------------
r35028 | cpu@chromium.org | 2009-12-19 02:48:30 +0100 (Sat, 19 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/result_codes.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc

Reset the dr key if the toast experiment is cancelled.

TEST= run the toast experiment and cancel it. Then look at the dr key on 
HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463C-AFF1-A69D9E530F96}
should be "0"


BUG=30799


Review URL: http://codereview.chromium.org/502077
------------------------------------------------------------------------
r35026 | jcampan@chromium.org | 2009-12-19 02:35:05 +0100 (Sat, 19 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h

In the password option pages, a table is used.
On deletion, the model goes away before the actual table,
causing the table to access a deleted object.
This CL fixes it.

BUG=30791
TEST=Bring up the password dialog (in the options dialog, 'Personal Stuff', 'Show saved passwords').
Review URL: http://codereview.chromium.org/503063
------------------------------------------------------------------------
r35025 | thakis@chromium.org | 2009-12-19 02:31:03 +0100 (Sat, 19 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/common/mach_ipc_mac.h
   M /trunk/src/chrome/common/mach_ipc_mac.mm
   M /trunk/src/chrome/test/chrome_process_util.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc

Revert 34994, maybe it regressed startup perf - Fix cpu/memory measurements on OS X.

Right now, this only works for the current process; support for child processes will be added in a later CL.

BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.

Review URL: http://codereview.chromium.org/500118

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
------------------------------------------------------------------------
r35020 | kkania@chromium.org | 2009-12-19 02:27:51 +0100 (Sat, 19 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/base/gfx/size.cc
   M /trunk/src/base/gfx/size.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_test_util.h
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_mac.mm
   M /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc

[Mac] Port browser action popup test to mac.
BUG=29710
TEST=none
Review URL: http://codereview.chromium.org/506069
------------------------------------------------------------------------
r35017 | pkasting@chromium.org | 2009-12-19 02:12:15 +0100 (Sat, 19 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Allow app/popup Windows to be programmatically sent a CURRENT_TAB navigation instead of having it change to a tabbed browser.  Original patch by David Garcia (see http://codereview.chromium.org/505013 ), r=me, tweaked.

BUG=20529
TEST=none
------------------------------------------------------------------------
r35015 | zork@google.com | 2009-12-19 01:54:42 +0100 (Sat, 19 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc

Fix a release mode crash.  Work should not be done inside of DCHECK()s.

BUG=none
TEST=run sync_unit_tests in a release build.
Review URL: http://codereview.chromium.org/500147
------------------------------------------------------------------------
r35013 | estade@chromium.org | 2009-12-19 01:38:27 +0100 (Sat, 19 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc

add unit test for ExtensionURLToRelativeFilePath

BUG=30749
TEST=this patch

Review URL: http://codereview.chromium.org/507054
------------------------------------------------------------------------
r35011 | jhawkins@chromium.org | 2009-12-19 01:28:55 +0100 (Sat, 19 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_field.cc

Set the address field type based on how many address fields we encountered.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/501092
------------------------------------------------------------------------
r35003 | mpcomplete@chromium.org | 2009-12-19 00:25:45 +0100 (Sat, 19 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix a number of issues with extension disable-on-update:
- No longer create 2 infobars.
- No longer leak infobars. This fixes a crash.
- Update the disabled list before sending the notification, so that the
extension management page updates properly.

BUG=30407

Review URL: http://codereview.chromium.org/501104
------------------------------------------------------------------------
r34998 | viettrungluu@chromium.org | 2009-12-18 23:56:08 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/url_drop_target.h
   M /trunk/src/chrome/browser/cocoa/url_drop_target.mm

Mac: implement DnD of URLs onto Omnibox.

(DnD of text coming in another patch.)

BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.

Review URL: http://codereview.chromium.org/481012
------------------------------------------------------------------------
r34994 | thakis@chromium.org | 2009-12-18 23:48:19 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/common/mach_ipc_mac.h
   M /trunk/src/chrome/common/mach_ipc_mac.mm
   M /trunk/src/chrome/test/chrome_process_util.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc

Fix cpu/memory measurements on OS X.

Right now, this only works for the current process; support for child processes will be added in a later CL.

BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.

Review URL: http://codereview.chromium.org/500118
------------------------------------------------------------------------
r34993 | zork@google.com | 2009-12-18 23:40:42 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h

Continuing migration of directory_backing_store.cc to Chromium sqlite wrappers.

BUG=none
TEST=Run sync_unit_tests

Review URL: http://codereview.chromium.org/500114
------------------------------------------------------------------------
r34992 | andybons@chromium.org | 2009-12-18 23:40:00 +0100 (Fri, 18 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc

[Mac] Implements popups for Page Actions, plus fixes a leak within the Browser Action popup class.

BUG=12281
TEST=Install the RSS feed page action extension. Go to a site with multiple feeds on the page, like http://ask.metafilter.com, observe a popup upon clicking the page action icon.
Review URL: http://codereview.chromium.org/500138
------------------------------------------------------------------------
r34990 | slightlyoff@chromium.org | 2009-12-18 23:09:12 +0100 (Fri, 18 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/build/common.gypi
   D /trunk/src/chrome/app/dummy_main_functions.cc
   D /trunk/src/chrome/browser/renderer_host/render_process_host_dummy.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/chrome_common.gypi
   D /trunk/src/chrome/chrome_dll.gypi
   D /trunk/src/chrome/chrome_exe.gypi
   D /trunk/src/chrome/common/resource_dispatcher_dummy.cc
   D /trunk/src/chrome/common/socket_stream_dispatcher_dummy.cc
   D /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/nacl/sel_main.cc
   D /trunk/src/chrome/nacl.gypi
   D /trunk/src/webkit/glue/webkit_glue_dummy.cc
   M /trunk/src/webkit/glue/websocketstreamhandle_delegate.h

Revert 34983 - Split more targets from chrome.gyp to add support for building Native Client for 64bit Windows. 

This CL is required for supporting Native Client on 64bit Windows. On Win64 we will use a 64bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32bit Chrome binaries.
For the targets that are required for both 32bit and 64bit builds, this CL moves the shared parts of the target definitions into targetspecific gypi files (such as base.gypi). New 64bit only targets are added. Since we would like to port as few code as possible at this point, some 64bit targets include less source files or less dependencies than the original 32bit targets. These targets will have nacl_win64 in their name  to emphasize that they should be used for NaCl only. Some 64bit targets are identical to the 32bit targets in everything except for the target platform  these will have only win64 in their name. 

TEST=none
BUG=28176
Review URL: http://codereview.chromium.org/384068

TBR=gregoryd@google.com

Review URL: http://codereview.chromium.org/501125
------------------------------------------------------------------------
r34986 | skrul@chromium.org | 2009-12-18 22:08:43 +0100 (Fri, 18 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc

Bring the remove notifications up from the WebDatabase to the WebDataService.

Review URL: http://codereview.chromium.org/505046
------------------------------------------------------------------------
r34985 | ananta@chromium.org | 2009-12-18 22:07:53 +0100 (Fri, 18 Dec 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   A /trunk/src/chrome_frame/test/data/multiple_cf_instances_main.html
   A /trunk/src/chrome_frame/test/data/multiple_cf_instances_test.html

Multiple chrome frame activex controls should instantiate and navigate correctly in IE. This was not
the case due to a race condition between put_src getting called for subsequent activex instances
and the external tab to hold the chrome frame instance getting created. 

Fix is to pass in the URL if we have it when the automation client is initialized to launch the chrome
automation server. If not we navigate when the external tab is created. To achieve this we stuff in
all relevant parameters into a structure which is populated when the automation client is initialized.

I also changed the CreateExternalTab message to carry the referrer for the initial navigation.

Fixes http://code.google.com/p/chromium/issues/detail?id=28236
Test=added unit tests for the same. The firefox one is not working at this point. Disabled this test
     for now while I debug it.

Bug=28236

Review URL: http://codereview.chromium.org/500123
------------------------------------------------------------------------
r34983 | gregoryd@google.com | 2009-12-18 21:55:37 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/build/common.gypi
   A /trunk/src/chrome/app/dummy_main_functions.cc
   A /trunk/src/chrome/browser/renderer_host/render_process_host_dummy.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/chrome_common.gypi
   A /trunk/src/chrome/chrome_dll.gypi
   A /trunk/src/chrome/chrome_exe.gypi
   A /trunk/src/chrome/common/resource_dispatcher_dummy.cc
   A /trunk/src/chrome/common/socket_stream_dispatcher_dummy.cc
   A /trunk/src/chrome/common_constants.gypi
   M /trunk/src/chrome/nacl/sel_main.cc
   A /trunk/src/chrome/nacl.gypi
   A /trunk/src/webkit/glue/webkit_glue_dummy.cc
   M /trunk/src/webkit/glue/websocketstreamhandle_delegate.h

Split more targets from chrome.gyp to add support for building Native Client for 64-bit Windows. 

This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries.
For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. 

TEST=none
BUG=28176
Review URL: http://codereview.chromium.org/384068
------------------------------------------------------------------------
r34981 | akalin@chromium.org | 2009-12-18 21:48:50 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Added confirmation dialog for stopping syncing.

Added some explanatory comments.

BUG=30642
TEST=manual testing

Review URL: http://codereview.chromium.org/501108
------------------------------------------------------------------------
r34975 | avi@chromium.org | 2009-12-18 20:56:46 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm

Need to allow accessibility exceptions to flow to allow the Accessibility Verifier to work.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/503048
------------------------------------------------------------------------
r34972 | arv@chromium.org | 2009-12-18 20:23:55 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js

Adds bookmarks.getRecent that returns the recently bookmarked items.

BUG=None
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.FLAKY_Bookmarks

Review URL: http://codereview.chromium.org/503053
------------------------------------------------------------------------
r34969 | zork@chromium.org | 2009-12-18 19:59:46 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc

Update DirectoryBackingStore::SaveChanges() to use Chromium's SQlite helper functions.

BUG=none
TEST=Run sync_unit_tests and observe that they pass.

Review URL: http://codereview.chromium.org/502061
------------------------------------------------------------------------
r34968 | cira@chromium.org | 2009-12-18 19:53:05 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/tools/wine_valgrind/chromium-valgrind-suppressions

Fix memory leak on ExtensionMessageBundle.
Revert valgrind suppresion.

BUG=30762

Review URL: http://codereview.chromium.org/501115
------------------------------------------------------------------------
r34963 | pamg@google.com | 2009-12-18 19:32:21 +0100 (Fri, 18 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

Unit tests for page action icons on Mac.

BUG=12281
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/500110
------------------------------------------------------------------------
r34957 | cira@chromium.org | 2009-12-18 18:07:40 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Fixes crash when message IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW has non-ASCII characters.

BUG=30736
TEST=Open chrome with --lang=sr and try to pack extension. It shouldn't crash, and files with be generated.

Review URL: http://codereview.chromium.org/503051
------------------------------------------------------------------------
r34955 | rsesek@chromium.org | 2009-12-18 17:46:55 +0100 (Fri, 18 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   D /trunk/src/chrome/browser/gtk/gtk_expanded_container.cc
   D /trunk/src/chrome/browser/gtk/gtk_expanded_container.h
   D /trunk/src/chrome/browser/gtk/gtk_expanded_container_unittest.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 34954 - Fix issue 11258: Linux: gracefully handle small browser window

TODO: Make location bar to be freely shrinkable. Will be addressed in another CL.

BUG=11258
TEST=See bug report.

Review URL: http://codereview.chromium.org/507022

TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/502073
------------------------------------------------------------------------
r34954 | suzhe@chromium.org | 2009-12-18 17:33:55 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   A /trunk/src/chrome/browser/gtk/gtk_expanded_container.cc
   A /trunk/src/chrome/browser/gtk/gtk_expanded_container.h
   A /trunk/src/chrome/browser/gtk/gtk_expanded_container_unittest.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Fix issue 11258: Linux: gracefully handle small browser window

TODO: Make location bar to be freely shrinkable. Will be addressed in another CL.

BUG=11258
TEST=See bug report.

Review URL: http://codereview.chromium.org/507022
------------------------------------------------------------------------
r34953 | rsesek@chromium.org | 2009-12-18 16:52:54 +0100 (Fri, 18 Dec 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Revert 34951 - Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC.

The combined IPC means that scrolling only requires one transport DIB instead
of two.  Previously, we'd use one in the ScrollRect IPC to pass up the pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC to
pass up the pixels for the updated scroll bar rendering.  Now all paints are
done using a single transport DIB.

Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects.  Then only those rects are copied from the backing store.

The same optimization is not done for Linux or Mac yet.

R=brettw
BUG=29591
TEST=none

Review URL: http://codereview.chromium.org/506013

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/506075
------------------------------------------------------------------------
r34952 | viettrungluu@chromium.org | 2009-12-18 16:37:59 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm

Mac: correctly fix Omnibox drawing (again), and make the focus ring come back.

(Somehow I managed to miss the drawing code I should have modified before.)

BUG=30188,30716
TEST=Make sure Omnibox border draws correctly (zoom in closely and look) and matches the buttons; do so with a wide variety of themes. Make sure the blue focus ring appears when appropriate.

Review URL: http://codereview.chromium.org/501103
------------------------------------------------------------------------
r34951 | darin@chromium.org | 2009-12-18 16:37:08 +0100 (Fri, 18 Dec 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC.

The combined IPC means that scrolling only requires one transport DIB instead
of two.  Previously, we'd use one in the ScrollRect IPC to pass up the pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC to
pass up the pixels for the updated scroll bar rendering.  Now all paints are
done using a single transport DIB.

Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects.  Then only those rects are copied from the backing store.

The same optimization is not done for Linux or Mac yet.

R=brettw
BUG=29591
TEST=none

Review URL: http://codereview.chromium.org/506013
------------------------------------------------------------------------
r34942 | thakis@chromium.org | 2009-12-18 09:56:18 +0100 (Fri, 18 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc

Add a keyboard shortcut on Escape that emits the IDC_STOP command.

BUG=20916
TEST=Load something big (http://cnn.com/) and hit escape. Page load will stop.

Review URL: http://codereview.chromium.org/491023
Patch from Jochen Eisinger.
------------------------------------------------------------------------
r34938 | atwilson@chromium.org | 2009-12-18 07:05:08 +0100 (Fri, 18 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/chrome_tests.gypi

Enable login prompt (http auth) tests on non-windows platforms

TEST=LoginPromptTest.*

Review URL: http://codereview.chromium.org/501091
------------------------------------------------------------------------
r34929 | akalin@chromium.org | 2009-12-18 04:49:17 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Added switch to invalidate sync login.

BUG=none
TEST=manual testing

Review URL: http://codereview.chromium.org/500120
------------------------------------------------------------------------
r34926 | estade@chromium.org | 2009-12-18 03:40:24 +0100 (Fri, 18 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds the cmdline "--new-window" that instructs the init sequence
to open a new window instead of reusing the most recent tab for
opening cmdline URLs.

BUG=2843
TEST=Run with --new-window switch and confirm that a new window pops up 
patch by <clemens [at] endorphin dot org>
original review: <http://codereview.chromium.org/464060>

Review URL: http://codereview.chromium.org/503023
------------------------------------------------------------------------
r34925 | estade@chromium.org | 2009-12-18 03:39:47 +0100 (Fri, 18 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h

gtk: Browser action dragging fixes

1) fix crasher triggered any time a drag from a different source hovers over the browser action bar.
2) fix graphical issue where changes to the ordering could possibly take a few seconds to propagate to other browser windows.

BUG=30639
TEST=a) drag a bookmark over the browser action toolbar, don't crash
     b) open two windows. drag a browser action around, keep holding left mouse button and drag to a distant part of the screen, then release. The positional change should instantly take effect in the second browser window.

Review URL: http://codereview.chromium.org/506065
------------------------------------------------------------------------
r34924 | estade@chromium.org | 2009-12-18 03:39:33 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h

Limit the size of extension views on linux.

BUG=26162
TEST=<img height="100%">

Review URL: http://codereview.chromium.org/505047
------------------------------------------------------------------------
r34923 | estade@chromium.org | 2009-12-18 03:39:16 +0100 (Fri, 18 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/extensions/convert_user_script.cc
   M /trunk/src/chrome/browser/extensions/convert_user_script_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.h
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Extensions: file handling clean up.

- remove various invalid uses of ASCII functions
- properly escape resource requests
- clean up file path handling

Some work remains to be done on the last bullet point but this is enough to fix the bug.

BUG=30509
TEST=see bug

Review URL: http://codereview.chromium.org/501046
------------------------------------------------------------------------
r34921 | rafaelw@chromium.org | 2009-12-18 03:17:24 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Don't show download arrow animation for extensions.

This patch exempts non-theme extensions (extensions not downloaded from theme minigallery) from showing the arrow download animation.

BUG=29632
TEST=Install extension from the gallery. No download arrow should be shown. Install theme from https://tools.google.com/chrome/intl/en/themes/index.html. Download arrow should be shown. Download random other stuff -> download arrow should be shown.

Review URL: http://codereview.chromium.org/504031
------------------------------------------------------------------------
r34917 | akalin@chromium.org | 2009-12-18 02:45:50 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

gtk/sync: Use GetStatus when it is not necessary to know the status labels.

BUG=none
TEST=compiles

( patch by thiago.farina@gmail.com : http://codereview.chromium.org/503009 )

Review URL: http://codereview.chromium.org/504036
------------------------------------------------------------------------
r34915 | yusukes@google.com | 2009-12-18 02:33:49 +0100 (Fri, 18 Dec 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.cpp

Returns an error immediately without sending IPC message when a font family name to resolve is too long.

This change is important when a site has @font-face rule like:

  // http://paulirish.com/webkit-fontface-hang.html
  @font-face{font-family:testfont;src:url('data:font/ttf;base64,AA.....<<looooooooooong base64 data>>.....aQ==')}

In such a case, WebCore first calls SkFontHost::CreateTypeface() with the (possibly very long) data-uri string itself, then calls SkFontHost::CreateTypefaceFromStream() with decoded byte stream. Since render_sandbox_host_linux.cc just ignores too long IPC message, the renderer process could block indefinitely waiting for a reply inside recvmsg() system call called from SkFontHost::CreateTypeface().

I'm not sure if the WebCore behavior (i.e. calling CreateTypeface with data-uris) is reasonable, but I believe the Skia part is better to be fixed anyway. Non data-uri font family names could be very long too:

  @font-face{font-family:testfont;src:local('AA........AA');}

BUG=29861
TEST=First, set up your Linux SUID Sandbox binary: http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment. Then start Chromium and visit http://paulirish.com/webkit-fontface-hang.html or http://typekit.com/. Verify that the renderer does not freeze.

Review URL: http://codereview.chromium.org/507037
------------------------------------------------------------------------
r34908 | feldstein@chromium.org | 2009-12-18 01:43:10 +0100 (Fri, 18 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Make history page more responsive by rendering items incrementally instead of wiping out the page multiple times.

Code review 501044
BUG=30020
TEST=Navigate through history to make sure it still works.  On windows, have a spares history with multiple days, and click one of the first entries while the rest are still loading and make sure the click is not lost.

------------------------------------------------------------------------
r34907 | sky@chromium.org | 2009-12-18 01:41:45 +0100 (Fri, 18 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Changes Init to use ASSERT_EQ, rather than true.

BUG=none
TEST=none
TBR=skrul

Review URL: http://codereview.chromium.org/501102
------------------------------------------------------------------------
r34905 | sky@chromium.org | 2009-12-18 01:27:37 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Fixes bug in MainMenu that if there are no browsers around when timer
fires we get a crash.

BUG=none
TEST=none
TBR=oshima

Review URL: http://codereview.chromium.org/502065
------------------------------------------------------------------------
r34902 | estade@chromium.org | 2009-12-18 01:23:05 +0100 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/ipc/ipc_platform_file.h

Win: Fix an invalid handle initialization in the spellchecker.

Also, convert a potential crash to a NOTREACHED.

BUG=30433
TEST=see bug

Review URL: http://codereview.chromium.org/505022
------------------------------------------------------------------------
r34901 | sky@chromium.org | 2009-12-18 01:19:44 +0100 (Fri, 18 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/sql/init_status.h
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Fixes two related bugs:
. If we can't init the web db a dialog is shown to the user.
. If we can't init the web db the default search provider no longer
  becomes NULL.

BUG=28374
TEST=none

Review URL: http://codereview.chromium.org/501090
------------------------------------------------------------------------
r34900 | erg@google.com | 2009-12-18 01:18:44 +0100 (Fri, 18 Dec 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/test/testing_profile.h

[More BTP includes.]

Uninstall themes when all theme infobars are gone; not on each infobar's destruction.

There are multiple problems with the current implementation:
- It handles multiple tabs with theme install infobars badly.
- It has a subtle race condition where installing a second theme, and then
  installing the original theme (note: not clicking undo) uninstalled both
  themes.

Instead, only uninstall unused themes when all infobars are closed down.

BUG=none
TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show.
TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work.

Previous Review URL: http://codereview.chromium.org/504052

Review URL: http://codereview.chromium.org/501096
------------------------------------------------------------------------
r34892 | tony@chromium.org | 2009-12-18 00:07:25 +0100 (Fri, 18 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/test/testing_profile.h

Revert "Preload the visited link db on the file thread if the file exists."

There are ui_test crashes with this change.

This reverts commit r34874.

TBR=mirandac

Review URL: http://codereview.chromium.org/502063
------------------------------------------------------------------------
r34891 | erg@google.com | 2009-12-18 00:00:47 +0100 (Fri, 18 Dec 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

TBR: Revert to fix Chromos.
------------------------------------------------------------------------
r34890 | erg@google.com | 2009-12-17 23:52:05 +0100 (Thu, 17 Dec 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

Uninstall themes when all theme infobars are gone; not on each infobar's destruction.

There are multiple problems with the current implementation:
- It handles multiple tabs with theme install infobars badly.
- It has a subtle race condition where installing a second theme, and then
  installing the original theme (note: not clicking undo) uninstalled both
  themes.

Instead, only uninstall unused themes when all infobars are closed down.

BUG=none
TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show.
TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work.

Review URL: http://codereview.chromium.org/504052
------------------------------------------------------------------------
r34889 | skrul@chromium.org | 2009-12-17 23:45:27 +0100 (Thu, 17 Dec 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/webdata/autofill_change.cc
   M /trunk/src/chrome/browser/webdata/autofill_change.h
   A /trunk/src/chrome/browser/webdata/autofill_entry.cc
   M /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

Return a list of changed from WebDatabase::RemoveFormElementsAddedBetween()
This changes add a list of AutofillChange out parameter to the RemoveFormElementsAddedBetween() method in order to communicate exactly what happened to the caller.  This method may only update some autofill entries (by removing use timestamps that fall in the specified time range) or completely remove the autofill entry (if all the use timestamps fall between the specified time range).  For sync, we need to know the difference.

This change also required some new testing method on WebDatabase to make it possible to add new autofill entries with specific timestamps.  This is needed to create a reliable test that requires entries to be added at different times.  If there is a better way to do this, please let me know.

The next change will add the notifications to the WebDataService.

BUG=30169

Review URL: http://codereview.chromium.org/506047
------------------------------------------------------------------------
r34886 | nick@chromium.org | 2009-12-17 23:37:51 +0100 (Thu, 17 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

Remove per-field dirty bits from EntryKernel.

Always write complete rows into the database.  Unify the Update/Create paths by using INSERT OR REPLACE.  Remove the IS_NEW field.

Expand one unit test to be sure they exercise the dirty-clearing behavior of SaveChanges.

This is done in preparation for moving to protobuf-based storage.  When most fields are merged into a single protobuf column, tracking dirtiness on a per-field basis doesn't buy much.

BUG=30041
TEST=existing unit tests

Review URL: http://codereview.chromium.org/507029
------------------------------------------------------------------------
r34880 | ananta@chromium.org | 2009-12-17 22:43:15 +0100 (Thu, 17 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Attempt 2 at landing this. This fixes the incognito mode ui test failures.

Fix a crash in ChromeFrame caused by incorrectly instantiating the automation url request context
used by the host network stack implementation with a NULL AutomationResourceMessageFilter pointer.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=29025

Will add a test for this in a subsequent CL.

Bug=29025

Review URL: http://codereview.chromium.org/506060
------------------------------------------------------------------------
r34877 | tony@chromium.org | 2009-12-17 22:24:33 +0100 (Thu, 17 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.h

Make the fullscreen exit bubble slide away when it hides.

BUG=8405

Review URL: http://codereview.chromium.org/507042
------------------------------------------------------------------------
r34876 | estade@chromium.org | 2009-12-17 22:23:35 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Port PageActionPopupTest to Linux by filling in missing functionality in locationbarviewgtk.

BUG=30326
TEST=test passes

Review URL: http://codereview.chromium.org/507032
------------------------------------------------------------------------
r34874 | tony@chromium.org | 2009-12-17 22:15:37 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/test/testing_profile.h

Preload the visited link db on the file thread if the file exists.
Otherwise, just load like normal on the UI thread.

BUG=24163

Review URL: http://codereview.chromium.org/502005
------------------------------------------------------------------------
r34870 | johnnyg@chromium.org | 2009-12-17 21:40:43 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc

I initialized this new field in one constructor but not in the other one, which caused uninitialized-memory failure in valgrind.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/504050
------------------------------------------------------------------------
r34868 | mirandac@google.com | 2009-12-17 21:17:36 +0100 (Thu, 17 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Revert 34855 - Fix a crash in ChromeFrame caused by incorrectly instantiating the automation url request context used
by the host network stack implementation with a NULL AutomationResourceMessageFilter pointer.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=29025

Will add a test for this in a subsequent CL.

Bug=29025

Review URL: http://codereview.chromium.org/505033

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/501087
------------------------------------------------------------------------
r34867 | jcampan@chromium.org | 2009-12-17 21:17:00 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   D /trunk/src/chrome/browser/cld_helper.cc
   D /trunk/src/chrome/browser/cld_helper.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/english_page.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js:34841)
   D /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Reverting the CLD CL altogether, the reliability bot is still red.

BUG=30681
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/504048
------------------------------------------------------------------------
r34864 | rohitrao@chromium.org | 2009-12-17 21:02:36 +0100 (Thu, 17 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

[Mac] Fix an object destruction ordering problem in TabStripControllerTest.

BUG=http://crbug.com/30397
TEST=Valgrind should still be happy.
Review URL: http://codereview.chromium.org/502020
------------------------------------------------------------------------
r34863 | mark@chromium.org | 2009-12-17 20:47:40 +0100 (Thu, 17 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm

Remove unnecessary super call in a delegate method.

BUG=30154
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/491059
------------------------------------------------------------------------
r34862 | aa@chromium.org | 2009-12-17 20:43:56 +0100 (Thu, 17 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_javascript_url_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/isolated_world_apitest.cc
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon2.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/update.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update2.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/chromium.png (from /trunk/src/chrome/test/data/extensions/api_test/popup/chromium.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/popup.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon1.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon1.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon2.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon2.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon3.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon3.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon4.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon4.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon5.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon5.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/manifest.json:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon1.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon2.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon3.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon4.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon5.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/connect/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/connect/page.js
   D /trunk/src/chrome/test/data/extensions/api_test/connect/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/connect_external/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/connect_external/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/all_frames.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/top_frame_only.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/all_frames.js (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/all_frames.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/test.html (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/test.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/top_frame_only.js (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/top_frame_only.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/background.html (from /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/injectionator.js (from /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/a.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/a.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/b.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/b.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/background.html (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/c.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/c.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/a.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/a.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/background.html (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/manifest.json:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/1.css
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/1.css (from /trunk/src/chrome/test/data/extensions/api_test/executescript/1.css:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/executescript/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script1.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/script1.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script2.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/script2.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script3.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/script3.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test_executescript.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/test_executescript.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame0.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame0.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame1.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame1.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame2.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame2.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame3.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame3.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/script.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/script.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test_executescript.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test_executescript.html:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/script1.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/script2.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/script3.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/test_executescript.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame0.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame1.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame2.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame3.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/script.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test_executescript.html
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/a.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/b.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/c.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/a.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/connect/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/page.js (from /trunk/src/chrome/test/data/extensions/api_test/connect/page.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/test.html (from /trunk/src/chrome/test/data/extensions/api_test/connect/test.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/connect_external/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/test.html (from /trunk/src/chrome/test/data/extensions/api_test/connect_external/test.html:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/page.html
   A /trunk/src/chrome/test/data/extensions/api_test/override/background.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/override/downloads.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/downloads.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/override/history.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/history.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/override/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/override1/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/override/newtab.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/newtab.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/override/nonexistant.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/nonexistant.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/override/test.js (from /trunk/src/chrome/test/data/extensions/api_test/override1/test.js:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/override1/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/downloads.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/history.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/override1/newtab.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/nonexistant.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/background.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/icon.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/page_action/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update2.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/background.html (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/page_action/icon.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/page.html (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/page.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/background.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/background.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/icon.png:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/popup.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/popup.html:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/popup.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/chromium.png
   M /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html (from /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup.html (from /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband_popup.html:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/popup_api/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband_popup.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/a.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/a.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/a.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/b.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/b.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/c.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/c.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/d.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/d.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/e.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/e.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/echo.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/f.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/f.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/tabs/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/relative.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/relative.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/tabs_util.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/tabs_util.js:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/test.html:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/c.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/d.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/e.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/echo.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/f.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/manifest.json:34857)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/test.html (from /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/test.html:34857)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/relative.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/tabs_util.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Reorganize api_tests directory.

This reapplies 34794 and 34779 with one additional fix,
which were reverted by 34798.

TBR=mpcomplete@chromium.org
BUG=30507
------------------------------------------------------------------------
r34857 | tim@chromium.org | 2009-12-17 20:18:53 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Generic ModelAssociator based on prototype from earlier CL.

BUG=29831
TEST=ProfileSyncServiceTest

Review URL: http://codereview.chromium.org/507039
------------------------------------------------------------------------
r34855 | ananta@chromium.org | 2009-12-17 20:10:50 +0100 (Thu, 17 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Fix a crash in ChromeFrame caused by incorrectly instantiating the automation url request context used
by the host network stack implementation with a NULL AutomationResourceMessageFilter pointer.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=29025

Will add a test for this in a subsequent CL.

Bug=29025

Review URL: http://codereview.chromium.org/505033
------------------------------------------------------------------------
r34851 | johnnyg@chromium.org | 2009-12-17 19:58:32 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/browser_url_handler.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h

Allow rewriting of URLs to be reversed in some cases, so that if the underlying renderer URL changes, the virtual URL displayed in the address bar can be updated to reflect that.  Currently apply that technique only to view-source rewrites, so it will follow redirects.

BUG=19444
TEST=go to view-source:http://crbug.com

Review URL: http://codereview.chromium.org/493001
------------------------------------------------------------------------
r34850 | xiyuan@chromium.org | 2009-12-17 19:49:56 +0100 (Thu, 17 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Use KF_ALTDOWN flag instead of GetKeyState(VK_MENU)

KF_ALTDOWN is more accurate than GetKeyState(VK_MENU). When usre presses
RightShift+RightAlt, the fake VK_CONTROL generated carries KF_ALTDOWN in
its flags but GetKeyState(VK_MENU) is clear.

BUG=30244
TEST=Verify RightAlt+RightShift does not change to RTL and issue 24888 does not regress. However, RightShift+RightAlt still changes RTL as this is the behavior of richedit.

Review URL: http://codereview.chromium.org/505026
------------------------------------------------------------------------
r34847 | zork@google.com | 2009-12-17 19:36:07 +0100 (Thu, 17 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc

Alter DirectoryBackingStore::InitializeTables() and
DirectoryBackingStore::SafeDropTable() to use the standard Chromium wrappers.

BUG=none
TEST=Run the sync unit tests and observe that they still pass.

Review URL: http://codereview.chromium.org/500102
------------------------------------------------------------------------
r34846 | cira@chromium.org | 2009-12-17 19:30:53 +0100 (Thu, 17 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.h
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Load message catalogs on demand when chrome.i18n.getMessage needs them.

1. Added default locale to the url context
2. Removed old code that was uploading catalogs on load (to renderer)
3. Removed message bundle object from Extension class.

BUG=27361
TEST=Open Chrome with --lang=sr and load src\chrome\common\extensions\docs\examples\api\i18n\getMessage extension from chrome://extensions page. Click on icon and text in popup should be localized.

Review URL: http://codereview.chromium.org/463011
------------------------------------------------------------------------
r34844 | rohitrao@chromium.org | 2009-12-17 19:27:42 +0100 (Thu, 17 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa_unittest.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

[Mac] Fix a leak in BrowserWindowCocoaTest.

BUG=http://crbug.com/30382
TEST=Valgrind mac should stay happy.
Review URL: http://codereview.chromium.org/506055
------------------------------------------------------------------------
r34842 | pamg@google.com | 2009-12-17 19:27:16 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

First batch of unit tests for mac Page Actions.
Fix leak of page_action_views_ in LocationBarViewMac.

TEST=covered by unit tests and valgrind UI tests
BUG=30448, 12281
Review URL: http://codereview.chromium.org/506046
------------------------------------------------------------------------
r34840 | tony@chromium.org | 2009-12-17 19:14:35 +0100 (Thu, 17 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc

Add rounded corner support to rounded_window.cc.  This only kicks
in if the radius is >= 8, which is the case for the full screen
exit bubble.

We could tweak the radius needed to trigger this-- I didn't actually
test to see what radii looked good and what radii looked bad.

BUG=8405

Review URL: http://codereview.chromium.org/505029
------------------------------------------------------------------------
r34837 | oshima@chromium.org | 2009-12-17 18:30:13 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/resources/downloads.html

Don't show "show in foloder" in chrome os.

BUG=chromiun-os:916
TEST=None

Review URL: http://codereview.chromium.org/506045
------------------------------------------------------------------------
r34836 | kkania@chromium.org | 2009-12-17 18:27:54 +0100 (Thu, 17 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Mac: Use indices correctly in TabStripController to fix crash. Fix several instances of using controller indices instead of model indices.
BUG=28325
TEST=See bug
Review URL: http://codereview.chromium.org/506022
------------------------------------------------------------------------
r34834 | pinkerton@chromium.org | 2009-12-17 18:04:29 +0100 (Thu, 17 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm

Fix issue where drag image would be offset if the content area was not at the bottom of the window (for example, if the download manager was showing).
BUG=30586
TEST=dragging things from the browser should work as before
Review URL: http://codereview.chromium.org/504046
------------------------------------------------------------------------
r34820 | kinuko@chromium.org | 2009-12-17 11:43:54 +0100 (Thu, 17 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Fix crash on opening a file save dialog when the parent tab has no content on Mac/Linux

BUG=29213
TEST=Check 'Ask where to save each file before downloading' in 'Under the Hood' preferences.  Open a page that has links to downloadable items (like http://ftp.sunet.se/pub/Linux/kernels/v1.0/).  Right-click on one of the item and choose 'Open Link in New Tab'.
Make sure an empty tab opens and a dialog appears for asking where to save the file.  Make sure the dialog does not disappear immediately.  Make sure that closing the empty tab do not crash the browser.

Review URL: http://codereview.chromium.org/507024
------------------------------------------------------------------------
r34818 | jcampan@chromium.org | 2009-12-17 10:00:11 +0100 (Thu, 17 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Disabling browser tests that are testing the language detection,
since language detection is temporarily disabled.

BUG=30662
TEST=None
TBR=brettw

Review URL: http://codereview.chromium.org/504041
------------------------------------------------------------------------
r34816 | jcampan@chromium.org | 2009-12-17 08:57:38 +0100 (Thu, 17 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cld_helper.cc

The reliability tests are reporting lots of crashers
in the CLD library.
Temporarily disabling the CLD detection while investigating.

BUG=30662
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/500091
------------------------------------------------------------------------
r34812 | finnur@chromium.org | 2009-12-17 06:55:32 +0100 (Thu, 17 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   A /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   A /trunk/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   A /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   A /trunk/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Add the right-click context menu for Browser actions and Page Actions.

BUG=29538
TEST=Right-click an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022
------------------------------------------------------------------------
r34811 | evan@chromium.org | 2009-12-17 06:54:10 +0100 (Thu, 17 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc

Use GetSwitchValueASCII, so we don't use the deprecated versions.

Patch from Thiago Farina <thiago.farina@gmail.com>.

Review URL: http://codereview.chromium.org/498002
------------------------------------------------------------------------
r34808 | asargent@chromium.org | 2009-12-17 05:27:24 +0100 (Thu, 17 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc

Workaround to prevent a crash checking extensions blacklist.

Somehow the extensions dictionary is ending up null when we don't expect it to.
This prevents the crash but may not prevent other problems. 

BUG=29317
TEST=none


Review URL: http://codereview.chromium.org/507030
------------------------------------------------------------------------
r34798 | aa@chromium.org | 2009-12-17 03:24:34 +0100 (Thu, 17 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_javascript_url_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/isolated_world_apitest.cc
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/background.html:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon2.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/update.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon2.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update2.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/chromium.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/popup.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon1.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon2.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon3.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon4.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon5.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/update.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update2.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon1.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon1.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon2.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon2.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon3.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon3.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon4.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon4.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon5.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon5.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/connect/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/connect/page.js (from /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/page.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/connect/test.html (from /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/test.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/connect_external/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/connect_external/test.html (from /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/test.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/all_frames.js (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/all_frames.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/test.html (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/test.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/top_frame_only.js (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/top_frame_only.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/background.html (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/injectionator.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/manifest.json:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/all_frames.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/top_frame_only.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/injectionator.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/a.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/b.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/c.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/a.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/1.css (from /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/1.css:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/1.css
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script1.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script2.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script3.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test_executescript.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame0.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame1.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame2.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame3.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/script.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test_executescript.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/script1.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script1.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/script2.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script2.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/script3.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script3.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/test_executescript.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test_executescript.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame0.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame0.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame1.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame1.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame2.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame2.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame3.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame3.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/script.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/script.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test_executescript.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test_executescript.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/a.js (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/a.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/b.js (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/b.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/background.html (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/c.js (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/c.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/a.js (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/a.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/background.html (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/test.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/test.html:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/page.js
   D /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/background.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/icon.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/page.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/page.html:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/override/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/downloads.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/history.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/override/newtab.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/nonexistant.html
   D /trunk/src/chrome/test/data/extensions/api_test/override/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/override1/background.html (from /trunk/src/chrome/test/data/extensions/api_test/override/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/override1/downloads.html (from /trunk/src/chrome/test/data/extensions/api_test/override/downloads.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/override1/history.html (from /trunk/src/chrome/test/data/extensions/api_test/override/history.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/override1/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/override/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/override1/newtab.html (from /trunk/src/chrome/test/data/extensions/api_test/override/newtab.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/override1/nonexistant.html (from /trunk/src/chrome/test/data/extensions/api_test/override/nonexistant.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/override1/test.js (from /trunk/src/chrome/test/data/extensions/api_test/override/test.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/background.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/background.html:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update2.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/icon.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/manifest.json:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/page.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update2.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/background.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/background.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/icon.png:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/popup.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/popup.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/chromium.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/chromium.png:34797)
   M /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/popup.html:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup_api/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband_popup.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/a.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/a.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/b.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/b.html:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/a.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/b.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/c.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/d.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/e.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/f.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/relative.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/tabs_util.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/c.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/c.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/d.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/d.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/e.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/e.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/echo.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/f.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/f.html:34797)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/relative.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/relative.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/tabs_util.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/tabs_util.js:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/test.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.html:34797)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js:34797)

Revert 34794 and 34779. Too much red.

TBR=mpcomplete@chromium.org
BUG=30507
------------------------------------------------------------------------
r34791 | oshima@chromium.org | 2009-12-17 01:25:49 +0100 (Thu, 17 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

fixes for
 crash/non responsive issue in compact navbar.
 crash when adding tab.

new command line switch to start chrome in chromeos layout.
changed accelerator to toggle compact navbar to ctrl-shit-c.
-0 does not work on chromeos for some reason.

BUG=chromium-os:1010, 30612
TEST=None

Review URL: http://codereview.chromium.org/500043
------------------------------------------------------------------------
r34786 | erg@google.com | 2009-12-17 01:18:33 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc

BrowserThemePack: Move encoding the processed images to the writing thread.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/504032
------------------------------------------------------------------------
r34784 | jhawkins@chromium.org | 2009-12-17 01:02:05 +0100 (Thu, 17 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_field.cc
   A /trunk/src/chrome/browser/autofill/name_field.cc
   A /trunk/src/chrome/browser/autofill/name_field.h
   M /trunk/src/chrome/chrome_browser.gypi

Implement NameField, a FormField that matches a name field in a form.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/504030
------------------------------------------------------------------------
r34783 | tommi@chromium.org | 2009-12-17 00:59:17 +0100 (Thu, 17 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi.h
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/chrome_frame/utils.h

Handle right-click->"Save Link As" in the host browser.

TEST=Right click on a link in CF and select "save link as".  You should immediately get the host browser's download UI.  Before there could be a significant wait before this happened.
BUG=23561

Review URL: http://codereview.chromium.org/506042
------------------------------------------------------------------------
r34779 | aa@chromium.org | 2009-12-17 00:39:02 +0100 (Thu, 17 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_javascript_url_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/isolated_world_apitest.cc
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/icon2.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/basics/update.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/no_icon/update2.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/chromium.png (from /trunk/src/chrome/test/data/extensions/api_test/popup/chromium.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/popup/popup.html (from /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/background.html (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon1.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon1.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon2.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon2.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon3.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon3.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon4.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon4.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/icon5.png (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon5.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/tab_specific_state/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/manifest.json:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon1.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon2.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon3.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon4.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/icon5.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/connect/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/connect/page.js
   D /trunk/src/chrome/test/data/extensions/api_test/connect/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/connect_external/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/connect_external/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/all_frames.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/top_frame_only.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js
   D /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/all_frames.js (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/all_frames.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/test.html (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/test.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/all_frames/top_frame_only.js (from /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/top_frame_only.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/background.html (from /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/injectionator.js (from /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/extension_process/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/a.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/a.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/b.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/b.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/background.html (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/c.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/c.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/a.js (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/a.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/background.html (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/content_scripts/isolated_world2/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/manifest.json:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/1.css
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/1.css (from /trunk/src/chrome/test/data/extensions/api_test/executescript/1.css:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/executescript/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script1.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/script1.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script2.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/script2.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/script3.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript/script3.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/basic/test_executescript.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript/test_executescript.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame0.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame0.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame1.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame1.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame2.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame2.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/frame3.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame3.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/script.js (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/script.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/in_frame/test_executescript.html (from /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test_executescript.html:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/script1.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/script2.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/script3.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript/test_executescript.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame0.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame1.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame2.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame3.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/script.js
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test_executescript.html
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/a.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/b.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/c.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/a.js
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/messaging
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/connect/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/page.js (from /trunk/src/chrome/test/data/extensions/api_test/connect/page.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect/test.html (from /trunk/src/chrome/test/data/extensions/api_test/connect/test.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/connect_external/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/messaging/connect_external/test.html (from /trunk/src/chrome/test/data/extensions/api_test/connect_external/test.html:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/page.html
   A /trunk/src/chrome/test/data/extensions/api_test/override
   A /trunk/src/chrome/test/data/extensions/api_test/override/background.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/override/downloads.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/downloads.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/override/history.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/history.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/override/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/override1/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/override/newtab.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/newtab.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/override/nonexistant.html (from /trunk/src/chrome/test/data/extensions/api_test/override1/nonexistant.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/override/test.js (from /trunk/src/chrome/test/data/extensions/api_test/override1/test.js:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/override1/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/downloads.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/history.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/override1/newtab.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/nonexistant.html
   D /trunk/src/chrome/test/data/extensions/api_test/override1/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/background.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/icon.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/page_action/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/basics/update2.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/background.html (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/page_action/icon.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/old_api/page.html (from /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/page.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/background.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/background.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/icon.png (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/icon.png:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/popup/popup.html (from /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/popup.html:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/page_action_popup/popup.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup/chromium.png
   M /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband.html (from /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/popup/toolband_popup.html (from /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband_popup.html:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/popup_api/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html
   D /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband_popup.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/a.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/a.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/a.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/b.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/b.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/c.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/c.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/d.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/d.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/e.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/e.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/echo.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/echo.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/f.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/f.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/tabs/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/relative.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/relative.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/tabs_util.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/tabs_util.js:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.html (from /trunk/src/chrome/test/data/extensions/api_test/tabs/test.html:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js (from /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/c.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/d.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/e.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/echo.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/f.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/manifest.json (from /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/manifest.json:34772)
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/javascript_url_permissions/test.html (from /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/test.html:34772)
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/relative.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/tabs_util.js
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Reorganize api_tests directory. One top-level directory per feature.

BUG=30507

Review URL: http://codereview.chromium.org/504033
------------------------------------------------------------------------
r34772 | shess@chromium.org | 2009-12-16 23:56:33 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/base/message_loop.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

[Mac] Pump nestable tasks while web popups are visible.

BUG=30147
TEST=Go to site with select control and flash animation, popping up control shouldn't pause the flash.  See the bug for an example.

Review URL: http://codereview.chromium.org/486042
------------------------------------------------------------------------
r34762 | viettrungluu@chromium.org | 2009-12-16 23:26:56 +0100 (Wed, 16 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm

Mac: make unselected pinned tabs glow when their title changes.

When an unselected pinned tab changes its title, that tab should briefly "glow" to indicate this (see what Win/Chrome does).

BUG=29261,28154
TEST=Go to <http://www.surflocal.net/Awards/submit/animatedtitle.html>, pin it, and select another tab; the pinned tab should glow (pulsate in this case) nicely. Also make sure that hover effects work as normal. Try this on a number of themes, with multiple tabs, etc.

Review URL: http://codereview.chromium.org/455042
------------------------------------------------------------------------
r34761 | estade@chromium.org | 2009-12-16 23:21:44 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Make sure mid-drag bookmark bar items are not shown by BookmarkBarGtk::Show() calls

BUG=30521
TEST=click a boomkark bar icon, then quickly drag it. It should not re-appear on the shelf until the drag is over.

Review URL: http://codereview.chromium.org/504017
------------------------------------------------------------------------
r34760 | zork@google.com | 2009-12-16 23:19:20 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.h

Handle errors in DoesTableExist() gracefully instead of crashing.

BUG=30403
TEST=None

Review URL: http://codereview.chromium.org/500040
------------------------------------------------------------------------
r34759 | jparent@chromium.org | 2009-12-16 22:58:45 +0100 (Wed, 16 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable DevToolsSanityTest.TestExpandScope as it is failing from webkit roll.

TEST=none
BUG=30618


Review URL: http://codereview.chromium.org/500077
------------------------------------------------------------------------
r34757 | viettrungluu@chromium.org | 2009-12-16 22:36:10 +0100 (Wed, 16 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Mac: fix/implement app windows (not app mode), popups, drawing; refactor code.

1. Properly display app windows, including Developer Tools window (no location bar). Also check using --app=http://foobar.com/.
2. Lay out popup windows (in particular, location bar) better. Check using, e.g., <http://www.quirksmode.org/js/popup.html>; make sure it looks good (with a variety of themes).
3. Properly draw border to Omnibox -- so that its border matches the surrounding buttons. Check (looking very closely/zooming) using various themes (Google and artist, light and dark).
4. Re-organize/refactor code in the BrowserWindowController (esp. the layout code). Check that (in a normal window) it still displays the toolbar, bookmark bar (normal and NTP), infobar, and download shelf correctly.

BUG=13148,20244,26757,29103
TEST=See above.

Review URL: http://codereview.chromium.org/495010
------------------------------------------------------------------------
r34756 | estade@chromium.org | 2009-12-16 22:29:49 +0100 (Wed, 16 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Get rid of some unecessary calls to BookmarkBarGtk::Show().

We were calling Show() three times for every navigation. This probably didn't have awful performance consequences, but isn't helpful.

BUG=none
TEST=go to NTP with always show bookmarks off. Navigate to google.com. The floating bookmark bar should disappear.

Review URL: http://codereview.chromium.org/505015
------------------------------------------------------------------------
r34750 | ananta@chromium.org | 2009-12-16 22:12:23 +0100 (Wed, 16 Dec 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   A /trunk/src/chrome_frame/test/data/xmlhttprequest_test.html

Tommi, please review everything. jam please review changes to resource_dispatcher_host.cc

XMLHttpRequests issued by ChromeFrame instances would not use the host network stack at times.
HTTP requests issued by these chrome instances are sent over automation to the host browser. This relies
on the request having a renderer process id and a routing id for us to be able to intercept these requests.

XHR requests are sent over to the browser via the ViewHostMsg_SyncLoad. This message has the routing id.
However we always passed 0 down to the ResourceDispatcherHost::BeginRequest function which caused this
to fail.

Added a chrome frame specific unit test for this.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=30355

Bug=30355

Review URL: http://codereview.chromium.org/501040
------------------------------------------------------------------------
r34749 | cira@chromium.org | 2009-12-16 22:11:06 +0100 (Wed, 16 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/l10n
   A /trunk/src/chrome/test/data/extensions/l10n/Preferences
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0/_locales
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0/_locales/en
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0/_locales/en/messages.json
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0/_locales/sr
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0/_locales/sr/messages.json
   A /trunk/src/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0/_locales
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0/_locales/en
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0/_locales/en/messages.json
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0/_locales/sr
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0/_locales/sr/messages.json
   A /trunk/src/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/l10n/lgpnlbnlajcjdkakbbnfcgkdfggonpic
   A /trunk/src/chrome/test/data/extensions/l10n/lgpnlbnlajcjdkakbbnfcgkdfggonpic/1.0
   A /trunk/src/chrome/test/data/extensions/l10n/lgpnlbnlajcjdkakbbnfcgkdfggonpic/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json

Localizing manifest for installed or unpacked extensions.

1. Use _MSG_ format for manifest fields instead of hard-coded names.
2. Localize manifest during installation procedure -> save localized version to prefs.
3. Add current_locale field to manifest so we can detect when chrome locale changes and re-localize manifest.
4. Adds prefs method to MigratePrefs&Write to disk.
5. General refactor of extension_file_util wrt l10n code.
6. Don't localize themes (we can revert this by adding default_locale and current_locale keys to allowed keys for theme section).

BUG=27360

Review URL: http://codereview.chromium.org/434015
------------------------------------------------------------------------
r34745 | zork@chromium.org | 2009-12-16 21:58:28 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Fix labels on the content options page to wrap properly.  Also, add a utility function to allow other labels to do the same.

BUG=29797
TEST=Open the content options page, and check that the labels wrap at the width of the page.

Review URL: http://codereview.chromium.org/500026
------------------------------------------------------------------------
r34740 | jhawkins@chromium.org | 2009-12-16 21:23:15 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/credit_card_field.cc

Fix the ARM build.  Clarify the logic with parentheses.

TBR=jcampan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/502036
------------------------------------------------------------------------
r34738 | jcampan@chromium.org | 2009-12-16 21:06:40 +0100 (Wed, 16 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Disabling the language detection on Linux and Mac.
The CLD library is not ported to these platforms yet
and the code is currently causing a memory leak.

TBR=brettw
BUG=None

Review URL: http://codereview.chromium.org/500073
------------------------------------------------------------------------
r34736 | jhawkins@chromium.org | 2009-12-16 20:40:29 +0100 (Wed, 16 Dec 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/credit_card_field.cc
   A /trunk/src/chrome/browser/autofill/credit_card_field.h
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement CreditCardField, a FormField that matches a credit card field in a form.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/502018
------------------------------------------------------------------------
r34735 | pinkerton@chromium.org | 2009-12-16 20:27:09 +0100 (Wed, 16 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_menu_model_unittest.cc
   M /trunk/src/chrome/browser/page_menu_model_unittest.cc
   M /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/chrome_tests.gypi
   A /trunk/src/chrome/test/menu_model_test.cc
   A /trunk/src/chrome/test/menu_model_test.h

Refactor shared menu model testing code into a common baseclass
BUG=28977
TEST=unit tests still work
Review URL: http://codereview.chromium.org/504027
------------------------------------------------------------------------
r34733 | rafaelw@chromium.org | 2009-12-16 20:16:38 +0100 (Wed, 16 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/common/notification_type.h

Only show gray LOADING dialog for Themes.

The patch changes the behavior of the LOADING dialog such that it is only shown for extension downloads from the mini-gallery (theme) url. Note that this means that themes from the chrome extensions gallery will also NOT have the dialog shown.

BUG=29628
TEST=Install an theme from https://tools.google.com/chrome/intl/pt/themes/index.html. The gray LOADING dialog should appear. Install extension or theme from chrome.google.com/extensions. No LOADING dialog should appear

Review URL: http://codereview.chromium.org/507016
------------------------------------------------------------------------
r34728 | jcampan@chromium.org | 2009-12-16 19:35:52 +0100 (Wed, 16 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   A /trunk/src/chrome/browser/cld_helper.cc
   A /trunk/src/chrome/browser/cld_helper.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/english_page.html
   A /trunk/src/chrome/test/data/french_page.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Makes the language detection happen with every page load 
as we do with the page indexing. (The language detection was
previously done on demand when the extension related API was querying it.)
Once detected the language is stored on the navigation entry.
It'll be used for the upcoming translation feature.

Also I moved the existing language detection from the UI to
the file thread.

The change required few changes for the
chrome.tabs.detectLanguage extension API to still work.

BUG=None
TEST=Run the browser tests and unit-tests.

Review URL: http://codereview.chromium.org/492024
------------------------------------------------------------------------
r34723 | kuan@chromium.org | 2009-12-16 18:15:56 +0100 (Wed, 16 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/sad_tab_controller_unittest.mm

fix leakages in SadTabControllerTest

BUG=30522
TEST=verify that running "unit_tests --gtest_filter="SadTabController*"" does not have leakages
Review URL: http://codereview.chromium.org/507023
------------------------------------------------------------------------
r34721 | skrul@chromium.org | 2009-12-16 17:53:22 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/webdata/autofill_change.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

Send notifications when single items are removed from autofill.
This patch will send an AUTOFILL_ENTRIES_REMOVED when an autofill entry is removed via WebDataService::RemoveFormValueForElementName() is called (note that the next change will have this implemented for the bulk removal method).  This change also includes a bit of refactoring on how the notification details are sent from the WDS thread back to the main thread.  Previously I was sending the data back via a WDResult but that didn't work well when expanded to different notifications since there is so way to tell what a given request was for.  So I added some fields to the WedDataRequest class to hold the affected keys and the notification type.

BUG=30168

Review URL: http://codereview.chromium.org/506001
------------------------------------------------------------------------
r34718 | pinkerton@chromium.org | 2009-12-16 17:21:36 +0100 (Wed, 16 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/browser/app_menu_model.h
   M /trunk/src/chrome/browser/app_menu_model_unittest.cc
   M /trunk/src/chrome/browser/cocoa/menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/page_menu_model.h
   A /trunk/src/chrome/browser/tab_menu_model.cc
   A /trunk/src/chrome/browser/tab_menu_model.h
   A /trunk/src/chrome/browser/tab_menu_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Factor tab context menu into a shared model and fix mac and win to use it. Improve a couple of model unit tests. Remove unused members in the models.
BUG=28977
TEST=context menus on tabs should work and enable/disable properly
Review URL: http://codereview.chromium.org/500030
------------------------------------------------------------------------
r34717 | skrul@chromium.org | 2009-12-16 17:13:09 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/webdata/autofill_entry.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

Add details to autofill add notification
This change adds a details payload containing the list of modified keys to the autofill add notification.  The existing mechanism for passing values back from query methods (WDResult) is reused here to pass the modified keys back to the caller.

BUG=29606

Review URL: http://codereview.chromium.org/477009
------------------------------------------------------------------------
r34708 | hamaji@chromium.org | 2009-12-16 10:28:46 +0100 (Wed, 16 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Mark ExtensionBrowserTest.AutoUpdate as flaky.

This happens only on Linux x64.

An example log:

http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20x64/builds/3487/steps/browser_tests/logs/stdio

The first failure:

http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20x64/builds/3474

BUG=30548
TEST=none

Review URL: http://codereview.chromium.org/501050
------------------------------------------------------------------------
r34668 | aa@chromium.org | 2009-12-16 08:47:39 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json

Fix regression where we stopped running content scripts in
extension processes.

BUG=29621

Review URL: http://codereview.chromium.org/505012
------------------------------------------------------------------------
r34649 | finnur@chromium.org | 2009-12-16 05:20:42 +0100 (Wed, 16 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix browser crash in extension system.

When an external extension is removed from the json file
(for example by a 3rd party installer) after the user
has explicitly uninstalled it, Chrome would start crashing
and crashing.

This is now fixed. Also added a couple of unit tests for
this case (for each external provider) and cleaned up one
of those unit tests to make it match what the other was
doing.

BUG=http://crbug.com/30505
TEST=Covered by unit test.

Review URL: http://codereview.chromium.org/504016
------------------------------------------------------------------------
r34648 | kinuko@chromium.org | 2009-12-16 05:12:12 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Fix a node selection when creating a new item under the 'Other Bookmarks'

BUG=30067
TEST=Right click 'Other Bookmarks' and choose 'Add Page' or 'Add Folder' to create a new item.  Make sure the editor opens with the 'Other Bookmarks' selected by default and the item is created under the 'Other Bookmarks'.

Review URL: http://codereview.chromium.org/506012
------------------------------------------------------------------------
r34647 | satorux@chromium.org | 2009-12-16 04:28:02 +0100 (Wed, 16 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Fix radio items in MenuGtk.

Suppose there are three radio items A, B, C, and A is now being
checked. If you click C, commands associated with A and C are both
executed. This is because A also receives the "activate" signal,
before C receives it.

BUG=30450
TEST=try; manually with gdb with the steps described in crbug.com/30450.

Review URL: http://codereview.chromium.org/506010
------------------------------------------------------------------------
r34646 | kinuko@chromium.org | 2009-12-16 04:18:25 +0100 (Wed, 16 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc

Make bookmarks manager search work for URLs containing uppercase characters

BUG=30427
TEST=BookmarkUtilsTest.DoesBookmarkContainText
TEST=Add a bookmark item for a URL containing upper case, open the bookmarks manager and type in the URL in the 'Search' form.  Make sure the bookmark is found.

Review URL: http://codereview.chromium.org/502011
------------------------------------------------------------------------
r34645 | jamesr@chromium.org | 2009-12-16 04:17:51 +0100 (Wed, 16 Dec 2009) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/task_manager_renderer_resource.cc
   D /trunk/src/chrome/browser/task_manager_renderer_resource.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/chrome_browser.gypi

Revert 34630 - Handles rendererspecific TaskManager resources consistently for TabContent and Extension processes

TEST=none
BUG=29307

Review URL: http://codereview.chromium.org/466025

TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/501043
------------------------------------------------------------------------
r34639 | rsesek@chromium.org | 2009-12-16 03:04:17 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

Fix leaky tests KeywordEditorCocoaControllerTest and EditSearchEngineCocoaControllerTest.

BUG=30390,30392
TEST=Run unit_tests under Valgrind.

Review URL: http://codereview.chromium.org/507010
------------------------------------------------------------------------
r34636 | derat@chromium.org | 2009-12-16 02:46:07 +0100 (Wed, 16 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics.cc
   M /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc

chromeos: Add some network metrics to the external metrics transport.
Also test all metrics names in the unit test.

(change is by semenzato@chromium.org and was already
reviewed by rvargas at http://codereview.chromium.org/489008)

TBR=semenzato

Review URL: http://codereview.chromium.org/500041
------------------------------------------------------------------------
r34634 | jamesr@chromium.org | 2009-12-16 02:07:08 +0100 (Wed, 16 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/view_id_util.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/login_model.h
   M /trunk/src/chrome/browser/login_prompt.h

Give classes with virtual methods virtual protected d'tors instead of non-virtual public implicit d'tors.

Was originally:
Replace public nonvirtual destructors in classes with virtual members
with protected nonvirtual destructors where possible, and with
public virtual destructors where destruction of a derived class occurs.
(chrome/browser/[a-m]* only)

(Part 4 of http://www.gotw.ca/publications/mill18.htm
has a rationale for why public nonvirtual destructors in classes with
virtual members is dangerous.)

BUG=none
TEST=base_unittests & app_unittests

Review URL: http://codereview.chromium.org/201100
------------------------------------------------------------------------
r34632 | willchan@chromium.org | 2009-12-16 01:55:07 +0100 (Wed, 16 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/browser_main.cc

Fix Linux hanging ui_tests and browser_tests by reverting posix signal handler changes.
Reverts:
r34036 - "Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe."
r34096 - "Re-enable TCMalloc on Linux."  This change depended on the posix signal handler change.
BUG=http://crbug.com/30501

Review URL: http://codereview.chromium.org/502017
------------------------------------------------------------------------
r34631 | chocobo@chromium.org | 2009-12-16 01:40:14 +0100 (Wed, 16 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h

Small fix to code to prevent wasting enum values.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/500036
------------------------------------------------------------------------
r34630 | jamesr@chromium.org | 2009-12-16 01:28:52 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/task_manager_renderer_resource.cc
   A /trunk/src/chrome/browser/task_manager_renderer_resource.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/chrome_browser.gypi

Handles renderer-specific TaskManager resources consistently for TabContent and Extension processes

TEST=none
BUG=29307

Review URL: http://codereview.chromium.org/466025
------------------------------------------------------------------------
r34628 | kuan@chromium.org | 2009-12-16 01:23:05 +0100 (Wed, 16 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/sad_tab_controller_unittest.mm

block sad tab controller unittest that have leakages for now.

BUG=27212
Review URL: http://codereview.chromium.org/500035
------------------------------------------------------------------------
r34627 | chocobo@chromium.org | 2009-12-16 01:15:19 +0100 (Wed, 16 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h

Add offline mode selection for ChromeOS
BUG=568
TEST=none
Review URL: http://codereview.chromium.org/504008
------------------------------------------------------------------------
r34626 | sky@chromium.org | 2009-12-16 01:08:10 +0100 (Wed, 16 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

Lands http://codereview.chromium.org/469009 for Thiago:

bookmarks: Update parent (folder) modified time when we create a new
bookmark node.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/500005
------------------------------------------------------------------------
r34624 | willchan@chromium.org | 2009-12-16 00:14:14 +0100 (Wed, 16 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/fixed_host_resolver.cc
   M /trunk/src/net/base/fixed_host_resolver.h
   M /trunk/src/net/flip/flip_network_transaction.cc
   M /trunk/src/net/flip/flip_session.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h

Flip: Comma delimit the various flip options. Redo the fixed testing server flags.
Renames --testing-fixed-server to --testing-fixed-host.  Adds --testing-fixed-http-port and --testing-fixed-https-port.

Review URL: http://codereview.chromium.org/501032
------------------------------------------------------------------------
r34620 | mbelshe@google.com | 2009-12-16 00:05:56 +0100 (Wed, 16 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc

Remove the AsyncSlowStart experiment

BUG=30144
TEST=none

Review URL: http://codereview.chromium.org/491056
------------------------------------------------------------------------
r34614 | jhawkins@chromium.org | 2009-12-15 23:18:37 +0100 (Tue, 15 Dec 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/address_field.cc
   A /trunk/src/chrome/browser/autofill/address_field.h
   M /trunk/src/chrome/browser/autofill/form_field.cc
   M /trunk/src/chrome/chrome_browser.gypi

Implement AddressField, a FormField that matches a set of address fields in a form.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/492022
------------------------------------------------------------------------
r34611 | ananta@chromium.org | 2009-12-15 23:05:09 +0100 (Tue, 15 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h

Speculative fix for a chrome browser crash which occurs with ChromeFrame. Based on the crash dump, the crash
occurs when the external tab container is being destroyed which in turn takes down the automation provider 
and the channel, etc. All this occurs in the context of OleUninitialize, which executes after BrowserMain
returns, i.e. the message loop is now invalid, thus causing a crash while attempting to post a task to it.
Based on this call stack it looks like it happens due to the enable-renderer-accessisibility flag.

Fix is to move the OleInitialize/OleUnitialize calls to Platform::WillInitializeMainMessageLoop and
Platform::DidEndMainMessageLoop. The Platform::DidEndMainMessageLoop function now executes as a task which
is posted to the message loop prior to quitting it. This would ensure that the cleanup happens correctly.

Fixes http://code.google.com/p/chromium/issues/detail?id=30383

Bug=30383
Review URL: http://codereview.chromium.org/501011
------------------------------------------------------------------------
r34609 | mmoss@google.com | 2009-12-15 22:40:29 +0100 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/tools/build/linux/chrome-wrapper

Support custom Linux version strings (e.g. release channel, downstream vendor name, etc.).

Also reformat the Mac/Win version strings as per comments in
http://codereview.chromium.org/506007.

Review URL: http://codereview.chromium.org/506016
------------------------------------------------------------------------
r34608 | arv@chromium.org | 2009-12-15 22:35:57 +0100 (Tue, 15 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Remove the "Bookmark sync" menu item

This also cleans up the states.

BUG=28419
TEST=The menu item should be gone but we should still see errors from bookmark
sync on the NTP

Review URL: http://codereview.chromium.org/501029
------------------------------------------------------------------------
r34602 | erg@google.com | 2009-12-15 21:56:28 +0100 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc

Deal with themes that don't provide certain sections. Fixes crasher in new themes system.

BUG=30453
TEST=Installing https://chrome.google.com/extensions/detail/immljcnndlfdiajkpggdjbikmnibdhhi doesn't crash chrome.

Review URL: http://codereview.chromium.org/506014
------------------------------------------------------------------------
r34599 | rohitrao@chromium.org | 2009-12-15 21:48:51 +0100 (Tue, 15 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_view_unittest.mm
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_mac.txt

[Mac] Fix a very silly leak in FindBarViewTest.

BUG=http://crbug.com/30391
TEST=Valgrind passes.
Review URL: http://codereview.chromium.org/507012
------------------------------------------------------------------------
r34597 | brettw@chromium.org | 2009-12-15 21:46:32 +0100 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/utility_messages.h
   A /trunk/src/chrome/common/utility_messages_internal.h
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.h

Move the utility process messages to their own file now that we have more than
16 message types.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/460119
------------------------------------------------------------------------
r34594 | mirandac@chromium.org | 2009-12-15 21:22:17 +0100 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc

Fix for Debug crasher in safe browsing updater.

BUG= 20411
TEST= none

Review URL: http://codereview.chromium.org/463047
------------------------------------------------------------------------
r34585 | kuan@chromium.org | 2009-12-15 20:52:37 +0100 (Tue, 15 Dec 2009) | 14 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/SadTab.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/sad_tab_controller.h
   A /trunk/src/chrome/browser/cocoa/sad_tab_controller.mm
   A /trunk/src/chrome/browser/cocoa/sad_tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.h
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

mac: totally revamp "Aw Snap" page, implement new "Learn more" link, add unittests.
- totally revamp "Aw Snap" page to use xib resource, to reduce initialization code
- new SadTabController:
  - controls SadTabView, via xib
  - uses TabContents in init, so as to launch url for link; used to use BrowserList::GetLastActive but that's null in chrome-frame release
  - if TabContents is nil, remove link in view
  - encapsulates the setting up and removing of its SadTabView within and shield them from TabContentsView, which only access the controller
- SadTabView repositions and resizes subviews when browser window is resized, including (un)wrapping of message.
- action for link is decoupled from target to facilitate unittesting
- new SadTabControllerTest that tests initing controller with and without TabContents, and clicking on link

BUG=27212
TEST=Verify that "Aw Snap" page shows up correctly, with the new "Learn more" link centered beneath the message. Contents should be centered in window when the latter resizes. If necessary, message should be wrapped, or unwrapped if previously wrapped and new width can accommodate.
Review URL: http://codereview.chromium.org/432015
------------------------------------------------------------------------
r34583 | jrg@chromium.org | 2009-12-15 20:46:26 +0100 (Tue, 15 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc

Move channel (beta,dev,stable) determination code to a common location.
Add channel info to about:version.

Linux about box work not done.
Linux channel determination code still a stub.

BUG=30444

How to verify:
- on both Mac and Win, with a branded build:
- confirm the About Box and about:version have channel info after the version number.

Channel for PC comes from the registry so it'll be the channel of your official install, not this build.
Channel for Mac comes from the Info.plist so it WILL be from the current version; stable if undefined.

Review URL: http://codereview.chromium.org/506007
------------------------------------------------------------------------
r34580 | andybons@chromium.org | 2009-12-15 20:25:51 +0100 (Tue, 15 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/common/notification_type.h

Reattempt at r465143. The UI tests rely too heavily on the current behavior of closing the last window indicating exiting the entire app, so that is left alone for now with a TODO added.
From the old description:
Mac: Fixes bug where extension background hosts were being cleared when the last window was closed. It assumed that this meant the app was closing. Not the case with Mac apps. Added a mac-only notification APP_TERMINATED and use that to perform cleanup upon shutdown.

TEST=More description in the bug, but basically just make sure that background views stick around even after you've closed the last window.
BUG=28666 
Review URL: http://codereview.chromium.org/502012
------------------------------------------------------------------------
r34578 | akalin@chromium.org | 2009-12-15 20:20:08 +0100 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/mac/network_status_detector_task_mac.cc
   A /trunk/src/chrome/browser/sync/notifier/base/mac/network_status_detector_task_mac.h
   A /trunk/src/chrome/browser/sync/notifier/base/mac/network_status_detector_task_mac_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi

Implemented OS X version of NetworkStatusDetectorTaskMac.

BUG=none
TEST=trybots,manual testing

Review URL: http://codereview.chromium.org/485004
------------------------------------------------------------------------
r34576 | arv@chromium.org | 2009-12-15 19:47:14 +0100 (Tue, 15 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Hide the notifier when restoring all removed thumbnails.

BUG=29952
TEST=Blacklist a thumbanil. This shows the notifier. Then restore all remove
thumbnails. The notifier should be hidden now.

Review URL: http://codereview.chromium.org/494013
------------------------------------------------------------------------
r34566 | erg@google.com | 2009-12-15 18:38:28 +0100 (Tue, 15 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_pack.cc
   M /trunk/src/chrome/browser/browser_theme_pack.h
   M /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK: Fix regression where we don't build tinted buttons in GTK theme mode.

(Caused by my r34486)
TEST=Use GTK+ mode. page/app menu button should have same tint as title bar.
BUG=NONE

Review URL: http://codereview.chromium.org/507002
------------------------------------------------------------------------
r34561 | pinkerton@chromium.org | 2009-12-15 18:11:30 +0100 (Tue, 15 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/app_menu_model.cc
   A /trunk/src/chrome/browser/app_menu_model.h
   A /trunk/src/chrome/browser/app_menu_model_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Make a shared app menu model and update win and mac to use it. Remove the NSMenu from Toolbar.xib. 
BUG=22646
TEST=the app menu works as it used to.
Review URL: http://codereview.chromium.org/482006
------------------------------------------------------------------------
r34558 | tim@chromium.org | 2009-12-15 17:46:17 +0100 (Tue, 15 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h

Use a ConditionVariable in place of WaitableEvent in BookmarkModelWorker.

This is to ensure future changes to the code don't introduce harmful races
that could arise in presence of compiler optimizations due to the lack of
a barrier permitting instruction re-ordering.  The theoretical race that
exists now isn't causing any real malfunction today, but is causing
ThreadSanitizer warnings.

BUG=25915
TEST=BookmarkModelWorkerTest

Review URL: http://codereview.chromium.org/488012
------------------------------------------------------------------------
r34557 | mirandac@chromium.org | 2009-12-15 17:26:54 +0100 (Tue, 15 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Commit issue 464079 for feldstein: limit the clear browsing data window to only pop up once.

BUG= 24980
TEST= see http://codereview.chromium.org/464079/show
Review URL: http://codereview.chromium.org/501001
------------------------------------------------------------------------
r34556 | mirandac@chromium.org | 2009-12-15 17:26:26 +0100 (Tue, 15 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.h
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   A /trunk/src/chrome/browser/cocoa/hover_close_button.h
   A /trunk/src/chrome/browser/cocoa/hover_close_button.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/chrome_browser.gypi

Committing issue 484006 for feldstein.
Refactor close button to its own class.

BUG= 23641
TEST= see http://codereview.chromium.org/484006

Review URL: http://codereview.chromium.org/501003
------------------------------------------------------------------------
r34555 | kinuko@chromium.org | 2009-12-15 16:27:55 +0100 (Tue, 15 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/cross_origin_xhr_apitest.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc

Handle unexpected connection close during SSL handshake on Mac

SSLHandlshake may return errSSLClosedGraceful error code which is
interpreted as net::OK by NetErrorFromOSStatus, but the caller code
sometimes do not check status!=noErr cases if net_error==OK,
and this can lead unexpected status in the handshake sequence
(and causes ExtensionApiTest.CrossOriginXHR failure on Mac).

BUG=29711
TEST=ExtensionApiTest.CrossOriginXHR

Review URL: http://codereview.chromium.org/500018
------------------------------------------------------------------------
r34554 | pinkerton@chromium.org | 2009-12-15 15:28:31 +0100 (Tue, 15 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Enable/disable "next/previous tab" commands when there is only 1 tab.
BUG=26951
TEST=make sure next/previous tab menu items are correctly enabled/disabled based on the number of tabs.
------------------------------------------------------------------------
r34547 | jeremy@chromium.org | 2009-12-15 12:55:08 +0100 (Tue, 15 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/base/base.gypi
   M /trunk/src/base/file_util.h
   M /trunk/src/base/time.h
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/time_unittest.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/process_watcher.h
   A /trunk/src/chrome/common/process_watcher_mac.cc
   M /trunk/src/chrome/common/process_watcher_posix.cc
   A /trunk/src/chrome/common/process_watcher_unittest.cc

Make ProcessWatcher use kqueues on Mac.

* Port ProcessWatcher::EnsureProcessTerminated() to kqueue() APIs on OS X.
* Make ProcessWatcher::EnsureProcessGetsReaped() Linux-only, since it's only used there.
* Add a unit test.

BUG=12731
TEST=Open Chrome/Mac, open and close a few tabs.  Processes shouldn't stay around.

Review URL: http://codereview.chromium.org/496007
------------------------------------------------------------------------
r34545 | yurys@chromium.org | 2009-12-15 11:56:27 +0100 (Tue, 15 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc

DevTools: repair DevToolsExtensionDebugTest.TestContentScriptIsPresent

Review URL: http://codereview.chromium.org/500020
------------------------------------------------------------------------
r34543 | pfeldman@chromium.org | 2009-12-15 11:35:54 +0100 (Tue, 15 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Restore sanity tests tests.
BUG=30418

Review URL: http://codereview.chromium.org/505005
------------------------------------------------------------------------
r34540 | yusukes@google.com | 2009-12-15 10:15:39 +0100 (Tue, 15 Dec 2009) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/language_library.cc
   A /trunk/src/chrome/browser/chromeos/language_library.h
   A /trunk/src/chrome/browser/chromeos/language_menu_button.cc
   A /trunk/src/chrome/browser/chromeos/language_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome_browser.gypi

Implement "Language Switcher" for Chromium OS. This change enables users to switch their IME (input method) by clicking a menu button on the status area. Basic structure of the code is almost the same as power_menu_button and power_library.

Demo: http://dev.chromium.org/chromium-os/chromiumos-design-docs/text-input/demos

language_library.{cc,h}: UI-libcros glue. boilerplate code.
language_menu_button.{cc,h}: A button on the status area and its drop-down menu. Implements app/menus/menu_model.h interface.
status_area_view.{cc,h}: Put the language button on the status area.

BUG=494
TEST=Start Chromium OS. Click the menu button on the status area. Then verify that all IMEs you configured (via ibus-setup command, for now) is listed in the drop down menu.

Review URL: http://codereview.chromium.org/449050
------------------------------------------------------------------------
r34539 | kinuko@chromium.org | 2009-12-15 09:43:37 +0100 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

Minor fix to get browser/extensions/page_action_apitest.cc building on Mac

BUG=29895
TEST=build and run browser_tests, and see if it succeeds

Review URL: http://codereview.chromium.org/487026
------------------------------------------------------------------------
r34527 | rsesek@chromium.org | 2009-12-15 02:27:32 +0100 (Tue, 15 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm

[Mac] Close the font panel when closing the font settings sheet.

BUG=29885
TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings. Open a font panel by pressing Change then close the settings sheet by pressing Cancel. Font panel should not remain open.
------------------------------------------------------------------------
r34524 | tony@chromium.org | 2009-12-15 02:06:49 +0100 (Tue, 15 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Fix a leak added in r34510.  We need to delete old ChangeProcessors.

TBR=albertb

Review URL: http://codereview.chromium.org/503008
------------------------------------------------------------------------
r34522 | tony@chromium.org | 2009-12-15 01:43:17 +0100 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable anther DevTools sanity test that was missed in r34516.

BUG=30418
TBR=pfeldman

Review URL: http://codereview.chromium.org/500007
------------------------------------------------------------------------
r34516 | dglazkov@chromium.org | 2009-12-15 01:07:52 +0100 (Tue, 15 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable DevTools sanity tests pending investigation.

TBR=pfeldman
TEST=none
BUG=30418


Review URL: http://codereview.chromium.org/506005
------------------------------------------------------------------------
r34510 | albertb@google.com | 2009-12-15 00:14:03 +0100 (Tue, 15 Dec 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc (from /trunk/src/chrome/browser/sync/glue/change_processor.cc:34504)
   A /trunk/src/chrome/browser/sync/glue/bookmark_change_processor.h (from /trunk/src/chrome/browser/sync/glue/change_processor.h:34504)
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc (from /trunk/src/chrome/browser/sync/glue/model_associator.cc:34504)
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_associator.h (from /trunk/src/chrome/browser/sync/glue/model_associator.h:34504)
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   D /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi

I refactored ChangeProcessor so that the common stuff can be reused by other
data types. For ModelAssociator, I just extracted an interface. There's
probably more that can be reused, but I thought we would get to it once we
know more about what kind of associations the other data types will
require. In particular, I didn't use templates because none of the methods that
ProfileSyncService calls on ModelAssociator require a data-type specific type.

I didn't invest too much time refactoring the unit tests, so they're pretty
hacky. I believe the right thing to do would be to test PSS, CP and MA
seperately instead of having a giant PSS test that assumes we only care
about bookmarks.

BUG=29831,29832
TEST=Unit test

Review URL: http://codereview.chromium.org/477007
------------------------------------------------------------------------
r34509 | pamg@google.com | 2009-12-15 00:13:44 +0100 (Tue, 15 Dec 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

First steps toward page actions on Mac. Page action icons shold show and
perform their click actions when clicked. This is very rough, being committed
in an early form so more people can contribute to the effort.

Includes some early work from andybons too, toward making
popups work.

Known issues:
* Icons don't refresh properly when an extension is installed or removed.
Switching windows, then back again, updates the location bar properly.
* Right- and middle-clicks do nothing
* No tooltips, badges, installation previews, or popups yet
* No unit tests yet

BUG=12281
TEST=none yet
Review URL: http://codereview.chromium.org/427009
------------------------------------------------------------------------
r34504 | estade@chromium.org | 2009-12-14 23:02:35 +0100 (Mon, 14 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Add a regression test for http://crbug.com/29473

BUG=29473
TEST=it passes

Review URL: http://codereview.chromium.org/486037
------------------------------------------------------------------------
r34502 | chron@google.com | 2009-12-14 23:00:49 +0100 (Mon, 14 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html

Fix a few languages: sync dialog box was cutting off the cancel button.
Add padding to throbber.
Fix merge and sync cutoff.

BUG=27770, 29767, 29788, 29782, 29647
TEST=manually checked all languages,

Review URL: http://codereview.chromium.org/460123
------------------------------------------------------------------------
r34498 | kkania@chromium.org | 2009-12-14 22:42:57 +0100 (Mon, 14 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   A /trunk/src/chrome/browser/extensions/browser_action_test_util.h
   A /trunk/src/chrome/browser/extensions/browser_action_test_util_gtk.cc
   A /trunk/src/chrome/browser/extensions/browser_action_test_util_mac.mm
   A /trunk/src/chrome/browser/extensions/browser_action_test_util_views.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/renderer/resources/extension_apitest.js

Refactor browser action apitest and port for mac.
BUG=29709
TEST=none  
Review URL: http://codereview.chromium.org/443013
------------------------------------------------------------------------
r34497 | xiyuan@chromium.org | 2009-12-14 22:29:31 +0100 (Mon, 14 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Fix issue 30244

Ensure Alt is clear for our Ctrl+Shift/Shift+Ctrl logic so that Hebrew
IME generated Shift+Ctrl does not pass through and triggers RTL.

BUG=30244
TEST=Verify fix for 30244 and issue 24888 does not regress.

Review URL: http://codereview.chromium.org/497010
------------------------------------------------------------------------
r34496 | avi@chromium.org | 2009-12-14 22:25:20 +0100 (Mon, 14 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Disable "open in incognito window" for incognito windows.

BUG=http://crbug.com/24637
TEST=as in bug

Review URL: http://codereview.chromium.org/488018
------------------------------------------------------------------------
r34491 | mhm@chromium.org | 2009-12-14 21:57:31 +0100 (Mon, 14 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

[extensions] Position browser action popup correctly for RTL languages.

ExtensionPopup::Show was hard coded to use BubbleBorder::TOP_RIGHT, by changing it to be dynamic that depends on UI Layout fixes this issue.

BUG=29807
TEST=Change chrome language to Arabic, install Sidewiki, the popup will position itself correctly.

Review URL: http://codereview.chromium.org/494008
------------------------------------------------------------------------
r34490 | estade@chromium.org | 2009-12-14 21:51:29 +0100 (Mon, 14 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Persist the order of extensions in the browser action toolbar across sessions.

Very similar to what we did with the extension shelf.

BUG=26990

Review URL: http://codereview.chromium.org/487021
------------------------------------------------------------------------
r34489 | estade@chromium.org | 2009-12-14 21:51:16 +0100 (Mon, 14 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/common/notification_type.h

Fix extension shutdown notification, take 2.

The first patch was broken because a lot of stuff relied on the EXTENSION_PROCESS_CRASHED notification being sent when the extension hadn't actually "crashed". New fix: rename the notification to EXTENSION_PROCESS_TERMINATED, and don't send unload notifications during browser shutdown.

BUG=30057

Review URL: http://codereview.chromium.org/489009
------------------------------------------------------------------------
r34488 | estade@chromium.org | 2009-12-14 21:50:58 +0100 (Mon, 14 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Gtk: improve performance of tab dragging.

Remove two server trips and two byte swizzles by keeping the tab image server side (instead of piping it through an SkBitmap). This creates noticeably better performance on drawing attached dragged tabs (i.e. when you drag a tab to reorder it, but don't drag out of the tab strip) on non-compositing WMs (I suspect it is better for compositing as well, but did not test it).

BUG=21657
TEST=see above

Review URL: http://codereview.chromium.org/496002
------------------------------------------------------------------------
r34487 | akalin@chromium.org | 2009-12-14 21:49:04 +0100 (Mon, 14 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.cc
   M /trunk/src/chrome/browser/sync/sync_ui_util.h
   M /trunk/src/chrome/browser/sync/sync_ui_util_mac.mm
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Add a UI helper method to just get the sync status without needing labels.

Patch by thiago.farina@gmail.com ( original code review: http://codereview.chromium.org/469017 ).

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/486044
------------------------------------------------------------------------
r34486 | erg@google.com | 2009-12-14 21:48:07 +0100 (Mon, 14 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/base/data_pack_unittest.cc
   A /trunk/src/chrome/browser/browser_theme_pack.cc
   A /trunk/src/chrome/browser/browser_theme_pack.h
   A /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/browser_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_inactive
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_incognito
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_incognito_inactive
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_original
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_tab_background_incognito
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_tab_background_original
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/PreferencesTemplate

Try 2: Completely redo how themes are stored on disk and processed at install time.

Same as previous patch, except we now have a
BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in
ntp_resource_cache.cc.

BUG=24493,21121
TEST=All the new unit tests pass. All the complex theme startup tests go faster.

Previous Review URL: http://codereview.chromium.org/460050

Review URL: http://codereview.chromium.org/499004
------------------------------------------------------------------------
r34471 | cmasone@google.com | 2009-12-14 19:57:38 +0100 (Mon, 14 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Switch name of emit-login-prompt-ready target to use '_'; this fixes the scons build for chromium OS

TBR=davemoore

------------------------------------------------------------------------
r34463 | cmasone@google.com | 2009-12-14 18:42:12 +0100 (Mon, 14 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   A /trunk/src/chrome/browser/chromeos/image_background.h (from /trunk/src/chrome/browser/chromeos/image_background.h:34134)
   A /trunk/src/chrome/browser/chromeos/login_manager_view.cc (from /trunk/src/chrome/browser/chromeos/login_manager_view.cc:34134)
   A /trunk/src/chrome/browser/chromeos/login_manager_view.h (from /trunk/src/chrome/browser/chromeos/login_manager_view.h:34134)
   M /trunk/src/chrome/browser/chromeos/pipe_reader.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Retry landing the chrome-as-chromeos-login-manager change

Old CL: http://codereview.chromium.org/449023
Review URL: http://codereview.chromium.org/488007
------------------------------------------------------------------------
r34456 | ukai@chromium.org | 2009-12-14 11:34:54 +0100 (Mon, 14 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.h

Fix WebSocket crash bug.

When closing the tab, ResourceDispatcherHost::Receiver is deleted, so
all SocketStreamHost for the receiver should be deleted.
Add CancelRequestsForProcess() in SocketStreamDispatcherHost that deletes
all SocketStreamHost for the |host_id|.

BUG=30290
TEST=visit http://wbe02.mibbit.com/?debug=true&channel=%23websocket, and close the tab. Didn't crash the browser.

Review URL: http://codereview.chromium.org/494011
------------------------------------------------------------------------
r34445 | rsesek@chromium.org | 2009-12-13 18:01:54 +0100 (Sun, 13 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/font_language_settings_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h

Make KeywordEditorCocoaController implement the proper protocols. Also remove
unnecessary ones from FontLanguageSettingsController.

BUG=30155
TEST=Build with 10.6 SDK.

Review URL: http://codereview.chromium.org/496006
------------------------------------------------------------------------
r34444 | suzhe@chromium.org | 2009-12-13 06:39:18 +0100 (Sun, 13 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

[Windows] Fix issue 30123: REGRESSION: Alt-D causes system beep

BUG=30123
TEST=Press Alt+D should not beep.

Review URL: http://codereview.chromium.org/487035
------------------------------------------------------------------------
r34420 | yurys@chromium.org | 2009-12-12 07:49:47 +0100 (Sat, 12 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc

Reenable ExtensionDevToolsBrowserTest.TimelineApi

BUG=30087

Review URL: http://codereview.chromium.org/486033
------------------------------------------------------------------------
r34407 | viettrungluu@chromium.org | 2009-12-12 04:51:11 +0100 (Sat, 12 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/extension_shelf_controller.h
   D /trunk/src/chrome/browser/cocoa/extension_shelf_controller.mm
   D /trunk/src/chrome/browser/cocoa/extension_shelf_controller_unittest.mm
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Mac: remove extension shelf code.

Otherwise, I'll shortly have to update it and test other changes against the extension shelf (or let bitrot set in).

The extension shelf was removed from Chrome/Chromium. This code was left in for possible future use since doing so posed no cost. The corresponding code remains in the Windows version (for experimental purposes), but has also been removed from the Linux version. If this code is ever needed again, this patch will be the one to try to revert.

BUG=30178
TEST=Trybots, to make sure everything still compiles and unit tests run cleanly.

Review URL: http://codereview.chromium.org/495004
------------------------------------------------------------------------
r34402 | johnnyg@chromium.org | 2009-12-12 03:22:02 +0100 (Sat, 12 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc

Fix bad rearrangement of code which causes notifications to crash. 

BUG=30109
TEST=none

Review URL: http://codereview.chromium.org/490020
------------------------------------------------------------------------
r34401 | eroman@chromium.org | 2009-12-12 02:15:32 +0100 (Sat, 12 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/net/url_request/request_tracker.h
   M /trunk/src/net/url_request/request_tracker_unittest.cc

Exclude chrome:// requests from showing up on the about:net-internals page.

The problem is that most people would get to about:net-internals by first opening a new tab and then navigating it.
Opening a new tab page generates lots of requests, which could end up overwriting things we cared about in the circular buffer of recent requests.

BUG=30163

Review URL: http://codereview.chromium.org/491062
------------------------------------------------------------------------
r34396 | oshima@chromium.org | 2009-12-12 01:11:09 +0100 (Sat, 12 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc

Disabled toolstrip tests

BUG=30151
TEST=Run browser_tests and ui_tests on linux_views. toolstrip tests should be disabled.

Review URL: http://codereview.chromium.org/491058
------------------------------------------------------------------------
r34395 | mirandac@chromium.org | 2009-12-12 01:07:42 +0100 (Sat, 12 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/app/gfx/color_utils.cc
   M /trunk/src/app/gfx/color_utils.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Theme download status message, so that it's readable in themes of any color.

BUG= 21176
TEST= Download something large in a dark or light theme. Note that status update (notification of how much data is left to download) is legible.
Review URL: http://codereview.chromium.org/488002
------------------------------------------------------------------------
r34385 | erg@google.com | 2009-12-11 23:09:55 +0100 (Fri, 11 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/base/data_pack_unittest.cc
   D /trunk/src/chrome/browser/browser_theme_pack.cc
   D /trunk/src/chrome/browser/browser_theme_pack.h
   D /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/browser_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_inactive
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_incognito
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_incognito_inactive
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_original
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_tab_background_incognito
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_tab_background_original
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/PreferencesTemplate

Revert "Completely redo how themes are stored on disk and processed at install
time," as it fails valgrind tests.

This reverts commit 86faccd1028937a69ccc718718fd48c06c0cd471 (r34379).

Review URL: http://codereview.chromium.org/490025
------------------------------------------------------------------------
r34380 | agl@chromium.org | 2009-12-11 22:04:42 +0100 (Fri, 11 Dec 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   D /trunk/src/chrome/browser/strict_transport_security_persister.cc
   D /trunk/src/chrome/browser/strict_transport_security_persister.h
   A /trunk/src/chrome/browser/transport_security_persister.cc (from /trunk/src/chrome/browser/strict_transport_security_persister.cc:34379)
   A /trunk/src/chrome/browser/transport_security_persister.h (from /trunk/src/chrome/browser/strict_transport_security_persister.h:34379)
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.h
   A /trunk/src/net/base/https_prober.cc
   A /trunk/src/net/base/https_prober.h
   D /trunk/src/net/base/strict_transport_security_state.cc
   D /trunk/src/net/base/strict_transport_security_state.h
   D /trunk/src/net/base/strict_transport_security_state_unittest.cc
   A /trunk/src/net/base/transport_security_state.cc (from /trunk/src/net/base/strict_transport_security_state.cc:34379)
   A /trunk/src/net/base/transport_security_state.h
   A /trunk/src/net/base/transport_security_state_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc

SPDY: augment Strict Transport Security with the beginnings of SPDY upgrade.

This adds an opportunistic flag to the information that we store in
the Strict Transport Security State. Given this, STSS might be
misnamed now, but renaming it in this patch would add huge amounts of
noise.

We process the 'X-Bodge-Transport-Security' header which has the same
format as the STS header. When we see this on an HTTP connection,
we'll probe for a clean HTTPS path to the host and then remember it.
This header should be considered mutually exclusive with STS, although
this isn't enforced in the code.

The remembered flag is currently ignored by the rest of the code. This
will be addressed in a future patch.

The header should be called 'Opportunistic-Transport-Security' in the
future, but we have some issues to work out before we take that name.

http://codereview.chromium.org/456011
------------------------------------------------------------------------
r34379 | erg@google.com | 2009-12-11 21:55:30 +0100 (Fri, 11 Dec 2009) | 17 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.gypi
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/base/data_pack_unittest.cc
   A /trunk/src/chrome/browser/browser_theme_pack.cc
   A /trunk/src/chrome/browser/browser_theme_pack.h
   A /trunk/src/chrome/browser/browser_theme_pack_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/browser_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_inactive
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_incognito
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_incognito_inactive
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_frame_original
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_tab_background_incognito
   D /trunk/src/chrome/test/data/profiles/complex_theme/Default/Cached Theme Images/theme_tab_background_original
   A /trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/PreferencesTemplate

Completely redo how themes are stored on disk and processed at install time.

Rewrites most of BrowserThemeProvider and adds a new class
BrowserThemePack. BrowserThemePack takes all the logic of generating resources
out of the BrowserThemeProvider, does all of them at theme install time
(previously, we lazily generated all the button images and a good number of
colors, which muddled logic quite a bit), and then writes all the data out into
an mmap()able file to speed startup when a theme is installed.

In addition, this changes how the GtkThemeProvider works. The GtkThemeProvider
now generates all of its images lazily and doesn't reach into the
implementation details of BrowserThemeProvider as it used to.

BUG=24493,21121
TEST=All the new unit tests pass. All the complex theme startup tests go faster.

Review URL: http://codereview.chromium.org/460050
------------------------------------------------------------------------
r34374 | andybons@chromium.org | 2009-12-11 21:08:55 +0100 (Fri, 11 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/common/notification_type.h

Rolling back r34316 due to tab_switching_test failing. TBR=scherkus

TEST=none
BUG=none
------------------------------------------------------------------------
r34368 | evan@chromium.org | 2009-12-11 20:40:57 +0100 (Fri, 11 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_posix.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_win.cc

sync: Fix license copyright text.

Checked with debian/licensecheck.pl

BUG=28291

Review URL: http://codereview.chromium.org/495001
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r34360 | ananta@chromium.org | 2009-12-11 20:21:48 +0100 (Fri, 11 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc

The ChromeFrame net tests randomly crash in the url request redirect tests on the chrome frame builder.
Some debugging revealed that we send over two redirect responses from the IE host network stack implementation
to Chrome, which causes a crash in the url request automation job while dereferencing a NULL request.

Two redirect responses are sent in the following scenario:-
1. We received a redirect notification in our bind status callback. We abort the binding and return E_ABORT.
2. Eventually we receive a call in our bind status callback implementation of OnResponse even after the binding
   was aborted. This causes the response to be sent twice.

Added a check for a NULL binding and a trace in the IE host network stack implementation. I also added
a NOTREACHED in the url request automation job if we ever receive a message for an automation job which
has a NULL request.

Bug=30118

Review URL: http://codereview.chromium.org/487028
------------------------------------------------------------------------
r34356 | johnnyg@chromium.org | 2009-12-11 19:05:24 +0100 (Fri, 11 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Change the cookies view so that the remove buttons are only enabled when there are cookies in the list to remove.

BUG=27663
TEST=none

Review URL: http://codereview.chromium.org/486027
------------------------------------------------------------------------
r34353 | oshima@chromium.org | 2009-12-11 18:54:59 +0100 (Fri, 11 Dec 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

TBR: sky@chromium.org
------------------------------------------------------------------------
r34351 | davemoore@chromium.org | 2009-12-11 18:39:18 +0100 (Fri, 11 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Creating new CL for uploading a picture from ChromiumOS

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/452016
------------------------------------------------------------------------
r34350 | davemoore@chromium.org | 2009-12-11 18:18:06 +0100 (Fri, 11 Dec 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/cros_api.gyp
   M /trunk/src/chrome/chrome_browser.gypi

Moves cros_api.gyp into Chrome. The current situation (cros_api.gyp
living in third_party/cros) won't work as the SConstruct file in
third_party/cros is different than the one Chrome wants (it's for the
Chrome OS side). As a result, when chrome gclient syncs it clobbers
third_party/cros/SConstruct and further syncs fail.

Review URL: http://codereview.chromium.org/487016
------------------------------------------------------------------------
r34348 | maruel@chromium.org | 2009-12-11 17:30:16 +0100 (Fri, 11 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/app/clipboard/scoped_clipboard_writer.cc
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/password_manager/encryptor_win.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   M /trunk/src/webkit/database/databases_table.cc
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc

Use utf_string_conversions header in more places.

Patch contributed by Thiago Farina (thiago.farina@gmail.com)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/465065
------------------------------------------------------------------------
r34346 | yurys@chromium.org | 2009-12-11 15:56:14 +0100 (Fri, 11 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc

Pass one empty argument to ApuAgentDelegate.DispatchToApu to match ExtensionDevToolsBridge::OnRpcMessage.

BUG=30087

Review URL: http://codereview.chromium.org/491046
------------------------------------------------------------------------
r34342 | yurys@chromium.org | 2009-12-11 12:34:55 +0100 (Fri, 11 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc

Temporarily disable ExtensionDevToolsBrowserTest.TimelineApi which is failing after 34337

TBR=pfeldman
BUG=30087

Review URL: http://codereview.chromium.org/490015
------------------------------------------------------------------------
r34337 | yurys@chromium.org | 2009-12-11 10:08:17 +0100 (Fri, 11 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   A /trunk/src/webkit/glue/devtools/devtools_message_data.cc
   A /trunk/src/webkit/glue/devtools/devtools_message_data.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc_js.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.h
   M /trunk/src/webkit/webkit.gyp

DevTools: use WebDevToolsMessageData for devtools rpc messages

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34333

Review URL: http://codereview.chromium.org/463065
------------------------------------------------------------------------
r34334 | yurys@chromium.org | 2009-12-11 07:45:13 +0100 (Fri, 11 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   D /trunk/src/webkit/glue/devtools/devtools_message_data.cc
   D /trunk/src/webkit/glue/devtools/devtools_message_data.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc_js.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.h
   M /trunk/src/webkit/webkit.gyp

Revert "DevTools: use WebDevToolsMessageData for devtools rpc messages"

This reverts commit ea393f34b293ebf8b96bef5855b9f41faf82b192.

Review URL: http://codereview.chromium.org/492018
------------------------------------------------------------------------
r34333 | yurys@chromium.org | 2009-12-11 07:37:15 +0100 (Fri, 11 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   A /trunk/src/webkit/glue/devtools/devtools_message_data.cc
   A /trunk/src/webkit/glue/devtools/devtools_message_data.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc_js.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.h
   M /trunk/src/webkit/webkit.gyp

DevTools: use WebDevToolsMessageData for devtools rpc messages

Review URL: http://codereview.chromium.org/463065
------------------------------------------------------------------------
r34332 | xiyuan@chromium.org | 2009-12-11 07:13:51 +0100 (Fri, 11 Dec 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.h
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/web_applications/web_app.h

Get web app icon via FavIconHelper and auto repair/update

- Expose a DownloadImage method from FavIconHelper to download/decode
  image for an image url;
- Expose FavIconHelper from TabContents;
- Update CreateApplicationShortcutView to use the exposed DownloadImage
  method to get web app icon instead of do it via URLFetcher/PNGCodec;
- Check and update web app icon and shortcuts when chrome is lauched as
  app for OS_WIN;
- Code cleanup:
  - Move a bunch of FavIconHelper methods that are not used externally
    to private;
  - Remove an unused cancelable_consumer_ from TabContents;

BUG=8539
TEST=Verify issue 8539 is fixed. And create a web page with a non PNG shortcut icon and verify it shows up in create application shortcut dialog.

Review URL: http://codereview.chromium.org/482003
------------------------------------------------------------------------
r34324 | estade@chromium.org | 2009-12-11 04:19:39 +0100 (Fri, 11 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h

Revert r34321 as it breaks the task manager:

------------------------------------------------------------------------
r34321 | estade@chromium.org | 2009-12-10 18:19:50 -0800 (Thu, 10 Dec 2009) | 5 lines

Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process is fast-terminated (i.e., didn't crash).

BUG=30057

Review URL: http://codereview.chromium.org/492014


Review URL: http://codereview.chromium.org/487023
------------------------------------------------------------------------
r34322 | estade@chromium.org | 2009-12-11 03:20:21 +0100 (Fri, 11 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Find bar fixes:

- prefer previous find from same tab contents over overall most recent find when re-opening find bar
- GTK + Windows: always update find bar view text if it doesn't match the search results.

TEST=see bug for repro steps
BUG=30006

Review URL: http://codereview.chromium.org/482015
------------------------------------------------------------------------
r34321 | estade@chromium.org | 2009-12-11 03:19:50 +0100 (Fri, 11 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h

Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process is fast-terminated (i.e., didn't crash).

BUG=30057

Review URL: http://codereview.chromium.org/492014
------------------------------------------------------------------------
r34319 | oshima@chromium.org | 2009-12-11 02:31:01 +0100 (Fri, 11 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h

fix chromeos build

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/492013
------------------------------------------------------------------------
r34316 | andybons@chromium.org | 2009-12-11 01:46:43 +0100 (Fri, 11 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/common/notification_type.h

Mac: Fixes bug where extension background hosts were being cleared when the last window was closed. It assumed that this meant the app was closing. Not the case with Mac apps. Added a mac-only notification APP_TERMINATED and use that to perform cleanup upon shutdown.

TEST=More description in the bug, but basically just make sure that background views stick around even after you've closed the last window.
BUG=28666
Review URL: http://codereview.chromium.org/465143
------------------------------------------------------------------------
r34311 | jhawkins@chromium.org | 2009-12-11 01:18:25 +0100 (Fri, 11 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/form_field.cc
   A /trunk/src/chrome/browser/autofill/phone_field.cc
   A /trunk/src/chrome/browser/autofill/phone_field.h
   M /trunk/src/chrome/chrome_browser.gypi

Implement PhoneField, a FormField that matches a phone number field in a form.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/488010
------------------------------------------------------------------------
r34301 | jrg@chromium.org | 2009-12-11 00:20:21 +0100 (Fri, 11 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Display channel in about box after version.  Windows.

BUG=3000
TEST=see bug

Review URL: http://codereview.chromium.org/463062
------------------------------------------------------------------------
r34293 | estade@chromium.org | 2009-12-10 23:23:12 +0100 (Thu, 10 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Fix chromiumos build, try 2

tbr=oshima

------------------------------------------------------------------------
r34291 | estade@chromium.org | 2009-12-10 23:12:56 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Fix chromeos compile

TBR=wtc


------------------------------------------------------------------------
r34290 | ananta@chromium.org | 2009-12-10 22:55:08 +0100 (Thu, 10 Dec 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/automation/automation_provider_unittest.cc
   A /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.cc
   A /trunk/src/chrome/browser/automation/chrome_frame_automation_provider.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

ChromeFrame uses the IPC automation channel to talk to Chrome. The IPC messages sent by ChromeFrame
are handled by the AutomationProvider class in Chrome, which also handles other IPC's not used by
ChromeFrame. 

We now have a new class ChromeFrameAutomationProvider which derives from the AutomationProvider 
class and validates that incoming IPC messages are valid ChromeFrame messages.

Bug=29931
Test=Covered by unit test

Review URL: http://codereview.chromium.org/476008
------------------------------------------------------------------------
r34286 | zork@chromium.org | 2009-12-10 22:46:02 +0100 (Thu, 10 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

Fix sync options to properly hide the link when the dialog is first shown.

BUG=29762
TEST=Open the options dialog.  Note that there is no invisible rectangle.

Review URL: http://codereview.chromium.org/492006
------------------------------------------------------------------------
r34285 | estade@chromium.org | 2009-12-10 22:40:32 +0100 (Thu, 10 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   A /trunk/src/chrome/browser/renderer_preferences_util.cc
   A /trunk/src/chrome/browser/renderer_preferences_util.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/renderer/render_view.cc

re-apply r34183

---------------
linux: theme scrollbars from GTK theme 

Pick the color of the slider's thumbpart and rail from the GTK theme. 
We cannot match the exact visual appearance of the GTK theme, as 
rendering engines can make arbitrary changes to the actual visual 
appearance. But by sampling a representative set of pixels, we ensure 
that we will at least match the general color scheme. 

BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show

Review URL: http://codereview.chromium.org/479006
------------------------------------------------------------------------
r34283 | albertb@google.com | 2009-12-10 22:19:34 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Fix the crashing chromeos sync tests and revert the patch that disabled them.

BUG=29994

Review URL: http://codereview.chromium.org/490007
------------------------------------------------------------------------
r34281 | shess@chromium.org | 2009-12-10 22:18:03 +0100 (Thu, 10 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm

[Mac] Attempt to fix ref-after-free problems with NSTableView dataSource.

Clearing dataSource in the source's -dealloc seems generally good.
HungRendererController having a local copy of the titles is in case
the table view is redrawn as part of closing the window (this can
happen if the window is closed while the user is mousing on the
table, and perhaps at other times).

BUG=29558
TEST=Crash noted in bug stops happening.

Review URL: http://codereview.chromium.org/469016
------------------------------------------------------------------------
r34279 | zork@google.com | 2009-12-10 22:11:18 +0100 (Thu, 10 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Give the proper error message in the case where you attempt to log int
o bookmark sync while offline.

BUG=19738
TEST=Attempt to log in to bookmark sync while offline.  The error should be
"Connection Unavailable"
Review URL: http://codereview.chromium.org/455038
------------------------------------------------------------------------
r34272 | estade@chromium.org | 2009-12-10 21:10:15 +0100 (Thu, 10 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: hook up drag and drop of browser actions (for reordering).

The changes are propagated across open chrome windows, but are not persisted between sessions yet.

BUG=26990

Review URL: http://codereview.chromium.org/463056
------------------------------------------------------------------------
r34271 | phajdan.jr@chromium.org | 2009-12-10 21:04:35 +0100 (Thu, 10 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_listener.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/global_request_id.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   A /trunk/src/chrome/browser/renderer_host/resource_queue.cc
   A /trunk/src/chrome/browser/renderer_host/resource_queue.h
   A /trunk/src/chrome/browser/renderer_host/resource_queue_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Implement ResourceQueue, an object that makes it easy to delay starting
requests in ResourceDispatcherHost until specified conditions are met.

Make UserScriptListener use ResourceQueue.

This is the first step toward waiting for the privacy blacklists to load.

TEST=Covered by unit_tests.
BUG=21541

Review URL: http://codereview.chromium.org/460108
------------------------------------------------------------------------
r34270 | tony@chromium.org | 2009-12-10 20:56:19 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc

Fix a case where we try to get the homepage as a boolean value, when
it should be a string.  Since we tried to get the pref as the wrong
type, we never set the value homepage_defined so it's always false.

Review URL: http://codereview.chromium.org/491008
------------------------------------------------------------------------
r34263 | asargent@chromium.org | 2009-12-10 20:09:48 +0100 (Thu, 10 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Prevent 2 types of extension crashes.

If javascript code puts custom toJSON functions on Array.prototype, our 
extension API code detects malformed requests and kills the offending renderer.

Also, the browser can crash if a browser action popup process dies (for various
reasons, including this json serialization problem).


BUG=29283
TEST=Create an extension with a browser action popup that loads prototype.js, and then calls chrome.tabs.update(). 
Before this change, the popup bubble will crash, and when you click away, crash the browser too. 

Review URL: http://codereview.chromium.org/466065
------------------------------------------------------------------------
r34258 | xiyuan@chromium.org | 2009-12-10 19:02:51 +0100 (Thu, 10 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   A /trunk/src/chrome/test/data/onload_redirect_to_anchor.html

Add FaviconOfOnloadRedirectToAnchorPage for issue 15782

BUG=15782
TEST=None

Review URL: http://codereview.chromium.org/418006
------------------------------------------------------------------------
r34257 | dglazkov@chromium.org | 2009-12-10 18:58:25 +0100 (Thu, 10 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Add command line flag and associated prefs to allow run-time enable of geolocaiton features.
Once this is landed we can enable GEOLOCATION in WebKit at build time, allowing proper tests
to be written that utilize this flag.

BUG=29182
TEST=Manually enabled GEOLOCATION in WebKit and passed the command line flag.

Review URL: http://codereview.chromium.org/460020
------------------------------------------------------------------------
r34254 | sky@chromium.org | 2009-12-10 18:24:38 +0100 (Thu, 10 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Disables a handful of tests for chromeos as they're crashing.

BUG=29994
TEST=none
TBR=albertb

Review URL: http://codereview.chromium.org/486013
------------------------------------------------------------------------
r34253 | thomasvl@chromium.org | 2009-12-10 18:21:53 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Marking test as flaky since it is failing in release >50% of the time now.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/489003
------------------------------------------------------------------------
r34234 | suzhe@chromium.org | 2009-12-10 07:01:48 +0100 (Thu, 10 Dec 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/test/test_browser_window.h

Refactor the keyboard events handling code related to RenderViewHostDelegate::View and TabContentsDelegate interfaces.

Significant changes made by this CL:
1. The keyboard event handling code has been moved from TabContentsView implementation classes into BrowserWindow implementation classes.
Please refer to this discussion thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/e6e0b5cc105659b7/9953c4308bb0000c
This change makes the keyboard event flow comply with the relationship between TabContents/TabContentsView and TabContentsDelegate/BrowserWindow.
Besides it, the code is also simplified a lot, for example, the keyboard event handling code in chrome/browser/views/tab_contents/tab_contents_view_{gtk,win}.cc are now merged into one copy and moved into chrome/browser/views/frame/browser_view.cc.

2. A pre-handle phrase has been added into the keyboard event handling flow. A keyboard event will be first sent to the browser for pre-handling before being sent to the renderer. Then if the event was not handled by the renderer, it'll be sent to the browser again for post-handling.

3. The keyboard accelerator handling code of Windows and Linux ports have been optimized to get rid off extra command lookup.

4. The keyboard event message flow between the browser and the renderer is changed back to full async mode, all complex logics introduced by revision 29857 are removed.


BUG=24479, 26054, 26131, 28839
TEST=See bug reports.


Review URL: http://codereview.chromium.org/400012
------------------------------------------------------------------------
r34227 | sehr@google.com | 2009-12-10 04:21:14 +0100 (Thu, 10 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/tools/pepper_test_plugin/README
   M /trunk/src/webkit/tools/pepper_test_plugin/event_handler.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp

Re-enable the build of Pepper support by default (issue 464074, svn revision 34161).
There were problems building Skia and others for the 64-bit linux versions of the
Pepper test plugin, so I have disabled building that plugin except on Windows for now
and added a TODO.

One significant addition to the previous comment lines. The flag enable_gpu=1 now
causes the build definition ENABLE_GPU=1 to allow guarding of dependent code.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/481001
------------------------------------------------------------------------
r34222 | thestig@chromium.org | 2009-12-10 03:08:10 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   A /trunk/src/sandbox/linux/suid/process_util.h
   A /trunk/src/sandbox/linux/suid/process_util_linux.c
   M /trunk/src/sandbox/linux/suid/sandbox.c
   M /trunk/src/sandbox/sandbox.gyp

Linux: Adjust /proc/pid/oom_adj to sacrifice plugin and renderer processes to the OOM killer.

BUG=29752
TEST=During out of memory conditions, Linux kernel picks a plugin/renderer over the browser process.
Review URL: http://codereview.chromium.org/467058
------------------------------------------------------------------------
r34220 | thestig@chromium.org | 2009-12-10 03:02:20 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/browser_main_gtk.cc

Linux: Implement RecordBreakpadStatusUMA.

BUG=21732
TEST=none
Review URL: http://codereview.chromium.org/489002
------------------------------------------------------------------------
r34219 | twiz@google.com | 2009-12-10 02:59:11 +0100 (Thu, 10 Dec 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_host.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/views/widget/widget_win.cc

A collection of fixes allowing the chrome.experimental.popup.* set of APIs to function in circumstances where there is no Browser instance present.  This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API.  I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup
Review URL: http://codereview.chromium.org/434046
------------------------------------------------------------------------
r34216 | albertb@google.com | 2009-12-10 02:41:31 +0100 (Thu, 10 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Fix typo in ifdef for enabling auth bootstraping on Chrome OS

Review URL: http://codereview.chromium.org/481008
------------------------------------------------------------------------
r34207 | mattm@chromium.org | 2009-12-10 01:05:34 +0100 (Thu, 10 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Linux: Make page_action_hbox_ an OwnedWidget.

UpdatePageActions() can get called after the gtk widgets have been destroyed.

BUG=29757
TEST=see bug

Review URL: http://codereview.chromium.org/476007
------------------------------------------------------------------------
r34206 | tony@chromium.org | 2009-12-10 01:04:48 +0100 (Thu, 10 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_dummy.cc
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_mac.mm
   M /trunk/src/app/resource_bundle_posix.cc
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/common/extensions/extension_l10n_util.h
   M /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/test/testing_browser_process.h

Make BrowserProcess::GetApplicationLocale thread safe and migrate
callers of l10n_util::GetApplicationLocale to use this instead.

In the browser process, it's wrong to call
l10n_util::GetApplicationLocale with an empty string because then
it won't consider the user pref value when resolving the locale.

On Linux, it's also wrong to call l10n_util::GetApplicationLocale
after startup because the call touches disk and on Linux, we assume
that all of the program files can be deleted after startup (so
updates in place can work).

Review URL: http://codereview.chromium.org/476002
------------------------------------------------------------------------
r34203 | evan@chromium.org | 2009-12-10 00:53:18 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

extensions: Properly use string16 for Unicode text.

BUG=29850

Review URL: http://codereview.chromium.org/477011
------------------------------------------------------------------------
r34201 | jhawkins@chromium.org | 2009-12-10 00:42:34 +0100 (Thu, 10 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_field.cc
   M /trunk/src/chrome/browser/autofill/autofill_field.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/autofill/field_types.h
   A /trunk/src/chrome/browser/autofill/form_field.cc
   A /trunk/src/chrome/browser/autofill/form_field.h
   M /trunk/src/chrome/browser/autofill/form_structure.cc
   M /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   M /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/chrome_browser.gypi

autofill: Add the FormField interface.  Classes that implement the FormField interface provide heuristics for determining the type of a form field.  An initial implementation, EmailField, is provided.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/469013
------------------------------------------------------------------------
r34197 | davemoore@chromium.org | 2009-12-09 23:34:34 +0100 (Wed, 09 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Add some spacing so that status area lines up on cros

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/483002
------------------------------------------------------------------------
r34196 | thomasvl@chromium.org | 2009-12-09 23:07:02 +0100 (Wed, 09 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/cross_origin_xhr_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] more browser_tests cleanup
- get extension_browsertests_misc compiling
- mark a bunch of tests with bugs and dependencies before they can come online
- bring a bunch of tests online (also on linux)

- Also removed some variables only used in one spot in the gyp file now.
- Update all the browser_tests to use the MAYBE_ pattern to make sure we never get a conflict on the define

BUG=none
TEST=waterfall stays green
Review URL: http://codereview.chromium.org/475008
------------------------------------------------------------------------
r34193 | evan@chromium.org | 2009-12-09 22:43:02 +0100 (Wed, 09 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/encryptor_linux.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc

linux: remove a NOTIMPL since we have a bug on it

Also, update some comments to use the new bug number.

BUG=8205,25404

Review URL: http://codereview.chromium.org/483003
------------------------------------------------------------------------
r34192 | jrg@chromium.org | 2009-12-09 22:26:14 +0100 (Wed, 09 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Display channel after version in about box.  Mac.

BUG=29917
TEST=Open about box on dev and beta.  See channel in about box after version.

Review URL: http://codereview.chromium.org/463063
------------------------------------------------------------------------
r34187 | estade@chromium.org | 2009-12-09 21:26:43 +0100 (Wed, 09 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   D /trunk/src/chrome/browser/renderer_preferences_util.cc
   D /trunk/src/chrome/browser/renderer_preferences_util.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/renderer/render_view.cc

rollback r34183

tbr=asargent

Review URL: http://codereview.chromium.org/482002
------------------------------------------------------------------------
r34183 | estade@chromium.org | 2009-12-09 21:11:39 +0100 (Wed, 09 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   A /trunk/src/chrome/browser/renderer_preferences_util.cc
   A /trunk/src/chrome/browser/renderer_preferences_util.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/renderer/render_view.cc

linux: theme scrollbars from GTK theme 

Pick the color of the slider's thumbpart and rail from the GTK theme. 
We cannot match the exact visual appearance of the GTK theme, as 
rendering engines can make arbitrary changes to the actual visual 
appearance. But by sampling a representative set of pixels, we ensure 
that we will at least match the general color scheme. 

BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show

Review URL: http://codereview.chromium.org/466080
------------------------------------------------------------------------
r34179 | pinkerton@chromium.org | 2009-12-09 20:56:30 +0100 (Wed, 09 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/app/menus/simple_menu_model.h
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/menu_controller.h
   A /trunk/src/chrome/browser/cocoa/menu_controller.mm
   A /trunk/src/chrome/browser/cocoa/menu_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   A /trunk/src/chrome/browser/page_menu_model.cc
   A /trunk/src/chrome/browser/page_menu_model.h
   A /trunk/src/chrome/browser/page_menu_model_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Share the code that builds the page menu in a common model, make Mac and Win use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code.
BUG=22646
TEST=page menu should work as before
Review URL: http://codereview.chromium.org/465130
------------------------------------------------------------------------
r34177 | pkasting@chromium.org | 2009-12-09 20:41:41 +0100 (Wed, 09 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/app/app_base.gypi
   A /trunk/src/app/gfx/scrollbar_size.cc
   A /trunk/src/app/gfx/scrollbar_size.h
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Change most callers of NativeScrollbar size functions to use a dedicated function that matches WebKit instead, since the callers really care about content area scrollbars.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/463061
------------------------------------------------------------------------
r34176 | oshima@chromium.org | 2009-12-09 20:40:00 +0100 (Wed, 09 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc

fix for memory leak and illegal access, 2nd attempt.
* ExternalMetrics class requires scoped_refptr.
 original CL : http://codereview.chromium.org/470006

BUG=None
TEST=Run unit_test with valgrind.

patch from issue 470006

Review URL: http://codereview.chromium.org/465140
------------------------------------------------------------------------
r34175 | wtc@chromium.org | 2009-12-09 20:35:54 +0100 (Wed, 09 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.h

Define X509Certificate::intermediate_ca_certs_ as a std::vector of
OSCertHandle so that we can also use it on Windows.

Remove the unused SSLClientSocketMac::intermediate_certs_ member.

R=hawk
BUG=28744
TEST=Can visit good HTTPS sites with no certificate errors.  Clicking
the "Certificate information" button in the page security information
window should show a complete certificate chain (as opposed to just
the server certificate).
Review URL: http://codereview.chromium.org/452042
------------------------------------------------------------------------
r34168 | mirandac@chromium.org | 2009-12-09 20:05:25 +0100 (Wed, 09 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Fix delete day so that font is correct and it can be reached through tab.

Landing for eisinger.

BUG= 21459
TEST= On history page, font for delete day msg is correct, and you can tab to it.
Review URL: http://codereview.chromium.org/473004
------------------------------------------------------------------------
r34162 | sehr@google.com | 2009-12-09 18:45:03 +0100 (Wed, 09 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/README
   M /trunk/src/webkit/tools/pepper_test_plugin/event_handler.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp

Revert 34161 - Enable Pepper support by default, including building the test plugin.
This is needed because the NaCl plugin code that runs in the renderer
needs to use Pepper APIs all the time, and NaCl support has been enabled
by default for several months now.  To cause an untrusted Pepper plugin
to run in the renderer one needs to specify the internalpepper flag.
I have also removed the enable_pepper flag from gyp.  As the build of the
GPU process was tied to this flag, I have renamed the flag to enable_gpu.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/464074

TBR=sehr@google.com
Review URL: http://codereview.chromium.org/475004
------------------------------------------------------------------------
r34161 | sehr@google.com | 2009-12-09 18:19:22 +0100 (Wed, 09 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome_renderer.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/plugins/npapi_extension_thunk.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/README
   M /trunk/src/webkit/tools/pepper_test_plugin/event_handler.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp

Enable Pepper support by default, including building the test plugin.
This is needed because the NaCl plugin code that runs in the renderer
needs to use Pepper APIs all the time, and NaCl support has been enabled
by default for several months now.  To cause an untrusted Pepper plugin
to run in the renderer one needs to specify the --internal-pepper flag.
I have also removed the enable_pepper flag from gyp.  As the build of the
GPU process was tied to this flag, I have renamed the flag to enable_gpu.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/464074
------------------------------------------------------------------------
r34154 | pfeldman@chromium.org | 2009-12-09 15:36:33 +0100 (Wed, 09 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.h
   M /trunk/src/webkit/glue/webmenuitem.h

Chromium: support custom WebCore context menu items in Chromium port (downstream).

Review URL: http://codereview.chromium.org/465123
------------------------------------------------------------------------
r34147 | thakis@chromium.org | 2009-12-09 09:04:53 +0100 (Wed, 09 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc
   D /trunk/src/chrome/browser/mach_broker_mac.cc
   D /trunk/src/chrome/browser/mach_broker_mac.h
   D /trunk/src/chrome/browser/mach_broker_mac_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/mach_ipc_mac.h
   M /trunk/src/chrome/common/mach_ipc_mac.mm
   M /trunk/src/chrome/renderer/renderer_main.cc

Revert 34146 - A place to store the pid>mach_port_t mapping.

Not yet for review.

Landing to measure perf impact, will revert immediately.

BUG=13156
TEST=unittests

Review URL: http://codereview.chromium.org/460126

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/466088
------------------------------------------------------------------------
r34146 | thakis@chromium.org | 2009-12-09 08:54:32 +0100 (Wed, 09 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc
   A /trunk/src/chrome/browser/mach_broker_mac.cc
   A /trunk/src/chrome/browser/mach_broker_mac.h
   A /trunk/src/chrome/browser/mach_broker_mac_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/mach_ipc_mac.h
   M /trunk/src/chrome/common/mach_ipc_mac.mm
   M /trunk/src/chrome/renderer/renderer_main.cc

A place to store the pid->mach_port_t mapping.

Not yet for review.

Landing to measure perf impact, will revert immediately.

BUG=13156
TEST=unittests

Review URL: http://codereview.chromium.org/460126
------------------------------------------------------------------------
r34145 | hbono@chromium.org | 2009-12-09 08:14:45 +0100 (Wed, 09 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Reverts my r4300 and re-fixes Issue 3156 and 13500.
My r4300, which is a fix Issue 3156, has been causing regressions (Issue 9596, Issue 13500, Issue 29290, etc.)
Every time when this change caused regressions, we added more code to Chromium and made Chromium code more complicated.
So, I think it is better to revert this change once and find another solution for Issue 3156 rather than to add another workaround for Issue 29290.

To look into Issue 3156 more deeply, it is caused by a recursive message-handler call.
When SetWindowText() is called while an IME is composing text, the IME calls SendMessage() to send a WM_IME_COMPOSITION message.
When we receive this WM_IME_COMPOSITION message, it updates the omnibox and calls SetWindowText()...
This recursive call caused not only Issue 3156 but also caused some other IME issues, such as Issue 13500.

BUG=3156,13500,29290
TEST=On XP, open a new tab, set the IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate and show the popup URL without a crash.
TEST=Open Gmail, compose a new e-mail (without using a tear-off window), set the IME to Hiragana, type 'c' in its message body, and wait for the draft auto-saving. The browser should show the 'c' character.
Review URL: http://codereview.chromium.org/467015
------------------------------------------------------------------------
r34141 | sky@chromium.org | 2009-12-09 06:08:07 +0100 (Wed, 09 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fixes bugs with panels. We weren't setting the type at the right time
and needed to set a size_request so that the title gets the right
size.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/466081
------------------------------------------------------------------------
r34140 | sky@chromium.org | 2009-12-09 06:06:51 +0100 (Wed, 09 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes bug so that if we restore popups (as we do on chrome os) we
restore them to the correct size.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/471002
------------------------------------------------------------------------
r34136 | andybons@chromium.org | 2009-12-09 05:14:02 +0100 (Wed, 09 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/extensions/extension_host_mac.h
   A /trunk/src/chrome/browser/extensions/extension_host_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/chrome_browser.gypi

Fixes issue where clicking on a <SELECT> dropdown in an extension popup window would hard crash the browser.

I'm hoping that this will open up discussions for refactoring work amongst ExtensionHost and TabContentsView, since
so much code is shared between the two and both need sufficient Mac love.

BUG=29353
TEST=load a browser action with a popup that contains a SELECT element. click on the element and observe that it acts normally (no crashing).
Review URL: http://codereview.chromium.org/465108
------------------------------------------------------------------------
r34135 | jrg@chromium.org | 2009-12-09 04:34:13 +0100 (Wed, 09 Dec 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/chromium/login_background.png
   D /trunk/src/chrome/app/theme/chromium/login_panel.png
   D /trunk/src/chrome/app/theme/chromium/login_splash.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   D /trunk/src/chrome/browser/chromeos/image_background.h
   D /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   D /trunk/src/chrome/browser/chromeos/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 34134 - Viewsbased login window for Chrome OS.  Doesn't yet actually do anything
Review URL: http://codereview.chromium.org/449023

TBR=cmasone@google.com
Review URL: http://codereview.chromium.org/467060
------------------------------------------------------------------------
r34134 | cmasone@google.com | 2009-12-09 04:14:40 +0100 (Wed, 09 Dec 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/app/theme/chromium/login_background.png
   A /trunk/src/chrome/app/theme/chromium/login_panel.png
   A /trunk/src/chrome/app/theme/chromium/login_splash.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   A /trunk/src/chrome/browser/chromeos/image_background.h
   A /trunk/src/chrome/browser/chromeos/login_manager_view.cc
   A /trunk/src/chrome/browser/chromeos/login_manager_view.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Views-based login window for Chrome OS.  Doesn't yet actually do anything
Review URL: http://codereview.chromium.org/449023
------------------------------------------------------------------------
r34133 | estade@chromium.org | 2009-12-09 04:08:50 +0100 (Wed, 09 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/installer/util/lzma_util.cc
   M /trunk/src/net/tools/dump_cache/cache_dumper.h

Minor cleanup; remove deprecate file_util function and some obsolete TODOs.

Review URL: http://codereview.chromium.org/467030
------------------------------------------------------------------------
r34121 | willchan@chromium.org | 2009-12-09 02:22:14 +0100 (Wed, 09 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Revert 34110 - Fix leak of ShutdownDetector.  Broke Mac startup_test.
For some reason I thought that nonjoinable threads would always delete their delegates.  I was wrong.
BUG=http://crbug.com/29675

Review URL: http://codereview.chromium.org/460144

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/460154
------------------------------------------------------------------------
r34120 | viettrungluu@chromium.org | 2009-12-09 02:18:35 +0100 (Wed, 09 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Mac: add UMA calls for drag-and-drop of URLs on tab strip.

(Chrome/Win already has these, and we use the same names.)

BUG=29799
TEST=none

Review URL: http://codereview.chromium.org/465139
------------------------------------------------------------------------
r34117 | tony@chromium.org | 2009-12-09 02:06:26 +0100 (Wed, 09 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc

Have the utility process run out of process on Linux again by
using the /proc/self/exe trick we use for plugins.  Since we don't
need any resources from .pak files, this should be safe.

BUG=22703
TEST=Install a theme, verify that it worked properly.

Review URL: http://codereview.chromium.org/464073
------------------------------------------------------------------------
r34114 | asargent@chromium.org | 2009-12-09 01:48:58 +0100 (Wed, 09 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics.h
   M /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc

Revert 34099 - fix for memory leak and illegal access. (found in valgrind test)
 * name, values for callback seems to be on stack.
  i changed const char* to string so that it can copy, and
  also expect_eq can print string when failed.

BUG=None
TEST=Run unit_tests on valgrind.

Review URL: http://codereview.chromium.org/470006

TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/466083
------------------------------------------------------------------------
r34111 | mirandac@chromium.org | 2009-12-09 01:35:10 +0100 (Wed, 09 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Make "delete history for day" message have the correct font on Mac.
Committing for feldstein.

BUG= 21459
TEST= History tab on mac should show correct font in "delete day" message.

Review URL: http://codereview.chromium.org/460148
------------------------------------------------------------------------
r34110 | willchan@chromium.org | 2009-12-09 01:05:26 +0100 (Wed, 09 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix leak of ShutdownDetector.
For some reason I thought that non-joinable threads would always delete their delegates.  I was wrong.
BUG=http://crbug.com/29675

Review URL: http://codereview.chromium.org/460144
------------------------------------------------------------------------
r34109 | pkasting@chromium.org | 2009-12-09 00:52:36 +0100 (Wed, 09 Dec 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Revert this, it didn't compile on linux_views (argh)

------------------------------------------------------------------------
r34108 | pkasting@chromium.org | 2009-12-09 00:47:14 +0100 (Wed, 09 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Try re-enabling the resize corner on Windows to see if it still causes perf regressions.

BUG=458
TEST=The bottom right corner of the window whould have a resize corner.
Review URL: http://codereview.chromium.org/465133
------------------------------------------------------------------------
r34099 | oshima@chromium.org | 2009-12-08 23:49:40 +0100 (Tue, 08 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics.h
   M /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc
   A /trunk/src/chrome/test/data/valgrind/base_tests.gtest.txt

fix for memory leak and illegal access. (found in valgrind test)
 * name, values for callback seems to be on stack.
  i changed const char* to string so that it can copy, and
  also expect_eq can print string when failed.

BUG=None
TEST=Run unit_tests on valgrind.

Review URL: http://codereview.chromium.org/470006
------------------------------------------------------------------------
r34077 | derat@chromium.org | 2009-12-08 21:28:32 +0100 (Tue, 08 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.cc

gtk: Fix theme loading bubble position.

BUG=29539
TEST=tried it

Review URL: http://codereview.chromium.org/464058
------------------------------------------------------------------------
r34076 | johnnyg@chromium.org | 2009-12-08 20:49:56 +0100 (Tue, 08 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon.cc
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_win.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h

Notifications should resize themselves to the content within min-max bounds, rather than being all the same size.

CL hooks into RenderView callbacks to detect the size of the content, and contains some refactoring so that conceptually balloon size = content size + frame, rather than content size = balloon size - frame as it has been.

BUG=26691
TEST=included

Review URL: http://codereview.chromium.org/460131
------------------------------------------------------------------------
r34074 | stuartmorgan@chromium.org | 2009-12-08 20:41:08 +0100 (Tue, 08 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/framework.order
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/plugin_messages_internal.h
   A /trunk/src/chrome/plugin/plugin_interpose_util_mac.h
   A /trunk/src/chrome/plugin/plugin_interpose_util_mac.mm
   M /trunk/src/chrome/plugin/plugin_main_mac.mm
   M /trunk/src/chrome/plugin/plugin_thread.cc

Add Cocoa window interposing for plugin process

Adds support for noticing window show/hide done via Cocoa APIs. Also adds interposing on a couple more Carbon calls that I came across while debugging. Refactors to make things a bit less messy:
- Moves responsibility for re-activating the browser when the last plugin window closes into the browser, to simplify that logic.
- Moves utility method for activating the plugin process into the plugin, rather than the interpose library, so the Cocoa code can use it too.
- Add a data-holder and a couple of wrapper methods to reduce code duplication in the window show/hide handling.

BUG=28009, 29321
TEST=Plugin-opened windows (Gmail attachments, full-screen Flash, etc.) should work as expected again.

Review URL: http://codereview.chromium.org/465111
------------------------------------------------------------------------
r34072 | thestig@chromium.org | 2009-12-08 20:25:59 +0100 (Tue, 08 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc

Linux: Don't show all of the print dialog's children, including widgets normally not displayed.

BUG=26872
TEST=Default print dialog should not have the conflict warning.
Review URL: http://codereview.chromium.org/460138
------------------------------------------------------------------------
r34066 | eroman@chromium.org | 2009-12-08 19:35:14 +0100 (Tue, 08 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h

Refactor: Eliminte locking from PrefetchObserver and DnsMaster in favor of making these classes non-threadsafe.

Conceptually, PrefetchObserver and DnsMaster live on the IO thread, and their methods can only be called from the IO thread.

In the cases where calls do need to be made from the UI thread, we post a task to be run on the IO loop and return without blocking.

The only time where we block is during shutdown, when we must wait on the IO thread to get us the startup list and referral list.

BUG=25335


Review URL: http://codereview.chromium.org/300032
------------------------------------------------------------------------
r34065 | thomasvl@chromium.org | 2009-12-08 19:22:44 +0100 (Tue, 08 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/cross_origin_xhr_apitest.cc
   M /trunk/src/chrome/browser/extensions/stubs_apitest.cc
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] A chunk of browser_tests for extensions:
  - Bring up extension_apitest on mac
  - stub browser_action_apitest but get it compiling
  - stubs_apitest passes
  - compile cross_origin_xhr_apitest, but we don't pass it.
  - content_script_all_frames_apitest passes
  - execute_script_apitest passes

BUG=none
TEST=waterfall stays green

Review URL: http://codereview.chromium.org/465121
------------------------------------------------------------------------
r34059 | thomasvl@chromium.org | 2009-12-08 16:29:32 +0100 (Tue, 08 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Browser_tests work
- Drop the GYP variables that were only used in one place (the indirection seems more complicated then helpful)
- don't bother with a conditional for breakpad_mac_stubs (1/2 of the file didn't since the excludes handle it)
- Continue bring browser_tests stuff online:
  - extension_browsertest support for other tests
  - TaskManagerBrowserTest passes
  - SSLUITest passes
  - BlacklistManagerBrowserTest passes

BUG=none
TEST=tests show up on the waterfall/trybot and pass.
Review URL: http://codereview.chromium.org/467046
------------------------------------------------------------------------
r34037 | twiz@google.com | 2009-12-08 05:28:58 +0100 (Tue, 08 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html

Addition of a new parameter to the popup.show(...) Chrome extension API that allows the caller to specify the behaviour of the window focus when the pop-up is displayed.

I added a test for the new parameter in the ExtensionApiTest.FLAKY_Popup test.  I also corrected a truncated string in the unit-test.

Because the pop-up actually uses two windows, I had to change the WidgetWin::Show() routine to also reposition the window at the top.  If a window is shown and activated, it is automatically brought to the front.  Because we don't activate the pop-up when we want to keep the focus in the current extension view,  I had to bring it to the front so that it wouldn't be hidden behind the 'chrome-bubble' window.

BUG=none
TEST=ExtensionApiTest.FLAKY_Popup

Review URL: http://codereview.chromium.org/454019
------------------------------------------------------------------------
r34036 | willchan@chromium.org | 2009-12-08 05:22:50 +0100 (Tue, 08 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/base/logging.cc
   M /trunk/src/base/logging.h
   M /trunk/src/chrome/browser/browser_main.cc

Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe.
* Don't use LOG/CHECK.  Replace with RAW_LOG/DCHECK (newly added to logging.h)
* Don't directly post a task to the UI loop.  Write to a magic pipe.  Read this from a separate thread which will post to a task to the UI loop.
BUG=http://crbug.com/29240

Review URL: http://codereview.chromium.org/460094
------------------------------------------------------------------------
r34035 | suzhe@chromium.org | 2009-12-08 04:18:49 +0100 (Tue, 08 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Fix issue 23221: accesskey is not supported on Chromium Mac.

The key point is to provide correct unmodifiedText field for fabricated Char events, because in webkit, unmodifiedText is used for matching accesskey.

BUG=23221
TEST=See bug report.

Review URL: http://codereview.chromium.org/460105
------------------------------------------------------------------------
r34030 | maruel@chromium.org | 2009-12-08 03:04:22 +0100 (Tue, 08 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/printing/emf_win.h
   M /trunk/src/printing/image.cc
   M /trunk/src/printing/printed_document.h
   M /trunk/src/printing/printed_page.h
   M /trunk/src/printing/printing_context.h
   M /trunk/src/printing/printing_context_win.cc

printing: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS).

Use DISALLOW_COPY_AND_ASSIGN instead.

Patch contributed by Thiago Farina

Review URL: http://codereview.chromium.org/460087
------------------------------------------------------------------------
r34025 | rafaelw@chromium.org | 2009-12-08 01:47:23 +0100 (Tue, 08 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/result_codes.h
   M /trunk/src/chrome/renderer/render_view.cc

Revert "Allow silent extension installations from the extensions gallery - Part 1."

Original CL: http://codereview.chromium.org/400018/show

Looks like we're no longer hoping to get this approach into mstone4 release, so I'm unwinding this.

BUG=27431
TBR=aa

Review URL: http://codereview.chromium.org/467042
------------------------------------------------------------------------
r34024 | rsesek@chromium.org | 2009-12-08 01:38:32 +0100 (Tue, 08 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm

[Mac] Show group separators in the keyword editor

BUG=23570,21640
TEST=Chromium-->Preferences-->Manage. (1) See "Default" group. (2) Add an engine and it appears under an "Other" group header. (3) Make that new engine default and it moves under the "Default" group and the "Other" header disappears.

Review URL: http://codereview.chromium.org/466022
------------------------------------------------------------------------
r34014 | gwilson@chromium.org | 2009-12-08 00:33:14 +0100 (Tue, 08 Dec 2009) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/group_policy.cc
   D /trunk/src/chrome/browser/group_policy.h
   D /trunk/src/chrome/browser/group_policy_settings.cc
   D /trunk/src/chrome/browser/group_policy_settings.h
   D /trunk/src/chrome/browser/group_policy_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Revert 34008 - Adds basic group policy support.  Resubmitting r33093 with a new unit test.

TBR=cpu
TEST=unit test included
BUG=19374

Review URL: http://codereview.chromium.org/450037


Review URL: http://codereview.chromium.org/460128
------------------------------------------------------------------------
r34010 | tony@chromium.org | 2009-12-08 00:09:32 +0100 (Tue, 08 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Remove IsPrefRegistered function from PrefService API and fix the callers to
call FindPreference directly.

BUG=None
TEST=compiles and passes existing tests

Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/460117/show

Review URL: http://codereview.chromium.org/463044
------------------------------------------------------------------------
r34008 | gwilson@google.com | 2009-12-07 23:57:58 +0100 (Mon, 07 Dec 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/group_policy.cc
   A /trunk/src/chrome/browser/group_policy.h
   A /trunk/src/chrome/browser/group_policy_settings.cc
   A /trunk/src/chrome/browser/group_policy_settings.h
   A /trunk/src/chrome/browser/group_policy_unittest.cc
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Adds basic group policy support.  Resubmitting r33093 with a new unit test.

R=kuchhal
TEST=unit test included
BUG=19374

Review URL: http://codereview.chromium.org/450037
------------------------------------------------------------------------
r34005 | estade@chromium.org | 2009-12-07 23:34:31 +0100 (Mon, 07 Dec 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
   A /trunk/src/chrome/browser/extensions/extension_toolbar_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/chrome_browser.gypi

Extensions: create a simple model for the browser action buttons toolstrip and use it on Linux.

TODO: persist the order of buttons
TODO: use the model on windows, mac
TODO: let the view change the order of buttons

My plan for persisting the order is just to write/read a simple text file to/from disk, one extension id per line. Similar to the bookmark model, except that is structured data (because they try to hold more information).

BUG=26990

Review URL: http://codereview.chromium.org/462026
------------------------------------------------------------------------
r33996 | jhawkins@chromium.org | 2009-12-07 22:57:51 +0100 (Mon, 07 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Use gfx::Point instead of GET_X/Y_LPARAM to reduce the dependency on ATL. 

Patch from Thiago Farina <thiago.farina@gmail.com>
Original review: http://codereview.chromium.org/465004

BUG=5027
TEST=None 
Review URL: http://codereview.chromium.org/460121
------------------------------------------------------------------------
r33985 | sky@chromium.org | 2009-12-07 21:39:19 +0100 (Mon, 07 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc

Fixes bug where we wouldn't force a maximized window on Chrome OS
during login. This happens because on Chrome OS we start the WM and
Chrome at the same time, which means it's possiblef for us not to be
able to get the name of the window manager. I've changed the code to
assume that if we can't get the name of the window manager we're on
Chrome OS. This isn't perfect. Hopefully once the WM tells us we're
maximized before we're shown we can do away with this code.

BUG=ChromeOS bug 929
TEST=none

Review URL: http://codereview.chromium.org/463042
------------------------------------------------------------------------
r33980 | agl@chromium.org | 2009-12-07 21:05:08 +0100 (Mon, 07 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Linux: fix painting on the NTP and elsewhere.

BUG=29504
------------------------------------------------------------------------
r33973 | shess@chromium.org | 2009-12-07 20:03:33 +0100 (Mon, 07 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm

[Mac] Pump renderer messages in web content right-click context menu.

Allow nestable tasks while processing the menu so that video and the
like doesn't pause.

BUG=25055
TEST=Start a video somewhere.  Right-click in the content.  Video should keep running.

Review URL: http://codereview.chromium.org/366021
------------------------------------------------------------------------
r33971 | viettrungluu@chromium.org | 2009-12-07 19:54:33 +0100 (Mon, 07 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Mac: implement "Search the Web..." (Opt-Cmd-F).

This focuses the Omnibox with '?' in the contents with the text insertion point immediately after (and no selection), unless the Omnibox already has something beginning with '?' in which case it selects the text after the '?'. This is what
Ctrl-K does on other platforms. On the Mac, we get a menu item (under Edit -> Find), and the Mac-standard shortcut of Opt-Cmd-F (users can set Cmd-K as a short cut in System Preferences if they really want).

Changes to MainMenu.xib: added ^IDS_EDIT_SEARCH_WEB_MAC menu item ("Search the Web...", tag 39002, Opt-Cmd-F as keyboard shortcut, sending -commandDispatch: to first responder) as first item in Find submenu, followed by a separator.

BUG=29501
TEST=Check that this feature has the behaviour described above (using both the menu item and using Opt-Cmd-F), with (1) nothing in the Omnibox to begin with, (2) a random URL in the Omnibox, and (3) "?<some search term(s)>". Check that the Omnibox is properly focused (so set focus to various places, and make sure that the Omnibox gets focused).

Review URL: http://codereview.chromium.org/460111
------------------------------------------------------------------------
r33970 | skrul@chromium.org | 2009-12-07 19:53:57 +0100 (Mon, 07 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   A /trunk/src/chrome/common/notification_observer_mock.h
   M /trunk/src/chrome/common/notification_type.h

Add notification for autofill changes.

This is the first in a series of changes for adding notifications to autofill.  This change adds the notification plumbing to WebDataService::AddFormFieldValues that sends a simple notification.

The next change will add a Details<> payload to the notification with a list of changes that were performed, and then I will expand the notifications to the other autofill mutation methods.

Review URL: http://codereview.chromium.org/455027
------------------------------------------------------------------------
r33968 | zork@chromium.org | 2009-12-07 18:46:04 +0100 (Mon, 07 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Land http://codereview.chromium.org/467012 on behalf of tfarina.

Review URL: http://codereview.chromium.org/465079
------------------------------------------------------------------------
r33965 | thakis@chromium.org | 2009-12-07 17:56:42 +0100 (Mon, 07 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

More cleanups.

Rename tabModel_ to tabStripModel_. Belongs to codereview.chromium.org/465095.

TEST=BUG=none

Review URL: http://codereview.chromium.org/464061
------------------------------------------------------------------------
r33963 | rsesek@chromium.org | 2009-12-07 17:30:57 +0100 (Mon, 07 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/base/cocoa_protocols_mac.h
   A /trunk/src/chrome/app/nibs/FontLanguageSettings.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/browser/cocoa/font_language_settings_controller.h
   A /trunk/src/chrome/browser/cocoa/font_language_settings_controller.mm
   A /trunk/src/chrome/browser/cocoa/font_language_settings_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

[Mac] Implement font and encoding settings in Under the Hood preferences

* Font settings can now be changed for serif, sans serif, and fixed width.
* The default encoding can now be changed via preferences.
* Language settings are not yet implemented. See http://crbug.com/23828

BUG=20845
TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings

Review URL: http://codereview.chromium.org/461005
------------------------------------------------------------------------
r33957 | ukai@chromium.org | 2009-12-07 08:23:34 +0100 (Mon, 07 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/worker/worker_thread.cc

WebSocket in Worker: commandline passing for worker process.

Pass feature control command line flags to worker process, and enable WebKit features in worker.
Also, passing logging flags and prepend --render-cmd-prefix if specified.

BUG=27618
TEST=none

Review URL: http://codereview.chromium.org/445003
------------------------------------------------------------------------
r33955 | viettrungluu@chromium.org | 2009-12-07 07:18:53 +0100 (Mon, 07 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Mac: fix problem with un-minimizing windows using the app icon in the Dock.

More specifically, when detaching the status bubble window, don't just remove it as a child window but also remove it from the screen list.

BUG=29054
TEST=Minimize all browser windows and make sure clicking on the app's Dock icon restores (un-minimizes) the last-used browser window; repeat under a variety of circumstances; see bug for more details. Also make sure that the status bubble continues to work properly.

Review URL: http://codereview.chromium.org/460101
------------------------------------------------------------------------
r33953 | ukai@chromium.org | 2009-12-07 06:55:19 +0100 (Mon, 07 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.cc
   M /trunk/src/chrome/browser/renderer_host/socket_stream_host.h

WebSocket in Worker: renderer_host change

To support WebSocket in Worker, SocketStreamDispatcherHost should be part of ResourceDispatcherHost instead of ResourceMessageFilter.
ResourceMessageFilter is used only for renderer process, so it would not handle IPC message from worker process.

SocketStreamHost changed to have ResourceDispatcherHost::Receiver, which is a peer of child process, and indexed by receiver id and socket_id.

BUG=27618
TEST=none

Review URL: http://codereview.chromium.org/437084
------------------------------------------------------------------------
r33952 | rafaelw@chromium.org | 2009-12-07 05:52:55 +0100 (Mon, 07 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/result_codes.h
   M /trunk/src/chrome/renderer/render_view.cc

Allow silent extension installations from the extensions gallery - Part 1.

In this episode we:
-Create a new ChildProcess privilege (SILENT_INSTALL_EXTENSION) which is granted to the extension gallery pages.
-Ensure that extension gallery pages are isolated into their own process which is never shared with other urls.

Important: The SILENT_INSTALL_EXTENSION privilege is never granted any additional abilities in this patch, so this patch only has the effect of grouping gallery URLs into a separate process.

In subsequent patch(es) we plan to (a) observe this new privilege and allow gallery urls to install extensions bypassing the normal prompts, (b) polish this UI flow [in particular, do not show the black "loading" dilaog, (c) check the id of the extension to be installed (from the crx) matches the expected id (from gallery url).

BUG=27431

Review URL: http://codereview.chromium.org/400018
------------------------------------------------------------------------
r33948 | thakis@chromium.org | 2009-12-07 05:03:53 +0100 (Mon, 07 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/task_manager.h

Some code cleanups.

Rename tabView_ to tabStripView_. Fix indentation.

TEST=BUG=none

Review URL: http://codereview.chromium.org/465095
------------------------------------------------------------------------
r33945 | aa@chromium.org | 2009-12-06 22:41:03 +0100 (Sun, 06 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Fix a crash bug on user script installation and add a test
to make sure it doesn't happen again.

Also, re-enable a test nearby. The history has been lost of
why this was failing, so it may fail again, but at least
we'll have data.

Finally, fix a Greasemonkey compat issue.

BUG=29298

Review URL: http://codereview.chromium.org/466053
------------------------------------------------------------------------
r33933 | jar@chromium.org | 2009-12-06 01:09:37 +0100 (Sun, 06 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/histogram_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/net/base/connection_type_histograms.cc
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/disk_cache/histogram_macros.h
   M /trunk/src/net/disk_cache/stats.cc
   M /trunk/src/net/disk_cache/stats.h
   M /trunk/src/net/disk_cache/stats_histogram.cc
   M /trunk/src/net/disk_cache/stats_histogram.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_server_type_histograms.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket_stream/socket_stream_metrics.cc

Use factory to create histograms, and refcounts to track lifetimes

This is CL patch 377028 by Raman Tenneti, with minor changes to
make the try-bots happier.

It is cleanup that better ensures lifetimes of histograms (making it harder
for users to abuse them).  

bug=16495 (repairs leak induced by the first landing)
bug=18840 (should make leaks less possible)
tbr=raman.tenneti
Review URL: http://codereview.chromium.org/462027
------------------------------------------------------------------------
r33924 | viettrungluu@chromium.org | 2009-12-05 09:18:27 +0100 (Sat, 05 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Mac: Make a stop-gap visual indicator for dropping URLs on the tab strip.

A.k.a. a present for pkasting. Eventually we'll probably want to do something more sophisticated (at the very least arrows should fade in/out), but for now this doesn't look (much?) worse than what's on Win/Chrome.

BUG=25405
TEST=Drag URLs to the tab strip, move around, make sure the ugly arrow appears in the right locations, dropping to confirm. Repeat with various themes to make sure arrow is reasonably visible.

Review URL: http://codereview.chromium.org/466051
------------------------------------------------------------------------
r33914 | abarth@chromium.org | 2009-12-05 03:30:54 +0100 (Sat, 05 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc

Fix null-pointer crash.

BUG=29444

Review URL: http://codereview.chromium.org/469001
------------------------------------------------------------------------
r33902 | joi@chromium.org | 2009-12-05 02:36:33 +0100 (Sat, 05 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h

Get rid of ExternalTabAutomationProxy by switching the extension UI
tests over to ExternalTabUITest.

BUG=27326
TEST=ui_tests.exe

Review URL: http://codereview.chromium.org/468013
------------------------------------------------------------------------
r33899 | johnnyg@chromium.org | 2009-12-05 01:51:58 +0100 (Sat, 05 Dec 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/app/theme/balloon_close.png
   A /trunk/src/chrome/app/theme/balloon_close_hover.png
   M /trunk/src/chrome/app/theme/balloon_frame.png
   A /trunk/src/chrome/app/theme/balloon_options_arrow.png
   A /trunk/src/chrome/app/theme/balloon_options_arrow_hover.png
   M /trunk/src/chrome/app/theme/balloon_shelf.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/resources/notification.html
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h

Spruce up the notification UI to much more closely match the mocks, including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons.

Part of the CL includes new features for TextButton class to control icon placement and appearance on hover.

BUG=none
TEST=notifications

Review URL: http://codereview.chromium.org/450045
------------------------------------------------------------------------
r33890 | viettrungluu@chromium.org | 2009-12-05 00:55:52 +0100 (Sat, 05 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   A /trunk/src/chrome/browser/cocoa/url_drop_target.h
   A /trunk/src/chrome/browser/cocoa/url_drop_target.mm
   M /trunk/src/chrome/chrome_browser.gypi

Mac: implement drag-and-drop of URLs to tabs/tab strip.

Not yet implemented: visual feedback, dropping multiple URLs/files, perhaps key modifiers (?).

Doing the visual feedback right (making the tabs move around, etc.) will require a fairly hefty work on the tabs code, so I'm splitting up the work.

BUG=25405
TEST=Test dragging and dropping URLs/links, files, plain text (with a possibly-poorly-formed URL), etc. on the tab and on the empty part of the tab strip; web page should load in tab or in new tab, and that tab should be selected.

Review URL: http://codereview.chromium.org/337055
------------------------------------------------------------------------
r33889 | thestig@chromium.org | 2009-12-05 00:52:28 +0100 (Sat, 05 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

views/options: Use non-deprecated version of PathService::Get.

Patch from Thiago Farina <thiago.farina@gmail.com>
Original review: http://codereview.chromium.org/462038

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/465068
------------------------------------------------------------------------
r33888 | thestig@chromium.org | 2009-12-05 00:51:33 +0100 (Sat, 05 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/DEPS
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc

Linux: Record the list of plugins loaded in browser process crash reports.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/459015
------------------------------------------------------------------------
r33886 | pkasting@chromium.org | 2009-12-05 00:49:51 +0100 (Sat, 05 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/host_zoom_map.cc
   A /trunk/src/chrome/browser/host_zoom_map.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/page_zoom.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc

Remember zoom on a per-host basis.

BUG=567
TEST=Visit a page, zoom in or out, then navigate to a different host.  The new page should not be zoomed.  Go back, or restart, or open a new tab and navigate to the old page, and it should be zoomed.
Review URL: http://codereview.chromium.org/437077
------------------------------------------------------------------------
r33885 | zork@chromium.org | 2009-12-05 00:46:54 +0100 (Sat, 05 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc

Fix html_dialog_gtk.cc so that the dialog is large enough to display the entire html control.

BUG=none
TEST=Enable sync and attempt to log in.  The cancel button should be completely visible.

Review URL: http://codereview.chromium.org/464029
------------------------------------------------------------------------
r33875 | pkasting@chromium.org | 2009-12-04 23:51:02 +0100 (Fri, 04 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Make the system menu for app/popup windows slightly shorter.  Original patch by Thiago Farina (see http://codereview.chromium.org/402095 ), r=me.

BUG=23787
TEST=Popup window system menus (right click the icon in the upper left corner) should not have Save Page, Duplicate Tab, and a few other things anymore.
------------------------------------------------------------------------
r33870 | estade@chromium.org | 2009-12-04 23:33:59 +0100 (Fri, 04 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h

Windows: theme the close button for the find bar.

The blocked popup container isn't themed, but it will need similar treatment.

BUG=29101 (sort of)
TEST=use a dark theme, the close button should be visible on the findbar
Review URL: http://codereview.chromium.org/465049
------------------------------------------------------------------------
r33869 | jar@chromium.org | 2009-12-04 23:25:58 +0100 (Fri, 04 Dec 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Delay DNS subresource resolution until navigational resolution is complete

This should probably help some folks that have very sensitive DNS
resolution systems, by at least assuring that the initial navigation
can't get stuck behind congestion induced by DNS prefetching.

There is a tiny chance that this used to be a bit less problematic, as
the DNS prefetch system used to use its own threads, which gave
the navigational resolution a "racing" chance to be handled first (or
at least sooner).  With the centralized use of the resolver, the code
(as noted by eroman) actually started the sub-resource resolution
(in all cases) before the navigational resolution.  This change
explicitly forces the clearly better ordering.

It won't "fix" bug 3041... but it may help some users with more
recent comments in that bug.

bug=3041
r=eroman
Review URL: http://codereview.chromium.org/464023
------------------------------------------------------------------------
r33862 | thestig@chromium.org | 2009-12-04 22:41:27 +0100 (Fri, 04 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Linux: Show the private memory usage by default instead of the shared memory usage. (which shows 0 for me)

BUG=none
TEST=Task manager shows the interesting stats by default.
Review URL: http://codereview.chromium.org/468017
------------------------------------------------------------------------
r33861 | darin@chromium.org | 2009-12-04 22:41:00 +0100 (Fri, 04 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/paint_aggregator.cc
   M /trunk/src/chrome/renderer/paint_aggregator.h
   M /trunk/src/chrome/renderer/paint_aggregator_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/skia/ext/bitmap_platform_device_linux.cc
   M /trunk/src/skia/ext/bitmap_platform_device_linux.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/bitmap_platform_device_win.cc

Preserve optimized scrolling in the presence of multiple animating rects.

Change PlatformCanvas so that it only fills with "sea foam green" when bitmap data is not externally supplied.  Modifying the interface to make this an option bloated the CL too much.  I may do this as a follow-up.

Adds a new --show-paint-rects command line flag that will render a border around paint rects to help debug and study WebKit painting issues.

R=brettw
BUG=25905
TEST=none

Review URL: http://codereview.chromium.org/414016
------------------------------------------------------------------------
r33860 | stuartmorgan@chromium.org | 2009-12-04 22:28:54 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc

Add IsWindowActive to the Mac plugin interpose list

BUG=28021
TEST=Mouseover should work in Silverlight

Review URL: http://codereview.chromium.org/460057
------------------------------------------------------------------------
r33858 | tony@chromium.org | 2009-12-04 22:10:28 +0100 (Fri, 04 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc

Use the zygote for extension page popup processes.

BUG=29377

Review URL: http://codereview.chromium.org/464041
------------------------------------------------------------------------
r33857 | mirandac@chromium.org | 2009-12-04 22:02:11 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Add locale information to the links in the chrome://extensions page.

BUG= 28624
TEST= links from the chrome://extensions page should include locale information.

Review URL: http://codereview.chromium.org/467019
------------------------------------------------------------------------
r33856 | mirandac@chromium.org | 2009-12-04 22:01:00 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/incognito_tab.html

Move incognito text box down.

Top line of incognito text box is now at the same point as the top line of the thumbnails in the regular NTP.
This means that themed NTP backgrounds look the way the theme designers planned them to (for example, you can see the "Chrome comet" in Star Gazing, and the pattern swirl in OP), and the regular and incognito NTPs have a unified look.

Review URL: http://codereview.chromium.org/463030
------------------------------------------------------------------------
r33854 | avi@chromium.org | 2009-12-04 21:53:38 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm

Don't bounce the downloads folder if the download was auto-removed (e.g. themes)

BUG=http://crbug.com/28717
TEST=as in bug

Review URL: http://codereview.chromium.org/465064
------------------------------------------------------------------------
r33853 | shess@chromium.org | 2009-12-04 21:50:47 +0100 (Fri, 04 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

[Mac] Route edit-state messages via observer rather than delegate.

AutocompleteTextField routes messages to AutocompleteEditViewMac via a
Cocoa-style delegate and also a C++ observer class.  The Cocoa-style
delegate has been gradually being pruned down in favor of the
observer, this CL completes the transformation.

The noted bugs occur because some bit of Cocoa code was sending
spurious delegate notifications.  Since this code no longer depends on
those notifications, the spurious notifications are no longer a
problem for this case.

BUG=19116, 17803
TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox).  Bring up the Print panel and cancel.  Bring up a new tab and close it.  gmail's accelerator keys should still work right (not send focus to omnibox).

Review URL: http://codereview.chromium.org/391025
------------------------------------------------------------------------
r33851 | mattm@chromium.org | 2009-12-04 21:45:54 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/base/message_pump_glib.cc
   M /trunk/src/base/message_pump_glib.h
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/ui_test_utils_linux.cc

Avoid including gtk & glib headers in message_pump_glib.h, saves 1 sec on do-nothing make.

TEST=manual browser test, trybots
BUG=none

Review URL: http://codereview.chromium.org/464031
------------------------------------------------------------------------
r33850 | thomasvl@chromium.org | 2009-12-04 21:45:11 +0100 (Fri, 04 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

enabled one browser test and tag JavascriptAlertActivatesTab, ReloadThenCancelBeforeUnload, & SingleBeforeUnloadAfterWindowClose as disabled so they compile but don't run on the Mac

TEST=tree stays green
BUG=29424
Review URL: http://codereview.chromium.org/464039
------------------------------------------------------------------------
r33848 | avi@chromium.org | 2009-12-04 21:40:16 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc

Reverts r4177, reimplements a fix for bug 3417. Adding UpdateObservers to DownloadItem::Finished is wrong, as it causes a duplicate notification to fire when a download is complete.

BUG=http://crbug.com/3417
TEST=bug does not regress

Review URL: http://codereview.chromium.org/464043
------------------------------------------------------------------------
r33832 | apatrick@google.com | 2009-12-04 19:08:45 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/common/ipc_test_sink.cc
   M /trunk/src/chrome/common/ipc_test_sink.h
   M /trunk/src/chrome_frame/sync_msg_reply_dispatcher.h
   M /trunk/src/ipc/ipc_channel_posix.cc
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/ipc/ipc_logging.h
   M /trunk/src/ipc/ipc_message.cc
   M /trunk/src/ipc/ipc_message.h
   M /trunk/src/ipc/ipc_message_macros.h
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/ipc/ipc_sync_message.cc
   M /trunk/src/ipc/ipc_sync_message.h

Added new IPC message class for CommandBuffer.
Increased IPC message header type from 16 bits to 32 bits so it can accomodate more message classes.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/399013
------------------------------------------------------------------------
r33830 | thomasvl@chromium.org | 2009-12-04 19:03:02 +0100 (Fri, 04 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc

Enable browser_tests: SavePageBrowserTest.FileNameFromPageTitle & SavePageBrowserTest.SaveHTMLOnly on the Mac.

BUG=16322
TEST=waterfall stays green
Review URL: http://codereview.chromium.org/463031
------------------------------------------------------------------------
r33829 | pinkerton@chromium.org | 2009-12-04 18:57:49 +0100 (Fri, 04 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status_area_view.h

Fix bustage.
BUG=none
TEST=none
------------------------------------------------------------------------
r33827 | pinkerton@chromium.org | 2009-12-04 18:50:26 +0100 (Fri, 04 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/menus
   A /trunk/src/app/menus/accelerator.h
   A /trunk/src/app/menus/menu_model.cc
   A /trunk/src/app/menus/menu_model.h
   A /trunk/src/app/menus/simple_menu_model.cc (from /trunk/src/views/controls/menu/simple_menu_model.cc:33442)
   A /trunk/src/app/menus/simple_menu_model.h (from /trunk/src/views/controls/menu/simple_menu_model.h:33442)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/back_forward_menu_model_views.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_views.h
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/button_dropdown.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_delegate.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   D /trunk/src/views/controls/menu/simple_menu_model.cc
   D /trunk/src/views/controls/menu/simple_menu_model.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Refactor the menu model to live outside views/ so it can be shared
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/465005
------------------------------------------------------------------------
r33825 | timurrrr@chromium.org | 2009-12-04 18:37:01 +0100 (Fri, 04 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h

Fix a couple of data races on booleans
BUG=21468,22520
For the explanation why these are data races,
see http://code.google.com/p/data-race-test/wiki/PopularDataRaces
Review URL: http://codereview.chromium.org/251027
------------------------------------------------------------------------
r33822 | erikkay@chromium.org | 2009-12-04 17:57:56 +0100 (Fri, 04 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc

Move ExtensionApiTest.Bookmarks from DISABLED to FLAKY since it doesn't
crash.

BUG=19866
TEST=ExtensionApiTest.Bookmarks

Review URL: http://codereview.chromium.org/465034
------------------------------------------------------------------------
r33821 | viettrungluu@chromium.org | 2009-12-04 17:33:56 +0100 (Fri, 04 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Mac: restore window size/position when hiding bookmark bar or download shelf.

This applies in particular when the bookmark bar or download shelf causes the
window to grow at the top (due to there not being enough space at the bottom of
the screen). Note that resizing or moving reset the state (* for moving it's a
bit more subtle), so hiding afterwards will always shrink the window from the
bottom.

BUG=29192
TEST=(1) Navigate to a normal (non-NTP) page and hide bookmark bar; move window close to the bottom of the screen (keeping the window fully on-screen); Shift-Cmd-B to show the bookmark bar (which show grow maybe a bit downwards and then upwards); Shift-Cmd-B to hide it again; it should shrink from the top and from the bottom, restoring its original size/position. (2) Do the same but move the window away from the bottom of the screen after the first Shift-Cmd-B; now upon hiding it should only shrink at the bottom. (3) Check that if the window is far enough away from the bottom of the screen to begin with, then growing/shrinking only occurs at the bottom. (4) Do (1)-(3) for the download shelf (download something to show the shelf; then hide it by closing it).

Review URL: http://codereview.chromium.org/465024
------------------------------------------------------------------------
r33805 | zelidrag@google.com | 2009-12-04 08:59:00 +0100 (Fri, 04 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Downward drag after mouse-down is now causing bookmark bar folders to open, rather than drag. The bar folder can still be dragged in any other direction.

Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. 

BUG=9016
TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu.
TBR=sky

Review URL: http://codereview.chromium.org/467017
------------------------------------------------------------------------
r33802 | huanr@chromium.org | 2009-12-04 08:04:07 +0100 (Fri, 04 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/common/notification_registrar.cc
   M /trunk/src/chrome/common/notification_registrar.h

Adding instrument to NotificationRegistrar to check
Add() and Remove() are called from same thread.

Note I already checked in a fix for the bug. The CL
is trying to check whether the issue exists in other
code path.

TEST=none
BUG=27834

Review URL: http://codereview.chromium.org/449044
------------------------------------------------------------------------
r33800 | yusukes@google.com | 2009-12-04 07:34:46 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/webkit/glue/webpreferences.h

Enable remote fonts by default. This change introduces --disable-remote-fonts flag and obsoletes --enable-remote-fonts.

BUG=17818
TEST=(1) Start chromium WITHOUT --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _remote_ fonts (reference image: http://www.alistapart.com/d/cssatten/poen.png ) / (2) Start chromium WITH --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _local_ fonts 

Review URL: http://codereview.chromium.org/165236
------------------------------------------------------------------------
r33798 | finnur@chromium.org | 2009-12-04 07:03:27 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_am.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix download dialog truncation in German locale.

BUG=23178
TEST=Requires manual inspection for text trunction on --lang=de (when closing Chrome while downloading)

Review URL: http://codereview.chromium.org/465041
------------------------------------------------------------------------
r33794 | asargent@chromium.org | 2009-12-04 06:33:45 +0100 (Fri, 04 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Improve reporting of subprocess crashes.

-Split extension renderer crashes out of the existing UMA renderer crash metric 
into its own metric.

-Add a new metric for the sum of all ChildProcessHost crashes.

-Add histograms for each crash type.


BUG=28022
TEST=We should start getting more crash reports in UMA and histograms.

Review URL: http://codereview.chromium.org/468005
------------------------------------------------------------------------
r33793 | mhm@chromium.org | 2009-12-04 06:32:25 +0100 (Fri, 04 Dec 2009) | 13 lines
Changed paths:
   A /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   A /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h

Implement keyboard access between bookmarks and main toolbar.

Allow ALT+SHIFT+T and TAB to traverse between bookmarks bar and main toolbar, same thing goes for SHIFT+TAB. Once any toolbar is focused, the arrow keys are used to traverse its children views.

Any toolbar that needs to be traversable needs to extend "AccessibleToolbarView", that class will deal with all the toolbar accessibility needs such as handling ESC, Left/Right arrows, Enter, Drop downs, and traversals with Tab/Shift+Tab.

There is one abstract method that the views who are extending this would need to implement if needed which allows the toolbar to skip views that are being traversed:
 bool IsAccessibleViewTraversable(views::View* view)

BUG=25625
TEST=Test to see if the main toolbar and bookmarks bar is traversable.

Review URL: http://codereview.chromium.org/333010
------------------------------------------------------------------------
r33791 | tim@chromium.org | 2009-12-04 05:16:22 +0100 (Fri, 04 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_quota_service.h
   M /trunk/src/chrome/browser/extensions/extensions_quota_service_unittest.cc

Fix leak reported in extensions_quota_service_unittest.cc

TBR=nick

Review URL: http://codereview.chromium.org/468018
------------------------------------------------------------------------
r33780 | nick@chromium.org | 2009-12-04 03:43:42 +0100 (Fri, 04 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Use GetStringUTF16 to return string16 instead of std::wstring in bookmark manager.

Patch by Thiago Farina <thiago.farina@gmail.com>.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/460056
------------------------------------------------------------------------
r33777 | estade@chromium.org | 2009-12-04 03:18:50 +0100 (Fri, 04 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h

Fix chromium os build.

Review URL: http://codereview.chromium.org/468016
------------------------------------------------------------------------
r33775 | estade@chromium.org | 2009-12-04 03:07:02 +0100 (Fri, 04 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc

Make the default RendererPreferences smarter.

Change the default RenderViewHostDelegate::GetRendererPrefs to a singleton because initialization may not always be cheap (we assume copying is, however).

BUG=29043
TEST=if you focus a link in an extension popup, you can actually see the focus ring (the focus ring had been set to 0x000000 color)

Review URL: http://codereview.chromium.org/458013
------------------------------------------------------------------------
r33771 | viettrungluu@chromium.org | 2009-12-04 02:51:32 +0100 (Fri, 04 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Mac: remove hacky way the New Tab button is obtained from the nib.

I added a member variable and an accessor/mutator ... and hooked up that up in
the nib. Changes to BrowserWindow.xib: hook up the New Tab button to
|newTabButton| in TabBar.

Unit test fixed. Previously committed at r33758, reverted at r33761.

BUG=none
TEST=Make sure it builds, runs, and that the New Tab button still works.

Review URL: http://codereview.chromium.org/460058
------------------------------------------------------------------------
r33770 | tim@chromium.org | 2009-12-04 02:43:02 +0100 (Fri, 04 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   A /trunk/src/chrome/browser/extensions/extensions_quota_service.cc
   A /trunk/src/chrome/browser/extensions/extensions_quota_service.h
   A /trunk/src/chrome/browser/extensions/extensions_quota_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/test.html
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js

Add ExtensionsQuotaService to limit abusive amounts of requests
to mutating extension functions, as discussed on chromium-dev and
in Extensions quotaserver design doc.

Add a hook in the dispatcher to have the quota service assess the request.

Wire up bookmarks.{create, move, remove, update} to the service.

BUG=19899
TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new)

Review URL: http://codereview.chromium.org/441006
------------------------------------------------------------------------
r33761 | viettrungluu@chromium.org | 2009-12-04 01:57:21 +0100 (Fri, 04 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Revert 33758 - Mac: remove hacky way the New Tab button is obtained from the nib.

I added a member variable and an accessor/mutator ... and hooked up that up in
the nib. Changes to BrowserWindow.xib: hook up the New Tab button to
|newTabButton| in TabBar.

BUG=none
TEST=Make sure it builds, runs, and that the New Tab button still works.

Review URL: http://codereview.chromium.org/465042

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/465045
------------------------------------------------------------------------
r33758 | viettrungluu@chromium.org | 2009-12-04 01:44:46 +0100 (Fri, 04 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Mac: remove hacky way the New Tab button is obtained from the nib.

I added a member variable and an accessor/mutator ... and hooked up that up in
the nib. Changes to BrowserWindow.xib: hook up the New Tab button to
|newTabButton| in TabBar.

BUG=none
TEST=Make sure it builds, runs, and that the New Tab button still works.

Review URL: http://codereview.chromium.org/465042
------------------------------------------------------------------------
r33755 | akalin@chromium.org | 2009-12-04 01:22:04 +0100 (Fri, 04 Dec 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/notifier/base/mac/time_mac.cc
   M /trunk/src/chrome/chrome.gyp

Removed sync/notifier/base/mac/time_mac.cc (which just includes time_posix.cc).

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/462014
------------------------------------------------------------------------
r33752 | akalin@chromium.org | 2009-12-04 00:54:45 +0100 (Fri, 04 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   A /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
   A /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
   A /trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/html_dialog_gtk.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Created HtmlDialogTabContentsDelegate, which encapsulates the TabContentsDelegate behavior for HTML dialogs.  Made all three implementations (gtk, win32, and cocoa) use it.

This also makes HTML dialogs not tied to a Browser instance.  Also, unlike the current behavior, any links followed from an HTML dialog box will be opened in a non-incognito browser, even if the HTML dialog was launched from an incognito browser.  According to beng, this is okay.

BUG=28609
TEST=unittests, manual testing on linux/windows/os x with sync setup wizard

Review URL: http://codereview.chromium.org/441011
------------------------------------------------------------------------
r33748 | tony@chromium.org | 2009-12-04 00:32:57 +0100 (Fri, 04 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome_frame/utils.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc

Fixes to the string MatchPattern functions:

1) Make it explicit that it only supports ASCII (since it iterates
character by character).
2) Limit the recursion to 16 levels.  We could allow more, but in the
case of a ?, it has exponential complexity, so I figured 16 was a good
stopping point.  It seems rare that someone would have more than 16
'?' and '*'s.

BUG=28645

Review URL: http://codereview.chromium.org/460047
------------------------------------------------------------------------
r33746 | snej@chromium.org | 2009-12-04 00:06:51 +0100 (Fri, 04 Dec 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h

Implement "Email Link To Page" menu command.
This menu item only exists in the Mac build, but the code is cross-platform so it could be hooked up on other platforms as well, if desired.
It works by generating a URL of the form
  mailto:?subject=Fwd:%20PAGETITLE&body=%0A%0APAGEURL
and telling platform_utils to open it.

This is my first patch involving command handling; I've tried to follow the way similar menu commands
like Print are implemented, but feel free to tell me if there are better ways.

I didn't find any place for unit tests for TabContents; if this needs tests, let me know where they should go.

BUG=29232
TEST=none

Review URL: http://codereview.chromium.org/466019
------------------------------------------------------------------------
r33731 | asargent@chromium.org | 2009-12-03 23:06:53 +0100 (Thu, 03 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc

Send Keystone ID to Omaha for Extensions Gallery update checks.

This is the OSX complement to http://src.chromium.org/viewvc/chrome?view=rev&revision=32853

BUG=b/2168147
TEST=extension autoupdate should still work on MacOS

Review URL: http://codereview.chromium.org/431033
------------------------------------------------------------------------
r33728 | thakis@chromium.org | 2009-12-03 22:45:06 +0100 (Thu, 03 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc

Remove the deprecated version of FixupURL and fix the callers.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/455022
Patch from tfarina.
------------------------------------------------------------------------
r33726 | pkasting@chromium.org | 2009-12-03 22:40:26 +0100 (Thu, 03 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Fix data races in Safe Browsing Service that were possible with aggressive compiler optimizations.

BUG=28559
TEST=none
Review URL: http://codereview.chromium.org/455039
------------------------------------------------------------------------
r33720 | pam@chromium.org | 2009-12-03 22:08:03 +0100 (Thu, 03 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Don't ping for extension blacklist when no extensions are installed.

BUG=24168
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/466012
------------------------------------------------------------------------
r33719 | dank@chromium.org | 2009-12-03 22:07:47 +0100 (Thu, 03 Dec 2009) | 24 lines
Changed paths:
   M /trunk/src/base/allocator/generic_allocators.cc
   M /trunk/src/build/all.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Make no-tcmalloc (really, non-base/allocator) builds work again,
(i.e. this is a plain vanilla build used when layers like base/allocator
are getting in the way of debugging)
and make sure they use msvcrt rather than libcmt
(libcmt is used to help shim malloc/free, but it gets
in the way of valgrind doing the same thing).

Sadly, this is now a gyp-time operation rather than a Configuration
option.

Had to remove hardcoded C prototype for _set_new_mode, 
as that caused link errors.

Also add variables win_{release,debug}_{Optimization,RuntimeLibrary}
to let the valgrind build override those settings.

Fix calling convention on _set_new_mode to match the
one in <new.h>

BUG=none
TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll


Review URL: http://codereview.chromium.org/455037
------------------------------------------------------------------------
r33717 | tony@chromium.org | 2009-12-03 22:05:16 +0100 (Thu, 03 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Reduce the logging output when running startup tests on linux/mac.

Review URL: http://codereview.chromium.org/464021
------------------------------------------------------------------------
r33713 | thomasvl@chromium.org | 2009-12-03 21:44:10 +0100 (Thu, 03 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc

Mark the tests as disabled on mac with a bug to revisit, this should allow browser_tests to run on the mac.

BUG=29331
TEST=none
Review URL: http://codereview.chromium.org/466021
------------------------------------------------------------------------
r33712 | mirandac@chromium.org | 2009-12-03 21:28:36 +0100 (Thu, 03 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc

Change WideToASCII to WideToUTF8 to ensure that CJK tips are properly displayed.

BUG= none
TEST= CJK tips should display properly.

Review URL: http://codereview.chromium.org/467003
------------------------------------------------------------------------
r33702 | robertshield@chromium.org | 2009-12-03 20:16:47 +0100 (Thu, 03 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc

Adding product names to safe browsing report_error and report_phish URLs on Windows. These names will be different for Google Chrome, Chromium and Chrome Frame. On Mac / Linux, leaving the name as "googlechrome" for all builds.

BUG=None
TEST=Verify that the safe browsing URLs are tagged with the correct product name for each product.


Review URL: http://codereview.chromium.org/455035
------------------------------------------------------------------------
r33695 | pkasting@chromium.org | 2009-12-03 19:17:12 +0100 (Thu, 03 Dec 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Misc. cleanup of safe_browsing_util.cc:
* Shorten code where easy to do so
* Remove an unneeded line
* Better function parameter names for one function
* Be consistent about not using {} on one-line bodies (some places did, some didn't)
* Be consistent about using "a" and "!a" instead of "a != 0" and "a == 0" (some places did one, some did the other)
* No else after return/continue
* Reduce duplicated code by reordering lines
* Use for () instead of while () where doing so would shorten things
* More comments in a few places
* Use iterators in a few cases where doing so avoids more verbose or complex code
* Name a few constants

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/452043
------------------------------------------------------------------------
r33694 | mirandac@chromium.org | 2009-12-03 19:13:31 +0100 (Thu, 03 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bug_report_view.cc

Change BugReportView to use the bug report types from the cross-platform BugReportUtil class.

BUG= 27281
TEST= "report bug" dialog in windows should not change at all.

Review URL: http://codereview.chromium.org/464017
------------------------------------------------------------------------
r33687 | viettrungluu@chromium.org | 2009-12-03 17:11:00 +0100 (Thu, 03 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/menu_button.mm
   M /trunk/src/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm
   M /trunk/src/chrome/browser/cocoa/nswindow_local_state.h
   M /trunk/src/chrome/browser/cocoa/nswindow_local_state.mm
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.h

Cleanup: FIXME -> TODO, viettrungluu@gmail.com -> viettrungluu, remove whitespace at EOL.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/467002
------------------------------------------------------------------------
r33685 | mirandac@chromium.org | 2009-12-03 17:02:40 +0100 (Thu, 03 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Notify user that Chrome is already synced if promo banner "sync me" link is clicked.

BUG= 28795
TEST= sync bookmarks, then click "sync" link in promo again.  see notification that you are already synced.

Review URL: http://codereview.chromium.org/462011
------------------------------------------------------------------------
r33684 | kuan@chromium.org | 2009-12-03 17:00:46 +0100 (Thu, 03 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

linux: use TabContents to launch url for link in crash page
- used to use BrowserList::GetLastActive but that's null in chrome-frame release.
- TabContents is passed into constructor and only if it's non-null is the link created.

BUG=29034
TEST=verify that crash per bug report doesn't happen.
Review URL: http://codereview.chromium.org/466016
------------------------------------------------------------------------
r33682 | jeremy@chromium.org | 2009-12-03 16:36:08 +0100 (Thu, 03 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility.sb
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/chrome_tests.gypi
   M /trunk/src/chrome/common/sandbox_mac.mm
   A /trunk/src/chrome/common/sandbox_mac_unittest.mm

Add regex escaping code to Mac sandbox implementation and re-enable the utility process on OS X.

Other changes:
* An error initializing the sandbox on OS X is now treated as fatal.
* Improved error reporting for sandbox-related failures.

BUG=26492,23837
TEST=Installing extensions and themes should still work on OS X.

Review URL: http://codereview.chromium.org/434077
------------------------------------------------------------------------
r33671 | joel@chromium.org | 2009-12-03 08:02:54 +0100 (Thu, 03 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.cc

linux: build fix for gcc-4.4

This fixes the following errors seen with gcc-4.4 on Ubuntu Karmic:

  CXX(target) out/Release/obj.target/browser/chrome/browser/gtk/download_in_progress_dialog_gtk.o
  cc1plus: warnings being treated as errors
  chrome/browser/gtk/download_in_progress_dialog_gtk.cc: In constructor ‘DownloadInProgressDialogGtk::DownloadInProgressDialogGtk(Browser*)’:
  chrome/browser/gtk/download_in_progress_dialog_gtk.cc:59: error: format not a string literal and no format arguments
  chrome/browser/gtk/download_in_progress_dialog_gtk.cc:68: error: format not a string literal and no format arguments

Review URL: http://codereview.chromium.org/466017
------------------------------------------------------------------------
r33663 | cpu@chromium.org | 2009-12-03 04:56:22 +0100 (Thu, 03 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_main.h
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   M /trunk/src/chrome/browser/diagnostics/diagnostics_test.h

Basic console output for diagnostics mode windows-only

Also Wires --diagnostics to the diagnostics entry point
start chrome with --diagnostics and watch pretty output

BUG=27885
TEST= unit tests included

Review URL: http://codereview.chromium.org/454020
------------------------------------------------------------------------
r33649 | viettrungluu@chromium.org | 2009-12-03 02:44:00 +0100 (Thu, 03 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

Mac unit test: fix StatusBubbleMacTest.UpdateSizeAndPosition flakiness.

The success/failure of this test depends on the location of the mouse. Other
StatusBubbleMacTest.* tests may have the same issue too.

BUG=none
TEST=trybots and less flakiness

Review URL: http://codereview.chromium.org/460029
------------------------------------------------------------------------
r33642 | thestig@chromium.org | 2009-12-03 02:07:12 +0100 (Thu, 03 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/base/base_paths.h
   M /trunk/src/base/base_paths_mac.h
   M /trunk/src/base/base_paths_mac.mm
   M /trunk/src/chrome/browser/profile.cc

Mac: Rename DIR_CACHE to DIR_USER_CACHE, which is already used on Linux.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/463005
------------------------------------------------------------------------
r33626 | mattm@chromium.org | 2009-12-03 01:09:09 +0100 (Thu, 03 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix leaking ExtensionMessageService in ProfileManagerTest.

BUG=28824
TEST=tools/valgrind/chrome_tests.sh -t unit --gtest_filter=ProfileManagerTest.CreateProfile

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33611

Review URL: http://codereview.chromium.org/455031
------------------------------------------------------------------------
r33622 | gspencer@chromium.org | 2009-12-03 00:51:54 +0100 (Thu, 03 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

This removes the "default browser" selections from the Chromium OS
build of Chromium, for both the views and the gtk versions of the
options panel.

BUG=768
TEST=Built chrome for chromeos and verified that the default browser
items were no longer there.
Review URL: http://codereview.chromium.org/464006
------------------------------------------------------------------------
r33619 | estade@chromium.org | 2009-12-03 00:41:18 +0100 (Thu, 03 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Change LOG(WARNING) to LOG(INFO) in a couple places.

This prevents console spew when ctrl+c closing works gracefully.

Review URL: http://codereview.chromium.org/462013
------------------------------------------------------------------------
r33617 | estade@chromium.org | 2009-12-03 00:40:50 +0100 (Thu, 03 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.cc

GTK: improve look of download in progress dialog.

BUG=29174

Review URL: http://codereview.chromium.org/464005
------------------------------------------------------------------------
r33615 | thestig@chromium.org | 2009-12-03 00:26:50 +0100 (Thu, 03 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc

Linux: Make the sad tab link readable.

BUG=28796
TEST=Link on about:crash is not blue on blue.
Review URL: http://codereview.chromium.org/444008
------------------------------------------------------------------------
r33613 | mattm@chromium.org | 2009-12-03 00:07:33 +0100 (Thu, 03 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Revert 33611 - Fix leaking ExtensionMessageService in ProfileManagerTest.

BUG=28824
TEST=tools/valgrind/chrome_tests.sh t unit gtest_filter=ProfileManagerTest.CreateProfile

Review URL: http://codereview.chromium.org/455031

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/458012
------------------------------------------------------------------------
r33611 | mattm@chromium.org | 2009-12-02 23:57:02 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix leaking ExtensionMessageService in ProfileManagerTest.

BUG=28824
TEST=tools/valgrind/chrome_tests.sh -t unit --gtest_filter=ProfileManagerTest.CreateProfile

Review URL: http://codereview.chromium.org/455031
------------------------------------------------------------------------
r33610 | avi@chromium.org | 2009-12-02 23:52:31 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm

Put in a "knock it off" checkbox in Mac alerts, to prevent web pages from locking the user out. Matches existing UI in Linux/Windows.

BUG=http://crbug.com/26800
TEST=as in bug

Review URL: http://codereview.chromium.org/460025
------------------------------------------------------------------------
r33609 | mirandac@chromium.org | 2009-12-02 23:42:57 +0100 (Wed, 02 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Put "make this my home page" link into the tip section.

BUG= 28196
TEST= "make this my home page" should show up as a tip.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33527
Review URL: http://codereview.chromium.org/449073
------------------------------------------------------------------------
r33608 | willchan@chromium.org | 2009-12-02 23:41:05 +0100 (Wed, 02 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h

Kill holdback for Http Prioritization experiment.  Turn on to 100%.

Review URL: http://codereview.chromium.org/458010
------------------------------------------------------------------------
r33607 | andybons@chromium.org | 2009-12-02 23:30:37 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm

Makes 'Cancel' the default button for extension install/uninstall confirmation dialogs.

BUG=26357
TEST=try to install any extension on Mac, verify that the default (blue) button with the key equivalent of 'Return' is the abort action, NOT the install action.
Review URL: http://codereview.chromium.org/463008
------------------------------------------------------------------------
r33604 | nick@chromium.org | 2009-12-02 23:01:31 +0100 (Wed, 02 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/character_set_converters_posix.cc

sync: clean up a little bit the character_set_converters code.

Patch from Thiago Farina <thiago.farina@gmail.com>

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/442014
------------------------------------------------------------------------
r33600 | estade@chromium.org | 2009-12-02 22:01:57 +0100 (Wed, 02 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Gtk: theme certain close buttons:

- download shelf
- find bar
- blocked popup container

Notably, don't theme the infobar close button.

In a follow up patch, I will fix the findbar and blocked popup container of Windows.

BUG=29101

Review URL: http://codereview.chromium.org/454024
------------------------------------------------------------------------
r33599 | phajdan.jr@chromium.org | 2009-12-02 21:48:53 +0100 (Wed, 02 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Unload the entire extension when any part of it crashes.

Also enable the task_manager_browsertest.cc (where I added the new test) on Linux.

TEST=Covered by browser_tests.
BUG=21635

Review URL: http://codereview.chromium.org/465007
------------------------------------------------------------------------
r33598 | andybons@chromium.org | 2009-12-02 21:31:00 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm

Fixes two problems caused by core animation race conditions. One involves clicking a browser action multiple times very quickly. The other has to do with the frame of the popup changing mid-animation.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/464004
------------------------------------------------------------------------
r33595 | kuan@chromium.org | 2009-12-02 21:05:43 +0100 (Wed, 02 Dec 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

linux_view: implement learn-more link in crash page
- enable mouse-over event to show hand-cursor
- enable mouse-click event, which launches help url

win and linux_view: use TabContents to launch url for link in crash page
- was using BrowserList::GetLastActive, but in chrome frame, this is null, so url can't launch.
- now, TabcontentsView passes its TabContents when creating SadTabView.
- SadTabView only creates learn-more link if TabContents is not null.

BUG=27298,29034
TEST=chromeos: verify that link in crash page shows hand cursor on mouse over, and launches help url when clicked. 
win, chromeos: link in crash page can be launched successfully in chrome-frame release.
Review URL: http://codereview.chromium.org/460021
------------------------------------------------------------------------
r33573 | phajdan.jr@chromium.org | 2009-12-02 16:53:06 +0100 (Wed, 02 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   A /trunk/src/chrome/test/data/extensions/privacy_blacklists
   A /trunk/src/chrome/test/data/extensions/privacy_blacklists/invalid_blacklist
   A /trunk/src/chrome/test/data/extensions/privacy_blacklists/invalid_blacklist/manifest.json
   A /trunk/src/chrome/test/data/extensions/privacy_blacklists/invalid_blacklist/privacy_blacklist.pbl
   A /trunk/src/chrome/test/data/extensions/privacy_blacklists/missing_blacklist
   A /trunk/src/chrome/test/data/extensions/privacy_blacklists/missing_blacklist/manifest.json

Validate privacy blacklist format when validating an extension
containing a privacy blacklist.

TEST=Covered by unit_tests.
BUG=21541

Review URL: http://codereview.chromium.org/453016
------------------------------------------------------------------------
r33571 | thomasvl@chromium.org | 2009-12-02 16:09:16 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_mac.mm

Tweak how we force the locale from the browser, this allow browser_tests to startup without doing the cocoa locale force (since it isn't valid there).

BUG=none
TEST=ntp tips, history times stamps, etc. all still in the right locale
Review URL: http://codereview.chromium.org/449076
------------------------------------------------------------------------
r33565 | thestig@chromium.org | 2009-12-02 09:45:01 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base_paths.h
   M /trunk/src/base/base_paths_posix.cc
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/base/test/test_suite.h
   A /trunk/src/base/third_party/xdg_user_dirs (from /trunk/src/chrome/third_party/xdg_user_dirs:33409)
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_paths_internal.h
   M /trunk/src/chrome/common/chrome_paths_linux.cc
   D /trunk/src/chrome/third_party/xdg_user_dirs
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/base/yuv_convert_unittest.cc
   M /trunk/src/media/filters/file_data_source_unittest.cc

Move some XDG code from chrome to base, make DIR_USER_CACHE generic rather than Chromium specific, and clean up a few headers.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/449048
------------------------------------------------------------------------
r33564 | phajdan.jr@chromium.org | 2009-12-02 09:22:30 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_metrics.cc

Still fixing ChromiumOS build.

TBR=thestig

Review URL: http://codereview.chromium.org/459013
------------------------------------------------------------------------
r33563 | phajdan.jr@chromium.org | 2009-12-02 09:16:39 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Fix Windows build by #including needed header.

TBR=sky

Review URL: http://codereview.chromium.org/463003
------------------------------------------------------------------------
r33562 | phajdan.jr@chromium.org | 2009-12-02 09:14:47 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc

Fix ChromeOS build by #including needed header.

TBR=sky

Review URL: http://codereview.chromium.org/459012
------------------------------------------------------------------------
r33561 | phajdan.jr@chromium.org | 2009-12-02 09:03:16 +0100 (Wed, 02 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   A /trunk/src/chrome/browser/spellcheck_host_observer.h
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/visitedlink_master.cc

[GTTF] Reduce header dependencies in chrome.

Review URL: http://codereview.chromium.org/457025
------------------------------------------------------------------------
r33546 | mbelshe@google.com | 2009-12-02 05:31:31 +0100 (Wed, 02 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   A /trunk/src/net/base/request_priority.h
   M /trunk/src/net/flip/flip_session.cc
   M /trunk/src/net/flip/flip_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_request_info.h
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_type.h

Update network priorities to support better granularity
of resource loading from WebKit into the network stack.

In order to fully make these work, webkit changes are needed
as well.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/452033
------------------------------------------------------------------------
r33545 | pkasting@chromium.org | 2009-12-02 04:59:28 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Make the safe_browsing_util.cc function definition order match the declaration order.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/460008
------------------------------------------------------------------------
r33543 | akalin@chromium.org | 2009-12-02 04:39:28 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Removed TabContentsDelegate::ShouldDisplayURLField() which is unused anywhere.

BUG=
TEST=trybots

Review URL: http://codereview.chromium.org/462001
------------------------------------------------------------------------
r33541 | aa@chromium.org | 2009-12-02 04:22:35 +0100 (Wed, 02 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/app/breakpad_win.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Ok, here is a different approach at this change.

Instead of storing pointers into a vector, store offsets. That
way, if the vector resizes, we should still be OK.

Also, add a DCHECK that we only enter this method once, which
is my current assumption.

Review URL: http://codereview.chromium.org/457028
------------------------------------------------------------------------
r33539 | akalin@chromium.org | 2009-12-02 03:52:45 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h

Added protected destructor to BrowserWindow.

BUG=
TEST=trybots

Review URL: http://codereview.chromium.org/460006
------------------------------------------------------------------------
r33538 | mirandac@chromium.org | 2009-12-02 03:21:36 +0100 (Wed, 02 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Revert 33527 - Put "make this my home page" link into the tip section.

BUG= 28196
TEST= "make this my home page" should show up as a tip.

Review URL: http://codereview.chromium.org/449073

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/460007
------------------------------------------------------------------------
r33534 | thestig@chromium.org | 2009-12-02 02:55:06 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/breakpad/breakpad.gyp
   A /trunk/src/breakpad/linux/breakpad_googletest_includes.h
   D /trunk/src/breakpad/linux/directory_reader.h
   D /trunk/src/breakpad/linux/directory_reader_unittest.cc
   D /trunk/src/breakpad/linux/dump_symbols.cc
   D /trunk/src/breakpad/linux/dump_symbols.h
   D /trunk/src/breakpad/linux/dump_syms.cc
   D /trunk/src/breakpad/linux/exception_handler.cc
   D /trunk/src/breakpad/linux/exception_handler.h
   D /trunk/src/breakpad/linux/exception_handler_unittest.cc
   D /trunk/src/breakpad/linux/file_id.cc
   D /trunk/src/breakpad/linux/file_id.h
   M /trunk/src/breakpad/linux/generate-test-dump.cc
   D /trunk/src/breakpad/linux/line_reader.h
   D /trunk/src/breakpad/linux/line_reader_unittest.cc
   D /trunk/src/breakpad/linux/linux_dumper.cc
   D /trunk/src/breakpad/linux/linux_dumper.h
   D /trunk/src/breakpad/linux/linux_dumper_unittest.cc
   D /trunk/src/breakpad/linux/linux_libc_support.h
   D /trunk/src/breakpad/linux/linux_libc_support_unittest.cc
   D /trunk/src/breakpad/linux/linux_syscall_support.h
   D /trunk/src/breakpad/linux/memory.h
   D /trunk/src/breakpad/linux/memory_unittest.cc
   D /trunk/src/breakpad/linux/minidump-2-core.cc
   D /trunk/src/breakpad/linux/minidump_file_writer.cc
   D /trunk/src/breakpad/linux/minidump_format_linux.h
   D /trunk/src/breakpad/linux/minidump_writer.cc
   D /trunk/src/breakpad/linux/minidump_writer.h
   D /trunk/src/breakpad/linux/minidump_writer_unittest.cc
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/crash_handler_host_linux.cc
   M /trunk/src/chrome/chrome.gyp

Linux: Use upstream google-breakpad instead of our fork.

BUG=28276
TEST=dump_syms works with ToT Chrome.
Review URL: http://codereview.chromium.org/414049
------------------------------------------------------------------------
r33533 | jcampan@chromium.org | 2009-12-02 02:48:35 +0100 (Wed, 02 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_host.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_host.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Make sure we don't dismiss extension popups when the focus
changes for a child window of the popup, as it is the case
with select popups.

BUG=28110
TEST=Make sure extension popups are still working as expected.
     Open an extension popup with a select popup (combo box)
     in it. Click on the select to bring up its popup, the
     extension popup should stay opened.

Review URL: http://codereview.chromium.org/459005
------------------------------------------------------------------------
r33530 | mpcomplete@chromium.org | 2009-12-02 02:42:41 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Delete old version directories of installed extensions during garbage
collection.

BUG=28884

Review URL: http://codereview.chromium.org/455026
------------------------------------------------------------------------
r33529 | tony@chromium.org | 2009-12-02 02:41:06 +0100 (Wed, 02 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider_unittest.cc

Take 2 at: Fix the opacity of titlebars on the NTP page.
We were accidentally setting the opacity to 1/255.

This bug was introduced in r32643.  Fix the unittest too.

BUG=29107

Review URL: http://codereview.chromium.org/461003
------------------------------------------------------------------------
r33528 | tony@chromium.org | 2009-12-02 02:30:31 +0100 (Wed, 02 Dec 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Revert 33526 - Fix the opacity of titlebars on the NTP page.  We were accidentally
setting the opacity to 1/255.

This bug was introduced in r32643.

BUG=29107

Review URL: http://codereview.chromium.org/452040

TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/460004
------------------------------------------------------------------------
r33527 | mirandac@chromium.org | 2009-12-02 02:29:44 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Put "make this my home page" link into the tip section.

BUG= 28196
TEST= "make this my home page" should show up as a tip.

Review URL: http://codereview.chromium.org/449073
------------------------------------------------------------------------
r33526 | tony@chromium.org | 2009-12-02 02:15:22 +0100 (Wed, 02 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Fix the opacity of titlebars on the NTP page.  We were accidentally
setting the opacity to 1/255.

This bug was introduced in r32643.

BUG=29107

Review URL: http://codereview.chromium.org/452040
------------------------------------------------------------------------
r33524 | ananta@chromium.org | 2009-12-02 01:48:55 +0100 (Wed, 02 Dec 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

Speculative fix for ChromeFrame crash in bug http://code.google.com/p/chromium/issues/detail?id=29025

The crash occurs while dereferencing the automation channel to send out the SetCookie IPC message on the
automation channel to the host browser. Based on what I could see from the crash dump and the code
it seems like there could be a scenario where the AutomationResourceContext object could be destroyed
while the AutomationCookieStore object is still around and thus ends up with a stale pointer which crashes
when dereferenced.

Fix is to ensure that all related code paths hold on to a refcounted AutomationResourceContext instance.

I will look into whether it is possible to come up with a unit test for this.

Bug=29025

Review URL: http://codereview.chromium.org/450020
------------------------------------------------------------------------
r33523 | estade@chromium.org | 2009-12-02 01:40:44 +0100 (Wed, 02 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

GTK: don't apply gtk theme to the info bubble for the extension popup.

BUG=29096

Review URL: http://codereview.chromium.org/450043
------------------------------------------------------------------------
r33522 | estade@chromium.org | 2009-12-02 01:40:29 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

GTK: Support plain text target as source for bookmark drags initiated from bookmark manager and bookmark bar.

BUG=29029
TEST=drag a bookmark into an <input> field

Review URL: http://codereview.chromium.org/449067
------------------------------------------------------------------------
r33519 | viettrungluu@chromium.org | 2009-12-02 01:30:00 +0100 (Wed, 02 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Windows/Linux: remove useless SetProfile() on tab selection.

(We have a fixed profile per browser.) The Mac code never had this SetProfile().

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/450038
------------------------------------------------------------------------
r33510 | eroman@chromium.org | 2009-12-02 00:54:49 +0100 (Wed, 02 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Hold a reference to object returned by GetGlobalHostResolver().
This change is to help diagnose bug 29038.

BUG=29038

Review URL: http://codereview.chromium.org/455025
------------------------------------------------------------------------
r33509 | pkasting@chromium.org | 2009-12-02 00:50:10 +0100 (Wed, 02 Dec 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Build fix for Linux perf bot.

------------------------------------------------------------------------
r33503 | willchan@chromium.org | 2009-12-02 00:22:45 +0100 (Wed, 02 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc

Mark BlacklistManagerBrowserTest.Basic as flaky.
BUG=29113

Review URL: http://codereview.chromium.org/458003
------------------------------------------------------------------------
r33502 | willchan@chromium.org | 2009-12-02 00:14:50 +0100 (Wed, 02 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Marking SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching as flaky.
BUG=29110

Review URL: http://codereview.chromium.org/450044
------------------------------------------------------------------------
r33501 | brettw@chromium.org | 2009-12-02 00:07:02 +0100 (Wed, 02 Dec 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/third_party/npapi/bindings/npapi.h
   A /trunk/src/third_party/npapi/bindings/npapi_extensions.h (from /trunk/src/webkit/glue/pepper/pepper.h:33382)
   M /trunk/src/third_party/npapi/npapi.gyp
   D /trunk/src/webkit/glue/pepper
   M /trunk/src/webkit/glue/plugins/nphostapi.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/tools/pepper_test_plugin/plugin_object.cc
   M /trunk/src/webkit/tools/pepper_test_plugin/plugin_object.h

Update the Pepper APIs to the latest spec for the 2D demo plugin.

This also adds the npapi headers to the npapi.gyp file since I got tired of
Visual Studio not finding the files.

This removes the "open file in sandbox" feature which it doesn't look like we
will use.

One more significant change is that I changed to including pepper.h in all
cases, even when pepper is disabled. We used to have a forward declare in
npapi.h for the structs in question, but we'll be adding a lot more structs for
the different contexts and I don't think this will scale. I think its OK fo
rthe pepper API declarations to be available when Pepper isn't enabled.

BUT=none
TEST=none

Review URL: http://codereview.chromium.org/453015
------------------------------------------------------------------------
r33489 | jam@chromium.org | 2009-12-01 23:23:59 +0100 (Tue, 01 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Fix DCHECK that was firing in metrics service in debug builds.  This particular case was harmless with no underlying bugs.

BUG=29085
Review URL: http://codereview.chromium.org/449068
------------------------------------------------------------------------
r33486 | mbelshe@google.com | 2009-12-01 23:15:40 +0100 (Tue, 01 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Move WinSock initialize earlier in the startup process.  I ran into
a case where my extension used the network; but because extensions are
initialized earlier than WinSock init, the extension failed when
trying to do a dns lookup.  This only fails because it was in conjunction
with the --single-process flag, so it is unlikely to effect others.

Nonetheless, there is really no harm in moving winsock initialization
to be very early.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/454021
------------------------------------------------------------------------
r33484 | viettrungluu@chromium.org | 2009-12-01 23:14:41 +0100 (Tue, 01 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Mac: disable bookmark bar animation in toolbar-less windows.

(It's still a bit odd that some of these windows (e.g., Developer Tools) display
a location bar. The displayed bar is also a strange size and not properly
framed. These are separate bugs.)

BUG=29070
TEST=Open a normal web page and then also a Developer Tools window (Cmd-Opt-I). Focus the window (and tab) with the normal web page. Press Shift-Cmd-B a few times. Make sure no animation occurs in the Developer Tools window. Also make sure the bookmark bar animations occur normally in normal browser windows.

Review URL: http://codereview.chromium.org/453020
------------------------------------------------------------------------
r33479 | pkasting@chromium.org | 2009-12-01 22:09:54 +0100 (Tue, 01 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   D /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Clean up Safe Browsing code a little:
* Update copyrights.
* Remove unnecessary headers.
* Remove useless functions.
* Make declaration and definition order match (in at least the _database_bloom.* files).
* Eliminate database_perftest.cc, since it seems to have been disabled entirely since before the public launch, and looks like it's perhaps irrelevant to the current code design.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/457019
------------------------------------------------------------------------
r33478 | viettrungluu@chromium.org | 2009-12-01 22:03:32 +0100 (Tue, 01 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm

Mac: allow bookmark bar buttons to be dragged as URLs.

TODO #1: dragging of folder buttons.
TODO #2: perhaps holding Option while dragging on the bookmark bar should force
the bookmark to be copied instead of moved.

BUG=17608, 28842
TEST=Make a bunch of (non-folder) bookmarks on the bookmark bar; try dragging these bookmark bar buttons to the desktop, to the web content area, to text boxes, to other browsers -- these should all do sensible things; make sure that dragging them around on the bookmark bar still rearranges them.

Review URL: http://codereview.chromium.org/434095
------------------------------------------------------------------------
r33476 | johnnyg@chromium.org | 2009-12-01 21:54:58 +0100 (Tue, 01 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/profile.cc

Keep incognito notification preferences separate from regular ones, and don't persist them permanently.

BUG=none
TEST=use notifications in incognito

Review URL: http://codereview.chromium.org/455004
------------------------------------------------------------------------
r33475 | skrul@chromium.org | 2009-12-01 21:48:47 +0100 (Tue, 01 Dec 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/webdata/web_data_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Add the beginnings of a unit test for the autofill features of the WebDataService.

This is so I can start adding change notification to the autofill methods, which is need to sync this data type.

Review URL: http://codereview.chromium.org/435030
------------------------------------------------------------------------
r33470 | arv@chromium.org | 2009-12-01 21:16:49 +0100 (Tue, 01 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Allow tips with a[target]

This does not reject links with targets but it does reset the target to the 
current page.

BUG=29084
TEST=With tips turned on and the web inspector shown. You should no longer
see any warnings about a[target]

Review URL: http://codereview.chromium.org/452029
------------------------------------------------------------------------
r33463 | kuchhal@chromium.org | 2009-12-01 20:17:26 +0100 (Tue, 01 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/google_update_settings_posix.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Remove executable property that got set by mistake.

BUG=23658
TEST=make sure executable property is not in svn

Review URL: http://codereview.chromium.org/449066
------------------------------------------------------------------------
r33461 | tony@chromium.org | 2009-12-01 19:50:33 +0100 (Tue, 01 Dec 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fix a bug where not all autocomplete entries were being shown when
the popup got resized smaller.

To repro:
- go to the chrome issue tracker (crbug.com)
- search for "aaaa" and "aaa"
- clear the search field and paste "aaaa" into the box
- press backspace

At this point, you should see both autocomplete suggestions.

BUG=29042

Review URL: http://codereview.chromium.org/457024
------------------------------------------------------------------------
r33455 | viettrungluu@chromium.org | 2009-12-01 18:57:12 +0100 (Tue, 01 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm

Mac: change tab change notifications to pass full TabChangeType.

This makes the Mac code better parallel that on other platforms. It will also be needed to make the "glow" animation for (unselected, title-changing) pinned tabs work. (I have a mostly-working patch which does the glow, but it's horribly hacky and to get it to completely work would either involve much more hackiness or significant refactoring. That's why the glow is not part of this CL.)

Also: prevent changes in background tabs (e.g., loading finished) from killing any current bookmark bar animation. Still to do on this front (part of issue 27693): be smarter about bookmark bar updates in the selected tab.

BUG=28154, 27693
TEST=Load lots of (slow-loading) pages in background tabs while pressing Shift-Cmd-B repeatedly; make sure changes in background (unselected) tabs don't cancel the animation.

Review URL: http://codereview.chromium.org/449056
------------------------------------------------------------------------
r33450 | thomasvl@chromium.org | 2009-12-01 18:42:02 +0100 (Tue, 01 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm

Mark the help menu as such so Cocoa adds the search item.

BUG=28987
TEST=set lang to french, launch, the help menu should have search option on 10.6
Review URL: http://codereview.chromium.org/452011
------------------------------------------------------------------------
r33446 | pinkerton@chromium.org | 2009-12-01 18:09:50 +0100 (Tue, 01 Dec 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Clean up property name and add comment about thread-safety.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/456022
------------------------------------------------------------------------
r33440 | sgk@chromium.org | 2009-12-01 14:48:04 +0100 (Tue, 01 Dec 2009) | 5 lines
Changed paths:
   M /trunk/src/base/leak_annotations.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/third_party/tcmalloc/chromium/src/config.h
   M /trunk/src/webkit/DEPS
   M /trunk/src/webkit/extensions/v8/heap_profiler_extension.cc

Point #include lines to files in the new tcmalloc/chromium local branch.
Add +third_party\tcmalloc to webkit\DEPS.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/449016
------------------------------------------------------------------------
r33434 | piman@chromium.org | 2009-12-01 08:15:14 +0100 (Tue, 01 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

linux: don't try to create plugin container if view_ is NULL

This can only happen for extensions with delay-initialized RenderWidgetHost.

BUG=28715

Review URL: http://codereview.chromium.org/450029
------------------------------------------------------------------------
r33409 | viettrungluu@chromium.org | 2009-12-01 02:47:46 +0100 (Tue, 01 Dec 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Mac: minor cleanup for TabView.

This is only the beginning.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/449038
------------------------------------------------------------------------
r33396 | wtc@chromium.org | 2009-12-01 01:57:19 +0100 (Tue, 01 Dec 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc

Add a "// namespace" comment after the closing curly brace
of a namespace to make cpplint happy.

R=zork
BUG=none
TEST=no compilation errors
Review URL: http://codereview.chromium.org/450027
------------------------------------------------------------------------
r33395 | suzhe@chromium.org | 2009-12-01 01:55:59 +0100 (Tue, 01 Dec 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h

Optimize the rendering when there are pending key events.

BUG=27932: Regression: Forced rendering for every keystroke
TEST=See the bug report.

Review URL: http://codereview.chromium.org/435002
------------------------------------------------------------------------
r33391 | albertb@google.com | 2009-12-01 01:39:53 +0100 (Tue, 01 Dec 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h

Plumping for taking LSID cookie from ProfileSyncService to GaiaAuthenticator.

Review URL: http://codereview.chromium.org/366035
------------------------------------------------------------------------
r33389 | estade@chromium.org | 2009-12-01 01:35:16 +0100 (Tue, 01 Dec 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: add middle click and right click functionality to maximize button.

If the user right clicks on the maximize button, it will horizontally maximize the window, and if the user middle clicks on the maximize button it will vertically maximize the window.

At least on kde, the window manager supports more complicated behavior, e.g. right clicking on a window that is horizontally maximized will return it to its former size. It seems to keep track of multiple restored rects. However, we're not well equipped to replicate this behavior, so I just didn't add it. If the user wants it, they can disable the custom frame.

BUG=28881

Review URL: http://codereview.chromium.org/455012
------------------------------------------------------------------------
r33380 | gspencer@google.com | 2009-12-01 01:00:43 +0100 (Tue, 01 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_url_handler.cc

This fixes an issue where view source on a local file would return a
blank page.

This bug was introduced by the fix for issue 26129 (r30418), which
was to limit view source so that it wouldn't be able to load
javascript or data URLs, but that change forgot to allow file urls.

This fixes the above omission by allowing file URLs again.

TEST=works:view-source:file:///tmp/test.html, doesn't work:view-source:javascript:alert('foo')
BUG=27409
Review URL: http://codereview.chromium.org/434094
------------------------------------------------------------------------
r33379 | tim@chromium.org | 2009-12-01 00:56:56 +0100 (Tue, 01 Dec 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Makes the chevron throb after a user sync'ed his bookmarks (if the overflow menu is shown)
This also makes the chevron throb when no bookmarks is added during a sync and merge. 

BUG=24306
TEST=sync with over 10 bookmarks in the bookmark bar so that the chevron is visible.

Patch by Bruno Calvignac<BrunoCalvignac@gmail.com>
Original Review: http://codereview.chromium.org/306054/show

Review URL: http://codereview.chromium.org/454010
------------------------------------------------------------------------
r33373 | mattm@chromium.org | 2009-12-01 00:40:08 +0100 (Tue, 01 Dec 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

Linux cookies view: ui cleanups to match win.

Show tree lines.

Domains are collapsed by default and expanding them expands all their children

Don't show the column header in the tree view anymore.

BUG=27657
TEST=compare to win

Review URL: http://codereview.chromium.org/444010
------------------------------------------------------------------------
r33369 | jamesr@chromium.org | 2009-12-01 00:18:29 +0100 (Tue, 01 Dec 2009) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

Revert 33344 - Relocate plugin list fetching to PluginService

We fetch the plugin list from three places.  Previously, each location had
custom code to proxy the query to the file thread.  This change moves
the query to the PluginService, which then internally manages posting to
the file thread and calling back.

I experimented with some different approaches to handling the lifetimes
of the requests and responses.  The approach now is simple:
 The PluginService plugin methods are called and respond on the IO
  thread.  Two of the three consumers of the plugin lists are already on
  the IO thread, so they don't need any complicated thread handling.
 None of the callers ever need to cancel their requests: one is a
  singleton, and the other two always wait (in terms of holding a ref
  on the object) for the requests to complete.  This makes lifetime
  management a lot simpler than it would otherwise be.

With this change in place, I can then look at refactoring the PluginService
implementation on Linux to do more complicated plugin loading as needed in
bug 17863.

BUG=17863

Review URL: http://codereview.chromium.org/437069

TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/456012
------------------------------------------------------------------------
r33359 | mattm@chromium.org | 2009-11-30 23:41:36 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/common/gtk_tree.cc

Linux: Adds back the ability to filter cookies by origin in the cookies options view

BUG=27657
TEST=unittest passes, manually testing typing "google" in the search field pulls up origins containing "google" in their name

Review URL: http://codereview.chromium.org/437075
------------------------------------------------------------------------
r33355 | estade@chromium.org | 2009-11-30 23:29:04 +0100 (Mon, 30 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Dynamically adjust width of download item dangerous warning.

BUG=28707

Review URL: http://codereview.chromium.org/456003
------------------------------------------------------------------------
r33350 | kuan@chromium.org | 2009-11-30 23:07:04 +0100 (Mon, 30 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/sad_tab_view.cc

win: change link color in crash page to white.

BUG=28996
TEST=verify that link in crash page is white.
Review URL: http://codereview.chromium.org/453009
------------------------------------------------------------------------
r33348 | tony@chromium.org | 2009-11-30 22:59:53 +0100 (Mon, 30 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc

Remove another instance of using the transient pref service.  This pref
is only read from the options dialog, the windows installer (a separate
process) and a spot in safe browsing.  The only one that matters is
the safe browsing case.

BUG=28992

Review URL: http://codereview.chromium.org/456004
------------------------------------------------------------------------
r33347 | sky@chromium.org | 2009-11-30 22:57:21 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome.gyp

Fixes views/gtk build. ImporterView is windows specific.

BUG=none
TEST=none
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/449024
------------------------------------------------------------------------
r33344 | evan@chromium.org | 2009-11-30 22:52:32 +0100 (Mon, 30 Nov 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

Relocate plugin list fetching to PluginService

We fetch the plugin list from three places.  Previously, each location had
custom code to proxy the query to the file thread.  This change moves
the query to the PluginService, which then internally manages posting to
the file thread and calling back.

I experimented with some different approaches to handling the lifetimes
of the requests and responses.  The approach now is simple:
- The PluginService plugin methods are called and respond on the IO
  thread.  Two of the three consumers of the plugin lists are already on
  the IO thread, so they don't need any complicated thread handling.
- None of the callers ever need to cancel their requests: one is a
  singleton, and the other two always wait (in terms of holding a ref
  on the object) for the requests to complete.  This makes lifetime
  management a lot simpler than it would otherwise be.

With this change in place, I can then look at refactoring the PluginService
implementation on Linux to do more complicated plugin loading as needed in
bug 17863.

BUG=17863

Review URL: http://codereview.chromium.org/437069
------------------------------------------------------------------------
r33342 | akalin@chromium.org | 2009-11-30 22:50:19 +0100 (Mon, 30 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Enable sync by default on all platforms.

BUG=23073
TEST=ran without --enable-sync on OS X, made sure sync UI was still present

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33318

Review URL: http://codereview.chromium.org/438005
------------------------------------------------------------------------
r33338 | willchan@chromium.org | 2009-11-30 22:22:15 +0100 (Mon, 30 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm

Disable BugReportWindowController tests.
BUG=http://crbug.com/29019

Review URL: http://codereview.chromium.org/457008
------------------------------------------------------------------------
r33337 | tony@chromium.org | 2009-11-30 22:19:50 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc

Step 1 in getting rid of transient prefs.  Move over --homepage to
not using a transient pref.

BUG=28992

Review URL: http://codereview.chromium.org/457003
------------------------------------------------------------------------
r33336 | sky@chromium.org | 2009-11-30 22:19:07 +0100 (Mon, 30 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   A /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.cc
   A /trunk/src/chrome/browser/views/bookmark_bar_instructions_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/grid_layout.cc
   M /trunk/src/views/grid_layout.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Adds link to bookmark bar that when clicked imports bookmarks. I also
added support for baselines to GridLayout.

BUG=4374
TEST=On a new profile make sure the bookmark bar has a link to import
bookmarks, click the link and make sure you can import your bookmarks.

Review URL: http://codereview.chromium.org/440029
------------------------------------------------------------------------
r33335 | davemoore@chromium.org | 2009-11-30 22:18:51 +0100 (Mon, 30 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_prefs.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.cc
   M /trunk/src/net/base/file_stream_posix.cc

Add -profile command line switch

Review URL: http://codereview.chromium.org/384062
------------------------------------------------------------------------
r33326 | darin@chromium.org | 2009-11-30 21:39:41 +0100 (Mon, 30 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util.cc

Remove std::wstring from most of net/base/escape.h.

I left the one API because based on the comment, it should eventually be
removed. Updated the callers to use UTF16ToWideHack until more work can be done
to remove std::wstring. I also updated net/base/escape_unittest.cc to use the
same hack until a proper solution can be coded.

Original patch submission here:
http://codereview.chromium.org/402085

Patch by Patrick Scott (phanna@android.com)
R=darin
BUG=23581
TEST=escape_unittest

Review URL: http://codereview.chromium.org/452015
------------------------------------------------------------------------
r33324 | phajdan.jr@chromium.org | 2009-11-30 21:32:56 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/chrome_frame/test/net/test_automation_provider.h

[GTTF] Reduce header dependencies in chrome.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/454004
------------------------------------------------------------------------
r33322 | akalin@chromium.org | 2009-11-30 21:27:35 +0100 (Mon, 30 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Revert 33318 - Enable sync by default on all platforms.

BUG=23073
TEST=ran without enablesync on OS X, made sure sync UI was still present

Review URL: http://codereview.chromium.org/438005

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/455008
------------------------------------------------------------------------
r33319 | wtc@chromium.org | 2009-11-30 21:16:29 +0100 (Mon, 30 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/net/base/nss_memio.c
   M /trunk/src/net/socket/client_socket.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.h
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/socket/tcp_client_socket_win.h

Define the GetPeerName method of the ClientSocket interface for all
platforms, in preparation for using SSLClientSocketNSS on Windows.

nss_memio.c does not need to include <unistd.h>

Fix style nits.

R=eroman
BUG=28744
TEST=none
Review URL: http://codereview.chromium.org/440031
------------------------------------------------------------------------
r33318 | akalin@chromium.org | 2009-11-30 21:09:39 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Enable sync by default on all platforms.

BUG=23073
TEST=ran without --enable-sync on OS X, made sure sync UI was still present

Review URL: http://codereview.chromium.org/438005
------------------------------------------------------------------------
r33315 | pkasting@chromium.org | 2009-11-30 20:59:28 +0100 (Mon, 30 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h

Don't save popup blocker whitelist modifications performed while off the record.

BUG=none
TEST=Go incognito, visit popuptest.com, whitelist popups, restart and verify they're not whitelisted.
Review URL: http://codereview.chromium.org/434109
------------------------------------------------------------------------
r33309 | maruel@chromium.org | 2009-11-30 20:32:39 +0100 (Mon, 30 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/chrome_frame/test/net/test_automation_provider.h

Revert 33301 and 33305 due to unit_tests breakage.

TBR=pawel

Review URL: http://codereview.chromium.org/453007
------------------------------------------------------------------------
r33305 | phajdan.jr@chromium.org | 2009-11-30 19:45:28 +0100 (Mon, 30 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc

Fix compile for ChromeOS by #including needed headers.

TBR=maruel
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/457004
------------------------------------------------------------------------
r33302 | oshima@chromium.org | 2009-11-30 19:34:37 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Draw the normal window's frame in maximized mode. See BUG for more detail. Dan will investigate further when he has time.

BUG=28580, 727 (chromeos)
TEST=None

Review URL: http://codereview.chromium.org/436039
------------------------------------------------------------------------
r33301 | phajdan.jr@chromium.org | 2009-11-30 19:34:00 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   M /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/chrome_frame/test/net/test_automation_provider.h

[GTTF] Reduce header dependencies in chrome.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/454004
------------------------------------------------------------------------
r33293 | davemoore@chromium.org | 2009-11-30 18:19:52 +0100 (Mon, 30 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Show chromium os version in about panel

Review URL: http://codereview.chromium.org/440008
------------------------------------------------------------------------
r33291 | pinkerton@chromium.org | 2009-11-30 17:57:32 +0100 (Mon, 30 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Clear the target/action of the close button when the view goes into the closing state in an attempt to prevent errant messages to dead objects.
BUG=24987
TEST=open a ton of tabs, rapidly click the close box, hope nothing crashes and the tabs still close correctly.
------------------------------------------------------------------------
r33290 | phajdan.jr@chromium.org | 2009-11-30 17:11:27 +0100 (Mon, 30 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.cc
   D /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc (from /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.cc:33288)
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/data/extensions/common/privacy_blacklist/privacy_blacklist.pbl
   M /trunk/src/chrome/test/testing_profile.h

Integrate BlacklistManager with Profile.

Now each Profile has a BlacklistManager that maintains a compiled Blacklist for that Profile.

The system does not yet pause user-initiated web requests until the blacklist system is ready. However, the code is not supposed to be ready, and is hidden behind a --enable-privacy-blacklists command-line flag.

TEST=Covered by browser_test.
BUG=21541

Review URL: http://codereview.chromium.org/371063
------------------------------------------------------------------------
r33288 | yurys@chromium.org | 2009-11-30 16:46:58 +0100 (Mon, 30 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: fix on Linux and reenable DevToolsSanityTest.TestPauseWhenScriptIsRunning

Review URL: http://codereview.chromium.org/449013
------------------------------------------------------------------------
r33287 | viettrungluu@chromium.org | 2009-11-30 16:38:32 +0100 (Mon, 30 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Mac: improve apparent z-order problems when switching Spaces.

Remove the status bubble as child window when hidden, rather than just setting
its opacity to 0. I'm not sure about the effects, if any, of doing this rather
than destroying the window completely. This doesn't eliminate z-order problems
with Spaces, but should improve it considerably.

This may also ameliorate the problems with moving windows between Spaces using
Expose.

BUG=28107, 24956
TEST=Create a bunch of windows; get the status bubble to appear in the active (key) window and then get it to disappear; switch to another spaces and back; make sure the active window is on top; repeat.

Review URL: http://codereview.chromium.org/434120
------------------------------------------------------------------------
r33280 | yurys@chromium.org | 2009-11-30 10:40:19 +0100 (Mon, 30 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: temporarily diable DevToolsSanityTest.TestPauseWhenScriptIsRunning which fails on Linux

TBR=mnaganov@chromium.org

Review URL: http://codereview.chromium.org/454003
------------------------------------------------------------------------
r33279 | yurys@chromium.org | 2009-11-30 10:20:45 +0100 (Mon, 30 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   A /trunk/src/chrome/test/data/devtools/pause_when_script_is_running.html
   M /trunk/src/webkit/glue/devtools/debugger_agent.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.h

DevTools: process pause script request on the IO thread. To pause already running script we need to call v8::Debug::DebugBreak() on a thread different from the Render thread which may be busy with JS execution.

BUG=28892
TEST=DevToolsSanityTest.TestPauseWhenScriptIsRunning

Review URL: http://codereview.chromium.org/444017
------------------------------------------------------------------------
r33269 | nsylvain@chromium.org | 2009-11-30 06:07:55 +0100 (Mon, 30 Nov 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/app/breakpad_win.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Revert 33255 - Report active extensions in crash reports. This only implements Windows right now. Mac and linux will be separate CLs.

"Active" is overloaded to mean different things depending on
the process type:

 browser: all enabled extensions
 renderer: unique set of extensions from all user scripts
 extension: extensions running in the process

BUG=27169

Review URL: http://codereview.chromium.org/437078

--

There are thousands of new crashes with reivison 33256 and 33255, so i'm
reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL



TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/448006
------------------------------------------------------------------------
r33267 | nsylvain@chromium.org | 2009-11-30 05:58:18 +0100 (Mon, 30 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable DevToolsExtensionDebugTest.TestContentScriptIsPresent because
it started failing after the webkit merge.

Review URL: http://codereview.chromium.org/449008
------------------------------------------------------------------------
r33255 | aa@chromium.org | 2009-11-30 02:39:02 +0100 (Mon, 30 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/app/breakpad_win.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Report active extensions in crash reports. This only implements Windows right now. Mac and linux will be separate CLs.

"Active" is overloaded to mean different things depending on
the process type:

- browser: all enabled extensions
- renderer: unique set of extensions from all user scripts
- extension: extensions running in the process

BUG=27169

Review URL: http://codereview.chromium.org/437078
------------------------------------------------------------------------
r33241 | mark@chromium.org | 2009-11-28 23:05:11 +0100 (Sat, 28 Nov 2009) | 44 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/keystone_glue.h
   D /trunk/src/chrome/app/keystone_glue.mm
   D /trunk/src/chrome/app/keystone_glue_unittest.mm
   M /trunk/src/chrome/app/nibs/About.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/authorization_util.cc
   A /trunk/src/chrome/browser/cocoa/authorization_util.h
   A /trunk/src/chrome/browser/cocoa/keystone_glue.h (from /trunk/src/chrome/app/keystone_glue.h:32993)
   A /trunk/src/chrome/browser/cocoa/keystone_glue.mm (from /trunk/src/chrome/app/keystone_glue.mm:32993)
   A /trunk/src/chrome/browser/cocoa/keystone_glue_unittest.mm (from /trunk/src/chrome/app/keystone_glue_unittest.mm:32993)
   A /trunk/src/chrome/browser/cocoa/keystone_infobar.h
   A /trunk/src/chrome/browser/cocoa/keystone_infobar.mm
   A /trunk/src/chrome/browser/cocoa/keystone_promote_postflight.sh
   A /trunk/src/chrome/browser/cocoa/keystone_promote_preflight.sh
   A /trunk/src/chrome/browser/cocoa/scoped_authorizationref.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

In-application Keystone ticket promotion.

The concept of "ticket promotion" is added to the application when Keystone is
in use.  Ticket promotion is used to turn a user Keystone ticket, which Chrome
normally establishes when it launches, into a system Keystone ticket, after
successful user authentication and authorization.  Having a system Keystone
with a system ticket means that updates are applied with root privileges
instead of user privileges, essentially eliminating the possibility that a
user will fall off of the auto-update train because they can read and execute
but not write the application.

Two principles of promotion apply:

 - An application on a user ticket NEEDS promotion if it determines that it
   doesn't have permission to write to itself.  Being on a user ticket, an
   update attempt would fail.
 - An application on a user ticket WANTS promotion if it already NEEDS
   promotion.  Additionally, if it is installed in a system-wide location
   such as /Applications, it will WANT promotion, even if it does not NEED it.

If promotion is needed, an info bar will show up on launch requesting it.
This info bar works similarly to the default browser info bar: it has a "don't
bother me again" button, it will only show up after the first launch, it won't
disappear on navigation if the navigation happens very quickly, and it won't
show itself if another info bar is up.  This means that if both the default
browser info bar and the promotion info bar have a shot at showing, only one
will win.  In my experience, each wins about half of the time.

If promotion is needed, the update UI in the About window will be hidden.
Checking for updates and offering to apply them doesn't make much sense when
the update won't be able to install successfully.  All of the auto-update
machinery is still working in the background, but the About window UI is
hidden.

If promotion is wanted, the About window will contain a new button allowing
the user to enter promotion.  This gives access to the same promotion routine
as the promotion info bar.  It can be used even from an administrative account
that is able to update the application without promotion.  It's intended to be
used by the system administrator of the family without requiring them to
switch to one of the kids' accounts.

BUG=16360
TEST=Exhaustively, please.
Review URL: http://codereview.chromium.org/437053
------------------------------------------------------------------------
r33214 | phajdan.jr@chromium.org | 2009-11-26 20:48:34 +0100 (Thu, 26 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/hi_res_timer_manager.h
   A /trunk/src/app/hi_res_timer_manager_posix.cc
   A /trunk/src/app/hi_res_timer_manager_win.cc
   A /trunk/src/app/system_monitor.cc (from /trunk/src/base/system_monitor.cc:33213)
   A /trunk/src/app/system_monitor.h (from /trunk/src/base/system_monitor.h:33213)
   A /trunk/src/app/system_monitor_posix.cc (from /trunk/src/base/system_monitor_posix.cc:33213)
   A /trunk/src/app/system_monitor_unittest.cc (from /trunk/src/base/system_monitor_unittest.cc:33213)
   A /trunk/src/app/system_monitor_win.cc (from /trunk/src/base/system_monitor_win.cc:33213)
   M /trunk/src/base/base.gyp
   D /trunk/src/base/system_monitor.cc
   D /trunk/src/base/system_monitor.h
   D /trunk/src/base/system_monitor_posix.cc
   D /trunk/src/base/system_monitor_unittest.cc
   D /trunk/src/base/system_monitor_win.cc
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/base/time.h
   M /trunk/src/base/time_win.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/profile_import/profile_import_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/utility/utility_main.cc
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Make SystemMonitor not a Singleton and move it out of base

SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past.

Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/431008
------------------------------------------------------------------------
r33206 | apavlov@chromium.org | 2009-11-26 14:11:48 +0100 (Thu, 26 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

Remove Content-Type workaround for cached resources

BUG=27364
TEST=DevToolsSanityTest.TestCachedResourceMimeType

Review URL: http://codereview.chromium.org/437089
------------------------------------------------------------------------
r33182 | ukai@chromium.org | 2009-11-26 07:16:09 +0100 (Thu, 26 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc

Throttle websocket live experiment

0.5% of users will participate websocket live experiment.

BUG=28843
TEST=none

Review URL: http://codereview.chromium.org/434110
------------------------------------------------------------------------
r33177 | jorlow@chromium.org | 2009-11-26 06:18:18 +0100 (Thu, 26 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Re-enable Toolbar5ImporterTest

 * Fix disabled code to make it compile again.
 * The test doesn't pass if the importer thinks this is the first run of
   the browser, so call CreateSentinel() to mark this as a subsequent run.

BUG=11838
TEST=none

Review URL: http://codereview.chromium.org/437083
------------------------------------------------------------------------
r33168 | thestig@chromium.org | 2009-11-26 02:48:07 +0100 (Thu, 26 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix signal handlers so we don't fail a DCHECK.

BUG=none
TEST=ctrl+c in debug mode doesn't cause a DCHECK failure.
Review URL: http://codereview.chromium.org/442018
------------------------------------------------------------------------
r33165 | chron@google.com | 2009-11-26 02:16:57 +0100 (Thu, 26 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   M /trunk/src/chrome/browser/sync/resources/setup_done.html
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc

Fix keyboard focus in initial sync dialogs.
Remove stray style tag that caused validation problems.
TEST=manually tested
BUG=28803,28801

Review URL: http://codereview.chromium.org/442019
------------------------------------------------------------------------
r33164 | atwilson@chromium.org | 2009-11-26 02:10:30 +0100 (Thu, 26 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   A /trunk/src/chrome/test/data/workers/incognito_worker.html
   A /trunk/src/chrome/test/data/workers/incognito_worker.js
   M /trunk/src/chrome/worker/DEPS
   M /trunk/src/chrome/worker/worker_uitest.cc

Changed shared worker code so incognito windows do not have access to non-incognito shared workers.

BUG=27883
TEST=added new uitest

Review URL: http://codereview.chromium.org/441022
------------------------------------------------------------------------
r33162 | jorlow@chromium.org | 2009-11-26 01:37:06 +0100 (Thu, 26 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h

For now, let's clear local storage whenever we clear cookies.

BUG=28788
TEST="Clear private data..." from the menu, check cookies, and tell it ok.  Data in "Local Storage" inside the profile's data dir should be deleted and any open websites that were using that data should no longer be able to see it.
Review URL: http://codereview.chromium.org/441012
------------------------------------------------------------------------
r33152 | idana@chromium.org | 2009-11-26 00:31:35 +0100 (Thu, 26 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h

Patching the following CL from thiago.farina@gmail.com: http://codereview.chromium.org/418044

BUG=26551
TEST=See bug description
TBR=thiago.farina@gmail.com

Review URL: http://codereview.chromium.org/437073
------------------------------------------------------------------------
r33147 | mdm@chromium.org | 2009-11-25 23:54:00 +0100 (Wed, 25 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Be more paranoid when checking the default browser in Windows and return "not default" rather than "can't tell" in most cases.
Also undo previous fixes that worked around an incorrect return value; one of them (the infobar change) regresses the Linux version to display the infobar in cases where we would not be able to set ourselves as the default anyway (which was the original reason for the change that broke things on Windows).

BUG=28429, 27403

TEST=(windows) install chrome but don't set it as the default during install, then restart it and verify that the infobar shows and chrome can still be set as the default

TEST=(linux) run chrome in an unsupported desktop environment and verify that it neither displays the infobar asking to be made the default browser nor claims that it is the default browser in options
Review URL: http://codereview.chromium.org/434022
------------------------------------------------------------------------
r33146 | jorlow@chromium.org | 2009-11-25 23:52:21 +0100 (Wed, 25 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Fix incognito with LocalStorage.

BUG=28807
TEST=Incognito has seprate data from the main window and is reset when you close the incognito window.

Review URL: http://codereview.chromium.org/434099
------------------------------------------------------------------------
r33144 | chase@chromium.org | 2009-11-25 23:40:12 +0100 (Wed, 25 Nov 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

RESUBMIT of http://codereview.chromium.org/404025/show

Start the WebKit thread when we initialize the resource
dispatcher host.

NOTE: It's very possible this will have a startup
performance impact. I'm going to watch the bots after
committing.

TODO: Clean up shutdown logic that exists simply
because we don't know whether or not we'll ever start
the WebKit thread.

Originally landed in r33063, reverted in r33101 due to
coincidence with Modules Linux startup test failures.

TBR=jorlow, darin
TEST=The WebKit thread gets spun up early in the
initialization process.
BUG=24144,28364

Review URL: http://codereview.chromium.org/441025
------------------------------------------------------------------------
r33137 | oshima@chromium.org | 2009-11-25 23:18:13 +0100 (Wed, 25 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Flaky tests on linux/view/64bit builds.
Also updated browser_tests to use #define instead of #if/else, like other tests.

BUG=28808
TEST=None

Review URL: http://codereview.chromium.org/442012
------------------------------------------------------------------------
r33131 | tony@chromium.org | 2009-11-25 22:58:14 +0100 (Wed, 25 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc

Convert a few other places from using ApplyAccelerator (async) to
using RunCommand (sync).

Review URL: http://codereview.chromium.org/436031
------------------------------------------------------------------------
r33127 | chron@google.com | 2009-11-25 22:39:12 +0100 (Wed, 25 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc

Fix some minor things that were in the unique naming CL that I forgot to address.

Review URL: http://codereview.chromium.org/435026
------------------------------------------------------------------------
r33119 | chron@google.com | 2009-11-25 22:25:22 +0100 (Wed, 25 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

Make cancel button not pop up when you make a bad login.
BUG=27543
TEST=Manually tested

Review URL: http://codereview.chromium.org/437033
------------------------------------------------------------------------
r33109 | pkasting@chromium.org | 2009-11-25 21:47:52 +0100 (Wed, 25 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/base/json/json_reader.cc
   M /trunk/src/base/json/json_reader_unittest.cc
   M /trunk/src/base/json/json_writer.cc
   M /trunk/src/base/json/json_writer_unittest.cc
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/test/ui/javascript_test_util.cc
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/net/base/strict_transport_security_state.cc

Many changes to DictionaryValues:
* Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs.
* Use these APIs with all key iterator usage.
* SetXXX() calls cannot fail, so change them from bool to void.
* Change GetSize() to size() since it's cheap, and add empty().

Other:
* Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop).
* Shorten a few bits of code.

BUG=567
TEST=none
Review URL: http://codereview.chromium.org/441008
------------------------------------------------------------------------
r33108 | jshin@chromium.org | 2009-11-25 21:47:02 +0100 (Wed, 25 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Enable the RTL UI support in the extensions_ui (chrome://extensions). While doing so, make it use the font-family and font-size (84% by default) set in locale_settings for the current UI language. The body font size used to be 87%. To make up for the difference between two, the font sizes given in percentage are adjusted (increased) accordingly in the rest of the file.


BUG=28202
TEST=1. Run Chrome with '--lang=he' or '--lang=ar' on Windows (or 'LANGUAGE=he chrome' / 'LANGUAGE=ar chrome' on Linux) and go to 'chrome://extensions'. Strings are not yet translated, but the overall UI should be RTL.
2. Run Chrome in en-US (or your favorite LTR language) and go to 'chrome://extensions'. It should look the same as before.


Review URL: http://codereview.chromium.org/434024
------------------------------------------------------------------------
r33107 | dglazkov@chromium.org | 2009-11-25 21:43:50 +0100 (Wed, 25 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Plumb through site-specific quirks setting with a command line switch.

Quirks are enabled by default.

R=darin
BUG=19586
TEST=wikileaks.org should now have its sidebar in the proper place.

Review URL: http://codereview.chromium.org/442010
------------------------------------------------------------------------
r33104 | gwilson@google.com | 2009-11-25 21:04:28 +0100 (Wed, 25 Nov 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/group_policy.cc
   D /trunk/src/chrome/browser/group_policy.h
   D /trunk/src/chrome/browser/group_policy_settings.cc
   D /trunk/src/chrome/browser/group_policy_settings.h
   D /trunk/src/chrome/browser/group_policy_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Reverts 33093.  The unittest doesn't seem to be able to set registry keys.

R=jparent
TEST=bots green
Review URL: http://codereview.chromium.org/444002
------------------------------------------------------------------------
r33101 | chase@chromium.org | 2009-11-25 20:45:43 +0100 (Wed, 25 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Revert "RESUBMIT of http://codereview.chromium.org/404025/show"

There is a flaky failure in Linux startup tests that
started appearing after r33063 landed.  Try backing
out r33063 to see if this CL is the cause.

BUG=24144
TEST=linux startup tests pass
TBR=jorlow

Review URL: http://codereview.chromium.org/441020
------------------------------------------------------------------------
r33093 | gwilson@google.com | 2009-11-25 20:06:28 +0100 (Wed, 25 Nov 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/group_policy.cc
   A /trunk/src/chrome/browser/group_policy.h
   A /trunk/src/chrome/browser/group_policy_settings.cc
   A /trunk/src/chrome/browser/group_policy_settings.h
   A /trunk/src/chrome/browser/group_policy_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Adds basic group policy support.  Does not wire the settings to the preferences yet, but at least adds support for looking in the right place.

R=cpu,kuchhal
TEST=unit test included
BUG=19374


Review URL: http://codereview.chromium.org/405003
------------------------------------------------------------------------
r33079 | viettrungluu@chromium.org | 2009-11-25 18:41:18 +0100 (Wed, 25 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm

Mac: give visual feedback for bookmark button drags.

Draw a "ugly black bar" (where "black" is actually a theme colour) to indicate
where a bookmark button that's being dragged will end up if dropped. This is a
stopgap measure for the beta. Later, we will make the buttons move around
instead (even if implementable in the time remaining, such animations would be a
crash risk).

BUG=17608
TEST=Drag bookmark bar buttons around. Make sure that the bar indicating where a button will be dropped is visible enough and accurate. Repeat with various themes.

Review URL: http://codereview.chromium.org/437051
------------------------------------------------------------------------
r33069 | ian@chromium.org | 2009-11-25 17:31:50 +0100 (Wed, 25 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h

Adds back the ability to filter cookies by origin in the cookies options view.

BUG=27657
TEST=Typing "google" in the search field pulls up origins containing "google" in their name
Review URL: http://codereview.chromium.org/435024
------------------------------------------------------------------------
r33068 | oshima@chromium.org | 2009-11-25 17:08:59 +0100 (Wed, 25 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Moving two tests to FLAKY tests.
 TestHTTPSErrorWithNoNavEntry: fails differently on 32 and 64 bits due to timing issue. (We thought it's deterinistic, but this is apparently not)
 FindDisappearOnNavigate: due to asynchronous-ness on x11.

BUG=28629,28098
TEST=build and run browser_tests in 64bit.

Review URL: http://codereview.chromium.org/438010
------------------------------------------------------------------------
r33067 | viettrungluu@chromium.org | 2009-11-25 16:41:05 +0100 (Wed, 25 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm

Mac: fix Esc-key cancellation of bookmark bar button drags.

The drag would be cancelled after pressing Esc, but moving the mouse again would
cause the bookmark bar button to see a drag again and start a new drag. This
patch makes the button wait for the next mouse down.

BUG=28502
TEST=Drag bookmark bar button and keep mouse button; press Esc (and see cancellation animation); move mouse again and make sure a new drag doesn't start.

Review URL: http://codereview.chromium.org/437055
------------------------------------------------------------------------
r33063 | jorlow@chromium.org | 2009-11-25 15:07:01 +0100 (Wed, 25 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

RESUBMIT of http://codereview.chromium.org/404025/show

Start the WebKit thread when we initialize the resource dispatcher host.

NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.

TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.

TBR=darin
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144,28364

Review URL: http://codereview.chromium.org/432007
------------------------------------------------------------------------
r33057 | huanr@chromium.org | 2009-11-25 07:59:33 +0100 (Wed, 25 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h

Fixing 27834 by always deleting ExtensionMessageService on
UI thread.


BUG=27834
TEST=none

Review URL: http://codereview.chromium.org/440012
------------------------------------------------------------------------
r33056 | jam@chromium.org | 2009-11-25 07:54:11 +0100 (Wed, 25 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc

Move last shutdown file access off the UI thread and onto the file thread.

Review URL: http://codereview.chromium.org/437049
------------------------------------------------------------------------
r33051 | tim@chromium.org | 2009-11-25 06:47:19 +0100 (Wed, 25 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h

Fixed handling of preferred login info in password manager.

BUG=23850
TEST=Go to a login page (i.e. gmail), log in with several different user accounts.
Observe that the last used account is now the one that is used for the initial page autofill.

Patch by zelidrag@chromium.org
Original Review: http://codereview.chromium.org/437032

Review URL: http://codereview.chromium.org/434070
------------------------------------------------------------------------
r33050 | nick@chromium.org | 2009-11-25 06:11:11 +0100 (Wed, 25 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_linux.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_mac.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_unittest.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_win.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/chrome.gyp

sync: get rid of path_helpers files.

Patch from Thiago Farina (thiago.farina@gmail.com)

BUG=26443
TEST=None

Review URL: http://codereview.chromium.org/414072
------------------------------------------------------------------------
r33048 | hayato@chromium.org | 2009-11-25 05:23:02 +0100 (Wed, 25 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Ignore UTF-8's BOM when parsing userscript's metadata.

BUG=27333
TEST=UserScriptTest and check the issue does not happen against userscipt encoded in UTF-8 with BOM..

Review URL: http://codereview.chromium.org/420001
------------------------------------------------------------------------
r33046 | thestig@chromium.org | 2009-11-25 05:07:15 +0100 (Wed, 25 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Posix: Catch SIGHUP/SIGINT and do a clean shutdown.

BUG=28746
TEST=Ctrl+C = clean shutdown.
Review URL: http://codereview.chromium.org/432019
------------------------------------------------------------------------
r33044 | akalin@chromium.org | 2009-11-25 04:54:40 +0100 (Wed, 25 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   D /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   D /trunk/src/chrome/browser/sync/sync_status_ui_helper.h
   D /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac.h
   D /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac.mm
   D /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac_unittest.mm
   A /trunk/src/chrome/browser/sync/sync_ui_util.cc (from /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc:33035)
   A /trunk/src/chrome/browser/sync/sync_ui_util.h
   A /trunk/src/chrome/browser/sync/sync_ui_util_mac.h (from /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac.h:33035)
   A /trunk/src/chrome/browser/sync/sync_ui_util_mac.mm (from /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac.mm:33035)
   A /trunk/src/chrome/browser/sync/sync_ui_util_mac_unittest.mm (from /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac_unittest.mm:33035)
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp

Changed SyncStatusUIHelper namespace class into a real namespace (sync_ui_util), per style guide.

Changed static functions into anonymous-namespace functions.

Renamed files/namespaces from sync_status_ui_helper to sync_ui_util.

Moved sync_ui_util_mac.mm functions into sync_ui_util namespace.

Updated all callers.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/414065
------------------------------------------------------------------------
r33035 | aa@chromium.org | 2009-11-25 03:05:39 +0100 (Wed, 25 Nov 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/content_script_all_frames_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/examples/api/messaging/timer/page.js
   M /trunk/src/chrome/common/extensions/docs/static/content_scripts.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/all_frames.js
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/content_script_all_frames/top_frame_only.js
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/feed_finder.js
   A /trunk/src/chrome/test/data/extensions/test_file_with_iframe.html

Introduce a new 'all_frames' property to content scripts and
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.

Review URL: http://codereview.chromium.org/412008
------------------------------------------------------------------------
r33033 | hayato@chromium.org | 2009-11-25 03:02:39 +0100 (Wed, 25 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Tiny clean up. Use ASSERT_EQ instead of EXPECT_EQ.

BUG=None
TEST=UserScriptMasterTest

Review URL: http://codereview.chromium.org/434034
------------------------------------------------------------------------
r33026 | eroman@chromium.org | 2009-11-25 02:39:08 +0100 (Wed, 25 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher.cc

Remove the temporary instrumentation added to track down a crash in URLFetcher.

This is almost a full revert of r31526, except that the two DCHECK(url_request_context_getter_) which I promoted to CHECK()s remain as CHECK()s (since they will be useful to catch similar problems in the future, and are cheap).

BUG=27074

Review URL: http://codereview.chromium.org/434050
------------------------------------------------------------------------
r33022 | tommi@chromium.org | 2009-11-25 02:34:08 +0100 (Wed, 25 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/extra_system_apis.h
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/chrome_frame/urlmon_url_request.h

Transfer CF downloads to the host browser.TEST=Click a download link (not via redirect) in a web page displayed by Chrome Frame.  The request should be handled by the host browser.BUG=23561
Review URL: http://codereview.chromium.org/385108
------------------------------------------------------------------------
r32998 | estade@chromium.org | 2009-11-25 00:33:10 +0100 (Wed, 25 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

GTK: Don't send double/triple click events to renderer.

This goes along with webkit bug: https://bugs.webkit.org/show_bug.cgi?id=31841

BUG=17466

Review URL: http://codereview.chromium.org/431031
------------------------------------------------------------------------
r32997 | viettrungluu@chromium.org | 2009-11-25 00:26:38 +0100 (Wed, 25 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Allow the window to be moved when dragging on the incognito icon

BUG=25028
TEST=Drag the window from both incognito view and regular window bar while it's in foreground and background

Review URL: http://codereview.chromium.org/434030
Patch from feldstein.
------------------------------------------------------------------------
r32996 | mirandac@chromium.org | 2009-11-25 00:25:57 +0100 (Wed, 25 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Remove theming from notifications and extension/bookmark sync promo.

BUG= 28577
TEST= Trigger notification (remove a thumbnail) with themed browser, note that text and link in notification (and in extension/bookmark sync promo) are legible and retain original colors.


Review URL: http://codereview.chromium.org/437045
------------------------------------------------------------------------
r32995 | viettrungluu@chromium.org | 2009-11-25 00:22:23 +0100 (Wed, 25 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Mac: make bookmark bar drag buttons prettier.

(In particular, clip them to their rounded rectangle.)

BUG=28593
TEST=Drag bookmark bar buttons with a wide variety of themes; make sure edges/corners are correctly clipped from drag images.

Review URL: http://codereview.chromium.org/435028
------------------------------------------------------------------------
r32987 | aa@chromium.org | 2009-11-24 23:38:36 +0100 (Tue, 24 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Remove --enable-user-script and associated tests.

This doesn't remove the underlying support from
UserScriptMaster; that is a riskier change.

BUG=27520

Review URL: http://codereview.chromium.org/418043
------------------------------------------------------------------------
r32986 | johnnyg@chromium.org | 2009-11-24 23:36:33 +0100 (Tue, 24 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h

Stop opening _all_ notification location changes in a new tab.  That was allowing unwanted popups from a notification with script that sets window.location=foo. 

Instead override some RVHDelegate::View methods to allow popups to be blocked, and new-tab links to open in new tabs; now regular links will navigate the toast.  The view methods are implemented using the standard helper.

BUG=28015
TEST=none


Review URL: http://codereview.chromium.org/434041
------------------------------------------------------------------------
r32985 | tony@chromium.org | 2009-11-24 23:32:16 +0100 (Tue, 24 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc

Move some theme images to being serviced on the IO thread.  For
Linux Release builds on my machine, all the chrome://theme/ image
requests block for 300-400ms during browser startup (it's faster
after startup).  Something is blocking the UI thread so move
image requests that aren't themed off the UI thread.  This is
safe to do because ResourceBundle is thread safe.

I still see chrome://theme/theme_ntp_attribution and
chrome://theme/theme_ntp_background blocking so I will look
into those next (I think with the default theme, they shouldn't
be loaded at all).

Review URL: http://codereview.chromium.org/440009
------------------------------------------------------------------------
r32982 | xiyuan@chromium.org | 2009-11-24 23:22:51 +0100 (Tue, 24 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix app icon flicker in loading animation

The flicker is caused by setting window title icon while a loading
animation is in progress. Fix the problem by skipping window icon update
when loading animation is running.

BUG=15782
TEST=Verify no flicker while web app loads per Ben's comments.

Review URL: http://codereview.chromium.org/436028
------------------------------------------------------------------------
r32980 | andybons@chromium.org | 2009-11-24 23:14:51 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

o Updates the browser action buttons when a tab is changed. This is needed for tab-specific browser action buttons.
o If a tooltip is not present on a browser action button, clear the tooltip of the button.

BUG=28719
TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab.
Review URL: http://codereview.chromium.org/434047
------------------------------------------------------------------------
r32979 | johnnyg@chromium.org | 2009-11-24 23:10:49 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Make notifications permission available in the extension manifest and hook up to the desktop notification service.

BUG=27249
TEST=none

Review URL: http://codereview.chromium.org/432005
------------------------------------------------------------------------
r32977 | mattm@chromium.org | 2009-11-24 22:56:51 +0100 (Tue, 24 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix page action spacing on Linux.
Use the same constant for both Linux and Windows.

BUG=28660
TEST=load extensions, compare spacing

Review URL: http://codereview.chromium.org/440002
------------------------------------------------------------------------
r32975 | zork@chromium.org | 2009-11-24 22:46:36 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

Update the sync menu item to change on Linux to reflect the current sync state.

BUG=28209
TEST=Enable sync and sign in.  The "Sync my Bookmarks" label should now read "Bookmarks Synced..."

Review URL: http://codereview.chromium.org/431032
------------------------------------------------------------------------
r32968 | ager@chromium.org | 2009-11-24 21:50:03 +0100 (Tue, 24 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

Fix a flaky dev tools sanity test.

The test only works if the source of scripts are found in a specific
order.  This cannot be ensured since the source is found by traversing
the heap.  The scripts tab is only visible after processing the
debugger test page, so only check for visibility in that case.

Enable test on Linux again where it passes after this change.

TEST=none
BUG=26540
Review URL: http://codereview.chromium.org/434044
------------------------------------------------------------------------
r32966 | tony@chromium.org | 2009-11-24 21:42:08 +0100 (Tue, 24 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

fix build

TBR=arv

Review URL: http://codereview.chromium.org/431038
------------------------------------------------------------------------
r32965 | tony@chromium.org | 2009-11-24 21:35:59 +0100 (Tue, 24 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Merge in part of the last perf change.  Move when we initialize
the CSS/HTML for the NTP.  This should allow the history query
to happen sooner.

Move the first_view logic out of NewTabHTMLSource.  It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated.

Also make sure we only hang on to the original profile.  I think
the incognito profile can be deleted out from under us when the
last incognito window is closed.

Review URL: http://codereview.chromium.org/434038
------------------------------------------------------------------------
r32963 | sky@chromium.org | 2009-11-24 21:19:39 +0100 (Tue, 24 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc

Makes the nonclientframeview for popups on views/gtk draw
nothing. This is needed as we want the window manager rendering the
decorations.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/436026
------------------------------------------------------------------------
r32948 | zork@chromium.org | 2009-11-24 20:08:15 +0100 (Tue, 24 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/signal_thread_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/third_party/libjingle/README.chromium
   M /trunk/src/third_party/libjingle/files/talk/base/asynchttprequest.h
   M /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc
   M /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.h
   M /trunk/src/third_party/libjingle/files/talk/base/messagequeue.cc
   M /trunk/src/third_party/libjingle/files/talk/base/messagequeue.h
   M /trunk/src/third_party/libjingle/files/talk/base/signalthread.cc
   M /trunk/src/third_party/libjingle/files/talk/base/signalthread.h
   M /trunk/src/third_party/libjingle/files/talk/base/thread.cc
   M /trunk/src/third_party/libjingle/mods-since-v0_4_0.diff

Update Signal Thread to use ref counting and locks to ensure thread safety.

Review URL: http://codereview.chromium.org/418042
------------------------------------------------------------------------
r32942 | sky@chromium.org | 2009-11-24 19:30:46 +0100 (Tue, 24 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Disables default browser check and exit menu for toolkit_views on
chromeos.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/431029
------------------------------------------------------------------------
r32936 | sky@chromium.org | 2009-11-24 18:34:35 +0100 (Tue, 24 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Sets widget created by info bubbles to a custom type so that they
don't get a drop shadow and centered on screen.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/431021
------------------------------------------------------------------------
r32934 | avi@google.com | 2009-11-24 18:17:56 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/theme_install_bubble_view.mm
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc

Switch theme loading to use its own string.

BUG=http://crbug.com/24177
TEST=no visible change

Review URL: http://codereview.chromium.org/361006
------------------------------------------------------------------------
r32930 | viettrungluu@chromium.org | 2009-11-24 17:40:58 +0100 (Tue, 24 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Mac: improve hover/clicked state appearance of bookmark bar buttons.

I more or less implemented things as per discussion with Cole and Glen. (This
does not re-create the appearance on Win Chrome, which is not exactly right
either.)

BUG=28477
TEST=Load various themes (in particular, "Karim Rashid") and make sure bookmark bar buttons look good and legible in hover and pressed states.

Review URL: http://codereview.chromium.org/440001
------------------------------------------------------------------------
r32928 | erikkay@chromium.org | 2009-11-24 17:33:12 +0100 (Tue, 24 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc

disable extension toolstrips by default, adding
--enable-extension-toolstrips

BUG=24475
TEST=Extension*Toolstrip*

Review URL: http://codereview.chromium.org/434026
------------------------------------------------------------------------
r32925 | avi@google.com | 2009-11-24 16:20:31 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

Fix to prevent selecting a popup menu item from crashing when the item is auto-opened.

BUG=http://crbug.com/28215
TEST=as in bug

Review URL: http://codereview.chromium.org/431019
------------------------------------------------------------------------
r32919 | ukai@chromium.org | 2009-11-24 08:18:55 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/net/websockets/websocket.cc

Reduce DLOG in websocket code

BUG=28657
TEST=none

Review URL: http://codereview.chromium.org/440005
------------------------------------------------------------------------
r32918 | hayato@chromium.org | 2009-11-24 07:21:53 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/base/DEPS
   M /trunk/src/base/base.gyp
   A /trunk/src/base/base64.cc (from /trunk/src/net/base/base64.cc:32913)
   A /trunk/src/base/base64.h (from /trunk/src/net/base/base64.h:32913)
   A /trunk/src/base/base64_unittest.cc (from /trunk/src/net/base/base64_unittest.cc:32913)
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/extensions/convert_user_script.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/net/DEPS
   D /trunk/src/net/base/base64.cc
   D /trunk/src/net/base/base64.h
   D /trunk/src/net/base/base64_unittest.cc
   M /trunk/src/net/base/data_url.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/strict_transport_security_state.cc
   M /trunk/src/net/http/http_auth_handler_basic.cc
   M /trunk/src/net/http/http_auth_handler_ntlm.cc
   M /trunk/src/net/net.gyp

Move base64 from 'net/base' into 'base'.

BUG=13572
TEST=none

Review URL: http://codereview.chromium.org/399068
------------------------------------------------------------------------
r32914 | derat@chromium.org | 2009-11-24 05:18:51 +0100 (Tue, 24 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

gtk: Restore omnibox text selection on tab switch.

Tested by:
- highlighting omnibox text
- switching to a different tab
- highlighting some other text
- switching back to the first tab
- confirming that the omnibox highlighting was restored
  but PRIMARY didn't get updated when switching back

BUG=20674
TEST=see above

Review URL: http://codereview.chromium.org/440003
------------------------------------------------------------------------
r32906 | tony@chromium.org | 2009-11-24 03:46:42 +0100 (Tue, 24 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Revert "Move the NTP HTML generation to early so we can avoid an extra"

It caused New Tab Warm on Windows to regress to the speed before adding
the cache on Windows.

This reverts commit r32899.

TBR=arv

Review URL: http://codereview.chromium.org/431024
------------------------------------------------------------------------
r32905 | thestig@chromium.org | 2009-11-24 03:34:09 +0100 (Tue, 24 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/process_singleton_dialog.cc
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc

Linux: Create app modal dialogs in a different way to work around a KDE 3 window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows.

BUG=28230
TEST=see bug
Review URL: http://codereview.chromium.org/425016
------------------------------------------------------------------------
r32904 | nick@chromium.org | 2009-11-24 03:24:12 +0100 (Tue, 24 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc

Remove a TODO in post_commit_command.cc.  Clarify what's going on.

Review URL: http://codereview.chromium.org/431023
------------------------------------------------------------------------
r32899 | tony@chromium.org | 2009-11-24 02:32:22 +0100 (Tue, 24 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Move the NTP HTML generation to early so we can avoid an extra
trip to the UI thread later.  Not sure if this will make a
difference.

Move the NTP and CSS handler init to after adding the MostVistedHandler.
This should allow an earlier db fetch for the cases when the HTML/CSS
are not in the cache (e.g., browser startup).

Review URL: http://codereview.chromium.org/439013
------------------------------------------------------------------------
r32898 | andybons@chromium.org | 2009-11-24 02:28:41 +0100 (Tue, 24 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h

Fixes extension packing codepath that was hitting a race condition DCHECK described in http://crbug.com/27944.
BUG=28530
TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash.
Review URL: http://codereview.chromium.org/436008
------------------------------------------------------------------------
r32896 | ananta@chromium.org | 2009-11-24 02:21:35 +0100 (Tue, 24 Nov 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/chrome_frame/urlmon_url_request.h
   M /trunk/src/net/http/http_response_headers.cc
   M /trunk/src/net/http/http_response_headers.h

ChromeFrame's host network stack implementation for IE full tab mode implicitly follows redirects.
When Chrome receives a notification about a redirect it also attempts to follow the redirect request. While
this works in most cases, some sites actually returned an error for the second request initiated by Chrome.

Fix is to abort the request in urlmon, when we receive a notification about a redirect. I also fixed the
IsRedirectResponse function in the UrlRequestAutomationJob class to only treat 301, 302, 303 and 307 as 
redirect codes on the same lines as the default http job.

Test=covered by existing network tests.

I also verified that http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL.

Fixes http://code.google.com/p/chromium/issues/detail?id=28296

Bug=28296


Review URL: http://codereview.chromium.org/402107
------------------------------------------------------------------------
r32894 | munjal@chromium.org | 2009-11-24 02:10:35 +0100 (Tue, 24 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/protocol/service_constants.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   D /trunk/src/chrome/browser/sync/util/character_set_converters.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   D /trunk/src/chrome/browser/sync/util/character_set_converters_unittest.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.h
   M /trunk/src/chrome/browser/sync/util/sync_types.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_syncable_utils.cc
   M /trunk/src/chrome/test/sync/engine/test_syncable_utils.h

Final part of PathString cleanup.

BUG=26342
TEST+exist

Review URL: http://codereview.chromium.org/429003
------------------------------------------------------------------------
r32892 | akalin@chromium.org | 2009-11-24 01:55:35 +0100 (Tue, 24 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_cppsafe.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   A /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac.h
   A /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac.mm
   A /trunk/src/chrome/browser/sync/sync_status_ui_helper_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Added main menu item for Sync in OS X. (Right below "Preferences...").  Made it work without a browser window being present.

Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}.

BUG=27995
TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in.

Review URL: http://codereview.chromium.org/423004
------------------------------------------------------------------------
r32889 | rafaelw@chromium.org | 2009-11-24 01:19:54 +0100 (Tue, 24 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Fix crash when an extension popup shows a JS alert. Showing the alert takes...

Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show.

Disable showing JS alerts from popups, because doing so makes the popup
disappear immediately, which has all sorts of unfortunate side effects for the
poor orphaned alert (see bug for details).

BUG=27758
TEST=create extension with popup, put link with |onclick="alert('test');"| in
it; install extension, open popup, and click link; see no crash (nor popup)

Review URL: http://codereview.chromium.org/435010
------------------------------------------------------------------------
r32887 | estade@chromium.org | 2009-11-24 00:45:41 +0100 (Tue, 24 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/page_info_model.cc

page info dialog polish:

GTK:
- set default size of contents, rather than window as a whole---this gets line wrapping right.
All:
- change title string to Title Case instead of Sentence case
- fix Connection text for mixed/unsafe content

BUG=28507

Review URL: http://codereview.chromium.org/437026
------------------------------------------------------------------------
r32885 | tony@chromium.org | 2009-11-24 00:25:17 +0100 (Tue, 24 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Remove ResourceBundle::LoadImageResourceBytes since it appears to
be identical to LoadDataResourceBytes.  Migrate callers to
LoadDataResourceBytes.

Review URL: http://codereview.chromium.org/437019
------------------------------------------------------------------------
r32880 | akalin@chromium.org | 2009-11-23 23:48:43 +0100 (Mon, 23 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h

Moved common OpenSyncMyBookmarksDialog() code into SyncStatusUIHelper.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/414064
------------------------------------------------------------------------
r32866 | ananta@chromium.org | 2009-11-23 23:16:52 +0100 (Mon, 23 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc

Marking the ExtensionApiTest.ExecuteScript test as flaky as it failed for no apparent reason
on the vista dbg builder. 

Issue http://code.google.com/p/chromium/issues/detail?id=28630 has been logged to track this.

TBR=aa
Bug=28630


Review URL: http://codereview.chromium.org/432010
------------------------------------------------------------------------
r32854 | jam@chromium.org | 2009-11-23 22:26:47 +0100 (Mon, 23 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc

Fix environment variables not being used after switching to ChildProcessLauncher.

BUG=28602
TEST=verified flash works on Mac
Review URL: http://codereview.chromium.org/439005
------------------------------------------------------------------------
r32853 | asargent@chromium.org | 2009-11-23 22:24:48 +0100 (Mon, 23 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Make extension updates use omaha id when talking to omaha.

BUG=b/2168147
TEST=Extensions auto-updates should still work.


Review URL: http://codereview.chromium.org/403026
------------------------------------------------------------------------
r32851 | akalin@chromium.org | 2009-11-23 22:20:07 +0100 (Mon, 23 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm

Removed browser owned by HtmlDialogWindowController.  This fixes the crash
described in issue 28329.

Use a non-incognito profile for HTML dialogs and any links launched
from them.  This diverges from the behavior on Windows, but according
to beng this is okay.

Made it so that HTML dialog boxes don't keep history.

BUG=28329
TEST=made sure there is no crash when closing the browser with the sync
setup wizard open

Review URL: http://codereview.chromium.org/416004
------------------------------------------------------------------------
r32849 | phajdan.jr@chromium.org | 2009-11-23 21:47:28 +0100 (Mon, 23 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Mark all ErrorPage tests as FLAKY.

It's a race condition which used to manifest more
frequently on XP, but in fact it exists on all platforms.
People started adding even more #ifdefs and things
when tests failed on Linux too, so let's just say
they're all flaky. :-(

TEST=none
BUG=22877

Review URL: http://codereview.chromium.org/437016
------------------------------------------------------------------------
r32846 | michaeln@google.com | 2009-11-23 21:40:57 +0100 (Mon, 23 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/appcache/chrome_appcache_service.cc
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.h
   A /trunk/src/webkit/appcache/appcache_thread.cc
   A /trunk/src/webkit/appcache/appcache_thread.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.h
   M /trunk/src/webkit/webkit.gyp

The appcache system uses two threads, an IO thread and a DB thread.
It does not create these threads, the embedder is responsible for
providing them to the appcache library by implementing the class
declared in appcache_thread.h.

Also in this CL are two implementations, one for Chrome and another for test_shell.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/409005
------------------------------------------------------------------------
r32844 | estade@chromium.org | 2009-11-23 21:38:38 +0100 (Mon, 23 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   D /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   D /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   A /trunk/src/chrome/browser/tab_contents/web_drag_source_win.cc (from /trunk/src/chrome/browser/tab_contents/web_drag_source.cc:32647)
   A /trunk/src/chrome/browser/tab_contents/web_drag_source_win.h (from /trunk/src/chrome/browser/tab_contents/web_drag_source.h:32647)
   D /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   D /trunk/src/chrome/browser/tab_contents/web_drop_target.h
   A /trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc (from /trunk/src/chrome/browser/tab_contents/web_drop_target.cc:32647)
   A /trunk/src/chrome/browser/tab_contents/web_drop_target_win.h (from /trunk/src/chrome/browser/tab_contents/web_drop_target.h:32647)
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc

Assorted cleanup.

process: grep for TODO(port), find cruft, clean it up

Review URL: http://codereview.chromium.org/427004
------------------------------------------------------------------------
r32840 | estade@chromium.org | 2009-11-23 21:28:54 +0100 (Mon, 23 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/common/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc

Add platform abstraction for simple error box, and use it in a couple extensions-related places.

Also add a virtual destructor in some unrelated infobar.

BUG=27691

Review URL: http://codereview.chromium.org/427002
------------------------------------------------------------------------
r32834 | jhawkins@chromium.org | 2009-11-23 20:47:41 +0100 (Mon, 23 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc

Add a label member to the FormField class.  This member will hold the value of the field's label once we parse this value from the DOM.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418032
------------------------------------------------------------------------
r32832 | jam@chromium.org | 2009-11-23 20:42:33 +0100 (Mon, 23 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h

Fix bug when accessing g_browser_process->broker_services() at shutdown.

BUG=28501
Review URL: http://codereview.chromium.org/435001
------------------------------------------------------------------------
r32829 | ian@chromium.org | 2009-11-23 20:41:34 +0100 (Mon, 23 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model.cc

Fixing GCC 4.4 build fix (landing a patch for hbono)

This patch was written by hbono, landing for him as he can't
land this until tomorrow, and it's a patch to fix a build.

Reviewed at http://codereview.chromium.org/414025

BUG=none
TEST=GCC 4.4 compiles

Review URL: http://codereview.chromium.org/436003
------------------------------------------------------------------------
r32828 | estade@chromium.org | 2009-11-23 20:41:00 +0100 (Mon, 23 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

GTK: Set initial size for js alert.

BUG=28058

Review URL: http://codereview.chromium.org/426008
------------------------------------------------------------------------
r32827 | estade@chromium.org | 2009-11-23 20:40:48 +0100 (Mon, 23 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_gtk.cc

GTK: don't dereference stale ConstrainedWindow pointer.

BUG=28587

Review URL: http://codereview.chromium.org/436004
------------------------------------------------------------------------
r32825 | jcampan@chromium.org | 2009-11-23 20:39:55 +0100 (Mon, 23 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Default browser checking on start-up was broken.
ShellIntegration::IsDefaultBrowser() had been changed to return an enum instead of a bool.
But the code in browser_init.cc calling it has not been updated.

BUG=28429
TEST=Test that the default browser infobar is shown when Chrome is started and not the default browser.

Review URL: http://codereview.chromium.org/426009
------------------------------------------------------------------------
r32824 | jcampan@chromium.org | 2009-11-23 20:39:16 +0100 (Mon, 23 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

Adding some missing accelerators to Linux toolkit views.

BUG=28416
TEST=Tests all the accelerators found in chrome/browser/views/accelerator_table_gtk.cc work and are consistent Chrome on Windows.
Review URL: http://codereview.chromium.org/426006
------------------------------------------------------------------------
r32820 | mirandac@chromium.org | 2009-11-23 20:02:31 +0100 (Mon, 23 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc

Add locale as a parameter to the extension link.

BUG= 28433
TEST= click on puzzle piece and promo line "extension" links; chrome UI language should be included as a parameter in the link.

Review URL: http://codereview.chromium.org/434002
------------------------------------------------------------------------
r32818 | oshima@chromium.org | 2009-11-23 19:57:26 +0100 (Mon, 23 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Adjust the position of the frame background image for ChromeOS to match gtk build.
Gtk build is using non custom frame mode, which renders the frmae pixels
15 pixels above. I'll remove this hack once we migrate to views.

BUG=28580
TEST=None

Review URL: http://codereview.chromium.org/434011
------------------------------------------------------------------------
r32817 | kuchhal@chromium.org | 2009-11-23 19:53:52 +0100 (Mon, 23 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/delete_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/helper.cc
   M /trunk/src/chrome/installer/util/helper.h
   M /trunk/src/chrome/installer/util/helper_unittest.cc
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/move_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/work_item.cc
   M /trunk/src/chrome/installer/util/work_item.h
   M /trunk/src/chrome/installer/util/work_item_list.cc
   M /trunk/src/chrome/installer/util/work_item_list.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc

Revert "installer: clean up to use FilePath instead of std::wstring."

This reverts commit 9da05365beb211e3879e6049547e5e92c4c0a5a2 (r32811).

TBR=thiago.farina@gmail.com
BUG=32811

Review URL: http://codereview.chromium.org/437011
------------------------------------------------------------------------
r32816 | eroman@chromium.org | 2009-11-23 19:34:55 +0100 (Mon, 23 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/net/base/host_resolver.h

Some small comment fixes for HostResolver and DnsMaster.

Original patch by cbentzel@google.com (see http://codereview.chromium.org/437005)

r=me
BUG=NONE

Review URL: http://codereview.chromium.org/437009
------------------------------------------------------------------------
r32815 | tony@chromium.org | 2009-11-23 19:31:25 +0100 (Mon, 23 Nov 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Take 2 at moving NTP CSS resources into the NTP resource cache.

Moving the HTML to the cache saved 8ms on New Tab Warm on Windows,
maybe we can shave a few more ms off by moving the CSS.

The last change had a regression on the mac new tab perf, so I suspect
it's the extra round trip to the UI thread when trying to load the CSS
(the UI thread is probably just busy at that time).  Instead, I'm moving
the generation of the CSS to the time the object is constructed, rather
than when the resource is requested.  This is like the code before,
except sometimes we'll hit the cache.

BUG=26228

Review URL: http://codereview.chromium.org/427003
------------------------------------------------------------------------
r32814 | mrossetti@chromium.org | 2009-11-23 19:29:58 +0100 (Mon, 23 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Improve unit test robustness.

BUG=28405
TEST=none

Review URL: http://codereview.chromium.org/425007
------------------------------------------------------------------------
r32811 | kuchhal@chromium.org | 2009-11-23 19:10:13 +0100 (Mon, 23 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/delete_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/helper.cc
   M /trunk/src/chrome/installer/util/helper.h
   M /trunk/src/chrome/installer/util/helper_unittest.cc
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/move_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/work_item.cc
   M /trunk/src/chrome/installer/util/work_item.h
   M /trunk/src/chrome/installer/util/work_item_list.cc
   M /trunk/src/chrome/installer/util/work_item_list.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc

installer: clean up to use FilePath instead of std::wstring.

BUG=24672
TEST=installer_util_unittests and setup_unittests

Review URL: http://codereview.chromium.org/385129
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r32810 | sky@chromium.org | 2009-11-23 19:08:18 +0100 (Mon, 23 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Adjusts font sizes to be readable on Chrome OS.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/434010
------------------------------------------------------------------------
r32808 | avi@google.com | 2009-11-23 18:57:54 +0100 (Mon, 23 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_util_mac.mm

Call FNNotify on download complete; this should help apps watching the downloads folder.

BUG=none
TEST=If Transmission is watching the Downloads folder, it should catch a completed download immediately.


Review URL: http://codereview.chromium.org/437006
------------------------------------------------------------------------
r32804 | kkania@chromium.org | 2009-11-23 18:46:53 +0100 (Mon, 23 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Allow reentrant tasks on window close in in-proc browser test framework.  Disable tests that are failing on Mac.
BUG=none
TEST=none 
Review URL: http://codereview.chromium.org/425013
------------------------------------------------------------------------
r32803 | pfeldman@chromium.org | 2009-11-23 16:31:57 +0100 (Mon, 23 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

DevTools: Add UMA entry for inspect element action.
BUG=28563

Review URL: http://codereview.chromium.org/431009
------------------------------------------------------------------------
r32792 | viettrungluu@chromium.org | 2009-11-22 21:57:06 +0100 (Sun, 22 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm

Mac: fix toolbar sizing bug upon unloading extension/theme.

BUG=28476
TEST=Install any theme (e.g., "Classic"); click "undo" in infobar; toolbar layout shouldn't change (and the toolbar's contents should be sized correctly).

Review URL: http://codereview.chromium.org/418048
------------------------------------------------------------------------
r32789 | derat@chromium.org | 2009-11-22 19:41:23 +0100 (Sun, 22 Nov 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

gtk: Get rid of status bubble flicker.

The bubble was appearing in its default location
when getting shown while the mouse was nearby; it
would move to the correct location on the next
motion event.

I think that there's still a flicker in the wrong
location when closing the download bar and then
triggering the bubble, but the fix is non-obvious
to me.  It's possible that it's not noticeable on
anything faster than the slow DSL line that I'm
using to run Chrome remotely to test this.

BUG=28494
TEST=repeated steps from bug and checked that download bar behavior doesn't appear to have regressed either

Review URL: http://codereview.chromium.org/431007
------------------------------------------------------------------------
r32779 | viettrungluu@chromium.org | 2009-11-22 08:04:10 +0100 (Sun, 22 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Mac: minor cleanup of constants in toolbar_controller.mm.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/418049
------------------------------------------------------------------------
r32772 | evan@chromium.org | 2009-11-22 03:59:10 +0100 (Sun, 22 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h

build fix: missing include

Not exactly sure why this was compiling for some people before.
------------------------------------------------------------------------
r32770 | aa@chromium.org | 2009-11-22 03:25:04 +0100 (Sun, 22 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/static/content_scripts.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Preferences
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ahbojlbmpfcbogfblmekncilheldhjga/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/coomonpcecmahbfkifeohkbgicpcfdgf/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/dhminefdpfgdedodgdilagiencggdcpm/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/kgfhjcinicjnlcbnbacbkbjdbafnlckn/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ledhkldokbafdcbmepdigjmkabmombel/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/lgmapeiimomfdbfphldobhhpoaoafaci/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/maemolkcfjifpmigoecmpfphmebnebpk/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/mdeggakgacjccnbfbhbihfchoidihkaf/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/mgonfebmjopdoipblbijejncibmgmcol/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ohmmlgjlmaadhojogadklhlidfpdeoca/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc

Revert change that disallowed content scripts access to
file:// URLs. It turns out teams were already depending on
this and we didn't want to break them.

Instead, group file:// access with NPAPI in the extension
install prompt.

Note: this is a pure revert of r402029 and r402069 (sorry
Finnur!) except the changes in extension_install_ui.cc,
which are new.

BUG=28456

Review URL: http://codereview.chromium.org/430003
------------------------------------------------------------------------
r32766 | mdm@chromium.org | 2009-11-22 02:13:47 +0100 (Sun, 22 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Put the --type switch back as the first for renderers, for easy identification.
BUG=28421
TEST=run ps auxw, see that --type is the first switch to renderer processes

Review URL: http://codereview.chromium.org/414071
------------------------------------------------------------------------
r32759 | mirandac@chromium.org | 2009-11-21 23:00:31 +0100 (Sat, 21 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h

Remove old bookmark sync promo from new tab page. 

Part 2: to be merged into 249.

BUG=28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP. 

Review URL: http://codereview.chromium.org/414076
------------------------------------------------------------------------
r32756 | mirandac@chromium.org | 2009-11-21 22:48:53 +0100 (Sat, 21 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h

Revert 32754 - Remove old bookmark sync promo from new tab page.

BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.

Review URL: http://codereview.chromium.org/420004

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/414075
------------------------------------------------------------------------
r32754 | mirandac@chromium.org | 2009-11-21 22:43:17 +0100 (Sat, 21 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h

Remove old bookmark sync promo from new tab page.

BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.

Review URL: http://codereview.chromium.org/420004
------------------------------------------------------------------------
r32750 | jam@chromium.org | 2009-11-21 21:32:30 +0100 (Sat, 21 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc
   M /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/worker/worker_uitest.cc

Launch all child processes asynchronously so as not to block the IO thread.

BUG=6844, 27935
Review URL: http://codereview.chromium.org/402097
------------------------------------------------------------------------
r32739 | ananta@chromium.org | 2009-11-21 09:43:39 +0100 (Sat, 21 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/chrome_frame/test/net/test_automation_provider.cc
   M /trunk/src/chrome_frame/test/net/test_automation_provider.h

Tommi, please review everything. John please review the changes to plugin_service.cc/.h

The test automation provider registers itself as a protocol factory for http/https requests. This 
is to ensure that intercepts set by the url request network tests work correctly. I was seeing these
tests fail consistently on my setup as their intercept function would never get called.

The other change is to add a simple mechanism based on a boolean flag to disable browser side plugins
like gears which also intercept network requests and expect to be called on the IO thread. The chrome 
frame network tests run in a relatively simple environment where the network tests run in a separate thread
(not the IO thread) which causes a number of DCHECKS to fire in debug build test runs. The flag used to
determine whether browser plugins are loaded defaults to true.

Review URL: http://codereview.chromium.org/414017
------------------------------------------------------------------------
r32738 | thakis@chromium.org | 2009-11-21 08:44:29 +0100 (Sat, 21 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Mac: Implement profile error dialog.

The "active window" change was done for linux in http://codereview.chromium.org/147091 and might fix other problems too. Without this, BrowserList::GetLastActive() returns NULL in  Browser::Observe(), which caused the new function not to be called.

It looks something like http://imgur.com/6PHQm .

BUG=26377
TEST=
chmod -r ~/Library/Application\ Support/Chromium/Default/History*
Then start chromium (release build, so that we survive some sqlite dchecks) and make sure it displays an error message (then chmod +r again)

Review URL: http://codereview.chromium.org/418040
------------------------------------------------------------------------
r32733 | tim@chromium.org | 2009-11-21 05:02:03 +0100 (Sat, 21 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Mark Page404_GoBack as flaky on linux

TBR=phajdan.jr
BUG=19361
TEST=ErrorPageTest

Review URL: http://codereview.chromium.org/426011
------------------------------------------------------------------------
r32732 | tim@chromium.org | 2009-11-21 04:29:52 +0100 (Sat, 21 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.h
   D /trunk/src/chrome/browser/sync/engine/client_command_channel.h
   D /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.cc
   D /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.cc
   M /trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.h
   D /trunk/src/chrome/browser/sync/engine/sync_cycle_state.h
   D /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   D /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   D /trunk/src/chrome/browser/sync/engine/syncer_session.h
   D /trunk/src/chrome/browser/sync/engine/syncer_status.cc
   D /trunk/src/chrome/browser/sync/engine/syncer_status.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.h
   A /trunk/src/chrome/browser/sync/sessions
   A /trunk/src/chrome/browser/sync/sessions/session_state.cc
   A /trunk/src/chrome/browser/sync/sessions/session_state.h
   A /trunk/src/chrome/browser/sync/sessions/status_controller.cc
   A /trunk/src/chrome/browser/sync/sessions/status_controller.h
   A /trunk/src/chrome/browser/sync/sessions/status_controller_unittest.cc
   A /trunk/src/chrome/browser/sync/sessions/sync_session.cc
   A /trunk/src/chrome/browser/sync/sessions/sync_session.h
   A /trunk/src/chrome/browser/sync/sessions/sync_session_context.h
   A /trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/blob.h
   M /trunk/src/chrome/chrome.gyp

Add browser_sync 'sessions' to relieve SyncCycleState, SyncProcessState, SyncerSession,
SyncerStatus, and ConflictResolutionView of duty.
Main impact is factors all status munging to 'StatusController', adds SyncSessionContext
to wrap various engine parts needed by different components, removes duplicated methods by a
factor of ~3 making it easier to reason about, and adds a 'Controller' to the session object to
give a way to delegate session-global (i.e affecting any session) occurrences such as throttling.

Also adds testing for 'HasMoreToSync' and other session related code.

BUG=25266
TEST=SyncSessionTest(added), StatusControllerTest(added)
     various sync_unit_tests in this CL

Review URL: http://codereview.chromium.org/386030
------------------------------------------------------------------------
r32730 | viettrungluu@chromium.org | 2009-11-21 03:53:08 +0100 (Sat, 21 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_info_snapshot_mac.cc

Mac: fix error message which mentions top instead of ps.

BUG=28357
TEST=none (unless you feel like mocking /bin/ps)

Review URL: http://codereview.chromium.org/426010
------------------------------------------------------------------------
r32728 | akalin@chromium.org | 2009-11-21 03:46:12 +0100 (Sat, 21 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Revert 32727 - Disable sync. (Will be committed on beta branch only, and this CL will be immediately reverted.)

BUG=26712
TEST=trybot

Review URL: http://codereview.chromium.org/425015

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/414069
------------------------------------------------------------------------
r32727 | akalin@chromium.org | 2009-11-21 03:44:21 +0100 (Sat, 21 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Disable sync. (Will be committed on beta branch only, and this CL will be immediately reverted.)

BUG=26712
TEST=trybot

Review URL: http://codereview.chromium.org/425015
------------------------------------------------------------------------
r32722 | evan@chromium.org | 2009-11-21 02:29:00 +0100 (Sat, 21 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base_paths.h
   D /trunk/src/base/base_paths_linux.cc
   D /trunk/src/base/base_paths_linux.h
   M /trunk/src/base/base_paths_mac.h
   A /trunk/src/base/base_paths_posix.cc (from /trunk/src/base/base_paths_linux.cc:32718)
   M /trunk/src/base/base_paths_win.h
   M /trunk/src/base/path_service.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

posix: refactor duplicated path-handling code

We had the same code in three headers, and an "if FREEBSD" in a
_linux.cc file.

Review URL: http://codereview.chromium.org/414063
------------------------------------------------------------------------
r32716 | jhawkins@chromium.org | 2009-11-21 01:22:01 +0100 (Sat, 21 Nov 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill/autofill_type.cc
   A /trunk/src/chrome/browser/autofill/autofill_type.h
   M /trunk/src/chrome/chrome.gyp

Implement AutoFillType, the high-level description of AutoFill types.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418026
------------------------------------------------------------------------
r32708 | pkasting@chromium.org | 2009-11-21 00:16:26 +0100 (Sat, 21 Nov 2009) | 7 lines
Changed paths:
   A /trunk/src/base/auto_reset.h (from /trunk/src/base/scoped_bool.h:32572)
   M /trunk/src/base/base.gyp
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/ref_counted.cc
   D /trunk/src/base/scoped_bool.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/ipc/ipc_channel_posix.cc
   M /trunk/src/ipc/ipc_channel_posix.h
   M /trunk/src/ipc/ipc_channel_win.cc
   M /trunk/src/views/focus/focus_util_win.cc
   M /trunk/src/views/widget/widget_gtk.cc

Use AutoReset (formerly ScopedBool) where possible.

This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399096
------------------------------------------------------------------------
r32706 | jamesr@chromium.org | 2009-11-21 00:14:23 +0100 (Sat, 21 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/base/ref_counted.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/webkit/appcache/mock_appcache_storage.cc

Forces T*s to scoped_refptr<T> when PostTask()ing to a function expecting scoped_refptr<T>

Review URL: http://codereview.chromium.org/418007
------------------------------------------------------------------------
r32705 | finnur@chromium.org | 2009-11-21 00:13:21 +0100 (Sat, 21 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   A /trunk/src/chrome/test/data/find_in_page/simple.html

When you search for something, press F3, close the box and press F3 it would only open the Find box and not issue the search. This is because we set the prepopulate string to find_text and not find_text_ (the former is blank on F3). I have also changed the variable name to prevent this kind of confusion in the future.

BUG=28306
TEST=Automated test added.
Review URL: http://codereview.chromium.org/425003
------------------------------------------------------------------------
r32702 | estade@chromium.org | 2009-11-21 00:10:56 +0100 (Sat, 21 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc

Properly report blacklisted extension errors (currently, blacklisted extensions don't send an install error notification, so the loading bubble persists forever).

BUG=none
TEST=install a blacklisted extension

Review URL: http://codereview.chromium.org/418031
------------------------------------------------------------------------
r32701 | hawk@chromium.org | 2009-11-21 00:08:38 +0100 (Sat, 21 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc

Don't do work in the SharedIOBuffer constructor; use an Init method instead. This eliminates instances of allocated-but-invalid SharedIOBuffers. Also clean up some CHECKs and TODOs associated with the bug.

The upshot is that we no longer crash in AsyncResourceHandler::OnResponseCompleted() when we can't allocate shared memory. We now crash (properly, I believe) in the renderer process if the shared memory that failed to allocate was the TransportDIB, since the renderer can't communicate with the browser without it.

BUG=16371
TEST=none 
Review URL: http://codereview.chromium.org/391009
------------------------------------------------------------------------
r32698 | dumi@chromium.org | 2009-11-20 23:42:53 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Turn on HTML5 DBs by default.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/414048
------------------------------------------------------------------------
r32697 | akalin@chromium.org | 2009-11-20 23:41:00 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/hung_renderer_dialog.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc

Replaced HungRendererDialog class with hung_renderer_dialog namespace.

BUG=
TEST=trybots

Review URL: http://codereview.chromium.org/415006
------------------------------------------------------------------------
r32696 | jcampan@chromium.org | 2009-11-20 23:40:11 +0100 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Ensures the renderer gets focus/blur message when switching tabs.

BUG=26610
TEST=Open a page in a teb that prints out when the window object gets focused
    blured. Switch to another tab then come back to that tab. A blur and focus
    events should have been fired.

Review URL: http://codereview.chromium.org/402091
------------------------------------------------------------------------
r32693 | mrossetti@chromium.org | 2009-11-20 23:35:58 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm

Allow folders to be created with empty names.

BUG=28318
TEST=Bring up the Add Folder sheet by choosing Add Folder... from the contextual menu.  The OK button should always be active.  Click OK and a new, unnamed folder should be added.

Review URL: http://codereview.chromium.org/414055
------------------------------------------------------------------------
r32690 | jrg@chromium.org | 2009-11-20 23:33:14 +0100 (Fri, 20 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm

Apply theme color to bookmark button text.

BUG=http://crbug.com/17608

TEST=Add some bookmarks (you must use both folders and marks).  Apply
a theme and make sure theme color applies bookmark button text for all
buttons (including "Other bookmarks").  Create new window and make
sure bookmark buttons still fine in new window.  Quit and restart
Chrome.  Make sure theme color still applied to bookmark button text
in the same way as before quitting (e.g. same color and still applies
to all).  Change theme 1 more time and verify color.

Review URL: http://codereview.chromium.org/424004
------------------------------------------------------------------------
r32687 | ananta@chromium.org | 2009-11-20 23:18:45 +0100 (Fri, 20 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Revert 32608 - RESUBMIT of http://src.chromium.org/viewvc/chrome?view=rev&revision=32319 with unit test fixes.

Reverting this as this caused a number of valgrind test failures.

Make the WebKitThread object start the WebKit thread on construction (not lazily).

NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.

TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.

TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144

Review URL: http://codereview.chromium.org/404025

TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/427001
------------------------------------------------------------------------
r32686 | sky@chromium.org | 2009-11-20 23:07:11 +0100 (Fri, 20 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/widget_gtk.cc

Fixes two issues from valgrind, and some cleanup:
. Makes it so observer installed by WidgetGtk is cleaned up and not
  leaked.
. Removes unnecessary static_cast<int> in view.
. Fixes some leaks in textfield and button.
. Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/420005
------------------------------------------------------------------------
r32681 | mrossetti@chromium.org | 2009-11-20 22:55:53 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Change popup construction logic so that folders with empty name is no longer used for excluding the root node from display, rather, user is_root() for that purpose.  A folder with an empty name is now shown as a blank line in the popup.

BUG=28313
TEST=Create a new folder with a blank name and add an URL to that folder. Select the new bookmark. Bring up the bubble and click either 'Edit' or 'Close'. It should not crash at this point.  Also, click on the popup and a blank line should appear representing the newly created folder.

Review URL: http://codereview.chromium.org/418027
------------------------------------------------------------------------
r32677 | viettrungluu@chromium.org | 2009-11-20 22:48:02 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/memory_details.h

Fix DCHECK() failure when about:memory used.

BUG=28358
TEST=On a debug build (on any platform), go to about:memory and make sure it doesn't fail a DCHECK().

Review URL: http://codereview.chromium.org/418022
------------------------------------------------------------------------
r32675 | tony@chromium.org | 2009-11-20 22:43:07 +0100 (Fri, 20 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Revert "Move NTP CSS resources into the NTP resource cache." because it slowed down NTP on mac.

This reverts commit r32649.

Review URL: http://codereview.chromium.org/425004
------------------------------------------------------------------------
r32658 | estade@chromium.org | 2009-11-20 21:35:39 +0100 (Fri, 20 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

GTK: Don't fail on startup with debug build.

I thought the check would never fail, but I found out how to trigger it, so it turns out to be necessary after all.

TBR=derat

Review URL: http://codereview.chromium.org/421011
------------------------------------------------------------------------
r32655 | tim@chromium.org | 2009-11-20 21:23:44 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Disable another part of RDH test due to tsan race condition.

TBR=ananta
BUG=28364

Review URL: http://codereview.chromium.org/418020
------------------------------------------------------------------------
r32653 | akalin@chromium.org | 2009-11-20 21:05:09 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm

Fixed and clarified comments in html_dialog_window_controller.mm.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/414008
------------------------------------------------------------------------
r32649 | tony@chromium.org | 2009-11-20 21:00:53 +0100 (Fri, 20 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Move NTP CSS resources into the NTP resource cache.

Moving the HTML to the cache saved 8ms on New Tab Warm on Windows,
maybe we can shave a few more ms off by moving the CSS.

http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150

After this change, I'm going to try to do some cleanup to merge
NewTabHTMLSource into DOMUIThemeSource since these classes are both
quite small now.

BUG=26228

Review URL: http://codereview.chromium.org/413004
------------------------------------------------------------------------
r32645 | estade@chromium.org | 2009-11-20 20:37:19 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Gtk: don't occlude find bar with animating infobar.

BUG=none
TEST=type g in location bar, press ctrl+f, wait for did you mean infobar. it should be below the findbar.

Review URL: http://codereview.chromium.org/418005
------------------------------------------------------------------------
r32644 | rafaelw@chromium.org | 2009-11-20 20:35:47 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc

ExtensionInstalledBubble border/sizing polish

BUG=27921
TEST=None

Review URL: http://codereview.chromium.org/413005
------------------------------------------------------------------------
r32643 | erg@google.com | 2009-11-20 20:31:38 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_unittest.cc

- Start adding unit tests for the BrowserThemeProvider rewrite.
- Fix overflow error in colors.

BUG=21121

Review URL: http://codereview.chromium.org/414041
------------------------------------------------------------------------
r32634 | tangjie@chromium.org | 2009-11-20 19:27:20 +0100 (Fri, 20 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame0.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame1.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame2.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/frame3.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/script.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript_in_frame/test_executescript.html

Make executeScript and insertCSS inject code into all frames.
Patched from 401007(see http://codereview.chromium.org/401007/) to commit. Reviewed by aa and darin.
R=aa,darin
Review URL: http://codereview.chromium.org/421005
------------------------------------------------------------------------
r32631 | amanda@chromium.org | 2009-11-20 19:26:16 +0100 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Mac: Simulate the OS-level focus handling that windows and linux plugins
rely on to trigger NPAPI keyboard focus notifications.
BUG=26585
TEST=On pages with multiple Flash text entry fields, only one should have
a blinking caret at any time.  Flash elements that use the ActionScript2
"Key.IsDown()" function should only detect keydowns when they are in a
visible tab and focused.
Review URL: http://codereview.chromium.org/399090
------------------------------------------------------------------------
r32623 | tim@chromium.org | 2009-11-20 18:49:03 +0100 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Disable two tests causing valgrind issues from revision 32608.

TBR=jorlow

TEST=ResourceDispatcherHostTest
BUG=28364

Review URL: http://codereview.chromium.org/414040
------------------------------------------------------------------------
r32619 | mirandac@chromium.org | 2009-11-20 18:20:00 +0100 (Fri, 20 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

More tweaks and fixes for extension and bookmark sync promo.  

Make bookmark sync link start up the sync process.  Make the message more aesthetically pleasing. 
Improve the overall layout of the message; ensure it doesn't overlap the NTP content. Also add a border to the notification line so that it matches the promo line in appearance, and stands out against themes of all colors.


BUG= 27853, 28047
TEST= start chrome, click on "bookmark sync" in promo message on NTP. chrome should start up the bookmark sync process.
Review URL: http://codereview.chromium.org/402021
------------------------------------------------------------------------
r32616 | erikkay@chromium.org | 2009-11-20 17:42:50 +0100 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   A /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/background.html
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/manifest.json
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/mappy_content_script.js
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/marker.png
   M /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/popup.html

Fix window.close() for page action popups.
Convert mappy to a page action popup.
Also fix a bug where disabling an extension with a page action didn't cause the icon to hide.

BUG=27519
TEST=none

Review URL: http://codereview.chromium.org/414019
------------------------------------------------------------------------
r32608 | jorlow@chromium.org | 2009-11-20 14:04:11 +0100 (Fri, 20 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

RESUBMIT of http://src.chromium.org/viewvc/chrome?view=rev&revision=32319 with unit test fixes.

Make the WebKitThread object start the WebKit thread on construction (not lazily).

NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.

TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.

TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144

Review URL: http://codereview.chromium.org/404025
------------------------------------------------------------------------
r32600 | evan@chromium.org | 2009-11-20 07:53:28 +0100 (Fri, 20 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/base/compiler_specific.h
   M /trunk/src/base/format_macros.h
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/i18n/number_formatting.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/base/tracked_objects.cc
   M /trunk/src/base/worker_pool_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/courgette/adjustment_method_2.cc
   M /trunk/src/media/base/video_frame_impl_unittest.cc
   M /trunk/src/media/filters/ffmpeg_glue.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/load_log_util.cc
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/disk_cache/sparse_control.cc
   M /trunk/src/net/ftp/ftp_directory_listing_buffer_unittest.cc
   M /trunk/src/net/ftp/ftp_directory_listing_parsers_unittest.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/partial_data.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/url_request/request_tracker_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_view_net_internals_job.cc
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/media/buffered_data_source_unittest.cc
   M /trunk/src/webkit/glue/media/media_resource_loader_bridge_factory.cc

Add compiler-specific "examine printf format" attributes to printfs.

Functions that take a printf-style format get a new annotation, which
produces a bunch of compiler warnings when you use printf impoperly.
This change adds the annotations and fixes the warnings.

We now must use PRId64 for 64-bit numbers and the PRIsz for size_t.

Review URL: http://codereview.chromium.org/339059
------------------------------------------------------------------------
r32598 | viettrungluu@chromium.org | 2009-11-20 06:29:00 +0100 (Fri, 20 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/About.xib
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Mac: remove cursor turd from About dialog.

(The cursor was displayed with full keyboard accessibility enabled.)

Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|).

BUG=25570
TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text).

Review URL: http://codereview.chromium.org/414028
------------------------------------------------------------------------
r32595 | kuan@chromium.org | 2009-11-20 04:26:00 +0100 (Fri, 20 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc

Fix assert in sad_tab when requested width for message is < -1.

BUG=28270
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/414022
------------------------------------------------------------------------
r32594 | mattm@chromium.org | 2009-11-20 04:00:38 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Add extensions BookmarkModel observer automatically when manifest has bookmarks permission.

BUG=28136
TEST=see bug

Review URL: http://codereview.chromium.org/412007
------------------------------------------------------------------------
r32589 | andybons@chromium.org | 2009-11-20 03:24:22 +0100 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   M /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   A /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.h
   A /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller.mm
   A /trunk/src/chrome/browser/cocoa/extensions/extension_popup_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/chrome.gyp

Adds popups to browser actions, completing the feature.
Adds functionality to choose between two different InfoBubbleView types: white background and gradient background.

Screenshot: http://andybons.com/chrome/news_popup.png

BUG=23881
TEST=Install a browser action extension that has a popup, click and observe the popup being shown. Initial unit test added, but disabled.
Review URL: http://codereview.chromium.org/402077
------------------------------------------------------------------------
r32588 | aa@chromium.org | 2009-11-20 03:16:13 +0100 (Fri, 20 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/renderer/user_script_slave.cc

Special case the gallery to not show the scary download roadblock.

That was only needed because of clickjacking.

BUG=28227

Review URL: http://codereview.chromium.org/411004
------------------------------------------------------------------------
r32587 | levin@chromium.org | 2009-11-20 03:14:41 +0100 (Fri, 20 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h

Fix build.

TBR=jam@chromium.org
TEST=None
BUG=None

Review URL: http://codereview.chromium.org/414023
------------------------------------------------------------------------
r32586 | levin@chromium.org | 2009-11-20 03:05:34 +0100 (Fri, 20 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix unitialized memory access in workers.

The primary issue was that OnDestroy didn't change the entangled port
to have its entangled port be none.

A secondary issues that came up is that in very rare circumstances (like a crash
happening early in a worker process), it seemed like it may be possible that one
of the message ports may think it is entangled and the other half may not, so
the Erase method guards against this.

Also, some code was added to verify the internal structure before running code
and after.

BUG=27839
TEST=valgrind on linux running ui tests, specifically WorkerTest.WorkerFastLayoutTests.

Review URL: http://codereview.chromium.org/402106
------------------------------------------------------------------------
r32585 | estade@chromium.org | 2009-11-20 02:58:19 +0100 (Fri, 20 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

GTK bookmark manager polish.

1. on right tree view, deselect everything when user presses below lowest row. This is not native gtktreeview behavior, but it is used in windows and by nautilus via libegg, so it matches user expectations.
2. allow default left click handler to run on right tree view. This allows a left click below the lowest row to cause the tree view pane to take focus.
3. continue blocking empty drags.

BUG=27869,27872

Review URL: http://codereview.chromium.org/417002
------------------------------------------------------------------------
r32584 | estade@chromium.org | 2009-11-20 02:56:08 +0100 (Fri, 20 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Fix mac ui test valgrind.

this define should have been SPELLCHECKER_IN_RENDERER, but instead it was OS_LINUX, so I didn't notice it.

BUG=none
TEST=none

TBR=thestig

Review URL: http://codereview.chromium.org/414021
------------------------------------------------------------------------
r32583 | chron@google.com | 2009-11-20 02:41:34 +0100 (Fri, 20 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_columns.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   A /trunk/src/chrome/test/sync/engine/test_syncable_utils.cc
   A /trunk/src/chrome/test/sync/engine/test_syncable_utils.h

Remove unique naming from syncer! This reduces the complexity. Modify the index to store things with parent id and metahandle instead of parent id and name.

Add a template function for extracting name from proto buffers.

Refactor some unit tests to work without unique naming.
Remove path calls since they make no sense without unique names.

Remove find by parentID and names.

Remove unique name resolution from conflict resolver.

Remove syncable name class.

TEST=included unit tests

Review URL: http://codereview.chromium.org/371029
------------------------------------------------------------------------
r32581 | suzhe@chromium.org | 2009-11-20 02:30:33 +0100 (Fri, 20 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.h

Linux: Fix regression issue 27964: ctrl+tab loses focus from the text box.

BUG=27964
TEST=Open two tabs, and load www.google.com in one tab and place the cursor in the search box, then press ctrl-tab twice. The cursor should be still in the search box.

Review URL: http://codereview.chromium.org/402083
------------------------------------------------------------------------
r32579 | tony@chromium.org | 2009-11-20 02:09:41 +0100 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc

Set the label for a chrome link button when the text is set, not when
the expose event fires.  This avoids a relayout that happens when the
label is set the first time the link is exposed.

TEST=Put a breakpoint in gtk_chrome_link_button_expose and open the
    about dialog.  You should hit the breakpoint twice, not four times.

Review URL: http://codereview.chromium.org/411007
------------------------------------------------------------------------
r32578 | mpcomplete@chromium.org | 2009-11-20 02:06:00 +0100 (Fri, 20 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Undo my revert at r32524 due to a startup test regression.

ExtensionHosts once again spawn extension processes asynchronously. However,
if the process is already started, we now initialize the RenderView
synchronously. This is so bug 28049 stays fixed.

BUG=28049

Review URL: http://codereview.chromium.org/402101
------------------------------------------------------------------------
r32573 | arv@chromium.org | 2009-11-20 01:48:39 +0100 (Fri, 20 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Fix issue where a thumbnail was stuck in hover mode after a delete.

The reason why the thumbnail was stuck is that it was focused due to
the mousedown (the element was reused). Now we blur the element when we
blacklist the thumbnail.

This also adds support for Del (and Cmd+Backspace for mac) to blacklist the
focused thumbnail.

This also fixes the issue where the user could tab to a filler.

BUG=28185
TEST=Remove a thumbnail and move the mouse out of the mostvisited thumbnails.
None of them should be highlighted. 

Review URL: http://codereview.chromium.org/414011
------------------------------------------------------------------------
r32563 | estade@chromium.org | 2009-11-19 23:52:15 +0100 (Thu, 19 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc

Linux: tell webkit to permit WebDragOperationMove drags.

BUG=28235
TEST=drag text between two text fields in a web page, e.g. google.com search results page has two <input>s. The dragged text should Move (not Copy) from one to the other.

Review URL: http://codereview.chromium.org/414009
------------------------------------------------------------------------
r32561 | estade@chromium.org | 2009-11-19 23:44:29 +0100 (Thu, 19 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   D /trunk/src/chrome/browser/spellcheck_unittest.cc
   D /trunk/src/chrome/browser/spellcheck_worditerator.cc
   D /trunk/src/chrome/browser/spellcheck_worditerator.h
   D /trunk/src/chrome/browser/spellchecker.cc
   D /trunk/src/chrome/browser/spellchecker.h
   D /trunk/src/chrome/browser/spellchecker_common.h
   M /trunk/src/chrome/browser/spellchecker_linux.cc
   M /trunk/src/chrome/browser/spellchecker_mac.mm
   M /trunk/src/chrome/browser/spellchecker_platform_engine.h
   A /trunk/src/chrome/browser/spellchecker_platform_engine_unittest.cc
   M /trunk/src/chrome/browser/spellchecker_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/spellcheck_common.cc
   A /trunk/src/chrome/common/spellcheck_common.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   A /trunk/src/chrome/renderer/spellchecker/spellcheck_unittest.cc (from /trunk/src/chrome/browser/spellcheck_unittest.cc:32111)
   M /trunk/src/chrome/test/testing_profile.h

Move Mac to using renderer spellchecker.

BUG=25677

Review URL: http://codereview.chromium.org/395007
------------------------------------------------------------------------
r32560 | rohitrao@chromium.org | 2009-11-19 23:42:01 +0100 (Thu, 19 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

[Mac] Add support for growing or shrinking the window during animations.

BUG=http://crbug.com/14900
TEST=No visible impact, yet.
Review URL: http://codereview.chromium.org/391035
------------------------------------------------------------------------
r32556 | tony@chromium.org | 2009-11-19 23:22:24 +0100 (Thu, 19 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h

Move URLs out of *.pak files and put them into code.  This saves
28k of pak file size, but will make the binary a tad bit larger.

BUG=28174

Review URL: http://codereview.chromium.org/407007
------------------------------------------------------------------------
r32552 | cpu@chromium.org | 2009-11-19 22:55:03 +0100 (Thu, 19 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc

Making the toast localized
Current code had 4 flavors of non-localized strings, now we have selected one and localized

BUG=none
TEST=start chrome with --try-chrome-again=0 and observe.

Review URL: http://codereview.chromium.org/399102
------------------------------------------------------------------------
r32551 | dmaclach@chromium.org | 2009-11-19 22:52:16 +0100 (Thu, 19 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/AboutIPC.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/about_ipc_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.mm
   M /trunk/src/chrome/browser/cocoa/background_gradient_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/background_tile_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/base_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/clickhold_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/event_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_pasteboard_unittest.mm
   M /trunk/src/chrome/browser/cocoa/focus_tracker_unittest.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/nswindow_local_state_unittest.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/styled_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm

Moved a whole pile of unittests over to CocoaTest.
AboutIPC.xib - Connected up controller to its window and the window delegate to the controller.

BUG=26484, 26484
TEST=See repro steps in bugs.

Review URL: http://codereview.chromium.org/402066
------------------------------------------------------------------------
r32549 | akalin@chromium.org | 2009-11-19 22:37:49 +0100 (Thu, 19 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm

Removed parentWindow parameter from HtmlDialogWindowController.

Center HTML dialogs using [window screen].

BUG=
TEST=manual

Review URL: http://codereview.chromium.org/407010
------------------------------------------------------------------------
r32547 | derat@chromium.org | 2009-11-19 22:24:11 +0100 (Thu, 19 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

gtk: Show page action popup bubbles.

Focus is a bit weird within these; I suspect that it's the same
with the browser action bubbles.  It looks like the same issue that
the bookmark bubble had: the bubble grabs the pointer; when a
widget within it (e.g. combobox) gets clicked it steals the grab;
when it ungrabs it the grab is released instead of being
transferred back to the bubble.  Unsure of what the correct fix
is for this.

BUG=28061
TEST=installed two separate extensions with page action popups and clicked on their icons

Review URL: http://codereview.chromium.org/412001
------------------------------------------------------------------------
r32541 | rohitrao@chromium.org | 2009-11-19 22:01:35 +0100 (Thu, 19 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/animatable_view.mm

[Mac] Rename a poorly named class.

BUG=http://crbug.com/28261
TEST=None
Review URL: http://codereview.chromium.org/402088
------------------------------------------------------------------------
r32540 | akalin@chromium.org | 2009-11-19 21:58:59 +0100 (Thu, 19 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h

Made FlowHandler() be created by SyncSetupFlow itself.

Clean up SyncSetupFlow's flow_handler_ if ownership isn't taken away
from it.

BUG=
TEST=SyncSetupWizard unit tests

Review URL: http://codereview.chromium.org/405027
------------------------------------------------------------------------
r32537 | akalin@chromium.org | 2009-11-19 21:46:15 +0100 (Thu, 19 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm

Moved HtmlDialogWindowDelegateBridge into html_dialog_window_controller.mm.

BUG=
TEST=trybots,manually compiled

Review URL: http://codereview.chromium.org/402075
------------------------------------------------------------------------
r32536 | mad@chromium.org | 2009-11-19 21:43:53 +0100 (Thu, 19 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h

Allow extension port connection requests to provide tab information.

For Siggi: http://codereview.chromium.org/408015

BUG=0
TEST=none

------------------------------------------------------------------------
r32526 | mrossetti@chromium.org | 2009-11-19 19:59:21 +0100 (Thu, 19 Nov 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/ImportSettingsDialog.xib
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/import_settings_dialog.h
   A /trunk/src/chrome/browser/cocoa/import_settings_dialog.mm
   A /trunk/src/chrome/browser/cocoa/import_settings_dialog_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome_browser.gypi

Implement "Import Bookmarks and Settings".

Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name .  This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder).

Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above.

BUG=26157
TEST=Launch Chrome and inspect the current bookmarks and settings.  With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu.  Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu.  Select a browser from the popup, choose the items to be imported, and press OK.  Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported.

Review URL: http://codereview.chromium.org/378036
------------------------------------------------------------------------
r32524 | mpcomplete@chromium.org | 2009-11-19 19:49:28 +0100 (Thu, 19 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Revert old change that created an ExtensionHost's RenderView asynchronously.

With jam's recent change to spawn renderers from a background thread,
ExtensionHost spawns processes asynchronously for free. Reverting this change
also fixes a bug due to an extension popup closing before the next one can be
created.

BUG=28049

Review URL: http://codereview.chromium.org/399098
------------------------------------------------------------------------
r32522 | ian@chromium.org | 2009-11-19 19:13:52 +0100 (Thu, 19 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc

Sort the origins in the cookies_tree_model by effective TLD, as opposed
to a lexicographical sort on the entire origin as a string.

BUG=28192
TEST=cookies_tree_model_unittest.cc
Review URL: http://codereview.chromium.org/404039
------------------------------------------------------------------------
r32520 | tony@chromium.org | 2009-11-19 18:50:42 +0100 (Thu, 19 Nov 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   A /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc
   A /trunk/src/chrome/browser/dom_ui/ntp_resource_cache.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/test/testing_profile.h

Implement a NTP resource cache.  Instead of re-generating the
HTML for the NTP each time, keep a cached copy as part of the
profile.

- This changes the handling of StartDataRequest to always happen
on the UI thread since it needs to use the Profile.  Previously
we would generate on the UI thread then handle all the requests
on the IO thread.
- first_view_ got changed into a static bool.  I also removed it
from being added to the json because it didn't appear to be used
anywhere.
- Merge the incognito and regular handler into one since I added
that as a flag to the request in a previous change.

I plan to add the CSS to NTPResourceCache next.

BUG=23120

Review URL: http://codereview.chromium.org/399055
------------------------------------------------------------------------
r32515 | thomasvl@chromium.org | 2009-11-19 17:25:04 +0100 (Thu, 19 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util_mac.h
   M /trunk/src/app/l10n_util_mac.mm
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h

Mac language/locale cleanup
- Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale.
- For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before)
- All other process types will honor the language they got on the command line when starting up.
- When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.)
- During browser startup, if someone passed a language, bail because Mac can't support that.

TEST=The tips on the NTP and the dates on the history page are in the same language at the UI.
BUG=26856
BUG=22727
Review URL: http://codereview.chromium.org/399086
------------------------------------------------------------------------
r32508 | xiyuan@chromium.org | 2009-11-19 10:18:50 +0100 (Thu, 19 Nov 2009) | 29 lines
Changed paths:
   M /trunk/src/app/win_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/web_applications/web_app.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/util/shell_util.cc

Set prop app id for chromium/application shortcut.

This is a follow up change after andrew's patch for win7 shortcut to
properly set app id for chromium/application shortcut.
- Move PKEY_AppUserModel_ID and code to set it from app/win_util.cc to
  base/win_util.cc as SetAppIdForPropertyStore to share with file_util
  shortcut code;
- Add an app_id args to file_util's CreateShortcutLink and
  UpdateShortcutLink;
- Update code that calls the above two function in installer and
  UserDataManager so that the chromium shortcuts are created with proper
  app id (except the uninstall shortcut which is not tagged with any app
  id).
- Move ComputeApplicationNameFromURL from Browser to web_app namespace
  and use it as app id for application shortcut. This makes pinned
  shortcut and browser window use the same app id and Win7 correctly
  groups them;

- Rename ComputeApplicationNameFromURL to GenerateApplicationNameFromURL
  per Ben's comments;

- Add a DCHECK in SetAppIdForPropertyStore to ensure app id is less than
  128 chars and contains no space per msdn;
- Change default app id from IDS_PRODUCT_NAME to chrome::kBrowserAppName

BUG=28104
TEST=On Win7, pinned shortcut should no longer be separated from running instance of chrome for both chrome and web application.

Review URL: http://codereview.chromium.org/399045
------------------------------------------------------------------------
r32503 | xiyuan@chromium.org | 2009-11-19 08:17:23 +0100 (Thu, 19 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/web_applications/web_app.cc
   M /trunk/src/chrome/browser/web_applications/web_app.h

Disable create application shortcuts for internal pages

- In fact, we only allow scheme file, ftp, http and https to have
  shortcuts;
- Removed GetFavIcon().isNull() for checking since we are using url
  scheme now;
- Add a CommandCreateAppShortcut to BrowserTest per Ben's comments;

BUG=26743
TEST=Verify create application shortcuts menu item is disabled for all
internal pages including but not limited to new tab page, history,
downloads, view-source etc.

Review URL: http://codereview.chromium.org/404011
------------------------------------------------------------------------
r32494 | cpu@chromium.org | 2009-11-19 05:50:58 +0100 (Thu, 19 Nov 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/diagnostics/diagnostics_model.cc
   A /trunk/src/chrome/browser/diagnostics/diagnostics_model.h
   A /trunk/src/chrome/browser/diagnostics/diagnostics_model_unittest.cc
   A /trunk/src/chrome/browser/diagnostics/diagnostics_test.h
   M /trunk/src/chrome/chrome_browser.gypi
   M /trunk/src/chrome/chrome_tests.gypi

Introducing the diagnostic model classes

Chrome diagnostics wants to be a MVC, this is the classes that compose the model part.

BUG=27885
TEST=included unit tests



Review URL: http://codereview.chromium.org/385144
------------------------------------------------------------------------
r32493 | avi@google.com | 2009-11-19 05:48:57 +0100 (Thu, 19 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_util_mac.h
   M /trunk/src/chrome/browser/cocoa/download_util_mac.mm

Mac: Bounce the downloads folder (in the Dock) on completed downloads.

BUG=none
TEST=download something on SL, watch the Dock bounce. Bounce, Dock, bounce!

Review URL: http://codereview.chromium.org/404043
------------------------------------------------------------------------
r32488 | eroman@chromium.org | 2009-11-19 04:43:19 +0100 (Thu, 19 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h

Cleanup some callers now that the restriction that ChromeURLRequestContextGetter be released from the IO thread is gone.

This was an anoyance for consumers of URLRequestContextGetter, as they would play tricks doing manual AddRef/Release.

The actual removal of this policy happened in: r32129.

BUG=None
Test=Existing tests don't crash/leak.

Review URL: http://codereview.chromium.org/332006
------------------------------------------------------------------------
r32487 | evan@chromium.org | 2009-11-19 04:42:44 +0100 (Thu, 19 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc

file_util: Fix some callers of CreateNewTempDirectory to remove the deprecated version.

BUG=None
TEST=unit_tests

Patch from Thiago Farina <thiago.farina@gmail.com>.

Review URL: http://codereview.chromium.org/385112
------------------------------------------------------------------------
r32484 | oshima@chromium.org | 2009-11-19 04:33:31 +0100 (Thu, 19 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_browsertest.cc

BookmarkManagerTest now passes without this hack.
I don't know exactly what's been changed thoguh.
We're going to enable this in build/try bots soon so we can tell when this comes back.

BUG=28046
TEST=browser_tests --gtest_filter=BookmarkManagerTest* should pass.

Review URL: http://codereview.chromium.org/399104
------------------------------------------------------------------------
r32476 | estade@chromium.org | 2009-11-19 03:54:54 +0100 (Thu, 19 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

GTK: add f11 for fullscreen menu item to wrench menu.

BUG=28211

Review URL: http://codereview.chromium.org/399106
------------------------------------------------------------------------
r32463 | estade@chromium.org | 2009-11-19 02:49:19 +0100 (Thu, 19 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: correct coordinate calculation for floating bookmark bar background painting.

I believe changes to the windowed-ness of the widgetry in the bookmark bar caused this.

BUG=27769
TEST=works in both classic theme mode and gtk theme mode

Review URL: http://codereview.chromium.org/399103
------------------------------------------------------------------------
r32462 | ukai@chromium.org | 2009-11-19 02:48:24 +0100 (Thu, 19 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Enable WebSocketExperiment back

r32311 fixes the cause of the crash, so enable WebSocket experiment again.

BUG=28096,27856
TEST=none

Review URL: http://codereview.chromium.org/399065
------------------------------------------------------------------------
r32461 | viettrungluu@chromium.org | 2009-11-19 02:42:26 +0100 (Thu, 19 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm

Mac: Fix regression in NTP detached bookmark bar colours.

The regression was caused by r32425.

BUG=28203
TEST=Look at NTP detached bookmark bar: it should be medium-ish grey, not black (or is that dark grey)?

Review URL: http://codereview.chromium.org/406009
------------------------------------------------------------------------
r32453 | joel@chromium.org | 2009-11-19 01:50:48 +0100 (Thu, 19 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

linux: unused variable in ARM build

The seccomp sandbox is conditional on ARCH_CPU_X86_FAMILY.  When
building for !ARCH_CPU_X86_FAMILY the variable g_proc_fd is
unused, leading to a build error when -Werror is turned on.

Review URL: http://codereview.chromium.org/397040
------------------------------------------------------------------------
r32451 | cira@chromium.org | 2009-11-19 01:41:33 +0100 (Thu, 19 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker_unittest.cc

Enabling (sandboxed) extension unpacker tests.

XP bots were failing on directory Delete. Removing ASSERT_TRUE for deletes solves the problem.

Review URL: http://codereview.chromium.org/408009
------------------------------------------------------------------------
r32449 | estade@chromium.org | 2009-11-19 01:36:21 +0100 (Thu, 19 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: Fix popup menu positioning.

Don't go off end of screen. push_in doesn't actually work as well as one might hope.

BUG=27800

Review URL: http://codereview.chromium.org/408017
------------------------------------------------------------------------
r32446 | jam@chromium.org | 2009-11-19 01:27:24 +0100 (Thu, 19 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   D /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Remove the utility process unit tests to simplify the utility process code a little (helpeful to make it use ChildProcessLauncher).  Note that the test isn't needed anymore as a unit test because since it was written, there have been a couple of tests that exercise this code path through browser_tests.  They use sandboxed utility processes so it's more equivalent to what the user experiences.

Review URL: http://codereview.chromium.org/402074
------------------------------------------------------------------------
r32445 | akalin@chromium.org | 2009-11-19 01:22:49 +0100 (Thu, 19 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm

Made HtmlDialogWindowController on OS X use its own browser object.

Fixed some style violations.

Made HtmlDialogWindowDelegateBridge stop doing anything after it receives a close notification.

This fixes the crash described in issue 28039.

BUG=28039
TEST=trybots,manual

Review URL: http://codereview.chromium.org/402065
------------------------------------------------------------------------
r32443 | chocobo@chromium.org | 2009-11-19 01:20:39 +0100 (Thu, 19 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc

Remove Network section from options pages for now.
BUG=541
TEST=None
Review URL: http://codereview.chromium.org/399094
------------------------------------------------------------------------
r32441 | mrossetti@chromium.org | 2009-11-19 01:06:04 +0100 (Thu, 19 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkAllTabs.xib
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Change the folder presentation in the Bookmark Editor and the Bookmark All Tabs dialogs to a tree view.

Nib changes: Removed the NSBrowser and added an NSOutlineView.

BUG=26647,26643,26718,27634
TEST=Bring up the bookmark editor by control-clicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu.  Observe that the folder presentation is now a tree view.  Select any folder and click New Folder to verify that new folders can be added.  Double-click on the newly created folder to change its name.  Added folders will not commit until OK is pressed, which will require that a bookmark actually be added.  Also bring up the Bookmark All Tabs dialog by control-clicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view.


Review URL: http://codereview.chromium.org/393006
------------------------------------------------------------------------
r32434 | tony@chromium.org | 2009-11-19 00:46:43 +0100 (Thu, 19 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Revert r32108 and re-enable BrowserTest.FLAKY_SingleBeforeUnloadAfterWindowClose
on Linux.

Some crashers on window close have been fixed so let's try running this again.  I was unable to repro from running the test in a loop for a few hours.

TBR=erikkay

Review URL: http://codereview.chromium.org/408016
------------------------------------------------------------------------
r32431 | zork@chromium.org | 2009-11-19 00:24:39 +0100 (Thu, 19 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc

Change the layout have in sync_setup_flow.cc to only be active on MacOS.

BUG=none
TEST=Enable bookmarks on Linux.  The dialog should no longer be too large.

Review URL: http://codereview.chromium.org/402070
------------------------------------------------------------------------
r32427 | eroman@chromium.org | 2009-11-19 00:07:08 +0100 (Thu, 19 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/net/proxy/init_proxy_resolver.cc
   M /trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/proxy/proxy_script_fetcher.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

NULL out the ProxyScriptFetcher used by ProxyService when the URLRequestContext it was using for downloads is destroyed.

This avoids the possibility of accessing freed memory when sharing ProxyService amongst request context, and the main context is destroyed first.

BUG=25338

Review URL: http://codereview.chromium.org/387065
------------------------------------------------------------------------
r32426 | dmaclach@chromium.org | 2009-11-19 00:07:08 +0100 (Thu, 19 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm

Move some more tests over to CocoaTest

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/405022
------------------------------------------------------------------------
r32425 | viettrungluu@chromium.org | 2009-11-18 23:56:47 +0100 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/animatable_view.h
   M /trunk/src/chrome/browser/cocoa/animatable_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_state.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/toolbar_view.mm
   M /trunk/src/chrome/chrome.gyp

Mac: animate NTP detached bookmark bar <-> normal bookmark bar.

Also mostly fix the placement of the "For quick access, place your bookmarks here [...]" message (when there are no bookmarks). It's not quite right in the new animation (detached <-> normal).

BUG=25600, 27692, 27693
TEST=Go to NTP and press Cmd-Shift-B a few times while watching closely. The detached bar should "morph" smoothly to the normal bar and vice versa. Switch themes and repeat; please test at least the default theme and the Brushed theme.

Review URL: http://codereview.chromium.org/400020
------------------------------------------------------------------------
r32420 | viettrungluu@chromium.org | 2009-11-18 23:29:54 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm

Tiny style fix.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/402067
------------------------------------------------------------------------
r32416 | erg@google.com | 2009-11-18 23:18:34 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

GTK: Remove problematic theme styles from the location bar.

BUG=27103
TEST=Use xfce-stellar theme. There shouldn't be an inner box in the location bar and typing shouldn't cause text to move up and down.

Review URL: http://codereview.chromium.org/399087
------------------------------------------------------------------------
r32413 | mirandac@chromium.org | 2009-11-18 23:05:04 +0100 (Wed, 18 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Tweaks and fixes for NTP extension promo.

Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.

BUG= 27814, 25258, 27815
TEST= see various bugs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32176
Review URL: http://codereview.chromium.org/385135
------------------------------------------------------------------------
r32408 | sky@chromium.org | 2009-11-18 22:42:35 +0100 (Wed, 18 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc

Makes it so you can't detach tabs on Chrome OS. It doesn't make sense
given the current design and triggers a crash. I'm also effectively
disabling DockInfo for ChromeOS as that triggers a crash. I don't
believe we'll hit the code after my first change, but I'm going for
completeness.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/399083
------------------------------------------------------------------------
r32391 | zork@chromium.org | 2009-11-18 22:03:51 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Add support for the bookmark sync error button on the bookmark bar to Linux.

BUG=none
TEST=Change your password after logging into bookmark sync, then restart your browser.  There should be a warning button on the bookmark bar now.

Review URL: http://codereview.chromium.org/387054
------------------------------------------------------------------------
r32389 | zork@chromium.org | 2009-11-18 21:40:25 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.cc
   D /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/chrome.gyp

Change the sync dialog to use the Html version on Linux.

BUG=none
TEST=Run chrome with --enable-sync.  While bookmark sync is disabled, click on Wrench Menu->Sync My Bookmarks

Review URL: http://codereview.chromium.org/402059
------------------------------------------------------------------------
r32384 | viettrungluu@chromium.org | 2009-11-18 21:19:31 +0100 (Wed, 18 Nov 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm

Mac: implement Pin Tab.

Note that, per Apple's HIG, the context menu alternates between Pin/Unpin Tab instead of toggling a checkmark.

Changes to TabView.xib:
- add Pin Tab item (to match Windows)

Still to do:
- dragging/dropping tabs needs visual feedback to indicate how pinned state will change (need input from UI team)
- on Windows, you can pin a tab by dragging it slightly to the right of the rightmost pinned tab; this needs to be done

BUG=25481
TEST=not yet

Review URL: http://codereview.chromium.org/375010
------------------------------------------------------------------------
r32383 | oshima@chromium.org | 2009-11-18 21:11:44 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

Use Views version of BrowserActionTest for linux/view build.

BUG=None
TEST=browser_tess --gtest_filter=BrowserActionTest* should pass on linux/view build.

Review URL: http://codereview.chromium.org/404021
------------------------------------------------------------------------
r32382 | mpcomplete@chromium.org | 2009-11-18 20:53:34 +0100 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sandbox_policy.cc

Hacky fix for crashes with Google Desktop installed.

The fix is to add --ignored=" --type=renderer " to the command line of
non-renderer, non-plugin subprocesses, tricking GD into not injecting its DLL.

BUG=25580

Review URL: http://codereview.chromium.org/400026
------------------------------------------------------------------------
r32381 | oshima@chromium.org | 2009-11-18 20:49:20 +0100 (Wed, 18 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

This is a temp hack to get SSLUITest.TestHTTPErrorWithNoNavEntry working on linux/views.
see http://crbug/28098 for more details about the root cause of the issue.

BUG=28098
TEST=brower_tests passes with this hack, but we need real solution.

Review URL: http://codereview.chromium.org/397037
------------------------------------------------------------------------
r32376 | pkasting@chromium.org | 2009-11-18 20:32:58 +0100 (Wed, 18 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/memory_purger.cc
   M /trunk/src/chrome/browser/memory_purger.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc

Hook up the memory purger to all the relevant locations.

This removes the two-state purge/reset code (no longer necessary), and the hooks to the power monitor (not ready to turn those on without more work and testing).

BUG=23400
TEST=Run Chrome with --purge-memory-button, use it for awhile, open the Task Manager, and click "Purge Memory".  You should still be able to use the program normally, and hopefully we dumped some memory out too (varies by usage).
Review URL: http://codereview.chromium.org/399028
------------------------------------------------------------------------
r32374 | dmaclach@chromium.org | 2009-11-18 20:32:00 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac_unittest.mm

move DownloadShelfMac tests over to CocoaTest

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/407004
------------------------------------------------------------------------
r32373 | wtc@chromium.org | 2009-11-18 20:31:40 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/unittest_test_server.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

Rename policy_url to first_party_for_cookies in cookie-related code.

R=abarth
BUG=25133
TEST=none. A cosmetic change.
Review URL: http://codereview.chromium.org/403011
------------------------------------------------------------------------
r32372 | dmaclach@chromium.org | 2009-11-18 20:31:33 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

Move status_bubble_mac_unittest over to CocoaTest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/404030
------------------------------------------------------------------------
r32371 | dmaclach@chromium.org | 2009-11-18 20:30:48 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller_unittest.mm

Move HungRenderedControllerUnitTest over to CocoaTest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/406003
------------------------------------------------------------------------
r32370 | dmaclach@chromium.org | 2009-11-18 20:30:31 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button_unittest.mm

move delayedmenu_button_unittest over to CocoaTest

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/406004
------------------------------------------------------------------------
r32369 | dmaclach@chromium.org | 2009-11-18 20:30:13 +0100 (Wed, 18 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm

move chrome_browser_window_unittest over to cocoatest
renable some disabled tests.

BUG=24732
TEST=none

Review URL: http://codereview.chromium.org/402055
------------------------------------------------------------------------
r32365 | kuan@chromium.org | 2009-11-18 20:24:48 +0100 (Wed, 18 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.h

This cl reimplements the entire "Aw Snap" page to use gtk widgets to layout and draw the icon, title, message and add new "Learn more" link; the old implementation used skia to do simple drawing, but couldn't be used for link, hence the rewrite.

BUG=27211
TEST=Verify that "Aw Snap" page is displayed correctly, and new "Learn more" link shows up centralized beneath the message, and when window is resized bi-directionally, especially smaller to force wrapping of message.
Review URL: http://codereview.chromium.org/385145
------------------------------------------------------------------------
r32364 | mark@chromium.org | 2009-11-18 20:24:39 +0100 (Wed, 18 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

RenderWidgetHostViewMac should release its owning RenderWidgetHostViewCocoa
in Destroy when the widget was a native (external) pop-up menu.

This change depends on WebKit r51102
(https://bugs.webkit.org/show_bug.cgi?id=31609).

BUG=27723, 26876
TEST=1. Following the steps in bug 27723 comment 5 should not result in a sad
        tab:
         a. Open Google Calendar
         b. Bring up a recurring event
         c. Click the "Edit" link on the "Repeat" line beneath "When"
         d. Change the value of the "Repeat Every" drop-down menu
     2. Also, web content pop-up menus should work more generally.
     3. After using a web content pop-up menu and then closing all windows,
        there should not be any renderer processes running.
Review URL: http://codereview.chromium.org/397039
------------------------------------------------------------------------
r32363 | zork@chromium.org | 2009-11-18 20:23:25 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/html_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/html_dialog_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Add support for ShowHtmlDialog() to Linux.  This is modeled off the MacOS and Windows versions, except that it uses a gtk dialog and TabContentsContainerGtk to create the window.

BUG=25260
TEST=Call ShowHTMLDialog() with a working dialog, such as the login dialog for Bookmark sync.

Review URL: http://codereview.chromium.org/394011
------------------------------------------------------------------------
r32362 | kuchhal@chromium.org | 2009-11-18 20:20:57 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Leave the 'Make Chrome Default' button enabled on Windows if not already default.

BUG=27403
TEST=As described in the bug above.

Review URL: http://codereview.chromium.org/408004
------------------------------------------------------------------------
r32358 | estade@chromium.org | 2009-11-18 20:18:49 +0100 (Wed, 18 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc

GTK: fix link button double free.

If set_normal_color was called while native_markup == normal_markup, then the string could be double freed. To fix this problem and prevent similar future mistakes, I made native_markup stdup normal_markup instead of just copying the pointer (the optimization wasn't worth the trickiness). Also, I cleaned up destruction logic.

BUG=27855

TEST=tried every flavor of chrome link button:
- classic theme
- non classic theme
- gtk theme
- gtk theme system theme that has non-default link text color property
Review URL: http://codereview.chromium.org/400009
------------------------------------------------------------------------
r32357 | cira@chromium.org | 2009-11-18 20:13:11 +0100 (Wed, 18 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker_unittest.cc

DISABLING all new unpacker tests. XP try bots are failing.

TBR=tony@chromium.org

Review URL: http://codereview.chromium.org/399076
------------------------------------------------------------------------
r32350 | rsesek@chromium.org | 2009-11-18 19:09:12 +0100 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.mm

Change two |-autorelease|ed objects to scoped_nsobject<>.

See http://codereview.chromium.org/380010/diff/1/2.

BUG=27149
TEST=Style

Review URL: http://codereview.chromium.org/405019
------------------------------------------------------------------------
r32348 | dmaclach@chromium.org | 2009-11-18 19:06:00 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm

Moving gradient button cell over to cocoatest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/404029
------------------------------------------------------------------------
r32345 | cira@chromium.org | 2009-11-18 19:02:47 +0100 (Wed, 18 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   A /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   A /trunk/src/chrome/common/extensions/extension_unpacker_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/test/data/extensions/unpacker
   A /trunk/src/chrome/test/data/extensions/unpacker/empty_default_locale
   A /trunk/src/chrome/test/data/extensions/unpacker/empty_default_locale/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/empty_default_locale.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n/_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US/messages.json
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/sr
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/sr/messages.json
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/good_l10n.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/has_default_missing_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/has_default_missing_locales/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/has_default_missing_locales.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_default_locale
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_default_locale/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_default_locale.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_messages_file
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US/messages.json
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_messages_file/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/invalid_messages_file.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_data
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_data/_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US/messages.json
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_data/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_data.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_has_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_has_locales/_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_has_locales/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_default_has_locales.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_messages_file
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_messages_file/_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_messages_file/_locales/en_US
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_messages_file/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/missing_messages_file.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/no_l10n
   A /trunk/src/chrome/test/data/extensions/unpacker/no_l10n/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/no_l10n.crx
   A /trunk/src/chrome/test/data/extensions/unpacker/no_locale_data
   A /trunk/src/chrome/test/data/extensions/unpacker/no_locale_data/_locales
   A /trunk/src/chrome/test/data/extensions/unpacker/no_locale_data/manifest.json
   A /trunk/src/chrome/test/data/extensions/unpacker/no_locale_data.crx
   M /trunk/src/chrome/utility/utility_thread.cc

Parse messages.json in ExtensionUnpacker (like we do for manifest) and pass them to sandboxed_extension_unpacker.
Added unittest files for unpacker and sandboxed unpacker.

TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail.
BUG=27362

Review URL: http://codereview.chromium.org/390019
------------------------------------------------------------------------
r32344 | mrossetti@chromium.org | 2009-11-18 19:00:04 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm

Eliminate the extra separator when there are no bookmarks in the bookmarks bar.

BUG=27795
TEST=Start with a fresh Chrome or else remove all bookmarks.  Bring up the Bookmarks menu.  Observe that there is a single separator above the Other Bookmarks menu item.  Add a bookmark to the bar.  Bring up the Bookmarks menu.  Observe that there is now a new bookmark item followed by a new separator.  Remove the new bookmark and repeat the observation noting that both the bookmark and the separator have been removed.

Review URL: http://codereview.chromium.org/403013
------------------------------------------------------------------------
r32342 | viettrungluu@chromium.org | 2009-11-18 18:59:36 +0100 (Wed, 18 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Mac: add Extensions to the Main Menu and to the Wrench Menu.

Changes to MainMenu.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS_MAC", tag: IDC_MANAGE_EXTENSIONS, sends: -commandDispatch: to First Responder) to Main Menu -> Window, immediately below Downloads.
Changes to Toolbar.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS", others as above) to Wrench Menu, immediately below Downloads.
Enable Extensions menu item when no browser window is open.

BUG=25423
TEST=Make sure Extensions menu items in Main Menu -> Window and in the Wrench Menu work. Also make sure the former works when no browser window is open.

Review URL: http://codereview.chromium.org/399072
------------------------------------------------------------------------
r32341 | jrg@chromium.org | 2009-11-18 18:59:10 +0100 (Wed, 18 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_button.h
   A /trunk/src/chrome/browser/cocoa/bookmark_button.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_button_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Drag and drop of buttons/folders from bar to bar.
Does not include DnD to/from menus.
No animations of drop destination yet.

BUG=http://crbug.com/17608

TEST=Do some draggin and droppin.
Confirm click still works on the marks and folders.
Confirm "other bookmarks" canNOT be moved.
Confirm NTP / detached bar also works for DnD.

Review URL: http://codereview.chromium.org/395031
------------------------------------------------------------------------
r32339 | dmaclach@chromium.org | 2009-11-18 18:55:04 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm

Move bookmark bar bridge unittest over to CocoaTest.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/407002
------------------------------------------------------------------------
r32336 | kkania@chromium.org | 2009-11-18 18:37:12 +0100 (Wed, 18 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/echo.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/tabs_util.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Add various tests for chrome.tabs/windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/355029
------------------------------------------------------------------------
r32335 | jcampan@chromium.org | 2009-11-18 18:36:33 +0100 (Wed, 18 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h

Fixes several focus issue with popup in the extensions' browser actions:
- when opening a browser action popup, it gets the focus.
- tab traversal now works in the popup
- pressing esc closes the popup (if the keyboard event is not processed by the page)

BUG=22654, 28087, 28086
TEST=Create an extension with a browser extension that shows a popup. Make the popup
     so that it has a textfield (that gets focused when the popup show) and a button.
     Install the extension. Open the popup, the textfield should have focus. Press
     tab, the focus should go to the button. Press Esc, the popup should be closed.

Review URL: http://codereview.chromium.org/402036
------------------------------------------------------------------------
r32334 | ian@chromium.org | 2009-11-18 18:27:45 +0100 (Wed, 18 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h

Add an option to tree_view for whether to show lines from the root node
to children nodes (sets TVS_LINESATROOT). Set this to false by default
(maintaining existing behaviour by default), except for cookies_view where
we set it to true.

BUG=27657
TEST=open cookies dialog, make sure the origins have a + box next to them,
and that expanding these also expands the cookies folder beneath them.
Review URL: http://codereview.chromium.org/399030
------------------------------------------------------------------------
r32320 | jorlow@chromium.org | 2009-11-18 13:26:27 +0100 (Wed, 18 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h

Revert my last...

Review URL: http://codereview.chromium.org/402049
------------------------------------------------------------------------
r32319 | jorlow@chromium.org | 2009-11-18 12:07:40 +0100 (Wed, 18 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h

Make the WebKitThread object start the WebKit thread on construction (not lazily).

NOTE: It's very possible this will have a startup performance impact.  I'm going to watch the bots after committing.

TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.

TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144

Review URL: http://codereview.chromium.org/405007
------------------------------------------------------------------------
r32314 | thestig@chromium.org | 2009-11-18 11:35:47 +0100 (Wed, 18 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Linux: Make sure the suid sandbox is owned by root.

If chrome-sandbox is mode 4755 but not owned by root, Chrome doesn't start up. We should abort instead.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/372008
------------------------------------------------------------------------
r32313 | mnaganov@chromium.org | 2009-11-18 11:13:10 +0100 (Wed, 18 Nov 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/manual_tests/heap-profiler-test-basic-grid-functionality.html
   A /trunk/src/chrome/browser/debugger/manual_tests/heap-profiler-test-snapshots-comparison.html
   A /trunk/src/chrome/browser/debugger/manual_tests/profiler-test-console-control.html
   A /trunk/src/chrome/browser/debugger/manual_tests/profiler-test-re-opening.html

DevTools: add more manual Profiles tab tests.

Review URL: http://codereview.chromium.org/404002
------------------------------------------------------------------------
r32311 | ukai@chromium.org | 2009-11-18 10:29:15 +0100 (Wed, 18 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.h

Hold histograms in static variables instead of allocating heap.

If instance variables holding pointers to Histograms, it would cause
crash bug when the instance is torn down and the metrics services use
and recording of their contents.

The current "standard" patten for using Histograms includes making sure
that the Histogram instances are not destroyed prematurely, held in
static variables.

BUG=28096
TEST=none

Review URL: http://codereview.chromium.org/404022
------------------------------------------------------------------------
r32308 | hbono@chromium.org | 2009-11-18 09:32:35 +0100 (Wed, 18 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist.cc

A fix for Issue 18994.
This change retrieves the number of slots available for custom JumpList items to calculate the items for "Most Visited" items and for "Recently Closed" items.
As written in the MSDN doc, Windows 7 changes the number of JumpList slots at run time and it truncates the items from the bottom (i.e. "Recently Closed" items) if we add more items than available ones.
To fix this issue, this change assigned 60% of available JumpList slots to the "Most Visited" category and 40% to the "Recently Closed" category, respectively. (If there are not so many "Recently Closed" Items, this change increases the number of "Most Visited" items.)

Also, this change sets the AppID since <http://codereview.chromium.org/385120> changes it.

BUG=18994
TEST=Open a JumpList and see there are two or more "Recently Closed" items in it.
Review URL: http://codereview.chromium.org/399031
------------------------------------------------------------------------
r32304 | mark@chromium.org | 2009-11-18 08:22:20 +0100 (Wed, 18 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Remove tabs introduced by r31197.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402045
------------------------------------------------------------------------
r32286 | oshima@chromium.org | 2009-11-18 05:27:05 +0100 (Wed, 18 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_browsertest.cc
   M /trunk/src/views/focus/accelerator_handler_gtk.cc

Fix for BookmarkManager Test Crash test.
 * Test was failing because the key events were sent even after
  the window has been destroyed.
 * Make sure browser window is closed before the end of test.
   Test fails in BookmarkBarView without this. I think this requires
   a fix on browser side. Filed a bug 28046.

BUG=None
Test=run browser_tests --gtest_filter=*Bookmark*

Review URL: http://codereview.chromium.org/397034
------------------------------------------------------------------------
r32284 | simonrad@chromium.org | 2009-11-18 05:25:37 +0100 (Wed, 18 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix find bar scrolling with the page after switching back to tab.

We need to do a BrowserView::Layout() (which updates things like the bookmarks bar and the find bar) both in between the TabContents detach/attach AND after the final attach. This way, we toggle the bookmarks bar at the right time, but we still end up setting the find bar properly.

R=beng
BUG=27960
TEST=Navigate to a page where you can see the vertical scroll bar. Press Ctrl+F to open the find bar. Switch to another tab and then back to the original tab. Scroll down/up the page. The find bar should stay in place, not scroll with the page or disappear.

Review URL: http://codereview.chromium.org/397036
------------------------------------------------------------------------
r32278 | joel@chromium.org | 2009-11-18 05:13:33 +0100 (Wed, 18 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Hide seccomp sandbox calls from non-x86 machines

The seccomp sandbox is not built on ARM as it contains x86 specific code.
However, there are a pair of calls to seccomp sandbox functions in the zygote
initialisation, this hides those calls behind the ARCH_CPU_X86_FAMILY define.

Without this the ARM build does not link.

Review URL: http://codereview.chromium.org/402009
------------------------------------------------------------------------
r32277 | aa@chromium.org | 2009-11-18 05:11:31 +0100 (Wed, 18 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Fix a crash when activating a select element inside a page
action popup.

With this change, select elements still don't work correctly
with page actions: when you try to use them, the page action
popup disappears. However, at least now, it doesn't crash.

BUG=27576
TEST=Install extension in related bug. Navigate to any site
and click page action. Browser should not crash.

Review URL: http://codereview.chromium.org/399032
------------------------------------------------------------------------
r32271 | finnur@chromium.org | 2009-11-18 04:21:13 +0100 (Wed, 18 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/stubs_apitest.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/static/content_scripts.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/test/data/extensions/api_test/stubs/manifest.json
   M /trunk/src/chrome/test/data/extensions/browsertest/title_localized_pa/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Preferences
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ahbojlbmpfcbogfblmekncilheldhjga/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/coomonpcecmahbfkifeohkbgicpcfdgf/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/dhminefdpfgdedodgdilagiencggdcpm/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/kgfhjcinicjnlcbnbacbkbjdbafnlckn/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ledhkldokbafdcbmepdigjmkabmombel/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/lgmapeiimomfdbfphldobhhpoaoafaci/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/maemolkcfjifpmigoecmpfphmebnebpk/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/mdeggakgacjccnbfbhbihfchoidihkaf/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/mgonfebmjopdoipblbijejncibmgmcol/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ohmmlgjlmaadhojogadklhlidfpdeoca/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/profiles/content_scripts50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/subscribe_page_action/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc

Don't allow content scripts to execute on file:// urls.

This requires a command line flag for the page cycler tests,
since those load file:// urls.

BUG=27877
TEST=Bunch of tests affected.

Review URL: http://codereview.chromium.org/402029
------------------------------------------------------------------------
r32270 | stuartmorgan@chromium.org | 2009-11-18 04:14:20 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc

Only request full-screen once per plugin window

BUG=28019
TEST=Make Silverlight full screen on the Mac, then shrink it back to in-page mode; the dock should re-appear.

Review URL: http://codereview.chromium.org/402028
------------------------------------------------------------------------
r32269 | stuartmorgan@chromium.org | 2009-11-18 04:11:05 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc

Interpose one more Carbon function for Window disposing

BUG=27820
TEST=Focus should return to browser window in test case from bug.

Review URL: http://codereview.chromium.org/402037
------------------------------------------------------------------------
r32264 | jam@chromium.org | 2009-11-18 03:41:26 +0100 (Wed, 18 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   A /trunk/src/chrome/browser/child_process_launcher.cc (from /trunk/src/chrome/browser/child_process_launcher.cc:32237)
   A /trunk/src/chrome/browser/child_process_launcher.h (from /trunk/src/chrome/browser/child_process_launcher.h:32237)
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Launch processes asynchronously so as not to block the UI thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203)

BUG=6844
Review URL: http://codereview.chromium.org/397031
------------------------------------------------------------------------
r32263 | jar@chromium.org | 2009-11-18 03:39:58 +0100 (Wed, 18 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Stop top-crasher regression by disabling WebSocketExperimentRunner

There was a race to destroy histograms held by an instance within
WebSocketExperimentRunner, and this was causing the crash when
histograms were being recorded at shutdown.

See bug 28096 for re-enabling this feature.

BUG=27856
r=wtc,ukai
Review URL: http://codereview.chromium.org/404017
------------------------------------------------------------------------
r32260 | wtc@chromium.org | 2009-11-18 03:27:34 +0100 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.h
   M /trunk/src/webkit/glue/media/simple_data_source.cc
   M /trunk/src/webkit/glue/media/simple_data_source.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Use an explicit boolean has_new_first_party_for_cookies instead
of an empty, invalid URL to indicate whether the first party for
cookies URL needs changing when following a redirect.

R=eroman
BUG=25133
TEST=none
Review URL: http://codereview.chromium.org/405011
------------------------------------------------------------------------
r32257 | wtc@chromium.org | 2009-11-18 03:14:27 +0100 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/net/cookie_policy_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Add browser tests for the BLOCK_THIRD_PARTY_COOKIES policy
to verify we allow first-party cookies in the regular and
redirected cases.

R=abarth,eroman
BUG=25133
TEST=new browser tests are added
Review URL: http://codereview.chromium.org/401009
------------------------------------------------------------------------
r32253 | dmaclach@chromium.org | 2009-11-18 02:50:06 +0100 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm

Fixes up TabStripControllerTests so that they work with CocoaTest.
Enhances BrowserTestHelper so that you can create and close the
browser window.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/402035
------------------------------------------------------------------------
r32251 | dmaclach@chromium.org | 2009-11-18 02:49:45 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Fix for parent window closing behind the bookmark bubble.

BUG=27752
TEST=none

Review URL: http://codereview.chromium.org/397006
------------------------------------------------------------------------
r32246 | dmaclach@chromium.org | 2009-11-18 01:57:28 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac_unittest.mm

Move TaskManagerMacUnitTest over to Cocoatest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/404010
------------------------------------------------------------------------
r32245 | dmaclach@chromium.org | 2009-11-18 01:57:02 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm

Fix up check so that it reads correctly when it fails.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/399047
------------------------------------------------------------------------
r32240 | jamesr@chromium.org | 2009-11-18 01:42:19 +0100 (Wed, 18 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/base_session_service.cc

Ensure that the refcount on InternalGetCommandRequest stays non-zero through a PostTask

The problem was that BaseSessionService::ScheduleGetLastSessionCommands() was posting a task with a InternalGetCommandsRequest* request parameter by calling NewRunnableMethod(.., &SessionBackend::ReadLastSessionCommands, request).  SessnionBackend::ReadLastSessionCommands takes one parameter of type scoped_refptr<InternalGetCommandsRequest>.  However, NewRunnableMethod was matching the template because an InternalGetCommandsRequest* is implicitly convertable to a scoped_refptr<InternalGetCommandsRequest> but it was not actually creating the scoped_refptr<> (and thus bumping the refcount) until the task was dispatched.  By this time the refcount on the InternalGetCommandsRequest had already dropped to zero, leading to memory corruption.

This fixes the problem by passing a scoped_refptr<...> in to NewRunnableMethod() to ensure that it is copied and that the refcount stays up.

TEST=covered by TabRestoreUITest.RestoreIntoSameWindow - caused very intermittend failures locally
BUG=none

Review URL: http://codereview.chromium.org/404012
------------------------------------------------------------------------
r32238 | jam@chromium.org | 2009-11-18 01:03:23 +0100 (Wed, 18 Nov 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/child_process_launcher.cc
   D /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Revert 32203,32204,32205 - Launch processes asynchronously so as not to block the UI thread.  For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change.

BUG=6844
Review URL: http://codereview.chromium.org/397002

Review URL: http://codereview.chromium.org/402033
------------------------------------------------------------------------
r32237 | mirandac@chromium.org | 2009-11-18 01:02:00 +0100 (Wed, 18 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert 32176 - Tweaks and fixes for NTP extension promo.

Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.

BUG= 27814, 25258, 27815
TEST= see various bugs.
Review URL: http://codereview.chromium.org/385135

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/399051
------------------------------------------------------------------------
r32223 | pkasting@chromium.org | 2009-11-17 23:17:20 +0100 (Tue, 17 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Fix DCHECK when trying to remove multiple engines from the Manage Search Engines dialog.  Original patch by Thiago Farina (see http://codereview.chromium.org/401013 ), r=me.

BUG=5227
TEST=Select multiple engines and hit "Remove" in a debug build; should not checkfail.
------------------------------------------------------------------------
r32221 | pkasting@chromium.org | 2009-11-17 23:12:39 +0100 (Tue, 17 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc

Fix checkfailure caused by stupidity.

BUG=23400
TEST=none

------------------------------------------------------------------------
r32218 | dmaclach@chromium.org | 2009-11-17 23:00:53 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

I've moved toolbar_controller_unittest over to CocoaTest which should be better about cleaning things
up properly. Let's see if this fixes the world.

BUG=27920
TEST=none

Review URL: http://codereview.chromium.org/399041
------------------------------------------------------------------------
r32216 | avi@google.com | 2009-11-17 22:57:23 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Explicitly set an icon color for Incognito on Mac.

BUG=http://crbug.com/27867
TEST=incognito icons should be black

Review URL: http://codereview.chromium.org/405008
------------------------------------------------------------------------
r32214 | tony@chromium.org | 2009-11-17 22:41:52 +0100 (Tue, 17 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

Style cleanups for BrowserThemeProvider.  Move the global
stl containers into helper functions to defer init and to ensure
we only initialize once.  Move some consts into the namespace.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/399042
------------------------------------------------------------------------
r32213 | jam@chromium.org | 2009-11-17 22:41:08 +0100 (Tue, 17 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/strict_transport_security_persister.cc
   M /trunk/src/chrome/browser/strict_transport_security_persister.h
   M /trunk/src/views/widget/aero_tooltip_manager.cc
   M /trunk/src/views/widget/aero_tooltip_manager.h

Fix race conditions where an object's constructor uses PostTask on itself.  This isn't safe since the posted task can execute before the constructor returns, leading to destruction of the object.

BUG=27944
Review URL: http://codereview.chromium.org/399016
------------------------------------------------------------------------
r32212 | pkasting@chromium.org | 2009-11-17 22:38:10 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Fix a problem where queued checks' clients would never be called back if when the check finally ran it passed the prefix check (the common case).  This was made more noticeable by r31950 since before that things wouldn't be queued unless we were resetting the database (rare) or caught a narrow timing window where |database_| was true but |database_loaded_| was false; after that, we could get this on startup, and with r32136, after closing the database as well.

This also removes some unnecessary bits now that we don't queue during a reset.

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/402004
------------------------------------------------------------------------
r32208 | pkasting@chromium.org | 2009-11-17 22:18:33 +0100 (Tue, 17 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Allow multiselection deletion of engines in the Manage Search Engines dialog.  Original patch by Thiago Farina (see http://codereview.chromium.org/402020 ), r=me, tweaked.

BUG=16842
TEST=Select multiple engines.  "Remove" should be enabled iff the selected set does not include the default engine.
------------------------------------------------------------------------
r32205 | jam@chromium.org | 2009-11-17 21:56:01 +0100 (Tue, 17 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_launcher.cc

Fix build break on Mac release.

BUG=6844
TBR=darin
Review URL: http://codereview.chromium.org/405006
------------------------------------------------------------------------
r32204 | jam@chromium.org | 2009-11-17 21:24:49 +0100 (Tue, 17 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

fix include order
------------------------------------------------------------------------
r32203 | jam@chromium.org | 2009-11-17 21:23:57 +0100 (Tue, 17 Nov 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/child_process_launcher.cc
   A /trunk/src/chrome/browser/child_process_launcher.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Launch processes asynchronously so as not to block the UI thread.  For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change.

BUG=6844
Review URL: http://codereview.chromium.org/397002
------------------------------------------------------------------------
r32197 | ben@chromium.org | 2009-11-17 20:12:08 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   D /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   D /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   D /trunk/src/chrome/browser/views/tabs/tab_2.cc
   D /trunk/src/chrome/browser/views/tabs/tab_2.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   D /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   D /trunk/src/chrome/browser/views/tabs/tab_strip_2.h
   D /trunk/src/chrome/browser/views/tabs/tab_strip_wrapper.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/views/animator.cc
   D /trunk/src/views/animator.h
   M /trunk/src/views/views.gyp

Remove new tabstrip code. Going to try doing this a different way.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/400005
------------------------------------------------------------------------
r32194 | evan@chromium.org | 2009-11-17 20:04:12 +0100 (Tue, 17 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_views.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chromeos/external_metrics.cc
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h
   M /trunk/src/chrome/browser/options_page_base.cc
   M /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/new_browser_window_widget.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Use plain strings instead of wstrings for UMA actions

git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/

This cuts more than 10k off my binary.  Which is nothing compared
to the size of the binary, but that's a whole lot of zero bytes!
This is less code this way anyway.

Review URL: http://codereview.chromium.org/399026
------------------------------------------------------------------------
r32191 | oshima@chromium.org | 2009-11-17 19:58:14 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc

ViewIDTest.Basic fix
 FindBar has to be created before the test.

BUG=26192
TEST=Run browser_tests

Review URL: http://codereview.chromium.org/387060
------------------------------------------------------------------------
r32189 | sky@chromium.org | 2009-11-17 19:50:17 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Attempt 2 at fixing white flash in switching between ntp and non-ntp.

BUG=27898
TEST=make sure tab switching on chrome os doesn't result in any visual
artifacts, especially when switching between ntp and non-ntp.

Review URL: http://codereview.chromium.org/404005
------------------------------------------------------------------------
r32188 | ananta@chromium.org | 2009-11-17 19:48:43 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

The AutomationMsg_SetCookie IPC should be channeled to the automation cookie store for ChromeFrame. This 
ensures that the automation client would receive a callback when the cookie is set on the store.

Bug=none

Review URL: http://codereview.chromium.org/403004
------------------------------------------------------------------------
r32187 | chocobo@chromium.org | 2009-11-17 19:45:14 +0100 (Tue, 17 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Fix crashing bug due to browser being NULL.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/400015
------------------------------------------------------------------------
r32186 | evan@chromium.org | 2009-11-17 19:40:18 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc

sync: add some "static"s to functions

This is needed to work around a gcc bug when building with -Os.
But it's more correct anyway.

Review URL: http://codereview.chromium.org/395026
------------------------------------------------------------------------
r32182 | erikkay@chromium.org | 2009-11-17 19:14:11 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Disable all of ToolbarControllerTest due to crashiness.

BUG=27920
TBR=idana

Review URL: http://codereview.chromium.org/400013
------------------------------------------------------------------------
r32176 | mirandac@chromium.org | 2009-11-17 18:19:44 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Tweaks and fixes for NTP extension promo.

Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.

BUG= 27814, 25258, 27815
TEST= see various bugs.
Review URL: http://codereview.chromium.org/385135
------------------------------------------------------------------------
r32171 | apavlov@chromium.org | 2009-11-17 16:25:07 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/manual_tests/element-styles.html

DevTools: Element styles manual test

BUG=none
TEST=this

Review URL: http://codereview.chromium.org/399034
------------------------------------------------------------------------
r32166 | hbono@chromium.org | 2009-11-17 10:00:12 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

A quick fix for Issue 3798.
Some Chinese IMEs insert whitespace characters (U+3000) instead of input characters while they are composing text. So, trimming these whitespace characters (at the beginning of an omnibox) prevents from inputting text on these IMEs. As a quick fix, this change prevent our AutocompleteEditViewWin::OnImeComposition() from starting auto-complete when an omnibox starts with whitespace characters.

BUG=3798
TEST=Type "google.com" on Omnibox, type "Tab" to start tab-to-search, type 'nihao' on Microsoft New Phonetic IME, and see we can see Chinese characters in the omnibox. 
Review URL: http://codereview.chromium.org/391070
------------------------------------------------------------------------
r32165 | xiyuan@chromium.org | 2009-11-17 09:39:51 +0100 (Tue, 17 Nov 2009) | 28 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   A /trunk/src/chrome/browser/views/create_application_shortcut_view.cc
   A /trunk/src/chrome/browser/views/create_application_shortcut_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/web_applications
   A /trunk/src/chrome/browser/web_applications/web_app.cc
   A /trunk/src/chrome/browser/web_applications/web_app.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/test_browser_window.h

Implement web app shortcuts natively per issue 25528

- Implement a CreateApplicationShortcutView similar to the current Gears-based one;
- Add a few profile prefs to persist user's last checked shortcut locations
- Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications"
  in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls
  file_util code to creates shortcut on Windows;
- Add Win7 taskbar pin/unpin support function to file_util;
- Update TabContents to replace gears with new code;

Note:
- Gears dialog is modaless but this one is a modal dialog.
- Gear's icon store is not migrated because gears icons
  could still be used by shortcuts created by gears and
  thus we could not delete them even after migration. And we
  are not using the local ico files in the dialog even if
  they exists.
- New CreateApplicationShortcutView is included when
  TOOLKIT_VIEW is defined. However on platforms other
  than Windows, the actual CreateShortCut code is not
  implemented. Right now it calls ShellIntegration's
  CreateDesktopShort if OS_LINUX is defined and
  NOTREACHED() for other platforms.

BUG=25528
TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7.

Review URL: http://codereview.chromium.org/372012
------------------------------------------------------------------------
r32164 | xiyuan@chromium.org | 2009-11-17 09:17:24 +0100 (Tue, 17 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Apply andrewbunn's patch for issue 19358

The patch gives non-webapp chrome an app id so that win7 taskbar group the icons correctly. That is, webapp icons are grouped together based on app name and all chrome windows are grouped together.

BUG=19358
TEST=verify fix for issue 19358

Review URL: http://codereview.chromium.org/385120
------------------------------------------------------------------------
r32163 | aa@chromium.org | 2009-11-17 08:06:16 +0100 (Tue, 17 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Add validation to extension packaging.

BUG=27685,27690

Review URL: http://codereview.chromium.org/398001
------------------------------------------------------------------------
r32162 | idana@chromium.org | 2009-11-17 08:05:41 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Disable ToolbarControllerTest.LoadingState which crashed a few times today.

BUG=27920
TEST=ToolbarControllerTest.LoadingState
TBR=dmaclach,erikkay

Review URL: http://codereview.chromium.org/403003
------------------------------------------------------------------------
r32160 | nick@chromium.org | 2009-11-17 07:53:18 +0100 (Tue, 17 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Re-enable the ServerChangeProcessing test.

Review URL: http://codereview.chromium.org/387066
------------------------------------------------------------------------
r32156 | jam@chromium.org | 2009-11-17 06:41:10 +0100 (Tue, 17 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc

Correct a typo.
Review URL: http://codereview.chromium.org/397009
------------------------------------------------------------------------
r32152 | sky@chromium.org | 2009-11-17 05:19:31 +0100 (Tue, 17 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Fixes painting bug in switching between ntp and non-ntp pages. Without
this code the bookmark bar's widget gets sized to 1x1 for a
layout/painting step and we get all sorts of painting artifacts. I
don't understand why that happens, but forcing a layout fixes it. I've
scoped this just to chrome os for now.

BUG=27898
TEST=make sure tab switching on chrome os doesn't result in any visual
artifacts, especially when switching between ntp and non-ntp.

Review URL: http://codereview.chromium.org/397018
------------------------------------------------------------------------
r32151 | mhm@chromium.org | 2009-11-17 05:17:13 +0100 (Tue, 17 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

[Linux] Hide fullscreen bubble when kiosk mode is active.

When chrome is ran in kiosk mode, the fullscreen bubble should be hidden. As well, I found a major variable name mixup in browerview.

BUG=27308
TEST=None

Review URL: http://codereview.chromium.org/385146
------------------------------------------------------------------------
r32143 | laforge@chromium.org | 2009-11-17 02:49:05 +0100 (Tue, 17 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Revert 32137 - Revert 32121  Fix crash.

BUG=27145,possibly others
TEST=See bug.

Review URL: http://codereview.chromium.org/399014

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/399021

TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/399024
------------------------------------------------------------------------
r32142 | dmaclach@chromium.org | 2009-11-17 02:32:52 +0100 (Tue, 17 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Get rid of DCHECK that was firing. The check itself is not 
completely necessary, and as it turns out we don't always get matching
exit/enter events.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/395025
------------------------------------------------------------------------
r32139 | erikkay@chromium.org | 2009-11-17 02:19:01 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Disable ToolbarControllerTest.Display which crashed 5 times today.

BUG=27920
TEST=ToolbarControllerTest.Display
TBR=dmaclach

Review URL: http://codereview.chromium.org/399022
------------------------------------------------------------------------
r32137 | erikkay@chromium.org | 2009-11-17 02:01:22 +0100 (Tue, 17 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Revert 32121 - Fix crash.

BUG=27145,possibly others
TEST=See bug.

Review URL: http://codereview.chromium.org/399014

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/399021
------------------------------------------------------------------------
r32136 | pkasting@chromium.org | 2009-11-17 01:48:53 +0100 (Tue, 17 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Add ability to close the Safe Browsing Service database and recreate it on the fly.

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/399006
------------------------------------------------------------------------
r32129 | estade@chromium.org | 2009-11-17 01:15:49 +0100 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cookies_tree_model_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/net/url_request_context_getter.h
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h

Spellchecker: Always destruct url request context getter on io thread.

To do this, we have to initiate downloads on the UI thread and don't hold onto a reference in the file thread.

BUG=27667

Review URL: http://codereview.chromium.org/387055
------------------------------------------------------------------------
r32127 | ananta@chromium.org | 2009-11-17 01:12:52 +0100 (Tue, 17 Nov 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc

amit, please review everything, jam please review the changes to the tab_contents and the
renderer_host sources.

Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab
container, which hosts ChromeFrame. This object was used to carry a custom URL request
context which was used to intercept HTTP requests and cookie requests issued by external
tabs.

However as the life time of the automation profile class depended on the lifetime of the external
tab container object this caused a number of crashes in objects which held on to the automation profile
pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser 
instance as the profile is deleted at the very end.

We can associate the automation URL request context with the underlying tab_contents which would
eventually percolate down to the resource message filter. Doing this would avoid the need for the
AutomationProfile class.

This CL achieves that.
Bug=27695,27662


Review URL: http://codereview.chromium.org/385117
------------------------------------------------------------------------
r32126 | tony@chromium.org | 2009-11-17 01:10:36 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Plumb through off the record state from the URL request to the
chrome url request data sources.  This will allow me to merge
IncognitoTabHTMLSource and NewTabHTMLSource and allow me clean
up DOMUIThemeSource, but those will be follow up changes.

Review URL: http://codereview.chromium.org/397019
------------------------------------------------------------------------
r32121 | thakis@chromium.org | 2009-11-17 00:30:05 +0100 (Tue, 17 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Fix crash.

BUG=27145,possibly others
TEST=See bug.

Review URL: http://codereview.chromium.org/399014
------------------------------------------------------------------------
r32120 | twiz@google.com | 2009-11-17 00:28:26 +0100 (Tue, 17 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.h
   A /trunk/src/chrome/browser/extensions/extension_popup_host.cc
   A /trunk/src/chrome/browser/extensions/extension_popup_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/experimental.popup.html
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html
   M /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband_popup.html

Refactoring of the chrome.experimental.popup API implementation to allow display of pop-ups for extensions viewed through a tab-contents view.I added a new class, ExtensionPopupHost.  This class implements the necessary environment for managing child popup windows from either an ExtensionHost, or an ExtensionDOMUI.  Note that this class is added as a member to ExtensionHost and ExtensionDOMUI.  

I decided to take this approach to prevent multiple inheritance of the NotificationObserver class:  Both ExtensionPopupHost and ExtensionHost must inherit from this class, and I was uncertain of how the system would behave wrt virtual inheritance.  Please comment on if I should have used the inheritance approach.

I also removed the customHandler tag (in extension_api.json) that I had added in the initial submission.  The arguments in the schema are now those that users of the API see.  The nodocs tags were also removed.

The api experimental.popup.getAnchorWindow() has been renamed to popup.getParentWindow, as per a suggestion from Erik K.

BUG=none
TEST=extension_popup_apitest.cc
Review URL: http://codereview.chromium.org/385061
------------------------------------------------------------------------
r32115 | erg@chromium.org | 2009-11-17 00:12:47 +0100 (Tue, 17 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm

Mac: Draw entire Bookmark Bar every time to match API expectations.

NtpBackgroundUtil::PaintBackgroundDetachedMode() expects to draw
the entire bookmark bar on every expose; all of its internal math
is based on the assumption that the incoming area is zero-based and
is the whole bookmark bar area.

TEST=(Repo instructions in bug)
BUG=25655

Review URL: http://codereview.chromium.org/401005
------------------------------------------------------------------------
r32113 | huanr@chromium.org | 2009-11-16 23:59:33 +0100 (Mon, 16 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   D /trunk/src/chrome/browser/history/visit_log.cc
   D /trunk/src/chrome/browser/history/visit_log.h
   D /trunk/src/chrome/browser/history/visit_log_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Removing the logging on history thread since the crash
is fixed.

BUG=16591
TEST = none

Review URL: http://codereview.chromium.org/384073
------------------------------------------------------------------------
r32112 | estade@chromium.org | 2009-11-16 23:55:17 +0100 (Mon, 16 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/ipc/ipc.gyp
   A /trunk/src/ipc/ipc_platform_file.h

reland 31875. Revert was:
------
Revert 31875 to see whether it fixes reliability bot.

BUG=25677
TEST=None
------

TBR=huanr
Review URL: http://codereview.chromium.org/397017
------------------------------------------------------------------------
r32108 | erikkay@chromium.org | 2009-11-16 23:34:35 +0100 (Mon, 16 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

BUG=27893
TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose
TBR=idana

disable test on Linux due to crashes

Review URL: http://codereview.chromium.org/391080
------------------------------------------------------------------------
r32106 | derat@chromium.org | 2009-11-16 23:25:28 +0100 (Mon, 16 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc

gtk: Fix button text in extension uninstall dialog.

BUG=27763

Review URL: http://codereview.chromium.org/400004
------------------------------------------------------------------------
r32105 | agl@chromium.org | 2009-11-16 23:20:44 +0100 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/base/simple_thread.cc
   M /trunk/src/chrome/browser/cancelable_request.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/net/http/http_auth_handler_ntlm_portable.cc

Linux: fix uninit warnings when building -Os.

http://codereview.chromium.org/401002
------------------------------------------------------------------------
r32104 | eroman@chromium.org | 2009-11-16 23:18:55 +0100 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/net/ocsp/nss_ocsp.cc
   M /trunk/src/net/ocsp/nss_ocsp.h

Move NULLing of OCSP context from UI thread to IO thread, to avoid possible races.

Review URL: http://codereview.chromium.org/391062
------------------------------------------------------------------------
r32103 | arv@chromium.org | 2009-11-16 23:16:31 +0100 (Mon, 16 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Make sure the notifier does not get focused after it was hidden.

BUG=27833

TEST=See bug


Review URL: http://codereview.chromium.org/387064
------------------------------------------------------------------------
r32096 | davemoore@chromium.org | 2009-11-16 22:48:41 +0100 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/resources/about_os_credits.html

add chromeos credits

Review URL: http://codereview.chromium.org/399012
------------------------------------------------------------------------
r32093 | evan@chromium.org | 2009-11-16 22:45:17 +0100 (Mon, 16 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Use GetSwitchValuePath.

BUG=24672
TEST=unit_tests
Patch by Thiago Farina <thiago.farina@gmail.com>.

Review URL: http://codereview.chromium.org/375016
------------------------------------------------------------------------
r32090 | phajdan.jr@chromium.org | 2009-11-16 22:39:50 +0100 (Mon, 16 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc

Fix intermittent DCHECK failure in BlacklistManagerTest.

Ensure correct shutdown of threads.

TEST=Covered by unit_tests.
BUG=27726

Review URL: http://codereview.chromium.org/384149
------------------------------------------------------------------------
r32089 | estade@chromium.org | 2009-11-16 22:30:07 +0100 (Mon, 16 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc

Spellchecker: call init *after* constructor.

This fixes the error where PostTask would post the task to the file thread and release its reference before the constructor returned.

credit for fix goes to jam@ and thestig@
Review URL: http://codereview.chromium.org/399011
------------------------------------------------------------------------
r32085 | estade@chromium.org | 2009-11-16 21:39:22 +0100 (Mon, 16 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/chrome.gyp

Port most of browser action apitest to linux.

BUG=27224

Review URL: http://codereview.chromium.org/385085
------------------------------------------------------------------------
r32074 | huanr@chromium.org | 2009-11-16 20:34:59 +0100 (Mon, 16 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/ipc/ipc.gyp
   D /trunk/src/ipc/ipc_platform_file.h

Revert 31875 to see whether it fixes reliability bot.

BUG=25677
TEST=None

Review URL: http://codereview.chromium.org/397014
------------------------------------------------------------------------
r32066 | apavlov@chromium.org | 2009-11-16 19:31:56 +0100 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/manual_tests/event-listeners.html

Add Event Listeners sidebar pane manual test

Review URL: http://codereview.chromium.org/391074
------------------------------------------------------------------------
r32056 | mnaganov@chromium.org | 2009-11-16 15:40:04 +0100 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/manual_tests/profiler-test-basic-grid-functionality.html
   A /trunk/src/chrome/browser/debugger/manual_tests/profiler-test-focus-and-exclude.html
   A /trunk/src/chrome/browser/debugger/manual_tests/resources/fib.js

DevTools: add 2 manual profiler tests.

Review URL: http://codereview.chromium.org/399002
------------------------------------------------------------------------
r32053 | pfeldman@chromium.org | 2009-11-16 14:02:20 +0100 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/manual_tests
   A /trunk/src/chrome/browser/debugger/manual_tests/console-call-line-numbers.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-exception-on-load.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-execution-while-paused.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-pause-on-else-statements.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-pause-on-for-in-statements.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-pause-on-for-statements.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-step-on-do-while-statements.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-step-on-for-in-statements.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-step-on-for-statements.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-step-on-while-statements.html
   A /trunk/src/chrome/browser/debugger/manual_tests/debugger-watch-expressions.html
   A /trunk/src/chrome/browser/debugger/manual_tests/dom-mutation.html
   A /trunk/src/chrome/browser/debugger/manual_tests/error-warning-count.html
   A /trunk/src/chrome/browser/debugger/manual_tests/highlight-nodes.html
   A /trunk/src/chrome/browser/debugger/manual_tests/highlight-source-line.html
   A /trunk/src/chrome/browser/debugger/manual_tests/resources
   A /trunk/src/chrome/browser/debugger/manual_tests/resources/loop-statements.js
   A /trunk/src/chrome/browser/debugger/manual_tests/resources/mutate-frame-2.html
   A /trunk/src/chrome/browser/debugger/manual_tests/resources/mutate-frame.html
   A /trunk/src/chrome/browser/debugger/manual_tests/resources/script-console-calls.js

DevTools: Add some devtools manual tests.

Review URL: http://codereview.chromium.org/385134
------------------------------------------------------------------------
r32037 | dmaclach@chromium.org | 2009-11-16 01:32:08 +0100 (Mon, 16 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm

Speeds up display bookmark animation as requested by thakis.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/384139
------------------------------------------------------------------------
r32034 | aa@chromium.org | 2009-11-16 00:26:25 +0100 (Mon, 16 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Minor text changes per Kathy's suggestions.

TBR=kathyw@chromium.org
------------------------------------------------------------------------
r32032 | jrg@chromium.org | 2009-11-15 21:13:57 +0100 (Sun, 15 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

TEST=new Chrome with bookmark folders visible in bar.
Create new window (Cmd-N).  Make sure folders there!

BUG=http://crbug.com/27774
	
Review URL: http://codereview.chromium.org/385130
------------------------------------------------------------------------
r32030 | jrg@chromium.org | 2009-11-15 20:26:52 +0100 (Sun, 15 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Fix multi-window bookmark bubble problem.

Also fix a "flash" where the bookmark bubble opened in the wrong spot
before jumping to the correct spot (hard to see).

BookmarkBubble.xib change: NOT initially visible.

BUG=http://crbug.com/27545

TEST=see bug (it's clear).

Review URL: http://codereview.chromium.org/391057
------------------------------------------------------------------------
r32029 | jrg@chromium.org | 2009-11-15 20:26:33 +0100 (Sun, 15 Nov 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_menu.h
   A /trunk/src/chrome/browser/cocoa/bookmark_menu.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_menu_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Fix "open all" on a folder node to open only 'marks in that folder,
not ALL all.  Make Delete and Rename enabled for folder context menu
(but disabled for "Other Bookmarks").

nib changes (related to the context menus):
- Telegate is the bookmark bar controller.
- Switched type from NSMenu to BookmarkMenu.

TEST=New window.  Create folder "empty" with nothing in it.  Create
folder "two" with 2 bookmarks in it.  Create a final bookmark in the
top level of the bar.
Context menu (right click) over all folders.
Make sure Delete and Rename enabled for folders but not "Other Bookmarks".
Make sure "Open All" (and friends) disabled over "empty", enabled over "two".
"Open All" on "two" --> see 2 opened.
"Open All" on the bar itself --> see 3 opened.
Ditto for "Open all in new window" and "open all in incognito window".
Create a new window.  In new window, make sure folders have context menus.

BUG=http://crbug.com/27522, http://crbug.com/27529

Review URL: http://codereview.chromium.org/391046
------------------------------------------------------------------------
r32027 | mirandac@chromium.org | 2009-11-15 20:19:30 +0100 (Sun, 15 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add message and image to NTP to promote extensions and bookmark sync.

BUG= 27393, 26744
TEST= promotional messages should show up on NTP.

Review URL: http://codereview.chromium.org/394005
------------------------------------------------------------------------
r32019 | mhm@chromium.org | 2009-11-15 04:22:17 +0100 (Sun, 15 Nov 2009) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   D /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h

Revert 32012-32017

git cl dcommit somehow committed all my local changes in cygwin

TBR=evan
BUG=none

Review URL: http://codereview.chromium.org/396006
------------------------------------------------------------------------
r32017 | mhm@chromium.org | 2009-11-15 03:47:10 +0100 (Sun, 15 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

fix nits
------------------------------------------------------------------------
r32016 | mhm@chromium.org | 2009-11-15 03:47:04 +0100 (Sun, 15 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

small mistake
------------------------------------------------------------------------
r32015 | mhm@chromium.org | 2009-11-15 03:46:58 +0100 (Sun, 15 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   M /trunk/src/chrome/browser/views/accessible_toolbar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix nits
------------------------------------------------------------------------
r32014 | mhm@chromium.org | 2009-11-15 03:46:52 +0100 (Sun, 15 Nov 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/views/accessible_toolbar_view.cc
   A /trunk/src/chrome/browser/views/accessible_toolbar_view.h

Rebase
------------------------------------------------------------------------
r32013 | mhm@chromium.org | 2009-11-15 03:46:46 +0100 (Sun, 15 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Remove explicit
------------------------------------------------------------------------
r32012 | mhm@chromium.org | 2009-11-15 03:46:31 +0100 (Sun, 15 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h

rebase
------------------------------------------------------------------------
r32008 | erikkay@chromium.org | 2009-11-14 23:05:47 +0100 (Sat, 14 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc

Mostly fixes black flashing that happens during popup resize.

BUG=25459
TEST=none
TBR=amit

Review URL: http://codereview.chromium.org/394004
------------------------------------------------------------------------
r32006 | dmaclach@chromium.org | 2009-11-14 17:09:06 +0100 (Sat, 14 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm

Makes InfoBubbleWindow close animations work correctly with regards to
activating other windows post-close correctly.

BUG=27711
TEST=See repro steps in bug.

Review URL: http://codereview.chromium.org/385119
------------------------------------------------------------------------
r32002 | dmaclach@chromium.org | 2009-11-14 08:04:36 +0100 (Sat, 14 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/theme_install_bubble_view.mm

Keeps the "loading..." text centered on the screen when you resize the window.

BUG=27706
TEST=see bug description

Review URL: http://codereview.chromium.org/385118
------------------------------------------------------------------------
r32001 | dumi@chromium.org | 2009-11-14 07:37:19 +0100 (Sat, 14 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Revert 31999 - Enable HTML5 DBs by default (except in incognito mode).

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/397001

TBR=michael@chromium.org

Review URL: http://codereview.chromium.org/397004
------------------------------------------------------------------------
r31999 | dumi@chromium.org | 2009-11-14 06:31:14 +0100 (Sat, 14 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Enable HTML5 DBs by default (except in incognito mode).

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/397001
------------------------------------------------------------------------
r31996 | dumi@chromium.org | 2009-11-14 05:53:10 +0100 (Sat, 14 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Re-enable the ExtensionApiTest.Storage test.

TEST=none
BUG=27216


Review URL: http://codereview.chromium.org/394017
------------------------------------------------------------------------
r31990 | johnnyg@chromium.org | 2009-11-14 03:48:01 +0100 (Sat, 14 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/notifications_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Remove (actually, reverse meaning of) command line flag for desktop notifications, so that is is available by default in Windows.

Security review at http://b/issue?id=2161143

BUG=25975
TEST=none

Review URL: http://codereview.chromium.org/391064
------------------------------------------------------------------------
r31989 | johnnyg@chromium.org | 2009-11-14 03:32:11 +0100 (Sat, 14 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc

Escape javascript going into text notifications.

BUG=27674
TEST=included

Review URL: http://codereview.chromium.org/386035
------------------------------------------------------------------------
r31986 | thakis@chromium.org | 2009-11-14 03:03:08 +0100 (Sat, 14 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Mac: Let arrow keys move caret in IME mode.

BUG=26869
TEST=Activate Kotoeri, smash keys, confirm that arrow keys move caret. Confirm that rest of IME still works (hah!).

Review URL: http://codereview.chromium.org/386032
------------------------------------------------------------------------
r31984 | derat@chromium.org | 2009-11-14 02:18:00 +0100 (Sat, 14 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

gtk: Hide the status bubble when the mouse nears it.

This isn't as slick as other platforms, in that the bubble
just slides down and gets cropped instead of sliding down out
of the browser window -- doing the latter will probably
require reparenting the bubble into its own window when we
want to move it.

BUG=18311
TEST=ran "nc -l -p 8080", went to localhost:8080, and made sure that the bubble ran away with both LTR and RTL languages

Review URL: http://codereview.chromium.org/392007
------------------------------------------------------------------------
r31983 | thakis@chromium.org | 2009-11-14 02:17:04 +0100 (Sat, 14 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

cleanup: rename variable |resize_layout_scheduled_| to |needs_resize_layout_|.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/391042
Patch from tfarina.
------------------------------------------------------------------------
r31982 | atwilson@chromium.org | 2009-11-14 02:11:56 +0100 (Sat, 14 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Turn on shared workers by default
------------------------------------------------------------------------
r31981 | ananta@chromium.org | 2009-11-14 02:06:21 +0100 (Sat, 14 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Initialize the host_renderer_id and host_render_view_id in the resource dispatcher unit test.
This fixes a UMR in resource_dispatcher host.

Bug=27649

Review URL: http://codereview.chromium.org/395004
------------------------------------------------------------------------
r31979 | pkasting@chromium.org | 2009-11-14 02:02:37 +0100 (Sat, 14 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/scoped_bool.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

More safe browsing cleanup work:
* Remove |resetting_| from the safe browsing service, it doesn't do anything useful.
* Add appropriate locks in a few places in the database that were missing them.
* Prevent potential infinite recursion in the database at one spot.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391060
------------------------------------------------------------------------
r31977 | viettrungluu@chromium.org | 2009-11-14 02:01:17 +0100 (Sat, 14 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/animatable_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/toolbar_compressable.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/view_resizer_pong.mm
   M /trunk/src/chrome/chrome.gyp

Mac: Animate the bookmark bar showing/hiding.

There's a huge refactoring of the bookmark bar controller in this CL, so that animation-related code is in only a few places (instead of scattered all over the place).

Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from AnimatableView, I had to hook up its delegate_ member to File's Owner (i.e., the BookmarkBarController).

Not yet implemented: morphing between the detached bar (on the NTP) and anything else.

BUG=25600
TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch it animate.

Review URL: http://codereview.chromium.org/384105
------------------------------------------------------------------------
r31976 | dmaclach@chromium.org | 2009-11-14 01:56:34 +0100 (Sat, 14 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.h
   M /trunk/src/chrome/browser/cocoa/info_bubble_window.mm

Causes all info bubbles to fade in and out with an animation instead of just
appearing.

Change to BookmarkBubble.xib was to make the window not show on creation.
It will have more mods to it because of switching to IB on Snow Leopard.

BUG=27464
TEST=Make the bookmark bubble appear and disappear by clicking on the star.

Review URL: http://codereview.chromium.org/389027
------------------------------------------------------------------------
r31973 | akalin@chromium.org | 2009-11-14 01:35:46 +0100 (Sat, 14 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm

Implemented ShowOptionsWindow() for OS X (except the highlighting
of the given group).

Refactored PreferencesWindowController a bit.

Made preferences_window_controller_unittest.mm use CocoaTest instead of CocoaTestHelper and reenabled disabled test which was crashing (likely due to interactions with CocoaTestHelper).

BUG=23073
TEST=manually,trybots

Review URL: http://codereview.chromium.org/391050
------------------------------------------------------------------------
r31968 | idana@chromium.org | 2009-11-14 01:21:02 +0100 (Sat, 14 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Moved the various Google Accounts URLs out of gaia_login.html and into sync_setup_wizard.cc
so that we can append the language code as a CGI parameter based on the locale.

BUG=26385
TEST=Make sure links on the sync login dialog open pages in the same language as the browser language.

Review URL: http://codereview.chromium.org/385103
------------------------------------------------------------------------
r31967 | rohitrao@chromium.org | 2009-11-14 01:13:35 +0100 (Sat, 14 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

[Mac] Fix weird layout issues when dragging a tab from a large screen to a small one.

BUG=http://crbug.com/27652
TEST=With two monitors of different vertical sizes connected, make a chrome window on the larger monitor, as tall as the monitor.  Drag it over to the smaller monitor and drop it.  The window should not re-layout weirdly during the drag and should continue to have a tab strip after the drop.
Review URL: http://codereview.chromium.org/385106
------------------------------------------------------------------------
r31966 | brettw@chromium.org | 2009-11-14 00:56:25 +0100 (Sat, 14 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

WebKit merge 50932:50947.

This also includes http://codereview.chromium.org/394008 which restores
interactive tests for devtools.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/386029
------------------------------------------------------------------------
r31965 | levin@chromium.org | 2009-11-14 00:47:14 +0100 (Sat, 14 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Revert 31960  -- Bookmark tests seemed to fail after this went in.

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/395010
------------------------------------------------------------------------
r31960 | tim@chromium.org | 2009-11-13 23:27:40 +0100 (Fri, 13 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Makes the chevron throb after a user sync'ed his bookmarks (if the overflow menu is shown)
This also makes the chevron throb when no bookmarks is added during a sync and merge.

BUG=24306
TEST=sync with over 10 bookmarks in the bookmark bar so that the chevron is visible.

Patch by Bruno Calvignac<BrunoCalvignac@gmail.com>
Original Review: http://codereview.chromium.org/306054/show

Review URL: http://codereview.chromium.org/395005
------------------------------------------------------------------------
r31958 | asargent@chromium.org | 2009-11-13 23:22:55 +0100 (Fri, 13 Nov 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/stubs_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   A /trunk/src/chrome/test/data/extensions/api_test/stubs
   A /trunk/src/chrome/test/data/extensions/api_test/stubs/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/stubs/content_script.js
   A /trunk/src/chrome/test/data/extensions/api_test/stubs/manifest.json

Add stub functions for chrome.* APIs in content scripts. 

Most of the extensions API is not supported in content scripts for security 
purposes. Instead the typical pattern is to use messaging between content 
scripts and a background page which executes them on behalf of the script.
This is not immediately obvious to many extension developers, so this
change adds an error message to help them better understand what's going on.


BUG=26128
TEST=Try writing a content script that uses some of the extensions API stuff 
in chrome.tabs, chrome.windows, etc. You should see errors in the console 
telling you that it isn't supported in content scripts.


Review URL: http://codereview.chromium.org/366024
------------------------------------------------------------------------
r31956 | dmaclach@chromium.org | 2009-11-13 23:11:50 +0100 (Fri, 13 Nov 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Attempt to get a fix and performance back.

Originally submitted as:
http://codereview.chromium.org/386021

Reverted with:
http://codereview.chromium.org/384100

This new version only creates the tracking regions (and the associated
notifications) if the mouse is actually in the tab strip. Hoping this should
improve our startup performance.

BUG=27458, 13208, 21448
TEST=Create a pile of tabs. 
     Select a middle one. 
     Put your cursor in some other tab. 
     Hit cmd-w a couple of times 
     Watch to make sure highlights occur correctly in both the tabs and the 
     close buttons.

Review URL: http://codereview.chromium.org/385102
------------------------------------------------------------------------
r31955 | mpcomplete@chromium.org | 2009-11-13 23:06:41 +0100 (Fri, 13 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper_win.cc

Add an "extension" process type, which mostly gets treated as a renderer everywhere.

BUG=27163

Review URL: http://codereview.chromium.org/384108
------------------------------------------------------------------------
r31953 | johnnyg@chromium.org | 2009-11-13 23:04:58 +0100 (Fri, 13 Nov 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/notifications/notifications_uitest.cc (from /trunk/src/chrome/browser/notifications/notifications_uitest.cc:31839)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/renderer/notification_provider.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/notifications
   A /trunk/src/chrome/test/data/notifications/notifications_request_function.html
   A /trunk/src/chrome/test/data/notifications/notifications_request_inline.html

Notifications permission infobar should only be shown in response to a user gesture, not arbitrary script.

Experimental fix for UI test, so checking in flaky at first to see if I have it...

BUG=27215
TEST=included

Committed as r31839... and reverted.
Review URL: http://codereview.chromium.org/387011
------------------------------------------------------------------------
r31952 | rvargas@google.com | 2009-11-13 23:00:16 +0100 (Fri, 13 Nov 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos/external_metrics.cc
   A /trunk/src/chrome/browser/chromeos/external_metrics.h
   A /trunk/src/chrome/browser/chromeos/external_metrics_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   D /trunk/src/chrome/browser/metrics/system_metrics_logger.h
   D /trunk/src/chrome/browser/metrics/system_metrics_logger_impl.cc
   D /trunk/src/chrome/browser/metrics/system_metrics_logger_impl.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/chrome.gyp

Use Chrome to transport Chrome OS metrics. 
Chrome periodically reads the content of a well-know file, 
and parses it into name-value pairs, each representing a 
Chrome OS metrics event. The events are then logged using 
the normal UMA mechanism. The file is then truncated to 
zero size. Chrome uses flock() to synchronize accesses 
to the file. 
BUG=none 
TEST=compiled and run Linux and Chrome OS versions. 
Verified that uploaded Chrome OS events appear in about:histograms. 
Also external_metrics_unittest.cc tests the collection of metrics 
messages from the well-known file.

patch written by semenzato_google.com
original code review: http://codereview.chromium.org/378013
(plus http://codereview.chromium.org/346041)


Review URL: http://codereview.chromium.org/394010
------------------------------------------------------------------------
r31951 | wtc@chromium.org | 2009-11-13 22:54:55 +0100 (Fri, 13 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.h
   M /trunk/src/webkit/glue/media/simple_data_source.cc
   M /trunk/src/webkit/glue/media/simple_data_source.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Propagate the "first party for cookies" from WebKit to the network stack
when we follow a redirect, because WebKit's
MainResourceLoader::willSendRequest method may change the "first party for
cookies" URL of the resource request.

R=abarth
BUG=25133
TEST=In Options menu, change cookie policy to "Accept cookies only from
sites I visit" and then follow the instructions in issue 25133 comment 20.
Review URL: http://codereview.chromium.org/385024
------------------------------------------------------------------------
r31950 | pkasting@chromium.org | 2009-11-13 22:53:26 +0100 (Fri, 13 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Simplify the SafeBrowsingService logic some:

* |database_loaded_| was entirely unnecessary.  The only ways in which checking it differed from checking |database_| were that it took longer to be set, and if true it meant that ProtocolManager::Initialize() had been called.  Erik and I determined that ProtocolManager::Initialize() was safe to call irrespective of whether the database had finished loading, and that this didn't add additional network burden in the case of a corrupt/unavailable database (especially since in those cases |database_loaded_| would still have been set true).

* |resetting_| can be set to false on the db thread, saving a little bit of code (due to a reorg) and allowing callers to proceed immediately when they happen to call the IO thread before the db thread calls back to it after finishing a reset.

I also made CheckUrl() queue the request when |database_| is NULL instead of just dropping it.  This seems more correct given that |database_| is guaranteed to eventually become non-NULL, so this means we won't skip checking requests that happen right during startup.  I am a bit concerned that this means we may slow startup by delaying all the network requests until the safe browsing DB spins up.  Feedback desired.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/384110
------------------------------------------------------------------------
r31945 | finnur@chromium.org | 2009-11-13 22:17:32 +0100 (Fri, 13 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized/chrome-16.png
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized/manifest.json
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized_pa
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized_pa/background.html
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized_pa/chrome-16.png
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized_pa/manifest.json
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized_pa/script.js
   A /trunk/src/chrome/test/data/extensions/browsertest/title_localized_pa/simple.html

Support localization for browser actions and page action
tooltips.

BUG=25349
TEST=Browser test added.

Review URL: http://codereview.chromium.org/385096
------------------------------------------------------------------------
r31943 | munjal@chromium.org | 2009-11-13 22:06:10 +0100 (Fri, 13 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc

Fix crash described in 27580 by telling bookmark model to remove
a node *after* disassocating from the maps.

BUG=27580

Review URL: http://codereview.chromium.org/391056
------------------------------------------------------------------------
r31941 | jcampan@chromium.org | 2009-11-13 21:56:15 +0100 (Fri, 13 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix for a bug where navigating from the NTP, to an SSL interstitial and then
a malware interstitial, the location bar would be empty (instead of showing
the malware URL).

This happens because when the second interstitial is shown,
TabContents::GetDOMUIForCurrentState() thinks the current DOMUI is the NTP
one, and therefore does not show the URL.
Instead of messing with the complicated logic of GetDOMUIForCurrentState(),
I made us always show the URL for interstitial, as it should be the case.

BUG=26082
TEST=See bug steps. Also make sure navigating to SLL and malware interstitial
     works as expected and that the right URL is displayed everytime. Test
     that clickicng Continue/Revert as well as navigating from an interstitial
     works and that the right URL is displayed.

Review URL: http://codereview.chromium.org/384013
------------------------------------------------------------------------
r31934 | scherkus@chromium.org | 2009-11-13 21:02:43 +0100 (Fri, 13 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Disable ResourceDispatcherHostTest.Cancel due to unitialized memory read caught by purify.

BUG=27649
TEST=n/a
TBR=ananta

Review URL: http://codereview.chromium.org/387050

------------------------------------------------------------------------
r31932 | erg@google.com | 2009-11-13 20:56:17 +0100 (Fri, 13 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.h
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autofill/autofill_field.h
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider_list.h
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.h
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/debugger/debugger_host.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_item_model.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/download/download_started_animation.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/in_memory_database.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/page_usage_data.h
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_linux.h
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/language_combobox_model.h
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/memory_purger.h
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_response.h
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/user_metrics.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/net/test_url_fetcher_factory.h
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/net/url_fetcher_protect.h
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/net/url_request_failed_dns_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.h
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h
   M /trunk/src/chrome/browser/omnibox_search_hint.h
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/parsers/metadata_parser.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_factory.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_manager.h
   M /trunk/src/chrome/browser/password_manager/ie7_password.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   D /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   M /trunk/src/chrome/browser/password_manager/password_store_kwallet.h
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blocked_response.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/strict_transport_security_persister.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/notifier/base/fastalloc.h
   M /trunk/src/chrome/browser/sync/notifier/base/static_assert.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/browser/views/constrained_window_win.h
   M /trunk/src/chrome/browser/views/dropdown_bar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.h
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   D /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   D /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.h
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/grid.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_gtk.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.h
   M /trunk/src/chrome/browser/views/tabs/tab_2.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.h
   M /trunk/src/chrome/browser/views/theme_helpers.h
   M /trunk/src/chrome/browser/views/uninstall_view.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/visitedlink_event_listener.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_error_reporter.h
   M /trunk/src/chrome/common/extensions/extension_error_utils.h
   M /trunk/src/chrome/common/gears_api.h
   M /trunk/src/chrome/common/important_file_writer.h
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/libxml_utils.cc
   M /trunk/src/chrome/common/logging_chrome.h
   M /trunk/src/chrome/common/mru_cache.h
   M /trunk/src/chrome/common/net/dns.h
   M /trunk/src/chrome/common/net/socket_stream.h
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/property_bag.h
   M /trunk/src/chrome/common/ref_counted_util.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/sqlite_compiled_statement.h
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/common/thumbnail_score.h
   M /trunk/src/chrome/common/visitedlink_common.cc
   M /trunk/src/chrome/common/visitedlink_common.h
   M /trunk/src/chrome/common/web_resource/web_resource_unpacker.h
   M /trunk/src/chrome/common/win_safe_util.h
   M /trunk/src/chrome/installer/gcapi/gcapi.h
   M /trunk/src/chrome/installer/mini_installer/mini_installer.h
   M /trunk/src/chrome/installer/mini_installer/pe_resource.h
   M /trunk/src/chrome/installer/setup/setup_util.h
   M /trunk/src/chrome/installer/util/helper.h
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/lzma_util.h
   M /trunk/src/chrome/installer/util/version.h
   M /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/js_only_v8_extensions.h
   M /trunk/src/chrome/renderer/external_extension.cc
   M /trunk/src/chrome/renderer/external_extension.h
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.h
   M /trunk/src/chrome/renderer/localized_error.h
   M /trunk/src/chrome/renderer/net/render_dns_master.h
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate.h
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/renderer_web_database_observer.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/renderer/websharedworkerrepository_impl.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_handle_tracker.h
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.cc
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.cc
   M /trunk/src/chrome/test/reliability/page_load_test.h
   M /trunk/src/chrome/test/reliability/reliability_test_suite.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h
   M /trunk/src/chrome/test/test_launcher/test_runner.h
   M /trunk/src/chrome/test/test_notification_tracker.h
   M /trunk/src/chrome/tools/convert_dict/aff_reader.h
   M /trunk/src/chrome/tools/convert_dict/dic_reader.h
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.h
   M /trunk/src/chrome/tools/crash_service/crash_service.h
   M /trunk/src/chrome/worker/nativewebworker_impl.h
   M /trunk/src/chrome/worker/nativewebworker_stub.h
   M /trunk/src/chrome/worker/websharedworker_stub.h
   M /trunk/src/chrome/worker/webworker_stub.h
   M /trunk/src/chrome/worker/webworker_stub_base.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h

Fixes almost all of the rest of lint errors in the chrome/ directory (minus the really hard ones which will need actual review instead of rubber-stamping.)

Review URL: http://codereview.chromium.org/386026
------------------------------------------------------------------------
r31931 | jianli@chromium.org | 2009-11-13 20:45:58 +0100 (Fri, 13 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc

Fix the problem that file URL is not converted to file path in drag-and-drop on Linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/385100
------------------------------------------------------------------------
r31930 | munjal@chromium.org | 2009-11-13 20:40:59 +0100 (Fri, 13 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/path_name_cmp.h
   M /trunk/src/chrome/browser/sync/util/character_set_converters.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/character_set_converters_unittest.cc
   M /trunk/src/chrome/browser/sync/util/crypto_helpers.cc
   M /trunk/src/chrome/browser/sync/util/crypto_helpers.h
   M /trunk/src/chrome/browser/sync/util/crypto_helpers_unittest.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.h
   M /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_win.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Part 1 of removing PathSTring. I scrubbed files that are not
in chron's CL to avoid merge.

Review URL: http://codereview.chromium.org/393011
------------------------------------------------------------------------
r31925 | jam@chromium.org | 2009-11-13 20:19:47 +0100 (Fri, 13 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc

Note: purify and valgrind suppressions already exist.  If the purify expression isn't being used, something else is wrong.

Revert 31914 - Disable ChromeThreadTest.NotReleasedIfTargetThreadNonExistent until suppression is added.

BUG=27630
TEST=n/a
TBR=scherkus

Review URL: http://codereview.chromium.org/385095


TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/384124
------------------------------------------------------------------------
r31924 | ben@chromium.org | 2009-11-13 20:11:55 +0100 (Fri, 13 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_dialogs.h

Fix crash by using correct type in class decl.

Patch by Std.Denis.

http://crbug.com/27291
TEST=Open fonts and languages dialog box and click OK. Should not crash.

Review URL: http://codereview.chromium.org/384123
------------------------------------------------------------------------
r31922 | jam@chromium.org | 2009-11-13 19:57:46 +0100 (Fri, 13 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/child_process_security_policy_browser_test.cc
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Small clean-up to not expose base::Process from RenderProcesHost, and instead only expose base::ProcessHandle.  Precursor to moving process startup off the UI thread.
Review URL: http://codereview.chromium.org/387047
------------------------------------------------------------------------
r31921 | jam@chromium.org | 2009-11-13 19:57:43 +0100 (Fri, 13 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Remove the UMA stats for whether the renderer was in a new desktop or not.

Review URL: http://codereview.chromium.org/391045
------------------------------------------------------------------------
r31920 | thakis@chromium.org | 2009-11-13 19:44:21 +0100 (Fri, 13 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.h
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Mac: Only show one per-tab sheet at a time per tab.

BUG=26900
TEST=Go to http://www/~thakis/cgi-bin/test.html . Test that two sheets show up (the first expects "u" as user and no pass, the other "v" and no pass). The first sheet appears immediately, the second after 2 seconds. Try entering u for the first faster than 2 seconds and switch tabs, when coming back to the original tab, the 2nd sheet should wait for you. Try closing the window and the tab while a sheet is showing, both when the tab with the sheet is in the background and in the foreground.

Review URL: http://codereview.chromium.org/384113
------------------------------------------------------------------------
r31917 | scherkus@chromium.org | 2009-11-13 19:09:52 +0100 (Fri, 13 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Disable ProfileSyncServiceTest_ServerChangeProcessing due to purify error.

BUG=27630
TEST=n/a
TBR=nick

Review URL: http://codereview.chromium.org/393012

------------------------------------------------------------------------
r31914 | scherkus@chromium.org | 2009-11-13 18:42:10 +0100 (Fri, 13 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc

Disable ChromeThreadTest.NotReleasedIfTargetThreadNonExistent until suppression is added.

BUG=27630
TEST=n/a
TBR=jam

Review URL: http://codereview.chromium.org/385095

------------------------------------------------------------------------
r31913 | brettw@chromium.org | 2009-11-13 18:35:35 +0100 (Fri, 13 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/mount_library.cc
   M /trunk/src/chrome/browser/chromeos/mount_library.h

Rename loaded() to EnsureLoaded() to match my previous change.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391053
------------------------------------------------------------------------
r31911 | brettw@chromium.org | 2009-11-13 18:04:42 +0100 (Fri, 13 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_library.h
   M /trunk/src/chrome/browser/chromeos/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/power_library.cc
   M /trunk/src/chrome/browser/chromeos/power_library.h
   M /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/synaptics_library.cc
   M /trunk/src/chrome/browser/chromeos/synaptics_library.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Write a test for loading libcros.so on startup of Chrome. You just pass the
--test-load-libcros on the command line. The browser will exit immediately and
the error code (and error messages) will indicate success or failure.

I also renamed loaded() static functions related to loading this library. These
are not simple getters since they will actually load the library if its not
loaded yet. I renamed it to EnsureLoaded.

TEST=This is a test
BUG=none
Review URL: http://codereview.chromium.org/387014
------------------------------------------------------------------------
r31907 | thakis@chromium.org | 2009-11-13 17:44:16 +0100 (Fri, 13 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_cell.h
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Draw download item background like windows does if a theme is installed.

BUG=27221
TEST=Download something, install theme. Download item should look different.

Review URL: http://codereview.chromium.org/384115
------------------------------------------------------------------------
r31906 | mirandac@chromium.org | 2009-11-13 16:51:10 +0100 (Fri, 13 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ReportBug.xib
   M /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm

Fixes for Report Bug Dialog:
* Honor "send screenshot" checkbox
* Save bug description and send screenshot state if user chooses "phishing report" function (that disables both); restore if the user goes back to a non-phishing bug.
* Make bug report give consistent and correct values for bug type.

BUG= 27283, 27282, 27281
TEST= Fill in data in bug description, toggle send screenshot "on". Move between "phishing" and non-phishing reports before sending. Note that description goes away and reappears appropriately.
 
Review URL: http://codereview.chromium.org/385047
------------------------------------------------------------------------
r31901 | levin@chromium.org | 2009-11-13 12:25:40 +0100 (Fri, 13 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disabling some failing tests after the recent WebKit roll.

TBR=pfeldman@chromium.org
TEST=None
BUG=27603

Review URL: http://codereview.chromium.org/385090
------------------------------------------------------------------------
r31897 | aa@chromium.org | 2009-11-13 10:47:51 +0100 (Fri, 13 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Load default browser action icons only once per-window. This
also changes the loading logic to be just like the GTK port,
because it was nicer, and because it is nice for them to be
parallel as much as possible.

It would be better to only load this icon once per application
session, but that would require something fancier.

BUG=27485

Review URL: http://codereview.chromium.org/389032
------------------------------------------------------------------------
r31893 | aa@chromium.org | 2009-11-13 09:44:13 +0100 (Fri, 13 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Add new link to bottom right of extension management page.

Review URL: http://codereview.chromium.org/394002
------------------------------------------------------------------------
r31892 | levin@chromium.org | 2009-11-13 08:50:13 +0100 (Fri, 13 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc

Revert 31873 - Revert 31862  Ensure AutomationMsg_SetCookieAsync is sent on IO thread.

Restoring this change as it seems the blame list was incorrect on
some bot and this change wasn't to blame but r31865 was in fact the 
real culprit.

TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/384116
------------------------------------------------------------------------
r31891 | dumi@chromium.org | 2009-11-13 07:37:03 +0100 (Fri, 13 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/webkit/database/database_util.cc
   M /trunk/src/webkit/database/database_util.h
   M /trunk/src/webkit/database/database_util_unittest.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h

Cleans up a bit the DB-related methods.

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/394006
------------------------------------------------------------------------
r31885 | atwilson@chromium.org | 2009-11-13 05:05:02 +0100 (Fri, 13 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h

Changed WorkerProcessHost::WorkerInstance to use std::list instead of std::set,
because the posix version of std::set has no way to update the iterator when
calling erase(), and using the old invalid iterator was corrupting memory.

BUG=27589
TBR=levin@chromium.org

Review URL: http://codereview.chromium.org/385083
------------------------------------------------------------------------
r31880 | scherkus@chromium.org | 2009-11-13 03:28:05 +0100 (Fri, 13 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h

Revert 31877 - Revert 31869  Ignore keyboard messages from enter key in renderer if they were not initiated there.
BUG=26755
TEST=Enter messages initiated in omnibox should not propagate to renderer
Review URL: http://codereview.chromium.org/384101

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/384109

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/393005
------------------------------------------------------------------------
r31877 | scherkus@chromium.org | 2009-11-13 03:13:46 +0100 (Fri, 13 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h

Revert 31869 - Ignore keyboard messages from enter key in renderer if they were not initiated there.
BUG=26755
TEST=Enter messages initiated in omnibox should not propagate to renderer
Review URL: http://codereview.chromium.org/384101

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/384109
------------------------------------------------------------------------
r31875 | estade@chromium.org | 2009-11-13 02:36:50 +0100 (Fri, 13 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.cc
   M /trunk/src/chrome/renderer/spellchecker/spellcheck.h
   M /trunk/src/ipc/ipc.gyp
   A /trunk/src/ipc/ipc_platform_file.h

Use renderer spellchecker for windows.

BUG=25677
Review URL: http://codereview.chromium.org/372075
------------------------------------------------------------------------
r31874 | dumi@chromium.org | 2009-11-13 02:30:45 +0100 (Fri, 13 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/webkit/database/database_tracker.cc
   M /trunk/src/webkit/database/database_tracker_unittest.cc
   A /trunk/src/webkit/database/database_util.cc
   A /trunk/src/webkit/database/database_util.h
   A /trunk/src/webkit/database/database_util_unittest.cc
   M /trunk/src/webkit/database/databases_table.cc
   M /trunk/src/webkit/database/databases_table.h
   M /trunk/src/webkit/database/databases_table_unittest.cc
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/database/vfs_backend.h
   M /trunk/src/webkit/tools/test_shell/simple_database_system.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/webkit_glue.gyp

Changing the file naming scheme. Creating a directory for each origin,
and naming files according to the row ID of the respective DB in the
tracker database. Also, fixing a bug: caching the renderer process
handle in DatabaseDispatcherHost after it was set in
ResourceMessageFilter.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/385051
------------------------------------------------------------------------
r31873 | levin@chromium.org | 2009-11-13 02:30:15 +0100 (Fri, 13 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc

Revert 31862 - Ensure AutomationMsg_SetCookieAsync is sent on IO thread.

These tests started failing with this checkin:
AuthenticateSuccess AuthenticateWithTokenSuccess 

Review URL: http://codereview.chromium.org/387042

TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/389031
------------------------------------------------------------------------
r31872 | idana@chromium.org | 2009-11-13 02:23:29 +0100 (Fri, 13 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc

Revert 31865 - This change is patched from http://codereview.chromium.org/276071 by randy.posynick@gmail.com

Don't overwrite email with lowercase value from GetUserInfo().

BUG=20848
TEST=See bug for description
TBR=brg@chromium.org

Review URL: http://codereview.chromium.org/392016

TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/384106
------------------------------------------------------------------------
r31869 | georgey@chromium.org | 2009-11-13 02:18:00 +0100 (Fri, 13 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h

Ignore keyboard messages from enter key in renderer if they were not initiated there.
BUG=26755
TEST=Enter messages initiated in omnibox should not propagate to renderer
Review URL: http://codereview.chromium.org/384101
------------------------------------------------------------------------
r31868 | atwilson@chromium.org | 2009-11-13 02:13:37 +0100 (Fri, 13 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/websharedworkerrepository_impl.cc
   M /trunk/src/chrome/renderer/websharedworkerrepository_impl.h
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/worker/websharedworker_stub.cc
   M /trunk/src/chrome/worker/websharedworker_stub.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/worker_uitest.cc
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/workers/shared-worker-exception-expected.txt

Added lifecycle management and sharing support for SharedWorkers. SharedWorkers
can now outlive their parent pages and can be shared by multiple instances
across multiple tabs.

BUG=26233
TEST=ui tests

Review URL: http://codereview.chromium.org/390017
------------------------------------------------------------------------
r31865 | idana@chromium.org | 2009-11-13 01:42:42 +0100 (Fri, 13 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc

This change is patched from http://codereview.chromium.org/276071 by randy.posynick@gmail.com

Don't overwrite email with lowercase value from GetUserInfo().

BUG=20848
TEST=See bug for description
TBR=brg@chromium.org

Review URL: http://codereview.chromium.org/392016
------------------------------------------------------------------------
r31863 | pkasting@chromium.org | 2009-11-13 01:28:54 +0100 (Fri, 13 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Minor cleanup to safe_browsing_service.*; no code change.
* Eliminate header files that aren't needed
* Eliminate function declarations that are never defined
* Reorder header slightly for Google C++ Style Guide compliance and to make more functions private
* Move above-function comments like "Called on IO thread" from definitions to declarations for added visibility
* Reorder function definitions to match declaration order

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391039
------------------------------------------------------------------------
r31862 | stoyan@chromium.org | 2009-11-13 01:26:38 +0100 (Fri, 13 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc

Ensure AutomationMsg_SetCookieAsync is sent on IO thread.
If SetCookie is invoked via automation and load_requests_via_automation is true, the IPC will be sent back from the UI thread.
BUG=27568

Review URL: http://codereview.chromium.org/387042
------------------------------------------------------------------------
r31858 | sky@chromium.org | 2009-11-13 00:51:48 +0100 (Fri, 13 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/filebrowse.html

Fixes bug in file browser.

TBR=dhg
BUG=none
Review URL: http://codereview.chromium.org/385081
------------------------------------------------------------------------
r31857 | scherkus@chromium.org | 2009-11-13 00:48:32 +0100 (Fri, 13 Nov 2009) | 11 lines
Changed paths:
   D /trunk/src/chrome/browser/notifications/notifications_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/renderer/notification_provider.cc
   D /trunk/src/chrome/test/data/notifications

Revert 31839 - Notifications permission infobar should only be shown in response to a user gesture, not arbitrary script.

Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script.

BUG=27215
TEST=included

Review URL: http://codereview.chromium.org/387011

TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/385080
------------------------------------------------------------------------
r31856 | dmaclach@chromium.org | 2009-11-13 00:43:02 +0100 (Fri, 13 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Revert 31814 - Testing to see if it caused performance problems.

Add support for observing tracking areas so that when tabs are moved underneath
our cursor, we highlight them correctly.

BUG=27458, 13208, 21448
TEST=Create a pile of tabs. 
     Select a middle one. 
     Put your cursor in some other tab. 
     Hit cmdw a couple of times
     Watch to make sure highlights occur correctly in both the tabs and the
     close buttons.

Review URL: http://codereview.chromium.org/386021

TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/384100
------------------------------------------------------------------------
r31844 | mpcomplete@chromium.org | 2009-11-12 23:49:01 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc

Fix a crash in ExtensionMessageService when a source renderer closed.

BUG=27554

Review URL: http://codereview.chromium.org/384097
------------------------------------------------------------------------
r31842 | aa@chromium.org | 2009-11-12 23:46:29 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Improve text on management UI. Still waiting for a treatment
from the design team, but I wanted to at least get the words
in before the string freeze.

Review URL: http://codereview.chromium.org/385075
------------------------------------------------------------------------
r31840 | mpcomplete@chromium.org | 2009-11-12 23:44:35 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Fix crash in BrowserActionButton::OnImageLoaded.

BUG=27167

Review URL: http://codereview.chromium.org/385072
------------------------------------------------------------------------
r31839 | johnnyg@chromium.org | 2009-11-12 23:43:52 +0100 (Thu, 12 Nov 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/notifications/notifications_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/renderer/notification_provider.cc
   A /trunk/src/chrome/test/data/notifications
   A /trunk/src/chrome/test/data/notifications/notifications_request_function.html
   A /trunk/src/chrome/test/data/notifications/notifications_request_inline.html

Notifications permission infobar should only be shown in response to a user gesture, not arbitrary script.

Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script.

BUG=27215
TEST=included

Review URL: http://codereview.chromium.org/387011
------------------------------------------------------------------------
r31835 | estade@chromium.org | 2009-11-12 22:53:06 +0100 (Thu, 12 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fix bug where crossing events (mouse enter, mouse leave) were being sent
when the mouse button is down, causing duplicate events that caused serious
problems with drag and drop of selections in gmail, plus other problems.
The crossing events should still be sent when the mouse button is not down.

BUG=27264
TEST=confirmed that gmail bug is no longer reproducible; trybot succeeded

patch by Dominic Mazzoni <dmazzoni at goog>
original review: http://codereview.chromium.org/387038

Review URL: http://codereview.chromium.org/389024
------------------------------------------------------------------------
r31834 | rafaelw@chromium.org | 2009-11-12 22:41:15 +0100 (Thu, 12 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/build/build.py
   M /trunk/src/chrome/common/extensions/docs/js/api_page_generator.js
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/json_schema.js
   M /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html
   M /trunk/src/chrome/test/data/extensions/json_schema_test.js

JsonSchema support for declaring "object" constructors.

This adds support for an optional declaration of "isInstanceOf" on "type":"object". If present, the candidate object will be tested for js:instanceof window[schema.isInstanceOf].

Several api functions are modified to take advantage of declaring their "class".

Also, support added to docs for modules, methods & events to declare "nodocs":"true" to be excluded from the docs.

Also, check to warn on an attempt to use cygwin python to generate docs.

BUG=27213
TEST=NONE

Review URL: http://codereview.chromium.org/389005
------------------------------------------------------------------------
r31832 | eroman@chromium.org | 2009-11-12 22:38:55 +0100 (Thu, 12 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc

Fix a comment.

Review URL: http://codereview.chromium.org/393002
------------------------------------------------------------------------
r31831 | erg@google.com | 2009-11-12 22:33:33 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc

GTK: Explicitly use underlines in cookies dialog to fix display in Karmic.

BUG=25635

Review URL: http://codereview.chromium.org/385073
------------------------------------------------------------------------
r31829 | tim@chromium.org | 2009-11-12 22:22:09 +0100 (Thu, 12 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Implement the gaia captcha state and unlock capability in the sync setup wizard.

BUG=19738
TEST=Get a Google Account into captcha state. Start syncing. You should
be presented with a captcha image and textbox to answer the challenge.
Doing so correctly shoud unlock your account and proceed with sync setup.

Review URL: http://codereview.chromium.org/389017
------------------------------------------------------------------------
r31826 | estade@chromium.org | 2009-11-12 22:18:49 +0100 (Thu, 12 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Correctly get ExtensionService out of EXTENSION_PROCESS_CRASHED notification.

Source is Profile*, not ExtensionsService*.

BUG=27199
TEST=load gmail browser action extension, crash it with task manager, press reload button.

Review URL: http://codereview.chromium.org/385076
------------------------------------------------------------------------
r31825 | shess@chromium.org | 2009-11-12 22:17:02 +0100 (Thu, 12 Nov 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Ignore incorrect focus notifications in Omnibox.

After the user runs a Print or Page Layout panel,
autocomplete_edit_view_mac.mm starts seeing
-controlTextDidBeginEditing: notifications when the field does not
have a field editor.  The code thoroughly depends on having a field
editor when it has focus, so this breaks things badly.
-controlTextDidBeginEditing: appears to be sent multiple times when in
this state, once inappropriately, and later when everything is set up
correctly (when the user edits), so this simply ignores the
inappropriate notification.

In the case that is being ignored, AutocompleteEditViewMac will fire
DCHECKs all over the place, so it's somewhat unlikely that this case
is happening in correct operation.

BUG=19116, 17803
TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox).  Bring up the Print panel and cancel.  Bring up a new tab and close it.  gmail's accelerator keys should still work right (not send focus to omnibox).

Review URL: http://codereview.chromium.org/391001
------------------------------------------------------------------------
r31823 | arv@chromium.org | 2009-11-12 22:08:43 +0100 (Thu, 12 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Hide "Make this my home page" after setting the home page.

This also fixes an l10n issue where the string was hard coded in English.

Instead of using the tips infrastructure, after setting the home page we send
an ack to the NTP and show a notification. In this way the user will see the
notification even if they have hidden the tips.

Added a ui test that clicks on the link and checks the state of the UI
afterwards.

BUG=25101
TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click
on the link "Make this my home page" at the bottom. You should see a banner at
the top. Pressing Alt-Home should now go to the NTP.

Review URL: http://codereview.chromium.org/392005
------------------------------------------------------------------------
r31821 | eroman@chromium.org | 2009-11-12 21:52:56 +0100 (Thu, 12 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Fix a crash during shutdown where SafeBrowsingProtocolManager could end up getting back NULL for Profile::GetDefaultRequestContext() and consequently URLFetcher would crash.

During shutdown the Profile is first deleted, and THEN the IO thread is torn down.
This means there is a window of time when Profile::GetDefaultRequestContext() will return NULL, but tasks are still running on the IO thread.

Instead, SafeBrowsingProtocolManager now gets passed an explicit context, and holds a reference throughout its lifetime.
This way it is guaranteed a valid pointer throughout the lifetime of the IO thread, even if the default Profile has already been deleted.

BUG=27074
Review URL: http://codereview.chromium.org/392010
------------------------------------------------------------------------
r31820 | zork@google.com | 2009-11-12 21:44:13 +0100 (Thu, 12 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/third_party/libjingle/files/talk/base/taskrunner.h

Fix mediator_thread_impl.cc to run timer tasks when the task runner is
otherwise idle.

BUG=19784, 26988
TEST=1.  Enable sync and log in.
2.  Go to about:sync
3.  Check that notifications are enabled.
4.  Disable all network adapters, and wait 15 seconds.
5.  Refresh about:sync, and ensure that notifications are disabled.

Review URL: http://codereview.chromium.org/391027
------------------------------------------------------------------------
r31816 | sky@chromium.org | 2009-11-12 21:21:18 +0100 (Thu, 12 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/resources/filebrowse.html

Lands http://codereview.chromium.org/386015 for dhg:

Changing the dom_ui so that it has a new call which allows the
javascript
of the page to open a new window. 

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/385074
------------------------------------------------------------------------
r31814 | dmaclach@chromium.org | 2009-11-12 21:12:49 +0100 (Thu, 12 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Add support for observing tracking areas so that when tabs are moved underneath
our cursor, we highlight them correctly.

BUG=27458, 13208, 21448
TEST=Create a pile of tabs. 
     Select a middle one. 
     Put your cursor in some other tab. 
     Hit cmd-w a couple of times
     Watch to make sure highlights occur correctly in both the tabs and the
     close buttons.

Review URL: http://codereview.chromium.org/386021
------------------------------------------------------------------------
r31808 | oshima@chromium.org | 2009-11-12 20:09:38 +0100 (Thu, 12 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc

Focus fix for compact navigation bar.
 * Make focusable so that focus can be moved to compact navigation bar by tab.
 * Ctrl-L should focus the compact navigation bar (and select all texts)

BUG=51 (chrome-os)
TEST=switch to compact navigation bar mode, hit tab or ctrl-L to move focus to compact navigation bar.

Review URL: http://codereview.chromium.org/384079
------------------------------------------------------------------------
r31807 | oshima@chromium.org | 2009-11-12 20:08:55 +0100 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc

disable toolstrip test for chromeos/linux_view

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/391033
------------------------------------------------------------------------
r31805 | zork@chromium.org | 2009-11-12 20:01:13 +0100 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h

Add the sync options to the preferences dialog on Linux.

BUG=none
TEST=With bookmark sync enabled, go to Wrench Menu->Sync my bookmarks.  Ensure that the Bookmark Sync section is there and useable.

Review URL: http://codereview.chromium.org/385026
------------------------------------------------------------------------
r31803 | andybons@chromium.org | 2009-11-12 19:53:09 +0100 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/extensions
   A /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h
   A /trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension_action.cc

Initial change for the implementation of browser actions on the mac.
Popups are not implemented within this change.

BUG=23881
TEST=Install a browser action extension on the mac. Observe that something actually happens in the UI.
Review URL: http://codereview.chromium.org/366029
------------------------------------------------------------------------
r31802 | dmaclach@chromium.org | 2009-11-12 19:50:25 +0100 (Thu, 12 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm

Moves the animation for the download_started into an overlay window to get
rid of jankyness on 10.6. It really shouldn't have worked right on 10.5 either.
The layer needed to be hosted in a view. Views should not overlap.
The only ways to do this correctly are:
a) Turn on setWantsLayer for the browser view and make a subview to host our 
   animation.
b) An overlay window
Went with 'b', because 'a' may be a big memory hit, and I'm not sure how
webkit works in a layered environment.
BUG=23500
TEST=see bug

Review URL: http://codereview.chromium.org/385053
------------------------------------------------------------------------
r31801 | thakis@chromium.org | 2009-11-12 19:48:55 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Address	post-commit comments from codereview.chromium.org/371059 and codereview.chromium.org/293019

TEST=BUG=none

Review URL: http://codereview.chromium.org/389016
------------------------------------------------------------------------
r31800 | phajdan.jr@chromium.org | 2009-11-12 19:44:36 +0100 (Thu, 12 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

A little cleanup in SessionRestoreUITest.

- don't reload tabs to ensure that a page loaded (it's handled in
  waiting for completion of IDC_NEW_TAB)
- simplify the code, making it shorter and issuing less automation calls

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/385066
------------------------------------------------------------------------
r31799 | johnnyg@chromium.org | 2009-11-12 19:40:37 +0100 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   M /trunk/src/chrome/browser/notifications/notification.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc

When extensions use notifications, display the name of the extension in UI rather than the "origin".

BUG=26961
TEST=test extension linked in the bug

Review URL: http://codereview.chromium.org/385058
------------------------------------------------------------------------
r31798 | craig.schlenter@chromium.org | 2009-11-12 19:39:59 +0100 (Thu, 12 Nov 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Fix some strict aliasing errors from r31773 caught with gcc 4.4.

I've chosen to use a union here instead of restoring the original memcpy code.

Errors were as follows:

cc1plus: warnings being treated as errors
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘virtual bool SafeBrowsingDatabaseBloom::ContainsUrl(const GURL&, std::string*, std::vector<int, std::allocator<int> >*, std::vector<SBFullHashResult, std::allocator<SBFullHashResult> >*, base::Time)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:274: error: dereferencing pointer ‘full_hash.207’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:274: note: initialized from here
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘void SafeBrowsingDatabaseBloom::InsertSub(int, SBPrefix, SBEntry*)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:478: error: dereferencing pointer ‘full_hash.258’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:478: note: initialized from here
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘void SafeBrowsingDatabaseBloom::InsertAdd(SBPrefix, SBEntry*)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:402: error: dereferencing pointer ‘full_hash.237’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:402: note: initialized from here
make: *** [out/Release/obj.target/browser/chrome/browser/safe_browsing/safe_browsing_database_bloom.o] Error 1

Review URL: http://codereview.chromium.org/389021
------------------------------------------------------------------------
r31793 | erg@google.com | 2009-11-12 19:01:17 +0100 (Thu, 12 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc

GTK: The blocked popup notification should obey chrome themes.

BUG=26155
TEST=Install a chrome theme; the default gradient shouldn't be shown on the
popup notification.

Review URL: http://codereview.chromium.org/384063
------------------------------------------------------------------------
r31791 | johnnyg@chromium.org | 2009-11-12 18:40:58 +0100 (Thu, 12 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view_host.h

Allow script in notifications to close the notification by calling window.close().

BUG=26277
TEST=none


Review URL: http://codereview.chromium.org/385056
------------------------------------------------------------------------
r31789 | akalin@chromium.org | 2009-11-12 18:23:43 +0100 (Thu, 12 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Turn on sync for OS X (behind an --enable-sync switch).

Added ProfileSyncService::IsSyncEnabled().

BUG=23073
TEST=manually (OS X),trybot

Review URL: http://codereview.chromium.org/389019
------------------------------------------------------------------------
r31788 | pfeldman@chromium.org | 2009-11-12 17:53:59 +0100 (Thu, 12 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

DevTools: Only enable dev tools for dev tools if process-per-tab flag is set. At the same time, allow it in release mode as well.
BUG=27252

Review URL: http://codereview.chromium.org/384084
------------------------------------------------------------------------
r31785 | rohitrao@chromium.org | 2009-11-12 16:51:34 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Support undo in the omnibox.

BUG=http://crbug.com/18084
TEST=You should be able to undo and redo typing and pasting in the omnibox, unless autocomplete has kicked in or you selected/highlighted an entry in the popup.
Review URL: http://codereview.chromium.org/246009
------------------------------------------------------------------------
r31781 | thomasvl@chromium.org | 2009-11-12 14:28:48 +0100 (Thu, 12 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Total guess fixes for the bug.

Add DCHECKs for main thread in all the places we use animation contexts.
Added a stack based class that takes an animate flag to enable/disable animation operations (grouping, durations) to clean up the code that does optional animation.
This might help the crashes in the bug because before we created animation context groups when we didn't need them and those empty groups could be tripping up something in the system frameworks (I some something similar in nib loading on 10.6).

BUG=26979
TEST=like we have a repeat fail case...
Review URL: http://codereview.chromium.org/390014
------------------------------------------------------------------------
r31779 | yurys@google.com | 2009-11-12 11:32:08 +0100 (Thu, 12 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc

DevTools: enable Storage panel by default

Tha panel allows inspecting cookies and local/session storage which are enabled by default.

TEST=DevToolsSanityTest.TestShowStoragePanel

Review URL: http://codereview.chromium.org/391032
------------------------------------------------------------------------
r31776 | ukai@chromium.org | 2009-11-12 09:24:29 +0100 (Thu, 12 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc

Fix DCHECK in WebSocketExperimentTask.

Don't run experiment task if there are not request context ready yet.

BUG=27491
TEST=none

Review URL: http://codereview.chromium.org/384076
------------------------------------------------------------------------
r31775 | akalin@chromium.org | 2009-11-12 08:58:10 +0100 (Thu, 12 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm

Added Sync-related controls to Preferences pane under "Personal Stuff".

These controls are only visible when sync is enabled.  This isn't finished,
but it is enough to be usable.

Made RemoveViewFromView() handle top-most views.  Also added
RemoveGroupFromView().

BUG=23073
TEST=manual testing, trybots

Review URL: http://codereview.chromium.org/380006
------------------------------------------------------------------------
r31773 | pkasting@chromium.org | 2009-11-12 07:53:24 +0100 (Thu, 12 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc

Misc. minor cleanups in bloom filter code:
* Use assignment/casting in place of memcpy() where possible
* Avoid some unnecessary size_t->int casts by just using size_t
* Be more consistent about usage of SBPrefix type
* Write shorter statements/blocks if possible, e.g. "a -= (b + c);" instead of "a = a - b; a = a - c;"
* Update copyrights

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/386009
------------------------------------------------------------------------
r31768 | andybons@chromium.org | 2009-11-12 06:54:58 +0100 (Thu, 12 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/info_bubble_view.mm

Fixes mac build.

BUG=none
TEST=none
------------------------------------------------------------------------
r31764 | andybons@chromium.org | 2009-11-12 06:18:50 +0100 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   D /trunk/src/chrome/browser/cocoa/bookmark_bubble_view.h
   D /trunk/src/chrome/browser/cocoa/bookmark_bubble_view.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bubble_view_unittest.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.h
   D /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bubble_window_unittest.mm
   A /trunk/src/chrome/browser/cocoa/info_bubble_view.h (from /trunk/src/chrome/browser/cocoa/bookmark_bubble_view.h:31757)
   A /trunk/src/chrome/browser/cocoa/info_bubble_view.mm (from /trunk/src/chrome/browser/cocoa/bookmark_bubble_view.mm:31757)
   A /trunk/src/chrome/browser/cocoa/info_bubble_view_unittest.mm (from /trunk/src/chrome/browser/cocoa/bookmark_bubble_view_unittest.mm:31757)
   A /trunk/src/chrome/browser/cocoa/info_bubble_window.h (from /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.h:31757)
   A /trunk/src/chrome/browser/cocoa/info_bubble_window.mm (from /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.mm:31757)
   A /trunk/src/chrome/browser/cocoa/info_bubble_window_unittest.mm (from /trunk/src/chrome/browser/cocoa/bookmark_bubble_window_unittest.mm:31757)
   M /trunk/src/chrome/chrome.gyp

o Renames the bookmark bubble class to InfoBubble in a step to make it more reusable.
o Adds the ability to position the arrow of the bubble on the top right as well as the top left (default).

BUG=none
TEST=Nothing should change visually. This is prep for use by browser action popups and the first run UI.
Review URL: http://codereview.chromium.org/385060
------------------------------------------------------------------------
r31761 | evan@chromium.org | 2009-11-12 03:53:53 +0100 (Thu, 12 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Revert "Removes TabStrip::CanUpdateDisplay as it ..."

This reverts commit r31736 due to valgrind errors.
------------------------------------------------------------------------
r31756 | mattm@chromium.org | 2009-11-12 03:10:05 +0100 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/cookies_table_model.cc
   D /trunk/src/chrome/browser/cookies_table_model.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Remove cookies_table_model which has been succeeded by cookies_tree_model.

BUG=26713
TEST=still compiles

Review URL: http://codereview.chromium.org/387031
------------------------------------------------------------------------
r31753 | jrg@chromium.org | 2009-11-12 02:48:00 +0100 (Thu, 12 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h

Fix bookmark bar text alignment.

BUG=http://crbug.com/27301

TEST=new profile with no bookmarks.  Shrink horiz width so "bookmarks
go here" text overlaps with "Other bookmarks".  Make sure they line up
vertically.  Now go to NTP and detach bookmark bar (cmd-shift-b).
Make sure text still lines up.

Review URL: http://codereview.chromium.org/385055
------------------------------------------------------------------------
r31752 | vandebo@chromium.org | 2009-11-12 02:41:44 +0100 (Thu, 12 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Render Helper would die in HandleLocaltime if passed an invalid time.
Check the output of localtime() before using it.

BUG=none
TEST=memory_test on 64bit Linux

Review URL: http://codereview.chromium.org/386012
------------------------------------------------------------------------
r31749 | yaar@chromium.org | 2009-11-12 02:14:49 +0100 (Thu, 12 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/app/locales/locales.gyp
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.h
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/css_colors.h
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.cc
   M /trunk/src/chrome/common/desktop_notifications/active_notification_tracker.h
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/chrome/common/native_web_keyboard_event_mac.mm
   M /trunk/src/chrome/common/native_web_keyboard_event_win.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/common/webmessageportchannel_impl.cc
   M /trunk/src/chrome/common/webmessageportchannel_impl.h
   M /trunk/src/chrome/plugin/npobject_proxy.cc
   M /trunk/src/chrome/plugin/npobject_stub.cc
   M /trunk/src/chrome/plugin/npobject_util.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/chrome/renderer/extensions/bindings_utils.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/external_extension.cc
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/notification_provider.cc
   M /trunk/src/chrome/renderer/notification_provider.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_mac.mm
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_linux.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_view_unittest_mac.mm
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_web_database_observer.cc
   M /trunk/src/chrome/renderer/renderer_web_database_observer.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/renderer/webmediaplayer_impl.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/websharedworkerrepository_impl.h
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/chrome/worker/nativewebworker_impl.cc
   M /trunk/src/chrome/worker/nativewebworker_impl.h
   M /trunk/src/chrome/worker/websharedworker_stub.cc
   M /trunk/src/chrome/worker/webworker_stub.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   D /trunk/src/webkit/api/WebKit.gyp
   M /trunk/src/webkit/appcache/appcache_interfaces.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/data/purify/test_shell_tests.exe_UMR.txt
   M /trunk/src/webkit/default_plugin/default_plugin.gyp
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/cpp_bound_class.cc
   M /trunk/src/webkit/glue/cpp_bound_class_unittest.cc
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/cpp_variant_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc_js.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations_unittest.cc
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/form_field_values.cc
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.h
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/glue_serialize.h
   M /trunk/src/webkit/glue/glue_serialize_unittest.cc
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/iframe_redirect_unittest.cc
   M /trunk/src/webkit/glue/image_decoder.cc
   M /trunk/src/webkit/glue/image_resource_fetcher.cc
   M /trunk/src/webkit/glue/media/video_renderer_impl.h
   M /trunk/src/webkit/glue/mimetype_unittest.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.h
   M /trunk/src/webkit/glue/multipart_response_delegate_unittest.cc
   M /trunk/src/webkit/glue/npruntime_util.cc
   M /trunk/src/webkit/glue/password_form.h
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   M /trunk/src/webkit/glue/resource_fetcher.cc
   M /trunk/src/webkit/glue/resource_fetcher.h
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.cc
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.h
   M /trunk/src/webkit/glue/webaccessibility.cc
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webclipboard_impl.h
   M /trunk/src/webkit/glue/webcursor.cc
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webcursor_gtk.cc
   M /trunk/src/webkit/glue/webcursor_mac.mm
   M /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.h
   M /trunk/src/webkit/glue/webdropdata.cc
   M /trunk/src/webkit/glue/webframe_unittest.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webmediaplayer_impl.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/webmenuitem.h
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.cc
   M /trunk/src/webkit/glue/webpasswordautocompletelistener_impl.h
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webplugin_impl_unittest.cc
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/websocketstreamhandle_impl.cc
   M /trunk/src/webkit/glue/websocketstreamhandle_impl.h
   M /trunk/src/webkit/glue/webthemeengine_impl_win.cc
   M /trunk/src/webkit/glue/webthemeengine_impl_win.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/glue/weburlloader_impl.h
   M /trunk/src/webkit/glue/webview_unittest.cc
   M /trunk/src/webkit/glue/window_open_disposition.h
   M /trunk/src/webkit/tools/layout_tests/layout_package/platform_utils_win.py
   M /trunk/src/webkit/tools/test_shell/accessibility_controller.cc
   M /trunk/src/webkit/tools/test_shell/accessibility_ui_element.cc
   M /trunk/src/webkit/tools/test_shell/accessibility_ui_element.h
   M /trunk/src/webkit/tools/test_shell/drag_delegate.cc
   M /trunk/src/webkit/tools/test_shell/drop_delegate.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/mac/test_shell_webview.mm
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/mac/webview_host.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.cc
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.h
   M /trunk/src/webkit/tools/test_shell/plain_text_controller.cc
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/simple_socket_stream_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_navigation_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webthemeengine.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webthemeengine.h
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_web_worker.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/text_input_controller.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_win.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   D /trunk/src/webkit/webkit.gyp
   A /trunk/src/webkit/webkit_glue.gyp (from /trunk/src/webkit/webkit.gyp:31748)

Upstreaming WebKit.gyp

This mega patch contains a few simple but tightly dependent changes:
1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org.
2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion.
3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp.
4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch.

Review URL: http://codereview.chromium.org/387020
------------------------------------------------------------------------
r31748 | jrg@chromium.org | 2009-11-12 02:09:25 +0100 (Thu, 12 Nov 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Enable and implement last 2 items in bookmark bar context menu: "Open
All In New Window" and "Open All In Incognito Window"  (17616).

Bookmark Folders have the bar context menu, not the bookmark context
menu (26748).

Disable bookmark manager item on bookmark contextual menus (26944).

BUG=http://crbug.com/17616, http://crbug.com/26748, http://crbug.com/26944

TEST=Add some bookmarks.
Make sure "Open All In New Window" and "Open All In Incognito Window" work from the bar context menu.
Add a bookmark folder.
Make sure the context menu of the folder is the bar conetxt menu, not the 'mark context menu.
Make sure Bookmark Manager item is DISabled in both context menus.

nib change: hook up actions in the "Open All Blah" items just like the normal "Open All". 

Review URL: http://codereview.chromium.org/373022
------------------------------------------------------------------------
r31747 | chase@chromium.org | 2009-11-12 02:02:01 +0100 (Thu, 12 Nov 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h

Add a RWH_TabSwitchPaintDuration histogram.

The RWH_TabSwitchPaintDuration histogram calculates
the amount of time it took after a particular view was
selected for it to be fully painted.

Previous versions of this patch included modifications
to the tab switching test.  Those are blocked on setting
up a new builder for accurate measurement and are now
removed from this CL.

BUG=4104
TEST=none

Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632
Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31645
Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31679
Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31683

Review URL: http://codereview.chromium.org/378038
------------------------------------------------------------------------
r31746 | estade@chromium.org | 2009-11-12 01:51:57 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc

Compile fix for linux.

TBR=erikkay

Review URL: http://codereview.chromium.org/386011
------------------------------------------------------------------------
r31745 | jcampan@chromium.org | 2009-11-12 01:44:48 +0100 (Thu, 12 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Adding implementation of AutocompleteEditViewMac::IsSelectAll().
Also makes the SetUserText behavior similar to the Windows/Linux versions (by calling SetWindowTextAndCaretPos() that also deals with the selection).

R=shess
BUG=None
TEST=Make sure the location bar still works as expected on Mac.
Review URL: http://codereview.chromium.org/329024
------------------------------------------------------------------------
r31744 | estade@chromium.org | 2009-11-12 01:33:11 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

GTK: fix null dereference in bookmark manager.

BUG=27436

Review URL: http://codereview.chromium.org/391023
------------------------------------------------------------------------
r31743 | estade@chromium.org | 2009-11-12 01:33:01 +0100 (Thu, 12 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h

GTK: Use bookmark bar text color for show all downloads... link when not using GTK theme or Classic theme.

BUG=27075

Review URL: http://codereview.chromium.org/384060
------------------------------------------------------------------------
r31736 | sky@chromium.org | 2009-11-12 01:00:27 +0100 (Thu, 12 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Removes TabStrip::CanUpdateDisplay as it lead to crashes on the
windows side.

BUG=24132
TEST=none

Review URL: http://codereview.chromium.org/372068
------------------------------------------------------------------------
r31733 | finnur@chromium.org | 2009-11-12 00:08:48 +0100 (Thu, 12 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc

ExtensionResource::GetFilePath returns empty path if it
fails to resolve the css and js script files specified in
the manifest. We shouldn't rely on the results of GetFilePath
in the error, but show the relative path instead.

BUG=27423
TEST=Create an extension with a content script, but specify 
a css and a js file that doesn't exist. The error message
should be descriptive and make sense.

Review URL: http://codereview.chromium.org/385052
------------------------------------------------------------------------
r31732 | mattm@chromium.org | 2009-11-12 00:07:58 +0100 (Thu, 12 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/app/tree_model.h
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/chrome/browser/cookies_tree_model.cc
   M /trunk/src/chrome/browser/cookies_tree_model.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/common/gtk_tree.cc
   M /trunk/src/chrome/common/gtk_tree.h

Linux: Convert Cookies options page from a list into a tree.

Add gtk_tree::TreeAdapter class.

BUG=26713
TEST=compare behavior to windows impl

Review URL: http://codereview.chromium.org/371079
------------------------------------------------------------------------
r31731 | ananta@chromium.org | 2009-11-12 00:01:47 +0100 (Thu, 12 Nov 2009) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/urlmon_url_request.cc
   M /trunk/src/chrome_frame/urlmon_url_request.h

ChromeFrame HTTP requests would randomly fail if we navigated to multiple HTTP sites. This was because
the automation resource message filter tracked HTTP requests based on the request ids which are generated
by the renderer process. As a result a new request would get created say with id 0, while an existing request
would end in ChromeFrame causing the new request to incorrectly shutdown.

Fix is to revert back to the original way of tracking requests with an auto incrementing id. The automation url
job maintains both ids now, i.e. the automation request id and the chrome request id. The download notification
receives the automation id and basically looks up the associated automation request id and sends the notification
back to ChromeFrame.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=27401

Other fixes in this CL include the following:-
1. The active document instance would never get destroyed. This was because we call ShowUI on the doc host 
   which maintains a reference. We need to call HideUI in Setsite of NULL, which releases the reference.

2. When the active x instance is shutting down we try to shutdown all running requests in the OnDestroy handler.
   To ensure that the request is deleted from the request map and released in the same thread which created it
   we post a task back to the ui thread which never runs as the window is being destroyed. Fix is to create
   a message only window with every urlmonrequest instance which supports task marshaling.

Tests in a future CL.

Bug=27401

Review URL: http://codereview.chromium.org/386008
------------------------------------------------------------------------
r31729 | tim@chromium.org | 2009-11-11 23:57:46 +0100 (Wed, 11 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   A /trunk/src/chrome/browser/google_service_auth_error.h
   D /trunk/src/chrome/browser/sync/auth_error_state.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Part 1 of implementing captcha for sync dialog. 
Added GoogleServiceAuthError, which is the same as the incumbent AuthErrorState but can support captcha information too. I moved it because it just had nothing specific to sync about it. This CL is mostly a rename and basic plumbing CaptchaRequired error state from browser_sync::AuthWatcher through to UI thread.

Ben, I added a .h to chrome/browser/ alongside other google_* stuff. I'm just looking for your blessing here, or suggestion of alternate location.  

BUG=19738

Review URL: http://codereview.chromium.org/384040
------------------------------------------------------------------------
r31728 | erg@google.com | 2009-11-11 23:56:30 +0100 (Wed, 11 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

GTK: Use themed background images in toolbar buttons.

When a chrome theme asks to use a background image on a toolbar button,
use it. Oddly enough, all of the graphics drawing was written but the
plumbing of actually setting the background wasn't...

TEST=Good Smile, Chuck Anderson, etc. should have button backgrounds which
are very different from the toolbar background in the GTK port.
BUG=NONE

Review URL: http://codereview.chromium.org/384057
------------------------------------------------------------------------
r31727 | pinkerton@chromium.org | 2009-11-11 23:55:42 +0100 (Wed, 11 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Prevent accidental animations if we haven't yet done a full layout. Stab in the dark at a fix for some crashes.
BUG=26979
TEST=dragging tabs over an existing window should still animate as the placeholder shifts around.
Review URL: http://codereview.chromium.org/385048
------------------------------------------------------------------------
r31719 | dmaclach@chromium.org | 2009-11-11 22:49:29 +0100 (Wed, 11 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

BookmarkBubble.xib - Change control from combobox to popup button. The massive changes due to the xib are due to editing the xib on SnowLeopard.

Changes internals of bookmark bubble controller so that it will work correctly 
with items with the same name.

BUG=27330
TEST=Create several bookmark folders and items using the bookmark bubble and
     verify that it is still working correctly.
Review URL: http://codereview.chromium.org/384025
------------------------------------------------------------------------
r31718 | johnnyg@chromium.org | 2009-11-11 22:48:18 +0100 (Wed, 11 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Rename unused "SSL" related automation methods to be generic, since that's what these methods actually do, and so I can repurpose them for a different info-bar test.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/385029
------------------------------------------------------------------------
r31713 | finnur@chromium.org | 2009-11-11 22:27:29 +0100 (Wed, 11 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   A /trunk/src/chrome/browser/resources/extension_default_icon.png

Switch to the new extensions default icon.

BUG=27399
TEST=Extensions without an icon now have a light-blue
puzzle-piece icon when installing/uninstalling them
and when listing them on chrome://extensions.

Review URL: http://codereview.chromium.org/384055
------------------------------------------------------------------------
r31712 | dmaclach@chromium.org | 2009-11-11 22:26:46 +0100 (Wed, 11 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm

Update zoom/close/miniaturize button based on cursor location after the window
has been moved.

BUG=27388
TEST=Click the zoom button on a browser window. Make sure the '+' disappears.

Review URL: http://codereview.chromium.org/384054
------------------------------------------------------------------------
r31710 | akalin@chromium.org | 2009-11-11 22:12:44 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

TBR: pkasting
------------------------------------------------------------------------
r31709 | akalin@chromium.org | 2009-11-11 22:00:02 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Added RemoveGroupFromView().
------------------------------------------------------------------------
r31708 | akalin@chromium.org | 2009-11-11 21:59:56 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Made RemoveViewFromView() handle top-most subviews.
------------------------------------------------------------------------
r31707 | akalin@chromium.org | 2009-11-11 21:59:51 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Added vertical shift for sync stuff.
------------------------------------------------------------------------
r31706 | akalin@chromium.org | 2009-11-11 21:59:45 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Grouped sync controls and remove them properly.
------------------------------------------------------------------------
r31704 | akalin@chromium.org | 2009-11-11 21:59:34 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Moved pref stuff to the right place.
------------------------------------------------------------------------
r31702 | akalin@chromium.org | 2009-11-11 21:59:23 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Implemented sync button action.
------------------------------------------------------------------------
r31701 | akalin@chromium.org | 2009-11-11 21:58:56 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Hooked up sync service to preferences dialog.
------------------------------------------------------------------------
r31699 | sky@chromium.org | 2009-11-11 21:47:09 +0100 (Wed, 11 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Fixes leak in BackingStore as shown by valgrind. XFree doesn't free
the data of the image, where as XDestroyImage does.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/386003
------------------------------------------------------------------------
r31695 | mark@chromium.org | 2009-11-11 21:08:18 +0100 (Wed, 11 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

"Am I on the right thread?" DCHECKs for StatusBubbleMac.

This doesn't fix bug 26979, but I want to get these DCHECKs in as I continue
to investigate that bug.

BUG=26979
TEST=don't hit these DCHECKs
Review URL: http://codereview.chromium.org/385043
------------------------------------------------------------------------
r31689 | mpcomplete@chromium.org | 2009-11-11 20:28:07 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Mark ErrorPageTest.IFrameDNSError_GoBackAndForward as flaky since it failed
on Linux.

BUG=19361

Review URL: http://codereview.chromium.org/384050
------------------------------------------------------------------------
r31687 | simonrad@chromium.org | 2009-11-11 20:21:19 +0100 (Wed, 11 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix jumping/resize/relayout of NTP/webpages when switching between NTP and another tab.

(This really fixes 3 issues)
1. When the bookmarks bar is not docked, it toggles on and off when switching between the NTP and another tab. Since it is part of the UI, this causes the TabContents to be resized. This causes ugly re-layout of some webpages and also causes the NTP to jump when you switch to it, if themed. The solution is to toggle the floating bookmarks bar at a time when no TabContents is attached - that is, after detaching the first one but before attaching the second one.
2. Changing the info-bar can also cause a resize, so we also want to do this when no TabContents is attached.
3. Finally, when the NTP is displayed and another, floating tab is dragged and inserted to the left of the NTP, the selected tab index will not be set correctly. As a result, the NTP will be resized incorrectly before the tabs are even switched.

R=beng
BUG=23925
TEST=1. Apply Ratchet and Clank theme. Open NTP and Google Calendar in tabs. Switch back and forth between them. The NTP background should not jump or flicker, and Calendar should not re-layout. 2. Try switching between the NTP (or Calendar) and a tab that has an info-bar. 3. Open NTP and another tab. Drag the other tab until it detaches from the windows and floats. Re-attach and detach the tab repeatedly, so that the window switches between displaying the two tabs, and make sure you insert the other tab to the *left* of the NTP. The NTP should never jump.


Review URL: http://codereview.chromium.org/376018
------------------------------------------------------------------------
r31686 | estade@chromium.org | 2009-11-11 20:20:01 +0100 (Wed, 11 Nov 2009) | 71 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

More search engine prepopulate data updating.

notes:
- did not include startslim as its popularity was too low (as reported by Alexa)
- did not use espanol.yahoo.com for bolivia, instead used yahoo.com (as with most Latin American countries). espanol.yahoo.com seems to be aimed at es_US
- Did not remove fr_CA engines, because it seems prudent to use localized engines when possible
- Switzerland - 14 engines were listed. I took the 6 that I thought were probably most popular.
- did not include Onkosh as its popularity was too low (as reported by Alexa)
- yp.com.hk - this is Yellow Pages Hong Kong, not a web search. Did not include it.
- virgilio - I am super confused as to whether it's virgilio or virgilio.alice.it. Left it alone.
- Did not remove delfi_lt because it is a really popular site (probably popular search engine) in Lithuania. The fact that it is localized is not a mark against it.
- xalo.vn - again not popular enough

List of completely removed engines (i.e. engines no longer in use for _any_ country):
- adonde
- aeiou
- aladin
- altavista_es
- altavista_mx
- aol_fr
- aonde
- ask_de
- ask_uk
- biglobe
- bigmir
- bluewin
- conexcol
- delfi_ee
- embla
- empas
- eniro_dk
- finna
- forthnet
- gigabusca
- goo
- iafrica
- ilse
- jamaicalive
- krstarica
- live*
- lycos*
- matkurja
- meta
- msn*
- mweb
- mywebsearch
- nan10
- netindex
- nifty
- ohperu
- orange
- sesam
- sogou
- soso
- szm
- t_online
- terra_ec
- terra_mx
- terra_pe
- toile
- vinden
- voila
- web_de
- yagua
- yam



BUG=23909

Review URL: http://codereview.chromium.org/385032
------------------------------------------------------------------------
r31685 | apavlov@chromium.org | 2009-11-11 20:19:02 +0100 (Wed, 11 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h

Revert r31665: themed mac startup time regression

BUG=none
TEST=none
TBR=yurys@chromium.org

Review URL: http://codereview.chromium.org/387027
------------------------------------------------------------------------
r31684 | estade@chromium.org | 2009-11-11 20:18:28 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Safely send spellcheck intialization messages to renderer.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/390010
------------------------------------------------------------------------
r31683 | chase@chromium.org | 2009-11-11 20:11:39 +0100 (Wed, 11 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc

Revert "Add a RWH_TabSwitchPaintDuration histogram."

Causes tab_switching_test to go red.  Reverting this commit
which is part of the investigation.

BUG=4104
TEST=tab_switching_test goes green

Review URL: http://codereview.chromium.org/384049
------------------------------------------------------------------------
r31680 | aa@chromium.org | 2009-11-11 19:39:02 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc

Change width of install bubble to avoid orphan.

BUG=27351
TEST=none

Review URL: http://codereview.chromium.org/385034
------------------------------------------------------------------------
r31679 | chase@chromium.org | 2009-11-11 19:36:37 +0100 (Wed, 11 Nov 2009) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc

Add a RWH_TabSwitchPaintDuration histogram.

The RWH_TabSwitchPaintDuration histogram calculates
the amount of time it took after a particular view was
selected for it to be fully painted.

I modified the tab switching test to use the new tab
switch paint duration histogram in place of the whiteout
duration histogram.  As a measure, whiteout duration
would not carry a value if we kept the backing store
around for a tab, and we would end up with a result of
zero instead of a useful result.  Local results with the
new measure are consistent with the number of operations
we perform on the tabs.

The tab switching test now fails if it cannot locate
the correct histogram.  In that case, it will output
the contents of the log file for remote debugging.

BUG=4104
TEST=count of tab switch paint duration histogram
results in tab switching test equals number of tabs
used in test

First committed as: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632
Reverted in: 31645

Review URL: http://codereview.chromium.org/378038
------------------------------------------------------------------------
r31675 | rafaelw@chromium.org | 2009-11-11 19:20:01 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc

Add a close button to ExtensionInstalledBubble.

BUG=27156
TEST=Install an extension, the installed successful bubble should have a close button with an x image that will close the bubble when clicked.

Review URL: http://codereview.chromium.org/384026
------------------------------------------------------------------------
r31670 | johnnyg@chromium.org | 2009-11-11 18:40:31 +0100 (Wed, 11 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   A /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc
   A /trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   M /trunk/src/chrome/chrome.gyp

Unit tests for desktop notifications.

* Allow non-windows BalloonCollections to create non-viewable balloons (so that non-viewing aspects are cross-platform testable)
* Makes NotificationObjectProxy overridable by a mock object which logs instead of calls to JS
* Move Layout code from private to protected in BalloonCollection to enable verification of position code.

BUG=none
TEST=these

Review URL: http://codereview.chromium.org/371041
------------------------------------------------------------------------
r31669 | erg@google.com | 2009-11-11 18:36:50 +0100 (Wed, 11 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/convert_user_script.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/process_info_snapshot_mac.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/mailbox.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/common/extensions/extension_action_unittest.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/mru_cache_unittest.cc
   M /trunk/src/chrome/common/pref_member_unittest.cc
   M /trunk/src/chrome/common/worker_thread_ticker.cc
   M /trunk/src/chrome/installer/gcapi/gcapi.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/create_dir_work_item.cc
   M /trunk/src/chrome/installer/util/create_reg_key_work_item.cc
   M /trunk/src/chrome/installer/util/html_dialog_impl.cc
   M /trunk/src/chrome/installer/util/lzma_util.cc
   M /trunk/src/chrome/installer/util/lzma_util_unittest.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/visitedlink_slave.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/websharedworker_proxy.cc
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/security_tests/ipc_security_tests.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.cc

A large number of style nits in preparation for turning on automated cpplint.py.

Review URL: http://codereview.chromium.org/385023
------------------------------------------------------------------------
r31668 | yurys@google.com | 2009-11-11 18:08:31 +0100 (Wed, 11 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/pause_when_loading_devtools.html
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: add test for pause event during frontend load.

BUG=27366
TEST=DevToolsSanityTest.TestPauseWhenLoadingDevTools
Review URL: http://codereview.chromium.org/392002
------------------------------------------------------------------------
r31667 | pinkerton@chromium.org | 2009-11-11 17:26:26 +0100 (Wed, 11 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Allow new window creation when the frontmost browser has a modal sheet attached.
BUG=27379
TEST=creating new windows with app modals, tab modal, window modals
Review URL: http://codereview.chromium.org/387025
------------------------------------------------------------------------
r31665 | apavlov@chromium.org | 2009-11-11 16:56:33 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h

Set have_inspector_files_ in the UI thread as it is only read from that thread.

BUG=24419
TEST=TSAN

Review URL: http://codereview.chromium.org/391017
------------------------------------------------------------------------
r31663 | sky@chromium.org | 2009-11-11 15:44:19 +0100 (Wed, 11 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h

Fixes possible crash during tab dragging. The code was invoking
InitWindowCreatePoint when making a tab pinned, which is only save to
invoke when the drag starts.

BUG=27329
TEST=make sure no regressions in tab dragging.

Review URL: http://codereview.chromium.org/391006
------------------------------------------------------------------------
r31655 | phajdan.jr@chromium.org | 2009-11-11 10:32:01 +0100 (Wed, 11 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

[GTTF] Make ResourceDispatcherTest.CrossSiteNavigationErrorPage faster
and more solid.

Sleeping for about 6 seconds is not a good idea.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/385010
------------------------------------------------------------------------
r31654 | oshima@chromium.org | 2009-11-11 09:19:13 +0100 (Wed, 11 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h

Fix for issue 27210, show bookmarks bar menu is out of sync with the browser's status.
 * Update the states of menu before showing menu like Window's menu does.
 * Don't fire activate signal when the state is chagned via API.
 * Eliminated UpdateStateData and replace it with the NativeMenuGtk and the position
   stored in the gtk widget.
 * Fixed StateAreaView to check bookmark bar status.

BUG=27210
TEST=Run linux builds (gtk/views/chromeos) check if the bookmark bar menu's status is in sync with the bookmark bar.

Review URL: http://codereview.chromium.org/383012
------------------------------------------------------------------------
r31653 | ukai@chromium.org | 2009-11-11 07:59:38 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
   A /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.h
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   M /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.h
   M /trunk/src/chrome/chrome.gyp

WebSocket Live Experiment

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/369002
------------------------------------------------------------------------
r31652 | thakis@chromium.org | 2009-11-11 07:09:57 +0100 (Wed, 11 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm

Revert r31647 again, I have enough perf data
------------------------------------------------------------------------
r31651 | aa@chromium.org | 2009-11-11 07:07:03 +0100 (Wed, 11 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Speculative fix for a common crash. We were leaking the
BrowserActionView because RemoveChild() does not delete it.
This could maybe cause OnImageLoaded() to be called when
there is no parent. I couldn't see any other path that could
lead to that.

BUG=27167
TEST=none

Review URL: http://codereview.chromium.org/385031
------------------------------------------------------------------------
r31649 | pkasting@chromium.org | 2009-11-11 06:42:41 +0100 (Wed, 11 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h

Avoid inconsistent state (leading to checkfailures) due to Windows minimize/restore functionality hiding and showing the autocomplete dropdown outside of the awareness of the controller.

Instead, this switches to the simpler model of just creating a new HWND when we want to show the dropdown, and destroying it when we want to close it.  Happily, this also seems to save quite a bit of code.

BUG=20511
TEST=Type a character in the omnibox, minimize the window, and restore it.  The dropdown should have disappeared.
Review URL: http://codereview.chromium.org/391011
------------------------------------------------------------------------
r31647 | thakis@chromium.org | 2009-11-11 06:03:47 +0100 (Wed, 11 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm

Mac: Use native folder icons for the bookmark bar.

Based on http://codereview.chromium.org/342103 .

I will land this to see the startup perf impact, then revert this after a short while, and then send it out for review.

BUG=26457
TEST=Look at bookmark bar's "Other bookmarks". Should have blue folder.

Review URL: http://codereview.chromium.org/384039
------------------------------------------------------------------------
r31645 | dpranke@google.com | 2009-11-11 04:04:32 +0100 (Wed, 11 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc

Reverting 31632 - looks like it broke some tests.

  R=chase@chromium.org
  TEST=tab_switching_test
  BUG=none

Review URL: http://codereview.chromium.org/389006
------------------------------------------------------------------------
r31644 | mrossetti@chromium.org | 2009-11-11 03:49:05 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/base/mac_util_unittest.mm
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc

For the immediate milestone, exclude History and Thumbnails from being backed up by Time Machine.  The bug describes appropriate long-term solutions to this problem.

BUG=259595
TEST=Launch Chrome.  Inspect the following files found in ~/Library/Application Support/Chromium/Default/: a) History, b) History-journal, c) Thumbnails, and d) Thumbnails-journal and verify that they are not being backed up by Time Machine.

Review URL: http://codereview.chromium.org/387016
------------------------------------------------------------------------
r31641 | jamesr@chromium.org | 2009-11-11 02:51:32 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Adds a 'V8' column to task manager to track amount of memory in JavaScript heap

BUG=27226
TEST=open task manager, enable column, compare with V8 heap profiler

Review URL: http://codereview.chromium.org/377037
------------------------------------------------------------------------
r31636 | thestig@chromium.org | 2009-11-11 02:29:26 +0100 (Wed, 11 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Inodes can be 64-bit, use Int64ToString.

BUG=27322
TEST=none
Review URL: http://codereview.chromium.org/384031
------------------------------------------------------------------------
r31633 | sky@chromium.org | 2009-11-11 02:10:45 +0100 (Wed, 11 Nov 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/app/theme/filebrowse_back.png
   A /trunk/src/chrome/app/theme/filebrowse_forward.png
   A /trunk/src/chrome/app/theme/icon_app.png
   A /trunk/src/chrome/app/theme/icon_file.png
   A /trunk/src/chrome/app/theme/icon_folder.png
   A /trunk/src/chrome/app/theme/icon_media.png
   A /trunk/src/chrome/app/theme/icon_photo.png
   A /trunk/src/chrome/app/theme/icon_webpage.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/chromeos/mount_library.cc
   A /trunk/src/chrome/browser/chromeos/mount_library.h
   A /trunk/src/chrome/browser/chromeos/usb_mount_observer.cc
   A /trunk/src/chrome/browser/chromeos/usb_mount_observer.h
   M /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/net/base/net_util_posix.cc

Lands http://codereview.chromium.org/379007 for Dave:

Fixes leak in BackingStore as shown by valgrind. XFree doesn't free
the data of the image, where as XDestroyImage does.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/391008
------------------------------------------------------------------------
r31632 | chase@chromium.org | 2009-11-11 02:09:39 +0100 (Wed, 11 Nov 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc

Add a RWH_TabSwitchPaintDuration histogram.

The RWH_TabSwitchPaintDuration histogram calculates
the amount of time it took after a particular view was
selected for it to be fully painted.

I modified the tab switching test to use the new tab
switch paint duration histogram in place of the whiteout
duration histogram.  As a measure, whiteout duration
would not carry a value if we kept the backing store
around for a tab, and we would end up with a result of
zero instead of a useful result.  Local results with the
new measure are consistent with the number of operations
we perform on the tabs.

The tab switching test now fails if it cannot locate
the correct histogram.

BUG=4104
TEST=count of tab switch paint duration histogram
results in tab switching test equals number of tabs
used in test

Review URL: http://codereview.chromium.org/378038
------------------------------------------------------------------------
r31624 | sky@chromium.org | 2009-11-11 01:47:32 +0100 (Wed, 11 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/views/view.h

Fixes regression in showing bookmark menus where the wrong menu would
appear when rtl.

BUG=26376
TEST=see bug

Review URL: http://codereview.chromium.org/384021
------------------------------------------------------------------------
r31623 | zork@google.com | 2009-11-11 01:43:53 +0100 (Wed, 11 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/win/async_network_alive_win32.cc

Check for an active network connection when network adapter status changes.

BUG=19784
TEST=On a system with two network adapters, ensure one has an active internet
connection, and the other does not.  Disconnect the active one, and check that
in notifier::NetworkStatusDetectorTaskMT::OnNetworkAliveDone() the call to
network_alive->alive() returns false.

Review URL: http://codereview.chromium.org/377019
------------------------------------------------------------------------
r31622 | oshima@chromium.org | 2009-11-11 01:40:46 +0100 (Wed, 11 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/views/widget/widget_gtk.cc

Adding a couple of missing parts for extensios on linux/views.
 * Creating RenderWidgetHostView for gtk
 * Fix assertion failure in BrowserBubble
 * Don't change the window size if the size is empty, which causes gtk assertion error.

With this change, most of extension tests in browser passes except for toolstrip.
Given that toolstrip is obsolete, may be we should just remove it from test.

BUG=None
TEST=Run browesr_tests. All tests for extension must pass except for ExtensionApiTest.Toolstrip

Review URL: http://codereview.chromium.org/390006
------------------------------------------------------------------------
r31619 | idana@chromium.org | 2009-11-11 01:14:31 +0100 (Wed, 11 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/app/gfx/canvas.h
   M /trunk/src/app/gfx/canvas_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Added a flag to the Canvas class which allows forcing an RTL directionality
on text drawn using Canvas::DrawStringInt(). Using this flag, it is possible to
render RTL text correctly on platforms where LRE/PDF chars are not supported (e.g.
Windows XP with no RTL fonts installed).

BUG=23425
TEST=Run chrome and enter Hebrew text into the omnibox (see bug description). Make sure suggestions are formatted correctly. Verify in both RTL and LTR UIs.

Review URL: http://codereview.chromium.org/384018
------------------------------------------------------------------------
r31618 | zork@chromium.org | 2009-11-11 01:08:24 +0100 (Wed, 11 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h

Update GtkChromeLinkButton to provide an accessor for changing the label.

BUG=none
TEST=Create a GtkChromeLinkButton, and then use gtk_chrome_link_button_set_label() to change the text.  The displayed text should be the new text.

Review URL: http://codereview.chromium.org/391005
------------------------------------------------------------------------
r31616 | idana@chromium.org | 2009-11-11 00:53:18 +0100 (Wed, 11 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.cc

Fixed a label alignment issue in ConfirmMessageBoxDialog. 

There is no need to manually detect the text directionlity at run time. Setting the
label's alignment to views::Label::ALIGN_LEFT is sufficient because the mirroring subsystem
will flip it automatically if the locale is RTL.

BUG=26378
TEST=Run chrome with --lang=he, enable sync and then disable through the options dialog. Text in dialog box should be right aligned.

Review URL: http://codereview.chromium.org/390005
------------------------------------------------------------------------
r31612 | finnur@chromium.org | 2009-11-11 00:17:41 +0100 (Wed, 11 Nov 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Disabled extensions should be uninstallable. 

The code to display the dialog looks up an
Extension by id but doesn't return disabled ones.

So I added that option to the function. 

I also added a check so that we don't show the
Options button enabled when the extension is
disabled, since you need the extension to be
enabled for the Options page to work.

BUG=26910
TEST=Disable an extension that has an Option page,
make sure Options is not enabled after disabling,
then uninstall it. It should uninstall.

Review URL: http://codereview.chromium.org/385014
------------------------------------------------------------------------
r31603 | sky@chromium.org | 2009-11-10 22:54:49 +0100 (Tue, 10 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h

Fixes possible crash in showing bookmark menu. The problem occurred
when you clicked on one top level menu on the bookmark bar, moused
over another menu and then we loaded favicons for the first menu. The
code needs to figure out which menu has the icon instead of invoking
set icon on menu_.

BUG=27067
TEST=make sure bookmark menus work ok.

Review URL: http://codereview.chromium.org/388007
------------------------------------------------------------------------
r31600 | jam@chromium.org | 2009-11-10 22:11:37 +0100 (Tue, 10 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

Small cleanup.  No more need for Init() since the internal process id is valid at construction of RMF.  Also make the destructor private.

Review URL: http://codereview.chromium.org/379014
------------------------------------------------------------------------
r31598 | mpcomplete@chromium.org | 2009-11-10 22:03:33 +0100 (Tue, 10 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/app/gfx/skbitmap_operations.cc
   M /trunk/src/app/gfx/skbitmap_operations.h
   M /trunk/src/app/gfx/skbitmap_operations_unittest.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h

Unrevert 31478  Add UI for turning on/off network devices.
BUG=26636
TEST=run skbitmap_operations_unittest
Review URL: http://codereview.chromium.org/353028

TBR=chocobo@google.com
Review URL: http://codereview.chromium.org/384017
------------------------------------------------------------------------
r31597 | munjal@chromium.org | 2009-11-10 21:58:40 +0100 (Tue, 10 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h

Fix 26141
- Change sync id to bookmark id map to sync id to bookmark node map
- Make other appropriate changes.

BUG=26141
TEST=Exist.

Review URL: http://codereview.chromium.org/383002
------------------------------------------------------------------------
r31595 | shess@chromium.org | 2009-11-10 21:34:30 +0100 (Tue, 10 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/base/chrome_application_mac.h
   M /trunk/src/base/chrome_application_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

[Mac] ScopedSendingEvent finds NSApp by itself.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/385009
------------------------------------------------------------------------
r31589 | mpcomplete@chromium.org | 2009-11-10 21:09:54 +0100 (Tue, 10 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/app/gfx/skbitmap_operations.cc
   M /trunk/src/app/gfx/skbitmap_operations.h
   M /trunk/src/app/gfx/skbitmap_operations_unittest.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h

Revert 31478 - Add UI for turning on/off network devices.
BUG=26636
TEST=run skbitmap_operations_unittest
Review URL: http://codereview.chromium.org/353028

TBR=chocobo@google.com
Review URL: http://codereview.chromium.org/384014
------------------------------------------------------------------------
r31588 | dmaclach@chromium.org | 2009-11-10 20:59:26 +0100 (Tue, 10 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/animatable_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp

Add support for slowing down all animations on the Mac by using the shift and/or
control key.

BUG=27274
TEST= 1) create a window. 
      2) Create a tab. 
      3) Hold down the shift key and click in the close button on the tab.
      4) Watch animation proceed slowly. (and slower if you hold down shift + control)
      This should apply to all non-web page animations.
      
Review URL: http://codereview.chromium.org/388004
------------------------------------------------------------------------
r31587 | estade@chromium.org | 2009-11-10 20:59:11 +0100 (Tue, 10 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Start to update search engine prepopulate data: Hungary and UAE.

Will do more at one time after I get the hang of it. Baby steps.

Tango just disappeared from the list, it didn't explicitly say remove, but Alexa describes it as:
"Images or video content. May be unsuited to certain users." so I guess it's not really a search engine.

BUG=23909

Review URL: http://codereview.chromium.org/380008
------------------------------------------------------------------------
r31584 | jorlow@chromium.org | 2009-11-10 20:28:26 +0100 (Tue, 10 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc

Put local storage files in "Local Storage" instead of "localStorage" directory to match existing convention.

This includes a one-time attempt to migrate the directory.  Once this occurs, older versions will not have access to the data.  I'll send out a chromium-dev post announcing this before I check in.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/378020
------------------------------------------------------------------------
r31578 | mark@chromium.org | 2009-11-10 20:02:02 +0100 (Tue, 10 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm

Back out r31572, reinstating r31563:

Always create BackingStore CGLayers using the owner view's window's context as
a reference.

Reorganize CGLayer and CGBitmapContext creation into common functions.

BUG=26989
TEST=Still paints?  Good.
Review URL: http://codereview.chromium.org/384011
------------------------------------------------------------------------
r31577 | erikkay@chromium.org | 2009-11-10 20:00:36 +0100 (Tue, 10 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-128x128.png
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16-subscribed.png
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16.png
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-64x64.png
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed_finder.js
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/iframe.js
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/style.css
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html

move subscribe_page_action out of samples in preparation for removing
samples directory (part 2)

TEST=ExtensionBrowserTest.*PageAction
BUG=26106
TBR=finnur

Review URL: http://codereview.chromium.org/387004
------------------------------------------------------------------------
r31573 | kuan@chromium.org | 2009-11-10 19:51:33 +0100 (Tue, 10 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h

implement "Learn more" link in "Aw snap" page.
this changelist is only for windows.

BUG=21726
TEST=verify that "Learn More" link shows up centralized beneath crash message and when clicked, opens the url specified in bug.

Review URL: http://codereview.chromium.org/377016
------------------------------------------------------------------------
r31572 | mark@chromium.org | 2009-11-10 19:50:50 +0100 (Tue, 10 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm

Temporarily(?) back out r31563 to see if it caused a morejs page cycler
performance regression.

BUG=26989
TEST=observe
Review URL: http://codereview.chromium.org/388009
------------------------------------------------------------------------
r31571 | thomasvl@chromium.org | 2009-11-10 19:50:08 +0100 (Tue, 10 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ReportBug.xib
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm

[Mac] L10N cleanup of report a bug
- align the baselines of the controls
- quick animation when changing the buttons so it is a little less sudden.
While here:
- don't update the button title while dragging through the menu, do it when done.
- Fixed up some kvo binding to stop using the ivars directly since the controller has accessors

TEST=baselines match, button updates after selection not during menu drags
BUG=27275
Review URL: http://codereview.chromium.org/388006
------------------------------------------------------------------------
r31567 | finnur@chromium.org | 2009-11-10 18:51:12 +0100 (Tue, 10 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Remove flaky label from ParseFeed tests. No failure can be found
within Pavel's log. There used to be two sources of flakiness,
one that I could reproduce locally, made perfect sense and I
managed to weed out. The other made no sense and I could never
repro locally, and that is the one that seems to have disappeared
now.

TBR=phajdan
BUG=23686
TEST=None. (Well, this is a test I am changing).

Review URL: http://codereview.chromium.org/383008
------------------------------------------------------------------------
r31565 | phajdan.jr@chromium.org | 2009-11-10 18:30:45 +0100 (Tue, 10 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc

Mark ExtensionApiTest.Popup as FLAKY.

TEST=none
BUG=27271

Review URL: http://codereview.chromium.org/383007
------------------------------------------------------------------------
r31563 | mark@chromium.org | 2009-11-10 18:23:48 +0100 (Tue, 10 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm

Always create BackingStore CGLayers using the owner view's window's context as
a reference.

Reorganize CGLayer and CGBitmapContext creation into common functions.

BUG=26989
TEST=Still paints?  Good.
Review URL: http://codereview.chromium.org/371089
------------------------------------------------------------------------
r31558 | rsesek@chromium.org | 2009-11-10 16:10:31 +0100 (Tue, 10 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

[Mac] Fix a leak in HyperlinkButtonCell

BUG=27149
TEST=Valgrind

Review URL: http://codereview.chromium.org/380010
------------------------------------------------------------------------
r31549 | rolandsteiner@chromium.org | 2009-11-10 11:55:34 +0100 (Tue, 10 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Mark all tests in the DownloadTest suite as flaky under Windows (as discussed in this review).

As discussed under http://codereview.chromium.org/342056 .

Note: did not change that ContentDisposition test, which  was already marked as FLAKY for all platforms, nor KnownSize, which is DISABLED.

BUG=20809
TEST=none

Review URL: http://codereview.chromium.org/342056
------------------------------------------------------------------------
r31547 | johnnyg@chromium.org | 2009-11-10 07:27:38 +0100 (Tue, 10 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/renderer/notification_provider.cc

Adds an options menu to the frame of the desktop notification, for now with the single option of revoking permissions from that origin.

The renderer side change is a related issue that the full URL was being sent as the "source" of the notification rather than only the origin.

BUG=26690
TEST=open a notification

Review URL: http://codereview.chromium.org/363011
------------------------------------------------------------------------
r31540 | finnur@chromium.org | 2009-11-10 04:27:39 +0100 (Tue, 10 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Add confirmation on extension uninstallation.

Reuses the Install dialog (and makes it slightly more generic).

BUG=27162
TEST=None

Review URL: http://codereview.chromium.org/376030
------------------------------------------------------------------------
r31534 | tony@chromium.org | 2009-11-10 02:55:57 +0100 (Tue, 10 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Fix memory stomping by ImageLoadingTracker in BrowserActionButton.

In the views code, tracker_ is set to null in this case.  Without
this, I get lots of random crashes when I have 2 page actions
installed (buildbot extension and google tasks extension) and I open
close lots of windows.

BUG=26751,25558

Review URL: http://codereview.chromium.org/379020
------------------------------------------------------------------------
r31531 | estade@chromium.org | 2009-11-10 02:41:31 +0100 (Tue, 10 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Clean up dead code path in bookmark bar.

TBR=erg
TEST=tryservers
Review URL: http://codereview.chromium.org/377042
------------------------------------------------------------------------
r31529 | estade@chromium.org | 2009-11-10 02:33:05 +0100 (Tue, 10 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/spellcheck_host.cc
   M /trunk/src/chrome/browser/spellcheck_host.h

Couple of prospective fix for memory test flakiness: addref/release the url request context getter appropriately; fix a leak.

Passing as a straight pointer without addreffing was copied from the previous spellchecker impl. Using .release() instead of = NULL was a plain old mistake.

BUG=none
TEST=memory test flakiness goes away hopefully?

Review URL: http://codereview.chromium.org/379015
------------------------------------------------------------------------
r31528 | tim@chromium.org | 2009-11-10 02:32:19 +0100 (Tue, 10 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/sync_cycle_state.h
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/engine/syncer_status.h
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h

Removes blocked items. Also, some minor cleanup in preparation for (and to help minimize diffs from) a larger CL. 

(Cloned from http://codereview.chromium.org/371071, which was part of an http:// checkout,
 and this one is an svn:// checkout, so that I can commit).

BUG=25266


Review URL: http://codereview.chromium.org/371092
------------------------------------------------------------------------
r31526 | eroman@chromium.org | 2009-11-10 02:23:24 +0100 (Tue, 10 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher.cc

Add instrumentation to track down a crash.

Promotes some DCHECKs to CHECKs, to figure out who is calling URLFetcher::Start() without having first set a valid request context.

Also adds a |was_cancelled_| variable to rule out that Start() isn't called after the request was already cancelled.

This change can be reverted once we get the data.

BUG=27074

Review URL: http://codereview.chromium.org/377041
------------------------------------------------------------------------
r31521 | ananta@chromium.org | 2009-11-10 02:13:11 +0100 (Tue, 10 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Return false from TabContentsViewWin::HandleKeyboardEvent even if the tab contents delegate
(ExternaltabContainer) handled the keyboard event by sending it off to IE. This is to avoid
the subsequent keyboard messages from being suppressed.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=27173 which caused a number
of keyboard messages like Shift + characters to not work in ChromeFrame. 

This regressed in revision 29857


Review URL: http://codereview.chromium.org/376031
------------------------------------------------------------------------
r31520 | jcampan@chromium.org | 2009-11-10 02:11:19 +0100 (Tue, 10 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Disabling a failing browser test.

BUG=http://crbug.com/27216
TBR=willchan

Review URL: http://codereview.chromium.org/377043
------------------------------------------------------------------------
r31517 | mpcomplete@chromium.org | 2009-11-10 01:24:38 +0100 (Tue, 10 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc

Fix memory leak in AsyncExtensionFunction.

BUG=27196

Review URL: http://codereview.chromium.org/377036
------------------------------------------------------------------------
r31513 | tony@chromium.org | 2009-11-10 01:17:44 +0100 (Tue, 10 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Fix a bug where we would cache the incognito profile pointer in
DOMUIThemeSource and try to use it after it was deleted.
Instead, always cache the original profile pointer (which will
live longer).

While I'm here, get rid of the profile_ cached in
NewTabHTMLSource because we don't need it after the ctor is done
running.

BUG=26840

Review URL: http://codereview.chromium.org/372072
------------------------------------------------------------------------
r31507 | dumi@chromium.org | 2009-11-10 00:43:34 +0100 (Tue, 10 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/db_message_filter.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Adding support for DatabaseTracker messages to
DatabaseDispatcherHost. This code will get called as soon as we switch
from WebCore's DatabaseTracker implementation to Chromium's. Also,
cleaned up the pre-existing support for VFS messages.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/340067
------------------------------------------------------------------------
r31504 | oshima@chromium.org | 2009-11-10 00:35:16 +0100 (Tue, 10 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/chrome.gyp

* Add History menu to back/forward buttons in compact navigation bar.
* Enable/Dislable back/forward button to reflect the state of command.

BUG=26498, 26264
TEST=None

Review URL: http://codereview.chromium.org/366033
------------------------------------------------------------------------
r31501 | oshima@chromium.org | 2009-11-10 00:12:21 +0100 (Tue, 10 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

fix hover animation regression.

BUG=27119
TEST=None

Review URL: http://codereview.chromium.org/371082
------------------------------------------------------------------------
r31498 | nick@chromium.org | 2009-11-10 00:03:20 +0100 (Tue, 10 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Fix a few spelling mistakes.

Review URL: http://codereview.chromium.org/355046
------------------------------------------------------------------------
r31495 | willchan@chromium.org | 2009-11-09 23:44:32 +0100 (Mon, 09 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Add bug number for flaky LocalStorageLayoutTests.
BUG=27194

Review URL: http://codereview.chromium.org/371085
------------------------------------------------------------------------
r31493 | mark@chromium.org | 2009-11-09 23:38:35 +0100 (Mon, 09 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm

BackingStoreMac scrolling update and DCHECKs.

Functional change: when a CGBitmapContext is in use instead of a CGLayer,
scroll.  CGLayerGetSize(NULL) was just returning (0.0, 0.0), which was causing
no scrolling.

Functional change: avoid entering the scroll blitter if:
(0 < abs(dx) < size_.width() and abs(dy) >= size_.height()) or
(0 < abs(dy) < size_.height() and abs(dx) >= size_.width())

Non-functional change: DCHECK in a few spots that exactly one of a CGLayer and
a CGBitmapContext is present.

BUG=26989
TEST=Things should paint when scrolling.
Review URL: http://codereview.chromium.org/376028
------------------------------------------------------------------------
r31492 | ben@chromium.org | 2009-11-09 23:35:23 +0100 (Mon, 09 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Slow down animations for the tabstrip so they're visible again.

http://crbug.com/27119
TEST=create a new tab. you should see it animate in.

Review URL: http://codereview.chromium.org/378034
------------------------------------------------------------------------
r31488 | jcampan@chromium.org | 2009-11-09 23:21:28 +0100 (Mon, 09 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Reverting 31479.
The interactive UI tests still fail on the build bot.

TBR=sky
Review URL: http://codereview.chromium.org/372071
------------------------------------------------------------------------
r31486 | oshima@chromium.org | 2009-11-09 23:06:19 +0100 (Mon, 09 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_location_bar.cc
   A /trunk/src/chrome/browser/views/dropdown_bar_host.cc
   A /trunk/src/chrome/browser/views/dropdown_bar_host.h
   A /trunk/src/chrome/browser/views/dropdown_bar_host_gtk.cc
   A /trunk/src/chrome/browser/views/dropdown_bar_host_win.cc (from /trunk/src/chrome/browser/views/find_bar_host_win.cc:31485)
   A /trunk/src/chrome/browser/views/dropdown_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_win.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/chrome.gyp

Refactored FindBarHost/View to create DropdownBarHostView, which I'm plannig to use this
for CompactLocationBar.

BUG=None
TEST=enabled find_bar_host_browsertest.cc for linux view build.

Review URL: http://codereview.chromium.org/360044
------------------------------------------------------------------------
r31485 | oshima@chromium.org | 2009-11-09 23:03:33 +0100 (Mon, 09 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_browsertest.cc

Fix BrowserTest.NoTitle/Title for chromeos build.

BUG=None
TEST=run browser_tests --gtest_filter=Browser.NoTitle (and Title)

Review URL: http://codereview.chromium.org/371076
------------------------------------------------------------------------
r31482 | xiyuan@chromium.org | 2009-11-09 22:51:14 +0100 (Mon, 09 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Fix issue 5982

Change load flags of save page URLRequest from LOAD_ONLY_FROM_CACHE to LOAD_PREFERRING_CACHE so that we could save "no-cache,no-store" pages.

BUG=5982
TEST=Verify fix for issue 5982.

Review URL: http://codereview.chromium.org/371077
------------------------------------------------------------------------
r31479 | jcampan@chromium.org | 2009-11-09 22:40:42 +0100 (Mon, 09 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Tentatively reenabling tests now that I fixed a test running before this one
that was doing a 
Ctrl-Esc instead of Esc, bringing up the Windows start menu.
Not sure why it would cause the tests to fail on the bot, probably an activation
issue (that I cannot repro locally).

BUG=26996
TEST=Make sure the interactive UI tests stay green on the Window build bot.

Review URL: http://codereview.chromium.org/379009
------------------------------------------------------------------------
r31478 | chocobo@google.com | 2009-11-09 22:25:25 +0100 (Mon, 09 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/app/gfx/skbitmap_operations.cc
   M /trunk/src/app/gfx/skbitmap_operations.h
   M /trunk/src/app/gfx/skbitmap_operations_unittest.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/network_library.cc
   M /trunk/src/chrome/browser/chromeos/network_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h

Add UI for turning on/off network devices.
BUG=26636
TEST=run skbitmap_operations_unittest
Review URL: http://codereview.chromium.org/353028
------------------------------------------------------------------------
r31476 | pinkerton@chromium.org | 2009-11-09 22:21:37 +0100 (Mon, 09 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Get rid of flickering of the old tab in the content area, caused by not drawing the newly dropped tab contents until we got back to the event loop.
BUG=none
TEST=tab dragging in and out of windows, should be no flicker when dropping a new tab into an existing window.
Review URL: http://codereview.chromium.org/377038
------------------------------------------------------------------------
r31475 | jcampan@chromium.org | 2009-11-09 22:20:32 +0100 (Mon, 09 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc

Landing georgey's CL

See http://codereview.chromium.org/361032

Review URL: http://codereview.chromium.org/378032
------------------------------------------------------------------------
r31474 | mark@chromium.org | 2009-11-09 22:08:50 +0100 (Mon, 09 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm

w pixels * 4 channels * 8 bits/channel / 8 bits/byte = w * 4 bytes/row

BUG=26989
TEST=Things should paint even when scrolling.
Review URL: http://codereview.chromium.org/376026
------------------------------------------------------------------------
r31472 | rohitrao@chromium.org | 2009-11-09 22:01:37 +0100 (Mon, 09 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/animatable_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/fast_resize_view.h
   A /trunk/src/chrome/browser/cocoa/fast_resize_view.mm
   A /trunk/src/chrome/browser/cocoa/fast_resize_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/view_resizer.h
   M /trunk/src/chrome/chrome.gyp

[Mac] Adds a "fast resize mode" in which the RenderWidgetHostViewCocoa is clipped rather than resized.  Useful for when animations are running.

BUG=http://crbug.com/26857
TEST=Animations should still work.  Infobar animations should be smoother.  The web contents will clip or fill with white at the bottom while the animation is running, but should resize and draw correctly when the animation finishes.
Review URL: http://codereview.chromium.org/372056
------------------------------------------------------------------------
r31469 | pinkerton@chromium.org | 2009-11-09 21:54:16 +0100 (Mon, 09 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Make the target window main when dragging a tab onto it so it looks more like a drop target. Remove placeholder when tab gets dragged out.
BUG=25584
TEST=dragging tabs out and back in
Review URL: http://codereview.chromium.org/372066
------------------------------------------------------------------------
r31468 | dmaclach@chromium.org | 2009-11-09 21:44:44 +0100 (Mon, 09 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm

Makes the window not autocalculate its content border thickness, and fixes it
to 24 pixels.

BUG=25684
TEST=See bug for repro steps.

Review URL: http://codereview.chromium.org/372065
------------------------------------------------------------------------
r31466 | sky@chromium.org | 2009-11-09 21:17:33 +0100 (Mon, 09 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Makes it so app_modal_dialog_gtk can work with views/gtk.

I'm also removing a bunch of dead files from chrome.gyp.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/377033
------------------------------------------------------------------------
r31465 | willchan@chromium.org | 2009-11-09 21:14:36 +0100 (Mon, 09 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Revert 31419 - Commit Issue 255057: Unit Test for Toggling of Encoding AutoDetect

BUG=23617
TEST=BrowserEncodingTest.TestToggleAutoDetect


TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/378031
------------------------------------------------------------------------
r31464 | phajdan.jr@chromium.org | 2009-11-09 21:08:34 +0100 (Mon, 09 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc

Fix a memory leak in ExtensionsServiceTest by ensuring that the message loop
runs after destroying the ExtensionsService.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/381006
------------------------------------------------------------------------
r31462 | avi@chromium.org | 2009-11-09 20:50:10 +0100 (Mon, 09 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

Theme the text of the download item so it's readable with dark themes.

BUG=http://crbug.com/21559
TEST=as in bug

Review URL: http://codereview.chromium.org/377015
------------------------------------------------------------------------
r31461 | tony@chromium.org | 2009-11-09 20:27:47 +0100 (Mon, 09 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc
   A /trunk/src/chrome/browser/gtk/fullscreen_exit_bubble_gtk.h
   M /trunk/src/chrome/chrome.gyp

First cut at Exit Fullscreen bubble on Linux.

It shows and disappears after 3 seconds.  There is no way to bring it
back.

The following remain to be done:
- Rounding the bottom corners (with a radius of 8, ActAsRoundedWindow
  looks ugly) and make it transparent.
- Slide in/out animation.
- Implement the logic in the Windows version for when to show or hide the
  bubble.  It's pretty complicated and I haven't decided whether to
  port it or to try to share it.

BUG=8405

Review URL: http://codereview.chromium.org/374023
------------------------------------------------------------------------
r31460 | willchan@chromium.org | 2009-11-09 20:25:33 +0100 (Mon, 09 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Revert 31458 - Revert "Always destroy the ExtensionsService on UI thread."

It introduced memory leaks in tests. I have to ensure that
all message loops run pending tasks to guarantee that
ExtensionsService will be destroyed.

TBR=erikkay

Review URL: http://codereview.chromium.org/377034

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/378029
------------------------------------------------------------------------
r31458 | phajdan.jr@chromium.org | 2009-11-09 20:21:47 +0100 (Mon, 09 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Revert "Always destroy the ExtensionsService on UI thread."

It introduced memory leaks in tests. I have to ensure that
all message loops run pending tasks to guarantee that
ExtensionsService will be destroyed.

TBR=erikkay

Review URL: http://codereview.chromium.org/377034
------------------------------------------------------------------------
r31455 | ben@chromium.org | 2009-11-09 20:12:32 +0100 (Mon, 09 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h

BrowserTabStrip should not be a TabStrip2 subclass, instead, it should just use it.

Note that this results in the BrowserTabStrip being leaked. I will solve this problem later.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/379002
------------------------------------------------------------------------
r31450 | sky@chromium.org | 2009-11-09 19:37:14 +0100 (Mon, 09 Nov 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/state_tracker.cc
   A /trunk/src/chrome/browser/state_tracker.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome.gyp

Adds more debugging code in hopes of figuring out why on dragging the
tab strip model is empty, but not the tab strip. The latest crash data
indicates the tab strip is not closing all.

BUG=24132
TEST=none

Review URL: http://codereview.chromium.org/375017
------------------------------------------------------------------------
r31448 | willchan@chromium.org | 2009-11-09 19:33:16 +0100 (Mon, 09 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Mark DOMStorageTest.LocalStorageLayoutTests as flaky.
Failed http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests/builds/14458/steps/ui_tests/logs/stdio

Review URL: http://codereview.chromium.org/372064
------------------------------------------------------------------------
r31446 | finnur@chromium.org | 2009-11-09 19:15:52 +0100 (Mon, 09 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Try one other thing temporarily to try to determine cause for a flaky test.

TBR=jcampan
BUG=16447
TEST=This is changing a test

Review URL: http://codereview.chromium.org/376024
------------------------------------------------------------------------
r31443 | jcampan@chromium.org | 2009-11-09 18:50:19 +0100 (Mon, 09 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc

Fix for a test that was sending a Ctrl-Esc instead of Esc key events.

BUG=None
TEST=Run the tests.

Review URL: http://codereview.chromium.org/377031
------------------------------------------------------------------------
r31441 | phajdan.jr@chromium.org | 2009-11-09 18:47:23 +0100 (Mon, 09 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc

Make AutomatedUITestBase.CloseBrowserWindow more solid.

It still crashes the browser under test, but less frequently.
Preserving the FLAKY_ mark in the test.

TEST=none
BUG=14774

Review URL: http://codereview.chromium.org/371066
------------------------------------------------------------------------
r31434 | phajdan.jr@chromium.org | 2009-11-09 17:38:33 +0100 (Mon, 09 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Always destroy the ExtensionsService on UI thread.

This should help with stability.

TEST=Covered by unit_tests.
BUG=none

Review URL: http://codereview.chromium.org/371061
------------------------------------------------------------------------
r31433 | thakis@chromium.org | 2009-11-09 17:29:27 +0100 (Mon, 09 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Fix tests.

TBR=avi

Review URL: http://codereview.chromium.org/377030
------------------------------------------------------------------------
r31432 | thakis@chromium.org | 2009-11-09 17:24:26 +0100 (Mon, 09 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm

Make download items less annoying by handling clicks more correctly.

BUG=21916
TEST=Download two files, click first downoad item, click second download item. Both should open, no context menu should appear.

Review URL: http://codereview.chromium.org/371060
------------------------------------------------------------------------
r31429 | thakis@chromium.org | 2009-11-09 17:13:11 +0100 (Mon, 09 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.h
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.mm

Mac: Theme "Show all downloads..." link.

Refactor HyperlinkCell a bit and make it less crashy.

This depends on http://codereview.chromium.org/377026 (the changes form that CL are contained in this CL too. Ignore them.)

BUG=none
TEST=Install theme, "Show all downloads..." color should change. Uninstall theme through installing the "classic" theme in the gallery, link should be blue again. Hit "Reset to default theme" in prefs, theme should still be blue. Open and close shelf a few times and change themes, nothing should crash.

Review URL: http://codereview.chromium.org/371059
------------------------------------------------------------------------
r31428 | thakis@chromium.org | 2009-11-09 17:08:49 +0100 (Mon, 09 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Mac: Let status bubble dodge to the right if necessary.

Windows seems to do this either if a shelf is visible or if the status bubble would slide off screen, so chrome/mac now does that too :-/

Note that the right-aligned bubble overlaps a vertical scrollbar if present. That matches windows.

BUG=22198
TEST=See bug. Also test that if both popup block bubble and status bubble are at the right, the status bubble should be on top of the popup block bubble.

Review URL: http://codereview.chromium.org/372051
------------------------------------------------------------------------
r31421 | thakis@chromium.org | 2009-11-09 06:40:43 +0100 (Mon, 09 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/chrome.gyp

Mac: Make download shelf use GTM ui stuff.

xib changes (a bit more complicated than anticipated, because GTMUI decided to resize the image view to 0x0, since its image is only loaded in DownloadShelfController's awakeFromNib -- hence I couldn't make the image view a child of the width-based resizer):

* Replace text view with a button that has a HyperlinkView cell
* Change its text to ^IDS_SHOW_ALL_DOWNLOADS
* Add localizer and ui localizer/layout tweaker objects
* Put close button and new button into a width-based tweaker
* Put item container and image view into a box
* Let width-based tweaker resize said box

No intended functionality change. This is a prerequisite for http://codereview.chromium.org/371059 .

BUG=None
TEST=download shelf still looks like it did before, resizing hides download items when the icon would touch them.

Review URL: http://codereview.chromium.org/377026
------------------------------------------------------------------------
r31419 | rolandsteiner@chromium.org | 2009-11-09 05:33:11 +0100 (Mon, 09 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Commit Issue 255057: Unit Test for Toggling of Encoding Auto-Detect

BUG=23617
TEST=BrowserEncodingTest.TestToggleAutoDetect

------------------------------------------------------------------------
r31416 | thestig@chromium.org | 2009-11-09 05:21:51 +0100 (Mon, 09 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   A /trunk/src/chrome/browser/crash_handler_host_linux.cc (from /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc:31186)
   A /trunk/src/chrome/browser/crash_handler_host_linux.h (from /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.h:31186)
   A /trunk/src/chrome/browser/crash_handler_host_linux_stub.cc (from /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux_stub.cc:31186)
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   D /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   D /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.h
   D /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux_stub.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/plugin/DEPS
   M /trunk/src/chrome/plugin/plugin_main.cc

Linux: Catch plugin crashes.

BUG=25964
TEST=none
Review URL: http://codereview.chromium.org/371015
------------------------------------------------------------------------
r31414 | jam@chromium.org | 2009-11-09 01:56:22 +0100 (Mon, 09 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memory leak I introduced in my earlier change.

BUG=27035
Review URL: http://codereview.chromium.org/376020
------------------------------------------------------------------------
r31412 | mhm@chromium.org | 2009-11-09 01:12:09 +0100 (Mon, 09 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h

Kiosk Mode implementation.

Kiosk mode will just hide the status bar and initially set it as full screen. Added some tests to add --kiosk mode as a command switch that tests if its in fullscreen state and doesn't have a status bubble.

BUG=23145
TEST=Kiosk Mode functions and
     Run the ./ui_tests --gtest_filter=KioskModeTest.*

Review URL: http://codereview.chromium.org/244003
------------------------------------------------------------------------
r31409 | pfeldman@chromium.org | 2009-11-08 21:01:10 +0100 (Sun, 08 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h

DevTools: handle the case where client host is disposed while in the list of orphan ones.

Review URL: http://codereview.chromium.org/374029
------------------------------------------------------------------------
r31408 | mirandac@chromium.org | 2009-11-08 20:04:54 +0100 (Sun, 08 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/sys_string_conversions.h
   M /trunk/src/base/sys_string_conversions_mac.mm
   A /trunk/src/base/sys_string_conversions_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm

Fix NSString conversions to treat a null NSString as a string of length 0, instead of crashing. This allows Cocoa to use null objects as empties, as is its wont, and we only run a check when needed.

This CL also removes the now-superfluous checks for null NSStrings from BugReportWindowController.  A cursory look through the code shows that there are many places where a check for null precedes a call to an NSString conversion; filed another bug against myself to go through and fix all of these (http://code.google.com/p/chromium/issues/detail?id=27055).  Also filed a bug to expand unit tests for NSString conversion methods (http://code.google.com/p/chromium/issues/detail?id=27059).


Review URL: http://codereview.chromium.org/371057
------------------------------------------------------------------------
r31403 | joi@chromium.org | 2009-11-08 15:02:58 +0100 (Sun, 08 Nov 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/background.html
   M /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/test.html
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h

Modifying extension automation so that it is done through a particular
tab for all extension views.  Previously, API routing to the
automation client would only work for extension views that were
contained in the particular ExternalTab instance being automated. This
meant you couldn't test API calls from e.g. background pages.

Also using async functions instead of the previous RVH-based hack.

Updating one of the UI tests to make the API calls from a background
page, to provide an end-to-end test of the new routing.

This makes AutomationProvider::SetEnableAutomationExtension
Windows-only, but it effectively always was since it was already
dependent on ExternalTabContainer (indirectly, to provide a non-empty
implementation of TabContentsDelegate::ForwardMessageToExternalHost).

BUG=none
TEST=ui_tests.exe, chrome_frame_tests.exe, chrome_frame_unittests.exe

Review URL: http://codereview.chromium.org/366025
------------------------------------------------------------------------
r31401 | jeremy@chromium.org | 2009-11-08 13:22:53 +0100 (Sun, 08 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_list.cc
   M /trunk/src/chrome/browser/importer/importer_list.h

Make sure we don't get an outside array element.

BUG=None
TEST=covered by unit_tests.

Review URL: http://codereview.chromium.org/343076
------------------------------------------------------------------------
r31399 | finnur@chromium.org | 2009-11-08 04:08:17 +0100 (Sun, 08 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Remove flaky label for FindInPageControllerTest.FindDisappearOnNavigate

When I started looking into the test flakiness, it
turns out it hasn't failed in 3 weeks, according to
Phajdan's logs, so I am removing the Flaky label.

BUG=16447
TEST=This is a test change.

Review URL: http://codereview.chromium.org/371054
------------------------------------------------------------------------
r31397 | ben@chromium.org | 2009-11-08 02:54:05 +0100 (Sun, 08 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Fix toolkit_views build


Review URL: http://codereview.chromium.org/375021
------------------------------------------------------------------------
r31394 | ben@chromium.org | 2009-11-08 00:12:38 +0100 (Sun, 08 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Move all the stuff relating to detached tab dragging out of BrowserFrameWin and onto the TabStrip2 object. It was mostly cross platform anyway.Adds APIs to Widget that:- allow a Widget to be obtained for a given gfx::NativeView- allow native properties to be set on a Widget.Adds an API to Window that lets the caller convert the window's appearance into a lightly transparent transient looking thing for dragging.BUG=noneTEST=none
Review URL: http://codereview.chromium.org/149440
------------------------------------------------------------------------
r31391 | thestig@chromium.org | 2009-11-07 21:48:10 +0100 (Sat, 07 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Mark BrowserTest.SingleBeforeUnloadAfterWindowClose as flaky.

TBR=creis

BUG=27039
TEST=none
Review URL: http://codereview.chromium.org/372046
------------------------------------------------------------------------
r31388 | mirandac@chromium.org | 2009-11-07 17:26:14 +0100 (Sat, 07 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ReportBug.xib
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm

Allow return key to add new line in description text field.

BUG= 26860
TEST= open bug report. enter multi-line description, using return to insert newlines.

Review URL: http://codereview.chromium.org/374024
------------------------------------------------------------------------
r31387 | ananta@chromium.org | 2009-11-07 16:39:55 +0100 (Sat, 07 Nov 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/renderer_glue.cc

Amit, please review everything.
jam, please review changes to the plugin create channel IPCs.
mpcomplete, please review changes to chrome_plugin_host.cc

ChromeFrame needs to intercept URL requests issued directly by plugins like gears to ensure that they
get routed through the host browser network stack. We decide whether or not a request is to be handled
based on the renderer process id and the render view id (routing id), which get passed in the
ViewHostMsg_RequestResource IPC. If this request is issued by Gears then the routing id comes in as
MSG_ROUTING_NONE, which causes the request to go through the chrome network stack.

Fix is to pass the host render view id to the plugin in the PluginMsg_Init IPC. The plugin already
receives the renderer process id. Both these ids now come back in the ViewHostMsg_RequestResource
IPC.

This fixes an issue with wave when rendered in full tab mode in ChromeFrame, where dropping a file into
a wave would cause the renderer to hang.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=23992

Bug=23992

Review URL: http://codereview.chromium.org/370007
------------------------------------------------------------------------
r31386 | phajdan.jr@chromium.org | 2009-11-07 16:13:22 +0100 (Sat, 07 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc

Fix threading issues in BlacklistManager, using new ChromeThread.

TEST=Covered by unit_tests and browser_tests.
BUG=21541

Review URL: http://codereview.chromium.org/361030
------------------------------------------------------------------------
r31383 | pfeldman@chromium.org | 2009-11-07 13:07:24 +0100 (Sat, 07 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc

DevTools: Wire Ctrl+Shift+I to DevTools, Ctrl+Shift+J to JavaScript console. This way modifiers are consistent on Mac and it makes sense on Windows/Linux.

------------------------------------------------------------------------
r31372 | markus@chromium.org | 2009-11-07 07:09:38 +0100 (Sat, 07 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   M /trunk/src/sandbox/linux/seccomp/access.cc
   M /trunk/src/sandbox/linux/seccomp/clone.cc
   M /trunk/src/sandbox/linux/seccomp/exit.cc
   M /trunk/src/sandbox/linux/seccomp/ioctl.cc
   M /trunk/src/sandbox/linux/seccomp/ipc.cc
   M /trunk/src/sandbox/linux/seccomp/madvise.cc
   M /trunk/src/sandbox/linux/seccomp/maps.cc
   M /trunk/src/sandbox/linux/seccomp/maps.h
   M /trunk/src/sandbox/linux/seccomp/mmap.cc
   M /trunk/src/sandbox/linux/seccomp/mprotect.cc
   M /trunk/src/sandbox/linux/seccomp/munmap.cc
   M /trunk/src/sandbox/linux/seccomp/open.cc
   M /trunk/src/sandbox/linux/seccomp/sandbox.cc
   M /trunk/src/sandbox/linux/seccomp/sandbox.h
   M /trunk/src/sandbox/linux/seccomp/sandbox_impl.h
   M /trunk/src/sandbox/linux/seccomp/securemem.cc
   M /trunk/src/sandbox/linux/seccomp/socketcall.cc
   M /trunk/src/sandbox/linux/seccomp/stat.cc
   M /trunk/src/sandbox/linux/seccomp/syscall_table.h
   M /trunk/src/sandbox/linux/seccomp/trusted_process.cc

Allow the seccomp sandbox to be enabled, even if the suid sandbox has
already put a chroot() jail around it. The only tricky part is access
to /proc/self/maps, but we can safely pass in an open file descriptor.

BUG=26527
Review URL: http://codereview.chromium.org/371047
------------------------------------------------------------------------
r31371 | aa@chromium.org | 2009-11-07 07:03:19 +0100 (Sat, 07 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Fix typo from r31351

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r31365 | rafaelw@chromium.org | 2009-11-07 03:51:18 +0100 (Sat, 07 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   A /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   A /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/docs/static/pageAction.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

Reland Extension Installed InfoBubble

(fix mac build breakage)

This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.

TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.

BUG=21412
TBR=willchan

Review URL: http://codereview.chromium.org/376014
------------------------------------------------------------------------
r31363 | tommi@chromium.org | 2009-11-07 03:35:04 +0100 (Sat, 07 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/plugin_url_request.cc
   M /trunk/src/chrome_frame/test/net/test_automation_provider.cc
   M /trunk/src/chrome_frame/test/net/test_automation_resource_message_filter.cc

Basic wiring to enable downloads for CF's host browser network stack.  A notable change here is that url automation job id's no longer exist and instead a request id is used.  There's a 1 to 1 relation between a job and a request so this is more convenient.
Review URL: http://codereview.chromium.org/355036
------------------------------------------------------------------------
r31361 | hclam@chromium.org | 2009-11-07 03:27:23 +0100 (Sat, 07 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/url_request/view_cache_helper.cc

Clear disk cache when the cache is not initialized

BUG=24765
TEST=unit test, clear browsing data and the cache, media cache will
     be cleared even if a media object was not loaded.

Since the disk cache backend in HttpCache is lazily initialized, clearing
the cache before it receives the first transaction would have no effect.
So initialize the disk cache explicitly when we clear the cache.

Review URL: http://codereview.chromium.org/378015
------------------------------------------------------------------------
r31360 | maruel@chromium.org | 2009-11-07 03:23:06 +0100 (Sat, 07 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/non_client_view.cc

Fix style issues in View class.

BUG=None
TEST=None

Patch contributed by thiago.farina@gmail.com

Review URL: http://codereview.chromium.org/338011
------------------------------------------------------------------------
r31357 | jam@chromium.org | 2009-11-07 02:56:19 +0100 (Sat, 07 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_remote.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.h
   M /trunk/src/chrome/browser/extensions/autoupdate_interceptor.h
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/favicon_service.h
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/jumplist.h
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_request_info.h
   M /trunk/src/chrome/browser/strict_transport_security_persister.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Ninth patch in making destructors of refcounted objects private.

BUG=26749

Review URL: http://codereview.chromium.org/372013
------------------------------------------------------------------------
r31355 | jcampan@chromium.org | 2009-11-07 02:40:18 +0100 (Sat, 07 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Temporary disabling interactive tests that are failing on the build bot
(not locally) since the tests have been moved out of process.

BUG=26996
TEST=Interactive test build bot should be green.
TBR=sky
Review URL: http://codereview.chromium.org/377021
------------------------------------------------------------------------
r31354 | yurys@google.com | 2009-11-07 02:40:03 +0100 (Sat, 07 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/pause_on_exception.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: add pause on exception test

Review URL: http://codereview.chromium.org/353020
------------------------------------------------------------------------
r31352 | pkasting@chromium.org | 2009-11-07 02:34:53 +0100 (Sat, 07 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/base/base.gyp
   M /trunk/src/base/i18n/icu_string_conversions.cc
   M /trunk/src/base/i18n/icu_string_conversions.h
   M /trunk/src/base/i18n/icu_string_conversions_unittest.cc
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/utf_string_conversions.cc
   M /trunk/src/base/utf_string_conversions.h
   A /trunk/src/base/utf_string_conversions_unittest.cc (from /trunk/src/base/string_util_unittest.cc:30908)
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/net/browser_url_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Fix various problems with inline autocomplete and URLs that change length during fixup:
* URLs with http auth info, which gets stripped
* URLs with IDN hosts
* URLs with escaped values that get unescaped

In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode.

The fix is to track how fixup affects the offsets into the URL we care about.  Plumbing this required an enormous number of additions :(

There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match.  Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong).  This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it).

BUG=4010
TEST=Covered by unittests
Review URL: http://codereview.chromium.org/372017
------------------------------------------------------------------------
r31351 | aa@chromium.org | 2009-11-07 02:33:24 +0100 (Sat, 07 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Improve the look of the extensions management page when no
extensions are installed.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r31349 | jennb@chromium.org | 2009-11-07 02:17:14 +0100 (Sat, 07 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/api/public/WebRuntimeFeatures.h
   M /trunk/src/webkit/api/src/WebRuntimeFeatures.cpp

Change application cache cmd line enabling to use the new RuntimeEnabledFeatures code.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/377002
------------------------------------------------------------------------
r31348 | jam@chromium.org | 2009-11-07 02:06:28 +0100 (Sat, 07 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.h
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h

Tenth patch in making destructors of refcounted objects private.

BUG=26749

Review URL: http://codereview.chromium.org/376007
------------------------------------------------------------------------
r31347 | viettrungluu@chromium.org | 2009-11-07 02:03:38 +0100 (Sat, 07 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Mac: fix tab closure problem when close tab buttons not shown.

BUG=26889
TEST=See bug description.

Review URL: http://codereview.chromium.org/373020
------------------------------------------------------------------------
r31345 | jcampan@chromium.org | 2009-11-07 01:34:47 +0100 (Sat, 07 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Reenabled a bunch of interactive UI tests on Linux,
one of them still fails.

BUG=26540
TEST=Run interactive ui tests on Linux.
TBR=willchan

Review URL: http://codereview.chromium.org/374021
------------------------------------------------------------------------
r31344 | creis@chromium.org | 2009-11-07 01:33:51 +0100 (Sat, 07 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Prevents an old RenderViewHost from preempting a cross-site navigation once the unload request has been made.

This fixes a bug where competing navigations could either cause the tab to close unexpectedly or all future cross-site navigations (and possibly tab close attempts) to fail.

BUG=23942
BUG=26839
TEST=TabContentsTest.CrossSiteCantPreemptAfterUnload

Review URL: http://codereview.chromium.org/372014
------------------------------------------------------------------------
r31339 | jam@chromium.org | 2009-11-07 01:23:14 +0100 (Sat, 07 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Eighth patch in making destructors of refcounted objects private.

BUG=26749
Review URL: http://codereview.chromium.org/378004
------------------------------------------------------------------------
r31335 | aa@chromium.org | 2009-11-07 01:12:29 +0100 (Sat, 07 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Make the inspector for the background page stay open when
reloading an extension.

BUG=25287
TEST=Load an extension that has a background page and reload it. Inspector should stay open and continue
working.

Review URL: http://codereview.chromium.org/371040
------------------------------------------------------------------------
r31330 | thakis@chromium.org | 2009-11-07 01:00:27 +0100 (Sat, 07 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/webkit/api/src/EditorClientImpl.cpp

[mac] Add "Paste and Match Style" to edit menu

xib change: Added "^IDS_PASTE_MATCH_STYLE_MAC" to edit menu below paste with key equiv cmd-opt-shift-v, hooked up to pasteAsPlainText: on first responder.

BUG=25205
TEST=Cmd-shift-v no longer pastes. Cmd-shift-opt-v does paste, _and_ blinks the menu.

Review URL: http://codereview.chromium.org/371034
------------------------------------------------------------------------
r31327 | jcampan@chromium.org | 2009-11-07 00:50:42 +0100 (Sat, 07 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc

Relanding the CL that made interactive UI tests run out-of-proc.
It was causing them to hang on Windows.
I cannot repro on my box.
I added a timeout to the ViewEventTest as I suspect they are the
ones causing the timeout.

Original review:
http://codereview.chromium.org/355014/show

TEST=None
TBR=rafael

Review URL: http://codereview.chromium.org/360016
------------------------------------------------------------------------
r31326 | willchan@chromium.org | 2009-11-07 00:48:54 +0100 (Sat, 07 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   D /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   D /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/docs/static/pageAction.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

Revert 31322 - Extension Installed InfoBubble

This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.

TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.

BUG=21412

Review URL: http://codereview.chromium.org/362022

TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/375019
------------------------------------------------------------------------
r31325 | finnur@chromium.org | 2009-11-07 00:41:11 +0100 (Sat, 07 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc

Adding traces to a test when it fails in the hope of at
least ruling some things out. These traces will be 
either be removed (once I get more data).

TBR=jcampan
BUG=16447
TEST=This is changing a test

Review URL: http://codereview.chromium.org/373019
------------------------------------------------------------------------
r31324 | aa@chromium.org | 2009-11-07 00:39:14 +0100 (Sat, 07 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Also reload extensions management page for extensions that
don't have a process.

BUG=NONE
TEST=Open two chrome windows, navigate one to extensions management UI. Install an extension that has no background process in the other. Management UI should show the installed extension automatically, without reload.

Review URL: http://codereview.chromium.org/371043
------------------------------------------------------------------------
r31322 | rafaelw@chromium.org | 2009-11-07 00:27:01 +0100 (Sat, 07 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   A /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc
   A /trunk/src/chrome/browser/views/extensions/extension_installed_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/docs/static/pageAction.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

Extension Installed InfoBubble

This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.

TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.

BUG=21412

Review URL: http://codereview.chromium.org/362022
------------------------------------------------------------------------
r31320 | thakis@chromium.org | 2009-11-07 00:22:47 +0100 (Sat, 07 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Make sure to fire menu items only once per key. Also, crash less.

Followup to http://codereview.chromium.org/293019 .

BUG=none
TEST=Open 2 tabs, go to first tab, go to google.com, make sure that web has focus, hit cmd-w. Chrome shouldn't crash.

Review URL: http://codereview.chromium.org/372034
------------------------------------------------------------------------
r31318 | shess@chromium.org | 2009-11-07 00:07:25 +0100 (Sat, 07 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

[Mac] Defer close from renderer while tab is a drag source.

When dragging a link out of web content, pin the tab so that it
doesn't close out from under the drag.

BUG=26134
TEST=See bug for test.html.  View test.html.  Dragging link out should cause page to not close, and app should no longer crash.

Review URL: http://codereview.chromium.org/372023
------------------------------------------------------------------------
r31316 | dmaclach@chromium.org | 2009-11-06 23:50:44 +0100 (Fri, 06 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BrowserWindow.xib
   A /trunk/src/chrome/app/theme/newtab_h.pdf
   A /trunk/src/chrome/app/theme/newtab_p.pdf
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp

Adds hover and pressed states for the newtab button on the Mac.
BrowserWindow.xib change was to add newtab_p as the image for the alternate
state for the new tab button.
BUG=26205
TEST=1) mouse over the new tab button and it should highlight. 
     2) Click and hold on the new tab button and its state should change
     3) Release, and watch new tab get created. Verify that new button state
        changes appropriately
     4) Create a full tab strip of tabs. Verify that button state stays
        correct as you click on the new tab button and new tabs are created but
        the button doesn't move.
     5) Create 2 tabs, and move the mouse button into the newtab button.
        See that it highlights. hit cmd-w to close a tab. As the newtab button
        moves away from under the cursor make sure it loses its highlight.
        
Review URL: http://codereview.chromium.org/372009
------------------------------------------------------------------------
r31315 | aa@chromium.org | 2009-11-06 23:49:48 +0100 (Fri, 06 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Open the extensions manager tab in single-tab-per-window mode.

Review URL: http://codereview.chromium.org/372016
Patch from Akira <akira@yayakoshi.net>.
------------------------------------------------------------------------
r31312 | pinkerton@chromium.org | 2009-11-06 23:21:50 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm

Bulletproof the url going into a std::string and ensure it's not going to
be NULL, which throws and exception.
BUG=26883
TEST=dragging things into the content area (urls, images, text, etc)
Review URL: http://codereview.chromium.org/373016
------------------------------------------------------------------------
r31310 | jorlow@chromium.org | 2009-11-06 23:02:16 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Reenable tests that were disabled due to the epic flakyness of LocalStorage which has since been fixed.

TEST=none
BUG=25746

Review URL: http://codereview.chromium.org/377011
------------------------------------------------------------------------
r31309 | akalin@chromium.org | 2009-11-06 23:01:09 +0100 (Fri, 06 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Added menu item for sync to wrench menu.

 Wrench menu item is right above "Preferences...".  Chrome menu item will be added in a future CL right above "Clear Browsing Data...".  Sync menu items are hidden if bookmark sync is disabled (the current default for OS X).  UI decisions were made after consulting with Cole.

Added code in browser_window_controller.mm to update sync menu item dynamically.

Added unit tests.

BUG=23073
TEST=manual testing, trybots, unittests

Review URL: http://codereview.chromium.org/363017
------------------------------------------------------------------------
r31302 | pfeldman@chromium.org | 2009-11-06 22:26:05 +0100 (Fri, 06 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h

DevTools: provide a way for clients to detach and attach client hosts to render views.
BUG=25287

Review URL: http://codereview.chromium.org/375011
------------------------------------------------------------------------
r31301 | estade@chromium.org | 2009-11-06 22:24:20 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

GTK: Fix context menu positioning.

There are still some issues with context menus. The context menu doesn't respect links, for example. That is, if you tab to a link and hit the menu button, it will act as if you right clicked on the upper left pixel of the web page (both in content and position of the menu). This seems to be a webkit bug/missing feature as safari 4 on windows does the same. However, some cases do work as expected, for example if you select text and hit the menu button. Anyway, I'll do the webkit side of this fix as some later patch.

BUG=26811

Review URL: http://codereview.chromium.org/371033
------------------------------------------------------------------------
r31298 | munjal@chromium.org | 2009-11-06 22:15:33 +0100 (Fri, 06 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc

Part 2 of string cleanup in Sync:
- Get rid of sync_char16 from syncapi
- Use wstring for title in syncapi since that gets converted to wstring
  later on anyway.
- Use GURL for urls in syncapi
- Return const string references from syncapi instead of pointers to
  C-style strings.
- Make appropriate changes to calling code.

BUG=26342
TEST=Already exist.


Review URL: http://codereview.chromium.org/362019
------------------------------------------------------------------------
r31296 | estade@chromium.org | 2009-11-06 22:09:57 +0100 (Fri, 06 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.h

GTK: Change find bar to use a floating container rather than some hacked up gtkfixed business.

The straw that broke this camel's back was when I realized that showing the findbar in fullscreen mode would inescapably mean an extra 1 pixel border at the top.

Also fix z-ordering problems for findbar that have been around since I introduced the floating bookmark bar (the fact that no one filed a bug on this suggests that it's not that noticeable).

BUG=none
TEST=find bar still works. find bar works in fullscreen. the toolbar bottom border still exists at all times. there are no z-ordering problems. the find bar still gets out of way of find results.

Review URL: http://codereview.chromium.org/373007
------------------------------------------------------------------------
r31295 | estade@chromium.org | 2009-11-06 22:09:50 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

Add another drag flavor for bookmark menu controller menu items.

BUG=26835

Review URL: http://codereview.chromium.org/372003
------------------------------------------------------------------------
r31293 | mattm@chromium.org | 2009-11-06 22:08:56 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/common/gtk_tree.cc
   M /trunk/src/chrome/common/gtk_tree.h

Rename gtk_tree::ModelAdapter to TableAdapter in preparation for adding TreeAdapter.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/374007
------------------------------------------------------------------------
r31289 | willchan@chromium.org | 2009-11-06 21:47:40 +0100 (Fri, 06 Nov 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Revert 31284 - Added menu item for sync to wrench menu.

 Wrench menu item is right above "Preferences...".  Chrome menu item will be added in a future CL right above "Clear Browsing Data...".  Sync menu items are hidden if bookmark sync is disabled (the current default for OS X).  UI decisions were made after consulting with Cole.

Added code in browser_window_controller.mm to update sync menu item dynamically.

Added unit tests.

BUG=23073
TEST=manual testing, trybots, unittests

Review URL: http://codereview.chromium.org/363017

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/374017
------------------------------------------------------------------------
r31287 | thakis@chromium.org | 2009-11-06 21:34:24 +0100 (Fri, 06 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Send keypress() events for ctrl-key and cmd-key in addition to keydown().

The ctrl-key behavior matches what Safari does: We first send a keydown for ctrl-key, and only if the key is not an emacs shortcut, we send a keypress.

The cmd-key behavior is slightly different from Safari: Safari triggers menu items after the keypress command has not been swallowed by javascript. We trigger menu items after keydown. That means that if the user hits cmd-key, we send a keydown and only send a keypress if the shortcut doesn't trigger a menu item. Safari always sends both keydown and keypress.

BUG=25249
TEST=Go to http://unixpapa.com/js/testkey.html . Hit ctrl-a, only a keydown should be generated. Hit ctrl-s, both keydown and keypress should be generated. Hit cmd-a, only a keydown should be generated. Hit cmd-shift-a, both keypress and keydown should be generated. Also, ctrl-1 now makes something a heading in google docs. Cmd-s and Cmd-f should still work in docs.

Review URL: http://codereview.chromium.org/293019
------------------------------------------------------------------------
r31285 | finnur@chromium.org | 2009-11-06 21:28:34 +0100 (Fri, 06 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Extensions UI page should not allow Reload forextensions that are not 'in development' andshould not DCHECK when uninstalling a disabledextension.I also reordered the links on the page, now thatwe show the Reload link conditionally, sinceit is weird to enable extensions after this change.The order starts out as...Disable - Reload - Uninstall... then when you press Disable it becomes:          Enable - Uninstallpress Enable, it becomes:Disable - Reload - UninstallNotice how the Reload link pops up where Enable linkwas and where you'd expect Disable to be?TEST=Open chrome://extensions and make sure extensionsloaded with --load-extension have the Reload optionand when you disable an extension it does not DCHECKin debug version of Chrome.BUG=http://crbug.com/26901, http://crbug.com/26910
Review URL: http://codereview.chromium.org/374014
------------------------------------------------------------------------
r31284 | akalin@chromium.org | 2009-11-06 21:26:30 +0100 (Fri, 06 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Added menu item for sync to wrench menu.

 Wrench menu item is right above "Preferences...".  Chrome menu item will be added in a future CL right above "Clear Browsing Data...".  Sync menu items are hidden if bookmark sync is disabled (the current default for OS X).  UI decisions were made after consulting with Cole.

Added code in browser_window_controller.mm to update sync menu item dynamically.

Added unit tests.

BUG=23073
TEST=manual testing, trybots, unittests

Review URL: http://codereview.chromium.org/363017
------------------------------------------------------------------------
r31283 | viettrungluu@chromium.org | 2009-11-06 21:20:47 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Mac: show correct default favicon in tab strip.

We should show the "blank page" favicon for pages which don't have their own (this favicon is used everywhere else for this purpose), not the "globe" (nav.pdf) favicon.

BUG=26953
TEST=Go to, e.g., "about:blank" and check the favicon in the tab in the tab strip.

Review URL: http://codereview.chromium.org/373012
------------------------------------------------------------------------
r31272 | idana@chromium.org | 2009-11-06 20:59:03 +0100 (Fri, 06 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc

Got rid of DieFileDie in user_settings_unittest.cc.

It turns out that the v10 -> v11 database migration code had a bug
where the destination file (SyncData.sqlite3) wasn't copied into the
correct directory. I fixed that problem too.

BUG=21834

Review URL: http://codereview.chromium.org/366011
------------------------------------------------------------------------
r31269 | tony@chromium.org | 2009-11-06 20:55:16 +0100 (Fri, 06 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/courgette/courgette_tool.cc
   M /trunk/src/media/bench/bench.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc

Use GetSwitchValueASCII.

BUG=24672
TEST=None

Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/296004

Review URL: http://codereview.chromium.org/373013
------------------------------------------------------------------------
r31268 | tony@chromium.org | 2009-11-06 20:52:33 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc

Another regression from r31031: Fix RWHV sizing in extension popups.
Without this call, the RWH didn't actually change size and was
always 0x0.

BUG=26927

Review URL: http://codereview.chromium.org/376011
------------------------------------------------------------------------
r31258 | sky@chromium.org | 2009-11-06 19:55:04 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Attempt at fixing crash when showing bookmark model. The crash
indicates the node is null, which should only happen if adding the
bookmark failed. Adding a bookmark can fail if the url isn't valid.

BUG=26858
TEST=make sure star button still works

Review URL: http://codereview.chromium.org/371011
------------------------------------------------------------------------
r31256 | jorlow@chromium.org | 2009-11-06 19:45:01 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Turn LocalStorage on by default.

TEST=none
BUG=4360

Review URL: http://codereview.chromium.org/366032
------------------------------------------------------------------------
r31254 | sky@chromium.org | 2009-11-06 19:44:00 +0100 (Fri, 06 Nov 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Fixes bug where clicking on bookmark in a folder or home button
doesn't revert the autocomplete. The current approach of sprinkling
Revert throughout the code is easy to forget. I've put the code in
Browser so that everyone should pick it up.

If you're ok with this, I'll see if there are some calls to Revert I
can remove.

BUG=25842
TEST=add the home button to the toolbar, navigate to a page other than
the home page, type some text in the omnibox, click the home button,
make sure the text in the omnibox changes to show the url of the home
page.

Review URL: http://codereview.chromium.org/361008
------------------------------------------------------------------------
r31250 | sky@chromium.org | 2009-11-06 19:19:30 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Relaxes constraint that typing in a url in the omnibox of a pinned tab
opens in foreground to allow changes to the path of the url to open in
current tab.

BUG=26490
TEST=none

Review URL: http://codereview.chromium.org/372001
------------------------------------------------------------------------
r31249 | willchan@chromium.org | 2009-11-06 19:16:24 +0100 (Fri, 06 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable OptionsPage test.
BUG=26948

Review URL: http://codereview.chromium.org/371024
------------------------------------------------------------------------
r31247 | jcampan@chromium.org | 2009-11-06 19:00:48 +0100 (Fri, 06 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Poor work-around for the crasher 23411.
Somehow pending_render_view_host_ in RenderViewHostManager is deleted
without being NULLed, which I still don't know why.
Hoefully the NOTREADED() in there will be hit by somehow and help shed
some light on the conditions.

BUG=23411
TEST=Make sure navigating across sites and closing tabs and browsers while
     navigating works as expected.

Review URL: http://codereview.chromium.org/378001
------------------------------------------------------------------------
r31245 | thomasvl@chromium.org | 2009-11-06 18:57:46 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Some style cleanup from comments after commit.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/372022
------------------------------------------------------------------------
r31242 | zork@google.com | 2009-11-06 18:29:33 +0100 (Fri, 06 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc

Fix the mediator thread to check for a valid xmpp client before trying to
process commands.  This fixes the problem where the auto-reconnect posts a
login command just after the client connects, just before a listen for updates
command is posted.

BUG=24245
TEST=Send a CMD_LISTEN_FOR_UPDATES immediately after the CMD_LOGIN in
MediatorThreadImpl::Login()  Chromium will no longer crash.

Review URL: http://codereview.chromium.org/372011
------------------------------------------------------------------------
r31241 | erikkay@chromium.org | 2009-11-06 18:24:36 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc

add some histograms to extensions

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/372005
------------------------------------------------------------------------
r31239 | johnnyg@chromium.org | 2009-11-06 18:02:36 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Correctly route the notifications permission-request-complete callback to the process/route which generated it.  It might not be the same tab that's showing the infobar, particularly if it comes from an extension.

BUG=26859
TEST=request notifications permission from an extension and allow it.

Review URL: http://codereview.chromium.org/378005
------------------------------------------------------------------------
r31238 | mirandac@chromium.org | 2009-11-06 18:01:11 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ReportBug.xib
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm

Fix ReportBug dialog so that cancel button moves with the send button as it expands and contracts when its title changes.

BUG= none
TEST= Open report bug dialog; choose "Send phishing report" and note that cancel button moves as send button expands.

Review URL: http://codereview.chromium.org/372021
------------------------------------------------------------------------
r31237 | pinkerton@chromium.org | 2009-11-06 18:00:55 +0100 (Fri, 06 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Prevent being caught in a drag without the correct set up being first performed, caused by some strange context menu interactions. This doesn't fix why we're in this situation, only a band-aid for any problems it could cause.
BUG=25682
TEST=clicking tabs, dragging tabs, closing tabs, anything with tabs, and the case covered in the bug to ensure there are no crashes.
Review URL: http://codereview.chromium.org/355027
------------------------------------------------------------------------
r31236 | pinkerton@chromium.org | 2009-11-06 17:56:29 +0100 (Fri, 06 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Fix issue where transparent window background wouldn't show up until after you'd dragged a tab out, then back in, then out again.
BUG=21580
TEST=tab dragging
Review URL: http://codereview.chromium.org/373011
------------------------------------------------------------------------
r31235 | thomasvl@chromium.org | 2009-11-06 17:46:27 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Prefs l10n width tweaks
- Small shuffle to the basics page to make things look a little better
- Support for the three areas that get really wide in the prefs ui forcing the window wider, this will make sure nothing is clipped in any language.

BUG=26586
TEST=try french, german, etc. to make sure no buttons extend off the side of the prefs window.
Review URL: http://codereview.chromium.org/378012
------------------------------------------------------------------------
r31234 | johnnyg@chromium.org | 2009-11-06 17:27:26 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   A /trunk/src/chrome/test/data/find_in_page/select_changes_ordinal.html
   M /trunk/src/webkit/api/src/WebFrameImpl.cpp

Update the find result index "(m of n)" whenever there is an active selection on a find next.

BUG=20883
TEST=included
Review URL: http://codereview.chromium.org/335012
------------------------------------------------------------------------
r31232 | mirandac@chromium.org | 2009-11-06 17:00:49 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm

Fix crasher caused by not checking for empty strings before converting.

BUG= 26855
TEST= See bug report for repro steps.
Review URL: http://codereview.chromium.org/371012
------------------------------------------------------------------------
r31229 | pfeldman@chromium.org | 2009-11-06 15:59:26 +0100 (Fri, 06 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

DevTools: Follow up to r31226. Fixed one of the toggledevtools calls.
tbr=apavlov

------------------------------------------------------------------------
r31225 | pfeldman@chromium.org | 2009-11-06 14:55:01 +0100 (Fri, 06 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

DevTools: Wire Ctrl+Shift+C to "Show JavaScript console".

Review URL: http://codereview.chromium.org/377005
------------------------------------------------------------------------
r31215 | eroman@chromium.org | 2009-11-06 09:58:16 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h

Remove an access to Profile from the IO thread.

Also explicitly hold a reference to the URLRequestContextGetter as long as the task is outstanding on the IO thread.

BUG=26893

Review URL: http://codereview.chromium.org/371016
------------------------------------------------------------------------
r31214 | hclam@chromium.org | 2009-11-06 09:32:17 +0100 (Fri, 06 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/version_loader.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/print_ui.h
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_manager.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/file_reader.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Revert "Revert r31175 r31176 r31187"

The bustage seems to be a WebKit change upstream. It is not reverted in
WebKit and merger. So bring the innocent change back in.

TBR=jam
TEST=green tree

Review URL: http://codereview.chromium.org/375009
------------------------------------------------------------------------
r31213 | viettrungluu@chromium.org | 2009-11-06 08:55:22 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/tab_cell.h
   D /trunk/src/chrome/browser/cocoa/tab_cell.mm
   D /trunk/src/chrome/browser/cocoa/tab_cell_unittest.mm

Delete several empty files (chrome/browser/cocoa/tab_cell*).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/373009
------------------------------------------------------------------------
r31209 | robertshield@chromium.org | 2009-11-06 07:11:18 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/chrome_frame_distribution.cc
   M /trunk/src/chrome/installer/util/chrome_frame_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h

Remove build time differences between Chrome Frame and Google Chrome in the
SafeBrowsing code.

BUG=26012
TEST=None

Review URL: http://codereview.chromium.org/360059
------------------------------------------------------------------------
r31208 | ananta@chromium.org | 2009-11-06 06:57:17 +0100 (Fri, 06 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h

The URLRequestAutomationJob object which needs to route HTTP requests to the host browser for
ChromeFrame's host network stack implementation can register itself as a protocol factory for http/https
instead of using the mechanism to intercept HTTP requests which Gears and the App cache use. This ensures
that Gears works partially with ChromeFrame.

The protocol factory mechanism also has the same limitation as the intercept mechanism, i.e. it does not
support chaining.

Partial fix for http://code.google.com/p/chromium/issues/detail?id=23992

Bug=23992

Review URL: http://codereview.chromium.org/365009
------------------------------------------------------------------------
r31207 | ian@chromium.org | 2009-11-06 05:58:48 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/cookies_tree_model.cc
   A /trunk/src/chrome/browser/cookies_tree_model.h
   A /trunk/src/chrome/browser/cookies_tree_model_unittest.cc (from /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc:31033)
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/tree/tree_view.cc

Converting the Cookies options page from a TableView to a TreeView
so that we can add in Database, LocalStorage, and Appcache next
to the cookies for an origin.

BUG=26713
TEST=cookies_tree_model_unittest.cc

Review URL: http://codereview.chromium.org/365005
------------------------------------------------------------------------
r31206 | estade@chromium.org | 2009-11-06 05:46:09 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Fix a leak caught by valgrind following r31199

TBR=jam

Review URL: http://codereview.chromium.org/375007
------------------------------------------------------------------------
r31204 | pam@chromium.org | 2009-11-06 05:08:54 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/chrome.gyp

Implement window.alert() and its cousins for extensions.
Second try, now with fixed observer.

BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a page action.
Make sure it gets the result back correctly. Also make sure it still works when
called from a web page.
Review URL: http://codereview.chromium.org/373006
------------------------------------------------------------------------
r31203 | mrossetti@chromium.org | 2009-11-06 05:03:47 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm

Broke a couple of unit tests while bringing them up-to-date with CocoaTest.

TBR=jrg@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/378006
------------------------------------------------------------------------
r31201 | hclam@chromium.org | 2009-11-06 04:28:20 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/version_loader.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/print_ui.h
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_manager.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/file_reader.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Rever r31175 r31176 r31187

XP tests are failing, the guess is r31175 and r31176.

TBR=beng
TEST=XP tests go green

Review URL: http://codereview.chromium.org/376008
------------------------------------------------------------------------
r31200 | mrossetti@chromium.org | 2009-11-06 04:24:29 +0100 (Fri, 06 Nov 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/BookmarkAllTabs.xib
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   A /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implement Bookmark All Tabs... Added an abstraction of BookmarkEditorController called BookmarkEditorBaseController, from which BookmarkEditorController and the new BookmarkAllTabsController derive.  The bookmark/folder name, URL and OK button now use bindings/KVO.  Added BookmarkAllTabs.xib which is nearly identical to BookmarkEditor.xib.  Changed unit test since an empty bookmark name is now acceptable.  Added unit test for the Bookmark All Tabs...

BookmarkEditor.xib changes: Removed the bookmark name and url as outlets and instead bound their values to controller's displayName and displayURL respectively.  Bound the OK button enabling to the controller's okEnabled.

BUG=25099
TEST=Open two or more tabs.  Bring up a contextual menu by control-clicking on one of the tabs.  Choose the Bookmark All Tabs... menu item.  A dialog will be presented in which you can type a folder name and select the parent folder in which the new folder will be placed.  By default, the most recently touched folder will be selected as the parent.  Click OK.  Now check to parent folder to see that the newly created folder has been added and then check within that folder to see that the open tabs have been added.

Perform the above operation again only this time choose the Bookmark All Tabs... menu item found in the Bookmarks menu.

Review URL: http://codereview.chromium.org/357005
------------------------------------------------------------------------
r31199 | estade@chromium.org | 2009-11-06 04:05:46 +0100 (Fri, 06 Nov 2009) | 28 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   A /trunk/src/chrome/browser/spellcheck_host.cc
   A /trunk/src/chrome/browser/spellcheck_host.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker_mac.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   A /trunk/src/chrome/renderer/spellchecker
   A /trunk/src/chrome/renderer/spellchecker/spellcheck.cc (from /trunk/src/chrome/browser/spellchecker.cc:30148)
   A /trunk/src/chrome/renderer/spellchecker/spellcheck.h (from /trunk/src/chrome/browser/spellchecker.h:30148)
   A /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.cc (from /trunk/src/chrome/browser/spellcheck_worditerator.cc:30148)
   A /trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.h (from /trunk/src/chrome/browser/spellcheck_worditerator.h:30148)
   M /trunk/src/chrome/test/testing_profile.h

Move the spellchecker to the renderer.

The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread.

This breaks the SpellChecker class into two new classes.
1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread.
2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process).

My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor.

There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work:
- dictionary is loaded lazily
- hunspell is initialized lazily, per renderer
- language changes work.
- Dynamic downloading of new dictionaries
- auto spell correct works (as well as toggling it).
- disabling spellcheck works.
- custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate")

TODO:
- move spellchecker unit tests to test SpellCheck2
- add sync IPC for platform spellchecker; port to Mac
- add dictionary location fallback; port to Windows
- remove SpellChecker classes from browser/

BUG=25677

Review URL: http://codereview.chromium.org/357003
------------------------------------------------------------------------
r31198 | suzhe@chromium.org | 2009-11-06 03:57:51 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Reverts some useful code accidently removed by CL http://codereview.chromium.org/340024/show

BUG=12316, 24818
TEST=Clear the omnibox, and paste something into it by middle click, the inline autocomplete shouldn't be triggered.
TEST=Input something in the omnibox to trigger inline autocomplete, then press and hold ctrl key and click the text to clear the selection, then release ctrl key, the text in the omnibox shouldn't be changed.

Review URL: http://codereview.chromium.org/362018
------------------------------------------------------------------------
r31197 | thakis@chromium.org | 2009-11-06 03:43:51 +0100 (Fri, 06 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_browser_application_mac.mm
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Do not send input menu toggle events to the web.

This changes us back from the sendEvent:-based approach to the performKeyEquivalent:-based one. The main problem with the pKE: approach was that ctrl-tab toggled the view loop. However, I found an SPI in WebKit's source that enables us to work around that.

I tested lots of stuff, but there are of course chances that this regresses something. The only sane way to write unit tests for all that keyhandling crap however is to sendEvent: keys to NSApp and have a complete browser with renderers running, and browser tests don't work on OS X yet :-/

BUG=26115
TEST=Open SysPrefs->Keyboard and configure cmd-space to switch input languages. Go to a page that blocks js events (e.g. http://unixpapa.com/js/testkey.html ,  check the two left checkboxes), cmd-space should still switch input languages. ) All the cases listed at the end of http://sites.google.com/a/chromium.org/dev/developers/os-x-keyboard-handling .

Review URL: http://codereview.chromium.org/363024
------------------------------------------------------------------------
r31195 | mark@chromium.org | 2009-11-06 03:04:29 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Don't leak orphan renderer processes.  Don't leak RenderWidgetHosts associated
with pop-up menus.

BUG=26311, 26876
TEST=Open a tab with a pop-up menu, use the pop-up menu, and then close all
     windows.  There should be no renderer processes running.
Review URL: http://codereview.chromium.org/374006
------------------------------------------------------------------------
r31194 | idana@chromium.org | 2009-11-06 03:00:53 +0100 (Fri, 06 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc

Revert 31122 - Revert 31109  Avoid calling PlatformThread::Sleep(1) from event_sys_unittests.cc

BUG=21833

Review URL: http://codereview.chromium.org/360040

TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/361035

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/377001
------------------------------------------------------------------------
r31193 | estade@chromium.org | 2009-11-06 02:56:59 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Erase the thin green line on the floating NTP bookmark bar (un-themed mode).

BUG=26740

Review URL: http://codereview.chromium.org/371005
------------------------------------------------------------------------
r31192 | jam@chromium.org | 2009-11-06 02:55:48 +0100 (Fri, 06 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/net/url_request_context_getter.h
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   M /trunk/src/chrome/browser/password_manager/password_store_kwallet.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc

Seventh patch in making destructors of refcounted objects private.

BUG=26749
Review URL: http://codereview.chromium.org/371006
------------------------------------------------------------------------
r31188 | atwilson@chromium.org | 2009-11-06 02:43:56 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/worker/worker_main.cc

Added support for --worker-startup-dialog command line flag.
Added ChildProcess::WaitForDebugger() utility routine, and changed the various
processes to use it.

Review URL: http://codereview.chromium.org/370006
------------------------------------------------------------------------
r31187 | jam@chromium.org | 2009-11-06 02:16:53 +0100 (Fri, 06 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/version_loader.h

Fix chromeos build break
------------------------------------------------------------------------
r31186 | rohitrao@chromium.org | 2009-11-06 01:57:40 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FindBar.xib
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_text_field.h
   A /trunk/src/chrome/browser/cocoa/find_bar_text_field.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_text_field_cell.h
   A /trunk/src/chrome/browser/cocoa/find_bar_text_field_cell.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_text_field_cell_unittest.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_text_field_unittest.mm
   A /trunk/src/chrome/browser/cocoa/styled_text_field.h
   A /trunk/src/chrome/browser/cocoa/styled_text_field.mm
   A /trunk/src/chrome/browser/cocoa/styled_text_field_cell.h
   A /trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm
   A /trunk/src/chrome/browser/cocoa/styled_text_field_cell_unittest.mm
   A /trunk/src/chrome/browser/cocoa/styled_text_field_test_helper.h
   A /trunk/src/chrome/browser/cocoa/styled_text_field_test_helper.mm
   A /trunk/src/chrome/browser/cocoa/styled_text_field_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Draw the results label correctly in the findbar.

Adds common base classes (StyledTextField and StyledTextFieldCell) for both the find bar and omnibox text fields.

BUG=http://crbug.com/19550
TEST=Findbar results label should not be overdrawn by find text.
TEST=Autocomplete drawing (keyword, hint, lock icon) should not be affected.
Review URL: http://codereview.chromium.org/319005
------------------------------------------------------------------------
r31183 | shess@chromium.org | 2009-11-06 01:50:29 +0100 (Fri, 06 Nov 2009) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

[Mac] Delay TabContents::Close() when event-tracking.

The close is delayed until the main event loop restarts.

Renderers can cause UI state changes which can badly break
event-tracking loops.  The basic pattern is "Run JavaScript to close
window after a timeout, and start event-tracking loop and keep it
going across the timeout."  Things crash when UI elements attempt to
refer to freed objects.  Examples:

 - Last tab in a window closes while dragging the window.
 - Last tab in a window closes while bookmark bar context menu visible.
 - Last tab in a window closes while download shelf context menu visible.
 - Tab closes while dragging a link over the tab.
 - Tab closes while dragging a link from the tab.
 - Tab closes while back/forward context menu is open.
 - Tab closes while click-hold in the tab's close button.
 - Tab closes while closing info bar.
 - Tab closes while tab context menu is visible.
 - Probably more I'm not aware of.

Supersedes (and reverts) previous fix for issues 25462 and 25465.

BUG=25462, 25463, 25465, 26135, 26136, 26137, 25467
TEST=See bugs for repro cases.

Review URL: http://codereview.chromium.org/362013
------------------------------------------------------------------------
r31182 | creis@chromium.org | 2009-11-06 01:45:18 +0100 (Fri, 06 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

Fixes navigations chrome-internal: to actually show the NTP.

We now rewrite chrome-internal: (the old NTP URL) to chrome://newtab.  Before, we were not properly showing the NTP for this URL, which caused some problems with further navigations (particularly form submissions) from that tab.

Also, the default kHomePage string is now chrome://newtab instead of the outdated chrome-internal:.  The logic in GeneralPageView is already designed to not show this URL in the preferences dialog.

BUG=6564
TEST=NewTabUITest.ChromeInternalLoadsNTP

Review URL: http://codereview.chromium.org/363019
------------------------------------------------------------------------
r31181 | jhawkins@chromium.org | 2009-11-06 01:42:15 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   A /trunk/src/chrome/browser/autofill/personal_data_manager.cc
   A /trunk/src/chrome/browser/autofill/personal_data_manager.h
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Add a stub implementation of PersonalDataManager, the connection between the database and the autofill manager.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360027
------------------------------------------------------------------------
r31180 | mirandac@chromium.org | 2009-11-06 01:42:11 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

Fix first run OEM bubble size issue.

BUG= 20267
TEST= Force the first run OEM bubble to appear on a Windows machine with "classic" and "aero" theme.  Note that the box is large enough to contain the text in both cases.

Review URL: http://codereview.chromium.org/374001
------------------------------------------------------------------------
r31179 | aa@chromium.org | 2009-11-06 01:40:10 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

If the download manager setting "prompt for a location for each downloaded file" is set, we weren't installing user scripts.

It probably makes sense to check the ".user.js" on the URL always, instead of the path, since that is really what is supposed to happen  conceptually.

BUG=26801
TEST=Set settings to always prompt for download location. Install user script. Should get extension install prompt.

Review URL: http://codereview.chromium.org/372006
------------------------------------------------------------------------
r31176 | jam@chromium.org | 2009-11-06 01:32:01 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_manager.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/file_reader.h
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h

Sixth patch in making destructors of refcounted objects private.

BUG=26749

Review URL: http://codereview.chromium.org/370001
------------------------------------------------------------------------
r31175 | jam@chromium.org | 2009-11-06 01:31:36 +0100 (Fri, 06 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/chromeos/version_loader.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/print_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Fifth patch in making destructors of refcounted objects private.

BUG=26749

Review URL: http://codereview.chromium.org/361025
------------------------------------------------------------------------
r31170 | aa@chromium.org | 2009-11-06 00:41:36 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Change prevents multiple instances of an extension's option page from being opened within one window when teh "Options" button is pressed on the extensions settings page.

BUG=none
TEST=Install an extension that specifies an options_page in it's manifest file. Open the extensions page (wrench menu) and click the "Options" button for that extension. The options page will open and come to the forefront. Go back to the extensions tab and click "Options" again. The same tab as before should be brought to the forefront.

Review URL: http://codereview.chromium.org/366026
Patch from Akira <akira@yayakoshi.net>.
------------------------------------------------------------------------
r31168 | viettrungluu@chromium.org | 2009-11-06 00:37:40 +0100 (Fri, 06 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/base/mac_util_unittest.mm
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   A /trunk/src/chrome/browser/memory_details_mac.cc
   A /trunk/src/chrome/browser/process_info_snapshot.h
   A /trunk/src/chrome/browser/process_info_snapshot_mac.cc
   A /trunk/src/chrome/browser/process_info_snapshot_mac_unittest.cc
   A /trunk/src/chrome/browser/resources/about_memory_mac.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Mac: Implement about:memory.

This implements about:memory on Mac. It calls /bin/ps to obtain information
about processes (this is Apple's officially supported "API"). Unfortunately, ps
provides fairly minimal information (rss and vsize); top is better, but not a
stable API -- it has changed greatly between Mac OS 10.5 and 10.6, and moreover
the 10.6 version is more limited in its output formatting.

BUG=9653
TEST=Go to about:memory under a variety of conditions (with a variety of browsers loaded).

Review URL: http://codereview.chromium.org/333008
------------------------------------------------------------------------
r31167 | jam@chromium.org | 2009-11-06 00:37:05 +0100 (Fri, 06 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/extensions/autoupdate_interceptor.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/metadata_url_request.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/net/url_request_failed_dns_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/net/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/test/automation/automation_handle_tracker.h

Fourth patch in making destructors of refcounted objects private.

BUG=26749
Review URL: http://codereview.chromium.org/360043
------------------------------------------------------------------------
r31164 | viettrungluu@chromium.org | 2009-11-06 00:33:55 +0100 (Fri, 06 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h

Mac: don't restore explicitly closed windows.

With "On startup"/"Restore the pages that were open last" set (in Preferences), a window which was explicitly closed (using the red button, Cmd-Shift-W, the menu item -- but not due to quit) should not be restored on startup. This is the behaviour of Firefox and Camino (Safari doesn't appear to implement this feature).

Note about this patch: Depending on how we decide things will work for App mode, much more code could be disabled on Mac.

BUG=13341
TEST=Set the browser to restore pages on start (see above). Navigate somewhere interesting; close window; quit; restart; should open a browser with default window (NTP or homepage or whatever). Navigate somewhere; quit; restart; should open previously opened stuff. Make sure that session restore (also crash recovery) still work as expected.

Review URL: http://codereview.chromium.org/362016
------------------------------------------------------------------------
r31162 | atwilson@chromium.org | 2009-11-06 00:31:38 +0100 (Fri, 06 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/webkit/api/src/SharedWorkerRepository.cpp

Added support for --enable-shared-workers
Added a --enable-shared-workers flag, and return false from SharedWorkerRepository::isAvailable() if it is not set.

BUG=26233
TEST=None (unit tests do not run yet)

Review URL: http://codereview.chromium.org/372004
------------------------------------------------------------------------
r31161 | tony@chromium.org | 2009-11-06 00:28:51 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc

Don't let the user inline edit "Bookmarks Bar" or "Other Bookmarks"
in the bookmark manager.

BUG=26779

Review URL: http://codereview.chromium.org/360064
------------------------------------------------------------------------
r31157 | cira@chromium.org | 2009-11-06 00:26:30 +0100 (Fri, 06 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Don't reload whole chrome://extensions page when interacting with single extension (disable/enable...).

BUG=26163
TEST=Click on Disable/Reload links and check if the whole page got reloaded.

Review URL: http://codereview.chromium.org/341076
------------------------------------------------------------------------
r31156 | rohitrao@chromium.org | 2009-11-06 00:24:23 +0100 (Fri, 06 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.h
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm

[Mac] Adds animations for the download shelf.

Nib file changes:
- Connected DownloadShelfView's delegate_ to DownloadShelfController.

BUG=http://crbug.com/25602
TEST=Download shelf should animate open/closed.
Review URL: http://codereview.chromium.org/342083
------------------------------------------------------------------------
r31152 | estade@chromium.org | 2009-11-05 23:39:56 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: hack around floating bookmark bar stuck-in-prelight bug.

BUG=26299

Review URL: http://codereview.chromium.org/363022
------------------------------------------------------------------------
r31149 | nick@chromium.org | 2009-11-05 23:34:29 +0100 (Thu, 05 Nov 2009) | 3 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/util/highres_timer.h
   D /trunk/src/chrome/browser/sync/util/highres_timer_linux.cc
   D /trunk/src/chrome/browser/sync/util/highres_timer_linux.h
   D /trunk/src/chrome/browser/sync/util/highres_timer_mac.cc
   D /trunk/src/chrome/browser/sync/util/highres_timer_mac.h
   D /trunk/src/chrome/browser/sync/util/highres_timer_unittest.cc
   D /trunk/src/chrome/browser/sync/util/highres_timer_win.cc
   D /trunk/src/chrome/browser/sync/util/highres_timer_win.h
   M /trunk/src/chrome/chrome.gyp

Remove the high res timer, which is unused.

Review URL: http://codereview.chromium.org/369006
------------------------------------------------------------------------
r31147 | estade@chromium.org | 2009-11-05 23:31:58 +0100 (Thu, 05 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: fix certain corner cases where overflow chevron wouldn't show.

When a tool item is added but there is no room for it, it doesn't get an allocation right away, so our check to see if it fit was failing. This would be fixed the next time there was an allocate event (e.g. due to a resize).

I noticed while debugging this that SetChevronState is getting called like 10 times in a row when you type in a url and press enter. This is in repsonse to allocate signals. I don't know why there are so many allocate signals, but it warrants further investigation.

BUG=26736

Review URL: http://codereview.chromium.org/372002
------------------------------------------------------------------------
r31146 | sky@chromium.org | 2009-11-05 23:31:23 +0100 (Thu, 05 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc

Clicking on restore window button on ntp now nukes ntp. We always did
this for tabs, just not windows.

BUG=21316
TEST=see bug

Review URL: http://codereview.chromium.org/360060
------------------------------------------------------------------------
r31143 | kuchhal@chromium.org | 2009-11-05 23:31:03 +0100 (Thu, 05 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_mac.mm
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/browser/google_update_settings_posix.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_logging.h
   M /trunk/src/chrome/common/child_process_logging_linux.cc
   M /trunk/src/chrome/common/child_process_logging_mac.mm
   M /trunk/src/chrome/common/child_process_logging_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h

Change id that identifies client in crash reports. Whenever metrics service recording is enabled, it sets the client id for crash reporting.

- On Windows this id gets stored in the registry so that we can read it pretty early regardless of the process type. If the id has not been generated (like in the case of first run) we initialize with empty string but the real id gets inserted once metrics service gets initialized.
- On Linux we were creating a hash and storing it in 'Consent to Send Stats'. This change replaces that hash with the metrics id. Unlike before calling SetConsentToSendStats doesn't generate a new id, if an id already exists.
- On Mac there was no id set. Now we use metrics id as guid for the browser process. For other process types a change is still required to pass that id as command line param to renderers/plugins (like Linux).

BUG=23658
TEST=Cause a deliberate crash in Chrome renderer/browser/plugin and make sure the clientID reported to the crash server is the right GUID.

Review URL: http://codereview.chromium.org/346007
------------------------------------------------------------------------
r31142 | pkasting@chromium.org | 2009-11-05 23:28:58 +0100 (Thu, 05 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc

Clean up usage of some iterators.  Original patch by Thiago Fariana (see http://codereview.chromium.org/343078 ), r=me.

BUG=none
TEST=none
------------------------------------------------------------------------
r31139 | aa@chromium.org | 2009-11-05 22:53:44 +0100 (Thu, 05 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Fix bug where we were not displaying icons in the management
UI for disabled extensions.

Also, desaturate the icons of disabled extensions to make them
look more disabledy.

BUG=25963
TEST=On the extensions page, disable an extension, then press
reload. You should see a greyscale version of the icon.

Review URL: http://codereview.chromium.org/360039
------------------------------------------------------------------------
r31138 | nick@chromium.org | 2009-11-05 22:53:30 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc

Fix the extensions activity monitor test for POSIX (c:\?  Really?)

R=akalin

Review URL: http://codereview.chromium.org/360047
------------------------------------------------------------------------
r31135 | dmaclach@chromium.org | 2009-11-05 22:53:01 +0100 (Thu, 05 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/chrome_application_mac.h (from /trunk/src/chrome/browser/chrome_application_mac.h:30825)
   A /trunk/src/base/chrome_application_mac.mm (from /trunk/src/chrome/browser/chrome_application_mac.mm:30825)
   M /trunk/src/base/message_pump_mac.mm
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   D /trunk/src/chrome/browser/chrome_application_mac.h
   D /trunk/src/chrome/browser/chrome_application_mac.mm
   D /trunk/src/chrome/browser/chrome_application_mac_unittest.mm
   A /trunk/src/chrome/browser/chrome_browser_application_mac.h (from /trunk/src/chrome/browser/chrome_application_mac.h:30825)
   A /trunk/src/chrome/browser/chrome_browser_application_mac.mm (from /trunk/src/chrome/browser/chrome_application_mac.mm:30825)
   A /trunk/src/chrome/browser/chrome_browser_application_mac_unittest.mm (from /trunk/src/chrome/browser/chrome_application_mac_unittest.mm:30825)
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm

Cleans up our autorelease pool handling by making sure that an autorelease pool isn't created while the app is handling an event sent via -[NSApp sendEvent].

Branches browser/chrome_application_mac into browser/chrome_browser_application and base/chrome_application. Renderers will run as chrome_applications, and browsers will run as chrome_browser_applications. 

BUG=26418, 25462, 25463, 25465
TEST=1) See bug 25857. 2) Start up. Open 3+ windows. 3)Quit. See bugs for other repro cases.

Review URL: http://codereview.chromium.org/345051
------------------------------------------------------------------------
r31131 | tc@google.com | 2009-11-05 22:47:49 +0100 (Thu, 05 Nov 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc

Fix the chrome app icon on windows
(and also the icon for the default plugin window).

MSVS's resource compiler can only compile resources of the same
type from a single .rc file, so we can't have ICON types scattered
across rc files.  This change moves all the icon files out of
theme_resources.rc and puts them in chrome_dll.rc.  This worked
in the past because these were different dlls.

This has the side benefit of not including the ico files in
the linux/mac builds.

BUG=26600

Review URL: http://codereview.chromium.org/361031
------------------------------------------------------------------------
r31128 | dmaclach@chromium.org | 2009-11-05 22:45:19 +0100 (Thu, 05 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm

We were calling to an undefined method. I was able to repro this by putting my
patch in (http://codereview.chromium.org/345051) without adding shess's patch
(http://codereview.chromium.org/362013). I'm not sure how to repro otherwise.
Either way, I think this is actually what's intended to happen. Certainly better
than what is there now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/355045
------------------------------------------------------------------------
r31127 | tony@chromium.org | 2009-11-05 22:44:34 +0100 (Thu, 05 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Tell the RWH about the intial window size for drop down menus.
This fixes a bug where all drop down menus were blank (we never
told the renderer our size).

This was regressed in r31031 when I removed the size allocate
handler.

BUG=26759

Review URL: http://codereview.chromium.org/361034
------------------------------------------------------------------------
r31126 | ben@chromium.org | 2009-11-05 22:11:57 +0100 (Thu, 05 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   D /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/chrome.gyp

Revert 31110 - Implement window.alert() and its cousins for extensions.

BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a page action.
  Make sure it gets the result back correctly.  Also make sure it still works when
  called from a web page.
Review URL: http://codereview.chromium.org/341089

TBR=pam@chromium.org
Review URL: http://codereview.chromium.org/360063
------------------------------------------------------------------------
r31122 | ben@chromium.org | 2009-11-05 21:29:49 +0100 (Thu, 05 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc

Revert 31109 - Avoid calling PlatformThread::Sleep(1) from event_sys_unittests.cc

BUG=21833

Review URL: http://codereview.chromium.org/360040

TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/361035
------------------------------------------------------------------------
r31119 | pkasting@chromium.org | 2009-11-05 20:40:26 +0100 (Thu, 05 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc

Fix checkfailure on Linux Views build by actually opening the popup when it's initted.

Also add sanity checking like in the Windows version.

BUG=20511
TEST=none
Review URL: http://codereview.chromium.org/361020
------------------------------------------------------------------------
r31118 | rafaelw@chromium.org | 2009-11-05 20:34:36 +0100 (Thu, 05 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

chrome://extensions/ support for multiple, asynchronous calls to render

This is in anticipation of support for re-rendering the page on extension install/uninstall without reloading.

TEST=none
BUG=26163

Review URL: http://codereview.chromium.org/361027
------------------------------------------------------------------------
r31117 | sky@chromium.org | 2009-11-05 20:12:20 +0100 (Thu, 05 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes bug where choosing reopen closed tba would do nothing for
popups. The bug stemmed from browser initializing the enabled state of
IDC_RESTORE_TAB to false for popups, but CanRestoreTab returns true
for popups. There is no need to diable restoring tabs for popups as we
don't always restore to the current window, or we may end up restoring
a closed window.

BUG=13774
TEST=see bug

Review URL: http://codereview.chromium.org/369005
------------------------------------------------------------------------
r31113 | mirandac@chromium.org | 2009-11-05 19:47:51 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Change "remove thumbnail" message to make it fit nicely above the thumbnails on the NTP.

BUG= 22820
TEST= remove thumbnails. notice that "undo" butterbar doesn't overlap anything or elide text uncomfortably.
Review URL: http://codereview.chromium.org/361017
------------------------------------------------------------------------
r31110 | pam@chromium.org | 2009-11-05 19:22:35 +0100 (Thu, 05 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/jsmessage_box_client.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/chrome.gyp

Implement window.alert() and its cousins for extensions.

BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a page action.
  Make sure it gets the result back correctly.  Also make sure it still works when
  called from a web page.
Review URL: http://codereview.chromium.org/341089
------------------------------------------------------------------------
r31109 | idana@chromium.org | 2009-11-05 19:18:47 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc

Avoid calling PlatformThread::Sleep(1) from event_sys_unittests.cc

BUG=21833

Review URL: http://codereview.chromium.org/360040
------------------------------------------------------------------------
r31096 | atwilson@chromium.org | 2009-11-05 17:27:06 +0100 (Thu, 05 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   D /trunk/src/chrome/renderer/websharedworker_impl.cc
   D /trunk/src/chrome/renderer/websharedworker_impl.h
   A /trunk/src/chrome/renderer/websharedworker_proxy.cc (from /trunk/src/chrome/renderer/websharedworker_impl.cc:31095)
   A /trunk/src/chrome/renderer/websharedworker_proxy.h (from /trunk/src/chrome/renderer/websharedworker_impl.h:31095)
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   A /trunk/src/chrome/worker/websharedworker_stub.cc
   A /trunk/src/chrome/worker/websharedworker_stub.h
   A /trunk/src/chrome/worker/webworker_stub.cc
   A /trunk/src/chrome/worker/webworker_stub.h
   A /trunk/src/chrome/worker/webworker_stub_base.cc
   A /trunk/src/chrome/worker/webworker_stub_base.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt
   M /trunk/src/webkit/api/WebKit.gyp
   A /trunk/src/webkit/api/public/WebCommonWorkerClient.h (from /trunk/src/webkit/api/public/WebWorkerClient.h:31095)
   M /trunk/src/webkit/api/public/WebSharedWorker.h
   M /trunk/src/webkit/api/public/WebWorkerClient.h
   M /trunk/src/webkit/api/src/SharedWorkerRepository.cpp
   A /trunk/src/webkit/api/src/WebSharedWorkerImpl.cpp (from /trunk/src/webkit/api/public/WebSharedWorker.h:31095)
   A /trunk/src/webkit/api/src/WebSharedWorkerImpl.h (from /trunk/src/webkit/api/public/WebSharedWorker.h:31095)

Added beginnings of browser-process support for shared workers.
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.

BUG=26233
TEST=none (will enable layout tests when basic functionality available)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31077

Review URL: http://codereview.chromium.org/351004
------------------------------------------------------------------------
r31091 | jeremy@chromium.org | 2009-11-05 15:04:48 +0100 (Thu, 05 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/browser/utility.sb
   M /trunk/src/chrome/browser/utility_process_host.cc
   A /trunk/src/chrome/browser/worker.sb
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper.h
   A /trunk/src/chrome/common/sandbox_init_wrapper_linux.cc
   A /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   A /trunk/src/chrome/common/sandbox_init_wrapper_win.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm

TBR: mark@chromium.org
------------------------------------------------------------------------
r31090 | jeremy@chromium.org | 2009-11-05 14:15:24 +0100 (Thu, 05 Nov 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   D /trunk/src/chrome/browser/utility.sb
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   D /trunk/src/chrome/browser/worker.sb
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper.h
   D /trunk/src/chrome/common/sandbox_init_wrapper_linux.cc
   D /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   D /trunk/src/chrome/common/sandbox_init_wrapper_win.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm

TBR:mark
------------------------------------------------------------------------
r31089 | jeremy@chromium.org | 2009-11-05 13:50:34 +0100 (Thu, 05 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/browser/utility.sb
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   A /trunk/src/chrome/browser/worker.sb
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper.h
   A /trunk/src/chrome/common/sandbox_init_wrapper_linux.cc
   A /trunk/src/chrome/common/sandbox_init_wrapper_mac.cc
   A /trunk/src/chrome/common/sandbox_init_wrapper_win.cc
   M /trunk/src/chrome/common/sandbox_mac.h
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm

Sandbox Worker process on the Mac.

* Add plumbing to allow multiple Sandbox profiles on OS X.
* Separate sandbox_init_wrapper into platform specific files.
* Sandbox Worker process & add plumbing to Sandbox utility process when we bring that up.
* Remove mention of stale bugs in utility process on Mac.

BUG=23582
TEST=Worker process should work.

Review URL: http://codereview.chromium.org/341033
------------------------------------------------------------------------
r31087 | apavlov@chromium.org | 2009-11-05 12:44:33 +0100 (Thu, 05 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/webkit/api/public/WebDevToolsFrontendClient.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inspector_controller_impl.js
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsfrontend_impl.h

Highlight node with mouse over it while selecting element to inspect

BUG=20969
TEST=none

Review URL: http://codereview.chromium.org/348056
------------------------------------------------------------------------
r31083 | ukai@chromium.org | 2009-11-05 10:32:47 +0100 (Thu, 05 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Enable WebSockets by default

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/360007
------------------------------------------------------------------------
r31082 | jorlow@chromium.org | 2009-11-05 10:16:30 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Switch over to the new way of enabling/disabling session/local storage. 

BUG=none 
TEST=|'localStorage' in window| should only be true iff --enable-local-storage is specified 
Review URL: http://codereview.chromium.org/335034
------------------------------------------------------------------------
r31081 | jorlow@chromium.org | 2009-11-05 10:13:12 +0100 (Thu, 05 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_area.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   M /trunk/src/webkit/api/public/WebStorageArea.h
   M /trunk/src/webkit/api/public/WebStorageEventDispatcher.h
   M /trunk/src/webkit/api/src/StorageAreaProxy.cpp
   M /trunk/src/webkit/api/src/StorageEventDispatcherChromium.cpp
   M /trunk/src/webkit/api/src/StorageEventDispatcherImpl.cpp
   M /trunk/src/webkit/api/src/StorageEventDispatcherImpl.h
   M /trunk/src/webkit/api/src/WebStorageAreaImpl.cpp
   M /trunk/src/webkit/api/src/WebStorageAreaImpl.h
   M /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.cpp
   M /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.h
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/storage/domstorage/localstorage/iframe-events-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/storage/domstorage/localstorage/simple-events-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/storage/domstorage/localstorage/iframe-events-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/storage/domstorage/localstorage/simple-events-expected.txt
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Enable the URL portion of storage events.  This is mostly just plumbing + a hack for making them work in test shell and single process mode.

This replaces http://codereview.chromium.org/335034/show

TEST=none
BUG=24581

Review URL: http://codereview.chromium.org/363014
------------------------------------------------------------------------
r31080 | atwilson@chromium.org | 2009-11-05 09:04:18 +0100 (Thu, 05 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   A /trunk/src/chrome/renderer/websharedworker_impl.cc (from /trunk/src/chrome/renderer/websharedworker_proxy.cc:31079)
   A /trunk/src/chrome/renderer/websharedworker_impl.h (from /trunk/src/chrome/renderer/websharedworker_proxy.h:31079)
   D /trunk/src/chrome/renderer/websharedworker_proxy.cc
   D /trunk/src/chrome/renderer/websharedworker_proxy.h
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   D /trunk/src/chrome/worker/websharedworker_stub.cc
   D /trunk/src/chrome/worker/websharedworker_stub.h
   D /trunk/src/chrome/worker/webworker_stub.cc
   D /trunk/src/chrome/worker/webworker_stub.h
   D /trunk/src/chrome/worker/webworker_stub_base.cc
   D /trunk/src/chrome/worker/webworker_stub_base.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/webkit/api/WebKit.gyp
   D /trunk/src/webkit/api/public/WebCommonWorkerClient.h
   M /trunk/src/webkit/api/public/WebSharedWorker.h
   M /trunk/src/webkit/api/public/WebWorkerClient.h
   M /trunk/src/webkit/api/src/SharedWorkerRepository.cpp
   D /trunk/src/webkit/api/src/WebSharedWorkerImpl.cpp
   D /trunk/src/webkit/api/src/WebSharedWorkerImpl.h

Revert "Added beginnings of browser-process support for shared workers."

This reverts commit 31077.
------------------------------------------------------------------------
r31077 | atwilson@chromium.org | 2009-11-05 07:29:08 +0100 (Thu, 05 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   D /trunk/src/chrome/renderer/websharedworker_impl.cc
   D /trunk/src/chrome/renderer/websharedworker_impl.h
   A /trunk/src/chrome/renderer/websharedworker_proxy.cc (from /trunk/src/chrome/renderer/websharedworker_impl.cc:31074)
   A /trunk/src/chrome/renderer/websharedworker_proxy.h (from /trunk/src/chrome/renderer/websharedworker_impl.h:31074)
   M /trunk/src/chrome/renderer/webworker_base.cc
   M /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   A /trunk/src/chrome/worker/websharedworker_stub.cc
   A /trunk/src/chrome/worker/websharedworker_stub.h
   A /trunk/src/chrome/worker/webworker_stub.cc
   A /trunk/src/chrome/worker/webworker_stub.h
   A /trunk/src/chrome/worker/webworker_stub_base.cc
   A /trunk/src/chrome/worker/webworker_stub_base.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/webkit/api/WebKit.gyp
   A /trunk/src/webkit/api/public/WebCommonWorkerClient.h (from /trunk/src/webkit/api/public/WebWorkerClient.h:31074)
   M /trunk/src/webkit/api/public/WebSharedWorker.h
   M /trunk/src/webkit/api/public/WebWorkerClient.h
   M /trunk/src/webkit/api/src/SharedWorkerRepository.cpp
   A /trunk/src/webkit/api/src/WebSharedWorkerImpl.cpp (from /trunk/src/webkit/api/public/WebSharedWorker.h:31074)
   A /trunk/src/webkit/api/src/WebSharedWorkerImpl.h (from /trunk/src/webkit/api/public/WebSharedWorker.h:31074)

Added beginnings of browser-process support for shared workers.
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.

BUG=26233
TEST=none (will enable layout tests when basic functionality available)

Review URL: http://codereview.chromium.org/351004
------------------------------------------------------------------------
r31074 | nirnimesh@chromium.org | 2009-11-05 06:28:21 +0100 (Thu, 05 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/google_update_settings_posix.cc
   M /trunk/src/chrome/common/chrome_switches.cc

Always enable Breakpad if using --enable-crash-reporter flag

This is so that when unattended, typically the first run dialog is not shown
(when using automation proxy) and the user does not get a chance to consent
to sending stats. This gives an opportunity to force enable breakpad.

BUG=24960,25271
TEST=Breakpad should be initialized if --enable-crash-reporter flag has been specified

Review URL: http://codereview.chromium.org/282011
------------------------------------------------------------------------
r31073 | robertshield@chromium.org | 2009-11-05 05:59:48 +0100 (Thu, 05 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/chrome_frame_distribution.cc
   M /trunk/src/chrome/installer/util/chrome_frame_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc

Push the Omaha app guid into the browser distribution classes to remove compile-time differences between Chrome Frame and Chrome.

Review URL: http://codereview.chromium.org/361023
------------------------------------------------------------------------
r31069 | ben@chromium.org | 2009-11-05 04:55:05 +0100 (Thu, 05 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h

Make SessionService use its own enum for storing window type in the session database. This allows us to modify Browser::Type without invalidating databases from older versions.

http://crbug.com/26500
TEST=see bug

Review URL: http://codereview.chromium.org/361016
------------------------------------------------------------------------
r31068 | evan@chromium.org | 2009-11-05 04:52:53 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

linux: swap order of buttons for dangerous downloads

BUG=26756

Review URL: http://codereview.chromium.org/361024
------------------------------------------------------------------------
r31067 | cpu@chromium.org | 2009-11-05 04:46:35 +0100 (Thu, 05 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sandbox_policy.cc

Move LOG from warning to info
- Less file IO on the UI thread

Review URL: http://codereview.chromium.org/354013
------------------------------------------------------------------------
r31061 | oshima@chromium.org | 2009-11-05 03:12:37 +0100 (Thu, 05 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Show only one app menu. Cole pointed out that ChromeOS currently has two almost identical app menu.
This CL will toggle app menu depending on the status of toolbar.
  - This is only for toolkit views build as gtk version does not toggle toolbar.
  - The menu contnets are not fully sync'ed. We need some refactoring, when
    we fully migrate to views.

Review URL: http://codereview.chromium.org/366010
------------------------------------------------------------------------
r31056 | mattm@chromium.org | 2009-11-05 02:41:09 +0100 (Thu, 05 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Coverity: Fix unnecessary Singleton object instantiation.

CID=7228-7241
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/360037
------------------------------------------------------------------------
r31054 | eroman@chromium.org | 2009-11-05 02:17:16 +0100 (Thu, 05 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Remove what appears to be an unused variable.
Also correct some long line violations.

Review URL: http://codereview.chromium.org/355034
------------------------------------------------------------------------
r31051 | tony@chromium.org | 2009-11-05 02:03:53 +0100 (Thu, 05 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Fix a bug where we were over compensating for the height of the
bookmarks bar during an animation.  What we want is the "extra"
height provided by the bookmarks bar.  Since we always show at
least 4px, we don't count that as extra height.

Review URL: http://codereview.chromium.org/366019
------------------------------------------------------------------------
r31047 | viettrungluu@chromium.org | 2009-11-05 01:48:22 +0100 (Thu, 05 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Enable the OK button when editing a bookmark even when there is no text, and keep alignment correct in both cases. Also strip out newlines from bookmark titles.

[Patch by feldstein.]

BUG=26353
TEST=Add and remove titles from bookmarks in the bookmark bar and verify that they look correct, and icons are centered when there is no text.

Review URL: http://codereview.chromium.org/353024
------------------------------------------------------------------------
r31046 | jam@chromium.org | 2009-11-05 01:46:21 +0100 (Thu, 05 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix first run ui hanging.  The threads need to get started earlier.

BUG=26614
Review URL: http://codereview.chromium.org/360035
------------------------------------------------------------------------
r31045 | mpcomplete@chromium.org | 2009-11-05 01:39:46 +0100 (Thu, 05 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h

Fix a bug where we'd leak ResourceMessageFilters and BrowserRenderProcessHosts
on shutdown when extensions were running.

BUG=15708
BUG=26652

Review URL: http://codereview.chromium.org/355032
------------------------------------------------------------------------
r31043 | mirandac@chromium.org | 2009-11-05 01:23:06 +0100 (Thu, 05 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Ensure that overlay does not appear in incognito mode.

BUG= 20036
TEST= install glossy blue theme. See curved corner (overlay) in upper left hand corner.
Note that it does not appear in the incognito version of the theme (now it appears in the jarringly wrong color).
Review URL: http://codereview.chromium.org/361018
------------------------------------------------------------------------
r31040 | eroman@chromium.org | 2009-11-05 00:54:32 +0100 (Thu, 05 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Reorder the definitions in chrome_url_request_context.cc to match the declaration order.

This is strictly a no-op refactor, it does not change any code (just re-orders it within the file).
This addresses a TODO to tidy the code.

TBR=darin
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/360030
------------------------------------------------------------------------
r31036 | mirandac@chromium.org | 2009-11-05 00:24:42 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc

Fix theme install crasher.

BUG= 26704
TEST= change themes. browser does not crash.
Review URL: http://codereview.chromium.org/366015
------------------------------------------------------------------------
r31031 | tony@chromium.org | 2009-11-05 00:01:05 +0100 (Thu, 05 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Only send renderer resize messages for RWHV sizing caused by
TCV's size allocate message.  This avoids a spurious size-allocate
being sent to the renderers when creating a new tab.  The extra
size-allocate is called by the build-in GtkFixed's size allocate
method.

Another way to think of this is that we only size our RWH directly
and decouple it's sizing from the GTK+ widget's sizing.

BUG=26495

Review URL: http://codereview.chromium.org/363012
------------------------------------------------------------------------
r31030 | mirandac@chromium.org | 2009-11-05 00:00:28 +0100 (Thu, 05 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm

Ensure that report bug dialog is centered when it opens.

BUG= 26689
TEST= none
Review URL: http://codereview.chromium.org/362012
------------------------------------------------------------------------
r31024 | mpcomplete@chromium.org | 2009-11-04 23:40:05 +0100 (Wed, 04 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h

Fix a memory leak in ExtensionMessageService.

Also grasp at straws trying to fix a crash bug.

BUG=21201

Review URL: http://codereview.chromium.org/345058
------------------------------------------------------------------------
r31023 | pamg@google.com | 2009-11-04 23:37:11 +0100 (Wed, 04 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/skia/ext/skia_utils_mac.mm

Restoring r29827. The skia file is new to this attempt, and may be what was causing a unit test to crash last time.

Refactor security-icon code to a more general form, also more consistent with
the Windows implementation, in preparation for implementing page actions.

Review URL: http://codereview.chromium.org/264037

BUG=14899, 22922, 12281
TEST=unit tests included
Review URL: http://codereview.chromium.org/348069
------------------------------------------------------------------------
r31021 | finnur@chromium.org | 2009-11-04 23:29:24 +0100 (Wed, 04 Nov 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   A /trunk/src/chrome/browser/resources/gray.png

Grouping the extensions and calling out the disabled
ones more prominently.

Also added an unused string for 'getting more extensions',
so we can translate.

Converted 'Developer Tools' references to 'Developer Mode',
to avoid confusion with Chrome's developer tools.

TEST=Load extension b_foo through --load-extension.
Open chrome://extensions/ and notice extension b_foo is
on top, even though another extension a_foo normally would
appear at the top due to alphabetical sorting. Then disable
an extension and notice it should turn all gray. Enable,
and it should no longer be gray.
BUG=http://crbug.com/26699, http://crbug.com/25850

Review URL: http://codereview.chromium.org/365008
------------------------------------------------------------------------
r31019 | thestig@chromium.org | 2009-11-04 23:26:03 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/browser/resources/about_memory_linux.html

Linux: use /proc/pid/statm to get memory stats when /proc/pid/smaps is unavailable.

BUG=23258
TEST=We get approximate memory usage in about:memory for sandboxed renderers.
Review URL: http://codereview.chromium.org/365007
------------------------------------------------------------------------
r31018 | fbarchard@chromium.org | 2009-11-04 23:25:18 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/media/audio/audio_output.h
   M /trunk/src/media/audio/fake_audio_output_stream.cc
   M /trunk/src/media/audio/fake_audio_output_stream.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/audio_manager_linux.cc
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac_unittest.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/filters/audio_renderer_impl.cc

SetVolume and GetVolume take one volume instead of separate left and right volumes.
BUG=26660
TEST=no visible difference. Make sure volume still works.  Code size should go down marginally.

Review URL: http://codereview.chromium.org/357004
------------------------------------------------------------------------
r31015 | robertshield@chromium.org | 2009-11-04 23:18:57 +0100 (Wed, 04 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/install_util.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/chrome_tab.cc

Continue to remove CHROME_FRAME_BUILD define from code that goes into chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line.

Also,

* At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it).
* The installer now propagates the presence of --verbose-logging to uninstalls.
* The chrome_launcher now allows the --chrome-frame switch through to chrome.
* The installer now accepts a --chrome-frame switch.
* Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer.


BUG=26012, 26603
TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly.


Review URL: http://codereview.chromium.org/345021
------------------------------------------------------------------------
r31011 | nick@chromium.org | 2009-11-04 23:10:26 +0100 (Wed, 04 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Remove the sync error button from the Linux bookmark bar.

It wasn't wired up to any errors yet, it wasn't hidden by default, it created an unnecessary horizontal space, and it would DCHECK (or worse) when that space was clicked.

BUG=26595
TEST=Displayed the bookmarks bar, verified that the gap to the left of "Other Bookmarks" went away and that it was no longer clickable.
R=estade

Review URL: http://codereview.chromium.org/360024
------------------------------------------------------------------------
r31010 | jam@chromium.org | 2009-11-04 22:57:48 +0100 (Wed, 04 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread.cc

Stop each ChromeThread before nulling out the entry in chrome_threads_.  This allows DCHECKs that the code is running on the correct thread to succeed.

BUG=26714
Review URL: http://codereview.chromium.org/363010
------------------------------------------------------------------------
r31009 | estade@chromium.org | 2009-11-04 22:53:03 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: Fix a couple minor popup window icon menu bugs.

BUG=26265,26268

Review URL: http://codereview.chromium.org/360023
------------------------------------------------------------------------
r31004 | johnnyg@chromium.org | 2009-11-04 22:29:11 +0100 (Wed, 04 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon.cc
   M /trunk/src/chrome/browser/notifications/balloon.h
   M /trunk/src/chrome/browser/notifications/balloon_collection.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/notification.h
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.cc
   M /trunk/src/chrome/browser/notifications/notification_ui_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.h
   M /trunk/src/chrome/renderer/notification_provider.cc

Implement cancel() API on a Notification object so that script can cancel or tear down a toast.

BUG=26360
TEST=cancel a notification

Review URL: http://codereview.chromium.org/363003
------------------------------------------------------------------------
r31003 | tony@chromium.org | 2009-11-04 22:27:23 +0100 (Wed, 04 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Revert "Convert tabcontentscontainer to use a vbox instead of a fixed.  The"

This reverts commit r30843.

This broke the findbar/download shelf animation optimization.  I
originally was doing this as part of fixing issue 26495, but I
found a different way.

TBR=estade

Review URL: http://codereview.chromium.org/366009
------------------------------------------------------------------------
r31000 | dmaclach@chromium.org | 2009-11-04 22:12:44 +0100 (Wed, 04 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Clean up bookmark_editor_controller to so that is closes consistently as both a standard window and as a sheet.
Get rid of an unneeded member variable.
Clean up unittest to use new CocoaTest, and to clean up its windows properly.

BUG=none
TEST=Open the bookmark editing window and edit bookmarks. Make sure to test with both OK and Cancel.

Review URL: http://codereview.chromium.org/361011
------------------------------------------------------------------------
r30998 | dmaclach@chromium.org | 2009-11-04 22:09:42 +0100 (Wed, 04 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Shifted patterns in tabs and background pattern over so that patterns line up correctly with the
browser window.

BUG=18548
TEST=Open window with Legal Pad theme from the them gallery and make sure the red lines line up.

Review URL: http://codereview.chromium.org/351010
------------------------------------------------------------------------
r30983 | pinkerton@chromium.org | 2009-11-04 20:54:17 +0100 (Wed, 04 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/base_view.mm

Back out r30033 which broke drag scrolling in web pages until we have a better solution.
BUG=22199
TEST=dragging to scroll in web pages should again work.
Review URL: http://codereview.chromium.org/367001
------------------------------------------------------------------------
r30982 | mad@chromium.org | 2009-11-04 20:49:51 +0100 (Wed, 04 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc

Fix for flaky browser tests as done by twiz and reviewed here:
http://codereview.chromium.org/346044

BUG=26599
TEST=extension_popup_apitest.cc 

------------------------------------------------------------------------
r30981 | phajdan.jr@chromium.org | 2009-11-04 20:47:07 +0100 (Wed, 04 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc

Mark BlockedPopupContainerInteractiveTest.DontSpawnEndlessPopups as FLAKY.

TEST=none
BUG=26692

Review URL: http://codereview.chromium.org/363004
------------------------------------------------------------------------
r30980 | jhawkins@chromium.org | 2009-11-04 20:29:58 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/sha1.cc
   A /trunk/src/base/sha1.h
   A /trunk/src/base/sha1_unittest.cc
   M /trunk/src/chrome/DEPS
   A /trunk/src/chrome/browser/autofill/autofill_field.cc
   A /trunk/src/chrome/browser/autofill/autofill_field.h
   M /trunk/src/chrome/browser/autofill/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill/autofill_manager.h
   A /trunk/src/chrome/browser/autofill/field_types.h
   A /trunk/src/chrome/browser/autofill/form_structure.cc
   A /trunk/src/chrome/browser/autofill/form_structure.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc
   M /trunk/src/webkit/glue/form_field_values.h

Implement FormStructure and an initial method, EncodeUploadRequest.  This also adds SHA1HashString, a utility method to get the SHA-1 hash of an input string, with appropriate unit tests.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/355003
------------------------------------------------------------------------
r30976 | estade@chromium.org | 2009-11-04 20:01:03 +0100 (Wed, 04 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/ipc/ipc_message.cc

GTK: Properly convert task manager UI row to task manager model row.

Also clean up some leaking tree paths.

BUG=22961
TEST=after sorting, task manager still works normally

Review URL: http://codereview.chromium.org/362001
------------------------------------------------------------------------
r30974 | mark@chromium.org | 2009-11-04 19:59:01 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/animatable_view.h

AnimatableView needs to be an NSAnimationDelegate.

BUG=insect
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/360014
------------------------------------------------------------------------
r30971 | tony@chromium.org | 2009-11-04 19:37:31 +0100 (Wed, 04 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Enable localization of default downloaded filename.

Instead of localizing "download" string in net_util.cc, make a caller,
download_manger, provide a localized string.

BUG=25289
TEST=NetUtilTest.GetSuggestedFilename,DownloadManagerTest.TestDownloadFilename

Original patch by hayato@google.com at:
http://codereview.chromium.org/343014/show

Review URL: http://codereview.chromium.org/367003
------------------------------------------------------------------------
r30970 | munjal@chromium.org | 2009-11-04 19:33:53 +0100 (Wed, 04 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/url_translator.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/character_set_converters_posix.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters_win.cc
   D /trunk/src/chrome/browser/sync/util/compat_file.h
   D /trunk/src/chrome/browser/sync/util/compat_file_posix.cc
   D /trunk/src/chrome/browser/sync/util/compat_file_win.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.h
   M /trunk/src/chrome/browser/sync/util/path_helpers_linux.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_mac.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_unittest.cc
   A /trunk/src/chrome/browser/sync/util/path_helpers_win.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.h
   M /trunk/src/chrome/browser/sync/util/query_helpers_unittest.cc
   M /trunk/src/chrome/browser/sync/util/sync_types.h
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h


Clean up the strings for sync code:
- Use FilePath for real file paths.
- Use std::string for PathString on Windows as well

TODO in a separate CL:
- Get rid of PathString typedef completely and directly use std::string everywhere.
- Use wchar_t in syncapi.h/.cc and get rid of sync_char16.

TEST=Existing tests are sufficient since this CL does a lot of code refactoring.
BUG=26342

Review URL: http://codereview.chromium.org/340055
------------------------------------------------------------------------
r30967 | thomasvl@chromium.org | 2009-11-04 18:55:02 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Remove the stats and crash report checkbox from the under the hood prefs in non google chrome builds.

BUG=24425
TEST=Chroimum builds don't have the checkbox, chrome builds do.  Chromium builds shouldn't have a gap where it was.
Review URL: http://codereview.chromium.org/363005
------------------------------------------------------------------------
r30966 | markus@chromium.org | 2009-11-04 18:52:47 +0100 (Wed, 04 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   M /trunk/src/sandbox/linux/seccomp/sandbox.cc
   M /trunk/src/sandbox/linux/seccomp/sandbox.h
   M /trunk/src/sandbox/linux/seccomp/sandbox_impl.h

Only enable the seccomp sandbox, if the machine actually has kernel support for
this feature, and if no other obstacle prevents us from enabling it.

Otherwise, we print a warning message and continue running without the sandbox.
This is not ideal, but given the non-trivial number of users who might not have
seccomp enabled by default, this seems the prudent approach.

BUG=26521
Review URL: http://codereview.chromium.org/341092
------------------------------------------------------------------------
r30965 | stuartmorgan@chromium.org | 2009-11-04 18:27:08 +0100 (Wed, 04 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h

Don't allow the browser to stay above a modal plugin window (Mac)

There's a flicker of the modal window being hidden then coming forward again, and the menus still work, so we'll most likely have fake the modality more aggressively at some point. This gets us the basic infrastructure though, and solves the severe usability problem.

BUG=20798
TEST=Open a modal plugin window (e.g., Gmail upload). Switch to another app, then back to Chrome; the plugin window should come to the front.

Review URL: http://codereview.chromium.org/355021
------------------------------------------------------------------------
r30959 | pinkerton@chromium.org | 2009-11-04 16:18:22 +0100 (Wed, 04 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Implement tab closing animations.
BUG=14919
TEST=tab opening and closing, tab dragging, trying to drag tabs while animating closed, http auth, tab modal sheets, anything involving tabs.
Review URL: http://codereview.chromium.org/348061
------------------------------------------------------------------------
r30958 | pinkerton@chromium.org | 2009-11-04 16:17:16 +0100 (Wed, 04 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Implement undo/redo so they will be properly enabled when the web content has focus.
BUG=26112
TEST=per bug.
Review URL: http://codereview.chromium.org/355016
------------------------------------------------------------------------
r30956 | avi@chromium.org | 2009-11-04 16:02:05 +0100 (Wed, 04 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Speculative backout of r30849 to determine what impact it has on startup time.

TBR=mmentovai

------------------------------------------------------------------------
r30954 | phajdan.jr@chromium.org | 2009-11-04 15:11:18 +0100 (Wed, 04 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc

Fix BlacklistManagerBrowserTest.Basic to be more solid.

It turns out it was flaky (was waiting for an event that already happened).
When running the message loop to wait for extension loading changes,
it was executing BlacklistManager tasks as well.

TEST=Covered by browser_tests.
BUG=21541
TBR=aa

Review URL: http://codereview.chromium.org/361003
------------------------------------------------------------------------
r30952 | phajdan.jr@chromium.org | 2009-11-04 12:11:34 +0100 (Wed, 04 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/common/privacy_blacklist
   A /trunk/src/chrome/test/data/extensions/common/privacy_blacklist/manifest.json
   A /trunk/src/chrome/test/data/extensions/common/privacy_blacklist/privacy_blacklist.pbl

Implement loading blacklists from extensions.

It doesn't yet work in full-browser scenario, but allows me
to write a simple test.

TEST=Covered by browser_tests.
BUG=21541

Review URL: http://codereview.chromium.org/341050
------------------------------------------------------------------------
r30949 | ukai@chromium.org | 2009-11-04 11:02:28 +0100 (Wed, 04 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/socket_stream/socket_stream.cc
   M /trunk/src/net/socket_stream/socket_stream.h
   A /trunk/src/net/socket_stream/socket_stream_throttle.cc
   A /trunk/src/net/socket_stream/socket_stream_throttle.h
   A /trunk/src/net/websockets/websocket_throttle.cc
   A /trunk/src/net/websockets/websocket_throttle.h
   A /trunk/src/net/websockets/websocket_throttle_unittest.cc

Implement websocket throttling.

Implement the client-side requirements in the spec.
 4.1 Handshake
   1.   If the user agent already has a Web Socket connection to the
        remote host (IP address) identified by /host/, even if known by
        another name, wait until that connection has been established or
        for that connection to have failed.

BUG=none
TEST=net_unittests passes

Review URL: http://codereview.chromium.org/342052
------------------------------------------------------------------------
r30948 | thestig@chromium.org | 2009-11-04 09:32:22 +0100 (Wed, 04 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/sandbox_methods_linux.h
   M /trunk/src/chrome/test/in_process_browser_test.cc

Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox.

While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox.

Original review: http://codereview.chromium.org/262020
This is try 2 - initialize the sandbox host and zygote for InProcessBrowserTest.

TBR=agl

BUG=20012, 20714, 23072
TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them.

Review URL: http://codereview.chromium.org/361002
------------------------------------------------------------------------
r30946 | akalin@chromium.org | 2009-11-04 06:45:15 +0100 (Wed, 04 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc

Added scale hack to work around Windows font metric issue.

BUG=none
TESTED=tested sync setup wizard on OS X

Review URL: http://codereview.chromium.org/348070
------------------------------------------------------------------------
r30945 | jorlow@chromium.org | 2009-11-04 06:44:40 +0100 (Wed, 04 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h

First half of http://codereview.chromium.org/274014/show

This fixes storage events in single process mode, fixes a bug due to the glue/webkitclient_impl not being updated when I introduced quota support, introduces a params struct for storage events, and is general cleanup.  Submitting this first since the change to add the url param made things bigger than I liked.

TBR=darin
TEST=none
BUG=25427

Review URL: http://codereview.chromium.org/348071
------------------------------------------------------------------------
r30942 | sky@chromium.org | 2009-11-04 06:05:48 +0100 (Wed, 04 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/native_widget_types.h
   A /trunk/src/app/gfx/path.cc (from /trunk/src/app/gfx/path.cc:30912)
   M /trunk/src/app/gfx/path.h
   M /trunk/src/app/gfx/path_gtk.cc
   M /trunk/src/app/gfx/path_win.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/scoped_handle.h
   A /trunk/src/base/scoped_handle_gtk.h (from /trunk/src/base/scoped_handle_gtk.h:30912)
   M /trunk/src/base/scoped_handle_win.h
   M /trunk/src/chrome/browser/dock_info_win.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_win.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_win.cc

Attempt 2 at:

Gets find bar animation/clipping to work on views/gtk.

The only difference between this and the first version is fixing an
include in extension_host that was triggering mac to build views, as
well as an extraneous SetSlideDuration I had used for testing.

BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/342116
------------------------------------------------------------------------
r30939 | thestig@chromium.org | 2009-11-04 05:22:47 +0100 (Wed, 04 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/sandbox_methods_linux.h

Revert 30938 - Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox.

While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox.

BUG=20012,20714,23072
TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them.
Review URL: http://codereview.chromium.org/262020
Review URL: http://codereview.chromium.org/359001
------------------------------------------------------------------------
r30938 | thestig@chromium.org | 2009-11-04 05:07:33 +0100 (Wed, 04 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/sandbox_methods_linux.h

Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox.

While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox.

BUG=20012,20714,23072
TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them.
Review URL: http://codereview.chromium.org/262020
------------------------------------------------------------------------
r30936 | ukai@chromium.org | 2009-11-04 04:54:11 +0100 (Wed, 04 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix valgrind error in SocketStreamDispatcherHost

BUG=26324
TEST=none

Review URL: http://codereview.chromium.org/342113
------------------------------------------------------------------------
r30934 | cpu@chromium.org | 2009-11-04 04:39:22 +0100 (Wed, 04 Nov 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_win.cc
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   D /trunk/src/chrome/app/google_update_client.cc
   D /trunk/src/chrome/app/google_update_client.h
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/chrome.gyp

Rewrite of chrome.exe startup code

A lot of cruft and repeated code has deposited over the years on chrome's initialization code.
This CL makes it all much more clear and straightforward. There is no fundamental change of
behavior except the order of certain things is different but it should not alter the observed
operation.

- chrome's and chromium load is fundamentally the same but most of the code was repeated
- chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH
- Use of SearchPath() was dangerous and not needed
- removed google_update_client.cc and .h
- removed bunch of #ifdefs

TEST=all convered by UI tests already except [1]
BUG=none

[1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed').


Review URL: http://codereview.chromium.org/345036
------------------------------------------------------------------------
r30930 | thestig@chromium.org | 2009-11-04 04:10:00 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Keep track of when file dialogs are destroyed.

BUG=none
TEST=Open two windows, open a file dialog in one, quit the browser in other. There should not be any GTK assertion errors.
Review URL: http://codereview.chromium.org/339096
------------------------------------------------------------------------
r30925 | aa@chromium.org | 2009-11-04 03:15:20 +0100 (Wed, 04 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   A /trunk/src/chrome/browser/extensions/convert_user_script.cc
   A /trunk/src/chrome/browser/extensions/convert_user_script.h
   A /trunk/src/chrome/browser/extensions/convert_user_script_unittest.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_error_utils.cc
   M /trunk/src/chrome/common/extensions/extension_error_utils.h
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/renderer/resources/greasemonkey_api.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   A /trunk/src/chrome/test/data/extensions/user_script_basic.user.js
   A /trunk/src/chrome/test/data/extensions/user_script_no_metadata.user.js

Add first class support for user scripts.

Original review: http://codereview.chromium.org/340057

TBR=mpcomplete@chromium.org
BUG=22103
TEST=Install a user script (such as from userscripts.org). You should get the extension install UI and the
script should show up in the extension management UI. It should also work, though some scripts use
Firefox-specific APIs and those won't work in Chromium.
------------------------------------------------------------------------
r30913 | sky@chromium.org | 2009-11-04 02:15:59 +0100 (Wed, 04 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/native_widget_types.h
   D /trunk/src/app/gfx/path.cc
   M /trunk/src/app/gfx/path.h
   M /trunk/src/app/gfx/path_gtk.cc
   M /trunk/src/app/gfx/path_win.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/scoped_handle.h
   D /trunk/src/base/scoped_handle_gtk.h
   M /trunk/src/base/scoped_handle_win.h
   M /trunk/src/chrome/browser/dock_info_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_win.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_win.cc

Revert 30903 - Gets find bar animation/clipping to work on views/gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/340077

TBR=sky@chromium.org
------------------------------------------------------------------------
r30908 | pkasting@chromium.org | 2009-11-04 02:01:01 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h

Try to add more sanity checking to help track down a crash.

BUG=20511
TEST=none
Review URL: http://codereview.chromium.org/342112
------------------------------------------------------------------------
r30903 | sky@chromium.org | 2009-11-04 01:38:45 +0100 (Wed, 04 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/native_widget_types.h
   A /trunk/src/app/gfx/path.cc
   M /trunk/src/app/gfx/path.h
   M /trunk/src/app/gfx/path_gtk.cc
   M /trunk/src/app/gfx/path_win.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/scoped_handle.h
   A /trunk/src/base/scoped_handle_gtk.h
   M /trunk/src/base/scoped_handle_win.h
   M /trunk/src/chrome/browser/dock_info_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_win.cc
   M /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_win.cc

Gets find bar animation/clipping to work on views/gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/340077
------------------------------------------------------------------------
r30893 | rohitrao@chromium.org | 2009-11-04 00:55:55 +0100 (Wed, 04 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/view_resizer.h

[Mac] Enables animations for the infobar.  Changes the control flow for infobar opening/closing to match Windows more closely.

Nib file changes:
- Embedded the InfoBarGradientView inside an AnimatableView.
- Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet.
- Bound the AnimatableView's delegate_ to the InfoBarController.

BUG=http://crbug.com/25599
TEST=Infobars should animate in and out, except for during tab switches.
Review URL: http://codereview.chromium.org/354008
------------------------------------------------------------------------
r30892 | sky@chromium.org | 2009-11-04 00:48:30 +0100 (Wed, 04 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc

Changes session restore to use a normal load rather than preferring
the cache. We need to do this else we don't honor page expiration and
end up showing stale data for some sites.

BUG=21195
TEST=make sure session restore works.

Review URL: http://codereview.chromium.org/341043
------------------------------------------------------------------------
r30886 | rafaelw@chromium.org | 2009-11-04 00:29:17 +0100 (Wed, 04 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Mark ShowModalDialogTest.BasicTest as FLAKY

TBR=phajdan.jr,jam
BUG=17806

Review URL: http://codereview.chromium.org/346045
------------------------------------------------------------------------
r30884 | mpcomplete@chromium.org | 2009-11-04 00:21:27 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc

Clean up extension message port data in the renderer.

BUG=26262

Review URL: http://codereview.chromium.org/344044
------------------------------------------------------------------------
r30882 | jam@chromium.org | 2009-11-04 00:12:52 +0100 (Wed, 04 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Use ChromeThread::DeleteOnIOThread in a few places where an object must be deleted on a certain thread.

BUG=25354
Review URL: http://codereview.chromium.org/342090
------------------------------------------------------------------------
r30881 | jam@chromium.org | 2009-11-04 00:12:42 +0100 (Wed, 04 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/common/child_process_host.cc

Last patch in removing MessageLoop* caching.

BUG=25354
Review URL: http://codereview.chromium.org/353015
------------------------------------------------------------------------
r30880 | pkasting@chromium.org | 2009-11-04 00:12:17 +0100 (Wed, 04 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_history_api.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/possible_url_model.cc

Eliminate QueryOptions::most_recent_visit_only.  All non-unittest consumers of this set it to true, so just turn it on unconditionally.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341087
------------------------------------------------------------------------
r30876 | eroman@chromium.org | 2009-11-03 23:53:58 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Remove the db_loop_ member variable which is a unused following r30163.

BUG=25354

Review URL: http://codereview.chromium.org/353023
------------------------------------------------------------------------
r30871 | thomasvl@chromium.org | 2009-11-03 22:52:05 +0100 (Tue, 03 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Prefs window sizing/spacing:
- Make some vertical spacing in basics more consistent
- Make some vertical spacing in personal stuff more consistent
- Make the views a bit wider to avoid some clipping and wrapping in a few languages.
- A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc).

TEST=window looks ok (given our strings it won't always look great, but shoot for ok).
BUG=26586
Review URL: http://codereview.chromium.org/351027
------------------------------------------------------------------------
r30869 | avi@chromium.org | 2009-11-03 22:46:57 +0100 (Tue, 03 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Make page and wrench buttons have correct hover look.

xib changes:
- cell tags changed to make them styled independently
- button attribute "bordered" disabled

BUG=http://crbug.com/25644
TEST=as in bug

Review URL: http://codereview.chromium.org/341088
------------------------------------------------------------------------
r30868 | tim@chromium.org | 2009-11-03 22:39:08 +0100 (Tue, 03 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h

Remove context-based dependencies on SyncerSession from ApplyUpdatesCommand.
This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil.

Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager,
ModelSafeWorker, etc from progress state.

BUG=25266
TEST=sync unit tests

Review URL: http://codereview.chromium.org/351026
------------------------------------------------------------------------
r30867 | mirandac@chromium.org | 2009-11-03 22:13:59 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bug_report_util.cc
   M /trunk/src/chrome/browser/bug_report_util.h

Add OS version information to the bug report utility for the Mac version.

BUG= http://crbug.com/26138
TEST= none
Review URL: http://codereview.chromium.org/355013
------------------------------------------------------------------------
r30866 | jrg@chromium.org | 2009-11-03 22:13:37 +0100 (Tue, 03 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm

Bookmark context menu "Edit" starts with current name, not "New Folder".
"Add Folder..." from either buttons or bar happier (always adds, doesn't edit).
"Add Folder..." now allows you to rename new folders the default name ("New Folder").


BUG=http://crbug.com/26364, http://crbug.com/26407

TEST=Over a bookmark button for a 'mark or folder, context menu --> Edit.
Make sure initial name is current name, not "New Folder".
Over button for 'mark, for folder, or bar itself: context menu --> Add Folder.
Make sure initial name is "New Folder", and that it creates a folder (not a rename).
Make sure you are allowed to create a folder named "New Folder".

Review URL: http://codereview.chromium.org/345045
------------------------------------------------------------------------
r30862 | finnur@chromium.org | 2009-11-03 22:00:34 +0100 (Tue, 03 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc


BrowserActionsContainer breaks for nobody... or maybe someone
just forgot to hit the breaks. :)

This avoids triggering a NOTREACHED in the default case that
I hit during testing.

BUG=None
TEST=Load the set_page_color sample extension in debug build
of Chrome and it should not NOTREACH (it should... um... REACH?)
when pressing the browser action icon. :)


Review URL: http://codereview.chromium.org/351023
------------------------------------------------------------------------
r30855 | thestig@chromium.org | 2009-11-03 21:25:48 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Initialize |restored_bounds_| so new windows always have a proper size.

BUG=none
TEST=Resize window to 400x300, hold down ctrl+N, new windows should all be the same size.
Review URL: http://codereview.chromium.org/355007
------------------------------------------------------------------------
r30853 | jrg@chromium.org | 2009-11-03 21:17:56 +0100 (Tue, 03 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Disable open all bookmarks context menu item if there are no bookmarks.

BUG=http://crbug.com/26071

TEST=New empty bookmark bar.  Maker sure "Open all bookmarks" in context menu is disabled.
(You'll need to click in the bottom of the bar so you don't overlap the text).
Add a bookmark.
Make sure "Open all bookmarks" in context menu is ENabled.

Review URL: http://codereview.chromium.org/351018
------------------------------------------------------------------------
r30852 | rohitrao@chromium.org | 2009-11-03 21:05:02 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/animatable_view.h
   A /trunk/src/chrome/browser/cocoa/animatable_view.mm
   A /trunk/src/chrome/browser/cocoa/animatable_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Adds a new view that will allow us to animate the height property of views.  This class will be the base class for any view that needs to be animated.

BUG=None
TEST=No visible impact.  New unittests should pass.
Review URL: http://codereview.chromium.org/350002
------------------------------------------------------------------------
r30849 | avi@chromium.org | 2009-11-03 20:38:29 +0100 (Tue, 03 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Make bookmark folder look Mac-y

BUG=http://crbug.com/26457
TEST=as in bug

Review URL: http://codereview.chromium.org/342103
------------------------------------------------------------------------
r30845 | jschuh@chromium.org | 2009-11-03 20:23:26 +0100 (Tue, 03 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Check word lengths before adding to dictionary and spellchecking.
BUG=20469
TEST=None
Review URL: http://codereview.chromium.org/326012
------------------------------------------------------------------------
r30843 | tony@chromium.org | 2009-11-03 20:19:27 +0100 (Tue, 03 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Convert tabcontentscontainer to use a vbox instead of a fixed.  The
comment in the code mentions that a vbox would cause a split screen,
but looking at the code, it seems like that's not possible because
we hide the old TCVG before adding new ones.  These days the vbox
contains all TCVGs and only shows one at a time (I think in the past
we tried to remove them, but we don't have that problem now).

This simplifies the code by not having to use our own size-allocate
handler.

Review URL: http://codereview.chromium.org/354018
------------------------------------------------------------------------
r30841 | thestig@chromium.org | 2009-11-03 20:12:28 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.h

Delete the temp dir created by CreateZip.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341074
------------------------------------------------------------------------
r30840 | jamesr@chromium.org | 2009-11-03 20:07:10 +0100 (Tue, 03 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h

Allows extension-devtools api to survive page navigation.
The problem was that the ExtensionDevtoolsBridge maintained explicit knowledge of the RenderViewHost is was monitoring. This would be invalidated on page navigations where the inspected RVH would be swapped out from underneath it.

This patch removes knowledge of RenderViewHost from the ExtensionDevToolsBridge and makes sure it appropriately unregisters itself.

Patch by: Jaime Yap (jaimeyap@google.com)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/348042
------------------------------------------------------------------------
r30836 | viettrungluu@chromium.org | 2009-11-03 19:53:04 +0100 (Tue, 03 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: fix Text Encoding menu/submenu

(1) Clicking on the Text Encoding menu item should display the submenu, not try to execute a nonexistent command.
(2) The Text Encoding menu item shouldn't be disabled, but instead the submenu's contents (so that the submenu is always visible). See Apple's HIG:
<http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF122>.

Changes to MainMenu.xib: disconnected |-commandDispatch:| from the Text Encoding menu item.

BUG=25957,26593
TEST=Check that the Text Encoding submenu is always available, with its contents disabled on the NTP (for example) and enabled (and working) on a normal web page. Check that clicking (and releasing) on the Text Encoding menu item itself shows the submenu.

Review URL: http://codereview.chromium.org/345050
------------------------------------------------------------------------
r30835 | rafaelw@chromium.org | 2009-11-03 19:51:02 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Disable failing in-process-browser interactive_ui_tests.

BUG=26540

Review URL: http://codereview.chromium.org/341078
------------------------------------------------------------------------
r30831 | rafaelw@chromium.org | 2009-11-03 19:26:13 +0100 (Tue, 03 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc

Disable flaky (crashing) ExtensionApiTest.Popup

TBR=mad,twiz
BUG=26599

Review URL: http://codereview.chromium.org/353021
------------------------------------------------------------------------
r30830 | pkasting@chromium.org | 2009-11-03 19:19:37 +0100 (Tue, 03 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Better handling of UNKNOWN versus QUERY in a couple ways.

First, made it possible to navigate to "invalid" hostnames in a number of additional cases, including when the user types an explicit scheme or when we have a valid TLD and no spaces.  The default action for these kinds of inputs is still search, but we'll pull up an accidental search infobar if need be now.

Second, made the HistoryURLProvider show a What You Typed match for UNKNOWN inputs when the user explicitly typed "http:" or "https:" at the front, since these have the highest probability of being navigational inputs.

BUG=26341
TEST=Type "http://foo bar baz.com" and verify you are given a (non-default) entry in the dropdown to navigate.
Review URL: http://codereview.chromium.org/353010
------------------------------------------------------------------------
r30825 | thomasvl@chromium.org | 2009-11-03 18:46:51 +0100 (Tue, 03 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Prefs under the hood work:
- Make all the controls/labels wrap to the width they get.
- Make the content vertically shift as it is made to fit its strings.
- Add more spacing for the sections as listed in bugs.
- Consistent indents for the sections/subsections.
- Update the code to use constant naming (was was "under the hood" and some was "advanced" (just so it is clear they are talking about one thing, and not two).
- DEPS roll for GTM to pick up support for NSPathControl.

TEST=Under the hood content should fit in all languages.
BUG=20538
BUG=25595
BUG=25597
Review URL: http://codereview.chromium.org/355011
------------------------------------------------------------------------
r30819 | brettw@chromium.org | 2009-11-03 17:52:53 +0100 (Tue, 03 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_pepper.h
   M /trunk/src/webkit/glue/pepper/pepper.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/tools/pepper_test_plugin/plugin_object.cc

Add the plumbing and test code for plugins opening files from the sandbox. This
does not implement the actual opening of the files (currently the chain ends in
resource_message_filter.cc), I will do that separately with some additional
security review. This current patch just gets the synchronous request to the
browser and returns a NULL result.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/340050
------------------------------------------------------------------------
r30818 | viettrungluu@chromium.org | 2009-11-03 17:47:13 +0100 (Tue, 03 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Mac: correct favicons in bookmarks bar (for pages w/o one and for subfolders).

Bookmarks for pages without a favicon should display a generic "blank page" icon (this also helps avoid a blank button if the bookmark also doesn't have a title). Also, folders within folders also need to display the folder icon.

BUG=23558
TEST=See above; be sure to test things on the bar and in folders, and make sure that pages with favicons are still displayed correctly.

Review URL: http://codereview.chromium.org/339087
------------------------------------------------------------------------
r30815 | mirandac@chromium.org | 2009-11-03 17:15:32 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   A /trunk/src/chrome/app/nibs/ReportBug.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/bug_report_window_controller.h
   A /trunk/src/chrome/browser/cocoa/bug_report_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/bug_report_window_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add "Report Bug" dialog to Mac OSX.

BUG= http://crbug.com/19282
TEST= Use report bug dialog on Mac OSX.
Review URL: http://codereview.chromium.org/340039
------------------------------------------------------------------------
r30813 | sky@chromium.org | 2009-11-03 16:03:00 +0100 (Tue, 03 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Removes test that we're likely never going to reenable.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/340069
------------------------------------------------------------------------
r30798 | mbelshe@google.com | 2009-11-03 07:03:31 +0100 (Tue, 03 Nov 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/net/base/fixed_host_resolver.cc
   A /trunk/src/net/base/fixed_host_resolver.h
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/net.gyp

Add a command line flag to force all network traffic through a particular server.
The command line is:
  --fixed-server=host:port

When set, all traffic will be diverted through this server.  This is useful for
testing purposes with fixed servers.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/345034
------------------------------------------------------------------------
r30796 | aa@chromium.org | 2009-11-03 06:02:30 +0100 (Tue, 03 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/static/content_scripts.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/renderer/user_script_idle_scheduler.cc
   A /trunk/src/chrome/renderer/user_script_idle_scheduler.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js

Re-commit "Add new user script injection point:
document_idle."

Original code review: http://codereview.chromium.org/339064

BUG=26126
TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r30793 | jrg@chromium.org | 2009-11-03 03:32:48 +0100 (Tue, 03 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix memory problems.
Remove some dead code.
Remove valgrind suppression which suppressed this error.

BUG=http://crbug.com/26489
TEST=Mac valgrind bot stays green for ui_test BrowserEncodingTest.TestEncodingAliasMapping

Review URL: http://codereview.chromium.org/355006
------------------------------------------------------------------------
r30790 | jam@chromium.org | 2009-11-03 03:27:01 +0100 (Tue, 03 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_bridge.cc
   M /trunk/src/chrome/browser/importer/importer_bridge.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc

Fifth patch in getting rid of caching MessageLoop pointers.

BUG=25354
Review URL: http://codereview.chromium.org/345037
------------------------------------------------------------------------
r30789 | jam@chromium.org | 2009-11-03 03:26:46 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix mem leak in sync tests by ensuring that the destruction tasks get to run.

BUG=26493

Review URL: http://codereview.chromium.org/353011
------------------------------------------------------------------------
r30787 | aa@chromium.org | 2009-11-03 02:43:21 +0100 (Tue, 03 Nov 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/static/content_scripts.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/renderer/user_script_idle_scheduler.cc
   D /trunk/src/chrome/renderer/user_script_idle_scheduler.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js

Revert r30784

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r30784 | aa@chromium.org | 2009-11-03 02:29:39 +0100 (Tue, 03 Nov 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/static/content_scripts.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/renderer/user_script_idle_scheduler.cc
   A /trunk/src/chrome/renderer/user_script_idle_scheduler.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js

Add new user script injection point "document_idle" and make it the default.

Semantically, document-idle means "when the DOM is ready and layout has been idle for awhile", or more loosely, "as soon as we get around to it".

Right now this uses a simple heuristic. It injects scripts 200ms after DOMContentLoaded, or immediately after onload, whichever happens first.

BUG=26126
TEST=Manual. Extensions with content scripts should work.

Review URL: http://codereview.chromium.org/339064
------------------------------------------------------------------------
r30781 | thestig@chromium.org | 2009-11-03 02:14:21 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Use more ScopedTempDirs.

BUG=none
TEST=ExtensionsServiceTest shouldn't leak temp files.
Review URL: http://codereview.chromium.org/342085
------------------------------------------------------------------------
r30778 | mad@chromium.org | 2009-11-03 01:37:31 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/base/json/json_writer.cc
   M /trunk/src/base/json/json_writer.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   A /trunk/src/chrome/browser/extensions/extension_popup_api.cc
   A /trunk/src/chrome/browser/extensions/extension_popup_api.h
   A /trunk/src/chrome/browser/extensions/extension_popup_apitest.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/common/view_types.cc
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/popup_api
   A /trunk/src/chrome/test/data/extensions/api_test/popup_api/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband.html
   A /trunk/src/chrome/test/data/extensions/api_test/popup_api/toolband_popup.html

Submitting change from http://codereview.chromium.org/276029/show

BUG=none
TEST=none

------------------------------------------------------------------------
r30776 | rafaelw@chromium.org | 2009-11-03 01:32:48 +0100 (Tue, 03 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable failing DevToolsSanityTests on linux.

BUG=26540

Review URL: http://codereview.chromium.org/341075
------------------------------------------------------------------------
r30775 | pam@chromium.org | 2009-11-03 01:22:09 +0100 (Tue, 03 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc

Reverting 30766. It caused failures in ui_tests BrowserTest.SingleBeforeUnloadAfterWindowClose and apparently made the browser_tests crash.

BUG=26398
TEST=covered by ui_tests and browser_tests

Review URL: http://codereview.chromium.org/354015
------------------------------------------------------------------------
r30771 | estade@chromium.org | 2009-11-03 00:51:35 +0100 (Tue, 03 Nov 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   A /trunk/src/chrome/test/data/mouseleave.html
   A /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/webkit/api/public/gtk/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp

Re-landing of r30726, which was reverted as a possible cause of chromeos buildbot failures

Handle GTK enter and leave notification events and pass them to WebKit as 
mouse move events. This prevents an HTML widget from staying in the mouseover 
state when the cursor leaves the window. Add a new ui test that checks 
the specific case that was broken by warping the mouse pointer inside and 
outside the content area. 

BUG=24660
TEST=ui_tests 

patch by Dominic Mazzoni <dmazzoni [at] google>
original review: http://codereview.chromium.org/274010/show

------------------------------------------------------------------------
r30766 | pam@chromium.org | 2009-11-03 00:27:15 +0100 (Tue, 03 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc

Set active_dialog_ before showing it, since showing a dialog can sometimes
actually move to the next one in the queue instead.

BUG=26398
TEST=Make sure alert/confirm boxes work properly. Make sure a background
    tab that shows a (delayed) alert box works. Same with a background
    browser. Especially make sure http://crbug.com/10699 doesn't recur.
Review URL: http://codereview.chromium.org/339094
------------------------------------------------------------------------
r30765 | willchan@chromium.org | 2009-11-03 00:25:19 +0100 (Tue, 03 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/net/base/load_log_event_type_list.h
   M /trunk/src/net/base/load_log_unittest.h
   M /trunk/src/net/flip/flip_session.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket/client_socket.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socket_test_util.h
   M /trunk/src/net/socket/socks5_client_socket.cc
   M /trunk/src/net/socket/socks5_client_socket.h
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket.cc
   M /trunk/src/net/socket/socks_client_socket.h
   M /trunk/src/net/socket/socks_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.cc
   M /trunk/src/net/socket/ssl_client_socket_mac.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc
   M /trunk/src/net/socket/ssl_client_socket_win.h
   M /trunk/src/net/socket/tcp_client_socket_libevent.cc
   M /trunk/src/net/socket/tcp_client_socket_libevent.h
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc
   M /trunk/src/net/socket/tcp_client_socket_win.h
   M /trunk/src/net/socket/tcp_pinger.h
   M /trunk/src/net/socket_stream/socket_stream.cc

Add LoadLog to ClientSocket::Connect().
TODO: Use LoadLog in FLIP code.

Review URL: http://codereview.chromium.org/344026
------------------------------------------------------------------------
r30762 | jrg@chromium.org | 2009-11-03 00:02:29 +0100 (Tue, 03 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

bookmark STAR bubble: Disambiguate folders with the same name

BUG=http://crbug.com/19408

TEST=Create a bookmark.
Create 2 bookmark folders both with the same name, "foo".
Go to your bookmarked page.
Click STAR to get bookmark bubble.
Change parent folder to the 1st "foo".
Confirm it's there on the bar.
Click STAR to get bookmark bubble.
Change parent folder to the 2nd "foo".
Confirm it's there on the bar.
Click STAR to get bookmark bubble.
Chose "choose another folder" to be sure that logic still works.

Review URL: http://codereview.chromium.org/340042
------------------------------------------------------------------------
r30758 | erikkay@chromium.org | 2009-11-02 23:22:35 +0100 (Mon, 02 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc

disable inactive rendering for ExtensionPopup

BUG=26502
TEST=none

Review URL: http://codereview.chromium.org/345043
------------------------------------------------------------------------
r30755 | tc@google.com | 2009-11-02 23:04:02 +0100 (Mon, 02 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_mac.mm
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/app/test_suite.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/tools/build/win/FILES
   M /trunk/src/chrome_frame/test/net/fake_external_tab.cc
   M /trunk/src/views/examples/examples_main.cc
   M /trunk/src/views/views.gyp

Remove themes/default.dll and merge the resources into chrome.dll.

This gives us one less file to load on startup.  This does mean
that some tests need to explicitly include theme_resources.rc.

BUG=24035

Review URL: http://codereview.chromium.org/348033
------------------------------------------------------------------------
r30753 | creis@chromium.org | 2009-11-02 22:52:28 +0100 (Mon, 02 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc

Fix a memory bug in the new ResizeThenCrash test.

(Related to http://codereview.chromium.org/348025)

BUG=25097
TEST=RenderWidgetHostTest.ResizeThenCrash


Review URL: http://codereview.chromium.org/353008
------------------------------------------------------------------------
r30751 | jam@chromium.org | 2009-11-02 22:44:37 +0100 (Mon, 02 Nov 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Fourth patch in getting rid of caching MessageLoop pointers.

BUG=25354
Review URL: http://codereview.chromium.org/348037
------------------------------------------------------------------------
r30745 | pkasting@chromium.org | 2009-11-02 22:40:11 +0100 (Mon, 02 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Fix a problem in the implementation of search-vs.-go-in-context-menus.  We were eliding the text before passing it to the classifier, resulting in wrong destination URLs for elided strings.

This also eliminates a couple string conversions and shortens the EscapeAmpersand() algorithm.

BUG=1978
TEST=Highlight a long string in a page.  Right-click it.  Verify the string is elided in the context menu.  Click the search entry.  Verify the string you searched for is not elided.
Review URL: http://codereview.chromium.org/343081
------------------------------------------------------------------------
r30744 | pkasting@chromium.org | 2009-11-02 22:40:00 +0100 (Mon, 02 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Unittest for fix to allow navigation when there is no history DB.

BUG=25822
TEST=none
Review URL: http://codereview.chromium.org/343067
------------------------------------------------------------------------
r30743 | thomasvl@chromium.org | 2009-11-02 22:18:53 +0100 (Mon, 02 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Reverting 30702 - Which was a Revert of 30696.

See http://codereview.chromium.org/340045 for the original code.

This includes a newer version of GTM that solves the problem with nib loading on 10.6.

TEST=http://codereview.chromium.org/340045
BUG=none
Review URL: http://codereview.chromium.org/343082
------------------------------------------------------------------------
r30737 | jam@chromium.org | 2009-11-02 21:25:57 +0100 (Mon, 02 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Sixth patch in getting rid of caching MessageLoop pointers.

BUG=25354

Review URL: http://codereview.chromium.org/354002
------------------------------------------------------------------------
r30731 | rafaelw@chromium.org | 2009-11-02 20:29:12 +0100 (Mon, 02 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   D /trunk/src/chrome/test/data/mouseleave.html
   D /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/webkit/api/public/gtk/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp

Revert "Handle GTK enter and leave notification events and pass them to WebKit as "

This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=30726

TBR=estade

Review URL: http://codereview.chromium.org/343080
------------------------------------------------------------------------
r30727 | evan@chromium.org | 2009-11-02 19:58:32 +0100 (Mon, 02 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/jumplist.h

Use FilePath in JumpList.

BUG=24672
TEST=Compiles

Patch by Thiago Farina <thiago.farina@gmail.com>.

Review URL: http://codereview.chromium.org/348035
------------------------------------------------------------------------
r30726 | estade@chromium.org | 2009-11-02 19:51:22 +0100 (Mon, 02 Nov 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   A /trunk/src/chrome/test/data/mouseleave.html
   A /trunk/src/chrome/test/ui/mouseleave_uitest.cc
   M /trunk/src/webkit/api/public/gtk/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp

Handle GTK enter and leave notification events and pass them to WebKit as 
mouse move events. This prevents an HTML widget from staying in the mouseover 
state when the cursor leaves the window. Add a new ui test that checks 
the specific case that was broken by warping the mouse pointer inside and 
outside the content area. 

BUG=24660
TEST=ui_tests 

patch by Dominic Mazzoni <dmazzoni [at] google>
original review: http://codereview.chromium.org/274010/show

Review URL: http://codereview.chromium.org/354010
------------------------------------------------------------------------
r30725 | yurys@google.com | 2009-11-02 19:45:07 +0100 (Mon, 02 Nov 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/image.html
   A /trunk/src/chrome/test/data/devtools/image.png
   M /trunk/src/webkit/api/public/WebURLLoaderClient.h
   M /trunk/src/webkit/api/src/ResourceHandle.cpp
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.cc
   M /trunk/src/webkit/glue/multipart_response_delegate_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher.cc
   M /trunk/src/webkit/glue/resource_fetcher.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc

DevTools: report correct content length for resources.

Currently lengthReceived always has the same value as dataLength when Safari calls ResourceHandle::didReceiveData. In Chrome expected content length is passed as lengthReceived parameter which leads to incorrect content length to be stored in InspectorResource. InspectorResource expects lengthReceived to be the length of current data chunk(see InspectorResource::addLength). So I changed lengthReceived parameter to be dataLength.

Darin, I see your TODO comment at line 581 in  http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?annotate=6296 (the comment was deleted later) so I think you are right person to review the change in weburlloader_impl.cc. Please look at weburlloader_impl.cc and feel free to leave devtools specific changes to Alex and Pavel.

BUG=25213
TEST=DevToolsSanityTest.TestResourceContentLength
Review URL: http://codereview.chromium.org/295041
------------------------------------------------------------------------
r30722 | creis@chromium.org | 2009-11-02 19:34:14 +0100 (Mon, 02 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc

Fixes reloading after a background tab crashes.

Needed to clear RenderWidgetHost::in_flight_size_ if the renderer crashed.

BUG=25097
TEST=RenderWidgetHostTest.ResizeThenCrash

Review URL: http://codereview.chromium.org/348025
------------------------------------------------------------------------
r30720 | thestig@chromium.org | 2009-11-02 19:33:28 +0100 (Mon, 02 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Destroy the TaskManagerGtk singleton instance when its window is destroyed, otherwise its treeview will still be getting notifications and trying to manipulate the destroyed treeview.

BUG=none
TEST=Install an extension, open the task manager, and quit the browser should not result in a GTK error.
Review URL: http://codereview.chromium.org/345031
------------------------------------------------------------------------
r30718 | thakis@chromium.org | 2009-11-02 19:25:02 +0100 (Mon, 02 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.h
   M /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.mm
   M /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h

Address post-submit comments from http://codereview.chromium.org/327009 .

BUG=TEST=none

Review URL: http://codereview.chromium.org/354009
------------------------------------------------------------------------
r30714 | estade@chromium.org | 2009-11-02 19:00:23 +0100 (Mon, 02 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Clean up temp scaffolding stubs some. It can be mac only now.

BUG=9295,8077
TEST=trybots
Review URL: http://codereview.chromium.org/340052
------------------------------------------------------------------------
r30713 | pfeldman@chromium.org | 2009-11-02 18:59:36 +0100 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/webkit/api/public/WebDevToolsAgent.h
   M /trunk/src/webkit/api/public/WebDevToolsAgentClient.h
   M /trunk/src/webkit/glue/devtools/js/inject_dispatch.js
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h

DevTools: support cross-navigation instrumentation.
Review URL: http://codereview.chromium.org/343075
------------------------------------------------------------------------
r30707 | sky@chromium.org | 2009-11-02 18:08:47 +0100 (Mon, 02 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Test case for fix to bug 26279.

BUG=26279
TEST=see bug

Review URL: http://codereview.chromium.org/339092
------------------------------------------------------------------------
r30705 | thakis@chromium.org | 2009-11-02 17:48:12 +0100 (Mon, 02 Nov 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Remember last used prefs tab.

BUG=21440
TEST=Open prefs, select 2nd tab. close & reopen prefs window. 2nd tab should still be selected. close & reopen chrome, open prefs. 2nd tab should still be selected.

Review URL: http://codereview.chromium.org/352003
------------------------------------------------------------------------
r30702 | thomasvl@chromium.org | 2009-11-02 17:08:41 +0100 (Mon, 02 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Reverting 30696.

10.6 loads xibs differently, breaking GTMIBArray

TBR=mark@chromium.org
BUG=none
TEST=none

------------------------------------------------------------------------
r30700 | rsesek@chromium.org | 2009-11-02 16:49:30 +0100 (Mon, 02 Nov 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model.mm
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model_unittest.mm

[Mac] Prevent search engines from disappearing in the preferences list

* Fix the logic in -[SearchEngineListModel defaultIndex].
* Make the test data URLs in SearchEngineListModelTest replaceable, enabling
  more tests.
* Add a test for this bug 21898.

TEST=Preferences-->Manage. Add two new search engines. Make the second one default. The list in main Preferences should not have a blank entry.
BUG=21898

Review URL: http://codereview.chromium.org/341060
------------------------------------------------------------------------
r30696 | thomasvl@chromium.org | 2009-11-02 14:15:33 +0100 (Mon, 02 Nov 2009) | 15 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Prefs layout work for "basics" and "personal stuff"
- These two pages should now auto size vertically the labels.
  - The label should be top aligned with controls in the group when the group is taller.
  - The content should be vertically centered when the label is taller.
- All the textfields should always be tall enough to show content.
- Radios/checkbox should word wrap to show all their text.
- The spacing between groups is a little more even
- DEPS roll to pick up newer GTM with GTMIBArray.
- A bunch of changes in the XIB related to evening out spacing, adding the GTMIBArray for referencing stuff, etc.
Note: if a single radio word wraps all radios get space for that many lines, that's just how the OS does it and we aren't trying to change that (at the moment).
Note: some of the horizontal layouts can extend off the side of the window, that will be fixed in a future cl (once under the hood is also cleaned up).

TEST=see cl description for what should be working now.
BUG=20538
Review URL: http://codereview.chromium.org/340045
------------------------------------------------------------------------
r30692 | jeremy@chromium.org | 2009-11-02 09:08:48 +0100 (Mon, 02 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Remove tapuz.co.il from search provider list since it isn't a search provider.

This was added erroneously and has never worked, removing.

BUG=7271
TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" , tapuz should not be displayed as a search provider.

Review URL: http://codereview.chromium.org/346013
------------------------------------------------------------------------
r30690 | jam@chromium.org | 2009-11-02 08:12:19 +0100 (Mon, 02 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Fix windows interactive ui test failure introduced in r30687.

BUG=25354
TBR=estade
Review URL: http://codereview.chromium.org/353003
------------------------------------------------------------------------
r30689 | aa@chromium.org | 2009-11-02 07:50:09 +0100 (Mon, 02 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Moved +/i icon next to "Developer Tools" 2 px to the left, and made the text itself a link.

BUG=26406
TEST=Compile and see chrome://extensions

Review URL: http://codereview.chromium.org/340056
Patch from Ramkumar Ramachandra <artagnon@gmail.com>.
------------------------------------------------------------------------
r30688 | jam@chromium.org | 2009-11-02 07:10:30 +0100 (Mon, 02 Nov 2009) | 7 lines
Changed paths:
   M /trunk/src/base/ref_counted.h
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   D /trunk/src/chrome/browser/renderer_host/file_system_accessor.cc
   D /trunk/src/chrome/browser/renderer_host/file_system_accessor.h
   D /trunk/src/chrome/browser/renderer_host/file_system_accessor_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/ipc/ipc_channel_proxy.cc
   M /trunk/src/ipc/ipc_channel_proxy.h

Add the ability for objects which derive from RefCountedThreadSafe to specify a destructor trait.  This allows browser objects to specify which thread they're terminated on.  The benefit is we avoid the need to do manual ref counting when an object posts tasks to itself on different threads, if an object must be destructed on a specific thread.

This patch adds initial support and only shows one example with ResourceMessageFilter.  I will do the rest in a follow-up patch to keep things small.

BUG=25354
TEST=added unit tests
Review URL: http://codereview.chromium.org/338065
------------------------------------------------------------------------
r30687 | jam@chromium.org | 2009-11-02 06:59:37 +0100 (Mon, 02 Nov 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/memory_details_linux.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/strict_transport_security_persister.cc
   M /trunk/src/chrome/browser/strict_transport_security_persister.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/common/important_file_writer.cc
   M /trunk/src/chrome/common/important_file_writer.h
   M /trunk/src/chrome/common/important_file_writer_unittest.cc
   M /trunk/src/chrome/common/pref_member_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h

Third patch in getting rid of caching MessageLoop pointers and always using ChromeThread instead.

BUG=25354

Review URL: http://codereview.chromium.org/342068
------------------------------------------------------------------------
r30685 | thakis@chromium.org | 2009-11-02 04:08:11 +0100 (Mon, 02 Nov 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

Add "Go to..." to the context menu when the selected text in a page is a url.

So when you select:
"http://www.google.com"

The context menu that will appear will be:
"Go to http://www.google.com"

Instead of:
"Search Google for http://www.google.com"

BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.

Review URL: http://codereview.chromium.org/326026
Patch from tfarina.
------------------------------------------------------------------------
r30684 | jrg@chromium.org | 2009-11-02 01:12:26 +0100 (Mon, 02 Nov 2009) | 32 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_constants.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm

Add the "Other bookmarks" button on the right of the bookmark bar.

Lots of fixes to deal better with the floating bar on the
  NTP (e.g. chevron resize, chevron enabling only when there is
  overflow, ...)

Move layoutSubviews logic from bookmark_bar_toolbar_view to
  bookmark_bar_controller to better honor MVC.

BUG=http://crbug.com/24985, http://crbug.com/24827, http://crbug.com/22018

TEST=Lots of moves:
New browser with no bookmarks.
Go to New Tab Page.  Show Bookmark Bar.  
See "Other Bookmarks" button on right.
Do NOT see chevron.
Hover over and click on Other Bookmarks to be sure it doesn't draw out of bounds.
Disable bookmark bar (so it is now floating).
Repeat hover/click test.
Enable (so now attached).
Add bookmarks until chevron shows up.
Repeat hover/click test with chevron and Other Bookmarks.
Make browser wider and thinner; each time repeat hover/click test.
Detach bookmark bar (so floating on NTP).
Make browser wider and thinner; each time repeat hover/click test.
Carefully make browser wider/thinner so chevron appears/disappears.
Make sure chevron never overlaps a bookmark.
With chevron visible, quit & relaunch.  Make sure chevron visible.
With chevron NOT visible, quit & relaunch.  Make sure chevron not visible.


Review URL: http://codereview.chromium.org/348017
------------------------------------------------------------------------
r30681 | thakis@chromium.org | 2009-11-01 22:47:07 +0100 (Sun, 01 Nov 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

Reverting 30679.
Review URL: http://codereview.chromium.org/341062
------------------------------------------------------------------------
r30679 | thakis@chromium.org | 2009-11-01 22:07:13 +0100 (Sun, 01 Nov 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

Add "Go to..." to the context menu when the selected text in a page is a url.

So when you select:
"http://www.google.com"

The context menu that will appear will be:
"Go to http://www.google.com"

Instead of:
"Search Google for http://www.google.com"

BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.

Review URL: http://codereview.chromium.org/326026
------------------------------------------------------------------------
r30677 | erikkay@chromium.org | 2009-11-01 04:57:10 +0100 (Sun, 01 Nov 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/notification_type.h

Implement page action popups.

A random side effect of this change is that it changes page action hover from bubble to tool tip.

BUG=24645
TEST=ExtensionApiTest.PageActionPopup

Review URL: http://codereview.chromium.org/347016
------------------------------------------------------------------------
r30670 | johnnyg@chromium.org | 2009-10-31 17:53:11 +0100 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Reenable PosixSessionEnd test.

------------------------------------------------------------------------
r30668 | mark@chromium.org | 2009-10-31 16:35:26 +0100 (Sat, 31 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/base/message_pump_mac.h
   M /trunk/src/base/message_pump_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

DeferredAutoreleasePool didn't work on Snow Leopard.

This is a backout of r30647, but also resurrects the change from
http://codereview.chromium.org/341022 to work around the crash that r30647
solved much more elegantly.

We can't really leave things broken on 10.6, though.  I killed most of a
perfectly good Friday evening trying to figure out how to salvage r30647,
but the DeferredAutoreleasePool approach seems doomed without making private
calls.

This makes me really sad.

BUG=25857, 26399, 26402
TEST=Does it launch on Snow Leopard now?  Does it crash when you close windows?
Review URL: http://codereview.chromium.org/339095
------------------------------------------------------------------------
r30667 | derat@chromium.org | 2009-10-31 16:23:52 +0100 (Sat, 31 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Re-enable omnibox select-all-on-click for Chrome OS builds.

TEST=built chrome-os and non- binaries and made sure they worked as expected

Review URL: http://codereview.chromium.org/342069
------------------------------------------------------------------------
r30664 | yurys@google.com | 2009-10-31 09:42:21 +0100 (Sat, 31 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: add all scripts from afterCompile events when scripts panel is shown for the first timeBUG=26312
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh

Review URL: http://codereview.chromium.org/341057
------------------------------------------------------------------------
r30662 | ben@chromium.org | 2009-10-31 05:39:45 +0100 (Sat, 31 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

Rework the way the FindBrowserWithProfile/Type methods work.

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. I now also maintain a fallback to walk the entire registered list of browsers forward if the active scan fails. This is likely only in a testing environment where a Browser may never have been activated.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30659
Review URL: http://codereview.chromium.org/330013
------------------------------------------------------------------------
r30661 | ben@chromium.org | 2009-10-31 04:58:56 +0100 (Sat, 31 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

roll back 30659 since it still breaks browser_tests
------------------------------------------------------------------------
r30660 | johnnyg@chromium.org | 2009-10-31 04:27:19 +0100 (Sat, 31 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/api/public/WebRuntimeFeatures.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebRuntimeFeatures.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Change notification cmd line enabling to use the new RuntimeEnabledFeatures code.

BUG=25318
TEST=none

Review URL: http://codereview.chromium.org/339093
------------------------------------------------------------------------
r30659 | ben@chromium.org | 2009-10-31 04:19:15 +0100 (Sat, 31 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

Update: I removed TYPE_ANY to see if I could fool the builders into letting this pass without crashing in browser_tests. It makes the code uglier, but I want to debug and figure out what's going on.

Rework the way the FindBrowserWithProfile/Type methods work.

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531
Review URL: http://codereview.chromium.org/330013
------------------------------------------------------------------------
r30658 | johnnyg@chromium.org | 2009-10-31 03:27:14 +0100 (Sat, 31 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Temporarily disable PosixSessionEnd test to make sure it's not masking other failures.

BUG=none
TEST=none

------------------------------------------------------------------------
r30657 | johnnyg@google.com | 2009-10-31 02:37:27 +0100 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

Reverting 30656.
Review URL: http://codereview.chromium.org/342072
------------------------------------------------------------------------
r30656 | pkasting@chromium.org | 2009-10-31 02:13:45 +0100 (Sat, 31 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h

When the user has highlighted something like a URL, in the context menu show an options to navigate rather than searching.  Original patch by Thiago Farina (see http://codereview.chromium.org/326026 ), r=me.

BUG=1978
TEST=Highlight "google.com" and right-click.
------------------------------------------------------------------------
r30655 | johnnyg@chromium.org | 2009-10-31 02:13:38 +0100 (Sat, 31 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   M /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm

Fix the build by removing some not implemented macros.

TBR=atwilson
BUG=none
TEST=none


------------------------------------------------------------------------
r30652 | johnnyg@chromium.org | 2009-10-31 00:53:08 +0100 (Sat, 31 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   D /trunk/src/chrome/browser/notifications/desktop_notification_service_linux.cc
   D /trunk/src/chrome/browser/notifications/desktop_notification_service_mac.mm
   D /trunk/src/chrome/browser/notifications/desktop_notification_service_win.cc
   M /trunk/src/chrome/chrome.gyp

Now that the UI layer is accessible cross-platform, coalesce the DesktopNotificationService layer into one common module.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343066
------------------------------------------------------------------------
r30648 | erg@google.com | 2009-10-31 00:10:37 +0100 (Sat, 31 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Use background images for location bar, instead of faking it.

BUG=26258
TEST=Border color of location bar matches the buttons on each side.

Review URL: http://codereview.chromium.org/348029
------------------------------------------------------------------------
r30647 | dmaclach@chromium.org | 2009-10-31 00:05:27 +0100 (Sat, 31 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/base/message_pump_mac.h
   M /trunk/src/base/message_pump_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Cleans up our autorelease handling so that we don't create a layered 
autorelease pool in our run loop source if there is one already on the stack 
above us. This allows Cocoa to clean up all the objects at the same time as it 
expects to do. There may be more "interesting" code that can be removed now 
that this is in. Initially we were going to implement it by checking the 
nesting levels of the runloops, but it turns out by the time sendEvent is 
called at the upper level we are already out of the "CFRunloopRun" call so 
our nesting count isn't a valid indicator of our state.

TEST=1) See bug 25857. 2) Start up. Open 3+ windows. Quit.
BUG=25857

Review URL: http://codereview.chromium.org/343024
------------------------------------------------------------------------
r30642 | pkasting@chromium.org | 2009-10-30 23:34:41 +0100 (Fri, 30 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h

Show a warning when the history files can't be read correctly.

This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages.

BUG=25822
TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog.
Review URL: http://codereview.chromium.org/342048
------------------------------------------------------------------------
r30641 | jcampan@chromium.org | 2009-10-30 23:16:37 +0100 (Fri, 30 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

The fix for bug 24248 did not fully bullet-proof the RenderWidgetHostViewWin
for messages recieved after the render view host has been NULLed, causing
crashers with select drop-downs.


BUG=25290
TEST=Make sure select drop-downs work and don't crash the browser.


Review URL: http://codereview.chromium.org/348022
------------------------------------------------------------------------
r30638 | jorlow@chromium.org | 2009-10-30 22:46:14 +0100 (Fri, 30 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc

Fix several MAJOR crashers in Chrome+LocalStorage/Extensions.  Need to explicitly call Stop() in destructor (before the vtable is torn down) since we override CleanUp().

Filed bug to make this impossible in the future: http://code.google.com/p/chromium/issues/detail?id=26365

TEST=DOMStorageTests UI tests don't fail.
BUG=25413,25746

Review URL: http://codereview.chromium.org/345028
------------------------------------------------------------------------
r30633 | pkasting@chromium.org | 2009-10-30 22:07:57 +0100 (Fri, 30 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h

Make sure we can still navigate to URLs when the History DB can't be loaded.

BUG=25822
TEST=Make your History files non-readable, run Chrome (Release), Type in "test.com" and see that the selected action is navigation.
Review URL: http://codereview.chromium.org/343051
------------------------------------------------------------------------
r30631 | estade@chromium.org | 2009-10-30 21:55:55 +0100 (Fri, 30 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_mac.mm
   M /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/app/gfx/font_win.cc
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc

Fix up extension badge text drawing.

Fall abck to the system default font if the preferred font isn't available.

Also, only create the SkPaint struct once, not on every paint.

Also, make some more things const.

BUG=25693
TEST=badge still looks good, that crash goes away

Review URL: http://codereview.chromium.org/341045
------------------------------------------------------------------------
r30624 | tim@chromium.org | 2009-10-30 21:02:14 +0100 (Fri, 30 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Use the original profile to get the sync service when building the app menu.

BUG=23993
TEST=Open incognito window. Click the bookmark sync button. Either the signin dialog
or the options panel should open.

Review URL: http://codereview.chromium.org/350005
------------------------------------------------------------------------
r30623 | johnnyg@chromium.org | 2009-10-30 21:00:48 +0100 (Fri, 30 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   M /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h

Need to load the permissions lists every time at startup for notifications.

BUG=26274
TEST=grant notifications permissions and restart browser

Review URL: http://codereview.chromium.org/339077
------------------------------------------------------------------------
r30622 | tony@chromium.org | 2009-10-30 20:58:06 +0100 (Fri, 30 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc

Convert chrome_url_data_manager (previously a global) into a Singleton.  This
is just cleanup.

Take 2 with a fix in sync code.

TBR=evanm

Review URL: http://codereview.chromium.org/350007
------------------------------------------------------------------------
r30619 | akalin@chromium.org | 2009-10-30 20:50:29 +0100 (Fri, 30 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/app/gfx/font_mac.mm
   A /trunk/src/chrome/browser/cocoa/browser_command_executor.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window_unittest.mm
   A /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h
   A /trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/html_dialog_window_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implemented most of HtmlDialogWindowController, which is a Cocoa port
of HtmlDialogView.

Added TODO to fix inaccurate font height metric for OS X font class (and maybe width).

Added the BrowserCommandExecutor protocol so that not just a
BrowserWindowController can be the window controller for a
ChromeEventProcessingWindow.

Added unittests.  Also tested manually with the bookmark sync setup
wizard dialog.

BUG=23073
TEST=added unittests, trybot, and manual testing

Review URL: http://codereview.chromium.org/344008
------------------------------------------------------------------------
r30615 | viettrungluu@chromium.org | 2009-10-30 20:32:22 +0100 (Fri, 30 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Mac: enable History, Downloads, and Open Location... with no windows open.

BUG=25620
TEST=Close all windows, try History->History (Cmd-Y); close window, try Window->Downloads (Shift-Cmd-J); close window, try Open Location... (Cmd-L).

Review URL: http://codereview.chromium.org/329004
------------------------------------------------------------------------
r30611 | davemoore@chromium.org | 2009-10-30 19:52:16 +0100 (Fri, 30 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/user_settings_posix.cc

Use the password_manager encryptor to encrypt the sync credentials under Linux and OSX.

BUG=none
TEST=Enable bookmark sync, close and re-launch chrome, make sure there are no sync error message at the bottom of the NTP.

Original patch by albertb@chromium.org
Committed by davemoore@chromium.org

Review URL: http://codereview.chromium.org/341012
------------------------------------------------------------------------
r30607 | pkasting@chromium.org | 2009-10-30 19:43:45 +0100 (Fri, 30 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

The SafeBrowsing system had a bunch of plumbing for system resume that wasn't actually hooked to anything.  Seems better to not have it than to have it look like it's doing something when it isn't.

BUG=25336
TEST=none
Review URL: http://codereview.chromium.org/347024
------------------------------------------------------------------------
r30605 | erg@google.com | 2009-10-30 19:40:23 +0100 (Fri, 30 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

GTK: Fix the border around the find bar in chrome theme mode.

Don't fake the border with event boxes, but instead use the theme images.

BUG=26258
TEST=In default theme, make sure find bar border now looks like windows.

Review URL: http://codereview.chromium.org/341055
------------------------------------------------------------------------
r30600 | tony@chromium.org | 2009-10-30 19:15:22 +0100 (Fri, 30 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Revert "Convert chrome_url_data_manager (previously a global) into a"

This reverts commit r30594.

Review URL: http://codereview.chromium.org/342062
------------------------------------------------------------------------
r30599 | atwilson@chromium.org | 2009-10-30 19:11:47 +0100 (Fri, 30 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   A /trunk/src/chrome/renderer/websharedworker_impl.cc
   A /trunk/src/chrome/renderer/websharedworker_impl.h
   A /trunk/src/chrome/renderer/websharedworkerrepository_impl.cc
   A /trunk/src/chrome/renderer/websharedworkerrepository_impl.h
   A /trunk/src/chrome/renderer/webworker_base.cc
   A /trunk/src/chrome/renderer/webworker_base.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   A /trunk/src/webkit/api/public/WebSharedWorker.h (from /trunk/src/webkit/api/src/SharedWorkerRepository.cpp:30598)
   A /trunk/src/webkit/api/public/WebSharedWorkerRepository.h (from /trunk/src/webkit/api/src/SharedWorkerRepository.cpp:30598)
   M /trunk/src/webkit/api/src/SharedWorkerRepository.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Initial pass of shared workers renderer-side code

Added initial interface hooks betweek WebKit code and renderer-side worker code.
The proper messages are generated to fire off a shared worker, but they are currently
ignored by the browser process.

BUG=26233
TEST=none (will enable layout tests when basic functionality available)

Review URL: http://codereview.chromium.org/340036
------------------------------------------------------------------------
r30597 | davemoore@chromium.org | 2009-10-30 19:05:30 +0100 (Fri, 30 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Remove bold from About label.
BUG=25932
TEST=None

Review URL: http://codereview.chromium.org/347009
------------------------------------------------------------------------
r30594 | tony@chromium.org | 2009-10-30 19:02:14 +0100 (Fri, 30 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Convert chrome_url_data_manager (previously a global) into a
Singleton.  This is just cleanup.

Review URL: http://codereview.chromium.org/339078
------------------------------------------------------------------------
r30593 | oshima@chromium.org | 2009-10-30 18:58:24 +0100 (Fri, 30 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   A /trunk/src/chrome/browser/chromeos/external_protocol_dialog.cc
   A /trunk/src/chrome/browser/chromeos/external_protocol_dialog.h (from /trunk/src/chrome/browser/views/external_protocol_dialog.h:30592)
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/chrome.gyp

Enable ExternalProtocolDialog for Chromeos.
 * It simply says it's not supported as ChromeOS wont launch external program.
Fixed resource files to use chromeos. Apparently I misunderstood how this works when I added 'toolkit_views' to grd files. It was never defined, and wasn't necessary.

BUG=23853
TEST=type in "apple.cm" in the omnibox and it should popup the external protocol dialog.

Review URL: http://codereview.chromium.org/342040
------------------------------------------------------------------------
r30591 | mark@chromium.org | 2009-10-30 18:32:22 +0100 (Fri, 30 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/cocoa_protocols_mac.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h

BookmarkEditorController needs to implement NSMatrixDelegate for the 10.6 SDK
build.

BUG=arthropod
TEST=build with mac_sdk=10.6
Review URL: http://codereview.chromium.org/345026
------------------------------------------------------------------------
r30590 | mirandac@chromium.org | 2009-10-30 18:29:27 +0100 (Fri, 30 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disable DownloadTest.PerWindowShelf because of flakiness.

BUG= http://crbug.com/26325
TEST= none

Review URL: http://codereview.chromium.org/348024
------------------------------------------------------------------------
r30584 | avi@chromium.org | 2009-10-30 17:16:19 +0100 (Fri, 30 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h

Use FilePath in UserDataDirDialog to remove the use of FilePath::FromWStringHack.

Patch by tfarina.

BUG=None
TEST=None 

Review URL: http://codereview.chromium.org/334017

------------------------------------------------------------------------
r30567 | brg@chromium.com | 2009-10-30 09:48:51 +0100 (Fri, 30 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_history_apitest.cc

Disable flaky test.  See http://crbug.com/26296
BUG=26296
TEST=none
Review URL: http://codereview.chromium.org/346021
------------------------------------------------------------------------
r30562 | thakis@chromium.org | 2009-10-30 07:13:06 +0100 (Fri, 30 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm

[mac] Make NTP floating style rect 1px thick. Also change the border color.

Remember: Cocoa coordinates are on 0.5.

http://imgur.com/1IIRZ

TBR=dmaclach

BUG=25941
TEST=Show NTP to ben. He shouldn't scream at you too much.

Review URL: http://codereview.chromium.org/342051
------------------------------------------------------------------------
r30561 | brg@chromium.com | 2009-10-30 06:25:01 +0100 (Fri, 30 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_history_api.cc
   A /trunk/src/chrome/browser/extensions/extension_history_api.h
   A /trunk/src/chrome/browser/extensions/extension_history_api_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_history_api_constants.h
   A /trunk/src/chrome/browser/extensions/extension_history_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/history
   A /trunk/src/chrome/test/data/extensions/api_test/history/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/history/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/history/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/history/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/history/test.js

Implement the Extension History API, v 0.1.The first version is a weak wrapper around the HistoryServices object in Chrome.BUG=22952TEST=browser_tests.exe --gtest_filer=ExtensionApiTest.History
Review URL: http://codereview.chromium.org/313001
------------------------------------------------------------------------
r30557 | johnnyg@chromium.org | 2009-10-30 04:44:03 +0100 (Fri, 30 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   M /trunk/src/chrome/browser/notifications/desktop_notification_service_win.cc
   A /trunk/src/chrome/browser/notifications/notification_ui_manager.cc
   A /trunk/src/chrome/browser/notifications/notification_ui_manager.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/testing_browser_process.h

Connect the various pieces for notifications... hook up NotificationUIManager to BrowserProcess to DesktopNotificationService to RenderView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/342043
------------------------------------------------------------------------
r30553 | jam@chromium.org | 2009-10-30 03:24:50 +0100 (Fri, 30 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

LocalStorageLayoutTests are flakey on Linux as well.

BUG=24145
TBR=jorlow

Review URL: http://codereview.chromium.org/344029
------------------------------------------------------------------------
r30550 | jam@chromium.org | 2009-10-30 02:49:06 +0100 (Fri, 30 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/user_script_listener.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener.h
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc

Get rid of MessageLoop* caching in extensions code.

BUG=25354
Review URL: http://codereview.chromium.org/345023
------------------------------------------------------------------------
r30547 | thakis@chromium.org | 2009-10-30 02:32:30 +0100 (Fri, 30 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.h
   A /trunk/src/chrome/browser/cocoa/repost_form_warning_mac.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Implement form resubmission warning dialog

Surprisingly, this is not a tab-modal sheet on linux and windows, so it's window-modal on os x as well for now.

BUG=23526
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html , click "Do it!", hit reload. Window sheet should come up. Hitting cancel should cancel the navigation (and hitting reload again should bring up sheet again). Hitting "Resend" should trigger reload.

Review URL: http://codereview.chromium.org/327009
------------------------------------------------------------------------
r30546 | pkasting@chromium.org | 2009-10-30 02:22:21 +0100 (Fri, 30 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

Based on the rest of the codebase, I think we're supposed to #include chromium_strings rather than google_chrome_strings, although I doubt it would matter.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343050
------------------------------------------------------------------------
r30544 | chocobo@google.com | 2009-10-30 02:15:02 +0100 (Fri, 30 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extenders.cc

Fix linux view build breakage.
------------------------------------------------------------------------
r30542 | tim@chromium.org | 2009-10-30 01:35:00 +0100 (Fri, 30 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

Disable form entry while sending credentials. 

BUG=19980
TEST=See the steps in the bug description. 

Patch by Randy Posynick<randy.posynick@gmail.com>
http://codereview.chromium.org/287008

Review URL: http://codereview.chromium.org/339075
------------------------------------------------------------------------
r30541 | chocobo@google.com | 2009-10-30 01:35:00 +0100 (Fri, 30 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos/browser_extenders.cc (from /trunk/src/chrome/browser/chromeos/chromeos_browser_extenders.cc:30488)
   D /trunk/src/chrome/browser/chromeos/chromeos_browser_extenders.cc
   D /trunk/src/chrome/browser/chromeos/chromeos_version_loader.cc
   D /trunk/src/chrome/browser/chromeos/chromeos_version_loader.h
   D /trunk/src/chrome/browser/chromeos/chromeos_version_loader_unittest.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/compact_location_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_location_bar.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/chromeos/cros_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_library.h
   D /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   D /trunk/src/chrome/browser/chromeos/cros_network_library.h
   D /trunk/src/chrome/browser/chromeos/cros_power_library.cc
   D /trunk/src/chrome/browser/chromeos/cros_power_library.h
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.h
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor.cc
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor.h
   M /trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   A /trunk/src/chrome/browser/chromeos/network_library.cc (from /trunk/src/chrome/browser/chromeos/cros_network_library.cc:30488)
   A /trunk/src/chrome/browser/chromeos/network_library.h (from /trunk/src/chrome/browser/chromeos/cros_network_library.h:30488)
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/panel_controller.cc
   M /trunk/src/chrome/browser/chromeos/panel_controller.h
   M /trunk/src/chrome/browser/chromeos/password_dialog_view.cc
   M /trunk/src/chrome/browser/chromeos/password_dialog_view.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader.cc
   M /trunk/src/chrome/browser/chromeos/pipe_reader.h
   M /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc
   A /trunk/src/chrome/browser/chromeos/power_library.cc (from /trunk/src/chrome/browser/chromeos/cros_power_library.cc:30488)
   A /trunk/src/chrome/browser/chromeos/power_library.h (from /trunk/src/chrome/browser/chromeos/cros_power_library.h:30488)
   M /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.h
   M /trunk/src/chrome/browser/chromeos/settings_page_view.cc
   M /trunk/src/chrome/browser/chromeos/settings_page_view.h
   M /trunk/src/chrome/browser/chromeos/status_area_button.cc
   M /trunk/src/chrome/browser/chromeos/status_area_button.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   A /trunk/src/chrome/browser/chromeos/version_loader.cc (from /trunk/src/chrome/browser/chromeos/chromeos_version_loader.cc:30488)
   A /trunk/src/chrome/browser/chromeos/version_loader.h (from /trunk/src/chrome/browser/chromeos/chromeos_version_loader.h:30488)
   A /trunk/src/chrome/browser/chromeos/version_loader_unittest.cc (from /trunk/src/chrome/browser/chromeos/chromeos_version_loader_unittest.cc:30488)
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/chrome.gyp

Move chromeos code to namespace chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341044
------------------------------------------------------------------------
r30540 | tim@chromium.org | 2009-10-30 01:34:43 +0100 (Fri, 30 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc

Fix for crash when a bookmark URL is an empty string 

BUG=19852
TEST=See repro steps of the bug 

Patch by Bruno Calvignac <BrunoCalvignac@gmail.com>
Original CL http://codereview.chromium.org/282004

Review URL: http://codereview.chromium.org/342046
------------------------------------------------------------------------
r30539 | ben@chromium.org | 2009-10-30 01:22:27 +0100 (Fri, 30 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

Revert r30541 since it's still breaking browser_tests
------------------------------------------------------------------------
r30532 | thakis@chromium.org | 2009-10-30 00:35:09 +0100 (Fri, 30 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Unflaky tests.

Since bug 24721 is fixed, these might work again. They don't show up on the flakiness dashboard, suggesting that they behaved for a while.

BUG=24632,24889
TEST=Tests not super flaky

Review URL: http://codereview.chromium.org/345024
------------------------------------------------------------------------
r30531 | ben@chromium.org | 2009-10-30 00:28:10 +0100 (Fri, 30 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

Rework the way the FindBrowserWithProfile/Type methods work.

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.

Review URL: http://codereview.chromium.org/330013
------------------------------------------------------------------------
r30527 | tony@chromium.org | 2009-10-29 23:25:36 +0100 (Thu, 29 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Some new tab ui fixes.

1) Always intialize the css cache.  Previously we were only
initializing if not in incognito mode.  If the first NTP was an
incognito page, it wouldn't be styled.

2) Small optimization in generating the HTML to avoid calling
ReplaceFirstSubstringAfterOffset which would need to move the
bytes after the placeholder.

3) Only generate the css for the incognito or normal mode.  Since
the NTP only needs one, we only need to generate one.

BUG=26228

Review URL: http://codereview.chromium.org/344027
------------------------------------------------------------------------
r30523 | mrossetti@chromium.org | 2009-10-29 23:10:32 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_tree_browser_cell.h
   A /trunk/src/chrome/browser/cocoa/bookmark_tree_browser_cell.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_tree_browser_cell_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Original discussion in CL for 337010.  See http://codereview.chromium.org/337010/show/.

BUG=25099
TEST=See 337010.

Review URL: http://codereview.chromium.org/343042
------------------------------------------------------------------------
r30522 | estade@chromium.org | 2009-10-29 23:08:32 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

GTK: add back toolbar border.

BUG=26239
TEST=launch browser, look at border under toolbar, open findbar

Review URL: http://codereview.chromium.org/339074
------------------------------------------------------------------------
r30521 | cira@chromium.org | 2009-10-29 22:47:40 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/bad/Preferences
   M /trunk/src/chrome/test/data/extensions/good/Preferences

- Removes fallback from Prefs to LoadExtension on UI thread.
- Fix extension_service_unittest to actually load extensions from prefs.

BUG=19733
TEST=Remove extension manifest from Preferences file. Extension shouldn't load even if the necessary files are present.
Review URL: http://codereview.chromium.org/339058
------------------------------------------------------------------------
r30519 | pkasting@chromium.org | 2009-10-29 22:38:24 +0100 (Thu, 29 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h

Use the new SearchVersusNavigateClassifier in BrowserRootView.  Patch by Thiago Farina (see http://codereview.chromium.org/347020 ), r=me, tweaked.

BUG=21317
TEST=none
------------------------------------------------------------------------
r30518 | finnur@chromium.org | 2009-10-29 22:34:31 +0100 (Thu, 29 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

A bit of polish for the extensions page.

Minor position changes to the CSS to make the page
match the other pages better when flipping
betwen the downloads, history and extensions page.

BUG=http://crbug.com/26120
TEST=Flip between History and Downloads page and
the icon and the header section should line up
and be the same size on all three pages.
Review URL: http://codereview.chromium.org/339073
------------------------------------------------------------------------
r30512 | jhawkins@chromium.org | 2009-10-29 22:17:13 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/form_field.cc
   M /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc

Remove the element_ member of FormField, as we don't use it and shouldn't be using WebCore internals in glue anyway.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/342032
------------------------------------------------------------------------
r30511 | estade@chromium.org | 2009-10-29 22:08:52 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc

GTK Improve look of about dialog.

BUG=26173

Review URL: http://codereview.chromium.org/345022
------------------------------------------------------------------------
r30509 | ben@chromium.org | 2009-10-29 22:01:45 +0100 (Thu, 29 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc

Remove out of date comment.
------------------------------------------------------------------------
r30508 | pkasting@chromium.org | 2009-10-29 21:38:22 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc

If we remove a search engine from our prepopulate data, remove it from the user's list too if they haven't edited it or made it default.

BUG=none
TEST=Covered by unittest
Review URL: http://codereview.chromium.org/339071
------------------------------------------------------------------------
r30507 | ben@chromium.org | 2009-10-29 21:35:37 +0100 (Thu, 29 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix and re-enable a test I broke with the find bar changes I made last night.

Remove Browser::find_bar(), make everyone use either Browser::GetFindBarController() which creates the FindBarController on demand, or a new method HasFindBarController(), which can be used to check for its existence (so as to avoid creating it unnecessarily).

http://crbug.com/26231
TEST=interactive ui tests, standard find tests

Review URL: http://codereview.chromium.org/348015
------------------------------------------------------------------------
r30504 | finnur@chromium.org | 2009-10-29 21:20:32 +0100 (Thu, 29 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/browser_url_util.cc

Mailto links should not include mailto: when copying to the clipboard.

BUG=24430
TEST=Right click a mailto:foo@bar.com link on a page, select Copy email
address. Make sure the clipboard contains foo@bar.com and no mailto:
prefix.

Review URL: http://codereview.chromium.org/342031
------------------------------------------------------------------------
r30499 | asargent@chromium.org | 2009-10-29 20:58:47 +0100 (Thu, 29 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/old_page_actions/page.html

New event style for pageAction API.

This makes us fire both the old deprecated style of pageActions click handler and the new pageAction style. 

BUG=25833
TEST=none


Review URL: http://codereview.chromium.org/346006
------------------------------------------------------------------------
r30498 | brettw@chromium.org | 2009-10-29 20:58:43 +0100 (Thu, 29 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc

Fix transparent windowless plugin background painting. This would manifest
itself as incorrect ClearType edges.

The problem was that we were taking into account the translation from the page
coordinate system when blitting the background, but this had already been
accounted for in the transformation matrix, resulting in duplicate
transformations.

The fix simplifies the code by not tranlating into the page coordinate system
until later, staying in the plugin coordinate system which is more convenient.
This means that the background (which is the same size as the buffer) can just
be painted at (0,0) with no fuss and no muss. We don't even need to worry about
how much we paint since the clip was already installed.

This also corrects some indenting in browser.cc that I noticed.

TEST="Attach a file" text in Gmail compose looks weird (sometimes requires
     selecting it to make this happen).
BUG=26080
Review URL: http://codereview.chromium.org/343040
------------------------------------------------------------------------
r30497 | brettw@chromium.org | 2009-10-29 20:58:30 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/webkit/database/vfs_backend.cc

Random style fixes in the database backend.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/340004
------------------------------------------------------------------------
r30495 | arv@chromium.org | 2009-10-29 20:52:31 +0100 (Thu, 29 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   A /trunk/src/chrome/browser/dom_ui/shown_sections_handler_unittest.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

NTP: Allow hiding tips and bookmark sync.

This change adds 2 new menu items to the option menu.

There is pref migration code to make tips and sync visible by default.

BUG=24319

TEST=Hide and show the different sections and reload to make sure it
is persisted across instances of NTP.

Review URL: http://codereview.chromium.org/337011
------------------------------------------------------------------------
r30492 | craig.schlenter@chromium.org | 2009-10-29 20:49:08 +0100 (Thu, 29 Oct 2009) | 10 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/notifier/base/linux/time_linux.cc
   M /trunk/src/chrome/chrome.gyp

Linux: Remove unnecessary time_linux.cc from sync code.

time_posix.cc has the actual code and compiles on Linux
already. Including both files causes linker errors for
the shared build.

BUG=none
TEST=compiles on trybots

Review URL: http://codereview.chromium.org/341035
------------------------------------------------------------------------
r30491 | tony@chromium.org | 2009-10-29 20:48:54 +0100 (Thu, 29 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc

Convert ReplaceStringPlaceholders(std::string...) to take a
StringPiece as the format string instead.  This allows us to save
a string copy in the new tab page.

Also clean up some code in the extensions process binding that
was doing excess string conversions.

BUG=26228

Review URL: http://codereview.chromium.org/347019
------------------------------------------------------------------------
r30488 | munjal@chromium.org | 2009-10-29 20:17:12 +0100 (Thu, 29 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc

Gosh, fix a typo to really fix the tree.

------------------------------------------------------------------------
r30487 | munjal@chromium.org | 2009-10-29 20:12:01 +0100 (Thu, 29 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc

Fix the warning treated as error on linux 64 bit build of
comparing signed and unsigned values.

BUG=tree break
TEST=none

Review URL: http://codereview.chromium.org/339070
------------------------------------------------------------------------
r30486 | mirandac@chromium.org | 2009-10-29 19:47:17 +0100 (Thu, 29 Oct 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/bug_report_util.cc
   A /trunk/src/chrome/browser/bug_report_util.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/chrome.gyp

Hoist bug reporting code out of bug_report_view so that it can be used cross-platform.

BUG= none
TEST= bug reporting should work the same on Windows.


Review URL: http://codereview.chromium.org/339051
------------------------------------------------------------------------
r30485 | pinkerton@chromium.org | 2009-10-29 19:44:51 +0100 (Thu, 29 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm

Don't use NSEvent currentEvent for the event that starts the context menu, it may not be what we think it is.
BUG=23157
TEST=context menus in the web content area, esp rapid right-click and dragging.
Review URL: http://codereview.chromium.org/344024
------------------------------------------------------------------------
r30484 | munjal@chromium.org | 2009-10-29 19:37:34 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Try to revive the revision 30441 which was reverted in 30443.

BUG=23978
TEST=Added unit test

Review URL: http://codereview.chromium.org/343041
------------------------------------------------------------------------
r30482 | estade@chromium.org | 2009-10-29 19:34:23 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

GTK: redraw browser action when badge text changes.

BUG=26024

Review URL: http://codereview.chromium.org/347015
------------------------------------------------------------------------
r30481 | estade@chromium.org | 2009-10-29 19:34:12 +0100 (Thu, 29 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/theme_install_bubble_view.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/common/notification_type.h

Hide the theme install bubble a little earlier.

The bubble was showing at the same time as the installation confirmation dialog for non-theme extensions.

BUG=26130

Review URL: http://codereview.chromium.org/339055
------------------------------------------------------------------------
r30476 | stuartmorgan@chromium.org | 2009-10-29 19:19:19 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc

Disable FindInPageTest.FocusRestore, which is killing the Interactive Tests bot

BUG=26231
TEST=Interactive Tests bot green-ness

Review URL: http://codereview.chromium.org/342038
------------------------------------------------------------------------
r30473 | pkasting@chromium.org | 2009-10-29 18:53:21 +0100 (Thu, 29 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/search_versus_navigate_classifier.cc
   A /trunk/src/chrome/browser/search_versus_navigate_classifier.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Factor search vs. navigate classification into its own file to make it more broadly usable.  Patch by Thiago Farina (see http://codereview.chromium.org/328031 ), r=me.

BUG=21317
TEST=none
------------------------------------------------------------------------
r30472 | thestig@chromium.org | 2009-10-29 18:52:58 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h

Put TabGtk's Observer inside a scoped_ptr.

BUG=24679
TEST=Mouse down on a tab, then press ctrl+w. This should not result in a dangling pointer in the MessagePump's ObserverList.
Review URL: http://codereview.chromium.org/340028
------------------------------------------------------------------------
r30471 | johnnyg@chromium.org | 2009-10-29 18:51:36 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/notifications/balloon.cc
   A /trunk/src/chrome/browser/notifications/balloon.h
   A /trunk/src/chrome/browser/notifications/balloon_collection.cc
   A /trunk/src/chrome/browser/notifications/balloon_collection.h
   A /trunk/src/chrome/browser/notifications/balloon_collection_linux.cc
   A /trunk/src/chrome/browser/notifications/balloon_collection_mac.mm
   A /trunk/src/chrome/browser/notifications/balloon_collection_win.cc
   D /trunk/src/chrome/browser/notifications/balloons.h
   A /trunk/src/chrome/browser/views/notifications
   A /trunk/src/chrome/browser/views/notifications/balloon_view.cc
   A /trunk/src/chrome/browser/views/notifications/balloon_view.h
   A /trunk/src/chrome/browser/views/notifications/balloon_view_host.cc
   A /trunk/src/chrome/browser/views/notifications/balloon_view_host.h
   A /trunk/src/chrome/browser/views/notifications/balloon_view_host_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Adds UI components for desktop notifications, including balloon view classes to display toasts on the screen, and manager for controlling the layout of the balloons.

BUG=none
TEST=none yet (part of larger patch)

Review URL: http://codereview.chromium.org/338051
------------------------------------------------------------------------
r30470 | davemoore@chromium.org | 2009-10-29 18:43:44 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/process.h
   A /trunk/src/base/process_linux.cc
   M /trunk/src/base/process_posix.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/process_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Lower priorities of background tabs on linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/345009
------------------------------------------------------------------------
r30468 | jam@chromium.org | 2009-10-29 18:34:19 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix unit test memory leak introduced by my ChromeThread change.

BUG=26213

Review URL: http://codereview.chromium.org/346014
------------------------------------------------------------------------
r30466 | tony@chromium.org | 2009-10-29 18:32:27 +0100 (Thu, 29 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h

Uninstall themes after the undo infobar goes away.

We don't hold a pointer to the Extension in ThemeInstalledInfobarDelegate because it can become invalid.  Instead we use the id to uninstall if the extension exists at infobar close time.

Also keep the code for deleting themes on shutdown to clean up old users and because a crash could leave themes hanging around.

BUG=25832

Review URL: http://codereview.chromium.org/343027
------------------------------------------------------------------------
r30465 | tony@chromium.org | 2009-10-29 18:29:45 +0100 (Thu, 29 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Only use std::string when generating the NTP CSS.  This saves
about 10ms on the UI thread on my debug build.

This saves a lot of string conversion.

BUG=23120

Review URL: http://codereview.chromium.org/341028
------------------------------------------------------------------------
r30463 | erg@chromium.org | 2009-10-29 18:05:23 +0100 (Thu, 29 Oct 2009) | 13 lines
Changed paths:
   A /trunk/src/chrome/browser/app_controller_cppsafe_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/chrome.gyp

Fix window restore behaviour on Mac.

On the mac, there can be no windows, but the application is sitll open. This
confused "Restore the pages that were open last" so that it would restore
when opening a new window.

BUG=13341
TEST=Open chromium. Set On Startup to "Restore the pages that were open last".
Open a few tabs. Close the window (but not chromium). Click the dock icon.
The tabs shouldn't be restored. But if you quit chrome and start again,
things should reopen.

Review URL: http://codereview.chromium.org/340023
------------------------------------------------------------------------
r30460 | mirandac@chromium.org | 2009-10-29 17:38:22 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Disable ExtensionsServiceTest.InstallExtension and ExtensionTest.InitFromValueInvalid until fix is in.

BUG= http://crbug.com/26214
TEST= none
Review URL: http://codereview.chromium.org/343038
------------------------------------------------------------------------
r30457 | pfeldman@chromium.org | 2009-10-29 17:07:21 +0100 (Thu, 29 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   A /trunk/src/webkit/api/public/WebCookie.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   A /trunk/src/webkit/glue/webcookie.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/webkit.gyp

DevTools: Implement raw cookies access for inspector.
Review URL: http://codereview.chromium.org/294025
------------------------------------------------------------------------
r30456 | pfeldman@chromium.org | 2009-10-29 16:18:56 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools:  Webkit merge broke DevToolsSanityTest.TestEnableResourcesTab
BUG=26171
TBR=yurys

Review URL: http://codereview.chromium.org/340035
------------------------------------------------------------------------
r30449 | phajdan.jr@chromium.org | 2009-10-29 10:40:10 +0100 (Thu, 29 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   D /trunk/src/chrome/browser/views/blacklist_error_dialog.cc
   D /trunk/src/chrome/browser/views/blacklist_error_dialog.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   D /trunk/src/chrome/tools/pbl_tool/DEPS
   D /trunk/src/chrome/tools/pbl_tool/pbl_tool.cc

Design changes in browser/privacy_blacklist needed to integrate
privacy blacklists with extensions.

- change I/O routines interface to be more clear
- distinguish between transient and permanent blacklists
- remove obsolete code (pbl_tool and blacklist error dialog)

BlacklistManager will be responsible for recompiling the persistent
blacklists. Errors will be reported via infobars.

TEST=Covered by unit_tests.
BUG=21541

Review URL: http://codereview.chromium.org/337025
------------------------------------------------------------------------
r30447 | rolandsteiner@chromium.org | 2009-10-29 10:18:55 +0100 (Thu, 29 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc

Disable browser test ViewIDTest.Basic that fails on Linux since around r30434

c.f. http://code.google.com/p/chromium/issues/detail?id=26192

BUG=none
TEST=browser tests on Linux succeed again

Review URL: http://codereview.chromium.org/346011
------------------------------------------------------------------------
r30444 | aa@chromium.org | 2009-10-29 08:34:45 +0100 (Thu, 29 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Only dispatch tab events when there is someone listening.

This should cut down on the number of occurrences of a crash that happens in JSON serialization.

BUG=25558,26169

Review URL: http://codereview.chromium.org/341029
------------------------------------------------------------------------
r30443 | aa@chromium.org | 2009-10-29 08:31:00 +0100 (Thu, 29 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Reverting r30441. Fails compile on linux x64.

TBR=munjal@chromium.org
------------------------------------------------------------------------
r30441 | munjal@chromium.org | 2009-10-29 07:48:15 +0100 (Thu, 29 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Make some improvements to sync model associator:
- Fail the load assocications if there the total number of
  nodes in the bookmark model and the sync model don't match
  (issue: 25542)
- Add a bookmark id index and use that during load assocications
  instead of calling BookmarkModel::GetNodeByID since the latter
  traverses the entier tree in DFS order until it finds the node
  with the given ID.
- Add a unit test that would exercise the new model associator
  load associations behavior.

BUG=25542
TEST=Unit test added.

Review URL: http://codereview.chromium.org/337037
------------------------------------------------------------------------
r30440 | ukai@chromium.org | 2009-10-29 07:18:11 +0100 (Thu, 29 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
   A /trunk/src/chrome/browser/renderer_host/socket_stream_dispatcher_host.h
   A /trunk/src/chrome/browser/renderer_host/socket_stream_host.cc
   A /trunk/src/chrome/browser/renderer_host/socket_stream_host.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/net/socket_stream.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   A /trunk/src/chrome/renderer/socket_stream_dispatcher.cc
   A /trunk/src/chrome/renderer/socket_stream_dispatcher.h

WebSocket support in chromium.

Run with --enable-web-sockets enables WebSocket features.

BUG=12497
TEST=none

Review URL: http://codereview.chromium.org/292044
------------------------------------------------------------------------
r30435 | ben@chromium.org | 2009-10-29 06:14:03 +0100 (Thu, 29 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

roll back r30430 because it causes bustage even though I don't know why.
------------------------------------------------------------------------
r30434 | ben@chromium.org | 2009-10-29 05:09:17 +0100 (Thu, 29 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Lazily create the find bar.

http://crbug.com/21910
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30062
Review URL: http://codereview.chromium.org/334019
------------------------------------------------------------------------
r30433 | thestig@chromium.org | 2009-10-29 05:02:55 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Move FileDescriptorGetInode() and FindProcessHoldingSocket() into base/linux_util.cc. Reimplement FileDescriptorGetInode().

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/312002
------------------------------------------------------------------------
r30431 | mark@chromium.org | 2009-10-29 04:25:48 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm

Reduce NSImageCacheTest.LookupFoundAndClear test flake

BUG=26176
TEST=watch this test on the bots tomorrow
Review URL: http://codereview.chromium.org/344019
------------------------------------------------------------------------
r30430 | ben@chromium.org | 2009-10-29 04:24:00 +0100 (Thu, 29 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h

Rework the way the FindBrowserWithProfile/Type methods work.

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.

Review URL: http://codereview.chromium.org/330013
------------------------------------------------------------------------
r30429 | ben@chromium.org | 2009-10-29 04:16:44 +0100 (Thu, 29 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Use a regular interface pointer for ITextDocument in AutocompleteEditViewWin.

I'm doing this because we want precise control over the lifetime of the validity of this pointer.

It turns out the paint patching code caused richedit20.dll to be unloaded, which caused the pointer held by the ScopedComPtr member to become junk and the subsequent ~ScopedComPtr to crash.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/340014
------------------------------------------------------------------------
r30427 | nsylvain@chromium.org | 2009-10-29 04:05:49 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm

Mark LookupFoundAndClear as flaky.

BUG:26176

Review URL: http://codereview.chromium.org/343031
------------------------------------------------------------------------
r30426 | thestig@chromium.org | 2009-10-29 03:55:44 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: set minimum window size to 100x100 so it does not disappear with a custom frame and so it is easy to resize.

BUG=11258
TEST=Turn on custom frame, try to make window as small as possible. It should not be infinitely small or a pain to resize.
Review URL: http://codereview.chromium.org/347013
------------------------------------------------------------------------
r30425 | thestig@chromium.org | 2009-10-29 03:54:34 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Do not allow GTK File Chooser dialogs to return directories. This is probably a regression in newer versions of GTK.

BUG=23595
TEST=In Jaunty, attempt to attach /usr/bin in Gmail.
Review URL: http://codereview.chromium.org/306060
------------------------------------------------------------------------
r30421 | zork@chromium.org | 2009-10-29 03:21:55 +0100 (Thu, 29 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h

Fix the notifier SSL layer to make notifications work for Linux Bookmark sync.

BUG=none
TEST=1.  Enable bookmark sync on Linux.
2.  Options -> Sync my bookmarks
3.  Log in.
4:  Go to "about:sync" and check that "Notifications Enabled" is true.


Review URL: http://codereview.chromium.org/339056
------------------------------------------------------------------------
r30418 | amit@chromium.org | 2009-10-29 03:14:17 +0100 (Thu, 29 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_url_handler.cc

Prevent 'view-source' from being abused by disabling anything
other than http, https, ftp or file protocols in it.

BUG=26129
TEST=view-source:javascript:alert('foo') should no longer work in chrome's address bar.

Review URL: http://codereview.chromium.org/348004
------------------------------------------------------------------------
r30416 | jorlow@chromium.org | 2009-10-29 02:43:41 +0100 (Thu, 29 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable DevToolsSanityTest.TestEnableResourcesTab after WebKit roll broke it.

TBR=pfeldman
TEST=none
BUG=26171
Review URL: http://codereview.chromium.org/339060
------------------------------------------------------------------------
r30414 | jam@chromium.org | 2009-10-29 02:14:03 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Call Release instead of deleteing the object directly.

BUG=25354
TBR=nsylvain
Review URL: http://codereview.chromium.org/341027
------------------------------------------------------------------------
r30410 | jam@chromium.org | 2009-10-29 01:27:43 +0100 (Thu, 29 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Fix memory leaks in unit tests from my previous checkin.

BUG=25354
Review URL: http://codereview.chromium.org/348003
------------------------------------------------------------------------
r30409 | jhawkins@chromium.org | 2009-10-29 01:14:18 +0100 (Thu, 29 Oct 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/autofill_manager.cc
   D /trunk/src/chrome/browser/autofill_manager.h

Remove the old AutofillManager source files that have been replaced by FormFieldHistory.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/347014
------------------------------------------------------------------------
r30403 | sky@chromium.org | 2009-10-29 00:04:59 +0100 (Thu, 29 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   A /trunk/src/chrome/browser/automation/automation_provider_views.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc

Gets AutomationProxyVisibleTest.WindowGetViewBounds to pass on
views/gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/338067
------------------------------------------------------------------------
r30402 | thestig@chromium.org | 2009-10-28 23:54:47 +0100 (Wed, 28 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Move a Linux only #include into the right place.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341026
------------------------------------------------------------------------
r30400 | evan@chromium.org | 2009-10-28 23:30:22 +0100 (Wed, 28 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

linux: don't override mouse selection behavior in omnibox

This means we now don't match Windows Chrome (which selects all on single
click) nor Firefox (which selects all on double click).

Patch by Dan Erat; I'm submitting it on his behalf.

This is an EXPERIMENT.  I may revert it at my own discretion.
If you don't like it, please complain at
  http://code.google.com/p/chromium/issues/detail?id=26140
so your feedback can be tallied.

BUG=11614,12713,19508,others.
TEST=single click in omnibox does not select all

Review URL: http://codereview.chromium.org/340024
------------------------------------------------------------------------
r30398 | jcampan@chromium.org | 2009-10-28 23:24:49 +0100 (Wed, 28 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc

Attempt at fixing bug 24248 with a workaround.
This is a similar fix to what eroman did previously.
We NULL render_widget_host_ when it's deleted, so we do not call it if it's been destroyed.
Added a bunch of check for render_widget_host_ before using it, as eroman changes triggered some crashers with some windows messages somehow happening after render_widget_host_ was NULLed.
Also added a NOTREACHED when the RenderWidgetHostViewWin OnFinalMessage is called and the destruction has not been initiated by the render view host, but it's gone, in an attempt to understand how this crasher can happen.
More info is available in the bug comments.

BUG=24248
TEST=Make sure opening/closing tab works as expected.
     Test that selects (for example the language on under
     http://www.google.com/advanced_search?hl=en can be open,
     closed, selected.

Review URL: http://codereview.chromium.org/338054
------------------------------------------------------------------------
r30395 | tony@chromium.org | 2009-10-28 23:22:40 +0100 (Wed, 28 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Give the TabContentsContainer a white background so the user will
initially see white.  On debug builds, you see white, green, then
the page.

BUG=20059

Review URL: http://codereview.chromium.org/342027
------------------------------------------------------------------------
r30393 | stuartmorgan@chromium.org | 2009-10-28 23:13:00 +0100 (Wed, 28 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc

Fix call ordering in Carbon plugin interposing

SetSystemUIMode seems to be unhappy with releasing full screen mode while a full-screen plugin window is still frontmont; swap the order of our calls so we do them after the window is closed instead.

BUG=25838
TEST=Open a full-screen Flash window, then exit. Dock should re-appear.

Review URL: http://codereview.chromium.org/342026
------------------------------------------------------------------------
r30386 | oshima@chromium.org | 2009-10-28 21:45:42 +0100 (Wed, 28 Oct 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_extenders.cc
   A /trunk/src/chrome/browser/chromeos/compact_location_bar.cc
   A /trunk/src/chrome/browser/chromeos/compact_location_bar.h
   M /trunk/src/chrome/browser/views/frame/browser_extender.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

CompactLocationBar 1st step:
 * Added OnMouseXXXTab methods to BrowserExtender to handle on tabs.
 * Changed tab to call above methods.
 * Added GetSelectedTab to TabStrip

Minor changes along with the major changes above
* Removed unnecessary file entries in chrome.gyp
* Fixed a few method's const.
* Removed unnecessary class declarations and includes.

Know issue: keyboard focus is not working.
In 2nd step, I'm going to eliminate popup and use whatever that FindBar is using to show compact location bar. I'll fix the issue above after this migration. (if it still persists)

BUG=None
Test=None

Review URL: http://codereview.chromium.org/341008
------------------------------------------------------------------------
r30384 | finnur@chromium.org | 2009-10-28 21:41:17 +0100 (Wed, 28 Oct 2009) | 13 lines
Changed paths:
   A /trunk/src/chrome/app/theme/extensions_section.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   D /trunk/src/chrome/browser/resources/default_extension_icon_128.png
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Standardize on the plugin icon (puzzle piece) as the default icon for
install dialogs and the management ui page.

Also changed the margins on the body to match the download page and
the history page so it doesn't look as bad when you switch between them.

TEST=Install an extension without an icon and you should see the puzzle
piece icon in the install dialog.
TEST=Open the chrome://extensions page and you should see the same icon
in the top left corner.
BUG=25906

Review URL: http://codereview.chromium.org/344014
------------------------------------------------------------------------
r30383 | jam@chromium.org | 2009-10-28 21:31:58 +0100 (Wed, 28 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h

First of several patches to get rid of MessageLoop caching now that we have ChromeThread::PostTask.

BUG=25354
Review URL: http://codereview.chromium.org/342020
------------------------------------------------------------------------
r30379 | kuchhal@chromium.org | 2009-10-28 21:12:08 +0100 (Wed, 28 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Cleanup a few FirstRun methods that are only applicable to Windows.

BUG=11971
TEST=No functional change. Make sure first-run/import still works on all three platforms.

Review URL: http://codereview.chromium.org/340020
------------------------------------------------------------------------
r30378 | jhawkins@chromium.org | 2009-10-28 20:51:21 +0100 (Wed, 28 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   A /trunk/src/chrome/app/theme/infobar_autofill.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/autofill
   A /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.cc
   A /trunk/src/chrome/browser/autofill/autofill_infobar_delegate.h
   A /trunk/src/chrome/browser/autofill/autofill_manager.cc
   A /trunk/src/chrome/browser/autofill/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add initial implementation of AutoFill++.  This implementation is hidden behind a switch, --enable-new-autofill.  So far, we only pop up an infobar asking the user if he'd like to save the form information.  I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/339030
------------------------------------------------------------------------
r30375 | tony@chromium.org | 2009-10-28 20:17:09 +0100 (Wed, 28 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Remove the non-const browser() getter from BrowserWindowGtk.

Review URL: http://codereview.chromium.org/347006
------------------------------------------------------------------------
r30373 | sky@chromium.org | 2009-10-28 20:14:53 +0100 (Wed, 28 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Changes bookmark html writer test to lookup string rather than hard
coding. I can't think of a good reason why we were hard coding it
before.

BUG=17592
TEST=none

Review URL: http://codereview.chromium.org/340009
------------------------------------------------------------------------
r30356 | finnur@chromium.org | 2009-10-28 18:37:44 +0100 (Wed, 28 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

The test is only failing on Mac, so lets just disabled it for Mac specifically so as to not lose test coverage on other platforms.

TBR=aa
BUG=26035
TEST=None

Review URL: http://codereview.chromium.org/343019
------------------------------------------------------------------------
r30355 | sky@chromium.org | 2009-10-28 18:20:06 +0100 (Wed, 28 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Changes ui proxy classes to use Browser::Types rather than copying
them.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343018
------------------------------------------------------------------------
r30346 | erikkay@chromium.org | 2009-10-28 17:18:21 +0100 (Wed, 28 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html

Constrain extension popups to a min/max size.
Also, fix some glitches in sizing the popups.

BUG=25214
TEST=ExtensionApiTest.BrowserActionPopup

Review URL: http://codereview.chromium.org/295051
------------------------------------------------------------------------
r30341 | skerner@chromium.org | 2009-10-28 16:08:35 +0100 (Wed, 28 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html
   M /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Issue 21729: Add new event chrome.tabs.onStatusChange .

BUG=21729
TEST= Manually tested that onUpdated sends all tab info.  Updated unit tests.
Review URL: http://codereview.chromium.org/289006
------------------------------------------------------------------------
r30339 | nsylvain@chromium.org | 2009-10-28 15:51:05 +0100 (Wed, 28 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Another flaky crashy test: ExtensionUpdaterTest.TestBlacklistUpdateCheckRequests

bug:26035
Review URL: http://codereview.chromium.org/338064
------------------------------------------------------------------------
r30338 | nsylvain@chromium.org | 2009-10-28 15:33:19 +0100 (Wed, 28 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Add a comment above the disabled test to say which bug
covers the issue.

Review URL: http://codereview.chromium.org/343017
------------------------------------------------------------------------
r30337 | thomasvl@chromium.org | 2009-10-28 15:27:37 +0100 (Wed, 28 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Allow sandbox logging to be set when invoking chrome and relayed to the renderers.

TEST=flag on browser causes logging from renderers.
BUG=none
Review URL: http://codereview.chromium.org/342017
------------------------------------------------------------------------
r30334 | mad@chromium.org | 2009-10-28 13:41:29 +0100 (Wed, 28 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc

Get rid of FilePath::AppendAndResolveRelative().

To resolve the problem of '..' parent references as well as symbolic links on POSIX platforms, we can simply use the file_util::AbsolutePath() function.

This has the drawback of having a different behavior on Windows and POSIX platforms, in the way that it can return a canonical path that doesn't exists when ran on Windows, but it will return an empty path (or false) when run on a POSIX platform.

So we need to add an extra PathExists() call to unify the behavior.

BUG=25681,25131 

Review URL: http://codereview.chromium.org/343003
------------------------------------------------------------------------
r30328 | ukai@chromium.org | 2009-10-28 09:53:41 +0100 (Wed, 28 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/net/websocket_experiment
   A /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
   A /trunk/src/chrome/browser/net/websocket_experiment/websocket_experiment_task.h
   M /trunk/src/chrome/chrome.gyp

WIP: websocket live experiment

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/333045
------------------------------------------------------------------------
r30326 | aa@chromium.org | 2009-10-28 08:43:17 +0100 (Wed, 28 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/README.txt
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html

Rename getTabContentses to getExtensionTabs.
The old name is also aliased for backwards compat.

This lands:
http://codereview.chromium.org/224012

BUG=21433

Review URL: http://codereview.chromium.org/339041
------------------------------------------------------------------------
r30325 | finnur@chromium.org | 2009-10-28 08:07:28 +0100 (Wed, 28 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Disable a test that frequently crashes on Mac 10.5 Tests (dbg) bot (and I've seen it crash on the try servers as well).

TBR=lzheng
BUG=26035
TEST=None

Review URL: http://codereview.chromium.org/338060
------------------------------------------------------------------------
r30324 | finnur@chromium.org | 2009-10-28 06:42:24 +0100 (Wed, 28 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Prep the management page for localization.

BUG=25947
TEST=Not easily testable until we have the strings localized.

Review URL: http://codereview.chromium.org/329039
------------------------------------------------------------------------
r30323 | rolandsteiner@chromium.org | 2009-10-28 06:40:09 +0100 (Wed, 28 Oct 2009) | 18 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc

Fix for bug 10876 that resulted in some refactoring:

The bug originates from extensions being treated case sensitive on Windows and Mac OSX, where they shouldn't be. 

Therefore I added generic static methods to FilePath to compare strings in the same way the file system does, and changed the relevant parts of the code to make use of them.
I tested the methods under Windows and Mac OS X. I also wrote a basic version for Linux/Posix that behaves the same way as the original code, so there should at least be no regression.

Also, while fixing this I found some confusion in the code about whether extensions are used with or without leading dot. For this reason I changed some functions that were taking an extension as parameter to instead take the whole file path. This makes calling these functions easier and the caller doesn't need to know whether the extension is supposed to be with or without dot.

In the same vein, I split DownloadManager::IsExecutable into IsExecutableFile, where one again passes in the whole file and doesn't have to worry about getting the extension right, and IsExecutableExtension, which corresponds to the original functionality. Ideally only the former method should be public, but that again would have required further code scrubbing that was (even more) outside of the original bug fix.

Finally, fixed a wrong comment in the file path tests.


BUG=10876
TEST=FilePathTest.MatchesExtension, .CompareIgnoreCase

Review URL: http://codereview.chromium.org/149796
------------------------------------------------------------------------
r30318 | chocobo@google.com | 2009-10-28 05:11:00 +0100 (Wed, 28 Oct 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/app/theme/statusbar_disconnected.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_1.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_2.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_3.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_4.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_5.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_6.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_7.png
   D /trunk/src/chrome/app/theme/statusbar_wifi_8.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_network_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_button.cc
   M /trunk/src/chrome/browser/chromeos/status_area_button.h

New wifi icons animation.
BUG=none
TEST=25538
Review URL: http://codereview.chromium.org/315008
------------------------------------------------------------------------
r30316 | estade@chromium.org | 2009-10-28 04:21:40 +0100 (Wed, 28 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc

GTK: touch up appearance of browser actions badge.

Also don't show empty browser action tooltips.

BUG=26023

Review URL: http://codereview.chromium.org/341016
------------------------------------------------------------------------
r30313 | tim@chromium.org | 2009-10-28 04:03:43 +0100 (Wed, 28 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   A /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.cc (from /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.cc:30161)
   A /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h (from /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h:30161)
   A /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc (from /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc:30161)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Take 2 at browser_sync::ExtensionsActivityMonitor.
Original: http://codereview.chromium.org/325001/show

TEST=ExtensionsActivityMonitorTest

Review URL: http://codereview.chromium.org/333041
------------------------------------------------------------------------
r30312 | aa@chromium.org | 2009-10-28 03:30:43 +0100 (Wed, 28 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/zip.cc
   M /trunk/src/chrome/common/zip.h
   M /trunk/src/chrome/common/zip_unittest.cc
   A /trunk/src/chrome/test/data/zip/test/foo/bar/.hidden
   M /trunk/src/chrome/test/data/zip/test.zip
   M /trunk/src/chrome/test/data/zip/test_nocompress.zip

Filter out hidden files, both when loading extensions and when
packaging them.

We also special case the common OS X zip dropping "__MACOSX" when
loading extensions.

BUG=23004

Review URL: http://codereview.chromium.org/340018
------------------------------------------------------------------------
r30310 | rafaelw@chromium.org | 2009-10-28 02:54:12 +0100 (Wed, 28 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Fix paint glitch on load/unload browser action.

This asks the toolbar (BrowserActionContainer.GetParent()) to paint when a browser action view has been added & removed.

TEST=Load browser action. Go to chrome://extensions, click "reload". The omnibar should visibly flash large & small as the browser action is loaded and unload, but it should not leave behind any visible "cruft" around the browser action.

BUG=24642

Review URL: http://codereview.chromium.org/341015
------------------------------------------------------------------------
r30303 | jam@chromium.org | 2009-10-28 02:12:59 +0100 (Wed, 28 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix the crashes in interactive_ui_tests on Linux.

The cause is really subtle.  When I added a db_thread() in BrowserMain, that changed the order that threads were created at.  Since interactive ui tests don't run atexitmanager (I filed a bug to make them do), this cascaded into file_posix.cc's InFlightIO singelton caching the first IO MessageLoop pointer.  By fluke, previously each IO ML would have the exact same pointer value (must be a unique size for the allocator).  My change modified the construction order, so the second run would have a different ChromeThread (file) get the previous IO thread's ML pointer.  That led to the asserts.  I have added code to start the threads in a predictable manner for now.

BUG=25354
TEST=interactive_ui_tests in Linux stop crashing
Review URL: http://codereview.chromium.org/340017
------------------------------------------------------------------------
r30302 | thestig@chromium.org | 2009-10-28 02:05:51 +0100 (Wed, 28 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

In ~BrowserToolbarGtk, remove notifications we added in the ctor.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/345002
------------------------------------------------------------------------
r30289 | mpcomplete@chromium.org | 2009-10-28 01:17:51 +0100 (Wed, 28 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc

Simple fix so the utility process respects single process mode.

BUG=24746

Review URL: http://codereview.chromium.org/339033
------------------------------------------------------------------------
r30286 | derat@chromium.org | 2009-10-28 01:00:49 +0100 (Wed, 28 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

GTK: Activate window when "Get themes" button is clicked.

This is a direct copy of the Views fix from r29949.

BUG=24866
TESTED=verified that minimized browser window gets restored under metacity

Review URL: http://codereview.chromium.org/334048
------------------------------------------------------------------------
r30282 | aa@chromium.org | 2009-10-28 00:29:49 +0100 (Wed, 28 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   D /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   D /trunk/src/chrome/browser/extensions/extension_l10n_util.h
   D /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   A /trunk/src/chrome/common/extensions/extension_l10n_util.cc (from /trunk/src/chrome/browser/extensions/extension_l10n_util.cc:30275)
   A /trunk/src/chrome/common/extensions/extension_l10n_util.h (from /trunk/src/chrome/browser/extensions/extension_l10n_util.h:30275)
   A /trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc (from /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc:30275)
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/utility/utility_main.cc

Fix bug where many extensions don't install due to sandbox.

FWIW, I tracked down why our tests didn't find this. We do
have coverage for the code path that was getting executed,
but the sandbox is disabled in our browser tests, so it did
not expose this issue.

BUG=25865
TEST=Install any extension that has a content script or icons (test/data/extensions/good.crx is one example). Go to chrome://extensions/. You should see the extension successfully installed.

Review URL: http://codereview.chromium.org/337041
------------------------------------------------------------------------
r30281 | sky@chromium.org | 2009-10-28 00:29:21 +0100 (Wed, 28 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/menu/menu_controller.cc

Lands http://codereview.chromium.org/291006 for Pierre:

Open all bookmarks in a bookmark menu folder according to the window disposition derived from the event flags. This is currently only possible with a middle click on the top level bookmark bar button. 

BUG=19597
TEST=Control click a folder on your bookmark bar, and thorougly test
bookmark bar, especially with folders.

Review URL: http://codereview.chromium.org/334047
------------------------------------------------------------------------
r30277 | piman@chromium.org | 2009-10-28 00:26:59 +0100 (Wed, 28 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters_posix.cc
   M /trunk/src/third_party/libjingle/files/talk/base/cryptstring.h
   M /trunk/src/third_party/libjingle/files/talk/base/host.cc
   M /trunk/src/third_party/libjingle/files/talk/base/natserver.cc
   M /trunk/src/third_party/libjingle/files/talk/base/natsocketfactory.cc
   M /trunk/src/third_party/libjingle/files/talk/base/socketadapters.cc
   M /trunk/src/third_party/libjingle/files/talk/base/stringencode.cc
   M /trunk/src/third_party/libjingle/files/talk/base/stringutils.h
   M /trunk/src/third_party/libjingle/files/talk/base/testclient.cc
   M /trunk/src/third_party/libjingle/files/talk/base/urlencode.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/port.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/relayport.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/stun.cc

linux: fix gcc 4.3 issues (for arm)

These are mostly minor syntax / missing header fixes.

Review URL: http://codereview.chromium.org/338037
------------------------------------------------------------------------
r30276 | davemoore@chromium.org | 2009-10-28 00:24:39 +0100 (Wed, 28 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Got the about panel to have its text lined up correctly.
Also added underline capability to linux fonts.

Review URL: http://codereview.chromium.org/338029
------------------------------------------------------------------------
r30272 | zork@chromium.org | 2009-10-27 23:49:23 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/single_client_live_bookmarks_sync_unittest.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/sync/test_http_bridge_factory.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Remove the browser_sync flag.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/337034
------------------------------------------------------------------------
r30269 | shess@chromium.org | 2009-10-27 23:35:51 +0100 (Tue, 27 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm

[Mac] Prevent using tab context menu after tab closed.

JavaScript can close windows while in the event loop processing a
right-click menu.  This change prevents sending messages to the tab
controller after it has been closed.

BUG=25462, 25465
TEST=See bug for test.html.
TEST=Run test.html, right-click tab, after close all items should be grayed out.
TEST=Run test.html, click tab's close button and hold until tab closes.  Should not crash on release.

Review URL: http://codereview.chromium.org/335048
------------------------------------------------------------------------
r30265 | evan@chromium.org | 2009-10-27 23:13:36 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

extensions: make the slidey animation fast

Personal crusade.

Review URL: http://codereview.chromium.org/344003
------------------------------------------------------------------------
r30259 | zork@chromium.org | 2009-10-27 22:49:40 +0100 (Tue, 27 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc

Run a Chrome message loop on the mediator thread, allowing certificates to be verified.

BUG=none
TEST= 1.  Enable bookmark syncing on a mac or linux build.
2.  Run chrome with --log-level=0.
3.  Options menu -> Sync my Bookmarks.  Log in.
4.  Check that "XmppSocketAdapter::OnConnectEvent - STATE_TLS_OPEN" appears in the output.

Review URL: http://codereview.chromium.org/340007
------------------------------------------------------------------------
r30255 | sky@chromium.org | 2009-10-27 22:43:53 +0100 (Tue, 27 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Take 2 at this. The only change between this and the first is to add the GetType message to the end of the list and to keep the old message for
creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored.

Makes session restore on Chrome OS restore popups.

BUG=18862
TEST=none

Review URL: http://codereview.chromium.org/329040
------------------------------------------------------------------------
r30249 | tony@chromium.org | 2009-10-27 22:33:23 +0100 (Tue, 27 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc

NewTabUITest.NTPHasThumbnails can be flakey if it takes more than
2 sec for the history results to be returned (displaying the
thumbnails).  Work around this by giving extra time to the test.

BUG=25949

Review URL: http://codereview.chromium.org/339029
------------------------------------------------------------------------
r30245 | pkasting@chromium.org | 2009-10-27 22:06:11 +0100 (Tue, 27 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Loosen RFC 1738 compliance check to allow underscores where we already allowed hyphens, to match real-world needs.

I don't believe further loosening will be required but that data will hopefully be coming soon.  In the meantime people are asking for this fix.

BUG=25714
TEST=Entring "a_b.com" in the omnibox should default to navigate, not search
Review URL: http://codereview.chromium.org/339017
------------------------------------------------------------------------
r30243 | mattm@chromium.org | 2009-10-27 21:58:46 +0100 (Tue, 27 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc

Coverity: Fix call to string->empty() that meant ->clear()

CID=127
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/304009
------------------------------------------------------------------------
r30240 | mark@chromium.org | 2009-10-27 21:44:57 +0100 (Tue, 27 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/keystone_glue.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Map update check failure to "update server not available."

BUG=25948
TEST=With a suitably recent KSR, mess up the update server URL in the ticket,
     and verify that the update status line in the About box shows the gray
     icon with "update server not available" after attempting to check for
     an update.
Review URL: http://codereview.chromium.org/344002
------------------------------------------------------------------------
r30234 | pkasting@chromium.org | 2009-10-27 20:22:38 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Remove dead variables.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/329030
------------------------------------------------------------------------
r30226 | estade@chromium.org | 2009-10-27 19:51:23 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

GTK: Draw floating bookmark bar correctly during resizes.

BUG=23907
TEST=Using ratchet + clank theme, go to NTP while bookmark bar is off so you see a floating bar. Maximize the window. It should look right.

Review URL: http://codereview.chromium.org/329022
------------------------------------------------------------------------
r30225 | estade@chromium.org | 2009-10-27 19:47:51 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h

Add "remember my choice" checkbox for windows external protocol dialog.

BUG=24085

Review URL: http://codereview.chromium.org/332039
------------------------------------------------------------------------
r30219 | rafaelw@chromium.org | 2009-10-27 19:03:22 +0100 (Tue, 27 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Further polish to extensions_ui page.

This changes the details text from gray to black. It also persists in the preferences the state of devMode (whether the developer tools are showing). Lastly, it adds a fade/slide effect on page elements which are shown in devMode.

BUG=25471

Review URL: http://codereview.chromium.org/329018
------------------------------------------------------------------------
r30218 | finnur@chromium.org | 2009-10-27 19:01:47 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Page action pixel-god appeasement (better positioning and spacing for the page action icons).

BUG=25708
TEST=Visual inspection. See bug.

Review URL: http://codereview.chromium.org/329028
------------------------------------------------------------------------
r30217 | cira@chromium.org | 2009-10-27 18:49:40 +0100 (Tue, 27 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc

Fixes bug introduced in r28333, where we were checking if path.empty() instead of !PathExists(path).
In addition makes background page load check.

BUG=24041
TEST=Try loading extension with content script that doesn't exist on disk, but is listed in manifest.

Review URL: http://codereview.chromium.org/335037
------------------------------------------------------------------------
r30216 | jrg@chromium.org | 2009-10-27 18:45:00 +0100 (Tue, 27 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Disable fullscreen for Mstone-4 / ReleaseBlock-Beta.

Review URL: http://codereview.chromium.org/341001
------------------------------------------------------------------------
r30215 | mark@chromium.org | 2009-10-27 18:38:49 +0100 (Tue, 27 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/keystone_glue.h
   M /trunk/src/chrome/app/keystone_glue.mm
   M /trunk/src/chrome/app/keystone_glue_unittest.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Make KeystoneGlue less antisocial.

Remove -clearRecentStatus which really tied KeystoneGlue too closely to
AboutWindowController.  If KeystoneGlue ever wound up with any other clients,
this relationship would have been harmful.  AboutWindowController now
maintains a static variable to handle what -clearRecentStatus had been used
for.

Remove -releaseDefaultKeystoneGlue, which was only intended to be used for
testing, as a workaround for test flake.  The test flake has been removed.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/333049
------------------------------------------------------------------------
r30214 | tony@chromium.org | 2009-10-27 18:22:17 +0100 (Tue, 27 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc

Changed button text in Edit Search Engine... dialog to conform
with GNOME HIG.

BUG=18076
TEST=Compile and see label

Original patch by Ramkumar Ramachandra <artagnon@gmail.com> at
http://codereview.chromium.org/338015/show

Review URL: http://codereview.chromium.org/333052
------------------------------------------------------------------------
r30210 | thakis@chromium.org | 2009-10-27 18:16:29 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Add TODOs.

BUG=TEST=none

Review URL: http://codereview.chromium.org/334029
------------------------------------------------------------------------
r30209 | thakis@chromium.org | 2009-10-27 18:07:06 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

[mac] Fix Cmd-w in the one-tab case.

BUG=25788
TEST=See bug

Review URL: http://codereview.chromium.org/337040
------------------------------------------------------------------------
r30207 | jrg@chromium.org | 2009-10-27 17:33:53 +0100 (Tue, 27 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm

CL which includes http://codereview.chromium.org/337006 for mrossetti
Also includes a unit test fix.
BUG=21908

TEST=Control-click on the bookmark bar, either on an existing folder
or on the blank area and choose "Add Folder..." from the contextual
menu. A sheet will drop down from the bookmark bar asking for the name
of the folder to add. The edit field will be populated with the
proposed name 'New folder'. ('New folder' will be appropriately
localized.)


Review URL: http://codereview.chromium.org/329031
------------------------------------------------------------------------
r30204 | sky@chromium.org | 2009-10-27 17:21:34 +0100 (Tue, 27 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Revert 30194 - Makes session restore on Chrome OS restore popups.

BUG=18862
TEST=none

Review URL: http://codereview.chromium.org/337030

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/335047
------------------------------------------------------------------------
r30196 | brettw@chromium.org | 2009-10-27 16:48:52 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Change the use-flip command line flag from wchar_t to char

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/338038
------------------------------------------------------------------------
r30194 | sky@chromium.org | 2009-10-27 16:31:13 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Makes session restore on Chrome OS restore popups.

BUG=18862
TEST=none

Review URL: http://codereview.chromium.org/337030
------------------------------------------------------------------------
r30193 | sky@chromium.org | 2009-10-27 16:26:36 +0100 (Tue, 27 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Nukes TabStrip::CanUpdateDisplay. This appears to be the culprit for a
couple of crashes we're getting.

BUG=24132, 13707
TEST=thorougly test tab dragging on windows and make sure there are no
regressions.

Review URL: http://codereview.chromium.org/337013
------------------------------------------------------------------------
r30190 | avi@chromium.org | 2009-10-27 15:22:01 +0100 (Tue, 27 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/chrome/browser/resources/about_memory.html
   M /trunk/src/chrome/browser/resources/about_stats.html
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/privacy_blacklist_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   M /trunk/src/chrome/browser/security/resources/ssl_error.html
   M /trunk/src/chrome/browser/security/resources/ssl_roadblock.html
   M /trunk/src/chrome/renderer/resources/error_no_details.html
   M /trunk/src/chrome/renderer/resources/neterror.html

Ensure that Helvetica, if installed, is used instead of Arial. This should be an effective defense against the Mac fontheads zombie uprising.

BUG=http://crbug.com/21458
TEST=navigate to any HTML-as-UI page (about:credits, etc) on a Mac; ensure Helvetica-ness


Review URL: http://codereview.chromium.org/333032
------------------------------------------------------------------------
r30179 | yurys@google.com | 2009-10-27 11:46:22 +0100 (Tue, 27 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/page_with_content_script.html
   M /trunk/src/chrome/test/ui_test_utils.cc

DevTools: fix and enable DevToolsExtensionDebugTest.TestContentScriptIsPresent.
Review URL: http://codereview.chromium.org/328029
------------------------------------------------------------------------
r30172 | aa@chromium.org | 2009-10-27 07:17:57 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   D /trunk/src/chrome/common/extensions/extension_action2.cc
   D /trunk/src/chrome/common/extensions/extension_action2.h
   D /trunk/src/chrome/common/extensions/extension_action2_unittest.cc
   A /trunk/src/chrome/common/extensions/extension_action_unittest.cc (from /trunk/src/chrome/common/extensions/extension_action2_unittest.cc:30171)
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Replace ExtensionAction with ExtensionAction2.

BUG=24472

Review URL: http://codereview.chromium.org/337035
------------------------------------------------------------------------
r30171 | ukai@chromium.org | 2009-10-27 07:09:33 +0100 (Tue, 27 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc

Fix browser crash on startup.

>	chrome.dll!`anonymous namespace'::OnNoMemory()  Line 126	C++
	chrome.dll!_invalid_parameter_noinfo()  Line 99 + 0xc bytes	C++
	chrome.dll!RefCountedBytes::front()  Line 67 + 0x1b bytes	C++
	chrome.dll!BookmarkModel::OnFavIconDataAvailable(int handle=8, bool know_favicon=true, scoped_refptr<RefCountedBytes> data={...}, bool expired=true, GURL icon_url={...})  Line 652 + 0x2b bytes	C++

It seems RefCountedBytes data has no data. If data size is 0, accessing front
of data would cause crash.
By checking its size, fixes this crash.

BUG=25803
TEST=no crash on startup

Review URL: http://codereview.chromium.org/328037
------------------------------------------------------------------------
r30170 | rolandsteiner@chromium.org | 2009-10-27 06:54:51 +0100 (Tue, 27 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc

Revert 30168 - Commit patch set from http://codereview.chromium.org/149796
(see discussion and history there)

BUG=10876
TEST=FilePathTest.MatchesExtension.CompareIgnoreCase


TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/337042
------------------------------------------------------------------------
r30169 | jam@chromium.org | 2009-10-27 06:27:41 +0100 (Tue, 27 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Attempt to make interactive ui tests complete on Linux while I try to repro it.
Review URL: http://codereview.chromium.org/333042
------------------------------------------------------------------------
r30168 | rolandsteiner@chromium.org | 2009-10-27 06:24:41 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc

Commit patch set from http://codereview.chromium.org/149796
(see discussion and history there)

BUG=10876
TEST=FilePathTest.MatchesExtension.CompareIgnoreCase

------------------------------------------------------------------------
r30165 | rvargas@google.com | 2009-10-27 05:46:32 +0100 (Tue, 27 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc

Http cache: Handle byte range requests when there is no cache entry.

BUG=25873
TEST=unittest


Review URL: http://codereview.chromium.org/330026
------------------------------------------------------------------------
r30164 | jam@chromium.org | 2009-10-27 05:34:31 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/synaptics_library.cc
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Fix compile failures in Chrome OS and Views builds.

TBR=darin
BUG=25354
Review URL: http://codereview.chromium.org/329033
------------------------------------------------------------------------
r30163 | jam@chromium.org | 2009-10-27 04:59:31 +0100 (Tue, 27 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_power_library.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/extensions/autoupdate_interceptor.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/file_reader.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details_linux.cc
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h
   M /trunk/src/chrome/browser/net/test_url_fetcher_factory.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/notifications/notification_object_proxy.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/power_save_blocker_common.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/file_system_accessor.cc
   M /trunk/src/chrome/browser/renderer_host/file_system_accessor_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc

Simplify threading in browser thread by making only ChromeThread deal with different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread.  If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching.  With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354
Review URL: http://codereview.chromium.org/306032
------------------------------------------------------------------------
r30162 | tim@chromium.org | 2009-10-27 04:33:44 +0100 (Tue, 27 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   D /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.cc
   D /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   D /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Revert (4 of 4) 30153 - Introduce browser_sync::ExtensionsActivityMonitor to collect extensions API usage
for correlation to sync commit requests.  Add ChromiumExtensionsActivity to sync.proto
to allow passing this data to sync servers.

BUG=25323
TEST=Added ExtensionsActivityMonitorTest. +Performing mutations on the bookmarks model via an extension should result in
ChromiumExtensionsActivity for each such extension showing up in CommitMessages.

Review URL: http://codereview.chromium.org/325001

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/333040
------------------------------------------------------------------------
r30160 | tim@chromium.org | 2009-10-27 04:30:43 +0100 (Tue, 27 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h

Revert (2 of 4) 30156 - Add newline to end of file to fix compile. again :(

TBR=nick

Review URL: http://codereview.chromium.org/333037

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/337039
------------------------------------------------------------------------
r30159 | tim@chromium.org | 2009-10-27 04:29:47 +0100 (Tue, 27 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc

Revert (1 of 4) 30157 - Add newline to end of another file.

TBR=nick

Review URL: http://codereview.chromium.org/333038

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/328036
------------------------------------------------------------------------
r30157 | tim@chromium.org | 2009-10-27 04:14:10 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc

Add newline to end of another file.

TBR=nick

Review URL: http://codereview.chromium.org/333038
------------------------------------------------------------------------
r30156 | tim@chromium.org | 2009-10-27 04:04:26 +0100 (Tue, 27 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h

Add newline to end of file to fix compile. again :(

TBR=nick

Review URL: http://codereview.chromium.org/333037
------------------------------------------------------------------------
r30153 | tim@chromium.org | 2009-10-27 03:42:17 +0100 (Tue, 27 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   A /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.cc
   A /trunk/src/chrome/browser/sync/util/extensions_activity_monitor.h
   A /trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Introduce browser_sync::ExtensionsActivityMonitor to collect extensions API usage
for correlation to sync commit requests.  Add ChromiumExtensionsActivity to sync.proto
to allow passing this data to sync servers.

BUG=25323
TEST=Added ExtensionsActivityMonitorTest. +Performing mutations on the bookmarks model via an extension should result in
ChromiumExtensionsActivity for each such extension showing up in CommitMessages.

Review URL: http://codereview.chromium.org/325001
------------------------------------------------------------------------
r30148 | vandebo@chromium.org | 2009-10-27 02:30:57 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

Make the memory resource functions return bools so that we know when the information is not available. Refactor TaskManager slightly.

BUG=23366
TEST=See "N/A" for memory usage in Linux task manager

Review URL: http://codereview.chromium.org/339012
------------------------------------------------------------------------
r30140 | jrg@chromium.org | 2009-10-27 01:40:53 +0100 (Tue, 27 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm

Reverting 30136.
Review URL: http://codereview.chromium.org/338032
------------------------------------------------------------------------
r30136 | jrg@chromium.org | 2009-10-27 01:15:57 +0100 (Tue, 27 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm

Landing http://codereview.chromium.org/337006 for mrossetti
BUG=21908

TEST=Control-click on the bookmark bar, either on an existing folder
or on the blank area and choose "Add Folder..." from the contextual
menu. A sheet will drop down from the bookmark bar asking for the name
of the folder to add. The edit field will be populated with the
proposed name 'New folder'. ('New folder' will be appropriately
localized.)

------------------------------------------------------------------------
r30135 | cmasone@google.com | 2009-10-27 01:13:48 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros_power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_power_library.h

cros: doing dbus stuff on the file thread==disaster.

libdbus-glib uses the glib main loop internally.  We were making calls on a background thread that wound up telling libdbus-glib to get a connection to the system bus on said background thread.  This led to a background thread trying to use the same glib main loop as Chrome's UI thread, and concurrency issues led to crashing.  Sadly, there can be only one main loop per process, as I understand it.

This code takes away the attempts to use the background thread.  As our interaction with dbus is semantically asynchronous, this seems ok to me. 
Review URL: http://codereview.chromium.org/339013
------------------------------------------------------------------------
r30133 | aa@chromium.org | 2009-10-27 01:10:52 +0100 (Tue, 27 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_action2.cc
   M /trunk/src/chrome/common/extensions/extension_action2.h
   M /trunk/src/chrome/common/extensions/extension_action2_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html
   A /trunk/src/chrome/test/data/extensions/samples/test_page_action/icon1.png
   A /trunk/src/chrome/test/data/extensions/samples/test_page_action/icon2.png
   M /trunk/src/chrome/test/data/extensions/samples/test_page_action/manifest.json
   D /trunk/src/chrome/test/data/extensions/samples/test_page_action/print_16x16.png

Move page actions over to ExtensionAction2 and get rid of
extension_action.*.

Final bit of refactor will be to rename ExtensionAction2 to
ExtensionAction will be the next CL.

BUG=24472,25844

Review URL: http://codereview.chromium.org/332021
------------------------------------------------------------------------
r30126 | dmaclach@chromium.org | 2009-10-27 00:40:22 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/extension_shelf_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/menu_button_unittest.mm

First set of unittest fixes. Many more to come ;-)

TEST=run the unittests and watch them pass.
BUG=none

Review URL: http://codereview.chromium.org/334016
------------------------------------------------------------------------
r30123 | zork@chromium.org | 2009-10-27 00:38:24 +0100 (Tue, 27 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/chrome.gyp

Add SSL wrapper for linux and mac.  This allows notifier to use chrome's SSL layer instead of OpenSSL.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/270074
------------------------------------------------------------------------
r30119 | oshima@chromium.org | 2009-10-26 23:40:39 +0100 (Mon, 26 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_extenders.cc

Fullscreen for ChromeOS with toolkit_views=1 build
 * show/hide chromeos components based on fullscreen status
 * added compact_navigation_bar_enabled_ flag to differentiate being in fullscreen and
   being disabled.

BUG=22805
TEST=Toggle fullscreen mode using F11. Try with/without compact navigation bar, which can be enabled by "shift-ctrl-0".

Review URL: http://codereview.chromium.org/332032
------------------------------------------------------------------------
r30117 | evan@chromium.org | 2009-10-26 23:39:33 +0100 (Mon, 26 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/installer/setup/setup_util_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/test/chrome_frame_test_utils.cc
   M /trunk/src/chrome_frame/test/net/process_singleton_subclass.cc
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/net/tools/dump_cache/dump_cache.cc

Remove deprecated CommandLine(std::wstring) ctor.

Add a ctor for creating a CommandLine for carrying arguments;
convert all the users to either that or the FilePath version.

BUG=24672

Review URL: http://codereview.chromium.org/329017
------------------------------------------------------------------------
r30113 | sky@chromium.org | 2009-10-26 23:21:42 +0100 (Mon, 26 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Makes inactive pinned tabs throb on views when the title changes.

BUG=25308
TEST=go to gmail, pin the tab, select another tab. Have someone IM you
     and make sure your gmail tab throbs.

Review URL: http://codereview.chromium.org/329021
------------------------------------------------------------------------
r30108 | thestig@chromium.org | 2009-10-26 23:05:35 +0100 (Mon, 26 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc

Add a check for NULL in PopulateFolderCombo.

BUG=25849
TEST=none
Review URL: http://codereview.chromium.org/335032
------------------------------------------------------------------------
r30106 | zork@chromium.org | 2009-10-26 22:49:35 +0100 (Mon, 26 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp

Resubmit http://codereview.chromium.org/314016 with views fixed
Review URL: http://codereview.chromium.org/338008
------------------------------------------------------------------------
r30100 | mark@chromium.org | 2009-10-26 22:33:32 +0100 (Mon, 26 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/keystone_glue.h
   M /trunk/src/chrome/app/keystone_glue.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm

Make the About box display existing pending operations instead of firing off
a new update check even when an existing update check or installation attempt
is in progress.

Remove the check that validates that the Update button is disabled after
being clicked.  This test has become very fragile now that the Update button
reliably enables itself as soon as an update installation attempt fails.

BUG=13165
TEST=Get the About box to offer you the opportunity to install an update.
     Click "Install Now".  Close the About box and quickly reopen it.  The
     update status should be "Installing new version..." and not "Checking
     for updates..."
Review URL: http://codereview.chromium.org/339010
------------------------------------------------------------------------
r30095 | dmaclach@chromium.org | 2009-10-26 22:22:14 +0100 (Mon, 26 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bubble_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/sad_tab_view_unittest.mm

Fixes up bookmark bubbles and the browser window so that they shut down correctly.
BookmarkBubbleController has been made an NSWindowController instead of the
view controller that it used to be, and now loads its window from the nib instead
of creating it on the fly. Also cleans up fullscreen mode so that the window
referenced from browser_window_controller stays constant instead of having
[self window] and window_ potentially pointing at two different windows.

BookmarkBubble.xib has been modified so that it instantiates a window containing
a bubble view instead of just instantiating a view.

BUG=25054
TEST=Try going in and out of full screen mode. Try bringing up a bookmark bubble by clicking on the star. Try creating a pile of windows and then quitting,
Review URL: http://codereview.chromium.org/333017
------------------------------------------------------------------------
r30092 | finnur@chromium.org | 2009-10-26 22:14:44 +0100 (Mon, 26 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Find-in-page should not ding while deleting characters.

BUG=18120
TEST=Open google.com, type Ctrl+F, type in garbage. Erase one letter at a time and there should be no beeping while you erase. Try it again, but this time use shift-delete to cut a few letters off the end. It should not ding. Now Copy the whole find string, press Esc, open Find again and on Paste it should not ding.

Review URL: http://codereview.chromium.org/338005
------------------------------------------------------------------------
r30091 | mark@chromium.org | 2009-10-26 22:13:21 +0100 (Mon, 26 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/cocoa/extension_install_prompt.mm
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/chrome.gyp

o Cleans up canonical extension_install_ui.cc to avoid #ifdefs when feasible.
o Adds Cocoa implementation of the extension installation prompt.
o Added new cross-platform implementations of the extension install error prompt.
o Got rid of unused extension install strings from early implementations.
o Added a string to display as the header of the error dialog, since it was inline English.

Patch by Andrew Bonventre <andybons@gmail.com>

BUG=19654
TEST=Install an extension on any platform, observe consistent visual behavior and messaging.
Review URL: http://codereview.chromium.org/333015
------------------------------------------------------------------------
r30088 | derat@chromium.org | 2009-10-26 21:51:08 +0100 (Mon, 26 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

GTK: Fix browser action bubble arrow positions.

This also cleans up some of the InfoBubbleGtk code a bit.

BUG=23373
TEST=tested LTR and RTL under metacity

Review URL: http://codereview.chromium.org/332022
------------------------------------------------------------------------
r30087 | phajdan.jr@chromium.org | 2009-10-26 21:40:42 +0100 (Mon, 26 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

Mark flaky tests as flaky:

BookmarkHTMLWriterTest.Test (suspected resource flakiness)
LoginPromptTest.TestTwoAuths

TEST=none
BUG=17592, 25794

Review URL: http://codereview.chromium.org/332024
------------------------------------------------------------------------
r30086 | ojan@chromium.org | 2009-10-26 21:36:29 +0100 (Mon, 26 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Mark DOMStorageTest.SessionStorageLayoutTests as flaky.

BUT=24145
Review URL: http://codereview.chromium.org/338024
------------------------------------------------------------------------
r30082 | oshima@chromium.org | 2009-10-26 21:21:05 +0100 (Mon, 26 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/chromeos_browser_extenders.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/standard_extender.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/test_browser_window.h

CompactNavigationBar for toolkit views build, with some design change per Cole's request.
 * Swapped the positions of entry field and navigation buttons.
 * Hide navigation buttions when the entry field gains focus.
   - To implement this, I added OnKillFocus in AutocompleteEditController, and updated
     corresponding files.
 * Added accelerator (shift-ctrl-0) to toggle compact navigation bar
Changes to BrowserExtender
 * Made all virtual methods in BrowserExtender pure virtual.
 * Added HideToolbar method to control visibility of toolbar from Extender.

Review URL: http://codereview.chromium.org/329009
------------------------------------------------------------------------
r30078 | mark@chromium.org | 2009-10-26 20:58:13 +0100 (Mon, 26 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/worker_pool_mac.h
   M /trunk/src/base/worker_pool_mac.mm
   M /trunk/src/chrome/app/keystone_glue.h
   M /trunk/src/chrome/app/keystone_glue.mm
   M /trunk/src/chrome/app/keystone_glue_unittest.mm
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/restart_browser.mm

About box auto-update improvements.

The About box now knows how to check to see if updates have been installed
in the background without anyone having to click the Update button in the box.

The About box no longer gets stuck in the "installed" state.  Even if an
update has been installed, the About box will still check for new updates when
reopened.

BUG=13165, 20488
TEST=Play with the about box and auto-update a whole lot
Review URL: http://codereview.chromium.org/338012
------------------------------------------------------------------------
r30074 | johnnyg@chromium.org | 2009-10-26 20:32:52 +0100 (Mon, 26 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Refactor widget methods to support desktop notifications, including GTK stubs.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/307030
------------------------------------------------------------------------
r30073 | oshima@chromium.org | 2009-10-26 20:32:35 +0100 (Mon, 26 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix fullscreen mode in chromeos=1 build.
* added member vars for main menu and compact navbar
* show/hide main menu/compact navbar/status area upon fullscreen mode change.

I'll work on linux_views as well.

BUG=22805
TEST=Create new window from compact navbar menu, and toggle full screen mode

Review URL: http://codereview.chromium.org/332027
------------------------------------------------------------------------
r30071 | shess@chromium.org | 2009-10-26 20:13:08 +0100 (Mon, 26 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Adjust Omnibox implementation to not break undo chain.

This does not fix undo, it just makes the implementation break it
less.

BUG=18084
TEST=Omnibox should continue to work.

Review URL: http://codereview.chromium.org/337027
------------------------------------------------------------------------
r30069 | aa@chromium.org | 2009-10-26 20:09:15 +0100 (Mon, 26 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix crash when a page action cannot load its icon.

This can happen legitmately if the icon has been moved or
corrupted on disk.

I think we are hitting it too frequently for that to be the
whole explanation, but since this code is moving around a
lot shortly, it seems prudent to put in the quick fix and
worry about what's really going on post-refactor.

BUG=25601
TEST=Remove an extension's page action icon from its folder after installation. Should not crash when attempting to show page action.

Review URL: http://codereview.chromium.org/339005
------------------------------------------------------------------------
r30068 | glen@chromium.org | 2009-10-26 19:35:39 +0100 (Mon, 26 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Reverting 30062.
Review URL: http://codereview.chromium.org/338022
------------------------------------------------------------------------
r30063 | eroman@chromium.org | 2009-10-26 18:59:51 +0100 (Mon, 26 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h

Refactor: Change the interface from HostResolver::DisableIPv6() to HostResolver::SetDefaultAddressFamily(), to make it more general.

This came up in a codereview comment, but was after I had checked in.

Review URL: http://codereview.chromium.org/303026
------------------------------------------------------------------------
r30062 | ben@chromium.org | 2009-10-26 18:59:02 +0100 (Mon, 26 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Lazily create the find bar.

http://crbug.com/21910
TEST=none

Review URL: http://codereview.chromium.org/334019
------------------------------------------------------------------------
r30059 | viettrungluu@chromium.org | 2009-10-26 18:18:31 +0100 (Mon, 26 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: Make Cmd-[ and Cmd-] work properly again.

I had accidentally made them open new tabs. I added a |-commandDispatchUsingKeyModifiers:| method to the browser window controller and made the back/forward buttons send this selector instead (this is how Toolbar.xib was changed).

[N.B.: As of this writing, Cmd+Shift-back/forwards is broken, but that's a separate, non-Mac-specific, issue.]

BUG=25810
TEST=Make sure Cmd-[ and Cmd-] work as expected (not opening history items in new tabs). Make sure back and forward buttons work properly (including while holding down Cmd and Cmd+Shift).

Review URL: http://codereview.chromium.org/333026
------------------------------------------------------------------------
r30058 | erg@google.com | 2009-10-26 18:14:27 +0100 (Mon, 26 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h

Only double the buffer when AsyncResourceHandler's caller fill the buffer.

This is an update to r29904 and came out of a discussion with Darin.

BUG=http://crbug.com/24493
TEST=NONE

Review URL: http://codereview.chromium.org/335010
------------------------------------------------------------------------
r30050 | creis@chromium.org | 2009-10-26 16:55:46 +0100 (Mon, 26 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/click-noreferrer-links.html (from /trunk/src/chrome/test/data/click-noreferrer-links.html:29794)
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Second attempt to swap processes on rel=noreferrer, target=blank links.

The test timed out on one of the bots last time.  This change tries to fix that, and it breaks down the test into multiple tests to isolate the problem in case it isn't fixed.

No changes to code outside the test and the test HTML file.  Previous review at http://codereview.chromium.org/284015.

BUG=24447
TEST=RenderViewHostManagerTest.*SwapProcess*

Review URL: http://codereview.chromium.org/328017
------------------------------------------------------------------------
r30049 | sky@chromium.org | 2009-10-26 16:35:13 +0100 (Mon, 26 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_delegate.h
   M /trunk/src/views/controls/menu/menu_host_gtk.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.h
   M /trunk/src/views/controls/menu/menu_host_win.cc
   M /trunk/src/views/controls/menu/menu_host_win.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/screen.h
   M /trunk/src/views/screen_gtk.cc
   M /trunk/src/views/screen_win.cc

Makes it so that when a folder is open on the bookmark bar and the
mouse moves over another folder, the menu for that folder is shown.

BUG=355
TEST=thorougly test all possible permutations of bookmark menus you
     can think of, including drag and drop to the menus.

Review URL: http://codereview.chromium.org/328012
------------------------------------------------------------------------
r30048 | viettrungluu@chromium.org | 2009-10-26 16:13:06 +0100 (Mon, 26 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Mac: Make middle-click tab closure cancellable.

When middle-clicking a tab to close it, one should be able to move the mouse off
the tab before releasing to cancel it.

BUG=16019
TEST=Get a 3-button mouse. Make sure middle-clicking tabs to close them still works. Make sure moving the mouse off the tab before releasing the button cancels.

Review URL: http://codereview.chromium.org/333021
------------------------------------------------------------------------
r30037 | viettrungluu@chromium.org | 2009-10-26 07:08:57 +0100 (Mon, 26 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: Fix (window modal) sheet placement when bookmark bar is present.

BUG=25754
TEST=Check placement of (window modal) sheets (e.g., Open File...) with various combinations of the following: NTP/non-NTP, bookmark bar active/not active, infobar present/not present, and also download bar present/not present.

Review URL: http://codereview.chromium.org/337019
------------------------------------------------------------------------
r30033 | viettrungluu@chromium.org | 2009-10-26 05:53:43 +0100 (Mon, 26 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/base_view.mm

Mac: Make status bubbles pop properly when mouse leaves content area.

We hadn't set up our tracking area (in BaseView) to send mouse enter/exits.

BUG=22199
TEST=Get a page with lots of links which upon resizing can be made to abut the left edge (e.g., <http://www.nytimes.com/>), and resize/scroll to make it so; hover over a link to show status bubble; move mouse off the window, staying on the same link until off the window. The status bubble should then fade away.

Review URL: http://codereview.chromium.org/337016
------------------------------------------------------------------------
r30032 | thakis@chromium.org | 2009-10-26 05:40:12 +0100 (Mon, 26 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Do not send some keyboard shortcuts to the renderers

Walking the whole menu on every keypress seems ridiculous. Linux does this too :-/ (Caching is made hard because the user can change key equivalents in system preferences at every point in time, and we're not notified of that. And people only hit max 5 keys/second, so it's not all that ridiculous).

There's a UI test for this, but the interactive UI tests are not enabled on OS X, so it's not executed.

Menu walking code based on code from CocoatechCore.

BUG=5496,15090,24877
TEST=Go to http://unixpapa.com/js/testkey.html , check "keydown", focus the textbox, and make sure that cmd-t still opens tabs, cmd-shift-[ still switches tabs, cmd-w still closes tabs. however, cmd-L should not focus url bar and cmd-1 should not go to the first tab.

Review URL: http://codereview.chromium.org/273032
------------------------------------------------------------------------
r30030 | thakis@chromium.org | 2009-10-26 04:23:04 +0100 (Mon, 26 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/nsmenuitem_additions.h
   A /trunk/src/chrome/browser/cocoa/nsmenuitem_additions.mm
   A /trunk/src/chrome/browser/cocoa/nsmenuitem_additions_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add a function that can check if a menu item would be fired by a keypress.

BUG=Needed for a CL that I'm writing for 15090.
TEST=Unittest included.

Review URL: http://codereview.chromium.org/319001
------------------------------------------------------------------------
r30029 | ben@chromium.org | 2009-10-26 03:41:14 +0100 (Mon, 26 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Fix regression where popups and app frames lost their titlebars.

TBR=pkasting
http://crbug.com/25784
TEST=open any popup window or app frame, should have title bar to drag window.

Review URL: http://codereview.chromium.org/328026
------------------------------------------------------------------------
r30021 | nsylvain@chromium.org | 2009-10-25 02:33:58 +0200 (Sun, 25 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Disable ExtensionApiTest.Storage because it crashes the browser_tests too.

BUG:25746

Review URL: http://codereview.chromium.org/328024
------------------------------------------------------------------------
r30019 | nsylvain@chromium.org | 2009-10-25 02:09:49 +0200 (Sun, 25 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc

Disable ExtensionApiTest.BrowserActionPopup because it crashes on the bot.

BUG: 25746
Review URL: http://codereview.chromium.org/330012
------------------------------------------------------------------------
r30018 | mdm@chromium.org | 2009-10-25 00:57:17 +0200 (Sun, 25 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

Fix the proxy host and port string to start with http:// if it does not already.
BUG=21218
TEST=none

Review URL: http://codereview.chromium.org/235030
------------------------------------------------------------------------
r30016 | viettrungluu@chromium.org | 2009-10-24 23:37:16 +0200 (Sat, 24 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: implement dispositions for back/forward buttons (not in drop-downs).

That is, holding Cmd while pressing back/forward will open in a new background tab and holding Cmd+Shift will open in a new foreground tab. Theoretically, it can support holding Shift to open in a new window, but Browser::GoBack()/GoForward() doesn't support this disposition (due to a technical "limitation" of the implementation?).

This does *not* implement dispositions in the drop-down menus.

BUG=25319
TEST=Navigate to build up some history. Then press back/forward while holding down Cmd or Cmd+Shift.

Review URL: http://codereview.chromium.org/330002
------------------------------------------------------------------------
r30012 | thakis@chromium.org | 2009-10-24 21:06:31 +0200 (Sat, 24 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Fix compile on Snow Leopard.

BUG=TEST=phajdan

Review URL: http://codereview.chromium.org/333023
------------------------------------------------------------------------
r29997 | aa@chromium.org | 2009-10-24 06:35:08 +0200 (Sat, 24 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   A /trunk/src/chrome/common/extensions/extension_action2.cc
   A /trunk/src/chrome/common/extensions/extension_action2.h
   A /trunk/src/chrome/common/extensions/extension_action2_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/manifest.json

Refactor BrowserActions, and add support for
tab-specific state.

Future changelists will move Page Actions over to
ExtensionAction2, then replace ExtensionAction and
ExtensionActionState with ExtensionAction2.

Also, fix a bug in setIcon({path:...}) where it
would work only the first time.

BUG=24669,24472

Review URL: http://codereview.chromium.org/306044
------------------------------------------------------------------------
r29995 | dumi@chromium.org | 2009-10-24 05:46:14 +0200 (Sat, 24 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Enable HTML5 databases for all extension renderer processes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/330010
------------------------------------------------------------------------
r29992 | derat@chromium.org | 2009-10-24 05:19:13 +0200 (Sat, 24 Oct 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Try to position info bubbles onscreen.

I didn't go so far as to add support for arrows-on-the-bottom
in this change; I'm just making the bubble extend left or right
as needed.  I'll add a parameter to specify the default arrow
location (needed for browser action popups) in another CL.

Tested by:
- dragging a window to the right edge of the screen and
  confirming that bookmark bubbles open extended to the left
- opening a bookmark bubble, using a little X program to move
  the Chrome window to the right side of the screen (can't drag
  it there since the pointer is grabbed), and confirming that
  the bubble gets updated to extend to the left
- running in Arabic and confirming that bubbles extend to the
  left by default but get switched to extend to the right as
  needed

BUG=23373
TEST=see above

Review URL: http://codereview.chromium.org/316006
------------------------------------------------------------------------
r29991 | evan@chromium.org | 2009-10-24 04:13:43 +0200 (Sat, 24 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_gtk.cc

linux: nuke a NOTIMPLEMENTED

Review URL: http://codereview.chromium.org/333020
------------------------------------------------------------------------
r29990 | thakis@chromium.org | 2009-10-24 04:01:08 +0200 (Sat, 24 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Make bookmark bar primitive drag destination.

Credits for the bookmark bar fix to dmac; stolen from http://codereview.chromium.org/267082 .

BUG=18289
TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29906
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29908

Review URL: http://codereview.chromium.org/336001
------------------------------------------------------------------------
r29988 | rafaelw@chromium.org | 2009-10-24 03:33:51 +0200 (Sat, 24 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Increase visual spacing between browser action buttons to 5px.

BUG=25444

Review URL: http://codereview.chromium.org/316019
------------------------------------------------------------------------
r29987 | rafaelw@chromium.org | 2009-10-24 03:30:17 +0200 (Sat, 24 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html

Fix ExtensionApiTest.PageAction & Enable test on linux

TBR=mpcomplete

Review URL: http://codereview.chromium.org/337015
------------------------------------------------------------------------
r29985 | pkasting@chromium.org | 2009-10-24 03:28:39 +0200 (Sat, 24 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/db_message_filter.h
   M /trunk/src/webkit/database/vfs_backend.cc
   M /trunk/src/webkit/database/vfs_backend.h

Clean up database files.  Some changes are due to Google style guide violations, some to be consistent with prevailing team style, some merely in hopes of increasing readability.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/330007
------------------------------------------------------------------------
r29979 | viettrungluu@chromium.org | 2009-10-24 02:33:09 +0200 (Sat, 24 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm

Mac: remove some now-dead code and add a comment.

I slightly jumped the gun on committing CL 328010, and this patch does some things requested in a review.

BUG=23825
TEST=none

Review URL: http://codereview.chromium.org/326024
------------------------------------------------------------------------
r29978 | derat@chromium.org | 2009-10-24 02:27:52 +0200 (Sat, 24 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Compute infobubble target rects correctly.

I misunderstood how allocations work in the original
version and wasn't handling the case where there are
intermediate GdkWindows between the target widget and
its toplevel window correctly.

TEST=first-run, bookmark, and browser action bubbles get opened in the correct places under xmonad, metacity, and ion3
BUG=23373

Review URL: http://codereview.chromium.org/326017
------------------------------------------------------------------------
r29977 | rafaelw@chromium.org | 2009-10-24 02:27:45 +0200 (Sat, 24 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/pageAction.html

Remove pageAction setXXXBadge functions.

This only removes the binding to the functions, not their implementation, as we may want to bring back badges for pageActions if we can make them look good.

BUG=25552

Review URL: http://codereview.chromium.org/329001
------------------------------------------------------------------------
r29971 | estade@chromium.org | 2009-10-24 01:09:50 +0200 (Sat, 24 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix chromeos build break due to out-of-order member initialization.

TBR=ojan

Review URL: http://codereview.chromium.org/337008
------------------------------------------------------------------------
r29969 | glen@chromium.org | 2009-10-24 00:45:37 +0200 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp

Reverting 29961.
Review URL: http://codereview.chromium.org/328016
------------------------------------------------------------------------
r29968 | ojan@chromium.org | 2009-10-24 00:45:08 +0200 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Um, do the disable right. TBR.
Review URL: http://codereview.chromium.org/328015
------------------------------------------------------------------------
r29966 | ojan@chromium.org | 2009-10-24 00:37:17 +0200 (Sat, 24 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc

Disable test failing since r29947. 

TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/338006
------------------------------------------------------------------------
r29964 | estade@chromium.org | 2009-10-24 00:30:29 +0200 (Sat, 24 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Add the Extensinos menu item to GTK.

Also change windows so that it always shows the Extensions menu item, but greys it out if it's disabled.

BUG=25424

Review URL: http://codereview.chromium.org/316017
------------------------------------------------------------------------
r29963 | estade@chromium.org | 2009-10-24 00:29:21 +0200 (Sat, 24 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Fix startup UMR.

The bookmark bar calls IsFullScreen() during startup, which queries state_.

I checked to see if relying on a dummy value would get us into trouble with some crazy corner case where we are in the wrong floating state---it doesn't appear to.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/328014
------------------------------------------------------------------------
r29961 | zork@chromium.org | 2009-10-24 00:25:59 +0200 (Sat, 24 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp

Build sync by default on all platforms.  This also turns off sync on both Linux and Mac, so that even though the code is compiled, it won't run.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/314016
------------------------------------------------------------------------
r29957 | stuartmorgan@chromium.org | 2009-10-24 00:16:39 +0200 (Sat, 24 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc

Switch from plugin to browser process only when all windows close (Mac)

Whenever a plugin-opened window is closed, check for other visible windows and only reactive the browser process if there aren't any.

BUG=23566
TEST=Press command-shift-G on a plugin-opened open dialog, then dismiss the sheet. The open dialog should stay visible and active.

Review URL: http://codereview.chromium.org/328013
------------------------------------------------------------------------
r29954 | viettrungluu@chromium.org | 2009-10-24 00:08:26 +0200 (Sat, 24 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/safari_importer.mm

Mac: don't import Safari's home page setting.

Apparently it often leads to a useless home page. I kept the ImportHomepage() method in case we ever change our minds.

BUG=25603
TEST=Set the home page in Safari to something interesting; run Chromium with --first-run to bring up import dialog; select Safari and continue; make sure home page isn't imported.

Review URL: http://codereview.chromium.org/328010
------------------------------------------------------------------------
r29949 | ben@chromium.org | 2009-10-23 23:47:53 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Make it so that clicking the "Get Themes" link in the options dialog box activates the browser window that the themes gallery is opened in.

http://crbug.com/24866
TEST=see bug

Review URL: http://codereview.chromium.org/308013
------------------------------------------------------------------------
r29945 | pkasting@chromium.org | 2009-10-23 23:23:53 +0200 (Fri, 23 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/test/testing_profile.h

Add functions to purge the Web Database memory and get the service without creating it, for the memory purger.

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/326014
------------------------------------------------------------------------
r29943 | davemoore@chromium.org | 2009-10-23 23:11:14 +0200 (Fri, 23 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/views/controls/label.cc

Get the About panel to align its links correctly,
but undo a previous change to the way we measure strings in pango.

Review URL: http://codereview.chromium.org/338001
------------------------------------------------------------------------
r29935 | finnur@chromium.org | 2009-10-23 22:09:34 +0200 (Fri, 23 Oct 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/app/theme/extensions_favicon.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Switching to a plugin icon as the favicon for the extensions page.

TBR=arv
BUG=25509
TEST=Open the extensions page and it should have a plugin as it's favicon.

Review URL: http://codereview.chromium.org/329012
------------------------------------------------------------------------
r29934 | brettw@chromium.org | 2009-10-23 22:00:20 +0200 (Fri, 23 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/json
   A /trunk/src/base/json/json_reader.cc (from /trunk/src/base/json_reader.cc:29787)
   A /trunk/src/base/json/json_reader.h (from /trunk/src/base/json_reader.h:29787)
   A /trunk/src/base/json/json_reader_unittest.cc (from /trunk/src/base/json_reader_unittest.cc:29787)
   A /trunk/src/base/json/json_writer.cc (from /trunk/src/base/json_writer.cc:29787)
   A /trunk/src/base/json/json_writer.h (from /trunk/src/base/json_writer.h:29787)
   A /trunk/src/base/json/json_writer_unittest.cc (from /trunk/src/base/json_writer_unittest.cc:29787)
   A /trunk/src/base/json/string_escape.cc (from /trunk/src/base/string_escape.cc:29787)
   A /trunk/src/base/json/string_escape.h (from /trunk/src/base/string_escape.h:29787)
   A /trunk/src/base/json/string_escape_unittest.cc (from /trunk/src/base/string_escape_unittest.cc:29787)
   D /trunk/src/base/json_reader.cc
   D /trunk/src/base/json_reader.h
   D /trunk/src/base/json_reader_unittest.cc
   D /trunk/src/base/json_writer.cc
   D /trunk/src/base/json_writer.h
   D /trunk/src/base/json_writer_unittest.cc
   D /trunk/src/base/string_escape.cc
   D /trunk/src/base/string_escape.h
   D /trunk/src/base/string_escape_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/common/json_value_serializer.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/sandbox_mac.mm
   M /trunk/src/chrome/common/web_resource/web_resource_unpacker.cc
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/ipc/ipc_message_utils.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/strict_transport_security_state.cc

Move the json-related files into a separate json directory. This hopefully also
makes the naming of string_escape more clear (it's actually JSON-specific).
Move the files into the base namespace.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/316016
------------------------------------------------------------------------
r29930 | chron@chromium.org | 2009-10-23 21:48:23 +0200 (Fri, 23 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncer_status.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h

Hook up "remaining changes" to sync client. Remove "latest timestamp".
TEST=manually tested
BUG=19993
Review URL: http://codereview.chromium.org/295052
------------------------------------------------------------------------
r29929 | cevans@chromium.org | 2009-10-23 21:42:02 +0200 (Fri, 23 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Submitting on behalf of jschuh@
See http://codereview.chromium.org/326012

Check word lengths before adding to dictionary and spellchecking.

TBR=brettw
BUG=20469
TEST=None

Review URL: http://codereview.chromium.org/332012
------------------------------------------------------------------------
r29928 | dmaclach@chromium.org | 2009-10-23 21:41:04 +0200 (Fri, 23 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_view_unittest.mm

Basic test class that is going to replace CocoaTestHelper and CocoaNoWindowTestHelper.
Is responsible for bootstrapping cocoa and verifying that all windows are
closed down correctly between tests. Also includes a macro for doing some
very repetitive view testing that we had multiple copies of. I included a single
changed over test so that you can see the difference.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/327010
------------------------------------------------------------------------
r29922 | finnur@chromium.org | 2009-10-23 21:20:28 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/extensions_favicon.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h

Adding a favicon for the Extensions page.

BUG=25509
TEST=Open the extensions page and its tab should have an icon.

Review URL: http://codereview.chromium.org/332009
------------------------------------------------------------------------
r29919 | joi@chromium.org | 2009-10-23 21:16:20 +0200 (Fri, 23 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome_frame/chrome_frame_activex.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/chrome_frame_npapi_unittest.cc
   M /trunk/src/chrome_frame/chrome_frame_plugin.h
   M /trunk/src/chrome_frame/chrome_tab.idl
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc

Enhance extension UI testing by enabling you to select which extension
APIs to forward (and thus stub out in your test), while others will
keep being fulfilled as per usual.  This lets you build tests that
stub out one piece of behavior while testing that some side effects of
another API happen as expected.

BUG=none
TEST=Run ui_tests.exe

Review URL: http://codereview.chromium.org/314015
------------------------------------------------------------------------
r29917 | pkasting@chromium.org | 2009-10-23 21:03:16 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc

Fix linux build failures.  Not sure why these didn't fail before.

TBR=maruel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/338003
------------------------------------------------------------------------
r29915 | pkasting@chromium.org | 2009-10-23 20:47:09 +0200 (Fri, 23 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_data_service_win.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/webkit/glue/form_field_values.h

Remove some #includes where possible.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/335002
------------------------------------------------------------------------
r29913 | jhawkins@chromium.org | 2009-10-23 20:31:32 +0200 (Fri, 23 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/form_field_history_manager.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   A /trunk/src/webkit/glue/form_field.cc
   A /trunk/src/webkit/glue/form_field.h
   M /trunk/src/webkit/glue/form_field_values.cc
   M /trunk/src/webkit/glue/form_field_values.h
   M /trunk/src/webkit/webkit.gyp

Break out FormFieldValues::Element into FormField, which will eventually hold more autofill data about each form field.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306061
------------------------------------------------------------------------
r29911 | mpcomplete@chromium.org | 2009-10-23 20:25:58 +0200 (Fri, 23 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/connect
   A /trunk/src/chrome/test/data/extensions/api_test/connect/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/connect/page.js
   A /trunk/src/chrome/test/data/extensions/api_test/connect/test.html
   D /trunk/src/chrome/test/data/extensions/api_test/connect_external/connect.html
   A /trunk/src/chrome/test/data/extensions/api_test/connect_external/test.html

Implement extension.sendRequest, a simpler way to do messaging.

BUG=23865

Review URL: http://codereview.chromium.org/320009
------------------------------------------------------------------------
r29910 | shess@chromium.org | 2009-10-23 20:24:43 +0200 (Fri, 23 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm

[Mac] Fix keyword editor-related crashes

* Adjust the edit buttons after adding a new keyword.
* Don't make NSPointerArray calls which cause exceptions.

Patch from rsesek@chromium.org http://codereview.chromium.org/262028

BUG=23350, 22545
TEST=Preferences-->Manage. Add a search engine. Click "Make Default", delete it ("-)". Crash.

Review URL: http://codereview.chromium.org/319006
------------------------------------------------------------------------
r29908 | thakis@chromium.org | 2009-10-23 20:08:53 +0200 (Fri, 23 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm

TBR: nsylvain

Revert
------------------------------------------------------------------------
r29906 | thakis@chromium.org | 2009-10-23 19:51:35 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm

[Mac] Make bookmark bar primitive drag destination.

BUG=18289
TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar.

Review URL: http://codereview.chromium.org/336001
------------------------------------------------------------------------
r29904 | erg@google.com | 2009-10-23 19:39:53 +0200 (Fri, 23 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h

When sending resources across the IPC barrier, use increasing sized buffers.

AsyncResourceHandler::OnWillRead will usually allocate a new piece of shared
memory for each 32 kilobyte chunk of a resource to be sent over IPC from the
browser to the renderer. Instead, use a 32k chunk, then a 64k chunk, then a
128k chunk up to a maximum size of 512k.

Why? Because transferring large resources is really slow. To send a sequence of
32k chunks to the renderer, we need to wait for the renderer to send an ACK
message back before we send the next chunk.

The themeing on the new tab page is a pathological case for this code. Most of
the background images are large, and my test case is about 800k. This was 25
round trips. Now it is 5. According to the web inspector, it used to take ~700ms to transfer said image. Now
it's in the ~30ms range. It feels faster, and the web inspector shows the speed up, but tab_complex_theme_cold does not...

BUG=http://crbug.com/24493
TEST=Doesn't regress any performance tests.

Review URL: http://codereview.chromium.org/331001
------------------------------------------------------------------------
r29903 | sky@chromium.org | 2009-10-23 19:19:03 +0200 (Fri, 23 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/app/throb_animation.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Makes inactive pinned tabs on linux throb when the title changes. I
need to resolve with Glen/Nicholas how to handle the windows side.

BUG=25308
TEST=none

Review URL: http://codereview.chromium.org/314010
------------------------------------------------------------------------
r29900 | wtc@chromium.org | 2009-10-23 18:58:37 +0200 (Fri, 23 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/x509_user_cert_resource_handler.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   A /trunk/src/net/base/cert_database.h
   A /trunk/src/net/base/cert_database_mac.cc
   A /trunk/src/net/base/cert_database_nss.cc
   A /trunk/src/net/base/cert_database_win.cc
   A /trunk/src/net/base/keygen_handler.h
   A /trunk/src/net/base/keygen_handler_mac.cc
   A /trunk/src/net/base/keygen_handler_nss.cc
   A /trunk/src/net/base/keygen_handler_win.cc
   M /trunk/src/net/base/mime_util.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/webkit/api/public/WebKitClient.h
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h

Adds support for the <keygen> tag for client certificate enrollment
under Linux. Currently, no notifications are given to the user that the
certificate was successfully enrolled.

Patch by Gaurav Shah <gauravsh@chromium.org> of Google.
Original review URL: http://codereview.chromium.org/261035

BUG=148
TEST=Can test on the following sites:
http://foaf.me/simple_KEYGEN_CreateClientCertificate.php
http://www.myopenid.com
Review URL: http://codereview.chromium.org/271112
------------------------------------------------------------------------
r29896 | shess@chromium.org | 2009-10-23 18:10:31 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm

[Mac] Make sure that Cocoa knows Omnibox field draws with transparency.

http://crbug.com/24745
TEST=Should not have transparent ring around omnibox in popup windows.

Review URL: http://codereview.chromium.org/304005
------------------------------------------------------------------------
r29895 | ananta@chromium.org | 2009-10-23 18:09:41 +0200 (Fri, 23 Oct 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/net/http/http_util.cc
   M /trunk/src/net/http/http_util.h
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc

Fixes ChromeFrame net tests which run the URLRequest unit tests by launching IE and having it issue
the corresponding HTTP requests via automation. Fixes as below:-

1. The DefaultAcceptCharset and DefaultAcceptLanguage tests were failing because the URL request automation
   job would only read the extra headers from the request. These tests set these headers in the URLRequestContext.
   We needed to mimic the functionality in the URLRequestHttpJob to add in these headers if they were not
   already present. As part of this I moved the AppendHeaderIfMissing function from url_request_http_job.cc
   to HttpUtil as it is needed by the automation job as well.

2. The OverrideAcceptLanguage and OverrideAcceptCharset tests started failing in chrome frame net tests
   after the fixes to get the default versions of these tests to pass. These tests basically pass in the
   Accept-Language and Accept-Charset headers and expect the same values to be echoed back. IE ends up
   caching the responses from the default versions of these tests and thus echoes back the old response
   which causes these tests to fail. I tried passing in the no-cache header from our HTTP server for
   the EchoHeader tests but this did not work. To fix this we now pass in the echoheaderoverride
   parameter for the OverrideAcceptLanguage and OverrideAcceptCharset tests. The HTTP server has been
   updated to support this.

3. NotifyDone can be called on the job if the original request was redirected. Added a check for whether
   NotifyDone was already called on the job in URLRequestAutomationJob

Review URL: http://codereview.chromium.org/322004
------------------------------------------------------------------------
r29891 | viettrungluu@chromium.org | 2009-10-23 16:43:55 +0200 (Fri, 23 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/extension_shelf_controller.mm

Coding style fix: "if(" => "if (".

(One of the changes was pointed out to me by pinkerton in a too-late drive-by a
while back.)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/327011
------------------------------------------------------------------------
r29884 | eroman@chromium.org | 2009-10-23 09:39:21 +0200 (Fri, 23 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc

Fix compile bustage on chromeos builder.

This is fallout from r29880.

TBR=darin
BUG=22294

Review URL: http://codereview.chromium.org/328006
------------------------------------------------------------------------
r29882 | ben@chromium.org | 2009-10-23 09:12:26 +0200 (Fri, 23 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/app/gfx/insets.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Make sure the RootView is sized to the correct bounds when the opaque frame is maximized.It seems that now, when an opaque frame is maximized we also need to add the SM_CXSIZEFRAME to the top of the client rect. I don't know why, it's just is.I reworked the way Widget allows subclasses to handle sizing of the RootView... I delegate responsibility for determining the RootView's bounds to a helper virtual function which BrowserFrameWin overrides. This seems cleaner to me. I make sure this handling only occurs when the window is not maximized.http://crbug.com/25227TEST=use to a theme or switch off glass on vista or use Xp. Maximize the browser window. The tabs should be entirely visible.
Review URL: http://codereview.chromium.org/304007
------------------------------------------------------------------------
r29880 | eroman@chromium.org | 2009-10-23 08:33:31 +0200 (Fri, 23 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/cookies_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   A /trunk/src/chrome/browser/net/url_request_context_getter.cc
   A /trunk/src/chrome/browser/net/url_request_context_getter.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Move initialization of ChromeURLRequestContexts to the IO thread.

Before, these URLRequestContexts were lazily created from the UI thread. Unfortunately that model made it easy for consumers on the UI thread to poke at stuff which was being used from the IO thread, and introduce races.

So instead of providing a URLRequestContext*, the Profile now vends a URLRequestContextGetter*. 

The consequence of this is:

* Consumers on the UI thread can no longer get access to a URLRequestContext.
* Consumers on the IO thread need to call URLRequestContextGetter::GetURLRequestContext() to get at the context. This uses the same style lazy-creation of URLRequestContexts, albeit from the IO thread.

OK, so now the smelly part:

There were a couple of consumers of URLRequestContext on the UI thread that can't easily be moved to the IO thread -- these are the consumers of the cookie store. Before they could happily mess with the cookie store from the UI thread, and this was fine since CookieStore is threadsafe. However under the new model, they have no way to get at the URLRequestContext from the UI thread, hence can't get a pointer to the cookie store.

To support that use-cases, I bastardized the API some by adding a URLRequestContextGetter::GetCookieStore() method that lets UI thread consumers get a pointer to the cookie store, since we know this particular cross-thread usage is safe.

BUG=http://crbug.com/22294

Review URL: http://codereview.chromium.org/258008
------------------------------------------------------------------------
r29879 | thakis@chromium.org | 2009-10-23 08:19:44 +0200 (Fri, 23 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Fix build.

TBR: nsylvain
------------------------------------------------------------------------
r29877 | thakis@chromium.org | 2009-10-23 08:11:09 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Make user shortcuts override built-in shortcuts.

BUG=25330
TEST=Open sysprefs, keyboard, keyboard shortcuts, add a keyboard shortcut that makes cmd-right do "Select Next Tab". Hit cmd-right in chromium. Should switch tabs instead of doing history navigation (note "instead". If it does both tab switching _and_ history navigation, that's wrong). If a text box is focussed, cmd-right should however instead move the cursor and not switch tabs. Switching windows with cmd-` should still work. Switching tabs with cmd-1/2/3 and cmd-{/} should still work. Using backspace/shift-backspace for history should still work.

Review URL: http://codereview.chromium.org/325004
------------------------------------------------------------------------
r29875 | finnur@chromium.org | 2009-10-23 06:44:34 +0200 (Fri, 23 Oct 2009) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/background.html
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/chrome-16.png
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/manifest.json
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/script.js

Readding from scratch instead reverting the revert.

It kept eating the files I added, so I recreated
the changelist from scratch using the raw patch 
downloaded from Rietveld.

TBR=mpcomplete

Original description:

We changed the page action manifest from
 'icon' -> 'default_icon'
and now allow extensions to programmatically
specifying an icon. However, page actions that
hard-coded an icon using the 'icon' tag in the
manifest (don't show an icon programmatically)
now lose their icons. This causes a crash when we
try to display the icon in the LocationBarView.

We now check when the extension tries to enable
the page action whether there are any icons to
display. If not, we don't proceed and log an
error to the console.

BUG=25562
TEST=Covered by browser test.

Review URL: http://codereview.chromium.org/334005
------------------------------------------------------------------------
r29873 | mark@chromium.org | 2009-10-23 06:18:05 +0200 (Fri, 23 Oct 2009) | 17 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   A /trunk/src/chrome/browser/power_save_blocker.h
   A /trunk/src/chrome/browser/power_save_blocker_common.cc
   A /trunk/src/chrome/browser/power_save_blocker_stub.cc
   A /trunk/src/chrome/browser/power_save_blocker_win.cc
   M /trunk/src/chrome/chrome.gyp

Disable system suspend while downloading files on win32.

If the system goes into power-save sleep mode while downloading files,
the download fails. So, prevent sleep mode until the download finishes.

This patch introduces a new RAII class to request that the system's
power-save mode be disabled - PowerSaveBlocker.
This is only implemented for win32; other platforms are stubbed out.

This only partially implements bug 25420 it only attempts to handle the
downloading case.

Patch by Bryan Donlan <bdonlan@gmail.com>

BUG=25420
TEST=Download a large file with the system sleep timeout set to a short interval.
Review URL: http://codereview.chromium.org/287017
------------------------------------------------------------------------
r29871 | finnur@chromium.org | 2009-10-23 06:02:02 +0200 (Fri, 23 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc

This test is flaky, it has failed multiple times on the Linux
interactive dbg bot tonight.

TBR=erg
BUG=25614
TEST=none

Review URL: http://codereview.chromium.org/332004
------------------------------------------------------------------------
r29868 | rohitrao@chromium.org | 2009-10-23 05:22:23 +0200 (Fri, 23 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

[Mac] Remove flicker when typing in the findbar.

BUG=http://crbug.com/25590
TEST=No flicker when typing in findbar.
Review URL: http://codereview.chromium.org/333007
------------------------------------------------------------------------
r29867 | finnur@chromium.org | 2009-10-23 05:01:47 +0200 (Fri, 23 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   D /trunk/src/chrome/test/data/extensions/browsertest/crash_25562

Revert 29861 since this fail on the interactive
linux dbg bot, for some weird reason...

Page actions that don't specify an icon (ie.
have a spelling error in the manifest, such as
icon instead of icons/default_icon) caused a
crash when they try to display their icon.

We now check when the extension tries to enable
the page action whether there are any icons to
display. If not, we don't proceed and log an
error to the console.

TBR=nsylvain
BUG=25562
TEST=Covered by browser test.
Review URL: http://codereview.chromium.org/316018

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/327007
------------------------------------------------------------------------
r29866 | suzhe@chromium.org | 2009-10-23 04:52:06 +0200 (Fri, 23 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/base/keyboard_code_conversion_gtk.cc
   M /trunk/src/base/keyboard_code_conversion_gtk.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   A /trunk/src/chrome/browser/browser_keyevents_browsertest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/keyevents_test.html
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi
   M /trunk/src/chrome/test/ui_test_utils.h
   A /trunk/src/chrome/test/ui_test_utils_linux.cc
   A /trunk/src/chrome/test/ui_test_utils_mac.cc
   A /trunk/src/chrome/test/ui_test_utils_win.cc

Implements tests for testing browser's overall key events handling behavior.

This CL implements some basic tests for testing browser's overall key events handling behavior. This CL depends on http://codereview.chromium.org/235039 and http://codereview.chromium.org/195062. Currently, only Linux and Windows are supported.
The tests assume US keyboard layout is used and no IME is activated. We still need to investigate how to write tests that involving different keyboard layout and input methods.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/268035
------------------------------------------------------------------------
r29861 | finnur@chromium.org | 2009-10-23 04:12:34 +0200 (Fri, 23 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/background.html
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/chrome-16.png
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/manifest.json
   A /trunk/src/chrome/test/data/extensions/browsertest/crash_25562/script.js

Page actions that don't specify an icon (ie.
have a spelling error in the manifest, such as
icon instead of icons/default_icon) caused a
crash when they try to display their icon.

We now check when the extension tries to enable
the page action whether there are any icons to
display. If not, we don't proceed and log an
error to the console.

BUG=25562
TEST=Covered by browser test.
Review URL: http://codereview.chromium.org/316018
------------------------------------------------------------------------
r29860 | mattm@chromium.org | 2009-10-23 03:51:33 +0200 (Fri, 23 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/common/gtk_tree.cc
   M /trunk/src/chrome/common/gtk_tree.h

Linux: fix crash in PopulateCookieDetails called by OnSelectionChanged callback
which can be called while the view and model are in inconsistent states.

BUG=25535
TEST=open cookies manager, select all, remove all

Review URL: http://codereview.chromium.org/334001
------------------------------------------------------------------------
r29857 | suzhe@chromium.org | 2009-10-23 03:15:33 +0200 (Fri, 23 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h

Fix conflicts between accelerator keys and HTML DOM accesskeys.

This CL fixes conflicts between accelerator keys and HTML DOM accesskeys by suppressing Char events if corresponding RawKeyDown event was handled by the browser after returning from the renderer unhandled.

This CL not only fixes this conflict issue, but also makes the behavior of handling accelerator keys similar than IE, which also suppresses a key press event if the key down event was handled as an accelerator key.

BUG=21624 accesskey attributes conflict with browser shortcuts (like tab-switching)
TEST=Open http://djmitche.github.com/buildbot/docs/0.7.11/ in one of opened multiple tabs, switch to another tab by pressing an alt-# key binding, then switch back to the original page to see if it's just as you left it before switching tabs.

Review URL: http://codereview.chromium.org/235039
------------------------------------------------------------------------
r29854 | jcampan@chromium.org | 2009-10-23 03:02:38 +0200 (Fri, 23 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h

The TableViewObserver::OnKeyDown method signature was changed recently and
the bookmark manager view had not been properly updated and was not called
anymore, breaking the keyboard shortcuts.
This was broken in the TaskManager as well.

Also changed the TreeView to use the base::KeyboardCode.

BUG=25533
TEST=Test that the different shortcuts (CTRL-X,CTRL-V, CTRL-C, DELETE,
     ENTER...) work in the bookmark manager.
     Test that in the TaskManager, pressing ENTER activates the selected tab.

Review URL: http://codereview.chromium.org/322006
------------------------------------------------------------------------
r29853 | nsylvain@chromium.org | 2009-10-23 02:59:56 +0200 (Fri, 23 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm

Revert 29844 - Disable the Web drop target unittests because they
keep crashing.

BUg=25586

Review URL: http://codereview.chromium.org/330001

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/327004
------------------------------------------------------------------------
r29850 | mattm@chromium.org | 2009-10-23 02:47:51 +0200 (Fri, 23 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

[GTK] Use gtk_window_present_with_time since the doc's says it is better to use
it when it is a response to a user action.

BUG=None
TEST=compiled and tested.

Review URL: http://codereview.chromium.org/299001
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r29847 | nsylvain@chromium.org | 2009-10-23 02:22:57 +0200 (Fri, 23 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Revert 29827 - Refactor securityicon code to a more general form, also more consistent with
the Windows implementation, in preparation for implementing page actions.

BUG=14899, 22922, 12281
TEST=unit tests included

Review URL: http://codereview.chromium.org/264037

TBR=pamg@google.com
Review URL: http://codereview.chromium.org/333002
------------------------------------------------------------------------
r29844 | nsylvain@chromium.org | 2009-10-23 02:06:15 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm

Disable the Web drop target unittests because they
keep crashing.

BUg=25586

Review URL: http://codereview.chromium.org/330001
------------------------------------------------------------------------
r29837 | estade@chromium.org | 2009-10-23 01:43:59 +0200 (Fri, 23 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc

GTK: in gtk theme mode, when a chrome button is showing a menu, make it look depressed.

BUG=21053
TEST=app menu

Review URL: http://codereview.chromium.org/328001
------------------------------------------------------------------------
r29836 | oshima@chromium.org | 2009-10-23 01:41:24 +0200 (Fri, 23 Oct 2009) | 13 lines
Changed paths:
   D /trunk/src/chrome/browser/chromeos/browser_extender.cc
   D /trunk/src/chrome/browser/chromeos/browser_extender.h
   A /trunk/src/chrome/browser/chromeos/chromeos_browser_extenders.cc (from /trunk/src/chrome/browser/chromeos/browser_extender.cc:29830)
   A /trunk/src/chrome/browser/chromeos/panel_controller.cc (from /trunk/src/chrome/browser/views/panel_controller.cc:29830)
   A /trunk/src/chrome/browser/chromeos/panel_controller.h (from /trunk/src/chrome/browser/views/panel_controller.h:29830)
   A /trunk/src/chrome/browser/chromeos/panels
   A /trunk/src/chrome/browser/chromeos/panels/panel_scroller.cc (from /trunk/src/chrome/browser/views/panels/panel_scroller.cc:29830)
   A /trunk/src/chrome/browser/chromeos/panels/panel_scroller.h (from /trunk/src/chrome/browser/views/panels/panel_scroller.h:29830)
   A /trunk/src/chrome/browser/chromeos/panels/panel_scroller_container.cc (from /trunk/src/chrome/browser/views/panels/panel_scroller_container.cc:29830)
   A /trunk/src/chrome/browser/chromeos/panels/panel_scroller_container.h (from /trunk/src/chrome/browser/views/panels/panel_scroller_container.h:29830)
   A /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.cc (from /trunk/src/chrome/browser/views/panels/panel_scroller_header.cc:29830)
   A /trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.h (from /trunk/src/chrome/browser/views/panels/panel_scroller_header.h:29830)
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/views/frame/browser_extender.cc
   A /trunk/src/chrome/browser/views/frame/browser_extender.h (from /trunk/src/chrome/browser/chromeos/browser_extender.h:29830)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/frame/standard_extender.cc
   D /trunk/src/chrome/browser/views/panel_controller.cc
   D /trunk/src/chrome/browser/views/panel_controller.h
   D /trunk/src/chrome/browser/views/panels/panel_scroller.cc
   D /trunk/src/chrome/browser/views/panels/panel_scroller.h
   D /trunk/src/chrome/browser/views/panels/panel_scroller_container.cc
   D /trunk/src/chrome/browser/views/panels/panel_scroller_container.h
   D /trunk/src/chrome/browser/views/panels/panel_scroller_header.cc
   D /trunk/src/chrome/browser/views/panels/panel_scroller_header.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/chrome.gyp

* Moved panel controller to chromeos directory
* Include BrowserExtender to regular build to remove CHROMEOS ifdefs in BrowserView
 * moved browser_extender.h to chrome/browser/views/frame, and BrowserExtender methods
   to chrome/browser/views/frame/browser_extender.cc.
 * Added StandardExtender (standard_extender.cc), which is empty now. I'm going to add MainMenu support to win,
   which will be added vua StandardExtender with a command line flag.
 * factory method "Create" is now defined in standard_extender.cc and chromeos/chromeos_browser_extenders.cc.
   toolkit_views=1 uses chromeos_browser_extenders.cc and other build uses standard_extender

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/317001
------------------------------------------------------------------------
r29832 | brettw@chromium.org | 2009-10-23 01:06:12 +0200 (Fri, 23 Oct 2009) | 24 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/base/i18n/file_util_icu.cc
   M /trunk/src/base/i18n/file_util_icu.h
   M /trunk/src/base/i18n/file_util_icu_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printing_context_win.cc
   M /trunk/src/webkit/glue/weburlloader_impl.cc

Do some cleanup of file path name handling.

This started trying to cleanup DownloadManager::GenerateFilename which asserts
if your system locale isn't UTF-8 (I ran into this when mine got messed up).
The solution is to have GetSuggestedFilename return a FilePath rather than
calling FromWStringHack.

The rest of the patch is a result of trying to write GetSuggestedFilename in a
reasonable way. I changed ReplaceIllegalCharacters to work on a
FilePath::StringType.

Some places in the code calling these functions got cleaner, some got messier.
I think overall the ones that got messier are the ones doing sketchy things
with paths and the ones that got cleaner are the ones doing things more
properly.

The only code here that gets called a nontrivial number of times is the
weburlloader, and I think the new code does about the same number of string
conversions overall (though on certain platforms the number will be higher or
lower).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/271056
------------------------------------------------------------------------
r29830 | xiyuan@chromium.org | 2009-10-23 00:13:35 +0200 (Fri, 23 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Fix for issue 18228.

Don't record browser history for navigations for tabs in app frame.

BUG=18228
TEST=Open chrome in app frame (via "-app", application shortcut or convert a page to app), navigations in app frame should not appear in history.

Review URL: http://codereview.chromium.org/306052
------------------------------------------------------------------------
r29827 | pamg@google.com | 2009-10-23 00:01:07 +0200 (Fri, 23 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Refactor security-icon code to a more general form, also more consistent with
the Windows implementation, in preparation for implementing page actions.

BUG=14899, 22922, 12281
TEST=unit tests included

Review URL: http://codereview.chromium.org/264037
------------------------------------------------------------------------
r29824 | rafaelw@chromium.org | 2009-10-22 23:37:59 +0200 (Thu, 22 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Support for chrome.browserAction.setIcon(imageData) on linux.

This updates BrowserActionButton so it picks up the icon from the extension->browser_action_state().

Review URL: http://codereview.chromium.org/300027
------------------------------------------------------------------------
r29820 | pinkerton@chromium.org | 2009-10-22 23:15:36 +0200 (Thu, 22 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkNameFolder.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm

Ensure OK is only enabled when there is text in the text field for folders and items (whitespace is ok).
BUG=19558
TEST=per bug, test existing folders and new folders alike.
Review URL: http://codereview.chromium.org/292046
------------------------------------------------------------------------
r29819 | zork@chromium.org | 2009-10-22 23:09:48 +0200 (Thu, 22 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Fix profile_sync_service_unittest.cc to build on Mac and Linux

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/307011
------------------------------------------------------------------------
r29818 | gregoryd@google.com | 2009-10-22 23:04:15 +0200 (Thu, 22 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/test/nacl/nacl_test.cc

After recent changes (handle passing and RNG) Native Client tests run successfully in the sandbox.
Review URL: http://codereview.chromium.org/316011
------------------------------------------------------------------------
r29816 | estade@chromium.org | 2009-10-22 22:57:13 +0200 (Thu, 22 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Fix a couple gtk file chooser crashers.

BUG=25493
BUG=25490

Review URL: http://codereview.chromium.org/324002
------------------------------------------------------------------------
r29815 | cira@chromium.org | 2009-10-22 22:56:18 +0200 (Thu, 22 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.h
   M /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc

Loading local resources uses improved fallback algorithm.

Before:
 _locales/current_locale/rel_path, then extension root/rel_path

Now:
 _locales/{current_locale, parents}/rel_path, then extension root/rel_path

This change syncs local resource loading with catalog loading algo.

BUG=12131

Review URL: http://codereview.chromium.org/316013
------------------------------------------------------------------------
r29810 | evan@chromium.org | 2009-10-22 22:38:35 +0200 (Thu, 22 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Remove old migration code, as users should have been migrated by now.

BUG=24450

Review URL: http://codereview.chromium.org/292055
------------------------------------------------------------------------
r29808 | estade@chromium.org | 2009-10-22 22:20:15 +0200 (Thu, 22 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Check for null in bookmark bar drag received handler

BUG=25491

Review URL: http://codereview.chromium.org/324003
------------------------------------------------------------------------
r29807 | oshima@chromium.org | 2009-10-22 22:15:05 +0200 (Thu, 22 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extender.cc
   M /trunk/src/chrome/browser/chromeos/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_wrapper.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h
   M /trunk/src/views/window/window_gtk.cc

Enable System Context Menu for linux views.
 * Chagned WindowGtk to pass through right click mouse event for
    HTCAPTION so that ContextMenuController on Frame/Tab view works.
 * Added ContetMenuController to NonClientView.
 * Added "PointIsWithinWindowCaption to BrowserView to exclude chromeos specific components from Caption area.
Fix a minor bug in NonClientView
 * GetViewForPoint was using wrong point. This wasn't causing any issue as the frame_view's origin was (0, 0)

BUG=None
TEST=run chromeos build and right click frame view and verify that you get system menu.

Review URL: http://codereview.chromium.org/303014
------------------------------------------------------------------------
r29806 | jam@chromium.org | 2009-10-22 22:12:51 +0200 (Thu, 22 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc

Fix renderer hang if plugin process crashes while initializing a plugin.

BUG=25104
Review URL: http://codereview.chromium.org/315012
------------------------------------------------------------------------
r29798 | johnnyg@chromium.org | 2009-10-22 21:49:08 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Adjust flakiness settings to match the adjustments I made to the tests.

TBR=jorlow
BUG=none
TEST=these

Review URL: http://codereview.chromium.org/307044
------------------------------------------------------------------------
r29797 | mark@chromium.org | 2009-10-22 21:34:25 +0200 (Thu, 22 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp

A few more #ifdefs for platform-specific behaviors to port this test to mac.

Haven't tested outside of mac yet, so the guard for GetSafeFilename is still present for linux. Trybot should be run to make sure it passed in Win.

BUG=21632
TEST=none

Review URL: http://codereview.chromium.org/296001
------------------------------------------------------------------------
r29795 | johnnyg@chromium.org | 2009-10-22 21:03:43 +0200 (Thu, 22 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   D /trunk/src/chrome/test/data/click-noreferrer-links.html
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Reverting 29783.
Review URL: http://codereview.chromium.org/306055
------------------------------------------------------------------------
r29794 | johnnyg@chromium.org | 2009-10-22 20:46:33 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Webkit roll 49926:49941

BUG=none
TEST=none
TBR=tc,jorlow

Review URL: http://codereview.chromium.org/314011
------------------------------------------------------------------------
r29785 | estade@chromium.org | 2009-10-22 20:00:57 +0200 (Thu, 22 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   A /trunk/src/chrome/browser/gtk/extension_popup_gtk.cc
   A /trunk/src/chrome/browser/gtk/extension_popup_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

GTK: add browser actions popups.

Also add a new notification that tells the popup to close.

BUG=23897
TEST=--load-extension=chrome/test/data/extensions/samples/buildbot
TEST=--load-extension=chrome/test/data/extensions/samples/set_page_color

Review URL: http://codereview.chromium.org/314008
------------------------------------------------------------------------
r29784 | pinkerton@chromium.org | 2009-10-22 19:59:08 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Hook up the browser in the bookmark editor. Adjust the logic controlling the OK button enabling. 

In the BookmarkEditor.xib: Connect the NSBrowser's delegate (showing the bookmark tree) to the File's Owner (BookmarkEditorController). 
Patch from Mike Rossetti (mrosseti@chromium.org)
Original review at: http://codereview.chromium.org/287014
BUG=17613
TEST=none
------------------------------------------------------------------------
r29783 | creis@google.com | 2009-10-22 19:53:25 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/click-noreferrer-links.html
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Swaps renderer processes on links with rel=noreferrer and target=_blank.

We now detect these types of navigations in RenderView and allow the browser process to handle them.  This allows us to swap process if the navigation is cross-site.  Requires exposing suppressOpenerInNewFrame in WebFrame to accurately detect these links.

BUG=24447
TEST=RenderViewHostManagerTest.SwapProcessOnRelNoreferrerWithTargetBlank
Review URL: http://codereview.chromium.org/284015
------------------------------------------------------------------------
r29782 | gregoryd@google.com | 2009-10-22 19:42:32 +0200 (Thu, 22 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_process.cc

Add support for IMC handle passing in Chrome sandbox

Review URL: http://codereview.chromium.org/292056
------------------------------------------------------------------------
r29780 | erg@google.com | 2009-10-22 19:36:17 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/app/gfx/codec/png_codec.cc
   M /trunk/src/app/gfx/codec/png_codec.h
   M /trunk/src/app/gfx/codec/png_codec_unittest.cc
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Make PNGCodec::Decode(...) not make an intermediary copy of the decoded data;
instead have it write directly to the returned SkBitmap.

BUG=http://crbug.com/24493
TEST=Perf should get better. On the perf trybot, tab_complex_theme_cold got an average of ~40ms better.

Review URL: http://codereview.chromium.org/305001
------------------------------------------------------------------------
r29778 | sky@chromium.org | 2009-10-22 18:56:52 +0200 (Thu, 22 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Lands http://codereview.chromium.org/306039 for Sean:

Adding support for constrained dialogs with toolkit_views.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/322002
------------------------------------------------------------------------
r29776 | jcampan@chromium.org | 2009-10-22 18:20:27 +0200 (Thu, 22 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

The detached bookmark bar should not show on interstitials.

BUG=22060
TEST=See bug.

Review URL: http://codereview.chromium.org/306019
------------------------------------------------------------------------
r29773 | gwilson@google.com | 2009-10-22 17:29:33 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Changes the initialization of enabling the reporting metrics to initialize from registry settings first, rather than defaulting to Local State.

R=cpu,kuchhal
TEST=Turn on usagestats in options, close chrome, set usagestats off in registry, restart and verify it is turned OFF in options.
BUG=7547

Review URL: http://codereview.chromium.org/295035
------------------------------------------------------------------------
r29754 | nsylvain@chromium.org | 2009-10-22 04:21:01 +0200 (Thu, 22 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/api/public/WebKit.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebKit.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Revert 29747 - Switch over to the new way of enabling/disabling session/local storage.

BUG=none
TEST=|'localStorage' in window| should only be true iff enablelocalstorage
     is specified

Review URL: http://codereview.chromium.org/293032

TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/315009
------------------------------------------------------------------------
r29751 | finnur@chromium.org | 2009-10-22 04:09:29 +0200 (Thu, 22 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Minor adjustments to the fonts on the management page (less squished and more like the mocks).

BUG=12119
TEST=chrome://extensions page should look more like the screenshot in the bug.

Review URL: http://codereview.chromium.org/303028
------------------------------------------------------------------------
r29747 | jorlow@chromium.org | 2009-10-22 03:24:43 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/api/public/WebKit.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebKit.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Switch over to the new way of enabling/disabling session/local storage.

BUG=none
TEST=|'localStorage' in window| should only be true iff --enable-local-storage
     is specified

Review URL: http://codereview.chromium.org/293032
------------------------------------------------------------------------
r29744 | viettrungluu@chromium.org | 2009-10-22 02:36:18 +0200 (Thu, 22 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Mac: Enable help when there are no windows.

BUG=23825
TEST=Close all browser windows. Check that Help->Chromium Help (or Google Chrome Help) is enabled and works correctly.

Review URL: http://codereview.chromium.org/303030
------------------------------------------------------------------------
r29743 | rohitrao@chromium.org | 2009-10-22 02:35:53 +0200 (Thu, 22 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Cmd-Return in the omnibox should revert the omnibox text back to its original state.

BUG=23514
TEST=Type a URL into the omnibox, then Cmd-Return.  The omnibox text should revert to its original state.
Review URL: http://codereview.chromium.org/260008
------------------------------------------------------------------------
r29741 | mbelshe@google.com | 2009-10-22 01:52:07 +0200 (Thu, 22 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/net/flip/flip_framer.h
   M /trunk/src/net/flip/flip_session.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h

Expand the options for how FLIP runs.  The GFE team needs
the ability to run a client with ssl & compression turned off.
Update the command line to accomodate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/315006
------------------------------------------------------------------------
r29727 | shess@chromium.org | 2009-10-22 01:06:57 +0200 (Thu, 22 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Simplify field editor code which tracks whether editor rect changed.

Previous code used an elaborate system of checks, which was gradually
becoming unmaintainable.  Now that -resetFieldEditorFrameIfNeeded is
implemented using dirty tricks, it is pretty easy to just check if it
changed rather than trying to predict it.

BUGS=none
TEST=none

Review URL: http://codereview.chromium.org/295036
------------------------------------------------------------------------
r29725 | johnnyg@chromium.org | 2009-10-22 00:53:07 +0200 (Thu, 22 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/painter.h

Re-enable the paint_center option in ImagePainter.

This was lost when ImagePainter was refactored as part of the fix to http://crbug.com/23261.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/300019
------------------------------------------------------------------------
r29723 | brettw@chromium.org | 2009-10-22 00:43:37 +0200 (Thu, 22 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/filebrowse_ui.cc
   A /trunk/src/chrome/browser/dom_ui/filebrowse_ui.h
   A /trunk/src/chrome/browser/resources/filebrowse.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Create an initial Chrome page for file browsing. This just implements the
ability to list files and display them in JS via DOMUI.

BUG=none
TEST=none
Original review: http://codereview.chromium.org/255090
Patch by David Garcia.
------------------------------------------------------------------------
r29721 | estade@chromium.org | 2009-10-22 00:25:14 +0200 (Thu, 22 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h

GTK: add checkbox to external protocol dialog.

BUG=24085
TEST=<a href="aim:goim?screenname=JerseyGrl&message=lol">Click here to message me on AIM!</a>

Review URL: http://codereview.chromium.org/306017
------------------------------------------------------------------------
r29717 | jhawkins@chromium.org | 2009-10-21 23:47:00 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/form_field_history_manager.cc
   A /trunk/src/chrome/browser/form_field_history_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp

Rename AutofillManager to FormFieldHistoryManager to better reflect the purpose of the class.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292050
------------------------------------------------------------------------
r29714 | finnur@chromium.org | 2009-10-21 23:35:47 +0200 (Wed, 21 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

The Management UI now fetches the icon for each extension
and shows it on the page.

BUG=12119
TEST=Open chrome://extensions and all extensions that
have an icon associated with them, should show the
icon and those that don't have the generic plugin
icon.

Review URL: http://codereview.chromium.org/292048
------------------------------------------------------------------------
r29710 | sky@chromium.org | 2009-10-21 23:30:41 +0200 (Wed, 21 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Gets status bubbles on views/gtk to correctly track when the parent
window is hidden/minimized/moved. This is made tricky by the fact that
gtk doesn't have the notion of owned windows that automatically hidden
along with the parent as windows does.

BUG=none
TEST=none directly, although covered by ui tests.

Review URL: http://codereview.chromium.org/304008
------------------------------------------------------------------------
r29709 | rohitrao@chromium.org | 2009-10-21 23:30:29 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

[Mac] Properly flip coordinate systems in BrowserWindowCocoa.

BUG=http://crbug.com/18707
TEST=New windows on secondary monitors should cascade correctly.
Review URL: http://codereview.chromium.org/314006
------------------------------------------------------------------------
r29708 | rohitrao@chromium.org | 2009-10-21 23:30:17 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Properly save the workarea when saving window positions.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/315002
------------------------------------------------------------------------
r29706 | mark@chromium.org | 2009-10-21 23:27:17 +0200 (Wed, 21 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc

Messaging of the download item for extension is now:
Extensions can harm your computer. Are you sure you want to continue? [Continue] [Discard]

This involved taking out the GTMUILocalizerAndLayoutTweaker from the xib and placing it within the controller itself, since the content of the UI is determined at runtime and cannot rely simply on the xib contents.

For Win and Linux, only the confirm button needed to change.

Patch by Andy Bonventre <andybons@gmail.com>

BUG=23105,25257
TEST=When clicking on a link to an extension, the messaging should be specific to extensions and the button to confirm the installation should be 'Continue' instead of 'Save'.
Review URL: http://codereview.chromium.org/293014
------------------------------------------------------------------------
r29704 | zork@chromium.org | 2009-10-21 22:53:39 +0200 (Wed, 21 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/third_party/libjingle/overrides/talk/base/basictypes.h

Fix unit test compiling on Linux
Review URL: http://codereview.chromium.org/295034
------------------------------------------------------------------------
r29700 | shess@chromium.org | 2009-10-21 22:33:43 +0200 (Wed, 21 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm
   A /trunk/src/chrome/browser/cocoa/objc_method_swizzle.h
   A /trunk/src/chrome/browser/cocoa/objc_method_swizzle.mm
   A /trunk/src/chrome/browser/cocoa/objc_method_swizzle_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] DCHECK when raising NSException.

NSException == badness.  This causes a DCHECK when someone is setting
out to raise an NSException.

http://crbug.com/24463
TEST=none

Provoke some exceptions.

Review URL: http://codereview.chromium.org/292004
------------------------------------------------------------------------
r29697 | tony@chromium.org | 2009-10-21 22:19:12 +0200 (Wed, 21 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h

Hack around the floating tab when using space/enter to end a drag.

We don't get a drag-end or a drag-failed event if the user presses
space/enter, so we hack around this with a timer.  I filed a bug with
GTK+ upstream about not getting the event:
  https://bugzilla.gnome.org/show_bug.cgi?id=599130

BUG=21627

Review URL: http://codereview.chromium.org/300028
------------------------------------------------------------------------
r29695 | xiyuan@chromium.org | 2009-10-21 22:10:53 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Fix for issue 24888

Richedit seems to have a default paragraph format which will be used when the last paragraph in the document is deleted. (e.g. when SetWindowText is called, or when user manually deletes everything). When this happens, richedit also automatically set keyboard layout to match the default paragraph format. Unfortunately, fix for issue 11683 does not help for this scenario. The default paragraph format seems could only be set when user switches keyboard layout with an empty richedit. The fix in this CL works around the problem by setting richedit's text to empty before it forward the reading order change hotkey (ctrl+shift/shift+ctrl).

BUG=24888
TEST=Verify this CL fixes issue 24888 that LTR/RTL reading order is preserved when user selects suggestions/changes tabs after changing keyboard layout with non-empty text in Omnibox.

Review URL: http://codereview.chromium.org/294013
------------------------------------------------------------------------
r29693 | chocobo@google.com | 2009-10-21 22:01:35 +0200 (Wed, 21 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/preferences.cc
   A /trunk/src/chrome/browser/chromeos/synaptics_library.cc
   A /trunk/src/chrome/browser/chromeos/synaptics_library.h
   D /trunk/src/chrome/browser/chromeos/touchpad.cc
   D /trunk/src/chrome/browser/chromeos/touchpad.h
   M /trunk/src/chrome/chrome.gyp

Switch to use libcros to make changes to touchpad settings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/300011
------------------------------------------------------------------------
r29688 | rohitrao@chromium.org | 2009-10-21 21:27:49 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

[Mac] Be more aggressive in repositioning windows that are offscreen.

BUG=http://crbug.com/18713
TEST=Windows that can fit entirely onscreen should appear entirely onscreen.
Review URL: http://codereview.chromium.org/293052
------------------------------------------------------------------------
r29687 | mattm@chromium.org | 2009-10-21 21:21:26 +0200 (Wed, 21 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

[Linux] Select the first row in cookies table when the Cookies window is
opened.

Windows already does this.

BUG=None
TEST=compiled and tested on linux and covered by unit_tests.

Review URL: http://codereview.chromium.org/270063
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r29686 | eroman@chromium.org | 2009-10-21 21:12:57 +0200 (Wed, 21 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   A /trunk/src/net/base/address_family.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_cache.cc
   M /trunk/src/net/base/host_cache.h
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/host_resolver_proc.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_view_net_internals_job.cc

Add a mechanism to disable IPv6.

(1) Adds the ability to specify the address family on a per-request basis.

(2) Exposes a --disable-ipv6 flag to chrome that changes the default address family from AF_UNSPEC to AF_INET (same sort of thing Firefox does).

(3) Changes the backing datastructure for HostCache:EntryMap and HostResolverImpl::JobMap from a "hash_map" to a "std::map". This was for consistency with other code (when I went to add a custom hash trait, I couldn't find any existing code which was using hashmap for custom keys).

(4) Updates about:net-internals to display an address family for the hostcache dump (since it is now a part of the key).

This change is in anticipation of turning off IPv6 host resolving in the PAC utility functions (see bug 24641). But it is also a feature addition.

BUG=24641

TEST=HostCacheTest.AddressFamilyIsPartOfKey
Review URL: http://codereview.chromium.org/302010
------------------------------------------------------------------------
r29684 | cira@chromium.org | 2009-10-21 21:08:23 +0200 (Wed, 21 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.h
   M /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.cc
   M /trunk/src/chrome/common/extensions/extension_message_bundle.h
   M /trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en/messages.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en_US/messages.json

Implementing better fallback algorithm.

Before:
 current_locale->default_locale

Now:
 current_locale->chain_of_parent_locales->default_locale

If default_locale is de, and current locale en_US, we follow:
en_US -> en -> de

en is not a Chrome locale (only en_US, en_GB are), but we fake it to allow this kind of fallback.

Developers can implement common locale root with most of the messages (like en) and put locale specifics in en_GB (color->colour) or en_US. You can even symlink en and en_US and save on work.

I am planning on fixing loading local resources too, to use this child->parent fallback.

BUG=12131

Review URL: http://codereview.chromium.org/293037
------------------------------------------------------------------------
r29683 | nsylvain@chromium.org | 2009-10-21 21:04:52 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   D /trunk/src/chrome/test/data/devtools/page_with_content_script.html

Revert 29635 - DevTools: fix and enable TestContentScriptIsPresent

The test was still failing

Review URL: http://codereview.chromium.org/314001

TBR=yurys@google.com
Review URL: http://codereview.chromium.org/292051
------------------------------------------------------------------------
r29681 | pkasting@chromium.org | 2009-10-21 21:02:10 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/api/public/WebViewClient.h
   M /trunk/src/webkit/glue/dom_operations_private.h
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/searchable_form_data.h

Trim unused members from SearchableFormData.  Remove copies of WebCore functions that are now public.  Fix a few style errors.  Make some functions shorter.  Remove "using" directives since most of the file ignored them anyways.  Remove unneeded #includes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292041
------------------------------------------------------------------------
r29673 | estade@chromium.org | 2009-10-21 20:19:03 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc

GTK: Display explanatory message on sad tab page.

Also fix canvas text drawing bugs for certain vertical alignments.

BUG=25267
TEST=about:crash

Review URL: http://codereview.chromium.org/307015
------------------------------------------------------------------------
r29672 | zork@chromium.org | 2009-10-21 20:18:39 +0200 (Wed, 21 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.cc
   M /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.h

Style and comment fixes for sync_setup_wizard_gtk.cc and sync_setup_wizard.h

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/292038
------------------------------------------------------------------------
r29671 | avi@chromium.org | 2009-10-21 20:11:28 +0200 (Wed, 21 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm

Mac: Switch from "Cancel" to "Do Nothing" for the external protocol dialog, and allow remembering the "Do Nothing" choice.

BUG=none
TEST=Verify that "Do Nothing" is the left button, and that clicking the "Remember" checkbox remembers the "Do Nothing" state.

Review URL: http://codereview.chromium.org/314003
------------------------------------------------------------------------
r29669 | jhawkins@chromium.org | 2009-10-21 20:07:38 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/renderer/render_view.cc

Rename RenderViewHostDelegate::Autofill to RenderViewHostDelegate::FormFieldHistory to better reflect the purpose of the interface.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/294030
------------------------------------------------------------------------
r29666 | pam@chromium.org | 2009-10-21 19:40:32 +0200 (Wed, 21 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Use the original profile when opening the keyword editor window, since
otherwise the profile pointer may go stale if it was opened from an Incognito
window.

Simplify the check that already does this on Mac. GetOriginalProfile() returns
the profile it's called on, if it isn't incognito.

BUG=23359
TEST=open Incognito window, right-click in omnibox, Edit Search Engines,
    close Incog window, edit an engine
Review URL: http://codereview.chromium.org/307010
------------------------------------------------------------------------
r29665 | phajdan.jr@chromium.org | 2009-10-21 19:36:49 +0200 (Wed, 21 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   D /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   D /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Remove the extension shelf on Linux.

The extension team's plan is to get rid of extension shelf entirely.

This is also going to fix a crash.

TEST=none
BUG=25106

Review URL: http://codereview.chromium.org/313006
------------------------------------------------------------------------
r29660 | thakis@chromium.org | 2009-10-21 19:15:28 +0200 (Wed, 21 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc

Fix cmd-opt-left/right.

This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.

BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29646
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648

Review URL: http://codereview.chromium.org/313004
------------------------------------------------------------------------
r29657 | evan@chromium.org | 2009-10-21 18:45:38 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

posix: ~ should be considered a path character in the omnibox

We expand it to $HOME or the appropriate /home/foobar.

BUG=18200
TEST=Extended the unit test with test cases.

Review URL: http://codereview.chromium.org/300026
------------------------------------------------------------------------
r29656 | davemoore@chromium.org | 2009-10-21 18:33:42 +0200 (Wed, 21 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status_area_button.cc

Fix for Release build break

Review URL: http://codereview.chromium.org/293050
------------------------------------------------------------------------
r29651 | davemoore@chromium.org | 2009-10-21 18:13:58 +0200 (Wed, 21 Oct 2009) | 14 lines
Changed paths:
   A /trunk/src/chrome/app/theme/statusbar_battery10c.png
   A /trunk/src/chrome/app/theme/statusbar_battery10d.png
   A /trunk/src/chrome/app/theme/statusbar_battery11c.png
   A /trunk/src/chrome/app/theme/statusbar_battery11d.png
   A /trunk/src/chrome/app/theme/statusbar_battery12c.png
   A /trunk/src/chrome/app/theme/statusbar_battery12d.png
   A /trunk/src/chrome/app/theme/statusbar_battery13c.png
   A /trunk/src/chrome/app/theme/statusbar_battery13d.png
   A /trunk/src/chrome/app/theme/statusbar_battery14c.png
   A /trunk/src/chrome/app/theme/statusbar_battery14d.png
   A /trunk/src/chrome/app/theme/statusbar_battery15c.png
   A /trunk/src/chrome/app/theme/statusbar_battery15d.png
   A /trunk/src/chrome/app/theme/statusbar_battery16c.png
   A /trunk/src/chrome/app/theme/statusbar_battery16d.png
   M /trunk/src/chrome/app/theme/statusbar_battery1c.png
   M /trunk/src/chrome/app/theme/statusbar_battery1d.png
   M /trunk/src/chrome/app/theme/statusbar_battery2c.png
   M /trunk/src/chrome/app/theme/statusbar_battery2d.png
   M /trunk/src/chrome/app/theme/statusbar_battery3c.png
   M /trunk/src/chrome/app/theme/statusbar_battery3d.png
   M /trunk/src/chrome/app/theme/statusbar_battery4c.png
   M /trunk/src/chrome/app/theme/statusbar_battery4d.png
   M /trunk/src/chrome/app/theme/statusbar_battery5c.png
   M /trunk/src/chrome/app/theme/statusbar_battery5d.png
   M /trunk/src/chrome/app/theme/statusbar_battery6c.png
   M /trunk/src/chrome/app/theme/statusbar_battery6d.png
   M /trunk/src/chrome/app/theme/statusbar_battery7c.png
   M /trunk/src/chrome/app/theme/statusbar_battery7d.png
   M /trunk/src/chrome/app/theme/statusbar_battery8c.png
   M /trunk/src/chrome/app/theme/statusbar_battery8d.png
   A /trunk/src/chrome/app/theme/statusbar_battery9c.png
   A /trunk/src/chrome/app/theme/statusbar_battery9d.png
   M /trunk/src/chrome/app/theme/statusbar_battery_charged.png
   A /trunk/src/chrome/app/theme/statusbar_battery_missing.png
   M /trunk/src/chrome/app/theme/statusbar_battery_unknown.png
   A /trunk/src/chrome/app/theme/statusbar_container.png
   A /trunk/src/chrome/app/theme/statusbar_container_hover.png
   A /trunk/src/chrome/app/theme/statusbar_container_pressed.png
   M /trunk/src/chrome/app/theme/statusbar_menu.png
   A /trunk/src/chrome/app/theme/statusbar_network_disconnected.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_dot.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_down1.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_down1p.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_down2.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_down2p.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_down3.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_down3p.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_up1.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_up1p.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_up2.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_up2p.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_up3.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_up3p.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_warning.png
   M /trunk/src/chrome/app/theme/statusbar_wired.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/cros_power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_power_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/power_menu_button.h
   A /trunk/src/chrome/browser/chromeos/status_area_button.cc
   A /trunk/src/chrome/browser/chromeos/status_area_button.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome.gyp

New button scheme...borders are separate from the inner contents so
that they can be highlighted / depressed independently.

Got alignment of buttons right.

Support hover and pushed in StatusAreaButton.

Share status area button code.

New icons for battery and wifi.

New images.

Review URL: http://codereview.chromium.org/300018
------------------------------------------------------------------------
r29648 | nsylvain@chromium.org | 2009-10-21 17:39:12 +0200 (Wed, 21 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm

Revert 29646 - Fix cmdoptleft/right.

This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmdoptleft meant cmdleft and swallowed the event.

BUG=25396
TEST=Focus text box in web. cmdoptleft/right should switch tabs, cmdleft/right should move cursor in text box. Focus web background. cmdoptleft/right should switch tabs, cmdleft/right should do history navigation. Focus omnibox. cmdoptleft/right should still switch tabs, cmdleft/right should move cursor. cmd1/2 should switch tabs in all three places, cmdopt1/2 should not do anything.

Review URL: http://codereview.chromium.org/313004

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/306025
------------------------------------------------------------------------
r29646 | thakis@chromium.org | 2009-10-21 17:24:04 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm

Fix cmd-opt-left/right.

This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.

BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.

Review URL: http://codereview.chromium.org/313004
------------------------------------------------------------------------
r29635 | yurys@google.com | 2009-10-21 15:01:28 +0200 (Wed, 21 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/page_with_content_script.html

DevTools: fix and enable TestContentScriptIsPresent

Review URL: http://codereview.chromium.org/314001
------------------------------------------------------------------------
r29630 | yurys@google.com | 2009-10-21 12:31:26 +0200 (Wed, 21 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: temporarily disable TestContentScriptIsPresent

TBR=apavlov
Review URL: http://codereview.chromium.org/313002
------------------------------------------------------------------------
r29623 | yurys@google.com | 2009-10-21 09:17:17 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/extensions
   A /trunk/src/chrome/test/data/devtools/extensions/simple_content_script
   A /trunk/src/chrome/test/data/devtools/extensions/simple_content_script/manifest.json
   A /trunk/src/chrome/test/data/devtools/extensions/simple_content_script/simple_content_script.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: test that content scripts are visible in the debugger scripts list

BUG=25294,24214
TEST=DevToolsExtensionDebugTest.TestContentScriptIsPresent
Review URL: http://codereview.chromium.org/295020
------------------------------------------------------------------------
r29607 | eroman@chromium.org | 2009-10-21 05:18:59 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Revert r29418 as it caused a regression.

OnKillFocus() is being called during destruction, and tries to access a render_widget_host_ which has already been NULLed.

BUG=25290, 24248
TBR=jcampan

Review URL: http://codereview.chromium.org/308014
------------------------------------------------------------------------
r29596 | estade@chromium.org | 2009-10-21 03:28:58 +0200 (Wed, 21 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h

revert r29588.

John says the DB thread always gets shut down by the IO thread, so the change is unnecessary, also, it caused valgrind leaks.

BUG=25245

Review URL: http://codereview.chromium.org/293039
------------------------------------------------------------------------
r29588 | estade@chromium.org | 2009-10-21 01:41:50 +0200 (Wed, 21 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h

SQL cookie store: Safely post to DB thread from IO thread.

BUG=25245
TEST=?

Review URL: http://codereview.chromium.org/295032
------------------------------------------------------------------------
r29587 | estade@chromium.org | 2009-10-21 01:27:33 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h

GTK: theme the info bar border.

Also apply the default border for non-gtk themes.

BUG=23390
TEST=none

Review URL: http://codereview.chromium.org/304012
------------------------------------------------------------------------
r29586 | rogerta@chromium.org | 2009-10-21 01:26:40 +0200 (Wed, 21 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Add support for to automation interface load install and load extensions.

TEST=None
BUG=0

Review URL: http://codereview.chromium.org/274076
------------------------------------------------------------------------
r29584 | finnur@chromium.org | 2009-10-21 01:13:43 +0200 (Wed, 21 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Implement the new extension management UI. For the UI mocks
see the bug details.

This gets us most of the way there. We have made minor
course corrections since the mocks were introduced (no 
date will be shown, no "Get more extensions" link is
visible and the name is not linked).

Known issues: 

The only thing missing is the fact that we show a default
plugin icon for each extension (as opposed to the icon for
the extension). 

BUG=12119
TEST=Open chrome://extensions and all the buttons and
links should work (Developer Tools, Enable, Disable,
Reload, Uninstall, Load, Pack, Update, etc).

Review URL: http://codereview.chromium.org/293028
------------------------------------------------------------------------
r29581 | mpcomplete@chromium.org | 2009-10-21 00:57:14 +0200 (Wed, 21 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/bg.html
   M /trunk/src/chrome/test/data/extensions/samples/gmail_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html

Fix drawing code for page action badges.

The badge can now extend beyond the boundary of the image.

BUG=24644

Review URL: http://codereview.chromium.org/297014
------------------------------------------------------------------------
r29580 | jhawkins@chromium.org | 2009-10-21 00:49:47 +0200 (Wed, 21 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   D /trunk/src/webkit/glue/autofill_form.cc
   D /trunk/src/webkit/glue/autofill_form.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   A /trunk/src/webkit/glue/form_field_values.cc
   A /trunk/src/webkit/glue/form_field_values.h
   M /trunk/src/webkit/webkit.gyp

Rename AutoFillForm to FormFieldValues to better reflect the purpose of the data structure.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306014
------------------------------------------------------------------------
r29579 | arv@chromium.org | 2009-10-21 00:47:33 +0200 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Remove the unused handlers as well

BUG=None

TEST=None


Review URL: http://codereview.chromium.org/292001
------------------------------------------------------------------------
r29572 | mhm@chromium.org | 2009-10-20 23:21:01 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Allow ESC to cancel ALT+SHIFT+T in Toolbar.

By overriding SkipDefaultKeyEventProcessing in View, it will ensure that the current hackish implementation of Toolbar request focus will be dealt before any other focus related actions and accelerators.

BUG=8239
TEST=Press ESC while in accessibility mode.

Review URL: http://codereview.chromium.org/272024
------------------------------------------------------------------------
r29571 | ben@chromium.org | 2009-10-20 23:04:33 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Fix bubbles deactivating the opaque frame.

The theme work caused a check that had been included to see if the frame view should be painted as active even if it was inactive. This reintroduces that check.

http://crbug.com/20966
TEST=see bug

Review URL: http://codereview.chromium.org/303012
------------------------------------------------------------------------
r29562 | pinkerton@chromium.org | 2009-10-20 22:33:54 +0200 (Tue, 20 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Make escape remove a bookmark if it's just been added (but not if it already existed). Add unit tests for both behaviors. Add metrics to match windows code. 
BUG=24466
TEST=if bookmark existed prior to clicking star, esc should leave it. if clicking star added bookmark, esc should remove it.
Review URL: http://codereview.chromium.org/300022
------------------------------------------------------------------------
r29556 | mpcomplete@chromium.org | 2009-10-20 22:13:24 +0200 (Tue, 20 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html

Revert "Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista"

Original description:

Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/293031
------------------------------------------------------------------------
r29555 | mpcomplete@chromium.org | 2009-10-20 22:09:15 +0200 (Tue, 20 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix a race bug where content scripts would not apply to the first page load.

BUG=11547

Review URL: http://codereview.chromium.org/302011
------------------------------------------------------------------------
r29554 | shess@chromium.org | 2009-10-20 22:06:10 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Prevent browser window from re-displaying when partially shut down.

http://crbug.com/24734
TEST=Start Chrome, Command-o, Command-q, should quit cleanly.
TEST=download a file.  Should be able to Quit the browser cleanly.
TEST=Open two windows with one tab apiece.  Drag one to the other.  Should not crash.

Review URL: http://codereview.chromium.org/295028
------------------------------------------------------------------------
r29553 | finnur@chromium.org | 2009-10-20 21:56:43 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/extensions_ui_page_logo.png (from /trunk/src/chrome/browser/resources/gear.png:29423)

Adding new image needed for the managment UI. This way I might be
able to try this change on the try bot in my other changelist.

TBR=aa
BUG=12119
TEST=None

Review URL: http://codereview.chromium.org/295029
------------------------------------------------------------------------
r29549 | darin@chromium.org | 2009-10-20 21:25:42 +0200 (Tue, 20 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_messages_internal.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_linux.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/login_database_mac.cc
   M /trunk/src/chrome/browser/password_manager/login_database_mac.h
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations.h
   M /trunk/src/webkit/glue/dom_operations_unittest.cc
   M /trunk/src/webkit/glue/form_data.h
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener_unittest.cc
   M /trunk/src/webkit/glue/password_form.h
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h

Convert some structures in webkit/glue to string16.

R=yaar
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/305002
------------------------------------------------------------------------
r29548 | evan@chromium.org | 2009-10-20 21:12:42 +0200 (Tue, 20 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/base/keyboard_code_conversion_gtk.cc
   M /trunk/src/base/keyboard_code_conversion_gtk.h
   M /trunk/src/chrome/browser/chromeos/chromeos_version_loader.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/sync/util/highres_timer_mac.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/autoupdate.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/build/generator.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/devtools.html
   M /trunk/src/chrome/common/extensions/docs/events.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/hosting.html
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/match_patterns.html
   M /trunk/src/chrome/common/extensions/docs/npapi.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/docs/static/api_index.html
   M /trunk/src/chrome/common/extensions/docs/static/api_other.html
   M /trunk/src/chrome/common/extensions/docs/static/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/static/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/static/browserAction.html
   M /trunk/src/chrome/common/extensions/docs/static/devguide.html
   M /trunk/src/chrome/common/extensions/docs/static/extension.html
   M /trunk/src/chrome/common/extensions/docs/static/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/static/index.html
   M /trunk/src/chrome/common/extensions/docs/static/manifest.html
   M /trunk/src/chrome/common/extensions/docs/static/overview.html
   M /trunk/src/chrome/common/extensions/docs/static/packaging.html
   M /trunk/src/chrome/common/extensions/docs/static/tabs.html
   M /trunk/src/chrome/common/extensions/docs/static/themes.html
   M /trunk/src/chrome/common/extensions/docs/static/toolstrip.html
   M /trunk/src/chrome/common/extensions/docs/static/windows.html
   M /trunk/src/chrome/common/extensions/docs/static/xhr.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/template/page_shell.html
   M /trunk/src/chrome/common/extensions/docs/test.html
   M /trunk/src/chrome/common/extensions/docs/themes.html
   M /trunk/src/chrome/common/extensions/docs/toolstrip.html
   M /trunk/src/chrome/common/extensions/docs/tut_debugging.html
   M /trunk/src/chrome/common/extensions/docs/tutorials.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/extensions/docs/xhr.html
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html
   M /trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html
   M /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/a.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/b.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/c.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/d.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/e.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/f.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/relative.html
   M /trunk/src/chrome/test/data/extensions/api_test/toolstrip/folder/relative.html
   M /trunk/src/chrome/test/data/extensions/api_test/toolstrip/test.html
   M /trunk/src/chrome/test/data/extensions/api_test/toolstrip/test2.html
   M /trunk/src/chrome/test/data/extensions/browsertest/last_error/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/backgroundpage.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/test_gettabs.html
   M /trunk/src/chrome/test/data/extensions/profiles/toolstrips1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/profiles/toolstrips50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/bg.html
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/popup.html
   M /trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html
   M /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/mappy/popup.html
   M /trunk/src/chrome/test/data/extensions/samples/mole/mole.html
   M /trunk/src/chrome/test/data/extensions/samples/override_igoogle/redirect.html
   M /trunk/src/chrome/test/data/extensions/samples/screenshot/screenshot.html
   M /trunk/src/chrome/test/data/extensions/samples/screenshot/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/set_icon_path/background.html
   M /trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html
   M /trunk/src/o3d/samples/shadow-map.html
   M /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.cc
   M /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.h
   M /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/webkit/api/public/WebAccessibilityObject.h
   M /trunk/src/webkit/tools/test_shell/accessibility_controller.cc
   M /trunk/src/webkit/tools/test_shell/accessibility_controller.h
   M /trunk/src/webkit/tools/test_shell/accessibility_ui_element.cc
   M /trunk/src/webkit/tools/test_shell/accessibility_ui_element.h

Remove +x bit from files that shouldn't have it.

Review URL: http://codereview.chromium.org/307007
------------------------------------------------------------------------
r29545 | evan@chromium.org | 2009-10-20 20:56:25 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

"Fix" a NOTIMPLEMENTED on Linux by using the default password store.

We haven't yet resolved how to integrate with OS-native password stores,
so printing this NOTIMPLEMENTED isn't helpful.

Review URL: http://codereview.chromium.org/308003
------------------------------------------------------------------------
r29542 | tony@chromium.org | 2009-10-20 20:51:43 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

If we're in the middle of a drag, don't allow the user to middle
click to close or right click for the context menu.

BUG=21627
TEST=On a tab, left mouse down, right mouse click, then drag.  Left mouse
  up should release the tab.

Review URL: http://codereview.chromium.org/305004
------------------------------------------------------------------------
r29538 | estade@chromium.org | 2009-10-20 20:31:13 +0200 (Tue, 20 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc

Extensions: guarantee removal of BROWSER_WINDOW_READY registration.

In unit tests, we were not removing the registration because we never get the BROWSER_WINDOW_READY notification. When a browser later gets allocated the same memory address, we hit a DCHECK in registrar_.Add().

This change should be safe because BROWSER_WINDOW_READY only gets called at most once per browser instance.

BUG=none
TEST=linux build bots stop flaking on this test

Review URL: http://codereview.chromium.org/306009
------------------------------------------------------------------------
r29533 | oshima@chromium.org | 2009-10-20 20:01:45 +0200 (Tue, 20 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extender.cc
   M /trunk/src/chrome/browser/chromeos/browser_extender.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/panel_controller.cc
   M /trunk/src/chrome/browser/views/panel_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/chrome.gyp

PanelControler support
 * Refactored BrowserExtender and added NormalExtender and PopopExtender.
   BrowserExtender::Create factory method returns appropriate extender for given BrowserView.
 * Added #if/#else to PanelController to accept BrowserView in Constructor.
 * added guard code in Close so that it will ignore 2nd invocation of Close. (views seems
   to call Close() (when it requests, and when it's really closed)
Added missing code in TabOverviewMessageListener

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/276075
------------------------------------------------------------------------
r29531 | pinkerton@chromium.org | 2009-10-20 19:40:24 +0200 (Tue, 20 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Make dropped tabs animate from where they were dropped. Make room for the full width of the tab placeholder. Make tab dragging as smooth as glass.
BUG=24982, 24983
TEST=tab dragging between windows, tab dragging w/in a window.
Review URL: http://codereview.chromium.org/306006
------------------------------------------------------------------------
r29529 | estade@chromium.org | 2009-10-20 19:39:44 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Ignore invalid urls on command line.

BUG=none
TEST=chrome doesn't dcheck if you launch with a command line such as "chrome %U"

Review URL: http://codereview.chromium.org/293010
------------------------------------------------------------------------
r29528 | estade@chromium.org | 2009-10-20 19:39:15 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK: Change text for extension download UI.

BUG=25257
TEST=none

Review URL: http://codereview.chromium.org/303009
------------------------------------------------------------------------
r29527 | mirandac@chromium.org | 2009-10-20 19:36:16 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/importer_lock_dialog.h
   M /trunk/src/chrome/browser/cocoa/importer_lock_dialog.mm
   M /trunk/src/chrome/browser/importer/importer.cc

Add dialog to tell user to close Firefox during import, if it's open and blocking.  OS-Mac only.

BUG= http://crbug.com/20899
TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29481
Review URL: http://codereview.chromium.org/283023
------------------------------------------------------------------------
r29524 | tony@chromium.org | 2009-10-20 19:17:10 +0200 (Tue, 20 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Fix crash bug when attempting to download a url with unsupported scheme,
e.g. 'data:', by 'Alt + Click'.

Note: This change only fixes crash. Supporting a download for URL
with 'data:' scheme is not implemented in the change.

BUG=24846
TEST=See the first entry of bug 24846 and confirm that the browser won't crash.

Original patch by hayato@google.com at
http://codereview.chromium.org/287002/show

Review URL: http://codereview.chromium.org/306007
------------------------------------------------------------------------
r29519 | thakis@chromium.org | 2009-10-20 18:44:35 +0200 (Tue, 20 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Cleanup unneccessary include.

Review URL: http://codereview.chromium.org/308002
------------------------------------------------------------------------
r29517 | finnur@chromium.org | 2009-10-20 18:19:00 +0200 (Tue, 20 Oct 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/minus.png
   A /trunk/src/chrome/browser/resources/plus.png

Adding two images for the new Extension managment UI.

I separated this from the other changelist so that the
try servers wouldn't fail because a binary file had
been added.

TBR=rafaelw
BUG=12119
TEST=None, no code change.

Review URL: http://codereview.chromium.org/294024
------------------------------------------------------------------------
r29515 | sky@chromium.org | 2009-10-20 18:01:45 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Disables session restore on chrome os when running tests. This causes
problems with some tests as the nested message loop run by session
restore gets prematurely exited and Chrome is left in a weird state.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/294009
------------------------------------------------------------------------
r29512 | mad@chromium.org | 2009-10-20 17:27:21 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_resource.cc
   M /trunk/src/chrome/common/extensions/extension_resource.h
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc

Minimize dependency of user scripts.

And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt.

BUG=none
TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized.

Review URL: http://codereview.chromium.org/267051
------------------------------------------------------------------------
r29511 | viettrungluu@chromium.org | 2009-10-20 17:09:55 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/common/process_watcher_posix.cc
   M /trunk/src/chrome/renderer/render_thread.cc

Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).

We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this.

BUG=25272
TEST=none

Review URL: http://codereview.chromium.org/300010
------------------------------------------------------------------------
r29509 | nsylvain@chromium.org | 2009-10-20 15:33:41 +0200 (Tue, 20 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html

Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista

Original description:
Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/291003

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/306004
------------------------------------------------------------------------
r29498 | phajdan.jr@chromium.org | 2009-10-20 08:40:15 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h

Correctly handle extension reloading in the task manager.

BUG=18693
TEST=Added new tests to browser_tests.

Review URL: http://codereview.chromium.org/300005
------------------------------------------------------------------------
r29497 | ukai@chromium.org | 2009-10-20 07:51:55 +0200 (Tue, 20 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/api/public/WebKit.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebKit.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

add enableWebSockets in WebKit API
and remove experimentalWebSocketsEnabled from WebPreferences/Settings.

Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too.  This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium.
Instead add WebKit::enableWebSockets() in this change to
control WebSockets feature.

Review URL: http://codereview.chromium.org/292012
------------------------------------------------------------------------
r29495 | aa@chromium.org | 2009-10-20 07:16:54 +0200 (Tue, 20 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path/background.html
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon1.png
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon2.png
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon3.png
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon4.png
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon5.png
   A /trunk/src/chrome/test/data/extensions/samples/set_icon_path/manifest.json

Implement chrome.browserAction.setIcon({path:...});

BUG=22575

Review URL: http://codereview.chromium.org/269103
------------------------------------------------------------------------
r29491 | jorlow@chromium.org | 2009-10-20 05:21:58 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   A /trunk/src/chrome/test/data/layout_tests/clear_dom_storage.html
   M /trunk/src/chrome/test/data/layout_tests/layout_test_controller.html
   M /trunk/src/chrome/test/ui/ui_layout_test.cc

Add the first event ui test + a bunch of refactoring.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/271020
------------------------------------------------------------------------
r29489 | jorlow@chromium.org | 2009-10-20 04:46:19 +0200 (Tue, 20 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/webkit/api/src/StorageEventDispatcherImpl.cpp
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Roll WebKit up to 49830 and fix a build error caused by that revision.

TBR=yutak
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/294017
------------------------------------------------------------------------
r29488 | thakis@chromium.org | 2009-10-20 04:33:54 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Fix DCHECK.

BUG=none
TEST=Focus background of google.com, hit "a". Shouldn't DCHECK.

Review URL: http://codereview.chromium.org/297017
------------------------------------------------------------------------
r29482 | tony@chromium.org | 2009-10-20 02:27:49 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Don't use gtk_dialog_run for extension install errors because
it blocks the main message loop.

BUG=19441

Review URL: http://codereview.chromium.org/294014
------------------------------------------------------------------------
r29481 | mirandac@chromium.org | 2009-10-20 02:11:09 +0200 (Tue, 20 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/importer_lock_dialog.h
   A /trunk/src/chrome/browser/cocoa/importer_lock_dialog.mm
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/chrome.gyp

Add dialog to tell user to close Firefox during import, if it's open and blocking.  OS-Mac only.

BUG= http://crbug.com/20899
TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox.

Review URL: http://codereview.chromium.org/283023
------------------------------------------------------------------------
r29472 | evan@chromium.org | 2009-10-20 00:54:41 +0200 (Tue, 20 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/base/base_paths_win.cc
   M /trunk/src/base/i18n/icu_util.cc
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler_unittest.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc

Deprecate PathService::Get(..., wstring*) and use FilePath instead.

I tried fixing all the Windows code but there's a *ton* of it.
This change will at least prevent people from adding new code that
uses the deprecated version (as that won't compile on Lin/Mac).

BUG=24672

Review URL: http://codereview.chromium.org/293013
------------------------------------------------------------------------
r29471 | cevans@chromium.org | 2009-10-20 00:45:59 +0200 (Tue, 20 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

(Copy of previous CL that existed in a client I lost)

- Don't treat the body of an "authentication required" response as a valid dictionary!
- In the event of a 200 status code, check the response actually looks like a dictionary.

BUG=24486
TEST=Verified the appearance of new dictionaries after changing spell-check language; verified spell-checking on new dictionaries.
TBR=sidchat

Review URL: http://codereview.chromium.org/295014
------------------------------------------------------------------------
r29468 | tony@chromium.org | 2009-10-20 00:27:00 +0200 (Tue, 20 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/extensions/extension.h

Delete unused themes from disk on shutdown.

This reduces the size of the Preferences file and frees up some disk space.
The smaller Preferences file should help improve startup time for users
who have installed lots of themes.

BUG=24377

Review URL: http://codereview.chromium.org/303006
------------------------------------------------------------------------
r29461 | dimich@google.com | 2009-10-19 23:39:54 +0200 (Mon, 19 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/child_process_host.cc
   A /trunk/src/chrome/test/data/ssl/imported.js
   A /trunk/src/chrome/test/data/ssl/page_with_unsafe_worker.html
   A /trunk/src/chrome/test/data/ssl/unsafe_worker.js

Degrade the https color and lock icon for the page that has a worker that loads subresource with bad cert.
The idea is to make UI reflect loading of resources with bad certificates that were previously approved by the user.
bug=20176
TEST=SSLUITest.TestUnsafeContentsInWorker unit_test.
Review URL: http://codereview.chromium.org/268006
------------------------------------------------------------------------
r29458 | thakis@chromium.org | 2009-10-19 23:19:55 +0200 (Mon, 19 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Make window cycling work even if you change it to something else than cmd-` in sysprefs.

Instead of just dispatching to the menu after a key comes back from the renderer, do a complete re-dispatch to NSApp (so that the event gets to the menu and cmd-` handlers) but then ignore it when it comes back to the web (because we already sent this event to the renderer once).

BUG=24817
TEST=Open sysprefs, change keyboard shortcut for "Move focus to next window in active application" to e.g. cmd-\. Open two chrome windows, focus the web, hit cmd-\. It should switch windows. All other keyboard shortcuts should still work (test that ctrl-tab works when web has focus, test backspace when text field is focussed in web, when background is focussed in web, when IME is active, test hitting cmd-1/2 when omnibox or web have focus, hit cmd-left when omnibox, textbox in web, background in web has focus, test that cmd-f in docs still opens doc's find interface)

Review URL: http://codereview.chromium.org/303002
------------------------------------------------------------------------
r29457 | mpcomplete@chromium.org | 2009-10-19 23:08:30 +0200 (Mon, 19 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html

Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/291003
------------------------------------------------------------------------
r29450 | pkasting@chromium.org | 2009-10-19 22:37:48 +0200 (Mon, 19 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc

Parse input with explicit schemes better.  Before, if the user typed "http://..." we always parsed as a URL.  Now we parse more like we would without the scheme, so that we can reject various kinds of invalid inputs.

BUG=none
TEST=Input "http://foo:bar" (without quotes) in the address bar, and the default action should be search, not navigate.
Review URL: http://codereview.chromium.org/292003
------------------------------------------------------------------------
r29443 | sky@chromium.org | 2009-10-19 22:06:08 +0200 (Mon, 19 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc

Lands http://codereview.chromium.org/272036 for Thiago:

Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode.

GetType -> type
SetType -> set_type

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/297005
------------------------------------------------------------------------
r29437 | tim@chromium.org | 2009-10-19 21:26:24 +0200 (Mon, 19 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc

Beef-up a DCHECK_NE case in browser_sync::ChangeProcessor to return early if one of the permanent nodes are changed by a bookmark model event.  I think we may hit a roadblock a bit deeper down right now and not actually poison the user's cloud state, but it seems best to
catch this at first-chance.

BUG=25067

Review URL: http://codereview.chromium.org/295007
------------------------------------------------------------------------
r29435 | brettw@chromium.org | 2009-10-19 21:17:32 +0200 (Mon, 19 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/spellchecker_linux.cc
   M /trunk/src/chrome/browser/spellchecker_mac.mm
   M /trunk/src/chrome/browser/spellchecker_platform_engine.h
   M /trunk/src/chrome/browser/spellchecker_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu.h

Convert the spellchecker and associated messages and functions to use string16
for words instead of wstring. I also changed some places where it converted the
word to a string to do that conversion at the last possible second before
giving it to Hunspell (since this conversion isn't needed for Mac).

TEST=Covered by unit tests
BUG=none
Review URL: http://codereview.chromium.org/274077
------------------------------------------------------------------------
r29431 | thomasvl@chromium.org | 2009-10-19 20:48:12 +0200 (Mon, 19 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Support the Bookmark bar and Other bookmarks titles in titlecase.

TEST=the bookmark bubble menu should have title case items for the two.
BUG=24912
Review URL: http://codereview.chromium.org/297004
------------------------------------------------------------------------
r29430 | cevans@chromium.org | 2009-10-19 20:43:18 +0200 (Mon, 19 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc

Use SSL to fetch the "known plug-ins" list.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/280002
------------------------------------------------------------------------
r29428 | pkasting@chromium.org | 2009-10-19 20:42:36 +0200 (Mon, 19 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h

Allow the history URL provider to handle input of type QUERY.  This helps in the case where the user types something that on its own isn't navigable, but might be the prefix of something else navigable.

While there are no tests for this directly, another change of mine to treat more inputs with explicit schemes as queries (e.g. "http:/") relies on this, and does unittest for it.

In order to fit the new relevance scores into the table, I went through and simplified the relevance scoring so that generally providers used the same scores for more input types.  The effects of this should be barely noticeable (it affects the ranking of past search queries that are old against results from the secondary search provider), and it simplifies the code noticeably.

This also fixes a "bug" that the NavSuggest results were incremented backwards, but since we only score one of these right now there's no visible effect.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/291005
------------------------------------------------------------------------
r29426 | kuchhal@chromium.org | 2009-10-19 20:35:18 +0200 (Mon, 19 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Make importer obey import_search_engine preference even if FRUI is enabled.

With this change importer will give preference to the value specified in master
preference for import_search_engine instead of ignoring it like before.

BUG=23649
TEST=Specified in above bug.

Review URL: http://codereview.chromium.org/274081
------------------------------------------------------------------------
r29423 | kuchhal@chromium.org | 2009-10-19 20:19:07 +0200 (Mon, 19 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/setup_util_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc

Make GetDistroBooleanPreference return troolean value.

BUG=23649
TEST=installer_util_unittests, setup_unittests

Review URL: http://codereview.chromium.org/269107
------------------------------------------------------------------------
r29421 | evan@chromium.org | 2009-10-19 19:56:51 +0200 (Mon, 19 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc

linux: fix compile errors in extension_creator

New code added more fwrite calls where the return code isn't handled,
causing compile errors on Fedora and other platforms.
While we're at it, use the new PLOG interface.

BUG=24347

Review URL: http://codereview.chromium.org/300007
------------------------------------------------------------------------
r29420 | ananta@chromium.org | 2009-10-19 19:34:57 +0200 (Mon, 19 Oct 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome_frame/bho.cc
   M /trunk/src/chrome_frame/bho.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_activex_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.cc
   M /trunk/src/chrome_frame/test/chrome_frame_automation_mock.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   A /trunk/src/chrome_frame/test/data/referrer_frame.html
   A /trunk/src/chrome_frame/test/data/referrer_main.html

When Chrome hands off a URL to be opened by the external host by the ViewHostMsg_OpenURL IPC, it
needs to pass the referrer as well. The Chrome fixes in this CL are mostly related to passing the
HTTP referer off to the browser and from there to the ExternalTabContainer to ChromeFrame and back.

The ChromeFrame changes are basically around the same lines with one exception. When we handle the
AutomationMsg_OpenURL IPC in the activex and the active document we pass the referer if applicable
to the WebBrowser2::Navigate2 interface, which is then read by the BHO in BeforeNavigate2. We then
save away an AddRef'ed BHO pointer in TLS which is then referenced by the Active document for reading
the referer and passing it off to Chrome in the NavigateInExternalTab message.

Added a unit test in ChromeFrame which tests this case.

This fixes http://code.google.com/p/chromium/issues/detail?id=22994

Bug=22994

Review URL: http://codereview.chromium.org/274071
------------------------------------------------------------------------
r29418 | eroman@chromium.org | 2009-10-19 19:30:04 +0200 (Mon, 19 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Speculative fix for a crash where RenderWidgetHostViewWin tries to access a deleted RenderWidgetHost during OnFinalMessage().

BUG=24248

Review URL: http://codereview.chromium.org/284019
------------------------------------------------------------------------
r29414 | davemoore@chromium.org | 2009-10-19 19:15:22 +0200 (Mon, 19 Oct 2009) | 23 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/chrome/browser/chromeos/chromeos_version_loader.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Do work necessary to make Views About panel work on Chrome OS. This is to be used for forcing Chrome OS updates.

There were many things that needed to be fixed for this to work.

Make skia's canvas return height of font for size of strings, instead of the actual height of the characters to bring it in line with Windows.

Make average character widths use pango metrics and windows dialog units. Make this lazy, to avoid most calls.

Fix bug in About panel that failed to adjust the embedded links to allow for the padding that Link adds so they can be focused.

Support gtk about panel in regular build, views in chrome os only.

Fix WindowGtk to call WindowClosing()

Fix canvas_linux::SetupPangoLayout() to wrap correctly, if passed a width

Fix Label::ComputeMultiLineFlags() to turn off eliding. With  eliding the pango routines always return 1 line.

Enable focus manager in dialogs.

Version loader crashed in debug.

Review URL: http://codereview.chromium.org/282002
------------------------------------------------------------------------
r29412 | erg@google.com | 2009-10-19 19:04:46 +0200 (Mon, 19 Oct 2009) | 24 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_mac.mm
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/app/theme_provider.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/ref_counted.h
   A /trunk/src/base/ref_counted_memory.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/favicon_service.cc
   M /trunk/src/chrome/browser/favicon_service.h
   M /trunk/src/chrome/browser/history/top_sites.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/common/ref_counted_util.h
   M /trunk/src/views/widget/default_theme_provider.h

First fix to minimize copying of image data.

This is the first of multiple patches that clean up handling of memory
regarding images. Previously, the code did several memcpy()s or
equivalents. This change:

- Creates an abstract interface RefCountedMemory which provides access to the
  front() of a memory range and the size() of it. It is a RefCountedThreadSafe.
- Adds a RefCountedStaticMemory class which isa RefCountedMemory.
- Pushes RefCountedBytes up into base/ from chrome/ and make it conform to
  RefCountedMemory.
- Have ResourceBundle return RefCountedStaticMemory to the mmaped() or DLL
  loaded resources instead of memcpy()ing them.
- General cleanups to minimize copies in constructing RefCountedBytes.
- Use the above consistent interface in the BrowserThemeProvider, along with
  special casing the loading of the new tab page background.

This patch is mostly cleanups and there should only be a slight performance
gain if any. Most of the real speedups should come in subsequent patches.

BUG=http://crbug.com/24493
TEST=Slightly faster on Perf bot; does not introduce crashes.

Review URL: http://codereview.chromium.org/288005
------------------------------------------------------------------------
r29409 | thomasvl@chromium.org | 2009-10-19 18:44:07 +0200 (Mon, 19 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc

Add NOTREACHED for someone trying to change the title on the bookmark bar folder or other bookmarks folders.

TEST=none
BUG=25067
Review URL: http://codereview.chromium.org/293006
------------------------------------------------------------------------
r29407 | avi@chromium.org | 2009-10-19 18:31:46 +0200 (Mon, 19 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm

Adding bug link to TODOs; no code change.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/304002
------------------------------------------------------------------------
r29406 | avi@chromium.org | 2009-10-19 18:31:00 +0200 (Mon, 19 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Remove unused code; the code that now implements this is in chrome_browser_window.mm as of r28613.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/304001
------------------------------------------------------------------------
r29397 | pinkerton@chromium.org | 2009-10-19 16:11:51 +0200 (Mon, 19 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Don't delay menu item fixup when the number of tabs change.
BUG=24878
TEST=cmd-w/cmd-shift-w are always correct for close-tab/close-window when window layering changes.
Review URL: http://codereview.chromium.org/283017
------------------------------------------------------------------------
r29396 | thakis@chromium.org | 2009-10-19 16:00:26 +0200 (Mon, 19 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm
   M /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Short-circuit events rwhvmac if it's focussed.

This way the key view loop can't steal our events. This effectively reverts part of http://codereview.chromium.org/242069 and instead takes a bit from http://codereview.chromium.org/271054 .

BUG=24921
TEST=Open 2 tabs. Focus web. Ctrl-tab should switch tabs. Cmd-1/2 should switch tabs. Hitting backspace should go back if no textbox is focusses in the web, else it should delete in the textbox. Hitting cmd-f in docs should still open docs custom search interface.

Review URL: http://codereview.chromium.org/300002
------------------------------------------------------------------------
r29388 | thakis@chromium.org | 2009-10-19 05:13:31 +0200 (Mon, 19 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/ime_input.cc
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_mac.mm

Make backspace not go back while IME is active.

Linux does this in GtkIMContextWrapper::ProcessFilteredKeyPressEvent() by setting hardware_keycode to 0. It's a pain to change an NSEvent, so I just added a bool "skip" to NativeWebKeybordEvent and set it to "true" for rawkeydowns while ime is active.

BUG=25000
TEST=Open webpage. Focus text field. Type something, hit backspace. Text should be deleted. Focus background, hit backspace. Browser should go back one page. Focus text field, start IME (either by going to syspref->international->input menu and enabling e.g. "Kotoeri" and then selecting this in the top right corner and typing a single "a", or by just activating dead key ime on an us layout by hitting opt-u, opt-i, or opt-e), hit backspace. Browser should not go back but end IME mode.

Review URL: http://codereview.chromium.org/295003
------------------------------------------------------------------------
r29387 | suzhe@chromium.org | 2009-10-19 04:52:28 +0200 (Mon, 19 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc


BUG=23107 Last character of completed path in Omnibar is the wrong color after inline autocomplete
BUG=24818 Funky behavior in omnibar editing
TEST=Run chromium with a clean profile, then access go/go (or similar url) for several times to make sure inputting 'g' can trigger inline autocomplete. Then input "go/go" and then check if the last char is gray.
TEST=Input something into omnibox to trigger inline autocomplete, then press ctrl-right and hold ctrl key, to move the cursor and clear the text selection, then release ctrl key, the text added by inline autocomplete should not be removed.

Review URL: http://codereview.chromium.org/287005
------------------------------------------------------------------------
r29382 | dmaclach@chromium.org | 2009-10-19 02:22:15 +0200 (Mon, 19 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Clean up use of scoped_nsobject<NSAutoreleasePool>. I have a CL coming later
that will protect us against these in the future.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/283026
------------------------------------------------------------------------
r29376 | erikkay@chromium.org | 2009-10-17 15:54:57 +0200 (Sat, 17 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/test/data/extensions/samples/override_igoogle
   A /trunk/src/chrome/test/data/extensions/samples/override_igoogle/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/override_igoogle/redirect.html

Fix chrome_url_overides to work with packed extensions.
The InitFromValue code was modifying the JSON with some local data which
was then being re-used by the unpacker and sent up to the browser which
caused it to use this temporary local data as if it was the original
manifest source.

BUG=24398
TEST=pack and install override_igoogle extension

Review URL: http://codereview.chromium.org/276074
------------------------------------------------------------------------
r29368 | nick@chromium.org | 2009-10-17 04:04:06 +0200 (Sat, 17 Oct 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/sync/test_http_bridge_factory.h

Fix ProfileSyncService unit test.

Create TestHttpBridge for use by ProfileSyncServiceUnittest, so it
doesn't crash.

DoInitialize has been changed to take a HttpPostProviderFactory
before the core initialization.  The HttpBridge is now created
on the UI thread instead of the core thread.

Create fake tagged nodes in the order that they are requested.

Make the request order consistent and in visual order since this is the
most natural way to request them.

TEST=Ran the affected unit tests on Windows, tested basic sync functionality with two concurrent browsers.
BUG=25021

Review URL: http://codereview.chromium.org/292008
------------------------------------------------------------------------
r29367 | wtc@chromium.org | 2009-10-17 03:33:26 +0200 (Sat, 17 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/webkit/glue/media/buffered_data_source_unittest.cc

Set os_error to net::ERR_ABORTED instead of 0 or net::ERR_FAILED when
we set the status of a URLRequestStatus to URLRequestStatus::CANCELED.

R=eroman
BUG=24674
TEST=none
Review URL: http://codereview.chromium.org/269064
------------------------------------------------------------------------
r29365 | aa@chromium.org | 2009-10-17 03:03:26 +0200 (Sat, 17 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/test/data/extensions/samples/icon_size_test
   A /trunk/src/chrome/test/data/extensions/samples/icon_size_test/icon.png
   A /trunk/src/chrome/test/data/extensions/samples/icon_size_test/manifest.json

Allow slightly larger browser and page action icons.

This allows 19px icons to be able to be used for both
browser and page icons.

I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome,
but some Chrome location bar icons use 18px for soft edges,
so I guess this will just have to be something we advise
developers on.

We can actually fit up to 21 (whoa nelly) pixels on Windows,
but apparently the space is slightly smaller on mac.

Also minor layout fix. We were sizing the browser action
buttons 1px too short.

BUG=24881
TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space.

Review URL: http://codereview.chromium.org/286001
------------------------------------------------------------------------
r29362 | estade@chromium.org | 2009-10-17 02:28:55 +0200 (Sat, 17 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.h

Linux: Make theme install bubble prettier (for compositing WMs)

BUG=none
TEST=screenshot

Review URL: http://codereview.chromium.org/289004
------------------------------------------------------------------------
r29361 | estade@chromium.org | 2009-10-17 02:28:41 +0200 (Sat, 17 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Use the proper extension id when creating browser action buttons.

BUG=25066
TEST=none

Review URL: http://codereview.chromium.org/274083
------------------------------------------------------------------------
r29360 | nick@chromium.org | 2009-10-17 02:28:13 +0200 (Sat, 17 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc
   M /trunk/src/chrome/browser/sync/notifier/base/fastalloc.h
   M /trunk/src/chrome/browser/sync/notifier/base/nethelpers.h
   M /trunk/src/chrome/browser/sync/notifier/base/time.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/mailbox.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/mailbox.h
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/inet_aton.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.h
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters_unittest.cc
   M /trunk/src/chrome/browser/sync/util/compat_file.h
   M /trunk/src/chrome/browser/sync/util/compat_file_posix.cc
   M /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc
   M /trunk/src/chrome/browser/sync/util/highres_timer_unittest.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_unittest.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.cc
   M /trunk/src/chrome/browser/sync/util/sync_types.h
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   M /trunk/src/chrome/test/live_sync/single_client_live_bookmarks_sync_unittest.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Rename CHROME_PERSONALIZATION to BROWSER_SYNC.

Avoid #ifdef in general, favoring #if defined().

In one spot, use PlatformThread::Sleep instead of rolling our own.

Review URL: http://codereview.chromium.org/267125
------------------------------------------------------------------------
r29357 | chron@chromium.org | 2009-10-17 01:45:49 +0200 (Sat, 17 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h

Fix sync bug where notifications were being sent for unsuccessful commit attempts.

BUG=24996
TEST=Manually tested

Review URL: http://codereview.chromium.org/284008
------------------------------------------------------------------------
r29355 | abarth@chromium.org | 2009-10-17 01:33:57 +0200 (Sat, 17 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Sniff 204 responses as text/plain to avoid creating unwanted downloads.

BUG=24391
TEST=ResourceDispatcherHostTest.MimeSniff204

Review URL: http://codereview.chromium.org/274075
------------------------------------------------------------------------
r29354 | estade@chromium.org | 2009-10-17 01:32:08 +0200 (Sat, 17 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

[GTK] Remove an unused variable in bookmark_manager_gtk.cc. 

BUG=None 
TEST=None

patch by Thiago Farina
original review: http://codereview.chromium.org/268040/show

Review URL: http://codereview.chromium.org/290004
------------------------------------------------------------------------
r29353 | estade@chromium.org | 2009-10-17 01:24:29 +0200 (Sat, 17 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: properly resize bookmark bar when going from attached to detached on NTP fullscreen.

BUG=24463

Review URL: http://codereview.chromium.org/287015
------------------------------------------------------------------------
r29350 | tim@chromium.org | 2009-10-17 01:00:24 +0200 (Sat, 17 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

If chrome starts without a network connection, the sync serverconnectionmanager won't get an auth_token set until
the Authenticator validates it.  We had a bug where when we come online and the server connection manager determines
that a server is reachable, we would drop the request to authenticate (which is the first step in getting the auth token
set properly).  This was resulting in subsequent requests returning 401 UNAUTHORIZED, and sync getting stuck in an offline
state.

The fix is to set the auth token on startup, so the gaia authenticator and server connection manager start off on the same
page.

BUG=24973
TEST=setup sync, shutdown chrome. ipconfig /release, start chrome, ipconfig /renew. about:sync shoudl show 'READY'.

Review URL: http://codereview.chromium.org/285008
------------------------------------------------------------------------
r29349 | shess@chromium.org | 2009-10-17 00:59:23 +0200 (Sat, 17 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm

[Mac] Log some NSException info with crash dumps.

Adds two breakpad keys.  "firstexception" will store the name and
reason for the first NSException caught by the event loop.
"lastexception" will store the same for the last one seen before
crashing.

http://crbug.com/24462
TEST=Hard to test without known exceptions to handle.

Review URL: http://codereview.chromium.org/275008
------------------------------------------------------------------------
r29346 | estade@chromium.org | 2009-10-17 00:35:43 +0200 (Sat, 17 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h

GTK: disable theme buttons in options dialog when we are already using that theme.

BUG=18585
TEST=clicking

Review URL: http://codereview.chromium.org/289007
------------------------------------------------------------------------
r29343 | sky@chromium.org | 2009-10-17 00:28:44 +0200 (Sat, 17 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   M /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc

Makes canceling 'bookmark all tabs' delete the folder. Or rather,
makes it so that bookmark all tabs only creates the folder if the user
presses ok. I wasn't happy adding another random arg to
BookmarkEditor::Show, so I added in a structure an enum. This makes it
clearer what Show should do.

I also fixed the following:
. On gtk we wouldn't always pick the right parent for nodes.
. The context menu item is now enabled on views/gtk.

And this now breaks the mac side. I'll straighten that out right after
landing this.

BUG=24367
TEST=Make sure 'bookmark all tabs' works, as well as the bookmark
editor work. (get to the bookmark editor by creating a new bookmark,
then clicking edit, or right clicking a bookmark on the bookmark bar and
choosing edit).

Review URL: http://codereview.chromium.org/271115
------------------------------------------------------------------------
r29339 | tim@chromium.org | 2009-10-17 00:13:52 +0200 (Sat, 17 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Always re-layout the app menu to get sync system state.

BUG=25103
TEST=Start chrome, verify app menu says 'Synchronize my bookmarks...'.
Click it, and set up sync. Reopen app menu, and it should say 'Bookmarks synced...'

Review URL: http://codereview.chromium.org/274078
------------------------------------------------------------------------
r29337 | rvargas@google.com | 2009-10-17 00:07:38 +0200 (Sat, 17 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/net/http/http_cache.cc

Http Cache: Enable byte-range support by default.

The command line parameter to modify the behavior changes from
--enable-byte-range-support
to
--disable-byte-range-support

BUG=24989
TEST= current tests


Review URL: http://codereview.chromium.org/267132
------------------------------------------------------------------------
r29335 | mpcomplete@chromium.org | 2009-10-16 23:53:46 +0200 (Fri, 16 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   A /trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/pageAction.html
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/page_action
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/update.html
   A /trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html
   A /trunk/src/chrome/test/data/extensions/samples/test_page_action
   A /trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html
   A /trunk/src/chrome/test/data/extensions/samples/test_page_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/test_page_action/print_16x16.png

Implement new page action API.

Still no actual drawing code for badges, though.

BUG=24635
TEST=Load the sample test_page_action extension and click the page action to cycle through various states.

Review URL: http://codereview.chromium.org/269079
------------------------------------------------------------------------
r29333 | oshima@chromium.org | 2009-10-16 23:49:19 +0200 (Fri, 16 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/browser_extender.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fixes crash in toolkit_views. The problem with the current code is
that it assumed browser->window() was non-null, but with toolkit_views
this ends up being called before window has been assigned.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/290002
------------------------------------------------------------------------
r29317 | pkasting@chromium.org | 2009-10-16 21:49:22 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Classify more types of input as queries.

This adds an oracle that can determine if a hostname is RFC 1738 compliant; if we get a hostname that's not an IP address and not compliant here, we almost certainly have a query.

This also rejects "ports" that don't consist of a number between 0 and 65535 (e.g. port "abc" or port "123456").

BUG=18817
TEST=The string "foo: bar" (with quotes) should default to search, not navigate, in the address bar.
Review URL: http://codereview.chromium.org/271116
------------------------------------------------------------------------
r29314 | arv@chromium.org | 2009-10-16 21:47:41 +0200 (Fri, 16 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/common/jstemplate_builder.cc

NTP: Fix startup visual state 

This inject the template data earlier in the document so that we can set
the initial visual state based on the user preference. This prevents
flickering when the user is not showing the most visited thumbnails.

BUG=24513

TEST=Use a theme with a background image to make this easier to spot.
Hide the most visited. Restart Chrome. The thumbnails should not flicker

Review URL: http://codereview.chromium.org/269095
------------------------------------------------------------------------
r29311 | mark@chromium.org | 2009-10-16 21:37:29 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

Make Mac SelectFileDialogImpl load SaveAccessoryView.nib from the proper
bundle.

BUG=24923
TEST=File:Save Page As… should work and offer a Format pop-up menu
Review URL: http://codereview.chromium.org/285003
------------------------------------------------------------------------
r29309 | thomasvl@chromium.org | 2009-10-16 21:35:59 +0200 (Fri, 16 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm

Bookmark bubble tweaks
TitleCase the other folder menu options.
Use the helper that handles ellipsis.

TEST=the other folder option is title case
BUG=24912
Review URL: http://codereview.chromium.org/276065
------------------------------------------------------------------------
r29308 | nick@chromium.org | 2009-10-16 21:32:37 +0200 (Fri, 16 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc

Remove a dcheck that had a signed/unsigned warning.

Fix the mac build (sync is enabled by default on Mac!)

R=munjal

Review URL: http://codereview.chromium.org/291002
------------------------------------------------------------------------
r29307 | nick@chromium.org | 2009-10-16 21:16:36 +0200 (Fri, 16 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc

Use a multiset rather than a set to store bookmarks when running the model associator merge.

For cases where there's an exact duplicate URL and title,
this allows each BookmarkNode a chance to be associated
with a sync node.  With a set, we'd forget about all
but one of the duplicates, resulting in the creation
of yet more duplicates.  The result was exponential
growth with each merge and sync.

BUG=24995
TEST=

Review URL: http://codereview.chromium.org/288001
------------------------------------------------------------------------
r29306 | sky@chromium.org | 2009-10-16 21:14:08 +0200 (Fri, 16 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/chrome.gyp

Adds bookmark context menu test to set of unit_tests run on
toolkit_views build.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/284014
------------------------------------------------------------------------
r29297 | asargent@chromium.org | 2009-10-16 20:34:28 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/options.crx

Add concept of an options page to Extensions.


BUG=23801
TEST=Create an extension with an "options_page" entry in its manifest with a value the name of a html file in the extension dir.
Load that extension and go to chrome://extensions, there should be an "Options" button that takes you to the page specified in the manifest.


Review URL: http://codereview.chromium.org/271114
------------------------------------------------------------------------
r29295 | mark@chromium.org | 2009-10-16 20:32:50 +0200 (Fri, 16 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resources/app_locale_settings.grd
   M /trunk/src/app/resources/app_locale_settings_am.xtb
   M /trunk/src/app/resources/app_locale_settings_ar.xtb
   M /trunk/src/app/resources/app_locale_settings_bg.xtb
   M /trunk/src/app/resources/app_locale_settings_bn.xtb
   M /trunk/src/app/resources/app_locale_settings_ca.xtb
   M /trunk/src/app/resources/app_locale_settings_cs.xtb
   M /trunk/src/app/resources/app_locale_settings_da.xtb
   M /trunk/src/app/resources/app_locale_settings_de.xtb
   M /trunk/src/app/resources/app_locale_settings_el.xtb
   M /trunk/src/app/resources/app_locale_settings_en-GB.xtb
   M /trunk/src/app/resources/app_locale_settings_es-419.xtb
   M /trunk/src/app/resources/app_locale_settings_es.xtb
   M /trunk/src/app/resources/app_locale_settings_et.xtb
   M /trunk/src/app/resources/app_locale_settings_fi.xtb
   M /trunk/src/app/resources/app_locale_settings_fil.xtb
   M /trunk/src/app/resources/app_locale_settings_fr.xtb
   M /trunk/src/app/resources/app_locale_settings_gu.xtb
   M /trunk/src/app/resources/app_locale_settings_he.xtb
   M /trunk/src/app/resources/app_locale_settings_hi.xtb
   M /trunk/src/app/resources/app_locale_settings_hr.xtb
   M /trunk/src/app/resources/app_locale_settings_hu.xtb
   M /trunk/src/app/resources/app_locale_settings_id.xtb
   M /trunk/src/app/resources/app_locale_settings_it.xtb
   M /trunk/src/app/resources/app_locale_settings_ja.xtb
   M /trunk/src/app/resources/app_locale_settings_kn.xtb
   M /trunk/src/app/resources/app_locale_settings_ko.xtb
   M /trunk/src/app/resources/app_locale_settings_lt.xtb
   M /trunk/src/app/resources/app_locale_settings_lv.xtb
   M /trunk/src/app/resources/app_locale_settings_ml.xtb
   M /trunk/src/app/resources/app_locale_settings_mr.xtb
   M /trunk/src/app/resources/app_locale_settings_nb.xtb
   M /trunk/src/app/resources/app_locale_settings_nl.xtb
   M /trunk/src/app/resources/app_locale_settings_or.xtb
   M /trunk/src/app/resources/app_locale_settings_pl.xtb
   M /trunk/src/app/resources/app_locale_settings_pt-BR.xtb
   M /trunk/src/app/resources/app_locale_settings_pt-PT.xtb
   M /trunk/src/app/resources/app_locale_settings_ro.xtb
   M /trunk/src/app/resources/app_locale_settings_ru.xtb
   M /trunk/src/app/resources/app_locale_settings_sk.xtb
   M /trunk/src/app/resources/app_locale_settings_sl.xtb
   M /trunk/src/app/resources/app_locale_settings_sr.xtb
   M /trunk/src/app/resources/app_locale_settings_sv.xtb
   M /trunk/src/app/resources/app_locale_settings_sw.xtb
   M /trunk/src/app/resources/app_locale_settings_ta.xtb
   M /trunk/src/app/resources/app_locale_settings_te.xtb
   M /trunk/src/app/resources/app_locale_settings_th.xtb
   M /trunk/src/app/resources/app_locale_settings_tr.xtb
   M /trunk/src/app/resources/app_locale_settings_uk.xtb
   M /trunk/src/app/resources/app_locale_settings_vi.xtb
   M /trunk/src/app/resources/app_locale_settings_zh-CN.xtb
   M /trunk/src/app/resources/app_locale_settings_zh-TW.xtb
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/app/resources/app_strings.grd
   M /trunk/src/app/resources/app_strings_am.xtb
   M /trunk/src/app/resources/app_strings_ar.xtb
   M /trunk/src/app/resources/app_strings_bg.xtb
   M /trunk/src/app/resources/app_strings_bn.xtb
   M /trunk/src/app/resources/app_strings_ca.xtb
   M /trunk/src/app/resources/app_strings_cs.xtb
   M /trunk/src/app/resources/app_strings_da.xtb
   M /trunk/src/app/resources/app_strings_de.xtb
   M /trunk/src/app/resources/app_strings_el.xtb
   M /trunk/src/app/resources/app_strings_en-GB.xtb
   M /trunk/src/app/resources/app_strings_es-419.xtb
   M /trunk/src/app/resources/app_strings_es.xtb
   M /trunk/src/app/resources/app_strings_et.xtb
   M /trunk/src/app/resources/app_strings_fi.xtb
   M /trunk/src/app/resources/app_strings_fil.xtb
   M /trunk/src/app/resources/app_strings_fr.xtb
   M /trunk/src/app/resources/app_strings_gu.xtb
   M /trunk/src/app/resources/app_strings_he.xtb
   M /trunk/src/app/resources/app_strings_hi.xtb
   M /trunk/src/app/resources/app_strings_hr.xtb
   M /trunk/src/app/resources/app_strings_hu.xtb
   M /trunk/src/app/resources/app_strings_id.xtb
   M /trunk/src/app/resources/app_strings_it.xtb
   M /trunk/src/app/resources/app_strings_ja.xtb
   M /trunk/src/app/resources/app_strings_kn.xtb
   M /trunk/src/app/resources/app_strings_ko.xtb
   M /trunk/src/app/resources/app_strings_lt.xtb
   M /trunk/src/app/resources/app_strings_lv.xtb
   M /trunk/src/app/resources/app_strings_ml.xtb
   M /trunk/src/app/resources/app_strings_mr.xtb
   M /trunk/src/app/resources/app_strings_nl.xtb
   M /trunk/src/app/resources/app_strings_no.xtb
   M /trunk/src/app/resources/app_strings_or.xtb
   M /trunk/src/app/resources/app_strings_pl.xtb
   M /trunk/src/app/resources/app_strings_pt-BR.xtb
   M /trunk/src/app/resources/app_strings_pt-PT.xtb
   M /trunk/src/app/resources/app_strings_ro.xtb
   M /trunk/src/app/resources/app_strings_ru.xtb
   M /trunk/src/app/resources/app_strings_sk.xtb
   M /trunk/src/app/resources/app_strings_sl.xtb
   M /trunk/src/app/resources/app_strings_sr.xtb
   M /trunk/src/app/resources/app_strings_sv.xtb
   M /trunk/src/app/resources/app_strings_sw.xtb
   M /trunk/src/app/resources/app_strings_ta.xtb
   M /trunk/src/app/resources/app_strings_te.xtb
   M /trunk/src/app/resources/app_strings_th.xtb
   M /trunk/src/app/resources/app_strings_tr.xtb
   M /trunk/src/app/resources/app_strings_uk.xtb
   M /trunk/src/app/resources/app_strings_vi.xtb
   M /trunk/src/app/resources/app_strings_zh-CN.xtb
   M /trunk/src/app/resources/app_strings_zh-TW.xtb
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/resources/generated_resources_am.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ar.xtb
   M /trunk/src/chrome/app/resources/generated_resources_bg.xtb
   M /trunk/src/chrome/app/resources/generated_resources_bn.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ca.xtb
   M /trunk/src/chrome/app/resources/generated_resources_cs.xtb
   M /trunk/src/chrome/app/resources/generated_resources_da.xtb
   M /trunk/src/chrome/app/resources/generated_resources_de.xtb
   M /trunk/src/chrome/app/resources/generated_resources_el.xtb
   M /trunk/src/chrome/app/resources/generated_resources_en-GB.xtb
   M /trunk/src/chrome/app/resources/generated_resources_es-419.xtb
   M /trunk/src/chrome/app/resources/generated_resources_es.xtb
   M /trunk/src/chrome/app/resources/generated_resources_et.xtb
   M /trunk/src/chrome/app/resources/generated_resources_fi.xtb
   M /trunk/src/chrome/app/resources/generated_resources_fil.xtb
   M /trunk/src/chrome/app/resources/generated_resources_fr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_gu.xtb
   M /trunk/src/chrome/app/resources/generated_resources_he.xtb
   M /trunk/src/chrome/app/resources/generated_resources_hi.xtb
   M /trunk/src/chrome/app/resources/generated_resources_hr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_hu.xtb
   M /trunk/src/chrome/app/resources/generated_resources_id.xtb
   M /trunk/src/chrome/app/resources/generated_resources_it.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ja.xtb
   M /trunk/src/chrome/app/resources/generated_resources_kn.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ko.xtb
   M /trunk/src/chrome/app/resources/generated_resources_lt.xtb
   M /trunk/src/chrome/app/resources/generated_resources_lv.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ml.xtb
   M /trunk/src/chrome/app/resources/generated_resources_mr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_nl.xtb
   M /trunk/src/chrome/app/resources/generated_resources_no.xtb
   M /trunk/src/chrome/app/resources/generated_resources_or.xtb
   M /trunk/src/chrome/app/resources/generated_resources_pl.xtb
   M /trunk/src/chrome/app/resources/generated_resources_pt-BR.xtb
   M /trunk/src/chrome/app/resources/generated_resources_pt-PT.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ro.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ru.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sk.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sl.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sv.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sw.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ta.xtb
   M /trunk/src/chrome/app/resources/generated_resources_te.xtb
   M /trunk/src/chrome/app/resources/generated_resources_th.xtb
   M /trunk/src/chrome/app/resources/generated_resources_tr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_uk.xtb
   M /trunk/src/chrome/app/resources/generated_resources_vi.xtb
   M /trunk/src/chrome/app/resources/generated_resources_zh-CN.xtb
   M /trunk/src/chrome/app/resources/generated_resources_zh-TW.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_am.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ar.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_bg.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_bn.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ca.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_cs.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_da.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_de.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_el.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_en-GB.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_es-419.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_es.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_et.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_fi.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_fil.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_fr.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_gu.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_he.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_hi.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_hr.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_hu.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_id.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_it.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ja.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_kn.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ko.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_lt.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_lv.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ml.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_mr.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_nl.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_no.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_or.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_pl.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ro.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ru.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_sk.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_sl.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_sr.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_sv.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_sw.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_ta.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_te.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_th.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_tr.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_uk.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_vi.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/google_chrome_strings_zh-TW.xtb
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_am.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome_frame/resources/chrome_frame_resources.grd
   M /trunk/src/chrome_frame/resources/chrome_frame_strings.grd
   M /trunk/src/net/base/net_resources.grd
   M /trunk/src/webkit/glue/devtools_strings.grd
   M /trunk/src/webkit/glue/inspector_strings.grd
   M /trunk/src/webkit/glue/resources/webkit_strings_am.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ar.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_bg.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_bn.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ca.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_cs.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_da.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_de.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_el.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_en-GB.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_es-419.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_es.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_et.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_fi.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_fil.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_fr.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_gu.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_he.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_hi.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_hr.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_hu.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_id.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_it.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ja.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_kn.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ko.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_lt.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_lv.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ml.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_mr.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_nl.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_no.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_or.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_pl.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_pt-BR.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_pt-PT.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ro.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ru.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_sk.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_sl.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_sr.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_sv.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_sw.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_ta.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_te.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_th.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_tr.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_uk.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_vi.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_zh-CN.xtb
   M /trunk/src/webkit/glue/resources/webkit_strings_zh-TW.xtb
   M /trunk/src/webkit/glue/webkit_resources.grd
   M /trunk/src/webkit/glue/webkit_strings.grd
   M /trunk/src/webkit/tools/test_shell/test_shell_resources.grd

Set svn:eol-style = LF on .grd and .xtb files

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/264078
------------------------------------------------------------------------
r29294 | finnur@chromium.org | 2009-10-16 20:20:15 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Marking the ParseFeed as flaky again.

This makes me very sad... :(

TBR=nsylvain
BUG=23686
TEST=None

Review URL: http://codereview.chromium.org/283015
------------------------------------------------------------------------
r29289 | jcampan@chromium.org | 2009-10-16 18:50:37 +0200 (Fri, 16 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

A recent change to the way we close tabs (http://codereview.chromium.org/235050)
causes Browser::CanCloseContentsAt() to be called several times for the same tab.
This was triggering a DCHECK in the "download in progress" warning.

BUG=24974
TEST=See bug. Test thoroughly the "dowload in progress" warning: start a big
     download, then close Chrome (by closing all tabs, by using the top window
     close button). Make sure both behaviors (continue/abort closing) work as 
     expected.

Review URL: http://codereview.chromium.org/273076
------------------------------------------------------------------------
r29288 | cmasone@google.com | 2009-10-16 18:29:52 +0200 (Fri, 16 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc

Implementations of net::CookieStore are supposed to use thread-safe ref counting.  My MockCookieStore objects were just statically allocated and destroyed, so it wasn't a problem, but doing things with a scoped_refptr and obeying the newly-implemented checks is more fool-proof.

Review URL: http://codereview.chromium.org/273078
------------------------------------------------------------------------
r29287 | finnur@chromium.org | 2009-10-16 18:10:01 +0200 (Fri, 16 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Landing patch from Thiago Farina:

[Windows] Make the order of the buttons of Languages Tab to match with the Linux version. 

BUG=None 
TEST=compiled and tested on windows. 

Originally review as:  http://codereview.chromium.org/269019


------------------------------------------------------------------------
r29285 | finnur@chromium.org | 2009-10-16 17:57:41 +0200 (Fri, 16 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Getting rid of the final flakiness in the ParseFeed test.

TBR=jcampan
BUG=23686
TEST=These are modifications to a browser test.

Review URL: http://codereview.chromium.org/285001
------------------------------------------------------------------------
r29281 | rohitrao@chromium.org | 2009-10-16 17:35:38 +0200 (Fri, 16 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/test_event_utils.h
   M /trunk/src/chrome/browser/cocoa/test_event_utils.mm

[Mac] Eat mouse clicks in the findbar to prevent them from falling through to views below.

BUG=http://crbug.com/22854
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/273041
------------------------------------------------------------------------
r29280 | avi@chromium.org | 2009-10-16 17:35:37 +0200 (Fri, 16 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm

Fix logic test in "remember my choice" dialog for protocols.

BUG=http://crbug.com/25035
TEST=as in bug


Review URL: http://codereview.chromium.org/283011
------------------------------------------------------------------------
r29279 | phajdan.jr@chromium.org | 2009-10-16 17:26:16 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/base/condition_variable_unittest.cc
   M /trunk/src/base/timer_unittest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/net/disk_cache/backend_unittest.cc

Mark some disabled tests as flaky to increase test coverage.

When a test doesn't hang or crash, it can run on the bots
and on developers' machines.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/269104
------------------------------------------------------------------------
r29276 | sky@chromium.org | 2009-10-16 17:15:39 +0200 (Fri, 16 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc

Lands http://codereview.chromium.org/276054 for sosa:

Remove dependency to browser_window

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/274074
------------------------------------------------------------------------
r29275 | thomasvl@chromium.org | 2009-10-16 17:02:43 +0200 (Fri, 16 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Test has failed a few times in the current waterfall display.  The bug that enabled it is still open, so tagging it to that bug and just marking as flaky.

TEST=none
BUG=20809
Review URL: http://codereview.chromium.org/276060
------------------------------------------------------------------------
r29274 | erikkay@chromium.org | 2009-10-16 16:57:25 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/extensions/api_test/popup
   A /trunk/src/chrome/test/data/extensions/api_test/popup/chromium.png
   A /trunk/src/chrome/test/data/extensions/api_test/popup/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/popup/popup.html
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/popup.html

Popup width and height are now dynamic.

BUG=24471
TEST=none

Review URL: http://codereview.chromium.org/273046
------------------------------------------------------------------------
r29271 | thomasvl@chromium.org | 2009-10-16 16:20:07 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Flagging as flaky again, they like to fail with some frequency on Chromium XP but not the testers.

TBR=finnur@chromium.org
TEST=none
BUG=23686
Review URL: http://codereview.chromium.org/284011
------------------------------------------------------------------------
r29270 | thakis@chromium.org | 2009-10-16 16:15:16 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm

Disable backspace until I have fixed it in IME mode.

BUG=25000
TEST=hit opt-u backspace. Browser should not go back a page. Browser should in fact never go back when you hit backspace.

Review URL: http://codereview.chromium.org/288002
------------------------------------------------------------------------
r29269 | avi@chromium.org | 2009-10-16 16:13:35 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm

Fix Mac theme provider so it returns nil when there is no theme provided color. Partial revert of r28560.

BUG=http://crbug.com/24551
TEST=as in bug

Review URL: http://codereview.chromium.org/274069
------------------------------------------------------------------------
r29267 | avi@chromium.org | 2009-10-16 16:07:59 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Keep the "place bookmarks here" text vertically centered on the Mac.

BUG=http://crbug.com/24934
TEST=the text should be vertically centered always:
- confirm text is vertically centered when bookmark bar is visible
- confirm text is vertically centered when bookmark bar is set to "not visible"
but on the new tab page so it is floating

Review URL: http://codereview.chromium.org/281009
------------------------------------------------------------------------
r29263 | akalin@chromium.org | 2009-10-16 12:32:04 +0200 (Fri, 16 Oct 2009) | 17 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gfx/font_util.cc
   A /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc:29262)
   A /trunk/src/chrome/browser/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.h:29262)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc:29262)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h:29262)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc:29262)
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Made sync code build and pass unit tests on OS X.

Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.

BUG=23073
TEST=trybot

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258

Review URL: http://codereview.chromium.org/279004
------------------------------------------------------------------------
r29259 | akalin@chromium.org | 2009-10-16 09:58:54 +0200 (Fri, 16 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/app/app.gyp
   D /trunk/src/app/gfx/font_util.cc
   D /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   D /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/sync/sync_setup_flow.cc:29258)
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/sync/sync_setup_flow.h:29258)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard.cc:29258)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/sync/sync_setup_wizard.h:29258)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc:29258)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Reverted 29258.

TBR: nick@chromium.org
------------------------------------------------------------------------
r29258 | akalin@chromium.org | 2009-10-16 09:33:29 +0200 (Fri, 16 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gfx/font_util.cc
   A /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc:29256)
   A /trunk/src/chrome/browser/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.h:29256)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc:29256)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h:29256)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc:29256)
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/third_party/libjingle/files/talk/base/autodetectproxy.cc
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Made sync code build and pass unit tests on OS X.

Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.

BUG=23073
TEST=trybot

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255

Review URL: http://codereview.chromium.org/279004
------------------------------------------------------------------------
r29257 | nick@chromium.org | 2009-10-16 09:11:02 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc

Fix a crash in incognito mode when clicking the wrench menu.

This was a regression recent sync UI changes.  This fixes the regression to match the old incognito mode behavior.

TBR=tim@chromium.org
BUG=25014
TEST=See bug.  It doesn't crash anymore.

Review URL: http://codereview.chromium.org/283008
------------------------------------------------------------------------
r29256 | akalin@chromium.org | 2009-10-16 09:05:52 +0200 (Fri, 16 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/app/app.gyp
   D /trunk/src/app/gfx/font_util.cc
   D /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   D /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/sync/sync_setup_flow.cc:29255)
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/sync/sync_setup_flow.h:29255)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard.cc:29255)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/sync/sync_setup_wizard.h:29255)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc:29255)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Reverted 29255.

TBR: nick@chromium.org
------------------------------------------------------------------------
r29255 | akalin@chromium.org | 2009-10-16 08:48:32 +0200 (Fri, 16 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gfx/font_util.cc
   A /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc:29254)
   A /trunk/src/chrome/browser/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.h:29254)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc:29254)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h:29254)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc:29254)
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Made sync code build and pass unit tests on OS X.

Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.

BUG=23073
TEST=trybot

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253

Review URL: http://codereview.chromium.org/279004
------------------------------------------------------------------------
r29254 | akalin@chromium.org | 2009-10-16 08:17:54 +0200 (Fri, 16 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/app/app.gyp
   D /trunk/src/app/gfx/font_util.cc
   D /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   D /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/sync/sync_setup_flow.cc:29253)
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/sync/sync_setup_flow.h:29253)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard.cc:29253)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/sync/sync_setup_wizard.h:29253)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc:29253)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Reverted 29253.

TBR: nick@chromium.org
------------------------------------------------------------------------
r29253 | akalin@chromium.org | 2009-10-16 07:52:33 +0200 (Fri, 16 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gfx/font_util.cc
   A /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc:29240)
   A /trunk/src/chrome/browser/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.h:29240)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc:29240)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h:29240)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc:29240)
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Made sync code build and pass unit tests on OS X.

Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.

BUG=23073
TEST=trybot

Review URL: http://codereview.chromium.org/279004
------------------------------------------------------------------------
r29244 | darin@chromium.org | 2009-10-16 05:53:39 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/api/public/WebView.h
   M /trunk/src/webkit/api/public/WebViewClient.h
   M /trunk/src/webkit/glue/autofill_form.cc
   M /trunk/src/webkit/glue/autofill_form.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener.h
   M /trunk/src/webkit/glue/password_autocomplete_listener_unittest.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Move autofill related WebView{Delegate} methods into the WebKit API.

This CL also changes a bunch of autofill related wstring values to string16.

R=jcampan
BUG=24595
TEST=none

Review URL: http://codereview.chromium.org/279001
------------------------------------------------------------------------
r29243 | tim@chromium.org | 2009-10-16 05:33:42 +0200 (Fri, 16 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html

Fix 'Create an account' and 'Help' links on gaia login dialog.

BUG=19918,21509
Review URL: http://codereview.chromium.org/267135
------------------------------------------------------------------------
r29240 | akalin@chromium.org | 2009-10-16 04:43:28 +0200 (Fri, 16 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/app/app.gyp
   D /trunk/src/app/gfx/font_util.cc
   D /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   D /trunk/src/chrome/browser/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/sync/sync_setup_flow.cc:29239)
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/sync/sync_setup_flow.h:29239)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard.cc:29239)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/sync/sync_setup_wizard.h:29239)
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc:29239)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

TBR: nick@chromium.org
------------------------------------------------------------------------
r29239 | akalin@chromium.org | 2009-10-16 04:22:16 +0200 (Fri, 16 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gfx/font_util.cc
   A /trunk/src/app/gfx/font_util.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/sync_setup_flow.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc:29232)
   A /trunk/src/chrome/browser/sync/sync_setup_flow.h (from /trunk/src/chrome/browser/views/sync/sync_setup_flow.h:29232)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc:29232)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard.h (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h:29232)
   A /trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc (from /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc:29232)
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   D /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Made sync code build and pass unit tests on OS X.

Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.

BUG=23073
TEST=trybot

Review URL: http://codereview.chromium.org/279004
------------------------------------------------------------------------
r29236 | tim@chromium.org | 2009-10-16 03:31:55 +0200 (Fri, 16 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h

Hook up ClientToServerResponse::THROTTLED to the client sync loop.

TEST=Added SyncerThreadWithSyncerTest.Throttling

Review URL: http://codereview.chromium.org/269101
------------------------------------------------------------------------
r29234 | hclam@chromium.org | 2009-10-16 03:22:33 +0200 (Fri, 16 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc

Removing a synchronous pause that reduces impact on the IO thread

Audio pause is implemented synchronously in the browser process.
This can easily choke the IO thread when user does a series of
pause of looping a very short audio / video. This change will
make the pause action asynchronous. The drawback of this change
is that we cannot stop audio playback immediately as we receive
the pause request.

This is still an improvement over chrome 3.0 as the "playback"
period after pause is noticably shorter.

Review URL: http://codereview.chromium.org/279010
------------------------------------------------------------------------
r29233 | pkasting@chromium.org | 2009-10-16 03:02:58 +0200 (Fri, 16 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Fix an erroneous set of tab change notifications sent whenever closing a tab before the current one.  GetSelectedTabContents() was using the old |selected_index_|, which was no longer the selected tab, leading to bogus notifications, which in turn caused other problems.

BUG=16753
TEST=Open Chrome.  Hit ctrl-t twice.  Type a few letters.  Middle click the tab to the left of the current tab (the first "New Tab" you opened).  Your typing should not disappear.
Review URL: http://codereview.chromium.org/276052
------------------------------------------------------------------------
r29229 | thakis@chromium.org | 2009-10-16 02:53:06 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Let cmd-` switch windows again.

BUG=24817
TEST=Open three windows. Focus web contents. Cmd-` should cycle windows Cmd-shift-` should cycle in the other direction.

Review URL: http://codereview.chromium.org/280005
------------------------------------------------------------------------
r29228 | nick@chromium.org | 2009-10-16 02:52:50 +0200 (Fri, 16 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/third_party/libjingle/files/talk/base/physicalsocketserver.cc
   M /trunk/src/third_party/libjingle/files/talk/base/win32socketserver.cc
   A /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.cc
   A /trunk/src/third_party/libjingle/files/talk/base/winsock_initializer.h
   M /trunk/src/third_party/libjingle/libjingle.gyp
   A /trunk/src/third_party/libjingle/overrides/talk/base/winsock_initializer.cc

Within libjingle, add an abstraction of winsock initialization.

When building chrome, override the default implementation so
that we share the winsock initialization singleton with net/base.

Trigger the winsock initialization lazily in a few places.

This is intended to fix a startup perf regression that appeared
when sync (and libjingle) became linked into chrome.dll, rather
than a separate delay-loaded sync dll.

BUG=24448
TEST=Verified deferred winsock initialization via debugger.  Measured before and after time of the StartupTest.PerfTest. Verified sync notification still work.

Review URL: http://codereview.chromium.org/267089
------------------------------------------------------------------------
r29213 | tony@chromium.org | 2009-10-16 01:40:15 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.h

Convert the HTTP cache to use FilePath rather than wstring for the
disk cache path.

BUG=24672

Review URL: http://codereview.chromium.org/276048
------------------------------------------------------------------------
r29212 | estade@chromium.org | 2009-10-16 01:35:18 +0200 (Fri, 16 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.cc
   A /trunk/src/chrome/browser/gtk/theme_install_bubble_view_gtk.h
   M /trunk/src/chrome/chrome.gyp

GTK: Add theme install bubble.

BUG=24360
TEST=load a theme

Review URL: http://codereview.chromium.org/273074
------------------------------------------------------------------------
r29208 | chocobo@google.com | 2009-10-16 01:19:36 +0200 (Fri, 16 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc

Fix status area to use icognito mode background when in icognito mode.
BUG=24970
TEST=none
Review URL: http://codereview.chromium.org/274070
------------------------------------------------------------------------
r29207 | oshima@chromium.org | 2009-10-16 01:13:13 +0200 (Fri, 16 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc

Disabling failing ExternalCookieHandlerTest tests

Review URL: http://codereview.chromium.org/271111
------------------------------------------------------------------------
r29204 | shess@chromium.org | 2009-10-16 01:10:07 +0200 (Fri, 16 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.h
   M /trunk/src/chrome/browser/chrome_application_mac.mm
   A /trunk/src/chrome/browser/chrome_application_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] UMA histogram for uncaught NSExceptions.

NSExceptions break C++ assumptions.  This starts to track how often
NSExceptions happen.

http://crbug.com/24463
TEST=Brower continues to operate.

Review URL: http://codereview.chromium.org/264061
------------------------------------------------------------------------
r29202 | shess@chromium.org | 2009-10-16 01:05:07 +0200 (Fri, 16 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Trim Omnibox hints as field shrinks.

When user text doesn't fit with the full hint:
   "Type to search" hint goes away
   "Tab to search" condenses to "Tab"
   "Search Engine:" is truncated

http://crbug.com/20285
TEST=Type a sentence.  Resize window to see if type-hint goes away.
TEST=Type "google".  Resize window to see if tab-hint goes away.
TEST=Type "google" then TAB, then sentence.  Resize window to see if "Search Google:" is truncated.
TEST=In all cases, text should not scroll before truncation (though it might move as part of truncation).

Review URL: http://codereview.chromium.org/262034
------------------------------------------------------------------------
r29197 | tim@chromium.org | 2009-10-15 23:52:28 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_am.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sw.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   A /trunk/src/chrome/browser/sync/resources/setup_done.html
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.cc
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Facelifts to sync UI

BUG=23136,24858,21596
TEST=SyncSetupWizardTest
Review URL: http://codereview.chromium.org/270081
------------------------------------------------------------------------
r29195 | gregoryd@google.com | 2009-10-15 23:46:15 +0200 (Thu, 15 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h

Get the nexe name from NaCl and send the NaCl process handle and pid to the renderer
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/273056
------------------------------------------------------------------------
r29191 | rogerta@chromium.org | 2009-10-15 23:29:31 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/test/data/purify/unit_tests.exe.gtest.txt
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest.txt

Fix another memory leak in my unit test.

TEST=none
BUG=24769

Review URL: http://codereview.chromium.org/271109
------------------------------------------------------------------------
r29188 | wtc@chromium.org | 2009-10-15 23:23:37 +0200 (Thu, 15 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.h

Provides a certificate for SSL client authentication on NSS sockets.
GUI is still missing, so certificates and private keys have to be
stored manually, p.e.:
$ pk12util -d sql:$HOME/.pki/nssdb -i PKCS12_file.p12
Adds --auto-ssl-client-auth command-line option to enable this feature.

Patch contributed by Jaime Soriano <jsorianopastor@gmail.com>.
Original review URL: http://codereview.chromium.org/220009

R=wtc
BUG=16830
TEST=Try to connect to a web page that requires SSL authentication and
confirm that it connects if and only if a valid certificate is stored in
the ~/.pki/nssdb database.
Review URL: http://codereview.chromium.org/276037
------------------------------------------------------------------------
r29183 | chocobo@google.com | 2009-10-15 23:08:29 +0200 (Thu, 15 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   A /trunk/src/chrome/browser/chromeos/preferences.cc
   A /trunk/src/chrome/browser/chromeos/preferences.h
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add UI for changing timezones.
BUG=24876
TEST=none
Review URL: http://codereview.chromium.org/267113
------------------------------------------------------------------------
r29176 | finnur@chromium.org | 2009-10-15 22:39:38 +0200 (Thu, 15 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Remove flaky label from ParseFeed tests.

These tests have been running fine since my fix. Also removing the traces I added for debugging.

TBR=jcampan
BUG=23686
TEST=Change is enabling the test.

Review URL: http://codereview.chromium.org/273069
------------------------------------------------------------------------
r29173 | jamesr@chromium.org | 2009-10-15 22:37:24 +0200 (Thu, 15 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Tracks the amount of memory SQLite is using in the browser process

This patch adds support for SQLite memory use tracking in the task manager and enables it for the browser process.  SQLite can get into the 10s of MB of memory pretty easily and it is nice to see exactly how much of a 'fat' browser process it is responsible for.

SQLite is also used in the renderer process for web databases, but since those are behind a flag and off by default I haven't added support for them yet.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/276009
------------------------------------------------------------------------
r29172 | tim@chromium.org | 2009-10-15 22:37:11 +0200 (Thu, 15 Oct 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/sync/resources/success-large.png

Add checkmark image to repository so that try servers can use it in testing upcoming patch.  TBR=nick
------------------------------------------------------------------------
r29168 | ben@chromium.org | 2009-10-15 21:37:07 +0200 (Thu, 15 Oct 2009) | 1 line
Changed paths:
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc

didn't mean to add this file.
------------------------------------------------------------------------
r29167 | ben@chromium.org | 2009-10-15 21:34:21 +0200 (Thu, 15 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc (from /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc:28863)

fix bustage
------------------------------------------------------------------------
r29166 | phajdan.jr@chromium.org | 2009-10-15 21:28:31 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc

Fix memory leaks in BlacklistManagerTest.

BUG=21541
TEST=Covered by unit_tests.

Review URL: http://codereview.chromium.org/276047
------------------------------------------------------------------------
r29165 | jrg@chromium.org | 2009-10-15 21:26:30 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   A /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.h
   A /trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm
   A /trunk/src/chrome/browser/cocoa/chrome_event_processing_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window.h
   M /trunk/src/chrome/chrome.gyp


BUG=http://crbug.com/24459
TEST=see bug report.  Also play with entering and leaving fullscreen.

Review URL: http://codereview.chromium.org/269070
------------------------------------------------------------------------
r29164 | ben@chromium.org | 2009-10-15 21:21:57 +0200 (Thu, 15 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_win.cc

Fix a whole category of frame switching bugs relating to the window z-order being screwed up screwed up when DWM is toggled or themes are installed or reset.

The first part of the fix was to remove the hack I put in to hide then show the window while the frame type change occurs.

The hack was to work around the fact that upon returning to glass from non-glass, the area identified by BrowserFrameWin::OnNCCalcSize as client was filled with solid black vs. transparent black.

I don't know why this fix works, but returning a client size for the opaque frame as 1 pixel different to the window rect causes the blackness bug to not occur, so that's what I did (in addition to removing the hack).

I also had to put in a couple of fixes to accommodate the pixel turd we gain in the opaque frame. I renamed ChangeSize to LayoutRootView. When we're using the opaque frame, since the views system is rendering the entire content of the window all the time I always size the widget to the window rect rather than the client rect.

http://crbug.com/15424
TEST=change the frame type by:

- turning on/off aero glass
- installing a theme, then resetting
- running an app that forces the DWM off, e.g. the O3D plugin

The frame should appear correct after the transition in either direction, and window z-order should be preserved.

Review URL: http://codereview.chromium.org/266013
------------------------------------------------------------------------
r29155 | pkasting@chromium.org | 2009-10-15 20:41:29 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Default to using system background, text, and link colors on the NTP instead of white, black, and blue (respectively).

BUG=22967
TEST=Change system theme, start Chrome w/no theme, observe the NTP respects the system colors.
Review URL: http://codereview.chromium.org/273043
------------------------------------------------------------------------
r29152 | estade@chromium.org | 2009-10-15 20:30:33 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h

Extensions: Make badge drawing code cross platform so linux (and eventually mac) can use it.

I will switch Windows over to the common function in a follow-up patch.

BUG=23882
TEST=gmail browser action sample extension

Review URL: http://codereview.chromium.org/279008
------------------------------------------------------------------------
r29149 | finnur@chromium.org | 2009-10-15 20:18:51 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

The ParseFeed test was testing too much in one test, hitting the overall limit for a single browser test. I have therefore split it into three and added a more descriptive error message for when we time out.

I will remove the traces and the FLAKY_ label after a successful run or two on the bots.

BUG=23686
TEST=Tested by automated test.

Review URL: http://codereview.chromium.org/274066
------------------------------------------------------------------------
r29146 | thakis@chromium.org | 2009-10-15 20:05:31 +0200 (Thu, 15 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

Update search state when search text is updated through find pasteboard.

BUG=none
TEST=
*Search for something. Switch to textedit, search for something else. Switch back to chrome. The outdated "x of y" text should be invisble in the find bar, but the prev/next find result buttons should be enabled. Hit enter. Pages should be searched, "x of y " text should return.

* Open a findbar, search for something. Open new chrome window, hit cmd-f. findbar in new window should contain the text you searched for in the last window.

Review URL: http://codereview.chromium.org/267022
------------------------------------------------------------------------
r29145 | tony@chromium.org | 2009-10-15 20:05:18 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/new_tab_ui_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Add a ui test to verify that using the typical_history profile
results in thumbnails.

I could have added this directly to the new tab startup tests, but
that would mean turning on DOM automation for the new tab tests.
I was trying to avoid the extra code in the new tab startup tests.

Review URL: http://codereview.chromium.org/269060
------------------------------------------------------------------------
r29144 | sky@chromium.org | 2009-10-15 20:04:02 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Adds some debugging code in hopes of isolating a crasher. From the
crash it appears that we're starting a drag for an index beyond that of
the model.

BUG=24132
TEST=none

Review URL: http://codereview.chromium.org/275023
------------------------------------------------------------------------
r29143 | sidchat@chromium.org | 2009-10-15 20:00:38 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Fix bug: browser action button disappears when loading a new extension. This was happenening because BrowserActionContainer, on receiving notification about an extension load/unload/change, deletes all BrowserAction views, re-adds all the views again, and asks the toolbar to SetBounds for the BrowserActionContainer. However, during deletion, it does not re-set the bounds. As a result, when SetBounds is called by the toolbar again, it does not see any changed in BrowserActionContainer, and does not layout again, causing all the browser actions to disappear. The solution lies in forcing  Layout() after SetBounds() in ToolbarView.

BUG=23593
TEST=none
Review URL: http://codereview.chromium.org/276033
------------------------------------------------------------------------
r29139 | pinkerton@chromium.org | 2009-10-15 19:45:15 +0200 (Thu, 15 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Fix tab dragging when windows overlap. Bring window to front when dragging a tab into it (allowing drags to window whose tab strip is fully obscured).
BUG=22283
TEST=all tab dragging between windows.
Review URL: http://codereview.chromium.org/281001
------------------------------------------------------------------------
r29138 | pinkerton@chromium.org | 2009-10-15 19:45:04 +0200 (Thu, 15 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Hook up "Bookmark All Tabs" on Mac as menu item in Bookmarks menu and tab context menu. Fix a typo in the grd file for adding a bookmark.
BUG=24363
TEST=bookmark all tabs, edit dialog still dims OK when url is invalid for bookmarks that aren't folders.
Review URL: http://codereview.chromium.org/269080
------------------------------------------------------------------------
r29137 | rohitrao@chromium.org | 2009-10-15 19:38:32 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

[Mac] Bring the correct window to the front when calling BrowserWindow::Activate().  Before this would ignore the existence of fullscreen windows.

BUG=http://crbug.com/21145
TEST=Trigger a javascript alert dialog.  The original non-fullscreen window should not appear.
Review URL: http://codereview.chromium.org/274060
------------------------------------------------------------------------
r29135 | phajdan.jr@chromium.org | 2009-10-15 19:32:48 +0200 (Thu, 15 Oct 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/blacklist_samples/host.pbl
   A /trunk/src/chrome/test/data/blacklist_samples/other_ads.pbl

Create BlacklistManager, which will aggregate individual blacklists into one compiled one
and maintain it.

This is the first step towards shipping privacy blacklists in extensions.

The next step will be to make Profile own a BlacklistManager, and make ExtensionsService a BlacklistPathsProvider.

TEST=Covered by unit_tests.
BUG=21541

Review URL: http://codereview.chromium.org/164535
------------------------------------------------------------------------
r29134 | zork@chromium.org | 2009-10-15 19:32:20 +0200 (Thu, 15 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   A /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.cc
   A /trunk/src/chrome/browser/gtk/sync_setup_wizard_gtk.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h

Fix pieces of syncapi that aren't implemented on Linux.
Review URL: http://codereview.chromium.org/242141
------------------------------------------------------------------------
r29131 | pkasting@chromium.org | 2009-10-15 19:20:59 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc

Oops, dom_storage_dispatcher_host.h got left out of the change, and I introduced a typo when converting CreateWebStorageNamespaceIfNecessary to use a conditional.

BUG=23400
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/282005
------------------------------------------------------------------------
r29130 | pkasting@chromium.org | 2009-10-15 19:07:34 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context_unittest.cc

Add the ability to purge memory to LocalStorage.  This deletes the underlying WebCore objects that manage the sqlite DB, causing its memory caches to be eliminated, and then recreates the objects on demand.

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/264062
------------------------------------------------------------------------
r29128 | jrg@chromium.org | 2009-10-15 18:45:53 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Update unit tests to honor the concept that an ok: call makes the
BookmarkEditorController invalid for subsequent bookmark manipulation
(e.g. it can and does do a remove/add instead of an in-place edit).

Review URL: http://codereview.chromium.org/274039
------------------------------------------------------------------------
r29124 | thomasvl@chromium.org | 2009-10-15 18:27:07 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Remove the include of nsimage_cache_mac since it's not used in these files any more.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/268037
------------------------------------------------------------------------
r29121 | avi@chromium.org | 2009-10-15 17:55:33 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/theme_install_bubble_view.h (from /trunk/src/chrome/browser/views/theme_install_bubble_view.h:28392)
   A /trunk/src/chrome/browser/cocoa/theme_install_bubble_view.mm (from /trunk/src/chrome/browser/views/theme_install_bubble_view.cc:28392)
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/test_browser_window.h

Show "Loading" bubble while loading a theme.

BUG=http://crbug.com/22219
TEST=load a theme, see "Loading..."

Review URL: http://codereview.chromium.org/267031
------------------------------------------------------------------------
r29111 | nsylvain@chromium.org | 2009-10-15 16:11:38 +0200 (Thu, 15 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Add DownloadMimeTest to the flaky list.

BUG:24889
Review URL: http://codereview.chromium.org/276043
------------------------------------------------------------------------
r29102 | suzhe@chromium.org | 2009-10-15 10:20:19 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Linux: Stack autocomplete popup window directly on top of the browser's toplevel window.

BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM"
TEST=Please refer to the bug report for how to test.

Review URL: http://codereview.chromium.org/274046
------------------------------------------------------------------------
r29101 | yurys@google.com | 2009-10-15 10:08:32 +0200 (Thu, 15 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: enable DevToolsSanityTest.TestCompletionOnPause that failed because WebKit@49557 was not rolled.

BUG=24805
Review URL: http://codereview.chromium.org/271100
------------------------------------------------------------------------
r29098 | aa@chromium.org | 2009-10-15 08:59:22 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   D /trunk/src/chrome/browser/extensions/browser_action_test.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html

Reland r29095 (removes wrench integration for
browser actions).

Test failure was a fluke. I forgot that changing
resources always makes the first bot run fail.

TBR=mpcomplete@chromium.org
BUG=24379,24671
------------------------------------------------------------------------
r29097 | aa@chromium.org | 2009-10-15 08:36:08 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   D /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   A /trunk/src/chrome/browser/extensions/browser_action_test.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html

Reverting r29095 (removes wrench integration for
browser actions).

TBR=mpcomplete@chromium.org
BUG=24379,24671
------------------------------------------------------------------------
r29095 | aa@chromium.org | 2009-10-15 08:07:38 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
   D /trunk/src/chrome/browser/extensions/browser_action_test.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html

Remove the implicit wrench menu items for browser actions.

Also, allow browser actions with no initial icons, and add
some better tests.

BUG=24379,24671

Review URL: http://codereview.chromium.org/276010
------------------------------------------------------------------------
r29094 | estade@chromium.org | 2009-10-15 07:09:50 +0200 (Thu, 15 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_after_reboot_helper.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/move_tree_work_item.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_util.cc
   M /trunk/src/chrome/test/mini_installer_test/run_all_unittests.cc
   M /trunk/src/chrome/tools/crash_service/main.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/chrome_launcher.h
   M /trunk/src/chrome_frame/chrome_tab.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc
   M /trunk/src/chrome_frame/test_utils.cc
   M /trunk/src/chrome_frame/test_utils.h
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.h
   M /trunk/src/webkit/tools/webcore_unit_tests/BMPImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/XBMImageDecoder_unittest.cpp

Re-try r29078: Remove some deprecated file_util wstring functions.

With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced).

Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705
mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491
linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466

I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet.
Review URL: http://codereview.chromium.org/271099
------------------------------------------------------------------------
r29089 | nsylvain@chromium.org | 2009-10-15 06:26:33 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Mark HistorySearchXSS as flaky.

BUG:22111

Review URL: http://codereview.chromium.org/278016
------------------------------------------------------------------------
r29085 | estade@chromium.org | 2009-10-15 05:41:02 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_after_reboot_helper.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/move_tree_work_item.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_util.cc
   M /trunk/src/chrome/test/mini_installer_test/run_all_unittests.cc
   M /trunk/src/chrome/tools/crash_service/main.cc
   M /trunk/src/chrome_frame/chrome_launcher.cc
   M /trunk/src/chrome_frame/chrome_launcher.h
   M /trunk/src/chrome_frame/chrome_tab.cc
   M /trunk/src/chrome_frame/test/perf/chrome_frame_perftest.cc
   M /trunk/src/chrome_frame/test_utils.cc
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.h
   M /trunk/src/webkit/tools/webcore_unit_tests/BMPImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/XBMImageDecoder_unittest.cpp

Revert wstring patch (r29078 and follow up commits). It is causing failures on the buildbots.

TBR=nsylvain

Review URL: http://codereview.chromium.org/280004
------------------------------------------------------------------------
r29078 | estade@chromium.org | 2009-10-15 03:59:15 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_after_reboot_helper.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/move_tree_work_item.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_util.cc
   M /trunk/src/chrome/test/mini_installer_test/run_all_unittests.cc
   M /trunk/src/chrome/tools/crash_service/main.cc
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.h
   M /trunk/src/webkit/tools/webcore_unit_tests/BMPImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/XBMImageDecoder_unittest.cpp

Remove some deprecated file_util wstring functions.

death to the wstring

TEST=trybots
BUG=none

Review URL: http://codereview.chromium.org/276016
------------------------------------------------------------------------
r29075 | munjal@chromium.org | 2009-10-15 03:08:45 +0200 (Thu, 15 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

Fix some warnings on Mac that are treated as errors:
The warnings indicate that a public/protected method of a class
visible outside of a .cc file returns a type that's declared in
the anonymous namespace in that file (and hence not visible outside
the file).

BUG=23073
TEST=none

Review URL: http://codereview.chromium.org/273058
------------------------------------------------------------------------
r29073 | cpu@chromium.org | 2009-10-15 02:56:41 +0200 (Thu, 15 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   M /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc

Move the sqlite error handler to a single location
- Eliminate code duplication
- Cover other 3 databases
- Still doing the same as before, sending UMA histograms

BUG=11908
TEST=none


Review URL: http://codereview.chromium.org/270101
------------------------------------------------------------------------
r29071 | jcampan@chromium.org | 2009-10-15 02:35:18 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

Fixing a bug with interstitial pages triggered with malware.

BUG=http://crbug.com/17627
TEST=See bug.

Review URL: http://codereview.chromium.org/273022
------------------------------------------------------------------------
r29068 | aa@chromium.org | 2009-10-15 02:02:24 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/browserAction.html
   M /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/gmail_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html
   M /trunk/src/chrome/test/data/extensions/samples/print_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/manifest.json

Update browser actions api to be like new design doc.

BUG=23879
TEST=Install sample gmail browser action sample.

Review URL: http://codereview.chromium.org/264046
------------------------------------------------------------------------
r29063 | jam@chromium.org | 2009-10-15 01:32:01 +0200 (Thu, 15 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc

Add histogram for how tab closing time.  Did some cleanup along the way.  Moved the is_showing_before_unload_dialog_ stuff from RenderViewHost to TabContents since we need that bit there as well.
Review URL: http://codereview.chromium.org/274057
------------------------------------------------------------------------
r29061 | sky@chromium.org | 2009-10-15 01:23:48 +0200 (Thu, 15 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h

Hides the control buttons for browser when maximized on chrome
os. maximized is the default state on chrome os, so this effectively
gives us no window controls just as we have now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/273055
------------------------------------------------------------------------
r29059 | mpcomplete@chromium.org | 2009-10-15 01:14:59 +0200 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   M /trunk/src/chrome/browser/extensions/extension_i18n_api.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h

Small cleanup to extension function registration to avoid scattered definitions.

BUG=no

Review URL: http://codereview.chromium.org/274059
------------------------------------------------------------------------
r29055 | mmoss@chromium.org | 2009-10-15 00:58:56 +0200 (Thu, 15 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Don't hide task manager key binding from web pages.

This allows shift-esc to work again in Gmail chat windows.

BUG=none

TEST=Open Gmail, start a chat, repeatedly press SHIFT+ESC and watch it switch between the chat "window" and the mail list. The Task Manager should not open.

Review URL: http://codereview.chromium.org/274028

------------------------------------------------------------------------
r29053 | tim@chromium.org | 2009-10-15 00:53:50 +0200 (Thu, 15 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

For sync exponential backoff, allow one nudge per exponential backoff interval. If the nudge
still leaves the syncer with more work to do, don't accept any further nudges for this interval,
and keep the exponent stage for exponential backoff the same.

As a result of the patch, the unittest can now explicitly determine if exponential backoff
kicked in or not.

We really need to wire this up directly to the error codes to be precise, because the current impl (and
it's the same with my patch) appears to trigger exponential backoff in other cases (ShouldSyncAgain).

TEST=SyncerThreadTest

Review URL: http://codereview.chromium.org/275015
------------------------------------------------------------------------
r29050 | mirandac@chromium.org | 2009-10-15 00:47:07 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Disable "Reset to Default Theme" button in Google Chrome Options / Personal Stuff when the default theme is already set, Windows side.

BUG= http://crbug.com/18585
TEST= Install a default theme, note that button is disabled.  Install a non-default theme, note that button is enabled.

Review URL: http://codereview.chromium.org/279005
------------------------------------------------------------------------
r29047 | mirandac@chromium.org | 2009-10-15 00:45:55 +0200 (Thu, 15 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Disable "Reset to Default Theme" button in Google Chrome Options / Personal Stuff when the default theme is already set.
This change is for the Mac OS; Windows change in a separate patch.

BUG= http://crbug.com/18585
TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat.

Review URL: http://codereview.chromium.org/278004
------------------------------------------------------------------------
r29046 | avi@chromium.org | 2009-10-15 00:37:43 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Fix extension canceling; the CFUserNotification functionality gets a bit weird.

BUG=http://crbug.com/23405
TEST=try to cancel extension load; it should work.

Review URL: http://codereview.chromium.org/279006
------------------------------------------------------------------------
r29034 | mark@chromium.org | 2009-10-15 00:01:26 +0200 (Thu, 15 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_paths_mac.mm
   A /trunk/src/chrome/tools/build/make_version_cc.py

Eliminate char/wchar_t conversions, probably-unsafe statics, and disk access
when determining the framework and helper app paths on the Mac.

BUG=24833
TEST=app still works, tests still pass
Review URL: http://codereview.chromium.org/267102
------------------------------------------------------------------------
r29029 | finnur@chromium.org | 2009-10-14 23:16:14 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Moving one test to appear last to see if it makes a difference.

TBR=jcampan
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/276031
------------------------------------------------------------------------
r29027 | sky@chromium.org | 2009-10-14 23:14:20 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/chrome.gyp

Gets the full screen bubble to work on views/gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/264059
------------------------------------------------------------------------
r29025 | avi@chromium.org | 2009-10-14 23:09:09 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm

Mac: colorize the "bookmarks go here" text to match the theme.

BUG=http://crbug.com/23536
TEST=as in bug

Review URL: http://codereview.chromium.org/278008
------------------------------------------------------------------------
r29021 | oshima@chromium.org | 2009-10-14 22:50:01 +0200 (Wed, 14 Oct 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/browser_extender.cc
   A /trunk/src/chrome/browser/chromeos/browser_extender.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/window/non_client_view.h

Add ChromeOS controls to BrowserView
 * Added BrowserExtender class to isolate ChromeOS specific controls from BrowserView
 * Extender currently adds main menu and status area view only.
 * System menu is not enabled because using SetContextMenuController on NonClientFrameView
  didn't work. I need to investigate how.
 * PanelController support will be added in next CL.

Review URL: http://codereview.chromium.org/269078
------------------------------------------------------------------------
r29013 | evan@chromium.org | 2009-10-14 22:32:19 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.cc
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.cc
   M /trunk/src/chrome/browser/net/url_request_slow_http_job.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/ui/npapi_uitest.cc

Use FilePath in URLRequestMocks.

BUG=24672
TEST=compiles

Review URL: http://codereview.chromium.org/271066
------------------------------------------------------------------------
r29011 | finnur@chromium.org | 2009-10-14 22:31:49 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Marking DISABLED test as FLAKY so I can investigate on the bots. 
Also adding traces.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/276030
------------------------------------------------------------------------
r29007 | kuchhal@chromium.org | 2009-10-14 22:16:23 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Linux: Prevent another Chrome instance when First Run UI is active.

BUG=24485
TEST=On Ubuntu, delete 'First Run' file and launch Chrome to bring up First Run UI and then again launch Chrome which should not crash.

Review URL: http://codereview.chromium.org/278006
------------------------------------------------------------------------
r29006 | estade@chromium.org | 2009-10-14 22:12:50 +0200 (Wed, 14 Oct 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/app/theme/infobar_multiple_downloads.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/browser/cocoa/download_request_dialog_delegate_mac.h
   D /trunk/src/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm
   D /trunk/src/chrome/browser/download/download_request_dialog_delegate.h
   D /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   D /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   A /trunk/src/chrome/browser/download/download_request_infobar_delegate.cc
   A /trunk/src/chrome/browser/download/download_request_infobar_delegate.h
   A /trunk/src/chrome/browser/download/download_request_infobar_delegate_unittest.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   D /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.cc
   D /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.h
   M /trunk/src/chrome/chrome.gyp

Make the multiple download request dialog an infobar.

The icon is a placeholder until Glen makes a pretty one.

BUG=24047
TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html
allow, deny, closing infobar, and closing tab all work as expected

Review URL: http://codereview.chromium.org/275011
------------------------------------------------------------------------
r29003 | stuartmorgan@chromium.org | 2009-10-14 22:02:27 +0200 (Wed, 14 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/renderer/mock_printer.cc
   M /trunk/src/chrome/renderer/mock_printer.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/printing/image.h
   M /trunk/src/printing/pdf_metafile_mac.cc
   M /trunk/src/printing/pdf_metafile_mac.h
   M /trunk/src/printing/pdf_metafile_mac_unittest.cc
   M /trunk/src/printing/printed_document_mac.cc

Enable the RenderViewTest printing tests on the Mac.

Migrates some test APIs from wstring path names to FilePath objects, and fixes some gcc compilation issues, to allow the tests to build on Mac.

Moves rendering logic and some other pdf logic into PdfMetafile to avoid duplication with unit test code. Switches rendering from the deprecated CGContextDrawPDFDocument to the newer (but less convenient) CGContextDrawPDFPage.

Added debugging helpers to PdfMetafile: SaveTo, matching the other platform metafiles, and context retain count checking to get early warning of issues that will cause printing failure.

BUG=24750
TEST=N/A

Review URL: http://codereview.chromium.org/274052
------------------------------------------------------------------------
r28998 | chocobo@google.com | 2009-10-14 21:50:50 +0200 (Wed, 14 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Map ctrl+, to open options settings page for Chrome OS.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/267095
------------------------------------------------------------------------
r28997 | jrg@chromium.org | 2009-10-14 21:37:00 +0200 (Wed, 14 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Originally in http://codereview.chromium.org/270096 but got lost somehow.
BUG=http://crbug.com/24758
TBR=mrossetti

Review URL: http://codereview.chromium.org/273054
------------------------------------------------------------------------
r28996 | mattm@chromium.org | 2009-10-14 21:31:58 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc

Coverity: check return of SafeBrowsingProtocolParser::ParseGetHash.

CID=6428
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/261034
------------------------------------------------------------------------
r28992 | hclam@chromium.org | 2009-10-14 21:09:10 +0200 (Wed, 14 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc

Clear media cache when clearing browsing data

BUG=24765
BUG=24813
TEST=run Chromium with --enable-byte-range-support, watch a movie, clear
     browsing data, Media Cache folder shouldn't have the cache files.

Clear media cache when clearing browsing data. What's missing in this patch
is that disk_cache in HttpCache is lazily initialized, so it has to be used
at least once before we can clear it.

Review URL: http://codereview.chromium.org/275013
------------------------------------------------------------------------
r28991 | ananta@chromium.org | 2009-10-14 20:47:49 +0200 (Wed, 14 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

Ensure that the correct URL and title is displayed in the host browser if the browser tab
is attached to an existing external tab. This can happen if a script running in chrome invokes
window.open which opens a popup window. To ensure that the title and URL display correctly we
send over the navigation state changed IPC from Chrome when we receive an IPC from ChromeFrame 
indicating that it connected to the external tab.

I also made a change to the function which sends over the 
navigation state to chrome to ensure that we set the title 
to the URL if it is empty. This mimics Chrome and the other 
browser's behavior.

This should fix http://code.google.com/p/chromium/issues/detail?id=24024

Bug=24024

Review URL: http://codereview.chromium.org/274035
------------------------------------------------------------------------
r28989 | chocobo@google.com | 2009-10-14 20:27:35 +0200 (Wed, 14 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc

Fix bug to select initial wifi network when options page opens.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/276023
------------------------------------------------------------------------
r28988 | nick@chromium.org | 2009-10-14 20:26:56 +0200 (Wed, 14 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h

Readability fixes for server_connection_manager.

Review URL: http://codereview.chromium.org/267029
------------------------------------------------------------------------
r28986 | sky@chromium.org | 2009-10-14 20:03:47 +0200 (Wed, 14 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/screen.h
   M /trunk/src/views/screen_gtk.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/window/window_gtk.cc

Fixes regression in menu button. I converted a call from GetWidget to
GetWindow, the problem is in certain scenarios GetWindow can return
null. I've changed the code back to GetWidget and converted Screen
from taking a NativeWindow to a NativeView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/269076
------------------------------------------------------------------------
r28985 | finnur@chromium.org | 2009-10-14 19:57:55 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable parse feed test again.

TBR=jcampan
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/278003
------------------------------------------------------------------------
r28982 | rogerta@chromium.org | 2009-10-14 19:56:30 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc

Fix for memory leak in unit test.  The test used to leak SiteInstance object
returned from GetSiteInstanceForURL().

BUG=24769
TEST=None

Review URL: http://codereview.chromium.org/271088
------------------------------------------------------------------------
r28977 | tim@chromium.org | 2009-10-14 19:15:05 +0200 (Wed, 14 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html

Fix line endings on merge_and_sync.html in repo, it is breaking svn.
------------------------------------------------------------------------
r28976 | finnur@chromium.org | 2009-10-14 19:09:36 +0200 (Wed, 14 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

A patch from contributor Thiago Farina:

[Windows] Improve the usage of "Open the following pages:" table.

- Allow multiple selection.
- Select the next row after the last row deleted or nothing when the row doesn't
have any items.
- Select the item in table when the user add an url.

BUG=19150
TEST=add a bunch of urls, remove them, in different orders, should work fine.


Review URL: http://codereview.chromium.org/267094
------------------------------------------------------------------------
r28973 | thomasvl@chromium.org | 2009-10-14 18:59:41 +0200 (Wed, 14 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Updates for Under the Hood prefs from Cole:
- Make the scroller the width of the window.
- Resize the content so any wrapping text fields have the full width.
- Tweak the scroller so only bot bottom border shows.

BUG=20538
TEST=Under the hood prefs scroller is the width of the window and goes to the bottom of the toolbar.
Review URL: http://codereview.chromium.org/276019
------------------------------------------------------------------------
r28971 | erg@google.com | 2009-10-14 18:53:41 +0200 (Wed, 14 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/download_started_animation_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.h
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/page_usage_data.cc
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/history/visit_log_unittest.cc
   M /trunk/src/chrome/browser/history/visit_tracker_unittest.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/net/url_request_tracking.cc
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blocked_response.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc

More style nits.

(Working on cleaning chrome/ so hopefully we can lint it by default.)

Review URL: http://codereview.chromium.org/274040
------------------------------------------------------------------------
r28970 | finnur@chromium.org | 2009-10-14 18:50:53 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Temporarily re-enabling ParseFeed test.

TBR=jcampan
BUG=23686
TEST=None

Review URL: http://codereview.chromium.org/269077
------------------------------------------------------------------------
r28967 | ananta@chromium.org | 2009-10-14 18:22:02 +0200 (Wed, 14 Oct 2009) | 31 lines
Changed paths:
   M /trunk/src/base/waitable_event_watcher.h
   M /trunk/src/base/waitable_event_watcher_posix.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/ipc/ipc_sync_channel.cc
   M /trunk/src/ipc/ipc_sync_channel.h
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/ipc/ipc_sync_message_unittest.h

John, please review everything.
agl, please review changes to the waitable_event_watcher code.

Multiple sync channels if used in the same listener thread could result in calls completing in the
wrong context at times. This happens if there are nested calls on these sync channels, i.e
1. Call from client 1 on channel 1 to server 1. Message pumping is enabled for the corresponding message
2. Call from client 2 on channel 2 to server 2, Message pumping is enabled for the corresponding message

Now if a reply for 1 arrives, it should be queued until reply 2 arrives. This does not happen which
causes 2 to terminate prematurely leading to crashes, 1 waiting indefinitely at times, etc.

The fix for this issue is to maintain a local global stack for the send done event watcher object.
The global object is in the form of a TLS. This ensures that we only watch for completed events
on the outermost sync channel.

The changes in the Waitable event watcher object are to return the current delegate which is needed
to start watching the old send watcher once we are done and to ensure that the event member is set even
if it was already signaled when StartWatching was called.

I have added a unit test in ipc_tests for this case. I removed the old QueuedReply based unit tests as
they did not test the actual nested call case.

While debugging these issues I also found some issues in BrowserRenderProcessHost::OnChannelError where
it would delete a sync channel while it was in use. Based on a discussion with jam we decided to DeleteSoon
the sync channel pointer. However this broke some browser ui tests which relied on the timing of the OnChannelError notification. 
We decided to leave the existing code as is for now. I removed the DCHECK on channel as it would fire repeatedly if the channel died
while multiple sync calls were waiting to complete leading to OnChannelError firing multiple times.

Bug=24427

Review URL: http://codereview.chromium.org/271033
------------------------------------------------------------------------
r28966 | pinkerton@chromium.org | 2009-10-14 18:18:41 +0200 (Wed, 14 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Don't animate first tab or new tab button when creating first tab (fix for startup regression), and don't animate NTB when the window isn't visible.
BUG=24744
TEST=new tab and new tab button animation should still happen when creating and closing tabs, also test tab dragging animation.
Review URL: http://codereview.chromium.org/271089
------------------------------------------------------------------------
r28965 | finnur@chromium.org | 2009-10-14 18:03:36 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_test.cc

Disabling ExtensionBrowserTest.BrowserAction since it crashes very frequently on Linux.

TBR=nsylvain
BUG=24802
TEST=None

Review URL: http://codereview.chromium.org/274049
------------------------------------------------------------------------
r28964 | yurys@google.com | 2009-10-14 18:02:02 +0200 (Wed, 14 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: temporarily disable completion test which fails on Linux

TBR=pfeldman
Review URL: http://codereview.chromium.org/274048
------------------------------------------------------------------------
r28961 | yurys@google.com | 2009-10-14 17:38:35 +0200 (Wed, 14 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/completion_on_pause.html
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: support autocompletion when script is paused

Review URL: http://codereview.chromium.org/277001
------------------------------------------------------------------------
r28958 | shess@chromium.org | 2009-10-14 16:00:15 +0200 (Wed, 14 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm

[Mac] Omnibox popup should have Edit Search Engines when editable.

Was previously tied to whether you could paste-and-go.

http://crbug.com/24741
http://crbug.com/22512
TEST=Copy " " to pasteboard.  Right-click omnibox.  Should see "Edit
Search Engines".

Review URL: http://codereview.chromium.org/271078
------------------------------------------------------------------------
r28950 | darin@chromium.org | 2009-10-14 08:00:36 +0200 (Wed, 14 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Make the acknowledgement message for querying form autofill data always
be sent.

I plan to make use of this to have the RenderView hold onto a WebNode
instead of a node_id in a future CL.

R=jcampan
BUG=24595
TEST=none

Review URL: http://codereview.chromium.org/270082
------------------------------------------------------------------------
r28944 | gregoryd@google.com | 2009-10-14 05:38:36 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/common/child_process_info.cc

Adding support for Native Client in Chrome's task manager and "stats for nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28875
Review URL: http://codereview.chromium.org/267043
------------------------------------------------------------------------
r28941 | estade@chromium.org | 2009-10-14 05:22:32 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/browser_action_test.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/chrome.gyp

Port Browser Actions browsertest to linux.

BUG=23882
TEST=run it

Review URL: http://codereview.chromium.org/274025
------------------------------------------------------------------------
r28938 | mhm@chromium.org | 2009-10-14 04:05:43 +0200 (Wed, 14 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Remove hot tracked toolbar button when toolbar removes focus.

WillLooseFocus needs to check if acc_focused_view is set, if it is, then it will properly remove it.

BUG=3510
TEST=ALT+SHIFT+T all the way to the menu button, select options/about chromium menu option and hit enter to select one of them. The menu will be not hottracked.

Review URL: http://codereview.chromium.org/270072
------------------------------------------------------------------------
r28937 | nick@chromium.org | 2009-10-14 03:08:46 +0200 (Wed, 14 Oct 2009) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Fix a bug that would cause spurious commits from the bookmark model
under the following circumstances:

  (a) There were two or more bookmarks with the
      same title in a folder.

  (b) A change notification event occured for
      the bookmark (in my case it was a favicon
      loaded event; these would happen every
      startup, and maybe on every page visit too),
      but the bookmark properties didn't
      actually change.

What was happening is that we were filtering out redundant
property changes for the title, but only after we'd uniquified
the name.  This wasn't necessary, and for cases where
there was a sibling with an identical name, the newly
generated uniquified name would result in a false positive.

The fix is to do the filtering on the non-unique name only.
This is the only property visible to syncapi clients.

BUG=24770
TEST=See bug.

Review URL: http://codereview.chromium.org/271083
------------------------------------------------------------------------
r28933 | tony@chromium.org | 2009-10-14 02:56:55 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Implement shift+delete for removing omnibox entries on Linux.

TEST=Select an item from the autocomplete popup and press shift+del.
  Clear the autocomplete and start typing again. Verify that the
  item doesn't re-appear.

Review URL: http://codereview.chromium.org/271063
------------------------------------------------------------------------
r28923 | asargent@chromium.org | 2009-10-14 02:19:31 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/autoupdate_interceptor.cc
   A /trunk/src/chrome/browser/extensions/autoupdate_interceptor.h
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/autoupdate
   A /trunk/src/chrome/test/data/extensions/autoupdate/key.pem
   A /trunk/src/chrome/test/data/extensions/autoupdate/manifest_v2.xml
   A /trunk/src/chrome/test/data/extensions/autoupdate/manifest_v3.xml
   A /trunk/src/chrome/test/data/extensions/autoupdate/v1
   A /trunk/src/chrome/test/data/extensions/autoupdate/v1/manifest.json
   A /trunk/src/chrome/test/data/extensions/autoupdate/v1/toolstrip.html
   A /trunk/src/chrome/test/data/extensions/autoupdate/v1.crx
   A /trunk/src/chrome/test/data/extensions/autoupdate/v2
   A /trunk/src/chrome/test/data/extensions/autoupdate/v2/manifest.json
   A /trunk/src/chrome/test/data/extensions/autoupdate/v2/toolstrip.html
   A /trunk/src/chrome/test/data/extensions/autoupdate/v2.crx
   A /trunk/src/chrome/test/data/extensions/autoupdate/v3
   A /trunk/src/chrome/test/data/extensions/autoupdate/v3/manifest.json
   A /trunk/src/chrome/test/data/extensions/autoupdate/v3/toolstrip.html
   A /trunk/src/chrome/test/data/extensions/autoupdate/v3.crx
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Add a browser test for extensions autoupdate.

BUG=17826,19403
TEST=none

Review URL: http://codereview.chromium.org/270019
------------------------------------------------------------------------
r28922 | pkasting@chromium.org | 2009-10-14 02:18:57 +0200 (Wed, 14 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Blind attempt at fixing the bookmark bar instructional text color for GTK.

BUG=23536
TEST=Open Chrome Linux w/a theme and no bookmarks, verify instructional text in bookmarks bar has correct color.
Review URL: http://codereview.chromium.org/274034
------------------------------------------------------------------------
r28918 | chocobo@google.com | 2009-10-14 02:08:33 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_network_library.h
   M /trunk/src/chrome/browser/chromeos/cros_power_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_power_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc

Make cros library thread-safe.
Adds unmonitoring of network status changes.
Fixed a few edge case bugs.
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/272019
------------------------------------------------------------------------
r28914 | erg@google.com | 2009-10-14 01:23:47 +0200 (Wed, 14 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/base/condition_variable_unittest.cc
   M /trunk/src/base/debug_on_start.cc
   M /trunk/src/base/debug_util_mac.cc
   M /trunk/src/base/debug_util_unittest.cc
   M /trunk/src/base/directory_watcher_unittest.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/google_update_settings_posix.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/window_sizer_linux.cc

Fix a whole bunch of style nits.

(Long term intention is to add a subset of cpplint.py to the presubmit script.)

Review URL: http://codereview.chromium.org/276008
------------------------------------------------------------------------
r28912 | mpcomplete@chromium.org | 2009-10-14 01:17:50 +0200 (Wed, 14 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Update page action manifest parsing to match the new format.

Preserves backwards compatability with the old manifest format.

BUG=24635

Review URL: http://codereview.chromium.org/275007
------------------------------------------------------------------------
r28909 | evan@chromium.org | 2009-10-14 01:00:11 +0200 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h

Use FilePath in ChildProcessHost.

BUG=24672
TEST=still compiles

Review URL: http://codereview.chromium.org/270077
------------------------------------------------------------------------
r28908 | cpu@chromium.org | 2009-10-14 00:56:53 +0200 (Wed, 14 Oct 2009) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/diagnostics
   A /trunk/src/chrome/browser/diagnostics/diagnostics_main.cc
   A /trunk/src/chrome/browser/diagnostics/diagnostics_main.h
   A /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc
   A /trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h
   M /trunk/src/chrome/chrome.gyp

Empty files to kick off the diagnostic mode

- Main entry point
- sqlite error handler

BUG=none
TEST=none

TBR=huanr


Review URL: http://codereview.chromium.org/274033
------------------------------------------------------------------------
r28907 | stuartmorgan@chromium.org | 2009-10-14 00:54:12 +0200 (Wed, 14 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printer_query.cc
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   D /trunk/src/chrome/renderer/print_web_view_helper_mac.cc
   A /trunk/src/chrome/renderer/print_web_view_helper_mac.mm
   M /trunk/src/chrome/renderer/render_view_unittest.cc

Wire up printing on the Mac

Get the printing support class stack building and hooked up on the Mac.
Add support for creating NativeMetafile objects with PDF print data on the renderer side, and passing them to the browser via the existing printing IPC system.
Flip on the simpler printing unit tests (those that don't require PDF -> bitmap conversion).

BUG=13158
TEST=Print on the Mac--it should work!

Review URL: http://codereview.chromium.org/276004
------------------------------------------------------------------------
r28904 | jrg@chromium.org | 2009-10-14 00:44:25 +0200 (Wed, 14 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Fix "Add Page..." in bookmark bar context menu.  Suspect this bug was
always there but it only became an issue when accessibility changes
landed.

BUG=http://crbug.com/24758
TEST=Open menu.  See "add page" sheet show up.

Review URL: http://codereview.chromium.org/270096
------------------------------------------------------------------------
r28903 | sky@chromium.org | 2009-10-14 00:41:54 +0200 (Wed, 14 Oct 2009) | 18 lines
Changed paths:
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc (from /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc:28767)
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_views.h (from /trunk/src/chrome/browser/views/blocked_popup_container_view_views.h:28767)
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/menu/simple_menu_model.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Take 2 of getting blocked popups to work on views/gtk. My first attempt was not deleting the blocked popup container view views,
which resulted in a reliability crash. This differs from the first patch in that BlockedPopupContainerViewViews::Destroy now does
a delete this.

From the original patch:

I had to fix a couple of additional things here:

. Avoid doing anything in OnSizeAllocation if the size hasn't
changed. Because of how gtk works I was getting stuck in a loop if I
OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
is a check.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274019
------------------------------------------------------------------------
r28902 | sky@chromium.org | 2009-10-14 00:38:19 +0200 (Wed, 14 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/screen.h
   M /trunk/src/views/screen_gtk.cc
   M /trunk/src/views/screen_win.cc
   M /trunk/src/views/views.gyp

Couple of views/gtk tweaks:
. Adds accelerator to list of files compiled on views/gtk.
. Adds function to Screen to get monitor bounds from a window.
. Adds BrowserFrameGtk::GetAccelerator to match windows.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/275005
------------------------------------------------------------------------
r28901 | akalin@chromium.org | 2009-10-14 00:28:03 +0200 (Wed, 14 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc

Fixed some more Google Sync mac build compile errors.

Review URL: http://codereview.chromium.org/271043
------------------------------------------------------------------------
r28900 | akalin@chromium.org | 2009-10-14 00:25:24 +0200 (Wed, 14 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h
   M /trunk/src/chrome/browser/sync/glue/change_processor.h
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   A /trunk/src/chrome/browser/sync/notifier/base/mac
   A /trunk/src/chrome/browser/sync/notifier/base/mac/network_status_detector_task_mac.cc
   A /trunk/src/chrome/browser/sync/notifier/base/mac/time_mac.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   D /trunk/src/chrome/browser/sync/util/character_set_converters_linux.cc
   A /trunk/src/chrome/browser/sync/util/character_set_converters_posix.cc (from /trunk/src/chrome/browser/sync/util/character_set_converters_linux.cc:28899)
   M /trunk/src/chrome/browser/sync/util/path_helpers_linux.cc
   A /trunk/src/chrome/browser/sync/util/path_helpers_mac.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/third_party/libjingle/libjingle.gyp

Patched in 265058 (which was uploaded under akalin@gmail.com). Original
description:

Numerous fixes to get parts of Chrome Sync to compile on OS X.

Fixes include:

- Added missing definitions for some static const class variables.
- Added some missing dependencies.
- Marked some Windows-only dependencies as such.
- Added stub files for some platform-specific classes.

BUG=none
TEST=Put through trybots.

Review URL: http://codereview.chromium.org/266065
------------------------------------------------------------------------
r28899 | pkasting@chromium.org | 2009-10-14 00:17:45 +0200 (Wed, 14 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Use correct theme color for bookmark bar "drag things here" empty helper text.

BUG=23536
TEST=With an empty bookmark bar and any theme, the helper text color should match the "other bookmarks" color.
Review URL: http://codereview.chromium.org/276005
------------------------------------------------------------------------
r28888 | gregoryd@google.com | 2009-10-13 23:15:29 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/common/child_process_info.cc

Revert 28875 - Adding support for Native Client in Chrome's task manager and "stats for nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/267043

TBR=gregoryd@google.com

Review URL: http://codereview.chromium.org/266067
------------------------------------------------------------------------
r28882 | hawk@chromium.org | 2009-10-13 22:55:37 +0200 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/net/base/x509_certificate.h

View Certificate dialog sometimes shows incorrect status because it didn't have the full certificate chain.
BUG=23122
TEST=https://www.paypal.com should have "This certificate is valid" in View Page Info->View Certificate Information
Review URL: http://codereview.chromium.org/256064
------------------------------------------------------------------------
r28881 | jam@chromium.org | 2009-10-13 22:54:48 +0200 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/renderer/render_view.cc

Revert r28745 which disabled nested message loops on Mac, after Mark's fixes.

BUG=24337
Review URL: http://codereview.chromium.org/269065
------------------------------------------------------------------------
r28875 | gregoryd@google.com | 2009-10-13 22:28:36 +0200 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/common/child_process_info.cc

Adding support for Native Client in Chrome's task manager and "stats for nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/267043
------------------------------------------------------------------------
r28874 | pkasting@chromium.org | 2009-10-13 22:22:49 +0200 (Tue, 13 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webthemecontrol.cc

Use predefined color names where possible for clarity.  Also use "SkColorSetARGB(0, 0, 0, 0)" in place of "NULL" since it's not obvious what the latter means as a color.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/273042
------------------------------------------------------------------------
r28869 | estade@chromium.org | 2009-10-13 22:06:23 +0200 (Tue, 13 Oct 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
   A /trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/chrome.gyp

GTK: Browser actions toolbar.

We don't have html popups yet but clicking should work (e.g. print button works).

TODO: port browser_action in proc browser test.
TODO: badges

BUG=23882
TEST=loaded gmail browser action extension, loaded print bookmark bar extension, loaded them both, unloaded, disabled, enabled, etc.

Review URL: http://codereview.chromium.org/273025
------------------------------------------------------------------------
r28868 | pkasting@chromium.org | 2009-10-13 22:00:09 +0200 (Tue, 13 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/views/widget/default_theme_provider.cc
   M /trunk/src/views/widget/default_theme_provider.h

Make the ThemeProvider methods const.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/266037
------------------------------------------------------------------------
r28866 | jcampan@chromium.org | 2009-10-13 21:58:21 +0200 (Tue, 13 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.gypi

Factoring out the interactive UI tests in their own GYP file.
Although turning back on the browser focus tests that had been turned off last week because of my previous attempt at performing this refactoring (that change was reverted).

BUG=None
TEST=Build and run the interactive ui tests on Windows and Linux.

Review URL: http://codereview.chromium.org/273029
------------------------------------------------------------------------
r28862 | pkasting@chromium.org | 2009-10-13 21:05:20 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Always ASSERT that created servers are non-NULL (since creation can fail).  Blindly dereferencing NULL pointers in a unittest causes the test harness to crash.

BUG=none
TEST=none
TBR=jcampan
Review URL: http://codereview.chromium.org/270088
------------------------------------------------------------------------
r28860 | jamesr@chromium.org | 2009-10-13 20:57:48 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_unittest.cc

Fix valgrind-caught memory leak in TaskManagerUnittest

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/276003
------------------------------------------------------------------------
r28856 | evan@chromium.org | 2009-10-13 20:43:35 +0200 (Tue, 13 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/test/ui/npapi_test_helper.cc
   M /trunk/src/chrome/test/ui/npapi_test_helper.h
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc

Remove the unnecessary conversion to wstring when calling file_util::WriteFile.

Also use FilePath in npapi_test_helper.

BUG=24672
TEST=compiled

Review URL: http://codereview.chromium.org/266061
Patch from Thiago Farina <tfarina@gmail.com>.
------------------------------------------------------------------------
r28851 | pinkerton@chromium.org | 2009-10-13 20:28:36 +0200 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Animate the new tab button when closing a tab.
BUG=14919
TEST=new tab button is in the correct location.
Review URL: http://codereview.chromium.org/243049
------------------------------------------------------------------------
r28850 | tschmelcher@chromium.org | 2009-10-13 20:27:40 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/data_pack.cc
   M /trunk/src/base/debug_util_posix.cc
   M /trunk/src/base/directory_watcher_inotify.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/base/stats_table.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/ipc/ipc_channel_posix.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc

Eliminate all uses of strerror() in code that uses src/base. strerror() is inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().

TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none

Review URL: http://codereview.chromium.org/261055
------------------------------------------------------------------------
r28849 | michaeln@google.com | 2009-10-13 20:25:23 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.h

AppCache: Kill bad renderers when we receive bad IPC messages.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/273012
------------------------------------------------------------------------
r28846 | rogerta@google.com | 2009-10-13 20:21:43 +0200 (Tue, 13 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc

I had written unit tests for the change to add a runtime id to Profiles, but
I forgot to include those tests in the CL (255087).  So here they are.

BUG=0
TEST=this change includes only tests for existing code

Review URL: http://codereview.chromium.org/273006
------------------------------------------------------------------------
r28845 | kuchhal@chromium.org | 2009-10-13 20:21:11 +0200 (Tue, 13 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Shorten the generated file name to be less than MAX_PATH (on Windows).

BUG=24591

Review URL: http://codereview.chromium.org/267063
------------------------------------------------------------------------
r28842 | jcampan@chromium.org | 2009-10-13 20:11:35 +0200 (Tue, 13 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

WidgetWin was an accelerator target, it does not need to.

BUG=None
TEST=make sure Esc still works in the bookmark bubble and that accelerators work as expected.
Review URL: http://codereview.chromium.org/271067
------------------------------------------------------------------------
r28839 | jamesr@chromium.org | 2009-10-13 20:01:18 +0200 (Tue, 13 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations.h
   M /trunk/src/webkit/glue/dom_operations_unittest.cc

This patch enables "Save page as" (ctrl+s) for resources located at
chrome-extension URLs. In the absence of any API for doing file I/O this adds
very useful functionality to chrome extensions. This patch is needed to allow
APU to save its instrumentation data to disk without the need for a plugin.

patch by: Jaime Yap (jaimeyap@google.com)

BUG=none
TEST=Bundle a page "foo.html" with an extension. Usings the tabs API or
     window.open, open "foo.html" in the extensions process. Try to save it
     using CTRL+S. (You can test with any of the existing samples that bundle
     a page).

Review URL: http://codereview.chromium.org/266051
------------------------------------------------------------------------
r28836 | mirandac@chromium.org | 2009-10-13 19:41:06 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

The file menu was enabled even when a browser window was obscured by a modal dialog.  This fix disables these menu items while the dialog window is up.

BUG= http://crbug.com/23864
TEST= Open the "open file" file chooser window with cmd-o (or from the menu). Attempt to open a new tab, window, or file. Note that you cannot. Close the file chooser window, and note that these menu items are now enabled again.

Review URL: http://codereview.chromium.org/269035
------------------------------------------------------------------------
r28834 | phajdan.jr@chromium.org | 2009-10-13 19:34:06 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Fix creating desktop shortcuts for systems with empty or incomplete XDG_DATA_DIRS.

An example of such system is Fedora 11.

BUG=22966
TEST=See bug.

Review URL: http://codereview.chromium.org/267053
------------------------------------------------------------------------
r28829 | jamesr@chromium.org | 2009-10-13 19:27:01 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/task_manager_unittest.cc

Refactors freaky TaskManager::Resource self-updating

Currently, TaskManagerTabContentsResource supports getting WebCore cache information.  This information has to be fetched from the renderer process via an IPC round-trip.  Currently, the Resource updates itself whenever a query is made from the View via the TaskManagerModel::GetResourceWebCore*() methods, which seems very wrong from a design POV and is tricky to test.  This patch cleans up the picture a bit by routing the TaskManagerModel::Refresh() call to interested TaskManager::Resource objects.

TEST=try bots, open task manager + right click to enable cache columns, browse around, observe updated values
BUG=none

Review URL: http://codereview.chromium.org/267062
------------------------------------------------------------------------
r28827 | pkasting@chromium.org | 2009-10-13 19:19:57 +0200 (Tue, 13 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

A few other miscellaneous bits of cleanup to BrowserThemeProvider:
* Put "&" ref-qualifier on type, not variable (style guide)
* Use "foo.count(bar)" instead of "foo.find(bar) != foo.end()" where possible (shorter)
* Better iterator name in one spot (missed it last time)
* Some tiny indentation/whitespace/line-wrapping changes

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/275004
------------------------------------------------------------------------
r28826 | erg@chromium.org | 2009-10-13 19:18:47 +0200 (Tue, 13 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Mac: Fix bookmark bar buttons not being layed out correctly on startup.

BUG=17625

Review URL: http://codereview.chromium.org/271058
------------------------------------------------------------------------
r28825 | dmaclach@chromium.org | 2009-10-13 19:06:39 +0200 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm

Disable broken tests until I can get a fix in.
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/275003
------------------------------------------------------------------------
r28823 | dmaclach@chromium.org | 2009-10-13 18:33:35 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm

Fixes up drawing so that we don't have any transparent holes, and adds a
bit more of a guard around some private API calling.
Also moves the widgets up one pixel, and fixes drawing the widgets in windows
without tabstrips.

BUG=24539, 24693
TEST=Assign a window the Mark Ecko theme (https://tools.google.com/chrome/intl/en/themes/theme_at_mecko.html) and look for holes in the top of the window graphics. Click on this link (http://www.htmlcodetutorial.com/linking/popup_test_a.html) and make sure the popup windows widgets are in the right place.
Review URL: http://codereview.chromium.org/273031
------------------------------------------------------------------------
r28819 | avi@chromium.org | 2009-10-13 17:46:42 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Mac: Fix buttons not tinting to theme.

BUG=http://crbug.com/24429
TEST=buttons should tint

Review URL: http://codereview.chromium.org/273037
------------------------------------------------------------------------
r28818 | stoyan@google.com | 2009-10-13 16:56:38 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_frame_delegate.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h

This CL is for the needs of ChromeFrame.
TabContentsDelegate implementation may override navigations caused by JsvaScript history object.

Yet not perfect since webkit view of navigation stack differs from the view of external-non-Chrome-host-browser.
We have to provide the full stack from host-browser (+visited links alongside) in the same way as Chrome-browser provides it to renderer.

BUG=24004
Review URL: http://codereview.chromium.org/261046
------------------------------------------------------------------------
r28815 | avi@chromium.org | 2009-10-13 16:52:20 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/nsimage_cache_mac.mm
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Mac: Make the nsimage_cache behave more like +[NSImage imageNamed:]

BUG=none
TEST=no visible change

Review URL: http://codereview.chromium.org/272032
------------------------------------------------------------------------
r28814 | pinkerton@chromium.org | 2009-10-13 16:12:58 +0200 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm

Allow the about window to create a new window to handle loading web pages if there is none currently available.
BUG=24234
TEST=clicking links in about window with and without browsers open.
Review URL: http://codereview.chromium.org/272013
------------------------------------------------------------------------
r28813 | pinkerton@chromium.org | 2009-10-13 16:12:45 +0200 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_mac.mm

Use the real bundle identifier instead of the framework's identifier for detecting default browser identifier.
BUG=24401
TEST=set default to chromium from safari, verify chromium thinks it's default. set default to safari in safari, verify chromium thinks it's not default. Then set it to default and verify Safari thinks Chromium is default.
Review URL: http://codereview.chromium.org/261039
------------------------------------------------------------------------
r28809 | shess@chromium.org | 2009-10-13 15:29:27 +0200 (Tue, 13 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Add breakpad info for crashes in the target/action dispatcher.

-[NSApplication sendAction:to:from:] is a central dispatcher for
target-action messages sent by controls.  Backtraces from here often
contain only Cocoa messages, making it hard to tell where things are
at when a freed target gets messaged.  Add additional info like the
action being requested and the tag of the sender.

http://crbug.com/24460
TEST=Browser continues to work.

Review URL: http://codereview.chromium.org/269039
------------------------------------------------------------------------
r28793 | mbelshe@google.com | 2009-10-13 06:43:21 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/net.gyp

Add a command line switch to enable flip sockets.
With this change, flip code is now compiled
and the limited unit tests actually run.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/259064
------------------------------------------------------------------------
r28789 | mhm@chromium.org | 2009-10-13 05:34:48 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Fix flashing issue when hitting escape while find bar is active.

When the View try's to focus to the last focused component, it can't, because ToolBarView is not Focusable, hence overriding IsFocusable will fix the flashing, but will create a focusable ring around the whole toolbar.

BUG=15228
TEST=ALT+SHIFT+T press left arrow until page menu, and select find in page. Press ESC numerous times, no more flashing issues for the find bar.

Review URL: http://codereview.chromium.org/265056
------------------------------------------------------------------------
r28788 | sky@chromium.org | 2009-10-13 05:17:31 +0200 (Tue, 13 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Wires up bookmark all tabs on linux.

BUG=2935
TEST=Create two tabs, press control-shift-d. You should be presented
with a dialog that lets you give a name to a folder. Change the name,
press enter and make sure you get a bookmark folder populated with the
urls of any open tabs.

Review URL: http://codereview.chromium.org/268038
------------------------------------------------------------------------
r28780 | nsylvain@chromium.org | 2009-10-13 04:17:45 +0200 (Tue, 13 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Mark the IcognitoDownload as flaky because it keeps
failing on mac.

BUG:24684
Review URL: http://codereview.chromium.org/266059
------------------------------------------------------------------------
r28779 | evan@chromium.org | 2009-10-13 04:07:25 +0200 (Tue, 13 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/app/app_switches.cc
   M /trunk/src/app/app_switches.h
   M /trunk/src/base/base_switches.cc
   M /trunk/src/base/base_switches.h
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/base/debug_on_start.cc
   M /trunk/src/base/debug_on_start.h
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/test/perf_test_suite.h
   M /trunk/src/base/test/test_suite.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/debug_flags.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/mini_installer_test/run_all_unittests.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/test_launcher/out_of_proc_test_runner.cc
   M /trunk/src/chrome/test/test_launcher/test_runner.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/sunspider_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.h
   M /trunk/src/chrome/test/ui/v8_benchmark_uitest.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.h
   M /trunk/src/chrome_frame/chrome_launcher_unittest.cc
   M /trunk/src/courgette/courgette_tool.cc
   M /trunk/src/ipc/ipc_switches.cc
   M /trunk/src/ipc/ipc_switches.h
   M /trunk/src/media/bench/bench.cc
   M /trunk/src/net/tools/dump_cache/dump_cache.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/tools/fetch/fetch_server.cc
   M /trunk/src/o3d/converter/cross/converter_main.cc
   M /trunk/src/o3d/converter/cross/verifier_main.cc
   M /trunk/src/o3d/converter_edge/cross/converter_main.cc
   M /trunk/src/o3d/converter_edge/cross/verifier_main.cc
   M /trunk/src/tools/imagediff/image_diff.cc
   M /trunk/src/webkit/glue/plugins/plugin_constants_win.h
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/webworkerclient_impl.cc
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.h

Use ASCII strings for switch names.

Review URL: http://codereview.chromium.org/270062
------------------------------------------------------------------------
r28778 | estade@chromium.org | 2009-10-13 04:07:11 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

GTK: avoid a hang brought on by an infinite size-allocate queue.

This is not the most satisfying fix imaginable. I'm not sure why we are getting size-allocate events where the visibility of the chevron has changed but our allocation is not yet updated. In principle I suppose it would be better not to call any function that might cause an allocation from within a size-allocate handler, but guaranteeing that is probably pretty hard.

BUG=24470
TEST=repro steps no longer repro; also, verified that the early return line is actually being hit.

Review URL: http://codereview.chromium.org/270078
------------------------------------------------------------------------
r28777 | estade@chromium.org | 2009-10-13 04:06:57 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Gtk: draw the secure scheme color over the correct char range.

BUG=none
TEST=go to gmail.com

Review URL: http://codereview.chromium.org/272028
------------------------------------------------------------------------
r28776 | estade@chromium.org | 2009-10-13 04:06:34 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc

GTK: don't dcheck when user dismisses print dialog.

BUG=none
TEST=ctrl+p, escape in debug mode does not dcheck

Review URL: http://codereview.chromium.org/272030
------------------------------------------------------------------------
r28775 | mattm@chromium.org | 2009-10-13 03:52:48 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk_unittest.cc

[Linux] Select a row in Languages table when the user delete an item.
This is to work in the same way as in Windows version.

BUG=None
TEST=add some languages, remove them, should work fine.

Review URL: http://codereview.chromium.org/270013
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r28771 | pkasting@chromium.org | 2009-10-13 03:40:30 +0200 (Tue, 13 Oct 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/views/widget/default_theme_provider.cc
   M /trunk/src/views/widget/default_theme_provider.h

Misc. cleanup for theme provider code, including:
* Use correct indentation/alignment in a number of places
* Use early-return to avoid long code block indenting
* Use for() instead of while() in cases where that's what the code is actually doing
* Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found")
* Use {} when needed, don't use when not
* Do not use "else" after "return"
* Shorten overly-verbose code
* Pull some trivial functions into the header
* Eliminate unused function
* Use STLDeleteValues() helper where appropriate

Some of this was originally in my patch that modified constness, but I've split it out to make that more sane.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/272033
------------------------------------------------------------------------
r28768 | nsylvain@chromium.org | 2009-10-13 03:39:31 +0200 (Tue, 13 Oct 2009) | 17 lines
Changed paths:
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_views.h
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc (from /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc:28715)
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h (from /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h:28715)
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/menu/simple_menu_model.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Revert 28716 - Gets blocked popups to work on views/gtk. I had to fix a couple of
additional things here:

. Avoid doing anything in OnSizeAllocation if the size hasn't
  changed. Because of how gtk works I was getting stuck in a loop if I
  OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
  is a check.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261051

TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/267069
------------------------------------------------------------------------
r28767 | oshima@chromium.org | 2009-10-13 02:41:48 +0200 (Tue, 13 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc

Fixed lame typo.
  Doh, I forgot that linux try bot does not compile this file.

BUG=None
TEST=compiled with chromeos=1
TBR=sky

Review URL: http://codereview.chromium.org/269061
------------------------------------------------------------------------
r28764 | oshima@chromium.org | 2009-10-13 01:58:03 +0200 (Tue, 13 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/installer/installer.gyp

include CHROMEOS files and defintions in TOOLKIT_VEIWS build.
 * changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
 * changed to define OS_CHROMEOS when toolkit_views==1
 * changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
  I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
  from xid. Looks like I need to register it somewhere

Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.

BUG=none
TEST=run views unit test and browser.

Review URL: http://codereview.chromium.org/262027
------------------------------------------------------------------------
r28761 | jamesr@chromium.org | 2009-10-13 01:57:18 +0200 (Tue, 13 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_events.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/devtools/timeline_api/background.html
   M /trunk/src/chrome/test/data/extensions/devtools/timeline_api_two/background_two.html
   A /trunk/src/webkit/glue/devtools/apu_agent_delegate.h
   M /trunk/src/webkit/glue/devtools/js/inject_dispatch.js
   M /trunk/src/webkit/glue/webdevtoolsagent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/webkit.gyp

Enables the sending of Timeline Agent and Resource messages to the devtools api in extensions.

Review URL: http://codereview.chromium.org/267013
------------------------------------------------------------------------
r28760 | evan@chromium.org | 2009-10-13 01:57:07 +0200 (Tue, 13 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h

Use FilePaths in chrome_url_data_manager.

BUG=24672
TEST=still compiles

Review URL: http://codereview.chromium.org/267065
------------------------------------------------------------------------
r28758 | arv@chromium.org | 2009-10-13 01:55:13 +0200 (Tue, 13 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   D /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove old NTP

BUG=None

TEST=None

Review URL: http://codereview.chromium.org/271057
------------------------------------------------------------------------
r28752 | evan@chromium.org | 2009-10-13 00:50:39 +0200 (Tue, 13 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc

CommandLine: rejigger how initialization works.

I'm attempting to clean up CommandLine.
This change rearranges how initialization is done.  I am trying
to eliminate redundant functions; more will come in subsequent changes.

Review URL: http://codereview.chromium.org/273018
------------------------------------------------------------------------
r28749 | mark@chromium.org | 2009-10-13 00:27:56 +0200 (Tue, 13 Oct 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

Status bubbles should wait before showing and hiding, and should fade in and
out on the Mac.

This fixes the fades, which were actually written but unfortunately not
working due to a silly bug.  It also adds the delays, cleaning up a TODO.
It fixes some questionable logic ("hide by calling Hide() and then FadeIn()").
Finally, it allows better reuse of the status bubble NSWindow, and fixes a bug
that prevented the status bubble window from properly attaching to its parent
window if the parent was offscreen at attachment time.  Unit tests for the new
behavior are included, and as a bonus, I've added better testing for some
existing behavior.

See http://dev.chromium.org/user-experience/status-bubble for the design of
the status bubble.  Also, consult chrome/browser/views/status_bubble_views.cc
for the implementation used on Windows.

BUG=24495
TEST=Mouse over some links
Review URL: http://codereview.chromium.org/269045
------------------------------------------------------------------------
r28745 | jam@chromium.org | 2009-10-12 23:51:04 +0200 (Mon, 12 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/renderer/render_view.cc

Disable nested message loops in Mac for now.  There seems to be a problem with the message pumping or IPC channel where the sent reply from the browser doesn't make it to the renderer main thread.

BUG=24337
Review URL: http://codereview.chromium.org/273023
------------------------------------------------------------------------
r28743 | erikkay@chromium.org | 2009-10-12 23:43:37 +0200 (Mon, 12 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Fixed data race between GetDatabase and CheckURL at startup.
Also did a bit of code cleanup.

BUG=11106
TEST=use tsan on ViewSourceTest.DoesBrowserRenderInViewSource

Review URL: http://codereview.chromium.org/273020
------------------------------------------------------------------------
r28734 | shess@chromium.org | 2009-10-12 22:24:26 +0200 (Mon, 12 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm

Revert "[Mac] Add breakpad info for crashes in the target/action dispatcher."

Breaks the Release compile somehow.  Sigh.

TBR=michaeln,mmoss

Review URL: http://codereview.chromium.org/266053
------------------------------------------------------------------------
r28731 | shess@chromium.org | 2009-10-12 21:59:31 +0200 (Mon, 12 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm

[Mac] Add breakpad info for crashes in the target/action dispatcher.

-[NSApplication sendAction:to:from:] is a central dispatcher for
target-action messages sent by controls.  Backtraces from here often
contain only Cocoa messages, making it hard to tell where things are
at when a freed target gets messaged.  Add additional info like the
action being requested and the tag of the sender.

http://crbug.com/24460
TEST=Browser continues to work.

Review URL: http://codereview.chromium.org/269039
------------------------------------------------------------------------
r28728 | sky@chromium.org | 2009-10-12 21:22:26 +0200 (Mon, 12 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/input_window_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_host_gtk.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.h
   M /trunk/src/views/controls/menu/menu_host_win.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view.h
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/menu/submenu_view.h
   M /trunk/src/views/controls/menu/view_menu_delegate.h

Converts some uses of native_view to native_window. This is necessitated
by wanting to parent bookmarkeditor to browserwindow, which returns a
native_window.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/270067
------------------------------------------------------------------------
r28725 | pkasting@chromium.org | 2009-10-12 21:08:58 +0200 (Mon, 12 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Make function definition order (.cc) match function declaration order (.h).  No code changes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267055
------------------------------------------------------------------------
r28716 | sky@chromium.org | 2009-10-12 19:44:40 +0200 (Mon, 12 Oct 2009) | 13 lines
Changed paths:
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_views.cc (from /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc:28562)
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_views.h (from /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h:28562)
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/menu/simple_menu_model.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Gets blocked popups to work on views/gtk. I had to fix a couple of
additional things here:

. Avoid doing anything in OnSizeAllocation if the size hasn't
  changed. Because of how gtk works I was getting stuck in a loop if I
  OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
  is a check.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261051
------------------------------------------------------------------------
r28712 | mpcomplete@chromium.org | 2009-10-12 19:21:53 +0200 (Mon, 12 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/manifest.json

Fix a browser crash when calling browserAction.setIcon(invalidIndex).

BUG=24354
TEST=Load the test_browser_action extension and click on the button a few times. It should cycle between a printer and animating shapes without crashing.

Review URL: http://codereview.chromium.org/261049
------------------------------------------------------------------------
r28710 | sky@chromium.org | 2009-10-12 19:03:59 +0200 (Mon, 12 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Forwards mouse leave to renderer for views/gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/269051
------------------------------------------------------------------------
r28709 | thakis@chromium.org | 2009-10-12 18:18:07 +0200 (Mon, 12 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Send key equivalents to renderer first.

Based on a patch by avi@.

See also http://codereview.chromium.org/271054 .

Known issues:
* Breaks if any menu item ever uses a keyboard accelerator that doesn't use cmd as part of the flags.

(* Suppressing keypress() doesn't prevent default action (suppressing keydown() works though. Both Firefox and Safari prevent the default action when either is suppressed). This seems to be broken on linux and windows too, though  – it seems to match IE8, but not Firefox or Safari. I guess this is the question for the web council.)

BUG=15090
TEST=Cmd-f now sucks when used on google docs.

Review URL: http://codereview.chromium.org/242069
------------------------------------------------------------------------
r28706 | phajdan.jr@chromium.org | 2009-10-12 17:48:32 +0200 (Mon, 12 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Fix ChromeOS build by adding missing header.

TBR=brettw

Review URL: http://codereview.chromium.org/274002
------------------------------------------------------------------------
r28705 | phajdan.jr@chromium.org | 2009-10-12 17:32:07 +0200 (Mon, 12 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/omnibox_search_hint.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/file_system_accessor.h
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/site_instance.cc
   M /trunk/src/chrome/browser/renderer_host/site_instance.h
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/ui/ui_layout_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Header dependency cleanup in chrome/

- reduce header dependencies
- remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h!

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/245011
------------------------------------------------------------------------
r28704 | dmaclach@chromium.org | 2009-10-12 17:19:16 +0200 (Mon, 12 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm

Fix for the bookmark_bar which got ignored in my earlier
theming CL (28613). This fixes up drawing so the themes
line up correctly.

BUG=24481, 24484
TEST=None

Review URL: http://codereview.chromium.org/271045
------------------------------------------------------------------------
r28699 | thomasvl@chromium.org | 2009-10-12 14:13:49 +0200 (Mon, 12 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Add a learn more hyper link button to the privacy settings area of under the hood prefs.

BUG=24424
TEST=under the hood has a working learn more button in the privacy section.
Review URL: http://codereview.chromium.org/268028
------------------------------------------------------------------------
r28696 | johnnyg@chromium.org | 2009-10-12 07:44:26 +0200 (Mon, 12 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/notifications
   A /trunk/src/chrome/browser/notifications/balloons.h
   A /trunk/src/chrome/browser/notifications/desktop_notification_service.cc
   A /trunk/src/chrome/browser/notifications/desktop_notification_service.h
   A /trunk/src/chrome/browser/notifications/desktop_notification_service_linux.cc
   A /trunk/src/chrome/browser/notifications/desktop_notification_service_mac.mm
   A /trunk/src/chrome/browser/notifications/desktop_notification_service_win.cc
   A /trunk/src/chrome/browser/notifications/notification.h
   A /trunk/src/chrome/browser/notifications/notification_object_proxy.cc
   A /trunk/src/chrome/browser/notifications/notification_object_proxy.h
   A /trunk/src/chrome/browser/notifications/notifications_prefs_cache.cc
   A /trunk/src/chrome/browser/notifications/notifications_prefs_cache.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/resources/notification.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/notification_provider.cc
   M /trunk/src/chrome/test/testing_profile.h

Browser side support (sans UI) for desktop notifications.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/194108

Review URL: http://codereview.chromium.org/271052
------------------------------------------------------------------------
r28695 | mark@chromium.org | 2009-10-12 06:32:14 +0200 (Mon, 12 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chrome_application_mac.h
   M /trunk/src/chrome/browser/chrome_application_mac.mm

SIGTERM should cause the application to exit on the Mac.

BUG=23551
TEST=Send SIGTERM to the browser process.  It should exit cleanly.
Review URL: http://codereview.chromium.org/269048
------------------------------------------------------------------------
r28691 | brettw@chromium.org | 2009-10-11 22:21:32 +0200 (Sun, 11 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/blit.h
   A /trunk/src/app/gfx/gtk_native_view_id_manager.cc (from /trunk/src/base/gfx/gtk_native_view_id_manager.cc:28672)
   A /trunk/src/app/gfx/gtk_native_view_id_manager.h (from /trunk/src/base/gfx/gtk_native_view_id_manager.h:28672)
   A /trunk/src/app/gfx/native_widget_types.h (from /trunk/src/base/gfx/native_widget_types.h:28672)
   A /trunk/src/app/gfx/native_widget_types_gtk.cc (from /trunk/src/base/gfx/native_widget_types_gtk.cc:28672)
   A /trunk/src/app/win
   A /trunk/src/app/win/window_impl.cc (from /trunk/src/base/window_impl.cc:28672)
   A /trunk/src/app/win/window_impl.h (from /trunk/src/base/window_impl.h:28672)
   M /trunk/src/base/base.gyp
   D /trunk/src/base/gfx/gtk_native_view_id_manager.cc
   D /trunk/src/base/gfx/gtk_native_view_id_manager.h
   D /trunk/src/base/gfx/native_widget_types.h
   D /trunk/src/base/gfx/native_widget_types_gtk.cc
   D /trunk/src/base/window_impl.cc
   D /trunk/src/base/window_impl.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/download_util_mac.mm
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/fonts_languages_window.h
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.h
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/native_window_notification_source.h
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h
   A /trunk/src/tools/memory_watcher/DEPS
   M /trunk/src/tools/memory_watcher/hotkey.h
   M /trunk/src/tools/memory_watcher/memory_watcher.gyp
   M /trunk/src/views/controls/button/native_button_wrapper.h
   M /trunk/src/views/controls/combobox/native_combobox_wrapper.h
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/slider/native_slider_wrapper.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/screen.h
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/tooltip_manager_win.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window.h
   M /trunk/src/webkit/default_plugin/DEPS
   M /trunk/src/webkit/default_plugin/plugin_impl_win.h
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/plugin_instance.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webplugin_page_delegate.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h

Move native_widget_types and gtk_native_view_id_manager from base/gfx to
app/gfx in preparation for removing the base_gfx project. This also moves
base/window_impl.cc to app/win/window_impl because this file shouldn't be in
base.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/273017
------------------------------------------------------------------------
r28690 | amanda@chromium.org | 2009-10-11 21:02:15 +0200 (Sun, 11 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc

Change Mac fullscreen mode to be a stack, not a flag.  This fixes crashes and
misbehavior of fullscreen browser windows and plugins, especially when they
interact.
BUG=23571,24216
TEST=open up multiple browser windows, make them fullscreen, and go to pages
(such as video players) that can invoke full screen plugins.  The menu bar
should hide when the first window becomes fullscreen, show again after the
last window stops being fullscreen, and not crash at any of those transitions.
Review URL: http://codereview.chromium.org/269022
------------------------------------------------------------------------
r28674 | brettw@chromium.org | 2009-10-10 22:40:50 +0200 (Sat, 10 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/base/DEPS
   M /trunk/src/base/base.gyp
   M /trunk/src/base/i18n/icu_string_conversions.cc
   M /trunk/src/base/i18n/icu_string_conversions.h
   A /trunk/src/base/i18n/icu_string_conversions_unittest.cc (from /trunk/src/base/string_util_unittest.cc:28568)
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/webkit/appcache/manifest_parser.cc
   M /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc

Remove the dependency on i18n/icu_string_conversions from base/string_util.h.
Fix up all files requireing this header to include it directly. Split out the
ICU-dependent string util unit tests into a new file
base/i18n/icu_string_util_unittest.cc

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/269034
------------------------------------------------------------------------
r28673 | dmaclach@chromium.org | 2009-10-10 22:35:40 +0200 (Sat, 10 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_frame_view.mm

Change back from using NSRectFillWithOperation to plain NSRectFill
because according to shark we were spending a lot of time doing 
the alpha blending that we didn't need. In fact we didn't even
want it because it was leaving us artifacts in the corners of our
windows.

BUG=24490,24500
TEST=none

Review URL: http://codereview.chromium.org/273015
------------------------------------------------------------------------
r28667 | yusukes@google.com | 2009-10-10 20:19:04 +0200 (Sat, 10 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Don't draw the red line when the security level is SECURE.

Review URL: http://codereview.chromium.org/273016/show

BUG=24510
TEST=see the bug

------------------------------------------------------------------------
r28655 | ananta@chromium.org | 2009-10-10 07:41:23 +0200 (Sat, 10 Oct 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/accessibility/view_accessibility.h
   M /trunk/src/views/accessibility/view_accessibility_wrapper.cc
   M /trunk/src/views/accessibility/view_accessibility_wrapper.h
   M /trunk/src/views/view.cc

Accessibility information from the renderer was not being returned to tools like screen readers, etc.
This was because the object implementing the root IAccessible interface did not know how to navigate
a native render view. To work around this, we now check if the underlying view is a native view in
our root IAccessible::get_accChild function and if yes we send the WM_GETOBJECT message to the
corresponding RenderWidgetHostViewWin class, which returns an IAccessible interface which then can
expose information from the renderer.

The other changes in the accessibility code are for some crashes I observed while testing the 
screen readers like nvda, the Windows screen reader which send a flurry of WM_GETOBJECT messages
leading to some race conditions.

We also ensure that the accessibility information for a view is torn down when the view is destroyed.

Fixes portions of http://code.google.com/p/chromium/issues/detail?id=13291

Bug=13291

Review URL: http://codereview.chromium.org/261044
------------------------------------------------------------------------
r28649 | tim@chromium.org | 2009-10-10 03:09:44 +0200 (Sat, 10 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Revert r28645 - "Render sync code inactive..."
Vive le sync!

Review URL: http://codereview.chromium.org/269044
------------------------------------------------------------------------
r28645 | tim@chromium.org | 2009-10-10 03:01:00 +0200 (Sat, 10 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Render sync code inactive without any way to enable.

**** I WILL REVERT THIS PATCH IMMEDIATELY. It is a kill switch that may need to be merged in later. ***

Patching this CL is a quick shut-off mechanism in the event sync needs to de disabled prior to a release build.

TEST=No sync UI visible.  about:sync shows 'SYNC_DISABLED', no 'Sync Data' folder created when run.

Review URL: http://codereview.chromium.org/270049
------------------------------------------------------------------------
r28642 | tim@chromium.org | 2009-10-10 02:42:53 +0200 (Sat, 10 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.cc
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.h
   D /trunk/src/chrome/browser/sync/util/compat_pthread.h
   D /trunk/src/chrome/browser/sync/util/pthread_helpers.cc
   D /trunk/src/chrome/browser/sync/util/pthread_helpers.h
   D /trunk/src/chrome/browser/sync/util/pthread_helpers_fwd.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/tools/build/win/FILES

Remove pthreads from build and installer files.
We can yank it from deps/ following this.

BUG=19895
TEST=sync_unit_tests

Review URL: http://codereview.chromium.org/261042
------------------------------------------------------------------------
r28628 | sidchat@chromium.org | 2009-10-10 01:41:59 +0200 (Sat, 10 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Browser actions: limit minimum size of omnibox. When decreasing the width of the omnibox, the Browser actions start falling off one by one till there are two left. After that, the omnibox itself starts shrinking, as it normally does. Note that if there is only one browser action, then it remains sticky to the toolbar.

BUG=23962
TEST=none
Review URL: http://codereview.chromium.org/262008
------------------------------------------------------------------------
r28627 | hawk@chromium.org | 2009-10-10 01:41:56 +0200 (Sat, 10 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Add EV certificate text to the Mac location bar
BUG=10910
TEST=EV sites (e.g., http://www.paypal.com and most bank sites) get a green text description next to the lock icon in the location bar, non-EV (and non-SSL) sites do not
Review URL: http://codereview.chromium.org/216031
------------------------------------------------------------------------
r28621 | sidchat@chromium.org | 2009-10-10 00:51:39 +0200 (Sat, 10 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Change text for extension download UI.

BUG=23105
TEST=none
Review URL: http://codereview.chromium.org/261026
------------------------------------------------------------------------
r28618 | estade@chromium.org | 2009-10-10 00:47:22 +0200 (Sat, 10 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Windows: use NtpBackgroundUtil to draw detached bookmark bar.

BUG=23836

Review URL: http://codereview.chromium.org/268027
------------------------------------------------------------------------
r28617 | chocobo@google.com | 2009-10-10 00:45:01 +0200 (Sat, 10 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_network_library.h

A couple fixes for network cros library
- no need to send updates after connecting to wifi. the cros api will handle this.
- clear state before parsing ServiceStatus in case the network no longer exists.
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/271038
------------------------------------------------------------------------
r28613 | thakis@chromium.org | 2009-10-10 00:37:55 +0200 (Sat, 10 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/background_gradient_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/browser_frame_view.h
   A /trunk/src/chrome/browser/cocoa/browser_frame_view.mm
   A /trunk/src/chrome/browser/cocoa/browser_frame_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.h
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view.mm
   M /trunk/src/chrome/chrome.gyp

Several theming fixes for the Mac. Sorry for the extensive change, but they
were all sort of intertwined.

Fixes up patterns in general so that they are all in phase.
Moves the window widget buttons down by two pixels.
Draws overlays correctly.
Fixes up some accessibility issues with the default window widgets.
Gets rid of some out of date files (tab_cell).

BUG=18438, 18547, 19851, 20295, 22213, 23651, 24338
TEST=Launch Chrome. Switch to "dots" theme from the Google themes. Create a couple of tabs. Check to make sure that the background pattern line up with the tabs. Move the tabs around. Check that the hightlight colors and text colors look correct for all of the tabs. Make sure the patterns stay lined up. Resize the window, make sure none of the patterns move around. Create new windows by dragging the tabs out of the windows and make sure a new window is created with the correct pattern. Show the "find" bar. Make sure its pattern lines up correctly with the tabbar. Switch to default theme. Make sure it looks correct and draws properly. Switch to Zen theme and make sure that the overlay at the top draws correctly. Create a new window. make sure that the rollovers in the window widgets work correctly in both the active and inactive window. Mouse down on the zoom button in the inactive window and notice that the window context changes. Move off of the zoom button and mouse up. Mouse down on the miniaturize button on the inactive window and notice that the window context does not change. Move off of the miniaturize button and mouse up. Do the same thing you did for the miniaturize button for the close button. Start up Accessibility Inspector from the developer tools. Make sure that the window widgets report their accessibility information correctly.

Review URL: http://codereview.chromium.org/260009
Patch from dmaclach@chromium.org.
------------------------------------------------------------------------
r28606 | jcampan@chromium.org | 2009-10-09 23:49:58 +0200 (Fri, 09 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disabling a interactive test

Disabling the last browser focus interactive UI tests.
It mysteriously crashing, as with the rest of them that were disabled
yesterday (this one was left out, probably unintentionaly).

BUG=http://crbug.com/24400
TBR=estade

Review URL: http://codereview.chromium.org/272016
------------------------------------------------------------------------
r28603 | shess@chromium.org | 2009-10-09 23:30:10 +0200 (Fri, 09 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm

[Mac] Fix some omnibox breakage for small windows.

Change the code to decorate the contents string normally, then elide
the marked-up string if it doesn't fit.

http://crbug.com/23279
TEST=See bug.

Review URL: http://codereview.chromium.org/264012
------------------------------------------------------------------------
r28601 | aa@chromium.org | 2009-10-09 23:28:19 +0200 (Fri, 09 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/dddddddddddddddddddddddddddddddd
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/dddddddddddddddddddddddddddddddd/1.0
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/dddddddddddddddddddddddddddddddd/1.0/git_hates_empty_dirs
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/1.0
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/1.0/manifest.json

Improve error messages when a manifest is not readable or not valid JSON.

Review URL: http://codereview.chromium.org/251003
------------------------------------------------------------------------
r28600 | jianli@chromium.org | 2009-10-09 23:26:29 +0200 (Fri, 09 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm

Fix the problem that files cannot be dropped on the input widget on the Mac.

BUG=19529
TEST=none

Review URL: http://codereview.chromium.org/270026
------------------------------------------------------------------------
r28597 | pkasting@chromium.org | 2009-10-09 23:10:43 +0200 (Fri, 09 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix spacing that was supposed to go in a previous checkin and somehow 
missed it.

------------------------------------------------------------------------
r28595 | aa@chromium.org | 2009-10-09 22:52:48 +0200 (Fri, 09 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   A /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc (from /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.cc:28590)
   A /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   D /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.h
   A /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc (from /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc:28590)
   A /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h (from /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h:28590)
   D /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/chrome.gyp

Reland: Rename ThemePreviewInfobarDelegate to
ThemeInstalledInfoBarDelegate

Contributed by Thiago Farina <tfarina@gmail.com>

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r28592 | evan@chromium.org | 2009-10-09 22:43:51 +0200 (Fri, 09 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

linux/mac: use "First Run", not "First Run Dev"

This should've been done back when we finished the First Run dialogs,
but better late than never.

BUG=24397
TEST=Run Chrome on an old profile; you should not get a first run dialog if you've already clicked through and your user data dir should now contain a "First Run" file and no "First Run Dev" file.  Run Chrome on a new profile; First Run should still work as before.

Review URL: http://codereview.chromium.org/273009
------------------------------------------------------------------------
r28587 | tim@chromium.org | 2009-10-09 22:26:54 +0200 (Fri, 09 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc

Remove pthreads from event_sys_unittest.

BUG=19895
TEST=EventSys

Review URL: http://codereview.chromium.org/273007
------------------------------------------------------------------------
r28586 | huanr@chromium.org | 2009-10-09 22:26:12 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix Valgrind UMR errors by initializing thumbnail pixels.
Original code review: http://codereview.chromium.org/270040

BUG=17067
TEST=none

Review URL: http://codereview.chromium.org/264024
------------------------------------------------------------------------
r28584 | brettw@chromium.org | 2009-10-09 21:44:28 +0200 (Fri, 09 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Fix header.
------------------------------------------------------------------------
r28577 | brettw@chromium.org | 2009-10-09 20:44:00 +0200 (Fri, 09 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc

Really fix the changed include to fix the ChromeOS build this time.

BUG=none
TEST=none
------------------------------------------------------------------------
r28573 | brettw@chromium.org | 2009-10-09 20:37:42 +0200 (Fri, 09 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/clock_menu_button.cc

Fix wrong include to fix the CromeOS build.

BUG=none
TEST=none
------------------------------------------------------------------------
r28572 | brettw@chromium.org | 2009-10-09 20:31:32 +0200 (Fri, 09 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Fix a missed include rename to fix the build.

BUG=none
TET=none
------------------------------------------------------------------------
r28569 | brettw@chromium.org | 2009-10-09 20:20:30 +0200 (Fri, 09 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/app/test_suite.h
   M /trunk/src/base/DEPS
   M /trunk/src/base/base.gyp
   A /trunk/src/base/i18n/icu_util.cc (from /trunk/src/base/icu_util.cc:28404)
   A /trunk/src/base/i18n/icu_util.h (from /trunk/src/base/icu_util.h:28404)
   A /trunk/src/base/i18n/time_formatting.cc (from /trunk/src/base/time_format.cc:28404)
   A /trunk/src/base/i18n/time_formatting.h (from /trunk/src/base/time_format.h:28404)
   A /trunk/src/base/i18n/word_iterator.cc (from /trunk/src/base/word_iterator.cc:28404)
   A /trunk/src/base/i18n/word_iterator.h (from /trunk/src/base/word_iterator.h:28404)
   A /trunk/src/base/i18n/word_iterator_unittest.cc (from /trunk/src/base/word_iterator_unittest.cc:28404)
   D /trunk/src/base/icu_util.cc
   D /trunk/src/base/icu_util.h
   D /trunk/src/base/perf_test_suite.h
   D /trunk/src/base/run_all_perftests.cc
   D /trunk/src/base/run_all_unittests.cc
   A /trunk/src/base/test
   A /trunk/src/base/test/perf_test_suite.h (from /trunk/src/base/perf_test_suite.h:28404)
   A /trunk/src/base/test/run_all_perftests.cc (from /trunk/src/base/run_all_perftests.cc:28404)
   A /trunk/src/base/test/run_all_unittests.cc (from /trunk/src/base/run_all_unittests.cc:28404)
   A /trunk/src/base/test/test_file_util.h (from /trunk/src/base/test_file_util.h:28404)
   A /trunk/src/base/test/test_file_util_linux.cc (from /trunk/src/base/test_file_util_linux.cc:28404)
   A /trunk/src/base/test/test_file_util_mac.cc (from /trunk/src/base/test_file_util_mac.cc:28404)
   A /trunk/src/base/test/test_file_util_posix.cc (from /trunk/src/base/test_file_util_posix.cc:28404)
   A /trunk/src/base/test/test_file_util_win.cc (from /trunk/src/base/test_file_util_win.cc:28404)
   A /trunk/src/base/test/test_suite.h (from /trunk/src/base/test_suite.h:28404)
   D /trunk/src/base/test_file_util.h
   D /trunk/src/base/test_file_util_linux.cc
   D /trunk/src/base/test_file_util_mac.cc
   D /trunk/src/base/test_file_util_posix.cc
   D /trunk/src/base/test_file_util_win.cc
   D /trunk/src/base/test_suite.h
   D /trunk/src/base/time_format.cc
   D /trunk/src/base/time_format.h
   D /trunk/src/base/word_iterator.cc
   D /trunk/src/base/word_iterator.h
   D /trunk/src/base/word_iterator_unittest.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/perf/perftests.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/tools/convert_dict/convert_dict.cc
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/chrome_frame/chrome_frame.gyp
   M /trunk/src/courgette/encoded_program_fuzz_unittest.cc
   M /trunk/src/courgette/run_all_unittests.cc
   M /trunk/src/ipc/ipc_tests.cc
   M /trunk/src/media/base/run_all_unittests.cc
   M /trunk/src/net/base/net_test_suite.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/run_all_unittests.cc
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/tools/test_shell/run_all_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Move more ICU-dependent stuff from base into base/i18n. Some test stuff also
depended on this, so to make the DEPS work out, I made a new base/test
directory where I moved the testing-related files into a new directory
base/test.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/266038
------------------------------------------------------------------------
r28567 | yaar@chromium.org | 2009-10-09 20:17:44 +0200 (Fri, 09 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/webkit/api/public/WebContextMenuData.h
   M /trunk/src/webkit/api/public/WebViewClient.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/webkit.gyp

Moving ShowContextMenu out of WebView_delegate and into WebViewClient
(Part of the Webkit API refactoring effort).

Review URL: http://codereview.chromium.org/265011
------------------------------------------------------------------------
r28565 | mpcomplete@chromium.org | 2009-10-09 20:13:27 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   A /trunk/src/chrome/browser/extensions/extension_messages_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   A /trunk/src/chrome/test/data/extensions/api_test/connect_external
   A /trunk/src/chrome/test/data/extensions/api_test/connect_external/connect.html
   A /trunk/src/chrome/test/data/extensions/api_test/connect_external/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html

Implement chrome.extension.connectExternal and fix various API inconsistencies.

BUG=23583
BUG=17910
TEST=no

Review URL: http://codereview.chromium.org/262016
------------------------------------------------------------------------
r28564 | pkasting@chromium.org | 2009-10-09 20:13:23 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Allow the NTP to be bookmarked.

BUG=none
TEST=Try to bookmark the NTP.
Review URL: http://codereview.chromium.org/269028
------------------------------------------------------------------------
r28562 | chocobo@google.com | 2009-10-09 20:08:43 +0200 (Fri, 09 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   M /trunk/src/chrome/browser/chromeos/cros_network_library.h

Update cros network library code to work with the latest cros API that sends network updates with ServiceStatus. This fixes the issue where if we are connected to ethernet, we won't get wifi network updates.
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/269029
------------------------------------------------------------------------
r28560 | erg@chromium.org | 2009-10-09 20:01:08 +0200 (Fri, 09 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_constants.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/chrome.gyp

Mac: Theme the bookmark bar on the new tab page.

- XIB change: The controller has a connection to buttonView_.
- BrowserThemeProviderMac: Fix a bug where we weren't returning
  default colors; we returned nil instead.
- The majority of the implementation is actually the cross platform
  NtpBackgroundUtil::PaintBackgroundDetachedMode. We do platform
  specific drawing on top of the background, though.

TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithNoImage
TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithBgImage
BUG=http://crbug.com/17625

Review URL: http://codereview.chromium.org/266027
------------------------------------------------------------------------
r28559 | tony@chromium.org | 2009-10-09 19:58:02 +0200 (Fri, 09 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h

Revert "Revert "Start the database query for the new tab page results as soon""

This re-applies r28549 with a NULL pointer check for the HistoryService, which
can be NULL during unit tests.

It also means that if the user does a view-source on the new tab page, we make
a wasted query to the history service, but I guess that's not a big deal.

TBR=arv

Review URL: http://codereview.chromium.org/267039
------------------------------------------------------------------------
r28556 | jcampan@chromium.org | 2009-10-09 19:56:16 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/views/controls/native/native_view_host.cc

When a GtkWidget was destroyed the NVH would not be detached.
There was a hack in location_bar_view to prevent an assert, but it would cause an other assert.
Also fixed a double delete with the find_bar_host.

BUG=None
TEST=Start Chrome Linux toolkit view. Close it. It should not assert.
Review URL: http://codereview.chromium.org/266034
------------------------------------------------------------------------
r28551 | tony@chromium.org | 2009-10-09 19:06:06 +0200 (Fri, 09 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h

Revert "Start the database query for the new tab page results as
soon" because TabContentsTest.NTPViewSource is crashing on linux.

This reverts commit r28549.

Review URL: http://codereview.chromium.org/273004
------------------------------------------------------------------------
r28549 | tony@chromium.org | 2009-10-09 18:51:52 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   M /trunk/src/chrome/browser/dom_ui/most_visited_handler.h

Start the database query for the new tab page results as soon
as we create the MostVisitedHandler.

I find that in practice, once the new tab page is warm, we get
the results before the new tab page html loads.

Review URL: http://codereview.chromium.org/267034
------------------------------------------------------------------------
r28548 | thakis@chromium.org | 2009-10-09 18:49:22 +0200 (Fri, 09 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h

typo. TBR=pinkerton

Review URL: http://codereview.chromium.org/272010
------------------------------------------------------------------------
r28547 | tony@chromium.org | 2009-10-09 18:45:48 +0200 (Fri, 09 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Just add a comment to explain some empty functions.

Review URL: http://codereview.chromium.org/271028
------------------------------------------------------------------------
r28542 | pinkerton@chromium.org | 2009-10-09 18:25:41 +0200 (Fri, 09 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Make sure we call orderOut: before calling performClose:. This ensures the window is hidden immediately so we don't see any teardown that may ensure.
BUG=23959
TEST=closing windows with lots of tabs, quitting with lots of tabs. dragging while windows close.
Review URL: http://codereview.chromium.org/264022
------------------------------------------------------------------------
r28541 | jeremy@chromium.org | 2009-10-09 18:23:10 +0200 (Fri, 09 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/sandbox_mac.h
   A /trunk/src/chrome/common/sandbox_mac.mm (from /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm:28540)
   M /trunk/src/chrome/renderer/renderer.sb
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm

Some fixes to the OS X Sandbox:

* Added a command line option to enable verbose logging in the Sandbox.  This will be useful when we start looking at the information in ChromeBot.
* Modified the code that splices the homedir path into the Sandbox file.  This code is now only used on 10.6 and no longer uses a regex.
* Moved sandbox code out into a sandbox_mac file.
* Changed 10.6 seed release references -> 10.6 .

BUG=21483
TEST=Browser should launch and display NTP correctly on OS X 10.5 & 10.6

Review URL: http://codereview.chromium.org/242165
------------------------------------------------------------------------
r28539 | thomasvl@chromium.org | 2009-10-09 17:56:00 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/Preferences.xib
   D /trunk/src/chrome/browser/cocoa/preferences_localizer.h
   D /trunk/src/chrome/browser/cocoa/preferences_localizer.mm
   M /trunk/src/chrome/chrome.gyp

Remove the preference localizer class.
Add some new strings that didn't exit to the grd file needed by Mac prefs.
Update all the strings in the file to use the localizer.

BUG=20538
TEST=Almost all the pref strings should be localized, there area few new ones that won't show up localized until we do a TC run.  The controls do *NOT* auto size yet, so there can be clipping/oversized controls.
Review URL: http://codereview.chromium.org/273001
------------------------------------------------------------------------
r28528 | thakis@chromium.org | 2009-10-09 09:27:14 +0200 (Fri, 09 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Forgot backspace/shift-backspace.

This should've been a two-line patch, but due to http://codereview.chromium.org/255028 it became a four-line patch.

BUG=12557
TEST=Focus text box on a web page. backspace should delete text. Focus webpage background. backspace/shift-backspace should go history back/forward. When the omnibox is focussed, backspace should delete text, but cmd-1-9 should still switch tabs.

Review URL: http://codereview.chromium.org/272008
------------------------------------------------------------------------
r28525 | aa@chromium.org | 2009-10-09 06:44:37 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   D /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   A /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.cc (from /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc:28523)
   A /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.h
   D /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   A /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc (from /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc:28523)
   A /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h (from /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h:28523)
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/chrome.gyp

Revert r28519-28523. Accidentally used wrong command,
committing a bunch of local changes individually with
bad commit messages.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r28524 | rafaelw@chromium.org | 2009-10-09 06:39:02 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/test/data/extensions/samples/gmail_browser_action/background.html
   A /trunk/src/chrome/test/data/extensions/samples/gmail_browser_action/blank.png
   M /trunk/src/chrome/test/data/extensions/samples/gmail_browser_action/manifest.json

set BrowserActionButton inset to 0 so icon can draw to edges.

Also, implement cool spinning gmail icon when unread count changes.

Review URL: http://codereview.chromium.org/264021
------------------------------------------------------------------------
r28523 | aa@chromium.org | 2009-10-09 06:30:20 +0200 (Fri, 09 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc

whee
------------------------------------------------------------------------
r28522 | aa@chromium.org | 2009-10-09 06:30:15 +0200 (Fri, 09 Oct 2009) | 1 line
Changed paths:
   D /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.h
   D /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h

remove old files
------------------------------------------------------------------------
r28520 | aa@chromium.org | 2009-10-09 06:30:06 +0200 (Fri, 09 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h

patch from issue 261007
------------------------------------------------------------------------
r28519 | aa@chromium.org | 2009-10-09 06:29:58 +0200 (Fri, 09 Oct 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.cc
   A /trunk/src/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h
   A /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc
   A /trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h

copy files to new location to help git cl patch
------------------------------------------------------------------------
r28517 | tim@chromium.org | 2009-10-09 06:12:46 +0200 (Fri, 09 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h

[Windows] Add a button in bookmark manager to show the status of bookmarks synchronization.It does the item 5 of the BUG only.This add a button after |Tools| menu. 

And it's showed all the time, with the current status of sync. The user should run 'chrome --enable-sync' to see it. 

Patch by Thiago Farina, http://codereview.chromium.org/256017

BUG=23136
TEST=compiled and ran on Windows. 
Review URL: http://codereview.chromium.org/268021
------------------------------------------------------------------------
r28514 | tim@chromium.org | 2009-10-09 05:56:00 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Sync: Remove pthreads from syncapi. Convert AddressWatchThread from pthreads to chrome threads.

BUG=19895

Review URL: http://codereview.chromium.org/265054
------------------------------------------------------------------------
r28512 | estade@chromium.org | 2009-10-09 05:04:14 +0200 (Fri, 09 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Spellchecker:

Move file accesses during initialization to file thread. Also fix a rare (and harmless) memory leak. Also introduce a rare (and harmless) memory leak.

TEST=added dchecks, ran spellcheck unit tests, clicked around, changed dictionaries, added words
BUG=22984
BUG=21924
BUG=1123096

Review URL: http://codereview.chromium.org/269020
------------------------------------------------------------------------
r28511 | estade@chromium.org | 2009-10-09 05:04:04 +0200 (Fri, 09 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h

Make on-demand download directory creation safe.

If the SavePackage or SaveFileManager went down at the wrong time (most likely during shutdown), we potentially could have crashed. Avoid this race by using a specialized Task instaed of SaveFileManager, and by making the SavePackage callback task scoped.

BUG=none
TEST=downloads still work, whether or not the downloads dir exists.

Review URL: http://codereview.chromium.org/262019
------------------------------------------------------------------------
r28510 | estade@chromium.org | 2009-10-09 05:03:42 +0200 (Fri, 09 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

GTK: Draw a strikethrough over bad https.

TEST=https://metafilter.com
BUG=23339

Review URL: http://codereview.chromium.org/261033
------------------------------------------------------------------------
r28509 | estade@chromium.org | 2009-10-09 05:03:33 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc

Protect the user against whitelisted external protocol bombardment as well as greylisted.

BUG=3628

Review URL: http://codereview.chromium.org/270006
------------------------------------------------------------------------
r28508 | estade@chromium.org | 2009-10-09 04:59:18 +0200 (Fri, 09 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disable all browser focus tests on windows. They are hanging or crashing on the buildbot.

BUG=24400
TBR=thakis

Review URL: http://codereview.chromium.org/271030
------------------------------------------------------------------------
r28505 | thakis@chromium.org | 2009-10-09 03:26:20 +0200 (Fri, 09 Oct 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   M /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Support cmd-left/right for history.

Since cmd-left/right should not do history if the omnibox is focussed, but cmd-1-9 should work if the omnibox is focussed, we have to differentiate between window- and browser-level shortcuts.

(Because performKeyEquivalent bubbles up from the window -- and if we let it bubble up to the omnibox, then the omnibox handles cmd-left/right just fine, but it swallows cmd-1 and doesn't give us a chance to intercept this. That means cmd-left doesn't work if you hit cmd-l tab, which focusses something that's neither omnibox nor tab contents. This behavior is consistent with safari and camino, and I think it's the best we can do without rewriting event dispatching.

Camino does this here:
http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWindow.mm#128
http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWrapper.mm#1031

)

BUG=12557
TEST=Focus text box on a web page. cmd-left/right should go to start/end of text. Focus webpage background. cmd-left/right \
should go history back/forward. When the omnibox is focussed, cmd-left/right should move the caret, but cmd-1-9 should still switch tabs.

Note that shortcuts still don't work if a subwindow (e.g. find bar, bookmark bubble) has focus.

Review URL: http://codereview.chromium.org/251069
------------------------------------------------------------------------
r28504 | davemoore@chromium.org | 2009-10-09 03:22:47 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Set size before realizing window in chrome os.

Change to avoid race condition over size of popup windows in Chrome OS

Review URL: http://codereview.chromium.org/261025
------------------------------------------------------------------------
r28503 | chron@chromium.org | 2009-10-09 03:21:48 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc

Replace pthreads locks with chrome locks in syncable.cc.
Replace pthreads with chrome platform thread in syncable unittest.

TEST=unit tests included
BUG=19895

Review URL: http://codereview.chromium.org/265033
------------------------------------------------------------------------
r28502 | gregoryd@google.com | 2009-10-09 03:10:42 +0200 (Fri, 09 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h

Bug fix: MetricsService::RecordPluginChanges should handle only plugins

Review URL: http://codereview.chromium.org/264020
------------------------------------------------------------------------
r28500 | derat@chromium.org | 2009-10-09 03:02:48 +0200 (Fri, 09 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/common/gtk_util.cc

Linux: Prevent first-run bubble from getting clipped on high-DPI displays.

Avoids setting the width of the contents vbox (so it can grow if the
combined width of the two buttons exceeds the estimated width of the
bubble's text) and fixes an issue where we were getting even-more-bogus
estimates due to using an unrealized widget.

Also adds a DCHECK() to catch future code that passes unrealized
widgets to gtk_util::GetWidgetSizeFromResources() (I checked the
existing calls to it and they all look fine).

BUG=23367
TEST=tested first-run bubble on displays with various DPIs (75, 120, 200, etc.)

Review URL: http://codereview.chromium.org/265023
------------------------------------------------------------------------
r28498 | mbelshe@google.com | 2009-10-09 03:01:51 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h

Update the SSLClientAuthHandler to use the thread safe reference counter.
It does get invoked both on the ui and io threads.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/267028
------------------------------------------------------------------------
r28496 | chocobo@google.com | 2009-10-09 03:00:20 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/power_menu_button.cc

Implement animation using ThrobAnimation.
Fix so that we show ethernet icon if connected even if wifi is connected.
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/262031
------------------------------------------------------------------------
r28495 | aa@chromium.org | 2009-10-09 02:58:57 +0200 (Fri, 09 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Revert r28489 as it broke the linux build.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r28489 | aa@chromium.org | 2009-10-09 02:45:11 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.cc
   M /trunk/src/chrome/browser/extensions/image_loading_tracker.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Make the max size for ImageTrackingLoader configurable. This makes it so that icons larger than 16px can be used in browser actions.

This is not that useful until we fix the inset issue in the browser action buttons though, so I will not be checking it in.

Review URL: http://codereview.chromium.org/271029
------------------------------------------------------------------------
r28480 | pkasting@chromium.org | 2009-10-09 01:20:20 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc

* Add ctrl-shift-d to bookmark all tabs.
* Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything.
* Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious.

BUG=2935
TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs
Review URL: http://codereview.chromium.org/266029
------------------------------------------------------------------------
r28476 | mattm@chromium.org | 2009-10-09 01:10:15 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc

Coverity: check file_util::ReadFileToString return.

CID=6217
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/257039
------------------------------------------------------------------------
r28470 | brettw@chromium.org | 2009-10-09 01:04:24 +0200 (Fri, 09 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Remove comments and const_cast that is no longer necessary with the latest Skia.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/262017
------------------------------------------------------------------------
r28469 | cpu@chromium.org | 2009-10-09 00:59:39 +0200 (Fri, 09 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h

Add a ticks counter that tells you how idle is a render process

It gives you a timedelta since the last time it was known that the renderer was active

- so far receiving a message from the renderer seems a simple heuristic.
- The goal is to use it to prioritize the use of hot renderers or do something to cold ones.

BUG=none
TEST=test included


Review URL: http://codereview.chromium.org/267018
------------------------------------------------------------------------
r28465 | nick@chromium.org | 2009-10-09 00:52:45 +0200 (Fri, 09 Oct 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   M /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window.h

Measure the sync wizard dialog in appropriate units:
specifically, units proportional to the fonts used inside of it.

We approximate the font chosen by the wizard's CSS.  In actuality, the
CSS chooses a font-face "arial", "sans-serif".  We just use the default
sans serif font; arial is the default value for that property.

This fixes an issue where changing to the "Windows Classic" theme
on Vista would cause the dialog to be resized, clipping its
contents, which are unaffected by the UI font size.

Update the default GRIT sizes to closely match the old ones.

Old vs new:
http://www.corp.google.com/~ncarter/wizard-size-screenshots.png

BUG=21828
TEST=verified old size against new size in Aero Theme with default
settings; verified size stays the same under Classic theme.

Review URL: http://codereview.chromium.org/261017
------------------------------------------------------------------------
r28461 | pkasting@chromium.org | 2009-10-09 00:34:29 +0200 (Fri, 09 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

Add the ability to unload the HistoryBackend.

A small number of places used accessors like in_memory_url_database() or backend_loaded() with the expectation that if they weren't already functional, the history system was in the process of making them so.  I elected to make both of these functions that triggered lazy backend initialization.

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/267019
------------------------------------------------------------------------
r28458 | jhawkins@chromium.org | 2009-10-08 23:50:19 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/mork_reader.h

Coverity: Pass file parameter by reference.

CID=6423
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265046
------------------------------------------------------------------------
r28457 | sky@chromium.org | 2009-10-08 23:49:16 +0200 (Thu, 08 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   A /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc
   A /trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp

Pulls WebDragDest out of TabContentsViewGtk so that it can be used by
both views and gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/265041
------------------------------------------------------------------------
r28455 | jhawkins@chromium.org | 2009-10-08 23:27:17 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Use ASSERT_TRUE, not ASSERT_NE.

TBR=mpcomplete
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270033
------------------------------------------------------------------------
r28454 | mark@chromium.org | 2009-10-08 23:14:44 +0200 (Thu, 08 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/HungRendererDialog.xib
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   A /trunk/src/chrome/browser/cocoa/multi_key_equivalent_button.h
   A /trunk/src/chrome/browser/cocoa/multi_key_equivalent_button.mm
   M /trunk/src/chrome/chrome.gyp

Hung Renderer dialog should dismiss with "Wait" for Enter or Esc

HungRendererDialog.xib: made the "Wait" button's use Return as its normal key
equivalent; changed the "Wait" button's class to MultiKeyEquivalentButton.

BUG=21074
TEST=about:hang.  Return, Enter, Esc, and Command-. (period) should all dismiss
     the Hung Renderer dialog with "Wait".
Review URL: http://codereview.chromium.org/266026
------------------------------------------------------------------------
r28453 | shess@chromium.org | 2009-10-08 23:14:19 +0200 (Thu, 08 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Enable "Edit Search Engines" in Omnibox context menu.

Side effect of making the editor a singleton.

http://crbug.com/22512
http://crbug.com/22648
TEST=Right-click in Omnibox, "Edit Search Engines" should bring up the editor.
TEST=Right-click in a popu's Omnibox, no such option on menu.
TEST=Open prefs, select Basic/Manage, close prefs.  Repeat, should not get a second window.

Review URL: http://codereview.chromium.org/220040
------------------------------------------------------------------------
r28452 | jhawkins@chromium.org | 2009-10-08 23:12:35 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Coverity: Assert that GetMutableDictionary returns a non-NULL dictionary.

CID=6421
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270030
------------------------------------------------------------------------
r28451 | jhawkins@chromium.org | 2009-10-08 23:11:43 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store.cc

Coverity: DCHECK that we got a valid dictionary.

CID=6420
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/262029
------------------------------------------------------------------------
r28448 | viettrungluu@chromium.org | 2009-10-08 23:02:36 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

Mac: Resize status bubble when window is resized.

BUG=22956
TEST=Load a (slow-loading) web site so that a status bubble will appear and be visible for a while. While the status bubble is visible, resize the window. The status bubble should move and/or resize appropriately.

Review URL: http://codereview.chromium.org/266018
------------------------------------------------------------------------
r28447 | zork@google.com | 2009-10-08 22:58:16 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disable BrowserFocusTest.BrowsersRememberFocus as it is crashing the
interactive UI tests in win.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270029
------------------------------------------------------------------------
r28446 | sky@chromium.org | 2009-10-08 22:56:54 +0200 (Thu, 08 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Adds the ability to create a bookmark folder populated with a bookmark
for each open tab. I've currently wired this up on windows, will wire
up rest of platforms in a separate cl.

BUG=2935
TEST=on Windows open multiple tabs, right click on a tab and choose
'Bookmark all tabs'. You should then get the bookmark editor with no
url field. Accepting the dialog should result in creating a new folder
with a bookmark for each of the open tabs.

Review URL: http://codereview.chromium.org/270021
------------------------------------------------------------------------
r28445 | mattm@chromium.org | 2009-10-08 22:56:49 +0200 (Thu, 08 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/visitsegment_database.cc

Coverity: fix possible leak in VisitSegmentDatabase.

If we get a non-zero segment_id, a zero segment_id, and another non-zero segment_id, the pud for the zero segment_id will be leaked.  A non-zero segment_id shouldn't happen since it refers to a primary-key in the segments table, but this changes it to check directly whether a pud has been created, and thus makes it more error-proof.  This should be safe, as pud is only stored into the list in two places, in the first it is immediately replaced with a new pud, in the second it is storing the final pud (if any.)

CID=6379
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/265027
------------------------------------------------------------------------
r28435 | tony@chromium.org | 2009-10-08 22:10:13 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/most_visited_handler.cc
   A /trunk/src/chrome/browser/dom_ui/most_visited_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/chrome.gyp

Move MostVisitedHandler into a separate file because it's big.

I'm going to be modifying this file a lot and the single big file
was hard to work with.

Review URL: http://codereview.chromium.org/265040
------------------------------------------------------------------------
r28431 | mark@chromium.org | 2009-10-08 22:03:54 +0200 (Thu, 08 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/app/test_suite.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_paths_mac.mm
   D /trunk/src/chrome/common/mac_app_names.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Get rid of mac_app_names.h.  Replace it with real constants from
chrome_constants.h.

As a side effect of this change, tests will use the framework in the build
directory as their main bundle override for the purposes of resource loading,
instead of looking into the framework inside the application bundle.  This
should be more than sufficient, and is done for simplicity, because a future
change will make it more difficult to locate the correct framework inside the
application bundle unless the product version number is known.

BUG=24220
TEST=product still works and all tests still pass
Review URL: http://codereview.chromium.org/266023
------------------------------------------------------------------------
r28430 | jhawkins@chromium.org | 2009-10-08 21:59:30 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disable BrowserFocusTest.ClickingMovesFocus as it is crashing the interactive UI tests in win.

TBR=zork
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265043
------------------------------------------------------------------------
r28429 | tim@chromium.org | 2009-10-08 21:57:13 +0200 (Thu, 08 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h

Sync: Remove pthreads from ServerConnectionManager and notifier.

BUG=19895

Review URL: http://codereview.chromium.org/266011
------------------------------------------------------------------------
r28426 | thakis@chromium.org | 2009-10-08 21:55:14 +0200 (Thu, 08 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/views/focus/focus_manager.cc

Add about:memory link to task manager.

Since about:memory DCHECK()s atm, the link is not completely hooked up.

In the xib, I've added a square button with height 14 and the new HyperlinkCell, contained in a GTMWidthBasedResizer or how it's called. I made sure the baseline of link on the left and button on the right is at the same height.

BUG=17989,13156
TEST=Open MainMenu.xib, click "Enable" for view->dev->taskman. Build&run chrome. Task manager should contain link.

Review URL: http://codereview.chromium.org/255018
------------------------------------------------------------------------
r28420 | evan@chromium.org | 2009-10-08 20:58:11 +0200 (Thu, 08 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

cleanup: Change AddTabWithNavigationController to simply AddTab.

Patch from Thiago Farina <thiago.farina@gmail.com>.

Review URL: http://codereview.chromium.org/243013
------------------------------------------------------------------------
r28418 | jam@chromium.org | 2009-10-08 20:38:42 +0200 (Thu, 08 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h

Ensure that the plugin HWND doesn't disappear before the plugin gets NPP_SetWindow with a null HWND.

BUG=23694
TEST=tried really hard to write an automated test but couldn't since it's a race condition that repros this (i.e. IO thread is busy and windows message gets dispatched on the UI thread first)
Review URL: http://codereview.chromium.org/268012
------------------------------------------------------------------------
r28417 | thakis@chromium.org | 2009-10-08 20:35:27 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Remove auto-open files from the download shelf on auto-open. This is the Gtk version of r20787 / r28391.

BUG=None, see http://codereview.chromium.org/268008 .
TEST=download a theme, make sure that it doesn't stay in the download shelf. 

Review URL: http://codereview.chromium.org/262022
------------------------------------------------------------------------
r28414 | munjal@chromium.org | 2009-10-08 20:20:37 +0200 (Thu, 08 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.h
   M /trunk/src/chrome/browser/sync/notifier/base/nethelpers.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/util/highres_timer.h
   A /trunk/src/chrome/browser/sync/util/highres_timer_mac.cc
   A /trunk/src/chrome/browser/sync/util/highres_timer_mac.h
   M /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/third_party/expat/expat.gyp
   M /trunk/src/third_party/libjingle/libjingle.gyp
   M /trunk/src/third_party/libjingle/overrides/talk/base/basictypes.h

Part 1 of making sync work on Mac:
- Add high res timer class for mac (we might eventually replace all timer classes with Chrome ones)
- Define POSIX for OS==mac where needed
- Add new liens at the end of some files since otherwise they produce errors on Mac
- Rearrange initializer list of constructors to match declaration order in header; these become warning as error.
- Some chrome.gyp magic

At this point the code compiles but doesn't link due to some missing code on Mac like SSL stuff. But
I thought this was a good check point.

Note that chrome.gyp magic might change in future.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/255053
------------------------------------------------------------------------
r28405 | brettw@chromium.org | 2009-10-08 19:38:30 +0200 (Thu, 08 Oct 2009) | 17 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/base/base.gyp
   M /trunk/src/base/file_util.h
   D /trunk/src/base/file_util_icu.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   A /trunk/src/base/i18n/file_util_icu.cc (from /trunk/src/base/file_util_icu.cc:28217)
   A /trunk/src/base/i18n/file_util_icu.h
   A /trunk/src/base/i18n/file_util_icu_unittest.cc
   A /trunk/src/base/i18n/number_formatting.cc (from /trunk/src/base/string_util_icu.cc:28217)
   A /trunk/src/base/i18n/number_formatting.h
   M /trunk/src/base/string_util.h
   D /trunk/src/base/string_util_icu.cc
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/printing/printed_document.cc
   M /trunk/src/printing/printing_context_win.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc

Separate out some more ICU from base and into base/i18n.

This moves string_util_icu. I moved the number formatting function into
base/i18n/number_formatting and just removed the other function in
string_util_icu which was TrimWhitespaceUTF8. It is only used in a few places
and isn't actually helpful (and the fact that it round-trips through UTF-16 is
better for the caller to see).

This takes out the sorting from the FileEnumerator. The comment says the
sorting is not guaranteed. I moved it into file_util_icu as a standalone
function for callers of FileEnumerator to call manually if they need sorted
results. I modified the directory lister to use this sorting instead, and filed
a bug on doing more optimal JS-based sorting.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/267001
------------------------------------------------------------------------
r28400 | sky@chromium.org | 2009-10-08 18:38:08 +0200 (Thu, 08 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu.cc
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu.h
   R /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc (from /trunk/src/chrome/browser/gtk/bookmark_context_menu.cc:28297)
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h (from /trunk/src/chrome/browser/gtk/bookmark_context_menu.h:28297)
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/chrome.gyp

Renames browser/gtk/bookmark_context_menu to
BoookmarkContextMenuGtk. I need to do this so that views/gtk can use
both BookmarkContextMenu and BookmarkContextMenuGtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/261013
------------------------------------------------------------------------
r28393 | sky@chromium.org | 2009-10-08 17:50:25 +0200 (Thu, 08 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp

Wires up sad tab for views/gtk, and fixes crash in requesting focus
when sad tab is showing.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/270018
------------------------------------------------------------------------
r28392 | thomasvl@chromium.org | 2009-10-08 17:31:06 +0200 (Thu, 08 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/chrome.gyp

Use more images from the pak files
- Remove the alert icon from the download item dangerous download xib.
- Remove the download fav icon from the download shelf xib.
- Update the download shelf to fetch the image from the pak.
- Update the download item to fetch the alert image from the pak.
- Update the bookmark bar to fetch the folder icon from the xib and cache it.
- Remove the three images from the bundles.

BUG=20230
TEST=all three still show their images
Review URL: http://codereview.chromium.org/260012
------------------------------------------------------------------------
r28391 | avi@chromium.org | 2009-10-08 16:06:21 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm

Remove auto-open files from the download shelf on auto-open. This is the Mac version of r20787.

BUG=http://crbug.com/18719
TEST=download a theme, make sure that it doesn't stay in the download shelf.

Review URL: http://codereview.chromium.org/268008
------------------------------------------------------------------------
r28390 | tommi@chromium.org | 2009-10-08 16:00:11 +0200 (Thu, 08 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

Committing change 255087 for Roger:
TBR=amit


http://codereview.chromium.org/255087

Adding a unique runtime Id to Profile objects, that can be used as the key
of the ProfileSiteInstanceMap type. This is used to make sure that Profile
objects can correctly share site information when one profile is derived
from another.

BUG=0
TEST=See unit tests


Review URL: http://codereview.chromium.org/261012
------------------------------------------------------------------------
r28389 | yurys@google.com | 2009-10-08 15:44:35 +0200 (Thu, 08 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: fix and reenable TestDebugIntrinsicProperties
Review URL: http://codereview.chromium.org/268015
------------------------------------------------------------------------
r28388 | craig.schlenter@chromium.org | 2009-10-08 12:54:33 +0200 (Thu, 08 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

linux: fix build error on gcc-4.4 on Ubuntu

Patch by Joel Stanley <joel@jms.id.au>

Review URL: http://codereview.chromium.org/261021
------------------------------------------------------------------------
r28385 | abarth@chromium.org | 2009-10-08 09:26:46 +0200 (Thu, 08 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

One more bad extension.

Review URL: http://codereview.chromium.org/261022
------------------------------------------------------------------------
r28384 | sgk@chromium.org | 2009-10-08 08:56:57 +0200 (Thu, 08 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Display tcmalloc debug output from renderer processes in about:tcmalloc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255080
------------------------------------------------------------------------
r28383 | darin@chromium.org | 2009-10-08 08:50:00 +0200 (Thu, 08 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Fix long tooltips flashing like crazy under Windows. 

Tooltips longer than 1024 chars get truncated. However, to determine if the
tooltip changed, the un-truncated new text was compared to the truncated old
text. Thus, for long tooltips, the tooltip text was considered to be constantly
changing, causing the tooltip to be destroyed and re-created constantly.

Patch by Simon Radford 
R=beng,darin
BUG=4754
TEST=Go to (for example) http://people.mozilla.org/~rdoherty/tooltips.html and
check that the long tooltips do not flash on Windows (I used Vista). 

Review URL: http://codereview.chromium.org/265003


------------------------------------------------------------------------
r28377 | shess@chromium.org | 2009-10-08 06:34:33 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/browser_window.h
   D /trunk/src/chrome/browser/cocoa/browser_window.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm (from /trunk/src/chrome/browser/cocoa/browser_window.mm:28374)
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/chrome.gyp

[Mac] Window titles for Expose.

http://crbug.com/18854
TEST=Titles on mouse-over in Expose.  No extra title in titlebar.

Review URL: http://codereview.chromium.org/259023
------------------------------------------------------------------------
r28369 | aa@chromium.org | 2009-10-08 03:52:56 +0200 (Thu, 08 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/chrome/browser/extensions/isolated_world_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/a.js
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/b.js
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/c.js
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world1/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world2
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/a.js
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/isolated_world2/manifest.json
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc

Make all content scripts from an extension run in the same
isolated world. Chromium side of change.

Review URL: http://codereview.chromium.org/262002
------------------------------------------------------------------------
r28368 | mattm@chromium.org | 2009-10-08 03:51:39 +0200 (Thu, 08 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h

Coverity: remove unused writer_ member from importer classes.

CID=6427
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/267020
------------------------------------------------------------------------
r28367 | nick@chromium.org | 2009-10-08 03:42:23 +0200 (Thu, 08 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/system_metrics.proto
   M /trunk/src/chrome/chrome.gyp

Use the lite runtime for system_metrics.proto.
Have the system_metrics generated code depend on 'protobuf_lite'.

Review URL: http://codereview.chromium.org/242117
------------------------------------------------------------------------
r28366 | chocobo@google.com | 2009-10-08 03:33:21 +0200 (Thu, 08 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/clock_menu_button.cc
   A /trunk/src/chrome/browser/chromeos/clock_menu_button.h
   A /trunk/src/chrome/browser/chromeos/cros_library.cc
   A /trunk/src/chrome/browser/chromeos/cros_library.h
   A /trunk/src/chrome/browser/chromeos/cros_network_library.cc
   A /trunk/src/chrome/browser/chromeos/cros_network_library.h
   A /trunk/src/chrome/browser/chromeos/cros_power_library.cc
   A /trunk/src/chrome/browser/chromeos/cros_power_library.h
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   A /trunk/src/chrome/browser/chromeos/power_menu_button.cc
   A /trunk/src/chrome/browser/chromeos/power_menu_button.h
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/custom_button.h
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h

Refactor cros library code into central location and have the UI elements observe changes.
- implemented power menu button showing remaining battery info.
- implemented clock menu button showing detailed clock info.
- also implemented monitoring of network status change.
- don't show highlighted state for these menu buttons
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/251099
------------------------------------------------------------------------
r28365 | rafaelw@chromium.org | 2009-10-08 03:18:02 +0200 (Thu, 08 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/base/crypto/rsa_private_key.h
   M /trunk/src/base/crypto/rsa_private_key_nss.cc
   M /trunk/src/base/crypto/signature_creator.h
   M /trunk/src/base/crypto/signature_creator_nss.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   D /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc
   M /trunk/src/chrome/chrome.gyp

Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support.

original issue: http://codereview.chromium.org/207062

The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots.

HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.

Additionally, support is added for packaging extensions via ---pack-extension on linux and mac

BUG=20668, 20669

TBR=aa,wtc

Review URL: http://codereview.chromium.org/265032
------------------------------------------------------------------------
r28364 | nick@chromium.org | 2009-10-08 03:16:26 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html

Fix merge and sync alignment issue.

BUG=24217
TEST=screenshotted before and after.

Review URL: http://codereview.chromium.org/261018
------------------------------------------------------------------------
r28361 | pkasting@chromium.org | 2009-10-08 03:00:03 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Revert sanity check; this doesn't actually work since UpdatePopupAppearance() never removes child views (the popup quickly grows to its child limit and then stays there forever; we only show some of the children at a time though).

BUG=20511
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/262018
------------------------------------------------------------------------
r28356 | shess@chromium.org | 2009-10-08 02:29:31 +0200 (Thu, 08 Oct 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/browser_window.h
   A /trunk/src/chrome/browser/cocoa/browser_window.mm (from /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm:28354)
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   D /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   D /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm
   D /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/chrome.gyp

Revert "[Mac] Window titles for Expose."

Revert r28350 aka http://codereview.chromium.org/259023

Passed the trybots because of DCHECK which wasn't there for build
bots.

TBR=zork

Review URL: http://codereview.chromium.org/271015
------------------------------------------------------------------------
r28352 | tim@chromium.org | 2009-10-08 01:57:20 +0200 (Thu, 08 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   A /trunk/src/chrome/browser/sync/engine/auth_watcher_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Sync: Remove pthreads from auth_watcher.

BUG=19895
TEST=AuthWatcherTest
Review URL: http://codereview.chromium.org/246098
------------------------------------------------------------------------
r28350 | shess@chromium.org | 2009-10-08 01:53:51 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/browser_window.h
   D /trunk/src/chrome/browser/cocoa/browser_window.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window.h
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window.mm (from /trunk/src/chrome/browser/cocoa/browser_window.mm:28346)
   A /trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/chrome.gyp

[Mac] Window titles for Expose.

http://crbug.com/18854
TEST=Titles on mouse-over in Expose.  No extra title in titlebar.

Review URL: http://codereview.chromium.org/259023
------------------------------------------------------------------------
r28349 | zork@chromium.org | 2009-10-08 01:46:56 +0200 (Thu, 08 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/highres_timer_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.cc

Update sync unit tests to build on linux
Review URL: http://codereview.chromium.org/218014
------------------------------------------------------------------------
r28348 | pkasting@chromium.org | 2009-10-08 01:44:12 +0200 (Thu, 08 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Add another sanity check, this time that the popup's "open state" (HWND) matches its result count (views).

BUG=20511
TEST=none
Review URL: http://codereview.chromium.org/271013
------------------------------------------------------------------------
r28346 | sky@chromium.org | 2009-10-08 01:27:01 +0200 (Thu, 08 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

Makes sure bookmark ids are unique on reading from file. If not unique
we reassign them. The particular scenario that can lead to this is
when migrating bookmarks out of the db we never reset the ids of the
newly created nodes, so that we wrote all to the file with ids of
0. I'm not patching that code so that I have coverage of the unit
test, and we'll handle fix up during reading anyway.

BUG=24060
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/268001
------------------------------------------------------------------------
r28340 | mattm@chromium.org | 2009-10-08 00:58:45 +0200 (Thu, 08 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Coverity: Check return of TabProxy::GoForward, GoBack, etc

CID=5709,5708,5706,5705,5704,5703,5702,5701,5700
BUG=none
TEST=ran the tests

Review URL: http://codereview.chromium.org/256067
------------------------------------------------------------------------
r28338 | agl@chromium.org | 2009-10-08 00:55:48 +0200 (Thu, 08 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Linux: use SOCK_SEQPACKET rather than SOCK_DGRAM

We use SOCK_SEQPACKET rather than SOCK_DGRAM to prevent the renderer from
sending datagrams to other sockets on the system. The sandbox may prevent the
renderer from calling socket() to create new sockets, but it'll still inherit
some sockets. With PF_UNIX+SOCK_DGRAM, it can call sendmsg to send a datagram
to any (abstract) socket on the same system. With SOCK_SEQPACKET, this is
prevented.

http://codereview.chromium.org/267011

------------------------------------------------------------------------
r28337 | agl@chromium.org | 2009-10-08 00:54:48 +0200 (Thu, 08 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Linux: remove the concept of physical memory from the task manager.

Physical memory isn't a concept on Linux. We have private pages and
proportional set size.

This patch matches the task manager up with about:memory. 'Private
memory' gets you the number of private pages and 'Shared memory' is
the PSS (except on systems with old kernels that don't have PSS, where
it'll be zero).

http://codereview.chromium.org/242096

------------------------------------------------------------------------
r28333 | cira@chromium.org | 2009-10-08 00:49:10 +0200 (Thu, 08 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.h
   M /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   A /trunk/src/chrome/browser/extensions/file_reader.cc (from /trunk/src/chrome/browser/net/file_reader.cc:28157)
   A /trunk/src/chrome/browser/extensions/file_reader.h (from /trunk/src/chrome/browser/net/file_reader.h:28157)
   A /trunk/src/chrome/browser/extensions/file_reader_unittest.cc (from /trunk/src/chrome/browser/net/file_reader_unittest.cc:28157)
   A /trunk/src/chrome/browser/extensions/image_loading_tracker.cc (from /trunk/src/chrome/browser/image_loading_tracker.cc:28157)
   A /trunk/src/chrome/browser/extensions/image_loading_tracker.h (from /trunk/src/chrome/browser/image_loading_tracker.h:28157)
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   D /trunk/src/chrome/browser/image_loading_tracker.cc
   D /trunk/src/chrome/browser/image_loading_tracker.h
   D /trunk/src/chrome/browser/net/file_reader.cc
   D /trunk/src/chrome/browser/net/file_reader.h
   D /trunk/src/chrome/browser/net/file_reader_unittest.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/common/extensions/extension_resource.cc
   A /trunk/src/chrome/common/extensions/extension_resource.h
   A /trunk/src/chrome/common/extensions/extension_resource_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc

Loads local resources from current locale subtree if available, if not it falls back to extension subtree.

We look for ext_root/foo/bar.js under ext_root/_locales/fr/foo/bar.js if current locale is fr. If there is no fr specific resource we load ext_root/foo/bar.js instead.

Lots of small refactoring to replace FilePath with ExtensionResource.


BUG=12131
TEST=See unittest for sample tree.


Review URL: http://codereview.chromium.org/256022
------------------------------------------------------------------------
r28331 | rafaelw@chromium.org | 2009-10-08 00:42:07 +0200 (Thu, 08 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/chrome.gyp

Revert "Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support. Part 1."

This reverts commit c18585b4bd75664122be8af6ff1170cc5c6efc66.

TBR=tc

Review URL: http://codereview.chromium.org/270015
------------------------------------------------------------------------
r28330 | aa@chromium.org | 2009-10-08 00:36:24 +0200 (Thu, 08 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/common/extensions/extension_action.h

Pull a BrowserActionView out of BrowserActionContainer. Also
rename the button to BrowserActionButton.

This should make adding animation to the badge easier.

Review URL: http://codereview.chromium.org/268002
------------------------------------------------------------------------
r28325 | rafaelw@chromium.org | 2009-10-08 00:26:07 +0200 (Thu, 08 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/chrome.gyp

Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support. Part 1.

original issue: http://codereview.chromium.org/207062

Attempting to land this patch earlier resulted in compile failures on linux valgrind and linux perf that I was unable to reproduce.

I am splitting this into two pieces. This piece adds extension packing support via --pack-extension for mac & linux.

BUG=20668,20669

Review URL: http://codereview.chromium.org/266007
------------------------------------------------------------------------
r28321 | sky@chromium.org | 2009-10-08 00:17:56 +0200 (Thu, 08 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Makes MainMenu a singleton and loaded 5 seconds after startup. This is
done so that we can show the menu quickly. This is a hack. If the menu
remains html we'll pull the html into Chrome and won't need this. This
is just for a better prototype experience.

BUG=24147
TEST=make sure the main menu still works.

Review URL: http://codereview.chromium.org/271004
------------------------------------------------------------------------
r28311 | jhawkins@chromium.org | 2009-10-07 23:27:34 +0200 (Wed, 07 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/three_languages.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/samples/cld/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/cld/toolstrip.html

Revert r28293.

This reverts,

"Change detectLanguage() API to now return the top three languages as well their percentages. Added suitable unit testing to test that top three languages are returned as expected."

TBR=zork
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270012
------------------------------------------------------------------------
r28304 | erikkay@chromium.org | 2009-10-07 22:35:49 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h

Fix double free with browser action popups.

BUG=24122
TEST=none

Review URL: http://codereview.chromium.org/269008
------------------------------------------------------------------------
r28301 | brettw@chromium.org | 2009-10-07 22:10:30 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/app/sql/connection.cc
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/chrome/browser/meta_table_helper.h

Fix SQL preloading. I did Run() with a SELECT which produces data, so it
reports failure. This meant we were never preloading data.

TEST=covered by perf tests
http://crbug.com/23854
Review URL: http://codereview.chromium.org/265018
------------------------------------------------------------------------
r28300 | brettw@chromium.org | 2009-10-07 22:07:17 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gfx/blit.cc (from /trunk/src/base/gfx/blit.cc:28001)
   A /trunk/src/app/gfx/blit.h (from /trunk/src/base/gfx/blit.h:28001)
   A /trunk/src/app/gfx/gdi_util.cc (from /trunk/src/base/gfx/gdi_util.cc:27936)
   A /trunk/src/app/gfx/gdi_util.h (from /trunk/src/base/gfx/gdi_util.h:27936)
   A /trunk/src/app/gfx/gtk_util.cc (from /trunk/src/base/gfx/gtk_util.cc:28001)
   A /trunk/src/app/gfx/gtk_util.h (from /trunk/src/base/gfx/gtk_util.h:28001)
   A /trunk/src/app/gfx/native_theme_win.cc (from /trunk/src/base/gfx/native_theme.cc:27936)
   A /trunk/src/app/gfx/native_theme_win.h (from /trunk/src/base/gfx/native_theme.h:27936)
   A /trunk/src/app/gfx/native_theme_win_unittest.cc (from /trunk/src/base/gfx/native_theme_unittest.cc:27936)
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/win_util.cc
   M /trunk/src/base/base.gyp
   D /trunk/src/base/gfx/DEPS
   D /trunk/src/base/gfx/blit.cc
   D /trunk/src/base/gfx/blit.h
   D /trunk/src/base/gfx/gdi_util.cc
   D /trunk/src/base/gfx/gdi_util.h
   D /trunk/src/base/gfx/gtk_util.cc
   D /trunk/src/base/gfx/gtk_util.h
   D /trunk/src/base/gfx/native_theme.cc
   D /trunk/src/base/gfx/native_theme.h
   D /trunk/src/base/gfx/native_theme_unittest.cc
   D /trunk/src/base/gfx/platform_canvas.h
   D /trunk/src/base/gfx/platform_canvas_linux.h
   D /trunk/src/base/gfx/platform_canvas_mac.h
   D /trunk/src/base/gfx/platform_device_linux.h
   D /trunk/src/base/gfx/platform_device_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/renderer/webmediaplayer_impl.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/skia/ext/vector_platform_device_win.cc
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/controls/menu/menu_config_win.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/slider/native_slider_gtk.cc
   M /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/drag_utils_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/glue/webthemeengine_impl_win.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_platform_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Move classes depending on Skia out of base/gfx and into app/gfx. Rename
native_theme to native_theme_win since its Windows-specific.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/259047
------------------------------------------------------------------------
r28298 | tony@chromium.org | 2009-10-07 22:03:40 +0200 (Wed, 07 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fix the tab move animation when the custom frame is on.  Previously,
we were using the tab's y position which takes into account the
custom frame padding.  However, TabBounds is relative to the tabstrip
origin so the we kept incrementing the y position by 15px at each
step of the animation.

Use the original tab bound y instead (matches code in the pin tab
animation).

TEST=open some tabs and use ctrl+shift+page{up,down} with the custom frame on.

Review URL: http://codereview.chromium.org/269010
------------------------------------------------------------------------
r28293 | sidchat@chromium.org | 2009-10-07 21:55:15 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/three_languages.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/samples/cld/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/cld/toolstrip.html

Change detectLanguage() API to now return the top three languages as well their percentages. Added suitable unit testing to test that top three languages are returned as expected.

BUG=20666
TEST=none
Review URL: http://codereview.chromium.org/223010
------------------------------------------------------------------------
r28292 | sky@chromium.org | 2009-10-07 21:55:02 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Wires up views/gtk to use the gtk bookmark editor.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/271001
------------------------------------------------------------------------
r28290 | jhawkins@chromium.org | 2009-10-07 21:49:51 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Mark DOMStorageTest.LocalStorageLayoutTests as flaky.

BUG=24145
TEST=none
Review URL: http://codereview.chromium.org/270009
------------------------------------------------------------------------
r28287 | mark@chromium.org | 2009-10-07 21:37:26 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm

Back out r28284 (backout of r28260), it did not cause the perf regression.

BUG=23517 24118
TEST=none
Review URL: http://codereview.chromium.org/269009
------------------------------------------------------------------------
r28286 | thomasvl@chromium.org | 2009-10-07 21:35:38 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Follow up to r242162 to properly animate between prefs panes.

TEST=none
BUG=20538
Review URL: http://codereview.chromium.org/270008
------------------------------------------------------------------------
r28284 | mark@chromium.org | 2009-10-07 21:09:13 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm

Try backing out r28260 to see if it caused the Mac startup test perf regression

BUG=23517 24118
TEST=Observe Mac perf bot
Review URL: http://codereview.chromium.org/267010
------------------------------------------------------------------------
r28279 | tony@chromium.org | 2009-10-07 20:44:24 +0200 (Wed, 07 Oct 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/app/theme/ntp_themes_promo.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   A /trunk/src/chrome/browser/resources/ntp_themes_promo.png (from /trunk/src/chrome/app/theme/ntp_themes_promo.png:28272)

Inline the theme promo image.  This should be a tiny bit faster than
using a chrome:// URL.

Review URL: http://codereview.chromium.org/255099
------------------------------------------------------------------------
r28278 | timsteele@google.com | 2009-10-07 20:42:35 +0200 (Wed, 07 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/sync_cycle_state.h
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h

Sync: Replace pthread mutex with base::Lock in a few more places.
This leaves just ServerConnectionManager behind.

BUG=19895
TEST=sync_unit_tests

Review URL: http://codereview.chromium.org/251098
------------------------------------------------------------------------
r28269 | cpu@chromium.org | 2009-10-07 19:16:01 +0200 (Wed, 07 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sandbox_policy.cc

Update evicted dlls list

New breed of Spyware Doctor DLL is crashing our processes

BUG=24037
TEST=install spyware doctor 6.1 (6.1.0.0), chrome should function


Review URL: http://codereview.chromium.org/260026
------------------------------------------------------------------------
r28268 | tony@chromium.org | 2009-10-07 19:01:44 +0200 (Wed, 07 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   A /trunk/src/chrome/browser/metrics/metric_event_duration_details.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Revert "Revert "Add startup tests that log start script, domcontentloaded, and onload.""

This reverts commit r28209 and relands r28199.

The failure seems to have been flaky (it passed on the other bots and on the following run).  I want to
try to land again.  If it fails again, I'll disable the test.

TBR=mattm

Review URL: http://codereview.chromium.org/268003
------------------------------------------------------------------------
r28266 | erg@chromium.org | 2009-10-07 18:58:35 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Mac: Hide the bookmark bar in popup windows.

BUG=17625
BUG=23988

Review URL: http://codereview.chromium.org/255096
------------------------------------------------------------------------
r28262 | mark@chromium.org | 2009-10-07 18:42:16 +0200 (Wed, 07 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/app/test_suite.h
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/app/clean_mac_resources
   M /trunk/src/chrome/app/tweak_mac_lproj_folders
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths_internal.h
   M /trunk/src/chrome/common/chrome_paths_mac.mm
   M /trunk/src/chrome/common/mac_app_names.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Move all resources into the framework.

BUG=14610 (in support of unbreaking auto-update)
TEST=The .app's Contents/Resources folder should not contain the resources that
     are moving to the .framework's Resources folder;
     The .app's Contents/Resources folder should still contain app.icns,
     document.icns, the helper .app, and a whole slew of .lprojs that only
     contain InfoPlist.strings;
     Make sure Breakpad still works in the browser, renderer, and other process
     types.
Review URL: http://codereview.chromium.org/256062
------------------------------------------------------------------------
r28261 | arv@chromium.org | 2009-10-07 18:40:31 +0200 (Wed, 07 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NTP: Add a workaround for the case where we reopen a window and a tooltip is
shown in the background window.

BUG=23967

TEST=Open two windows with at least two tabs. Open one more window and go to
the NTP. Close the first two windows. Now click on the first link in the 
Recently closed section. This reopens a window. Now move the mouse so you can
see the NTP again. There should be no tooltip for the Recently closed item

Review URL: http://codereview.chromium.org/263002
------------------------------------------------------------------------
r28260 | pinkerton@chromium.org | 2009-10-07 18:40:15 +0200 (Wed, 07 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm

Fix up URIs of drags from the filesystem to allow them to be successfully dropped in the content area to load.
BUG=23517
TEST=dragging files, bookmarks, folders, text, etc to content area should behave correctly.
Review URL: http://codereview.chromium.org/267006
------------------------------------------------------------------------
r28258 | erg@chromium.org | 2009-10-07 18:36:18 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Mac: Find bar should be drawn on top of all other toolbars.

BUG=24000

Review URL: http://codereview.chromium.org/255101
------------------------------------------------------------------------
r28256 | shess@chromium.org | 2009-10-07 18:09:10 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/cocoa_protocols_mac.h
   A /trunk/src/chrome/browser/cocoa/DEPS
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Use OCMock in autocomplete_text_field_unittest.mm.

BUGS=none
TEST=unit tests continue to work.

Review URL: http://codereview.chromium.org/257063
------------------------------------------------------------------------
r28255 | robertshield@chromium.org | 2009-10-07 17:53:56 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc

Add a client name to the safe browsing service for Chrome Frame builds of Chrome.

TEST=Verify that Chrome Frame builds use the client name 'googlechromeframe' when talking to the safe browsing service.

Review URL: http://codereview.chromium.org/246090
------------------------------------------------------------------------
r28252 | rsesek@chromium.org | 2009-10-07 17:26:23 +0200 (Wed, 07 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/KeywordEditor.xib
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm

[Mac] Add icons to the search engine editor

* Put icons the "name" cell of KeywordEditor.
* Have KeywordEditorCocoaController be the observer of the table model, so that
  it is properly notified of all model changes (esp. icons).

TEST=Open search engine editor, see icons.

Review URL: http://codereview.chromium.org/242020
------------------------------------------------------------------------
r28250 | mnaganov@chromium.org | 2009-10-07 17:16:45 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: enable TestProfilerTab back, as fix has been rolled in V8.

BUG=23768,23961
TEST=DevToolsSanityTest.TestProfilerTab

Review URL: http://codereview.chromium.org/266005
------------------------------------------------------------------------
r28249 | thakis@chromium.org | 2009-10-07 17:07:33 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

Let fn-left/right in find bar scroll to end of page.

BUG=none
TEST=Open page with scrollbar, open and focus find bar. Hit fn-right, it should scroll to the end of the page. Hit fn-left, it should scroll back up.

Review URL: http://codereview.chromium.org/246084
------------------------------------------------------------------------
r28248 | yurys@google.com | 2009-10-07 16:51:27 +0200 (Wed, 07 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: temporarily disable failing test

TBR=pfeldman
Review URL: http://codereview.chromium.org/265008
------------------------------------------------------------------------
r28247 | yurys@google.com | 2009-10-07 16:12:15 +0200 (Wed, 07 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/debugger_intrinsic_properties.html
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: allow inspecting __proto__, constructor, prototype properties.BUG=23647
Review URL: http://codereview.chromium.org/262005
------------------------------------------------------------------------
r28244 | thomasvl@chromium.org | 2009-10-07 15:38:33 +0200 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

First step in l10n for the prefs window.
- Add a toolbar instead of tabs.
- Make the window change size based on the content.
- Center the views to the widest of the subviews.

TEST=prefs window and all of the controls in it work.
BUG=20538
Review URL: http://codereview.chromium.org/242162
------------------------------------------------------------------------
r28240 | chocobo@google.com | 2009-10-07 11:47:24 +0200 (Wed, 07 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/touchpad.cc

Tweak touchpad settings for better performance.
TEST=none
BUG=23996
Review URL: http://codereview.chromium.org/242164
------------------------------------------------------------------------
r28237 | jorlow@chromium.org | 2009-10-07 08:15:41 +0200 (Wed, 07 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_area.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_area.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h

Fix a major DOM Storage memory leak and try again to enable the UI tests.

TBR=michaeln
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/251109
------------------------------------------------------------------------
r28236 | darin@chromium.org | 2009-10-07 07:50:28 +0200 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/webkit/api/public/WebMediaPlayerAction.h
   M /trunk/src/webkit/api/public/WebView.h
   D /trunk/src/webkit/glue/media_player_action.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/webkit.gyp

Move MediaPlayerAction to WebMediaPlayerAction.  Switch to an enum and a
boolean to express the action.

R=ajwong
BUG=10033
TEST=none

Review URL: http://codereview.chromium.org/251103
------------------------------------------------------------------------
r28235 | abarth@chromium.org | 2009-10-07 07:14:38 +0200 (Wed, 07 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

Add more extensions to our download_exe list.

Review URL: http://codereview.chromium.org/243115
------------------------------------------------------------------------
r28234 | rafaelw@chromium.org | 2009-10-07 06:43:45 +0200 (Wed, 07 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   A /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc
   M /trunk/src/chrome/chrome.gyp

This reverts:  HTML Pack Extension Dialog / Linux & Mac Packaging Support.

original issue: http://codereview.chromium.org/207062/

TBR=sky

Review URL: http://codereview.chromium.org/270001
------------------------------------------------------------------------
r28232 | derat@chromium.org | 2009-10-07 06:06:02 +0200 (Wed, 07 Oct 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

Linux: Improve info bubble placement.

Make InfoBubble's constructor take positions relative to the browser
window's origin, rather than the absolute positions used by Views.

Otherwise, we run into issues when the browser window is being moved while
the bubble is created -- this is unlikely to happen for bookmark bubbles,
but when the first run bubble is created, the browser window may or may not
be in the final place that the window manager is going to put it.  There
was previously a 200 ms delay before opening the bubble, but that approach
still fails sometimes when X is being forwarded over a network connection.

This change makes us update the bubble's position as we receive
ConfigureNotify events about its browser window.

TEST=checked that first-run and bookmark bubbles are placed correctly in openbox, KDE, metacity, fluxbox, and ion3

Review URL: http://codereview.chromium.org/256068
------------------------------------------------------------------------
r28229 | rafaelw@chromium.org | 2009-10-07 05:46:46 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   D /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc
   M /trunk/src/chrome/chrome.gyp

HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.

Additionally, support is added for packaging extensions via ---pack-extension on linux and mac

Review URL: http://codereview.chromium.org/207062
------------------------------------------------------------------------
r28228 | sky@chromium.org | 2009-10-07 05:30:22 +0200 (Wed, 07 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Converts info bubbles on views/gtk from popups to normal windows to
avoid the focus problems.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/246099
------------------------------------------------------------------------
r28227 | sky@chromium.org | 2009-10-07 05:29:48 +0200 (Wed, 07 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h

Attempt at fixing crash during importing. As far as I can tell from
the crash the BookmarkModel is trying to notifying observers it's
going away and one of those observers has been deleted. This is during
first run import, so the only observer should be the importer.

This may be possible if someone prematurely exits the nested loop
started during first run so that the importerhost isn't done when the
profile is deleted.

BUG=16143
TEST=none

Review URL: http://codereview.chromium.org/242119
------------------------------------------------------------------------
r28225 | cmasone@google.com | 2009-10-07 05:09:33 +0200 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Adding a SIGTERM handler for OS_POSIX builds.  This is needed so that Chrome can shut down gracefully when many posix-based system halt or reboot while Chrome is open.

SIGTERM may come in on any thread, so the handler creates a Task object that wraps up a call to BrowserList::CloseAllBrowsers(true) and Posts it to the message loop of the UI thread.  Thus, we both get out of the signal handler quickly and can deal with the signal on any thread.

BUG=23551

TEST=covered by BrowserTest.PosixSessionEnd
Review URL: http://codereview.chromium.org/255036
------------------------------------------------------------------------
r28221 | rsesek@chromium.org | 2009-10-07 04:30:05 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h

[Mac] Show the page info window after clicking the security icon in the URL bar

BUG=22922
TEST=Go to https://twitter.com, click the lock icon, see page info window.

Review URL: http://codereview.chromium.org/222020
------------------------------------------------------------------------
r28219 | brettw@chromium.org | 2009-10-07 04:10:20 +0200 (Wed, 07 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_version_info_mac.mm
   A /trunk/src/base/i18n/icu_string_conversions.cc (from /trunk/src/base/i18n/string_conversions.cc:27937)
   A /trunk/src/base/i18n/icu_string_conversions.h (from /trunk/src/base/i18n/string_conversions.h:27937)
   D /trunk/src/base/i18n/string_conversions.cc
   D /trunk/src/base/i18n/string_conversions.h
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_writer.cc
   M /trunk/src/base/logging.cc
   M /trunk/src/base/platform_file_posix.cc
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/string16.cc
   A /trunk/src/base/string16_unittest.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/sys_info_posix.cc
   M /trunk/src/base/system_monitor_unittest.cc
   A /trunk/src/base/third_party/icu
   A /trunk/src/base/third_party/icu/README
   A /trunk/src/base/third_party/icu/icu_utf.cc
   A /trunk/src/base/third_party/icu/icu_utf.h
   M /trunk/src/base/trace_event.cc
   A /trunk/src/base/utf_string_conversions.cc (from /trunk/src/base/i18n/string_conversions.cc:27937)
   A /trunk/src/base/utf_string_conversions.h (from /trunk/src/base/i18n/string_conversions.h:27937)
   M /trunk/src/base/values.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

Copy the relevant parts of ICU to a new file base/third_party/icu/icu_utf.*
so we can do basic UTF8/16/32 conversions without linking all of ICU.

Change callers who used to call SysUTF8ToWide/SysWideToUTF8 in base to using
these new functions. I will remove the Sys versions of these functions in a
later patch.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/243102
------------------------------------------------------------------------
r28218 | derat@chromium.org | 2009-10-07 04:09:05 +0200 (Wed, 07 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

Linux: Fix focus issues in bookmark bubble.

I wasn't aware of it in my initial change that made us use
override-redirect windows for InfoBubbleGtk, but clicking on
the bookmark bubble's folder combobox steals InfoBubbleGtk's
pointer and keyboard grabs, resulting in the other widgets
in the window behaving as if they're inactive after the
combobox's popup is closed.  This somewhat hacky change
makes us reinstall the bubble's grabs after the popup closes.

TEST=clicked in and out of bookmark bubble's combobox and checked that text entry still behaves normally

Review URL: http://codereview.chromium.org/260019
------------------------------------------------------------------------
r28217 | estade@chromium.org | 2009-10-07 03:58:17 +0200 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Reap renderer processes following fast termination.

I'm still seeing some defunct processes, but not one for every tab, and they don't appear to be former renderer processes, so that's probably a separate bug.

BUG=23778
TEST=after closing a tab ps shows that the renderer is gone (not just defunct)

Review URL: http://codereview.chromium.org/242155
------------------------------------------------------------------------
r28215 | estade@chromium.org | 2009-10-07 03:58:01 +0200 (Wed, 07 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   A /trunk/src/chrome/browser/ntp_background_util.cc
   A /trunk/src/chrome/browser/ntp_background_util.h
   M /trunk/src/chrome/chrome.gyp

GTK: Draw bottom-aligned ntp themes on floating bookmark bar.

This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well.

I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907

BUG=22836
TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes.

Review URL: http://codereview.chromium.org/255086
------------------------------------------------------------------------
r28214 | estade@chromium.org | 2009-10-07 03:57:37 +0200 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc

GTK: Fix minor slide animation bugs.

Following r27934, we might hit the code path for initial positioning *after* the AnimationProgressed positioning, causing the child widget not to show.

BUG=23902
TEST=when you switch away from a tab that has an infobar, then switch back, you can see the infobar.

Review URL: http://codereview.chromium.org/258038
------------------------------------------------------------------------
r28213 | estade@chromium.org | 2009-10-07 03:57:28 +0200 (Wed, 07 Oct 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

GTK: make sure to delete any remaining dialogs when the SelectFileDialogImpl object goes out of scope.

The control flow was as follows:

1. user initiates a save page command
2. user initiates a second save page command
3. tab contents creates a SavePackage, shows dialog
4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl
5. At this point two dialogs are visible.
6. User dismisses second dialog.
7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl.
8. Bad stuff.

BUG=23817
TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared.

Review URL: http://codereview.chromium.org/243117
------------------------------------------------------------------------
r28209 | mattm@chromium.org | 2009-10-07 03:46:35 +0200 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   D /trunk/src/chrome/browser/metrics/metric_event_duration_details.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Revert "Add startup tests that log start script, domcontentloaded, and onload."
which failed on XP Perf (single).

This reverts commit r28199.

TBR=tony

Review URL: http://codereview.chromium.org/265002
------------------------------------------------------------------------
r28208 | chron@google.com | 2009-10-07 03:11:32 +0200 (Wed, 07 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

Revert 28198 - Remove pthreads from syncable.
Remove unused kernel scoped unlock.

BUG=19895
TEST=Existing unit tests

Review URL: http://codereview.chromium.org/246097

TBR=chron@chromium.org

Review URL: http://codereview.chromium.org/265001
------------------------------------------------------------------------
r28202 | mpcomplete@chromium.org | 2009-10-07 02:26:44 +0200 (Wed, 07 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Add NULL-checks to render_view_host->view() to fix startup test crash.

TBR=erikkay

Review URL: http://codereview.chromium.org/258040
------------------------------------------------------------------------
r28199 | tony@chromium.org | 2009-10-07 02:16:15 +0200 (Wed, 07 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   M /trunk/src/chrome/browser/automation/automation_provider_observers.h
   A /trunk/src/chrome/browser/metrics/metric_event_duration_details.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add startup tests that log start script, domcontentloaded, and onload.

TabContents sends a notification which is picked up by the browser
automation controller which keeps a map of events and times.  Add
an automation IPC so that tests can get these values from the
browser automation controller.  Finally, add a feature startup test
to collect these values.

This is just to get some consistent timings from the buildbot.

BUG=23120

Review URL: http://codereview.chromium.org/246105
------------------------------------------------------------------------
r28198 | chron@chromium.org | 2009-10-07 02:13:47 +0200 (Wed, 07 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

Remove pthreads from syncable.
Remove unused kernel scoped unlock.

BUG=19895
TEST=Existing unit tests

Review URL: http://codereview.chromium.org/246097
------------------------------------------------------------------------
r28193 | mirandac@chromium.org | 2009-10-07 02:00:12 +0200 (Wed, 07 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h

Fix tips in OS X to respect system language settings instead of locale.

BUG= http://crbug.com/22727
TEST= Set preferred language to a different setting from the locale in the OS X system settings.
Make sure that the language of the tips matches the language setting (which
should be the same as that of the Chrome UI).  If tips are not available in
the Chrome UI language, no tips should be shown.

Review URL: http://codereview.chromium.org/258037
------------------------------------------------------------------------
r28191 | finnur@chromium.org | 2009-10-07 01:56:22 +0200 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Make browser actions appear to the left of the bookmark menu.

Also fixed min size of the browser to take into account the browser actions.

BUG-23924
TESTS=Open Chrome with --bookmark-menu and make sure browser actions you install appear to the left. Also, resize the browser horizontally and make sure it always shows all the controls in the chrome (from Back to App menu).

Review URL: http://codereview.chromium.org/246102
------------------------------------------------------------------------
r28190 | sidchat@chromium.org | 2009-10-07 01:51:28 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc

Fix for BrowserActions UNLOAD not changing Omnibox length. BrowserActionsContainer is the child view of ToolBarView. When BrowserActionsContainer gets notification for LOAD/UNLOAD, it needs to re-layout ToolBarView, its parent.

BUG=23381
TEST=none

Review URL: http://codereview.chromium.org/246107
------------------------------------------------------------------------
r28187 | erikkay@chromium.org | 2009-10-07 01:50:06 +0200 (Wed, 07 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   M /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/test/data/extensions/samples/set_page_color/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html

Add an BubbleBorder to BrowserAction popups and fix positioning of the
popup.

BUG=23833,23835
TEST=none

Review URL: http://codereview.chromium.org/259065
------------------------------------------------------------------------
r28177 | mpcomplete@chromium.org | 2009-10-07 01:02:56 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h

Fix a regression with setting the toolstrip background.

BUG=23458
TEST=Load an extension with a toolstrip. The toolstrip's background should match the shelf's background for your theme.

Review URL: http://codereview.chromium.org/243114
------------------------------------------------------------------------
r28175 | tony@chromium.org | 2009-10-07 00:55:41 +0200 (Wed, 07 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Revert r28050 and put the paint observer timeout back to 2 sec.

The new tab times didn't change on linux/mac so that's probably
not the problem.  This will speed up the new tab tests.

Review URL: http://codereview.chromium.org/256083
------------------------------------------------------------------------
r28158 | amanda@chromium.org | 2009-10-06 23:33:21 +0200 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host_mac.cc

Fix a crash when a plugin file picker window is dismissed.  This is a
spot fix--a comprehensive fix will require
http://code.google.com/p/chromium/issues/detail?id=23571
BUG=23774
TEST=upload a file via Flash (example: Gmail, YouTube).  The browser should not crash
after you click "OK" to dismiss the file picker.
Review URL: http://codereview.chromium.org/242161
------------------------------------------------------------------------
r28145 | avi@chromium.org | 2009-10-06 21:33:07 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/external_protocol_dialog.h
   A /trunk/src/chrome/browser/cocoa/external_protocol_dialog.mm
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/chrome.gyp

External protocol dialog support for the Mac.

BUG=http://crbug.com/15546
TEST=try to use an external protocol; it should put up a dialog

Review URL: http://codereview.chromium.org/256065
------------------------------------------------------------------------
r28144 | jhawkins@chromium.org | 2009-10-06 21:22:05 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/ie7_password.cc

Coverity: Check the return value of CryptDestroyHash and CryptReleaseContext.

CID=6309
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243103
------------------------------------------------------------------------
r28143 | jhawkins@chromium.org | 2009-10-06 21:21:19 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc

Coverity: Assert that socket() returned a successful value.

CID=6384
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260010
------------------------------------------------------------------------
r28140 | mnaganov@chromium.org | 2009-10-06 21:09:55 +0200 (Tue, 06 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: disable TestProfilerTab test due to flakiness.

To fix it, a change needs to be made in V8.

BUG=23768
TEST=none

Review URL: http://codereview.chromium.org/256082
------------------------------------------------------------------------
r28139 | mark@chromium.org | 2009-10-06 21:06:49 +0200 (Tue, 06 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.h

Make EditSearchEngineCocoaController adhere to NSWindowDelegate
Review URL: http://codereview.chromium.org/242157
------------------------------------------------------------------------
r28136 | mpcomplete@chromium.org | 2009-10-06 20:56:51 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html

Implement browserAction.setIcon(ImageData) for extensions.

BUG=23269
TEST=load the test_browser_action sample extension, and click the browser action. Watch it dynamically update.

Review URL: http://codereview.chromium.org/242150
------------------------------------------------------------------------
r28131 | nick@chromium.org | 2009-10-06 20:20:34 +0200 (Tue, 06 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Cleanup some rotten references to old command line switches.

Review URL: http://codereview.chromium.org/243105
------------------------------------------------------------------------
r28130 | mpcomplete@chromium.org | 2009-10-06 20:15:58 +0200 (Tue, 06 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/ipc/ipc_message_utils.cc

Modify extension request IPC messages to pass a ListValue instead of a string.

This allows us to pass binary values through extension requests. I use this in
my next CL to pass SkBitmaps.

BUG=23269
TEST=no

Review URL: http://codereview.chromium.org/251093
------------------------------------------------------------------------
r28129 | nick@chromium.org | 2009-10-06 20:14:28 +0200 (Tue, 06 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/dom_view.cc

DOMView: avoid double-detaching.

I'm seeing ~DOMView happen after NativeViewHost::Detach has already been
done as part of WM_DESTROY.

BUG=20339

TEST=cancel the sync login dialog and create app shortcuts dialogs.

Review URL: http://codereview.chromium.org/258028
------------------------------------------------------------------------
r28119 | erikkay@chromium.org | 2009-10-06 18:36:39 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/browser_action_test.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/extensions/extension_action.h

Don't show popup browser actions in the wrench menu.

BUG=23834
TEST=none

Review URL: http://codereview.chromium.org/257048
------------------------------------------------------------------------
r28117 | jeremy@chromium.org | 2009-10-06 18:28:57 +0200 (Tue, 06 Oct 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   A /trunk/src/chrome/browser/importer/importer_bridge.cc
   A /trunk/src/chrome/browser/importer/importer_bridge.h
   A /trunk/src/chrome/browser/importer/importer_list.cc
   A /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/mork_reader.h
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/chrome.gyp

(please review thoroughly since this touches many moving parts).

Refactor ImporterHost as preparation for OOPprofile import.

ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process.

This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc.

ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world.

ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface.

There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work.  For now I'm trying to keep these CLs as small as I can.

BUG=14458
TEST=Profile import should continue to work on Windows/Linux & Mac.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27996

Review URL: http://codereview.chromium.org/242091
------------------------------------------------------------------------
r28116 | pkasting@chromium.org | 2009-10-06 18:26:20 +0200 (Tue, 06 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Turns out a cleanup change I made a while ago was wrong.  This could result in odd text colors in the Omnibox when typing.

BUG=none
TEST=Visit m/, then type a letter into the omnibox and make sure it's black.
Review URL: http://codereview.chromium.org/259054
------------------------------------------------------------------------
r28115 | erikkay@chromium.org | 2009-10-06 18:11:44 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html

Resubmit http://codereview.chromium.org/243096 with gcc compile error fixed.

BUG=23832
TBR=mpcomplete

Review URL: http://codereview.chromium.org/257056
------------------------------------------------------------------------
r28112 | nick@chromium.org | 2009-10-06 17:48:28 +0200 (Tue, 06 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome.dll.deps
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/tools/build/win/FILES

Change the Windows build to statically link the sync library.

Update installer files so that they don't reference syncapi.dll. Add a
reference to iphlpapi, and make it and pthreads lazy-loaded.
BUG=23609
TEST=interactive testing of two sync clients with notifications.

Review URL: http://codereview.chromium.org/242118
------------------------------------------------------------------------
r28111 | sky@chromium.org | 2009-10-06 17:39:03 +0200 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Changes the url of the main menu.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/255088
------------------------------------------------------------------------
r28110 | creis@google.com | 2009-10-06 17:30:18 +0200 (Tue, 06 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Prevents a duplicate beforeunload dialog after window.close().
If the renderer tells the browser to close a window, we no longer
run the unload events, because the renderer already has.

BUG=11647
TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose


Review URL: http://codereview.chromium.org/246080
------------------------------------------------------------------------
r28104 | thomasvl@chromium.org | 2009-10-06 17:08:17 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

Removed omnibox images from the bundle.
Update the code to pull the omnibox images from the pak files instead.

TEST=Omnibox still has all the right images next to the things it lists
BUG=20230
Review URL: http://codereview.chromium.org/246101
------------------------------------------------------------------------
r28099 | pfeldman@chromium.org | 2009-10-06 10:58:36 +0200 (Tue, 06 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/webkit_resources.grd

DevTools: bring devtools tests back.

Review URL: http://codereview.chromium.org/243107
------------------------------------------------------------------------
r28098 | jorlow@chromium.org | 2009-10-06 10:24:38 +0200 (Tue, 06 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Revert.

------------------------------------------------------------------------
r28097 | jorlow@chromium.org | 2009-10-06 09:35:05 +0200 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Re-enable the DOM Storage ui tests that worked orginally.
Next step: enable ones that should work, but (for some reason) don't.

TEST=It runs.
BUG=none

Review URL: http://codereview.chromium.org/256070
------------------------------------------------------------------------
r28095 | aa@chromium.org | 2009-10-06 08:17:54 +0200 (Tue, 06 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json

Generate IDs for --load-extension by hashing the path instead
of incrementing a static counter.

BUG=21281
TEST=Load an unpacked extension from chrome://extensions/ that
does not have an ID in its manifest. The resulting ID should
be random-looking, not something like "aaaaaa".

Review URL: http://codereview.chromium.org/256049
------------------------------------------------------------------------
r28093 | ukai@chromium.org | 2009-10-06 07:18:47 +0200 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Implement --enable-web-sockets flag.

BUG=12497
TEST=none

Review URL: http://codereview.chromium.org/255075
------------------------------------------------------------------------
r28091 | sgk@google.com | 2009-10-06 05:58:38 +0200 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/app_controller_mac_unittest.mm

Explicitly activeIgnoringOtherApps from IDC_NEW{,_INCOGNITO}_WINDOW
in app_controller_mac.mm, under the assumption we're either already
the foreground app or should become the foreground mac
(when created from the dock menu).
BUG=22595
TEST="New Window" or "New Incognito Window" from dock menu with other app in foreground
Review URL: http://codereview.chromium.org/256054
------------------------------------------------------------------------
r28086 | chron@chromium.org | 2009-10-06 04:22:10 +0200 (Tue, 06 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_transaction_factory.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/url_request/url_request_context.h

Initial CL for fixing some of the proxy auth issues.
Auth_cache is contained in the http session. We need to share
the http session with the parent profile request context in order to retain http authentication.
Weirdly enough, Profile::GetDefaultRequestContext() is not the same as profile_->GetRequestContext(),
It does NOT yet pop up a dialog if the user hasn't done so already.

BUG=19581
TEST=Included.

Review URL: http://codereview.chromium.org/241001
------------------------------------------------------------------------
r28085 | ananta@chromium.org | 2009-10-06 03:44:57 +0200 (Tue, 06 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome_frame/chrome_active_document.cc
   M /trunk/src/chrome_frame/chrome_active_document.h
   M /trunk/src/chrome_frame/chrome_active_document.rgs
   M /trunk/src/chrome_frame/chrome_frame_activex.rgs
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_automation.h
   M /trunk/src/chrome_frame/chrome_frame_npapi.rgs
   M /trunk/src/chrome_frame/chrome_protocol.rgs
   M /trunk/src/chrome_frame/chrome_tab.rgs

Added support for specifying the BrowserFlags DWORD value when we register the ChromeFrame Active Document
server. This allows the document server to receive a number of menu events like Find, View->Text Size, etc.
Thanks to Stoyan for helping me debug this :)

Clicking on Edit->Find in the menu in IE with this causes IEFrame to call our Active document's Exec implementation
with the IDM_FIND command. The handling here is to invoke our default Find handling. Added support for
honoring user text size selections. The next thing to be done is to honor the current text size setting while
launching Chrome.

I also fixed the rgs files to have LF as the terminating character.

This fixes Bug http://code.google.com/p/chromium/issues/detail?id=23667

Bug=23667

Review URL: http://codereview.chromium.org/243082
------------------------------------------------------------------------
r28084 | timsteele@google.com | 2009-10-06 03:24:03 +0200 (Tue, 06 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc

Initialize message_loop_ in gaia authenticator.

BUG=23906

Review URL: http://codereview.chromium.org/257058
------------------------------------------------------------------------
r28082 | mattm@chromium.org | 2009-10-06 03:07:20 +0200 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Coverity: check module for NULL before calling GetProcAddress.

CID=5168,5169
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/257043
------------------------------------------------------------------------
r28077 | erg@google.com | 2009-10-06 02:43:43 +0200 (Tue, 06 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Fix build.

TBR=nsylvain

Review URL: http://codereview.chromium.org/246100
------------------------------------------------------------------------
r28075 | viettrungluu@chromium.org | 2009-10-06 02:29:04 +0200 (Tue, 06 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Mac: Fix crash while dragging a tab alone in a window.

Specifically, the crash could be repro'ed as follows (it also occurred under other circumstances as well): Have a window with one or more tabs in it. Create a new window with a single tab. Drag the tab in the new window, and while dragging right-click (and release).

This patch also prevents right-clicks while dragging from stopping the drag.

BUG=23591
TEST=See above.

Review URL: http://codereview.chromium.org/242139
------------------------------------------------------------------------
r28074 | erg@chromium.org | 2009-10-06 02:28:35 +0200 (Tue, 06 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/toolbar_compressable.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome.gyp

Mac: Implements the special bookmark bar on NTP.

Based mostly on Ben's patch, but made it compile, work, and descoped
moving the bookmark bar around the view heiarchy.

XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view].

BUG=17625

Review URL: http://codereview.chromium.org/246034
------------------------------------------------------------------------
r28066 | erg@google.com | 2009-10-06 01:40:01 +0200 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK: Refactor some things so GTK doesn't touch the on disk image cache.

Hopefully will solve crash.

BUG=23588

Review URL: http://codereview.chromium.org/258020
------------------------------------------------------------------------
r28064 | viettrungluu@chromium.org | 2009-10-06 01:38:34 +0200 (Tue, 06 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.h
   M /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.h
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/menu_button.h
   M /trunk/src/chrome/browser/cocoa/menu_button.mm
   M /trunk/src/chrome/browser/cocoa/menu_button_unittest.mm

Mac: Eliminate unintended "menu" method overrides.

This had the bad effect of showing bad/strange menus upon right-click on various buttons or, worse, crashing.

BUG=22148,23606
TEST=Right click on back/forwards buttons (after some navigation so that they're active), page/wrench buttons, and bookmark bar off-the-side button and make sure no menu is shown (and it that it doesn't crash). Also do so when the menu is active/highlighted with menu already showing.

Review URL: http://codereview.chromium.org/251091
------------------------------------------------------------------------
r28063 | tony@chromium.org | 2009-10-06 01:36:08 +0200 (Tue, 06 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/url_constants.h

Remove references to DOMUIContents.  It looks like the class doesn't exist.

Review URL: http://codereview.chromium.org/257055
------------------------------------------------------------------------
r28061 | jcampan@chromium.org | 2009-10-06 01:31:39 +0200 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native/native_view_host_win.h
   M /trunk/src/views/controls/native/native_view_host_wrapper.h
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.h
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc

Reverting the NativeViewHostWin focus refactoring.
It seems the added subclassing is causing crashers in the field.

BUG=23861
TEST=None
TBR=beng
Review URL: http://codereview.chromium.org/259052
------------------------------------------------------------------------
r28057 | erikkay@chromium.org | 2009-10-06 00:20:07 +0200 (Tue, 06 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html

TBR: mpcomplete
revert previous checkin (compile failure due to bad merge resolution)
------------------------------------------------------------------------
r28055 | sidchat@chromium.org | 2009-10-06 00:01:26 +0200 (Tue, 06 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc

Change flag "auto-spell-correct" to "experimental-spellchecker-features". I will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260006
------------------------------------------------------------------------
r28053 | erikkay@chromium.org | 2009-10-06 00:00:05 +0200 (Tue, 06 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html

Allow popups to close themselves with window.close().

This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC.

BUG=23832
TEST=run set_page_color extension, when it sets the color, the popup
should close

Review URL: http://codereview.chromium.org/243096
------------------------------------------------------------------------
r28051 | sky@chromium.org | 2009-10-05 23:51:40 +0200 (Mon, 05 Oct 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/chromium/button_menu.png
   A /trunk/src/chrome/app/theme/chromium/button_menu_drop_down.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Make the main menu open at full screen and provides command line
switches for changing the url and size.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/246091
------------------------------------------------------------------------
r28050 | tony@chromium.org | 2009-10-05 23:50:46 +0200 (Mon, 05 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Up the new tab paint observer timeout from 2s to 5s.  Trying to see
if this gets us more accurate data on new tab times.

BUG=21398

TBR=evanm (ok'ed in person)

Review URL: http://codereview.chromium.org/257052
------------------------------------------------------------------------
r28044 | jhawkins@chromium.org | 2009-10-05 23:09:12 +0200 (Mon, 05 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store.cc

Coverity: Allocate |cache| after we have a logic path where we can return and leak.

CID=6380
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255081
------------------------------------------------------------------------
r28043 | pkasting@chromium.org | 2009-10-05 23:08:30 +0200 (Mon, 05 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable a Dev Tools test that got missed.

BUG=23858
TEST=none
Review URL: http://codereview.chromium.org/242147
------------------------------------------------------------------------
r28037 | pkasting@chromium.org | 2009-10-05 22:51:35 +0200 (Mon, 05 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc

Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/259050
------------------------------------------------------------------------
r28036 | jparent@chromium.org | 2009-10-05 22:49:22 +0200 (Mon, 05 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Temporarily disable the dev tools unit tests.  They were broken by the webkit merge from 49050:49097.

TEST=none
BUG=23858

Review URL: http://codereview.chromium.org/257049
------------------------------------------------------------------------
r28034 | jam@chromium.org | 2009-10-05 22:47:32 +0200 (Mon, 05 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc

Remove the RenderProcessHost from the list of renderer processes when we call DeleteSoon, not in the destructor.  Otherewise the process can be reused in the meantime.  This matches what we do in ChildProcessHost.

BUG=21038
Review URL: http://codereview.chromium.org/257028
------------------------------------------------------------------------
r28031 | johnnyg@chromium.org | 2009-10-05 22:39:17 +0200 (Mon, 05 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Adds command line flag to enable desktop notifications.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/249057/show

------------------------------------------------------------------------
r28028 | tony@chromium.org | 2009-10-05 22:28:12 +0200 (Mon, 05 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc

Remove a NOTREACHED from the keyword editor dialog.  To hit,
open the keyword editor dialog and press enter.

Review URL: http://codereview.chromium.org/259029
------------------------------------------------------------------------
r28023 | mattm@chromium.org | 2009-10-05 21:36:55 +0200 (Mon, 05 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Coverity: check TemplateURL::url return value.

CID=6325
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/256045
------------------------------------------------------------------------
r28019 | mattm@chromium.org | 2009-10-05 21:22:51 +0200 (Mon, 05 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   D /trunk/src/chrome/browser/importer/importer_bridge.cc
   D /trunk/src/chrome/browser/importer/importer_bridge.h
   D /trunk/src/chrome/browser/importer/importer_list.cc
   D /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/mork_reader.h
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/chrome.gyp

Revert "Refactor ImporterHost as preparation for OOP switch", which caused purify XP leak:

std::_W::_Allocate(unsigned int,wchar_t *) [unit_tests.exe]
Alloc Location
   ...
   chrome/browser/importer/ie_importer.cc  IEImporter::StartImport(ProfileInfo,WORD,ImporterBridge *)
   base/tuple.h  ?DispatchToMethod@VImporter@@P81@AEXUProfileInfo@@GPAVImporterBridge@@@ZU2@GV?$scoped_refptr@VImporterBridge@@@@@@YAXPAVImporter@@P80@AEXUProfileInfo@@GPAVImporterBridge@@@ZABU?$Tuple3@UProfileInfo@@GV?$scoped_refptr@VImporterBridge@@@@@@@Z
   ^^^

This reverts commit r28007 and r27996.

TBR=jeremy

Review URL: http://codereview.chromium.org/260011
------------------------------------------------------------------------
r28016 | mark@chromium.org | 2009-10-05 21:07:34 +0200 (Mon, 05 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/nsimage_cache_mac.h (from /trunk/src/chrome/browser/cocoa/nsimage_cache.h:27995)
   A /trunk/src/base/nsimage_cache_mac.mm (from /trunk/src/chrome/browser/cocoa/nsimage_cache.mm:27995)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   D /trunk/src/chrome/browser/cocoa/nsimage_cache.h
   D /trunk/src/chrome/browser/cocoa/nsimage_cache.mm
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/chrome.gyp

Move nsimage_cache into base so that it can be accessed from outside of chrome.
This is in support of the next round of rebundling.

TEST=does it still build, do the unit tests still pass, does it still work?
BUG=14610
Review URL: http://codereview.chromium.org/243100
------------------------------------------------------------------------
r28007 | craig.schlenter@chromium.org | 2009-10-05 20:00:47 +0200 (Mon, 05 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_list.h

Add missing include.

Review URL: http://codereview.chromium.org/242144
------------------------------------------------------------------------
r28005 | estade@chromium.org | 2009-10-05 19:28:04 +0200 (Mon, 05 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Task Manager: show right click context menu no matter where you click on the task manager window.

discoverability++

Review URL: http://codereview.chromium.org/203047
------------------------------------------------------------------------
r27999 | jshin@chromium.org | 2009-10-05 18:38:41 +0200 (Mon, 05 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc

Add a dummy call to icu::TimeZone.createDefault() before the sandbox kicks in.
This is necessary to get the datetime formatting work correctly in a renderer process (e.g. FTP directory list that is now done in a renderer process.)

BUG=23361,23082
TEST=...

Review URL: http://codereview.chromium.org/243060
------------------------------------------------------------------------
r27997 | asargent@chromium.org | 2009-10-05 18:11:35 +0200 (Mon, 05 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc

Do not use the utility process on linux.

We don't currently use the zygote to spawn the utility process, so after browser updates bad bugs can occur with mismatched subprocesses. See crbug.com/23327 and crbug.com/22703.

BUG=23327
TEST=Extensions installation/autoupdate and New Tab Page tip download should still work.

Review URL: http://codereview.chromium.org/256036
------------------------------------------------------------------------
r27996 | jeremy@chromium.org | 2009-10-05 18:10:30 +0200 (Mon, 05 Oct 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   A /trunk/src/chrome/browser/importer/importer_bridge.cc
   A /trunk/src/chrome/browser/importer/importer_bridge.h
   A /trunk/src/chrome/browser/importer/importer_list.cc
   A /trunk/src/chrome/browser/importer/importer_list.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/mork_reader.h
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/chrome.gyp

(please review thoroughly since this touches many moving parts).

Refactor ImporterHost as preparation for OOPprofile import.

ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process.

This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc.

ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world.

ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface.

There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work.  For now I'm trying to keep these CLs as small as I can.

BUG=14458
TEST=Profile import should continue to work on Windows/Linux & Mac.

Review URL: http://codereview.chromium.org/242091
------------------------------------------------------------------------
r27992 | rohitrao@chromium.org | 2009-10-05 16:57:56 +0200 (Mon, 05 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

[Mac] Insert views into the proper place in the view hierarchy when tearing off tabs.

BUG=http://crbug.com/19320
BUG=http://crbug.com/23407
BUG=http://crbug.com/20555
TEST=Tearing off a tab with an open infobar should not show a blank transparent space.  After tearing off a tab, both find in page and fullscreen should work properly.
Review URL: http://codereview.chromium.org/258012
------------------------------------------------------------------------
r27983 | thomasvl@chromium.org | 2009-10-05 14:37:05 +0200 (Mon, 05 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm

Infobar l10n pass
- remove the close button outlet (unused)
- add a helper to hide the buttons and resize the text field to use the same.
- if no image, move the text field
- tweak the xib to make it clear the values aren't used
- tweak the xib to remove the NSEveryone image
- make the link text use the control's font so it matches what's in the xib and other infobar modes (if we ever had to tweak it).
- use the GTM helper for autosizing buttons
- reflow how we position the buttons/textfield for the button infobars so it updates the textfield once.

TEST=if you make the window skinny, any infobars that don't have buttons shouldn't reserve space for them.  the the plugin crashed info bar shouldn't show a bogus graphic (currently we have none set).
BUG=20535
BUG=19183
Review URL: http://codereview.chromium.org/251075
------------------------------------------------------------------------
r27981 | thomasvl@chromium.org | 2009-10-05 14:07:52 +0200 (Mon, 05 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/character_encoding.cc

"Windows" and "Macintosh" are proper names, and should be capitalized in the UI.

TEST=Encoding menus should have these two capitalized.
BUG=22843
Review URL: http://codereview.chromium.org/251043
------------------------------------------------------------------------
r27966 | jnd@chromium.org | 2009-10-04 03:17:55 +0200 (Sun, 04 Oct 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

TestOverrideEncoding hanging is because TabProxy::WaitForNavigation can not get reply if current last last_navigation_time for tab _tracker is great than the input last_navigation_time.

See AutomationProvider::WaitForNavigation, it is handled by IPC_MESSAGE_HANDLER_DELAY_REPLY, which means the message handler need to send the reply message by itself.
According to current WaitForNavigation logic, if current last last_navigation_time for tab _tracker is less than the input last_navigation_time, the replay will be sent by NavigationNotificationObserver. Otherwise, the reply will never be sent.
So if somehow the test machine is slow, the navigation has happened before calling AutomationProvider::WaitForNavigation, the caller will never get reply. That is why TestOverrideEncoding hangs sometimes.

Please refer to http://chrome-svn/viewvc/chrome?view=rev&revision=9585 to see how the logic was changed before.

The problem also happened on other two places. 

BUG=23121
TEST=BrowserEncodingTest.TestOverrideEncoding

Review URL: http://codereview.chromium.org/242024
------------------------------------------------------------------------
r27961 | tim@chromium.org | 2009-10-04 00:17:54 +0200 (Sun, 04 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.cc
   M /trunk/src/chrome/browser/views/confirm_message_box_dialog.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h

Change ConfirmMessageBoxDialog to just be a native view (it was only windows before, too, but now at least it doesn't
cause zombie processes) with an observer that is notified when the user clicks OK/closes the dialog instead of running
a nested message loop and blocking.  This fixes bug 20451, where nested message loops were running a confirm dialog and
could cause zombie processes at browser shutdown.

BUG=20451
TEST=None (manual: verify that the confirmation dialog is shown when you try to remove all passwords, and that no zombie is left behind if the browser is closed while the confirmation dialog is showing)
Review URL: http://codereview.chromium.org/243054
------------------------------------------------------------------------
r27956 | timsteele@google.com | 2009-10-03 23:33:11 +0200 (Sat, 03 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/client_command_channel.h
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   M /trunk/src/chrome/browser/sync/util/event_sys.h
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc

Sync: Remove pthreads from event_sys code. Remove asynch version of GaiaAuthenticator, as it 
is never used.  This allowed replacing all lock/mutex code with current MessageLoop assertions.
Some temp scaffolding in auth_watcher (e.g creating a message loop for the current pthread),
which will be removed as part of my next trick.

TEST=sync_unit_tests suite, sync_integration_tests suite
BUG=19895

Review URL: http://codereview.chromium.org/251080
------------------------------------------------------------------------
r27954 | nsylvain@chromium.org | 2009-10-03 23:02:51 +0200 (Sat, 03 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Fix a warning:
browser_focus_uitest.cc:401: warning: 'unfocused_browser' may be used uninitialized in this function
browser_focus_uitest.cc:400: warning: 'focused_browser' may be used uninitialized in this function

TBR:maruel
Review URL: http://codereview.chromium.org/256050
------------------------------------------------------------------------
r27951 | aa@chromium.org | 2009-10-03 21:39:24 +0200 (Sat, 03 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html

Add an API to manipulate the browser action badge.

BUG=23268

Review URL: http://codereview.chromium.org/256032
------------------------------------------------------------------------
r27950 | pkasting@chromium.org | 2009-10-03 19:02:25 +0200 (Sat, 03 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc

Linux build failure makes no sense.  Try random fix.

------------------------------------------------------------------------
r27949 | pkasting@chromium.org | 2009-10-03 18:47:10 +0200 (Sat, 03 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/blocked_popup_container_unittest.cc
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h

Rewrite chunks of the blocked popup container code:
* Fix an off-by-one error in menu rendering if a renderer actually sent us kImpossibleNumberOfPopups.
* Be clearer and stricter about item indexes and sanity checking.  Hopefully, this or the previous item fix a crash we saw (no bug filed).
* Add notice support (as much as exists for Windows) to GTK and Mac.
* Make the implementations in the three platforms mirror each other a little more precisely.
* Fix (expected, actual) mis-ordering in Mac unittest.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260005
------------------------------------------------------------------------
r27943 | jorlow@chromium.org | 2009-10-03 09:07:34 +0200 (Sat, 03 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc
   M /trunk/src/webkit/api/public/WebKitClient.h
   A /trunk/src/webkit/api/public/WebStorageEventDispatcher.h
   M /trunk/src/webkit/api/src/StorageEventDispatcherChromium.cpp
   A /trunk/src/webkit/api/src/StorageEventDispatcherImpl.cpp
   A /trunk/src/webkit/api/src/StorageEventDispatcherImpl.h
   A /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.cpp
   A /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/webkit.gyp

Another stab at the Chromium side of storage events.  Re-submission of http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch
er_host.cc

TBR=darin
TEST=Manually inspected that storage events fired.  Will turn on more layout tests in a 
subsequent patch.
BUG=19972

Original review URL: http://codereview.chromium.org/223013

Review URL: http://codereview.chromium.org/258010
------------------------------------------------------------------------
r27942 | jorlow@chromium.org | 2009-10-03 08:51:15 +0200 (Sat, 03 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   M /trunk/src/webkit/api/public/WebStorageNamespace.h
   M /trunk/src/webkit/api/src/StorageNamespaceProxy.cpp
   M /trunk/src/webkit/api/src/WebStorageNamespaceImpl.cpp
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Add quota support.

Add a 5mb quota to DOM Storage.  Most of the details are in an upstream patch (https://bugs.webkit.org/show_bug.cgi?id=29991 ).

BUG=16876
TEST=I added a layout test upstream and it works.

Review URL: http://codereview.chromium.org/255050
------------------------------------------------------------------------
r27941 | darin@chromium.org | 2009-10-03 07:01:26 +0200 (Sat, 03 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/api/public/WebFrameClient.h
   M /trunk/src/webkit/api/public/WebView.h
   M /trunk/src/webkit/api/public/WebViewClient.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/empty_webframeclient.h
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

More WebView / WebViewDelegate cleanup.

Moves a bunch of methods from glue to the WebKit API.

R=dglazkov
BUG=10033
TEST=none

Review URL: http://codereview.chromium.org/246079
------------------------------------------------------------------------
r27937 | brettw@chromium.org | 2009-10-03 06:25:37 +0200 (Sat, 03 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/clipboard
   A /trunk/src/app/clipboard/clipboard.cc (from /trunk/src/base/clipboard.cc:27849)
   A /trunk/src/app/clipboard/clipboard.h (from /trunk/src/base/clipboard.h:27849)
   A /trunk/src/app/clipboard/clipboard_linux.cc (from /trunk/src/base/clipboard_linux.cc:27849)
   A /trunk/src/app/clipboard/clipboard_mac.mm (from /trunk/src/base/clipboard_mac.mm:27849)
   A /trunk/src/app/clipboard/clipboard_unittest.cc (from /trunk/src/base/clipboard_unittest.cc:27849)
   A /trunk/src/app/clipboard/clipboard_util_win.cc (from /trunk/src/base/clipboard_util.cc:27849)
   A /trunk/src/app/clipboard/clipboard_util_win.h (from /trunk/src/base/clipboard_util.h:27849)
   A /trunk/src/app/clipboard/clipboard_win.cc (from /trunk/src/base/clipboard_win.cc:27849)
   A /trunk/src/app/clipboard/scoped_clipboard_writer.cc (from /trunk/src/base/scoped_clipboard_writer.cc:27849)
   A /trunk/src/app/clipboard/scoped_clipboard_writer.h (from /trunk/src/base/scoped_clipboard_writer.h:27849)
   M /trunk/src/app/os_exchange_data_provider_win.cc
   M /trunk/src/app/os_exchange_data_win_unittest.cc
   M /trunk/src/base/base.gyp
   D /trunk/src/base/clipboard.cc
   D /trunk/src/base/clipboard.h
   D /trunk/src/base/clipboard_linux.cc
   D /trunk/src/base/clipboard_mac.mm
   D /trunk/src/base/clipboard_unittest.cc
   D /trunk/src/base/clipboard_util.cc
   D /trunk/src/base/clipboard_util.h
   D /trunk/src/base/clipboard_win.cc
   D /trunk/src/base/scoped_clipboard_writer.cc
   D /trunk/src/base/scoped_clipboard_writer.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   A /trunk/src/chrome/browser/net/browser_url_util.cc
   A /trunk/src/chrome/browser/net/browser_url_util.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/webkit/glue/scoped_clipboard_writer_glue.h
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webclipboard_impl.h
   M /trunk/src/webkit/glue/webdropdata_win.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_clipboard_impl.cc
   M /trunk/src/webkit/webkit.gyp

Move the clipboard stuff out of base and into app/clipboard. I renamed
clipboard_util to clipboard_util_win since it's Windows-only. This patch makes
test_shell depend on app as well. There should be no logic change.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/260003
------------------------------------------------------------------------
r27934 | estade@chromium.org | 2009-10-03 05:51:32 +0200 (Sat, 03 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h

Gtk: Update slide animation progress in a cleaner way.

BUG=none
TEST=animations still work: infobar, findbar, download shelf

Review URL: http://codereview.chromium.org/255071
------------------------------------------------------------------------
r27933 | brettw@chromium.org | 2009-10-03 05:51:06 +0200 (Sat, 03 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist.cc

Fix a build error in the jumplist to use the new png codec location.

TEST=none
BUG=none
------------------------------------------------------------------------
r27930 | brettw@chromium.org | 2009-10-03 05:12:20 +0200 (Sat, 03 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gfx/codec
   A /trunk/src/app/gfx/codec/DEPS
   A /trunk/src/app/gfx/codec/jpeg_codec.cc (from /trunk/src/base/gfx/jpeg_codec.cc:27822)
   A /trunk/src/app/gfx/codec/jpeg_codec.h (from /trunk/src/base/gfx/jpeg_codec.h:27822)
   A /trunk/src/app/gfx/codec/jpeg_codec_unittest.cc (from /trunk/src/base/gfx/jpeg_codec_unittest.cc:27822)
   A /trunk/src/app/gfx/codec/png_codec.cc (from /trunk/src/base/gfx/png_decoder.cc:27822)
   A /trunk/src/app/gfx/codec/png_codec.h (from /trunk/src/base/gfx/png_decoder.h:27822)
   A /trunk/src/app/gfx/codec/png_codec_unittest.cc (from /trunk/src/base/gfx/png_codec_unittest.cc:27822)
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/base/base.gyp
   M /trunk/src/base/gfx/DEPS
   D /trunk/src/base/gfx/jpeg_codec.cc
   D /trunk/src/base/gfx/jpeg_codec.h
   D /trunk/src/base/gfx/jpeg_codec_unittest.cc
   D /trunk/src/base/gfx/png_codec_unittest.cc
   D /trunk/src/base/gfx/png_decoder.cc
   D /trunk/src/base/gfx/png_decoder.h
   D /trunk/src/base/gfx/png_encoder.cc
   D /trunk/src/base/gfx/png_encoder.h
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/top_sites.cc
   M /trunk/src/chrome/browser/icon_loader_linux.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/tools/profiles/generate_profile.cc
   M /trunk/src/printing/image.cc
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/tools/imagediff/image_diff.cc
   M /trunk/src/tools/imagediff/image_diff.gyp
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classes
into the gfx namespace.

Combine the PNGEncoder and PNGDecoder. There were separate when we had
different executables for the browser and renderer, and linked the encoder only
in one of them (which saved us some space used by libpng). This hasn't been the
case for years, so combining them (again) makes sense.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/243076
------------------------------------------------------------------------
r27926 | ananta@chromium.org | 2009-10-03 04:17:31 +0200 (Sat, 03 Oct 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Pass unhandled keyup messages coming in from the renderer to the underlying view. This is needed
for system keyboard messages which are generated when the Alt key is pressed in addition to other
keys to function correctly in ChromeFrame.

The TabContentsView implementation for windows does the right thing by specifically checking for keydown
events before processing them as accelerators. The TabContentsView implementation for Linux also treated
keyup messages as accelerators, which is now fixed.

This fixes parts of http://code.google.com/p/chromium/issues/detail?id=22996

Bug=22996

Review URL: http://codereview.chromium.org/255028
------------------------------------------------------------------------
r27925 | aa@chromium.org | 2009-10-03 03:51:09 +0200 (Sat, 03 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Try again to check in the badge stuff.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r27918 | tony@chromium.org | 2009-10-03 01:58:05 +0200 (Sat, 03 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Add histograms that track how long it takes to open the new tab page.

This doesn't time all loads of the new tab page, just new foreground
tabs using ctrl+t or the plus button.  This includes the time it takes
to create the tab contents and logs the time until JS has started
executing, domcontentloaded, and onload.

Note: onload doesn't mean the page is done loading.  We have "NewTabUI load" for that.

BUG=23120

Review URL: http://codereview.chromium.org/242107
------------------------------------------------------------------------
r27916 | tony@chromium.org | 2009-10-03 01:41:11 +0200 (Sat, 03 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc

Set the default action of the import data dialog to "Import" and
focus the button.

BUG=19627

Review URL: http://codereview.chromium.org/259028
------------------------------------------------------------------------
r27912 | nsylvain@chromium.org | 2009-10-03 01:15:16 +0200 (Sat, 03 Oct 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/protocol/proto2_to_oproto.py
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Revert my revert because it causes more problems.

------------------------------------------------------------------------
r27910 | nsylvain@chromium.org | 2009-10-03 01:00:03 +0200 (Sat, 03 Oct 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/protocol/proto2_to_oproto.py (from /trunk/src/chrome/browser/sync/protocol/proto2_to_oproto.py:27817)
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/third_party/protobuf2/protobuf.gyp

revert this change because protoc.exe crashes during compile and breaks the try servers:

Set the LITE runtime optimization flag in sync.proto.
This generates c++ code without support for protobuf reflections, and
shaves 175000 bytes off of the final release size of syncapi.dll.


Review URL: http://codereview.chromium.org/242133
------------------------------------------------------------------------
r27906 | finnur@chromium.org | 2009-10-02 23:58:49 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

Disabling the test while I figure out why it is flaky.
And update the version number (forgot in my last changelist). No code change there.

TBR=nsylvain

Review URL: http://codereview.chromium.org/255066
------------------------------------------------------------------------
r27905 | jcampan@chromium.org | 2009-10-02 23:56:53 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disabling a filing test temporarily.

TEST=None
BUG=23683
TBR=cpu
Review URL: http://codereview.chromium.org/257040
------------------------------------------------------------------------
r27901 | jcampan@chromium.org | 2009-10-02 23:17:45 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Find-in-bar would steal focus when switching tab.

BUG=23296
TEST=See bug.
Review URL: http://codereview.chromium.org/243073
------------------------------------------------------------------------
r27898 | finnur@chromium.org | 2009-10-02 23:09:14 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   A /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/iframe.js
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/style.css
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html
   A /trunk/src/chrome/test/data/feeds/feed4.xml
   A /trunk/src/chrome/test/data/feeds/feed5.xml

We now postMessage the RSS file over to the js script and have it parse it there in the context of the iframe instead of doing this in the extension html page.

BUG=None
TEST=Covered by automated tests.
Review URL: http://codereview.chromium.org/246066
------------------------------------------------------------------------
r27896 | tony@chromium.org | 2009-10-02 23:03:15 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h

Switch to using radio buttons for toggling the custom frame. Use
title case for the context menu on the title bar.

BUG=23412

Review URL: http://codereview.chromium.org/255059
------------------------------------------------------------------------
r27895 | tony@chromium.org | 2009-10-02 22:59:13 +0200 (Fri, 02 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc

Use IDS_THEME_INSTALL_INFOBAR_UNDO_BUTTON instead of IDS_UNDO since 3.0
shipped.

Review URL: http://codereview.chromium.org/257036
------------------------------------------------------------------------
r27893 | pkasting@chromium.org | 2009-10-02 22:44:15 +0200 (Fri, 02 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc

Fix compile failure due to bad merge.

------------------------------------------------------------------------
r27892 | pkasting@chromium.org | 2009-10-02 22:40:56 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/common/mru_cache.h
   M /trunk/src/chrome/common/mru_cache_unittest.cc

Add a Clear() function to MRUCache.  This will be useful in my MemoryPurger class.  Technically you can call ShrinkToSize(0), but that's both less clear and slower.

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/257024
------------------------------------------------------------------------
r27891 | pkasting@chromium.org | 2009-10-02 22:40:47 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h

Make usage of iterator types more consistent, which also saves some code.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243072
------------------------------------------------------------------------
r27890 | pkasting@chromium.org | 2009-10-02 22:37:27 +0200 (Fri, 02 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc

Convert users of RenderProcessHost iterator to all use same style.  The key motivator for this is that at least one old place actually did the wrong thing in its loop and failed to call functions on anything but the first host.  This also makes many places slightly shorter.

Remove an unneeded #include in web_cache_manager.h by converting it to a forward declaration.

Update copyrights on touched files.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242104
------------------------------------------------------------------------
r27889 | erikkay@chromium.org | 2009-10-02 22:19:20 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   A /trunk/src/chrome/browser/views/extensions/extension_popup.cc
   A /trunk/src/chrome/browser/views/extensions/extension_popup.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/view_types.h
   A /trunk/src/chrome/test/data/extensions/samples/set_page_color
   A /trunk/src/chrome/test/data/extensions/samples/set_page_color/icon.png
   A /trunk/src/chrome/test/data/extensions/samples/set_page_color/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html
   M /trunk/src/views/controls/button/menu_button.h

Add simple popup support to browser actions.  This will create a popup HTML window that extends below a browser action button  when the browser is clicked.  When it loses focus, it is automatically dismissed.

BUG=23596
TEST=none

Review URL: http://codereview.chromium.org/258011
------------------------------------------------------------------------
r27887 | darin@chromium.org | 2009-10-02 22:14:29 +0200 (Fri, 02 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   A /trunk/src/chrome/test/data/session_history/location_redirect.html
   A /trunk/src/chrome/test/data/session_history/location_redirect_frame1.html
   A /trunk/src/chrome/test/data/session_history/location_redirect_frame2.html
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc

Do not discount a MANUAL_SUBFRAME load just because it involved
some redirects.

R=brettw
BUG=21353
TEST=none

Review URL: http://codereview.chromium.org/246073
------------------------------------------------------------------------
r27885 | shess@chromium.org | 2009-10-02 22:05:10 +0200 (Fri, 02 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Change Omnibox to select-all on mouse-up if the mouse didn't move.

This is to match Windows...

http://crbug.com/22980
TEST=When Omnibox has focus, everything should work identically.
TEST=Put focus in content.  Single-click in Omnibox should select-all on mouse-up.
TEST=Put focus in content.  Click-drag in Omnibox should select text like normal.
TEST=Put focus in content.  Double-click should select-all on first mouse-up, but select-word on next click.
TEST=Same test for triple-click.

Review URL: http://codereview.chromium.org/243063
------------------------------------------------------------------------
r27884 | idanan@google.com | 2009-10-02 22:01:09 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc

Support multiple EOL types in Privacy Blacklists

BUG=16932
TEST=none
TBR=maruel

Review URL: http://codereview.chromium.org/251078
------------------------------------------------------------------------
r27881 | mattm@chromium.org | 2009-10-02 21:57:58 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc

Coverity: Check CreateNewTempDirectory return value.

CID=6021,6020,6019
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/256033
------------------------------------------------------------------------
r27875 | jcampan@chromium.org | 2009-10-02 21:05:19 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

The focus would only be restored properly the first time the
find-in-bar box was closed.
Also wrote an interactive ui test and took the opportunity to convert the existing find-in-bar interactive ui test to be a browser test.

BUG=23599
TEST=See bug.
Review URL: http://codereview.chromium.org/251064
------------------------------------------------------------------------
r27873 | piman@chromium.org | 2009-10-02 21:00:31 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/nacl_process_host.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/render_process.cc

Add an option to disable NaCl at compile time for platforms where it doesn't build yet

Just add disable_nacl=1 to gyp defines

Review URL: http://codereview.chromium.org/257029
------------------------------------------------------------------------
r27865 | estade@chromium.org | 2009-10-02 20:11:09 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Any time we are shutting down a tab, try to use fast shutdown.

BUG=http://crbug.com/5638
TEST=existing tab strip model tests, Fast shutdown ui tests, new tab strip model fast shutdown test

Review URL: http://codereview.chromium.org/235050
------------------------------------------------------------------------
r27861 | pinkerton@chromium.org | 2009-10-02 19:59:13 +0200 (Fri, 02 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Fix several issues with dragging tabs and quickly letting go, including crashes because we get mouseDragged "events" after mouseUp, windows that stay transucent, and windows that vanish entirely but stay in the window list.
BUG=22266, 13594, 22538
TEST=dragging tabs between windows should still work
Review URL: http://codereview.chromium.org/243080
------------------------------------------------------------------------
r27853 | jhawkins@chromium.org | 2009-10-02 19:42:07 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h

gtk: Restore the window that is hidden when the last tab is dragged out of the window.

BUG=21002
TEST=Drag the last tab out of a window and press esc.  The window should be restored.
Review URL: http://codereview.chromium.org/257026
------------------------------------------------------------------------
r27852 | jam@chromium.org | 2009-10-02 19:30:36 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Revert my attempt at cleaning up RenderViewHost::UnhandledKeyboardEvent in my previous patch.  Looks like the check is needed because otherwise KeyUp triggers the accelerator a second time.

BUG=23260
TBR=craig.schlenter
Review URL: http://codereview.chromium.org/246078
------------------------------------------------------------------------
r27850 | tony@chromium.org | 2009-10-02 19:18:46 +0200 (Fri, 02 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Fix the NewTabUI load UMA metric.

We were attaching the paint observer to the a RenderWidgetHost that
was getting immediately swapped out when the new tab page started
to load.  Instead, wait and use the DOM UI callback methods which
happen right after NewTabUI is created.

Review URL: http://codereview.chromium.org/242115
------------------------------------------------------------------------
r27849 | yurys@google.com | 2009-10-02 18:46:34 +0200 (Fri, 02 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/debugger_closure.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: test that scopes can be epxanded

Review URL: http://codereview.chromium.org/258016
------------------------------------------------------------------------
r27848 | darin@chromium.org | 2009-10-02 18:28:56 +0200 (Fri, 02 Oct 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/api/public/WebViewClient.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Restore plumbing for the spelling panel on Mac.

It turns out this is reached through a very awkward code path.  We send an IPC
to the renderer so that it can call WebFrame::executeCommand passing it the
"ToggleSpellingPanel" command.  That is intercepted in our code--in
WebFrameImpl--and results in calling a method on Editor that just turns around
and calls EditorClient.  EditorClient is again our code, which just pokes the
embedder via WebViewClient to get it to send an IPC back to the browser so that
it can show the spelling panel.

I would have just short-circuited all of this plumbing if it weren't for the
side-effect that this code has of triggering an update to the spelling panel.
That way it can show the correct word.  I think that could be done a simpler
way, but for now, I'm content to just restore the way things were.

R=pinkerton
BUG=23543
TEST=manual test: right click on a misspelled word and select the option on
Mac Chrome to show the spelling panel.  you should see it appear :)

Review URL: http://codereview.chromium.org/246071
------------------------------------------------------------------------
r27841 | mirandac@chromium.org | 2009-10-02 17:14:29 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Fix NTP so that it updates on theme change.

BUG= http://crbug.com/20392
TEST= Open several windows and new tabs.  Change theme.  Note that NTP background images all update correctly.


Review URL: http://codereview.chromium.org/243067
------------------------------------------------------------------------
r27837 | yurys@google.com | 2009-10-02 14:01:44 +0200 (Fri, 02 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: reenable step-out test as issues causing its failure on linux was fixed in WebKit r48970

TBR=pfeldman
Review URL: http://codereview.chromium.org/256039
------------------------------------------------------------------------
r27832 | brettw@chromium.org | 2009-10-02 07:01:42 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/app/sql/connection.cc
   M /trunk/src/app/sql/connection.h
   M /trunk/src/app/sql/connection_unittest.cc
   M /trunk/src/app/sql/statement.cc
   M /trunk/src/app/sql/statement.h
   M /trunk/src/app/sql/statement_unittest.cc
   M /trunk/src/app/sql/transaction_unittest.cc
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_database.cc
   M /trunk/src/chrome/browser/history/in_memory_database.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.h
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h

Convert history to use new sql wrappers. Enhance wrappers in several ways to
support the needs of history.

BUG=none
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/246053
------------------------------------------------------------------------
r27826 | mattm@chromium.org | 2009-10-02 06:12:38 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc

Coverity: Remove unnecessary GetPasswordFormAt call.

CID=6161
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/242108
------------------------------------------------------------------------
r27825 | mattm@chromium.org | 2009-10-02 06:11:04 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Coverity: Check GetInteger & GetBoolean return.

CID=5937,5838
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/255051
------------------------------------------------------------------------
r27824 | brettw@chromium.org | 2009-10-02 06:02:39 +0200 (Fri, 02 Oct 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_types.h
   A /trunk/src/chrome/browser/history/top_sites.cc
   A /trunk/src/chrome/browser/history/top_sites.h
   A /trunk/src/chrome/browser/history/top_sites_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/thumbnail_score.cc
   M /trunk/src/chrome/common/thumbnail_score.h
   A /trunk/src/chrome/common/thumbnail_score_unittest.cc

Add some initial code for the top sites service. This will be a replacement for
the thumbnail database, and will also replace the ThumbnailStore which was the
previous replacement we didn't ship. This component will be very much like the
ThumbnailStore wtih the addition of the actual most visited data (not just
thumbnails) and that it is threadsafe.

This class is designed to be called on any thread. When it is complete,
thumbnails will be added to it from the UI thread of the browser. Requests for
thumbnails and the most visited data can be serviced directly on the I/O thread
without going through the UI thread, and since the data is cached, the request
won't also have to go through the history thread.

The current state is that it cqan store and update the the most visited list and thumbnails. There are unit tests covering this behavior.

I also added support for redirect ranking to ThumbnailScore. This is to
duplicated the ranking function in history currently, where it prefers
thumbnails closer to the end of a redirect chain. Since we won't be using the
history service and are only storing thumbnails for the most visited items, we
have to track the redirect index ourselves.

BUG=none
TEST=covered by unit tests (hopefully!)
Review URL: http://codereview.chromium.org/251002
------------------------------------------------------------------------
r27823 | jam@chromium.org | 2009-10-02 05:30:49 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

For some reason, if the interactive test that I added runs after inprocess tests (still in interactive tests), it gives an assert in Linux before it starts because the existing process count is 2.  Moving it to a different file solves the prolbem.

TBR=jcampan
BUG=5496
Review URL: http://codereview.chromium.org/259010
------------------------------------------------------------------------
r27822 | jam@chromium.org | 2009-10-02 04:20:29 +0200 (Fri, 02 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Attempt to fix the Linux views build
------------------------------------------------------------------------
r27818 | nick@chromium.org | 2009-10-02 03:42:46 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/protocol/proto2_to_oproto.py
   M /trunk/src/chrome/browser/sync/protocol/sync.proto
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/third_party/protobuf2/protobuf.gyp

Set the LITE runtime optimization flag in sync.proto.
This generates c++ code without support for protobuf reflections, and
shaves 175000 bytes off of the final release size of syncapi.dll.
BUG=none
TEST=tested sync interactively with two clients.

Review URL: http://codereview.chromium.org/249034
------------------------------------------------------------------------
r27816 | pkasting@chromium.org | 2009-10-02 03:29:29 +0200 (Fri, 02 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/test/testing_profile.h

Add Profile::DeleteSpellChecker(), which my MemoryPurger will use to purge the spellchecker objects from memory.

This reworks the SpellChecker management functions inside the ProfileImpl for simplicity.  The only notable side effect is that GetSpellChecker() will now cause a notification if it inits |spellchecker_|, just like ReinitializeSpellChecker() already did.  This was just to simplify the code; at the point this fires, no one will be listening yet, so it won't actually do anything.

Also use a temporary at one spot in browser_render_process_host.cc instead of calling a heavyweight function twice in a row.

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/259009
------------------------------------------------------------------------
r27815 | aa@chromium.org | 2009-10-02 03:26:27 +0200 (Fri, 02 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/browser_action_badge_center.png
   D /trunk/src/app/resources/browser_action_badge_left.png
   D /trunk/src/app/resources/browser_action_badge_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Rollback broken change, again.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r27814 | jam@chromium.org | 2009-10-02 03:25:41 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Don't send tab switching/killing/creating keyboard accelerators to pages.  This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish.

BUG=5496
TEST=added ui test
Review URL: http://codereview.chromium.org/224023
------------------------------------------------------------------------
r27812 | aa@chromium.org | 2009-10-02 03:14:46 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/browser_action_badge_center.png
   A /trunk/src/app/resources/browser_action_badge_left.png
   A /trunk/src/app/resources/browser_action_badge_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Check in http://codereview.chromium.org/259004 again.

First cut at badge implementation.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r27811 | chron@chromium.org | 2009-10-02 03:13:35 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h

Replace Read/Write lock with a plain old chrome lock.

BUG=19895

Review URL: http://codereview.chromium.org/246056
------------------------------------------------------------------------
r27810 | cpu@chromium.org | 2009-10-02 02:44:16 +0200 (Fri, 02 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc

Add UMA histograms for sqlite errors
- cookies
- history db

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/243055
------------------------------------------------------------------------
r27807 | mattm@chromium.org | 2009-10-02 02:15:16 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Coverity: check Thread::Start return value.

CID=6207,6206
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/242105
------------------------------------------------------------------------
r27805 | estade@chromium.org | 2009-10-02 02:05:12 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc

Fix linux views build.

TBR=nsylvain

Review URL: http://codereview.chromium.org/255049
------------------------------------------------------------------------
r27804 | paul@chromium.org | 2009-10-02 02:01:35 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc

Change a phishing report URL param.

BUG=22542
TEST=None.

Review URL: http://codereview.chromium.org/242110
------------------------------------------------------------------------
r27801 | estade@chromium.org | 2009-10-02 01:50:21 +0200 (Fri, 02 Oct 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.h

GTK: Detach bookmark bar on NTP.

TODO=get alignment right for NTP background when alignment != top
TODO=fancy-pants animation (on windows this animation looks rather janky anyway so I'm not eager to work on this)
TODO=tweak in gtk mode (border color=?)

TEST=fiddle a lot, make sure there are no problems with find bar occlusion.
TEST=install a bunch of different themes; everything looks right (up to TODOs)
TEST=switch back and forth between gtk theme and chromium theme
TEST=popup windows still work
TEST=poked around in valgrind
TEST=poked around with fullscreen

BUG=18780

Review URL: http://codereview.chromium.org/243057
------------------------------------------------------------------------
r27798 | mpcomplete@chromium.org | 2009-10-02 01:44:00 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   M /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/notification_type.h

Add some debugging junk to ExtensionMessageService to track down a crash.

BUG=21201
TEST=no

Review URL: http://codereview.chromium.org/256029
------------------------------------------------------------------------
r27794 | nick@chromium.org | 2009-10-02 01:19:13 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.h

A small cleanup to the sync setup flow.
BUG=20339
TEST=none

Review URL: http://codereview.chromium.org/243065
------------------------------------------------------------------------
r27792 | nick@chromium.org | 2009-10-02 01:14:53 +0200 (Fri, 02 Oct 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc

Convert the SslInitializationSingleton over to a base/singleton.

The existing implementation crashed when I switched syncapi to static
linkage, I think because pthreads had already been unloaded when
CleanupSSL happened.

BUG=19895
TEST=basic two-client sync run-through, start-up, shutdown.

Review URL: http://codereview.chromium.org/246067
------------------------------------------------------------------------
r27786 | brettw@chromium.org | 2009-10-02 00:51:49 +0200 (Fri, 02 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Do some cleanup of BrowserRenderProcessHost::Init to try to reduce the
complexity and clean up some of the ifdefs.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/254008
------------------------------------------------------------------------
r27783 | tony@chromium.org | 2009-10-02 00:45:13 +0200 (Fri, 02 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

Update some strings in the options dialog w.r.t. themes.

Changed the heading from Themes: to Appearance: and switch
from 'Set to XXX theme' to 'Use XXX theme'.

BUG=21504

Review URL: http://codereview.chromium.org/243059
------------------------------------------------------------------------
r27782 | brg@chromium.com | 2009-10-02 00:40:27 +0200 (Fri, 02 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/url_translator.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc

Rename EscapeUrl and expand the code comment.

BUG=none
TEST=Escape.EscapeUrlEncodedData
Review URL: http://codereview.chromium.org/257021
------------------------------------------------------------------------
r27781 | rafaelw@chromium.org | 2009-10-02 00:36:06 +0200 (Fri, 02 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Ensure ChromeURLRequestContext finds out first about extension loading.

This prevents races from arising where extension renderers may try to navigate to extension urls before the request context knows how to map the urls to extension resources.

BUG=22668

Review URL: http://codereview.chromium.org/255047
------------------------------------------------------------------------
r27779 | chocobo@google.com | 2009-10-02 00:33:47 +0200 (Fri, 02 Oct 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   M /trunk/src/chrome/browser/chromeos/network_menu_button.h
   M /trunk/src/chrome/browser/chromeos/password_dialog_view.cc
   M /trunk/src/chrome/browser/chromeos/password_dialog_view.h
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/common/chrome_paths.cc

Hook up wifi menu button UI to ChromeOS shared library.
BUG=none
TEST=23090
Review URL: http://codereview.chromium.org/246057
------------------------------------------------------------------------
r27774 | shess@chromium.org | 2009-10-01 23:47:03 +0200 (Thu, 01 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Unit test -[AutocompleteTextField mouseDown:].

Breaking this off of the change to single-click because this is
definitely a keeper, that one might be contencious.

http://crbug.com/22980
TEST=Unit test only.

Review URL: http://codereview.chromium.org/242103
------------------------------------------------------------------------
r27772 | ericu@google.com | 2009-10-01 23:42:14 +0200 (Thu, 01 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/base/scoped_clipboard_writer.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h

The "Copy URL" link is always greyed out in the Chrome menu on popups [crbug.com/13488].
This turns out to be because it was never implemented.
Tested manually on Windows; I'll test on Linux before submitting.

BUG=13488
TEST=Tested manually on Windows and added a unit test for the new Clipboard function.

Review URL: http://codereview.chromium.org/210042
------------------------------------------------------------------------
r27769 | shess@chromium.org | 2009-10-01 23:31:18 +0200 (Thu, 01 Oct 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_application_mac.mm

[Mac] Don't crash when selecting closed window from Dock menu.

The Dock menu contains an automagic section where you can select
amongst open windows.  This is wired up to send to the window as a
target, but if JavaScript closes the window in the meanwhile, it
messages a freed object.  This short-circuits the specific selector if
the window is no longer valid.

http://crbug.com/14003
TEST=Bug contains instructions and an example html file to help.

Review URL: http://codereview.chromium.org/259001
------------------------------------------------------------------------
r27764 | aa@chromium.org | 2009-10-01 22:43:29 +0200 (Thu, 01 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/browser_action_badge_center.png
   D /trunk/src/app/resources/browser_action_badge_left.png
   D /trunk/src/app/resources/browser_action_badge_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Revert tree bustage.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r27763 | mattm@chromium.org | 2009-10-01 22:37:03 +0200 (Thu, 01 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Coverity: Check return value of GetInteger.

CID=6192
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/257013
------------------------------------------------------------------------
r27761 | aa@chromium.org | 2009-10-01 22:33:33 +0200 (Thu, 01 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/browser_action_badge_center.png
   A /trunk/src/app/resources/browser_action_badge_left.png
   A /trunk/src/app/resources/browser_action_badge_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

First cut at badge implementation. Right now it just uses static
data. A subsequent change will hook it up to the extension APIs.

See http://dl.getdropbox.com/u/124107/badges.png for a picture
of what this looks like.

BUG=23268

Review URL: http://codereview.chromium.org/259004
------------------------------------------------------------------------
r27760 | jhawkins@chromium.org | 2009-10-01 22:29:27 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h

Coverity: Initialize lock_, semaphore_, and test_socket_ in the constructor.

CID=2297
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255007
------------------------------------------------------------------------
r27759 | jorlow@chromium.org | 2009-10-01 22:16:48 +0200 (Thu, 01 Oct 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc
   M /trunk/src/webkit/api/public/WebKitClient.h
   D /trunk/src/webkit/api/public/WebStorageEventDispatcher.h
   M /trunk/src/webkit/api/src/StorageEventDispatcherChromium.cpp
   D /trunk/src/webkit/api/src/StorageEventDispatcherImpl.cpp
   D /trunk/src/webkit/api/src/StorageEventDispatcherImpl.h
   D /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.cpp
   D /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/webkit.gyp

Reverting 27756.
Review URL: http://codereview.chromium.org/249058
------------------------------------------------------------------------
r27758 | jhawkins@chromium.org | 2009-10-01 22:03:33 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h

Coverity: Fix the AcceleratorPressed override to match the declaration in WidgetWin.

CID=4190
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255031
------------------------------------------------------------------------
r27756 | jorlow@chromium.org | 2009-10-01 21:51:45 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc
   M /trunk/src/webkit/api/public/WebKitClient.h
   A /trunk/src/webkit/api/public/WebStorageEventDispatcher.h
   M /trunk/src/webkit/api/src/StorageEventDispatcherChromium.cpp
   A /trunk/src/webkit/api/src/StorageEventDispatcherImpl.cpp
   A /trunk/src/webkit/api/src/StorageEventDispatcherImpl.h
   A /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.cpp
   A /trunk/src/webkit/api/src/WebStorageEventDispatcherImpl.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/webkit.gyp

Another stab at the Chromium side of storage events.  The WebKit side can be found here: https://bugs.webkit.org/show_bug.cgi?id=29655

TEST=Manually inspected that storage events fired.  Will turn on more layout tests in a subsequent patch.
BUG=19972

Review URL: http://codereview.chromium.org/223013
------------------------------------------------------------------------
r27755 | amanda@chromium.org | 2009-10-01 21:41:56 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   A /trunk/src/chrome/browser/plugin_process_host_mac.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Fix several issues around fullscreen Mac plugins:
* Keystrokes are now properly sent to plugins in fullscreen mode
* When a plugin creates a fullscreen window, we hide the menu bar and restore it when the window is closed
BUG=19534,21020
TEST=Open a page with plugins that can go full screen (example: flash video players).  Enter full screen mode and verify that esc, arrow keys, spacebar, etc. work as expected.  Verify that the menu bar is hidden when the plugin goes fullscreen and is restored when it exits fullscreen mode.
Review URL: http://codereview.chromium.org/257008
------------------------------------------------------------------------
r27751 | pkasting@chromium.org | 2009-10-01 20:50:19 +0200 (Thu, 01 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/memory_purger.cc
   A /trunk/src/chrome/browser/memory_purger.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add framework of MemoryPurger, a class to dump memory from everywhere possible.  Currently does nothing.

This also adds a "Purge memory" button to the task manager when run with --purge-memory-button, which can be used to test the functionality.

BUG=23400
TEST=Run with --purge-memory-button, open the task manager and see a new button.  Click it to toggle it to "Reset purge", and click again to toggle back.
Review URL: http://codereview.chromium.org/259003
------------------------------------------------------------------------
r27744 | erg@google.com | 2009-10-01 20:18:45 +0200 (Thu, 01 Oct 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

GTK: Don't hard code status bubble border.

Review URL: http://codereview.chromium.org/255040
------------------------------------------------------------------------
r27741 | mpcomplete@chromium.org | 2009-10-01 20:06:47 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc
   A /trunk/src/chrome/browser/extensions/extension_browser_actions_api.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/samples/test_browser_action
   A /trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html
   A /trunk/src/chrome/test/data/extensions/samples/test_browser_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/test_browser_action/print2_16x16.png
   A /trunk/src/chrome/test/data/extensions/samples/test_browser_action/print_16x16.png

Add chrome.browserAction.setName and .setIcon.

BUG=23379
TEST=Load the print_browser_action extension from the samples test dir and click it. The icon and name should update.

Review URL: http://codereview.chromium.org/242081
------------------------------------------------------------------------
r27740 | pkasting@chromium.org | 2009-10-01 19:59:38 +0200 (Thu, 01 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/base/system_monitor.cc
   M /trunk/src/base/system_monitor.h
   M /trunk/src/base/system_monitor_unittest.cc
   M /trunk/src/base/time_win.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Simplify the PowerObserver API by removing unneeded args and providing default implementations.

This also makes all the subclasses use the same code to add/remove observers.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244054
------------------------------------------------------------------------
r27728 | pkasting@chromium.org | 2009-10-01 19:17:36 +0200 (Thu, 01 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h

Fix a typo in a comment.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244053
------------------------------------------------------------------------
r27720 | sky@chromium.org | 2009-10-01 16:55:28 +0200 (Thu, 01 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc

Fixes bug in determining if we can paste from the clipboard. Need to
use IsFormatAvailableByString rather than IsFormatAvailable.

BUG=21106
TEST=see bug, also covered by unit test now.

Review URL: http://codereview.chromium.org/256016
------------------------------------------------------------------------
r27719 | idanan@google.com | 2009-10-01 16:00:02 +0200 (Thu, 01 Oct 2009) | 66 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blocked_response.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blocked_response.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/resources/privacy_blacklist_block.html

Privacy Blacklist Unblock

Summary
-------

Mostly implemented the unblocking for visual resources for the Privacy Blacklist.
Merging now before I leave. Eveything here only has effect if the --privacy-blacklist
flag specifies a Privacy Blacklist.

Detailed Changes
----------------

[chrome/browser/resources/privacy_blacklist.html]

- Replaced the about:blank place-holder with variable to set the unblock link.

- Open the Privacy Blacklist provider page in a new tab. This works around an
  issue where such request for a full-page (rather than a sub-resource) gets
  blocked indefinitely.

[chrome/browser/render_host/resource_dispatcher_host.h]

- Added a BlockedResponse member which is now a class rather than a namespace,
  see below for more information.

[chrome/browser/render_host/resource_dispatcher_host.cc]

- Generate headers for the blocked response to redirect to the chrome-blocked URL
  which prevents an enclosing page from reading the URL of the unblock link. This
  was suggested by Darin to avoid scripted bypassing of blocked contents.

- Recover the original URL for blocked content, in order to fetch it during
  unblocking.

- Do not create CrossSiteResourceHandler when an unblocked link is requested.
  Otherwise the request never resumes as the blocked page never gets closed
  since it is not a real page.

[chrome/browser/privacy_blacklist/blocked_response.cc]

- Defined chrome-block and chrome-unblock URL schemes. The block scheme is used
  to return the blocked response. The unblock scheme is used request a blocked
  resource's URL without being intercepted by the Privacy Blacklist.

- Defined a hash function for a blocked resource as its address in memory.
  Function to reverse the hash is therefore trivial.

- Added a function to return headers for a blocked response.

- Added a function to generate a block URL from a requested one.

- Added a function to get an unblock URL from a requested one.

- Added a function to return the original URL for a blocked one.

[chrome/browser/privacy_blacklist/blocked_response.h]

- Made the BlockedResponse namespace into a class.

- Created a member set to keep all the blocked resources URL.

BUG=16932
TEST=none
TBR=darin

Review URL: http://codereview.chromium.org/252001
------------------------------------------------------------------------
r27713 | brg@chromium.com | 2009-10-01 11:19:29 +0200 (Thu, 01 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/url_translator.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc

Add EscapeURL to the ASCII escape methods.EscapeURL escapes all forbidden ascii characters in an URL and repalces spaces with '+'.

Test=Escape.EscapeUrl
BUG=23029
Review URL: http://codereview.chromium.org/244056
------------------------------------------------------------------------
r27704 | viettrungluu@chromium.org | 2009-10-01 07:01:55 +0200 (Thu, 01 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm

Mac: *Correctly* fill file extension as drag source.

(We have to strip the '.' from the file extension.)

BUG=23431
TEST=Make sure images can still be dragged to, e.g., the desktop; make sure images can be dragged to Acorn <http://www.flyingmeat.com/acorn/>.

Review URL: http://codereview.chromium.org/255035
------------------------------------------------------------------------
r27700 | estade@chromium.org | 2009-10-01 05:19:10 +0200 (Thu, 01 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc

GTK: improve app mode .desktop file creation.

1) pass --user-data-dir when appropriate
2) don't overwrite old .desktop files that share the same name.

BUG=23353

Review URL: http://codereview.chromium.org/255016
------------------------------------------------------------------------
r27699 | viettrungluu@chromium.org | 2009-10-01 05:10:15 +0200 (Thu, 01 Oct 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: Allow window/app. to be closed when tab modal sheets are showing.

This patch consists only of code deletions. Despite the comments in the
deleted code, it's all okay since sheets are closed:
|TabContents::~TabContents()| calls
|ConstrainedWindowMac::CloseConstrainedWindow()|, which calls
|ConstrainedWindowMacDelegate::DeleteDelegate()|, which should close the
sheet if it's still open. This code path has been in use for quite some
time, since we've allowed (or failed to disallow!) tabs containing
sheets to be closed via the close tab button.

BUG=19427
TEST=Open some tabs (possibly in multiple windows) with some tab modal sheet (e.g., by navigating to <http://www.pagetutor.com/keeper/mystash/secretstuff.html>); close a window containing such a tab, with a tab modal sheet visible or not; quit application while a tab modal sheet is active (not nec. visible).

Review URL: http://codereview.chromium.org/242059
------------------------------------------------------------------------
r27698 | sky@chromium.org | 2009-10-01 05:00:46 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h

Reenables showing crashed info bar on chrome os.

BUG=23502
TEST=none

Review URL: http://codereview.chromium.org/249050
------------------------------------------------------------------------
r27696 | mhm@chromium.org | 2009-10-01 04:05:03 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Make sure download shelf items and download items don't share names.

BUG=23046
TEST=Compiled and ran on Windows

Review URL: http://codereview.chromium.org/242082
------------------------------------------------------------------------
r27692 | jar@chromium.org | 2009-10-01 02:25:41 +0200 (Thu, 01 Oct 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/third_party/tcmalloc/config_linux.h
   M /trunk/src/third_party/tcmalloc/config_win.h
   D /trunk/src/third_party/tcmalloc/google/malloc_extension.h
   D /trunk/src/third_party/tcmalloc/malloc_extension.cc
   M /trunk/src/third_party/tcmalloc/page_heap.cc
   M /trunk/src/third_party/tcmalloc/page_heap.h
   M /trunk/src/third_party/tcmalloc/tcmalloc.cc
   M /trunk/src/third_party/tcmalloc/tcmalloc.gyp

Rollback Scavenge implemetation and rely on existing functionality to free

This is a landing of a patch provided by antonm.  See:
http://codereview.chromium.org/235022

Also included change to browser_about_handler.cc to fix build, and I set
TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this
was an inadvertent rollback element).

r=antonm
Review URL: http://codereview.chromium.org/257009
------------------------------------------------------------------------
r27690 | jrg@chromium.org | 2009-10-01 01:58:41 +0200 (Thu, 01 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Add "copy" to context menu on bookmark button.

BUG=http://crbug.com/16941
TEST=Right-click on bookmark button; pick copy.
  Go to any other app and paste.  Make sure you got URL.

Review URL: http://codereview.chromium.org/249048
------------------------------------------------------------------------
r27689 | estade@chromium.org | 2009-10-01 01:56:15 +0200 (Thu, 01 Oct 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h

GTK: Fix memory leak from r27666.

Make MenuGtk take ownership of submenus.

BUG=none
TEST=valgrind doesn't complain

Review URL: http://codereview.chromium.org/251053
------------------------------------------------------------------------
r27686 | aa@chromium.org | 2009-10-01 01:38:44 +0200 (Thu, 01 Oct 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Set the initial enabledness state of any browser actions when
the window first comes up.

BUG=23380
TEST=Install an extension that has a browser action. Open a
new window. Browser action menu item should be disabled in
wrench menu.

Review URL: http://codereview.chromium.org/242083
------------------------------------------------------------------------
r27677 | tim@chromium.org | 2009-10-01 00:48:58 +0200 (Thu, 01 Oct 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc

Tweak constants used by sync setup wizard unittest. Reviewed by nick.
------------------------------------------------------------------------
r27666 | estade@chromium.org | 2009-10-01 00:16:33 +0200 (Thu, 01 Oct 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h

GTK: Implement popup favicon menu.

BUG=18181

Review URL: http://codereview.chromium.org/244029
------------------------------------------------------------------------
r27663 | creis@google.com | 2009-10-01 00:05:29 +0200 (Thu, 01 Oct 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h

Stops the throbber from spinning if the user cancels a beforeunload dialog,
if the dialog is triggered by a reload or location bar entry.

BUG=22004
TEST=BrowserTest.ReloadThenCancelBeforeUnload

Review URL: http://codereview.chromium.org/256015
------------------------------------------------------------------------
r27662 | jhawkins@chromium.org | 2009-10-01 00:00:50 +0200 (Thu, 01 Oct 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc

Coverity: tips_cache_->GetSize() returns an unsigned int so the comparison >= 0 is always true.  Change the check to != 0 to actually have an effect.

CID=6044
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255030
------------------------------------------------------------------------
r27661 | rohitrao@chromium.org | 2009-09-30 23:38:09 +0200 (Wed, 30 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

[Mac] Rewrite and renable a badly-written unittest.

BUG=None
TEST=Test should pass.
Review URL: http://codereview.chromium.org/255029
------------------------------------------------------------------------
r27658 | pkasting@chromium.org | 2009-09-30 23:27:34 +0200 (Wed, 30 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/base/base.gyp
   D /trunk/src/base/idle_timer.cc
   D /trunk/src/base/idle_timer.h
   D /trunk/src/base/idle_timer_none.cc
   D /trunk/src/base/idletimer_unittest.cc
   M /trunk/src/chrome/browser/browser.cc

Remove IdleTimer, which no one uses.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244049
------------------------------------------------------------------------
r27657 | pkasting@chromium.org | 2009-09-30 23:25:33 +0200 (Wed, 30 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Make the cache columns in the Task Manager sortable and only displayed once per process on GTK and Mac, just like was already done on Windows.

BUG=16221
TEST=Open Task Manager on GTK or Mac, add a WebCore Cache column, see that it only prints one line of output per process, and verify it's sortable.
Review URL: http://codereview.chromium.org/251046
------------------------------------------------------------------------
r27654 | aa@chromium.org | 2009-09-30 22:54:26 +0200 (Wed, 30 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h

Make browser actions highlight on mouseover using theme colors.

Also, adjust layout a bit to allow for larger icons.

BUG=23363,23377
TEST=Install an extension that has a browser action. It should
highlight on rollover.

Review URL: http://codereview.chromium.org/246051
------------------------------------------------------------------------
r27653 | finnur@chromium.org | 2009-09-30 22:46:33 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Landing patch from contributor Thiago Farina.

Update GetDownloadDirectory to take FilePath instead of wstring to avoid conversions "To and From wstring". 

BUG=None 
TEST=run ui_tests.exe 

Review URL: http://codereview.chromium.org/243047
------------------------------------------------------------------------
r27652 | pkasting@chromium.org | 2009-09-30 22:42:27 +0200 (Wed, 30 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/base/field_trial.h
   M /trunk/src/base/process.h
   M /trunk/src/base/process_posix.cc
   M /trunk/src/base/process_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_trial.cc
   M /trunk/src/chrome/browser/browser_trial.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/testing_browser_process.h

Remove all MemoryModel-related code, since we're unlikely to use it again.  Also changes some sample code to use a random generic name ("PruningAlgorithm") instead of MemoryModel in hopes that no one will be confused.

This does not remove IdleTimer, even though it now has no users.  I do plan to remove it, but I want to do that in a separate commit so it's easy to reference and revert if at some later point we want this functionality.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242079
------------------------------------------------------------------------
r27649 | rsesek@chromium.org | 2009-09-30 22:20:58 +0200 (Wed, 30 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.h

[Mac] Make the "Get themes" button in Preferences a link (again)

BUG=21414
TEST=Preferences-->Personal Stuff, "Get themes..." is a hyperlink.

Review URL: http://codereview.chromium.org/244047
------------------------------------------------------------------------
r27641 | thomasvl@chromium.org | 2009-09-30 21:06:18 +0200 (Wed, 30 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/PageInfo.xib
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Page Info Window
- Localize title
- Localize button
- Autosize button to text
- Localize headings
- Fetch the page info good/bad images from the resource bundle
Stop including the page info good/bad images in the app bundle.

TEST=Page Info dialog is localized and the button isn't clipped.
BUG=20230
BUG=20536
Review URL: http://codereview.chromium.org/246048
------------------------------------------------------------------------
r27637 | kbr@google.com | 2009-09-30 20:35:49 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Added command line argument --enable-webgl to facilitate turning on
ENABLE_3D_CANVAS in development builds. Currently this argument also
requires disabling the sandbox.

BUG=http://crbug.com/21852
TEST=none (runs preexisting WebGL layout tests; more coming)

Review URL: http://codereview.chromium.org/246042
------------------------------------------------------------------------
r27636 | pkasting@chromium.org | 2009-09-30 20:28:44 +0200 (Wed, 30 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Make it possible to sort the WebCore Cache size columns in the Task Manager.  Also only show cache sizes once per process since the WebCore Cahce is a singleton within the renderer process.

BUG=16221
TEST=none
Review URL: http://codereview.chromium.org/244041
------------------------------------------------------------------------
r27632 | hclam@chromium.org | 2009-09-30 19:49:41 +0200 (Wed, 30 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.h
   M /trunk/src/webkit/glue/media/buffered_data_source_unittest.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h

Enable <video> using cache

Retrying the following two patches:
http://codereview.chromium.org/253001/show
http://codereview.chromium.org/248012/show

TBR=scherkus

Review URL: http://codereview.chromium.org/242073
------------------------------------------------------------------------
r27630 | sidchat@chromium.org | 2009-09-30 19:47:23 +0200 (Wed, 30 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Make moles work for --show-extensions-on-top.

BUG=www.crbug.com/21271
TEST=none
Review URL: http://codereview.chromium.org/249033
------------------------------------------------------------------------
r27625 | mirandac@chromium.org | 2009-09-30 19:28:24 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Change disk access on theme install from UI to File thread.

BUG= http://crbug.com/17696
TEST= none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27520
Review URL: http://codereview.chromium.org/222025
------------------------------------------------------------------------
r27618 | jrg@chromium.org | 2009-09-30 18:52:33 +0200 (Wed, 30 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

When a button may have grown (e.g. icon loaded), recompute if we need
to show/hide the "off the side" button on the right of the bookmark
bar.

BUG=http://crbug.com/21887
TEST=Get a bunch of bookmarks with icons.  Shrink the window width
until the icon JUST BARELY appears.  Quit and relaunch Chrome.  Make
sure "iff the side" button is visible.


Review URL: http://codereview.chromium.org/249037
------------------------------------------------------------------------
r27616 | jrg@chromium.org | 2009-09-30 18:50:52 +0200 (Wed, 30 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Fix bookmark trimming.

BUG=http://crbug.com/22825
TEST=rename bookmarks to the following names; make sure the full name shows up (and not "t...").
     test, FBL, Moma, SFGate
  Now rename a bookmark to "banana whamma fo famma me mi mo mamma banana" 
  and make sure it is trimmed.

Review URL: http://codereview.chromium.org/249038
------------------------------------------------------------------------
r27615 | darin@chromium.org | 2009-09-30 18:49:54 +0200 (Wed, 30 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h

Remove some unused code.

R=pinkerton
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/256005
------------------------------------------------------------------------
r27614 | kuchhal@chromium.org | 2009-09-30 18:49:33 +0200 (Wed, 30 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Set new homepage preferences only if there is no existing value.

BUG=23402
TEST=On a clean install, make sure Chrome has Homepage button enabled. Use master_preferences to disable homapage button and make sure it works.

Review URL: http://codereview.chromium.org/255025
------------------------------------------------------------------------
r27612 | jar@chromium.org | 2009-09-30 18:04:24 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/meta_table_helper.cc

Re-enable SQL lite preload

We previously disabled it it to see if it was involved with the double 
free... but the cause has been shown to be a thread-unsafe reference 
count (not a party to this change).

r=brettw
Review URL: http://codereview.chromium.org/246036
------------------------------------------------------------------------
r27607 | kuchhal@chromium.org | 2009-09-30 16:22:54 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h

BrowsingDataRemover* should not be scoped.

BrowsingDataRemover deletes itself (see browsing_data_remover.cc:
MessageLoop::current()->DeleteSoon(FROM_HERE, this)).

BUG=22068

Review URL: http://codereview.chromium.org/218001
------------------------------------------------------------------------
r27606 | pinkerton@chromium.org | 2009-09-30 15:58:22 +0200 (Wed, 30 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Fix a bug where dragging a window that's been closed by JS back into another window would crash. Be more specific about when the window will be closed/deleted during dragging in hopes of making future crashes a little more clear.
BUG=none
TEST=dragging tabs between windows should work. tabs closed via window.close() on a timer should work.
Review URL: http://codereview.chromium.org/246035
------------------------------------------------------------------------
r27603 | yurys@google.com | 2009-09-30 12:17:41 +0200 (Wed, 30 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: temorarily disable TestStepOut as it fails on Linux

TBR=pfeldman
Review URL: http://codereview.chromium.org/256009
------------------------------------------------------------------------
r27600 | yurys@google.com | 2009-09-30 11:06:31 +0200 (Wed, 30 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/debugger_step.html
   A /trunk/src/chrome/test/data/devtools/debugger_step.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: add tests for step over/out/in

Review URL: http://codereview.chromium.org/248040
------------------------------------------------------------------------
r27599 | aa@chromium.org | 2009-09-30 09:32:01 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/extensions/browser_action_test.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_action.cc
   M /trunk/src/chrome/common/extensions/extension_action.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/samples/make_page_red
   A /trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html
   A /trunk/src/chrome/test/data/extensions/samples/make_page_red/icon.png
   A /trunk/src/chrome/test/data/extensions/samples/make_page_red/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon
   A /trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon/background.html
   A /trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon/manifest.json

Integrate browser actions with the wrench menu. Browser
actions always show up in a submenu of the wrench menu, and
if they have an icon, they also show up in the toolbar area.

BUG=23380,22883
TEST=Added new automated tests for the command handling, but we need to test that the menu items show up manually. To do that, run with no extension installed, you should see "extensions" in the wrench menu. Add an extension that adds a browser action, you should now see an "extensions" submenu with "manage extensions" and the browser action(s) in the submenu.

Review URL: http://codereview.chromium.org/246037
------------------------------------------------------------------------
r27597 | suzhe@chromium.org | 2009-09-30 07:29:29 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Try to fix AutocompleteEditViewTest failures on buildbot (issue 23213).

The failures must be caused by timing issue. This CL tries to fix the issue by initializing all necessary components before running tests.

BUG=23213 AutocompleteEditViewTest tests are failing
TEST=none

Review URL: http://codereview.chromium.org/242047
------------------------------------------------------------------------
r27595 | mbelshe@google.com | 2009-09-30 06:42:46 +0200 (Wed, 30 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/net/socket/tcp_client_socket_win.cc

Relanding:
Implement a readsize throttle within the TCP socket.

Add a fieldgroup trial for testing it.

BUG=none
TEST=none

Original Review URL: http://codereview.chromium.org/173259

Review URL: http://codereview.chromium.org/243038
------------------------------------------------------------------------
r27594 | darin@chromium.org | 2009-09-30 06:29:20 +0200 (Wed, 30 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/base/message_pump_glib_unittest.cc
   M /trunk/src/base/ref_counted.h
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/common/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

Reverting 27389.
Review URL: http://codereview.chromium.org/246027
------------------------------------------------------------------------
r27590 | hclam@chromium.org | 2009-09-30 05:23:04 +0200 (Wed, 30 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h

Revert r27589 that broke the tree

TBR=scherkus

Review URL: http://codereview.chromium.org/246043
------------------------------------------------------------------------
r27589 | hclam@chromium.org | 2009-09-30 04:50:01 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h

<video> use cache if --enable-byte-range-support is present

BUG=16013
TEST=Playing a video should still work with the flag in incognito mode or not.

Allow <video> to use cache if running with experimental byte range support.

Review URL: http://codereview.chromium.org/253001
------------------------------------------------------------------------
r27578 | derat@chromium.org | 2009-09-30 02:48:16 +0200 (Wed, 30 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Linux: Make InfoBubble use an override-redirect (popup) window.

This makes it work correctly in ion3 and other window managers that don't expect clients to try to move top-level windows themselves.

This implementation grabs the pointer and keyboard.  By doing this and using an override-redirect window, we should be able to avoid worrying about interactions with different window managers.  The only downside (alluded to in the previous code) is that window manager keybindings don't make it through until the user dismisses the bubble by clicking outside of it or hitting Enter or Escape.  I don't think this will be a problem; it's no different from what happens when you open a context menu in an app.

BUG=20523
TEST=tested first-run and bookmark bubbles in Metacity, ion3, Fluxbox, KDE4, and the WM that I'm working on

Review URL: http://codereview.chromium.org/198016
------------------------------------------------------------------------
r27577 | nick@chromium.org | 2009-09-30 02:44:21 +0200 (Wed, 30 Sep 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/engine/syncapi_stub.cc
   M /trunk/src/chrome/chrome.gyp

Remove the syncapi stub.
This was only needed so that we could compile the sync glue code
without access to a syncapi binary.  Now that syncapi can be built from
source, it's obsolete.

Review URL: http://codereview.chromium.org/242060
------------------------------------------------------------------------
r27565 | erg@google.com | 2009-09-30 01:30:41 +0200 (Wed, 30 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK: Use a calculated border color in chrome theme mode instead of blue.

Review URL: http://codereview.chromium.org/255012
------------------------------------------------------------------------
r27563 | jcampan@chromium.org | 2009-09-30 01:15:10 +0200 (Wed, 30 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native/native_view_host_win.h
   M /trunk/src/views/controls/native/native_view_host_wrapper.h
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.h
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc

Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). 

Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. 

See original review:
http://codereview.chromium.org/235011/show

BUG=None 
TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. 
TBR=ben

Review URL: http://codereview.chromium.org/246032
------------------------------------------------------------------------
r27562 | finnur@chromium.org | 2009-09-30 01:12:35 +0200 (Wed, 30 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   A /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/style.css
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html
   A /trunk/src/chrome/test/data/feeds/feed3.xml
   A /trunk/src/chrome/test/data/feeds/feed_script.xml

The RSS extension now renders the RSS HTML preview inside an IFRAME.

BUG=None
TEST=See browser tests.

Review URL: http://codereview.chromium.org/242055
------------------------------------------------------------------------
r27559 | darin@chromium.org | 2009-09-30 01:06:13 +0200 (Wed, 30 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   M /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   A /trunk/src/chrome/browser/net/file_reader.cc
   A /trunk/src/chrome/browser/net/file_reader.h
   A /trunk/src/chrome/browser/net/file_reader_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Use a helper to facilitate reading a file on a background thread.

This fixes a thread-safety bug in ExecuteCodeInTabFunction caused by using
RefCounted instead of RefCountedThreadSafe.  Instead of changing
ExecuteCodeInTabFunction to be RefCountedThreadSafe, I thought it would be
better to fork off a helper class.

R=aa
BUG=none
TEST=file_reader_unittest.cc and existing browser_tests (once my other patch
lands which adds thread-safety assertions to NewRunnableMethod)

Review URL: http://codereview.chromium.org/243033
------------------------------------------------------------------------
r27556 | brg@chromium.com | 2009-09-30 01:00:41 +0200 (Wed, 30 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc

Cleanup some code in the render_view_host_manager unittest.
The initialization of the ProfileSyncService was being called twice in one test.

Test=RenderViewHostManagerTest in unittests
Bug=none
Review URL: http://codereview.chromium.org/248036
------------------------------------------------------------------------
r27552 | jrg@chromium.org | 2009-09-30 00:46:11 +0200 (Wed, 30 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Fix crash when using about:ipc with only NTP on Windows.
Must check iterator's Done() before dereferencing (list may be empty).

Review URL: http://codereview.chromium.org/243040
------------------------------------------------------------------------
r27550 | estade@chromium.org | 2009-09-30 00:38:47 +0200 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

GTK: Fix a bookmark dragging crasher by initing a member var.

Not sure when this regressed. Looking at the svn history I can't even find a revision where it would have worked. We probably made some other change that revealed this long-standing bug.

BUG=23233
TEST=drag a bookmark out of a bookmark bar folder

Review URL: http://codereview.chromium.org/255011
------------------------------------------------------------------------
r27544 | darin@chromium.org | 2009-09-30 00:20:49 +0200 (Wed, 30 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.h

These classes need to use thread safe reference counting.

Detected using this CL:
http://codereview.chromium.org/251012

R=jcampan
BUG=none
TEST=covered by browser tests once my assertion to NewRunnableMethod lands.

Review URL: http://codereview.chromium.org/251033
------------------------------------------------------------------------
r27540 | mirandac@chromium.org | 2009-09-30 00:08:22 +0200 (Wed, 30 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Reverting 27520.
Review URL: http://codereview.chromium.org/256003
------------------------------------------------------------------------
r27533 | mark@chromium.org | 2009-09-29 23:32:55 +0200 (Tue, 29 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Use Mac fonts in Mac Chrome.

Use Helvetica, Times, Courier, Apple Chancery, and Papyrus for sans-serif,
serif, monospace, cursive, and fantasy, respectively.  These are the fonts
used by Safari and Firefox on the Mac, and the fonts that we run layout tests
with on the Mac.

BUG=19135 21458
TEST=http://www.w3.org/Style/Examples/007/fonts
     Check the fonts for sans-serif, serif, monospace, cursive, fantasy
     Note that the font used for "Helvetica, sans-serif" is actually Verdana
Review URL: http://codereview.chromium.org/244039
------------------------------------------------------------------------
r27531 | derat@chromium.org | 2009-09-29 23:27:01 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Raise window after click on titlebar or border.

BUG=23318
TEST=checked that it matches native window behavior in metacity and kwin

Review URL: http://codereview.chromium.org/246029
------------------------------------------------------------------------
r27526 | thomasvl@chromium.org | 2009-09-29 21:57:32 +0200 (Tue, 29 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ImportProgressDialog.xib
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm

Import dialog fixup:
- use one call string convert
- load the nib from the main bundle
- make the cancel button autosize to it's string
- make the cancel button tweak it's position based on the string (not dialog position, but keep the right edge as is)
- fix up some field overlaps, and position, dialog still isn't pretty, but this is how Cole said to leave it rather then reopen the discussion now.
- use the WithFixup helpers to deal with ellipses 

TEST=button fits text, fields don't overlap any strings.
BUG=20534
Review URL: http://codereview.chromium.org/235055
------------------------------------------------------------------------
r27525 | jhawkins@chromium.org | 2009-09-29 21:37:22 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_unittest.cc

Coverity: Initialize got_thumbnail_callback_, query_url_success_, and redirect_query_success_ in the constructor.

CID=1653
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/251031
------------------------------------------------------------------------
r27524 | jcampan@chromium.org | 2009-09-29 21:10:58 +0200 (Tue, 29 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_win.cc

This CL cleans-up the FindBarHost and fixes an assert that happens on the focus manager when closing Chrome (linux toolkit views). 

See original review at:
http://codereview.chromium.org/220036/show

BUG=None 
TEST=Make sure find works as expected on Chrome Linux toolkit views.
TBR=ben

Review URL: http://codereview.chromium.org/243035
------------------------------------------------------------------------
r27523 | mattm@chromium.org | 2009-09-29 21:09:51 +0200 (Tue, 29 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc

Coverity: Fix memleak in GetNodeDictionary again.

CID=4804
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/246025
------------------------------------------------------------------------
r27522 | tim@chromium.org | 2009-09-29 21:08:29 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Unflakify SyncerThreadWithSyncerTest.Polling by using TimeTicks instead of system time.  Should have done that first, but I had started writing the test before writing the code and learning how to use TimeTicks.

TEST=SyncerThreadWithSyncerTest.Polling
BUG=23336

Review URL: http://codereview.chromium.org/248034
------------------------------------------------------------------------
r27520 | mirandac@chromium.org | 2009-09-29 21:00:18 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Change disk access on theme install from UI to File thread.

BUG= http://crbug.com/17696
TEST= none

Review URL: http://codereview.chromium.org/222025
------------------------------------------------------------------------
r27517 | pinkerton@chromium.org | 2009-09-29 20:40:58 +0200 (Tue, 29 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Fix a typo.
BUG=NONE
TEST=NONE
------------------------------------------------------------------------
r27516 | rafaelw@chromium.org | 2009-09-29 20:28:47 +0200 (Tue, 29 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc
   M /trunk/src/net/url_request/url_request_job_manager.cc

Enable ExtensionApiTest.Toolstrip and add additional debug output.

This output is testing the prospect that the cause of the flakiness is a race to the IO thread between the renderer that is requesting a chrome-extension page and the message to insert the correct mapping to service the request.

BUG=22668

Review URL: http://codereview.chromium.org/251025
------------------------------------------------------------------------
r27515 | jhawkins@chromium.org | 2009-09-29 20:25:54 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/common/navigation_types.h

Coverity: Initialize all member variables in the default constructor.

CID=1315
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243029
------------------------------------------------------------------------
r27511 | pkasting@chromium.org | 2009-09-29 20:13:07 +0200 (Tue, 29 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/base/waitable_event_watcher_unittest.cc
   M /trunk/src/base/weak_ptr_unittest.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/property_bag_unittest.cc
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/filters/ffmpeg_demuxer_unittest.cc
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/ssl_client_auth_cache_unittest.cc
   M /trunk/src/net/ftp/ftp_auth_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc

Avoid potential "NULL used as int" warnings by changing ASSERT_EQ(NULL, ...) to ASSERT_TRUE(... == NULL).  Patch by Jacob Mandelson (see http://codereview.chromium.org/202057 ), r=me.

BUG=none
TEST=none
------------------------------------------------------------------------
r27510 | jhawkins@chromium.org | 2009-09-29 20:09:20 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.h

Coverity: Initialize member variables in the constructor.

CID=1634
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242041
------------------------------------------------------------------------
r27502 | jrg@chromium.org | 2009-09-29 19:28:46 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm

Bookmark menus not updated when their name is edited in the bookmark bar.

BUG=http://crbug.com/23301
TEST=see bug

Review URL: http://codereview.chromium.org/245035
------------------------------------------------------------------------
r27501 | jrg@chromium.org | 2009-09-29 19:28:29 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Disable "OK" button in edit dialog of bookmark button when name is not valid

TEST=see bug
BUG=http://crbug.com/19558

Review URL: http://codereview.chromium.org/249030
------------------------------------------------------------------------
r27500 | jrg@chromium.org | 2009-09-29 19:28:19 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

l10n the "(empty)" string in bookmark bar folders.

BUG=http://crbug.com/17626
TEST=create a new bookmark bar folder.  Open it: the menu should have a disabled item that says "(empty)".

Review URL: http://codereview.chromium.org/235047
------------------------------------------------------------------------
r27495 | tim@chromium.org | 2009-09-29 19:01:10 +0200 (Tue, 29 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h

Make two members private in sync and add getters/setters for them. 

BUG=None 
TEST=None 

Patch by Thiago Farina, http://codereview.chromium.org/242017

Review URL: http://codereview.chromium.org/251029
------------------------------------------------------------------------
r27493 | sky@chromium.org | 2009-09-29 18:48:41 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Adds the ability for script to move the menu.

BUG=23261
TEST=none

Review URL: http://codereview.chromium.org/245045
------------------------------------------------------------------------
r27489 | davemoore@chromium.org | 2009-09-29 18:29:40 +0200 (Tue, 29 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/DEPS

Change the DEPS to support a directory name change.

Review URL: http://codereview.chromium.org/245044
------------------------------------------------------------------------
r27488 | rohitrao@chromium.org | 2009-09-29 18:07:51 +0200 (Tue, 29 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

[Mac] Root the RenderWidgetHostView in the upper left, not the lower left.  This prevents all sorts of fun jank when resizing a window.

BUG=http://crbug.com/23252
TEST=Resize gmail (which is particularly hard on the renderer).  The upper left corner of the view should not change, flicker, or jump around.
Review URL: http://codereview.chromium.org/244030
------------------------------------------------------------------------
r27487 | davemoore@chromium.org | 2009-09-29 18:01:20 +0200 (Tue, 29 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome.gyp

X64: Remove restriction on using r12 as index register.

Review URL: http://codereview.chromium.org/126045
------------------------------------------------------------------------
r27485 | rsesek@chromium.org | 2009-09-29 17:54:48 +0200 (Tue, 29 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

[Mac] Hook up part of the download preferences

Enable the download location path and the prompt-for-download settings.

BUG=22047
TEST=Preferences --> Under the hood, set download location, downloaded file is in new location.
TEST=Enable prompt for download location, download file, save panel comes up.

Review URL: http://codereview.chromium.org/239008
------------------------------------------------------------------------
r27484 | sky@chromium.org | 2009-09-29 17:49:57 +0200 (Tue, 29 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Wires up views on linux dialogs to use gtk ones.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/254007
------------------------------------------------------------------------
r27483 | pinkerton@chromium.org | 2009-09-29 17:47:53 +0200 (Tue, 29 Sep 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/file_metadata.h
   A /trunk/src/chrome/browser/cocoa/file_metadata.mm
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/quarantine_mac.h
   D /trunk/src/chrome/common/quarantine_mac.mm

Add kMDItemWhereFroms metadata attribute to downloaded files. Combine with quarantine utility function and move into chrome/browser/cocoa, since common/ is not the right place for browser code.
BUG=22289
TEST=file downloading
Review URL: http://codereview.chromium.org/220037
------------------------------------------------------------------------
r27481 | thomasvl@chromium.org | 2009-09-29 17:41:20 +0200 (Tue, 29 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FirstRunDialog.xib
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm

Mac First Run:
- Load the nib from the main bundle.
- fetch the learn more url from resources instead of hardcoded in source
- the the layout tweak the sizes of the two buttons based on the l10n strings
- make the browser popup auto position based on the size of the checkbox's text.

BUG=20531
TEST=the button always fit their text and position correctly, the browser menu positions next to the text, learn more for breakpad goes to the right language page.
Review URL: http://codereview.chromium.org/248032
------------------------------------------------------------------------
r27480 | thomasvl@chromium.org | 2009-09-29 17:40:24 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm

Use the mac helpers for fetching resource strings.
Fill in the autosizing code so the text fits in all languages.

TEST=popup blocker is sized to it's text in all languages.
BUG=21278
Review URL: http://codereview.chromium.org/242049
------------------------------------------------------------------------
r27479 | rsesek@chromium.org | 2009-09-29 17:34:32 +0200 (Tue, 29 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.h
   A /trunk/src/chrome/browser/cocoa/hyperlink_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/hyperlink_button_cell_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Create HyperlinkButtonCell and make the "Get themes" button an instance

* Creates a HyperlinkButtonCell that can be used in conjuction with a NSButton
  to display the control as a hyperlink (blue underliend text), rather than
  a normal Cocoa control.
* Switch the "Get themes..." button in Preferences to be one.

BUG=17989,21414
TEST=Preferences-->Personal Stuff, "Get themes..." is a hyperlink.

Review URL: http://codereview.chromium.org/248019
------------------------------------------------------------------------
r27478 | nsylvain@chromium.org | 2009-09-29 17:26:53 +0200 (Tue, 29 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Disable it for real this time.

Review URL: http://codereview.chromium.org/245043
------------------------------------------------------------------------
r27477 | nsylvain@chromium.org | 2009-09-29 17:17:29 +0200 (Tue, 29 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc

Disable SyncerThreadWithSyncerTest.Polling because it's flaky.

BUG:23336
Review URL: http://codereview.chromium.org/255002
------------------------------------------------------------------------
r27475 | rsesek@chromium.org | 2009-09-29 14:08:28 +0200 (Tue, 29 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h

[Windows] Remember the window placement of Keyword editor (Search Engines) to restore again it
in the same place where the user closed it for the last time.

BUG=22269
TEST=open Search engines, move it to a different location, close it, open it again, see if it is
opened in the latest location that you closed.

Review URL: http://codereview.chromium.org/243024
Patch from tfarina.
------------------------------------------------------------------------
r27472 | brg@chromium.com | 2009-09-29 11:11:44 +0200 (Tue, 29 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Remove the enable-sync flag from the Chrome command line and enable sync by default.

BUG=none
Test=Sync my bookmarks should be enabled by default.
Review URL: http://codereview.chromium.org/248024
------------------------------------------------------------------------
r27469 | abarth@chromium.org | 2009-09-29 09:26:25 +0200 (Tue, 29 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   D /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.cc
   D /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/chrome.gyp

Remove old way of handling mixed content now that we have the new mixed content
API in place.

R=agl
TEST=Covered by our mixed content browser tests

Review URL: http://codereview.chromium.org/248013
------------------------------------------------------------------------
r27463 | ananta@chromium.org | 2009-09-29 05:44:06 +0200 (Tue, 29 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Another attempt at landing this.

If IE was navigated away to a different page when the ChromeFrame inspector window was open
it would crash the browser.

The fix is to ensure that the inspector window is closed when the ExternalTabContainer window
is uninitialized.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=22993

Bug=22993

Review URL: http://codereview.chromium.org/249028
------------------------------------------------------------------------
r27456 | jam@chromium.org | 2009-09-29 04:18:30 +0200 (Tue, 29 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/npobject_proxy.cc
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.cc
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/npobject_util.cc
   M /trunk/src/chrome/plugin/npobject_util.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Get rid of the need for cross process events in order to get plugin processes to run nested message loops when a dialog is shown.  Instead use an async message that's broadcast from the renderer to all plugin processes that are connected to it, and which is dispatched on the plugin IO thread to set a process-local waitable event.  This fixes showModalDialog on Linux/Mac.

BUG=15891
TEST=covered by UI tests, undef's them for POSIX
Review URL: http://codereview.chromium.org/242043
------------------------------------------------------------------------
r27450 | mattm@chromium.org | 2009-09-29 03:56:31 +0200 (Tue, 29 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

Coverity: check result of file_util::CopyFile.

CID=5099
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/251023
------------------------------------------------------------------------
r27449 | thestig@chromium.org | 2009-09-29 03:55:00 +0200 (Tue, 29 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/PRESUBMIT.py
   A /trunk/src/chrome/browser/views/PRESUBMIT.py
   A /trunk/src/views/PRESUBMIT.py

Add GetPreferredTrySlaves() to presubmit scripts.

BUG=23071
TEST=none
Review URL: http://codereview.chromium.org/251024
------------------------------------------------------------------------
r27445 | gregoryd@google.com | 2009-09-29 02:33:46 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/browser/nacl_process_host.cc
   A /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/nacl_messages.h
   A /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27397
Review URL: http://codereview.chromium.org/153002
------------------------------------------------------------------------
r27444 | jcampan@chromium.org | 2009-09-29 02:33:35 +0200 (Tue, 29 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/base/keyboard_code_conversion_gtk.cc
   M /trunk/src/base/keyboard_code_conversion_gtk.h
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/event_win.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_win.cc

Relanding keyboard code refactoring:
http://codereview.chromium.org/248010/show

Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. 
Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. 

BUG=None 
TEST=Make sure short-cuts works as expected, especially in the omnibox.



Review URL: http://codereview.chromium.org/251020
------------------------------------------------------------------------
r27438 | tony@chromium.org | 2009-09-29 02:03:50 +0200 (Tue, 29 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h

Directly add ExtensionShelfGtk to the widget hierarchy.

Just code cleanup.  There's some more of this for the
ExtensionShelfGtk::Toolstrip (adding removing the widgets
from the hbox), but I kept that since the abstraction
seems kind of useful.

Review URL: http://codereview.chromium.org/242044
------------------------------------------------------------------------
r27434 | mpcomplete@chromium.org | 2009-09-29 01:36:23 +0200 (Tue, 29 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Retry r27137. Create renderers for ExtensionHosts one at a time to avoid blocking the UI.

I added a process.Close() to the fast shutdown path for renderers. The problem
was that we were trying to use an old terminated process handle.

BUG=14040
TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The
UI should be responsive while the toolstrips are loading.

Review URL: http://codereview.chromium.org/243007
------------------------------------------------------------------------
r27432 | chron@chromium.org | 2009-09-29 01:36:12 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/pthread_helpers.h

Remove unused pthread helpers. Looks like we don't use pthread_rw locks at all.
This CL does not complete 19391, only removes the pthread dep.

BUG=19391

Review URL: http://codereview.chromium.org/231005
------------------------------------------------------------------------
r27426 | tim@chromium.org | 2009-09-29 00:43:21 +0200 (Tue, 29 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

sync i18n support for gaia_login.html and merge_and_sync.htmlMove resources in generated_resources.grd.Move the google logo depending of the order of words in the translation of "Google Account"Add support for rtl locales
BUG=19896
TEST=Make sure the layout of gaia_login.html and merge_and_sync.html is correct in ltr and rtl

Patch by Bruno Calvignac, http://codereview.chromium.org/195082.

Review URL: http://codereview.chromium.org/244024
------------------------------------------------------------------------
r27425 | tony@chromium.org | 2009-09-29 00:38:39 +0200 (Tue, 29 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer_linux.cc

Fix how we calculate workarea size (_NET_WORKAREA gives width/height).

Fix how we calculate initial window size to be workarea - 20 for
height and width.  This matches Windows.

BUG=23229

Review URL: http://codereview.chromium.org/254004
------------------------------------------------------------------------
r27423 | estade@chromium.org | 2009-09-29 00:35:24 +0200 (Tue, 29 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc

Linux: Enable FindInPage automated ui test test.

BUG=none
TEST=run it

Review URL: http://codereview.chromium.org/243010
------------------------------------------------------------------------
r27422 | estade@chromium.org | 2009-09-29 00:35:15 +0200 (Tue, 29 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Use favicon for application shortcut icon.

BUG=22528

Review URL: http://codereview.chromium.org/249023
------------------------------------------------------------------------
r27421 | jam@chromium.org | 2009-09-29 00:32:21 +0200 (Tue, 29 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_factory.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_factory.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/modal_dialog_event.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/render_view_test.cc

Fix deadlock when plugin puts an alert and right afterwards the browser process makes a win32 call that ends up waiting on the plugin.  Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks.  The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked.  The fix is to set the event that runs nested message loop in the renderer process.

BUG=23147
TEST=ui tests already cover nested message loops and plugins.  This particular scenario is hard to write a test case for because it's a race condition involving the browser.
Review URL: http://codereview.chromium.org/243018
------------------------------------------------------------------------
r27419 | senorblanco@chromium.org | 2009-09-29 00:11:12 +0200 (Tue, 29 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Reverting 27407.
Review URL: http://codereview.chromium.org/249027
------------------------------------------------------------------------
r27418 | jhawkins@chromium.org | 2009-09-28 23:47:04 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/download_types.h

Coverity: Initialize all member variables in the default constructor.

CID=1423
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/249024
------------------------------------------------------------------------
r27416 | jcampan@chromium.org | 2009-09-28 23:32:30 +0200 (Mon, 28 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/event_win.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_win.cc

Reverting 27412 it breaks the toolkit views Linux build.

TBR=sky
Review URL: http://codereview.chromium.org/254005
------------------------------------------------------------------------
r27413 | ben@chromium.org | 2009-09-28 23:19:53 +0200 (Mon, 28 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Change the way the NonClientView handles forcing the native frame for popups/app windows.

Rather than carrying state in a force_native_frame_ member it uses a virtual method AlwaysUseNativeFrame analogous to AlwaysUseCustomFrame. This makes me a little happier.

BUG=none
TEST=On a vista capable system, test that when a theme is installed, popups and app frames are rendered with the native frame. Test that constrained windows (e.g. HTTP basic auth) are rendered with the custom frame. Without a theme installed, test that all windows have a native frame except constrained windows. With Vista Basic system setting, verify that all windows have a custom frame, including constrained windows.

Review URL: http://codereview.chromium.org/200146
------------------------------------------------------------------------
r27412 | jcampan@chromium.org | 2009-09-28 23:18:58 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar_win.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/event_win.cc
   M /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_win.cc

Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_.
Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly.

BUG=None
TEST=Make sure short-cuts works as expected, especially in the omnibox.
Review URL: http://codereview.chromium.org/248010
------------------------------------------------------------------------
r27411 | jhawkins@chromium.org | 2009-09-28 23:18:32 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Coverity: Initialize ids_found_ in the constructor.

CID=4622
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242040
------------------------------------------------------------------------
r27409 | jhawkins@chromium.org | 2009-09-28 23:16:17 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_unittest.cc

Coverity: Remove two unused member variables.

CID=6087
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242039
------------------------------------------------------------------------
r27407 | ananta@chromium.org | 2009-09-28 23:13:08 +0200 (Mon, 28 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

If IE was navigated away to a different page when the ChromeFrame inspector window was open
it would crash the browser.

The fix is to ensure that the inspector window is closed when the ExternalTabContainer window
is uninitialized.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=22993

Bug=22993

Review URL: http://codereview.chromium.org/249005
------------------------------------------------------------------------
r27406 | finnur@chromium.org | 2009-09-28 23:09:56 +0200 (Mon, 28 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/browser_actions_container.cc
   M /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/common/extensions/extension_action.cc (from /trunk/src/chrome/common/page_action.cc:27363)
   A /trunk/src/chrome/common/extensions/extension_action.h (from /trunk/src/chrome/common/page_action.h:27363)
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   D /trunk/src/chrome/common/page_action.cc
   D /trunk/src/chrome/common/page_action.h

Moving ContextualAction class to common/extensions and in the process renaming it ExtensionAction.

No code change.

BUG=None
TEST=Page actions and browser actions should work as before (no change)

Review URL: http://codereview.chromium.org/242035
------------------------------------------------------------------------
r27405 | jrg@chromium.org | 2009-09-28 23:08:04 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/AboutIPC.xib
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   A /trunk/src/chrome/browser/cocoa/about_ipc_bridge.h
   A /trunk/src/chrome/browser/cocoa/about_ipc_bridge.mm
   A /trunk/src/chrome/browser/cocoa/about_ipc_controller.h
   A /trunk/src/chrome/browser/cocoa/about_ipc_controller.mm
   A /trunk/src/chrome/browser/cocoa/about_ipc_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/about_ipc_dialog.h
   A /trunk/src/chrome/browser/cocoa/about_ipc_dialog.mm
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/ipc/ipc_logging.h

Implement about:ipc dialog for Mac.

Convert IPC logging trigger from x-process waitable event to a messages
sent to all processes.

Review URL: http://codereview.chromium.org/192070
------------------------------------------------------------------------
r27403 | sky@chromium.org | 2009-09-28 22:56:49 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/painter.h

Adds the ability for script to resize the menu.

BUG=23261
TEST=none

Review URL: http://codereview.chromium.org/249020
------------------------------------------------------------------------
r27402 | jhawkins@chromium.org | 2009-09-28 22:55:26 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_types.h

Coverity: Initialize all of the member variables in the default constructor.

CID=1424
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/245029
------------------------------------------------------------------------
r27400 | gregoryd@google.com | 2009-09-28 22:45:32 +0200 (Mon, 28 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   D /trunk/src/chrome/browser/nacl_process_host.cc
   D /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/chrome/common/nacl_messages.h
   D /trunk/src/chrome/common/nacl_messages_internal.h
   D /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

Revert 27397 - First step towards NaClChrome integration:1. NaCl plugin becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324
Review URL: http://codereview.chromium.org/153002

TBR=gregoryd@google.com

Review URL: http://codereview.chromium.org/235042
------------------------------------------------------------------------
r27398 | sky@chromium.org | 2009-09-28 22:19:54 +0200 (Mon, 28 Sep 2009) | 9 lines
Changed paths:
   A /trunk/src/app/active_window_watcher_x.cc (from /trunk/src/chrome/browser/gtk/active_window_watcher.cc:27238)
   A /trunk/src/app/active_window_watcher_x.h (from /trunk/src/chrome/browser/gtk/active_window_watcher.h:27238)
   M /trunk/src/app/app.gyp
   D /trunk/src/chrome/browser/gtk/active_window_watcher.cc
   D /trunk/src/chrome/browser/gtk/active_window_watcher.h
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Pulls ActiveWindowWatcher into app so that we can use it in
views. Converts from using notification server to observer as
notification service is chrome only.
Also changes the pointer type used by window_gtk to be a left arrow.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/245016
------------------------------------------------------------------------
r27397 | gregoryd@google.com | 2009-09-28 22:17:30 +0200 (Mon, 28 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/browser/nacl_process_host.cc
   A /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/nacl_messages.h
   A /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324
Review URL: http://codereview.chromium.org/153002
------------------------------------------------------------------------
r27396 | jhawkins@chromium.org | 2009-09-28 21:52:41 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Coverity: Initialize profile_ and process_images_ in the constructor.

CID=3971
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/219014
------------------------------------------------------------------------
r27394 | thakis@chromium.org | 2009-09-28 21:47:07 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Add columns to gtk task manager.

BUG=16221
TEST=Open task man, right-click dialog, enable new columns (image size, script size, css size), surf around.

Review URL: http://codereview.chromium.org/245018
------------------------------------------------------------------------
r27393 | cira@chromium.org | 2009-09-28 21:38:49 +0200 (Mon, 28 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   D /trunk/src/chrome/browser/extensions/extension_message_bundle.cc
   D /trunk/src/chrome/browser/extensions/extension_message_bundle.h
   D /trunk/src/chrome/browser/extensions/extension_message_bundle_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/common/extensions/docs/static/i18n.html
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/common/extensions/extension_message_bundle.cc (from /trunk/src/chrome/browser/extensions/extension_message_bundle.cc:27238)
   A /trunk/src/chrome/common/extensions/extension_message_bundle.h (from /trunk/src/chrome/browser/extensions/extension_message_bundle.h:27238)
   A /trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc (from /trunk/src/chrome/browser/extensions/extension_message_bundle_unittest.cc:27238)
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/i18n/_locales
   A /trunk/src/chrome/test/data/extensions/api_test/i18n/_locales/en_US
   A /trunk/src/chrome/test/data/extensions/api_test/i18n/_locales/en_US/messages.json
   M /trunk/src/chrome/test/data/extensions/api_test/i18n/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/i18n/test.js
   A /trunk/src/chrome/test/data/extensions/samples/i18n/_locales
   A /trunk/src/chrome/test/data/extensions/samples/i18n/_locales/en_US
   A /trunk/src/chrome/test/data/extensions/samples/i18n/_locales/en_US/messages.json
   A /trunk/src/chrome/test/data/extensions/samples/i18n/_locales/sr
   A /trunk/src/chrome/test/data/extensions/samples/i18n/_locales/sr/messages.json
   M /trunk/src/chrome/test/data/extensions/samples/i18n/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/i18n/toolstrip.html

Implementing chrome.i18n.getMessage call, that loads message from the extension catalog, and if necessary replaces placeholders (up to 9).

I have 3 forms of getMessage call:

getMessage("name") for simple messages without placeholders.
getMessage("name", "one param") for messages with only one placeholder.
getMessage("name", ["one", "two"]) for messages with only one or more placeholders.

getMessage returns string.

BUG=12131
TEST=Load samples/i18n extension (switch Chrome to sr locale) and observe ext. name, description and toolstrip texts should be in Serbian.

Review URL: http://codereview.chromium.org/225009
------------------------------------------------------------------------
r27392 | jhawkins@chromium.org | 2009-09-28 21:34:43 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/user_data_manager.cc

Coverity: Initialize message_loop_ in the constructor.

CID=1505
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/219036
------------------------------------------------------------------------
r27391 | sky@chromium.org | 2009-09-28 21:33:24 +0200 (Mon, 28 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes regression in drop arrow. Specifically window properties were
being set after Init, which does no good.

BUG=23180
TEST=see bug

Review URL: http://codereview.chromium.org/251019
------------------------------------------------------------------------
r27390 | jhawkins@chromium.org | 2009-09-28 21:29:10 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc

Coverity: Initialize message_response_timeout_ in the constructor.

CID=1504
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223028
------------------------------------------------------------------------
r27389 | senorblanco@chromium.org | 2009-09-28 21:21:41 +0200 (Mon, 28 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/base/message_pump_glib_unittest.cc
   M /trunk/src/base/ref_counted.h
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/common/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

Reverting 27379, in hopes of fixing browser_tests.

TBR=darin

Review URL: http://codereview.chromium.org/248021
------------------------------------------------------------------------
r27388 | agl@chromium.org | 2009-09-28 21:20:17 +0200 (Mon, 28 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_memory_linux.html

Linux: add note to about:memoy re missing renderers.

On Linux, we cannot gets at the 'maps' nor 'smaps' files for our
renderers when they are sandboxed (because they are non-dumpable). One
could imaging plumbing IPC calls to the renderers for this
information, but it would be a lot of code for little gain. In the
mean time we should at least explain why all the renderers might be
missing.

(This is an issue with the SUID sandbox. The seccomp sandbox would be
ok.)

BUG=23258
http://codereview.chromium.org/235008

------------------------------------------------------------------------
r27379 | darin@chromium.org | 2009-09-28 20:12:55 +0200 (Mon, 28 Sep 2009) | 20 lines
Changed paths:
   M /trunk/src/base/message_pump_glib_unittest.cc
   M /trunk/src/base/ref_counted.h
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/common/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome_frame/chrome_frame_automation.cc
   M /trunk/src/chrome_frame/chrome_frame_delegate.h
   M /trunk/src/chrome_frame/test/chrome_frame_unittests.cc
   M /trunk/src/ipc/ipc_logging.cc
   M /trunk/src/ipc/ipc_sync_channel_unittest.cc
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

Assert that thread-safe reference counting is used with
cross-thread NewRunnableMethod.

This assertion caught such an error in VisitedLinkMaster!

My approach, modify RunnableMethodTraits<T> to assert that
when ReleaseCallee happens on a different thread from
RetainCallee that the type supports thread-safe reference
counting.  I do this by adding a static method to both
RefCounted<T> and RefCountedThreadSafe<T>.

This results in a little ugliness in cases where people
implement AddRef and Release by hand (to make the no-ops).
There may be a nicer way to deal with those few cases.

R=brettw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/251012
------------------------------------------------------------------------
r27378 | erg@chromium.org | 2009-09-28 20:10:23 +0200 (Mon, 28 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Mac: Sheets should be positioned between the content and everything above it.

BUG=17615

Review URL: http://codereview.chromium.org/219032
------------------------------------------------------------------------
r27375 | agl@chromium.org | 2009-09-28 20:03:55 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   D /trunk/src/base/scoped_fd.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Linux: remove --google-internal-crash-reporting.

It's time to kill this. It's been marginally useful, but only marginally.

http://codereview.chromium.org/222021

------------------------------------------------------------------------
r27371 | tim@chromium.org | 2009-09-28 19:18:35 +0200 (Mon, 28 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h

Added an accelerator to the HtmlDialogView class so that hitting the ESC key closes the dialog.

BUG=19786
TEST=Open Sync Bookmaeks Login dialog. Enter credentials, TAB between fields, etc. to ensure nothing is broken. Hit the ESC key to dismiss the dialog.

Patch by Randy Posynick (http://codereview.chromium.org/199069)

Review URL: http://codereview.chromium.org/246020
------------------------------------------------------------------------
r27368 | erg@google.com | 2009-09-28 18:54:09 +0200 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc

Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS.
GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors.

BUG=23031

Review URL: http://codereview.chromium.org/248006
------------------------------------------------------------------------
r27344 | tim@chromium.org | 2009-09-27 22:14:05 +0200 (Sun, 27 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc

Balance call to CommandLine::Init in syncapi with call to CommandLine::Terminate.
This should relieve the purify redness.

TBR=nick
TEST=ProfileSyncServiceTest, sync_unit_tests

Review URL: http://codereview.chromium.org/243023
------------------------------------------------------------------------
r27342 | nsylvain@chromium.org | 2009-09-27 21:50:54 +0200 (Sun, 27 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc

The comment above the ExtensionApiTest.Toolstrip says that it's
disabled because of flakyness, but it's not disabled, and it's
really flaky, so i'm disabling it for real.

BUG:22668

Review URL: http://codereview.chromium.org/242027
------------------------------------------------------------------------
r27341 | nsylvain@chromium.org | 2009-09-27 21:41:49 +0200 (Sun, 27 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Disable AutocompleteEditViewTest.AltEnter and AutocompleteEditViewTest.BrowserAccelerators
because they started failing all the time.

TBR:pkasting
BUG:23213

Review URL: http://codereview.chromium.org/246017
------------------------------------------------------------------------
r27331 | rsesek@chromium.org | 2009-09-27 00:47:11 +0200 (Sun, 27 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Update the TabContents::SavePage parameter to take FilePath instead of wstring to avoid conversions "To and From wstring".

BUG=None
TEST=run unit_tests.exe

Review URL: http://codereview.chromium.org/217008
Patch from tfarina.
------------------------------------------------------------------------
r27326 | gregoryd@google.com | 2009-09-26 12:53:26 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   D /trunk/src/chrome/browser/nacl_process_host.cc
   D /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/chrome/common/nacl_messages.h
   D /trunk/src/chrome/common/nacl_messages_internal.h
   D /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

Revert 27324 - First step towards NaClChrome integration:1. NaCl plugin becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002

TBR=bradnelson@google.com

Review URL: http://codereview.chromium.org/244017
------------------------------------------------------------------------
r27324 | gregoryd@google.com | 2009-09-26 11:47:54 +0200 (Sat, 26 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/browser/nacl_process_host.cc
   A /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/nacl_messages.h
   A /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/nacl/DEPS
   M /trunk/src/chrome/nacl/nacl_main.cc
   M /trunk/src/chrome/nacl/nacl_thread.cc
   M /trunk/src/chrome/nacl/nacl_thread.h
   M /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002
------------------------------------------------------------------------
r27323 | abarth@chromium.org | 2009-09-26 10:30:59 +0200 (Sat, 26 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Update our mixed content state with information from the new mixed content
APIs.  This change is purely additive.  I'll rip out the old mechanism in the
next patch.

R=agl

Review URL: http://codereview.chromium.org/243012
------------------------------------------------------------------------
r27319 | finnur@chromium.org | 2009-09-26 05:18:46 +0200 (Sat, 26 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/browser/views/browser_actions_container.cc
   A /trunk/src/chrome/browser/views/browser_actions_container.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/page_action.cc
   M /trunk/src/chrome/common/page_action.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/samples/print_browser_action
   A /trunk/src/chrome/test/data/extensions/samples/print_browser_action/background.html
   A /trunk/src/chrome/test/data/extensions/samples/print_browser_action/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/print_browser_action/print_16x16.png

Implement Browser Actions extensions.

Browser Actions are like Page Actions, except they appear next to the Omnibox and are always visible. For details see http://code.google.com/p/chromium/wiki/BrowserActions.

Added a simple browser action sample that adds a Print button to the chrome toolbar (which brings up the Print dialog for the current page).

Removed |type| from PageActions, which is currently ignored and was already removed from the docs.

Each extension can only have 1 browser_action. Each browser action can specify more than one icon, but only the first is used. And no API has been added yet (besides the event definition).

BUG=22099
TEST=Install the sample browser action, navigate to google.com, press the print button. A print dialog should come up.
Review URL: http://codereview.chromium.org/243001
------------------------------------------------------------------------
r27317 | gregoryd@google.com | 2009-09-26 04:22:17 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   D /trunk/src/chrome/browser/nacl_process_host.cc
   D /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/chrome/common/nacl_messages.h
   D /trunk/src/chrome/common/nacl_messages_internal.h
   D /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

Revert 27315 - First step towards NaClChrome integration:1. NaCl plugin becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002

TBR=gregoryd@google.com

Review URL: http://codereview.chromium.org/244014
------------------------------------------------------------------------
r27316 | nick@chromium.org | 2009-09-26 03:27:23 +0200 (Sat, 26 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc
   M /trunk/src/third_party/libjingle/README.chromium
   M /trunk/src/third_party/libjingle/files/talk/base/logging.h
   M /trunk/src/third_party/libjingle/libjingle.gyp

Use base/logging from chrome/browser/sync. Add a macro to libjingle's
logging.h to suppress the definition of LOG() and friends unless
explicitly requested. Fix gyp paths to overrides files.

Review URL: http://codereview.chromium.org/225001
------------------------------------------------------------------------
r27315 | gregoryd@google.com | 2009-09-26 03:22:10 +0200 (Sat, 26 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/browser/nacl_process_host.cc
   A /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/nacl_messages.h
   A /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   A /trunk/src/chrome/nacl
   A /trunk/src/chrome/nacl/DEPS
   A /trunk/src/chrome/nacl/nacl_main.cc
   A /trunk/src/chrome/nacl/nacl_thread.cc
   A /trunk/src/chrome/nacl/nacl_thread.h
   A /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002
------------------------------------------------------------------------
r27312 | mhm@chromium.org | 2009-09-26 03:13:00 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Remove the context menu item 'Remove from shelf' from download shelf

BUG=23078
TEST=No more menu item on download item

Review URL: http://codereview.chromium.org/246004
------------------------------------------------------------------------
r27306 | sky@chromium.org | 2009-09-26 02:56:00 +0200 (Sat, 26 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes regression introduced by fixing bookmark bar. We need to process
INVALIDATE_LOAD both synchronously and asynchronously.

BUG=none
TEST=make sure you see status bubble saying loading.

Review URL: http://codereview.chromium.org/235028
------------------------------------------------------------------------
r27300 | thakis@chromium.org | 2009-09-26 02:10:19 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

Remove "remove" from download item context menu on mac.

BUG=23078
TEST=Download something. Menu should no longer contain "Remove".

Review URL: http://codereview.chromium.org/249008
------------------------------------------------------------------------
r27297 | tony@chromium.org | 2009-09-26 01:56:18 +0200 (Sat, 26 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc

Fix a bug where we get an extra resize event for background tabs.

The TabContentsContainerGtk is a GtkFixed that contains a
TabContentsViewGtk for each tab.  We hide the background TCVG
and only show the foreground TCVG.  However, when the TCCG
gets a resize event, we were still sending a set_size_request
to all the background tabs.  Since they were hidden, nothing
happened except in the case described in issue 14114.  It
seems like this is a spurious resize by gtk, but not sending
the resize request seems to work around it.

BUG=14114
TEST=see bug

Review URL: http://codereview.chromium.org/246012
------------------------------------------------------------------------
r27293 | evan@chromium.org | 2009-09-26 01:44:34 +0200 (Sat, 26 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.h

linux: ifdef out Upgrade class to verify we're not using it

This works because I removed all usage of it in a previous change.

BUG=9295

Review URL: http://codereview.chromium.org/248009
------------------------------------------------------------------------
r27290 | sidchat@chromium.org | 2009-09-26 01:40:55 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Part 3 of 'Polish dragging of ToolStrips': Restrict the horizontal and vertical motions of the toolstrips so that they cannot be dragged out of the extension shelf.

BUG=www.crbug.com/18443
TEST=none

Review URL: http://codereview.chromium.org/251004
------------------------------------------------------------------------
r27285 | evan@chromium.org | 2009-09-26 01:21:56 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

linux: add mutter to window frame whitelist

BUG=20381,23109
TEST=it compiles

Review URL: http://codereview.chromium.org/235029
------------------------------------------------------------------------
r27284 | jcampan@chromium.org | 2009-09-26 01:15:41 +0200 (Sat, 26 Sep 2009) | 23 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/keyboard_code_conversion_gtk.cc
   A /trunk/src/base/keyboard_code_conversion_gtk.h
   M /trunk/src/base/keyboard_codes.h
   D /trunk/src/base/keyboard_codes_linux.h
   D /trunk/src/base/keyboard_codes_mac.h
   A /trunk/src/base/keyboard_codes_posix.h (from /trunk/src/base/keyboard_codes_mac.h:27238)
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.cc
   M /trunk/src/chrome/browser/views/accelerator_table_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/focus/accelerator_handler_gtk.cc
   M /trunk/src/views/widget/widget_gtk.cc

[Relanding erg's change with fix for toolkit_views shortcuts and 
interactive ui tests. Note that this was originally reviewed in
http://codereview.chromium.org/217022/show I originally Elliot
suggestion of replacing the usage of int for keycode with the
bae::Keycode type, but that led to the CL getting out of hands
(as this is used in many different places). So this is only the
patch set 1 of that CL, I'll replace the type in another CL] 

Use windows keycodes under linux (and all non-windows platforms). 

This fixes any place where we use a VKEY_* (RenderWidgetHost, for example) 
under Linux, but breaks accelerators in TOOLKIT_VIEWS which relied on this 
wrong behaviour. 

Previously, keyboard_codes_linux defined all the VKEY_* constants as their 
GDK_* counterparts, which is wrong since the VKEY_* are supposed to resolve 
to windows key codes. 

BUG=22551
TEST=Make sure accelerators still work as expected on Chrome Linux and 
Chrome Linux with toolkit views. Test when the the accelerators with 
the focus in the location bar and also with the focus on the page.
Review URL: http://codereview.chromium.org/235025
------------------------------------------------------------------------
r27283 | nick@chromium.org | 2009-09-26 01:14:06 +0200 (Sat, 26 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.cc
   M /trunk/src/third_party/libjingle/README.chromium
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/p2ptransport.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/rawtransport.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/rawtransportchannel.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/session.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/sessionmanager.cc
   M /trunk/src/third_party/libjingle/files/talk/p2p/base/transport.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/constants.cc
   D /trunk/src/third_party/libjingle/files/talk/xmpp/constants.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/jid.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/saslcookiemechanism.h
   M /trunk/src/third_party/libjingle/files/talk/xmpp/saslmechanism.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppclient.cc
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.cc (from /trunk/src/third_party/libjingle/files/talk/xmpp/constants.cc:27280)
   A /trunk/src/third_party/libjingle/files/talk/xmpp/xmppconstants.h (from /trunk/src/third_party/libjingle/files/talk/xmpp/constants.h:27280)
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppengineimpl_iq.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmpplogintask.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmppstanzaparser.cc
   M /trunk/src/third_party/libjingle/files/talk/xmpp/xmpptask.cc
   M /trunk/src/third_party/libjingle/libjingle.gyp

Rename "xmpp/constants.*" to" xmpp/xmppconstants.*"

The intent is to fix a link error that seems to happen when two
compilation units share a filename: there is another constants.cc in
p2p/base. Touch xmppconstants.h to work around a git cl upload bug.

Review URL: http://codereview.chromium.org/244010
------------------------------------------------------------------------
r27281 | tim@chromium.org | 2009-09-26 01:09:36 +0200 (Sat, 26 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.cc (from /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.cc:27123)
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.h (from /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.h:27123)
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc (from /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc:27123)
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.h (from /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.h:27123)
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Second attempt at the new syncer thread impl, now with less crashes!
Previous one at http://codereview.chromium.org/214033.

I had local edits that resulted in initializing the CommandLine for syncapi,
but didn't have them as part of the patch, so this was causing a crash whenever
SyncerThreadFactory::Create was called.  The only diff here is the call to
CommandLine::Init in syncapi.cc.  This effectively means you can't change the
syncer thread impl on linux (we init an empty command line there), but this is
OK.  Once we link statically we won't need to do this.

TEST=ProfileSyncServiceTest, SyncerThreadTest, SyncerThreadWithSyncerTest

Review URL: http://codereview.chromium.org/250001
------------------------------------------------------------------------
r27277 | rafaelw@chromium.org | 2009-09-26 01:04:40 +0200 (Sat, 26 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc

Enable ExtensionApiTest.Toolstrip

Need debug output from http://codereview.chromium.org/242012

BUG=22668

Review URL: http://codereview.chromium.org/246011
------------------------------------------------------------------------
r27276 | rafaelw@chromium.org | 2009-09-26 01:00:14 +0200 (Sat, 26 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Add LOG(INFO) debug output to help track down extension browsertest flakiness

BUG=22668

Review URL: http://codereview.chromium.org/242012
------------------------------------------------------------------------
r27275 | agl@chromium.org | 2009-09-26 00:57:42 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_memory_linux.html

Linux: remove --google-internal-crash-reporting.

It's time to kill this. It's been marginally useful, but only marginally.

http://codereview.chromium.org/222021

------------------------------------------------------------------------
r27270 | jamesr@chromium.org | 2009-09-26 00:43:35 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm

Enables WebCache columns on OS X's task manager.

TEST=Enabled the Task Manager context menu, opened, enabled columns and observed values that look reasonable.
BUG=16221

Review URL: http://codereview.chromium.org/243006
------------------------------------------------------------------------
r27269 | chocobo@google.com | 2009-09-26 00:39:23 +0200 (Sat, 26 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/statusbar_disconnected.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_1.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_2.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_3.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_4.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_5.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_6.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_7.png
   A /trunk/src/chrome/app/theme/statusbar_wifi_8.png
   A /trunk/src/chrome/app/theme/statusbar_wired.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/chromeos/network_menu_button.cc
   A /trunk/src/chrome/browser/chromeos/network_menu_button.h
   A /trunk/src/chrome/browser/chromeos/password_dialog_view.cc
   A /trunk/src/chrome/browser/chromeos/password_dialog_view.h
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome.gyp

Add wifi menu button to status bar of Chrome OS. Currently showing mock data as we have not hooked it up to ChromeOS shared library wifi code yet.
TEST=none
BUG=23090
Review URL: http://codereview.chromium.org/231014
------------------------------------------------------------------------
r27266 | thestig@chromium.org | 2009-09-26 00:36:23 +0200 (Sat, 26 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/common/chrome_paths.cc

Create the download folder if it doesn't exist. That is, the actual download folder, not the default one.

BUG=21759
TEST=none
Review URL: http://codereview.chromium.org/219017
------------------------------------------------------------------------
r27265 | erikkay@chromium.org | 2009-09-26 00:31:24 +0200 (Sat, 26 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc

TBR: rafaelw,leiz
disable a ExtensionApiTest.Toolstrip which is flaky on linux
------------------------------------------------------------------------
r27264 | thestig@chromium.org | 2009-09-26 00:19:33 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Disable TestOverrideEncoding test. It's been hanging the XP Tests (dbg)(3) ui_test all day.

BUG=23121
TEST=none
TBR=jnd
Review URL: http://codereview.chromium.org/252007
------------------------------------------------------------------------
r27263 | davemoore@chromium.org | 2009-09-26 00:19:13 +0200 (Sat, 26 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

A change to make popups work correctly in the GTK build broke
Chrome OS panels...this fixes them.
Review URL: http://codereview.chromium.org/242011
------------------------------------------------------------------------
r27262 | aa@chromium.org | 2009-09-26 00:12:38 +0200 (Sat, 26 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Make extension installation work when the "ask for destination
of every download" preference is set.

BUG=23011
TEST=Set the preference in question, install an extension. You should not get a save as dialog and it should install correctly.

Review URL: http://codereview.chromium.org/252005
------------------------------------------------------------------------
r27261 | aa@chromium.org | 2009-09-26 00:02:49 +0200 (Sat, 26 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   A /trunk/src/chrome/test/data/extensions/bad_underscore.crx

Actually run directory validation code on install.

BUG=23084
TEST=Install extensions attached to referenced bug. You should get an error dialog, not a crash.

Review URL: http://codereview.chromium.org/244012
------------------------------------------------------------------------
r27260 | evan@chromium.org | 2009-09-25 23:58:22 +0200 (Fri, 25 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp

linux: port some of the download manager unit test

Mostly lots of #ifdefs tracking platform behaviors.
I tried to make the logic correct for Mac, too, but I didn't enable
Mac here.

BUG=21632

Review URL: http://codereview.chromium.org/220025
------------------------------------------------------------------------
r27258 | aa@chromium.org | 2009-09-25 23:50:56 +0200 (Fri, 25 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/renderer/resources/extension_toolstrip.css

Make --show-extensions-on-top look exactly, pixel-for-pixel
identical to the bookmark bar.

Used the same semi-transparent image for the button background
that the bookmarkbar uses, so that it will work for themes.

The upside of this is that we look the same as the bookmark bar. The downside is that we look the same as the bookmark bar (which currently looks pretty bad with some themes).

However, with the default theme, I think that the bookmark bar currently looks better than our toolstrips. The UI team should probably create some images that look good with different themes for the bookmark bar, then we can update this again.

Review URL: http://codereview.chromium.org/225025
------------------------------------------------------------------------
r27256 | mdm@chromium.org | 2009-09-25 23:48:59 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: stop the window reconfigure debounce timer when a window is closed.
BUG=23085
TEST=none

Review URL: http://codereview.chromium.org/245010
------------------------------------------------------------------------
r27253 | pkasting@chromium.org | 2009-09-25 23:35:58 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/common/url_constants.h

Re-ban chrome:// URLs from being added to history until I can craft a more fine-grained solution.

BUG=23076
TEST=Hit ctrl-t, then ctrl-h, and verify you didn't just add "New Tab" to your history.
Review URL: http://codereview.chromium.org/248005
------------------------------------------------------------------------
r27252 | evan@chromium.org | 2009-09-25 23:33:52 +0200 (Fri, 25 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_paths.cc

Refuse to start if we can't get the user data directory.

The alternative is spewing private user data in random directories.

BUG=22277
TEST=chmod -x ~/.config; Chrome should refuse to start

Review URL: http://codereview.chromium.org/219043
------------------------------------------------------------------------
r27251 | erg@google.com | 2009-09-25 23:32:34 +0200 (Fri, 25 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   A /trunk/src/chrome/browser/gtk/bookmark_bar_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   A /trunk/src/chrome/browser/gtk/tabstrip_origin_provider.h
   M /trunk/src/chrome/chrome.gyp

GTK: Add three simple unit tests to the bookmark bar.

Review URL: http://codereview.chromium.org/249004
------------------------------------------------------------------------
r27249 | abarth@chromium.org | 2009-09-25 23:08:29 +0200 (Fri, 25 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Plumb the new mixed content API callbacks to the tab contents.  We'll actually
use these notifications in a future patch.

No behavior change.

R=agl

Review URL: http://codereview.chromium.org/241004
------------------------------------------------------------------------
r27248 | shess@chromium.org | 2009-09-25 23:05:26 +0200 (Fri, 25 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

[Mac] Fix depressed baseline in Omnibox.

A previous change converted AutocompleteTextFieldCell to rely more on
-drawingRectForBounds: rather than tweaking the baseline in an ad-hoc
fashion in many places.  This adds a place I missed.

http://crbug.com/23096
TEST=Browse to www.google.com.  When putting focus in the page the
url should stay at the same spot as when focus is in the Omnibox.

Review URL: http://codereview.chromium.org/242010
------------------------------------------------------------------------
r27247 | mdm@chromium.org | 2009-09-25 23:04:34 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Linux: work around browser windows that get stuck maximized by the WM.
BUG=22807
TEST=none

Review URL: http://codereview.chromium.org/218040
------------------------------------------------------------------------
r27243 | davemoore@chromium.org | 2009-09-25 22:53:27 +0200 (Fri, 25 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

The shadow drawn by the browser window was being drawn over by
the status area view.
Review URL: http://codereview.chromium.org/249002
------------------------------------------------------------------------
r27242 | thomasvl@chromium.org | 2009-09-25 22:52:49 +0200 (Fri, 25 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/chrome.gyp

L10N pass through download item and download shelf.
  - l10n the menus
  - l10n the dangerous item buttons
  - make view auto size for the dangerous item buttons

TEST=download shelf item buttons and menus are localized
BUG=20529
BUG=20530
Review URL: http://codereview.chromium.org/245009
------------------------------------------------------------------------
r27240 | jeremy@chromium.org | 2009-09-25 22:47:58 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_mac.mm
   D /trunk/src/chrome/browser/first_run_migration_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Remove old Mac First Run Migration code.

We've gone through 2 dev release cycles so most users should be upgraded by now,
removing code.

Review URL: http://codereview.chromium.org/244011
------------------------------------------------------------------------
r27238 | tony@chromium.org | 2009-09-25 22:11:21 +0200 (Fri, 25 Sep 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Remove an unnecessary vbox from the widget hierarchy.

Previously, it was:

vbox (window_vbox)
..eventbox
..vbox (content_vbox_)
....eventbox
....eventbox
....eventbox
....eventbox

I removed content_vbox_ and just put everything into the window vbox.  There
was no padding, so it's pretty straight forward.  Some points for drawing
the custom frame border were taken relative to content_vbox_, so those
points are adjusted.

Review URL: http://codereview.chromium.org/239007
------------------------------------------------------------------------
r27237 | estade@chromium.org | 2009-09-25 22:09:49 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Hook up external protocol handler to user gestures to prevent malicious sites from popping up a lot of dialogs (or in the case of whitelisted protocols, launching a lot of programs).

BUG=3628
TEST=test.html from crbug.com/21049

Review URL: http://codereview.chromium.org/240002
------------------------------------------------------------------------
r27234 | evan@chromium.org | 2009-09-25 22:07:04 +0200 (Fri, 25 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc

posix: fix a bug estade found in the review but I misunderstood his comment

We still need the "break;" to happen on all platforms.
------------------------------------------------------------------------
r27233 | thakis@chromium.org | 2009-09-25 22:04:34 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Remove "Remove" from download item context menu on linux.

BUG=23078
TEST=Download something, open item's context menu. "Remove from list" should no longer be in there.

Review URL: http://codereview.chromium.org/246006
------------------------------------------------------------------------
r27232 | estade@chromium.org | 2009-09-25 22:04:25 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc

Cut down on flakiness of automated ui tests by changing message sending/waiting logic.

BUG=none
TEST=a lot less flaky on linux

Review URL: http://codereview.chromium.org/235019
------------------------------------------------------------------------
r27231 | estade@chromium.org | 2009-09-25 22:04:03 +0200 (Fri, 25 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/incognito_tab.html

Invert the new incognito tab Spyman orientation and location for RTL.

Also, make the in-page spy man face the text. Thus he will face the opposite direction of the titlebar spy guy.

BUG=22872
BUG=22935

Review URL: http://codereview.chromium.org/238005
------------------------------------------------------------------------
r27230 | sky@chromium.org | 2009-09-25 22:00:08 +0200 (Fri, 25 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Reenables BookmarkHTMLWriterTest.  I couldn't repro a failure on my
machine after running the test all night, so I'm reenabling the test
and making the output more humany readable so that if it does fail
hopefully we can figure out where it's going wrong.

BUG=17592
TEST=this is only a test change

Review URL: http://codereview.chromium.org/244007
------------------------------------------------------------------------
r27228 | sky@chromium.org | 2009-09-25 21:58:40 +0200 (Fri, 25 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Minor cleanup. Converts Browser from storing a vector of pending
updates to a map. This simplifies processing and removal.

BUG=1209369
TEST=none

Review URL: http://codereview.chromium.org/250003
------------------------------------------------------------------------
r27227 | mark@chromium.org | 2009-09-25 21:56:12 +0200 (Fri, 25 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h

Use delegates in AutocompleteEditViewMac and do other stuff to get it to build
with the 10.6 SDK.
Review URL: http://codereview.chromium.org/244009
------------------------------------------------------------------------
r27222 | jeremy@chromium.org | 2009-09-25 20:19:39 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h

Misc. Cleanup related to OOP Profile Import

* Add PROFILE_IMPORT_PROCESS type to ChildProfileInfo.
* Other small bits of cleanup.

Review URL: http://codereview.chromium.org/220027
------------------------------------------------------------------------
r27220 | shess@chromium.org | 2009-09-25 20:15:51 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h

Comment changes from post-LGTM comments on 219031.

TBR=rohitrao@chromium.org

Review URL: http://codereview.chromium.org/246003
------------------------------------------------------------------------
r27218 | sky@chromium.org | 2009-09-25 20:09:37 +0200 (Fri, 25 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Makes it so that you shouldn't be able to get a big fat bookmark
bar. This happened because when we changed from needing a
bookmarkbar/extension-shelf to not needing one we processed the layout
change asynchronously, but could paint immediately and painting always
checks the current state. I initially made painting/layout stay in
sync with regards to whether they thought the bookmark bar should be
shown, which also fixes this, but because we process the change async
there was still some noticable jank. Instead I've changed processing
of the transition from needing bars to not (or vice-versa) to be
synchronous.

BUG=22165
TEST=see bug

Review URL: http://codereview.chromium.org/219034
------------------------------------------------------------------------
r27217 | shess@chromium.org | 2009-09-25 20:07:24 +0200 (Fri, 25 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Manually reposition Omnibox field editor rather than using focus machinery.

Previously this code abused the Cocoa focus machinery to move the
field editor around when needed, which required the code to mess
around with delegation to make sure the changes didn't leak out to the
core autocomplete code.  Unfortunately, it also messes with other
features, like undo.  This change does the positioning manually, which
should let everything just work.

TEST=Tab-to-search and keyword hints shouldn't cause the field to break.

Review URL: http://codereview.chromium.org/219031
------------------------------------------------------------------------
r27216 | jamesr@chromium.org | 2009-09-25 19:59:03 +0200 (Fri, 25 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Adds three new off-by-default columns to the task manager to track WebCore caches

These values are currently exposed via about:histograms/WebCoreCache. This change allows for users to monitor the cache sizes in real-time broken out by renderer.

TEST=Open task manager, right click on chrome, select columns, observe that they update along with browsing.
BUG=16221

Review URL: http://codereview.chromium.org/217010
------------------------------------------------------------------------
r27215 | jhawkins@chromium.org | 2009-09-25 19:57:09 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc

Coverity: Initialize file_loop_ and io_loop_ in the constructor.

CID=1405
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/245004
------------------------------------------------------------------------
r27213 | rafaelw@chromium.org | 2009-09-25 19:45:16 +0200 (Fri, 25 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/test/data/extensions/api_test/override1/test.js

ExtensionApiTest improvements.

This fixes a race condition where ExtensionBrowserTest::WaitForExtensionHostsToLoad() could have exited before all hosts were loaded. It simplifies the Overrides test. It also adds some debug output for aiding the hunt for remaining flakiness.

BUG=22668

Review URL: http://codereview.chromium.org/220039
------------------------------------------------------------------------
r27212 | nick@chromium.org | 2009-09-25 19:38:11 +0200 (Fri, 25 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/base/posix/time_posix.cc
   D /trunk/src/chrome/browser/sync/notifier/base/string.cc
   D /trunk/src/chrome/browser/sync/notifier/base/string.h
   D /trunk/src/chrome/browser/sync/notifier/base/string_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/base/time.cc
   M /trunk/src/chrome/browser/sync/notifier/base/time.h
   M /trunk/src/chrome/browser/sync/notifier/base/time_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/base/win/time_win32.cc
   D /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers-inl.h
   D /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers.cc
   D /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers.h
   M /trunk/src/chrome/chrome.gyp

Remove string.h/.cc, xml_parse_helpers.h/.cc, and date- parsing code
from notifier/base.  These were unused.

Review URL: http://codereview.chromium.org/219006
------------------------------------------------------------------------
r27203 | jhawkins@chromium.org | 2009-09-25 19:23:32 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/possible_url_model.cc

Coverity: Initialize observer_ in the constructor.

CID=1483
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/219039
------------------------------------------------------------------------
r27202 | jhawkins@chromium.org | 2009-09-25 19:22:23 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

Coverity: Initialize read_buffer_size_ in the constructor.

CID=1422
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/224021
------------------------------------------------------------------------
r27201 | tony@chromium.org | 2009-09-25 19:21:04 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc

Fix chromeos

TBR=brettw

Review URL: http://codereview.chromium.org/242007
------------------------------------------------------------------------
r27200 | jeremy@chromium.org | 2009-09-25 19:13:41 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FirstRunDialog.xib
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm

OS X First run dialog: hide import option of nothing to import from.

* Modify the Mac First Run dialog so that if the system in question doesn't have any browser profiles to import from, we don't display the option.
* Modify SafariImporter to only be enabled if the current user's account actually has a profile attached to it.

Review URL: http://codereview.chromium.org/218039
------------------------------------------------------------------------
r27199 | tony@chromium.org | 2009-09-25 19:07:23 +0200 (Fri, 25 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h

Allow the initial size of TabContentViews to be based on the
size of another TabContents by having an optional TabContents*
passed into the TabContents ctor.

This fixes a race condition where it's possible for a web
page to load before getting the sizing information from the
browser.  The new flow passes the size information to the
renderer process before passing the URL to load.

BUG=20159

Review URL: http://codereview.chromium.org/201130
------------------------------------------------------------------------
r27196 | pkasting@chromium.org | 2009-09-25 18:49:26 +0200 (Fri, 25 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/views/background.cc
   M /trunk/src/views/background.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h

Use the system WINDOWTEXT color for labels, instead of black.  Also use the system WINDOW color for InfoBubbles, not white.  Several places are made to explicitly use black labels where that's correct or respecting system colors is a non-trivial fix (bugs filed for most).

Also, apparently I didn't get all my cleanup changes in the last patch, oops.

BUG=92,21027
TEST=Set theme to high-contrast black on white, check that most pieces of chrome UI have readable text
Review URL: http://codereview.chromium.org/237005
------------------------------------------------------------------------
r27195 | tony@chromium.org | 2009-09-25 18:47:38 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Calculate whiteout duration on linux (the time we draw green
or white because of no backing store).  This is mainly just
a copy of the Windows code (mac has it too).

Review URL: http://codereview.chromium.org/220043
------------------------------------------------------------------------
r27194 | phajdan.jr@chromium.org | 2009-09-25 18:21:57 +0200 (Fri, 25 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc

Improve desktop shortcut creation:

- remove more comments (which generally only apply to the browser itself)
- add #!/usr/bin/env xdg-open shebang
- make the .desktop file placed on the desktop executable
- add more tests to make sure we're still secure

TEST=Covered by unit_tests.
BUG=22589

Review URL: http://codereview.chromium.org/232003
------------------------------------------------------------------------
r27192 | dglazkov@chromium.org | 2009-09-25 18:09:05 +0200 (Fri, 25 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Re-enable UnloadTest.BrowserCloseBeforeUnload* tests now that they are passing again.

The http://trac.webkit.org/changeset/48732 fixed it.

TBR=senorblanco
TEST=none
BUG=22696

Review URL: http://codereview.chromium.org/242006
------------------------------------------------------------------------
r27186 | sky@chromium.org | 2009-09-25 17:15:04 +0200 (Fri, 25 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Lands http://codereview.chromium.org/214030 for Thiago:

Avoids the unnecessary conversion to wstring when calling the WriteBookmarks function, using FilePath instead.

BUG=None
TEST=run unit_tests.exe

Review URL: http://codereview.chromium.org/239002
------------------------------------------------------------------------
r27185 | thakis@chromium.org | 2009-09-25 17:12:02 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Fix color of download item text in incognito window.

BUG=22664
TEST=Open incognito window, download something. The download item should contain readable text.

Review URL: http://codereview.chromium.org/235018
------------------------------------------------------------------------
r27179 | sky@chromium.org | 2009-09-25 15:40:00 +0200 (Fri, 25 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Changes the main menu to do the following:
. Creates a TabContents in CreateNewWindow rather than a
  RenderViewHost. We want to support the ability to open popups from
  this menu, so going with TabContents directly seemed the best
  option.
. Showing the menu now does a keyboard grab. This is needed so that
  keyboard events go to the menu and focus doesn't remain whever it
  was when the menu was shown.

BUG=22954
TEST=see bug

Review URL: http://codereview.chromium.org/219037
------------------------------------------------------------------------
r27174 | hbono@chromium.org | 2009-09-25 07:40:48 +0200 (Fri, 25 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

A follow-up change for r26694.
This change is a follow-up change for r26694 that I wasn't able to review. Nevertheless, this change includes only style nits.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/234003
------------------------------------------------------------------------
r27172 | tyoshino@google.com | 2009-09-25 07:04:57 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Use URL constants instead of writing string literals in test using history page address.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/200142
------------------------------------------------------------------------
r27169 | darin@chromium.org | 2009-09-25 06:23:56 +0200 (Fri, 25 Sep 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Implemented upload progress indicator in status bar.

When sending an HTTP POST request with sufficiently large payload data (such as
uploading a file or several), the status bar should display the progress in the
form of a percentage. The ResourceDispatcherHost periodically sends upload
progress messages to the UI thread as well as to the renderer. If an upload is
occurring, other potential LoadStateChanged messages to the same RenderViewHost
are ignored; this prevents the upload progress display from being interrupted
periodically by "Waiting for <site>" messages. 

Original code review:
http://codereview.chromium.org/211050

Original patch by Simon Radford
r=darin
BUG=4715
TEST=Try uploading one or more files (e.g. at a file hosting site) and confirm
that the percentage is shown in the status bar. 

Review URL: http://codereview.chromium.org/244001
------------------------------------------------------------------------
r27168 | mattm@chromium.org | 2009-09-25 05:18:26 +0200 (Fri, 25 Sep 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/data/purify/unit_tests.exe.gtest.txt
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Removing valgrind suppressions that have not triggered in the last 100 runs.  (Doesn't cover suppressions_mac.txt)

Some suppressions didn't trigger because the test was disabled.  It is assumed that before re-enabling such a test someone would fix it and check that it doesn't still need any suppressions:
BUG=6522
BUG=11838

Not reproducible, bug is already closed:
BUG=10750
BUG=11117
BUG=12539,12549,12661

Not reproducible (or not enough info to try):
BUG=4609
BUG=16103
BUG=16129 (probably fixed by r20100)
BUG=16578
BUG=16584
BUG=16586
BUG=16625
BUG=16908
BUG=18654
BUG=19385
BUG=19490

Review URL: http://codereview.chromium.org/219021
------------------------------------------------------------------------
r27167 | estade@chromium.org | 2009-09-25 04:57:16 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc

Fix gcc warning in chrome os compile.

TBR=jungshik

Review URL: http://codereview.chromium.org/242001
------------------------------------------------------------------------
r27166 | estade@chromium.org | 2009-09-25 04:36:38 +0200 (Fri, 25 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc

GTK: First cut at tab dragging automation.

Also make tab dragging slightly more robust.

I tried really hard to avoid hackiness, but after many hours of wrestling with gtk and X, this is the best I could do. The main point of contention is that GTK (and our tab dragging code in particular) seems to be able to get X into a state where gdk_display_warp_pointer() doesn't send back any events (although it does move the X pointer). I tried to fix our code directly, but decided it was GTK that was broken. So I faked some mouse motion events to prod the tab dragging into working. This approach does not appear to be flaky, and is actually closer to the event stream that occurs when a user drags a tab than the obvious approach would be. (The tests themselves are somewhat flaky, but only due to WaitForURLDisplayedForTab() flakiness, which is a separate issue I'll look at later. The tests aren't on any buildbot for now so I'd like to leave them enabled.)

BUG=22182
TEST=--gtest_filter=AutomatedUITest.Drag*

Review URL: http://codereview.chromium.org/218017
------------------------------------------------------------------------
r27165 | estade@chromium.org | 2009-09-25 04:35:30 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Fix overflow chevron for RTL locales.

BUG=22872

Review URL: http://codereview.chromium.org/218037
------------------------------------------------------------------------
r27164 | evan@chromium.org | 2009-09-25 03:36:34 +0200 (Fri, 25 Sep 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc

linux: unittest fix
------------------------------------------------------------------------
r27161 | evan@chromium.org | 2009-09-25 03:27:31 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

linux: drop temp_scaffolding_stubs

It was mostly unneeded, but I had to excise the last bits of RLZ and move
some NOTIMPLEMENTED bits to where they belong.

Review URL: http://codereview.chromium.org/219042
------------------------------------------------------------------------
r27152 | tony@chromium.org | 2009-09-25 02:18:15 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Convert the BrowerThemeProvider pointer from being ref counted to
not being ref counted.  It's owned by the profile and it doesn't
need to be ref counted.

Review URL: http://codereview.chromium.org/223027
------------------------------------------------------------------------
r27151 | pkasting@chromium.org | 2009-09-25 02:07:31 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/controls/textfield/textfield.h

Clean up a few bits of files that I'm about to modify.  The only visible change is the removal of some extra spacing Ben erroneously added to the link infobar a while back (clients already do their own spacing as needed, so this just added extra whitespace in mid-sentence).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223029
------------------------------------------------------------------------
r27147 | phajdan.jr@chromium.org | 2009-09-25 01:56:03 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc

Wait for the history backend to load, which makes AutocompleteBrowserTest.Autocomplete not flaky.

TEST=Covered by browser_tests.
BUG=19876

Review URL: http://codereview.chromium.org/218038
------------------------------------------------------------------------
r27145 | mhm@chromium.org | 2009-09-25 01:53:48 +0200 (Fri, 25 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/custom_button.h

Fix hottracking on button views.The hottracking on the toolbar was broken, the expected behavoir is when focus is set to the toolbar (by hitting SHIFT+ALT+T) and toolbar buttons are traversed by right/left arrow keys, a bevel should appear on the button (HOT Image).

This patch fixes the initial hottracking issue where the first item is not hottracked.

BUG=10942
TEST=ALT+SHIFT+T and traverse with arrow keys, observe hot tracking.

Review URL: http://codereview.chromium.org/194037
------------------------------------------------------------------------
r27143 | mpcomplete@chromium.org | 2009-09-25 00:59:09 +0200 (Fri, 25 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Revert r27137: "Create renderers for ExtensionHosts one at a time to avoid
blocking the UI"

BUG=14040
TBR=erikkay
------------------------------------------------------------------------
r27140 | jhawkins@chromium.org | 2009-09-25 00:00:31 +0200 (Fri, 25 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_database.cc

Coverity: Initialize statement_cache_ in the constructor.

CID=1640
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/225020
------------------------------------------------------------------------
r27138 | pkasting@chromium.org | 2009-09-24 23:59:38 +0200 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/app/gfx/color_utils.cc
   M /trunk/src/app/gfx/color_utils.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Simplify life for people trying to pick a "readable" foreground color by not requiring them to provide two choices.  This also speeds the call up a tiny bit by not calculating the background luminance twice.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/220029
------------------------------------------------------------------------
r27137 | mpcomplete@chromium.org | 2009-09-24 23:58:08 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Create renderers for ExtensionHosts one at a time to avoid blocking the UI.

BUG=14040
TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading.

Review URL: http://codereview.chromium.org/220028
------------------------------------------------------------------------
r27136 | jhawkins@chromium.org | 2009-09-24 23:57:45 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/archived_database.cc

Coverity: Initialize statement_cache_ in the constructor.

CID=1608
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/222024
------------------------------------------------------------------------
r27135 | jhawkins@chromium.org | 2009-09-24 23:57:26 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_database.cc

Coverity: Initialize statement_cache_ in the constructor.

CID=1602
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223026
------------------------------------------------------------------------
r27134 | jhawkins@chromium.org | 2009-09-24 23:56:56 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc

Coverity: Initialize updating_ in the constructor.

CID=1484
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/222026
------------------------------------------------------------------------
r27133 | thestig@chromium.org | 2009-09-24 23:56:36 +0200 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/cairo_cached_surface.cc

Make Chromium Linux work over VNC again.

BUG=none
TEST=Run a debug copy of Chromium over VNC, should not hit the DCHECK.
Review URL: http://codereview.chromium.org/218024
------------------------------------------------------------------------
r27131 | pkasting@chromium.org | 2009-09-24 23:54:59 +0200 (Thu, 24 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc

Add about: and chrome:* to history.  Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/193071 ), r=me,brettw.

BUG=2958
TEST=Visit "about:", then hit ctrl-h and make sure it's in your history.
------------------------------------------------------------------------
r27130 | tony@chromium.org | 2009-09-24 23:48:08 +0200 (Thu, 24 Sep 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/browser_list_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/views/window/window_gtk.cc

Implement BrowserList::AllBrowsersClosed for Linux.

This fixes leaks caused by not calling gtk_widget_destroy on
dialog windows when we exit.

While I'm here, fix a GList leak on Linux toolkit views.

Review URL: http://codereview.chromium.org/223015
------------------------------------------------------------------------
r27127 | rohitrao@chromium.org | 2009-09-24 23:45:17 +0200 (Thu, 24 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Support option-return to open in new foreground tab.

BUG=http://crbug.com/22882
TEST=Type something into the omnibox.  Option-return should open it in a new foreground tab.
TEST=After using Option-return to open something in a new foreground tab, switch back to the original tab and verify that the url in the omnibox has reverted to the original page's url.
TEST=Option-leftclick on a link in a webpage should still prompt you to "save as."
Review URL: http://codereview.chromium.org/218032
------------------------------------------------------------------------
r27124 | davemoore@chromium.org | 2009-09-24 23:05:36 +0200 (Thu, 24 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   R /trunk/src/chrome/browser/sync/engine/syncer_thread.cc (from /trunk/src/chrome/browser/sync/engine/syncer_thread.cc:27116)
   R /trunk/src/chrome/browser/sync/engine/syncer_thread.h (from /trunk/src/chrome/browser/sync/engine/syncer_thread.h:27116)
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.cc
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.h
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc
   D /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Reverting 27117.
Review URL: http://codereview.chromium.org/235010
------------------------------------------------------------------------
r27120 | jhawkins@chromium.org | 2009-09-24 22:32:12 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

Coverity: Initialize tab_contents_ and wait_state_ in the constructor.

CID=1510
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/218036
------------------------------------------------------------------------
r27118 | erg@google.com | 2009-09-24 22:27:43 +0200 (Thu, 24 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

GTK: Use "Set to Classic theme" instead of reset in the options dialog.

Review URL: http://codereview.chromium.org/238003
------------------------------------------------------------------------
r27117 | tim@chromium.org | 2009-09-24 22:24:48 +0200 (Thu, 24 Sep 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   R /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   R /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.cc (from /trunk/src/chrome/browser/sync/engine/syncer_thread.cc:26372)
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_pthreads.h (from /trunk/src/chrome/browser/sync/engine/syncer_thread.h:26372)
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc (from /trunk/src/chrome/browser/sync/engine/syncer_thread.cc:26372)
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.h (from /trunk/src/chrome/browser/sync/engine/syncer_thread.h:26372)
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Use chrome/base synchronization primitives and threads instead of
pthreads in SyncerThread.  The old pthread impl can be used by
specifying --syncer-thread-pthreads for comparison until we
settle fully on the final impl (I have a MessageLoop-based impl
in progress).

The default SyncerThread is as close to the pthreads-impl semantics as
I could get, with one exception: it does not offer a time-out
when calling Stop(), because it greatly simplifies the implementation.
I first implemented it *with* the timeout, and for sake of
experimentation while this is in shuffle I am checking it in
as SyncerThreadTimedStop, available by using --syncer-thread-timed-stop. I'm not sure which we want ultimately, but it's useful to have around when building the MessageLoop based impl.

I had to refactor the interface slightly to allow multiple implementations,
I think it will be quite useful while working on the MessageLoop impl.

Added several tests to SyncerThreadUnittest, which all impls now pass (
just pass the command line flag to try each out).

TEST=SyncerThreadTest, SyncerThreadWithSyncerTest, integration tests

Review URL: http://codereview.chromium.org/214033
------------------------------------------------------------------------
r27115 | jcampan@chromium.org | 2009-09-24 22:18:54 +0200 (Thu, 24 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native/native_view_host_win.h
   M /trunk/src/views/controls/native/native_view_host_wrapper.h
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.h
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc

Reverting 27113, it breaks the ChomeOS build.

TBR=ben
Review URL: http://codereview.chromium.org/231022
------------------------------------------------------------------------
r27113 | jcampan@chromium.org | 2009-09-24 21:54:15 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native/native_view_host_win.h
   M /trunk/src/views/controls/native/native_view_host_wrapper.h
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.h
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc

Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view.

BUG=None
TEST=Run all tests. Make sure focus is stored/restored properly in Chrome.

Review URL: http://codereview.chromium.org/214029
------------------------------------------------------------------------
r27111 | jhawkins@chromium.org | 2009-09-24 21:50:44 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h

Coverity: Initialize the remaining members of HistoryContentsProvider.

CID=1633
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223025
------------------------------------------------------------------------
r27109 | jhawkins@chromium.org | 2009-09-24 21:48:58 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Coverity: Initialize the remaining members of AutocompleteEditModel.

CID=1646
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/231007
------------------------------------------------------------------------
r27108 | jhawkins@chromium.org | 2009-09-24 21:47:50 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc

Coverity: Initialize pending_buf_size_ in the constructor.

CID=1639
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/218011
------------------------------------------------------------------------
r27106 | mattm@chromium.org | 2009-09-24 21:45:31 +0200 (Thu, 24 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Remove unused tab_contents variable.

CID=6204
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/227013
------------------------------------------------------------------------
r27105 | mattm@chromium.org | 2009-09-24 21:44:57 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Initialize user_gesture_observed_ in NavigationController constructor.

BUG=18268
TEST=run the included test under valgrind without the navigation_controller.cc change, then with.  The memcheck condititional jump error shouldn't fire with the fix.

Review URL: http://codereview.chromium.org/220002
------------------------------------------------------------------------
r27101 | cpu@chromium.org | 2009-09-24 21:35:18 +0200 (Thu, 24 Sep 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc

Fix for crasher on toast UI

- The order of:

radio_button = new views::RadioButton(..)
layout->AddView(radio_button)
radio_button->SetChecked(true);

Matters, if the last two statements are inverted we crash (??)


BUG=none
TEST=start chrome with --try-chrome-again=1 and it does not crash and you see a toast


Review URL: http://codereview.chromium.org/225019
------------------------------------------------------------------------
r27097 | dglazkov@chromium.org | 2009-09-24 21:15:50 +0200 (Thu, 24 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Temporarily disable BrowserCloseBeforeUnload* tests while I am working on fixing them.

TBR=thomasvl
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/222023
------------------------------------------------------------------------
r27088 | jhawkins@chromium.org | 2009-09-24 19:58:03 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc

Coverity: Initialize remaining_payload_length_ in the constructor.

CID=2286
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/220020
------------------------------------------------------------------------
r27085 | shess@chromium.org | 2009-09-24 19:44:11 +0200 (Thu, 24 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Rewrite Omnibox field-editor frame-changing tests.

The previous tests mostly replicated
autocomplete_text_field_cell_unittest.mm cases.  Reworked them to test
that the field editor placement is the same whether
-resetFieldEditorFrameIfNeeded is doing the placement, or the regular
Cocoa focusing machinery.  That's more relevant to what that method is
doing.

Review URL: http://codereview.chromium.org/219003
------------------------------------------------------------------------
r27079 | shess@chromium.org | 2009-09-24 19:18:53 +0200 (Thu, 24 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm

[Mac] Remove paste-and-go from omnibox context menu in popup windows.

The field is not editable, and this is an editing item.

http://crbug.com/20246
TEST=www.popuptest.com, test #2, right-click in the popup's omnibox.
Should not have paste-and-go/paste-and-search menu item.

Review URL: http://codereview.chromium.org/219018
------------------------------------------------------------------------
r27076 | thakis@chromium.org | 2009-09-24 18:41:06 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_pasteboard_unittest.mm

Fix coding style violation.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/235002
------------------------------------------------------------------------
r27075 | sky@chromium.org | 2009-09-24 18:08:03 +0200 (Thu, 24 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/touchpad.cc

Lands http://codereview.chromium.org/231008 for Charlie:

Make vertical edge scroll false by default. Fixed sensitivity
parameter values and inverted the relationship between touch
sensitivity preference and synclient parameter value.

TEST=none 
BUG=22848

Review URL: http://codereview.chromium.org/236002
------------------------------------------------------------------------
r27074 | finnur@chromium.org | 2009-09-24 18:02:44 +0200 (Thu, 24 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Regression: Shift modifier on Find was reversed.
We were also not using GetKeyState correctly in win_util, as the documentation mentions. We should be looking at the high-order bit (&-ing with 0x8000, not 0x80).
BUG=22849TEST=Try to use Enter during FindInPage. Notice it should search forwards when Shift key is not pressed and backwards when Shift is pressed.
Review URL: http://codereview.chromium.org/218009
------------------------------------------------------------------------
r27073 | phajdan.jr@chromium.org | 2009-09-24 18:02:17 +0200 (Thu, 24 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Add a DCHECK to get more info about flaky NPAPIVisiblePluginTester failures.

Example failure:

[FATAL:render_widget_host_view_win.cc(399)] Check failed: parent.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/220021
------------------------------------------------------------------------
r27071 | sky@chromium.org | 2009-09-24 17:51:26 +0200 (Thu, 24 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Changes from listening to focus-out/focus-in for active status to
listening for is-active.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/219016
------------------------------------------------------------------------
r27067 | yurys@google.com | 2009-09-24 17:16:18 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/script_syntax_error.html
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: autoresume execution on parse errors.

BUG=22852
TEST=DevToolsSanityTest.TestAutoContinueOnSyntaxError

Review URL: http://codereview.chromium.org/218026
------------------------------------------------------------------------
r27064 | rohitrao@chromium.org | 2009-09-24 16:55:21 +0200 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Add a strikethrough through insecure url schemes.

BUG=http://crbug.com/22558
TEST=Go to https://www.twitter.com/.  See the cert mismatch warning.  Check that "https://" in the omnibox is red with a strikethrough.
Review URL: http://codereview.chromium.org/215038
------------------------------------------------------------------------
r27063 | yurys@google.com | 2009-09-24 16:00:41 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

Reverting 27062 since "DevTools: repair on linux and reenable breakpoint tests" revision 27060 was not the cause of regression on Webkit Mac10.5 and Webkit Linux (dbg)(3)

TBR=maruel
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/231016
------------------------------------------------------------------------
r27062 | maruel@chromium.org | 2009-09-24 15:31:40 +0200 (Thu, 24 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

Revert "DevTools: repair on linux and reenable breakpoint tests" revision 27060.

Caused regression on Webkit Mac10.5 and Webkit Linux (dbg)(3)

TBR=yurys
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/225027
------------------------------------------------------------------------
r27061 | suzhe@chromium.org | 2009-09-24 11:32:31 +0200 (Thu, 24 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Enable disabled autocomplete edit view tests.

This CL enables those disabled autocomplete edit view tests, as the flaky and failing issue were already solved.

BUG=20422: Autocomplete edit view needs automated testing
BUG=21846: AutocompleteEditViewTest.AltEnter is failing
BUG=21849: AutocompleteEditViewTest.EnterToSearch is flaky
TEST=none

Review URL: http://codereview.chromium.org/223021
------------------------------------------------------------------------
r27060 | yurys@google.com | 2009-09-24 11:11:54 +0200 (Thu, 24 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: repair on linux and reenable breakpoint tests
Review URL: http://codereview.chromium.org/231001
------------------------------------------------------------------------
r27055 | jorlow@chromium.org | 2009-09-24 09:09:57 +0200 (Thu, 24 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Crash the renderer not the browser when we see a storage area ID or namespace ID
that we didn't expect.

TEST=Changed the code to pass in an invalid ID.  The tab became sad as expected.
BUG=20055

Review URL: http://codereview.chromium.org/217001
------------------------------------------------------------------------
r27050 | thakis@chromium.org | 2009-09-24 08:07:18 +0200 (Thu, 24 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_pasteboard_unittest.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Try to fix valgrind.

TBR: mark@chromium.org
(Since this looks like something you've dealt with before)
------------------------------------------------------------------------
r27048 | ananta@chromium.org | 2009-09-24 07:41:02 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Removing the comment above the Firefox30Importer test which indicated that the test was disabled, etc as
we fixed the underlying cause of the test failure.

TBR=nsylvain

Review URL: http://codereview.chromium.org/219027
------------------------------------------------------------------------
r27045 | ananta@chromium.org | 2009-09-24 07:23:11 +0200 (Thu, 24 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

The Firefox3XImporter test was incorrectly deleting a ref counted object causing an ASSERT to fire
resulting in this test to randomly fail on the Vista dbg builder.

Fix is to get rid of the delete and wrap the allocated Firefox3Observer object in a scoped_refptr.

This fixes http://code.google.com/p/chromium/issues/detail?id=22884

Bug=22884

Review URL: http://codereview.chromium.org/231012
------------------------------------------------------------------------
r27041 | estade@chromium.org | 2009-09-24 06:57:30 +0200 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

GTK: Don't ellipsize the Other Bookmarks button.

BUG=22788

Review URL: http://codereview.chromium.org/225014
------------------------------------------------------------------------
r27037 | nsylvain@chromium.org | 2009-09-24 04:57:01 +0200 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Disable the firefox importer test because it fails on the
buildbot.

BUG:22884
Review URL: http://codereview.chromium.org/219026
------------------------------------------------------------------------
r27031 | pkasting@chromium.org | 2009-09-24 03:14:52 +0200 (Thu, 24 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/color_utils.cc
   M /trunk/src/app/gfx/color_utils.h
   A /trunk/src/app/gfx/color_utils_unittest.cc (from /trunk/src/app/gfx/color_utils_unittest.cc:26978)
   A /trunk/src/app/gfx/skbitmap_operations.cc (from /trunk/src/app/gfx/skbitmap_operations.cc:26978)
   A /trunk/src/app/gfx/skbitmap_operations.h (from /trunk/src/app/gfx/skbitmap_operations.h:26978)
   A /trunk/src/app/gfx/skbitmap_operations_unittest.cc (from /trunk/src/app/gfx/skbitmap_operations_unittest.cc:26978)
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils.h
   D /trunk/src/skia/ext/skia_utils_unittest.cc
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Move functions from skia/ext to app/gfx where possible: most of skia_utils.* and image_operations.* can be moved because they are not used by WebKit code.

This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights.

This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux.

BUG=none
TEST=none
------------------------------------------------------------------------
r27015 | thakis@chromium.org | 2009-09-24 00:43:00 +0200 (Thu, 24 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/find_pasteboard.h
   A /trunk/src/chrome/browser/cocoa/find_pasteboard.mm
   A /trunk/src/chrome/browser/cocoa/find_pasteboard_unittest.mm
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/chrome.gyp

Let cmd-f/cmd-g use the findboard.

In a nutshell, this means that the find bars honor the global find pasteboard, which is like a clipboard, but for searches. See the TEST section below for consequences, and also see the bug for more information.

BUG=14562
TEST=
* Select some text, hit cmd-e, cmd-g. This should search for the marked text and open the find bar if it's not open.
* Open TextEdit, hit cmd-f. Enter some text, hit enter. Switch back to Chrome with an open find bar. The find bar should now contain the text you entered in TextEdit
* Enter different text into chrome's find bar, switch back to TextEdit. Its find window should now contain the new text.
* Search for something in one tab, switch to another tab. It should contain the same text in the findbar as the first one.
* Open the findbar, select some text, hit cmd-e. The find bar should be updated with the selected text and this text should be highlighted in the web page. Find bars in other tabs should be updated with that text as well.

Review URL: http://codereview.chromium.org/206035
------------------------------------------------------------------------
r27014 | jhawkins@chromium.org | 2009-09-24 00:42:05 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

Coverity: Initialize SavePackageParam::save_type to SAVE_TYPE_UNKNOWN in the constructor.

CID=2275
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/219020
------------------------------------------------------------------------
r27012 | davemoore@google.com | 2009-09-24 00:30:16 +0200 (Thu, 24 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_host.cc
   M /trunk/src/chrome/browser/views/find_bar_host.h
   M /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   M /trunk/src/chrome/browser/views/find_bar_host_win.cc

A refactor broke the find bar...characters like ! and ( 
became unsearchable

BUG=10509

TEST=Open nytimes.com, search for "new". Then type "!". It should appear in the search box but not be found (unless the the text "new!" is really in the page. Confirm you can search for ( and & as well.
Review URL: http://codereview.chromium.org/220019
------------------------------------------------------------------------
r27008 | erg@chromium.org | 2009-09-24 00:28:23 +0200 (Thu, 24 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h
   M /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Mac: Hook up the page menu's "Encoding" submenu.

Hook the NSMenu's delegate up to the ToolbarController in the nib and
generalize EncodingMenuControllerDelegate to work with a NSMenu
object instead of grabbing the app menu.

BUG=22639
TEST=ToolbarControllerTest.PopulateEncodingMenu

Review URL: http://codereview.chromium.org/225016
------------------------------------------------------------------------
r27005 | shess@chromium.org | 2009-09-24 00:24:56 +0200 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Back out accidentally-left logging line in autocomplete code.

Was added in http://codereview.chromium.org/207047 .  I promise to drink less caffeine in the future.

Review URL: http://codereview.chromium.org/220024
------------------------------------------------------------------------
r27003 | ananta@chromium.org | 2009-09-24 00:15:04 +0200 (Thu, 24 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Reinstating the AutomationMsg_TabReposition message and related stuff which is used by ChromeFrame. These were
incorrectly removed under the assumption that they are unused.

This should fix the ChromeFrame build issues.

TBR=amit,estade

Review URL: http://codereview.chromium.org/220022
------------------------------------------------------------------------
r27001 | thestig@chromium.org | 2009-09-24 00:12:23 +0200 (Thu, 24 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   D /trunk/src/chrome/app/breakpad_linux_stub.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/renderer_main.cc

Make Linux Breakpad initialization call to lsb_release asynchronous. Also wrap more
things in USE_LINUX_BREAKPAD while we're at it.

BUG=21782
TEST=Add time.sleep(10) to /usr/bin/lsb_release; starting Chrome should not take 10 seconds more.
Review URL: http://codereview.chromium.org/209042
------------------------------------------------------------------------
r26999 | sky@chromium.org | 2009-09-24 00:09:31 +0200 (Thu, 24 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h

Makes Chrome on Chrome OS not restore the last session if the last
session crashed.

BUG=22835
TEST=On Chrome OS bring up Chrome, wait a few seconds, go to a
  terminal and kill Chrome, when Chrome comes up again you should see
  the crashed info bar.

Review URL: http://codereview.chromium.org/220018
------------------------------------------------------------------------
r26996 | sky@chromium.org | 2009-09-23 23:46:38 +0200 (Wed, 23 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Lands http://codereview.chromium.org/227008 for Charlie:

Add touchpad sensitivity setting.
BUG=22848
TEST=none

Review URL: http://codereview.chromium.org/223012
------------------------------------------------------------------------
r26995 | sky@chromium.org | 2009-09-23 23:42:58 +0200 (Wed, 23 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data.h
   M /trunk/src/app/os_exchange_data_provider_gtk.cc
   M /trunk/src/app/os_exchange_data_provider_gtk.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/views/DEPS
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/drag_utils.h
   M /trunk/src/views/widget/drop_target_gtk.cc

Implements file contents support in OSExchangeData and DropTarget
for gtk. Makes html and file contents support in OSExchangeData only
for windows (as that is the only place we need it), and makes dragging
files work.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/232002
------------------------------------------------------------------------
r26993 | shess@chromium.org | 2009-09-23 23:31:39 +0200 (Wed, 23 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h

[Mac] Convert Omnibox paste-and-go to use AutocompleteTextFieldObserver.

Obvious result of Rohit's addition of paste-and-go and my refactor to
add AutocompleteTextFieldObserver.  Bonus prize of unit tests for
cocoa/ part of Rohit's change.

Review URL: http://codereview.chromium.org/207047
------------------------------------------------------------------------
r26992 | tony@chromium.org | 2009-09-23 23:29:42 +0200 (Wed, 23 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Add more view ids and gtk widget names to so gtkparasite is
easier to navigate.

Review URL: http://codereview.chromium.org/221001
------------------------------------------------------------------------
r26991 | thestig@chromium.org | 2009-09-23 23:27:43 +0200 (Wed, 23 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Fix an off by 1 error in the Linux Breakpad guid.

BUG=22067
TEST=No more random strings in crash client GUIDs.
Review URL: http://codereview.chromium.org/213038
------------------------------------------------------------------------
r26985 | jhawkins@chromium.org | 2009-09-23 23:12:04 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/icon_loader.cc

Coverity: Initialize target_message_loop_ in the constructor.

CID=3970
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/233001
------------------------------------------------------------------------
r26984 | jhawkins@chromium.org | 2009-09-23 23:11:40 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Coverity: Initialize the remaining DropInfo members in the constructor.

CID=4402
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/227007
------------------------------------------------------------------------
r26983 | jhawkins@chromium.org | 2009-09-23 23:08:27 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h

Coverity: Add a SavePackageType, SAVE_TYPE_UNKNOWN, which represents the state of the save type before the user has selected a save type.  Initialize save_type_ to this value in the constructor.

CID=3809
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/220016
------------------------------------------------------------------------
r26982 | phajdan.jr@chromium.org | 2009-09-23 23:07:07 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/net/ftp_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Add a very basic test for FTP directory listing, browser side.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/220015
------------------------------------------------------------------------
r26981 | phajdan.jr@chromium.org | 2009-09-23 23:06:28 +0200 (Wed, 23 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc

Gather more info when AutocompleteBrowserTest flakily fails.

It's most probably a bug in the code being tested, or a bad assumption
in the test.

TEST=none
BUG=19876

Review URL: http://codereview.chromium.org/233002
------------------------------------------------------------------------
r26979 | pkasting@chromium.org | 2009-09-23 22:54:48 +0200 (Wed, 23 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/color_utils.cc
   M /trunk/src/app/gfx/color_utils.h
   D /trunk/src/app/gfx/color_utils_unittest.cc
   D /trunk/src/app/gfx/skbitmap_operations.cc
   D /trunk/src/app/gfx/skbitmap_operations.h
   D /trunk/src/app/gfx/skbitmap_operations_unittest.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils.h
   A /trunk/src/skia/ext/skia_utils_unittest.cc (from /trunk/src/skia/ext/skia_utils_unittest.cc:26974)
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Reverting 26975.
Review URL: http://codereview.chromium.org/222011
------------------------------------------------------------------------
r26975 | pkasting@chromium.org | 2009-09-23 22:40:52 +0200 (Wed, 23 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/color_utils.cc
   M /trunk/src/app/gfx/color_utils.h
   A /trunk/src/app/gfx/color_utils_unittest.cc (from /trunk/src/skia/ext/skia_utils_unittest.cc:26635)
   A /trunk/src/app/gfx/skbitmap_operations.cc (from /trunk/src/skia/ext/image_operations.cc:26696)
   A /trunk/src/app/gfx/skbitmap_operations.h (from /trunk/src/skia/ext/image_operations.h:26696)
   A /trunk/src/app/gfx/skbitmap_operations_unittest.cc (from /trunk/src/skia/ext/image_operations_unittest.cc:26696)
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils.h
   D /trunk/src/skia/ext/skia_utils_unittest.cc
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Move functions from skia/ext to app/gfx where possible: most of skia_utils.* and image_operations.* can be moved because they are not used by WebKit code.

This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/207059
------------------------------------------------------------------------
r26972 | mdm@chromium.org | 2009-09-23 22:34:34 +0200 (Wed, 23 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Linux: create dropped tab windows at the restore size of the source window instead of its current size (different when the source is maximized)
BUG=22154
TEST=open a window with two tabs, maximize it, then drag one tab out - it should be the original size of the original window

Review URL: http://codereview.chromium.org/216053
------------------------------------------------------------------------
r26962 | erg@google.com | 2009-09-23 21:31:31 +0200 (Wed, 23 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Revert "GTK: Use rounded corners in AutocompletePopupViewGtk."

This mostly reverts commit e461ca0cebce93375b81a14af7caf5d95a10158c (r25080) and adds a comment about why I reverted it.

This breaks on NX, probably because we're shaping a toplevel window
from within the expose event. I don't see a different point when we
can shape the window reliably (configure-event doesn't appear to work),
so just revert rounded corners on the popup for now.

BUG=22015

Review URL: http://codereview.chromium.org/224004
------------------------------------------------------------------------
r26960 | jhawkins@chromium.org | 2009-09-23 21:22:24 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h

Coverity: Initialize ssl_cert_id_, ssl_cert_status_, and ssl_security_bits_ in the constructor.

CID=5442
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/222008
------------------------------------------------------------------------
r26959 | tony@chromium.org | 2009-09-23 21:21:58 +0200 (Wed, 23 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Revert "Revert "Add back ctrl+shift+delete for bringing up the "Clear browsing data"""

This reverts commit r26956 and re-applies the keyboard bindings for clearing
browsing data.

_ph says that the test is just flaky.

TBR=estade

Review URL: http://codereview.chromium.org/232005
------------------------------------------------------------------------
r26956 | tony@chromium.org | 2009-09-23 20:42:56 +0200 (Wed, 23 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Revert "Add back ctrl+shift+delete for bringing up the "Clear browsing data""

This reverts commit r26947.

TBR=estade

Review URL: http://codereview.chromium.org/225015
------------------------------------------------------------------------
r26955 | michaeln@google.com | 2009-09-23 20:38:56 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Be sure to initialize AppCacheDispatcherHost on the IO thread.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/221002
------------------------------------------------------------------------
r26954 | jhawkins@chromium.org | 2009-09-23 20:32:38 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store.cc

Coverity: Initialize statement_cache_ in the constructor.

CID=5040
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/225013
------------------------------------------------------------------------
r26953 | ananta@chromium.org | 2009-09-23 20:26:03 +0200 (Wed, 23 Sep 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/views/html_dialog_view.cc

There is a race condition when the HtmlDialogView is closed which causes a crash while dereferencing an invalid
delegate_ (HtmlDialogUIDelegate*) member. I could not reproduce this consistently though. The inference is
as below:-

1. When the dialog is closed the HtmlDialogView::OnDialogClosed member function is invoked which calls the
   OnDialogClosed function on the delegate. This in turn causes the delegate to be destroyed.
2. It then sets the delegate to NULL and attempts to close the window.
3. Before the Close method is dispatched if the view attempts to Paint it causes a crash in the
   HtmlDialogView::GetWindowTitle function because of dereferencing a NULL delegate_.

Fix is to add corresponding NULL checks in the relevant functions.

This fixes http://b/issue?id=2138035, which was reported with ChromeFrame.

Bug=2138035


Review URL: http://codereview.chromium.org/220011
------------------------------------------------------------------------
r26947 | tony@chromium.org | 2009-09-23 20:00:06 +0200 (Wed, 23 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Add back ctrl+shift+delete for bringing up the "Clear browsing data"
dialog on linux.  When we removed the menu item, we lost the keyboard
binding as well.

Review URL: http://codereview.chromium.org/216056
------------------------------------------------------------------------
r26941 | brettw@chromium.org | 2009-09-23 19:19:46 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

Remove a DCHECK that was firing in legitimate cases. The cases are described in
the comment I added to the code.

http://crbug.com/21849
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/210043
------------------------------------------------------------------------
r26939 | brettw@chromium.org | 2009-09-23 19:17:48 +0200 (Wed, 23 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc

Add some new histograms for history, and UMA-enable a few others.

BUG=19773
TEST=none
Review URL: http://codereview.chromium.org/212014
------------------------------------------------------------------------
r26933 | sky@chromium.org | 2009-09-23 18:23:13 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

Disables turning on custom frame in chrome os.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/207055
------------------------------------------------------------------------
r26930 | phajdan.jr@chromium.org | 2009-09-23 18:05:12 +0200 (Wed, 23 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc

Remove an EXPECT in new autocomplete browser test which failes on Windows.

I misinterpreted trybot results, the bot detected it earlier.

TBR=pkasting

Review URL: http://codereview.chromium.org/220008
------------------------------------------------------------------------
r26924 | phajdan.jr@chromium.org | 2009-09-23 17:35:17 +0200 (Wed, 23 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Add new, shiny browser test for Autocomplete (Omnibox).

To fix the Omnibox automation flakiness, I first want to be sure
how the system behaves in its natural environment. The test is very basic
for now.

TEST=browser_tests
BUG=19876

Review URL: http://codereview.chromium.org/193069
------------------------------------------------------------------------
r26917 | yurys@google.com | 2009-09-23 16:31:47 +0200 (Wed, 23 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: temporarily disable breakpoint tests

TBR=pfeldman
Review URL: http://codereview.chromium.org/218003
------------------------------------------------------------------------
r26913 | yurys@google.com | 2009-09-23 14:44:47 +0200 (Wed, 23 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: added a new test for console evaluation on call frame.

Review URL: http://codereview.chromium.org/229002
------------------------------------------------------------------------
r26909 | pfeldman@chromium.org | 2009-09-23 10:49:09 +0200 (Wed, 23 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/test/data/devtools/console_test_page.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Add more console tests.
BUG=22570
Review URL: http://codereview.chromium.org/212047
------------------------------------------------------------------------
r26898 | davemoore@chromium.org | 2009-09-23 04:42:45 +0200 (Wed, 23 Sep 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/app/theme/statusbar_battery.png
   A /trunk/src/chrome/app/theme/statusbar_battery1c.png
   A /trunk/src/chrome/app/theme/statusbar_battery1d.png
   A /trunk/src/chrome/app/theme/statusbar_battery2c.png
   A /trunk/src/chrome/app/theme/statusbar_battery2d.png
   A /trunk/src/chrome/app/theme/statusbar_battery3c.png
   A /trunk/src/chrome/app/theme/statusbar_battery3d.png
   A /trunk/src/chrome/app/theme/statusbar_battery4c.png
   A /trunk/src/chrome/app/theme/statusbar_battery4d.png
   A /trunk/src/chrome/app/theme/statusbar_battery5c.png
   A /trunk/src/chrome/app/theme/statusbar_battery5d.png
   A /trunk/src/chrome/app/theme/statusbar_battery6c.png
   A /trunk/src/chrome/app/theme/statusbar_battery6d.png
   A /trunk/src/chrome/app/theme/statusbar_battery7c.png
   A /trunk/src/chrome/app/theme/statusbar_battery7d.png
   A /trunk/src/chrome/app/theme/statusbar_battery8c.png
   A /trunk/src/chrome/app/theme/statusbar_battery8d.png
   A /trunk/src/chrome/app/theme/statusbar_battery_charged.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/browser/chromeos/DEPS
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Make chromeos build use shared object to load battery
functionality. Call into it and show new battery images

Review URL: http://codereview.chromium.org/215025
------------------------------------------------------------------------
r26897 | mal@chromium.org | 2009-09-23 04:38:17 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc

Change the URL for the plugin finder service.

We need to start using the /edgedl prefix.

BUG= b/2111073
Review URL: http://codereview.chromium.org/217021
------------------------------------------------------------------------
r26894 | arv@chromium.org | 2009-09-23 03:32:37 +0200 (Wed, 23 Sep 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/ntp_themes_promo.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adds a theme promo in the lower right corner

BUG=None

TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome
Review URL: http://codereview.chromium.org/217020
------------------------------------------------------------------------
r26893 | estade@chromium.org | 2009-09-23 03:25:45 +0200 (Wed, 23 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix views build.

TBR=stuartmorgan

Review URL: http://codereview.chromium.org/224001
------------------------------------------------------------------------
r26891 | estade@chromium.org | 2009-09-23 03:15:50 +0200 (Wed, 23 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/download_in_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp

Download in progress dialog:

- Change hardcoded "Google Chrome" to product name.
- Implement for GTK.

BUG=21652

Review URL: http://codereview.chromium.org/212051
------------------------------------------------------------------------
r26890 | estade@chromium.org | 2009-09-23 03:14:34 +0200 (Wed, 23 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h

GTK: Dismiss the bookmark folder menu(s) when a context menu item is executed.

BUG=22372

Review URL: http://codereview.chromium.org/211056
------------------------------------------------------------------------
r26868 | paul@chromium.org | 2009-09-23 00:07:11 +0200 (Wed, 23 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable two ui_tests on linux after a WebKit merge.

BUG=22696
TEST=Covered by ui_tests.
Review URL: http://codereview.chromium.org/211053
------------------------------------------------------------------------
r26864 | sky@chromium.org | 2009-09-22 23:46:27 +0200 (Tue, 22 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Implements a couple of NOTIMPLEMENTEDs in window_gtk and comments on
why we're not going to implement some.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/207057
------------------------------------------------------------------------
r26862 | pinkerton@chromium.org | 2009-09-22 23:25:50 +0200 (Tue, 22 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Remove potential for command-key equivalents to beat the file menu fix-up timer by clearing the command keys for close tab/window before we fire the timer.
BUG=16689
TEST=cmd-w closes tabs/windows correctly based on number of tabs in the window and if the window is a browser window. Also comment 16 in the bug.
Review URL: http://codereview.chromium.org/215056
------------------------------------------------------------------------
r26860 | phajdan.jr@chromium.org | 2009-09-22 23:05:47 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/net/net_resource_provider.cc
   A /trunk/src/chrome/common/net/net_resource_provider.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/net/base/mime_util.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.h
   M /trunk/src/webkit/glue/DEPS
   A /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc
   A /trunk/src/webkit/glue/ftp_directory_listing_response_delegate.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/webkit.gyp

Move FTP LIST parsing code to the renderer process.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/210027
------------------------------------------------------------------------
r26855 | dumi@chromium.org | 2009-09-22 22:41:20 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/webkit/DEPS
   A /trunk/src/webkit/database
   A /trunk/src/webkit/database/vfs_backend.cc (from /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc:26362)
   A /trunk/src/webkit/database/vfs_backend.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.h
   A /trunk/src/webkit/tools/test_shell/simple_database_system.cc
   A /trunk/src/webkit/tools/test_shell/simple_database_system.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/webkit.gyp

Refactor the DB code to make it accessible from test_shell.

BUG=21442
TEST=none

Review URL: http://codereview.chromium.org/203074
------------------------------------------------------------------------
r26853 | erg@chromium.org | 2009-09-22 22:37:43 +0200 (Tue, 22 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm

Mac: Empty bookmark bar should show IDS_BOOKMARKS_NO_ITEMS.

TEST=BookmarkBarControllerTest.DisplaysHelpMessageOnEmpty
TEST=BookmarkBarControllerTest.HidesHelpMessageWithBookmark
BUG=17360

Review URL: http://codereview.chromium.org/216052
------------------------------------------------------------------------
r26846 | estade@chromium.org | 2009-09-22 21:57:24 +0200 (Tue, 22 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h

Automated ui test porting + cleanup:

- Change POINTs to gfx::Point
- Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build)
-- add new automation messages to replace GetWindowHWND, which is not portable
- re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp)
- compile additional tests on linux (they don't pass, so they are disabled)
- stub out linux tab dragging automation implementation (browser side)
- delete various cruft

BUG=19758

Review URL: http://codereview.chromium.org/211033
------------------------------------------------------------------------
r26844 | michaeln@google.com | 2009-09-22 21:50:31 +0200 (Tue, 22 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.h
   M /trunk/src/webkit/appcache/appcache_service.cc
   M /trunk/src/webkit/appcache/appcache_service.h

Fix appcache_service and request_context referencing.

There is one appcache service per profile and several request context per profile. The profile holds a reference to the appcache service. Those request contexts which are subject to retrieval from appcaches hold a reference to the appcache service too. The appcache service is provided with a pointer back to the 'main' request context, this context is used when updating appcaches.

Initialization is a little tricky because profiles can't be used on the IO thread and request contexts can't be used on the UI thread.

BUG=22597,22125
TEST=many existing tests exercise profile/context creation
Review URL: http://codereview.chromium.org/215024
------------------------------------------------------------------------
r26839 | sky@chromium.org | 2009-09-22 20:38:40 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Gets the drop arrow to show when dragging URLs over the tab strip.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/215047
------------------------------------------------------------------------
r26835 | zork@chromium.org | 2009-09-22 20:18:33 +0200 (Tue, 22 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/sync_cycle_state.h
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_status.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/notifier/base/string.cc
   M /trunk/src/chrome/browser/sync/notifier/base/task_pump.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_columns.h
   M /trunk/src/chrome/browser/sync/util/character_set_converters.h
   M /trunk/src/chrome/browser/sync/util/character_set_converters_linux.cc
   M /trunk/src/chrome/browser/sync/util/compat_file_posix.cc
   M /trunk/src/chrome/browser/sync/util/compat_pthread.h
   M /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   M /trunk/src/chrome/browser/sync/util/path_helpers.h
   M /trunk/src/chrome/browser/sync/util/path_helpers_linux.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc
   M /trunk/src/chrome/browser/sync/util/pthread_helpers.cc
   M /trunk/src/chrome/browser/sync/util/pthread_helpers.h
   M /trunk/src/chrome/browser/sync/util/query_helpers.h
   M /trunk/src/chrome/browser/sync/util/sync_types.h
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings_posix.cc

Fix compiling of sync on linux.
Review URL: http://codereview.chromium.org/211019
------------------------------------------------------------------------
r26832 | sky@chromium.org | 2009-09-22 20:11:31 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/views/view.h
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_win.cc

Implements a NOTIMPLEMENTED in GoButton.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/216045
------------------------------------------------------------------------
r26830 | phajdan.jr@chromium.org | 2009-09-22 19:37:44 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Do not run ErrorPageTest on XP, too flaky.

TEST=Um, none?
BUG=19361

Review URL: http://codereview.chromium.org/212049
------------------------------------------------------------------------
r26828 | tony@chromium.org | 2009-09-22 19:27:59 +0200 (Tue, 22 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h

Make it possible to edit bookmark folder names inline.  This
works in both the edit bookmark dialog and in the bookmark manager.

BUG=20328

Review URL: http://codereview.chromium.org/210036

------------------------------------------------------------------------
r26825 | idanan@google.com | 2009-09-22 19:01:44 +0200 (Tue, 22 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Fix so that the doubleclick privacy blacklist does not interfere with Gmail

OnCookieSet changed so that a blacklist present but with no match still sets the cookie.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/217016
------------------------------------------------------------------------
r26824 | kuchhal@chromium.org | 2009-09-22 18:56:20 +0200 (Tue, 22 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/importer/importer.cc

Fix crash during import by checking for errors and exiting early.

BUG=22055

Review URL: http://codereview.chromium.org/204051
------------------------------------------------------------------------
r26821 | mdm@chromium.org | 2009-09-22 18:44:14 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: correctly update window restore bounds.
This makes creating a new window after maximizing an existing window work as intended (reliably).
BUG=15102
TEST=create a new window after maximizing an existing window on sawfish; the new window should not be maximized

Review URL: http://codereview.chromium.org/212046
------------------------------------------------------------------------
r26820 | sky@chromium.org | 2009-09-22 18:43:46 +0200 (Tue, 22 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc

Makes tab dragging on views restrict the drag to the main window.

As X is async, this results in annoying flicker right now. If we stick
with this we're going to need to avoid creating a new window. But this
is good enough for now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/210035
------------------------------------------------------------------------
r26819 | sgk@google.com | 2009-09-22 18:39:11 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/app_controller_mac.mm

Have the dock menu "New Incognito Window" item always open a new
window, not open a tab in an existing incognito window.
(Vedran Šajatović)
BUG=21175
TEST=New Incognito Window from dock with an incognito window already open
Review URL: http://codereview.chromium.org/207054
------------------------------------------------------------------------
r26816 | sgk@chromium.org | 2009-09-22 18:16:39 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/build/build_config.h
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/chrome.gyp

Add a simple about:tcmalloc page that just displays its canned stats.
Add USE_TCMALLOC to control its inclusion.  Make browser depend on
tcmalloc to get the PERFTOOLS_DLL_DECL definition.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/216033
------------------------------------------------------------------------
r26809 | erikkay@chromium.org | 2009-09-22 17:07:51 +0200 (Tue, 22 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

hide toolstrips in full screen mode
BUG=13439
TEST=none

Review URL: http://codereview.chromium.org/214045
------------------------------------------------------------------------
r26794 | mattm@chromium.org | 2009-09-22 06:28:45 +0200 (Tue, 22 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/strict_transport_security_persister.cc
   M /trunk/src/chrome/browser/strict_transport_security_persister.h
   M /trunk/src/net/url_request/url_request_context.h

URLRequestContext needs to keep a reference to StrictTransportSecurityState

StrictTransportSecurityPersister needs to unregister itself as the delegate before it gets deleted.

BUG=21897
TEST=see bug

Review URL: http://codereview.chromium.org/217012
------------------------------------------------------------------------
r26793 | jorlow@chromium.org | 2009-09-22 06:20:04 +0200 (Tue, 22 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   M /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/dom_storage_type.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h

Create an enum for local storage vs. session storage rather than using
a boolean.

TEST=It still works.
BUG=21070


Review URL: http://codereview.chromium.org/212033
------------------------------------------------------------------------
r26792 | rsesek@chromium.org | 2009-09-22 06:00:04 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

[Mac] Add favicons to items in folders on the bookmark bar.

BUG=22601
TEST=Add folder to bookmark bar, bookmark a page in that folder, see icon when you open the menu.

Review URL: http://codereview.chromium.org/210029
------------------------------------------------------------------------
r26788 | aa@chromium.org | 2009-09-22 04:44:51 +0200 (Tue, 22 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc

Two minor fixes to extensions/download manager integration:
- Don't show installed extensions in download view
- Make "Save as..." work for extensions

BUG=19080,20183

Review URL: http://codereview.chromium.org/209064
------------------------------------------------------------------------
r26787 | jnd@chromium.org | 2009-09-22 04:31:04 +0200 (Tue, 22 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Speed up the BrowserEncodingTest.TestEncodingAutoDetect.
The main way is making the sleep timout shorter.

BUG=22063
TEST=BrowserEncodingTest.TestEncodingAutoDetect.

Review URL: http://codereview.chromium.org/209030
------------------------------------------------------------------------
r26786 | evan@chromium.org | 2009-09-22 04:01:59 +0200 (Tue, 22 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/google_update_settings_mac.mm
   M /trunk/src/chrome/browser/google_update_settings_posix.cc

linux: fix a notimplemented by sharing mac code

We don't have an install-time language setting either.

Review URL: http://codereview.chromium.org/208054
------------------------------------------------------------------------
r26781 | aa@chromium.org | 2009-09-22 03:16:18 +0200 (Tue, 22 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc

Use heap memory intead of stack memory to avoid having to
grow the stack.

BUG=12968
TEST=none

Review URL: http://codereview.chromium.org/215042
------------------------------------------------------------------------
r26771 | rafaelw@chromium.org | 2009-09-22 02:32:52 +0200 (Tue, 22 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html

Add NotificationType::BROWSER_WINDOW_READY, chrome.windows.onCreated now sends full window

BUG=NONE

Review URL: http://codereview.chromium.org/195030
------------------------------------------------------------------------
r26765 | eroman@chromium.org | 2009-09-22 02:04:59 +0200 (Tue, 22 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/base/leak_tracker.h
   M /trunk/src/chrome/browser/browser_process_impl.cc

Enable LeakTracker on release builds.

This is intended to be temporary, so we can get data from the dev channel on why URLRequest objects are leaking at shutdown.

WARNING: it may cause a slight slowdown on page cycler.

Also as part of this change, I switched the order that we check URLFetcher / URLRequest.
This is simply so that if both URLFetcher and URLRequest have leaked, we will report the URLFetcher leak rather than the URLRequest leak.

BUG=http://crbug.com/21199, http://crbug.com/18372

Review URL: http://codereview.chromium.org/217005
------------------------------------------------------------------------
r26761 | phajdan.jr@chromium.org | 2009-09-22 01:07:15 +0200 (Tue, 22 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   A /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.cc
   A /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/mock-link-doctor.html
   A /trunk/src/chrome/test/data/mock-link-doctor.html.mock-http-headers

Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.

Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward.

TEST=Covered by ui_tests and browser_tests.
http://crbug.com/18365, http://crbug.com/19361

Review URL: http://codereview.chromium.org/174179
------------------------------------------------------------------------
r26757 | paul@chromium.org | 2009-09-22 00:49:00 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Temporarily disable some devtools interactive tests.

BUG=22570
TEST=Covered by the disabled tests.

Review URL: http://codereview.chromium.org/215043
------------------------------------------------------------------------
r26755 | cpu@chromium.org | 2009-09-22 00:39:09 +0200 (Tue, 22 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.h

Making UserScriptMaster::ScriptReloader refcounted thread safe
- Being addref() in two different threads.

BUG=18488
TEST=none


Review URL: http://codereview.chromium.org/213025
------------------------------------------------------------------------
r26754 | cpu@chromium.org | 2009-09-22 00:38:00 +0200 (Tue, 22 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist.h

Making ShellLinkItem refcount thread safe

-It is being addref() in main thread and in the file thread

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/213026
------------------------------------------------------------------------
r26753 | shess@chromium.org | 2009-09-22 00:28:31 +0200 (Tue, 22 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h

[Mac] Use gmock rather than manual mock for autocomplete tests.

Review URL: http://codereview.chromium.org/209053
------------------------------------------------------------------------
r26752 | chron@chromium.org | 2009-09-22 00:27:30 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc

For bookmark sync, remove cookie support from http bridge and syncapi.
Cookies are problematic for the sync client and no longer necessary.
This code is no longer used.


Review URL: http://codereview.chromium.org/208036
------------------------------------------------------------------------
r26749 | jam@chromium.org | 2009-09-22 00:13:31 +0200 (Tue, 22 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Fix race condition with message ports being dropped if sent before a worker starts.

BUG=22315
TEST=covered by worker-messageport-gc.html
Review URL: http://codereview.chromium.org/208045
------------------------------------------------------------------------
r26748 | mpcomplete@chromium.org | 2009-09-22 00:05:45 +0200 (Tue, 22 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   A /trunk/src/chrome/test/data/extensions/uitest/plugins
   A /trunk/src/chrome/test/data/extensions/uitest/plugins/README
   A /trunk/src/chrome/test/data/extensions/uitest/plugins/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/plugins/plugin.dll
   A /trunk/src/chrome/test/data/extensions/uitest/plugins/test.html
   M /trunk/src/webkit/api/public/WebKit.h
   M /trunk/src/webkit/api/src/WebKit.cpp
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Update renderer plugin cache when we load/unload extensions with plugins.

BUG=12306
TEST=Load and unload extensions that contain plugins and visit pages that use them. Also covered by tests.

Review URL: http://codereview.chromium.org/201111
------------------------------------------------------------------------
r26744 | sky@chromium.org | 2009-09-21 23:53:15 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc

Makes TabIconView use IDR_PRODUCT_LOGO_16 on non-windows platforms.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/207045
------------------------------------------------------------------------
r26743 | sky@chromium.org | 2009-09-21 23:52:55 +0200 (Mon, 21 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc

~AutocompleteEditViewGtk expects to be the only referencing the
underlying widget. Without this call to Detach we hit a DCHECK.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/208049
------------------------------------------------------------------------
r26742 | finnur@chromium.org | 2009-09-21 23:50:51 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Fix clipping issue on extension shelf (when detached).

BUG=22557
TEST=Open NTP, detach the extension shelf and resize the browser horizontally. Toolstrips should not draw outside the extension shelf border.

Review URL: http://codereview.chromium.org/211046
------------------------------------------------------------------------
r26737 | erg@chromium.org | 2009-09-21 23:42:46 +0200 (Mon, 21 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/About.xib
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm

Make links in the cocoa about dialog clickable. (Try #2).

Once again, we're changing the implementation from an NSTextField to an
NSTextView. The text is no longer editable, the margins have been fixed
to not be standard cocoa margins and the font is explicitly set to
Lucida Grande.

After talking with jrg, I think the text should be selectable.

BUG=20493
BUG=20855

Review URL: http://codereview.chromium.org/216028
------------------------------------------------------------------------
r26727 | thestig@chromium.org | 2009-09-21 22:09:39 +0200 (Mon, 21 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Remove an unused variable and some includes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209043
------------------------------------------------------------------------
r26726 | sky@chromium.org | 2009-09-21 22:01:48 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

Disables the quit menu item for Chrome OS.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/212035
------------------------------------------------------------------------
r26713 | tim@chromium.org | 2009-09-21 21:26:10 +0200 (Mon, 21 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h

Remove syncer_paused from syncapi.

Review URL: http://codereview.chromium.org/217003
------------------------------------------------------------------------
r26710 | shess@chromium.org | 2009-09-21 21:20:35 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.h
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest_helper.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Expose AutocompleteEditViewMac to Cocoa code.

This reduces the number of forwarding/delegate shenanigans we have to
go through.

Review URL: http://codereview.chromium.org/211030
------------------------------------------------------------------------
r26709 | chron@chromium.org | 2009-09-21 21:20:27 +0200 (Mon, 21 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/history/history.cc

Switch history thread back to base::Thread. Sync unit tests require more than one history thread.
We hope to have a hard unit test dependency on buildbot soon, but we need to fix our tests again now.
BUG=22056
Review URL: http://codereview.chromium.org/215023
------------------------------------------------------------------------
r26708 | sky@chromium.org | 2009-09-21 21:03:27 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/app/theme/compactnav_chrome.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/chromeos/main_menu.cc
   M /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

The main menu button is now enabled by default.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/214034
------------------------------------------------------------------------
r26706 | erikkay@chromium.org | 2009-09-21 20:51:21 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

allow the handle to be hidden when moles are expanded

BUG=15494
TEST=none

Review URL: http://codereview.chromium.org/210031
------------------------------------------------------------------------
r26704 | estade@chromium.org | 2009-09-21 20:28:03 +0200 (Mon, 21 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Retry of r26698.

R=stuartmorgan

Review URL: http://codereview.chromium.org/208047
------------------------------------------------------------------------
r26700 | estade@chromium.org | 2009-09-21 19:57:47 +0200 (Mon, 21 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm

Revert a file that slipped into r26699 by mistake.

TBR=stuartmorgan

------------------------------------------------------------------------
r26699 | estade@chromium.org | 2009-09-21 19:41:16 +0200 (Mon, 21 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Reverting r26698. Somehow this broke scons?

TBR=stuartmorgan

Review URL: http://codereview.chromium.org/217004
------------------------------------------------------------------------
r26698 | estade@chromium.org | 2009-09-21 19:27:31 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   D /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   D /trunk/src/chrome/browser/resources/linux-splash.html
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Linux: Remove linux splash page and printing command line switch.

BUG=22295
BUG=19911

Review URL: http://codereview.chromium.org/211036
------------------------------------------------------------------------
r26697 | estade@chromium.org | 2009-09-21 19:25:30 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Revert 23438 which reverted 23408.

see http://codereview.chromium.org/165534

BUG=22302
Review URL: http://codereview.chromium.org/207035
------------------------------------------------------------------------
r26694 | thakis@chromium.org | 2009-09-21 19:08:55 +0200 (Mon, 21 Sep 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Forward edit commands to be executed for shortcuts which aren't handled by
javascript.

As a result, cocoa keybindings work.

The approach:

We instantiate a vanilla NSResponder, call interpretKeyEvents on it, and
record all of the selectors passed into doCommandBySelector while
interpreting the key event.  The selectors are converted into edit commands
which can be passed to the render process.

Caveats:
- Shortcuts involving a sequence of key combinations (chords) don't work,
because we instantiate a new responder for each event.
- We ignore key combinations that don't include a modifier (ctrl, cmd, alt)
because this was causing strange behavior (e.g. tab always inserted a tab
rather than moving to the next field on the page).

BUG=12538
TEST=go to a page with a text field. make sure that ctrl-a moves cursor to beginning of line, ctrl-e goes to the end, ctrl-d deletes to the right, ctrl-h to the left, etc

Review URL: http://codereview.chromium.org/209046
Patch from matt@tolton.com.
------------------------------------------------------------------------
r26688 | brettw@chromium.org | 2009-09-21 18:46:32 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h

Add histograms for tab count, RenderProcessHost count, and the number of
glyph "pages" in memory per load (to check memory consumption).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/195104
------------------------------------------------------------------------
r26687 | thakis@chromium.org | 2009-09-21 18:21:37 +0200 (Mon, 21 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   M /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Task Manager for OS X: Set up columns, show rows.

This is more work-in-progress for the OS X task manager. The table header is complete (the right columns are there, and right-clicking the header gives a column-selection context menu just like in e.g. Task Manager), and the rows data is displayed. However, all the metrics (memory, cpu, etc) seem to be all wrong. Because of this and because too much stuff is still unimplemented (favicons in rows, the "kill process" button, the link, etc), I won't commit the change to MainMenu.xib, so users still won't be able to open this dialog.

BUG=13156
TEST=Connect view->task manager to first responder's commandDispatch:, set the menu item to "enabled", and give the menu item the tag 40005. Now opening the task manager should actually display data. Right-clicking the table header should show a functional menu that lets you select which columns to display. Clicking a column header should not select the column, double-clicking an item should not edit it. Also, when resizing the task manager, stuff should now behave in a sane way.

Review URL: http://codereview.chromium.org/208043
------------------------------------------------------------------------
r26685 | aa@chromium.org | 2009-09-21 18:16:33 +0200 (Mon, 21 Sep 2009) | 394 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

<html>
<style type="text/css">
  <!--
  body { font-family: arial,sans-serif; background-color: #fff; margin-top: 2; }
  .c { width: 4; height: 4; }
  a:link { color: #00c; }
  a:visited { color: #551a8b; }
  a:active { color: #f00; }
  .form-noindent { background-color: #fff; border: 1px solid #c3d9ff; }
  -->
</style>
<style type="text/css"><!--
.gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }

.gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; }
.gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; }

--></style>
  <head>
  <title>Google Accounts</title>
  <style type="text/css"><!--

    body {
      font-family: arial, sans-serif;
      margin: 0;
      padding: 13px 15px 15px;

    }
    .body {
      margin: 0;
    }

    div.errorbox-good {}

    div.errorbox-bad {}

    div.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;}
    font.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;}

    div.topbar {
      font-size:smaller;
      margin-right: -5px;
      text-align:right;
      white-space:nowrap;
    }
    div.header {
      margin-bottom: 9px;
      margin-left: -2px;
      position:relative;
      zoom: 1
    }
    div.header img.logo {
      border: 0;
      float:left;
    }
    div.header div.headercontent {
      float:right;
      margin-top:17px;
    }
    div.header:after{
      content:".";
      display:block;
      height:0;
      clear:both;
      visibility:hidden;
    }
    div.pagetitle {
      font-weight:bold;
    }

    .footer {
      color: #666;
      font-size: smaller;
      margin-top: 40px;
      text-align: center;
    }

    table#signupform {
      left: -5px;
      top: -7px;
      position:relative;
    }
    table#signupform td{
      padding: 7px 5px;
    }
    table#signupform td table td{
      padding: 1px;
    }

    hr {
      border: 0;
      background-color:#DDDDDD;
      height: 1px;
      width: 100%;
      text-align: left;
      margin: 5px;
    }

  --></style>
</head>
  <body dir="ltr"
        onLoad=
                 "gaia_setFocus();"
               >
  <div id="main">
<?sc # for new logo transition ?>
<div class=header>
  <a href='https://www.google.com/accounts/'>
  <img class=logo
       src='https://www.google.com/intl/en/images/logos/accounts_logo.gif'
       alt="Google" />
  </img>
  </a>
</div>
  <div id=maincontent>
  <table border="0" width="100%" cellpadding=0 cellspacing=0>
  <tr>
  <td width="75%" valign="top">
<h3>
  Chromium Code Reviews
  uses Google Accounts for Sign In.
</h3>
<p><font size=-1>
  Google is not affiliated with the contents of
  <b>Chromium Code Reviews</b>
  or its owners. If you sign in, Google will share your email address with
  <b>Chromium Code Reviews</b>,
  but not your password or any other personal information.
</font></p>
<p><font size=-1>
  <b>Chromium Code Reviews</b>
  may use your email address to personalize your experience on their website.
</font></p>
  </td>
  <td style="padding-left: 10px;" valign="top" align="center">
  <div id="rhs">
  <div id="rhs_login_signup_box">
<script><!--

function gaia_onLoginSubmit() {

  if (window.gaiacb_onLoginSubmit) {
    return gaiacb_onLoginSubmit();
  } else {
    return true;
  }

}

function gaia_setFocus() {
  var f = null;
  if (document.getElementById) {
    f = document.getElementById("gaia_loginform");
  } else if (window.gaia_loginform) {
    f = window.gaia_loginform;
  }
  if (f) {
    if (f.Email && (f.Email.value == null || f.Email.value == "")) {
      f.Email.focus();
    } else if (f.Passwd) {
      f.Passwd.focus();
    }
  }
}
--></script>
<style type="text/css"><!--
  div.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; }
  font.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; }
--></style>
<style type="text/css"><!--
.gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; }
.gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }
.gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; }

.gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; }
.gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; }

--></style>
<form id="gaia_loginform"

        action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post"

      onsubmit=
                 "return(gaia_onLoginSubmit());"
                >
<div id="gaia_loginbox">
<table class="form-noindent" cellspacing="3" cellpadding="5" width="100%" border="0">
  <tr>
  <td valign="top" style="text-align:center" nowrap="nowrap"
        bgcolor="#e8eefa">
  <input type="hidden" name="ltmpl"
             value="gm">
  <div class="loginBox">
  <table id="gaia_table" align="center" border="0" cellpadding="1" cellspacing="0">
<tr>
<td colspan="2" align="center">
  <font size="-1">
  Sign in with your
  </font>
  <table>
  <tr>
  <td valign="top">
  <img src="google_transparent.gif"
           alt="Google">
  </img>
  </td>
  <td valign="middle">
  <font size="+0"><b>Account</b></font>
  </td>
  </tr>
</table>
</td>
</tr>
  <script type="text/javascript"><!--
    function onPreCreateAccount() {

      return true;

    }

    function onPreLogin() {

      if (window["onlogin"] != null) {
        return onlogin();
      } else {
        return true;
      }

    }
  --></script>
<tr>
  <td colspan="2" align="center">
  </td>
</tr>
<tr>
  <td nowrap="nowrap">
  <div align="right">
  <span class="gaia le lbl">
  Email:
  </span>
  </div>
  </td>
  <td>
  <input type="hidden" name="continue" id="continue"
           value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" />
  <input type="hidden" name="service" id="service"
           value="ah" />
  <input type="hidden" name="ltmpl" id="ltmpl"
           value="gm" />
  <input type="hidden" name="ltmpl" id="ltmpl"
           value="gm" />
  <input type="hidden" name="ahname" id="ahname"
           value="Chromium Code Reviews" />
  <input type="hidden"
             name="GALX"
             value="LfA4LnZj1gM" />
  <input type="text" name="Email"  id="Email"
  size="18" value=""

    class='gaia le val'

  />
  </td>
</tr>
<tr>
  <td></td>
  <td align="left">
  </td>
</tr>
<tr>
  <td align="right" nowrap="nowrap">
  <span class="gaia le lbl">
  Password:
  </span>
  </td>
  <td>
  <input type="password"
   name="Passwd" id="Passwd"
  size="18"

    class="gaia le val"

  />
  </td>
</tr>
<tr>
  <td>
  </td>
  <td align="left">
  </td>
</tr>
  <tr>
  <td align="right" valign="top">
  <input type="checkbox" name="PersistentCookie" id="PersistentCookie"
    value="yes"

    checked='checked'

  />
  <input type="hidden" name='rmShown' value="1" />
  </td>
  <td>
  <label for="PersistentCookie" class="gaia le rem">
  Stay signed in
  </label>
  </td>
</tr>
<tr>
  <td>
  </td>
  <td align="left">
  <input type="submit" class="gaia le button" name="signIn"
           value="Sign in"
                  />
  </td>
</tr>
<tr id="ga-fprow">
  <td colspan="2" height="33.0" class="gaia le fpwd"
    align="center" valign="bottom">
  <a href="http://www.google.com/support/accounts/bin/answer.py?answer=48598&amp;hl=en&amp;ctx=ch_ServiceLogin&amp;p=ah&amp;fpUrl=https%3A%2F%2Fwww.google.com%2Faccounts%2FForgotPasswd%3FfpOnly%3D1%26continue%3Dhttp%253A%252F%252Fcodereview.chromium.org%252F_ah%252Flogin%253Fcontinue%253Dhttp%253A%252F%252Fcodereview.chromium.org%252F210007%252Fdescription%26service%3Dah%26ltmpl%3Dgm"
       target=_top>
  Can&#39;t access your account?
  </a>
  </td>
</tr>
  </table>
  </div>
  </td>
  </tr>
</table>
</div>
<input type="hidden" name="asts"
       id="asts"
       value="">
</form>
<form id="gaia_universallogin"
      action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post"
      onsubmit="return(gaia_onLoginSubmit());">
  <input type="hidden" name="continue" id="continue"
           value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" />
  <input type="hidden" name="service" id="service"
           value="ah" />
  <input type="hidden" name="ltmpl" id="ltmpl"
           value="gm" />
  <input type="hidden" name="ltmpl" id="ltmpl"
           value="gm" />
  <input type="hidden" name="ahname" id="ahname"
           value="Chromium Code Reviews" />
  <input type="hidden" name="ltmpl" id="ltmpl"
           value="gm" />
</form>
  <br/>
<table class="form-noindent" border="0" cellpadding="6" cellspacing="3" width="100%">
  <tr>
  <td bgcolor="#e8eefa" align="center" style="font-size:83%">
  <b>Don't have a Google Account?
  </b><br/>
  <a href='https://www.google.com/accounts/NewAccount?continue=http%3A%2F%2Fcodereview.chromium.org%2F_ah%2Flogin%3Fcontinue%3Dhttp%3A%2F%2Fcodereview.chromium.org%2F210007%2Fdescription&amp;service=ah&amp;ltmpl=gm&amp;sig=909f6cca8e55250406f8bfbd303ab4a9' >
  <b>Create an account now</b>
  </a>
  </td>
  </tr>
</table>
  </div>
  <br/>
  </div>
  </td>
  </tr>
  </table>
  </div>
<div class="footer">
  &copy;2009 Google
  -
  <a href='http://www.google.com/'>Google Home</a>
  -
  <a href='https://www.google.com/accounts/TOS?hl=en'>Terms of Service</a>
  -
  <a href='http://www.google.com/intl/en/privacy.html'>Privacy Policy</a>
  -
  <a href='http://www.google.com/support/accounts?hl=en'>Help</a>
</div>
  </div>
  </body>
</html>

Review URL: http://codereview.chromium.org/210007
------------------------------------------------------------------------
r26682 | rohitrao@chromium.org | 2009-09-21 17:10:58 +0200 (Mon, 21 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

[Mac] Save/restore focus in TabContentsViewMac.

BUG=http://crbug.com/12556
TEST=Open two tabs.  Focus the omnibox in one, switch tabs and then back again.  Omnibox should still have focus.  Repeat with the findbar instead of the omnibox.
Review URL: http://codereview.chromium.org/206015
------------------------------------------------------------------------
r26681 | avi@chromium.org | 2009-09-21 17:05:46 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/browser/automation/automation_provider_mac.mm (from /trunk/src/chrome/browser/automation/automation_provider_gtk.cc:26575)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Adding basic window control to the automation provider for the Mac.

BUG=http://crbug.com/16616
TEST=as described in bug.

Review URL: http://codereview.chromium.org/216024
------------------------------------------------------------------------
r26668 | sky@chromium.org | 2009-09-21 01:26:02 +0200 (Mon, 21 Sep 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/main_menu.cc
   A /trunk/src/chrome/browser/chromeos/main_menu.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/chrome.gyp

Changes the main menu from displaying a static image to loading a page.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/208034
------------------------------------------------------------------------
r26664 | thakis@chromium.org | 2009-09-20 04:06:37 +0200 (Sun, 20 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Only show extension shelf on demand again.

This caused the perf regression, so the ext shelf can stay on.

TBR: mark@chromium.org
------------------------------------------------------------------------
r26663 | thakis@chromium.org | 2009-09-20 03:37:50 +0200 (Sun, 20 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Temporarily always show extension shelf.

This is to check if this caused the perf startup regression.

TBR: mark@chromium.org
------------------------------------------------------------------------
r26658 | erikkay@chromium.org | 2009-09-19 22:59:12 +0200 (Sat, 19 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc

remove the right-click devtools behavior

BUG=20634
TEST=right click on a toolstrip, nothing should happen
TBR=aa

Review URL: http://codereview.chromium.org/211038
------------------------------------------------------------------------
r26656 | thakis@chromium.org | 2009-09-19 21:57:17 +0200 (Sat, 19 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Turn os x extension shelf on.

I can't reproduce the startup perf regression locally after syncing, so I will do some experiments on trunk. If this regresses, I'll submit a different experiment later today, and then revert this completely by the end of this day.

TBR=mmentovai

Review URL: http://codereview.chromium.org/215028
------------------------------------------------------------------------
r26654 | erikkay@chromium.org | 2009-09-19 21:31:51 +0200 (Sat, 19 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/renderer/resources/extension_toolstrip.css (from /trunk/src/chrome/browser/resources/extensions_toolstrip.css:26652)
   M /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html

Change the view mode when switching between moles and toolstrips, and
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.

BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26635

Review URL: http://codereview.chromium.org/208020
------------------------------------------------------------------------
r26646 | rsesek@chromium.org | 2009-09-19 03:54:23 +0200 (Sat, 19 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/EditSearchEngine.xib
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/nswindow_local_state.h
   A /trunk/src/chrome/browser/cocoa/nswindow_local_state.mm
   A /trunk/src/chrome/browser/cocoa/nswindow_local_state_unittest.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc
   M /trunk/src/chrome/browser/search_engines/keyword_editor_controller.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

[Mac] Polish the search engine manager

* Make the edit search engine window a sheet.
* Only allow one instance of the search engine manager to be opened at once.
* The search engine manager now remembers its position.
* Create NSWindow(LocalStateAdditions) category to assist with storing window
  position in Chromium's local state.

BUG=21761,21762,21883,21996
TEST=Editing/adding a search engine happens in a sheet. Press [Manage] multiple times and only 1 window should open. Press [Manage] and the window should be at its last position.

Review URL: http://codereview.chromium.org/207027
------------------------------------------------------------------------
r26644 | thakis@chromium.org | 2009-09-19 03:32:09 +0200 (Sat, 19 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Do not automatically show extension shelf.

But leave it off for now, as it regresses startup performance by 20ms / ~5%.

BUG=none
TEST=Compile in the extension shelf. It now only shows up if you have extensions installed, the shelf shows up, else it doesn't.

Review URL: http://codereview.chromium.org/211035
------------------------------------------------------------------------
r26642 | mattm@chromium.org | 2009-09-19 03:26:31 +0200 (Sat, 19 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Add gtk widget names for stuff in location bar.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/215004
------------------------------------------------------------------------
r26638 | estade@chromium.org | 2009-09-19 02:32:37 +0200 (Sat, 19 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc

Fix my view id util browsertest breakage.

TBR=mbelshe

Review URL: http://codereview.chromium.org/214027
------------------------------------------------------------------------
r26636 | mbelshe@google.com | 2009-09-19 00:51:17 +0200 (Sat, 19 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   A /trunk/src/chrome/browser/resources/extensions_toolstrip.css (from /trunk/src/chrome/browser/resources/extensions_toolstrip.css:26634)
   D /trunk/src/chrome/browser/resources/extensions_toolstrip_theme.css
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   D /trunk/src/chrome/renderer/resources/extensions_toolstrip.css
   M /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html

Revert 26635 - Change the view mode when switching between moles and toolstrips, and
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.

BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close

Review URL: http://codereview.chromium.org/208020

TBR=erikkay@chromium.org

Review URL: http://codereview.chromium.org/210024
------------------------------------------------------------------------
r26635 | erikkay@chromium.org | 2009-09-19 00:29:32 +0200 (Sat, 19 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   D /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   A /trunk/src/chrome/browser/resources/extensions_toolstrip_theme.css
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/renderer/resources/extensions_toolstrip.css (from /trunk/src/chrome/browser/resources/extensions_toolstrip.css:26634)
   M /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html

Change the view mode when switching between moles and toolstrips, and
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.

BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close

Review URL: http://codereview.chromium.org/208020
------------------------------------------------------------------------
r26633 | mattm@chromium.org | 2009-09-19 00:18:20 +0200 (Sat, 19 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/views/widget/widget_win.h

Fix BrowserFrameWin::OnMoving bad_override coverity error.

BUG=17104

Review URL: http://codereview.chromium.org/208019
------------------------------------------------------------------------
r26629 | phajdan.jr@chromium.org | 2009-09-18 23:57:49 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Fix coverity issue found in flaky DownloadTest, which should also decrease flakiness.

Big thanks to mattm for finding the issue!

TEST=none
BUG=20809

Review URL: http://codereview.chromium.org/209033
------------------------------------------------------------------------
r26627 | mdm@chromium.org | 2009-09-18 23:45:54 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc

Move the --type=plugin and --plugin-path arguments to the beginning of the argument list for plugin processes.
BUG=22262
TEST=none

Review URL: http://codereview.chromium.org/212021
------------------------------------------------------------------------
r26625 | erikkay@chromium.org | 2009-09-18 23:42:19 +0200 (Fri, 18 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Change BrowserBubble to use Close instead of CloseNow.  This should make
it less susceptible to crashes in certain use cases.
Remove a delay in destroying the widget that was added to work around
the old crash.

BUG=18248
TEST=none

Review URL: http://codereview.chromium.org/211027
------------------------------------------------------------------------
r26624 | estade@chromium.org | 2009-09-18 23:39:35 +0200 (Fri, 18 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

GTK: Download item as drag source.

BUG=21656
TEST=Drag a completed download onto the desktop, or into the tabstrip, or wherever

Review URL: http://codereview.chromium.org/215002
------------------------------------------------------------------------
r26623 | estade@chromium.org | 2009-09-18 23:39:16 +0200 (Fri, 18 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/view_id_util.cc
   M /trunk/src/chrome/browser/gtk/view_id_util.h

GTK: Add a bunch more widget names for parasite.

Also, change slightly how we apply custom styles to certain buttons.

BUG=22096

Review URL: http://codereview.chromium.org/210019
------------------------------------------------------------------------
r26620 | shess@chromium.org | 2009-09-18 23:21:50 +0200 (Fri, 18 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Paste in Omnibox needs to initiate field editing correctly.

We override -paste: to do Chrome-specific stuff.  This circumvents
certain Cocoa-standard setup which happens when user's edit text
views, and elsewhere we depend on that setup being right.  This
changes our code to participate in that setup process.

http://crbug.com/21301
TEST=Copy "raising arizona" to the clipboard.  Put focus in the NTP
(Omnibox field does not have focus ring).  Click in Omnibox field and
paste.  Should now see autocomplete popup.

Review URL: http://codereview.chromium.org/213029
------------------------------------------------------------------------
r26617 | mdm@chromium.org | 2009-09-18 23:15:54 +0200 (Fri, 18 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Linux: avoid browser windows moving around by the size of WM decorations over restart.
Use a debounce timer to get the true window position shortly after the last reconfigure event is delivered, and save that.
BUG=18771
TEST=none

Review URL: http://codereview.chromium.org/203027
------------------------------------------------------------------------
r26609 | cira@chromium.org | 2009-09-18 23:07:39 +0200 (Fri, 18 Sep 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.h
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.h
   M /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_message_bundle.cc
   A /trunk/src/chrome/browser/extensions/extension_message_bundle.h
   A /trunk/src/chrome/browser/extensions/extension_message_bundle_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en_US/messages.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/sr/messages.json

CL is the same as http://codereview.chromium.org/173487, but had to be moved to new CL number because I switched machines.

Implemented the rest of loading/parsing logic for extension i18n:

1. Loading message catalogs for default and application locale.
2. Parsing JSON and replacing placeholders with actual content within a message.
3. Creating unified dictionary (union of default and application dictionaries,
where application dict. has priority for common messages).

New class ExtensionMessageBundle holds new dictionary, and parses data. It's
injected into Extension.

ExtensionMessageHandler::ReplaceVariablesInString can replace both
$placeholders$ and __MSG_messages__ in given string (HTML, manifest, actual
message string...).

Implemented actual manifest name/description replacement too, as an example.

Extension is now pretty agnostic about localization, and this makes it easier to use message bundles
with things that are not extensions...

BUG=12131

Review URL: http://codereview.chromium.org/202063
------------------------------------------------------------------------
r26608 | pinkerton@chromium.org | 2009-09-18 23:07:19 +0200 (Fri, 18 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Get rid of a few NOTIMPLEMENTEDs in the scaffolding.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209035
------------------------------------------------------------------------
r26607 | mattm@chromium.org | 2009-09-18 23:07:19 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc

Fix check for wr_list validity not covering entire use.

(Coverity FORWARD_NULL error CID 6043.)

BUG=17101
TEST=none

Review URL: http://codereview.chromium.org/209038
------------------------------------------------------------------------
r26603 | rohitrao@chromium.org | 2009-09-18 21:35:46 +0200 (Fri, 18 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

[Mac] Implement Paste and Go/Search.

BUG=http://crbug.com/10937
BUG=http://crbug.com/13021
TEST=Omnibox context menu should contain paste and go/search.
Review URL: http://codereview.chromium.org/192008
------------------------------------------------------------------------
r26597 | jcampan@chromium.org | 2009-09-18 20:54:35 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

This CL makes the browser focus tests faster by replacing
some time-outs with notifications.

BUG=22065
TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal*
     These tests should run in few seconds.

Review URL: http://codereview.chromium.org/210013
------------------------------------------------------------------------
r26592 | erg@google.com | 2009-09-18 20:02:32 +0200 (Fri, 18 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Revert "Extensions: tab.title should not be undefined."

On vista, this change hard breaks tab.title in extensions.

This reverts commit cabda9d732b49ed018821772398d732bbc1af75a (r26586).

TBR=rafaelw

Review URL: http://codereview.chromium.org/207032
------------------------------------------------------------------------
r26590 | phajdan.jr@chromium.org | 2009-09-18 19:55:55 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc

More reliably find the .desktop file for the browser.

Also search in "applications" subdirectory of each of XDG_DATA_DIRS.

TEST=See bug.
BUG=21995

Review URL: http://codereview.chromium.org/214010
------------------------------------------------------------------------
r26589 | paul@chromium.org | 2009-09-18 19:47:54 +0200 (Fri, 18 Sep 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h

Fix a crash canceling a completed, auto-opened download.

To reproduce this crash:
1. Set 'Always open files of this type' on the download shelf
   menu to checked for a particular file type.
2. Download a large file of that type.
3. Before the download completes, open its context menu on
   the shelf.
4. When the download completes, select 'Cancel' from the menu.
5. Crash.

The crash occurs because auto-opened downloads automatically
remove (and thus delete) themselves from the shelf even if
the menu is still running. Selecting a menu item at this point
will attempt to access the deleted object.

The fix is to let the menu know when the calling object is
becoming invalid, so we can avoid doing any further work.

BUG=20810
TEST=Try the above repro steps and notice that Chrome doesn't crash.

Review URL: http://codereview.chromium.org/213018
------------------------------------------------------------------------
r26587 | tony@chromium.org | 2009-09-18 19:40:10 +0200 (Fri, 18 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

Size the render widget host view when the browser tries to set it to a particular size.

BUG=21942
TEST=On Linux chrome, load a #anchor page in the background.  After
  the page loads, view the tab.  It should be scrolled to the right
  place.

Review URL: http://codereview.chromium.org/214002

------------------------------------------------------------------------
r26586 | erg@google.com | 2009-09-18 19:39:10 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Extensions: tab.title should not be undefined.

(If you request tab information while the page is loading, the tab.title is undefined and it shouldn't be.)

Review URL: http://codereview.chromium.org/196125
------------------------------------------------------------------------
r26583 | tony@chromium.org | 2009-09-18 19:11:36 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc

Remove the intializaton of the Download Manager when bringing up
the options dialog.  This was done a long long time ago because
we used to register the download dir pref in the Download Manager
constructor.  Since that's no longer the case, we don't need to
intialize the Download Manager.

Review URL: http://codereview.chromium.org/208021

------------------------------------------------------------------------
r26582 | tony@chromium.org | 2009-09-18 19:10:57 +0200 (Fri, 18 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

Set the parent of BookmarkContextMenu to be the browser window, not
the menu which is just going away.  This makes it consistent with
the edit dialog that comes up when editing directly on the toolbar.

Review URL: http://codereview.chromium.org/213015

------------------------------------------------------------------------
r26575 | phajdan.jr@chromium.org | 2009-09-18 18:29:53 +0200 (Fri, 18 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.h

Various cleanups FTP-related.

- use better name for FTP LIST parsing code in about:credits
- don't open a second data socket
- add a comment explaining why we close the data socket at one point

TEST=Covered by net_unittests.
BUG=none

Review URL: http://codereview.chromium.org/207014
------------------------------------------------------------------------
r26573 | pinkerton@chromium.org | 2009-09-18 18:24:24 +0200 (Fri, 18 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm

Switch to using vkey constants rather than hardcoded decimal values
BUG=none
TEST=switching tabs via key combos should still work.
Review URL: http://codereview.chromium.org/209031
------------------------------------------------------------------------
r26567 | rohitrao@chromium.org | 2009-09-18 17:17:26 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FindBar.xib
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm

[Mac] Adds animations to the findbar.

BUG=http://crbug.com/14908
TEST=Findbar should animate open and closed, unless switching tabs.
Review URL: http://codereview.chromium.org/195105
------------------------------------------------------------------------
r26566 | rohitrao@chromium.org | 2009-09-18 17:17:06 +0200 (Fri, 18 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

[Mac] Disable autoresizing of subviews when going into and out of fullscreen
mode.  This will prevent spurious renderer resizes and reduce flicker.

BUG=http://crbug.com/21666
TEST=Layout of www.google.com should not be messed up after exiting fullscreen
mode.
Review URL: http://codereview.chromium.org/210011
------------------------------------------------------------------------
r26563 | sky@chromium.org | 2009-09-18 15:53:15 +0200 (Fri, 18 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Lands http://codereview.chromium.org/203029 for Thiago:

[Windows] Bookmark-menu button should be themed like any other menu button. 
Command: 
$ chrome --bookmark-menu 

BUG=18954
TEST=open chrome/chromium with --bookmark-menu switch in the command line, apply a theme, see if the bookmark-menu 
is themed? Reset to default theme, see if the bookmark-menu come backs
to default state.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/208017
------------------------------------------------------------------------
r26562 | yurys@google.com | 2009-09-18 15:43:17 +0200 (Fri, 18 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: don't duplicate eval scripts on each panel switch. 
Review URL: http://codereview.chromium.org/211012
------------------------------------------------------------------------
r26560 | thomasvl@chromium.org | 2009-09-18 15:01:46 +0200 (Fri, 18 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   D /trunk/src/chrome/browser/cocoa/autoseparating_menu.h
   D /trunk/src/chrome/browser/cocoa/autoseparating_menu.m
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Remove the theme popup menu and just have a reset button to match the other platforms.  This avoids us needed extra localization strings, and we'll look to pick up any new UI when it's done for all platforms.
Remove the autoseparating_menu since it is no longer used.

TEST=Prefs just has a reset button and no theme popup list.
BUG=none
Review URL: http://codereview.chromium.org/214011
------------------------------------------------------------------------
r26559 | pinkerton@chromium.org | 2009-09-18 14:52:46 +0200 (Fri, 18 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Allow popup windows to have a title displayed in the titlebar.
BUG=17918
TEST=popups get a title, nobody else does. Expose should show title.
Review URL: http://codereview.chromium.org/209020
------------------------------------------------------------------------
r26556 | aa@chromium.org | 2009-09-18 11:47:35 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc
   A /trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h
   A /trunk/src/chrome/browser/extensions/execute_script_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   A /trunk/src/chrome/test/data/extensions/api_test/executescript
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/1.css
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/1.css~
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/script1.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/script2.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/script3.js
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/executescript/test_executescript.html

Try again to land "Implement script API:executeScript"
http://codereview.chromium.org/173556

TBR=mpcomplete@chromium.org
Patch from Jerry Tang <tangjie@google.com>.
------------------------------------------------------------------------
r26544 | suzhe@chromium.org | 2009-09-18 05:43:34 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Implement GetCurrentCountryID() for Linux.

This CL implements GetCurrentCountryID() function for Linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/203079
------------------------------------------------------------------------
r26543 | bradnelson@google.com | 2009-09-18 05:01:21 +0200 (Fri, 18 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/app/chrome_dll_main.cc
   D /trunk/src/chrome/browser/nacl_process_host.cc
   D /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   D /trunk/src/chrome/common/nacl_messages.h
   D /trunk/src/chrome/common/nacl_messages_internal.h
   D /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   D /trunk/src/chrome/nacl
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

Preparing rollback in case things don't work out.
This rolls back 26540, gregoryd's attempt at a nacl landing.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/213019
------------------------------------------------------------------------
r26540 | gregoryd@google.com | 2009-09-18 03:46:27 +0200 (Fri, 18 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/format_macros.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/browser/nacl_process_host.cc
   A /trunk/src/chrome/browser/nacl_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/nacl_messages.h
   A /trunk/src/chrome/common/nacl_messages_internal.h
   A /trunk/src/chrome/common/nacl_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   A /trunk/src/chrome/nacl
   A /trunk/src/chrome/nacl/nacl_main.cc
   A /trunk/src/chrome/nacl/nacl_thread.cc
   A /trunk/src/chrome/nacl/nacl_thread.h
   A /trunk/src/chrome/nacl/sel_main.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc

This is a copy of http://codereview.chromium.org/153002/show
First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required

TBR=bradnelson

Review URL: http://codereview.chromium.org/207025
------------------------------------------------------------------------
r26536 | paul@chromium.org | 2009-09-18 03:01:19 +0200 (Fri, 18 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Fix a bug where we access a view after deletion.

When the download shelf menu option 'Remove' is chosen,
the view is removed and deleted (along with the object
representing the download) so we must not access them
after the removal.

This CL NULLs the download pointer in the menu to
prevent any futher access.

BUG=20810
TEST=Remove an item from the download shelf and Chrome
     should not crash.
Review URL: http://codereview.chromium.org/216018
------------------------------------------------------------------------
r26531 | estade@chromium.org | 2009-09-18 02:47:38 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc

Linux Printing: Move file open operation to file thread.

Also delete the temp file when we're done with it (usually).

BUG=22097
TEST=printing still works

Review URL: http://codereview.chromium.org/215015
------------------------------------------------------------------------
r26529 | sidchat@chromium.org | 2009-09-18 02:44:58 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h

Language detection works only for Windows now. Make chrome.tabs.detectLanguage return default (English) for non-Windows OS. Review URL: http://codereview.chromium.org/199064

BUG=www.crbug.com/20692
TEST=none

------------------------------------------------------------------------
r26528 | agl@chromium.org | 2009-09-18 02:44:53 +0200 (Fri, 18 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/net/base/strict_transport_security_state.cc
   M /trunk/src/net/base/strict_transport_security_state.h
   M /trunk/src/net/base/strict_transport_security_state_unittest.cc

Revert "Strict transport security: add checkbox to clear state."

This reverts commit r25955.

------------------------------------------------------------------------
r26527 | thakis@chromium.org | 2009-09-18 02:43:26 +0200 (Fri, 18 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

Let arrow up/down in find bar scroll page.

This now matches both windows _and_ common sense.

BUG=none as far as I know
TEST=Go to a web page with scrollbar (e.g. en.wikipedia.org), focus find bar hit arrow up/down. Page should now scroll.

Review URL: http://codereview.chromium.org/212012
------------------------------------------------------------------------
r26526 | finnur@chromium.org | 2009-09-18 02:42:57 +0200 (Fri, 18 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

While fixing bug 22070 (Toolstrip theme background not updated when resizing Chrome window) I added code to trigger repainting the background on resize. This flushed out a problem (Skia exceptions) that was causing the extension tests to become flaky on the bots (bug 22135). I've changed the code to do a deep copy on the subset bitmap we get before passing it down to the renderer, which causes Skia to not go haywire when drawing the background.

That makes it possible to fix bug 22070, which now causes the background to be updated on resize. There is also now no need to set the background_needs_repaint_ flag to true before calling Layout. We also don't need to keep track of whether we are detached or not, we just need to monitor the background_needs_repaint_ flag.

BUG=22070, 22135
TEST=Monitor the bots and see if the tests become flaky again.
Review URL: http://codereview.chromium.org/215017
------------------------------------------------------------------------
r26520 | tommi@chromium.org | 2009-09-18 00:56:00 +0200 (Fri, 18 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

Retry that check for nullness in url request automation job.

TEST=run automation tests.
BUG=none

Review URL: http://codereview.chromium.org/210012
------------------------------------------------------------------------
r26513 | shess@chromium.org | 2009-09-18 00:29:31 +0200 (Fri, 18 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/visit_database.cc

Some history backend fixes for database corruption.

Don't enter an infinite loop in GetLastSegmentID() when traversing the
referring_visit list.  Don't return rows from visits table where a
specific visit_id was passed but some other visit_id was returned.
Don't update visits table with rows who's referring_visit refers to
the visit itself.

BUGS=20321
TEST=Don't hang with Kelly's profile.  I guess Kelly could test?

Review URL: http://codereview.chromium.org/206041
------------------------------------------------------------------------
r26511 | sky@chromium.org | 2009-09-18 00:28:22 +0200 (Fri, 18 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.cc
   M /trunk/src/chrome/browser/chromeos/touchpad.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   A /trunk/src/views/controls/slider
   A /trunk/src/views/controls/slider/native_slider_gtk.cc
   A /trunk/src/views/controls/slider/native_slider_gtk.h
   A /trunk/src/views/controls/slider/native_slider_wrapper.h
   A /trunk/src/views/controls/slider/slider.cc
   A /trunk/src/views/controls/slider/slider.h
   M /trunk/src/views/views.gyp

Lands http://codereview.chromium.org/211002 for Charlie:

Add touchpad speed factor setting to Chrome OS touchpad settings page.
Created slider widget with native gtk widget.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/209016
------------------------------------------------------------------------
r26507 | sgk@google.com | 2009-09-18 00:23:44 +0200 (Fri, 18 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/app_controller_mac_unittest.mm

Stylistic fixes in the new dock menu code:
* Initialize variables when declared.
* Descriptive name (dock_menu) for the returned value.
* Use a scoped_nsobject in the unit test, not autorelease.
BUG=none
TEST=AppControllerTest.DockMenu
Review URL: http://codereview.chromium.org/200126
------------------------------------------------------------------------
r26502 | pkasting@chromium.org | 2009-09-18 00:12:18 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

Fix the Linux Views build, sigh.  We need a trybot.

BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/209024
------------------------------------------------------------------------
r26500 | hclam@chromium.org | 2009-09-18 00:07:18 +0200 (Fri, 18 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc

Pause for <video> should have immediate effect on audio

BUG=20351

A bug found while fixing mac audio. IPCAudioSouce transist to a
wrong state after Play() is called. Resulting to pause having
no effect. This will solve the problem of audio keeps playing
a while after it is paused.

Review URL: http://codereview.chromium.org/193095
------------------------------------------------------------------------
r26497 | pkasting@chromium.org | 2009-09-18 00:04:33 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h

Try to make ImageBubbles draw correctly on Linux Views as well.  This also fixes an error in the window region calculation (I used right()/bottom() where I should have used width()/height()) and updates some comments and variable names in the hope of more clarity.

BUG=21028
TEST=Look at image bubbles on Linux Views
Review URL: http://codereview.chromium.org/207021
------------------------------------------------------------------------
r26496 | thestig@chromium.org | 2009-09-18 00:03:25 +0200 (Fri, 18 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

prefs::kDownloadDefaultDirectory should always be initialized in DownloadManager::RegisterUserPrefs, remove code that assumes otherwise.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209003
------------------------------------------------------------------------
r26495 | pinkerton@chromium.org | 2009-09-17 23:55:02 +0200 (Thu, 17 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm

Hook up cmd-0..8 as "select Nth tab" and cmd-9 as "select last tab".
BUG=none
TEST=as described.
Review URL: http://codereview.chromium.org/212009
------------------------------------------------------------------------
r26491 | estade@chromium.org | 2009-09-17 23:45:48 +0200 (Thu, 17 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h

GTK: Get rid of default drag icon for tab drags.

I guess this regressed at some point.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/209002
------------------------------------------------------------------------
r26490 | mdm@chromium.org | 2009-09-17 23:43:19 +0200 (Thu, 17 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Ignore remote requests to open tabs that would open external protocol handlers.
BUG=21934
TEST=none

Review URL: http://codereview.chromium.org/213003
------------------------------------------------------------------------
r26488 | thomasvl@chromium.org | 2009-09-17 23:41:04 +0200 (Thu, 17 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/About.xib
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Reverting 26482.

relied on making the field editable which really doesn't work for legal text you show a user

BUG=20493
BUG=20855
BUG=22179
BUG=22180
Review URL: http://codereview.chromium.org/212010
------------------------------------------------------------------------
r26486 | tommi@chromium.org | 2009-09-17 23:30:56 +0200 (Thu, 17 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

revert bad merge.

------------------------------------------------------------------------
r26485 | tommi@chromium.org | 2009-09-17 23:10:11 +0200 (Thu, 17 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

Fix a dlog that could dereference a null pointer.

TEST=run automation tests.
BUG=non

Review URL: http://codereview.chromium.org/207017
------------------------------------------------------------------------
r26483 | evan@chromium.org | 2009-09-17 23:00:18 +0200 (Thu, 17 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc

linux: expose the ProcessSingleton timeout to speed tests

We have a 20-second timeout normally, but for testing purposes 1 second is
plenty.

Review URL: http://codereview.chromium.org/209018
------------------------------------------------------------------------
r26482 | erg@chromium.org | 2009-09-17 22:56:45 +0200 (Thu, 17 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/About.xib
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Make links in the cocoa about dialog clickable.

This replaces an NSTextField with an NSTextView so the file owner
can implement some of NSTextView's delegate interface to respond
to links.

While we're here, also add an additional newline between the main text and the Google build's terms and conditions.

BUG=20493
BUG=20855

Review URL: http://codereview.chromium.org/203084
------------------------------------------------------------------------
r26480 | mark@chromium.org | 2009-09-17 22:44:13 +0200 (Thu, 17 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/spellchecker_mac.mm

Use NSApp in preference to [NSApplication sharedApplicaton]

BUG=0
TEST={}
Review URL: http://codereview.chromium.org/207001
------------------------------------------------------------------------
r26479 | mark@chromium.org | 2009-09-17 22:43:24 +0200 (Thu, 17 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm

Fix a few pasteboard-related things in the Mac unit_tests.  Most of these
changes are non-functional or minimally functional.  There are a couple of
functional changes in here too.  Hopefully this will resolve some of the
Valgrind failures.

BUG=21479
TEST=unit_tests
Review URL: http://codereview.chromium.org/210006
------------------------------------------------------------------------
r26477 | mark@chromium.org | 2009-09-17 22:43:06 +0200 (Thu, 17 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/cocoa_protocols_mac.h
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h

Use delegate protocols present in the 10.6 SDK.  For previous SDKs, provide
empty protocol definitions for compatibility.

BUG=20925
TEST=build
Review URL: http://codereview.chromium.org/209004
------------------------------------------------------------------------
r26476 | timurrrr@chromium.org | 2009-09-17 22:36:29 +0200 (Thu, 17 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/net/base/host_resolver.h

Fixed a few data races on reference counters.
BUG=18488
Review URL: http://codereview.chromium.org/215011
------------------------------------------------------------------------
r26460 | yurys@google.com | 2009-09-17 19:57:05 +0200 (Thu, 17 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: temporary disable TestConsoleLog and TestEvalGlobal that would fail with next WebKit roll.
Review URL: http://codereview.chromium.org/208009
------------------------------------------------------------------------
r26446 | nsylvain@chromium.org | 2009-09-17 17:31:55 +0200 (Thu, 17 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable ExtensionViews and toolstrip browser tests because
they crash all the time on the new vista bot (in skia).

BUG:22135
Review URL: http://codereview.chromium.org/209015
------------------------------------------------------------------------
r26439 | maruel@chromium.org | 2009-09-17 14:36:52 +0200 (Thu, 17 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc

Fix EOL inconsistency on extension_message_service.cc.

NO CODE CHANGE.

The presubmit check should have warned you. Please listen to it. This causes breakage on the try slaves because SVN is too stupid to revert a file with inconsistent EOL, go figure.

TBR=mpcomplete
TEST=none
BUG=none
------------------------------------------------------------------------
r26424 | evan@chromium.org | 2009-09-17 02:35:13 +0200 (Thu, 17 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

linux: add names to some widgets for parasite's benefit

Review URL: http://codereview.chromium.org/212002
------------------------------------------------------------------------
r26420 | agl@chromium.org | 2009-09-17 01:59:55 +0200 (Thu, 17 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/browser/outdated_plugins.cc
   D /trunk/src/chrome/browser/outdated_plugins.h
   D /trunk/src/chrome/browser/outdated_plugins_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Revert "Windows: Warn about outdated plugins."

This reverts commit r26409.

------------------------------------------------------------------------
r26418 | estade@chromium.org | 2009-09-17 01:33:34 +0200 (Thu, 17 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

GTK: Don't put a blank line in the tooltip for nameless bookmark bar bookmarks.

Man, why is it so hard to get this right??

BUG=none
TEST=look at tooltips for a bookmark that has
a) no title
b) no url (folder)
c) both title and url
Review URL: http://codereview.chromium.org/207003
------------------------------------------------------------------------
r26413 | suzhe@chromium.org | 2009-09-17 01:00:09 +0200 (Thu, 17 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Fix a crash issue of AutocompleteEditViewTest.

This CL fixes a crash issue of AutocompleteEditViewTest, which is due to not waiting for bookmark model and history service being fully loaded.

BUG=21971
TEST=none

Review URL: http://codereview.chromium.org/201135
------------------------------------------------------------------------
r26409 | agl@chromium.org | 2009-09-17 00:44:34 +0200 (Thu, 17 Sep 2009) | 47 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/outdated_plugins.cc
   A /trunk/src/chrome/browser/outdated_plugins.h
   A /trunk/src/chrome/browser/outdated_plugins_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Windows: Warn about outdated plugins.

Add the infrastructure for detecting out of date plugins and warning
the user about them.

Glen was ok with the infobar, although he notes that there will be a
better 'notifications' UI for this sort of thing in the future.

This UI will trigger at most once a day and only when we load the
plugin information.

This patch appears to duplicate some information from plugins2.xml,
which is the plugins database that the default plugin uses to install
missing plugins. I'm not reusing that information in this patch:
  * Note that the names of the plugins are different between the two.
    plugins2.xml uses a 'friendly' name, while this code needs to know
    the name that the plugin itself uses.
  * Also note that URLs are different. plugins2.xml wants a link to an
    exe for the installer, while we want a landing page.
  * The code for loading and parsing plugins2.xml is in the default
    plugin, and thus would require a lot of major refactoring to use
    here.

Regarding the second point, above. One could imagine that we open a
tab to "about:update-plugin#MAGICSTRING,application/x-shockwave".
Javascript on that page notes the fragment in the URL and creates a
plugin of the correct type on the page, passing MAGICSTRING to the
plugin. The renderers are updated to know that all plugins on about
pages should be directed to the default plugin.

The default plugin notes the MAGICSTRING argument and uses a new NPAPI
call to validate the string. MAGICSTRING will be a random string,
created once per instance which is needed so that the default plugin
can know that it's running on behalf of the browser, not some random
webpage. When it validates, it doesn't wait for the user to click
inside the plugin to trigger the download. It also doesn't trigger a
page reload afterwards, instead draws text to the effect of
"Successful install".

This alternative design would remove the duplication, at the cost of a
lot of work. Since it's a UI question, I asked Ben and Glen. However,
they didn't get back to me so, for now at least, this simplier
solution will suffice.

BUG=21100
http://codereview.chromium.org/197053

------------------------------------------------------------------------
r26407 | tim@chromium.org | 2009-09-17 00:33:33 +0200 (Thu, 17 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc

Handle some startup errors encountered by ModelAssociator (such as 
unable to find tagged nodes) more gracefully by triggering the
unrecoverable error handler. 

This was in response to a suggestion from chron, as we seem to hit this case a fair bit, and crashing is a pain. More importantly it's possible users are hitting it as well and having an explicit error case / message hidden on the options dialog is better than silently failing with no inkling as to what happened.  It also just seems preferable to be in the PSS error state when this happens.


Review URL: http://codereview.chromium.org/201119
------------------------------------------------------------------------
r26402 | pkasting@chromium.org | 2009-09-17 00:01:50 +0200 (Thu, 17 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

Try to fix Linux Views build.

------------------------------------------------------------------------
r26401 | estade@chromium.org | 2009-09-16 23:49:56 +0200 (Wed, 16 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/gtk_util.cc

Escape ampersands in web view text selection for right click context menu so that they don't show up as mnemonics.

Also escape underscores in gtk menus so they don't show up as mnemonics (we use ampersands to match windows).

BUG=14587

Review URL: http://codereview.chromium.org/203078
------------------------------------------------------------------------
r26400 | estade@chromium.org | 2009-09-16 23:49:46 +0200 (Wed, 16 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/printing/print_dialog_gtk.cc
   A /trunk/src/chrome/browser/printing/print_dialog_gtk.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

GTK: Add a dialog for printing.

Add an infobar directing users to tell us if they have problems with printing.

Hide printing behind --enable-printing flag on linux/gtk.

BUG=9847
TEST=none
Review URL: http://codereview.chromium.org/200138
------------------------------------------------------------------------
r26397 | michaeln@google.com | 2009-09-16 23:36:44 +0200 (Wed, 16 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h

Gears File Drag Drop

r24899 now keys the child security policy database based on 
renderer id, rather than renderer process id. Update gears 
drag drop to use the renderer id for the file policy access 
checks. 

This is a clone for submission of of noel's original CL
http://codereview.chromium.org/195079

BUG=7995


Review URL: http://codereview.chromium.org/196145
------------------------------------------------------------------------
r26396 | tony@chromium.org | 2009-09-16 23:36:20 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   A /trunk/src/chrome/browser/tab_contents/test_tab_contents.cc (from /trunk/src/chrome/browser/tab_contents/test_web_contents.cc:26391)
   A /trunk/src/chrome/browser/tab_contents/test_tab_contents.h (from /trunk/src/chrome/browser/tab_contents/test_web_contents.h:26391)
   D /trunk/src/chrome/browser/tab_contents/test_web_contents.cc
   D /trunk/src/chrome/browser/tab_contents/test_web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Rename test_web_contents.* to test_tab_contents.*

Just a small cleanup.

Review URL: http://codereview.chromium.org/206037

------------------------------------------------------------------------
r26394 | pkasting@chromium.org | 2009-09-16 23:33:45 +0200 (Wed, 16 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/theme/bubble_b.png
   A /trunk/src/chrome/app/theme/bubble_b_arrow.png
   M /trunk/src/chrome/app/theme/bubble_bl.png
   M /trunk/src/chrome/app/theme/bubble_br.png
   D /trunk/src/chrome/app/theme/bubble_corner_bl.png
   D /trunk/src/chrome/app/theme/bubble_corner_br.png
   D /trunk/src/chrome/app/theme/bubble_corner_tl.png
   D /trunk/src/chrome/app/theme/bubble_corner_tr.png
   M /trunk/src/chrome/app/theme/bubble_l.png
   M /trunk/src/chrome/app/theme/bubble_r.png
   M /trunk/src/chrome/app/theme/bubble_t.png
   A /trunk/src/chrome/app/theme/bubble_t_arrow.png
   M /trunk/src/chrome/app/theme/bubble_tl.png
   M /trunk/src/chrome/app/theme/bubble_tr.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/bubble_positioner.h
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc

Convert InfoBubble to using BubbleBorder.  This also replaces the border graphics with a slightly darker set from Nicholas.

The downside here is that the Linux views code is definitely going to be broken by this.  I'm not sure of the best design for Linux views, so I haven't implemented one.

BUG=21028
TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position.
Review URL: http://codereview.chromium.org/195099
------------------------------------------------------------------------
r26392 | cevans@chromium.org | 2009-09-16 23:28:41 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Add test for history HTML escaping issue.

BUG=17892
TEST=SessionHistoryTest.HistorySearchXSS

Review URL: http://codereview.chromium.org/206040
------------------------------------------------------------------------
r26387 | mark@chromium.org | 2009-09-16 23:03:44 +0200 (Wed, 16 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/base/base_paths_mac.h
   M /trunk/src/base/base_paths_mac.mm
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/base/path_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_paths_mac.mm

Set OS X cache directory to ~/Library/Caches/[app name]/[profile name] 

 - Added implementation of GetUserCacheDirectory() for OS X. 
 - Added FilePath::GetRelativePath(). 
 - Implemented per-profile cache directories for OS X.

Patch by Fred Akalin <akalin@gmail.com>

Code review URL: http://codereview.chromium.org/174053
Review URL: http://codereview.chromium.org/204043
------------------------------------------------------------------------
r26379 | jhawkins@chromium.org | 2009-09-16 21:52:04 +0200 (Wed, 16 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc

valgrind: memset the window command data structure.  |timestamp| is aligned on a 16 byte boundary leaving 4 bytes of uninitialized data in the middle of the struct.  We write this data to disk, which is a possible security risk.

BUG=22031
TEST=TabRestoreUITest.RestoreToDifferentWindow
Review URL: http://codereview.chromium.org/196144
------------------------------------------------------------------------
r26371 | phajdan.jr@chromium.org | 2009-09-16 21:15:53 +0200 (Wed, 16 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/tools/automated_ui_test_tools/auto_ui_test_input_generator.py
   M /trunk/src/chrome/tools/automated_ui_test_tools/possible_actions.txt

First part of automated_ui_tests improvements.

- disable unreliable RestoreTab action
- make more command sync, waiting for their completion

TEST=none
BUG=21547, 21636

Review URL: http://codereview.chromium.org/196096
------------------------------------------------------------------------
r26370 | sky@chromium.org | 2009-09-16 21:08:19 +0200 (Wed, 16 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/settings_page_view.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/focus/focus_manager_gtk.cc

Land http://codereview.chromium.org/206025 for Charlie:

Fix settings page transparent background issue
Also comment out focus manager check due to bug: http://crbug.com/21378

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/194128
------------------------------------------------------------------------
r26369 | thomasvl@chromium.org | 2009-09-16 20:59:46 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/login_prompt_mac.mm

Pick up newer GTM
Switch a bunch of window sizing over to use the helper so it's completely in all cases.

BUG=none
TEST=about box, hung renderer, edit search engine, and http auto still size correctly.
Review URL: http://codereview.chromium.org/201137
------------------------------------------------------------------------
r26366 | pamg@google.com | 2009-09-16 20:13:10 +0200 (Wed, 16 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Reduce severity of alert level when extension installation fails.

BUG=19907
TEST=as described in bug
Review URL: http://codereview.chromium.org/204034
------------------------------------------------------------------------
r26362 | sidchat@chromium.org | 2009-09-16 19:37:10 +0200 (Wed, 16 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Part 1 of 'Polish dragging of ToolStrips'. This CL restricts the motion of the ToolStrip to just horizontal motions until it is dragged far enough from the extension shelf, in which case it is torn away from it (similar to Tabs).

BUG=18443
TEST=none
------------------------------------------------------------------------
r26359 | xji@chromium.org | 2009-09-16 19:21:13 +0200 (Wed, 16 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/app/gfx/text_elider.h
   M /trunk/src/app/gfx/text_elider_unittest.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

ï»¿This CL fixes issue 10860 - RTL: Hebrew file names should have forced LTR
directionality in download shelf.

File names in download shelf are forced to be LTR in DownloadItemView and
through ElideFileName().

BUG=http://crbug.com/10860
TEST=1. Open chrome with Hebrew UI.
2. Right click a link and chose Save As... (4th item from the top for
non-Hebrew
speakers)
3. In the save as dialog name the file ×§×•×‘×¥.html
4. In the download shelf the filename should display as ×§×•×‘×¥.html (not
html.×§×•×‘×¥)
Review URL: http://codereview.chromium.org/131001
------------------------------------------------------------------------
r26358 | nick@chromium.org | 2009-09-16 19:07:46 +0200 (Wed, 16 Sep 2009) | 16 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/notifier/listener/listener_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/third_party/libjingle/libjingle.gyp

Build the sync unit tests:

 - Remove old main(argc, argv) from syncable_unittest.
 - Since the old notifier target had only one unittest,
merge it with the syncer tests.
 - Remove listener_unittest.cc entirely.
 - Don't compile natserver_main.cc, which has another main()
 - Use a test main from the test_support_unit library.  This
   has the downside of pulling in a lot of deps we don't need,
   but it gives us a run_all_unittests.cc.
 - Fix a few compile errors in test code.

TEST=unit tests pass
BUG=none

Review URL: http://codereview.chromium.org/205021
------------------------------------------------------------------------
r26357 | mirandac@chromium.org | 2009-09-16 19:02:20 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/history.html

Ensure that HTML can't be executed when entered on the "Search History" or "Search downloads" pages.

BUG= http://crbug.com/17892
TEST= Open history / downloads page. Search for "<h1>HI</h1>".  Note that the HTML is not interpreted, but displayed as text.

Review URL: http://codereview.chromium.org/201129
------------------------------------------------------------------------
r26354 | thakis@chromium.org | 2009-09-16 18:45:47 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Improve tab-closability of right-most tab.

BUG=21903
TEST=Open 20 tabs. Put mouse over close button of some tab in the middle and keep clicking to close tabs. When the tab below the mouse is right-most, closing it should cause the other tabs to grow so that another close box ends up below the cursor (until the remaining tabs have reached the maximum tab width).

Review URL: http://codereview.chromium.org/196137
------------------------------------------------------------------------
r26352 | thakis@chromium.org | 2009-09-16 18:39:21 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

disable extension bar for now

BUG=none
TEST=extension bar is no longer visible

Review URL: http://codereview.chromium.org/206030
------------------------------------------------------------------------
r26348 | mark@chromium.org | 2009-09-16 18:11:38 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm

Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize conversions

The SDK has gotten stupider in 10.6, and has conspired with the compiler,
which now thinks that when the receiver is held in a scoped_nsobject, NSColor
and NSSize arguments should be converted to their CG cousins.
Review URL: http://codereview.chromium.org/205016
------------------------------------------------------------------------
r26344 | craig.schlenter@chromium.org | 2009-09-16 17:49:15 +0200 (Wed, 16 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Add pause and resume to Linux download shelf.

BUG=16929

Review URL: http://codereview.chromium.org/203069
------------------------------------------------------------------------
r26342 | thomasvl@chromium.org | 2009-09-16 17:08:35 +0200 (Wed, 16 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/EditSearchEngine.xib
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm

Edit Search Engine fix up:

Fix the class name to match a rename that happened before commit.
Make the label size changes force the fields over, but not string the fields (window grows).
Make the url description autosize to the text it gets.
Make the window track the height needed for the url description field.

BUG=21893
TEST= The url description text should stay under the url box in all languages.  The labels should never clip or overlap the text fields.
Review URL: http://codereview.chromium.org/195096
------------------------------------------------------------------------
r26322 | hbono@chromium.org | 2009-09-16 05:26:48 +0200 (Wed, 16 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

Another try to fix a build break caused by r26312.
This change just adds a namespace. I wish this fixes.

TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/201132
------------------------------------------------------------------------
r26321 | hbono@chromium.org | 2009-09-16 05:07:03 +0200 (Wed, 16 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

A quick build fix caused by r26312.
It seems this "static_cast<GtkWidget*>(window)" has been moved from a static member "InfoBubble::Show()" to a non-static member "InfoBubble::Init()". So, we don't need this cast.

TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/204036
------------------------------------------------------------------------
r26315 | suzhe@chromium.org | 2009-09-16 03:21:53 +0200 (Wed, 16 Sep 2009) | 43 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Fix issue 21587, a regression of CL 196020.

This CL fixes issue 21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input.

It's a regression of my CL: http://codereview.chromium.org/196020, which reverts the text of omnibox in OnAfterPossibleChanges(), when enter key is pressed:

...
  // If the change is caused by an Enter key press event, and the event was not
  // handled by IME, then it's an unexpected change and shall be reverted here.
  // {Start|Finish}UpdatingHighlightedText() are called here to prevent the
  // PRIMARY selection from being changed.
  if (enter_was_pressed_ &&
      (char_inserted_ == '\n' || char_inserted_ == '\r')) {
    StartUpdatingHighlightedText();
    SetTextAndSelectedRange(text_before_change_, sel_before_change_);
    FinishUpdatingHighlightedText();
    return false;
  }
...

Unfortunately, this piece of code causes the char_inserted_ to be set to wrong value in HandleInsertText(), if the text has only one character. See the source code of HandleInsertText():

...
  // Filter out new line and tab characters.
  // |text| is guaranteed to be a valid UTF-8 string, so it's safe here to
  // filter byte by byte.
  //
  // If there was only a single character, then it might be generated by a key
  // event. In this case, we save the single character to help our
  // "key-press-event" signal handler distinguish if an Enter key event is
  // handled by IME or not.
  if (len == 1)
    char_inserted_ = text[0];
...

This CL uses a boolean |enter_was_inserted_| instead of char |char_inserted_| to record the enter key status, to make sure it won't be reset unexpectly.

The test has been updated to cover this case. An unexpected dns lookup issue in the test which causes a failure on Windows was also fixed.

BUG=21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input.
TEST=Input one character in omnibox and press enter, the default link matched with the character should be opened.

Review URL: http://codereview.chromium.org/200131
------------------------------------------------------------------------
r26312 | pkasting@chromium.org | 2009-09-16 03:13:54 +0200 (Wed, 16 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h

More miscellaneous cleanup bits to try and move info_bubble.* closer to my locally rewritten versions, so that the diff will be readable.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196131
------------------------------------------------------------------------
r26311 | thakis@chromium.org | 2009-09-16 02:59:04 +0200 (Wed, 16 Sep 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/ExtensionShelf.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/extension_shelf_controller.h
   A /trunk/src/chrome/browser/cocoa/extension_shelf_controller.mm
   A /trunk/src/chrome/browser/cocoa/extension_shelf_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/extension_view_mac.h
   A /trunk/src/chrome/browser/cocoa/extension_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

Add a bare-bones extension shelf that displays extension items on OS X.

This brings our extension support to about the level it has on linux.

One issue is that the toolstrips are webpages with a background image that just happens to look like the shelf they are on. But the background images are not updated on key->nonkey window changes, so the toolstrip backgrounds look slightly off in one of the two cases. If we decide to keep the shelf, we should fix this, but see the bug for erikkay's stance on this.

Also, the NTP is only loaded after all toolstrips have been loaded for some reason. That's what happens on the other platforms too, I believe.

The extension shelf uses the DownloadShelfView as background view for now.

Screenie: http://imgur.com/wSHgU.png

BUG=19073
TEST=Extensions that live in the shelf should show up. They should be clickable, resize correctly (e.g. the build status extension), and the shelf should interact in a sane way with the status bubble.

Review URL: http://codereview.chromium.org/175025
------------------------------------------------------------------------
r26308 | estade@chromium.org | 2009-09-16 02:29:22 +0200 (Wed, 16 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/printing/pdf_ps_metafile_linux.cc
   M /trunk/src/printing/pdf_ps_metafile_linux.h
   M /trunk/src/printing/pdf_ps_metafile_linux_unittest.cc

Linux: print page to file rather than using shared memory to send it to the browser.

BUG=9847

adapted from patch by <minyu.huang [at] gmail>

Review URL: http://codereview.chromium.org/203062
------------------------------------------------------------------------
r26307 | hawk@chromium.org | 2009-09-16 02:26:37 +0200 (Wed, 16 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Add SSL icons on Mac OS X

BUG=14899
TEST=https sites have a lock icon in the address field, plain http sites do not
Review URL: http://codereview.chromium.org/199072
------------------------------------------------------------------------
r26304 | mark@chromium.org | 2009-09-16 02:09:06 +0200 (Wed, 16 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

Fix Snow Leopard SDK errors

error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument passing
Review URL: http://codereview.chromium.org/204028
------------------------------------------------------------------------
r26295 | nick@chromium.org | 2009-09-16 01:18:42 +0200 (Wed, 16 Sep 2009) | 23 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   A /trunk/src/chrome/browser/sync/notifier/base/win
   A /trunk/src/chrome/browser/sync/notifier/base/win/async_network_alive_win32.cc (from /trunk/src/chrome/browser/sync/notifier/base/win32/async_network_alive_win32.cc:26134)
   A /trunk/src/chrome/browser/sync/notifier/base/win/time_win32.cc (from /trunk/src/chrome/browser/sync/notifier/base/win32/time_win32.cc:26134)
   D /trunk/src/chrome/browser/sync/notifier/base/win32
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/win
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/win/win32window.cc (from /trunk/src/chrome/browser/sync/notifier/gaia_auth/win32window.cc:26134)
   D /trunk/src/chrome/browser/sync/notifier/gaia_auth/win32window.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   D /trunk/src/chrome/browser/sync/util/character_set_converters-linux.cc
   D /trunk/src/chrome/browser/sync/util/character_set_converters-win32.cc
   A /trunk/src/chrome/browser/sync/util/character_set_converters_linux.cc (from /trunk/src/chrome/browser/sync/util/character_set_converters-linux.cc:26074)
   M /trunk/src/chrome/browser/sync/util/character_set_converters_unittest.cc
   A /trunk/src/chrome/browser/sync/util/character_set_converters_win.cc (from /trunk/src/chrome/browser/sync/util/character_set_converters-win32.cc:26134)
   D /trunk/src/chrome/browser/sync/util/compat-file-posix.cc
   D /trunk/src/chrome/browser/sync/util/compat-file-win.cc
   D /trunk/src/chrome/browser/sync/util/compat-file.h
   D /trunk/src/chrome/browser/sync/util/compat-pthread.h
   A /trunk/src/chrome/browser/sync/util/compat_file.h (from /trunk/src/chrome/browser/sync/util/compat-file.h:26134)
   A /trunk/src/chrome/browser/sync/util/compat_file_posix.cc (from /trunk/src/chrome/browser/sync/util/compat-file-posix.cc:26074)
   A /trunk/src/chrome/browser/sync/util/compat_file_win.cc (from /trunk/src/chrome/browser/sync/util/compat-file-win.cc:26074)
   A /trunk/src/chrome/browser/sync/util/compat_pthread.h (from /trunk/src/chrome/browser/sync/util/compat-pthread.h:26134)
   M /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc
   D /trunk/src/chrome/browser/sync/util/highres_timer-linux.cc
   D /trunk/src/chrome/browser/sync/util/highres_timer-linux.h
   D /trunk/src/chrome/browser/sync/util/highres_timer-win32.cc
   D /trunk/src/chrome/browser/sync/util/highres_timer-win32.h
   M /trunk/src/chrome/browser/sync/util/highres_timer.h
   A /trunk/src/chrome/browser/sync/util/highres_timer_linux.cc (from /trunk/src/chrome/browser/sync/util/highres_timer-linux.cc:26134)
   A /trunk/src/chrome/browser/sync/util/highres_timer_linux.h (from /trunk/src/chrome/browser/sync/util/highres_timer-linux.h:26074)
   M /trunk/src/chrome/browser/sync/util/highres_timer_unittest.cc
   A /trunk/src/chrome/browser/sync/util/highres_timer_win.cc (from /trunk/src/chrome/browser/sync/util/highres_timer-win32.cc:26074)
   A /trunk/src/chrome/browser/sync/util/highres_timer_win.h (from /trunk/src/chrome/browser/sync/util/highres_timer-win32.h:26074)
   D /trunk/src/chrome/browser/sync/util/path_helpers-linux.cc
   D /trunk/src/chrome/browser/sync/util/path_helpers-posix.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.h
   A /trunk/src/chrome/browser/sync/util/path_helpers_linux.cc (from /trunk/src/chrome/browser/sync/util/path_helpers-linux.cc:26134)
   A /trunk/src/chrome/browser/sync/util/path_helpers_posix.cc (from /trunk/src/chrome/browser/sync/util/path_helpers-posix.cc:26134)
   M /trunk/src/chrome/browser/sync/util/path_helpers_unittest.cc
   M /trunk/src/chrome/browser/sync/util/pthread_helpers.cc
   M /trunk/src/chrome/browser/sync/util/pthread_helpers.h
   M /trunk/src/chrome/browser/sync/util/query_helpers.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.h
   M /trunk/src/chrome/browser/sync/util/query_helpers_unittest.cc
   M /trunk/src/chrome/browser/sync/util/sync_types.h
   D /trunk/src/chrome/browser/sync/util/user_settings-posix.cc
   D /trunk/src/chrome/browser/sync/util/user_settings-win32.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   A /trunk/src/chrome/browser/sync/util/user_settings_posix.cc (from /trunk/src/chrome/browser/sync/util/user_settings-posix.cc:26134)
   A /trunk/src/chrome/browser/sync/util/user_settings_win.cc (from /trunk/src/chrome/browser/sync/util/user_settings-win32.cc:26134)
   M /trunk/src/chrome/chrome.gyp

Build sync engine as part of the browser build.

As before, syncapi is built as a dynamic library, and only
on windows.  The difference is that it's built from source,
rather than being pulled in as a binary.

Changes to sync engine code:
 * Use OS_WIN instead of OS_WINDOWS (requires build_config.h).

 * Rename platform-specific files to match the chrome convention.
   This allows them to be excluded by rules that already exist
   in chrome.gyp.  The convention is either a /win/ directory,
   or an _win.cc at the end of the file.  Other valid platforms
   are _mac, _linux, and _posix

Changes to DEPS:
 * On Windows, pull in pthreads-win32.

Changes to chrome.gyp:
 * Add new library targets for sync, notifier, sync_proto, and
   syncapi.

Review URL: http://codereview.chromium.org/193103
------------------------------------------------------------------------
r26294 | mark@chromium.org | 2009-09-16 01:18:07 +0200 (Wed, 16 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm

applicationDockMenu: is used in the unit test, it should not be private
Review URL: http://codereview.chromium.org/201127
------------------------------------------------------------------------
r26288 | pkasting@chromium.org | 2009-09-16 00:46:03 +0200 (Wed, 16 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   A /trunk/src/chrome/browser/bubble_positioner.h
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/bubble_border.cc
   M /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp

Convert the AutocompletePopupPositioner into a BubblePositioner in preparation for using it to position both the Omnibox bubble and InfoBubbles.  It now gets the bounds of the location stack, which can be turned into useful coordinates for both items.

This should not result in any visible change.

BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/194110
------------------------------------------------------------------------
r26287 | finnur@chromium.org | 2009-09-16 00:44:12 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css

Use a better highlight images for "hover" state and pushed "state".

BUG=18452
TEST=Try different themes and make sure the extension toolstrips have a nice hover and "pushed" images (by hovering over and then clicking and holding the left mouse button).

Review URL: http://codereview.chromium.org/201125
------------------------------------------------------------------------
r26284 | estade@chromium.org | 2009-09-16 00:40:06 +0200 (Wed, 16 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Connect signal handlers before initing widgets in browser window.

Moved the function call to the beginning of InitWidgets() to enforce this.

BUG=21868
TEST=interactive ui tests still working locally

Review URL: http://codereview.chromium.org/205012
------------------------------------------------------------------------
r26281 | phajdan.jr@chromium.org | 2009-09-16 00:25:27 +0200 (Wed, 16 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/tools/automated_ui_test_tools/auto_ui_test_input_generator.py
   M /trunk/src/chrome/tools/automated_ui_test_tools/possible_actions.txt

Revert "First part of automated_ui_tests improvements."

Revert "Fix Mac by disabling some UI tests on it."

Too many failures.

TBR=huanr

Review URL: http://codereview.chromium.org/193118
------------------------------------------------------------------------
r26280 | mark@chromium.org | 2009-09-16 00:19:18 +0200 (Wed, 16 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Size the buffer used for the metrics log text properly.

The existing code was abusing the WriteInto interface (base/string_util.h).
The size passed to WriteInto should be the size of the string plus one for
a terminating NUL byte.

This bug caused the final newline in the log to be clipped.  c_str users
(there probably weren't any) would see the final newline which wouldn't be
wouldn't be followed by a NUL byte.

TEST=not really any
BUG=21733
Review URL: http://codereview.chromium.org/194099
------------------------------------------------------------------------
r26278 | thakis@chromium.org | 2009-09-16 00:15:08 +0200 (Wed, 16 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/process_util_mac.mm
   A /trunk/src/chrome/app/nibs/TaskManager.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/task_manager_mac.h
   A /trunk/src/chrome/browser/cocoa/task_manager_mac.mm
   A /trunk/src/chrome/browser/cocoa/task_manager_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Some scaffolding for the task manager.

BUG=13156
TEST=Connect view->task manager to first responder's commandDispatch: and give the menu item the tag 40005. Now clicking that menu item should bring up a completely unfunctional task manager window (but it has a localized title and button).

Review URL: http://codereview.chromium.org/200094
------------------------------------------------------------------------
r26277 | aa@chromium.org | 2009-09-16 00:15:01 +0200 (Wed, 16 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc

Land review 193091: Avoid unnecessary conversions between wchar_t
and wstring.

TBR=erikkay@chromium.org
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r26274 | finnur@chromium.org | 2009-09-16 00:05:52 +0200 (Wed, 16 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   M /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Unified the color definitions for the dividers so that extension shelf is using the same values as the bookmark bar. The bookmark bar dividers looked much better against very light background than the extension shelf ones did.

BUG=18452
TEST=The dividers should look like the bookmark ones and should not look bad against very light colored backgrounds.
Review URL: http://codereview.chromium.org/204026
------------------------------------------------------------------------
r26272 | phajdan.jr@chromium.org | 2009-09-15 23:57:52 +0200 (Tue, 15 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/tools/automated_ui_test_tools/auto_ui_test_input_generator.py
   M /trunk/src/chrome/tools/automated_ui_test_tools/possible_actions.txt

First part of automated_ui_tests improvements.

- disable unreliable RestoreTab action
- make more command sync, waiting for their completion

TEST=none
BUG=21547, 21636

Review URL: http://codereview.chromium.org/196096
------------------------------------------------------------------------
r26269 | mark@chromium.org | 2009-09-15 23:36:11 +0200 (Tue, 15 Sep 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider_list_mac.mm
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   A /trunk/src/chrome/browser/chrome_application_mac.h
   A /trunk/src/chrome/browser/chrome_application_mac.mm
   M /trunk/src/chrome/chrome.gyp

Chrome should shut down cleanly when quit from the Dock icon menu, during
user logout, and during system restart and shutdown.

MainMenu.xib changes (because you're not expected to parse nibs yourself):
 - The quit menu item's action is changed from the AppController object's
   -quit: method (which no longer exists) to the application object's
   -terminate: method (the Cocoa standard).
 - The application and owner object types are changed from NSApplication to
   CrApplication.
 - The application menu name is changed from Chromium to
   ^IDS_SHORT_PRODUCT_NAME.  Cocoa doesn't use this anyway, it gets replaced
   at runtime with the localized value of CFBundleName, but we shouldn't have
   branding-specific strings in our nibs.

BUG=18078
TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch.
     You should NOT see the "Google Chrome didn't shut down correctly" info bar.
Review URL: http://codereview.chromium.org/201121
------------------------------------------------------------------------
r26266 | erikkay@chromium.org | 2009-09-15 23:22:56 +0200 (Tue, 15 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   A /trunk/src/chrome/test/data/extensions/api_test/toolstrip/folder
   A /trunk/src/chrome/test/data/extensions/api_test/toolstrip/folder/relative.html
   M /trunk/src/chrome/test/data/extensions/api_test/toolstrip/manifest.json
   M /trunk/src/chrome/test/data/extensions/api_test/toolstrip/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/toolstrip/test2.html

Handle mole/toolstrip URLs properly.
* expand/collapse to chrome-extension://crashme no longer crashes
* expand/collapse to a relative URL now works

BUG=20412,21905
TEST=browser_tests ExtensionApi.Toolstrip
(note that the test doesn't actually exercise these changes due to 21905)

Review URL: http://codereview.chromium.org/195093
------------------------------------------------------------------------
r26263 | brettw@chromium.org | 2009-09-15 23:06:25 +0200 (Tue, 15 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Replace a bunch of hardcoded URLs with constants from url_constants.h

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/193092
------------------------------------------------------------------------
r26261 | sky@chromium.org | 2009-09-15 22:36:54 +0200 (Tue, 15 Sep 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/settings_contents_view.cc
   A /trunk/src/chrome/browser/chromeos/settings_contents_view.h
   A /trunk/src/chrome/browser/chromeos/touchpad.cc
   A /trunk/src/chrome/browser/chromeos/touchpad.h

Forgot to svn add files when landing patch.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/193115
------------------------------------------------------------------------
r26260 | brettw@chromium.org | 2009-09-15 22:24:17 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/app/sql/connection.cc
   M /trunk/src/app/sql/connection.h
   M /trunk/src/app/sql/statement.cc
   M /trunk/src/app/sql/statement.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   A /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.cc (from /trunk/src/chrome/common/net/cookie_monster_sqlite.cc:26016)
   A /trunk/src/chrome/browser/net/sqlite_persistent_cookie_store.h (from /trunk/src/chrome/common/net/cookie_monster_sqlite.h:26016)
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_win.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/net/cookie_monster_sqlite.cc
   D /trunk/src/chrome/common/net/cookie_monster_sqlite.h

Convert the sqlite cookie database and web database to use the new sqlite
wrapper. This also moves and renamed the old cookie_monster_sqlite file to
match the class name.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/201099
------------------------------------------------------------------------
r26259 | sky@chromium.org | 2009-09-15 22:21:53 +0200 (Tue, 15 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chromeos/settings_page_view.cc
   M /trunk/src/chrome/browser/chromeos/settings_page_view.h
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/skia/ext/skia_utils_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/window/dialog_client_view.cc

Lands http://codereview.chromium.org/193032 for Charlie:

First pass at adding ChromeOS settings 
- a mock wifi selector combobox 
- touchpad settings that makes calls to synclient 
- on startup, touchpad settings are initialized to what's stored in
preferences

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/203073
------------------------------------------------------------------------
r26258 | rafaelw@chromium.org | 2009-09-15 22:16:41 +0200 (Tue, 15 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/a.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/b.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/c.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/d.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/e.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/f.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Address ExtensionApiTest.Tabs flakiness

This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded().

(2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors.

BUG=20828

Review URL: http://codereview.chromium.org/195090
------------------------------------------------------------------------
r26257 | agl@chromium.org | 2009-09-15 22:13:38 +0200 (Tue, 15 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   M /trunk/src/sandbox/sandbox.gyp

Linux: add support for SELinux.

This patch adds support for a selinux GYP variable which, when set to
one, does the following:
  * Removes the seccomp sandbox from the compile
  * Removes support for SUID sandboxing from the zygote
  * Performs a dynamic transition, in the zygote, to
    chromium_renderer_t.

This code requires that the system policy have a sensible set of
access vectors for the chromium_renderer_t type. Such a policy will be
found in sandbox/selinux in the future.

http://codereview.chromium.org/203071

------------------------------------------------------------------------
r26253 | michaeln@google.com | 2009-09-15 22:00:11 +0200 (Tue, 15 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/appcache/chrome_appcache_service.h
   M /trunk/src/webkit/appcache/appcache_service.cc
   M /trunk/src/webkit/appcache/appcache_service.h
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

1) Tell the AppCacheService which request context to use when fetching resources for updates. Done for both chrome and test_shell. The service does not yet take a reference to that context, because the extra reference apparently gives some tests grief.

2) Added methods to generate new storage ids for different object types on the IO thread.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/195077
------------------------------------------------------------------------
r26252 | thomasvl@chromium.org | 2009-09-15 21:58:34 +0200 (Tue, 15 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/KeywordEditor.xib
   M /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm

Keyword editor fixes:

The "make default" button
  Auto size to always fit the text.
  Be a small style control, look better (changes font).
General fix up so the window resizes.
TableView
  Turn off column select
  Turn off multiple selection (code doesn't support it on delete).
Update the xib for the class name change that happened as part of the prior commit.

BUG=21892
TEST=window resize correctly, make default button fits it's text for all languages.
Review URL: http://codereview.chromium.org/206016
------------------------------------------------------------------------
r26250 | paul@chromium.org | 2009-09-15 21:25:19 +0200 (Tue, 15 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Committing original patch http://codereview.chromium.org/178036
by Vassili Bykov.

BUG=19983
TEST=Follow the steps in the bug to test the bubble's 
     move-out-of-the-way behavior with dowload shelf
     both visible and hidden.

Review URL: http://codereview.chromium.org/200135
------------------------------------------------------------------------
r26246 | rohitrao@chromium.org | 2009-09-15 20:54:44 +0200 (Tue, 15 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

[Mac] Make the pageup, Shift-pageup, and Option-Shift-pageup keys scroll the underlying webpage when using the findbar.

BUG=http://crbug.com/17421
TEST=Try pressing pageup with focus in the findbar.
Review URL: http://codereview.chromium.org/204006
------------------------------------------------------------------------
r26232 | pinkerton@chromium.org | 2009-09-15 20:05:12 +0200 (Tue, 15 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Make sure the text color is set correctly for incognito themes until we theme them correctly
BUG=20707
TEST=tab text appears correctly in incognito.
Review URL: http://codereview.chromium.org/196123
------------------------------------------------------------------------
r26231 | rohitrao@chromium.org | 2009-09-15 20:01:58 +0200 (Tue, 15 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/focus_tracker.h
   A /trunk/src/chrome/browser/cocoa/focus_tracker.mm
   A /trunk/src/chrome/browser/cocoa/focus_tracker_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Restore focus to the previously focused view when dismissing the find bar.
If a result was found, restore focus to the tab contents. This allows for
keyboard navigation using the find bar.

Now with fix for valgrind failure.  This CL reverts 26219, which in turn reverted 26214.

BUG=http://crbug.com/12657
BUG=http://crbug.com/21374
TEST=See test case in bug 21374
Review URL: http://codereview.chromium.org/205010
------------------------------------------------------------------------
r26229 | tim@chromium.org | 2009-09-15 19:28:51 +0200 (Tue, 15 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.h

Check in syncapi header consistent with most recent build of syncapi.dll
from the chrome sync client devchannel release branch.

TBR=idana
Review URL: http://codereview.chromium.org/196124
------------------------------------------------------------------------
r26228 | finnur@chromium.org | 2009-09-15 19:18:40 +0200 (Tue, 15 Sep 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   A /trunk/src/chrome/browser/views/detachable_toolbar_view.h

Fix build. When I recreated my changelist I accidentally left out two files I had added.

Fixing.

TBR=jcampan
BUG=None
TEST=Build should work

Review URL: http://codereview.chromium.org/204023
------------------------------------------------------------------------
r26227 | finnur@chromium.org | 2009-09-15 19:08:08 +0200 (Tue, 15 Sep 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

ExtensionShelf now uses the BookmarkExtensionBackground, just like the BookmarkBarView. 

Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. 
Added an interface that both BookmarkBarView and ExtensionShelf implement. 
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. 
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). 
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. 
Toolstrip text color values are no longer hard-coded but use the color specified in the theme. 
Decreased the timeouts for showing and hiding the toolstrip handle. 
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. 

Known issues: 

Some themes expose the fact that: 
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. 
- Didn't spend much time theming the shelf handle (just used the solid color from the theme). 
- When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change).

BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.

Review URL: http://codereview.chromium.org/204022
------------------------------------------------------------------------
r26224 | jcampan@chromium.org | 2009-09-15 18:35:49 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/ssl/page_with_blank_target.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

This CL adds a test to insure we are not regressing on http://crbug.com/19941
We would crash when an SSL error would happen on a page with no navigation entry.

TEST=Run the test.
BUG=http://crbug.com/19941

Review URL: http://codereview.chromium.org/196115
------------------------------------------------------------------------
r26221 | gwilson@google.com | 2009-09-15 18:04:45 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc

Modifies the Firefox import behavior such that if we're in first run, the importer is headless, and we're only importing the home page, skip the Firefox lock.
Otherwise, the process would silently wait for Firefox to close with no warnings.

BUG=18709
TEST=set "import_home_page" : true, "skip_first_run_ui" : true in the master_preferences, and run without FirstRun.  Import should not block.

Review URL: http://codereview.chromium.org/174057
------------------------------------------------------------------------
r26220 | avi@chromium.org | 2009-09-15 17:51:07 +0200 (Tue, 15 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

mac: drop NOTIMPLEMENTED in GotFocus()

See http://codereview.chromium.org/194109 for details.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/196122
------------------------------------------------------------------------
r26219 | rohitrao@chromium.org | 2009-09-15 17:49:47 +0200 (Tue, 15 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   D /trunk/src/chrome/browser/cocoa/focus_tracker.h
   D /trunk/src/chrome/browser/cocoa/focus_tracker.mm
   D /trunk/src/chrome/browser/cocoa/focus_tracker_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Reverting 26214.
Review URL: http://codereview.chromium.org/201116
------------------------------------------------------------------------
r26218 | maruel@chromium.org | 2009-09-15 17:45:14 +0200 (Tue, 15 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Disable flaky test ExtensionApiTest.Tabs.

TBR=asargent
BUG=20828
TEST=ExtensionApiTest.Tabs random failure

Review URL: http://codereview.chromium.org/205009

------------------------------------------------------------------------
r26214 | rohitrao@chromium.org | 2009-09-15 16:52:03 +0200 (Tue, 15 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/focus_tracker.h
   A /trunk/src/chrome/browser/cocoa/focus_tracker.mm
   A /trunk/src/chrome/browser/cocoa/focus_tracker_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Restore focus to the previously focused view when dismissing the find bar.
If a result was found, restore focus to the tab contents.  This allows for
keyboard navigation using the find bar.

BUG=http://crbug.com/12657
BUG=http://crbug.com/21374
TEST=See test case in bug 21374
Review URL: http://codereview.chromium.org/201061
------------------------------------------------------------------------
r26208 | tyoshino@google.com | 2009-09-15 14:59:22 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Disable AutocompleteEditViewTest.DesiredTLD until it becomes not flaky.

BUG=21864
TEST=none
TBR=suzhe

Review URL: http://codereview.chromium.org/195085
------------------------------------------------------------------------
r26199 | tyoshino@google.com | 2009-09-15 08:18:26 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Disable AutocompleteEditViewTest.EnterToSearch until it becomes not flaky.

BUG=21849
TBR=suzhe
TEST=none

Review URL: http://codereview.chromium.org/204019
------------------------------------------------------------------------
r26198 | thakis@chromium.org | 2009-09-15 07:39:01 +0200 (Tue, 15 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

Potential fix for http://crbug.com/13111

The browser_window_controller is destroyed before the window is destroyed.
In its dealloc, it sends the download shelf an |exiting| message that deletes
all item controllers, but the items's views might still be visible and hold
weak references to their controllers. When they are clicked, they would se
nd a message to free'd memory.

This is all speculation.

BUG=13111
TEST=Release to dev channel, monitor crash reports. Should go down.

Review URL: http://codereview.chromium.org/193109
------------------------------------------------------------------------
r26197 | tyoshino@google.com | 2009-09-15 07:30:23 +0200 (Tue, 15 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Disable failing test AutocompleteEditViewTest.AltEnter until it's fixed.

BUG=21846
TEST=none
TBR=suzhe
Review URL: http://codereview.chromium.org/205007
------------------------------------------------------------------------
r26192 | tyoshino@google.com | 2009-09-15 04:23:03 +0200 (Tue, 15 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Fix build failure.

Initialize gfx::NativeWindow (i.e. HWND) and AutocompleteEditView* so that Chromium Linux
doesn't fail to build due to uninitialized variable warning.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/204017

Review URL: http://codereview.chromium.org/204017
------------------------------------------------------------------------
r26190 | suzhe@chromium.org | 2009-09-15 03:11:00 +0200 (Tue, 15 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Add autocomplete_edit_view_browsertest.cc.

This CL adds automated tests for AutocompleteEditView.

BUG=20422: Autocomplete edit view needs automated testing
TEST=none

Review URL: http://codereview.chromium.org/177052
------------------------------------------------------------------------
r26188 | cira@chromium.org | 2009-09-15 02:29:29 +0200 (Tue, 15 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Drag and drop for extension in RTL wasn't working properly.
ExtensionShelf::ToolstripAtX would never find a toolstrip for any value of x (or would find wrong one).


BUG=11880
TEST=Load chrome with --lang=he, add 2-3 extensions and try dragging and switching their positions. It should work as LTR.

Review URL: http://codereview.chromium.org/204015
------------------------------------------------------------------------
r26187 | evan@chromium.org | 2009-09-15 02:24:10 +0200 (Tue, 15 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

linux: drop NOTIMPLEMENTED in GotFocus()

Leftover cruft.

Review URL: http://codereview.chromium.org/194109
------------------------------------------------------------------------
r26186 | nsylvain@chromium.org | 2009-09-15 02:23:34 +0200 (Tue, 15 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   D /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   D /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Revert change 26184, 26181 and 26178 to fix
the compile error on the toolkit builder.

TBR:finnur

Review URL: http://codereview.chromium.org/203064
------------------------------------------------------------------------
r26185 | tony@chromium.org | 2009-09-15 02:06:55 +0200 (Tue, 15 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Don't vertically tile the frame background.

BUG=21728

Review URL: http://codereview.chromium.org/203060

------------------------------------------------------------------------
r26184 | finnur@chromium.org | 2009-09-15 02:04:31 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Oops, another variable also has the same problem (warning turned into error due to initialization order).

TBR=erikkay
BUG=None
TEST=Linux build compiles.

Review URL: http://codereview.chromium.org/204016
------------------------------------------------------------------------
r26181 | finnur@chromium.org | 2009-09-15 01:55:22 +0200 (Tue, 15 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Fix linux build warning treated as error.

TBR=erikkay
BUG=None

Review URL: http://codereview.chromium.org/193108
------------------------------------------------------------------------
r26178 | finnur@chromium.org | 2009-09-15 01:40:15 +0200 (Tue, 15 Sep 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   A /trunk/src/chrome/browser/views/detachable_toolbar_view.cc
   A /trunk/src/chrome/browser/views/detachable_toolbar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

ExtensionShelf now uses the BookmarkExtensionBackground, just like the BookmarkBarView.

Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added.
Added an interface that both BookmarkBarView and ExtensionShelf implement.
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not.
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions).
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process.
Toolstrip text color values are no longer hard-coded but use the color specified in the theme.
Decreased the timeouts for showing and hiding the toolstrip handle.
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses.

Known issues:

Some themes expose the fact that:
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though.
- Didn't spend much time theming the shelf handle (just used the solid color from the theme).

BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.
Review URL: http://codereview.chromium.org/203034
------------------------------------------------------------------------
r26177 | sky@chromium.org | 2009-09-15 01:35:12 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.cc

Removes some dead NOTIMPLEMENTEDs and enables some code that no longer
needs to be ifdef'd out.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/196111
------------------------------------------------------------------------
r26172 | pkasting@chromium.org | 2009-09-15 01:04:58 +0200 (Tue, 15 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bubble_border.h

Try to fix Linux views build

------------------------------------------------------------------------
r26170 | rafaelw@chromium.org | 2009-09-15 00:53:50 +0200 (Tue, 15 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc

Update Linux extension install prompt

BUG=21416

Review URL: http://codereview.chromium.org/203058

------------------------------------------------------------------------
r26169 | mattm@chromium.org | 2009-09-15 00:34:42 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Log an error message when deleting lockfile or socket fails in ProcessSingletonLinux.
Also, include full path in error about creating the lock.

BUG=20982
TEST=chown your profile & lockfile to root.root and run.  Should print error about unlink ... permission denied.

Review URL: http://codereview.chromium.org/193105
------------------------------------------------------------------------
r26168 | jshin@chromium.org | 2009-09-15 00:30:18 +0200 (Tue, 15 Sep 2009) | 33 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview_impl.cc

Fix for bug 2932: Chrome should not trigger page reloading when turn off auto detect 

In order to fix the bug I added new interfaces to allow resetting the override encoding (including a new render message). 

The new logic is as follows: 

-) If the user turns auto-detect OFF, nothing happens (as requested in the bug description) 
-) If the user turns auto-detect ON, then the page is reloaded with an empty override encoding 

I.e., turning auto-detect on resets a previous override setting. 
The reverse is not true, however: specifiying a new override setting will not turn auto-detect off. 


BUG=2932
TEST=do the following steps, using the test file (encoding-gb18030.htm) attached to comment 14 of the original bug http://crbug.com/2932 : 

1.) load the file while auto-detect is turned off 
-> garbage is displayed 
2.) turn auto-detect on 
-> proper Chinese text should appear 
-> in the encoding menu, Chinese encoding should be highlighted 
3.) turn auto-detect off 
-> proper Chinese text should remain 
-> in the encoding menu, Chinese encoding should remain highlighted 
4.) choose any other encoding 
-> garbage is again displayed (in the new encoding) 
5.) turn auto-detect on 
-> proper Chinese text should again appear 
-> in the encoding menu, Chinese should again be highlighted 

Original Review: http://codereview.chromium.org/173265
Patch by Roland Steiner (rolandsteiner@google.com)

------------------------------------------------------------------------
r26165 | pkasting@chromium.org | 2009-09-15 00:00:34 +0200 (Tue, 15 Sep 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/bubble_b.png (from /trunk/src/chrome/app/theme/omnibox_b.png:26120)
   A /trunk/src/chrome/app/theme/bubble_bl.png (from /trunk/src/chrome/app/theme/omnibox_bl.png:26120)
   A /trunk/src/chrome/app/theme/bubble_br.png (from /trunk/src/chrome/app/theme/omnibox_br.png:26120)
   A /trunk/src/chrome/app/theme/bubble_l.png (from /trunk/src/chrome/app/theme/omnibox_l.png:26120)
   A /trunk/src/chrome/app/theme/bubble_r.png (from /trunk/src/chrome/app/theme/omnibox_r.png:26120)
   A /trunk/src/chrome/app/theme/bubble_t.png (from /trunk/src/chrome/app/theme/omnibox_t.png:26120)
   A /trunk/src/chrome/app/theme/bubble_tl.png (from /trunk/src/chrome/app/theme/omnibox_tl.png:26120)
   A /trunk/src/chrome/app/theme/bubble_tr.png (from /trunk/src/chrome/app/theme/omnibox_tr.png:26120)
   D /trunk/src/chrome/app/theme/omnibox_b.png
   D /trunk/src/chrome/app/theme/omnibox_bl.png
   D /trunk/src/chrome/app/theme/omnibox_br.png
   D /trunk/src/chrome/app/theme/omnibox_l.png
   D /trunk/src/chrome/app/theme/omnibox_r.png
   D /trunk/src/chrome/app/theme/omnibox_t.png
   D /trunk/src/chrome/app/theme/omnibox_tl.png
   D /trunk/src/chrome/app/theme/omnibox_tr.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   A /trunk/src/chrome/browser/views/bubble_border.cc
   A /trunk/src/chrome/browser/views/bubble_border.h
   M /trunk/src/chrome/chrome.gyp

Factor out border-drawing code from autocomplete_popup_contents_view.cc into a new file, bubble_border.cc, so that InfoBubble will be able to start using it.  This also renames the resources to be more generic.

This should not result in any visual changes.

BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/194107
------------------------------------------------------------------------
r26163 | evan@chromium.org | 2009-09-14 23:33:28 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html

linux: update splash pages to reflect new plugin reality

The bug tracker lists all the missing stuff anyway.

Review URL: http://codereview.chromium.org/204010
------------------------------------------------------------------------
r26159 | paul@chromium.org | 2009-09-14 22:59:13 +0200 (Mon, 14 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Split the "downloads in progress at exit" confirm dialog text into
a bold font warning question and a normal font explanation to better
map to the Mac UI guidelines.

BUG=19755
TEST=Try to exit chrome with a download in progress. The dialog
     text should have two paragraphs: the first in bold font asking
     a question, and the second in normal font with an explanation.

Review URL: http://codereview.chromium.org/193080
------------------------------------------------------------------------
r26158 | eroman@chromium.org | 2009-09-14 22:51:04 +0200 (Mon, 14 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_job_manager.cc
   D /trunk/src/net/url_request/url_request_view_cache_job.cc
   D /trunk/src/net/url_request/url_request_view_cache_job.h
   D /trunk/src/net/url_request/url_request_view_net_internal_job.cc
   D /trunk/src/net/url_request/url_request_view_net_internal_job.h
   A /trunk/src/net/url_request/url_request_view_net_internals_job.cc (from /trunk/src/net/url_request/url_request_view_net_internal_job.cc:25998)
   A /trunk/src/net/url_request/url_request_view_net_internals_job.h (from /trunk/src/net/url_request/url_request_view_net_internal_job.h:25998)
   A /trunk/src/net/url_request/view_cache_helper.cc (from /trunk/src/net/url_request/url_request_view_cache_job.cc:25998)
   A /trunk/src/net/url_request/view_cache_helper.h (from /trunk/src/net/url_request/url_request_view_cache_job.h:25998)

Change the URLs used to access "view-cache:" and "view-net-internals:".

"net-internal:*" ==> "chrome://net-internals/*"
"view-cache:*" ==> "chrome://net-internals/view-cache/*"
"view-cache:stats" ==> "chrome://net-internals/httpcache.stats"


As before, there are also aliases from the "about:*" page:

"about:net-internal[/*]" aliases "chrome://net-internals/*"
"about:cache[/*]" aliases "chrome://net-internals/view-cache"

BUG=http://crbug.com/21551

Review URL: http://codereview.chromium.org/202067
------------------------------------------------------------------------
r26156 | sky@chromium.org | 2009-09-14 22:34:45 +0200 (Mon, 14 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Changes the width of pinned tabs to 56, except on chrome os where it
remains at 64.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/203055
------------------------------------------------------------------------
r26153 | jcampan@chromium.org | 2009-09-14 22:20:35 +0200 (Mon, 14 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/views/controls/native/native_view_host.cc
   M /trunk/src/views/controls/native/native_view_host.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h

This CL makes the focus remembered across tab switches for Chrome Linux with toolkit views.
It also contains clean-ups and implementation of different minor focus related things.

BUG=None
TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab.
     Also test that deactivating/reactivating the browser window still restores focus properly.

Review URL: http://codereview.chromium.org/194041

------------------------------------------------------------------------
r26152 | estade@chromium.org | 2009-09-14 22:20:14 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Don't show bookmark bar remnants in fullscreen mode.

BUG=21742

Review URL: http://codereview.chromium.org/200124
------------------------------------------------------------------------
r26148 | estade@chromium.org | 2009-09-14 22:12:55 +0200 (Mon, 14 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK: Adjust toolbar padding.

Pixel-perfect with Windows.

BUG=21772

Review URL: http://codereview.chromium.org/203054
------------------------------------------------------------------------
r26144 | pkasting@chromium.org | 2009-09-14 21:48:05 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/view.h

Clean up a few tiny things I noticed.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196110
------------------------------------------------------------------------
r26142 | phajdan.jr@chromium.org | 2009-09-14 21:36:31 +0200 (Mon, 14 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/base/path_service_unittest.cc
   M /trunk/src/base/sys_info_unittest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   M /trunk/src/chrome/installer/setup/setup_util_unittest.cc

Fix to use FilePath in more unittests.

Landing patch for Thiago Farina, original review: http://codereview.chromium.org/187005

BUG=None
TEST=run unit_tests.exe, base_unittests.exe.

Review URL: http://codereview.chromium.org/193101
------------------------------------------------------------------------
r26141 | sky@chromium.org | 2009-09-14 21:26:49 +0200 (Mon, 14 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_gtk.cc
   A /trunk/src/app/gfx/font_skia.cc (from /trunk/src/app/gfx/font_skia.cc:26115)
   M /trunk/src/app/gfx/font_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc

Reverts linux font change again. Slow down isn't as bad as before. But
still not ideal.

BUG=none
TEST=none
TBR=agl

Review URL: http://codereview.chromium.org/194105
------------------------------------------------------------------------
r26140 | thomasvl@chromium.org | 2009-09-14 21:25:20 +0200 (Mon, 14 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/HttpAuthLoginSheet.xib
   M /trunk/src/chrome/browser/login_prompt_mac.h
   M /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/chrome.gyp

Load the http auth dialog from the main bundle.
Localize the http auth dialog.
Add the explanation to the http auth dialog.
Autosize the http auth dialog after putting in the explanation.

TEST=http auto ui should now be localized.
BUG=20532
Review URL: http://codereview.chromium.org/196109
------------------------------------------------------------------------
r26138 | mattm@chromium.org | 2009-09-14 21:20:14 +0200 (Mon, 14 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

Use gtk_window_set_skip_taskbar_hint on info bubble popups so they don't show up in the task bar.

Review URL: http://codereview.chromium.org/201103
------------------------------------------------------------------------
r26137 | thomasvl@chromium.org | 2009-09-14 21:10:48 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view_unittest.mm

Fix up the unittest to now expect the image within the bundle.

TEST=chromium mac goes green
BUG=none
Review URL: http://codereview.chromium.org/194104
------------------------------------------------------------------------
r26135 | jcampan@chromium.org | 2009-09-14 20:57:22 +0200 (Mon, 14 Sep 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

The focus is not restored properly when a Windows modal dialog
(such as "open file', 'print'...) is closed.
We are running these dialogs from a different thread and they
cause the browser window to get activated before it has been
enabled. This causes the focus restoration to fail as the window
is not enabled.
In an earlier patch, I fixed it by storing/restoring the focus
explicitly before/after the dialog is shown.
But the fix did not apply to the print dialog which does not use
the code I added my fix in.

This CL reverts that previous fix and comes with a simpler solution:
if when we are about to restore focus the window is disabled, we
delay the focus restoration untill the window is enabled again.

BUG=3380
TEST=Set the focus on a page with scroll-bars, right-click to do a
    'save as'. Close the dialog. The arrow keys should let you scroll
    the page. Accelerators such as Ctrl-T should still work. Test
    'open a file', 'print' and the font selection dialog (in the options).
    When closing the dialog the focus should return to the view that last
    had focus. 

Review URL: http://codereview.chromium.org/199106
------------------------------------------------------------------------
r26131 | estade@chromium.org | 2009-09-14 20:45:03 +0200 (Mon, 14 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

GTK: Don't show extension shelf when it's empty.

this gets rid of a 1 pixel grey line at the bottom of the web contents.

Also, do show the extension shelf in fullscreen (matching windows).

BUG=none (regression of crbug.com/17324)
TEST=one_in_shelf still works
Review URL: http://codereview.chromium.org/194094
------------------------------------------------------------------------
r26130 | pkasting@chromium.org | 2009-09-14 20:41:54 +0200 (Mon, 14 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.h

Try to fix the Linux Views build.

TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203053
------------------------------------------------------------------------
r26129 | evan@chromium.org | 2009-09-14 20:41:33 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

linux: enable plugins by default

This is long overdue.

Review URL: http://codereview.chromium.org/193100
------------------------------------------------------------------------
r26127 | tommi@chromium.org | 2009-09-14 20:38:36 +0200 (Mon, 14 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Changing a NOTREACHED() to a DLOG as StopAsync can be called before a view has been created.

TEST=run automation tests.
BUG=none

Review URL: http://codereview.chromium.org/193099
------------------------------------------------------------------------
r26126 | idana@chromium.org | 2009-09-14 20:34:07 +0200 (Mon, 14 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc
   M /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.h
   M /trunk/src/chrome/browser/sync/notifier/base/async_network_alive.h
   M /trunk/src/chrome/browser/sync/notifier/base/linux/network_status_detector_task_linux.cc
   M /trunk/src/chrome/browser/sync/notifier/base/nethelpers.h
   M /trunk/src/chrome/browser/sync/notifier/base/network_status_detector_task.cc
   M /trunk/src/chrome/browser/sync/notifier/base/network_status_detector_task.h
   M /trunk/src/chrome/browser/sync/notifier/base/network_status_detector_task_mt.cc
   M /trunk/src/chrome/browser/sync/notifier/base/posix/time_posix.cc
   M /trunk/src/chrome/browser/sync/notifier/base/signal_thread_task.h
   M /trunk/src/chrome/browser/sync/notifier/base/string.cc
   M /trunk/src/chrome/browser/sync/notifier/base/string.h
   M /trunk/src/chrome/browser/sync/notifier/base/string_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/base/task_pump.cc
   M /trunk/src/chrome/browser/sync/notifier/base/task_pump.h
   M /trunk/src/chrome/browser/sync/notifier/base/time.cc
   M /trunk/src/chrome/browser/sync/notifier/base/time.h
   M /trunk/src/chrome/browser/sync/notifier/base/time_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/base/timer.h
   M /trunk/src/chrome/browser/sync/notifier/base/utils.h
   M /trunk/src/chrome/browser/sync/notifier/base/win32/time_win32.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/auto_reconnect.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/auto_reconnect.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/connection_options.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/connection_options.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/connection_settings.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/const_communicator.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/mailbox.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/mailbox.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/mailbox_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/product_info.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_connection_generator.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_connection_generator.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_log.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_log.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.h
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.h
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/inet_aton.h
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h
   M /trunk/src/chrome/browser/sync/notifier/gaia_auth/win32window.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread.h
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   M /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_event.h
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   M /trunk/src/chrome/browser/sync/syncable/syncable-inl.h
   M /trunk/src/chrome/browser/sync/syncable/syncable.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.cc
   M /trunk/src/chrome/browser/sync/syncable/syncable_id.h
   M /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   M /trunk/src/chrome/browser/sync/util/character_set_converters-win32.cc
   M /trunk/src/chrome/browser/sync/util/compat-file.h
   M /trunk/src/chrome/browser/sync/util/compat-pthread.h
   M /trunk/src/chrome/browser/sync/util/crypto_helpers.cc
   M /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   M /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc
   M /trunk/src/chrome/browser/sync/util/highres_timer-linux.cc
   M /trunk/src/chrome/browser/sync/util/highres_timer_unittest.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers-linux.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers-posix.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.h
   M /trunk/src/chrome/browser/sync/util/pthread_helpers.cc
   M /trunk/src/chrome/browser/sync/util/query_helpers.cc
   M /trunk/src/chrome/browser/sync/util/user_settings-posix.cc
   M /trunk/src/chrome/browser/sync/util/user_settings-win32.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.cc
   M /trunk/src/chrome/browser/sync/util/user_settings.h
   M /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.cc
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.h
   M /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator_unittest.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   M /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   M /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h

Made some style fixes in the remaining code under chrom/browser/sync and under chrome/test/sync.

Review URL: http://codereview.chromium.org/203043
------------------------------------------------------------------------
r26125 | tony@chromium.org | 2009-09-14 20:22:52 +0200 (Mon, 14 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Add keyboard shortcuts to reorder tabs left or right on Linux.

It's standard in GTK+ for tabbed interfaces to be reorderable
using ctrl+shift+pgup and ctrl+shift+pgdn (e.g., in Terminal).

The plumbing is included on all platforms, but the shortcut is
only hooked up on Linux.

BUG=21594

Review URL: http://codereview.chromium.org/194088

------------------------------------------------------------------------
r26124 | sgk@google.com | 2009-09-14 20:14:46 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   A /trunk/src/chrome/browser/app_controller_mac_unittest.mm (from /trunk/src/chrome/browser/app_controller_mac_unittest.mm:26038)
   M /trunk/src/chrome/chrome.gyp

Add "New Window" and "New Incognito Window" items to the Dock Menu.
Add a unit test module for AppController with a simple DockMenu test.
BUG=21175
TEST=AppControllerTest.DockMenu
Review URL: http://codereview.chromium.org/196103
------------------------------------------------------------------------
r26122 | agl@chromium.org | 2009-09-14 20:01:15 +0200 (Mon, 14 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Linux: remove check that the renderer knows its PID.

With the SUID sandbox and CLONE_NEWPID, this check is failing. (It'll
only trigger on recent kernels which have CLONE_NEWPID support).

BUG=21112

http://codereview.chromium.org/202060/

------------------------------------------------------------------------
r26121 | pkasting@chromium.org | 2009-09-14 20:00:12 +0200 (Mon, 14 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Some initial cleanup of InfoBubble:
* Remove fading/animation-related code, which didn't do anything
* Remove unnecessary #includes
* Try and make a few comments better
* Make more functions private or protected
* Ensure definition order == declaration order

Hopefully, there should be no visible effects of this change.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/204001
------------------------------------------------------------------------
r26119 | phajdan.jr@chromium.org | 2009-09-14 19:46:15 +0200 (Mon, 14 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc

Remove code doing a no-op due to float -> int rounding.
Make implicit float -> int/long conversions explicit.

(Implicit float -> int conversions can be found by compiling with
-Wconversion in gcc [versions 4.1.1 and 4.2.4, and surely many others].)

Landing the patch for Jacob Mandelson, original review: http://codereview.chromium.org/201091

BUG=none
TEST=app_unittests & base_unittests

Review URL: http://codereview.chromium.org/200122
------------------------------------------------------------------------
r26116 | sky@chromium.org | 2009-09-14 19:19:29 +0200 (Mon, 14 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_gtk.cc
   D /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/app/gfx/font_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc

Attempt 2 at converting font from Skia to Pango. The slow down appears to be entirely attributed to asking for the metrics. To get back the performance I did the following:

. Only ask for the metrics when needed. We appear to create 6 or so fonts very early on without needing the metrics. This ensures we only take the metrics load hit when needed.
. Keep a cache of the metrics around. This ensures that we only load the metrics once.

I didn't dig through the Pango source to see why Pango is slow at getting metrics. I suspect it's the first person to ask for metrics incurs a penalty as Pango accesses the disk. The code we have now is the same as that as Gtk.
Review URL: http://codereview.chromium.org/199101
------------------------------------------------------------------------
r26115 | tim@chromium.org | 2009-09-14 19:16:42 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc

Move sync wizard dimension constants to locale_settings GRD.

BUG=19896

Review URL: http://codereview.chromium.org/192077
------------------------------------------------------------------------
r26107 | sky@chromium.org | 2009-09-14 17:59:25 +0200 (Mon, 14 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Implements LocationBarView::AvailableWidth for Gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/195068
------------------------------------------------------------------------
r26106 | thomasvl@chromium.org | 2009-09-14 17:26:20 +0200 (Mon, 14 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp

Update the sadtab and throbbers to use the helpers for fetching strings/images from pak file.
Use the images directly from the pak files instead of having extra copies in the bundle.

TEST=sad tab page still works and has all images.  throbbers still work.  the app should no longer carry the sadtab and throbber images directly.
BUG=20230
BUG=21076
Review URL: http://codereview.chromium.org/194101
------------------------------------------------------------------------
r26105 | thakis@chromium.org | 2009-09-14 17:05:02 +0200 (Mon, 14 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_mac.mm

Fix crash when closing tab with an open http auth sheet.

Parts of patch by mdm@chromium.org, taken from http://codereview.chromium.org/196104

BUG=19427, 21111, 21304 (not sure about last one)
TEST=Open a page with an http auth sheet, open another tab, close tab with the open sheet -- should not crash. Also check that opening a tab with an open sheet, then hitting back, forward, reload still works and doesn't crash.

Review URL: http://codereview.chromium.org/194095
------------------------------------------------------------------------
r26102 | tim@chromium.org | 2009-09-14 15:11:27 +0200 (Mon, 14 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc

Use jstemplates in merge and sync setup page.

BUG=19896

Review URL: http://codereview.chromium.org/194092
------------------------------------------------------------------------
r26093 | mark@chromium.org | 2009-09-14 05:26:03 +0200 (Mon, 14 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/browser_main.h
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_main_win.h

Send Breakpad and debugger status to the metrics service on the Mac.

BUG=21731
TEST=Metrics data should have the correct values for breakpadregistrationok,
     breakpadregistrationfail, debuggerpresent, and debuggernotpresent in
     log.profile.stability.
Review URL: http://codereview.chromium.org/203050
------------------------------------------------------------------------
r26088 | evan@chromium.org | 2009-09-13 16:54:22 +0200 (Sun, 13 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

posix: NOTIMPLEMENTED in --pack-extension

Review URL: http://codereview.chromium.org/194097
------------------------------------------------------------------------
r26085 | ananta@chromium.org | 2009-09-13 01:10:41 +0200 (Sun, 13 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

Support the View Page Info option in the ExternalTabContainer, which would allow this to work in external
automation clients.

This fixes bug http://b/issue?id=2093098

Bug=2093098

Review URL: http://codereview.chromium.org/192080
------------------------------------------------------------------------
r26078 | rsesek@chromium.org | 2009-09-12 19:00:39 +0200 (Sat, 12 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/chrome/app/nibs/EditSearchEngine.xib
   A /trunk/src/chrome/app/nibs/KeywordEditor.xib
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.h
   A /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.h
   A /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Implement the search engine manager

* Enable the Manage search engines button in Preferences
* New search engines can be added using the "+" button
* Existing search engines can be edited via double-click
* Existing search engines can be removed with the "-" button
* The "Make Default" button has the same behavior as the list box in the Basics
  preferences "Default Search"

BUG=16187
TEST=Go to Preferences, click "Manage" next to "Default Search" and add/edit/remove engines.

Review URL: http://codereview.chromium.org/193040
------------------------------------------------------------------------
r26076 | thakis@chromium.org | 2009-09-12 10:27:27 +0200 (Sat, 12 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Try to fix build.

TBR=pinkerton

------------------------------------------------------------------------
r26075 | thakis@chromium.org | 2009-09-12 09:30:35 +0200 (Sat, 12 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Let cmd-e write the selection into the find pasteboard.

Note that chrome still does not support _reading_ from the find pasteboard, so hitting cmd-e followed by cmd-g in chrome still doesn't work. Also, cmd-f doesn't write to the find pasteboard yet either.

BUG=14562
TEST=Select some text on a web page, hit cmd-e, go to the same web page in safari, hit cmd-g. Safari should search for the text you selected in chrome.

Review URL: http://codereview.chromium.org/197035
------------------------------------------------------------------------
r26069 | pkasting@chromium.org | 2009-09-12 03:28:51 +0200 (Sat, 12 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h

Clean up a few things about the first run bubble code:
* Constants at top didn't need "Static" since they were already in an anonymous namespace
* Move function definitions out from declarations.  This avoids auto-inlining these (sometimes large) functions and makes it easier to see what a class contains.
* Now that I could see the class functions, make as many as possible private.
* Make sure definition order and declaration order match.

This shouldn't make any functional changes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/202065
------------------------------------------------------------------------
r26066 | mdm@chromium.org | 2009-09-12 03:06:12 +0200 (Sat, 12 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_gtk.cc

Linux: don't crash when closing tabs that have open login prompts.
BUG=21601
TEST=close a tab asking for HTTP authentication, it should not crash

Review URL: http://codereview.chromium.org/196104
------------------------------------------------------------------------
r26062 | estade@chromium.org | 2009-09-12 03:01:55 +0200 (Sat, 12 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu.cc

Bookmark context menu: pass the correct parent to the bookmark editor.

BUG=21360
TEST=see bug

Review URL: http://codereview.chromium.org/192079
------------------------------------------------------------------------
r26061 | erg@google.com | 2009-09-12 02:52:10 +0200 (Sat, 12 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Cache our GdkCursor objects, since building them hits the disk.

TEST=strace chrome. Moving the mouse over the webpage shouldn't spew open() calls.
BUG=21623

Review URL: http://codereview.chromium.org/195071
------------------------------------------------------------------------
r26058 | agl@chromium.org | 2009-09-12 02:33:53 +0200 (Sat, 12 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc

Disable browser shutdown measurements on non-Windows platforms.

BUG=21489

http://codereview.chromium.org/199103

------------------------------------------------------------------------
r26057 | mdm@chromium.org | 2009-09-12 02:32:26 +0200 (Sat, 12 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/browser/window_sizer.h

Update some comments. No code change.
BUG=none
TEST=none

------------------------------------------------------------------------
r26056 | jcampan@chromium.org | 2009-09-12 02:17:58 +0200 (Sat, 12 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc

The SSL policy when showing an error page sets the page type on the wrong navigation entry, which can potentially be NULL causing a crasher.
Disabling the setting of page type for the error page, since it is not used.

BUG=http://crbug.com/19941
TEST=See steps in the bug.

Review URL: http://codereview.chromium.org/193063
------------------------------------------------------------------------
r26054 | asargent@chromium.org | 2009-09-12 02:08:08 +0200 (Sat, 12 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h

Do not send or store cookies for extensions autoupdate http requests.

BUG=18641
TEST=none

Review URL: http://codereview.chromium.org/196097
------------------------------------------------------------------------
r26052 | rafaelw@chromium.org | 2009-09-12 01:53:57 +0200 (Sat, 12 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/relative.html
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Extension apis: windows.create({url:}) now supports relative paths.

tabs.update() & tabs.move() now return full Tab object.

BUG=17665

Review URL: http://codereview.chromium.org/203042
------------------------------------------------------------------------
r26050 | estade@chromium.org | 2009-09-12 01:34:04 +0200 (Sat, 12 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Size popups by their contents, not the window's outer bounds.

(This problem was most annoying when a popup was meant to be exactly large enough to show a certain image.)

This fixes a BlockedPopupContainer interactive ui test.

Review URL: http://codereview.chromium.org/192058
------------------------------------------------------------------------
r26049 | tommi@chromium.org | 2009-09-12 01:27:50 +0200 (Sat, 12 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc

Handling a case where the browser_iterator_ would be NULL.  The DCHECK was fine but the code itself was missing the check.

TEST=Run automation tests.
BUG=none

Review URL: http://codereview.chromium.org/194093
------------------------------------------------------------------------
r26048 | idana@chromium.org | 2009-09-12 01:25:15 +0200 (Sat, 12 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.h
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   M /trunk/src/chrome/browser/sync/engine/authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/authenticator.h
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   M /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   M /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   M /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   M /trunk/src/chrome/browser/sync/engine/client_command_channel.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.h
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   M /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/download_updates_command.h
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.cc
   M /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   M /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc
   M /trunk/src/chrome/browser/sync/engine/post_commit_message_command.h
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   M /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   M /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.h
   M /trunk/src/chrome/browser/sync/engine/sync_cycle_state.h
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   M /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.cc
   M /trunk/src/chrome/browser/sync/engine/syncer.h
   M /trunk/src/chrome/browser/sync/engine/syncer_command.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_end_command.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   M /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_session.h
   M /trunk/src/chrome/browser/sync/engine/syncer_status.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   M /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_types.h
   M /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   M /trunk/src/chrome/browser/sync/engine/syncer_util.h
   M /trunk/src/chrome/browser/sync/engine/syncproto.h
   M /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   M /trunk/src/chrome/browser/sync/engine/update_applicator.h
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   M /trunk/src/chrome/browser/sync/engine/verify_updates_command.h


Review URL: http://codereview.chromium.org/201087
------------------------------------------------------------------------
r26043 | estade@chromium.org | 2009-09-12 01:04:23 +0200 (Sat, 12 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Set the back/forward and bookmark bar menus to always show their images.

This only works for GTK 2.16+.

BUG=21495

Review URL: http://codereview.chromium.org/199099
------------------------------------------------------------------------
r26040 | nick@chromium.org | 2009-09-12 00:51:35 +0200 (Sat, 12 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/notifier/DEPS
   M /trunk/src/chrome/browser/sync/notifier/base/win32/async_network_alive_win32.cc

Don't depend on scoped_any.

BUG=none
TEST=single-stepped with breakpoints in all
functions of PlatformNetworkInfo; made changes on a
connected client while disconnecting the client
I was debugging.  Achieved full coverage of the
affected code, except for error paths.

Review URL: http://codereview.chromium.org/194091
------------------------------------------------------------------------
r26039 | sgk@google.com | 2009-09-12 00:40:02 +0200 (Sat, 12 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   D /trunk/src/chrome/browser/app_controller_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Revert 26016 - valgrind leak -
Add "New Window" and "New Incognito Window" items to the Dock Menu.
Add a unit test module for AppController with a simple DockMenu test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199031

TBR=sgk@google.com
Review URL: http://codereview.chromium.org/196101
------------------------------------------------------------------------
r26037 | amit@chromium.org | 2009-09-12 00:33:58 +0200 (Sat, 12 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h

ExternalTabcontainer browser to initial URL

Browse the newly created external tab to the specified initial URL
if present, to about:blank otherwise. Also send information about
SSL status when sending navigation updates to the automation client.

BUG=none
TEST=CreateExternalTabWithUrl UI test

Review URL: http://codereview.chromium.org/193054
------------------------------------------------------------------------
r26030 | sky@chromium.org | 2009-09-12 00:16:00 +0200 (Sat, 12 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_gtk.cc
   A /trunk/src/app/gfx/font_skia.cc (from /trunk/src/app/gfx/font_skia.cc:26014)
   M /trunk/src/app/gfx/font_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc

Reverts r26015. It caused a startup regression:(

BUG=20823
TEST=none
TBR=agl

Review URL: http://codereview.chromium.org/203041
------------------------------------------------------------------------
r26029 | jcampan@chromium.org | 2009-09-12 00:15:32 +0200 (Sat, 12 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc

The shell dialog code explicitly disables the browser HWND before calling the Windows API to select a file.
When the dialog is closed, the browser HWND gets a WM_ACTIVATE but is still disabled, which messes up with the focus restoration.
This patch ensures we restore the focus explicitly when the browser HWND is reenabled to work-around that issue.

BUG=3380
TEST=Set the focus on a page with scroll-bars, right-click to do a 'save as'. Close the dialog. The arrow keys should let you scroll the page. Accelerators such as Ctrl-T should still work. Test 'open a file', 'print' and the font selection dialog (in the options). When closing the dialog the focus should return to the view that last had focus.

Review URL: http://codereview.chromium.org/195065
------------------------------------------------------------------------
r26028 | paul@chromium.org | 2009-09-11 23:58:29 +0200 (Fri, 11 Sep 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/net/base/platform_mime_util_mac.cc

Fix two issues with a downloaded file's extension:

1. On Mac, we were prepending an extra '.' to the extension causing
it to fail a comparison (resulting in second extension being added).
2. For downloads with the extension '.tgz' and mime type
'application/x-gzip', we were appending an extra '.gz' extension.

The extension compare code is starting to get a little long, but I
don't think it's too bad if there are only a few of these cases.

BUG=21591,21595
TEST=1. Download a file on Mac with a well known extension type (mp3, gz)
and notice that there are no double extensions. 2. Download a tgz file and
notice that the file's extension is '.tgz', not '.tgz.gz'.

Review URL: http://codereview.chromium.org/195064
------------------------------------------------------------------------
r26022 | brettw@chromium.org | 2009-09-11 23:30:56 +0200 (Fri, 11 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/sql
   A /trunk/src/app/sql/connection.cc
   A /trunk/src/app/sql/connection.h
   A /trunk/src/app/sql/connection_unittest.cc
   A /trunk/src/app/sql/meta_table.cc
   A /trunk/src/app/sql/meta_table.h
   A /trunk/src/app/sql/statement.cc
   A /trunk/src/app/sql/statement.h
   A /trunk/src/app/sql/statement_unittest.cc
   A /trunk/src/app/sql/transaction.cc
   A /trunk/src/app/sql/transaction.h
   A /trunk/src/app/sql/transaction_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database.h

Add a new wrapper for sqlite. This is mostly a large cleanup of the existing
one, combined with the statement cache in a nice way. It is designed to
entirely wrap sqlite so that we can catch corrupt errors in the future and
"do something" when we get them without having to change all the calling code.

There is also a new meta_table file which is almost exactly like the old one
but which uses the new sql interface.

This patch changes Chrome's history TextDatabase to use this new wrapper as a
proof of concept, because this usage is relatively well-confined.
Review URL: http://codereview.chromium.org/199047
------------------------------------------------------------------------
r26020 | nick@chromium.org | 2009-09-11 23:30:12 +0200 (Fri, 11 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/all_status.cc
   M /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   M /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/notifier/communicator/auto_reconnect.cc
   M /trunk/src/chrome/browser/sync/notifier/listener/listen_task.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   M /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   M /trunk/src/chrome/browser/sync/util/path_helpers.cc
   M /trunk/src/chrome/browser/sync/util/pthread_helpers.cc

Fix compiler warnings in chrome\browser\sync.

Warnings are treated as errors in the Chrome build.
Most of these are just forcing the implicit conversion
to maintain the previous behavior.

TEST=sync unit tests
BUG=none

Review URL: http://codereview.chromium.org/193085
------------------------------------------------------------------------
r26016 | sgk@google.com | 2009-09-11 23:20:05 +0200 (Fri, 11 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   A /trunk/src/chrome/browser/app_controller_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add "New Window" and "New Incognito Window" items to the Dock Menu.
Add a unit test module for AppController with a simple DockMenu test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199031
------------------------------------------------------------------------
r26015 | sky@chromium.org | 2009-09-11 23:11:12 +0200 (Fri, 11 Sep 2009) | 18 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_gtk.cc
   D /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/app/gfx/font_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc

Nukes font_skia and converts font_gtk to use pango. This was
necessitated by Pango and Skia differing on how the fonts are sized,
resulting in lots of clipping in views.

The only iffy part of this is I've made Font::nativeFont() win/mac
only (it isn't used on Linux). I did this to avoid folks accidentally
modifying the underlying font out from under Font. That said, I could
certainly nuke GetPangoFontDescription in favor of nativeFont() and
make it return the PangoFontDescription (not a copy). Let me know if
you feel strongly about converting this.

Assuming your ok with this, I'll watch the perf tests to make sure
this doesn't impact startup.

BUG=20823
TEST=none

Review URL: http://codereview.chromium.org/195058
------------------------------------------------------------------------
r26014 | kuchhal@chromium.org | 2009-09-11 23:08:53 +0200 (Fri, 11 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

While importing favicon, make sure there is an entry in the history db.

This will match with what history db does for regular bookmarked URLs with favicons - when history db is cleaned, we keep an entry in the db with 0 visits as long as that url is bookmarked.

BUG=13338

Review URL: http://codereview.chromium.org/193053
------------------------------------------------------------------------
r26007 | erg@google.com | 2009-09-11 22:56:04 +0200 (Fri, 11 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

GTK: Don't show the GTK theme button on chromeos.

Review URL: http://codereview.chromium.org/193088
------------------------------------------------------------------------
r26006 | mattm@chromium.org | 2009-09-11 22:51:10 +0200 (Fri, 11 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/extensions/docs/pageActions.html

Add button number to page action event reply object. Fix outdated page action docs.

Review URL: http://codereview.chromium.org/194082
------------------------------------------------------------------------
r26004 | phajdan.jr@chromium.org | 2009-09-11 22:25:10 +0200 (Fri, 11 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Increase number of tries in CheckInternetZoneIdentifier.

Hopefully this will be enough to kill flakiness. But I'm afraid it'll require
some better solution in the end.

TEST=ui_tests
BUG=20809

Review URL: http://codereview.chromium.org/203033
------------------------------------------------------------------------
r26002 | rafaelw@chromium.org | 2009-09-11 22:13:21 +0200 (Fri, 11 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Update ExtensionApiTest.Tabs and re-enable

BUG=20828

Review URL: http://codereview.chromium.org/199091
------------------------------------------------------------------------
r26001 | dumi@chromium.org | 2009-09-11 22:06:27 +0200 (Fri, 11 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc

Bug fix: produce unique temp file names when the VFS requests a handle to a null file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/194021
------------------------------------------------------------------------
r25996 | pam@chromium.org | 2009-09-11 21:31:38 +0200 (Fri, 11 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/test_location_bar.h

Force page-action views to update after reloading an extension, by deleting
them all. Otherwise, since the view count is unchanged, the views continue to
use stale extension information and the page-action icon fails to be displayed.

Fix excessive timeout logging in WaitForPageActionVisibilityChangeTo().

BUG=http://crbug.com/21324
TEST=write page-action extension, load as unpacked, reload, verify that icon
  is shown on a matching page. Also covered by browser_tests unit test.

Review URL: http://codereview.chromium.org/202027
------------------------------------------------------------------------
r25994 | aa@chromium.org | 2009-09-11 21:28:25 +0200 (Fri, 11 Sep 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/cross_origin_xhr_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/extensions/api_test/cross_origin_xhr
   A /trunk/src/chrome/test/data/extensions/api_test/cross_origin_xhr/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/cross_origin_xhr/test.html
   A /trunk/src/chrome/test/data/extensions/test_file.txt

Add api tests for cross-origin XHR.

Review URL: http://codereview.chromium.org/199092
------------------------------------------------------------------------
r25992 | mark@chromium.org | 2009-09-11 21:04:14 +0200 (Fri, 11 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h

[Windows] Clear Browsing Data dialog should not have any button as default
action.  Also makes the behavior in Windows side act the same as in Linux/Mac. 

Patch by Thiago Farina <thiago.farina@gmail.com>

BUG=21461
TEST=open "clear browsing data" and see if none of buttons are set as default.

Code review URL: http://codereview.chromium.org/201080

------------------------------------------------------------------------
r25988 | tony@chromium.org | 2009-09-11 20:12:56 +0200 (Fri, 11 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Since themes are designed with the custom frame in mind, we need to offset
the background when the custom frame is off.

This is needed after http://codereview.chromium.org/193030 was checked in (which fixed a related bug on Windows).

We don't translate the x values because the tab renderer code
already takes the x offset into consideration.

TEST=Install the Color Chips theme from the theme gallery.  The vertical white lines should line up on the inactive tabs.

Review URL: http://codereview.chromium.org/194080

------------------------------------------------------------------------
r25985 | jianli@chromium.org | 2009-09-11 19:46:07 +0200 (Fri, 11 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   A /trunk/src/chrome/test/data/fileurl_universalaccess.html
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/selection/4960137-expected.checksum
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/selection/4960137-expected.png
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/selection/4960137-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/selection/cleared-by-relayout-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/selection/inactive-selection-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/dom/Element/offsetLeft-offsetTop-body-quirk-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/dom/Element/offsetLeft-offsetTop-html-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/dom/HTMLDocument/document-open-return-value-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/leaks/002-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/loader/data-url-encoding-html-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/loader/data-url-encoding-svg-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/cleared-by-relayout-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/inactive-selection-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/Element/offsetLeft-offsetTop-body-quirk-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/Element/offsetLeft-offsetTop-html-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/HTMLDocument/document-open-return-value-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/leaks/002-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/loader/data-url-encoding-html-expected.txt
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/loader/data-url-encoding-svg-expected.txt
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/layout_tests/layout_package/path_utils.py
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Support running tests under LayoutTests/http/tests/local as local file, in order to mimic what run-webkit-tests does.
Search "http/tests/local/" in http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests for what it does.
This is needed by http/tests/local/resources/send-dragged-file.js.

Turn on file URL universal access in the test_shell. Delete rebaseline results of those layout tests that pass due to this change. Also add a UI test to make sure it is not on for the browser.

BUG=9275,12882
TEST=none

Review URL: http://codereview.chromium.org/201048
------------------------------------------------------------------------
r25976 | erikkay@chromium.org | 2009-09-11 17:16:45 +0200 (Fri, 11 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   A /trunk/src/chrome/browser/extensions/extension_toolstrip_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/api_test/toolstrip
   A /trunk/src/chrome/test/data/extensions/api_test/toolstrip/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/toolstrip/test.html
   M /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html

add mole collapse/expand events.  convert mappy to use this.
BUG=15494
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip

Review URL: http://codereview.chromium.org/203023
------------------------------------------------------------------------
r25973 | sky@chromium.org | 2009-09-11 15:39:25 +0200 (Fri, 11 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Adds pinned tabs to windows. As the code between windows and gtk is
quite similar, this wasn't that much work.

BUG=none
TEST=make sure tabs behave correctly on windows, as well as testing
pinning/unpinning.

Review URL: http://codereview.chromium.org/193051
------------------------------------------------------------------------
r25971 | aa@chromium.org | 2009-09-11 08:28:15 +0200 (Fri, 11 Sep 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   A /trunk/src/chrome/browser/extensions/extension_javascript_url_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/search_engines/template_url_scraper_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   M /trunk/src/chrome/test/data/extensions/api_test/README.txt
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions
   A /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/javascript_url_permissions/test.html
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Don't allow updating tabs to javascript URLs without host
permissions to that tab.

Cleaned up a few things along the way:

- added a GetExtension() method to
  ExtensionFunctionDispatcher and ExtensionFunction since it
  was used in more than one place.

- Removed first param from chrome.test.failCallback() since
  it wasn't used anywhere.

- Added a convenience CanAccessHost() method to Extension,
  since it seems likely to be commonly used.

- Refactored setup of mock host resolver in browsertest,
  since the way it was, you could only customize it at the
  testsuite level, not the test level.

Review URL: http://codereview.chromium.org/199074
------------------------------------------------------------------------
r25968 | suzhe@chromium.org | 2009-09-11 06:17:41 +0200 (Fri, 11 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc

Fix text and selection's save/restore issue of omnibox when displaying temporary text.

This CL fixes issue 21362: The original text and selection can't be reverted correctly when pressing escape key in omnibox if currently selected line is not the default match.

BUG=21362: The original text and selection can't be reverted correctly when pressing escape key in omnibox if currently selected line is not the default match.
TEST=Input something in omnibox and make sure inline autocomplete is triggered, then press down to select another line, then press escape to revert to the default match and see of the original text and selection was reverted correctly.

Review URL: http://codereview.chromium.org/194056
------------------------------------------------------------------------
r25966 | jorlow@chromium.org | 2009-09-11 05:58:45 +0200 (Fri, 11 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc
   M /trunk/src/webkit/api/public/WebStorageArea.h
   M /trunk/src/webkit/api/src/WebStorageAreaImpl.cpp
   M /trunk/src/webkit/api/src/WebStorageAreaImpl.h

Get rid of the half-working traces of locking, caching, and quotas.  It
probably shoudln't have been added in to begin with.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/203015
------------------------------------------------------------------------
r25964 | mhm@chromium.org | 2009-09-11 04:42:42 +0200 (Fri, 11 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Gtk: Allow all columns in task manager to be sortable.

BUG=21048
TEST=Open task manager and sort any column

Review URL: http://codereview.chromium.org/196040
------------------------------------------------------------------------
r25962 | estade@chromium.org | 2009-09-11 03:15:04 +0200 (Fri, 11 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Update the system favicon/folder icon on theme change.

BUG=21531
TEST=use gtk theme, look at icons in task manager, bookmark bar, tab strip, change gtk theme with gnome-appearance-properties,note that the default favicons and folder icons have changed

Review URL: http://codereview.chromium.org/202055
------------------------------------------------------------------------
r25961 | mirandac@chromium.org | 2009-09-11 03:14:05 +0200 (Fri, 11 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_incognito_tab_theme.css

Make themes in the incognito NTP which are bottom-aligned attach to the bottom of the screen, rather than the bottom of the text box.

BUG= http://crbug.com/21543
TEST= Install "Folders" theme. Open incognito window.  Observe that NTP background looks the same as it doesn in normal mode.

Review URL: http://codereview.chromium.org/202056
------------------------------------------------------------------------
r25958 | jrg@chromium.org | 2009-09-11 02:33:38 +0200 (Fri, 11 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add command line switch --activate-on-launch to help Selenium.
Implemented for Mac; behavior implicit on Windows.

If you do NOT get an "activate on launch" behavior on Windows, it is
because Selenium is not the current foreground app.  See
http://msdn.microsoft.com/en-us/library/ms633539(VS.85).aspx 
for details on foreground behavior.  This isn't something we can fix
in Chrome on Windows.

BUG=http://crbug.com/20935 
TEST=Launch Chrome from the command line.
E.g. "..../Chromium.app/Contents/MacOS/Chromium".  See it NOT gain
foreground.  Add --activate-on-launch.  DO see it gain foreground.

Review URL: http://codereview.chromium.org/202053
------------------------------------------------------------------------
r25957 | brettw@chromium.org | 2009-09-11 02:32:58 +0200 (Fri, 11 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/in_memory_database.cc

Metrics for the in-memory DB size to see if we spend too much time loading it,
and how big it ends up being.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/193061
------------------------------------------------------------------------
r25955 | agl@chromium.org | 2009-09-11 02:17:44 +0200 (Fri, 11 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/net/base/strict_transport_security_state.cc
   M /trunk/src/net/base/strict_transport_security_state.h
   M /trunk/src/net/base/strict_transport_security_state_unittest.cc

Strict transport security: add checkbox to clear state.

This patches add a checkbox to the "Clear Browsing Data" dialog which
clears the STS state when checked. Since we don't timestamp our
entries (for now at least, should we?), the duration selected has no
effect: we always clear everything.

Mac doesn't appear to have a dialog for this yet, so no Mac specific
changes.

http://codereview.chromium.org/196070

------------------------------------------------------------------------
r25953 | arv@google.com | 2009-09-11 02:10:41 +0200 (Fri, 11 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Fix undo link color

BUG=21506

TEST=Remove a thumbnail from the NTP and notice the color of the undo
link. The text should be dark blue with a lighter blue underline color.

Review URL: http://codereview.chromium.org/202052
------------------------------------------------------------------------
r25943 | tony@chromium.org | 2009-09-11 01:20:20 +0200 (Fri, 11 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Disallow popup windows from setting the window size to the exact
screen size.  This works around a WM work around that causes
the popup to end up in full screen mode.

BUG=21456
TEST=Go to www.stonephotography.ca, click on enter site, verify that
    the window is not in full screen mode (over taskbar).

Review URL: http://codereview.chromium.org/202050

------------------------------------------------------------------------
r25942 | estade@chromium.org | 2009-09-11 01:17:33 +0200 (Fri, 11 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Fix another awesome menu bar helper bug.

BUG=21492

Review URL: http://codereview.chromium.org/200088
------------------------------------------------------------------------
r25939 | mirandac@chromium.org | 2009-09-11 00:49:32 +0200 (Fri, 11 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Check in http://codereview.chromium.org/197013/show for tfarina.


Review URL: http://codereview.chromium.org/200086
------------------------------------------------------------------------
r25934 | mattm@chromium.org | 2009-09-11 00:25:16 +0200 (Fri, 11 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   A /trunk/src/chrome/browser/image_loading_tracker.cc
   A /trunk/src/chrome/browser/image_loading_tracker.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp

Linux: implement Page Actions support.

BUG=11973
TEST=load an extension with page actions, it should work like on windows.

Review URL: http://codereview.chromium.org/195050
------------------------------------------------------------------------
r25929 | tim@chromium.org | 2009-09-10 23:39:21 +0200 (Thu, 10 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc

Populate strings in gaia_login.html using jstemplates instead of literals.

BUG=21494,19896
TEST=SyncSetupWizardTest.  Open sync wizard, ensure strings are present (error cases too).


Review URL: http://codereview.chromium.org/199083
------------------------------------------------------------------------
r25928 | mpcomplete@chromium.org | 2009-09-10 23:39:09 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/renderer/render_view.cc

Make extensions use ViewMsg_EnableIntrinsicWidthChangedMode.

BUG=11974
TEST=no

Review URL: http://codereview.chromium.org/194064
------------------------------------------------------------------------
r25923 | mattm@chromium.org | 2009-09-10 23:17:22 +0200 (Thu, 10 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

Revert "Set the info bubble popups as _NET_WM_WINDOW_TYPE_UTILITY so they"
It caused a window frame to be drawn around the info bubble under sawfish.

This reverts commit r25002.

BUG=21517
TEST=see bug

Review URL: http://codereview.chromium.org/193077
------------------------------------------------------------------------
r25920 | tony@chromium.org | 2009-09-10 23:08:39 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_mac.mm
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/base/data_pack.h
   M /trunk/src/base/data_pack_unittest.cc
   M /trunk/src/base/debug_util_posix.cc
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/string_piece.cc
   M /trunk/src/base/string_piece.h
   M /trunk/src/base/string_piece_unittest.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_icu.cc
   M /trunk/src/base/sys_string_conversions.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/privacy_blacklist/blocked_response.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/jstemplate_builder.cc
   M /trunk/src/chrome/common/jstemplate_builder.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/test/v8_unit_test.cc
   M /trunk/src/chrome/test/v8_unit_test.h
   M /trunk/src/chrome/tools/mac_helpers/infoplist_strings_util.mm
   M /trunk/src/net/base/net_module.cc
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/registry_controlled_domain.cc
   M /trunk/src/net/base/registry_controlled_domain.h
   M /trunk/src/net/http/http_chunked_decoder.cc
   M /trunk/src/net/http/http_util.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc

Move StringPiece into the base namespace.  It is colliding
with the StringPiece class in icu4.2, which is a problem
when trying to use the system version of icu.

Review URL: http://codereview.chromium.org/193072

------------------------------------------------------------------------
r25913 | mdm@chromium.org | 2009-09-10 22:52:00 +0200 (Thu, 10 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Make the "get themes" button into a link instead.
BUG=21414
TEST=none

Review URL: http://codereview.chromium.org/203019
------------------------------------------------------------------------
r25911 | cpu@chromium.org | 2009-09-10 22:49:47 +0200 (Thu, 10 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Fix my change to flashing tab
- I commited the last experiment, not what I meant to commit, sorry.

TBR=darin
BUG=21481
TEST=see bug


Review URL: http://codereview.chromium.org/193076
------------------------------------------------------------------------
r25904 | stuartmorgan@google.com | 2009-09-10 21:56:17 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h

Speculative fix for Mac quarantine crash

BUG=13120
TEST=Quaraniting should continue to work on the Mac, and zone information should still be set on Windows.

Review URL: http://codereview.chromium.org/193075
------------------------------------------------------------------------
r25902 | mirandac@chromium.org | 2009-09-10 21:42:31 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Force preferences to save immediately when a theme is set, so that a browser crash does not corrupt the theme.

BUG= http://crbug.com/21488
TEST= Install a theme.  Force browser crash, and reopen. Note that theme images are not corrupted.

Review URL: http://codereview.chromium.org/200080
------------------------------------------------------------------------
r25899 | nick@chromium.org | 2009-09-10 21:31:26 +0200 (Thu, 10 Sep 2009) | 9 lines
Changed paths:
   D /trunk/src/chrome/browser/sync/engine/net/openssl_init.cc
   D /trunk/src/chrome/browser/sync/engine/net/openssl_init.h

Remove openssl_init from sync\engine.

These weren't referenced anywhere; we don't rely
on openssl.  They were just cruft.

BUG=none
TEST=builds fine without these files

Review URL: http://codereview.chromium.org/201082
------------------------------------------------------------------------
r25897 | tony@chromium.org | 2009-09-10 21:22:57 +0200 (Thu, 10 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Fix accel leak in task manager and bookmark manager by using
the same cleanup code as browser_window_gtk.

Also fix a leak of the gtk widgets when the accelerator was
not used for the task manager.  If the user closed by using the
window manager destroy, then we never called gtk_widget_destroy
on the window and leaked the widgets.

Review URL: http://codereview.chromium.org/202035

------------------------------------------------------------------------
r25895 | idanan@chromium.org | 2009-09-10 21:16:34 +0200 (Thu, 10 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.h
   A /trunk/src/chrome/browser/views/blacklist_error_dialog.cc
   A /trunk/src/chrome/browser/views/blacklist_error_dialog.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/tools/pbl_tool/pbl_tool.cc

Error diagnostics for Blacklist IO

For now, as with other extension errors, these are not i18n'd.

The blacklist loading error is though because it is most like
an error to be shown to end users.

BUG=16932
TEST=none

Review URL: http://codereview.chromium.org/173357
------------------------------------------------------------------------
r25894 | pinkerton@chromium.org | 2009-09-10 21:10:13 +0200 (Thu, 10 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Allow windows with a single tab to be merged into other windows with drag and drop. When there is a single window with a single tab, we treat it like a window move.
BUG=15108
TEST=dragging out windows and merging them back in, dragging windows around to move them. Test windows of different types (incognito) as well.
Review URL: http://codereview.chromium.org/199079
------------------------------------------------------------------------
r25884 | estade@chromium.org | 2009-09-10 20:25:50 +0200 (Thu, 10 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm

Attempt to fix memory leak in some mac tests.

Review URL: http://codereview.chromium.org/192061
------------------------------------------------------------------------
r25880 | erg@google.com | 2009-09-10 20:16:15 +0200 (Thu, 10 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/cairo_cached_surface.cc
   A /trunk/src/chrome/browser/gtk/cairo_cached_surface.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Reapplies the GdkPixbuf -> cairo surface patch.

Only difference is explicitly calling a FreePerDisplaySurfaces() function from
~GtkThemeProvider() because vtables are set to base class during destructor
calling.

BUG=http://crbug.com/10499
Original Review URL: http://codereview.chromium.org/197046

Review URL: http://codereview.chromium.org/199077
------------------------------------------------------------------------
r25879 | jhawkins@chromium.org | 2009-09-10 20:09:12 +0200 (Thu, 10 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/base/scoped_bstr_win.h
   M /trunk/src/base/scoped_variant_win.cc
   M /trunk/src/base/scoped_variant_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/history/history_publisher_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/accessibility/view_accessibility_wrapper.cc
   M /trunk/src/views/accessibility/view_accessibility_wrapper.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Use Scoped[Bstr,ComPtr,Variant] instead of their ATL equivalents to reduce dependencies on ATL.

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/200045
------------------------------------------------------------------------
r25877 | mdm@chromium.org | 2009-09-10 20:02:17 +0200 (Thu, 10 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   A /trunk/src/base/setproctitle_linux.c
   A /trunk/src/base/setproctitle_linux.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: set the process title (that shows in "ps" etc.) of renderers correctly when using the zygote.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/196009
------------------------------------------------------------------------
r25875 | phajdan.jr@chromium.org | 2009-09-10 19:50:01 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Get more info in the logs when ErrorPageTest fails.

TEST=none
BUG=19361

Review URL: http://codereview.chromium.org/199076
------------------------------------------------------------------------
r25867 | tommi@chromium.org | 2009-09-10 19:19:06 +0200 (Thu, 10 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

Supressing the referrer header in the automation url request job when going from a secure to non-secure URL.

Also calling OnSSLCertificateError in case of certificate errors.

TEST=Run automation tests.
BUG=none

Review URL: http://codereview.chromium.org/195054
------------------------------------------------------------------------
r25864 | zork@google.com | 2009-09-10 18:49:21 +0200 (Thu, 10 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Remove deprecated status flags from sync
Review URL: http://codereview.chromium.org/202033
------------------------------------------------------------------------
r25861 | mirandac@chromium.org | 2009-09-10 18:33:21 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc

Fix problem of white box appearing in themes without an NTP background image.

BUG= http://crbug.com/21290
TEST= Install a theme without an NTP image (greyscale).  Look at NTP with bookmarkbar attached and detached.  See no white box at bottom of NTP.

Review URL: http://codereview.chromium.org/194066
------------------------------------------------------------------------
r25860 | phajdan.jr@chromium.org | 2009-09-10 18:32:39 +0200 (Thu, 10 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

Get window origin only once in BrowserToolbarGtk::GetPopupBounds.

This is an optimization, and also helps stability. Fixes an intermittent DCHECK
I was hitting while working on unrelated parts of code.

TEST=There are DCHECKs that make sure the new code is valid.
BUG=none

Review URL: http://codereview.chromium.org/200069
------------------------------------------------------------------------
r25859 | erikkay@chromium.org | 2009-09-10 18:32:35 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

sliding animation for moles

BUG=15494
TEST=none

Review URL: http://codereview.chromium.org/203004
------------------------------------------------------------------------
r25857 | thomasvl@chromium.org | 2009-09-10 14:21:06 +0200 (Thu, 10 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Add the tooltips for the toolbar buttons.
Dynamically set the tooltip for the star button based on state.
  - make bookmark
  - edit bookmark
Build the go button tooltip when asked so it can react to state of the tab and of the url bar.
  - stop state
  - got to url state
  - do search state

BUG=21089
TEST=All the buttons in the toolbar should have localized tooltips.  The star's depends on it's state.  To go button will be stop, goto site, or do search (link windows).
Review URL: http://codereview.chromium.org/198027
------------------------------------------------------------------------
r25853 | nick@chromium.org | 2009-09-10 09:42:43 +0200 (Thu, 10 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/util/path_helpers-posix.cc

Fix one more checkdeps path.  Left this out
of the last change.

TEST=checkdeps.py
BUG=none

Review URL: http://codereview.chromium.org/200076
------------------------------------------------------------------------
r25852 | suzhe@chromium.org | 2009-09-10 09:22:48 +0200 (Thu, 10 Sep 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   A /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.cc
   A /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler.h
   A /trunk/src/chrome/browser/renderer_host/gtk_key_bindings_handler_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/edit_command.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   A /trunk/src/chrome/test/data/gtk_key_bindings_test_gtkrc
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc

Supports Gtk keyboard themes.

This CL fixes issue 11480: Support GTK keyboard themes (emacs keybindings).
A new class GtkKeyBindingsHandler has been added, which matches a key event against key bindings defined in current Gtk keyboard theme.
A new render message ViewMsg_SetEditCommandsForNextKeyEvent has been added for sending edit commands associated to a key event to renderer. This message shall be sent just before sending the key event. RenderView will handle this event and cache the edit commands until the key event is processed.
When processing the key event, EditClientImpl::handleKeyboardEvent() will eventually be called to handle the key event, if it's not handled by DOM and the focus is inside an input box. Then a newly added method WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent(), which is implemented in RenderView, will be called by EditClientImpl::handleKeyboardEvent() to execute edit commands previously sent from browser by ViewMsg_SetEditCommandsForNextKeyEvent message. If WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent() returns false, which means the key event doesn't have edit command associated, EditClientImpl will handle the key event with built-in logic, which may trigger a built-in key binding.
With this approach, system defined key bindings always have higher priority than built-in key bindings defined in editor_client_impl.cc.

Known issue:
If a key event matches not only a system defined key binding but also an accesskey of a DOM element, then both corresponding edit commands and accesskey action will be executed. Because accesskey is handled in WebViewImpl::CharEvent(), while edit commands are bound to RawKeyDown or KeyUp events.

BUG=11480 "Support GTK keyboard themes (emacs keybindings)"
TEST=Switch to Emacs keyboard theme by changing the value of gconf key
"/desktop/gnome/interface/gtk_key_theme" to "Emacs", then starts chrome and
opens a webpage with a text input box. Input something into the text box, then
press any of the Emacs key bindings defined in
/usr/share/themes/Emacs/gtk-2.0-key/gtkrc, to see if it works as expected. For
example, ctrl-p should move the cursor up one line, and ctrl-k should delete to
the end of paragraph.

Review URL: http://codereview.chromium.org/165293
------------------------------------------------------------------------
r25851 | nick@chromium.org | 2009-09-10 09:19:12 +0200 (Thu, 10 Sep 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/notifier/DEPS
   M /trunk/src/chrome/browser/sync/notifier/base/string_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/base/time_unittest.cc
   M /trunk/src/chrome/browser/sync/notifier/communicator/mailbox_unittest.cc

Fix checkdeps by removing some include paths
and adding a DEPS rule to allow "talk/".

This code is not yet compiled,
but it is still subject to checkdeps.

TEST=ran checkdeps.py
BUG=none

Review URL: http://codereview.chromium.org/201077
------------------------------------------------------------------------
r25850 | nick@chromium.org | 2009-09-10 08:05:27 +0200 (Thu, 10 Sep 2009) | 41 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/engine/all_status.cc
   A /trunk/src/chrome/browser/sync/engine/all_status.h
   A /trunk/src/chrome/browser/sync/engine/all_status_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/apply_updates_command.cc
   A /trunk/src/chrome/browser/sync/engine/apply_updates_command.h
   A /trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/auth_watcher.cc
   A /trunk/src/chrome/browser/sync/engine/auth_watcher.h
   A /trunk/src/chrome/browser/sync/engine/authenticator.cc
   A /trunk/src/chrome/browser/sync/engine/authenticator.h
   A /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
   A /trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
   A /trunk/src/chrome/browser/sync/engine/build_commit_command.cc
   A /trunk/src/chrome/browser/sync/engine/build_commit_command.h
   A /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.cc
   A /trunk/src/chrome/browser/sync/engine/change_reorder_buffer.h
   A /trunk/src/chrome/browser/sync/engine/client_command_channel.h
   A /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.cc
   A /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.h
   A /trunk/src/chrome/browser/sync/engine/conflict_resolver.cc
   A /trunk/src/chrome/browser/sync/engine/conflict_resolver.h
   A /trunk/src/chrome/browser/sync/engine/download_updates_command.cc
   A /trunk/src/chrome/browser/sync/engine/download_updates_command.h
   A /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.cc
   A /trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h
   A /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc
   A /trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.h
   A /trunk/src/chrome/browser/sync/engine/model_safe_worker.h
   A /trunk/src/chrome/browser/sync/engine/net
   A /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.cc
   A /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator.h
   A /trunk/src/chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/net/http_return.h
   A /trunk/src/chrome/browser/sync/engine/net/openssl_init.cc
   A /trunk/src/chrome/browser/sync/engine/net/openssl_init.h
   A /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.cc
   A /trunk/src/chrome/browser/sync/engine/net/server_connection_manager.h
   A /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
   A /trunk/src/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
   A /trunk/src/chrome/browser/sync/engine/net/url_translator.cc
   A /trunk/src/chrome/browser/sync/engine/net/url_translator.h
   A /trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc
   A /trunk/src/chrome/browser/sync/engine/post_commit_message_command.h
   A /trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc
   A /trunk/src/chrome/browser/sync/engine/process_commit_response_command.h
   A /trunk/src/chrome/browser/sync/engine/process_updates_command.cc
   A /trunk/src/chrome/browser/sync/engine/process_updates_command.h
   A /trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.cc
   A /trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.h
   A /trunk/src/chrome/browser/sync/engine/sync_cycle_state.h
   A /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
   A /trunk/src/chrome/browser/sync/engine/sync_process_state.h
   A /trunk/src/chrome/browser/sync/engine/syncapi.cc
   A /trunk/src/chrome/browser/sync/engine/syncer.cc
   A /trunk/src/chrome/browser/sync/engine/syncer.h
   A /trunk/src/chrome/browser/sync/engine/syncer_command.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_command.h
   A /trunk/src/chrome/browser/sync/engine/syncer_end_command.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_end_command.h
   A /trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_proto_util.h
   A /trunk/src/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_session.h
   A /trunk/src/chrome/browser/sync/engine/syncer_status.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_status.h
   A /trunk/src/chrome/browser/sync/engine/syncer_thread.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_thread.h
   A /trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_types.h
   A /trunk/src/chrome/browser/sync/engine/syncer_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_util.cc
   A /trunk/src/chrome/browser/sync/engine/syncer_util.h
   A /trunk/src/chrome/browser/sync/engine/syncproto.h
   A /trunk/src/chrome/browser/sync/engine/syncproto_unittest.cc
   A /trunk/src/chrome/browser/sync/engine/update_applicator.cc
   A /trunk/src/chrome/browser/sync/engine/update_applicator.h
   A /trunk/src/chrome/browser/sync/engine/verify_updates_command.cc
   A /trunk/src/chrome/browser/sync/engine/verify_updates_command.h
   A /trunk/src/chrome/browser/sync/notifier
   A /trunk/src/chrome/browser/sync/notifier/base
   A /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.cc
   A /trunk/src/chrome/browser/sync/notifier/base/async_dns_lookup.h
   A /trunk/src/chrome/browser/sync/notifier/base/async_network_alive.h
   A /trunk/src/chrome/browser/sync/notifier/base/fastalloc.h
   A /trunk/src/chrome/browser/sync/notifier/base/linux
   A /trunk/src/chrome/browser/sync/notifier/base/linux/network_status_detector_task_linux.cc
   A /trunk/src/chrome/browser/sync/notifier/base/linux/time_linux.cc
   A /trunk/src/chrome/browser/sync/notifier/base/nethelpers.cc
   A /trunk/src/chrome/browser/sync/notifier/base/nethelpers.h
   A /trunk/src/chrome/browser/sync/notifier/base/network_status_detector_task.cc
   A /trunk/src/chrome/browser/sync/notifier/base/network_status_detector_task.h
   A /trunk/src/chrome/browser/sync/notifier/base/network_status_detector_task_mt.cc
   A /trunk/src/chrome/browser/sync/notifier/base/network_status_detector_task_mt.h
   A /trunk/src/chrome/browser/sync/notifier/base/posix
   A /trunk/src/chrome/browser/sync/notifier/base/posix/time_posix.cc
   A /trunk/src/chrome/browser/sync/notifier/base/signal_thread_task.h
   A /trunk/src/chrome/browser/sync/notifier/base/static_assert.h
   A /trunk/src/chrome/browser/sync/notifier/base/string.cc
   A /trunk/src/chrome/browser/sync/notifier/base/string.h
   A /trunk/src/chrome/browser/sync/notifier/base/string_unittest.cc
   A /trunk/src/chrome/browser/sync/notifier/base/task_pump.cc
   A /trunk/src/chrome/browser/sync/notifier/base/task_pump.h
   A /trunk/src/chrome/browser/sync/notifier/base/time.cc
   A /trunk/src/chrome/browser/sync/notifier/base/time.h
   A /trunk/src/chrome/browser/sync/notifier/base/time_unittest.cc
   A /trunk/src/chrome/browser/sync/notifier/base/timer.cc
   A /trunk/src/chrome/browser/sync/notifier/base/timer.h
   A /trunk/src/chrome/browser/sync/notifier/base/utils.h
   A /trunk/src/chrome/browser/sync/notifier/base/win32
   A /trunk/src/chrome/browser/sync/notifier/base/win32/async_network_alive_win32.cc
   A /trunk/src/chrome/browser/sync/notifier/base/win32/time_win32.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator
   A /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/auth_task.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/auto_reconnect.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/auto_reconnect.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/connection_options.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/connection_options.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/connection_settings.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/connection_settings.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/const_communicator.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/login.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/login.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/login_failure.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/login_settings.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/mailbox.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/mailbox.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/mailbox_unittest.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/product_info.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/product_info.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/single_login_attempt.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/talk_auth_task.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers-inl.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/xml_parse_helpers.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_connection_generator.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_connection_generator.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_log.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_log.h
   A /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.cc
   A /trunk/src/chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.h
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiaauth.h
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/gaiahelper.h
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/inet_aton.h
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/sigslotrepeater.h
   A /trunk/src/chrome/browser/sync/notifier/gaia_auth/win32window.cc
   A /trunk/src/chrome/browser/sync/notifier/listener
   A /trunk/src/chrome/browser/sync/notifier/listener/listen_task.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/listen_task.h
   A /trunk/src/chrome/browser/sync/notifier/listener/listener_unittest.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread.h
   A /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_impl.h
   A /trunk/src/chrome/browser/sync/notifier/listener/mediator_thread_mock.h
   A /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/send_update_task.h
   A /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/subscribe_task.h
   A /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator.h
   A /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.cc
   A /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_impl.h
   A /trunk/src/chrome/browser/sync/notifier/listener/talk_mediator_unittest.cc
   A /trunk/src/chrome/browser/sync/protocol
   A /trunk/src/chrome/browser/sync/protocol/proto2_to_oproto.py
   A /trunk/src/chrome/browser/sync/protocol/service_constants.h
   A /trunk/src/chrome/browser/sync/protocol/sync.proto
   A /trunk/src/chrome/browser/sync/syncable
   A /trunk/src/chrome/browser/sync/syncable/blob.h
   A /trunk/src/chrome/browser/sync/syncable/dir_open_result.h
   A /trunk/src/chrome/browser/sync/syncable/directory_backing_store.cc
   A /trunk/src/chrome/browser/sync/syncable/directory_backing_store.h
   A /trunk/src/chrome/browser/sync/syncable/directory_event.h
   A /trunk/src/chrome/browser/sync/syncable/directory_manager.cc
   A /trunk/src/chrome/browser/sync/syncable/directory_manager.h
   A /trunk/src/chrome/browser/sync/syncable/path_name_cmp.h
   A /trunk/src/chrome/browser/sync/syncable/syncable-inl.h
   A /trunk/src/chrome/browser/sync/syncable/syncable.cc
   A /trunk/src/chrome/browser/sync/syncable/syncable.h
   A /trunk/src/chrome/browser/sync/syncable/syncable_changes_version.h
   A /trunk/src/chrome/browser/sync/syncable/syncable_columns.h
   A /trunk/src/chrome/browser/sync/syncable/syncable_id.cc
   A /trunk/src/chrome/browser/sync/syncable/syncable_id.h
   A /trunk/src/chrome/browser/sync/syncable/syncable_id_unittest.cc
   A /trunk/src/chrome/browser/sync/syncable/syncable_unittest.cc
   A /trunk/src/chrome/browser/sync/util
   A /trunk/src/chrome/browser/sync/util/character_set_converters-linux.cc
   A /trunk/src/chrome/browser/sync/util/character_set_converters-win32.cc
   A /trunk/src/chrome/browser/sync/util/character_set_converters.cc
   A /trunk/src/chrome/browser/sync/util/character_set_converters.h
   A /trunk/src/chrome/browser/sync/util/character_set_converters_unittest.cc
   A /trunk/src/chrome/browser/sync/util/closure.h
   A /trunk/src/chrome/browser/sync/util/compat-file-posix.cc
   A /trunk/src/chrome/browser/sync/util/compat-file-win.cc
   A /trunk/src/chrome/browser/sync/util/compat-file.h
   A /trunk/src/chrome/browser/sync/util/compat-pthread.h
   A /trunk/src/chrome/browser/sync/util/crypto_helpers.cc
   A /trunk/src/chrome/browser/sync/util/crypto_helpers.h
   A /trunk/src/chrome/browser/sync/util/crypto_helpers_unittest.cc
   A /trunk/src/chrome/browser/sync/util/data_encryption.cc
   A /trunk/src/chrome/browser/sync/util/data_encryption.h
   A /trunk/src/chrome/browser/sync/util/data_encryption_unittest.cc
   A /trunk/src/chrome/browser/sync/util/dbgq.h
   A /trunk/src/chrome/browser/sync/util/event_sys-inl.h
   A /trunk/src/chrome/browser/sync/util/event_sys.h
   A /trunk/src/chrome/browser/sync/util/event_sys_unittest.cc
   A /trunk/src/chrome/browser/sync/util/fast_dump.h
   A /trunk/src/chrome/browser/sync/util/highres_timer-linux.cc
   A /trunk/src/chrome/browser/sync/util/highres_timer-linux.h
   A /trunk/src/chrome/browser/sync/util/highres_timer-win32.cc
   A /trunk/src/chrome/browser/sync/util/highres_timer-win32.h
   A /trunk/src/chrome/browser/sync/util/highres_timer.h
   A /trunk/src/chrome/browser/sync/util/highres_timer_unittest.cc
   A /trunk/src/chrome/browser/sync/util/path_helpers-linux.cc
   A /trunk/src/chrome/browser/sync/util/path_helpers-posix.cc
   A /trunk/src/chrome/browser/sync/util/path_helpers.cc
   A /trunk/src/chrome/browser/sync/util/path_helpers.h
   A /trunk/src/chrome/browser/sync/util/path_helpers_unittest.cc
   A /trunk/src/chrome/browser/sync/util/pthread_helpers.cc
   A /trunk/src/chrome/browser/sync/util/pthread_helpers.h
   A /trunk/src/chrome/browser/sync/util/pthread_helpers_fwd.h
   A /trunk/src/chrome/browser/sync/util/query_helpers.cc
   A /trunk/src/chrome/browser/sync/util/query_helpers.h
   A /trunk/src/chrome/browser/sync/util/query_helpers_unittest.cc
   A /trunk/src/chrome/browser/sync/util/row_iterator.h
   A /trunk/src/chrome/browser/sync/util/signin.h
   A /trunk/src/chrome/browser/sync/util/sync_types.h
   A /trunk/src/chrome/browser/sync/util/user_settings-posix.cc
   A /trunk/src/chrome/browser/sync/util/user_settings-win32.cc
   A /trunk/src/chrome/browser/sync/util/user_settings.cc
   A /trunk/src/chrome/browser/sync/util/user_settings.h
   A /trunk/src/chrome/browser/sync/util/user_settings_unittest.cc
   A /trunk/src/chrome/test/sync
   A /trunk/src/chrome/test/sync/engine
   A /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.cc
   A /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator.h
   A /trunk/src/chrome/test/sync/engine/mock_gaia_authenticator_unittest.cc
   A /trunk/src/chrome/test/sync/engine/mock_server_connection.cc
   A /trunk/src/chrome/test/sync/engine/mock_server_connection.h
   A /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.cc
   A /trunk/src/chrome/test/sync/engine/test_directory_setter_upper.h
   A /trunk/src/chrome/test/sync/engine/test_id_factory.h

Initial commit of sync engine code to browser/sync.

The code is not built on any platform yet.  That will arrive
as a subsequent checkin.

This is an implementation of the interface exposed earlier
through syncapi.h.  It is the client side of a sync
protocol that lets users sync their browser data
(currently, just bookmarks) with their Google Account.

Table of contents:

browser/sync/
  protocol - The protocol definition, and
             other definitions necessary to connect to
             the service.
  syncable/ - defines a data model for syncable objects,
              and provides a sqlite-based backing store
              for this model.
  engine/ - includes the core sync logic, including commiting
            changes to the server, downloading changes from
            the server, resolving conflicts, other parts of
            the sync algorithm.
  engine/net - parts of the sync engine focused on the
               business of talking to the server.  Some of
               this is binds a generic "server connection"
               interface to a concrete implementation
               provided by Chromium.
  notifier - the part of the syncer focused on the business
             of sending and receiving xmpp notifications.
             Notifications are used instead of polling to
             achieve very low latency change propagation.
  util - not necessarily sync specific utility code.  Much
         of this is scaffolding which should either be
         replaced by, or merged with, the utility code
         in base/.

BUG=none
TEST=this code includes its own suite of unit tests.

Review URL: http://codereview.chromium.org/194065
------------------------------------------------------------------------
r25842 | huanr@chromium.org | 2009-09-10 07:00:20 +0200 (Thu, 10 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/visit_log.cc
   M /trunk/src/chrome/browser/history/visit_log.h

Retry 25770 after fixing Valgrind issue.

Enable database logging on history thread.
Original review: http://codereview.chromium.org/198011

BUG=16591
TEST=History UI test


Review URL: http://codereview.chromium.org/194067
------------------------------------------------------------------------
r25837 | mirandac@chromium.org | 2009-09-10 05:08:00 +0200 (Thu, 10 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h

http://src.chromium.org/viewvc/chrome?view=rev&revision=25829 should have included this change to the signature of the SaveThemeBitmap method.

BUG= none
TEST= none

TBR: glen

Review URL: http://codereview.chromium.org/196073
------------------------------------------------------------------------
r25836 | estade@chromium.org | 2009-09-10 04:15:56 +0200 (Thu, 10 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc

Put the find bar back for mac and linux.

BUG=21443

Review URL: http://codereview.chromium.org/192060
------------------------------------------------------------------------
r25834 | mirandac@chromium.org | 2009-09-10 04:04:38 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc

Ensure that tips change when the Chrome language changes.

BUG= http://crbug.com/21394
TEST= Change chrome language.  Close and reopen browser.  Tips should appear in new language, or, if not available, they should not appear.

Review URL: http://codereview.chromium.org/199073
------------------------------------------------------------------------
r25833 | estade@chromium.org | 2009-09-10 04:00:50 +0200 (Thu, 10 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/base/clipboard.cc
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_mac.mm
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/base/scoped_clipboard_writer.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc

Clipboard:

- Move link construction logic to scoped_clipboard_writer.cc
- Make callers use EscapeForHTML on the anchor text
- Make WriteHyperlink just write html, and not a bookmark as well (only affects one caller, which I updated)
- implement WriteBookmark for gtk

BUG=18034,18035

Review URL: http://codereview.chromium.org/194052
------------------------------------------------------------------------
r25832 | mdm@chromium.org | 2009-09-10 03:49:22 +0200 (Thu, 10 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Linux: avoid a NOTREACHED() by not reaching it.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/195046
------------------------------------------------------------------------
r25831 | mattm@chromium.org | 2009-09-10 03:29:02 +0200 (Thu, 10 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Simplify the gtk location bar padding and make it more consistent.

Sets the container border and box padding values, so that each widget doesn't need an alignment to pad itself.

With this the horizontal padding is almost the same as windows (in a few cases we have 1 more pixel between elements.)
The vertical padding should be unchanged.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/195048
------------------------------------------------------------------------
r25829 | mirandac@chromium.org | 2009-09-10 03:24:03 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Ensure that inactive tab images line up correctly with frame image when themed.  Also fix HasCustomImage so that it only returns true when the image is in the extension's original set, not just a generated theme for the cache.

BUG= http://crbug.com/21134
TEST= install a theme with a detailed frame background.  Open many tabs.  Make sure the inactive tab image lines up with the frame image.

Review URL: http://codereview.chromium.org/193030
------------------------------------------------------------------------
r25828 | erg@google.com | 2009-09-10 03:12:19 +0200 (Thu, 10 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   D /trunk/src/chrome/browser/gtk/cairo_cached_surface.cc
   D /trunk/src/chrome/browser/gtk/cairo_cached_surface.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Revert "Upload GdkPixbufs into cairo surfaces so they (hopefully) live on the X
server and have better performance. In the presence of XRender, let cairo do
things smarter."

Valgrind problems.

This reverts commit 03871714c3e5b39ee0f8369ecc2313c02fe0ca08 (r25814).

Review URL: http://codereview.chromium.org/200071
------------------------------------------------------------------------
r25826 | kuchhal@chromium.org | 2009-09-10 02:50:09 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc

Disable ViewIDTest.Basic.

BUG=21443
TBR=davemoore

Review URL: http://codereview.chromium.org/202036
------------------------------------------------------------------------
r25822 | jar@chromium.org | 2009-09-10 02:04:41 +0200 (Thu, 10 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/third_party/sqlite/src/pager.c

Temporarilly comment out SQLite load optimization

This is meant to test to see if we can reduce SQL related crashes by
removing the pre-load optimization.

I also added a line of defensive code (initializing a pointer).


r=brettw
Review URL: http://codereview.chromium.org/203011
------------------------------------------------------------------------
r25821 | estade@chromium.org | 2009-09-10 01:57:48 +0200 (Thu, 10 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: fix bookmark bar regression:

show bookmark folder dropdowns even if there is no overflow

BUG=21430
Review URL: http://codereview.chromium.org/203010
------------------------------------------------------------------------
r25819 | davemoore@chromium.org | 2009-09-10 01:48:30 +0200 (Thu, 10 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/base/keyboard_codes_linux.h
   M /trunk/src/base/keyboard_codes_mac.h
   M /trunk/src/base/keyboard_codes_win.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   A /trunk/src/chrome/browser/views/find_bar_host.cc (from /trunk/src/chrome/browser/views/find_bar_win.cc:25582)
   A /trunk/src/chrome/browser/views/find_bar_host.h (from /trunk/src/chrome/browser/views/find_bar_win.h:25582)
   A /trunk/src/chrome/browser/views/find_bar_host_browsertest.cc (from /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc:25582)
   A /trunk/src/chrome/browser/views/find_bar_host_gtk.cc
   A /trunk/src/chrome/browser/views/find_bar_host_interactive_uitest.cc (from /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc:25582)
   A /trunk/src/chrome/browser/views/find_bar_host_uitest.cc (from /trunk/src/chrome/browser/views/find_bar_win_uitest.cc:25582)
   A /trunk/src/chrome/browser/views/find_bar_host_win.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   D /trunk/src/chrome/browser/views/find_bar_win.cc
   D /trunk/src/chrome/browser/views/find_bar_win.h
   D /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   D /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   D /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc

First cut at implementation of FindBar for views / gtk
Also had to implement change notification for TextField on views / gtk
Review URL: http://codereview.chromium.org/200035
------------------------------------------------------------------------
r25814 | erg@google.com | 2009-09-10 01:07:10 +0200 (Thu, 10 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/cairo_cached_surface.cc
   A /trunk/src/chrome/browser/gtk/cairo_cached_surface.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Upload GdkPixbufs into cairo surfaces so they (hopefully) live on the X server and have better performance. In the presence of XRender, let cairo do things smarter.

This is a big win performance wise. BrowserWindowGtk::OnCustomFrameExpose, a heavy user of images sped up from an average runtime of 20.5ms to 0.7ms.

TEST=Run through valgrind, don't leak memory.
TEST=Run both before and after using xtrace. Notice fewer XCreatePixmap requests and more XRender-CreatePicture requests.
BUG=http://crbug.com/10499

Review URL: http://codereview.chromium.org/197046
------------------------------------------------------------------------
r25811 | arv@google.com | 2009-09-10 00:56:53 +0200 (Thu, 10 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Fix issue where dragged thumbnail had the wrong z-index.

BUG=20903

TEST=Drag a thumbnail and release the mouse where you drqagged the
thumbnail from. Now, be quick, and drag the same thumbnail again. THe
thumbnail should not be displayed behind any other thumbnails.


Review URL: http://codereview.chromium.org/203006
------------------------------------------------------------------------
r25810 | xji@chromium.org | 2009-09-10 00:56:28 +0200 (Thu, 10 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_i18n_api.cc
   A /trunk/src/chrome/browser/extensions/extension_i18n_api.h
   A /trunk/src/chrome/browser/extensions/extension_i18n_apitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/i18n.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   A /trunk/src/chrome/test/data/extensions/api_test/i18n
   A /trunk/src/chrome/test/data/extensions/api_test/i18n/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/i18n/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/i18n/test.js
   A /trunk/src/chrome/test/data/extensions/samples/i18n
   A /trunk/src/chrome/test/data/extensions/samples/i18n/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/i18n/toolstrip.html

Added chrome.i18n extension API.
The API proposal doc is 
http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/i18n-api

This CL only adds the getter of accept languages: 
chrome.i18n.getAcceptLanguages().

The setter of accept languages will be added in a separate CL.

BUG=http://crbug.com/14574
TEST=TEST=There is an extension in chrome\test\data\extensions\samples\i18n.
Load this extension. It creates a toolstrip button.  Click this button, you
should get chrome's accept languages.
Review URL: http://codereview.chromium.org/174116
------------------------------------------------------------------------
r25789 | arv@google.com | 2009-09-09 23:20:24 +0200 (Wed, 09 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Disable tabbing to hidden elements.

This is a work around since the WebKit fix is not on the M3 branch.

BUG=15711

TEST=Tab around. At all times something on the page should have focus
(unless the address bar got the focus).


Review URL: http://codereview.chromium.org/201068
------------------------------------------------------------------------
r25788 | jhawkins@chromium.org | 2009-09-09 23:17:44 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/base/gfx/point.cc
   M /trunk/src/base/gfx/point.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/widget/aero_tooltip_manager.cc

Use gfx::Point instead of GET_X/Y_LPARAM to reduce a dependency on ATL.

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/195035
------------------------------------------------------------------------
r25787 | pinkerton@chromium.org | 2009-09-09 23:16:22 +0200 (Wed, 09 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Start a drag if the tab is dragged off the sides of the window.
BUG=14926
TEST=drag tabs and make sure nothing breaks.
Review URL: http://codereview.chromium.org/195043
------------------------------------------------------------------------
r25786 | pinkerton@chromium.org | 2009-09-09 23:16:05 +0200 (Wed, 09 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.mm
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/spellchecker_linux.cc
   M /trunk/src/chrome/browser/spellchecker_mac.mm
   M /trunk/src/chrome/browser/spellchecker_platform_engine.h
   M /trunk/src/chrome/browser/spellchecker_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Adds support for the os x spelling panel to chromium. Users can
now access it from the main menu and context menu and use it to perform
spelling tasks. For more detail, see
http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc
Patch from pwicks86@gmail.com (Paul Wicks).
BUG=None
TEST=The spelling panel should work in os x.
------------------------------------------------------------------------
r25781 | huanr@chromium.org | 2009-09-09 22:06:34 +0200 (Wed, 09 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/history/history.cc

Revert r25770 due to valgrind failures on Linux.

TEST=none.
BUG=none.

Review URL: http://codereview.chromium.org/199065
------------------------------------------------------------------------
r25780 | jhawkins@chromium.org | 2009-09-09 22:06:05 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_win.cc
   M /trunk/src/chrome/browser/window_sizer_win.cc
   M /trunk/src/views/controls/table/table_view.cc

Use RECT instead of CRect to reduce dependencies on ATL.

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/195036
------------------------------------------------------------------------
r25779 | cira@chromium.org | 2009-09-09 22:05:45 +0200 (Wed, 09 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   M /trunk/src/chrome/browser/extensions/extension_l10n_util.h
   M /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en_US
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en_US/messages.json
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/sr
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/sr/messages.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json

Simple fix of extension_l10n_util that allows folders in form ".some_name" to exist in _locales folder.
It helps testing/loading extensions from svn tree (skips .svn folder, doesn't fail).

Review URL: http://codereview.chromium.org/196029
------------------------------------------------------------------------
r25778 | thestig@chromium.org | 2009-09-09 22:00:13 +0200 (Wed, 09 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/base/file_version_info.cc
   M /trunk/src/base/file_version_info_unittest.cc
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc
   M /trunk/src/chrome/common/json_value_serializer_perftest.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/unittest_test_server.h

Fix to use FilePath version of PathService::Get.

BUG=None
TEST=None

Original Review URL: http://codereview.chromium.org/174189
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/193047
------------------------------------------------------------------------
r25777 | mdm@chromium.org | 2009-09-09 21:59:33 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Don't do a default browser check when new tabs are opened via the command line.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/203001
------------------------------------------------------------------------
r25773 | mdm@chromium.org | 2009-09-09 21:51:59 +0200 (Wed, 09 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Small comment updates. No code change.
BUG=none
TEST=none

------------------------------------------------------------------------
r25770 | huanr@chromium.org | 2009-09-09 21:36:01 +0200 (Wed, 09 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/history/history.cc

Enable database logging on history thread.

BUG=16591
TEST=History UI test

Review URL: http://codereview.chromium.org/198011
------------------------------------------------------------------------
r25769 | cpu@chromium.org | 2009-09-09 21:35:31 +0200 (Wed, 09 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add 3 more flavors of the try chrome toast
- Different strings, pretty much the same deal.
- One case removes the radio buttons.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/198038
------------------------------------------------------------------------
r25767 | mpcomplete@chromium.org | 2009-09-09 21:09:15 +0200 (Wed, 09 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h

Don't send the channel-disconnect message if the recipient is in the process
of closing.

This is an attempt to fix a crash bug.

TEST=no
BUG=21201

Review URL: http://codereview.chromium.org/197054
------------------------------------------------------------------------
r25766 | estade@chromium.org | 2009-09-09 21:08:23 +0200 (Wed, 09 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK: fix tabstrip index misalignment during tab removal.

Repro steps:
- open a gmail tab and get someone to message you such that the tab title keeps changing
- put that tab to the right of a bunch of other tabs
- close a bunch of the tabs to the left of gmail
Each time you close a tab you have about a 10% chance of reproing.

The solution is essentially copy-pasted from the windows tabstrip.

The Browser change is somewhat unrelated. I noticed the comment "Do not dereference |contents|" and that we were in fact dereferncing |contents|, so I worked around it.

BUG=13811

Review URL: http://codereview.chromium.org/199054
------------------------------------------------------------------------
r25761 | jhawkins@chromium.org | 2009-09-09 20:55:35 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/ui/npapi_uitest.cc

Remove unused ATL headers.

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/194051
------------------------------------------------------------------------
r25760 | sidchat@google.com | 2009-09-09 20:51:44 +0200 (Wed, 09 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Make BrowserView layout both extension shelf and bookmarks bar if toolstrips change in the extension shelf.

BUG=21269
BUG=21270
BUG=21274
TEST=none
Review URL: http://codereview.chromium.org/192041
------------------------------------------------------------------------
r25752 | sidchat@google.com | 2009-09-09 19:39:55 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Disable extensions shelf toggle {Ctrl + Alt + B} for extensions appearing on top.

BUG=20936
TEST=none
Review URL: http://codereview.chromium.org/194042
------------------------------------------------------------------------
r25739 | cpu@chromium.org | 2009-09-09 19:04:36 +0200 (Wed, 09 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Fix for the flashing of the front tab.
- The background tabs think they are visible causing paints to
  be executed. These steal the backing store from the visible tab

Please read the bug for more info.

BUG=20831
TEST= see bug for steps


Review URL: http://codereview.chromium.org/199010
------------------------------------------------------------------------
r25738 | mirandac@chromium.org | 2009-09-09 19:01:16 +0200 (Wed, 09 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc

Check in patch for pierre.lafayette, http://codereview.chromium.org/178059/show.

Review URL: http://codereview.chromium.org/194057
------------------------------------------------------------------------
r25731 | rohitrao@chromium.org | 2009-09-09 18:32:47 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm

Reverting 22324.  Reenables CustomHomePagesModelTest.ModelChangedNotification on Mac.

BUG=http://crbug.com/17452
TEST=Test should not be flaky.
Review URL: http://codereview.chromium.org/193058
------------------------------------------------------------------------
r25722 | rohitrao@chromium.org | 2009-09-09 16:59:38 +0200 (Wed, 09 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

[Mac] Force-enable the find next/previous buttons when pressing
Cmd-F to repeat a search.

BUG=http://crbug.com/18762
BUG=http://crbug.com/20273
TEST=See test cases in bugs.  Both should work now.
Review URL: http://codereview.chromium.org/200050
------------------------------------------------------------------------
r25711 | mnaganov@chromium.org | 2009-09-09 10:04:46 +0200 (Wed, 09 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/inspector_controller.js

DevTools: A quick fix to enable interactive_ui_tests.

Need to figure out why settings are inavailable through InspectorController.
For now, just stub them.

BUG=http://crbug.com/21277
TEST=none

Review URL: http://codereview.chromium.org/196060
------------------------------------------------------------------------
r25708 | jshin@chromium.org | 2009-09-09 08:49:08 +0200 (Wed, 09 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/.gitignore
   M /trunk/src/DEPS
   M /trunk/src/app/app.gyp
   M /trunk/src/base/base.gyp
   M /trunk/src/base/icu_util.cc
   M /trunk/src/build/all.gyp
   M /trunk/src/build/temp_gyp/googleurl.gyp
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vsprops
   M /trunk/src/chrome/installer/installer.gyp
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/installer/mini_installer.gyp
   M /trunk/src/chrome/tools/build/win/FILES
   M /trunk/src/chrome/tools/build/win/server.rules
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/printing/printing.gyp
   M /trunk/src/third_party/libxml/README.chromium
   M /trunk/src/third_party/libxml/build/libxml.vsprops
   M /trunk/src/third_party/libxml/libxml.gyp
   A /trunk/src/third_party/libxml/xmldummy_mac.cc
   M /trunk/src/third_party/libxslt/build/libxslt.vsprops
   M /trunk/src/third_party/sqlite/sqlite.gyp
   M /trunk/src/third_party/sqlite/src/shell_icu_win.c
   M /trunk/src/views/views.gyp
   M /trunk/src/webkit/default_plugin/default_plugin.gyp
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/webkit.gyp

Replace icu38/icu38.gyp  with icu/icu.gyp in gyp files replace all the references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc


In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). 

Also updated is the test results for net_util_unittests.


This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). 

BUG=8198
TEST=On all platforms, all the targets are built fine.

Review URL: http://codereview.chromium.org/172031
------------------------------------------------------------------------
r25701 | sky@chromium.org | 2009-09-09 05:20:55 +0200 (Wed, 09 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/views/controls/menu/menu_config_gtk.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_delegate.h
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/controls/menu/menu_separator_gtk.cc
   M /trunk/src/views/controls/menu/submenu_view.cc
   M /trunk/src/views/controls/menu/submenu_view.h

Wires up drag and drop for bookmark menus and cleans up a couple of
minor painting issues.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/199050
------------------------------------------------------------------------
r25699 | evan@chromium.org | 2009-09-09 04:01:10 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_bar_helper.cc
   M /trunk/src/net/base/dns_util.cc

Include fixes for gcc >= 4.3

Patch by Joel Stanley <joel@jms.id.au>

Review URL: http://codereview.chromium.org/197055
------------------------------------------------------------------------
r25695 | estade@chromium.org | 2009-09-09 03:02:46 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Don't let the page widget(s) handle key events that webkit didn't handle.

BUG=21165

Review URL: http://codereview.chromium.org/201047
------------------------------------------------------------------------
r25693 | ukai@chromium.org | 2009-09-09 02:46:58 +0200 (Wed, 09 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/pipe_reader.h

Fix build break for chrome os.

Add #include <stdio.h> for fclose et al.
Without stdio.h, we got errors like:
In file included from /usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:5:
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h: In destructor 'virtual PipeReader::~PipeReader()':
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.h:33: error: 'fclose' was not declared in this scope
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc: In member function 'virtual std::string PipeReader::Read(uint32)':
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:11: error: 'fopen' was not declared in this scope
/usr/local/google/home/ukai/chrome/src/chrome/browser/chromeos/pipe_reader.cc:12: error: 'fgets' was not declared in this scope
scons: *** [/usr/local/google/home/ukai/chrome/src/sconsbuild/Debug/obj/chrome/browser/chromeos/pipe_reader.o] Error 1

Review URL: http://codereview.chromium.org/199046
------------------------------------------------------------------------
r25692 | estade@chromium.org | 2009-09-09 02:45:07 +0200 (Wed, 09 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

GTK: Switch the page/app menus over to the new menu bar helper class.

BUG=19675

Review URL: http://codereview.chromium.org/193052
------------------------------------------------------------------------
r25680 | sidchat@google.com | 2009-09-09 01:33:14 +0200 (Wed, 09 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Remove jankiness from bookmark animation for --show-extensions-on-top.

BUG=20927
TEST=none

Review URL: http://codereview.chromium.org/192039
------------------------------------------------------------------------
r25677 | estade@chromium.org | 2009-09-09 01:11:03 +0200 (Wed, 09 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   A /trunk/src/chrome/browser/gtk/menu_bar_helper.cc
   A /trunk/src/chrome/browser/gtk/menu_bar_helper.h
   M /trunk/src/chrome/chrome.gyp

Make the bookmark toolbar folders act like a menu bar.

I didn't convert the page/app menu to use the new helper class in an effort to keep this patch small and reviewable.

BUG=19675
BUG=15889
TEST=fiddled with it for while, and ran it under valgrind

Review URL: http://codereview.chromium.org/200029
------------------------------------------------------------------------
r25671 | agl@chromium.org | 2009-09-09 00:30:58 +0200 (Wed, 09 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: work around broken dlsym's.

It appears that Nvidia's libGL.so is overriding dlopen/dlsym with
versions that don't fully function. So far, all the users reporting
this have been running Gentoo, but it might just be that they have
up-to-date drivers. The report[1] suggests that all drivers >= 180
have this issue.

[1] http://www.nvnews.net/vbulletin/showthread.php?t=132259

BUG=16800
http://codereview.chromium.org/201055

------------------------------------------------------------------------
r25669 | japhet@chromium.org | 2009-09-09 00:16:05 +0200 (Wed, 09 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_mac.mm
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/webkit/api/public/WebClipboard.h
   M /trunk/src/webkit/api/public/WebViewClient.h
   M /trunk/src/webkit/api/src/AssertMatchingEnums.cpp
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webclipboard_impl.h
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.cc
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_clipboard_impl.cc

Roll webkit deps 48155:48185 and remove a couple of passing tests from test_expectations.txt.

Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168.

BUG=4360
BUG=21228
BUG=18792
TEST=none
TBR=eroman

------------------------------------------------------------------------
r25662 | pinkerton@chromium.org | 2009-09-08 23:09:29 +0200 (Tue, 08 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.h
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bubble_view.h
   A /trunk/src/chrome/browser/cocoa/bubble_view.mm
   A /trunk/src/chrome/browser/cocoa/bubble_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/chrome.gyp

Pretty-up the blocked popup view by sharing code from the status bubble. Blocked Popup view is now themed as well.
BUG=20815
TEST=popup blocking and status bubble still work.
Review URL: http://codereview.chromium.org/196043
------------------------------------------------------------------------
r25659 | mpcomplete@chromium.org | 2009-09-08 23:01:52 +0200 (Tue, 08 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Add a disable button to the Extension management UI.

TEST=Try installing and/or loading some extensions, and toggling between enable and disable in the management UI (chrome://extensions).
BUG=12122

Review URL: http://codereview.chromium.org/199018
------------------------------------------------------------------------
r25653 | sky@chromium.org | 2009-09-08 22:24:12 +0200 (Tue, 08 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h

Fixes regression introduced in dnd refactoring. I removed a check for
the URL that I shouldn't have (it won't be needed at some point, but it
is now).

BUG=21198
TEST=Select a URL and drag to the tab strip. Make sure you get the
     drop target and you can drop the text to create a new tab. Do the
     same with www.google.com, you shouldn't get a drop target.

Review URL: http://codereview.chromium.org/202010
------------------------------------------------------------------------
r25650 | jam@chromium.org | 2009-09-08 21:46:18 +0200 (Tue, 08 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   D /trunk/src/chrome/test/activex_test_control
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   D /trunk/src/webkit/activex_shim
   D /trunk/src/webkit/activex_shim_dll
   D /trunk/src/webkit/default_plugin/activex_installer.cc
   D /trunk/src/webkit/default_plugin/activex_installer.h
   M /trunk/src/webkit/default_plugin/default_plugin.gyp
   M /trunk/src/webkit/default_plugin/default_plugin_shared.h
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.h
   M /trunk/src/webkit/default_plugin/plugin_main.cc
   M /trunk/src/webkit/glue/plugins/plugin_constants_win.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_page_delegate.h
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/webkit.gyp

Take out the activex control.BUG=20259
Review URL: http://codereview.chromium.org/200031
------------------------------------------------------------------------
r25647 | erg@google.com | 2009-09-08 21:22:13 +0200 (Tue, 08 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/rounded_window.cc

GTK Theme: Don't render IDR_THEME_TOOLBAR on GtkWidgets.

IDR_THEME_TOOLBAR is a generated blank image of the bg[SELECTED] color,
which will be drawn by default on GtkWidgets. Uploading an image of
said color to the X server on each expose and then asking it to tile the
image across the widget is silly; stop doing it.

Also sets clip rectangles correctly in a few places where we were using GdkGC
instead of skia.

Review URL: http://codereview.chromium.org/196044
------------------------------------------------------------------------
r25644 | jeremy@chromium.org | 2009-09-08 21:07:47 +0200 (Tue, 08 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/FirstRunDialog.xib
   M /trunk/src/chrome/app/nibs/ImportProgressDialog.xib
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm
   M /trunk/src/chrome/chrome.gyp

Localize OS X First Run Dialogs

* Uses the awesome ChromeUILocalizer infrastructure.
* Also solves the issue of hard coded prodcut names.

BUG=19160,19651,19176
TEST=First run dialog + it's progress dialog should now say "Chromium" instead of "Google Chrome".

Review URL: http://codereview.chromium.org/199035
------------------------------------------------------------------------
r25643 | mdm@chromium.org | 2009-09-08 20:59:13 +0200 (Tue, 08 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h

Linux: expose "Use system title bar and borders" preference in options dialog.
BUG=19483
TEST=none

Review URL: http://codereview.chromium.org/193033
------------------------------------------------------------------------
r25636 | snej@chromium.org | 2009-09-08 20:07:27 +0200 (Tue, 08 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h

Fix linux-views build by adding a header change I missed in my previous checkin (r25629).
BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985
TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html

Review URL: http://codereview.chromium.org/192040
------------------------------------------------------------------------
r25635 | sky@chromium.org | 2009-09-08 19:51:04 +0200 (Tue, 08 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/views.gyp
   A /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/tooltip_manager.h
   M /trunk/src/views/widget/tooltip_manager_gtk.cc
   M /trunk/src/views/widget/tooltip_manager_gtk.h
   M /trunk/src/views/widget/tooltip_manager_win.cc
   M /trunk/src/views/widget/tooltip_manager_win.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Fleshes out the tooltip implementation for views on Gtk. It doesn't
support explicit positioning of the tooltip as windows does. That'll
have to be added later.

BUG=none
TEST=make sure tooltips still work correctly on windows

Review URL: http://codereview.chromium.org/197031
------------------------------------------------------------------------
r25629 | snej@chromium.org | 2009-09-08 19:29:25 +0200 (Tue, 08 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.h
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/cocoa/web_drop_target.h
   M /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/webkit/api/public/WebDragOperation.h
   A /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/events/drag-in-frames-expected.txt
   A /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/events/drag-in-frames-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/drag-in-frames-expected.txt
   M /trunk/src/webkit/glue/dragclient_impl.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/test_shell/drag_delegate.cc
   M /trunk/src/webkit/tools/test_shell/drop_delegate.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Plumb the DragOperation through all the layers between the platform Drag-n-drop code and WebCore.
This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec.
(The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.)
R=darin,pink
BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985
TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html
Review URL: http://codereview.chromium.org/174364
------------------------------------------------------------------------
r25626 | japhet@chromium.org | 2009-09-08 19:12:50 +0200 (Tue, 08 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable interactive_ui_tests failing as of WebKit merge 48098:48155 due to upstream breakage.

BUG=21277
TEST=none
R=thomasvl


Review URL: http://codereview.chromium.org/200043
------------------------------------------------------------------------
r25623 | erikkay@chromium.org | 2009-09-08 17:49:52 +0200 (Tue, 08 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js
   M /trunk/src/chrome/test/data/extensions/api_test/override1/test.js

finished testing functions and added events to bookmark tests.
added infrastructure to better support events and cleaned up callback testing.

Review URL: http://codereview.chromium.org/192028
------------------------------------------------------------------------
r25616 | thakis@chromium.org | 2009-09-08 16:54:27 +0200 (Tue, 08 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Final tweaks to download item look on OS X. It now looks pretty much like on windows and linux, but is drawn nearly completely with vectors.

Also fix the SkColor->NSColor conversion in the mac theme provider.

Also let status bubble text color be influenced by current theme.

BUG=18902,18438
TEST=Download items now look like on windows. Color of the main download item text should change with the theme. Also, the status bubble text now adapts to the theme, and themes that specify text colors can now successfully change the color of e.g. the text in tabs. Also check that the status text ("104.0/110 MB, 1 h 45 secs left") is elided at the right when it's too long.

Review URL: http://codereview.chromium.org/192033
------------------------------------------------------------------------
r25615 | maruel@chromium.org | 2009-09-08 16:37:48 +0200 (Tue, 08 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_mac.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/skia/ext/vector_canvas.h
   M /trunk/src/skia/ext/vector_canvas_linux.cc
   M /trunk/src/skia/ext/vector_platform_device_linux.cc
   M /trunk/src/skia/ext/vector_platform_device_linux.h

Pass printing result to the browser.

The resulting PDF file will now be passed to the browser and be saved as "chromium_printing_test.pdf" under current directory.

BUG=9847
TEST=printing on linux should now generate chromium_printing_test.pdf in download directory. Printing on Windows should still work.

Patch contributed by minyu.huang@gmail.com
Review URL: http://codereview.chromium.org/172115
------------------------------------------------------------------------
r25614 | mnaganov@chromium.org | 2009-09-08 12:50:56 +0200 (Tue, 08 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/test/data/devtools/js_page.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: fix flakiness of DevToolsSanityTest/TestProfilerTab.

Made a local run for 25 times, got no single failure.

BUG=http://crbug.com/21108
TEST=none

Review URL: http://codereview.chromium.org/200040
------------------------------------------------------------------------
r25609 | jorlow@chromium.org | 2009-09-08 05:54:49 +0200 (Tue, 08 Sep 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.cc
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_context.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   A /trunk/src/chrome/browser/in_process_webkit/storage_area.cc
   A /trunk/src/chrome/browser/in_process_webkit/storage_area.h
   A /trunk/src/chrome/browser/in_process_webkit/storage_namespace.cc
   A /trunk/src/chrome/browser/in_process_webkit/storage_namespace.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h

Refactor DOM storage to be more object oriented.  All the DOMStorageDispatcher hosts (which are each owned by one ResourceMessageFilter) for the same profile share a WebKit context, and each one of those contexts owns a DOMStorageContext.  The DOMStorageContext owns storage namespace objects which own storage area objects which wrap their WebKit counterparts.

Not only is this cleaner code wise and more efficient (we're not duplicating WebStorageNamespaces and Areas for each DOMStorageDispatcherHost) but this is necessary for events and locking.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/192003
------------------------------------------------------------------------
r25608 | abarth@chromium.org | 2009-09-08 01:09:58 +0200 (Tue, 08 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

Refuse to render RSS as XML by treating the response as text/plain.  This is
somewhat unfortunate, but we need to do this until we have a built-in feed
previewer.

R=mal
BUG=21238

Review URL: http://codereview.chromium.org/201044
------------------------------------------------------------------------
r25602 | craig.schlenter@chromium.org | 2009-09-07 21:01:41 +0200 (Mon, 07 Sep 2009) | 18 lines
Changed paths:
   M /trunk/src/app/os_exchange_data_provider_gtk.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/widget/drop_target_gtk.cc

Fix some gcc 4.4 issues when compiling with toolkit_views.

Most of these squash harmless compiler warnings but the custom_button.cc
change fixes a real problem with the accelerator key bitmask calculation
(+ preceeds << in terms of operator precedence)

The change to tab_strip.cc is ugly but it fixes the following error:

chrome/browser/views/tabs/tab_strip.cc: In member function
‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’:
chrome/browser/views/tabs/tab_strip.cc:201: error: assuming
signed overflow does not occur when assuming that
(X - c) > X is always false

As an added bonus, this makes the Linux shared build of toolkit_views
work too.

Review URL: http://codereview.chromium.org/199025
------------------------------------------------------------------------
r25599 | benl@chromium.org | 2009-09-07 18:39:46 +0200 (Mon, 07 Sep 2009) | 26 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/base.gyp
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/crypto/signature_verifier.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/gfx/native_widget_types.h
   M /trunk/src/base/gfx/rect.h
   M /trunk/src/base/keyboard_codes.h
   M /trunk/src/build/build_config.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/transport_dib.h
   M /trunk/src/media/base/media_posix.cc
   M /trunk/src/media/media.gyp
   M /trunk/src/skia/ext/platform_canvas.h
   M /trunk/src/skia/ext/platform_device.h
   M /trunk/src/skia/skia.gyp
   M /trunk/src/third_party/ffmpeg/ffmpeg.gyp
   M /trunk/src/third_party/libevent/libevent.gyp
   M /trunk/src/third_party/libxml/libxml.gyp
   M /trunk/src/third_party/libxslt/libxslt.gyp
   M /trunk/src/third_party/npapi/bindings/npapi.h
   M /trunk/src/webkit/build/rule_gperf.py
   M /trunk/src/webkit/glue/plugins/nphostapi.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/webkit.gyp

Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set but
not OS_WIN.

Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set.

Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX,
OS_LINUX or OS_FREEBSD.

Added USE_NSS for ... nss (for crypto). Windows and MacOS use
platform-specific libraries.

All of the above cause slightly odd formulations like:

#if defined(OS_WIN)
...
#elif defined(USE_BASE_DATA_PACK)
...
#endif

Possibly should also define USE_DLL_FOR_DATA, etc? Or something?

Wrapped various references to struct stat64 and stat64() to use struct
stat and stat() for FreeBSD - but a "man stat64" on Linux suggests
that we could do the same thing for at least Linux, too, and perhaps
eliminate the wrapper?

------------------------------------------------------------------------
r25594 | ananta@chromium.org | 2009-09-06 17:27:14 +0200 (Sun, 06 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Chrome side of the fix for http://b/issue?id=1694574, which is a bug caused when a new automation client instance is launched and attempts to attach to an existing external tab. An example of where this could happen is javascript on a page attempting a window.open with target _blank. In this case the Chrome browser creates a TabContents instance which is attached to an ExternalTabContainer instance. The automation client then attaches to this ExternalTabContainer. This all works if the automation client is in the same client process. If a new process is launched a separate automation channel is created between the client and the chrome browser which causes this to not work as expected.

Fix is have a floating ExternalTabContainer instance which is eventually connected to by the client. When we receive a notification from the client that it is about to connect to the ExternalTabContainer instance we setup the automation channel and other info in the underlying automation profile.

The new TabContents is created with the same profile instance as the current TabContents. This does not
work correctly if the underlying profile is an automation profile as its lifetime is tied to the
ExternalTabContainer. To fix this I added a setter for the new policy to the NavigationController. Not doing
this causes the browser to crash if the original ExternalTabContainer instance dies.

There is a bigger issue here which is that all this profile sharing would cause session cookies to not work correctly if multiple automation clients are connected to the same Chrome browser instance over the same profile. I will file a separate bug to track this issue.

Bug=1694574
 
Review URL: http://codereview.chromium.org/200003
------------------------------------------------------------------------
r25585 | suzhe@chromium.org | 2009-09-06 04:05:35 +0200 (Sun, 06 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Fix issue 20934: Omnibox keyboard behavior wrong for "See recent pages in history"

This CL fixes issue 20934 by eliminating the side effect caused by Enter key press event.

BUG=20934: Omnibox keyboard behavior wrong for "See recent pages in history"
TEST=Input something in omnibox, make sure it triggers "See N recent pages in history containing XXX", then select this item and press Enter to see if chrome://history/#q=XXX is opened.

Review URL: http://codereview.chromium.org/196020
------------------------------------------------------------------------
r25581 | pkasting@chromium.org | 2009-09-05 20:27:02 +0200 (Sat, 05 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Fix adjacent separators when not running with --enable-sync.

BUG=20408
TEST=Open tools menu, see that there are no instances of two adjacent separators 
Review URL: http://codereview.chromium.org/192032
------------------------------------------------------------------------
r25580 | shess@chromium.org | 2009-09-05 19:30:03 +0200 (Sat, 05 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

[Mac] Fix Omnibox keyword-search color.

Originally was using theme colors, which seem to have changed.

http://crbug.com/20556
TEST=Type www.google.com and hit tab, should see "Search Google:" in a
bubble.  The bubble should be blue with a darker background.

Review URL: http://codereview.chromium.org/175055
------------------------------------------------------------------------
r25577 | abarth@chromium.org | 2009-09-05 16:21:09 +0200 (Sat, 05 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   D /trunk/src/chrome/browser/force_tls_persister.cc
   D /trunk/src/chrome/browser/force_tls_persister.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   A /trunk/src/chrome/browser/strict_transport_security_persister.cc (from /trunk/src/chrome/browser/force_tls_persister.cc:25538)
   A /trunk/src/chrome/browser/strict_transport_security_persister.h (from /trunk/src/chrome/browser/force_tls_persister.h:25538)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h
   D /trunk/src/net/base/force_tls_state.cc
   D /trunk/src/net/base/force_tls_state.h
   D /trunk/src/net/base/force_tls_state_unittest.cc
   A /trunk/src/net/base/strict_transport_security_state.cc (from /trunk/src/net/base/force_tls_state.cc:25538)
   A /trunk/src/net/base/strict_transport_security_state.h (from /trunk/src/net/base/force_tls_state.h:25538)
   A /trunk/src/net/base/strict_transport_security_state_unittest.cc (from /trunk/src/net/base/force_tls_state_unittest.cc:25538)
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h

Rename X-Force-TLS to Strict-Transport-Security.

Also, remove StrictTransportSecurity code from SSLPolicy because that code
doesn't work.

R=agl

Review URL: http://codereview.chromium.org/198035
------------------------------------------------------------------------
r25576 | yurys@google.com | 2009-09-05 11:23:29 +0200 (Sat, 05 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/webkit_resources.grd

DevTools: re-enable some devtools interactive ui tests that started to fail after WebKit roll. Touch webkit_resources.grd so that build bot takes changes to injected scripts.

BUG=21116

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/194033
------------------------------------------------------------------------
r25575 | yurys@google.com | 2009-09-05 11:07:25 +0200 (Sat, 05 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Reverting 25574.
Review URL: http://codereview.chromium.org/201038
------------------------------------------------------------------------
r25574 | yurys@google.com | 2009-09-05 10:49:16 +0200 (Sat, 05 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: re-enable some devtools interactive ui tests that started to fail after WebKit roll.

BUG=21116

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/193034
------------------------------------------------------------------------
r25568 | pkasting@chromium.org | 2009-09-05 03:05:27 +0200 (Sat, 05 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Fix small pixel glitches in omnibox dropdown corners.

BUG=21146
TEST=Omnibox dropdown corners look nicer
Review URL: http://codereview.chromium.org/201037
------------------------------------------------------------------------
r25567 | shess@chromium.org | 2009-09-05 02:56:56 +0200 (Sat, 05 Sep 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   A /trunk/src/chrome/browser/cocoa/cocoa_test_helper.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

[Mac] Add testing code to expose an NSColor memory leak.

AutocompleteTextFieldCell calls -keyboardFocusIndicatorColor when
drawing the focus ring, which valgrind considers a leak.  While we
were testing drawing when not focussed, unit tests could not test
drawing when focussed without the window being made key, which is bad
for many reasons.

This change adds some code to allow faking the key window, then adds
tests for drawing when focussed which exposes the memory leak, then
adds a suppression for that memory leak.

http://crbug.com/21137
TEST=valgrind AutocompleteTextFieldCellTest.Display

Review URL: http://codereview.chromium.org/192031
------------------------------------------------------------------------
r25560 | shess@chromium.org | 2009-09-05 02:29:54 +0200 (Sat, 05 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Drop shadow for Omnibox popup.

Adding the system drop shadow adds a border, so removed the border we
were drawing.  Also pushed all of the one-pixel-here-one-pixel-there
positioning tweaks to -autocompletePopupPosition.

http://crbug.com/20283
TEST=Omnibox popup border should have drop shadow, be two pixels below
Omnibox, and rounded corners should align with rounded corners of star
and go buttons.

Review URL: http://codereview.chromium.org/185013
------------------------------------------------------------------------
r25558 | ananta@chromium.org | 2009-09-05 02:17:14 +0200 (Sat, 05 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/cookie_store.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

This CL changes the CookieStore obect to be a refcounted object to get a better handle on its lifetime as there are cases where this object is handed out to URLRequestContext instances which outlive the URLRequestContext object which created it.

Partial fix for http://code.google.com/p/chromium/issues/detail?id=15289

Bug=15289

Review URL: http://codereview.chromium.org/197023
------------------------------------------------------------------------
r25556 | tony@chromium.org | 2009-09-05 02:05:08 +0200 (Sat, 05 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/test_browser_window.h

Move the "history is too new" dialog out of
chrome/browser/history/history.cc.  Instead use a notification
that Browser picks up and delegates to BrowserWindow.

Include implementations for Windows, Linux GTK+, and Linux Views
(sorry, no mac impl).

Review URL: http://codereview.chromium.org/200023

------------------------------------------------------------------------
r25553 | mdm@chromium.org | 2009-09-05 01:39:58 +0200 (Sat, 05 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_mac.mm
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Allow the default browser check to return "unknown" and reflect that in the UI.

On Linux this can happen for unsupported desktop environments. On Windows and Mac OS X this probably should not occur and likely indicates some sort of serious configuration error. This change avoids repeatedly bothering the user to set the default browser in cases where we're likely to fail at that, without incorrectly displaying that we are the default browser.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/200025
------------------------------------------------------------------------
r25536 | erg@google.com | 2009-09-05 00:37:09 +0200 (Sat, 05 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK: Chrome themes should use COLOR_BOOKMARK_TEXT for most download item text.

Review URL: http://codereview.chromium.org/201030
------------------------------------------------------------------------
r25533 | sidchat@google.com | 2009-09-05 00:29:58 +0200 (Sat, 05 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Make the extension shelf appear on the left of the bookmark bar, instead of on the right.

BUG=http://www.crbug.com/20929
TEST=none
Review URL: http://codereview.chromium.org/198002
------------------------------------------------------------------------
r25529 | tony@chromium.org | 2009-09-05 00:23:40 +0200 (Sat, 05 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm
   M /trunk/src/chrome/browser/encoding_menu_controller.cc
   M /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/encoding_menu_controller_unittest.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_filebase.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Convert std::wstring encoding names to std::string in a bunch of files.

BUG=8647 (http://crbug.com/8647)
TEST=run unit_tests.exe and ui_tests.exe

Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/179057/show

Some linux related fixes by me.

Review URL: http://codereview.chromium.org/192017

------------------------------------------------------------------------
r25521 | mirandac@chromium.org | 2009-09-04 23:58:59 +0200 (Fri, 04 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc

Make sure theme loading bubble is cancelled when extension install is cancelled.

BUG= http://crbug.com/21096
TEST= Install theme. Cancel install at dialog box. Note disappearance of "loading" bubble.

Review URL: http://codereview.chromium.org/201019
------------------------------------------------------------------------
r25520 | arv@google.com | 2009-09-04 23:52:37 +0200 (Fri, 04 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/theme/ntp_themes_gallery_thumb.png
   M /trunk/src/chrome/app/theme/ntp_welcome_thumb.png
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/renderer/render_view.cc

NNTP: Updating the thumbnail size to match the size we use on the new
tab page.

This should reduce the amount of work needed since the images do not
need to be resized.

BUG=17455

TEST=No visible changes

Review URL: http://codereview.chromium.org/194028
------------------------------------------------------------------------
r25512 | cpu@chromium.org | 2009-09-04 23:06:41 +0200 (Fri, 04 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Remove non-full paints from uninitialized backing store

When we create a new backing store, by definition, we don't have the
previous bits, so it does not make sense to draw a small dransport
dib over what ammounts to black pixels.


BUG=13762
TEST=see bug


Review URL: http://codereview.chromium.org/193017
------------------------------------------------------------------------
r25511 | maruel@chromium.org | 2009-09-04 22:55:11 +0200 (Fri, 04 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/tools/build/win/precompiled.cc
   D /trunk/src/chrome/tools/build/win/precompiled.h
   D /trunk/src/chrome/tools/build/win/precompiled.vsprops
   D /trunk/src/chrome/tools/build/win/precompiled_wtl.cc
   D /trunk/src/chrome/tools/build/win/precompiled_wtl.h
   D /trunk/src/chrome/tools/build/win/precompiled_wtl.vsprops
   D /trunk/src/net/build/precompiled_net.cc
   D /trunk/src/net/build/precompiled_net.h
   M /trunk/src/net/net.gyp
   M /trunk/src/sandbox/sandbox.gyp
   D /trunk/src/sandbox/sandbox_poc/pocdll/stdafx.cc
   D /trunk/src/sandbox/sandbox_poc/pocdll/stdafx.h
   D /trunk/src/sandbox/sandbox_poc/stdafx.cc
   D /trunk/src/sandbox/sandbox_poc/stdafx.h
   D /trunk/src/sandbox/src/stdafx.cc
   D /trunk/src/sandbox/src/stdafx.h
   D /trunk/src/sandbox/tests/integration_tests/stdafx.cc
   D /trunk/src/sandbox/tests/integration_tests/stdafx.h
   D /trunk/src/sandbox/tests/unit_tests/stdafx.cc
   D /trunk/src/sandbox/tests/unit_tests/stdafx.h
   D /trunk/src/sandbox/tests/validation_tests/stdafx.cc
   D /trunk/src/sandbox/tests/validation_tests/stdafx.h
   D /trunk/src/sandbox/tools/finder/stdafx.cc
   D /trunk/src/sandbox/tools/finder/stdafx.h
   D /trunk/src/sandbox/tools/launcher/stdafx.cc
   D /trunk/src/sandbox/tools/launcher/stdafx.h
   D /trunk/src/skia/precompiled.cc
   M /trunk/src/skia/skia.gyp
   D /trunk/src/tools/measure_page_load_time/ie_bho/stdafx.cpp
   D /trunk/src/tools/measure_page_load_time/ie_bho/stdafx.h
   D /trunk/src/webkit/build/V8Bindings/precompiled_v8bindings.cpp
   D /trunk/src/webkit/build/V8Bindings/precompiled_v8bindings.h
   D /trunk/src/webkit/build/precompiled_webkit.cc
   D /trunk/src/webkit/build/precompiled_webkit.h
   D /trunk/src/webkit/build/precompiled_webkit_c.c
   M /trunk/src/webkit/webkit.gyp

Delete all precompiled support. It is causing more harm than good, especially when define changes.

TEST=none
BUG=20889

Review URL: http://codereview.chromium.org/171118

------------------------------------------------------------------------
r25507 | viettrungluu@chromium.org | 2009-09-04 22:43:14 +0200 (Fri, 04 Sep 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/menu_button.h
   M /trunk/src/chrome/browser/cocoa/menu_button.mm

(Mac) Display the bookmark bar off-the-side menu on mouse down. Also align the menu.
(Basically, make it like Safari's button.)

We make the button into a |MenuButton|, attach a fixed menu to it in the
nib, and make the |BookmarkBarController| the delegate for this menu so
that we can update the menu just before it's displayed.

As a side effect, also fixes bug 20813.

BUG=21093,20813
TEST=Make sure the bookmark bar off-the-side button works properly under a variety of circumstances, making sure the menu is properly aligned, etc.

Review URL: http://codereview.chromium.org/199024
------------------------------------------------------------------------
r25504 | mnaganov@chromium.org | 2009-09-04 22:33:30 +0200 (Fri, 04 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable interactive_ui_tests::TestProfilerTab for now.

BUG=http://crbug.com/21108
TEST=none

Review URL: http://codereview.chromium.org/193025
------------------------------------------------------------------------
r25502 | jhawkins@chromium.org | 2009-09-04 22:26:09 +0200 (Fri, 04 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/ie_importer.cc

Revert one more piece of ie_importer.cc I left out in the last revert.

TBR=tommi
------------------------------------------------------------------------
r25501 | asargent@chromium.org | 2009-09-04 22:21:40 +0200 (Fri, 04 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

Revert 25478 which was causing Mac valgrind failures.

TBR=shess


------------------------------------------------------------------------
r25500 | jhawkins@chromium.org | 2009-09-04 22:16:32 +0200 (Fri, 04 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/ie_importer.cc

Revert changes to ie_importer.cc from r25498.  The builder doesn't like something; investigating.

TBR=tommi
------------------------------------------------------------------------
r25498 | jhawkins@chromium.org | 2009-09-04 22:04:07 +0200 (Fri, 04 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/win_safe_util.cc

Use ScopedComPtr instead of CComPtr to reduce a dependency on ATL.

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/201012
------------------------------------------------------------------------
r25497 | pkasting@chromium.org | 2009-09-04 22:02:44 +0200 (Fri, 04 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Use system background color for info bubbles.  This causes some problems right now due to bug 21027 and bug 21028.

BUG=92
TEST=Go to a secure site, hover the lock and see that the bubble uses the system window background color.
------------------------------------------------------------------------
r25496 | davemoore@chromium.org | 2009-09-04 22:01:45 +0200 (Fri, 04 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/chromeos/gview_request_interceptor.cc
   A /trunk/src/chrome/browser/chromeos/gview_request_interceptor.h
   A /trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/net.gyp
   A /trunk/src/net/url_request/url_request_redirect_job.cc
   A /trunk/src/net/url_request/url_request_redirect_job.h

Intercept HTTP requests for documents that GView is capable of displaying (such
as pdf) and redirect the user to the appropriate URL for viewing.

Original patch by skrulx@gmail.com
http://codereview.chromium.org/174016

Review URL: http://codereview.chromium.org/199019
------------------------------------------------------------------------
r25495 | victorw@chromium.org | 2009-09-04 21:59:56 +0200 (Fri, 04 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: disable 4 sanity tests during deps roll.

R=asargent
TEST=none
BUG=21116

Review URL: http://codereview.chromium.org/199030
------------------------------------------------------------------------
r25494 | pkasting@chromium.org | 2009-09-04 21:58:29 +0200 (Fri, 04 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Use system themes where possible in Omnibox edit and dropdown; in other cases, provide a pair of colors and use whichever contrasts more with the relevant background color, to maintain readability.

BUG=92,18367
TEST=Use the omnibox on various non-default and high-contrast system themes.  Observe that everything is always readable.
Review URL: http://codereview.chromium.org/200009
------------------------------------------------------------------------
r25487 | stuartmorgan@google.com | 2009-09-04 21:12:37 +0200 (Fri, 04 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Strip .plugin off of Mac plugin names when showing the crash info bar.

BUG=21029
TEST=Kill a plugin process; the plugin crash info bar shouldn't have ".plugin" in the plugin name.

Review URL: http://codereview.chromium.org/197018
------------------------------------------------------------------------
r25486 | abarth@chromium.org | 2009-09-04 21:07:14 +0200 (Fri, 04 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable the XSSAuditor by default.

R=dglazkov

------------------------------------------------------------------------
r25485 | estade@chromium.org | 2009-09-04 21:07:13 +0200 (Fri, 04 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

GTK: Implement folder chooser dialog.

Also, found another gtk bug: http://bugzilla.gnome.org/show_bug.cgi?id=594089 We can't write a suppression for this bug because the warning message is too generic, but it shouldn't be much of a problem in release builds.

BUG=20940

Review URL: http://codereview.chromium.org/196014
------------------------------------------------------------------------
r25478 | shess@chromium.org | 2009-09-04 20:25:09 +0200 (Fri, 04 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

[Mac] Fix Omnibox keyword-search color.

Originally was using theme colors, which seem to have changed.

http://crbug.com/20556
TEST=Type www.google.com and hit tab, should see "Search Google:" in a
bubble.  The bubble should be blue with a darker background.

Review URL: http://codereview.chromium.org/175055
------------------------------------------------------------------------
r25475 | shess@chromium.org | 2009-09-04 20:01:59 +0200 (Fri, 04 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Make Omnibox a little bit transparent.

Randomly chose 90% opaque.  For some reason -controlColor didn't work
right anymore for hovered background, switch to -controlHighlightColor
(which sounds closer to the point anyhow).

http://crbug.com/20679
TEST=Omnibox popup should be slightly transparent, but not annoyingly so.

Review URL: http://codereview.chromium.org/188014
------------------------------------------------------------------------
r25460 | arv@google.com | 2009-09-04 19:02:23 +0200 (Fri, 04 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Make the option button pressed when the option menu is open.

BUG=21062

TEST=Click the option menu button (the top right button). The button
should look pressed as long as the menu is visible.

Review URL: http://codereview.chromium.org/201020
------------------------------------------------------------------------
r25459 | agl@chromium.org | 2009-09-04 18:57:51 +0200 (Fri, 04 Sep 2009) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/force_tls_persister.cc
   A /trunk/src/chrome/browser/force_tls_persister.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/net/base/force_tls_state.cc
   M /trunk/src/net/base/force_tls_state.h

ForceTLS: persist to disk

With this patch, we'll persist ForceTLS state to disk. It's saved as a
JSON file (ForceTLSState) in the profile directory for the moment.
You still need the --force-https flag in order to trigger any ForceTLS
behaviour.

For the moment, this state isn't cleared when the rest of the browser
state it. That's ok because it's still behind a flag.

http://codereview.chromium.org/186014

------------------------------------------------------------------------
r25458 | jrg@chromium.org | 2009-09-04 18:44:41 +0200 (Fri, 04 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Fix crash on bookmark button delete.
Fix a bunch of "unrecognized selector sent to instance" NSLogs.

BUG=http://crbug.com/20937, http://crbug.com/20813
TEST=Right-click on a bookmark button and delete it.
Repeat a few times.  Make sure we don't crash.
Launch from the command line (.../Chromium.app/Contents/MacOS/Chromium)
Move the mouse around the toolbar hovering over the buttons and the chevron.
Make sure no "does not respond to selector" messages printed.

Review URL: http://codereview.chromium.org/199014
------------------------------------------------------------------------
r25455 | phajdan.jr@chromium.org | 2009-09-04 17:53:03 +0200 (Fri, 04 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Disable flaky TabDraggingTest.Tab1Tab3Escape.

TEST=none
http://crbug.com/21092

Review URL: http://codereview.chromium.org/196027
------------------------------------------------------------------------
r25452 | thomasvl@chromium.org | 2009-09-04 17:07:52 +0200 (Fri, 04 Sep 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/app/nibs/HungRendererDialog.xib
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/chrome.gyp

Hung Renderer dialog:
  Resize to fit the graphic.
  Fetch the hung from ResourceBundle since it looks like it should be under theme control.
  Swap the kill and wait buttons.
  Add in localization objects.
  Resize message and window to find localized content.
Bookmark Bubble:
  Right align labels to fields.
  Make window resize to fit labels.
  Switch to small controls per Cole.
Stop bringing the frozen tab graphic into the bundle so we avoid the extra copy.

BUG=20525
BUG=20533
TEST=Hung renderer localized and fits content.  Bookmark bubble fits labels in all languages.
Review URL: http://codereview.chromium.org/193020
------------------------------------------------------------------------
r25449 | sky@chromium.org | 2009-09-04 16:21:16 +0200 (Fri, 04 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/chromeos_version_loader.cc
   M /trunk/src/chrome/browser/chromeos/chromeos_version_loader_unittest.cc

Changes version string looked for in about:version to match that of
version string written by OS.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/194017
------------------------------------------------------------------------
r25448 | yurys@google.com | 2009-09-04 16:03:09 +0200 (Fri, 04 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: reenable set breakpoint test
Review URL: http://codereview.chromium.org/198023
------------------------------------------------------------------------
r25442 | hbono@chromium.org | 2009-09-04 13:18:29 +0200 (Fri, 04 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Reverting 23702.
Review URL: http://codereview.chromium.org/173343
------------------------------------------------------------------------
r25440 | yurys@google.com | 2009-09-04 11:36:26 +0200 (Fri, 04 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: enable scripts panel sanity test.

BUG=19858
Review URL: http://codereview.chromium.org/201014
------------------------------------------------------------------------
r25433 | jam@chromium.org | 2009-09-04 07:53:23 +0200 (Fri, 04 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/default_plugin/plugins2.xml
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

This changelist fixes some issues with the NPAPI WMP plugin work in Chrome.  The first is that we need to disable windowless mode since it doesn't work in the NPAPI plugin (Safari does this as well, and sites don't use windowless for Firefox).  The second is to make UpdateGeometry message synchronous for WMP.  The problem I saw was that while handling that message, the plugin might disaptch a NPObject Invoke method to play a video, which WMP doesn't expect and it leads to the video never playing.

While touching these files, I made some small cleanup by reverting the change that made WebPluginProxy not have a WebPluginDelegateImpl pointer, which added a bunch of unnecessary methods to WebPluginDelegate.

BUG=20259
TEST=use --no-activex and try playing the videos on http://www.nana10.co.il/Section/?SectionID=10847&sid=235
Review URL: http://codereview.chromium.org/196012
------------------------------------------------------------------------
r25430 | rafaelw@chromium.org | 2009-09-04 06:35:53 +0200 (Fri, 04 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Re-disable ExtensionApiTest.Tabs (flakey)

TBR=asargent,phajdan.jr

Review URL: http://codereview.chromium.org/200016
------------------------------------------------------------------------
r25422 | arv@google.com | 2009-09-04 04:08:56 +0200 (Fri, 04 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Fix issue with pinning the pre-populated thumbnails.

BUG=20801

TEST=Create a new profile and open the new tab page. Pin and reorder the
pre-populated thumbnails. The thumbnails and favicons should continue to
work.

Review URL: http://codereview.chromium.org/195010
------------------------------------------------------------------------
r25414 | viettrungluu@chromium.org | 2009-09-04 03:44:57 +0200 (Fri, 04 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   D /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   D /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/chrome.gyp

Delete some empty files.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174190
------------------------------------------------------------------------
r25413 | mdm@chromium.org | 2009-09-04 03:41:11 +0200 (Fri, 04 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h

Linux: make external protocol dialog non-modal.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/198017
------------------------------------------------------------------------
r25412 | mdm@chromium.org | 2009-09-04 03:40:49 +0200 (Fri, 04 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc

Fix OS_WINDOWS -> OS_WIN.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/194019
------------------------------------------------------------------------
r25402 | aa@chromium.org | 2009-09-04 01:13:09 +0200 (Fri, 04 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html

Try again to fix bug 20968, this time not breaking browser
tests.

This is kinda a janky hack to get the browser test to keep
working but I couldn't think of anything better.

Review URL: http://codereview.chromium.org/196015
------------------------------------------------------------------------
r25401 | mirandac@chromium.org | 2009-09-04 01:13:07 +0200 (Fri, 04 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc

Fix loading bubble not disappearing with corrupt theme image.

BUG= http://crbug.com/21044
TEST= try installing a theme with a corrupt image.  note that loading bubble disappears.

Review URL: http://codereview.chromium.org/196016
------------------------------------------------------------------------
r25394 | rafaelw@chromium.org | 2009-09-04 00:55:24 +0200 (Fri, 04 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Add some DCHECKS and asserts to debug why ExtensionApiTest.Tabs is flakey and Reenable.

BUG=20828

Review URL: http://codereview.chromium.org/193013
------------------------------------------------------------------------
r25390 | phajdan.jr@chromium.org | 2009-09-04 00:35:12 +0200 (Fri, 04 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Sleep and poll (yuck!) in DownloadTest while verifying Internet ZoneIdentifier.

There seems to be no other reliable way to do that due to Windows file semantics.

This should decrease the flakiness.

TEST=Covered by ui_tests.
http://crbug.com/20809

Review URL: http://codereview.chromium.org/192010
------------------------------------------------------------------------
r25389 | jcampan@chromium.org | 2009-09-04 00:30:27 +0200 (Fri, 04 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Fixing focus in location bar and accelerators on Linux toolkit views.

BUG=None
TEST=Focus the location bar, deactive/reactivate the browser window with
Alt-Tab, the focus should still be on the location bar.
Click few links on a page to have a history navigation. Focus the location
bar, use backspace to delete some text. Focus a text area in a web page,
make sure backspace works as expected (deletes text). Now click on a non
text area, press backspace. You should trigger a navigate back.

Review URL: http://codereview.chromium.org/185014

------------------------------------------------------------------------
r25386 | agl@chromium.org | 2009-09-04 00:16:47 +0200 (Fri, 04 Sep 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/force_tls_persister.cc
   D /trunk/src/chrome/browser/force_tls_persister.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/net/base/force_tls_state.cc
   M /trunk/src/net/base/force_tls_state.h

Reverting r25382: blame Windows

------------------------------------------------------------------------
r25383 | mirandac@chromium.org | 2009-09-04 00:04:40 +0200 (Fri, 04 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/views/theme_install_bubble_view.cc
   A /trunk/src/chrome/browser/views/theme_install_bubble_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Add "loading..." message to theme install to counter jank.

BUG= http://crbug.com/17696
TEST= Install a theme.  Note that a "loading" message appears to notify you that a theme is loading.

Review URL: http://codereview.chromium.org/191011
------------------------------------------------------------------------
r25382 | agl@chromium.org | 2009-09-04 00:01:37 +0200 (Fri, 04 Sep 2009) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/force_tls_persister.cc
   A /trunk/src/chrome/browser/force_tls_persister.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/net/base/force_tls_state.cc
   M /trunk/src/net/base/force_tls_state.h

ForceTLS: persist to disk

With this patch, we'll persist ForceTLS state to disk. It's saved as a
JSON file (ForceTLSState) in the user data directory for the moment.
You still need the --force-https flag in order to trigger any ForceTLS
behaviour, however.

For the moment, this state isn't cleared when the rest of the browser
state it. That's ok because it's still behind a flag.

http://codereview.chromium.org/186014

------------------------------------------------------------------------
r25380 | amanda@chromium.org | 2009-09-03 23:51:10 +0200 (Thu, 03 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc

Adjust color spaces so that Mac Chrome renders colors properly.
BUG=19951,20552
TEST=compare pages rendered in Chromium and Safari.  They should appear the same.
mark: review
jrg/brettw: FYI

Review URL: http://codereview.chromium.org/194013
------------------------------------------------------------------------
r25379 | estade@chromium.org | 2009-09-03 23:46:20 +0200 (Thu, 03 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc

Fix views linux build.

TBR=maruel

Review URL: http://codereview.chromium.org/198012
------------------------------------------------------------------------
r25377 | estade@chromium.org | 2009-09-03 23:37:15 +0200 (Thu, 03 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

GTK file picker: Use mime type filters instead of shell-style glob filters.

BUG=12347

Review URL: http://codereview.chromium.org/192011
------------------------------------------------------------------------
r25373 | estade@chromium.org | 2009-09-03 23:33:21 +0200 (Thu, 03 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   A /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/external_protocol_dialog_gtk.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/chrome.gyp

Add external protocol dialog for Linux.

This exposes a bug where \n in a string resource is rendered literally when it is displayed. I don't know at what point on Windows the '\' + 'n' is translated to a line return, I have filed crbug.com/20943

BUG=20731

Review URL: http://codereview.chromium.org/194002
------------------------------------------------------------------------
r25369 | finnur@chromium.org | 2009-09-03 23:09:26 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Add missing headers for Release.

TBR=jcampan
BUG=None
TEST=Release build should work now.
Review URL: http://codereview.chromium.org/196008
------------------------------------------------------------------------
r25367 | finnur@chromium.org | 2009-09-03 22:58:01 +0200 (Thu, 03 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/new_browser_window_widget.cc
   M /trunk/src/chrome/browser/views/new_browser_window_widget.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/browser/views/panel_controller.cc
   M /trunk/src/chrome/browser/views/panel_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_2.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/uninstall_view.cc
   M /trunk/src/chrome/browser/views/uninstall_view.h
   M /trunk/src/views/controls/button/button.cc
   M /trunk/src/views/controls/button/button.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.h
   M /trunk/src/views/event.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h

Fix 9867: Activating the previous/next buttons with the keyboard in the find bar should not change the focus.

Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message.

BUG=9687
TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button.

Review URL: http://codereview.chromium.org/188016
------------------------------------------------------------------------
r25362 | viettrungluu@chromium.org | 2009-09-03 22:42:24 +0200 (Thu, 03 Sep 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/clickhold_button_cell.h
   M /trunk/src/chrome/browser/cocoa/clickhold_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/menu_button.h
   A /trunk/src/chrome/browser/cocoa/menu_button.mm
   A /trunk/src/chrome/browser/cocoa/menu_button_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

(Mac) Make the Page/Wrench buttons place their menu in the right place.

Also makes the buttons drag-able -- you can drag or click and wait to
open their menu. Lucky for me, I wrote reusable code.

To do (not now): The "off-the-end" button on the bookmark bar needs the
same fix.

Bug (not to be fixed now): The menu doesn't do the right thing when the
window is moved off the left edge to the screen -- it doesn't open to
the right in the correct fashion. Nor does it do the proper thing when
you move the window off the bottom edge of the screen -- it doesn't open
upwards entirely correctly. <shrug>

BUG=18572
TEST=Click on the Page and Wrench menu buttons and observe. Also test \
     dragging to open.

Review URL: http://codereview.chromium.org/174556
------------------------------------------------------------------------
r25359 | mirandac@chromium.org | 2009-09-03 22:37:57 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Fix theme cache corruption.

BUG= http://crbug.com/20957
TEST= Install many themes quickly, with many windows open.  Close browser and reopen.  Theme should not be corrupted.

Review URL: http://codereview.chromium.org/197010
------------------------------------------------------------------------
r25357 | jrg@chromium.org | 2009-09-03 22:12:59 +0200 (Thu, 03 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm

Add "other bookmarks" to bookmark menu.

BUG=http://crbug.com/18734
TEST=Launch Chrome.  Add some bookmarks then open the bookmark menu.  
You should see all "bookmark bar" bookmarks, followed by a separator
  line, followed by an "Other bookmarks" submenu at the end.
Go to a bookmark then click on STAR.  Change folder to "other bookmarks".
Now open bookmark menu; see item moved from "main page" to the 
  "other bookmarks" folder at the end.
Undo that change by clicking on STAR, changing parent.
Make sure back to normal.


Review URL: http://codereview.chromium.org/195001
------------------------------------------------------------------------
r25356 | jrg@chromium.org | 2009-09-03 22:07:50 +0200 (Thu, 03 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Properly show/hide "off the side" button/menu (chevron) on bookmark bar as needed.

BUG=http://crbug.com/17852

TEST=delete all bookmarks.  No chevron.
Add one bookmark to bookmark bar.  No chevron.
Make window real wide.
Add some more bookmarks (but not enough that it spills over).  No chevron.
Make window thinner.  Chevron appears!
Widen window until chevron hides.
Add more bookmarks until it appears again.


Review URL: http://codereview.chromium.org/201005
------------------------------------------------------------------------
r25351 | shess@chromium.org | 2009-09-03 21:45:35 +0200 (Thu, 03 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

[Mac] Disable Omnibox editing in popup windows.

http://crbug.com/20243
TEST=Go to www.popuptest.com.  Select test #2, allow one of the popups
through.  Try to edit in the omnibox.  Should be able to select and
copy, but not enter text.

Review URL: http://codereview.chromium.org/183043
------------------------------------------------------------------------
r25346 | shess@chromium.org | 2009-09-03 21:16:43 +0200 (Thu, 03 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm

[Mac] Make I-beam cursor match editing area.

Due to our tweaking of the text area, the I-beam cursor was sometimes
janky.

http://crbug.com/20238
TEST=I don't even know how to really test this.

Review URL: http://codereview.chromium.org/181011
------------------------------------------------------------------------
r25341 | asargent@chromium.org | 2009-09-03 20:42:26 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Remove obsolete comment about a test being disabled.

BUG=16106
TEST=none

Review URL: http://codereview.chromium.org/176016
------------------------------------------------------------------------
r25336 | pkasting@chromium.org | 2009-09-03 20:34:24 +0200 (Thu, 03 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Make the omnibox 2 hover code a tiny bit less goofy by removing a now-unused function (although it may have to come back eventually) and using the Model's conception of hover state instead of direct hot-tracking in the view.

Unfortunately, there are still problems, including bogus mousemove events for the same point and no WM_MOUSELEAVE events, all of which the old code handled.  I think fixing this is going to require implementing a TODO in the code to hoist mouse handling to the main dropdown view, at which point I can probably address issue 13703 as well.

BUG=13279
TEST=none
Review URL: http://codereview.chromium.org/187002
------------------------------------------------------------------------
r25329 | mpcomplete@chromium.org | 2009-09-03 19:57:44 +0200 (Thu, 03 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/newtab.html
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/test.html

Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new""

Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed.

BUG=17636

Review URL: http://codereview.chromium.org/172120
------------------------------------------------------------------------
r25325 | evan@chromium.org | 2009-09-03 19:38:39 +0200 (Thu, 03 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/chrome/browser/chromeos/status_area_view.cc

Revert "Workaround Skia and Pango measuring font heights differently by asking Pango"

This reverts commit r25131.  It seems to have regressed Linux startup;
will track perf builder after committing this to be sure.
------------------------------------------------------------------------
r25322 | erg@google.com | 2009-09-03 19:24:54 +0200 (Thu, 03 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

GTK: Don't have a blank line in bookmark folder tooltips.

Review URL: http://codereview.chromium.org/198006
------------------------------------------------------------------------
r25318 | arv@google.com | 2009-09-03 18:55:32 +0200 (Thu, 03 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

NNTP: Fix link and link underline colors

The fall back color for the link underline is the link color with the alpha channel set to 1/3 of the link color.

BUG=20697

TEST=All links on the NTP should have different underline color. Also,
try with different themes.

Review URL: http://codereview.chromium.org/194004
------------------------------------------------------------------------
r25317 | erg@google.com | 2009-09-03 18:52:23 +0200 (Thu, 03 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   A /trunk/src/chrome/browser/gtk/gtk_theme_provider_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

GTK Themes: Add basic unit tests for gtk themes.

Review URL: http://codereview.chromium.org/186019
------------------------------------------------------------------------
r25316 | mark@chromium.org | 2009-09-03 18:38:04 +0200 (Thu, 03 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

The iterator used to walk through the set of throbbers might become invalid
if a throbber decides it's done animating during the walk.  This might happen
for toast throbbers, like the sad tab icon.

TEST=none, really
BUG=20907
Review URL: http://codereview.chromium.org/185016
------------------------------------------------------------------------
r25314 | phajdan.jr@chromium.org | 2009-09-03 18:08:36 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc

Disable flaky ExtensionApi tests. #1 source of flakiness.

TEST=none
http://crbug.com/19866, http://crbug.com/20828

Review URL: http://codereview.chromium.org/195003
------------------------------------------------------------------------
r25312 | mirandac@chromium.org | 2009-09-03 16:47:31 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Make theme setup a little faster by not blurring images for tab backgrounds.

BUG= http://crbug.com/20956
TEST= Install themes, note that tab backgrounds look good.

Review URL: http://codereview.chromium.org/198003
------------------------------------------------------------------------
r25305 | pfeldman@chromium.org | 2009-09-03 11:02:05 +0200 (Thu, 03 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: re-enable sanity tests disabled during the deps roll.
BUG=20835
TBR=yurys
Review URL: http://codereview.chromium.org/194010
------------------------------------------------------------------------
r25296 | mark@chromium.org | 2009-09-03 05:38:58 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Restore r25049 (back out r25295) to isolate it as the cause of bug 20872.

TBR=pinkerton
BUG=20872
TEST=watch perf
Review URL: http://codereview.chromium.org/194008
------------------------------------------------------------------------
r25295 | mark@chromium.org | 2009-09-03 05:31:06 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Temporarily back out r25049 to isolate it as the cause of bug 20872.

TBR=pinkerton
BUG=20872
TEST=watch perf
Review URL: http://codereview.chromium.org/196002
------------------------------------------------------------------------
r25293 | asargent@chromium.org | 2009-09-03 04:23:39 +0200 (Thu, 03 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Add an auto-update now button to chrome://extensions page

BUG=http://crbug.com/17853
TEST=Install an old version of an extension with an available update, then go 
to chrome://extensions and hit the auto-update now button. The extension 
should update.


Review URL: http://codereview.chromium.org/184005
------------------------------------------------------------------------
r25289 | jcampan@chromium.org | 2009-09-03 02:44:39 +0200 (Thu, 03 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc

A crasher can happen in the AlternateNavURLFetcher if the fetch finishes after the tab has been closed.
At that point the navigation controller the AlternateNavURLFetcher has been deleted and should not be accessed.
This CL also addresses a memory leak that would happen when the fetch would fail.

BUG=http://crbug.com/17044
TEST=Navigate to an internal URL (ex: http//mylocalserver) by only typing its name (mylocalserver), an infobar asking whether you want to go to http//mylocalserver should be shown.
Review URL: http://codereview.chromium.org/187016
------------------------------------------------------------------------
r25282 | brettw@chromium.org | 2009-09-03 02:11:31 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc

Add warnings around the new tab page command line switch and its use so people
don't get confused and copy this pattern (as happened recently).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/186018
------------------------------------------------------------------------
r25279 | brettw@chromium.org | 2009-09-03 02:07:37 +0200 (Thu, 03 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   A /trunk/src/chrome/browser/chromeos/status_area_view.cc (from /trunk/src/chrome/browser/views/frame/status_area_view.cc:25179)
   A /trunk/src/chrome/browser/chromeos/status_area_view.h (from /trunk/src/chrome/browser/views/frame/status_area_view.h:25178)
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   D /trunk/src/chrome/browser/views/frame/status_area_view.cc
   D /trunk/src/chrome/browser/views/frame/status_area_view.h
   M /trunk/src/chrome/chrome.gyp

Move status area view to the chromeos directory.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/192001
------------------------------------------------------------------------
r25278 | estade@chromium.org | 2009-09-03 02:06:09 +0200 (Thu, 03 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Set the focus ring color to match the Gtk theme focus color.

BUG=8540

Review URL: http://codereview.chromium.org/173642
------------------------------------------------------------------------
r25277 | asargent@chromium.org | 2009-09-03 02:03:20 +0200 (Thu, 03 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix to ensure IO thread is created when ExtensionUpdater needs it.

In some cases on MacOS it turned out that the IO Thread hadn't been
created at the time we were asking for it.

BUG=http://crbug.com/20794
TEST=none

Review URL: http://codereview.chromium.org/184024
------------------------------------------------------------------------
r25276 | huanr@chromium.org | 2009-09-03 01:52:55 +0200 (Thu, 03 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/visit_database.cc
   A /trunk/src/chrome/browser/history/visit_log.cc
   A /trunk/src/chrome/browser/history/visit_log.h
   A /trunk/src/chrome/browser/history/visit_log_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Adding in memory log of history visit database. This
log will be saved in crash dump (to be done in next
CL) to help debug the corruption in history thread.

TEST=Added unit test.
BUG=16591

Review URL: http://codereview.chromium.org/187004
------------------------------------------------------------------------
r25273 | mpcomplete@chromium.org | 2009-09-03 01:33:00 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc

Attempt at a fix for ExtensionBrowserTest.MessagingContentScript.

BUG=20795
TEST=no

Review URL: http://codereview.chromium.org/191010
------------------------------------------------------------------------
r25267 | pkasting@chromium.org | 2009-09-03 01:23:55 +0200 (Thu, 03 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/toolbar_model.cc

Make the EV cert message disappear while typing in the omnibox.

BUG=20917
TEST=Visit paypal.com, then type in the omnibox.  While typing, the EV cert message on the right side of the omnibox should disappear.
Review URL: http://codereview.chromium.org/172118
------------------------------------------------------------------------
r25265 | paul@chromium.org | 2009-09-03 01:19:54 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Exclude specific browser_tests that don't yet work on Mac.

BUG=16322 (http://crbug.com/16322)
TEST=Covered by browser_tests.

Review URL: http://codereview.chromium.org/189007
------------------------------------------------------------------------
r25261 | thakis@chromium.org | 2009-09-03 01:01:26 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc

Fix a DCHECK that I hit while working on the extension shelf for OS X.

BUG=Part of 19073
TEST=unittest in CL

Review URL: http://codereview.chromium.org/185015
------------------------------------------------------------------------
r25256 | mpcomplete@chromium.org | 2009-09-03 00:40:20 +0200 (Thu, 03 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   D /trunk/src/chrome/test/data/extensions/uitest/window_open/manifest.json
   D /trunk/src/chrome/test/data/extensions/uitest/window_open/newtab.html
   D /trunk/src/chrome/test/data/extensions/uitest/window_open/test.html

Revert r25250: "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new"

Review URL: http://codereview.chromium.org/171127
------------------------------------------------------------------------
r25253 | pamg@google.com | 2009-09-03 00:23:32 +0200 (Thu, 03 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Fix crash on Mac by passing an owning window to SelectFile() when loading
an unpacked extension from chrome://extensions.

BUG=20860
TEST=go to chrome://extensions on Mac, click "Load unpacked extensions...", don't crash
Review URL: http://codereview.chromium.org/171121
------------------------------------------------------------------------
r25250 | mpcomplete@chromium.org | 2009-09-03 00:11:01 +0200 (Thu, 03 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/newtab.html
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/test.html

Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new
window (assuming it is on the same site instance).

BUG=17636
TEST=no

Review URL: http://codereview.chromium.org/173649
------------------------------------------------------------------------
r25245 | mdm@chromium.org | 2009-09-02 23:54:24 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Linux: make the columns in the task manager avoid causing scroll bars.
BUG=17930
TEST=open the task manager and load some pages; the network column shouldn't force a horizontal scrollbar

Review URL: http://codereview.chromium.org/186001
------------------------------------------------------------------------
r25238 | mark@chromium.org | 2009-09-02 22:54:19 +0200 (Wed, 02 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Share one timer for all of the throbbers in the application.

BUG=20907 19268
TEST=Make lots of throbbers spin simultaneously.  There should be no reduction
     in animation speed or smoothness.
Review URL: http://codereview.chromium.org/191009
------------------------------------------------------------------------
r25237 | mattm@chromium.org | 2009-09-02 22:51:45 +0200 (Wed, 02 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h

Gtk first run: Remove obsolete warning for unimplemented privacy features.

Add learn more link after crash reporting checkbox.

BUG=none
TEST=build google release build, launch with empty user-data-dir, click learn more link - should open in default browser.

Review URL: http://codereview.chromium.org/178025
------------------------------------------------------------------------
r25236 | sidchat@google.com | 2009-09-02 22:49:45 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Infrastructure to allow putting Extension Shelf on top along with Bookmarks.

BUG=http://code.google.com/p/chromium/issues/detail?id=20517
TEST=none
Review URL: http://codereview.chromium.org/173613
------------------------------------------------------------------------
r25234 | brettw@chromium.org | 2009-09-02 22:38:22 +0200 (Wed, 02 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_unittest.cc
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Remove the ability to load lazy URLs from the NavigationController. This is no
longer used (except for a test that doens't seem to need it). We used to use
this feature for session restore, but it has since changed.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/191008
------------------------------------------------------------------------
r25232 | mark@chromium.org | 2009-09-02 22:32:45 +0200 (Wed, 02 Sep 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Improve New Tab Page load performance.

This change nets another 65ms (20%) improvement in the duration between the
renderer requesting the NTP and it having all of the resources for the NTP
available and being completely done with layout on my Mac laptop in release
mode.

Move the handling of important resource requests needed for NTP layout from the
UI thread onto the IO thread.  This is handled by caching the necessary data on
the UI thread when possible, so that no profile or theme access is needed to
service the request.  There is often a lot of contention for the UI thread when
a new tab is created, and allowing these requests to be handled more directly
by the IO thread allows the renderer to lay the page out while the browser is
still busy doing UI work.

http://groups.google.com/group/chromium-dev/browse_thread/thread/7148074f807dc5f7

TEST=Do the new tab page and new incognito tab page still work?
     Are they faster?
BUG=13337
Review URL: http://codereview.chromium.org/179069
------------------------------------------------------------------------
r25231 | pinkerton@chromium.org | 2009-09-02 22:28:52 +0200 (Wed, 02 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Fix placement of new tab button when low on space. Was previously comparing against the wrong minimum values, and the check isn't even necessary.
BUG=18721
TEST=create and close lots of tabs, make sure NTB is placed correctly
Review URL: http://codereview.chromium.org/184016
------------------------------------------------------------------------
r25229 | arv@google.com | 2009-09-02 22:22:16 +0200 (Wed, 02 Sep 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Fix issue with the ordering of the most visited items.

This change allows the pinned items to work better after the history
has been cleared. Previously we were limited byt the amount of items
returned by the history. Now pinned items still show up even after the
history has been cleared.

Also, this change makes the filler items flow to the left of pinned
items as necessary.

BUG=20817

TEST=Launch chrome with a new profile. Navigate around so that you have
at least 5 non prepoluated thumbnails on the NTP. Pin the second and
the fifth item. Now clear your history. The pinned items should stay in
place and the fillers should flow around them.

Review URL: http://codereview.chromium.org/184001
------------------------------------------------------------------------
r25224 | sky@chromium.org | 2009-09-02 22:11:14 +0200 (Wed, 02 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Removes some code I accidentally checked in with my last patch.

TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/186016
------------------------------------------------------------------------
r25218 | sky@chromium.org | 2009-09-02 21:38:39 +0200 (Wed, 02 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Makes openning a URL from the Omnibox on a pinned tab create a new
tab.

BUG=none
TEST=On linux make sure the omnibox behaves as expected. Then pin a
  tab and type a url. This should create a new tab rather than
  navigating the current tab.

Review URL: http://codereview.chromium.org/182051
------------------------------------------------------------------------
r25214 | mdm@chromium.org | 2009-09-02 20:59:04 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc
   M /trunk/src/chrome/browser/views/url_picker.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Set the initial sizes of several dialogs based on font information.
BUG=19622
TEST=none

Review URL: http://codereview.chromium.org/180031
------------------------------------------------------------------------
r25201 | estade@chromium.org | 2009-09-02 20:10:18 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

GTK: Make the bookmark menu controller use the GTK-native folder/default favicon images.

BUG=13320

Review URL: http://codereview.chromium.org/188001
------------------------------------------------------------------------
r25200 | estade@chromium.org | 2009-09-02 20:10:09 +0200 (Wed, 02 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

GTK: Implement the bookmark bar chevron.

I didn't use the native GtkToolbar version of this because, as usual, GTK doesn't give us enough flexibility to do what we want. But it wasn't too hard or super hacky to re-implement it.

The chromium version (and hence the Windows version) looks bad. This is not my fault. I don't know why it points right rather than down, when the menu pops down, not to the right. This is why I used a down arrow for the GTK version rather than matching with a right arrow.

BUG=15845

Review URL: http://codereview.chromium.org/187001
------------------------------------------------------------------------
r25197 | pinkerton@chromium.org | 2009-09-02 20:07:15 +0200 (Wed, 02 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Don't allow the home/page/options buttons to be toggled when we're only showing the url bar, with accompanying unit test.
BUG=17825
TEST=make sure you can still show these optional elements in normal windows.
Review URL: http://codereview.chromium.org/188010
------------------------------------------------------------------------
r25190 | dglazkov@chromium.org | 2009-09-02 19:53:05 +0200 (Wed, 02 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disable flakey DownloadTest::ContentDisposition

TBR=paul
TEST=none
BUG=20888


Review URL: http://codereview.chromium.org/188011
------------------------------------------------------------------------
r25184 | darin@chromium.org | 2009-09-02 19:10:59 +0200 (Wed, 02 Sep 2009) | 31 lines
Changed paths:
   M /trunk/src/base/weak_ptr.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/api/public/WebFrameClient.h
   M /trunk/src/webkit/api/public/WebPlugin.h
   M /trunk/src/webkit/api/public/WebPluginContainer.h
   A /trunk/src/webkit/api/public/WebPluginParams.h
   M /trunk/src/webkit/api/src/WebPluginContainerImpl.cpp
   M /trunk/src/webkit/api/src/WebPluginContainerImpl.h
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.h
   M /trunk/src/webkit/glue/plugins/plugin_stream.h
   M /trunk/src/webkit/glue/plugins/plugin_stream_url.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webplugin.h
   D /trunk/src/webkit/glue/webplugin_delegate.cc
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webplugin_impl_unittest.cc
   A /trunk/src/webkit/glue/webplugin_page_delegate.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/webkit.gyp

Eliminate remaining WebCore dependencies from webplugin_impl.cc

Introduces WebPluginPageDelegate to hold the methods that only
existed on WebViewDelegate to allow WebPluginImpl to talk to the
RenderView.  This enables us to eliminate those methods from
WebViewDelegate, which eliminates the last dependency on gfx/
native_widget_types.h in our WebKit interface!

WebViewDelegate grows a CreatePlugin method that returns a
WebKit::WebPlugin.  It loses its CreatePluginDelegate method,
which now lives on WebPluginPageDelegate.

This change makes RenderView use WeakPtr when it hands itself to
each WebPluginDelegateProxy and WebPluginImpl instance.  This
makes the memory management simpler.

This change also moves various WebPlugin* interfaces defined in
webkit/glue into the webkit_glue namespace.  This was to help
reduce confusion with similarly named types in the WebKit
namespace.

WebKit::WebPluginParams is added to contain the set of parameters
used to construct a plugin.

WebPluginContainer gets a couple more methods to allow us to avoid
WebCore dependencies in WebPluginImpl.

R=jam
BUG=10036
TEST=none
Review URL: http://codereview.chromium.org/181014
------------------------------------------------------------------------
r25182 | viettrungluu@chromium.org | 2009-09-02 19:01:19 +0200 (Wed, 02 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm

Mac: Fix zoom (green maximize) button.

We always maximally zoom vertically, since doing otherwise is too hard.
(We'd have to figure out the width and get the renderer to calculate the
height -- and somehow do this asynchronously.)

BUG=17472
TEST=Zoom/unzoom from a variety of window configurations (size and position), with the Dock in the different possible positions, with web content of differing intrinsic size.

Review URL: http://codereview.chromium.org/173254
------------------------------------------------------------------------
r25179 | brettw@chromium.org | 2009-09-02 18:47:08 +0200 (Wed, 02 Sep 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/status_area_view.cc

Some enhancements as requested to the compact nav bar. The search box looks
larger, back and foward moved to the right, there is a border below the tab
strip.

Importantly, the compact nav bar can be switched on and off at runtime via the
app menu (which creates a new window with it) rather than using the command
line flag.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/171112
------------------------------------------------------------------------
r25176 | phajdan.jr@chromium.org | 2009-09-02 18:34:14 +0200 (Wed, 02 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc

Remove most Sleeps from RedirectTest and wait properly.

Not fixing any Top15 flakiness, but removes the ugly polling pattern
and prevents it from being copy-pasted into new tests.

TEST=Covered by ui_tests.
BUG=none

Review URL: http://codereview.chromium.org/183037
------------------------------------------------------------------------
r25174 | jeremy@chromium.org | 2009-09-02 18:22:02 +0200 (Wed, 02 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.mm

* Spin a modal loop so that messages that cause Chrome UI to be shown don't come through, this fixes a crash in the first run import dialog.
* Fail early if NSSDecryptor detects that the environment isn't set up write to load NSS libraries.

BUG=19169
TEST=See repro instructions in bug.

Review URL: http://codereview.chromium.org/179073
------------------------------------------------------------------------
r25168 | jnd@chromium.org | 2009-09-02 16:51:10 +0200 (Wed, 02 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/US-ASCII.html

Alias 'US-ASCII' to 'ISO-8859-1' in our UI without touching webkit.BUG=15801
TEST=Add US-ASCII encoding to browser encoding test
Review URL: http://codereview.chromium.org/178017
------------------------------------------------------------------------
r25167 | mark@chromium.org | 2009-09-02 16:40:47 +0200 (Wed, 02 Sep 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Don't show favicons or throbbers for the New Tab page on the Mac.

This change nets another 35ms (15%) improvement in the duration between the
renderer requesting the NTP and it having all of the resources for the NTP
available and being completely done with layout on my Mac laptop in release
mode.

For any page which DOMUI indicates no icon should be shown, including the New
Tab page, don't show a favicon or throbber.  When the icon is removed, the
title should expand to the left to fill the void.  Compare to the behavior on
Windows and Linux.

http://groups.google.com/group/chromium-dev/browse_thread/thread/7148074f807dc5f7

BUG=13337 20378
TEST=No throbber or favicon on the New Tab page
Review URL: http://codereview.chromium.org/184003
------------------------------------------------------------------------
r25154 | ananta@chromium.org | 2009-09-02 07:22:18 +0200 (Wed, 02 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Chrome side of the fix for uploading histograms sent by automation clients. These are sent by automation clients via the AutomationMsg_RecordHistograms IPC message. These histograms are then added to the list maintained by the StatisticsRecorder object.

Partial fix for http://b/issue?id=2059267

Bug=2059267

Review URL: http://codereview.chromium.org/173529
------------------------------------------------------------------------
r25153 | thestig@chromium.org | 2009-09-02 07:04:57 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Fix BrowserEncodingTest to use FilePaths and cleanup temporary files.

BUG=none
TEST=Running this test should not leave extra files in the temp dir.
Review URL: http://codereview.chromium.org/176057
------------------------------------------------------------------------
r25149 | thestig@chromium.org | 2009-09-02 05:33:39 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_backend_unittest.cc

Fix two tests that leak temporary files.

BUG=none
TEST=Run ExtensionsServiceTest and SessionBackendTest, make sure they don't leave extra temp files behind.
Review URL: http://codereview.chromium.org/180068
------------------------------------------------------------------------
r25133 | brettw@chromium.org | 2009-09-02 02:35:58 +0200 (Wed, 02 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   A /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc
   A /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/chrome.gyp

Split ExtraRequestInfo out of ResourceDispatcherHost so it isn't cluttering up
that header file. I added documentation and split out the accessors according
to Google-style.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/179046
------------------------------------------------------------------------
r25131 | brettw@chromium.org | 2009-09-02 02:24:18 +0200 (Wed, 02 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/app/gfx/font_skia.cc
   M /trunk/src/chrome/browser/views/frame/status_area_view.cc

Workaround Skia and Pango measuring font heights differently by asking Pango
for the height that we'll report in the gfx::Font. This seems wrong, but at
least things will look reasonable until we find a better solution.

This changes the existing height computation code to use ceiling. Even though
this is no longer used, it is good to have the correct code for the height
computation here so that if we find a better solution, it will be run properly.

This also gives more room for the clock in the status area view because the
height is now more and we want it to be aligned properly.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/183044
------------------------------------------------------------------------
r25129 | mdm@chromium.org | 2009-09-02 02:23:28 +0200 (Wed, 02 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h

Fix a comment typo. No code change.
BUG=none
TEST=none

------------------------------------------------------------------------
r25128 | tony@chromium.org | 2009-09-02 02:21:18 +0200 (Wed, 02 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Don't paint the throbber animation while dragging.

Windows doesn't paint the throbber either, so we match.  We can
probably add it back in if we want, but it might not be worth
the effort.

BUG=20750

Review URL: http://codereview.chromium.org/183039

------------------------------------------------------------------------
r25126 | jhawkins@chromium.org | 2009-09-02 02:12:05 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h

gtk: Don't complete the tab drag if the user canceled the drag operation.

BUG=20155
TEST=Start dragging a tab and press esc.  The tab should go back to the source tabstrip.
Review URL: http://codereview.chromium.org/173653
------------------------------------------------------------------------
r25120 | mpcomplete@chromium.org | 2009-09-02 01:48:28 +0200 (Wed, 02 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   D /trunk/src/chrome/test/data/extensions/uitest/window_open/manifest.json
   D /trunk/src/chrome/test/data/extensions/uitest/window_open/newtab.html
   D /trunk/src/chrome/test/data/extensions/uitest/window_open/test.html

Revert accidental commits: r25115 and r25116

Review URL: http://codereview.chromium.org/183045
------------------------------------------------------------------------
r25118 | sky@chromium.org | 2009-09-02 01:39:07 +0200 (Wed, 02 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Minor tweaks to how pin tabs look:
. Increases the width by 8 pixels.
. Animates the position of the favicon when the tab changes from
  pinned to unpinned. Without this the favicon jumps noticably.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/183040
------------------------------------------------------------------------
r25116 | mpcomplete@chromium.org | 2009-09-02 01:34:52 +0200 (Wed, 02 Sep 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

formatting
------------------------------------------------------------------------
r25115 | mpcomplete@chromium.org | 2009-09-02 01:33:39 +0200 (Wed, 02 Sep 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   A /trunk/src/chrome/test/data/extensions/uitest/window_open
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/newtab.html
   A /trunk/src/chrome/test/data/extensions/uitest/window_open/test.html

Merge branch 'api' of /src/chrome/src into api
------------------------------------------------------------------------
r25114 | dglazkov@chromium.org | 2009-09-02 01:32:23 +0200 (Wed, 02 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable two DevToolsSanityTests. They started failing after http://trac.webkit.org/changeset/47944 came downstream.

TBR=pfeldman
BUG=20835
TEST=none

Review URL: http://codereview.chromium.org/180073
------------------------------------------------------------------------
r25109 | eroman@chromium.org | 2009-09-02 01:13:15 +0200 (Wed, 02 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/url_request/url_request_job_manager.cc
   A /trunk/src/net/url_request/url_request_view_net_internal_job.cc
   A /trunk/src/net/url_request/url_request_view_net_internal_job.h

Add skeleton for an about:net-internal page.

This page contains low-level debug information that is of interest to power users, and bug investigators.

The output can be filtered by using special sub-URLs.
The sub-URLs themselves are listed when visiting about:net-internal, but to give an idea:

  about:net-internal -- everything
  about:net-internal/proxyservice -- all things proxy
  about:net-internal/proxyservice.config -- current settings
  about:net-internal/hostresolver.hostcache -- dns cache
  
BUG=http://crbug.com/14478
R=darin
Review URL: http://codereview.chromium.org/173024
------------------------------------------------------------------------
r25107 | arv@google.com | 2009-09-02 00:47:17 +0200 (Wed, 02 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP cleanup

- Fix bookmark sync background color
- Make hidden elements not take up space at the bottom of the NNTP
- Simplify sync and set as home page
- Fix issue where middle clicking on the sync link opened a new tab

BUG=19538

TEST=None

Review URL: http://codereview.chromium.org/178065
------------------------------------------------------------------------
r25100 | mdm@chromium.org | 2009-09-02 00:32:26 +0200 (Wed, 02 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc

Linux: handle external protocols, e.g. mailto: links.
BUG=20696
TEST=click a mailto: link, it should open your default MUA

Review URL: http://codereview.chromium.org/177040
------------------------------------------------------------------------
r25099 | michaeln@google.com | 2009-09-02 00:30:30 +0200 (Wed, 02 Sep 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/appcache/appcache_backend_proxy.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc
   M /trunk/src/chrome/common/appcache/appcache_dispatcher_host.h
   M /trunk/src/chrome/common/appcache/appcache_frontend_proxy.cc
   A /trunk/src/chrome/common/appcache/chrome_appcache_service.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/webkit/appcache/appcache_backend_impl.cc
   M /trunk/src/webkit/appcache/appcache_backend_impl.h
   M /trunk/src/webkit/appcache/appcache_host.h
   A /trunk/src/webkit/appcache/appcache_interceptor.cc
   A /trunk/src/webkit/appcache/appcache_interceptor.h
   M /trunk/src/webkit/appcache/appcache_service.cc
   M /trunk/src/webkit/appcache/appcache_service.h
   M /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   A /trunk/src/webkit/tools/test_shell/simple_appcache_system.cc
   M /trunk/src/webkit/tools/test_shell/simple_appcache_system.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/webkit.gyp

Plumb request interception into the appcache library for both chrome and test_shell.

AppCache library:
* Added AppCacheInterceptor, which is derived from URLRequest::Interceptor.

Chrome:
* Each UserProfile instantiates a ChromeAppCacheService, which is derived from an appcache library class.
* Each ChromeURLRequestContext associated with that profile has a reference to that instance.
* ResourceDispatcherHost pokes AppCacheInterceptor when initiating URLRequests and when returning the response head.

TestShell:
* Added SimpleAppCacheSystem which bundles together appcache lib components for use in a single process with an UI and IO thread.
* TestShellWebKit instantiates and initializes an instance of the above, aimed at at temp directory that will get cleaned up when the test run is over.
* SimpleResourceLoaderBridge pokes the system when initiating URLRequests and when returning the response head.

TEST=none, although many existing tests exercise this stuff
BUG=none

Review URL: http://codereview.chromium.org/173406
------------------------------------------------------------------------
r25088 | viettrungluu@chromium.org | 2009-09-01 23:02:36 +0200 (Tue, 01 Sep 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/clickhold_button_cell.h
   M /trunk/src/chrome/browser/cocoa/clickhold_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/clickhold_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm
   A /trunk/src/chrome/browser/cocoa/delayedmenu_button_unittest.mm
   M /trunk/src/chrome/chrome.gyp

(Mac) Added unit tests for ClickHoldButtonCell and DelayedMenuButton.

Also added some comments and cleaned up some code.

BUG=20693
TEST=Run unit tests. Also make sure back/forward buttons (and menus) \
     work correctly.

Review URL: http://codereview.chromium.org/179043
------------------------------------------------------------------------
r25081 | arv@google.com | 2009-09-01 22:22:09 +0200 (Tue, 01 Sep 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Escape the URL for the CSS url function.

This fixes issues where the thumbnail on the NTP wasn't showing.

BUG=18380

TEST=Make sure that the following pages show thumbnails on the new tab
page:

  http://digg.com/?\
  http://code.google.com/p/chromium/issues/list?can=2&q=&sort=-id&colspec=ID+Stars+Pri+Area+Type+Status+Summary+Modified+Owner
  http://code.google.com/p/chromium/issues/list?can=2&q=&sort=-id&colspec=ID%20Stars%20Pri%20Area%20Type%20Status%20Summary%20Modified%20Owner

Review URL: http://codereview.chromium.org/178061
------------------------------------------------------------------------
r25080 | erg@google.com | 2009-09-01 22:14:56 +0200 (Tue, 01 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

GTK: Use rounded corners in AutocompletePopupViewGtk.

Review URL: http://codereview.chromium.org/173646
------------------------------------------------------------------------
r25077 | pinkerton@chromium.org | 2009-09-01 22:12:31 +0200 (Tue, 01 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Remove un-needed method (updateLoadingAnimations).
BUG=8281
TEST=none.
Review URL: http://codereview.chromium.org/181037
------------------------------------------------------------------------
r25075 | estade@chromium.org | 2009-09-01 21:41:12 +0200 (Tue, 01 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Squash the bookmark bar into the toolbar by 4 pixels.

On windows they do this by having the two views overlap. We can't so instead move the bottom 4 pixels of padding from the toolbar widget into the bookmark bar widget. When the bookmark bar is closed/hidden, it still shows those 4 pixels. When it opens, it is able to make use of those 4 pixels. Since we get 4 extra pixels, we can make the overall height of the bookmark bar 4 pixels less.

BUG=18570

Review URL: http://codereview.chromium.org/178029
------------------------------------------------------------------------
r25067 | estade@chromium.org | 2009-09-01 20:56:35 +0200 (Tue, 01 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/app/gtk_dnd_util.cc
   M /trunk/src/app/gtk_dnd_util.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h

GTK: Make the toolbar star button a drag source.

Also refactor URI list/named url packing code.

BUG=19008

Review URL: http://codereview.chromium.org/175036
------------------------------------------------------------------------
r25063 | jcampan@chromium.org | 2009-09-01 20:37:39 +0200 (Tue, 01 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/app/gfx/font.h
   M /trunk/src/app/gfx/font_gtk.cc
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget_gtk.cc

Porting textfield to toolkit_views Gtk.

BUG=None
TEST=Run the view unit-tests.

See original review:
http://codereview.chromium.org/165512/show
Review URL: http://codereview.chromium.org/180061
------------------------------------------------------------------------
r25057 | tony@chromium.org | 2009-09-01 20:13:07 +0200 (Tue, 01 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Set the window type hint for the options dialog and
task manager to GDK_WINDOW_TYPE_HINT_NORMAL.  This allows the
dialogs to go behind browser windows in metacity.

I did it for these two dialogs mainly because they have links
to web pages. The links should be able to open on top of the
dialog.

Review URL: http://codereview.chromium.org/179014

------------------------------------------------------------------------
r25053 | pkasting@chromium.org | 2009-09-01 19:27:03 +0200 (Tue, 01 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Unbreak the world.  Turns out SetProfile(NULL) causes a DCHECK failure.

TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/177055
------------------------------------------------------------------------
r25050 | erg@google.com | 2009-09-01 19:18:02 +0200 (Tue, 01 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   A /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.cc
   A /trunk/src/chrome/browser/extensions/gtk_theme_preview_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/chrome.gyp

GTK Themes: The Theme Installed Infobar's "Undo" button should work with GTK Themes.

http://crbug.com/20629

Review URL: http://codereview.chromium.org/181022
------------------------------------------------------------------------
r25049 | pinkerton@chromium.org | 2009-09-01 19:13:13 +0200 (Tue, 01 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Restrict use of tab positioning animation on a new tab to when there are more than one tab. Don't use animation on new tab button
BUG=none
TEST=NTB shows up correctly and doesn't show during drags.
Review URL: http://codereview.chromium.org/174579
------------------------------------------------------------------------
r25047 | phajdan.jr@chromium.org | 2009-09-01 19:07:17 +0200 (Tue, 01 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html
   D /trunk/src/net/ftp/ftp_directory_parser.cc
   D /trunk/src/net/ftp/ftp_directory_parser.h
   M /trunk/src/net/net.gyp
   A /trunk/src/net/third_party
   A /trunk/src/net/third_party/parseftp
   A /trunk/src/net/third_party/parseftp/ParseFTPList.cpp (from /trunk/src/net/ftp/ftp_directory_parser.cc:24973)
   A /trunk/src/net/third_party/parseftp/ParseFTPList.h (from /trunk/src/net/ftp/ftp_directory_parser.h:24973)
   A /trunk/src/net/third_party/parseftp/README.chromium
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc

Move Mozilla FTP LIST response parsing code to net/third_party directory.

This should make licensing terms and third-party origin of the code more clear.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/179041
------------------------------------------------------------------------
r25046 | dglazkov@chromium.org | 2009-09-01 19:00:28 +0200 (Tue, 01 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable MessagingContentScript test due to flakiness

TBR=mpcomplete
BUG=20795
TEST=none

Review URL: http://codereview.chromium.org/176061
------------------------------------------------------------------------
r25045 | sky@chromium.org | 2009-09-01 18:59:31 +0200 (Tue, 01 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser_about_handler.cc
   A /trunk/src/chrome/browser/chromeos/chromeos_version_loader.cc
   A /trunk/src/chrome/browser/chromeos/chromeos_version_loader.h
   A /trunk/src/chrome/browser/chromeos/chromeos_version_loader_unittest.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

When running on chrome OS about:version now shows OS version.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/179063
------------------------------------------------------------------------
r25044 | pkasting@chromium.org | 2009-09-01 18:59:11 +0200 (Tue, 01 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/common/notification_type.h

More work fixing miscellaneous issues in the autocomplete code, probably none of which will help my crasher :(

* Force the query to stop if the user deletes a match.  This makes more sense from a UI perspective and allows some code to be simpler.
* Prevent us from potentially doing a "minimal changes" match in a different profile (hard to trigger, likely no practical effects)
* Remove unneeded Reset() call on a repeating timer (which will auto-reset itself)
* Rename one of the notifications and move its listener to the edit, since that's who really cares about it anyway.
* Make the controller's Stop(true) notify the popup via the normal observer pipeline rather than coding something special into the popup's StopAutocomplete().
* Rename |paste_and_go_controller| |synchronous_controller| and use it instead of using the main popup controller to do the synchronous query when calling URLsForDefaultMatch().  This makes things both simpler and safer.

BUG=none
TEST=Using the omnibox still works fine
Review URL: http://codereview.chromium.org/178049
------------------------------------------------------------------------
r25036 | erikkay@chromium.org | 2009-09-01 17:49:37 +0200 (Tue, 01 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js

more bookmark tests, plus fix a couple of API bugs

BUG=19099,17288
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks

Review URL: http://codereview.chromium.org/183020
------------------------------------------------------------------------
r25035 | pinkerton@chromium.org | 2009-09-01 17:36:00 +0200 (Tue, 01 Sep 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/background_gradient_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/base_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/command_observer_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/event_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/fullscreen_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/infobar_gradient_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/search_engine_list_model_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view_unittest.mm

Make all of our unit tests be PlatformTests to get an autorelease pool.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/178037
------------------------------------------------------------------------
r25029 | viettrungluu@chromium.org | 2009-09-01 15:40:24 +0200 (Tue, 01 Sep 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

(Mac) Make mashing the close tab button work.

To do this, I had to commit several crimes against humanity. In
particular, Cocoa doesn't generate the required extra hit tests during
animations, so we have to. Sometimes, it gets really messed up and ends
up hitting the "drag blocking view". Moreover, we have to account for
the possibility of the mouse down hitting a moving tab, and going up on
the close button, etc.

BUG=17720
TEST=Mash the close tabs button under a wide variety of situations. \
     Also make sure that the handling of the tabs (dragging, etc.)  \
     hasn't accidentally been messed up.

Review URL: http://codereview.chromium.org/174461
------------------------------------------------------------------------
r25013 | aa@chromium.org | 2009-09-01 05:17:42 +0200 (Tue, 01 Sep 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/extensions/pack_extension_job.cc
   A /trunk/src/chrome/browser/extensions/pack_extension_job.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc
   M /trunk/src/chrome/chrome.gyp

A few more fixes to chrome://extensions/.

* Pull PackExtensionJob out into its own file so that it could
  more easily be reused in the future.

* Disable OK button while PackExtnesionJob is running to give
  a bit of feedback that something is happening.

* Fix title-casing. Apparently sentence-casing is Google UX
  stanard.

Review URL: http://codereview.chromium.org/176047
------------------------------------------------------------------------
r25010 | yusukes@google.com | 2009-09-01 04:28:11 +0200 (Tue, 01 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc

Fix a DCHECK corner case.
Allow (current + new == max) case.

BUG=20673
TEST=none

Review URL: http://codereview.chromium.org/176037
------------------------------------------------------------------------
r25007 | jhawkins@chromium.org | 2009-09-01 03:50:37 +0200 (Tue, 01 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_gtk.cc

gtk: Fix a typo that breaks tab dragging when another gtk window is minimized.

BUG=20228,20513
TEST=Extensive tab dragging.
Review URL: http://codereview.chromium.org/182034
------------------------------------------------------------------------
r25006 | asargent@chromium.org | 2009-09-01 03:44:03 +0200 (Tue, 01 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_tabs_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_apitest.js
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js
   M /trunk/src/chrome/test/data/extensions/api_test/override1/test.js
   A /trunk/src/chrome/test/data/extensions/api_test/tabs
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/tabs/test.js

Add browser tests for extensions tab API.

BUG=18442
TEST=none

Review URL: http://codereview.chromium.org/174633
------------------------------------------------------------------------
r25005 | tony@chromium.org | 2009-09-01 03:22:28 +0200 (Tue, 01 Sep 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Fix the position of the throbber for pinned tabs.  It was wrong before,
but we repainted the whole pinned tab so it wasn't as obvious.  With
this change, the throbber is placed where the favicon will go.

BUG=20626

Review URL: http://codereview.chromium.org/175038

------------------------------------------------------------------------
r25002 | tony@chromium.org | 2009-09-01 03:06:32 +0200 (Tue, 01 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

Set the info bubble popups as _NET_WM_WINDOW_TYPE_UTILITY so they
don't show up in the task bar.

Review URL: http://codereview.chromium.org/177046

------------------------------------------------------------------------
r24998 | mhm@chromium.org | 2009-09-01 03:00:23 +0200 (Tue, 01 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc

Update hunspell DEPS to 1.2.8

BUG=14756
TEST=Ran valgrind and unit_tests for SpellCheckTest and all passed successfully.

Review URL: http://codereview.chromium.org/176046
------------------------------------------------------------------------
r24996 | thestig@chromium.org | 2009-09-01 02:55:22 +0200 (Tue, 01 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Cleanup temporary files created by the extension updater unit test.

BUG=None
TEST=Run unit_tests --gtest_filter=ExtensionUpdaterTest.*, make sure there's no extra temporary files after the test finishes.
Review URL: http://codereview.chromium.org/173635
------------------------------------------------------------------------
r24987 | mirandac@chromium.org | 2009-09-01 02:24:54 +0200 (Tue, 01 Sep 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Reverting 24982.
Review URL: http://codereview.chromium.org/175041
------------------------------------------------------------------------
r24982 | mirandac@chromium.org | 2009-09-01 02:19:05 +0200 (Tue, 01 Sep 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

This is only for 195; will be reverted immediately.

Review URL: http://codereview.chromium.org/179052
------------------------------------------------------------------------
r24979 | agl@chromium.org | 2009-09-01 02:12:58 +0200 (Tue, 01 Sep 2009) | 10 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   A /trunk/src/chrome/browser/memory_details_linux.cc
   A /trunk/src/chrome/browser/memory_details_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/browser/resources/about_memory_linux.html
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Linux: about:memory

(based on http://code.google.com/p/chromium/issues/detail?id=16251)

Add about:memory support to Linux. Rather than try and copy the
Windows output, we use a couple of metrics which make more sense on
Linux: USS and PSS.

http://codereview.chromium.org/177024

------------------------------------------------------------------------
r24977 | rvargas@google.com | 2009-09-01 02:08:35 +0200 (Tue, 01 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

RDH: Don't attempt to sniff the mime type of requests that
don't have a body.

BUG=16873
TEST=unittests

Review URL: http://codereview.chromium.org/173536
------------------------------------------------------------------------
r24971 | derat@chromium.org | 2009-09-01 01:41:21 +0200 (Tue, 01 Sep 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Simplify omnibox selection code and stop taking back selection.

This fixes a long-time bug (mentioned at the end of my description
in http://codereview.chromium.org/159185 but reported more recently)
where Chrome would steal back the PRIMARY selection the first time
that another app takes it.

I tested by going through my test cases from the following earlier
changes and also confirming that the selection-stealing issue is also
fixed:

  http://codereview.chromium.org/151006
  http://codereview.chromium.org/155971
  http://codereview.chromium.org/159185
  http://codereview.chromium.org/164539
  http://codereview.chromium.org/173098

BUG=20460
TESTED=see above

Review URL: http://codereview.chromium.org/176029
------------------------------------------------------------------------
r24966 | kuchhal@chromium.org | 2009-09-01 01:33:50 +0200 (Tue, 01 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

Delete first run dialog on Linux when done.

BUG=18429

Review URL: http://codereview.chromium.org/182037
------------------------------------------------------------------------
r24962 | tommi@chromium.org | 2009-09-01 01:29:13 +0200 (Tue, 01 Sep 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/test/automation/automation_messages.h

Explicitly including the redirect status with the AutomationURLResponse info.
Before we were always defaulting to 301.

TEST=run automation tests.
BUG=none

Review URL: http://codereview.chromium.org/178041
------------------------------------------------------------------------
r24960 | tony@chromium.org | 2009-09-01 01:10:55 +0200 (Tue, 01 Sep 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Paint the hover animation state when painting just the favicon.

BUG=20658

Review URL: http://codereview.chromium.org/173630

------------------------------------------------------------------------
r24959 | jeremy@chromium.org | 2009-09-01 01:08:00 +0200 (Tue, 01 Sep 2009) | 17 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/app/breakpad_mac.h
   M /trunk/src/chrome/app/breakpad_mac.mm
   M /trunk/src/chrome/app/breakpad_mac_stubs.mm
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/first_run_mac.mm

Change when we enable Apple's Crash reporter.

Enable Apple Crash Reporter for Browser process in Non-Debug builds.

* Introduce mac_util::IsBackgroundProcess().
* Invert logic around Breakpad Enabling/Disabling to make it clearer.
* Honor the kDisableBreakpad switch.

Our new policy:
* Breakpad is enabled/disabled based on the user stats reporting opt-in flag - this hasn't changed.
* Always disable Apple Crash in background processes (plug-in, renderer, etc).
* If Breakpad is enabled browser crashes will be passed to Crash Reporter.
* If Breakpad is NOT enabled browser [or any other foreground app] crashes will be passed to Crash Reporter in Release builds.

Effectively this means that we now enable Crash Reporter for the browser process in Chromium release builds so these will no longer crash silently with no trace.

Review URL: http://codereview.chromium.org/180048
------------------------------------------------------------------------
r24946 | mdm@chromium.org | 2009-09-01 00:08:22 +0200 (Tue, 01 Sep 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Fix comment grammar. No code change.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/182036
------------------------------------------------------------------------
r24941 | amanda@chromium.org | 2009-08-31 23:39:22 +0200 (Mon, 31 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Update BackingStore to handle the case where our Cocoa view has
not been inserted into a window yet.
BUG=20009
TEST=tabs opened in the background should not be blank when you switch to them.

Review URL: http://codereview.chromium.org/175027
------------------------------------------------------------------------
r24939 | shess@chromium.org | 2009-08-31 23:21:31 +0200 (Mon, 31 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Fix operation of Control key in Omnibox.

http://crbug.com/20455
TEST=Enter "this" into address bar.  Hold Control, should see
"www.this.com" as first item.  Release, and it should go back to
"this" immediately.

Review URL: http://codereview.chromium.org/182021
------------------------------------------------------------------------
r24938 | shess@chromium.org | 2009-08-31 23:14:41 +0200 (Mon, 31 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/keystone_glue.m
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

OSX: Remove some nsnotificationcenter observers more reliably.

There are some crashers which show up as an objc_msgSend when posting
a notification.  So I went around reviewing our observers looking for
places where it's possible that we weren't unregistering correctly.
These may have already been correct, but this change would seem to
make unregistration more reliable.

Review URL: http://codereview.chromium.org/174480
------------------------------------------------------------------------
r24936 | shess@chromium.org | 2009-08-31 23:11:38 +0200 (Mon, 31 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Fix Option-return in Omnibox.

Option-return inserted a literal newline, did not want.  Also fixed
Option-tab to not insert literal tab.

http://crbug.com/17914
TEST=Type text, option-tab should not insert literal tab,
option-return should not insert newline.  Both should do nothing.

Review URL: http://codereview.chromium.org/181024
------------------------------------------------------------------------
r24931 | pkasting@chromium.org | 2009-08-31 22:54:30 +0200 (Mon, 31 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc

I was too aggressive when placing this check.  With rapid typing and deletion it's perfectly reasonable for the controller to be running a query when the popup is not open.

TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/177041
------------------------------------------------------------------------
r24930 | mattm@chromium.org | 2009-08-31 22:53:53 +0200 (Mon, 31 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   A /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   D /trunk/src/chrome/browser/tab_contents/repost_form_warning.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/test_browser_window.h

Gtk confirm form resubmission dialog.

Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog

BUG=19761
TEST=see bug

Review URL: http://codereview.chromium.org/174294
------------------------------------------------------------------------
r24928 | pkasting@chromium.org | 2009-08-31 22:32:16 +0200 (Mon, 31 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc

Reland r24920 without the other cruft that I had in my checkout, which broke the compile.

TBR=mmoss
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/176043
------------------------------------------------------------------------
r24927 | mmoss@chromium.org | 2009-08-31 22:15:07 +0200 (Mon, 31 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc

Revert r24920 due to compile failures.

TBR=pkasting

Review URL: http://codereview.chromium.org/181023

------------------------------------------------------------------------
r24924 | mmoss@chromium.org | 2009-08-31 22:05:56 +0200 (Mon, 31 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

TBR:pkasting

------------------------------------------------------------------------
r24920 | pkasting@chromium.org | 2009-08-31 21:38:13 +0200 (Mon, 31 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc

Minor autocomplete fixes while trying to track down a topcrash:
* Turn some DCHECKs into CHECKs (I don't think any of these will get hit)
* Ensure that URLsForDefaultMatch() doesn't leave any results lying around on the controller, since the popup isn't open (and those two states should be locked in step)
* Eliminate some old code in Move() that shouldn't have actually done anything anymore (since result() should already be in sync with the popup, and SetSelectedLine() is going to stop the controller)
* Use a pre-existing helper function at two places in the Edit for readability

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/180045
------------------------------------------------------------------------
r24919 | estade@chromium.org | 2009-08-31 21:36:33 +0200 (Mon, 31 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Don't hardcode the timeout in the unload ui test.

The too-short timeout was making it leak in valgrind.

BUG=20617
Review URL: http://codereview.chromium.org/180044
------------------------------------------------------------------------
r24915 | rafaelw@chromium.org | 2009-08-31 21:29:10 +0200 (Mon, 31 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable flakey browsertests on Linux.

This disables ExtensionMessagingTab and ExtensionViews

TBR=estade

Review URL: http://codereview.chromium.org/173632

------------------------------------------------------------------------
r24914 | pkasting@chromium.org | 2009-08-31 21:23:33 +0200 (Mon, 31 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h

Make AutocompleteController::done() match up with when results are actually pushed to listeners.  r24290 made it possible for the controller to be "done" (in that all providers had finished) but have not yet sent the final results to listeners.  This makes done() only return true when the controller has actually pushed the final results.

I'm not sure precisely what effects this discrepancy could have had but I suspect they were bad, given that callers assume done() means "results are stable".

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173631
------------------------------------------------------------------------
r24913 | mmoss@chromium.org | 2009-08-31 20:58:19 +0200 (Mon, 31 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/webkit/tools/test_shell/media_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc

Linux 64-bit: Fix failing unit_tests and ignore non-working plugin/media tests.

Related bugs:
http://crbug.com/18337
http://crbug.com/20467

Review URL: http://codereview.chromium.org/175019

------------------------------------------------------------------------
r24911 | estade@chromium.org | 2009-08-31 20:31:05 +0200 (Mon, 31 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h

Don't resize the renderer while opening the bookmark bar or an infobar.

This is just a performance optimization. Previously this code was added for closing bookmark bars as a bit of visual polish.Doing the same thing for opening bookmark bars should reduce CPU usage but it won't look any different (for fast computers anyway).

BUG=17133

Review URL: http://codereview.chromium.org/183011
------------------------------------------------------------------------
r24905 | sky@chromium.org | 2009-08-31 20:09:47 +0200 (Mon, 31 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Makes 'Pin tab' option in context menu a checkbox.

BUG=20575
TEST=On linux pin a tab. Right click on the tab and make sure you see
     a check next to 'Pin Tab'.

Review URL: http://codereview.chromium.org/175028
------------------------------------------------------------------------
r24903 | jhawkins@chromium.org | 2009-08-31 19:55:01 +0200 (Mon, 31 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

gtk: Use a GtkInvisible to track the tab dragging operation.  Originally we were using the actual tab widget for this purpose, but this is unreliable becauase we hide and detach the tab widget, which disturbs the drag operation.

BUG=19725,20513
TEST=Extensive tab dragging.
Review URL: http://codereview.chromium.org/176034
------------------------------------------------------------------------
r24901 | phajdan.jr@chromium.org | 2009-08-31 19:41:45 +0200 (Mon, 31 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/importer_lock_view.cc

Removes unnecessary using-declaration.

Patch by Thiago Farina. Original review: http://codereview.chromium.org/177031

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/173629
------------------------------------------------------------------------
r24899 | brettw@chromium.org | 2009-08-31 19:27:45 +0200 (Mon, 31 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener.cc
   M /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/memory_details.cc
   A /trunk/src/chrome/browser/net/url_request_tracking.cc
   A /trunk/src/chrome/browser/net/url_request_tracking.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_request_info.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h

Replace the RenderProcessHost.PID function that returns the OS-generated
process ID with an internally-generated id() function. This allows us the
guarantee that the IDs are unique over the entire run of the application.

This also cleans up some code associated with managing the PID.

The main potentially interesting change is now the PID is set uniquely for
every creation of RenderProcessHost. It used to be set cleared if the process
went away, and re-set if the process was re-created. The ID generation is in
ChildProcesInfo so it is also unique between workers and plugins. I had to
change some significant things in resource_dispatcher_host_unittest to take
into account this new generation of IDs.

BUG=17828
TEST=none
Review URL: http://codereview.chromium.org/160203
------------------------------------------------------------------------
r24896 | mirandac@chromium.org | 2009-08-31 19:21:12 +0200 (Mon, 31 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Fix the color of links in list form so that they're themed and not default blue.

BUG= http://crbug.com/20277
TEST= Open NTP, try out some themes, observe that links change color to keep up with theme, and are legible against background of page.

Review URL: http://codereview.chromium.org/176033
------------------------------------------------------------------------
r24892 | erikkay@chromium.org | 2009-08-31 19:15:47 +0200 (Mon, 31 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_test_api.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/js_only_v8_extensions.cc
   M /trunk/src/chrome/renderer/extensions/js_only_v8_extensions.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   A /trunk/src/chrome/renderer/resources/extension_apitest.js
   D /trunk/src/chrome/test/data/extensions/api_test/bookmarks/api_test.js
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.html
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/override1/api_test.js
   M /trunk/src/chrome/test/data/extensions/api_test/override1/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/override1/downloads.html
   M /trunk/src/chrome/test/data/extensions/api_test/override1/history.html
   M /trunk/src/chrome/test/data/extensions/api_test/override1/newtab.html
   M /trunk/src/chrome/test/data/extensions/api_test/override1/nonexistant.html
   M /trunk/src/chrome/test/data/extensions/api_test/override1/test.js
   D /trunk/src/chrome/test/data/extensions/api_test/storage/api_test.js
   M /trunk/src/chrome/test/data/extensions/api_test/storage/background.html
   M /trunk/src/chrome/test/data/extensions/api_test/storage/tab.html
   M /trunk/src/chrome/test/render_view_test.cc

share extension API test framework

BUG=18442
TEST=ExtensionApiTest.*

Review URL: http://codereview.chromium.org/173622
------------------------------------------------------------------------
r24890 | mdm@chromium.org | 2009-08-31 19:13:49 +0200 (Mon, 31 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc

Linux: make search engines dialog size based on locale settings.
BUG=20453
TEST=none

Review URL: http://codereview.chromium.org/180034
------------------------------------------------------------------------
r24888 | tommi@chromium.org | 2009-08-31 18:57:08 +0200 (Mon, 31 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Sanitizing the referrer header before starting the automation request.TEST=Run automation unit tests.BUG=none
Review URL: http://codereview.chromium.org/183004
------------------------------------------------------------------------
r24883 | mirandac@chromium.org | 2009-08-31 18:20:14 +0200 (Mon, 31 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc

Adding command-line option to override bans on certain port numbers through a comma-separated list of ports.

BUG= http://crbug.com/18307
TEST= url_request_unittest, use commandline flag allowed_ports=1,600. Navigate to http://www.google.com:1 or http://www.google.com:600. You should not get an ERR_UNSAFE_PORT, it will attempt to load the page.

------------------------------------------------------------------------
r24882 | aa@chromium.org | 2009-08-31 17:47:06 +0200 (Mon, 31 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc

Fix two bugs in chrome://extensions/:

* CHECK when reloading installed extension. Caused because we
  were somtimes trying to register for the same notifications
  twice.

* Not able to "Reload" extensions that were loaded with
  "Load Unpacked Extension".

TBR=erikkay@chromium.org

Review URL: http://codereview.chromium.org/178033
------------------------------------------------------------------------
r24881 | avi@chromium.org | 2009-08-31 17:17:11 +0200 (Mon, 31 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/back_Template.pdf
   M /trunk/src/chrome/app/theme/close_bar_h.pdf
   M /trunk/src/chrome/app/theme/close_bar_p.pdf
   M /trunk/src/chrome/app/theme/forward_Template.pdf
   M /trunk/src/chrome/app/theme/go_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/reload_Template.pdf
   M /trunk/src/chrome/app/theme/star_Template.pdf
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Updates to clean up default theme and add hover states.

Patch by Cole.

BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438
TEST=none

Review URL: http://codereview.chromium.org/165499

------------------------------------------------------------------------
r24877 | aa@chromium.org | 2009-08-31 12:31:06 +0200 (Mon, 31 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   A /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc
   M /trunk/src/chrome/chrome.gyp

Adds a button to chrome://extensions/ that allows easy packing
of extensions into crx files.

BUG=20578
TEST=Create a sample extension, pack it, then try to install it.

Review URL: http://codereview.chromium.org/181020
------------------------------------------------------------------------
r24876 | aa@chromium.org | 2009-08-31 12:21:05 +0200 (Mon, 31 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/default_extension_icon_128.png

Update temporary default extension icon to the Google Labs
'beaker'. It isn't clear how LGPL applies to images, so
to avoid hassle, replaced the old icon with something else.

TBR=erikkay@chromium.org
------------------------------------------------------------------------
r24875 | jhawkins@chromium.org | 2009-08-31 08:42:06 +0200 (Mon, 31 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

gtk: Get rid of the title-centering code in TabRendererGtk.  DrawStringInt centers the text for us already.  This change also removes a hack that modified the clipping rect unnecessarily.

BUG=20401,20610
TEST=none
Review URL: http://codereview.chromium.org/179037
------------------------------------------------------------------------
r24871 | aa@chromium.org | 2009-08-30 22:55:11 +0200 (Sun, 30 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Add a button to chrome://extensions to load an extension.

BUG=20577
TBR=rafaelw@chromium.org

Review URL: http://codereview.chromium.org/177032
------------------------------------------------------------------------
r24866 | aa@chromium.org | 2009-08-30 08:59:06 +0200 (Sun, 30 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Pretty up the chrome://extensions/ page a bit.

This is what it looks like with this change:
http://dl.getdropbox.com/u/124107/cap.png

Note that this removes the information about content scripts.
I would actually like to expand that information to show all
the components of the extension eventually, but with just
content scripts, it didn't seem super useful.

TBR=rafaelw@chromium.org
------------------------------------------------------------------------
r24865 | finnur@chromium.org | 2009-08-30 05:59:01 +0200 (Sun, 30 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Fix warnings in Linux build.

TBR=erikkay
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/173623
------------------------------------------------------------------------
r24864 | finnur@chromium.org | 2009-08-30 05:47:26 +0200 (Sun, 30 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/test_browser_window.h

Experiment with dislodging the Extension Shelf and having it only appear on the New Tab page.

BUG=http://crbug.com/20415
TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity.

Review URL: http://codereview.chromium.org/175017
------------------------------------------------------------------------
r24863 | jhawkins@chromium.org | 2009-08-30 05:18:17 +0200 (Sun, 30 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

gtk: Schedule a paint operation for the previously selected tab when selecting a new tab.

BUG=20583
TEST=Open a browser with two tabs.  Select the unselected tab.  The now-unselected tab should be rendered as unselected.
Review URL: http://codereview.chromium.org/182025
------------------------------------------------------------------------
r24862 | jhawkins@chromium.org | 2009-08-30 05:17:26 +0200 (Sun, 30 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

gtk: Initialize |background_offset_x_|.  When rendering a dragged tab, we weren't hitting the codepath that initializes this variable, leading to a UMR that caused glitchy rendering.

BUG=20157
TEST=Drag a tab.  The rendering should not be glitchy.
Review URL: http://codereview.chromium.org/176035
------------------------------------------------------------------------
r24861 | ananta@chromium.org | 2009-08-30 01:45:34 +0200 (Sun, 30 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_observers.cc

The DomOperationNotificationObserver::Observe function can get invoked from other paths in the browser, like navigating away from Interstitial pages, etc. We end up crashing the browser because of dereferencing a NULL reply_message pointer.

Added a check for the same.

This fixes http://b/issue?id=2057296

Bug=2057296

Review URL: http://codereview.chromium.org/179024
------------------------------------------------------------------------
r24856 | erikkay@chromium.org | 2009-08-29 18:45:27 +0200 (Sat, 29 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc

reenable overrides test
- The failure was happening because of my change to use api_test.js in the test.  Because of that, there were now two calls to chrome.test.pass(), and I was asserting that there had been only one.  This was only failing under Release, presumably because it wound up getting both pass events in the single event loop (a timing issue).

BUG=none
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Overrides

Review URL: http://codereview.chromium.org/181012
------------------------------------------------------------------------
r24854 | thakis@chromium.org | 2009-08-29 07:53:49 +0200 (Sat, 29 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Use Lucida Grande instead of Helvetica for "Show all downloads..." link in download shelf.

BUG=20343
TEST=Look at it.

Review URL: http://codereview.chromium.org/173621
------------------------------------------------------------------------
r24852 | estade@chromium.org | 2009-08-29 05:07:29 +0200 (Sat, 29 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.h
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/possible_url_model.h

Fix a crash where we were looking for the fav icon in the wrong service.

This caused the possible url dialog in the options menu to never load favicons, and instead DCHECK (crashing debug builds).
Review URL: http://codereview.chromium.org/179034
------------------------------------------------------------------------
r24846 | aa@chromium.org | 2009-08-29 03:29:23 +0200 (Sat, 29 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Enable extensions by default.

BUG=20573
TEST=Install sample extensions without modifying command line flags. They should install (and run on next startup).

Review URL: http://codereview.chromium.org/179032
------------------------------------------------------------------------
r24841 | aa@chromium.org | 2009-08-29 02:35:52 +0200 (Sat, 29 Aug 2009) | 22 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/test/data/extensions/api_test/storage/api_test.js
   A /trunk/src/chrome/test/data/extensions/api_test/storage/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/storage/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/storage/tab.html
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Force databases and localstorage to be enabled extensions.

We were already doing this, this change modifies the
mechanism. Before we were relying on the presence of the
--enable-extensions flag, but as we are getting ready to
remove that on dev, we needed something else.

This forces local storage and database to be enabled on
chrome-extension:// pages.

Also, change the way database enabling works in general to
be more like the way local storage works, just for
consistency. Will remove old, unnecessary WebKit API in an
upstream change.

erikkay: extensions stuff
dumi: database stuff
jorlow: local storage stuff

BUG=19511

Review URL: http://codereview.chromium.org/173306
------------------------------------------------------------------------
r24836 | phajdan.jr@chromium.org | 2009-08-29 01:39:44 +0200 (Sat, 29 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/browser/shell_integration_unittest.cc

Implement creating shortcuts in the applications menu.

TEST=none
http://crbug.com/17251

Review URL: http://codereview.chromium.org/179008
------------------------------------------------------------------------
r24831 | mdm@chromium.org | 2009-08-29 01:13:43 +0200 (Sat, 29 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Linux: get GNOME or KDE proxy settings.
BUG=17363, 20407
TEST=none

Review URL: http://codereview.chromium.org/174327
------------------------------------------------------------------------
r24830 | mirandac@chromium.org | 2009-08-29 01:07:27 +0200 (Sat, 29 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

If a preferences file references a theme which is from an old version, or whose images have failed to process correctly, drop back to the default theme.

BUG= http://crbug.com/20263
TEST= Use a preferences file from an older version of Chrome that has a theme installed, and open Chrome.  Observe that Chrome opens using the default theme.

Review URL: http://codereview.chromium.org/175013
------------------------------------------------------------------------
r24828 | erg@google.com | 2009-08-29 01:05:33 +0200 (Sat, 29 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/rounded_window.cc
   A /trunk/src/chrome/browser/gtk/rounded_window.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/chrome.gyp

GTK: Refactoring and rounds the "Search site for:" hint.

Factor out common window rounding code from two places where it was used,
generalize it, and use it to round the "Search site for:" hint in the location
bar. Theoretically, people should be able to use this anywhere they need a
window to have rounded corners.

http://crbug.com/18310

Review URL: http://codereview.chromium.org/179026
------------------------------------------------------------------------
r24827 | mattm@chromium.org | 2009-08-29 00:59:24 +0200 (Sat, 29 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   D /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   D /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   A /trunk/src/chrome/browser/tab_contents/repost_form_warning.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/test_browser_window.h

Revert "Gtk confirm form resubmission dialog." Broke linux views build.

This reverts commit e6ab23c81e56c6b9fbb062bbb090a648e6ebef12.

TBR=beng

Review URL: http://codereview.chromium.org/183006
------------------------------------------------------------------------
r24826 | mattm@chromium.org | 2009-08-29 00:47:11 +0200 (Sat, 29 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.cc
   A /trunk/src/chrome/browser/gtk/repost_form_warning_gtk.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   D /trunk/src/chrome/browser/tab_contents/repost_form_warning.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/test_browser_window.h

Gtk confirm form resubmission dialog.

Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog

BUG=19761
TEST=see bug

Review URL: http://codereview.chromium.org/174294
------------------------------------------------------------------------
r24823 | mirandac@chromium.org | 2009-08-29 00:40:53 +0200 (Sat, 29 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Make tips and their links readable in all themes.

BUG= http://crbug.com/20506
TEST= Install any theme.  Observe that tips are legible.

Review URL: http://codereview.chromium.org/182012
------------------------------------------------------------------------
r24822 | idanan@chromium.org | 2009-08-29 00:37:24 +0200 (Sat, 29 Aug 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h

Added notice for blocked items to the popup container

Left a TODO to rename the class to something more general but
it is preferable to do a rename separate from code changes, it
will make things easier to sync and be quicker since that change
is relatively trivial.

The exact look may be changed later but I'll attach screenshots
to this issue to show the initial implementation.

Also left as future enhancement is the possibility of limiting
the size of the notification list in cases where a lot of hosts
are affected. The most extreme example I found was some Gizmodo
page with 36 domains using cookies.

BUG=16932
TEST=none

Review URL: http://codereview.chromium.org/179013
------------------------------------------------------------------------
r24821 | brettw@chromium.org | 2009-08-29 00:35:40 +0200 (Sat, 29 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   M /trunk/src/views/controls/textfield/native_textfield_gtk.h
   M /trunk/src/views/widget/widget_gtk.cc

Make the views bookmark bubble work on GTK.

The combobox still isn't implemented, but this makes TextBox work, and also
does some changes around the info_bubble to make sure it get created properly.

TEST=none
BUG=none.
Review URL: http://codereview.chromium.org/177026
------------------------------------------------------------------------
r24819 | shess@chromium.org | 2009-08-29 00:29:56 +0200 (Sat, 29 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Handle shift-delete when omnibox popup is up.

When the user hits shift-delete (that's forward delete),
attempt to delete the item highlighted from the list.  This only seems
to work for history items.

http://crbug.com/20281
TEST=No idea.  I've managed to delete an item, but most items seem
immune to deletion, this code is calling the right place, but the
match itself checks !deletable.  Sometimes I have luck going to a
site, then typing part of the URL and using shift-del on it.

Review URL: http://codereview.chromium.org/176022
------------------------------------------------------------------------
r24816 | aa@chromium.org | 2009-08-29 00:24:51 +0200 (Sat, 29 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/common/extensions/docs/static/background_pages.html
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/test/data/extensions/samples/benchmark/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/getviews/common.js
   M /trunk/src/chrome/test/data/extensions/samples/password_maker/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/screenshot/screenshot.js
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html

Make a bunch of backlogged breaking changes to the extensions API in prep for dev:

* Enforce permissions on cross-origin XHR
* Enforce module-level permissions
* Decided not to completely remove chrome.self since it is so widely used, but removed all references to it from samples and docs.

BUG=16356,12129,12140
TEST=Sample extensions on http://dev.chromium.org/developers/design-documents/extensions/samples should still work

Review URL: http://codereview.chromium.org/179027
------------------------------------------------------------------------
r24813 | kuchhal@chromium.org | 2009-08-29 00:13:35 +0200 (Sat, 29 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Show Make this my homepage link on new tab page.

BUG=20254

Review URL: http://codereview.chromium.org/179012
------------------------------------------------------------------------
r24807 | dumi@chromium.org | 2009-08-28 23:58:28 +0200 (Fri, 28 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/platform_file.h
   M /trunk/src/base/platform_file_posix.cc
   M /trunk/src/base/platform_file_win.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/third_party/sqlite/README.chromium
   M /trunk/src/third_party/sqlite/src/os_unix.c
   M /trunk/src/webkit/api/public/WebKitClient.h
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h

Chromium side patch for DB support on Linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174232
------------------------------------------------------------------------
r24806 | arv@google.com | 2009-08-28 23:56:48 +0200 (Fri, 28 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   A /trunk/src/chrome/browser/favicon_service.cc
   A /trunk/src/chrome/browser/favicon_service.h
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/sync/glue/change_processor.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Adds a FaviconService class tied to the profile.

Original issue: http://codereview.chromium.org/115212/show

The favicons service is the entry point to getting favicons.

Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages
are never added to the history.

BUG=5840

TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in
this window. Then close the window and open the NTP. The recently closed
windows/tabs should show the favicons for the hsitroy and downloads page.

Review URL: http://codereview.chromium.org/178001
------------------------------------------------------------------------
r24800 | erikkay@chromium.org | 2009-08-28 23:38:30 +0200 (Fri, 28 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_override_apitest.cc

disable a failing test (ExtensionApiTest.Overrides)
TBR: tony
------------------------------------------------------------------------
r24796 | tony@chromium.org | 2009-08-28 23:03:17 +0200 (Fri, 28 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/app/animation.h
   M /trunk/src/app/table_model.h
   M /trunk/src/app/table_model_observer.h
   M /trunk/src/app/tree_model.h
   M /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/base/file_descriptor_shuffle.h
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/base/system_monitor.h
   M /trunk/src/base/task.h
   M /trunk/src/base/third_party/dmg_fp/README.chromium
   M /trunk/src/base/third_party/dmg_fp/dtoa.cc
   M /trunk/src/base/time.cc
   M /trunk/src/base/time.h
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/waitable_event.h
   M /trunk/src/base/waitable_event_watcher_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/view_id_util.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/login_model.h
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/parsers/metadata_parser.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_factory.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.h
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/page_navigator.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/gtk_tree.h
   M /trunk/src/chrome/common/property_bag_unittest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/common/worker_thread_ticker.h
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/browser/browser_test_runner.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/ipc/ipc_logging.h
   M /trunk/src/ipc/ipc_sync_channel.h
   M /trunk/src/ipc/ipc_sync_message.h
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/base/clock.h
   M /trunk/src/media/filters/ffmpeg_demuxer_unittest.cc
   M /trunk/src/media/filters/null_audio_renderer.cc
   M /trunk/src/media/filters/video_renderer_base.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/ssl_client_auth_cache_unittest.cc
   M /trunk/src/net/ftp/ftp_auth_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/tools/fetch/http_listen_socket.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/menu/simple_menu_model.h
   M /trunk/src/views/view.h
   M /trunk/src/webkit/api/public/linux/WebSandboxSupport.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc.h
   M /trunk/src/webkit/glue/webcursor_unittest.cc

Revert "Fix a ton of compiler warnings."

This reverts commit r24792.

TBR=estade

Review URL: http://codereview.chromium.org/179028

------------------------------------------------------------------------
r24793 | shess@chromium.org | 2009-08-28 22:42:57 +0200 (Fri, 28 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

[Mac] Handle middle click in autocomplete popup.

Middle click should open the item clicked in a background tab.

http://crbug.com/20282
TEST=Start typing in omnibox.  Middle click an item.  The item should
open in a different tab without affecting the current omnibox state.

Review URL: http://codereview.chromium.org/179009
------------------------------------------------------------------------
r24792 | estade@chromium.org | 2009-08-28 22:41:10 +0200 (Fri, 28 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/app/animation.h
   M /trunk/src/app/table_model.h
   M /trunk/src/app/table_model_observer.h
   M /trunk/src/app/tree_model.h
   M /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/base/file_descriptor_shuffle.h
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/base/system_monitor.h
   M /trunk/src/base/task.h
   M /trunk/src/base/third_party/dmg_fp/README.chromium
   M /trunk/src/base/third_party/dmg_fp/dtoa.cc
   M /trunk/src/base/time.cc
   M /trunk/src/base/time.h
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/waitable_event.h
   M /trunk/src/base/waitable_event_watcher_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/view_id_util.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/login_model.h
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/parsers/metadata_parser.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_factory.h
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.cc
   M /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.h
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/page_navigator.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/gtk_tree.h
   M /trunk/src/chrome/common/property_bag_unittest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/common/worker_thread_ticker.h
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/browser/browser_test_runner.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/ipc/ipc_logging.h
   M /trunk/src/ipc/ipc_sync_channel.h
   M /trunk/src/ipc/ipc_sync_message.h
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/base/clock.h
   M /trunk/src/media/filters/ffmpeg_demuxer_unittest.cc
   M /trunk/src/media/filters/null_audio_renderer.cc
   M /trunk/src/media/filters/video_renderer_base.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/ssl_client_auth_cache_unittest.cc
   M /trunk/src/net/ftp/ftp_auth_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/tools/fetch/http_listen_socket.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/controls/menu/simple_menu_model.h
   M /trunk/src/views/view.h
   M /trunk/src/webkit/api/public/linux/WebSandboxSupport.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc.h
   M /trunk/src/webkit/glue/webcursor_unittest.cc

Fix a ton of compiler warnings.

Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.

BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest

patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show

------------------------------------------------------------------------
r24791 | erikkay@chromium.org | 2009-08-28 22:26:05 +0200 (Fri, 28 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/browser_url_handler.h
   M /trunk/src/chrome/browser/extensions/extension_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   A /trunk/src/chrome/browser/extensions/extension_override_apitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/api_test/override1
   A /trunk/src/chrome/test/data/extensions/api_test/override1/api_test.js
   A /trunk/src/chrome/test/data/extensions/api_test/override1/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/override1/downloads.html
   A /trunk/src/chrome/test/data/extensions/api_test/override1/history.html
   A /trunk/src/chrome/test/data/extensions/api_test/override1/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/override1/newtab.html
   A /trunk/src/chrome/test/data/extensions/api_test/override1/nonexistant.html
   A /trunk/src/chrome/test/data/extensions/api_test/override1/test.js

override chrome:// URLs via extensions.
Overrides are declared in an extension's manifest.  The last one installed
wins.  However, we keep a list of those installed per page so that priority
is preserved and so that uninstall will revert to a previous state.

Review URL: http://codereview.chromium.org/174277
------------------------------------------------------------------------
r24778 | tony@chromium.org | 2009-08-28 21:49:45 +0200 (Fri, 28 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Disable the custom frame on app mode windows.  This includes the
dev tools window.

It makes app mode windows feel a lot more native.

BUG=16474

Review URL: http://codereview.chromium.org/183002

------------------------------------------------------------------------
r24775 | aa@chromium.org | 2009-08-28 21:39:44 +0200 (Fri, 28 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

Don't show extension disabled infobar when manually updating
extensions that increase privilges.

BUG=20461

Review URL: http://codereview.chromium.org/174637
------------------------------------------------------------------------
r24770 | rafaelw@chromium.org | 2009-08-28 21:07:21 +0200 (Fri, 28 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/api_other.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageActions.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/browsertest/last_error/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/mole
   A /trunk/src/chrome/test/data/extensions/samples/mole/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/mole/mole.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html

Extension API Renaming/Consistency changes

BUG=20288

Review URL: http://codereview.chromium.org/180016
------------------------------------------------------------------------
r24767 | shess@chromium.org | 2009-08-28 21:01:34 +0200 (Fri, 28 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Handle backspacing out of keyword search.

When the user hits backspace with the caret on the LHS in a keyword
search, should exit keyword search.

[Apple keyboards may label what I'm calling "backspace" as "delete".
The wide key above |\ key.]

http://crbug.com/20286
TEST=Type www.google.com, then tab to enter keyword search.  Type some
text.  Select-all and hit backspace, should stay in keyword mode.
Type some text, backspace should work as normal.  Type some text,
position caret at LHS, backspace should take you out of keyword mode.

Review URL: http://codereview.chromium.org/180009
------------------------------------------------------------------------
r24766 | rafaelw@chromium.org | 2009-08-28 21:00:00 +0200 (Fri, 28 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable ExtensionBrowsertest.MessagingContentScripts on linux

TBR=tc

Review URL: http://codereview.chromium.org/175011

------------------------------------------------------------------------
r24765 | jhawkins@chromium.org | 2009-08-28 20:59:51 +0200 (Fri, 28 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

gtk: Clip the tab title to the content height and not the font height.  The font height is a design measure and should not be used for a bounding box.

BUG=20401
TEST=Open google.com in a tab.  Tab title should be fully visible and not clipped.
Review URL: http://codereview.chromium.org/179022
------------------------------------------------------------------------
r24754 | aa@chromium.org | 2009-08-28 20:33:34 +0200 (Fri, 28 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   A /trunk/src/chrome/browser/resources/default_extension_icon_128.png
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc

Adds a default icon to the install dialog if the extension
doesn't specify one.

This icon came from Crystal Clear [1] and is licensed under
LGPL.

[1] http://commons.wikimedia.org/wiki/Crystal_Clear

BUG=20510

Review URL: http://codereview.chromium.org/173604
------------------------------------------------------------------------
r24752 | thomasvl@chromium.org | 2009-08-28 20:17:15 +0200 (Fri, 28 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm

Make the default ok/cancel button come from the pak files.

BUG=20496
TEST=more alerts should get localized strings.
Review URL: http://codereview.chromium.org/181006
------------------------------------------------------------------------
r24751 | arv@google.com | 2009-08-28 20:01:19 +0200 (Fri, 28 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Remove JSTemplate from NTP

This should reduce the time to show the NTP with about 5ms :-)

Fix a bug with tips causing an exception when there are no tips.

BUG=None

TEST=None

Review URL: http://codereview.chromium.org/178015
------------------------------------------------------------------------
r24750 | agl@chromium.org | 2009-08-28 19:59:50 +0200 (Fri, 28 Aug 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/resources/about_memory_linux.html (from /trunk/src/chrome/browser/resources/about_memory.html:24628)

Duplicate about_memory.html to create a Linux version.

This is in preparation for adding about:memory support for Linux, but
the change is otherwise too large to be considered the same file
without this trick.

------------------------------------------------------------------------
r24744 | jhawkins@chromium.org | 2009-08-28 19:38:04 +0200 (Fri, 28 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

gtk: Remove unnecessary gtk_widget_queue_draws from the tabstrip code.

BUG=15872
TEST=none
Review URL: http://codereview.chromium.org/182007
------------------------------------------------------------------------
r24741 | shess@chromium.org | 2009-08-28 19:35:24 +0200 (Fri, 28 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Don't eat tab if tab-to-search hint not visible.

http://crbug.com/20284
TEST=Type "test text".  You should see "Type to search" hint.  TAB
should take you into the content view.  Unfortunately, there are other
unrelated bugs around the tab sequencing, so this only works with NTP
on a new window.  Hit TAB twice and you should start tabbing between
thumbnails.

Review URL: http://codereview.chromium.org/180010
------------------------------------------------------------------------
r24739 | shess@chromium.org | 2009-08-28 19:26:30 +0200 (Fri, 28 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

[Mac] Tweaks to Omnibox metrics.

Pull in the popup corners by half a pixel to more closely match the
rounding on the buttons.  Pull up the gap between the popup and the
field by one pixel to match Windows.

http://crbug.com/20446

Review URL: http://codereview.chromium.org/178007
------------------------------------------------------------------------
r24737 | thomasvl@chromium.org | 2009-08-28 18:40:39 +0200 (Fri, 28 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/About.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller.h
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/background_tile_view.h
   A /trunk/src/chrome/browser/cocoa/background_tile_view.mm
   A /trunk/src/chrome/browser/cocoa/background_tile_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/restart_browser.h
   A /trunk/src/chrome/browser/cocoa/restart_browser.mm
   M /trunk/src/chrome/chrome.gyp

Add background_tile_view for tiling an image as UI background (about box needed it)
Added restart_browser as a helper like Views helper for putting up a request for the user to restart.
Added a new string needed for Mac style alerts to go with the existing restart string.
Make Mac Chromium use a custom about box.
Give Chromium and Google Chrome an about box that matches the one on other platforms
Use all the existing UI strings for the about box so we get credits, copy rights, etc.

TEST=New aboutbox for Chromium and Google Chrome.  About box should be fully l10n and size as needed.  Chrome update messaging should more match windows and be localized.
BUG=13219,19020

Review URL: http://codereview.chromium.org/173606
------------------------------------------------------------------------
r24736 | kuchhal@chromium.org | 2009-08-28 18:11:44 +0200 (Fri, 28 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/google_url_tracker.h

Change default homepage experience.

We want to make google.com homepage by default and also show the home button (see the bug below).

BUG=http://crbug.com/19392
TEST=Delete user profile and launch Chrome - homepage should be set to google.com and should be enabled. also home button should show up.

Review URL: http://codereview.chromium.org/174030
------------------------------------------------------------------------
r24720 | rafaelw@chromium.org | 2009-08-28 06:09:56 +0200 (Fri, 28 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_apitest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Enable a bunch of extension browsertests for linux

Review URL: http://codereview.chromium.org/173545

------------------------------------------------------------------------
r24719 | suzhe@chromium.org | 2009-08-28 05:48:01 +0200 (Fri, 28 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc

Fix issue 20297: Typing backspace while in a form field causes the browser to go back in its history

With the changes made in CL http://codereview.chromium.org/173344, gtk_window_activate_key() is used to handle a key event that was not handled by webkit. Unlike the old code, gtk_window_activate_key() may match the key event with predefined accelerators according to its hardware_keycode rather than keyval. Thus, we need to set hardare_keycode to an invalid value in GtkIMContextWrapper if the key event is handled by IME, to prevent BrowserWindowGtk from handling it again.

BUG=20297: Typing backspace while in a form field causes the browser to go back in its history
TEST=Starts scim's XIM server by running "scim -d", then runs chrome with GTK_IM_MODULE=xim. Open www.google.com and press backspace in the search box, the browser shall not go back to previous page.

Review URL: http://codereview.chromium.org/179016
------------------------------------------------------------------------
r24709 | mirandac@chromium.org | 2009-08-28 02:50:00 +0200 (Fri, 28 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Fix theme caching on Vista 64 when default theme is installed from the theme gallery.

BUG= http://crbug.com/20344
TEST= On vista 64 , install a non-default theme.  Open theme gallery and choose "Classic" theme.  Close browser and restart.  Theme should be default aero theme on Vista, and not the opaque blue windows theme.

Review URL: http://codereview.chromium.org/174562
------------------------------------------------------------------------
r24708 | avi@chromium.org | 2009-08-28 02:46:49 +0200 (Fri, 28 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/back_Template.pdf
   M /trunk/src/chrome/app/theme/close_bar_h.pdf
   M /trunk/src/chrome/app/theme/close_bar_p.pdf
   M /trunk/src/chrome/app/theme/forward_Template.pdf
   M /trunk/src/chrome/app/theme/go_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/reload_Template.pdf
   M /trunk/src/chrome/app/theme/star_Template.pdf
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Reverting 24700.
Review URL: http://codereview.chromium.org/181002
------------------------------------------------------------------------
r24705 | suzhe@chromium.org | 2009-08-28 02:31:28 +0200 (Fri, 28 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Fix control key and paste behavior in Linux omnibox.

BUG=12316: Linux Omnibox, autocomplete on paste annoying.
BUG=13096: Support desired_tld in Linux omnibox
BUG=20166: Linux omnibox control key behavior is incorrect
TEST=Select all text in omnibox and paste something into omnibox by either ctrl-v, paste item in context menu or middle click, to see if inline autocomplete is not activated.
TEST=Input something in omnibox, eg. "goog", make sure the inline autocomplete is activated, then press ctrl key to see if the inline autocomplete is still there.
TEST=Input something in omnibox, eg. "cnn", press ctrl-Enter to see if www.cnn.com is opened.

Review URL: http://codereview.chromium.org/173462
------------------------------------------------------------------------
r24704 | pkasting@chromium.org | 2009-08-28 02:17:44 +0200 (Fri, 28 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/history/history_types.h

Do at least some rudimentary sorting of bookmarked URLs in the omnibox dropdown (existing sort was effectively random).  Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/165455 ), r=sky,me, tweaked.

BUG=16230
TEST=In the omnibox dropdown, bookmarked URLs that have been typed more often should be ranked above those that have been typed less often.
------------------------------------------------------------------------
r24703 | phajdan.jr@chromium.org | 2009-08-28 02:07:22 +0200 (Fri, 28 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Wait correctly for all navigations that will happen in ErrorPageTest.

Will it kill flakiness? I'm undisabling some tests on Linux to find out.

TEST=none
http://crbug.com/19361

Review URL: http://codereview.chromium.org/175006
------------------------------------------------------------------------
r24702 | phajdan.jr@chromium.org | 2009-08-28 02:02:08 +0200 (Fri, 28 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/browser/automation/automation_provider_observers.cc
   A /trunk/src/chrome/browser/automation/automation_provider_observers.h
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Move observers out of automation_provider.cc to declutter the file.

Also make sure they all use DISALLOW_COPY_AND_ASSIGN.

TEST=none
http://crbug.com/19874

Review URL: http://codereview.chromium.org/176004
------------------------------------------------------------------------
r24700 | avi@chromium.org | 2009-08-28 01:51:17 +0200 (Fri, 28 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/back_Template.pdf
   M /trunk/src/chrome/app/theme/close_bar_h.pdf
   M /trunk/src/chrome/app/theme/close_bar_p.pdf
   M /trunk/src/chrome/app/theme/forward_Template.pdf
   M /trunk/src/chrome/app/theme/go_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/reload_Template.pdf
   M /trunk/src/chrome/app/theme/star_Template.pdf
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Updates to clean up default theme and add hover states.

Patch by Cole.

BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438
TEST=none

Review URL: http://codereview.chromium.org/165499

------------------------------------------------------------------------
r24698 | erg@google.com | 2009-08-28 01:39:13 +0200 (Fri, 28 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK Themes: Refresh the entire location bar area on Update().

http://crbug.com/20027

Review URL: http://codereview.chromium.org/182004
------------------------------------------------------------------------
r24692 | mattm@chromium.org | 2009-08-28 01:10:43 +0200 (Fri, 28 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   A /trunk/src/chrome/browser/gtk/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_linux.txt

Add unittest for Gtk search engine manager dialog.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/180012
------------------------------------------------------------------------
r24686 | jshin@chromium.org | 2009-08-28 00:56:39 +0200 (Fri, 28 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc

With an upcoming ICU 4.2 upgrade, the way 'search' works has changed and FiP doesn't make a hit for 
a stand-alone dependent vowel sign of Indic scripts, which is OK according to a native Malayalam speaker.

Revise FindInPageControllerTest.FindCrash_Issue1341577 to run FindInPage (U+0D4C) without checking the return value because the test was devised to test the 'crash' issue.

BUG=8198
TEST=FindInPageControllerTest.FindCrash_Issue1341577 pass before and after ICU upgrade to 4.2




Review URL: http://codereview.chromium.org/174629
------------------------------------------------------------------------
r24685 | estade@chromium.org | 2009-08-28 00:56:36 +0200 (Fri, 28 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Ellipsize long entries in bookmark menus and the back/forward menus.

Also ellipsize long tooltips.

Also make the bookmark bar tooltips more like window (Title on one line, then url on the next line). I've made the title bold, although that isn't the case on windows.

Menus: Prefer popping downwards rather than upwards when there is more space down than up.

BUG=18617
BUG=20120

Review URL: http://codereview.chromium.org/175004
------------------------------------------------------------------------
r24683 | thakis@chromium.org | 2009-08-28 00:52:41 +0200 (Fri, 28 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Fix download shelf item overflow on os x.

This was regressed by the subview layout refactoring.

BUG=14672
TEST=download several items, resize window, make sure that no download item ever overlaps the "Show all downloads" link on the right.

Review URL: http://codereview.chromium.org/173048
------------------------------------------------------------------------
r24675 | tony@chromium.org | 2009-08-28 00:20:17 +0200 (Fri, 28 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add a fast path for tab strip expose.

This optimizes the common case of just needing to update
favicons.  If the expose area consists of just favicons,
only paint the favicons (i.e., don't bother with the complex
tab edges that overlap).

This doesn't help when tabs are resizing or moving, but does
reduce CPU usage quite a bit.

BUG=15872

Review URL: http://codereview.chromium.org/179003

------------------------------------------------------------------------
r24668 | mirandac@chromium.org | 2009-08-27 23:38:44 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fixes typo in new_new_tab.js that turned off tips.

BUG= none
TEST= none
Review URL: http://codereview.chromium.org/178005
------------------------------------------------------------------------
r24667 | evan@chromium.org | 2009-08-27 23:36:48 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_plugins.html

Make the about:plugins page use a normal-sized font.

This has been bugging me.

Review URL: http://codereview.chromium.org/174620
------------------------------------------------------------------------
r24663 | thakis@chromium.org | 2009-08-27 23:13:42 +0200 (Thu, 27 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h

Remove completed downloads from shelf when the shelf closes.

BUG=15712
TEST=Download a few things, close shelf, download something else, note initial few things are no longer on the shelf.

Special cases:

* Dangerous downloads still awaiting affirmation should never be removed, no matter if they are completed or not.

* Cancelled downloads should be removed.

* In-progress downloads should not be removed.

Review URL: http://codereview.chromium.org/173186
------------------------------------------------------------------------
r24662 | klink@chromium.org | 2009-08-27 23:04:35 +0200 (Thu, 27 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/webkit/glue/glue_accessibility_object.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Adds support for WAI-ARIA role option, by adding exposure of MSAA role ROLE_SYSTEM_LISTITEM.

BUG=19982
TEST=Assign @role option on a child element to either menu or listbox. It will be exposed as either menuitem or listitem, respectively. 

Review URL: http://codereview.chromium.org/173488
------------------------------------------------------------------------
r24654 | finnur@chromium.org | 2009-08-27 22:43:17 +0200 (Thu, 27 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix 20398: PageAction icon disappears on reader.google.com when url includes reference

We now strip away the reference when comparing the url's (for the purpose of clearing the page action icons).

BUG=20398
TEST=None

Review URL: http://codereview.chromium.org/174613
------------------------------------------------------------------------
r24650 | estade@chromium.org | 2009-08-27 21:52:05 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc

Send release events as well as press events in linux event mocking infrastructure.

Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach.

Review URL: http://codereview.chromium.org/178002
------------------------------------------------------------------------
r24643 | erg@google.com | 2009-08-27 21:31:55 +0200 (Thu, 27 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

Add call to BrowserThemeProvider::GenerateBitmap removed in r24170.

(Linux relies on the lazy generation provided by GenerateBitmap; having
to call GenerateTabImages() regressed linux startup; theoretically it'd be
nice if everything was done lazily...)

Review URL: http://codereview.chromium.org/180004
------------------------------------------------------------------------
r24642 | sky@chromium.org | 2009-08-27 21:29:47 +0200 (Thu, 27 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/chromeos/settings_page_view.cc
   A /trunk/src/chrome/browser/chromeos/settings_page_view.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/chrome.gyp

Adds the settings tab to options on chrome os. The contents is just a place
holder at this point.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174596
------------------------------------------------------------------------
r24635 | ben@chromium.org | 2009-08-27 20:46:46 +0200 (Thu, 27 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.h
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm

Fix a couple of bugs in the "custom home pages" list in the Preferences window.

1. It was possible to add empty rows to the list by repeatedly clicking the + button.
2. There was a crash when editing an existing item, clearing the text and pressing enter. CustomHomePagesEntry::setURL didn't handle a nil NSString passed to it in this condition.

I added a controlTextDidEndEditing method to PreferencesWindowController that forces a revalidation of the contents of the model backing the TableView.

http://crbug.com/19555
TEST=Click the + button below the custom home pages table view in the Basics page of Preferences. You should get an active edit but not add the item if you don't type anything. Also, try adding a few valid URLs, then click one to edit and delete the URL, then press enter. It should be removed from the table. See also attached unit test.
Review URL: http://codereview.chromium.org/174173
------------------------------------------------------------------------
r24630 | jhawkins@chromium.org | 2009-08-27 20:11:42 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

gtk: Subtract the tabstrip x offset from the last tab x offset when calculating the available tab width.  The tabstrip and its tabs are not necessarily based at (0,0).

BUG=20329
TEST=Open many tabs until they resize smaller.  Repeatedly close the left-most tab with the close button.  The tabs should not resize at all until the mouse leaves the tabstrip.
Review URL: http://codereview.chromium.org/173559
------------------------------------------------------------------------
r24623 | pfeldman@chromium.org | 2009-08-27 19:47:18 +0200 (Thu, 27 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   M /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   M /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/webkit/glue/devtools/debugger_agent.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/devtools_mock_rpc.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc.cc
   M /trunk/src/webkit/glue/devtools/devtools_rpc.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc_js.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_delegate.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsclient.h
   M /trunk/src/webkit/glue/webdevtoolsclient_delegate.h
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.h
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/webkit.gyp

DevTools: Remove base/values dependency from devtools.

Review URL: http://codereview.chromium.org/173480
------------------------------------------------------------------------
r24608 | phajdan.jr@chromium.org | 2009-08-27 18:42:20 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   D /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.cc
   D /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/data/mock-link-doctor.html
   D /trunk/src/chrome/test/data/mock-link-doctor.html.mock-http-headers
   M /trunk/src/chrome/test/in_process_browser_test.cc

Revert r24606-24607. The tree didn't like them. :(

TBR=darin

Review URL: http://codereview.chromium.org/173574
------------------------------------------------------------------------
r24607 | phajdan.jr@chromium.org | 2009-08-27 17:46:40 +0200 (Thu, 27 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Wait correctly for navigations in ErrorPage UI test.

TBR=darin

TEST=none
http://crbug.com/19361

Review URL: http://codereview.chromium.org/173571
------------------------------------------------------------------------
r24606 | phajdan.jr@chromium.org | 2009-08-27 17:20:52 +0200 (Thu, 27 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   A /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.cc
   A /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/mock-link-doctor.html
   A /trunk/src/chrome/test/data/mock-link-doctor.html.mock-http-headers
   M /trunk/src/chrome/test/in_process_browser_test.cc

Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.

Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward.

TEST=Covered by ui_tests and browser_tests.
http://crbug.com/18365, http://crbug.com/19361

Review URL: http://codereview.chromium.org/174179
------------------------------------------------------------------------
r24605 | phajdan.jr@chromium.org | 2009-08-27 17:06:03 +0200 (Thu, 27 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Draw background of Linux extension toolstrips.

This makes Linux extension shelf quite pretty now IMHO.

TEST=Just see it.
http://crbug.com/16759

Review URL: http://codereview.chromium.org/174585
------------------------------------------------------------------------
r24599 | aa@chromium.org | 2009-08-27 08:47:46 +0200 (Thu, 27 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/allhosts1_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/allhosts1_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/allhosts2_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/allhosts2_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/allhosts3_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/allhosts3_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts1_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts1_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts2_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts2_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts3_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts3_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts4_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/hosts4_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions1_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions1_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions2_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions2_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions3_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions3_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions4_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/permissions4_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/plugin1_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/plugin1_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/plugin2_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/plugin2_old.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/plugin3_new.json
   A /trunk/src/chrome/test/data/extensions/allow_silent_upgrade/plugin3_old.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/all_hosts.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/all_hosts2.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/all_hosts3.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/duplicate_content_script.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/duplicate_host.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/empty.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/https_not_considered.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/one_host.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/one_host_wildcard.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/two_content_scripts.json
   A /trunk/src/chrome/test/data/extensions/effective_host_permissions/two_hosts.json

Update of the extension install UI:

- Give the user more information about which hosts an
  extension can access.
- Remove the red severe warning because it doesn't play well
  with themes and because it adds nothing when the other
  text is more specific.
- Make the image a bit smaller.

Also integrate this new idea with the silent/not-silent update flow.

BUG=12129,12140,19582

Review URL: http://codereview.chromium.org/173463
------------------------------------------------------------------------
r24586 | rohitrao@chromium.org | 2009-08-27 05:57:04 +0200 (Thu, 27 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

[Mac] The autocomplete popup now gets its position from the toolbar controller,
rather than simply growing its width by 2*height.

BUG=None
TEST=The autocomplete popup should continue to appear in the same location.
Review URL: http://codereview.chromium.org/173439
------------------------------------------------------------------------
r24583 | estade@chromium.org | 2009-08-27 04:15:09 +0200 (Thu, 27 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

Don't flip out in debug mode when launching the bookmark manager and the model isn't yet loaded.

Review URL: http://codereview.chromium.org/174593
------------------------------------------------------------------------
r24581 | estade@chromium.org | 2009-08-27 03:32:41 +0200 (Thu, 27 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_browsertest.cc

assure model is loaded *before* showing the bookmark manager

Review URL: http://codereview.chromium.org/173554
------------------------------------------------------------------------
r24578 | estade@chromium.org | 2009-08-27 03:10:44 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix linux views build.

TBR=rvargas

Review URL: http://codereview.chromium.org/174589
------------------------------------------------------------------------
r24576 | estade@chromium.org | 2009-08-27 02:58:46 +0200 (Thu, 27 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/process_singleton_dialog.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Set the default icon list so we don't have to set it on every window all the time.

Review URL: http://codereview.chromium.org/174586
------------------------------------------------------------------------
r24575 | estade@chromium.org | 2009-08-27 02:57:35 +0200 (Thu, 27 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Enable welcome page for non-windows platforms.

Later we may wish to customize the welcome page per platform (particularly for chrome os) but for now it looks helpful enough to be worth showing on the first run.

BUG=20327

Review URL: http://codereview.chromium.org/174551
------------------------------------------------------------------------
r24574 | jorlow@chromium.org | 2009-08-27 02:55:02 +0200 (Thu, 27 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/nullable_string16.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/api/public/WebString.h

Add a nullable string16 class to base.  It combines a string16 + a null param
in order to cover all the possible states of a WebKit string.  For strings
where the null state is not meaninfully different from the empty state, this
class should NOT be used.  There are, however, some cases where we do need to
track null.  LocalStorage is an example.  This class should be a fairly light
weight way to do so.  This change also adds implicit conversion to and from
WebStrings.

This also switches LocalStorage's IPCs over to using this new class.

BUG=17343
TEST=none

Review URL: http://codereview.chromium.org/174484
------------------------------------------------------------------------
r24564 | kuchhal@chromium.org | 2009-08-27 01:53:00 +0200 (Thu, 27 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/test/data/purify/unit_tests.exe.gtest.txt

Fix memory leaks in Firefox impoter unittest.

BUG=19820
TBR=erikkay

Review URL: http://codereview.chromium.org/173546
------------------------------------------------------------------------
r24560 | jhawkins@chromium.org | 2009-08-27 01:40:03 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

gtk: Fix the bounds of the clip region for tab title text.

BUG=19741
TEST=Open many tabs.  The ellipses should not be rendered if the tab is not large enough.
Review URL: http://codereview.chromium.org/174582
------------------------------------------------------------------------
r24558 | erg@google.com | 2009-08-27 01:18:54 +0200 (Thu, 27 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK Themes: Fix the find bar so the match count is inside the entry.

In addition, only draw the dirty rectangle area when manually drawing a gtk entry.

http://crbug.com/17962

Review URL: http://codereview.chromium.org/174577
------------------------------------------------------------------------
r24557 | estade@chromium.org | 2009-08-27 01:13:40 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Make sure the bookmark model is loaded before running bookmark manager tests. Fixes flaky browser test failures on the build bots.

Also restructure the test to make adding future tests easier.

Review URL: http://codereview.chromium.org/173527
------------------------------------------------------------------------
r24553 | pam@chromium.org | 2009-08-27 01:08:38 +0200 (Thu, 27 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Make extension install UI text on Mac match Windows version. Still to come if
possible: coloring the "severe" warning red, applying a style to the rest of
the text, and changing the default warning icon to the extension's
install_icon.

Remove dead function declaration, no longer used.

BUG=19654
TEST=install an extension on Mac, observe dialog
Review URL: http://codereview.chromium.org/174498
------------------------------------------------------------------------
r24547 | estade@chromium.org | 2009-08-27 00:32:04 +0200 (Thu, 27 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

AutomationProvider: Implement GetBrowserForWindow() on mac and linux views.

Review URL: http://codereview.chromium.org/174505
------------------------------------------------------------------------
r24546 | estade@chromium.org | 2009-08-27 00:31:24 +0200 (Thu, 27 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

GTK: Don't reposition the findbar when it's not visible.

This gives us ~8ms of startup improvement that we lost previously from r22012.

Review URL: http://codereview.chromium.org/173510
------------------------------------------------------------------------
r24541 | erg@google.com | 2009-08-27 00:17:00 +0200 (Thu, 27 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

Fix startup regression in gtk theme mode.

Don't populate the image dictionary in gtk mode, in addition to not writing the
images to disk.

Review URL: http://codereview.chromium.org/173525
------------------------------------------------------------------------
r24540 | rafaelw@chromium.org | 2009-08-26 23:58:22 +0200 (Wed, 26 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   A /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Reland "Linux Extensions Install Prompt""

This relands http://codereview.chromium.org/174462 which was reverted.

It now only includes the new panel for TOOLKIT_GTK (was OS_LINUX).

TBR=sgk

Review URL: http://codereview.chromium.org/173522

------------------------------------------------------------------------
r24539 | phajdan.jr@chromium.org | 2009-08-26 23:55:34 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h

Polish the look of Linux extension shelf.

TEST=none
http://crbug.com/16759

Review URL: http://codereview.chromium.org/174564
------------------------------------------------------------------------
r24537 | jeremy@chromium.org | 2009-08-26 23:43:42 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix SharedMemory Object leak

Detected via Valgrind.

BUG=16209
TEST=None

Review URL: http://codereview.chromium.org/174560
------------------------------------------------------------------------
r24536 | jorlow@chromium.org | 2009-08-26 23:38:03 +0200 (Wed, 26 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/webmessageportchannel_impl.cc
   M /trunk/src/chrome/common/webmessageportchannel_impl.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/worker/nativewebworker_impl.cc
   M /trunk/src/chrome/worker/nativewebworker_impl.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/webkit/api/public/WebMessagePortChannel.h
   M /trunk/src/webkit/api/public/WebVector.h
   M /trunk/src/webkit/api/public/WebWorker.h
   M /trunk/src/webkit/api/public/WebWorkerClient.h
   M /trunk/src/webkit/api/src/PlatformMessagePortChannel.cpp
   M /trunk/src/webkit/glue/webworker_impl.cc
   M /trunk/src/webkit/glue/webworker_impl.h
   M /trunk/src/webkit/glue/webworkerclient_impl.cc
   M /trunk/src/webkit/glue/webworkerclient_impl.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_webworker.cc
   M /trunk/src/webkit/tools/test_shell/test_worker/test_webworker.h

First half of updating Worker.postMessage(), DOMWindow.postMessage(), and
MessagePort.postMessage() to accept multiple MessagePorts.

Original review: http://codereview.chromium.org/173193

TBR=atwilson

TEST=None (new functionality not yet exposed via bindings, so existing tests suffice)
BUG=19948

Review URL: http://codereview.chromium.org/174566
------------------------------------------------------------------------
r24530 | phajdan.jr@chromium.org | 2009-08-26 23:21:43 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h

Fix crash in Linux extension shelf.

We need to delay creating render view until we're fully constructed.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/173506
------------------------------------------------------------------------
r24529 | kuchhal@chromium.org | 2009-08-26 23:20:22 +0200 (Wed, 26 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Re-enable importer unit tests one more time to debug on buildbot.

BUG=19820

Review URL: http://codereview.chromium.org/174561
------------------------------------------------------------------------
r24527 | avi@chromium.org | 2009-08-26 22:58:42 +0200 (Wed, 26 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/back_Template.pdf
   M /trunk/src/chrome/app/theme/close_bar_h.pdf
   M /trunk/src/chrome/app/theme/close_bar_p.pdf
   M /trunk/src/chrome/app/theme/forward_Template.pdf
   M /trunk/src/chrome/app/theme/go_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/reload_Template.pdf
   M /trunk/src/chrome/app/theme/star_Template.pdf
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Reverting 24512.
Review URL: http://codereview.chromium.org/174558
------------------------------------------------------------------------
r24526 | sky@chromium.org | 2009-08-26 22:51:02 +0200 (Wed, 26 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/menu_arrow.png (from /trunk/src/app/resources/menu_arrow.png:24508)
   A /trunk/src/app/resources/menu_check.png (from /trunk/src/app/resources/menu_check.png:24508)
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/menu/menu_config_gtk.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_host_gtk.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/window_gtk.cc

Attempt 2 at landing bookmark menus.

The build breakage was the result of a bad ifdef in MenuController,
specifically around the OnKeyDown method.

BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/173517
------------------------------------------------------------------------
r24520 | jhawkins@chromium.org | 2009-08-26 22:41:36 +0200 (Wed, 26 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

gtk: button-press events return coordinates relative to the gdk window in which the button was pressed.  Convert this point to a browser window-relative coordinate when handling resizing the custom frame.

BUG=18308
TEST=Click the last pixel of the tabstrip and drag the mouse.  You should not be able to resize the browser window.
Review URL: http://codereview.chromium.org/173319
------------------------------------------------------------------------
r24519 | mdm@chromium.org | 2009-08-26 22:39:27 +0200 (Wed, 26 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

Store the proxy's hostname rather than the first site visited via the proxy when storing proxy passwords.
BUG=12992
TEST=none

Review URL: http://codereview.chromium.org/173438
------------------------------------------------------------------------
r24518 | tony@chromium.org | 2009-08-26 22:38:04 +0200 (Wed, 26 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Make the tab strip expose events more targeted on linux.

Rather than queueing the whole tab strip, only queue the area
that changed when updating the throbber.

This doesn't do much now since the tab strip expose always repaints everything, but this sets us up to optimize the expose handler.

Review URL: http://codereview.chromium.org/173391

------------------------------------------------------------------------
r24513 | tony@chromium.org | 2009-08-26 22:22:37 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Set the window icon to the favicon when in app mode.

BUG=19734
TEST=Run chrome --app=http://www.google.com/ .  The task bar should
     show the google favicon.

Review URL: http://codereview.chromium.org/174542

------------------------------------------------------------------------
r24512 | avi@chromium.org | 2009-08-26 22:20:51 +0200 (Wed, 26 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/app/theme/back_Template.pdf
   M /trunk/src/chrome/app/theme/close_bar_h.pdf
   M /trunk/src/chrome/app/theme/close_bar_p.pdf
   M /trunk/src/chrome/app/theme/forward_Template.pdf
   M /trunk/src/chrome/app/theme/go_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   M /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/reload_Template.pdf
   M /trunk/src/chrome/app/theme/star_Template.pdf
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Updates to clean up default theme and add hover states.

Path by Cole.

BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438
TEST=none

Review URL: http://codereview.chromium.org/165499

------------------------------------------------------------------------
r24509 | sky@chromium.org | 2009-08-26 22:12:59 +0200 (Wed, 26 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/menu_arrow.png
   D /trunk/src/app/resources/menu_check.png
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/menu/menu_config_gtk.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_host_gtk.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/window_gtk.cc

Reverts menu patch.

BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/173508
------------------------------------------------------------------------
r24507 | estade@chromium.org | 2009-08-26 22:08:26 +0200 (Wed, 26 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Fix DCHECK on download item removal, take 2.

We can't delay destroying the download item view because it has to be destoyed before the download model is destroyed. Insted we delay the execution of the command.

Review URL: http://codereview.chromium.org/173458
------------------------------------------------------------------------
r24506 | estade@chromium.org | 2009-08-26 22:07:50 +0200 (Wed, 26 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

POSIX doesn't have reserved filenames; so don't worry about a download trying to use one.

BUG=19456
Review URL: http://codereview.chromium.org/173238
------------------------------------------------------------------------
r24505 | estade@chromium.org | 2009-08-26 22:06:46 +0200 (Wed, 26 Aug 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/bookmark_manager_browsertest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/chrome.gyp

Add a simple in-process bookmark manager test.

Review URL: http://codereview.chromium.org/174494
------------------------------------------------------------------------
r24504 | evan@chromium.org | 2009-08-26 22:00:14 +0200 (Wed, 26 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

Avoids the use of ToWStringHack in a few places.

BUG=None
TEST=run app_unittests.exe, browser_tests.exe and selenium_tests.exe

Review URL: http://codereview.chromium.org/173418
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r24501 | sky@chromium.org | 2009-08-26 21:42:11 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/menu_arrow.png
   A /trunk/src/app/resources/menu_check.png
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/menu/menu_config_gtk.cc
   M /trunk/src/views/controls/menu/menu_controller.cc
   M /trunk/src/views/controls/menu/menu_controller.h
   M /trunk/src/views/controls/menu/menu_host_gtk.cc
   M /trunk/src/views/controls/menu/menu_host_gtk.h
   M /trunk/src/views/controls/menu/menu_item_view.cc
   M /trunk/src/views/controls/menu/menu_item_view_gtk.cc
   M /trunk/src/views/controls/menu/menu_item_view_win.cc
   M /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window_gtk.cc

Gets bookmark menu working on linux. There are just a handful of
NOTIMPLEMENTEDs to resolve (initiating drags is the biggest remaining
issue). I'll tackle the remaining issues separately.

BUG=none
TEST=make sure bookmark menus work well on windows still.

Review URL: http://codereview.chromium.org/173431
------------------------------------------------------------------------
r24499 | sdoyon@chromium.org | 2009-08-26 21:30:15 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   A /trunk/src/chrome/browser/debugger/extension_ports_remote_service.cc
   A /trunk/src/chrome/browser/debugger/extension_ports_remote_service.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/chrome.gyp

Extension ports devtools remote service.

Wires message ports to extensions through the devtools remote socket.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174226
------------------------------------------------------------------------
r24497 | mattm@chromium.org | 2009-08-26 21:26:23 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc

Fix leaking gtk tree models.

BUG=19750
TEST=none

Review URL: http://codereview.chromium.org/174463
------------------------------------------------------------------------
r24493 | finnur@chromium.org | 2009-08-26 21:13:30 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Tab strip should not resize on close (Vista).

When you close a tab using the mouse, we synthesize a fake WM_MOUSEMOVE message so that the close button that slides under the mouse will highlight. We now use GetMessagePos to read the position of the cursor and SendMessage to dispatch it, otherwise the receiving GetMessagePos call will not calculate the coordinates correctly (coordinates will be relative to the Chrome main window top left point, not the monitor's top left point, causing the tabstrip to resize).

BUG=18832
TEST=On Vista, open a bunch of tabs, then start closing the tab in the middle using the mouse. Don't move the mouse at all while doing this and observe that the tab strip doesn't resize. Also, the close button on the tab that slides under the mouse should be highlighted.

Review URL: http://codereview.chromium.org/173433
------------------------------------------------------------------------
r24472 | jshin@chromium.org | 2009-08-26 20:07:31 +0200 (Wed, 26 Aug 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Don't use URL-encoded strings when user's input is in progress or the text isn't
HTTP/HTTPs.

It seems that Firefox is doing the same thing.

BUG=16534 (http://crbug.com/16534)

TEST=Visit any website and append double-quote (") for the URL and invoke
"Select All" by Control-A, then copy the URL by Control-C. Paste the result into
notepad and check if the double-quote is NOT encoded.
TEST=Access file:///" and select whole Omnibox and copy the URL. Paste the text
into notepad and check if the double-quote is NOT URL encoded.
TEST=Put " in Omnibox and type enter key so that you will be navigated to
http://www.google.co.jp/search?sourceid=chrome&ie=UTF-8&q=%22. Copy whole
content in Omnibox and paste it into notepad. Then, check if the double-quote is
URL-encoded (%22).

Original Review: http://codereview.chromium.org/155495/show
Patch by hamaji@chromium.org (he's on vacation and asked me to land) 


------------------------------------------------------------------------
r24469 | wtc@chromium.org | 2009-08-26 19:56:09 +0200 (Wed, 26 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix a FORWARD_NULL defect reported by Coverity.

If 'profile' is NULL, we should return
ResultCodes::NORMAL_EXIT so that we won't go on to
dereference 'profile'.

R=brettw,estade
BUG=http://crbug.com/17101
TEST=none
Review URL: http://codereview.chromium.org/171007
------------------------------------------------------------------------
r24459 | mpcomplete@chromium.org | 2009-08-26 19:18:14 +0200 (Wed, 26 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/extensions/user_script_listener.cc
   A /trunk/src/chrome/browser/extensions/user_script_listener.h
   A /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/chrome.gyp

Re-try r24372 - Delay request loading until all user scripts that request
depends on are ready.

UMR should be fixed after setting new appcache variable.

BUG=no
TEST=no

Review URL: http://codereview.chromium.org/173482
------------------------------------------------------------------------
r24455 | jrg@chromium.org | 2009-08-26 19:01:12 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm

Fix bookmark bubble crash.

BUG=http://crbug.com/20131
TEST=see bug; was very specific.

Review URL: http://codereview.chromium.org/173428
------------------------------------------------------------------------
r24446 | phajdan.jr@chromium.org | 2009-08-26 17:39:26 +0200 (Wed, 26 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   D /trunk/src/chrome/browser/errorpage_browsertest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Fix another source of flakiness in ErrorPageTest

We need to wait for correct number of navigations when going back or forward
to the LinkDoctor page.

Re-enable previously disabled tests and remove the now-duplicate browser test.

The test is still not very solid, because the LinkDoctor should be mocked.

TEST=Covered by ui_tests.
http://crbug.com/19361, http://crbug.com/19395

Review URL: http://codereview.chromium.org/174396
------------------------------------------------------------------------
r24442 | suzhe@chromium.org | 2009-08-26 17:16:31 +0200 (Wed, 26 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fix issue 19081: Linux: Not able to switch input method correctly in web page using SCIM

This CL fixes issue 19081 by setting im context's client window when host view's native widget is realized rather than focused in.
When setting im context's client window, GtkIMMulticontext will destroy and recreate its slave im context, which will cause this issue.

BUG=19081: Linux: Not able to switch input method correctly in web page using SCIM
TEST=Export GTK_IM_MODULE=scim then open chrome, open www.google.com and place cursor in search box, hit ctrl-space to open SCIM then click scim bar or tray icon and select another input method, then check if input method was switched correct.

Review URL: http://codereview.chromium.org/174217
------------------------------------------------------------------------
r24441 | pinkerton@chromium.org | 2009-08-26 17:12:50 +0200 (Wed, 26 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Cache GTMTheme across windows to avoid re-creating it every time we create a new window. Cache gradient to avoid re-creating it every time we draw a button cell.
BUG=none
TEST=switch themes, ensure it works. Make sure buttons draw correctly.
Review URL: http://codereview.chromium.org/173445
------------------------------------------------------------------------
r24429 | rafaelw@google.com | 2009-08-26 07:01:44 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   D /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Revert "Linux Extensions Install Prompt"

This reverts 24426

TBR=yutak

Review URL: http://codereview.chromium.org/173460

------------------------------------------------------------------------
r24426 | rafaelw@google.com | 2009-08-26 06:26:00 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   A /trunk/src/chrome/browser/gtk/extension_install_prompt_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Linux Extensions Install Prompt

BUG=19653

Review URL: http://codereview.chromium.org/174462

------------------------------------------------------------------------
r24422 | suzhe@chromium.org | 2009-08-26 05:56:20 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Improves key event handing code of BrowserWindowGtk.

This CL improves the key event handing code of BrowserWindowGtk. Issue 20118 is also fixed.

BUG=20118: Typing a colon (:) into the address bar causes the browser to freeze
TEST=Run chrome with a XIM input method, chrome and x server's cpu usage shall be very low after pressing shift key (or any other modifier key) in omnibox.

Review URL: http://codereview.chromium.org/173344
------------------------------------------------------------------------
r24421 | estade@chromium.org | 2009-08-26 05:46:00 +0200 (Wed, 26 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

Revert my download item change.

Turns out download item views need to be destroyed before the associated download item is destroyed.

Review URL: http://codereview.chromium.org/173456
------------------------------------------------------------------------
r24420 | sky@chromium.org | 2009-08-26 05:27:29 +0200 (Wed, 26 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Couple of tweaks to ui_controls_linux:

. Moves listening from DidProcess to WillProcess. This is necessitated
  by the bookmark bar (chrome menu) tests that spawn a nested run
  loop, which results in DidProcess not getting sent and the test
  wedging. This brings the code closer in line with Windows.
. If there is a mouse/keyboard grab, mouse/keyboard events are sent to
  the grabbed widget.
. Deals with a NULL widget for sending keyboard events (tries to find
  focused widget).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/173392
------------------------------------------------------------------------
r24419 | nick@chromium.org | 2009-08-26 04:58:15 +0200 (Wed, 26 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   D /trunk/src/chrome/browser/extensions/user_script_listener.cc
   D /trunk/src/chrome/browser/extensions/user_script_listener.h
   D /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/chrome.gyp

Revert 24372 - Delay request loading until all user scripts that request depends on are ready.

BUG=11547
TEST=See bug.

Review URL: http://codereview.chromium.org/173239

TBR=mpcomplete@chromium.org

Review URL: http://codereview.chromium.org/174501
------------------------------------------------------------------------
r24418 | mirandac@chromium.org | 2009-08-26 04:56:58 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Turn tips on by default, and turn off tip loading during UI testing.

BUG= none
TEST= none

Review URL: http://codereview.chromium.org/173444
------------------------------------------------------------------------
r24417 | brettw@chromium.org | 2009-08-26 04:53:36 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/base/time.h
   M /trunk/src/base/time_mac.cc
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/time_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/test/data/profiles/typical_history/Default/History
   M /trunk/src/net/base/cookie_monster_unittest.cc

Convert internal time format to Windows 1601 epoch on Linux & Mac.

Although we represent time internally starting from 1601, there are still
things like time explosion that will not work before the year 1900.  This
limitation is the same as it was previously.

BUG=14734
Review URL: http://codereview.chromium.org/173296
------------------------------------------------------------------------
r24416 | brettw@chromium.org | 2009-08-26 04:53:02 +0200 (Wed, 26 Aug 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/chromeos/compact_navigation_bar.cc (from /trunk/src/chrome/browser/views/compact_navigation_bar.cc:24095)
   A /trunk/src/chrome/browser/chromeos/compact_navigation_bar.h (from /trunk/src/chrome/browser/views/compact_navigation_bar.h:24095)
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   D /trunk/src/chrome/browser/views/compact_navigation_bar.cc
   D /trunk/src/chrome/browser/views/compact_navigation_bar.h
   M /trunk/src/chrome/chrome.gyp

Move the compact navigation bar to the chromeos directory.

Generalize the chromeos rules so we don't have to list every file in the exclusions.
Review URL: http://codereview.chromium.org/174446
------------------------------------------------------------------------
r24414 | estade@chromium.org | 2009-08-26 04:38:16 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Make the task manager use the native default favicon

BUG=13320


Review URL: http://codereview.chromium.org/173432
------------------------------------------------------------------------
r24413 | estade@chromium.org | 2009-08-26 04:38:06 +0200 (Wed, 26 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

Don't DCHECK when removing items from the download shelf.

BUG=20186

Review URL: http://codereview.chromium.org/173407
------------------------------------------------------------------------
r24410 | mhm@chromium.org | 2009-08-26 03:37:10 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Introduce accesskeys for Chrome menus.

Added ALT+E for Chrome Page Menu
Added ALT+F for Chrome App Menu

BUG=906 (http://crbug.com/906)
TEST=Triggered ALT+A and ALT+P from the keyboard which successfully opened the corresponding menu.
Review URL: http://codereview.chromium.org/174044
------------------------------------------------------------------------
r24399 | mirandac@chromium.org | 2009-08-26 03:26:16 +0200 (Wed, 26 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Reverting 24385.
Review URL: http://codereview.chromium.org/173443
------------------------------------------------------------------------
r24398 | mattm@chromium.org | 2009-08-26 03:19:43 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/base/string_tokenizer.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Fix cases that initialized StringTokenizer with a temporary.

Fix examples in StringTokenizer header that recommended doing that.

BUG=none
TEST=on linux, open options, click proxy configuration button a bunch.  It should not fail intermittently.

Review URL: http://codereview.chromium.org/174490
------------------------------------------------------------------------
r24388 | suzhe@chromium.org | 2009-08-26 02:56:43 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Fix regression issue 20066.

This CL fixes issue 20066, a regression issue caused by a change in CL 172041.

BUG=20066: Regression: search keywords search with default search engine only.
TEST=Assuming 'y' is associated to a search engine, type "y abc" in omnibox and press enter shall search abc with the search engine associated to 'y'.

Review URL: http://codereview.chromium.org/173332
------------------------------------------------------------------------
r24385 | mirandac@chromium.org | 2009-08-26 02:40:14 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Turn on tips by default.

BUG= none
TEST= none

Review URL: http://codereview.chromium.org/173371
------------------------------------------------------------------------
r24384 | mirandac@chromium.org | 2009-08-26 02:32:11 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/web_resource/web_resource_unpacker.cc
   M /trunk/src/chrome/common/web_resource/web_resource_unpacker.h

Add single line of tips to NNTP.

BUG= http://crbug.com/19162
TEST= Start browser with NNTP, note line of tips at bottom.

Review URL: http://codereview.chromium.org/173087
------------------------------------------------------------------------
r24378 | thestig@chromium.org | 2009-08-26 02:14:27 +0200 (Wed, 26 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/breakpad/breakpad.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc

Allow Chromium Linux to be built with Breakpad. Enable Linux CHROME_HEADLESS support. (Try 2)

TEST=none
BUG=19663

Original Review URL: http://codereview.chromium.org/173095

Review URL: http://codereview.chromium.org/173397
------------------------------------------------------------------------
r24372 | mpcomplete@chromium.org | 2009-08-26 01:45:58 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/extensions/user_script_listener.cc
   A /trunk/src/chrome/browser/extensions/user_script_listener.h
   A /trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/chrome.gyp

Delay request loading until all user scripts that request depends on are ready.

BUG=11547
TEST=See bug.

Review URL: http://codereview.chromium.org/173239
------------------------------------------------------------------------
r24370 | glen@chromium.org | 2009-08-26 01:37:02 +0200 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Theme the NTP attribution text

BUG=20262
TEST=Verify that the attribution 'theme created by' text matches the title color under the thumbnails

Review URL: http://codereview.chromium.org/173409
------------------------------------------------------------------------
r24360 | phajdan.jr@chromium.org | 2009-08-26 01:09:46 +0200 (Wed, 26 Aug 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/view_id_util_browsertest.cc (from /trunk/src/chrome/browser/gtk/view_id_util_unittest.cc:24356)
   D /trunk/src/chrome/browser/gtk/view_id_util_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Move the ViewIDTest to browser_tests, where it belongs.

It carries state in singletons, which is evil. browser_tests launcher
deals with that properly.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/174470
------------------------------------------------------------------------
r24356 | kuchhal@chromium.org | 2009-08-26 00:56:31 +0200 (Wed, 26 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Disable Firefox Importer tests again due to Purify report of leaks.

Review URL: http://codereview.chromium.org/174414
------------------------------------------------------------------------
r24344 | tony@chromium.org | 2009-08-26 00:20:36 +0200 (Wed, 26 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Work around a WM work around where if the size of the chrome
window matches the desktop size on startup, the WM puts chrome
in full screen mode that you can't get out of.

Our workaround is to never restore to a size that matches the
screen.  This is better than telling people to edit their
Local State file.

Review URL: http://codereview.chromium.org/174457

------------------------------------------------------------------------
r24336 | erg@google.com | 2009-08-25 23:51:24 +0200 (Tue, 25 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK Themes: Dropdown arrow size on download items should match font size.

Review URL: http://codereview.chromium.org/174449
------------------------------------------------------------------------
r24327 | estade@chromium.org | 2009-08-25 23:25:18 +0200 (Tue, 25 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

gtk: port ButtonSeparatorView

BUG=13142

Review URL: http://codereview.chromium.org/173334
------------------------------------------------------------------------
r24325 | shess@chromium.org | 2009-08-25 23:21:29 +0200 (Tue, 25 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h

OSX: Fix the select-all-on-mouse-down in Omnibox.

Getting clicks in the decoration areas right caused a change to how
clicks on the unfocused field worked.  NSTextField also forwards the
event to get click-drag selection right, this does the same thing for
clicks in the decorations (other clicks are passed to super).

http://crbug.com/20142
TEST=Browse to www.google.com.  Click in page.  Click in omnibox
without releasing.  You should get a caret insertion point.

Review URL: http://codereview.chromium.org/173362
------------------------------------------------------------------------
r24323 | glen@chromium.org | 2009-08-25 23:17:43 +0200 (Tue, 25 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

- Fix bug where white logo wasn't showing
- Add attribution support back to the NTP

BUG=20019
TEST=Install a theme with a white logo and attribution, and verify that both display correctly.

Review URL: http://codereview.chromium.org/173372
------------------------------------------------------------------------
r24316 | erg@google.com | 2009-08-25 23:02:28 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK Themes: Create an inactive tab text color based on the inactive tab.

(We were previously just grabbing a raw GTK color, which didn't work out very
well in themes like High Contrast Inverse...)

Review URL: http://codereview.chromium.org/174407
------------------------------------------------------------------------
r24310 | erg@google.com | 2009-08-25 22:50:37 +0200 (Tue, 25 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK Themes: Fix linux UI frame regression introduced in r24170.

Review URL: http://codereview.chromium.org/173389
------------------------------------------------------------------------
r24309 | piman@chromium.org | 2009-08-25 22:50:32 +0200 (Tue, 25 Aug 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc

linux: new socket/plug code for windowed plugins

This CL reworks the GtkSocket/GtkPlug code for windowed plugins on linux. Instead of having the plugin ask the browser to create a socket to plug into, it simply creates a plug and sends it to the browser. The browser creates a socket and attaches the plug when the socket becomes realized

This fixes 2 main issues:
- we can create windowed plugins in background tabs (Issue 16125)
- we can detach tabs with windowed plugins and reattach them (Issue 17110)

I reworked the IPCs, so it removes some amount of linux-specific things. We also need less synchronous IPCs to create/destroy plugins, so that should be a bit faster. In particular, I removed the plugin pid map, and instead made sure the renderer always destroys the plugin containers if the plugin process crashes - they will be destroyed if the renderer process crashes. Let me know if you have an issue with that.

Also, the intermediate plug/socket creation now happens in webplugin_delegate_impl_gtk. That means test_shell uses it as well. It made the code a lot simpler, and means we're testing it as well, albeit with a bit of extra overhead.

Bonus: I found a big bad bug in the GtkPluginContainer that made its width/height alias with some internal gtk structures. That was certainly causing some amounts of bugs.

Bonus 2: scrolling now looks more in sync with the rest of the page, though I'm not exactly sure which part caused that.

BUG=16125,17110
TEST=a lot of manual testing involving YouTube videos

Review URL: http://codereview.chromium.org/174295

------------------------------------------------------------------------
r24287 | mattm@chromium.org | 2009-08-25 21:52:53 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc

Gtk Font options: Separate font family and size by comma to work around Gtk issue.

BUG=19823
TEST=see bug

Review URL: http://codereview.chromium.org/173333
------------------------------------------------------------------------
r24269 | kuchhal@chromium.org | 2009-08-25 20:50:09 +0200 (Tue, 25 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Re-enable importer unit tests since they do not seem to generate Purify errors locally.

Review URL: http://codereview.chromium.org/174414
------------------------------------------------------------------------
r24262 | klink@chromium.org | 2009-08-25 20:43:06 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/webkit/glue/glue_accessibility_object.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Adds support for WAI-ARIA roles application, document, radiogroup, region, separator, status and tooltip.

BUG=19982
TEST=Assign @role application, document, radiogroup, region, separator, status or tooltip to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly.

Review URL: http://codereview.chromium.org/174382
------------------------------------------------------------------------
r24255 | estade@chromium.org | 2009-08-25 20:23:51 +0200 (Tue, 25 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK: Make the progress area go away when a download item is cancelled.

BUG=20158

Review URL: http://codereview.chromium.org/174365
------------------------------------------------------------------------
r24253 | deanm@chromium.org | 2009-08-25 20:19:44 +0200 (Tue, 25 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Fix double control key issue with the omnibox.

Previously holding two controls keys and releasing one would show the
non-control omnibox results, but hitting enter would take the control results.
Fix this by showing the correct results if any control key is held down.

Review URL: http://codereview.chromium.org/173324

------------------------------------------------------------------------
r24252 | mdm@chromium.org | 2009-08-25 20:14:26 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Linux: set the initial size of the "Page" column in the task manager to fit the dialog.
This keeps that column from forcing the other columns into a scroll bar when a page with a long title is viewed.
BUG=17930
TEST=none

Review URL: http://codereview.chromium.org/173308
------------------------------------------------------------------------
r24241 | thakis@chromium.org | 2009-08-25 19:11:44 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_mac.h
   M /trunk/src/chrome/browser/login_prompt_mac.mm

Autofill http auth dialog on os x and linux.

BUG=19801
TEST=See bug (on both mac and linux)

Review URL: http://codereview.chromium.org/173341
------------------------------------------------------------------------
r24234 | erikkay@google.com | 2009-08-25 18:26:17 +0200 (Tue, 25 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm

Add support for replace infobar.  The lack of this was a top mac crasher.
BUG=19728
TEST=install two themes without dismissing info bar.  then dismiss the info bar.  It shouldn't crash.

Review URL: http://codereview.chromium.org/174349
------------------------------------------------------------------------
r24233 | pfeldman@chromium.org | 2009-08-25 18:22:12 +0200 (Tue, 25 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: disable scripts-related sanity tests again.
TBR=yurys

------------------------------------------------------------------------
r24231 | phajdan.jr@chromium.org | 2009-08-25 17:22:46 +0200 (Tue, 25 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   A /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Fix "crashed extension" infobar browser crashes.

This is a general rework of how "crashed extension" infobar works
and how the extension is actually recovered after the crash.

This is a subset of original http://codereview.chromium.org/164151/ .
I had to remove the part which unloads the entire extension on crash,
because it interacts badly with other parts of the browser. I'm fixing that.

TEST=See bug.
http://crbug.com/15888

Review URL: http://codereview.chromium.org/173314
------------------------------------------------------------------------
r24230 | pfeldman@chromium.org | 2009-08-25 15:53:58 +0200 (Tue, 25 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   D /trunk/src/chrome/test/data/devtools/debugger_test.js
   M /trunk/src/chrome/test/data/devtools/debugger_test_page.html
   A /trunk/src/chrome/test/data/devtools/resource_test.js
   A /trunk/src/chrome/test/data/devtools/resource_test_page.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Enable devtools sanity tests on Linux.

Review URL: http://codereview.chromium.org/174395
------------------------------------------------------------------------
r24228 | yutak@chromium.org | 2009-08-25 13:23:45 +0200 (Tue, 25 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/breakpad/breakpad.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc

Reverting 24220.

It seemed that r24220 caused failures on all of Linux UI (valgrind) bots.

TBR=thestig@chromium.org

Review URL: http://codereview.chromium.org/173345
------------------------------------------------------------------------
r24226 | aa@chromium.org | 2009-08-25 10:52:47 +0200 (Tue, 25 Aug 2009) | 3 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   D /trunk/src/chrome/test/data/extensions/api_test/storage/api_test.js
   D /trunk/src/chrome/test/data/extensions/api_test/storage/background.html
   D /trunk/src/chrome/test/data/extensions/api_test/storage/manifest.json
   D /trunk/src/chrome/test/data/extensions/api_test/storage/tab.html
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Revert r24223. Storage test is not working.

TBR=mpcomplete@chromium.org
------------------------------------------------------------------------
r24223 | aa@chromium.org | 2009-08-25 10:23:00 +0200 (Tue, 25 Aug 2009) | 22 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_storage_apitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/test/data/extensions/api_test/storage
   A /trunk/src/chrome/test/data/extensions/api_test/storage/api_test.js
   A /trunk/src/chrome/test/data/extensions/api_test/storage/background.html
   A /trunk/src/chrome/test/data/extensions/api_test/storage/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/storage/tab.html
   M /trunk/src/webkit/glue/webpreferences.cc
   M /trunk/src/webkit/glue/webpreferences.h

Force databases and localstorage to be enabled extensions.

We were already doing this, this change modifies the
mechanism. Before we were relying on the presence of the
--enable-extensions flag, but as we are getting ready to
remove that on dev, we needed something else.

This forces local storage and database to be enabled on
chrome-extension:// pages.

Also, change the way database enabling works in general to
be more like the way local storage works, just for
consistency. Will remove old, unnecessary WebKit API in an
upstream change.

erikkay: extensions stuff
dumi: database stuff
jorlow: local storage stuff

BUG=19511

Review URL: http://codereview.chromium.org/173306
------------------------------------------------------------------------
r24220 | thestig@chromium.org | 2009-08-25 09:25:06 +0200 (Tue, 25 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/breakpad/breakpad.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc

Allow Chromium Linux to be built with Breakpad. Enable Linux CHROME_HEADLESS support.

TEST=none
BUG=19663
Review URL: http://codereview.chromium.org/173095
------------------------------------------------------------------------
r24216 | aa@chromium.org | 2009-08-25 07:13:57 +0200 (Tue, 25 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/net/base/mime_util.cc

Try one more time to lock down content sniffing for
Chrome extensions.

Last time I tried to check this in, I had to roll
it back because it made installing extensions from
file:// URLs not work.

Turned out that we just have to add a single line
mapping the ".crx" extension to our mimetype.

BUG=13296
TEST=Install an extension from the interweb, it should install. Install an extension from disk, it should install.

Review URL: http://codereview.chromium.org/174380
------------------------------------------------------------------------
r24212 | tommi@chromium.org | 2009-08-25 05:48:03 +0200 (Tue, 25 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h

Making RegisterRequest and UnregisterRequest virtual so that they can be overriden in derived test classes.
Also making the unique id counter static in order to avoid conflicts with id values handed out from base classes.
Since the id will be used on the other side of automation, it's not enough to make the id generator function overridable.  All request IDs must be unique.

R=amit
BUG=none
TEST=Should be no change.  Run automation tests.

Review URL: http://codereview.chromium.org/174345
------------------------------------------------------------------------
r24210 | mattm@chromium.org | 2009-08-25 04:16:47 +0200 (Tue, 25 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h

More Gtk Cookies View polish.

Reduce filter delay to 100ms, add stock icons to dialog buttons,
remove extraneous cookie icons.

BUG=17919
TEST=none

Review URL: http://codereview.chromium.org/173331
------------------------------------------------------------------------
r24206 | tim@chromium.org | 2009-08-25 03:45:44 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc

Make HttpBridge::AllowSendingCookies return true for now.

TEST=HttpBridgeTest, sync integration
BUG=20182

Review URL: http://codereview.chromium.org/173325
------------------------------------------------------------------------
r24198 | glen@chromium.org | 2009-08-25 02:46:03 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Now that Import and Clear are available in options, they should be removed from the menu.

BUG=20137
TEST=Verify that the Chrome menu doesn't contain 'import' or 'clear browsing data' options.

Review URL: http://codereview.chromium.org/149745
------------------------------------------------------------------------
r24191 | estade@chromium.org | 2009-08-25 02:25:43 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

Fall back to the chrome-themed default favicon if the gtk theme fails to produce one.

BUG=19994


Review URL: http://codereview.chromium.org/174267
------------------------------------------------------------------------
r24187 | estade@chromium.org | 2009-08-25 02:12:58 +0200 (Tue, 25 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

GTK: Show the correct text for the omnibox "paste and go/search" menu item.

BUG=20151

Review URL: http://codereview.chromium.org/174363
------------------------------------------------------------------------
r24186 | mmoss@chromium.org | 2009-08-25 02:12:29 +0200 (Tue, 25 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/installer/installer.gyp

Update build to work with native 64-bit Linux packages.

Also remove the no longer used GTK variable, since the GTK_PATH modification
was a hack for 32-bit binaries on 64-bit distros.

Review URL: http://codereview.chromium.org/173286

------------------------------------------------------------------------
r24179 | glen@chromium.org | 2009-08-25 01:49:34 +0200 (Tue, 25 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

We weren't drawing the toolbar color, leading to theme hideousness.

Also fix up the bookmark bar border color.

BUG=20139
TEST=none

Review URL: http://codereview.chromium.org/174352
------------------------------------------------------------------------
r24170 | mirandac@chromium.org | 2009-08-25 01:06:19 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/test/data/profiles/complex_theme/Default/PreferencesTemplate

Cache images on theme install so startup does no image processing.

BUG= http://crbug.com/18768
TEST= none

Review URL: http://codereview.chromium.org/174085
------------------------------------------------------------------------
r24166 | pinkerton@chromium.org | 2009-08-25 00:36:53 +0200 (Tue, 25 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm

Compile on 10.6
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173305
------------------------------------------------------------------------
r24158 | mpcomplete@chromium.org | 2009-08-25 00:11:07 +0200 (Tue, 25 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   A /trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc
   A /trunk/src/chrome/browser/extensions/extension_devtools_bridge.h
   A /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.cc
   A /trunk/src/chrome/browser/extensions/extension_devtools_browsertest.h
   A /trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc
   A /trunk/src/chrome/browser/extensions/extension_devtools_events.cc
   A /trunk/src/chrome/browser/extensions/extension_devtools_events.h
   A /trunk/src/chrome/browser/extensions/extension_devtools_manager.cc
   A /trunk/src/chrome/browser/extensions/extension_devtools_manager.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/devtools
   A /trunk/src/chrome/test/data/extensions/devtools/timeline_api
   A /trunk/src/chrome/test/data/extensions/devtools/timeline_api/background.html
   A /trunk/src/chrome/test/data/extensions/devtools/timeline_api/manifest.json
   A /trunk/src/chrome/test/data/extensions/devtools/timeline_api_two
   A /trunk/src/chrome/test/data/extensions/devtools/timeline_api_two/background_two.html
   A /trunk/src/chrome/test/data/extensions/devtools/timeline_api_two/manifest.json
   M /trunk/src/chrome/test/testing_profile.h

Exposes a chrome.devtools object to extensions.  This allows extensions to call chrome.devtools.connect() to open up a Port by which it can receive devtools messages to implement the proposed perf trace extensions API documented here:

http://code.google.com/p/chromium/wiki/ExtensionsPerfTraceAPI

Review URL: http://codereview.chromium.org/159882
------------------------------------------------------------------------
r24156 | mdm@chromium.org | 2009-08-25 00:08:10 +0200 (Tue, 25 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Linux: fix "goats teleported" task manager column.
Some glibc library functions behave a little differently than Windows so this column was not working correctly.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174347
------------------------------------------------------------------------
r24155 | estade@chromium.org | 2009-08-25 00:01:18 +0200 (Tue, 25 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc

Fix 2 failing BlockedPopupContainerInteractiveTests on Linux.

Review URL: http://codereview.chromium.org/174356
------------------------------------------------------------------------
r24154 | jhawkins@chromium.org | 2009-08-24 23:53:12 +0200 (Mon, 24 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc

Fix the Views build.

TBR=tony
Review URL: http://codereview.chromium.org/174357
------------------------------------------------------------------------
r24153 | jhawkins@chromium.org | 2009-08-24 23:41:30 +0200 (Mon, 24 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc

gtk: Implement AutomationProvider::GetBrowserForWindow.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173289
------------------------------------------------------------------------
r24150 | tim@chromium.org | 2009-08-24 23:31:54 +0200 (Mon, 24 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc

In HttpBridgeTest, make sure to read the full HTTP response content and not
just up until the first null character.

TEST=HttpBridgeTest

Review URL: http://codereview.chromium.org/174291
------------------------------------------------------------------------
r24149 | jhawkins@chromium.org | 2009-08-24 23:24:53 +0200 (Mon, 24 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

gtk: Clip the cairo context to the extents provided to the DrawStringInt function.  This fixes an issue when rendering the tab title where the ellipses are rendered no matter how small the tab is sized.  This change also fixes an issue where we were using the default font to determine whether to show the tooltip.

BUG=19741
TEST=Open many tabs.  See that the ellipses should disappear when there's no room left in the tab to display them.
Review URL: http://codereview.chromium.org/173300
------------------------------------------------------------------------
r24145 | erg@google.com | 2009-08-24 23:07:23 +0200 (Mon, 24 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

GTK Themes: Theme the dangerous file warning label and icon.

http://crbug.com/18340

Review URL: http://codereview.chromium.org/174328
------------------------------------------------------------------------
r24143 | mdm@chromium.org | 2009-08-24 22:55:17 +0200 (Mon, 24 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Linux: use switches::kApp instead of "--app" when creating .desktop files.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174340
------------------------------------------------------------------------
r24140 | rafaelw@chromium.org | 2009-08-24 22:47:06 +0200 (Mon, 24 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json

(Extension API) Make BookmarkTreeNode.index "type":"integer"

Review URL: http://codereview.chromium.org/173275
------------------------------------------------------------------------
r24139 | tony@chromium.org | 2009-08-24 22:45:44 +0200 (Mon, 24 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

Reduce the status bubble rounding by a pixel.

Since we don't have real rounded corners, make the corner look less
blocky and only clip by 3 pixels.  This matches the "rounding" of
the bottom of the find box.

Review URL: http://codereview.chromium.org/174344

------------------------------------------------------------------------
r24138 | stuartmorgan@chromium.org | 2009-08-24 22:45:02 +0200 (Mon, 24 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fix a leak in RenderWidgetHostViewCocoa and remove its suppression

BUG=18540
TEST=Valgrind Mac bots should stay green

Review URL: http://codereview.chromium.org/174293
------------------------------------------------------------------------
r24131 | paul@chromium.org | 2009-08-24 21:58:27 +0200 (Mon, 24 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm

Fix a crash when closing a window with a download animation.

This CL fixes a crash that occurs when a small download has
completed quickly, and the download shelf receives two 'complete'
notifications (one at shelf item creation, and one when the
download observer fires).

We detect this case by checking for an existing complete
animation and ignoring the second notification.

BUG=18416 (http://crbug.com/18416)
TEST=Download something, close the window before the animation completes
     and notice that Chrome doesn't crash.

Review URL: http://codereview.chromium.org/174326
------------------------------------------------------------------------
r24114 | hclam@chromium.org | 2009-08-24 20:00:32 +0200 (Mon, 24 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/media/audio/audio_output.h
   M /trunk/src/media/audio/fake_audio_output_stream.cc
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/alsa_output_unittest.cc
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac_unittest.cc
   M /trunk/src/media/audio/simple_sources.cc
   M /trunk/src/media/audio/simple_sources.h
   M /trunk/src/media/audio/simple_sources_unittest.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/filters/audio_renderer_impl.cc
   M /trunk/src/media/filters/audio_renderer_impl.h

Providing unplayed bytes in audio hardware buffer

BUG=20007
TEST=WinAudioTest.PCMWaveStreamPendingBytes

We used to guess what is in the hardware audio buffer to
perform audio sync. But due the triple buffering and
other platforms has other buffering scheme we need to be
able to know how many bytes are left in the hardware buffer.

We provide this data via AudioCallback::OnMoreData(), so we
can predict when the requested buffer will be played.

Review URL: http://codereview.chromium.org/174243
------------------------------------------------------------------------
r24113 | rvargas@google.com | 2009-08-24 19:59:31 +0200 (Mon, 24 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc

Http cache: Enable experimental support for byte range requests.

Requires --enable-byte-range-support

BUG=12258
TEST=covered by unit tests.

Review URL: http://codereview.chromium.org/173231
------------------------------------------------------------------------
r24101 | phajdan.jr@chromium.org | 2009-08-24 17:52:38 +0200 (Mon, 24 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/test/data/showmodaldialog.html
   M /trunk/src/chrome/test/data/showmodaldialog_dialog.html

Make ShowModalDialogTest.BasicTest not flaky and re-enable it.

TEST=Covered by ui_tests.
http://crbug.com/17806

Review URL: http://codereview.chromium.org/174245
------------------------------------------------------------------------
r24090 | jhawkins@chromium.org | 2009-08-23 21:49:03 +0200 (Sun, 23 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Move the remaining gtk stubs for AutomationProvider out of temp_scaffolding_stubs.cc.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174289
------------------------------------------------------------------------
r24089 | aa@chromium.org | 2009-08-23 19:56:25 +0200 (Sun, 23 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/render_view_test.cc

Implement granular cross-origin XHR for extensions.

I left the temporary hack that allows all origins until we are
ready to break everything all at once.

Also, I still need to devise some way to test this.

BUG=12129

Review URL: http://codereview.chromium.org/173166
------------------------------------------------------------------------
r24080 | mhm@chromium.org | 2009-08-22 18:27:32 +0200 (Sat, 22 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/options_util.cc

Clears the "Clear auto-opening settings" button (put it in the default state,
ie, disabled), when the user 
clicks in "Reset to defaults" button.

BUG=7334 (http://crbug.com/7334)
TEST=Download a file, enable "Always open files of this type" from download item
menu, go to Options/Under the 
Hood and then click on "Reset to defaults" button.

Contributed by tfarina (thiago.farina@gmail.com)

Review URL: http://codereview.chromium.org/174306
------------------------------------------------------------------------
r24079 | mhm@chromium.org | 2009-08-22 18:09:39 +0200 (Sat, 22 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Enabling "Save as..." in view:source page.

BUG=12748 (http://crbug.com/12748)
TEST=Goes to view-source:http://www.google.com/ and see if the menu is enabled.

Review URL: http://codereview.chromium.org/165068
------------------------------------------------------------------------
r24078 | jnd@chromium.org | 2009-08-22 12:17:32 +0200 (Sat, 22 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Disable this test of encoding override on MacOS and Linux because on those platforms
 AutomationProvider::OverrideEncoding is not implemented yet.

BUG=none
TEST=none
TBR=jshin

Review URL: http://codereview.chromium.org/174305
------------------------------------------------------------------------
r24077 | jnd@chromium.org | 2009-08-22 11:37:36 +0200 (Sat, 22 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Use size_t to fix compilation error.

TEST=none
BUG=none

------------------------------------------------------------------------
r24076 | jnd@chromium.org | 2009-08-22 11:29:34 +0200 (Sat, 22 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Use ARRAYSIZE_UNSAFE

BUG=none
TEST=none
TBR=jshik

------------------------------------------------------------------------
r24075 | jnd@chromium.org | 2009-08-22 11:23:18 +0200 (Sat, 22 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

arraysize doesn't accept a type defined inside a function.  In these rare
 cases, I have to use the unsafe ARRAYSIZE_UNSAFE() macro

BUG=none
TEST=none
TRB=jshik

------------------------------------------------------------------------
r24074 | jnd@chromium.org | 2009-08-22 11:06:53 +0200 (Sat, 22 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_encoding_uitest.cc

Fix compilation failure on Mac and Linux

BUG=none
TEST=none
TBR=jshin


Review URL: http://codereview.chromium.org/174304
------------------------------------------------------------------------
r24073 | jnd@chromium.org | 2009-08-22 10:28:47 +0200 (Sat, 22 Aug 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/browser_encoding_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/encoding_tests
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/Big5.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/EUC-JP.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-13.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-15.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-2.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-4.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-5.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-6.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-7.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/ISO-8859-8.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/KOI8-R.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/KOI8-U.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/Shift-JIS.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/UTF-16LE.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/UTF-8.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/gb18030.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/iso-8859-1.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/macintosh.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1250.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1251.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1252.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1253.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1254.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1255.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1256.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1257.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-1258.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-874.html
   A /trunk/src/chrome/test/data/encoding_tests/alias_mapping/windows-949.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/Big5_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/ISO-8859-5_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/ISO-8859-6_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/ISO-8859-7_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/ISO-8859-8_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/KOI8-R_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/Shift-JIS_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/UTF-8_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_Big5_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_ISO-8859-5_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_ISO-8859-6_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_ISO-8859-7_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_ISO-8859-8_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_KOI8-R_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_Shift-JIS_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_UTF-8_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_gb18030_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_iso-8859-1_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_windows-1251_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_windows-1254_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_windows-1255_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_windows-1256_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/expected_results/expected_windows-949_saved_from_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/gb18030_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/iso-8859-1_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/windows-1251_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/windows-1254_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/windows-1255_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/windows-1256_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/auto_detect/windows-949_with_no_encoding_specified.html
   A /trunk/src/chrome/test/data/encoding_tests/user_override
   A /trunk/src/chrome/test/data/encoding_tests/user_override/expected_gb18030_saved_from_iso88591_meta.html
   A /trunk/src/chrome/test/data/encoding_tests/user_override/gb18030_with_iso88591_meta.html
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add a UI test for "Encoding" menu. Please see crbug.com/5515 for more details.This change list is based on http://codereview.chromium.org/18417 which was written by xlyuan@chromiumBug=5515 ( http://crbug.com/5515 )
Review URL: http://codereview.chromium.org/165393
------------------------------------------------------------------------
r24068 | rafaelw@chromium.org | 2009-08-22 08:01:32 +0200 (Sat, 22 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/renderer/extensions/bindings_utils.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/test.html

Validation of extension api callbacks and event parameters in DEBUG

BUG=18711

Review URL: http://codereview.chromium.org/173034
------------------------------------------------------------------------
r24062 | chron@chromium.org | 2009-08-22 03:32:07 +0200 (Sat, 22 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/sync/glue/http_bridge.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc

Add support to glue and syncAPI for header setting. (second try)

Review URL: http://codereview.chromium.org/174269
------------------------------------------------------------------------
r24055 | jhawkins@chromium.org | 2009-08-22 02:36:05 +0200 (Sat, 22 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove even more cruft from temp_scaffolding_stubs.h.  This change also enables modal_html_dialog_delegate.cc for Mac and Linux, since it's already ported.  Porting defines in tab_contents.cc were removed to reflect the current state of the ports.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174278
------------------------------------------------------------------------
r24054 | jrg@chromium.org | 2009-08-22 02:31:22 +0200 (Sat, 22 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm

Add favicons to the Mac bookmark menu

Landing CL for rsesek@chromium.org
Original CL: http://codereview.chromium.org/172084


------------------------------------------------------------------------
r24052 | suzhe@chromium.org | 2009-08-22 02:25:04 +0200 (Sat, 22 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Implements unimplemented methods of AutocompleteEditViewGtk and fixes a regression issue.

This CL implements two unimplemented methods of AutocompleteEditViewGtk: OnRevertTemporaryText() and IsSelectAll().
The implementation are mostly copied from autocomplete_edit_view_mac.mm.

Some grammer errors and a valgrind warning introduced by CL 165457 are also fixed.

This CL was just updated to fix a regression caused by CL 165457 (issue 19631).

BUG=19631: Tabbing on Omnibox enters in to search UI mode
TEST=Input something in omnibox and make sure some text is selected and popup view is opened, change current selection in popup view by pressing up/down then press escape to see if omnibox is reverted to its original content and selection.
TEST=Make sure www.google.com is one of the search engine, open www.google.com then move the focus back to omnibox and press tab to see if the focus is moved into web page.

Review URL: http://codereview.chromium.org/172041
------------------------------------------------------------------------
r24051 | brg@chromium.com | 2009-08-22 02:24:39 +0200 (Sat, 22 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h

Reorganize UMA data to measure network latency on sync authorization.

Also, the max time for the merge/sync UI should be increased to minutes.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174170
------------------------------------------------------------------------
r24049 | klink@chromium.org | 2009-08-22 02:20:30 +0200 (Sat, 22 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/webkit/glue/glue_accessibility_object.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Adds support and exposure of additional accessibility roles. Includes naming of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars.

BUG=13291,19982
TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document.
Review URL: http://codereview.chromium.org/174252
------------------------------------------------------------------------
r24038 | jrg@chromium.org | 2009-08-22 00:57:39 +0200 (Sat, 22 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Tweak bookmark star bubble with UI dudes:
- Bubble arrow now gives STAR a wedgie (Glen)
- Bubble slightly higher up (Ben)
- 'Remove' button moved to bottom-left; made full size (Cole, Glen, Ben)
- Title alignment tweaks (Cole)
- Window height += 8 for better alignment (Cole)
- Window has shadow and no explicit border (Cole)

Review URL: http://codereview.chromium.org/173215
------------------------------------------------------------------------
r24037 | jeremy@chromium.org | 2009-08-22 00:56:00 +0200 (Sat, 22 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm

Fix carwash in BookMarkBarController

objc objects that own c++ objects have funny behavior.  The C++ object's destructor can be called at an unspecified future time, long past the time that the objc object is destructed.

One possible symptom is an objc exception thrown when a browser window closes which could surface as a failure of Chrome to quit.

Review URL: http://codereview.chromium.org/173232
------------------------------------------------------------------------
r24034 | estade@chromium.org | 2009-08-22 00:37:35 +0200 (Sat, 22 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/base/mime_util.h
   M /trunk/src/base/mime_util_linux.cc
   M /trunk/src/chrome/browser/icon_loader.cc

Move gtk_settings_get_default() call to the UI thread.

BUG=19971

Review URL: http://codereview.chromium.org/173216
------------------------------------------------------------------------
r24032 | jhawkins@chromium.org | 2009-08-22 00:35:29 +0200 (Sat, 22 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_browser_process.h

Mask the BrokerServices class behind an ifdef for Windows only; Linux and Mac have their own sandboxes.  Remove the corresponding stubs from temp_scaffolding_stubs.h.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173228
------------------------------------------------------------------------
r24028 | dimich@google.com | 2009-08-22 00:18:30 +0200 (Sat, 22 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Disable the second Page404 ui_test - first was disabled earlier, this one uses same code path.
R=phajdan.jr
BUG=19361
TEST=none
Review URL: http://codereview.chromium.org/173227
------------------------------------------------------------------------
r24027 | estade@chromium.org | 2009-08-22 00:14:41 +0200 (Sat, 22 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/common/gtk_util.cc

More interactive test porting for Linux.

Also fix a bug in the Windows implementation of SendMouseMoveNotifyWhenDone where the task would never be run if the cursor was already in the destination position before the call.

BUG=19076
BUG=19881

Review URL: http://codereview.chromium.org/174201
------------------------------------------------------------------------
r24026 | rvargas@google.com | 2009-08-22 00:07:37 +0200 (Sat, 22 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc

Revert cl 24015

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174260
------------------------------------------------------------------------
r24024 | jeremy@chromium.org | 2009-08-21 23:53:54 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   A /trunk/src/chrome/browser/importer/firefox_importer_unittest_messages_internal.h
   A /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils.h
   A /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.mm
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.mm
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/firefox2_nss_mac/README
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libfreebl3.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libnspr4.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libnss3.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libplc4.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libplds4.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libsoftokn3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/README
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libfreebl3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnspr4.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnss3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnssdbm3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnssutil3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libplc4.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libplds4.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libsoftokn3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libsqlite3.dylib
   M /trunk/src/ipc/ipc_sync_message_unittest.h
   M /trunk/src/ipc/ipc_tests.cc

Recommit "Bring up Firefox Password Import Unittest on OS X."

This recommits r23971

Review URL: http://codereview.chromium.org/174259
------------------------------------------------------------------------
r24023 | erg@google.com | 2009-08-21 23:51:57 +0200 (Fri, 21 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

GTK Themes: Download items should be drawn with GTK, not nineboxes.

Review URL: http://codereview.chromium.org/174253
------------------------------------------------------------------------
r24022 | michaeln@google.com | 2009-08-21 23:46:31 +0200 (Fri, 21 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/app_cache
   A /trunk/src/chrome/common/appcache
   A /trunk/src/chrome/common/appcache/appcache_backend_proxy.cc
   A /trunk/src/chrome/common/appcache/appcache_backend_proxy.h
   A /trunk/src/chrome/common/appcache/appcache_dispatcher.cc (from /trunk/src/chrome/common/app_cache/app_cache_dispatcher.cc:23644)
   A /trunk/src/chrome/common/appcache/appcache_dispatcher.h (from /trunk/src/chrome/common/app_cache/app_cache_dispatcher.h:23644)
   A /trunk/src/chrome/common/appcache/appcache_dispatcher_host.cc (from /trunk/src/chrome/common/app_cache/app_cache_dispatcher_host.cc:23644)
   A /trunk/src/chrome/common/appcache/appcache_dispatcher_host.h (from /trunk/src/chrome/common/app_cache/app_cache_dispatcher_host.h:23644)
   A /trunk/src/chrome/common/appcache/appcache_frontend_proxy.cc
   A /trunk/src/chrome/common/appcache/appcache_frontend_proxy.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   A /trunk/src/webkit/appcache/appcache_backend_impl.cc
   A /trunk/src/webkit/appcache/appcache_backend_impl.h
   A /trunk/src/webkit/appcache/appcache_frontend_impl.cc
   A /trunk/src/webkit/appcache/appcache_frontend_impl.h
   A /trunk/src/webkit/appcache/appcache_interfaces.cc
   A /trunk/src/webkit/appcache/appcache_interfaces.h
   A /trunk/src/webkit/appcache/web_application_cache_host_impl.cc
   A /trunk/src/webkit/appcache/web_application_cache_host_impl.h
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/media/media_resource_loader_bridge_factory.cc
   M /trunk/src/webkit/glue/media/media_resource_loader_bridge_factory.h
   M /trunk/src/webkit/glue/media/simple_data_source.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/unittest_test_server.h
   D /trunk/src/webkit/glue/webappcachecontext.cc
   D /trunk/src/webkit/glue/webappcachecontext.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   A /trunk/src/webkit/tools/test_shell/simple_appcache_system.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc
   M /trunk/src/webkit/webkit.gyp

Retrofit the pre-existing appache message dispatching with the new WebKit APIs and concrete classes defined in our new appcache library, and get rid of the old files.

There are many files in the CL, mostly to pickup constant values now defined in our new appcache library, and to reflect a terminilogy change (from 'context' to 'host').

TEST=some existing unit tests apply
BUG=none

Review URL: http://codereview.chromium.org/170003
------------------------------------------------------------------------
r24020 | erikkay@chromium.org | 2009-08-21 23:38:23 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/api_test.js
   M /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js

handle index from bookmarks API properly
BUG=19866
TEST=ExtensionApiTest.Bookmarks

Review URL: http://codereview.chromium.org/173220
------------------------------------------------------------------------
r24015 | rvargas@google.com | 2009-08-21 23:29:13 +0200 (Fri, 21 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc

Http cache: Enable experimental support for byte range requests.

Requires --enable-byte-range-support

BUG=12258
TEST=covered by unit tests.

Review URL: http://codereview.chromium.org/173173
------------------------------------------------------------------------
r24011 | davemoore@chromium.org | 2009-08-21 23:11:55 +0200 (Fri, 21 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/panel_controller.cc

If a window is moving in response to a mouse motion event,
you can't just convert the relative coords from the event
to the screen because you don't know if your View's position
relative to the screen may or may not have changed. You need
the screen coordinates from the event itself. This change
uses gdk_get_current_event() to get the event so we can get the screen coords from it
Review URL: http://codereview.chromium.org/173213
------------------------------------------------------------------------
r24010 | mattm@chromium.org | 2009-08-21 23:11:37 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/languages_page_gtk_unittest.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Gtk: Add spellchecking options.

BUG=13524
TEST=spellchecking options behave like in windows.

Review URL: http://codereview.chromium.org/173112
------------------------------------------------------------------------
r24008 | mattm@chromium.org | 2009-08-21 23:08:08 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/process_singleton_dialog.cc
   A /trunk/src/chrome/browser/gtk/process_singleton_dialog.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Gtk: Add error dialog when profile was in use on a different computer.

BUG=17549
TEST=see bug

Review URL: http://codereview.chromium.org/173222
------------------------------------------------------------------------
r24006 | pinkerton@chromium.org | 2009-08-21 22:58:41 +0200 (Fri, 21 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm

Ensure we don't show the icon when setting the icon view explicitly.
BUG=18359
TEST=create a ton of tabs, tabs that are still loading or have favicons should not show the throbber/icon once the tab is too small even though it's still going. Ensure that favicons still show up when tab is correctly sized.
Review URL: http://codereview.chromium.org/174238
------------------------------------------------------------------------
r24003 | mark@chromium.org | 2009-08-21 22:24:17 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc

Disable ErrorPageTest.Page404 on Linux.  It's flaky.  ph is working on it.

TEST=yes
BUG=19361
Review URL: http://codereview.chromium.org/173219
------------------------------------------------------------------------
r24001 | estade@chromium.org | 2009-08-21 21:57:00 +0200 (Fri, 21 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h

Findbar stuff:

- change dialog shape correctly when theme changes
- vertically center the match label in gtk theme mode
- update the match label colors when theme changes

BUG=19726

Review URL: http://codereview.chromium.org/173176
------------------------------------------------------------------------
r23998 | mattm@chromium.org | 2009-08-21 21:48:39 +0200 (Fri, 21 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/net/ssl_config_service_manager.h
   D /trunk/src/chrome/browser/net/ssl_config_service_manager_defaults.cc
   M /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   A /trunk/src/chrome/browser/net/ssl_config_service_manager_system.cc (from /trunk/src/chrome/browser/net/ssl_config_service_manager_win.cc:23757)
   D /trunk/src/chrome/browser/net/ssl_config_service_manager_win.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_win.cc
   M /trunk/src/net/base/ssl_config_service_win_unittest.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Cleanups for SSLConfigService and SSLConfigServiceManager.

Make SSLConfig.rev_checking_enable default to true (which also affects the defaults set by SSLConfigServicePref.)

Add static SSLConfigService::CreateSystemSSLConfigService which creates a standalone SSLConfigService (either SSLConfigServiceWin or SSLConfigServiceDefaults.)

Use CreateSystemSSLConfigService in fetch_client and test_shell_request_context.

Merge SSLConfigServiceManagerWin and SSLConfigServiceManagerDefaults into SSLConfigServiceManagerSystem, which uses CreateSystemSSLConfigService.

BUG=11507,19290
TEST=only visible change should be linux defaults to having rev checking option enabled.

Review URL: http://codereview.chromium.org/173097
------------------------------------------------------------------------
r23997 | mpcomplete@chromium.org | 2009-08-21 21:46:46 +0200 (Fri, 21 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/notification_type.h

Load extensions that have their manifest in the Prefs on the UI thread.

There is some migration code for loading old extensions which we do on the UI
thread as well, for simplicity. This will only happen the first time the user
starts Chrome, so I think it's OK.

Also cleaned up the EXTENSIONS_LOADED notification to send out a single
extension, instead of a 1-element list of extensions.

BUG=18293
TEST=loading extensions should still work

Review URL: http://codereview.chromium.org/174208
------------------------------------------------------------------------
r23995 | amit@chromium.org | 2009-08-21 21:03:50 +0200 (Fri, 21 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

InitNavigationInfo only if there's a valid entry

Automation can send information about an entry only if it exists.
Handle the case that during early loading there's no navigation
entry and we can avoid sending navigation information.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/174225
------------------------------------------------------------------------
r23993 | idanan@chromium.org | 2009-08-21 20:57:08 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.h

Cleanup Unused Includes

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/173210
------------------------------------------------------------------------
r23992 | jhawkins@chromium.org | 2009-08-21 20:52:44 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/browser/automation/automation_provider_gtk.cc
   A /trunk/src/chrome/browser/automation/automation_provider_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Implement SetWindowBounds and SetWindowVisible in AutomationProvider for Linux.

BUG=16616
TEST=covered by automation tests
Review URL: http://codereview.chromium.org/174195
------------------------------------------------------------------------
r23981 | jhawkins@chromium.org | 2009-08-21 20:07:17 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

coverity: Make sure we have a profile before potentially adding the Crashed infobar.

CID=5723
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165494
------------------------------------------------------------------------
r23979 | jeremy@chromium.org | 2009-08-21 20:05:55 +0200 (Fri, 21 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   D /trunk/src/chrome/browser/importer/firefox_importer_unittest_messages_internal.h
   D /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils.h
   D /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.mm
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.mm
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/data/firefox2_nss_mac/README
   D /trunk/src/chrome/test/data/firefox2_nss_mac/libfreebl3.dylib
   D /trunk/src/chrome/test/data/firefox2_nss_mac/libnspr4.dylib
   D /trunk/src/chrome/test/data/firefox2_nss_mac/libnss3.dylib
   D /trunk/src/chrome/test/data/firefox2_nss_mac/libplc4.dylib
   D /trunk/src/chrome/test/data/firefox2_nss_mac/libplds4.dylib
   D /trunk/src/chrome/test/data/firefox2_nss_mac/libsoftokn3.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/README
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libfreebl3.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libnspr4.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libnss3.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libnssdbm3.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libnssutil3.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libplc4.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libplds4.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libsoftokn3.dylib
   D /trunk/src/chrome/test/data/firefox3_nss_mac/libsqlite3.dylib
   M /trunk/src/ipc/ipc_sync_message_unittest.h
   M /trunk/src/ipc/ipc_tests.cc

Revert "Bring up Firefox Password Import Unittest on OS X."

This reverts commit 63381b4554b1190c8a87583a5c5f403815e44e83.
------------------------------------------------------------------------
r23975 | pinkerton@chromium.org | 2009-08-21 19:52:59 +0200 (Fri, 21 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Make sure we correctly stop DownloadItemControllers from observering view resize events when they are removed from the controller list.
BUG=19958
TEST=download things and use the dropdown to remove them from the list, make sure nothing bad happens.
Review URL: http://codereview.chromium.org/174228
------------------------------------------------------------------------
r23974 | phajdan.jr@chromium.org | 2009-08-21 19:49:46 +0200 (Fri, 21 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Disable flaky ShowModalDialogTest.BasicTest

TBR=jam

http://crbug.com/17806

Review URL: http://codereview.chromium.org/173204
------------------------------------------------------------------------
r23973 | idanan@chromium.org | 2009-08-21 19:47:08 +0200 (Fri, 21 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_observer.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Send notice for blackisted non-visual resources

This is just the piping to call into the blocked_popup_container
(which shall be later renamed and expanded to a generalized blocked
resource container) from the browser's request context.

BUG=16932
TEST=none

Review URL: http://codereview.chromium.org/171109
------------------------------------------------------------------------
r23971 | jeremy@chromium.org | 2009-08-21 19:27:27 +0200 (Fri, 21 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   A /trunk/src/chrome/browser/importer/firefox_importer_unittest_messages_internal.h
   A /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils.h
   A /trunk/src/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.mm
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.mm
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/firefox2_nss_mac
   A /trunk/src/chrome/test/data/firefox2_nss_mac/README
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libfreebl3.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libnspr4.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libnss3.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libplc4.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libplds4.dylib
   A /trunk/src/chrome/test/data/firefox2_nss_mac/libsoftokn3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac
   A /trunk/src/chrome/test/data/firefox3_nss_mac/README
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libfreebl3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnspr4.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnss3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnssdbm3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libnssutil3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libplc4.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libplds4.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libsoftokn3.dylib
   A /trunk/src/chrome/test/data/firefox3_nss_mac/libsqlite3.dylib
   M /trunk/src/ipc/ipc_sync_message_unittest.h
   M /trunk/src/ipc/ipc_tests.cc

Bring up Firefox Password Import Unittest on OS X.

The NSSDecrptor class needs to be run in a child process on OS X, so we need to do some fancy footwork in the form of a bridge class.

Also a few small fixes for surrounding code.
BUG=18775
TEST=none

Review URL: http://codereview.chromium.org/174206
------------------------------------------------------------------------
r23964 | rohitrao@chromium.org | 2009-08-21 18:23:40 +0200 (Fri, 21 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm

[Mac] Omnibox keyword, keyword hint, and search hint support.

BUG=http://crbug.com/10944
BUG=http://crbug.com/10943
BUG=http://crbug.com/12285

TEST=With empty field, should see "Type to search" in light text on
the RHS of the omnibox.  Type "google" and should see "Press [Tab] to
search Google" in light text on the RHS.  Hit TAB, should see a
rounded [Search Google:] item on the left and the cursor is now right
of that.  Popup should show "Keyword:" in some entries.

Patch by shess@chromium.org.
Review URL: http://codereview.chromium.org/173194
------------------------------------------------------------------------
r23962 | pfeldman@chromium.org | 2009-08-21 18:04:14 +0200 (Fri, 21 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js

DevTools: Restore devtools sanity console tests.
BUG=18786

Review URL: http://codereview.chromium.org/174220
------------------------------------------------------------------------
r23959 | phajdan.jr@chromium.org | 2009-08-21 17:32:52 +0200 (Fri, 21 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc

Move some waiting from AutomationProxy to AutomationProvider.

This way it can wait properly and not poll.

TEST=Covered by ui_tests.
BUG=none

Review URL: http://codereview.chromium.org/173158
------------------------------------------------------------------------
r23958 | amanda@chromium.org | 2009-08-21 17:30:06 +0200 (Fri, 21 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

If there's no actual window (for example, in some unit tests), don't try to
paint to it.  Build fix.
BUG=none
TEST=none
TBR=rohitrao

Review URL: http://codereview.chromium.org/174224
------------------------------------------------------------------------
r23957 | mhm@chromium.org | 2009-08-21 17:15:16 +0200 (Fri, 21 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/third_party/hunspell
   M /trunk/src/chrome/tools/convert_dict/convert_dict.cc

Pull the entire hunspell tree and place it in depsBUG=14756TEST=Compiled Chromium, ran tests
Review URL: http://codereview.chromium.org/174127
------------------------------------------------------------------------
r23955 | amanda@chromium.org | 2009-08-21 16:37:57 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Change backing store constructor so that it bases the CGLayer on the parent
window's characteristics, and change DidScrollRect to do immediate painting.
BUG=14823
TEST=scrolling should appear slightly smoother on some machines
Review URL: http://codereview.chromium.org/174223
------------------------------------------------------------------------
r23954 | pinkerton@chromium.org | 2009-08-21 16:19:09 +0200 (Fri, 21 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller_unittest.mm

Make the page info window remember its placement origin on the Mac
* Store x/y origin in the local state PrefService
* Offset new windows when creating them so they don't overlap
* Add a unit test for remembering window placement
* Refactor PageInfoWindowControllerTest to make use of SetUp()
Patch from Robert Sesek (rsesek@chromium.org)
BUG=none
TEST=Open a page info window and move it. Open another and it should open in the
new location.
------------------------------------------------------------------------
r23953 | sky@chromium.org | 2009-08-21 16:11:15 +0200 (Fri, 21 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Make the main menu button only show if you pass in a command line
switch.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/174221
------------------------------------------------------------------------
r23947 | mhm@chromium.org | 2009-08-21 07:00:28 +0200 (Fri, 21 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/third_party/hunspell (from /trunk/src/chrome/third_party/hunspell:23945)

Reverting 23946.
Review URL: http://codereview.chromium.org/173185
------------------------------------------------------------------------
r23946 | mhm@chromium.org | 2009-08-21 06:21:36 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/third_party/hunspell

Pull the entire hunspell tree and place it in deps

BUG=14756
TEST=Compiled Chromium, ran tests
Review URL: http://codereview.chromium.org/174127
------------------------------------------------------------------------
r23936 | cmasone@google.com | 2009-08-21 03:47:41 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/chromeos
   A /trunk/src/chrome/browser/chromeos/external_cookie_handler.cc
   A /trunk/src/chrome/browser/chromeos/external_cookie_handler.h
   A /trunk/src/chrome/browser/chromeos/external_cookie_handler_unittest.cc
   A /trunk/src/chrome/browser/chromeos/pipe_reader.cc
   A /trunk/src/chrome/browser/chromeos/pipe_reader.h
   A /trunk/src/chrome/browser/chromeos/pipe_reader_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

[Chrome OS] Adds support for injecting Corp cookies at startup

To support single-sign-on for Chrome OS, we need a way to inject cookies into Chrome.  In the case of session cookies, putting them into Chrome's cookie jar DB doesn't work.  This CL adds a command line flag that tells chrome the name of a Unix pipe to open, from which it can read said cookies.

Eventually, I want to replace this pipe-reading with an appropriate usage of DBus, but Chrome OS isn't there yet.  This CL adds the appropriate infrastructure, though, and the PipeReader class can later be replaced with something that pulls the cookies off DBus instead.
Review URL: http://codereview.chromium.org/174062
------------------------------------------------------------------------
r23935 | sky@chromium.org | 2009-08-21 03:39:29 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Adds prototype menu.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174200
------------------------------------------------------------------------
r23932 | thestig@chromium.org | 2009-08-21 03:24:55 +0200 (Fri, 21 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Uses the FilePath::CopyFile version that recieves FilePath instead of std::wstring.

BUG=None
TEST=None

Patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/164383

Review URL: http://codereview.chromium.org/174168
------------------------------------------------------------------------
r23930 | mattm@chromium.org | 2009-08-21 03:18:37 +0200 (Fri, 21 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_mac.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/result_codes.h

Make ProcessSingletonLinux check the hostname to avoid multiple uses of a profile over NFS.

In order to avoid the singleton socket filename from exceeding the max socket name length, the socket is just named "SingletonSocket" and a new file "SingletonLock" is used for the hostname&pid.

BUG=17549
TEST=see bug

Review URL: http://codereview.chromium.org/174041
------------------------------------------------------------------------
r23927 | agl@chromium.org | 2009-08-21 02:34:09 +0200 (Fri, 21 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/testing_browser_process.h

Don't show "Inspect Element" in the context menu if we can't inspect.

Ubuntu want to ship with the inspector files in a separate package and
having menu items which are broken isn't nice.

http://codereview.chromium.org/174162

------------------------------------------------------------------------
r23925 | ananta@chromium.org | 2009-08-21 02:26:53 +0200 (Fri, 21 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

We should only handle http and https in the URL job created to enable automation clients to
handle URL requests.

This fixes bug http://b/issue?id=2068725

Bug=2068725

Review URL: http://codereview.chromium.org/174197
------------------------------------------------------------------------
r23920 | estade@chromium.org | 2009-08-21 02:05:40 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable DevToolsSanityTest.TestShowScriptsTab, which has been flaky for quite a while.

TBR=pfeldman

Review URL: http://codereview.chromium.org/174203
------------------------------------------------------------------------
r23916 | phajdan.jr@chromium.org | 2009-08-21 01:36:46 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_browsertest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   D /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.cc
   D /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/data/mock-link-doctor.html
   D /trunk/src/chrome/test/data/mock-link-doctor.html.mock-http-headers
   M /trunk/src/chrome/test/in_process_browser_test.cc

Revert "Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness."

TBR=darin

Review URL: http://codereview.chromium.org/173165
------------------------------------------------------------------------
r23915 | kuchhal@chromium.org | 2009-08-21 01:26:37 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser_main_win.cc
   D /trunk/src/chrome/browser/views/uninstall_dialog.cc
   D /trunk/src/chrome/browser/views/uninstall_dialog.h
   A /trunk/src/chrome/browser/views/uninstall_view.cc
   A /trunk/src/chrome/browser/views/uninstall_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

Re-apply r23841 "During uninstall if Chrome is set as default"

BUG=14023
TEST=Make sure the option of choosing a different browser shows up during un

Review URL: http://codereview.chromium.org/174194
------------------------------------------------------------------------
r23913 | ananta@chromium.org | 2009-08-21 01:23:03 +0200 (Fri, 21 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

The HTTP response headers coming back from the automation URL job need to be normalized to be delimited
by '\0' instead of '\r\n'. This causes URLs like microsoft.com, etc to not render correctly in 
automation HTTP clients.

This fixes bug http://b/issue?id=2066632

Thanks to Eric Roman for his help in tracking this down.

Bug=2066632


Review URL: http://codereview.chromium.org/174132
------------------------------------------------------------------------
r23910 | mdm@chromium.org | 2009-08-21 01:14:57 +0200 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc

Linux: make the "change proxy settings" button able to start several proxy config utilities.
Currently it still only ever starts gnome-network-properties but it is now easy to update.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/174106
------------------------------------------------------------------------
r23906 | phajdan.jr@chromium.org | 2009-08-21 00:55:19 +0200 (Fri, 21 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_browsertest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   A /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.cc
   A /trunk/src/chrome/browser/net/url_request_mock_link_doctor_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/mock-link-doctor.html
   A /trunk/src/chrome/test/data/mock-link-doctor.html.mock-http-headers
   M /trunk/src/chrome/test/in_process_browser_test.cc

Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.

Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward.

TEST=Covered by ui_tests and browser_tests.
http://crbug.com/18365, http://crbug.com/19361

Review URL: http://codereview.chromium.org/174179
------------------------------------------------------------------------
r23903 | kuchhal@chromium.org | 2009-08-21 00:47:58 +0200 (Fri, 21 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc

Reapply r23840 - Also return bookmark index through bookmarks API.

Review URL: http://codereview.chromium.org/173155
------------------------------------------------------------------------
r23899 | jhawkins@chromium.org | 2009-08-21 00:43:55 +0200 (Fri, 21 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

gtk: Update the tooltip state whenever the tab is resized.

BUG=19754
TEST=Open a new window and browse to google.com.  Hover the mouse over the tab and notice that the tooltip does not display.  Open enough new tabs so that the google.com tab title is ellipsized.  Hover the mouse over the tab and notice that the tooltip displays.
Review URL: http://codereview.chromium.org/174188
------------------------------------------------------------------------
r23895 | estade@chromium.org | 2009-08-21 00:09:53 +0200 (Fri, 21 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc

Disable some blocked popup container tests to green the tree.

I will fix these later today.

http://code.google.com/p/chromium/issues/detail?id=19881

TBR=brg

Review URL: http://codereview.chromium.org/174182
------------------------------------------------------------------------
r23889 | scherkus@chromium.org | 2009-08-20 23:28:17 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc

Disable mute/unmute when media does not have an audio track.

BUG=18970
TEST=test matrix videos ending in 0 should have mute context menu disabled

Review URL: http://codereview.chromium.org/174018
------------------------------------------------------------------------
r23887 | pinkerton@chromium.org | 2009-08-20 23:25:42 +0200 (Thu, 20 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Don't abandon or cancel in-progress field editors when the window closes.
BUG=17864
TEST=contents of fields are saved regardless of in-progress editing.
Review URL: http://codereview.chromium.org/174166
------------------------------------------------------------------------
r23886 | jrg@chromium.org | 2009-08-20 23:24:29 +0200 (Thu, 20 Aug 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/BookmarkBubble.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_view.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_view.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_window.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bubble_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Bookmark STAR bubble.

BUG=http://crbug.com/14929
Sample image attached to bug.

TEST=Click the STAR to add a bookmark.
Watch bubble come up.  Title is "Bookmark added!"
Confirm fields are OK.
Switch tabs and see bubble go away.
Click STAR again.
Watch bubble come up.  Title is "Bookmark"
Make sure all the buttons work (Edit, Close, Remove).
Make sure you can change the title and parent folder.
Make sure "Choose another folder..." opens edit window.

Review URL: http://codereview.chromium.org/171016
------------------------------------------------------------------------
r23884 | jam@chromium.org | 2009-08-20 23:20:17 +0200 (Thu, 20 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Remove include of IPC headers from headers they crept into.  This slows down the build.
Review URL: http://codereview.chromium.org/174148
------------------------------------------------------------------------
r23880 | estade@chromium.org | 2009-08-20 23:16:51 +0200 (Thu, 20 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Linux: more interactive tests porting.

The most noteworthy change here is the implementation of SendMouseMove() and SendMouseClick() in ui_controls. I've combed the interwebs and I don't think it's possible to figure out the GdkWindow that is showing for a given (x,y) coordinate pair (except perhaps by delving into X), so we have to just send clicks to wherever the pointer lies. This is unfortunate in that it means we have to move the pointer, wait for it to get where it's going, and only then make the click. But on the bright side there's this super helpful function called gdk_display_warp_pointer() which makes moving the mouse a breeze.

BUG=19076

Review URL: http://codereview.chromium.org/174113
------------------------------------------------------------------------
r23879 | erg@google.com | 2009-08-20 23:14:52 +0200 (Thu, 20 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

GTK Theme: Fix corner offsets on the find bar.

http://crbug.com/19811

Review URL: http://codereview.chromium.org/173140
------------------------------------------------------------------------
r23878 | pkasting@chromium.org | 2009-08-20 22:54:58 +0200 (Thu, 20 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h

Fix compile error

------------------------------------------------------------------------
r23877 | brettw@chromium.org | 2009-08-20 22:50:12 +0200 (Thu, 20 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc

Disable the Bookmarks ExtensionAPITest becuase it is flaky.

Review URL: http://codereview.chromium.org/173149
------------------------------------------------------------------------
r23876 | pkasting@chromium.org | 2009-08-20 22:49:12 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h

Initialize all new booleans in unittest constructor.

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173148
------------------------------------------------------------------------
r23872 | brettw@chromium.org | 2009-08-20 22:40:01 +0200 (Thu, 20 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h

Fix uninitialized memory read in autocomplete tests.


Review URL: http://codereview.chromium.org/173142
------------------------------------------------------------------------
r23866 | tony@chromium.org | 2009-08-20 22:18:50 +0200 (Thu, 20 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Close the autocomplete popup when the user tries to move the
window with the custom frame, when the user tries to resize
the window with the custom frame, and when the window switches
between maximized/restored state.

BUG=19636

Review URL: http://codereview.chromium.org/174109

------------------------------------------------------------------------
r23863 | idana@chromium.org | 2009-08-20 22:05:07 +0200 (Thu, 20 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   D /trunk/src/chrome/browser/sync/personalization_strings.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp

Removed personalization_strings.h and moved all the strings into generated_resources.grd.

I'll take care of the Setup Wizard strings/resources in my next patch. 

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/173069
------------------------------------------------------------------------
r23860 | mark@chromium.org | 2009-08-20 21:57:30 +0200 (Thu, 20 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/meta_table_helper.cc

Fix gcc warning about possible unused variable experienced with Apple gcc 4.2
in an -O3 experiment.
Review URL: http://codereview.chromium.org/173124
------------------------------------------------------------------------
r23859 | pkasting@chromium.org | 2009-08-20 21:50:34 +0200 (Thu, 20 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h

Attempt to minimize omnibox flicker, without increasing lag too much.

This also updates a bunch of comments, mostly to keep terminology like "results" and "matches" consistent, occasionally to fix grammar or other issues.

BUG=18369
TEST=none
Review URL: http://codereview.chromium.org/173031
------------------------------------------------------------------------
r23854 | ericroman@google.com | 2009-08-20 21:34:59 +0200 (Thu, 20 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/test/data/reliability/known_crashes.txt

Check for NULL Profile::GetDefaultRequestContext().

This papers over a chrome-bot crash.

The problem is that the ChromeURLRequestContexts have a split life between the UI thread and IO thread.
Although conceptually they live on the IO thread, they are lazy-initialized on the UI thread, and are contained by a Profile which also lives on the UI thread.

What happens in this crash, is ResolveProxyMsgHelper (the class which handles IPCs from the plugin process for proxy resolving) calls Profile::GetDefaultRequestContext() to get at the main URLRequestContext from the IO thread. Well, during the shutdown sequence, ~ProfileImpl NULLs the default request context before the IO thread is torn down, so consumers on the IO thread may get NULL. Or even worse, might get a non-NULL pointer to a request context that has already been freed.

With this patch I hack past the NULL case.

Really we need a proper solution to managing URLRequestContexts split personality... I did a quick survey of the code and found other consumers that use GetDefaultRequestContext from the IO thread, so this bug may be happening elsewhere.

BUG=http://crbug.com/18358

Review URL: http://codereview.chromium.org/172085
------------------------------------------------------------------------
r23850 | ajwong@chromium.org | 2009-08-20 21:02:48 +0200 (Thu, 20 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/context_menu.h
   A /trunk/src/webkit/glue/media_player_action.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc

Move MediaPlayerAction out of context_menu.h into webview.h since it's really only used by webview.

Review URL: http://codereview.chromium.org/174143
------------------------------------------------------------------------
r23848 | mpcomplete@chromium.org | 2009-08-20 20:58:19 +0200 (Thu, 20 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.h
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   D /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/Current Version
   D /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version
   D /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/Current Version

Get rid of the extension's "Current Version" file.

The entire manifest.json value is now stored in the prefs file. This will
allow for quick extension checks on startup.

BUG=18293
TEST=Make sure installing/upgrading/uninstalling extensions works as expected.

Review URL: http://codereview.chromium.org/174036
------------------------------------------------------------------------
r23847 | kuchhal@chromium.org | 2009-08-20 20:55:37 +0200 (Thu, 20 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc

Revert "Also return bookmark index through bookmarks API."

Revert r23840

Review URL: http://codereview.chromium.org/173133
------------------------------------------------------------------------
r23845 | kuchhal@chromium.org | 2009-08-20 20:40:51 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser_main_win.cc
   A /trunk/src/chrome/browser/views/uninstall_dialog.cc
   A /trunk/src/chrome/browser/views/uninstall_dialog.h
   D /trunk/src/chrome/browser/views/uninstall_view.cc
   D /trunk/src/chrome/browser/views/uninstall_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

Revert "During uninstall if Chrome is set as default,"
allow user to choose another browser as default."

reverting r23841

Review URL: http://codereview.chromium.org/173131
------------------------------------------------------------------------
r23844 | kuchhal@chromium.org | 2009-08-20 20:30:21 +0200 (Thu, 20 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Disable two tests while I investigate why Purify doesnt like them.

BUG=19820

Review URL: http://codereview.chromium.org/174153
------------------------------------------------------------------------
r23841 | kuchhal@chromium.org | 2009-08-20 20:22:40 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser_main_win.cc
   D /trunk/src/chrome/browser/views/uninstall_dialog.cc
   D /trunk/src/chrome/browser/views/uninstall_dialog.h
   A /trunk/src/chrome/browser/views/uninstall_view.cc
   A /trunk/src/chrome/browser/views/uninstall_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

During uninstall if Chrome is set as default, allow user to choose another browser as default.

BUG=14023
TEST=Make sure the option of choosing a different browser shows up during uninstall (and works as intended) iff chrome is set as default browser.

Review URL: http://codereview.chromium.org/172080
------------------------------------------------------------------------
r23840 | kuchhal@chromium.org | 2009-08-20 20:20:17 +0200 (Thu, 20 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc

Also return bookmark index through bookmarks API.

Review URL: http://codereview.chromium.org/173074
------------------------------------------------------------------------
r23837 | tony@chromium.org | 2009-08-20 20:16:58 +0200 (Thu, 20 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h

Fix theme install on 64 bit chromium builds.

Extension signature sizes are always 4 bytes, not variable depending
on platform.

Review URL: http://codereview.chromium.org/173104

------------------------------------------------------------------------
r23836 | wtc@chromium.org | 2009-08-20 20:15:22 +0200 (Thu, 20 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Make new FTP the default on Windows.  Use the --wininet-ftp
command-line switch to select the old WinInet-based FTP
implementation.

R=phajdan.jr
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/173099
------------------------------------------------------------------------
r23834 | derat@chromium.org | 2009-08-20 20:11:35 +0200 (Thu, 20 Aug 2009) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox.

r23596 was the original attempt; r23714 reverted it.  Using
gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer
ownership of the GtkClipboard and appears to prevent it from
unhighlighting its text.

Tested as follows:
1. Select text in webkit and hit Ctrl-C; check that both the
   PRIMARY and CLIPBOARD selections contain it.
2. Click in the omnibox.  All of the text gets highlighted.
   Check that the PRIMARY selection contains the omnibox text and
   the CLIPBOARD selection contains the webkit text.
3. Type Ctrl-C and confirm that the CLIPBOARD selection now
   contains the omnibox text.
4. Copy webkit text back to both selections.
5. Type Ctrl-L.  The omnibox text gets highlighted but both
   selections still contain the webkit text.
6. Type Ctrl-C and confirm that both selections now contain the
   omnibox text.
7. Try hitting Ctrl-C again while the omnibox text is on the
   CLIPBOARD selection to make sure that a bizarre GTK crash
   doesn't occur (see comment in code).

BUG=19648
TESTED=see above

Review URL: http://codereview.chromium.org/173098
------------------------------------------------------------------------
r23833 | tim@chromium.org | 2009-08-20 20:08:16 +0200 (Thu, 20 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   D /trunk/src/chrome/browser/sync/personalization.cc
   D /trunk/src/chrome/browser/sync/personalization.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   D /trunk/src/chrome/browser/sync/resources/new_tab_personalization.html
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/single_client_live_bookmarks_sync_unittest.cc

Remove personalization.h/cc by putting things in final resting places

Review URL: http://codereview.chromium.org/173085
------------------------------------------------------------------------
r23829 | phajdan.jr@chromium.org | 2009-08-20 18:56:24 +0200 (Thu, 20 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix the compile for TOOLKIT_VIEWS.

TBR=tony

Review URL: http://codereview.chromium.org/174146
------------------------------------------------------------------------
r23828 | erg@google.com | 2009-08-20 18:49:21 +0200 (Thu, 20 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK Themes: Reapply r23734, fixing destruction order issues.

http://crbug.com/18856

Review URL: http://codereview.chromium.org/174100
------------------------------------------------------------------------
r23827 | phajdan.jr@chromium.org | 2009-08-20 18:47:13 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp

Add (incomplete) UI for creating application shortcuts on Linux

TEST=none
http://crbug.com/17251

Review URL: http://codereview.chromium.org/171082
------------------------------------------------------------------------
r23825 | arv@google.com | 2009-08-20 18:37:39 +0200 (Thu, 20 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Make sure that the window tooltip is within the browser viewport.

BUG=18534

TEST=Open a new window. Open several tabs in this window and then close
the window. An item representing this window should be shown on the new
tab page. Hover this item (or tab to it). The tooltip should be
repositioned so that it is not clipped by the window viewport.


Review URL: http://codereview.chromium.org/173100
------------------------------------------------------------------------
r23824 | arv@google.com | 2009-08-20 18:36:58 +0200 (Thu, 20 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html

NNTP: Remove the DownloadsHandler from the new tab page.

BUG=none

TEST=none

Review URL: http://codereview.chromium.org/174099
------------------------------------------------------------------------
r23822 | asargent@chromium.org | 2009-08-20 18:18:21 +0200 (Thu, 20 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/extensions/update_manifest.cc
   A /trunk/src/chrome/common/extensions/update_manifest.h
   A /trunk/src/chrome/common/extensions/update_manifest_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h

Do extensions update manifest XML parsing in a sandboxed process.

This involves moving the xml parsing code from static functions in 
extension_updater.cc to a UpdateManifest class, and switching from 
logging any errors directly to collecting them up and passing them 
across the IPC channel.


BUG=http://crbug.com/12677
TEST=extensions auto-update should still work correctly


Review URL: http://codereview.chromium.org/164541
------------------------------------------------------------------------
r23821 | rohitrao@chromium.org | 2009-08-20 18:11:54 +0200 (Thu, 20 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm

Various omnibox UI fixes:
* Truncate match contents to 70% of the available width, reserving 30% for the
description.
* Animate omnibox shrinkage.

BUG=14898
TEST=Omnibox should animate smaller, but not bigger/opened/closed.  Match
description should always be partially visible, if present.
Review URL: http://codereview.chromium.org/173002
------------------------------------------------------------------------
r23818 | mbelshe@google.com | 2009-08-20 17:44:33 +0200 (Thu, 20 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Change default memory model from MEDIUM to HIGH.
This will eliminate the workingsetsize reductions
that we currently do in the browser.

Memory usage will increase by about 25%.  But it should
alleviate swapping issues that some users are seeing.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/173057
------------------------------------------------------------------------
r23813 | avi@chromium.org | 2009-08-20 15:54:11 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Essentially revert r16636. We get no speedup from using CIImage and we are susceptible to random leaks.

BUG=http://crbug.com/18661
TEST=throbbers should work just fine

Review URL: http://codereview.chromium.org/171110
------------------------------------------------------------------------
r23807 | abarth@chromium.org | 2009-08-20 08:56:46 +0200 (Thu, 20 Aug 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Revert 23805.
------------------------------------------------------------------------
r23805 | abarth@chromium.org | 2009-08-20 07:28:31 +0200 (Thu, 20 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable the XSSAuditor by default.  Please watch out for compatibility issues.

Review URL: http://codereview.chromium.org/174013
------------------------------------------------------------------------
r23801 | sky@chromium.org | 2009-08-20 05:58:11 +0200 (Thu, 20 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   A /trunk/src/views/controls/menu/menu_controller.cc (from /trunk/src/views/controls/menu/chrome_menu.cc:23735)
   A /trunk/src/views/controls/menu/menu_controller.h (from /trunk/src/views/controls/menu/chrome_menu.h:23735)
   A /trunk/src/views/controls/menu/menu_delegate.h (from /trunk/src/views/controls/menu/chrome_menu.h:23735)
   A /trunk/src/views/controls/menu/menu_item_view.cc (from /trunk/src/views/controls/menu/chrome_menu.cc:23735)
   A /trunk/src/views/controls/menu/menu_item_view.h (from /trunk/src/views/controls/menu/chrome_menu.h:23735)
   A /trunk/src/views/controls/menu/menu_scroll_view_container.cc
   A /trunk/src/views/controls/menu/menu_scroll_view_container.h
   A /trunk/src/views/controls/menu/submenu_view.cc (from /trunk/src/views/controls/menu/chrome_menu.cc:23735)
   A /trunk/src/views/controls/menu/submenu_view.h (from /trunk/src/views/controls/menu/chrome_menu.h:23735)
   M /trunk/src/views/views.gyp

Splits the menu classes into individual files in anticipation of
porting them.

BUG=none
TEST=make sure to thorougly test bookmark menus on windows.

Review URL: http://codereview.chromium.org/173091
------------------------------------------------------------------------
r23792 | mark@chromium.org | 2009-08-20 03:20:35 +0200 (Thu, 20 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Make unit_tests UtilityProcessHostTest use the helper app on the Mac.

BUG=none, not worth it for this
TEST=unit_tests '--gtest_filter=UtilityProcessHostTest*' runs Chromium Helper,
     not Chromium.  No application icon should appear in the dock during this
     test.
Review URL: http://codereview.chromium.org/174061
------------------------------------------------------------------------
r23780 | phajdan.jr@chromium.org | 2009-08-20 01:52:26 +0200 (Thu, 20 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Try to shutdown the browser more peacefully before using more brutal methods.

Also, do proper cleanup before browser shutdown in MetricsService UI test.

I hope this will reduce the flakiness.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/173023
------------------------------------------------------------------------
r23776 | amit@chromium.org | 2009-08-20 01:14:26 +0200 (Thu, 20 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Support navigating to absolute index through automation.

Also, send more information in AutomationMsg_DidNavigate

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/165333
------------------------------------------------------------------------
r23775 | arv@google.com | 2009-08-20 01:05:56 +0200 (Thu, 20 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Limit the dragged item to the viewport boundaries.

BUG=16361, 15099

TEST=Drag the thumbnails on the new tab page and make sure that the
visual representation is never clipped. Also make sure that no new
scrollbars show up due to dragging.

Review URL: http://codereview.chromium.org/173090
------------------------------------------------------------------------
r23773 | vandebo@chromium.org | 2009-08-20 00:44:12 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc

When importing a lot of history, the NOTREACHED in VisitedLinkMaster::AddFingerprint is reached.  This causes an exit on debug builds, for production builds part of the history would silently not get imported.  The root cause is that the initial size of the hash table only considers one of the two sources of input.

BUG=none
TEST=VisitedLinkTest::BigImport

Review URL: http://codereview.chromium.org/164419
------------------------------------------------------------------------
r23771 | tony@chromium.org | 2009-08-20 00:42:38 +0200 (Thu, 20 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Cache the left and right tab curve images.  We were spending a lot
of time regenerating the images for all the tabs.  This speeds
up the time needed to paint a tab by about 30%.

This helps a bit, but we're still slow.  We need to calculate
damage rects and only redraw damage rects (most of the remaining
time is spent on painting to the canvas now).

BUG=15872

Review URL: http://codereview.chromium.org/174095

------------------------------------------------------------------------
r23770 | jam@chromium.org | 2009-08-20 00:41:10 +0200 (Thu, 20 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Renable ShowModalDialogTest test with a longer timeout.  Until we have a way of executing JS in the renderer from a ui test, we'll have to use hacks like this.
Review URL: http://codereview.chromium.org/165090
------------------------------------------------------------------------
r23769 | jam@chromium.org | 2009-08-20 00:40:57 +0200 (Thu, 20 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/test/data/reliability/known_crashes.txt

Fix the crash if a download starts before we have the plugin list.  The fix is to make ResourceDispatcherHost support a handler pausing a request in its OnResponseStarted callback.

Note I didn't find any way of testing the resource handler code, so I didn't know how to add a good test for this.

BUG=19414
Review URL: http://codereview.chromium.org/173037
------------------------------------------------------------------------
r23768 | jhawkins@chromium.org | 2009-08-20 00:40:25 +0200 (Thu, 20 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

gtk: Make sure we found the window corresponding to the XID of the window under the drag.

BUG=19552
TEST=Drag a tab up and out of the tab strip.  This should not crash.
Review URL: http://codereview.chromium.org/174091
------------------------------------------------------------------------
r23762 | jshin@chromium.org | 2009-08-19 23:52:15 +0200 (Wed, 19 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc

Add icu:: qualifiers to a couple of more files. They're missed in the previous CL.

BUG=8198
TEST=Building all targets succeed without an error. 
TBR=darin
Review URL: http://codereview.chromium.org/173076
------------------------------------------------------------------------
r23760 | derat@chromium.org | 2009-08-19 23:51:36 +0200 (Wed, 19 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Default to not using custom frame under Fluxbox.

BUG=19130
TESTED=checked that it compiles :-P

Review URL: http://codereview.chromium.org/173079
------------------------------------------------------------------------
r23757 | mattm@chromium.org | 2009-08-19 23:48:42 +0200 (Wed, 19 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   A /trunk/src/chrome/browser/net/ssl_config_service_manager.h
   A /trunk/src/chrome/browser/net/ssl_config_service_manager_defaults.cc
   A /trunk/src/chrome/browser/net/ssl_config_service_manager_pref.cc
   A /trunk/src/chrome/browser/net/ssl_config_service_manager_win.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h
   D /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   A /trunk/src/net/base/ssl_config_service_defaults.h
   D /trunk/src/net/base/ssl_config_service_unittest.cc
   A /trunk/src/net/base/ssl_config_service_win.cc (from /trunk/src/net/base/ssl_config_service.cc:22541)
   A /trunk/src/net/base/ssl_config_service_win.h (from /trunk/src/net/base/ssl_config_service.h:22541)
   A /trunk/src/net/base/ssl_config_service_win_unittest.cc (from /trunk/src/net/base/ssl_config_service_unittest.cc:22541)
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Pref-backed SSLConfigService for Linux.

Makes SSLConfigService into a ref-counted interface, and makes Profile own an SSLConfigServiceFactory which is used to create the SSLConfigService and pass it through the URLRequestContext on down to where it is actually used.

R=eroman,wtc
BUG=11507,19290
Review URL: http://codereview.chromium.org/165003
------------------------------------------------------------------------
r23750 | arv@google.com | 2009-08-19 23:31:42 +0200 (Wed, 19 Aug 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/app/theme/checkbox_black.png
   A /trunk/src/chrome/app/theme/checkbox_white.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Use checkbox menu items in the options menu to control which sections to show.

I also changed to use black text on white for the menu.

BUG=None

TEST=Hide and show the different sections on new tab page and makes
sure that the checkbox is correctly synced with the state.

Review URL: http://codereview.chromium.org/174035
------------------------------------------------------------------------
r23747 | davemoore@chromium.org | 2009-08-19 23:28:09 +0200 (Wed, 19 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Make popups on Chrome OS turn into foreground tabs when they
are too big
Review URL: http://codereview.chromium.org/174019
------------------------------------------------------------------------
r23744 | erg@google.com | 2009-08-19 23:21:27 +0200 (Wed, 19 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h

Revert "GTK Theme: Make inactive titlebar legible."

This reverts commit 872a67636100b790dd034fe502e585d6a6abe716
(r23734). Use of notifications is questionable.

TBR=estade

Review URL: http://codereview.chromium.org/174087
------------------------------------------------------------------------
r23741 | pinkerton@chromium.org | 2009-08-19 22:54:37 +0200 (Wed, 19 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Check the favicon and loading state when a tab is created in case its TabContents is from an existing browser (such as torn off from a drag).
BUG=18352
TEST=dragging a tab out with a favicon should keep the favicon. Creating new tabs should be unaffected. dragging a tab out with a throbber should show the throbber and change to the correct favicon.
Review URL: http://codereview.chromium.org/174074
------------------------------------------------------------------------
r23740 | thakis@chromium.org | 2009-08-19 22:47:26 +0200 (Wed, 19 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_item_cell.h
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/skia/ext/canvas_paint_mac.h

Add progress disks to os x download items. Some more spacing tweaks. Still not done.

BUG=18902
TEST=download something, note that a green disk appears, and disappears after some flashing after the download is done.

Review URL: http://codereview.chromium.org/174048
------------------------------------------------------------------------
r23739 | cira@chromium.org | 2009-08-19 22:45:14 +0200 (Wed, 19 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_file_util.h
   M /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_l10n_util.cc
   A /trunk/src/chrome/browser/extensions/extension_l10n_util.h
   A /trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

This change enables Chrome to load locale information for the extension. It detects default locale, and filters out all locales not supported
by Chrome or with invalid names/missing messages.

It also checks for folders that start with _ and are not in the reserved list.

We don't validate messages file with this CL.

Added support for loading supplied locale information to the extension_file_util, and detecting default locale.
Added new constants to extension class (_locales directory name, messages filename).
Added new error messages to _constants.
Added new unittests.

BUG=12131
TEST=There should be no visible changes, except in case of error when loading extension (e.g. create empty _locales folder and try loading).

Review URL: http://codereview.chromium.org/170015
------------------------------------------------------------------------
r23737 | jhawkins@chromium.org | 2009-08-19 22:41:20 +0200 (Wed, 19 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc

gtk: Release the reference to the startup custom pages model so that it's owned by the GtkTreeView and will be destroyed when the tree view is destroyed.

BUG=19670
TEST=Load chromium with a fresh profile.  Open and close the options window at least three times.  The browser should not crash.
Review URL: http://codereview.chromium.org/173038
------------------------------------------------------------------------
r23734 | erg@google.com | 2009-08-19 22:36:02 +0200 (Wed, 19 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h

GTK Theme: Make inactive titlebar legible.

I'm pretty certain we'll never be able to match the text color on custom popup
windows, but at the very least make it legible. Tested in both light and dark
themes.

http://crbug.com/18856

Review URL: http://codereview.chromium.org/173061
------------------------------------------------------------------------
r23732 | estade@chromium.org | 2009-08-19 22:34:00 +0200 (Wed, 19 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/base/keyboard_codes_linux.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc

Port more browser focus tests to linux.

Added a new test to make sure clicking sets focus, since I changed a lot of tests to programatically set focus instead of using clicking.

Also set the actual time on our synthetic key events. I'm still not sure this is necessary but would like to avoid subtle bugs.

Also get rid of the NineBox constructor that takes a theme provider and convert its callers to use cairo directly or the other NineBox constructor. This change was necessary because theme providers could go stale and then the NineBox would cause seg faults. Also, it was only being used for single images... and UniBox just sounds wrong.

Also fix extension shelf to paint its image with the correct x/y (noticeable only with certain themes). Remove the notification observer stuff from the extension shelf, as I don't think there is any action to be taken when the theme changes.

BUG=19076
BUG=19659
TEST=all the ported interactive ui tests (as well as all the already-working tests) pass.
TEST=(Linux) things still render correctly (frame image, drop shadows, find box, extension shelf)

Review URL: http://codereview.chromium.org/173030
------------------------------------------------------------------------
r23729 | phajdan.jr@chromium.org | 2009-08-19 22:32:58 +0200 (Wed, 19 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add automation call to wait for multiple navigations.

Convert one ErrorPage UI test to use it.

The rest of the tests will require more work.

TEST=Covered by ui_tests.
http://crbug.com/19361, http://crbug.com/19395

Review URL: http://codereview.chromium.org/174015
------------------------------------------------------------------------
r23722 | amanda@chromium.org | 2009-08-19 20:59:22 +0200 (Wed, 19 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   D /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_mac.mm (from /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc:23543)
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

Re-implement BackingStore on the Mac as a CGLayer instead of a Skia canvas,
to get better performance.  As a side effect, remove the ugly stopgap scrolling code.  Do not close 14823 with this fix, but it should help (primary motivation was improving the plugin drawing path).

Paul: review
rafael: please check the change to extension_tabs_module.cc
John, Rohit: FYI, comments welcome
BUG=14823,
TEST=scrolling and plugin performance should improve

Review URL: http://codereview.chromium.org/171054
------------------------------------------------------------------------
r23717 | phajdan.jr@chromium.org | 2009-08-19 20:00:55 +0200 (Wed, 19 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Revert "Add automation call to wait for multiple navigations."

Broke the page cyclers.

TBR=tony

Review URL: http://codereview.chromium.org/174065
------------------------------------------------------------------------
r23715 | thakis@chromium.org | 2009-08-19 18:14:26 +0200 (Wed, 19 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm

Load 16x16 icons for shelf.

BUG=18902
TEST=The 16x16 icons on the left of a download item look crisp.

Review URL: http://codereview.chromium.org/174049
------------------------------------------------------------------------
r23714 | derat@chromium.org | 2009-08-19 18:04:27 +0200 (Wed, 19 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Revert updating PRIMARY selection on Ctrl-C in omnibox.

This backs out r23596.  I'm pretty sure that it worked when I tested it
right before submitting, but it's totally breaking stuff now -- it looks
like when I update the PRIMARY selection, GTK notices that it's lost the
selection and automatically unhighlights the text in the omnibox, making
it impossible to use Ctrl-C to copy omnibox text to the clipboard. :-(

BUG=19648
TESTED=Hit Ctrl-L, Ctrl-C and confirmed that text remains highlighted and becomes CLIPBOARD selection.

Review URL: http://codereview.chromium.org/174058
------------------------------------------------------------------------
r23711 | phajdan.jr@chromium.org | 2009-08-19 17:07:18 +0200 (Wed, 19 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add automation call to wait for multiple navigations.

Convert one ErrorPage UI test to use it.

The rest of the tests will require more work.

TEST=Covered by ui_tests.
http://crbug.com/19361, http://crbug.com/19395

Review URL: http://codereview.chromium.org/174015
------------------------------------------------------------------------
r23709 | phajdan.jr@chromium.org | 2009-08-19 16:56:38 +0200 (Wed, 19 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/id_map.h (from /trunk/src/chrome/common/id_map.h:23707)
   A /trunk/src/base/id_map_unittest.cc (from /trunk/src/chrome/common/id_map_unittest.cc:23707)
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/app_cache/app_cache_context_impl.h
   M /trunk/src/chrome/common/app_cache/app_cache_dispatcher_host.h
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/db_message_filter.h
   D /trunk/src/chrome/common/id_map.h
   D /trunk/src/chrome/common/id_map_unittest.cc
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/render_view.h

Move IDMap back to base/ where it is needed.

TEST=Covered by base_unittests.
BUG=none

Review URL: http://codereview.chromium.org/173026
------------------------------------------------------------------------
r23706 | pinkerton@chromium.org | 2009-08-19 15:18:01 +0200 (Wed, 19 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller_unittest.mm

Give the test an autorelease pool so the dialog gets cleaned up at the end of the test.
Review URL: http://codereview.chromium.org/173019
------------------------------------------------------------------------
r23704 | pfeldman@chromium.org | 2009-08-19 14:27:35 +0200 (Wed, 19 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Re-enable devtools sanity tests.
TBR=mnaganov
Review URL: http://codereview.chromium.org/173053
------------------------------------------------------------------------
r23703 | hbono@chromium.org | 2009-08-19 11:22:56 +0200 (Wed, 19 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/test/chrome_process_util_linux.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.cc

Lands <http://codereview.chromium.org/165297> for thiago.farina@gmail.com.

R=me

From Thiago:

Replaces some TrimWhitespace with TrimWhitespaceASCII or TrimWhitespaceUTF8.

BUG=9851
TEST=run base_unittests.exe, unit_tests.exe and ui_tests.exe
Review URL: http://codereview.chromium.org/172039
------------------------------------------------------------------------
r23702 | hbono@chromium.org | 2009-08-19 10:35:17 +0200 (Wed, 19 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

A quick fix for Issue 19421.
This issue is caused by AutocompleteEditViewMac::SetText() that updates the value of an AutocompleteEditField instance while an input method is composing text. Same as Windows, NSTextView finishes an ongoing composition when we update the value of an AutocompleteEditField object.
To fix this issue, we check whether or not NSTextView has marked text and exit if it has.

BUG=19421 "Korean IME does not work in the omnibox"
TEST=Select Korean 2-set keyboard, type 'g', 'k', 's', 'r', 'm', 'f' keys, and verify we can see two Korean syllables.

+rohitrao for reviewers since shess is out for the week
Review URL: http://codereview.chromium.org/171103
------------------------------------------------------------------------
r23699 | ben@chromium.org | 2009-08-19 08:18:13 +0200 (Wed, 19 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/test_event_utils.mm

Try and fix the valgrind error. The CGEventRef wasn't being released.

BUG=none
TEST=none

TBR=jrg

Review URL: http://codereview.chromium.org/174047
------------------------------------------------------------------------
r23695 | mattm@chromium.org | 2009-08-19 06:48:24 +0200 (Wed, 19 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/languages_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/languages_page_gtk.h
   A /trunk/src/chrome/browser/gtk/options/languages_page_gtk_unittest.cc
   M /trunk/src/chrome/browser/language_order_table_model.cc
   M /trunk/src/chrome/browser/language_order_table_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_linux.txt

Gtk languages options page part 1: accept-languages configuration.

Move accept_language_list to l10n_util, use it for LanguagesPageGtk.

BUG=13524
TEST=You can view, reorder, remove and add accept-languages.

Review URL: http://codereview.chromium.org/174043
------------------------------------------------------------------------
r23693 | ben@chromium.org | 2009-08-19 05:52:11 +0200 (Wed, 19 Aug 2009) | 29 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/event_utils.h
   A /trunk/src/chrome/browser/cocoa/event_utils.mm
   A /trunk/src/chrome/browser/cocoa/event_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   A /trunk/src/chrome/browser/cocoa/test_event_utils.h
   A /trunk/src/chrome/browser/cocoa/test_event_utils.mm
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/cocoa_utils.h
   D /trunk/src/chrome/common/cocoa_utils.mm
   D /trunk/src/chrome/common/cocoa_utils_unittest.mm

This changelist represents the necessary merger of two others:

http://codereview.chromium.org/172082

Create new event_utils.h file for Cocoa-specific event to WindowOpenDisposition
cracking.

Hook this up to BookmarkBarController so that clicks to bookmark items use the
oracle function to determine where the bookmark should be opened.

BUG=17301
TEST=Cmd+Click etc on bookmark items should work. See bug and unit test
attached.

http://codereview.chromium.org/174021

Convert users of the "get last active browser, get selected tab contents, open
url" pattern to just call OpenURL on Browser directly.

Makes GetOrCreateTabbedBrowser public on Browser, and makes it static so it can
be called with a provided profile.

BUG=none
TEST=Try opening links from the bookmark/history menus on mac, with and without
an existing window open, with an active incognito window, etc. The links should
all open in the last active non-incognito window, or create a new non-incognito
window if none is open.

Review URL: http://codereview.chromium.org/173044
------------------------------------------------------------------------
r23690 | sky@chromium.org | 2009-08-19 05:33:44 +0200 (Wed, 19 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/drop_helper.cc
   A /trunk/src/views/widget/drop_target_gtk.cc (from /trunk/src/views/widget/drop_target_gtk.cc:23657)
   A /trunk/src/views/widget/drop_target_gtk.h (from /trunk/src/views/widget/drop_target_gtk.h:23657)
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Relands drop support:

Adds drop support for views on gtk. As X lazily provides drop data I
needed to tweak the views API a bit.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/173025
------------------------------------------------------------------------
r23686 | jeremy@chromium.org | 2009-08-19 04:29:36 +0200 (Wed, 19 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   A /trunk/src/chrome/browser/first_run_migration_mac_unittest.mm
   D /trunk/src/chrome/browser/google_update_settings_linux.cc
   D /trunk/src/chrome/browser/google_update_settings_linux_unittest.cc
   M /trunk/src/chrome/browser/google_update_settings_mac.mm
   D /trunk/src/chrome/browser/google_update_settings_mac_unittest.mm
   A /trunk/src/chrome/browser/google_update_settings_posix.cc (from /trunk/src/chrome/browser/google_update_settings_linux.cc:23685)
   A /trunk/src/chrome/browser/google_update_settings_posix_unittest.cc (from /trunk/src/chrome/browser/google_update_settings_linux_unittest.cc:23685)
   M /trunk/src/chrome/chrome.gyp

Make Mac first run store sentinel in Profile directory.

* Added code to migrate from previous defaults-based first run.
* Renamed linux_guid -> posix_guid.
BUG=19260
TEST=Open current official release and go through first run UI, then open a release compiled with this patch.  First run UI should not be displayed again.
TEST=First Run UI should only be displayed once on first run and not anew on each launch.

Review URL: http://codereview.chromium.org/173020
------------------------------------------------------------------------
r23683 | mattm@chromium.org | 2009-08-19 04:09:01 +0200 (Wed, 19 Aug 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/language_combobox_model.cc (from /trunk/src/chrome/browser/views/options/language_combobox_model.cc:23611)
   A /trunk/src/chrome/browser/language_combobox_model.h (from /trunk/src/chrome/browser/views/options/language_combobox_model.h:23611)
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   D /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   D /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/chrome.gyp

Move LanguageComboboxModel to chrome/browser

BUG=13524
TEST=none

Review URL: http://codereview.chromium.org/172083
------------------------------------------------------------------------
r23676 | rafaelw@chromium.org | 2009-08-19 00:59:25 +0200 (Wed, 19 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/api_index.html
   M /trunk/src/chrome/common/extensions/docs/background_pages.html
   M /trunk/src/chrome/common/extensions/docs/bookmarks.html
   M /trunk/src/chrome/common/extensions/docs/content_scripts.html
   M /trunk/src/chrome/common/extensions/docs/devguide.html
   M /trunk/src/chrome/common/extensions/docs/extension.html
   M /trunk/src/chrome/common/extensions/docs/getstarted.html
   M /trunk/src/chrome/common/extensions/docs/index.html
   M /trunk/src/chrome/common/extensions/docs/js/api_page_generator.js
   M /trunk/src/chrome/common/extensions/docs/manifest.html
   M /trunk/src/chrome/common/extensions/docs/overview.html
   M /trunk/src/chrome/common/extensions/docs/packaging.html
   M /trunk/src/chrome/common/extensions/docs/pageActions.html
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/common/extensions/docs/template/api_template.html
   M /trunk/src/chrome/common/extensions/docs/toolstrip.html
   M /trunk/src/chrome/common/extensions/docs/windows.html
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/browsertest
   A /trunk/src/chrome/test/data/extensions/browsertest/last_error
   A /trunk/src/chrome/test/data/extensions/browsertest/last_error/manifest.json
   A /trunk/src/chrome/test/data/extensions/browsertest/last_error/toolstrip.html

Async extension callbacks now always fire and set chrome.extension.lastError on error.

Includes doc changes for extension.lastError and a browsertest.

BUG=17381

Review URL: http://codereview.chromium.org/172078
------------------------------------------------------------------------
r23675 | mpcomplete@chromium.org | 2009-08-19 00:53:47 +0200 (Wed, 19 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h

Show the extension install UI when the user clicks Reenable for a disabled-on-upgrade extension.

Also fix a couple misc bugs with disabled extensions:
- Fix a crash when trying to reenable an uninstalled disabled extension.
- Fix a bug where upgrading a disabled extension would reenable it.

BUG=12140
TEST=no

Review URL: http://codereview.chromium.org/172006
------------------------------------------------------------------------
r23670 | paul@chromium.org | 2009-08-19 00:36:42 +0200 (Wed, 19 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h

Wait for the SafeBrowsing check to complete before following
a redirect.

BUG=6442
TEST=None

Review URL: http://codereview.chromium.org/165508
------------------------------------------------------------------------
r23669 | tim@chromium.org | 2009-08-19 00:36:05 +0200 (Wed, 19 Aug 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/sync/glue/change_processor.cc (from /trunk/src/chrome/browser/sync/profile_sync_service.cc:23505)
   A /trunk/src/chrome/browser/sync/glue/change_processor.h (from /trunk/src/chrome/browser/sync/profile_sync_service.h:23505)
   M /trunk/src/chrome/browser/sync/glue/model_associator.cc
   M /trunk/src/chrome/browser/sync/glue/model_associator.h
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   M /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc

Move model operations from ProfileSyncService to ChangeProcessor.

TEST=ProfileSyncServiceTest, sync integration tests

Review URL: http://codereview.chromium.org/172040
------------------------------------------------------------------------
r23667 | paul@chromium.org | 2009-08-19 00:29:58 +0200 (Wed, 19 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc

Show or open downloaded items on the UI thread for Mac. This is
required because NSWorkspace, which is used for the open or show
operation, must be called on the main thread.

BUG=19447 (http://crbug.com/19447)
TEST=Repro steps fully described in the bug report.
     
Review URL: http://codereview.chromium.org/172074
------------------------------------------------------------------------
r23665 | arv@google.com | 2009-08-19 00:23:12 +0200 (Wed, 19 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Show more items in the recently closed section.

Also fix the tooltip for the items.

BUG=None

TEST=Open 5 or more tabs with long window titles. Close them and go to
the new tab page. The recencly closed section should show at least 5
items.

Review URL: http://codereview.chromium.org/174008
------------------------------------------------------------------------
r23658 | sky@chromium.org | 2009-08-18 23:44:19 +0200 (Tue, 18 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/drop_helper.cc
   D /trunk/src/views/widget/drop_target_gtk.cc
   D /trunk/src/views/widget/drop_target_gtk.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Reverts recent patch as broke build on toolkit_views.

TBR=ben
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174023
------------------------------------------------------------------------
r23653 | sky@chromium.org | 2009-08-18 23:24:34 +0200 (Tue, 18 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/drop_helper.cc
   A /trunk/src/views/widget/drop_target_gtk.cc
   A /trunk/src/views/widget/drop_target_gtk.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Adds drop support for views on gtk. As X lazily provides drop data I
needed to tweak the views API a bit.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165407
------------------------------------------------------------------------
r23647 | paul@chromium.org | 2009-08-18 23:11:47 +0200 (Tue, 18 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Synthesize an NSEvent for handling drag events, since we
can't guarantee that by the time we start dragging, the
application's current event is a valid drag.

BUG=16811 (http://crbug.com/16811)
TEST=Drag operations should all still work.

Review URL: http://codereview.chromium.org/171067
------------------------------------------------------------------------
r23644 | phajdan.jr@chromium.org | 2009-08-18 22:10:37 +0200 (Tue, 18 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   D /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   D /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Revert "Fix "crashed extension" infobar browser crashes."

TBR=cevans

Review URL: http://codereview.chromium.org/173014
------------------------------------------------------------------------
r23639 | nick@chromium.org | 2009-08-18 19:25:09 +0200 (Tue, 18 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome.dll.deps
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/tools/build/win/FILES

syncapi shared lib: always.  Build a stub
if the binaries are not available.  For
a Chrome-branded release, pull the binaries
from elsewhere.

For a release where CHROME_PERSONALIZATION is disabled,
(e.g. Mac and Linux), we needn't build this.
TEST=build and run with a variety of commandline flags + clobber try server
BUG=none

Review URL: http://codereview.chromium.org/171096
------------------------------------------------------------------------
r23638 | erg@google.com | 2009-08-18 19:08:54 +0200 (Tue, 18 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Implement chrome.tabs.captureVisibleTab for linux

http://crbug.com/19532

Review URL: http://codereview.chromium.org/172072
------------------------------------------------------------------------
r23636 | rohitrao@chromium.org | 2009-08-18 18:58:08 +0200 (Tue, 18 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/cocoa_utils.h
   A /trunk/src/chrome/common/cocoa_utils.mm
   A /trunk/src/chrome/common/cocoa_utils_unittest.mm

Add modifier key support for window open dispositions throught the Mac UI

* Add cocoa_utils.{h,mm} and a unit test for the one method it contains:
  event_utils::DispositionFromEventFlags().
* Add modifier key support to the history menu, bookmark menu, infobars,
  bookmark bar, and Omnibox.

BUG=17912,17301
TEST=When using the aforementioned UI elements, Cmd should open in new
foreground tab, Cmd+Shift should open in new background tab, and Shift should
open in a new window.

Patch by Robert Sesek.
------------------------------------------------------------------------
r23634 | phajdan.jr@chromium.org | 2009-08-18 18:37:52 +0200 (Tue, 18 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc

Cleanup in AutomationProvider's navigation observer.

Remove unnecessary parameters. Instead of making the callers customize the return codes,
just standardize on already present constants.

This is a preparation needed before implementing waiting for multiple navigations.

TEST=Covered by ui_tests.
http://crbug.com/19395

Review URL: http://codereview.chromium.org/171064
------------------------------------------------------------------------
r23631 | erikkay@chromium.org | 2009-08-18 18:07:55 +0200 (Tue, 18 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/renderer_host/file_system_accessor_unittest.cc
   M /trunk/src/chrome/installer/setup/setup_util_unittest.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/master_preferences_unittest.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/glue/plugins/plugin_stream_posix.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc

Renames the function CreateTemporaryFilename to CreateTemporaryFile and track down all callers, also removes the
deprecated function that uses std::wstring.

BUG=3078 (http://crbug.com/3078)
TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests.

Review URL: http://codereview.chromium.org/164537
Patch from Thiago Farina.
------------------------------------------------------------------------
r23628 | phajdan.jr@chromium.org | 2009-08-18 17:40:32 +0200 (Tue, 18 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   A /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Fix "crashed extension" infobar browser crashes.

This is a general rework of how "crashed extension" infobar works
and how the extension is actually recovered after the crash.

TEST=See bug.
http://crbug.com/15888

Review URL: http://codereview.chromium.org/164151
------------------------------------------------------------------------
r23627 | sky@chromium.org | 2009-08-18 17:37:20 +0200 (Tue, 18 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/gtk_dnd_util.cc (from /trunk/src/chrome/browser/gtk/gtk_dnd_util.cc:23183)
   A /trunk/src/app/gtk_dnd_util.h (from /trunk/src/chrome/browser/gtk/gtk_dnd_util.h:23183)
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   D /trunk/src/chrome/browser/gtk/gtk_dnd_util.cc
   D /trunk/src/chrome/browser/gtk/gtk_dnd_util.h
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Moves GtkDndUtil into app.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165423
------------------------------------------------------------------------
r23626 | brettw@chromium.org | 2009-08-18 17:36:15 +0200 (Tue, 18 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/compact_navigation_bar.cc
   M /trunk/src/chrome/browser/views/compact_navigation_bar.h
   M /trunk/src/chrome/browser/views/frame/status_area_view.cc
   M /trunk/src/chrome/browser/views/frame/status_area_view.h

Bugfixes and enhancements to the compact nav bar and the status area.

This makes the compact navigation bar off by default at the request of Nicolas.
It can be enabled with --compact-nav on the command line. It also adds
different tab opening options when this feature is enabled. They are accessible
from the app menu in the status area. The buttons now extend to the top of the
screen for easier clicking.

The status area is enabled whether or not the compact navigation bar is. I
fixed the background so it will appear unselected when the window loses focus,
and I fixed the time formatting to make the minutes always 2 digits.

The Chrome button is now hooked up and just opens a tab to a placeholder page.
Review URL: http://codereview.chromium.org/169001
------------------------------------------------------------------------
r23623 | brettw@chromium.org | 2009-08-18 16:49:36 +0200 (Tue, 18 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h

Remove ViewHostMsg_PluginMessage which was unused.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/171052
------------------------------------------------------------------------
r23622 | brettw@chromium.org | 2009-08-18 16:49:26 +0200 (Tue, 18 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/common/histogram_synchronizer.h

Remove RenderProcessHost::size(). With Pawel's change, size() isn't necessarily
correct, and it was badly named and needed fixing anyway.

This patch just removes it. There were a few debugging places that used it
which I just removed, since I think they're old and haven't been useful lately.

The non-trivial changes were in the histogram code, it now counts them slightly
differently.
Review URL: http://codereview.chromium.org/171051
------------------------------------------------------------------------
r23615 | ericroman@google.com | 2009-08-18 08:17:50 +0200 (Tue, 18 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/proxy/mock_proxy_resolver.h
   M /trunk/src/net/proxy/proxy_service.h

Remove an unused header from proxy_service.h.

Review URL: http://codereview.chromium.org/164545
------------------------------------------------------------------------
r23613 | jshin@chromium.org | 2009-08-18 07:12:29 +0200 (Tue, 18 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/app/gfx/text_elider.h
   M /trunk/src/app/gfx/text_elider_unittest.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/app/table_model.cc
   M /trunk/src/app/table_model.h
   M /trunk/src/base/file_util_icu.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/string_util_icu.cc
   M /trunk/src/base/time_format.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/net/base/net_util.cc

Use 'icu::' namespace explicitly throughout Chrome tree instead of relying on 'using namespace icu'.

This is Chrome's counterpart to the ICU header change that disables
'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece.

The webkit change (which is minor) will be dealt with in the webkit bugzilla.

This can go in before the ICU change/upgrade without affecting anything. 


BUG=8198
TEST=All the targets are built without an error on all platforms.

Review URL: http://codereview.chromium.org/171012
------------------------------------------------------------------------
r23612 | eroman@chromium.org | 2009-08-18 05:58:09 +0200 (Tue, 18 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Reference count ProxyService.

This is necessary since ProxyService is getting shared between chrome's url request contexts (off the record, media), and the current way it is being shared could result in free memory read/writes during shutdown.

This is a step towards fixing http://crbug.com/15289.

BUG=http://crbug.com/15289
TEST=The existing tests should continue to pass following this refactor.

Review URL: http://codereview.chromium.org/165430
------------------------------------------------------------------------
r23611 | estade@chromium.org | 2009-08-18 04:16:21 +0200 (Tue, 18 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_constants.h

more linux automation porting: SendKeyPressNotifyWhenDone

also change the interface for SimulateOSKeyPress()/SendKeyPress() to take a VKEY_ value (defined in base/keyboard_codes.h) rather than a VK_ value.

BUG=19076

Review URL: http://codereview.chromium.org/171079
------------------------------------------------------------------------
r23608 | mdm@chromium.org | 2009-08-18 04:06:13 +0200 (Tue, 18 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc

Linux: make the passwords and exceptions dialog box default size larger.
BUG=19433
TEST=obvious

Review URL: http://codereview.chromium.org/171077
------------------------------------------------------------------------
r23605 | paul@chromium.org | 2009-08-18 03:27:01 +0200 (Tue, 18 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h

Add the UI thread to the list of ChromeThreads.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/171088
------------------------------------------------------------------------
r23603 | mattm@chromium.org | 2009-08-18 03:04:45 +0200 (Tue, 18 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/combobox_model.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/combobox/native_combobox_win.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc

Factor out views::Combobox::Model so that it can be used cross-platform.

This removes the Combobox* source arg from the Model methods, which wasn't really used by anything.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165514
------------------------------------------------------------------------
r23597 | cevans@chromium.org | 2009-08-18 02:25:20 +0200 (Tue, 18 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc

Call the new FilePath API to make sure the untrusted sandboxed process is not
sending us paths with .. in them.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/171025
------------------------------------------------------------------------
r23596 | derat@chromium.org | 2009-08-18 02:25:09 +0200 (Tue, 18 Aug 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Update PRIMARY selection on omnibox copy-to-clipboard.

This brings us in line with Firefox's behavior.  Ctrl-L highlights
the URL but doesn't update the PRIMARY selection, so Ctrl-C is a
common* way to get the current location into PRIMARY so you can
middle-click somewhere else to paste it.

* I use it and a user mentioned that they do too. :-P

Tested as follows:

- highlight some text on the page to make it PRIMARY
- hit Ctrl-L and confirm that text on page is still PRIMARY
- hit Ctrl-C and confirm that location is now PRIMARY
- repeat, but this time hit the right arrow key between Ctrl-L
  and Ctrl-C to unhighlight the text first.  the text on the
  page should remain the PRIMARY selection

BUG=18403
TESTED=see above

Review URL: http://codereview.chromium.org/164539
------------------------------------------------------------------------
r23595 | erg@google.com | 2009-08-18 02:23:55 +0200 (Tue, 18 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

GTK Theme: Draw the GTK border around the entry in GTK them mode.

Also makes the label look native. I can't get the label inside the entry,
though.

http://crbug.com/17962

Review URL: http://codereview.chromium.org/172069
------------------------------------------------------------------------
r23591 | idana@chromium.org | 2009-08-18 01:03:21 +0200 (Tue, 18 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/sync/personalization_strings.h

Made the Sync UI work in the New New tab page.

There are no significant logic changes except the addition of a link which points to the web ui.

BUG=none

Review URL: http://codereview.chromium.org/172007
------------------------------------------------------------------------
r23588 | estade@chromium.org | 2009-08-18 00:53:06 +0200 (Tue, 18 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Temporarily disable a failing ui test.

TBR=eroman

------------------------------------------------------------------------
r23585 | estade@chromium.org | 2009-08-18 00:25:17 +0200 (Tue, 18 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Begin to port browser focus tests to linux.

TEST=interactive ui tests builds and runs and BrowserFocusTest.TabInitialFocus passes

Review URL: http://codereview.chromium.org/172059
------------------------------------------------------------------------
r23584 | erikkay@chromium.org | 2009-08-17 23:59:29 +0200 (Mon, 17 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc

cap the number of tabs in the backing store cache

BUG=19353
TEST=None

Review URL: http://codereview.chromium.org/165538
------------------------------------------------------------------------
r23583 | mark@chromium.org | 2009-08-17 23:55:55 +0200 (Mon, 17 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_linux.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/window_sizer_linux.cc
   M /trunk/src/chrome/browser/window_sizer_unittest.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h

Cleaning up lines longer than 80 chars under src/chrome/browser. 

Command:
awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0  } }' *.cc *.h

# recursive
find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) >
80 ) { print FILENAME, FNR, $0 } }' {} \;

Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>

BUG=None
TEST=None

Code review URL: http://codereview.chromium.org/164566
Review URL: http://codereview.chromium.org/171066
------------------------------------------------------------------------
r23577 | erikkay@chromium.org | 2009-08-17 22:57:14 +0200 (Mon, 17 Aug 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_apitest.cc
   A /trunk/src/chrome/browser/extensions/extension_apitest.h
   A /trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_test_api.cc
   A /trunk/src/chrome/browser/extensions/extension_test_api.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/api_test
   A /trunk/src/chrome/test/data/extensions/api_test/bookmarks
   A /trunk/src/chrome/test/data/extensions/api_test/bookmarks/manifest.json
   A /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.html
   A /trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js

An initial pass at structure to do end-to-end extension API tests.  I'll work on actually fleshing out some tests in the next CL.

Review URL: http://codereview.chromium.org/171032
------------------------------------------------------------------------
r23572 | phajdan.jr@chromium.org | 2009-08-17 22:13:53 +0200 (Mon, 17 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/visitedlink_event_listener.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/common/id_map.h
   A /trunk/src/chrome/common/id_map_unittest.cc

Refactor IDMap to support safe removing of elements during iteration.

TEST=Covered by unit_tests and other automated tests.
http://crbug.com/19202

Review URL: http://codereview.chromium.org/164518
------------------------------------------------------------------------
r23571 | pkasting@chromium.org | 2009-08-17 22:10:29 +0200 (Mon, 17 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Changes Live Search to Bing for en_US only.  A full worldwide review is in progress and we'll pick up the other countries eventually.

Added some temporary comments on the Bing entry since the way it's coexisting with the Live entries right now makes for a few slightly unusual bits.

BUG=13065
TEST=Search providers should show Bing and not Live Search, setting Bing to default should result in working Suggest and search functionality.
Review URL: http://codereview.chromium.org/171065
------------------------------------------------------------------------
r23568 | robertshield@chromium.org | 2009-08-17 21:50:04 +0200 (Mon, 17 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc

Fix for crash bug in PluginProcessHost::OnGetCookies - it likes like this can be called when we don't have a URLContext from which to return cookies. 

Previously we crashed, this patch just logs an error and returns an empty string instead. 

BUG=http://crbug.com/10706


Review URL: http://codereview.chromium.org/171050
------------------------------------------------------------------------
r23563 | jam@chromium.org | 2009-08-17 21:18:45 +0200 (Mon, 17 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/test/data/reliability/known_crashes.txt

Fix crash that could happen on shutdown if the ResourceMessageFilter tried to get the IO thread's message loop when it was going away.  Do the same acrobatics as in BufferedResourceHandler by going to the UI thread first, and doing refcounting manually.

Also fix an issue I saw by inspection in BufferedResourceHandler, where Release should be called at the end of the function.

BUG=19415
Review URL: http://codereview.chromium.org/171055
------------------------------------------------------------------------
r23550 | thakis@chromium.org | 2009-08-17 20:04:08 +0200 (Mon, 17 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Clean up download item look, part 1 of many.

BUG=18902
TEST=items look like buttons all the time, not only on hover. icon is 16x16 :-/. spacing slightly modified (not final yet).

Review URL: http://codereview.chromium.org/172030
------------------------------------------------------------------------
r23548 | paul@chromium.org | 2009-08-17 20:01:55 +0200 (Mon, 17 Aug 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/download_util_mac.h
   A /trunk/src/chrome/browser/cocoa/download_util_mac.mm
   A /trunk/src/chrome/browser/cocoa/download_util_mac_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Implement drag and drop of downloads for the Mac downloads page.

BUG=15776 (http://crbug.com/15776)
TEST=Download an item, open the download page, drag the icon of
     the download to the desktop.

Review URL: http://codereview.chromium.org/164459
------------------------------------------------------------------------
r23543 | pfeldman@chromium.org | 2009-08-17 10:55:05 +0200 (Mon, 17 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

DevTools: remove TODO on completed item.
BUG=19335
TBR=aa

Review URL: http://codereview.chromium.org/171036
------------------------------------------------------------------------
r23532 | finnur@chromium.org | 2009-08-16 17:20:44 +0200 (Sun, 16 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix potential crash in Browser::OpenURLAtIndex.

This is a bit of a Coverity nit, but if disposition
SUPPRESS_OPEN is ever passed in to this function,
it will crash because we try to call Focus on a
new_contents pointer that is null. I verified this
by hard coding the disposition as we open URLs.

BUG=17101
TEST=No significant change.

Review URL: http://codereview.chromium.org/155773
------------------------------------------------------------------------
r23515 | aa@chromium.org | 2009-08-15 07:39:50 +0200 (Sat, 15 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Undo disabled toolstrip test, now that upstream bug is fixed.

TBR=mpcomplete@chromium.org
BUG=19335
------------------------------------------------------------------------
r23512 | jam@chromium.org | 2009-08-15 04:50:19 +0200 (Sat, 15 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h

Fix reliability bot crashes after moving plugin loading to file thread.

The problem was that the BufferedResourceHandler could now be destructed on the file thread, if the task that it posted on the IO thread completed before the code on the file thread returned.  Solved this by doing manual refcounting.
Review URL: http://codereview.chromium.org/171015
------------------------------------------------------------------------
r23509 | mark@chromium.org | 2009-08-15 04:04:21 +0200 (Sat, 15 Aug 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_mac.h
   M /trunk/src/chrome/app/breakpad_mac.mm
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/DEPS
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Change breakpads on the helper processes to keep our rimZ clean.

Initialize crash reporting in helper processes such as the renderer process.
Renderer crash reporting stopped working in r23006 when multiple .app bundles
were introduced, because the stats collection and crash reporting preference
is presently accessed via NSUserDefaults, keyed on the bundle ID.  The main
browser process and helper processes have distinct bundle IDs.  In the new
scheme, only the main browser process consults this preference, and passes it
to helper processes in their command lines.

BUG=19204
TEST=When reporting is enabled, Breakpad should pick up browser and renderer
     process crashes;
     When reporting is enabled, renderer should not log messages like
         [mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(47)] Breakpad disabled;
     When reporting is disabled, browser and renderer should both log these
         messages.
Review URL: http://codereview.chromium.org/165546
------------------------------------------------------------------------
r23508 | estade@chromium.org | 2009-08-15 04:04:00 +0200 (Sat, 15 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.h

GTK: Change go button tooltip to be updated every time it is shown.

This simplifies the logic and fixes a couple of bugs (and probably more):
- the first time the tooltip is shown after a navigation, it was stale (showed "stop loading the page")
- the first time the tooltip is shown after the text of the omnibox is changed, it was stale

Also, don't hardcode "Google" as the name of the search provider.

BUG=12836

Review URL: http://codereview.chromium.org/171014
------------------------------------------------------------------------
r23505 | tim@chromium.org | 2009-08-15 03:19:11 +0200 (Sat, 15 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sync/personalization.cc
   M /trunk/src/chrome/browser/sync/personalization.h
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/sync/resources/setup_flow.html
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.cc
   M /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   M /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   M /trunk/src/chrome/test/testing_profile.h

Some personalization cleanup:
- Removes ProfilePersonalization (which is why the CL appears huge)
- Makes Profile do the work ProfilePersonalization did for creating PSS
- cloudy:stats > about:sync
- Removes the cloudy:// scheme and uses chrome:// for resources.
  (Note SyncResourcesSource is a straight copy of CloudyResourceSource).
- Moves prefs and switches to pref_names and chrome_switches.

BUG=none
TEST=ProfileSyncServiceTest, LiveBookmarkSyncTests, SyncSetupWizardTest

Review URL: http://codereview.chromium.org/164544
------------------------------------------------------------------------
r23504 | nick@chromium.org | 2009-08-15 02:46:37 +0200 (Sat, 15 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc

Touch PSS as an experiment, to see what the builder recompiles.

No-op code change.

Review URL: http://codereview.chromium.org/172016
------------------------------------------------------------------------
r23503 | kuchhal@chromium.org | 2009-08-15 02:27:20 +0200 (Sat, 15 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_linux.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_win.h
   A /trunk/src/chrome/test/data/firefox35_profile
   A /trunk/src/chrome/test/data/firefox35_profile/cert8.db
   A /trunk/src/chrome/test/data/firefox35_profile/cookies.sqlite
   A /trunk/src/chrome/test/data/firefox35_profile/key3.db
   A /trunk/src/chrome/test/data/firefox35_profile/places.sqlite
   A /trunk/src/chrome/test/data/firefox35_profile/prefs.js
   A /trunk/src/chrome/test/data/firefox35_profile/search.sqlite
   A /trunk/src/chrome/test/data/firefox35_profile/secmod.db
   A /trunk/src/chrome/test/data/firefox35_profile/signons.sqlite

Import passwords from Firefox 3.1 and above.

BUG=9103

Review URL: http://codereview.chromium.org/165352
------------------------------------------------------------------------
r23501 | jam@chromium.org | 2009-08-15 02:04:01 +0200 (Sat, 15 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc

Ensure we don't load plugins on the IO thread.

I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins.

BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
------------------------------------------------------------------------
r23500 | phajdan.jr@chromium.org | 2009-08-15 02:02:40 +0200 (Sat, 15 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   A /trunk/src/chrome/browser/errorpage_browsertest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Convert parts of errorpage_uitest.cc to be not flaky.

TEST=Covered by browser_tests.
http://crbug.com/19361, http://crbug.com/19395

Review URL: http://codereview.chromium.org/169002
------------------------------------------------------------------------
r23499 | mpcomplete@chromium.org | 2009-08-15 01:59:37 +0200 (Sat, 15 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h

Adds a copyright header to extension_browsertest.cc and fixes lint error.

Review URL: http://codereview.chromium.org/171005
------------------------------------------------------------------------
r23497 | wtc@chromium.org | 2009-08-15 01:49:19 +0200 (Sat, 15 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/net/base/cert_status_flags.cc
   M /trunk/src/net/base/cert_status_flags.h
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/base/x509_certificate_win.cc

Add new certificate error code
ERR_CERT_WEAK_SIGNATURE_ALGORITHM and certificate status
flag CERT_STATUS_WEAK_SIGNATURE_ALGORITHM.  Note that I
didn't add new load flag
LOAD_IGNORE_CERT_WEAK_SIGNATURE_ALGORITHM.

Allow users to accept MD2 certificates as certificates
signed using a weak signature algorithm.  MD4 certificates
are still treated as invalid certificates.

R=jar,jcampan
BUG=http://crbug.com/18725
TEST=none
Review URL: http://codereview.chromium.org/165504
------------------------------------------------------------------------
r23496 | kuchhal@chromium.org | 2009-08-15 01:46:21 +0200 (Sat, 15 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_win.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

Do not delete default browser entries for other users when uninstalling it for one user.

BUG=19222
TEST=Install and set Chrome as default for two different users on the same machine. Uninstall for one user and make sure the default browser still works for the second user.

Review URL: http://codereview.chromium.org/164454
------------------------------------------------------------------------
r23493 | estade@chromium.org | 2009-08-15 01:15:23 +0200 (Sat, 15 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Fix TabDraggingTest.Tab2OutOfTabStrip, which I broke by changing browser_tracker_ to window_tracker_

Verified working on my windows box.

I'd like to go on the record as disliking "handle" as a variable name.

BUG=19368

Review URL: http://codereview.chromium.org/172001
------------------------------------------------------------------------
r23492 | mpcomplete@chromium.org | 2009-08-15 01:11:13 +0200 (Sat, 15 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable UpdatePermissions until I can figure out why it's failing.

BUG=no
TEST=no
TBR=aa

Review URL: http://codereview.chromium.org/171002
------------------------------------------------------------------------
r23490 | sidchat@google.com | 2009-08-15 01:05:13 +0200 (Sat, 15 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/options_util.cc

Fix for spell check toggle checkbox not getting selected after reset to default button is clicked. Patch by tfarina (original patch: http://codereview.chromium.org/165524)

BUG=www.crbug.com/4602
TEST=none
------------------------------------------------------------------------
r23485 | estade@chromium.org | 2009-08-15 00:50:42 +0200 (Sat, 15 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

GTK: Change file chooser dialogs to prefer the suggested path (somewhatly erroneously known as "default_path") over the last selected path.

Also respect default_path for file save dialogs. This fixes a DCHECK we could hit from <upload> elements (as it turns out, there was no Release-mode crash).

BUG=19267

Review URL: http://codereview.chromium.org/170014
------------------------------------------------------------------------
r23483 | ananta@chromium.org | 2009-08-15 00:39:01 +0200 (Sat, 15 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Added support in the ExternalTabContainer for handling the NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in its implementation of TabContents::AddNewContents. These dispositions are handled by creating a new ExternalTabContainer instance, attaching it to the automation provider and sending off the AutomationMsg_AttachExternalTab IPC to the automation client requesting it to attach to the newly created tab.

This fixes bug http://b/issue?id=2050347

Bug=2050347

Review URL: http://codereview.chromium.org/164530
------------------------------------------------------------------------
r23482 | phajdan.jr@chromium.org | 2009-08-15 00:38:08 +0200 (Sat, 15 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Split short-circuited assertions in session_restore_uitest.cc to make more
meaningful errors appear in the logs.

This will help fight the test flakiness.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/164564
------------------------------------------------------------------------
r23480 | mpcomplete@chromium.org | 2009-08-15 00:32:39 +0200 (Sat, 15 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   A /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc
   A /trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/permissions-high-v2.crx
   A /trunk/src/chrome/test/data/extensions/permissions-low-v1.crx
   A /trunk/src/chrome/test/data/extensions/permissions-low-v1.pem
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Disable an extension when it is upgraded to a version that requires more
permissions then before, and prompt the user to re-enable.

Incidentally, this required adding support for disabling extensions.

BUG=12140
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/165414
------------------------------------------------------------------------
r23479 | rafaelw@chromium.org | 2009-08-15 00:30:24 +0200 (Sat, 15 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Implement chrome.tabs.getVisibleTabCapture() on Mac

Review URL: http://codereview.chromium.org/165429
------------------------------------------------------------------------
r23474 | aa@chromium.org | 2009-08-15 00:22:08 +0200 (Sat, 15 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix a bug where we can sometimes incorrectly decide a download
is not an extension.

BUG=19340
TEST=See bug for details.

Review URL: http://codereview.chromium.org/170007
------------------------------------------------------------------------
r23468 | sidchat@google.com | 2009-08-14 23:52:41 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Another attempt at tree fix.

TBR=pkasting
BUG=none
TEST=none
------------------------------------------------------------------------
r23465 | sidchat@google.com | 2009-08-14 23:43:56 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Fix build.

TBR=pkasting
BUG=none
TEST=none.
------------------------------------------------------------------------
r23464 | sidchat@google.com | 2009-08-14 23:35:20 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Make Spellchecker save the dictionary file in the file thread.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164358
------------------------------------------------------------------------
r23459 | erg@chromium.org | 2009-08-14 23:21:26 +0200 (Fri, 14 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

GTK Theme: Theme the find bar.

Modify the find bar so that in GTK theme mode we:
- ...set the dialog shape to a series of points instead of an image.
- ...use the global border color.
- ...use GTK icons.

This does not draw the GtkEntry border around the GtkEntry though. That will be a follow up patch.

http://crbug.com/17962

Review URL: http://codereview.chromium.org/165497
------------------------------------------------------------------------
r23456 | erikkay@chromium.org | 2009-08-14 23:02:11 +0200 (Fri, 14 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc

remove some unneeded DCHECKs (from an earlier review comment you made)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165545
------------------------------------------------------------------------
r23453 | paul@chromium.org | 2009-08-14 22:39:08 +0200 (Fri, 14 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view_unittest.mm

Prevent mouse down events on the toolbar view from moving the parent window.

BUG=19305 (http://crbug.com/19305)
TEST=Click and drag on the toolbar background and ensure that the window isn't moved.

Review URL: http://codereview.chromium.org/164528
------------------------------------------------------------------------
r23452 | tony@chromium.org | 2009-08-14 22:27:35 +0200 (Fri, 14 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Only call gtk_window_present on an alert dialog if the
activation state of the window is changing to active.  The
signal gets sent even when windows are going inactive (to make
the frame light blue), but we only want to do anything if
the window is trying to become active.

This seems fvwm specific in that gtk_window_present actually
changes focus in fvwm (in compiz/metacity, it just causes the
window to throb in the taskbar).

BUG=19292

Review URL: http://codereview.chromium.org/165502

------------------------------------------------------------------------
r23451 | deanm@chromium.org | 2009-08-14 22:24:42 +0200 (Fri, 14 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Match Windows and GtkEntry move cursor with selection behavior.

Review URL: http://codereview.chromium.org/170002

------------------------------------------------------------------------
r23447 | estade@chromium.org | 2009-08-14 20:30:57 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

re-disable Tab2OutOfTabStrip to make the bot green

TBR=maruel

Review URL: http://codereview.chromium.org/165547
------------------------------------------------------------------------
r23438 | maruel@chromium.org | 2009-08-14 16:54:21 +0200 (Fri, 14 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Revert 23408 in the hope to fix linux webkit_tests regressions.

According to http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8895
and http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8896
The culprit is either 23407 or 23408. I'm trying 23408 first.

TBR=estage
TEST=webkit linux webkit_tests
BUG=none
Review URL: http://codereview.chromium.org/165534
------------------------------------------------------------------------
r23437 | maruel@chromium.org | 2009-08-14 16:38:00 +0200 (Fri, 14 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc

Reverting 23420. It caused a reliability regression.

TBR=jam
BUG=none
TEST=reliability
Review URL: http://codereview.chromium.org/165532
------------------------------------------------------------------------
r23432 | hbono@chromium.org | 2009-08-14 14:35:56 +0200 (Fri, 14 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc

Another fix for my new unit-test "SpellCheckTest.SpellCheckTest".
Sorry I forgot removing a fprint() call used for debug.

TBR=brettw
BUG=18184
TEST=run unit_test on Mac
Review URL: http://codereview.chromium.org/164554
------------------------------------------------------------------------
r23431 | hbono@chromium.org | 2009-08-14 14:19:03 +0200 (Fri, 14 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   A /trunk/src/chrome/third_party/hunspell/dictionaries/es-ES-1-1.bdic

A fix for a unit-test break on Mac.
This change fixes my new unit-test "SpellCheckTest.SpellCheckTest" breaks on Mac.
The system dictionaries of Mac spellchecker don't have the following words included in hunspell:
 * en-AU (Australia): "organize" (which is a typo of "organise");
 * en-GB (United Kingdom): "organize" (which is a typo of "organise");
 * pt-BT (Brazil): "Google";
 * pt-PT (Portugal): "Google".

This change removed "Google" from a couple of texts and fixed a couple of typos. Also, this change adds a language for Spanish (Spain), which I forgot adding.

TBR=brettw
BUG=18184
TEST=run unit_tests on Mac
Review URL: http://codereview.chromium.org/164553
------------------------------------------------------------------------
r23430 | hbono@chromium.org | 2009-08-14 12:59:31 +0200 (Fri, 14 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   A /trunk/src/chrome/third_party/hunspell/dictionaries/ca-ES-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/cs-CZ-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/da-DK-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/de-DE-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/el-GR-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/en-AU-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/en-GB-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/et-EE-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/fr-FR-1-4.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/he-IL-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/hi-IN-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/hr-HR-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/id-ID-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/it-IT-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/lt-LT-1-3.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/lv-LV-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/nb-NO-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/nl-NL-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/pl-PL-1-3.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/pt-BR-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/pt-PT-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/ro-RO-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/ru-RU-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/sk-SK-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/sl-SI-1-2.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/sv-SE-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/tr-TR-1-1.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/vi-VN-1-2.bdic

Added a unit test "SpellCheckTest.SpellCheckText".
This change adds a new unit test "SpllCheckTest.SpellCheckText" for testing our spellchecker with all available dictionaries.

BUG=18184 "Add more spellcheck tests with languages other than en-US"
TEST=run unit_test.exe
Review URL: http://codereview.chromium.org/159906
------------------------------------------------------------------------
r23427 | willchan@chromium.org | 2009-08-14 09:07:49 +0200 (Fri, 14 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h

Make ClientSocketPool/ClientSocketPoolBase/ClientSocketHandle more generic.
This is in preparation for creating an SSLClientSocketPool.
ClientSocketPoolBase is now templated.  Most of the implementation has moved to ClientSocketPoolBaseHelper which is not templated.
In order to make this possible, ClientSocketPoolBaseHelper's internal data structures do not use the full concrete Request type, but rather use a pointer to Request.
ClientSocketPoolBase takes a SocketParams as a template argument, primarily to allow RequestSocket to take a templated parameter that contains all the information necessary to connect the socket (be it TCP or SSL or whatever).
ClientSocketPool::RequestSocket() and ClientSocketHandle::Init() have been templated as well to handle this case.
I've left adding run-time type safety checks as a TODO.
TEST=net_unittests
BUG=http://crbug.com/13289

Review URL: http://codereview.chromium.org/160621
------------------------------------------------------------------------
r23426 | levin@chromium.org | 2009-08-14 09:05:22 +0200 (Fri, 14 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Temporarily disable ExtensionBrowserTest.Toolstrip while the 
crash is being investigated.

BUG=http://crbug.com/19335
TEST=None


Review URL: http://codereview.chromium.org/164549
------------------------------------------------------------------------
r23423 | lzheng@chromium.org | 2009-08-14 08:37:18 +0200 (Fri, 14 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

The change has the followings:
1. Auto-updating of extension blacklist.
2. Handle extensions in the blacklist. If an extension is in the blacklist,
a. browser will not load the extension at start time;
b. browser will unload the extension at running time;
c. browser will not install the extension;


BUG=12118
TEST=Verify behavior described above works (they should be covered in the unittests in this change).
Review URL: http://codereview.chromium.org/165164
------------------------------------------------------------------------
r23422 | aa@chromium.org | 2009-08-14 07:43:53 +0200 (Fri, 14 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/view_types.h
   M /trunk/src/chrome/renderer/extensions/bindings_utils.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/backgroundpage.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/test_gettabs.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html
   M /trunk/src/ipc/ipc_message_utils.h

Implementation of getBackgroundPage(), getToolstrips(), and
getTabContentses().

This lands http://codereview.chromium.org/159067.

Raf, the only thing you need to look at is the changes to extensions_process_bindings.js and extension_api.json.

BUG=13577
TEST=Browser tests added

Review URL: http://codereview.chromium.org/164458
------------------------------------------------------------------------
r23420 | jam@chromium.org | 2009-08-14 07:24:21 +0200 (Fri, 14 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc

Ensure we don't load plugins on the IO thread.

I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins.

BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
------------------------------------------------------------------------
r23419 | willchan@chromium.org | 2009-08-14 06:54:46 +0200 (Fri, 14 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/ftp/ftp_transaction.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/proxy/proxy_resolver_js_bindings.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socks5_client_socket.cc
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

LoadLog is used as an output parameter, reorder it to the last parameter.

Review URL: http://codereview.chromium.org/164531
------------------------------------------------------------------------
r23414 | tim@chromium.org | 2009-08-14 05:24:23 +0200 (Fri, 14 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/test/test_browser_window.h

Fix SyncSetupWizard test again; the order of operations when the HtmlDialogView
infrastructure closes a dialog is a bit different from what I was simulating in this
test.  It goes 1) obtain handlers from delegate. 2) delete delegate. 3) delete handlers.
Also add a virtual dtor to TestBrowserWindow.

BUG=19002
TEST=SyncSetupWizardTest

Review URL: http://codereview.chromium.org/164494
------------------------------------------------------------------------
r23411 | levin@chromium.org | 2009-08-14 05:00:30 +0200 (Fri, 14 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/base/window_impl.cc
   M /trunk/src/base/window_impl.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/webkit/default_plugin/default_plugin.gyp
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h
   M /trunk/src/webkit/webkit.gyp

Reverting 23406.

It seems that Tab2OutOfTabStrip is failing consistently after this change.

BUG=None
TEST=None
TBR=jhawkins@chromium.org

Review URL: http://codereview.chromium.org/164543
------------------------------------------------------------------------
r23409 | paul@chromium.org | 2009-08-14 04:07:19 +0200 (Fri, 14 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   A /trunk/src/chrome/browser/cocoa/download_shelf_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Prevent mouse down events in the bookmark bar and download shelf from moving
the parent window around.

BUG=19305 (http://crbug.com/19305)
TEST=Make the download shelf and/or bookmark bar visible. Clicking
     and dragging on either one should not move the window around.

Review URL: http://codereview.chromium.org/165500
------------------------------------------------------------------------
r23408 | estade@chromium.org | 2009-08-14 03:18:40 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Check for enter as well as return in the find bar

BUG=19312

Review URL: http://codereview.chromium.org/165511
------------------------------------------------------------------------
r23406 | jhawkins@chromium.org | 2009-08-14 03:12:38 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/base/window_impl.cc
   M /trunk/src/base/window_impl.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/webkit/default_plugin/default_plugin.gyp
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h
   M /trunk/src/webkit/webkit.gyp

Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to reduce a dependency on ATL.

BUG=5023
TEST=Uninstall flash.  Visit hulu.com and install the flash plugin.
Review URL: http://codereview.chromium.org/165469
------------------------------------------------------------------------
r23404 | estade@chromium.org | 2009-08-14 03:11:14 +0200 (Fri, 14 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Revert some of my automation provider changes. Maybe it's possible that GetResource() returns NULL when ContainsHandle() returns true? I can't repro locally and there is no try server for this.

Review URL: http://codereview.chromium.org/165510
------------------------------------------------------------------------
r23401 | sidchat@google.com | 2009-08-14 02:44:30 +0200 (Fri, 14 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Disable TabDraggingTest.Tab2OutOfTabStrip temporarily.

TBR=estade
BUG=none
TEST=none

------------------------------------------------------------------------
r23395 | davemoore@chromium.org | 2009-08-14 01:59:55 +0200 (Fri, 14 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/panel_controller.cc
   M /trunk/src/chrome/browser/views/panel_controller.h

Show favicon in panel title, highlight focused panel, fix breakage
recent search box changes
Review URL: http://codereview.chromium.org/164425
------------------------------------------------------------------------
r23393 | estade@chromium.org | 2009-08-14 01:50:29 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

I changed an OS_WIN to TOOLKIT_VIEWS. The buildbot doesn't like it. Why don't we have a trybot for linux views.

TBR=tony

Review URL: http://codereview.chromium.org/165505
------------------------------------------------------------------------
r23392 | estade@chromium.org | 2009-08-14 01:44:02 +0200 (Fri, 14 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   A /trunk/src/chrome/browser/gtk/view_id_util.cc
   A /trunk/src/chrome/browser/gtk/view_id_util.h
   A /trunk/src/chrome/browser/gtk/view_id_util_unittest.cc
   M /trunk/src/chrome/chrome.gyp

GTK: Add view ids to our widgets. These will be used for testing.

Also add unit test to test test infrastructure.

BUG=19214

Review URL: http://codereview.chromium.org/164519
------------------------------------------------------------------------
r23388 | suzhe@chromium.org | 2009-08-14 01:35:43 +0200 (Fri, 14 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Fix regression caused by CL 16142

This CL fixes regression caused by CL 16142: Improve key event handling of AutocompleteEditViewGtk.

BUG=19193: omnibox blocks ctrl-* commands
BUG=19199: omnibox ignores history, automatically searchs
TEST=Open chrome, move cursor into omnibox then press ctrl-t to see if a new tab is opened.
TEST=Open chrome, input something in omnibox and make sure an url is matched and some text is highlighted in omnibox, then press Enter to see if the url is opened.

Review URL: http://codereview.chromium.org/165457
------------------------------------------------------------------------
r23386 | estade@chromium.org | 2009-08-14 01:34:24 +0200 (Fri, 14 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   M /trunk/src/chrome/browser/automation/ui_controls_win.cc
   M /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/ui/history_uitest.cc

linux: More automation porting.

I have verified that this is working on Linux, but still have yet to enable any new automated tests. Baby steps.

BUG=19076

Review URL: http://codereview.chromium.org/164446
------------------------------------------------------------------------
r23384 | tony@chromium.org | 2009-08-14 01:32:13 +0200 (Fri, 14 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Reland r23358 with a fix for linux unit_tests:

Better location for setting the size of tab contents.  This should
catch all code paths.  I noticed that middle clicking a bookmark
wasn't working, so I found a single place to do this.

This code is always run when a tab is added and it sizes the
contents when it's loading in the background.

BUG=619

TBR=japhet

Review URL: http://codereview.chromium.org/164526

------------------------------------------------------------------------
r23381 | jhawkins@chromium.org | 2009-08-14 01:21:24 +0200 (Fri, 14 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_uitest.cc

coverity: Pass strings by reference.

CID=5738
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165486
------------------------------------------------------------------------
r23378 | beng@google.com | 2009-08-14 01:19:45 +0200 (Fri, 14 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

When you clicked Get Themes in Mac prefs, the browser window containing the themes gallery wasn't coming to the front.

There was an implicit assumption on Windows that TabContentsViewWin::Focus caused the window containing the TabContents to be foregrounded. This is because on Windows a HWND is focused with a call to SetFocus, which activates the containing top level window. On Mac, TabContentsViewMac::Focus needs to explicitly activate the containing window.

Also, changes the Mac preferences code to call the same function as on Windows, for simplicity.

Note: the "foreground" parameter to AddTabWithURL means the tab is opened in the foreground, not that the window is activated.

http://crbug.com/18157
TEST=none

Review URL: http://codereview.chromium.org/165492
------------------------------------------------------------------------
r23374 | tony@chromium.org | 2009-08-14 01:16:54 +0200 (Fri, 14 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc

Reland r23357 since it doesn't seem to be the cause of unit test
failure:

Renames the NavigationEntry::display_url() to virtual_url().

BUG=6970 (http://crbug.com/6970)
TEST=None

Patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/164383

Review URL: http://codereview.chromium.org/165501

------------------------------------------------------------------------
r23371 | sidchat@google.com | 2009-08-14 00:31:37 +0200 (Fri, 14 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc

re-enable test.

BUG=none
TEST=none
------------------------------------------------------------------------
r23370 | sidchat@google.com | 2009-08-14 00:20:47 +0200 (Fri, 14 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc

Disable BrowserCommandsTest.TabNavigationAccelerators.

TBR=tony@chromium.org
BUG=none
TEST=none
------------------------------------------------------------------------
r23367 | tony@chromium.org | 2009-08-13 23:43:44 +0200 (Thu, 13 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc

Revert "Renames the NavigationEntry::display_url() to virtual_url()."

This reverts commit r23357.

Review URL: http://codereview.chromium.org/164517

------------------------------------------------------------------------
r23365 | tony@chromium.org | 2009-08-13 23:03:44 +0200 (Thu, 13 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Revert "Better location for setting the size of tab contents.  This should"

This reverts commit r23358.

TBR=japhet

Review URL: http://codereview.chromium.org/165489

------------------------------------------------------------------------
r23362 | aa@chromium.org | 2009-08-13 22:55:17 +0200 (Thu, 13 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Argh, reverting the change to remove the "crx" file extension
hack in DownloadManager.

For those playing along at home, this change makes it so that
we once again consider any file that ends in ".crx" an
extension.

The problem is that file:// URLs are not-sniffable, so with
this change we cannot install extensions from file:// URLs.

We need to fix things so that we consider file associations
for local files, I guess.

TBR=mpcomplete@chromium.org
------------------------------------------------------------------------
r23361 | jrg@chromium.org | 2009-08-13 22:53:04 +0200 (Thu, 13 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

BUG=http://crbug.com/17986
Original CL: http://codereview.chromium.org/164500
TEST=see original CL

Landing an LGTMed CL for rsesek@gmail.com

Review URL: http://codereview.chromium.org/165484
------------------------------------------------------------------------
r23360 | tony@chromium.org | 2009-08-13 22:51:59 +0200 (Thu, 13 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc

Make confirm info bar buttons support mnemonics.

I think this is temporary because we're past string freeze and
the undo text is borrowed from elsewhere.

I should have caught this in the last change. :(

Review URL: http://codereview.chromium.org/164490

------------------------------------------------------------------------
r23359 | pfeldman@chromium.org | 2009-08-13 22:49:42 +0200 (Thu, 13 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: Disable sanity tests while merging the DOMAgent commit upstream. (Re-apply 23350).

Review URL: http://codereview.chromium.org/164514
------------------------------------------------------------------------
r23358 | tony@chromium.org | 2009-08-13 22:45:47 +0200 (Thu, 13 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Better location for setting the size of tab contents.  This should
catch all code paths.  I noticed that middle clicking a bookmark
wasn't working, so I found a single place to do this.

This code is always run when a tab is added and it sizes the
contents when it's loading in the background.

BUG=619

Review URL: http://codereview.chromium.org/165473

------------------------------------------------------------------------
r23357 | tony@chromium.org | 2009-08-13 22:45:12 +0200 (Thu, 13 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc

Renames the NavigationEntry::display_url() to virtual_url().

BUG=6970 (http://crbug.com/6970)
TEST=None

Patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/164383

Review URL: http://codereview.chromium.org/165485

------------------------------------------------------------------------
r23356 | pfeldman@chromium.org | 2009-08-13 22:37:15 +0200 (Thu, 13 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Rollback 23350. Fix build breakage: no object file generated.
TBR=mnaganov

------------------------------------------------------------------------
r23350 | pfeldman@chromium.org | 2009-08-13 22:15:48 +0200 (Thu, 13 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: Disable sanity tests while merging the DOMAgent commit upstream.
TBR=mnaganov
Review URL: http://codereview.chromium.org/164505
------------------------------------------------------------------------
r23345 | mpcomplete@chromium.org | 2009-08-13 21:49:49 +0200 (Thu, 13 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc

Add some paranoid CHECKs to the ExtensionMessageService to track down a crash.

BUG=19067
TEST=no

Review URL: http://codereview.chromium.org/165431
------------------------------------------------------------------------
r23334 | pinkerton@chromium.org | 2009-08-13 20:36:46 +0200 (Thu, 13 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/clickhold_button_cell.mm

Make drag-to-activate session history dropdowns less sensitive. Patch from viettrunglu@gmail.com
BUG=19273
TEST=Make your mouse really sensitive; see if you can accidentally activate the
back/forward history dropdowns.
------------------------------------------------------------------------
r23332 | tony@chromium.org | 2009-08-13 20:33:58 +0200 (Thu, 13 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Take 2 at fixing anchor links opening in background tabs on linux.
Also fix a code path that seems to be missing on Windows (maybe
this regressed?).

This time make sure RWHV is not NULL.

BUG=619

TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6

Review URL: http://codereview.chromium.org/165468

------------------------------------------------------------------------
r23331 | robertshield@chromium.org | 2009-08-13 20:30:18 +0200 (Thu, 13 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h

Correcting a possible race between adding and removing automation resource message filters.

Review URL: http://codereview.chromium.org/165395
------------------------------------------------------------------------
r23329 | paul@chromium.org | 2009-08-13 20:19:00 +0200 (Thu, 13 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/about_window_controller.mm

Clear an error message from the throbber space.

When an update fails, we display an error string and allow the
user to try again by manually pressing the update button. When
the user does that, we should clear the error message so that the
update throbber doesn't draw over the text, which looks ugly.

BUG=19272 (http://crbug.com/19272)
TEST=Difficult to repro: try to update chrome and fail, press the
     update button and notice that the error message disappears when
     the throbber is active.
Review URL: http://codereview.chromium.org/165462
------------------------------------------------------------------------
r23327 | maruel@chromium.org | 2009-08-13 20:15:03 +0200 (Thu, 13 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/base/system_monitor.cc
   M /trunk/src/base/system_monitor.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Simple cleanup.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164424
------------------------------------------------------------------------
r23324 | agl@chromium.org | 2009-08-13 20:08:50 +0200 (Thu, 13 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/third_party/libxml/libxml.gyp
   M /trunk/src/third_party/libxslt/libxslt.gyp
   M /trunk/src/third_party/sqlite/sqlite.gyp
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc

Linux: fix up use_system_{libxml,libxslt,sqlite3}

http://codereview.chromium.org/164450

------------------------------------------------------------------------
r23323 | tony@chromium.org | 2009-08-13 20:05:07 +0200 (Thu, 13 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h

Fix a bug where infobars were not getting replaced on linux.  This
was added to the info bar api in r22711.

There's a tiny flicker when the infobars are replaced, but it's a
lot better than the jerky animation there used to be.

I imagine mac will still have this bug.

BUG=19101
TEST=Install 2 themes from the theme gallery.  The second theme should
    be displayed.

Review URL: http://codereview.chromium.org/164456

------------------------------------------------------------------------
r23320 | tony@chromium.org | 2009-08-13 19:34:56 +0200 (Thu, 13 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Revert "Fix anchor links opening in background tabs on linux.  Also fix"

Some tab opening crashes, I need to null check some pointers.

TBR=estade

This reverts commit r23317.

Review URL: http://codereview.chromium.org/164486

------------------------------------------------------------------------
r23317 | tony@chromium.org | 2009-08-13 19:27:35 +0200 (Thu, 13 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Fix anchor links opening in background tabs on linux.  Also fix
a code path that seems to be missing on Windows (maybe this
regressed?).

BUG=619
TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6

Review URL: http://codereview.chromium.org/164452

------------------------------------------------------------------------
r23316 | phajdan.jr@chromium.org | 2009-08-13 19:25:12 +0200 (Thu, 13 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/blacklist.pbl
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json

Add privacy_blacklists key to extension manifest and validate it.

This is the first step towards shipping privacy blacklists in extensions.

TEST=Covered by unit_tests.
BUG=none

Review URL: http://codereview.chromium.org/164349
------------------------------------------------------------------------
r23304 | mark@chromium.org | 2009-08-13 14:53:16 +0200 (Thu, 13 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_path.h
   M /trunk/src/base/hash_tables.h
   M /trunk/src/breakpad/breakpad.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/cocoa/nsimage_cache.h
   M /trunk/src/chrome/browser/cocoa/nsimage_cache.mm
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/testing/gtest.gyp

Disable RTTI and C++ exceptions in the Mac build.  Disable RTTI in the Linux
build, where C++ exceptions are already disabled.

BUG=19094 12248
TEST=Mac release-mode Google Chrome.app should shrink by about 6MB.
     Mac disk image should shrink by about 1.5MB.
     Linux binary and package should shrink too.
Review URL: http://codereview.chromium.org/165330
------------------------------------------------------------------------
r23297 | jorlow@chromium.org | 2009-08-13 10:27:11 +0200 (Thu, 13 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Revert 23286

TBR=michaeln
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/164463
------------------------------------------------------------------------
r23286 | jorlow@chromium.org | 2009-08-13 08:12:25 +0200 (Thu, 13 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Another attempt to enable the local storage ui test based layout tests.

TBR=michaeln
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/164461
------------------------------------------------------------------------
r23278 | sky@chromium.org | 2009-08-13 05:12:25 +0200 (Thu, 13 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm

Removes unneeded include in download_request_dialog_delegate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/164444
------------------------------------------------------------------------
r23276 | thakis@chromium.org | 2009-08-13 04:28:01 +0200 (Thu, 13 Aug 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/HttpAuthLoginSheet.xib
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.h
   M /trunk/src/chrome/browser/cocoa/constrained_window_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm
   A /trunk/src/chrome/browser/login_prompt_mac.h
   A /trunk/src/chrome/browser/login_prompt_mac.mm
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Implement http auth login dialog for OS X.

The login sheet looks very bare-bones…but that's probably ok for now.

BUG=12043
TEST=Go to a page that uses http auth, e.g. http://www.pagetutor.com/keeper/mystash/secretstuff.html . A sheet should come up that asks for login and password. Escape should cancel the sheet, return should confirm it. The sheet should be per-tab, e.g. tab switching while the sheet is open should work.

Review URL: http://codereview.chromium.org/164391
------------------------------------------------------------------------
r23273 | shess@chromium.org | 2009-08-13 02:28:10 +0200 (Thu, 13 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Mac: Omnibox popup metrics.

Use en-dash instead of em-dash to separate match and description.

Popup font a little smaller than field font.

Make cell taller, and no gap between cells.

Use BaseFont from ResourceBundle instead of field's default font (this
is what Windows uses, I think).

http://crbug.com/19184

Review URL: http://codereview.chromium.org/164418
------------------------------------------------------------------------
r23266 | estade@chromium.org | 2009-08-13 02:17:30 +0200 (Thu, 13 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

gtk: One more accelerator

BUG=19122

Review URL: http://codereview.chromium.org/165411
------------------------------------------------------------------------
r23259 | rafaelw@chromium.org | 2009-08-13 02:04:06 +0200 (Thu, 13 Aug 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/common/extensions/docs/tabs.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   A /trunk/src/chrome/test/data/extensions/samples/screenshot
   A /trunk/src/chrome/test/data/extensions/samples/screenshot/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/screenshot/screenshot.html
   A /trunk/src/chrome/test/data/extensions/samples/screenshot/screenshot.js
   A /trunk/src/chrome/test/data/extensions/samples/screenshot/toolstrip.html

I have taken over this patch, original authored by Adam Hunter (adamhunter).

The original issue is: http://codereview.chromium.org/144019

--------------

Functionality has been requested in the Extension API for Javascript to
take screenshots of the currently visible tab.  This changelist builds this
function, chrome.tabs.getVisibleScreenCapture.  This function takes a
single callback function and returns to that function a data URL of a JPEG
image of the current screen.  A simple sample extension is provided as a
use case.

BUG=14760
TEST=There is an extension in chrome\test\data\extensions\samples\screenshot,
load this extension.  It creates a toolstrip button.  Click this button, you
should get a page with a screenshot of the active tab.  The API function
is found at chrome.tabs.getVisibleScreenCapture.

Review URL: http://codereview.chromium.org/160228
------------------------------------------------------------------------
r23254 | tim@chromium.org | 2009-08-13 01:47:58 +0200 (Thu, 13 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc

Fix two URLRequestContext leaks in HttpBridgeTest and reenable the test.  It was previously failing the purify step.



BUG=19002
TEST=HttpBridgeTest


Review URL: http://codereview.chromium.org/165363
------------------------------------------------------------------------
r23253 | shess@chromium.org | 2009-08-13 01:45:01 +0200 (Thu, 13 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Mac: autocomplete popup size and shape mirrors star/go buttons.

Also line up image and title columns under star and field.

http://crbug.com/19182

Review URL: http://codereview.chromium.org/164415
------------------------------------------------------------------------
r23250 | jeremy@chromium.org | 2009-08-13 01:42:01 +0200 (Thu, 13 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/safari_importer.mm

Fix early return/DCHECK importing Safari bookmarks.

BUG=19167

Review URL: http://codereview.chromium.org/164442
------------------------------------------------------------------------
r23243 | phajdan.jr@chromium.org | 2009-08-13 01:08:24 +0200 (Thu, 13 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/base/base.gyp
   D /trunk/src/base/id_map.h
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/app_cache/app_cache_context_impl.h
   M /trunk/src/chrome/common/app_cache/app_cache_dispatcher_host.h
   M /trunk/src/chrome/common/db_message_filter.cc
   M /trunk/src/chrome/common/db_message_filter.h
   A /trunk/src/chrome/common/id_map.h (from /trunk/src/base/id_map.h:23241)
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/render_view.h

Move IDMap from base/ to common/

Nothing in base/ uses it, and I'm going to make some non-trivial changes to it.

TEST=none
http://crbug.com/19202

Review URL: http://codereview.chromium.org/164428
------------------------------------------------------------------------
r23239 | eroman@chromium.org | 2009-08-13 00:49:10 +0200 (Thu, 13 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/mock_host_resolver.cc

Remove the unittest "DnsMasterTest.OsCachesLookupsTest".

This test was checking that the system host resolver maintains an internal cache, by doing actual DNS resolves (which introduces a network dependency in the unit tests). This could be flaky on linux, which doesn't cache resolves.

As of r18236 however, chromium maintains its own host cache. So the DNS prefetcher does not need to rely on the OS caching DNS resolves in order to be a win.

BUG=http://crbug.com/18766

Review URL: http://codereview.chromium.org/164350
------------------------------------------------------------------------
r23234 | estade@chromium.org | 2009-08-13 00:25:44 +0200 (Thu, 13 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

So it turns out that gdk already has a function that does exactly what we want.

http://www.google.com/codesearch/p?hl=en&sa=N&cd=2&ct=rc#eSCqYNcHl48/gtk%2B-2.4.10/gdk/gdkevents.c&q=gdk_event_get_time

Review URL: http://codereview.chromium.org/164429
------------------------------------------------------------------------
r23233 | ananta@chromium.org | 2009-08-13 00:21:10 +0200 (Thu, 13 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/test/automation/automation_messages.h

Added support for the URLRequestAutomationJob object which issues HTTP requests through automation to receive persistent cookies from the automation client. These cookies are passed in when the automation client notifies Chrome that a HTTP request was started.

The URLRequestAutomationJob object now informs Chrome whether an automation URL request was redirected. 

The ExternalTabContainer now handles the NEW_FOREGROUND_TAB and displays a popup window in response. This gets around an ASSERT.

This fixes bug http://b/issue?id=2048046

Bug=2048046

Review URL: http://codereview.chromium.org/165350
------------------------------------------------------------------------
r23230 | sky@chromium.org | 2009-08-12 23:58:18 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data.h
   A /trunk/src/app/os_exchange_data_provider_gtk.cc
   A /trunk/src/app/os_exchange_data_provider_gtk.h
   A /trunk/src/app/os_exchange_data_provider_win.cc (from /trunk/src/app/os_exchange_data_win.cc:23183)
   A /trunk/src/app/os_exchange_data_provider_win.h (from /trunk/src/app/os_exchange_data.h:23183)
   D /trunk/src/app/os_exchange_data_win.cc
   M /trunk/src/app/os_exchange_data_win_unittest.cc
   M /trunk/src/base/clipboard_util.cc
   M /trunk/src/base/clipboard_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/drag_utils_win.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/widget/drop_target_win.cc

Refactors OSExchangeData for easier portability.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/164401
------------------------------------------------------------------------
r23226 | phajdan.jr@chromium.org | 2009-08-12 23:34:49 +0200 (Wed, 12 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   A /trunk/src/chrome/browser/shell_integration_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp

First step to create application shortcuts on Linux.

Create a working desktop shortcut. For now it displays no UI, but the backend works.

TEST=none
http://crbug.com/17251

Review URL: http://codereview.chromium.org/164280
------------------------------------------------------------------------
r23225 | shess@chromium.org | 2009-08-12 23:34:48 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Mac: Make autocomplete popup track autocomplete field resizes.

http://crbug.com/17402
TEST=Enter text in the omnibox and resize the window.  Popup size should follow.

Review URL: http://codereview.chromium.org/165332
------------------------------------------------------------------------
r23216 | avi@chromium.org | 2009-08-12 22:39:41 +0200 (Wed, 12 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm

(Mac) Place back/forward toolbar menu correctly when there's a bookmark
bar.

It turns out that the frame is in the DelayedMenuButton's coordinate
system, but a fudge is needed to make things line up. (I don't
understand these fudges, especially vertically.)

Patch by viettrungluu.

BUG=http://crbug.com/19174
TEST=Surf a bit, check back menu with and without bookmark bar.

------------------------------------------------------------------------
r23215 | thomasvl@chromium.org | 2009-08-12 22:33:05 +0200 (Wed, 12 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util_mac.mm
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm

Move the menu bar l10n into the xib file.
Localize the menu bar titles.
Have the browser platform delegate startup the resource bundle system so we can fetch localization data.
Make l10n_util::GetApplicationLocale return what cocoa says for the language so we match what the UI is using.

TEST=everything still works.
BUG=17380
Review URL: http://codereview.chromium.org/164413
------------------------------------------------------------------------
r23213 | tim@chromium.org | 2009-08-12 22:17:39 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc

Disable SyncSetupWizardTest again.

TBR=cmp
BUG=19002

Review URL: http://codereview.chromium.org/165400
------------------------------------------------------------------------
r23209 | estade@chromium.org | 2009-08-12 21:56:28 +0200 (Wed, 12 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   D /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   A /trunk/src/chrome/browser/automation/ui_controls_linux.cc
   A /trunk/src/chrome/browser/automation/ui_controls_win.cc (from /trunk/src/chrome/browser/automation/ui_controls.cc:23045)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_constants.h

Checkpoint for event automation porting.

Partially based on patch by Dan Kegel.

Review URL: http://codereview.chromium.org/164371
------------------------------------------------------------------------
r23208 | scherkus@chromium.org | 2009-08-12 21:52:44 +0200 (Wed, 12 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/webview_impl.cc

Remove Playback Rate from the context menu.

This feature is better implemented as an extension rather than being put into
the absolute-core UI.

Review URL: http://codereview.chromium.org/164301

------------------------------------------------------------------------
r23207 | tim@chromium.org | 2009-08-12 21:48:14 +0200 (Wed, 12 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc

Fix two leaks in SyncSetupWizard test caused by the mock infrastructure
not doing the cleanup that happens in real life.

BUG=19002
TEST=SyncSetupWizardTest

Review URL: http://codereview.chromium.org/164370
------------------------------------------------------------------------
r23205 | mirandac@chromium.org | 2009-08-12 21:36:57 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Make text on NNTP popup menu blue, so it can be read in all themes.

BUG= http://crbug.com/18471
TEST= Open new tab page in any theme, click "Change page layout" dropdown menu, note that text is always blue on white.

Review URL: http://codereview.chromium.org/165389
------------------------------------------------------------------------
r23196 | mark@chromium.org | 2009-08-12 21:00:42 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_mac.mm

Remove TransformProcessType from the browser process now that LSUIElement
is gone.

BUG=8044
TEST=Dock icon still works properly
Review URL: http://codereview.chromium.org/165384
------------------------------------------------------------------------
r23194 | phajdan.jr@chromium.org | 2009-08-12 20:35:37 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Fix unused variable on GCC.

TBR=wtc
http://crbug.com/18697

Review URL: http://codereview.chromium.org/164410
------------------------------------------------------------------------
r23193 | phajdan.jr@chromium.org | 2009-08-12 20:29:57 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Fix compile on Windows.

TBR=wtc
http://crbug.com/18697

Review URL: http://codereview.chromium.org/165391
------------------------------------------------------------------------
r23190 | phajdan.jr@chromium.org | 2009-08-12 20:20:35 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Fix crash with new FTP in Incognito mode.

TEST=See bug.
http://crbug.com/18697

Review URL: http://codereview.chromium.org/165386
------------------------------------------------------------------------
r23189 | erg@google.com | 2009-08-12 20:19:59 +0200 (Wed, 12 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Popup notification should have transparent rounded corners.

Also uses the new consistent border color in GTK theme mode.

Review URL: http://codereview.chromium.org/165356
------------------------------------------------------------------------
r23188 | jeremy@chromium.org | 2009-08-12 20:18:44 +0200 (Wed, 12 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FirstRunDialog.xib
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm
   M /trunk/src/chrome/browser/first_run_mac.mm

Fix several bugs in First Run.

Chromium:
* First run no longer displays every time you launch Chromium.
* Enable Stats checkbox hidden (it doesn't do anything anyway in Chromium).

General:
* Import popup menu disables with checkbox.

BUG=19163,19171

Review URL: http://codereview.chromium.org/165387
------------------------------------------------------------------------
r23184 | suzhe@chromium.org | 2009-08-12 18:12:06 +0200 (Wed, 12 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Improve key event handling of AutocompleteEditViewGtk.

This CL improves key event handling of AutocompleteEditViewGtk class, following changes have been made:
1. Avoid accessing private data member of GtkTextView object, including im_context, need_im_reset etc.
2. Always send key events to the default handler of GtkTextView before handling them by ourselves, to make sure the behavior of IME and GtkTextView are always correct. This fixes the issue of moving focus from omnibox to webpage by pressing Tab key when using XIM im module.
3. Intercept "insert-text" signal of GtkTextBuffer object to prevent any unwanted characters from being inserted into omnibox.
4. Intercept "backspace" signal of GtkTextView object to fix issue 19068: [Linux] Search keywords: Backspace should exit out of search mode

BUG=18393: AutocompleteEditViewGtk should not access private members of GtkTextView
BUG=19068: [Linux] Search keywords: Backspace should exit out of search mode
TEST=Starts a XIM input method, such as scim then open chrome with GTK_IM_MODULE=xim. Opens a webpage and press tab and shift-tab in omnibox to see if focus can be moved to/from webpage correctly.
TEST=Copy & paste some text with new line characters to omnibox to see if new line characters are filtered.
TEST=Turn on keyword search mode, press backspace to see if it can exit keyword search mode.
TEST= Turn on keyword search mode, input some text then press backspace to delete a character, to see if it still in keyword search mode. Then move the cursor to the beginning of the text and press backspace, to see if it exits keyword search mode correctly.

Review URL: http://codereview.chromium.org/164142
------------------------------------------------------------------------
r23168 | sky@chromium.org | 2009-08-12 06:03:27 +0200 (Wed, 12 Aug 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/tab_contents_drag_source.cc
   A /trunk/src/chrome/browser/gtk/tab_contents_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Refactors drag support from TabContentsViewGtk into
TabContentsDragHandler so that it can be used by both Gtk and Views.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165302
------------------------------------------------------------------------
r23160 | estade@chromium.org | 2009-08-12 05:29:17 +0200 (Wed, 12 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Add ctrl+w accelerator to close bookmark manager for linux

Following the way that the Task Manger does it.

BUG=18879

patch by Joel Stanley <joel.stan [at] gmail>

original review: http://codereview.chromium.org/165220

------------------------------------------------------------------------
r23146 | mattm@chromium.org | 2009-08-12 04:51:40 +0200 (Wed, 12 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

Gtk Cookie Manager: Fix removing multiple cookies while the list is sorted.

BUG=11507

Review URL: http://codereview.chromium.org/165358
------------------------------------------------------------------------
r23145 | mattm@chromium.org | 2009-08-12 04:49:34 +0200 (Wed, 12 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/common/gtk_tree.cc
   M /trunk/src/chrome/common/gtk_tree.h

Move common Gtk TreeModel handling code into gtk_tree::ModelAdapter.

Also add gtk_tree::SelectAndFocusRowNum.

BUG=none
TEST=cookie manage, bookmark editor, url picker, search engine manager should all still work.

Review URL: http://codereview.chromium.org/165359
------------------------------------------------------------------------
r23135 | michaeln@google.com | 2009-08-12 03:14:58 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/api/public/WebSettings.h
   M /trunk/src/webkit/api/src/WebSettingsImpl.cpp
   M /trunk/src/webkit/api/src/WebSettingsImpl.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Adds a command line switch to enable the appcache, and plumb the switch throughto preferences and webcore settings.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/164306
------------------------------------------------------------------------
r23127 | ericroman@google.com | 2009-08-12 02:25:12 +0200 (Wed, 12 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_impl.cc
   M /trunk/src/net/base/host_resolver_impl.h
   M /trunk/src/net/base/host_resolver_impl_unittest.cc
   A /trunk/src/net/base/load_log.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/ftp/ftp_transaction.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_resolver_js_bindings.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/socket/client_socket_handle.cc
   M /trunk/src/net/socket/client_socket_handle.h
   M /trunk/src/net/socket/client_socket_pool.h
   M /trunk/src/net/socket/client_socket_pool_base.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socket_test_util.cc
   M /trunk/src/net/socket/socks5_client_socket.cc
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket.cc
   M /trunk/src/net/socket/socks_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.cc
   M /trunk/src/net/socket/tcp_client_socket_pool.h
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Add a "LoadLog" parameter to transactions, hostresolver, clientsocketpool and proyxservice.This dependency comes from the parent URLRequest, and is used as a container for per-request profiling data.This change is strictly a no-op refactor -- the parameter is unused, and LoadLog does nothing.BUG=http://crbug.com/14478TEST=none -- just needs to compile and pass existing tests.DESIGN=<http://docs.google.com/Doc?id=dfhcnb2v_21gbtrcpr3&hl=en>
Review URL: http://codereview.chromium.org/126303
------------------------------------------------------------------------
r23126 | glen@chromium.org | 2009-08-12 02:24:05 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/infobar_theme.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc

Add a default icon for theme install infobar.

BUG=18227
TEST=Install a theme, verify that an infobar with a pretty icon appears.

Review URL: http://codereview.chromium.org/165205
------------------------------------------------------------------------
r23124 | tc@google.com | 2009-08-12 02:16:09 +0200 (Wed, 12 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix 2 small docked dev tools bugs:

1) Set the initial size of the docked dev tools pane to 200px to match
   Windows.
2) Set the color of the dev tools divider to the frame color.

TEST=Open the dev tools (ctrl+shift+j) and dock it (button in lower left).
  Verify that the divider color matches the frame color like on windows.

Review URL: http://codereview.chromium.org/165335

------------------------------------------------------------------------
r23118 | aa@chromium.org | 2009-08-12 01:51:49 +0200 (Wed, 12 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Remove the temporary hack that considered any file that ended
in ".crx" a Chrome extension now that all the relevant servers
are fixed.

BUG=13296

Review URL: http://codereview.chromium.org/164344
------------------------------------------------------------------------
r23115 | jrg@chromium.org | 2009-08-12 01:46:26 +0200 (Wed, 12 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/page_info_window_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

BUG=http://crbug.com/16646
Submititing on behalf rsesek@gmail.com
Original CL is http://codereview.chromium.org/164255

Review URL: http://codereview.chromium.org/165346
------------------------------------------------------------------------
r23111 | avi@chromium.org | 2009-08-12 01:27:03 +0200 (Wed, 12 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init_browsertest.cc

Don't use external website addresses for testing. Even though we're not trying to load them, they'll cause test failures.

TBR

BUG=none
TEST=tree greens

Review URL: http://codereview.chromium.org/165340
------------------------------------------------------------------------
r23105 | tc@google.com | 2009-08-12 01:01:42 +0200 (Wed, 12 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Don't focus the location bar if we're in full screen mode.

I originally tried to set the GTK_CAN_FOCUS flag on the autocomplete
edit text_view, but that requires plumbing a method through BrowserToolbar,
LocationBarGtk, and AutocompleteEditViewGtk.  This is easier.

Since the widget is already hidden, it's not in the tab order so other
than explicit calls in code, it's not possible to give the gtk text view
focus.

BUG=14945

Review URL: http://codereview.chromium.org/164342

------------------------------------------------------------------------
r23103 | thakis@chromium.org | 2009-08-12 00:50:13 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_mac.h
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/chrome.gyp

Add "dangerous download" view on OS X, for now for dmg files. Also fix download item layout.

BUG=14667,17831
TEST=Download a dmg file. Make sure the "dangerous download" view appears. Check that both buttons work, and that the dmg filename is elided correctly. Also test that "Remove" on a normal download item's context menu relayouts the remaining items on the shelf.

Review URL: http://codereview.chromium.org/165295
------------------------------------------------------------------------
r23099 | estade@chromium.org | 2009-08-12 00:25:07 +0200 (Wed, 12 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

Download item gtk tidbits:

- Add histograms for clickjacking
- Load correct icon for dangerous download items (credit to Nico Weber)

Review URL: http://codereview.chromium.org/164337
------------------------------------------------------------------------
r23091 | thakis@chromium.org | 2009-08-12 00:03:17 +0200 (Wed, 12 Aug 2009) | 37 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/scoped_nsobject.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/constrained_window_mac.h
   A /trunk/src/chrome/browser/cocoa/constrained_window_mac.mm
   A /trunk/src/chrome/browser/cocoa/download_request_dialog_delegate_mac.h
   A /trunk/src/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add support for constrained windows on os x, based on Avi's GTMWindowSheetController. Add carpet bombing dialog as first per-tab sheet.

Depends http://codereview.appspot.com/105064 .

The main issue with this patch is that GTMWindowSheetController doesn't provide an api to move sheets between windows, so this CL disables tab dragging for tabs with sheets, and fullscreen mode for windows with sheets. We can fix this later.

Other stuff that should be done at some point, but not now:

* Open/Save panels should be per-tab
* Need an ui test that goes to page, then page with sheet, then hit back, forward, reload.
* Bookmark sheets should not be sheets but in a separate window

BUG=14666
TEST=Go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , a per-window sheet should appear. Things to test with this dialog:

* Hitting cmd-q while a sheet is open in any tab should not quit but instead focus the sheet.

* Hitting cmd-w while a sheet is open in any tab should not close the window but instead focus the sheet.

* Dragging a tab with a sheet should move the window (and keep the tab visible), not detach the tab.

* Going fullscreen should be disabled for windows with open tabs.

* When a per-tab sheet is open in a non-active tab, it shouldn't steal the focus, i.e. going to the page above, then hitting cmd-t, and then hitting cmd-l should work.

* Closing a non-frontmost tab with a per-tab sheet shouldn't crash.

* Going to the url above and quickly opening a new tab, so that the sheet opens while its tab is not front-most should work (sheet should display only when you switch back to the tab with the sheet).

* Go to google.com, then to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html ,
  hit "backward" with open sheet, hit forward, focus location bar, hit enter. This shouldn't crash.

* Hitting escape should dismiss the sheet

* Hitting enter should confirm the sheet.

Review URL: http://codereview.chromium.org/159780
------------------------------------------------------------------------
r23089 | erg@chromium.org | 2009-08-11 23:58:13 +0200 (Tue, 11 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

GTK Themes: Use a consistent border color along all webcontent.

The color used in the status bubble is now used in the top margin
and in the download bar. This doesn't convert the popup notification,
as that needs additional changes...

Review URL: http://codereview.chromium.org/164345
------------------------------------------------------------------------
r23087 | markus@chromium.org | 2009-08-11 23:46:07 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   A /trunk/src/sandbox/linux/seccomp
   A /trunk/src/sandbox/linux/seccomp/access.cc
   A /trunk/src/sandbox/linux/seccomp/clone.cc
   A /trunk/src/sandbox/linux/seccomp/debug.cc
   A /trunk/src/sandbox/linux/seccomp/debug.h
   A /trunk/src/sandbox/linux/seccomp/exit.cc
   A /trunk/src/sandbox/linux/seccomp/getpid.cc
   A /trunk/src/sandbox/linux/seccomp/gettid.cc
   A /trunk/src/sandbox/linux/seccomp/ioctl.cc
   A /trunk/src/sandbox/linux/seccomp/ipc.cc
   A /trunk/src/sandbox/linux/seccomp/library.cc
   A /trunk/src/sandbox/linux/seccomp/library.h
   A /trunk/src/sandbox/linux/seccomp/linux_syscall_support.h
   A /trunk/src/sandbox/linux/seccomp/madvise.cc
   A /trunk/src/sandbox/linux/seccomp/maps.cc
   A /trunk/src/sandbox/linux/seccomp/maps.h
   A /trunk/src/sandbox/linux/seccomp/mmap.cc
   A /trunk/src/sandbox/linux/seccomp/mprotect.cc
   A /trunk/src/sandbox/linux/seccomp/munmap.cc
   A /trunk/src/sandbox/linux/seccomp/mutex.h
   A /trunk/src/sandbox/linux/seccomp/open.cc
   A /trunk/src/sandbox/linux/seccomp/sandbox.cc
   A /trunk/src/sandbox/linux/seccomp/sandbox.h
   A /trunk/src/sandbox/linux/seccomp/sandbox_impl.h
   A /trunk/src/sandbox/linux/seccomp/securemem.cc
   A /trunk/src/sandbox/linux/seccomp/securemem.h
   A /trunk/src/sandbox/linux/seccomp/socketcall.cc
   A /trunk/src/sandbox/linux/seccomp/stat.cc
   A /trunk/src/sandbox/linux/seccomp/syscall.cc
   A /trunk/src/sandbox/linux/seccomp/syscall.h
   A /trunk/src/sandbox/linux/seccomp/syscall_table.c
   A /trunk/src/sandbox/linux/seccomp/syscall_table.h
   A /trunk/src/sandbox/linux/seccomp/tls.h
   A /trunk/src/sandbox/linux/seccomp/trusted_process.cc
   A /trunk/src/sandbox/linux/seccomp/trusted_thread.cc
   A /trunk/src/sandbox/linux/seccomp/x86_decode.cc
   A /trunk/src/sandbox/linux/seccomp/x86_decode.h
   M /trunk/src/sandbox/sandbox.gyp

Initial version of the Seccomp sandbox. Imported from http://code.google.com/p/seccompsandbox/
Make the seccomp sandbox dependant on the --enable-seccomp-sandbox flag

Review URL: http://codereview.chromium.org/165310

------------------------------------------------------------------------
r23086 | willchan@chromium.org | 2009-08-11 23:43:11 +0200 (Tue, 11 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/snippet.cc

Linux: Add CHECKs to track down source of history std::string out of range exceptions.
BUG=http://crbug.com/15261

Review URL: http://codereview.chromium.org/164191
------------------------------------------------------------------------
r23085 | kuchhal@chromium.org | 2009-08-11 23:40:55 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Do not import homepage on First Run if a homepage is given in master preferences.

BUG=9048

Review URL: http://codereview.chromium.org/164291
------------------------------------------------------------------------
r23084 | ericroman@google.com | 2009-08-11 23:38:54 +0200 (Tue, 11 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/leak_tracker.h
   A /trunk/src/base/leak_tracker_unittest.cc
   A /trunk/src/base/linked_list.h
   A /trunk/src/base/linked_list_unittest.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/net/url_request/url_request.h

Add checks to DEBUG mode that no instance of URLRequest or URLFetcher survives the destruction of the IO thread.

This checking is done by introducing a new helper class to base called LeakTracker. Classes that you want to check for leaks just need to extend LeakTracker.

The reason I am picking on URLFetcher / URLRequest, is I believe we have a bug that is making an instance of URLFetcher to outlive the IO thread.

This causes various sorts of badness.

For example:
If URLFetcher survives the IO thread, then URLRequestContext remains referenced and therefore also survives IO thread. In turn HostResolverImpl survives the IO thread, so any outstanding resolve requests are NOT cancelled before the IO thread is decomissioned. So now, when the worker thread doing the DNS resolve finally finishes (assuming it finishes before the rogue URLRequest is destroyed), it post the result to a defunct message loop. KAB00m! (http://crbug.com/15513)

Moreover, I believe we hit this same problem sporadically in AutomationProxyTest.AutocompleteGetSetText -- the test is flaky on the buildbots, and I've seen DCHECKs which suggest it is related to this issue.

BUG=http://crbug.com/18372
Review URL: http://codereview.chromium.org/160447
------------------------------------------------------------------------
r23082 | sky@chromium.org | 2009-08-11 23:32:30 +0200 (Tue, 11 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_dnd_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_dnd_util.h

Refactors code to extract urls out of bookmark_utils and into GtkDndUtil.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/164322
------------------------------------------------------------------------
r23081 | glen@chromium.org | 2009-08-11 23:32:17 +0200 (Tue, 11 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

With the recent NNTP changes, we change the way themes work - they're now closer to NTP1 theming - ntp_section_* is used to control the display of the light blue sections, and we've added ntp_header that controls the dark blue hover color, ntp_header falls back to ntp_section if provided.

Also fix a minor bug where the default theme was saving theme data - we were generating colors before saving the provided colors.

BUG=18720,18722
TEST=Install a theme and verify that the recently closed section is themed correctly.

Review URL: http://codereview.chromium.org/165192
------------------------------------------------------------------------
r23080 | jeremy@chromium.org | 2009-08-11 23:31:17 +0200 (Tue, 11 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/nibs/ImportProgressDialog.xib
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm
   A /trunk/src/chrome/browser/cocoa/import_progress_dialog.h
   A /trunk/src/chrome/browser/cocoa/import_progress_dialog.mm
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/chrome.gyp

First Run Import Progress UI.

First run code needed some reworking in order to get things in order for progress notification.

BUG=18773
TEST=When importing another browser's settings, a progress dialog should be displayed.

Review URL: http://codereview.chromium.org/164290
------------------------------------------------------------------------
r23078 | jhawkins@chromium.org | 2009-08-11 23:29:06 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

gtk: Disconnect the accelerator group keys when closing the browser window.

BUG=10737
TEST=Watch the valgrind bot stay green.
Review URL: http://codereview.chromium.org/164294
------------------------------------------------------------------------
r23077 | avi@chromium.org | 2009-08-11 23:28:08 +0200 (Tue, 11 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/browser_init_browsertest.cc
   M /trunk/src/chrome/chrome.gyp

Ensure we have a valid profile when using
BrowserInit::LaunchWithProfile::OpenURLsInBrowser() directly and the browser
passed in is a popup window.

Original Review URL: http://codereview.chromium.org/160331

BUG=http://crbug.com/17520
TEST=see bug.

Review URL: http://codereview.chromium.org/164341
------------------------------------------------------------------------
r23074 | mark@chromium.org | 2009-08-11 23:27:30 +0200 (Tue, 11 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/common/chrome_paths.cc

Use real creator code for Keychain items.  Instead of hard-coding 'rimZ', use
the correct creator code for the application.  This is 'rimZ' for branded
Google Chrome, and 'Cr24' for Chromium.

BUG=19000
TEST=No functional change in Google Chrome-branded builds
Review URL: http://codereview.chromium.org/164332
------------------------------------------------------------------------
r23073 | sgk@google.com | 2009-08-11 22:56:18 +0200 (Tue, 11 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Revert 23064 - Ensure we don't load plugins on the IO thread

BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/165321
------------------------------------------------------------------------
r23070 | brettw@chromium.org | 2009-08-11 21:45:19 +0200 (Tue, 11 Aug 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/app/theme/compactnav_back.png
   A /trunk/src/chrome/app/theme/compactnav_chrome.png
   A /trunk/src/chrome/app/theme/compactnav_forward.png
   A /trunk/src/chrome/app/theme/compactnav_separator.png
   A /trunk/src/chrome/app/theme/statusbar_battery.png
   A /trunk/src/chrome/app/theme/statusbar_menu.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/defaults.cc
   M /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   A /trunk/src/chrome/browser/views/compact_navigation_bar.cc
   A /trunk/src/chrome/browser/views/compact_navigation_bar.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   A /trunk/src/chrome/browser/views/frame/status_area_view.cc
   A /trunk/src/chrome/browser/views/frame/status_area_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp

Add a first attempt at a compact location bar and a status bar. The status bar
contains a clock, an application menu, and a non-working battery indicator.
The compact location bar can be toggled by COMPACT_NAV_BAR in browser_window_gtk.cc
Review URL: http://codereview.chromium.org/165272
------------------------------------------------------------------------
r23069 | estade@chromium.org | 2009-08-11 21:44:00 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc

Add more window icons.

BUG=19015,19016

Review URL: http://codereview.chromium.org/164331
------------------------------------------------------------------------
r23064 | jam@chromium.org | 2009-08-11 21:25:38 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Ensure we don't load plugins on the IO thread

BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
------------------------------------------------------------------------
r23061 | hclam@chromium.org | 2009-08-11 21:09:28 +0200 (Tue, 11 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/media/audio/audio_output.h

AudioRendererHost send ViewMsg_AudioStreamState

AudioRendererHost should use ViewMsg_AudioStreamState to
notify renderer of its state instead of AudioOutputStream::State.
The enum of AudioOutputStream::State is not used anywhere, thus
removed.

TEST=unit_tests --gtest_filter=Audio*

Review URL: http://codereview.chromium.org/165255
------------------------------------------------------------------------
r23057 | thestig@chromium.org | 2009-08-11 20:45:13 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_paths_internal.h
   M /trunk/src/chrome/common/chrome_paths_linux.cc

Use $XDG_CACHE_HOME for the cache on Linux. This only works for the default profile.

BUG=16976
TEST=Run Chromium, visit some webpages, make sure it's using the cache under $XDG_CACHE_HOME (~/.cache by default)
Review URL: http://codereview.chromium.org/159028
------------------------------------------------------------------------
r23055 | aa@chromium.org | 2009-08-11 20:37:38 +0200 (Tue, 11 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h

Make the theme install infobar have an 'undo' button instead
of a 'back to default' button.

BUG=18986
TEST=none

Review URL: http://codereview.chromium.org/164312
------------------------------------------------------------------------
r23052 | tc@google.com | 2009-08-11 20:12:59 +0200 (Tue, 11 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Make app modal dialogs (from javascript) actually be app modal.  This
is similar to the behavior on Windows, although they only fake app
modality.

BUG=18123

Review URL: http://codereview.chromium.org/164296

------------------------------------------------------------------------
r23050 | agl@chromium.org | 2009-08-11 20:09:12 +0200 (Tue, 11 Aug 2009) | 45 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/webkit/api/public/gtk/WebFontInfo.h
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   M /trunk/src/webkit/api/src/gtk/WebFontInfo.cpp

Linux: Make SandboxIPCProcess not be a WebKitClient

Previously, SandboxIPCProcess had to be a full WebKitClient because of
the following assertion failure:

0  0x08af0a77 in buildBaseTextCodecMaps ()
   at
third_party/WebKit/WebCore/platform/text/TextEncodingRegistry.cpp:176
1  0x08af0e73 in WebCore::atomicCanonicalTextEncodingName
(name=0x985d665 "UTF-8")
   at
third_party/WebKit/WebCore/platform/text/TextEncodingRegistry.cpp:241
2  0x08aee811 in TextEncoding (this=0xb876ef8, name=0x985d665 "UTF-8")
   at third_party/WebKit/WebCore/platform/text/TextEncoding.cpp:61
3  0x08aee88a in WebCore::UTF8Encoding ()
   at third_party/WebKit/WebCore/platform/text/TextEncoding.cpp:266
4  0x08ae744c in WebCore::String::fromUTF8 (string=0x56d7a120
"�226\207�211�233正�221",
   size=15) at third_party/WebKit/WebCore/platform/text/String.cpp:674
5  0x0872a7c0 in WebKit::WebString::fromUTF8 (data=0x56d7a120
"�226\207�211�233正�221",
   length=15) at webkit/api/src/WebString.cpp:72
6  0x087245bd in WebKit::WebFontInfo::familyForChars
(characters=0x56c11628, numCharacters=1)
   at webkit/api/src/gtk/WebFontInfo.cpp:98
7  0x0847599a in SandboxIPCProcess::HandleGetFontFamilyForChars
(this=0xff869ba8, fd=29,
   pickle=@0xff86900c, iter=0xff869054, fds=@0xff86901c)
   at chrome/browser/renderer_host/render_sandbox_host_linux.cc:215
8  0x08475d70 in SandboxIPCProcess::HandleRequestFromRenderer
(this=0xff869ba8, fd=29)
   at chrome/browser/renderer_host/render_sandbox_host_linux.cc:115
9  0x08475fea in SandboxIPCProcess::Run (this=0xff869ba8)
   at chrome/browser/renderer_host/render_sandbox_host_linux.cc:84
10 0x084747f9 in RenderSandboxHostLinux (this=0x56c10e78)
   at chrome/browser/renderer_host/render_sandbox_host_linux.cc:299

This this patch, we remove the need to use WebString and the codec
translation (which was just a translation from UTF8 to UTF16 and back
again anyway) and thus can remove all of the WebKitClient gubbins.

BUG=17260

http://codereview.chromium.org/164112

------------------------------------------------------------------------
r23048 | sidchat@google.com | 2009-08-11 20:04:49 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Fix a spell check dictionary download bug, where killing the spell checker while downloading the dictionary leads to a crash. This is happening for my auto-language detection feature, which sometimes kills a spellchecker while it is downloading a dictionary file. Hopefully, this is also a fix for BUG 18743.

BUG=www.crbug.com/18743
TEST=none
Review URL: http://codereview.chromium.org/165175
------------------------------------------------------------------------
r23041 | tc@google.com | 2009-08-11 19:30:08 +0200 (Tue, 11 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Fix the theme overlay when the window is maximized and inactive.  We
were drawing the active overlay.

TEST=Install the Zen Spring theme, maximize chrome, and select a different
  window.  The overlay should be dimmed.

Review URL: http://codereview.chromium.org/164271

------------------------------------------------------------------------
r23036 | idanan@chromium.org | 2009-08-11 18:52:59 +0200 (Tue, 11 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/privacy_blacklist/blocked_response.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blocked_response.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   A /trunk/src/chrome/browser/resources/privacy_blacklist_block.html
   A /trunk/src/chrome/browser/resources/privacy_blacklist_block.png
   M /trunk/src/chrome/chrome.gyp

Blocked Resource Responses

Added resources used for replacing HTML elements when
they are blocked. These were modeled after the malware
response page.

BUG=16932
TEST=none

Review URL: http://codereview.chromium.org/164158
------------------------------------------------------------------------
r23025 | derat@chromium.org | 2009-08-11 17:29:39 +0200 (Tue, 11 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Linux: Load PRIMARY selection on middle-click on new tab button.

BUG=18938,11612,11614
TESTED=highlighted text and checked that middle-click loads it if it's a URL but does nothing if it isn't

Review URL: http://codereview.chromium.org/164282
------------------------------------------------------------------------
r23023 | avi@chromium.org | 2009-08-11 16:36:52 +0200 (Tue, 11 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm

Allow theming of colors for the Mac.

BUG=http://crbug.com/18438
TEST=none

Review URL: http://codereview.chromium.org/162010
------------------------------------------------------------------------
r23019 | sky@chromium.org | 2009-08-11 16:03:45 +0200 (Tue, 11 Aug 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/login_model.h
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/chrome.gyp

Splits out the LoginModel into a separate class so that we other
platforms aren't including views.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/164269
------------------------------------------------------------------------
r23017 | thomasvl@chromium.org | 2009-08-11 15:32:21 +0200 (Tue, 11 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/build/mac/generate_localizer
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/app/nibs/BookmarkNameFolder.xib
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/ui_localizer.h
   M /trunk/src/chrome/browser/cocoa/ui_localizer.mm
   M /trunk/src/chrome/chrome.gyp

ObjC classes generated by the build and used in Xib files is already getting ugly, if they aren't built at build start, IB sometimes throws warnings about unknown things, so...
  - Use one class for the localizer and generate the table that drives it.
  - Update the generator script to process a list of xib files and generate one header.
  - Update the data within the GYP file to do this.
  - This might actually help overall size since it helps force one set of strings for each different window.
  - Switch to bsearch for table lookup since we have one, larger table now.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164260
------------------------------------------------------------------------
r23016 | yusukes@google.com | 2009-08-11 14:17:37 +0200 (Tue, 11 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

Modified the toolbar button handlers so that the handlers can revert the location bar when the button pressed is RELOAD, FORWARD, or BACK.

Note that this change does not handle F5 nor Ctrl-r key presses. That's intentional. Please see the comment #7 by pkasting in http://crbug.com/15464 .

Windows change: http://codereview.chromium.org/155908
Mac change: http://codereview.chromium.org/164145

BUG=18710
TEST=The same as http://codereview.chromium.org/155908

Review URL: http://codereview.chromium.org/164137
------------------------------------------------------------------------
r23015 | jorlow@chromium.org | 2009-08-11 09:36:53 +0200 (Tue, 11 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc

Disable some unit tests.

TEST=none
BUG=19002

Review URL: http://codereview.chromium.org/165294
------------------------------------------------------------------------
r23011 | jorlow@chromium.org | 2009-08-11 06:16:43 +0200 (Tue, 11 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   M /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   M /trunk/src/webkit/api/public/WebStorageArea.h
   M /trunk/src/webkit/api/src/StorageAreaProxy.cpp
   M /trunk/src/webkit/api/src/StorageAreaProxy.h
   M /trunk/src/webkit/api/src/WebStorageAreaImpl.cpp
   M /trunk/src/webkit/api/src/WebStorageAreaImpl.h

The spec for ____storage.key() changed.  Now, instead of raising an exception when you try to access a key
at an index that's greater than or equal to ___Storage.length, it simply returns a null.

This is yet another demonstration of why we need a NullableString16 (rather than passing around a string and 
a bool) but this cannot block on that work.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/165289
------------------------------------------------------------------------
r23007 | tim@chromium.org | 2009-08-11 05:20:47 +0200 (Tue, 11 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc

Add the default sync service URL.

Review URL: http://codereview.chromium.org/164307
------------------------------------------------------------------------
r23006 | mark@chromium.org | 2009-08-11 05:12:01 +0200 (Tue, 11 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/build/mac/dump_app_syms
   M /trunk/src/build/mac/tweak_app_infoplist
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h

Re-commit r22981 after backout at r22992.  Contains fixes to relocate
plugin_carbon_interpose.dylib from the outer browser app bundle to the inner
helper app bundle.

Provide a separate app bundle for subprocesses like the renderer on the Mac.
Remove LSUIElement and related hacks from the browser's app bundle.

BUG=8044
TEST=Observe one Chromium and one or more Chromium Helper processes in
     Activity Monitor
Review URL: http://codereview.chromium.org/164177
Review URL: http://codereview.chromium.org/164303
------------------------------------------------------------------------
r23004 | tim@chromium.org | 2009-08-11 04:36:34 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/sync/engine/syncapi.h
   A /trunk/src/chrome/browser/sync/engine/syncapi_stub.cc
   M /trunk/src/chrome/browser/sync/personalization.cc
   M /trunk/src/chrome/browser/sync/personalization.h
   M /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Build browser/sync files by default using a stubbed-out syncapi
implementation.  The stub will be replaced once the rest of
sync/engine lands as we open source the sync engine code.

Review URL: http://codereview.chromium.org/165257
------------------------------------------------------------------------
r23003 | estade@chromium.org | 2009-08-11 04:20:18 +0200 (Tue, 11 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Fix up bookmark bar event stuff.

Make instructions a drag target and also make it possible to right click on it.

Also fix http://crbug.com/18967

Also report the right action in the drag motion handler (MOVE vs. COPY).

BUG=18967

Review URL: http://codereview.chromium.org/164295
------------------------------------------------------------------------
r23002 | idana@chromium.org | 2009-08-11 04:17:22 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/personalization_strings.h
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Added a button to the bookmark bar which shows up when the sync
login credentials expire and we need the user to re-enter their
password.

Review URL: http://codereview.chromium.org/164278
------------------------------------------------------------------------
r23001 | brg@chromium.com | 2009-08-11 04:17:06 +0200 (Tue, 11 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   M /trunk/src/chrome/browser/sync/personalization.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.cc
   M /trunk/src/chrome/browser/sync/profile_sync_service.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.h

Add UMA histograms for chrome-sync.We add the following histograms:Sync.MergeAndSyncNeededCountNumber of times merge and sync is needed to run.Sync.AuthorizationTimeTime taken during initial authorization.Sync.UserPerceivedAuthorizationTimeTime the user spends looking at the authorization dialog.Sync.BookmarkAssociationTimeTime taken during bookmark association.Sync.ReauthorizationTimeTime taken from startup for the user to reauthorize.
Sync.Events
This is an enumeration of distinct events of the following types:

Number of times sync was started from the ad in NTP.Number of times sync was started from the Wrench menu.Number of times sync was started from Wrench->Options.Number of times sync was stopped from Wrench->Options.Number of times sync was stopped during the sign-on process.Number of times sync was stopped after successfully authorized.Number of times sync was cancelled when the merge dialog was surfaces.
BUG=None.
Test=None.

Review URL: http://codereview.chromium.org/165111
------------------------------------------------------------------------
r22998 | phajdan.jr@chromium.org | 2009-08-11 03:57:37 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   D /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   D /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Revert "Fix "crashed extension" infobar browser crashes."

Will it fix browser_tests crashes on Vista?

Review URL: http://codereview.chromium.org/165287
------------------------------------------------------------------------
r22996 | suzhe@chromium.org | 2009-08-11 03:32:49 +0200 (Tue, 11 Aug 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.cc
   A /trunk/src/chrome/browser/renderer_host/gtk_im_context_wrapper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/chrome.gyp

Cleanup GtkIMContext related code by splitting it into separated source file.

This CL splits GtkIMContext related code into separated source files from render_widget_host_view_gtk.{h,cc}, making the code clearer to read. It also fixes issue 18061.
Focus moving issues related to AutocompleteEditViewGtk will be addressed in another CL, see issue 18393 for reference.

BUG=18061: pressing tab on form textfields goes directly to submit or login buttons
TEST=Starts scim's xim server with command "scim -d", then launches chrome with GTK_IM_MODULE=xim. Opens a web page with multiple input box, such as gmail.com, presses Tab and Shift-Tab multiple times to see if focus moves among focusable elements in the web page.

Review URL: http://codereview.chromium.org/160577
------------------------------------------------------------------------
r22992 | mark@chromium.org | 2009-08-11 02:51:02 +0200 (Tue, 11 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/build/mac/dump_app_syms
   M /trunk/src/build/mac/tweak_app_infoplist
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h

Back out r22981, it may have caused Windows test failures.
Review URL: http://codereview.chromium.org/164298
------------------------------------------------------------------------
r22989 | estade@chromium.org | 2009-08-11 02:34:52 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Add back numpad accelerators that were lost in r22423

BUG=18229

Review URL: http://codereview.chromium.org/165245
------------------------------------------------------------------------
r22988 | estade@chromium.org | 2009-08-11 02:34:17 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Make sure we don't set focus to the findbar until after the focus is restored to the tab contents.

BUG=18294

Review URL: http://codereview.chromium.org/160566
------------------------------------------------------------------------
r22985 | phajdan.jr@chromium.org | 2009-08-11 02:27:14 +0200 (Tue, 11 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/extensions/crashed_extension_infobar.cc
   A /trunk/src/chrome/browser/extensions/crashed_extension_infobar.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Fix "crashed extension" infobar browser crashes.

This is a general rework of how "crashed extension" infobar works
and how the extension is actually recovered after the crash.

TEST=See bug.
http://crbug.com/15888

Review URL: http://codereview.chromium.org/164151
------------------------------------------------------------------------
r22984 | jhawkins@chromium.org | 2009-08-11 02:26:04 +0200 (Tue, 11 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_gtk.cc

gtk: Post the SendNotification in a task on the UI thread.  In rare instances, SendNotifications was being run before CancelAuthDeferred, so the proper cleanup was not happening before this object was deleted which leads to a crash.

BUG=18973
TEST=Instructions in the bug report.
Review URL: http://codereview.chromium.org/165268
------------------------------------------------------------------------
r22983 | paul@chromium.org | 2009-08-11 02:24:20 +0200 (Tue, 11 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc

Commit patch for Pierre-Antoine LaFayette, original CL:
http://codereview.chromium.org/164119

Items in the Downloads page should be loaded like a normal OS file when dragged
to a Tab content area. We need the URL to be set to the file path in the
IDataObject so that WebDropData can properly handle the file.

BUG=9266
TEST=Drag an item with a supported MIME type from the Downloads page to a Tab
content area. It should load within the browser. Drag an item with an
unsupported MIME type and it should not open it.

Review URL: http://codereview.chromium.org/165260
------------------------------------------------------------------------
r22981 | mark@chromium.org | 2009-08-11 02:23:19 +0200 (Tue, 11 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/build/mac/dump_app_syms
   M /trunk/src/build/mac/tweak_app_infoplist
   M /trunk/src/chrome/app/app-Info.plist
   A /trunk/src/chrome/app/helper-Info.plist (from /trunk/src/chrome/app/app-Info.plist:22731)
   A /trunk/src/chrome/app/make_mac_app_symlinks
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h

Provide a separate app bundle for subprocesses like the renderer on the Mac.
Remove LSUIElement and related hacks from the browser's app bundle.

BUG=8044
TEST=Observe one Chromium and one or more Chromium Helper processes in
     Activity Monitor
Review URL: http://codereview.chromium.org/164177
------------------------------------------------------------------------
r22980 | mirandac@chromium.org | 2009-08-11 02:22:24 +0200 (Tue, 11 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h

Mask the close button on the download shelf so that it's visible even in dark themes.

BUG= http://crbug.com/18451
TEST= Install a dark theme, cause download shelf to appear, note that the close button is visible.

Review URL: http://codereview.chromium.org/164276
------------------------------------------------------------------------
r22976 | estade@chromium.org | 2009-08-11 02:00:56 +0200 (Tue, 11 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

GTK: button clicking cleanup.

I found a much better way to implement middle-click-to-navigate: use gtk_get_current_event() to get the button release event that triggered the "clicked" signal. This simplifies greatly a lot of places that I had previously added complication.

Also this adds middle click to navigate on the go button.
Also this makes middle click on a bookmark bar button depress the button.


Review URL: http://codereview.chromium.org/165261
------------------------------------------------------------------------
r22973 | paul@chromium.org | 2009-08-11 01:58:21 +0200 (Tue, 11 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Fix a bug when exiting Mac Chrome with in progress downloads.

If the user has closed all browser windows and then tries to exit
with downloads in progress, Mac Chrome would just quit. This CL
handles the case of exiting without any windows open.

BUG=15899 (http://crbug.com/15899)
TEST=Start a download, close all windows then try to exit. Chrome
     will now prompt the user with an exit confirm dialog.
Review URL: http://codereview.chromium.org/164273
------------------------------------------------------------------------
r22947 | estade@chromium.org | 2009-08-10 22:11:23 +0200 (Mon, 10 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/app/gfx/canvas.h
   M /trunk/src/app/gfx/canvas_linux.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Use system default favicon in tab strip when using GTK theme.

Review URL: http://codereview.chromium.org/164266
------------------------------------------------------------------------
r22946 | tc@google.com | 2009-08-10 22:09:31 +0200 (Mon, 10 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Have the restored size returned when the browser asks for it.  This
fixes a bug where new windows would open to the full desktop size
and the WM would treat it specially.

TEST=Maximize chrome, open a new window.  It shouldn't be the size of a maximized window.
BUG=18952

Review URL: http://codereview.chromium.org/165248

------------------------------------------------------------------------
r22945 | tc@google.com | 2009-08-10 22:09:04 +0200 (Mon, 10 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Update the window shape after changing themes.  We were losing the rounded
corners on theme change in the options dialog.

Review URL: http://codereview.chromium.org/165256

------------------------------------------------------------------------
r22942 | jhawkins@chromium.org | 2009-08-10 22:07:37 +0200 (Mon, 10 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

gtk: Don't crash if the user double clicks an empty area of the task manager tree view.

BUG=18960
TEST=Double click the empty space of the task manager tree view.  The browser should not crash.
Review URL: http://codereview.chromium.org/165253
------------------------------------------------------------------------
r22941 | thakis@chromium.org | 2009-08-10 22:05:29 +0200 (Mon, 10 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Make mouse cursor temporarily hide on keyboard input.

Note: We are very liberal in hiding the mouse cursor, much like Preview
and some other apps. Safari is much more conservative (e.g., press "x"
in random text content), but for us to do that we'd have to wire up the
renderer to tell us when to hide the cursor.

BUG=14077
TEST=Give web content keyboard focus, press various keys.

Patch by viettrungluu@gmail.com

Review URL: http://codereview.chromium.org/165252
------------------------------------------------------------------------
r22933 | pkasting@chromium.org | 2009-08-10 20:54:18 +0200 (Mon, 10 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc

Change "Cancelled" to "Canceled".  Original patch by Thiago Farina (see http://codereview.chromium.org/165097 ), r=me.

BUG=none
TEST=none
------------------------------------------------------------------------
r22930 | jhawkins@chromium.org | 2009-08-10 20:41:48 +0200 (Mon, 10 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

gtk: Desensitize the "End Process" button when first loading the task manager.

BUG=18582
TEST=Open the task manager.  The "End Process" button should not be sensitive.
Review URL: http://codereview.chromium.org/164261
------------------------------------------------------------------------
r22929 | tc@google.com | 2009-08-10 20:10:56 +0200 (Mon, 10 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Work around a compiz bug where starting chrome and trying to maximize
would render the window as maximized, but the window state wouldn't be
set properly.

TEST=Start chrome, maximize chrome, close chrome.  Restart chrome.  Window
  controls in compiz should be the maximized version and there should
  be no rounded corners.

Review URL: http://codereview.chromium.org/165186

------------------------------------------------------------------------
r22927 | ananta@chromium.org | 2009-08-10 20:07:37 +0200 (Mon, 10 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/renderer/render_view.cc

If URL requests are to be routed through the external host, the ExternalTabContainer instantiates
an automation profile object which implements the Profile interface. This object was not being 
passed the external tab handle which is needed for cookies to be set correctly in the external host. 

HTTP Post requests should not be treated as top level URL requests to be handled by the external host.
These were getting converted incorrectly to HTTP Get requests thus resulting in Post requests not
working correctly in the external tab container.

Fixes bug http://b/issue?id=2042101

Bug=2042101


Review URL: http://codereview.chromium.org/164207
------------------------------------------------------------------------
r22926 | jrg@chromium.org | 2009-08-10 20:05:17 +0200 (Mon, 10 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Fix bookmark bar chevron not being pinned to right when launch with bar open.

TEST=\
Make browser window thin (e.g. 400pix wide).
Show bookmark bar.  Quit.  Relaunch.
Make sure the "off the side" chevron on the bookmark bar is pinned to the right of the window.
Resize width wider and thinner a little; make sure chevron stays pinned.
Make browser window wide (e.g. 1000pix wide).
Quit.  Relaunch.
Make sure chevron is pinned to the right of the window.
Repeat all these tests but close the bookmark bar before quitting so it starts life closed.

Review URL: http://codereview.chromium.org/165207
------------------------------------------------------------------------
r22924 | tc@google.com | 2009-08-10 19:55:46 +0200 (Mon, 10 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Only have middle click lower the window if we hit the titlebar or
window edge.  Middle clicking a link on the page shouldn't do
this.

BUG=15430

Review URL: http://codereview.chromium.org/164257

------------------------------------------------------------------------
r22921 | sky@chromium.org | 2009-08-10 19:33:43 +0200 (Mon, 10 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_service.cc

Changes SessionService to make sure a Pickle is deleted before the
memory the pickle was created from is deleted. I don't think the
current code actually causes a problem as Pickle's destructor won't
attempt to delete the memory in this case, but I'm adding this to make
it clear the Pickle should be deleted and prevent any future problems.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165241
------------------------------------------------------------------------
r22917 | dglazkov@chromium.org | 2009-08-10 17:27:19 +0200 (Mon, 10 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc

Rework visited link updating mechanism to be more robust.

This is a follow-up to http://src.chromium.org/viewvc/chrome?view=rev&revision=22540,
which eliminated one crash, but still left behind another, this time due to
racing between history backend and WebView creation.

The solution is to make sure no visited-link-related messages are sent to the
rendering process until we know for sure it is created.

BUG=17555
TEST=VisitedLinkeRelayTest.WebViewReadiness
R=darin


Review URL: http://codereview.chromium.org/165210
------------------------------------------------------------------------
r22907 | hbono@chromium.org | 2009-08-10 11:25:34 +0200 (Mon, 10 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist.cc

A blind fix for Issue 18837 (and a build fix for VS2008)
To read this crash dump, this issue is caused by my mistake that this jumplist.cc calls "icon_urls_.front()" for an empty list.
This change added some checks that verifies a std::list has one or more items.
This change also fixes linker errors because of conflicted symbols: CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused by my mistake that I forgot removing "EXTERN_C" keywords when I moved them into an anonymous namespace. This change removes the "EXTERN_C" keywords for VS2008.

BUG=18837 "Crash - JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned char> >,bool,GURL)"
TEST=Show JumpList on Windows 7.
TEST=Build Chromium with VS2008.
Review URL: http://codereview.chromium.org/159853
------------------------------------------------------------------------
r22895 | thakis@chromium.org | 2009-08-10 07:07:39 +0200 (Mon, 10 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   A /trunk/src/chrome/browser/views/url_picker.cc (from /trunk/src/chrome/browser/views/shelf_item_dialog.cc:22894)
   A /trunk/src/chrome/browser/views/url_picker.h (from /trunk/src/chrome/browser/views/shelf_item_dialog.h:22894)
   M /trunk/src/chrome/chrome.gyp

Renaming the class ShelfItemDialog to URLPicker, and ShelfItemDialogDelegate to URLPickerDelegate.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/164149
------------------------------------------------------------------------
r22894 | yusukes@google.com | 2009-08-10 06:54:23 +0200 (Mon, 10 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Modified the browser controller so that it can revert the location bar when a user pressed RELOAD, FORWARD, or BACK buttons.

Note that this change does not revert the bar when Command+r is pressed. That's intentional. Please see the comment #7 by pkasting in http://crbug.com/15464 .

Windows change: http://codereview.chromium.org/155908
Linux change: http://codereview.chromium.org/164137

BUG=18710
TEST=The same as http://codereview.chromium.org/155908 (except the F5 stuff since Chromium Mac seems not to support F5 reload?)

Review URL: http://codereview.chromium.org/164145
------------------------------------------------------------------------
r22893 | thakis@chromium.org | 2009-08-10 06:30:39 +0200 (Mon, 10 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm

add "remove" to download item context menu on mac

BUG=60
TEST=Download something, open context menu, click "remove" -- item should be removed from shelf. It leaves a hole behind right now (bug 17831), will fix that later.

Review URL: http://codereview.chromium.org/160444
------------------------------------------------------------------------
r22886 | jnd@chromium.org | 2009-08-09 14:58:03 +0200 (Sun, 09 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc

vector.end() is out of range, need to erase (end() - 1)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165045
------------------------------------------------------------------------
r22885 | evan@chromium.org | 2009-08-09 07:29:17 +0200 (Sun, 09 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

On GTK, middle-click on the title bar (and the window frame in general) will
lower the window. This is Chromium's custom titlebar, not the one provided
by the window manager.

BUG=15430

Review URL: http://codereview.chromium.org/165123
Patch from Nigel Tao <nigeltao@google.com>.
------------------------------------------------------------------------
r22884 | evan@chromium.org | 2009-08-09 07:20:49 +0200 (Sun, 09 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc

When importing bookmarks from Firefox, filter out the default bookmarks.

The existing code attempted to do this but it had a bug.

BUG=18530

Review URL: http://codereview.chromium.org/165094
Patch from Doug Muir <dmuir@google.com>.
------------------------------------------------------------------------
r22870 | jorlow@chromium.org | 2009-08-08 22:38:30 +0200 (Sat, 08 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Completely disable DOM Storage UI test until https://bugs.webkit.org/show_bug.cgi?id=28094 is in.  Until then, this will be flaky and crash the browser.

TBR=jam
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165211
------------------------------------------------------------------------
r22868 | jorlow@chromium.org | 2009-08-08 21:14:29 +0200 (Sat, 08 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Re-enable the ui test based layout tests for DOM Storage.

TBR=jam
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/164227
------------------------------------------------------------------------
r22858 | mad@google.com | 2009-08-08 04:33:26 +0200 (Sat, 08 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h

Committing for Siggi based on review:
http://codereview.chromium.org/165134


------------------------------------------------------------------------
r22855 | estade@chromium.org | 2009-08-08 04:18:31 +0200 (Sat, 08 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.h

GTK: Use stock icons for bookmark folder and default favicon.

In the main window, in the default theme, we still use the chrome icons.

There are still several more places that need updating: the tab strip, the task manager, etc. I will deal with that later.

BUG=13320

Review URL: http://codereview.chromium.org/165194
------------------------------------------------------------------------
r22840 | glen@chromium.org | 2009-08-08 02:44:16 +0200 (Sat, 08 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Fix for bookmark bar text not being correct in subsequent Windows. I believe this bug was masked by how long bookmarks take to create in the primary window (as the bookmark system is loaded late)

BUG=18550
TEST=Install a theme with custom colors for bookmark bar text, then open a new window and verify that the bookmark bar text is themed correctly.

Review URL: http://codereview.chromium.org/165172
------------------------------------------------------------------------
r22839 | erg@google.com | 2009-08-08 02:34:33 +0200 (Sat, 08 Aug 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/app/theme/back_noborder.png
   A /trunk/src/chrome/app/theme/forward_noborder.png
   A /trunk/src/chrome/app/theme/go_noborder.png
   A /trunk/src/chrome/app/theme/go_noborder_center.png
   A /trunk/src/chrome/app/theme/home_noborder.png
   A /trunk/src/chrome/app/theme/reload_noborder.png
   M /trunk/src/chrome/app/theme/star_noborder.png
   A /trunk/src/chrome/app/theme/star_noborder_center.png
   M /trunk/src/chrome/app/theme/starred_noborder.png
   A /trunk/src/chrome/app/theme/starred_noborder_center.png
   A /trunk/src/chrome/app/theme/stop_noborder.png
   A /trunk/src/chrome/app/theme/stop_noborder_center.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

GTK Theme: Use Glen's new non-border

Imports Glen's new icons, and creates centered versions of all of them. Then
use these icons in the GTK theme interface.

Also selects the button tinting color to be a lighter color on some very dark
backgrounds.

Review URL: http://codereview.chromium.org/164202
------------------------------------------------------------------------
r22824 | estade@chromium.org | 2009-08-08 01:12:01 +0200 (Sat, 08 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

Revert accidental change that snuck into my last patch.

TBR=senorblanco

Review URL: http://codereview.chromium.org/164204
------------------------------------------------------------------------
r22820 | estade@chromium.org | 2009-08-08 01:02:08 +0200 (Sat, 08 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

GTK: Make the bookmark bar folder menus dismiss properly.

- They will not dismiss when you show and then hide a context menu (unless that context menu initiates certain actions such as "Edit").
- They will dismiss when you click away from them.

BUG=18523

Review URL: http://codereview.chromium.org/164183
------------------------------------------------------------------------
r22817 | idana@chromium.org | 2009-08-08 00:56:16 +0200 (Sat, 08 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/auth_error_state.h
   M /trunk/src/chrome/browser/sync/personalization_strings.h
   M /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc

Fixed the message which appears when the user is asked to re-login when the login credentials expire.

Review URL: http://codereview.chromium.org/164161
------------------------------------------------------------------------
r22814 | paul@chromium.org | 2009-08-08 00:47:56 +0200 (Sat, 08 Aug 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h

Fix for an "update in progress" DCHECK.

A DCHECK in SafeBrowsingService::UpdateStarted can potentially be
triggered if there is an error opening the database for reading,
or if there is no response from the server for a update request.
Both of these cases can cause our 'update_in_progress_' flag to
not be reset properly before the next update.

This CL adds:
- a timeout for update responses
- better handling for database errors
that properly resets the update state.

BUG=12835 (http://crbug.com/12835)
TEST=None.

Review URL: http://codereview.chromium.org/165008
------------------------------------------------------------------------
r22799 | stuartmorgan@google.com | 2009-08-08 00:03:17 +0200 (Sat, 08 Aug 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.cc
   A /trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   A /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc
   A /trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/webkit.gyp

Set up a interposing library for Carbon calls made by plugins.

This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation.

This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs.

BUG=18203,18553
TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus.

Review URL: http://codereview.chromium.org/164100
------------------------------------------------------------------------
r22792 | tc@google.com | 2009-08-07 23:18:15 +0200 (Fri, 07 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Check the bookmark bar state when updating the title of the page.

Windows does this too, it's just not an explicit call.

BUG=18602

Review URL: http://codereview.chromium.org/165158

------------------------------------------------------------------------
r22791 | tc@google.com | 2009-08-07 23:17:16 +0200 (Fri, 07 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Use the inactive window overlay when the window is inactive.

TEST=Install the Zen Spring theme and activate a different window.
  The tree overlay should be lighter.

Review URL: http://codereview.chromium.org/164186

------------------------------------------------------------------------
r22784 | ananta@chromium.org | 2009-08-07 22:52:58 +0200 (Fri, 07 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

The UrlRequestAutomationJob::GetResponseInfo function needs to return a valid X509Certificate in the HttpResponseInfo structure passed in if the current URL scheme is https

Not returning this certificate causes a number of DCHECKS to fire in the network stack implementation and in the renderer process, which eventually causes the navigation to fail.

Fix is to return a dummy X509Certificate on the same lines as Gears.

This fixes bug http://b/issue?id=2039699

Bug=2039699

Review URL: http://codereview.chromium.org/164110
------------------------------------------------------------------------
r22783 | mirandac@chromium.org | 2009-08-07 22:52:39 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Ensure that popups windows are not themed.

BUG= http://crbug.com/18093
TEST= While running Chrome with a theme installed, and force a popup.  Note that the popup window is not themed.

Review URL: http://codereview.chromium.org/159871
------------------------------------------------------------------------
r22768 | senorblanco@chromium.org | 2009-08-07 22:20:37 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Mark a layout tests as crash/pass; disable two crashing UI tests.

BUG=http://crbug.com/18784,http://crbug.com/18786
TEST=less redness == more goodness
TBR=tim

------------------------------------------------------------------------
r22753 | thomasvl@chromium.org | 2009-08-07 21:26:36 +0200 (Fri, 07 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/app/app.gyp
   M /trunk/src/app/l10n_util.h
   A /trunk/src/app/l10n_util_mac.h
   A /trunk/src/app/l10n_util_mac.mm
   A /trunk/src/app/l10n_util_mac_unittest.mm (from /trunk/src/chrome/browser/cocoa/ui_localizer_unittest.mm:22729)
   M /trunk/src/chrome/browser/cocoa/ui_localizer.h
   M /trunk/src/chrome/browser/cocoa/ui_localizer.mm
   D /trunk/src/chrome/browser/cocoa/ui_localizer_unittest.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/chrome.gyp

Move some Mac l10n helpers out into app/l10n so they are closer to the generic ones.
Complete the apis points so the ones folks might need are all there already.
Switch the code using the old calls over to the new helpers.

TEST=no l10n stuff broke
BUG=none
Review URL: http://codereview.chromium.org/165132
------------------------------------------------------------------------
r22747 | tc@google.com | 2009-08-07 21:00:02 +0200 (Fri, 07 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

In app windows, fallback to the product icon if there's no site favicon.

TEST=Open the web inspector.  When it finishes loading, it should show
  the chromium icon instead of the last frame of the throbber.

Review URL: http://codereview.chromium.org/164159

------------------------------------------------------------------------
r22745 | mpcomplete@chromium.org | 2009-08-07 20:58:19 +0200 (Fri, 07 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/simple_api_call/manifest.json
   M /trunk/src/chrome/test/render_view_test.cc

Add module-level permissions to extensions.

This first pass is fairly simple. If a permission is not specified in the
manifest, the corresponding module will not be exposed to script. For example,
without specifying the "tabs" permission, chrome.tabs and chrome.windows will
not be available.

BUG=12140
TEST=no

Review URL: http://codereview.chromium.org/164039
------------------------------------------------------------------------
r22743 | estade@chromium.org | 2009-08-07 20:47:11 +0200 (Fri, 07 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

Fix some issues with bookmark bar folder menu.

Without this patch, you have to click repeatedly on a folder to get the context menu to pop up, because the first few clicks dismiss whatever submenus you may have open. This patch fixes that.

There is another problem present with and without this patch where a bookmark bar folder menu that has shown a context menu will not regain the application/X grabs. This makes it possible to use the rest of the browser while the menu is showing, and clicking away from the menu won't dismiss the menu. In the interests of keeping this patch easy to review I will look into that issue separately.

BUG=18275

Review URL: http://codereview.chromium.org/165138
------------------------------------------------------------------------
r22742 | munjal@chromium.org | 2009-08-07 20:38:31 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/sync/personalization.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   D /trunk/src/chrome/browser/views/options/user_data_page_view.cc
   D /trunk/src/chrome/browser/views/options/user_data_page_view.h
   M /trunk/src/chrome/chrome.gyp

Move the sync options group from "user Data" tab to "Personal Stuff" tab and remove the "User Data" tab.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/165105
------------------------------------------------------------------------
r22740 | avi@chromium.org | 2009-08-07 20:34:55 +0200 (Fri, 07 Aug 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.h
   A /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/clickhold_button_cell.h
   A /trunk/src/chrome/browser/cocoa/clickhold_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/delayedmenu_button.h
   A /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implement back/forward toolbar menus on Mac (bug 13203).

Note: The drop-down menu is actually a drag-down (activating on
click-hold or on drag), working much like Safari's (and other Apple
apps, such as Dictionary). This can be changed to a pop-down if that's
what's desired.

TODO: Show keyboard shortcut for "Show Full History".

Patch by viettrungluu.

BUG=http://crbug.com/13203
TEST=Navigate around, check out and use the menus; do so in multiple tabs and
windows.

Review URL: http://codereview.chromium.org/160496

------------------------------------------------------------------------
r22736 | tc@google.com | 2009-08-07 20:03:10 +0200 (Fri, 07 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix a bug where we don't maximize on titlebar double click in KWin.

GTK+ sends the following events on double click:

GDK_BUTTON_PRESS
GDK_BUTTON_RELEASE
GDK_BUTTON_PRESS
GDK_2BUTTON_PRESS
GDK_BUTTON_RELEASE

If we start a gtk_window_begin_move_drag on the second GDK_BUTTON_PRESS, the call to gtk_window_maximize fails.  To work around this, we keep track of the last click and if it's going to be a double click, we don't call gtk_window_begin_move_drag.

BUG=18401

Review URL: http://codereview.chromium.org/165102

------------------------------------------------------------------------
r22731 | jeremy@chromium.org | 2009-08-07 17:28:50 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm

Support cntrl-tab to switch tabs on OS X.

BUG=13299
TEST=Cntrl-Tab should switch to the next tab, cntrl-shift-tab should switch to the previous tab.

Review URL: http://codereview.chromium.org/164133
------------------------------------------------------------------------
r22721 | rohitrao@chromium.org | 2009-08-07 06:49:14 +0200 (Fri, 07 Aug 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBarContainer.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/view_resizer.h
   A /trunk/src/chrome/browser/cocoa/view_resizer_pong.h
   A /trunk/src/chrome/browser/cocoa/view_resizer_pong.mm
   M /trunk/src/chrome/chrome.gyp

Reverts the revert of 22517.

Rewrites the Mac view resizing logic to have the BrowserWindowController
directly resize and relayout its children views.  Now when a view needs
to be resized, it asks its resize delegate (typically its controller's
parent) to perform the resize.

BUG=http://crbug.com/17619

TEST=Make sure that views are laid out correctly, even when they change size.
Open and close the bookmark bar.  Trigger an infobar and then close it.  Trigger
the download shelf and then close it.  Trigger a download shelf with the infobar
open, or with the bookmark bar open.  Switch to and from fullscreen with various
bars open.  Resize the browser window with various bars open.  Start the browser
with and without the bookmark bar open.  Try all of the above in a popup window.

Review URL: http://codereview.chromium.org/165014
------------------------------------------------------------------------
r22713 | mattm@chromium.org | 2009-08-07 03:56:05 +0200 (Fri, 07 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc

Gtk Cookie Manager polish.

Make dialog wider, set first column width to fixed (but resizable), set initial sort order.

BUG=17919

Review URL: http://codereview.chromium.org/164125
------------------------------------------------------------------------
r22712 | jrg@chromium.org | 2009-08-07 03:51:21 +0200 (Fri, 07 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Fix crash on fullscreening of popup.

BUG=http://crbug.com/18551

TEST=Create a pop-up window.
Fullscreen it (Cmd-Shift-F).
Go back (Cmd-Shift-F again).
Repeat a few times across different launches of Chromium.

Review URL: http://codereview.chromium.org/164024
------------------------------------------------------------------------
r22711 | aa@chromium.org | 2009-08-07 03:29:47 +0200 (Fri, 07 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/common/notification_type.h

Fix a few bugs with the theme infobar:

* Don't animate the infobar closing and opening when switching
  between themes.

* Don't show multiple infobars when intalling themes in rapid
  succession.

BUG=18213

Review URL: http://codereview.chromium.org/165029
------------------------------------------------------------------------
r22710 | thestig@chromium.org | 2009-08-07 03:22:58 +0200 (Fri, 07 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

Porting POINT to gfx::Point.

Patch from thiago.farnia at gmail.com. Original review url:
http://codereview.chromium.org/155888

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164121
------------------------------------------------------------------------
r22708 | estade@chromium.org | 2009-08-07 03:04:53 +0200 (Fri, 07 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Restore right click on bookmark bar.

it stopped working after r22660

Review URL: http://codereview.chromium.org/165108
------------------------------------------------------------------------
r22704 | arv@google.com | 2009-08-07 02:41:20 +0200 (Fri, 07 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Add a menu item that allows the user to restore all blacklisted
thumbnails

BUG=15247

TEST=Blacklist (remove) a few thumbnails (hit the x on the thumbnail
toolbar). Then go to the options menu and "Restore all removed
thumbnails". The removed thumbnails should be back.

Review URL: http://codereview.chromium.org/165107
------------------------------------------------------------------------
r22703 | tc@google.com | 2009-08-07 02:36:42 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc

Set the dangerous download text to the bookmark bar text
color since we already set the shelf to the toolbar background
color.

Review URL: http://codereview.chromium.org/164116

------------------------------------------------------------------------
r22697 | mattm@chromium.org | 2009-08-07 02:07:33 +0200 (Fri, 07 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc

Changelist for mattm readability review.

Review URL: http://codereview.chromium.org/160037
------------------------------------------------------------------------
r22696 | estade@chromium.org | 2009-08-07 01:52:25 +0200 (Fri, 07 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

GTK: Change the way to calculate the position of the tab title text.

On my machine this doesn't actually change the position, but at least it gets rid of the magic -1.

BUG=18555

Review URL: http://codereview.chromium.org/165024
------------------------------------------------------------------------
r22695 | tc@google.com | 2009-08-07 01:52:02 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc

Add a temporary extension error message box on linux.

The NOTREACHED() crashed my debug build.

Review URL: http://codereview.chromium.org/164088

------------------------------------------------------------------------
r22692 | erg@google.com | 2009-08-07 01:34:03 +0200 (Fri, 07 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

Relanding r22644, "GTK: Rounded corner on status bubble."

The previous patch made ui_tests red because we don't always have a GdkWindow
when a widget's size-allocate signal is called. Move all responsibility into
the expose-event handler.

http://crbug.com/18309

Original Review URL: http://codereview.chromium.org/164010

Review URL: http://codereview.chromium.org/164104
------------------------------------------------------------------------
r22691 | arv@google.com | 2009-08-07 01:25:18 +0200 (Fri, 07 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

NNTP: Remove tips and downloads and introduce a recently closed bar instead.

Make the list mode only show one column and make the items look like links.

BUG=None

TEST= On the new tab page try opening and closing tabs and windows.
The closed tabs and windows should appear in the recently closed bar at
the bottom.

Review URL: http://codereview.chromium.org/165095
------------------------------------------------------------------------
r22685 | estade@chromium.org | 2009-08-07 00:59:25 +0200 (Fri, 07 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Hook up copy pasta hotkeys in gtk bookmark manager.

Also change the display hotkey for tab reload from f5 (windowsy) to ctrl+r (linuxy).

BUG=none
TEST=use the new hotkeys

Review URL: http://codereview.chromium.org/164097
------------------------------------------------------------------------
r22684 | estade@chromium.org | 2009-08-07 00:59:09 +0200 (Fri, 07 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

Don't pack an empty label into bookmarks with empty titles.

BUG=18348

Review URL: http://codereview.chromium.org/164101
------------------------------------------------------------------------
r22679 | derat@chromium.org | 2009-08-07 00:17:26 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Linux: Pass font settings through to interstitial renderers.

BUG=18483
TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties

Review URL: http://codereview.chromium.org/164094
------------------------------------------------------------------------
r22676 | estade@chromium.org | 2009-08-07 00:00:44 +0200 (Fri, 07 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h

GTK: Don't choke when there's no selection in the bookmark editor tree view.

1) disable "new folder" when no folder is selected
2) if a user clicks apply when no folder is selected, apply the title/url edits but leave it in its original location

Review URL: http://codereview.chromium.org/164016
------------------------------------------------------------------------
r22675 | estade@chromium.org | 2009-08-07 00:00:27 +0200 (Fri, 07 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Properly size accepted dangerous downloads.

BUG=18448

Review URL: http://codereview.chromium.org/165086
------------------------------------------------------------------------
r22672 | phajdan.jr@chromium.org | 2009-08-06 23:34:11 +0200 (Thu, 06 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h

Correctly handle extensions width in the GTK extension shelf.

Also make the method name used on Windows shorter and more obvious.

TEST=none
http://crbug.com/16759

Review URL: http://codereview.chromium.org/164092
------------------------------------------------------------------------
r22666 | paul@chromium.org | 2009-08-06 23:12:35 +0200 (Thu, 06 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_item_model.cc

Remove the size of a cancelled download in the download shelf.

Patch created by Thiago Farina, original CL:
http://codereview.chromium.org/160465

BUG=17180 (http://crbug.com/17180)
TEST=Download some file, then cancel it and notice the shelf UI
     does not any longer display the size of download.

Review URL: http://codereview.chromium.org/165073
------------------------------------------------------------------------
r22662 | asargent@chromium.org | 2009-08-06 23:05:21 +0200 (Thu, 06 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc

Switch extension update manifest parse errors to LOG(WARN).

Before this patch they are using ExtensionErrorReporter, but I
don't think it's actually useful for users to see them on the
chrome://extensions page. 

BUG=http://crbug.com/18565
TEST=You should no longer see messages like "Extension update
manifest parse error: Invalid codebase url"on the
chrome://extensions page.


Review URL: http://codereview.chromium.org/164008
------------------------------------------------------------------------
r22660 | tc@google.com | 2009-08-06 23:00:13 +0200 (Thu, 06 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

More theme fixes.

1) Fix the bookmark bar to draw the same as the toolbar (tile the background
image and have a transparent background).
2) Fix the tab backgrounds to be offset correctly rather than always drawing
as if we're the first tab.

Some small code cleanup in views/tabs/tab_renderer.h.

Review URL: http://codereview.chromium.org/165078

------------------------------------------------------------------------
r22659 | estade@chromium.org | 2009-08-06 22:52:39 +0200 (Thu, 06 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

GTK: handle Escape in omnibox when numlock/scrolllock/caps lock is on.

BUG=18643
TEST=turn on num lock. Escape in omnibox resets the address.

Review URL: http://codereview.chromium.org/165079
------------------------------------------------------------------------
r22656 | erg@google.com | 2009-08-06 22:37:12 +0200 (Thu, 06 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

Revert "GTK: Rounded corner on status bubble."

This reverts commit d98d01314c8b0905ac236d98dc39508ad8acfd05 (r22644).

This should make the linux ui tests green.

Review URL: http://codereview.chromium.org/164086
------------------------------------------------------------------------
r22655 | jam@chromium.org | 2009-08-06 22:29:29 +0200 (Thu, 06 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc

Get rid of warning on CHROME_OS builder.
Review URL: http://codereview.chromium.org/165080
------------------------------------------------------------------------
r22653 | jam@chromium.org | 2009-08-06 22:20:22 +0200 (Thu, 06 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   M /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/common/webmessageportchannel_impl.cc
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/worker/nativewebworker_impl.cc
   M /trunk/src/chrome/worker/nativewebworker_impl.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/webkit/api/public/WebWorker.h
   M /trunk/src/webkit/api/public/WebWorkerClient.h
   M /trunk/src/webkit/api/src/PlatformMessagePortChannel.cpp
   M /trunk/src/webkit/api/src/PlatformMessagePortChannel.h
   M /trunk/src/webkit/glue/webworker_impl.cc
   M /trunk/src/webkit/glue/webworker_impl.h
   M /trunk/src/webkit/glue/webworkerclient_impl.cc
   M /trunk/src/webkit/glue/webworkerclient_impl.h
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt
   M /trunk/src/webkit/tools/test_shell/test_worker/test_webworker.cc
   M /trunk/src/webkit/tools/test_shell/test_worker/test_webworker.h

Enable message ports for workers.

TEST=included ui test
Review URL: http://codereview.chromium.org/160576
------------------------------------------------------------------------
r22644 | erg@google.com | 2009-08-06 21:57:22 +0200 (Thu, 06 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

GTK: Rounded corner on status bubble.

http://crbug.com/18309

Review URL: http://codereview.chromium.org/164010
------------------------------------------------------------------------
r22640 | agl@chromium.org | 2009-08-06 21:04:50 +0200 (Thu, 06 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/common/bzip2_unittest.cc
   M /trunk/src/net/base/bzip2_filter.h
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/third_party/bzip2/bzip2.gyp

Linux: add GYP flag to build with system libbz2.

This follows the general style of r21663, which we agreed was the way
to do this.

Note that, currently, one cannot build with system libbz2 on a 64-bit
system since it's not part of the ia32-compat package.

http://codereview.chromium.org/165016

------------------------------------------------------------------------
r22636 | agl@chromium.org | 2009-08-06 20:44:06 +0200 (Thu, 06 Aug 2009) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: don't use GOT patching to intercept localtime(_r)

Our current GOT patching code is platform specific and fails to work
when V8 is built as a library.

Instead we define global functions for those functions which we wish
to override.  Since we will be first in the dynamic resolution order,
the dynamic linker will point callers to our versions of these
functions. However, we have the same binary for both the browser and
the renderers, which means that our overrides will apply in the
browser too.

The global |g_am_zygote_or_renderer| is true iff we are in a zygote or
renderer process. It's set in ZygoteMain and inherited by the
renderers when they fork. (This means that it'll be incorrect for
global constructor functions and before ZygoteMain is called -
beware).

Our replacement functions can check this global and either proxy the
call to the browser over the sandbox IPC
(http://code.google.com/p/chromium/wiki/LinuxSandboxIPC) or they can
use dlsym with RTLD_NEXT to resolve the symbol, ignoring any symbols
in the current module.

TEST=Run javascript:alert(new Date().getTimezoneOffset()). It shouldn't return 0 unless you're actually in GMT.
BUG=16800
http://codereview.chromium.org/165011

------------------------------------------------------------------------
r22631 | tc@google.com | 2009-08-06 20:36:03 +0200 (Thu, 06 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

More Linux theme fixes.

(1) If the theme provides a inactive tab background, don't offset the
image.  This matches the Windows code.

(2) Tile the toolbar background in both the X and Y direction (no longer
use a ninebox for this).

(3) Make the toolbar event box have an invisible window so toolbar
backgrounds with transparency will show the background behind it.

TEST=Install the Grass theme from the theme gallery.  It shouldn't look janky.

Review URL: http://codereview.chromium.org/164023

------------------------------------------------------------------------
r22628 | idana@chromium.org | 2009-08-06 20:31:12 +0200 (Thu, 06 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sync/resources/gaia_login.html
   M /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc

Changed the bookmark sync login dialog message and the dialog's width.

Review URL: http://codereview.chromium.org/165021
------------------------------------------------------------------------
r22613 | mirandac@chromium.org | 2009-08-06 18:37:56 +0200 (Thu, 06 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   A /trunk/src/chrome/browser/resources/new_incognito_tab_theme.css

Apply theme to incognito NTP.

BUG= http://crbug.com/18480
TEST= Open incognito window.  Note that NTP is themed.

Review URL: http://codereview.chromium.org/164002
------------------------------------------------------------------------
r22610 | mirandac@chromium.org | 2009-08-06 18:26:23 +0200 (Thu, 06 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Ensure that status bubble does not obscure download shelf.

BUG= http://crbug.com/18425
TEST= Cause download shelf to appear.  Hover over a link in the extreme lower left corner of the page.  Note that status bubble dodges to the right, instead of dropping to obscure the shelf.


Review URL: http://codereview.chromium.org/159878
------------------------------------------------------------------------
r22605 | hamaji@chromium.org | 2009-08-06 14:52:19 +0200 (Thu, 06 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/mock_proxy_resolver.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Reverting r22603, which reverts r22591. It seems that the revert doesn't help...

TEST=none
BUG=none
TBR=eroman

Review URL: http://codereview.chromium.org/164057
------------------------------------------------------------------------
r22603 | hamaji@chromium.org | 2009-08-06 14:11:05 +0200 (Thu, 06 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/mock_proxy_resolver.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Reverting r22591. It seems to be making purify fail.

r22590: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5026

r22591: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5030

TEST=none
BUG=none
TBR=eroman

Review URL: http://codereview.chromium.org/165048
------------------------------------------------------------------------
r22602 | hamaji@chromium.org | 2009-08-06 14:00:29 +0200 (Thu, 06 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Disable SSLUITest.TestGoodFrameNavigation as it seems to be flaky.

BUG=18626
TEST=none
TBR=jcampan

Review URL: http://codereview.chromium.org/165047
------------------------------------------------------------------------
r22595 | aa@chromium.org | 2009-08-06 09:46:37 +0200 (Thu, 06 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/jumplist.h
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/gzip_filter_unittest.cc
   M /trunk/src/net/disk_cache/block_files_unittest.cc
   M /trunk/src/net/url_request/url_request_view_cache_job.cc

Revert of r22559.

This caused an easily reproducible crash:

1. Start with a fresh profile
2. Navigate to google.com
3. Restart
4. Navigate to google.com
5. crash

The change from pass-by-value to pass-by-ref in
fav_icon_helper.* seems to be to blame, but I can't see it
right off.

TBR=phajdan.jr@chromium.org
------------------------------------------------------------------------
r22591 | eroman@chromium.org | 2009-08-06 07:42:11 +0200 (Thu, 06 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/net.gyp
   A /trunk/src/net/proxy/mock_proxy_resolver.h (from /trunk/src/net/proxy/proxy_service_unittest.cc:22447)
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Remove dependency on SingleThreadedProxyResolver from resolve_proxy_msg_helper_unittest.cc.

Extracts MockAsyncProxyResolver to "mock_proxy_resolver.h".

This should be the last unittest that needs cleanup post r21631.

BUG=http://crbug.com/11079

Review URL: http://codereview.chromium.org/160619
------------------------------------------------------------------------
r22578 | aa@chromium.org | 2009-08-06 04:18:23 +0200 (Thu, 06 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Don't show themes in extension config UI. This fixes various bugs
where the extension config UI doesn't work right with themes.

This isn't ideal because users go to chrome://extensions/
expecting themes to be listed. If they aren't there, users
might be confused. But I don't have an alternate solution.

Also, this change removes the error listing from the top of chrome://extensions/. These errors are just getting noisy, I don't think they provide much value.

BUG=13649,18456

Review URL: http://codereview.chromium.org/160631
------------------------------------------------------------------------
r22577 | ananta@chromium.org | 2009-08-06 04:16:16 +0200 (Thu, 06 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Don't run the SetProxyConfig task on the UI thread as it causes a bunch of DCHECKS
to fire in the ProxyConfigService objects.

Review URL: http://codereview.chromium.org/164013
------------------------------------------------------------------------
r22575 | estade@chromium.org | 2009-08-06 03:57:56 +0200 (Thu, 06 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/icon_loader.cc

Icon loader: respect delegate's response to NotifyDelegate call (false means the delegate doesn't assume ownership).

Review URL: http://codereview.chromium.org/164038
------------------------------------------------------------------------
r22567 | arv@google.com | 2009-08-06 02:20:32 +0200 (Thu, 06 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Fix window tooltip so that it is not shown out of place.

BUG=18529

TEST=The bug is hard to reproduce but it involved moving the mouse
fast over the link.

Review URL: http://codereview.chromium.org/164012
------------------------------------------------------------------------
r22566 | arv@google.com | 2009-08-06 02:20:22 +0200 (Thu, 06 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

NNTP: Minor tweak to make the Google chrome logo line up better.

BUG=None

TEST=None

Review URL: http://codereview.chromium.org/165010
------------------------------------------------------------------------
r22559 | phajdan.jr@chromium.org | 2009-08-06 02:03:08 +0200 (Thu, 06 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   M /trunk/src/chrome/browser/gtk/list_store_favicon_loader.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/jumplist.h
   M /trunk/src/chrome/browser/possible_url_model.cc
   M /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/gzip_filter_unittest.cc
   M /trunk/src/net/disk_cache/block_files_unittest.cc
   M /trunk/src/net/url_request/url_request_view_cache_job.cc

Bunch of Coverity fixes, rather minor severity.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/159862
------------------------------------------------------------------------
r22557 | paul@chromium.org | 2009-08-06 01:52:50 +0200 (Thu, 06 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Fix a bug where a download isn't canceled when the user requests it.

This particular bug only occurs when the user is prompted via save
file dialog and then chooses cancel. In this case, the file selection
code path for canceling was not the same as regular cancel case, so
the network requests continued.

BUG=18160
TEST=When prompted to save a download, choose cancel and notice that
     there is no further network traffic due to that download.

Review URL: http://codereview.chromium.org/160627
------------------------------------------------------------------------
r22556 | jeremy@chromium.org | 2009-08-06 01:50:35 +0200 (Thu, 06 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/safari_importer.h
   M /trunk/src/chrome/browser/importer/safari_importer.mm
   M /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/common/sqlite_utils.h
   A /trunk/src/chrome/test/data/safari_import/Safari/Bookmarks.plist
   A /trunk/src/chrome/test/data/safari_import/Safari/WebpageIcons.db

Safari Bookmark/Favicon import.

Review URL: http://codereview.chromium.org/159750
------------------------------------------------------------------------
r22546 | tim@chromium.org | 2009-08-06 00:20:54 +0200 (Thu, 06 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/user_data_page_view.cc

Fix include path for header file to fix sync build.
I'll hold off committing until Idan lets me know I didn't butcher anything else, too :)
Review URL: http://codereview.chromium.org/165004
------------------------------------------------------------------------
r22542 | estade@chromium.org | 2009-08-05 23:49:26 +0200 (Wed, 05 Aug 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

GTK: Fancy html5 draggy stuff.

Also, don't crash in release mode when the tab contents is deleted during a drag.

1) Source side: when the tab contents is going down, abort the current drag (if any). Initiate drags on a GtkInvisible (matching firefox, among other programs I assume). This lets us give up ownership of the drag widget and let the drag unwind.
2) Destination side: make a seemingly harmless GTK assert point to a crbug bug. This warrants further investigation.

BUG=16249
TEST=drag around ntp thumbnails

BUG=18557
In release mode, you should be able to do all the following without crashing or getting any asserts besides the two mentioned in 18557
TEST=drag something from gedit over a tab that closes
TEST=drag something from the render view over a tab that closes
TEST=drag something from the render view off of the browser from within a tab that closes
TEST=repeat all the above with a tab that is being swapped out according to the repro steps in bug 16073

Review URL: http://codereview.chromium.org/159889
------------------------------------------------------------------------
r22541 | rohitrao@chromium.org | 2009-08-05 23:29:23 +0200 (Wed, 05 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBarContainer.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/view_resizer.h
   D /trunk/src/chrome/browser/cocoa/view_resizer_pong.h
   D /trunk/src/chrome/browser/cocoa/view_resizer_pong.mm
   M /trunk/src/chrome/chrome.gyp

Reverting 22517.
Review URL: http://codereview.chromium.org/165001
------------------------------------------------------------------------
r22540 | dglazkov@chromium.org | 2009-08-05 23:28:51 +0200 (Wed, 05 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc

Ensure that we never call into WebCore::Page static methods when Page constructor hasn't been called.

This is a top crash for Mac right now. The crash occurs because the static table of all pages in the renderer is initialized 
in WebCore:: Page constructor, and if we attempt to access this table before the Page was created (i.e. before WebView::Create is called),
we get into a crashy situation. I am really not sure how to reproduce this, but I can defend against the situation.

BUG=17555
R=darin
TEST=unable to repro, speculative fix.

Review URL: http://codereview.chromium.org/159887
------------------------------------------------------------------------
r22539 | tc@google.com | 2009-08-05 23:22:29 +0200 (Wed, 05 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Draw the theme overlay.  I hadn't implemented this previously because
I didn't have an example theme that does this.

TEST=Install the Folders theme from the theme gallery and you should
  see a paperclip and some paper in the theme.

Review URL: http://codereview.chromium.org/165002

------------------------------------------------------------------------
r22537 | tc@google.com | 2009-08-05 23:09:45 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/app/theme/throbber_waiting_light.png
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Add the anti-clockwise waiting throbber to app mode/popup windows.

BUG=18181

Review URL: http://codereview.chromium.org/160653

------------------------------------------------------------------------
r22531 | japhet@chromium.org | 2009-08-05 22:50:08 +0200 (Wed, 05 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Implement TabContentsViewMac::SizeContents(), so that the TabContentsView
gets sized properly on creation.

BUG=619
BUG=15960
TEST=none

Review URL: http://codereview.chromium.org/162016
------------------------------------------------------------------------
r22525 | tc@google.com | 2009-08-05 22:33:58 +0200 (Wed, 05 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Use a font size of 9pt in the tab titles.  This is a bit
bigger than before.  This matches the font size used in Windows (the heights are the same), but on Linux, the text render a bit wider.

BUG=17866

Review URL: http://codereview.chromium.org/160663

------------------------------------------------------------------------
r22524 | evan@chromium.org | 2009-08-05 22:32:36 +0200 (Wed, 05 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc

extensions: clean up some code I saw while tracking down a bug

The bug was already fixed, but this change shouldn't hurt too.

Review URL: http://codereview.chromium.org/162020
------------------------------------------------------------------------
r22523 | evan@chromium.org | 2009-08-05 22:27:50 +0200 (Wed, 05 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

linux: always show bookmarks bar on NTP

BUG=16825

Review URL: http://codereview.chromium.org/159897
------------------------------------------------------------------------
r22522 | tc@google.com | 2009-08-05 22:26:41 +0200 (Wed, 05 Aug 2009) | 47 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   A /trunk/src/chrome/renderer/print_web_view_helper_linux.cc
   A /trunk/src/chrome/renderer/print_web_view_helper_mac.cc
   M /trunk/src/chrome/renderer/print_web_view_helper_win.cc
   M /trunk/src/skia/ext/vector_canvas.cc
   M /trunk/src/skia/ext/vector_canvas.h
   A /trunk/src/skia/ext/vector_canvas_linux.cc
   M /trunk/src/skia/ext/vector_canvas_win.cc
   A /trunk/src/skia/ext/vector_platform_device.h
   A /trunk/src/skia/ext/vector_platform_device_linux.cc
   A /trunk/src/skia/ext/vector_platform_device_linux.h
   M /trunk/src/skia/skia.gyp

Original change by Min-Yu Huang <minyu.huang@gmail.com> in
http://codereview.chromium.org/160347

This is the very preliminary implementation to support printing on Linux and it
has not been finished yet. For each page to be printed, we convert rendering
actions on canvas into cairo APIs and generate a PS/PDF file.

chrome/chrome.gyp:
  Include our newly added and renamed files.

chrome/browser/browser.h:
chrome/browser/browser.cc:
  Allow the user print the web page by hitting ctrl-p.

chrome/browser/gtk/standard_menus.cc:
  Show "Print" in the menu.

chrome/renderer/print_web_view_helper.cc:
chrome/renderer/print_web_view_helper.h:
chrome/renderer/print_web_view_helper_mac.cc
chrome/renderer/print_web_view_helper_win.cc
  Move the class PrepareFrameAndViewForPrint to the header file and move
platform dependent parts to their corresponding files.

chrome/renderer/print_web_view_helper_linux.cc:
  Hard-coded parameters for printing. Only print the first page now.

skia/ext/vector_canvas.cc:
skia/ext/vector_canvas.h:
skia/ext/vector_canvas_linux.cc:
skia/ext/vector_canvas_win.cc:
  Move platform dependent parts to their corresponding files.

skia/ext/vector_platform_device.h:
skia/ext/vector_platform_device_linux.cc:
skia/ext/vector_platform_device_linux.h
  We translate skia APIs into Cairo APIs here. A PDF file is also created and
saved to the disk at this moment for testing purpose (you have to run chrome
without the sandbox to save the file). There are still lots of bugs.

skia/skia.gyp:
  Include our newly added files when compiling skia package on Linux.

BUG=9847

Review URL: http://codereview.chromium.org/160673

------------------------------------------------------------------------
r22521 | tim@chromium.org | 2009-08-05 22:06:15 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/WATCHLISTS
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   M /trunk/src/chrome/browser/sync/glue/bookmark_model_worker_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/live_sync
   A /trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc
   A /trunk/src/chrome/test/live_sync/bookmark_model_verifier.h
   A /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.cc
   A /trunk/src/chrome/test/live_sync/live_bookmarks_sync_test.h
   A /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.cc
   A /trunk/src/chrome/test/live_sync/profile_sync_service_test_harness.h
   A /trunk/src/chrome/test/live_sync/single_client_live_bookmarks_sync_unittest.cc
   A /trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc

Add the sync files to chrome.gyp.  They still don't result in anything building because
the files are wrapped in #ifdef CHROME_PERSONALIZATION which is not defined anywhere at the moment.

Add live_sync to chrome\test and corresponding target to chrome.gyp

Review URL: http://codereview.chromium.org/159902
------------------------------------------------------------------------
r22517 | rohitrao@chromium.org | 2009-08-05 21:55:29 +0200 (Wed, 05 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBarContainer.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/view_resizer.h
   A /trunk/src/chrome/browser/cocoa/view_resizer_pong.h
   A /trunk/src/chrome/browser/cocoa/view_resizer_pong.mm
   M /trunk/src/chrome/chrome.gyp

Rewrites the Mac view resizing logic to have the BrowserWindowController
directly resize and relayout its children views.  Now when a view needs
to be resized, it asks its resize delegate (typically its controller's
parent) to perform the resize.

BUG=http://crbug.com/17619

TEST=Make sure that views are laid out correctly, even when they change size.
Open and close the bookmark bar.  Trigger an infobar and then close it.  Trigger
the download shelf and then close it.  Trigger a download shelf with the infobar
open, or with the bookmark bar open.  Switch to and from fullscreen with various
bars open.  Resize the browser window with various bars open.  Start the browser
with and without the bookmark bar open.  Try all of the above in a popup window.

Review URL: http://codereview.chromium.org/159776
------------------------------------------------------------------------
r22515 | estade@chromium.org | 2009-08-05 21:46:29 +0200 (Wed, 05 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc

Add some spacing to titlebar buttons.

Review URL: http://codereview.chromium.org/160593
------------------------------------------------------------------------
r22514 | sky@chromium.org | 2009-08-05 21:44:44 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc

Adds a unit test for coverage of bug 15786.

BUG=15786
TEST=this is just a test change.

Review URL: http://codereview.chromium.org/160651
------------------------------------------------------------------------
r22512 | evan@chromium.org | 2009-08-05 21:42:38 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

linux: rearrange widget layout in importer dialog

I'm not especially happy with how it looks now, though I think it's
better than before.

Review URL: http://codereview.chromium.org/160661
------------------------------------------------------------------------
r22511 | phajdan.jr@chromium.org | 2009-08-05 21:40:18 +0200 (Wed, 05 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Clean up SavePage UI test, remove dead code.

As most of the tests moved to the browser test, this is now unneeded.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/160666
------------------------------------------------------------------------
r22501 | rohitrao@chromium.org | 2009-08-05 20:38:10 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm

Removes notification observers at the end of each CustomHomePagesModel unittest.
This gets rid of some scary warnings and may also fix a flaky test.

BUG=http://crbug.com/17452
TEST=None
Review URL: http://codereview.chromium.org/160643
------------------------------------------------------------------------
r22499 | avi@chromium.org | 2009-08-05 20:14:08 +0200 (Wed, 05 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   D /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.h
   D /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   D /trunk/src/chrome/browser/cocoa/clickhold_button_cell.h
   D /trunk/src/chrome/browser/cocoa/clickhold_button_cell.mm
   D /trunk/src/chrome/browser/cocoa/delayedmenu_button.h
   D /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Reverting 22478.

TBR=jar
Review URL: http://codereview.chromium.org/160660
------------------------------------------------------------------------
r22492 | agl@chromium.org | 2009-08-05 19:35:08 +0200 (Wed, 05 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/third_party/ffmpeg/ffmpeg.gyp

Linux: preload ffmpeg in the zygote.

When using the sandbox, the renderer cannot load the ffmpeg shared
objects from disk. So we load them in the zygote before the sandbox is
started.

(Note that this doesn't get media working, but it's a start.)

BUG=18329

http://codereview.chromium.org/159841

(Note: relanding. Original landing in r22392, reverted in r22405 due
to check-deps failure.)

------------------------------------------------------------------------
r22490 | jrg@chromium.org | 2009-08-05 19:28:39 +0200 (Wed, 05 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

On bookmark edit, the OK button is now disabled if the entered URL is
invalid (e.g. is the empty string).  The Cancel button is never
disabled.

BUG=http://crbug.com/17006

TEST=Right click on a bookmark button to edit it.
Make sure OK is enabled.
Set URL to "" (the empty string).
Make sure OK is DISabled.
Set URL to "x".
Make sure OK is enabled.

Review URL: http://codereview.chromium.org/160628
------------------------------------------------------------------------
r22487 | glen@chromium.org | 2009-08-05 19:13:01 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Quick 'low-risk-for-the-next-release' fix to increase theme install/load perf (should be a 2-4x speedup). Bug should remain open until a better approach (background threads, perhaps) is used.

BUG=17696
TEST=none

Review URL: http://codereview.chromium.org/159903
------------------------------------------------------------------------
r22486 | robertshield@chromium.org | 2009-08-05 19:05:57 +0200 (Wed, 05 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Add the WS_CLIPCHILDREN style to the external tab container window to prevent massive visual flickering during resize.

Review URL: http://codereview.chromium.org/160646
------------------------------------------------------------------------
r22485 | evan@chromium.org | 2009-08-05 19:04:56 +0200 (Wed, 05 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc

Fix a DCHECK hit inside the bookmark matching code.

We do bookmark matching in two passes: first, a quick search for all
the words, then a second filtering pass that obeys query syntax.
We were hitting a DCHECK when the second pass would filter any matches
out.  For example, the query ["thi"] matches a bookmark [think], but
it shouldn't match because quotes mean literal match.

BUG=15786

Review URL: http://codereview.chromium.org/159905
------------------------------------------------------------------------
r22478 | avi@chromium.org | 2009-08-05 17:13:13 +0200 (Wed, 05 Aug 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.h
   A /trunk/src/chrome/browser/cocoa/back_forward_menu_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/clickhold_button_cell.h
   A /trunk/src/chrome/browser/cocoa/clickhold_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/delayedmenu_button.h
   A /trunk/src/chrome/browser/cocoa/delayedmenu_button.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implement back/forward toolbar menus on Mac (bug 13203).

Note: The drop-down menu is actually a drag-down (activating on
click-hold or on drag), working much like Safari's (and other Apple
apps, such as Dictionary). This can be changed to a pop-down if that's
what's desired.

[The previously included fix to bug 17990 has been split off to CL
159864.]

TODO: Show keyboard shortcut for "Show Full History".

Patch by viettrungluu.

BUG=http://crbug.com/13203
TEST=Navigate around, check out and use the menus; do so in multiple tabs and
windows.

Review URL: http://codereview.chromium.org/160496

------------------------------------------------------------------------
r22470 | jorlow@chromium.org | 2009-08-05 10:21:26 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Another try to make Valgrind errors go away without figuring out how to do a suppression.

TBR=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159909
------------------------------------------------------------------------
r22468 | jorlow@chromium.org | 2009-08-05 09:36:18 +0200 (Wed, 05 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc

Temporarily disable DOM Storage tests since they are exposing
memory leaks in valgrind.  DOM Storage is behind a flag, so
it's ok to hide the symptoms until the problem can be solved.

TBR=darin
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/159908
------------------------------------------------------------------------
r22466 | jorlow@chromium.org | 2009-08-05 08:02:07 +0200 (Wed, 05 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/layout_tests
   A /trunk/src/chrome/test/data/layout_tests/layout_test_controller.html (from /trunk/src/chrome/test/data/workers/layout_test_controller.html:22032)
   D /trunk/src/chrome/test/data/workers/layout_test_controller.html
   A /trunk/src/chrome/test/ui/ui_layout_test.cc (from /trunk/src/chrome/worker/worker_uitest.cc:22165)
   A /trunk/src/chrome/test/ui/ui_layout_test.h (from /trunk/src/chrome/worker/worker_uitest.cc:22032)
   M /trunk/src/chrome/worker/worker_uitest.cc

Run the DOM Storage layout tests in the UI test framework since the test shell doesn't hit very much of the new code.  I still plan to write unit tests and we're still goign to enable the layout tests in test shell, but this is still a good way for us to test the full stack ASAP.

Workers has used this technique for a while now.  This CL factors out the layout test running code from the workers ui test and moves arounds directories a bit so not everything is in the "workers" directory.

Doing this via a v8 extension is the right way to go long term, but I ran into a couple snags, so I think this is a good first step.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/159720
------------------------------------------------------------------------
r22462 | glen@chromium.org | 2009-08-05 05:32:20 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc

Use the theme ID as as the cache-buster, making subsequent NNTP loads much faster.

BUG=18427
TEST=Install a few themes, verify that the NNTP never gets out of sync with the installed theme.

Review URL: http://codereview.chromium.org/159900
------------------------------------------------------------------------
r22457 | glen@chromium.org | 2009-08-05 03:33:36 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/views/widget/default_theme_provider.h

Make the DOMUIThemeSource load and pass through a PNG, rather than relying on decode/encode.

BUG=18427
TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading.

Review URL: http://codereview.chromium.org/159891
------------------------------------------------------------------------
r22455 | mdm@chromium.org | 2009-08-05 03:29:12 +0200 (Wed, 05 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/common/logging_chrome.cc

Linux: forward --log-level from the browser to the zygote.
BUG=none
TEST=pass --log-level=0 on startup, the setting will now be used in the renderers

Review URL: http://codereview.chromium.org/159881
------------------------------------------------------------------------
r22454 | tim@chromium.org | 2009-08-05 03:18:27 +0200 (Wed, 05 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/WATCHLISTS
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.cc
   A /trunk/src/chrome/browser/dom_ui/new_tab_page_sync_handler.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/sync/auth_error_state.h
   A /trunk/src/chrome/browser/sync/engine
   A /trunk/src/chrome/browser/sync/engine/syncapi.h
   A /trunk/src/chrome/browser/sync/glue
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_worker_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   A /trunk/src/chrome/browser/sync/glue/http_bridge.h
   A /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/model_associator.h
   A /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   A /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/personalization.cc
   A /trunk/src/chrome/browser/sync/personalization.h
   A /trunk/src/chrome/browser/sync/personalization_strings.h
   A /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   A /trunk/src/chrome/browser/sync/resources/about_sync.html
   A /trunk/src/chrome/browser/sync/resources/gaia_login.html
   A /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   A /trunk/src/chrome/browser/sync/resources/new_tab_personalization.html
   A /trunk/src/chrome/browser/sync/resources/setup_flow.html
   A /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   A /trunk/src/chrome/browser/sync/sync_status_ui_helper.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   A /trunk/src/chrome/browser/views/options/user_data_page_view.cc
   A /trunk/src/chrome/browser/views/options/user_data_page_view.h
   A /trunk/src/chrome/browser/views/sync
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.cc
   A /trunk/src/chrome/browser/views/sync/sync_setup_flow.h
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.cc
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard.h
   A /trunk/src/chrome/browser/views/sync/sync_setup_wizard_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Add files to browser/sync and tweak includes.
Create browser/sync/glue and /engine.
Create sync watchlist and add a few folks.

No GYP change here so no build changes should occur.
chrome.gyp CL is coming shortly, as well as live_sync tests.


Review URL: http://codereview.chromium.org/160598
------------------------------------------------------------------------
r22452 | jorlow@chromium.org | 2009-08-05 03:15:54 +0200 (Wed, 05 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   M /trunk/src/webkit/api/src/WebKit.cpp
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc

This CL is doing a bunch of Misc work to make LocalStorage data persist.

First of all, this allows WebKit clients to specify whether or not the VFS should be used.  In the browser process, we never want it to be.

Next, this allows WebKit clients to specify the behavior of WebKit's FileSystem code.  By default, they should all be NOT_REACHED().  The browser process implements the two of these I need for LocalStorage, but it'll be really easy for the rest to be implemented as needed.

Next, this adds a function that storage routines can call to ensure that lazily initialized stuff that must be initialized on the main WebKit thread is initialized.  Right now, this is just used to initialize the UTF8 conversion tables, but I'm sure there'll be more overt time.

Lastly, this uses the profile directory stored by webkit_context_ to derive the path LocalStorage should use.

This CL also cleans up a few minor style issues as it goes.

TEST=none
BUG=4360

Review URL: http://codereview.chromium.org/159778
------------------------------------------------------------------------
r22448 | aa@chromium.org | 2009-08-05 02:32:04 +0200 (Wed, 05 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Undo my bonehead mistake of checking in a modification to the
hardcoded theme gallery URL.

Review URL: http://codereview.chromium.org/159888
------------------------------------------------------------------------
r22447 | mpcomplete@chromium.org | 2009-08-05 01:59:04 +0200 (Wed, 05 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc

Unpack extensions in-process in --single-process mode.

TEST=no
BUG=no

Review URL: http://codereview.chromium.org/159833
------------------------------------------------------------------------
r22444 | evan@chromium.org | 2009-08-05 01:52:22 +0200 (Wed, 05 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

linux: yet more polish for the new toolbar graphics

Review URL: http://codereview.chromium.org/159885
------------------------------------------------------------------------
r22439 | phajdan.jr@chromium.org | 2009-08-05 01:24:01 +0200 (Wed, 05 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_view_gtk.h

Make extensions in the extension shelf render their content to a visible GTK
widget.

TEST=none
http://crbug.com/16759

Review URL: http://codereview.chromium.org/160610
------------------------------------------------------------------------
r22437 | erg@google.com | 2009-08-05 01:14:41 +0200 (Wed, 05 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK Theme: Fix location bar display on popup windows.

Review URL: http://codereview.chromium.org/159879
------------------------------------------------------------------------
r22430 | ericroman@google.com | 2009-08-05 00:43:12 +0200 (Wed, 05 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/net.gyp
   A /trunk/src/net/proxy/init_proxy_resolver.cc
   A /trunk/src/net/proxy/init_proxy_resolver.h
   A /trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_mac.h
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.h
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.h
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/proxy/proxy_script_fetcher.h
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver.cc
   M /trunk/src/net/proxy/single_threaded_proxy_resolver.h
   M /trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc

Better match IE's proxy settings.

 * When BOTH autodetect and custom PAC script are given, try both.
 * Use successful PAC parsing as the heuristic for determining when a script   is valid (rather than first-request). 
 * Only apply the proxy bypass list when using non-PAC.

The high level explanation on how this works:

http://sites.google.com/a/chromium.org/dev/developers/design-documents/proxy-settings-fallback

BUG= http://crbug.com/18271, http://crbug.com/9985
TEST=unit tests.
Review URL: http://codereview.chromium.org/160510
------------------------------------------------------------------------
r22428 | arv@google.com | 2009-08-05 00:34:12 +0200 (Wed, 05 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

NNTP: Update the position of the option menu.

I forgot this one in issue 159817

BUG=17944

TEST=Open the option menu. It should be placed just below the button.

Review URL: http://codereview.chromium.org/160606
------------------------------------------------------------------------
r22425 | evan@chromium.org | 2009-08-05 00:18:02 +0200 (Wed, 05 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc

posix: remove unused ie7_logins database table

This will remain in existing users' profiles, but whatever.

BUG=17268

Review URL: http://codereview.chromium.org/159870
------------------------------------------------------------------------
r22423 | jcampan@chromium.org | 2009-08-05 00:02:38 +0200 (Wed, 05 Aug 2009) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/accelerator_table_linux.cc
   D /trunk/src/chrome/browser/accelerator_table_linux.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/views/accelerator_table_gtk.cc (from /trunk/src/chrome/browser/accelerator_table_linux.cc:22312)
   A /trunk/src/chrome/browser/views/accelerator_table_gtk.h (from /trunk/src/chrome/browser/accelerator_table_linux.h:22312)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp

The initial registration of the browser accelerators for toolkit_views was sharing the accelerator table withe the GTK implementation.
It was missing some accelerators that are not defined in the table but in standard_menus.cc.
Turns out it's probably easier for toolkit_views and Gtk not to share that accelerator map.
I reverted the Gtk browser view to use a non shared accelerator table, and moved the accelerator table file to be toolkit_views specific.

BUG=None
TEST=Run Chrome (toolkit_views). Make sure accelerators (such as Ctrl-T, Ctrl-N...) work
Review URL: http://codereview.chromium.org/160544
------------------------------------------------------------------------
r22422 | avi@chromium.org | 2009-08-04 23:59:43 +0200 (Tue, 04 Aug 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Activate scrollbars (etc.) upon selecting a tab.

(Conceivably, the SetActive() could be pushed into the RWHV's
DidBecomeSelected(). Conceivably, one could imagine selection without
activation, so I chose to put it closer to the UI side of the code in
the TabContents. Hmmm. Maybe we should also put in the RWHV::SetActive()
method on all platforms.)

Patch by viettrungluu.

BUG=http://crbug.com/18262
TEST=Make your browser window really small, create new tabs, switch between
them.

Review URL: http://codereview.chromium.org/160505

------------------------------------------------------------------------
r22421 | avi@chromium.org | 2009-08-04 23:57:34 +0200 (Tue, 04 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Keep scrollbars (etc.) active upon pulling down menu extra.

Patch by viettrungluu.

BUG=http://crbug.com/17990
TEST=Go to a window with scrollbar and pull down menu extra; also check what
happens when moving around between different apps and different Chromium
windows.

Review URL: http://codereview.chromium.org/159864

------------------------------------------------------------------------
r22420 | estade@chromium.org | 2009-08-04 23:52:40 +0200 (Tue, 04 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h

GTK: Make folder tree views expand columns properly, also refactor the code into one common location

BUG=18276

Review URL: http://codereview.chromium.org/160603
------------------------------------------------------------------------
r22419 | estade@chromium.org | 2009-08-04 23:52:29 +0200 (Tue, 04 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/base/clipboard.cc
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/base/scoped_clipboard_writer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/tools/gtk_clipboard_dump/gtk_clipboard_dump.cc

GTK: implement bookmark manager copy/paste.

- Refactor bookmark util clipboard code to be cross platform.
- Add a CBF_DATA format for writing arbitrary data to the clipboard.
- Change MenuGtk so that showing a menu only makes the menu items update asynchronously. This way we can show the menu immediately and we won't get in trouble if the delegate's IsCommandEnabled() runs a nested message loop.

I did not do any mac-side implementation of the new clipboard stuff. The implementation should be easy when they get around to writing the bookmark manager.

Review URL: http://codereview.chromium.org/159815
------------------------------------------------------------------------
r22415 | tc@google.com | 2009-08-04 23:49:41 +0200 (Tue, 04 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

Disable input events when a JS dialog is showing.

Prior to this patch, you could still send input events and they
would get queued in the renderer to be handled after the JS
dialog was dismissed.  This makes our behavior more like other
browsers.

This also works around a linux/mac bug where the hung renderer dialog would appear when an alert is showing.

BUG=12176

Review URL: http://codereview.chromium.org/160494

------------------------------------------------------------------------
r22413 | phajdan.jr@chromium.org | 2009-08-04 23:48:59 +0200 (Tue, 04 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   A /trunk/src/chrome/test/data/save_page/b.saved1.htm
   A /trunk/src/chrome/test/data/save_page/b.saved2.htm

Port more tests from save_page_uitest.cc to save_page_browsertest.cc.

Also add more detailed checks for saved page contents.

TEST=Covered by browser_tests.
http://crbug.com/3791

Review URL: http://codereview.chromium.org/159858
------------------------------------------------------------------------
r22410 | jam@chromium.org | 2009-08-04 23:27:24 +0200 (Tue, 04 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

Fix valgrind warning.

Review URL: http://codereview.chromium.org/159873
------------------------------------------------------------------------
r22406 | mhm@chromium.org | 2009-08-04 23:14:31 +0200 (Tue, 04 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Include Pause/Resume in the context menu for the item in the download shelf.

The pause and resume context item will only appear when the download is in progress. It will not show on the context menu if the download has been cancelled or completed.

It is a toggle state, either pause or resume, not both.

BUG=16929 (http://www.crbug.com/16929)
TEST=Download a large file, right click pause, then resume. As well, download a small file, wait till finishes, right click, you will see no pause/resume.

Review URL: http://codereview.chromium.org/159844
------------------------------------------------------------------------
r22405 | agl@chromium.org | 2009-08-04 23:14:19 +0200 (Tue, 04 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/third_party/ffmpeg/ffmpeg.gyp

Revert "Linux: preload ffmpeg in the zygote."

This reverts commit r22392.

------------------------------------------------------------------------
r22398 | avi@chromium.org | 2009-08-04 20:25:23 +0200 (Tue, 04 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Sort theme popup list correctly.

BUG=none
TEST=ensure that the list is sorted without regard to case

Review URL: http://codereview.chromium.org/159857
------------------------------------------------------------------------
r22397 | aa@chromium.org | 2009-08-04 20:22:33 +0200 (Tue, 04 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/extensions/docs/css/ApiRefStyles.css
   M /trunk/src/chrome/common/extensions/docs/static/index.html

Add some more content to the content scripts docs.

TBR=rafaelw@chormium.org
------------------------------------------------------------------------
r22396 | arv@google.com | 2009-08-04 20:16:28 +0200 (Tue, 04 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Change the numbe of recently closed tabs to a maximum of 10 instead of 6.

Bug=17879

TEST=Close a lot of tabs. You should see the 10 latest closed tabs in the
recent activities section.

Review URL: http://codereview.chromium.org/160588
------------------------------------------------------------------------
r22393 | agl@chromium.org | 2009-08-04 19:52:04 +0200 (Tue, 04 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/base/sys_info.h
   M /trunk/src/base/sys_info_posix.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/render_process.cc

Linux: don't try and read shmmax in the sandbox.

In the sandbox, reading shmmax from proc always fails. Thus, we move
the function into base and call it before starting the sandbox. The
value is then cached.

http://codereview.chromium.org/159843

------------------------------------------------------------------------
r22392 | agl@chromium.org | 2009-08-04 19:48:22 +0200 (Tue, 04 Aug 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/third_party/ffmpeg/ffmpeg.gyp

Linux: preload ffmpeg in the zygote.

When using the sandbox, the renderer cannot load the ffmpeg shared
objects from disk. So we load them in the zygote before the sandbox is
started.

(Note that this doesn't get media working, but it's a start.)

BUG=18329

http://codereview.chromium.org/159841

------------------------------------------------------------------------
r22391 | evan@chromium.org | 2009-08-04 19:43:10 +0200 (Tue, 04 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   M /trunk/src/app/resources/linux_close.png
   A /trunk/src/app/resources/linux_close_glen.png (from /trunk/src/app/resources/linux_close.png:22381)
   A /trunk/src/app/resources/linux_close_h.png
   A /trunk/src/app/resources/linux_close_mask.png
   A /trunk/src/app/resources/linux_close_p.png
   A /trunk/src/app/resources/linux_maximize.png
   A /trunk/src/app/resources/linux_maximize_h.png
   A /trunk/src/app/resources/linux_maximize_mask.png
   A /trunk/src/app/resources/linux_maximize_p.png
   A /trunk/src/app/resources/linux_minimize.png
   A /trunk/src/app/resources/linux_minimize_h.png
   A /trunk/src/app/resources/linux_minimize_mask.png
   A /trunk/src/app/resources/linux_minimize_p.png
   A /trunk/src/app/resources/linux_restore.png
   A /trunk/src/app/resources/linux_restore_h.png
   A /trunk/src/app/resources/linux_restore_p.png
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

linux: use linux-specific window control graphics from glen

BUG=15952,18385

Review URL: http://codereview.chromium.org/159859
------------------------------------------------------------------------
r22389 | darin@chromium.org | 2009-08-04 19:36:55 +0200 (Tue, 04 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   D /trunk/src/webkit/glue/webview_delegate.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/webkit.gyp

Move alternate 404 error page loading out of WebFrame and into RenderView.

This involved adding a new method on WebViewDelegate to allow the embedder to
intercept data being loaded for a document.

I also had to plumb a few more FrameLoaderClient notifications through
WebViewDelegate.  See DidReceiveResponse and DidFinishLoading.

R=tony
BUG=15648
TEST=covered by errorpage_uitest.cc

Review URL: http://codereview.chromium.org/160578
------------------------------------------------------------------------
r22382 | erikkay@chromium.org | 2009-08-04 18:44:43 +0200 (Tue, 04 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   A /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/toolstrip.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   A /trunk/src/chrome/test/data/extensions/samples/mappy
   A /trunk/src/chrome/test/data/extensions/samples/mappy/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_content_script.js
   A /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html

mole API - take 2

originally reviewed / committed as http://codereview.chromium.org/160276

TBR=mpcomplete,phadjan.jr

Review URL: http://codereview.chromium.org/159854
------------------------------------------------------------------------
r22379 | finnur@chromium.org | 2009-08-04 17:20:34 +0200 (Tue, 04 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h

Fixing potential memory leak in BookmarkCodec::DecodeNode.

Coverity finds a condition where this leaks. We are at the moment not using it in such a way that it leaks, but that might of course change. It looks to me like the API is not intended to be used in such a way anyway, so we can just check for it and return false.

BUG=15350
TEST=Decoding bookmarks should work as before.

Review URL: http://codereview.chromium.org/159075
------------------------------------------------------------------------
r22377 | avi@chromium.org | 2009-08-04 15:58:54 +0200 (Tue, 04 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm

Do proper HSL > HSB conversion.

BUG=http://crbug.com/15760
TEST=slight visual change

Review URL: http://codereview.chromium.org/159810
------------------------------------------------------------------------
r22375 | hbono@chromium.org | 2009-08-04 12:46:50 +0200 (Tue, 04 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/jumplist.cc
   M /trunk/src/chrome/browser/jumplist.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable JumpList by default on Windows 7.

This change enables our custom JumpList by default, i.e. enables our custom JumpList when Chromium is launched without a "--disable-custom-jumplist" option.

BUG=8037
TEST=Right-click the taskbar icon of Chromium on Windows 7.
Review URL: http://codereview.chromium.org/159398
------------------------------------------------------------------------
r22370 | pfeldman@chromium.org | 2009-08-04 09:12:29 +0200 (Tue, 04 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Fix devtools after WebKit @r46732 roll.
BUG=18378

Review URL: http://codereview.chromium.org/159850
------------------------------------------------------------------------
r22368 | aa@chromium.org | 2009-08-04 08:46:21 +0200 (Tue, 04 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   A /trunk/src/chrome/browser/views/extensions/extension_install_prompt.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/page_action.h

Implement first cut at the extension installation prompt on Windows.

Had to move set_path() earlier in the unpack process so that we would have real paths for the resources, so that we could load and display the icon in the ui.

This exposed a problem where page actions had absolute paths and other images in extensions had relative paths. Extension::GetBrowserImages() was expecting relative paths, and it just happened to work because in both cases Extension was initialized without a path.

Modified page actions to use relative paths to be consistent with other images.

Review URL: http://codereview.chromium.org/160516
------------------------------------------------------------------------
r22367 | aa@chromium.org | 2009-08-04 08:44:11 +0200 (Tue, 04 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memory leak introduced by r22043.

BUG=18070
TEST=none

Review URL: http://codereview.chromium.org/160509
------------------------------------------------------------------------
r22366 | aa@chromium.org | 2009-08-04 08:39:51 +0200 (Tue, 04 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable failing inspector sanity test.

TBR=pfeldman@chromium.org
------------------------------------------------------------------------
r22365 | suzhe@chromium.org | 2009-08-04 07:34:19 +0200 (Tue, 04 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   A /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/chrome.gyp

It's a copy of http://codereview.chromium.org/155772, with the fix for valgrind test failure.

This CL implements the second TODO item of issue 12343:
2) We should send back an ACK to the second process.  If the second process doesn't get an ACK in the given timeout, it should kill the first process and go ahead and start.

The approach of this CL is to append process id to the singleton's socket filename, such as "SingletonSocket-12345", and creates a symbol link "SingletonSocket" to the real socket file. In ProcessSingleton::NotifyOtherProcess() if it's successfully connected to "SingletonSocket" but no ACK received, then the original process can be killed by its process id retrieved from the symbol link.

BUG=12343 ProcessSingleton Linux cleanups
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z, then launch chrome again in another terminal. The second chrome shall be started in 5 seconds, and the first one shall be killed.

Review URL: http://codereview.chromium.org/160436
------------------------------------------------------------------------
r22356 | jam@chromium.org | 2009-08-04 04:00:56 +0200 (Tue, 04 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/ref_counted.h
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/worker_host/message_port_dispatcher.cc
   A /trunk/src/chrome/browser/worker_host/message_port_dispatcher.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/common/webmessageportchannel_impl.cc
   A /trunk/src/chrome/common/webmessageportchannel_impl.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/ipc/ipc_message_utils.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   A /trunk/src/webkit/api/public/WebMessagePortChannel.h
   A /trunk/src/webkit/api/public/WebMessagePortChannelClient.h
   A /trunk/src/webkit/api/src/PlatformMessagePortChannel.cpp
   A /trunk/src/webkit/api/src/PlatformMessagePortChannel.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc
   M /trunk/src/webkit/webkit.gyp

Cross-process Message Port implementation.

I'm sending this first, then I'll add support to workers in another changelist to avoid making this change larger.

TEST=running message port related layout tests in ui_tests
Review URL: http://codereview.chromium.org/159372
------------------------------------------------------------------------
r22355 | paul@chromium.org | 2009-08-04 03:57:52 +0200 (Tue, 04 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm
   M /trunk/src/chrome/chrome.gyp

Implement the download arrow animation for Mac.

TEST=Download something and notice the nice download arrow animation.
BUG=14661 (http://crbug.com/14661)

Review URL: http://codereview.chromium.org/159623
------------------------------------------------------------------------
r22346 | davemoore@chromium.org | 2009-08-04 01:32:27 +0200 (Tue, 04 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/panel_controller.cc

This unneeded include broke if someone subsequently included 
net/url_request/url_request_status.h

Review URL: http://codereview.chromium.org/159818
------------------------------------------------------------------------
r22342 | tc@google.com | 2009-08-04 01:22:10 +0200 (Tue, 04 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_file_util.cc

Put the null pointer check for theme images before we use the
pointer.

This was crashing for me with the theme I had installed.

Review URL: http://codereview.chromium.org/160550

------------------------------------------------------------------------
r22341 | paul@chromium.org | 2009-08-04 01:21:41 +0200 (Tue, 04 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Implement the quit dialog on Mac displayed when the user has in progress
Downloads.

BUG=15899
TEST=A dialog asking the user if they want to quit when there are downloads
     in progress will be displayed when the user tries to exit under that
     condition.
Review URL: http://codereview.chromium.org/159424
------------------------------------------------------------------------
r22339 | brettw@chromium.org | 2009-08-04 01:15:56 +0200 (Tue, 04 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc

Fix a warning from GCC about uninitialized variables.
Review URL: http://codereview.chromium.org/160545
------------------------------------------------------------------------
r22337 | arv@google.com | 2009-08-04 01:04:17 +0200 (Tue, 04 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

NNTP: Fix the issue where the lower corners had a fex dark pixels
leaking through.

BUG=18172

TEST=Look at the lower left and right corners of the thumbnails on the
new new tab page. There should bot be any dark pixels there.

Review URL: http://codereview.chromium.org/160549
------------------------------------------------------------------------
r22336 | evan@chromium.org | 2009-08-04 00:59:05 +0200 (Tue, 04 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

linux: fix regression where opening the page menu would cause a reload

I tried to be clever before, but I turned out needing brute force.

BUG=17647

Review URL: http://codereview.chromium.org/159822
------------------------------------------------------------------------
r22335 | evan@chromium.org | 2009-08-04 00:57:21 +0200 (Tue, 04 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/linux_close.png
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

linux: visual refresh of the close box

BUG=15952

Review URL: http://codereview.chromium.org/159824
------------------------------------------------------------------------
r22331 | tim@chromium.org | 2009-08-04 00:46:58 +0200 (Tue, 04 Aug 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/sync
   A /trunk/src/chrome/browser/sync/resources
   A /trunk/src/chrome/browser/sync/resources/close.png
   A /trunk/src/chrome/browser/sync/resources/gear.png
   A /trunk/src/chrome/browser/sync/resources/google_transparent.png
   A /trunk/src/chrome/browser/sync/resources/merge_and_sync.png

Add sync image resources, take 2.
This time do it from a fresh checkout that doesn't have all the other sync/ files
so svn commit doesn't pull them in as well!



Review URL: http://codereview.chromium.org/160546
------------------------------------------------------------------------
r22324 | phajdan.jr@chromium.org | 2009-08-03 23:57:57 +0200 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm

Disable CustomHomePagesModelTest.ModelChangedNotification because of crashiness.

TEST=none
http://crbug.com/17452

Review URL: http://codereview.chromium.org/159814
------------------------------------------------------------------------
r22323 | arv@google.com | 2009-08-03 23:57:45 +0200 (Mon, 03 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

NNTP: Reduce the amount of whitespace at the top. Make the toolbar
align better with the logo and update the logo to the right size.

BUG=17944

TEST=None


Review URL: http://codereview.chromium.org/159817
------------------------------------------------------------------------
r22322 | phajdan.jr@chromium.org | 2009-08-03 23:57:30 +0200 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc

Disable flaky parts of FindInPageControllerTest.

TEST=none
http://crbug.com/16447

Review URL: http://codereview.chromium.org/159805
------------------------------------------------------------------------
r22321 | bradnelson@google.com | 2009-08-03 23:55:29 +0200 (Mon, 03 Aug 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/sync

Rolling back 22317

BUG=None
TEST=None
TBR=tim

Review URL: http://codereview.chromium.org/160542
------------------------------------------------------------------------
r22320 | arv@google.com | 2009-08-03 23:49:50 +0200 (Mon, 03 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix issue where the favicon was not shown on the NNTP

BUG=18186

TEST=Go to the new tab page. You should see favicons next to the most visited thumbnail title.


Review URL: http://codereview.chromium.org/160528
------------------------------------------------------------------------
r22319 | sky@chromium.org | 2009-08-03 23:49:47 +0200 (Mon, 03 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fixes bug in calculating size of tabs on linux tab strip. Specifically
I wasn't calculating the available width correctly when there are
pinned tabs.

BUG=18134
TEST=see bug

Review URL: http://codereview.chromium.org/159812
------------------------------------------------------------------------
r22318 | mdm@chromium.org | 2009-08-03 23:47:00 +0200 (Mon, 03 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/gtk_tree.cc (from /trunk/src/chrome/common/gtk_tree_util.cc:22130)
   A /trunk/src/chrome/common/gtk_tree.h (from /trunk/src/chrome/common/gtk_tree_util.h:22130)
   D /trunk/src/chrome/common/gtk_tree_util.cc
   D /trunk/src/chrome/common/gtk_tree_util.h

Rename namespace gtk_tree_util to gtk_tree which is shorter.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160431
------------------------------------------------------------------------
r22317 | tim@chromium.org | 2009-08-03 23:46:10 +0200 (Mon, 03 Aug 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/sync
   A /trunk/src/chrome/browser/sync/auth_error_state.h
   A /trunk/src/chrome/browser/sync/engine
   A /trunk/src/chrome/browser/sync/engine/syncapi.h
   A /trunk/src/chrome/browser/sync/glue
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.cc
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_worker.h
   A /trunk/src/chrome/browser/sync/glue/bookmark_model_worker_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/http_bridge.cc
   A /trunk/src/chrome/browser/sync/glue/http_bridge.h
   A /trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc
   A /trunk/src/chrome/browser/sync/glue/model_associator.cc
   A /trunk/src/chrome/browser/sync/glue/model_associator.h
   A /trunk/src/chrome/browser/sync/glue/sync_backend_host.cc
   A /trunk/src/chrome/browser/sync/glue/sync_backend_host.h
   A /trunk/src/chrome/browser/sync/personalization.cc
   A /trunk/src/chrome/browser/sync/personalization.h
   A /trunk/src/chrome/browser/sync/personalization_strings.h
   A /trunk/src/chrome/browser/sync/profile_sync_service.cc
   A /trunk/src/chrome/browser/sync/profile_sync_service.h
   A /trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc
   A /trunk/src/chrome/browser/sync/resources
   A /trunk/src/chrome/browser/sync/resources/about_sync.html
   A /trunk/src/chrome/browser/sync/resources/close.png
   A /trunk/src/chrome/browser/sync/resources/gaia_login.html
   A /trunk/src/chrome/browser/sync/resources/gear.png
   A /trunk/src/chrome/browser/sync/resources/google_transparent.png
   A /trunk/src/chrome/browser/sync/resources/merge_and_sync.html
   A /trunk/src/chrome/browser/sync/resources/merge_and_sync.png
   A /trunk/src/chrome/browser/sync/resources/new_tab_personalization.html
   A /trunk/src/chrome/browser/sync/resources/setup_flow.html
   A /trunk/src/chrome/browser/sync/sync_status_ui_helper.cc
   A /trunk/src/chrome/browser/sync/sync_status_ui_helper.h

Add the image resources first so the CL that references them can pass on
the try servers.
Review URL: http://codereview.chromium.org/159808
------------------------------------------------------------------------
r22316 | mirandac@chromium.org | 2009-08-03 23:44:58 +0200 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Make sure that the "Recent activities" section of the NNTP does not include duplicates.

BUG= http://crbug.com/17896
TEST= Open a new tab.  Close the same page more than once.  Observe that this page only appears once in the "Recent activities" section of the NNTP.

Review URL: http://codereview.chromium.org/160399
------------------------------------------------------------------------
r22314 | kuchhal@chromium.org | 2009-08-03 23:42:37 +0200 (Mon, 03 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_exe.rc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/shell_util.cc

Use alternate icon for Chrome shortcuts if specified in master preferences.

This change depends on change 159539 that is currently under review and a new chrome2.ico that is yet to be added to the repository.

BUG=12701
TEST=Specify an alternate icon in --installerdata file and make sure that icon is used for shortcuts and it not changed later by updates.

Review URL: http://codereview.chromium.org/159618
------------------------------------------------------------------------
r22302 | mpcomplete@chromium.org | 2009-08-03 21:44:25 +0200 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Delay loading of ExtensionHosts until the background page is ready.

BUG=13912
TEST=no

Review URL: http://codereview.chromium.org/159756
------------------------------------------------------------------------
r22301 | darin@chromium.org | 2009-08-03 21:31:33 +0200 (Mon, 03 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   A /trunk/src/chrome/test/data/page404.html
   A /trunk/src/chrome/test/data/page404.html.mock-http-headers
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc

When loading an alternate 404 error page, always set 'replace' to true.

This is necessary because WebCore still loads an empty blank page when
we postpone the data for the original 404 error page.

R=tony
BUG=18109
TEST=errorpage_uitest.cc

Review URL: http://codereview.chromium.org/159801
------------------------------------------------------------------------
r22297 | jhawkins@chromium.org | 2009-08-03 21:14:39 +0200 (Mon, 03 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

gtk: Move the enter/leave-notify-event handling to TabRendererGtk and hook up the close button signals to this handler.

BUG=18196
TEST=Open two tabs.  Hover the mouse over the close button of the inactive tab.  The inactive tab should stay highlighted.
Review URL: http://codereview.chromium.org/160512
------------------------------------------------------------------------
r22296 | avi@chromium.org | 2009-08-03 21:13:17 +0200 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/Preferences.xib
   A /trunk/src/chrome/browser/cocoa/autoseparating_menu.h
   A /trunk/src/chrome/browser/cocoa/autoseparating_menu.m
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Get rid of non-functional elements from the themes prefs; add switcher.

BUG=http://crbug.com/18094
TEST=try the theme picker and enjoy!

Review URL: http://codereview.chromium.org/159727
------------------------------------------------------------------------
r22295 | erg@google.com | 2009-08-03 20:51:35 +0200 (Mon, 03 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Fix breakage.

Review URL: http://codereview.chromium.org/159802
------------------------------------------------------------------------
r22293 | erg@google.com | 2009-08-03 20:43:28 +0200 (Mon, 03 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK Themes: Theme labels in LocationBarViewGtk.

Labels in LocationBarViewGtk should be black even when a dark GTK theme is used
when we're not in GTK theme mode. Likewise, when we're using a GTK theme, we
should have the background and border color of the "Search X for:" box use
colors from the theme instead of having hard coded ones.

Review URL: http://codereview.chromium.org/159798
------------------------------------------------------------------------
r22289 | estade@chromium.org | 2009-08-03 20:25:03 +0200 (Mon, 03 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/accelerator_table_linux.cc

GTK: Allow keypad to be used for all tab selection accelerators.

(the only other accelerator that uses a number is ctrl+0, and that already accepts the keypad)

BUG=18229

Review URL: http://codereview.chromium.org/159799
------------------------------------------------------------------------
r22288 | estade@chromium.org | 2009-08-03 20:22:00 +0200 (Mon, 03 Aug 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK: Add stock icons to some dialog buttons.

To be clear, this only adds button images from stock images, and doesn't change the text of the buttons. I chose APPLY for dialogs that involve checkboxes. I chose OK for dialogs without checkboxes.

also
- switched the position of the OK/Cancel buttons on the import lock dialog.
- changed the first run dialog CANCEL button to QUIT, because CANCEL is really confusing in that situation (this is a problem on windows as well).

I couldn't find any other dialogs that are missing button images, but if you see some call em out.

BUG=none
TEST=look at all the pretty images.

Review URL: http://codereview.chromium.org/160493
------------------------------------------------------------------------
r22287 | mhm@chromium.org | 2009-08-03 20:13:58 +0200 (Mon, 03 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest.txt
   M /trunk/src/chrome/third_party/hunspell/README.chromium
   A /trunk/src/chrome/third_party/hunspell/google.patch (from /trunk/src/chrome/third_party/hunspell/google.patch:22242)
   M /trunk/src/chrome/third_party/hunspell/hunspell.gyp
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affentry.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affentry.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affixmgr.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affixmgr.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/atypes.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/baseaffix.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/csutil.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/csutil.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/dictmgr.cxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/filemgr.cxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/filemgr.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/htypes.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.h
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.hxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/hunzip.cxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/hunzip.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/license.hunspell
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/phonet.cxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/phonet.hxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/replist.cxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/replist.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/suggestmgr.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/suggestmgr.hxx
   D /trunk/src/chrome/third_party/hunspell/src/hunspell/w_char.hxx
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Reverting hunspell upgrade 22263,22257,22252,22243. Causing many valgrind warnings.

TBR: brettw, dank, jshin
Review URL: http://codereview.chromium.org/159797
------------------------------------------------------------------------
r22286 | asargent@chromium.org | 2009-08-03 19:54:34 +0200 (Mon, 03 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Make extensions auto-update schedule persist across browser restarts.

Instead of starting the timer all over again, we instead persist some 
information about when we had scheduled it and when it actually fired. We then 
try to balance keeping clients reasonably up to date with avoiding a 
thundering herd against servers.

BUG=http://crbug.com/12545
TEST=none

Review URL: http://codereview.chromium.org/160433
------------------------------------------------------------------------
r22284 | kuchhal@chromium.org | 2009-08-03 19:46:05 +0200 (Mon, 03 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/util_constants.h

Refactoring of master preferences parsing before adding a new preference.

Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer.

No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again.

BUG=12701
TEST=Make sure all the distribution preferences still work as before.

Review URL: http://codereview.chromium.org/159539
------------------------------------------------------------------------
r22281 | evan@chromium.org | 2009-08-03 19:29:49 +0200 (Mon, 03 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

linux: set FD_CLOEXEC on the singleton socket

The IME library may spawn a subprocess, which will then hold open
our singleton socket after we've shut down.

BUG=17952

Review URL: http://codereview.chromium.org/160523
------------------------------------------------------------------------
r22280 | arv@google.com | 2009-08-03 19:27:51 +0200 (Mon, 03 Aug 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP notification tweaks.

These came up in the usability studies.

Show the first run notification for 30 seconds.

Truncate the blacklisted title so that more of the message is shown.
In small mode both the title and the message have to be truncated. The
current UI design does not work well enough for small screens.

BUG=None

TEST=Start chrome with an empty/new profile. The first run notification
on the new tab page should be shown for 30s. Then navigate to a page
with a long title and go back to the new tab page and blacklist that
page. The title in the notifier should be truncated.

Review URL: http://codereview.chromium.org/160462
------------------------------------------------------------------------
r22277 | jcampan@chromium.org | 2009-08-03 19:18:08 +0200 (Mon, 03 Aug 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/accelerator_table_linux.cc
   A /trunk/src/chrome/browser/accelerator_table_linux.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc

Adding registration of accelerators for the browser in toolkit_views.

BUG=None
TEST=Open Chrome built with toolkit_views, test that accelerators work. 

See review:
http://codereview.chromium.org/160502
Review URL: http://codereview.chromium.org/159790
------------------------------------------------------------------------
r22276 | mhm@chromium.org | 2009-08-03 19:14:56 +0200 (Mon, 03 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc

Allow cancellable download items to be removable from download shelf.

BUG=18235 (http://crbug.com/18235)
TEST=Cancel a big download and remove it.
Review URL: http://codereview.chromium.org/159769
------------------------------------------------------------------------
r22274 | mhm@chromium.org | 2009-08-03 19:04:03 +0200 (Mon, 03 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc

Reverting 22273.
Review URL: http://codereview.chromium.org/160524
------------------------------------------------------------------------
r22273 | mhm@chromium.org | 2009-08-03 19:02:25 +0200 (Mon, 03 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc

Allow cancellable download items to be removable from download shelf.

BUG=18235 (http://crbug.com/18235)
TEST=Cancel a big download and remove it.
Review URL: http://codereview.chromium.org/159769
------------------------------------------------------------------------
r22271 | avi@chromium.org | 2009-08-03 18:44:41 +0200 (Mon, 03 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.h

Put forwarding function for GetTheme into the automation profile.

TBR

Review URL: http://codereview.chromium.org/159794
------------------------------------------------------------------------
r22270 | avi@chromium.org | 2009-08-03 18:34:34 +0200 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

Implement kCurrentThemeID so we can know what the last theme to be installed was.

BUG=none
TEST=not visible in UI

Review URL: http://codereview.chromium.org/159705
------------------------------------------------------------------------
r22267 | mirandac@chromium.org | 2009-08-03 17:34:07 +0200 (Mon, 03 Aug 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

LocationBarView::PageActionImageView::LoadImageTask::Run() may pass a NULL image pointer through to OnImageLoaded; make sure that the pointer is not dereferenced in these cases.

BUG= http://crbug.com/18140
TEST= none.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22213

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22254
Review URL: http://codereview.chromium.org/159711
------------------------------------------------------------------------
r22262 | hbono@chromium.org | 2009-08-03 09:38:06 +0200 (Mon, 03 Aug 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_mac.mm
   M /trunk/src/webkit/api/public/WebInputEvent.h
   M /trunk/src/webkit/api/public/mac/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/mac/WebInputEventFactory.mm

Implement the NSTextInput protocol.

This change implements the NSTextInput protocol to integrate dead-keys and IME support into Mac Chromium.
Same as Linux, to improve compatibility with Windows Chrome, this change emulates IPC messages sent on Windows when we input characters to fix Issue 11952 and Issue 11981.
Even though I notice we need more work for fixing edge cases (e.g. disabling IMEs on a password input) also on Mac, it is the good starting point. (Supporting edge-cases requires complicated code and it makes hard to review.)

BUG=11952 "IME support is not implemented"
BUG=11981 "Deadkeys do not work"
BUG=16393 "Mac: Not able to insert any letter using "Special Characters" pallet"
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form.
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form.
TEST=Open a web page which contains a <textarea> form, type a return key, and see a new line is inserted.
Review URL: http://codereview.chromium.org/150206
------------------------------------------------------------------------
r22258 | jhawkins@chromium.org | 2009-08-03 03:39:07 +0200 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc

Coverity: Check the return value of file_util::ReadFileToString.  It's possible that the file will be removed from the filesystem inbetween the enumeration and reading of the file.  In this instance, the script is removed from the script list.

CID=3888
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159680
------------------------------------------------------------------------
r22254 | mirandac@chromium.org | 2009-08-02 21:35:20 +0200 (Sun, 02 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

LocationBarView::PageActionImageView::LoadImageTask::Run() may pass a NULL image pointer through to OnImageLoaded; make sure that the pointer is not dereferenced in these cases.

BUG= http://crbug.com/18140
TEST= none.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22213
Review URL: http://codereview.chromium.org/159711
------------------------------------------------------------------------
r22253 | darin@chromium.org | 2009-08-02 21:23:45 +0200 (Sun, 02 Aug 2009) | 31 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/iframe_dns_error.html
   A /trunk/src/chrome/test/data/title3.html (from /trunk/src/chrome/test/data/title2.html:22154)
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.cc
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h

Move alternate error page loading out of WebFrame.

Make the RenderView be in charge of loading alternate error pages.

While working on this change, I noticed several related bugs:

1-  Loading an URL with an invalid host name from the new tab page results in
an error page.  If you hit back and then forward, you will be left with an
empty location bar.  In a debug build this trips an assertion in
ClassifyNavigation because the given page_id is -1.  This problem is caused by
not duplicating the NavigationState of the failed load when creating a load for
the error page.  Hence, the pending_page_id of the forward navigation is lost.

2-  Loading an URL with an invalid host name as a subframe results in an extra
navigation in session history.  One navigation for the main frame and one
navigation for the error page load.  This is another symptom of the problem
described in #1.  However, the solution is different.  Here, we need to know
that the subframe load is an AUTO_SUBFRAME load so that we load the error page
using 'replace' semantics (so that WebCore does not generate a new session
history entry).

Finally, I decided to restrict alternative DNS error pages to only work for the
main frame to match what we do for alternative 404 error pages.  It doesn't seem
worth it to show link doctor results for subframes since their primary purpose
is to assist people who mis-type an URL.

R=tony,brettw
BUG=15648
TEST=covered by errorpage_uitest.cc

Review URL: http://codereview.chromium.org/159575
------------------------------------------------------------------------
r22247 | chrome-bot@google.com | 2009-08-02 02:14:02 +0200 (Sun, 02 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   D /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   D /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   D /trunk/src/chrome/common/extensions/docs/toolstrip.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   D /trunk/src/chrome/test/data/extensions/samples/mappy

Rolling back change 22245.
Too much red :-(

BUG=None
TEST=None
TBR=erikkay

Review URL: http://codereview.chromium.org/159763
------------------------------------------------------------------------
r22245 | erikkay@chromium.org | 2009-08-01 23:14:05 +0200 (Sat, 01 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_toolstrip_api.cc
   A /trunk/src/chrome/browser/extensions/extension_toolstrip_api.h
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   A /trunk/src/chrome/common/extensions/docs/toolstrip.html
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   A /trunk/src/chrome/test/data/extensions/samples/mappy
   A /trunk/src/chrome/test/data/extensions/samples/mappy/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_content_script.js
   A /trunk/src/chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html

mole expand/collapse API, callable from a toolstrip for manual operation

Review URL: http://codereview.chromium.org/160276
------------------------------------------------------------------------
r22244 | aa@chromium.org | 2009-08-01 19:58:35 +0200 (Sat, 01 Aug 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   A /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   A /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/chrome.gyp

Try again to land: http://codereview.chromium.org/160483

Ever closer. Extract a client interface out of CrxInstaller
and use it to implement ExtensionInstallUI.

There is (still) no dialog here. But the next CL will, um,
definitely have it.

Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is
already previewed.

TBR=mpcomplete@chromium.org
BUG=17932

Review URL: http://codereview.chromium.org/160501
------------------------------------------------------------------------
r22243 | mhm@chromium.org | 2009-08-01 04:31:34 +0200 (Sat, 01 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/third_party/hunspell/README.chromium
   D /trunk/src/chrome/third_party/hunspell/google.patch
   M /trunk/src/chrome/third_party/hunspell/hunspell.gyp
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affentry.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affentry.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affixmgr.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/affixmgr.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/atypes.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/baseaffix.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/csutil.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/csutil.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/dictmgr.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/filemgr.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/filemgr.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/htypes.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.h
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hunzip.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hunzip.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/license.hunspell
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/phonet.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/phonet.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/replist.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/replist.hxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/suggestmgr.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/suggestmgr.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/w_char.hxx

Update Hunspell to the latest stable version to use the latest bdict format.

Updated Hunspell to version 1.2.8 which properly deals with UTF8 and fixes many bugs. This CL will use the BDict format and remove the usage of FileMgr. Removed the unwanted "key" parameter constructors from hunspell since we are managing them through bdict. Removed all line numbers from the errors  since we don't support that.

BUG= 14756 (http://crbug.com/14756)
TEST= Compiled Hunspell, Compiled Chromium, Ran Chromium, Fixed some of my spelling mistakes. Ran unit tests for SpellCheckTest.*
Review URL: http://codereview.chromium.org/155841
------------------------------------------------------------------------
r22242 | erg@chromium.org | 2009-08-01 04:23:33 +0200 (Sat, 01 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK Themes: Fix painting issues where GTK theme engine was painting over buttons.

So it looks like some themeing engines in distros more recent than Hardy paint
random boxes of the default background if you don't pass an explicit clip area
to gtk_paint_shadow().

http://crbug.com/18129

Review URL: http://codereview.chromium.org/159754
------------------------------------------------------------------------
r22241 | estade@chromium.org | 2009-08-01 03:51:46 +0200 (Sat, 01 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

retry r2226, with a fix for a case where we could double free.

Review URL: http://codereview.chromium.org/160495
------------------------------------------------------------------------
r22240 | derat@chromium.org | 2009-08-01 03:35:45 +0200 (Sat, 01 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Linux: Fix Valgrind error in VisitedLinkEventsTest.Coalescense.

I introduced the error in r22193; it shows up when there's no X
server to connect to.  I get a "GLib-GObject-CRITICAL **:
g_object_get: assertion `G_IS_OBJECT (object)' failed" message with
this change, but I'm not sure if it's from my code or if it was
already there, and the tests still pass.

TEST=ran VisitedLinkEventsTest.Coalescense under Valgrind with DISPLAY=:6

Review URL: http://codereview.chromium.org/159753
------------------------------------------------------------------------
r22236 | nsylvain@chromium.org | 2009-08-01 02:43:01 +0200 (Sat, 01 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Fix compile error.
Review URL: http://codereview.chromium.org/159755
------------------------------------------------------------------------
r22235 | estade@chromium.org | 2009-08-01 02:41:52 +0200 (Sat, 01 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

revert 22226 as it caused some ui test crashes

TBR=nsylvain

Review URL: http://codereview.chromium.org/160491
------------------------------------------------------------------------
r22233 | ben@chromium.org | 2009-08-01 02:17:37 +0200 (Sat, 01 Aug 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Fix unrelated bustage... ALLOW_THIS...
------------------------------------------------------------------------
r22231 | aa@chromium.org | 2009-08-01 02:12:02 +0200 (Sat, 01 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   D /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   D /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/chrome.gyp

Rollback 22228

TBR=mpcomplete@chromium.org
------------------------------------------------------------------------
r22230 | ben@chromium.org | 2009-08-01 02:07:13 +0200 (Sat, 01 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h

Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on shutdown due to a check in OwnedWidgetGtk for unbalanced refcnt.

The NativeViewHostGtk now owns the GtkWidget attached to it for the lifetime of its attachment. This removes my crazy ownership games from before and makes it a lot simpler.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159751
------------------------------------------------------------------------
r22229 | ben@chromium.org | 2009-08-01 02:07:00 +0200 (Sat, 01 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/views/screen.h
   M /trunk/src/views/screen_gtk.cc
   M /trunk/src/views/screen_win.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_gtk.cc

Status bubble limping in TOOLKIT_VIEWS.

Add CreateTransparentFloatingWidget method to Widget and add Init/SetContentsView methods.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160474
------------------------------------------------------------------------
r22228 | aa@chromium.org | 2009-08-01 01:59:53 +0200 (Sat, 01 Aug 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.cc
   M /trunk/src/chrome/browser/extensions/crx_installer.h
   A /trunk/src/chrome/browser/extensions/extension_install_ui.cc
   A /trunk/src/chrome/browser/extensions/extension_install_ui.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/chrome.gyp

Ever closer. Extract a client interface out of CrxInstaller and
use it to implement ExtensionInstallUI.

There is (still) no dialog here. But the next CL will, um,
definitely have it.

Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed.

BUG=17932

Review URL: http://codereview.chromium.org/160483
------------------------------------------------------------------------
r22227 | estade@chromium.org | 2009-08-01 01:53:01 +0200 (Sat, 01 Aug 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

Typo fix

------------------------------------------------------------------------
r22226 | estade@chromium.org | 2009-08-01 01:42:39 +0200 (Sat, 01 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

GTK: Theme our link button.

BUG=17772

Review URL: http://codereview.chromium.org/159748
------------------------------------------------------------------------
r22222 | pkasting@chromium.org | 2009-08-01 01:38:55 +0200 (Sat, 01 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Fix some character literals to use the right escape string.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159714
------------------------------------------------------------------------
r22221 | estade@chromium.org | 2009-08-01 01:37:57 +0200 (Sat, 01 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

Since bookmark copy/paste is not impl on non-Windows platforms, don't remove nodes when cutting.

BUG=18152
TEST=none

TBR=erg

Review URL: http://codereview.chromium.org/160488
------------------------------------------------------------------------
r22218 | tc@google.com | 2009-08-01 01:33:21 +0200 (Sat, 01 Aug 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fix a bug where we tried to get the position of the tabstrip
but the tabstrip wasn't in our widget hierarchy for app mode
windows.  Now we always put the tabstrip in the hierarchy, even
if we don't show it.

BUG=18202

Review URL: http://codereview.chromium.org/159745

------------------------------------------------------------------------
r22216 | stuartmorgan@google.com | 2009-08-01 01:17:16 +0200 (Sat, 01 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Fix or/|| mistake in ifdef

TBR=mark
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160487
------------------------------------------------------------------------
r22214 | willchan@chromium.org | 2009-08-01 01:01:20 +0200 (Sat, 01 Aug 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc

CHECK that IOBuffer::data_ in AsyncResourceHandler is not NULL before caching it.
BUG=http://crbug.com/16371

Review URL: http://codereview.chromium.org/159730
------------------------------------------------------------------------
r22213 | mirandac@chromium.org | 2009-08-01 00:58:40 +0200 (Sat, 01 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

LocationBarView::PageActionImageView::LoadImageTask::Run() may pass a NULL image pointer through to OnImageLoaded; make sure that the pointer is not dereferenced in these cases.

BUG= http://crbug.com/18140
TEST= none.

Review URL: http://codereview.chromium.org/159711
------------------------------------------------------------------------
r22212 | phajdan.jr@chromium.org | 2009-08-01 00:54:35 +0200 (Sat, 01 Aug 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   A /trunk/src/chrome/browser/download/save_page_browsertest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Convert parts of SavePage UI tests to more reliable browser tests.

Use a real notification for download completion - that's the main unflakying point.

TEST=none
http://crbug.com/3791

Review URL: http://codereview.chromium.org/160480
------------------------------------------------------------------------
r22210 | jcampan@chromium.org | 2009-08-01 00:53:37 +0200 (Sat, 01 Aug 2009) | 7 lines
Changed paths:
   M /trunk/src/base/keyboard_codes.h
   A /trunk/src/base/keyboard_codes_linux.h
   A /trunk/src/base/keyboard_codes_mac.h
   D /trunk/src/base/keyboard_codes_posix.h
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_pump_glib.cc
   M /trunk/src/base/message_pump_glib.h
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   A /trunk/src/views/focus/accelerator_handler.h (from /trunk/src/views/widget/accelerator_handler.h:21181)
   A /trunk/src/views/focus/accelerator_handler_gtk.cc
   A /trunk/src/views/focus/accelerator_handler_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/views.gyp
   D /trunk/src/views/widget/accelerator_handler.cc
   D /trunk/src/views/widget/accelerator_handler.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/dialog_client_view.cc

This CL adds accelerators to the Linux toolkit views.
The MessageLoop had to be modified to support Dispatchers on Linux.

BUG=None
TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests.

Review URL: http://codereview.chromium.org/159046
------------------------------------------------------------------------
r22209 | stuartmorgan@google.com | 2009-08-01 00:53:31 +0200 (Sat, 01 Aug 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Switch on plugins by default for the Mac

BUG=10809
TEST=Visit a sit with Flash content. Playback should work, interacting with the plugin is still buggy.

Review URL: http://codereview.chromium.org/159729
------------------------------------------------------------------------
r22206 | kuchhal@chromium.org | 2009-08-01 00:16:26 +0200 (Sat, 01 Aug 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/util_constants.h

Revert changes from r22198 to r22204 and r22194. None of these changes were
supposed to be commited. Seems like git took all the temporary commits from the
base branch and uploaded them to svn.

Review URL: http://codereview.chromium.org/159736
------------------------------------------------------------------------
r22205 | derat@chromium.org | 2009-08-01 00:13:08 +0200 (Sat, 01 Aug 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Fix cast breakage from 22193 (hopefully).

Review URL: http://codereview.chromium.org/159737
------------------------------------------------------------------------
r22200 | kuchhal@chromium.org | 2009-07-31 23:58:41 +0200 (Fri, 31 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h

cleanup
------------------------------------------------------------------------
r22198 | kuchhal@chromium.org | 2009-07-31 23:58:12 +0200 (Fri, 31 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/install.h
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/util_constants.h

Refactoring of master preferences parsing before adding a new preference.
------------------------------------------------------------------------
r22193 | derat@chromium.org | 2009-07-31 23:52:44 +0200 (Fri, 31 Jul 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Linux: Autodetect whether the custom frame should be used.

Listing a bunch of strings from WMs' source sucks,
but I can't think of any way to detect tiling WMs that
don't support the EWMH (see the bug and the comment in
this CL), so this seems safer.

Tested with the following:
- wiped out related prefs and started chrome under ion3;
  custom frame not used
- quit and started under metacity; custom frame *was* used
- toggled custom frame pref off and restarted under
  metacity again; custom frame not used
- toggled it back on and restarted under ion3; custom frame
  was used

BUG=15861
TEST=see above

Review URL: http://codereview.chromium.org/160374
------------------------------------------------------------------------
r22187 | thakis@chromium.org | 2009-07-31 22:53:47 +0200 (Fri, 31 Jul 2009) | 34 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/web_drag_source.h
   A /trunk/src/chrome/browser/cocoa/web_drag_source.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

Enable dragging of images to desktop (Finder), Preview, etc. (on Mac).

This hooks up drag-and-drop of file promises, lazy writing to the drag
pasteboard, drag-sourcing of TIFF images (via Cocoa) and file contents.

Patch Set 5 improvements: Adds asynchronous writing of promised files.

Patch Set 4 improvements: Big refactoring -- drag source stuff is now
handled by the WebDragSource (Cocoa) object, with messages proxied
through the TabContentsViewCocoa object. The WebDragSource object
carries a weak reference to the TCVC, owns the WebDropData, and keeps
track of the drag pasteboard types/promises.

Patch Set 3 improvements over Patch Set 2: It shouldn't crash anymore. Made
drop_data_ reference counted, in anticipation of asynchronous file
writing.

TODO #1: Testing. Still need a unit test, maybe. Should make sure that
dragging by file contents actually works.

TODO #2 (in some other patch): Refactor some of the WebDropData
extraction code out, e.g., file name extraction should be made common
with other platforms.

TODO #3 (in some other patch): We really should make WebDropData cheaper
to copy around and retain. I'm not convinced it's a good idea to push
out the entire thing over IPC, especially since the data pushed could be
very big and may not even be used.

BUG=15640
TEST=drag images to various applications

Patch by viettrungluu@gmail.com

------------------------------------------------------------------------
r22182 | thakis@chromium.org | 2009-07-31 22:27:24 +0200 (Fri, 31 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

Make spacing between "theme" buttons same as spacing between "browsing data"
buttons.

BUG=none
TEST=Open Options->Personal Stuff and note that it looks better than before.

Review URL: http://codereview.chromium.org/160467
------------------------------------------------------------------------
r22181 | erg@google.com | 2009-07-31 22:27:23 +0200 (Fri, 31 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Relanding r22155 (GTK Themes: Use theme colors in the text view in the location bar.)

Fixed build issues with Ben's help.

Original Review URL: http://codereview.chromium.org/159671

Review URL: http://codereview.chromium.org/160466
------------------------------------------------------------------------
r22180 | sky@chromium.org | 2009-07-31 22:20:35 +0200 (Fri, 31 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/menu/chrome_menu.h

Fixes possible crash in bookmark menus. Specifically if you had a menu
showing and brought up the context menu and clicked a separator we
would do the wrong thing. We would try to show the first menu again,
without cancelling out of the inner loop, which would most likely
result in a crash. The right thing to do in this case is not close the
context menu (this behavior can be seen in windows as well).

BUG=17862
TEST=see bug, but also covered by ui test now.

Review URL: http://codereview.chromium.org/160458
------------------------------------------------------------------------
r22179 | jeremy@chromium.org | 2009-07-31 22:18:49 +0200 (Fri, 31 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/.gitignore
   M /trunk/src/base/mac_util.h
   M /trunk/src/base/mac_util.mm
   M /trunk/src/base/mac_util_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/importer/importer.cc
   A /trunk/src/chrome/browser/importer/safari_importer.h
   A /trunk/src/chrome/browser/importer/safari_importer.mm
   A /trunk/src/chrome/browser/importer/safari_importer_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/safari_import
   A /trunk/src/chrome/test/data/safari_import/Preferences
   A /trunk/src/chrome/test/data/safari_import/Preferences/com.apple.Safari.plist
   A /trunk/src/chrome/test/data/safari_import/README
   A /trunk/src/chrome/test/data/safari_import/Safari
   A /trunk/src/chrome/test/data/safari_import/Safari/History.plist

First cut at Safari Import - Home Page & History Only.

Review URL: http://codereview.chromium.org/159668
------------------------------------------------------------------------
r22177 | jhawkins@chromium.org | 2009-07-31 22:02:19 +0200 (Fri, 31 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Revert a part of r22173 that caused a compile failure on Win dbg.

TBR=rafaelw
Review URL: http://codereview.chromium.org/160470
------------------------------------------------------------------------
r22175 | estade@chromium.org | 2009-07-31 21:57:23 +0200 (Fri, 31 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

GTK: Ctrl+shift+q for quit

yay

BUG=17819

Review URL: http://codereview.chromium.org/159722
------------------------------------------------------------------------
r22174 | estade@chromium.org | 2009-07-31 21:56:45 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Add "Get Themes" button to gtk options dialog.

BUG=17641

Review URL: http://codereview.chromium.org/160416
------------------------------------------------------------------------
r22173 | jhawkins@chromium.org | 2009-07-31 21:51:46 +0200 (Fri, 31 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Coverity: Check the return value of DictionaryValue::GetString.

CID=4199,4685
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159677
------------------------------------------------------------------------
r22172 | jhawkins@chromium.org | 2009-07-31 21:50:37 +0200 (Fri, 31 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Coverity: Check the return value of ExecuteJavaScriptAndExtractString.

CID=5133
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159676
------------------------------------------------------------------------
r22170 | estade@chromium.org | 2009-07-31 21:46:53 +0200 (Fri, 31 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc

Implement FindBarGtk::StopAnimation().

Not convinced it's 100% necessary but it can't hurt.

BUG=11979

Review URL: http://codereview.chromium.org/159715
------------------------------------------------------------------------
r22169 | estade@chromium.org | 2009-07-31 21:46:31 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

GTK: Show shortcuts in title bar context menu and tab context menu.

BUG=17936

Review URL: http://codereview.chromium.org/159721
------------------------------------------------------------------------
r22168 | ben@chromium.org | 2009-07-31 21:40:33 +0200 (Fri, 31 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   D /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   D /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   A /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc
   A /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Make TOOLKIT_VIEWS port use views-based Autocomplete popup.

The popups now interact with the edit via AutocompleteEditView rather than the platform-specific types.

Note this also removes the old omnibox popup code. It hasn't been active for some time.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160378
------------------------------------------------------------------------
r22167 | sky@chromium.org | 2009-07-31 21:37:44 +0200 (Fri, 31 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc

Fixes bug in creating search terms where we weren't unescaping
correctly.

BUG=17697
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/159707
------------------------------------------------------------------------
r22164 | avi@chromium.org | 2009-07-31 20:51:04 +0200 (Fri, 31 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Use real KVO notification for the default browser text.

BUG=none
TEST=make sure the default browser explanatory text stays working.

Review URL: http://codereview.chromium.org/159708
------------------------------------------------------------------------
r22163 | erg@google.com | 2009-07-31 20:26:24 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/chrome.gyp

I give up. Reverting all attempts at fixing the gtk-view bustage.

Reverts r22161,r22159,r22155

Review URL: http://codereview.chromium.org/159719
------------------------------------------------------------------------
r22157 | tc@google.com | 2009-07-31 19:11:41 +0200 (Fri, 31 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Show an icon and the page title in the custom frame when it's an
app mode window or a popup window.  The icon will become a
clockwise spinning throbber when pages are loading.

BUG=16049
TEST=Open a window using --app=http://google.com/ and click on a
  few links.

Review URL: http://codereview.chromium.org/160427

------------------------------------------------------------------------
r22155 | erg@google.com | 2009-07-31 19:10:04 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

GTK Themes: Use theme colors in the text view in the location bar.

Tested with a bunch of light and dark themes.

Review URL: http://codereview.chromium.org/159671
------------------------------------------------------------------------
r22153 | avi@chromium.org | 2009-07-31 17:06:25 +0200 (Fri, 31 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Add "Get themes" button to the prefs.

BUG=none
TEST=you get a button "get themes" that takes you to the theme gallery.

Review URL: http://codereview.chromium.org/160455
------------------------------------------------------------------------
r22147 | ukai@chromium.org | 2009-07-31 09:51:32 +0200 (Fri, 31 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc

Integrate OCSP handlers in SSLClientSocketNSS.
It depends on http://codereview.chromium.org/126046

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155912
------------------------------------------------------------------------
r22145 | suzhe@chromium.org | 2009-07-31 09:09:34 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   D /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/chrome.gyp

Reverting 22144.

still broke valgrind ui_tests.

Review URL: http://codereview.chromium.org/159694
------------------------------------------------------------------------
r22144 | suzhe@chromium.org | 2009-07-31 07:31:27 +0200 (Fri, 31 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   A /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/chrome.gyp

It's a copy of http://codereview.chromium.org/155772, with the fix for valgrind test failure.

This CL implements the second TODO item of issue 12343:
2) We should send back an ACK to the second process.  If the second process doesn't get an ACK in the given timeout, it should kill the first process and go ahead and start.

The approach of this CL is to append process id to the singleton's socket filename, such as "SingletonSocket-12345", and creates a symbol link "SingletonSocket" to the real socket file. In ProcessSingleton::NotifyOtherProcess() if it's successfully connected to "SingletonSocket" but no ACK received, then the original process can be killed by its process id retrieved from the symbol link.

BUG=http://crbug.com/12343 ProcessSingleton Linux cleanups
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z, then launch chrome again in another terminal. The second chrome shall be started in 5 seconds, and the first one shall be killed.

Review URL: http://codereview.chromium.org/160436
------------------------------------------------------------------------
r22143 | mhm@chromium.org | 2009-07-31 07:28:29 +0200 (Fri, 31 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc

Add "Remove from list" for download item in the download shelf.

This would remove the download list (CTRL+J) as well.

BUG=60 (http://crbug.com/60)
TEST=Download a file from the net, download shelf appears, click the download item's arrow and "Remove from list". The item removes from the shelf and list.
Review URL: http://codereview.chromium.org/155749
------------------------------------------------------------------------
r22141 | laforge@chromium.org | 2009-07-31 07:04:11 +0200 (Fri, 31 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Revert 20927 - Experiment with opening links opened via context menu in the foreground.

BUG=none
TEST=tabs opened via "Open link in new tab..." should open in foreground, not background.

Review URL: http://codereview.chromium.org/155671

TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/160439
------------------------------------------------------------------------
r22138 | mhm@chromium.org | 2009-07-31 04:54:54 +0200 (Fri, 31 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/resources/downloads.html

Add "Remove from list" for each download in domui page.

A "Remove from list" link would be added to the download items and once clicked, it will remove it from the shelf and list.

BUG=60 (http://crbug.com/60)
TEST=Download a file from the net, CTRL+J. Click on "Remove from list".  The item removes from the list and download shelf.

Review URL: http://codereview.chromium.org/155750
------------------------------------------------------------------------
r22132 | asargent@chromium.org | 2009-07-31 03:15:49 +0200 (Fri, 31 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix some whitespace lint that has crept in.

Perhaps this got in from git not running 
gcl lint / gcl presubmit checks?


BUG=none
TEST=none


Review URL: http://codereview.chromium.org/159678
------------------------------------------------------------------------
r22130 | mdm@chromium.org | 2009-07-31 02:40:15 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/common/gtk_tree_util.cc
   M /trunk/src/chrome/common/gtk_tree_util.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Linux: convert classes GtkUtil/GtkTreeUtil back to namespaces gtk_util/gtk_tree_util.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160417
------------------------------------------------------------------------
r22127 | robertshield@chromium.org | 2009-07-31 02:20:08 +0200 (Fri, 31 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

Adding outbound header filtering to automation HTTP requests.

Review URL: http://codereview.chromium.org/159649
------------------------------------------------------------------------
r22120 | tc@google.com | 2009-07-31 01:47:58 +0200 (Fri, 31 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Re-enable commands when coming out of full screen mode on linux.

Since the call is async, we need to manually tell Browser that
we're no longer in full screen mode.

BUG=18104

Review URL: http://codereview.chromium.org/159670

------------------------------------------------------------------------
r22117 | estade@chromium.org | 2009-07-31 01:01:44 +0200 (Fri, 31 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

GTK find bar positioning: Don't try to make a negative-width rectangle.

BUG=none
TEST=make your browser very narrow in debug mode, it doesn't crash

Review URL: http://codereview.chromium.org/159665
------------------------------------------------------------------------
r22116 | phajdan.jr@chromium.org | 2009-07-31 01:00:49 +0200 (Fri, 31 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Remove a NOTREACHED() in plugin code that can be reached.

It was contributing to test flakiness. I also updated a comment explaining why the code doesn't kill the plugin process.

TEST=none
http://crbug.com/18108

Review URL: http://codereview.chromium.org/159602
------------------------------------------------------------------------
r22114 | estade@chromium.org | 2009-07-31 00:57:52 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc

GTK: Bidify the status bubble.

BUG=17632

Review URL: http://codereview.chromium.org/159664
------------------------------------------------------------------------
r22113 | estade@chromium.org | 2009-07-31 00:57:41 +0200 (Fri, 31 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Remember/restore the bookmark manager pane position.

BUG=18071

Review URL: http://codereview.chromium.org/160422
------------------------------------------------------------------------
r22112 | jcampan@chromium.org | 2009-07-31 00:51:54 +0200 (Fri, 31 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   D /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/chrome.gyp

Relanding the page info on Gtk Linux.

Review URL: http://codereview.chromium.org/159657

------------------------------------------------------------------------
r22107 | mattm@chromium.org | 2009-07-31 00:34:23 +0200 (Fri, 31 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   A /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_linux.txt

Try again: Add unittest for Gtk cookie manager.

Fix a few bugs of button sensitivity not updating when it should.

Add the unittest to the valgrind/unit_tests.gtest_linux.txt list since Gtk is
causing UninitCondition errors when run with no DISPLAY.

BUG=11507
BUG=15445

Review URL: http://codereview.chromium.org/160420
------------------------------------------------------------------------
r22104 | amit@chromium.org | 2009-07-30 23:37:04 +0200 (Thu, 30 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

ChromeURLRequestContext fallout

Fix the issues caused by static_cast<ChromeURLRequestContext*>.
There were assumptions in the code that a URLRequestContext*
will always be ChromeURLRequestContext* and resulting 
'static_cast's. This assumption is no longer true. Instead,
URLlRequestContext now has a member GetChromeURLRequestContext
that returns a ChromeURLRequestContext* if it really that type.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160332
------------------------------------------------------------------------
r22103 | phajdan.jr@chromium.org | 2009-07-30 23:27:01 +0200 (Thu, 30 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/base/test_file_util.h
   M /trunk/src/base/test_file_util_posix.cc
   M /trunk/src/base/test_file_util_win.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Remove duplication of DieFileDie, and move it to proper location.

TEST=none
http://crbug.com/18085

Review URL: http://codereview.chromium.org/159658
------------------------------------------------------------------------
r22102 | estade@chromium.org | 2009-07-30 23:25:51 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

GTK: Implement omnibox DnD destination behavior.

BUG=18025

Review URL: http://codereview.chromium.org/160369
------------------------------------------------------------------------
r22101 | pinkerton@chromium.org | 2009-07-30 23:25:51 +0200 (Thu, 30 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Fix tab z-ordering on Mac. Make the TabStripController take full
ownership of its list of subviews. The subviews of the TabStripView are
now generated directly (in appropriate z-order) from a list of permanent
subviews (e.g., the new tab button) and the list of tabs. In general,
this patch seems to make tab manipulation much more stable. Patch from
Viet-Trung Luu (viettrungluu@gmail.com)
BUG=14913
TEST=open/move/close/duplicate/rip/etc. tabs and observe; also check context
menus
------------------------------------------------------------------------
r22097 | darin@chromium.org | 2009-07-30 23:10:01 +0200 (Thu, 30 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Add support for moving the mouse so that GetMessagePos would notice.

R=pkasting
BUG=18079
TEST=covered by TabDraggingTest.Tab2OutOfTabStrip

Review URL: http://codereview.chromium.org/160412
------------------------------------------------------------------------
r22093 | mattm@chromium.org | 2009-07-30 22:56:17 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   D /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Revert "Add unittest for Gtk cookie manager."

This reverts commit 91bd4c1a4703db44ea45852bf2f62822e1ded743, which caused valgrind errors.

TBR=erg
------------------------------------------------------------------------
r22092 | pinkerton@chromium.org | 2009-07-30 22:45:10 +0200 (Thu, 30 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Fix tab dragging to always hide the new tab button while dragging a tab or targeting an existing window. Makes things much nicer.
BUG=14923, 14925, 15667
TEST=dragging tabs in and out of windows, and within windows. Make sure new tab button goes away when it should and always comes back.
Review URL: http://codereview.chromium.org/160345
------------------------------------------------------------------------
r22090 | estade@chromium.org | 2009-07-30 22:22:20 +0200 (Thu, 30 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

GTK: render view: grab focus *before* forwarding mouse event to renderer.

BUG=18047
TEST=see bug

Review URL: http://codereview.chromium.org/159654
------------------------------------------------------------------------
r22089 | mattm@chromium.org | 2009-07-30 22:16:34 +0200 (Thu, 30 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h
   A /trunk/src/chrome/browser/gtk/options/cookies_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Add unittest for Gtk cookie manager.

Fix a few bugs of button sensitivity not updating when it should.

BUG=11507

Review URL: http://codereview.chromium.org/159625
------------------------------------------------------------------------
r22088 | mattm@chromium.org | 2009-07-30 22:12:43 +0200 (Thu, 30 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_table_model.h

Fix search engine manager allowing you to remove the current default search engine.

If a search engine entry is already in the main group, MakeDefaultTemplateURL should return the current index(so that button states will be updated) rather than -1(which should mean nothing was done.)

BUG=17566
TEST=Select search engine that is already in the main group but not the default, and click "make default".  The "make default" and "remove" buttons should no longer be clickable.

Review URL: http://codereview.chromium.org/159557
------------------------------------------------------------------------
r22085 | mdm@chromium.org | 2009-07-30 22:00:02 +0200 (Thu, 30 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/net/base/net_util.cc

gcc >= 4.3 fixes
Patch from joel.stan@gmail.com: http://codereview.chromium.org/160377
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159648
------------------------------------------------------------------------
r22084 | jhawkins@chromium.org | 2009-07-30 21:31:45 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

gtk: Grab the pointer when we grab focus for the source tab's widget.  Fixes a crash where events were being sent to an unknown, unrealized widget.

BUG=18049
TEST=Quickly drag a tab down out of the tab strip.  The browser should not crash.
Review URL: http://codereview.chromium.org/160379
------------------------------------------------------------------------
r22071 | jcampan@chromium.org | 2009-07-30 20:24:56 +0200 (Thu, 30 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   D /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   A /trunk/src/chrome/browser/page_info_window.cc (from /trunk/src/chrome/browser/page_info_window.cc:22069)
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/chrome.gyp

Reverting 22070.
Review URL: http://codereview.chromium.org/159645
------------------------------------------------------------------------
r22070 | jcampan@chromium.org | 2009-07-30 20:08:49 +0200 (Thu, 30 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/page_info_window_gtk.cc
   M /trunk/src/chrome/browser/page_info_model.cc
   M /trunk/src/chrome/browser/page_info_model.h
   D /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/chrome.gyp

Implementation of the page info dialog on Linux Gtk.

BUG=http://crbug.com/11598
TEST=Visit an HTTPS page, click the lock icon, the page info should show.

Review URL: http://codereview.chromium.org/159521

------------------------------------------------------------------------
r22067 | darin@chromium.org | 2009-07-30 20:01:39 +0200 (Thu, 30 Jul 2009) | 53 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/net/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/net/url_request_mock_util.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   A /trunk/src/chrome/test/data/cross-origin-redirect-blocked.html
   A /trunk/src/chrome/test/data/redirect-to-title2.html
   A /trunk/src/chrome/test/data/redirect-to-title2.html.mock-http-headers
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_filter.cc
   M /trunk/src/net/url_request/url_request_filter.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/glue/media/buffered_data_source.cc
   M /trunk/src/webkit/glue/media/buffered_data_source.h
   M /trunk/src/webkit/glue/media/simple_data_source.cc
   M /trunk/src/webkit/glue/media/simple_data_source.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlloader_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Add plumbing for allowing the renderer to intercept and cancel redirects before
they are sent.

A good portion of this CL is to support the new UI test.

The IPC to notify the renderer of a redirect now includes a ResponseInfo struct
allowing WebURLLoaderImpl to provide detailed response info (including response
headers) to WebKit.  This isn't strictly necessary, but I thought I'd include
this to make the code more future proof.

A cross origin restriction is added to SyncResourceHandler::OnRequestRedirected
that mimics the code in WebCore/platform/network/cf/ResourceHandleCFNet.cpp.
This is most unfortunate, and I filed a bug at bugs.webkit.org about the
similar duplication of logic in WebCore.

There seemed to be enough code paths leading to request cancellation at the
ResourceDispatcher level that I couldn't easily ensure that a request only gets
cancelled once.  So, I added an is_cancelled flag to record if it is not
necessary to send a ViewHostMsg_CancelRequest IPC.  This avoids some warnings
in the ResourceDispatcherHost.

To support my UI test, I needed to change URLRequestMockHttpJob to know how to
serve redirects.  I moved URLRequestHttpJob::IsRedirectResponse to its base
class, URLRequestJob so that the implementation could be shared.  This revealed
a minor bug in URLRequest.  We were never resetting response_info_ upon
following a redirect.  I added this code consolidated similar code from
URLRequest::Redirect and URLRequest::RestartWithJob into a new PrepareToRestart
method.

To support my UI test, I added a "hit count" field to URLRequestFilter, and I
added an associated automation IPC to query the value.  The test was a bit
challenging to write because there is no way to tell the difference from JS.
Before and after, it appears to JS as though the cross-origin redirect failed.
However, the server can see the extra redirect request.  So, I simply record
the number of hits against URLs of the form http://mock.http/foo, and use that
to observe if any extra requests were made.  I implemented the new IPC message
by extending the AutomationResourceMessageFilter.  This allowed me to trap the
IPC message on the IO thread where it is safe to probe the URLRequestFilter.  I
then changed the implementation of AutomationMsg_SetFilteredInet to work
similarly.

I revised URLRequestMockHTTPJob::GetOnDiskPath to support ports.  This actually
allowed me to reuse URLRequestMockHTTPJob to service URLs in different security
origins.  My test redirects from http://mock.http/ to http://mock.http:4000/.

Please see the comments in cross-origin-redirect-blocked.html for details about
how the test functions.

R=brettw,wtc
BUG=16413
TEST=covered by resource_dispatcher_host_uitest.cc

Review URL: http://codereview.chromium.org/159370
------------------------------------------------------------------------
r22066 | kuchhal@chromium.org | 2009-07-30 20:00:47 +0200 (Thu, 30 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc

Fixing the google browser name in about:memory page.

BUG=4928
TEST=Open about:memory page a see if the browser name of Google is what is expected.

Review URL: http://codereview.chromium.org/159385
Patch from Thiago Farina <thiago.farina@gmail.com>.
------------------------------------------------------------------------
r22061 | darin@chromium.org | 2009-07-30 18:54:09 +0200 (Thu, 30 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Temporarily disable a failing interactive UI test.

TBR=avi
BUG=18079
TEST=none

Review URL: http://codereview.chromium.org/160400
------------------------------------------------------------------------
r22060 | pinkerton@chromium.org | 2009-07-30 18:50:45 +0200 (Thu, 30 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Get rid of redundant tab layout by installing incognito badge and adjusting tab strip before creating the tab strip controller. 
BUG=none
TEST=initial incognito tab layout should exactly match normal tab layout (including new tab button).
Review URL: http://codereview.chromium.org/160397
------------------------------------------------------------------------
r22058 | avi@chromium.org | 2009-07-30 18:24:35 +0200 (Thu, 30 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Properly destroy popups when their parent views are told to destroy.

BUG=http://crbug.com/12970
TEST=as in bug

Review URL: http://codereview.chromium.org/160353
------------------------------------------------------------------------
r22056 | phajdan.jr@chromium.org | 2009-07-30 17:48:53 +0200 (Thu, 30 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   D /trunk/src/chrome/browser/automation/url_request_failed_dns_job.cc
   D /trunk/src/chrome/browser/automation/url_request_failed_dns_job.h
   D /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   D /trunk/src/chrome/browser/automation/url_request_mock_http_job.h
   D /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   D /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h
   D /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   D /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   D /trunk/src/chrome/browser/automation/url_request_slow_http_job.cc
   D /trunk/src/chrome/browser/automation/url_request_slow_http_job.h
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   A /trunk/src/chrome/browser/net/url_request_failed_dns_job.cc (from /trunk/src/chrome/browser/automation/url_request_failed_dns_job.cc:22054)
   A /trunk/src/chrome/browser/net/url_request_failed_dns_job.h (from /trunk/src/chrome/browser/automation/url_request_failed_dns_job.h:22054)
   A /trunk/src/chrome/browser/net/url_request_mock_http_job.cc (from /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc:22054)
   A /trunk/src/chrome/browser/net/url_request_mock_http_job.h (from /trunk/src/chrome/browser/automation/url_request_mock_http_job.h:22054)
   A /trunk/src/chrome/browser/net/url_request_mock_net_error_job.cc (from /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc:22054)
   A /trunk/src/chrome/browser/net/url_request_mock_net_error_job.h (from /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h:22054)
   A /trunk/src/chrome/browser/net/url_request_mock_util.cc
   A /trunk/src/chrome/browser/net/url_request_mock_util.h
   A /trunk/src/chrome/browser/net/url_request_slow_download_job.cc (from /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc:22054)
   A /trunk/src/chrome/browser/net/url_request_slow_download_job.h (from /trunk/src/chrome/browser/automation/url_request_slow_download_job.h:22054)
   A /trunk/src/chrome/browser/net/url_request_slow_http_job.cc (from /trunk/src/chrome/browser/automation/url_request_slow_http_job.cc:22054)
   A /trunk/src/chrome/browser/net/url_request_slow_http_job.h (from /trunk/src/chrome/browser/automation/url_request_slow_http_job.h:22054)
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Move mock url request classes to a location when browser tests will be able to use them too.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/160366
------------------------------------------------------------------------
r22054 | darin@chromium.org | 2009-07-30 17:01:19 +0200 (Thu, 30 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Use GET_X/Y_PARAM instead of LO/HIWORD.

According to MSDN, this avoids signed/unsigned issues that can
lead to problems on systems with multiple monitors.

Credit goes to Yoav Zilberberg for catching this!

R=pkasting
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/160372
------------------------------------------------------------------------
r22043 | aa@chromium.org | 2009-07-30 08:21:58 +0200 (Thu, 30 Jul 2009) | 22 lines
Changed paths:
   M /trunk/src/build/common.gypi
   A /trunk/src/chrome/browser/extensions/crx_installer.cc
   A /trunk/src/chrome/browser/extensions/crx_installer.h
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   M /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/chrome.gyp

Pull CrxInstaller out of ExtensionsService.

CrxInstaller is a new stateful object that encapsulates a
single installation from unpack through notification.

It currently contains the UI bits, but I suspect in the next
CL (where I will finally implement the install UI) these
will come out and CrxInstaller will become
SilentCrxInstaller, and only used for updates and external
installs.

Also in this change, I removed the concept of install callbacks that ExtensionUpdater was using. This was only used to delete the temp crx file as far as I can tell, and we can easily keep state about that in CrxInstaller.

With this CL, ExtensionsServiceBackend is almost completely
dead, with only a few zombie methods left like
LoadAllExtensions(). These should all become little objects
like CrxInstaller that hold a reference to ExtensionsService
over their lifetime and then kill themselves.

I'll get to that eventually.

Review URL: http://codereview.chromium.org/160311
------------------------------------------------------------------------
r22036 | mdm@chromium.org | 2009-07-30 03:33:24 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Linux: convert namespace gtk_util to class GtkUtil to meet style guidelines.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160371
------------------------------------------------------------------------
r22035 | jhawkins@chromium.org | 2009-07-30 03:29:42 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

gtk: Add the 'Stats for nerds' link to the task manager.

BUG=17851
TEST=Open the task manager.  Click on the 'Stats for nerds' link.  Browser should navigate to about:memory.
Review URL: http://codereview.chromium.org/159616
------------------------------------------------------------------------
r22024 | darin@chromium.org | 2009-07-30 01:55:47 +0200 (Thu, 30 Jul 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Use GetMessagePos instead of GetCursorPos to avoid unwanted detached tabs.

The problem with GetCursorPos is that it queries the mouse position right now,
which means that the values may not be consistent with the values reported via
windows messages.  GetMessagePos on the other hand returns the mouse position
as last reported via the message loop.

With this change, I'm unable to reproduce unwanted detached tabs even under
heavy system load.

R=ben
BUG=2993
TEST=While your system is heavily loaded, click on a tab, release the mouse
button and then move the mouse downward.  Do this as quickly as you can, and
the tab should stay put.

Review URL: http://codereview.chromium.org/160364
------------------------------------------------------------------------
r22020 | jcampan@chromium.org | 2009-07-30 01:34:56 +0200 (Thu, 30 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/test/testing_browser_process.h

There is no need for the browser process to have an accelerator handler.This CL cleans this up.BUG=NoneTEST=Accelerator should work in Chrome and in the first run window.
Review URL: http://codereview.chromium.org/160301
------------------------------------------------------------------------
r22019 | mdm@chromium.org | 2009-07-30 01:28:10 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/gtk_tree_util.cc
   A /trunk/src/chrome/common/gtk_tree_util.h

Linux: factor out some shared GTK tree utility code.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160356
------------------------------------------------------------------------
r22018 | erg@google.com | 2009-07-30 01:23:25 +0200 (Thu, 30 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

GTK Themes: Native omnibox part 2.

Put the star and go/stop buttons inside the location bar drawing. Reverts my changes to
location_bar_view_gtk.cc in the previous patch. (Showed mocks of this to Ben and Glen.)

Also fixes rendering of the location bar background under Crux and other themes that
draw an entry_bg.

Review URL: http://codereview.chromium.org/159610
------------------------------------------------------------------------
r22017 | ananta@chromium.org | 2009-07-30 01:18:19 +0200 (Thu, 30 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Added automation messages and corresponding handlers to support operations like 

1. SelectAll
2. Cut/Copy/Paste
3. Reload :- Added an asynchronous version of this IPC
4. Stop.

Review URL: http://codereview.chromium.org/159609
------------------------------------------------------------------------
r22016 | japhet@chromium.org | 2009-07-30 01:12:27 +0200 (Thu, 30 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Force sizing of a new tab as soon as TabContents is created.

BUG=619
BUG=15960
TEST=none


Review URL: http://codereview.chromium.org/126290
------------------------------------------------------------------------
r22015 | jhawkins@chromium.org | 2009-07-30 01:06:59 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

gtk: Don't wrap around when scrolling the tab strip using the scroll event.  This matches native gtk behavior.

BUG=17869
TEST=Open multiple tabs.  Scroll the tabs using the scroll wheel.  The scroll should not wrap around.
Review URL: http://codereview.chromium.org/160362
------------------------------------------------------------------------
r22012 | estade@chromium.org | 2009-07-30 01:00:25 +0200 (Thu, 30 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc

GTK: move the findbar out of the way when it covers a find result.

BUG=15875

Review URL: http://codereview.chromium.org/160350
------------------------------------------------------------------------
r22011 | estade@chromium.org | 2009-07-30 00:59:36 +0200 (Thu, 30 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.h

Make the DownloadRequestDialogDelegateGtk always report some response to the download request manager.

We weren't reporting Cancel on page navigation, which meant the download request manager had a stale pointer that it later tried to dereference.

BUG=18021

Review URL: http://codereview.chromium.org/160361
------------------------------------------------------------------------
r22001 | derat@google.com | 2009-07-29 23:52:28 +0200 (Wed, 29 Jul 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Linux: Save and restore bookmark manager and task manager window size.

To test, did the following under Metacity/GNOME:

- remove window_placement prefs from "Local State" file
- start chrome
- open bookmark manager with Ctrl-Shift-B
- resize window to be small and close it
- reopen bookmark manager and confirm that its window is the same
  size as when closed
- maximize bookmark manager and close it
- reopen bookmark manager and confirm that it's still small
- minimize bookmark manager before closing it; confirm that the
  size remains the same
- restart chrome and confirm that the window size is still saved
- repeat the above tests with the task manager (which is a bit
  quicker, since it doesn't allow maximizing or minimizing)

BUG=15488
TEST=see above

Review URL: http://codereview.chromium.org/160330
------------------------------------------------------------------------
r22000 | phajdan.jr@chromium.org | 2009-07-29 23:51:41 +0200 (Wed, 29 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc

Undisable DnsMasterTest.MassiveConcurrentLookupTest.

It still passes, and provides coverage for situation where there are
lots of DNS requests at the same time.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/159601
------------------------------------------------------------------------
r21998 | mattm@chromium.org | 2009-07-29 23:47:23 +0200 (Wed, 29 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/options_util.h

Add private: before DISALLOW_IMPLICIT_CONSTRUCTORS.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160354
------------------------------------------------------------------------
r21995 | jeremy@chromium.org | 2009-07-29 23:12:11 +0200 (Wed, 29 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/FirstRunDialog.xib
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   D /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.cc
   A /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.mm
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   A /trunk/src/chrome/browser/importer/nss_decryptor_mac.mm
   M /trunk/src/chrome/chrome.gyp

First cut at Firefox import on OSX + stubs for Safari import.

Known limitations:
* Runs in browser process, should run in a separate process.
* No UI.
* No FF password import.

BUG=15455
TEST=Check that firefox settings are correctly imported on first run, firefox password importing and Safari importing still don't work.

Review URL: http://codereview.chromium.org/160341
------------------------------------------------------------------------
r21991 | mattm@chromium.org | 2009-07-29 22:51:58 +0200 (Wed, 29 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h

Gtk password dialog: Initialize pending_login_query_.

BUG=8205

Review URL: http://codereview.chromium.org/159603
------------------------------------------------------------------------
r21989 | tc@google.com | 2009-07-29 22:40:50 +0200 (Wed, 29 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Draw the side and bottom shadows in the native frame.

As with the rest of our shadow drawing, we don't overlap 1 pixel, we
just draw the area around.

BUG=15505

Review URL: http://codereview.chromium.org/160306

------------------------------------------------------------------------
r21986 | tc@google.com | 2009-07-29 22:12:25 +0200 (Wed, 29 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

Move the tabstrip to the right one pixel so our tab placement
matches up with Windows.

BUG=17915

Review URL: http://codereview.chromium.org/160281

------------------------------------------------------------------------
r21983 | jcampan@chromium.org | 2009-07-29 22:02:05 +0200 (Wed, 29 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/panel_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/test/test_browser_window.h

Landing Thiago Farina's CL.

See http://codereview.chromium.org/159186

Renaming GetNormalBounds to GetRestoredBounds from browser_window.h.

BUG=None
TEST=None
TBR=tfarina
Review URL: http://codereview.chromium.org/160337
------------------------------------------------------------------------
r21975 | xji@chromium.org | 2009-07-29 20:27:52 +0200 (Wed, 29 Jul 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

This CL fixes issue 17468: Regression: Directionality marks should not be inserted for LTR systems

To avoid empty square displayed around tooltip when system does not have RTL support, only add Unicode marks when element's directionality is not the same as UI's directionality.

Note:
1. tooltip will be displayed using its element's directionality.
2. in system without RTL support, tooltip will only be displayed correctly (in its element's directionality and without empty square around) when both UI and element's directionality is LTR.
 

BUG=http://crbug.com/17468
TEST=
1. Uninstall the right-to-left script and east Asian script through the Control Panel and restart system.
2. Run English Chrome.
3. given the following HTML, the displayed tooltip should not have empty square around. 
<html>
<head>
	<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="TEXT/HTML; CHARSET=utf-8">
</head>
<body>
<span style="background-color:Blue" title="Hi!">And now here!</span>
</body></html>

Review URL: http://codereview.chromium.org/160262
------------------------------------------------------------------------
r21973 | mdm@chromium.org | 2009-07-29 20:20:03 +0200 (Wed, 29 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/exceptions_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/passwords_exceptions_window_gtk.h
   A /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/passwords_page_gtk.h
   M /trunk/src/chrome/chrome.gyp

Linux: add the password manager UI.
BUG=8205
TEST=go to wrench->options->personal stuff->show saved passwords, it works

Review URL: http://codereview.chromium.org/159522
------------------------------------------------------------------------
r21966 | thakis@chromium.org | 2009-07-29 19:40:39 +0200 (Wed, 29 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   A /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.cc
   A /trunk/src/chrome/browser/gtk/download_request_dialog_delegate_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Implement the "This site is attempting to download
multiple files. Do you want to allow this?" dialog on linux.

BUG=12757
TEST=Download several files from the same domain. After the first download, you should be prompted for every additional file you want to download from that domain (try for example http://amnoid.de/ddsview/download.html , click on the "download" link twice).

Review URL: http://codereview.chromium.org/159528
------------------------------------------------------------------------
r21965 | erg@google.com | 2009-07-29 19:38:10 +0200 (Wed, 29 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

GTK Themes: Native location bar area.

The combined star/location bar/go construct doesn't look native. In
GTK mode, make the star and go buttons act like toolbar buttons, and
draw a GTK text entry widget onto the toolbar. The omnibox popup
is just the size of the entry when in GTK theme mode.

There's still a lot of work to be done on this; I want to properly
draw focus rings, have the rest of the location box use theme colors, et cetera, but this is less broken then what's currently
there.

Review URL: http://codereview.chromium.org/159532
------------------------------------------------------------------------
r21961 | jcampan@chromium.org | 2009-07-29 19:25:30 +0200 (Wed, 29 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

The focus would be messed-up when reloading a crashed tab, also causing accelerators to be broken.

This CL also makes sure to keep the focus on the location bar when reloading the NTP.

BUG=http://crbug.com/14954
TEST=See bug.
Review URL: http://codereview.chromium.org/160206
------------------------------------------------------------------------
r21946 | yuzo@chromium.org | 2009-07-29 09:16:00 +0200 (Wed, 29 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

Move window to workarea origin if it is completely off-screen.

BUG=17822
TEST=Use multiple monitors. Start Chrome, move the window to a non-primary
monitor, and exit Chrome. Disconnect or disable the monitor and start Chrome
again. Chrome should appear at the origin of a remaining monitor. Also try
chaning the resolution of the non-primary monitor. As far as the window fits
within the monitor, it should be shown as-is. If not, it is moved to the origin
and resized, if necessary.

Review URL: http://codereview.chromium.org/160246
------------------------------------------------------------------------
r21945 | willchan@chromium.org | 2009-07-29 09:04:35 +0200 (Wed, 29 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   D /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/chrome.gyp

Reverting 21943.

Broke valgrind ui_tests
Review URL: http://codereview.chromium.org/160320
------------------------------------------------------------------------
r21944 | hbono@chromium.org | 2009-07-29 08:56:18 +0200 (Wed, 29 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

A quick fix for Issue 13443 (Take 2).

It seems NXClient sends GDK_Tab not only when we press control+tab keys but also when we press control+shift+tab keys.
To emulate Firefox, this change checks if |modifier| is control+shift when |keyval| is either GDK_Tab, GDK_ISO_Left_Tab, or GDK_KP_Tab.

BUG=13443 "Shift+Ctrl+Tab should cycle tabs backwards"
TEST=Execute Chromium on an NX Client, press control+shift+tab keys, and verify tabs cycle backwards.
Review URL: http://codereview.chromium.org/155564
------------------------------------------------------------------------
r21943 | willchan@chromium.org | 2009-07-29 08:04:47 +0200 (Wed, 29 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   A /trunk/src/chrome/browser/process_singleton_linux_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/chrome.gyp

Linux: Adds ACKs to ProcessSingletonLinux.
Patch contributed by suzhe@google.com (http://codereview.chromium.org/155772)
BUG=http://crbug.com/12343
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z,
then launch chrome again in another terminal. The second chrome shall be started
in 5 seconds, and the first one shall be killed.

Review URL: http://codereview.chromium.org/159577
------------------------------------------------------------------------
r21941 | glen@chromium.org | 2009-07-29 06:16:40 +0200 (Wed, 29 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Add null pointer check. It appears some themes specify images that don't exist, and some newly added code handled that poorly, leading to crashes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160312
------------------------------------------------------------------------
r21940 | willchan@chromium.org | 2009-07-29 05:42:00 +0200 (Wed, 29 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc

Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_.
BUG=http://crbug.com/16371

Review URL: http://codereview.chromium.org/159561
------------------------------------------------------------------------
r21936 | estade@chromium.org | 2009-07-29 04:09:15 +0200 (Wed, 29 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Make find bar BIDI.

BUG=17475
TEST=obvious

Review URL: http://codereview.chromium.org/159570
------------------------------------------------------------------------
r21934 | mattm@chromium.org | 2009-07-29 03:04:19 +0200 (Wed, 29 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h

Gtk: Add default encoding option.

BUG=11507

Review URL: http://codereview.chromium.org/160307
------------------------------------------------------------------------
r21930 | robertshield@chromium.org | 2009-07-29 02:22:37 +0200 (Wed, 29 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/common/common_param_traits.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/automation/automation_messages.h

Cause POST data to be marhsaled across the automation interface when using AutomationMsg_RequestStart.

Review URL: http://codereview.chromium.org/159228
------------------------------------------------------------------------
r21920 | aa@chromium.org | 2009-07-29 01:28:37 +0200 (Wed, 29 Jul 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_file_util.cc
   A /trunk/src/chrome/browser/extensions/extension_file_util.h
   A /trunk/src/chrome/browser/extensions/extension_file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.h

Pull all the filesystem manipulation out of
ExtensionsServiceBackend into a set of utility functions.

The intent of this is:
a) make extensions_service.cc smaller
b) have smaller pieces hanging around that we can more easily
   reconfigure to implement new features.
c) improve testability.
Review URL: http://codereview.chromium.org/159400
------------------------------------------------------------------------
r21914 | glen@chromium.org | 2009-07-29 01:10:36 +0200 (Wed, 29 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Stop doing the saturation-gradient thing on the NNTP. It blinded people. Also update the section background so that it looks the same on white, but is actually transparent.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159549
------------------------------------------------------------------------
r21910 | glen@chromium.org | 2009-07-29 00:57:22 +0200 (Wed, 29 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h

Only allow one theme installation infobar to be shown at a time.

BUG=None
TEST=Install two themes without closing the infobar - make sure only one infobar is visible.

Review URL: http://codereview.chromium.org/160296
------------------------------------------------------------------------
r21909 | arv@google.com | 2009-07-29 00:52:40 +0200 (Wed, 29 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix issues with right border of the lower section as well as some CSS
tweaks for the list view mode.

This also fixes an issue where the thumbnails were not positioned
correctly at startup in RTL

BUG=17810, 17811, 17751

TEST=Hide the recent activities and make sure that the right border of
even more is shown. Switch to list mode. Make sure that the filler are
hidden. Try dragging the items in the list view. The text should not
dissappear.

Review URL: http://codereview.chromium.org/160291
------------------------------------------------------------------------
r21908 | phajdan.jr@chromium.org | 2009-07-29 00:45:58 +0200 (Wed, 29 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   A /trunk/src/chrome/browser/gtk/extension_view_gtk.cc
   A /trunk/src/chrome/browser/gtk/extension_view_gtk.h
   M /trunk/src/chrome/chrome.gyp

Create render view for extensions on Linux.

Now when an extension is loaded, you will see its entry in the task manager.
However, on the shelf there is still only a placeholder label (I have to
work on setting proper size for the render widget).

TEST=none
http://crbug.com/16759

Review URL: http://codereview.chromium.org/159527
------------------------------------------------------------------------
r21906 | estade@chromium.org | 2009-07-29 00:38:15 +0200 (Wed, 29 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

left a file out

TBR=awong

Review URL: http://codereview.chromium.org/159550
------------------------------------------------------------------------
r21905 | estade@chromium.org | 2009-07-29 00:28:45 +0200 (Wed, 29 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: More hotkeys.

- ctrl+e = ctrl+k
- alt + e and alt + f to open the page and wrench menus respectively (emulating menu bar _File and _Edit)

BUG=none
TEST=use the new hotkeys

Review URL: http://codereview.chromium.org/160292
------------------------------------------------------------------------
r21903 | arv@google.com | 2009-07-29 00:17:21 +0200 (Wed, 29 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/i18n_template.js
   M /trunk/src/chrome/browser/resources/new_tab.html

Old NTP: Make sure we do not try to load "undefined" for the p13n
iframe.

Also, override some styles that gets set in the theme css which is
written for the new new tab page.

BUG=None

TEST=Start chrome with --old-new-tab-page

Review URL: http://codereview.chromium.org/160290
------------------------------------------------------------------------
r21902 | mdm@chromium.org | 2009-07-29 00:13:14 +0200 (Wed, 29 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc

Linux: it's not actually a bug to have the selection become empty in the URL picker.
BUG=none
TEST=in a debug build, go to wrench->options->basics, select "open the following pages", click "add", select something from the list, and then deselect it by holding ctrl and clicking it again; chromium should not crash

Review URL: http://codereview.chromium.org/159540
------------------------------------------------------------------------
r21898 | ananta@chromium.org | 2009-07-29 00:04:22 +0200 (Wed, 29 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc

There are instances where the URLRequestAutomationJob::Kill() function can get called after Cleanup, which
results in the AutomationResourceMessageFilter member getting destroyed and a subsequent crash.

Added a NULL check for the same.

Review URL: http://codereview.chromium.org/160293
------------------------------------------------------------------------
r21896 | klink@chromium.org | 2009-07-28 23:34:20 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Adds additional MSAA information to fill in a few gaps in the hierarchy.

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/160239
------------------------------------------------------------------------
r21891 | deanm@chromium.org | 2009-07-28 23:15:56 +0200 (Tue, 28 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/media/base/video_frame_impl.cc
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/disk_cache/mapped_file_posix.cc

Assorted fixes for 64-bit.

Review URL: http://codereview.chromium.org/160288

------------------------------------------------------------------------
r21889 | wtc@chromium.org | 2009-07-28 23:09:43 +0200 (Tue, 28 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h

Fix a BAD_OVERRIDE defect reported by Coverity.  Remove
an unused version of the OnMessageReceived method.

R=brettw
BUG=17104
TEST=none
Review URL: http://codereview.chromium.org/160242
------------------------------------------------------------------------
r21887 | brettw@chromium.org | 2009-07-28 23:05:32 +0200 (Tue, 28 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc

Add a NULL check for the pending render view host when we get a close message.
I don't think we're guaranteed to have a pending one.

BUG=17916
Review URL: http://codereview.chromium.org/160286
------------------------------------------------------------------------
r21884 | evan@chromium.org | 2009-07-28 22:41:17 +0200 (Tue, 28 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc

linux: extra shadow in prefs dialog

When we use gtk_scrolled_window_add_with_viewport, it sets its own
shadow.

BUG=16913

Review URL: http://codereview.chromium.org/159535
------------------------------------------------------------------------
r21878 | mpcomplete@chromium.org | 2009-07-28 22:14:53 +0200 (Tue, 28 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html

Reenable use of ExecuteScriptInNewWorld.

I didn't even realize I checked in the code that disabled it.

BUG=no
TEST=no

Review URL: http://codereview.chromium.org/159454
------------------------------------------------------------------------
r21875 | phajdan.jr@chromium.org | 2009-07-28 21:46:59 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Disable ShowModalDialogTest.BasicTest. Currently #2 flaky test.

TEST=none
http://crbug.com/17806

Review URL: http://codereview.chromium.org/160210
------------------------------------------------------------------------
r21874 | idanan@chromium.org | 2009-07-28 21:41:36 +0200 (Tue, 28 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/net/url_request/url_request_context.h

Moved the logical dependency on Blacklist from URLRequestContext
to ChromeURLRequestContext.

BUG=16932
TEST=none

Review URL: http://codereview.chromium.org/159519
------------------------------------------------------------------------
r21873 | sgk@google.com | 2009-07-28 21:39:33 +0200 (Tue, 28 Jul 2009) | 5 lines
Changed paths:
   D /trunk/src/app/app.vsprops
   D /trunk/src/base/build/base.vsprops
   D /trunk/src/base/build/base_gfx.vsprops
   D /trunk/src/base/build/base_unittests.vsprops
   D /trunk/src/chrome/app/theme/theme_dll.vsprops
   D /trunk/src/chrome/browser/browser.vsprops
   D /trunk/src/chrome/installer/gcapi/gcapi.vsprops
   D /trunk/src/chrome/installer/util/prebuild/using_util_prebuild.vsprops
   D /trunk/src/chrome/renderer/renderer.vsprops
   D /trunk/src/chrome/test/activex_test_control/activex_test_control.vsprops
   D /trunk/src/chrome/test/automation/automation.vsprops
   D /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.vsprops
   D /trunk/src/chrome/tools/build/win/browser_tests_dll.vsprops
   D /trunk/src/chrome/tools/build/win/data_dll.vsprops
   D /trunk/src/chrome/tools/build/win/debugger_disabled.vsprops
   D /trunk/src/chrome/tools/build/win/js_engine.vsprops
   D /trunk/src/chrome/tools/build/win/js_engine_impl.vsprops
   D /trunk/src/chrome/tools/build/win/js_engine_impl_kjs.vsprops
   D /trunk/src/chrome/tools/build/win/language_dll.vsprops
   D /trunk/src/chrome/tools/build/win/reliability_test.vsprops
   D /trunk/src/chrome/tools/build/win/test_memory_usage.vsprops
   D /trunk/src/chrome/tools/build/win/test_shell_tests.vsprops
   D /trunk/src/chrome/tools/build/win/ui_test.vsprops
   D /trunk/src/google_update/using_google_update.vsprops
   D /trunk/src/net/build/net.vsprops
   D /trunk/src/o3d/o3d_common.vsprops
   D /trunk/src/printing/printing.vsprops
   D /trunk/src/sdch/using_sdch.vsprops
   D /trunk/src/third_party/sqlite/sqlite.vsprops
   D /trunk/src/views/views.vsprops
   D /trunk/src/webkit/activex_shim/activex_shim.vsprops
   D /trunk/src/webkit/activex_shim_dll/activex_shim_dll.vsprops
   D /trunk/src/webkit/build/JavaScriptCore/bug_1124849_debug.vsprops
   D /trunk/src/webkit/build/JavaScriptCore/bug_1124849_release.vsprops
   D /trunk/src/webkit/build/JavaScriptCore/javascriptcore.vsprops
   D /trunk/src/webkit/build/JavaScriptCore/testapi.vsprops
   D /trunk/src/webkit/build/JavaScriptCore/using_javascriptcore.vsprops
   D /trunk/src/webkit/build/JavaScriptCore/wtf.vsprops
   D /trunk/src/webkit/build/KJSBindings/KJSBindings.vsprops
   D /trunk/src/webkit/build/KJSBindings/using_KJSBindings.vsprops
   D /trunk/src/webkit/build/V8Bindings/using_v8bindings.vsprops
   D /trunk/src/webkit/build/V8Bindings/v8bindings.vsprops
   D /trunk/src/webkit/build/WebCore/webcore.vsprops
   D /trunk/src/webkit/build/WebKit/WebKit.vsprops
   D /trunk/src/webkit/build/js_engine.vsprops
   D /trunk/src/webkit/build/js_engine_kjs.vsprops
   D /trunk/src/webkit/build/port/port.vsprops
   D /trunk/src/webkit/build/precompiled_webkit.vsprops
   D /trunk/src/webkit/build/webkit_common.vsprops
   D /trunk/src/webkit/build/webkit_common_defines.vsprops
   D /trunk/src/webkit/build/webkit_common_includes.vsprops
   D /trunk/src/webkit/default_plugin/default_plugin.vsprops
   D /trunk/src/webkit/glue/glue.vsprops
   D /trunk/src/webkit/tools/test_shell/test_shell.vsprops
   D /trunk/src/webkit/tools/test_shell/test_shell_tests.vsprops
   D /trunk/src/webkit/tools/test_shell/test_worker/test_worker.vsprops

Remove *.vsprops files that are no longer referenced (or only have
references to each other) anywhere in the Chromium code base.
BUG=none
TEST=rebuild
Review URL: http://codereview.chromium.org/159523
------------------------------------------------------------------------
r21871 | jeremy@chromium.org | 2009-07-28 21:21:25 +0200 (Tue, 28 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/google_update_settings_mac.mm
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

Turn on metrics reporting on POSIX if user has consented.

Review URL: http://codereview.chromium.org/159512
------------------------------------------------------------------------
r21870 | mattm@chromium.org | 2009-07-28 21:20:46 +0200 (Tue, 28 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Fix proxy settings for Gnome >=2.26

Proxy settings are set using Gnome's network properties dialog, by running the
binary directly.  The binary was renamed from gnome-system-preferences to
gnome-system-properties in Janurary 2009, so to ensure the dialog works on both
newer and older systems, this patch searches the users PATH for the binary to use.

Upstream rename: http://git.gnome.org/cgit/gnome-control-center/commit/?id=4f1b6aafba338a267b6c1b911ceb33358b2eca09

BUG=17756
TEST='Under the Hood' -> 'Change proxy settings' still works on Ubuntu Hardy as well as Ubuntu Jaunty.

Review URL: http://codereview.chromium.org/160146
Patch from Joel Stanley.
------------------------------------------------------------------------
r21869 | arv@google.com | 2009-07-28 20:48:44 +0200 (Tue, 28 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/resources/new_new_tab.js

When there are no images to replace a blacklisted page, putting filler
causes a blank spot which no other thumbnail can be dragged to. This 
will go away on page refresh, but we can easily redraw all items
keeping the filler in the rightmost indices.

Original patch by pierre.lafayette@gmail.com, http://codereview.chromium.org/160152

BUG=17738

r=me

------------------------------------------------------------------------
r21866 | evan@chromium.org | 2009-07-28 20:40:20 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

linux: make --single-process work again for plugins

We can use a TYPE_IO loop for the renderer thread on Linux
in single-process mode since we run the plugins out of process.

Review URL: http://codereview.chromium.org/160274
------------------------------------------------------------------------
r21854 | arv@google.com | 2009-07-28 19:23:06 +0200 (Tue, 28 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/startup/feature_startup_test.cc

Disable first run for the New Tab Cold perf test.

BUG=17668

TEST=Run the test

Review URL: http://codereview.chromium.org/160108
------------------------------------------------------------------------
r21849 | asargent@chromium.org | 2009-07-28 18:48:42 +0200 (Tue, 28 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc

Make the minimum extensions update frequency allowed on command line be 30 seconds.

This is as opposed to the value of 1 hour in release mode, which makes testing
difficult for people trying to test out autoupdate.

BUG=http://crbug.com/17867
TEST=Run with --enable-extensions --extension-update-frequency=30 will actually update an extension
that has updates after 30 seconds.

Review URL: http://codereview.chromium.org/159490
------------------------------------------------------------------------
r21846 | evan@chromium.org | 2009-07-28 18:05:51 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Enable Client ID generation on Linux/OS X.  Enables UMA logging.

BUG=15418

Review URL: http://codereview.chromium.org/149758
Patch from Chris Masone <cmasone@google.com>.
------------------------------------------------------------------------
r21844 | jeremy@chromium.org | 2009-07-28 17:56:12 +0200 (Tue, 28 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FirstRunDialog.xib
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   M /trunk/src/chrome/browser/cocoa/first_run_dialog.mm
   M /trunk/src/chrome/browser/first_run_mac.mm

Nice looking First-Run dialogs.

* Switch NIB.
* Use NSWindowController.
* "Make default browser" button hooked up.
* Import bookmarks still not implemented.

Review URL: http://codereview.chromium.org/149512
------------------------------------------------------------------------
r21843 | phajdan.jr@chromium.org | 2009-07-28 17:48:03 +0200 (Tue, 28 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc

Fix the root cause of flakiness in SafeBrowsingProtocolManagerTest.TestGetHashBackOffTimes
and undisable the test.

TEST=none
http://crbug.com/1880

Review URL: http://codereview.chromium.org/160225
------------------------------------------------------------------------
r21841 | idanan@chromium.org | 2009-07-28 17:18:24 +0200 (Tue, 28 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   A /trunk/src/chrome/test/data/blacklist_samples
   A /trunk/src/chrome/test/data/blacklist_samples/annoying_ads.pbl
   A /trunk/src/chrome/test/data/blacklist_samples/block_flash.pbl
   A /trunk/src/chrome/test/data/blacklist_samples/combine3.pbr
   A /trunk/src/chrome/test/data/blacklist_samples/session_cookies.pbl
   M /trunk/src/chrome/tools/pbl_tool/pbl_tool.cc

Load Multiple Blacklists

Add the ability to load multiple text blacklists into the binary blacklist representation.

NOTE: Included Binary file means this change expects to fail on the trybots
in blacklist_io_test.cc:103. All other checks must pass.

BUG=16932
TEST=BlacklistIO*

Review URL: http://codereview.chromium.org/159199
------------------------------------------------------------------------
r21839 | thakis@chromium.org | 2009-07-28 16:50:01 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Remove unused code

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159493
------------------------------------------------------------------------
r21836 | amit@chromium.org | 2009-07-28 15:28:11 +0200 (Tue, 28 Jul 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/automation/automation_profile_impl.cc
   A /trunk/src/chrome/browser/automation/automation_profile_impl.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/cookies_table_model.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   A /trunk/src/net/base/cookie_options.h
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/cookie_policy_unittest.cc
   A /trunk/src/net/base/cookie_store.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Navigation and cookies for Automation

Give Automation better visibility and control over navigations. 
Also, make it possible for automation to implement a dummy cookie
store to go with dummy request serving over automation.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159189
------------------------------------------------------------------------
r21815 | thakis@chromium.org | 2009-07-28 05:12:31 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm

Redraw download item when its state changed

BUG=17859
TEST=Download a largish file (iTunes or XCode). The download item's state should update several times a second, not just on hover.

Review URL: http://codereview.chromium.org/160237
------------------------------------------------------------------------
r21804 | estade@chromium.org | 2009-07-28 04:32:25 +0200 (Tue, 28 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Workaround for GtkFileChooserButton bug: disable mouse wheel scrolling.

Also disable it for the cookie behavior combobox, because it fights with the scrolled window.

The GtkFileChooserButton spews the following 2 errors (and possibly others) when you scroll on it quickly:

Gtk-WARNING **: idle activate multiple times without clearing the folder object first.
Gtk: gtk_tree_model_get_iter: assertion `path != NULL' failed

This causes us to crash in debug, and causes undesirable console output in release. I verified that this is their bug and not ours by reproing in a simple program that just has a window with a GtkFileChooserButton in it.

BUG=17805

Review URL: http://codereview.chromium.org/159459
------------------------------------------------------------------------
r21794 | mattm@chromium.org | 2009-07-28 03:57:31 +0200 (Tue, 28 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   A /trunk/src/chrome/browser/shell_integration_win.cc (from /trunk/src/chrome/browser/shell_integration.cc:21737)
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/chrome.gyp

Fix running default browser check/setting in UI thread on Linux.

Rename shell_integration.cc to shell_integration_win.cc, so
shell_integration.cc can be used for cross-platform stuff.

Move DefaultBrowserWorker from GeneralPageView to ShellIntegration.

BUG=17179
Review URL: http://codereview.chromium.org/160218
------------------------------------------------------------------------
r21793 | glen@chromium.org | 2009-07-28 03:55:44 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.html

Make the NNTP always request a new theme CSS

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160240
------------------------------------------------------------------------
r21792 | willchan@chromium.org | 2009-07-28 03:46:32 +0200 (Tue, 28 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_linux.cc
   M /trunk/src/chrome/browser/importer/nss_decryptor_linux.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_mac.h
   M /trunk/src/chrome/browser/importer/nss_decryptor_win.h
   M /trunk/src/chrome/chrome.gyp

Linux: Fix NSSDecryptor to decrypt Firefox passwords using correct user database.
Note that we're deliberately leaving NSS user databases open until NSS shutdown since closing and reopening it does not work correctly (NSS bug).
Also, enable the firefox_importer_unittest.cc for linux.  Move out some tests to firefox_profile_unittest.cc.
Fix lock file deletion in the posix implementation of FirefoxProfileLock.
BUG=http://crbug.com/17490
TEST=Import bookmark and settings, verify that passwords are indeed imported.

Review URL: http://codereview.chromium.org/160077
------------------------------------------------------------------------
r21788 | glen@chromium.org | 2009-07-28 03:37:19 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Generate tab images on browser load (previously we were only doing it on start).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159470
------------------------------------------------------------------------
r21787 | mhm@chromium.org | 2009-07-28 03:31:55 +0200 (Tue, 28 Jul 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/language_order_table_model.cc (from /trunk/src/chrome/browser/views/options/languages_page_view.cc:21508)
   A /trunk/src/chrome/browser/language_order_table_model.h (from /trunk/src/chrome/browser/views/options/languages_page_view.cc:21508)
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/chrome.gyp

Refactor out language models for linux gtk views preparation

There are models and an language array that are needed for the linux gtk views afaik. So extracting the classes from the windows specific code into separate files would allow code reusabiliy.

BUG=13524
TEST=Windows Language Dialog functions properly.

Review URL: http://codereview.chromium.org/151138
------------------------------------------------------------------------
r21786 | mattm@chromium.org | 2009-07-28 03:28:31 +0200 (Tue, 28 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/fonts_page_gtk.h
   M /trunk/src/chrome/chrome.gyp

Gtk: Implement font selection options.

BUG=11507

Review URL: http://codereview.chromium.org/159458
------------------------------------------------------------------------
r21785 | meelapshah@chromium.org | 2009-07-28 03:22:25 +0200 (Tue, 28 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/notification_type.h

Make ThumbnailStore broadcast a notification when it has finished reading thumbnails from disk.
Make DOMUIThumbnailSource wait for this notification if ThumbnailStore isn't ready yet.
Also clean up some of the code.

Review URL: http://codereview.chromium.org/155911
------------------------------------------------------------------------
r21782 | agl@chromium.org | 2009-07-28 03:18:35 +0200 (Tue, 28 Jul 2009) | 12 lines
Changed paths:
   A /trunk/src/base/scoped_fd.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Linux: add internal core dump reporting.

In order to get a handle on a number of browser crashes, this patch
adds an options for Google internal folks to upload full core files
when the browser crashes. The core files are uploaded to an internal
IP address and will be available to other developers.

This is only enabled for Chrome branded builds and then, only if
--google-internal-crash-reporting is given on the command line.

http://codereview.chromium.org/160212

------------------------------------------------------------------------
r21781 | arv@google.com | 2009-07-28 03:15:35 +0200 (Tue, 28 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix issue where the width of the sections was not updated correctly.

BUG=17751

TEST=Make the window small so that the small layout is triggered. Then
resize the window to trigger normal mode. The right border of the tips
section should be visible.

Review URL: http://codereview.chromium.org/159466
------------------------------------------------------------------------
r21770 | aa@chromium.org | 2009-07-28 02:47:53 +0200 (Tue, 28 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   A /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc
   A /trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Pull a SandboxedExtensionUnpacker out of ExtensionsService.
Review URL: http://codereview.chromium.org/160145
------------------------------------------------------------------------
r21767 | estade@chromium.org | 2009-07-28 02:45:35 +0200 (Tue, 28 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_dnd_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_dnd_util.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Gtk: DnD extravaganza

- Correctly update drag status for drags over renderer. This makes things look quite a bit better.
- Rework the dnd utils so that we specify the drag targets in the order we prefer them (for destinations)
- Refactor code in bookmark bar so folder and toolbar drags share more code
- Allow bookmark bar to accept URI lists and plain text drags (for plain text we require the text to be a valid url)

BUG=17431

Review URL: http://codereview.chromium.org/159419
------------------------------------------------------------------------
r21759 | thakis@chromium.org | 2009-07-28 02:25:05 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/chrome.gyp

First stab at download item overflow. Also add the image to the left of "Show all downloads" to the shelf.

BUG=14672,14665
TEST=Download several items. They should now no longer overlap the "Open all downloads" link.

Review URL: http://codereview.chromium.org/159384
------------------------------------------------------------------------
r21758 | tc@google.com | 2009-07-28 02:18:22 +0200 (Tue, 28 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Add the shadow above the toolbar (below the tabstrip).

We put this in the browser window expose handler so the tabs in the
tab strip will draw over it.

BUG=15505

Review URL: http://codereview.chromium.org/160201

------------------------------------------------------------------------
r21750 | arv@google.com | 2009-07-28 02:00:14 +0200 (Tue, 28 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

NNTP: Make the window tooltip behave more like a real tooltip by
adding a hide delay and making sure we show the tooltip where the
mouse pointer is at the time of showing.

Also fix an issue where the theme css incorrectly made the tab and
window items look different than the download items.

BUG=16539

TEST=Download a file, close a tab, close a window and go to the new
tab page. There should be three links in the recent activities and
they should all have the same color and underline color. Hower over
the closed window entry and it should show a rich tooltip.

Review URL: http://codereview.chromium.org/159417
------------------------------------------------------------------------
r21741 | dumi@chromium.org | 2009-07-28 01:32:02 +0200 (Tue, 28 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Fixes a warning: 'this' in initializer list.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/159450
------------------------------------------------------------------------
r21736 | dumi@chromium.org | 2009-07-28 01:06:34 +0200 (Tue, 28 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/base/platform_file.h
   M /trunk/src/base/platform_file_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   A /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.cc
   A /trunk/src/chrome/browser/renderer_host/database_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/db_message_filter.cc
   A /trunk/src/chrome/common/db_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKit.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   M /trunk/src/webkit/api/src/WebKit.cpp
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webview_impl.cc

Adding HTML5 DB support to Chromium: Chromium changes

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/74001
------------------------------------------------------------------------
r21729 | jhawkins@chromium.org | 2009-07-28 00:48:34 +0200 (Tue, 28 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

gtk: Use the requested window bounds when determining the location of the source tab.  This is necessary because we move the hidden source tab during a drag, and gtk does not update the allocation of hidden widgets.

BUG=16918,17712
TEST=Extensive tab dragging.
Review URL: http://codereview.chromium.org/159436
------------------------------------------------------------------------
r21727 | willchan@chromium.org | 2009-07-28 00:45:00 +0200 (Tue, 28 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h

Fix LogTCPConnectedMetrics.  Add FieldTrials for late binding (enable for 50% of dev channel).

Review URL: http://codereview.chromium.org/159038
------------------------------------------------------------------------
r21721 | mpcomplete@chromium.org | 2009-07-28 00:16:11 +0200 (Tue, 28 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h

Don't create an ExtensionDOMUI for urls with invalid extension IDs.

This fixes a crash bug.

BUG=17546
TEST=Navigate to chrome-extension://baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/ with no
extensions installed.  Chrome should not crash.

Review URL: http://codereview.chromium.org/160199
------------------------------------------------------------------------
r21719 | phajdan.jr@chromium.org | 2009-07-28 00:09:40 +0200 (Tue, 28 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Make possible reloading extensions from the chrome://extensions/ page.

http://crbug.com/16459

Review URL: http://codereview.chromium.org/159323
------------------------------------------------------------------------
r21718 | estade@chromium.org | 2009-07-28 00:04:45 +0200 (Tue, 28 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc

Set window icon on manage search engines dialog.

Same for hung renderer dialog.

BUG=13000

Review URL: http://codereview.chromium.org/160147
------------------------------------------------------------------------
r21717 | estade@chromium.org | 2009-07-27 23:55:21 +0200 (Mon, 27 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

GTK: Make the info bubble (and bookmark bubble and first run bubble) bidi.

BUG=17631

Review URL: http://codereview.chromium.org/160131
------------------------------------------------------------------------
r21713 | aa@chromium.org | 2009-07-27 23:47:13 +0200 (Mon, 27 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h

Make the theme preview infobar default to installation, and 
only have a single button for undo.
Review URL: http://codereview.chromium.org/160200
------------------------------------------------------------------------
r21711 | jhawkins@chromium.org | 2009-07-27 23:24:21 +0200 (Mon, 27 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

gtk: Fix the positioning of the tabstrip drop arrow for RTL locales.

BUG=17695
TEST=Open the browser in a RTL locale.  Drag a link from the tab contents into the tabstrip.  The drop arrow should be positioned correctly.
Review URL: http://codereview.chromium.org/159394
------------------------------------------------------------------------
r21707 | avi@chromium.org | 2009-07-27 23:12:54 +0200 (Mon, 27 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Fix gradient drawing on the Mac. (Base coordinate system != window base coordinate system.)

BUG=http://crbug.com/17716
TEST=as in bug

Review URL: http://codereview.chromium.org/160194
------------------------------------------------------------------------
r21704 | erg@google.com | 2009-07-27 23:08:06 +0200 (Mon, 27 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK Themes: A gtkrc file can now override our choice of frame color by
specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme.

Also attempts to do a better job matching the frame color. Most window
managers (defined as metacity default theme and xfwm's default theme)
take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it
will be wrong a smaller percentage of the time then our current
behaviour.

http://crbug.com/16271 (dark theme bug)
http://crbug.com/13967 (theme color metabug)

Review URL: http://codereview.chromium.org/160188
------------------------------------------------------------------------
r21700 | jhawkins@chromium.org | 2009-07-27 22:54:23 +0200 (Mon, 27 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Coverity: Pass strings by reference.

CID=5146
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160154
------------------------------------------------------------------------
r21699 | jhawkins@chromium.org | 2009-07-27 22:54:11 +0200 (Mon, 27 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Coverity: Pass strings by reference.

CID=4139
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159352
------------------------------------------------------------------------
r21691 | phajdan.jr@chromium.org | 2009-07-27 22:41:20 +0200 (Mon, 27 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h

Removing unused forward declaration of StarredURLDatabase from bookmark_model.h.

Patch by Thiago Farina. Original review: http://codereview.chromium.org/160151

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/160185
------------------------------------------------------------------------
r21686 | rohitrao@chromium.org | 2009-07-27 22:25:59 +0200 (Mon, 27 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/FindBar.xib
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

Pretties up the FindBar on Mac.

BUG=http://crbug.com/14903
BUG=http://crbug.com/14904
BUG=http://crbug.com/14905
TEST=Findbar should function normally, as before.
Review URL: http://codereview.chromium.org/160144
------------------------------------------------------------------------
r21685 | brettw@chromium.org | 2009-07-27 22:15:40 +0200 (Mon, 27 Jul 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Re-landing r21673 without re-enabling the BrowserTest, which apparently is
still failing.

Make downloads not prevent tabs from closing. If a download creates a
cross-site transition (for example, if you click a link in Gmail that results
in a download in a new tab), that tab will be stuck and you can't close it or
the browser. This is the opposite problem with a similar cause as bug 16246. In
both cases we were using some secondary signal to tell us if we're closing for
a cross site transition or closing the tab, and that signal was wrong. In this
case, we were running the onunload handler, but because there was a pending
RenderViewHost, the RenderManager would think that the close was a cross-site
one, and not forward the close message to actually close the tab. This patch
adds a flag to the on unload handlers that indicates whether it's for a tab
closure or a cross-site transition, so we can do the right thing unambiguously
when the message returns. In this case I keep this information in the
RenderView in case we send multiple close requests, we'll close the tab if any
of them were for the entire tab, even if that particular one was dropped
because we don't want to have more than one in flight at once. BUG=17560
TEST=none.
Review URL: http://codereview.chromium.org/160122
Review URL: http://codereview.chromium.org/159426
------------------------------------------------------------------------
r21683 | robertshield@chromium.org | 2009-07-27 21:55:35 +0200 (Mon, 27 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Revert of r21673 - which caused browser_test failure in ChromeURLAfterDownload.

TBR=brettw
Review URL: http://codereview.chromium.org/160187
------------------------------------------------------------------------
r21678 | mpcomplete@chromium.org | 2009-07-27 21:18:41 +0200 (Mon, 27 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/in_process_browser_test.cc

Fix port disconnect so that it's refcounted.  This fixes a bug where a channel
would close if any one listener on the channel called "disconnect()".

BUG=16644
TEST=no

Review URL: http://codereview.chromium.org/155476
------------------------------------------------------------------------
r21675 | tc@google.com | 2009-07-27 21:04:07 +0200 (Mon, 27 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Avoid calls to gtk_widget_get_pointer during mouse move if
not necessary.  This is to work around janky scrolling behavior
that brad was seeing.  I can't repro, so he'll have to tell me if
this works for him

BUG=16786

Review URL: http://codereview.chromium.org/160179

------------------------------------------------------------------------
r21673 | brettw@chromium.org | 2009-07-27 21:00:05 +0200 (Mon, 27 Jul 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Make downloads not prevent tabs from closing.

If a download creates a cross-site transition (for example, if you click a
link in Gmail that results in a download in a new tab), that tab will be stuck
and you can't close it or the browser.

This is the opposite problem with a similar cause as bug 16246. In both cases
we were using some secondary signal to tell us if we're closing for a cross site
transition or closing the tab, and that signal was wrong.

In this case, we were running the onunload handler, but because there was a
pending RenderViewHost, the RenderManager would think that the close was a
cross-site one, and not forward the close message to actually close the tab.

This patch adds a flag to the on unload handlers that indicates whether it's
for a tab closure or a cross-site transition, so we can do the right thing
unambiguously when the message returns. In this case I keep this information in
the RenderView in case we send multiple close requests, we'll close the tab if
any of them were for the entire tab, even if that particular one was dropped
because we don't want to have more than one in flight at once.

BUG=17560
TEST=none.

Review URL: http://codereview.chromium.org/160122
------------------------------------------------------------------------
r21668 | phajdan.jr@chromium.org | 2009-07-27 20:46:33 +0200 (Mon, 27 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.h
   A /trunk/src/chrome/browser/automation/url_request_slow_http_job.cc
   A /trunk/src/chrome/browser/automation/url_request_slow_http_job.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Make AutomationProxyTest.NavigateToURLWithTimeout* tests not-flaky.

I used a mock url request job which is guaranteed to finish after the timeout the test uses.

TEST=none
http://crbug.com/16462

Review URL: http://codereview.chromium.org/155941
------------------------------------------------------------------------
r21664 | estade@chromium.org | 2009-07-27 20:18:41 +0200 (Mon, 27 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Implement delete key for the Remove action in the bookmark manager.

Although we will also need to implement certain other hotkeys such as Ctrl+C and so forth, I see no point in adding an accelerator group as we do not want the accelerators to work when the tree views don't have focus. Also we don't want the menu to show the accelerators.

Also, fix a bug where the organize menu could be stale. mdm pointed out that ctrl+clicking the selection could lead to an empty selection.

BUG=17393

Review URL: http://codereview.chromium.org/160137
------------------------------------------------------------------------
r21657 | estade@chromium.org | 2009-07-27 19:38:13 +0200 (Mon, 27 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Gtk: gtk_window_present when an already-showing browser window is showing and we want to show it again.

I think this will be very WM-specific on whether it works. It seems that a lot of WMs don't want to allow windows from groups that don't have focus to do this. For example: http://blogs.gnome.org/metacity/2007/12/24/stacking/

BUG=17767

Review URL: http://codereview.chromium.org/160149
------------------------------------------------------------------------
r21648 | avi@chromium.org | 2009-07-27 18:34:17 +0200 (Mon, 27 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/ClearBrowsingData.xib
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view.h
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Give crashed tabs the crashed tab icon on the Mac.

BUG=none
TEST=crash a page and see if the icon shows up (animated)

Review URL: http://codereview.chromium.org/160113
------------------------------------------------------------------------
r21639 | rohitrao@chromium.org | 2009-07-27 17:37:25 +0200 (Mon, 27 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   A /trunk/src/chrome/browser/cocoa/history_menu_bridge.h
   A /trunk/src/chrome/browser/cocoa/history_menu_bridge.mm
   A /trunk/src/chrome/browser/cocoa/history_menu_bridge_unittest.mm
   A /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.h
   A /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/history_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

First cut at Mac history menu.

* The menu has two sections: most visited and recently closed.
* Creates a HistoryMenuBridge that observes different data sources and stores
  results for use in the menu.
* Creates a HistoryMenuController to respond to Cocoa IBActions from the menu.

BUG=14933
TEST=History menu in mac should populate with most visited and recently closed
sites.
RELEASE_NOTES=Add initial implementation of the Mac history menu.

Patch by Robert Sesek.
------------------------------------------------------------------------
r21638 | erikkay@chromium.org | 2009-07-27 17:12:09 +0200 (Mon, 27 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/2/manifest.json

reenable a disabled part of a unit test

BUG=15363
TEST=ExtensionsService.LoadAllExtensionsFromDirectorySuccess

Review URL: http://codereview.chromium.org/159388
------------------------------------------------------------------------
r21637 | yurys@google.com | 2009-07-27 11:17:23 +0200 (Mon, 27 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inject.js
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webkit_resources.grd

DevTools: split console evaluation into two steps: actual evaluation and result
wrapping. When second step is executed debugger_agent_manager will autocontinue
on break. We assume that second step doesn't call user scripts.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21635
Review URL: http://codereview.chromium.org/159395
------------------------------------------------------------------------
r21636 | yurys@google.com | 2009-07-27 10:51:20 +0200 (Mon, 27 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inject.js
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h

Reverting 21635.
Review URL: http://codereview.chromium.org/159399
------------------------------------------------------------------------
r21635 | yurys@google.com | 2009-07-27 10:24:46 +0200 (Mon, 27 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inject.js
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h

DevTools: split console evaluation into two steps: actual evaluation and result
wrapping. When second step is executed debugger_agent_manager will autocontinue
on break. We assume that second step doesn't call user scripts.

Review URL: http://codereview.chromium.org/159395
------------------------------------------------------------------------
r21634 | thakis@chromium.org | 2009-07-27 05:34:16 +0200 (Mon, 27 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm

Fix location bar display.

BUG=17667
TEST=see bug

Review URL: http://codereview.chromium.org/160142
------------------------------------------------------------------------
r21633 | arv@google.com | 2009-07-27 04:16:33 +0200 (Mon, 27 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/new_new_tab.html

NNTP: Change the lower right section to say "What will we put here?"

TBR=glen@chromium.org

BUG=None

Test=None

Review URL: http://codereview.chromium.org/159393
------------------------------------------------------------------------
r21632 | erikkay@chromium.org | 2009-07-27 01:29:47 +0200 (Mon, 27 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

add test to verify mole data being read

TBR=mpcomplete

Review URL: http://codereview.chromium.org/160148
------------------------------------------------------------------------
r21631 | ericroman@google.com | 2009-07-26 23:12:20 +0200 (Sun, 26 Jul 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_resolver.h
   M /trunk/src/net/proxy/proxy_resolver_mac.cc
   M /trunk/src/net/proxy/proxy_resolver_mac.h
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.h
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   A /trunk/src/net/proxy/single_threaded_proxy_resolver.cc (from /trunk/src/net/proxy/proxy_service.cc:20322)
   A /trunk/src/net/proxy/single_threaded_proxy_resolver.h (from /trunk/src/net/proxy/proxy_service.h:20322)
   A /trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc

Remove the concept of threading from ProxyService, and move it into the ProxyResolver dependency.

ProxyResolver may now complete requests asynchronously, and is defined to handle multiple requests.

The code from ProxyService that queued requests onto the single PAC thread has moved into SingleThreadedProxyResolver. 

This refactor lays the groundwork for:

(1) http://crbug.com/11746 -- Run PAC proxy resolving out of process.
(Can inject an IPC bridge implementation of ProxyResolver)


(2) http://crbug.com/11079 -- Run PAC proxy resolving on multiple threads.
(Can implement a MultithreadedProxyResolver type class; still complications around v8 threadsafety though).

BUG=http://crbug.com/11746, http://crbug.com/11079
TEST=existing unit-tests.

Review URL: http://codereview.chromium.org/149525
------------------------------------------------------------------------
r21628 | aa@chromium.org | 2009-07-26 10:36:12 +0200 (Sun, 26 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix exception in DownloadManager if the download has no extension.

TBR=erikkay
Review URL: http://codereview.chromium.org/159392
------------------------------------------------------------------------
r21627 | aa@chromium.org | 2009-07-26 09:25:32 +0200 (Sun, 26 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Modify detection of Chrome extensions in download manager. It
turns out many servers send the no-sniff option, including the
one we use for our sample extensions.

So we can't rely on mime types to detect Chrome extensions, at
least until we have some place to put our samples that doesn't
have this problem.

TBR=erikkay
Review URL: http://codereview.chromium.org/159391
------------------------------------------------------------------------
r21626 | aa@chromium.org | 2009-07-26 08:16:12 +0200 (Sun, 26 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   A /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp

Try again to commit r21622: Add infobar preview for themes,
remove --enable-extension requirement.

Review URL: http://codereview.chromium.org/159390
------------------------------------------------------------------------
r21625 | aa@chromium.org | 2009-07-26 06:09:23 +0200 (Sun, 26 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   D /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc
   D /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp

Revert revisions 21622-21624.


------------------------------------------------------------------------
r21624 | aa@chromium.org | 2009-07-26 05:58:38 +0200 (Sun, 26 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc

Fix broken tree.

------------------------------------------------------------------------
r21623 | aa@chromium.org | 2009-07-26 05:54:27 +0200 (Sun, 26 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.cc (from /trunk/src/chrome/browser/views/extensions/theme_preview_infobar_delegate.cc:21622)
   A /trunk/src/chrome/browser/extensions/theme_preview_infobar_delegate.h (from /trunk/src/chrome/browser/views/extensions/theme_preview_infobar_delegate.h:21622)
   D /trunk/src/chrome/browser/views/extensions/theme_preview_infobar_delegate.cc
   D /trunk/src/chrome/browser/views/extensions/theme_preview_infobar_delegate.h

Fix broken tree on mac/linux.

Review URL: http://codereview.chromium.org/159389
------------------------------------------------------------------------
r21622 | aa@chromium.org | 2009-07-26 05:41:47 +0200 (Sun, 26 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   A /trunk/src/chrome/browser/views/extensions/theme_preview_infobar_delegate.cc
   A /trunk/src/chrome/browser/views/extensions/theme_preview_infobar_delegate.h
   M /trunk/src/chrome/chrome.gyp

Add infobar preview for themes, remove --enable-extension
requirement.
Review URL: http://codereview.chromium.org/160141
------------------------------------------------------------------------
r21621 | erikkay@chromium.org | 2009-07-26 02:11:42 +0200 (Sun, 26 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/extensions/extension_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json

add mole info to toolstrip definition and enable moles

Review URL: http://codereview.chromium.org/159202
------------------------------------------------------------------------
r21620 | aa@chromium.org | 2009-07-25 23:17:34 +0200 (Sat, 25 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Make the download manager display a scary file warning if an
extensions is not from the gallery.
Review URL: http://codereview.chromium.org/159379
------------------------------------------------------------------------
r21619 | erikkay@chromium.org | 2009-07-25 21:38:21 +0200 (Sat, 25 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

* notify theme loading with --load-extension
* fix crasher in theme parsing with no images

Review URL: http://codereview.chromium.org/160124
------------------------------------------------------------------------
r21615 | arv@google.com | 2009-07-25 08:54:43 +0200 (Sat, 25 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Disable the tips service by default.

Update the UI to not say tips or recommendations.

BUG=None

TEST=Starting chrome should not show any tips byt default


Review URL: http://codereview.chromium.org/160138
------------------------------------------------------------------------
r21612 | aa@chromium.org | 2009-07-25 05:15:58 +0200 (Sat, 25 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/mime_sniffer_unittest.cc

Implement mimetype sniffing for extensions.

abarth: can you review the changes to mime_sniffer.cc?
paul: everything else?

BUG=13296
TEST=Added unit tests
Review URL: http://codereview.chromium.org/159345
------------------------------------------------------------------------
r21608 | arv@google.com | 2009-07-25 03:37:00 +0200 (Sat, 25 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.js

, INNTP: Adds 2 hard coded thumbnails.

This code needs to be rewritten after beta to handle localized content.

BUG=15079

TEST=Start chrome with a new profile. There should be 2 thumbnails on
the new tab page.

Review URL: http://codereview.chromium.org/160126
------------------------------------------------------------------------
r21604 | glen@chromium.org | 2009-07-25 03:19:10 +0200 (Sat, 25 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Stop drawing the status bubble text highlight because it sucks for themes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159292
------------------------------------------------------------------------
r21603 | aa@chromium.org | 2009-07-25 03:06:42 +0200 (Sat, 25 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Use referrer_url instead of download url to decide whether a
theme installation can happens sans-prompt.
Review URL: http://codereview.chromium.org/160087
------------------------------------------------------------------------
r21600 | estade@chromium.org | 2009-07-25 02:53:58 +0200 (Sat, 25 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Make some default file dialog titles for linux.

Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar.

BUG=16890
TEST=should be obvious

Review URL: http://codereview.chromium.org/159326
------------------------------------------------------------------------
r21599 | ben@chromium.org | 2009-07-25 02:46:46 +0200 (Sat, 25 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Implement Window modality in TOOLKIT_VIEWS, and allow windows to be centered over their modal parent or the screen if there is no modal parent. This means child windows don't open at 0,0 anymore.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159335
------------------------------------------------------------------------
r21598 | ajwong@chromium.org | 2009-07-25 02:46:46 +0200 (Sat, 25 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Add in UMA logging for context menu playback controls.

BUG=15686
TEST=none

Review URL: http://codereview.chromium.org/159371
------------------------------------------------------------------------
r21597 | mhm@chromium.org | 2009-07-25 02:27:18 +0200 (Sat, 25 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

Reverting 21588 to make Linux toolkit dbg happy.
TBR: thiago
Review URL: http://codereview.chromium.org/159378
------------------------------------------------------------------------
r21595 | brg@chromium.com | 2009-07-25 02:24:57 +0200 (Sat, 25 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/app/win_util.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/chrome/browser/browser.cc

Partial fix to 7028 - Pinning in Win7.A complete fix will require Gears to set the application id as a property on the shortcut  As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar.  However, they can not be pinned from the main application window nor can they be pinned from the shortcut.  The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button.  Instead in the latter case a web appliation will form a new group.

Bug=7028
Test=None.  (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly)
Review URL: http://codereview.chromium.org/159336
------------------------------------------------------------------------
r21594 | mhm@chromium.org | 2009-07-25 02:24:31 +0200 (Sat, 25 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h

Reverting 21593.
TBR=thiago
Review URL: http://codereview.chromium.org/159377
------------------------------------------------------------------------
r21593 | mhm@chromium.org | 2009-07-25 02:10:23 +0200 (Sat, 25 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h

Fix Linux Toolkit dbg bustage.

BUG=None
TEST=None
TBR=nsylvain
Review URL: http://codereview.chromium.org/159375
------------------------------------------------------------------------
r21588 | mhm@chromium.org | 2009-07-24 23:56:13 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h

Porting POINT to gfx::Point for automation provider

BUG=None
TEST=None

Patch by tfarina
Original Review: http://codereview.chromium.org/155888
Review URL: http://codereview.chromium.org/160088
------------------------------------------------------------------------
r21586 | jshin@chromium.org | 2009-07-24 23:51:33 +0200 (Fri, 24 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc

Move setlocale() to zygote_main_linux to make sure that it's called
before the sandbox is triggered.

BUG=16860 (http://crbug.com/16860 )
TEST=Run Chrome with LC_ALL=en_US.UTF-8. 1. Make sure that you don't see
any warning about 'setlocale failing'. 2. Upload a file whose name
contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The
filename field in a form should be populated with the name (rather than empty).

Review URL: http://codereview.chromium.org/160112
------------------------------------------------------------------------
r21582 | asargent@chromium.org | 2009-07-24 23:39:23 +0200 (Fri, 24 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Fix 2 bugs in extensions autoupdate request parameters.

-Separator that should be between id and version parameters was at the end of version
-Missing the "uc" parameter which the gallery server code was expecting as indication
 of an update check

BUG=http://crbug.com/17469
TEST=extensions auto-update should work

Review URL: http://codereview.chromium.org/159224
------------------------------------------------------------------------
r21581 | pinkerton@chromium.org | 2009-07-24 23:26:02 +0200 (Fri, 24 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Implement feature where tabs don't resize when using the close box until the mouse leaves the tab strip. Also turn off zordering fix from before, it regressed things.
BUG=14912
TEST=creating a bunch of tabs and making sure that after you close them and mouse away, they return to the correct sizes. Creating new tabs after that should all be the correct size as well.
Review URL: http://codereview.chromium.org/160116
------------------------------------------------------------------------
r21579 | tc@google.com | 2009-07-24 23:20:55 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

fix toolkit_views compile due to AutocompleteEditViewGtk change.

TBR=estade

Review URL: http://codereview.chromium.org/159367

------------------------------------------------------------------------
r21578 | tc@google.com | 2009-07-24 23:08:43 +0200 (Fri, 24 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Implement location only display mode (used by popup windows).

This matches the pixel sizes on Windows.  The location bar is
a couple pixels shorter and the font is a little smaller.

BUG=17580

Review URL: http://codereview.chromium.org/159303

------------------------------------------------------------------------
r21576 | estade@chromium.org | 2009-07-24 23:03:15 +0200 (Fri, 24 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

GTK: Don't close info bubbles based on which toplevel is active.

This fixes the behavior for active toplevel windows and focus follows mouse that moving the mouse onto and then off of the bookmark bubble will close it.

This also fixes that we might paint the tab strip active while the system title bar is painted inactive. Unfortunately we can't stop the browser window from painting inactive when using the system frame.

This reverts us to the old bad behavior that you could drag around the browser window and the bookmark bubble will stay in place. It also reverts us to allowing the info bubble to being able to persist even if it doesnt have focus. This doesn't match windows, but I'm not convinced windows is all that great.

BUG=none
TEST=see above

Review URL: http://codereview.chromium.org/159288
------------------------------------------------------------------------
r21575 | estade@chromium.org | 2009-07-24 23:03:05 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

GTK: Let custom draw buttons specify their stock size as well as their stock image.

I tried to also make the tab strip use stock gtk close button but that is gonna require a lot more work to get layout right so leave it alone for now.

BUG=none
TEST=close button on download shelf is sanely sized

Review URL: http://codereview.chromium.org/159325
------------------------------------------------------------------------
r21574 | jhawkins@chromium.org | 2009-07-24 23:02:08 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Coverity: Pass FilePaths and strings by reference.

CID=2716,4565,5054
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160120
------------------------------------------------------------------------
r21573 | jcampan@chromium.org | 2009-07-24 22:51:35 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win.cc

A crasher from the field indicates that the focus manager can be NULL when the FindBarWin is instanciated.
It is not clear how this can happen.

BUG=17056
TEST=None
Review URL: http://codereview.chromium.org/161001
------------------------------------------------------------------------
r21571 | arv@google.com | 2009-07-24 22:48:57 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Change the background color of the NNTP lower sections.

BUG=None

TEST=The background color of the lower sections on the NNTP should be light blue.


Review URL: http://codereview.chromium.org/159350
------------------------------------------------------------------------
r21567 | jhawkins@chromium.org | 2009-07-24 22:38:59 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h

Coverity: Pass FilePaths by reference.

CID=2696
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159353
------------------------------------------------------------------------
r21566 | jhawkins@chromium.org | 2009-07-24 22:38:19 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h

Coverity: Pass strings by reference.

CID=2714,2715
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159351
------------------------------------------------------------------------
r21555 | tc@google.com | 2009-07-24 20:52:42 +0200 (Fri, 24 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix a bug where an ongoing find operation would re-appear even
though we already changed the find text.

On Linux, we would continue doing a find operation.  On Windows,
the find operation would stop, but the find box would not be
cleared.

TEST=Go to a long page (like the html 5 spec).  Do a find for a very
  common string (e.g., any single letter).  Press backspace to clear
  the find box while results are still populating.  The find box
  should be cleared and the find stopped.

Review URL: http://codereview.chromium.org/159321

------------------------------------------------------------------------
r21547 | jhawkins@chromium.org | 2009-07-24 19:50:20 +0200 (Fri, 24 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix the win build.  path is being modified and returned, so it can't be a const ref.

TBR=finnur
------------------------------------------------------------------------
r21545 | glen@chromium.org | 2009-07-24 19:43:03 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix frame overlay display in incognito mode, make location bar background follow theme tinting.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159340
------------------------------------------------------------------------
r21543 | aa@chromium.org | 2009-07-24 19:41:39 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

More (temporary) cleanup for theme installation:

- Modify the gallery URL to only allow SSL.

- Remove the special case that allowed theme installation without --enable-extension. Now that we have the gallery special case this is not necessary anymore.

- Modify the dialog language to be a little less lame.
Review URL: http://codereview.chromium.org/159301
------------------------------------------------------------------------
r21542 | jhawkins@chromium.org | 2009-07-24 19:39:34 +0200 (Fri, 24 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

gtk: Theme the tab close button.

BUG=none
TEST=Open a browser window.  The close button should be visible.  Apply a theme with a colored close button.  The close button color should match the theme.
Review URL: http://codereview.chromium.org/159338
------------------------------------------------------------------------
r21541 | jhawkins@chromium.org | 2009-07-24 19:39:10 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater.h
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Coverity: Pass strings and GURLs by reference.

CID=5051,5052,5053
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159343
------------------------------------------------------------------------
r21540 | jhawkins@chromium.org | 2009-07-24 19:38:59 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.h
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   M /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.h

Coverity: Pass strings by reference.

CID=4459,4563,4564,4566,4567,4569,4570,4571,4803
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159342
------------------------------------------------------------------------
r21539 | glen@chromium.org | 2009-07-24 19:24:43 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Some fixes to make NNTP themes work again.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160102
------------------------------------------------------------------------
r21538 | glen@chromium.org | 2009-07-24 19:16:21 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Stop using strings for NTP logo inversion

BUG=14578
TEST=none

Review URL: http://codereview.chromium.org/160105
------------------------------------------------------------------------
r21537 | evan@chromium.org | 2009-07-24 19:06:06 +0200 (Fri, 24 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

linux: swap buttons on first run dialog

Cancel goes on the left.

Review URL: http://codereview.chromium.org/160103
------------------------------------------------------------------------
r21536 | idanan@chromium.org | 2009-07-24 19:00:15 +0200 (Fri, 24 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h

Return Error Status Upon Blocking Requests

Blocked requests now return an error status so that the Chrome throbber does
not spin indefinitely when blocking URL requests.

This code shall be replaced with resource substitution next but gives a better
experience until then. Same goes for the added type-based interception.

TEST=none
BUG=16932

Review URL: http://codereview.chromium.org/159214
------------------------------------------------------------------------
r21535 | erg@google.com | 2009-07-24 18:54:46 +0200 (Fri, 24 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

GTK Themes: Theme the bookmark bubble. (And first run bubble).

http://crbug.com/16783

Review URL: http://codereview.chromium.org/160025
------------------------------------------------------------------------
r21534 | glen@chromium.org | 2009-07-24 18:44:40 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Layout was entirely the wrong place to be updating the button - it gets called too early. This moves it near the other user of the color values.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160094
------------------------------------------------------------------------
r21532 | pinkerton@chromium.org | 2009-07-24 18:12:18 +0200 (Fri, 24 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Live resize of tabs as the window resizes.
BUG=13713
TEST=dragging tabs still animates, new tabs still animate, resizing window live-resizes tabs.
Review URL: http://codereview.chromium.org/159346
------------------------------------------------------------------------
r21531 | brettw@chromium.org | 2009-07-24 17:57:39 +0200 (Fri, 24 Jul 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Fix a race condition where rapid back/forward clicks could close a tab

This can be triggered when you're on the new tab page, going to *two* other
sites, then rapidly hitting back and forward randomly. If a cross-site
transition was canceled before the original page responds with an "OK to close
me" message, it will mistakenly categorize the close as not just for the
RenderView (correspondong to one side of the cross-site transition) but for the
entire tab.

This change adds an explicit parameter on the messages indicating whether it's
for interstials or for the tab so we don't have to rely on the request still
being active.

This also adds the "requesting process + route" in addition to the
"new process + request" so we can be more clear about sending the messages to
the correct place. The previous patch conbimed these in a confusing way.

BUG=16246
TEST=none
Review URL: http://codereview.chromium.org/159255
------------------------------------------------------------------------
r21529 | yurys@google.com | 2009-07-24 17:00:26 +0200 (Fri, 24 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inject.js
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h

Reverting 21525.
Review URL: http://codereview.chromium.org/160100
------------------------------------------------------------------------
r21527 | deanm@chromium.org | 2009-07-24 15:55:43 +0200 (Fri, 24 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Hide ia32 asm when not building for ARCH_CPU_X86_FAMILY

r21097, 'Linux sandbox: plumb timezone calls through the sandbox' adds some
ia32 assembly by the way of a define.  This is bad for building for ARM.

Patch by Joel Stanley.

Review URL: http://codereview.chromium.org/160097

------------------------------------------------------------------------
r21526 | avi@chromium.org | 2009-07-24 15:15:13 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

When no theme is installed, don't attempt to tint buttons.

BUG=http://crbug.com/17511
TEST=all toolbar buttons should be black

Review URL: http://codereview.chromium.org/160032
------------------------------------------------------------------------
r21525 | yurys@google.com | 2009-07-24 15:10:26 +0200 (Fri, 24 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.cc
   M /trunk/src/webkit/glue/devtools/debugger_agent_manager.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inject.js
   M /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h

DevTools: split console evaluation into two steps: actual evaluation and result wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts.
Review URL: http://codereview.chromium.org/160012
------------------------------------------------------------------------
r21522 | hbono@chromium.org | 2009-07-24 12:24:39 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/jumplist.cc
   A /trunk/src/chrome/browser/jumplist.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Integrates a custom JumpList of Windows 7 into Chromium.
This change adds an option "--enable-custom-jumplist" that uses the ICustomDestinationList interface to add "Most Visited" pages, "Recently Closed" pages, and "Tasks" to the JumpList of Chromium.
This change registers the CustomJumpList class into an observer of TabRestoreService so it can update the JumpList when a user adds/removes a tab.
This change stores icon files used by a custom JumpList under "$(User Data Dir)/JumpListIcons" so Taskbar can show JumpList icons even when Chromium is not running.

BUG=8037
TEST=Right-click the taskbar icon of Chromium on Windows 7.
Review URL: http://codereview.chromium.org/56175
------------------------------------------------------------------------
r21519 | glen@chromium.org | 2009-07-24 09:33:56 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/common/extensions/extension.cc

Let theme values that previous had to be real be specified as ints.

Also bonus update to background_tab_text naming.

BUG=16892
TEST=Create and install a theme with integer values for ntp_section opacity or tint values.

Review URL: http://codereview.chromium.org/160093
------------------------------------------------------------------------
r21518 | glen@chromium.org | 2009-07-24 09:32:38 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/views/controls/button/text_button.cc

Make the bookmark buttons follow theme changes correctly.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160092
------------------------------------------------------------------------
r21510 | glen@chromium.org | 2009-07-24 06:27:39 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Add link to themes gallery.

BUG=16381
TEST=Go to second page of options, verify that the 'Get themes' button opens a new tab and takes you to the themes gallery.

Review URL: http://codereview.chromium.org/160081
------------------------------------------------------------------------
r21509 | glen@chromium.org | 2009-07-24 06:25:13 +0200 (Fri, 24 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/theme/chromium/product_logo.png
   A /trunk/src/chrome/app/theme/chromium/product_logo_white.png
   M /trunk/src/chrome/app/theme/ntp_close.png
   M /trunk/src/chrome/app/theme/ntp_close_h.png
   M /trunk/src/chrome/app/theme/ntp_close_p.png
   M /trunk/src/chrome/app/theme/ntp_list_off.png
   M /trunk/src/chrome/app/theme/ntp_list_off_h.png
   M /trunk/src/chrome/app/theme/ntp_list_off_p.png
   M /trunk/src/chrome/app/theme/ntp_list_on.png
   M /trunk/src/chrome/app/theme/ntp_list_on_h.png
   M /trunk/src/chrome/app/theme/ntp_list_on_p.png
   A /trunk/src/chrome/app/theme/ntp_menu_mask.png
   M /trunk/src/chrome/app/theme/ntp_option.png
   M /trunk/src/chrome/app/theme/ntp_option_h.png
   M /trunk/src/chrome/app/theme/ntp_option_p.png
   M /trunk/src/chrome/app/theme/ntp_pin_off.png
   M /trunk/src/chrome/app/theme/ntp_pin_off_h.png
   M /trunk/src/chrome/app/theme/ntp_pin_off_p.png
   M /trunk/src/chrome/app/theme/ntp_pin_on.png
   M /trunk/src/chrome/app/theme/ntp_pin_on_h.png
   M /trunk/src/chrome/app/theme/ntp_pin_on_p.png
   M /trunk/src/chrome/app/theme/ntp_thumb_off.png
   M /trunk/src/chrome/app/theme/ntp_thumb_off_h.png
   M /trunk/src/chrome/app/theme/ntp_thumb_off_p.png
   M /trunk/src/chrome/app/theme/ntp_thumb_on.png
   M /trunk/src/chrome/app/theme/ntp_thumb_on_h.png
   M /trunk/src/chrome/app/theme/ntp_thumb_on_p.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_tab_theme.css

Fix a bunch of bugs related to NNTP theming.

Basically: 
- Add NNTP Theming

BrowserThemeProvider:
- Add NNTP logo inversion capability
- Only allow a set of images to be themed.
- Tint incognito windows correctly.
(Sorry for the feature-mush)

BUG=17379,14578,17593
TEST=Make sure the NNTP is themed correctly.

Review URL: http://codereview.chromium.org/159305
------------------------------------------------------------------------
r21507 | glen@chromium.org | 2009-07-24 05:45:55 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Make the NNTP listen for the correct theme changed notification.

BUG=17565
TEST=Install a theme, reset the theme, verify that the NNTP changes correctly in both cases.

Review URL: http://codereview.chromium.org/160027
------------------------------------------------------------------------
r21506 | thakis@chromium.org | 2009-07-24 05:10:27 +0200 (Fri, 24 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

When closing the download shelf, hide the buttons of the dangerous download
warning. Also fix the shelf closing animation.

BUG=13632
TEST=Download an exe (e.g. limewire from downloads.com), so that a "dangerous
download" message appears on the shelf. Then close the shelf. The "Yes" and "No"
buttons should be hidden, and the whole download shelf should slide down with
all items on it in place.

Original review url: http://codereview.chromium.org/159261

------------------------------------------------------------------------
r21505 | glen@chromium.org | 2009-07-24 05:03:03 +0200 (Fri, 24 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/theme/tab_close.png
   A /trunk/src/chrome/app/theme/tab_close_mask.png (from /trunk/src/chrome/app/theme/tab_close_mask.png:21488)
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Recommit of r21474. Original description:

"""
Make the tab close button color match the tab text.

BUG=17378
TEST=Install themes with different tab text colors and verify that the tab close button changes color appropriately.

Review URL: http://codereview.chromium.org/155882
"""

Changes since then include removing a NOTREACHED and changing that method so that a caller can detect whether a ThemeProvider is available.

------------------------------------------------------------------------
r21504 | agl@chromium.org | 2009-07-24 04:28:58 +0200 (Fri, 24 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html

Remove mention that we don't support different types of font rendering from the splash page.

------------------------------------------------------------------------
r21503 | rafaelw@chromium.org | 2009-07-24 04:14:56 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/extensions/api/extension_api.json
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Push bookmarks.remove/removeAll polymorphism into c++. fix bookmarks id schema issues (http://code.google.com/p/chromium/issues/detail?id=17562 failed to update schema types from int to string).

R=erikkay
BUG=17417

Review URL: http://codereview.chromium.org/160064
------------------------------------------------------------------------
r21495 | jorlow@chromium.org | 2009-07-24 03:22:51 +0200 (Fri, 24 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   A /trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc
   A /trunk/src/chrome/renderer/renderer_webstoragearea_impl.h
   A /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.cc
   A /trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   A /trunk/src/webkit/api/src/StorageAreaProxy.cpp
   A /trunk/src/webkit/api/src/StorageAreaProxy.h
   M /trunk/src/webkit/api/src/StorageNamespaceProxy.cpp
   M /trunk/src/webkit/api/src/StorageNamespaceProxy.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc
   M /trunk/src/webkit/webkit.gyp

The final CL for plumbing DOM Storage.

Add webKitClient plumbing for getting/creating storage namespaces.  Add a chromium implementation for WebStorageArea and WebStorageNamespace which communicates via IPC with the dom_storage_dispatcher_host in the browser process.  Flesh out the StorageAreaProxy and StorageNamespaceProxy to use the aforementioned implementations.

The WebStorageArea implementation includes decently aggressive caching optimizations.  There's still a lot of work to do, though.

BUG=4360
TEST=none

Review URL: http://codereview.chromium.org/147248
------------------------------------------------------------------------
r21491 | glen@chromium.org | 2009-07-24 02:44:22 +0200 (Fri, 24 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Fix newline issues in tab_renderer.h

------------------------------------------------------------------------
r21489 | glen@chromium.org | 2009-07-24 02:34:38 +0200 (Fri, 24 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/theme/tab_close.png
   D /trunk/src/chrome/app/theme/tab_close_mask.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Revert 21474

TBR=joshia
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160074
------------------------------------------------------------------------
r21483 | mpcomplete@chromium.org | 2009-07-24 02:04:33 +0200 (Fri, 24 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   D /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/background.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/toolstrip.html

Another try at enabling the content script messaging test.

Also fixes some issues that that test exposes.

My previous attempt (http://src.chromium.org/viewvc/chrome?view=rev&revision=21324) was reverted.

TEST=no
BUG=no

Review URL: http://codereview.chromium.org/160048
------------------------------------------------------------------------
r21481 | estade@chromium.org | 2009-07-24 02:03:54 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/base/mime_util_linux.cc
   M /trunk/src/chrome/browser/icon_loader_linux.cc

Enable SVG icons for linux.

get rid of kEnableSVG

BUG=12272
TEST=I made it load an svg for the download shelf and it worked. SVGZ did not work.

Review URL: http://codereview.chromium.org/159247
------------------------------------------------------------------------
r21480 | arv@google.com | 2009-07-24 01:58:17 +0200 (Fri, 24 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Adds the first run banner.

First run is determined by checking if there are no thumbnails. The check for no thumbnails is done on the backend since I need to add code to add some pre populated thumbnails and therefore the most visited pages will not be empty on the client. There is one edge case where the banner can show up again and that is if the user blacklists all his thumbnails and restarts chrome.

Also, updates the look of the fillers to match the latest mocks.

BUG=15079

TEST=Start with a new empty profile. You should see the blue first run banner. Then navigate to some link and come back the NTP. The banner should not be shown again. Also, test that this did not break the yellow notification banner shown when a thumbnail is removed.

Review URL: http://codereview.chromium.org/159304
------------------------------------------------------------------------
r21479 | jrg@chromium.org | 2009-07-24 01:56:19 +0200 (Fri, 24 Jul 2009) | 28 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/chrome.gyp

Added menus for bookmark bar folders.  This is NOT based on the Cole
prototype; it is an attempt to get something functional in the short
term, and have a visual baseline before doing something new.

Added folder icons for bookmark bar folder buttons.  Added an "off the
side" button/menu for bookmark buttons which don't fit on the bar.
Updated "Add page..." item to allow creating bookmarks in the folders
(if selected over a folder button).

BUG=http://crbug.com/8381

TEST=Here we go:
1) Make sure bookmark bar folders have the "folder" icon.
2) Right click on a folder --> Add Page, and add a bookmark.
   Make sure bookmark is now in the folder, not at the top level.
3) (Oh, you just implicitly verified you can open bookmark folders!)
4) Add 5 bookmarks then shrink the window thinner so all bookmark
  buttons don't fit.  Make sure "off the right" button gets enabled
  (on right side of bar) and shows bookmarks in a pop-up menu (when
  clicked) that don't completely fit on the bar.
5) Make it super-wide so the all fit and make sure "off the right"
  button is disabled.
6) Add a bunch of bookmarks to a folder; make sure they all work.
7) Add nested folders (by editing the bookmark pref file and restarting
   Chrome) and make sure bookmark folder buttons have nested/cascading
   menus.

Review URL: http://codereview.chromium.org/159286
------------------------------------------------------------------------
r21478 | evan@chromium.org | 2009-07-24 01:54:59 +0200 (Fri, 24 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

linux: obey window positioning information when bounds are overridden

Normally we want to let windows position themselves, but in some cases
(like dropping a tab) we really do want to drop the window where we
dropped.

BUG=15404
TEST=Drag off a tab and drop it.  It should drop where you released it.

Review URL: http://codereview.chromium.org/159316
------------------------------------------------------------------------
r21477 | glen@chromium.org | 2009-07-24 01:45:41 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Fix linux/mac build errors.

TBR=jrg
BUG=none
TEST=none

------------------------------------------------------------------------
r21476 | klink@chromium.org | 2009-07-24 01:43:25 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/accessibility/accessibility_types.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/controls/button/menu_button.cc

Adds MSAA information to various (previously uncovered) bits of the UI, including Bookmark and Extensions infobars. This is to moving towards completing the hierarchy for the benefit of full screen reader support.

BUG=None.
Test=None.

Review URL: http://codereview.chromium.org/155446
------------------------------------------------------------------------
r21474 | glen@chromium.org | 2009-07-24 01:34:31 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/tab_close.png
   A /trunk/src/chrome/app/theme/tab_close_mask.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Make the tab close button color match the tab text.

BUG=17378
TEST=Install themes with different tab text colors and verify that the tab close button changes color appropriately.

Review URL: http://codereview.chromium.org/155882
------------------------------------------------------------------------
r21472 | meelapshah@chromium.org | 2009-07-24 01:25:15 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Fix memory leak in VisitSegmentDatabase::QuerySegmentUsage and HistoryBackend::QueryTopURLsAndRedirects.

BUG=16104
TEST=sh tools/valgrind/chrome_test.sh -t ui --gtest_filter=TabRestoreUITest.RestoreIntoSameWindow 

Review URL: http://codereview.chromium.org/160060
------------------------------------------------------------------------
r21469 | brettw@chromium.org | 2009-07-24 01:18:12 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/metadata_url_request.cc
   A /trunk/src/chrome/browser/parsers
   A /trunk/src/chrome/browser/parsers/metadata_parser.cc
   A /trunk/src/chrome/browser/parsers/metadata_parser.h
   A /trunk/src/chrome/browser/parsers/metadata_parser_factory.h
   A /trunk/src/chrome/browser/parsers/metadata_parser_filebase.cc
   A /trunk/src/chrome/browser/parsers/metadata_parser_filebase.h
   A /trunk/src/chrome/browser/parsers/metadata_parser_jpeg.cc
   A /trunk/src/chrome/browser/parsers/metadata_parser_jpeg.h
   A /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.cc
   A /trunk/src/chrome/browser/parsers/metadata_parser_jpeg_factory.h
   A /trunk/src/chrome/browser/parsers/metadata_parser_manager.cc
   A /trunk/src/chrome/browser/parsers/metadata_parser_manager.h
   M /trunk/src/chrome/chrome.gyp

Adding a new parsing system to the metadata url request.

BUG=none
TEST=none
Original review: http://codereview.chromium.org/155803
Patch by: dhg@google.com

Review URL: http://codereview.chromium.org/160059
------------------------------------------------------------------------
r21468 | jhawkins@chromium.org | 2009-07-24 01:15:21 +0200 (Fri, 24 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   D /trunk/src/chrome/test/data/valgrind/unit_tests.gtest_linux.txt

gtk: Set the treeview column title even for headers we aren't displaying.  Older versions of gtk trip up on an empty title string.

BUG=15445
TEST=Watch the Linux valgrind bot stay green.
Review URL: http://codereview.chromium.org/159312
------------------------------------------------------------------------
r21466 | ajwong@chromium.org | 2009-07-24 01:06:56 +0200 (Fri, 24 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Allow the browser to send actions back to the render for media element context menus.

Also renamed ContextNodeType per fishd's suggestion.

BUG=15686
TEST=none

Review URL: http://codereview.chromium.org/155954
------------------------------------------------------------------------
r21463 | mattm@chromium.org | 2009-07-24 00:46:45 +0200 (Fri, 24 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   M /trunk/src/chrome/browser/gtk/options/cookies_view.h

Gtk: Add cookie details to cookie manager.

BUG=11507

Review URL: http://codereview.chromium.org/155974
------------------------------------------------------------------------
r21457 | tc@google.com | 2009-07-24 00:14:17 +0200 (Fri, 24 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

A small refactor of the toolbar background.

I'm not sure in what cases SetProfile will be called to change
the profile, but this seems to handle that possible case.

Review URL: http://codereview.chromium.org/159282

------------------------------------------------------------------------
r21455 | evan@chromium.org | 2009-07-24 00:10:53 +0200 (Fri, 24 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

linux: generalize desktop environment guessing to encompass KDE

BUG=17363

Review URL: http://codereview.chromium.org/159297
------------------------------------------------------------------------
r21454 | jhawkins@chromium.org | 2009-07-24 00:04:22 +0200 (Fri, 24 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/page_info_model.h

Pass input string parameters by reference.

CID=5116
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160052
------------------------------------------------------------------------
r21448 | estade@chromium.org | 2009-07-23 23:35:19 +0200 (Thu, 23 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Bookmark bar: Don't connect to the OnDragDrop signal since we can just use the default.

Eventually we may want to allow dropping more different types, and we will need to implement an OnDragDrop handler so we can properly prioritize these types (preferring BOOKMARK_ITEM over TEXT_PLAIN and so forth). But for now we can just use the default handler.

BUG=17501
TEST=drag an image onto the bookmark bar, note that there is only one link created

Review URL: http://codereview.chromium.org/159256
------------------------------------------------------------------------
r21445 | erg@google.com | 2009-07-23 23:14:59 +0200 (Thu, 23 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Close pop up notification when navigating to other site.

When BlockedPopupContainer stopped being a ConstrainedWindow, the
notification stopped being cleared in TabContents::MaybeCloseChildWindows.

http://crbug.com/8622
http://crbug.com/14150
TEST=See 8622 for repro steps.

Review URL: http://codereview.chromium.org/159287
------------------------------------------------------------------------
r21444 | phajdan.jr@chromium.org | 2009-07-23 23:13:52 +0200 (Thu, 23 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/base/gfx/point.cc
   M /trunk/src/base/gfx/point.h
   M /trunk/src/base/gfx/rect.cc
   M /trunk/src/base/gfx/rect.h
   M /trunk/src/base/gfx/size.cc
   M /trunk/src/base/gfx/size.h
   M /trunk/src/chrome/browser/bookmarks/base_bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window.mm
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h

Headers cleanup:

- reduce header dependencies by using bookmark_model_observer.h
- replace #include <iostream> by #include <iosfwd> in headers

Review URL: http://codereview.chromium.org/159280
------------------------------------------------------------------------
r21440 | jhawkins@chromium.org | 2009-07-23 22:48:55 +0200 (Thu, 23 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

gtk: Fix the case where a user quickly moves the mouse away from a dragged tab
causing gtk to stop generating motion-notify-event signals.  In this case,
a call to gtk_grab_add lets gtk clean up the drag for us.

BUG=16509
TEST=Quickly move the mouse away from a dragged tab (up and left works best).
The drag will end and a new window will open.  The dragged tab window should
not still exist.
Review URL: http://codereview.chromium.org/159290
------------------------------------------------------------------------
r21438 | jcampan@chromium.org | 2009-07-23 22:40:10 +0200 (Thu, 23 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   A /trunk/src/chrome/browser/omnibox_search_hint.cc
   A /trunk/src/chrome/browser/omnibox_search_hint.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

This CL adds an infobar instructing users they can do search directly from the location bar when they navigate to their default search engine.The infobar is dismissed and not shown again if the user does a search from the omnibox or dismiss the infobar.This is part of a UX experiment and is behind a switch.BUG=NoneTEST=Start Chrome with a fresh profile. Navigate to www.google.com. An info bar should be shown. Click the 'show me' button, the location bar should display a message explaining search can be made from it.
Review URL: http://codereview.chromium.org/159242
------------------------------------------------------------------------
r21437 | mpcomplete@chromium.org | 2009-07-23 22:36:49 +0200 (Thu, 23 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/gears/binaries/gears.dll
   M /trunk/src/gears/binaries/gears.pdb

CPAPI (0.11) for gears drag drop.

Provide a method that allows the gears plugin to ask the browser
process to verify that its renderer has permission to access the
drop files. Update the copyright notices.

BUG=7995

Review URL: http://codereview.chromium.org/159074
------------------------------------------------------------------------
r21435 | klink@chromium.org | 2009-07-23 22:35:57 +0200 (Thu, 23 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Disables BookmarkHTMLWriterTest for now, since it is very flaky on Windows. Will talk to Scott when he comes back from vacation to get this re-enabled.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/159225
------------------------------------------------------------------------
r21432 | pinkerton@chromium.org | 2009-07-23 22:12:50 +0200 (Thu, 23 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/TabView.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Make tabs go all the way to the right edge and stop using less of the strip as more tabs are added. Don't resize on selection when tabs are very small, except just enough to show a close box. Clip closebox and favicon as tab gets very small. Fix z-order to be consistent among all unselected tabs. Fix incognito man disappearing when dragging window via the tab. Tabs can now get about as small as they do on windows allowing many more to fit.
BUG=14911, 14913, 17372
TEST=adding and removing lots of tabs and making sure nothing goes wrong.
Review URL: http://codereview.chromium.org/159206
------------------------------------------------------------------------
r21428 | kuchhal@chromium.org | 2009-07-23 21:51:18 +0200 (Thu, 23 Jul 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h

Allow two user level installs of Chrome to have default browser settings.

This change will allow two Windows users to install thier own copy of Chrome
and set it as default browser. There is a bunch of refactoring in this change.
- Divided the registry entries into three categories:
  * Entries that are only read from HKLM
  * Entries that actually tie file/protocol associations to Chrome. This will
    almost always be in HKCU (except when it is a OEM install).
  * Entries that we can create in HKCU if we fail to create them in HKLM.
- For single user machine nothing should change.
- For two users on the same machine (each with a different user level Chrome
installed), the second user's default browser will get renamed to
Chromium.<user> and the required registry entries will also be renamed so that
they do not overwrite first users's registry entries.

BUG=3641
TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, user-level install/system-level install.

Review URL: http://codereview.chromium.org/159172
------------------------------------------------------------------------
r21424 | cpu@google.com | 2009-07-23 21:25:01 +0200 (Thu, 23 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc

Don't add the QuickLaunch shortcut by default in Windows7

BUG=17401
TEST=none


Review URL: http://codereview.chromium.org/159244
------------------------------------------------------------------------
r21421 | pinkerton@chromium.org | 2009-07-23 21:12:40 +0200 (Thu, 23 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Fix issue where dragging window via a tab would incorrectly dim chrome when there were no other windows as drag targets, but only the first time.
BUG=11125
TEST=dragging tabs in and out of windows should show consistent feedback.
Review URL: http://codereview.chromium.org/160018
------------------------------------------------------------------------
r21420 | avi@chromium.org | 2009-07-23 21:12:23 +0200 (Thu, 23 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/base_view.mm
   M /trunk/src/webkit/glue/webview_impl.cc

Fix bug 15795: make the capslock indicator in password fields (on Mac) work.
(Hook up WebKit's Frame::eventHandler()->capsLockStateMayHaveChanged() in
WebViewImpl::KeyEvent() and -flagsChanged: to -keyEvent: in BaseView.)

Patch from viettrungluu@gmail.com.

BUG=http://crbug.com/15795
TEST=go to some password field (e.g., in gmail login), cycle capslock

Review URL: http://codereview.chromium.org/159215

------------------------------------------------------------------------
r21417 | darin@chromium.org | 2009-07-23 21:10:23 +0200 (Thu, 23 Jul 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Add support to URLRequest for deferring redirects.

I chose to add an out parameter to OnReceivedRedirect because it allows for the
default behavior to remain the same.

I considered adding a ContinueAfterRedirect method that all OnReceivedRedirect
implementations would need to call, but this caused one annoying problem:  In
the case of a ChromePlugin, it is possible for the URLRequest to get deleted
inside the handler for the redirect.  This would make it hard to subsequently
call a method on the URLRequest since I would need to have a way to determine
if the URLRequest had been deleted.

TEST=covered by unit tests
BUG=16413,6442
R=eroman,wtc

Review URL: http://codereview.chromium.org/155897
------------------------------------------------------------------------
r21412 | nsylvain@chromium.org | 2009-07-23 20:17:55 +0200 (Thu, 23 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/utility/utility_main.cc
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/ipc/ipc_channel_proxy.cc
   M /trunk/src/ipc/ipc_channel_proxy.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Unrevert 21355 because the revert might be causing the
worker tests failures.

Review URL: http://codereview.chromium.org/159276
------------------------------------------------------------------------
r21410 | agl@chromium.org | 2009-07-23 19:58:27 +0200 (Thu, 23 Jul 2009) | 34 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Select omnibox text on button release instead of press.

We also don't select all of the text if the user dragged to
highlight some text before releasing the button.

Tested by repeating the scenarios from:

  http://codereview.chromium.org/151006
  http://codereview.chromium.org/159185

plus checking that the following cases behave as expected:

1. Type some text into the omnibox.  Click in Webkit to give
   it the focus.  Click once in the omnibox.  All of its
   text should be highlighted, and middle-clicking in
   another window should show that the primary selection was
   updated.

2. Click in the omnibox to clear its highlighted text and
   click in Webkit again.  Click in the omnibox again, but
   this time drag to highlight some text before letting go
   of the button.  The highlighted text should be preserved
   on button release, and the primary selection should be
   updated.

3. Repeat step 2.  Click a few times in the omnibox and
   confirm that we don't select all of its text (that should
   only happen at the end of the initial click that focuses
   the omnibox).

(Patch from Dan Erat)

http://codereview.chromium.org/155971

------------------------------------------------------------------------
r21409 | mpcomplete@chromium.org | 2009-07-23 19:56:50 +0200 (Thu, 23 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc

Have UtilityProcessHostTest wait until the utility process dies before
finishing.  This is an attempt to fix a memory leak.

BUG=17387
TEST=no

Review URL: http://codereview.chromium.org/155895
------------------------------------------------------------------------
r21400 | robertshield@chromium.org | 2009-07-23 19:34:58 +0200 (Thu, 23 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.h

Squash the "Confirm Form Repost" dialog triggered via an external context menu reload - the dialog is modal, but there may not be anything for it to be modal to.

This is a shorter term fix - a longer term fix will be to change the way the dialog is displayed and allow it to be routed through automation.

Review URL: http://codereview.chromium.org/160010
------------------------------------------------------------------------
r21398 | nsylvain@chromium.org | 2009-07-23 19:33:22 +0200 (Thu, 23 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/utility/utility_main.cc
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/ipc/ipc_channel_proxy.cc
   M /trunk/src/ipc/ipc_channel_proxy.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Revert 21355 because it might be causing all the new
crashes on reliability. It also seems to be causing 
valgrind error.

Original change: 
Switch the first thread in a child process to be the main thread, and make theIO thread be the second thread.  The change is needed for plugins on mac.

Review URL: http://codereview.chromium.org/159274
------------------------------------------------------------------------
r21396 | arv@google.com | 2009-07-23 19:24:05 +0200 (Thu, 23 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Adds the drag over animation.

When we drag over a thumbnail we move the drop target 15px towards the
location it would be if we dropped the source.

BUG=14961

TEST=Drag a thumbnail. When dragging over an item the item should move
towards the location of where the source came from.


Review URL: http://codereview.chromium.org/155978
------------------------------------------------------------------------
r21394 | erg@google.com | 2009-07-23 18:44:11 +0200 (Thu, 23 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

GTK Themes: Use the GTK close button in the download shelf and popup notification.

Review URL: http://codereview.chromium.org/155939
------------------------------------------------------------------------
r21393 | avi@chromium.org | 2009-07-23 18:35:56 +0200 (Thu, 23 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Propagate theme changes to the tabstrip.

BUG=http://crbug.com/17519
TEST=change themes; tabs should theme too

Review URL: http://codereview.chromium.org/159271
------------------------------------------------------------------------
r21392 | brettw@chromium.org | 2009-07-23 18:31:45 +0200 (Thu, 23 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Re-enable some focus UI tests. These failed for unknown reasons with a funny
error from the notification service. This error seems to be fixed.

BUG=15265
Test=This is a test
Review URL: http://codereview.chromium.org/155858
------------------------------------------------------------------------
r21389 | brettw@chromium.org | 2009-07-23 18:14:09 +0200 (Thu, 23 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/debug_flags.cc

Fix liner errors due to duplicate symbols in the switches. These switches
were moved to IPC, but the source ones in chrome/common were kept.
Review URL: http://codereview.chromium.org/160014
------------------------------------------------------------------------
r21386 | pinkerton@chromium.org | 2009-07-23 17:54:18 +0200 (Thu, 23 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Correctly account for windows of different sizes when snapping windows together during a drag.
BUG=16386
TEST=dragging together windows of different sizes.
Review URL: http://codereview.chromium.org/159270
------------------------------------------------------------------------
r21381 | pinkerton@chromium.org | 2009-07-23 16:57:23 +0200 (Thu, 23 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm

Increase the close button offset so the text doesn't overlap it.
BUG=13300
TEST=see bug.
Review URL: http://codereview.chromium.org/159269
------------------------------------------------------------------------
r21379 | pinkerton@chromium.org | 2009-07-23 16:35:00 +0200 (Thu, 23 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Don't install the incognito badge in anything other than a normal browser window.
BUG=17531
TEST=incognito man doesn't show up in popups, but does in main windows.
Review URL: http://codereview.chromium.org/159267
------------------------------------------------------------------------
r21376 | aa@chromium.org | 2009-07-23 10:00:35 +0200 (Thu, 23 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Unbreak extension installation. Cleanup accidentally reversed
boolean logic. Difficult to test because this is way up close
to the UI.

Review URL: http://codereview.chromium.org/160002
------------------------------------------------------------------------
r21364 | arv@google.com | 2009-07-23 03:29:53 +0200 (Thu, 23 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

Tweak thumbnail sizes a bit so it the NNTP looks better side by side on
a 1920x1200 screen.

Also, tweak the default size of new windows slightly. In case we decide
to use side by side windows size the window in such a way that 2
windows fit on the screen and have the kWindowTilePixels spacing
between each other and the screen edges.

BUG=None

TEST=Show two windows side. On a 1920x1200 screen they should both be
showing the thumbnails in normal size.

Review URL: http://codereview.chromium.org/155930
------------------------------------------------------------------------
r21355 | jam@chromium.org | 2009-07-23 02:25:06 +0200 (Thu, 23 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/utility/utility_main.cc
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/ipc/ipc_channel_proxy.cc
   M /trunk/src/ipc/ipc_channel_proxy.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Switch the first thread in a child process to be the main thread, and make theIO thread be the second thread.  The change is needed for plugins on mac.
Review URL: http://codereview.chromium.org/155944
------------------------------------------------------------------------
r21350 | phajdan.jr@chromium.org | 2009-07-23 02:12:10 +0200 (Thu, 23 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h

Populate the Linux extension shelf with placeholder labels containing each extension's name.

TEST=none
http://crbug.com/16759

Review URL: http://codereview.chromium.org/155957
------------------------------------------------------------------------
r21348 | jhawkins@chromium.org | 2009-07-23 02:10:42 +0200 (Thu, 23 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h

gtk: Fix a regression from r21320 which caused a crash when dragging a tab out of the browser.  We must wrap the tab renderer widget in a GtkFixed in order to maintain the size we request for the widget; otherwise, the widget will fill the entire window.

BUG=none
TEST=Drag a tab out of the window.  This should not crash.
Review URL: http://codereview.chromium.org/155965
------------------------------------------------------------------------
r21347 | stuartmorgan@google.com | 2009-07-23 02:09:35 +0200 (Thu, 23 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Flip on crashed plugin name lookup on the Mac.

BUG=none
TEST=Running with --enable-plugins on, go to a page with a plugin and kill the plugin process. The info bar should list the name of the plugin rather than its path.

Review URL: http://codereview.chromium.org/155952
------------------------------------------------------------------------
r21346 | jorlow@chromium.org | 2009-07-23 02:09:02 +0200 (Thu, 23 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages_internal.h

One part of many for enabling DOM Storage.

Add browser-process IPC code + tweak the WebKit Thread.  Note that this code can't possibly be called/run yet.

WebKitThread now has a PostIOThreadTask methods that can safely post back to the IO thread.  This should be used for all WebKit thread -> the rest of the world communication.

There are many TODOs in this code that should be resolved before this is shipped without a --enable-local-storage flag.

BUG=4360
TEST=none
Review URL: http://codereview.chromium.org/155845
------------------------------------------------------------------------
r21344 | estade@chromium.org | 2009-07-23 02:07:16 +0200 (Thu, 23 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Show bookmark manager context menu on mouse down, not up.

If the mouse down occurs over an unselected row, let the default handler run before we show the context menu (so that row will be selected when we show the menu). If the mouse down occurs over a selected row, don't let the default handler run (because if multiple rows are selected the rest of the selection would get clobbered).

BUG=http://crbug.com/17388
TEST=see bug

Review URL: http://codereview.chromium.org/159179
------------------------------------------------------------------------
r21342 | agl@chromium.org | 2009-07-23 01:57:21 +0200 (Thu, 23 Jul 2009) | 34 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/WATCHLISTS
   M /trunk/src/base/file_descriptor_posix.h
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/app_cache/app_cache_context_impl.h
   M /trunk/src/chrome/common/app_cache/app_cache_dispatcher.h
   M /trunk/src/chrome/common/app_cache/app_cache_dispatcher_host.h
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/common/chrome_counters.h
   M /trunk/src/chrome/common/chrome_descriptors.h
   A /trunk/src/chrome/common/common_param_traits.cc
   A /trunk/src/chrome/common/common_param_traits.h
   A /trunk/src/chrome/common/common_param_traits_unittest.cc (from /trunk/src/chrome/common/ipc_message_unittest.cc:21338)
   M /trunk/src/chrome/common/devtools_messages.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   D /trunk/src/chrome/common/file_descriptor_set_posix.cc
   D /trunk/src/chrome/common/file_descriptor_set_posix.h
   D /trunk/src/chrome/common/file_descriptor_set_unittest.cc
   D /trunk/src/chrome/common/ipc_channel.h
   D /trunk/src/chrome/common/ipc_channel_handle.h
   D /trunk/src/chrome/common/ipc_channel_posix.cc
   D /trunk/src/chrome/common/ipc_channel_posix.h
   D /trunk/src/chrome/common/ipc_channel_proxy.cc
   D /trunk/src/chrome/common/ipc_channel_proxy.h
   D /trunk/src/chrome/common/ipc_channel_win.cc
   D /trunk/src/chrome/common/ipc_channel_win.h
   D /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   D /trunk/src/chrome/common/ipc_logging.cc
   D /trunk/src/chrome/common/ipc_logging.h
   D /trunk/src/chrome/common/ipc_maybe.h
   D /trunk/src/chrome/common/ipc_message.cc
   D /trunk/src/chrome/common/ipc_message.h
   D /trunk/src/chrome/common/ipc_message_macros.h
   D /trunk/src/chrome/common/ipc_message_unittest.cc
   D /trunk/src/chrome/common/ipc_message_utils.cc
   D /trunk/src/chrome/common/ipc_message_utils.h
   D /trunk/src/chrome/common/ipc_send_fds_test.cc
   D /trunk/src/chrome/common/ipc_sync_channel.cc
   D /trunk/src/chrome/common/ipc_sync_channel.h
   D /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   D /trunk/src/chrome/common/ipc_sync_message.cc
   D /trunk/src/chrome/common/ipc_sync_message.h
   D /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   D /trunk/src/chrome/common/ipc_sync_message_unittest.h
   M /trunk/src/chrome/common/ipc_test_sink.h
   D /trunk/src/chrome/common/ipc_tests.cc
   D /trunk/src/chrome/common/ipc_tests.h
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/mock_printer.cc
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   A /trunk/src/ipc/file_descriptor_set_posix.cc (from /trunk/src/chrome/common/file_descriptor_set_posix.cc:21338)
   A /trunk/src/ipc/file_descriptor_set_posix.h (from /trunk/src/chrome/common/file_descriptor_set_posix.h:21338)
   A /trunk/src/ipc/file_descriptor_set_unittest.cc (from /trunk/src/chrome/common/file_descriptor_set_unittest.cc:21338)
   A /trunk/src/ipc/ipc.gyp
   A /trunk/src/ipc/ipc_channel.h (from /trunk/src/chrome/common/ipc_channel.h:21338)
   A /trunk/src/ipc/ipc_channel_handle.h (from /trunk/src/chrome/common/ipc_channel_handle.h:21338)
   A /trunk/src/ipc/ipc_channel_posix.cc (from /trunk/src/chrome/common/ipc_channel_posix.cc:21338)
   A /trunk/src/ipc/ipc_channel_posix.h (from /trunk/src/chrome/common/ipc_channel_posix.h:21338)
   A /trunk/src/ipc/ipc_channel_proxy.cc (from /trunk/src/chrome/common/ipc_channel_proxy.cc:21338)
   A /trunk/src/ipc/ipc_channel_proxy.h (from /trunk/src/chrome/common/ipc_channel_proxy.h:21338)
   A /trunk/src/ipc/ipc_channel_win.cc (from /trunk/src/chrome/common/ipc_channel_win.cc:21338)
   A /trunk/src/ipc/ipc_channel_win.h (from /trunk/src/chrome/common/ipc_channel_win.h:21338)
   A /trunk/src/ipc/ipc_descriptors.h (from /trunk/src/chrome/common/chrome_descriptors.h:21338)
   A /trunk/src/ipc/ipc_fuzzing_tests.cc (from /trunk/src/chrome/common/ipc_fuzzing_tests.cc:21338)
   A /trunk/src/ipc/ipc_logging.cc (from /trunk/src/chrome/common/ipc_logging.cc:21338)
   A /trunk/src/ipc/ipc_logging.h (from /trunk/src/chrome/common/ipc_logging.h:21338)
   A /trunk/src/ipc/ipc_message.cc (from /trunk/src/chrome/common/ipc_message.cc:21338)
   A /trunk/src/ipc/ipc_message.h (from /trunk/src/chrome/common/ipc_message.h:21338)
   A /trunk/src/ipc/ipc_message_macros.h (from /trunk/src/chrome/common/ipc_message_macros.h:21338)
   A /trunk/src/ipc/ipc_message_unittest.cc
   A /trunk/src/ipc/ipc_message_utils.cc
   A /trunk/src/ipc/ipc_message_utils.h (from /trunk/src/chrome/common/ipc_message_utils.h:21338)
   A /trunk/src/ipc/ipc_send_fds_test.cc (from /trunk/src/chrome/common/ipc_send_fds_test.cc:21338)
   A /trunk/src/ipc/ipc_switches.cc
   A /trunk/src/ipc/ipc_switches.h
   A /trunk/src/ipc/ipc_sync_channel.cc (from /trunk/src/chrome/common/ipc_sync_channel.cc:21338)
   A /trunk/src/ipc/ipc_sync_channel.h (from /trunk/src/chrome/common/ipc_sync_channel.h:21338)
   A /trunk/src/ipc/ipc_sync_channel_unittest.cc (from /trunk/src/chrome/common/ipc_sync_channel_unittest.cc:21338)
   A /trunk/src/ipc/ipc_sync_message.cc (from /trunk/src/chrome/common/ipc_sync_message.cc:21338)
   A /trunk/src/ipc/ipc_sync_message.h (from /trunk/src/chrome/common/ipc_sync_message.h:21338)
   A /trunk/src/ipc/ipc_sync_message_unittest.cc (from /trunk/src/chrome/common/ipc_sync_message_unittest.cc:21338)
   A /trunk/src/ipc/ipc_sync_message_unittest.h (from /trunk/src/chrome/common/ipc_sync_message_unittest.h:21338)
   A /trunk/src/ipc/ipc_tests.cc (from /trunk/src/chrome/common/ipc_tests.cc:21338)
   A /trunk/src/ipc/ipc_tests.h (from /trunk/src/chrome/common/ipc_tests.h:21338)

Split the IPC code into ipc/

This splits the ipc code from the common project.  The 'common' project pulls in
all of webkit, the v8 bindings, skia, googleurl, and a number of other projects
which makes it very difficult to deal with especially for external projects
wanting just to use some of Chromium's infrastructure.  This puts the ipc code
into its top-level ipc/ directory with a dependency only on base.  The common
project depends on the new ipc/ipc.gyp:ipc target so that all projects currently
pulling common in to get the IPC code still have it available.  This mostly
follows agl's pre-gyp attempt to do this which was r13062.

Known issues:
- Currently a number of projects depend on chrome/chrome.gyp:common in order to
use the IPC infrastructure.  Rather than fixing all of these dependencies I have
made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules
section of DEPS so that checkdeps.py doesn't complain.  Over time projects that
need IPC should depend on the IPC project themselves and dependencies on common
removed, although I don't think many projects that need IPC will be able to get
away without common currently.
- ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a
ipc/ should not refer to files in chrome/... now.  I'm not sure how to resolve
this since it's really an IDE bug
- the named pipe name (windows+linux) and the logging event name (all) + env
variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion
of ipc/ being an independent library.  I think this should be examined in a
subsequent, much smaller patch.
- I've eliminated the IPC.SendMsgCount counter since it was implemented in a way
to create a dependency from ipc/ to chrome/common/chrome_counters. This is the
same approach that r13062 took.

http://codereview.chromium.org/155905

(Patch from James Robinson)

------------------------------------------------------------------------
r21341 | mpcomplete@chromium.org | 2009-07-23 01:42:09 +0200 (Thu, 23 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Fix my previous revert.  Merge issues.

TBR: aa
------------------------------------------------------------------------
r21340 | mpcomplete@chromium.org | 2009-07-23 01:39:25 +0200 (Thu, 23 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/background.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js

Revert "Fix an issue with unregistering content script contexts."

browser_tests are not happy.

TBR=aa
BUG=no
TEST=no

Review URL: http://codereview.chromium.org/159243
------------------------------------------------------------------------
r21336 | mpcomplete@chromium.org | 2009-07-23 00:57:28 +0200 (Thu, 23 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable 2 extension messaging browsertests until I can figure out why they are
failing on the buildbot.

TBR=aa
BUG=no
TEST=no

Review URL: http://codereview.chromium.org/159235
------------------------------------------------------------------------
r21329 | estade@chromium.org | 2009-07-22 23:53:05 +0200 (Wed, 22 Jul 2009) | 54 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Prevent omnibox autocomplete from stealing the primary X selection.

This is mostly accomplished by decoupling autocomplete (and the
auto-select-all when first clicking in the omnibox to focus it) from GTK's
clipboard code.  Before we update the selection marks, I unregister the
clipboard and block the signal from reaching my handler.  Afterwards, I
restore things.

This creates the possibly-odd effect that text can be highlighted both in
the omnibox and in Webkit, assuming that the omnibox text isn't actually
the primary selection.  I think that this is reasonable, but let me know if
you can think of a better way that it should be handled.

To test, I confirmed that all of the cases listed in
http://codereview.chromium.org/151006's description still work, along with
the following new ones:

1. Highlight text in an xterm to make it the primary selection.  Start
   typing an autocomplete-able URL into Chrome's omnibox.  Middle-click in
   the xterm and check that the xterm's text, rather than the autocompleted
   text from the omnibox, is pasted.

2. Now switch to a different tab and middle-click in the xterm again.  The
   xterm's text should still be pasted.

3. Switch to the original tab and check that the xterm's text is still the
   primary selection.

4. Highlight text in an xterm.  Click in Webkit to make sure
   that the omnibox doesn't have the focus.  Left-click in the omnibox.
   Its text should be highlighted but not made the primary selection
   (middle-clicking in the xterm should still paste the xterm's text).

   EDIT: I've changed this behavior -- clicking in the omnibox to focus it
   now sets its text as the primary selection.

5. Now triple-left-click in the omnibox to highlight all of its text.  This
   time, the URL should become the primary selection.

   EDIT: This is no longer relevant.

I noticed the following annoying behavior, but it's also present in the
official build without this change, so I don't think it's a regression
(there's probably something going on in GTK that I don't understand):

Highlight some text in the omnibox to make it the primary selection.
Now double-left-click to highlight a word in an xterm.  The word flashes in
the xterm, but Chrome automatically grabs the selection again.
Double-clicking in the xterm again lets it hang on to the selection.

Patch by Dan Erat <derat [at] google>
original review url: <http://codereview.chromium.org/159185>

Review URL: http://codereview.chromium.org/159230
------------------------------------------------------------------------
r21328 | davemoore@chromium.org | 2009-07-22 23:42:34 +0200 (Wed, 22 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/panel_controller.cc
   M /trunk/src/chrome/browser/views/panel_controller.h

Made the title of panels show focused state with black text
(as opposed to grey text in unfocused panels)
Review URL: http://codereview.chromium.org/159176
------------------------------------------------------------------------
r21324 | mpcomplete@chromium.org | 2009-07-22 23:32:24 +0200 (Wed, 22 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/background.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js

Fix an issue with unregistering content script contexts.

Reenable content script messaging test.

BUG=no
TEST=no

Review URL: http://codereview.chromium.org/155887
------------------------------------------------------------------------
r21323 | mattm@chromium.org | 2009-07-22 23:30:14 +0200 (Wed, 22 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Make UtilityProcessHost destructor virtual.

BUG=17129

Review URL: http://codereview.chromium.org/155946
------------------------------------------------------------------------
r21322 | pkasting@chromium.org | 2009-07-22 23:22:49 +0200 (Wed, 22 Jul 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Try and improve result coalescing/display in the omnibox popup.

This eliminates the delay timer in the popup view, and also eliminates the coalesce timer in the controller.  Instead, we simply coalesce until we're done, we have at least as many results as we're already showing, or the "maximum delay timeout" (300 ms) fires, indicating we've gone too long without updating.

Additionally, in order to be more responsive when typing rapidly, the controller updates observers immediately with the available results from a previous query if one is still running when a new query is started.  While in theory this seems like it might produce flicker, in practice _not_ having it also results in flicker (just less-predictable flicker) since the 300 ms timeout starts kicking in at random times relative to when new keys are pressed.

I also fixed a few small problems with leaving 1-pixel high white rows at the bottom of the popup during rapid typing (which weren't visible before this change since the popup would never shrink during rapid typing).

After eliminating the timeout in the popup view, I was able to refactor the code to be shorter since a few members and helper functions could all be inlined.  Then I added some long comments and made things not much shorter after all :/.  I also changed two other (self-contained) unrelated spots in the popup to be shorter.

Please patch this in locally and try how it feels.  Things to test with this change vs. the old code vs. the old, old (original omnibox) code:
* Type one letter at a time with long pauses in between; see how flickery the popup is
* Type one letter (e.g. "a") and then type rapidly for a while; see how responsive the popup is
* Type words like "amazon", "compusa" and "comcast" at various different speeds and observe the flicker vs. responsiveness tradeoff
* Type or paste some long series of letters (that default to searching), then rapidly press and release the ctrl key

My hope is that this hits a good balance (it's very difficult to be both flicker-free and responsive, I view the previous two sets of code as being off first one side of the scale and then the other).  Possible tweaks include the animation tweening mechanism and timing (I experimented with various different speeds and linear tweening, nothing felt significantly better to me but my machine sucks w.r.t. animation quality) and tweaking the controller "max timeout" value and notification behavior upon starting a new query (I tried notifying only if two keys had been typed since the last notification, it didn't feel better).

BUG=none
TEST=see above
Review URL: http://codereview.chromium.org/149659
------------------------------------------------------------------------
r21321 | aa@chromium.org | 2009-07-22 23:21:48 +0200 (Wed, 22 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Nasty short-term hack to special case display of dialog
on theme installation. It should not be displayed if the
theme was installed from our gallery URL.

I intend to fix this very soon, but I wanted it to make
this coming build, so I did this quick thing for now.

Also, I found another bug in ExtensionsService install
logic. There was a test, it was ensuring the wrong
behavior :(.
Review URL: http://codereview.chromium.org/155936
------------------------------------------------------------------------
r21320 | jhawkins@chromium.org | 2009-07-22 23:17:56 +0200 (Wed, 22 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

gtk: Keep track of the tab bounds using the size-allocate signal.  Previously we assumed that the tab was immediately sized as requested, which was not always happening.  This fixes a problem seen in RTL layout where the close button would be incorrectly positioned.

BUG=16756
TEST=Open the browser in a RTL language.  Notice that the close buttons on tabs are positioned correctly.
Review URL: http://codereview.chromium.org/155942
------------------------------------------------------------------------
r21318 | hclam@chromium.org | 2009-07-22 22:50:44 +0200 (Wed, 22 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc

Ignore errors about creating audio output stream
Instead of failing the media playback pipeline
completely, this change will ignores all errors
reported by the browser about audio output streams.

This is the first step towards handling audio hardware
errors.

TEST=MediaTest.VideoBearTheora

Review URL: http://codereview.chromium.org/159205
------------------------------------------------------------------------
r21314 | phajdan.jr@chromium.org | 2009-07-22 22:33:56 +0200 (Wed, 22 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc

Remove 1px of grey at the bottom of the render view.

It was a part of extension shelf not hiding fully.

TEST=On Linux, open any website with links and mouse hover over any link. There should be no gap between the status bubble and the bottom of the window.
http://crbug.com/17324

Review URL: http://codereview.chromium.org/155934
------------------------------------------------------------------------
r21312 | xji@chromium.org | 2009-07-22 22:07:47 +0200 (Wed, 22 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

This CL fixes issue 2780 -- RTL: Omnibar - message "Press Tab to search Google" doesn't show correctly in a "New Tab" for RTL locales

Because of the bug in PosFromChar() (see bug report for detailed information), we actually calculate the width of the string ourselves using font.GetStringWidth().

BUG=http://crbug.com/2780
TEST=
1 Start Chrome with a *new user data directory* and make sure the UI language is Hebrew.
2 Type www.google.com in the omnibox and press Enter.
3 Close and re-open the browser.
4 Type character "h" in Ominibox
5 Message "Press Tab to search Google" should show correctly, not only "Tab" is displayed
Review URL: http://codereview.chromium.org/155789
------------------------------------------------------------------------
r21311 | agl@chromium.org | 2009-07-22 22:06:51 +0200 (Wed, 22 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: add support for tm_zone to localtime via the sandbox.

Glibc adds a field to struct tm, tm_zone, which contains a pointer to
a string for the current time zone. Since this makes struct tm a
non-POD data type, it only works for the non-thread-safe localtime()
call, not localtime_r().

However, V8 relies on it so this patch adds support for passing it
through our sandbox.

BUG=17458
http://codereview.chromium.org/159216

------------------------------------------------------------------------
r21310 | shess@chromium.org | 2009-07-22 21:52:04 +0200 (Wed, 22 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Don't handle up/down-arrow unless popup is visible.

http://crbug.com/17013
TEST=Browse to www.google.com.  Click in the field.  Up-arrow should
go to beginning of line, down-arrow to end.

Review URL: http://codereview.chromium.org/155871
------------------------------------------------------------------------
r21308 | pinkerton@chromium.org | 2009-07-22 21:42:17 +0200 (Wed, 22 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Make double-clicking on the tab strip minimize (i.e., "miniaturize") the
window. Patch from viettrungluu@gmail.com (Viet-Trung Luu).
BUG=12286
TEST=double-clicking tab strip and anything that may have regressed in bug 12505
------------------------------------------------------------------------
r21307 | mattm@chromium.org | 2009-07-22 21:39:21 +0200 (Wed, 22 Jul 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/cookies_table_model.cc (from /trunk/src/chrome/browser/views/options/cookies_view.cc:21261)
   A /trunk/src/chrome/browser/cookies_table_model.h (from /trunk/src/chrome/browser/views/options/cookies_view.cc:21261)
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/cookies_view.cc
   A /trunk/src/chrome/browser/gtk/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/chrome.gyp

Gtk cookie manager part 1.

(Doesn't display cookie details, otherwise working.)

BUG=11507
TEST=All cookie manager functions should work as expected, other than viewing the cookie details.


Review URL: http://codereview.chromium.org/159187
------------------------------------------------------------------------
r21305 | paul@chromium.org | 2009-07-22 21:20:45 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_mac.h
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm

Load Mac download shelf icons asynchronously.

BUG=16226 (http://crbug.com/16226)
TEST=none.

Review URL: http://codereview.chromium.org/155831
------------------------------------------------------------------------
r21304 | jhawkins@chromium.org | 2009-07-22 21:20:42 +0200 (Wed, 22 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

gtk: Only accept text/uri-list drops in the tab strip.  We were accepting text/plain before, which was giving us the html for a dragged image instead of the url of the image.

BUG=16165
TEST=Go to google.com.  Drag the Google logo into the tabstrip.  The image should open up in a new tab (or the current tab, depending on the drop).
Review URL: http://codereview.chromium.org/159212
------------------------------------------------------------------------
r21295 | tc@google.com | 2009-07-22 20:27:43 +0200 (Wed, 22 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc

Only check --lang and the app language pref on Windows.  They
don't make sense on Linux/Mac so disable them.

I think we don't want to have a app language option on Linux
since the standard way to do this is to use LANG or LC_ALL.

Update the locale ui test to set LC_ALL on Linux.

BUG=15359

Review URL: http://codereview.chromium.org/155819

------------------------------------------------------------------------
r21293 | jrg@chromium.org | 2009-07-22 20:18:56 +0200 (Wed, 22 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   A /trunk/src/chrome/app/nibs/BookmarkNameFolder.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Bookmark Bar Add Folder / Rename Folder dialog and controller.

TEST=Right click on bar --> Add Folder...
  Type a name and it shows up as a folder in the bookmark bar.
  (You can't do anything with it yet; sorry).
  Right click on folder name --> Edit...
  Make sure you can rename the folder.

Review URL: http://codereview.chromium.org/159183
------------------------------------------------------------------------
r21289 | ananta@chromium.org | 2009-07-22 20:07:51 +0200 (Wed, 22 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

The ExternalTabContainer object which implements the TabContentsDelegate interface now implements the 
ShowHtmlDialog function which is needed to support HTML dialog popups like those displayed by Gears.'

Fixes http://b/issue?id=1963582

Bug=1963582

Review URL: http://codereview.chromium.org/159162
------------------------------------------------------------------------
r21286 | arv@google.com | 2009-07-22 19:39:50 +0200 (Wed, 22 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Make DND use the anchor name.

BUG=17408

TEST=Drag a thumbnail from the NNTP to your desktop of your bookmakrs
bar. The title should be used.


Review URL: http://codereview.chromium.org/159184
------------------------------------------------------------------------
r21285 | jhawkins@chromium.org | 2009-07-22 19:29:31 +0200 (Wed, 22 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

gtk: Fix a regression from r20404 which keeps a drag into the tabstrip from working.  Only destroy the container widget and not the drop info itself when the drag leaves the tab strip; otherwise, we'll lose the drop information used to open the link.

BUG=none
TEST=Drag a link into the tab strip.  The drop arrow should appear and disappear as the mouse enters and leaves the tab strip.  Drop the link into the tab strip.  The link should be opened in the new tab (or the current tab).
Review URL: http://codereview.chromium.org/159178
------------------------------------------------------------------------
r21284 | thakis@chromium.org | 2009-07-22 19:26:34 +0200 (Wed, 22 Jul 2009) | 28 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   A /trunk/src/webkit/glue/webview_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Make scrollbars and other controls tint/untint upon main window gaining
focus on Mac. This entails the following:
  - getting notifications that the main window has become or lost key
    window status (in BrowserWindowController) [new]
  - ... which tells the RenderWidgetHostView(Mac) to (de)activate [new]
  - ... which tells the RenderWidgetHost to (de)activate [new]
  - ... which sends a ViewMsg_SetActive message [new message] to the
    RenderView [new]
  - ... which tells the WebView(Impl) to (de)activate [new]
  - ... which tells its page()'s FocusController to (de)activate [new]
  - ... which is now in WebKit-land.

N.B.: "Activate" is the nomenclature used in WebKit; "focus"/"blur" can
sometimes (kind of) mean the same thing, but is ambiguous, since "focus"
has a more specific meaning.

Added a WebView unit test, which currently only tests to make sure that
SetActive() (and IsActive() [also new]) work correctly. The changes to
the other classes aren't very testable since they don't actually do
anything (other than pass things along).

BUG=12507
TEST=webkit/glue/webkit_unittest.cc


Patch by viettrungluu@gmail.com (see http://codereview.chromium.org/159048 ),
r=avi

------------------------------------------------------------------------
r21280 | thomasvl@chromium.org | 2009-07-22 18:47:54 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/build/mac/generate_localizer
   M /trunk/src/chrome/browser/cocoa/ui_localizer.h
   M /trunk/src/chrome/browser/cocoa/ui_localizer.mm

Add a custom subclass of GTMUILocalizer that skips the bundle work so we can directly use these from nib files without some extra overhead.
Updated the generator to make things based off this subclass.

TEST=none
BUG=16764
Review URL: http://codereview.chromium.org/159197
------------------------------------------------------------------------
r21273 | avi@chromium.org | 2009-07-22 16:49:53 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Kill popups when scrolling.

BUG=http://crbug.com/17376
TEST=as in bug

Review URL: http://codereview.chromium.org/155875
------------------------------------------------------------------------
r21272 | thomasvl@chromium.org | 2009-07-22 16:04:27 +0200 (Wed, 22 Jul 2009) | 15 lines
Changed paths:
   A /trunk/src/build/mac/generate_localizer
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/nibs/MainMenu.xib
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/app_controller_mac.mm
   D /trunk/src/chrome/browser/cocoa/menu_localizer.h
   D /trunk/src/chrome/browser/cocoa/menu_localizer.mm
   A /trunk/src/chrome/browser/cocoa/ui_localizer.h
   A /trunk/src/chrome/browser/cocoa/ui_localizer.mm
   A /trunk/src/chrome/browser/cocoa/ui_localizer_unittest.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/chrome.gyp

Starting mac l10n:
  Added a script to process a xib file and generate a localizer out of the resource constants it finds in the xib.
  Update the MainMenu.xib to use a generated localizer.
  Kill off the menu_localizer in favor of a generated one.
  ui_localizer is a helper so each "localizer" is as small as possible.
  Build some menus out of base strings and the product name like windows.
Added the dir generated for the localizers so we can load the header to directly create them (menubar one).
Enable the other 3 languages we were building to help test.
Made the context menu code use the new code for handling window's accelerators and ellipsis.
Added unittest for ui_localizer.
Opened http://crbug.com/17380 to track the problem with the menu titles so I can move on to other parts of the UI for now.

TEST=The main menu will have some items localized now (and more will be localizable in the TC).
BUG=16764
Review URL: http://codereview.chromium.org/155774
------------------------------------------------------------------------
r21269 | pfeldman@chromium.org | 2009-07-22 11:41:33 +0200 (Wed, 22 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc

DevTools: Rename JavaScript console action into Developer Tools.

Review URL: http://codereview.chromium.org/155914
------------------------------------------------------------------------
r21267 | yusukes@google.com | 2009-07-22 08:31:15 +0200 (Wed, 22 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

o Modified the toolbar button handler so that the handler can revert its omnibox when the button pressed is RELOAD, FORWARD, or BACK.
o Modified Browser::Reload(). Don't revert the bar when the user hit F5 or Ctrl-r.

BUG=15464
TEST=see the comment #3 of issue 15464

Review URL: http://codereview.chromium.org/155908
------------------------------------------------------------------------
r21260 | mdm@chromium.org | 2009-07-22 04:24:35 +0200 (Wed, 22 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Linux: use new xdg-settings "check" feature to determine whether we are the default browser.
BUG=17093
TEST=in GNOME, let Firefox set itself as the default after Chrome has set itself; Chrome should then detect that it is no longer the default

Review URL: http://codereview.chromium.org/155889
------------------------------------------------------------------------
r21256 | estade@chromium.org | 2009-07-22 03:35:13 +0200 (Wed, 22 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

GTK: Center the tab text by its meanline, rather than halfway between its ascent and descent.

The tab text was previously one pixel too high. With this patch it matches Windows.

I think before Evan's recent font size patch, this issue was hidden by favorable rounding.

Review URL: http://codereview.chromium.org/159169
------------------------------------------------------------------------
r21255 | estade@chromium.org | 2009-07-22 03:34:38 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

When a web contents drag has a URL but no title, make up a title for it.

BUG=17393
TEST=drag nntp thumbnail to bookmark bar

Review URL: http://codereview.chromium.org/155900
------------------------------------------------------------------------
r21254 | estade@chromium.org | 2009-07-22 03:34:25 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Don't create new tabs for middle clicks on bookmark items when the user releases off the item.

BUG=14518
TEST=see bug

Review URL: http://codereview.chromium.org/155902
------------------------------------------------------------------------
r21251 | willchan@chromium.org | 2009-07-22 02:53:48 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_linux.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc
   A /trunk/src/chrome/browser/importer/nss_decryptor.cc (from /trunk/src/chrome/browser/importer/firefox_importer_utils.cc:21221)
   A /trunk/src/chrome/browser/importer/nss_decryptor.h
   A /trunk/src/chrome/browser/importer/nss_decryptor_linux.cc
   A /trunk/src/chrome/browser/importer/nss_decryptor_linux.h
   A /trunk/src/chrome/browser/importer/nss_decryptor_mac.h (from /trunk/src/chrome/browser/importer/firefox_importer_utils.h:21221)
   A /trunk/src/chrome/browser/importer/nss_decryptor_win.cc (from /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc:21221)
   A /trunk/src/chrome/browser/importer/nss_decryptor_win.h (from /trunk/src/chrome/browser/importer/firefox_importer_utils.h:21221)
   M /trunk/src/chrome/chrome.gyp

Split NSSDecryptor out into platform specific files.
This lets Linux not bother to initialize NSS in the same way as the rest, but instead use the NSS symbols linked into the library, thereby preventing the NSS_Shutdown related bugs.
BUG=http://crbug.com/13929
TEST=Case 1: Start chrome.  Use firefox import utility.  Browse to some https site.  Shouldn't crash.  Case 2: Start chrome.  Browse to some https site.  Use firefox import utility.  Continue browsing https sites.  Shouldn't crash.

Review URL: http://codereview.chromium.org/159165
------------------------------------------------------------------------
r21248 | piman@google.com | 2009-07-22 02:40:48 +0200 (Wed, 22 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

linux: add command-line flag to allow debugging of sandboxed processes

Review URL: http://codereview.chromium.org/159124

------------------------------------------------------------------------
r21246 | mattm@chromium.org | 2009-07-22 02:22:49 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc

Try again: Add proxy config (using gnome-network-preferences)

BUG=11507
TEST=Open options, click change proxy, gnome-network-preferences should launch.  If gnome isn't installed or running, LinuxProxyConfig wiki page should load.

Review URL: http://codereview.chromium.org/155792
------------------------------------------------------------------------
r21244 | finnur@chromium.org | 2009-07-22 02:17:09 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc

Addressing minor review comments in ExtensionProcessManager post-submit.

BUG=None
TEST=None (no significant changes)

Review URL: http://codereview.chromium.org/159073
------------------------------------------------------------------------
r21242 | hclam@google.com | 2009-07-22 02:06:17 +0200 (Wed, 22 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/media/audio/audio_output.h
   M /trunk/src/media/audio/fake_audio_output_stream.cc
   M /trunk/src/media/audio/fake_audio_output_stream.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/audio_manager_linux.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.h
   M /trunk/src/media/audio/mac/audio_manager_mac.cc
   M /trunk/src/media/audio/mac/audio_manager_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/simple_sources.cc
   M /trunk/src/media/audio/simple_sources_unittest.cc
   M /trunk/src/media/audio/win/audio_manager_win.h
   M /trunk/src/media/audio/win/audio_output_win.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/media.gyp

Refactoring to share MockAudioOutputStream implementations across 3 platforms

Re-trying the previous CL. The last change got reverted because of valgrind
failure.

TBR=scherkus

Original CL: http://codereview.chromium.org/155471

Review URL: http://codereview.chromium.org/159167
------------------------------------------------------------------------
r21241 | jrg@chromium.org | 2009-07-22 01:57:19 +0200 (Wed, 22 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/BookmarkBar.xib
   A /trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implement bookmark editor.  No tree display or hierarchy movement, but
name/url editing works.  Get to the edotir from a context menu (Edit,
Add Page).  Also Implement Open All Bookmarks menu item.

BUG=http://crbug.com/8381, http://crbug.com/17006 

TEST=Add some bookmarks.  
Right-click on a bookmark and pick Edit.
Test editing the name and URL.  Make sure you can't add a bogus URL.
Right-click on a bookmark or the bar and Add Page.
Fill in name and URL fields to add a new bookmark.
Right-click Open All Bookmarks and make sure it hoses your machine.

Review URL: http://codereview.chromium.org/155874
------------------------------------------------------------------------
r21240 | arv@google.com | 2009-07-22 01:57:05 +0200 (Wed, 22 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/i18n_template.js

Fix issue where error pages inserted HTML from a template but the
string from the template was used with JST instead of the i18n template
and therefore it did not get recursively processed.

Also make sure we can support recursive handling of setting innerHTML
with the i18n template engine.

BUG=17377

TEST=Navigate to http://ponderer.org/tests/redirect-loop.py The error
page should show: The webpage at http://ponderer.org/tests/redirect-loop.py 
has ...

Review URL: http://codereview.chromium.org/155884
------------------------------------------------------------------------
r21239 | arv@google.com | 2009-07-22 01:54:55 +0200 (Wed, 22 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Use a <button> that looks like a link to prevent right click and middle click.

BUG=9591

TEST=Go to the history page and make sure that "Delete history for this day"
still works and that it does not allow opening the "link" in a new window.

Review URL: http://codereview.chromium.org/155892
------------------------------------------------------------------------
r21233 | erg@google.com | 2009-07-22 01:38:29 +0200 (Wed, 22 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h

GTK Themes: Fixes button state on pressed back/forward buttons and toolbar items.

This patch fixes two related problems:

1) Holding down back/forward now stay pressed while the menu is shown.
2) Buttons on the "toolbar" now emulate GTK's toolbar behaviour of only showing
   the border on hover.

http://crbug.com/17308
http://crbug.com/17340

Review URL: http://codereview.chromium.org/159154
------------------------------------------------------------------------
r21232 | glen@chromium.org | 2009-07-22 01:36:32 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc

Sometimes it's possible for a DOMUI to request images that don't exist (theme provider could specify null, or no custom image is provided). Move DCHECK protection into real code.

BUG=17257
TEST=Run purify as described in bug.

Review URL: http://codereview.chromium.org/159146
------------------------------------------------------------------------
r21231 | thakis@chromium.org | 2009-07-22 01:36:03 +0200 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_cell.mm

Fix context menu on download item.

BUG=none
TEST=Click arrow part of download item. A context menu should appear.

Review URL: http://codereview.chromium.org/159174
------------------------------------------------------------------------
r21230 | jhawkins@chromium.org | 2009-07-22 01:34:57 +0200 (Wed, 22 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

gtk: Two fixes for the tab leak:
* The tab strip handles the lifetime of the tab widget, so don't try to increase the ref count in order to destroy the widget later.
* Use DeleteSoon when deleting the dragged tab in order to give gtk a chance to clean up its ref counts added during the drag operation.

BUG=12863
TEST=Extensive tab dragging.  No crashes and the Linux UI valgrind bot should stay green.
Review URL: http://codereview.chromium.org/159166
------------------------------------------------------------------------
r21228 | jhawkins@chromium.org | 2009-07-22 01:33:42 +0200 (Wed, 22 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

gtk: Make GtkThemeProvider own the gtk label widget.  The widget is not added to a container, so we don't have the convenience of having it destroyed by the container.

BUG=none
TEST=Watch the Linux UI valgrind bot get a little greener.
Review URL: http://codereview.chromium.org/159157
------------------------------------------------------------------------
r21221 | brettw@chromium.org | 2009-07-22 00:03:07 +0200 (Wed, 22 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Make middle-clicking on GTK tabs not count for closing if you release off of the tab itself.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159158
------------------------------------------------------------------------
r21216 | estade@chromium.org | 2009-07-21 23:06:23 +0200 (Tue, 21 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/utility/utility_main.cc
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/tools/valgrind/memcheck/suppressions.txt

Revert r21117 as it caused reliability failures.

Also included in this revert: r21165, r21180, and a couple valgrind suppression edits

TBR=huanr

Review URL: http://codereview.chromium.org/155876
------------------------------------------------------------------------
r21214 | arv@google.com | 2009-07-21 22:48:14 +0200 (Tue, 21 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Merge the recent activities into one list and show more items
when the section is larger.

Make the window menu look and behave more like a tooltip.

Return more recently closed windows and tabs when using the NNTP.

BUG=16539, 16835, 14963

TEST=Hide and show the tips section. More items (if there are more
items) should be shown. Hover over a closed window and the tooltip
should look like a tooltip on Vista/Win7

Review URL: http://codereview.chromium.org/155865
------------------------------------------------------------------------
r21207 | estade@chromium.org | 2009-07-21 22:19:34 +0200 (Tue, 21 Jul 2009) | 43 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Make GTK file dialog box modal for parent window, instead of for the entire
application.

This works by adding the top-level GtkWindow objects, such as BrowserWindowGtk
and BookmarkManagerGtk, to their own unique window groups. Without this change,
all top-level windows are added to a default application-wide window group.

This ensures that all grabs created with gtk_grab_add(...) only affect the
window group of the grabbed widget, as opposed to the entire application.

Note that gtk_window_set_modal(...) is implemented with gtk_grab_add(...) and
therefore is only modal to a specific window group.

In order for this to work correctly, changes were also made to the info
bubble and render widget popup (<select> tag) code. Since these widgets
also call gtk_grab_add(...), they must be added to the top level window
group to work correctly.

Test 1:
- Open two new chrome window: A and B
- Open "Save file as..." dialog in window A
- Verify that window A does not respond to keyboard or mouse events.
- Verify that window B does responde to keyboard and mouse events.
- Open "Save file as..." dialog in window B
- Verify that window B does not respond to keyboard or mouse events.
- Cancel dialog on window A.
- Verify that window A starts responding to keyboard and mouse events.
- Cancel dialog on window B.
- Verify that window B starts responding to keyboard and mouse events.

Test 2:
- Verify that <select> tag allows for correct selection of items.

Test 3:
- Click bookmark star and verify that info bubble works correctly.

BUG=8727
TEST=none

patch by Mohit Muthanna Cheppudira <mohit.muthanna [at] gmail>
original review url: <http://codereview.chromium.org/155852>

Review URL: http://codereview.chromium.org/159147
------------------------------------------------------------------------
r21206 | erg@google.com | 2009-07-21 22:17:25 +0200 (Tue, 21 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h

GTK: Popup notification is readable with dark themes in chrome theme mode.

Review URL: http://codereview.chromium.org/155860
------------------------------------------------------------------------
r21205 | thakis@chromium.org | 2009-07-21 22:17:14 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_shelf_view.mm

Make download shelf themeable.

BUG=none
TEST=Install a theme, notice that the download shelf now at least somewhat fits with the new theme.
Review URL: http://codereview.chromium.org/159126
------------------------------------------------------------------------
r21203 | estade@chromium.org | 2009-07-21 21:51:24 +0200 (Tue, 21 Jul 2009) | 100 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp

This change list improves IME support on Linux. Many corner cases that were not
handled in original code are addressed, for example the input method in password
box case.

The most important change in this CL is the change to key event processing flow.
 In old code, a key event will first be sent to webkit then dispatched to IME
for filtering. With this CL, a key event will first be dispatched to IME for
filtering, then how to send the event to webkit is decided by the filtering
result.

This CL tries to emulate the keyboard input behavior on Windows as much as
possible. For example, if a keydown event is filtered by IME, then its virtual
key code will be changed to VK_PROCESSKEY(0xE5) to prevent webkit from
processing it again. This behavior can workaround bug 16281.

To test this CL, you may cut and save following html code into a file and open
it in chrome.
------------------8<----cut here----->8---------------------
<html><head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">

<script>
function keyEventHandler(event) {
  var props = [ "type", "charCode", "keyCode", "altKey",
    "ctrlKey", "shiftKey", "metaKey" ];
  var info = document.getElementById('info');
  var s = '';
  for (var i in props) {
    s += props[i] + ':' + event[props[i]] + ' ';
  }
  info.value += s + '\n';
}

function textEventHandler(event) {
  info.value += "type:" + event['type'] + " data:" + event['data'] + '\n';
}

function passwordChangeEventHandler(event) {
  var input2 = document.getElementById('input2');
  info.value += "password:" + input2.value + '\n';
}

function onLoad() {
  var input = document.getElementById('input');
  input.addEventListener('keydown', keyEventHandler, false);
  input.addEventListener('keyup', keyEventHandler, false);
  input.addEventListener('keypress', keyEventHandler, false);
  input.addEventListener('textInput', textEventHandler, false);
  var input2 = document.getElementById('input2');
  input2.addEventListener('change', passwordChangeEventHandler, false);
}
</script>
</head><body onload="onLoad()">
<input id="input" size="20">
<input id="input2" type="password" size="20">
<p>
<textarea id="info" rows="40" cols="150"></textarea>
</p></body></html>
------------------8<----cut here----->8---------------------

This CL was confirmed to fix following issues:
BUG=16281 "arrow keys and backspace/delete keys move/delete two characters at a
time when xim immodule is used"
BUG=16282 "Disable IMEs in a password input"
BUG=16596 "fcitx (chinese input method) not working in ubuntu 9.04"
BUG=16659 "Crash near RenderWidgetHostViewGtk::IMEUpdateStatus"
BUG=16699 "Can't move cursor to omnibox and use input method if cursor is
currently in a text input box in web page."
BUG=16796 "Input method issue: When inputting text in a text box, if there is a
composition string then pressing Backspace or Delete will cause the composition
string be cleared and the text box refuses to accept any further input.

All tests assume above html code is used.
TEST=Start scim with "scim -d" and start chrome with GTK_IM_MODULE=xim and
XMODIFIERS=@im=SCIM. Type something in input box, eg. "hello", then press
backspace, to see if only one character is deleted.
TEST=Move cursor to password input box, press ctrl-space to see if input method
is not activated. Switch keyboard layout to Canadian-French then type a'[{' key
and an 'a' key, then press enter, to see if a Latin character "U+00E2" is
inputted in password box.
TEST=Install fcitx with "sudo apt-get install fcitx" (assume you are using
Ubuntu/Debian). Open a terminal, export XMODIFIERS=@im=fcitx and
GTK_IM_MODULE=xim then run fcitx, then start chrome. Move cursor into an input
box, press ctrl-space and input something, eg. "nihao" then press space. Check
if some Chinese characters are inputted.
TEST=Start chrome with GTK_IM_MODULE=scim. Move cursor into a text input box
then move into a password box, chrome should not crash.
TEST=Move cursor into a text input box, then click omnibox, and see if the text
input box has lost focus. Press ctrl-space to activate input method, then type
something, and see of the input goes into omnibox.
TEST=Move cursor into a text input box and enable a Chinese Pinyin input method,
then type something, eg. "dajiahao", make sure a composition string is displayed
in the text input box, then press backspace and see if there is still a
composition string and backspace is handled by input method.

patch by James Su <james.su [at] gmail>
original review URL: <http://codereview.chromium.org/149755>


Review URL: http://codereview.chromium.org/155869
------------------------------------------------------------------------
r21202 | ben@chromium.org | 2009-07-21 21:50:42 +0200 (Tue, 21 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.cc

Fix two crashers with TOOLKIT_VIEWS build:

- NativeViewHostGtk::RemovedFromWidget crashes due to WidgetGtk::window_contents_ being NULL... basically when RemovedFromWidget is called from the RootView's dtor, the window_contents_ and widget_ properties of the containing WidgetGtk are NULL. It seems acceptable to not clean up in this case.
- TabContentsViewGtk dtor needs to call CloseNow(). This is similar to ~TabContents() calling DestroyWindow on the view's HWND. Without this, the TabContentsViewGtk object was destroyed but the corresponding GtkWidget wasn't, and so subsequent signal handlers would crash.

BUG=none
TEST=none 
Review URL: http://codereview.chromium.org/159130
------------------------------------------------------------------------
r21201 | thakis@chromium.org | 2009-07-21 21:41:53 +0200 (Tue, 21 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/DownloadItem.xib
   M /trunk/src/chrome/app/nibs/DownloadShelf.xib
   A /trunk/src/chrome/browser/cocoa/download_item_cell.h
   A /trunk/src/chrome/browser/cocoa/download_item_cell.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/chrome.gyp

Use a real download item.

BUG=14659,17100
TEST=Download multiple things. Items should now be inserted from the left. When a download is in progress, the time to completion should be displayed, when it's done the time should fade out and the filename should move down. Download items should appear in a sweep animation. Clicking the download directly should open it; clicking the arrow on the right of the download item should show the correct context menu. If a download filename is long, it should be elided in the middle.

Review URL: http://codereview.chromium.org/159060
------------------------------------------------------------------------
r21200 | erg@google.com | 2009-07-21 21:21:50 +0200 (Tue, 21 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK Themes: Get text color from a label object; this should fix some theme text problems.

GTK Themes can set colors on a per widget basis, and many do. Previously we were getting
the text color from a GtkWindow object, which sometimes is wrong--the theme just sets the
text color on labels...

Review URL: http://codereview.chromium.org/159143
------------------------------------------------------------------------
r21199 | avi@chromium.org | 2009-07-21 21:15:04 +0200 (Tue, 21 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/starred.pdf
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Add theme support for the yellow star on the Mac.

BUG=none
TEST=go to a bookmarked page; the outline of the yellow star should be themed

Review URL: http://codereview.chromium.org/155851
------------------------------------------------------------------------
r21192 | shess@chromium.org | 2009-07-21 20:13:32 +0200 (Tue, 21 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm

[Mac] Detect control-key changes in autocomplete field.

http://crbug.com/10934
TEST=Type 'something', and press Control.  Autocomplete should show www.something.com at the top.  If that's what you'd get anyhow, try a different word.  Control-enter should take you there.

Review URL: http://codereview.chromium.org/159105
------------------------------------------------------------------------
r21190 | shess@chromium.org | 2009-07-21 20:06:20 +0200 (Tue, 21 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm

[Mac] Prevent the field from updating the font panel and any ruler state.

Review URL: http://codereview.chromium.org/155816
------------------------------------------------------------------------
r21189 | jcampan@chromium.org | 2009-07-21 19:57:46 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.h
   A /trunk/src/views/controls/tabbed_pane
   A /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.cc
   A /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_win.h
   A /trunk/src/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h
   A /trunk/src/views/controls/tabbed_pane/tabbed_pane.cc (from /trunk/src/views/controls/tabbed_pane.cc:20790)
   A /trunk/src/views/controls/tabbed_pane/tabbed_pane.h (from /trunk/src/views/controls/tabbed_pane.h:20790)
   D /trunk/src/views/controls/tabbed_pane.cc
   D /trunk/src/views/controls/tabbed_pane.h
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/views.gyp

Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view.

BUG=None
TEST=Make sure the Options dialog still works as expected (tab selection, focus traversal...)
Review URL: http://codereview.chromium.org/155668
------------------------------------------------------------------------
r21187 | tc@google.com | 2009-07-21 19:43:06 +0200 (Tue, 21 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc

Fix another d&d crash that happens when the tab contents
is swapped out while a drag is happening.

Since the tab contents is swapped out, our RVH that the drag
started on is no longer valid.  Simply null out the pointer
and no longer try to send feedback to the drag source.  This
allows the user to continue the drag even though the source
RVH is gone.

BUG=16073

Review URL: http://codereview.chromium.org/159040
------------------------------------------------------------------------
r21185 | paul@chromium.org | 2009-07-21 19:34:23 +0200 (Tue, 21 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm

Fix for the URL status bubble overlapping the download shelf.

BUG=14662 (http://crbug.com/14662)
TEST=Download something so that the shelf is visible and make sure
     that hovering over links on the page produce a status bubble
     above the download shelf.
Review URL: http://codereview.chromium.org/155706
------------------------------------------------------------------------
r21183 | erg@google.com | 2009-07-21 18:55:08 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK Themes: In GTK mode, bookmark buttons should be the same size as "Other bookmarks".

Disable all possible things a theme can do to make this false on the GtkToolbar widget.

Review URL: http://codereview.chromium.org/155821
------------------------------------------------------------------------
r21182 | agl@chromium.org | 2009-07-21 18:53:46 +0200 (Tue, 21 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/renderer_preferences.h
   M /trunk/src/chrome/renderer/render_view.cc

Linux: pass users' font settings through to renderer.

The renderer doesn't give the settings to Skia yet -- that'll
go in after agl's work on hinting and subpixel rendering in Skia.

http://codereview.chromium.org/155787

(Patch by Dan Erat)

------------------------------------------------------------------------
r21157 | jorlow@chromium.org | 2009-07-21 05:23:40 +0200 (Tue, 21 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   A /trunk/src/webkit/api/src/StorageNamespaceProxy.cpp
   A /trunk/src/webkit/api/src/StorageNamespaceProxy.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/webkit.gyp

Enable DOM_STORAGE in our build.  Put LocalStorage and SessionStorage behind their own flags.  Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.--enable-local-storage and --enable-session-storage are the new flags.  If you enable them and try to use DOM Storage, Chromium will crash.Originally Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=21059 but then backed out due to include path issues.BUG=4360TEST=none
Review URL: http://codereview.chromium.org/159059
------------------------------------------------------------------------
r21154 | hclam@chromium.org | 2009-07-21 04:50:38 +0200 (Tue, 21 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/media/audio/audio_output.h
   M /trunk/src/media/audio/fake_audio_output_stream.cc
   M /trunk/src/media/audio/fake_audio_output_stream.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/audio_manager_linux.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.h
   M /trunk/src/media/audio/mac/audio_manager_mac.cc
   M /trunk/src/media/audio/mac/audio_manager_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/simple_sources_unittest.cc
   M /trunk/src/media/audio/win/audio_manager_win.h
   M /trunk/src/media/audio/win/audio_output_win.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/media.gyp

Revert r21137 to fix Chromium mac valgrind
TBR=scherkus

Review URL: http://codereview.chromium.org/159122
------------------------------------------------------------------------
r21152 | mattm@chromium.org | 2009-07-21 04:38:08 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Add link button for certificate management, linking to wiki page LinuxCertManagement

BUG=11507

Review URL: http://codereview.chromium.org/159115
------------------------------------------------------------------------
r21148 | evan@chromium.org | 2009-07-21 03:59:42 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

linux: use tiny font in tab strip

BUG=15864

Review URL: http://codereview.chromium.org/159119
------------------------------------------------------------------------
r21144 | mdm@chromium.org | 2009-07-21 03:29:04 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/tools/build/linux/chrome-wrapper

Linux: allow the desktop file name to be given in an environment variable for development Chromium builds, to avoid conflicting with packaged Chromium.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159108
------------------------------------------------------------------------
r21143 | estade@chromium.org | 2009-07-21 03:22:05 +0200 (Tue, 21 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Lop off the bottom pixel from the tab images.

The problem is that windows draws the tabstrip with a 1 pixel overlap on the toolbar, which we don't do. Instead (for now at least), just don't draw the bottom pixel of the tab. This makes the tabs 1 pixel shorter (matching windows).

BUG=13884
TEST=none

Review URL: http://codereview.chromium.org/155804
------------------------------------------------------------------------
r21141 | estade@chromium.org | 2009-07-21 03:21:43 +0200 (Tue, 21 Jul 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

Info bubble focus tweaks.

We can't close info bubbles when they lose focus because then we can't use the select dropdown in the bookmark bubble. Thus we have to watch the active window. Since we are doing this, we no longer need the application level grab or the button press handler.

This also fixes the problem that a browser window showing an info bubble will paint inactive (assuming your WM supports active/inactive windows).

This maintains the desirable properties:
- info bubbles close when you click outside them but inside the parent window
- info bubbles close when the parent window closes
- info bubbles don't show up on alternate desktops (even if your WM doesn't support active/inactive windows)
- info bubbles can survive losing focus to a popup window

This breaks the desirable properties:
- clicking on something in the browser while the info bubble is showing both dismisses the info bubble and does the appropriate action in the browser
- the info bubble dismisses when the browser loses focus in a window manager that doesn't support active/inactive state
- on xmonad, if you have the cursor over the browser window but the focus is on the info bubble (this is hard to do, since focus is supposed to follow the mouse, but not impossible), then it requires two clicks to dismiss the info bubble. But I think that this is a problem with xmonad and is present before this patch as well.

So this is not the best of all possible worlds, but it is an improvement over our current state as well as an improvement over the state before r20977.

BUG=17223
TEST=browser doesn't crash when you open the select dropdown in the bookmark bubble

Review URL: http://codereview.chromium.org/155793
------------------------------------------------------------------------
r21140 | evan@chromium.org | 2009-07-21 03:18:18 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h

linux: implement encodings menu

BUG=11599

Review URL: http://codereview.chromium.org/155830
------------------------------------------------------------------------
r21139 | brettw@chromium.org | 2009-07-21 03:14:18 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/panels/panel_scroller.cc
   M /trunk/src/chrome/browser/views/panels/panel_scroller.h
   M /trunk/src/chrome/browser/views/panels/panel_scroller_header.cc
   M /trunk/src/chrome/browser/views/panels/panel_scroller_header.h

Fix some problems with my panel scroller.

These problems were caused by me addressing review comment and forgetting to compile before checkin.

Review URL: http://codereview.chromium.org/159114
------------------------------------------------------------------------
r21137 | hclam@chromium.org | 2009-07-21 03:05:18 +0200 (Tue, 21 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/media/audio/audio_output.h
   A /trunk/src/media/audio/fake_audio_output_stream.cc
   A /trunk/src/media/audio/fake_audio_output_stream.h
   M /trunk/src/media/audio/linux/alsa_output.cc
   M /trunk/src/media/audio/linux/alsa_output.h
   M /trunk/src/media/audio/linux/audio_manager_linux.cc
   M /trunk/src/media/audio/linux/audio_manager_linux.h
   M /trunk/src/media/audio/mac/audio_manager_mac.cc
   M /trunk/src/media/audio/mac/audio_manager_mac.h
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/simple_sources_unittest.cc
   M /trunk/src/media/audio/win/audio_manager_win.h
   M /trunk/src/media/audio/win/audio_output_win.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h
   M /trunk/src/media/media.gyp

Refactoring to share MockAudioOutputStream implementations across 3 platforms

Review URL: http://codereview.chromium.org/155471
------------------------------------------------------------------------
r21136 | ben@chromium.org | 2009-07-21 02:34:36 +0200 (Tue, 21 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix GTK/Mac builds.

Review URL: http://codereview.chromium.org/155826
------------------------------------------------------------------------
r21132 | ben@chromium.org | 2009-07-21 02:15:50 +0200 (Tue, 21 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/page_info_window_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/window/window.h

Resurrect toolkit_views build.

Review URL: http://codereview.chromium.org/155797
------------------------------------------------------------------------
r21131 | brettw@chromium.org | 2009-07-21 02:04:08 +0200 (Tue, 21 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Fix Linux startup crash.

When there is no existing browser, this code will crash. It only works
because of the Linux splash screen.

Original review=http://codereview.chromium.org/155795
R=agl
TEST=none

Review URL: http://codereview.chromium.org/155822
------------------------------------------------------------------------
r21129 | mdm@chromium.org | 2009-07-21 01:38:14 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Make standard input /dev/null when running xdg-settings to set the default browser.
BUG=17219
TEST=run chrome from a terminal in KDE and use the "set as default browser" feature when ~/.kde/share/config/profilerc is owned by root; chrome should not freeze

Review URL: http://codereview.chromium.org/155796
------------------------------------------------------------------------
r21128 | rohitrao@chromium.org | 2009-07-21 01:35:24 +0200 (Tue, 21 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/InfoBar.xib
   M /trunk/src/chrome/browser/cocoa/infobar_controller.h
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   A /trunk/src/chrome/browser/cocoa/infobar_gradient_view.h (from /trunk/src/chrome/browser/cocoa/background_gradient_view.h:21067)
   A /trunk/src/chrome/browser/cocoa/infobar_gradient_view.mm (from /trunk/src/chrome/browser/cocoa/background_gradient_view.mm:21067)
   A /trunk/src/chrome/browser/cocoa/infobar_gradient_view_unittest.mm (from /trunk/src/chrome/browser/cocoa/background_gradient_view_unittest.mm:21067)
   M /trunk/src/chrome/chrome.gyp

Infobar UI cleanup on Mac.  Adds the yellow background gradient and
centers all of the buttons.

Also adds the ok/cancel buttons to the xib file.  Infobars that do not
need the buttons can remove them from the view before displaying.

BUG=http://crbug.com/14462
BUG=http://crbug.com/17195
TEST=Infobars should have yellow background, look less ugly.

Review URL: http://codereview.chromium.org/155788
------------------------------------------------------------------------
r21127 | erg@google.com | 2009-07-21 01:13:02 +0200 (Tue, 21 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Fix Browser::IsApplication so it conforms to the TabContentsDelegate interface.

This was showing up as a BAD_OVERRIDE in Coverity.

http://crbug.com/18296

Review URL: http://codereview.chromium.org/155810
------------------------------------------------------------------------
r21125 | shess@chromium.org | 2009-07-21 01:04:52 +0200 (Tue, 21 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Strip newlines from paste.

http://crbug.com/11817
TEST=Copy an URL somewhere and break it apart with newlines at random places.  Copy/paste it into omnibox and the newlines should be gone.  Try this one:

http://dev.chro
mium.org/develo
pers/how-tos/ge
t-the-code

Review URL: http://codereview.chromium.org/159018
------------------------------------------------------------------------
r21121 | jrg@chromium.org | 2009-07-21 00:53:21 +0200 (Tue, 21 Jul 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Don't make all bookmark buttons the same width.
Make thinner if possible.
Feelin luv 4 pink.

BUG=http://crbug.com/16942

TEST=2 main parts:
1)
Create bookmarks (click 'Star').
Make sure long titles get trimmed.
Make sure small titles have smaller buttons and text does NOT get trimmed.
Quit and launch with bookmark bar open.
Make sure things are still fine (icons load after bar first assembled).
2)
Quit Chromium.
Rename a LONG button title by editing ~/Library/Application Support/Chromium/Default/Bookmarks.
Relaunch Chromium.
Make sure the button is now smaller but is not "trimmed" (e.g. all the text is there).
Repeat for 5 buttons with different short (5-10 char) titles on each.
Make sure the buttons are smaller and the text is NOT trimmed.


Review URL: http://codereview.chromium.org/155712
------------------------------------------------------------------------
r21120 | erg@google.com | 2009-07-21 00:52:52 +0200 (Tue, 21 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK Themes: Fix spacing so page and app menus take up full height in GTK theme mode.

Review URL: http://codereview.chromium.org/159103
------------------------------------------------------------------------
r21119 | phajdan.jr@chromium.org | 2009-07-21 00:35:32 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Add missing TemplateURL include.

TBR=brettw

Review URL: http://codereview.chromium.org/159102
------------------------------------------------------------------------
r21118 | phajdan.jr@chromium.org | 2009-07-21 00:28:42 +0200 (Tue, 21 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Hopefully fix Windows release compile.

TBR=brettw

Review URL: http://codereview.chromium.org/155813
------------------------------------------------------------------------
r21117 | jam@chromium.org | 2009-07-21 00:20:20 +0200 (Tue, 21 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/histogram_synchronizer.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/utility/utility_main.cc
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h

Switch the first thread in a child process to be the main thread, and make the IO thread be the second thread.  The change is needed for plugins on mac.
Review URL: http://codereview.chromium.org/149558
------------------------------------------------------------------------
r21116 | phajdan.jr@chromium.org | 2009-07-21 00:18:42 +0200 (Tue, 21 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_model_observer.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_linux.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/mork_reader.h
   M /trunk/src/chrome/browser/views/importer_lock_view.cc

Header cleanup in browser/importer

- forward declare more things
- move bits from header to implementation files to cut includes
- extract bookmark_model_observer.h out of bookmark_model.h to reduce includes

Review URL: http://codereview.chromium.org/159097
------------------------------------------------------------------------
r21114 | phajdan.jr@chromium.org | 2009-07-21 00:07:32 +0200 (Tue, 21 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/panel_controller.cc

Fix misleading name and comment of Browser::GetCurrentPageTitle.

GetWindowTitleForCurrentTab more accurately describes what this function really does.

TEST=none
http://crbug.com/16231

Review URL: http://codereview.chromium.org/155534
------------------------------------------------------------------------
r21113 | tc@google.com | 2009-07-21 00:06:36 +0200 (Tue, 21 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

When we save the window bounds, make sure we are only storing the
non-maximized and non-fullscreen bounds.  We still keep track of
whether the window is maximized or not, but this allows restoring
a maximized browser to go back to it's previous state.

This also fixes a bug where we would confuse window managers by
setting the initial window size to the full desktop would cause
WMs to disable resize/move.

BUG=16602

Review URL: http://codereview.chromium.org/155802

------------------------------------------------------------------------
r21110 | jrg@chromium.org | 2009-07-20 23:51:27 +0200 (Mon, 20 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

File dropped off a popup CL :-(

TEST=A few things.
Bookmark bar test (16063):
- open bookmark bar, then open popup.  Popup should not have bmb.
- close bookmark bar, then open popup.  Popup should not have bmb.
- In main window, toggle bmb a few times.  Popup should not change.
Tab at bottom bug (16329):
- Open 'details' popup in gmail (next to 'last acct activity')
- make sure no tab strip at the bottom of the window
General (15727):
- Open a popup.  Make sure no toolbar (back/fwd buttons et al)

Test: same as listed in 
Review URL: http://codereview.chromium.org/155785
------------------------------------------------------------------------
r21107 | asargent@chromium.org | 2009-07-20 23:26:36 +0200 (Mon, 20 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Re-enable extensions auto-update.

BUG=12117
TEST=none

Review URL: http://codereview.chromium.org/159085
------------------------------------------------------------------------
r21103 | tc@google.com | 2009-07-20 23:12:28 +0200 (Mon, 20 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Change fullscreen mode to be determined by the window manager.
We used to have a bool that determined whether we were in full
screen mode or not, but that's not always in sync with the WM
so wait for the WM to tell us that we're in full screen mode.

Also, change it so when we're in full screen mode, we don't save our
window bounds because that causes us to restart in full screen mode
which is all sorts of broken.

BUG=16602

Review URL: http://codereview.chromium.org/159087

------------------------------------------------------------------------
r21102 | mpcomplete@chromium.org | 2009-07-20 23:05:37 +0200 (Mon, 20 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/test/testing_profile.h

Changed the extension.connect() API not to broadcast to all tabs.  Added a
more specific tabs.connect(tabId) API to connect to a specific tab.

Also changed the ExtensionMessageService from a singleton to a Profile-owned object.

BUG=12461
TEST=no

Review URL: http://codereview.chromium.org/155707
------------------------------------------------------------------------
r21101 | mdm@chromium.org | 2009-07-20 22:50:45 +0200 (Mon, 20 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration_linux.cc

Pretend we're the default browser when xdg-settings fails.
BUG=16981
TEST=use an unsupported desktop environment (like awesome) and start chrome; it should not ask about setting itself as the default

Review URL: http://codereview.chromium.org/159086
------------------------------------------------------------------------
r21100 | stuartmorgan@google.com | 2009-07-20 22:45:09 +0200 (Mon, 20 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h

Change GetAllLogins to GetAllBlacklistLogins.

BUG=none
TEST=accessing the list of passwords and password blacklists should still work.

Review URL: http://codereview.chromium.org/149778
------------------------------------------------------------------------
r21099 | evan@chromium.org | 2009-07-20 22:39:31 +0200 (Mon, 20 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

linux: remove unimplemented menu items

Review URL: http://codereview.chromium.org/155786
------------------------------------------------------------------------
r21097 | agl@chromium.org | 2009-07-20 22:30:07 +0200 (Mon, 20 Jul 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/sandbox_methods_linux.h

Linux sandbox: plumb timezone calls through the sandbox

The localtime (and localtime_r) functions try to access /etc/localtime
in the filesystem. For sandboxed renderers, this fails, the the
functions default to a UTC timezone.

These functions are called from within WebCore and V8 and there's no
clean way to patch the source code in place to do a hairpin turn and
manage an IPC. Additionally, we cannot overwrite the calls with the
usual symbol resolution procedures since the same chrome binary must
serve as both the unsandboxed browser and sandboxed renderer.

Thus we patch the GOT at runtime if we find, in the zygote process,
that we are sandboxed.

BUG=16800
TEST=Run javascript:alert(new Date().getTimezoneOffset()) in a sandboxed renderer. The resulting timezone offset (in minutes) should be correct for the local timezone.

------------------------------------------------------------------------
r21096 | jhawkins@chromium.org | 2009-07-20 22:29:15 +0200 (Mon, 20 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

gtk: Set the task manager scrolled window policy to GTK_POLICY_AUTOMATIC so that the task manager window is not resized when a page with a long title is viewed.

BUG=17079
TEST=Open the task manager after navigating to a site with a long page title.  The task manager window should not resize to fit the title.
Review URL: http://codereview.chromium.org/159081
------------------------------------------------------------------------
r21095 | arv@google.com | 2009-07-20 22:28:37 +0200 (Mon, 20 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc

Adds timestamp to session restore for tabs and windows.

BUG=13134

TEST=None

Review URL: http://codereview.chromium.org/155609
------------------------------------------------------------------------
r21094 | erg@chromium.org | 2009-07-20 22:26:11 +0200 (Mon, 20 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc

Make sure the popup notification is shown during animation.

(I don't see a call to hide between the first show and the
animation, but this fixes it so it must be getting called...)

http://crbug.com/14062

Review URL: http://codereview.chromium.org/155717
------------------------------------------------------------------------
r21092 | brettw@chromium.org | 2009-07-20 22:21:53 +0200 (Mon, 20 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   A /trunk/src/chrome/browser/views/panels
   A /trunk/src/chrome/browser/views/panels/panel_scroller.cc
   A /trunk/src/chrome/browser/views/panels/panel_scroller.h
   A /trunk/src/chrome/browser/views/panels/panel_scroller_container.cc
   A /trunk/src/chrome/browser/views/panels/panel_scroller_container.h
   A /trunk/src/chrome/browser/views/panels/panel_scroller_header.cc
   A /trunk/src/chrome/browser/views/panels/panel_scroller_header.h
   M /trunk/src/chrome/chrome.gyp

Add a simple "sidebar"-like panel container that will scroll.

This doesn't actually hold any panels at the moment, just dummy content.

Review URL: http://codereview.chromium.org/155593
------------------------------------------------------------------------
r21088 | meelapshah@chromium.org | 2009-07-20 22:03:09 +0200 (Mon, 20 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Write ThumbnailStore's cache to disk on browser shutdown.

Review URL: http://codereview.chromium.org/155729
------------------------------------------------------------------------
r21071 | pfeldman@chromium.org | 2009-07-20 12:16:08 +0200 (Mon, 20 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js

DevTools: Disable dock action on Mac OS since it is not yet implemented.
BUG=15936

Review URL: http://codereview.chromium.org/155765
------------------------------------------------------------------------
r21070 | pfeldman@chromium.org | 2009-07-20 10:57:55 +0200 (Mon, 20 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

DevTools: Store devtools split location on Linux.

Review URL: http://codereview.chromium.org/149748
------------------------------------------------------------------------
r21066 | erg@chromium.org | 2009-07-19 22:03:34 +0200 (Sun, 19 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.h

Fix native GTK interface.

In r21039, BrowserThemeProvider::Init was made non-virtual, which meant
that GtkBrowserThemeProvider::Init was never being called. Make it virtual
again (so the linux UI renders properly), and explicitly add Init() to the
ThemeProvider interface so this doesn't happen again.

Review URL: http://codereview.chromium.org/155754
------------------------------------------------------------------------
r21065 | jcampan@chromium.org | 2009-07-19 09:37:12 +0200 (Sun, 19 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/page_info_model.cc (from /trunk/src/chrome/browser/page_info_model.cc:21034)
   A /trunk/src/chrome/browser/page_info_model.h (from /trunk/src/chrome/browser/page_info_model.h:21034)
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   A /trunk/src/chrome/browser/views/page_info_window_view.cc (from /trunk/src/chrome/browser/views/page_info_window_view.cc:21034)
   D /trunk/src/chrome/browser/views/page_info_window_win.cc
   D /trunk/src/chrome/browser/views/page_info_window_win.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/test_browser_window.h

Relanding the the refactoring the page info to have a model.

BUG=None
TEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well.
TBR=ben
Review URL: http://codereview.chromium.org/155753
------------------------------------------------------------------------
r21060 | jorlow@chromium.org | 2009-07-18 19:37:05 +0200 (Sat, 18 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   D /trunk/src/webkit/api/src/StorageNamespaceProxy.cpp
   D /trunk/src/webkit/api/src/StorageNamespaceProxy.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/webkit.gyp

Reverting 21059.
Review URL: http://codereview.chromium.org/159056
------------------------------------------------------------------------
r21059 | jorlow@chromium.org | 2009-07-18 19:02:08 +0200 (Sat, 18 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   A /trunk/src/webkit/api/src/StorageNamespaceProxy.cpp
   A /trunk/src/webkit/api/src/StorageNamespaceProxy.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/webkit.gyp

Enable DOM_STORAGE in our build.  Put LocalStorage and SessionStorage behind their own flags.  Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.

--enable-local-storage and --enable-session-storage are the new flags.  If you enable them and try to use DOM Storage, Chromium will crash.

BUG=4360
TEST=none

Review URL: http://codereview.chromium.org/149792
------------------------------------------------------------------------
r21052 | ericroman@google.com | 2009-07-18 09:31:04 +0200 (Sat, 18 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/host_resolver_proc.h
   M /trunk/src/net/base/mock_host_resolver.cc
   M /trunk/src/net/base/mock_host_resolver.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc

Add synchronous-mode operation to MockHostResolver; this helps clarify some tests, which were using caching to get synchronous resolutions.TEST=existingBUG=NONE (addresses a TODO however).
Review URL: http://codereview.chromium.org/155620
------------------------------------------------------------------------
r21048 | jar@chromium.org | 2009-07-18 08:17:19 +0200 (Sat, 18 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Change DNS field trial to focus on congestion window setting

Stats suggest that optimal boundary for congestion detection
in DNS pre-resolution may be under 1 second.  This change
focuses the field trial on that region.

r=willchan
Review URL: http://codereview.chromium.org/155723
------------------------------------------------------------------------
r21047 | jar@chromium.org | 2009-07-18 08:00:38 +0200 (Sat, 18 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Clear yet another few stats when a new chrome version is installed

Re-review with Laforge found that three stats were registered, but not
cleared when we create a new version.  This CL clears those stats.

I also cleaned a tiny fragment that relates to one stat (moving the
setting of the stat into a conditional... which may make code more 
readable).


r=huanr
Review URL: http://codereview.chromium.org/155722
------------------------------------------------------------------------
r21045 | ben@chromium.org | 2009-07-18 07:11:33 +0200 (Sat, 18 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/window/window_win.cc

Fix frame turning black when reseting theme. Also simplifies the frame
type changed code somewhat. It turns out the frame still needs to be hidden
for WM_DWMCOMPOSITIONCHANGED message handlers however. Not sure why, but
this is the simplest/least buggy this code has been so far so I can live with
it.

http://crbug.com/14578
TEST=see bug

Review URL: http://codereview.chromium.org/159050
------------------------------------------------------------------------
r21041 | evan@chromium.org | 2009-07-18 05:25:32 +0200 (Sat, 18 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc

linux: print something when reusing an existing process

Since it's common start Chrome from the command line, we should print
something to indicate that it's intentionally quitting immediately.
This is the source of a lot of bug reports.

BUG=12918

Review URL: http://codereview.chromium.org/155740
------------------------------------------------------------------------
r21040 | mirandac@chromium.org | 2009-07-18 05:24:06 +0200 (Sat, 18 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Move product logo down so that it sits nicely on the NNTP.

BUG= http://crbug/com/16182
TEST= Open new tab page.  Observe that logo sits nicely on the page, even when hovering over the thumbnail in the upper left corner.

Review URL: http://codereview.chromium.org/159024
------------------------------------------------------------------------
r21039 | mirandac@chromium.org | 2009-07-18 05:23:33 +0200 (Sat, 18 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Allow the tiling of theme background images on the NTP.

BUG= http://crbug/com/15796
TEST= Add a property for tiling to a theme manifest.json.  Observe that the theme image is tiled on the NTP.

Review URL: http://codereview.chromium.org/149741
------------------------------------------------------------------------
r21035 | jcampan@chromium.org | 2009-07-18 02:45:39 +0200 (Sat, 18 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   D /trunk/src/chrome/browser/page_info_model.cc
   D /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   D /trunk/src/chrome/browser/views/page_info_window_view.cc
   A /trunk/src/chrome/browser/views/page_info_window_win.cc (from /trunk/src/chrome/browser/views/page_info_window_win.cc:21031)
   A /trunk/src/chrome/browser/views/page_info_window_win.h (from /trunk/src/chrome/browser/views/page_info_window_win.h:21031)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/test_browser_window.h

Reverting 21032.
It breaks the release build on Windows.

TBR=ben
Review URL: http://codereview.chromium.org/155736
------------------------------------------------------------------------
r21033 | mattm@chromium.org | 2009-07-18 02:34:56 +0200 (Sat, 18 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc

Revert "Add proxy config (using gnome-network-preferences)"

This reverts commit d06bc0c855b1e81e36c7bfc9bef342eb358d99a5.

TBR=estade
------------------------------------------------------------------------
r21032 | jcampan@chromium.org | 2009-07-18 02:34:06 +0200 (Sat, 18 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   M /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/page_info_model.cc
   A /trunk/src/chrome/browser/page_info_model.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   A /trunk/src/chrome/browser/views/page_info_window_view.cc (from /trunk/src/chrome/browser/views/page_info_window_win.cc:20376)
   D /trunk/src/chrome/browser/views/page_info_window_win.cc
   D /trunk/src/chrome/browser/views/page_info_window_win.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/test_browser_window.h

Refactoring the page info to have a model.BUG=NoneTEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well.
Review URL: http://codereview.chromium.org/155336
------------------------------------------------------------------------
r21024 | estade@chromium.org | 2009-07-18 01:37:10 +0200 (Sat, 18 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

Another bookmark manager crash fix after r20565.

This thing really needs a ui test.

BUG=none
TEST=importer doesn't crash
TBR=munjal

Review URL: http://codereview.chromium.org/159041
------------------------------------------------------------------------
r21023 | mattm@chromium.org | 2009-07-18 01:28:08 +0200 (Sat, 18 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.cc

Add proxy config (using gnome-network-preferences)

BUG=11507
TEST=Open options, click change proxy, gnome-network-preferences should launch.  If gnome isn't installed, LinuxProxyConfig wiki page should load.

Review URL: http://codereview.chromium.org/149785
------------------------------------------------------------------------
r21022 | sky@chromium.org | 2009-07-18 01:28:02 +0200 (Sat, 18 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Two tweaks to the linux tab strip code:
. Adds a 3 pixel gap between pinned and non-pinned tabs.
. Fixes bug when rapdily dragging pinned tabs that could result in
  unpinning all tabs to right of pinned tab being dragged.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155725
------------------------------------------------------------------------
r21017 | estade@chromium.org | 2009-07-18 00:54:22 +0200 (Sat, 18 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

remove accidentally committed debugging spew

TBR=evan

Review URL: http://codereview.chromium.org/155721
------------------------------------------------------------------------
r21014 | phajdan.jr@chromium.org | 2009-07-18 00:18:50 +0200 (Sat, 18 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
   A /trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
   M /trunk/src/chrome/chrome.gyp

Begin work on extension shelf for Linux.

For now it displays only a placeholder text, but knows when to display (it's connected to the ExtensionShelfModel).

TEST=none
http://crbug.com/16759

Review URL: http://codereview.chromium.org/159019
------------------------------------------------------------------------
r21010 | estade@chromium.org | 2009-07-17 23:36:35 +0200 (Fri, 17 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

GTK: Add some missing hotkeys.

There doesn't seem to be a platform default behavior for shift+scroll (for native apps like epiphany and gedit it vertically scrolls, and for firefox it navigates the back/forward list). Likewise I can't find any default way to get gnome to send a horiztonal scroll event except by having a horiztonal scrollwheel (like on a trackpad or fancy mouse).

Also it seems like the direction ought to switch for RTL-encoded pages, but this doesn't appear to happen in windows.

Also, fix bug where a ctrl+scroll would scroll AND zoom (which you can test by scrolling to the top of the page then pressing ctrl+down wheel).

BUG=16792
TEST=horizontally scroll via shift + Scrollwheel

Review URL: http://codereview.chromium.org/149729
------------------------------------------------------------------------
r21009 | agl@chromium.org | 2009-07-17 23:36:28 +0200 (Fri, 17 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/sandbox/linux/suid/sandbox.cc
   A /trunk/src/sandbox/linux/suid/suid_unsafe_environment_variables.h
   M /trunk/src/sandbox/sandbox.gyp

Linux sandbox: save full list of SUID unsafe environment variables.

r20733 added code to save LD_LIBRARY_PATH when using the SUID sandbox.
That fixed a P0, show-stopper bug, however, LD_LIBRARY_PATH isn't the
only variable which is stomped when using SUID binaries. This patch
extends support to all variables that we so affected.

BUG=16815
http://codereview.chromium.org/159025

------------------------------------------------------------------------
r21006 | estade@chromium.org | 2009-07-17 23:31:01 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Do not block all task manager tree view mouse release events.

BUG=16974
TEST=you can resize rows of the task manager

Review URL: http://codereview.chromium.org/155670
------------------------------------------------------------------------
r20996 | rohitrao@chromium.org | 2009-07-17 22:50:27 +0200 (Fri, 17 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm

Makes enter/shift-enter find next/previous on Mac.

BUG=htp://crbug.com/14890
TEST=Cmd-F to find in page.  Type a word into the box,
then ensure that pressing Enter finds the next instance,
Shift-Enter finds the previous instance.
Review URL: http://codereview.chromium.org/149100
------------------------------------------------------------------------
r20995 | sidchat@google.com | 2009-07-17 22:49:11 +0200 (Fri, 17 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

For system-level installs, if the spellcheck dictionary fails to get downloaded in the profile Application directory, download it in the User Data directory instead.
BUG=http://www.crbug.com/9650
TEST=Launch Chrome, and navigate to translate.google.com. Before typing anything in the text box, change name of folder Chrome/Application/Dictionaries to something else. Then, start typing something. The spellcheck dictionary, unable to get the folder Dictionaries, will fail to download, which will trigger its download in Chrome/User Data/Dictionaries. After it has downloaded, spellchecker will start working automatically.
Review URL: http://codereview.chromium.org/155394
------------------------------------------------------------------------
r20994 | mattm@chromium.org | 2009-07-17 22:45:21 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc

Rename the Cancel button to Close in gtk Clear Browsing Data.

BUG=16955
TEST=Open Clear Browsing Data dialog. The button should now say Close.

Review URL: http://codereview.chromium.org/159023
------------------------------------------------------------------------
r20991 | erg@google.com | 2009-07-17 22:39:33 +0200 (Fri, 17 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc

Fix same crashy assumption that I fixed in r20967 later on in normal theme mode.

Review URL: http://codereview.chromium.org/155709
------------------------------------------------------------------------
r20989 | pinkerton@chromium.org | 2009-07-17 22:20:12 +0200 (Fri, 17 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/webkit/api/src/mac/WebInputEventFactory.mm

Flip screen coordinates when converting NSEvent to WebMouseEvent. Enable processing of events during drag.
BUG=16909, 113616
TEST=dragging thumbnails works on NTP, dragging emails in gmail.
Review URL: http://codereview.chromium.org/159021
------------------------------------------------------------------------
r20985 | sky@chromium.org | 2009-07-17 22:05:49 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Changes the width of pinned tabs to be slightly bigger.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155701
------------------------------------------------------------------------
r20978 | evan@chromium.org | 2009-07-17 20:25:42 +0200 (Fri, 17 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html

linux: splash page update

Mention how to turn on plugins.

Review URL: http://codereview.chromium.org/159016
------------------------------------------------------------------------
r20977 | kuchhal@chromium.org | 2009-07-17 20:15:59 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

This matches the behavior on Windows. Also this change lets user close Chrome by clicking 'x' button even if a popup (for example - bookmark bubble) is open.

BUG=NONE
TEST=1. Click on bookmark star button to open bookmark bubble.  Switch focus to some other Window, bubble should close automatically. 2. Click on bookmark star button to open bookmark bubble. Close chrome by clicking on Window close button ('x') and Chrome should close.

Review URL: http://codereview.chromium.org/149757
------------------------------------------------------------------------
r20973 | kuchhal@chromium.org | 2009-07-17 20:10:26 +0200 (Fri, 17 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

Need to cleanup first run dialog on cancellation too.

Fixing what r20898 broke.

Review URL: http://codereview.chromium.org/155676
------------------------------------------------------------------------
r20971 | arv@google.com | 2009-07-17 20:07:55 +0200 (Fri, 17 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

NNTP: Fix issue where focused buttons where not distinguisgable from
non focused buttons.

BUG=16973

TEST=Tab to the buttons at the top of the NNTP. They should have a
*outlined* look (same as hover).

Review URL: http://codereview.chromium.org/159013
------------------------------------------------------------------------
r20967 | erg@google.com | 2009-07-17 19:51:28 +0200 (Fri, 17 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc

Fix occasional crash at startup in gtk_chrome_button_expose.

Review URL: http://codereview.chromium.org/155697
------------------------------------------------------------------------
r20966 | estade@chromium.org | 2009-07-17 19:50:40 +0200 (Fri, 17 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc

Silence compile errors on some compilers by checking return value of fwrite.

hat tip to spotrh

BUG=16948
TEST=none

Review URL: http://codereview.chromium.org/149786
------------------------------------------------------------------------
r20965 | jshin@chromium.org | 2009-07-17 19:44:46 +0200 (Fri, 17 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Added an observer for 'pref::kDefaultCharset' change I forgot to add in r15113 (http://src.chromium.org/viewvc/chrome?view=rev&revision=15113) . 
Besides, set referrer_charset_ (used in guessing the C-D charset in GetFileNameFromCD) to pref::kDefaultCharset without any q values appended.

TEST=1. Set the default charset in Options | Advanced | Fonts & Languages to ISO-8859-1. 
     2. Type http://i18nl10n.com/moztest/random21.yyy in the omnibox and the filename in the download bar should start with "횉횗짹횤21"
     3. Change the default charset to Korean
     4. Try #2 again and the filename in the download bar should start with '?쒓?21'. 

BUG=1148 (http://crbug.com/1148 )



Review URL: http://codereview.chromium.org/149705
------------------------------------------------------------------------
r20964 | meelapshah@chromium.org | 2009-07-17 19:27:19 +0200 (Fri, 17 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Qurey redirects when a thumbnail is set.
Update list of most visited URLs on an exponential timer, resetting when the history is cleared.

Review URL: http://codereview.chromium.org/155619
------------------------------------------------------------------------
r20962 | cpu@google.com | 2009-07-17 19:17:43 +0200 (Fri, 17 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc

More bad ipc message handling for RenderWidgetHost
- For input handling so far

BUG=16673
TEST=unit test included

Review URL: http://codereview.chromium.org/155613
------------------------------------------------------------------------
r20959 | avi@chromium.org | 2009-07-17 18:53:22 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Implement SetSize for valid size requests.

BUG=http://crbug.com/15334
TEST=type in a popup containing more than one item; as the number of items decreases, the list should properly shrink and draw itself.

Review URL: http://codereview.chromium.org/155694
------------------------------------------------------------------------
r20958 | pinkerton@chromium.org | 2009-07-17 18:51:16 +0200 (Fri, 17 Jul 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/browser_window_factory.mm
   A /trunk/src/chrome/browser/cocoa/browser_window_factory.mm (from /trunk/src/chrome/browser/browser_window_factory.mm:20948)
   M /trunk/src/chrome/chrome.gyp

Move into browser/cocoa from browser/
BUG=15475
TEST=none
Review URL: http://codereview.chromium.org/155690
------------------------------------------------------------------------
r20955 | rohitrao@chromium.org | 2009-07-17 17:42:35 +0200 (Fri, 17 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   M /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt

Fixes a leak in [LinkInfoBarController addAdditionalControls].
Removes the valgrind suppression for this leak.
Valgrind: 1, rohitrao: 0

BUG=17002
TEST=No more leaky.

Review URL: http://codereview.chromium.org/159005
------------------------------------------------------------------------
r20951 | pinkerton@chromium.org | 2009-07-17 17:06:48 +0200 (Fri, 17 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker_linux.cc
   M /trunk/src/chrome/browser/spellchecker_mac.mm
   M /trunk/src/chrome/browser/spellchecker_platform_engine.h
   M /trunk/src/chrome/browser/spellchecker_win.cc

Adds languages supported by the platform spellchecker to the right
click menu. Also includes a couple of methods which will be needed 
once support for the spelling panel is finished. Patch from Paul Wicks
(pwicks86@gmail.com)
BUG=NONE
TEST=Context menu on the mac should show and allow switching between languages
for the spellchecker
------------------------------------------------------------------------
r20944 | hbono@chromium.org | 2009-07-17 13:20:00 +0200 (Fri, 17 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

A quick fix for Issue 13711 (the second part)

Because of a hard-disk problem, I lost the original change. So, I would like to send another change for this fix.

This is the second part of the fix for Issue 13711.
On non-ASCII keyboards (e.g. Russian and Hebrew), |event->keyval| represents a non-ASCII value that BrowserWindowGtk::HandleAccelerator() cannot handle.
To fix this issue, this change uses |event->hardware_keycode| to retrieve its ASCII value before calling BrowserWindowGtk::HandleAccelerator().

BUG=13711 "Alt-D does not work when in editbox"
TEST=Type alt+d keys on a Russian keyboard and verify the input focus is moved to an onmibox.
Review URL: http://codereview.chromium.org/155555
------------------------------------------------------------------------
r20942 | estade@chromium.org | 2009-07-17 09:53:47 +0200 (Fri, 17 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Set window icon on task manager.

patch by <joel.stan@gmail.com>

original review url: http://codereview.chromium.org/155677

Review URL: http://codereview.chromium.org/149797
------------------------------------------------------------------------
r20941 | aa@chromium.org | 2009-07-17 09:51:06 +0200 (Fri, 17 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_constants.cc
   M /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/icon_128.png
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json

A small start: add icons to the extension manifest.

Review URL: http://codereview.chromium.org/155662
------------------------------------------------------------------------
r20938 | darin@chromium.org | 2009-07-17 08:21:57 +0200 (Fri, 17 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   A /trunk/src/webkit/api/public/WebLocalizedString.h
   A /trunk/src/webkit/api/src/LocalizedStrings.cpp (from /trunk/src/webkit/glue/localized_strings.cc:20870)
   D /trunk/src/webkit/glue/localized_strings.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/webkit.gyp

Introduce WebLocalizedString and queryLocalizedString methods
on WebKitClient.  This allows glue/localized_strings.cc to move
into the WebKit API implementation.

BUG=16933
TEST=none
R=dglazkov

Review URL: http://codereview.chromium.org/149760
------------------------------------------------------------------------
r20936 | thestig@chromium.org | 2009-07-17 07:55:51 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/base/linux_util.cc
   M /trunk/src/base/linux_util.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Include output of "lsb_release -d" in crash reports.

/etc/lsb-release does not exist on all distros, and sometimes it does
not provide any useful info. Whereas all LSB complaint distros return
useful data with the lsb_release command.
Review URL: http://codereview.chromium.org/155653
------------------------------------------------------------------------
r20935 | sky@chromium.org | 2009-07-17 07:14:13 +0200 (Fri, 17 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore.cc

Makes --pinned-tab-count work if session restore is enabled, but we
don't restore anything.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155667
------------------------------------------------------------------------
r20931 | ajwong@chromium.org | 2009-07-17 05:23:46 +0200 (Fri, 17 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/api/public/WebMediaPlayer.h
   M /trunk/src/webkit/api/src/WebMediaPlayerClientImpl.cpp
   M /trunk/src/webkit/api/src/WebMediaPlayerClientImpl.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.cc
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Begin implementation of the context menu for Video and Audio tags.

This code should enable the creation of a basic context menu for the Video and Audio tags.  The actions for fullscreen, save screenshot, loop, and set playback rate are not yet implemented.

BUG=15686
TEST=None

Review URL: http://codereview.chromium.org/149604
------------------------------------------------------------------------
r20930 | rohitrao@chromium.org | 2009-07-17 05:16:58 +0200 (Fri, 17 Jul 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/InfoBar.xib
   A /trunk/src/chrome/app/nibs/en.lproj/InfoBarContainer.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/infobar.h
   A /trunk/src/chrome/browser/cocoa/infobar_container_controller.h
   A /trunk/src/chrome/browser/cocoa/infobar_container_controller.mm
   A /trunk/src/chrome/browser/cocoa/infobar_container_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/infobar_controller.h
   A /trunk/src/chrome/browser/cocoa/infobar_controller.mm
   A /trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/infobar_test_helper.h
   A /trunk/src/chrome/browser/cocoa/infobar_text_field.h
   A /trunk/src/chrome/browser/cocoa/infobar_text_field.mm
   A /trunk/src/chrome/browser/cocoa/infobar_text_field_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

First cut at infobars on Mac.  These are not expected to be
pretty.  Animations and aesthetic appeal will come in a
future CL.

BUG=http://crbug.com/14462
BUG=http://crbug.com/14937
BUG=http://crbug.com/15839
BUG=http://crbug.com/16487
TEST=Infobars should show up when expected.
Review URL: http://codereview.chromium.org/155494
------------------------------------------------------------------------
r20929 | estade@chromium.org | 2009-07-17 05:09:20 +0200 (Fri, 17 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

forgot a file (or rather gcl was hiding it in another cl)

TBR=evan

Review URL: http://codereview.chromium.org/149787
------------------------------------------------------------------------
r20928 | estade@chromium.org | 2009-07-17 05:01:51 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Set window icon on options dialog, bookmark manager.

BUG=16951
TEST=launch bookmark manager on gnome/metacity, observe that window has icon

Review URL: http://codereview.chromium.org/155672
------------------------------------------------------------------------
r20927 | ben@chromium.org | 2009-07-17 04:00:42 +0200 (Fri, 17 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Experiment with opening links opened via context menu in the foreground.

BUG=none
TEST=tabs opened via "Open link in new tab..." should open in foreground, not background.

Review URL: http://codereview.chromium.org/155671
------------------------------------------------------------------------
r20925 | estade@chromium.org | 2009-07-17 03:04:44 +0200 (Fri, 17 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Make testers happy.

Only show linux splash page for new windows.

May this be the end of this sad saga.

TEST=if chrome is already running, `./out/Debug/chrome test.html` doesn't open splash page
BUG=http://crbug.com/16893

Review URL: http://codereview.chromium.org/149780
------------------------------------------------------------------------
r20921 | estade@chromium.org | 2009-07-17 02:17:56 +0200 (Fri, 17 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_dnd_util.cc
   M /trunk/src/chrome/browser/gtk/gtk_dnd_util.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Allow dragging a link from the web contents to the bookmark bar to get a named bookmark.

Also, change the naming scheme of the DnD targets.

BUG=16791
TEST=select a link in the web page and drag it to the bookmark bar.

Review URL: http://codereview.chromium.org/155661
------------------------------------------------------------------------
r20917 | erg@google.com | 2009-07-17 01:35:22 +0200 (Fri, 17 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc

Fix linux unit tests by checking for NULL that's impossible in real code, but needed in unit tests.

TBR=willchan

Review URL: http://codereview.chromium.org/155663
------------------------------------------------------------------------
r20914 | erg@google.com | 2009-07-17 01:09:39 +0200 (Fri, 17 Jul 2009) | 14 lines
Changed paths:
   A /trunk/src/chrome/app/theme/star_noborder.png
   A /trunk/src/chrome/app/theme/starred_noborder.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h

GTK Themes: Make the location bar area look native.

Replace the star and go buttons with a native looking thing, where
we manually draw the theme's button image for the full omnibox area
and then position the star/go buttons on top of that.

Also adds stand in versions of star_noborder and starred_noborder
until Glen can make real icons.

http://crbug.com/16227
http://crbug.com/13967
http://crbug.com/16915

Review URL: http://codereview.chromium.org/149681
------------------------------------------------------------------------
r20911 | rohitrao@chromium.org | 2009-07-17 00:34:11 +0200 (Fri, 17 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/window_sizer_mac.mm

Adds window position save/restore support for multiple monitors on Mac.
Fixes a bug where windows would creep up the screen every time you quit/restarted.

BUG=http://crbug.com/16176
BUG=http://crbug.com/12854
TEST=Windows should save/restore in the correct location, with either a single
monitor or multiple monitors.
Review URL: http://codereview.chromium.org/155647
------------------------------------------------------------------------
r20910 | rafaelw@chromium.org | 2009-07-17 00:20:00 +0200 (Fri, 17 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_event_names.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

First step in abstracting extension api to common/shared "IDL" files (jsonschema).

In this step, All "normal" api calls and events (those that arrive or originate from the browser process) are routed through a single v8::Extension API Call ("StartRequest").

Additionally, internal string names for methods and events now match the js namespace (i.e. "RemoveTab" -> "tabs.remove"), in anticipation of having names be implicit from their api module & name in the api "IDL".

TBR=aa,mpcomplete

Review URL: http://codereview.chromium.org/149730
------------------------------------------------------------------------
r20907 | paul@chromium.org | 2009-07-17 00:04:43 +0200 (Fri, 17 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_controller.h
   M /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Fix for the Mac download shelf crash when clearing all downloads.
We also now automatically hide the shelf when the downloads are
cleared.

BUG=15855,15893
TEST=Download a few things, clear all downloads and the shelf will
     empty and hide.

Review URL: http://codereview.chromium.org/149732
------------------------------------------------------------------------
r20900 | stuartmorgan@google.com | 2009-07-16 23:31:05 +0200 (Thu, 16 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Implement batch deletion in PasswordStoreMac.
Add a new keychain helper search and refactor a bit to support the deletion.

BUG=15070
TEST=Deleting passwords in Clear Browsing Data... will now work per the design doc (which means we clear passwords we created, and our metadata, but leave passwords created by other browsers alone).

Review URL: http://codereview.chromium.org/149759
------------------------------------------------------------------------
r20899 | estade@chromium.org | 2009-07-16 23:27:06 +0200 (Thu, 16 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

GTK: Fix bookmark manager crash on startup introduced by r20565

TBR=munjal

------------------------------------------------------------------------
r20898 | kuchhal@chromium.org | 2009-07-16 23:15:52 +0200 (Thu, 16 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_dialog.h

Show progress Window when importing profile from First Run dialog.

Review URL: http://codereview.chromium.org/149766
------------------------------------------------------------------------
r20897 | estade@chromium.org | 2009-07-16 23:07:01 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc

Select correct default folder in bookmark editor gtk.

BUG=none
TEST=right click in a dropdown from a folder on the bookmark bar, select add, you should see that the correct folder is seleted in the bookmark editor tree view. Add a bookmark, it should show up in the right place.

Review URL: http://codereview.chromium.org/149725
------------------------------------------------------------------------
r20896 | avi@chromium.org | 2009-07-16 22:47:20 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm

r20591 broke themed buttons. Fixing.

BUG=none
TEST=install theme, check to see that buttons are themed.

Review URL: http://codereview.chromium.org/155646
------------------------------------------------------------------------
r20895 | sidchat@google.com | 2009-07-16 22:43:01 +0200 (Thu, 16 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/samples/cld/toolstrip.html

Change getLanguage to detectLanguage, and incorporate corresponding changes, in tab extensions. Also, use ISO language (e.g. "fr" instead of "French") as return language.
BUG=none
TEST=Enable extensions, add the given toolstrip as extension. For a page, the language of the page should be returned as ISO language (e.g., "french" as "fr")
Review URL: http://codereview.chromium.org/149627
------------------------------------------------------------------------
r20894 | idanan@chromium.org | 2009-07-16 22:41:00 +0200 (Thu, 16 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc

Fix Valgrind Linux leak

Review URL: http://codereview.chromium.org/155645
------------------------------------------------------------------------
r20891 | pinkerton@chromium.org | 2009-07-16 22:25:17 +0200 (Thu, 16 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Clear the window delegate in dealloc. Just being safe, I don't think this fixes any known issues or breaks anything.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149702
------------------------------------------------------------------------
r20890 | jhawkins@chromium.org | 2009-07-16 22:20:55 +0200 (Thu, 16 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc

gtk: Handle RTL layout when rendering the dragged tab.

BUG=none
TEST=Drag a tab out of the browser in a RTL language.  The tab should be rendered on the right side of the container.
Review URL: http://codereview.chromium.org/155643
------------------------------------------------------------------------
r20888 | estade@chromium.org | 2009-07-16 22:06:47 +0200 (Thu, 16 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/icon_loader_linux.cc

GTK: Move icon parsing to UI thread.

Loading the data from disk remains on the background thread.

This fix is pseudo-speculative.

BUG=14746,14745,15244,15416
TEST=UI tests stop flaking out.

Review URL: http://codereview.chromium.org/149764
------------------------------------------------------------------------
r20886 | idanan@chromium.org | 2009-07-16 21:54:15 +0200 (Thu, 16 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Blacklist API change for allowing multiple rule matches

The findMatch function now returns a Match object which aggregates multiple
entries into one, in case (which is expected to be common) that multiple
rules match a given URL.

Since the set of matches is highly dependent on the URL, the Match class
replaces the old RequestData object to be added to URLRequests.

BUG=16932
TEST=Blacklist*
Review URL: http://codereview.chromium.org/149737
------------------------------------------------------------------------
r20885 | robertshield@google.com | 2009-07-16 21:33:26 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Remove DCHECK() in FindInPageNotificationObserver::Observe that gets triggered when FindInPage automation messages come in too quickly.

BUG=Multiple AutomationMsg_Find messages sent rapidly to Chrome (without waiting for the synchronous responses) will trigger this DCHECK().

TEST=Send many AutomationMsg_Find messages very quickly without waiting for responses. Ensure no DCHECKing.
Review URL: http://codereview.chromium.org/155644
------------------------------------------------------------------------
r20883 | abarth@chromium.org | 2009-07-16 20:54:38 +0200 (Thu, 16 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/base/base_switches.cc
   M /trunk/src/base/base_switches.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/webkit/api/public/WebFrame.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc

Enable isolated worlds for content scripts.

R=aa
TEST=LayoutTests/http/tests/security/isolatedWorld/ (will be landing soon after this patch)
BUG=12218

Review URL: http://codereview.chromium.org/155626
------------------------------------------------------------------------
r20881 | pinkerton@chromium.org | 2009-07-16 20:15:01 +0200 (Thu, 16 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Call the DragSource* API on the RenderViewHost during a drag.
BUG=16909
TEST=Dragging thumbs on the NTP
Review URL: http://codereview.chromium.org/155640
------------------------------------------------------------------------
r20880 | aa@chromium.org | 2009-07-16 20:04:36 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc

Fix for bug where we would not create ExtensionFunctionDispatcher
instances for ExtensionDOMUI if RenderView was reused.

BUG=16853
TEST=Added browser test
Review URL: http://codereview.chromium.org/155592
------------------------------------------------------------------------
r20877 | stuartmorgan@google.com | 2009-07-16 19:26:11 +0200 (Thu, 16 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Implement bulk password lookup API in PasswordStoreMac.
Refactor password merge to support the new search.
Rename the fill-targeted search on the adapter for better clarity about the distinction between it and the new search.

BUG=16485
TEST=none yet; UI doesn't exist.

Review URL: http://codereview.chromium.org/149708
------------------------------------------------------------------------
r20873 | pfeldman@chromium.org | 2009-07-16 18:47:58 +0200 (Thu, 16 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   M /trunk/src/webkit/glue/devtools/js/inspector_controller_impl.js
   M /trunk/src/webkit/glue/webdevtoolsclient_delegate.h
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.h

DevTools: Make 'toggle node search' mode work.
BUG=16824
Review URL: http://codereview.chromium.org/155639
------------------------------------------------------------------------
r20869 | craig.schlenter@chromium.org | 2009-07-16 17:55:27 +0200 (Thu, 16 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc

Fix a strict-aliasing issue in BlacklistStoreInput::ReadUInt.

Review URL: http://codereview.chromium.org/155622
------------------------------------------------------------------------
r20867 | deanm@chromium.org | 2009-07-16 16:57:25 +0200 (Thu, 16 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Linux omnibox suggestions, only force LTR on URLs.

I had previously forced LTR on all match contents.  These are usually URLs,
but in the case of history they are the search query.  Use the classification
to only for LTR on match contents that are actually URLs.

Review URL: http://codereview.chromium.org/155636

------------------------------------------------------------------------
r20866 | avi@chromium.org | 2009-07-16 16:53:28 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Implement theme reset

BUG=none
TEST=try clicking the "reset to default theme" button in the prefs; it'll reset things

Review URL: http://codereview.chromium.org/155633
------------------------------------------------------------------------
r20865 | avi@chromium.org | 2009-07-16 16:53:20 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Set theme immediately on change.

BUG=none
TEST=reset theme; watch window immediately retheme

Review URL: http://codereview.chromium.org/149752
------------------------------------------------------------------------
r20862 | deanm@chromium.org | 2009-07-16 12:16:47 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Work on RTL / BiDi Omnibox.

Based on work from Evan Stade.

Review URL: http://codereview.chromium.org/155567

------------------------------------------------------------------------
r20861 | pfeldman@chromium.org | 2009-07-16 11:35:55 +0200 (Thu, 16 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

DevTools: Initial commit with docked devtools window support on Linux.

Review URL: http://codereview.chromium.org/149675
------------------------------------------------------------------------
r20859 | darin@chromium.org | 2009-07-16 08:36:28 +0200 (Thu, 16 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/api/public/WebCompositionCommand.h
   M /trunk/src/webkit/api/public/WebNavigationPolicy.h
   M /trunk/src/webkit/api/public/WebPopupMenu.h
   M /trunk/src/webkit/api/public/WebTextDirection.h
   M /trunk/src/webkit/api/public/WebWidget.h
   M /trunk/src/webkit/api/public/WebWidgetClient.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   A /trunk/src/webkit/glue/webpopupmenu_impl.cc (from /trunk/src/webkit/glue/webpopupmenu_impl.cc:20854)
   A /trunk/src/webkit/glue/webpopupmenu_impl.h (from /trunk/src/webkit/glue/webpopupmenu_impl.h:20854)
   D /trunk/src/webkit/glue/webtextdirection.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   D /trunk/src/webkit/glue/webwidget.h
   D /trunk/src/webkit/glue/webwidget_delegate.h
   D /trunk/src/webkit/glue/webwidget_impl.cc
   D /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/glue/webworker_impl.cc
   A /trunk/src/webkit/glue/window_open_disposition.cc (from /trunk/src/webkit/glue/window_open_disposition.cc:20854)
   M /trunk/src/webkit/glue/window_open_disposition.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/mac/webview_host.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   M /trunk/src/webkit/webkit.gyp

Reverting 20855.
Review URL: http://codereview.chromium.org/149744
------------------------------------------------------------------------
r20855 | darin@chromium.org | 2009-07-16 07:33:47 +0200 (Thu, 16 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/api/public/WebCompositionCommand.h
   M /trunk/src/webkit/api/public/WebNavigationPolicy.h
   M /trunk/src/webkit/api/public/WebPopupMenu.h
   M /trunk/src/webkit/api/public/WebTextDirection.h
   M /trunk/src/webkit/api/public/WebWidget.h
   M /trunk/src/webkit/api/public/WebWidgetClient.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   D /trunk/src/webkit/glue/webpopupmenu_impl.cc
   D /trunk/src/webkit/glue/webpopupmenu_impl.h
   A /trunk/src/webkit/glue/webtextdirection.h (from /trunk/src/webkit/glue/webtextdirection.h:20853)
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   A /trunk/src/webkit/glue/webwidget.h (from /trunk/src/webkit/glue/webwidget.h:20853)
   A /trunk/src/webkit/glue/webwidget_delegate.h (from /trunk/src/webkit/glue/webwidget_delegate.h:20853)
   A /trunk/src/webkit/glue/webwidget_impl.cc (from /trunk/src/webkit/glue/webwidget_impl.cc:20853)
   A /trunk/src/webkit/glue/webwidget_impl.h (from /trunk/src/webkit/glue/webwidget_impl.h:20853)
   M /trunk/src/webkit/glue/webworker_impl.cc
   D /trunk/src/webkit/glue/window_open_disposition.cc
   M /trunk/src/webkit/glue/window_open_disposition.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/mac/webview_host.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   M /trunk/src/webkit/webkit.gyp

Reverting 20854.
Review URL: http://codereview.chromium.org/155621
------------------------------------------------------------------------
r20854 | darin@chromium.org | 2009-07-16 07:11:05 +0200 (Thu, 16 Jul 2009) | 30 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/api/public/WebCompositionCommand.h
   M /trunk/src/webkit/api/public/WebNavigationPolicy.h
   M /trunk/src/webkit/api/public/WebPopupMenu.h
   M /trunk/src/webkit/api/public/WebTextDirection.h
   M /trunk/src/webkit/api/public/WebWidget.h
   M /trunk/src/webkit/api/public/WebWidgetClient.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   A /trunk/src/webkit/glue/webpopupmenu_impl.cc (from /trunk/src/webkit/glue/webwidget_impl.cc:20363)
   A /trunk/src/webkit/glue/webpopupmenu_impl.h (from /trunk/src/webkit/glue/webwidget_impl.h:20363)
   D /trunk/src/webkit/glue/webtextdirection.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   D /trunk/src/webkit/glue/webwidget.h
   D /trunk/src/webkit/glue/webwidget_delegate.h
   D /trunk/src/webkit/glue/webwidget_impl.cc
   D /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/glue/webworker_impl.cc
   A /trunk/src/webkit/glue/window_open_disposition.cc
   M /trunk/src/webkit/glue/window_open_disposition.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/mac/webview_host.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   M /trunk/src/webkit/webkit.gyp

Use WebWidget from the WebKit API.  This change also makes
use of WebKitClient (replacing WebWidgetDelegate from glue).

The ripple effects of this change are rather large, but most
of the impact is mechanical.

The more interesting changes include:

1- Removing the WebWidget parameter from WebWidgetClient methods.  This didn't
matter at all to RenderWidget or RenderView, but it did cause some changes to
be made to TestWebViewDelegate.  Now, it is not possible to share a delegate
implementation for both the WebView and a popup menu, so I have a second
instance of the delegate owned by TestShell for use with popup menus.

2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was getting
to be a pretty large change, so I stopped short of deleting WindowOpenDisposition.
That way the Chrome side can remain mostly unmodified.  I then added a mapping
function to convert from WebNavigationPolicy to WindowOpenDisposition.

3- The IME methods on WebWidget were renamed (reviewed separately by hbono), and
there is now an enum to specify the composition command (WebCompositionCommand).

4- I added IPC serialization for WebCompositionCommand and WebTextDirection,
which cleaned up some code that was just using ints in IPC messages.

R=jam
BUG=16234
TEST=none

Review URL: http://codereview.chromium.org/149620
------------------------------------------------------------------------
r20853 | shess@chromium.org | 2009-07-16 06:56:06 +0200 (Thu, 16 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field.h
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h (from /trunk/src/chrome/browser/cocoa/location_bar_cell.h:20852)
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm (from /trunk/src/chrome/browser/cocoa/location_bar_cell.mm:20852)
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm (from /trunk/src/chrome/browser/cocoa/location_bar_cell_unittest.mm:20852)
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm (from /trunk/src/chrome/browser/cocoa/location_bar_fieldeditor_unittest.mm:20852)
   A /trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
   D /trunk/src/chrome/browser/cocoa/location_bar_cell.h
   D /trunk/src/chrome/browser/cocoa/location_bar_cell.mm
   D /trunk/src/chrome/browser/cocoa/location_bar_cell_unittest.mm
   D /trunk/src/chrome/browser/cocoa/location_bar_fieldeditor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

[Mac] Refactor location-bar autocomplete cell classes.

LocationBarCell -> AutocompleteTextFieldCell.
LocationBarFieldEditor -> AutocompleteTextFieldEditor.
AutocompleteTextField added as placeholder for future work (hints and
keyword search).

Review URL: http://codereview.chromium.org/149717
------------------------------------------------------------------------
r20852 | sky@chromium.org | 2009-07-16 06:19:19 +0200 (Thu, 16 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/defaults.cc
   A /trunk/src/chrome/browser/defaults.h
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/chrome.gyp

Makes the default for what to do on startup be restore last session on
chrome os as well as changing autocomplete edit/popup font sizes on
chrome os. As suggested by Evan I've moved these options into
chrome/browser/defaults.h so that we don't have a ton of #ifdefs every
where.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155576
------------------------------------------------------------------------
r20850 | ananta@chromium.org | 2009-07-16 05:49:22 +0200 (Thu, 16 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

When the unhandled accelerator messages come back from the external host, we should only DefProc the message.
The current implementaton calls TranslateMessage and DispatchMessage which causes the whole cycle to repeat.

This is the chrome side of the fix for http://b/viewIssue?id=1981454

Bug=1981454

Review URL: http://codereview.chromium.org/155562
------------------------------------------------------------------------
r20848 | mattm@chromium.org | 2009-07-16 05:31:34 +0200 (Thu, 16 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Implement gtk download options section.

BUG=11507

Review URL: http://codereview.chromium.org/155617
------------------------------------------------------------------------
r20845 | agl@chromium.org | 2009-07-16 04:52:15 +0200 (Thu, 16 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: reap the sandbox helper process.

TEST=start chrome with a SUID sandbox and check that no zombies persist.

http://codereview.chromium.org/149734

(Reland of r20838. Hopefully with the reaping in the correct place this time.)

------------------------------------------------------------------------
r20843 | thestig@chromium.org | 2009-07-16 04:38:39 +0200 (Thu, 16 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Pass Linux crash guid to renderers.
Review URL: http://codereview.chromium.org/149736
------------------------------------------------------------------------
r20842 | agl@chromium.org | 2009-07-16 04:37:38 +0200 (Thu, 16 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Revert "Linux: reap the sandbox helper process."

This reverts commit r20838: it broke unit tests on Linux.

------------------------------------------------------------------------
r20838 | agl@chromium.org | 2009-07-16 03:37:51 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Linux: reap the sandbox helper process.

TEST=start chrome with a SUID sandbox and check that no zombies persist.

http://codereview.chromium.org/149734

------------------------------------------------------------------------
r20837 | glen@chromium.org | 2009-07-16 03:37:39 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Align custom background tab images correctly.

BUG=16879
TEST=Install a theme with a background tab image and verify that the image is aligned to the top of the tab, and not to the top of the frame.

Review URL: http://codereview.chromium.org/149727
------------------------------------------------------------------------
r20833 | agl@chromium.org | 2009-07-16 03:09:27 +0200 (Thu, 16 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc

GCC > 4.2 fix: check return values for fread

http://codereview.chromium.org/149731

------------------------------------------------------------------------
r20829 | glen@chromium.org | 2009-07-16 02:39:41 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc

GetThemeProvider error in DownloadItemView. Just remove the offending line for now.

BUG=16882
TEST=Reliability green
TBR=agl

------------------------------------------------------------------------
r20825 | estade@chromium.org | 2009-07-16 02:20:25 +0200 (Thu, 16 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Fix web contents drag corner case.

We heuristically use the last mouse down event the renderer got as the event that 'started' the drag, which is not entirely accurate. Since the context menu grabs input, we were in a situation where the last mouse down was a right click, so it wanted the drag to end by releasing the right mouse button.

BUG=16793
TEST=see bug

Review URL: http://codereview.chromium.org/155604
------------------------------------------------------------------------
r20809 | erg@google.com | 2009-07-16 01:36:05 +0200 (Thu, 16 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK Themes: Tint throbbers like we tint all other buttons in the interface.

Relanding with fixes for unit tests. Run through trybot this time...

http://crbug.com/13967

Original Review URL: http://codereview.chromium.org/155588

TBR=estade

Review URL: http://codereview.chromium.org/155601
------------------------------------------------------------------------
r20807 | estade@chromium.org | 2009-07-16 01:26:15 +0200 (Thu, 16 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Cancel icon load requests when we are getting shutdown.

Hopefully this will fix the download test flakiness.

I was able to reproduce the crash manually by just mass-clicking on the same download link many times (thanks to DotA for improving my APM). With this patch I am no longer able to repro.

BUG=14746,14745,15244,15416
TEST=download tests stop flaking out

Review URL: http://codereview.chromium.org/149712
------------------------------------------------------------------------
r20803 | thestig@chromium.org | 2009-07-16 01:07:34 +0200 (Thu, 16 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Make Linux crash death signal message constant sized.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149709
------------------------------------------------------------------------
r20802 | erg@google.com | 2009-07-16 00:50:21 +0200 (Thu, 16 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Revert "GTK Themes: Tint throbbers like we tint all other buttons in the interface."

This reverts commit 3dfa509662e99282b5212490bfe19b32da357741 (r20799).

TBR=estade

Review URL: http://codereview.chromium.org/155598
------------------------------------------------------------------------
r20801 | agl@chromium.org | 2009-07-16 00:48:37 +0200 (Thu, 16 Jul 2009) | 25 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/sandbox/linux/suid/sandbox.cc
   M /trunk/src/sandbox/sandbox.gyp

Linux: move hardcoded paths to GYP variables.

This patch removes the hardcoded paths for the sandbox binary location
and the chrome binary location for the sandbox. Instead, you can now
set GYP variables for these things. Indeed, you have to set a GYP
variable in order to use the sandbox now.

GYP variables can be set on the command line, if you run gyp.py
directly, with -D key=value. Or you can export GYP_DEFINES="key=value
key2=value2".

Now, in order to use the sandbox you should set:
  linux_sandbox_path=/opt/google/chrome/chrome-sandbox
  linux_sandbox_chrome_path=/opt/google/chrome/chrome

(changing the paths as needed, of course). See the comments in
build/common.gypi

For development see
  http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment

Because developers need to setup a special sandbox binary.

http://codereview.chromium.org/149689

------------------------------------------------------------------------
r20799 | erg@google.com | 2009-07-16 00:41:19 +0200 (Thu, 16 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK Themes: Tint throbbers like we tint all other buttons in the interface.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/155588
------------------------------------------------------------------------
r20798 | mattm@chromium.org | 2009-07-16 00:26:16 +0200 (Thu, 16 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

TBR: evan@chromium.org
------------------------------------------------------------------------
r20797 | mattm@chromium.org | 2009-07-16 00:14:40 +0200 (Thu, 16 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h

Fill in "web content" section in "user data" options.

BUG=11507
TEST=open options -> user data.  Click the configure fonts button.  Font configuration dialog should appear.

Review URL: http://codereview.chromium.org/157002
------------------------------------------------------------------------
r20796 | mattm@chromium.org | 2009-07-16 00:09:55 +0200 (Thu, 16 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/options_util.cc
   M /trunk/src/chrome/browser/options_util.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Move the ResolveMetricsReportingEnabled logic to OptionsUtil, make gtk options use it.

Only show the reporting checkbox in Google Chrome builds.

Show the restart required message box when changing the reporting setting.

BUG=11507
TEST=on Chromium build, option should not show up.  On Google Chrome build in should show up, and enable both crash reporting and metrics settings.

Review URL: http://codereview.chromium.org/149665
------------------------------------------------------------------------
r20795 | ericroman@google.com | 2009-07-16 00:04:32 +0200 (Thu, 16 Jul 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_scraper_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   A /trunk/src/net/base/host_resolver_impl.cc (from /trunk/src/net/base/host_resolver.cc:20435)
   A /trunk/src/net/base/host_resolver_impl.h (from /trunk/src/net/base/host_resolver.h:20435)
   A /trunk/src/net/base/host_resolver_impl_unittest.cc (from /trunk/src/net/base/host_resolver_unittest.cc:20435)
   A /trunk/src/net/base/host_resolver_proc.cc (from /trunk/src/net/base/host_resolver.cc:20435)
   A /trunk/src/net/base/host_resolver_proc.h
   D /trunk/src/net/base/host_resolver_unittest.cc
   A /trunk/src/net/base/mock_host_resolver.cc (from /trunk/src/net/base/host_resolver_unittest.h:20435)
   A /trunk/src/net/base/mock_host_resolver.h (from /trunk/src/net/base/host_resolver_unittest.h:20435)
   M /trunk/src/net/base/run_all_unittests.cc
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.h
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base_unittest.cc
   M /trunk/src/net/socket/socks5_client_socket_unittest.cc
   M /trunk/src/net/socket/socks_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Refactorings surrounding HostResolver:

(1) Extract HostResolver to an interface.

The existing concrete implementation is now named HostResolverImpl. This makes it possible to create mocks with more complex behavior (i.e. choose via rules if response will be sync vs async).

(2) Transform HostMapper into HostResolverProc.

Conceptually HostResolverProc maps a hostname to a socket address, whereas HostMapper mapped a hostname to another hostname (so you were still at the mercy of the system's host resolver). With HostResolverProc you can specify the exact AddressList, making it possible to run tests requiring IPv6 socketaddrs on systems (like WinXP) that don't actually support it.

(3) Add a MockHostResolver implementation of HostResolver.

This replaces the [ScopedHostMapper + RuleBasedHostMapper + HostResolver] combo. It is less clunky and a bit more expressive.

BUG=http://crbug.com/16452
R=willchan
TEST=existing

Review URL: http://codereview.chromium.org/149511
------------------------------------------------------------------------
r20791 | jhawkins@chromium.org | 2009-07-15 23:58:49 +0200 (Wed, 15 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc

gtk: Remove two calls to Update that are unnecessary.  When we layout the dragged tab, gtk will emit an expose-event signal for us if the widget changes size.

BUG=none
TEST=Drag a tab out of the browser.  The tab should be sized and shown properly.
Review URL: http://codereview.chromium.org/149703
------------------------------------------------------------------------
r20790 | glen@chromium.org | 2009-07-15 22:49:38 +0200 (Wed, 15 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Add newline to end of download_manager.cc

BUG=none
TEST=none
TBR=sverrir

------------------------------------------------------------------------
r20788 | glen@chromium.org | 2009-07-15 22:35:13 +0200 (Wed, 15 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils.h
   M /trunk/src/skia/ext/skia_utils_unittest.cc

Make our HSL shifting match Photoshop's.

Also clean up a bunch of PMColor code - skia_utils should operate on SkColors and PMColors should only ever be used by SkBitmaps and ImageOperations.

BUG=16687

Review URL: http://codereview.chromium.org/149663
------------------------------------------------------------------------
r20787 | glen@chromium.org | 2009-07-15 22:34:28 +0200 (Wed, 15 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Remove auto-open items from the download shelf on auto-open. This has the delicious side-effect of auto-closing the download shelf after extensions are downloaded and auto installed.

While we're here, also add proper colors to the download buttons.

BUG=16232
TEST=Install a theme from the web, make sure the download shelf isn't shown after installation. Do the same for a filetype that is set to auto-open. Make sure the shelf stays open for other filetypes.

Review URL: http://codereview.chromium.org/149580
------------------------------------------------------------------------
r20786 | phajdan.jr@chromium.org | 2009-07-15 22:32:51 +0200 (Wed, 15 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/task_manager_view.cc
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/common
   A /trunk/src/chrome/test/data/extensions/common/background_page
   A /trunk/src/chrome/test/data/extensions/common/background_page/background.html
   A /trunk/src/chrome/test/data/extensions/common/background_page/manifest.json
   A /trunk/src/chrome/test/data/extensions/common/one_in_shelf
   A /trunk/src/chrome/test/data/extensions/common/one_in_shelf/manifest.json
   A /trunk/src/chrome/test/data/extensions/common/one_in_shelf/shelf.html

Add more browser tests for Task Manager.

TEST=Covered by browser_tests.
http://crbug.com/12127

Review URL: http://codereview.chromium.org/155433
------------------------------------------------------------------------
r20785 | estade@chromium.org | 2009-07-15 22:30:54 +0200 (Wed, 15 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

Make more things clickable in the bookmark bar menus:

- folder within a folder
- "empty" menu item

Note that it can be hard to click on a folder within a folder since hovering over the folder pops up a submenu that grabs focus, so you end up needing to right click twice. It's a little odd but the hackery required to fix it doesn't seem worth it.

BUG=15886
TEST=right click on an empty menu item

Review URL: http://codereview.chromium.org/155586
------------------------------------------------------------------------
r20782 | finnur@chromium.org | 2009-07-15 22:21:58 +0200 (Wed, 15 Jul 2009) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_event_names.cc
   M /trunk/src/chrome/browser/extensions/extension_event_names.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html

Retrying this patch. This was already reviewed by mpcomplete and the
only change is a fix for the UI test that broke and a small change to
event_bindings.cc (reviewed in-person).

ExtensionFunctionDispatcher now notifies ExtensionProcessManager of
renderviews created, which in turn notifies the renderer of page
actions that it knows about.

Remove generic event "page-action-executed" in favor of page action
specific event (sent as extension_id/page_action_id).

In the bindings, we now setup events for each page action we know about
so we can register for specific events, and not receive broadcast events
from all page actions. To setup these events I added a
GetCurrentPageActions() to extension_process_bindings.cc and a helper
function GetCurrentExtensionId().

And, finally, I simplified the page action background page by removing
the check to see if we are already subscribed to the feed (since we now
support multiple feed readers, it doesn't make sense anymore to always
check Google Reader). This check might make a comeback later in a
different form.

TBR=mpcomplete
BUG=13936
TEST=The RSS sample extension should work as before.
Review URL: http://codereview.chromium.org/149683
------------------------------------------------------------------------
r20780 | arv@google.com | 2009-07-15 22:18:02 +0200 (Wed, 15 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Only show completed downloads.

BUG=16719

TEST=Download a big file (http://www.thinkbroadband.com/download.html
has good files for testing downloads) and make sure that that cancelled
and in progress downloads are not shown on the new tab page.


Review URL: http://codereview.chromium.org/149685
------------------------------------------------------------------------
r20779 | munjal@chromium.org | 2009-07-15 22:15:26 +0200 (Wed, 15 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc

Don't use ID generation logic always. Only reassign IDs
when checksums differ or if IDs are missing and do that
simply by assigning the next maximum id.

Add a unit test.

BUG=16357
TEST=NONE

Review URL: http://codereview.chromium.org/155560
------------------------------------------------------------------------
r20778 | jhawkins@chromium.org | 2009-07-15 22:12:20 +0200 (Wed, 15 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

gtk: Handle RTL layout when positioning the tab strip drop arrow.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149695
------------------------------------------------------------------------
r20777 | tim@chromium.org | 2009-07-15 22:12:17 +0200 (Wed, 15 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc

Fix leak in ShownSectionsHandler::HandleGetShownSections and
potential leak of default_favicon_ in DOMUIFavIconSource.

BUG=16818
TEST=valgrind ui_tests

Review URL: http://codereview.chromium.org/155579
------------------------------------------------------------------------
r20774 | erg@google.com | 2009-07-15 22:01:14 +0200 (Wed, 15 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK Themes: Inactive title bars should follow the bg insensitive color.

This solves the inactive skyline color often being laughably bad. It does
show that we may want to draw the line between the skyline and toolbar
for best visual effect, though...

Review URL: http://codereview.chromium.org/149693
------------------------------------------------------------------------
r20773 | jrg@chromium.org | 2009-07-15 22:00:18 +0200 (Wed, 15 Jul 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Mac pop-up window happier-ness.

BUG=http://crbug.com/15727, http://crbug.com/16063, http://crbug.com/16329

TEST=A few things.
Bookmark bar test (16063):
- open bookmark bar, then open popup.  Popup should not have bmb.
- close bookmark bar, then open popup.  Popup should not have bmb.
- In main window, toggle bmb a few times.  Popup should not change.
Tab at bottom bug (16329):
- Open 'details' popup in gmail (next to 'last acct activity')
- make sure no tab strip at the bottom of the window
General (15727):
- Open a popup.  Make sure no toolbar (back/fwd buttons et al)

Review URL: http://codereview.chromium.org/155444
------------------------------------------------------------------------
r20772 | avi@chromium.org | 2009-07-15 21:59:30 +0200 (Wed, 15 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix auto-opening file types not auto-opening.

BUG=http://crbug.com/16085
TEST=As described in bug

Review URL: http://codereview.chromium.org/149692
------------------------------------------------------------------------
r20769 | shess@chromium.org | 2009-07-15 21:51:59 +0200 (Wed, 15 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Remove guard on FocusLocation() in autocomplete field.

Reapplies http://codereview.chromium.org/149492 .  That version was
accidentally calling this code as part of the class implementation,
which caused the code to receive the "done editing" notification,
which caused the code to drop the popup...

This version stops using FocusLocation() internally, instead messaging
field_ directly.

http://crbug.com/12246
TEST=Type some stuff in address bar.  Popup should popup with suggestions.  With cursor still in bar, Command-l should select all.

Review URL: http://codereview.chromium.org/155537
------------------------------------------------------------------------
r20768 | pinkerton@chromium.org | 2009-07-15 21:49:36 +0200 (Wed, 15 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm

Only register for popup menu notifications from our popup cell, not all of them.
BUG=16299
TEST=get a blocked popup, go to a site that has html selects. the popup menus should both work correctly.
Review URL: http://codereview.chromium.org/149694
------------------------------------------------------------------------
r20762 | estade@chromium.org | 2009-07-15 21:12:13 +0200 (Wed, 15 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc
   M /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

First run bubble polish:

- improve spacing and and sizing, both internally and externally (using windows as the guide)
- make legible for dark themes
- make show delay longer because it was too short on my machine (at least when using a Debug build).

Also explicitly set bookmark bubble labels black.

BUG=16782
TEST=none

Review URL: http://codereview.chromium.org/149664
------------------------------------------------------------------------
r20761 | mpcomplete@chromium.org | 2009-07-15 21:11:51 +0200 (Wed, 15 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable MessagingContentScript.  It's failing on the buildbot.

BUG=no
TEST=no
TBR=aa

Review URL: http://codereview.chromium.org/155580
------------------------------------------------------------------------
r20757 | klink@chromium.org | 2009-07-15 20:49:23 +0200 (Wed, 15 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   A /trunk/src/chrome/browser/views/browser_views_accessibility_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/accessibility

Adds browser tests instead of the old flaky UI tests.

Review URL: http://codereview.chromium.org/155487
------------------------------------------------------------------------
r20755 | mpcomplete@chromium.org | 2009-07-15 20:38:45 +0200 (Wed, 15 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h

Reenable content script messaging test.

Remove temporary change now that webkit DEPS roll landed.

TEST=no
BUG=16228

Review URL: http://codereview.chromium.org/149655
------------------------------------------------------------------------
r20752 | mattm@chromium.org | 2009-07-15 20:28:32 +0200 (Wed, 15 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc

Set the prefs::kMetricsReportingEnabled value in the gtk first run dialog.

BUG=11971
TEST=Build Google Chrome version, run with --user-data-dir pointing to empty directory, select to report crashes, open options user data page, check that the checkbox for reporting is actually checked.

Review URL: http://codereview.chromium.org/149666
------------------------------------------------------------------------
r20750 | pfeldman@chromium.org | 2009-07-15 20:19:46 +0200 (Wed, 15 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: re-enable interactve sanity tests.
BUG=16767

------------------------------------------------------------------------
r20749 | arv@google.com | 2009-07-15 20:18:55 +0200 (Wed, 15 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Set the pinned tooltip when we set the pinned state of the DOM.

BUG=16460

TEST=Drag a non pinned thumbnail and drop it on another thumbnail. Then
hover over the unpin button and the tooltip should say unpin/don't keep
on this page.


Review URL: http://codereview.chromium.org/155574
------------------------------------------------------------------------
r20742 | agl@chromium.org | 2009-07-15 19:27:56 +0200 (Wed, 15 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc

Linux: don't leak file descriptors in the sandbox host.

(This patch appeared to me, fully formed, in my sleep)

BUG=16426
http://codereview.chromium.org/149678

------------------------------------------------------------------------
r20739 | sky@chromium.org | 2009-07-15 19:20:01 +0200 (Wed, 15 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/base_bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/test/testing_profile.cc

Lands http://codereview.chromium.org/155428 for Thiago, which changes
from me to get the thing to work.

Merging two versions of BookmarkNodeRemoved into one.

BUG=None
TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure
everything works ok.

Review URL: http://codereview.chromium.org/155572
------------------------------------------------------------------------
r20737 | pinkerton@chromium.org | 2009-07-15 19:17:24 +0200 (Wed, 15 Jul 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/web_drop_target.h
   A /trunk/src/chrome/browser/cocoa/web_drop_target.mm
   A /trunk/src/chrome/browser/cocoa/web_drop_target_unittest.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

Implement drops on web view.
BUG=13155, 15657
TEST=Dragging from other applications to web view should load urls or drop text depending on where in the view the drop occurs. Same with drags from the desktop. Drags within text fields on a webpage should work.
Review URL: http://codereview.chromium.org/149626
------------------------------------------------------------------------
r20736 | tc@google.com | 2009-07-15 19:11:17 +0200 (Wed, 15 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

Use tinted icons for menu buttons.

Add a notification registrar for theme changes to the browser toolbar
and update the images when the theme changes.

Review URL: http://codereview.chromium.org/155473

------------------------------------------------------------------------
r20734 | idanan@chromium.org | 2009-07-15 19:05:49 +0200 (Wed, 15 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_io.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_store.h
   M /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/blacklist_small.pbl
   A /trunk/src/chrome/test/data/blacklist_small.pbr
   M /trunk/src/chrome/tools/pbl_tool/pbl_tool.cc

Privacy Blacklist IOImplemented parsing of input (text) blacklists. This is the format in which we will download privacy blacklist.Implemented storing and reading of aggregated blacklists in a binary format. This is the repository which Chromium will read on startup which is more efficient to load than the downloaded blacklists.Added concept of providers to blacklist entries so that we can determine the source of a pattern match, for future display in the UI.Unit tests added for the new IO classes. Privacy Blacklist conversion tool implemented to a single text blacklist into the binary format. Still needs options for storing multiple blacklists (TODO).

BUG=none
TEST=Blacklist*
Review URL: http://codereview.chromium.org/155298
------------------------------------------------------------------------
r20733 | agl@chromium.org | 2009-07-15 19:05:18 +0200 (Wed, 15 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/sandbox/linux/suid/sandbox.cc

Linux: propagate LD_LIBRARY_PATH through the SUID sandbox.

With the SUID sandbox, certain environment variables (esp
LD_LIBRARY_PATH) are cleared for security reasons. This means that the
child zygote process isn't run with the correct environment and can
fail to start.

BUG=16815

------------------------------------------------------------------------
r20731 | phajdan.jr@chromium.org | 2009-07-15 18:07:14 +0200 (Wed, 15 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/browser/net/url_fetcher_protect.cc
   M /trunk/src/chrome/browser/net/url_fetcher_protect.h
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/page_action.h
   M /trunk/src/chrome/common/worker_thread_ticker.cc

Fix a bunch of minor Coverity issues.

- pass more things by const reference
- check return codes (minor severity)

Review URL: http://codereview.chromium.org/149643
------------------------------------------------------------------------
r20728 | pinkerton@chromium.org | 2009-07-15 16:35:59 +0200 (Wed, 15 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm

Implements the AppendRadioMenuItem and AppendCheckboxMenuItem functions
for the mac platform. Patch from pwicks86@gmail.com (Paul Wicks)
BUG=None
TEST=None
------------------------------------------------------------------------
r20719 | aa@chromium.org | 2009-07-15 06:30:12 +0200 (Wed, 15 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/url_pattern_unittest.cc
   D /trunk/src/chrome/renderer/extensions/greasemonkey_api_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/greasemonkey_api.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Various minor fixes:

* --load-extension no longer requires --enable-extensions
* No longer support chrome:// URLs for user scripts
* Remove old unused Greasemonkey test
* Enable Greasemonkey API emulation in linux/mac

BUG=16720,16007,4476
TEST=Added several unit tests

Original review:
http://codereview.chromium.org/149619

------------------------------------------------------------------------
r20717 | estade@chromium.org | 2009-07-15 06:19:01 +0200 (Wed, 15 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Revert r20667, which broke dropdown menus.

TBR=evan

Review URL: http://codereview.chromium.org/155557
------------------------------------------------------------------------
r20715 | finnur@chromium.org | 2009-07-15 05:53:00 +0200 (Wed, 15 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_event_names.cc
   M /trunk/src/chrome/browser/extensions/extension_event_names.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   A /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16-subscribed.png (from /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16-subscribed.png:20713)
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

Reverting 20714.

Rietveld showed all green try bots, but looks like one ui test is failing
Review URL: http://codereview.chromium.org/149668
------------------------------------------------------------------------
r20714 | finnur@chromium.org | 2009-07-15 05:24:36 +0200 (Wed, 15 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_event_names.cc
   M /trunk/src/chrome/browser/extensions/extension_event_names.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   D /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16-subscribed.png
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

EFD now notifies EPM of renderviews created, which in turn notifies the renderer of page actions that it knows about.

Remove generic event "page-action-executed" in favor of page action specific event (sent as extension_id/page_action_id).

In the bindings, we now setup events for each page action we know about so we can register for specific events, and not receive broadcast events from all page actions. To setup these events I added a GetCurrentPageActions() to extension_process_bindings.cc and a helper function GetCurrentExtensionId().

And, finally, I simplified the page action background page by removing the check to see if we are already subscribed to the feed (since we now support multiple feed readers, it doesn't make sense anymore to always check Google Reader). This check might make a comeback later in a different form.

BUG=13936
TEST=The RSS sample extension should work as before.
Review URL: http://codereview.chromium.org/155514
------------------------------------------------------------------------
r20711 | sky@chromium.org | 2009-07-15 04:12:28 +0200 (Wed, 15 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h

Makes it so that if you drag a tab to the left edge of the tab strip
and hold the mouse for a little bit, the tab is pinned.

BUG=16634
TEST=on linux with no tabs pinned drag until your close to the right
     edge of the tab and wait a second. The tab should be pinned.

Review URL: http://codereview.chromium.org/155543
------------------------------------------------------------------------
r20710 | agl@chromium.org | 2009-07-15 04:08:45 +0200 (Wed, 15 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/sandbox/linux/suid/sandbox.cc

Linux: various sandbox changes

  * In development mode, don't let the sandbox run SUID or SGID
    binaries
  * Only obay CHROME_DEVEL_SANDBOX if the binary UID matches the
    read UID.
  * Change the default sandbox path to save those who do nothing.

R=markus

------------------------------------------------------------------------
r20709 | agl@chromium.org | 2009-07-15 03:41:50 +0200 (Wed, 15 Jul 2009) | 20 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/sandbox/linux/suid/sandbox.cc
   M /trunk/src/sandbox/sandbox.gyp

Linux: fix for developing on a machine with google-chrome packages installed.

The latest google-chrome packages contain a sandbox binary, which the
development builds of chromium will pick up on automatically. However,
for safety reasons, the sandbox binary will only exec a fixed chrome
binary location. Since development builds will be somewhere else in
the filesystem, this means that they will fail to start their zygote
processes and generally be very sad.

However, we /do/ want people developing with the sandbox, but we don't
want the general sandbox binary to be able to exec anything. We could
have chromium try and find its sandbox binary relative to the build
directory, but some people build on NFS and, since the sandbox binary
needs to be SUID, this won't work for them.

Instead, we add a new target: chrome_devel_sandbox which developers
can use. This builds a sandbox binary that will exec anything which is
owned by the running user. This alternative sandbox binary can be
selected by exporting CHROME_DEVEL_SANDBOX.

------------------------------------------------------------------------
r20708 | sky@chromium.org | 2009-07-15 03:37:31 +0200 (Wed, 15 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Couple of changes for chrome os startup:

. Adds command line option specifying some tabs should be pinned on
  startup.
. Disables crash dialog on startup.
. Disables linux warning page on startup.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149641
------------------------------------------------------------------------
r20707 | cpu@google.com | 2009-07-15 03:36:10 +0200 (Wed, 15 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc

Handle failure of de-serialization of IPC messages in RenderViewHost
- first pass at better bad-message handling
- Created infraestructure to test compliance with this

BUG=16673
TEST=unit tests included


Review URL: http://codereview.chromium.org/149578
------------------------------------------------------------------------
r20705 | arv@google.com | 2009-07-15 03:29:05 +0200 (Wed, 15 Jul 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

NNTP: Lots of small tweaks

* Remove focus outline for buttons
* Thumbnail links should not have underline (and be black)
* Make the edit bar animation slide up from the thumbnail
* Make animations a lot faster
* Fix issue where a thumbnail got stuck in hover mode after DnD.
* Make the thumbnails come first when tabbing
* Remove focus outline for the buttons and clean up focus outline in the list mode.

BUG=16061, 16449, 16342, 16542

TEST=See bugs


Review URL: http://codereview.chromium.org/155542
------------------------------------------------------------------------
r20703 | glen@chromium.org | 2009-07-15 03:18:52 +0200 (Wed, 15 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/common/pref_names.cc

Make theme provider remember display properties settings and color's alpha.

BUG=15527


Review URL: http://codereview.chromium.org/155033
------------------------------------------------------------------------
r20702 | mhm@chromium.org | 2009-07-15 03:11:36 +0200 (Wed, 15 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/resources/print_tab.html

Make use of the new Js Template i18n for print domui

Provides a simpler js template engine for print tab which is optimized better than JsTemplate. 

BUG=173, 947
TEST=print page loads fine.

Review URL: http://codereview.chromium.org/155479
------------------------------------------------------------------------
r20701 | estade@chromium.org | 2009-07-15 03:07:53 +0200 (Wed, 15 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Don't try to set transparency on pixbufs that don't have any transparency channel.

Also add DCHECK to make sure the assumption rowstride >= width * 4 is true.

The reason this didn't cause any crashes or graphical corruption is because the non-transparent images don't have any white in them (luckily we are not making a browser for an ipod).

BUG=16749
TEST=valgrind the browser, open find bar

Review URL: http://codereview.chromium.org/155547
------------------------------------------------------------------------
r20693 | evan@chromium.org | 2009-07-15 02:43:08 +0200 (Wed, 15 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h

linux: destroy browser-side plugin windows on plugin crash

Because the plugin windows must be destroyed by the UI thread,
we store the map of plugin PID -> plugin windows there,
on the RenderWidgetHostView.

This differs slightly from Windows, where the map is stored
on the PluginProcessHost, but is otherwise pretty similar.

TEST=crash a windowed plugin; you should see a sad plugin
icon in the place of the plugin

Review URL: http://codereview.chromium.org/155517
------------------------------------------------------------------------
r20690 | stoyan@chromium.org | 2009-07-15 02:22:12 +0200 (Wed, 15 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable tests failing due webkit (Roll WebKit DEPS 45843:45873). Introduced in r20680. 
See http://crbug.com/16767.
TBR=dimich
Review URL: http://codereview.chromium.org/155545
------------------------------------------------------------------------
r20686 | jorlow@chromium.org | 2009-07-15 01:24:32 +0200 (Wed, 15 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h

Reverting 20683.
Review URL: http://codereview.chromium.org/155539
------------------------------------------------------------------------
r20683 | evan@chromium.org | 2009-07-15 00:31:32 +0200 (Wed, 15 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h

linux: destroy browser-side plugin windows on plugin crash

Because the plugin windows must be destroyed by the UI thread,
we store the map of plugin PID -> plugin windows there,
on the RenderWidgetHostView.

This differs slightly from Windows, where the map is stored
on the PluginProcessHost, but is otherwise pretty similar.

TEST=crash a windowed plugin; you should see a sad plugin
icon in the place of the plugin

Review URL: http://codereview.chromium.org/155517
------------------------------------------------------------------------
r20676 | amit@chromium.org | 2009-07-15 00:09:03 +0200 (Wed, 15 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Remove the defunct SetAccelerator message and replace it with an
automation message to set initial settings.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155376
------------------------------------------------------------------------
r20671 | arv@google.com | 2009-07-14 23:40:19 +0200 (Tue, 14 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Update tooltips according to Roma. I ended up calling "Unpin" "Don't
keep on this page" since all the other suggestions are pretty bad as
they are.

BUG=None

TEST=The tooltips should have been updated


Review URL: http://codereview.chromium.org/155532
------------------------------------------------------------------------
r20670 | estade@chromium.org | 2009-07-14 23:34:58 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Re-enable save page ui tests. I could not get these to fail. I will watch the tree after committing.

TBR=evan

Review URL: http://codereview.chromium.org/149595
------------------------------------------------------------------------
r20668 | estade@chromium.org | 2009-07-14 23:34:15 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.mm
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h

Make DownloadShelf a pure interface.

http://crbug.com/15474
TEST=none

Review URL: http://codereview.chromium.org/149594
------------------------------------------------------------------------
r20667 | estade@chromium.org | 2009-07-14 23:33:42 +0200 (Tue, 14 Jul 2009) | 35 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Make GTK file dialog box modal for parent window, instead of for the entire
application.

This works by adding the GtkWindow in BrowserWindowGtk to its own
GtkWindowGroup and adding the SelectFile dialog to the same group. The
following call to gtk_grab_add(...) makes the SelectFile dialog modal, but
only to the windows within the same group.

Similarly, the bookmark manager window is also added to its own unique
GtkWindowGroup, so the import/export dialogs behave correctly.

If I'm understanding things correctly, the GtkWindowGroup objects are
reference counted once the have windows attached to them, and will delete
themselves after all references to them are destroyed. I'm not sure how to
verify this.

Test:

- Open two new chrome window: A and B
- Open "Save file as..." dialog in window A
- Verify that window A does not respond to keyboard or mouse events.
- Verify that window B does responde to keyboard and mouse events.
- Open "Save file as..." dialog in window B
- Verify that window B does not respond to keyboard or mouse events.
- Cancel dialog on window A.
- Verify that window A starts responding to keyboard and mouse events.
- Cancel dialog on window B.
- Verify that window B starts responding to keyboard and mouse events.

BUG=8727

patch by Mohit Muthanna <mmuthanna@google.com>
original review URL: http://codereview.chromium.org/149548

Review URL: http://codereview.chromium.org/155518
------------------------------------------------------------------------
r20664 | phajdan.jr@chromium.org | 2009-07-14 23:23:15 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Add missing include in browser_browsertest.cc, fixing the build.

TBR=nsylvain

Review URL: http://codereview.chromium.org/155531
------------------------------------------------------------------------
r20661 | phajdan.jr@chromium.org | 2009-07-14 23:10:49 +0200 (Tue, 14 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc

Make BrowserTest.ThirtyFourTabs not-flaky

I converted it to browser_tests framework, so I can just query RenderProcessHost instead of counting "chrome" processes, which apparently induced the flakiness.

TEST=Covered by browser_tests.
http://crbug.com/16062

Review URL: http://codereview.chromium.org/149559
------------------------------------------------------------------------
r20658 | hclam@chromium.org | 2009-07-14 23:08:36 +0200 (Tue, 14 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/views/confirm_message_box_dialog.cc
   A /trunk/src/chrome/browser/views/confirm_message_box_dialog.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/chrome.gyp

Adding a message box to confirm if the user really wants to delete all stored
passwords.

Original CL: http://codereview.chromium.org/155291
Patch contributed by: thiago.farina@gmail.com

Review URL: http://codereview.chromium.org/155513
------------------------------------------------------------------------
r20653 | levin@chromium.org | 2009-07-14 22:24:37 +0200 (Tue, 14 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/worker/nativewebworker_impl.h
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome/worker/worker_thread.cc

Make workers functional on OSX and Linux.

BUG=http://crbug.com/16664
TEST=The same tests run for Web Workers on Windows should be run on Linux and OSX.


Review URL: http://codereview.chromium.org/155015
------------------------------------------------------------------------
r20650 | sky@chromium.org | 2009-07-14 22:20:09 +0200 (Tue, 14 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Wires up restoring pinned tabs for session and tab restore
services. And turns on pinned tabs by default on linux.

BUG=16634
TEST=Currently this linux only. Try tab pinning and make sure it works.

Review URL: http://codereview.chromium.org/149621
------------------------------------------------------------------------
r20649 | agl@chromium.org | 2009-07-14 22:18:28 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html

Linux: update splash page.

We support complex text and tab dragging now, so remove those from the
list of non-features. Also, mention font renderer in a bit to stop
people filing bugs for that.

------------------------------------------------------------------------
r20644 | meelapshah@chromium.org | 2009-07-14 22:15:49 +0200 (Tue, 14 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store.cc

Transactionalize ThumbnailStore db operations.

Review URL: http://codereview.chromium.org/149582
------------------------------------------------------------------------
r20643 | erg@google.com | 2009-07-14 22:15:06 +0200 (Tue, 14 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

GTK Themes: Put the bookmark bar in a event box to prevent leaking.

Some engines (clearlooks) query the bg color of a widget directly, so wrap the bookmarkbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through.

http://crbug.com/16382

Review URL: http://codereview.chromium.org/155504
------------------------------------------------------------------------
r20642 | avi@chromium.org | 2009-07-14 22:14:03 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Backing out r20493 (http://codereview.chromium.org/149492), as it inadvertently killed the Omnibox suggestion list.

BUG=http://crbug.com/16714
TEST=Type in the omnibox; you should get a suggestion list.

Review URL: http://codereview.chromium.org/149622
------------------------------------------------------------------------
r20635 | erg@google.com | 2009-07-14 20:38:52 +0200 (Tue, 14 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc

GTK Themes: Initialize theme resources to make download shelf work.

Review URL: http://codereview.chromium.org/149615
------------------------------------------------------------------------
r20633 | avi@chromium.org | 2009-07-14 20:35:34 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

When a page is done loading, every tab change is important.

BUG=http://crbug.com/16087
TEST=as described in the bug

Review URL: http://codereview.chromium.org/149618
------------------------------------------------------------------------
r20627 | robertshield@google.com | 2009-07-14 18:58:29 +0200 (Tue, 14 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Noticed a crash in BrowserRenderProcessHost::SendUserScriptsUpdate due to using channel_->send() directly (instead of BrowserRenderProcessHost::Send() which checks whether channel_ is created).

It looks like this can happen during BrowserRenderProcessHost creation since the brph signs up for notifications at construction but only creates channel_ in its Init() method. 

BUG=http://b/15384


Review URL: http://codereview.chromium.org/155498
------------------------------------------------------------------------
r20625 | kuchhal@chromium.org | 2009-07-14 18:43:15 +0200 (Tue, 14 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   A /trunk/src/chrome/browser/gtk/first_run_bubble.cc
   A /trunk/src/chrome/browser/gtk/first_run_bubble.h
   M /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Linux: Add first run search bubble.

Review URL: http://codereview.chromium.org/149501
------------------------------------------------------------------------
r20624 | darin@chromium.org | 2009-07-14 18:32:59 +0200 (Tue, 14 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/api/public/WebPopupMenuInfo.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   A /trunk/src/webkit/glue/webmenuitem.h
   M /trunk/src/webkit/glue/webmenurunner_mac.h
   M /trunk/src/webkit/glue/webmenurunner_mac.mm
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/glue/webworker_impl.cc
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/webkit.gyp

Replace ShowAsPopupWithItems to CreatePopupWidgetWithInfo.  Also,
make use of WebPopupMenuInfo from the WebKit API.  WebMenuItem
remains in webkit/glue for convenience with IPC marshalling and
related usage in Chrome.

This work is precursor to switching over to using WebWidget from
the WebKit API.

BUG=16234
TEST=html select drop downs should still work on the mac.  try
switching languages on news.google.com.
R=paul

Review URL: http://codereview.chromium.org/155378
------------------------------------------------------------------------
r20619 | pinkerton@chromium.org | 2009-07-14 17:10:57 +0200 (Tue, 14 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/third_party/mozilla/include/NSPasteboard+Utils.h
   A /trunk/src/third_party/mozilla/include/NSPasteboard+Utils.mm
   A /trunk/src/third_party/mozilla/include/NSString+Utils.h
   A /trunk/src/third_party/mozilla/include/NSString+Utils.m
   A /trunk/src/third_party/mozilla/include/NSURL+Utils.h
   A /trunk/src/third_party/mozilla/include/NSURL+Utils.m

Allow dragging text/url content out of the browser. Dragging back in not yet implemented.
BUG=13155
TEST=dragging urls and selected text to other apps, the desktop, or the Dock should work.
Review URL: http://codereview.chromium.org/149565
------------------------------------------------------------------------
r20614 | pfeldman@chromium.org | 2009-07-14 11:29:58 +0200 (Tue, 14 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

DevTools: Focus docked DevTools window on breakpoint.

Review URL: http://codereview.chromium.org/155423
------------------------------------------------------------------------
r20611 | hbono@chromium.org | 2009-07-14 09:03:28 +0200 (Tue, 14 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

A blind fix for Issue 13443.
GTK may sends a GdkKeyEvent whose |keyval| is GDK_KP_Tab in pressing shift+tab keys on an X terminal running on Windows.
This change just adds GDK_KP_Tab to HandleCustomAccelerator() to handle this event.
(This is a blind fix since I don't have any environment that can reproduce this issue.)

(*1) http://mail.gnome.org/archives/gtk-list/1999-September/msg00354.html

BUG=13443 "Shift+Ctrl+Tab should cycle tabs backwards"
TEST=none
Review URL: http://codereview.chromium.org/149519
------------------------------------------------------------------------
r20609 | dimich@google.com | 2009-07-14 08:07:28 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

Fix the ConsoleLog test and enable it. It was previously disabled because WebKit change http://trac.webkit.org/changeset/45786 had split 
the 'type' and 'level' parameters of the ConsoleMessage into 2 separate parameters, which changed the way CSS styles are formatted 
for messages in Inspector front-end. Updated test expectations.
BUG=16684
TEST=the test DevToolsSanityTest.TestConsoleLog is enabled by this CL
Review URL: http://codereview.chromium.org/155482
------------------------------------------------------------------------
r20600 | ananta@chromium.org | 2009-07-14 05:42:55 +0200 (Tue, 14 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/widget/accelerator_handler.cc

Allow TabContentsDelegates to process unhandled keyboard messages coming back from the renderer. This is required
for ExternalTabContainer to be able to pass unhandled keyboard accelerator messages back to the external host.
This worked before as the focus manager would hand off these messages to keystroke listeners like the ExternalTabContainer.
However with the ExternalTabContainer no longer using the focus manager this does not work anymore.

Removed the keystroke listener code from the focus manager as the ExternalTabContainer was the only consumer and it does not use it anymore.

This fixes bug http://b/issue?id=1975749

Bug=1975749


Review URL: http://codereview.chromium.org/149520
------------------------------------------------------------------------
r20595 | mhm@chromium.org | 2009-07-14 03:51:32 +0200 (Tue, 14 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.cc
   M /trunk/src/chrome/browser/dom_ui/print_ui.h
   M /trunk/src/chrome/browser/resources/print_tab.html
   M /trunk/src/chrome/renderer/render_thread.cc

Hookup Print HTML page to the DOM UI for Print Preview and Settings

Depends on initial foundation: 
http://src.chromium.org/viewvc/chrome?view=rev&revision=19906

And html mockup: 
http://src.chromium.org/viewvc/chrome?view=rev&revision=19918

BUG=173, 947
TEST=The user will see the print html page as a html test webpage.
Review URL: http://codereview.chromium.org/155067
------------------------------------------------------------------------
r20593 | dimich@google.com | 2009-07-14 03:24:19 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Temporarily disable TestConsoleLog in interactive_tests. 
BUG=16684
TEST=none
TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/155472
------------------------------------------------------------------------
r20591 | jrg@chromium.org | 2009-07-14 02:58:17 +0200 (Tue, 14 Jul 2009) | 32 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/BookmarkBar.xib
   M /trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

More bookmark bar changes.

* Applied memory cleanliness fix in unit test; follow-up from
  http://codereview.chromium.org/149308.
* Move bookmark bar into it's own nib; minor code refactor to
  accomodate.
* The toolbar STAR button somehow lost it's action; added it back in.
* Implemented delete bookmark notification callback so we behave
  (remove button from the screen) when a bookmark is deleted.
* Added context menus for the bookmark bar and bookmark buttons.
* Hooked up a handful of these menu items.  E.g. 
 - open in new tab, window, incog window
 - delete bookmark (finally)
 - bookmark manager (which then hits a NOTIMPLEMENTED())
 - always show bookmark bar
* Truncate bookmark button text on end, not on middle.
  Experimental to look more like Windows.  
  It looks cleaner but is less Mac-like.
* Add "draws border when mouse goes over" for bookmark buttons.  Need
  to do it by hand since we have a custom button drawing method.

BUG=crbug.com/8381

TEST=Here's a list:
- Make sure the bookmark buttons don't have a border unless the mouse is over them
- Toolbar "STAR" should now add bookmarks when clicked
- Test context menus on bookmark buttons, and the bar itself
- Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g.
  Right click on bookmark --> delete menu item should delete button


Review URL: http://codereview.chromium.org/155358
------------------------------------------------------------------------
r20590 | arv@google.com | 2009-07-14 02:40:25 +0200 (Tue, 14 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/history.html
   A /trunk/src/chrome/browser/resources/i18n_template.js
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/security/resources/ssl_error.html
   M /trunk/src/chrome/browser/security/resources/ssl_roadblock.html
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/common/jstemplate_builder.cc
   M /trunk/src/chrome/common/jstemplate_builder.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/resources/error_no_details.html
   M /trunk/src/chrome/renderer/resources/neterror.html
   M /trunk/src/net/base/dir_header.html

This provides a simpler js template engine than JsTemplate. It has been
optimized for the way we do internationalization with JST before
and is about 4 times faster (average 4.8ms vs 22.8ms) for the history
page.

The syntax for this is very similar to JsTemplates. It uses the
attributes i18n-values and i18n-content which worls like jsvalues and
jscontent except that it does not allow arbitrary expressions.

BUG=None

TEST=All UI pages should work as before

Review URL: http://codereview.chromium.org/149420
------------------------------------------------------------------------
r20586 | avi@chromium.org | 2009-07-14 02:20:52 +0200 (Tue, 14 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Fix unittest; we changed the name of the PDF file that the test was using. (Plus a quick part of the original patch missed on checkin.)

BUG=none
TEST=none

TBR

Review URL: http://codereview.chromium.org/149587
------------------------------------------------------------------------
r20584 | mattm@chromium.org | 2009-07-14 02:14:13 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Add "learn more" link to privacy settings.

BUG=11507

Review URL: http://codereview.chromium.org/149581
------------------------------------------------------------------------
r20581 | sky@chromium.org | 2009-07-14 01:48:48 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.

BUG=16634
TEST=none

Review URL: http://codereview.chromium.org/155441
------------------------------------------------------------------------
r20580 | estade@chromium.org | 2009-07-14 01:48:27 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc

Fix chromium build.

TBR=erg

Review URL: http://codereview.chromium.org/155466
------------------------------------------------------------------------
r20575 | estade@chromium.org | 2009-07-14 01:44:55 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Re-enable previously flaky download ui tests. I can't reproduce the failures. Will watch tree after commit.

TBR=evan

Review URL: http://codereview.chromium.org/155449
------------------------------------------------------------------------
r20574 | estade@chromium.org | 2009-07-14 01:44:14 +0200 (Tue, 14 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

GTK: For the render view, count keyboard grab shadows the same as focus events.

This fixes an age old bug that dropdown menus still looked depressed after you select something from them and they collapse. It also fixes the more recent bug that you could have focus in the render view without any indication drawn by the renderer. I suspect there was a change to webkit that exacerbated this bug, because it seems like something we would have noticed earlier.

Verified in a debugger that showing/hiding a dropdown menu doesn't emit focus signals, but does emit grab notify signals. Also verified that the bug is no longer reproducible in a simple page with <select> and <input> elements.

BUG=16313
TEST=see desc.

Review URL: http://codereview.chromium.org/149506
------------------------------------------------------------------------
r20573 | stuartmorgan@google.com | 2009-07-14 01:44:08 +0200 (Tue, 14 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/keychain_mac.cc
   M /trunk/src/chrome/browser/keychain_mac.h
   M /trunk/src/chrome/browser/keychain_mock_mac.cc
   M /trunk/src/chrome/browser/keychain_mock_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Support individual Keychain item deletion in PasswordStoreMac.
Rename AddLogin to AddPassword for consistency with other method names.
Remove a confusing out param from the form merge check function.

BUG=16486
TEST=Once the UI exists, deleting individual passwords should work on the Mac.

Review URL: http://codereview.chromium.org/155451
------------------------------------------------------------------------
r20572 | estade@chromium.org | 2009-07-14 01:44:00 +0200 (Tue, 14 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK: Force a size on download items and elide the dangerous download filename.

This is a temporary hack that might not work in all locales and definitely won't work if we ever let users change font sizes. GtkLabels are just plain broken. Pango is also broken because you can get height-for-width for a layout but not width-for-height.

Thus we should switch to using skia to draw download items fonts, but this solution will work for now.

BUG=16389
TEST=download the Dansk version of open office for windows

Review URL: http://codereview.chromium.org/155395
------------------------------------------------------------------------
r20571 | estade@chromium.org | 2009-07-14 01:43:48 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc

Don't clobber the previous session when showing about-linux splash page.

BUG=16599
TEST=previous session should restore + linux splash page

Review URL: http://codereview.chromium.org/149555
------------------------------------------------------------------------
r20570 | estade@chromium.org | 2009-07-14 01:43:37 +0200 (Tue, 14 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc

Make chrome version legible in about:chrome dialog for dark themes.

Add Terms of Service link for google chrome (not chromium).

BUG=16544
TEST=use dark theme, look at version in about:chrome

Review URL: http://codereview.chromium.org/155454
------------------------------------------------------------------------
r20569 | estade@chromium.org | 2009-07-14 01:43:24 +0200 (Tue, 14 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Set infobar height on a different widget.

Honestly I'm not completely sure why this is happening, all I know is the internal widget isn't getting sized as large as we want it, so I changed it to take a more direct action to set the size.

BUG=16412
TEST=go to c, see infobar, switch tabs and go back and re-look at infobar. Should look same, with no 4 pixel strip of plainness.

Review URL: http://codereview.chromium.org/149579
------------------------------------------------------------------------
r20568 | tc@google.com | 2009-07-14 01:36:34 +0200 (Tue, 14 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc

Restore RTL icons to CustomDrawButtonBase.

Since moving from ResourceBundle to ThemeProvider, we needed to
plumb through GetRTLEnabledPixbufNamed in ThemeProvider.

Review URL: http://codereview.chromium.org/149483

------------------------------------------------------------------------
r20567 | evan@chromium.org | 2009-07-14 01:35:26 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

posix: show "plugin crashed" info bar when appropriate

Note I fixed a bug in AlertInfoBar while I was at it.

Review URL: http://codereview.chromium.org/155462
------------------------------------------------------------------------
r20565 | munjal@chromium.org | 2009-07-14 01:27:13 +0200 (Tue, 14 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h

Try the original CL "Always persist bookmark IDs" again with the fix to
Valgrind issue. The fix is in bookmark_storage.h - initialized the newly
added member ids_reassigned_ of LoadDetails class.

See http://codereview.chromium.org/149310 for the original CL.

TEST=NONE
BUG=16068

Review URL: http://codereview.chromium.org/155456
------------------------------------------------------------------------
r20564 | mattm@chromium.org | 2009-07-14 01:25:01 +0200 (Tue, 14 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Add cookie behavior combobox.

BUG=11507
TEST=Disable cookie saving and try to login to iGoogle.  Reenable and try again.

Review URL: http://codereview.chromium.org/149574
------------------------------------------------------------------------
r20563 | tc@google.com | 2009-07-14 01:24:08 +0200 (Tue, 14 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

Re-land the patch to elide the status bubble to 1/3 the width of the
window.

Review URL: http://codereview.chromium.org/155432

------------------------------------------------------------------------
r20561 | erg@google.com | 2009-07-14 01:23:08 +0200 (Tue, 14 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

GTK Themes: Refactored to use notifications instead of manual plumbing.

- Removes large amounts of plumbing because:
- All GtkChromeButtons are constructed from GtkThemeProvider which keeps a reference to all live buttons and sends them theme change notifications.
- CustomDrawButtons now subscribe themselves to the BROWSER_THEME_CHANGED notification; this gets rid of a LOT of plubming.
- Removes the GtkThemeProperties struct; just pass the theme provider around.
- Move all the constants from the themes namespace to class statics, per tony's suggestion

Review URL: http://codereview.chromium.org/149547
------------------------------------------------------------------------
r20560 | avi@chromium.org | 2009-07-14 01:22:33 +0200 (Tue, 14 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/app/nibs/en.lproj/TabView.xib
   M /trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib
   D /trunk/src/chrome/app/theme/back.pdf
   A /trunk/src/chrome/app/theme/back_Template.pdf
   D /trunk/src/chrome/app/theme/forward.pdf
   A /trunk/src/chrome/app/theme/forward_Template.pdf
   D /trunk/src/chrome/app/theme/go.pdf
   A /trunk/src/chrome/app/theme/go_Template.pdf
   D /trunk/src/chrome/app/theme/home.pdf
   A /trunk/src/chrome/app/theme/home_Template.pdf
   D /trunk/src/chrome/app/theme/menu_chrome.pdf
   A /trunk/src/chrome/app/theme/menu_chrome_Template.pdf
   A /trunk/src/chrome/app/theme/menu_chrome_rtl_Template.pdf
   D /trunk/src/chrome/app/theme/menu_page.pdf
   A /trunk/src/chrome/app/theme/menu_page_Template.pdf
   A /trunk/src/chrome/app/theme/menu_page_rtl_Template.pdf
   M /trunk/src/chrome/app/theme/nav.pdf
   M /trunk/src/chrome/app/theme/newtab.pdf
   D /trunk/src/chrome/app/theme/reload.pdf
   A /trunk/src/chrome/app/theme/reload_Template.pdf
   D /trunk/src/chrome/app/theme/star.pdf
   A /trunk/src/chrome/app/theme/star_Template.pdf
   M /trunk/src/chrome/app/theme/starred.pdf
   D /trunk/src/chrome/app/theme/stop.pdf
   A /trunk/src/chrome/app/theme/stop_Template.pdf
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.h
   M /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   M /trunk/src/chrome/browser/cocoa/background_gradient_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_view.h
   M /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

Initial support for theming on Mac OS X.

Patch by alcor.

Original review: http://codereview.chromium.org/149204

BUG=http://crbug.com/14451
TEST=Open a theme, watch it apply.

Review URL: http://codereview.chromium.org/155355
------------------------------------------------------------------------
r20554 | thestig@chromium.org | 2009-07-14 00:34:25 +0200 (Tue, 14 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/base/gfx/jpeg_codec.cc
   M /trunk/src/chrome/VERSION
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/process_watcher_posix.cc

Revert r20553.
------------------------------------------------------------------------
r20553 | thestig@chromium.org | 2009-07-14 00:23:53 +0200 (Tue, 14 Jul 2009) | 1 line
Changed paths:
   M /trunk/src
   M /trunk/src/base/gfx/jpeg_codec.cc
   M /trunk/src/chrome/VERSION
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/process_watcher_posix.cc

Additional svn ignores for native_client and Makefile.
------------------------------------------------------------------------
r20550 | tc@google.com | 2009-07-13 23:54:33 +0200 (Mon, 13 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h

Revert "Always persist bookmark IDs."

This reverts commit r20532 because valgrind was complaining
about uninitialized memory:
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/697/steps/valgrind%20test:%20unit/logs/stdio

TBR=munjal

Review URL: http://codereview.chromium.org/155448

------------------------------------------------------------------------
r20544 | erikkay@chromium.org | 2009-07-13 23:40:33 +0200 (Mon, 13 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h

Refactoring handle and dragging a bit in preparation for moles.  The primary change for this is to get rid of the concept of a "current" toolstrip and the idea that there's only one handle around.  Instead, each toolstrip has its own handle and each can be displaying it independently.  There's some initial work for moles in there, but it's disabled since this will require some other plumbing to hook up properly.

Review URL: http://codereview.chromium.org/155192
------------------------------------------------------------------------
r20541 | hclam@chromium.org | 2009-07-13 23:38:38 +0200 (Mon, 13 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc

Fix a memory leak in AudioRendererHost unit test
BUG=16554
TEST=AudioRendererHostTest.MockStreamDataConversation

Review URL: http://codereview.chromium.org/155412
------------------------------------------------------------------------
r20540 | amanda@chromium.org | 2009-07-13 23:33:09 +0200 (Mon, 13 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/webkit/glue/plugins/plugin_list_mac.mm

Add a temporary flag to enable plugins on the Mac and Linux while
leaving the default to "disabled" until they work better.
Temporary, for use by people who like living on the bleeding edge.
BUG=none
TEST=none

jam: review
evan,jon: FYI

Review URL: http://codereview.chromium.org/149570
------------------------------------------------------------------------
r20539 | sky@chromium.org | 2009-07-13 23:30:59 +0200 (Mon, 13 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/chrome/browser/metrics/system_metrics.proto
   A /trunk/src/chrome/browser/metrics/system_metrics_logger.h
   A /trunk/src/chrome/browser/metrics/system_metrics_logger_impl.cc
   A /trunk/src/chrome/browser/metrics/system_metrics_logger_impl.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h
   M /trunk/src/chrome/chrome.gyp

Lands http://codereview.chromium.org/149404 for cmasone:

Adding a protobuf-based metrics communication scheme between Chrome OS and
Chrome.  Essentially, Chrome is used as a metrics upload service, and this hacks
in a simple IPC mechanism for Chrome OS to use to communicate metrics info to
Chrome for upload.  We eventually want to do this using protobuffers over DBus,
but this protobuffers-over-X-properties mechanism will work for now.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/149459
------------------------------------------------------------------------
r20538 | rohitrao@chromium.org | 2009-07-13 23:29:06 +0200 (Mon, 13 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Changes Mac behavior to reblit the entire RWHVCocoa when scrolling.
This fixes the trails left behind when scrolling with the findbar open.

BUG=16124
TEST=Scroll with the find bar or popup blocker open.  Make sure there are
no trails left behind or other drawing issues.
Review URL: http://codereview.chromium.org/149556
------------------------------------------------------------------------
r20537 | stuartmorgan@google.com | 2009-07-13 23:29:01 +0200 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h

Don't store blacklist entries in the keychain.

BUG=none
TEST=none; mac password storage has no UI yet. (Once it does: opting never to remember passwords for a site should not create a Keycahin entry.)

Review URL: http://codereview.chromium.org/155389
------------------------------------------------------------------------
r20532 | munjal@chromium.org | 2009-07-13 23:17:39 +0200 (Mon, 13 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h

Always persist bookmark IDs.
Remove the preference to persist IDs.
NOTE that we need to save the file the first time with IDs
since existing bookmark files won't have IDs and the file
won't be saved until something changes in the bookmark model.
So we need to explicitly save once when we assign ids for the
first time.

TEST=NONE
BUG=16068

Review URL: http://codereview.chromium.org/149310
------------------------------------------------------------------------
r20523 | sky@chromium.org | 2009-07-13 22:47:12 +0200 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Adds rendering and dragging of pinned tabs to gtk.

BUG=16634
TEST=not yet

Review URL: http://codereview.chromium.org/149544
------------------------------------------------------------------------
r20519 | mpcomplete@chromium.org | 2009-07-13 22:38:56 +0200 (Mon, 13 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Add an optional channel name to the extension message connect event.

Also changed the way port IDs work internally to reduce confusion.  Each end of the port has its own ID, not the ID of its opposite end.

BUG=13706
TEST=no

Review URL: http://codereview.chromium.org/155381
------------------------------------------------------------------------
r20508 | mirandac@chromium.org | 2009-07-13 21:17:38 +0200 (Mon, 13 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc

Fix minor naming issue (see http://codereview.chromium.org/149255).

Review URL: http://codereview.chromium.org/155435
------------------------------------------------------------------------
r20501 | pfeldman@chromium.org | 2009-07-13 19:33:53 +0200 (Mon, 13 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Focus last focused view when DevTools window is being closed or undocked.

Review URL: http://codereview.chromium.org/155345
------------------------------------------------------------------------
r20495 | shess@chromium.org | 2009-07-13 18:39:04 +0200 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] AcceptInput() doesn't really need focus (as when called via "Go" button).

http://crbug.com/15811
TEST=Browse to www.google.com.  Focus is in document.  Click Go.  No more crash.

Review URL: http://codereview.chromium.org/149487
------------------------------------------------------------------------
r20494 | shess@chromium.org | 2009-07-13 18:38:30 +0200 (Mon, 13 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Always restyle omnibox after user input.

Previous version was perhaps too optimal.  This should be reasonable
for now since it only happens at the pace the user can enter input.

http://crbug.com/14628
TEST=Browse to www.google.com.  Copy/paste the entire URL.  Should be styled.

Review URL: http://codereview.chromium.org/149489
------------------------------------------------------------------------
r20493 | shess@chromium.org | 2009-07-13 18:37:15 +0200 (Mon, 13 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

[Mac] Remove guard on FocusLocation() in autocomplete field.

I went auditing around, and AFAICT all remaining callers should be
fine with selecting everything.

http://crbug.com/12246
TEST=Type some stuff in address bar.  With cursor in bar, Command-l should select all.

Review URL: http://codereview.chromium.org/149492
------------------------------------------------------------------------
r20491 | sverrir@chromium.org | 2009-07-13 18:11:08 +0200 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   A /trunk/src/printing/image.cc
   A /trunk/src/printing/image.h
   M /trunk/src/printing/printing.gyp

Extract Image class so it can be used in more tests.

BUG=none
TEST=none (no functional change).

Review URL: http://codereview.chromium.org/149410
------------------------------------------------------------------------
r20489 | brettw@chromium.org | 2009-07-13 18:03:49 +0200 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/net/metadata_url_request.cc
   A /trunk/src/chrome/browser/net/metadata_url_request.h
   M /trunk/src/chrome/chrome.gyp

Add a dummy URL request handler.

This metadata request just returns a dummy string for the "metadata" scheme.
This doesn't do anything yet.

Review URL: http://codereview.chromium.org/149490
------------------------------------------------------------------------
r20488 | phajdan.jr@chromium.org | 2009-07-13 17:50:19 +0200 (Mon, 13 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/history_publisher_win.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_database.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/page_usage_data.cc
   M /trunk/src/chrome/browser/history/page_usage_data.h
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/visit_tracker.cc
   M /trunk/src/chrome/browser/history/visit_tracker.h
   M /trunk/src/chrome/browser/history/visitsegment_database.cc

Reduce header dependencies in browser/history

Review URL: http://codereview.chromium.org/140047
------------------------------------------------------------------------
r20484 | ananta@chromium.org | 2009-07-13 17:02:41 +0200 (Mon, 13 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Added an async automation message AutomationMsg_PrintAsync to asynchronously print a TabContents.
This is on the same lines as the existing sync message AutomationMsg_PrintNow

Review URL: http://codereview.chromium.org/149468
------------------------------------------------------------------------
r20483 | erikkay@chromium.org | 2009-07-13 16:59:01 +0200 (Mon, 13 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/common/extensions/extension_constants.cc
   A /trunk/src/chrome/common/extensions/extension_constants.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Refactor extension constants to improve readability, debugging, and to make it easier to add new constants.

Review URL: http://codereview.chromium.org/155407
------------------------------------------------------------------------
r20479 | pfeldman@chromium.org | 2009-07-13 16:17:49 +0200 (Mon, 13 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h

DevTools: Toggle docked devtools window on shortcut.

Review URL: http://codereview.chromium.org/149527
------------------------------------------------------------------------
r20477 | nsylvain@chromium.org | 2009-07-13 16:10:34 +0200 (Mon, 13 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc

Revert 20451 because it caused memory leaks.

Memory Leak: (40 bytes, 1 blocks) AudioManagerWin::MakeAudioStream(Format::AudioManager,int,int,char) [unit_tests.exe]
Alloc Location
   ...
   media/audio/win/audio_output_win.cc:126  AudioManagerWin::MakeAudioStream(Format::AudioManager,int,int,char)
   chrome/browser/renderer_host/audio_renderer_host.cc:118  AudioRendererHost::IPCAudioSource::CreateIPCAudioSource(AudioRendererHost *,int,int,int,void *,Format::AudioManager,int,int,char,UINT,UINT)
   chrome/browser/renderer_host/audio_renderer_host_unittest.cc:161  AudioRendererHostTest::CreateAudioStream(Format::AudioManager)
   chrome/browser/renderer_host/audio_renderer_host_unittest.cc:174  AudioRendererHostTest::CreateMockStream(void)
   chrome/browser/renderer_host/audio_renderer_host_unittest.cc:191  AudioRendererHostTest_MockStreamDataConversation_Test::TestBody(void)
   testing/gtest/src/gtest.cc:2031  testing::Test::Run(void)
   ^^^
   

Review URL: http://codereview.chromium.org/149536
------------------------------------------------------------------------
r20471 | glen@chromium.org | 2009-07-12 18:43:52 +0200 (Sun, 12 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc

Reverting 20468.
Review URL: http://codereview.chromium.org/149514
------------------------------------------------------------------------
r20470 | glen@chromium.org | 2009-07-12 05:09:13 +0200 (Sun, 12 Jul 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Commit for tfarina

Original CL:
http://codereview.chromium.org/155060
This patch changes the behavior of clear search button in cookies_view to work
as in firefox.
When the dialog is launched the clear search button in the old cookie_view the
state of this button is enabled,
but the text field is empty, so the correct behavior is  make the button
disabled. Only when the user start typing
in the text field, the clear button will be enabled.

BUG=None
TEST=None


------------------------------------------------------------------------
r20469 | glen@chromium.org | 2009-07-12 05:09:05 +0200 (Sun, 12 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.h

Commit for tfarina

Original CL:
http://codereview.chromium.org/155059
A patch to make the grid column (table_view) of the passwords_page_view and
exceptions_page_view have the same size.
Without this, the table_view of exceptions_page_view has a width bigger than the
passwords_page_view.

BUG=None
TEST=None


------------------------------------------------------------------------
r20468 | glen@chromium.org | 2009-07-12 05:08:53 +0200 (Sun, 12 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc

Commit for tfarina

Original CL:
http://codereview.chromium.org/155076
Add the menus copy, cut and paste to BookmarkBar and BookmarkMenu.

BUG=5354
TEST=None


------------------------------------------------------------------------
r20466 | mirandac@chromium.org | 2009-07-12 04:59:07 +0200 (Sun, 12 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/ui/ui_test.cc

Turn backend tip service on by default.

BUG= none.
TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget.


Review URL: http://codereview.chromium.org/149255
------------------------------------------------------------------------
r20451 | hclam@chromium.org | 2009-07-11 03:43:40 +0200 (Sat, 11 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc

Unit tests for AudioRendererHost

Review URL: http://codereview.chromium.org/155397
------------------------------------------------------------------------
r20441 | stuartmorgan@chromium.org | 2009-07-11 01:40:28 +0200 (Sat, 11 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_win.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h

Add the rest of the password manager API to PasswordStore, and move clients
off of WebDataService. The methods are unimplemented on the Mac for the
moment, and do passthroughs to WDS on Windows as with the rest of the Windows
PasswordStore interface.

BUG=none
TEST=Saving, viewing, and deleting password should still work on Windows.
Review URL: http://codereview.chromium.org/155259
------------------------------------------------------------------------
r20438 | shess@chromium.org | 2009-07-11 01:19:36 +0200 (Sat, 11 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h

-orderBack: unit test windows when not in the debugger.

Review URL: http://codereview.chromium.org/149465
------------------------------------------------------------------------
r20436 | tc@google.com | 2009-07-11 01:10:42 +0200 (Sat, 11 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/base/base_drag_source.cc
   M /trunk/src/base/base_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h

Fix a crash that happens if a tab is closed while
we're in the middle of a drag originating from the tab.

The problem is that the tab gets deleted out from under the
drag operation which is happening in a nested message loop.

To work around this, if we're in the middle of a drag and
we get a tab close request, delay the tab close until after
the drag operation is finished.

BUG=16280

Review URL: http://codereview.chromium.org/149466
------------------------------------------------------------------------
r20433 | asargent@chromium.org | 2009-07-11 00:58:19 +0200 (Sat, 11 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Disable extension auto-updating (hopefully temporarily)

We may need to make a few changes before we're ready for this to be live,
so we're disabling for now.

BUG=12117
TEST=none


Review URL: http://codereview.chromium.org/155388
------------------------------------------------------------------------
r20432 | paul@chromium.org | 2009-07-11 00:47:08 +0200 (Sat, 11 Jul 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc

Ensure proper paths when saving pages with no title.

When saving a page with no title, such as a text file, attempt to
use a sane value for the save name by retrieving the last component
of the URL (if one exists).

This prevents the case where a page http://www.foo.com/a/path/name.txt
is saved as file "http www" with extension type "foo.com a path name.txt".

This change also makes the SavePackage code a little more flexible
and simpler to test.

BUG=none
TEST=Covered by unittest.

Review URL: http://codereview.chromium.org/155266
------------------------------------------------------------------------
r20431 | sky@chromium.org | 2009-07-11 00:44:14 +0200 (Sat, 11 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/panel_controller.cc

Fixed compile breakage resulting from wstring to string16 change.

BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/149484
------------------------------------------------------------------------
r20430 | asargent@chromium.org | 2009-07-11 00:42:10 +0200 (Sat, 11 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater.cc
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Fix leaks in ExtensionUpdater unit tests

BUG=http://crbug.com/16444
TEST=none

Review URL: http://codereview.chromium.org/149479
------------------------------------------------------------------------
r20428 | tc@google.com | 2009-07-11 00:40:50 +0200 (Sat, 11 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix UMR caused by ActiveWindowWatcher.

As spotted by the valgrind ui_tests buildbot.

BUG=16473

Review URL: http://codereview.chromium.org/149486

------------------------------------------------------------------------
r20427 | estade@chromium.org | 2009-07-11 00:37:47 +0200 (Sat, 11 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/profile.cc

Instead of forcing the homepage to be linux splash, force the startup action to be "view linux splash page".

Thus users can still use the home button until we get rid of the splash page.

BUG=16308
TEST=none.

Review URL: http://codereview.chromium.org/149481
------------------------------------------------------------------------
r20425 | scherkus@chromium.org | 2009-07-10 23:58:00 +0200 (Fri, 10 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc

Revert "Unit tests for AudioRendererHost"

TBR=hclam
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149485

------------------------------------------------------------------------
r20424 | estade@chromium.org | 2009-07-10 23:40:54 +0200 (Fri, 10 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Fix double click item activation in right pane of bookmark manager.

BUG=none
TEST=double click on an unselected item, it should be activated

Review URL: http://codereview.chromium.org/155368
------------------------------------------------------------------------
r20423 | hclam@chromium.org | 2009-07-10 23:40:20 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Enable a ui test that plays video without audio stream
TEST=MediaTest.VideoBearSilentTheora
BUG=16012

Review URL: http://codereview.chromium.org/155375
------------------------------------------------------------------------
r20422 | hclam@chromium.org | 2009-07-10 23:40:12 +0200 (Fri, 10 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc

Unit tests for AudioRendererHost
TEST=AudioRendererHostTest.CreateStream
     AudioRendererHostTest.MockStreamDataConversation
BUG=16035

Review URL: http://codereview.chromium.org/150191
------------------------------------------------------------------------
r20419 | hclam@chromium.org | 2009-07-10 23:08:22 +0200 (Fri, 10 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h

Fix a bug in AudioRendererHost and add hooks for test


Review URL: http://codereview.chromium.org/155372
------------------------------------------------------------------------
r20414 | evan@chromium.org | 2009-07-10 22:53:11 +0200 (Fri, 10 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h

plugins: use OnChannelError to detect when the channel goes away

Previously we used a special Watcher object to watch the process,
but that is not portable to POSIX and this is simpler anyway.
With this change, I now see ~PluginProcessHost() running when a
plugin crashes.

If you recall all the way back to
  http://codereview.chromium.org/16814
we did a similar thing to the renderer host.

Review URL: http://codereview.chromium.org/155331
------------------------------------------------------------------------
r20413 | arv@google.com | 2009-07-10 22:50:16 +0200 (Fri, 10 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix DnD jank

The mouseover code I added to do *smart* tooltips was making DnD almost
unusable.

BUG=None

TEST=Drag thumbnails on the NNTP and they should move smoothly.

Review URL: http://codereview.chromium.org/149427
------------------------------------------------------------------------
r20406 | thestig@chromium.org | 2009-07-10 22:14:40 +0200 (Fri, 10 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/app/theme/new_browser_window.png
   M /trunk/src/chrome/app/theme/tab_overview.png
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extension_event_names.cc
   M /trunk/src/chrome/browser/extensions/extension_event_names.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/common/extensions/extension_error_utils.cc
   M /trunk/src/chrome/common/extensions/extension_error_utils.h
   M /trunk/src/chrome/common/transport_dib.h
   M /trunk/src/chrome/common/transport_dib_linux.cc
   M /trunk/src/chrome/common/transport_dib_mac.cc
   M /trunk/src/chrome/common/transport_dib_win.cc
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/test/data/extensions/bad/Preferences
   M /trunk/src/chrome/test/data/extensions/bad_magic.crx
   M /trunk/src/chrome/test/data/extensions/bad_signature.crx
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/page.html
   M /trunk/src/chrome/test/data/extensions/good/Preferences
   M /trunk/src/chrome/test/data/extensions/good.pem
   M /trunk/src/chrome/test/data/extensions/good2.crx
   M /trunk/src/chrome/test/data/extensions/samples/getviews/bg.html
   M /trunk/src/chrome/test/data/extensions/samples/getviews/common.css
   M /trunk/src/chrome/test/data/extensions/samples/getviews/common.js
   M /trunk/src/chrome/test/data/extensions/samples/getviews/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/getviews/ts1.html
   M /trunk/src/chrome/test/data/extensions/samples/getviews/ts2.html
   M /trunk/src/chrome/test/data/extensions/test_file.html
   M /trunk/src/chrome/test/data/extensions/theme_with_missing_image.crx
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html
   M /trunk/src/chrome/test/data/zip/test.zip
   M /trunk/src/chrome/test/data/zip/test_nocompress.zip
   M /trunk/src/net/data/url_request_unittest/redirect307-to-echoall
   M /trunk/src/net/data/url_request_unittest/redirect307-to-echoall.mock-http-headers
   M /trunk/src/sandbox/tools/launcher/launcher.vcproj

Remove svn:executable property from some more files that don't need it.

TBR=evmar
Review URL: http://codereview.chromium.org/149471
------------------------------------------------------------------------
r20404 | jhawkins@chromium.org | 2009-07-10 21:59:02 +0200 (Fri, 10 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Fix a few issues with the drop arrow in the Linux tab strip:
* Reset the drop info when completing a drag (successful or otherwise).
* Reset the drop info when the drag leaves the tab strip zone.
* Report success or failure of the drop back to the source widget.
* Move and resize the drop arrow container before showing it to reduce visual jank.

BUG=none
TEST=Drag a image into the tab strip so that the drop arrow appears.  Release the drop over the tab strip and then move the window and repeat the process.  The drop arrow should be in the correct position.  Notice that there is no visual jank when the drop arrow is shown.
Review URL: http://codereview.chromium.org/149426
------------------------------------------------------------------------
r20403 | erg@google.com | 2009-07-10 21:55:30 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

GTK Themes: Set bg/text colors for the download shelf.

(This does not change the button image.)

Review URL: http://codereview.chromium.org/155365
------------------------------------------------------------------------
r20402 | tc@google.com | 2009-07-10 21:41:53 +0200 (Fri, 10 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

Revert "Revert "Add button tinting to the toolbar buttons.""

This reverts commit r20399 and re-applies the button tinting
code.  There's a fix for the go button gtk unittest by checking
to see if the browser is non-NULL before getting the theme provider.

TBR=erg

Review URL: http://codereview.chromium.org/155369

------------------------------------------------------------------------
r20400 | phajdan.jr@chromium.org | 2009-07-10 21:33:18 +0200 (Fri, 10 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Convert JavascriptAlertActivatesTab to browser_tests framework.

This should make it non-flaky, so I un-disabled the test. I also added necessary plumbing so we can
wait for AppModalDialog to appear and close it.

TEST=Covered by browser_tests.
http://crbug.com/16062

Review URL: http://codereview.chromium.org/149460
------------------------------------------------------------------------
r20399 | tc@google.com | 2009-07-10 21:16:39 +0200 (Fri, 10 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

Revert "Add button tinting to the toolbar buttons."

This reverts commit r20396.

TBR=erg

Review URL: http://codereview.chromium.org/155367

------------------------------------------------------------------------
r20398 | agl@chromium.org | 2009-07-10 21:14:31 +0200 (Fri, 10 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/sandbox/linux/suid/sandbox.cc

Linux: don't bother passing the chroot directory fd to the zygote.

Markus pointed out that the cwd was already shared between the chroot
helper process and the zygote, therefore we could avoid some
complexity in passing the file descriptor so, also, we could then make
the directory mode 0000.

http://codereview.chromium.org/155366
BUG=16363

------------------------------------------------------------------------
r20396 | tc@google.com | 2009-07-10 21:06:29 +0200 (Fri, 10 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

Add button tinting to the toolbar buttons.

Make CustomDrawButtonBase aware of the ThemeProvider.  If the
theme changes, we reload new pixbufs from the ThemeProvider.

This breaks RTL of the toolbar buttons, I'll add that back
in a follow up change to BrowserThemeProvider.

BUG=15506
TEST=Change themes or set the GTK+ theme.  The star button and go button should be tinted according to the theme (other buttons as well if not using GTK+ buttons).

Review URL: http://codereview.chromium.org/149432

------------------------------------------------------------------------
r20395 | pkasting@chromium.org | 2009-07-10 20:41:52 +0200 (Fri, 10 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Fix a crash when clicking a popup entry while composing in the Microsoft IME on XP.

We were forcing the IME to close during the process of updating the edit, which in turn caused us to try and handle "changes to the edit", leading to us (wrongly) rerunning autocomplete and blowing away our result set.

BUG=13500
TEST=On XP, open a new tab, set the (Microsoft) IME to Hiragana, type 'c', and then click an entry in the popup.  The browser should navigate, not crash.
Review URL: http://codereview.chromium.org/155330
------------------------------------------------------------------------
r20393 | asargent@chromium.org | 2009-07-10 20:40:18 +0200 (Fri, 10 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc

Temporarily disable unit tests with leaks until I can check in a fix for them.

BUG=http://crbug.com/16444
TEST=none
TBR=eroman


Review URL: http://codereview.chromium.org/155362
------------------------------------------------------------------------
r20389 | estade@chromium.org | 2009-07-10 20:23:58 +0200 (Fri, 10 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

A little bit of bookmark bar cleanup, a little bit of padding improvement.

The spacing between the toolbar buttons now matches windows pixel for pixel (tested empirically).

The bookmark bar item spacing is now a little better, but we need some hackery to improve it to the state of windows (we need to annex about 5 pixels from the toolbar when the bookmark bar is open).

The code for packing bookmark bar buttons is now all in one place.

Functional change: There will be no other bookmarks button until the model is loaded. If you care I can fix this, it just doesn't seem like a very important matter since it's unusable anyway when the model isn't loaded.o

I also removed a log warning from chrome_dll_main because with this change it started spamming a lot. We're already living with this warning, and have a bug filed for it (they fixed the root problem in newer versions of gtk so I think this bug will just never get resolved), so I don't think this is a big deal.

BUG=15870
TEST=things look marginally better, theming still works properly
Review URL: http://codereview.chromium.org/155342
------------------------------------------------------------------------
r20388 | agl@chromium.org | 2009-07-10 20:17:32 +0200 (Fri, 10 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/sandbox/linux/suid/sandbox.cc

Linux: use a temp directory for the chroot.

Ubuntu systems (at least) wipe /var/run at boot time, which is
deleting our sandbox directory. Instead, we have the SUID helper
create a temp directory in /tmp, unlink it and use that for the chroot
directory. A file descriptor is passed to the zygote process for it to
fchdir into.

(Thanks to fta for discussions on this.)

BUG=16363

------------------------------------------------------------------------
r20387 | rafaelw@chromium.org | 2009-07-10 20:13:46 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc

ExtensionBrowserEventRouter now observes TAB_CONTENTS_DESTROYED. This became necessary with the addition of dockable devtools TabContents. It is now possible for Tab contents to close after having been detached without being re-attached to a browser (as in the case of docking).

TBR=pfeldman

Review URL: http://codereview.chromium.org/149429
------------------------------------------------------------------------
r20383 | agl@chromium.org | 2009-07-10 19:50:24 +0200 (Fri, 10 Jul 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_main_linux.cc

Linux: all the binary to be readable with the SUID sandbox.

Previously, we required that the binary be non-readable. This causes the
kernel to mark the process as non-dumpable at startup. The thinking was
that, although we were putting the renderers into a PID namespace (with
the SUID sandbox), they would none the less be in the /same/ PID
namespace. So they could ptrace each other unless they were non-dumpable.

If the binary was readable, then there would be a window between process
startup and the point where we set the non-dumpable flag in which a
compromised renderer could ptrace attach.

However, now that we have a zygote model, only the (trusted) zygote
exists at this point and we can set the non-dumpable flag which is
inherited by all our renderer children.

------------------------------------------------------------------------
r20381 | rohitrao@chromium.org | 2009-07-10 19:45:48 +0200 (Fri, 10 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm

Broke my own unittest.  The expected behavior when calling
clearResults: is to not delete the existing find text, which
seems strange but matches the other platforms.

BUG=None
TEST=Fixes the build
Review URL: http://codereview.chromium.org/149463
------------------------------------------------------------------------
r20380 | mdm@chromium.org | 2009-07-10 19:08:16 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/chrome/browser/shell_integration_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   A /trunk/src/chrome/tools/build/linux/chrome-wrapper
   M /trunk/src/third_party

Add default browser checking and setting on Linux.
BUG=11972
TEST=none

Review URL: http://codereview.chromium.org/155100
------------------------------------------------------------------------
r20379 | asargent@chromium.org | 2009-07-10 18:43:17 +0200 (Fri, 10 Jul 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_updater.cc
   A /trunk/src/chrome/browser/extensions/extension_updater.h
   A /trunk/src/chrome/browser/extensions/extension_updater_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Implementation of Extension Updater.

This also contains changes to the ExtensionsService to hook up the ExtensionUpdater. 

BUG=http://crbug.com/12117
TEST=Extensions still work


Review URL: http://codereview.chromium.org/149213
------------------------------------------------------------------------
r20378 | sidchat@google.com | 2009-07-10 18:41:27 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/french_sentence.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   A /trunk/src/chrome/test/data/extensions/samples/cld
   A /trunk/src/chrome/test/data/extensions/samples/cld/manifest.json
   A /trunk/src/chrome/test/data/extensions/samples/cld/toolstrip.html

Add getLanguage function to tab extension.

BUG=none
TEST=enable extensions using the toolstip.html code (added with this CL) and load pages in different languages. The corresponding language should appear in the bottom left after the page is loadedm or when the button is clicked, or when you navigate back to that tab after visiting some other tab.
Review URL: http://codereview.chromium.org/150062
------------------------------------------------------------------------
r20377 | rohitrao@chromium.org | 2009-07-10 18:36:28 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/webkit/glue/webframe_impl.cc

Enables find in page match counts on Mac.

BUG=http://crbug.com/16148
TEST=Find in page should report match counts correctly.
Review URL: http://codereview.chromium.org/155353
------------------------------------------------------------------------
r20376 | phajdan.jr@chromium.org | 2009-07-10 17:45:19 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc

Properly restart extensions with no visible UI.

http://crbug.com/16070

Review URL: http://codereview.chromium.org/149416
------------------------------------------------------------------------
r20370 | hbono@chromium.org | 2009-07-10 10:32:52 +0200 (Fri, 10 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

A quick fix for Issue 15971.

This is another my stupid mistake that my r19238 sends a Char event even when its text[] member does not contains any characters.
I mis-understoold I needed to send a Char event every time when gtk_keyval_to_unicode() returns 0 to avoid Issue 15024. But this is wrong.
(Page Down, Page Up, Arrow Keys work without Char events. Only return keys need Char events.)

BUG=15971 "drop down list moves 2 positions when using the keyboard".
TEST=Open the attached test-case
Review URL: http://codereview.chromium.org/155207
------------------------------------------------------------------------
r20354 | evan@chromium.org | 2009-07-10 04:10:16 +0200 (Fri, 10 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h

Revert "plugins: use OnChannelError to detect when the channel goes away"

This reverts commit r20349.
Unit test failure.  I suspect the test, but let's keep the tree green.
------------------------------------------------------------------------
r20349 | evan@chromium.org | 2009-07-10 03:18:41 +0200 (Fri, 10 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h

plugins: use OnChannelError to detect when the channel goes away

Previously we used a special Watcher object to watch the process,
but that is not portable to POSIX and this is simpler anyway.
With this change, I now see ~PluginProcessHost() running when a
plugin crashes.

If you recall all the way back to
  http://codereview.chromium.org/16814
we did a similar thing to the renderer host.

Review URL: http://codereview.chromium.org/155331
------------------------------------------------------------------------
r20348 | ben@chromium.org | 2009-07-10 03:01:16 +0200 (Fri, 10 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Fix another string conversion with UTF16ToWideHack
------------------------------------------------------------------------
r20345 | ben@chromium.org | 2009-07-10 02:53:24 +0200 (Fri, 10 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_browsertest.cc

Fix another string conversion with UTF16ToWideHack
------------------------------------------------------------------------
r20344 | erg@google.com | 2009-07-10 02:46:27 +0200 (Fri, 10 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc

GTK Themes: Provide the correct inactive frame tint color.

Review URL: http://codereview.chromium.org/149435
------------------------------------------------------------------------
r20343 | ben@chromium.org | 2009-07-10 02:44:42 +0200 (Fri, 10 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

fix mac compile bustage - use a different string conversion function for GetCurrentPageTitle.
------------------------------------------------------------------------
r20342 | ben@chromium.org | 2009-07-10 02:33:29 +0200 (Fri, 10 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Convert some stuff to string16 so the toolkit_views build can build again
Review URL: http://codereview.chromium.org/155334
------------------------------------------------------------------------
r20339 | jam@chromium.org | 2009-07-10 02:05:15 +0200 (Fri, 10 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/test/data/showmodaldialog_dialog.html

Fix window.close() not working for modal dialogs.

BUG=16374
TEST=added regression test
Review URL: http://codereview.chromium.org/149412
------------------------------------------------------------------------
r20333 | estade@chromium.org | 2009-07-10 00:58:58 +0200 (Fri, 10 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Improve performance of dragged tab renderering.

Do as much as possible server side.

I suspect the main factors that made our previous implementation slow were blitting from client to server, several unnecessary copies of the entire image, and doing an in-memory rgba->bgra swap.

Now, even in debug mode with a 30" chrome window, the performance is very fast.

BUG=16257,15869
TEST=drag a tab out of the tabstrip, with and without compositing

Review URL: http://codereview.chromium.org/155321
------------------------------------------------------------------------
r20326 | estade@chromium.org | 2009-07-10 00:01:35 +0200 (Fri, 10 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Always let other handlers run for render area mouse clicks.

BUG=none
TEST=context menu shows when you right click (and doesn't immediately disappear)

Review URL: http://codereview.chromium.org/149417
------------------------------------------------------------------------
r20324 | brettw@chromium.org | 2009-07-10 00:00:21 +0200 (Fri, 10 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Move some more interfaces on RenderViewHostDelegate to separate classes. The
ones in the patch are those that are implemented by other classes, avoiding
TabContents pass-throughs.
Review URL: http://codereview.chromium.org/149373
------------------------------------------------------------------------
r20321 | estade@chromium.org | 2009-07-09 23:40:47 +0200 (Thu, 09 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Remove dead code in RWHV Gtk.

The code was introduced in r13044  and should have been removed in r13396 (when the majority of r13044 was undone).

BUG=16195
TEST=selection clipboard still works in render view, memory leak is gone

Review URL: http://codereview.chromium.org/149358
------------------------------------------------------------------------
r20320 | erg@google.com | 2009-07-09 23:40:35 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK Themes: "Other bookmarks" button should use correct borders.

Review URL: http://codereview.chromium.org/155322
------------------------------------------------------------------------
r20318 | sky@chromium.org | 2009-07-09 23:34:18 +0200 (Thu, 09 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Adds code to position the tab overview button during animations. It
appears that some times Layout isn't invoked on initial size, so that
positioning the tab overview button only during Layout isn't enough.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155306
------------------------------------------------------------------------
r20316 | finnur@chromium.org | 2009-07-09 23:30:53 +0200 (Thu, 09 Jul 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.h
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html
   A /trunk/src/chrome/test/data/feeds
   A /trunk/src/chrome/test/data/feeds/feed.html
   A /trunk/src/chrome/test/data/feeds/feed1.xml
   A /trunk/src/chrome/test/data/feeds/feed2.xml
   A /trunk/src/chrome/test/data/feeds/feed_invalid1.xml
   A /trunk/src/chrome/test/data/feeds/feed_invalid2.xml
   A /trunk/src/chrome/test/data/feeds/no_feed.html
   M /trunk/src/chrome/test/test_location_bar.h

Add a rudamentary feed preview to the RSS extension. It
doesn't handle inline HTML in the item description (it just
dumps it as text) and the feed needs to be valid XML for it
to show any preview, but it is better than nothing. We can
easily change it to display the HTML but we want to (at some
point) try to use a separate origin so that we can render
the HTML code from untrusted sources safely.

Also fix a bug in the image tracker. It should not try 
to communicate with the view if the view has gone away
(which was the whole point of the image tracker...)

BUG=None
TEST=Install the extension, browse to a page with a feed
and click onthe rss icon in the Omnibox. An interstitial
page should appear with a preview of the feed.
Review URL: http://codereview.chromium.org/155180
------------------------------------------------------------------------
r20314 | jhawkins@chromium.org | 2009-07-09 23:21:24 +0200 (Thu, 09 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc

Use the calculated dragged tab bounds when rendering the screenshot into the canvas.

BUG=15869
TEST=Drag a tab out of the Linux tab strip.  There should be a light-blue border around the dragged tab contents.
Review URL: http://codereview.chromium.org/155317
------------------------------------------------------------------------
r20313 | tc@google.com | 2009-07-09 23:20:52 +0200 (Thu, 09 Jul 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/active_window_watcher.cc
   A /trunk/src/chrome/browser/gtk/active_window_watcher.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Change the window background color to the inactive color when the
window manager says the window isn't active.

ActiveWindowWatcher listens for X events and notifies the browser
windows when the active window changes.  We can't just use focus
events because popup menus cause browser windows to lose focus,
but it's still the "active" window.

Some window managers don't track active window, in which case we
don't get the x event and we just say that all windows are
active (our current behavior).

BUG=14649

Review URL: http://codereview.chromium.org/155303

------------------------------------------------------------------------
r20312 | thomasvl@chromium.org | 2009-07-09 23:19:35 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/nsimage_cache.mm

If the init returns nil (don't throw) don't try to store that into the dict.
Fix typo.
Review URL: http://codereview.chromium.org/155318
------------------------------------------------------------------------
r20311 | erg@google.com | 2009-07-09 23:11:18 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc

GTK Theme: Localize "GTK Theme" button.

Review URL: http://codereview.chromium.org/149411
------------------------------------------------------------------------
r20310 | arv@google.com | 2009-07-09 23:07:16 +0200 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Make the filename in the downloads page wrap.

BUG=15148

TEST=Download a large file with a very long file name. The file name should wrap.

Review URL: http://codereview.chromium.org/149349
------------------------------------------------------------------------
r20309 | thomasvl@chromium.org | 2009-07-09 22:59:32 +0200 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   A /trunk/src/chrome/browser/cocoa/nsimage_cache.h
   A /trunk/src/chrome/browser/cocoa/nsimage_cache.mm
   A /trunk/src/chrome/browser/cocoa/nsimage_cache_unittest.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

Added an helper namespace that provides fetches images from the app bundle and caches them, line NSImage imageNamed: but lets us control the bundle that's checked.
Unittest for the helper.
Updated the current places that use +[NSImage imageNamed:] to use our cache helper.

BUG=none
TEST=All the ui images still load.
Review URL: http://codereview.chromium.org/149393
------------------------------------------------------------------------
r20308 | erg@google.com | 2009-07-09 22:35:19 +0200 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

GTK Themes: Prevent colors from "leaking through" by using an event box.

Some engines (clearlooks) query the bg color of a widget directly, so wrap the toolbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/155310
------------------------------------------------------------------------
r20306 | jhawkins@chromium.org | 2009-07-09 22:29:43 +0200 (Thu, 09 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/common/gtk_util.h

Fix the Linux tab strip zone calculation when using the skyline.  We are looking for the top-left origin of the tab strip in screen coordinates, but we sent in the coordinates of this point relative to the entire window to gtk_util::ConvertWidgetPointToScreen.

BUG=15867
TEST=Open enough tabs so that they must be resized.  Repeatedly press the mouse over a close button so that many tabs are closed.  The tabs should not resize until the mouse leaves the tab strip.
Review URL: http://codereview.chromium.org/155308
------------------------------------------------------------------------
r20304 | ben@chromium.org | 2009-07-09 22:00:23 +0200 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc

Fix toolkit views bustage... bad conversion from string16 to std::wstring

TBR=sky
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155307
------------------------------------------------------------------------
r20301 | ben@chromium.org | 2009-07-09 21:45:55 +0200 (Thu, 09 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_2.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.h

Bring over most of the old TabRenderer into Tab2. No real logic changes here. Split out a few large functions into sub functions (Layout -> LayoutIcon, LayoutTitle, etc; Paint -> PaintIcon, PaintTitle etc).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149380
------------------------------------------------------------------------
r20297 | jhawkins@chromium.org | 2009-07-09 21:30:24 +0200 (Thu, 09 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h

Scroll-wheeling, whilst over the tab-strip, now switches tabs on GTK/Linux.

TEST=none
BUG=1316
Review URL: http://codereview.chromium.org/155053
------------------------------------------------------------------------
r20296 | mpcomplete@chromium.org | 2009-07-09 21:26:35 +0200 (Thu, 09 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/bindings_utils.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/background.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.html
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Make the API to open a message channel symmetric, so it works the same whether opening from a tab or extension.

Also, move the callback handling back to extension_process_bindings, since I
didn't need it in event_bindings to implement this, and it didn't make sense
there anyway.

BUG=12461
TEST=no

Review URL: http://codereview.chromium.org/149237
------------------------------------------------------------------------
r20295 | kuchhal@chromium.org | 2009-07-09 21:22:35 +0200 (Thu, 09 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc

Start Chrome button on First Run customize view should launch Chrome.

BUG=16358

Review URL: http://codereview.chromium.org/149398
------------------------------------------------------------------------
r20293 | paul@chromium.org | 2009-07-09 20:51:51 +0200 (Thu, 09 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

Set the save file type index properly if there was only one file type.

The save file indexes are 1 based, and if there is only one file type
that the page can be saved as (such as a page like foo.com/notes.txt),
the index is set to 0 which will cause a crash.

BUG=15555 (http://crbug.com/15555)
TEST=Go to a web page that is a text file and try to save it. Chrome
     should not crash.

Review URL: http://codereview.chromium.org/155264
------------------------------------------------------------------------
r20292 | pinkerton@chromium.org | 2009-07-09 20:47:18 +0200 (Thu, 09 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Perf bots are "happy enough", enable the throbber for real.
BUG=12699
TEST=throbber animations in tabs while page loading.
Review URL: http://codereview.chromium.org/149400
------------------------------------------------------------------------
r20280 | hclam@chromium.org | 2009-07-09 20:11:54 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Disable media ui test again because it doesn't run without audio device

Review URL: http://codereview.chromium.org/155296
------------------------------------------------------------------------
r20276 | phajdan.jr@chromium.org | 2009-07-09 19:41:31 +0200 (Thu, 09 Jul 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/browser_browsertest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Convert most flakiness-prone Browser UI tests to browser_tests framework.

TEST=none
BUG=http://crbug.com/16062

Review URL: http://codereview.chromium.org/149365
------------------------------------------------------------------------
r20275 | hclam@chromium.org | 2009-07-09 19:37:45 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Enable UI test MediaTest.VideoBearH264

Review URL: http://codereview.chromium.org/155294
------------------------------------------------------------------------
r20273 | pinkerton@chromium.org | 2009-07-09 19:32:13 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Testing perfbots with throbber enabled
BUG=none
TEST=none
------------------------------------------------------------------------
r20272 | meelapshah@chromium.org | 2009-07-09 19:30:49 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Change ThumbnailStore to use sqlite instead of individual files try 2. Previous try failed interactive_ui_tests.

Review URL: http://codereview.chromium.org/149361
------------------------------------------------------------------------
r20270 | jar@chromium.org | 2009-07-09 19:23:11 +0200 (Thu, 09 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Ensure that SDCH is initialized at all times.

There is an active A/B experiment to test the impact of SDCH support.
This change correctly toggles support by simulating the command line
flag, rather than incorrectly avoiding initialization of the module.

BUG=16274
r=huanr
Review URL: http://codereview.chromium.org/155277
------------------------------------------------------------------------
r20269 | glen@chromium.org | 2009-07-09 19:14:12 +0200 (Thu, 09 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Make the toolbar theme align with the left edge of the browser and the top edge of the tab strip.

BUG=none
TEST=install a theme with lines across the toolbar and frame, and verify that the lines line up across the frame,toolbar,bookmarks bar and find bar.

Review URL: http://codereview.chromium.org/155124
------------------------------------------------------------------------
r20267 | amit@chromium.org | 2009-07-09 18:58:06 +0200 (Thu, 09 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/automation/automation_resource_message_filter.cc
   A /trunk/src/chrome/browser/automation/automation_resource_message_filter.h
   A /trunk/src/chrome/browser/automation/url_request_automation_job.cc
   A /trunk/src/chrome/browser/automation/url_request_automation_job.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

A prototype of resource loading through automation

In a test scenario where we need to load resources over
automation, we intercept the URL reqeusts and serve
them using automation IPCs.

This resource loading can be enabled per tab created
by automation. 

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/145024
------------------------------------------------------------------------
r20265 | hamaji@chromium.org | 2009-07-09 18:21:51 +0200 (Thu, 09 Jul 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Copy parsed URL into CF_UNICODETEXT when user select entire of Omnibox.

BUG=2820
BUG=8162
TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 and select entire text in Omnibox, then copy the text.
     Paste the copied text into other applications such as notepad and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 荳雁慍.
     Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website.
     Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0.
     Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 荳雁慍.
     Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0".
     Paste the copied text into URL-aware softwares such as MS-word and check if the pasted text contains 荳雁慍.
     Check if the link in MS-word is pointing to encoded URL (http://www.google.com/...%E4%B8%8A%E5%9C%B0).
TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 again and select "q=荳雁慍" in Omnibox, then copy the text.
     Paste it into somewhere and check if you see "q=荳雁慍".
TEST=Copy "荳雁慍" from somewhere and paste it into Omnibox.
     Copy from Omnibox and paste it into notepad. Then check if the pasted text is NOT encoded.
Review URL: http://codereview.chromium.org/119352
------------------------------------------------------------------------
r20261 | sverrir@google.com | 2009-07-09 16:34:30 +0200 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_worker.cc

I've seen recently a race condition while debugging printing.  The pages are not sent from the renderer quickly enough which causes the print thread to hang (no new page notifications are sent any more).
This change simply adds a poll every half a second for a new page.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149390
------------------------------------------------------------------------
r20258 | pfeldman@chromium.org | 2009-07-09 16:13:08 +0200 (Thu, 09 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/single_split_view.h

Add 'resize_leading_on_bounds_change' property into the SingleSplitView.
When it is turned on, leading component is resized when split view gets new bounds.

Review URL: http://codereview.chromium.org/155214
------------------------------------------------------------------------
r20257 | pfeldman@chromium.org | 2009-07-09 16:11:22 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

DevTools: paint devtools split with COLOR_TOOLBAR.

Review URL: http://codereview.chromium.org/149258
------------------------------------------------------------------------
r20244 | jrg@chromium.org | 2009-07-09 06:45:07 +0200 (Thu, 09 Jul 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

- Fix janklist issue #1: "there is a pixel line below the main
  toolbar. The main toolbar should blend in with the bookmark bar when
  it's open"
- Fix janklist issue #2: "It's way too tall - the distance from the
  bottom of the bar to a bookmark button bottom edge should be the
  same as the distance from the omnibox to the bookmark button top
  edge (this will probably mean that the bar has to overlap the
  toolbar)."
- Fix janklist issue #4 (first part): "the bookmark bar bookmark buttons
  have a frame around them ... "
- Fix janklist issue #9: "the show/hide animation is very janky... I see
  a dark gray area behind".  Even with animators the grey is gone, but
  animators are disabled for now due to races.
- Fix unlisted jank related to 9: don't use animator when opening bar on
  launch.
- Also chipped away on unit tests.

TEST=Launch with bookmark bar both open and closed.  Make sure OK on launch.
In each case open and close a few times fast.
Repeat with multiple windows open.
Sanity check jank descriptions listed above are fixed.

BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724

Review URL: http://codereview.chromium.org/149308
------------------------------------------------------------------------
r20243 | ananta@chromium.org | 2009-07-09 06:30:30 +0200 (Thu, 09 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc

Windowed plugins like Flash would cause the hung plugin dialog to show up when the print dialog was displayed.
The proposed fix is to signal the modal dialog event which would ensure that the renderer and plugins both pump
messages when the print dialog is displayed.

This fixes http://code.google.com/p/chromium/issues/detail?id=13804

Bug=13804

Review URL: http://codereview.chromium.org/155133
------------------------------------------------------------------------
r20240 | ben@chromium.org | 2009-07-09 06:19:37 +0200 (Thu, 09 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.h

Hack and slash TabStrip2 into mostly working state - DWM frame is now properly adjusted with --enable-tabtastic2, tab text doesn't cause black squares to be rendered etc.Also, remove some code invalidated by my fix earlier this week to make the distributor logo not overlap the window controls.BUG=noneTEST=none
Review URL: http://codereview.chromium.org/155267
------------------------------------------------------------------------
r20230 | estade@chromium.org | 2009-07-09 04:36:16 +0200 (Thu, 09 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc

Initialize dragged tab backing store to null.

This fixes a crasher I ran into when testing.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155263
------------------------------------------------------------------------
r20217 | estade@chromium.org | 2009-07-09 02:11:48 +0200 (Thu, 09 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: For mouse button clicks, only send buttons 1, 2, 3 to the renderer.

BUG=16236
TEST=no more sad tab on clicking mouse back button

Review URL: http://codereview.chromium.org/155250
------------------------------------------------------------------------
r20214 | rafaelw@chromium.org | 2009-07-09 02:03:46 +0200 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

ExtensionsServiceBackend::GarbageCollectionExtensions() makes a local copy of install_directory_. It was forcing the persistent copy to an absolute path which was causing the ExternsionsService and ExtensionsPrefs install_directory_ values to diverge.

Re-enable ExternalInstallPref on mac.

TBR=mpcomplete

Review URL: http://codereview.chromium.org/155187
------------------------------------------------------------------------
r20212 | kuchhal@chromium.org | 2009-07-09 01:57:44 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   A /trunk/src/chrome/browser/gtk/first_run_dialog.cc
   A /trunk/src/chrome/browser/gtk/first_run_dialog.h
   M /trunk/src/chrome/chrome.gyp

Linux: Add "set chrome as default" and "import profile data" option to First Run UI. Also enable it for Chromium builds.

Review URL: http://codereview.chromium.org/149348
------------------------------------------------------------------------
r20210 | brettw@chromium.org | 2009-07-09 01:45:29 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/widget/widget_gtk.cc

Replace instances of LINUX2 with OS_CHROMEOS and linux2 with chromeos.

Review URL: http://codereview.chromium.org/149367
------------------------------------------------------------------------
r20209 | brettw@chromium.org | 2009-07-09 01:42:25 +0200 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h

Some views GTK fixes.

Fix the crazy font on infobars by reducing the "medium" font size.

Make tab dragging not immediately crash by crating a dragged tab container.

Review URL: http://codereview.chromium.org/155253
------------------------------------------------------------------------
r20208 | mark@chromium.org | 2009-07-09 01:40:08 +0200 (Thu, 09 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   M /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc

Remove errant semicolon.  distcc's pump mode didn't understand this.  Also
fix presubmit warnings.
Review URL: http://codereview.chromium.org/155252
------------------------------------------------------------------------
r20207 | jhawkins@chromium.org | 2009-07-09 01:31:43 +0200 (Thu, 09 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Connect the ctrl-w accelerator to the task manager dialog, and close the window when this accelerator is activated.

BUG=11392
TEST=Open the task manager in Linux Chrome.  Press ctrl-w.  The task manager should close.
Review URL: http://codereview.chromium.org/149363
------------------------------------------------------------------------
r20206 | ben@chromium.org | 2009-07-09 01:22:23 +0200 (Thu, 09 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

fix bustage - ALLOW_THIS_IN_..
------------------------------------------------------------------------
r20204 | ben@chromium.org | 2009-07-09 01:12:36 +0200 (Thu, 09 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.h
   A /trunk/src/chrome/browser/views/tabs/tab_strip_wrapper.h

Add temporary TabStripWrapper interface that is implemented by both TabStrip and BrowserTabStrip... this makes dealing with the multiple implementations more manageable in shared code like BrowserView, etc. This interface will die once the new work is completed and a conversion is finished. The interface contains all the methods that BrowserView expect to find on TabStrip.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155242
------------------------------------------------------------------------
r20203 | estade@chromium.org | 2009-07-09 01:12:27 +0200 (Thu, 09 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc

Make bookmark bar folder buttons look active so long as the menu is open.

Make sure chrome buttons have no child displacement (so the contents don't jiggle when you press them).

BUG=none
TEST=do a click on a folder, click away, make sure the button always looks as you'd expect

Review URL: http://codereview.chromium.org/149355
------------------------------------------------------------------------
r20200 | paul@chromium.org | 2009-07-09 01:02:08 +0200 (Thu, 09 Jul 2009) | 14 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/DownloadItem.xib
   A /trunk/src/chrome/browser/cocoa/download_item_controller.h
   A /trunk/src/chrome/browser/cocoa/download_item_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_item_mac.h
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_mac.mm
   M /trunk/src/chrome/chrome.gyp

The Mac version of the download shelf from the original CL by thakis:
http://codereview.chromium.org/150216

Original description:
Move download item to its own view and a xib, paving the way for a custom
download item view. I didn't change the look of the download items yet. The
context menu is now in the download item xib as well.

BUG=14659,15098,14660
TEST=Download something. Everything should look like before (except for the
     smaller icon), but the context menu items should be disabled/enabled and
     checked/unchecked correctly.

Review URL: http://codereview.chromium.org/149276
------------------------------------------------------------------------
r20199 | tc@google.com | 2009-07-09 01:01:03 +0200 (Thu, 09 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

XFCE disables the system decorations if there's an xshape set.  So
only use the KWin hack when the custom frame is enabled.

This is still a bit buggy in KWin (toggling from custom frame -> system
decorations doesn't always re-attach system decorations), but it seems
like the best I can do.

Review URL: http://codereview.chromium.org/155248

------------------------------------------------------------------------
r20195 | sky@chromium.org | 2009-07-08 23:54:14 +0200 (Wed, 08 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc

Lands http://codereview.chromium.org/155128 for Thiago.

Description from Thiago:

Converting the history::StarredEntry::Type to a type defined in BookmarkNode.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/155165
------------------------------------------------------------------------
r20186 | estade@chromium.org | 2009-07-08 23:06:14 +0200 (Wed, 08 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

GTK: Allow user to drag onto folder in bookmark bar.

This is only half of the bug fix. We also should match windows in that a drag held over a folder for more than a second or so shows the folder's contents and allows the user to continue the drag into the folder.

Also, it's kind of hard to use this new feature since the bookmark items float around when you are dragging out of the same bookmark bar you're dragging into, but the fix for that would be separate (and would require some design decisions).

BUG=14222
TEST=drag single or multiple bookmarks onto a bookmark bar folder

Review URL: http://codereview.chromium.org/149307
------------------------------------------------------------------------
r20184 | sky@chromium.org | 2009-07-08 22:54:13 +0200 (Wed, 08 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   A /trunk/src/chrome/browser/metrics/metrics_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp

http://codereview.chromium.org/147084

Implements unique client ID generation for Posix.

Client ID generation happens once-per-install of Chromium (...well, this is
mostly true, at least).  On Windows, the code currently uses some system library
code that generates a GUID.  We don't ACTUALLY need a GUID, something that's
quite random and in the same format will work.  Since we don't want to add a
dependency on libuuid for POSIX, I created a less-random-but-still-good-enough
version.

BUG=15418
TEST=none

Review URL: http://codereview.chromium.org/149343
------------------------------------------------------------------------
r20182 | phajdan.jr@chromium.org | 2009-07-08 22:43:53 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/crash_recovery_browsertest.cc
   D /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Convert crash recovery tests to browser test framework, which should reduce flakiness.

TEST=none
http://crbug.com/16054

Review URL: http://codereview.chromium.org/149235
------------------------------------------------------------------------
r20181 | sky@chromium.org | 2009-07-08 22:39:46 +0200 (Wed, 08 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/webkit/glue/window_open_disposition.h

Adds tab pinning to TabStripModel. This is just the model side of
things (and tests), no UI yet.

The model enforces that all pinned tabs occur at the beginning of the
model. For example, if there are no pinned tabs and you pin the 10th
tab, it is moved to the front of the tab strip. Similarly inserting a
tab before the last pinned tab implicitly pins it. Moving a pinned tab
beyond the set of pinned tabs implicitly unpins it.

I'll file a bug on this when the site allows me to.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155228
------------------------------------------------------------------------
r20179 | eroman@chromium.org | 2009-07-08 21:03:29 +0200 (Wed, 08 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/tools/valgrind/suppressions.txt

Fix a leak of the new location GURL by NotificationTask when doing a redirect.

The problem is scoped_ptr<ResourceRequestDetails> is used to delete an instance of ResourceRedirectDetails, however the base class's destructor is non-virtual, so ResourceRedirectDetails extra field (GURL new_url_) does not get torn down properly.

Note that the blame callstacks in the bug report appear unrelated, because std::string is doing some fancy refcounting under the hood. So as GURLs get passed around, they take over the GURL::spec's memory that got allocated earlier by the network stack.

BUG=http://crbug.com/10873
TEST=The "RedirectTest.*" ui tests when run on linux valgrind bots should show no leaks

Review URL: http://codereview.chromium.org/155204
------------------------------------------------------------------------
r20174 | jcampan@chromium.org | 2009-07-08 20:32:35 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/chrome.gyp

The SSL UI tests are only run on Windows today.
Since they have been ported to the browser tests framework, they are not required anymore.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/155224
------------------------------------------------------------------------
r20158 | arv@google.com | 2009-07-08 19:18:54 +0200 (Wed, 08 Jul 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Change to use CSS media queries instead of using the "small" class name
to reduce the number of layouts needed at startup.

This also fixes an issue where starting in LIST mode did not work.

And it also fixes an issue where the width transition wasn't working
correctly.

BUG=13362

TEST=Starting in small and normal mode should still work

Review URL: http://codereview.chromium.org/155116
------------------------------------------------------------------------
r20157 | pinkerton@chromium.org | 2009-07-08 18:58:58 +0200 (Wed, 08 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm

fix bustage
------------------------------------------------------------------------
r20155 | pinkerton@chromium.org | 2009-07-08 18:47:36 +0200 (Wed, 08 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/TabView.xib
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_target.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Add context menus to tabs.
BUG=14920
TEST=context menus on tabs.
Review URL: http://codereview.chromium.org/155173
------------------------------------------------------------------------
r20154 | brettw@chromium.org | 2009-07-08 18:39:02 +0200 (Wed, 08 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Remove url_constants dependency from tab_contents.h.

Remove obsolete SupportsURL function from when we have TabContents types.

Review URL: http://codereview.chromium.org/155171
------------------------------------------------------------------------
r20153 | brettw@chromium.org | 2009-07-08 18:37:57 +0200 (Wed, 08 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/tabs/tab_2.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   M /trunk/src/chrome/chrome.gyp

Fix the Views-GTK build by adding necessary tab_strip_2 files and fixing some compilation errors.

Review URL: http://codereview.chromium.org/155184
------------------------------------------------------------------------
r20152 | brettw@chromium.org | 2009-07-08 18:24:33 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Split out some of the RVHDelegate functions into separate sub-classes. To limit
the scope, this patch just contains those delegate functions implemented only
by TabContents, plus the favicon functions implemented by the FavIconHelper.
The only changes are re-ordering and moving the functions, and changes in the
way that the functions are called through the new optional delegate.
Review URL: http://codereview.chromium.org/149239
------------------------------------------------------------------------
r20151 | jcampan@chromium.org | 2009-07-08 18:17:12 +0200 (Wed, 08 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Some code had been removed from FirstRun::IsChromeFirstRun() so that it may return true then false when later invoked.This caused a bug where we would show the info-bar warning that Chromium is not the default browser after the first run.This patch resurrects that code and changes the first run UI, as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE or Firefox your default browser. Open Chromium so it shows the 1st run UI. Unselect the "make chromium my default browser" button, then press start. When Chromium shows up, there should be no info-bar warning you Chromium is not your default browser.     Also test that the first run UI still works as expected.
Review URL: http://codereview.chromium.org/155168
------------------------------------------------------------------------
r20150 | davemoore@chromium.org | 2009-07-08 18:16:08 +0200 (Wed, 08 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Wasn't able to browse to new files within panels
Review URL: http://codereview.chromium.org/149303
------------------------------------------------------------------------
r20145 | jeremy@chromium.org | 2009-07-08 16:59:06 +0200 (Wed, 08 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   A /trunk/src/chrome/browser/cocoa/browser_window.h
   A /trunk/src/chrome/browser/cocoa/browser_window.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h
   A /trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm
   A /trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Add facitility for Global Keyboard shortcuts.

Also, do some housekeeping for our current shortcuts.

* Command-Option-l - Downloads [same shortcut as Safari].
* Command-Shift-[/] - Back/forward tab.
* cntrl-pageup/pagedn - Back/forward tab.

Global Keyboard events are intercepted by a new BrowserWindow custom class.

BUG=12537,15486
TEST=Check that above keyboard shortcuts work as advertised.

Review URL: http://codereview.chromium.org/149325
------------------------------------------------------------------------
r20144 | pinkerton@chromium.org | 2009-07-08 16:53:13 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Removes ifdefs in browser_render_process_host.cc that prevented
adding custom words to the dictionary on platforms other than 
windows. This functionality has now been implemented on all
platforms. Patch from pwicks86@gmail.com (Paul Wicks)
BUG=None
TEST=Adding words to dictionary on mac and linux.
------------------------------------------------------------------------
r20143 | shess@chromium.org | 2009-07-08 16:37:26 +0200 (Wed, 08 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   D /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc

Wire GetWindowRect, GetRootWindowRect, and GetScreenInfo out to the UI thread.

Convert GetScreenInfo to be sync and routed.

http://crbug.com/13113
R=darin@chromium.org, jam@chromium.org, amanda@chromium.org
TEST=See bug.

Review URL: http://codereview.chromium.org/151130
------------------------------------------------------------------------
r20141 | deanm@chromium.org | 2009-07-08 11:37:01 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.h

Removing an unused variable from cookies_view.h

Patch by Thiago Farina.

Review URL: http://codereview.chromium.org/155078

------------------------------------------------------------------------
r20140 | deanm@chromium.org | 2009-07-08 11:20:13 +0200 (Wed, 08 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Initial work on Linux tab to search.

Still are a bunch of more complicated behavior that doesn't work, like hitting
backspace to remove the keyword.  The keyword hint and keyword display more or
less work, although things have gotten pretty complicated.

BUG=10965
TEST=Tab to search with a keyword.

Review URL: http://codereview.chromium.org/151209

------------------------------------------------------------------------
r20139 | pfeldman@chromium.org | 2009-07-08 10:58:31 +0200 (Wed, 08 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc

DevTools: remove extensions-related workaround from the docked devtools window destruction.

Review URL: http://codereview.chromium.org/155206
------------------------------------------------------------------------
r20136 | pfeldman@chromium.org | 2009-07-08 10:15:48 +0200 (Wed, 08 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

DevTools: Align status bubble with the contents container, not docked devtools container.

Review URL: http://codereview.chromium.org/149253
------------------------------------------------------------------------
r20135 | yurys@google.com | 2009-07-08 09:56:56 +0200 (Wed, 08 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: added test for setting breakpoit.
Review URL: http://codereview.chromium.org/149256
------------------------------------------------------------------------
r20133 | aa@chromium.org | 2009-07-08 06:25:15 +0200 (Wed, 08 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc

Aha, I think this was racing because INSTALLED is actually fired
before LOADED. Frequently, this didn't matter because we post
a task to the message loop to quit and usually this would get
queued after the LOADED message.

But it is also possible for us to queue the quit task first,
I think.

TBR=mpcomplete
------------------------------------------------------------------------
r20132 | jeremy@chromium.org | 2009-07-08 06:20:07 +0200 (Wed, 08 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

Speculative Crash fix: Return early if user cancels save dialog.

I'm not able to repro the crash, but this seems safer overall.

BUG=16081
TEST=Right click an image, Save as, Chrome should not crash.

Review URL: http://codereview.chromium.org/149244
------------------------------------------------------------------------
r20130 | evan@chromium.org | 2009-07-08 05:58:29 +0200 (Wed, 08 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/jankometer.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

linux: port Jankometer

Originally I had split it into multiple files, but I think it's
cleaner to just use one.

(I want to use this for measuring plugin jank.)

BUG=8077

Review URL: http://codereview.chromium.org/155194
------------------------------------------------------------------------
r20129 | mirandac@chromium.org | 2009-07-08 05:47:49 +0200 (Wed, 08 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fix memory leaks introduced and exposed by r20028.

BUG= none
TEST= none


Review URL: http://codereview.chromium.org/155195
------------------------------------------------------------------------
r20126 | aa@chromium.org | 2009-07-08 04:40:42 +0200 (Wed, 08 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc

Add some more logging. Still trying to figure out flakey test.

TBR=mpcomplete
------------------------------------------------------------------------
r20125 | arv@google.com | 2009-07-08 04:38:03 +0200 (Wed, 08 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Make the cancelling of drag and drop match Safari for Windows. This is
a follow up CL to http://codereview.chromium.org/149038 as well as to
https://bugs.webkit.org/show_bug.cgi?id=26699

With this change we use DragOperationNone (instead of DragOperationCopy)
and NoButton (instead of LeftButton) when the user presses Escape.

BUG=12018

TEST=On the new new tab page drag one of the thumbnails out of the
window and press escape. The thumbnail should move back to its starting
position.

Review URL: http://codereview.chromium.org/149296
------------------------------------------------------------------------
r20124 | arv@google.com | 2009-07-08 04:37:15 +0200 (Wed, 08 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/startup/feature_startup_test.cc

Adds a way to set the boundaries of the browser window through
automation and use that to set the size of the window in the

"New Tab Cold" to ensure we are testing the normal case and not the
small case.

BUG=None

TEST=The NewTabUIStartupTest, PerfCold should still work.

Review URL: http://codereview.chromium.org/149233
------------------------------------------------------------------------
r20118 | agl@chromium.org | 2009-07-08 03:33:11 +0200 (Wed, 08 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/zygote_host_linux.cc

Build fix: string/wstring mismatch on Linux.

------------------------------------------------------------------------
r20110 | agl@chromium.org | 2009-07-08 03:15:14 +0200 (Wed, 08 Jul 2009) | 18 lines
Changed paths:
   M /trunk/src/breakpad/linux/exception_handler.cc
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/sandbox/linux
   A /trunk/src/sandbox/linux/suid
   A /trunk/src/sandbox/linux/suid/sandbox.cc
   M /trunk/src/sandbox/sandbox.gyp

Linux: SUID sandbox support

  * Make processes dumpable when they crash.
  * Find crashing processes by searching for a socket inode, rather
    than relying on SCM_CREDENTIALS. The kernel doesn't translate PIDs
    between PID namespaces with SCM_CREDENTIALS, so we can't use the
    PID there.
  * Use a command line flag to the renderer to enable crash dumping.
    Previously it tried to access the user's home directory for this
    information.
  * Search for a sandbox helper binary and, if found, use it.
  * Include the source for a sandbox helper binary. It's currently not
    built by default.

http://codereview.chromium.org/149230
R=evan,markus
BUG=8081

------------------------------------------------------------------------
r20109 | jorlow@chromium.org | 2009-07-08 03:05:18 +0200 (Wed, 08 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   M /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   M /trunk/src/chrome/browser/in_process_webkit/webkit_thread_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Simplify the WebKit thread model.  It's now created/destroyed on the UI thread (before/after the IO thread is started/stopped).  The WebKit thread is created lazily as needed (while on the IO thread).TEST=noneBUG=none

Review URL: http://codereview.chromium.org/149238
------------------------------------------------------------------------
r20108 | estade@chromium.org | 2009-07-08 03:02:37 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

GTK: Support for more drag targets in renderer destination.

BUG=http://crbug.com/15429
TEST=drag a file from konqueror to the web view; observe that it causes the browser to navigate there (assuming you don't drag it into an <input> field or something).

Review URL: http://codereview.chromium.org/155175
------------------------------------------------------------------------
r20107 | estade@chromium.org | 2009-07-08 03:01:53 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_dnd_util.cc

Gtk: URI list dragging for bookmarks (source side only)

BUG=none
TEST=drag a bookmark into the webview or onto another program such as konqueror. The right thing should happen.

Review URL: http://codereview.chromium.org/149301
------------------------------------------------------------------------
r20103 | aa@chromium.org | 2009-07-08 02:18:36 +0200 (Wed, 08 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Add some logging to a flakey browsertest to debug.

Review URL: http://codereview.chromium.org/149291
------------------------------------------------------------------------
r20102 | erg@google.com | 2009-07-08 02:10:41 +0200 (Wed, 08 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK Themes: Use the correct text color in the tab strip.

BUG=http://crbug.com/13967

Review URL: http://codereview.chromium.org/155183
------------------------------------------------------------------------
r20101 | meelapshah@chromium.org | 2009-07-08 02:08:31 +0200 (Wed, 08 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Reverting 20097.
Review URL: http://codereview.chromium.org/155186
------------------------------------------------------------------------
r20097 | meelapshah@chromium.org | 2009-07-08 00:39:45 +0200 (Wed, 08 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Change ThumbnailStore to use sqlite instead of individual files.

Review URL: http://codereview.chromium.org/149223
------------------------------------------------------------------------
r20096 | stuartmorgan@chromium.org | 2009-07-08 00:31:47 +0200 (Wed, 08 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/sunspider_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Sprinkle some defensiveness into the UI tests so that they don't explode if the proxy doesn't respond (e.g., due to a timeout).

BUG=none
TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking).
Review URL: http://codereview.chromium.org/149281
------------------------------------------------------------------------
r20095 | estade@chromium.org | 2009-07-08 00:31:35 +0200 (Wed, 08 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

Give page/app menu native menu bar feel.

Allow keyboard and mouse navigation between the two while one is open.

BUG=none
TEST=the page and wrench menus feel like a native menubar

Review URL: http://codereview.chromium.org/155164
------------------------------------------------------------------------
r20094 | klink@chromium.org | 2009-07-08 00:29:28 +0200 (Wed, 08 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/webkit/glue/glue_accessibility_object.cc
   M /trunk/src/webkit/glue/webaccessibility.h

Adds support for an initial set of WAI-ARIA roles, needed to support screen readers in AJAX web applications (e.g. Gmail).

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/149265
------------------------------------------------------------------------
r20093 | jam@chromium.org | 2009-07-08 00:26:05 +0200 (Wed, 08 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Fix the unit tests that had multiple ResourceDispatcherHost objects instantiated at the same time.
Review URL: http://codereview.chromium.org/149287
------------------------------------------------------------------------
r20090 | jhawkins@chromium.org | 2009-07-07 23:57:14 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc

Wrap the task manager treeview in a GtkScrolledWindow in order to have a frame around it.

BUG=16094
TEST=Open the task manager in Linux.  Make sure the task manager treeview has a frame around it.
Review URL: http://codereview.chromium.org/149286
------------------------------------------------------------------------
r20089 | tc@google.com | 2009-07-07 23:52:23 +0200 (Tue, 07 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Work around a bug in KWin where the window shape doesn't get
removed when we maximize/go full screen.

BUG=15317

Review URL: http://codereview.chromium.org/155169

------------------------------------------------------------------------
r20086 | sverrir@google.com | 2009-07-07 23:31:39 +0200 (Tue, 07 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/printing/page_number.cc
   D /trunk/src/chrome/browser/printing/page_number.h
   D /trunk/src/chrome/browser/printing/page_number_unittest.cc
   D /trunk/src/chrome/browser/printing/page_overlays.cc
   D /trunk/src/chrome/browser/printing/page_overlays.h
   D /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   D /trunk/src/chrome/browser/printing/page_range.cc
   D /trunk/src/chrome/browser/printing/page_range.h
   D /trunk/src/chrome/browser/printing/page_range_unittest.cc
   D /trunk/src/chrome/browser/printing/page_setup.cc
   D /trunk/src/chrome/browser/printing/page_setup.h
   D /trunk/src/chrome/browser/printing/page_setup_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   D /trunk/src/chrome/browser/printing/print_settings.cc
   D /trunk/src/chrome/browser/printing/print_settings.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   D /trunk/src/chrome/browser/printing/printed_document.cc
   D /trunk/src/chrome/browser/printing/printed_document.h
   D /trunk/src/chrome/browser/printing/printed_page.cc
   D /trunk/src/chrome/browser/printing/printed_page.h
   D /trunk/src/chrome/browser/printing/printed_pages_source.h
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   D /trunk/src/chrome/browser/printing/printing_test.h
   D /trunk/src/chrome/browser/printing/win_printing_context.cc
   D /trunk/src/chrome/browser/printing/win_printing_context.h
   D /trunk/src/chrome/browser/printing/win_printing_context_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/printing/DEPS
   M /trunk/src/printing/emf_win.h
   M /trunk/src/printing/emf_win_unittest.cc
   M /trunk/src/printing/native_metafile.h
   A /trunk/src/printing/page_number.cc (from /trunk/src/chrome/browser/printing/page_number.cc:19942)
   A /trunk/src/printing/page_number.h (from /trunk/src/chrome/browser/printing/page_number.h:19942)
   A /trunk/src/printing/page_number_unittest.cc (from /trunk/src/chrome/browser/printing/page_number_unittest.cc:19942)
   A /trunk/src/printing/page_overlays.cc (from /trunk/src/chrome/browser/printing/page_overlays.cc:19942)
   A /trunk/src/printing/page_overlays.h (from /trunk/src/chrome/browser/printing/page_overlays.h:19942)
   A /trunk/src/printing/page_overlays_unittest.cc (from /trunk/src/chrome/browser/printing/page_overlays_unittest.cc:19942)
   A /trunk/src/printing/page_range.cc (from /trunk/src/chrome/browser/printing/page_range.cc:19942)
   A /trunk/src/printing/page_range.h (from /trunk/src/chrome/browser/printing/page_range.h:19942)
   A /trunk/src/printing/page_range_unittest.cc (from /trunk/src/chrome/browser/printing/page_range_unittest.cc:19942)
   A /trunk/src/printing/page_setup.cc (from /trunk/src/chrome/browser/printing/page_setup.cc:19942)
   A /trunk/src/printing/page_setup.h (from /trunk/src/chrome/browser/printing/page_setup.h:19942)
   A /trunk/src/printing/page_setup_unittest.cc (from /trunk/src/chrome/browser/printing/page_setup_unittest.cc:19942)
   A /trunk/src/printing/print_settings.cc (from /trunk/src/chrome/browser/printing/print_settings.cc:19957)
   A /trunk/src/printing/print_settings.h (from /trunk/src/chrome/browser/printing/print_settings.h:19957)
   A /trunk/src/printing/printed_document.cc (from /trunk/src/chrome/browser/printing/printed_document.cc:19943)
   A /trunk/src/printing/printed_document.h (from /trunk/src/chrome/browser/printing/printed_document.h:19943)
   A /trunk/src/printing/printed_page.cc (from /trunk/src/chrome/browser/printing/printed_page.cc:19943)
   A /trunk/src/printing/printed_page.h (from /trunk/src/chrome/browser/printing/printed_page.h:19943)
   A /trunk/src/printing/printed_pages_source.h (from /trunk/src/chrome/browser/printing/printed_pages_source.h:19942)
   M /trunk/src/printing/printing.gyp
   A /trunk/src/printing/printing_context.h (from /trunk/src/chrome/browser/printing/win_printing_context.h:19942)
   A /trunk/src/printing/printing_context_linux.cc
   A /trunk/src/printing/printing_context_mac.cc
   A /trunk/src/printing/printing_context_win.cc (from /trunk/src/chrome/browser/printing/win_printing_context.cc:19942)
   A /trunk/src/printing/printing_context_win_unittest.cc (from /trunk/src/chrome/browser/printing/win_printing_context_unittest.cc:19942)
   A /trunk/src/printing/printing_test.h (from /trunk/src/chrome/browser/printing/printing_test.h:19942)

Move printing related stuff to the root printing project from the browser project.  This simplifies further refactoring and eases understanding of the printing part of Chrome.
Also renamed win_printing_context to printing_context_win (correct naming convention) and added stub implementations for _linux and mac.
Now all but one file is compiling on all platforms.

TEST=none (no functional change).
BUG=none

Review URL: http://codereview.chromium.org/149212
------------------------------------------------------------------------
r20085 | erg@google.com | 2009-07-07 23:31:39 +0200 (Tue, 07 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/blocked_popup_container_unittest.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

GTK Themes: Theme the popup notification.

TEST=Open popuptest.com in one tab and anything else in another. Switch between
GTK theme and normal. Theme of blocked popup container should change, even when
not the active tab.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/149277
------------------------------------------------------------------------
r20084 | jcampan@chromium.org | 2009-07-07 23:29:55 +0200 (Tue, 07 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

This CL makes sure JavaScript alerts are not shown while an interstitial is showing.
(The interstitial is displayed on top of an existing page. We don't want the hidden page to interfere with the interstitial.)

BUG=http://crbug.com/3256
TEST=Open the page attached in the bug (interstitial_test.html), no alert boxes should show.
Review URL: http://codereview.chromium.org/149261
------------------------------------------------------------------------
r20083 | rafaelw@chromium.org | 2009-07-07 23:26:42 +0200 (Tue, 07 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Move extension install to after .crx download completes

This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager.

BUG=15881
R=mpcomplete

Review URL: http://codereview.chromium.org/149161
------------------------------------------------------------------------
r20081 | rafaelw@chromium.org | 2009-07-07 23:17:57 +0200 (Tue, 07 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h

Revert r19752. Caused regression in tabs closing.

Origin issue: http://codereview.chromium.org/150122

B=16052,12745
TBR=brettw

Review URL: http://codereview.chromium.org/155157
------------------------------------------------------------------------
r20068 | pinkerton@chromium.org | 2009-07-07 21:51:55 +0200 (Tue, 07 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Nudges the incognito man over to the left a few more pixels.
BUG=14931
TEST=none.
Review URL: http://codereview.chromium.org/155159
------------------------------------------------------------------------
r20058 | ben@chromium.org | 2009-07-07 21:20:01 +0200 (Tue, 07 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm

Add extra delegate method to mac unit test.

TBR=pinkerton
------------------------------------------------------------------------
r20056 | ben@chromium.org | 2009-07-07 21:00:10 +0200 (Tue, 07 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc

bustage fix - add header
------------------------------------------------------------------------
r20055 | ben@chromium.org | 2009-07-07 20:54:06 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc

Fix release bustage. ALLOW_THIS_IN_INITIALIZER_LIST

TBR=sky

Review URL: http://codereview.chromium.org/149267
------------------------------------------------------------------------
r20053 | ben@chromium.org | 2009-07-07 20:44:31 +0200 (Tue, 07 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/tabs/browser_tab_strip.cc
   A /trunk/src/chrome/browser/views/tabs/browser_tab_strip.h
   A /trunk/src/chrome/browser/views/tabs/tab_2.cc
   A /trunk/src/chrome/browser/views/tabs/tab_2.h
   A /trunk/src/chrome/browser/views/tabs/tab_strip_2.cc
   A /trunk/src/chrome/browser/views/tabs/tab_strip_2.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/views/animator.cc
   A /trunk/src/views/animator.h
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Basics of a new TabStrip.It's very, very rough, but I wanted to check it in so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout!
Review URL: http://codereview.chromium.org/42490
------------------------------------------------------------------------
r20052 | pinkerton@chromium.org | 2009-07-07 20:43:09 +0200 (Tue, 07 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib
   A /trunk/src/chrome/app/theme/home.pdf
   A /trunk/src/chrome/app/theme/menu_chrome.pdf
   A /trunk/src/chrome/app/theme/menu_page.pdf
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Hook up the prefs for the optional home buttons and page/wrench buttons. Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked. 
BUG=13151
TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar.
Review URL: http://codereview.chromium.org/155151
------------------------------------------------------------------------
r20044 | rohitrao@chromium.org | 2009-07-07 19:46:49 +0200 (Tue, 07 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/HungRendererDialog.xib
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   M /trunk/src/chrome/browser/cocoa/hung_renderer_controller_unittest.mm

Removes the ability to close or minimize the hung renderer dialog
on Mac.  I'm leaving the window resizable for now, because I dislike
non-resizable windows.  This is easy enough to change later.

BUG=None
TEST=After bringing up the dialog, verify that the only way to dismiss
it is by pressing either the wait button or the kill button.
Review URL: http://codereview.chromium.org/151009
------------------------------------------------------------------------
r20043 | erg@google.com | 2009-07-07 19:43:01 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

GTK Themes: Status bubble obeys GTK colors now.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/149259
------------------------------------------------------------------------
r20042 | sidchat@google.com | 2009-07-07 19:41:14 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/spellchecker_common.h
   M /trunk/src/chrome/browser/spellchecker_linux.cc
   M /trunk/src/chrome/browser/spellchecker_mac.mm
   M /trunk/src/chrome/browser/spellchecker_platform_engine.h
   M /trunk/src/chrome/browser/spellchecker_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Change the use of typedef Language in Spell Check files back to std::string. It is unnecessary, and is conflicting with enum Language definition for compact language detection library.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150139
------------------------------------------------------------------------
r20041 | evan@chromium.org | 2009-07-07 19:40:46 +0200 (Tue, 07 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/base/gfx/native_widget_types.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   A /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   A /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/webkit.gyp

linux: OOP windowed plugins

There are still a few issues, but that's a start.
- only windowed plugins
- we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID).
- the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC.
- some code is duplicated between chrome and test_shell. We should probably refactor it, but I'm not sure where the common part should live.

Patch from Antoine Labour <piman@google.com>, with some touchups by me.

Review URL: http://codereview.chromium.org/146078
------------------------------------------------------------------------
r20037 | jcampan@chromium.org | 2009-07-07 19:22:08 +0200 (Tue, 07 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Crashers from the field indicate the navigation entry can be NULL. This is not expected and not clear how this happen.
Working-around the crasher.

BUG=http://crbug.com/15605
TEST=None



Review URL: http://codereview.chromium.org/150185
------------------------------------------------------------------------
r20035 | jhawkins@chromium.org | 2009-07-07 19:15:55 +0200 (Tue, 07 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Fix a typo.  TextDirection is the name of the enum, while GetTextDirection returns the current text direction.  Also fixes a few lint nits.

CID=4539
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149257
------------------------------------------------------------------------
r20029 | nsylvain@chromium.org | 2009-07-07 18:13:24 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc

Disable ExtensionBrowserTest.Incognito because it fails too often.

BUG:16106

Review URL: http://codereview.chromium.org/155147
------------------------------------------------------------------------
r20028 | mirandac@chromium.org | 2009-07-07 17:58:41 +0200 (Tue, 07 Jul 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/app/theme/close_button_mask.png (from /trunk/src/chrome/app/theme/close_button_mask.png:19762)
   A /trunk/src/chrome/app/theme/maximize_button_mask.png (from /trunk/src/chrome/app/theme/maximize_button_mask.png:19762)
   A /trunk/src/chrome/app/theme/minimize_button_mask.png (from /trunk/src/chrome/app/theme/minimize_button_mask.png:19762)
   A /trunk/src/chrome/app/theme/newtab_button_mask.png (from /trunk/src/chrome/app/theme/newtab_button_mask.png:19762)
   A /trunk/src/chrome/app/theme/restore_button_mask.png (from /trunk/src/chrome/app/theme/restore_button_mask.png:19762)
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/test/test_browser_window.h

Theme window control buttons.

BUG= http://crbug.com/14579
TEST= Install a theme with themed window control buttons.  Observe that WCB's are themed.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19758
Review URL: http://codereview.chromium.org/150041
------------------------------------------------------------------------
r20027 | sky@chromium.org | 2009-07-07 17:43:20 +0200 (Tue, 07 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Adds a couple of keybindings.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155103
------------------------------------------------------------------------
r20026 | pfeldman@chromium.org | 2009-07-07 16:25:29 +0200 (Tue, 07 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

DevTools: store devtools split offset only when devtools is being hidden.
Otherwise any browser window closed afterwards will overwrite settings with the original ones.

Review URL: http://codereview.chromium.org/155140
------------------------------------------------------------------------
r20019 | pinkerton@chromium.org | 2009-07-07 13:42:31 +0200 (Tue, 07 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/third_party/mozilla/include/ToolTip.h
   D /trunk/src/third_party/mozilla/include/ToolTip.mm

Use native Cocoa tooltips instead of Mozilla's ToolTip class.
This makes tooltips behave more normally, and fixes some of the bugs. Patch by Jens Alfke (snej@google.com)
BUG=15655
TEST=tooltips should feel more like native tooltips
------------------------------------------------------------------------
r20018 | pfeldman@chromium.org | 2009-07-07 13:04:34 +0200 (Tue, 07 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Add global eval sanity test.

Review URL: http://codereview.chromium.org/155134
------------------------------------------------------------------------
r20017 | pfeldman@chromium.org | 2009-07-07 12:49:12 +0200 (Tue, 07 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/eval_test_page.html
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Add more sanity tests.

Review URL: http://codereview.chromium.org/149246
------------------------------------------------------------------------
r20016 | pfeldman@chromium.org | 2009-07-07 09:40:02 +0200 (Tue, 07 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h

DevTools: Preserve devtools window contents on dock/undock.

Review URL: http://codereview.chromium.org/149199
------------------------------------------------------------------------
r20010 | estade@chromium.org | 2009-07-07 05:10:34 +0200 (Tue, 07 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

GTK: first cut at web contents as drag destination.

TEST=drag plain text into the web page in some place that will accept it, e.g. a text entry box. Also, no crashes when dragging from various places (tab strip, bookmark bar, desktop icons, omnibox, etc.)
BUG=http://crbug.com/15429

Review URL: http://codereview.chromium.org/150198
------------------------------------------------------------------------
r20007 | ben@chromium.org | 2009-07-07 03:57:00 +0200 (Tue, 07 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Clean up contents creation in BrowserView

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155029
------------------------------------------------------------------------
r20006 | ben@chromium.org | 2009-07-07 03:56:51 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h

Fix issue once and for all where distributor logo overlays window controls. Need to force a layout and schedule a paint when a window is made visible.

http://crbug.com/15520
TEST=see bug.
Review URL: http://codereview.chromium.org/155111
------------------------------------------------------------------------
r20001 | davemoore@chromium.org | 2009-07-07 02:41:04 +0200 (Tue, 07 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   A /trunk/src/chrome/browser/views/panel_controller.cc
   A /trunk/src/chrome/browser/views/panel_controller.h
   M /trunk/src/chrome/chrome.gyp

Popup changes
Review URL: http://codereview.chromium.org/155075
------------------------------------------------------------------------
r20000 | erg@google.com | 2009-07-07 02:37:08 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/gtk_theme_provider.h

GTK Themes: Set the text color of bookmark buttons to theme color.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/155108
------------------------------------------------------------------------
r19999 | tim@chromium.org | 2009-07-07 02:36:34 +0200 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h

Have the ApplyEdit* bookmark utilities return the BookmarkNode pointer
so that callers know whether or not the original BookmarkNode* passed in
is still valid or not.

Review URL: http://codereview.chromium.org/149140
------------------------------------------------------------------------
r19998 | estade@chromium.org | 2009-07-07 02:35:09 +0200 (Tue, 07 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Only force-abort popup render views on mousedown.

BUG= http://crbug.com/15976
TEST=see bug

Review URL: http://codereview.chromium.org/149209
------------------------------------------------------------------------
r19997 | estade@chromium.org | 2009-07-07 02:34:25 +0200 (Tue, 07 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Make default extension for downloading html "html" rather than "htm" on non-windows platforms.

BUG= http://crbug.com/15999
TEST=un-disable and run save page uitest on linux (it's only disabled because it's flaky, for some unrelated reason)

Review URL: http://codereview.chromium.org/155095
------------------------------------------------------------------------
r19988 | evan@chromium.org | 2009-07-06 23:06:39 +0200 (Mon, 06 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   D /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   D /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/webkit.gyp

Revert "linux: OOP windowed plugins"

This reverts r19983.  Test failures on Mac and Windows.
------------------------------------------------------------------------
r19986 | finnur@chromium.org | 2009-07-06 22:37:48 +0200 (Mon, 06 Jul 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc

Fixing a crash in RenderViewGone.

If I start Chrome and shut it down quickly RenderViewHost
receives an IPC ViewHostMsg_RenderViewGone. We respond in
ExtensionHost::RenderViewGone by putting up an info bar on
the selected tab contents saying that an extension
crashed. 

Only problem is that ExtensionHost::GetBrowser() can
return NULL during startup and shutdown, as documented
in the function and so we should not try to put up the
Infobar if the browser is going away.

BUG=None
TEST=Open Chrome with extensions enabled and an extension
loaded and shut Chrome down as soon as it launches. It
should not crash. Might take a few trys to repro.

Review URL: http://codereview.chromium.org/149205
------------------------------------------------------------------------
r19985 | finnur@chromium.org | 2009-07-06 22:35:49 +0200 (Mon, 06 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Extend the no-match red background to take up more space
(basically leaving only one pixel margin around the edges).

BUG=htt://crbug.com/15874
TEST=None, Find box should work as before.

Review URL: http://codereview.chromium.org/155061
------------------------------------------------------------------------
r19983 | evan@chromium.org | 2009-07-06 22:32:41 +0200 (Mon, 06 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   A /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.cc
   A /trunk/src/webkit/glue/plugins/gtk_plugin_container_manager.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/webkit.gyp

linux: OOP windowed plugins

There are still a few issues, but that's a start.
- only windowed plugins
- we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID).
- the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC.
- some code is duplicated between chrome and test_shell. We should probably factor it, but I'm not sure where the common part should live.

Review URL: http://codereview.chromium.org/146078
------------------------------------------------------------------------
r19982 | brettw@chromium.org | 2009-07-06 22:29:18 +0200 (Mon, 06 Jul 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/blocked_popup_container_unittest.cc
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
   M /trunk/src/chrome/browser/debugger/devtools_manager_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   A /trunk/src/chrome/browser/renderer_host/DEPS
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   D /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc
   D /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   D /trunk/src/chrome/browser/renderer_host/site_instance_unittest.cc
   A /trunk/src/chrome/browser/renderer_host/test
   A /trunk/src/chrome/browser/renderer_host/test/DEPS
   A /trunk/src/chrome/browser/renderer_host/test/README.txt
   A /trunk/src/chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc (from /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc:19944)
   A /trunk/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc (from /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc:19907)
   A /trunk/src/chrome/browser/renderer_host/test/site_instance_unittest.cc (from /trunk/src/chrome/browser/renderer_host/site_instance_unittest.cc:19907)
   A /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.cc (from /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc:19907)
   A /trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h (from /trunk/src/chrome/browser/renderer_host/test_render_view_host.h:19944)
   A /trunk/src/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc (from /trunk/src/chrome/browser/renderer_host/web_cache_manager_browser_test.cc:19907)
   D /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   D /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   D /trunk/src/chrome/browser/renderer_host/web_cache_manager_browser_test.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/test_web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.h

Do some refactoring of renderer_host.

This removes the last dependency on tab_contents from the renderer_host code
and into the RenderViewHostDelegate. Some of the tests depended on tab_contents,
so I moved to a new directory with the tab_contents include allowed via DEPS.
Now DEPS can enforce that no additional tab_contents includes are added to
renderer_host.

RenderViewHost delegate is now pure virtual. After spending a while *again*
figuring out why my code didn't work, only to find it was because the default
implementation of a function was getting called instead of the real one, I
decided to make this pure virtual. It is implemented by TabContents, which
implements basically everything, and two other places that implement less. Only
two lists of duplicate functions seems not too bad, although long-term it would
be nice if this delegate was somehow more succinct.
Review URL: http://codereview.chromium.org/155071
------------------------------------------------------------------------
r19980 | jhawkins@chromium.org | 2009-07-06 22:24:01 +0200 (Mon, 06 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Activate the currently selected process when the user double clicks the task manager treeview.

BUG=11392
TEST=Open the task manager and double click different processes.  Those tabs should be activated.
Review URL: http://codereview.chromium.org/155098
------------------------------------------------------------------------
r19979 | arv@google.com | 2009-07-06 22:19:50 +0200 (Mon, 06 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Add support for extended tooltips.

As the user moves the mouse around. Check if the element has an xtitle
property. If it does, compare the scrollWidth and the clientWidth and
set the real title property as needed.

BUG=15769

TEST=Hover over items on the NNTP. Only items with ellipsis should show tooltips.

Review URL: http://codereview.chromium.org/149166
------------------------------------------------------------------------
r19978 | kuchhal@chromium.org | 2009-07-06 22:19:29 +0200 (Mon, 06 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/rlz/rlz.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h

Add a ping delay time master preference.

BUG=1953127

Review URL: http://codereview.chromium.org/149135
------------------------------------------------------------------------
r19977 | brettw@chromium.org | 2009-07-06 22:17:35 +0200 (Mon, 06 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/views.gyp

Fix the current remaining Views-GTK compile and linker errors.

Chrome still doesn't run.

Review URL: http://codereview.chromium.org/155026
------------------------------------------------------------------------
r19976 | kuchhal@chromium.org | 2009-07-06 22:17:28 +0200 (Mon, 06 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/installer/util/shell_util.cc

Make default browser path check case insensitive.

BUG=15449

Review URL: http://codereview.chromium.org/149136
------------------------------------------------------------------------
r19973 | pinkerton@chromium.org | 2009-07-06 22:09:06 +0200 (Mon, 06 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Don't install the RWHVMac into the view hierarchy until everything has been properly sized. This avoids sending spurrious resize message with incorrect sizes to the renderer.
BUG=15717
TEST=pages should always be the correct size when loaded in bg or foreground. No more flashing a small size then redrawing.
Review URL: http://codereview.chromium.org/155099
------------------------------------------------------------------------
r19967 | mpcomplete@chromium.org | 2009-07-06 20:59:47 +0200 (Mon, 06 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h

Add a bunch of CHECKs to RenderViewHost trying to track down a crash.

BUG=15607
TEST=CHECKs should not fire, unless we're about to crash anyway, in which case I want the crash report.

Review URL: http://codereview.chromium.org/149142
------------------------------------------------------------------------
r19966 | estade@chromium.org | 2009-07-06 20:49:49 +0200 (Mon, 06 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h

GTK: Give the aboot dialog a facelift.

BUG=http://crbug.com/15897
TEST=get Glen to look at it

Review URL: http://codereview.chromium.org/155040
------------------------------------------------------------------------
r19965 | estade@chromium.org | 2009-07-06 20:49:30 +0200 (Mon, 06 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

GTK: Improve look of find in page failure label.

BUG=http://crbug.com/15874
TEST=looks good

Review URL: http://codereview.chromium.org/155041
------------------------------------------------------------------------
r19964 | stuartmorgan@chromium.org | 2009-07-06 20:36:25 +0200 (Mon, 06 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Add an exact search method to the Keychain adapter, and modify unit tests to us that instead of the raw keychain version.
Overhaul the single-item-search test to be shorter, clearer, and more complete.
Convert more namespaced methods that now have no public callers to private helpers of the Keychain adapter, and refactor the helpers.

BUG=none
TEST=none; no behavioral changes
Review URL: http://codereview.chromium.org/149160
------------------------------------------------------------------------
r19961 | willchan@chromium.org | 2009-07-06 20:31:42 +0200 (Mon, 06 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h

Reapply r19950.  Turns out it wasn't at fault for breaking the vista tests.
This reverts commit 6c6d8665c114217a14fea346cca97006e4c3daa7.
BUG=none
TEST=none
TBR=nsylvain

Review URL: http://codereview.chromium.org/155097
------------------------------------------------------------------------
r19957 | willchan@chromium.org | 2009-07-06 19:34:33 +0200 (Mon, 06 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h

Revert r19950 since it broke vista tests.
Revert "Add checks to track down crashes in URLRequestChromeJob."
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155092
------------------------------------------------------------------------
r19956 | jhawkins@chromium.org | 2009-07-06 19:08:06 +0200 (Mon, 06 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Add a context menu to the gtk task manager.

BUG=11392
TEST=none
Review URL: http://codereview.chromium.org/155027
------------------------------------------------------------------------
r19950 | willchan@chromium.org | 2009-07-06 18:31:43 +0200 (Mon, 06 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h

Add checks to track down crashes in URLRequestChromeJob.
BUG=http://crbug.com/13924
TEST=none

Review URL: http://codereview.chromium.org/155011
------------------------------------------------------------------------
r19944 | pinkerton@chromium.org | 2009-07-06 17:32:57 +0200 (Mon, 06 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.h
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm

Add remaining functionality for popup blocker: popup menu to unblock individual popups and whitelist sites. Also fixes intermittant leak on valgrind bots from poorly constructed unit test.
BUG=13160, 15818
TEST=unblocking popups, whitelisting sites, and unwhitelisting them. Green valgrind bot.
Review URL: http://codereview.chromium.org/149145
------------------------------------------------------------------------
r19943 | sverrir@google.com | 2009-07-06 17:25:50 +0200 (Mon, 06 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/printing/printed_page.cc
   M /trunk/src/chrome/browser/printing/printed_page.h
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/gfx/emf.cc
   D /trunk/src/chrome/common/gfx/emf.h
   D /trunk/src/chrome/common/gfx/emf_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/mock_printer.cc
   M /trunk/src/chrome/renderer/mock_printer_driver_win.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   A /trunk/src/printing/emf_win.cc (from /trunk/src/chrome/common/gfx/emf.cc:19830)
   A /trunk/src/printing/emf_win.h (from /trunk/src/chrome/common/gfx/emf.h:19830)
   A /trunk/src/printing/emf_win_unittest.cc (from /trunk/src/chrome/common/gfx/emf_unittest.cc:19830)
   A /trunk/src/printing/native_metafile.h
   M /trunk/src/printing/printing.gyp

Move Emf class to the printing library.  Also creates a platform agnostic NativeMetafile definition to ease platform porting.

BUG=none
TEST=none (No functional change)

Review URL: http://codereview.chromium.org/149181
------------------------------------------------------------------------
r19938 | pfeldman@chromium.org | 2009-07-06 10:00:30 +0200 (Mon, 06 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_client.cc

DevTools: preserve focus on activating dev tools window.
BUG=15912

Review URL: http://codereview.chromium.org/155068
------------------------------------------------------------------------
r19936 | yusukes@google.com | 2009-07-06 07:30:35 +0200 (Mon, 06 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Redraw the location bar on reload. This change is Mac port of http://codereview.chromium.org/100198.

BUG=none
TEST=open http://dev.chromium.org/, double click the location bar, press delete (delete URL string), press reload button, verify the URL is redrawn.

Review URL: http://codereview.chromium.org/155070
------------------------------------------------------------------------
r19933 | shess@chromium.org | 2009-07-06 03:50:22 +0200 (Mon, 06 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix problems with render_widget_host_ being deleted out-of-sync with cocoa_view_.

Right after Destroy() is called, render_widget_host_ is deleted.  So
clear render_widget_host_ and guard calls to render_widget_host_.

http://crbug.com/14613
http://crbug.com/13514
http://crbug.com/12725

Review URL: http://codereview.chromium.org/155021
------------------------------------------------------------------------
r19931 | dglazkov@chromium.org | 2009-07-04 19:22:08 +0200 (Sat, 04 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc

Ensure that VisitedLink listener Add event only fires when new fingerprint is added, and not during resizing/rebuilding or deleting fingerprints.

R=brettw
TEST=VisitedLinkTest.Listener
BUG=15926

Review URL: http://codereview.chromium.org/149185
------------------------------------------------------------------------
r19930 | aa@chromium.org | 2009-07-04 18:36:25 +0200 (Sat, 04 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   A /trunk/src/chrome/browser/extensions/extension_browsertest.h
   A /trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   D /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   D /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Add an ExtensionBrowserTest base class that allows in-process browser tests of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled.

Review URL: http://codereview.chromium.org/150213
------------------------------------------------------------------------
r19918 | mhm@chromium.org | 2009-07-04 00:14:29 +0200 (Sat, 04 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/resources/print_tab.css
   A /trunk/src/chrome/browser/resources/print_tab.html
   A /trunk/src/chrome/browser/resources/print_tab.js

Initial html page views for print preview and setup

This is still the foundation, has no implementation, just plain old html and its structure.

BUG=173, 947
TEST=none

Review URL: http://codereview.chromium.org/155051
------------------------------------------------------------------------
r19913 | maruel@chromium.org | 2009-07-03 21:20:11 +0200 (Fri, 03 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_win.cc

Fix EOL style on this file.

BUG=none
TEST=none

------------------------------------------------------------------------
r19910 | dglazkov@chromium.org | 2009-07-03 19:38:39 +0200 (Fri, 03 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   A /trunk/src/chrome/browser/visitedlink_event_listener.cc
   A /trunk/src/chrome/browser/visitedlink_event_listener.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/visitedlink_common.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc

Fix Acid3 Test 48: LINKTEST, Chromium side....

R=brettw
BUG=http://crbug.com/231
BUG=http://crubg.com/5160
TEST=ExpireHistoryTest.ArchiveSomeOldHistory
TEST=ExpireHistoryTest.ExpiringVisitsReader
TEST=VisitedLinkTest.Listener
TEST=VisitedLinkTest.Resizing
TEST=VisitedLinkRelayTest.*
TEST=VisitedLinkEventsTest.*


Review URL: http://codereview.chromium.org/113591
------------------------------------------------------------------------
r19909 | brettw@chromium.org | 2009-07-03 19:32:37 +0200 (Fri, 03 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   D /trunk/src/chrome/browser/renderer_host/render_view_host_manager.cc
   D /trunk/src/chrome/browser/renderer_host/render_view_host_manager.h
   D /trunk/src/chrome/browser/renderer_host/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   A /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc (from /trunk/src/chrome/browser/renderer_host/render_view_host_manager.cc:19893)
   A /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h (from /trunk/src/chrome/browser/renderer_host/render_view_host_manager.h:19893)
   A /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc (from /trunk/src/chrome/browser/renderer_host/render_view_host_manager_unittest.cc:19893)
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Move RenderViewHostManager back to tab_contents. Moving it to renderer_host
was a bad idea because of its significant dependencies on NavigationController
and NavigationEntry. I'm trying to make renderer_host not depend on tab_contents
at all.

Remove the dependency on TabContents pointers for notifications from the
ResourceDispatcherHost. Instead of having the broadcast code in the
ResourceDispatcherHost, I made it call a RenderViewHostDelegate callback. Then
TabContents implements the notification, so that it's really from the
TabContents.
Review URL: http://codereview.chromium.org/150069
------------------------------------------------------------------------
r19907 | sverrir@google.com | 2009-07-03 17:27:15 +0200 (Fri, 03 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/common/notification_type.h

Remove unused notification in print code to simplify before refactoring.
Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument.
Also made the --debug-print startup parameter only active in non-official builds.

BUG=none
TEST=Should have no functional affect.

Review URL: http://codereview.chromium.org/149148
------------------------------------------------------------------------
r19906 | mhm@chromium.org | 2009-07-03 14:13:48 +0200 (Fri, 03 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/print_ui.cc
   A /trunk/src/chrome/browser/dom_ui/print_ui.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/render_view.cc

Foundations for Print Preview and Setup

Create the foundations of implementing a tab for printing should be in the form of:
print:http://www.google.com
I have followed similar approach as what has been done with view-source: and chrome-extension:

BUG=173, 947
TEST=none

Review URL: http://codereview.chromium.org/150207
------------------------------------------------------------------------
r19904 | pfeldman@chromium.org | 2009-07-03 13:07:48 +0200 (Fri, 03 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/console_test_page.html
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Console tests.
Review URL: http://codereview.chromium.org/149178
------------------------------------------------------------------------
r19902 | apavlov@chromium.org | 2009-07-03 11:45:44 +0200 (Fri, 03 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc

Handle partial sends over the ChromeDevToolsProtocol.

send() can send parts of the buffer fed in. We should send parts of the buffer until the entire buffer has been transferred.
Review URL: http://codereview.chromium.org/150229
------------------------------------------------------------------------
r19889 | finnur@chromium.org | 2009-07-03 04:29:51 +0200 (Fri, 03 Jul 2009) | 18 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/default_extensions
   A /trunk/src/chrome/browser/extensions/default_extensions/external_extensions.json (from /trunk/src/chrome/browser/extensions/external_extensions.json:19757)
   D /trunk/src/chrome/browser/extensions/external_extensions.json
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/installer/mini_installer/mini_installer.vcproj
   M /trunk/src/chrome/installer/mini_installer.gyp

Create a project for maintaining default extensions.

This project is responsible for listing and copying the 
extensions we want to ship with Chrome by default. It 
copies the .crx files listed in the project plus a
.json file from:
  src\chrome\browser\extensions\default_extensions
to
  debug\extensions

... where the mini_installer will pick them up. At the
moment only the json file is getting copied, but we can
add .crx files when they are ready.

BUG=None
TEST=I will give a build to QA for testing this.

Review URL: http://codereview.chromium.org/155016
------------------------------------------------------------------------
r19887 | finnur@chromium.org | 2009-07-03 04:29:12 +0200 (Fri, 03 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc

Initializing the struct before using it, as mandated by
our Coverity overlord.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/149155
------------------------------------------------------------------------
r19884 | arv@google.com | 2009-07-03 04:04:52 +0200 (Fri, 03 Jul 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Make action buttons listen to the enter key.

Hide menus when the window is blurred or the user presses Alt or Meta.

Only show tootlip for the title of the thumbnail.

Allow mouse over on the window menu.

Made the windows opaque but with a hsla background color to make it more readable.

Quote all background image URLs so that we can display icons for URLs with spaces in them.

Call preventDefault when using the keyboard to navigate the options menu so that the page does not scroll.

BUG=15268, 15503, 15715, 15769, 15411, 15458

TEST=See bug descriptions

Review URL: http://codereview.chromium.org/149163
------------------------------------------------------------------------
r19879 | meelapshah@chromium.org | 2009-07-03 02:49:13 +0200 (Fri, 03 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Modify ThumbnailStore to make one call to the HistoryBackend using QueryTopURLsAndRedirects instead of a seperate call for each URL.  Also clean up some of the code and fix bug 14644.

BUG=14644
TEST=none

Review URL: http://codereview.chromium.org/149126
------------------------------------------------------------------------
r19877 | arv@google.com | 2009-07-03 02:47:00 +0200 (Fri, 03 Jul 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Another batch of performance improvements for NNTP.

Hard code the DOM and the layout for the default case so that we do not
need to do any js layout at startup.

Be more careful when calling layout. I added a dirty bit so that we
don't layout too often.

CSS cleanup/optimization to make selectors faster.

TEST=Run the perf test

BUG=13362

Review URL: http://codereview.chromium.org/149127
------------------------------------------------------------------------
r19874 | estade@chromium.org | 2009-07-03 02:43:55 +0200 (Fri, 03 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

GTK: Preview images in file chooser.

BUG=http://crbug.com/15500
TEST=select an image in a file chooser

Review URL: http://codereview.chromium.org/151100
------------------------------------------------------------------------
r19872 | jam@chromium.org | 2009-07-03 02:43:21 +0200 (Fri, 03 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   A /trunk/src/chrome/test/data/showmodaldialog.html
   A /trunk/src/chrome/test/data/showmodaldialog_dialog.html
   A /trunk/src/chrome/test/data/showmodaldialog_dialog.js

Fix showModalDialog regression.

BUG=4202
TEST=added regression test.
Review URL: http://codereview.chromium.org/149143
------------------------------------------------------------------------
r19871 | estade@chromium.org | 2009-07-03 02:43:13 +0200 (Fri, 03 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

Change some numbers on the gtk bookmark bar.

height = 29 matches windows constant
padding between bookmark name and favico: I couldn't find a relevant constant in the windows code, so I experimentally matched the spacing between the two, for the same bookmark on linux and windows.

BUG=http://crbug.com/15882
TEST=look at bookmark bar

Review URL: http://codereview.chromium.org/155019
------------------------------------------------------------------------
r19870 | estade@chromium.org | 2009-07-03 02:42:32 +0200 (Fri, 03 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

Knock out a couple more TODOs from the bookmark manager.

TEST=edit the name of a folder; it should update in the left pane. Add a new bookmark URL; it should show up selected in the right pane. Also, see bug
BUG=http://crbug.com/15844

Review URL: http://codereview.chromium.org/149151
------------------------------------------------------------------------
r19869 | estade@chromium.org | 2009-07-03 02:42:30 +0200 (Fri, 03 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

Re-show bookmark bar buttons whenever they're configured.

BUG=http://crbug.com/15859
TEST=see bug

Review URL: http://codereview.chromium.org/155008
------------------------------------------------------------------------
r19868 | erg@google.com | 2009-07-03 02:42:29 +0200 (Fri, 03 Jul 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.h
   A /trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   A /trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h

GTK: Initial implementation of using GTK themes, partially based on evan's CL 118358.

A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.

A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.

TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images.
http://crbug.com/13967

Review URL: http://codereview.chromium.org/150176
------------------------------------------------------------------------
r19866 | victorw@chromium.org | 2009-07-03 02:24:57 +0200 (Fri, 03 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   M /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   A /trunk/src/chrome/browser/renderer_host/file_system_accessor.cc
   A /trunk/src/chrome/browser/renderer_host/file_system_accessor.h
   A /trunk/src/chrome/browser/renderer_host/file_system_accessor_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/api/public/WebKitClient.h
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc

Add getFileSize support to chromium

The current implementation only allows getting file size
if the child process has been granted permission to upload file.
May need to update the policy checking code if getFileSize
is needed in other cases.

Here is the webkit implementation to support this:
https://bugs.webkit.org/show_bug.cgi?id=26521

TEST=none
BUG=9102

Review URL: http://codereview.chromium.org/131082
------------------------------------------------------------------------
r19861 | mirandac@chromium.org | 2009-07-03 01:56:22 +0200 (Fri, 03 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Revert 19829.

BUG= http://crbug.com/1455

Review URL: http://codereview.chromium.org/149156
------------------------------------------------------------------------
r19844 | mpcomplete@chromium.org | 2009-07-02 22:42:26 +0200 (Thu, 02 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Fix some issues with extension messaging:
- Disconnect ports properly (javascript mistake).
- Use the right port ID when dispatching the disconnect event.
- Fix a bug with 2 extensions loaded in the same process.

BUG=12686
BUG=15798
TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting.

Review URL: http://codereview.chromium.org/152003
------------------------------------------------------------------------
r19843 | brettw@chromium.org | 2009-07-02 22:40:21 +0200 (Thu, 02 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/new_browser_window_widget.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc

Fix the Linux2 build.

I removed the extra argument from WidgetGTK::Init but didn't update these sites.

Review URL: http://codereview.chromium.org/155006
------------------------------------------------------------------------
r19839 | estade@chromium.org | 2009-07-02 22:33:47 +0200 (Thu, 02 Jul 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

GTK: when doing a drag from a web page, pass a recent mouse down to gtk_drag_begin() so it has a better idea what time to pass to gdk_grab_pointer().

I believe the following was happening:
- render view gets mouse down, forwards to webkit
- render view gets motion, forwards to webkit
- user releases mouse button, that event is added to the queue
- browser gets message from webkit that a drag has begun, calls gtk_drag_begin() with no event
- gtk_drag_begin initiates a cursor grab, but it only applies to events that have not yet been added to the queue
- mouse release comes up in queue; passed to render view rather than the drag widget

TEST=You can't get stuck in really short render view drags. Whereas it was really easy to repro before (especially in Xephyr), I can repro no longer.
BUG=http://crbug.com/15768

Review URL: http://codereview.chromium.org/150204
------------------------------------------------------------------------
r19838 | estade@chromium.org | 2009-07-02 22:33:40 +0200 (Thu, 02 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

Fix bookmark util crash

BUG=http://crbug.com/15853
TEST=none

Review URL: http://codereview.chromium.org/155004
------------------------------------------------------------------------
r19837 | jrg@chromium.org | 2009-07-02 22:32:54 +0200 (Thu, 02 Jul 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Pop-up chrome.

BUG=http://crbug.com/15727

TEST=Load a web page that has a popup.  Example:
  <!DOCTYPE html>
  Click button to open a new window.
  <br>
  <button onclick="w = window.open('http://www.google.com', 'New Window', 'width=512,height=512'); w.moveTo(300,300);">Open with w,h</button>

Now click on the button to get a pop-up.  In the new window, make sure
there is no "tab" area above the URL bar, and no "new tab" button.
Hit Cmd-T to create a new tab, and make sure it gets created in the
OTHER window.

More work is needed to minimize pop-up chrome more, but this'll
prevent the most brutal failures (e.g. team meeting "demo" today).


Review URL: http://codereview.chromium.org/151135
------------------------------------------------------------------------
r19832 | eroman@chromium.org | 2009-07-02 22:00:49 +0200 (Thu, 02 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h

Fix a typo I came across while debugging.

BUG=None
TEST=None
TBR=brettw

Review URL: http://codereview.chromium.org/149128
------------------------------------------------------------------------
r19830 | jhawkins@chromium.org | 2009-07-02 21:25:42 +0200 (Thu, 02 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc

Add more functionality to the gtk task manager:
* Columns are resizable.
* Resource icon displayed by resource name.

BUG=11392
TEST=none
------------------------------------------------------------------------
r19829 | mirandac@chromium.org | 2009-07-02 21:23:03 +0200 (Thu, 02 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Change status bubble so that it expands to accommodate URL's that are abridged in the standard width.

BUG= http://crbug.com/1455
TEST= Mouse over a link which is abridged in the status bubble.  Hover for 2 seconds.  Link should expand to show as much as possible without extending out of the view in which it is contained.

Review URL: http://codereview.chromium.org/146043
------------------------------------------------------------------------
r19827 | estade@chromium.org | 2009-07-02 20:55:59 +0200 (Thu, 02 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h

GTK: Clean up some bookmark related UI hacks.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/150203
------------------------------------------------------------------------
r19822 | stuartmorgan@chromium.org | 2009-07-02 18:58:03 +0200 (Thu, 02 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/keychain_mock_mac.cc
   M /trunk/src/chrome/browser/keychain_mock_mac.h
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h

Implement Add and Update for PasswordStoreMac.
Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing.
Add creator code for keychain items we create, and unit tests to make sure.

BUG=11745
TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction.
Review URL: http://codereview.chromium.org/151176
------------------------------------------------------------------------
r19820 | brettw@chromium.org | 2009-07-02 18:21:17 +0200 (Thu, 02 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_views.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_views.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/simple_menu_model.cc
   M /trunk/src/views/controls/menu/simple_menu_model.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window_gtk.cc

Convert menu strings to UTF16, fix some views-GTK build errors.

Review URL: http://codereview.chromium.org/150171
------------------------------------------------------------------------
r19817 | rafaelw@chromium.org | 2009-07-02 17:52:17 +0200 (Thu, 02 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc

TBR:
------------------------------------------------------------------------
r19811 | rafaelw@chromium.org | 2009-07-02 16:22:49 +0200 (Thu, 02 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

reenable RenderViewHostManager browertest, add DownloadsCompleteObserver to ui_test_utils.

R=aa

Review URL: http://codereview.chromium.org/151189
------------------------------------------------------------------------
r19810 | jeremy@chromium.org | 2009-07-02 16:08:04 +0200 (Thu, 02 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm

This reverts 2 CLs that worked around a problem with NSGradient on 10.6,
the underlying issue is fixed in the latest seed so we don't need the workaround anymore:

* r16073 "Fixup colors for inactive tab."
* r15328 "Fixes for 10.6" (only the changes to tab_cell.mm)

Review URL: http://codereview.chromium.org/151197
------------------------------------------------------------------------
r19807 | pfeldman@chromium.org | 2009-07-02 12:49:57 +0200 (Thu, 02 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/webkit/glue/devtools/js/devtools.css

Add split with devtools container into the browser view.

Review URL: http://codereview.chromium.org/151150
------------------------------------------------------------------------
r19803 | yuzo@chromium.org | 2009-07-02 07:38:16 +0200 (Thu, 02 Jul 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.cc

Fix: Spurious SQL error message is logged in priming SQLite database cache.

This patch depends on the MetaTableHelper refactoring in:
http://codereview.chromium.org/150094

Currently, a spurious SQL error message is logged every time a unit test that
access SQLite database runs.

Example:
[----------] 6 tests from HistoryBackendTest
[ RUN      ] HistoryBackendTest.Loaded
[5660:5304:0630/150705:414864129:ERROR:sqlite_utils.cc(204)] SQLStatement.prepare_v2 failed: no such table: meta

BUG=none
TEST=n/a

Review URL: http://codereview.chromium.org/150095
------------------------------------------------------------------------
r19802 | yuzo@chromium.org | 2009-07-02 06:27:53 +0200 (Thu, 02 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/chrome/browser/meta_table_helper.h
   A /trunk/src/chrome/browser/meta_table_helper_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Refactor MetaTableHelper to remove redundant table name prefixing with database
name. Also, PrimeCache logic duplicated in HistoryBackend and
SQLitePersistentCookieStore is moved to this class.

BUG=none
TEST=n/a

Review URL: http://codereview.chromium.org/150094
------------------------------------------------------------------------
r19801 | estade@chromium.org | 2009-07-02 04:49:16 +0200 (Thu, 02 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Paint infobar background as gradient.

TEST=look at an infobar
BUG=none

Review URL: http://codereview.chromium.org/151162
------------------------------------------------------------------------
r19800 | cmp@google.com | 2009-07-02 04:12:14 +0200 (Thu, 02 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Prefer arraysize() over sizeof().

Fix a call to sizeof() on a static array to use
arraysize() instead.  Maybe fixes a coverity issue,
too.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/150202
------------------------------------------------------------------------
r19797 | arv@google.com | 2009-07-02 03:01:15 +0200 (Thu, 02 Jul 2009) | 37 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix performance issues with NNTP.

My tests show it as not as fast as the old NTP but it is a lot better
than before these changes:

Old NTP:
         208
         223
         211
         205
         211
Average: 211.6

NNTP before this change:
         732
         718
         718
         713
Average: 720.25

NNTP with this change:
         255
         248
         257
         254
         257
Average: 254.2

There is still room for improvements but this brings the NNTP perf
closer to being acceptable.

BUG=13362

TEST=Perf test at http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-cold/report.html?history=200


Review URL: http://codereview.chromium.org/150194
------------------------------------------------------------------------
r19779 | sky@chromium.org | 2009-07-02 00:35:26 +0200 (Thu, 02 Jul 2009) | 12 lines
Changed paths:
   M /trunk/src/base/id_map.h
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc

Adds some debugging code in hopes of tracking down a
crash. Specifically:

. Adds a CHECK to IDMap that evaluates to true if adding NULL. The
  default isn't to do this check.
. browser_shutdown CHECKs if the # RPHs changes while iterating
  through the RPHs.

BUG=15615
TEST=none

Review URL: http://codereview.chromium.org/150181
------------------------------------------------------------------------
r19776 | sky@chromium.org | 2009-07-02 00:17:09 +0200 (Thu, 02 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/views/new_browser_window_widget.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc

Adds user metrics for tab overview.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151172
------------------------------------------------------------------------
r19773 | stuartmorgan@chromium.org | 2009-07-01 23:57:59 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Remove a bunch of low-level keychain helper tests that are now redundant with tests of the newer higher-level methods.
Start collecting the helpers into a cohesive class that serves as a translation layer between keychain items and password forms.

BUG=none
TEST=Keychain passwords should still fill after a username is typed on the Mac (no change in behavior).
Review URL: http://codereview.chromium.org/151164
------------------------------------------------------------------------
r19772 | finnur@chromium.org | 2009-07-01 23:57:00 +0200 (Wed, 01 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/page_action.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/page_action.crx
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html
   A /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16-subscribed.png
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

PageActions can now specify multiple icons and switch between them
using optional parameters to enableForTab.

BUG=http://crbug.com/11906
TEST=None

Review URL: http://codereview.chromium.org/149046
------------------------------------------------------------------------
r19771 | pinkerton@chromium.org | 2009-07-01 23:56:45 +0200 (Wed, 01 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm

Call superclass's TearDown to avoid leaks.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150183
------------------------------------------------------------------------
r19770 | evan@chromium.org | 2009-07-01 23:56:25 +0200 (Wed, 01 Jul 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Make Linux restore Omnibox contents on tab switch.

Tested as follows:

Create a new window with two tabs.  Type a bunch of 'a' characters into tab A's omnibox and a bunch of 'b's into tab B.  Then,

1. Select tab A.  Left-click in the omnibox and highlight a few characters in the middle.  Left-click in the empty space to the right of the text to unhighlight it, then middle-click to make sure that the previously-highlighted text still gets pasted.

2. Repeat 1, but hit a key to remove the selection instead of clicking the mouse.  The old highlighted text should still be available as the primary selection.

3. Highlight A's text as in 1.  Select tab B and see that the omnibox is updated to B's string and highlighting is removed.  Middle-click and confirm that the previously-highlighted text from A is pasted.

4. Select A and left-click in the middle of its string to position the cursor there.  Click on tab B and then back on A to check that A's cursor position is restored.

5. Highlight text in A.  Select tab B and then highlight text from a different window.  Switch back to A and middle-click.  The text from the different window, rather than A's previously-highlighted text, should be pasted.

BUG=9225

Review URL: http://codereview.chromium.org/151006
Patch from Dan Erat <derat@google.com>.
------------------------------------------------------------------------
r19766 | meelapshah@chromium.org | 2009-07-01 23:50:33 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Moved typedef of RedirectList from HistoryService class to history namespace.

Review URL: http://codereview.chromium.org/151168
------------------------------------------------------------------------
r19763 | mirandac@chromium.org | 2009-07-01 23:17:43 +0200 (Wed, 01 Jul 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/app/theme/close_button_mask.png
   D /trunk/src/chrome/app/theme/maximize_button_mask.png
   D /trunk/src/chrome/app/theme/minimize_button_mask.png
   D /trunk/src/chrome/app/theme/newtab_button_mask.png
   D /trunk/src/chrome/app/theme/restore_button_mask.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Reverting 19758.
Review URL: http://codereview.chromium.org/150180
------------------------------------------------------------------------
r19761 | sky@chromium.org | 2009-07-01 23:06:29 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_grid.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_grid.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc

Improves tab overview.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151169
------------------------------------------------------------------------
r19759 | rafaelw@chromium.org | 2009-07-01 22:52:29 +0200 (Wed, 01 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc

Diable Broken RenderViewHostManager browsertest from http://src.chromium.org/viewvc/chrome?view=rev&revision=19752

R=ojan

Review URL: http://codereview.chromium.org/150179
------------------------------------------------------------------------
r19758 | mirandac@chromium.org | 2009-07-01 22:44:18 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/close_button_mask.png
   A /trunk/src/chrome/app/theme/maximize_button_mask.png
   A /trunk/src/chrome/app/theme/minimize_button_mask.png
   A /trunk/src/chrome/app/theme/newtab_button_mask.png
   A /trunk/src/chrome/app/theme/restore_button_mask.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Theme window control buttons.

BUG= http://crbug.com/14579
TEST= Install a theme with themed window control buttons.  Observe that WCB's are themed.

Review URL: http://codereview.chromium.org/150041
------------------------------------------------------------------------
r19752 | rafaelw@chromium.org | 2009-07-01 21:13:41 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc

Fix to allow browser close after download initiated from chrome:// url.

R=brettw
BUG=12745

Review URL: http://codereview.chromium.org/150122
------------------------------------------------------------------------
r19751 | avi@chromium.org | 2009-07-01 20:49:07 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm

Allow getting the theme tint as a value so that it can be applied independent of the theme provider. Since the Mac needs it to tint its vector resources it's added to the Mac.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151153
------------------------------------------------------------------------
r19747 | asargent@chromium.org | 2009-07-01 20:24:32 +0200 (Wed, 01 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Create an interface just for update-related functions in ExtensionsService.

This abstracts out the pieces that ExtensionUpdater will depend on, to allow easy mocking.

BUG=http://crbug.com/12117
TEST=none

Review URL: http://codereview.chromium.org/151127
------------------------------------------------------------------------
r19745 | meelapshah@chromium.org | 2009-07-01 19:54:53 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc

Temporary fix for page_cycler perf regression.

Review URL: http://codereview.chromium.org/151159
------------------------------------------------------------------------
r19744 | finnur@chromium.org | 2009-07-01 19:40:02 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc

Try to track down the cause of the Drag&Drop crash seen in bug 12524.

BUG=12524
TEST=None, we just need to monitor the crash reports from the field.

Review URL: http://codereview.chromium.org/150136
------------------------------------------------------------------------
r19743 | meelapshah@chromium.org | 2009-07-01 19:27:37 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_types.h

Add a function to the History to return a list of the top n visited URLs where and the list of most recent redirects for each of those URLs.

Review URL: http://codereview.chromium.org/151057
------------------------------------------------------------------------
r19740 | mirandac@chromium.org | 2009-07-01 18:55:15 +0200 (Wed, 01 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html

Remove null link from "welcome to tips" default suggestion.  Also make some hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556.


BUG= http://crbug.com/15467
TEST= Run with new new tab page for the first time, with no tips stored in preferences.  Note that welcome tip is not a link.

Review URL: http://codereview.chromium.org/147247
------------------------------------------------------------------------
r19738 | jhawkins@chromium.org | 2009-07-01 18:31:07 +0200 (Wed, 01 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.h

Implement the core functionality of the gtk task manager.

BUG=11392
TEST=none
Review URL: http://codereview.chromium.org/151154
------------------------------------------------------------------------
r19736 | sky@chromium.org | 2009-07-01 17:51:13 +0200 (Wed, 01 Jul 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/app/theme/newtab2.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

More new tab button tweaks. I'm leaving tab_start_x as I suspect I'm
going to need it again shortly.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151126
------------------------------------------------------------------------
r19735 | pinkerton@chromium.org | 2009-07-01 17:50:51 +0200 (Wed, 01 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   A /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.h
   A /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller.mm
   A /trunk/src/chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. Implement displaying of notification, menu of popups still to come.
BUG=13160
TEST=popup notification should display and popups blocked accordingly. Can close notification widget to prevent more notifications for this tab.
Review URL: http://codereview.chromium.org/150132
------------------------------------------------------------------------
r19733 | brettw@chromium.org | 2009-07-01 17:45:25 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Make sure tabs open on the left like normal.

Review URL: http://codereview.chromium.org/151117
------------------------------------------------------------------------
r19731 | pinkerton@chromium.org | 2009-07-01 17:26:22 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

The real unit test for bug 12902, which didn't land before (computers are hard, mmkay?).
BUG=12902
TEST=none
------------------------------------------------------------------------
r19729 | avi@chromium.org | 2009-07-01 17:01:06 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider_mac.mm

Switch to getting theme images via SkBitmap.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151104
------------------------------------------------------------------------
r19728 | pinkerton@chromium.org | 2009-07-01 16:50:15 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc

Whoops, accidentally committed a debug line
BUG=none
TEST=none
------------------------------------------------------------------------
r19727 | pinkerton@chromium.org | 2009-07-01 16:40:38 +0200 (Wed, 01 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   M /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc

Added unit tests for ClearBrowsingDataController.
Fixed a bug in ClearBrowsingDataController: checking Delete Form Data would end
up deleting passwords instead. Patch from Jens Alfke (snej@google.com).
BUG=12902
TEST=deleting form data should actually delete the form data.
------------------------------------------------------------------------
r19725 | rohitrao@chromium.org | 2009-07-01 16:21:17 +0200 (Wed, 01 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/base_view.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Converts BaseView to be non-opaque, which will fix drawing of
overlapping views, including the findbar and resize widget.  Three
classes currently inherit from BaseView: TabContentsViewCocoa,
RenderWidgetHostViewCocoa, and SadTabView (Mac).

BUG=http://crbug.com/10887
BUG=http://crbug.com/13150
TEST=Findbar should never disappear when searching.  Resize
widget should never disappear.  Clicking and dragging in a webpage should not move the window around.
Review URL: http://codereview.chromium.org/150104
------------------------------------------------------------------------
r19723 | pfeldman@chromium.org | 2009-07-01 15:21:41 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   D /trunk/src/chrome/browser/debugger/devtools_container.cc
   D /trunk/src/chrome/browser/debugger/devtools_container.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

DevTools: Add docked pane into the browser view.

Review URL: http://codereview.chromium.org/150160
------------------------------------------------------------------------
r19722 | yurys@google.com | 2009-07-01 12:51:56 +0200 (Wed, 01 Jul 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: check that devtools front-end JS files are loaded before running a test, otherwise the test will hang waiting for reponse from the front-end.
Review URL: http://codereview.chromium.org/151143
------------------------------------------------------------------------
r19719 | aa@chromium.org | 2009-07-01 11:02:32 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

fix build bustage

Review URL: http://codereview.chromium.org/150157
------------------------------------------------------------------------
r19717 | aa@chromium.org | 2009-07-01 10:46:25 +0200 (Wed, 01 Jul 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/extensions/extension_dom_ui.cc
   A /trunk/src/chrome/browser/extensions/extension_dom_ui.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/page.html

In this episode, we implement the DOMUI interface for extension views that are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy.

BUG=13936

Review URL: http://codereview.chromium.org/126137
------------------------------------------------------------------------
r19713 | pfeldman@chromium.org | 2009-07-01 09:50:04 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/devtools_container.cc
   A /trunk/src/chrome/browser/debugger/devtools_container.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/inject_dispatch.js
   M /trunk/src/webkit/glue/devtools/js/inspector_controller_impl.js
   M /trunk/src/webkit/glue/webdevtoolsclient_delegate.h
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.h

DevTools: Introduce docked version of DevTools.

Review URL: http://codereview.chromium.org/149071
------------------------------------------------------------------------
r19711 | yurys@google.com | 2009-07-01 09:25:16 +0200 (Wed, 01 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: fix debugger test, reenable debugger and resources tests.

BUG=15677
Review URL: http://codereview.chromium.org/151140
------------------------------------------------------------------------
r19710 | aa@chromium.org | 2009-07-01 08:42:32 +0200 (Wed, 01 Jul 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc

TBR:
------------------------------------------------------------------------
r19709 | aa@chromium.org | 2009-07-01 07:25:22 +0200 (Wed, 01 Jul 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_startup_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/data/extensions/content_script_inject/js_test.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script1.css
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script1a.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script1b.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script2.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script3.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject_page.html
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script2.js
   A /trunk/src/chrome/test/data/extensions/test_file.html
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json

Adds a browser_test for extension startup, content script
injection, and user script injection.

Also adds unit tests that EXTENSIONS_READY always gets fired.

Also removes some old test data that we weren't using.

Review URL: http://codereview.chromium.org/149120
------------------------------------------------------------------------
r19708 | yuzo@chromium.org | 2009-07-01 06:51:47 +0200 (Wed, 01 Jul 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Fix: Certain redirections remove sites from the history

Currently, PageTransition::CHAIN_END flag is removed from a History database
entry for a redirect source, even when the redirect is user initiated.

This change prevents the flag removal for user-initiated redirects.

TEST=Open http://www.google.com/ig and click on tabs multiple times. Without
this change, only the last tab clicked appears in the History page (CTRL+H).
With this change, all the tabs should appear.

TESTED=gcl try, manually

BUG=11355

Review URL: http://codereview.chromium.org/147145
------------------------------------------------------------------------
r19707 | hbono@chromium.org | 2009-07-01 06:41:53 +0200 (Wed, 01 Jul 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/webkit/api/public/gtk/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp

A quick fix for Issue 15531 and 10953
This issue is caused by my another mistake that I forgot setting the modifier-key state in creating a Char event in RenderWidgetHostViewGtkWidget::ForwardCharEvent().
Since the GtkIMContext signal-handlers don't use GdkEventKey objects and cannot get the modififer-key state, this change save the state in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() before dispatching a key event to the GtkIMContext object.

Also, this change adds gtk_im_context_focus_in() and gtk_im_context_focus_out() calls to fix compatibility problems with ibus.

BUG=10953 "IME support"
BUG=15531 "regression: shift-space doesn't scroll the page backwards"
TEST=Open a test page in <http://crbug.com/15531>, press shift+space keys, and observe ev.shiftKey is true.  
Review URL: http://codereview.chromium.org/151010
------------------------------------------------------------------------
r19706 | craig.schlenter@chromium.org | 2009-07-01 06:40:39 +0200 (Wed, 01 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc

Ensure bookmark title truncation always produces a valid UTF-8 string.

We also add ellipses to the bookmark title.

TEST = A bookmark with a title that has a UTF-8 character that spans
the 15 character truncation point should not cause "Gtk: Invalid input
string" errors. See http://dev.chromium.org/developers/coding-style
for an example of the problem. The title in that case is as follows:
"Coding Style \u200E(Chromium Developer Documentation)\u200E"

Review URL: http://codereview.chromium.org/147207
------------------------------------------------------------------------
r19704 | estade@chromium.org | 2009-07-01 05:11:11 +0200 (Wed, 01 Jul 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Bookmark manager polish:

- set a better default size
- ellipsize columns
- allow users to change column widths
- remember user-modified column widths

BUG=http://crbug.com/14742
TEST=none

Review URL: http://codereview.chromium.org/151134
------------------------------------------------------------------------
r19703 | estade@chromium.org | 2009-07-01 05:11:02 +0200 (Wed, 01 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Don't try to optimize out browser window reshapes.

The optimization failed to account for the possiblity of consecutive reshapes with different sizes. Instead of making the optimization smarter, just get rid of it, as it isn't clear it helps anything.

BUG=none
TEST=resize browser with custom frame on.

Review URL: http://codereview.chromium.org/151132
------------------------------------------------------------------------
r19692 | cpu@google.com | 2009-07-01 02:57:43 +0200 (Wed, 01 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Regression: task manager icon for chrome is blank
- During first run (confusing the newbie)
- In other special situations when we show UI before the main chrome window is created

BUG=14192
TEST=see bug


Review URL: http://codereview.chromium.org/151061
------------------------------------------------------------------------
r19691 | paul@chromium.org | 2009-07-01 02:52:18 +0200 (Wed, 01 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/chrome.gyp

Enable opening downloads from the Mac download shelf.

Also added a stub for an unused method on Canvas in order to link.

TEST=Selecting "Open" from the shelf menu will open a download
BUG=15661

Review URL: http://codereview.chromium.org/150079
------------------------------------------------------------------------
r19690 | sky@chromium.org | 2009-07-01 02:43:29 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h

Disables unit test as starting failing due to close to end of month.

BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/150147
------------------------------------------------------------------------
r19686 | mpcomplete@chromium.org | 2009-07-01 02:01:03 +0200 (Wed, 01 Jul 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Send port disconnect events when a frame is unloaded.

This is the other half of CL http://codereview.chromium.org/125280, which I split into http://codereview.chromium.org/147033 and this CL.

BUG=12686
TEST=no

Review URL: http://codereview.chromium.org/150125

------------------------------------------------------------------------
r19685 | stuartmorgan@chromium.org | 2009-07-01 01:59:17 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Wire up a LoginDatabase for PasswordStoreMac, and start using it for lookup.
(Although it will always be empty at this point, since storage isn't implemented yet.)

BUG=11745
TEST=none (no user-visible effect yet)
Review URL: http://codereview.chromium.org/147044
------------------------------------------------------------------------
r19681 | jcampan@chromium.org | 2009-07-01 01:07:55 +0200 (Wed, 01 Jul 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc

A recent refactoring of the DOM UI had caused the download page to be blank.
A call to Init had been removed.

BUG=http://crbug.com/15680
TEST=Download a file. Open the download page (CTRL-J) it should show the download.
Review URL: http://codereview.chromium.org/151110
------------------------------------------------------------------------
r19680 | brettw@chromium.org | 2009-07-01 00:50:32 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_gtk.cc

Fix missing include.

Review URL: http://codereview.chromium.org/151123
------------------------------------------------------------------------
r19679 | brettw@chromium.org | 2009-07-01 00:38:27 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Fix typo for build

Review URL: http://codereview.chromium.org/151121
------------------------------------------------------------------------
r19676 | jrg@chromium.org | 2009-07-01 00:27:23 +0200 (Wed, 01 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Add Mac-specific sizing rule with unit test.
Port rest of window_sizer_unittest.cc to non-Windows.

Review URL: http://codereview.chromium.org/149035
------------------------------------------------------------------------
r19675 | brettw@chromium.org | 2009-07-01 00:25:37 +0200 (Wed, 01 Jul 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/tab_contents/tab_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_util.h
   M /trunk/src/chrome/browser/task_manager.cc

Move GetTabContentsID out of tab util because it has nothing to do with tabs or
TabContents. I put a more accurately named static function in
ResourceDispatcherHost which is what really controls this request data.

I also moved a couple of static functions from the header to the cc in
resource_dispatcher.

Review URL: http://codereview.chromium.org/150124
------------------------------------------------------------------------
r19674 | kuchhal@chromium.org | 2009-07-01 00:22:58 +0200 (Wed, 01 Jul 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

FixIt: Remove first run dead code.

Review URL: http://codereview.chromium.org/151089
------------------------------------------------------------------------
r19667 | meelapshah@chromium.org | 2009-07-01 00:13:13 +0200 (Wed, 01 Jul 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h

Add a function to the History{Service,Backend} to query for a list of redirects ending at a specified URL.
Add the list of redirects leading to the URL to URLVisitedDetails which is broadcasted on HISTORY_URL_VISITED.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/151055
------------------------------------------------------------------------
r19666 | jrg@chromium.org | 2009-07-01 00:08:32 +0200 (Wed, 01 Jul 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/tools/valgrind/suppressions_mac.txt

Fix for
http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1303/steps/valgrind%20test:%20unit/logs/stdio

Review URL: http://codereview.chromium.org/151107
------------------------------------------------------------------------
r19654 | sky@chromium.org | 2009-06-30 23:00:27 +0200 (Tue, 30 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc

Lands http://codereview.chromium.org/126036 for Thiago.
From Thiago:

This patch is to solve the problem in import/export bookmarks. They aren't
exported correctly and also not imported
correctly. Now when the bookmarks are exported the character " are escaped to
&quot; and when they are imported,
they are unescaped.

BUG=7505
TEST=Try importing/exporting bookmarks, make sure nothing is broken.

Review URL: http://codereview.chromium.org/126222
------------------------------------------------------------------------
r19652 | pinkerton@chromium.org | 2009-06-30 22:57:24 +0200 (Tue, 30 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Remove hack for zoom button now that it's no longer needed
BUG=12498
TEST=zoom button should always be enabled.
Review URL: http://codereview.chromium.org/150134
------------------------------------------------------------------------
r19651 | glen@chromium.org | 2009-06-30 22:43:36 +0200 (Tue, 30 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Reland arv's NNTP enablery after it was reverted in 19603

TBR=arv

Review URL: http://codereview.chromium.org/151108
------------------------------------------------------------------------
r19640 | thakis@chromium.org | 2009-06-30 22:15:29 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_item_mac.mm

Fix download item icon.

BUG=none
TEST=Download something, note that the correct item shows up in the shelf.

Review URL: http://codereview.chromium.org/150015
------------------------------------------------------------------------
r19634 | mpcomplete@chromium.org | 2009-06-30 21:52:09 +0200 (Tue, 30 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/js_only_v8_extensions.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/greasemonkey_api.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Refactor extension bindings to share code, avoid exposing hidden variables
globally, and avoid using the DOM load/unload events.
- moved callback handling into event_bindings.js (ports will use it).
- added chromeHidden, a V8 hidden value, to keep all internal variables that
  need to be accessible to native code.
- changed context registration to occur always at extension load, instead of
  DOM load.
- added an internal unload event that doesn't disable SuddenTermination.

This is a rework of my earlier CL http://codereview.chromium.org/125280 which was reverted because of a perf regression.  I believe the perf problem was caused by the call into javascript I did on page load to handle context registration - this CL avoids that.

Review URL: http://codereview.chromium.org/147033

------------------------------------------------------------------------
r19633 | brettw@chromium.org | 2009-06-30 21:49:12 +0200 (Tue, 30 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Add support for shared memory when retrieving the backing store as a SkBitmap.
In my testing, this speeds it up 2-3x.

Review URL: http://codereview.chromium.org/150032
------------------------------------------------------------------------
r19625 | estade@chromium.org | 2009-06-30 20:57:52 +0200 (Tue, 30 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Update the browser window's shape on state change.

When launching the browser we restore the maximized state. However, the maximize call is asynchronous, so we don't actually observe the change to |state_| until later. So we need to update the shape on that later state-changed signal.

Usually if the user maximizes the window, it will change sizes. To avoid setting the window's shape more often than necessary, cache its current state (custom shape or no custom shape).

BUG=none
TEST=maximize the window, close chrome, re open chrome. It should not have a custom shape.

Review URL: http://codereview.chromium.org/150081
------------------------------------------------------------------------
r19619 | jhawkins@chromium.org | 2009-06-30 20:49:02 +0200 (Tue, 30 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/task_manager_gtk.cc
   A /trunk/src/chrome/browser/gtk/task_manager_gtk.h
   M /trunk/src/chrome/chrome.gyp

Add a skeleton UI for the gtk task manager.

BUG=11392
TEST=Right-click on the tabstrip and select 'Task Manager'.
Review URL: http://codereview.chromium.org/150082
------------------------------------------------------------------------
r19617 | jcampan@chromium.org | 2009-06-30 20:48:00 +0200 (Tue, 30 Jun 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.h
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/focus/external_focus_tracker.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   A /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   A /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/accelerator_handler.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_win.cc

This CL removes the last (major) Windows specific part out of the focus manager. 
It was previously landed and reverted because it broke the reliability tests.
http://codereview.chromium.org/125148

The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs.
The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure.
Files changed from the previous patch that need reviewing:
native_tab_contents_container_win.cc
tab_contents_view_win.h
tab_contents_view_win.cc

BUG=None
TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome.



Review URL: http://codereview.chromium.org/146093
------------------------------------------------------------------------
r19612 | finnur@chromium.org | 2009-06-30 20:12:48 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bug_report_view.cc

Coverity was complaining about the result of getenv not being null checked, but when I look at the code and confer with mal it looks like the offending code can just be removed (and some de-linting applied).

BUG=None
TEST=None (report a bug dialog should work as before).

Review URL: http://codereview.chromium.org/151069
------------------------------------------------------------------------
r19611 | finnur@chromium.org | 2009-06-30 20:12:40 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc

Coverity nit. Enums lacking name...

BUG=None
TEST=No need for one.

Review URL: http://codereview.chromium.org/151056
------------------------------------------------------------------------
r19610 | finnur@chromium.org | 2009-06-30 20:12:22 +0200 (Tue, 30 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc

Fix potential memleak in AddPagesWithDetails. Not a biggie 
since this is used only during testing, if the comment is
correct.

The reason this leaks is due to potential returns before
Broadcast is reached.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/151047
------------------------------------------------------------------------
r19609 | finnur@chromium.org | 2009-06-30 20:11:58 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc

Fix memleak in GetNodeDictionary.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/151041
------------------------------------------------------------------------
r19606 | dkegel@google.com | 2009-06-30 19:42:30 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable new test DevToolsSanityTest.TestEnableResourcesTab until Yuri fixes it

BUG=http://crbug.com/15677
TEST=none

Review URL: http://codereview.chromium.org/150115
------------------------------------------------------------------------
r19603 | glen@chromium.org | 2009-06-30 19:21:03 +0200 (Tue, 30 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Reverting 19593.
Review URL: http://codereview.chromium.org/150112
------------------------------------------------------------------------
r19601 | tc@google.com | 2009-06-30 19:07:55 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Take 2 at fixing BrowserThemeProvider memory leaks.

This time, don't delete images in generated_images_ since we're now going to delete them in image_cache_.

Review URL: http://codereview.chromium.org/151048

------------------------------------------------------------------------
r19599 | tc@google.com | 2009-06-30 18:49:02 +0200 (Tue, 30 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix a bug where we were getting a resize cursor near the top of the web
contents area.

Fix a bug where the background color was not updated on theme change.

BUG=14956

Review URL: http://codereview.chromium.org/151063

------------------------------------------------------------------------
r19597 | dkegel@google.com | 2009-06-30 18:41:48 +0200 (Tue, 30 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable new test DevToolsSanityTest.TestEnableScriptsTab until Yuri fixes it

BUG=http://crbug.com/15677
TEST=none

------------------------------------------------------------------------
r19595 | jar@chromium.org | 2009-06-30 18:31:54 +0200 (Tue, 30 Jun 2009) | 18 lines
Changed paths:
   M /trunk/src/base/field_trial.cc
   M /trunk/src/base/field_trial.h
   M /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Create A/B test of SDCH

To do this, I needed to add the feature that ALL FieldTrials that are
established in the browser process are forwarded and established in
the corresponding renderer processes.  This then allows both DNS impact,
 as well as SDCH inmpact (and any other field tests) to be studied
at the same time in a single binary.

This checkin also establishes a pattern that when we're doing A/B tests
via a histogram such as RequestToFinish, that we produce names for
all groups, rather than leaving one group as the "default" or "empty postfix"
group.  This is critical for naming various sub-groups when a multitude
of tests are taking place at the same time.

BUG=15479

r=mbelshe
Review URL: http://codereview.chromium.org/150087
------------------------------------------------------------------------
r19594 | rafaelw@chromium.org | 2009-06-30 18:29:56 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager.cc
   A /trunk/src/chrome/browser/renderer_host/render_view_host_manager_browsertest.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/chrome.gyp

Fixes issue where dragging a .crx to a chrome:// TabContents, and then navigating to another chrome:// url, the destination DOMUI won't be able to retrieve the data it needs (and thus not function)

BUG=14505
R=brettw

Review URL: http://codereview.chromium.org/132009
------------------------------------------------------------------------
r19593 | arv@google.com | 2009-06-30 18:26:33 +0200 (Tue, 30 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable the NNTP by default.

This renames the command line flags a bit.  

--new-tab-page=path/to/file.html

--old-new-tab-page


BUG=13362

TEST=Launch chrome and you should see the new new tab page.

Review URL: http://codereview.chromium.org/151054
------------------------------------------------------------------------
r19589 | glen@chromium.org | 2009-06-30 18:06:52 +0200 (Tue, 30 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/base/gfx/png_codec_unittest.cc
   M /trunk/src/base/gfx/png_decoder.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Reland of r19131, this time with real Math:

PNGDecoder wasn't multiplying the alpha like PNGEncoder was. This lead to color
overflow.

This intermediate fix makes everything correct, but will make alphaed pixels
slightly darker until the user's cache is flushed (I have screenshots of the effect).

BUG=13360
TEST=Run base_unittests.exe --gtest_filter=*PNG*

Review URL: http://codereview.chromium.org/150107
------------------------------------------------------------------------
r19588 | arv@google.com | 2009-06-30 18:05:08 +0200 (Tue, 30 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h

Fix for pressing escape during a drag and drop operation.

BUG=12018
Review URL: http://codereview.chromium.org/149038
------------------------------------------------------------------------
r19586 | cevans@chromium.org | 2009-06-30 17:13:09 +0200 (Tue, 30 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc

Add some limits to incoming audio stream requests to avoid allocating massive
buffers.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/147236
------------------------------------------------------------------------
r19585 | pinkerton@chromium.org | 2009-06-30 17:09:05 +0200 (Tue, 30 Jun 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   A /trunk/src/chrome/browser/spellchecker_common.h
   A /trunk/src/chrome/browser/spellchecker_linux.cc
   A /trunk/src/chrome/browser/spellchecker_mac.mm
   A /trunk/src/chrome/browser/spellchecker_platform_engine.h
   A /trunk/src/chrome/browser/spellchecker_win.cc
   M /trunk/src/chrome/chrome.gyp

Enable support for the Mac OS X spellchecking service in chromium.
spellchecker_platform_engine.h provides a basic interface for
platform specific spellcheckers to follow. spellchecker_mac.mm
implements these functions for the OS X spellchecking service.
spellchecker_win.cc and spellchecker_linux.cc provide a space for 
future developments on these platforms. spellchecker_common.h 
contains a few shared variables and typedefs that are useful across
all spellchecking code. spellchecker.cc has been modified to 
call the SpellCheckerPlatform::SpellCheckerAvailable() and use
either hunspell or the platform spellchecker based on that
call. Many new test cases have been added to one of
the unit tests as well. chrome.gyp has been edited
to reflect the added files.
patch from pwicks86@gmail.com (paul wicks)
BUG=13206
TEST=spellchecking works in web pages
------------------------------------------------------------------------
r19583 | yurys@google.com | 2009-06-30 17:06:57 +0200 (Tue, 30 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/debugger_test.js
   A /trunk/src/chrome/test/data/devtools/debugger_test_page.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: add tests that opens Scripts panel and checks that it's populated with two inspected scripts.
Review URL: http://codereview.chromium.org/151076
------------------------------------------------------------------------
r19580 | deanm@chromium.org | 2009-06-30 11:37:21 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Make the Linux location bar SSL icon padding match Windows.

The EV padding might also need adjustment later.

Review URL: http://codereview.chromium.org/151073

------------------------------------------------------------------------
r19567 | estade@chromium.org | 2009-06-30 02:20:18 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc

GTK custom frame: Don't show the border when maximized. Enlarge the close button's clickable area when maximized.

BUG= http://crbug.com/14646 and http://crbug.com/15628
TEST=maximize, turn on custom frame. The top right most pixel on the screen should be clickable and should close the window. There should be no border around the web contents.

Review URL: http://codereview.chromium.org/150078
------------------------------------------------------------------------
r19565 | paul@chromium.org | 2009-06-30 02:14:11 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Enable "Save As" on Mac.

TEST=Right clicking an image and choosing "Save As" now works.
BUG=15638

Review URL: http://codereview.chromium.org/151042
------------------------------------------------------------------------
r19562 | agl@chromium.org | 2009-06-30 02:05:08 +0200 (Tue, 30 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Linux: build fix for release builder.

r19500 triggered an error in the crash dumping code because of a
duplicate \#define.

------------------------------------------------------------------------
r19559 | jrg@chromium.org | 2009-06-30 01:56:11 +0200 (Tue, 30 Jun 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/fullscreen_window.h
   A /trunk/src/chrome/browser/cocoa/fullscreen_window.mm
   A /trunk/src/chrome/browser/cocoa/fullscreen_window_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/chrome.gyp

Mac fullscreen mode (with pkasting).

TEST=Launch Chrome.  Create a 2nd tab.  Close bookmark bar.
Cmd-F11 to enter fullscreen; make sure content is centered and both
  bookmark bar and toolbar are gone.  Make sure menubar gone.
Cmd-Opt-arrows to switch tabs; make sure still OK.
Cmd-F11 to go back; make sure things look normal.
Open bookmark bar.
Cmd-F11; make sure gone.  Cmd-F11 again; make sure it comes back.
Confirm View-->Fullscreen menu item works.
While in fullscreen, Cmd-T to create new tab and click on a fav tile.
  Make sure page loads.
While in fullscreen, try window hotkeys (Cmd-N and Cmd-W) to make sure
  they work.  Cmd-` to switch windows; switch back, then Cmd-F11 to
  undo fullscreen.
Move the mouse to to the top of the screen; make sure menubar appears.
Move the mouse down; make sure menubar goes away.


Review URL: http://codereview.chromium.org/126294
------------------------------------------------------------------------
r19557 | ben@chromium.org | 2009-06-30 01:39:19 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fix crash in delayed tab resizing. If the Resize Relayout code is called after the last tab has been closed but before the window is destroyed (this whole process is very async) there are zero tabs in the layout and as a result GetTabAt(0) will crash.

http://crbug.com/14603
TEST=none

Review URL: http://codereview.chromium.org/150064
------------------------------------------------------------------------
r19556 | tim@chromium.org | 2009-06-30 01:37:42 +0200 (Tue, 30 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Take two for http://codereview.chromium.org/131094
This time without browser_tests timeout that caused the revert.  The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached.

Review URL: http://codereview.chromium.org/149117
------------------------------------------------------------------------
r19553 | estade@chromium.org | 2009-06-30 01:36:13 +0200 (Tue, 30 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/base/mime_util.h
   M /trunk/src/base/mime_util_linux.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   D /trunk/src/chrome/browser/gtk/dnd_registry.cc
   D /trunk/src/chrome/browser/gtk/dnd_registry.h
   A /trunk/src/chrome/browser/gtk/gtk_dnd_util.cc (from /trunk/src/chrome/browser/gtk/dnd_registry.cc:19526)
   A /trunk/src/chrome/browser/gtk/gtk_dnd_util.h (from /trunk/src/chrome/browser/gtk/dnd_registry.h:19526)
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp

More web contents dragging.

TEST=drag an image (such as the google logo from google.com) into gimp or onto the desktop.
BUG=http://crbug.com/15429
Review URL: http://codereview.chromium.org/151033
------------------------------------------------------------------------
r19551 | estade@chromium.org | 2009-06-30 01:35:22 +0200 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h

Make tabstrip flush with top of titlebar when custom frame is enabled and browser is maximized.

TEST=maximize and enable custom frame
BUG=http://crbug.com/15431

Review URL: http://codereview.chromium.org/150072
------------------------------------------------------------------------
r19536 | erikkay@google.com | 2009-06-29 23:32:12 +0200 (Mon, 29 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html

a few minor tweaks the bookmarks API:
* change name "childrenIds" to "children"
* add dateAdded and dateGroupModified properties
* add id to onRemoved

BUG=13994
BUG=14581
BUG=12217
TEST=load sample bookmarks extension and play around with Dump Bookmarks


Review URL: http://codereview.chromium.org/151032
------------------------------------------------------------------------
r19535 | rohitrao@chromium.org | 2009-06-29 23:31:27 +0200 (Mon, 29 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Corrects RWHVCocoa to convert from flipped to unflipped
coordinates before whiting out unpainted areas.

BUG=None
TEST=Resize newly-created window, check for black areas.
Review URL: http://codereview.chromium.org/147232
------------------------------------------------------------------------
r19533 | finnur@chromium.org | 2009-06-29 23:29:26 +0200 (Mon, 29 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc

Fix memory leak in tips handler.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/150052
------------------------------------------------------------------------
r19531 | rohitrao@chromium.org | 2009-06-29 23:09:11 +0200 (Mon, 29 Jun 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/grow_box_view.h
   D /trunk/src/chrome/browser/cocoa/grow_box_view.mm
   D /trunk/src/chrome/browser/cocoa/grow_box_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Deletes now-unused growbox code.

BUG=None
TEST=None.  No visible impact.
------------------------------------------------------------------------
r19524 | ericroman@google.com | 2009-06-29 22:46:48 +0200 (Mon, 29 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.cc

Fix a typo in a comment.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151037
------------------------------------------------------------------------
r19520 | avi@chromium.org | 2009-06-29 22:31:29 +0200 (Mon, 29 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Allow extension extensions to be case-insensitive.

BUG=none
TEST=try to load an extension with a capital letter or two in the extension's extension. It should load.

Review URL: http://codereview.chromium.org/147017
------------------------------------------------------------------------
r19514 | estade@chromium.org | 2009-06-29 21:32:32 +0200 (Mon, 29 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Don't shutdown non-popup render views on clicks outside their bounds.

Review URL: http://codereview.chromium.org/151031
------------------------------------------------------------------------
r19513 | brettw@chromium.org | 2009-06-29 21:29:44 +0200 (Mon, 29 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Add three basic test items to RenderViewHostManagerTest:
- Init
- Navigate
- DOMUI

Original review: http://codereview.chromium.org/126060
Patch by tyoshino@google.com
------------------------------------------------------------------------
r19512 | dimich@google.com | 2009-06-29 21:09:30 +0200 (Mon, 29 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/webkit/api/public/WebKit.h
   M /trunk/src/webkit/api/src/WebKit.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Remove --enable-web-workers command-line switch.
BUG=4361
TEST=many ui/layout tests.
Review URL: http://codereview.chromium.org/149114
------------------------------------------------------------------------
r19511 | tc@google.com | 2009-06-29 20:46:25 +0200 (Mon, 29 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix a bug where all clicks in app mode windows would result in a window move.

Also update the comment to properly describe the code.  It was referring to the tab strip, but the code was using the toolbar.

BUG=15576

Review URL: http://codereview.chromium.org/150037

------------------------------------------------------------------------
r19505 | erg@google.com | 2009-06-29 20:21:33 +0200 (Mon, 29 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h

GTK: Drags from bookmark menus to the bookmark bar.

Review URL: http://codereview.chromium.org/147241
------------------------------------------------------------------------
r19503 | estade@chromium.org | 2009-06-29 20:12:36 +0200 (Mon, 29 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dnd_registry.h

update dnd registry enum to work properly with bitmask

TBR=erg

Review URL: http://codereview.chromium.org/150033
------------------------------------------------------------------------
r19501 | rohitrao@chromium.org | 2009-06-29 19:58:47 +0200 (Mon, 29 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/en.lproj/TabContents.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm

Removes our homespun grow box and replaces it with the
standard widget.  This may also fix some of our resizing
issues.

BUG=http://crbug.com/14663
TEST=The resizer widget should still work as expected.
Review URL: http://codereview.chromium.org/149094
------------------------------------------------------------------------
r19499 | finnur@chromium.org | 2009-06-29 19:55:58 +0200 (Mon, 29 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc

Coverity: Initialize member view_ to NULL in constructor.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/150028
------------------------------------------------------------------------
r19496 | jhawkins@chromium.org | 2009-06-29 19:38:22 +0200 (Mon, 29 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Two fixes for tab dragging in gtk:
* Check that backing_store_ is non-NULL before using it.  A drag can be initiated before the backing store has been created.
* Don't read a size greater than the size of the backing store image.

BUG=15387
TEST=Hard to reproduce.  Quickly initiate a tab drag after opening a new tab.
Review URL: http://codereview.chromium.org/150008
------------------------------------------------------------------------
r19495 | estade@chromium.org | 2009-06-29 19:35:32 +0200 (Mon, 29 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   A /trunk/src/chrome/browser/gtk/dnd_registry.cc
   M /trunk/src/chrome/browser/gtk/dnd_registry.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/chrome.gyp

GTK DND:

- Rearrange DND constants, create convenience functions
- (partially) implement drag onto home button

Note that the homepage is still hard-wired to the dev build splash page, so that it seems like this isn't working, but via debugging I ascertained that dragging a random file from the desktop onto the home button should successfully set that file as the homepage.

TEST=drag a lot of stuff all over the place (tabs, bookmarks, what have you), make sure nothing crashes
BUG=none

Review URL: http://codereview.chromium.org/147256
------------------------------------------------------------------------
r19493 | brettw@chromium.org | 2009-06-29 19:25:27 +0200 (Mon, 29 Jun 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Let RenderProcessHost provide a method HasConnection() instead of exposing
channel().

Motivation:
Currently, components that are using RenderProcessHost are checking its
liveness by null testing on channel(). I'd like to write unittests for those
components, but to mock out RenderProcessHost instances, I have to also
mock out the instance returned by RenderProcessHost::channel(), but there's
no interface class prepared. SyncChannel is directly used in RenderProcessHost.
Instead of dependency injection, I can let mock objects return invalid pointer
such as 0x1, but its bad test design. Rather than that, I'd like to introduce
HasConnection() method and override it to return true.

In fact, most of those components are not accessing channel()'s methods
directry. They're just checking channel() is null or not, and to issue IPCs,
they are calling Send method. So, it's OK to hide channel pointer from users, I
think.

Original review: http://codereview.chromium.org/147077
Patch by tyoshino@google.com
------------------------------------------------------------------------
r19492 | sky@chromium.org | 2009-06-29 19:21:22 +0200 (Mon, 29 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/new_browser_window_widget.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Wires up the create browser window.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151026
------------------------------------------------------------------------
r19487 | pfeldman@chromium.org | 2009-06-29 15:26:51 +0200 (Mon, 29 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Replace DeleteSoon with PostTask(DeleteTask) in browser_window_gtk for browser to be closed while in ui tests.

DevToolsSanityTests are running various scenarios including the ones that are waiting for browser to be closed. Tests are closing all the tabs in the browser and are running nested message loop until the BROWSER_CLOSE message arrives.

The browser close logic on Linux was using DeleteSoon on the window object, but DeleteSoon was never executed since the task was non-nestable. This change simply posts DeleteTask instead of DeleteSoon and hence browser close logic is working fine on a nested loop.

Review URL: http://codereview.chromium.org/151020
------------------------------------------------------------------------
r19485 | ukai@chromium.org | 2009-06-29 12:39:51 +0200 (Mon, 29 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Fix SSL icon padding in Location Bar in Gtk.

When no ssl icon/ev text shown
 show 4px|location_entry|4px only

When ssl icon/no ev text
 show 4px|location_entry|4px + 2px|ssl_icon|8px

When ssl icon and ev text shown
 show 4px|location_entry|4px + 2px|ssl_icon|8px + |ev_text|4px

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151017
------------------------------------------------------------------------
r19482 | hbono@chromium.org | 2009-06-29 09:01:15 +0200 (Mon, 29 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc

A quick fix for Issue 13432.

This is caused by my bonehead mistake that I forgot filtering out U_STRING_NOT_TERMINATED_WARNING while checking the return value in SpellCheckWordIterator::Normalize() in my change r10087.
I have added code that checks if the result value is U_STRING_NOT_TERMINATED_WARNING and added a couple of test cases which verify this issue.

BUG=13432 "Any word of 13 or 14 characters is not spellcheck"
TEST=run unit_test.exe.
Review URL: http://codereview.chromium.org/146074
------------------------------------------------------------------------
r19481 | brettw@chromium.org | 2009-06-29 05:56:51 +0200 (Mon, 29 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   A /trunk/src/chrome/browser/renderer_host/render_view_host_manager.cc (from /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc:19396)
   A /trunk/src/chrome/browser/renderer_host/render_view_host_manager.h (from /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h:19396)
   A /trunk/src/chrome/browser/renderer_host/render_view_host_manager_unittest.cc (from /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc:19396)
   A /trunk/src/chrome/browser/renderer_host/site_instance.cc (from /trunk/src/chrome/browser/tab_contents/site_instance.cc:19416)
   A /trunk/src/chrome/browser/renderer_host/site_instance.h (from /trunk/src/chrome/browser/tab_contents/site_instance.h:19396)
   A /trunk/src/chrome/browser/renderer_host/site_instance_unittest.cc (from /trunk/src/chrome/browser/tab_contents/site_instance_unittest.cc:19396)
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   D /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   D /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   D /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   D /trunk/src/chrome/browser/tab_contents/site_instance.cc
   D /trunk/src/chrome/browser/tab_contents/site_instance.h
   D /trunk/src/chrome/browser/tab_contents/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp

Move render_view_host_manager* and site_instance* from tab_contents to renderer_host.
Review URL: http://codereview.chromium.org/150011
------------------------------------------------------------------------
r19479 | sehr@google.com | 2009-06-29 02:30:51 +0200 (Mon, 29 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/installer/installer.gyp
   A /trunk/src/chrome/worker/nativewebworker_impl.cc
   A /trunk/src/chrome/worker/nativewebworker_impl.h
   A /trunk/src/chrome/worker/nativewebworker_stub.cc
   A /trunk/src/chrome/worker/nativewebworker_stub.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/third_party/tcmalloc/tcmalloc.gyp

Added stub native web worker support, including build support in preparation
for integrating the native client build.

------------------------------------------------------------------------
r19467 | arv@google.com | 2009-06-27 19:48:01 +0200 (Sat, 27 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Fix the forgotten renames of recommendations to tips.

BUG=15491

TEST=Open the options menu and there should be no "null" in the UI

Review URL: http://codereview.chromium.org/147249
------------------------------------------------------------------------
r19465 | davemoore@chromium.org | 2009-06-27 18:27:25 +0200 (Sat, 27 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.cc
   M /trunk/src/chrome/renderer/navigation_state.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Fix for reverted cl http://codereview.chromium.org/147123

A recent change broke the load times. It also revealed some deficiencies.
This adds a new time marker for when a load is committed, which is
a more interesting value than the start of the load (which we still keep).
Also, the first layout time wasn't an interesting time to keep, instead
we keep the time of the first paint.
The histograms were modified to use the new values when appropriate.

Review URL: http://codereview.chromium.org/149099
------------------------------------------------------------------------
r19464 | jar@chromium.org | 2009-06-27 16:35:44 +0200 (Sat, 27 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc

Refactor DNS A/B experient, and add test of congestion time limits

I added another option in the DNS experiment: user 2 seconds or 500ms
for the congestion limit (that causes pre-resolutions to be discarded
from the queue.

The code in browser_main.cc was getting toooo large, so I pulled all
the experiment code into dns_global.cc.

BUG=15479

r=eroman
Review URL: http://codereview.chromium.org/147215
------------------------------------------------------------------------
r19463 | ericroman@google.com | 2009-06-27 10:29:50 +0200 (Sat, 27 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h

Ensure that even if the HostResolver outlives the IO thread, its jobs will not try to complete on the IO thread.

This is an experiment for http://crbug.com/15513

BUG=15513
TBR=willchan

Review URL: http://codereview.chromium.org/150001
------------------------------------------------------------------------
r19461 | ben@chromium.org | 2009-06-27 08:23:47 +0200 (Sat, 27 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h

Need to temporarily flip this back to gfx::NativeView since the other platforms don't like it as window. Will fix later.

TBR=sky
BUG=none
TEST=none
------------------------------------------------------------------------
r19460 | ben@chromium.org | 2009-06-27 08:17:17 +0200 (Sat, 27 Jun 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc

fix build bustage by using ALLOW_THIS_IN_INITIALIZER_LIST
------------------------------------------------------------------------
r19459 | ben@chromium.org | 2009-06-27 08:08:32 +0200 (Sat, 27 Jun 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/views/bookmark_context_menu.h

gcl error, this file belonged in last changeset
------------------------------------------------------------------------
r19458 | ben@chromium.org | 2009-06-27 08:07:55 +0200 (Sat, 27 Jun 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc (from /trunk/src/chrome/browser/views/bookmark_context_menu.cc:19224)
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.h (from /trunk/src/chrome/browser/views/bookmark_context_menu.h:19224)
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   R /trunk/src/chrome/browser/views/bookmark_context_menu.cc (from /trunk/src/chrome/browser/views/bookmark_context_menu_views.cc:19224)
   D /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   D /trunk/src/chrome/browser/views/bookmark_context_menu_views.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/chrome.gyp

First part of bookmark context menu reorg.

BookmarkContextMenu controller (XP state bits) go back into browser/bookmarks. views::MenuItemView infrastructure lives in browser/views/bookmark_context_menu.

BUG=none
TEST=bookmark context menus on bookmark bar, bookmark manager, bookmark folder menus.

Review URL: http://codereview.chromium.org/149055
------------------------------------------------------------------------
r19456 | jcampan@chromium.org | 2009-06-27 07:11:41 +0200 (Sat, 27 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   A /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.cc
   A /trunk/src/chrome/browser/ssl/ssl_client_auth_handler.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

A first implementation of the SSL client auth UI.This uses the Windows API that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert.
Review URL: http://codereview.chromium.org/147233
------------------------------------------------------------------------
r19454 | ericroman@google.com | 2009-06-27 05:41:47 +0200 (Sat, 27 Jun 2009) | 30 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Reverting 19447.

This was causing interactive ui tests to fail with a crash:

 	kernel32.dll!_InterlockedDecrement@4() 	
>	interactive_ui_tests.exe!sk_atomic_dec()  Line 40	C++
 	interactive_ui_tests.exe!SkBitmap::MipMap::unref()  Line 76	C++
 	interactive_ui_tests.exe!SkBitmap::freeMipMap()  Line 367	C++
 	interactive_ui_tests.exe!SkBitmap::freePixels()  Line 346	C++
 	interactive_ui_tests.exe!SkBitmap::~SkBitmap()  Line 100	C++
 	interactive_ui_tests.exe!SkBitmap::`scalar deleting destructor'() 	C++
 	interactive_ui_tests.exe!BrowserThemeProvider::FreeImages()  Line 744	C++
 	interactive_ui_tests.exe!BrowserThemeProvider::~BrowserThemeProvider()  Line 141	C++
 	interactive_ui_tests.exe!BrowserThemeProvider::`scalar deleting destructor'() 	C++
 	interactive_ui_tests.exe!base::RefCounted<BrowserThemeProvider>::Release()  Line 80	C++
 	interactive_ui_tests.exe!scoped_refptr<BrowserThemeProvider>::operator=()  Line 209	C++
 	interactive_ui_tests.exe!ProfileImpl::~ProfileImpl()  Line 584	C++
 	interactive_ui_tests.exe!ProfileImpl::`scalar deleting destructor'() 	C++
 	interactive_ui_tests.exe!ProfileManager::~ProfileManager()  Line 57	C++
 	interactive_ui_tests.exe!ProfileManager::`scalar deleting destructor'() 	C++
 	interactive_ui_tests.exe!scoped_ptr<ProfileManager>::reset()  Line 81	C++
 	interactive_ui_tests.exe!BrowserProcessImpl::~BrowserProcessImpl()  Line 164	C++
 	interactive_ui_tests.exe!BrowserProcessImpl::`scalar deleting destructor'() 	C++
 	interactive_ui_tests.exe!browser_shutdown::Shutdown()  Line 135	C++
 	interactive_ui_tests.exe!BrowserMain()  Line 826	C++
 	interactive_ui_tests.exe!InProcessBrowserTest::SetUp()  Line 129	C++
 	interactive_ui_tests.exe!testing::Test::Run()  Line 2021	C++
 	interactive_ui_tests.exe!testing::internal::TestInfoImpl::Run()  Line 2291	C++
 	interactive_ui_tests.exe!testing::internal::TestInfoImpl::RunTest()  Line 656	C++
Review URL: http://codereview.chromium.org/147259
------------------------------------------------------------------------
r19451 | ericroman@google.com | 2009-06-27 03:50:14 +0200 (Sat, 27 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/ftp/ftp_network_session.h
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Make net::HostResolver refcounted.

This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer.

BUG=http://crbug.com/14664
TEST=existing unit tests.

Review URL: http://codereview.chromium.org/149053
------------------------------------------------------------------------
r19449 | mattm@chromium.org | 2009-06-27 03:44:33 +0200 (Sat, 27 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h

Finish the gtk search engine manager.

BUG=13326
TEST=Open options, click search engines manage button, try adding, removing, making default, etc.

Review URL: http://codereview.chromium.org/147243
------------------------------------------------------------------------
r19448 | evan@chromium.org | 2009-06-27 03:43:51 +0200 (Sat, 27 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/common/ipc_message.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h

mac/linux: rework plugin channel file descriptor creation

This CL fixes a bug where the same renderer could open several channels to the same plugin process, which end up having the same name. This CL makes it that there is only one channel for each (plugin, renderer) pair, just like on Windows.
The socketpair is created in the plugin process (which can ensure that only one channel per renderer gets created), and sends the renderer side through the browser process.

Note: this should essentially be a noop on Windows.

Review URL: http://codereview.chromium.org/149062
Patch from Antoine Labour <piman@google.com>.
------------------------------------------------------------------------
r19447 | tc@google.com | 2009-06-27 03:43:25 +0200 (Sat, 27 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

We're leaking almost all the theme bitmaps.  Properly delete images
when we create them.

We have to copy images that come from ResourceBundle because
ResourceBundle owns them.

Valgrind still sees more leaks in this area, but I need to investigate
some more and these are the biggies.

Review URL: http://codereview.chromium.org/149112

------------------------------------------------------------------------
r19446 | mattm@chromium.org | 2009-06-27 03:42:39 +0200 (Sat, 27 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc

Add more privacy prefs

BUG=11507

Review URL: http://codereview.chromium.org/149118
------------------------------------------------------------------------
r19445 | estade@chromium.org | 2009-06-27 03:41:07 +0200 (Sat, 27 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

Linux web drag first cut.

You can only drag out of the web contents, and can only drag text.

http://crbug.com/15429
TEST=try dragging some text into gedit

Review URL: http://codereview.chromium.org/147245
------------------------------------------------------------------------
r19444 | rvargas@google.com | 2009-06-27 02:35:56 +0200 (Sat, 27 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   A /trunk/src/chrome/browser/resources/new_new_tab.css (from /trunk/src/chrome/browser/resources/new_new_tab.css:19437)
   A /trunk/src/chrome/browser/resources/new_new_tab.html (from /trunk/src/chrome/browser/resources/new_new_tab.html:19437)
   A /trunk/src/chrome/browser/resources/new_new_tab.js (from /trunk/src/chrome/browser/resources/new_new_tab.js:19437)
   D /trunk/src/chrome/browser/resources/new_tab.css
   M /trunk/src/chrome/browser/resources/new_tab.html
   D /trunk/src/chrome/browser/resources/new_tab.js
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

revert cl 19438

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149116
------------------------------------------------------------------------
r19442 | jcampan@chromium.org | 2009-06-27 01:22:43 +0200 (Sat, 27 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Simple clean-up of the ssl_manager.h includes.

R=wtc
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/147234
------------------------------------------------------------------------
r19439 | rvargas@google.com | 2009-06-27 01:06:31 +0200 (Sat, 27 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/disk_cache/backend_impl.cc

Add a command line switch to allow setting the max size
of the disk cache.

This switch is intended for troubleshooting, not to
add another supported configuration.

BUG=15117
TEST=none

Review URL: http://codereview.chromium.org/146136
------------------------------------------------------------------------
r19438 | arv@google.com | 2009-06-27 01:03:48 +0200 (Sat, 27 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   D /trunk/src/chrome/browser/resources/new_new_tab.css
   D /trunk/src/chrome/browser/resources/new_new_tab.html
   D /trunk/src/chrome/browser/resources/new_new_tab.js
   A /trunk/src/chrome/browser/resources/new_tab.css (from /trunk/src/chrome/browser/resources/new_new_tab.css:19334)
   R /trunk/src/chrome/browser/resources/new_tab.html (from /trunk/src/chrome/browser/resources/new_new_tab.html:19334)
   A /trunk/src/chrome/browser/resources/new_tab.js (from /trunk/src/chrome/browser/resources/new_new_tab.js:19334)
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Make the new new tab page the default new tab page.

I changed the command line switch "--new-new-tab-page" to
"-new-tab-page=<path>" so we can continue to iterate.

BUG=13362

TEST=The new new tab page should be on by default.

Review URL: http://codereview.chromium.org/147226
------------------------------------------------------------------------
r19435 | meelapshah@chromium.org | 2009-06-27 00:56:46 +0200 (Sat, 27 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

WriteThumbnailToDisk runs on a bg thread so it cannot access the cache_ directly.
Instead, pass the data to be written to disk so no cache_ lookups are necessary.

Review URL: http://codereview.chromium.org/149105
------------------------------------------------------------------------
r19432 | ericroman@google.com | 2009-06-27 00:33:25 +0200 (Sat, 27 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/ftp/ftp_network_session.h
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Reverting 19425.
Review URL: http://codereview.chromium.org/147242
------------------------------------------------------------------------
r19428 | munjal@chromium.org | 2009-06-27 00:29:20 +0200 (Sat, 27 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/app/tree_node_model.h
   M /trunk/src/chrome/browser/bookmarks/base_bookmark_model_observer.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_manager.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/gtk/bookmark_context_menu.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/testing_profile.cc

Make bookmark model public interface use const BookmarkNode* instead of
BookmarkNode*. This helps in making the BookmarkNode class setters public
also without worrying about someone inadvertently changing BookmarkNode
properties directly for bookmark model bookmarks.

Change all the call sites to reflect this.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/146116
------------------------------------------------------------------------
r19426 | tc@google.com | 2009-06-27 00:07:40 +0200 (Sat, 27 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Fix a crash that happens when changing themes.

We were holding references to images that got deleted when themes
changed.  These all happen to be in a NineBox, so have NineBox
reload images when the theme change notification is sent.

Also fix an expose bug that wasn't noticeable in the original
theme.  We need to always place the image at 0, 0 for the
background and paint it all the way across the window (should
get clipped by cairo).

BUG=15366

Review URL: http://codereview.chromium.org/149102

------------------------------------------------------------------------
r19425 | ericroman@google.com | 2009-06-27 00:06:52 +0200 (Sat, 27 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/ftp/ftp_network_session.h
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/socket/client_socket_pool_base.h
   M /trunk/src/net/socket/ssl_client_socket_unittest.cc
   M /trunk/src/net/socket/ssl_test_util.cc
   M /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/socket/tcp_client_socket_unittest.cc
   M /trunk/src/net/socket/tcp_pinger_unittest.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Make net::HostResolver refcounted.

This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer.

BUG=http://crbug.com/14664
TEST=existing unit tests.

Review URL: http://codereview.chromium.org/149053
------------------------------------------------------------------------
r19421 | mattm@chromium.org | 2009-06-26 23:25:18 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc (from /trunk/src/chrome/browser/views/keyword_editor_view.cc:19296)
   A /trunk/src/chrome/browser/search_engines/keyword_editor_controller.h (from /trunk/src/chrome/browser/views/keyword_editor_view.h:19296)
   A /trunk/src/chrome/browser/search_engines/keyword_editor_controller_unittest.cc (from /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc:19296)
   A /trunk/src/chrome/browser/search_engines/template_url_table_model.cc (from /trunk/src/chrome/browser/views/keyword_editor_view.cc:19296)
   A /trunk/src/chrome/browser/search_engines/template_url_table_model.h (from /trunk/src/chrome/browser/views/keyword_editor_view.h:19296)
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   D /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Refactor the win KeywordEditorView for cross platform friendliness.

The TableModel is moved to search_engines/template_url_table_model.*

The shared logic, and ownership of the url_model_ and table_model_, is moved to search_engines/keyword_editor_controller.*

BUG=13326
Review URL: http://codereview.chromium.org/146138
------------------------------------------------------------------------
r19416 | brettw@chromium.org | 2009-06-26 23:00:43 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Do some minor cleanup I noticed in SiteInstance. Before, we would parse and
canonicalize the three about URLs every time this function was called (I think
for every page transition). This is unnecessary, so I just added a string
comparison.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/149084
------------------------------------------------------------------------
r19415 | mirandac@chromium.org | 2009-06-26 22:55:01 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h

Validates links which are to be passed on to the NTP by ensuring that they start with "http://" or "https://".

BUG= http://crbug.com/15457
TEST= Change cached tip link in preferences file to be invalid.  Note that this tip will not be included on the NTP.

Review URL: http://codereview.chromium.org/149083
------------------------------------------------------------------------
r19414 | tc@google.com | 2009-06-26 22:53:25 +0200 (Fri, 26 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/common/notification_type.h

Use regular notifications for theme changes.

This should have no impact on the current behavior.

On linux, we'll want to get these notifications in a few places other than
just the root browser windows so having it as a regular notification
makes it easier for us to just listen for the event.

Review URL: http://codereview.chromium.org/149032

------------------------------------------------------------------------
r19413 | jorlow@chromium.org | 2009-06-26 22:46:06 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/in_process_webkit
   A /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.cc
   A /trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h
   A /trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host_unittest.cc
   A /trunk/src/chrome/browser/in_process_webkit/webkit_context.cc
   A /trunk/src/chrome/browser/in_process_webkit/webkit_context.h
   A /trunk/src/chrome/browser/in_process_webkit/webkit_context_unittest.cc
   A /trunk/src/chrome/browser/in_process_webkit/webkit_thread.cc
   A /trunk/src/chrome/browser/in_process_webkit/webkit_thread.h
   A /trunk/src/chrome/browser/in_process_webkit/webkit_thread_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Create a webkit thread for use within the browser process.  This patch also includes some (soon to be fleshed out in another CL) code to demonstrate how it'll be used in DOM Storage.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/139003
------------------------------------------------------------------------
r19412 | mattm@chromium.org | 2009-06-26 22:40:05 +0200 (Fri, 26 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.h
   M /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc

Add stubs for the rest of the gtk advanced options sections. Hook up the reset prefs function.

BUG=11507

Review URL: http://codereview.chromium.org/149097
------------------------------------------------------------------------
r19410 | tc@google.com | 2009-06-26 22:27:29 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host_unittest.cc

Fix 2 memory leaks in UtilityProcessHostTest.ExtensionUnpacker.

Valgrind says this test is now clean, let's hope purify agrees.

BUG=15456

Review URL: http://codereview.chromium.org/149092

------------------------------------------------------------------------
r19405 | willchan@chromium.org | 2009-06-26 22:02:12 +0200 (Fri, 26 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

s/OS_MAC/OS_MACOSX/

Review URL: http://codereview.chromium.org/149087
------------------------------------------------------------------------
r19403 | sky@chromium.org | 2009-06-26 21:53:56 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Makes tab overview show the arrow at the right location.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/147218
------------------------------------------------------------------------
r19402 | estade@chromium.org | 2009-06-26 21:53:35 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

GTK bookmark manager: workaround for multi row dragging.

http://crbug.com/15240
TEST=click around in the bookmark manager a lot, everything works as you'd expect. In particular, if you hold ctrl and select a few rows, then release control, then click on those rows and try to drag them, they will drag.

Review URL: http://codereview.chromium.org/147188
------------------------------------------------------------------------
r19401 | estade@chromium.org | 2009-06-26 21:53:21 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc

Fix download shelf z ordering during close.

Pretty much the same as what we do in the find bar. I think the flickering thing in the bug desc. was another result of <http://crbug.com/14786>, as it was only present in 3.0.190.2 and not ToT, and toggling the bookmark bar fixed it.

http://crbug.com/15427
TEST=see bug

Review URL: http://codereview.chromium.org/149054
------------------------------------------------------------------------
r19400 | erikkay@google.com | 2009-06-26 21:50:52 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Enable extension protocols on all platforms.  This should enable background pages and tab-hosted pages from extensions.

BUG=none
TEST=load an extension that has a background page and verify that the process is created (see chrome://extensions)

Review URL: http://codereview.chromium.org/149091
------------------------------------------------------------------------
r19399 | jhawkins@chromium.org | 2009-06-26 21:49:40 +0200 (Fri, 26 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Fix two issues with Drag-N-Drop in gtk tabstrip:
* Handle drag-leave and drag-failed by hiding or destroying the drag arrow respectively.
* Hide the drop arrow instead of destroying the drop info when we set the drop index to -1.  This compensates for the fact that gtk emits the drag-leave signal before the drag-data-received signal.

BUG=none
TEST=Drag a URL in and out of the tabstrip.  The drop arrow should disappear when the dragged mouse leaves the tabstrip or when the drag fails.
Review URL: http://codereview.chromium.org/149093
------------------------------------------------------------------------
r19397 | maruel@chromium.org | 2009-06-26 21:29:25 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/app/resources/frame_default.png
   M /trunk/src/app/resources/frame_default_inactive.png
   M /trunk/src/app/resources/menu_droparrow.png
   M /trunk/src/chrome/app/theme/back_mask.png
   M /trunk/src/chrome/app/theme/button_mask.png
   M /trunk/src/chrome/app/theme/chromium/chromium_icon_32.png
   M /trunk/src/chrome/app/theme/chromium/product_logo_256.png
   M /trunk/src/chrome/app/theme/chromium/product_logo_32.png
   M /trunk/src/chrome/app/theme/chromium/product_logo_48.png
   M /trunk/src/chrome/app/theme/find_dialog_left.png
   M /trunk/src/chrome/app/theme/find_dialog_middle.png
   M /trunk/src/chrome/app/theme/find_dialog_right.png
   M /trunk/src/chrome/app/theme/forward_mask.png
   M /trunk/src/chrome/app/theme/go_mask.png
   M /trunk/src/chrome/app/theme/grow_box.png
   M /trunk/src/chrome/app/theme/notused.png
   M /trunk/src/chrome/app/theme/ntp_background.png
   M /trunk/src/chrome/app/theme/ntp_close.png
   M /trunk/src/chrome/app/theme/ntp_close_h.png
   M /trunk/src/chrome/app/theme/ntp_close_p.png
   M /trunk/src/chrome/app/theme/ntp_list_off.png
   M /trunk/src/chrome/app/theme/ntp_list_off_h.png
   M /trunk/src/chrome/app/theme/ntp_list_off_p.png
   M /trunk/src/chrome/app/theme/ntp_list_on.png
   M /trunk/src/chrome/app/theme/ntp_list_on_h.png
   M /trunk/src/chrome/app/theme/ntp_list_on_p.png
   M /trunk/src/chrome/app/theme/ntp_option.png
   M /trunk/src/chrome/app/theme/ntp_option_h.png
   M /trunk/src/chrome/app/theme/ntp_option_p.png
   M /trunk/src/chrome/app/theme/ntp_pin_off.png
   M /trunk/src/chrome/app/theme/ntp_pin_off_h.png
   M /trunk/src/chrome/app/theme/ntp_pin_off_p.png
   M /trunk/src/chrome/app/theme/ntp_pin_on.png
   M /trunk/src/chrome/app/theme/ntp_pin_on_h.png
   M /trunk/src/chrome/app/theme/ntp_pin_on_p.png
   M /trunk/src/chrome/app/theme/ntp_thumb_off.png
   M /trunk/src/chrome/app/theme/ntp_thumb_off_h.png
   M /trunk/src/chrome/app/theme/ntp_thumb_off_p.png
   M /trunk/src/chrome/app/theme/ntp_thumb_on.png
   M /trunk/src/chrome/app/theme/ntp_thumb_on_h.png
   M /trunk/src/chrome/app/theme/ntp_thumb_on_p.png
   M /trunk/src/chrome/app/theme/ntp_x_icon.png
   M /trunk/src/chrome/app/theme/ntp_x_icon_active.png
   M /trunk/src/chrome/app/theme/ntp_x_icon_hover.png
   M /trunk/src/chrome/app/theme/ntp_x_icon_small.png
   M /trunk/src/chrome/app/theme/o2_globe.png
   M /trunk/src/chrome/app/theme/o2_globe_selected.png
   M /trunk/src/chrome/app/theme/o2_globe_selected_dark.png
   M /trunk/src/chrome/app/theme/o2_history.png
   M /trunk/src/chrome/app/theme/o2_history_selected.png
   M /trunk/src/chrome/app/theme/o2_history_selected_dark.png
   M /trunk/src/chrome/app/theme/o2_more.png
   M /trunk/src/chrome/app/theme/o2_more_selected.png
   M /trunk/src/chrome/app/theme/o2_more_selected_dark.png
   M /trunk/src/chrome/app/theme/o2_search.png
   M /trunk/src/chrome/app/theme/o2_search_selected.png
   M /trunk/src/chrome/app/theme/o2_search_selected_dark.png
   M /trunk/src/chrome/app/theme/o2_star.png
   M /trunk/src/chrome/app/theme/o2_star_selected.png
   M /trunk/src/chrome/app/theme/o2_star_selected_dark.png
   M /trunk/src/chrome/app/theme/omnibox_b.png
   M /trunk/src/chrome/app/theme/omnibox_bl.png
   M /trunk/src/chrome/app/theme/omnibox_br.png
   M /trunk/src/chrome/app/theme/omnibox_l.png
   M /trunk/src/chrome/app/theme/omnibox_r.png
   M /trunk/src/chrome/app/theme/omnibox_t.png
   M /trunk/src/chrome/app/theme/omnibox_tl.png
   M /trunk/src/chrome/app/theme/omnibox_tr.png
   M /trunk/src/chrome/app/theme/star_mask.png
   M /trunk/src/chrome/app/theme/tab_alpha_left.png
   M /trunk/src/chrome/app/theme/tab_alpha_right.png
   M /trunk/src/chrome/app/theme/theme_frame_default.png
   M /trunk/src/chrome/app/theme/theme_frame_default_inactive.png
   M /trunk/src/chrome/app/theme/theme_frame_default_incognito.png
   M /trunk/src/chrome/app/theme/theme_frame_default_incognito_inactive.png
   M /trunk/src/chrome/app/theme/theme_tab_background.png
   M /trunk/src/chrome/app/theme/theme_tab_background_glass.png
   M /trunk/src/chrome/app/theme/theme_tab_background_incognito.png
   M /trunk/src/chrome/app/theme/theme_toolbar_default.png
   M /trunk/src/chrome/browser/resources/help.gif
   M /trunk/src/chrome/test/data/animate1.gif
   M /trunk/src/chrome/test/data/animate2.gif
   M /trunk/src/chrome/test/data/animate3.gif
   M /trunk/src/chrome/test/data/download-test3.gif
   M /trunk/src/chrome/test/data/extensions/samples/gmail/gmail.png
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/icon.png
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/icon_disabled.png
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/icon_subscribed.png
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16.png
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-64x64.png
   M /trunk/src/chrome/test/data/google/logo.gif
   M /trunk/src/chrome/test/data/google/x2.gif
   M /trunk/src/chrome/test/data/interstitial_page/logo.gif
   M /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp0.gif
   M /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp1.gif
   M /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp2.gif
   M /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp3.gif
   M /trunk/src/chrome/test/data/interstitial_page/x2.gif
   M /trunk/src/chrome/test/data/printing/cleardot.gif
   M /trunk/src/chrome/test/data/ssl/google_files/logo.gif
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/back.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/checker.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/clearConsoleButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/closeButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/consoleButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/database.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/databaseTable.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/databasesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/debuggerContinue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/debuggerPause.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/debuggerStepInto.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/debuggerStepOut.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/debuggerStepOver.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallDown.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallDownBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallDownWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallRight.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallRightBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallRightDown.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallRightDownBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallRightDownWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/disclosureTriangleSmallRightWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/dockButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/elementsIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/enableButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/errorIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/errorMediumIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/excludeButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/focusButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/forward.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/glossyHeader.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/glossyHeaderPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/glossyHeaderSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/glossyHeaderSelectedPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/goArrow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/graphLabelCalloutLeft.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/graphLabelCalloutRight.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/largerResourcesButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/nodeSearchButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/paneBottomGrow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/paneBottomGrowActive.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/paneGrowHandleLine.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/pauseOnExceptionButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/percentButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/profileGroupIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/profileIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/profileSmallIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/profilesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/profilesSilhouette.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/recordButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/reloadButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourceCSSIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourceDocumentIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourceDocumentIconSmall.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourceJSIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourcePlainIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourcePlainIconSmall.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourcesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourcesSizeGraphIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/resourcesTimeGraphIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/scriptsIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/scriptsSilhouette.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/searchSmallBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/searchSmallBrightBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/searchSmallGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/searchSmallWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/segment.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/segmentEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/segmentHover.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/segmentHoverEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/segmentSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/segmentSelectedEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/splitviewDimple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/splitviewDividerBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/statusbarBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/statusbarBottomBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/statusbarButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/statusbarMenuButton.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/statusbarMenuButtonSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/statusbarResizerHorizontal.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/statusbarResizerVertical.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelineHollowPillBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelineHollowPillGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelineHollowPillGreen.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelineHollowPillOrange.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelineHollowPillPurple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelineHollowPillRed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelineHollowPillYellow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelinePillBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelinePillGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelinePillGreen.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelinePillOrange.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelinePillPurple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelinePillRed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/timelinePillYellow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/tipBalloon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/tipBalloonBottom.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/tipIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/tipIconPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/toolbarItemSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/treeDownTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/treeDownTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/treeRightTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/treeRightTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/treeUpTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/treeUpTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/userInputIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/userInputPreviousIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/warningIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/warningMediumIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_linux/resources/inspector/Images/warningsErrors.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/aliasCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/cellCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/contextMenuCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/copyCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/crossHairCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/eastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/eastWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/grow_box.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/helpCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/back.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/checker.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/clearConsoleButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/closeButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/consoleButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/database.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/databaseTable.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/databasesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/debuggerContinue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/debuggerPause.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/debuggerStepInto.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/debuggerStepOut.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/debuggerStepOver.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallDown.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallDownBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallDownWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRight.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightDown.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightDownBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightDownWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/dockButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/elementsIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/enableButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/errorIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/errorMediumIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/excludeButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/focusButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/forward.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/glossyHeader.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/glossyHeaderPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/glossyHeaderSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/glossyHeaderSelectedPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/goArrow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/graphLabelCalloutLeft.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/graphLabelCalloutRight.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/largerResourcesButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/nodeSearchButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/paneBottomGrow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/paneBottomGrowActive.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/paneGrowHandleLine.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/pauseOnExceptionButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/percentButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/profileGroupIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/profileIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/profileSmallIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/profilesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/profilesSilhouette.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/radioDot.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/recordButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/reloadButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourceCSSIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourceDocumentIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourceDocumentIconSmall.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourceJSIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourcePlainIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourcePlainIconSmall.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourcesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourcesSizeGraphIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/resourcesTimeGraphIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/scriptsIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/scriptsSilhouette.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/searchSmallBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/searchSmallBrightBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/searchSmallGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/searchSmallWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/segment.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/segmentEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/segmentHover.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/segmentHoverEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/segmentSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/segmentSelectedEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/splitviewDimple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/splitviewDividerBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/statusbarBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/statusbarBottomBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/statusbarButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/statusbarMenuButton.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/statusbarMenuButtonSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/statusbarResizerHorizontal.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/statusbarResizerVertical.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelineHollowPillBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelineHollowPillGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelineHollowPillGreen.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelineHollowPillOrange.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelineHollowPillPurple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelineHollowPillRed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelineHollowPillYellow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelinePillBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelinePillGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelinePillGreen.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelinePillOrange.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelinePillPurple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelinePillRed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/timelinePillYellow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/tipBalloon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/tipBalloonBottom.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/tipIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/tipIconPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/toolbarItemSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/treeDownTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/treeDownTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/treeRightTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/treeRightTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/treeUpTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/treeUpTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/userInputIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/userInputPreviousIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/warningIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/warningMediumIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/inspector/Images/warningsErrors.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/linkCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/missingImage.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/moveCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/noDropCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/noneCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/northEastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/northEastSouthWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/northResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/northSouthResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/northWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/northWestSouthEastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/notAllowedCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/o2_globe.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/o2_history.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/o2_more.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/o2_search.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/o2_star.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/progressCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/sadtab.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/southEastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/southResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/southWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/throbber.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/throbber_waiting.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/verticalTextCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/waitCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/westResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/zoomInCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Chromium.app/Contents/Resources/zoomOutCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/aliasCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/cellCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/contextMenuCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/copyCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/crossHairCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/eastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/eastWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/grow_box.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/helpCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/back.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/checker.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/clearConsoleButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/closeButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/consoleButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/database.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/databaseTable.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/databasesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/debuggerContinue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/debuggerPause.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/debuggerStepInto.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/debuggerStepOut.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/debuggerStepOver.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallDown.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallDownBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallDownWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRight.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightDown.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightDownBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightDownWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/disclosureTriangleSmallRightWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/dockButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/elementsIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/enableButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/errorIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/errorMediumIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/excludeButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/focusButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/forward.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/glossyHeader.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/glossyHeaderPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/glossyHeaderSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/glossyHeaderSelectedPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/goArrow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/graphLabelCalloutLeft.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/graphLabelCalloutRight.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/largerResourcesButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/nodeSearchButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/paneBottomGrow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/paneBottomGrowActive.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/paneGrowHandleLine.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/pauseOnExceptionButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/percentButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/profileGroupIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/profileIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/profileSmallIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/profilesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/profilesSilhouette.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/radioDot.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/recordButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/reloadButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourceCSSIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourceDocumentIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourceDocumentIconSmall.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourceJSIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourcePlainIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourcePlainIconSmall.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourcesIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourcesSizeGraphIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/resourcesTimeGraphIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/scriptsIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/scriptsSilhouette.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/searchSmallBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/searchSmallBrightBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/searchSmallGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/searchSmallWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/segment.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/segmentEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/segmentHover.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/segmentHoverEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/segmentSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/segmentSelectedEnd.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/splitviewDimple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/splitviewDividerBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/statusbarBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/statusbarBottomBackground.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/statusbarButtons.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/statusbarMenuButton.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/statusbarMenuButtonSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/statusbarResizerHorizontal.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/statusbarResizerVertical.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelineHollowPillBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelineHollowPillGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelineHollowPillGreen.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelineHollowPillOrange.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelineHollowPillPurple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelineHollowPillRed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelineHollowPillYellow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelinePillBlue.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelinePillGray.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelinePillGreen.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelinePillOrange.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelinePillPurple.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelinePillRed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/timelinePillYellow.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/tipBalloon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/tipBalloonBottom.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/tipIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/tipIconPressed.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/toolbarItemSelected.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/treeDownTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/treeDownTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/treeRightTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/treeRightTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/treeUpTriangleBlack.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/treeUpTriangleWhite.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/userInputIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/userInputPreviousIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/warningIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/warningMediumIcon.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/inspector/Images/warningsErrors.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/linkCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/missingImage.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/moveCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/noDropCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/noneCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/northEastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/northEastSouthWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/northResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/northSouthResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/northWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/northWestSouthEastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/notAllowedCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/o2_globe.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/o2_history.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/o2_more.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/o2_search.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/o2_star.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/progressCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/sadtab.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/southEastResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/southResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/southWestResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/throbber.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/throbber_waiting.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/verticalTextCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/waitCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/westResizeCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/zoomInCursor.png
   M /trunk/src/chrome/tools/test/reference_build/chrome_mac/Google Chrome.app/Contents/Resources/zoomOutCursor.png
   M /trunk/src/media/player/toolbar.bmp
   M /trunk/src/o3d/samples/assets/android.png
   M /trunk/src/o3d/samples/assets/block.png
   M /trunk/src/o3d/samples/assets/brush.png
   M /trunk/src/o3d/samples/assets/egg.png
   M /trunk/src/o3d/samples/assets/fullscreen.png
   M /trunk/src/o3d/samples/assets/gauge.png
   M /trunk/src/o3d/samples/assets/gaugeback.png
   M /trunk/src/o3d/samples/assets/google-square.png
   M /trunk/src/o3d/samples/assets/iconback.png
   M /trunk/src/o3d/samples/assets/orange-flower.png
   M /trunk/src/o3d/samples/assets/particle-anim.png
   M /trunk/src/o3d/samples/assets/pillar.png
   M /trunk/src/o3d/samples/assets/purple-flower.png
   M /trunk/src/o3d/samples/assets/radar.png
   M /trunk/src/o3d/samples/assets/ripple.png
   M /trunk/src/o3d/samples/assets/shaving_cream.png
   M /trunk/src/o3d/samples/assets/square.png
   M /trunk/src/o3d/samples/beachdemo/assets/pe_mist.png
   M /trunk/src/o3d/samples/home-configurators/cb_images/toolselector.gif
   M /trunk/src/o3d/samples/home-configurators/cb_images/unbranded_bg.png
   M /trunk/src/o3d/samples/home-configurators/searsassets/sears_bg.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/bl.gif
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/br.gif
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/cleardot.gif
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/corner.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/db_tl.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/db_tr.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/google-small.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/lb_tl.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/lb_tr.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/sprites.gif
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/sprites08132008.png
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/tl.gif
   M /trunk/src/o3d/samples/interactive_sampler_assets/images/tr.gif
   M /trunk/src/o3d/samples/io/ui/covershadow.png
   M /trunk/src/o3d/samples/io/ui/logo.gif
   M /trunk/src/o3d/samples/io/ui/scrollwork.gif
   M /trunk/src/o3d/samples/pingpong/instructions.gif
   M /trunk/src/o3d/samples/pingpong/logo.gif
   M /trunk/src/o3d/samples/trends/assets/earth-large-with-ocean-mask.png
   M /trunk/src/o3d/samples/trends/assets/energy.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.0.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.1.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.10.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.11.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.12.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.13.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.14.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.15.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.16.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.17.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.18.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.19.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.2.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.20.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.21.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.22.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.23.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.24.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.25.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.26.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.27.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.28.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.29.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.3.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.4.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.5.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.6.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.7.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.8.png
   M /trunk/src/o3d/samples/waterdemo/assets/deepwater/deepwater.9.png
   M /trunk/src/o3d/samples/waterdemo/assets/horizon_ramp.png
   M /trunk/src/o3d/samples/waterdemo/assets/horizon_ramp_1.png
   M /trunk/src/o3d/samples/waterdemo/assets/noise.png
   M /trunk/src/o3d/samples/waterdemo/assets/reflectivity_map.png
   M /trunk/src/o3d/samples/waterdemo/assets/rock_reflection_new.png
   M /trunk/src/o3d/samples/waterdemo/assets/sky_compat.png
   M /trunk/src/o3d/samples/waterdemo/assets/sun_compat.png
   M /trunk/src/o3d/samples/waterdemo/assets/sun_ramp.png
   M /trunk/src/o3d/samples/waterdemo/assets/sun_ramp_1.png
   M /trunk/src/o3d/tests/basic_system_test/reference_frames/frame_capture0.png
   M /trunk/src/o3d/tests/basic_system_test/reference_frames/frame_capture1.png
   M /trunk/src/o3d/tests/basic_system_test/reference_frames/frame_capture2.png
   M /trunk/src/o3d/tests/basic_system_test/reference_frames/frame_capture3.png
   M /trunk/src/o3d/tests/basic_system_test/reference_frames/frame_capture4.png
   M /trunk/src/o3d/tests/bitmap_test/5kx5k.png
   M /trunk/src/o3d/tests/bitmap_test/gif-256x256-interlaced.gif
   M /trunk/src/o3d/tests/bitmap_test/gif-256x256.gif
   M /trunk/src/o3d/tests/bitmap_test/png-256x256-24bit-interlaced.png
   M /trunk/src/o3d/tests/bitmap_test/png-256x256-24bit.png
   M /trunk/src/o3d/tests/bitmap_test/png-256x256-32bit.png
   M /trunk/src/o3d/tests/bitmap_test/png-256x256-8bit-palette-alpha.png
   M /trunk/src/o3d/tests/bitmap_test/png-256x256-8bit-palette.png
   M /trunk/src/third_party/sqlite/art/2005osaward.gif
   M /trunk/src/third_party/sqlite/art/SQLite.gif
   M /trunk/src/third_party/sqlite/art/SQLite_big.gif
   M /trunk/src/third_party/sqlite/art/nocopy.gif
   M /trunk/src/third_party/sqlite/art/powered_by_sqlite.gif
   M /trunk/src/webkit/data/layout_tests/chrome/fast/forms/resources/logo.gif
   M /trunk/src/webkit/data/layout_tests/chrome/http/mime/resources/html_type_gif.gif
   M /trunk/src/webkit/data/layout_tests/chrome/http/mime/resources/smokey.gif
   M /trunk/src/webkit/data/layout_tests/chrome/http/mime/resources/type_gif.gif
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/compositing/generated-content-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/bgCompositeCopy-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/svg-as-background-2-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css/clip-zooming-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/css/nth-child-dynamic-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/dynamic/window-resize-scrollbars-test-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/dynamic/window-scrollbars-test-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-vertical-alignment-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-zoomed-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/select-empty-option-height-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/gradients/background-clipped-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/layers/inline-dirty-z-order-lists-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/scrollbars/listbox-scrollbar-combinations-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/scrollbars/overflow-scrollbar-combinations-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/group-opacity-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/js-update-gradient-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/chrome/fast/text/fake-italic-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/nth-child-dynamic-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dynamic/window-resize-scrollbars-test-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dynamic/window-scrollbars-test-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-vertical-alignment-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/background-clipped-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/inline-dirty-z-order-lists-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/media/viewport-media-query-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/media/video-layer-crash-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/chrome/fast/text/fake-italic-expected.png
   M /trunk/src/webkit/data/test_shell/frames/iframe1_files/foo1_data/vcss.gif
   M /trunk/src/webkit/data/test_shell/frames/iframe1_files/w3c_home.gif
   M /trunk/src/webkit/data/test_shell/frames/iframe1_files/wai.gif
   M /trunk/src/webkit/glue/resources/broken-image.gif
   M /trunk/src/webkit/glue/resources/linux-checkbox-off.png
   M /trunk/src/webkit/glue/resources/linux-checkbox-on.png
   M /trunk/src/webkit/glue/resources/linux-radio-off.png
   M /trunk/src/webkit/glue/resources/linux-radio-on.png
   M /trunk/src/webkit/glue/resources/pan_icon.png
   M /trunk/src/webkit/glue/resources/textarea_resize_corner.png
   M /trunk/src/webkit/tools/test_shell/resources/missingImage.gif
   M /trunk/src/webkit/tools/test_shell/resources/textAreaResizeCorner.png

Set images svn:mime-type.
png files to image/png, bmp files to image/bmp, gif files to image/gif

NO CODE CHANGE.

TEST=none
BUG=none

------------------------------------------------------------------------
r19395 | cira@chromium.org | 2009-06-26 20:56:08 +0200 (Fri, 26 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h

Change BrowserBubble so that clients can say if they expect canvas mirroring to happen or not.
ExtensionShelf doesn't need mirroring since View methods already provide most of the RTL functionality.

BUG=http://crbug.com/11880
TEST=Run chrome --lang=he and add 1+ extensions, and see if the handle is in proper position.

Review URL: http://codereview.chromium.org/149045
------------------------------------------------------------------------
r19390 | mattm@chromium.org | 2009-06-26 20:26:12 +0200 (Fri, 26 Jun 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/options_util.cc
   A /trunk/src/chrome/browser/options_util.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/chrome.gyp

move the ResetToDefault function for prefs to chrome/browser/options_util

BUG=11507

Review URL: http://codereview.chromium.org/147190
------------------------------------------------------------------------
r19389 | mattm@chromium.org | 2009-06-26 20:24:39 +0200 (Fri, 26 Jun 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/advanced_contents_gtk.h
   A /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/advanced_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Foundations for gtk advanced options page.

BUG=11507

Review URL: http://codereview.chromium.org/147187
------------------------------------------------------------------------
r19386 | finnur@chromium.org | 2009-06-26 20:21:18 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc

Fix crash 15371

We need to null check the return from GetActiveEntry.

BUG=15371
TEST=Watch the crash data from the field and make sure the crash is gone.

Review URL: http://codereview.chromium.org/147214
------------------------------------------------------------------------
r19385 | kuchhal@chromium.org | 2009-06-26 20:13:35 +0200 (Fri, 26 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc

fix windows build break.

Review URL: http://codereview.chromium.org/147222
------------------------------------------------------------------------
r19383 | mark@chromium.org | 2009-06-26 19:59:27 +0200 (Fri, 26 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Given the results of Rohit's investigation, I think that the times that we're
getting out of the pageload tests right now are highly suspect because we're
not actually getting the bits from each page to the screen.  As such, I'm
much less inclined to treat the "regression" in these tests as a problem.

BUG=15232
TEST=throbber changes between waiting (gray) and loading (blue) at appropriate
     times; animation still disabled
Review URL: http://codereview.chromium.org/147211
------------------------------------------------------------------------
r19381 | kuchhal@chromium.org | 2009-06-26 19:58:24 +0200 (Fri, 26 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   A /trunk/src/chrome/browser/importer/firefox_importer_utils_linux.cc
   A /trunk/src/chrome/browser/importer/firefox_importer_utils_mac.cc
   A /trunk/src/chrome/browser/importer/firefox_importer_utils_win.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   A /trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/chrome.gyp

Enable Firefox import on OS X. No UI yet.

Review URL: http://codereview.chromium.org/143001
------------------------------------------------------------------------
r19378 | nirnimesh@chromium.org | 2009-06-26 19:39:19 +0200 (Fri, 26 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc

Enable back the test disabled in r19348,r19345 since dank disabled them from
valgrind itself.

Review URL: http://codereview.chromium.org/147213
------------------------------------------------------------------------
r19370 | erikkay@chromium.org | 2009-06-26 19:12:27 +0200 (Fri, 26 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h

Change ExtensionHost to use notifications
rather than direct communication with ExtensionProcessManager.
This simplifies ownership and lifetime issues which allows me to also
revert the change that made ExtensionProcessManager owned by
ExtensionsService.

Review URL: http://codereview.chromium.org/147208
------------------------------------------------------------------------
r19369 | brettw@chromium.org | 2009-06-26 18:41:34 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Remove dependency on NavigationEntry from RenderViewHost. The code for
converting a NavigationEntry to a Navigate message is now in TabContents and
it will send the params rather than the NavigationEntry to the RenderViewHost.

I also removed "virtual" fron a bunch of functions that were never overridden.
Review URL: http://codereview.chromium.org/147128
------------------------------------------------------------------------
r19363 | tim@chromium.org | 2009-06-26 17:52:29 +0200 (Fri, 26 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Revert cl 19359 due to browser_tests timeout.

TBR=nsylvain
Review URL: http://codereview.chromium.org/147206
------------------------------------------------------------------------
r19360 | mnaganov@chromium.org | 2009-06-26 17:09:01 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   A /trunk/src/chrome/test/data/devtools/js_page.html
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools Profiler: add sanity test.

Add a test that opens a page which executes JS, profiles it, and checks the result displayed.

BUG=none
TEST=chrome\browser\debugger\devtools_sanity_unittest.cc

Review URL: http://codereview.chromium.org/147204
------------------------------------------------------------------------
r19359 | tim@chromium.org | 2009-06-26 16:54:44 +0200 (Fri, 26 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   M /trunk/src/chrome/browser/dom_ui/tips_handler.cc
   M /trunk/src/chrome/browser/dom_ui/tips_handler.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to construct these objects by deferring the DOMUI dependency to the init / "Attach" step.

Add GetMessageHandlers to HtmlDialogUIDelegate to allow
sending/receiving messages to the page hosted in the dialog as opposed to only on open/close.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/131094
------------------------------------------------------------------------
r19348 | nirnimesh@chromium.org | 2009-06-26 08:22:16 +0200 (Fri, 26 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc

Fix breakage

Review URL: http://codereview.chromium.org/147196
------------------------------------------------------------------------
r19345 | nirnimesh@chromium.org | 2009-06-26 08:09:09 +0200 (Fri, 26 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc

Disabling BookmarkEditorGtkTest::ModelsMatch_Test

http://crbug.com/15436

TBR=nsylvain

Review URL: http://codereview.chromium.org/147195
------------------------------------------------------------------------
r19340 | sky@chromium.org | 2009-06-26 06:36:28 +0200 (Fri, 26 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc

Tweaks to tab overview to get it performant:
. Delay getting thumnbails until 300ms after the window is shown. This
  is necessary as getting the thumnbails is very expensive.
. Configure the thumnbail for one cell at a time. For same reason as
  last one.
. Don't show new tab window widget as we don't yet have the type set
  up.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/147174
------------------------------------------------------------------------
r19339 | sky@chromium.org | 2009-06-26 06:36:20 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/newtab2.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Changes the image used for the new tab button.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/146056
------------------------------------------------------------------------
r19334 | jshin@chromium.org | 2009-06-26 05:26:13 +0200 (Fri, 26 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

The following 3 ui tests have been flaky on Linux.

  DownloadTest.DownloadMimeType
  DownlaodTest.ContentDisposition
  SavePageTest.FilenameFromPageTitle


BUG=15416,15244
   http://crbug.com/15416
   http://crbug.com/15244
TEST=Linux UI test bots do not fail due to these tests
TBR=estade
Original review: http://codereview.chromium.org/147179

------------------------------------------------------------------------
r19333 | estade@chromium.org | 2009-06-26 04:20:31 +0200 (Fri, 26 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc

More BIDI support:

- mirror nine boxes
- mirror menu positioning
- mirror download item show/hide logic

http://crbug.com/15406 is relevant, although I'm not sure this 100% fixes it.

TEST=use download shelf in Hebrew chrome. Things should be mirrored. Use it in English and nothing should be borked.
Review URL: http://codereview.chromium.org/147176
------------------------------------------------------------------------
r19332 | rvargas@google.com | 2009-06-26 04:04:51 +0200 (Fri, 26 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix proper MACOSX exlussion.

TBR=rafaelw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149051
------------------------------------------------------------------------
r19331 | rvargas@google.com | 2009-06-26 03:35:35 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/browser_views_accessibility_unittest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/accessibility (from /trunk/src/chrome/test/accessibility:19314)

Revert cl 19315 to see if it fixes the builds.

TBR=klink
BUG=none

Review URL: http://codereview.chromium.org/149049
------------------------------------------------------------------------
r19324 | agl@chromium.org | 2009-06-26 02:47:05 +0200 (Fri, 26 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc

Linux: fix font fallback for charactors missing from the primary font.

We are using the sandbox host for font fallback now via the WebKit
API. However, a patch landed in WebKit which added an assertion about
being on the correct thread. Since the sandbox host was using
WebString::fromUTF8, we hit the assertion and died.

So, we have to implement a WebKitClient for the sandbox host. We
cannot just pass in NULL because there's an assertion that it's
non-NULL. Also, we cannot pass in a bogus pointer because it actually
ends up getting called back.

------------------------------------------------------------------------
r19317 | ben@chromium.org | 2009-06-26 02:11:01 +0200 (Fri, 26 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/app/animation.cc
   M /trunk/src/app/animation.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Make omnibox2 dropdown not flash during result set transitions...

- Animate smoothly between decreasing popup heights. Increasing popup heights are instantaneous.
- Don't start a size adjustment until a few ms after the result set is updated to avoid jumping the height of the omnibox popup during typing as results from async providers stream in.
- The result row carries a copy of the match data so it always has something to paint even if the match that corresponded to those results is now gone. These rows aren't actually actionable by the user and only appear during the animation. The result views are retained even if they are not visible (clipped).

BUG=none
TEST=type slowly in the omnibox, note the height of the popup doesn't jump between characters.

Review URL: http://codereview.chromium.org/149030
------------------------------------------------------------------------
r19316 | rafaelw@chromium.org | 2009-06-26 02:06:05 +0200 (Fri, 26 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Disable ExtensionsService.ExternalInstallPref unittest on mac.

Broke with: http://codereview.chromium.org/140018.

R=rvargas

Review URL: http://codereview.chromium.org/147183
------------------------------------------------------------------------
r19315 | klink@chromium.org | 2009-06-26 02:01:48 +0200 (Fri, 26 Jun 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/browser_views_accessibility_unittest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/accessibility

Removes the outdated and flaky UI tests, and introduces a whole new set of shiny unit tests instead.BUG=2242,2243
Review URL: http://codereview.chromium.org/146124
------------------------------------------------------------------------
r19312 | mattm@chromium.org | 2009-06-26 01:49:39 +0200 (Fri, 26 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h

Remove unused num_rows argument to OptionsLayoutBuilderGtk

BUG=none

Review URL: http://codereview.chromium.org/149037
------------------------------------------------------------------------
r19310 | estade@chromium.org | 2009-06-26 01:48:54 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Fix another bookmark manager crasher.

Also, don't allow drags to originate from parts of the table view that don't have rows.

BUG=http://crbug.com/15388
TEST=try to drag from the white space below the lowest row of the bookmark manager right pane onto the bookmark bar (nothing should happen)

Review URL: http://codereview.chromium.org/149024
------------------------------------------------------------------------
r19309 | estade@chromium.org | 2009-06-26 01:48:44 +0200 (Fri, 26 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h

Add a function to ResourceBundle to allow loading images that will mirror in RTL. Use this function for custom buttons and for the Off the Record avatar.

for reference, this will be a bit different than Views, which does it per class rather than per image: http://dev.chromium.org/developers/design-documents/ui-mirroring-infrastructure

Review URL: http://codereview.chromium.org/147157
------------------------------------------------------------------------
r19306 | mirandac@chromium.org | 2009-06-26 01:32:48 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   M /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   A /trunk/src/chrome/browser/dom_ui/tips_handler.cc (from /trunk/src/chrome/browser/dom_ui/web_resource_handler.cc:19282)
   A /trunk/src/chrome/browser/dom_ui/tips_handler.h (from /trunk/src/chrome/browser/dom_ui/web_resource_handler.h:19282)
   D /trunk/src/chrome/browser/dom_ui/web_resource_handler.cc
   D /trunk/src/chrome/browser/dom_ui/web_resource_handler.h
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   M /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Hooks backend tip service into new tab page.  Also changes tip service to load tips from popgadget, at http://www.google.com/labs/popgadget/world.

BUG= http://crbug.com/14962
TEST= Enable new tab page.  See welcome message.  On reload afterwards (and always after that, as long as preferences file isn't removed), see browsing recommendations appear in bottom right corner.

Review URL: http://codereview.chromium.org/147109
------------------------------------------------------------------------
r19302 | cira@chromium.org | 2009-06-26 01:09:52 +0200 (Fri, 26 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/extensions/extension_shelf.cc

Move extension delimiters to the right.

BUG=http://crbug.com/11880
TEST=Load Chrome with --lang=he, and add 1+ extension. Delimiters should be on the right.

Review URL: http://codereview.chromium.org/147132
------------------------------------------------------------------------
r19301 | agl@chromium.org | 2009-06-26 01:09:05 +0200 (Fri, 26 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: add Alt-n keys for switching tabs.

The UI decision was to have both Alt-n and Ctrl-n switch tabs. Ctrl-n
to match Windows Chrome and Alt-n to match Firefox on Linux. Pages
which try to grab either sets of keys will succeed.

BUG=13395

------------------------------------------------------------------------
r19294 | rafaelw@chromium.org | 2009-06-25 23:53:43 +0200 (Thu, 25 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc

two more unit_test fixes for: http://codereview.chromium.org/140018

R=rvargas

Review URL: http://codereview.chromium.org/147171
------------------------------------------------------------------------
r19289 | ericroman@google.com | 2009-06-25 23:36:23 +0200 (Thu, 25 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/dns_global.cc

Reverting 19271.

Revert 19271, since it caused crash in reliability test. (dns prefetcher may still cancel requests on the host resolver during shutdown).
Review URL: http://codereview.chromium.org/149026
------------------------------------------------------------------------
r19288 | rafaelw@chromium.org | 2009-06-25 23:35:13 +0200 (Thu, 25 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc

Fix unit_test breakage from http://codereview.chromium.org/140018

R=sky

Review URL: http://codereview.chromium.org/147169
------------------------------------------------------------------------
r19287 | agl@chromium.org | 2009-06-25 23:25:31 +0200 (Thu, 25 Jun 2009) | 20 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/sandbox_methods_linux.h
   A /trunk/src/chrome/renderer/renderer_sandbox_support_linux.cc
   A /trunk/src/chrome/renderer/renderer_sandbox_support_linux.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   A /trunk/src/webkit/api/public/gtk/WebFontInfo.h
   A /trunk/src/webkit/api/public/linux
   A /trunk/src/webkit/api/public/linux/WebSandboxSupport.h
   M /trunk/src/webkit/api/src/ChromiumBridge.cpp
   A /trunk/src/webkit/api/src/gtk/WebFontInfo.cpp
   M /trunk/src/webkit/webkit.gyp

Linux: plumb fontconfig call out to the sandbox host.

This is hopefully the last step before our renderers can run cleanly
in a chroot.

WebKit needs to be able to ask for the correct font to use in the case
that the current font doesn't include glyphs for certain code points.
Currently we make a fontconfig call in our WebKit port to handle this.

This patch changes this so that the call is sent our via
ChromiumBridge. Since we are at ChromiumBridge, we could make a sync
IPC to the browser. However, fontconfig is a single threaded library
and we are already using it on the UI thread in the browser, so the
sync IPC would have to terminate on the UI thread. Even if this
doesn't deadlock, it causes huge spikes in latency.

So, instead, we send the IPC to the sandbox host process which is
already setup to handle fontconfig requests from Skia. See:
  http://code.google.com/p/chromium/wiki/LinuxSandboxIPC

------------------------------------------------------------------------
r19285 | rafaelw@chromium.org | 2009-06-25 23:03:23 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   A /trunk/src/chrome/test/data/extensions/bad/Extensions
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/1
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/1/manifest.json (from /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/1/manifest.json:19268)
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Current Version (from /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Current Version:19268)
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/1
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/1/not_a_manifest (from /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/1/not_a_manifest:19268)
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/Current Version (from /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/Current Version:19268)
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json (from /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json:19268)
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version (from /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version:19268)
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/cccccccccccccccccccccccccccccccc
   A /trunk/src/chrome/test/data/extensions/bad/Extensions/cccccccccccccccccccccccccccccccc/git_abhors_empty_dirs (from /trunk/src/chrome/test/data/extensions/bad/cccccccccccccccccccccccccccccccc/git_abhors_empty_dirs:19268)
   A /trunk/src/chrome/test/data/extensions/bad/Preferences
   D /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Current Version
   D /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/1/not_a_manifest
   D /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/Current Version
   D /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version
   D /trunk/src/chrome/test/data/extensions/bad/cccccccccccccccccccccccccccccccc/git_abhors_empty_dirs
   A /trunk/src/chrome/test/data/extensions/good/Extensions
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/js_files
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/js_files/script3.js (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/js_files/script3.js:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script1.js (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script1.js:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script2.js (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script2.js:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style1.css (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style1.css:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style2.css (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style2.css:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/Current Version (from /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/Current Version:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json (from /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version (from /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk
   A /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/2
   A /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/2/background.html (from /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/background.html:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/2/content_plugin.dll (from /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/content_plugin.dll:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/2/extension_plugin.dll (from /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/extension_plugin.dll:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/2/manifest.json (from /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/manifest.json:19268)
   A /trunk/src/chrome/test/data/extensions/good/Extensions/hpiknbiabeeppbpihjehijgoemciehgk/Current Version (from /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/Current Version:19268)
   A /trunk/src/chrome/test/data/extensions/good/Preferences
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/js_files/script3.js
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script1.js
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script2.js
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style1.css
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style2.css
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html
   D /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/Current Version
   D /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version
   D /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/background.html
   D /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/content_plugin.dll
   D /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/extension_plugin.dll
   D /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/Current Version

Refactored ExtensionsPrefs to store paths relative to the extensions install directory. Fix & reenabled two extensions_service unit_tests.

R=erikkay
BUG=14714

Review URL: http://codereview.chromium.org/140018
------------------------------------------------------------------------
r19282 | erg@google.com | 2009-06-25 22:43:15 +0200 (Thu, 25 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

GTK: Another attempt at fixing gtk_floating_container_forall() crasher.

Tie the lifetime of the GtkFloatingContainer to TabContentsContainerGtk.
Working theory is that we're leaking that reference, which is causing
the crash.

http://crbug.com/14485

Review URL: http://codereview.chromium.org/147163
------------------------------------------------------------------------
r19281 | mark@chromium.org | 2009-06-25 22:42:31 +0200 (Thu, 25 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Give such a fewer tips.  Hide tooltips when the owning
RenderWidgetHostView[Mac] is hidden.

BUG=14178
TEST=Get a tooltip to display (hover the Inbox link in Gmail) and then pop
     a new tab without using the mouse (press command-T).  The tooltip should
     disappear.
Review URL: http://codereview.chromium.org/149017
------------------------------------------------------------------------
r19273 | shess@chromium.org | 2009-06-25 21:29:01 +0200 (Thu, 25 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm

Guard against nil window in GetRootWindowRect().

Review URL: http://codereview.chromium.org/146118
------------------------------------------------------------------------
r19271 | ericroman@google.com | 2009-06-25 21:18:40 +0200 (Thu, 25 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/dns_global.cc

Teardown the global host resolver as part of ~ChromeURLRequest() rather than in EnsureDnsPrefetchShutdown().

This is necessary because although CleanupRequestContext() is strictly before EnsureDnsPrefetchShutdown(), the URLRequestContext instances are refcounted. Therefore they may survive CleanupRequestContext(), and continue accessing the HostResolver after dns prefetcher has done teardown.

BUG=14664

Review URL: http://codereview.chromium.org/146139
------------------------------------------------------------------------
r19267 | finnur@chromium.org | 2009-06-25 20:36:44 +0200 (Thu, 25 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Fix build. 

TBR=nsylvain
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/147156
------------------------------------------------------------------------
r19266 | avi@chromium.org | 2009-06-25 20:16:39 +0200 (Thu, 25 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   D /trunk/src/chrome/browser/cocoa/cocoa_utils.h
   D /trunk/src/chrome/browser/cocoa/cocoa_utils.mm
   D /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_mac.mm
   A /trunk/src/skia/ext/skia_utils_mac_unittest.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Add favicons to tabs on the Mac. Also moved SkBitmapToNSImage() to
skia/ext/skia_utils_mac.h and removed chrome/browser/cocoa/cocoa_utils.h.

Patch by rsesek.

BUG=13565

http://codereview.chromium.org/131018

------------------------------------------------------------------------
r19264 | finnur@chromium.org | 2009-06-25 19:53:15 +0200 (Thu, 25 Jun 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/external_extensions.json
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.h

The Provider for External Extensions no longer uses
the prefs file, but instead reads a preferences file
(a json file called external_extensions.json).

This file specifies what external extensions we
installed (shipped with Chrome) and the extension
system takes care of installing them.

Having this in a separate file makes the upgrade
scenario easier, since we can during upgrade simply
blow away this file and replace it (and not have
to worry about merging/loosing user specified data).

The extension system will read the file, and figure
out whether any extension needs to be upgraded based
on the information provided.

Now, all external providers fetch data on the file
thread instead of reading and copying preferences on
the UI thread and posting them to the file thread.

BUG=http://crbug.com/14201
TEST=Covered by unit test.
Review URL: http://codereview.chromium.org/144018
------------------------------------------------------------------------
r19257 | jcampan@chromium.org | 2009-06-25 19:29:09 +0200 (Thu, 25 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

On Linux, the path to the exe is used to fork renderer processes.
This was causing the browser tests to create browser tests instead of a renderer processes.
Also the SSL tests now pass on Linux and have been enabled.

BUG=None
TEST=Run the browser tests on Linux.
Review URL: http://codereview.chromium.org/146057
------------------------------------------------------------------------
r19254 | jcampan@chromium.org | 2009-06-25 19:20:56 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Fixing the tab order in the task manager.

BUG=http://crbug.com/6781
TEST=See bug

Review URL: http://codereview.chromium.org/149010
------------------------------------------------------------------------
r19247 | avi@chromium.org | 2009-06-25 16:52:01 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/extensions/extension_error_reporter.cc

Temporary extension UI for the Mac.

BUG=none
TEST=try loading a failing extension on the Mac; you should get some UI

Review URL: http://codereview.chromium.org/147098
------------------------------------------------------------------------
r19246 | erikkay@chromium.org | 2009-06-25 16:47:06 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/base/gfx/size.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

change backing store cache to be memory-based rather than count

BUG=13763
TEST=none

Review URL: http://codereview.chromium.org/146095
------------------------------------------------------------------------
r19245 | avi@chromium.org | 2009-06-25 16:23:41 +0200 (Thu, 25 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   A /trunk/src/chrome/browser/cocoa/cocoa_utils.h (from /trunk/src/chrome/browser/cocoa/cocoa_utils.h:19243)
   A /trunk/src/chrome/browser/cocoa/cocoa_utils.mm (from /trunk/src/chrome/browser/cocoa/cocoa_utils.mm:19243)
   A /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm (from /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm:19243)
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_mac.mm
   D /trunk/src/skia/ext/skia_utils_mac_unittest.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Reverting r19244 as it unintentionally broke ui tests: OtherRedirectsDontForkProcess InEmptyFrame TestLifetimeOfDomAutomationController


------------------------------------------------------------------------
r19244 | avi@chromium.org | 2009-06-25 15:58:34 +0200 (Thu, 25 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   D /trunk/src/chrome/browser/cocoa/cocoa_utils.h
   D /trunk/src/chrome/browser/cocoa/cocoa_utils.mm
   D /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_mac.mm
   A /trunk/src/skia/ext/skia_utils_mac_unittest.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Add favicons to tabs on the Mac. Also moved SkBitmapToNSImage() to
skia/ext/skia_utils_mac.h and removed chrome/browser/cocoa/cocoa_utils.h.

Patch by rsesek.

BUG=13565

Review URL: http://codereview.chromium.org/131018


------------------------------------------------------------------------
r19238 | hbono@chromium.org | 2009-06-25 10:47:51 +0200 (Thu, 25 Jun 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/webkit/api/public/gtk/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp
   M /trunk/src/webkit/glue/webview_impl.cc

Integrating GtkIMContext into the RenderWidgetHostViewGtk class (Take 2).

This change is an updated version of <http://codereview.chromium.org/126118> that I reverted because of issue 15024 <http://crbug.com/15024>. This issue 15024 is caused by my bonehead mistake that I forgot handling the case that gtk_im_context_filter_keypress() returns false. (The GtkIMContext usually returns false when we type control keys, such as return, page up, page down, etc.) To handle this case, this change added code that manually creates a Char
event and send it to the renderer in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent(). Except this code, it is exactly the same as <http://codereview.chromium.org/126118>.

Unfortunately, this change still uses std::wstring, I'm going to send another change which replace std::wstring with string16.

(The following message is copied from <http://codereview.chromium.org/126118>.)

This change implements signal handers of the GtkIMContext object to support IMEs anddead-keys. Also, to improve compatibility with Windows Chrome, this changeemulates IPC messages sent on Windows when we input characters and fixes
Issue13604 as well as Issue 10953 and 11226. Even though I notice we need more workfor fixing edge cases (e.g. disabling IMEs on a password input) on Linux, Ithink this is the good starting point. (Supporting edge-cases requirescomplicated code and it makes hard to review.)

BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
BUG=13711 "Alt-D does not work when in editbox"
TEST=Open a web page which contains an <input> form, type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form.
TEST=Open a web page which contains an <input> form, enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form.
TEST=Change the keyboard layout to Hebrew (or Russian), open a web page which contains an <input> form, input some characters in the <input> form, type control+a, and see the text in the <input> form is selected.
TEST=Open a web page which contains a <textarea> form, type a return key, and see a new line is inserted.
Review URL: http://codereview.chromium.org/147011
------------------------------------------------------------------------
r19236 | jcampan@chromium.org | 2009-06-25 09:17:41 +0200 (Thu, 25 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager_browser_test.cc

Relanding this, it was failing to compile because of a FRIEND_CHANGE that had not been updated with the test disabled name.

Disabling 2 browser tests that fail on the build-bot:
ExtensionShelfModelTest.Basic
WebCacheManagerBrowserTest.CrashOnceOnly

BUG=None
TEST=None
TBR=erikkay,jam

Review URL: http://codereview.chromium.org/147140
------------------------------------------------------------------------
r19234 | jcampan@chromium.org | 2009-06-25 08:22:17 +0200 (Thu, 25 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager_browser_test.cc

Reverting 19233.
This breaks the build, incrediblously.

TEST=None
BUG=None
TBR=jam
Review URL: http://codereview.chromium.org/146141
------------------------------------------------------------------------
r19233 | jcampan@chromium.org | 2009-06-25 08:01:12 +0200 (Thu, 25 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager_browser_test.cc

Disabling 2 browser tests that fail on the build-bot:
ExtensionShelfModelTest.Basic
WebCacheManagerBrowserTest.CrashOnceOnly

BUG=None
TEST=None
TBR=erikkay,jam
Review URL: http://codereview.chromium.org/147137
------------------------------------------------------------------------
r19232 | xji@chromium.org | 2009-06-25 07:34:38 +0200 (Thu, 25 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h

This CL fixes issue 14481 - RTL: Chrome is trying to open exe file directly after clicking down arrow on download shelf instead of drawing a context menu

After changing the download items in download shelf to be RTL in RTL UI, need to change the computation of x coordinate of drop down button. 

BUG=http://crbug.com/14481
TEST=
1. Run Hebrew Chrome
2. Download an exe file
   >> Dangerous file warning should show up now
3. Click "Save" button
4. Click the down arrow on the download shelf
5. Chrome should draw a context menu after clicking down arrow (not trying to open the exe file)

Review URL: http://codereview.chromium.org/131091
------------------------------------------------------------------------
r19225 | abarth@chromium.org | 2009-06-25 05:20:05 +0200 (Thu, 25 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/base_switches.cc
   M /trunk/src/base/base_switches.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.h
   M /trunk/src/webkit/webkit.gyp

Run content scripts in their own isolated world.  Hidden behind the --isolated-world command line argument to let us iterate on this feature.R=aaBUG=12218TEST=None :(  (I have a testing plan we can put in place once the upstream half of this CL lands.)
Review URL: http://codereview.chromium.org/118188
------------------------------------------------------------------------
r19224 | ukai@chromium.org | 2009-06-25 05:06:28 +0200 (Thu, 25 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Show EV cert info text next to security icon.

Use hbox to pack location entry, security icons and EV cert info text.

Change ToolbarModel::GetInfoText not return SkColor.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/126117
------------------------------------------------------------------------
r19223 | jeremy@chromium.org | 2009-06-25 04:45:17 +0200 (Thu, 25 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Add an about:inducebrowsercrashforrealz URL.

This facilitates easy QA for browser crash reporting.

Review URL: http://codereview.chromium.org/147126
------------------------------------------------------------------------
r19221 | estade@chromium.org | 2009-06-25 04:34:35 +0200 (Thu, 25 Jun 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Revert r19162,19179 as they caused the toolbar and bookmark bar to regress and display LTR for RTL locales.

r19162 | jhawkins@chromium.org | 2009-06-24 13:15:04 -0700 (Wed, 24 Jun 2009) | 5 lines

Add support for RTL languages in the gtk toolbar layout.

BUG=none
TEST=Open a browser window in a RTL language (--lang=he).  The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102

r19179 | jhawkins@chromium.org | 2009-06-24 14:38:25 -0700 (Wed, 24 Jun 2009) | 5 lines

Add support for RTL languages in the gtk bookmark bar.

BUG=none
TEST=Open a browser window in a RTL language (--lang=he).  The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105

See http://i139.photobucket.com/albums/q315/failfast/revertrtl.png

Review URL: http://codereview.chromium.org/147130
------------------------------------------------------------------------
r19220 | estade@chromium.org | 2009-06-25 04:33:51 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Paint the spy guy.

BUG=none
TEST=go incognito, toggle custom frame drawing

Review URL: http://codereview.chromium.org/146122
------------------------------------------------------------------------
r19218 | amanda@chromium.org | 2009-06-25 03:48:04 +0200 (Thu, 25 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Update Skia transfer mode names in browser/* to Skia r239
TBR=levin
Review URL: http://codereview.chromium.org/147131
------------------------------------------------------------------------
r19211 | amanda@chromium.org | 2009-06-25 03:01:52 +0200 (Thu, 25 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/app/gfx/canvas.cc
   M /trunk/src/app/gfx/canvas.h
   M /trunk/src/chrome/browser/cocoa/cocoa_utils.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/skia/config/SkUserConfig.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/skia_utils_mac.mm
   M /trunk/src/skia/skia.gyp
   M /trunk/src/webkit/port/bindings/scripts/CodeGeneratorV8.pm
   M /trunk/src/webkit/port/bindings/v8/v8_index.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_index.h
   M /trunk/src/webkit/webkit.gyp

Update WebKit to 45111 and Skia to 239
Review URL: http://codereview.chromium.org/147121
------------------------------------------------------------------------
r19208 | brettw@chromium.org | 2009-06-25 02:47:50 +0200 (Thu, 25 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disable failing tests until I can figure out what's going on.
Review URL: http://codereview.chromium.org/146127
------------------------------------------------------------------------
r19207 | ben@chromium.org | 2009-06-25 02:35:35 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_gtk.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_test.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_views.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu.cc
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu.h
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_gtk.cc:19200)
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   A /trunk/src/chrome/browser/views/bookmark_context_menu.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc:19200)
   A /trunk/src/chrome/browser/views/bookmark_context_menu.h (from /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h:19200)
   A /trunk/src/chrome/browser/views/bookmark_context_menu_test.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_test.cc:19200)
   A /trunk/src/chrome/browser/views/bookmark_context_menu_views.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_views.cc:19200)
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/chrome.gyp

Fork bookmark context menu logic across platforms. There's too much crazy stuff going on here, I can't begin to unravel it on more than one platform at a time.

TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146125
------------------------------------------------------------------------
r19203 | estade@chromium.org | 2009-06-25 02:17:01 +0200 (Thu, 25 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h

bookmarks dnd:

- Correct row index calculation in bookmark manager drag receive.
- Support multiple target dnd

also see http://crbug.com/15240

BUG=none
TEST=multi dragging in bookmark manager/bookmark bar. See cited bug for explanation of how to multi-drag.

Review URL: http://codereview.chromium.org/147107
------------------------------------------------------------------------
r19199 | arv@google.com | 2009-06-25 01:59:51 +0200 (Thu, 25 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Make sure we keep overflow: hidden on the #most-visited element when
hidden.

Also, update the height of the lower section so that content does not
get clipped.

BUG=15234, 15106

TEST=Hide the thumbnails on the new new tab page. There should be no
way that clicking on some empty space would activate a hidden
.thumbnail For the second part of this bug close 5+ tabs and check that
the Recently closed section does not get clipped.

Review URL: http://codereview.chromium.org/146120
------------------------------------------------------------------------
r19198 | jcampan@chromium.org | 2009-06-25 01:49:18 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/task_manager_view.cc

Now that the tab_table_ of the TaskManager is parent owned, it should not be accessed after the views have been removed.
This was causing a crasher in the browser tests (as a deleted object was accessed).

BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/147110
------------------------------------------------------------------------
r19197 | jshin@chromium.org | 2009-06-25 01:28:44 +0200 (Thu, 25 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/locale_tests_uitest.cc

Change zh-tw to zh-TW when it's used to find the locale data pack on Linux (case-sensitive file system).

BUG=8647
TEST=Pass ui test on Linux
TBR=tony

Review URL: http://codereview.chromium.org/146117
------------------------------------------------------------------------
r19196 | arv@google.com | 2009-06-25 01:23:56 +0200 (Thu, 25 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Add tooltips to buttons on the new new tab page as well as remove the
edit link.

BUG=14958, 15073

TEST=On the new new tab page. No "edit" link should show up after a
long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails,
show/hide list should all show tooltips.

Review URL: http://codereview.chromium.org/146108
------------------------------------------------------------------------
r19194 | yusukes@google.com | 2009-06-25 01:09:32 +0200 (Thu, 25 Jun 2009) | 11 lines
Changed paths:
   D /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

Merging r18584 into chrome/browser/views/tab_contents/tab_contents_view_win.cc.

My last patch (http://src.chromium.org/viewvc/chrome?view=rev&revision=18584) should have been for chrome/browser/views/tab_contents/tab_contents_view_win.cc, not for chrome/browser/tab_contents/tab_contents_view_win.cc since the latter had been deleted (http://src.chromium.org/viewvc/chrome?view=rev&revision=18368).

I've confirmed that no patch other than mine is submitted to the old file:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc?view=log

BUG=12290
TEST=See http://codereview.chromium.org/125111

Review URL: http://codereview.chromium.org/147074
------------------------------------------------------------------------
r19192 | ben@chromium.org | 2009-06-25 01:02:51 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/edit_search_engine_dialog.cc

Fix order of parameters that was causing title and keyword to be switched.

http://crbug.com/15226
TEST=see bug

Review URL: http://codereview.chromium.org/147112
------------------------------------------------------------------------
r19189 | meelapshah@chromium.org | 2009-06-25 00:38:58 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Add looking up/caching of redirect lists to find the best thumbnail.

Added timer to clean unpopular thumbnails from the cache/disk every hour.
Still need to implement removal of blacklisted urls.

Review URL: http://codereview.chromium.org/126237
------------------------------------------------------------------------
r19188 | brettw@chromium.org | 2009-06-25 00:36:15 +0200 (Thu, 25 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc

Fix a bug generating thumbnails. We would only use a stashed thumbnail when it
hadn't expired (5 seconds), even if there was no backing store. We now use the
stashed one no matter what if there is no backing store to create a new one.

Review URL: http://codereview.chromium.org/147087
------------------------------------------------------------------------
r19187 | mark@chromium.org | 2009-06-25 00:31:21 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Back out all sorts of stuff back to pre-r18933 so that we can regroup and
figure these perf regressions out.

TEST=graphs
BUG=15232
Review URL: http://codereview.chromium.org/147113
------------------------------------------------------------------------
r19183 | jshin@chromium.org | 2009-06-25 00:17:06 +0200 (Thu, 25 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/l10n_util_posix.cc
   M /trunk/src/app/l10n_util_unittest.cc
   M /trunk/src/app/l10n_util_win.cc
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_icu.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Replace std:;wstring with std::string and string16 in locale-name related APIs.

1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly.
2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring.

This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places). 

Note : this CL will be landed after http://codereview.chromium.org/147038 is landed. 
BUG=8647 (http://crbug.com/8647)
TEST=Pass l10n_util_unittest and other unit tests

Review URL: http://codereview.chromium.org/126223
------------------------------------------------------------------------
r19182 | kuchhal@chromium.org | 2009-06-25 00:16:17 +0200 (Thu, 25 Jun 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/external_extensions.json
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/installer/mini_installer/mini_installer.vcproj

Try to reland r19170 (Pick up extensions (if any) and extensions
definitions file for installation.)

Review URL: http://codereview.chromium.org/146109
------------------------------------------------------------------------
r19181 | tc@google.com | 2009-06-25 00:14:23 +0200 (Thu, 25 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   A /trunk/src/chrome/browser/utility_process_host_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Fix extension unpacking on linux/mac

Add a unittest that pretends to be the UtilityProcessHost and launches a chrome utility process for unpacking a theme.

Review URL: http://codereview.chromium.org/147001

------------------------------------------------------------------------
r19179 | jhawkins@chromium.org | 2009-06-24 23:38:25 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Add support for RTL languages in the gtk bookmark bar.

BUG=none
TEST=Open a browser window in a RTL language (--lang=he).  The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
------------------------------------------------------------------------
r19178 | agl@chromium.org | 2009-06-24 23:36:17 +0200 (Wed, 24 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Linux: fail more gracefully when ProcessSingleton fails to bind.

For users with AFS home directories, we cannot create UNIX domain
sockets for ProcessSingleton. Before this patch we would spin because
the socket would be constantly 'readable' for accept.

http://codereview.chromium.org/139008

BUG=14237

------------------------------------------------------------------------
r19176 | jcampan@chromium.org | 2009-06-24 23:32:48 +0200 (Wed, 24 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc

We were hitting a DCHECK when removing a password in the password option panel.
This is a regression introduced by a recent change that fixed another bug.
The problem was that we were not dealing with the empty selection case in the password table.

BUG=http://crbug.com/15215
TEST=Open the "show saved password" dialog in the options. Move the selection around. Delete a password. Show a password, then move the selection, the password should not be shown anymore.
Review URL: http://codereview.chromium.org/147104
------------------------------------------------------------------------
r19174 | rafaelw@chromium.org | 2009-06-24 23:28:30 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc

Move PathComponents from file_util to FilePath, add FilePath::IsParent()

r=erikkay,mark

Review URL: http://codereview.chromium.org/145026
------------------------------------------------------------------------
r19172 | kuchhal@chromium.org | 2009-06-24 23:17:59 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/external_extensions.json
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/installer/mini_installer/mini_installer.vcproj

Revert "Pick up extensions (if any) and extensions definitions file for installation."

This reverts commit r19170.

Review URL: http://codereview.chromium.org/146106
------------------------------------------------------------------------
r19170 | kuchhal@chromium.org | 2009-06-24 23:03:41 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/external_extensions.json
   M /trunk/src/chrome/installer/mini_installer/chrome.release
   M /trunk/src/chrome/installer/mini_installer/mini_installer.vcproj

Pick up extensions (if any) and extensions definitions file for installation.

BUG=14201

Review URL: http://codereview.chromium.org/147092
------------------------------------------------------------------------
r19169 | mark@chromium.org | 2009-06-24 23:01:36 +0200 (Wed, 24 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm

Fix test (really, you call this a test?) that I broke in r19167
Review URL: http://codereview.chromium.org/147105
------------------------------------------------------------------------
r19168 | finnur@chromium.org | 2009-06-24 22:54:51 +0200 (Wed, 24 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   A /trunk/src/chrome/test/data/find_in_page/crash_14491.html

Adding a browser test to catch a WebKit crash that was fixed in
revision 18898 (when WebKit revision 44901 was merged in).

BUG=14491
TEST=That's what this is all about.

Review URL: http://codereview.chromium.org/146102
------------------------------------------------------------------------
r19167 | mark@chromium.org | 2009-06-24 22:39:16 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Rewrite some tab controller stuff to maybe (but probably not) improve perf.

BUG=15232
TEST=watch perf graphs
Review URL: http://codereview.chromium.org/147103
------------------------------------------------------------------------
r19166 | arv@google.com | 2009-06-24 22:34:11 +0200 (Wed, 24 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix issues with the last patch.

BUG=14959

TEST=The option menu on the new new tab page should react to keyboard
and mouse events.


Review URL: http://codereview.chromium.org/147097
------------------------------------------------------------------------
r19164 | estade@chromium.org | 2009-06-24 22:27:47 +0200 (Wed, 24 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc

Avoid setting a widget's allocation outside of a widget implementation.

GtkFixeds do allocate their children. They give them an allocation that matches
their size request. Hence when you directly allocate the child, it gets two
allocates right in a row (one from you, one from the fixed). This was causing
flicker in slide animator gtk (most noticeable when opening a new browser window
and seeing the restore infobar, but also confirmed with debugging statements). The original reason for needing to use
size_allocate() instead of set_size_request() (which had to do with browser
window resizing) is now obsolete, so revert these back to size_request()s.

BUG=none
TEST=less flicker when an infobar is opening; border at bottom of toolbar/bookmark bar still looks the same

Review URL: http://codereview.chromium.org/147100
------------------------------------------------------------------------
r19162 | jhawkins@chromium.org | 2009-06-24 22:15:04 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

Add support for RTL languages in the gtk toolbar layout.

BUG=none
TEST=Open a browser window in a RTL language (--lang=he).  The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102
------------------------------------------------------------------------
r19160 | erg@google.com | 2009-06-24 22:03:30 +0200 (Wed, 24 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: When a browser is shown to the user, it should immediatly become the
active browser. Not doing so was breaking code that opened a new window and
then immediatly opened aditional tabs in it.

http://crbug.com/14018

Review URL: http://codereview.chromium.org/147091
------------------------------------------------------------------------
r19159 | estade@chromium.org | 2009-06-24 21:58:36 +0200 (Wed, 24 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

Make find bar match label pretty.

This also makes the findbar entry look the same on all system themes (dark themes no longer distinct).

BUG=none
TEST=when you fail to find something the background of the match count label turns orange, and when you succeed in finding something the background is white.

Review URL: http://codereview.chromium.org/147053
------------------------------------------------------------------------
r19157 | pinkerton@chromium.org | 2009-06-24 21:49:54 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

perbot
BUG=none
TEST=none
------------------------------------------------------------------------
r19156 | pinkerton@chromium.org | 2009-06-24 21:40:46 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm

Fix unit tests by not relying on the unit tests having a local_state object, fallback to the prefs object.
BUG=none
TEST=none
------------------------------------------------------------------------
r19154 | glen@chromium.org | 2009-06-24 21:29:05 +0200 (Wed, 24 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/base/gfx/png_codec_unittest.cc
   M /trunk/src/base/gfx/png_decoder.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Reverting 19131.
Review URL: http://codereview.chromium.org/147095
------------------------------------------------------------------------
r19150 | cira@chromium.org | 2009-06-24 20:41:36 +0200 (Wed, 24 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html

In case current language is RTL we mark file names as LTR to avoid problems like A-B.jpg becoming B.jpg-A on download page and new-new-tab/download section.BUG=http://crbug.com/15094TEST=Start Chrome with --lang=he --new-new-tab options and check that filename with - in the name has the proper form (check bug on how to get the file). I've checked LTR language (sr) too and output remains correct.
Review URL: http://codereview.chromium.org/146064
------------------------------------------------------------------------
r19149 | pinkerton@chromium.org | 2009-06-24 20:41:24 +0200 (Wed, 24 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Implement Privacy prefs and cookie prefs in "under the hood".
BUG=15078
TEST=prefs listed in bug. Not sure how to test nav errors or usage stats (since we don't really send them) or DNS pre-fetch.
Review URL: http://codereview.chromium.org/146088
------------------------------------------------------------------------
r19146 | pinkerton@chromium.org | 2009-06-24 20:15:13 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

perfbot
BUG=none
TEST=none
------------------------------------------------------------------------
r19145 | arv@google.com | 2009-06-24 20:03:10 +0200 (Wed, 24 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css

Fix incorrect CSS selector for global off switch for animations.

BUG=None

TEST=If you use remote desktop you should not see any animations as you
hide/show the thumbnails on the new new tab page.

Review URL: http://codereview.chromium.org/147086
------------------------------------------------------------------------
r19141 | arv@google.com | 2009-06-24 19:39:49 +0200 (Wed, 24 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Make the options menu keyboard navigatable. Hide the menu when the
button is clicked a second time.

BUG=14959, 15067 

TEST=Tab to the options button. Try pressing the down arrow, up arrow
or enter. These should show the menu. Try pressing esc to hide the
menu. Try pressing enter to execute the item. Try opening the menu,
both using the mouse and keyboard and make sure that it is hidden as
expected.

Review URL: http://codereview.chromium.org/147071
------------------------------------------------------------------------
r19135 | jshin@chromium.org | 2009-06-24 19:08:21 +0200 (Wed, 24 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disable PerWindowShelf test on Linux because it's flaky

BUG=15211 (http://crbug.com/15211 )
TEST=PerWindowShelf test does not show up as a failure on Linux bot
TBR=thakis
Review URL: http://codereview.chromium.org/146091
------------------------------------------------------------------------
r19134 | pinkerton@chromium.org | 2009-06-24 19:02:39 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

perfbot.
BUG=none
TEST=none
------------------------------------------------------------------------
r19131 | glen@chromium.org | 2009-06-24 18:40:08 +0200 (Wed, 24 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/base/gfx/png_codec_unittest.cc
   M /trunk/src/base/gfx/png_decoder.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

PNGDecoder wasn't multiplying the alpha like PNGEncoder was. This lead to color
overflow.

This intermediate fix makes everything correct, but will make alphaed pixels
slightly darker until the user's cache is flushed (I have screenshots of the effect).

BUG=13360
TEST=none

Review URL: http://codereview.chromium.org/147049
------------------------------------------------------------------------
r19130 | glen@chromium.org | 2009-06-24 18:39:58 +0200 (Wed, 24 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h

Fix infobar close button positioning. No-one appears to be using the close button method I removed, and it was wrong, anyway.

BUG=11238
TEST=Make sure that the plugin crashed infobar and save password infobar's close buttons are equivalently positioned.


Review URL: http://codereview.chromium.org/146066
------------------------------------------------------------------------
r19129 | willchan@chromium.org | 2009-06-24 18:39:44 +0200 (Wed, 24 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Fix interstitial crash.
The hidden page's renderer can crash before InterstitialPage::DidNavigate() gets called.
Add an if check for this case.
BUG=http://crbug.com/14942
TEST=see bug for info

Review URL: http://codereview.chromium.org/146070
------------------------------------------------------------------------
r19127 | pinkerton@chromium.org | 2009-06-24 18:21:27 +0200 (Wed, 24 Jun 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

perfbot
------------------------------------------------------------------------
r19126 | pinkerton@chromium.org | 2009-06-24 18:20:14 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

more perfbot tests.
bug=none
test=none
------------------------------------------------------------------------
r19125 | rohitrao@chromium.org | 2009-06-24 18:18:02 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/HungRendererDialog.xib
   A /trunk/src/chrome/browser/cocoa/hung_renderer_controller.h
   A /trunk/src/chrome/browser/cocoa/hung_renderer_controller.mm
   A /trunk/src/chrome/browser/cocoa/hung_renderer_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Initial implementation of the hung renderer dialog on Mac.

BUG=http://crbug.com/13152
TEST=Navigate to about:hang in a tab, verify that the dialog comes up.
Review URL: http://codereview.chromium.org/146012
------------------------------------------------------------------------
r19124 | stuartmorgan@chromium.org | 2009-06-24 17:54:38 +0200 (Wed, 24 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/keychain_mock_mac.cc
   M /trunk/src/chrome/browser/keychain_mock_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Separate the Keychain test data from the Mock itself, and make the mock data creation table-driven.
Replaces the const-ness of helper methods with casting away constness when necessary, so that the new public AddTestItem function isn't const as well.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147056
------------------------------------------------------------------------
r19122 | erikkay@google.com | 2009-06-24 17:45:29 +0200 (Wed, 24 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/views/extensions/extension_view.cc

Clean up a few startup and shutdown dependencies which should fix some of the extension
browser_tests.  Specifically, this includes:
* make ExtensionsService own ExtensionProcessManager so that they have the same lifetime
* git rid of notifications from unload all to avoid treating these notifications like real unload / uninstall events
* fix teardown logic in ExtensionShelfModelTest
* ExtensionView removes itself from the view hierarchy on destruction
* ExtensionProcessManager waits for EXTENSIONS_READY to load background pages

BUG=15080
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest

Review URL: http://codereview.chromium.org/147051
------------------------------------------------------------------------
r19121 | kuchhal@chromium.org | 2009-06-24 17:41:21 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc

Import search engines even if they are not in sqlite3 db.

BUG=14123

Review URL: http://codereview.chromium.org/146045
------------------------------------------------------------------------
r19120 | pinkerton@chromium.org | 2009-06-24 17:20:53 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

More perfbot fun.
BUG=none
TEST=none
------------------------------------------------------------------------
r19117 | pinkerton@chromium.org | 2009-06-24 16:46:06 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

disable more code for perfbot.
BUG=none
TEST=none
------------------------------------------------------------------------
r19114 | pinkerton@chromium.org | 2009-06-24 15:51:42 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

More experiments on perfbot.
BUG=none
TEST=none
------------------------------------------------------------------------
r19112 | pfeldman@chromium.org | 2009-06-24 15:17:12 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

DevTools: remove ShowJavaScriptConsole / InspectElementAt methods from render_view_host API.

Review URL: http://codereview.chromium.org/146080
------------------------------------------------------------------------
r19111 | pinkerton@chromium.org | 2009-06-24 15:13:38 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Backing out last change to see if it regressed perf.
BUG=none
TEST=none
------------------------------------------------------------------------
r19109 | apavlov@chromium.org | 2009-06-24 14:12:36 +0200 (Wed, 24 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.h

Handle EWOULDBLOCK/EAGAIN while sending ChromeDevTools protocol messages so that outbound protocol messages do not get silently dropped.
Review URL: http://codereview.chromium.org/147080
------------------------------------------------------------------------
r19108 | pfeldman@chromium.org | 2009-06-24 11:45:02 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   D /trunk/src/chrome/browser/debugger/debugger.vsprops
   D /trunk/src/chrome/browser/debugger/debugger_disabled.vcproj
   D /trunk/src/chrome/browser/debugger/debugger_disabled.vsprops
   D /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   D /trunk/src/chrome/browser/debugger/debugger_host_impl.h
   D /trunk/src/chrome/browser/debugger/debugger_io.h
   D /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   D /trunk/src/chrome/browser/debugger/debugger_io_socket.h
   D /trunk/src/chrome/browser/debugger/debugger_node.cc
   D /trunk/src/chrome/browser/debugger/debugger_node.h
   D /trunk/src/chrome/browser/debugger/debugger_shell.cc
   D /trunk/src/chrome/browser/debugger/debugger_shell.h
   D /trunk/src/chrome/browser/debugger/debugger_shell_stubs.cc
   D /trunk/src/chrome/browser/debugger/debugger_view.cc
   D /trunk/src/chrome/browser/debugger/debugger_view.h
   D /trunk/src/chrome/browser/debugger/debugger_window.cc
   D /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   D /trunk/src/chrome/browser/debugger/resources
   D /trunk/src/chrome/browser/dom_ui/debugger_ui.cc
   D /trunk/src/chrome/browser/dom_ui/debugger_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   D /trunk/src/chrome/renderer/debug_message_handler.cc
   D /trunk/src/chrome/renderer/debug_message_handler.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/devtools_agent_filter.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/debugger/debugger_unittests.py
   D /trunk/src/webkit/glue/debugger_bridge.cc
   D /trunk/src/webkit/glue/debugger_bridge.h
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/webkit.gyp

DevTools: Nuke legacy debugger.

Review URL: http://codereview.chromium.org/146027
------------------------------------------------------------------------
r19107 | pfeldman@chromium.org | 2009-06-24 11:40:35 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/single_split_view.h

Add support for vertical split into SingleSplitView.

Review URL: http://codereview.chromium.org/146036
------------------------------------------------------------------------
r19106 | craig.schlenter@chromium.org | 2009-06-24 07:48:04 +0200 (Wed, 24 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Show bookmark manager on Linux when menu shortcut is pressed (ctrl-shift-b).

Review URL: http://codereview.chromium.org/146031
------------------------------------------------------------------------
r19102 | estade@chromium.org | 2009-06-24 05:31:17 +0200 (Wed, 24 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Fix a bookmark manager context menu crash, and show the context menu on right click.

http://crbug.com/14196
http://crbug.com/14443

Review URL: http://codereview.chromium.org/147055
------------------------------------------------------------------------
r19101 | estade@chromium.org | 2009-06-24 05:31:02 +0200 (Wed, 24 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

show back/forward menu on right click

http://crbug.com/15100
TEST=do it

Review URL: http://codereview.chromium.org/146062
------------------------------------------------------------------------
r19096 | mattm@chromium.org | 2009-06-24 04:48:11 +0200 (Wed, 24 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc

Fix Gtk TableModel adapters always appending or prepending.

TEST=Open bookmark manager, drag bookmarks around.

Review URL: http://codereview.chromium.org/147059
------------------------------------------------------------------------
r19095 | agl@chromium.org | 2009-06-24 04:32:32 +0200 (Wed, 24 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   M /trunk/src/skia/ext/SkFontHost_fontconfig.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_direct.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.cpp
   M /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.h
   A /trunk/src/webkit/data/layout_tests/chrome/fast/text
   A /trunk/src/webkit/data/layout_tests/chrome/fast/text/fake-italic.html
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Linux: fix fake italics for fonts without italic variants.

Before this patch we assumed that the style which we got from
fontconfig was the one that we asked for. Rather than do this we need
to query the resulting style and plumb that back into WebKit. Once
WebKit knows that there's a mismatch between the request and actual
styles it can trigger faking.

BUG=14810

http://codereview.chromium.org/147005

------------------------------------------------------------------------
r19094 | yuzo@chromium.org | 2009-06-24 04:30:59 +0200 (Wed, 24 Jun 2009) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix: Omnibox is not updated properly when the main frame results in a file download

This is the second attempt, to address the cases where downloadable
URLs are input multiple times.

It seems that depending on the thread execution order, 
TabContents::DidFailProvisionalLoadWithError is sometimes called after
TabContents::OnStartDownload. In such cases, URL display invalidation
happens before the navigation entry removal. The result is
that the downlodable URL remains in the omnibox.

This change ensures that the URL invalidation happens right after
the navigation entry removal.

BUG=1904

TESTED=manually, gcl try

TEST=Type any URLs that causes download, e.g.,
ftp://ftp.vim.org/pub/vim/pc/gvim72.zip into the omnibox.
Observe that the URL is changed back to the original once the download starts.
Repeat this multiple times, with other URLs, to confirm it always works.



Review URL: http://codereview.chromium.org/147006
------------------------------------------------------------------------
r19093 | arv@google.com | 2009-06-24 04:30:04 +0200 (Wed, 24 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix issue where the closed window menu got cut off.

Also, fix issue where the recent items could not be executed using the
keyboard.

BUG=15104, 15111

TEST=Open a new window with 5+ tabs and close it. Then go to the new
new tab page and mouseover the item "5" tabs". It should show the whole
menu and you should also be able to tab to it and pressing enter when
focused should reopen the window.

Review URL: http://codereview.chromium.org/147054
------------------------------------------------------------------------
r19077 | erg@google.com | 2009-06-24 00:55:21 +0200 (Wed, 24 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/views/status_bubble_views.h

GTK: Fix status bubble hiding during background tab events.

So the GTK version had only one status, setting the status to any URL the user hovered over. When the background tab is done with loading, it sends a SetStatus("") to the StatusBubble. This was what was tickling the bug.

So I'm copying the Windows implementation, which can have a URL and a status, with the URL's display overriding the status display. So when the background tab calls SetStatus(""), the URL should still be displayed.

http://crbug.com/14802

Review URL: http://codereview.chromium.org/147050
------------------------------------------------------------------------
r19076 | ericroman@google.com | 2009-06-24 00:52:42 +0200 (Wed, 24 Jun 2009) | 20 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/registry_controlled_domain.cc
   M /trunk/src/net/proxy/proxy_config.cc

Original patch by pmarks@google.com (see http://codereview.chromium.org/113944)

- Pull in googleurl r107, which includes the new CanonicalizeHostVerbose()
function:
http://code.google.com/p/google-url/source/detail?r=107

- Atomically update Chromium to make use of this new function.  This allows us
to extract better information about IP addresses using fewer, and cleaner, calls
to googleurl.

- Also, change a call to CanonicalizeIPAddress() to stay compatible with r107.

The upshot of all this is, Chrome will no longer try to connect to IPv4
addresses with overflow "http://192.168.0.257", or hostnames surrounded by
square brackets "http://[google.com]"

BUG=none
TEST={unit_tests,googleurl_unittests,net_unittests}

Review URL: http://codereview.chromium.org/146053
------------------------------------------------------------------------
r19075 | arv@google.com | 2009-06-24 00:51:49 +0200 (Wed, 24 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_new_tab.js

Fix RTL issues with .item CSS class. Also use dir atttribute instead of
style.direction since it is recommended to treat direction as a
sementic information.

BUG=15077, 15087

TEST=Start chrome with -new-new-tab-page --lang=he and navigate to some
tabs, both RTL tabs and LTR tabs and then close them. The icon should
not overlap the text in the recent section of the new tab page. The text should be aligned next to the icon.

Review URL: http://codereview.chromium.org/147040
------------------------------------------------------------------------
r19074 | sky@chromium.org | 2009-06-24 00:43:40 +0200 (Wed, 24 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.h
   M /trunk/src/chrome/chrome.gyp

Minor tweaks to tab overview:
. select the tab when you click on a cell.
. on release if we didn't start a drag focus the browser.
. Makes the container draw a nicer looking background.
. Makes the new browser window widget show up appropriately.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/146046
------------------------------------------------------------------------
r19073 | sky@chromium.org | 2009-06-24 00:43:14 +0200 (Wed, 24 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Syncs to latest messages and makes tab overview button work.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/147047
------------------------------------------------------------------------
r19072 | mattm@chromium.org | 2009-06-24 00:42:19 +0200 (Wed, 24 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   A /trunk/src/chrome/browser/possible_url_model.cc
   A /trunk/src/chrome/browser/possible_url_model.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/chrome.gyp

Show recent history list in UrlPickerDialogGtk.

BUG=11507
TEST=open options, click "add" to startup url list, select row from list in add url dialog, click add.  Also, try sorting columns, and make sure correct url gets added when selecting an url after sorting.

Review URL: http://codereview.chromium.org/145009
------------------------------------------------------------------------
r19065 | brettw@chromium.org | 2009-06-23 23:45:04 +0200 (Tue, 23 Jun 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc

Build fix, use the correct define for mac.
------------------------------------------------------------------------
r19064 | brettw@chromium.org | 2009-06-23 23:36:47 +0200 (Tue, 23 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/views/controls/image_view.cc

Add Linux support for getting the thumbnail and wire into the switcher.

Review URL: http://codereview.chromium.org/144006
------------------------------------------------------------------------
r19061 | erikkay@chromium.org | 2009-06-23 23:25:01 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc

Fix case where install puts two copies of the extension toolbar on the shelf.

BUG=crbug.com/14941
TEST=install an extension, verify that only one toolbar is visible

Review URL: http://codereview.chromium.org/147026
------------------------------------------------------------------------
r19059 | estade@chromium.org | 2009-06-23 23:11:49 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Fix crasher where we tried to access a destroyed render widget host view.

BUG=14669
TEST=navigate to a webpage that takes a while to load (I used yahoo.com). As soon as you press enter in the url box, right click in the render view (so that the context menu is popped up for your current page rather than yahoo). After yahoo is loaded, dismiss the context menu. No crash.

Review URL: http://codereview.chromium.org/146011
------------------------------------------------------------------------
r19055 | jeremy@chromium.org | 2009-06-23 22:58:15 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc

Some cleanup around WebCore EditCommands:

Renamed CoreCommand -> EditCommand
Renamed the ViewMsg_HandleExecuteEditCommand IPC message to ViewMsg_ExecuteEditCommand

Review URL: http://codereview.chromium.org/147034
------------------------------------------------------------------------
r19052 | erg@google.com | 2009-06-23 22:31:04 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc

GTK: Fix middle click in bookmark menus opening with wrong disposition.

http://crbug.com/13228

Review URL: http://codereview.chromium.org/147023
------------------------------------------------------------------------
r19051 | jhawkins@chromium.org | 2009-06-23 22:29:07 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Handle RTL layout in the gtk tabstrip.

BUG=none
TEST=Open the browser with --lang=he and make sure the tabs are ordered starting from the right.  Also, the UI elements in the tabs should be reversed as well.
Review URL: http://codereview.chromium.org/147020
------------------------------------------------------------------------
r19041 | stuartmorgan@chromium.org | 2009-06-23 20:56:34 +0200 (Tue, 23 Jun 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/keychain_mock_mac.cc
   A /trunk/src/chrome/browser/keychain_mock_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Move MockKeychain into its own file.
The unit test file has become very unwieldy, and I no longer believe that the
Keychain mock is temporary code that should be replaced with GMock (since the
dummy implementation makes certain tests much easier).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146041
------------------------------------------------------------------------
r19039 | jcampan@chromium.org | 2009-06-23 20:50:19 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc

Disabling some browser tests that fail, as part of deploying the browser tests to the build bot.

BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/146042
------------------------------------------------------------------------
r19038 | jcampan@chromium.org | 2009-06-23 20:44:50 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc

Removing a now irrelevant browser test and disabling 2 failing ones (in order to be able to run browser tests on the main build bots).

BUG=None
TEST=Run the SSL browser tests
Review URL: http://codereview.chromium.org/146039
------------------------------------------------------------------------
r19036 | thestig@chromium.org | 2009-06-23 20:32:37 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Report the process type in Linux crash reports.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147031
------------------------------------------------------------------------
r19035 | agl@chromium.org | 2009-06-23 20:29:11 +0200 (Tue, 23 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Linux: fix crash reporting for zygote model

Crash reporting broke on Linux when we enabled the zygote model a
couple of weeks ago.

We can't just add "zygote" to the check for the process type because
the crash signal fd is set at the same time and that will change when
a renderer is forked from the zygote.

This fixes it for now, but it will need to be redone when we enable
sandboxing.

http://codereview.chromium.org/147004
BUG=14969

------------------------------------------------------------------------
r19033 | idanan@chromium.org | 2009-06-23 20:02:23 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   A /trunk/src/chrome/browser/privacy_blacklist
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist.cc
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist.h
   A /trunk/src/chrome/browser/privacy_blacklist/blacklist_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Privacy Blacklist SketelonAdded code hooks to serve as place holders for the implementationof the privacy blacklist. The --privacy-blacklist option was addedwhich will eventually is used to activate the code.This is work-in-progress code which effectively makes a couple morepointer-checks when the --privacy-blacklist is not specified. Whenit is specified, some of the blacklist code is executed but theblacklist is always empty and therefore has no impact on browsing.

BUG=none
TEST=Blacklist*

Review URL: http://codereview.chromium.org/119313
------------------------------------------------------------------------
r19032 | sverrir@google.com | 2009-06-23 19:59:55 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_settings.cc

Scale the margins according to the DPI of the printer.  The margins were fixed at 500 units which caused the margins to be huge for low DPI (low quality) printing output.

BUG=http://crbug.com/14502
TEST=Print with different DPI settings and notice how the margins stay the same physical width.

Review URL: http://codereview.chromium.org/145008
------------------------------------------------------------------------
r19031 | sky@chromium.org | 2009-06-23 19:57:39 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Adds back BrowserWindowGtk::set_drag_active.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/147024
------------------------------------------------------------------------
r19027 | asargent@chromium.org | 2009-06-23 18:51:05 +0200 (Tue, 23 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Changes to ExtensionsService to support extensions auto-update.

This CL adds an UpdateExtension method to ExtensionsService along with a completion
callback for when the install is complete (or failed).

BUG=http://crbug.com/12117
BUG=http://crbug.com/12764
TEST=none

Review URL: http://codereview.chromium.org/140022
------------------------------------------------------------------------
r19026 | stuartmorgan@chromium.org | 2009-06-23 18:36:20 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/keychain_mac.cc
   M /trunk/src/chrome/browser/keychain_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Implement the add/update functionality for Keychain that PasswordStoreMac will
need, and modify MockKeychain slightly to allow unit testing it.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146002
------------------------------------------------------------------------
r19025 | jcampan@chromium.org | 2009-06-23 18:10:27 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc

Disabling a test (bug filed) that is crashing (I am not sure what the correct fix is).

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/145023
------------------------------------------------------------------------
r19023 | jeremy@chromium.org | 2009-06-23 18:00:25 +0200 (Tue, 23 Jun 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   A /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.mm
   A /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper_unittest.mm
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Re-land r18853

Review URL: http://codereview.chromium.org/141008
------------------------------------------------------------------------
r19022 | erikkay@google.com | 2009-06-23 17:39:12 +0200 (Tue, 23 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix build break (file missing from CL).

TBR=davemoore
BUG=none
TEST=build works

Review URL: http://codereview.chromium.org/146033
------------------------------------------------------------------------
r19019 | erikkay@google.com | 2009-06-23 16:52:13 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   D /trunk/src/chrome/browser/extensions/extension_shelf.cc
   D /trunk/src/chrome/browser/extensions/extension_shelf.h
   D /trunk/src/chrome/browser/extensions/extension_view.cc
   D /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   A /trunk/src/chrome/browser/views/extensions
   A /trunk/src/chrome/browser/views/extensions/extension_shelf.cc (from /trunk/src/chrome/browser/extensions/extension_shelf.cc:18845)
   A /trunk/src/chrome/browser/views/extensions/extension_shelf.h (from /trunk/src/chrome/browser/extensions/extension_shelf.h:18845)
   A /trunk/src/chrome/browser/views/extensions/extension_view.cc (from /trunk/src/chrome/browser/extensions/extension_view.cc:18843)
   A /trunk/src/chrome/browser/views/extensions/extension_view.h (from /trunk/src/chrome/browser/extensions/extension_view.h:18843)
   M /trunk/src/chrome/chrome.gyp

Move extension view classes from browser/extensions to browser/views/extensions.

BUG=11650
TEST=none

Review URL: http://codereview.chromium.org/140010
------------------------------------------------------------------------
r19015 | hbono@chromium.org | 2009-06-23 13:13:03 +0200 (Tue, 23 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/webkit/api/public/gtk/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp

Revert 19009 because this prevents inserting return characters.

TBR=evan
BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
TEST=none
Review URL: http://codereview.chromium.org/147010
------------------------------------------------------------------------
r19014 | abarth@chromium.org | 2009-06-23 12:19:13 +0200 (Tue, 23 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_impl.cc

Plumb a command line argument to enable the XSSAuditor.

TBR=darin
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/146023
------------------------------------------------------------------------
r19012 | yuzo@chromium.org | 2009-06-23 10:11:28 +0200 (Tue, 23 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer_unittest.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

For consistency, stop using the workarea coordinate in
saving/retrieving/adjusting window positions.

TEST=Open Chrome windows and see if they are placed properly.
TESTED=gcl try, manually
BUG=none


Review URL: http://codereview.chromium.org/141039
------------------------------------------------------------------------
r19011 | ukai@chromium.org | 2009-06-23 08:35:05 +0200 (Tue, 23 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/net/base/cert_verifier.cc
   M /trunk/src/net/base/cert_verifier.h
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/base/x509_certificate_unittest.cc
   M /trunk/src/net/base/x509_certificate_win.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/socket/ssl_client_socket_nss.cc
   M /trunk/src/net/socket/ssl_client_socket_win.cc

Use LOAD_VERIFY_EV_CERT to verify EV-ness in Verify().

If LOAD_VERIFY_EV_CERT is requested on load_flags
and revokation checking is performed, Verify() peforms
EV certificate verification as well, and sets
CERT_STATUS_IS_EV in verify_result.

Eliminate X509Certificate::IsEV()

BUG=3592
TEST=net_unittests with ALLOW_EXTERNAL_ACCESS=1, \
 visit https://www.thawte.com/ and shows EV info.

Review URL: http://codereview.chromium.org/125120
------------------------------------------------------------------------
r19010 | aa@chromium.org | 2009-06-23 08:21:08 +0200 (Tue, 23 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc

Re-enable the --enable-extensions flag. Fix a bug where the extensions.enable pref was not being honored. Add tests.

This is intended to be submitted after:
http://codereview.chromium.org/132003

BUG=13467
TEST=Added unit tests

Review URL: http://codereview.chromium.org/132045
------------------------------------------------------------------------
r19009 | hbono@chromium.org | 2009-06-23 07:35:02 +0200 (Tue, 23 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/webkit/api/public/gtk/WebInputEventFactory.h
   M /trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp

Integrating GtkIMContext into the RenderWidgetHostViewGtk class.This change implements signal handers of the GtkIMContext object to support IMEs and dead-keys. Also, to improve compatibility with Windows Chrome, this change emulates IPC messages sent on Windows when we input characters and fixes Issue 13604 as well as Issue 10953 and 11226. Even though I notice we need more work for fixing edge cases (e.g. disabling IMEs on a password input) on Linux, I think this is the good starting point. (Supporting edge-cases requires complicated code and it makes hard to review.)

BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form.
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form.
TEST=Change the keyboard layout to Hebrew (or Russian), open a web page which contains an <input> form, input some characters in the <input> form, type control+a, and see the text in the <input> form is selected.
Review URL: http://codereview.chromium.org/126118
------------------------------------------------------------------------
r19008 | aa@chromium.org | 2009-06-23 07:14:29 +0200 (Tue, 23 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/base/crypto/rsa_private_key_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Disable extensions besides externally installed ones and themes.

This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to
undo the damage is ready.

BUG=13467
TEST=Added unit tests

Review URL: http://codereview.chromium.org/132003
------------------------------------------------------------------------
r19003 | ben@chromium.org | 2009-06-23 04:26:16 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   D /trunk/src/chrome/browser/gtk/edit_keyword_controller.cc
   D /trunk/src/chrome/browser/gtk/edit_keyword_controller.h
   A /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.cc (from /trunk/src/chrome/browser/gtk/edit_keyword_controller.cc:19002)
   A /trunk/src/chrome/browser/gtk/edit_search_engine_dialog.h (from /trunk/src/chrome/browser/gtk/edit_keyword_controller.h:19002)
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   M /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   D /trunk/src/chrome/browser/search_engines/edit_keyword_controller_base.cc
   D /trunk/src/chrome/browser/search_engines/edit_keyword_controller_base.h
   A /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.cc (from /trunk/src/chrome/browser/search_engines/edit_keyword_controller_base.cc:19002)
   A /trunk/src/chrome/browser/search_engines/edit_search_engine_controller.h (from /trunk/src/chrome/browser/search_engines/edit_keyword_controller_base.h:19002)
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   D /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   D /trunk/src/chrome/browser/views/edit_keyword_controller.h
   A /trunk/src/chrome/browser/views/edit_search_engine_dialog.cc (from /trunk/src/chrome/browser/views/edit_keyword_controller.cc:19002)
   A /trunk/src/chrome/browser/views/edit_search_engine_dialog.h (from /trunk/src/chrome/browser/views/edit_keyword_controller.h:19002)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/test_browser_window.h

Rejiggers the keyword editor so that the UI is independent of the model rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/140054
------------------------------------------------------------------------
r19002 | jhawkins@chromium.org | 2009-06-23 03:40:25 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Remove TOOLKI_VIEWS cruft from tab_contents_view_gtk.cc now that it has its own TabContentsView implementation.

BUG=14469
TEST=none
Review URL: http://codereview.chromium.org/146010
------------------------------------------------------------------------
r19001 | estade@chromium.org | 2009-06-23 03:19:24 +0200 (Tue, 23 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc

Fix gcc-4.3 build

crome/browser/gtk/gtk_chrome_link_button.cc needs stdlib.h for free and malloc
on gcc-4.3

patch by Joel Stan <joel.stan@gmail.com>
original review: http://codereview.chromium.org/147002

------------------------------------------------------------------------
r18999 | arv@google.com | 2009-06-23 03:07:09 +0200 (Tue, 23 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/browser/resources/new_tab.html

Removes some duplicated code to use LocalStrings formatString instead
of manually formatting it.

BUG=14878

TEST=Open a new window with at least 2 tabs. Close it and go to the
NTP and it should say "2 tabs" under recently closed.

Review URL: http://codereview.chromium.org/144022
------------------------------------------------------------------------
r18997 | jhawkins@chromium.org | 2009-06-23 02:59:53 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc

Bring the potential drag destination window to the front when the mouse moves over the window.

BUG=none
TEST=Open two browser windows with multiple tabs.  Make sure the windows overlap.  Drag a tab from the top-level window into the frame of the other window.  The lower window should be raised after a delay.
Review URL: http://codereview.chromium.org/146004
------------------------------------------------------------------------
r18989 | arv@google.com | 2009-06-23 01:53:09 +0200 (Tue, 23 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   A /trunk/src/chrome/browser/dom_ui/shown_sections_handler.cc
   A /trunk/src/chrome/browser/dom_ui/shown_sections_handler.h
   A /trunk/src/chrome/browser/resources/new_new_tab.css
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   A /trunk/src/chrome/browser/resources/new_new_tab.js
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Update the New New Tab Page. There are still a lot of things that are
not implemented but it is time to get this submitted and iron out the
remaining issues.

BUG=13362

TEST=Start chrome with --new-new-tab-page and look at play arouind with
the new tab page.

Review URL: http://codereview.chromium.org/132027
------------------------------------------------------------------------
r18985 | willchan@chromium.org | 2009-06-23 01:26:44 +0200 (Tue, 23 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   D /trunk/src/net/base/client_socket.cc
   D /trunk/src/net/base/client_socket.h
   D /trunk/src/net/base/client_socket_factory.cc
   D /trunk/src/net/base/client_socket_factory.h
   D /trunk/src/net/base/client_socket_handle.cc
   D /trunk/src/net/base/client_socket_handle.h
   D /trunk/src/net/base/client_socket_pool.h
   D /trunk/src/net/base/socket.h
   D /trunk/src/net/base/socket_test_util.cc
   D /trunk/src/net/base/socket_test_util.h
   D /trunk/src/net/base/ssl_client_socket.h
   D /trunk/src/net/base/ssl_client_socket_mac.cc
   D /trunk/src/net/base/ssl_client_socket_mac.h
   D /trunk/src/net/base/ssl_client_socket_nss.cc
   D /trunk/src/net/base/ssl_client_socket_nss.h
   D /trunk/src/net/base/ssl_client_socket_unittest.cc
   D /trunk/src/net/base/ssl_client_socket_win.cc
   D /trunk/src/net/base/ssl_client_socket_win.h
   D /trunk/src/net/base/ssl_test_util.cc
   D /trunk/src/net/base/ssl_test_util.h
   D /trunk/src/net/base/tcp_client_socket.h
   D /trunk/src/net/base/tcp_client_socket_libevent.cc
   D /trunk/src/net/base/tcp_client_socket_libevent.h
   D /trunk/src/net/base/tcp_client_socket_pool.cc
   D /trunk/src/net/base/tcp_client_socket_pool.h
   D /trunk/src/net/base/tcp_client_socket_pool_unittest.cc
   D /trunk/src/net/base/tcp_client_socket_unittest.cc
   D /trunk/src/net/base/tcp_client_socket_win.cc
   D /trunk/src/net/base/tcp_client_socket_win.h
   D /trunk/src/net/base/tcp_pinger.h
   D /trunk/src/net/base/tcp_pinger_unittest.cc
   M /trunk/src/net/ftp/ftp_network_layer.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction_unittest.cc
   M /trunk/src/net/http/http_basic_stream.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   A /trunk/src/net/socket
   A /trunk/src/net/socket/client_socket.cc (from /trunk/src/net/base/client_socket.cc:18944)
   A /trunk/src/net/socket/client_socket.h (from /trunk/src/net/base/client_socket.h:18944)
   A /trunk/src/net/socket/client_socket_factory.cc (from /trunk/src/net/base/client_socket_factory.cc:18944)
   A /trunk/src/net/socket/client_socket_factory.h (from /trunk/src/net/base/client_socket_factory.h:18944)
   A /trunk/src/net/socket/client_socket_handle.cc (from /trunk/src/net/base/client_socket_handle.cc:18944)
   A /trunk/src/net/socket/client_socket_handle.h (from /trunk/src/net/base/client_socket_handle.h:18944)
   A /trunk/src/net/socket/client_socket_pool.h (from /trunk/src/net/base/client_socket_pool.h:18944)
   A /trunk/src/net/socket/socket.h (from /trunk/src/net/base/socket.h:18944)
   A /trunk/src/net/socket/socket_test_util.cc (from /trunk/src/net/base/socket_test_util.cc:18944)
   A /trunk/src/net/socket/socket_test_util.h (from /trunk/src/net/base/socket_test_util.h:18944)
   A /trunk/src/net/socket/ssl_client_socket.h (from /trunk/src/net/base/ssl_client_socket.h:18944)
   A /trunk/src/net/socket/ssl_client_socket_mac.cc (from /trunk/src/net/base/ssl_client_socket_mac.cc:18944)
   A /trunk/src/net/socket/ssl_client_socket_mac.h (from /trunk/src/net/base/ssl_client_socket_mac.h:18944)
   A /trunk/src/net/socket/ssl_client_socket_nss.cc (from /trunk/src/net/base/ssl_client_socket_nss.cc:18944)
   A /trunk/src/net/socket/ssl_client_socket_nss.h (from /trunk/src/net/base/ssl_client_socket_nss.h:18944)
   A /trunk/src/net/socket/ssl_client_socket_unittest.cc (from /trunk/src/net/base/ssl_client_socket_unittest.cc:18944)
   A /trunk/src/net/socket/ssl_client_socket_win.cc (from /trunk/src/net/base/ssl_client_socket_win.cc:18944)
   A /trunk/src/net/socket/ssl_client_socket_win.h (from /trunk/src/net/base/ssl_client_socket_win.h:18944)
   A /trunk/src/net/socket/ssl_test_util.cc (from /trunk/src/net/base/ssl_test_util.cc:18948)
   A /trunk/src/net/socket/ssl_test_util.h (from /trunk/src/net/base/ssl_test_util.h:18948)
   A /trunk/src/net/socket/tcp_client_socket.h (from /trunk/src/net/base/tcp_client_socket.h:18944)
   A /trunk/src/net/socket/tcp_client_socket_libevent.cc (from /trunk/src/net/base/tcp_client_socket_libevent.cc:18944)
   A /trunk/src/net/socket/tcp_client_socket_libevent.h (from /trunk/src/net/base/tcp_client_socket_libevent.h:18944)
   A /trunk/src/net/socket/tcp_client_socket_pool.cc (from /trunk/src/net/base/tcp_client_socket_pool.cc:18944)
   A /trunk/src/net/socket/tcp_client_socket_pool.h (from /trunk/src/net/base/tcp_client_socket_pool.h:18944)
   A /trunk/src/net/socket/tcp_client_socket_pool_unittest.cc (from /trunk/src/net/base/tcp_client_socket_pool_unittest.cc:18944)
   A /trunk/src/net/socket/tcp_client_socket_unittest.cc (from /trunk/src/net/base/tcp_client_socket_unittest.cc:18944)
   A /trunk/src/net/socket/tcp_client_socket_win.cc (from /trunk/src/net/base/tcp_client_socket_win.cc:18944)
   A /trunk/src/net/socket/tcp_client_socket_win.h (from /trunk/src/net/base/tcp_client_socket_win.h:18944)
   A /trunk/src/net/socket/tcp_pinger.h (from /trunk/src/net/base/tcp_pinger.h:18948)
   A /trunk/src/net/socket/tcp_pinger_unittest.cc (from /trunk/src/net/base/tcp_pinger_unittest.cc:18948)
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/DEPS
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Move socket related files from net/base to net/socket.
Review URL: http://codereview.chromium.org/144009
------------------------------------------------------------------------
r18983 | willchan@chromium.org | 2009-06-23 01:23:37 +0200 (Tue, 23 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Linux: Enable some more ui_tests.
Ignore the expected_crashes_ since Linux doesn't have crash_service.

Review URL: http://codereview.chromium.org/144014
------------------------------------------------------------------------
r18981 | jhawkins@chromium.org | 2009-06-23 01:22:12 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h

Hide the window frame when the last tab is dragged out of a tabstrip.

BUG=13838
TEST=Open two browser windows.  Drag one of the tabs into the other tabstrip.  The first browser window should disappear and the browser should not crash.
Review URL: http://codereview.chromium.org/145019
------------------------------------------------------------------------
r18980 | estade@chromium.org | 2009-06-23 01:19:48 +0200 (Tue, 23 Jun 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Move toolbar hotkeys to BrowserWindowGtk.

BUG=14113
TEST=the navigation hotkeys now work in fullscreen mode. Make sure the follownig all work:

  { GDK_Left, IDC_BACK, GDK_MOD1_MASK },
  { GDK_BackSpace, IDC_BACK, GdkModifierType(0) },
  { XF86XK_Back, IDC_BACK, GdkModifierType(0) },
  { GDK_Right, IDC_FORWARD, GDK_MOD1_MASK },
  { GDK_BackSpace, IDC_FORWARD, GDK_SHIFT_MASK },
  { XF86XK_Forward, IDC_FORWARD, GdkModifierType(0) },
  { GDK_r, IDC_RELOAD, GDK_CONTROL_MASK },
  { GDK_F5, IDC_RELOAD, GdkModifierType(0) },
  { GDK_F5, IDC_RELOAD, GDK_CONTROL_MASK },
  { XF86XK_Reload, IDC_RELOAD, GdkModifierType(0) },
  { XF86XK_Refresh, IDC_RELOAD, GdkModifierType(0) },

key: { button, action, modifier }, where MOD1 = alt

Review URL: http://codereview.chromium.org/145020
------------------------------------------------------------------------
r18978 | estade@chromium.org | 2009-06-23 01:18:48 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Support middle click navigation with infobar links.

http://crbug.com/14518
TEST=middle click on an infobar link, it should open in a new tab

Review URL: http://codereview.chromium.org/145013
------------------------------------------------------------------------
r18975 | ben@chromium.org | 2009-06-23 00:44:38 +0200 (Tue, 23 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/task_manager_gtk.cc (from /trunk/src/chrome/browser/task_manager_linux.cc:18919)
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   D /trunk/src/chrome/browser/task_manager_linux.cc
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   D /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/task_manager_view.cc (from /trunk/src/chrome/browser/task_manager_win.cc:18919)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/test_browser_window.h

Reorganize the way the task manager is constructed.

The BrowserWindow creates the task manager UI directly, which uses the TaskManager to populate itself.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/140044
------------------------------------------------------------------------
r18968 | erg@google.com | 2009-06-23 00:21:23 +0200 (Tue, 23 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc

GTK: Fixes regression where "Add Page..." didn't work and printed a NOTIMPLEMENTED() to the console.

http://crbug.com/14935

Review URL: http://codereview.chromium.org/145011
------------------------------------------------------------------------
r18967 | mhm@chromium.org | 2009-06-23 00:19:34 +0200 (Tue, 23 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Paste and Go was missing on the omnibar this CL will append a menu item to the current Autocomplete edit box and by using Gtk clipboard, it will paste and search it.

BUG=14800 (http://crbug.com/14800)

TEST=Selected text from view and right clicked copied. Went to the omnibox and right clicked > Paste and Go. It navigated to the page successfully.

Review URL: http://codereview.chromium.org/140050
------------------------------------------------------------------------
r18966 | ben@chromium.org | 2009-06-23 00:18:44 +0200 (Tue, 23 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

Fix the first run infobubble. It overrode WidgetWin's OnSize without calling down to it so the window was never laid out when it was initially created.

http://crbug.com/14637
TEST=first run bubble should not be black

Review URL: http://codereview.chromium.org/145006
------------------------------------------------------------------------
r18964 | aa@chromium.org | 2009-06-22 23:53:52 +0200 (Mon, 22 Jun 2009) | 1 line
Changed paths:
   M /trunk/src/base/crypto/rsa_private_key_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

TBR: Fix dead tree.
------------------------------------------------------------------------
r18963 | tc@google.com | 2009-06-22 23:38:36 +0200 (Mon, 22 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Always draw the blue gradient background, even if the custom frame
is off.  Only paint the custom frame png if the custom frame is
on.

This fixes a bug where the blue gradient wans't applied on the window-decoration version.

Review URL: http://codereview.chromium.org/145005

------------------------------------------------------------------------
r18962 | aa@chromium.org | 2009-06-22 23:32:10 +0200 (Mon, 22 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc

Re-enable the --enable-extensions flag. Fix a bug where the extensions.enable pref was not being honored. Add tests.

This is intended to be submitted after:
http://codereview.chromium.org/132003

BUG=13467
TEST=Added unit tests

Review URL: http://codereview.chromium.org/132045
------------------------------------------------------------------------
r18960 | erg@google.com | 2009-06-22 23:25:31 +0200 (Mon, 22 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.h

Add a TODO comment for later when I have more time. (hahaha)

Review URL: http://codereview.chromium.org/144005
------------------------------------------------------------------------
r18959 | aa@chromium.org | 2009-06-22 23:23:50 +0200 (Mon, 22 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/base/crypto/rsa_private_key_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Disable extensions besides externally installed ones and themes.

This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to
undo the damage is ready.

BUG=13467
TEST=Added unit tests

Review URL: http://codereview.chromium.org/132003
------------------------------------------------------------------------
r18958 | thestig@chromium.org | 2009-06-22 23:23:04 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Add support for XF86Back and friends. This is how it's done in Galeon.

BUG=11441
TEST=Try the non-standard browser keys on a keyboard that has them. I.e. the back and forward button on a Thinkpad.
Review URL: http://codereview.chromium.org/140081
------------------------------------------------------------------------
r18957 | tc@google.com | 2009-06-22 23:09:30 +0200 (Mon, 22 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix type.  Fixes the gcc4.3 build.

TBR=thestig

Review URL: http://codereview.chromium.org/144004

------------------------------------------------------------------------
r18954 | tc@google.com | 2009-06-22 22:56:15 +0200 (Mon, 22 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Move the titlebar background drawing from the titlebar to the
browser window.  This fixes a visual bug where the border looked
disconnected with the background.  This matches what Windows does.

BUG=14884

Review URL: http://codereview.chromium.org/140078

------------------------------------------------------------------------
r18952 | sky@chromium.org | 2009-06-22 22:45:33 +0200 (Mon, 22 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/grid.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h

Changes tab overview to create a window the max size it can possibly
be so that resize animations are not janktastic. TabOverviewContainer
only draws in the parts that are actually used so that it appears as
though the window is smaller than it is. This was needed as
moving/resizing bounds is way too expensive.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132059
------------------------------------------------------------------------
r18951 | estade@chromium.org | 2009-06-22 22:40:04 +0200 (Mon, 22 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Rebuild the bookmark context menu from scratch when selection changes.

Since the "remove" item always causes selection to change, we don't have to worry about trying to call remove twice with the same context menu.

TEST=see bug. Also, no new crashes on linux.
BUG=14443

Review URL: http://codereview.chromium.org/132048
------------------------------------------------------------------------
r18950 | evan@chromium.org | 2009-06-22 22:37:52 +0200 (Mon, 22 Jun 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/ipc_channel_handle.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

posix: two related changes to make plugin IPC work on POSIX.

[re-retry, seeing if reliability bots like it]

* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer).  For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.

This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket.  The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.

* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time.  So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.

Review URL: http://codereview.chromium.org/113157
------------------------------------------------------------------------
r18949 | jhawkins@chromium.org | 2009-06-22 22:34:35 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Revert to enumerating all X windows if the Window Manager doesn't support _NET_CLIENT_LIST_STACKING.

BUG=14004
TEST=Drag tabs in and out of tabstrip in xmonad window manager.
Review URL: http://codereview.chromium.org/141061
------------------------------------------------------------------------
r18947 | pkasting@chromium.org | 2009-06-22 22:25:10 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

More CHECKs in my continuing effort to figure out what is going on.  Neither Ben nor I can get this one.

BUG=13500
TEST=none
Review URL: http://codereview.chromium.org/140009
------------------------------------------------------------------------
r18944 | jam@chromium.org | 2009-06-22 21:40:53 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/common/child_process_host.cc

Cancel all pending requests when a worker goes away.

BUG=14753

Review URL: http://codereview.chromium.org/140039
------------------------------------------------------------------------
r18938 | shess@chromium.org | 2009-06-22 21:27:13 +0200 (Mon, 22 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm

Returned rect was never being set for OnGetRootWindowRect().

http://crbug.com/14770
TEST=See bug.

Review URL: http://codereview.chromium.org/140011
------------------------------------------------------------------------
r18933 | pinkerton@chromium.org | 2009-06-22 21:21:46 +0200 (Mon, 22 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Correct logic that changes throbber states such that it will stay in the "wait" state for the correct period of time.
BUG=none
TEST=none, code not yet enabled
Review URL: http://codereview.chromium.org/141051
------------------------------------------------------------------------
r18930 | erg@google.com | 2009-06-22 21:03:31 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   M /trunk/src/chrome/browser/login_prompt_gtk.cc

GTK: Polish HTTP Auth UI. Adds standard border and word wraps the label.

http://crbug.com/11512

Review URL: http://codereview.chromium.org/140076
------------------------------------------------------------------------
r18928 | stuartmorgan@chromium.org | 2009-06-22 20:50:23 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Switch to using FilePath as long as possible for LoginDatabase, and do the conversion to std::string correctly for all platforms.

BUG=14641
TEST=LoginDatabase unit tests should build and run on Windows
Review URL: http://codereview.chromium.org/139005
------------------------------------------------------------------------
r18927 | tc@google.com | 2009-06-22 20:42:29 +0200 (Mon, 22 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   M /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Add the ability to resize the window when over the custom frame.

I also switched from 3px borders to 4px borders because that's what they are
on windows.  On linux, the borders look bigger because our webcontent area
doesn't drop a shadow.

For this to work for resizing on top, I had to remove the event box from
the browser titlebar and move the mouse event handling to the window.

BUG=14645

Review URL: http://codereview.chromium.org/140026

------------------------------------------------------------------------
r18926 | rohitrao@chromium.org | 2009-06-22 20:41:34 +0200 (Mon, 22 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Adds a missing call to TabContents::WasHidden() on Mac.
Consolidates the WasHidden/DidBecomeSelected logic into a single method.

This change is needed to make the hung renderer dialog disappear when
switching tabs.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/141048
------------------------------------------------------------------------
r18925 | avi@chromium.org | 2009-06-22 20:34:10 +0200 (Mon, 22 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/theme_provider.cc
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   A /trunk/src/chrome/browser/browser_theme_provider_mac.mm
   M /trunk/src/chrome/chrome.gyp

Theme image support for the Mac.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/140007
------------------------------------------------------------------------
r18924 | jcampan@chromium.org | 2009-06-22 20:33:43 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

By user request, focus should go to the location bar when about:blank is the default new tab page.

BUG=9966
TEST=Make "about:blank" your home page. Open a new tab. It should be showing about:blank and the location bar should be focused. 
Review URL: http://codereview.chromium.org/141028
------------------------------------------------------------------------
r18922 | mattm@chromium.org | 2009-06-22 20:32:13 +0200 (Mon, 22 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/edit_keyword_controller.cc

gtk EditKeywordController properly enables controls when created without a TemplateURL
(when creating with one, the entry changed signal would do it.)

BUG=13326

Review URL: http://codereview.chromium.org/141025
------------------------------------------------------------------------
r18919 | mattm@chromium.org | 2009-06-22 20:23:34 +0200 (Mon, 22 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/list_store_favicon_loader.cc
   A /trunk/src/chrome/browser/gtk/list_store_favicon_loader.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/chrome.gyp

Refactor the favicon loader out of gtk/options/general_page_gtk to gtk/list_store_favicon_loader,
so that it can be used by the url_picker_dialog_gtk as well.

BUG=11507

Review URL: http://codereview.chromium.org/141035
------------------------------------------------------------------------
r18918 | jcampan@chromium.org | 2009-06-22 20:07:29 +0200 (Mon, 22 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h

Landing Thiago Farina bug fix for the saved password dialog.

See http://codereview.chromium.org/125239

BUG=7863
TEST=See bug
TBR=ben
Review URL: http://codereview.chromium.org/142001
------------------------------------------------------------------------
r18916 | mattm@chromium.org | 2009-06-22 20:02:51 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/keyword_editor_view.cc
   A /trunk/src/chrome/browser/gtk/keyword_editor_view.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/chrome.gyp

Add a (non functional) gtk KeywordEditorWindow and hook it up in the relevant places.

BUG=13326

Review URL: http://codereview.chromium.org/141026
------------------------------------------------------------------------
r18915 | thestig@chromium.org | 2009-06-22 19:58:51 +0200 (Mon, 22 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Flip red and blue channels for painting in 24-bit bpp without Xrender.

Also clean up the code a bit.

BUG=12206
TEST=Start VNC4 with -depth 24, make sure Chromium displays red and blue coorectly on webpages.
Review URL: http://codereview.chromium.org/126256
------------------------------------------------------------------------
r18910 | finnur@chromium.org | 2009-06-22 19:26:38 +0200 (Mon, 22 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Adding the ability to remove page actions.BUG=NoneTEST=unit test.
Review URL: http://codereview.chromium.org/131003
------------------------------------------------------------------------
r18908 | pinkerton@chromium.org | 2009-06-22 19:13:46 +0200 (Mon, 22 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Only show tooltip when window is key.
BUG=14707
TEST=Tooltips shouldn't cause the main window to appear over the about panel. Alll other tooltip behavior should remain the same.
Review URL: http://codereview.chromium.org/140067
------------------------------------------------------------------------
r18905 | evan@chromium.org | 2009-06-22 17:31:15 +0200 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/ipc_channel_handle.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Revert "posix: two related changes to make plugin IPC work on POSIX."

This looks like it might be to blame for reliability test failures,
so I'm trying it out.
This reverts commit r18888.
------------------------------------------------------------------------
r18904 | nsylvain@chromium.org | 2009-06-22 17:27:45 +0200 (Mon, 22 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/focus/external_focus_tracker.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   D /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   D /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/accelerator_handler.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_win.cc

Revert :

Changed by: jcampan@chromium.org
Changed at: Fri 19 Jun 2009 21:22:47
Branch: src
Revision: 18889
Comments:
Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben
Review URL: http://codereview.chromium.org/141013

Because it creates hundreds of new reliability crashes.

TBR:jcampan

Review URL: http://codereview.chromium.org/140064
------------------------------------------------------------------------
r18903 | aa@chromium.org | 2009-06-22 17:23:10 +0200 (Mon, 22 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc

Fix bug where content scripts are not run if they are in
extensions that are loaded after EXTENSIONS_READY.

Review URL: http://codereview.chromium.org/140065
------------------------------------------------------------------------
r18901 | hbono@chromium.org | 2009-06-22 11:19:37 +0200 (Mon, 22 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc

A quick fix for Issue 3803.
I noticed a Font dialog used the system locale (not the application locale) to display the localzed font name of a CJK font, i.e. we can retrieve this localized font name with a GetTextFace() call. This change just retrieves the localized font name of the given font with a GetTextFace() call before initializing a CHOOSEFONT object.

BUG=3803 <http://crbug.com/3803>
TEST=run Chrome on Simplified Chinese XP; open the "Fonts and Languages" dialog;click the "Change" for "Sans-Serif Font", and; verify its "font" editbox shows the localized font-name of "simsun".
Review URL: http://codereview.chromium.org/119416
------------------------------------------------------------------------
r18900 | mhm@chromium.org | 2009-06-22 04:02:39 +0200 (Mon, 22 Jun 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/fonts_languages_window.h
   A /trunk/src/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Fonts and Languages Linux GTK Preparation

Rearranged the windows and mac ports to use the cross platform interfaces. Updated windows fonts and languages to use those interfaces. As well, created stubs for mac platform.

BUG=13524 (http://crbug.com/13524)
TEST=Open a webpage with a textfield, right click and choose Spell checker options > Language Settings. Tested this on windows as well.

Review URL: http://codereview.chromium.org/140043
------------------------------------------------------------------------
r18897 | levin@chromium.org | 2009-06-22 01:22:57 +0200 (Mon, 22 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context_unittest.cc

Re-enable the print unit tests.

BUG=none
TEST=none, just re-enabling some disabled tests.

Review URL: http://codereview.chromium.org/113789
------------------------------------------------------------------------
r18895 | mirandac@chromium.org | 2009-06-20 22:07:24 +0200 (Sat, 20 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Colors status bubble according to theme.

BUG=http://crbug.com/14763
TEST=Enable themes; status bubble color should reflect changed theme.  Otherwise, status bubble color should not change.

Review URL: http://codereview.chromium.org/140016
------------------------------------------------------------------------
r18892 | mhm@chromium.org | 2009-06-20 08:21:20 +0200 (Sat, 20 Jun 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/options/content_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/content_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Add Personal Stuff tab page to Options in Linux.

Following the same approach as the general tab page..

BUG=11507
TEST=The Personal stuff tab is fully functioning, the prefs save correctly.

Review URL: http://codereview.chromium.org/125105
------------------------------------------------------------------------
r18891 | thakis@chromium.org | 2009-06-20 08:16:38 +0200 (Sat, 20 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Fix download shelf display bug.

BUG=14783
TEST=Download more than one thing. Shelf shouldn't get bigger everytime an item is added.

Review URL: http://codereview.chromium.org/140041

Review URL: http://codereview.chromium.org/140041
------------------------------------------------------------------------
r18889 | jcampan@chromium.org | 2009-06-20 06:22:44 +0200 (Sat, 20 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/constrained_window_win.cc
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/focus/external_focus_tracker.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   A /trunk/src/views/focus/focus_manager_gtk.cc (from /trunk/src/views/focus/focus_manager_gtk.cc:18872)
   M /trunk/src/views/focus/focus_manager_unittest.cc
   A /trunk/src/views/focus/focus_manager_win.cc (from /trunk/src/views/focus/focus_manager_win.cc:18872)
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/accelerator_handler.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_win.cc

Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben
Review URL: http://codereview.chromium.org/141013
------------------------------------------------------------------------
r18888 | evan@chromium.org | 2009-06-20 05:10:51 +0200 (Sat, 20 Jun 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/ipc_channel_handle.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

posix: two related changes to make plugin IPC work on POSIX.

[retry, fix windows compile failure]

* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer).  For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.

This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket.  The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.

* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time.  So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.

Review URL: http://codereview.chromium.org/113157
------------------------------------------------------------------------
r18887 | mattm@chromium.org | 2009-06-20 04:40:21 +0200 (Sat, 20 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc

Make gtk url picker and edit keyword view modal.

Don't like that GTK only does app-modal rather than window modal, but otherwise you can just close the parent window and crash when you then click okay on the dialog.

BUG=11507

Review URL: http://codereview.chromium.org/141020
------------------------------------------------------------------------
r18885 | aa@chromium.org | 2009-06-20 03:39:23 +0200 (Sat, 20 Jun 2009) | 1 line
Changed paths:
   M /trunk/src/base/crypto/rsa_private_key_win.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

TBR: Add more logging to try and track down flakey crypto tests.
------------------------------------------------------------------------
r18881 | mpcomplete@google.com | 2009-06-20 02:45:48 +0200 (Sat, 20 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc

Disable some flaky UI tests in windows Debug.

BUG=14774
TEST=no
Review URL: http://codereview.chromium.org/140032
------------------------------------------------------------------------
r18878 | ben@chromium.org | 2009-06-20 01:31:01 +0200 (Sat, 20 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Second attempt to land this. This time it compiles on windows, too.

Resuscitate the TOOLKIT_VIEWS build by disabling stuff we don't build yet.

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141012
------------------------------------------------------------------------
r18873 | jcampan@chromium.org | 2009-06-20 01:08:41 +0200 (Sat, 20 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   D /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/focus/external_focus_tracker.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   D /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   D /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/accelerator_handler.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_win.cc

Reverting 18872.
Broke the Windows build.

BUG=None
TEST=None
TBR=ben

Review URL: http://codereview.chromium.org/140023
------------------------------------------------------------------------
r18872 | jcampan@chromium.org | 2009-06-20 00:57:54 +0200 (Sat, 20 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   A /trunk/src/chrome/browser/views/constrained_window_impl.cc (from /trunk/src/chrome/browser/views/constrained_window_impl.cc:18826)
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/focus/external_focus_tracker.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   A /trunk/src/views/focus/focus_manager_gtk.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   A /trunk/src/views/focus/focus_manager_win.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/accelerator_handler.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window_win.cc

Removed the last Windows specific part out of the focus manager. HWNDs are not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully  test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog.
Review URL: http://codereview.chromium.org/125148
------------------------------------------------------------------------
r18871 | cpu@google.com | 2009-06-20 00:55:47 +0200 (Sat, 20 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/result_codes.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h

Finish the wiring of the inactive user toast experiment
- Adds read-write to the client key of google_update
- Adds the logic to track experiment outcome
- Some new geric exitc codes (non error codes)

BUG= b/1484308
TEST= see the bug


Review URL: http://codereview.chromium.org/132058
------------------------------------------------------------------------
r18869 | ben@chromium.org | 2009-06-20 00:32:51 +0200 (Sat, 20 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Reverting 18865.
Review URL: http://codereview.chromium.org/140020
------------------------------------------------------------------------
r18868 | ben@chromium.org | 2009-06-20 00:31:09 +0200 (Sat, 20 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Reverting 18866.
Review URL: http://codereview.chromium.org/141006
------------------------------------------------------------------------
r18867 | jcampan@chromium.org | 2009-06-20 00:25:44 +0200 (Sat, 20 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h

When initially focused, the DOMUI (used for Gears dialog) would not focus the tab correctly.

BUG=14126
TEST=Use the "Create application shortcut..." menu to bring up the Gears dialog. Press tab, the focus should move around. Press ESC, the dialog should close.
Review URL: http://codereview.chromium.org/140001
------------------------------------------------------------------------
r18866 | ben@chromium.org | 2009-06-20 00:25:38 +0200 (Sat, 20 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Fix bustage... need to include this header directly after all.

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140017
------------------------------------------------------------------------
r18865 | ben@chromium.org | 2009-06-20 00:23:22 +0200 (Sat, 20 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Fixes for TOOLKIT_VIEWS build. Disable stuff that we know isn't working so far.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140014
------------------------------------------------------------------------
r18864 | erg@google.com | 2009-06-20 00:16:28 +0200 (Sat, 20 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/browser/gtk/constrained_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/constrained_window_gtk.h
   A /trunk/src/chrome/browser/login_prompt_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   D /trunk/src/chrome/browser/views/constrained_window_impl.cc
   D /trunk/src/chrome/browser/views/constrained_window_impl.h
   A /trunk/src/chrome/browser/views/constrained_window_win.cc (from /trunk/src/chrome/browser/views/constrained_window_impl.cc:18861)
   A /trunk/src/chrome/browser/views/constrained_window_win.h (from /trunk/src/chrome/browser/views/constrained_window_impl.h:18861)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

GTK: HTTP Auth dialogs under linux.

- Implements a ConstrainedWindowGtk which positions itself in the center of its corresponding TabContentsViewGtk.
- Implements LoginPromptGtk. HTTP Auth now works under Linux.
- Renames ConstrainedWindowImpl to ConstrainedWindowWin

http://crbug.com/11512

Review URL: http://codereview.chromium.org/132047
------------------------------------------------------------------------
r18860 | erg@google.com | 2009-06-20 00:08:49 +0200 (Sat, 20 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/gtk_floating_container.cc

Attempt to fix weird crasher in gtk_floating_container_forall by checking more input and calling parent class forall.

http://crbug.com/14485

Review URL: http://codereview.chromium.org/141004
------------------------------------------------------------------------
r18857 | mpcomplete@google.com | 2009-06-20 00:05:10 +0200 (Sat, 20 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Disable some UI tests on Linux due to crashiness and/or flakiness:
- SavePageTest.SaveHTMLOnly
- SavePageTest.SaveCompleteHTML
- DownloadTest.UnknownSize
- DownloadTest.IncognitoDownload

BUG=14746,14755
TEST=no
Review URL: http://codereview.chromium.org/139006
------------------------------------------------------------------------
r18856 | jeremy@chromium.org | 2009-06-20 00:02:10 +0200 (Sat, 20 Jun 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   D /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.mm
   D /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper_unittest.mm
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

back out r18853

This reverts commit f2f30e9d0108f4a776672c6b29d25ed3a8ad19ad.

Review URL: http://codereview.chromium.org/140013
------------------------------------------------------------------------
r18853 | jeremy@chromium.org | 2009-06-19 23:10:08 +0200 (Fri, 19 Jun 2009) | 12 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.h
   A /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper.mm
   A /trunk/src/chrome/browser/cocoa/rwhvm_editcommand_helper_unittest.mm
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

This patch adds Cocoa editing selectors to the RenderViewWidgetHostMac class.

This makes us a better citizen in OSX text-editing land and is a first step in getting our text entry story to work more natively on OSX.

The selectors are added at runtime to the Cocoa class and invoking them causes the appropriate WebKit core command to be invoked on the currently focused WebFrame.

As a side-effect bug 10862 is fixed.

BUG=10862
TEST=Open a new tab and type some text into an input element, change to a Hebrew keyboard layout and hit command-a, all text should be selected.

Review URL: http://codereview.chromium.org/114070
------------------------------------------------------------------------
r18852 | nsylvain@chromium.org | 2009-06-19 23:07:40 +0200 (Fri, 19 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc

Increase timeout in url_fetchet to make it more
friendly when running in purify.

Review URL: http://codereview.chromium.org/139004
------------------------------------------------------------------------
r18851 | evan@chromium.org | 2009-06-19 22:56:46 +0200 (Fri, 19 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/ipc_channel_handle.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Revert "posix: two related changes to make plugin IPC work on POSIX."

This reverts commit r18850, as it had a compile failure.
------------------------------------------------------------------------
r18850 | evan@chromium.org | 2009-06-19 22:50:09 +0200 (Fri, 19 Jun 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/ipc_channel_handle.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

posix: two related changes to make plugin IPC work on POSIX.

* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer).  For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.

This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket.  The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.

* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time.  So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.

Review URL: http://codereview.chromium.org/113157
------------------------------------------------------------------------
r18845 | erikkay@google.com | 2009-06-19 22:19:13 +0200 (Fri, 19 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_prefs.cc
   M /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/common/notification_type.h

part 3 of toolstrip dragging - persist the drag order
Also notify other browser windows of changes to the order.

BUG=http://code.google.com/p/chromium/issues/detail?id=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest.*


Review URL: http://codereview.chromium.org/131114
------------------------------------------------------------------------
r18843 | jhawkins@chromium.org | 2009-06-19 22:00:09 +0200 (Fri, 19 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Remove ourselves as a message loop observer in the tabstrip destructor to catch the case when the user closes the last tab in a tabstrip.  In this case, we add ourselves as a message loop observer and never get a chance to remove ourselves before the tabstrip is destroyed.

BUG=14648
TEST=Open a new window and press the close button on the tab.  The browser should not crash.
Review URL: http://codereview.chromium.org/140006
------------------------------------------------------------------------
r18842 | mirandac@chromium.org | 2009-06-19 21:57:35 +0200 (Fri, 19 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/web_resource_handler.cc
   M /trunk/src/chrome/browser/dom_ui/web_resource_handler.h
   M /trunk/src/chrome/browser/web_resource/web_resource_service.cc

First draft of web resource service; fetches data from a JSON feed 
and stores it in user prefs, where it can be used by the new tab page.

BUG = http://crbug.com/13363


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18766
Review URL: http://codereview.chromium.org/125052
------------------------------------------------------------------------
r18840 | paul@chromium.org | 2009-06-19 21:33:15 +0200 (Fri, 19 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Enable DownloadRequestManager for Mac.

DownloadRequestManager is the object that manages the number of downloads
that can occur in a given tab. It throttles non-user initiated downloads
to prevent carpet-bombing download attacks.

Enabling this object for Mac fixes the issue where we can only download
one file in a given tab.

BUG=None (mac work).
TEST=Can now download more than one item in a tab.

Review URL: http://codereview.chromium.org/132039
------------------------------------------------------------------------
r18837 | aa@chromium.org | 2009-06-19 21:03:41 +0200 (Fri, 19 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

TBR: Fix Toolstrips sometimes show scrollbars as rendering

See: http://codereview.chromium.org/126098
Patch from Jerry Tang <tangjie@google.com>.
------------------------------------------------------------------------
r18834 | evan@chromium.org | 2009-06-19 20:23:50 +0200 (Fri, 19 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

linux: make extensions service test pass in Debug.

It only passes on the build bots because they still have old directories, I
think?  AbsolutePath() on POSIX will fail if the path doesn't exist.  We let
the program march on in that case and the normal error handling (that would
handle the non-existent path) make the tests continue to pass.

Review URL: http://codereview.chromium.org/132054
------------------------------------------------------------------------
r18831 | thakis@chromium.org | 2009-06-19 20:15:59 +0200 (Fri, 19 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/DownloadShelf.xib
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   M /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm

Add "Show all downloads" link to download shelf.

BUG=14665
TEST=Download something, check that "show all downloads" text is on
shelf, click it, check that the downloads tab opens.

Review URL: http://codereview.chromium.org/132073

------------------------------------------------------------------------
r18827 | cpu@google.com | 2009-06-19 19:57:39 +0200 (Fri, 19 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Use correct calling convention for intercepted call
- Thanks to zhu.she.pi@gmail.com for finding the bug

BUG=14631
TEST=no test

Review URL: http://codereview.chromium.org/131066
------------------------------------------------------------------------
r18825 | stuartmorgan@chromium.org | 2009-06-19 19:33:28 +0200 (Fri, 19 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Add merging algorithm for keychain and metadata db PasswordForms, and unit tests for it.
Not used quite yet, since the metadata database still needs to be integrated into PasswordStoreMac.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131076
------------------------------------------------------------------------
r18823 | jhawkins@chromium.org | 2009-06-19 19:28:32 +0200 (Fri, 19 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Fix a leak when we bail out early because of the wrong bpp.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131118
------------------------------------------------------------------------
r18822 | pinkerton@chromium.org | 2009-06-19 19:23:06 +0200 (Fri, 19 Jun 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Fix compile error.
------------------------------------------------------------------------
r18821 | pinkerton@chromium.org | 2009-06-19 19:08:06 +0200 (Fri, 19 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Make escape close the prefs window.
BUG=none
TEST=fields in the middle of being editing should not save the value.
Review URL: http://codereview.chromium.org/131113
------------------------------------------------------------------------
r18819 | wtc@chromium.org | 2009-06-19 19:00:02 +0200 (Fri, 19 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a temporary command-line switch --auto-ssl-client-auth for
automatically selecting a client certificate when an SSL server
requests client authentication.

This switch will be removed when we implement client certificate
selection UI.

Also fix some cpplint.py nits.

R=jcampan
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/131090
------------------------------------------------------------------------
r18817 | pfeldman@chromium.org | 2009-06-19 18:19:28 +0200 (Fri, 19 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

DevTools: Enable 'Inspect element' on chromeui content while in debug mode.

Review URL: http://codereview.chromium.org/132071
------------------------------------------------------------------------
r18816 | kuchhal@chromium.org | 2009-06-19 18:14:58 +0200 (Fri, 19 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h

Linux: make import warning dialog modal.

Make ImporterHost aware of the current parent window and use that
as parent for the warning dialog.

BUG=13481
TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal.

Review URL: http://codereview.chromium.org/131080
------------------------------------------------------------------------
r18815 | sverrir@google.com | 2009-06-19 17:58:01 +0200 (Fri, 19 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/page_range.cc
   M /trunk/src/chrome/browser/printing/page_range.h
   M /trunk/src/chrome/browser/printing/page_range_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview_impl.cc

Add Print Selection support to Chrome.  This change is fairly involved since this means that the printing is done async instead of the fully synchronous mode the normal full page printing is.
This means we create an in memory copy of the selected text for printing.
This is the next step to move to fully async printing with print frame support.
This change also removes the print on demand functionality that was no longer used.

BUG=http://crbug.com/1682
TEST=The print dialog on Windows now contains an option to print selection only.  Test that with various pages and various selections.


Review URL: http://codereview.chromium.org/125082
------------------------------------------------------------------------
r18809 | phajdan.jr@chromium.org | 2009-06-19 15:56:25 +0200 (Fri, 19 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/common/notification_type.h

Display an infobar alert when extension process crashes.

Also correctly handle crashes in task manager. The infobar allows user to restart the extension process.

TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash.

http://crbug.com/14111

Review URL: http://codereview.chromium.org/126289
------------------------------------------------------------------------
r18806 | pinkerton@chromium.org | 2009-06-19 15:28:24 +0200 (Fri, 19 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Implement restoring closed tab menu item. Reworked cross-platform code to handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode".
BUG=13758
TEST=restoring closed tabs with visible windows and with no windows remaining open.
Review URL: http://codereview.chromium.org/125257
------------------------------------------------------------------------
r18795 | yuzo@chromium.org | 2009-06-19 08:20:48 +0200 (Fri, 19 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

Fix: New window appears to the left/up if the taskbar is on left/top.

Currently, the Windows taskbar (put differently, work area) is not considered
in getting the last window bounds (while it is for the saved window bounds).
This causes new windows (CTRL-N) appear to the left/up of the existing window
instead of right/down, if the taskbar is on left or top.

TESTED=gcl try, manually

TEST=Place the taskbar on left or top of the screen and create new Chrome windows by CTRL-N and observe.

BUG=14131

Review URL: http://codereview.chromium.org/125179
------------------------------------------------------------------------
r18794 | jar@chromium.org | 2009-06-19 08:10:37 +0200 (Fri, 19 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

When we upgrade, discard all uploadable stats, including old logs

We already discard all stability info when we do an upgrade to a new
version, as there is less concern about stats from old versions. This
change just adds the list of "old logs" (gathered in previous sessions,
presumably with an old version) to the list of data that is discarded.

BUG=14657

r=evanm
Review URL: http://codereview.chromium.org/131089
------------------------------------------------------------------------
r18791 | jcampan@chromium.org | 2009-06-19 07:06:11 +0200 (Fri, 19 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc

This is a fix for a memory leak.
AutocompletePopupWin would be leaked when the browser view is closed.

BUG=None
TEST=Make sure Chrome can be opened/closed without crasher.
Review URL: http://codereview.chromium.org/132050
------------------------------------------------------------------------
r18790 | yuzo@chromium.org | 2009-06-19 06:24:20 +0200 (Fri, 19 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Change URL back to the previous one if the typed URL causes file download.

This is the successor to http://codereview.chromium.org/115704

TESTED=manually

TEST=Type any URL that causes download, e.g.,
ftp://ftp.vim.org/pub/vim/pc/gvim72.zip into the omnibox.
Without this change the URL remains there. With this change,
the URL is changed back to the original one.

BUG=1904


Review URL: http://codereview.chromium.org/126266
------------------------------------------------------------------------
r18788 | jcampan@chromium.org | 2009-06-19 06:22:19 +0200 (Fri, 19 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc

A crasher from the field seems to indicate that the page render widget host view win can get the focus after the TabContents delegate has been NULLed.

BUG=http://crbug.com/14599
TEST=Exercise closing tabs with on-unload handlers.
Review URL: http://codereview.chromium.org/132052
------------------------------------------------------------------------
r18786 | estade@chromium.org | 2009-06-19 05:28:11 +0200 (Fri, 19 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Implement window open disposition for (some) navigation buttons.

still need to do similar for link buttons and such.

BUG=14518

Review URL: http://codereview.chromium.org/131071
------------------------------------------------------------------------
r18785 | estade@chromium.org | 2009-06-19 05:27:47 +0200 (Fri, 19 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Don't treat underscores as mnemonics in the bookmark bar.

BUG=14438
TEST=see bug

Review URL: http://codereview.chromium.org/132049
------------------------------------------------------------------------
r18784 | jar@chromium.org | 2009-06-19 04:51:42 +0200 (Fri, 19 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/greasemonkey_api.js
   M /trunk/src/chrome/renderer/resources/json_schema.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Revert 18765 to try to repair perf regression

TBR=mpcomplete
Review URL: http://codereview.chromium.org/131093
------------------------------------------------------------------------
r18782 | jar@chromium.org | 2009-06-19 03:58:51 +0200 (Fri, 19 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

Revert 18730 in attempt to repair Linux UI build bustage.

tbr=tc
Review URL: http://codereview.chromium.org/132055
------------------------------------------------------------------------
r18780 | jhawkins@chromium.org | 2009-06-19 02:09:23 +0200 (Fri, 19 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Render the dragged tab contents when detaching a tab from the tabstrip in gtk.

BUG=none
TEST=Drag a tab out of the tabstrip.  If the WM has compositing enabled, the dragged tab contents should be translucent; otherwise, the contents should be opaque.
Review URL: http://codereview.chromium.org/131042
------------------------------------------------------------------------
r18779 | estade@chromium.org | 2009-06-19 02:05:49 +0200 (Fri, 19 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/icon_loader_linux.cc

linux: Load icons with gdk instead of using PNGDecoder.

BUG=14487

Review URL: http://codereview.chromium.org/131058
------------------------------------------------------------------------
r18778 | estade@chromium.org | 2009-06-19 02:05:30 +0200 (Fri, 19 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Clean up BrowserWindowGtk constructor.

Review URL: http://codereview.chromium.org/131062
------------------------------------------------------------------------
r18777 | kuchhal@chromium.org | 2009-06-19 02:03:49 +0200 (Fri, 19 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc

Linux crash fix.

If no browser profile is found from which we can import, disable the import
button. This was not problem on Windows since we always had IE.

BUG=14489
TEST=Rename your Firefox profile dir (~/.mozilla/firefox) and make sure that the import button is disabled on the import dialog box.

Review URL: http://codereview.chromium.org/131075
------------------------------------------------------------------------
r18776 | mattm@chromium.org | 2009-06-19 02:02:44 +0200 (Fri, 19 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Handle middle click on gtk tab close button.

BUG=14636
TEST=middle click on tab close button, left click on tab close button

Review URL: http://codereview.chromium.org/131072
------------------------------------------------------------------------
r18775 | finnur@chromium.org | 2009-06-19 02:00:49 +0200 (Fri, 19 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Fix crash in LocationBarView when accessing TabContents.

The LocationBarView asks its delegate (the ToolbarView) for a pointer to TabContents. The problem is, the ToolbarView is keeping an internal pointer to TabContents, and that pointer is not getting cleared when the last tab goes away. This can lead to shutdown crashes, which is what I think is happening in the crash in bug 14601. 

This is a speculative fix because we can't reproduce, but according to the dis-assembly we access a corrupt STL struct through a non-null TabContents pointer, which makes sense if the TabContents pointer is not getting cleared (or if the STL struct is being modified through multiple threads, which I have verified it is not).

BUG=14601
TEST=Cannot reproduce, we'll have to watch the crash reports as they come in to see if the crash is fixed.

Review URL: http://codereview.chromium.org/132043
------------------------------------------------------------------------
r18773 | tc@google.com | 2009-06-19 01:53:45 +0200 (Fri, 19 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix a bug where the window would not be shaped properly when
dragging a new tab out.  It would sometimes not be shaped properly
when opening a new window.

The code to update the window frame looks to see if the window is
maximized.  state_ contains information as to whether or not
we're maximized, but it wasn't set yet resulting in a UMR.

Review URL: http://codereview.chromium.org/131079

------------------------------------------------------------------------
r18767 | tc@google.com | 2009-06-19 01:04:47 +0200 (Fri, 19 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Fix tab strip paint regression for tabs other than the first tab.

X is already offset when we call SetBounds, so we only need to
handle y offset.

Review URL: http://codereview.chromium.org/131073

------------------------------------------------------------------------
r18766 | mirandac@chromium.org | 2009-06-19 01:02:54 +0200 (Fri, 19 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   A /trunk/src/chrome/browser/dom_ui/web_resource_handler.cc
   A /trunk/src/chrome/browser/dom_ui/web_resource_handler.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   A /trunk/src/chrome/browser/web_resource
   A /trunk/src/chrome/browser/web_resource/web_resource_service.cc
   A /trunk/src/chrome/browser/web_resource/web_resource_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/web_resource
   A /trunk/src/chrome/common/web_resource/web_resource_unpacker.cc
   A /trunk/src/chrome/common/web_resource/web_resource_unpacker.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/utility/utility_thread.cc
   M /trunk/src/chrome/utility/utility_thread.h

First draft of web resource service; fetches data from a JSON feed 
and stores it in user prefs, where it can be used by the new tab page.

BUG = http://crbug.com/13363

Review URL: http://codereview.chromium.org/125052
------------------------------------------------------------------------
r18765 | mpcomplete@google.com | 2009-06-19 00:56:58 +0200 (Fri, 19 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/greasemonkey_api.js
   M /trunk/src/chrome/renderer/resources/json_schema.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Send port-closed notification when a frame with ports unloads.

Also add onLoad and onUnload chrome Event to our bindings, so we can add
listeners to these events without needing a DOM.  These don't hook into the
window "unload" event, so we no longer prevent Chrome's sudden termination of
tabs on shutdown.

BUG=12686
TEST=no
Review URL: http://codereview.chromium.org/125280
------------------------------------------------------------------------
r18763 | jam@chromium.org | 2009-06-19 00:51:03 +0200 (Fri, 19 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   A /trunk/src/chrome/test/data/workers/many_workers.html
   M /trunk/src/chrome/worker/DEPS
   M /trunk/src/chrome/worker/worker_uitest.cc
   M /trunk/src/webkit/glue/webworker_impl.cc

Implement a max worker count of 16 per tab and 64 total.  Any workers created after that are queued.

Review URL: http://codereview.chromium.org/125242
------------------------------------------------------------------------
r18762 | tc@google.com | 2009-06-19 00:49:56 +0200 (Fri, 19 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Make the tabstrip transparent (doesn't paint a background) by
turning the window off for the gtk_fixed that represents the
tabstrip.  For some reason, this caused the tabs to render relative to
the top of the window, so adjust the tab painting via the event
area offset.

BUG=13789

Review URL: http://codereview.chromium.org/131069

------------------------------------------------------------------------
r18761 | sky@chromium.org | 2009-06-19 00:45:28 +0200 (Fri, 19 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Adds SendMessage to TransitionTypes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/131052
------------------------------------------------------------------------
r18757 | thakis@chromium.org | 2009-06-18 23:57:57 +0200 (Thu, 18 Jun 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/DownloadShelf.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/download_item_mac.h
   A /trunk/src/chrome/browser/cocoa/download_item_mac.mm
   A /trunk/src/chrome/browser/cocoa/download_shelf_controller.h
   A /trunk/src/chrome/browser/cocoa/download_shelf_controller.mm
   A /trunk/src/chrome/browser/cocoa/download_shelf_mac.h
   A /trunk/src/chrome/browser/cocoa/download_shelf_mac.mm
   A /trunk/src/chrome/browser/cocoa/download_shelf_mac_unittest.mm
   A /trunk/src/chrome/browser/cocoa/download_shelf_view.h
   A /trunk/src/chrome/browser/cocoa/download_shelf_view.mm
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Initial download shelf on OS X.

This has lots of missing stuff (e.g. a custom download item view that shows
download progress, the popup is the same for in-progress and completed
downloads, no animation, everything looks ugly, the info bubble overlaps the
shelf when it's visible, no "open download manager page" link, etc), but the
basic functionality is hooked up: The shelf appears when files are downloaded,
and something ugly is added to the shelf for each download. The popup's "Reveral
in Finder" even works. The shelf is per-window as it should be.

BUG=12500
TEST=Download something and check the shelf appears. Click the close button and
make sure it disappears again.

Review URL: http://codereview.chromium.org/93129

------------------------------------------------------------------------
r18756 | avi@google.com | 2009-06-18 23:47:20 +0200 (Thu, 18 Jun 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/cocoa_utils.h (from /trunk/src/chrome/browser/cocoa/cocoa_utils.h:18742)
   A /trunk/src/chrome/browser/cocoa/cocoa_utils.mm (from /trunk/src/chrome/browser/cocoa/cocoa_utils.mm:18742)
   A /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm (from /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm:18742)

Reverting r18743, the rest of it.


------------------------------------------------------------------------
r18755 | avi@google.com | 2009-06-18 23:41:58 +0200 (Thu, 18 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_mac.mm
   D /trunk/src/skia/ext/skia_utils_mac_unittest.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Reverting r18743.


------------------------------------------------------------------------
r18753 | jar@chromium.org | 2009-06-18 23:32:27 +0200 (Thu, 18 Jun 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Enable SDCH on mac/linux

Although it compiles in all builds etc., someone left the enabling code
ifdef'ed in browser main. This should enable SDCH on mac/linux.

To test, visit a site that supports SDCH (twice... the first time
you'll get the dictionary in the background), and then do a
view-cache:
in front of the resulting URL, and check to see that you're getting
Content-Encoding: sdch,gzip
If it is not sdch encoded, then with some tiny (1%) probability, 
you're in a control group of a current experiment... and you can
try starting your browser again... and doing another two visits.

To better track the issue if you think you are in the control group,
you can also visit
about:histograms
and you should see that a dictionary was downloaded, and then
either some content was decoded, with timings in Sdch3.Experiment_Decode
or was not run in SDCH and was timed in Sdch3.Experiment_Holdback.

BUG=14516

r=willchan,pinkerton
Review URL: http://codereview.chromium.org/131025
------------------------------------------------------------------------
r18751 | kuchhal@chromium.org | 2009-06-18 23:14:34 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc

Import bookmarks to bookmark bar if user has not bookmarked anything yet.

BUG=9000

Review URL: http://codereview.chromium.org/131004
------------------------------------------------------------------------
r18750 | tc@google.com | 2009-06-18 23:12:48 +0200 (Thu, 18 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix a comment I meant to update in the last change.

TBR=evan

Review URL: http://codereview.chromium.org/131063

------------------------------------------------------------------------
r18749 | stuartmorgan@chromium.org | 2009-06-18 23:11:59 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Fix an uninitialized variable that valgrind complains about.

BUG=none
TEST=Tab dragging on the Mac should still work.
Review URL: http://codereview.chromium.org/131055
------------------------------------------------------------------------
r18748 | tc@google.com | 2009-06-18 23:11:23 +0200 (Thu, 18 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc

Paint the custom frame border and round the corners.

We apply the theme background color to the window and use a NineBox
to draw the theme images around the border.

BUG=13430

Review URL: http://codereview.chromium.org/131049

------------------------------------------------------------------------
r18746 | avi@google.com | 2009-06-18 22:49:41 +0200 (Thu, 18 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Committed wrong patchset for r18743. This should have been included.


------------------------------------------------------------------------
r18743 | avi@google.com | 2009-06-18 22:23:44 +0200 (Thu, 18 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   D /trunk/src/chrome/browser/cocoa/cocoa_utils.h
   D /trunk/src/chrome/browser/cocoa/cocoa_utils.mm
   D /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_mac.mm
   A /trunk/src/skia/ext/skia_utils_mac_unittest.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp

Add favicons to tabs on the Mac. Also moved SkBitmapToNSImage() to
skia/ext/skia_utils_mac.h and removed chrome/browser/cocoa/cocoa_utils.h.

Patch by rsesek.

BUG=13565

Review URL: http://codereview.chromium.org/131018


------------------------------------------------------------------------
r18742 | mattm@chromium.org | 2009-06-18 22:19:19 +0200 (Thu, 18 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/chrome/browser/gtk/edit_keyword_controller.cc

Add helper for forcing a GtkEntry to lowercase.

Make l10n_util::ToLower string16 friendly.

BUG=13326

Review URL: http://codereview.chromium.org/126260
------------------------------------------------------------------------
r18734 | jhawkins@chromium.org | 2009-06-18 21:36:27 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Set the gtk drag icon to a 1x1 transparent pixbuf so we don't get the default drag icon.

BUG=none
TEST=Drag a tab out of the tabstrip.  The default gtk drag icon should not be visible.
Review URL: http://codereview.chromium.org/131043
------------------------------------------------------------------------
r18730 | tc@google.com | 2009-06-18 20:56:08 +0200 (Thu, 18 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

Elide the URL in the status bubble.

I copied the logic about whether to show the loading status or URL from
the Views code.

Review URL: http://codereview.chromium.org/125267

------------------------------------------------------------------------
r18728 | zork@chromium.org | 2009-06-18 20:50:46 +0200 (Thu, 18 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

Fix options window for Personalization on Linux.
Review URL: http://codereview.chromium.org/132028
------------------------------------------------------------------------
r18727 | mattm@chromium.org | 2009-06-18 20:49:37 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/edit_keyword_controller.cc
   A /trunk/src/chrome/browser/gtk/edit_keyword_controller.h
   M /trunk/src/chrome/browser/search_engines/edit_keyword_controller_base.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add gtk EditKeywordController.

BUG=13326

Review URL: http://codereview.chromium.org/126305
------------------------------------------------------------------------
r18720 | rohitrao@chromium.org | 2009-06-18 20:03:22 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc

Fixes a crash when scrolling quickly on Mac.

BUG=http://crbug.com/14211
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/125211
------------------------------------------------------------------------
r18719 | estade@chromium.org | 2009-06-18 19:55:27 +0200 (Thu, 18 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Add tools menu for bookmark manager gtk.

Now you can import and export an .html file with your bookmarks in it.

BUG=13110

Review URL: http://codereview.chromium.org/132006
------------------------------------------------------------------------
r18717 | erikkay@google.com | 2009-06-18 19:21:51 +0200 (Thu, 18 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_prefs.cc (from /trunk/src/chrome/browser/extensions/extension_prefs.cc:18681)
   A /trunk/src/chrome/browser/extensions/extension_prefs.h (from /trunk/src/chrome/browser/extensions/extension_prefs.h:18681)
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Abstract ExtensionPrefs into their own class.

Relands http://codereview.chromium.org/126281 which had been reverted due to a leak.

The only difference is in extension_prefs.h where extension_data_ is now a scoped_ptr.
Review URL: http://codereview.chromium.org/131040
------------------------------------------------------------------------
r18715 | ben@chromium.org | 2009-06-18 19:04:10 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/dialog_client_view.cc
   A /trunk/src/views/window/window.cc
   M /trunk/src/views/window/window_win.cc

Hook up "clear browsing data" dialog. It looks like ass right now. The intent is to be able to debug problems with NativeControls under Gtk.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131027
------------------------------------------------------------------------
r18709 | amanda@chromium.org | 2009-06-18 18:18:53 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_mac.mm

Only check for first run dialog on official builds (since the dialog is a
no-op on Chromium builds)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131035
------------------------------------------------------------------------
r18703 | avi@google.com | 2009-06-18 15:58:34 +0200 (Thu, 18 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h

Quick spelling fix.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/132016
------------------------------------------------------------------------
r18682 | willchan@chromium.org | 2009-06-18 05:10:34 +0200 (Thu, 18 Jun 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_prefs.cc
   D /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Revert r18661.
Broke purify and mac valgrind. "Pull Extension-related prefs into its own class.  Also add a notification for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none"

Review URL: http://codereview.chromium.org/132008
------------------------------------------------------------------------
r18680 | willchan@chromium.org | 2009-06-18 04:23:16 +0200 (Thu, 18 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/base/process.h
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp

Linux: Enable metrics_service_uitest.cc.  Take 2.
Relands r18641, original code review: http://codereview.chromium.org/125268
Expect a crash on Windows.
The old method of crashing was flawed on posix (KillProcess just does a SIGTERM).  On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true.  This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix.  When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects.  Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1.

Review URL: http://codereview.chromium.org/131007
------------------------------------------------------------------------
r18675 | brettw@chromium.org | 2009-06-18 02:38:06 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Enable off-by-default monitor color management on Windows. This is enabled via
a command-line switch.

BUG=4938
Review URL: http://codereview.chromium.org/131002
------------------------------------------------------------------------
r18671 | mattm@chromium.org | 2009-06-18 02:16:02 +0200 (Thu, 18 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Linux: Add menu item to url bar context menu to launch the search engine editor.

BUG=13326

Review URL: http://codereview.chromium.org/126307
------------------------------------------------------------------------
r18670 | ben@chromium.org | 2009-06-18 02:09:09 +0200 (Thu, 18 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Allow the RenderWidgetHostViewGtk to be sized even if it isn't a popup.

browser/views/tab_contents/tab_contents_view_gtk.cc implements sizing in a similar fashion to windows - i.e. when the GtkWidget is resized, it tells the RenderViewHost that it was sized, which causes the RVH to resize the view. A check for if (parent_) in the Gtk RenderWidgetHostView impl was preventing this sizing from occurring.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/125275
------------------------------------------------------------------------
r18667 | estade@chromium.org | 2009-06-18 01:31:48 +0200 (Thu, 18 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: Don't try to special case webkit blur when we stop showing right click context menu.

After I spent more time investigating, it seems that when the popup menu closes, it always returns focus to the toplevel that previously had it. Thus we don't have to worry about some other toplevel getting focus without us getting another focus-out.

BUG=13554
TEST=right click spellcheck correction works in gmail

Review URL: http://codereview.chromium.org/126301
------------------------------------------------------------------------
r18666 | mattm@chromium.org | 2009-06-18 01:19:56 +0200 (Thu, 18 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Pass a gfk::NativeWindow instead of gfx::NativeView for TemplateURLFetcher.
Use cross-platform method to get the NativeWindow.

BUG=13326

Review URL: http://codereview.chromium.org/126302
------------------------------------------------------------------------
r18661 | erikkay@google.com | 2009-06-18 00:08:35 +0200 (Thu, 18 Jun 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_prefs.cc
   A /trunk/src/chrome/browser/extensions/extension_prefs.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h

Pull Extension-related prefs into its own class.  Also add a notification for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none
Review URL: http://codereview.chromium.org/126281
------------------------------------------------------------------------
r18660 | estade@chromium.org | 2009-06-17 23:53:03 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_widget.cc

Linux: Limit the size of the shared memory segment a renderer will request.

TEST=everything behaves the same, and you don't sad tab when resizing a very large autocomplete popup
BUG=13805

Review URL: http://codereview.chromium.org/125274
------------------------------------------------------------------------
r18657 | jrg@chromium.org | 2009-06-17 23:36:46 +0200 (Wed, 17 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Fix die-on-launch.

Review URL: http://codereview.chromium.org/126295
------------------------------------------------------------------------
r18653 | sky@chromium.org | 2009-06-17 22:46:10 +0200 (Wed, 17 Jun 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/views/new_browser_window_widget.cc
   A /trunk/src/chrome/browser/views/new_browser_window_widget.h
   M /trunk/src/views/controls/button/custom_button.h

Adds a widget that when clicked creates a new browser window. It's not
wired up yet, but will be shortly.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/126235
------------------------------------------------------------------------
r18651 | sky@chromium.org | 2009-06-17 22:38:36 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Adds the tab overview button to the tab strip.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/125262
------------------------------------------------------------------------
r18650 | sky@chromium.org | 2009-06-17 22:37:42 +0200 (Wed, 17 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fixes bug where creating new tabs on linux would momentarily flash the
new tab on the left edge of the strip. We don't have this bug on
windows because the tab strip isn't painted until after the animation
progresses.

BUG=none
TEST=on linux create new tabs by way of control-t (or plus button),
  make sure you don't get the new tab to momentarily appear on the
  left edge.

Review URL: http://codereview.chromium.org/126240
------------------------------------------------------------------------
r18649 | mpcomplete@google.com | 2009-06-17 21:55:17 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc

Fix linux compile error.

TBR=joi
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/125270
------------------------------------------------------------------------
r18646 | willchan@chromium.org | 2009-06-17 21:38:21 +0200 (Wed, 17 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/base/process.h
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp

Revert r18641: "Linux: Enable metrics_service_uitest.cc."
Broke ui_tests.

Review URL: http://codereview.chromium.org/125268
------------------------------------------------------------------------
r18645 | mpcomplete@google.com | 2009-06-17 21:32:43 +0200 (Wed, 17 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js

Add a port disconnect event for when one side of an extension message port
goes away.

Combine the various ExtensionMessageService IPC message into a single "Invoke"
message.

BUG=12686
TEST=no
Review URL: http://codereview.chromium.org/126234
------------------------------------------------------------------------
r18643 | mark@chromium.org | 2009-06-17 21:21:56 +0200 (Wed, 17 Jun 2009) | 20 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/PageInfo.xib
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/cocoa/page_info_window_controller.h
   A /trunk/src/chrome/browser/cocoa/page_info_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/page_info_window_mac.h
   A /trunk/src/chrome/browser/cocoa/page_info_window_mac.mm
   A /trunk/src/chrome/browser/page_info_window.cc
   A /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   D /trunk/src/chrome/browser/views/page_info_window.cc
   D /trunk/src/chrome/browser/views/page_info_window.h
   A /trunk/src/chrome/browser/views/page_info_window_win.cc (from /trunk/src/chrome/browser/views/page_info_window.cc:18622)
   A /trunk/src/chrome/browser/views/page_info_window_win.h (from /trunk/src/chrome/browser/views/page_info_window.h:18622)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Implements the Page Info window on Mac.

- Splits out the code that was in chrome/browser/views/page_info_window.{cc,h}
into a platform-independent class PageInfoWindow in
chrome/browser/page_info_window.{cc,h}
- The Windows implementation now lives in
chrome/browser/views/page_info_window_win.{cc,h}
- Created a Mac implemenation PageInfoWindowMac in
chrome/browser/cocoa/page_info_window_mac.{h,mm} to bridge to a Cocoa
NSWindowController
- Created a new NSWindowController subclass PageInfoWindowController that is in
chrome/browser/cocoa/page_info_window_controller.{h,mm}
- Created a XIB for the page info window in
chrome/app/nibs/en.lproj/PageInfo.xib

Patch by Robert Sesek <rsesek@bluestatic.org>

Review URL: http://codereview.chromium.org/115116

Review URL: http://codereview.chromium.org/125266
------------------------------------------------------------------------
r18642 | finnur@chromium.org | 2009-06-17 21:07:03 +0200 (Wed, 17 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/page_action.h
   M /trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json

Remove tooltip from page_action and just use the name as the tooltip. We don't seem to have a need for having the name and the tooltip be separate.

Review URL: http://codereview.chromium.org/125264
------------------------------------------------------------------------
r18641 | willchan@chromium.org | 2009-06-17 21:06:26 +0200 (Wed, 17 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process.h
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_host_linux.h
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp

Linux: Enable metrics_service_uitest.cc.
Add support for zygotes to call DidProcessCrash on renderers.
TEST=metrics_server_uitest.cc

Review URL: http://codereview.chromium.org/126264
------------------------------------------------------------------------
r18636 | mattm@chromium.org | 2009-06-17 20:29:43 +0200 (Wed, 17 Jun 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/search_engines/edit_keyword_controller_base.cc
   A /trunk/src/chrome/browser/search_engines/edit_keyword_controller_base.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/chrome.gyp

Refactor platform-independent stuff out of EditKeywordController.

Preparation for adding GTK implementation.

BUG=13326
TEST=Edit existing search engine, add new search engine, add engine by clicking on OpenSearch description file.

Review URL: http://codereview.chromium.org/125161
------------------------------------------------------------------------
r18626 | phajdan.jr@chromium.org | 2009-06-17 19:23:51 +0200 (Wed, 17 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher_protect.cc
   M /trunk/src/chrome/browser/net/url_fetcher_protect.h
   M /trunk/src/chrome/test/chrome_process_util.cc

Consistently use int64 for integers holding number of milliseconds.

This applies only to things which use TimeDelta::InMilliseconds, because
it returns int64. Before this patch callers static_casted that to int,
and after this patch they use the returned value as int64.

Review URL: http://codereview.chromium.org/126279
------------------------------------------------------------------------
r18624 | kuchhal@chromium.org | 2009-06-17 18:51:10 +0200 (Wed, 17 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc

Exit Chrome and show FRUI again on the next run, if user clicks on Cancel.

BUG=10825

Review URL: http://codereview.chromium.org/118528
------------------------------------------------------------------------
r18623 | erg@chromium.org | 2009-06-17 18:48:11 +0200 (Wed, 17 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   A /trunk/src/chrome/browser/login_prompt_win.cc (from /trunk/src/chrome/browser/login_prompt.cc:18622)
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/chrome.gyp

Remove the windows specific bits from login_prompt.cc and make LoginPromptWin conform to a general cross platform interface.

(Also tightens the interface for ConstrainedWindows a bit more)

Review URL: http://codereview.chromium.org/125217
------------------------------------------------------------------------
r18621 | shess@chromium.org | 2009-06-17 17:44:50 +0200 (Wed, 17 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Fix bug where the autocomplete text was being overridden by the user-entered text.

During the course of this, I gave in and implemented
EmphasizeURLComponents() for consistency with Windows and GTK.  Since
modifying the text changes the selection, added
SetTextAndSelectedRange() to make operations doing both easier to get
right.  Renamed UpdateAndStyleText() to SetText() for consistency.

http://crbug.com/14122
TEST=See bug.

Review URL: http://codereview.chromium.org/125201
------------------------------------------------------------------------
r18605 | jcampan@chromium.org | 2009-06-17 09:07:10 +0200 (Wed, 17 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h

Removing a method unecessary in FindBarWin.

BUG=None
TEST=Bring up the find box. Press Esc (the box should close). Hit a URL that takes a long time to load. While it is loading,  press ESC, the load should stop.
Review URL: http://codereview.chromium.org/126230
------------------------------------------------------------------------
r18588 | ben@chromium.org | 2009-06-17 06:23:00 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/button/native_button_gtk.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Fix build bustage by removing another dependency on browser/gtk by creating a new TabContentsViewGtk specifically for views. This subclasses WidgetGtk similar to how TabContentsViewWin subclasses WidgetWin.

There was a bug in NativeViewHostGtk - reparenting needs to be done atomically using gtk_widget_reparent since GtkWidgets are refcounted and when removed from a container are released, causing a crash when a TabContents is reparented.

The code now compiles thanks to a stubbed BlockedPopupContainer, however there is one remaining issue - the browser window no longer paints and the app instantly hangs. However this is better than the current state so I figured I'd send the code review.
Review URL: http://codereview.chromium.org/126107
------------------------------------------------------------------------
r18584 | yusukes@google.com | 2009-06-17 05:14:12 +0200 (Wed, 17 Jun 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc (from /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc:18152)

Do not write a profile path on a BookmarkDragData object since a dragged url (javascript:...) on a web page does not belong to (the profile's) bookmark model.

Currently the following function returns DRAG_NONE and thus the drop operation is not accepted. The reason for the return value is because ops becomes DragDropTypes::DRAG_MOVE (since data.profile_path_ is not empty()) but event.GetSourceOperations() returns DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK.

int BookmarkBarView::CalculateDropOperation(const DropTargetEvent& event,
...
    int ops = data.GetFirstNode(profile_)
        ? DragDropTypes::DRAG_MOVE
        : DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK;
    return bookmark_utils::PreferredDropOperation(event.GetSourceOperations(),
                                                  ops);

BUG=12290
TEST=Open http://delicious.com/help/bookmarklets page and drag the "Bookmark on Delicious" link on "Google Chrome" section to the bookmark bar.

Review URL: http://codereview.chromium.org/125111
------------------------------------------------------------------------
r18582 | estade@chromium.org | 2009-06-17 04:18:43 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

gtk fullscreen fixes.

http://crbug.com/13999
TEST=when you fullscreen, it should be impossible to see any of the following: frame, tabstrip, tool bar, bookmark bar.

Review URL: http://codereview.chromium.org/125230
------------------------------------------------------------------------
r18581 | ericroman@google.com | 2009-06-17 04:11:03 +0200 (Wed, 17 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc

Re-land another subset of r18520.

This particular subset should be a no-op: It adds an unused interface method (OnResolutionCancelled), and an unused test (CancelObserver), and lastly renames Cancel --> MarkAsCanceled().
The code in "dns_global.cc" is also unused since it is unreachable.

The original code review that this belongs to is:<http://codereview.chromium.org/125171>. (BUG=14138)

The original was backed out because of a valgrind linux error (BUG=14218), so I am now re-landing in smaller chunks to identify where the problem resides.
Review URL: http://codereview.chromium.org/126253
------------------------------------------------------------------------
r18578 | estade@chromium.org | 2009-06-17 03:08:25 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

gtk bookmark bar: Initialize a member variable.

http://crbug.com/14067
TEST=open browser, click on other bookmarks button. It should work on the first try.

Review URL: http://codereview.chromium.org/126249
------------------------------------------------------------------------
r18576 | davemoore@chromium.org | 2009-06-17 02:49:31 +0200 (Wed, 17 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Enable extensions without UI 
Review URL: http://codereview.chromium.org/125031
------------------------------------------------------------------------
r18575 | estade@chromium.org | 2009-06-17 02:43:43 +0200 (Wed, 17 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/icon_manager.h

gtk: Make sure icon is right size in download item.

This results in kind of an ugly icon sometimes. When we get SVG support the number of ugly cases should go down.

http://crbug.com/13791

Review URL: http://codereview.chromium.org/126245
------------------------------------------------------------------------
r18574 | ericroman@google.com | 2009-06-17 02:40:32 +0200 (Wed, 17 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc

Revert 18520.

The original code review for this change was:
<http://codereview.chromium.org/125171>

It is being reverted because it seems to have caused a valgrind on linux regression:
<http://crbug.com14218>

BUG=14218,14138,14188

Review URL: http://codereview.chromium.org/126248
------------------------------------------------------------------------
r18572 | brettw@chromium.org | 2009-06-17 02:35:02 +0200 (Wed, 17 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   M /trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
   M /trunk/src/chrome/common/transport_dib_mac.cc
   M /trunk/src/chrome/test/testing_browser_process.h

Fix a crash when the ThumbnailGenerator.

This happens when the ThumbnailGenerator is initialized because the
NotificationService doesn't exist yet. This patch adds a function that
TabContentscalls to make sure it is registered to avoid this problem.

Review URL: http://codereview.chromium.org/126239
------------------------------------------------------------------------
r18568 | hclam@chromium.org | 2009-06-17 02:17:23 +0200 (Wed, 17 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Disable MediaTest.VideoBearH264

TBR=scherkus

Review URL: http://codereview.chromium.org/126246
------------------------------------------------------------------------
r18562 | hclam@chromium.org | 2009-06-17 01:49:12 +0200 (Wed, 17 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/media_uitest.cc

Disable MediaTest.VideoBearH264 because it fails
TBR=finnur, scherkus

Review URL: http://codereview.chromium.org/126242
------------------------------------------------------------------------
r18560 | estade@chromium.org | 2009-06-17 01:31:37 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

GTK bookmark bar: only animate when user changes the pref (not, for example, on startup).

TEST=set bookmark bar open, restart chrome, bookmark bar should just be open (no animation)
BUG=none

Review URL: http://codereview.chromium.org/125223
------------------------------------------------------------------------
r18555 | rafaelw@chromium.org | 2009-06-17 01:13:55 +0200 (Wed, 17 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   A /trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html

submitted on behalf of rogerta (Roger Tawa).

Original issue: http://codereview.chromium.org/119325

r=rafaelw,Jói,stoyan,aa

Review URL: http://codereview.chromium.org/125206
------------------------------------------------------------------------
r18554 | finnur@chromium.org | 2009-06-17 01:11:26 +0200 (Wed, 17 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/app/app_paths.cc
   M /trunk/src/app/app_paths.h
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Bug 14202: Support relative paths when installing external extensions through prefs. 

First we try the path as absolute path. If the file is not found, we try a relative path: [installation path]\extensions

This will make installing extensions easier from pre-installed prefs, since we can drop them into an extensions directory under the program directory.

BUG=14202
TEST=Specify relative path when installing extensions through prefs. Best to test this with an installer that supports deploying extensions (blocked on 14201)

Review URL: http://codereview.chromium.org/125219
------------------------------------------------------------------------
r18551 | arv@google.com | 2009-06-17 01:08:55 +0200 (Wed, 17 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/local_strings.js
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/common/jstemplate_builder.cc

Make LocalStrings work without manipulating the DOM.

BUG=None

TEST=Make sure that localized text on NTP, History and Downloads still
look the same.

Review URL: http://codereview.chromium.org/125076
------------------------------------------------------------------------
r18550 | hclam@chromium.org | 2009-06-17 00:47:06 +0200 (Wed, 17 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/media_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/media
   A /trunk/src/chrome/test/data/media/bear.mp4
   A /trunk/src/chrome/test/data/media/player.html

UI test for <video>
Simple ui test that goes through some test clips.

TEST=MediaTest.*

Review URL: http://codereview.chromium.org/125173
------------------------------------------------------------------------
r18546 | estade@chromium.org | 2009-06-17 00:38:15 +0200 (Wed, 17 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Gtk bookmark manager: add search + recently added nodes.

Review URL: http://codereview.chromium.org/125220
------------------------------------------------------------------------
r18540 | brettw@chromium.org | 2009-06-16 23:41:02 +0200 (Tue, 16 Jun 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_painting_observer.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   A /trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc
   A /trunk/src/chrome/browser/tab_contents/thumbnail_generator.h
   A /trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/property_bag.h
   M /trunk/src/chrome/common/transport_dib.h
   M /trunk/src/chrome/common/transport_dib_linux.cc
   M /trunk/src/chrome/common/transport_dib_mac.cc
   M /trunk/src/chrome/common/transport_dib_win.cc
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Adds kind-of-live thumbnail generation for a potential tab switcher.

This listens to tab events and tries to keep thumbnails ready to go. See
thumbnail_generator.cc for a more detailed design.

This adds a painting observer to the RenderWidgetHost to enable this new
behavior, as well as a notification to allow the thumbnail generator to hook
its observer in. There is also a new notification that a backing store has been
disabled, which required making the backing stores know about their owning
widget hosts.

This component is currently disabled. We just need to uncomment the member in
Profile and it will start to work.

Original review: http://codereview.chromium.org/118420

Review URL: http://codereview.chromium.org/126101
------------------------------------------------------------------------
r18537 | jar@chromium.org | 2009-06-16 23:32:18 +0200 (Tue, 16 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h

Properly cleanup state after synchronous DNS resolution

Pre-resoultion system was not cleaning up its state when the resolver
returned asynchronously.  This regression probably landed when we shifted
to using an internal resolver class, rather than running on worker threads.
The impact was made detectable by the recent introudction of a micro-cache,
which often returns with a synchronous result.

BUG=14212

r=eroman
Review URL: http://codereview.chromium.org/125209
------------------------------------------------------------------------
r18536 | hclam@chromium.org | 2009-06-16 23:30:38 +0200 (Tue, 16 Jun 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h
   M /trunk/src/chrome/renderer/audio_message_filter_unittest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/media/filters/audio_renderer_base.cc
   M /trunk/src/media/filters/audio_renderer_base.h
   M /trunk/src/media/filters/audio_renderer_impl.cc
   M /trunk/src/media/filters/null_audio_renderer.cc

Since the introduction of PushSource, there are two buffering layers in the
browser process, the hardware buffer used in AudioOutputStream and
transportation buffer in PushSource. Together with the latency in the IPC
audio layer we have a serious AV sync problem.

To compensate the delay and latency introduced by these three factors
two parameters are added in RequestAudioPacket message that include
the buffer fill level and timestamp of the request. These two parameters
are used to determine the playback delay to be used by the audio
renderer to update the pipeline with the time delta.

So we have three parameters we need to care about:
1. Hardware buffer in AudioOutputStream
2. Buffered data in PushSource
3. IPC latency

We have accurate values for 2 and 3 but not 1. We currently don't have the
API in AudioOutputStream to query the remaining buffer in the hardware
buffer. But usually there is a large amount of data in it, e.g. on Windows
400ms worth of data. Since we now detached the hardware buffer request of
OnMoreData() from the actual packet request of IPC (by the introduction of
PushSource), it is really critical to know the buffer level in the hardware.
I made a guess of this buffer level by using the amount of last buffer copy.

Review URL: http://codereview.chromium.org/122020
------------------------------------------------------------------------
r18534 | paul@chromium.org | 2009-06-16 23:29:58 +0200 (Tue, 16 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Add a UI test for downloading in incognito mode.

This test opens an incognito window and verifies that
downloads work and that closing the incognito window
does not crash (see bug http://crbug.com/13983).

TEST=Test should run and not crash.
BUG=none

Review URL: http://codereview.chromium.org/126181
------------------------------------------------------------------------
r18532 | paul@chromium.org | 2009-06-16 23:27:47 +0200 (Tue, 16 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h

Speculative fix for a chromebot crash since I can't reproduce it
locally.

When shutting down the browser with a download shelf, we first
release the shelf (see BUG=13681 for details) but we are still
part of the view hierarchy. A little later in the shutdown, the
shelf's parent (BrowserView) will dereference the already deleted
shelf through its View base class, which I believe is the source
of the Chromebot crash.

BUG=14171 (http://crbug.com/14171)
TEST=Chromebot should not crash

Review URL: http://codereview.chromium.org/126228
------------------------------------------------------------------------
r18530 | mhm@chromium.org | 2009-06-16 23:27:11 +0200 (Tue, 16 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Cleanup Personal Stuff options tab page

The popup variable declarations are not needed anymore since they were removed .

BUG=none
TEST=page functions correctly
 
Review URL: http://codereview.chromium.org/126102
------------------------------------------------------------------------
r18523 | sky@chromium.org | 2009-06-16 22:23:58 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/tabs/grid.cc
   M /trunk/src/chrome/browser/views/tabs/grid.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_container.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_grid.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_grid.h
   A /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.cc
   A /trunk/src/chrome/browser/views/tabs/tab_overview_message_listener.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/screen_gtk.cc

Improved tab overview animations with better animation and wiring to
message loop.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/126185
------------------------------------------------------------------------
r18522 | laforge@chromium.org | 2009-06-16 22:22:11 +0200 (Tue, 16 Jun 2009) | 41 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/History/history_length_test_page_1.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_11.html (from /trunk/src/chrome/test/data/History/history_length_test_page_11.html:18511)
   A /trunk/src/chrome/test/data/History/history_length_test_page_12.html (from /trunk/src/chrome/test/data/History/history_length_test_page_12.html:18511)
   M /trunk/src/chrome/test/data/History/history_length_test_page_2.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_21.html (from /trunk/src/chrome/test/data/History/history_length_test_page_21.html:18511)
   A /trunk/src/chrome/test/data/History/history_length_test_page_22.html (from /trunk/src/chrome/test/data/History/history_length_test_page_22.html:18511)
   M /trunk/src/chrome/test/data/History/history_length_test_page_3.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_4.html
   M /trunk/src/chrome/test/ui/history_uitest.cc

Revert 18512 - Revert 18373  Consider a redirect following user gesture as userinitiated in maintaining
navigation entries. Also, ignore redirect or machineinitiated new subframe
navigations.

The current code treats all redirects as machineinitiated in processing
navigation to a new page (to fix Bugs 9663 and 10531). This is not always
appropriate, because some sites, e.g., www.google.com/ig, use redirect to
implement userinitiated navigation (Bug 11896).

This change assumes that a machineinitiated redirect happens within 300ms
since the last document load was completed, while  a userinitiated one
happens later.

This assumption is not always correct, e.g., a user may cause transition within
300ms. But I cannot think of any better ways to tell if a redirect is machine
initiated or userinitiated.

I believe this change works good enough, at least better than the status quo.

Review URL: http://codereview.chromium.org/115919

TEST=Open http://www.hp.com and observe it redirects to
http://www.hp.com/#Product . Hit Back button and observe
the former URL is not visited. Open http://www.google.com/ig and
click tabs inside the page, and try hitting Back and Forward to see if the
navigation is right. Open http://www.google.com/codesearch, search for
something, click on a result item, and try hitting Back.

BUG=11896,12820





TBR=yuzo@chromium.org

Review URL: http://codereview.chromium.org/125202

TBR=laforge@chromium.org

Review URL: http://codereview.chromium.org/126221
------------------------------------------------------------------------
r18520 | ericroman@google.com | 2009-06-16 22:14:27 +0200 (Tue, 16 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc

* Add an OnCancelResolution() notifier to HostResolver::Observer, so observers can tell when a request has been cancelled.

* Use OnCancelResolution() in DNS prefetcher observer, to avoid leaking entries in the |resolution| table when requests are cancelled. (BUG=14138)

* Fix a bug where completion notification wasn't being sent when the response was cached. (BUG=14188)

BUG=14138,14188
TEST=HostResolverTest.CancellationObserver, HostResolverTest.Observer

Review URL: http://codereview.chromium.org/125171
------------------------------------------------------------------------
r18518 | estade@chromium.org | 2009-06-16 21:57:31 +0200 (Tue, 16 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/app/app.gyp
   A /trunk/src/app/table_model.cc (from /trunk/src/views/controls/table/table_model.cc:18411)
   A /trunk/src/app/table_model.h (from /trunk/src/views/controls/table/table_model.h:18411)
   A /trunk/src/app/table_model_observer.h (from /trunk/src/views/controls/table/table_model_observer.h:18411)
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/views/controls/table/group_table_view.h
   D /trunk/src/views/controls/table/table_model.cc
   D /trunk/src/views/controls/table/table_model.h
   D /trunk/src/views/controls/table/table_model_observer.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_unittest.cc
   M /trunk/src/views/views.gyp

Move TableModel out of views/ and into app/.

Remove stub implementation in temp_scaffolding_stubs.h

Use l10n_util collator helper function in TableModel::Compare
Review URL: http://codereview.chromium.org/126184
------------------------------------------------------------------------
r18517 | mark@chromium.org | 2009-06-16 21:57:22 +0200 (Tue, 16 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/icon_loader_mac.mm
   M /trunk/src/chrome/browser/icon_manager_mac.mm
   D /trunk/src/skia/ext/skia_utils_mac.cc
   M /trunk/src/skia/ext/skia_utils_mac.h
   A /trunk/src/skia/ext/skia_utils_mac.mm (from /trunk/src/skia/ext/skia_utils_mac.cc:18505)
   M /trunk/src/skia/skia.gyp
   M /trunk/src/webkit/glue/image_decoder.cc

Add file icons to chrome://downloads/ on the Mac. Add Skia helper
CGImageToSkBitmap().

Patch by Robert Sesek <rsesek@bluestatic.org>

Review URL: http://codereview.chromium.org/118488
------------------------------------------------------------------------
r18516 | mpcomplete@google.com | 2009-06-16 21:53:02 +0200 (Tue, 16 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h

Fix a crash that could happen at shutdown or window close due to a double-free.

This is erikkay's patch.  I'm landing it while he's away.

TBR=erikkay
BUG=none
TEST=install an extension with a toolstrip and close chrome.  It shouldn't
crash.
Review URL: http://codereview.chromium.org/126219
------------------------------------------------------------------------
r18515 | darin@chromium.org | 2009-06-16 21:50:56 +0200 (Tue, 16 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/browser/password_manager/login_database.h
   M /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/loadtimes_extension_bindings.cc
   A /trunk/src/chrome/renderer/navigation_state.h (from /trunk/src/chrome/renderer/render_view.cc:18429)
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/password_form.h
   M /trunk/src/webkit/glue/webdatasource.h
   M /trunk/src/webkit/glue/webdatasource_impl.cc
   M /trunk/src/webkit/glue/webdatasource_impl.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Extract load times from WebDataSource.  Move them to NavigationState.

Move PasswordForm into the webkit_glue namespace.

TEST=none
BUG=10041
R=brettw

Review URL: http://codereview.chromium.org/126190
------------------------------------------------------------------------
r18512 | laforge@chromium.org | 2009-06-16 21:07:10 +0200 (Tue, 16 Jun 2009) | 37 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/History/history_length_test_page_1.html
   D /trunk/src/chrome/test/data/History/history_length_test_page_11.html
   D /trunk/src/chrome/test/data/History/history_length_test_page_12.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_2.html
   D /trunk/src/chrome/test/data/History/history_length_test_page_21.html
   D /trunk/src/chrome/test/data/History/history_length_test_page_22.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_3.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_4.html
   M /trunk/src/chrome/test/ui/history_uitest.cc

Revert 18373 - Consider a redirect following user gesture as userinitiated in maintaining
navigation entries. Also, ignore redirect or machineinitiated new subframe
navigations.

The current code treats all redirects as machineinitiated in processing
navigation to a new page (to fix Bugs 9663 and 10531). This is not always
appropriate, because some sites, e.g., www.google.com/ig, use redirect to
implement userinitiated navigation (Bug 11896).

This change assumes that a machineinitiated redirect happens within 300ms
since the last document load was completed, while  a userinitiated one
happens later.

This assumption is not always correct, e.g., a user may cause transition within
300ms. But I cannot think of any better ways to tell if a redirect is machine
initiated or userinitiated.

I believe this change works good enough, at least better than the status quo.

Review URL: http://codereview.chromium.org/115919

TEST=Open http://www.hp.com and observe it redirects to
http://www.hp.com/#Product . Hit Back button and observe
the former URL is not visited. Open http://www.google.com/ig and
click tabs inside the page, and try hitting Back and Forward to see if the
navigation is right. Open http://www.google.com/codesearch, search for
something, click on a result item, and try hitting Back.

BUG=11896,12820





TBR=yuzo@chromium.org

Review URL: http://codereview.chromium.org/125202
------------------------------------------------------------------------
r18505 | pinkerton@chromium.org | 2009-06-16 19:54:36 +0200 (Tue, 16 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Don't show tooltips if the window isn't main.
BUG=none
TEST=tooltips shouldn't show if the window isn't the frontmost.
Review URL: http://codereview.chromium.org/125194
------------------------------------------------------------------------
r18502 | phajdan.jr@chromium.org | 2009-06-16 19:25:47 +0200 (Tue, 16 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc

Fix Windows release compile by adding missing build_config.h include.

TBR=deanm

Review URL: http://codereview.chromium.org/126211
------------------------------------------------------------------------
r18500 | phajdan.jr@chromium.org | 2009-06-16 19:12:31 +0200 (Tue, 16 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_item.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_protocols.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/test/ui_test_utils.cc

Reduce header dependencies in chrome/browser/

In my scan of headers I got up to browser/gtk/

Review URL: http://codereview.chromium.org/126131
------------------------------------------------------------------------
r18498 | erg@chromium.org | 2009-06-16 19:05:11 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/automation/automation_constrained_window_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/blocked_popup_container_interactive_uitest.cc (from /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc:18494)
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   D /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   D /trunk/src/chrome/test/automation/constrained_window_proxy.cc
   D /trunk/src/chrome/test/automation/constrained_window_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Removes entirely dead code paths related to ConstrainedWindows.

- Removes parts of the interface that probably made sense at some time, but now only have a DLOG(INFO) as their implementation. Also remove their callers.
- Remove all usage of the ConstrainedWindowProxy interface in the automation system. It was *never* used.
- Rename constrianed_window_impl_interactive_uitests.cc to blocked_popup_container_interactive_uitest.cc. The test case hasn't tested code in constrained_window_impl.cc since the rewrite of the blocked popup system back last autumn.

Review URL: http://codereview.chromium.org/125160
------------------------------------------------------------------------
r18491 | pinkerton@chromium.org | 2009-06-16 17:17:56 +0200 (Tue, 16 Jun 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/app/theme/otr_icon.pdf
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Use a pdf instead of a png for incognito badge.
BUG=none
TEST=incognito badge should display correctly in incognito windows.
Review URL: http://codereview.chromium.org/126204
------------------------------------------------------------------------
r18490 | pinkerton@chromium.org | 2009-06-16 16:44:15 +0200 (Tue, 16 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Make tooltip loading lazy.
BUG=none
TEST=normal tooltip tests
Review URL: http://codereview.chromium.org/126203
------------------------------------------------------------------------
r18487 | craig.schlenter@chromium.org | 2009-06-16 15:14:08 +0200 (Tue, 16 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc

Solve a strict-aliasing issue in metrics_log.cc to appease gcc 4.4 on Linux.

Review URL: http://codereview.chromium.org/126104
------------------------------------------------------------------------
r18480 | aa@chromium.org | 2009-06-16 05:47:25 +0200 (Tue, 16 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Whoops. Actually print out the private key in the unit test,
instead of the crx file.

Review URL: http://codereview.chromium.org/125172
------------------------------------------------------------------------
r18479 | abarth@chromium.org | 2009-06-16 05:42:50 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Removed mixed content options.  Turns out extremely few users changed the default.

R=beng
BUG=None
TEST=Go to options dialog and notice that the mixed content option is gone.

Review URL: http://codereview.chromium.org/126106
------------------------------------------------------------------------
r18478 | brettw@chromium.org | 2009-06-16 04:46:22 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Remove unnecessary static_cast in the ctor of TabContents and AsWC helper
function. These were leftover from Brett's refactoring of Tab/WebContents.

Original review: http://codereview.chromium.org/125040
Patch by tyoshino@google.com

Review URL: http://codereview.chromium.org/125138
------------------------------------------------------------------------
r18476 | aa@chromium.org | 2009-06-16 04:01:29 +0200 (Tue, 16 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Trying to debug a purify problem, the flags are not set to output LOG(INFO), so I am changing to something I know will work.

Review URL: http://codereview.chromium.org/125167
------------------------------------------------------------------------
r18471 | ericroman@google.com | 2009-06-16 02:57:45 +0200 (Tue, 16 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Add a bug number to a TODO comment.

TBR=jar
BUG=14138

Review URL: http://codereview.chromium.org/126167
------------------------------------------------------------------------
r18470 | erikkay@google.com | 2009-06-16 02:54:59 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h

Fix a bug where ExtensionHost and ExtensionView weren't getting closed properly when a browser window was closed.

BUG=13975
TEST=see bug for repro steps


Review URL: http://codereview.chromium.org/125164
------------------------------------------------------------------------
r18467 | hamaji@chromium.org | 2009-06-16 02:48:32 +0200 (Tue, 16 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc

Add comments on magic number 0xbb. They are VK_OEM_PLUS. I guess the original author of this code considered the case where VK_OEM_PLUS isn't defined. For example, it seems that 0xbb is VK_EQUAL for embeded environments and VK_OEM_PLUS is never defined.
Review URL: http://codereview.chromium.org/119154
------------------------------------------------------------------------
r18466 | erikkay@google.com | 2009-06-16 02:43:23 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browsertest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Close all browsers during InProcessBrowserTest cleanup, not just the main one.

BUG=none
TEST=ExtensionViewTest.Incognito


Review URL: http://codereview.chromium.org/126175
------------------------------------------------------------------------
r18464 | estade@chromium.org | 2009-06-16 02:36:00 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Limit the size of popup menus on linux.

This fixes <http://crbug.com/13805>.

I've filed http://crbug.com/14142 for a more graceful solution.

Review URL: http://codereview.chromium.org/126171
------------------------------------------------------------------------
r18463 | estade@chromium.org | 2009-06-16 02:35:46 +0200 (Tue, 16 Jun 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Bookmark dragging cleanup.

bookmark bar:
- re-show on buttons when done dragging
- match g_object_ref in drag-begin with g_object_unref in drag-end
bookmark manager:
- get rid of default tree view drag handling (we override it all anyway, and it was causing problems)
- fix index out of bounds crash
- when you drag onto a folder, add it at the end of the folder rather than the beginning.

TEST=single bookmark dragging should be fully functional, non crashing
BUG=14019

Review URL: http://codereview.chromium.org/126163
------------------------------------------------------------------------
r18462 | aa@chromium.org | 2009-06-16 02:33:58 +0200 (Tue, 16 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/purify/unit_tests.exe.gtest.txt

Temporarily break the purify bot again so that I can get log
entries needed to permanently fix.

Review URL: http://codereview.chromium.org/125162
------------------------------------------------------------------------
r18458 | paul@chromium.org | 2009-06-16 02:11:21 +0200 (Tue, 16 Jun 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Fix a crash when closing an incognito window with a download
shelf visible.

We explicitly remove the download shelf view from the browser
view hierarchy during a window close operation. This avoids
calling back into the partially deleted view hierarchy with
download deleted observer notifications. Explicitly removing
the shelf allows the observer notifications to run first while
the views are still valid.


To reproduce:
1. Launch Chrome
2. Open an incognito window
3. Download something in the incognito window
4. The download shelf should become visible with one entry
5. Close the incognito window
6. Crash

BUG=13681 (http://crbug.com/13681)

Review URL: http://codereview.chromium.org/126082
------------------------------------------------------------------------
r18456 | ben@chromium.org | 2009-06-16 02:02:34 +0200 (Tue, 16 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc

Fix bustage caused by last change. enumeration changed name and got rid of _DELEGATE.

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/126176
------------------------------------------------------------------------
r18454 | ben@chromium.org | 2009-06-16 01:49:40 +0200 (Tue, 16 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_views.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_views.h
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/button_dropdown.h
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h

Upgrade BackForwardMenuModelViews to use new menu API. Also adds accelerator to the "Show Full History" item.

This requires bringing the owner-draw system for native menus over from the old code. I haven't really changed anything in it other than the format of dwItemData. This code could be improved/simplified by using gfx::Canvas more, but don't want to do it here.

BUG=none
TEST=make sure BackForwardMenuModel tests still pass, test the menu functionality in the toolbar.
Review URL: http://codereview.chromium.org/126092
------------------------------------------------------------------------
r18446 | stuartmorgan@chromium.org | 2009-06-16 00:23:01 +0200 (Tue, 16 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a switch for changing the fd limit on Mac/Linux.
Bump up the default fd limit on the Mac; stopgap fix for page cyclers, but something we want long-term to improve performance once we handle fd exhaustion with delays.

BUG=none
TEST=Launching with --file-descriptor-limit=20 should crash the renderer almost immediately.
Review URL: http://codereview.chromium.org/125151
------------------------------------------------------------------------
r18444 | brettw@chromium.org | 2009-06-16 00:13:30 +0200 (Tue, 16 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc

Implement the default tab opening behavior. Fix some linux build issues by adding missing includes.

Review URL: http://codereview.chromium.org/125145
------------------------------------------------------------------------
r18442 | jcampan@chromium.org | 2009-06-15 23:56:55 +0200 (Mon, 15 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Disabling 2 flacky UI tests.

TBR=stoyan
BUG=http://crbug.com/14132
Review URL: http://codereview.chromium.org/125153
------------------------------------------------------------------------
r18430 | mpcomplete@google.com | 2009-06-15 22:40:50 +0200 (Mon, 15 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Use GetForegroundWindow instead of GetActiveWindow because the former works on
all threads.

BUG=13914
TEST=install an extension an make sure the install dialog window shows up in front of
the Chrome window.
Review URL: http://codereview.chromium.org/125077
------------------------------------------------------------------------
r18428 | mpcomplete@google.com | 2009-06-15 22:28:09 +0200 (Mon, 15 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   M /trunk/src/chrome/browser/tab_contents/site_instance_unittest.cc

Group renderer processes by privilige when we hit the max process count.

BUG=12128
TEST=Create a bunch of tabs (40+) and make sure New Tab pages are always
grouped in a process with other chrome internal pages, extensions are
always grouped together, and regular web pages are never in a process with
extensions or New Tab pages.
Review URL: http://codereview.chromium.org/126002
------------------------------------------------------------------------
r18427 | erikkay@google.com | 2009-06-15 22:26:26 +0200 (Mon, 15 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Fix a crash during extension installation (debug only).

BUG=none
TEST=browser_tests.exe --gtest_filter=ExtensionViewTest.Incognito


Review URL: http://codereview.chromium.org/126151
------------------------------------------------------------------------
r18425 | jeremy@chromium.org | 2009-06-15 22:20:49 +0200 (Mon, 15 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/location_bar_fieldeditor_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

Fix http://crbug.com/13971:	OSX: Text copied from Omnibox is styled

Provide a custom field editor for the location bar that overrides cut/copy to only write plain text to the clipboard.

BUG=13971
TEST=Type a URL in the Omnibox, select all and copy url, open Textedit and paste the url into it.  Expected results: url should be unstyled previous behavior: styled text (as it appeared in the Omnibox was pasted)

Review URL: http://codereview.chromium.org/126075
------------------------------------------------------------------------
r18423 | stuartmorgan@chromium.org | 2009-06-15 22:06:12 +0200 (Mon, 15 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/login_database.cc
   M /trunk/src/chrome/chrome.gyp

Add missing headers for Windows and re-enable building of LoginDatabase.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125092
------------------------------------------------------------------------
r18410 | sky@chromium.org | 2009-06-15 20:31:22 +0200 (Mon, 15 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc

Fixes bug where keyword editor would end up prefixing all keyword urls
with "http://" if they didn't have one. This proves problematic as for
the google search url we don't have http:// and don't want it. The fix
is to only add http:// if the url field is editable. If the url field
isn't editable, we know the user hasn't editted it and don't need to
try and fix it up.

BUG=13282
TEST=see bug, but also make sure you don't run into any other problems
with the keyword editor.

Review URL: http://codereview.chromium.org/126052
------------------------------------------------------------------------
r18408 | pinkerton@chromium.org | 2009-06-15 20:29:45 +0200 (Mon, 15 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/third_party/mozilla/include/NSScreen+Utils.h
   A /trunk/src/third_party/mozilla/include/NSScreen+Utils.m
   A /trunk/src/third_party/mozilla/include/ToolTip.h
   A /trunk/src/third_party/mozilla/include/ToolTip.mm

Make tooltips work correctly, allowing for multiple tooltips w/out the mouse leaving the view (which is all NSView can handle by itself). Adds some Camino code to do so.
BUG=13995
TEST=tooltips in web pages, pages with multiple tooltips, expose and spaces.
Review URL: http://codereview.chromium.org/125133
------------------------------------------------------------------------
r18405 | agl@chromium.org | 2009-06-15 20:15:08 +0200 (Mon, 15 Jun 2009) | 30 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   A /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   A /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/browser/zygote_host_linux.cc
   M /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_descriptors.h
   A /trunk/src/skia/ext/SkFontHost_fontconfig.cpp
   A /trunk/src/skia/ext/SkFontHost_fontconfig_control.h
   A /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp
   A /trunk/src/skia/ext/SkFontHost_fontconfig_direct.h
   A /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   A /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.cpp
   A /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.h
   M /trunk/src/skia/skia.gyp

Linux: Add support for chrooted renderers.

http://code.google.com/p/chromium/wiki/LinuxSandboxIPC

Without filesystem access from the renderers, we need another way of
dealing with fontconfig and font loading.

This add support for:
  * An "SBX_D" environment variable in the renderers which is used to
    signal the end of dynamic linking so that the chroot can be
    enforced.
  * A sandbox_host process, running outside the sandbox, to deal with
    fontconfig requests from the renderers. See the wiki page for
    the reasoning behind making it a separate process.
  * A new, custom SkFontHost for Skia. Because this is Chrome
    specific, it will live outside the upstream Skia tree. This
    FontHost can be configured either to drive fontconfig directly
    (for the browser process and for any unsandboxed renderers) or to
    use an IPC system. Since the same SkFontHost has to be linked into
    both the browser and renderer (they are the same binary), this
    switch has to be made at run time.

Sandbox IPC calls are rare (a couple of dozen at page load time) and
add about 50us of overhead for each call.

(Reland of r17575 which was reverted in r17577)

http://codereview.chromium.org/112074
BUG=8081

------------------------------------------------------------------------
r18404 | tc@google.com | 2009-06-15 20:14:36 +0200 (Mon, 15 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix a UMR that happens while trying to forward mouse events.

The input param gets clobbered so we need to make a copy before
using it.

TEST=Run chrome via valgrind and move the mouse over the content area.  There
  should be no errors.

Review URL: http://codereview.chromium.org/126081

------------------------------------------------------------------------
r18401 | xji@chromium.org | 2009-06-15 19:45:57 +0200 (Mon, 15 Jun 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

This CL fixes issue 6223 (comment #10 and #15).

There are the following 3 issues:
1. the tab image in gray box is wrong in RTL locale. This is fixed by flipping canvas in RTL locale when draw those images.
2. dropped tab was not rendered in the correct position when gray box appears but the tab was not dropped inside the gray box. This is fixed by adjusting x coordinate of the dropped tab when there is dock information available in RTL in CompleteDrag().
3. when chrome is maximized, drag/drop a tab to left/right window, then drag the tab through original main browser tabstrip and drop it anywhere else, dropped tab was not rendered in the right position. This is fixed by initialize window create point based on source_tabstrip_, not attached_tabstrip_, and move the initialization function from Attach() (since the position is no longer related to attached_tabstrip_) to CaptureDragInfo() where the mouse_offset_ is set.

BUG=http://crbug.com/6223
TEST=
1. Open Hebrew Chrome, 
2. drag a tab to the right of the screen till the gray box showed up, the tab image showed in the gray box should be similar to the tab image in Hebrew Chrome (not that in English Chrome), 
3. drop the tab outside of the gray box while gray box is showing, the dropped tab should be rendered using the mouse click as the top-right corner (not top-left corner).
4. maximize chrome and open at least 2 tabs in it.
5. drag a tab out to left screen till the "left-half of screen" gray box showed up and drop it inside the gray box so that the tab was in the left-half of the screen and the original chrome browser is still maximized.
6. drag this tab back to the title of chrome (as if to re-insert it back to the maximized chrome's tabstrip) but do not release mouse, continue drag it back to somewhere on the screen and drop it. The dropped tab should be rendered using the mouse click as a point in its tabstrip (not rendered far away from the mouse click).


Review URL: http://codereview.chromium.org/126006
------------------------------------------------------------------------
r18400 | finnur@chromium.org | 2009-06-15 19:43:01 +0200 (Mon, 15 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Use linked_ptr for the ExternalExtensionProviders.

BUG=None
TEST=Covered by automated tests.

Review URL: http://codereview.chromium.org/125137
------------------------------------------------------------------------
r18397 | erikkay@google.com | 2009-06-15 19:29:32 +0200 (Mon, 15 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc

Clean up extension loading:
* load extensions from prefs rather than by scanning filesystem
* fix multiple loading bug
* in-place upgrade
* split out Init() behavior into individual pieces that can be called by tests

Also:
* add look up of extension by URL
* rename GetExtensionByID -> GetExtensionById

BUG=12399
BUG=14053
TEST=ExtensionServiceTest.*

Review URL: http://codereview.chromium.org/125102
------------------------------------------------------------------------
r18396 | nirnimesh@chromium.org | 2009-06-15 19:24:34 +0200 (Mon, 15 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/cocoa_utils.mm

Fix a leak in CocoaUtils::SkBitmapToNSImage

Review URL: http://codereview.chromium.org/125127
------------------------------------------------------------------------
r18395 | darin@chromium.org | 2009-06-15 19:21:10 +0200 (Mon, 15 Jun 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/webkit/api/public/WebForm.h
   M /trunk/src/webkit/api/public/WebFrameClient.h
   A /trunk/src/webkit/api/src/WebForm.cpp
   M /trunk/src/webkit/glue/autofill_form.cc
   M /trunk/src/webkit/glue/autofill_form.h
   M /trunk/src/webkit/glue/dom_operations.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/password_autocomplete_listener_unittest.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/searchable_form_data.h
   M /trunk/src/webkit/glue/webdatasource.h
   M /trunk/src/webkit/glue/webdatasource_impl.cc
   M /trunk/src/webkit/glue/webdatasource_impl.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/webkit.gyp

Extract form related classes from the guts of WebFrameImpl.

Instead of having WebFrameImpl generate SearchableFormData, PasswordForm, and AutofillForm classes, allow the embedder (RenderView) to do so.

This is done to help minimize the dependencies WebFrameImpl has on other code, which will make it easier to move WebFrame and WebDataSource into the WebKit API.

Most significant change:  Now, RenderView always sets a NavigationState on WebDataSource instances.  We used to only do so for browser initiated navigations.  This is done so that we can store things like SearchableFormData and friends on the NavigationState.

To facilitate this change, it was necessary to add a way through the WebKit API to refer to a HTMLFormElement.  This CL introduces WebForm, which is like a RefPtr<HTMLFormElement>, so you can just copy a WebForm around by value and the right thing happens.

Some of the other changes are about moving more things into the webkit_glue namespace.  On hindsight, I probably should have done that as a separate CL.

BUG=10041
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/126083
------------------------------------------------------------------------
r18394 | jrg@chromium.org | 2009-06-15 19:18:31 +0200 (Mon, 15 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm

Popuplate bookmark menus on 1st launch.

BUG=13794

TEST=launch Chrome.  Before doing anything (e.g. changing focus or
creating new windows), make sure the bookmark menu is populated.  If
you have no bookmarks you'll need to add them ('star' some URLs) then
restart Chrome.

Review URL: http://codereview.chromium.org/125094
------------------------------------------------------------------------
r18390 | pinkerton@chromium.org | 2009-06-15 18:01:47 +0200 (Mon, 15 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Badge browser window with incognito icon when in incognito mode
BUG=12536
TEST=incognito icon on window opened in incognito mode
------------------------------------------------------------------------
r18387 | sky@chromium.org | 2009-06-15 17:22:27 +0200 (Mon, 15 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Synchronizes message types.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126080
------------------------------------------------------------------------
r18385 | mad@chromium.org | 2009-06-15 16:29:21 +0200 (Mon, 15 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Reverting Rev 18383 since it brings down the performance of single core page cyclers too much...

------------------------------------------------------------------------
r18383 | mad@chromium.org | 2009-06-15 15:58:30 +0200 (Mon, 15 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

This is to thest the page cycler performance without the resize corner, to see if these paint optimizations are worth it.

I will revert these changes as needed... You may revert them yourself if they cause you trouble before I get to revert them.
I have tested these changes on two different linux configuration, but there are more code paths that I couldn't verify myself, though agl gave me the OK anyway.

These changes have already been reviewed here:
http://codereview.chromium.org/108040

------------------------------------------------------------------------
r18380 | deanm@chromium.org | 2009-06-15 12:33:53 +0200 (Mon, 15 Jun 2009) | 38 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Revert processing naming change, which breaks UI tests iterating over the
chrome processes by name.

Reverting:

commit b60e93b5ccb3bf0eefbc5b15b74b5a8be30aa589
Author: deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Mon Jun 15 09:59:38 2009 +0000

    Set process name on Linux

    This uses PR_SET_NAME to set the process name.  It was useful in looking at
    memory numbers with the zygote patches.  PR_SET_NAME is only avalaible in
    kernels >= 2.6.9 according to the man page:

    > PR_SET_NAME (since Linux 2.6.9)
    >  Set the process name for the calling process, using the value in
    >  the location pointed to by (char *) arg2.  The name can be up to
    >  16  bytes  long,  and  should  be null terminated if it contains
    >  fewer bytes.

    shenki@moya ~/src/chromium/src :process-name
    $ ps --forest
      PID TTY          TIME CMD
     5581 pts/2    00:00:00 bash
     9559 pts/2    00:00:02  \_ Chromium_Browse
     9573 pts/2    00:00:00  |   \_ Chromium_Render
     9581 pts/2    00:00:02  |   \_ Chromium_Render
     9584 pts/2    00:00:00  |   \_ Chromium_Render

    Patch by Joel Stanley.

    Review URL: http://codereview.chromium.org/118060

    git-svn-id: svn://chrome-svn/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/126119

------------------------------------------------------------------------
r18376 | deanm@chromium.org | 2009-06-15 11:59:38 +0200 (Mon, 15 Jun 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Set process name on Linux

This uses PR_SET_NAME to set the process name.  It was useful in looking at
memory numbers with the zygote patches.  PR_SET_NAME is only avalaible in
kernels >= 2.6.9 according to the man page:

> PR_SET_NAME (since Linux 2.6.9)
>  Set the process name for the calling process, using the value in
>  the location pointed to by (char *) arg2.  The name can be up to
>  16  bytes  long,  and  should  be null terminated if it contains
>  fewer bytes.

shenki@moya ~/src/chromium/src :process-name
$ ps --forest
  PID TTY          TIME CMD
 5581 pts/2    00:00:00 bash
 9559 pts/2    00:00:02  \_ Chromium_Browse
 9573 pts/2    00:00:00  |   \_ Chromium_Render
 9581 pts/2    00:00:02  |   \_ Chromium_Render
 9584 pts/2    00:00:00  |   \_ Chromium_Render

Patch by Joel Stanley.

Review URL: http://codereview.chromium.org/118060

------------------------------------------------------------------------
r18373 | yuzo@chromium.org | 2009-06-15 10:20:17 +0200 (Mon, 15 Jun 2009) | 33 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/History/history_length_test_page_1.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_11.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_12.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_2.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_21.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_22.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_3.html
   M /trunk/src/chrome/test/data/History/history_length_test_page_4.html
   M /trunk/src/chrome/test/ui/history_uitest.cc

Consider a redirect following user gesture as user-initiated in maintaining
navigation entries. Also, ignore redirect- or machine-initiated- new subframe
navigations.

The current code treats all redirects as machine-initiated in processing
navigation to a new page (to fix Bugs 9663 and 10531). This is not always
appropriate, because some sites, e.g., www.google.com/ig, use redirect to
implement user-initiated navigation (Bug 11896).

This change assumes that a machine-initiated redirect happens within 300ms
since the last document load was completed, while  a user-initiated one
happens later.

This assumption is not always correct, e.g., a user may cause transition within
300ms. But I cannot think of any better ways to tell if a redirect is machine-
initiated or user-initiated.

I believe this change works good enough, at least better than the status quo.

Review URL: http://codereview.chromium.org/115919

TEST=Open http://www.hp.com and observe it redirects to
http://www.hp.com/#Product . Hit Back button and observe
the former URL is not visited. Open http://www.google.com/ig and
click tabs inside the page, and try hitting Back and Forward to see if the
navigation is right. Open http://www.google.com/codesearch, search for
something, click on a result item, and try hitting Back.

BUG=11896,12820




------------------------------------------------------------------------
r18372 | ericroman@google.com | 2009-06-15 08:09:41 +0200 (Mon, 15 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   D /trunk/src/net/base/dns_resolution_observer.h
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/base/tcp_client_socket_pool.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/net.gyp

[Refactor] Rename DnsResolutionObserver --> HostResolver::Observer.

TEST=this is striclty a refactoring; just needs to compile and pass existing tests.

BUG=14056

Review URL: http://codereview.chromium.org/126110
------------------------------------------------------------------------
r18371 | ericroman@google.com | 2009-06-15 07:08:42 +0200 (Mon, 15 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/client_socket_handle.cc
   M /trunk/src/net/base/client_socket_handle.h
   M /trunk/src/net/base/client_socket_pool.h
   D /trunk/src/net/base/dns_resolution_observer.cc
   M /trunk/src/net/base/dns_resolution_observer.h
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/tcp_client_socket_pool.cc
   M /trunk/src/net/base/tcp_client_socket_pool.h
   M /trunk/src/net/base/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/base/tcp_client_socket_unittest.cc
   M /trunk/src/net/base/tcp_pinger_unittest.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_resolver_v8.cc

* Move the global "DnsResolutionObserver" code depended on by DNS prefetcher, into HostResolver.  This has the advantage that consumers of DNS no longer have to remember to call "DidFinishDnsResolutionWithStatus()" followed by "DidStartDnsResolution()" in order for the prefetcher to observe the resolution. Instead it just happens automatically, and subscribers register via HostResolver::AddObserver() on a particular resolver instance.

* To accomodate the prefetcher's observer, HostResolver::Resolve() needs an additional "referrer" parameter. This is slightly awkward since "referrer" has nothing to do with the actual resolve request. To simplify plumbing through this and other optional parameters, Resolve() was changed to take a "RequestInfo&" parameter in place of say {hostname, port, flags}.

* Added an option to HostResolver::Resolve() for disallowing cached responses (RequestInfo::allow_cached_response). This will be used when you refresh a page, to bypass the host cache. The code to do this has been added to HttpNetworkTransaction, but is commented out pending an appropriate unit-test to verify it.

BUG=14056

Review URL: http://codereview.chromium.org/125107
------------------------------------------------------------------------
r18370 | hbono@chromium.org | 2009-06-15 05:48:36 +0200 (Mon, 15 Jun 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Fixed 3 tests that failed in hebrew enabled vista
BrowserTest.NoTitle
BrowserTest.Title
AutomationProxyVisibleTest.WindowGetViewBounds

Some notes : 
There has been a small regression in the UI tests which makes them
get stuck even more on my very slow machine (maybe race conditions)
however, the fixes i post here do not make this state any worse
and fix these 3 tests above which always failed

TEST=1. run ui_tests on a RTL windows (or use --extra-chrome-flags=--lang=he)
2. the 3 tests listed above will always fail, as they expect LTR behavior
3. this fixes it

BUG=12636 http://code.google.com/p/chromium/issues/detail?id=12636

Original Patch by Yoav Zilberberg <yoav.zilberberg@gmail.com>
Original review: http://codereview.chromium.org/118441
R=me,jeremy,sky
Review URL: http://codereview.chromium.org/125036
------------------------------------------------------------------------
r18369 | thakis@chromium.org | 2009-06-15 01:29:00 +0200 (Mon, 15 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/history/thumbnail_database.cc

Fix commented-out favicon dumping code.

------------------------------------------------------------------------
r18368 | ben@chromium.org | 2009-06-14 23:52:13 +0200 (Sun, 14 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   D /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.cc
   D /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.h
   D /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   D /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   D /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   D /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.cc (from /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.cc:18365)
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_external_win.h (from /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.h:18365)
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.cc (from /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc:18348)
   A /trunk/src/chrome/browser/views/tab_contents/render_view_context_menu_win.h (from /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h:18348)
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.cc (from /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc:18365)
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_view_win.h (from /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h:18347)
   M /trunk/src/chrome/chrome.gyp

Move TabContentsViewWin and RenderViewContextMenu*Win to browser/views/tab_contents

They are dependent on the views API (WidgetWin, Menu2, SadTabView, etc etc) so this makes sense.

As a follow-on step, I will create a new tab_contents_view_gtk.cc/h in browser/views/tab_contents as well, so TOOLKIT_VIEWS is not exposed to bustage introduced from the non-TOOLKIT_VIEWS version of this file as it is now. I cannot have two files called "tab_contents_view_gtk" in the same directory (browser/tab_contents). Mimicking TabContentsViewWin, TOOLKIT_VIEWS TabContentsViewGtk will subclass WidgetGtk, use browser/views/sad_tab_view and utilize RenderViewContextMenuWin which is now cross platform.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/126099
------------------------------------------------------------------------
r18363 | brettw@chromium.org | 2009-06-14 17:14:53 +0200 (Sun, 14 Jun 2009) | 22 lines
Changed paths:
   M /trunk/src/app/gfx/canvas.h
   M /trunk/src/app/gfx/canvas_linux.cc
   A /trunk/src/app/gfx/canvas_paint.h
   M /trunk/src/app/gfx/canvas_win.cc
   M /trunk/src/base/gfx/native_theme.cc
   M /trunk/src/base/gfx/native_theme.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/mock_printer_driver_win.cc
   M /trunk/src/chrome/renderer/print_web_view_helper.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/skia/ext/bitmap_platform_device.h
   M /trunk/src/skia/ext/bitmap_platform_device_linux.cc
   M /trunk/src/skia/ext/bitmap_platform_device_linux.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/bitmap_platform_device_mac.h
   M /trunk/src/skia/ext/bitmap_platform_device_win.cc
   M /trunk/src/skia/ext/bitmap_platform_device_win.h
   A /trunk/src/skia/ext/canvas_paint.h
   A /trunk/src/skia/ext/canvas_paint_linux.h
   A /trunk/src/skia/ext/canvas_paint_win.h
   A /trunk/src/skia/ext/platform_canvas.cc
   M /trunk/src/skia/ext/platform_canvas.h
   M /trunk/src/skia/ext/platform_canvas_linux.cc
   D /trunk/src/skia/ext/platform_canvas_linux.h
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   D /trunk/src/skia/ext/platform_canvas_mac.h
   M /trunk/src/skia/ext/platform_canvas_win.cc
   M /trunk/src/skia/ext/platform_canvas_win.h
   M /trunk/src/skia/ext/platform_device.h
   M /trunk/src/skia/ext/platform_device_linux.cc
   M /trunk/src/skia/ext/platform_device_linux.h
   M /trunk/src/skia/ext/platform_device_mac.cc
   M /trunk/src/skia/ext/platform_device_mac.h
   M /trunk/src/skia/ext/platform_device_win.cc
   M /trunk/src/skia/ext/platform_device_win.h
   M /trunk/src/skia/ext/vector_canvas.cc
   M /trunk/src/skia/ext/vector_canvas.h
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   D /trunk/src/skia/ext/vector_device.cc
   D /trunk/src/skia/ext/vector_device.h
   A /trunk/src/skia/ext/vector_platform_device_win.cc (from /trunk/src/skia/ext/vector_device.cc:18362)
   A /trunk/src/skia/ext/vector_platform_device_win.h (from /trunk/src/skia/ext/vector_device.h:18362)
   M /trunk/src/skia/skia.gyp
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/widget/root_view_gtk.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/webkit/api/public/WebCanvas.h
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Refactor the PlatformContext layer to have only one class.

Previously we had three classes of PlatformCanvas*, one for each platform. Then
we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the
specific platform.

This means that it was almost impossible to forward-declare PlatformCanvas and
there were a bunch of unnecessary includes of platform_canvas.h in header
files.

This change makes there be only one platform_canvas.h header with ifdefs, which
removes a decent amount of duplicated code. There is a platform-independent
file, and one platform-dependent file of platform_canvas for each platform.

I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in
this case I kept the separate headers since there was much less overlap.

I also broke out CanvasPaint into separate headers so this template doesn't
need to be included all over the project (only a couple of files actually need
it).

Review URL: http://codereview.chromium.org/125109
------------------------------------------------------------------------
r18353 | phajdan.jr@chromium.org | 2009-06-13 12:29:07 +0200 (Sat, 13 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider_list.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/command_observer_bridge.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/command_updater.cc
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/debugger/debugger_host.h
   M /trunk/src/chrome/browser/debugger/debugger_io.h
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.h
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/chrome/browser/debugger/devtools_client_host.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.h
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dom_ui/debugger_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/encoding_menu_controller.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/in_process_browser_test.cc

Reduce header dependencies in browser/

- remove unneeded header includes
- move implementation bits out of headers
- more explicit header deps

In my scan of headers I got up to (including) dom_ui.

Review URL: http://codereview.chromium.org/126071
------------------------------------------------------------------------
r18352 | phajdan.jr@chromium.org | 2009-06-13 12:09:06 +0200 (Sat, 13 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/common/notification_type.h

Make extensions visible in the Task Manager.

- register for notifications when extension hosts are created/destroyed
- collapse extension tabs into just one table row, also for tabs opened while the task manager stays open

TEST=Start chrome.exe with --enable-extensions. Install the buildbot monitor extension. Open the task manager. You should see an extension process.

http://crbug.com/12127

Review URL: http://codereview.chromium.org/125047
------------------------------------------------------------------------
r18351 | aa@chromium.org | 2009-06-13 09:08:20 +0200 (Sat, 13 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   A /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
   A /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/1
   A /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/1/manifest.json (from /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/1/manifest.json:18350)
   A /trunk/src/chrome/test/data/extensions/bad/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Current Version (from /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/Current Version:18350)
   A /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
   A /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/1
   A /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/1/not_a_manifest (from /trunk/src/chrome/test/data/extensions/bad/no_manifest/1/not_a_manifest:18350)
   A /trunk/src/chrome/test/data/extensions/bad/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/Current Version (from /trunk/src/chrome/test/data/extensions/bad/missing_content_script/Current Version:18350)
   A /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa
   A /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0
   A /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/bad/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version (from /trunk/src/chrome/test/data/extensions/good/extension3/Current Version:18350)
   A /trunk/src/chrome/test/data/extensions/bad/cccccccccccccccccccccccccccccccc
   A /trunk/src/chrome/test/data/extensions/bad/cccccccccccccccccccccccccccccccc/git_abhors_empty_dirs (from /trunk/src/chrome/test/data/extensions/bad/no_version/git_abhors_empty_dirs:18350)
   D /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/Current Version
   D /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/bad/missing_content_script/Current Version
   D /trunk/src/chrome/test/data/extensions/bad/no_manifest/1/not_a_manifest
   D /trunk/src/chrome/test/data/extensions/bad/no_manifest/Current Version
   D /trunk/src/chrome/test/data/extensions/bad/no_version/git_abhors_empty_dirs
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/js_files
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/js_files/script3.js (from /trunk/src/chrome/test/data/extensions/good/extension1/1/js_files/script3.js:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json (from /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script1.js (from /trunk/src/chrome/test/data/extensions/good/extension1/1/script1.js:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script2.js (from /trunk/src/chrome/test/data/extensions/good/extension1/1/script2.js:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style1.css (from /trunk/src/chrome/test/data/extensions/good/extension1/1/style1.css:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/style2.css (from /trunk/src/chrome/test/data/extensions/good/extension1/1/style2.css:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html (from /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html (from /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip2.html:18350)
   A /trunk/src/chrome/test/data/extensions/good/behllobkkfkfnphdnhnkndlbkcpglgmj/Current Version
   A /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa
   A /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0
   A /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/good/bjafgdebaacbbbecmhlhpofkepfkgcpa/Current Version (from /trunk/src/chrome/test/data/extensions/good/extension3/Current Version:18350)
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/js_files/script3.js
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/script1.js
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/script2.js
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/style1.css
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/style2.css
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip2.html
   D /trunk/src/chrome/test/data/extensions/good/extension1/Current Version
   D /trunk/src/chrome/test/data/extensions/good/extension2/2/background.html
   D /trunk/src/chrome/test/data/extensions/good/extension2/2/content_plugin.dll
   D /trunk/src/chrome/test/data/extensions/good/extension2/2/extension_plugin.dll
   D /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/extension2/Current Version
   D /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/extension3/Current
   D /trunk/src/chrome/test/data/extensions/good/extension3/Current Version
   A /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk
   A /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2
   A /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/background.html (from /trunk/src/chrome/test/data/extensions/good/extension2/2/background.html:18350)
   A /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/content_plugin.dll (from /trunk/src/chrome/test/data/extensions/good/extension2/2/content_plugin.dll:18350)
   A /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/extension_plugin.dll (from /trunk/src/chrome/test/data/extensions/good/extension2/2/extension_plugin.dll:18350)
   A /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/2/manifest.json
   A /trunk/src/chrome/test/data/extensions/good/hpiknbiabeeppbpihjehijgoemciehgk/Current Version (from /trunk/src/chrome/test/data/extensions/good/extension2/Current Version:18350)
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Change extension id format back to mp-decimal, and change the
length to 32 chars (exactly 128 bits).

Review URL: http://codereview.chromium.org/126074
------------------------------------------------------------------------
r18349 | ananta@chromium.org | 2009-06-13 07:35:44 +0200 (Sat, 13 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.h

The context menu in external hosts would not work as expected as the command ids received from the TrackPopupMenuEx call
were the indices of the commands. This was because of the MNS_NOTIFYBYPOS menu style on the context menu coming in from chrome.

Fix is to turn off this style for external hosts.

R=ben

Review URL: http://codereview.chromium.org/126091
------------------------------------------------------------------------
r18348 | ben@chromium.org | 2009-06-13 07:15:46 +0200 (Sat, 13 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc

Restructure menu initialization for the TabContents. InitMenu cannot be called from the constructor because it seems to break RenderViewContextMenuExternalWin's virtual AppendItem from being called.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126089
------------------------------------------------------------------------
r18344 | estade@chromium.org | 2009-06-13 03:23:16 +0200 (Sat, 13 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

gtk bookmark manager:

- Implement list view activation.
- Fix a crasher.

TEST=double click on something in the right pane (folder or bookmark)
http://crbug.com/13110

Review URL: http://codereview.chromium.org/126084
------------------------------------------------------------------------
r18342 | estade@chromium.org | 2009-06-13 03:13:34 +0200 (Sat, 13 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

GTK: Fix refresh accelerators.

by Jacob Mandelson <jacob@mandelson.org>
original review: http://codereview.chromium.org/127001

Review URL: http://codereview.chromium.org/125093
------------------------------------------------------------------------
r18340 | jrg@chromium.org | 2009-06-13 02:53:18 +0200 (Sat, 13 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   A /trunk/src/chrome/browser/cocoa/cocoa_utils.h
   A /trunk/src/chrome/browser/cocoa/cocoa_utils.mm
   A /trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/skia/skia.gyp

Add favicons to Mac bookmark bar.
BUG=8381

TEST=Open bookmark bar (Cmd-B).  Add some bookmarks with sites that
have favicons (cnn.com).  See icons in bookmark buttons.  Make sure
color is correct.

Review URL: http://codereview.chromium.org/125061
------------------------------------------------------------------------
r18339 | estade@chromium.org | 2009-06-13 02:51:48 +0200 (Sat, 13 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_factory_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

Make findbar paint themed image.

Also, fixed drawing of background images that are not 1 pixel wide. (The code for this is somewhat speculative as there is no way of testing it at the moment, but for now it should still at least look correct.)

If you open the findbar while the bookmark bar is opened and then close the bookmark bar, the findbar painting is a little messed up in that it still thinks it's farther away from the tabstrip than it really is. The solution (unfortunately) is to continuously repaint the findbar as it is closing. Since this is glitch is hardly noticeable, I'm putting off fixing it.

TEST=findbar should look more integrated with bookmark bar, toolbar.
BUG=none

Review URL: http://codereview.chromium.org/125084
------------------------------------------------------------------------
r18338 | stuartmorgan@chromium.org | 2009-06-13 02:44:13 +0200 (Sat, 13 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc

Restores an early return that was incorrectly removed in the PasswordStore refactoring.

BUG=13979
TEST=Save a password on a site with a valid SSL certificate, then visit in when the cert is no longer valid.
Review URL: http://codereview.chromium.org/125074
------------------------------------------------------------------------
r18336 | erg@google.com | 2009-06-13 02:17:18 +0200 (Sat, 13 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.h
   A /trunk/src/chrome/browser/blocked_popup_container_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/chrome.gyp

Create a basic test case for the common usage of BlockedPopupContainer.

Review URL: http://codereview.chromium.org/125083
------------------------------------------------------------------------
r18334 | tc@google.com | 2009-06-13 01:45:40 +0200 (Sat, 13 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_titlebar.cc

Fix a bug where both restore and maximize buttons were showing after
toggling window manager decorations on/off.

TBR=estade

Review URL: http://codereview.chromium.org/125090

------------------------------------------------------------------------
r18330 | stuartmorgan@chromium.org | 2009-06-13 01:00:05 +0200 (Sat, 13 Jun 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/password_manager/login_database.cc
   A /trunk/src/chrome/browser/password_manager/login_database.h
   A /trunk/src/chrome/browser/password_manager/login_database_mac.cc
   A /trunk/src/chrome/browser/password_manager/login_database_mac.h
   A /trunk/src/chrome/browser/password_manager/login_database_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Copy login-related section of WebDatabase into a new class for use in PasswordStore.

The platform-specific inheritence here is because the current Windows implementation of PasswordStore is a temporary shim, and will eventually need to use its own database instead; since we'll need almost all the fields on the Mac for the bag-on-the-side anyway, it makes sense to share as much of this implementation as possible.

The code and unit tests are pretty much unchanged from WebDatabase (except for the inheritence stuff); the duplication should be temporary as the WebDatabase copy will be removed once Windows switches (and migrates their passwords).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119392
------------------------------------------------------------------------
r18328 | tc@google.com | 2009-06-13 00:39:57 +0200 (Sat, 13 Jun 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/browser_titlebar.cc
   A /trunk/src/chrome/browser/gtk/browser_titlebar.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/chrome.gyp

Refactor the titlebar code into its own class because it's getting big
and cluttering up browser_window_gtk.

Fix a small painting bug when a menu is drawn over the titlebar background.

Also move the tab strip context menu into the titlebar background container
by adding an event box.  Now the context menu appears e.g., below the
min/max/close buttons or above the tab strip.

Review URL: http://codereview.chromium.org/125078

------------------------------------------------------------------------
r18327 | tc@google.com | 2009-06-13 00:16:57 +0200 (Sat, 13 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

Use a bool instead of disconnecting/reconnecting the changed
signal handler.  I don't really care one way or the other :)

Review URL: http://codereview.chromium.org/118518

------------------------------------------------------------------------
r18326 | mhm@chromium.org | 2009-06-13 00:07:28 +0200 (Sat, 13 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h

Google Gears should be renamed to Gears

BUG=6234 (http://crbug.com/6234)
TEST=Checked the Google Gears screen to see if they got changed.
Wrench > Options > Under the Hood > Web Content


Review URL: http://codereview.chromium.org/125037
------------------------------------------------------------------------
r18321 | cpu@google.com | 2009-06-12 23:34:14 +0200 (Fri, 12 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run_win.cc

Tweaks to the try chrome toast
- Wire it to the cmdline param --try-chrome-again
- Set window bounds so it looks nice on Vista
- Enable the link to help center

BUG=b/1484308
TEST=see the bug

Review URL: http://codereview.chromium.org/126029
------------------------------------------------------------------------
r18319 | estade@chromium.org | 2009-06-12 23:15:44 +0200 (Fri, 12 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Fix themed toolbar drawing following tabstrip changes.

The code should also be more robust to future changes.

BUG=none
TEST=active tab blends into toolbar

Review URL: http://codereview.chromium.org/126013
------------------------------------------------------------------------
r18318 | stuartmorgan@chromium.org | 2009-06-12 23:15:33 +0200 (Fri, 12 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

Handle file descriptor exhaustions a little more gracefully. This prevents the browser itself from crashing in Intl2 page cycler tests on the Mac (although the renderer still dies, at least in debug), so that seems like a good idea whatever larger solution we find for the file descriptor issue.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/125024
------------------------------------------------------------------------
r18316 | rafaelw@chromium.org | 2009-06-12 22:45:45 +0200 (Fri, 12 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/bad_hash.crx
   D /trunk/src/chrome/test/data/extensions/bad_json.crx
   M /trunk/src/chrome/test/data/extensions/bad_magic.crx
   A /trunk/src/chrome/test/data/extensions/bad_signature.crx
   M /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good.crx
   A /trunk/src/chrome/test/data/extensions/good.pem
   M /trunk/src/chrome/test/data/extensions/good2.crx
   M /trunk/src/chrome/test/data/extensions/page_action.crx
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/manifest.json
   M /trunk/src/chrome/test/data/extensions/theme.crx
   M /trunk/src/chrome/test/data/extensions/theme2.crx
   M /trunk/src/chrome/test/data/extensions/theme_with_extension.crx
   A /trunk/src/chrome/test/data/extensions/theme_with_missing_image.crx
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json
   M /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/simple_api_call/manifest.json

Verify signed .crx extension installations

This is second try of:

http://codereview.chromium.org/115682

that was comitted in in 18189 and reverted.

BUG=12114
R=erikkay,wtc,aa

Review URL: http://codereview.chromium.org/126014
------------------------------------------------------------------------
r18315 | ben@chromium.org | 2009-06-12 22:44:28 +0200 (Fri, 12 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h

Remove the Menu object, converting all the remaining callers to use Menu2. I'll rename Menu2->Menu afterwards.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/122027
------------------------------------------------------------------------
r18312 | thestig@chromium.org | 2009-06-12 22:36:55 +0200 (Fri, 12 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/DEPS
   M /trunk/src/chrome/browser/DEPS
   D /trunk/src/chrome/common/gfx/DEPS
   M /trunk/src/chrome/renderer/DEPS
   D /trunk/src/chrome/test/perf/DEPS
   M /trunk/src/chrome/tools/DEPS

DEPS cleanup.
Review URL: http://codereview.chromium.org/118317
------------------------------------------------------------------------
r18307 | estade@chromium.org | 2009-06-12 21:58:24 +0200 (Fri, 12 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc

Revert thakis's changes to download_file.cc from r17595.

BUG=13991

Review URL: http://codereview.chromium.org/126066
------------------------------------------------------------------------
r18302 | pkasting@chromium.org | 2009-06-12 21:18:54 +0200 (Fri, 12 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc

Change some DCHECKs to CHECKs in hope of tracking down a crash.

BUG=13986
TEST=none
Review URL: http://codereview.chromium.org/125066
------------------------------------------------------------------------
r18301 | jcampan@chromium.org | 2009-06-12 21:14:54 +0200 (Fri, 12 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.h
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.cc
   M /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/views/controls/native/native_view_host_gtk.cc
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/widget/widget_win.cc

Changing the focus manager to not subclass HWNDs (but for the top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected.
Review URL: http://codereview.chromium.org/122002
------------------------------------------------------------------------
r18296 | erikkay@google.com | 2009-06-12 20:39:25 +0200 (Fri, 12 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc

Fix object ownership and cleanup issues between ExtensionHost and ExtensionView.  This was leading to crashes at shutdown as well as shutdown code not cleaning up properly.

BUG=13974
TEST=none


Review URL: http://codereview.chromium.org/126064
------------------------------------------------------------------------
r18292 | xji@chromium.org | 2009-06-12 20:01:47 +0200 (Fri, 12 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/views/view.h

This CL fixes issue 6103 -- Individual download items on the download shelf are not mirrored on RTL locales,
and issue 13217 -- Dangerous File warning on the shelf in RTL seems to misplace the buttons

Enable UI mirroring for DownloadItemView.
During painting each download items, for those items without corresponding mirrored images, flip the canvas to paint the mirrored image. And flip canvas back to normal to paint others.

BUG=http://crbug.com/6103
BUG=http://crbug.com/13217
Test=Open Hebrew Chrome, go to "http://build.chromium.org/buildbot/continuous/LATEST/", download mini_installer.exe, the layout of the warning should be "cancel_button ok_button warning_message warning_icon" from left to right. Click "ok" to download, the layout of the download item in download shelf should be "drop_down_icon download_file_name(or download_file_name with download_status) download_progress_animation and download icon" from left to right.

Review URL: http://codereview.chromium.org/118260
------------------------------------------------------------------------
r18291 | agl@chromium.org | 2009-06-12 19:36:55 +0200 (Fri, 12 Jun 2009) | 16 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/file_util_posix.cc
   A /trunk/src/base/global_descriptors_posix.cc
   A /trunk/src/base/global_descriptors_posix.h
   M /trunk/src/base/logging.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   D /trunk/src/base/reserved_file_descriptors.h
   A /trunk/src/base/unix_domain_socket_posix.cc
   A /trunk/src/base/unix_domain_socket_posix.h
   D /trunk/src/base/zygote_manager.cc
   D /trunk/src/base/zygote_manager.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   A /trunk/src/chrome/browser/zygote_host_linux.cc
   A /trunk/src/chrome/browser/zygote_host_linux.h
   A /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/chrome_descriptors.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/ipc_channel.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/process_watcher_posix.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/chrome_process_util.cc

Linux: refactor zygote support

http://code.google.com/p/chromium/wiki/LinuxZygote

  * Move Chrome specific bits out of base
  * Move away from the idea of reserved file descriptors (which don't really work
  with zygotes)
  * Load resources before forking renderers (means that we don't need
  communication between the zygote process and the renderers)
  * Make sure that gdb works against the browser again
  * Make sure that we have different ASLR between the renderers and the browser.

http://codereview.chromium.org/119335

(This is a reland. First landed in r18109, reverted in r18112.)

------------------------------------------------------------------------
r18290 | jcampan@chromium.org | 2009-06-12 19:36:50 +0200 (Fri, 12 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h

This makes the network column in the task manager not display NA as network usage is available.

BUG=http://crbug.com/13958
TEST=Open the task manager, the network column for the browser process should be showing 0. Type something in the location bar, the value should change.
Review URL: http://codereview.chromium.org/125056
------------------------------------------------------------------------
r18285 | erg@google.com | 2009-06-12 19:11:28 +0200 (Fri, 12 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc

GTK: Change BlockedPopupContainerView to a cairo implementation.

http://crbug.com/12843

Review URL: http://codereview.chromium.org/126017
------------------------------------------------------------------------
r18281 | jar@chromium.org | 2009-06-12 18:52:21 +0200 (Fri, 12 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Histogram count of number of command line arguments

This should help us evaluate which users are manually switching on 
non-standard options, which in turn may impact stability.

r=huanr
Review URL: http://codereview.chromium.org/126024
------------------------------------------------------------------------
r18280 | jar@chromium.org | 2009-06-12 18:52:10 +0200 (Fri, 12 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc

Add back in log info about histogram hashes

This was seemingly inadvertently deleted in a CL

http://src.chromium.org/viewvc/chrome?view=rev&revision=16023

The change should have no semantic impact on the running of the program
(unless the user enables logging), and it helps me isolate actual names
of histograms for unknown hashes that appear on the histogram dashboard.

r=evanm,dpranke
Review URL: http://codereview.chromium.org/125011
------------------------------------------------------------------------
r18267 | sky@chromium.org | 2009-06-12 16:34:39 +0200 (Fri, 12 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/views/tabs/tab_overview_types.cc
   A /trunk/src/chrome/browser/views/tabs/tab_overview_types.h

Adds wiring for tab overview.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/125020
------------------------------------------------------------------------
r18251 | finnur@chromium.org | 2009-06-12 07:05:41 +0200 (Fri, 12 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fixing memleak found by purify.

This should fix leaks at:
extensions_service.cc:495 and 498
... and since the providers are getting cleaned up, it should take care of:
extensions_service.cc:211
... as well.

TBR=erikkay
TEST=Covered by automated tests.
BUG=None

Review URL: http://codereview.chromium.org/126037
------------------------------------------------------------------------
r18250 | ananta@chromium.org | 2009-06-12 05:50:39 +0200 (Fri, 12 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.cc
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_external_win.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/menu_win.h

Allow external hosts to handle the context menu and thus be able to customize it.

Changes include 
1. A HandleContextMenu function which can be implemented by a TabContentsDelegate. Currently only ExternalTabContainer implements this.

2. Removed InitMenu calls from the RenderViewContextMenu subclass constructors, We need the subclasses to be able to override individual AddMenuItem calls. The newly added RenderViewContextMenuExternalWin class derives from RenderViewContextMenuWin whose constructor calls InitMenu. This happens at a time when the vtable is not yet setup. To fix this we added an Init function to the RenderViewContextMenu base class which then calls a virtual function DoInit, which derived classes can override to perform specific initializations.

3. Added automation messages to send over context menu events to external hosts and back

amit, please review everything. estade please review changes to tab_contents_view_gtk.cc and 
render_view_context_menu_gtk.cc. pinkerton please review changes to tab_contents_view_mac.mm and
render_view_context_menu_mac.mm


Review URL: http://codereview.chromium.org/119429
------------------------------------------------------------------------
r18247 | finnur@chromium.org | 2009-06-12 04:51:34 +0200 (Fri, 12 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/browser/extensions/external_extension_provider.h
   A /trunk/src/chrome/browser/extensions/external_pref_extension_provider.cc
   A /trunk/src/chrome/browser/extensions/external_pref_extension_provider.h
   A /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.cc
   A /trunk/src/chrome/browser/extensions/external_registry_extension_provider_win.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.gyp

Factor out the code that deals with installing external extensions through Registry and Preferences into separate classes. While I was at it, I removed the EXTERNAL_INSTALL file, since we now keep track of this in the Preferences.

This also takes care of the virtualization problem in the unit tests for vista (see bug).

BUG=13063
TEST=None, covered by automated tests.
Review URL: http://codereview.chromium.org/122004
------------------------------------------------------------------------
r18246 | willchan@chromium.org | 2009-06-12 04:29:49 +0200 (Fri, 12 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/test/data/purify/unit_tests.exe_MLK.txt

Fix leak in my interstitial page test.
Re-enable leaky web_contents_unittest.cc interstitial test.
Remove purify suppressions for leaky test.
BUG=http://crbug.com/13937

Review URL: http://codereview.chromium.org/125033
------------------------------------------------------------------------
r18241 | mhm@chromium.org | 2009-06-12 03:14:04 +0200 (Fri, 12 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/toolbar_model.cc

Spaces are not URL-encoded in the Omnibar

BUG=13818 (http://crbug.com/13818)

TEST=tests urls with spaces as well as files

Review URL: http://codereview.chromium.org/126025
------------------------------------------------------------------------
r18239 | willchan@chromium.org | 2009-06-12 03:04:50 +0200 (Fri, 12 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Oops, disable the correct test this time :)
http://crbug.com/13937

Review URL: http://codereview.chromium.org/126026
------------------------------------------------------------------------
r18237 | willchan@chromium.org | 2009-06-12 02:56:13 +0200 (Fri, 12 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Disable leaky web_contents_unittest.cc interstitial test.
BUG=http://crbug.com/13937.

Review URL: http://codereview.chromium.org/125029
------------------------------------------------------------------------
r18236 | ericroman@google.com | 2009-06-12 02:49:38 +0200 (Fri, 12 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   A /trunk/src/net/base/address_list_unittest.cc
   M /trunk/src/net/base/client_socket_pool.h
   A /trunk/src/net/base/host_cache.cc
   A /trunk/src/net/base/host_cache.h
   A /trunk/src/net/base/host_cache_unittest.cc
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/tcp_client_socket_pool.cc
   M /trunk/src/net/base/tcp_client_socket_pool.h
   M /trunk/src/net/base/tcp_client_socket_pool_unittest.cc
   M /trunk/src/net/base/tcp_client_socket_unittest.cc
   M /trunk/src/net/base/tcp_pinger_unittest.cc
   M /trunk/src/net/ftp/ftp_network_layer.cc
   M /trunk/src/net/ftp/ftp_network_layer.h
   M /trunk/src/net/ftp/ftp_network_session.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_resolver_perftest.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.cc
   M /trunk/src/net/proxy/proxy_resolver_v8.h
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/tools/fetch/fetch_client.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

* Avoid doing concurrent DNS resolves of the same hostname in HostResolver.

* Add a 1 minute cache for host resolves.

* Refactor HostResolver to handle multiple requests.

* Make HostResolver a dependency of URLRequestContext. operate the HostResolver
in async mode for proxy resolver (bridging to IO thread).

TEST=unittests
BUG=13163

Review URL: http://codereview.chromium.org/118100
------------------------------------------------------------------------
r18225 | estade@chromium.org | 2009-06-12 00:57:16 +0200 (Fri, 12 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Linux: Special case focus handling so that we don't tell webkit it's lost focus when a context menu is showing.

BUG=13404,13554
TEST=copy/paste *via the right-click context menu* works as expected in gmail.

Review URL: http://codereview.chromium.org/118339
------------------------------------------------------------------------
r18222 | estade@chromium.org | 2009-06-12 00:55:48 +0200 (Fri, 12 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/base/mime_util_linux.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

Linux: fix icon theme double free on shutdown by eliminating dupes from icon theme array.

Simplify some code in DownloadItemGtk that I previously thought was related to the crash, and so had made complicated.

Review URL: http://codereview.chromium.org/124001
------------------------------------------------------------------------
r18219 | sky@chromium.org | 2009-06-12 00:28:34 +0200 (Fri, 12 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

UI tweaks for the tab strip on linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/125012
------------------------------------------------------------------------
r18217 | tc@google.com | 2009-06-12 00:25:47 +0200 (Fri, 12 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc

Fix a layout bug in the fonts and languages dialog where
buttons get cut off on the right side of the dialog.  Instead
of sizing the label text based on a constant from the localized
resources, use the default text size (no-multiline text).

I also tightened up the font preview box to just use
the size of  the text + a constant padding on all sides.

BUG=13366

Review URL: http://codereview.chromium.org/125013
------------------------------------------------------------------------
r18212 | ericroman@google.com | 2009-06-11 23:53:55 +0200 (Thu, 11 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc

Change DnsMaster to only access HostResolver only on the IO thread.
And plumb through an (unused) HostResolver dependency into DnsMaster.

This is in preparation for <http://codereview.chromium.org/118100> which turns HostResolver into a (non-thread-safe) shared dependency of the URLRequestContext.

After CL 118100, DnsMaster will be issuing host resolves through the main URLRequestContext's HostResolver (now on the IO thread). This will have the effect of warming the shared HostResolver's internal cache.

BUG=13163
TEST=existing unit tests

Review URL: http://codereview.chromium.org/122028
------------------------------------------------------------------------
r18211 | brettw@google.com | 2009-06-11 23:46:53 +0200 (Thu, 11 Jun 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Make sure view-source: is applied to RenderView when it is reused for a new
navigation. On page loading errors, WebFrameImpl::DidFail() will call
RenderView::OnEnableViewSourceMode(false) not to show error pages in view
source mode. We should overwrite the mode for new navigations not to show
view-source: added inputs in non view-source mode.

This fix is related to
http://code.google.com/p/chromium/issues/detail?id=4516
But this doesn't resolve reloading case.

BUG=none

TEST=1) View some site using view-source:. 2) let the site return error for
        example 404 Not Found, and then view using view-source:. 3) make it 200
        again and view using view-source:. It must show source code.
Original review: http://codereview.chromium.org/119233
Patch by tyoshino@google.com
------------------------------------------------------------------------
r18210 | gwilson@google.com | 2009-06-11 23:43:02 +0200 (Thu, 11 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h

Adds the ability to import the home page of the default browser.  The import always existed, but was never hooked up to an installerdata preference.

R=cpu
BUG=13752
TEST=Run the installer with a line in the distribution block of the installerdata that reads: "import_home_page" : true.  The home page of the previous default browser should be imported.

Review URL: http://codereview.chromium.org/118512
------------------------------------------------------------------------
r18207 | erg@google.com | 2009-06-11 23:37:15 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h

GTK: Graphical polish on the BlockedPopupContainerView. Specifically, rounded borders and background gradient.

http://crbug.com/12843

Review URL: http://codereview.chromium.org/125007
------------------------------------------------------------------------
r18196 | estade@chromium.org | 2009-06-11 22:56:55 +0200 (Thu, 11 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

GTK: shift-enter in find bar searches backwards.

BUG=13520
TEST=use shift enter in find bar

Review URL: http://codereview.chromium.org/122047
------------------------------------------------------------------------
r18194 | jhawkins@chromium.org | 2009-06-11 22:53:30 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h

Use the MessageLoopForUI::Observer interface to listen for mouse motion events instead of hooking up to the global gdk event handler.  Once we hook up to the global handler and disconnect from it, the MessageLoopForUI will be broken because we stole the handler from it.

BUG=none
TEST=Exhaustively test dragging tabs in and out of multiple tabstrips.
Review URL: http://codereview.chromium.org/126001
------------------------------------------------------------------------
r18193 | tc@google.com | 2009-06-11 22:46:20 +0200 (Thu, 11 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/bad_hash.crx
   A /trunk/src/chrome/test/data/extensions/bad_json.crx
   M /trunk/src/chrome/test/data/extensions/bad_magic.crx
   M /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good.crx
   D /trunk/src/chrome/test/data/extensions/good.pem
   M /trunk/src/chrome/test/data/extensions/good2.crx
   M /trunk/src/chrome/test/data/extensions/page_action.crx
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/manifest.json
   M /trunk/src/chrome/test/data/extensions/theme.crx
   M /trunk/src/chrome/test/data/extensions/theme2.crx
   M /trunk/src/chrome/test/data/extensions/theme_with_extension.crx
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json
   M /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/simple_api_call/manifest.json

Revert "BUG=12114"

This reverts commit r18189.

TBR=rafaelw

Review URL: http://codereview.chromium.org/125004

------------------------------------------------------------------------
r18189 | rafaelw@chromium.org | 2009-06-11 22:16:09 +0200 (Thu, 11 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/bad_hash.crx
   D /trunk/src/chrome/test/data/extensions/bad_json.crx
   M /trunk/src/chrome/test/data/extensions/bad_magic.crx
   M /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good.crx
   A /trunk/src/chrome/test/data/extensions/good.pem
   M /trunk/src/chrome/test/data/extensions/good2.crx
   M /trunk/src/chrome/test/data/extensions/page_action.crx
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/manifest.json
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/manifest.json
   M /trunk/src/chrome/test/data/extensions/theme.crx
   M /trunk/src/chrome/test/data/extensions/theme2.crx
   M /trunk/src/chrome/test/data/extensions/theme_with_extension.crx
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json
   M /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/manifest.json
   M /trunk/src/chrome/test/data/extensions/uitest/simple_api_call/manifest.json

BUG=12114
R=erikkay,wtc

Review URL: http://codereview.chromium.org/115682
------------------------------------------------------------------------
r18187 | idanan@chromium.org | 2009-06-11 21:13:54 +0200 (Thu, 11 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Issue 3791: SavePageTest.* is crap

Modifying flaky test so that it waits for a file to stop being written 
rather than starts existing. Otherwise the compare check fails some times.
I know Windows has a more efficient API to do this but for the sake of
multiplatform compatibility, the solution is completely generic.

BUG=3791

Review URL: http://codereview.chromium.org/123026
------------------------------------------------------------------------
r18186 | aa@chromium.org | 2009-06-11 20:54:45 +0200 (Thu, 11 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix memory leak in ExtensionsService when skipping loaded
extensions.

Review URL: http://codereview.chromium.org/122021
------------------------------------------------------------------------
r18181 | stoyan@chromium.org | 2009-06-11 20:22:19 +0200 (Thu, 11 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Get tab HWND directly as result of CreateExternalTab automation call.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119448
------------------------------------------------------------------------
r18176 | estade@chromium.org | 2009-06-11 19:50:15 +0200 (Thu, 11 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

GTK: Forward certain key strokes from the find bar to the render view.

The choice of keystrokes matches windows.

BUG=12697
TEST=press up or down in find bar; page should scroll (assuming it can scroll)

Review URL: http://codereview.chromium.org/122014
------------------------------------------------------------------------
r18174 | jhawkins@chromium.org | 2009-06-11 19:31:17 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Start the resize animation after a delay once the mouse has left the tabstrip zone.

BUG=13471
TEST=Open enough tabs in a browser window so that they must resize.  Close a few tabs in the middle of the tabstrip.  The tabs should not resize.  Now move the mouse outside of the tabstrip zone (40 pixels below).  The tabs should resize after a short delay.
Review URL: http://codereview.chromium.org/123005
------------------------------------------------------------------------
r18172 | agl@chromium.org | 2009-06-11 19:28:41 +0200 (Thu, 11 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc

Another fix for issue 13724: Don't hard code chrome.exe

Use chrome::kBrowserProcessExecutableName instead.

BUG=13724
http://codereview.chromium.org/123022

(By Edward Crossman)

------------------------------------------------------------------------
r18166 | tc@google.com | 2009-06-11 17:54:26 +0200 (Thu, 11 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   D /trunk/src/chrome/browser/renderer_preferences.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   A /trunk/src/chrome/common/renderer_preferences.h (from /trunk/src/chrome/browser/renderer_preferences.h:18163)
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/render_view_test.cc

Move renderer_preferences.h from chrome/browser into chrome/common.  We
include the file in chrome/renderer and chrome/browser so to make check
deps happy, I'm putting the file in chrome/common.

Review URL: http://codereview.chromium.org/123001

------------------------------------------------------------------------
r18158 | deanm@chromium.org | 2009-06-11 13:43:31 +0200 (Thu, 11 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Revert mad's backing store changes, it completely hosed Linux painting.

This was r18090, reverted in r18092, recommitted without review in 18130.

Review URL: http://codereview.chromium.org/122034

------------------------------------------------------------------------
r18154 | deanm@chromium.org | 2009-06-11 12:09:05 +0200 (Thu, 11 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

Final touches on the Linux BookmarkBubble.
  - Implement "close on escape" with a top level accelerator.
  - Fix an invalid read when opening the editor from the folder combo.
  - Clean up some signal handlers (returning bool from a void function, etc).

BUG=11738

Review URL: http://codereview.chromium.org/118493

------------------------------------------------------------------------
r18153 | pfeldman@chromium.org | 2009-06-11 11:36:59 +0200 (Thu, 11 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc

DevTools: Keep Resources panel enabled status upon frame navigate.

Review URL: http://codereview.chromium.org/118508
------------------------------------------------------------------------
r18151 | thakis@chromium.org | 2009-06-11 07:18:21 +0200 (Thu, 11 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix browser window crash on windows.

BUG=13681 (http://crbug.com/13681)

TEST=Follow these steps
-Ctrl+Shift+N to Incognito window.
-Download a file
-Close the Incognito window after download is finished.

Review URL: http://codereview.chromium.org/120001
------------------------------------------------------------------------
r18150 | willchan@chromium.org | 2009-06-11 06:49:42 +0200 (Thu, 11 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Fix crash on interstitial page when the renderer crashed.
Simply add a NULL check to make sure the view is still there before showing it.
Also fix a debug crash since the ResourceDispatcherHost assumes that it should always find the pid & route_id key, which is not true if the renderer crashed.
BUG=http://crbug.com/13795
TEST=See bug for repro instructions.

Review URL: http://codereview.chromium.org/122025
------------------------------------------------------------------------
r18149 | aa@chromium.org | 2009-06-11 06:27:12 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   D /trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json
   D /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html

Revert "Add support to the automation provider to test sending browser"

This reverts commit 4775c631c09be565706f8a6ce3c4659bc89097e4.

Review URL: http://codereview.chromium.org/122024
------------------------------------------------------------------------
r18148 | aa@chromium.org | 2009-06-11 05:52:30 +0200 (Thu, 11 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   A /trunk/src/chrome/test/data/extensions/uitest/event_sink
   A /trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/event_sink/test.html

Add support to the automation provider to test sending browser
events to extensions. Implements an initial test that send all
known window, tab, page action, and bookmark events and makes
sure the extension received them.

Original review: http://codereview.chromium.org/119325

Review URL: http://codereview.chromium.org/123010
------------------------------------------------------------------------
r18147 | aa@chromium.org | 2009-06-11 05:46:36 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Revert "Add support to the automation provider to test sending browser"

This reverts commit 9b7fbb1e720ab2071b30531fd0266918c4e68d12.

Review URL: http://codereview.chromium.org/122022
------------------------------------------------------------------------
r18146 | aa@chromium.org | 2009-06-11 05:10:55 +0200 (Thu, 11 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc

Add support to the automation provider to test sending browser
events to extensions. Implements an initial test that send all
known window, tab, page action, and bookmark events and makes
sure the extension received them.

Original review: http://codereview.chromium.org/119325

Review URL: http://codereview.chromium.org/123009
Patch from Roger Tawa <rogerta@gmail.com>.
------------------------------------------------------------------------
r18140 | aa@chromium.org | 2009-06-11 04:06:45 +0200 (Thu, 11 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix extension loading code to properly filter out non-themes
when extensions are disabled.

BUG=12076
TEST=Added a unit test. Also, install an extension, then create a new version of it and overinstall. You should not see two of them.

Review URL: http://codereview.chromium.org/123004
------------------------------------------------------------------------
r18136 | estade@chromium.org | 2009-06-11 03:17:09 +0200 (Thu, 11 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h

Linux bookmark manager:

- Add more dragging.
- Make right pane updating less clobbery.

Review URL: http://codereview.chromium.org/122005
------------------------------------------------------------------------
r18135 | estade@chromium.org | 2009-06-11 03:16:28 +0200 (Thu, 11 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc

If widget is too small to render a nine box, just return (don't DCHECK).

When I initially added that DCHECK, we did not have any animations, so it was always a mistake to have a widget that was too small. Now that we do have animations, this is no longer true. Instead of having to work around this DCHECK with minimum size hacks, get rid of the hack and paint nothing.

TEST=download a safe thing and an unsafe thing. Open and close the bookmark bar and findbar a lot. Everything looks ok and doesn't crash.
http://crbug.com/13343

Review URL: http://codereview.chromium.org/118393
------------------------------------------------------------------------
r18132 | estade@chromium.org | 2009-06-11 03:10:46 +0200 (Thu, 11 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Fix a couple problems with DownloadItemGtk.

1) We were crashing after removing a download item because g_signal_handler_find() was not working as expected.
2) We had a graphical glitch with the dangerous download dialog because GtkAlignments doesn't normally redraw on allocate.

BUG=13659
Review URL: http://codereview.chromium.org/118403
------------------------------------------------------------------------
r18130 | mad@google.com | 2009-06-11 03:08:27 +0200 (Thu, 11 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Relanding reverted patch 18090.

------------------------------------------------------------------------
r18128 | pkasting@chromium.org | 2009-06-11 02:48:00 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc

Add a couple CHECK()s in hopes of helping to track down a crash.

BUG=13500
TEST=none
Review URL: http://codereview.chromium.org/118453
------------------------------------------------------------------------
r18120 | mattm@chromium.org | 2009-06-11 02:21:57 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Add helper for creating table of labeled controls.

BUG=none

Review URL: http://codereview.chromium.org/118489
------------------------------------------------------------------------
r18119 | mhm@chromium.org | 2009-06-11 02:08:17 +0200 (Thu, 11 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

Save as dialog should show html files

Currently "htm" files are hardcoded, that is the reason why its only seen. Adding "html" to the vector extension would fix this issue.

BUG=13429 (http://crbug.com/13429)

TEST=Can now see html in the save file dialog.

Review URL: http://codereview.chromium.org/119409
------------------------------------------------------------------------
r18118 | mhm@chromium.org | 2009-06-11 02:07:36 +0200 (Thu, 11 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/importer_view.cc

Fix HWND for Importer Dialog

Instead of grabbing the HWND from the browser, we can grab it from the current view since each view has a Widget who is associated with a HWND (NativeView). By doing that, we can assure the parent hwnd is that. Before, it was retrieving the hwnd from Browser* which caused this bug.

BUG=13154 (http://crbug.com/13154)

TEST=Launched Options>Importer>Import and it brought up the Options dialog.

Review URL: http://codereview.chromium.org/119408
------------------------------------------------------------------------
r18117 | mhm@chromium.org | 2009-06-11 02:07:16 +0200 (Thu, 11 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Hide URL from extension pages.

We can't do the same as we do for NTP because NTP is a DOMUI whereas chrome-extensions is just a normal webpage. Adding functionality within TabContents::ShouldDisplayURL() would be sufficient to tell the ombibox not to display the URL.

BUG=12371 (http://crbug.com/12371)
TEST=Tested chrome-extension://id/hello_world.html

Review URL: http://codereview.chromium.org/119406
------------------------------------------------------------------------
r18116 | mpcomplete@google.com | 2009-06-11 02:05:34 +0200 (Thu, 11 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   A /trunk/src/chrome/browser/extensions/extension_browsertest.cc (from /trunk/src/chrome/browser/extensions/extension_view_unittest.cc:18047)
   M /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   D /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   M /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome.gyp

Disable extensions in incognito mode.

Add a browsertest to make sure we don't crash with an incognito window open.
Had to finagle utility_process_host to make it work in a browsertest.

BUG=12326
TEST=none
Review URL: http://codereview.chromium.org/118476
------------------------------------------------------------------------
r18114 | jhawkins@chromium.org | 2009-06-11 01:55:51 +0200 (Thu, 11 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Replace a notimplemented with a link to the bug report.
TBR=tony
Review URL: http://codereview.chromium.org/122001
------------------------------------------------------------------------
r18113 | erg@google.com | 2009-06-11 01:54:20 +0200 (Thu, 11 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc
   A /trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h
   M /trunk/src/chrome/chrome.gyp

GTK: Implement BlockedPopupContainerView for linux.

This doesn't have:
- rounded corners
- gradient background
- animating in or out.
- graphical polish

but it is fucntionally complete.

http://crbug.com/12843

Review URL: http://codereview.chromium.org/118480
------------------------------------------------------------------------
r18112 | agl@chromium.org | 2009-06-11 01:28:46 +0200 (Thu, 11 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/file_util_posix.cc
   D /trunk/src/base/global_descriptors_posix.cc
   D /trunk/src/base/global_descriptors_posix.h
   M /trunk/src/base/logging.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   A /trunk/src/base/reserved_file_descriptors.h
   D /trunk/src/base/unix_domain_socket_posix.cc
   D /trunk/src/base/unix_domain_socket_posix.h
   A /trunk/src/base/zygote_manager.cc
   A /trunk/src/base/zygote_manager.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   D /trunk/src/chrome/browser/zygote_host_linux.cc
   D /trunk/src/chrome/browser/zygote_host_linux.h
   D /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/chrome_descriptors.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/ipc_channel.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/process_watcher_posix.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/chrome_process_util.cc

Revert 18109, 18111: Windows UI tests failed.

------------------------------------------------------------------------
r18109 | agl@chromium.org | 2009-06-11 01:04:55 +0200 (Thu, 11 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/file_util_posix.cc
   A /trunk/src/base/global_descriptors_posix.cc
   A /trunk/src/base/global_descriptors_posix.h
   M /trunk/src/base/logging.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   D /trunk/src/base/reserved_file_descriptors.h
   A /trunk/src/base/unix_domain_socket_posix.cc
   A /trunk/src/base/unix_domain_socket_posix.h
   D /trunk/src/base/zygote_manager.cc
   D /trunk/src/base/zygote_manager.h
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   A /trunk/src/chrome/browser/zygote_host_linux.cc
   A /trunk/src/chrome/browser/zygote_host_linux.h
   A /trunk/src/chrome/browser/zygote_main_linux.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/chrome_descriptors.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/ipc_channel.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/process_watcher_posix.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/chrome_process_util.cc

Linux: refactor zygote support

http://code.google.com/p/chromium/wiki/LinuxZygote

* Move Chrome specific bits out of base
* Move away from the idea of reserved file descriptors (which don't
  really work with zygotes)
* Load resources before forking renderers (means that we don't need
  communication between the zygote process and the renderers)
* Make sure that gdb works against the browser again
* Make sure that we have different ASLR between the renderers and the
  browser.

http://codereview.chromium.org/119335

------------------------------------------------------------------------
r18107 | tc@google.com | 2009-06-11 00:53:30 +0200 (Thu, 11 Jun 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

First cut at tall titlebar and custom window frame.

This implements the tall titlebar with the XP frame buttons, which should
work if your window manager supports them.

The titlebar background is drawn by the containing hbox.  It would be nice
if the tab strip could be made transparent so it wouldn't need to paint
a background itself, but I didn't know how to do that.

I still need to implement the frame resizing, frame coloring and move the
context menu from the tab strip to the titlebar.

BUG=13430

Review URL: http://codereview.chromium.org/119371

------------------------------------------------------------------------
r18106 | brettw@google.com | 2009-06-11 00:47:48 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Fix memory leak in unit_tests

BUG=13733
Original review: http://codereview.chromium.org/119444
Patch by Meelap Shah
------------------------------------------------------------------------
r18103 | stuartmorgan@chromium.org | 2009-06-11 00:41:28 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc

Add an exact-match Keychain search, with unit tests; groundwork for a more complete Keychain implementation.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119377
------------------------------------------------------------------------
r18102 | arv@google.com | 2009-06-11 00:36:40 +0200 (Thu, 11 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc

Show the remaining time in the downloads page.

BUG=13386

TEST=Download a large file and make sure that you see the speed in the donwloads page.

Review URL: http://codereview.chromium.org/119428
------------------------------------------------------------------------
r18101 | aa@chromium.org | 2009-06-11 00:35:50 +0200 (Thu, 11 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_creator.cc

Fix UMR in ExtensionCreator.

Review URL: http://codereview.chromium.org/119443
------------------------------------------------------------------------
r18100 | tc@google.com | 2009-06-11 00:34:51 +0200 (Thu, 11 Jun 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   A /trunk/src/chrome/browser/renderer_preferences.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/webkit/glue/dragclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Do not allow URL drops on app windows to cause a navigation away

from the currently loaded site.  We are careful in this patch to
continue to allow dropping URLs in text fields within the app
window, and behavior for normal browser windows remains as
before.

There is a slight glitch when dragging a to an app window on the
border of the window.  Even though it is very brief, it is still
disturbing.

BUG=7171
TEST=Open Chrome (1), load google.com.  Open Chrome (2), load
yahoo.com.  Drag a link from 1 to 2 and a link from 2 to 1 (both
allowed).  Create an app shortcut from 1, drag a link from 1 to
2 (allowed) and a link from 2 to 1 (denied).  Verify that link
scan be dragged to the omnibox and to text fields.

Patch by Chase Phillips <chase@chromium.org> via
http://codereview.chromium.org/119298

Review URL: http://codereview.chromium.org/121003

------------------------------------------------------------------------
r18098 | jhawkins@chromium.org | 2009-06-11 00:31:45 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Use the convenience function gdk_screen_get_window_stack to enumerate top-level gdk windows instead of querying Xlib directly, which doesn't work across many window managers.

BUG=none
TEST=Exhaustive tab dragging in multiple window managers (Compiz, Metacity, KWM).
Review URL: http://codereview.chromium.org/119345
------------------------------------------------------------------------
r18096 | cpu@google.com | 2009-06-11 00:21:24 +0200 (Thu, 11 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc

Fix tree bustage

TEST=none
BUG=none

TBR=nsylvain

Review URL: http://codereview.chromium.org/120003
------------------------------------------------------------------------
r18095 | mpcomplete@google.com | 2009-06-11 00:16:26 +0200 (Thu, 11 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc

Fix uninitialized ExtensionView::pending_preferred_width_.

BUG=13103
Review URL: http://codereview.chromium.org/119389
------------------------------------------------------------------------
r18094 | kuchhal@chromium.org | 2009-06-11 00:15:25 +0200 (Thu, 11 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc

Linux: Fix Firefox profile path for import.

BUG=13270

Review URL: http://codereview.chromium.org/118526
------------------------------------------------------------------------
r18093 | cpu@google.com | 2009-06-11 00:14:06 +0200 (Thu, 11 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

UI part of the try chrome toast
- experimental. 'en' only
- modal dialog is farily custom

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/118510
------------------------------------------------------------------------
r18092 | jrg@chromium.org | 2009-06-10 23:57:00 +0200 (Wed, 10 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Revert 18090

------------------------------------------------------------------------
r18090 | mad@google.com | 2009-06-10 23:41:54 +0200 (Wed, 10 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_manager.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc

To help resolve the performance issue introduced when enabling the resize corner, we now keep all non-intersecting rects separately and send an array of invalidation bitmaps via IPC as opposed to a single unionized rect :-)
Review URL: http://codereview.chromium.org/108040
------------------------------------------------------------------------
r18089 | sky@chromium.org | 2009-06-10 23:31:32 +0200 (Wed, 10 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/tabs/grid.cc
   M /trunk/src/chrome/browser/views/tabs/grid.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_cell.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   A /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.cc
   A /trunk/src/chrome/browser/views/tabs/tab_overview_drag_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_overview_grid.cc
   M /trunk/src/chrome/browser/views/tabs/tab_overview_grid.h
   M /trunk/src/chrome/chrome.gyp

Refactors tab overview and gets the rest of the chunks working. I've
refactored it so that there is a clear object responsible for dragging
and the controller now controls it all.

There is some common code between TabOverviewDragController and
DraggedTabController. I will try and share some code between these two
later.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/118513
------------------------------------------------------------------------
r18088 | aa@chromium.org | 2009-06-10 23:26:32 +0200 (Wed, 10 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.cc
   M /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Remove the prepended manifest from the crx format. Now we just have the header, the public key, the signature, and the zip.

Review URL: http://codereview.chromium.org/118490
------------------------------------------------------------------------
r18087 | tc@google.com | 2009-06-10 23:19:58 +0200 (Wed, 10 Jun 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h

Fix a crash in linux if the renderer process dies too fast.  On mac, we
just don't get the sad tab page.

If the renderer dies before it sends a ViewHostMsg_RenderViewReady message,
we never get the TAB_CONTENTS_CONNECTED, which in turn means that
TAB_CONTENTS_DISCONNECTED doesn't fire.  If TAB_CONTENTS_DISCONNECTED
doesn't fire, we never initialize sad_tab_ in tab_contents_view_gtk.cc and
crash the browser process.

I found this crash on the crash server:
http://crash/reportdetail?
reportid=fb3a7bc60c67eb1e&product=Chrome_Linux&version=3.0.183.1&date=&signa
ture=TabContentsViewGtk::Invalidate()-534CC7

BUG=13715

Review URL: http://codereview.chromium.org/119395

------------------------------------------------------------------------
r18086 | ojan@chromium.org | 2009-06-10 23:17:24 +0200 (Wed, 10 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Null check render_view_host when processing unload events.
I haven't been able to reproduce the crash, but I'm pretty sure
this is the problem.

I think this involves closing the browser while we're in the
middle of a cross-process or interstitial page tab transition.

TEST=none
BUG=http://crbug.com/11493
------------------------------------------------------------------------
r18085 | tc@google.com | 2009-06-10 23:14:15 +0200 (Wed, 10 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

Bind ^Q to quit, as is standard with Linux GUI apps.

BUG=none
TEST=Press ctrl+q and chrome should quit

Patch by Jacob Mandelson <jacob@mandelson.org> via
http://codereview.chromium.org/119393

Review URL: http://codereview.chromium.org/118522

------------------------------------------------------------------------
r18067 | maruel@chromium.org | 2009-06-10 18:53:42 +0200 (Wed, 10 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Dummy change to fix "svn: Inconsistent line ending style"

TEST=none
BUG=none

------------------------------------------------------------------------
r18066 | rohitrao@chromium.org | 2009-06-10 18:51:12 +0200 (Wed, 10 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/grow_box_view.h
   M /trunk/src/chrome/browser/cocoa/grow_box_view.mm

Converts a private variable to use scoped_nsobject.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118506
------------------------------------------------------------------------
r18065 | maruel@chromium.org | 2009-06-10 18:43:09 +0200 (Wed, 10 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Fix svn: Inconsistent line ending style

TEST=none
BUG=none

------------------------------------------------------------------------
r18064 | brettw@chromium.org | 2009-06-10 18:36:26 +0200 (Wed, 10 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Try2 at disabling the thumbnail store unit tests. The previous try didn't
work because the friend declarations depended on the exact name of the tests,
which I changed when I marked them disabled.
Review URL: http://codereview.chromium.org/119426
------------------------------------------------------------------------
r18063 | brettw@chromium.org | 2009-06-10 18:27:56 +0200 (Wed, 10 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Temporarily disable the thumbnail store unittests due to leaks.

BUG=13733
Review URL: http://codereview.chromium.org/118507
------------------------------------------------------------------------
r18062 | maruel@chromium.org | 2009-06-10 18:13:59 +0200 (Wed, 10 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_win.cc

Try to fix this file since it's constantly giving
"svn: Inconsistent line ending style"...

TEST=none
BUG=none

------------------------------------------------------------------------
r18061 | stuartmorgan@chromium.org | 2009-06-10 18:12:48 +0200 (Wed, 10 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/common/platform_util_mac.mm

Implement OpenItem on the Mac, and have the download manager call it when clicking a file link.

BUG=13552
TEST=Clicking a file link in the download manager should open the file.
Review URL: http://codereview.chromium.org/119398
------------------------------------------------------------------------
r18059 | pfeldman@chromium.org | 2009-06-10 17:37:58 +0200 (Wed, 10 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   M /trunk/src/webkit/glue/devtools/js/inspector_controller.js
   M /trunk/src/webkit/glue/devtools/js/tests.js

DevTools: Add test for resource panel enabling.

Review URL: http://codereview.chromium.org/118502
------------------------------------------------------------------------
r18058 | rohitrao@chromium.org | 2009-06-10 17:35:35 +0200 (Wed, 10 Jun 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/grow_box_view.m
   A /trunk/src/chrome/browser/cocoa/grow_box_view.mm (from /trunk/src/chrome/browser/cocoa/grow_box_view.m:18052)
   M /trunk/src/chrome/chrome.gyp

Rename grow_box_view.m to grow_box_view.mm.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118465
------------------------------------------------------------------------
r18056 | erikkay@google.com | 2009-06-10 17:10:55 +0200 (Wed, 10 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/json_schema.js
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html

Clean up bookmark API to match style of other extension APIs

BUG=11823
TEST=--load-extension test/data/extensions/samples/bookmarks
TEST=unit_tests.exe --gtest_filter=ExtensionAPIClientTest.*

Review URL: http://codereview.chromium.org/118209
------------------------------------------------------------------------
r18052 | idanan@chromium.org | 2009-06-10 16:05:45 +0200 (Wed, 10 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/widget/widget_win.h

Issue 8838: Close box not highlighted

We optimize mouse-mouve event handling by ignoring two mouse-move events in a row
which works in most cases except that when we animate tab-closing on windows we
send a duplicate mouse-move event on purpose to highlight the button. Unfortunately
our optimization kicks in.

Fixed by reseting the flag to optimize this before sending the extra mouse-move.

BUG=8838

Review URL: http://codereview.chromium.org/118454
------------------------------------------------------------------------
r18049 | pfeldman@chromium.org | 2009-06-10 14:00:28 +0200 (Wed, 10 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc

DevTools: do not crash on rapid refresh while on a Dev Tools Client window.

BUG=13494

Review URL: http://codereview.chromium.org/118494
------------------------------------------------------------------------
r18047 | pfeldman@chromium.org | 2009-06-10 11:44:36 +0200 (Wed, 10 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/webkit/glue/devtools/js/devtools.html
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   A /trunk/src/webkit/glue/devtools/js/tests.js
   M /trunk/src/webkit/webkit.gyp

DevTools: migrate sanity tests to javascript.

Review URL: http://codereview.chromium.org/119368
------------------------------------------------------------------------
r18044 | sgk@google.com | 2009-06-10 09:47:49 +0200 (Wed, 10 Jun 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/installer/util/prebuild/util_prebuild.vcproj
   D /trunk/src/chrome/installer/util/util.vcproj
   D /trunk/src/chrome/test/browser/browser_tests_dll.vcproj
   D /trunk/src/chrome/test/browser/browser_tests_launcher.vcproj
   D /trunk/src/chrome/test/perf/perftests.vcproj
   D /trunk/src/chrome/test/ui/ui_tests.vcproj

Remove checked-in .vcproj files that have been converted to gyp.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119411
------------------------------------------------------------------------
r18038 | phajdan.jr@chromium.org | 2009-06-10 08:57:20 +0200 (Wed, 10 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_linux.cc
   M /trunk/src/chrome/browser/task_manager_win.cc

Destroy TaskManager's view when its window is closed.

TEST=Open the task manager. Close it. Open again and close. Browser should not crash.

http://crbug.com/13361

Review URL: http://codereview.chromium.org/119299
------------------------------------------------------------------------
r18036 | ukai@chromium.org | 2009-06-10 08:07:07 +0200 (Wed, 10 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/net/base/load_flags.h

Add LOAD_VERIFY_EV_CERT in net load loag.

We'd like to run EV cert verification in cert verifier's context, but
EV cert verification is expensive and it is only relevant to main frame.
So, pass the LOAD_VERIFY_EV_CERT flag when the resource is main frame
to request EV cert verification.

BUG=10911
TEST=none


Review URL: http://codereview.chromium.org/118373
------------------------------------------------------------------------
r18023 | jshin@chromium.org | 2009-06-10 05:28:46 +0200 (Wed, 10 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Add a comment per review comment I missed in the previous check-in.

BUG=13215
TBR=jeremy
TEST=none

------------------------------------------------------------------------
r18022 | jshin@chromium.org | 2009-06-10 05:24:38 +0200 (Wed, 10 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Fix the in-progress download status for the RTL UI.

1. Make the download progress pie chart fill up CW even in the RTL UI. 
2. Make the filename be at the right end instead of being in the middle of the download status in the RTL UI.

BUG=13215,13216 (http://crbug.com/13215, http://crbug.com/13216)
TEST=1. Launch Chrome with --lang=he or --lang=ar. 
     2. Download a large file (like chrome mini-installer or Firefox) and go to the download tab (pressing Ctrl-J would work)
     3. The progress pie-chart should be filled up clockwise.
     4. The filename should be to the right of the download status ('5 kB of 7.2 MB - 4 mins left' in Hebrew or Arabic) instead of being put in the middle of the status string.

Review URL: http://codereview.chromium.org/119318
------------------------------------------------------------------------
r18012 | mattm@chromium.org | 2009-06-10 03:01:59 +0200 (Wed, 10 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h

Implement default search engine combobox.

BUG=11507
Review URL: http://codereview.chromium.org/118421
------------------------------------------------------------------------
r18010 | willchan@chromium.org | 2009-06-10 02:54:37 +0200 (Wed, 10 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

<!doctype html public '-//w3c//dtd html 4.0 transitional//en'><html><head><META HTTP-EQUIV='Refresh' CONTENT='0;URL=http://www.orkut.com'></head><body>You are being redirected <a href='http://www.orkut.com'>http://www.orkut.com</a>.</body></html>

Review URL: http://codereview.chromium.org/118418
------------------------------------------------------------------------
r18006 | tc@google.com | 2009-06-10 02:29:28 +0200 (Wed, 10 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

Fix a linux bug in the find bar where we keep re-selecting text
on the page after closing the find bar.  This happens because
gtk_entry_set_text triggers a "changed" event in gtk.  This
doesn't happen in on the windows side.

BUG=13344

Review URL: http://codereview.chromium.org/118457

------------------------------------------------------------------------
r18002 | erikkay@google.com | 2009-06-10 02:11:24 +0200 (Wed, 10 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   A /trunk/src/chrome/browser/extensions/extension_shelf_model.cc
   A /trunk/src/chrome/browser/extensions/extension_shelf_model.h
   A /trunk/src/chrome/browser/extensions/extension_shelf_model_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/data/purify/unit_tests.exe.gtest.txt
   M /trunk/src/chrome/test/unit/unittests.vcproj

part 2 of dragging change: reordering, but not persisting
* split up extension_shelf into a model and a view (easier to port)
* ExtensionHost now owns ExtensionView rather than vice versa
* dragging reorders extensions on the shelf
* moved ExtensionView* into browser_tests (currently not working)

BUG=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModel* (browser_tests.exe is currently broken)

Review URL: http://codereview.chromium.org/119290
------------------------------------------------------------------------
r18000 | ben@chromium.org | 2009-06-10 02:03:44 +0200 (Wed, 10 Jun 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Fix compile bustage by using macro
------------------------------------------------------------------------
r17997 | ben@chromium.org | 2009-06-10 01:58:17 +0200 (Wed, 10 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc

Update result formatting for the search provider for the Omnibox2 popup.
I've kept the old style in there now too since we have --disable-omnibox2 for a short while so QA can compare if necessary.

http://crbug.com/13647
TEST=suggestion completions should be bolded in the omnibox2 dropdown. the first "Search Google For" item should now read "<query> - Search Google" (or whatever your default search engine is).

Review URL: http://codereview.chromium.org/119341
------------------------------------------------------------------------
r17996 | ben@chromium.org | 2009-06-10 01:58:02 +0200 (Wed, 10 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/controls/menu/menu_2.cc
   M /trunk/src/views/controls/menu/menu_2.h
   M /trunk/src/views/controls/menu/menu_wrapper.h
   M /trunk/src/views/controls/menu/native_menu_gtk.cc
   M /trunk/src/views/controls/menu/native_menu_gtk.h
   M /trunk/src/views/controls/menu/native_menu_win.cc
   M /trunk/src/views/controls/menu/native_menu_win.h
   M /trunk/src/views/controls/menu/simple_menu_model.cc
   M /trunk/src/views/controls/menu/simple_menu_model.h

Remove Menu2Delegate interface and fold methods onto Menu2Model instead.
Enhance SimpleMenuModel::Delegate interface to support additional options required by the above.
Make MenuHostWindow process WM_MENUCOMMAND and WM_MENUSELECT - the first so we can determine which index was selected, the second so we can track highlight changes within a menu.
Convert Tab's context menu back to the windows native menu. This will make my life easier when I upgrade chrome_menu.cc to the new API if only the bookmarks menus/context menus are using it.

BUG=none
TEST=page, app menus again, context menu for tabs. open a bunch of tabs, open this page: http://bengoodger.dreamhosters.com/software/chrome/cxmenutest.html, close that tab then right click on the menu quickly. should not crash!

Review URL: http://codereview.chromium.org/118426
------------------------------------------------------------------------
r17990 | arv@google.com | 2009-06-10 01:07:26 +0200 (Wed, 10 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/jstemplate_builder.cc
   A /trunk/src/chrome/third_party/jstemplate/COPYING
   M /trunk/src/chrome/third_party/jstemplate/README.txt
   D /trunk/src/chrome/third_party/jstemplate/base.js
   M /trunk/src/chrome/third_party/jstemplate/compile.sh
   D /trunk/src/chrome/third_party/jstemplate/dom.js
   A /trunk/src/chrome/third_party/jstemplate/exports.js
   A /trunk/src/chrome/third_party/jstemplate/jsevalcontext.js
   M /trunk/src/chrome/third_party/jstemplate/jstemplate.js
   M /trunk/src/chrome/third_party/jstemplate/jstemplate_compiled.js
   A /trunk/src/chrome/third_party/jstemplate/jstemplate_example.html
   A /trunk/src/chrome/third_party/jstemplate/jstemplate_example.js
   A /trunk/src/chrome/third_party/jstemplate/jstemplate_jsunit.html
   A /trunk/src/chrome/third_party/jstemplate/jstemplate_test.js
   D /trunk/src/chrome/third_party/jstemplate/test
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/01-quick.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/02-gettpl.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/03-environ.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/04-jscontent.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/05-jsselect.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/06-jsdisplay.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/07-jsdisplay-empty.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/08-transclude.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/09-jsvalues.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/10-jsvalues.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/11-jseval.html
   A /trunk/src/chrome/third_party/jstemplate/tutorial_examples/12-parent.html
   M /trunk/src/chrome/third_party/jstemplate/util.js

Update JSTemplate to the latest version.

This version is from Google and has already stripped all non related code except for the MAPS_DEBUG flag. I manually removed all the debugging code related to MAPS_DEBUG.

TEST=New tab page, history, downloads and all other pages using HTML content should still work.

BUG=None


Review URL: http://codereview.chromium.org/119384
------------------------------------------------------------------------
r17980 | finnur@chromium.org | 2009-06-09 23:41:00 +0200 (Tue, 09 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc

Fix 13570: Find box stops responding to browser window resize.

If you enter a search term and delete it, the Find box UI flag gets set as inactive and the box stops moving when the browser resizes. This fixes that.

BUG=13570
TEST=Open Find, press 'e', press Backspace, resize the window. The Find box should move.


Review URL: http://codereview.chromium.org/119383
------------------------------------------------------------------------
r17978 | willchan@chromium.org | 2009-06-09 23:30:13 +0200 (Tue, 09 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Linux: Remove old ifdefs around a DCHECK.

Review URL: http://codereview.chromium.org/119376
------------------------------------------------------------------------
r17973 | brettw@chromium.org | 2009-06-09 22:23:40 +0200 (Tue, 09 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Fix Mac compile bustage
Review URL: http://codereview.chromium.org/119379
------------------------------------------------------------------------
r17972 | brettw@chromium.org | 2009-06-09 22:13:39 +0200 (Tue, 09 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store.cc

Fix Linux compile bustage
Review URL: http://codereview.chromium.org/119378
------------------------------------------------------------------------
r17971 | brettw@chromium.org | 2009-06-09 22:04:28 +0200 (Tue, 09 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   M /trunk/src/chrome/browser/thumbnail_store_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Modified ThumbnailStore to cache/store JPEGs instead
of SkBitmaps.

Add command line flag "--thumbnail-store" to enable
using the ThumbnailStore facility instead of the current
ThumbnailDatabase.

Original review: http://codereview.chromium.org/118409
Patch by Meelap Shah
------------------------------------------------------------------------
r17965 | rohitrao@chromium.org | 2009-06-09 21:22:09 +0200 (Tue, 09 Jun 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/grow_box_view.h
   M /trunk/src/chrome/browser/cocoa/grow_box_view.m

Modifies the growbox behavior to be more Mac-like.

Nib file changes:
- Set the min browser window size to 400x250.

BUG=http://crbug.com/11844
BUG=http://crbug.com/13015
BUG=http://crbug.com/13017

TEST=Verify that windows have a minimum size.  Verify that (with a
single monitor) windows cannot be resized into the dock area, unless
their lower right corner started in the dock area.  Verify that
windows can be resized across multiple monitors.

Review URL: http://codereview.chromium.org/118439
------------------------------------------------------------------------
r17963 | sverrir@google.com | 2009-06-09 21:07:05 +0200 (Tue, 09 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/win_printing_context.cc

Fix a minor bug in the print dialog on windows.  The minimum page number was not set so you could ask for a printout of page 0-5 in a 5 page document.
This caused an empty page to be printed before the others.

BUG=none
TEST=Try to enter illegal page number in the page number dialog.

Review URL: http://codereview.chromium.org/118446
------------------------------------------------------------------------
r17960 | mhm@chromium.org | 2009-06-09 20:24:03 +0200 (Tue, 09 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc

Should provide checks while loading bookmarks

Instead of providing a separate check to validate bookmarks while loading, we could assume invalid bookmarks are invalid, hence we don't break the loading sequence. We keep looping since another bookmark might be valid.

If the JSON syntax is broken, it will exit gracefully because the parser can't parse the file. This patch is only good for people who are editing their bookmarks directly and missing a item in the bookmark node.

BUG=10709 (http://crbug.com/10709)

TEST=Deleted any line from the Bookmarks file within the bookmark children node. Loaded up Chromium and it loaded the error free bookmarks.

Review URL: http://codereview.chromium.org/118351
------------------------------------------------------------------------
r17956 | pinkerton@chromium.org | 2009-06-09 19:39:34 +0200 (Tue, 09 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/scoped_nsdisable_screen_updates.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Add a stack-based class for property disabling and re-enabling screen updating without epic fail. Fixes issues where we weren't re-enabling updates in many cases which caused both jank and resize issues.
BUG=13476
TEST=closing windows shouldn't have jank regardless of the # of tabs. Resizing a window shouldn't explode visually in the chrome.
Review URL: http://codereview.chromium.org/119363
------------------------------------------------------------------------
r17955 | kuchhal@chromium.org | 2009-06-09 19:38:40 +0200 (Tue, 09 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h

Linux: Import passwords from Firefox.

BUG=11191
TEST=Try importing password from Firefox on Linux and it should work (though
they are not accessible in UI yet).

Review URL: http://codereview.chromium.org/118443
------------------------------------------------------------------------
r17947 | pinkerton@chromium.org | 2009-06-09 18:22:48 +0200 (Tue, 09 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/search_engine_list_model.h
   A /trunk/src/chrome/browser/cocoa/search_engine_list_model.mm
   A /trunk/src/chrome/browser/cocoa/search_engine_list_model_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implement default search popup.
BUG=13151
TEST=default search popup persistance.
Review URL: http://codereview.chromium.org/119310
------------------------------------------------------------------------
r17946 | kuchhal@chromium.org | 2009-06-09 18:07:02 +0200 (Tue, 09 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h

Revert "Linux: Import passwords from Firefox."

This reverts commit a45f7c83ced4af4ded3fcbd3608a1fe50a2c9f08.

Review URL: http://codereview.chromium.org/118435
------------------------------------------------------------------------
r17943 | kuchhal@chromium.org | 2009-06-09 17:59:18 +0200 (Tue, 09 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h

Linux: Import passwords from Firefox.

BUG=11191
TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet).

Review URL: http://codereview.chromium.org/119267
------------------------------------------------------------------------
r17941 | pfeldman@chromium.org | 2009-06-09 17:31:30 +0200 (Tue, 09 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h

DevTools: restore sanity test suite.

BUG=11533
Review URL: http://codereview.chromium.org/119355
------------------------------------------------------------------------
r17936 | mnaganov@chromium.org | 2009-06-09 10:48:31 +0200 (Tue, 09 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Make Ctrl-Shift-J to work across platforms.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/118427
------------------------------------------------------------------------
r17935 | aa@chromium.org | 2009-06-09 09:08:10 +0200 (Tue, 09 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css

apply patch

Review URL: http://codereview.chromium.org/119350
------------------------------------------------------------------------
r17932 | mhm@chromium.org | 2009-06-09 07:55:19 +0200 (Tue, 09 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Implement different radio groups for Options > Personal Stuff

Passwords and Form autofill share the same group, they need to be treated separately. It did not work correctly, when "password" radio option was chosen,two of 
"form autofill" radio option both change to blank(not selected). This patch will properly create different radio groups for passwords and autofill.

BUG=13222 (http://crbug.com/13222)

TEST=Radio buttons now function propertly

TBR=ben
Review URL: http://codereview.chromium.org/119347
------------------------------------------------------------------------
r17929 | ben@chromium.org | 2009-06-09 05:53:19 +0200 (Tue, 09 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc

Fix toolkit_views bustage by updating callsite to use the new function name.

BUG=none
TEST=none
TBR=jcampan
Review URL: http://codereview.chromium.org/118419
------------------------------------------------------------------------
r17927 | rafaelw@chromium.org | 2009-06-09 04:56:41 +0200 (Tue, 09 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/extensions/extension_creator.cc
   A /trunk/src/chrome/browser/extensions/extension_creator.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/test/data/extensions/good.crx
   M /trunk/src/chrome/test/data/extensions/good2.crx
   A /trunk/src/chrome/test/data/extensions/openssl_privkey_asn1.pem
   M /trunk/src/chrome/test/data/extensions/page_action.crx
   M /trunk/src/chrome/test/data/extensions/theme.crx
   M /trunk/src/chrome/test/data/extensions/theme2.crx

chrome.exe --package-extension generates .crx from extension directory

R=aa
BUG=12114

Review URL: http://codereview.chromium.org/118328
------------------------------------------------------------------------
r17926 | mhm@chromium.org | 2009-06-09 04:51:24 +0200 (Tue, 09 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Form Autofil Options should be a radio group

The Form Autofil is currently just a checkbox. To fit the chomium design, we prefer radios for single questions because it a bit clearer which choice you choose. As well, we merged import data and clear browsing data into browsing data since the page was getting a bit long.

BUG=13222 (http://crbug.com/13222)

TEST=Tested the options pane, the form autofil worked as expected.

Review URL: http://codereview.chromium.org/119146
------------------------------------------------------------------------
r17925 | mhm@chromium.org | 2009-06-09 04:50:38 +0200 (Tue, 09 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_win.cc

Stats for nerds should bring up applicaiton browser window to foreground

The reason why it didn't bring up the stats in foreground is because it is an application window. Application (same goes for popup) windows cannot have tabs, it is just a single page. When the link is clicked, we need to get the last active browser so we could open that about:memory page. When you open a page in an application window, it will create a new window or find a window (normal) that is present, then open the url in that tab. So now we don't have the browser pointed to that tab, its still pointed to the application window.

By finding the last active tab again, we can ensure we have the correct tab.

BUG=11822 (http://crbug.com/11822)
TEST=tested if the stats appeared in foreground and it did.
Review URL: http://codereview.chromium.org/119293
------------------------------------------------------------------------
r17922 | ben@chromium.org | 2009-06-09 04:13:18 +0200 (Tue, 09 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc

Fix omnibox popup positioning by not calling "SetChildBounds" which attempts to do a bunch of things to keep windows visible on screen... this isn't really what we want for this window, so we just call SetBounds instead.

http://crbug.com/11721
TEST=drag window so it's half offscreen, type in the omnibox. dropdown should appear properly anchored underneath omnibox even though it's half offscreen.
Review URL: http://codereview.chromium.org/119338
------------------------------------------------------------------------
r17921 | ben@chromium.org | 2009-06-09 04:13:07 +0200 (Tue, 09 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Fix weird stretchy text rendering in O2 popup. Apparently the tile flags were angering the skia gods.

http://crbug.com/13277
TEST=size window to various sizes, type stuff in omnibox, text shouldn't be stretched or scrunched.
Review URL: http://codereview.chromium.org/118414
------------------------------------------------------------------------
r17920 | jam@chromium.org | 2009-06-09 03:43:49 +0200 (Tue, 09 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

Don't call NPP_SetWindow before we have the plugin geometry.

Note: the full fix to the bug also needs Ananta's change at http://codereview.chromium.org/119200

Bug=12993
Review URL: http://codereview.chromium.org/118359
------------------------------------------------------------------------
r17915 | jhawkins@chromium.org | 2009-06-09 02:13:30 +0200 (Tue, 09 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dnd_registry.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Implement URL Drag & Drop for the linux tabstrip.

BUG=none
TEST=Drag a link from Firefox into the Chromium tab strip.  A new tab should open either before, after, or in the same tab depending on where the drop occurred.
Review URL: http://codereview.chromium.org/118411
------------------------------------------------------------------------
r17910 | aa@chromium.org | 2009-06-09 01:32:35 +0200 (Tue, 09 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

blech

Review URL: http://codereview.chromium.org/118412
------------------------------------------------------------------------
r17906 | sky@chromium.org | 2009-06-09 01:23:05 +0200 (Tue, 09 Jun 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/views/tabs/grid.cc
   A /trunk/src/chrome/browser/views/tabs/grid.h
   A /trunk/src/chrome/browser/views/tabs/tab_overview_cell.cc
   A /trunk/src/chrome/browser/views/tabs/tab_overview_cell.h
   A /trunk/src/chrome/browser/views/tabs/tab_overview_container.cc
   A /trunk/src/chrome/browser/views/tabs/tab_overview_container.h
   A /trunk/src/chrome/browser/views/tabs/tab_overview_controller.cc
   A /trunk/src/chrome/browser/views/tabs/tab_overview_controller.h
   A /trunk/src/chrome/browser/views/tabs/tab_overview_grid.cc
   A /trunk/src/chrome/browser/views/tabs/tab_overview_grid.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

 First part of tab overview. It isn't wired up, nor is it complete, but
it's a good enough stage that I want to check it in.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/119329
------------------------------------------------------------------------
r17905 | erg@google.com | 2009-06-09 01:13:01 +0200 (Tue, 09 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/blocked_popup_container.cc
   M /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container_view.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container_view.h
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_win.cc (from /trunk/src/chrome/browser/views/blocked_popup_container_view.cc:17904)
   A /trunk/src/chrome/browser/views/blocked_popup_container_view_win.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/chrome.gyp

Creates a BlockedPopupContainerView interface, and changes the current BlockedPopupContainerView class into a windows specific instance owned by the new BlockedPopupContainer.

http://crbug.com/12843

Review URL: http://codereview.chromium.org/118401
------------------------------------------------------------------------
r17900 | jcampan@chromium.org | 2009-06-08 23:27:28 +0200 (Mon, 08 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc

Rename the TabContents::SetInitialFocus(reverse) method to TabContents::FocusThroughTabTraversal(reverse), as SetInitialiFocus can be easily confused with TabContentView::SetInitialFocus().

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/118392
------------------------------------------------------------------------
r17898 | aa@chromium.org | 2009-06-08 23:01:53 +0200 (Mon, 08 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/test/testing_profile.h

Fix user scripts not getting initialized.

BUG=13290,13128
TEST=Add --enable-user-scripts to command line without --enable-extensions or --load-extension. Start Chrome, user scripts should work. Also run ui tests with --enable-extensions.

Review URL: http://codereview.chromium.org/119256
------------------------------------------------------------------------
r17897 | ben@chromium.org | 2009-06-08 23:01:37 +0200 (Mon, 08 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp

Convert toolbar page and app menus over to use the new system.

TEST=test page and app menus thoroughly.
Review URL: http://codereview.chromium.org/119291
------------------------------------------------------------------------
r17894 | mattm@chromium.org | 2009-06-08 22:56:19 +0200 (Mon, 08 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   M /trunk/src/chrome/common/gtk_util.h

Move GTK spacing constants into chrome/common/gtk_util.h

BUG=11507
Review URL: http://codereview.chromium.org/118399
------------------------------------------------------------------------
r17891 | pkasting@chromium.org | 2009-06-08 22:33:29 +0200 (Mon, 08 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h

Fix regression where hitting enter in the Omnibox would ignore recent editing.

Sadly, the only way I could find to fix this was a latest_result() accessor, because when the user hits enter, we really do need to use the very latest results.  This just highlights how more of this stuff should move to the AutocompleteController.

BUG=13428
TEST=Type "food.c" and wait for the popup to stabilize.  Then _very_ quickly type "om" and hit enter.  You should navigate to food.com instead of searching for "food.c".
Review URL: http://codereview.chromium.org/118398
------------------------------------------------------------------------
r17888 | finnur@chromium.org | 2009-06-08 22:08:12 +0200 (Mon, 08 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Adjusting the page action icon drawing slightly.

When multiple page actions are active, there was no padding between icons. Also, the entry_width was being truncated too much (the more page actions the more apparent it came).

This fixes that.

BUG=12060
TEST=Have multiple page actions (more than 3) active in the Omnibox, make sure there is a little bit of space between each icon. Start typing and make sure you can type all the way to the page action icons.

Review URL: http://codereview.chromium.org/118390
------------------------------------------------------------------------
r17886 | rohitrao@chromium.org | 2009-06-08 21:24:11 +0200 (Mon, 08 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc

Fixes scrolling in the mac backingstore.  We were copying
pixels to the wrong location when the scrolled region did
not start at y=0.
BUG=13521
TEST=Open url in bug report.  Scroll in the two frames with scrollbars,
then switch to a different window.  The webpage should not get scrambled.
Review URL: http://codereview.chromium.org/118372
------------------------------------------------------------------------
r17882 | estade@chromium.org | 2009-06-08 20:30:19 +0200 (Mon, 08 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

linux build fixes

------------------------------------------------------------------------
r17881 | estade@chromium.org | 2009-06-08 20:21:25 +0200 (Mon, 08 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Fix bookmark bar shutdown crash.

If the bookmarks backend finishes loading during shutdown (after the browser's gtk window has been destroyed but before the application is finished shutting down), we may try to call show() on a destroyed widget.

BUG=13575

Review URL: http://codereview.chromium.org/119317
------------------------------------------------------------------------
r17880 | estade@chromium.org | 2009-06-08 20:21:13 +0200 (Mon, 08 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

GTK: More drag support for bookmark manager.

- drag into folders
- improve pre-drop highlighting
- use default drag icon instead of row bitmap for tree view row drag.

Review URL: http://codereview.chromium.org/118357
------------------------------------------------------------------------
r17879 | pkasting@chromium.org | 2009-06-08 20:20:14 +0200 (Mon, 08 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Move a few commands to the appropriate slot in the command order.
Review URL: http://codereview.chromium.org/118311
------------------------------------------------------------------------
r17874 | jhawkins@chromium.org | 2009-06-08 19:45:11 +0200 (Mon, 08 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h

Remove a header that is no longer being used after r17818.

TBR=thestig
Review URL: http://codereview.chromium.org/118389
------------------------------------------------------------------------
r17873 | stuartmorgan@chromium.org | 2009-06-08 19:44:19 +0200 (Mon, 08 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc

Use EXPLICIT_ACCESS when trying to get the PasswordStore to cancel a login query, since that's the mode that was used to start it.

BUG=13348
TEST=Cancelling a login query should not fail in off-the-record mode.
Review URL: http://codereview.chromium.org/119204
------------------------------------------------------------------------
r17872 | jrg@chromium.org | 2009-06-08 19:43:01 +0200 (Mon, 08 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   A /trunk/src/chrome/browser/cocoa/background_gradient_view.h
   A /trunk/src/chrome/browser/cocoa/background_gradient_view.mm
   A /trunk/src/chrome/browser/cocoa/background_gradient_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_button_cell.h
   A /trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/gradient_button_cell.h
   A /trunk/src/chrome/browser/cocoa/gradient_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view.h
   M /trunk/src/chrome/browser/cocoa/toolbar_view.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Bookmark bar, now with buttons.
Much of this CL is refactoring; it's not as large as it looks.
(Do I always claim that?  It's really true this time.)

Review URL: http://codereview.chromium.org/115150
------------------------------------------------------------------------
r17868 | estade@chromium.org | 2009-06-08 19:26:01 +0200 (Mon, 08 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK bookmark manager: organize menu and aesthetic improvements.

Review URL: http://codereview.chromium.org/118388
------------------------------------------------------------------------
r17867 | sverrir@google.com | 2009-06-08 19:05:21 +0200 (Mon, 08 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_settings.cc
   M /trunk/src/chrome/browser/printing/print_settings.h
   M /trunk/src/chrome/browser/printing/printer_query.cc
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/mock_printer.cc
   M /trunk/src/chrome/renderer/mock_printer.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/print_web_view_helper.cc

Add support for printing selection only flag. This only adds the flag to the IPC and implements the Windows dialog interaction but does not enable this just yet.

BUG=http://crbug.com/1682
TEST=none

Review URL: http://codereview.chromium.org/118338
------------------------------------------------------------------------
r17851 | deanm@chromium.org | 2009-06-08 12:01:57 +0200 (Mon, 08 Jun 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Hack around klipper / glipper clipboard races.

I don't completely understand the problem, but I hacked up glipper to dump
what was going on.  It watches the primary clipboard ownership changes, then
waits for the clipboard contents.  There are some races there and then it eats
our selection.

The solution, which isn't great, is to disable the primary selection around
setting up the inline autocomplete selection.  This means that the primary
selection is the full text and not just the inlined portion, but I don't see a
huge case for using the autocompleted portion as the primary selection anyway.

The other clipboard (ctrl-c / ctrl-v) should work the same as before.

BUG=11956
TEST=That inline autocomplete works correctly like it did before.  It should
     now also work correctly with glipper / klipper running.

Review URL: http://codereview.chromium.org/119170

------------------------------------------------------------------------
r17850 | deanm@chromium.org | 2009-06-08 11:03:40 +0200 (Mon, 08 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h

Hook up the Linux bookmark bubble to the bookmark editor.

Folder selection and the Edit... button should now work.

BUG=11738

Review URL: http://codereview.chromium.org/119174

------------------------------------------------------------------------
r17849 | mhm@chromium.org | 2009-06-08 08:28:17 +0200 (Mon, 08 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Clicking a bookmark does not discard omnibox edits

We need to manually reset the omnibox by reverting the text before the bookmark click event occurs

BUG=12627 (http://crbug.com/12627)

TEST=Clicked on bookmark while editing in omnibox to bring up suggestionlist, as well tried unfocused omnibox while clicking on a focused inpage browser link
Review URL: http://codereview.chromium.org/119292
------------------------------------------------------------------------
r17842 | shess@chromium.org | 2009-06-06 22:35:55 +0200 (Sat, 06 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Check to see if we're still real before talking to renderWidgetHostView_.

http://crbug.com/13514
TEST=See bug.

Review URL: http://codereview.chromium.org/119278
------------------------------------------------------------------------
r17840 | dkegel@google.com | 2009-06-06 21:59:36 +0200 (Sat, 06 Jun 2009) | 27 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/file_descriptor_shuffle.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/logging.cc
   M /trunk/src/base/logging.h
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   A /trunk/src/base/reserved_file_descriptors.h
   A /trunk/src/base/zygote_manager.cc
   A /trunk/src/base/zygote_manager.h
   A /trunk/src/base/zygote_manager_unittest.cc
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/process_watcher_posix.cc

Prototype implementation of zygotes.  
Limitations that need addressing still:
- Doesn't forcibly terminate children that should have exited but haven't

Enable with env var ENABLE_ZYGOTE_MANAGER=1.

BUG=11841
TEST=
start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running.  Then create a new tab and browse to two new sites. 

Here's an example script to hide and unhide the .pak files (note: do not move the directory they're in, that doesn't work):

#!/bin/sh
chmod_all() {
   chmod $1 sconsbuild/Debug/chrome
   for path in . locales obj/chrome/app/intermediate/repack obj/global_intermediate/* themes
   do
     chmod $1 sconsbuild/Debug/$path/*.pak
   done
}
case $1 in
hide) chmod_all 000 ;;
show) chmod_all 755 ;;
esac


Review URL: http://codereview.chromium.org/115773
------------------------------------------------------------------------
r17827 | yusukes@google.com | 2009-06-06 12:04:15 +0200 (Sat, 06 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/app/animation.cc
   M /trunk/src/app/animation.h
   M /trunk/src/app/animation_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab.html

Second (and hopefully the final) fix for the issue 805:

Killed (1) the "start download" (big arrow) animation and (2) fade and resize animation on NTP page, when the following conditions is met:

(XP) Chromium is used over RDP.
(Vista) "Turn off all unnecessary animations (when possible)" option in "Control Panel - Ease of Access Center - Make the computer easier to see" is checked. Note that the option automatically becomes checked when a user turns off the "Menu and window animation" option of a remote-desktop client.

Review: http://codereview.chromium.org/115304

BUG=805
TEST=For (1), download a file and verify the arrow doesn't appear over RDP. For (2), set NTP as your homepage, start chromium on RDP session, verify fade animations on thumbnails are killed, then resize browser window, verify resize animations on thumbnails are also killed. Do the same thing with --new-new-tab-page command line flag. 

Review URL: http://codereview.chromium.org/118307
------------------------------------------------------------------------
r17826 | phajdan.jr@chromium.org | 2009-06-06 10:19:49 +0200 (Sat, 06 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h

Display extension processes in task manager.

This is the first part of the change. I will submit code to listen
for new extension processes while task manager is open in following patch(es).

TEST=Install an extension which renders to the extension shelf, like Buildbot Monitor from http://dev.chromium.org/developers/design-documents/extensions/samples. Open the task manager. You should see the extension process.

http://crbug.com/12127

Review URL: http://codereview.chromium.org/115858
------------------------------------------------------------------------
r17825 | aa@chromium.org | 2009-06-06 10:13:34 +0200 (Sat, 06 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Make extensions installable again.

Review URL: http://codereview.chromium.org/119279
------------------------------------------------------------------------
r17823 | mhm@chromium.org | 2009-06-06 06:30:09 +0200 (Sat, 06 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Duplicate Accelerator mapping in browser window 

CTRL+W is duplicated twice, we just need one, so this is just a cleanup.

BUG=none
TEST=CTRL+W works
Review URL: http://codereview.chromium.org/118360
------------------------------------------------------------------------
r17818 | thestig@chromium.org | 2009-06-06 03:04:34 +0200 (Sat, 06 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h

Partial revert of r17790. Don't use a OwnedWidgetGtk for container_.
Review URL: http://codereview.chromium.org/119274
------------------------------------------------------------------------
r17817 | arv@google.com | 2009-06-06 03:02:36 +0200 (Sat, 06 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html

Don't call HandleGetMostVisited on the backend after each black list
operation. Instead let JS do the call as needed. This is in preparation
for the new new tab page which will do other things when an URL is
blacklisted.

Also, fix some issue in the last CL

BUG=13362

TEST=Add and clear most visted items like before. Things should work as
before

Review URL: http://codereview.chromium.org/118350
------------------------------------------------------------------------
r17809 | ben@chromium.org | 2009-06-06 02:38:03 +0200 (Sat, 06 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Rename BrowserToolbarView->ToolbarView to match file name.
Reorganize functions in CC to match header and related OCD activities.
No logic changes.

Review URL: http://codereview.chromium.org/118352
------------------------------------------------------------------------
r17807 | shess@chromium.org | 2009-06-06 02:30:11 +0200 (Sat, 06 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Only allow tabs to be dragged between compatible windows.

Right now, this means windows with the same Profile.

http://crbug.com/12241
TEST=Open some tabs in incognito and regular windows.  Try to drag between.  Should be able to drag between like security contexts (incognito to incognito, regular to regular), but not across.

Review URL: http://codereview.chromium.org/119266
------------------------------------------------------------------------
r17806 | jcampan@chromium.org | 2009-06-06 02:23:55 +0200 (Sat, 06 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

When navigating to a page triggering an interstitial from the NTP, the title would still be the NTP's one.

http://crbug.com/11998
TEST=See bug.
Review URL: http://codereview.chromium.org/119262
------------------------------------------------------------------------
r17804 | jhawkins@chromium.org | 2009-06-06 02:21:36 +0200 (Sat, 06 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add dock_info.cc to the linux build.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118344
------------------------------------------------------------------------
r17800 | mbelshe@google.com | 2009-06-06 01:24:46 +0200 (Sat, 06 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Missed a file on checkin for multi-process handling of benchmarking extension.

BUG=none
TEST=non
Review URL: http://codereview.chromium.org/118323
------------------------------------------------------------------------
r17798 | pkasting@chromium.org | 2009-06-06 01:16:29 +0200 (Sat, 06 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Completely miscellaneous minor cleanup.  Remove some unneeded class declarations, modify or add a couple comments, change a function name in hopes of greater accuracy.
Review URL: http://codereview.chromium.org/119264
------------------------------------------------------------------------
r17797 | mpcomplete@google.com | 2009-06-06 01:15:02 +0200 (Sat, 06 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/utility/utility_thread.cc

Fix an issue where themes would sporadically fail to install.

Trying to send decoded images over IPC didn't work too well.  Instead, we'll
write them to a file and have the browser slurp them in from there.  My first
instinct was to use SharedMemory, but that would require us to impose a limit
on the size of the decoded image data.

Also made sure that the undecoded images are deleted when we install.

BUG=13455
TEST=Try the repro steps in bug 13455 several times and make sure it works
every time.
Review URL: http://codereview.chromium.org/119255
------------------------------------------------------------------------
r17796 | mattm@chromium.org | 2009-06-06 01:09:04 +0200 (Sat, 06 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Move ConvertAcceleratorsFromWindowsStyle into chrome/common/gtk_util.
Use it on the custom startup url buttons.

BUG=11507

Review URL: http://codereview.chromium.org/118327
------------------------------------------------------------------------
r17791 | pkasting@chromium.org | 2009-06-06 01:03:32 +0200 (Sat, 06 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/go_button.cc

Give the Go button the correct tooltip based on what's in the omnibox.

BUG=6906
TEST=Type "foo" into the Omnibox.  Verify the Go button tooltip refers to searching for "foo" using your default engine.  Change to "foo.com".  Verify the Go button tooltip refers to navigating to foo.com.  Change to using some custom search engine (e.g. tab-to-search on yahoo.com) and put in a search term.  Verify the Go button tooltip refers to searching for your term on the chosen engine.
Review URL: http://codereview.chromium.org/119263
------------------------------------------------------------------------
r17790 | thestig@chromium.org | 2009-06-06 01:03:14 +0200 (Sat, 06 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/common/owned_widget_gtk.h

Implement and use the -> operator for OwnedWidgetGtk.

Also change dragged_tabs_gtk's container_ to be a OwnedWidgetGtk just to be on the safe side.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119221
------------------------------------------------------------------------
r17786 | tc@google.com | 2009-06-06 00:49:53 +0200 (Sat, 06 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Remove a bunch of #ifs in browser.h and browser.cc.  These methods compile
fine on linux/mac.  I disabled the ones that crash right now.  Most of
the methods just call into browser_window_{gtk,cocoa} and hit a
NOTIMPLEMENTED.

Review URL: http://codereview.chromium.org/119217

------------------------------------------------------------------------
r17781 | jcampan@chromium.org | 2009-06-06 00:18:09 +0200 (Sat, 06 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/native_library.h
   M /trunk/src/base/native_library_linux.cc
   M /trunk/src/base/native_library_mac.mm
   M /trunk/src/base/native_library_win.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/browser/browser_test_launcher_in_proc.cc
   A /trunk/src/chrome/test/browser/browser_test_launcher_out_of_proc.cc
   A /trunk/src/chrome/test/browser/browser_test_runner.cc
   A /trunk/src/chrome/test/browser/browser_test_runner.h
   D /trunk/src/chrome/test/browser/browser_tests_launcher.cc
   M /trunk/src/chrome/test/browser/run_all_unittests.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_mac.mm

Porting the browser tests to Unix.
The browser tests are an alternative to UI tests.
They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes).
In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests.

BUG=None
TEST=Run the browser tests. 

Review URL: http://codereview.chromium.org/115896
------------------------------------------------------------------------
r17780 | jhawkins@chromium.org | 2009-06-06 00:15:46 +0200 (Sat, 06 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Make sure the tabstrip we're dragging in to is compatible with the source tabstrip.

BUG=none
TEST=Drag tabs between tabstrips.
Review URL: http://codereview.chromium.org/119258
------------------------------------------------------------------------
r17779 | finnur@chromium.org | 2009-06-06 00:10:01 +0200 (Sat, 06 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix build.

TBR=erikkay

Review URL: http://codereview.chromium.org/118337
------------------------------------------------------------------------
r17778 | klink@chromium.org | 2009-06-05 23:56:48 +0200 (Fri, 05 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webaccessibility.h
   M /trunk/src/webkit/glue/webaccessibilitymanager_impl.cc
   M /trunk/src/webkit/glue/webaccessibilitymanager_impl.h

Fixes an issue where the MSAA information was not reported back correctly to the AT, upon the HWND containing the web content first receiving focus. Note that this is not a full fix for the bug below, but one more piece to resolving it.BUG=13291TEST=none
Review URL: http://codereview.chromium.org/118206
------------------------------------------------------------------------
r17777 | finnur@chromium.org | 2009-06-05 23:53:19 +0200 (Fri, 05 Jun 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc

Add this ability to install Extensions using preferences. Also known as: port the installation mechanism to other platforms.

We already have the ability to install extensions using a registry key. That works only on Windows so this new change adds the same but using preferences instead of the Registry. This will eventually allow us to pre-install certain extensions when we install Chrome.

BUG=12060
TEST=Covered by unit tests, but to test manually: close Chrome, open your Preferences file (in your profile) and add this (after substituting all <values> in elbow brackets):

   "extensions": {
      "settings": {
         "<your_extension_id_lowercased>": {
            "external_crx": "<path_to_crx>",
            "external_version": "<crx version>"
         }
      },
   },

... then start Chrome. Your extension should get installed. 
Review URL: http://codereview.chromium.org/119195
------------------------------------------------------------------------
r17775 | sgk@google.com | 2009-06-05 23:42:17 +0200 (Fri, 05 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container.h
   A /trunk/src/chrome/browser/views/blocked_popup_container_view.cc (from /trunk/src/chrome/browser/views/blocked_popup_container.cc:17736)
   A /trunk/src/chrome/browser/views/blocked_popup_container_view.h (from /trunk/src/chrome/browser/views/blocked_popup_container.h:17736)
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/chrome.gyp

Change the name of chrome\browser\views\blocked_popup_container.{cc,h}
to blocked_popup_container_view.{cc,h}, to avoid duplication
with the same-named files in chrome\browser.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119253
------------------------------------------------------------------------
r17774 | pkasting@chromium.org | 2009-06-05 23:36:50 +0200 (Fri, 05 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc

Fix flicker that happened when hitting ctrl while in FORCED_QUERY mode.  We were comparing an input that had the "?" stripped off to one which didn't and thus never setting |minimal_changes| = true.

BUG=13295
TEST=Type "?foo" into the omnibox.  Then hit the ctrl key.  The box should not flicker at all when pressing and releasing ctrl.
Review URL: http://codereview.chromium.org/118325
------------------------------------------------------------------------
r17773 | glen@chromium.org | 2009-06-05 23:35:30 +0200 (Fri, 05 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/views/widget/default_theme_provider.cc
   M /trunk/src/views/widget/default_theme_provider.h

More theme bits for the NTP and window frame.

BUG=12768,13352
TEST=Verify that a theme with attribution works on the NTP and a theme with an overlay shows up

Review URL: http://codereview.chromium.org/119227
------------------------------------------------------------------------
r17766 | arv@google.com | 2009-06-05 22:42:39 +0200 (Fri, 05 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adds the backend for pinned items on the most visited page.

The pinned items are stored in the pref ntp.pinned_urls.

TEST=For now this should not change the behavior of the most visited thumbnails.

BUG=13362

Review URL: http://codereview.chromium.org/118269
------------------------------------------------------------------------
r17765 | estade@chromium.org | 2009-06-05 22:39:12 +0200 (Fri, 05 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   A /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/url_picker_dialog_gtk.h
   M /trunk/src/chrome/chrome.gyp

Implement custom startup url list.  (Recent urls list in the add url dialog not
implemented yet.)

BUG=11507

patch by Matt Mueller (mattm@google.com)
http://codereview.chromium.org/118280

------------------------------------------------------------------------
r17764 | estade@chromium.org | 2009-06-05 22:35:33 +0200 (Fri, 05 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc

Use custom strings for importer lock dialog.

Also make the text wrap.

BUG=13435

Review URL: http://codereview.chromium.org/118318
------------------------------------------------------------------------
r17762 | jcampan@chromium.org | 2009-06-05 22:17:58 +0200 (Fri, 05 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_win.cc

The table was deleted after the model and the table accesses the model in its destructor, causing a failure in the browser tests.

BUG=None
TEST=Run the browser tests
Review URL: http://codereview.chromium.org/118315
------------------------------------------------------------------------
r17757 | pkasting@chromium.org | 2009-06-05 21:41:46 +0200 (Fri, 05 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Better behavior for ctrl-k: If we're already in forced_query mode, re-select the query text instead of clearing the box.

BUG=6985
TEST=Press ctrl-k, type "foo", press ctrl-k again.  The omnibox should show "?foo" with "foo" selected.
Review URL: http://codereview.chromium.org/119135
------------------------------------------------------------------------
r17755 | glen@chromium.org | 2009-06-05 21:17:40 +0200 (Fri, 05 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Don't prompt before installing a Theme, move existing prompt so that users aren't prompted twice in the case when they have extensions disabled.

Theme installation confirmation will be done through an infobar (allowing you to preview a lot of themes quickly without dealing with dialogs) - see CL 119235.

BUG=none
TEST=Install a theme, verify that you don't get prompted. Install an extension and verify that you do get prompted.
Review URL: http://codereview.chromium.org/119232
------------------------------------------------------------------------
r17754 | estade@chromium.org | 2009-06-05 21:15:33 +0200 (Fri, 05 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   A /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h
   M /trunk/src/chrome/chrome.gyp

Implement some drag-n-drop for the bookmark manager.

Factor out shared code into bookmark_utils_gtk.*.

Fix a leak with toolbar button dragging.

BUG=13110
TEST=Added extra DCHECKs. Also, you can drag between the right half of the bookmark manager and the bookmark bar with no crashes.

Review URL: http://codereview.chromium.org/119220
------------------------------------------------------------------------
r17753 | evan@chromium.org | 2009-06-05 21:15:00 +0200 (Fri, 05 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h

Improve resizing behavior of options window.  Rather than extra whitespace at
the bottom, allow the custom url list to expand.

BUG=11507

Review URL: http://codereview.chromium.org/118203
Patch from Matt Mueller <mattm@google.com>.
------------------------------------------------------------------------
r17751 | mpcomplete@google.com | 2009-06-05 21:07:01 +0200 (Fri, 05 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Make AsyncExtensionFunction possible.

Change the bookmarks API to be async functions, so that they can delay their
response until the bookmark system is loaded.

BUG=12353
TEST=none
Review URL: http://codereview.chromium.org/114079
------------------------------------------------------------------------
r17748 | kuchhal@chromium.org | 2009-06-05 21:00:26 +0200 (Fri, 05 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc

If there is nothing to import, return.

Fixed DCHECK.

BUG=13246
TEST=In chrome debug build, do not select anything to import and click "Import".

Review URL: http://codereview.chromium.org/119104
------------------------------------------------------------------------
r17743 | mpcomplete@google.com | 2009-06-05 20:23:21 +0200 (Fri, 05 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Refuse to load extension-private plugins for pages that don't belong to that
extension.

BUG=12960
TEST=none
Review URL: http://codereview.chromium.org/118198
------------------------------------------------------------------------
r17741 | shess@chromium.org | 2009-06-05 20:19:53 +0200 (Fri, 05 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Ignore selections where the user dragged off the popup.

http://crbug.com/13107
TEST=Start typing in omnibox.  Click in the popup and drag mouse off before releasing.  Shouldn't crash.

Review URL: http://codereview.chromium.org/112097
------------------------------------------------------------------------
r17740 | pinkerton@chromium.org | 2009-06-05 20:19:10 +0200 (Fri, 05 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   A /trunk/src/chrome/browser/cocoa/custom_home_pages_model.h
   A /trunk/src/chrome/browser/cocoa/custom_home_pages_model.mm
   A /trunk/src/chrome/browser/cocoa/custom_home_pages_model_unittest.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Implement table for custom home pages at startup on Mac.
BUG=13151
TEST=custom home pages table. adding to it, removing. use current. enabling and disabling when applicable.
Review URL: http://codereview.chromium.org/119242
------------------------------------------------------------------------
r17725 | pfeldman@chromium.org | 2009-06-05 12:13:44 +0200 (Fri, 05 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_manager_unittest.cc

DevTools: Make reloading inspector lead to the complete DevTools Client Window reopening.

BUG=12956
Review URL: http://codereview.chromium.org/119178
------------------------------------------------------------------------
r17724 | pfeldman@chromium.org | 2009-06-05 11:40:51 +0200 (Fri, 05 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Disable "Duplicate" and "Copy URL" window actions on TYPE_APP browsers.

Review URL: http://codereview.chromium.org/119180
------------------------------------------------------------------------
r17722 | mbelshe@google.com | 2009-06-05 09:33:21 +0200 (Fri, 05 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   A /trunk/src/webkit/extensions/v8/benchmarking_extension.cc
   A /trunk/src/webkit/extensions/v8/benchmarking_extension.h
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/webkit.gyp

Add an extension to expose some primitives to JS for doing 
benchmarking from within Chrome.  Because the JS resides
in the renderer and the HTTP logic resides in the browser,
this required creation of two new, control messages which
can be sent from the renderer to the browser.

These are controlled under a new commandline option
"--enable-benchmarking"

BUG=6754
TEST=none

Review URL: http://codereview.chromium.org/119191
------------------------------------------------------------------------
r17712 | jam@chromium.org | 2009-06-05 07:35:07 +0200 (Fri, 05 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h

Fix regression from r11509 which caused each plugin instance to have its own IPC channel (doh!).

BUG=119052
TEST=covered by ui test that Amit added
Review URL: http://codereview.chromium.org/119158
------------------------------------------------------------------------
r17708 | glen@chromium.org | 2009-06-05 05:41:22 +0200 (Fri, 05 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/test/data/extensions/theme_missing_image.crx

Validate that extension resources exist.

BUG=11678
TEST=Make a theme with bad references to images and try to install it. Or just verify that the InstallTheme unit_test passes.

Review URL: http://codereview.chromium.org/119137
------------------------------------------------------------------------
r17707 | hclam@chromium.org | 2009-06-05 04:35:27 +0200 (Fri, 05 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc

Changed to use PushSource for the intermediate buffer
between the IPC layer and the audio hardware interface.
We have completely moved away from being blocking in
AudioRendererHost.
Since we'll be using PushSource for a longer period
of buffering. It's necessary to have
Play/Pause functionality in the AudioOutputStream,
this is simulated by start/stop the AudioOutputStream
multiple times.

Review URL: http://codereview.chromium.org/114069
------------------------------------------------------------------------
r17702 | jar@chromium.org | 2009-06-05 03:46:57 +0200 (Fri, 05 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.h

Fix tree bustage

TBR
Review URL: http://codereview.chromium.org/119225
------------------------------------------------------------------------
r17699 | jar@chromium.org | 2009-06-05 03:34:35 +0200 (Fri, 05 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/net/base/sdch_manager.h

Prevent SDCH from re-trying to download a dicitionary

Some dicitoaries provided by an SDCH server may be larger than
allowed by Chromium (which holds the dictionary memory-resident).
This CL prevents Chromium from endlessly re-trying such dicitonary loads, 

BUG=7722

r=huanr
Review URL: http://codereview.chromium.org/119198
------------------------------------------------------------------------
r17697 | jar@chromium.org | 2009-06-05 03:34:20 +0200 (Fri, 05 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc

Reverting 17638.

This relands http://src.chromium.org/viewvc/chrome?view=rev&revision=17605
which was reverted in 17638.

It also disables MassiveConcurrentLookupTest, which was a stress test,
and is partially obsolete since the class now responds to congestion
produced by NOT resolving all names.
BUG=13356

TBR=willchan
Review URL: http://codereview.chromium.org/119196
------------------------------------------------------------------------
r17693 | estade@chromium.org | 2009-06-05 03:17:32 +0200 (Fri, 05 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: Fake a mouse move event when the render view gains focus and the mouse is over it.

On windows, when the render view regains focus it receives a mouse move event with the coordinates of the pointer. We don't on linux, so we have to fake this. Without this, webkit doesn't know where the pointer is, so can have a wrong cursor or other graphical glitches.

TEST=bug is fixed
BUG=12879

Review URL: http://codereview.chromium.org/113987
------------------------------------------------------------------------
r17692 | slightlyoff@chromium.org | 2009-06-05 02:59:05 +0200 (Fri, 05 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc

Disabling a windows-only test failure to turn the tree green again and re-open. Evmar, willchan, and I are still investigating.

TEST=none

BUG=13388

Review URL: http://codereview.chromium.org/119219
------------------------------------------------------------------------
r17690 | paul@chromium.org | 2009-06-05 01:12:20 +0200 (Fri, 05 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_shelf_view.cc

Fix for closing the download shelf with multiple tabs open.

Make sure that the browser window is informed of the download
shelf visibility status at the end of the show / hide animation.

BUG=13369

Review URL: http://codereview.chromium.org/118278
------------------------------------------------------------------------
r17682 | evan@chromium.org | 2009-06-05 00:28:16 +0200 (Fri, 05 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/ipc_channel.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_channel_win.cc
   M /trunk/src/chrome/common/ipc_channel_win.h
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_sync_channel.cc
   M /trunk/src/chrome/common/ipc_sync_channel.h
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/ipc_tests.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc

ipc: use strings, not wstrings for channel ids.

They're ASCII anyway.

TEST=covered by existing tests

Review URL: http://codereview.chromium.org/119131
------------------------------------------------------------------------
r17677 | ben@chromium.org | 2009-06-05 00:05:44 +0200 (Fri, 05 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/browser/task_manager_win.cc

Latest attempt at enabling task manager tests and not having them leak or crash!

Make Task Manager Table view a scoped_ptr so it and its columns are deleted regardless of whether or not the HWND has been constructed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/119208
------------------------------------------------------------------------
r17675 | sgk@chromium.org | 2009-06-04 23:53:56 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/debugger/debugger.vcproj
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/plugin/plugin.vcproj
   D /trunk/src/chrome/renderer/renderer.vcproj
   D /trunk/src/chrome/test/automation/automation.vcproj

Convert most of the chrome .lib files to gyp generation:
automation.lib, common.lib, debugger.lib, plugin.lib, renderer.lib.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118254
------------------------------------------------------------------------
r17674 | wtc@chromium.org | 2009-06-04 23:53:47 +0200 (Thu, 04 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Remove the obsolete TabContents::GetSecurityStyle and
TabContents::GetSSLEVText methods.

This is discovered by Fumitoshi Ukai.

R=jcampan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118145
------------------------------------------------------------------------
r17672 | ben@chromium.org | 2009-06-04 23:45:37 +0200 (Thu, 04 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Forbid tab drops on application windows.

Change by Chase Phillips <cmp@google.com>

http://crbug.com/9576
TEST=open a standalone GMail shortcut window, attempt to drop a tab from an existing browser window into it. It should not be added.

------------------------------------------------------------------------
r17671 | tc@google.com | 2009-06-04 23:44:13 +0200 (Thu, 04 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Always redraw the location bar background when we resize.

BUG=13342

Review URL: http://codereview.chromium.org/119207

------------------------------------------------------------------------
r17670 | brettw@chromium.org | 2009-06-04 23:43:53 +0200 (Thu, 04 Jun 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/thumbnail_store.cc
   M /trunk/src/chrome/browser/thumbnail_store.h
   A /trunk/src/chrome/browser/thumbnail_store_unittest.cc

Implement a first pass at thumbnail store storage to disk, including a unit test for the new behavior.

TEST=covered by unittest
BUG=none
------------------------------------------------------------------------
r17662 | shess@chromium.org | 2009-06-04 22:43:44 +0200 (Thu, 04 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Don't update our text from toolbar if the toolbar's text doesn't
visibly differ from the model's text.

In most cases, this doesn't come up, because focus is usually not in
the field (so there wouldn't be local changes), but when opening NTP
you can type between when the tab opens in the browser and when the
renderer finishes loading it.  In that case, the model and toolbar
both have "" as the url text, so this case is hit.

http://crbug.com/13109
TEST=Browse to www.google.com.  Command-t for new tab and type http as fast as you can.  Before this fix, you sometimes got "tp" or something of the sort.

Review URL: http://codereview.chromium.org/119125
------------------------------------------------------------------------
r17659 | estade@chromium.org | 2009-06-04 22:27:55 +0200 (Thu, 04 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Don't crash when dragging bookmarks from one bookmark bar to another (as with multiple chrome windows).

BUG=none
TEST=drag a bookmark icon from one a bookmark bar to a bar in another window without crashing.

Review URL: http://codereview.chromium.org/119114
------------------------------------------------------------------------
r17655 | tc@google.com | 2009-06-04 22:10:31 +0200 (Thu, 04 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

On linux, add a context menu item in the tab strip for disabling
window decorations.

This is mostly just an experiment.  The window currently looks bad
because of no rounded corners.  It's also not possible to resize in
this state and if you have too many tabs, you can't move.

Review URL: http://codereview.chromium.org/114075

------------------------------------------------------------------------
r17654 | glen@chromium.org | 2009-06-04 22:02:07 +0200 (Thu, 04 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Make the inactive tab background line up with the parent without using magic numbers.

BUG=12761
TEST=Verify that the inactive tab background lines up with the frame image in maximized and unmaximized mode - you will need a heavily patterned theme to test with.

Review URL: http://codereview.chromium.org/118221
------------------------------------------------------------------------
r17652 | glen@chromium.org | 2009-06-04 21:59:08 +0200 (Thu, 04 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Fix for DWM crash.

BUG=13075
TBR=ben
TEST=On XP, verify that Chrome doesn't crash when a theme is installed or reset.

Review URL: http://codereview.chromium.org/118252
------------------------------------------------------------------------
r17649 | erg@google.com | 2009-06-04 21:36:33 +0200 (Thu, 04 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Why can't passing localy and on the try bots mean it compiles on the builders? Fix 2.
TBR=beng

Review URL: http://codereview.chromium.org/112094
------------------------------------------------------------------------
r17648 | erg@google.com | 2009-06-04 21:30:29 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Add atlapp.h. Wasn't neccessary on my local windows machine but builders want it.

TBR=beng

Review URL: http://codereview.chromium.org/119194
------------------------------------------------------------------------
r17647 | erg@google.com | 2009-06-04 21:22:13 +0200 (Thu, 04 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/blocked_popup_container.cc
   A /trunk/src/chrome/browser/blocked_popup_container.h (from /trunk/src/chrome/browser/views/blocked_popup_container.h:17642)
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   D /trunk/src/chrome/test/data/constrained_files/constrained_window_onload_moveto.html

Relanding the first of probably several patches trying to clean up the BlockedPopupContainer into something that can be cross-platform.
- BlokedPopupContainers are no longer ConstrainedWindows.
- There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement.

This version has minor windows compile fixes that changed from under me.

Original Review URL: http://codereview.chromium.org/119006

TBR=beng
TEST=Popup notification still works.

Review URL: http://codereview.chromium.org/119107
------------------------------------------------------------------------
r17646 | mpcomplete@google.com | 2009-06-04 21:22:05 +0200 (Thu, 04 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix a NOTREACHED in RenderViewHost::OnExtensionRequest.  It was firing because
RenderViewHosts created via window.open don't have their enabled_bindings_
set.
Review URL: http://codereview.chromium.org/119134
------------------------------------------------------------------------
r17642 | tc@google.com | 2009-06-04 20:27:35 +0200 (Thu, 04 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux toolbar cleanups.

1) Set a consistent padding between toolbar buttons by grouping controls
that have different paddings into hboxes.  E.g., back/forward are in a
grouped hbox and the menu buttons are in an hbox.

2) Hook the home button up to the user pref.

3) Change how we show the various widgets so home button only shows up
when the pref is enabled.

Review URL: http://codereview.chromium.org/118195

------------------------------------------------------------------------
r17641 | ben@chromium.org | 2009-06-04 20:27:27 +0200 (Thu, 04 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Implement window state restoration for the views-gtk window.
Allows the window to be resized smaller than its current size by setting a minimum size before initiating the drag.
Fixes a crash in TabContentsViewGtk due to a NULL delegate deref.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118227
------------------------------------------------------------------------
r17640 | ben@chromium.org | 2009-06-04 20:27:17 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Make tab resize relayout on mouse out work.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118228
------------------------------------------------------------------------
r17638 | willchan@chromium.org | 2009-06-04 19:12:48 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc

Fix purify freeze.  Revert "Use a priority queue to assure that subresources are resolved asap"
This reverts git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17605 0039d316-1c4b-4281-b951-d872f2087c98
TBR=jar

Review URL: http://codereview.chromium.org/118239
------------------------------------------------------------------------
r17632 | mirandac@chromium.org | 2009-06-04 17:28:02 +0200 (Thu, 04 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

Fix timing issue with first run bubble, and tweak size of OEM bubble so it looks more like Glen's mock.

BUG= http://crbug.com/9233
TEST= Run Chrome with --first-run option.  Notice that first run info bubble does not go away within the first second even if you click on or away from the browser.


Review URL: http://codereview.chromium.org/118143
------------------------------------------------------------------------
r17631 | rafaelw@chromium.org | 2009-06-04 16:58:18 +0200 (Thu, 04 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h

make extension apis tolerate browser absence during start-up & shutdown

Note: I was never able to directly reproduce the 13082 bug, the error mode is clear (there was no selected tab during a call to tabs.getSelected()). This fix will address that issue and we should stop seeing this crash reports.

R=erikkay
BUG=13082

Review URL: http://codereview.chromium.org/119117
------------------------------------------------------------------------
r17629 | pfeldman@chromium.org | 2009-06-04 12:30:11 +0200 (Thu, 04 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

DevTools: Set Chrome icon to Dev Tools window.
BUG=12687

Review URL: http://codereview.chromium.org/119168
------------------------------------------------------------------------
r17628 | deanm@chromium.org | 2009-06-04 12:25:45 +0200 (Thu, 04 Jun 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Revert a ctrl-enter change for Omnibox, it made inline autocomplete totally crazy.
For example, pressing ctrl while you have an inline autocomplete toggles the autocomplete
on and off, etc.

commit 51b37c5ce628836b22f68aa94ad871ce8cb1f66b
Author: estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Mon Jun 1 21:38:11 2009 +0000

    GTK: respect control key for setting TLD=com.

    BUG=13096
    Review URL: http://codereview.chromium.org/118086

    git-svn-id: svn://chrome-svn/chrome/trunk/src@17356 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/119169

------------------------------------------------------------------------
r17622 | ben@chromium.org | 2009-06-04 10:05:10 +0200 (Thu, 04 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.h

This is also required.


------------------------------------------------------------------------
r17621 | ben@chromium.org | 2009-06-04 10:03:56 +0200 (Thu, 04 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_unittest.cc

Temporarily disable these two tests while I figure out how this spaghetti interacts. Will re-enable tomorrow.

TBR=jcampan
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/119164
------------------------------------------------------------------------
r17609 | sgk@chromium.org | 2009-06-04 07:45:18 +0200 (Thu, 04 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/locales/locales.gyp
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser/browser_tests_dll.vcproj
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/tools/build/win/language_dll.vsprops
   M /trunk/src/tools/grit/build/grit_localized_resources.rules
   M /trunk/src/tools/grit/build/grit_resources.rules
   M /trunk/src/tools/grit/build/using_generated_resources.vsprops

Convert to gyp generation of chrome_resources and chrome_strings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119128
------------------------------------------------------------------------
r17608 | ben@chromium.org | 2009-06-04 07:42:11 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Allow WindowGtks to be moved and sized when the mouse is over the caption or sizing border.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118218
------------------------------------------------------------------------
r17605 | jar@chromium.org | 2009-06-04 07:28:21 +0200 (Thu, 04 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc

Use a priority queue to assure that subresources are resolved asap

Also implement DNS congestion avoidance in the pre-fetch system.

BUG=13276

r=mbelshe
Review URL: http://codereview.chromium.org/118149
------------------------------------------------------------------------
r17598 | brettw@chromium.org | 2009-06-04 05:57:39 +0200 (Thu, 04 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

Successor to http://codereview.chromium.org/115748

This change pulls in the new googleurl, which contains the ability to parse
partial IPv6 literals.

Add a test for chromium's SegmentURL, to verify that it's working.

BUG=none
TEST=Ran "unit_tests" in Debug and Release mode.
Patch by pmarks@google.com
------------------------------------------------------------------------
r17595 | thakis@chromium.org | 2009-06-04 05:30:22 +0200 (Thu, 04 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Move download shelf from per-tab to per-window.  Also disable auto-hiding of
the shelf.

BUG=9025
TEST=Download file in one tab, open new tab, and check that download shelf is
still open. Also try the shelf's close button and the "show all downloads"
link. When saving a file, the download animation should not show up.

Review URL: http://codereview.chromium.org/115740

------------------------------------------------------------------------
r17592 | glen@chromium.org | 2009-06-04 05:00:25 +0200 (Thu, 04 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/browser_theme_provider_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Unittests for NTP alignment changes (separate CL for Try server purposes). See http://codereview.chromium.org/115910

BUG=12768
TEST=none

Review URL: http://codereview.chromium.org/115911
------------------------------------------------------------------------
r17587 | glen@chromium.org | 2009-06-04 04:31:20 +0200 (Thu, 04 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h

Reland of r17500:

Theme our bookmark bar buttons.

BUG=12467
TEST=Apply a theme and verify that bookmark bar text colors changes.

------------------------------------------------------------------------
r17586 | glen@chromium.org | 2009-06-04 04:31:02 +0200 (Thu, 04 Jun 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/back_mask.png
   A /trunk/src/chrome/app/theme/button_mask.png
   A /trunk/src/chrome/app/theme/forward_mask.png
   A /trunk/src/chrome/app/theme/go_mask.png
   M /trunk/src/chrome/app/theme/notused.png
   A /trunk/src/chrome/app/theme/star_mask.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/image_button.h

Add ability to theme our buttons.

BUG=12762
TEST=Verify that buttons can be themed.

Review URL: http://codereview.chromium.org/119025
------------------------------------------------------------------------
r17583 | ben@chromium.org | 2009-06-04 04:20:21 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Fix toolkit_views bustage.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112093
------------------------------------------------------------------------
r17581 | evan@chromium.org | 2009-06-04 03:36:22 +0200 (Thu, 04 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_win.cc

Revert "It looks like the unit tests instantiate the TaskManagerView..."

This reverts commit r17573, on beng's request.
------------------------------------------------------------------------
r17577 | agl@chromium.org | 2009-06-04 02:29:15 +0200 (Thu, 04 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   D /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   D /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   D /trunk/src/skia/ext/SkFontHost_fontconfig.cpp
   D /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp
   D /trunk/src/skia/ext/SkFontHost_fontconfig_direct.h
   D /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   D /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.cpp
   D /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.h
   M /trunk/src/skia/skia.gyp

Revert r17575 and r17576. They are causing layout test errors.

------------------------------------------------------------------------
r17575 | agl@chromium.org | 2009-06-04 02:04:07 +0200 (Thu, 04 Jun 2009) | 28 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   A /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.cc
   A /trunk/src/chrome/browser/renderer_host/render_sandbox_host_linux.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   A /trunk/src/skia/ext/SkFontHost_fontconfig.cpp
   A /trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp
   A /trunk/src/skia/ext/SkFontHost_fontconfig_direct.h
   A /trunk/src/skia/ext/SkFontHost_fontconfig_impl.h
   A /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.cpp
   A /trunk/src/skia/ext/SkFontHost_fontconfig_ipc.h
   M /trunk/src/skia/skia.gyp
   M /trunk/src/webkit/webkit.gyp

Linux: Add support for chrooted renderers.

http://code.google.com/p/chromium/wiki/LinuxSandboxIPC

Without filesystem access from the renderers, we need another way of
dealing with fontconfig and font loading.

This add support for:
  * An "SBX_D" environment variable in the renderers which is used to
    signal the end of dynamic linking so that the chroot can be
    enforced.
  * A sandbox_host process, running outside the sandbox, to deal with
    fontconfig requests from the renderers. See the wiki page for
    the reasoning behind making it a separate process.
  * A new, custom SkFontHost for Skia. Because this is Chrome
    specific, it will live outside the upstream Skia tree. This
    FontHost can be configured either to drive fontconfig directly
    (for the browser process and for any unsandboxed renderers) or to
    use an IPC system. Since the same SkFontHost has to be linked into
    both the browser and renderer (they are the same binary), this
    switch has to be made at run time.

Sandbox IPC calls are rare (a couple of dozen at page load time) and
add about 50us of overhead for each call.

http://codereview.chromium.org/112074
BUG=8081

------------------------------------------------------------------------
r17573 | ben@chromium.org | 2009-06-04 02:00:34 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_win.cc

It looks like the unit tests instantiate the TaskManagerView without actually creating the window it lives in. Make sure the table is only allocated and initialized when it's inserted into a view hierarchy to avoid leaking the columns.

BUG=none
TEST=purify unit test bot
Review URL: http://codereview.chromium.org/118199
------------------------------------------------------------------------
r17567 | jhawkins@chromium.org | 2009-06-04 01:31:18 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Don't reset the gdk_event_handler in the tab destructor as this overwrites the handler set up by a potentially new tab.

BUG=none
TEST=Open a new browser window with two tabs.  Open a second browser window.  Drag a tag in and out of the tabstrip in the second browser window.
Review URL: http://codereview.chromium.org/119124
------------------------------------------------------------------------
r17562 | pkasting@chromium.org | 2009-06-04 01:07:35 +0200 (Thu, 04 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/common/notification_type.h

Fix crash due to AutocompletePopup trying to draw the old results when they were no longer available.I introduced this regression when moving |result_| to the AutocompleteController; the specific problem was the "result_.CopyFrom(latest_result_);" line I added when handling the synchronous messages being available.  This was done so the popup could get at the new results to update the edit with them.Instead, go back to the old method (of not updating the results until the first coalesced update came in), and pass the appropriate result set as a Details<> in the notification, so the popup can get at it without having to know how the controller works under-the-hood.BUG=11742
Review URL: http://codereview.chromium.org/119116
------------------------------------------------------------------------
r17559 | erikkay@google.com | 2009-06-04 01:00:09 +0200 (Thu, 04 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/browser_bubble.cc
   M /trunk/src/chrome/browser/views/browser_bubble.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Part 1 of dragging extensions on the shelf.  This part was just about getting the mechanics of the shelf handle and the dragging correct.  Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag.  release.
Review URL: http://codereview.chromium.org/119103
------------------------------------------------------------------------
r17557 | stuartmorgan@chromium.org | 2009-06-04 00:50:56 +0200 (Thu, 04 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Turn on the PasswordStoreMac implementation.

BUG=11745
TEST=Passwords from Keychain should be filled once the username field is filled and blurred.
Review URL: http://codereview.chromium.org/119118
------------------------------------------------------------------------
r17556 | ben@chromium.org | 2009-06-04 00:49:26 +0200 (Thu, 04 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix toolkit_views build.
Review URL: http://codereview.chromium.org/119119
------------------------------------------------------------------------
r17555 | ericroman@google.com | 2009-06-04 00:44:27 +0200 (Thu, 04 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/net/url_request/url_request.h

Update some comments in url_request.h to clarify that once the request is deleted/cancelled, the delegate should never be called again.

(The text added to URLRequest::Cancel() was copied from URLRequest::~URLRequest()).

The comment change in resource_dispatcher_host.cc is an unrelated name fix.

TEST=0
BUG=0

Review URL: http://codereview.chromium.org/118151
------------------------------------------------------------------------
r17553 | agl@chromium.org | 2009-06-04 00:28:40 +0200 (Thu, 04 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Linux: added overflow checks in the X BackingStore code.

http://codereview.chromium.org/119050

------------------------------------------------------------------------
r17550 | pkasting@chromium.org | 2009-06-04 00:14:11 +0200 (Thu, 04 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/common/native_window_notification_source.h
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_source.h

Allow Source<T> and Details<T> to be instantiated with T = const Foo.
Review URL: http://codereview.chromium.org/118185
------------------------------------------------------------------------
r17548 | jcampan@chromium.org | 2009-06-04 00:10:22 +0200 (Thu, 04 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc

Fix the Linux views build.

BUG=None
TEST=None
TBR=ben
Review URL: http://codereview.chromium.org/118184
------------------------------------------------------------------------
r17545 | stuartmorgan@chromium.org | 2009-06-04 00:00:41 +0200 (Thu, 04 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/password_manager/password_store.cc
   M /trunk/src/chrome/browser/password_manager/password_store.h
   M /trunk/src/chrome/browser/password_manager/password_store_default.cc
   M /trunk/src/chrome/browser/password_manager/password_store_default.h
   M /trunk/src/chrome/browser/password_manager/password_store_gnome.cc
   M /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   M /trunk/src/chrome/browser/password_manager/password_store_kwallet.cc
   M /trunk/src/chrome/browser/password_manager/password_store_kwallet.h
   M /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   M /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.cc
   M /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Change PasswordStoreDefault to access the WebDataService from the UI thread only.
Enables the PasswordStore refactoring yet again (third time's the charm?).

BUG=12479
TEST=Password save/autofill should continue to work on Windows.
Review URL: http://codereview.chromium.org/118131
------------------------------------------------------------------------
r17544 | jcampan@chromium.org | 2009-06-04 00:00:37 +0200 (Thu, 04 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/views/controls/combobox/combobox.cc
   M /trunk/src/views/controls/combobox/combobox.h
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/view.h

Some previous refactoring I did of the accelerator code had introduced regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed.     Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed.     Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox)
Review URL: http://codereview.chromium.org/119016
------------------------------------------------------------------------
r17542 | jhawkins@chromium.org | 2009-06-03 23:49:35 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Implement dragging a tab back into a tabstrip for gtk.

BUG=none
TEST=Open a browser window with two tabs.  Drag one of those tabs in and out of the window's tabstrip many times.  Open a new window and drag a tab into that window's tabstrip.
Review URL: http://codereview.chromium.org/118142
------------------------------------------------------------------------
r17539 | brettw@chromium.org | 2009-06-03 23:41:56 +0200 (Wed, 03 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   A /trunk/src/chrome/browser/renderer_host/backing_store_manager.cc (from /trunk/src/chrome/browser/renderer_host/backing_store.cc:17486)
   A /trunk/src/chrome/browser/renderer_host/backing_store_manager.h (from /trunk/src/chrome/browser/renderer_host/backing_store.h:17486)
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/chrome.gyp

Split the BackingStoreManager out of backing_store.* and into its own class.
Review URL: http://codereview.chromium.org/118179
------------------------------------------------------------------------
r17538 | thestig@google.com | 2009-06-03 23:26:09 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

Change an include to the right header after the app/gfx/gtk_util -> base/gfx/gtk_util merge.

BUG=none
TEST=Linux compile turns green.
Review URL: http://codereview.chromium.org/119111
------------------------------------------------------------------------
r17535 | thestig@google.com | 2009-06-03 23:13:16 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/app/app.gyp
   D /trunk/src/app/gfx/gtk_util.cc
   D /trunk/src/app/gfx/gtk_util.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc

Merge app/gfx/gtk_util into base/gfx/gtk_util.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118174
------------------------------------------------------------------------
r17533 | yutak@chromium.org | 2009-06-03 23:07:08 +0200 (Wed, 03 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_unittest.cc

FocusManager should accept multiple AcceleratorTargets for each accelerator.

Originally, FocusManager automatically unregisters an old target if multiple AcceleratorTargets are registered to the same accelerator. This behavior is somewhat troublesome, and actually ShelfItemDialog hits a run-time assertion due to the conflict of registrations (issue 12401). This change modifies the behavior of FocusManager to allow multiple targets to be registered for each accelerator.

BUG=12401
TEST=See if issue 12401 is resolved.
Review URL: http://codereview.chromium.org/114065
------------------------------------------------------------------------
r17532 | ben@chromium.org | 2009-06-03 23:07:08 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_win.cc

Fix task manager by only adding the table view to the view hierarchy when the task manager view is added.

http://crbug.com/12927
TEST=open the task manager, should work
Review URL: http://codereview.chromium.org/119105
------------------------------------------------------------------------
r17531 | evan@chromium.org | 2009-06-03 22:59:48 +0200 (Wed, 03 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc

plugins: rename GetPluginNativeView to GetNativeView.

That's what the function does, and some callers that had nothing to do with
plugins were calling GetPluginNativeView.

Review URL: http://codereview.chromium.org/118094
------------------------------------------------------------------------
r17529 | estade@chromium.org | 2009-06-03 22:48:54 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc

typo fix to unbreak linux build.

TBR=willchan

Review URL: http://codereview.chromium.org/118183
------------------------------------------------------------------------
r17528 | sidchat@google.com | 2009-06-03 22:20:58 +0200 (Wed, 03 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

UI Support for Auto Spell Correct. Currently, it is still under the command line flag --auto-spell-correct, which means that this UI support will appear only when the command line flag is enabled.BUG=www.crbug.com/13102TEST=enable this feature through the command line flag --auto-spell-correct and then use the Languages Options menu check box to toggle this feature on/off - test by typing "teh" in a text box.
Review URL: http://codereview.chromium.org/119002
------------------------------------------------------------------------
r17527 | estade@chromium.org | 2009-06-03 22:20:21 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h

Linux: more bookmark manager stuff.

Display stuff in the right pane. Also fix a bug I introduced in the last patch.

Review URL: http://codereview.chromium.org/118178
------------------------------------------------------------------------
r17518 | tc@google.com | 2009-06-03 21:53:30 +0200 (Wed, 03 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc

Revert "Disable a failing test on linux."
This reverts commit r17517.

TBR=willchan

Review URL: http://codereview.chromium.org/119100

------------------------------------------------------------------------
r17517 | tc@google.com | 2009-06-03 21:46:27 +0200 (Wed, 03 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc

Disable a failing test on linux.

TBR=erg

Review URL: http://codereview.chromium.org/118180

------------------------------------------------------------------------
r17515 | estade@chromium.org | 2009-06-03 21:36:29 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc

Fix linux unittest that I broke.

TBR=willchan

Review URL: http://codereview.chromium.org/118177
------------------------------------------------------------------------
r17514 | deanm@chromium.org | 2009-06-03 21:16:59 +0200 (Wed, 03 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h

Implement more of the BookmarkBubble, connecting it to the bookmark system.

This allows you to edit the bookmark title, and remove the bookmark.

BUG=11738
TEST=Click the bookmark star, you should be able to edit the bookmark title
     and remove the bookmark.

Review URL: http://codereview.chromium.org/119079

------------------------------------------------------------------------
r17513 | brettw@chromium.org | 2009-06-03 21:11:54 +0200 (Wed, 03 Jun 2009) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

When the contents don't have title, use URL for the name of bookmark entry.
Make it able to drag star even when the contents of address bar is modified.

This change makes the behavior of two different bookmarking operation, starring
and drag-and-drop, consistent.

Currently, bookmarking a page with no title by clicking star creates a bookmark
entry with an empty string as its name field, while dragging star to bookmark
manager uses URL for name field. As suggested in BUG5965, the behavior of
dragging star is better.

I've replaced the code in Browser::BookmarkCurrentPage (one for clicking star)
with the code in BrowserToolbarView::WriteDragData (one for dragging star) to
fix this issue. The former uses NavigationEntry::title() which returns an empty
string, while the latter uses TabContents::GetTitle() which returns URL

Additionally, I've made the check done in
BrowserToolbarView::GetDragOperations() and Browser::BookmarkCurrentPage() such
as ToolbarViewModel::ShouldDisplayURL() consistent. Following the suggestion by
glen, I've removed ToolbarViewModel::input_in_progress() from the check.

TEST=Bookmark page with no title by clicking star and see that the bookmark
     entry has the URL for its name field.

BUG=5965
Original review: http://codereview.chromium.org/113942
Patch by tyoshino@google.com

------------------------------------------------------------------------
r17512 | brettw@chromium.org | 2009-06-03 21:10:29 +0200 (Wed, 03 Jun 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Shows IDN for "Waiting for <host-name>..." message when Chrome is waiting for a
server response.

TEST=Adds "ja" to Accept-Language, accesses
http://www.xn--w22as22a.haun.org/empty.pl, which takes 10 seconds to response,
and confirms "Waiting for ..." message has Unicode host name.
BUG=3991
Original review URL: http://codereview.chromium.org/118070
Patch by tkent@google.com

------------------------------------------------------------------------
r17511 | brettw@chromium.org | 2009-06-03 21:08:48 +0200 (Wed, 03 Jun 2009) | 31 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc

Fix NavigationController::ClassifyNavigation() to treat redirection correctly.

When we enter an address that redirects to some other page to the address box,
it should show the address where we are redirected to after navigation
completes. Currently, it doesn't when we follow this procedure more than once
as described in BUG 5374.

After redirection, the renderer says that it navigated to the same page by
returning existing page_id in ViewHostMsg_FrameNavigate_Params, but
NavigationController::ClassifyNavigation() compares params.url with
pending_entry_->url() and says it's not SAME_PAGE. Therefore, the result is
not correctly treated and goes into EXISTING_PAGE handler. It compares
the existing entry for the page with pending_entry_. It's false, so it doesn't
call DiscardNonCommittedEntriesInternal(). pending_entry_ left not released.
Toolbar's view uses this pending_entry_'s url for showing address on the
address bar.

We should not check URL. Just overwrite entry_ with the response from renderer.

TEST=
Access http://www.google.com , https://www.google.com , and then
https://www.google.com . The address bar should show http://www.google.com .
Prepare some site http://example.com which redirects to http://example.org ,
and then access http://example.com , and then change the redirection to
http://example.net . Retry accessing http://example.com . The address bar
should show http://example.net .

BUG=5374
Original review: http://codereview.chromium.org/115916
Patch by tyoshino@google.com

------------------------------------------------------------------------
r17510 | mpcomplete@google.com | 2009-06-03 21:06:11 +0200 (Wed, 03 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   A /trunk/src/chrome/test/data/extensions/good/extension2/2/content_plugin.dll
   A /trunk/src/chrome/test/data/extensions/good/extension2/2/extension_plugin.dll
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json

Change plugin handling in extension from "plugin_dir" to a "plugin" list of
dictionaries, which allows us to specify properties per plugin.

This is the first part of allowing extensions to have plugins only accessible
by the extension process.

BUG=12960
Review URL: http://codereview.chromium.org/114072
------------------------------------------------------------------------
r17508 | glen@chromium.org | 2009-06-03 20:57:02 +0200 (Wed, 03 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h

Revert r17500

TBR=slightlyoff
BUG=none
TEST=none

------------------------------------------------------------------------
r17507 | jhawkins@chromium.org | 2009-06-03 20:39:45 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Display tooltips for gtk tabs that have elided titles.

BUG=none
TEST=Navigate to a URL with an elided title in the tab.  Hover the mouse over the tab.  A tooltip should appear with the full title.  Navigate to google.com and hover over the tab.  A tooltip should not appear (unless the tab is small enough).
Review URL: http://codereview.chromium.org/118161
------------------------------------------------------------------------
r17502 | glen@chromium.org | 2009-06-03 20:21:13 +0200 (Wed, 03 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/download_button_center_bottom.png
   M /trunk/src/chrome/app/theme/download_button_center_bottom_h.png
   M /trunk/src/chrome/app/theme/download_button_center_bottom_p.png
   M /trunk/src/chrome/app/theme/download_button_center_middle.png
   M /trunk/src/chrome/app/theme/download_button_center_middle_h.png
   M /trunk/src/chrome/app/theme/download_button_center_middle_p.png
   M /trunk/src/chrome/app/theme/download_button_center_top.png
   M /trunk/src/chrome/app/theme/download_button_center_top_h.png
   M /trunk/src/chrome/app/theme/download_button_center_top_p.png
   M /trunk/src/chrome/app/theme/download_button_left_bottom.png
   M /trunk/src/chrome/app/theme/download_button_left_bottom_h.png
   M /trunk/src/chrome/app/theme/download_button_left_bottom_p.png
   M /trunk/src/chrome/app/theme/download_button_left_middle.png
   M /trunk/src/chrome/app/theme/download_button_left_middle_h.png
   M /trunk/src/chrome/app/theme/download_button_left_middle_p.png
   M /trunk/src/chrome/app/theme/download_button_left_top.png
   M /trunk/src/chrome/app/theme/download_button_left_top_h.png
   M /trunk/src/chrome/app/theme/download_button_left_top_p.png
   M /trunk/src/chrome/app/theme/download_button_menu_bottom.png
   M /trunk/src/chrome/app/theme/download_button_menu_bottom_h.png
   M /trunk/src/chrome/app/theme/download_button_menu_bottom_p.png
   M /trunk/src/chrome/app/theme/download_button_menu_middle.png
   M /trunk/src/chrome/app/theme/download_button_menu_middle_h.png
   M /trunk/src/chrome/app/theme/download_button_menu_middle_p.png
   M /trunk/src/chrome/app/theme/download_button_menu_top.png
   M /trunk/src/chrome/app/theme/download_button_menu_top_h.png
   M /trunk/src/chrome/app/theme/download_button_menu_top_p.png
   M /trunk/src/chrome/app/theme/download_button_right_bottom.png
   M /trunk/src/chrome/app/theme/download_button_right_bottom_h.png
   M /trunk/src/chrome/app/theme/download_button_right_bottom_no_dd.png
   M /trunk/src/chrome/app/theme/download_button_right_bottom_p.png
   M /trunk/src/chrome/app/theme/download_button_right_middle.png
   M /trunk/src/chrome/app/theme/download_button_right_middle_h.png
   M /trunk/src/chrome/app/theme/download_button_right_middle_no_dd.png
   M /trunk/src/chrome/app/theme/download_button_right_middle_p.png
   M /trunk/src/chrome/app/theme/download_button_right_top.png
   M /trunk/src/chrome/app/theme/download_button_right_top_h.png
   M /trunk/src/chrome/app/theme/download_button_right_top_no_dd.png
   M /trunk/src/chrome/app/theme/download_button_right_top_p.png
   M /trunk/src/chrome/browser/views/download_shelf_view.cc

Theme the download bar. Mostly this is just changing the background color to match the toolbar, and making the button images transparent.

BUG=11703
TEST=Verify that the download bar matches the theme that is installed.

Review URL: http://codereview.chromium.org/119088
------------------------------------------------------------------------
r17500 | glen@chromium.org | 2009-06-03 20:19:15 +0200 (Wed, 03 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h

Theme our bookmark bar buttons.

BUG=12467
TEST=Apply a theme and verify that bookmark bar text colors changes.

Review URL: http://codereview.chromium.org/112092
------------------------------------------------------------------------
r17499 | ananta@chromium.org | 2009-06-03 20:16:05 +0200 (Wed, 03 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc

Removed focus manager references from the external tab container as we don't need the focus manager to achieve tabbing in and out of the chrome frame widget.

The other change is to add a check for a NULL container window when the tab contents is being freed.
This causes an assert to fire in the focus manager code while trying to unsubclass the window.



Review URL: http://codereview.chromium.org/119074
------------------------------------------------------------------------
r17497 | tc@google.com | 2009-06-03 20:07:06 +0200 (Wed, 03 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Port 2 more unit tests.  Just small differences between platforms.

This allows password_form_manager_unittest.cc and search_provider_unittest.cc
to run on linux/mac.

Review URL: http://codereview.chromium.org/118137

------------------------------------------------------------------------
r17489 | estade@chromium.org | 2009-06-03 19:23:36 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_manager.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_manager_gtk.h
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/chrome.gyp

Linux bookmark manager first cut.

Also add icons to bookmark tree model.

Review URL: http://codereview.chromium.org/118150
------------------------------------------------------------------------
r17485 | erg@google.com | 2009-06-03 18:56:38 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   D /trunk/src/chrome/browser/blocked_popup_container.cc
   D /trunk/src/chrome/browser/blocked_popup_container.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/constrained_files/constrained_window_onload_moveto.html

Revert "This is the first of probably several patches trying to clean up the BlockedPopupContainer
into something that can be cross-platform."
This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483).

Review URL: http://codereview.chromium.org/118166
------------------------------------------------------------------------
r17483 | erg@google.com | 2009-06-03 18:44:57 +0200 (Wed, 03 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/blocked_popup_container.cc
   A /trunk/src/chrome/browser/blocked_popup_container.h (from /trunk/src/chrome/browser/views/blocked_popup_container.h:17480)
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   D /trunk/src/chrome/test/data/constrained_files/constrained_window_onload_moveto.html

This is the first of probably several patches trying to clean up the BlockedPopupContainer into something that can be cross-platform.

- BlokedPopupContainers are no longer ConstrainedWindows.
- There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement.

Review URL: http://codereview.chromium.org/119006
------------------------------------------------------------------------
r17479 | phajdan.jr@chromium.org | 2009-06-03 17:01:29 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/base/clipboard.cc
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_mac.mm
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/condition_variable.h
   M /trunk/src/base/condition_variable_unittest.cc
   M /trunk/src/base/debug_util.h
   M /trunk/src/base/debug_util_win.cc
   M /trunk/src/base/field_trial.h
   M /trunk/src/base/file_version_info.cc
   M /trunk/src/base/file_version_info.h
   M /trunk/src/base/file_version_info_mac.mm
   M /trunk/src/base/idle_timer.h
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/perftimer.h
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/base/system_monitor.h
   M /trunk/src/base/tracked_objects.cc
   M /trunk/src/base/tracked_objects.h
   M /trunk/src/base/tracked_objects_unittest.cc
   M /trunk/src/base/waitable_event.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/media/base/mock_media_filters.h
   M /trunk/src/media/filters/video_thread.h
   M /trunk/src/net/disk_cache/disk_cache_test_util.h
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/views/controls/menu/chrome_menu.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Reduce header dependencies in base/

Also adds more explicit #includes for needed things.

Review URL: http://codereview.chromium.org/118162
------------------------------------------------------------------------
r17478 | erikkay@google.com | 2009-06-03 16:43:09 +0200 (Wed, 03 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Fix client coordinates when forwarding mouse events to RenderWidgetHostView parents.

A commit on behalf of tangjie: (already reviewed)
http://codereview.chromium.org/113671

BUG=http://code.google.com/p/chromium/issues/detail?id=11901
TEST=click anywhere in the extension bar and note whether this also gets counted as a click on the tab that's directly above it veritcally.

Review URL: http://codereview.chromium.org/119065
------------------------------------------------------------------------
r17475 | pinkerton@chromium.org | 2009-06-03 14:45:04 +0200 (Wed, 03 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Implemented a large chunk of the "user data" panel. Hooked the "under the hood" view into the window.
BUG=13151
TEST=enabled portions of the user data panel.
Review URL: http://codereview.chromium.org/119060
------------------------------------------------------------------------
r17473 | pfeldman@chromium.org | 2009-06-03 14:13:08 +0200 (Wed, 03 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/inspector_client_impl.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_delegate.h

Implement InspectorClient's Settings API.

This CL implements InspectorClient's API for reading / writing inspector settings. Here is how this is done: 

- inspector_client_impl.cc caches / serializes preferences into raw strings. It supports all kinds of settings except for string vector. I did not implement it since a) it requires more escaping b) I think we should get rid of it upstream. It then passes serialized settings string over IPC.
- There is a dedicated IPC message called UpdateInspectorSettings that takes care of settings update.

Two things I don't like: 
1) reading settings and writing settings follow different paths: WebPreferences interface for read, delegate -> IPC for write. WebPreferences on read is used since these settings are needed very early in the page cycle. delegate -> IPC on write is the only option.
2) this looks like too much code on the Chrome side for functionality like this. Is there a more generic way of settings and persisting WebKit's preferences in Chrome? Should there be one?

Review URL: http://codereview.chromium.org/119041
------------------------------------------------------------------------
r17472 | deanm@chromium.org | 2009-06-03 12:00:57 +0200 (Wed, 03 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

Implement the base for the BookmarkBubble UI.
Additionally set the transient on the InfoBubble dialog window.

BUG=11738

Review URL: http://codereview.chromium.org/119042

------------------------------------------------------------------------
r17471 | deanm@chromium.org | 2009-06-03 11:50:52 +0200 (Wed, 03 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   A /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc
   A /trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   D /trunk/src/chrome/browser/gtk/link_button_gtk.cc
   D /trunk/src/chrome/browser/gtk/link_button_gtk.h
   M /trunk/src/chrome/chrome.gyp

Make LinkButtonGtk into a real widget (GtkChromeLinkButton).

This means there are no longer two objects to keep around, the widget
and the wrapper C++ object.  This simplifies ownership in hierarchies.

Review URL: http://codereview.chromium.org/118116

------------------------------------------------------------------------
r17470 | phajdan.jr@chromium.org | 2009-06-03 11:39:44 +0200 (Wed, 03 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_constrained_window_tracker.h
   M /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/window_sizer_linux.cc

Headers cleanup in chrome/browser/

- reduce header dependencies
- miscellanous cleanups (add missing includes for OS_ defines etc)

Further changesets may follow. I was only looking at header files up to character_encoding.h.

Review URL: http://codereview.chromium.org/118072
------------------------------------------------------------------------
r17469 | ojan@chromium.org | 2009-06-03 10:58:48 +0200 (Wed, 03 Jun 2009) | 12 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc

Removes the following deprecated functions:
 file_util::InsertBeforeExtension(wstring*, wstring&)
 file_util::PathComponents(wstring&, vector<wstring>*)
 file_util::ReplaceExtension(wstring*, wstring&)

BUG=none
TEST=manual test for importing IE bookmarks with some sub-directories.

Original patch by tkent@google.com.
See http://codereview.chromium.org/118109
r=ojan,estade

------------------------------------------------------------------------
r17468 | sgk@chromium.org | 2009-06-03 08:21:25 +0200 (Wed, 03 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/locales/locales.gyp
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser/browser_tests_dll.vcproj
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/tools/build/win/language_dll.vsprops
   M /trunk/src/tools/grit/build/grit_localized_resources.rules
   M /trunk/src/tools/grit/build/grit_resources.rules
   M /trunk/src/tools/grit/build/using_generated_resources.vsprops

Revert last checkin to fix resources in Release builds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119075
------------------------------------------------------------------------
r17467 | sgk@chromium.org | 2009-06-03 07:41:00 +0200 (Wed, 03 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/locales/locales.gyp
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser/browser_tests_dll.vcproj
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/tools/build/win/language_dll.vsprops
   M /trunk/src/tools/grit/build/grit_localized_resources.rules
   M /trunk/src/tools/grit/build/grit_resources.rules
   M /trunk/src/tools/grit/build/using_generated_resources.vsprops

Convert to gyp generation of chrome_resources and chrome_strings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119061
------------------------------------------------------------------------
r17462 | mhm@chromium.org | 2009-06-03 04:16:32 +0200 (Wed, 03 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc

Local text file with spaces in filename is urlencoded in tab title

When viewing a local text file with spaces in filename, it is still urlencoded. Filename should be displayed with spaces, not with urlencoding. It would be more user-friendly.

Since net::FormatURL is already implemented, using it would be great. But it doesn't escape SPACES, just NORMAL, it doesn't even escape unicode. I plumbed out a unescapeurl that could be used whether we allow conversion of spaces or not.

BUG=8775 (http://crbug.com/8775)
TEST=Tested whether the input is escaped in the navigational context and ran the net tests

New Review: http://codereview.chromium.org/118059
Review URL: http://codereview.chromium.org/56053
------------------------------------------------------------------------
r17460 | agl@chromium.org | 2009-06-03 03:31:55 +0200 (Wed, 03 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h

Reenable DeleteURLAndFavicon test.

This test was disabled because it started failing, however it's
passing on the tryservers now so we'll give it another chance.

BUG=9600

------------------------------------------------------------------------
r17451 | jcampan@chromium.org | 2009-06-03 02:21:45 +0200 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Cancel pending changes when navigating away from the NTP.

BUG=12426
TEST=From the New Tab Page (NTP), click the Remove thumbnails link, remove thumbnails but don't press the Done button. Navigate to a URL (ex: www.google.com). Navigate to the NTP again, the thumbnails removed previously should still be showing. Also test that removal works properly when pressing the Done button.
Review URL: http://codereview.chromium.org/118119
------------------------------------------------------------------------
r17435 | brettw@chromium.org | 2009-06-03 00:12:06 +0200 (Wed, 03 Jun 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Support for searching bookmarks for IDN.

The main part of this change is DoesBookmarkContainWords() in
bookmark_utils.cc.  It tries to match a query words to IDN and
%-decoded strings as well as ASCII URL.

BUG=3991
TEST=add a unit test, check for IDN in the search box of Bookmark
Manager.
Checked in for tkent@google.com.
Original review: http://codereview.chromium.org/113815
------------------------------------------------------------------------
r17432 | pkasting@chromium.org | 2009-06-02 22:55:04 +0200 (Tue, 02 Jun 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Pasted links opened with alt-enter were opened next to the current tab instead of at the end of the strip.  This was because the LINK transition type triggered the TabStripModel to apply heuristics about where to open the URL, even though all URLs opened from the address bar should bypass these heuristics.  There were already hooks on the low-level functions to bypass the heuristics, I just had to expose them one level higher.  This meant an expansion to one of the TabContentsDelegate function's argument list, hence the number of files touched.  (This seems like a good capability to expose anyway, though.)BUG=6797TEST=Have multiple tabs in your tab strip.  Select the first tab, paste in a URL, and hit alt-enter.  The newly opened tab should appear at the far end of the strip.
Review URL: http://codereview.chromium.org/118038
------------------------------------------------------------------------
r17431 | glen@chromium.org | 2009-06-02 22:53:50 +0200 (Tue, 02 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/views/widget/default_theme_provider.cc
   M /trunk/src/views/widget/default_theme_provider.h

Allow themes to change the background of the new tab page. Adds support for display properties to themes (stored internally as ints/enums, but parsed from text).

BUG=12768
TEST=Install a theme with an new tab page background and verify that the background appears on the new tab page.

Review URL: http://codereview.chromium.org/115910
------------------------------------------------------------------------
r17429 | jeremy@chromium.org | 2009-06-02 22:36:00 +0200 (Tue, 02 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm

Display a tooltip when mousing over a tab title.

This allows a user to see the full page title.

Review URL: http://codereview.chromium.org/118095
------------------------------------------------------------------------
r17428 | brettw@chromium.org | 2009-06-02 22:32:01 +0200 (Tue, 02 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h

Fix the blue tab titles on GTK by hooking up the browser theme provider to the
browser frame.

Review URL: http://codereview.chromium.org/118088
------------------------------------------------------------------------
r17426 | tc@google.com | 2009-06-02 22:18:49 +0200 (Tue, 02 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Fix mac build.

TBR=erg

Review URL: http://codereview.chromium.org/114068

------------------------------------------------------------------------
r17424 | tc@google.com | 2009-06-02 22:08:12 +0200 (Tue, 02 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Port 2 more unittests to linux/mac.  Just some small compiler warnings.

This ports find_backend_unittest.cc and tab_strip_model_unittest.cc.

Review URL: http://codereview.chromium.org/119055

------------------------------------------------------------------------
r17423 | tc@google.com | 2009-06-02 22:05:44 +0200 (Tue, 02 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Allow left clicks in the tab strip to initiate a drag of the window.

Review URL: http://codereview.chromium.org/118127

------------------------------------------------------------------------
r17417 | rohitrao@chromium.org | 2009-06-02 20:51:59 +0200 (Tue, 02 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Adds mouseover images to the close tab button on Mac.

BUG=none
TEST=Mousing over the close button should change its image.
Review URL: http://codereview.chromium.org/113857
------------------------------------------------------------------------
r17415 | tc@google.com | 2009-06-02 20:47:33 +0200 (Tue, 02 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Add a context menu to the tab strip.  It appears when you click in the
tab strip background.

Review URL: http://codereview.chromium.org/119020

------------------------------------------------------------------------
r17408 | mpcomplete@google.com | 2009-06-02 20:39:55 +0200 (Tue, 02 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.cpp

Add some browser-level checks to prohibit access to extension bindings by
non-extension renderers.  Also add a check so that bindings are only exposed
if the top-level frame is the chrome-extension scheme.

BUG=11545
BUG=11993
TEST=none
Review URL: http://codereview.chromium.org/119014
------------------------------------------------------------------------
r17401 | sky@chromium.org | 2009-06-02 17:17:16 +0200 (Tue, 02 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h

Fixes a couple of bugs encountered in getting info bubbles to work:

. Initial bounds of windows weren't being set.
. Widgets were created initially shown. This was bad for windows as
  the window would end up showing prematurely.
. WindowGtk::window_state_ wasn't being initialized.
. And then actual InfoBubble stuff: properly init the bubble, show it
  and position it on the monitor.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/118102
------------------------------------------------------------------------
r17396 | bradnelson@chromium.org | 2009-06-02 10:15:48 +0200 (Tue, 02 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vsprops

Taking out redundant include dir, this should be handled by
using_google_update.vsprops.

BUG=None
TEST=None
TBR=sgk

Review URL: http://codereview.chromium.org/118108
------------------------------------------------------------------------
r17390 | jcampan@chromium.org | 2009-06-02 08:45:32 +0200 (Tue, 02 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc

Disabling a UI test that is flacky.
Note that these tests are going away soon when the browser tests become first class citizen.

BUG=6584
TEST=None
TBR=rafaelw
Review URL: http://codereview.chromium.org/119018
------------------------------------------------------------------------
r17387 | jcampan@chromium.org | 2009-06-02 08:09:27 +0200 (Tue, 02 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Makes the text of the in-progress download dialog better by special-casing the single download case.

BUG=11278
TEST=Start a big download, close Chrome. A dialog warning that a download is in progress should be shown. Check that the main text and button text use singular when referring to the download. Start several big downloads. Close Chrome, check the text now uses plural.
Review URL: http://codereview.chromium.org/119009
------------------------------------------------------------------------
r17384 | bradnelson@chromium.org | 2009-06-02 07:36:15 +0200 (Tue, 02 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vsprops

Adding missing include path now needed to find google_update generated header.
A little odd it wasn't needed before. Something generated probably got dragged
in.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/118103
------------------------------------------------------------------------
r17382 | ben@chromium.org | 2009-06-02 06:47:36 +0200 (Tue, 02 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   D /trunk/src/views/controls/combo_box.cc
   D /trunk/src/views/controls/combo_box.h
   A /trunk/src/views/controls/combobox
   A /trunk/src/views/controls/combobox/combobox.cc
   A /trunk/src/views/controls/combobox/combobox.h
   A /trunk/src/views/controls/combobox/native_combobox_gtk.cc
   A /trunk/src/views/controls/combobox/native_combobox_gtk.h
   A /trunk/src/views/controls/combobox/native_combobox_win.cc
   A /trunk/src/views/controls/combobox/native_combobox_win.h
   A /trunk/src/views/controls/combobox/native_combobox_wrapper.h
   M /trunk/src/views/controls/native/native_view_host_win.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/native_control_win.h
   M /trunk/src/views/views.gyp

Make Combobox portable
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113991
------------------------------------------------------------------------
r17378 | glen@chromium.org | 2009-06-02 05:04:51 +0200 (Tue, 02 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/app/resources/app_top_left.png
   M /trunk/src/app/resources/app_top_right.png
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Fix opaque app mode display.

Changed the app corner images to be the same size as the center image.

BUG=12541
TEST=In an opaque app-frame window, verify that the top edge doesn't have a frame-colored space between the drop shadow and the content area.

Review URL: http://codereview.chromium.org/118058
------------------------------------------------------------------------
r17376 | mal@chromium.org | 2009-06-02 03:07:52 +0200 (Tue, 02 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Correct the ffpmeg license disclosure:
  1. The correct license is version 2_.1_ of the LGPL
  2. The address is incorrect for the FSF.
     I also corrected the address for the pthreads disclosure.

BUG=http://crbug.com/13147
Review URL: http://codereview.chromium.org/118099
------------------------------------------------------------------------
r17374 | estade@chromium.org | 2009-06-02 02:50:39 +0200 (Tue, 02 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Make bookmark bar more amenable to dark themes.

- Explicitly set button text color.
- Set background of drag widget.

BUG=none
TEST=use a dark system theme, make sure everything looks reasonable.

Review URL: http://codereview.chromium.org/118097
------------------------------------------------------------------------
r17373 | glen@chromium.org | 2009-06-02 02:49:27 +0200 (Tue, 02 Jun 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc

The extensions service wasn't getting inited despite being used by themes (this manifested itself as theme reinstall failing, because CheckCurrentVersion found the directory, but ExtensionService::extensions_ was empty).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115974
------------------------------------------------------------------------
r17372 | thestig@google.com | 2009-06-02 02:35:47 +0200 (Tue, 02 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/browser/google_update_settings_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc

Generate GUIDs for users who wish to upload crash reports. Include it in crash reports.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118096
------------------------------------------------------------------------
r17366 | estade@chromium.org | 2009-06-02 00:54:16 +0200 (Tue, 02 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

Linux: Fix appearance of dangerous download dialog.

Don't give dangerous download dialog its own GdkWindow. We need the window to be transparent, which only works with compositing window managers, so instead of going through that hassle just don't give it a window. Let the text field adjust in size during animation.

BUG=none
TEST=download an .exe with a dark system theme. The dialog shouldn't have a dark frame around it.
Review URL: http://codereview.chromium.org/118092
------------------------------------------------------------------------
r17363 | ben@chromium.org | 2009-06-02 00:26:59 +0200 (Tue, 02 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Flip omnibox2 popup on by default for more testing.

Review URL: http://codereview.chromium.org/115980
------------------------------------------------------------------------
r17360 | cpu@google.com | 2009-06-02 00:17:54 +0200 (Tue, 02 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc

Coverity underground warfare: check return code
- Check return code consistently
- NOTREACHED() added in one case
- CID 4169

BUG = none
TEST = none

Review URL: http://codereview.chromium.org/118042
------------------------------------------------------------------------
r17359 | munjal@chromium.org | 2009-06-02 00:13:08 +0200 (Tue, 02 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc

Cleanup temp files/folders in a few more tests.

Review URL: http://codereview.chromium.org/118074
------------------------------------------------------------------------
r17356 | estade@chromium.org | 2009-06-01 23:38:11 +0200 (Mon, 01 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

GTK: respect control key for setting TLD=com.

BUG=13096
Review URL: http://codereview.chromium.org/118086
------------------------------------------------------------------------
r17353 | xji@chromium.org | 2009-06-01 23:19:30 +0200 (Mon, 01 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h

This CL fixes issue 10827 -- Hebrew: pop-up menu positioned to right of mouse-click in content area

context menu should be positioned using the mouse-click point as top right point in RTL locales.

BUG=http://crbug.com/10827
TEST=Open Hebrew Chrome, Right-click on the content area, on a link, or on an image, The pop-up menu should be positioned to the left of the mouse-click.
Review URL: http://codereview.chromium.org/118043
------------------------------------------------------------------------
r17352 | evan@chromium.org | 2009-06-01 23:15:32 +0200 (Mon, 01 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run_gtk.cc

linux: first run text update.

Review URL: http://codereview.chromium.org/118076
------------------------------------------------------------------------
r17351 | sky@chromium.org | 2009-06-01 23:10:40 +0200 (Mon, 01 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fixes bug where can't see contents of autocomplete edit. This was
happening because all widgets are initially hidden. NativeViewHostGtk
only shows the widget, not descendants.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/118081
------------------------------------------------------------------------
r17349 | sky@chromium.org | 2009-06-01 23:10:22 +0200 (Mon, 01 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/views/controls/native/native_view_host_gtk.cc

Fixes a couple of related bugs:

. gdk_display_get_pointer requires a display.
. Don't do anything in NativeViewHostGtk if asked to remove and there
  is no native view.
. Make NativeViewHostGtk deal with the native view already having the
  same parent.
. Implement a couple of methods in NativeTabContentsContainerGtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115989
------------------------------------------------------------------------
r17344 | cpu@google.com | 2009-06-01 21:43:53 +0200 (Mon, 01 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Coverity underground warfare: check return code
- Check return code consistently
- CID 4171

BUG = none
TEST = non


Review URL: http://codereview.chromium.org/118041
------------------------------------------------------------------------
r17339 | estade@chromium.org | 2009-06-01 20:46:37 +0200 (Mon, 01 Jun 2009) | 8 lines
Changed paths:
   M /trunk/src/app/slide_animation.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Make the bookmark bar closing animation less janky.

(Forgot to do this when adding the animation.)

BUG=none
TEST=Close the bookmark bar on a page with a dark background/complex elements. There should be very little annoying white stuff at the bottom.

Review URL: http://codereview.chromium.org/118066
------------------------------------------------------------------------
r17338 | jar@chromium.org | 2009-06-01 20:31:36 +0200 (Mon, 01 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc

Test impact of 4 rather than 8 parallel DNS prefetch

BUG=6532
r=wtc
Review URL: http://codereview.chromium.org/115990
------------------------------------------------------------------------
r17336 | jcampan@chromium.org | 2009-06-01 20:24:41 +0200 (Mon, 01 Jun 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/ui/ui_test.cc

Some UI tests would fail on some boxes as these tests have specific expectations in term of how many and what kind of info-bars are showing, and the default browser check would add an extra info-bar.
This CL adds a switch that disables the default browser check on start-up and makes the UI tests specify that switch.

BUG=13064
TEST=Run the UI tests.

Review URL: http://codereview.chromium.org/112081
------------------------------------------------------------------------
r17335 | tc@google.com | 2009-06-01 20:19:23 +0200 (Mon, 01 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/webkit/glue/webframe_impl.cc

Have the find bar show number of matches on linux.

We needed to enable some code in webkit/glue/webframe_impl.cc and
add a line to clear the results in find_bar_gtk.cc.

BUG=12955

Review URL: http://codereview.chromium.org/115960

------------------------------------------------------------------------
r17334 | estade@chromium.org | 2009-06-01 20:17:29 +0200 (Mon, 01 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Linux: ctrl+scroll for zoom

BUG=12962

Review URL: http://codereview.chromium.org/118044
------------------------------------------------------------------------
r17332 | robertshield@google.com | 2009-06-01 20:11:39 +0200 (Mon, 01 Jun 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Rollin' back 17315. Looks to be breaking OpenPopupWindowWithPlugin in the UI Test on the builder.

TBR=jhawkins

Review URL: http://codereview.chromium.org/115997
------------------------------------------------------------------------
r17321 | mal@chromium.org | 2009-06-01 18:49:54 +0200 (Mon, 01 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Add ffmpeg to about:terms.

BUG=http://crbug.com/12839
Review URL: http://codereview.chromium.org/113986
------------------------------------------------------------------------
r17319 | deanm@chromium.org | 2009-06-01 18:30:52 +0200 (Mon, 01 Jun 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Linux Omnibox, handle OnInputInProgress to clear the security style.

BUG=10965
TEST=Go to an https:// page, the location bar should be yellow.
     Type something, the background should change to white.
     Hit escape to revert the text, background should be yellow again.

Review URL: http://codereview.chromium.org/113995

------------------------------------------------------------------------
r17318 | deanm@chromium.org | 2009-06-01 18:18:13 +0200 (Mon, 01 Jun 2009) | 13 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc

Scale backing store cache size.

The approach is borrowed from render_process_host's kMaxRenderersByRamTier.

The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.

Patch by Joel Stanley.

BUG=12028

Review URL: http://codereview.chromium.org/115452

------------------------------------------------------------------------
r17315 | robertshield@google.com | 2009-06-01 17:58:14 +0200 (Mon, 01 Jun 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Re-apply 17223 (http://codereview.chromium.org/115943) to fix external tab handling of certain open dispositions.

Review URL: http://codereview.chromium.org/118030
------------------------------------------------------------------------
r17305 | aa@chromium.org | 2009-06-01 04:53:00 +0200 (Mon, 01 Jun 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   D /trunk/src/chrome/common/unzip.cc
   D /trunk/src/chrome/common/unzip.h
   D /trunk/src/chrome/common/unzip_unittest.cc
   A /trunk/src/chrome/common/zip.cc (from /trunk/src/chrome/common/unzip.cc:17304)
   A /trunk/src/chrome/common/zip.h
   A /trunk/src/chrome/common/zip_unittest.cc (from /trunk/src/chrome/common/unzip_unittest.cc:17304)
   D /trunk/src/chrome/test/data/unzip/test/foo/bar/baz.txt
   D /trunk/src/chrome/test/data/unzip/test/foo/bar/quux.txt
   D /trunk/src/chrome/test/data/unzip/test/foo/bar.txt
   D /trunk/src/chrome/test/data/unzip/test/foo.txt
   D /trunk/src/chrome/test/data/unzip/test.zip
   D /trunk/src/chrome/test/data/unzip/test_nocompress.zip
   A /trunk/src/chrome/test/data/zip
   A /trunk/src/chrome/test/data/zip/test
   A /trunk/src/chrome/test/data/zip/test/foo
   A /trunk/src/chrome/test/data/zip/test/foo/bar
   A /trunk/src/chrome/test/data/zip/test/foo/bar/baz.txt (from /trunk/src/chrome/test/data/unzip/test/foo/bar/baz.txt:17304)
   A /trunk/src/chrome/test/data/zip/test/foo/bar/quux.txt (from /trunk/src/chrome/test/data/unzip/test/foo/bar/quux.txt:17304)
   A /trunk/src/chrome/test/data/zip/test/foo/bar.txt (from /trunk/src/chrome/test/data/unzip/test/foo/bar.txt:17304)
   A /trunk/src/chrome/test/data/zip/test/foo.txt (from /trunk/src/chrome/test/data/unzip/test/foo.txt:17304)
   A /trunk/src/chrome/test/data/zip/test.zip
   A /trunk/src/chrome/test/data/zip/test_nocompress.zip (from /trunk/src/chrome/test/data/unzip/test_nocompress.zip:17304)
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/sandbox/tools/launcher/launcher.vcproj
   M /trunk/src/third_party/zlib/zlib.gyp

Implements a Zip() utility function. Refactor existing
Unzip-relatedness into shared locations.

Review URL: http://codereview.chromium.org/118028
------------------------------------------------------------------------
r17304 | ben@chromium.org | 2009-05-31 21:09:01 +0200 (Sun, 31 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Fix crash in omnibox2 popup introduced by themes work. There was no widget to obtain a theme provider from in this case.

TBR=glen
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118064
------------------------------------------------------------------------
r17302 | glen@chromium.org | 2009-05-31 09:39:53 +0200 (Sun, 31 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Now that themes are enabled by default, the option should be visible by default.

BUG=none
TEST=Verify that you can see the option to reset your theme in the second tab of the options dialog.

Review URL: http://codereview.chromium.org/112079
------------------------------------------------------------------------
r17301 | glen@chromium.org | 2009-05-31 09:39:29 +0200 (Sun, 31 May 2009) | 6 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/views/widget/default_theme_provider.cc
   M /trunk/src/views/widget/default_theme_provider.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Use the right frame type on startup, do proper swapping of frames when themes change. Leave the native frame decision up to the ThemeProvider.

BUG=12890
TEST=In Aero, unstall a theme, reset to default, install again, restart, reset theme to default. Make sure that the Aero frame changes to the themed frame and back again appropriately.

Review URL: http://codereview.chromium.org/118053
------------------------------------------------------------------------
r17299 | thakis@chromium.org | 2009-05-31 06:28:18 +0200 (Sun, 31 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Address post-lgtm comment from Evan. No functionality change.

BUG=none
TEST=none
TBR=evanm

Review URL: http://codereview.chromium.org/118054

Review URL: http://codereview.chromium.org/118054
------------------------------------------------------------------------
r17298 | thakis@chromium.org | 2009-05-31 06:08:35 +0200 (Sun, 31 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Don't crash on find on OS X and Linux. Bug introduced by r17285.

BUG=none
TEST=Hit ctrl-f in Linux or OS X and check that chrome doesn't crash.

Review URL: http://codereview.chromium.org/115979
------------------------------------------------------------------------
r17297 | thakis@chromium.org | 2009-05-31 05:46:48 +0200 (Sun, 31 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc

Linux and Mac support chrome://history by now. Remove NOTIMPLEMENTED.

Review url: http://codereview.chromium.org/115976

BUG=none
TEST=On Linux, open google.com, then wikipedia.com in the same tab. Then click
and hold on back button, select "Show Full History" in the appearing popup, and
make sure a tab with the history opens.

------------------------------------------------------------------------
r17296 | brettw@chromium.org | 2009-05-31 04:45:14 +0200 (Sun, 31 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc

Fix the Windows build by adding necessary headers.
Review URL: http://codereview.chromium.org/115975
------------------------------------------------------------------------
r17295 | brettw@chromium.org | 2009-05-31 04:36:23 +0200 (Sun, 31 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/native_button_wrapper.h
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/table/group_table_view.h
   A /trunk/src/views/controls/table/table_model.cc
   A /trunk/src/views/controls/table/table_model.h
   A /trunk/src/views/controls/table/table_model_observer.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   A /trunk/src/views/controls/table/table_view_observer.h
   M /trunk/src/views/controls/table/table_view_unittest.cc
   M /trunk/src/views/views.gyp

Split out the views table functions into separate header files. Many users only
need either the view or model observers and that's it.

I moved the model constructors to a .cc file so we don't have to include
l10n_util.h for everybody. A surprising number of files were getting l10n_util
from the table code, so I had to add it in a bunch of places.

There should be no code change except I made the table column cosntructors take
wstring references instead of copies.
Review URL: http://codereview.chromium.org/115969
------------------------------------------------------------------------
r17294 | mhm@chromium.org | 2009-05-31 00:53:23 +0200 (Sun, 31 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Add a "User Data" tab to the options, remove the "minor tweaks" tab

Add new option fields to the "User Data" tab and reorganize the "Under the Hood"
to fit a better User Experience.

RELANDING http://codereview.chromium.org/113896

TBR=ben
Review URL: http://codereview.chromium.org/115971
------------------------------------------------------------------------
r17289 | mhm@chromium.org | 2009-05-30 18:22:00 +0200 (Sat, 30 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Revert 17288 - Test failures.

TBR=ben
Review URL: http://codereview.chromium.org/115968
------------------------------------------------------------------------
r17288 | mhm@chromium.org | 2009-05-30 17:21:42 +0200 (Sat, 30 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h

Create a "User data" tab and remove the "minor tweaks" tab. The mockup is included in the issue. 

Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience.

BUG=11435 (http://crbug.com/11435)
TEST=Opened the option dialog and checked if functional.

Review URL: http://codereview.chromium.org/113896
------------------------------------------------------------------------
r17286 | ben@chromium.org | 2009-05-30 11:17:52 +0200 (Sat, 30 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc

Fix bustage by fixing defines not to include windows.

------------------------------------------------------------------------
r17285 | ben@chromium.org | 2009-05-30 10:27:29 +0200 (Sat, 30 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc

Fixes to make a browser window come up with TOOLKIT_VIEWS.

TBR=sky
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17271
Review URL: http://codereview.chromium.org/116007
------------------------------------------------------------------------
r17284 | mhm@chromium.org | 2009-05-30 07:40:05 +0200 (Sat, 30 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Fix linux compilation for print

Review URL: http://codereview.chromium.org/115966
------------------------------------------------------------------------
r17283 | mhm@chromium.org | 2009-05-30 07:26:24 +0200 (Sat, 30 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add --print command line argument to print a webpage

Added a new chrome switch called "print" and after the urls are being loaded, I call the last active browser and print the selected tab.

BUG=6942 (http://crbug.com/6942)
TEST=Added command line arguments [chrome.exe --print http://google.ca and the print dialog appeared for the selected tab component.

based on: http://codereview.chromium.org/100027
Review URL: http://codereview.chromium.org/118048
------------------------------------------------------------------------
r17282 | abarth@chromium.org | 2009-05-30 07:25:17 +0200 (Sat, 30 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/renderer/render_view.cc

Enforce a max length for document titles.

R=deanm
BUG=http://crbug.com/12810
TEST=None

Review URL: http://codereview.chromium.org/113969
------------------------------------------------------------------------
r17280 | mhm@chromium.org | 2009-05-30 06:48:50 +0200 (Sat, 30 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj

Fix project file for reverting 17273

Review URL: http://codereview.chromium.org/115965
------------------------------------------------------------------------
r17279 | mhm@chromium.org | 2009-05-30 06:34:00 +0200 (Sat, 30 May 2009) | 2 lines
Changed paths:
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Reverting 17273 - Fails reliability tests
Review URL: http://codereview.chromium.org/118047
------------------------------------------------------------------------
r17277 | evan@chromium.org | 2009-05-30 04:09:06 +0200 (Sat, 30 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/window_sizer.cc

linux: save window positions.

I followed the Windows code rather than the Mac code, and saved whenever
the window is moved.

Note that we only restore window *size*, not position.  We looked at every software we could find and none restored position.

BUG=12374

Review URL: http://codereview.chromium.org/115932
------------------------------------------------------------------------
r17276 | cpu@google.com | 2009-05-30 03:51:52 +0200 (Sat, 30 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc

Coverity underground warfare: Uninitalized member
- Fix ctor to init members
- CID 4186

BUG = none
TEST = well, it is a unit test

Review URL: http://codereview.chromium.org/112076
------------------------------------------------------------------------
r17275 | cpu@google.com | 2009-05-30 03:47:08 +0200 (Sat, 30 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Coverity underground warfare: Uninitalized member
- Fix ctor to init members
- CID 4187

BUG = none
TEST = none

Review URL: http://codereview.chromium.org/118035
------------------------------------------------------------------------
r17274 | ben@chromium.org | 2009-05-30 03:11:15 +0200 (Sat, 30 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc

Reverting 17271.
Review URL: http://codereview.chromium.org/118040
------------------------------------------------------------------------
r17273 | stuartmorgan@chromium.org | 2009-05-30 02:51:16 +0200 (Sat, 30 May 2009) | 5 lines
Changed paths:
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   A /trunk/src/chrome/browser/password_manager/password_store.cc
   A /trunk/src/chrome/browser/password_manager/password_store.h
   A /trunk/src/chrome/browser/password_manager/password_store_default.cc
   A /trunk/src/chrome/browser/password_manager/password_store_default.h
   A /trunk/src/chrome/browser/password_manager/password_store_gnome.cc
   A /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   A /trunk/src/chrome/browser/password_manager/password_store_kwallet.cc
   A /trunk/src/chrome/browser/password_manager/password_store_kwallet.h
   A /trunk/src/chrome/browser/password_manager/password_store_win.cc
   A /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Re-land the password store work from bug 8205, with changes that should fix bug 12479. The Linux pieces are still disabled, however.

BUG=8205
TEST=Password autofill should continue to work on Windows.
Review URL: http://codereview.chromium.org/114057
------------------------------------------------------------------------
r17271 | ben@chromium.org | 2009-05-30 02:38:38 +0200 (Sat, 30 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc

Fixes to make a browser window come up with TOOLKIT_VIEWS.

TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/116007
------------------------------------------------------------------------
r17270 | sidchat@google.com | 2009-05-30 02:35:33 +0200 (Sat, 30 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc

Revert Changes to stop tests breaking.

TBR=brettw
Review URL: http://codereview.chromium.org/112077
------------------------------------------------------------------------
r17268 | sidchat@google.com | 2009-05-30 02:09:00 +0200 (Sat, 30 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Possible fix for UnitTestFailure

TBR=brettw
Review URL: http://codereview.chromium.org/115962
------------------------------------------------------------------------
r17263 | xji@chromium.org | 2009-05-30 01:36:24 +0200 (Sat, 30 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc

This CL fixes issue 6223 - Drag and drop a new tab from RTL Chrome: the docked window usually showing out of current screen

The problem is that the dragged tab view is not rendered correctly in RTL locale. The view should be rendered in a position that the mouse is on tabstrip, which is consistent with the position in which the view will be docked when mouse release.

The root cause is the dragged tab view's width is calculated incorrectly in RTL locale.

BUG=http://crbug.com/6223
TEST=Open Chrome in Hebrew, drag and drop a tab, observe the tab view while dragging, the view should be rendered in a position that the mouse is on tabstrip.
Review URL: http://codereview.chromium.org/115938
------------------------------------------------------------------------
r17262 | mirandac@chromium.org | 2009-05-30 01:32:21 +0200 (Sat, 30 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Changed the status bar size to adapt to the size of the font,
instead of being a const.

BUG= http://crbug.com/1275
TEST=Set Windows XP font size to large or extra-large.  Open Chrome.
Hover over a link to bring up the status bubble.  Text should sit
comfortably in bubble, without being squeezed.

Review URL: http://codereview.chromium.org/113490
------------------------------------------------------------------------
r17260 | jcampan@chromium.org | 2009-05-30 01:26:40 +0200 (Sat, 30 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h

The ShelfItemDialog has an accelerator for Enter.
Since it also had a default button (that would also register an accelerator for Enter), there would be an assertion failure when unregistering the first accelerator.
Also removed the Esc accelerator (it is already handled by the dialog by default).

BUG=12922
TEST=Repro the scenario described in bug.

Review URL: http://codereview.chromium.org/115956
------------------------------------------------------------------------
r17259 | sidchat@google.com | 2009-05-30 01:20:35 +0200 (Sat, 30 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc

Do not autocorrect words in capital letters, or having capital letters in between, as they may refer to acronyms or terms not in the dictionary.

BUG = www.crbug.com/12921
TEST = Type CLD (a library), should not change back to LCD
Review URL: http://codereview.chromium.org/118008
------------------------------------------------------------------------
r17257 | glen@chromium.org | 2009-05-30 00:58:41 +0200 (Sat, 30 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc

Really theme the find bar. We were previously getting the DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider')

BUG=11702
TEST=Install a theme and verify that the find bar matches it.
TBR=finnur

Review URL: http://codereview.chromium.org/115729


------------------------------------------------------------------------
r17256 | brettw@chromium.org | 2009-05-30 00:54:17 +0200 (Sat, 30 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/thumbnail_store.h

Fix some review comments I missed in the previous checkin of this file.

Previous review: http://codereview.chromium.org/113909/diff/16/17
Patch my Meelap Shah
------------------------------------------------------------------------
r17255 | sky@chromium.org | 2009-05-30 00:51:09 +0200 (Sat, 30 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   A /trunk/src/chrome/browser/views/tabs/native_view_photobooth_gtk.cc
   A /trunk/src/chrome/browser/views/tabs/native_view_photobooth_gtk.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/native/native_view_host_gtk.cc

More views on gtk work: NativeViewPhotoboothGtk, adds a missing method
to NativeViewHostGtk and location bar view colors.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115958
------------------------------------------------------------------------
r17254 | estade@chromium.org | 2009-05-30 00:50:47 +0200 (Sat, 30 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h

When copying urls in the render view context menu, copy them to PRIMARY as well as CLIPBOARD.

BUG=12716

Review URL: http://codereview.chromium.org/115949
------------------------------------------------------------------------
r17246 | sky@chromium.org | 2009-05-29 23:53:27 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   A /trunk/src/chrome/browser/views/browser_bubble_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/window_sizer_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/native/native_view_host_gtk.cc

Fixes a slew of random link/compile errors for views on gtk.

BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/115948
------------------------------------------------------------------------
r17245 | glen@chromium.org | 2009-05-29 23:36:27 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc

Revert Revision 17224

BUG=none
TEST=non

Review URL: http://codereview.chromium.org/115951
------------------------------------------------------------------------
r17241 | pkasting@chromium.org | 2009-05-29 23:22:03 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Revert the Omnibox when changing tabs while its contents have been deleted.

To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller.

BUG=6850
Review URL: http://codereview.chromium.org/113983
------------------------------------------------------------------------
r17240 | glen@chromium.org | 2009-05-29 23:19:54 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/extensions/extension.cc
   M /trunk/src/chrome/common/extensions/extension.h

Allow themes to be installed without any commandline flag, still require flag for Extensions. Expand themes unittests.

BUG=12205,12231
TEST=Without any flags, try installing an extension and a theme. The extension should fail and the theme should succeed. Attempts to install a theme with extension components in the manifest should similarly result in failure.

Review URL: http://codereview.chromium.org/115798
------------------------------------------------------------------------
r17239 | robertshield@google.com | 2009-05-29 23:10:37 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Reverting 17223 (http://codereview.chromium.org/115943). Seems to make interactive UI tests unhappy.

TBR=tommi

Review URL: http://codereview.chromium.org/118029
------------------------------------------------------------------------
r17238 | munjal@chromium.org | 2009-05-29 23:08:14 +0200 (Fri, 29 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/file_test_utils.cc
   A /trunk/src/chrome/test/file_test_utils.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Clean-up temporary files/folders in firefox importer tests.

Review URL: http://codereview.chromium.org/115930
------------------------------------------------------------------------
r17233 | pkasting@chromium.org | 2009-05-29 22:47:50 +0200 (Fri, 29 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

Be less aggressive about resizing Chrome windows when restoring them.  Original patch by Yuzo Fujishima (see http://codereview.chromium.org/115180 ), r=me.

BUG=9587
------------------------------------------------------------------------
r17231 | pkasting@chromium.org | 2009-05-29 22:47:25 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc

Ignore the insert key so we don't switch into overtype mode (which surprises users since there's no indicator of it).

BUG=6856
TEST=In Omnibox or in a native textfield (e.g. the "Add a site" URL field for the Options dialog's "Open these sites at startup" pref), type text, set cursor at beginning, hit insert, and type.  Your text should prepend to the existing text instead of replacing it.
Review URL: http://codereview.chromium.org/115934
------------------------------------------------------------------------
r17228 | estade@chromium.org | 2009-05-29 22:42:16 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Properly display mnemonics in some gtk menus where they were not being escaped and showed up as &.

Get rid of manual escaping in bookmark context menu gtk.

BUG=12868
Review URL: http://codereview.chromium.org/118024
------------------------------------------------------------------------
r17227 | hclam@chromium.org | 2009-05-29 22:38:11 +0200 (Fri, 29 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   D /trunk/src/chrome/browser/renderer_host/media_resource_handler.cc
   D /trunk/src/chrome/browser/renderer_host/media_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/net/base/cache_type.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/disk_cache/backend_unittest.cc
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/disk_cache/entry_impl.cc
   M /trunk/src/net/disk_cache/entry_impl.h
   M /trunk/src/net/disk_cache/entry_unittest.cc
   M /trunk/src/net/disk_cache/histogram_macros.h
   M /trunk/src/net/disk_cache/mem_entry_impl.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_response_info.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h

Remove code path that passes a file handle to the renderer
Since the code now does range request without any caching
the code path for passing file handle is not used any more.

Changes:
1. Remove response_data_file in webkit_glue::ResourceResponseHead
2. Remove response_data_file in net::ResourceInfo
3. Remove code that passes file handle using IPC
4. Remove code that passes file hadnle from network layer to ResourceDispatcherHost
5. Remove MediaResourceHandler
6. Remove code in disk_cache that expose the file handle
7. Remove ChromeURLRequestContext::CreateOffTheRecordForMedia() so no more OTR request context for media, in OTR mode simply memory cache is used
8. Reset cache size for media cache to default

BUG=12249
BUG=12256

Review URL: http://codereview.chromium.org/113931
------------------------------------------------------------------------
r17224 | glen@chromium.org | 2009-05-29 22:33:49 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc

Really theme the find bar. We were previously getting the DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider')

BUG=11702
TEST=Install a theme and verify that the find bar matches it.

Review URL: http://codereview.chromium.org/115729
------------------------------------------------------------------------
r17223 | robertshield@google.com | 2009-05-29 22:33:11 +0200 (Fri, 29 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Avoid DCHECKING on NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in ExternalTabContainer by re-routing those dispositions to new popups.


Review URL: http://codereview.chromium.org/115943
------------------------------------------------------------------------
r17222 | mpcomplete@google.com | 2009-05-29 22:28:09 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix a browser crash that occurs if the extension unpacker process crashes
after it sends a response to the browser.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113867
------------------------------------------------------------------------
r17221 | sky@chromium.org | 2009-05-29 22:27:16 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/back_forward_menu_model_views.cc (from /trunk/src/chrome/browser/back_forward_menu_model_win.cc:17077)
   A /trunk/src/chrome/browser/back_forward_menu_model_views.h (from /trunk/src/chrome/browser/back_forward_menu_model_win.h:17077)
   D /trunk/src/chrome/browser/back_forward_menu_model_win.cc
   D /trunk/src/chrome/browser/back_forward_menu_model_win.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp

Renames BackForwardMenuModelWin to BackForwardMenuModelViews.

BUG=NONE
TEST=none

Review URL: http://codereview.chromium.org/118001
------------------------------------------------------------------------
r17218 | estade@chromium.org | 2009-05-29 22:24:46 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Linux: show tab context menu on mousedown rather than mouse up.

TEST=right click on a tab and see a context menu popup (i.e. no regression). Also, right click, hold, drag, release to select an item.

Review URL: http://codereview.chromium.org/118023
------------------------------------------------------------------------
r17217 | estade@chromium.org | 2009-05-29 22:24:23 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Put findbar close button back where it belongs.

TBR=deanm

Review URL: http://codereview.chromium.org/115935
------------------------------------------------------------------------
r17216 | estade@chromium.org | 2009-05-29 22:24:02 +0200 (Fri, 29 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

linux: Bookmark bar slide animation.

also improve the look of the instructions label.
Review URL: http://codereview.chromium.org/112070
------------------------------------------------------------------------
r17210 | sky@chromium.org | 2009-05-29 22:13:24 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/chrome.gyp

Gets TabIconView compiling on linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115905
------------------------------------------------------------------------
r17209 | sky@chromium.org | 2009-05-29 22:12:26 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc

Stub out a couple of methods in BookmarkDragData.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/112069
------------------------------------------------------------------------
r17207 | mirandac@chromium.org | 2009-05-29 22:06:41 +0200 (Fri, 29 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc

Ensure that Firefox search engines are imported correctly.
It also makes sure that engines which have been removed from Firefox
are not imported into Chrome.

BUG= http://crbug.com/12245
TEST= Install firefox, and do not change the default search engines.
Start Chrome, and import search engines from Firefox.  Default Firefox
engines should now be part of Chrome.


Review URL: http://codereview.chromium.org/115895
------------------------------------------------------------------------
r17195 | maruel@chromium.org | 2009-05-29 18:38:46 +0200 (Fri, 29 May 2009) | 2 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc

Reverting 17183 since it caused linux unit_test breakage.
Review URL: http://codereview.chromium.org/115929
------------------------------------------------------------------------
r17194 | brettw@chromium.org | 2009-05-29 18:37:04 +0200 (Fri, 29 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable the failing UI test. I filed a P1 bug on it.
Review URL: http://codereview.chromium.org/114063
------------------------------------------------------------------------
r17187 | pinkerton@chromium.org | 2009-05-29 16:40:00 +0200 (Fri, 29 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Fix namespace to ultimately compile on Mac
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115924
------------------------------------------------------------------------
r17186 | pinkerton@chromium.org | 2009-05-29 16:30:38 +0200 (Fri, 29 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/ClearBrowsingData.xib
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.h
   A /trunk/src/chrome/browser/cocoa/clear_browsing_data_controller.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view.h
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm
   M /trunk/src/chrome/chrome.gyp

Implement Clear Browser Data for Mac as an app modal dialog. Uses the profile of the given window or the default profile if run with no windows open. Add a setter to the throbber so it can be used in a nib file.
BUG=none
TEST=clear browser functionality (note that clearing passwords doesn't work) and checkbox persistance.
Review URL: http://codereview.chromium.org/112065
------------------------------------------------------------------------
r17183 | deanm@chromium.org | 2009-05-29 16:05:32 +0200 (Fri, 29 May 2009) | 13 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc

Scale backing store cache size.

The approach is borrowed from render_process_host's kMaxRenderersByRamTier.

The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.

Patch by Joel Stanley.

BUG=12028

Review URL: http://codereview.chromium.org/115452

------------------------------------------------------------------------
r17178 | phajdan.jr@chromium.org | 2009-05-29 11:43:26 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/dns_resolution_observer.h
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   M /trunk/src/net/base/listen_socket.h
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/sdch_filter.h
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/base/socket.h
   M /trunk/src/net/base/socket_test_util.cc
   M /trunk/src/net/base/ssl_client_socket_mac.cc
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_client_socket_win.cc
   M /trunk/src/net/base/ssl_info.h
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/tcp_client_socket_unittest.cc
   M /trunk/src/net/base/tcp_client_socket_win.cc
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/base/upload_data_stream.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_filter.h
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_job_manager.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.cc
   M /trunk/src/net/url_request/url_request_new_ftp_job.h
   M /trunk/src/net/url_request/url_request_simple_job.cc
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_view_cache_job.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

Reduce header dependencies in net/

TEST=none

Review URL: http://codereview.chromium.org/115870
------------------------------------------------------------------------
r17177 | phajdan.jr@chromium.org | 2009-05-29 11:31:15 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/extensions/extension.h
   M /trunk/src/chrome/common/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/common/extensions/extension_error_reporter.h
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_sync_channel.h
   M /trunk/src/chrome/common/jstemplate_builder.h
   M /trunk/src/chrome/common/mru_cache.h
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.h
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/chrome/common/page_action.h
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   M /trunk/src/chrome/common/sqlite_compiled_statement.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Headers cleanup in chrome/common

- reduce header dependencies
- miscellanous cleanups (whitespace, explicit deps)

Review URL: http://codereview.chromium.org/113945
------------------------------------------------------------------------
r17176 | yurys@google.com | 2009-05-29 10:37:06 +0200 (Fri, 29 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/common/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   M /trunk/src/webkit/glue/devtools/devtools_mock_rpc.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc.cc
   M /trunk/src/webkit/glue/devtools/devtools_rpc.h
   M /trunk/src/webkit/glue/devtools/devtools_rpc_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/webdevtoolsagent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_delegate.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsclient.h
   M /trunk/src/webkit/glue/webdevtoolsclient_delegate.h
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.h

DevTools: decouple class and method names from RPC message arguments. That would allow to select dispatcher wothout parsing the message argument.
Review URL: http://codereview.chromium.org/115862
------------------------------------------------------------------------
r17173 | ben@chromium.org | 2009-05-29 08:41:16 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h

Fixing more bustage by ifdefing out Windows-only code.
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115914
------------------------------------------------------------------------
r17172 | ben@chromium.org | 2009-05-29 08:32:43 +0200 (Fri, 29 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc

Fix unit test bustage by making sure ExtensionView::ViewHierarchyChanged calls the base class impl first.

Fix compile bustage by not compiling windows-specific code on other platforms.

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115912
------------------------------------------------------------------------
r17169 | ben@chromium.org | 2009-05-29 08:02:19 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/views/controls/button/native_button_gtk.cc
   M /trunk/src/views/controls/button/native_button_win.cc
   D /trunk/src/views/controls/hwnd_view.cc
   D /trunk/src/views/controls/hwnd_view.h
   A /trunk/src/views/controls/native
   A /trunk/src/views/controls/native/native_view_host.cc (from /trunk/src/views/controls/native_view_host.cc:17161)
   A /trunk/src/views/controls/native/native_view_host.h (from /trunk/src/views/controls/native_view_host.h:17161)
   A /trunk/src/views/controls/native/native_view_host_gtk.cc (from /trunk/src/views/controls/native_view_host_gtk.cc:17161)
   A /trunk/src/views/controls/native/native_view_host_gtk.h (from /trunk/src/views/controls/native_view_host_gtk.h:17161)
   A /trunk/src/views/controls/native/native_view_host_win.cc (from /trunk/src/views/controls/hwnd_view.cc:17161)
   A /trunk/src/views/controls/native/native_view_host_win.h (from /trunk/src/views/controls/hwnd_view.h:17161)
   A /trunk/src/views/controls/native/native_view_host_wrapper.h
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/native_control_gtk.cc
   M /trunk/src/views/controls/native_control_gtk.h
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/native_control_win.h
   D /trunk/src/views/controls/native_view_host.cc
   D /trunk/src/views/controls/native_view_host.h
   D /trunk/src/views/controls/native_view_host_gtk.cc
   D /trunk/src/views/controls/native_view_host_gtk.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar.h
   M /trunk/src/views/controls/separator.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/views.gyp

Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/114059
------------------------------------------------------------------------
r17159 | sky@chromium.org | 2009-05-29 03:54:27 +0200 (Fri, 29 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc
   M /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.h
   M /trunk/src/chrome/chrome.gyp

Gets NativeTabContentsContainerGtk to compile and removes some
unneeded methods from NativeTabContentsContainerWin.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115903
------------------------------------------------------------------------
r17158 | evan@chromium.org | 2009-05-29 03:11:27 +0200 (Fri, 29 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

linux: wrap prefs checkbox in options window.

This is a quick hack, that will be replaced once we have the rest of prefs
implemented.

BUG=12736

Review URL: http://codereview.chromium.org/113977
------------------------------------------------------------------------
r17157 | tc@google.com | 2009-05-29 03:06:01 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Pressing "enter" while the JS prompt text entry has focus should
accept the user's text.

Review URL: http://codereview.chromium.org/114058

------------------------------------------------------------------------
r17150 | arv@google.com | 2009-05-29 02:20:06 +0200 (Fri, 29 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/common/chrome_switches.cc

Allow passing in a file path to a file that will be used for the new new tab
page. This allows faster prototyping (F5) of the NNTP.

TEST=Start Chrome with --new-new-tab-page=path/to/file.html. The NTP should
show the file. Make a visible change in the file and reload the tab page and
the change should be visible immidiately.

BUG=None

Review URL: http://codereview.chromium.org/113927
------------------------------------------------------------------------
r17146 | sky@chromium.org | 2009-05-29 02:11:44 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/chrome.gyp

Gets GoButton to compile on Linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115879
------------------------------------------------------------------------
r17145 | pkasting@chromium.org | 2009-05-29 02:10:17 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h

Hoist TrimHttpPrefix() so we only have one copy, not one per provider.

Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately.

BUG=10558
Review URL: http://codereview.chromium.org/115885
------------------------------------------------------------------------
r17144 | pkasting@chromium.org | 2009-05-29 02:07:24 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Treat alt-(arrows/pgup/pgdn) like alt was not pressed.  There's no reason to ignore these keypresses.

BUG=6992
TEST=Type a letter so the omnibox dropdown shows.  Press alt-down.  If you used the numpad down arrow, nothing should happen (until you release both keys, then a special character might appear).  If you used the standalone arrow keys, the selection should move down one row.
Review URL: http://codereview.chromium.org/115891
------------------------------------------------------------------------
r17137 | evan@chromium.org | 2009-05-29 01:56:05 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html

linux: remove the word "Alpha" from all UI.

It mostly confuses the press.

Review URL: http://codereview.chromium.org/113978
------------------------------------------------------------------------
r17136 | tc@google.com | 2009-05-29 01:54:47 +0200 (Fri, 29 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Add alert box suppression check box to linux js dialogs.

BUG=12174

Review URL: http://codereview.chromium.org/115893

------------------------------------------------------------------------
r17134 | pkasting@chromium.org | 2009-05-29 01:42:11 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/views/controls/textfield/textfield.cc

IE and Firefox always translate (alt+numpad 7) as an accelerator.  We should too.

BUG=5372
TEST=Navigate somewhere, focus the omnibox, and hit alt+numpad 7.  You should navigate to your home page (by default, the new tab page).
Review URL: http://codereview.chromium.org/113971
------------------------------------------------------------------------
r17132 | estade@chromium.org | 2009-05-29 01:35:18 +0200 (Fri, 29 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/link_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/link_button_gtk.h
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Paint a focus indication on LinkButtonGtk buttons.

Also, rearrange helper code for centering things in hboxes so they don't expand to take up the full vertical space.

Also, don't allow focus on gtk_chrome_button buttons. This is to prevent the "Other bookmarks" button from getting focus (which matches windows) and is in line with disallowing focus on all custom chrome buttons (see CustomDrawButton).

BUG=12829
TEST=everything should look the same. Also if you tab to focus on a link button (e.g. download shelf's "show all downloads"), it should have a dotted line around the exterior.

Review URL: http://codereview.chromium.org/113970
------------------------------------------------------------------------
r17131 | abarth@chromium.org | 2009-05-29 01:29:45 +0200 (Fri, 29 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Rename policy_url to first_party_for_cookies in one more place.

This should have been in my earlier CL, but I had a gcl fail.

TBR=darin
BUG=None
TEST=No behavior change

Review URL: http://codereview.chromium.org/112067
------------------------------------------------------------------------
r17130 | thestig@chromium.org | 2009-05-29 01:06:34 +0200 (Fri, 29 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Initialize gtk syles before first run dialog. (Missed in r17104)

BUG=none
TEST=Linux first run dialog should be properly styled?
Review URL: http://codereview.chromium.org/115890
------------------------------------------------------------------------
r17123 | jar@chromium.org | 2009-05-29 00:02:46 +0200 (Fri, 29 May 2009) | 18 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/histogram_synchronizer.cc
   A /trunk/src/chrome/common/histogram_synchronizer.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.cc
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.h

Automatically adapt to faster/slower uploads of renderer histograms

This replaces the current time based approach (chrome is given N seconds
to upload all renederer histograms) with an asynch callback approach
that waits until all renderers have responded (with their updates). It
uses a fall-back timer to ensure that a hung renderer won't delay things
forever as well.

This causes faster (and complete) updates in about:histograms as well
as generally assuring complete updates during UMA gatherings.

This code was contributed by Raman Tenneti in CL 42496
http://codereview.chromium.org/42496

bug=12850

r=raman
Review URL: http://codereview.chromium.org/113473
------------------------------------------------------------------------
r17121 | thestig@chromium.org | 2009-05-28 23:51:29 +0200 (Thu, 28 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

Hook up Linux crash reporting setting to options dialog.
Review URL: http://codereview.chromium.org/115878
------------------------------------------------------------------------
r17115 | tc@google.com | 2009-05-28 23:23:18 +0200 (Thu, 28 May 2009) | 15 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/gtk/options/general_page_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/general_page_gtk.h
   A /trunk/src/chrome/browser/gtk/options/options_layout_gtk.cc
   A /trunk/src/chrome/browser/gtk/options/options_layout_gtk.h
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   A /trunk/src/chrome/browser/options_page_base.cc
   A /trunk/src/chrome/browser/options_page_base.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/chrome.gyp

Add general options page.  Options are working with the following exceptions:
Custom start urls and default search options widgets aren't hooked up.
Home page settings work, but are overridden by the linux start page settings.
Default browser checking/setting functions are not implemented, so the option
isn't useful yet.

Refactors some common code out of browser/views/options/options_page_view.*
into browser/options_page_base.{cc,h}

BUG=11507

Patch by Matt Mueller (mattm@google.com).

Review URL: http://codereview.chromium.org/113967

------------------------------------------------------------------------
r17113 | pkasting@chromium.org | 2009-05-28 23:00:10 +0200 (Thu, 28 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Remove some dead code.
Review URL: http://codereview.chromium.org/113965
------------------------------------------------------------------------
r17112 | ben@chromium.org | 2009-05-28 22:54:06 +0200 (Thu, 28 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.cc
   M /trunk/src/views/controls/textfield/native_textfield_win.h
   M /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   M /trunk/src/views/controls/textfield/textfield.cc
   M /trunk/src/views/controls/textfield/textfield.h
   M /trunk/src/views/view_unittest.cc

Make Textfield more portable.

Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface.

The APIs aren't perfectly tidy yet but this is a good first pass.

BUG=none
TEST=make sure you can still edit text fields, run the view unit tests.

Review URL: http://codereview.chromium.org/113940
------------------------------------------------------------------------
r17110 | ben@chromium.org | 2009-05-28 22:48:14 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Restore parent semantings for external tab container creation, and error check the HWND.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115852
------------------------------------------------------------------------
r17106 | estade@chromium.org | 2009-05-28 22:29:40 +0200 (Thu, 28 May 2009) | 5 lines
Changed paths:
   M /trunk/src/app/win_util.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/win_safe_util.cc
   M /trunk/src/chrome/common/win_safe_util.h

Linux: call xdg-open on downloaded files to open them.

BUG=12299
TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download.
Review URL: http://codereview.chromium.org/112064
------------------------------------------------------------------------
r17105 | munjal@chromium.org | 2009-05-28 22:23:33 +0200 (Thu, 28 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h

We need to save bookmarks file when the persist_ids settings changes
or when the file is detected to be changed externally.

Review URL: http://codereview.chromium.org/114055
------------------------------------------------------------------------
r17104 | thestig@chromium.org | 2009-05-28 22:23:06 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_linux.cc
   M /trunk/src/chrome/app/breakpad_linux.h
   M /trunk/src/chrome/app/breakpad_linux_stub.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run_gtk.cc
   A /trunk/src/chrome/browser/google_update_settings_linux.cc
   A /trunk/src/chrome/browser/google_update_settings_linux_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   D /trunk/src/chrome/renderer/render_crash_handler_linux.cc
   D /trunk/src/chrome/renderer/render_crash_handler_linux.h
   D /trunk/src/chrome/renderer/render_crash_handler_linux_stub.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Respect Linux user prefs with regards to crash reporting.
This involves implementing GoogleUpdateSettings::[GS]etCollectStatsConsent, and a whole lot of refactoring.

BUG=none
TEST=delete config dir, run official Linux build, don't enable crash reporting, crash browser -> no crash reporting.
Review URL: http://codereview.chromium.org/115808
------------------------------------------------------------------------
r17103 | tc@google.com | 2009-05-28 22:17:49 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Do a keyboard grab when select popups are showing.  This matches
other gtk popups (e.g., gtkmenu).  Always allow Esc to close the
popup so a hung renderer doesn't require mouse usage.

Review URL: http://codereview.chromium.org/113959

------------------------------------------------------------------------
r17102 | pkasting@chromium.org | 2009-05-28 22:13:44 +0200 (Thu, 28 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Clean up some code to make it more comprehensible.  No functional change.
Review URL: http://codereview.chromium.org/112063
------------------------------------------------------------------------
r17101 | sky@chromium.org | 2009-05-28 22:13:20 +0200 (Thu, 28 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Removes ifdef around include of tooltip_manager now that it's been
ported.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/113963
------------------------------------------------------------------------
r17098 | sky@chromium.org | 2009-05-28 21:58:56 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome.gyp

Gets bookmark_bar_view to compile on Linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115872
------------------------------------------------------------------------
r17097 | avi@chromium.org | 2009-05-28 21:45:07 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Handle opening URLs when there is no window open.

BUG=http://crbug.com/12550
TEST=as described in bug report

Review URL: http://codereview.chromium.org/113960
------------------------------------------------------------------------
r17095 | erg@google.com | 2009-05-28 21:22:34 +0200 (Thu, 28 May 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/gtk_floating_container.cc
   A /trunk/src/chrome/browser/gtk/gtk_floating_container.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/chrome.gyp

GTK: Implement GtkFloatingContainer and implement StatusBubble on top of it.

This introduces a hybrid GtkBin/GtkFixed container which exposes a signal to absolutely position widgets. This also fixes the current flickering issues with the status bubble.

http://crbug.com/11635
TEST=Goto a site with a long list of links (I used reddit.com) and move the mouse cursor up and down the list quickly. There shouldn't be flickering in the top left corner.

Review URL: http://codereview.chromium.org/115835
------------------------------------------------------------------------
r17093 | stoyan@chromium.org | 2009-05-28 21:12:46 +0200 (Thu, 28 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/common/net/cache_uitest.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_handle_tracker.cc
   M /trunk/src/chrome/test/automation/automation_handle_tracker.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/chrome/test/ui/layout_plugin_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/sunspider_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/v8_benchmark_uitest.cc
   M /trunk/src/chrome/test/url_fetch_test/url_fetch_test.cc
   M /trunk/src/chrome/worker/worker_uitest.cc

Make automation proxy objects to ref_counted. That allows to process async notifications directly in channel background thread. Add support for listener-less ChannelProxy.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113722
------------------------------------------------------------------------
r17089 | estade@chromium.org | 2009-05-28 20:35:24 +0200 (Thu, 28 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc

Generalize the code that checks for user actions in the render view to work on all platforms.

Also, on linux, assume the user denies every download which we would have prompted him with.

BUG=12709
TEST=windows is still carpet-bombing resilient and linux can download from the same page more than once.
Review URL: http://codereview.chromium.org/113925
------------------------------------------------------------------------
r17078 | jcampan@chromium.org | 2009-05-28 19:02:07 +0200 (Thu, 28 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

This CL is a clean-up of the app_modal_dialog_queue.cc in an attempt to fix a bug 10699.
Not sure what is causing the crasher.
Hopefully after this clean-up we'll get a different stack-trace that might help.

BUG=10699
TEST=Make sure alert/confirm boxes work properly. make sure a background tab that shows a (delayed) alert box  works. Same with a background browser.
     
Review URL: http://codereview.chromium.org/113932
------------------------------------------------------------------------
r17077 | jcampan@chromium.org | 2009-05-28 18:38:13 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

The Ctrl-Shift-Delete shortcut was not showing the Clear Browsing Data dialog.

BUG=12413
TEST=Focus the omnibox. Press Shift-Ctrl-Delete, the Clear Browsing Data dialog should show.
     Make sure cut/copy/paste shortcuts still work as expected (Ctrl/x, Ctrl/c, Ctrl/v, Shift/Delete, Shift/Insert).
Review URL: http://codereview.chromium.org/113872
------------------------------------------------------------------------
r17076 | sky@chromium.org | 2009-05-28 18:38:07 +0200 (Thu, 28 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/widget/aero_tooltip_manager.cc
   M /trunk/src/views/widget/aero_tooltip_manager.h
   D /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/tooltip_manager.h
   A /trunk/src/views/widget/tooltip_manager_gtk.cc
   A /trunk/src/views/widget/tooltip_manager_gtk.h
   A /trunk/src/views/widget/tooltip_manager_win.cc (from /trunk/src/views/widget/tooltip_manager.cc:17029)
   A /trunk/src/views/widget/tooltip_manager_win.h (from /trunk/src/views/widget/tooltip_manager.h:17029)
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h

Splits TooltipManager so that it can be ported and stubs out the GTK
side.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/114054
------------------------------------------------------------------------
r17073 | pfeldman@chromium.org | 2009-05-28 18:26:13 +0200 (Thu, 28 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

DevTools: remove DevTools from options UI.

Review URL: http://codereview.chromium.org/113951
------------------------------------------------------------------------
r17062 | brettw@chromium.org | 2009-05-28 05:39:38 +0200 (Thu, 28 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h

Hopefully fdix the Linux build
------------------------------------------------------------------------
r17061 | brettw@chromium.org | 2009-05-28 05:30:27 +0200 (Thu, 28 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Hopefully fix the Windows build.
------------------------------------------------------------------------
r17060 | brettw@chromium.org | 2009-05-28 05:26:32 +0200 (Thu, 28 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Hopefully dix the Linux build.
------------------------------------------------------------------------
r17050 | arv@google.com | 2009-05-28 03:15:10 +0200 (Thu, 28 May 2009) | 13 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html

Make the caption text for the "I understand" checkboxes in malware interstitial
pages into an HTML label tag, to make it clickable and more friendly to screen
readers.

TEST= Navigate to ianfette.org and click on the text "I understand that visiting
this site may harm my computer". Checkbox should toggle.

BUG= 12714

Original patch by chromium@willhirsch.co.uk 

Original review: http://codereview.chromium.org/115815

------------------------------------------------------------------------
r17048 | glen@chromium.org | 2009-05-28 02:15:36 +0200 (Thu, 28 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Remove JSCRE from about:credits

BUG=10638
TEST=Go to about:credits and verify that there's no reference to JSCRE

Original review URL:
http://codereview.chromium.org/113683

------------------------------------------------------------------------
r17043 | davemoore@chromium.org | 2009-05-28 02:10:00 +0200 (Thu, 28 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/dock_info_win.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Turn BrowserView::GetBrowserViewForNativeView() into GetBrowserViewForNativeWindow()
This simplifies things on linux where the native window is not the same type
as the native view.

Review URL: http://codereview.chromium.org/115830
------------------------------------------------------------------------
r17042 | pkasting@chromium.org | 2009-05-28 02:09:52 +0200 (Thu, 28 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Shift maximized mode tabstrip up by 1 px to avoid empty pixel at screen top.

BUG=12042
Review URL: http://codereview.chromium.org/115838
------------------------------------------------------------------------
r17041 | estade@chromium.org | 2009-05-28 01:52:32 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Dangerous download dialog for linux.

BUG=11780
TEST=go to cygwin.com, click "install or update now". The download shelf should appear with a dangerous download dialog, which should animate properly and without undue jank. Clicking "cancel" should delete the item and hide the shelf (since it's the only thing in the shelf). Clicking "save" should make it become a normal download item.

Review URL: http://codereview.chromium.org/113920
------------------------------------------------------------------------
r17038 | pkasting@chromium.org | 2009-05-28 01:39:36 +0200 (Thu, 28 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Fix erroneous sign when drawing path for right endcap of tabs, causing them to not be selectable for much of the right endcap.
Review URL: http://codereview.chromium.org/115836
------------------------------------------------------------------------
r17034 | ananta@chromium.org | 2009-05-28 01:01:21 +0200 (Thu, 28 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

With the recent change to the ExternalTabContainer to have it subclass WidgetWin rather than Widget and the associated ATL classes, the class name based comparison for a window
to check if it is an external tab container window is no longer valid. 

We now check if a window is an external tab window by looking for the existence of the kWindowObjectKey window property, which is only set on external tab container windows.

Review URL: http://codereview.chromium.org/115833
------------------------------------------------------------------------
r17032 | finnur@chromium.org | 2009-05-28 00:18:54 +0200 (Thu, 28 May 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc

Fix 12729: Find box doesn't unregister Esc accelerator.

This regressed recently during porting. When
comparing to see who is registered we need to 
be comparing against a class that implements
FocusChangeListener (and registers as such
with AddFocusChangeListener). In this case,
host_ does not implement that interface and 
doesn't register as a listener, so it will 
never be registered. We should be comparing
using 'this', not 'host_'.

I've fixed this and added a browser_test to 
catch this in the future.

BUG=12729
TEST=Open Find, press Esc, press Esc again 
and the Find box should not briefly appear
and hide again. Also, make sure Esc works 
to cancel navigations.

Review URL: http://codereview.chromium.org/115832
------------------------------------------------------------------------
r17029 | sky@chromium.org | 2009-05-28 00:00:39 +0200 (Thu, 28 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/input_window_dialog.h
   M /trunk/src/chrome/browser/input_window_dialog_gtk.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Converts a bunch things from NativeWindow to NativeView to make it
easier for callers. Also gets bookmark menu button to compile.

I'm also removing a function I just added to gtk_util as it's not
needed. GTK offers gtk_widget_get_toplevel which does what I need.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115831
------------------------------------------------------------------------
r17028 | brettw@chromium.org | 2009-05-27 23:51:06 +0200 (Wed, 27 May 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/thumbnail_store.h

Add an unused interface for storing thumbnails. This is to replace the history
system's thumbnail storage.
------------------------------------------------------------------------
r17027 | avi@chromium.org | 2009-05-27 23:40:09 +0200 (Wed, 27 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Make sure that we're restoring focus to a valid subview. (with Rohit)

BUG=http://crbug.com/12725

TEST=repro test mentioned in http://code.google.com/p/chromium/issues/detail?id=12725#c4

Review URL: http://codereview.chromium.org/113922
------------------------------------------------------------------------
r17026 | glen@chromium.org | 2009-05-27 23:38:06 +0200 (Wed, 27 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Commit on behalf of Yusuke:

"""
Fixed StatusBubbleViews::AvoidMouse() to support the mirrored UI (RTL) mode.

BUG=12148
TEST=Start chromium with --lang=he. Hover a mouse cursor on a link in the bottom
right corner, verify that the status bubble appears to the left. Verify that the
status bubble appears in a normal (right) position for all other links.
"""

Original review URL:
http://codereview.chromium.org/115461

------------------------------------------------------------------------
r17025 | mirandac@chromium.org | 2009-05-27 23:36:20 +0200 (Wed, 27 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

This fixes the problem of the status bubble obscuring the download shelf.

BUG= http://crbug.com/6590
TEST=Cause the download shelf to appear by initiating a download.  Hover
over a link in the extreme lower left corner of the browser window.  The
status bubble should avoid your mouse by moving to the right, instead of
moving down and obscuring the download shelf.


Review URL: http://codereview.chromium.org/113671
------------------------------------------------------------------------
r17024 | estade@chromium.org | 2009-05-27 23:32:09 +0200 (Wed, 27 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Remove an errant line from DownloadItemGtk that was causing a crash.

BUG=12653

Review URL: http://codereview.chromium.org/115829
------------------------------------------------------------------------
r17021 | jcampan@chromium.org | 2009-05-27 22:55:12 +0200 (Wed, 27 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Some ui tests would crash when the browser was closed.
The problem was related to an infobar (the default browser one) showing.
When the tab is closed, InfoBarClosed is called on the infobar delegates, triggering a delete of the delegate. Then a notification that the tab is destroyed is sent, causing the tab contents to layout its infobars accessing the deleted delegates.

BUG=12668
TEST=All UI tests should pass (especially the LoginPromptTest ones).
     Make IE your default browser, start Chrome. The default browser infobar should show. Close the tab.

Review URL: http://codereview.chromium.org/113906
------------------------------------------------------------------------
r17017 | munjal@chromium.org | 2009-05-27 22:16:41 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc

Add a preference to enable/disable ID persistence in bookmark model and
add methods in bookmark model to get/set this preference.

Review URL: http://codereview.chromium.org/113882
------------------------------------------------------------------------
r17014 | ben@chromium.org | 2009-05-27 21:47:23 +0200 (Wed, 27 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/message_box_view.h
   D /trunk/src/views/controls/text_field.cc
   D /trunk/src/views/controls/text_field.h
   A /trunk/src/views/controls/textfield
   A /trunk/src/views/controls/textfield/native_textfield_gtk.cc
   A /trunk/src/views/controls/textfield/native_textfield_gtk.h
   A /trunk/src/views/controls/textfield/native_textfield_win.cc
   A /trunk/src/views/controls/textfield/native_textfield_win.h
   A /trunk/src/views/controls/textfield/native_textfield_wrapper.h
   A /trunk/src/views/controls/textfield/textfield.cc (from /trunk/src/views/controls/text_field.cc:17006)
   A /trunk/src/views/controls/textfield/textfield.h (from /trunk/src/views/controls/text_field.h:17006)
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/views.gyp

Move text_field.cc and rename the class to Textfield in preparation for porting.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115825
------------------------------------------------------------------------
r17013 | pkasting@chromium.org | 2009-05-27 21:44:07 +0200 (Wed, 27 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Open a new tab page rather than the homepage if startup is set to "open the following" with a blank list.  Patch by Yuzo Fujishima (see http://codereview.chromium.org/113444 ), r=beng.

BUG=6901
------------------------------------------------------------------------
r17012 | pkasting@chromium.org | 2009-05-27 21:39:54 +0200 (Wed, 27 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Don't lose omnibox edits when dragging tabs out.  Patch by Yuzo Fujishima (see http://codereview.chromium.org/115558 ), r=beng.

BUG=10632
------------------------------------------------------------------------
r17010 | brettw@chromium.org | 2009-05-27 21:36:55 +0200 (Wed, 27 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   A /trunk/src/chrome/browser/views/dialog_stubs_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Add stubs for a variety of dialogs under GTK-Views.
Review URL: http://codereview.chromium.org/115824
------------------------------------------------------------------------
r17009 | sky@chromium.org | 2009-05-27 21:35:24 +0200 (Wed, 27 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.h

Adds comments to BrowserList::GetLastActive that it might return NULL
when there are browsers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113912
------------------------------------------------------------------------
r17002 | brettw@chromium.org | 2009-05-27 20:02:07 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/window_sizer_mac.mm
   M /trunk/src/chrome/chrome.gyp

Add BrowserView to the Linux build, it now compiles. This also includes a small
namespace change to window_sizer_mac which I noticed when doing a previous
change.
Review URL: http://codereview.chromium.org/113910
------------------------------------------------------------------------
r16997 | ben@chromium.org | 2009-05-27 19:29:34 +0200 (Wed, 27 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/button_dropdown.h

Make toolbar compile on linux.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115813
------------------------------------------------------------------------
r16996 | ben@chromium.org | 2009-05-27 19:28:24 +0200 (Wed, 27 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

ExternalTabContainer should subclass WidgetWin rather than Widget and ATL CWindowImpl. This makes it much easier to extend the API of Widget.

Cleans up ExternalTabContainer to better match chrome style.

BUG=none
TEST=run ui tests, verify ExternalTabContainer tests pass.
Review URL: http://codereview.chromium.org/113892
------------------------------------------------------------------------
r16995 | jeremy@chromium.org | 2009-05-27 19:18:23 +0200 (Wed, 27 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

revert 12598 now that text-overflow:ellipsis has been fixed in WebKit.

BUG=7697
TEST=Open RTL Chrome (--lang=he), load ynet.co.il, load mako.co.il, open new tab page.  Observe that ellipsis is placed correctly at the end of the page titles for aforementioned sites and that the underline is under the whole title and not just under the ellipsis.

Review URL: http://codereview.chromium.org/112025
------------------------------------------------------------------------
r16994 | arv@google.com | 2009-05-27 19:06:54 +0200 (Wed, 27 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Hides the "Remove thumbnails" link when the most visited intro is shown.

BUG=None

TEST=With an empty history, open a new tab. The NTP should not show the link
to "Remove thumbnails". Browse 3 different sites and open a new tab again. The
link "Remove thumbnails" should now be visible.


Review URL: http://codereview.chromium.org/115787
------------------------------------------------------------------------
r16992 | sky@chromium.org | 2009-05-27 18:52:04 +0200 (Wed, 27 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Fixes multiple definitions for DragDownload.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115811
------------------------------------------------------------------------
r16991 | pinkerton@chromium.org | 2009-05-27 18:42:22 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   A /trunk/src/chrome/browser/cocoa/preferences_localizer.h
   A /trunk/src/chrome/browser/cocoa/preferences_localizer.mm
   M /trunk/src/chrome/chrome.gyp

Use correct branding on the "make default browser" button. Create a new localizer subclass for the prefs window.
BUG=12534
TEST=make sure branding is correct on default browser button.
Review URL: http://codereview.chromium.org/115817
------------------------------------------------------------------------
r16989 | pinkerton@chromium.org | 2009-05-27 18:37:06 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Add shift-zoom to maximize.
BUG=none
TEST=shift-zoom maximizes window, zoom sizes to intrinsic size.
Review URL: http://codereview.chromium.org/115818
------------------------------------------------------------------------
r16987 | sky@chromium.org | 2009-05-27 18:36:19 +0200 (Wed, 27 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h

Relands cl 16982 as it wasn't the cause of the build breakage. Here's
the description for that cl:

Lands http://codereview.chromium.org/115505 for bug
http://crbug.com/4030 for tyoshino.

BUG=http://crbug.com/4030
TEST=make sure control-w dismisses bookmark manager.

Review URL: http://codereview.chromium.org/113902
------------------------------------------------------------------------
r16986 | kuchhal@chromium.org | 2009-05-27 18:36:10 +0200 (Wed, 27 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.h
   A /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.h
   A /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/chrome.gyp

Make the import feature a little more complete:
- Now we show import progress of individual items
- In case Firefox is running we display a warning and allow user to close it before proceeding
- Delete the Firefox lock when import finishes

BUG=11191

Review URL: http://codereview.chromium.org/114047

------------------------------------------------------------------------
r16985 | maruel@chromium.org | 2009-05-27 17:28:38 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h

Reverting 16982.

Broke Modules Mac
Review URL: http://codereview.chromium.org/113901
------------------------------------------------------------------------
r16984 | pfeldman@chromium.org | 2009-05-27 16:51:21 +0200 (Wed, 27 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide developer tools by default.

Review URL: http://codereview.chromium.org/117003
------------------------------------------------------------------------
r16982 | sky@chromium.org | 2009-05-27 16:34:22 +0200 (Wed, 27 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h

Lands http://codereview.chromium.org/115505 for bug
http://crbug.com/4030 for tyoshino.

BUG=http://crbug.com/4030
TEST=make sure control-w dismisses bookmark manager.

Review URL: http://codereview.chromium.org/113887
------------------------------------------------------------------------
r16981 | pinkerton@chromium.org | 2009-05-27 15:04:00 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm

Fix issue where cmd-w was hard-coded to closing a browser tab regardless of the frontmost window type. Have cmd-key equiv correctly set depending on the window type and the number of tabs in the window. Broadcast notification when the number of tabs changes in the model. Disable "close tab" item when there's only 1 tab in the browser window.
BUG=10047
TEST=cmd-w correctly closes the expected thing (frontmost window, or tab in the frontmost window). close tab should be disabled when the frontmost tab is not a browser or if there is only 1 tab in the window.
Review URL: http://codereview.chromium.org/115789
------------------------------------------------------------------------
r16978 | phajdan.jr@chromium.org | 2009-05-27 10:46:28 +0200 (Wed, 27 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_linux.cc
   M /trunk/src/chrome/browser/task_manager_win.cc

Create OpenClose browser test for TaskManager with necessary refactoring.

http://crbug.com/12320

Review URL: http://codereview.chromium.org/113636
------------------------------------------------------------------------
r16976 | phajdan.jr@chromium.org | 2009-05-27 10:12:55 +0200 (Wed, 27 May 2009) | 10 lines
Changed paths:
   M /trunk/src/base/test_suite.h
   M /trunk/src/base/time.h
   M /trunk/src/base/time_win.cc
   M /trunk/src/chrome/browser/browser_main.cc

Do not monitor system power state during unit tests.

The observer requires that message loop stays up and same through
its lifetime. This is not true during testing.

TEST=none

http://crbug.com/12187

Review URL: http://codereview.chromium.org/113824
------------------------------------------------------------------------
r16974 | jungshik@google.com | 2009-05-27 07:36:25 +0200 (Wed, 27 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc

Show Unicode IDNs for "On startup" setting and "Add page" dialog for it.

TEST=visit an IDN URL, and open the "Basics" tab of the "Options"
  dialog, select "Open the following pages", press "Add..." button,
  select the IDN URL, and confirm that the URL field is shown in
  Unicode, or
  paste a Punycode URL to the URL field of the "Add page" dialog,
  press "Add" button, and confirm that the "Open the followig pages"
  list shows the Unicode URL.

http://crbug.com/3991
Patch by tkent
Original review: http://codereview.chromium.org/115759

------------------------------------------------------------------------
r16973 | jungshik@google.com | 2009-05-27 07:33:19 +0200 (Wed, 27 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

For "Copy link address" context menu, copy the URL with Unicode host name
instead of Punycode host name.

http://crbug.com/4008
TEST="Copy link address" copies Unicode host name for both of <a href="punycode
URL"> and <a href="Unicode URL"> if Accept-Language preference is matched.

Patch by tkent
Original review: http://codereview.chromium.org/115752

------------------------------------------------------------------------
r16970 | thestig@chromium.org | 2009-05-27 04:59:36 +0200 (Wed, 27 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer_linux.cc

Fix comparison in window_sizer_linux. There can be multiple desktops so data_len can be greater.

TBR=evan

BUG=none
TEST=should work on window managers that support the wm-spec.
Review URL: http://codereview.chromium.org/113884
------------------------------------------------------------------------
r16963 | estade@chromium.org | 2009-05-27 03:29:43 +0200 (Wed, 27 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

Control spacing of toolbar elements with pixels rather than " " GtkLabels.

This fixes another large fonts issue.

BUG=12573
TEST=toolbar should look like it does on windows (where there is spacing, the size of it, etc.)

Review URL: http://codereview.chromium.org/115792
------------------------------------------------------------------------
r16960 | arv@google.com | 2009-05-27 02:58:31 +0200 (Wed, 27 May 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc

Use the original profile for the downloads manager so that a download manager
in an incognito window is in sync with all other download managers.

BUG=11514

TEST=Open a download manager (Ctrl+J) and an incognito window with a
download manager (Ctrl+Shift+N followed by Ctrl+J). Then start to download a
file and note that both download managers should get updated. Try pausing and
eventually click "Remove all" in either DM and all downloads should get removed
from both DMs.


Review URL: http://codereview.chromium.org/115804
------------------------------------------------------------------------
r16957 | ben@chromium.org | 2009-05-27 02:08:42 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Fix broken toolkit_views build by adding include of message_loop.

TBR=sky
Review URL: http://codereview.chromium.org/115806
------------------------------------------------------------------------
r16956 | evan@chromium.org | 2009-05-27 02:06:46 +0200 (Wed, 27 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer_linux.cc

linux: fix CHECK fail in window_sizer.

1) We shouldn't use CHECK for situations that can reasonably occur.
2) We need to recover from the case where this WORKAREA property isn't
   available.

Review URL: http://codereview.chromium.org/113877
------------------------------------------------------------------------
r16953 | brettw@chromium.org | 2009-05-27 01:50:25 +0200 (Wed, 27 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc
   M /trunk/src/chrome/chrome.gyp

Fox some compilation problems for Linux. This also adds bookmark_bar_view and
window_sizer to the Linux build.
Review URL: http://codereview.chromium.org/115803
------------------------------------------------------------------------
r16949 | arv@google.com | 2009-05-27 01:44:02 +0200 (Wed, 27 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc

Show the time remaining of download items in the download manager.

BUG=9607

TEST=Download a large file and go to the download manager (Ctrl+J). The
remaining time of your current downloads should decreasen as the download is
getting closer to being done.

Review URL: http://codereview.chromium.org/115797
------------------------------------------------------------------------
r16948 | ben@chromium.org | 2009-05-27 01:42:23 +0200 (Wed, 27 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Removes WidgetWin dependency from StatusBubbleViews so that it can compile on Linux.

Requires:
- making SetOpacity a cross platform method on Widget, replacing SetLayeredAlpha.
- moving Window::SetBounds to Widget
- replacing usage of MoveWindow in StatusBubbleViews with call to new SetBounds method.

BUG=none
TEST=make sure transparency still works for floating widgets like - status bubble, full screen exit bubble, dragged tabs

Review URL: http://codereview.chromium.org/113846
------------------------------------------------------------------------
r16947 | kuchhal@chromium.org | 2009-05-27 01:40:20 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

Change actual pref for stats reporting when selected.

Review URL: http://codereview.chromium.org/113866

------------------------------------------------------------------------
r16946 | tc@google.com | 2009-05-27 01:39:44 +0200 (Wed, 27 May 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Fix a bug where if user has focus follows mouse, moving out of
the chrome window closes content popups.

We need to grab all X mouse events using gdk_pointer_grab.  This
prevents other windows from getting focus.

We no longer need the focus-out-event signal handler because we'll
get the mouse down outside the browser window, forward it to the
renderer, and it will tell us to close.

I verified manually that killing the renderer while the popup is
showing results in gdk_display_pointer_ungrab getting called.  If the renderer hangs, the user just needs to click outside the popup.

Review URL: http://codereview.chromium.org/112052

------------------------------------------------------------------------
r16945 | sky@chromium.org | 2009-05-27 01:39:35 +0200 (Wed, 27 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   A /trunk/src/chrome/browser/views/frame/browser_non_client_frame_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/chrome.gyp

Fleshes out more of BrowserFrameGtk.



BUG=none

TEST=none 
Review URL: http://codereview.chromium.org/113873
------------------------------------------------------------------------
r16944 | jhawkins@chromium.org | 2009-05-27 01:39:01 +0200 (Wed, 27 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Fix initial window placement when dragging a tab out of the tabstrip into its own window.  This change also removes code that was overriding the requested size as a temporary workaround.

BUG=none
TEST=Open a browser window with two tabs.  Drag one of the tabs out of the tabstrip.  A new window should be created where the mouse is positioned.
Review URL: http://codereview.chromium.org/113874
------------------------------------------------------------------------
r16940 | thestig@chromium.org | 2009-05-27 00:55:28 +0200 (Wed, 27 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/window_sizer_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add a single monitor implementation of WindowSizer for Linux. (try 2)

BUG=10005
Review URL: http://codereview.chromium.org/115723
------------------------------------------------------------------------
r16939 | evan@chromium.org | 2009-05-27 00:48:40 +0200 (Wed, 27 May 2009) | 8 lines
Changed paths:
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   D /trunk/src/chrome/browser/password_manager/password_store.cc
   D /trunk/src/chrome/browser/password_manager/password_store.h
   D /trunk/src/chrome/browser/password_manager/password_store_default.cc
   D /trunk/src/chrome/browser/password_manager/password_store_default.h
   D /trunk/src/chrome/browser/password_manager/password_store_gnome.cc
   D /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   D /trunk/src/chrome/browser/password_manager/password_store_kwallet.cc
   D /trunk/src/chrome/browser/password_manager/password_store_kwallet.h
   D /trunk/src/chrome/browser/password_manager/password_store_win.cc
   D /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Revert the password manager refactoring -- it failed reliability tests.

(For reference, it was committed with the wrong message: "Patch to make
password patch build.")

This reverts commit r16708.

Review URL: http://codereview.chromium.org/113871
------------------------------------------------------------------------
r16933 | brettw@chromium.org | 2009-05-27 00:15:39 +0200 (Wed, 27 May 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_views.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_win.cc:16889)
   D /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_win.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.gyp

Rename bookmark_context_menu_win to *_views instead since it's technically
cross-platform.
Review URL: http://codereview.chromium.org/115799
------------------------------------------------------------------------
r16930 | brettw@chromium.org | 2009-05-26 23:58:30 +0200 (Tue, 26 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.cc

Remove the last bits leftover from my frame window experiment.
Review URL: http://codereview.chromium.org/113863
------------------------------------------------------------------------
r16929 | brettw@chromium.org | 2009-05-26 23:55:21 +0200 (Tue, 26 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix more compilation errors in browser_view.cc and an error I introduced in a
previous change that used the wrong parent variable when showing HTML dialogs.
Review URL: http://codereview.chromium.org/113864
------------------------------------------------------------------------
r16924 | aa@chromium.org | 2009-05-26 23:45:10 +0200 (Tue, 26 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css

Make the contents of toolstrips center vertically by default.

Review URL: http://codereview.chromium.org/115790
------------------------------------------------------------------------
r16920 | brettw@chromium.org | 2009-05-26 23:33:29 +0200 (Tue, 26 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Make bookmark_bar_view.h hopefully compile on Linux.
Review URL: http://codereview.chromium.org/115795
------------------------------------------------------------------------
r16918 | brettw@chromium.org | 2009-05-26 23:32:29 +0200 (Tue, 26 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Make most of browser_view compile on Linux.
Review URL: http://codereview.chromium.org/115786
------------------------------------------------------------------------
r16916 | agl@chromium.org | 2009-05-26 23:30:55 +0200 (Tue, 26 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Linux: don't trigger GCC 4.3 warnings

r16889 triggered some warnings with GCC 4.3: http://pastebin.com/m3a9415af

------------------------------------------------------------------------
r16906 | shess@chromium.org | 2009-05-26 22:51:34 +0200 (Tue, 26 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

SetInitialFocus() when there's no view to restore to.

http://crbug.com/12555
TEST=Browse to a page.  Bring up a new tab (Command-t), should be able to start typing in autocomplete.

http://crbug.com/12556
TEST=With a partial URL entered, switch tabs, and switch back.  Should be able to type to replace autocomplete.  This does not fix the entire bug.

Review URL: http://codereview.chromium.org/115734
------------------------------------------------------------------------
r16905 | jhawkins@chromium.org | 2009-05-26 22:49:01 +0200 (Tue, 26 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc

Fix a corner case in tab dragging where we receive a drag-end signal before ever receiving a drag-motion signal.  In this case we'd crash because dragged_tab_ isn't created yet.

BUG=12473
TEST=Open a browser with three tabs.  Rapidly click on the first and third tabs.  This should not cause the browser to crash.
Review URL: http://codereview.chromium.org/113854
------------------------------------------------------------------------
r16904 | estade@chromium.org | 2009-05-26 22:48:32 +0200 (Tue, 26 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc

Undelete the factory method for BackForwardMenuModelGtk.

It's still used by the unit test.

TBR=erg

Review URL: http://codereview.chromium.org/115791
------------------------------------------------------------------------
r16901 | sky@chromium.org | 2009-05-26 22:25:29 +0200 (Tue, 26 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fixes BrowserView::GetBrowserViewForNativeView on linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113851
------------------------------------------------------------------------
r16899 | sky@chromium.org | 2009-05-26 22:22:26 +0200 (Tue, 26 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/views.gyp

Gets a couple of download classes to compile on linux. Updates the
views build so that we only include the gtk classes we need.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115788
------------------------------------------------------------------------
r16898 | estade@chromium.org | 2009-05-26 22:18:21 +0200 (Tue, 26 May 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc
   A /trunk/src/chrome/browser/gtk/back_forward_button_gtk.h
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/chrome.gyp

Refactor back/forward buttons to their own class. Fix them so the menu pops up on drags and the buttons look depressed when the menu is showing.

BUG=12427
TEST=back/forward button behavior should be as on windows (see bug desc. for details).

Review URL: http://codereview.chromium.org/113806
------------------------------------------------------------------------
r16897 | stuartmorgan@chromium.org | 2009-05-26 22:17:50 +0200 (Tue, 26 May 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/keychain_mac.cc
   A /trunk/src/chrome/browser/keychain_mac.h
   A /trunk/src/chrome/browser/password_manager/password_store_mac.cc
   A /trunk/src/chrome/browser/password_manager/password_store_mac.h
   A /trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   A /trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M /trunk/src/chrome/chrome.gyp

First phase of Mac Keychain integration. For the overall plan, see the design doc linked from the bug. This implements the ability to read existing Keychain passwords, but no storage/updating yet, and no adding of our own metadata as passwords are used; all that will be done in follow-up patches.

This also includes a Keychain wrapper for the functionality necessary so far, and a mock Keychain sufficient to unit-test essentially all of the code.

This patch deliberately excludes the step of instantiating a PasswordStoreMac and hooking it up to the profile, because a bug in autocomplete itself prevents passwords we load from actually being used, and we don't want to trigger Keychain UI for passwords that will be ignored. So this won't be used in builds yet, but it will be unit tested.

BUG=11745
TEST=none (no user-visible effect yet)
Review URL: http://codereview.chromium.org/115658
------------------------------------------------------------------------
r16894 | jhawkins@chromium.org | 2009-05-26 22:03:37 +0200 (Tue, 26 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Implement dragging a tab out of a TabStripGtk into its own browser window.

BUG=none
TEST=Open a browser window with two tabs, pull one of the tabs out of the tab strip.  On release, a new window should be created with the dragged tab contents.
Review URL: http://codereview.chromium.org/113787
------------------------------------------------------------------------
r16892 | sky@chromium.org | 2009-05-26 22:00:11 +0200 (Tue, 26 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

Removes some dead code in TabContentsViewGtk and makes it compile for
views.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113849
------------------------------------------------------------------------
r16891 | brettw@chromium.org | 2009-05-26 21:50:15 +0200 (Tue, 26 May 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.h
   D /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc:16872)
   A /trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.h (from /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.h:16872)
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   A /trunk/src/chrome/browser/views/bookmark_menu_controller_views.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.cc:16872)
   A /trunk/src/chrome/browser/views/bookmark_menu_controller_views.h (from /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.h:16872)
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/chrome.gyp

Move the BookmarkMenuController out of bookmarks to the platform-specific part
of chrome. This renames the _win version to _views and makes the header
compilable on non-Windows.
Review URL: http://codereview.chromium.org/113844
------------------------------------------------------------------------
r16889 | agl@chromium.org | 2009-05-26 21:41:26 +0200 (Tue, 26 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Linux: implement 16-bit visuals without Xrender.

Some VNC users still have this setup.

BUG=10616
http://codereview.chromium.org/113848

------------------------------------------------------------------------
r16887 | mpcomplete@google.com | 2009-05-26 21:32:32 +0200 (Tue, 26 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Make OffTheRecordObserver a Singleton.

BUG=12560
Review URL: http://codereview.chromium.org/115785
------------------------------------------------------------------------
r16884 | finnur@chromium.org | 2009-05-26 21:08:13 +0200 (Tue, 26 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix a race condition in the unpacking of the extension system.

After asking for an extension to be unpacked, sometimes the
temp directory gets cleaned up before the unpacker can do its
work (in LoadExtensionsFromInstallDirectory, because the dir
contains no current version).

BUG=None
TEST=Add a reg key to HKLM to install an external extension
and make sure the extension gets installed.

Review URL: http://codereview.chromium.org/113795
------------------------------------------------------------------------
r16883 | wtc@chromium.org | 2009-05-26 21:07:34 +0200 (Tue, 26 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Rename the --proxy-bypass-urls command-line switch
--proxy-bypass-list.

R=robertshield,eroman
BUG=http://crbug.com/266
TEST=N/A
Review URL: http://codereview.chromium.org/115725
------------------------------------------------------------------------
r16882 | sky@chromium.org | 2009-05-26 21:06:50 +0200 (Tue, 26 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/dock_info_win.cc
   M /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Renames BrowserView::GetBrowserViewForHWND to
GetBrowserViewForNativeView and implements the GTK side. I could have
went with NativeWindow here, but we end up with more flexibility if we
keep this as NativeView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113842
------------------------------------------------------------------------
r16881 | sky@chromium.org | 2009-05-26 21:06:36 +0200 (Tue, 26 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_gtk.cc

Makes DockInfo usable on Linux. It doesn't implement
GetDockInfoAtPoint, but that's not important for now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115776
------------------------------------------------------------------------
r16880 | mpcomplete@google.com | 2009-05-26 21:00:58 +0200 (Tue, 26 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   D /trunk/src/chrome/browser/extensions/extension.cc
   D /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   D /trunk/src/chrome/browser/extensions/extension_error_reporter.cc
   D /trunk/src/chrome/browser/extensions/extension_error_reporter.h
   D /trunk/src/chrome/browser/extensions/extension_error_utils.cc
   D /trunk/src/chrome/browser/extensions/extension_error_utils.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   D /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/extensions/extension.cc (from /trunk/src/chrome/browser/extensions/extension.cc:16769)
   A /trunk/src/chrome/common/extensions/extension.h (from /trunk/src/chrome/browser/extensions/extension.h:16769)
   A /trunk/src/chrome/common/extensions/extension_error_reporter.cc (from /trunk/src/chrome/browser/extensions/extension_error_reporter.cc:16736)
   A /trunk/src/chrome/common/extensions/extension_error_reporter.h (from /trunk/src/chrome/browser/extensions/extension_error_reporter.h:16736)
   A /trunk/src/chrome/common/extensions/extension_error_utils.cc (from /trunk/src/chrome/browser/extensions/extension_error_utils.cc:16736)
   A /trunk/src/chrome/common/extensions/extension_error_utils.h (from /trunk/src/chrome/browser/extensions/extension_error_utils.h:16736)
   A /trunk/src/chrome/common/extensions/extension_unittest.cc (from /trunk/src/chrome/browser/extensions/extension_unittest.cc:16769)
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Remove unused code from ExtensionsService.

Move extension.* from browser to common, so it can be included by the utility
process.
Review URL: http://codereview.chromium.org/115716
------------------------------------------------------------------------
r16876 | pinkerton@chromium.org | 2009-05-26 20:51:50 +0200 (Tue, 26 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm

File bug for a NOTIMPLEMENTED, remove a couple others.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115774
------------------------------------------------------------------------
r16875 | pinkerton@chromium.org | 2009-05-26 20:51:21 +0200 (Tue, 26 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Correct the hit testing so that the window controls and title bar will get targeted when the window isn't the foreground window.
BUG=12505
TEST=closing and minimizing background windows. all mouse interactions with foreground tabs.
Review URL: http://codereview.chromium.org/112059
------------------------------------------------------------------------
r16867 | aa@chromium.org | 2009-05-26 08:05:40 +0200 (Tue, 26 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   A /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_bookmarks_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   A /trunk/src/chrome/browser/extensions/extension_event_names.cc
   A /trunk/src/chrome/browser/extensions/extension_event_names.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   A /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   A /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.cc
   A /trunk/src/chrome/browser/extensions/extension_tabs_module_constants.h
   M /trunk/src/chrome/chrome.gyp

Separate out the string constants used for extension API function
names, function parameter keys, error messages and event names so that
they can be reused when writing extension UI tests.

Original review: http://codereview.chromium.org/113771

Review URL: http://codereview.chromium.org/113831
Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>.
------------------------------------------------------------------------
r16864 | aa@chromium.org | 2009-05-26 04:27:02 +0200 (Tue, 26 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc

Update renderers when there are zero user scripts.

Commit: http://codereview.chromium.org/113733

BUG=12170
TEST=Enable user scripts and create one. See that it runs. Now delete it. See
that it does not run!

Review URL: http://codereview.chromium.org/113741
Patch from Ted Crossman <tedoc2000@gmail.com>.
------------------------------------------------------------------------
r16861 | mad@chromium.org | 2009-05-25 22:38:37 +0200 (Mon, 25 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/automation/extension_port_container.cc
   M /trunk/src/chrome/browser/automation/extension_port_container.h

Commiting for Jói, based on http://codereview.chromium.org/115721

------------------------------------------------------------------------
r16843 | abarth@chromium.org | 2009-05-23 20:11:10 +0200 (Sat, 23 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/net/base/cookie_policy.cc
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc

Rename |policy_url| to |first_party_for_cookies|.  This now matches the WebKit name for this piece of data.

R=jackson
BUG=None
TEST=No behavior change

Review URL: http://codereview.chromium.org/115743
------------------------------------------------------------------------
r16839 | brettw@chromium.org | 2009-05-23 17:24:20 +0200 (Sat, 23 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/hwnd_notification_source.h
   A /trunk/src/chrome/common/native_window_notification_source.h (from /trunk/src/chrome/common/hwnd_notification_source.h:16814)

Make hwnd_notification_source portable by making it use NativeWindow (and
renaming it accordingly).
Review URL: http://codereview.chromium.org/115730
------------------------------------------------------------------------
r16835 | tommi@chromium.org | 2009-05-23 05:55:54 +0200 (Sat, 23 May 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_extension_function.cc
   A /trunk/src/chrome/browser/automation/extension_automation_constants.cc
   A /trunk/src/chrome/browser/automation/extension_automation_constants.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/automation/extension_automation_constants.cc
   D /trunk/src/chrome/test/automation/extension_automation_constants.h
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Committing issue 113734 for Joi.

Description:

Make sure extension_uitest.cc is actually built (my bad - got confused
about the whole .gyp vs. .sln thing).

Also, to get things building now that extension_uitest.cc is built,
shuffle the extension automation constants around so they end up in
the browser library (I didn't realize the UI tests are already linking
with that, and the linker was bringing in the
automation_extension_function.obj file ended up causing lots of
unresolved linker problems).  Note that this did build the other day
when I submitted the file originally, but it must have been
essentially a fluke that the linker chose the other .obj file to get
the constants.

BUG=none
TEST=none

Original issue: http://codereview.chromium.org/113734

Review URL: http://codereview.chromium.org/113788
------------------------------------------------------------------------
r16832 | sky@chromium.org | 2009-05-23 04:50:01 +0200 (Sat, 23 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/chrome.gyp

Makes the info bars compile.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113801
------------------------------------------------------------------------
r16830 | sky@chromium.org | 2009-05-23 04:49:34 +0200 (Sat, 23 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/controls/text_field.h
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/window/window_gtk.cc

Makes FindBarWin buildable on linux. FindBarWin should be renamed to
FindBarViews, but I'm leaving it as is for now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113793
------------------------------------------------------------------------
r16827 | cpu@google.com | 2009-05-23 03:28:57 +0200 (Sat, 23 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/sandbox_policy.cc

Block another spyware doctor dll

This one is a strong suspect for several otherwise unexplained crashes

    Image path: C:\Program Files\Spyware Doctor\smum32.dll
    Image name: smum32.dll
    Timestamp:        Wed Nov 12 19:33:53 2008 (491BA021)
    CheckSum:         0002DA62
    ImageSize:        00029000
    File version:     6.1.0.2
    Product version:  6.1.0.2


TEST = no test required
BUG = 10695


Review URL: http://codereview.chromium.org/114043
------------------------------------------------------------------------
r16824 | mirandac@chromium.org | 2009-05-23 03:01:57 +0200 (Sat, 23 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Forces window to show and hide with native system calls at the beginning
and end of animation.  This allows the system bubble to hide and display
in systems that don't respect opacity, such as the Parallels desktop.

BUG= http://crbug.com/622
TEST=Start Chrome on a system running in a Parallels window.  Hover over
a status bubble, and move mouse away.  Status bubble should disappear.

(NOTE: This was reviewed at http://codereview.chromium.org/113747.  It is in a
different review here because that code was uploaded from another machine,
before I had committer access.)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16802

------------------------------------------------------------------------
r16823 | shess@chromium.org | 2009-05-23 02:58:58 +0200 (Sat, 23 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Don't make |field_| first responder in SetSelectedRange() unless |model_| has_focus already.

http://crbug.com/11920
TEST=Browser to www.google.com, focus is in search field, bring up new tab, click back to first tab, focus should be in search field.
TEST=Select messages in gmail, focus should NOT go to autocomplete field (omnibox, url bar).

Review URL: http://codereview.chromium.org/113751
------------------------------------------------------------------------
r16818 | pkasting@chromium.org | 2009-05-23 01:46:26 +0200 (Sat, 23 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/common/notification_service_unittest.cc

Try to fix more Mac bustage.

TBR=avi
Review URL: http://codereview.chromium.org/113799
------------------------------------------------------------------------
r16816 | pkasting@chromium.org | 2009-05-23 01:12:12 +0200 (Sat, 23 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Use a NotificationRegistrar to listen for notifications.

BUG=2381

TBR=avi
Review URL: http://codereview.chromium.org/113796
------------------------------------------------------------------------
r16815 | sky@chromium.org | 2009-05-23 01:03:45 +0200 (Sat, 23 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/chrome.gyp

Gets toolbar_star_toggle to compile on linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/112058
------------------------------------------------------------------------
r16813 | pkasting@chromium.org | 2009-05-23 01:01:34 +0200 (Sat, 23 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Fix a NotificationObserver that crept in yesterday to use the NotificationRegistrar.

BUG=2381
Review URL: http://codereview.chromium.org/113790
------------------------------------------------------------------------
r16811 | willchan@chromium.org | 2009-05-23 01:01:02 +0200 (Sat, 23 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Fixes a number of issues with ProcessSingletonLinux.
(1) Use nonblocking sockets.  Blocking the IO thread is bad.
(2) Handle multiple SocketReaders.
(3) Stop leaking file descriptors in SocketReader.  Old code used to stop watching the fds, but not close them.
(4) Handle partial reads and writes.  SocketReader reads until the sender shuts down his side of the socket.
(5) Timeout readers after 5 seconds so they don't hang forever.
BUG=http://www.crbug.com/12343
TEST=Open a chrome instance.  Check /proc/<pid>/fd/ to see how many descriptors there are.  Run "chrome www.google.com" on the command line a bunch of times, which should create a bunch of tabs.  Make sure you close all these new tabs that pop up.a  Check /proc/<pid>/fd/ to see how many descriptors there are.  There shouldn't be many more (although some of the new renderers that got created take awhile because they get cleaned up).  Keep repeating, you should be at a steady state of file descriptors.

Review URL: http://codereview.chromium.org/112054
------------------------------------------------------------------------
r16810 | ben@chromium.org | 2009-05-23 01:00:38 +0200 (Sat, 23 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/tab_contents
   A /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container.h
   A /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc
   A /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h
   A /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.cc
   A /trunk/src/chrome/browser/views/tab_contents/native_tab_contents_container_win.h
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.cc
   A /trunk/src/chrome/browser/views/tab_contents/tab_contents_container.h
   D /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   D /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/chrome.gyp

Refactors TabContentsContainerView into TabContentsContainer and associated platform-specific inner classes.

BUG=none
TEST=make sure web page focus cycling in and out of the content area still works.

Review URL: http://codereview.chromium.org/113784
------------------------------------------------------------------------
r16809 | brettw@chromium.org | 2009-05-23 01:00:22 +0200 (Sat, 23 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/views/controls/button/menu_button.h

Some more porting of browser_views.
Review URL: http://codereview.chromium.org/113794
------------------------------------------------------------------------
r16808 | michaeln@google.com | 2009-05-23 01:00:09 +0200 (Sat, 23 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/npruntime_util.cc
   M /trunk/src/webkit/glue/npruntime_util.h

CPAPI gears drag drop and renderer IPC.

CPAPI (0.10) functions for gears drag drop; one to extract thedrag type/data given an NPObject *event, one to override thedrop effect (drag cursor).

Gears drag drop API receives a browser event as an NPObject* sothe event is untrusted.  Provide IPC calls to the renderer sogears can pass the event to renderer/V8 for checking, prior todrag type/data extraction, or the setting of the drop effect.

Original patch by Noel Gordon via:
http://codereview.chromium.org/99240

BUG=7995
TEST=none
Review URL: http://codereview.chromium.org/112056
------------------------------------------------------------------------
r16806 | pkasting@chromium.org | 2009-05-23 00:57:48 +0200 (Sat, 23 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/113792
------------------------------------------------------------------------
r16805 | evan@chromium.org | 2009-05-23 00:57:43 +0200 (Sat, 23 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   A /trunk/src/chrome/browser/first_run_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

linux: Implement a first run dialog.

BUG=11971

Review URL: http://codereview.chromium.org/115722
------------------------------------------------------------------------
r16803 | mirandac@chromium.org | 2009-05-23 00:52:12 +0200 (Sat, 23 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Reverting 16802.
Review URL: http://codereview.chromium.org/115726
------------------------------------------------------------------------
r16802 | mirandac@chromium.org | 2009-05-23 00:43:59 +0200 (Sat, 23 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Forces window to show and hide with native system calls at the beginning
and end of animation.  This allows the system bubble to hide and display
in systems that don't respect opacity, such as the Parallels desktop.

BUG= http://crbug.com/622
TEST=Start Chrome on a system running in a Parallels window.  Hover over
a status bubble, and move mouse away.  Status bubble should disappear.

Review URL: http://codereview.chromium.org/114046
------------------------------------------------------------------------
r16800 | thestig@chromium.org | 2009-05-22 23:55:36 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   D /trunk/src/chrome/browser/window_sizer_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Reverting 16796.
Review URL: http://codereview.chromium.org/113791
------------------------------------------------------------------------
r16799 | brettw@chromium.org | 2009-05-22 23:36:50 +0200 (Fri, 22 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix the Windows build by adding some missing headers.
------------------------------------------------------------------------
r16798 | brettw@chromium.org | 2009-05-22 23:29:22 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc

Move more dialog showing routines to browser_dialogs.h to reduce dependencies
and make this file easier to port.
Review URL: http://codereview.chromium.org/113778
------------------------------------------------------------------------
r16797 | brettw@chromium.org | 2009-05-22 23:27:33 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/menu_win.cc

Remove some dependencies on Windows-specific files in BrowserView. The usage
of WindowWin was unnecessary so I removed it. I created a function in Menu
go get the system menu so that can be ported inside views.
Review URL: http://codereview.chromium.org/113785
------------------------------------------------------------------------
r16796 | thestig@chromium.org | 2009-05-22 23:18:28 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/window_sizer_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add a single monitor implementation of WindowSizer for Linux.

BUG=10005
Review URL: http://codereview.chromium.org/114041
------------------------------------------------------------------------
r16792 | pkasting@chromium.org | 2009-05-22 22:55:46 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/114040
------------------------------------------------------------------------
r16791 | tc@google.com | 2009-05-22 22:53:00 +0200 (Fri, 22 May 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fix a bug in popup menus where we sent the wrong mouse events coordinates to the
renderer.

gtk_grab_add() causes us to receive all events.  That means we receive
mouse events for other widgets with the coordinates relative to the other
widget.  We actually the coordinates relative to the popup.

This caused jankiness with the popup on news.google.com.  Since the popup happened to be on
the left side of the page, we sent event coordinates that happened to land in
the popup, causing us to select stuff.

BUG=12025

Review URL: http://codereview.chromium.org/113750

------------------------------------------------------------------------
r16787 | evan@chromium.org | 2009-05-22 22:32:05 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Fix mac.

TBR=eglaysher
------------------------------------------------------------------------
r16786 | finnur@chromium.org | 2009-05-22 22:28:12 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc

Fix bug 12468 where F3 (FindNext) in a brand new tab was not using prepopulated search (what you have searched for in other tabs).

TEST=Covered by in-process-browser test now. To test manually: open a tab, search for something in FindInPage, Press Ctrl+T and then F3. It should search for the same thing in the newly opened tab. 
BUG=12468

Review URL: http://codereview.chromium.org/115714
------------------------------------------------------------------------
r16783 | evan@chromium.org | 2009-05-22 22:19:39 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/first_run_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Refactor the FirstRun code into Windows-specific and portable.

BUG=11971
TEST=fresh install of Chrome should still bring up the first run dialog

Review URL: http://codereview.chromium.org/115689
------------------------------------------------------------------------
r16779 | estade@chromium.org | 2009-05-22 21:56:42 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc

Fix insidious typo from r16329

TBR=erg
BUG=12533

Review URL: http://codereview.chromium.org/113781
------------------------------------------------------------------------
r16777 | pkasting@chromium.org | 2009-05-22 21:51:21 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/115673
------------------------------------------------------------------------
r16776 | shess@chromium.org | 2009-05-22 21:40:11 +0200 (Fri, 22 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Overhaul omnibox focus detection on Mac.

Rather than aiming to detect acquisition and loss of focus in
|field_|, just acknowledge that there are cases where |field_| has
focus but |model_| doesn't know.  If |field_| has focus but no editing
has been done, then |model_| will take no action, so this is
reasonable.

Window resigning key just closes the popup, and doesn't affect
|model_| focus.  Thus, there is no need to deal with acquiring focus
when the window becomes key again, and we can live fine within the
constraints of -*DidBeginEditing: and -*ShouldEndEditing:.

Added checks for |field_| being focussed in all the relevant places.

http://crbug.com/12338

Review URL: http://codereview.chromium.org/113746
------------------------------------------------------------------------
r16775 | jam@chromium.org | 2009-05-22 21:38:21 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy_browser_test.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   A /trunk/src/chrome/browser/renderer_host/web_cache_manager_browser_test.cc
   M /trunk/src/chrome/test/browser/browser_tests_dll.vcproj
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Fix crash as a result of my previous change to fix the memory leak in WebCacheManager.

BUG=12362
TEST=added regression test
Review URL: http://codereview.chromium.org/113754
------------------------------------------------------------------------
r16772 | tim@chromium.org | 2009-05-22 21:28:00 +0200 (Fri, 22 May 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

Don't allow duplicate bookmark node ids by always assigning ids with the ones generated by the codec.

The bookmark bar and other bookmarks nodes get initialized
by the model to ids 1 and 2, respectively.  Later, when the
BookmarkCodec is decoding, it starts with the bookmark bar which
has id 1, but continues depth-first from this node instead of
handling other_bookmarks next.  This means the first child of
the bookmark bar gets id 2, and this was colliding with
other_bookmarks because the codec wasn't overwriting the id
when a valid |node| is passed in.  In other words, two exclusive
unique ID generators are not better than one. 

I considered other things, like calling RecordId on the id_generator
for the "special node" ids, but that caused PersistIds test to fail.
Also considered special-casing the two special nodes in Decode, but
those attempts felt either more subtle or lame than this one.

TEST=BookmarkModelTestWithProfile.CreateAndRestore


Review URL: http://codereview.chromium.org/115696
------------------------------------------------------------------------
r16768 | mpcomplete@google.com | 2009-05-22 21:02:19 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/utility_process_host.cc
   M /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/common/extensions/extension_unpacker.cc
   M /trunk/src/chrome/common/extensions/extension_unpacker.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/test/data/extensions/page_action.crx
   M /trunk/src/chrome/utility/utility_thread.cc

Have the browser process rewrite manifest.json and theme/page action images
that the extension unpacker process parsed.

BUG=11680
Review URL: http://codereview.chromium.org/115595
------------------------------------------------------------------------
r16767 | pkasting@chromium.org | 2009-05-22 20:41:32 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.h

Use a NotificationRegistrar to listen for notifications.BUG=2381
Review URL: http://codereview.chromium.org/113743
------------------------------------------------------------------------
r16765 | idanan@chromium.org | 2009-05-22 20:39:38 +0200 (Fri, 22 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Issue 12160: Crash

This represents crash #8 of the 2.0.180 branch, likely to
be caused by people playing with themese or have downloaded
a DLL to replace the Chrome theme from somewhere other than
us. No repro-steps, so the best is to avoid the problem.

BUG=12160
TEST=none

Review URL: http://codereview.chromium.org/115523
------------------------------------------------------------------------
r16764 | jeremy@chromium.org | 2009-05-22 20:38:25 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Respect the kNoFirstRun flag on Mac to not display the UI.  This should help solve a problem around this area with the release builders.

Review URL: http://codereview.chromium.org/113775
------------------------------------------------------------------------
r16762 | agl@chromium.org | 2009-05-22 20:23:58 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html

Linux: update splash page to mention lack of Gears support.

TBR=dean
BUG=12058

------------------------------------------------------------------------
r16761 | brettw@google.com | 2009-05-22 20:15:24 +0200 (Fri, 22 May 2009) | 16 lines
Changed paths:
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/app/gfx/text_elider.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc


Shows Unicode IDN instead of Punycode in the followings:
 - Bookmark Manager
 - Edit Bookmark dialog opened by Bookmark Manager
 - Edit Bookmark dialog opened by the star on the left of the address bar

Introduces new function, net::FormatUrl(), which has the following
parameters in addition to gfx::GetCleanStringFromUrl().
 - bool omit_username_password
 - bool unescape
and moves gfx::GetClienStringFromUrl() to net:: namespace, and removed
the last two parameters.

BUG=3991
Checked in for tkent
Original review = http://codereview.chromium.org/115346
------------------------------------------------------------------------
r16760 | brettw@google.com | 2009-05-22 20:15:16 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h

Middle clicking on a bookmark from the bookmark manager now
opens that bookmark in a new foreground tab.

http://crbug.com/7788
Checked in for Meelap Shah
Original review = http://codereview.chromium.org/115665
------------------------------------------------------------------------
r16759 | agl@chromium.org | 2009-05-22 20:14:04 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash-chrome.html
   M /trunk/src/chrome/browser/resources/linux-splash.html

Linux: update the splash page.

http://codereview.chromium.org/113769
BUG=12058

------------------------------------------------------------------------
r16758 | shess@chromium.org | 2009-05-22 20:13:34 +0200 (Fri, 22 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Mac: Fix so the omnibox popup doesn't show all tiny first time.

Also improve the code which sizes the popup.

http://crbug.com/12324
TEST=In previous release, start typing in omnibox.  Should see a 6-pixel-tall or so popup which is quickly replaced with the real popup.  With this fix, should not see the incorrect version.

Review URL: http://codereview.chromium.org/113644
------------------------------------------------------------------------
r16757 | sky@chromium.org | 2009-05-22 20:13:28 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h

Moves decoding and population of bookmark index to background thread.

BUG=6646
TEST=make sure bookmarks persist after running chrome.

Review URL: http://codereview.chromium.org/113768
------------------------------------------------------------------------
r16756 | asargent@chromium.org | 2009-05-22 20:09:43 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/test_url_fetcher_factory.h

Fix some outdated comments.

The URLFetcher::SetFactory method was renamed to URLFetcher::set_factory
at some point. I'm just fixing the comments here.

Review URL: http://codereview.chromium.org/113681
------------------------------------------------------------------------
r16755 | erg@google.com | 2009-05-22 20:08:21 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

GTK: Force the text color in the status bubble to be the same as windows.

Review URL: http://codereview.chromium.org/115710
------------------------------------------------------------------------
r16754 | robertshield@google.com | 2009-05-22 20:08:17 +0200 (Fri, 22 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/automation_constants.cc (from /trunk/src/chrome/common/automation_constants.cc:16741)
   A /trunk/src/chrome/common/automation_constants.h (from /trunk/src/chrome/common/automation_constants.h:16741)
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Re-do of r16741 (http://codereview.chromium.org/113482).

Moved the new automation message in automation_messages_internal.h to the END of the enum as per the large scary warning that I skillfully missed last time around.

TBR=amit

Review URL: http://codereview.chromium.org/115711
------------------------------------------------------------------------
r16753 | pinkerton@chromium.org | 2009-05-22 20:05:31 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Fix a lot of jankiness during tab dragging. Fix dragging last tab in a different way (overlay view) so we can continue to use the "sprouting up" new tab animation. Improved animation with placeholder so it's smoother. Fixed jank closing and tearing off windows by suppressing window updates. Patch from alcor@google.com
BUG=none
TEST=tab dragging w/in a window, between windows. Creating new tabs. Closing window with lots of tabs. 
------------------------------------------------------------------------
r16751 | pkasting@chromium.org | 2009-05-22 19:30:56 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/113745
------------------------------------------------------------------------
r16749 | hbono@chromium.org | 2009-05-22 19:10:11 +0200 (Fri, 22 May 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h

- Passing correct window handle to CreateChromeWindow(). We should pass the
handle of "Fonts and Languages" window to the function, but currently, a handle
of a widget inside the window is passed.
- Remove GetRootWindow() method from options_page_view.h since the function
returns HWND and thus isn't portable. We can simply use
GetWindow()->GetNativeWindow() instead.

BUG=10923
TEST=Open "Languages" dialog (Options - Minor Tweaks - Change font and language
settings - Languages tab - Add), then press Alt+Tab to switch to an another
application, press Alt+Tab again to switch back to chromium, press "Cancel" on
the dialog and verify that the "Fonts and Languages" window is focused.

Original patch created by Yusuke Sato. http://codereview.chromium.org/93097
R=me,ben
Review URL: http://codereview.chromium.org/115687
------------------------------------------------------------------------
r16746 | stuartmorgan@chromium.org | 2009-05-22 18:36:30 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Support middle-click-to-close on the Mac.

BUG=11146
TEST=Middle-clicking a tab should close it (any other mouse buttons should not).
Review URL: http://codereview.chromium.org/115683
------------------------------------------------------------------------
r16744 | stuartmorgan@chromium.org | 2009-05-22 18:28:52 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/tools/valgrind/suppressions_mac.txt

Fix a leak in BookmarkBarController, and remove the valgrind suppression for it.

BUG=11286
Review URL: http://codereview.chromium.org/113742
------------------------------------------------------------------------
r16743 | brettw@chromium.org | 2009-05-22 18:19:54 +0200 (Fri, 22 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/test_browser_window.h

Move a bunch of dialog creation routines to browser_dialogs.h to break the
dependency on the implementations of those views.

This also moves that file into the browser:: namespace to avoid having all the
functions in the global namespace.

Rename the "parent" parameter to ShowHTMLDialog to a NativeWindow type to
avoid nasty casting. I assume this argument was written before we had
NativeWindow.
Review URL: http://codereview.chromium.org/113728
------------------------------------------------------------------------
r16742 | robertshield@google.com | 2009-05-22 18:13:30 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/automation_constants.cc
   D /trunk/src/chrome/common/automation_constants.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Revert of r16741 which appeared to cause a perf regression (???) on the builder. 

TBR=thomasvl

Review URL: http://codereview.chromium.org/115708
------------------------------------------------------------------------
r16741 | robertshield@google.com | 2009-05-22 17:00:26 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/automation_constants.cc
   A /trunk/src/chrome/common/automation_constants.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Adding the ability to alter Chrome's proxy settings via the automation interface for automated testing.

Review URL: http://codereview.chromium.org/113482
------------------------------------------------------------------------
r16740 | apavlov@chromium.org | 2009-05-22 16:49:42 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h

Fix remote debugger detachment sequence according to the latest DevTools changes
Review URL: http://codereview.chromium.org/113765
------------------------------------------------------------------------
r16739 | sdoyon@chromium.org | 2009-05-22 16:37:39 +0200 (Fri, 22 May 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_service_linux_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/run_all_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Fix gconf for the linux proxy config service.

-Reenables fetching of settings from gconf.

-Moves all gconf access to happen from the UI thread only, (where
 the default glib main loop runs).

-Adds support for gconf notifications, avoiding having to poll the settings.

-Fixes a small initialization glitch in the unittest. Plus minor code style tweaks.

-Permanently removes gdk and glib threading initialization calls that
 were previously disabled.

-Slight reorganization of ProxyService creation to pass down the IO
 thread MessageLoop.

BUG=11111
TEST=none

Review URL: http://codereview.chromium.org/113043
------------------------------------------------------------------------
r16735 | pfeldman@chromium.org | 2009-05-22 10:53:27 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Handle Browser::FEATURE_TOOLBAR and Browser::FEATURE_LOCATIONBAR in browser_window_gtk. This change makes Dev Tools window look much nicer.

Review URL: http://codereview.chromium.org/113703
------------------------------------------------------------------------
r16729 | abarth@chromium.org | 2009-05-22 08:16:13 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc

Fix crash when updating a navigation entry without a site_instance.

R=creis
BUG=http://crbug.com/12423

Review URL: http://codereview.chromium.org/115695
------------------------------------------------------------------------
r16727 | abarth@chromium.org | 2009-05-22 07:49:45 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/navigation_controller_unittest.cc
   D /trunk/src/chrome/browser/navigation_entry_unittest.cc
   A /trunk/src/chrome/browser/tab_contents/navigation_controller_unittest.cc (from /trunk/src/chrome/browser/navigation_controller_unittest.cc:16720)
   A /trunk/src/chrome/browser/tab_contents/navigation_entry_unittest.cc (from /trunk/src/chrome/browser/navigation_entry_unittest.cc:16720)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move more misplaced tests.

TBR=creis
TEST=No behavior change.

Review URL: http://codereview.chromium.org/113755
------------------------------------------------------------------------
r16721 | abarth@chromium.org | 2009-05-22 06:19:11 +0200 (Fri, 22 May 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/site_instance_unittest.cc
   A /trunk/src/chrome/browser/tab_contents/site_instance_unittest.cc (from /trunk/src/chrome/browser/site_instance_unittest.cc:16720)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move site_instance_unittest.cc next to site_instance.cc

TBR=creis
TEST=No behavior change.


Review URL: http://codereview.chromium.org/115691
------------------------------------------------------------------------
r16719 | agl@chromium.org | 2009-05-22 05:37:45 +0200 (Fri, 22 May 2009) | 66 lines
Changed paths:
   M /trunk/src/breakpad/breakpad.gyp
   A /trunk/src/breakpad/linux
   A /trunk/src/breakpad/linux/directory_reader.h
   A /trunk/src/breakpad/linux/directory_reader_unittest.cc
   A /trunk/src/breakpad/linux/exception_handler.cc
   A /trunk/src/breakpad/linux/exception_handler.h
   A /trunk/src/breakpad/linux/exception_handler_unittest.cc
   A /trunk/src/breakpad/linux/generate-test-dump.cc
   A /trunk/src/breakpad/linux/line_reader.h
   A /trunk/src/breakpad/linux/line_reader_unittest.cc
   A /trunk/src/breakpad/linux/linux_dumper.cc
   A /trunk/src/breakpad/linux/linux_dumper.h
   A /trunk/src/breakpad/linux/linux_dumper_unittest.cc
   A /trunk/src/breakpad/linux/linux_libc_support.h
   A /trunk/src/breakpad/linux/linux_libc_support_unittest.cc
   A /trunk/src/breakpad/linux/linux_syscall_support.h
   A /trunk/src/breakpad/linux/memory.h
   A /trunk/src/breakpad/linux/memory_unittest.cc
   A /trunk/src/breakpad/linux/minidump-2-core.cc
   A /trunk/src/breakpad/linux/minidump_file_writer.cc
   A /trunk/src/breakpad/linux/minidump_format_linux.h
   A /trunk/src/breakpad/linux/minidump_writer.cc
   A /trunk/src/breakpad/linux/minidump_writer.h
   A /trunk/src/breakpad/linux/minidump_writer_unittest.cc
   M /trunk/src/build/all.gyp
   M /trunk/src/build/common.gypi
   A /trunk/src/chrome/app/breakpad_linux.cc
   A /trunk/src/chrome/app/breakpad_linux.h
   A /trunk/src/chrome/app/breakpad_linux_stub.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   A /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.cc
   A /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux.h
   A /trunk/src/chrome/browser/renderer_host/render_crash_handler_host_linux_stub.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/renderer/render_crash_handler_linux.cc
   A /trunk/src/chrome/renderer/render_crash_handler_linux.h
   A /trunk/src/chrome/renderer/render_crash_handler_linux_stub.cc
   M /trunk/src/chrome/renderer/renderer_logging_linux.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Linux: add Breakpad support

This commits a rewrite of the Breakpad Linux client.

The old code:
 * Had a number of plain bugs in it, but those could just have been
   fixed.
 * Allocated memory from the heap, which is a no go.
 * Made libc calls which can enter the dynamic linker - another source
   of crashes.
 * Didn't understand some of the tricks needed, like clone() via libc
   will write to random areas of memory because it assumes that it's
   only called from libpthread

Additionally, we had one more requirement which meant changing the
interface:
 * We need to be able to crash dump the renderers from the browser
   process.

And that last one really needed a rewrite.

We intend to try and upstream this new code into Breakpad.

The new Breakpad design works like this:

When a renderer crashes, a signal handler runs on an alternative stack
and collects information about the registers of the thread before the
crash. Then we enter Chromium specific code an send a datagram message
to a magic file descriptor (4) containing:
  * the registers and tid of the crashing thread
  * the active URL
  * a file descriptor to a socket
  * a CREDENTIALS structure giving the PID of the renderer.

On the other end of the socket is an object on the IO thread
(render_crash_handler_host_linux.cc) which reads and parses the
datagram. The CREDENTIALS structure is validated by the kernel, so the
renderer can't lie about it's PID and try and get the browser to crash
dump the wrong process.

The browser then ptraces the renderer and extracts all the needed
information to write a minidump to a temp file. Then we write a byte
to the file descriptor which the renderer gave the browser in the
datagram and that's the signal to the renderer to finish dying. It
dies by sending itself the same signal which trigger the crash dump in
the first place, so it will appear to crash as normal as far as kernel
core dumps and waitpid are concerned.

The browser then constucts a MIME message in a temp file for upload to
the crash service. We then fork out to /usr/bin/wget to actually do
the upload (since Debian numbers suggest that 99.8% of users have wget
installed.) A second forked child unlinks the temp files once wget has
completed.

For a browser crash, everything works pretty much the same except that
the datagram step is omitted and we clone() off a process to ptrace
ourselves and write the minidump.

This code is only enabled in Chrome branded builds. Stub source files
are substituted in the case of a Chromium build.

 http://codereview.chromium.org/115526

BUG=9646,10772
TEST=Build a Chrome branded binary. Send SEGV to a renderer and verify that wget output appears on stderr. Send a SEGV to the main binary and verify the same.

------------------------------------------------------------------------
r16715 | pkasting@chromium.org | 2009-05-22 05:18:33 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/115668
------------------------------------------------------------------------
r16714 | pkasting@chromium.org | 2009-05-22 05:18:21 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/112051
------------------------------------------------------------------------
r16713 | pkasting@chromium.org | 2009-05-22 05:06:57 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Try to fix test bustage

------------------------------------------------------------------------
r16711 | evan@chromium.org | 2009-05-22 04:27:51 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h

Revert "Revert "Use a NotificationRegistrar to listen for notifications.""

This re-applies r16709.
------------------------------------------------------------------------
r16710 | evan@chromium.org | 2009-05-22 04:11:23 +0200 (Fri, 22 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h

Revert "Use a NotificationRegistrar to listen for notifications."

This reverts commit r16709 (on pkasting's request).
------------------------------------------------------------------------
r16709 | pkasting@chromium.org | 2009-05-22 04:02:34 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/113744
------------------------------------------------------------------------
r16708 | evan@chromium.org | 2009-05-22 04:02:18 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/build/linux/system.gyp
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   A /trunk/src/chrome/browser/password_manager/password_store.cc
   A /trunk/src/chrome/browser/password_manager/password_store.h
   A /trunk/src/chrome/browser/password_manager/password_store_default.cc
   A /trunk/src/chrome/browser/password_manager/password_store_default.h
   A /trunk/src/chrome/browser/password_manager/password_store_gnome.cc
   A /trunk/src/chrome/browser/password_manager/password_store_gnome.h
   A /trunk/src/chrome/browser/password_manager/password_store_kwallet.cc
   A /trunk/src/chrome/browser/password_manager/password_store_kwallet.h
   A /trunk/src/chrome/browser/password_manager/password_store_win.cc
   A /trunk/src/chrome/browser/password_manager/password_store_win.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h

Patch to make password patch build.

Review URL: http://codereview.chromium.org/113710
Patch from John Maguire <johnmaguire@google.com>.
------------------------------------------------------------------------
r16707 | jeremy@chromium.org | 2009-05-22 04:02:00 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_mac.h
   M /trunk/src/chrome/app/breakpad_mac.mm
   M /trunk/src/chrome/app/breakpad_mac_stubs.mm
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/renderer/renderer_logging_mac.mm

1)When we enabled breakpad on first run we weren't correctly setting the process type.
2)Fixed another logic inversion in SetActiveRendererURL.
3)Change IsCrashReporterEnabled-> IsCrashReporterDisabled to prevent future confusion since that was the question all the callers where askign anyway.

Review URL: http://codereview.chromium.org/113737
------------------------------------------------------------------------
r16705 | pkasting@chromium.org | 2009-05-22 03:56:42 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc

Fix build break

------------------------------------------------------------------------
r16704 | pkasting@chromium.org | 2009-05-22 03:53:18 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.cc
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/115676
------------------------------------------------------------------------
r16703 | pkasting@chromium.org | 2009-05-22 03:53:02 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_controller.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/114039
------------------------------------------------------------------------
r16702 | pkasting@chromium.org | 2009-05-22 03:52:43 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/113738
------------------------------------------------------------------------
r16701 | pkasting@chromium.org | 2009-05-22 03:48:43 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h

More NotificationRegistrar conversions.

BUG=2381
Review URL: http://codereview.chromium.org/115675
------------------------------------------------------------------------
r16700 | pkasting@chromium.org | 2009-05-22 03:47:27 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc

More NotificationRegistrar conversions.

BUG=2381
Review URL: http://codereview.chromium.org/113736
------------------------------------------------------------------------
r16699 | pkasting@chromium.org | 2009-05-22 03:47:16 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h

More NotificationRegistrar conversions.

BUG=2381
Review URL: http://codereview.chromium.org/115674
------------------------------------------------------------------------
r16697 | pkasting@chromium.org | 2009-05-22 03:40:44 +0200 (Fri, 22 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Missed a case when converting this file to NotificationRegistrar.

BUG=2381
Review URL: http://codereview.chromium.org/113735
------------------------------------------------------------------------
r16694 | evan@chromium.org | 2009-05-22 03:37:19 +0200 (Fri, 22 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/clear_browsing_data_dialog_gtk.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/chrome.gyp

Implement clear browsing data dialog in linux

As well, refactored code on the windows side to reuse some functionality for the deletion range specified by its time period.

BUG=11192 (http://crbug.com/11192)
TEST=Looks pretty

Review URL: http://codereview.chromium.org/113558
Patch from Mohamed Mansour <m0.interactive@gmail.com>.
------------------------------------------------------------------------
r16693 | pkasting@chromium.org | 2009-05-22 03:33:12 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Try to fix a )#%&*^)*(&%#%^ build break

------------------------------------------------------------------------
r16691 | pkasting@chromium.org | 2009-05-22 03:22:35 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Try to fix compile bustage by brute force

------------------------------------------------------------------------
r16690 | pkasting@chromium.org | 2009-05-22 03:16:06 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Disable a failing test to open the tree.

------------------------------------------------------------------------
r16689 | tc@google.com | 2009-05-22 03:12:54 +0200 (Fri, 22 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

Revert "Revert "Use a NotificationRegistrar to listen for notifications. BUG=2381""
This reverts commit r16687 (i.e., relands r16666).

TBR=pkasting

Review URL: http://codereview.chromium.org/115686

------------------------------------------------------------------------
r16687 | tc@google.com | 2009-05-22 02:55:36 +0200 (Fri, 22 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

Revert "Use a NotificationRegistrar to listen for notifications.BUG=2381"
This reverts commit r16666.

TBR=pkasting

Review URL: http://codereview.chromium.org/115684

------------------------------------------------------------------------
r16686 | pkasting@chromium.org | 2009-05-22 02:08:20 +0200 (Fri, 22 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Try to make Mac unittest crash into a failure

------------------------------------------------------------------------
r16683 | finnur@chromium.org | 2009-05-22 01:24:43 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   A /trunk/src/chrome/test/data/find_in_page/move_if_obscuring.html

Find box regression: Doesn't move if obscuring. The problem is that we get multiple messages from the renderer about the status of the find operation and some contain the selection rect (others don't). Therefore, we have to use the last known good selection rect if none is passed in.

BUG=12463
TEST=Covered by in-process browser test now.

Review URL: http://codereview.chromium.org/115667
------------------------------------------------------------------------
r16682 | estade@chromium.org | 2009-05-22 01:24:22 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: respect webkit resize requests for autocomplete popups.

BUG=http://crbug.com/12430
TEST=see bug

Review URL: http://codereview.chromium.org/115669
------------------------------------------------------------------------
r16680 | ben@chromium.org | 2009-05-22 01:03:04 +0200 (Fri, 22 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Fix bustage in toolkit views build caused by lack of #ifdef OS_WIN

TBR=sky

Review URL: http://codereview.chromium.org/113739
------------------------------------------------------------------------
r16677 | ben@chromium.org | 2009-05-22 00:40:05 +0200 (Fri, 22 May 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/app/theme/app_top_center.png
   D /trunk/src/chrome/app/theme/app_top_left.png
   D /trunk/src/chrome/app/theme/app_top_right.png
   D /trunk/src/chrome/app/theme/close.png
   D /trunk/src/chrome/app/theme/close_h.png
   D /trunk/src/chrome/app/theme/close_p.png
   D /trunk/src/chrome/app/theme/close_sa.png
   D /trunk/src/chrome/app/theme/close_sa_h.png
   D /trunk/src/chrome/app/theme/close_sa_p.png
   D /trunk/src/chrome/app/theme/content_bottom_center.png
   D /trunk/src/chrome/app/theme/content_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/content_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/content_left_side.png
   D /trunk/src/chrome/app/theme/content_right_side.png
   D /trunk/src/chrome/app/theme/default_favicon.png
   D /trunk/src/chrome/app/theme/folder_closed.png
   D /trunk/src/chrome/app/theme/folder_closed_rtl.png
   D /trunk/src/chrome/app/theme/folder_open.png
   D /trunk/src/chrome/app/theme/folder_open_rtl.png
   D /trunk/src/chrome/app/theme/input_alert.png
   D /trunk/src/chrome/app/theme/input_good.png
   D /trunk/src/chrome/app/theme/input_unknown.png
   D /trunk/src/chrome/app/theme/maximize.png
   D /trunk/src/chrome/app/theme/maximize_h.png
   D /trunk/src/chrome/app/theme/maximize_p.png
   D /trunk/src/chrome/app/theme/menu_droparrow.png
   D /trunk/src/chrome/app/theme/minimize.png
   D /trunk/src/chrome/app/theme/minimize_h.png
   D /trunk/src/chrome/app/theme/minimize_p.png
   D /trunk/src/chrome/app/theme/restore.png
   D /trunk/src/chrome/app/theme/restore_h.png
   D /trunk/src/chrome/app/theme/restore_p.png
   D /trunk/src/chrome/app/theme/textbutton_b_h.png
   D /trunk/src/chrome/app/theme/textbutton_b_p.png
   D /trunk/src/chrome/app/theme/textbutton_bl_h.png
   D /trunk/src/chrome/app/theme/textbutton_bl_p.png
   D /trunk/src/chrome/app/theme/textbutton_br_h.png
   D /trunk/src/chrome/app/theme/textbutton_br_p.png
   D /trunk/src/chrome/app/theme/textbutton_c_h.png
   D /trunk/src/chrome/app/theme/textbutton_c_p.png
   D /trunk/src/chrome/app/theme/textbutton_l_h.png
   D /trunk/src/chrome/app/theme/textbutton_l_p.png
   D /trunk/src/chrome/app/theme/textbutton_r_h.png
   D /trunk/src/chrome/app/theme/textbutton_r_p.png
   D /trunk/src/chrome/app/theme/textbutton_t_h.png
   D /trunk/src/chrome/app/theme/textbutton_t_p.png
   D /trunk/src/chrome/app/theme/textbutton_tl_h.png
   D /trunk/src/chrome/app/theme/textbutton_tl_p.png
   D /trunk/src/chrome/app/theme/textbutton_tr_h.png
   D /trunk/src/chrome/app/theme/textbutton_tr_p.png
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   D /trunk/src/chrome/app/theme/theme_frame_default.png
   D /trunk/src/chrome/app/theme/theme_frame_default_inactive.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/app/theme/throbber.png
   D /trunk/src/chrome/app/theme/window_bottom_center.png
   D /trunk/src/chrome/app/theme/window_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/window_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/window_left_side.png
   D /trunk/src/chrome/app/theme/window_right_side.png
   D /trunk/src/chrome/app/theme/window_top_center.png
   D /trunk/src/chrome/app/theme/window_top_left_corner.png
   D /trunk/src/chrome/app/theme/window_top_right_corner.png
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/test/unit/unittests.vcproj

Make views/ depend only on images from app/resources.

Trying this again. All compile issues should be addressed, ui and unit tests now pass.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113690
------------------------------------------------------------------------
r16676 | aa@chromium.org | 2009-05-22 00:39:57 +0200 (Fri, 22 May 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/notification_type.h
   D /trunk/src/chrome/test/data/extensions/good/extension3/1.0/EXTERNAL_INSTALL
   A /trunk/src/chrome/test/data/extensions/good2.crx

Hook up more of extension uninstall.

Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.

Review URL: http://codereview.chromium.org/113493
------------------------------------------------------------------------
r16672 | ericroman@google.com | 2009-05-22 00:03:00 +0200 (Fri, 22 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/net/base/auth.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/http/http_auth_handler_digest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/proxy/proxy_server.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc

Changes the UI for HTTP/FTP auth challenges to include the server's port. So instead of "www.foo.com" it will say "www.foo.com:80". We need to include the port number since otherwise it can be ambiguous what the actual target server is.

This change also introduces utility function "GetHostAnd[Optional]Port()" to help with forming <host> [":" <port>] strings.

BUG=12073
Review URL: http://codereview.chromium.org/112041
------------------------------------------------------------------------
r16671 | pinkerton@chromium.org | 2009-05-21 23:57:48 +0200 (Thu, 21 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Put back in code that installs ThrobberView, but comment out timer. Add a big comment about why this is so slow. BUG=none TEST=none.
------------------------------------------------------------------------
r16669 | jeremy@chromium.org | 2009-05-21 23:49:05 +0200 (Thu, 21 May 2009) | 19 lines
Changed paths:
   M /trunk/src/base/message_pump_mac.mm
   M /trunk/src/chrome/app/breakpad_mac.mm
   A /trunk/src/chrome/app/nibs/en.lproj/FirstRunDialog.xib
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/cocoa/first_run_dialog.h
   A /trunk/src/chrome/browser/cocoa/first_run_dialog.mm
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm
   A /trunk/src/chrome/browser/first_run_mac.mm
   M /trunk/src/chrome/browser/google_update_settings_mac.mm
   M /trunk/src/chrome/browser/google_update_settings_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Implement temporary First Run Dialog on OS X

We use a modal dialog with a single checkbox on OS X.

We use the OSX defaults system since we want something quick and reliable.  The
dialog is displayed at a very early stage in Chrome startup (Before any
subsystems start relying on the stats variable).  This means there are a few
quirks in displaying the UI.

A change was also needed to our event handling code since when the dialog is
shown we spin an event loop at a very early stage in the process lifetime.

Changed default value for stats to false and updated unit tests to reflect that.

Also some misc. minor cleanup.

BUG=11971,12046

Review URL: http://codereview.chromium.org/115608
------------------------------------------------------------------------
r16667 | pkasting@chromium.org | 2009-05-21 23:43:34 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/115651
------------------------------------------------------------------------
r16666 | pkasting@chromium.org | 2009-05-21 23:38:00 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

Use a NotificationRegistrar to listen for notifications.BUG=2381
Review URL: http://codereview.chromium.org/115650
------------------------------------------------------------------------
r16665 | pkasting@chromium.org | 2009-05-21 23:37:06 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/113717
------------------------------------------------------------------------
r16664 | estade@chromium.org | 2009-05-21 23:36:44 +0200 (Thu, 21 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.h

Linux: Make page/app menu buttons depress while they're showing the menus.

TEST=click the page/app menu buttons. Observe that they are looking active. Dismiss the menu. Observe that the buttons are normal again.

Review URL: http://codereview.chromium.org/113724
------------------------------------------------------------------------
r16663 | erg@google.com | 2009-05-21 23:34:32 +0200 (Thu, 21 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

GTK: Fix crash when right clicking on a tab in the tabstrip.

http://crbug.com/12439

Review URL: http://codereview.chromium.org/115661
------------------------------------------------------------------------
r16660 | sky@chromium.org | 2009-05-21 23:26:13 +0200 (Thu, 21 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Gets LocationBarView to compile on linux. PageInfoWindow is nearly
there too, but needs Separator to actually completely compile.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113720
------------------------------------------------------------------------
r16658 | pinkerton@chromium.org | 2009-05-21 23:25:28 +0200 (Thu, 21 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

More tests for tab_cold. commenting out drawRect entirely.
------------------------------------------------------------------------
r16657 | avi@chromium.org | 2009-05-21 23:24:36 +0200 (Thu, 21 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc

Allow external whitelisted protocols on the Mac.

http://crbug.com/12287

Review URL: http://codereview.chromium.org/115660
------------------------------------------------------------------------
r16656 | pkasting@chromium.org | 2009-05-21 23:21:32 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/115648
------------------------------------------------------------------------
r16655 | pkasting@chromium.org | 2009-05-21 23:15:44 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_node.cc

Take 2 on fixing Linux build

------------------------------------------------------------------------
r16654 | pkasting@chromium.org | 2009-05-21 23:06:39 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_node.cc

Fix Linux build

------------------------------------------------------------------------
r16653 | erg@google.com | 2009-05-21 22:58:12 +0200 (Thu, 21 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK: Clean up the bookmark bar context menu
- Make items that should be checkboxes into checkboxes
- Clean up accelerator spam.

Review URL: http://codereview.chromium.org/113721
------------------------------------------------------------------------
r16652 | pkasting@chromium.org | 2009-05-21 22:56:29 +0200 (Thu, 21 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_node.h

Use a NotificationRegistrar to listen for notifications.

Also clean up a bunch of code to make it shorter/clearer/more style-guide compliant.

BUG=2381
Review URL: http://codereview.chromium.org/113718
------------------------------------------------------------------------
r16651 | finnur@chromium.org | 2009-05-21 22:37:49 +0200 (Thu, 21 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc

Convert all but one Find test from ui_test to In-Process
Browser test.

I also added initialization for a struct that static code analysis complained about. Not technically needed, but harmless to add.

BUG=None
TEST=None (covered by tests already).

Review URL: http://codereview.chromium.org/115652
------------------------------------------------------------------------
r16650 | pkasting@chromium.org | 2009-05-21 22:33:17 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/115647
------------------------------------------------------------------------
r16649 | pkasting@chromium.org | 2009-05-21 22:32:21 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h

Use a NotificationRegistrar to listen for notifications.

BUG=2381
Review URL: http://codereview.chromium.org/115653
------------------------------------------------------------------------
r16647 | glen@chromium.org | 2009-05-21 22:22:48 +0200 (Thu, 21 May 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/find_dialog_left.png
   A /trunk/src/chrome/app/theme/find_dialog_middle.png
   A /trunk/src/chrome/app/theme/find_dialog_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Theme the find bar.

The image resources are additional, as we don't want to mess with Linux.

BUG=11702

Review URL: http://codereview.chromium.org/115613
------------------------------------------------------------------------
r16645 | brettw@chromium.org | 2009-05-21 22:03:56 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/views/browser_dialogs.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Remove the dependency from browser_view on the bug report dialog. I am going to
be moving more of the dialogs to this file to reduce dependencies and make it
more portable.
Review URL: http://codereview.chromium.org/113678
------------------------------------------------------------------------
r16643 | pinkerton@chromium.org | 2009-05-21 21:41:58 +0200 (Thu, 21 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Back to square zero, throbber disabled.
------------------------------------------------------------------------
r16642 | jam@chromium.org | 2009-05-21 21:39:02 +0200 (Thu, 21 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

Reverts parts of http://src.chromium.org/viewvc/chrome?view=rev&revision=16474 which aren't needed anymore.

Review URL: http://codereview.chromium.org/113669
------------------------------------------------------------------------
r16640 | finnur@chromium.org | 2009-05-21 21:26:59 +0200 (Thu, 21 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Move the validation of icons for page actions to load time.
This is in line with how we validate content scripts and
enables installing page actions as .crx filed.

BUG=None
TEST=Install a Page Action as a .crx file. It should install.

Review URL: http://codereview.chromium.org/115644
------------------------------------------------------------------------
r16638 | jam@chromium.org | 2009-05-21 21:20:20 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/notification_type.h

Ensure workers don't outlive crashed renderers.
Review URL: http://codereview.chromium.org/114035
------------------------------------------------------------------------
r16637 | willchan@chromium.org | 2009-05-21 21:06:00 +0200 (Thu, 21 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Close the old browser window after SessionRestore.
SessionRestore needs to know the last active browser in order to close it after the session restore.
Add the call to BrowserList::SetLastActive() to accomplish this.
BUG=http://www.crbug.com/12372
TEST=Crash the browser.  Open a new browser.  Click on restore.  The old browser window should close and the old session should appear in the new browser window.

Review URL: http://codereview.chromium.org/113691
------------------------------------------------------------------------
r16636 | pinkerton@chromium.org | 2009-05-21 20:56:08 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.h
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm
   M /trunk/src/chrome/chrome.gyp

Rewriting to use CIImage in hopes of better performance. Still playing with perf bot.
Review URL: http://codereview.chromium.org/115643
------------------------------------------------------------------------
r16634 | pkasting@chromium.org | 2009-05-21 20:47:14 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_constrained_window_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.cc
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/external_tab_container.cc

Use NotificationRegistrar to handle notification observing.Also cleans up some other stuff: use {} on multi-line conditional bodies, remove a bunch of unused routing_id members, don't wrap lines that don't need to, etc.BUG=2381
Review URL: http://codereview.chromium.org/115602
------------------------------------------------------------------------
r16632 | yutak@chromium.org | 2009-05-21 20:44:33 +0200 (Thu, 21 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Make the link to Chromium project page depend on UI locale.

There is a link to the Chromium project in About dialog. It should go to the project page of the current UI language.

BUG=5909
TEST=See issue 5909
Review URL: http://codereview.chromium.org/113682
------------------------------------------------------------------------
r16630 | erg@google.com | 2009-05-21 20:41:11 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

GTK: Use correct tabstrip background in Incognito mode.
http://crbug.com/12421

Review URL: http://codereview.chromium.org/115642
------------------------------------------------------------------------
r16629 | tc@google.com | 2009-05-21 20:41:02 +0200 (Thu, 21 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Remove trailing NULL is data sent between chrome processes.

Since we split on NULL, the final NULL results in an extra command
line token passed to the original browser process.

Bug found by willchan.

Review URL: http://codereview.chromium.org/113714

------------------------------------------------------------------------
r16628 | estade@chromium.org | 2009-05-21 20:41:02 +0200 (Thu, 21 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc

Remove one more notimpl.

BUG=12052

Review URL: http://codereview.chromium.org/113713
------------------------------------------------------------------------
r16627 | estade@chromium.org | 2009-05-21 20:40:46 +0200 (Thu, 21 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Enable "View page info" context menu only for pages which developer commands
are meaningful for.

"View page info" can be treated as if it were a developer command in deciding
whether to enable it. For example, viewing page info of chrome://newtab
doesn't make much sense.

Tested manually.

-------------

patch by yuzo@google.com
review url: <http://codereview.chromium.org/115563>

------------------------------------------------------------------------
r16625 | erg@google.com | 2009-05-21 19:59:33 +0200 (Thu, 21 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

GTK: Don't instantly hide the status bubble; set a callback that does it after a delay.

Review URL: http://codereview.chromium.org/115639
------------------------------------------------------------------------
r16624 | tc@google.com | 2009-05-21 19:55:53 +0200 (Thu, 21 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.h

Cleanup Import Dialog in Linux

Remove reference of gtk.h as well as unnecessary casting.

Patch by Mohamed Mansour in http://codereview.chromium.org/113616

Review URL: http://codereview.chromium.org/113711

------------------------------------------------------------------------
r16623 | estade@chromium.org | 2009-05-21 19:55:40 +0200 (Thu, 21 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

Activate download shelf button while the menu is showing.

TEST=download something. Press the down arrow button on the right of the item. A menu should popup and the button should appear to depress. The button should pop back when you close the menu (either by clicking away from it or by choosing an item in it).

Review URL: http://codereview.chromium.org/113684
------------------------------------------------------------------------
r16621 | phajdan.jr@chromium.org | 2009-05-21 19:45:05 +0200 (Thu, 21 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc

Check if the test server started successfully before using it.
Prevents a crash in unit tests.

http://crbug.com/9644

Review URL: http://codereview.chromium.org/117002
------------------------------------------------------------------------
r16616 | xji@chromium.org | 2009-05-21 19:11:21 +0200 (Thu, 21 May 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_started_animation_win.cc

This is the merge of Yusuke's patch at:
http://codereview.chromium.org/113583

Draw the big arrow animation on the right side on RTL locales.

1) The item drop down arrow resides on the right hand side of the item and 
not the left hand side.
2) The animation is drawn on the left and side instead of the right hand
side.

This patch only fixes the issue 2) above. I'll fix 1) in separate change list.

BUG=http://crbug.com/6103
TBR=Yusuke
Review URL: http://codereview.chromium.org/115609
------------------------------------------------------------------------
r16615 | pinkerton@chromium.org | 2009-05-21 19:11:01 +0200 (Thu, 21 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

commenting out setNeedsDisplay, still playing with tab_cold timing.
------------------------------------------------------------------------
r16613 | pfeldman@chromium.org | 2009-05-21 19:06:29 +0200 (Thu, 21 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window.cc

DevTools: Provide nice initial location/size for the devtools window.

Review URL: http://codereview.chromium.org/113704
------------------------------------------------------------------------
r16609 | pinkerton@chromium.org | 2009-05-21 18:29:58 +0200 (Thu, 21 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Turning timer back on, invalidating timer when removing from superview. Still playing with tab_cold perf test.
------------------------------------------------------------------------
r16608 | jrg@chromium.org | 2009-05-21 18:14:43 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Update check interval adjustment.
BUG=http://code.google.com/p/chromium/issues/detail?id=12255

Review URL: http://codereview.chromium.org/112044
------------------------------------------------------------------------
r16606 | tc@google.com | 2009-05-21 17:55:16 +0200 (Thu, 21 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Fix a invalid read found by valgrind in process singleton linux.

We set up a listener on the IO thread, but the listener lived longer
than the IO thread.  Instead, register a listener to stop listening
when the IO thread goes away.  We have to register the destruction
listener on the thread that we're listening to, so there's an new
StartListening method dispatched from ProcessSingleton::Create.

Review URL: http://codereview.chromium.org/115605

------------------------------------------------------------------------
r16605 | pinkerton@chromium.org | 2009-05-21 17:51:23 +0200 (Thu, 21 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/throbber_view.mm

Testing throbber on perf bot
------------------------------------------------------------------------
r16602 | sky@chromium.org | 2009-05-21 17:17:08 +0200 (Thu, 21 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/chrome.gyp

Gets info_bubble compiling on linux. This code has a ton of ifdefs. It
would be cleaner to refactor. I'll do that later on though. I've added
a TODO to that effect.

Review URL: http://codereview.chromium.org/113679
------------------------------------------------------------------------
r16601 | pfeldman@chromium.org | 2009-05-21 17:01:02 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

DevTools: remove Debugger menu by default.
BUG=12011

Review URL: http://codereview.chromium.org/115633
------------------------------------------------------------------------
r16600 | pinkerton@chromium.org | 2009-05-21 16:51:18 +0200 (Thu, 21 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Re-enabling throbber with some image caching. This will probably regress the tab_cold timing on the perf bot, but that's expected. Future CLs will tinker.
------------------------------------------------------------------------
r16590 | pfeldman@chromium.org | 2009-05-21 11:51:50 +0200 (Thu, 21 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_client_host.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/webkit/glue/devtools/js/net_agent.js
   M /trunk/src/webkit/glue/devtools/net_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/net_agent_impl.h

DevTools: Display main resource url as devtools window title.

Review URL: http://codereview.chromium.org/113693
------------------------------------------------------------------------
r16582 | ananta@chromium.org | 2009-05-21 07:38:33 +0200 (Thu, 21 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

The underlying view_ can be NULL while processing a ViewHostMsg_PaintRect IPC message. Attempting
to prepare a backing store for a NULL view fails and crashes subsequently due to a NULL pointer dereference.

This fixes http://code.google.com/p/chromium/issues/detail?id=12167

Bug=12167

Review URL: http://codereview.chromium.org/113677
------------------------------------------------------------------------
r16577 | brettw@chromium.org | 2009-05-21 05:43:45 +0200 (Thu, 21 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h

Try to make TextField::Controller implementors cross-platform by abstracting
away the keystroke message that is passed. It turns out implementoars only ever
check for enter and escape messages, so I wrote two functions in TextField
that will decode the new Keyboard event.

This design is not optimal. Ideally we would have something more like the
WebInputEvent so that callers can check for anything in a cross-platform way.

This was branched off from the original review:
http://codereview.chromium.org/113639
------------------------------------------------------------------------
r16575 | ben@chromium.org | 2009-05-21 05:08:16 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   D /trunk/src/app/resources/app_top_center.png
   D /trunk/src/app/resources/app_top_left.png
   D /trunk/src/app/resources/app_top_right.png
   D /trunk/src/app/resources/close.png
   D /trunk/src/app/resources/close_h.png
   D /trunk/src/app/resources/close_p.png
   D /trunk/src/app/resources/close_sa.png
   D /trunk/src/app/resources/close_sa_h.png
   D /trunk/src/app/resources/close_sa_p.png
   D /trunk/src/app/resources/content_bottom_center.png
   D /trunk/src/app/resources/content_bottom_left_corner.png
   D /trunk/src/app/resources/content_bottom_right_corner.png
   D /trunk/src/app/resources/content_left_side.png
   D /trunk/src/app/resources/content_right_side.png
   D /trunk/src/app/resources/default_favicon.png
   D /trunk/src/app/resources/folder_closed.png
   D /trunk/src/app/resources/folder_closed_rtl.png
   D /trunk/src/app/resources/folder_open.png
   D /trunk/src/app/resources/folder_open_rtl.png
   D /trunk/src/app/resources/input_alert.png
   D /trunk/src/app/resources/input_good.png
   D /trunk/src/app/resources/input_unknown.png
   D /trunk/src/app/resources/maximize.png
   D /trunk/src/app/resources/maximize_h.png
   D /trunk/src/app/resources/maximize_p.png
   D /trunk/src/app/resources/menu_droparrow.png
   D /trunk/src/app/resources/minimize.png
   D /trunk/src/app/resources/minimize_h.png
   D /trunk/src/app/resources/minimize_p.png
   D /trunk/src/app/resources/restore.png
   D /trunk/src/app/resources/restore_h.png
   D /trunk/src/app/resources/restore_p.png
   D /trunk/src/app/resources/textbutton_b_h.png
   D /trunk/src/app/resources/textbutton_b_p.png
   D /trunk/src/app/resources/textbutton_bl_h.png
   D /trunk/src/app/resources/textbutton_bl_p.png
   D /trunk/src/app/resources/textbutton_br_h.png
   D /trunk/src/app/resources/textbutton_br_p.png
   D /trunk/src/app/resources/textbutton_c_h.png
   D /trunk/src/app/resources/textbutton_c_p.png
   D /trunk/src/app/resources/textbutton_l_h.png
   D /trunk/src/app/resources/textbutton_l_p.png
   D /trunk/src/app/resources/textbutton_r_h.png
   D /trunk/src/app/resources/textbutton_r_p.png
   D /trunk/src/app/resources/textbutton_t_h.png
   D /trunk/src/app/resources/textbutton_t_p.png
   D /trunk/src/app/resources/textbutton_tl_h.png
   D /trunk/src/app/resources/textbutton_tl_p.png
   D /trunk/src/app/resources/textbutton_tr_h.png
   D /trunk/src/app/resources/textbutton_tr_p.png
   D /trunk/src/app/resources/theme_frame_default.png
   D /trunk/src/app/resources/theme_frame_default_inactive.png
   D /trunk/src/app/resources/throbber.png
   D /trunk/src/app/resources/window_bottom_center.png
   D /trunk/src/app/resources/window_bottom_left_corner.png
   D /trunk/src/app/resources/window_bottom_right_corner.png
   D /trunk/src/app/resources/window_left_side.png
   D /trunk/src/app/resources/window_right_side.png
   D /trunk/src/app/resources/window_top_center.png
   D /trunk/src/app/resources/window_top_left_corner.png
   D /trunk/src/app/resources/window_top_right_corner.png
   A /trunk/src/chrome/app/theme/app_top_center.png (from /trunk/src/chrome/app/theme/app_top_center.png:16566)
   A /trunk/src/chrome/app/theme/app_top_left.png (from /trunk/src/chrome/app/theme/app_top_left.png:16566)
   A /trunk/src/chrome/app/theme/app_top_right.png (from /trunk/src/chrome/app/theme/app_top_right.png:16566)
   A /trunk/src/chrome/app/theme/close.png (from /trunk/src/chrome/app/theme/close.png:16566)
   A /trunk/src/chrome/app/theme/close_h.png (from /trunk/src/chrome/app/theme/close_h.png:16566)
   A /trunk/src/chrome/app/theme/close_p.png (from /trunk/src/chrome/app/theme/close_p.png:16566)
   A /trunk/src/chrome/app/theme/close_sa.png (from /trunk/src/chrome/app/theme/close_sa.png:16566)
   A /trunk/src/chrome/app/theme/close_sa_h.png (from /trunk/src/chrome/app/theme/close_sa_h.png:16566)
   A /trunk/src/chrome/app/theme/close_sa_p.png (from /trunk/src/chrome/app/theme/close_sa_p.png:16566)
   A /trunk/src/chrome/app/theme/content_bottom_center.png (from /trunk/src/chrome/app/theme/content_bottom_center.png:16566)
   A /trunk/src/chrome/app/theme/content_bottom_left_corner.png (from /trunk/src/chrome/app/theme/content_bottom_left_corner.png:16566)
   A /trunk/src/chrome/app/theme/content_bottom_right_corner.png (from /trunk/src/chrome/app/theme/content_bottom_right_corner.png:16566)
   A /trunk/src/chrome/app/theme/content_left_side.png (from /trunk/src/chrome/app/theme/content_left_side.png:16566)
   A /trunk/src/chrome/app/theme/content_right_side.png (from /trunk/src/chrome/app/theme/content_right_side.png:16566)
   A /trunk/src/chrome/app/theme/default_favicon.png (from /trunk/src/chrome/app/theme/default_favicon.png:16566)
   A /trunk/src/chrome/app/theme/folder_closed.png (from /trunk/src/chrome/app/theme/folder_closed.png:16566)
   A /trunk/src/chrome/app/theme/folder_closed_rtl.png (from /trunk/src/chrome/app/theme/folder_closed_rtl.png:16566)
   A /trunk/src/chrome/app/theme/folder_open.png (from /trunk/src/chrome/app/theme/folder_open.png:16566)
   A /trunk/src/chrome/app/theme/folder_open_rtl.png (from /trunk/src/chrome/app/theme/folder_open_rtl.png:16566)
   A /trunk/src/chrome/app/theme/input_alert.png (from /trunk/src/chrome/app/theme/input_alert.png:16566)
   A /trunk/src/chrome/app/theme/input_good.png (from /trunk/src/chrome/app/theme/input_good.png:16566)
   A /trunk/src/chrome/app/theme/input_unknown.png (from /trunk/src/chrome/app/theme/input_unknown.png:16566)
   A /trunk/src/chrome/app/theme/maximize.png (from /trunk/src/chrome/app/theme/maximize.png:16566)
   A /trunk/src/chrome/app/theme/maximize_h.png (from /trunk/src/chrome/app/theme/maximize_h.png:16566)
   A /trunk/src/chrome/app/theme/maximize_p.png (from /trunk/src/chrome/app/theme/maximize_p.png:16566)
   A /trunk/src/chrome/app/theme/menu_droparrow.png (from /trunk/src/chrome/app/theme/menu_droparrow.png:16566)
   A /trunk/src/chrome/app/theme/minimize.png (from /trunk/src/chrome/app/theme/minimize.png:16566)
   A /trunk/src/chrome/app/theme/minimize_h.png (from /trunk/src/chrome/app/theme/minimize_h.png:16566)
   A /trunk/src/chrome/app/theme/minimize_p.png (from /trunk/src/chrome/app/theme/minimize_p.png:16566)
   A /trunk/src/chrome/app/theme/restore.png (from /trunk/src/chrome/app/theme/restore.png:16566)
   A /trunk/src/chrome/app/theme/restore_h.png (from /trunk/src/chrome/app/theme/restore_h.png:16566)
   A /trunk/src/chrome/app/theme/restore_p.png (from /trunk/src/chrome/app/theme/restore_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_b_h.png (from /trunk/src/chrome/app/theme/textbutton_b_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_b_p.png (from /trunk/src/chrome/app/theme/textbutton_b_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_bl_h.png (from /trunk/src/chrome/app/theme/textbutton_bl_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_bl_p.png (from /trunk/src/chrome/app/theme/textbutton_bl_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_br_h.png (from /trunk/src/chrome/app/theme/textbutton_br_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_br_p.png (from /trunk/src/chrome/app/theme/textbutton_br_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_c_h.png (from /trunk/src/chrome/app/theme/textbutton_c_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_c_p.png (from /trunk/src/chrome/app/theme/textbutton_c_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_l_h.png (from /trunk/src/chrome/app/theme/textbutton_l_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_l_p.png (from /trunk/src/chrome/app/theme/textbutton_l_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_r_h.png (from /trunk/src/chrome/app/theme/textbutton_r_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_r_p.png (from /trunk/src/chrome/app/theme/textbutton_r_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_t_h.png (from /trunk/src/chrome/app/theme/textbutton_t_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_t_p.png (from /trunk/src/chrome/app/theme/textbutton_t_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_tl_h.png (from /trunk/src/chrome/app/theme/textbutton_tl_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_tl_p.png (from /trunk/src/chrome/app/theme/textbutton_tl_p.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_tr_h.png (from /trunk/src/chrome/app/theme/textbutton_tr_h.png:16566)
   A /trunk/src/chrome/app/theme/textbutton_tr_p.png (from /trunk/src/chrome/app/theme/textbutton_tr_p.png:16566)
   A /trunk/src/chrome/app/theme/theme_frame_default.png (from /trunk/src/chrome/app/theme/theme_frame_default.png:16566)
   A /trunk/src/chrome/app/theme/theme_frame_default_inactive.png (from /trunk/src/chrome/app/theme/theme_frame_default_inactive.png:16566)
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/app/theme/throbber.png (from /trunk/src/chrome/app/theme/throbber.png:16566)
   A /trunk/src/chrome/app/theme/window_bottom_center.png (from /trunk/src/chrome/app/theme/window_bottom_center.png:16566)
   A /trunk/src/chrome/app/theme/window_bottom_left_corner.png (from /trunk/src/chrome/app/theme/window_bottom_left_corner.png:16566)
   A /trunk/src/chrome/app/theme/window_bottom_right_corner.png (from /trunk/src/chrome/app/theme/window_bottom_right_corner.png:16566)
   A /trunk/src/chrome/app/theme/window_left_side.png (from /trunk/src/chrome/app/theme/window_left_side.png:16566)
   A /trunk/src/chrome/app/theme/window_right_side.png (from /trunk/src/chrome/app/theme/window_right_side.png:16566)
   A /trunk/src/chrome/app/theme/window_top_center.png (from /trunk/src/chrome/app/theme/window_top_center.png:16566)
   A /trunk/src/chrome/app/theme/window_top_left_corner.png (from /trunk/src/chrome/app/theme/window_top_left_corner.png:16566)
   A /trunk/src/chrome/app/theme/window_top_right_corner.png (from /trunk/src/chrome/app/theme/window_top_right_corner.png:16566)
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/views/DEPS
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/scroll_view.cc
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/custom_frame_view.cc

Revert 16567.

------------------------------------------------------------------------
r16574 | ben@chromium.org | 2009-05-21 05:03:17 +0200 (Thu, 21 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 16569.
Review URL: http://codereview.chromium.org/113689
------------------------------------------------------------------------
r16569 | ben@chromium.org | 2009-05-21 04:33:53 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

Fix release build by adding intermediate dir to release build include dirs too.

TBR=sky
Review URL: http://codereview.chromium.org/115620
------------------------------------------------------------------------
r16567 | ben@chromium.org | 2009-05-21 04:22:59 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/app/resources/app_resources.grd
   A /trunk/src/app/resources/app_top_center.png (from /trunk/src/chrome/app/theme/app_top_center.png:16516)
   A /trunk/src/app/resources/app_top_left.png (from /trunk/src/chrome/app/theme/app_top_left.png:16516)
   A /trunk/src/app/resources/app_top_right.png (from /trunk/src/chrome/app/theme/app_top_right.png:16516)
   A /trunk/src/app/resources/close.png (from /trunk/src/chrome/app/theme/close.png:16516)
   A /trunk/src/app/resources/close_h.png (from /trunk/src/chrome/app/theme/close_h.png:16516)
   A /trunk/src/app/resources/close_p.png (from /trunk/src/chrome/app/theme/close_p.png:16516)
   A /trunk/src/app/resources/close_sa.png (from /trunk/src/chrome/app/theme/close_sa.png:16516)
   A /trunk/src/app/resources/close_sa_h.png (from /trunk/src/chrome/app/theme/close_sa_h.png:16516)
   A /trunk/src/app/resources/close_sa_p.png (from /trunk/src/chrome/app/theme/close_sa_p.png:16516)
   A /trunk/src/app/resources/content_bottom_center.png (from /trunk/src/chrome/app/theme/content_bottom_center.png:16516)
   A /trunk/src/app/resources/content_bottom_left_corner.png (from /trunk/src/chrome/app/theme/content_bottom_left_corner.png:16516)
   A /trunk/src/app/resources/content_bottom_right_corner.png (from /trunk/src/chrome/app/theme/content_bottom_right_corner.png:16516)
   A /trunk/src/app/resources/content_left_side.png (from /trunk/src/chrome/app/theme/content_left_side.png:16516)
   A /trunk/src/app/resources/content_right_side.png (from /trunk/src/chrome/app/theme/content_right_side.png:16516)
   A /trunk/src/app/resources/default_favicon.png (from /trunk/src/chrome/app/theme/default_favicon.png:16516)
   A /trunk/src/app/resources/folder_closed.png (from /trunk/src/chrome/app/theme/folder_closed.png:16516)
   A /trunk/src/app/resources/folder_closed_rtl.png (from /trunk/src/chrome/app/theme/folder_closed_rtl.png:16516)
   A /trunk/src/app/resources/folder_open.png (from /trunk/src/chrome/app/theme/folder_open.png:16516)
   A /trunk/src/app/resources/folder_open_rtl.png (from /trunk/src/chrome/app/theme/folder_open_rtl.png:16516)
   A /trunk/src/app/resources/input_alert.png (from /trunk/src/chrome/app/theme/input_alert.png:16516)
   A /trunk/src/app/resources/input_good.png (from /trunk/src/chrome/app/theme/input_good.png:16516)
   A /trunk/src/app/resources/input_unknown.png (from /trunk/src/chrome/app/theme/input_unknown.png:16516)
   A /trunk/src/app/resources/maximize.png (from /trunk/src/chrome/app/theme/maximize.png:16516)
   A /trunk/src/app/resources/maximize_h.png (from /trunk/src/chrome/app/theme/maximize_h.png:16516)
   A /trunk/src/app/resources/maximize_p.png (from /trunk/src/chrome/app/theme/maximize_p.png:16516)
   A /trunk/src/app/resources/menu_droparrow.png (from /trunk/src/chrome/app/theme/menu_droparrow.png:16516)
   A /trunk/src/app/resources/minimize.png (from /trunk/src/chrome/app/theme/minimize.png:16516)
   A /trunk/src/app/resources/minimize_h.png (from /trunk/src/chrome/app/theme/minimize_h.png:16516)
   A /trunk/src/app/resources/minimize_p.png (from /trunk/src/chrome/app/theme/minimize_p.png:16516)
   A /trunk/src/app/resources/restore.png (from /trunk/src/chrome/app/theme/restore.png:16516)
   A /trunk/src/app/resources/restore_h.png (from /trunk/src/chrome/app/theme/restore_h.png:16516)
   A /trunk/src/app/resources/restore_p.png (from /trunk/src/chrome/app/theme/restore_p.png:16516)
   A /trunk/src/app/resources/textbutton_b_h.png (from /trunk/src/chrome/app/theme/textbutton_b_h.png:16516)
   A /trunk/src/app/resources/textbutton_b_p.png (from /trunk/src/chrome/app/theme/textbutton_b_p.png:16516)
   A /trunk/src/app/resources/textbutton_bl_h.png (from /trunk/src/chrome/app/theme/textbutton_bl_h.png:16516)
   A /trunk/src/app/resources/textbutton_bl_p.png (from /trunk/src/chrome/app/theme/textbutton_bl_p.png:16516)
   A /trunk/src/app/resources/textbutton_br_h.png (from /trunk/src/chrome/app/theme/textbutton_br_h.png:16516)
   A /trunk/src/app/resources/textbutton_br_p.png (from /trunk/src/chrome/app/theme/textbutton_br_p.png:16516)
   A /trunk/src/app/resources/textbutton_c_h.png (from /trunk/src/chrome/app/theme/textbutton_c_h.png:16516)
   A /trunk/src/app/resources/textbutton_c_p.png (from /trunk/src/chrome/app/theme/textbutton_c_p.png:16516)
   A /trunk/src/app/resources/textbutton_l_h.png (from /trunk/src/chrome/app/theme/textbutton_l_h.png:16516)
   A /trunk/src/app/resources/textbutton_l_p.png (from /trunk/src/chrome/app/theme/textbutton_l_p.png:16516)
   A /trunk/src/app/resources/textbutton_r_h.png (from /trunk/src/chrome/app/theme/textbutton_r_h.png:16516)
   A /trunk/src/app/resources/textbutton_r_p.png (from /trunk/src/chrome/app/theme/textbutton_r_p.png:16516)
   A /trunk/src/app/resources/textbutton_t_h.png (from /trunk/src/chrome/app/theme/textbutton_t_h.png:16516)
   A /trunk/src/app/resources/textbutton_t_p.png (from /trunk/src/chrome/app/theme/textbutton_t_p.png:16516)
   A /trunk/src/app/resources/textbutton_tl_h.png (from /trunk/src/chrome/app/theme/textbutton_tl_h.png:16516)
   A /trunk/src/app/resources/textbutton_tl_p.png (from /trunk/src/chrome/app/theme/textbutton_tl_p.png:16516)
   A /trunk/src/app/resources/textbutton_tr_h.png (from /trunk/src/chrome/app/theme/textbutton_tr_h.png:16516)
   A /trunk/src/app/resources/textbutton_tr_p.png (from /trunk/src/chrome/app/theme/textbutton_tr_p.png:16516)
   A /trunk/src/app/resources/theme_frame_default.png (from /trunk/src/chrome/app/theme/theme_frame_default.png:16516)
   A /trunk/src/app/resources/theme_frame_default_inactive.png (from /trunk/src/chrome/app/theme/theme_frame_default_inactive.png:16516)
   A /trunk/src/app/resources/throbber.png (from /trunk/src/chrome/app/theme/throbber.png:16516)
   A /trunk/src/app/resources/window_bottom_center.png (from /trunk/src/chrome/app/theme/window_bottom_center.png:16516)
   A /trunk/src/app/resources/window_bottom_left_corner.png (from /trunk/src/chrome/app/theme/window_bottom_left_corner.png:16516)
   A /trunk/src/app/resources/window_bottom_right_corner.png (from /trunk/src/chrome/app/theme/window_bottom_right_corner.png:16516)
   A /trunk/src/app/resources/window_left_side.png (from /trunk/src/chrome/app/theme/window_left_side.png:16516)
   A /trunk/src/app/resources/window_right_side.png (from /trunk/src/chrome/app/theme/window_right_side.png:16516)
   A /trunk/src/app/resources/window_top_center.png (from /trunk/src/chrome/app/theme/window_top_center.png:16516)
   A /trunk/src/app/resources/window_top_left_corner.png (from /trunk/src/chrome/app/theme/window_top_left_corner.png:16516)
   A /trunk/src/app/resources/window_top_right_corner.png (from /trunk/src/chrome/app/theme/window_top_right_corner.png:16516)
   D /trunk/src/chrome/app/theme/app_top_center.png
   D /trunk/src/chrome/app/theme/app_top_left.png
   D /trunk/src/chrome/app/theme/app_top_right.png
   D /trunk/src/chrome/app/theme/close.png
   D /trunk/src/chrome/app/theme/close_h.png
   D /trunk/src/chrome/app/theme/close_p.png
   D /trunk/src/chrome/app/theme/close_sa.png
   D /trunk/src/chrome/app/theme/close_sa_h.png
   D /trunk/src/chrome/app/theme/close_sa_p.png
   D /trunk/src/chrome/app/theme/content_bottom_center.png
   D /trunk/src/chrome/app/theme/content_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/content_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/content_left_side.png
   D /trunk/src/chrome/app/theme/content_right_side.png
   D /trunk/src/chrome/app/theme/default_favicon.png
   D /trunk/src/chrome/app/theme/folder_closed.png
   D /trunk/src/chrome/app/theme/folder_closed_rtl.png
   D /trunk/src/chrome/app/theme/folder_open.png
   D /trunk/src/chrome/app/theme/folder_open_rtl.png
   D /trunk/src/chrome/app/theme/input_alert.png
   D /trunk/src/chrome/app/theme/input_good.png
   D /trunk/src/chrome/app/theme/input_unknown.png
   D /trunk/src/chrome/app/theme/maximize.png
   D /trunk/src/chrome/app/theme/maximize_h.png
   D /trunk/src/chrome/app/theme/maximize_p.png
   D /trunk/src/chrome/app/theme/menu_droparrow.png
   D /trunk/src/chrome/app/theme/minimize.png
   D /trunk/src/chrome/app/theme/minimize_h.png
   D /trunk/src/chrome/app/theme/minimize_p.png
   D /trunk/src/chrome/app/theme/restore.png
   D /trunk/src/chrome/app/theme/restore_h.png
   D /trunk/src/chrome/app/theme/restore_p.png
   D /trunk/src/chrome/app/theme/textbutton_b_h.png
   D /trunk/src/chrome/app/theme/textbutton_b_p.png
   D /trunk/src/chrome/app/theme/textbutton_bl_h.png
   D /trunk/src/chrome/app/theme/textbutton_bl_p.png
   D /trunk/src/chrome/app/theme/textbutton_br_h.png
   D /trunk/src/chrome/app/theme/textbutton_br_p.png
   D /trunk/src/chrome/app/theme/textbutton_c_h.png
   D /trunk/src/chrome/app/theme/textbutton_c_p.png
   D /trunk/src/chrome/app/theme/textbutton_l_h.png
   D /trunk/src/chrome/app/theme/textbutton_l_p.png
   D /trunk/src/chrome/app/theme/textbutton_r_h.png
   D /trunk/src/chrome/app/theme/textbutton_r_p.png
   D /trunk/src/chrome/app/theme/textbutton_t_h.png
   D /trunk/src/chrome/app/theme/textbutton_t_p.png
   D /trunk/src/chrome/app/theme/textbutton_tl_h.png
   D /trunk/src/chrome/app/theme/textbutton_tl_p.png
   D /trunk/src/chrome/app/theme/textbutton_tr_h.png
   D /trunk/src/chrome/app/theme/textbutton_tr_p.png
   D /trunk/src/chrome/app/theme/theme_frame_default.png
   D /trunk/src/chrome/app/theme/theme_frame_default_inactive.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/app/theme/throbber.png
   D /trunk/src/chrome/app/theme/window_bottom_center.png
   D /trunk/src/chrome/app/theme/window_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/window_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/window_left_side.png
   D /trunk/src/chrome/app/theme/window_right_side.png
   D /trunk/src/chrome/app/theme/window_top_center.png
   D /trunk/src/chrome/app/theme/window_top_left_corner.png
   D /trunk/src/chrome/app/theme/window_top_right_corner.png
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/views/DEPS
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/scroll_view.cc
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/views.gyp
   M /trunk/src/views/window/custom_frame_view.cc

views/ should use resources from app/resources. Move dependent images to this location.

http://crbug.com/11387

------------------------------------------------------------------------
r16565 | estade@chromium.org | 2009-05-21 03:57:58 +0200 (Thu, 21 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc

Don't get stuck in an allocate loop on closing the download shelf.

Review URL: http://codereview.chromium.org/113674
------------------------------------------------------------------------
r16560 | pkasting@chromium.org | 2009-05-21 02:47:20 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Use a NotificationRegistrar to handle notification observing.

BUG=2381
Review URL: http://codereview.chromium.org/115607
------------------------------------------------------------------------
r16559 | pkasting@chromium.org | 2009-05-21 02:47:05 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h

Use NotificationRegistrar to handle notification observing.

BUG=2381
Review URL: http://codereview.chromium.org/115606
------------------------------------------------------------------------
r16557 | aa@chromium.org | 2009-05-21 02:42:29 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/good/extension3/1.0/EXTERNAL_INSTALL
   D /trunk/src/chrome/test/data/extensions/good2.crx

Revert "Hook up more of extension uninstall."
This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811.

Review URL: http://codereview.chromium.org/113680
------------------------------------------------------------------------
r16556 | erg@google.com | 2009-05-21 02:36:35 +0200 (Thu, 21 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc

Fix crash in bookmark editor. We crash when we don't have a selected folder, but we don't select
a folder by default when we're adding a new bookmark.

Review URL: http://codereview.chromium.org/115598
------------------------------------------------------------------------
r16552 | levin@chromium.org | 2009-05-21 02:30:51 +0200 (Thu, 21 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context_unittest.cc

Need to disable two print test temporarily to green the tree.

TBR=dimich
BUG=12363
TEST=none, just disabling some unit test temporarily.

Review URL: http://codereview.chromium.org/115610
------------------------------------------------------------------------
r16548 | brettw@chromium.org | 2009-05-21 00:27:11 +0200 (Thu, 21 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h

Remove widget_win.h dependency from fullscreen_exit_bubble.h. It is unused in
the header so I moved it to the .cc.
Review URL: http://codereview.chromium.org/115578
------------------------------------------------------------------------
r16547 | aa@chromium.org | 2009-05-21 00:21:30 +0200 (Thu, 21 May 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/notification_type.h
   D /trunk/src/chrome/test/data/extensions/good/extension3/1.0/EXTERNAL_INSTALL
   A /trunk/src/chrome/test/data/extensions/good2.crx

Hook up more of extension uninstall.

Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.

Review URL: http://codereview.chromium.org/113493
------------------------------------------------------------------------
r16545 | jrg@chromium.org | 2009-05-21 00:13:07 +0200 (Thu, 21 May 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/About.xib
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   A /trunk/src/chrome/browser/cocoa/about_window_controller.h
   A /trunk/src/chrome/browser/cocoa/about_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/about_window_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

About box development.
BUG=http://codereview.chromium.org/112044

Note pieces of chrome.gyp come from a different CL
(keystone_glue work associated with this).

Review URL: http://codereview.chromium.org/113614
------------------------------------------------------------------------
r16540 | jrg@chromium.org | 2009-05-20 23:23:58 +0200 (Wed, 20 May 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/app/keystone_glue.h
   M /trunk/src/chrome/app/keystone_glue.m
   A /trunk/src/chrome/app/keystone_glue_unittest.mm
   M /trunk/src/chrome/browser/browser_main_mac.mm

Development of keystone glue.
BUG=http://codereview.chromium.org/112044

chrome.gyp caught in a different CL but here is the relevant part of
the diff:

--- chrome.gyp	(revision 16158)
+++ chrome.gyp	(working copy)
@@ -2679,6 +2682,11 @@
       ],
       'sources': [
         'app/breakpad_mac_stubs.mm',
+	# *NO* files in chrome/app have unit tests (except keystone_glue)!!!
+	# It seems a waste to have an app_unittests target, so for now
+	# I add keystone_glue.m explicitly to this target.
+        'app/keystone_glue.m',
+        'app/keystone_glue_unittest.mm',
         # All unittests in browser, common, and renderer.
         'browser/autocomplete/autocomplete_unittest.cc',
         'browser/autocomplete/autocomplete_popup_view_mac_unittest.mm',

Review URL: http://codereview.chromium.org/113613
------------------------------------------------------------------------
r16539 | erg@google.com | 2009-05-20 23:21:17 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Prevent setting the checkbox value in menus from activating the menu item.

http://crbug.com/11942

Review URL: http://codereview.chromium.org/115589
------------------------------------------------------------------------
r16538 | aa@chromium.org | 2009-05-20 23:19:57 +0200 (Wed, 20 May 2009) | 4 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/good/extension3/1.0/EXTERNAL_INSTALL

TBR: Revert "Hook up more of extension uninstall."
This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a.

Review URL: http://codereview.chromium.org/113664
------------------------------------------------------------------------
r16534 | cpu@google.com | 2009-05-20 23:01:39 +0200 (Wed, 20 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_publisher_win.cc

Add HKLM + HKCU lookup for COM history indexer
- slight refactor

TEST= there are no tests
BUG= http://b/issue?id=1860803


Review URL: http://codereview.chromium.org/113605
------------------------------------------------------------------------
r16533 | estade@chromium.org | 2009-05-20 22:56:26 +0200 (Wed, 20 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Linux: reject empty file filters for file chooser dialogs.

Note that this is temporary in that, in the long run, we should be using mime type filters rather than shell-style globs.

TEST=right click/save as on a link. There should be no "*." filter.

Review URL: http://codereview.chromium.org/113660
------------------------------------------------------------------------
r16530 | jrg@chromium.org | 2009-05-20 22:50:53 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

mac_util::SetOverrideAppBundle() are handled in class ChromeTestSuite.
They should not be modified here (and especially should not be undone
in TearDown since it breaks things for following unit tests).

Review URL: http://codereview.chromium.org/115554
------------------------------------------------------------------------
r16529 | aa@chromium.org | 2009-05-20 22:47:25 +0200 (Wed, 20 May 2009) | 8 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/common/notification_type.h
   D /trunk/src/chrome/test/data/extensions/good/extension3/1.0/EXTERNAL_INSTALL

Hook up more of extension uninstall.

Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.

Review URL: http://codereview.chromium.org/113493
------------------------------------------------------------------------
r16528 | tc@google.com | 2009-05-20 22:41:00 +0200 (Wed, 20 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/chrome.gyp

Implement process singleton on linux so if the user tries to
open multiple chrome processes, the first one just opens a new window.

This is based on http://codereview.chromium.org/88067 by Nikita
Ofitserov (himikof).

BUG=8073

Review URL: http://codereview.chromium.org/115572

------------------------------------------------------------------------
r16527 | finnur@chromium.org | 2009-05-20 22:36:12 +0200 (Wed, 20 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   A /trunk/src/chrome/test/data/find_in_page/premature_end.html

Convert most of the Find UI tests to InProcBrowser tests. I might be able to convert the remaining ones, but this is enough for a first pass.

I also added a new disabled test, which will soon be enabled.

BUG=None
TEST=This whole changelist is about tests. :)

Review URL: http://codereview.chromium.org/113646
------------------------------------------------------------------------
r16526 | estade@chromium.org | 2009-05-20 22:35:52 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Enable IDC_CLOSE_WINDOW on linux.

I filed http://crbug.com/12334 to fix the ifdefed-out block in ui_test.cc.

Review URL: http://codereview.chromium.org/113655
------------------------------------------------------------------------
r16524 | estade@chromium.org | 2009-05-20 22:30:44 +0200 (Wed, 20 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

Linux: add background image theming to bookmark bar.

I got rid of the border padding in an attempt to more closely match windows, where the bookmark bar is very compact.

BUG=http://crbug.com/12216

Review URL: http://codereview.chromium.org/115551
------------------------------------------------------------------------
r16520 | jhawkins@chromium.org | 2009-05-20 22:21:13 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   A /trunk/src/chrome/browser/browser_theme_provider_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h
   M /trunk/src/chrome/chrome.gyp

Add GetPixbufNamed to ThemeProvider.  GetPixbufNamed converts a loaded theme bitmap to a GdkPixbuf and caches the image so ThemeProvider users don't need to release them ala ResourceBundle::GetPixbufNamed.
Review URL: http://codereview.chromium.org/113626
------------------------------------------------------------------------
r16519 | erg@google.com | 2009-05-20 22:21:12 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   A /trunk/src/chrome/browser/gtk/dnd_registry.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Fix crash in bookmark bar where we had conflicting ids.

http://crbug.com/12304

Review URL: http://codereview.chromium.org/115581
------------------------------------------------------------------------
r16518 | willchan@chromium.org | 2009-05-20 22:20:46 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Change RenderWidgetHostViewGtk::Destroy() to call gtk_widget_destroy().
BUG=http://www.crbug.com/11847.
TEST=Navigate to an interstitial page.  Click on Proceed.  It should not crash.

Review URL: http://codereview.chromium.org/115549
------------------------------------------------------------------------
r16505 | pinkerton@chromium.org | 2009-05-20 21:10:57 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Support multi-touch gestures for back&forward.
Review URL: http://codereview.chromium.org/115579
------------------------------------------------------------------------
r16504 | evan@chromium.org | 2009-05-20 21:09:16 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/first_run_win.cc (from /trunk/src/chrome/browser/first_run.cc:16503)

Copy first_run.cc to first_run_win.cc for history preservation.

A subsequent change will modify these files.

(Retrying previous change.)
------------------------------------------------------------------------
r16503 | evan@chromium.org | 2009-05-20 21:07:53 +0200 (Wed, 20 May 2009) | 1 line
Changed paths:
   D /trunk/src/chrome/browser/first_run_win.cc

Revert r16502.
------------------------------------------------------------------------
r16502 | evan@chromium.org | 2009-05-20 21:06:31 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/first_run_win.cc

Copy first_run.cc to first_run_win.cc for history preservation.

A subsequent change will modify these files.
------------------------------------------------------------------------
r16501 | yutak@chromium.org | 2009-05-20 20:46:05 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc

Remove unnecessary function overload in FontDisplayView.

FontDisplayView::SetFontType is overloaded and has two function signatures, but one of them became obsolete (its implementation is not synchronized with the other) and is no longer used.

TEST=none
Review URL: http://codereview.chromium.org/113610
------------------------------------------------------------------------
r16500 | avi@chromium.org | 2009-05-20 20:29:54 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm

Alert dialogs only get one button.

Review URL: http://codereview.chromium.org/113638
------------------------------------------------------------------------
r16497 | mpcomplete@google.com | 2009-05-20 20:24:14 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc

Prevent an extra copy of data types that get passed into IPC messages when
sending them.  This makes it so that types sendable via IPC no longer need
copy constructors.

BUG=12296
Review URL: http://codereview.chromium.org/112042
------------------------------------------------------------------------
r16496 | erg@google.com | 2009-05-20 20:19:13 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

GTK: Don't display empty tooltips on folders in the bookmark bar.

Review URL: http://codereview.chromium.org/115576
------------------------------------------------------------------------
r16495 | jhawkins@chromium.org | 2009-05-20 20:17:04 +0200 (Wed, 20 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Translate the canvas used to render gtk tabs by the tab bounds in order to render at (0,0) to match windows metrics.  This helps eliminate differences between the two tab rendering implementations.

TEST=Open multiple tabs.  Make sure the tabs are rendered correctly (close button, elided title text, favicon, sad tab crash animation).
Review URL: http://codereview.chromium.org/113623
------------------------------------------------------------------------
r16494 | pinkerton@chromium.org | 2009-05-20 20:09:49 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Temporarily disabling throbber to see if startup tests bot goes back to normal.
Review URL: http://codereview.chromium.org/113648
------------------------------------------------------------------------
r16491 | sky@chromium.org | 2009-05-20 20:01:28 +0200 (Wed, 20 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Moves GetFavIcon from BookmarkNode to BookmarkModel. I'm doing this
for two reasons:
. it cuts down on each node needing a reference to the model.
. it makes it clear nodes shouldn't need to talk with the model.
I'm primarily doing this for the last point as I'm going to populate
nodes on a background thread shortly and I don't want to risk the
chance of someone trying to talk with the model.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113617
------------------------------------------------------------------------
r16489 | pinkerton@chromium.org | 2009-05-20 19:59:34 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   A /trunk/src/chrome/browser/cocoa/menu_localizer.h
   A /trunk/src/chrome/browser/cocoa/menu_localizer.mm
   M /trunk/src/chrome/chrome.gyp

Use GTM's l10n class to substitute the correctly branded string for "Quit Chromium" at runtime. Update the string grd files to have this string. BUG=11486. TEST=check the quit menu item in the app menu for the correct branding.
Review URL: http://codereview.chromium.org/115574
------------------------------------------------------------------------
r16488 | shess@chromium.org | 2009-05-20 19:33:06 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Mac: Modify Omnibox to notice when the window loses key, too.

http://crbug.com/12252
TEST=Type "word" in omnibox.  Click on some other window.  Popup should dissappear.

Review URL: http://codereview.chromium.org/115573
------------------------------------------------------------------------
r16484 | shess@chromium.org | 2009-05-20 18:18:41 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Change some NOTIMPLMENTED() to tracking bugs because they are polluting the ui_tests output.

Review URL: http://codereview.chromium.org/113608
------------------------------------------------------------------------
r16483 | nsylvain@chromium.org | 2009-05-20 18:05:56 +0200 (Wed, 20 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/sandbox/sandbox.gyp
   M /trunk/src/sandbox/sandbox_poc/main_ui_window.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/spyware.cc
   M /trunk/src/sandbox/src/broker_services.cc
   M /trunk/src/sandbox/src/policy_target_test.cc
   M /trunk/src/sandbox/src/sandbox.vcproj
   M /trunk/src/sandbox/src/sandbox_policy.h
   M /trunk/src/sandbox/src/sandbox_policy_base.cc
   M /trunk/src/sandbox/src/sandbox_policy_base.h
   M /trunk/src/sandbox/src/sandbox_types.h
   M /trunk/src/sandbox/src/target_process.cc
   M /trunk/src/sandbox/src/target_process.h
   A /trunk/src/sandbox/src/window.cc
   A /trunk/src/sandbox/src/window.h
   M /trunk/src/sandbox/tests/validation_tests/suite.cc

Add support for alternate window station.

TEST: Start chrome, make sure it loads pages, then user process explorer to make sure the WindowStation handle name is not the same as the browser process.

BUG:10996

Review URL: http://codereview.chromium.org/113190
------------------------------------------------------------------------
r16482 | pfeldman@chromium.org | 2009-05-20 17:16:21 +0200 (Wed, 20 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: Now that dev tools window is opened using Browser::CreateForApp (that works on Mac & Linux), devtools window closing can hardly be tested by means of InProcessBrowserTest. Disabling for now, looking for the better solution.


Review URL: http://codereview.chromium.org/115570
------------------------------------------------------------------------
r16481 | pfeldman@chromium.org | 2009-05-20 16:42:01 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   D /trunk/src/chrome/browser/debugger/devtools_view.cc
   D /trunk/src/chrome/browser/debugger/devtools_view.h
   A /trunk/src/chrome/browser/debugger/devtools_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   D /trunk/src/chrome/browser/debugger/devtools_window_gtk.cc
   D /trunk/src/chrome/browser/debugger/devtools_window_mac.cc
   D /trunk/src/chrome/browser/debugger/devtools_window_win.cc
   D /trunk/src/chrome/browser/debugger/devtools_window_win.h
   M /trunk/src/chrome/chrome.gyp

DevTools: Get rid of views in DevTools.

Review URL: http://codereview.chromium.org/115562
------------------------------------------------------------------------
r16478 | pinkerton@chromium.org | 2009-05-20 15:19:57 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

When loading, change the tag on the "go button" to IDC_STOP so it executes the correct command. Update the unit test to verify. BUG=12260 TEST=click stop button while loading page.
Review URL: http://codereview.chromium.org/115540
------------------------------------------------------------------------
r16474 | phajdan.jr@chromium.org | 2009-05-20 14:56:43 +0200 (Wed, 20 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   A /trunk/src/chrome/browser/task_manager_browsertest.cc
   M /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/test/browser/browser_tests_dll.vcproj

Fix a crash on browser exit after opening TaskManager.

TaskManager is a singleton, so it's destroyed by AtExitManager. At the time
of destruction it cannot register AtExit callbacks (AtExitManager requires
that). It turns out that some Windows view code wants to register an AtExit
callback during destruction.

For more info about view code, see http://src.chromium.org/viewvc/chrome?view=rev&revision=9161

The fix is to destroy the view early, using EnsureShutdown static method
of TaskManager. It was also necessary to delete child views a bit earlier
to avoid another crashed.

Added a regression browser_test and verified that it's broken without this fix.

http://crbug.com/11180

Review URL: http://codereview.chromium.org/114031
------------------------------------------------------------------------
r16470 | pfeldman@chromium.org | 2009-05-20 10:45:59 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

DevTools: Enable dev tools ui sanity tests, take 2.
Review URL: http://codereview.chromium.org/115560
------------------------------------------------------------------------
r16467 | rafaelw@chromium.org | 2009-05-20 07:01:03 +0200 (Wed, 20 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

tabs.onUpdated now sends 'url' when 'state' has changed to 'loading' when navigating to a new url. If a reload is in progress, 'loading' will not be accompanied by 'url'.

Also, refactored some code so that string constants are defined and shared.

BUG=11200
R=erikkay

Review URL: http://codereview.chromium.org/113552
------------------------------------------------------------------------
r16466 | jam@chromium.org | 2009-05-20 06:39:37 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc

Reuse ChildProcessSecurityHost for worker processes.

Review URL: http://codereview.chromium.org/115550
------------------------------------------------------------------------
r16464 | abarth@chromium.org | 2009-05-20 06:30:23 +0200 (Wed, 20 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/test/testing_profile.h
   A /trunk/src/net/base/force_tls_state.cc
   A /trunk/src/net/base/force_tls_state.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h

More progress on ForceHTTPS.

Instead of turning on strict HTTPS error processing for every site, we now track which sites have opted in.  Our implementation is still experimental and hidden behing the command line switch --force-https.

R=darin
TEST=No tests yet because this is just an experiment.

Review URL: http://codereview.chromium.org/113503
------------------------------------------------------------------------
r16462 | jam@chromium.org | 2009-05-20 06:14:21 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was created for has long been closed.  This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least).
Review URL: http://codereview.chromium.org/115553
------------------------------------------------------------------------
r16460 | jar@chromium.org | 2009-05-20 05:49:05 +0200 (Wed, 20 May 2009) | 20 lines
Changed paths:
   M /trunk/src/base/field_trial.cc
   M /trunk/src/base/field_trial.h
   M /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Facilitate a FieldTrial in the renderer

I added a command line for the renderer that accepts a FieldTrial
name and value, and forces that value to be activated in the
renderer.  As a result, any FieldTrial setting that is specified
by the browser process can be set (forced) in the renderer
process.  Such settings can then be used to establish names
of histograms, which means all processes can work in sync
on a single field trial (and generate data).  This should
allow A/B tests to be run that modulate the page load times.

Dave: Please review/confirm that you are happy with the changes to
render_view.cc.  Note that all I did was change the names and limits
for the histograms (they now go up to 3 minutes).  The MakeName()
allows me to get an A/B test of the impact of DNS pre-resolution.

Mike: Please review the code for passing along switch settings.

r=davemoore,mbelshe
Review URL: http://codereview.chromium.org/115525
------------------------------------------------------------------------
r16451 | evan@chromium.org | 2009-05-20 03:05:16 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

linux: more NOTIMPLEMENTED squashing.

BUG=12052

Review URL: http://codereview.chromium.org/115548
------------------------------------------------------------------------
r16450 | erg@google.com | 2009-05-20 03:04:10 +0200 (Wed, 20 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc

Temporarily disabling the implementation of the bookmark bubble.
http://crbug.com/12259

Review URL: http://codereview.chromium.org/113609
------------------------------------------------------------------------
r16449 | klink@chromium.org | 2009-05-20 02:53:06 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   M /trunk/src/webkit/glue/glue_accessibility_object.cc
   M /trunk/src/webkit/glue/glue_accessibility_object.h
   M /trunk/src/webkit/glue/webaccessibility.h
   M /trunk/src/webkit/glue/webaccessibilitymanager.h
   M /trunk/src/webkit/glue/webaccessibilitymanager_impl.cc
   M /trunk/src/webkit/glue/webaccessibilitymanager_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.h

Adds propagation and handling of render-side focus events, for the benefit of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager.

Review URL: http://codereview.chromium.org/115374
------------------------------------------------------------------------
r16448 | evan@chromium.org | 2009-05-20 02:47:55 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

linux: more NOTIMPLEMENTED squashing.

BUG=12052

Review URL: http://codereview.chromium.org/113592
------------------------------------------------------------------------
r16444 | estade@chromium.org | 2009-05-20 02:24:39 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/base/mime_util.h
   M /trunk/src/base/mime_util_linux.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/icon_loader_linux.cc
   M /trunk/src/chrome/browser/icon_manager_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/net/base/platform_mime_util_linux.cc

Linux download shelf icons first cut.

Nor do we have support for alternate file formats; nor do we have a default icon.

BUG=http://crbug.com/8631
Review URL: http://codereview.chromium.org/113571
------------------------------------------------------------------------
r16441 | shess@chromium.org | 2009-05-20 02:11:36 +0200 (Wed, 20 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Mac: Make sure the popup is closed when losing focus in omnibox.

Moved detection from -controlTextDidEndEditing: to
-control:textShouldEditEditing: in case any of the code depends on
still having focus when this happens.

http://crbug.com/12252
TEST=Type "word" in omnibox.  Click on page.  Popup should dissappear.

Review URL: http://codereview.chromium.org/116006
------------------------------------------------------------------------
r16440 | jhawkins@chromium.org | 2009-05-20 02:07:05 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc

Remove a debugging statement that was left in my last commit.

TBR
------------------------------------------------------------------------
r16438 | glen@chromium.org | 2009-05-20 01:50:37 +0200 (Wed, 20 May 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/test/test_location_bar.h

Commit for Miranda. 
http://codereview.chromium.org/115265

Original text:
"""
This addresses 3 of the 4 issues described in Issue 9223: 

1) Creates a new streamlined bubble with less text.
2) Incorporates a close [x].
3) Driven by configuration option in master_preferences file; this alternate
   bubble will be used only if "oem_bubble": true is set.

Requested longer linger time feature will involve mucking with the focus 
manager; this change will be uploaded separately.

BUG=9223
TEST=Add "oem_bubble": true to master_preferences file.  Run chrome with
--first-run option.  Alternate, smaller OEM bubble should appear over the Chrome
browser in the place of the standard first-run bubble.
"""

------------------------------------------------------------------------
r16437 | jhawkins@chromium.org | 2009-05-20 01:44:34 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Handle non-composited WMs when rendering the dragged tab.  Also moves rendering of the close button to TabRendererGtk (where it belongs).
Review URL: http://codereview.chromium.org/115543
------------------------------------------------------------------------
r16436 | shess@chromium.org | 2009-05-20 01:41:07 +0200 (Wed, 20 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm

Mac: Fix the Go button.

Go eventually calls LocationBarViewMac::AcceptInputWithDisposition(),
which was NOTIMPLEMENTED().  Implement.

http://crbug.com/12253
TEST=Type some text into omnibox.  Click the Go button rather than hitting enter.

Review URL: http://codereview.chromium.org/113595
------------------------------------------------------------------------
r16434 | jam@chromium.org | 2009-05-20 01:32:26 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/child_process_security_policy_browser_test.cc
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/test/browser/browser_tests_dll.vcproj

Move the ChildProcessSecurityPolicy browser test to the browser_tests dll.

Review URL: http://codereview.chromium.org/115544
------------------------------------------------------------------------
r16433 | erg@google.com | 2009-05-20 01:30:27 +0200 (Wed, 20 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

Quick reimplementation of StatusBubbleGtk to not suck as much.

The TabContentsContainerGtk now uses a GtkFixed to store its
children, and the status bubble is now a child of that GtkFixed
so that it can be absolutely positioned on top of the rendered
data. Since it is no longer a GTK_WINDOW_POPUP, all the weird
stuff related to different window managers goes away.

http://crbug.com/11635

Review URL: http://codereview.chromium.org/113590
------------------------------------------------------------------------
r16432 | thestig@chromium.org | 2009-05-20 01:29:59 +0200 (Wed, 20 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Fix memory leak in nine_box.
Review URL: http://codereview.chromium.org/112040
------------------------------------------------------------------------
r16430 | estade@chromium.org | 2009-05-20 01:05:36 +0200 (Wed, 20 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Fix linux autocomplete popups.

BUG=http://crbug.com/12059

Review URL: http://codereview.chromium.org/113601
------------------------------------------------------------------------
r16429 | sky@chromium.org | 2009-05-20 01:04:42 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/base/message_pump_glib.cc
   M /trunk/src/base/message_pump_glib.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Adds DidProcessEvent to MessagePumpGLib.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113600
------------------------------------------------------------------------
r16428 | glen@chromium.org | 2009-05-20 01:03:58 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Draw the toolbar separator correctly, and in maximized mode.

BUG=11696
TEST=Verify that the grey line between toolbar and content exists in restored and maximized mode and *not* on the new tab page, and when an infobar (e.g. default browser infobar) is present.

Review URL: http://codereview.chromium.org/113556
------------------------------------------------------------------------
r16426 | brettw@chromium.org | 2009-05-20 00:56:52 +0200 (Wed, 20 May 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/views/frame/browser_frame_gtk.cc
   A /trunk/src/chrome/browser/views/frame/browser_frame_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_frame_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp

Add a skeleton browser_frame implementation for GTK, make browser_view (which
it needs) compile on GTK.
Review URL: http://codereview.chromium.org/113589
------------------------------------------------------------------------
r16422 | yutak@chromium.org | 2009-05-20 00:22:58 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/resources/about_memory.html

Let Konqueror recognized in about:memory.

Landing a patch written by myself, which is originally reviewed at <http://codereview.chromium.org/113489>.

BUG=7633
Review URL: http://codereview.chromium.org/115524
------------------------------------------------------------------------
r16420 | kuchhal@chromium.org | 2009-05-20 00:19:05 +0200 (Wed, 20 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc

Add option to enable/disable reporting.

BUG=11507

Review URL: http://codereview.chromium.org/115522

------------------------------------------------------------------------
r16419 | jam@chromium.org | 2009-05-20 00:09:18 +0200 (Wed, 20 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc

comment out test
------------------------------------------------------------------------
r16418 | jam@chromium.org | 2009-05-19 23:58:39 +0200 (Tue, 19 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc

Disable test since it's causing others to fail
------------------------------------------------------------------------
r16417 | jam@chromium.org | 2009-05-19 23:31:27 +0200 (Tue, 19 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc

comment out test in linux
------------------------------------------------------------------------
r16416 | jam@chromium.org | 2009-05-19 23:18:12 +0200 (Tue, 19 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc

Fix test on linux.
Review URL: http://codereview.chromium.org/113597
------------------------------------------------------------------------
r16415 | jam@chromium.org | 2009-05-19 23:02:58 +0200 (Tue, 19 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/child_process_security_policy.cc
   M /trunk/src/chrome/browser/child_process_security_policy.h
   M /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc

Fix memory leaks when a renderer crashes and the user refreshes.  Also fix memory leak every time a renderer process goes away.

Review URL: http://codereview.chromium.org/115492
------------------------------------------------------------------------
r16412 | pfeldman@chromium.org | 2009-05-19 22:54:38 +0200 (Tue, 19 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc

Disable dev tools sanity tests to see if it helps interactive ui tests to recover.

Review URL: http://codereview.chromium.org/115538
------------------------------------------------------------------------
r16411 | pkasting@chromium.org | 2009-05-19 22:49:35 +0200 (Tue, 19 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Eliminate an unused constant.  Original patch by Yuzo Fujishima (see http://codereview.chromium.org/113245 ), r=me.
------------------------------------------------------------------------
r16410 | pinkerton@chromium.org | 2009-05-19 22:46:37 +0200 (Tue, 19 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/TabView.xib
   M /trunk/src/chrome/browser/cocoa/tab_cell.h
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   A /trunk/src/chrome/browser/cocoa/throbber_view.h
   A /trunk/src/chrome/browser/cocoa/throbber_view.mm
   A /trunk/src/chrome/browser/cocoa/throbber_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implement a status throbber on the mac, currently using the Win artwork. Made the tab cell use a generic NSView for showing the icon instead of relying on the NSButtonCell to draw it, so a NSImageView is in place by default. Remove un-needed outlets, bindings, and views from the nib. BUG=11916. TEST=loading pages, opening and closing tabs.
Review URL: http://codereview.chromium.org/115527
------------------------------------------------------------------------
r16396 | mpcomplete@google.com | 2009-05-19 20:52:50 +0200 (Tue, 19 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/automation/extension_port_container.cc
   A /trunk/src/chrome/browser/automation/extension_port_container.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/chrome.gyp

Allow connecting and messaging with extension ports by funneling external
ports through the automation postMessage interface.

See original review at: http://codereview.chromium.org/113461
Patch by Siggi Asgeirsson <sigurdur.asgeirsson@gmail.com>
Review URL: http://codereview.chromium.org/113538
------------------------------------------------------------------------
r16394 | evan@chromium.org | 2009-05-19 20:31:47 +0200 (Tue, 19 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/input_window_dialog_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc

linux: more dialog touchups.  I had missed one before.

BUG=11017,12056

Review URL: http://codereview.chromium.org/113587
------------------------------------------------------------------------
r16393 | tc@google.com | 2009-05-19 20:27:17 +0200 (Tue, 19 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Take 2 at forcing the foreground and background color of the
omnibox text.

I used a static for the black text tag, but we need a separate instance
per omnibox (one per browser window).

BUG=11450

Review URL: http://codereview.chromium.org/115521

------------------------------------------------------------------------
r16392 | aa@chromium.org | 2009-05-19 20:27:09 +0200 (Tue, 19 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/browser/views/hwnd_html_view.cc
   D /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Fix inspection of extensions.

As a bonus, debugging of extensions now works. Go OOP inspector team!

Inspection code was calling RVHD::GetProfile(), which was not implemented by ExtensionHost. Looking into this, it seems better to just remove the method from the interface since Profile is already accessible by way of RVH.

The only caller to RVHD::GetProfile() besides the inspector was HWNDHtmlView which is itself dead code, so I removed it too.

Review URL: http://codereview.chromium.org/115501
------------------------------------------------------------------------
r16387 | tc@google.com | 2009-05-19 19:33:04 +0200 (Tue, 19 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Revert "Force the foreground and background color of the omnibox text."
This reverts commit r16383.

Session restore fails with this change.

TBR=willchan

Review URL: http://codereview.chromium.org/115519

------------------------------------------------------------------------
r16385 | rohitrao@chromium.org | 2009-05-19 19:18:31 +0200 (Tue, 19 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fixes a drawing bug when scrolling a page with frames on Mac.

http://crbug.com/12237
TEST=Scroll on a page with frames, make sure everything is drawn
correctly.
Review URL: http://codereview.chromium.org/113584
------------------------------------------------------------------------
r16384 | pfeldman@chromium.org | 2009-05-19 19:11:58 +0200 (Tue, 19 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

DevTools: enable sanity test.

Review URL: http://codereview.chromium.org/115349
------------------------------------------------------------------------
r16383 | tc@google.com | 2009-05-19 18:56:09 +0200 (Tue, 19 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Force the foreground and background color of the omnibox text.

I didn't bother messing with the selection color or cursor color.

BUG=11450

Review URL: http://codereview.chromium.org/115496

------------------------------------------------------------------------
r16380 | brettw@chromium.org | 2009-05-19 18:14:23 +0200 (Tue, 19 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Ifdef out some Windows dependencies. This is the first pass trying to get
browser_view compiling on Linux. I haven't figured out what we'll do with these
things longer-term.
Review URL: http://codereview.chromium.org/113585
------------------------------------------------------------------------
r16379 | sky@chromium.org | 2009-05-19 18:03:57 +0200 (Tue, 19 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fixes merge error.

BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/115512
------------------------------------------------------------------------
r16378 | sky@chromium.org | 2009-05-19 17:58:37 +0200 (Tue, 19 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h

Makes dragged_tab_controller compiler on linux. I'm not adding this to
the gyp file yet as BrowserView needs to be made compilable before I
turn this on.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113562
------------------------------------------------------------------------
r16377 | sky@chromium.org | 2009-05-19 17:23:12 +0200 (Tue, 19 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/chrome.gyp

Gets dragged_tab_view to compile on linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115495
------------------------------------------------------------------------
r16376 | erikkay@google.com | 2009-05-19 17:13:12 +0200 (Tue, 19 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h

Make new methods pure virtual per Brett's request in http://codereview.chromium.org/113481

R=brettw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113567
------------------------------------------------------------------------
r16375 | brettw@chromium.org | 2009-05-19 17:02:13 +0200 (Tue, 19 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info_win.cc

Fix the Windows release build by adding some missing includes.
Review URL: http://codereview.chromium.org/115511
------------------------------------------------------------------------
r16374 | brettw@chromium.org | 2009-05-19 16:51:44 +0200 (Tue, 19 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/gfx/path.h
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/theme_helpers.h
   M /trunk/src/chrome/common/ipc_message_unittest.cc
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/tools/profiles/generate_profile.cc
   M /trunk/src/skia/ext/SkMemory_new_handler.cpp
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/bitmap_platform_device_win.cc
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/platform_canvas_linux.cc
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   M /trunk/src/skia/ext/platform_canvas_mac.h
   M /trunk/src/skia/ext/platform_canvas_win.h
   M /trunk/src/skia/ext/platform_device_linux.h
   M /trunk/src/skia/ext/platform_device_mac.cc
   M /trunk/src/skia/ext/platform_device_mac.h
   M /trunk/src/skia/ext/platform_device_win.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils.h
   M /trunk/src/skia/ext/skia_utils_mac.cc
   M /trunk/src/skia/ext/skia_utils_mac.h
   M /trunk/src/skia/ext/skia_utils_unittest.cc
   M /trunk/src/skia/ext/skia_utils_win.cc
   M /trunk/src/skia/ext/skia_utils_win.h
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/skia/ext/vector_device.cc
   M /trunk/src/skia/ext/vector_device.h
   M /trunk/src/skia/precompiled.cc
   M /trunk/src/webkit/glue/image_decoder.cc
   M /trunk/src/webkit/tools/test_shell/simple_clipboard_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Fix Skia includes to use the whole path name.
Review URL: http://codereview.chromium.org/115412
------------------------------------------------------------------------
r16373 | brettw@chromium.org | 2009-05-19 16:51:36 +0200 (Tue, 19 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   A /trunk/src/chrome/browser/views/frame/browser_frame_win.cc (from /trunk/src/chrome/browser/views/frame/browser_frame.cc:16007)
   A /trunk/src/chrome/browser/views/frame/browser_frame_win.h (from /trunk/src/chrome/browser/views/frame/browser_frame.h:16007)
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Factor out a BrowserFrame interface, and move the existing Windows-based code
to a new class: BrowserFrameWin.

The major other change I had to make was the way that the TabStrip is set in
the BrowserRootView. Now there is a method on the frame that the view can
call when it creats the tabstrip that will set the tabstrip on the root view.
Review URL: http://codereview.chromium.org/113511
------------------------------------------------------------------------
r16371 | avi@chromium.org | 2009-05-19 15:58:25 +0200 (Tue, 19 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm

Must register the AE handler earlier to catch the open url on a launch.

BUG=http://crbug.com/11996

Review URL: http://codereview.chromium.org/113543
------------------------------------------------------------------------
r16370 | avi@chromium.org | 2009-05-19 15:51:37 +0200 (Tue, 19 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm

Make javascript dialogs able to prompt for text.

BUG=http://crbug.com/11137

Review URL: http://codereview.chromium.org/115484
------------------------------------------------------------------------
r16368 | apavlov@chromium.org | 2009-05-19 15:22:44 +0200 (Tue, 19 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h


Review URL: http://codereview.chromium.org/113533
------------------------------------------------------------------------
r16365 | pfeldman@chromium.org | 2009-05-19 13:35:46 +0200 (Tue, 19 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_view.cc

DevTools: increase web inspector height

Review URL: http://codereview.chromium.org/113577
------------------------------------------------------------------------
r16360 | abarth@chromium.org | 2009-05-19 08:10:26 +0200 (Tue, 19 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_index.h

Fix Linux Bustage from new CL where it is missing string import

Patch by Mohamed Mansour.

R=abarth
BUG=6646
TEST=compiles

http://codereview.chromium.org/113573


------------------------------------------------------------------------
r16357 | sky@chromium.org | 2009-05-19 05:59:42 +0200 (Tue, 19 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_index.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_index.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Adds an index over bookmark titles for fast look up.
The index is currently built on the main thread (because that's where
we do the decoding now), but I'll change that after landing this.

BUG=6646
TEST=There are tests to cover this, but make sure the omnibox still
  suggests bookmark titles.

Review URL: http://codereview.chromium.org/115403
------------------------------------------------------------------------
r16356 | estade@chromium.org | 2009-05-19 04:06:08 +0200 (Tue, 19 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: Make the render view default color white.

This mainly shows during navigations or new tab creation (or during render view resizing). White looks better than grey. On debug, set the color to green.

Review URL: http://codereview.chromium.org/113568
------------------------------------------------------------------------
r16355 | estade@chromium.org | 2009-05-19 03:58:01 +0200 (Tue, 19 May 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/test/data/save_page/c.htm

Ensure proper extension when saving an HTML page.

When an HTML page has a title, it is used as the suggested file name in saving
the page. Then the file extension is guessed from the suggested file name.

This results in a wrong extension if the title contains a period ".".
This the source of Bug 10581.

Merely setting ignore_suggested_ext to true in win_util::SaveFileAsWithFilter
is not a good fix, because then we have an issue in saving a page without
a title, where the extension can be correctly derived from the suggested
file name.

This change solves the issue by appending ".htm" to the suggested file name
if the page content type is HTML and the suggested file name doesn't have a
proper extension.

BUG=10581

--------

patch by yuzo@google.com
review here: <http://codereview.chromium.org/115235>

------------------------------------------------------------------------
r16351 | arv@chromium.org | 2009-05-19 02:55:50 +0200 (Tue, 19 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc (from /trunk/src/chrome/browser/dom_ui/downloads_ui.cc:16094)
   A /trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h (from /trunk/src/chrome/browser/dom_ui/downloads_ui.cc:16094)
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   A /trunk/src/chrome/browser/resources/new_new_tab.html (from /trunk/src/chrome/browser/resources/new_tab.html:16094)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds a new command line switch called new-new-tab-page which enables
the prototype new new tab page.

Split the DownloadsDOMHandler into its own file.

The prototype is rough and has bugs. Don't file any bugs on it!

TEST=Run with the command line above and you should see an alternative
new tab page.

Review URL: http://codereview.chromium.org/115426
------------------------------------------------------------------------
r16342 | jhawkins@chromium.org | 2009-05-19 01:40:54 +0200 (Tue, 19 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Implement the sad tab crash animation for tabs in linux.

BUG=11615
Review URL: http://codereview.chromium.org/115489
------------------------------------------------------------------------
r16339 | estade@chromium.org | 2009-05-19 00:56:11 +0200 (Tue, 19 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Linux: Just enough toolbar theming to make everything look normal again.

http://crbug.com/11679

Review URL: http://codereview.chromium.org/115438
------------------------------------------------------------------------
r16335 | jam@chromium.org | 2009-05-19 00:22:06 +0200 (Tue, 19 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/child_process_security_policy.cc (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc:16195)
   A /trunk/src/chrome/browser/child_process_security_policy.h (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h:16195)
   A /trunk/src/chrome/browser/child_process_security_policy_unittest.cc (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc:16195)
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   D /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   D /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h
   D /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Rename RendererSecurityPolicy and move it to browser\.  No code change.

Review URL: http://codereview.chromium.org/113488
------------------------------------------------------------------------
r16333 | jeremy@chromium.org | 2009-05-19 00:17:36 +0200 (Tue, 19 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad_mac.mm
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/google_update_settings_mac.mm
   A /trunk/src/chrome/browser/google_update_settings_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Hook up stats reporting via default system on OS X.

Allow enabling/disabling stats via user defaults.
Fix breakpad to read from global stats setting.

To disable stats, type the following in the terminal:
defaults write com.google.Chrome usagestats -bool NO

BUG=12046

Review URL: http://codereview.chromium.org/113549
------------------------------------------------------------------------
r16329 | estade@chromium.org | 2009-05-18 23:32:01 +0200 (Mon, 18 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

Linux: Don't unparent unselected tab contentses.

Instead, hide them. Sometimes an unselected tab contents can get unhandled keyboard events after it's been deselected (if the renderer was really slow in handling and returning the event).

http://crbug.com/12178

Review URL: http://codereview.chromium.org/113545
------------------------------------------------------------------------
r16328 | jhawkins@chromium.org | 2009-05-18 23:30:58 +0200 (Mon, 18 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Landing approved patch for Vincent Zanotti.

Linux: really hides the tab close button when it should not be painted.

R=me

Original changelist is at http://codereview.chromium.org/113161
Review URL: http://codereview.chromium.org/113551
------------------------------------------------------------------------
r16327 | tc@google.com | 2009-05-18 23:28:49 +0200 (Mon, 18 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/link_button_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Force the font size in the omnibox, tabs, find bar, and download shelf
so we don't get layout overflow issues.  Ideally, we would have
vector graphics for buttons and stuff so this wouldn't be an issue,
but for now, this will have to do.

BUG=11128

Review URL: http://codereview.chromium.org/113546

------------------------------------------------------------------------
r16325 | finnur@chromium.org | 2009-05-18 23:23:05 +0200 (Mon, 18 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h

Fix a crash in the extension system when sending response back to extension with no results. Also found an UMR causing DCHECKs to hit repeatedly (in AsyncExtensionFunction::SetArgs).

BUG=None
TEST=Basically, use any extension that calls an API function that returns no results (such as PageAction) and Chrome should not crash.
Review URL: http://codereview.chromium.org/114033
------------------------------------------------------------------------
r16324 | sky@chromium.org | 2009-05-18 23:22:51 +0200 (Mon, 18 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   D /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   D /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h
   A /trunk/src/chrome/browser/views/tabs/native_view_photobooth.h (from /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h:16306)
   A /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.cc (from /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc:16306)
   A /trunk/src/chrome/browser/views/tabs/native_view_photobooth_win.h (from /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h:16306)

Refactors HWNDPhotobooth into NativeViewPhotobooth and
NativeViewPhotoboothWin.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115475
------------------------------------------------------------------------
r16323 | estade@chromium.org | 2009-05-18 23:21:28 +0200 (Mon, 18 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

GTK: Give the find bar a more reasonable size.

This (roughly) matches windows.

http://crbug.com/12147
Review URL: http://codereview.chromium.org/113529
------------------------------------------------------------------------
r16322 | estade@chromium.org | 2009-05-18 23:21:19 +0200 (Mon, 18 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

More NOTIMPLEMENTED() swatting.

http://crbug.com/12052

Review URL: http://codereview.chromium.org/113544
------------------------------------------------------------------------
r16320 | evan@chromium.org | 2009-05-18 23:20:33 +0200 (Mon, 18 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

linux: unify all the dialog layout code for visual consistency.

We follow the GNOME HIG where possible, which mostly means the
pixel spacing of the borders and buttons in dialogs.

BUG=12056

Review URL: http://codereview.chromium.org/113539
------------------------------------------------------------------------
r16319 | sky@chromium.org | 2009-05-18 23:14:02 +0200 (Mon, 18 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/chrome.gyp

Makes it so tab_strip can compile on linux. Most differences are due
to compiler differences between gcc and MSVC.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113537
------------------------------------------------------------------------
r16316 | evan@chromium.org | 2009-05-18 23:12:27 +0200 (Mon, 18 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

linux: don't paint empty rects.

Fixes a crash in scrolling a heavy page repeatedly.

Review URL: http://codereview.chromium.org/113541
------------------------------------------------------------------------
r16312 | robertshield@google.com | 2009-05-18 23:10:52 +0200 (Mon, 18 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Fix unchecked pointer dereference that I stumbled across.

Review URL: http://codereview.chromium.org/115477
------------------------------------------------------------------------
r16311 | jhawkins@chromium.org | 2009-05-18 23:10:09 +0200 (Mon, 18 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h

Track and free generated images in the browser theme provider.
Review URL: http://codereview.chromium.org/115478
------------------------------------------------------------------------
r16310 | jhawkins@chromium.org | 2009-05-18 23:08:48 +0200 (Mon, 18 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   A /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc
   A /trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Implement DraggedTabGtk, the object that handles rendering either a dragged tab or tab contents during a tab drag.
Review URL: http://codereview.chromium.org/113532
------------------------------------------------------------------------
r16307 | estade@chromium.org | 2009-05-18 20:33:57 +0200 (Mon, 18 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Get rid of a couple NOTIMPLEMENTED()s.

http://crbug.com/12052
Review URL: http://codereview.chromium.org/115470
------------------------------------------------------------------------
r16306 | pinkerton@chromium.org | 2009-05-18 20:28:08 +0200 (Mon, 18 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib
   A /trunk/src/chrome/browser/cocoa/location_bar_cell.h
   A /trunk/src/chrome/browser/cocoa/location_bar_cell.mm
   A /trunk/src/chrome/browser/cocoa/location_bar_cell_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

Adjust size of location bar, update preference panels to new appearance.
------------------------------------------------------------------------
r16305 | avi@chromium.org | 2009-05-18 20:26:58 +0200 (Mon, 18 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Switch to a real API for putting titles in docked windows.

Review URL: http://codereview.chromium.org/113536
------------------------------------------------------------------------
r16293 | finnur@chromium.org | 2009-05-18 19:16:37 +0200 (Mon, 18 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Add support for more image types besides .ico in PageActions.

This relies on issue 11680 being fixed.

BUG=http://crbug.com/12060
TEST=(Needs PageAction extension). I tried specifying .ico, .jpg, .gif, .bmp, .png and they all worked (including weird sizes).
Review URL: http://codereview.chromium.org/115411
------------------------------------------------------------------------
r16292 | willchan@chromium.org | 2009-05-18 19:13:06 +0200 (Mon, 18 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Linux: Implement WasHidden()/DidBecomeSelected().
This is a small performance optimization to save on paint operations on hidden widgets, and not reallocate backing stores.
BUG=http://www.crbug.com/11977
TEST=Switch between tabs.  Make sure nothing breaks.

Review URL: http://codereview.chromium.org/115448
------------------------------------------------------------------------
r16290 | sky@chromium.org | 2009-05-18 19:03:14 +0200 (Mon, 18 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc

Land 12007 for yusukes. Original patch here:  http://codereview.chromium.org/115451 .

BUG=http://crbug.com/12007
TEST=see bug

Review URL: http://codereview.chromium.org/113531
------------------------------------------------------------------------
r16284 | erikkay@google.com | 2009-05-18 18:40:39 +0200 (Mon, 18 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h

Add a handle to the ExtensionShelf.  This is how users will drag extension toolstrips around, and perhaps where we'll add other UI for manipulating an extension.

BUG=none
TEST=none

depends on the following other changes:
http://codereview.chromium.org/113481
http://codereview.chromium.org/113486
http://codereview.chromium.org/113466

Review URL: http://codereview.chromium.org/113483
------------------------------------------------------------------------
r16283 | estade@chromium.org | 2009-05-18 18:30:02 +0200 (Mon, 18 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: make RWHV::Focus() set native focus (in addition to webkit focus).

Review URL: http://codereview.chromium.org/113528
------------------------------------------------------------------------
r16282 | willchan@chromium.org | 2009-05-18 18:27:34 +0200 (Mon, 18 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Linux: Fix interstitials to work across tab changes.
BUG=http://www.crbug.com/8486
TEST=Bring up two tabs.  In one tab, navigate to https://ianfette.org.  Switch to the next tab.  Switch back to the first tab.  It should still display the interstitial page.  Try this both with the focus on the interstitial page before you switch to the second tab and with the focus on the omnibox before switching tabs, to make sure focus is set properly.

Review URL: http://codereview.chromium.org/115446
------------------------------------------------------------------------
r16281 | sky@chromium.org | 2009-05-18 18:16:40 +0200 (Mon, 18 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/menu/chrome_menu.h

Makes chrome_menu able to compile of Linux (the header that is). I'm
going to do some major surgery to chrome_menu to get the rest
compiling on linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115431
------------------------------------------------------------------------
r16279 | erikkay@google.com | 2009-05-18 18:05:24 +0200 (Mon, 18 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h

Forward simplified mouse events to the RenderViewHostDelegate::View so that it can implementsimple hover / tracking behavior.BUG=crbug.com/12067TEST=none (suggestions welcome)
Review URL: http://codereview.chromium.org/113481
------------------------------------------------------------------------
r16277 | erikkay@google.com | 2009-05-18 17:41:12 +0200 (Mon, 18 May 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/views/browser_bubble.cc
   A /trunk/src/chrome/browser/views/browser_bubble.h
   A /trunk/src/chrome/browser/views/browser_bubble_win.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

An attempt to abstract the logic of the various layered windows we're using that are attached to browser UI.  I needed another one of these for the extension shelf, and figured I'd try to make one that was generic.  Ideally, we'd do more refactoring so that StatusBubbles, InfoBubble, etc. could all share some common code.

BUG=none
TEST=none (I'd love some suggestions on what to put into a unit test here)


Review URL: http://codereview.chromium.org/113486
------------------------------------------------------------------------
r16275 | pfeldman@chromium.org | 2009-05-18 15:24:00 +0200 (Mon, 18 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/debugger/devtools_window_gtk.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_mac.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.cc

DevTools: init devtools with proper profile.

Review URL: http://codereview.chromium.org/115463
------------------------------------------------------------------------
r16274 | pinkerton@chromium.org | 2009-05-18 14:47:28 +0200 (Mon, 18 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Fix for crash in empty home page field. Ensure pref gets set back to NTP. BUG=11852. 
Review URL: http://codereview.chromium.org/113363
------------------------------------------------------------------------
r16267 | abarth@chromium.org | 2009-05-18 03:25:25 +0200 (Mon, 18 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

Allow IPv6 literals to be typed directly into the address bar, without
requiring a preceding http://.  The square brackets are still needed, though.

Fix some of the style problems in url_fixer_upper.cc:
- Multi-line if should have {}s
- "using namespace" is bad.

Patch by pmarks@google.com.

R=abarth
TEST=New unit tests.

http://codereview.chromium.org/113509

------------------------------------------------------------------------
r16254 | abarth@chromium.org | 2009-05-17 07:08:21 +0200 (Sun, 17 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc

Add ':' to the RemoveJs whitelist for about:dns.  This fixes the problem
of IPv6 literals appearing like "2001?4860?b005??84".

Patch by pmarks@google.com.

R=abarth
TEST=View about:dns on an IPv6 network and notice that the address render correctly.

------------------------------------------------------------------------
r16247 | jshin@chromium.org | 2009-05-17 01:44:12 +0200 (Sun, 17 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_impl.cc

Chrome-part of disabling web fonts by default while still alowing SVG fonts

(The webkit part is http://codereview.chromium.org/67209/show and 
 http://bugs.webkit.org/show_bug.cgi?id=25239 )

1. Adds '--enable-remote-fonts' command line switch
2. Adds a field ('enable_remote_fonts) to WebPreference
3. Pass the value of enable_remote_fonts to the corresponding field in WebCore::Settings (m_downloadableBinaryFontsEnabled)

BUG=9633

TEST: 1. Run Chrome with and without '--enable-remote-font' command line flag and go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page should be rendered with 'dull-looking ordinary' fonts. With the flag, the page should be rendered with 'decorative' remote fonts.
2. Even without the above flag, Chrome should should get 100/100, with no  boxes in the upper right corner (still has the Linktest Failed error).
Review URL: http://codereview.chromium.org/67210
------------------------------------------------------------------------
r16245 | glen@chromium.org | 2009-05-17 00:00:02 +0200 (Sun, 17 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/test/test_location_bar.h

Revert the first run bubble change because of Mac/Linux failures.

------------------------------------------------------------------------
r16244 | glen@chromium.org | 2009-05-16 23:46:17 +0200 (Sat, 16 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

File missing from previous recommit.

------------------------------------------------------------------------
r16243 | glen@chromium.org | 2009-05-16 23:40:38 +0200 (Sat, 16 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/installer/gcapi/gcapi_test.vcproj
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/test/test_location_bar.h

Recommit for MirandaC of Smaller alternate first run bubble. http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac

------------------------------------------------------------------------
r16242 | glen@chromium.org | 2009-05-16 23:06:31 +0200 (Sat, 16 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/test/test_location_bar.h

rollback of r 162411

------------------------------------------------------------------------
r16241 | glen@chromium.org | 2009-05-16 22:50:23 +0200 (Sat, 16 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/test/test_location_bar.h

Commit for MirandaC of Smaller alternate first run bubble. http://codereview.chromium.org/115265

BUG=9223
TBR=mirandac

Review URL: http://codereview.chromium.org/113504
------------------------------------------------------------------------
r16240 | glen@chromium.org | 2009-05-16 22:10:55 +0200 (Sat, 16 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Commit for Yusuke. http://codereview.chromium.org/106005

Prevent the status bubble from getting pushed down below the screen.
BUG=4821
TEST=Open a page with a link in the bottom left corner, verify that the status bubble appears to the right. Verify that the status bubble appears in a normal position for all other links


------------------------------------------------------------------------
r16239 | glen@chromium.org | 2009-05-16 21:57:33 +0200 (Sat, 16 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Theme the bookmark bar when in NTP mode.

Review URL: http://codereview.chromium.org/115178
------------------------------------------------------------------------
r16232 | glen@chromium.org | 2009-05-16 09:04:42 +0200 (Sat, 16 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Attempt to fix leaks in DOMUISources test 

TBR=arv

Review URL: http://codereview.chromium.org/115441
------------------------------------------------------------------------
r16228 | abarth@chromium.org | 2009-05-16 07:07:08 +0200 (Sat, 16 May 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc (from /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc:16161)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Try 16161 again.  Third time is the charm.
------------------------------------------------------------------------
r16221 | estade@chromium.org | 2009-05-16 03:59:08 +0200 (Sat, 16 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Gtk: fix find bar rendering following NineBox improvements.

Review URL: http://codereview.chromium.org/113496
------------------------------------------------------------------------
r16210 | glen@chromium.org | 2009-05-16 01:40:11 +0200 (Sat, 16 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc

Temporarily disable some stuff to get Mac/Linux green. Rollback keeps timing out.

------------------------------------------------------------------------
r16209 | glen@chromium.org | 2009-05-16 01:26:40 +0200 (Sat, 16 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc

Convert uints to size_ts

Review URL: http://codereview.chromium.org/115429
------------------------------------------------------------------------
r16208 | glen@chromium.org | 2009-05-16 01:04:45 +0200 (Sat, 16 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc

Fix mac builder. int comparison.

TBR=arv

------------------------------------------------------------------------
r16207 | aa@chromium.org | 2009-05-16 00:58:33 +0200 (Sat, 16 May 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/automation/automation_extension_function.cc
   A /trunk/src/chrome/browser/automation/automation_extension_function.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   A /trunk/src/chrome/browser/extensions/extension_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   A /trunk/src/chrome/test/automation/automation_proxy_uitest.h
   A /trunk/src/chrome/test/automation/extension_automation_constants.cc
   A /trunk/src/chrome/test/automation/extension_automation_constants.h
   A /trunk/src/chrome/test/data/extensions/uitest
   A /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call
   A /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/roundtrip_api_call/test.html
   A /trunk/src/chrome/test/data/extensions/uitest/simple_api_call
   A /trunk/src/chrome/test/data/extensions/uitest/simple_api_call/manifest.json
   A /trunk/src/chrome/test/data/extensions/uitest/simple_api_call/test.html

First step to enable end-to-end testing of extensions through the
automation interface. This adds a method to turn on automation of
extension API functions, plumbing that redirects API requests
through the automation interface when appropriate, and a couple
of UITests that exercise the functionality.

See http://codereview.chromium.org/113277 for the original review.

Review URL: http://codereview.chromium.org/115427
Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>.
------------------------------------------------------------------------
r16206 | huanr@chromium.org | 2009-05-16 00:53:14 +0200 (Sat, 16 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

A boring change to make synchronous calls in TabRestore.

Review URL: http://codereview.chromium.org/115421
------------------------------------------------------------------------
r16205 | glen@chromium.org | 2009-05-16 00:40:57 +0200 (Sat, 16 May 2009) | 3 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/ntp_background.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc (from /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc:16020)
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/resources/new_tab.html
   A /trunk/src/chrome/browser/resources/new_tab_theme.css (from /trunk/src/chrome/browser/resources/new_tab_theme.css:16020)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Re-land of earlier NTP theme patch; now with mac and linux compatibility.

Review URL: http://codereview.chromium.org/115413
------------------------------------------------------------------------
r16203 | erg@google.com | 2009-05-16 00:33:13 +0200 (Sat, 16 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

GTK: Modify the bookmark bar to actually use GTK drag and drop.

(Previously, DnD support was faked and would crash the application
in a variety of not-really corner cases.)

http://crbug.com/10964

Review URL: http://codereview.chromium.org/115388
------------------------------------------------------------------------
r16201 | shess@chromium.org | 2009-05-16 00:30:05 +0200 (Sat, 16 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Mac: Style the omnibox URL.

Cribbed this mostly from GTK, including taking their colors pretty
directly.  The hostname in the URL is a stronger color than the rest
of the URL to call it out.  The https: scheme is also called out
specially.  The background color changes when secure.

Also cleaned up the selection-setting so that there are distinct code
paths for updating the field and setting the selection.

Also fixed saving of selection across popup navigation via arrow keys.

Also sprinkled some const jimmies while I was in there.

http://crbug.com/10939
TEST=Type an URL, does the hostname highlight versus the rest?  Do secure URLS look different?

Review URL: http://codereview.chromium.org/113479
------------------------------------------------------------------------
r16198 | mpcomplete@google.com | 2009-05-16 00:23:43 +0200 (Sat, 16 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/sandbox_policy.h
   A /trunk/src/chrome/browser/utility_process_host.cc
   A /trunk/src/chrome/browser/utility_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/extensions/extension_unpacker.cc
   A /trunk/src/chrome/common/extensions/extension_unpacker.h (from /trunk/src/chrome/browser/extensions/extensions_service.h:15769)
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   A /trunk/src/chrome/utility
   A /trunk/src/chrome/utility/utility.vcproj
   A /trunk/src/chrome/utility/utility_main.cc
   A /trunk/src/chrome/utility/utility_thread.cc
   A /trunk/src/chrome/utility/utility_thread.h

Introducing the Utility process, which handles the unpacking and verification
of extension packages.

This is a first pass.  In the second pass, I will add support for transcoding
the manifest and any images in the browser process.

BUG=11680
Review URL: http://codereview.chromium.org/114027
------------------------------------------------------------------------
r16196 | estade@chromium.org | 2009-05-16 00:19:17 +0200 (Sat, 16 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/download/download_started_animation.h
   A /trunk/src/chrome/browser/gtk/download_started_animation_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/browser/views/download_started_animation.cc
   D /trunk/src/chrome/browser/views/download_started_animation.h
   A /trunk/src/chrome/browser/views/download_started_animation_win.cc (from /trunk/src/chrome/browser/views/download_started_animation.cc:16120)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc

GTK: Add download shelf first show animation.

http://crbug.com/8631

Review URL: http://codereview.chromium.org/113428
------------------------------------------------------------------------
r16195 | estade@chromium.org | 2009-05-16 00:02:03 +0200 (Sat, 16 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   M /trunk/src/chrome/browser/gtk/focus_store_gtk.h

These files got added twice. But how??

------------------------------------------------------------------------
r16193 | estade@chromium.org | 2009-05-15 23:52:48 +0200 (Fri, 15 May 2009) | 5 lines
Changed paths:
   M /trunk/src/base/gfx/size.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/test_browser_window.h

Linux: Take download shelf and infobar close animations into account during render view sizing.

http://crbug.com/11080

Review URL: http://codereview.chromium.org/113322
------------------------------------------------------------------------
r16192 | estade@chromium.org | 2009-05-15 23:47:31 +0200 (Fri, 15 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/browser_views.vcproj

Undo changes to files that crept into the wrong CL

TBR=brettw

Review URL: http://codereview.chromium.org/113485
------------------------------------------------------------------------
r16191 | jcampan@chromium.org | 2009-05-15 23:38:07 +0200 (Fri, 15 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h

If there is not enough room in the download shelf to show a download, move the "show all download" link to the right to make it more visible that something happened.
This is a quick fix to mitigate the Malaysian case where the text is really long.

BUG=11816
TEST=Make sure download shelf still works as expected: download items still show and are animated. Dangerous downloads prompt for confirmation. If the browser window is too small, the download item is not shown and the link "Show all downloads" is displayed on the left.
Review URL: http://codereview.chromium.org/113417
------------------------------------------------------------------------
r16189 | estade@chromium.org | 2009-05-15 23:33:31 +0200 (Fri, 15 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   A /trunk/src/chrome/browser/gtk/focus_store_gtk.cc
   A /trunk/src/chrome/browser/gtk/focus_store_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/chrome.gyp

Linux: Make findbar restore focus to last focused widget on close.

Factor out some common code to FocusStoreGtk so it can be shared by anyone who cares about remembering which widget last had focus. Currently used in FindBarGtk and TabContentsViewGtk.

Review URL: http://codereview.chromium.org/115391
------------------------------------------------------------------------
r16188 | robertshield@google.com | 2009-05-15 23:31:42 +0200 (Fri, 15 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Shorten the new proxy switch names.

Review URL: http://codereview.chromium.org/113465
------------------------------------------------------------------------
r16187 | avi@google.com | 2009-05-15 23:30:50 +0200 (Fri, 15 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Explicitly set the window title in the dock when minimizing a window/updating the current tab's title.

http://crbug.com/11982

Review URL: http://codereview.chromium.org/113430
------------------------------------------------------------------------
r16183 | estade@chromium.org | 2009-05-15 23:09:56 +0200 (Fri, 15 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/child_process_security_policy.cc
   D /trunk/src/chrome/browser/child_process_security_policy.h
   D /trunk/src/chrome/browser/child_process_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   A /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc:16180)
   A /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h:16180)
   A /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc:16180)
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

revert r16181 as it broke linux

TBR=jam

Review URL: http://codereview.chromium.org/115418
------------------------------------------------------------------------
r16181 | jam@chromium.org | 2009-05-15 22:49:52 +0200 (Fri, 15 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/child_process_security_policy.cc (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc:16161)
   A /trunk/src/chrome/browser/child_process_security_policy.h (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h:16161)
   A /trunk/src/chrome/browser/child_process_security_policy_unittest.cc (from /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc:16161)
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   D /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   D /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h
   D /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Rename RendererSecurityPolicy and move it to browser\.  No code change.

Review URL: http://codereview.chromium.org/113475
------------------------------------------------------------------------
r16178 | sky@chromium.org | 2009-05-15 22:37:42 +0200 (Fri, 15 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/dock_info_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Handful of changes to get views building again. The tab.cc ifdefs are
only short term. I'll stub out parts of chrome_menu next so that these
can be removed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115406
------------------------------------------------------------------------
r16172 | ananta@chromium.org | 2009-05-15 21:34:02 +0200 (Fri, 15 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/dialog_delegate.h
   M /trunk/src/webkit/glue/plugins/test/plugin_windowed_test.cc

Displaying consecutive alerts from plugins should not hang the browser. The plugins display alerts via the NPN_Evaluate API. The browser signals an event handle to ensure that the plugin starts peeking for messages while waiting for the NPN_Evaluate call to return. When the dialog is dismissed by the user, windows does send some messages to the plugin window underneath, like activation messages, etc. These don't get dispatched as the event is reset when the dialog is dismissed, i.e. much before the window is actually
destroyed.

The fix is to reset the event handle after the window is actually destroyed. To achieve this I added an OnClose virtual function to the DialogDelegate interface, which is overridden by the JavascriptMessageBoxDialog class which eventually ensures that the event is reset.

This fixes http://code.google.com/p/chromium/issues/detail?id=10799

I updated the AlertInWindowMessage npapi test to display two alerts instead of one.

Bug=10799

Review URL: http://codereview.chromium.org/113464
------------------------------------------------------------------------
r16165 | abarth@chromium.org | 2009-05-15 20:50:18 +0200 (Fri, 15 May 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 16164.
Review URL: http://codereview.chromium.org/113471
------------------------------------------------------------------------
r16164 | abarth@chromium.org | 2009-05-15 20:47:06 +0200 (Fri, 15 May 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc (from /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc:16161)
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Try 16162 again.  Hopefully should build with gcc.
------------------------------------------------------------------------
r16163 | beng@google.com | 2009-05-15 20:43:06 +0200 (Fri, 15 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_policy.cc
   M /trunk/src/net/base/cookie_policy.h

Reverting 16158.
Review URL: http://codereview.chromium.org/113470
------------------------------------------------------------------------
r16162 | abarth@chromium.org | 2009-05-15 20:27:31 +0200 (Fri, 15 May 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 16161.
Review URL: http://codereview.chromium.org/113468
------------------------------------------------------------------------
r16161 | abarth@chromium.org | 2009-05-15 20:14:08 +0200 (Fri, 15 May 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/ssl/ssl_host_state_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add unit tests for SSLHostState.

R=jcampan
TEST=The whole CL is a test.  :)

Review URL: http://codereview.chromium.org/113446
------------------------------------------------------------------------
r16160 | tim@chromium.org | 2009-05-15 20:11:18 +0200 (Fri, 15 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc

Tweak layout of password manager views so the buttons don't
move around when resizing the window.

BUG=11900
TEST=Open the 'Show saved passwords' dialog in the Minor Tweaks pane.  Resize the window, the buttons (i.e Remove) should not move.

Review URL: http://codereview.chromium.org/115393
------------------------------------------------------------------------
r16159 | kuchhal@chromium.org | 2009-05-15 20:03:40 +0200 (Fri, 15 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h

Do proper cleanup during shutdown to make Valgrind happy.

BUG=10738,10748

Review URL: http://codereview.chromium.org/115392

------------------------------------------------------------------------
r16158 | idanan@chromium.org | 2009-05-15 17:24:46 +0200 (Fri, 15 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_policy.cc
   M /trunk/src/net/base/cookie_policy.h

Privacy option added for all cookies to become session cookies.

BUG=10502
Review URL: http://codereview.chromium.org/87047
------------------------------------------------------------------------
r16154 | hbono@chromium.org | 2009-05-15 12:25:39 +0200 (Fri, 15 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

A quick fix for Issue 11683.

I noticed this issue is caused by the IMF_AUTOKEYBOARD option of a RichEdit control, an option that allows a RichEdit control to automatically change the input language with a selection. (An omnibox changes a selection to display a styled text.) A RichEdit control automatically turns on the IMF_AUTOKEYBOARD option when we input an RTL character and start changing the input language with a selection. So, this change checks the IMF_AUTOKEYBOARD option and disable it before decorating a text to prevent it from changing the input language while decorating a text.

BUG=11683 "RTL: IME changes when writing a Hebrew character inside an English string in the omnibox"
TEST=Change the input language to English, type "abcd" in an omnibox, change the input language to Hebrew, type an 'a' key, and verify the input language is Hebrew.
Review URL: http://codereview.chromium.org/113394
------------------------------------------------------------------------
r16148 | ben@chromium.org | 2009-05-15 09:37:29 +0200 (Fri, 15 May 2009) | 8 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/gfx/canvas.cc (from /trunk/src/app/gfx/chrome_canvas.cc:16147)
   A /trunk/src/app/gfx/canvas.h (from /trunk/src/app/gfx/chrome_canvas.h:16147)
   A /trunk/src/app/gfx/canvas_linux.cc (from /trunk/src/app/gfx/chrome_canvas_linux.cc:16147)
   A /trunk/src/app/gfx/canvas_win.cc (from /trunk/src/app/gfx/chrome_canvas_win.cc:16147)
   D /trunk/src/app/gfx/chrome_canvas.cc
   D /trunk/src/app/gfx/chrome_canvas.h
   D /trunk/src/app/gfx/chrome_canvas_linux.cc
   D /trunk/src/app/gfx/chrome_canvas_win.cc
   D /trunk/src/app/gfx/chrome_font.h
   D /trunk/src/app/gfx/chrome_font_gtk.cc
   D /trunk/src/app/gfx/chrome_font_mac.mm
   D /trunk/src/app/gfx/chrome_font_skia.cc
   D /trunk/src/app/gfx/chrome_font_unittest.cc
   D /trunk/src/app/gfx/chrome_font_win.cc
   A /trunk/src/app/gfx/font.h (from /trunk/src/app/gfx/chrome_font.h:16147)
   A /trunk/src/app/gfx/font_gtk.cc (from /trunk/src/app/gfx/chrome_font_gtk.cc:16147)
   A /trunk/src/app/gfx/font_mac.mm (from /trunk/src/app/gfx/chrome_font_mac.mm:16147)
   A /trunk/src/app/gfx/font_skia.cc (from /trunk/src/app/gfx/chrome_font_skia.cc:16147)
   A /trunk/src/app/gfx/font_unittest.cc (from /trunk/src/app/gfx/chrome_font_unittest.cc:16147)
   A /trunk/src/app/gfx/font_win.cc (from /trunk/src/app/gfx/chrome_font_win.cc:16147)
   M /trunk/src/app/gfx/icon_util.h
   M /trunk/src/app/gfx/insets.h
   M /trunk/src/app/gfx/path.h
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/app/gfx/text_elider.h
   M /trunk/src/app/gfx/text_elider_unittest.cc
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_mac.mm
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/views/DEPS
   M /trunk/src/views/background.cc
   M /trunk/src/views/background.h
   M /trunk/src/views/border.cc
   M /trunk/src/views/border.h
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/button/checkbox.h
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/combo_box.cc
   M /trunk/src/views/controls/hwnd_view.cc
   M /trunk/src/views/controls/hwnd_view.h
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/menu/chrome_menu.h
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.h
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/text_field.h
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/controls/throbber.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/drag_utils.h
   M /trunk/src/views/painter.cc
   M /trunk/src/views/painter.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/root_view_gtk.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/window_win.cc

ChromeCanvas->gfx::Canvas

Rename files too.

TBR=brettw

http://crbug.com/11387
Review URL: http://codereview.chromium.org/113443
------------------------------------------------------------------------
r16147 | aa@chromium.org | 2009-05-15 09:01:25 +0200 (Fri, 15 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/notification_type.h
   A /trunk/src/chrome/test/data/extensions/good/extension3/1.0/EXTERNAL_INSTALL

Add ExtensionsService::Uninstall() plus unit tests.

Haven't hooked this up to anything yet though. Still trying to figure out the best way to shut everything down, so I figured I'd send this easy part out alone.

Review URL: http://codereview.chromium.org/113376
------------------------------------------------------------------------
r16146 | rafaelw@chromium.org | 2009-05-15 06:25:34 +0200 (Fri, 15 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

Uploaded & applied on behalf of Roger Tawa (rogerta@google.com).

BUG=11200
R=aa,rafaelw

http://codereview.chromium.org/115250

Review URL: http://codereview.chromium.org/113442
------------------------------------------------------------------------
r16145 | abarth@chromium.org | 2009-05-15 06:08:24 +0200 (Fri, 15 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   A /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_request_info.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/chrome.gyp

Finish refactoring to make SSLPolicy and friends unit testable.  Next stop: tests!

TBR=jcampan
BUG=http://crbug.com/8782

Review URL: http://codereview.chromium.org/115389
------------------------------------------------------------------------
r16142 | sky@chromium.org | 2009-05-15 05:05:11 +0200 (Fri, 15 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/dock_info.h
   A /trunk/src/chrome/browser/dock_info_win.cc (from /trunk/src/chrome/browser/dock_info.cc:16096)
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Refactors DockInfo so that it can be used on Linux. I haven't done the
gtk side yet.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113424
------------------------------------------------------------------------
r16141 | beng@google.com | 2009-05-15 04:16:10 +0200 (Fri, 15 May 2009) | 7 lines
Changed paths:
   M /trunk/src/app/gfx/chrome_canvas.cc
   M /trunk/src/app/gfx/chrome_canvas.h
   M /trunk/src/app/gfx/chrome_canvas_linux.cc
   M /trunk/src/app/gfx/chrome_canvas_win.cc
   M /trunk/src/app/gfx/chrome_font.h
   M /trunk/src/app/gfx/chrome_font_gtk.cc
   M /trunk/src/app/gfx/chrome_font_mac.mm
   M /trunk/src/app/gfx/chrome_font_skia.cc
   M /trunk/src/app/gfx/chrome_font_unittest.cc
   M /trunk/src/app/gfx/chrome_font_win.cc
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/app/gfx/text_elider.h
   M /trunk/src/app/gfx/text_elider_unittest.cc
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/app/win_util.cc
   M /trunk/src/app/win_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/native_button_wrapper.h
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/combo_box.cc
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/menu/chrome_menu.h
   M /trunk/src/views/controls/menu/menu_win.cc
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/controls/text_field.h
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/tooltip_manager.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/window_win.cc

ChromeFont->gfx::Font

Does not rename the files yet.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113441
------------------------------------------------------------------------
r16140 | tim@chromium.org | 2009-05-15 03:43:53 +0200 (Fri, 15 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Signature changed to take a Profile*

Review URL: http://codereview.chromium.org/113439
------------------------------------------------------------------------
r16139 | beng@google.com | 2009-05-15 03:25:29 +0200 (Fri, 15 May 2009) | 6 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/app_switches.cc
   A /trunk/src/app/app_switches.h
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util_unittest.cc
   A /trunk/src/app/test
   A /trunk/src/app/test/data
   A /trunk/src/app/test/data/resource.h (from /trunk/src/chrome/test/data/resource.h:16106)
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   D /trunk/src/chrome/test/data/resource.h
   M /trunk/src/chrome/test/data/resource.rc

Create app_switches and remove a dep.
Move resource.h to app.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113435
------------------------------------------------------------------------
r16137 | jungshik@google.com | 2009-05-15 02:59:20 +0200 (Fri, 15 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Update French spellcheck dictionary to 1.4.

This is to fix bug 8551.

http://crbug.com/8551
TEST=Launch Chrome with '--lang=fr' (or switch your spellcheck language to French).
In an textarea, type a paragraph of random text. Quit chrome or change the
spellcheck language to English. Chrome should not crash.
TBR=sidchat

Review URL: http://codereview.chromium.org/115390
------------------------------------------------------------------------
r16132 | arv@chromium.org | 2009-05-15 02:30:58 +0200 (Fri, 15 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Fix issue where the star in the history page could be hidden by long
entry titles or by making the window narrow enough to truncate the 
text.

BUG=9712

TEST=Bookmark a page and go to the history page. Resize the window so
that it is narrow enough to truncate the entry title of the page you 
just bookmarked. You still be able to see the star icon.

Review URL: http://codereview.chromium.org/113434
------------------------------------------------------------------------
r16127 | sky@chromium.org | 2009-05-15 01:52:57 +0200 (Fri, 15 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Remove a trailing slash in BrowserView. gcc doesn't like these.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/114030
------------------------------------------------------------------------
r16125 | beng@google.com | 2009-05-15 01:50:24 +0200 (Fri, 15 May 2009) | 2 lines
Changed paths:
   A /trunk/src/app/gfx/gtk_util.cc
   A /trunk/src/app/gfx/gtk_util.h
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Reverting 16124.
Review URL: http://codereview.chromium.org/115387
------------------------------------------------------------------------
r16124 | beng@google.com | 2009-05-15 01:46:18 +0200 (Fri, 15 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Reverting 16122.
Review URL: http://codereview.chromium.org/113427
------------------------------------------------------------------------
r16122 | beng@google.com | 2009-05-15 01:16:21 +0200 (Fri, 15 May 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/gtk_util.h

Move bitmap conversion function from chrome/common/gtk_utils.h into app/gfx/gtk_utils.h

http://crbug.com/11387

Review URL: http://codereview.chromium.org/115382
------------------------------------------------------------------------
r16112 | shess@chromium.org | 2009-05-15 00:07:53 +0200 (Fri, 15 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm

Use the Mac omnibox field's font as the basis for the fonts used in the field and popup.
NSAttributedString has fixed default font, unless overridden, this
basically makes the font used consistent with the field size.  Theming
will most likely change this again, but we can be prettier in the
meanwhile.

Review URL: http://codereview.chromium.org/115334
------------------------------------------------------------------------
r16107 | beng@google.com | 2009-05-14 23:35:59 +0200 (Thu, 14 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   M /trunk/src/chrome/browser/views/chrome_views_delegate.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/views/DEPS
   M /trunk/src/views/views_delegate.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_delegate.cc
   M /trunk/src/views/window/window_delegate.h
   M /trunk/src/views/window/window_gtk.cc
   M /trunk/src/views/window/window_gtk.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Move Always On Top setting out of Window/WindowDelegate and into task manager. It's the only one who uses this setting and the UI for exposing it is very specific to the task manager. Window retains a setter to set always on top state, but persistence and the system menu is Task Manager's responsbility. This allows us to sever the second-to-last chrome dependency from views.

http://crbug.com/11674
Review URL: http://codereview.chromium.org/115378
------------------------------------------------------------------------
r16101 | finnur@chromium.org | 2009-05-14 23:23:24 +0200 (Thu, 14 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Add error handling to PageAction extension API.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/113415
------------------------------------------------------------------------
r16100 | sky@chromium.org | 2009-05-14 23:06:57 +0200 (Thu, 14 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/back_forward_menu_model_win.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/menu/menu.cc
   M /trunk/src/views/controls/menu/menu.h
   A /trunk/src/views/controls/menu/menu_win.cc (from /trunk/src/views/controls/menu/menu.cc:16058)
   A /trunk/src/views/controls/menu/menu_win.h (from /trunk/src/views/controls/menu/menu.h:16058)
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/views.vcproj

Refactors menus so that I can create a MenuGtk implementation, and moves it into
the namespace views.

BUG=none
TEST=make sure I haven't broken any menus. This impacts all menus in
  Chrome, except bookmark ones.

Review URL: http://codereview.chromium.org/113410
------------------------------------------------------------------------
r16098 | finnur@chromium.org | 2009-05-14 22:51:06 +0200 (Thu, 14 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Extend the chrome.tabs API to allow relative paths.

BUG=None
TEST=In an extension, use chrome.tabs.create(...) to create a tab using a relative path ("foo/bar.html"). It should resolve that path by prepending the extension path ("chrome-extension://0000000000000000000000000000000000000042/foo/bar.html).
Review URL: http://codereview.chromium.org/113374
------------------------------------------------------------------------
r16095 | thestig@chromium.org | 2009-05-14 22:02:42 +0200 (Thu, 14 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/encoding_menu_controller.h

Add #include <string> to fix building with gcc 4.3.
Review URL: http://codereview.chromium.org/115372
------------------------------------------------------------------------
r16090 | beng@google.com | 2009-05-14 21:19:35 +0200 (Thu, 14 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Add star icon for bookmarked results in the omnibox2 popup view.

No, I'm not adding any more ternaries.

Review URL: http://codereview.chromium.org/115336
------------------------------------------------------------------------
r16088 | maruel@chromium.org | 2009-05-14 21:13:13 +0200 (Thu, 14 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/os_exchange_data.h
   M /trunk/src/app/os_exchange_data_win.cc
   M /trunk/src/app/os_exchange_data_win_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/history/history_publisher.cc
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/history_publisher_win.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/hwnd_view.cc
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/grid_layout_unittest.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view_drop_target.h
   M /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/window_win.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h

Remove even more ATL dependencies.
Review URL: http://codereview.chromium.org/115309
------------------------------------------------------------------------
r16083 | mpcomplete@google.com | 2009-05-14 20:46:21 +0200 (Thu, 14 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc

Add a separate cookie store that's used for extensions.

Modify CookieMonster to support overriding the "cookieable schemes".
Review URL: http://codereview.chromium.org/115204
------------------------------------------------------------------------
r16080 | evan@chromium.org | 2009-05-14 20:33:39 +0200 (Thu, 14 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

linux: more NOTIMPLEMENTED bugs.

Review URL: http://codereview.chromium.org/115366
------------------------------------------------------------------------
r16079 | evan@chromium.org | 2009-05-14 20:25:51 +0200 (Thu, 14 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

linux: another notimplemented into a bug.

Review URL: http://codereview.chromium.org/115365
------------------------------------------------------------------------
r16078 | evan@chromium.org | 2009-05-14 20:14:32 +0200 (Thu, 14 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

linux: not supporting page actions is a bug.

Review URL: http://codereview.chromium.org/115364
------------------------------------------------------------------------
r16074 | thomasvl@chromium.org | 2009-05-14 19:52:21 +0200 (Thu, 14 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   A /trunk/src/chrome/common/mac_app_names.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Provide one set of mac common app name defines for things that need the name of mac app on disk.
Update a used of names to use those new common ones.
Review URL: http://codereview.chromium.org/115359
------------------------------------------------------------------------
r16073 | jeremy@chromium.org | 2009-05-14 19:52:12 +0200 (Thu, 14 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm

Fixup colors for inactive tab.

Review URL: http://codereview.chromium.org/115362
------------------------------------------------------------------------
r16072 | jeremy@chromium.org | 2009-05-14 19:50:53 +0200 (Thu, 14 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h
   A /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm
   A /trunk/src/chrome/browser/encoding_menu_controller.cc
   A /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   A /trunk/src/chrome/browser/encoding_menu_controller_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Implement OS X Encoding Menu.

Also refactor Windows Encoding menu a bit to make the moving parts x-platform.
Add a unit test for the menu encoding logic.

In a followup CL I'll add some UI tests around this.

Review URL: http://codereview.chromium.org/113315
------------------------------------------------------------------------
r16070 | phajdan.jr@chromium.org | 2009-05-14 19:49:23 +0200 (Thu, 14 May 2009) | 14 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/base/directory_watcher.h
   M /trunk/src/base/directory_watcher_inotify.cc
   M /trunk/src/base/directory_watcher_mac.cc
   M /trunk/src/base/directory_watcher_stub.cc
   M /trunk/src/base/directory_watcher_unittest.cc
   M /trunk/src/base/directory_watcher_win.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc

Add support for almost-recursive watches in Linux DirectoryWatcher

After this patch DirectoryWatcher when asked for recursive watch will scan the
subtree and add inotify watches for each subfolder, but further changes to the
tree structure won't trigger adding/removing watches.

Support for really recursive watches is planned. This is just to divide the
work, because the task is not easy.

Based on patch by Janwar Dinata <j.dinata@gmail.com> reviewed at http://codereview.chromium.org/92151

http://crbug.com/8968

Review URL: http://codereview.chromium.org/115229
------------------------------------------------------------------------
r16067 | tim@chromium.org | 2009-05-14 19:35:51 +0200 (Thu, 14 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc

Fix regression caused by gfx::Size no longer accepting negative 
dimensions.

BUG=11900
TEST=Open 'Show Saved Passwords' under Minor Tweaks.  Should not crash, and the
'Show Password' button should be visible.

Review URL: http://codereview.chromium.org/115331
------------------------------------------------------------------------
r16065 | tc@google.com | 2009-05-14 19:23:44 +0200 (Thu, 14 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   D /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h
   D /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm
   D /trunk/src/chrome/browser/encoding_menu_controller.cc
   D /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   D /trunk/src/chrome/browser/encoding_menu_controller_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Revert "Implement OS X Encoding Menu."

This reverts commit r16061.

TBR=jeremy

Review URL: http://codereview.chromium.org/115357

------------------------------------------------------------------------
r16064 | huanr@chromium.org | 2009-05-14 19:12:39 +0200 (Thu, 14 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Enable one SessionRestoreUITest.

Review URL: http://codereview.chromium.org/113380
------------------------------------------------------------------------
r16063 | abarth@chromium.org | 2009-05-14 19:11:37 +0200 (Thu, 14 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h

Update comments as requested by jcampan.
------------------------------------------------------------------------
r16061 | jeremy@chromium.org | 2009-05-14 19:10:41 +0200 (Thu, 14 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h
   A /trunk/src/chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm
   A /trunk/src/chrome/browser/encoding_menu_controller.cc
   A /trunk/src/chrome/browser/encoding_menu_controller.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   A /trunk/src/chrome/browser/encoding_menu_controller_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Implement OS X Encoding Menu.

Also refactor Windows Encoding menu a bit to make the moving parts x-platform.
Add a unit test for the menu encoding logic.

In a followup CL I'll add some UI tests around this.

Review URL: http://codereview.chromium.org/113315
------------------------------------------------------------------------
r16058 | brettw@chromium.org | 2009-05-14 17:53:13 +0200 (Thu, 14 May 2009) | 13 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h

Add match count text to the GTK find bar. This also makes the bar wider.

The match count text doesn't currently show up realiably because the data in
the find reply is bad. I believe this is bug 11761.

The clicker checking code has been moved to the cross-platform
FindBarController so it doesn't have to be duplicated for each platform.

This also add IntToString16. I didnt add all the variants now. The *Wstring
versions should all eventually be changed to string16.

http://crbug.com/11750
Review URL: http://codereview.chromium.org/114023
------------------------------------------------------------------------
r16056 | rohitrao@chromium.org | 2009-05-14 17:24:31 +0200 (Thu, 14 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   A /trunk/src/chrome/browser/window_sizer_mac.mm
   A /trunk/src/chrome/browser/window_sizer_win.cc (from /trunk/src/chrome/browser/window_sizer.cc:15993)
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable basic saving/restoring window placements on Mac.

Refactors the existing WindowSizer code to move platform-specific code
into separate files.  Future CLs will add Mac support for muliple
monitors.

TEST=Browser windows should remember their position on Mac.  The
corresponding behavior on Windows should not have changed.
Review URL: http://codereview.chromium.org/113286
------------------------------------------------------------------------
r16054 | phajdan.jr@chromium.org | 2009-05-14 16:08:15 +0200 (Thu, 14 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Add missing ALLOW_THIS_IN_INITIALIZER_LIST...

TBR=jcampan

Review URL: http://codereview.chromium.org/113398
------------------------------------------------------------------------
r16053 | phajdan.jr@chromium.org | 2009-05-14 16:01:58 +0200 (Thu, 14 May 2009) | 11 lines
Changed paths:
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   A /trunk/src/chrome/browser/task_manager_linux.cc
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   A /trunk/src/chrome/browser/task_manager_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Extract Windows-specific parts of TaskManager.

- task_manager.cc compiles on POSIX
- task_manager_unittest.cc passes on Linux
- stub TaskManagerViewImpl for Linux (so that the unit test can pass)

TEST=Task manager should not be obviously broken on Windows.

http://crbug.com/11461

Review URL: http://codereview.chromium.org/115295
------------------------------------------------------------------------
r16050 | abarth@chromium.org | 2009-05-14 11:20:26 +0200 (Thu, 14 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc

Remove bad DCHECK.
------------------------------------------------------------------------
r16049 | abarth@chromium.org | 2009-05-14 10:57:15 +0200 (Thu, 14 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy_backend.h

Build fix.
------------------------------------------------------------------------
r16048 | abarth@chromium.org | 2009-05-14 10:47:30 +0200 (Thu, 14 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   A /trunk/src/chrome/browser/ssl/ssl_policy_backend.cc
   A /trunk/src/chrome/browser/ssl/ssl_policy_backend.h
   M /trunk/src/chrome/browser/ssl/ssl_request_info.h
   M /trunk/src/chrome/chrome.gyp

Factor SSLPolicyBackend out of SSLManager.

This reduces the complexity of SSLManager.  The idea is eventually to be able to test SSLPolicy by substituting a fake SSLPolicyBackend.

TBR=jcampan
TEST=No behavior changes.

Review URL: http://codereview.chromium.org/113395
------------------------------------------------------------------------
r16046 | abarth@chromium.org | 2009-05-14 09:50:35 +0200 (Thu, 14 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.h

Resubmit 16044 with typo fixed.
------------------------------------------------------------------------
r16045 | abarth@chromium.org | 2009-05-14 09:10:53 +0200 (Thu, 14 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.h

Revert 16044
------------------------------------------------------------------------
r16044 | abarth@chromium.org | 2009-05-14 08:26:32 +0200 (Thu, 14 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   M /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.h

Minor cleanup of SSL UI code.

TBR=jcampan
TEST=No functionality change.

Review URL: http://codereview.chromium.org/113392
------------------------------------------------------------------------
r16041 | abarth@chromium.org | 2009-05-14 07:46:24 +0200 (Thu, 14 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   A /trunk/src/chrome/browser/ssl/ssl_cert_error_handler.h
   A /trunk/src/chrome/browser/ssl/ssl_error_handler.cc
   A /trunk/src/chrome/browser/ssl/ssl_error_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   A /trunk/src/chrome/browser/ssl/ssl_mixed_content_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   A /trunk/src/chrome/browser/ssl/ssl_request_info.h
   M /trunk/src/chrome/chrome.gyp

Refactor the inner classes from SSLManager to their own files to reduce the complexity of SSLManager.  Heading towards unit testability of this code.

TBR=jcampan
TEST=No functionality change.


Review URL: http://codereview.chromium.org/113391
------------------------------------------------------------------------
r16039 | willchan@chromium.org | 2009-05-14 06:57:14 +0200 (Thu, 14 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/owned_widget_gtk.cc

Linux: Delay the deletion of the RWHVGtk object.
This object may be deleted within a signal handler for its widget, which causes a DCHECK.  Fix by using MessageLoop::DeleteSoon() instead.

BUG=http://www.crbug.com/11847
TEST=Open browser, navigate to www.google.com.  Navigate to www.yahoo.com.  This will delete the old RWHV.  It shouldn't crash.

Review URL: http://codereview.chromium.org/113316
------------------------------------------------------------------------
r16037 | jcampan@chromium.org | 2009-05-14 06:28:07 +0200 (Thu, 14 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/menu/chrome_menu.h
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/controls/text_field.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Clean-up of the accelerator code.
The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing.
This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators.
Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused.

BUG=11538
TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus.
     Also test that tab traversal still work as expected in the browser and in the option dialog.


Review URL: http://codereview.chromium.org/113307
------------------------------------------------------------------------
r16032 | aa@chromium.org | 2009-05-14 04:40:53 +0200 (Thu, 14 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

Revert "Revert "implemented extensions api windows.update().""
This reverts commit 81242e3b9c6e6fbc42ccf5f973b27ed4cf4401d6.

This wasn't the cause of the breakage.

Review URL: http://codereview.chromium.org/115337
------------------------------------------------------------------------
r16030 | aa@chromium.org | 2009-05-14 04:08:32 +0200 (Thu, 14 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

Revert "implemented extensions api windows.update()."
This reverts commit f2d9a44f3886aeab1378c8dbc1ce445202bc0ca5.

Review URL: http://codereview.chromium.org/115335
------------------------------------------------------------------------
r16029 | rafaelw@chromium.org | 2009-05-14 03:19:38 +0200 (Thu, 14 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

implemented extensions api windows.update().

currently only supports {left, top, width, height}.

Also, added extensions_api_client_unittest tests for CreateWindow, UpdateWindow & RemoveWindow

BUG=11200
R=mpComplete

Review URL: http://codereview.chromium.org/115316
------------------------------------------------------------------------
r16023 | evan@chromium.org | 2009-05-14 03:00:53 +0200 (Thu, 14 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/gtk/options
   A /trunk/src/chrome/browser/gtk/options/options_window_gtk.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add GTK options window (no options actually configurable yet.)

BUG=11507

Review URL: http://codereview.chromium.org/113377
Patch from Matt Mueller <mattm@google.com>.
------------------------------------------------------------------------
r16021 | glen@chromium.org | 2009-05-14 02:42:39 +0200 (Thu, 14 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/ntp_background.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   D /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/resources/new_tab.html
   D /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Undo 16020

------------------------------------------------------------------------
r16020 | glen@chromium.org | 2009-05-14 02:21:58 +0200 (Thu, 14 May 2009) | 8 lines
Changed paths:
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/app/l10n_util.h
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/ntp_background.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/resources/new_tab.html
   A /trunk/src/chrome/browser/resources/new_tab_theme.css
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Allow the new tab page to be themed (you may want to review DOMUIThemeSource as a whole and not just these changes).

Change global std::strings to chars* in browser theme provider.

Add ability for ReplaceStringPlaceHolder to take up to 9 replacements.

BUG=11235,11685
Review URL: http://codereview.chromium.org/115172
------------------------------------------------------------------------
r16015 | jar@chromium.org | 2009-05-14 01:32:01 +0200 (Thu, 14 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h

Ensure that IO thread is not called in last actions by SDCH shutdown

Unregister the sdch_dictionary_fetcher so that it destroys any pending
URLFetcher instances when we are nearing shutdown time.  Dictionaries
are only *potentially* useful (and not needed) for future SDCH 
fetches, so abandoning any pending items is safe and harmless.

b=9669
r=wtc
Review URL: http://codereview.chromium.org/113235
------------------------------------------------------------------------
r16013 | avi@google.com | 2009-05-14 01:29:02 +0200 (Thu, 14 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Save/restore the focused subview.

http://crbug.com/9420

Review URL: http://codereview.chromium.org/100358
------------------------------------------------------------------------
r16012 | sky@chromium.org | 2009-05-14 01:21:45 +0200 (Thu, 14 May 2009) | 6 lines
Changed paths:
   M /trunk/src/app/app.vcproj
   D /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data.h
   A /trunk/src/app/os_exchange_data_gtk.cc
   D /trunk/src/app/os_exchange_data_unittest.cc
   A /trunk/src/app/os_exchange_data_win.cc (from /trunk/src/app/os_exchange_data.cc:15916)
   A /trunk/src/app/os_exchange_data_win_unittest.cc (from /trunk/src/app/os_exchange_data_unittest.cc:15916)
   M /trunk/src/build/build_config.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Stubs out OSExchangeData for views on gtk.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113321
------------------------------------------------------------------------
r16009 | brettw@chromium.org | 2009-05-14 01:04:14 +0200 (Thu, 14 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h

Remove a comment referencing tab contents type switching.
Review URL: http://codereview.chromium.org/99047
------------------------------------------------------------------------
r16004 | arv@chromium.org | 2009-05-13 23:46:34 +0200 (Wed, 13 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Hide the "show full history" link when editing the thumbnails.

BUG=11330

TEST=Go to the NTP and click "Remove thumbnails". This should hide the "Show
full history" link.

Review URL: http://codereview.chromium.org/112020
------------------------------------------------------------------------
r16003 | beng@google.com | 2009-05-13 23:37:15 +0200 (Wed, 13 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Fix some issues with the omnibox2 popup:

- turn off transparency when glass isn't active
- make transparency when glass is active more opaque
- decrease the size of text to match the current omnibox popup
- make dim text in highlighted rows invert.

Review URL: http://codereview.chromium.org/113242
------------------------------------------------------------------------
r15993 | abarth@chromium.org | 2009-05-13 22:38:10 +0200 (Wed, 13 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h

Tweak comment as requested by wtc.
------------------------------------------------------------------------
r15991 | jhawkins@chromium.org | 2009-05-13 22:21:07 +0200 (Wed, 13 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Re-add tabstrip background rendering with support for themed backgrounds.
Review URL: http://codereview.chromium.org/115313
------------------------------------------------------------------------
r15988 | pinkerton@chromium.org | 2009-05-13 21:48:08 +0200 (Wed, 13 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Propagate intrinsic width notification over IPC in all cases (not just extensions) to the TabContentsView. Enable the zoom button on Mac to utilize it. Ensure we only send the IPC notification when the value changes, as WebCore tends to over-report that it has changed. Fix const-ness in delegate API where it's not necessary.
Review URL: http://codereview.chromium.org/115138
------------------------------------------------------------------------
r15987 | michaeln@google.com | 2009-05-13 21:31:47 +0200 (Wed, 13 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/npruntime_util.cc
   M /trunk/src/webkit/glue/npruntime_util.h

Reverting 15986.
Review URL: http://codereview.chromium.org/113359
------------------------------------------------------------------------
r15986 | michaeln@google.com | 2009-05-13 21:22:56 +0200 (Wed, 13 May 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/npruntime_util.cc
   M /trunk/src/webkit/glue/npruntime_util.h

CPAPI gears drag drop and renderer IPC....

CPAPI (0.10) functions for gears drag drop; one to extract the
drag type/data given an NPObject *event, one to override the
drop effect (drag cursor).

Gears drag drop API receives a browser event as an NPObject* so
the event is untrusted.  Provide IPC calls to the renderer so
gears can pass the event to renderer/V8 for checking, prior to
drag type/data extraction, or the setting of the drop effect.

V8 event checking is a TODO(noel), http://mondrian/10947778 for
the CPAPI (0.10) change submitted to gears.

BUG=7995

Original patch by Noel Gordon via:
http://codereview.chromium.org/99240
Review URL: http://codereview.chromium.org/115280
------------------------------------------------------------------------
r15985 | evan@chromium.org | 2009-05-13 21:18:52 +0200 (Wed, 13 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

metrics: don't record metrics unless user has opted-in.

This worked before, but regressed for Chromium builds.

BUG=2278

Review URL: http://codereview.chromium.org/113350
------------------------------------------------------------------------
r15982 | phajdan.jr@chromium.org | 2009-05-13 20:54:20 +0200 (Wed, 13 May 2009) | 7 lines
Changed paths:
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/tree_model.h (from /trunk/src/views/controls/tree/tree_model.h:15980)
   A /trunk/src/app/tree_node_iterator.h (from /trunk/src/views/controls/tree/tree_node_iterator.h:15980)
   A /trunk/src/app/tree_node_iterator_unittest.cc (from /trunk/src/views/controls/tree/tree_node_iterator_unittest.cc:15980)
   A /trunk/src/app/tree_node_model.h (from /trunk/src/views/controls/tree/tree_node_model.h:15980)
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj
   D /trunk/src/views/controls/tree/tree_model.h
   D /trunk/src/views/controls/tree/tree_node_iterator.h
   D /trunk/src/views/controls/tree/tree_node_iterator_unittest.cc
   D /trunk/src/views/controls/tree/tree_node_model.h
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/views.vcproj

Move tree-related classes that Linux code depends on from views/ to app/

TEST=If it compiles and unit_tests pass, it's ok. Just moving files around.

http://crbug.com/11066

Review URL: http://codereview.chromium.org/115185
------------------------------------------------------------------------
r15978 | huanr@chromium.org | 2009-05-13 20:41:39 +0200 (Wed, 13 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h

Making navigate, back, forward, and reload
synchronous in automated ui test.

Review URL: http://codereview.chromium.org/115279
------------------------------------------------------------------------
r15967 | maruel@chromium.org | 2009-05-13 19:52:48 +0200 (Wed, 13 May 2009) | 4 lines
Changed paths:
   M /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data.h
   M /trunk/src/app/os_exchange_data_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/history/history_publisher.cc
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/history_publisher_win.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/hwnd_view.cc
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/grid_layout_unittest.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view_drop_target.h
   M /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/window_win.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h

Revert 15965. I wasn't supposed to check that in since it still doesn't compile on linux and mac!

TBR=sky
Review URL: http://codereview.chromium.org/113351
------------------------------------------------------------------------
r15965 | maruel@chromium.org | 2009-05-13 19:31:10 +0200 (Wed, 13 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data.h
   M /trunk/src/app/os_exchange_data_unittest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/history/history_publisher.cc
   M /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/history_publisher_win.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/hwnd_view.cc
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/grid_layout_unittest.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view_drop_target.h
   M /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/window_win.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h

Remove even more ATL dependencies.
Review URL: http://codereview.chromium.org/115309
------------------------------------------------------------------------
r15961 | pinkerton@chromium.org | 2009-05-13 18:46:35 +0200 (Wed, 13 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Remove win-specific ifdefs to enable searching history. TEST=Searching history on NTP shound now do something, rather than nothing.
Review URL: http://codereview.chromium.org/115301
------------------------------------------------------------------------
r15959 | pinkerton@chromium.org | 2009-05-13 17:47:39 +0200 (Wed, 13 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Fix issue where dragging a newly created tab drags the entire window by commenting out some use of CoreAnimation. BUG=11829. TEST=dragging tags out of a new window.
Review URL: http://codereview.chromium.org/113343
------------------------------------------------------------------------
r15950 | maruel@chromium.org | 2009-05-13 15:22:45 +0200 (Wed, 13 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/test/data/History/HistoryHelper.js
   M /trunk/src/chrome/test/data/History/history_length_test1.html
   M /trunk/src/chrome/test/data/History/history_length_test2.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_1.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_2.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_3.html
   A /trunk/src/chrome/test/data/History/history_length_test_page_4.html
   M /trunk/src/chrome/test/ui/history_uitest.cc

This is the successor to http://codereview.chromium.org/67150

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG=9663,10531

Tested: unit_tests, ui_tests, manually.

Patch contributed by Yuzo Fujishima <yuzo@google.com>

Review: http://codereview.chromium.org/100245
------------------------------------------------------------------------
r15949 | senorblanco@chromium.org | 2009-05-13 15:16:52 +0200 (Wed, 13 May 2009) | 23 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/app/gfx/chrome_canvas.cc
   M /trunk/src/app/gfx/chrome_canvas_win.cc
   M /trunk/src/app/gfx/chrome_font.h
   M /trunk/src/app/gfx/chrome_font_skia.cc
   M /trunk/src/app/gfx/color_utils.cc
   M /trunk/src/app/gfx/color_utils.h
   M /trunk/src/app/gfx/icon_util.cc
   M /trunk/src/app/gfx/icon_util_unittest.cc
   M /trunk/src/app/theme_provider.h
   M /trunk/src/base/gfx/jpeg_codec.cc
   M /trunk/src/base/gfx/native_theme.cc
   M /trunk/src/base/gfx/native_theme.h
   M /trunk/src/base/gfx/png_decoder.cc
   M /trunk/src/base/gfx/png_encoder.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/history/page_usage_data.h
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/gtk_util.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   A /trunk/src/skia/config
   A /trunk/src/skia/config/SkUserConfig.h
   A /trunk/src/skia/config/win
   A /trunk/src/skia/config/win/stdint.h
   A /trunk/src/skia/ext/SkMemory_new_handler.cpp
   A /trunk/src/skia/ext/SkTypeface_fake.cpp
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils_unittest.cc
   D /trunk/src/skia/include/DoxygenMain.dox
   D /trunk/src/skia/include/Sk1DPathEffect.h
   D /trunk/src/skia/include/Sk2DPathEffect.h
   D /trunk/src/skia/include/SkAnimator.h
   D /trunk/src/skia/include/SkAnimatorView.h
   D /trunk/src/skia/include/SkApplication.h
   D /trunk/src/skia/include/SkAvoidXfermode.h
   D /trunk/src/skia/include/SkBGViewArtist.h
   D /trunk/src/skia/include/SkBML_WXMLParser.h
   D /trunk/src/skia/include/SkBML_XMLParser.h
   D /trunk/src/skia/include/SkBitmap.h
   D /trunk/src/skia/include/SkBlurDrawLooper.h
   D /trunk/src/skia/include/SkBlurMaskFilter.h
   D /trunk/src/skia/include/SkBorderView.h
   D /trunk/src/skia/include/SkBounder.h
   D /trunk/src/skia/include/SkCamera.h
   D /trunk/src/skia/include/SkCanvas.h
   D /trunk/src/skia/include/SkColor.h
   D /trunk/src/skia/include/SkColorFilter.h
   D /trunk/src/skia/include/SkColorMatrix.h
   D /trunk/src/skia/include/SkColorMatrixFilter.h
   D /trunk/src/skia/include/SkColorPriv.h
   D /trunk/src/skia/include/SkColorShader.h
   D /trunk/src/skia/include/SkCornerPathEffect.h
   D /trunk/src/skia/include/SkCullPoints.h
   D /trunk/src/skia/include/SkDOM.h
   D /trunk/src/skia/include/SkDashPathEffect.h
   D /trunk/src/skia/include/SkDeque.h
   D /trunk/src/skia/include/SkDescriptor.h
   D /trunk/src/skia/include/SkDevice.h
   D /trunk/src/skia/include/SkDiscretePathEffect.h
   D /trunk/src/skia/include/SkDither.h
   D /trunk/src/skia/include/SkDraw.h
   D /trunk/src/skia/include/SkDrawExtraPathEffect.h
   D /trunk/src/skia/include/SkDrawFilter.h
   D /trunk/src/skia/include/SkDrawLooper.h
   D /trunk/src/skia/include/SkEmbossMaskFilter.h
   D /trunk/src/skia/include/SkEvent.h
   D /trunk/src/skia/include/SkEventSink.h
   D /trunk/src/skia/include/SkFlattenable.h
   D /trunk/src/skia/include/SkFlipPixelRef.h
   D /trunk/src/skia/include/SkFontCodec.h
   D /trunk/src/skia/include/SkFontHost.h
   D /trunk/src/skia/include/SkGLCanvas.h
   D /trunk/src/skia/include/SkGlobals.h
   D /trunk/src/skia/include/SkGradientShader.h
   D /trunk/src/skia/include/SkGraphics.h
   D /trunk/src/skia/include/SkImageDecoder.h
   D /trunk/src/skia/include/SkImageRef.h
   D /trunk/src/skia/include/SkImageRef_GlobalPool.h
   D /trunk/src/skia/include/SkImageView.h
   D /trunk/src/skia/include/SkJS.h
   D /trunk/src/skia/include/SkKernel33MaskFilter.h
   D /trunk/src/skia/include/SkKey.h
   D /trunk/src/skia/include/SkLayerDrawLooper.h
   D /trunk/src/skia/include/SkLayerRasterizer.h
   D /trunk/src/skia/include/SkMMapStream.h
   D /trunk/src/skia/include/SkMallocPixelRef.h
   D /trunk/src/skia/include/SkMask.h
   D /trunk/src/skia/include/SkMaskFilter.h
   D /trunk/src/skia/include/SkMetaData.h
   D /trunk/src/skia/include/SkMovie.h
   D /trunk/src/skia/include/SkNinePatch.h
   D /trunk/src/skia/include/SkOSFile.h
   D /trunk/src/skia/include/SkOSMenu.h
   D /trunk/src/skia/include/SkOSSound.h
   D /trunk/src/skia/include/SkOSWindow_Mac.h
   D /trunk/src/skia/include/SkOSWindow_Unix.h
   D /trunk/src/skia/include/SkOSWindow_Win.h
   D /trunk/src/skia/include/SkOSWindow_wxwidgets.h
   D /trunk/src/skia/include/SkPackBits.h
   D /trunk/src/skia/include/SkPaint.h
   D /trunk/src/skia/include/SkPaintFlagsDrawFilter.h
   D /trunk/src/skia/include/SkParse.h
   D /trunk/src/skia/include/SkParsePaint.h
   D /trunk/src/skia/include/SkPath.h
   D /trunk/src/skia/include/SkPathEffect.h
   D /trunk/src/skia/include/SkPathMeasure.h
   D /trunk/src/skia/include/SkPicture.h
   D /trunk/src/skia/include/SkPixelRef.h
   D /trunk/src/skia/include/SkPixelXorXfermode.h
   D /trunk/src/skia/include/SkPorterDuff.h
   D /trunk/src/skia/include/SkProgressBarView.h
   D /trunk/src/skia/include/SkPtrRecorder.h
   D /trunk/src/skia/include/SkRasterizer.h
   D /trunk/src/skia/include/SkReader32.h
   D /trunk/src/skia/include/SkRefCnt.h
   D /trunk/src/skia/include/SkSVGAttribute.h
   D /trunk/src/skia/include/SkSVGBase.h
   D /trunk/src/skia/include/SkSVGPaintState.h
   D /trunk/src/skia/include/SkSVGParser.h
   D /trunk/src/skia/include/SkSVGTypes.h
   D /trunk/src/skia/include/SkScalerContext.h
   D /trunk/src/skia/include/SkScrollBarView.h
   D /trunk/src/skia/include/SkShader.h
   D /trunk/src/skia/include/SkShaderExtras.h
   D /trunk/src/skia/include/SkStackViewLayout.h
   D /trunk/src/skia/include/SkStream.h
   D /trunk/src/skia/include/SkStream_Win.h
   D /trunk/src/skia/include/SkString.h
   D /trunk/src/skia/include/SkStroke.h
   D /trunk/src/skia/include/SkSystemEventTypes.h
   D /trunk/src/skia/include/SkTDArray.h
   D /trunk/src/skia/include/SkTDStack.h
   D /trunk/src/skia/include/SkTDict.h
   D /trunk/src/skia/include/SkTextBox.h
   D /trunk/src/skia/include/SkTime.h
   D /trunk/src/skia/include/SkTransparentShader.h
   D /trunk/src/skia/include/SkTypeface.h
   D /trunk/src/skia/include/SkUnPreMultiply.h
   D /trunk/src/skia/include/SkUnitMapper.h
   D /trunk/src/skia/include/SkUnitMappers.h
   D /trunk/src/skia/include/SkUtils.h
   D /trunk/src/skia/include/SkView.h
   D /trunk/src/skia/include/SkViewInflate.h
   D /trunk/src/skia/include/SkWidget.h
   D /trunk/src/skia/include/SkWidgetViews.h
   D /trunk/src/skia/include/SkWindow.h
   D /trunk/src/skia/include/SkWriter32.h
   D /trunk/src/skia/include/SkXMLParser.h
   D /trunk/src/skia/include/SkXMLWriter.h
   D /trunk/src/skia/include/SkXfermode.h
   D /trunk/src/skia/include/corecg
   D /trunk/src/skia/precompiled.vsprops
   M /trunk/src/skia/skia.gyp
   D /trunk/src/skia/skia.vsprops
   M /trunk/src/skia/using_skia.vsprops
   M /trunk/src/views/background.cc
   M /trunk/src/views/background.h
   M /trunk/src/views/border.h
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/menu/chrome_menu.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/text_field.h
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/painter.cc
   M /trunk/src/views/painter.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/widget/root_view_gtk.cc
   M /trunk/src/views/window/window_delegate.cc
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t090501-c414-flt-ln-01-d-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1004-c5524-width-00-b-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1004-c5524-width-00-b-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/size/zero-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/size/zero-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/canvas/canvas-as-image-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/file-input-direction-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/file-input-direction-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/file-input-disabled-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/file-input-disabled-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/menulist-no-overflow-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/menulist-no-overflow-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/reflections/reflection-direction-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/reflections/reflection-direction-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/control-clip-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/control-clip-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/width100percent-checkbox-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/width100percent-checkbox-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/paths-data-03-f-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/stroked-pattern-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/stroked-pattern-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/tables/mozilla/bugs/bug23235-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/tables/mozilla/bugs/bug23235-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/tables/mozilla_expected_failures/bugs/bug85016-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t090501-c414-flt-ln-01-d-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1004-c5524-width-00-b-g-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1004-c5524-width-00-b-g-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/size/backgroundSize02-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/size/backgroundSize02-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/size/zero-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/size/zero-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-01-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-01-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-omit-right-slice-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-omit-right-slice-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-scale-transform-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-scale-transform-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-as-image-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-as-image-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/reflections/reflection-direction-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/reflections/reflection-direction-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/reflections/reflection-direction-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/001-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/001-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/002-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/002-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/003-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/003-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/scrollbars/overflow-scrollbar-combinations-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/scrollbars/overflow-scrollbar-combinations-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/paths-data-03-f-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/render-groups-01-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/render-groups-03-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/carto.net/window-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/carto.net/window-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-pattern-creation-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-pattern-creation-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/stroked-pattern-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/stroked-pattern-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug12910-2-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug12910-2-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug1296-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug1296-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug137388-2-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug137388-2-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug1430-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug1430-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug23235-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug23235-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug4093-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug4093-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug4427-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug4427-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug4523-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug4523-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug625-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug625-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug86708-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug86708-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/core/bloomberg-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/core/bloomberg-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla_expected_failures/bugs/bug1647-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla_expected_failures/bugs/bug1647-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla_expected_failures/bugs/bug85016-expected.png
   M /trunk/src/webkit/glue/image_resource_fetcher.cc
   M /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

This CL updates chrome to the latest version of skia, retrieved via DEPS, and
placed in third_party.  All relevant skia changes (for all 3 platforms) have
been upstreamed.

Most of this CL is mind-numbingly repetitive.  Things of interest are:  skia.gyp
(now points at third_party versions), DEPS, and SkUserConfig.h.  stdint.h:  Skia
now requires C99 integer types, which MSVC doesn't support natively.  I have put
typedefs in config/win/stdint.h.

Note that the new version of skia appears to render rects whose coordinates
are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled.  There
were a couple obvious instances of this in the code which I fixed, but there may
be more.

There were ~35 layout test failures due to minor pixel differences which I
rebaselined on Windows and Linux, and 8 genuine failures related to masks and
stroked text, which I have put in text_expectations.txt and assigned to
myself.  (There was another change which broke ~1700 tests on each platform,
but I put that change behind an #ifdef for now).

R=brettw

Review URL: http://codereview.chromium.org/65012
------------------------------------------------------------------------
r15947 | pfeldman@chromium.org | 2009-05-13 15:03:14 +0200 (Wed, 13 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_view.cc

DevTools: enable out of process dev tools by default. Take 2.

Review URL: http://codereview.chromium.org/115292
------------------------------------------------------------------------
r15941 | abarth@chromium.org | 2009-05-13 08:18:20 +0200 (Wed, 13 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h

Clarify the semantics of some SSLHostState data structures.

TBR=wtc
TEST=No behavior changes

Review URL: http://codereview.chromium.org/115289
------------------------------------------------------------------------
r15921 | erg@google.com | 2009-05-13 01:59:22 +0200 (Wed, 13 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

GTK: Display context menus on right-clicking a bookmark menu item.

- Refactors events so as a side effect, shift or control clicking a bookmark
  menu item opens with the correct disposition.
- Moves away from use of MenuGtk, as this menu does just too much weird stuff
  with events to use the general class.

Review URL: http://codereview.chromium.org/115270
------------------------------------------------------------------------
r15910 | estade@chromium.org | 2009-05-13 00:53:34 +0200 (Wed, 13 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Linux: fix a couple focus issues:

- Don't change focus in FindBarGtk::RestoreSavedFocus() unless the find bar has focus.
- Hide widgets in SlideAnimatorGtk when they aren't showing so they can't get focus.
- Add a check for null focus widget in TabContentsViewGtk::SaveFocus().

Review URL: http://codereview.chromium.org/115254
------------------------------------------------------------------------
r15904 | tc@google.com | 2009-05-12 23:38:59 +0200 (Tue, 12 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Remove two context menu entries that were never implemented!

Leave some stub code so someone can implement in the future.

BUG=11827

Review URL: http://codereview.chromium.org/113289

------------------------------------------------------------------------
r15902 | tc@google.com | 2009-05-12 23:31:15 +0200 (Tue, 12 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

Remove the page menu 'Print' entry until we implement it.

The keyboard accelerator still exists, but it's harmless (fires a
notimplemented).

BUG=11597

Review URL: http://codereview.chromium.org/115255

------------------------------------------------------------------------
r15899 | beng@google.com | 2009-05-12 23:20:40 +0200 (Tue, 12 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Now I have correct information on 11790 - NULL check TabContents in case this code is called during async window shutdown.

http://crbug.com/11790
Review URL: http://codereview.chromium.org/113292
------------------------------------------------------------------------
r15897 | jhawkins@chromium.org | 2009-05-12 23:17:42 +0200 (Tue, 12 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Update the Linux tabstrip code to handle themes.
Review URL: http://codereview.chromium.org/115260
------------------------------------------------------------------------
r15889 | brg@chromium.com | 2009-05-12 21:34:53 +0200 (Tue, 12 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Re-enable test after fix for valgrind/purify error.  
The fix was submitted in issue 79049.

http://crbug.com/10679
Review URL: http://codereview.chromium.org/115202
------------------------------------------------------------------------
r15888 | sidchat@google.com | 2009-05-12 21:30:21 +0200 (Tue, 12 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h

Add Automatic spell correction support in Chrome.

Issue=7624
Review URL: http://codereview.chromium.org/42608
------------------------------------------------------------------------
r15884 | paulg@google.com | 2009-05-12 21:08:28 +0200 (Tue, 12 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc

Don't access the notification service once it has been deleted.

This crash happens at shutdown where the notification service
is deleted by its owning thread during the normal thread tear
down process. In progress requests may still exist at this
point (and are about to be cleaned up) so they must not use
the service.

BUG=11491 (http://crbug.com/11491)

Review URL: http://codereview.chromium.org/115222
------------------------------------------------------------------------
r15881 | maruel@chromium.org | 2009-05-12 20:38:41 +0200 (Tue, 12 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h

Fix some CRLF files.

TBR=brettw
Review URL: http://codereview.chromium.org/113285
------------------------------------------------------------------------
r15880 | maruel@chromium.org | 2009-05-12 20:25:36 +0200 (Tue, 12 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h

Use the standard dotted rectangle when moving a tab out when "Show window
contents while dragging" is disabled.

BUG=805

Patch contributed by Yusuke Sato (yusukes@google.com)

Review: http://codereview.chromium.org/113176
------------------------------------------------------------------------
r15879 | pfeldman@chromium.org | 2009-05-12 20:25:17 +0200 (Tue, 12 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_view.cc

Reverting 15843: chrome performance regression.
Review URL: http://codereview.chromium.org/113284
------------------------------------------------------------------------
r15875 | willchan@chromium.org | 2009-05-12 20:04:20 +0200 (Tue, 12 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Revert "Revert "Only show the original RWHV or the interstitial page at any time.""
Fixed the SSL ui_tests which only failed on the buildbot by removing an unnecessary DCHECK.

Review URL: http://codereview.chromium.org/113238
------------------------------------------------------------------------
r15873 | phajdan.jr@chromium.org | 2009-05-12 20:00:07 +0200 (Tue, 12 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Fix few miscellanous TODO(port)s.

Review URL: http://codereview.chromium.org/113279
------------------------------------------------------------------------
r15867 | shess@chromium.org | 2009-05-12 19:38:17 +0200 (Tue, 12 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Address Mike's last complaint about Issue 114017.

http://codereview.chromium.org/114017

Add comment about operation of PropertyAccessor<> instance.

Review URL: http://codereview.chromium.org/113275
------------------------------------------------------------------------
r15864 | pinkerton@chromium.org | 2009-05-12 19:15:40 +0200 (Tue, 12 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Fix for delegate ordering problem dragging tabs between windows. We now remove the delegate and re-instate the new one in the correct order. Clean up the API a little as well. BUG=11466. TEST=dragging a tab into an existing window then switching tabs back and forth in the destination window.
Review URL: http://codereview.chromium.org/115240
------------------------------------------------------------------------
r15858 | abarth@chromium.org | 2009-05-12 18:21:03 +0200 (Tue, 12 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Be slightly more precise in how we propagate mixed content state.

Mixed content can't really propagate from one process to another, so we don't need to break the lock icon for every tab in the same origin when we see insecure content.  We need only break the lock icon for all the tabs in the same process.

R=jcampan
TEST=SSLUITest.TestMixedContentsTwoTabs

Review URL: http://codereview.chromium.org/115230
------------------------------------------------------------------------
r15855 | robertshield@google.com | 2009-05-12 17:07:50 +0200 (Tue, 12 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   A /trunk/src/chrome/browser/net/chrome_url_request_context_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/proxy/proxy_config.cc
   M /trunk/src/net/proxy/proxy_config.h
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/proxy/proxy_config_service_linux.cc
   M /trunk/src/net/proxy/proxy_config_service_linux.h
   M /trunk/src/net/proxy/proxy_config_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Making command-line specified proxy settings more flexible - allowing for setting of auto-detect, pac url, per-schema proxy settings, proxy bypass urls.

BUG=http://crbug.com/266

Review URL: http://codereview.chromium.org/115029
------------------------------------------------------------------------
r15854 | pinkerton@chromium.org | 2009-05-12 17:03:21 +0200 (Tue, 12 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Record UI metric for closing tabs with the mouse.
Review URL: http://codereview.chromium.org/114021
------------------------------------------------------------------------
r15853 | rafaelw@chromium.org | 2009-05-12 16:59:32 +0200 (Tue, 12 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension.cc
   A /trunk/src/chrome/browser/extensions/extension_error_utils.cc
   A /trunk/src/chrome/browser/extensions/extension_error_utils.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

FormatErrorMessage() functions are now publicly available from ExtensionErrorUtils.

ExtensionTabsModule implements a bunch of error_messages.

Extension Calls now always deliver a response to the calling context and route error messages if any to the window.console.error log.

Review URL: http://codereview.chromium.org/113105
------------------------------------------------------------------------
r15845 | pfeldman@chromium.org | 2009-05-12 11:20:33 +0200 (Tue, 12 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   A /trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/debugger/devtools_window_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.h
   A /trunk/src/chrome/test/data/devtools
   A /trunk/src/chrome/test/data/devtools/simple_page.html
   M /trunk/src/chrome/test/unit/unittests.vcproj

DevTools: Sanity ui test.

BUG=11533


Review URL: http://codereview.chromium.org/115127
------------------------------------------------------------------------
r15843 | pfeldman@chromium.org | 2009-05-12 11:09:14 +0200 (Tue, 12 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/devtools_agent_filter.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_view.cc

DevTools: enable out of process dev tools by default.

Review URL: http://codereview.chromium.org/115231
------------------------------------------------------------------------
r15839 | munjal@chromium.org | 2009-05-12 08:56:49 +0200 (Tue, 12 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller_unittest.mm

Move the bookmark node iD generation to bookmark model isntead of
bookmark node. This will also make the IDs more dense.

Review URL: http://codereview.chromium.org/99304
------------------------------------------------------------------------
r15822 | evan@chromium.org | 2009-05-12 02:33:04 +0200 (Tue, 12 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/iframe_uitest.cc

Re-enable IFrameTest.InEmptyFrame.

BUG=9870

Review URL: http://codereview.chromium.org/113211
Patch from Albert Bachand <albertb@google.com>.
------------------------------------------------------------------------
r15820 | glen@chromium.org | 2009-05-12 02:18:45 +0200 (Tue, 12 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Draw the maximized frame background correctly.

BUG=11695

Review URL: http://codereview.chromium.org/113227
------------------------------------------------------------------------
r15818 | tc@google.com | 2009-05-12 02:06:31 +0200 (Tue, 12 May 2009) | 4 lines
Changed paths:
   M /trunk/src/base/test_file_util_posix.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/startup/feature_startup_test.cc

Add new tab startup test to the linux & mac build.

Review URL: http://codereview.chromium.org/113229

------------------------------------------------------------------------
r15817 | jcampan@chromium.org | 2009-05-12 01:50:55 +0200 (Tue, 12 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/views/focus/view_storage.cc
   M /trunk/src/views/focus/view_storage.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h

Removing floating views, they are not used anymore.

BUG=None
TEST=Run unit_tests, ui_tests, interactive ui_tests.
     Make sure focus traversal still works.
Review URL: http://codereview.chromium.org/113215
------------------------------------------------------------------------
r15815 | kuchhal@chromium.org | 2009-05-12 01:45:25 +0200 (Tue, 12 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   A /trunk/src/chrome/browser/gtk/import_dialog_gtk.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/chrome.gyp

Add import settings dialog on linux.

BUG=11191
TEST=Open Import Settings dialog from Chrome wrench menu on Linux and make sure it imports Firefox data as selected.

Review URL: http://codereview.chromium.org/115133

------------------------------------------------------------------------
r15809 | evan@chromium.org | 2009-05-12 01:21:46 +0200 (Tue, 12 May 2009) | 7 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/base/gfx/platform_canvas_mac.h
   M /trunk/src/base/gfx/platform_device_mac.h
   M /trunk/src/base/gfx/png_encoder.cc
   M /trunk/src/base/gfx/png_encoder.h
   M /trunk/src/base/gfx/rect.cc
   M /trunk/src/base/gfx/rect.h
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/browser/debugger/resources/debugger_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   M /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/common/bindings_policy.h
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/greasemonkey_api_unittest.cc
   M /trunk/src/chrome/renderer/extensions/json_schema_unittest.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/json_schema.js
   M /trunk/src/chrome/test/data/extensions/content_script_inject/js_test.js
   M /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   M /trunk/src/chrome/test/data/extensions/content_script_inject/script1a.js
   M /trunk/src/chrome/test/data/extensions/content_script_inject/script1b.js
   M /trunk/src/chrome/test/data/extensions/content_script_inject/script2.js
   M /trunk/src/chrome/test/data/extensions/content_script_inject_page.html
   M /trunk/src/chrome/test/data/extensions/json_schema_test.js
   M /trunk/src/chrome/test/data/js_test_runner.html
   M /trunk/src/chrome/test/data/ssl/page_with_http_script.html
   M /trunk/src/chrome/test/data/ssl/randomize_hash.js
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_ca_ES.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_cs_CZ.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_da_DK.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_de_DE.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_de_DE_neu.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_el_GR.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_en_GB.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_en_US.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_es_ES.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_fr_FR.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_he_IL.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_hi_IN.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_hr_HR.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_id_ID.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_it_IT.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_lt_LT.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_lv_LV.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_nb_NO.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_nl_NL.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_pl_PL.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_pt_BR.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_pt_PT.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_ro_RO.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_ru_RU.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_sk_SK.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_sl_SI.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_sv_SE.txt
   M /trunk/src/chrome/third_party/hunspell/dictionaries/README_vi_VN.txt
   M /trunk/src/media/base/data_buffer.cc
   M /trunk/src/media/base/data_buffer.h
   M /trunk/src/media/base/media.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/bitmap_platform_device_mac.h
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   M /trunk/src/skia/ext/platform_canvas_mac.h
   M /trunk/src/skia/ext/platform_device_mac.cc
   M /trunk/src/skia/ext/platform_device_mac.h
   M /trunk/src/third_party/libxml/win32/config.h
   M /trunk/src/third_party/libxml/win32/include/libxml/xmlversion.h
   M /trunk/src/third_party/sqlite/doc/lemon.html
   M /trunk/src/third_party/sqlite/doc/report1.txt
   M /trunk/src/third_party/sqlite/ext/README.txt
   M /trunk/src/third_party/sqlite/ext/fts1/README.txt
   M /trunk/src/third_party/sqlite/ext/fts1/ft_hash.c
   M /trunk/src/third_party/sqlite/ext/fts1/ft_hash.h
   M /trunk/src/third_party/sqlite/ext/fts1/fts1.c
   M /trunk/src/third_party/sqlite/ext/fts1/fts1.h
   M /trunk/src/third_party/sqlite/ext/fts1/fts1_hash.c
   M /trunk/src/third_party/sqlite/ext/fts1/fts1_hash.h
   M /trunk/src/third_party/sqlite/ext/fts1/fts1_porter.c
   M /trunk/src/third_party/sqlite/ext/fts1/fts1_tokenizer.h
   M /trunk/src/third_party/sqlite/ext/fts1/fts1_tokenizer1.c
   M /trunk/src/third_party/sqlite/ext/fts1/fulltext.c
   M /trunk/src/third_party/sqlite/ext/fts1/fulltext.h
   M /trunk/src/third_party/sqlite/ext/fts1/simple_tokenizer.c
   M /trunk/src/third_party/sqlite/ext/fts1/tokenizer.h
   M /trunk/src/third_party/sqlite/ext/fts2/README.txt
   M /trunk/src/third_party/sqlite/ext/fts2/fts2.c
   M /trunk/src/third_party/sqlite/ext/fts2/fts2.h
   M /trunk/src/third_party/sqlite/ext/fts2/fts2_hash.c
   M /trunk/src/third_party/sqlite/ext/fts2/fts2_hash.h
   M /trunk/src/third_party/sqlite/ext/fts2/fts2_icu.c
   M /trunk/src/third_party/sqlite/ext/fts2/fts2_porter.c
   M /trunk/src/third_party/sqlite/ext/fts2/fts2_tokenizer.c
   M /trunk/src/third_party/sqlite/ext/fts2/fts2_tokenizer.h
   M /trunk/src/third_party/sqlite/ext/fts2/fts2_tokenizer1.c
   M /trunk/src/third_party/sqlite/ext/fts3/README.txt
   M /trunk/src/third_party/sqlite/ext/fts3/fts3.c
   M /trunk/src/third_party/sqlite/ext/fts3/fts3.h
   M /trunk/src/third_party/sqlite/ext/fts3/fts3_hash.c
   M /trunk/src/third_party/sqlite/ext/fts3/fts3_hash.h
   M /trunk/src/third_party/sqlite/ext/fts3/fts3_icu.c
   M /trunk/src/third_party/sqlite/ext/fts3/fts3_porter.c
   M /trunk/src/third_party/sqlite/ext/fts3/fts3_tokenizer.c
   M /trunk/src/third_party/sqlite/ext/fts3/fts3_tokenizer.h
   M /trunk/src/third_party/sqlite/ext/fts3/fts3_tokenizer1.c
   M /trunk/src/third_party/sqlite/ext/icu/README.txt
   M /trunk/src/third_party/sqlite/ext/icu/icu.c
   M /trunk/src/third_party/sqlite/ext/rtree/rtree.c
   M /trunk/src/third_party/sqlite/ext/rtree/rtree.h
   M /trunk/src/third_party/sqlite/preprocessed/keywordhash.h
   M /trunk/src/third_party/sqlite/preprocessed/opcodes.c
   M /trunk/src/third_party/sqlite/preprocessed/opcodes.h
   M /trunk/src/third_party/sqlite/preprocessed/parse.c
   M /trunk/src/third_party/sqlite/preprocessed/parse.h
   M /trunk/src/third_party/sqlite/preprocessed/sqlite3.h
   M /trunk/src/third_party/sqlite/src/alter.c
   M /trunk/src/third_party/sqlite/src/analyze.c
   M /trunk/src/third_party/sqlite/src/attach.c
   M /trunk/src/third_party/sqlite/src/auth.c
   M /trunk/src/third_party/sqlite/src/bitvec.c
   M /trunk/src/third_party/sqlite/src/btmutex.c
   M /trunk/src/third_party/sqlite/src/btree.c
   M /trunk/src/third_party/sqlite/src/btree.h
   M /trunk/src/third_party/sqlite/src/btreeInt.h
   M /trunk/src/third_party/sqlite/src/build.c
   M /trunk/src/third_party/sqlite/src/callback.c
   M /trunk/src/third_party/sqlite/src/complete.c
   M /trunk/src/third_party/sqlite/src/date.c
   M /trunk/src/third_party/sqlite/src/delete.c
   M /trunk/src/third_party/sqlite/src/expr.c
   M /trunk/src/third_party/sqlite/src/fault.c
   M /trunk/src/third_party/sqlite/src/func.c
   M /trunk/src/third_party/sqlite/src/global.c
   M /trunk/src/third_party/sqlite/src/hash.c
   M /trunk/src/third_party/sqlite/src/hash.h
   M /trunk/src/third_party/sqlite/src/hwtime.h
   M /trunk/src/third_party/sqlite/src/insert.c
   M /trunk/src/third_party/sqlite/src/journal.c
   M /trunk/src/third_party/sqlite/src/legacy.c
   M /trunk/src/third_party/sqlite/src/loadext.c
   M /trunk/src/third_party/sqlite/src/main.c
   M /trunk/src/third_party/sqlite/src/malloc.c
   M /trunk/src/third_party/sqlite/src/md5.c
   M /trunk/src/third_party/sqlite/src/mem1.c
   M /trunk/src/third_party/sqlite/src/mem2.c
   M /trunk/src/third_party/sqlite/src/mem3.c
   M /trunk/src/third_party/sqlite/src/mem4.c
   M /trunk/src/third_party/sqlite/src/mem5.c
   M /trunk/src/third_party/sqlite/src/mem6.c
   M /trunk/src/third_party/sqlite/src/mutex.c
   M /trunk/src/third_party/sqlite/src/mutex.h
   M /trunk/src/third_party/sqlite/src/mutex_os2.c
   M /trunk/src/third_party/sqlite/src/mutex_unix.c
   M /trunk/src/third_party/sqlite/src/mutex_w32.c
   M /trunk/src/third_party/sqlite/src/os.c
   M /trunk/src/third_party/sqlite/src/os.h
   M /trunk/src/third_party/sqlite/src/os_common.h
   M /trunk/src/third_party/sqlite/src/os_os2.c
   M /trunk/src/third_party/sqlite/src/os_symbian.cc
   M /trunk/src/third_party/sqlite/src/os_unix.c
   M /trunk/src/third_party/sqlite/src/os_win.c
   M /trunk/src/third_party/sqlite/src/pager.c
   M /trunk/src/third_party/sqlite/src/pager.h
   M /trunk/src/third_party/sqlite/src/pragma.c
   M /trunk/src/third_party/sqlite/src/prepare.c
   M /trunk/src/third_party/sqlite/src/printf.c
   M /trunk/src/third_party/sqlite/src/random.c
   M /trunk/src/third_party/sqlite/src/select.c
   M /trunk/src/third_party/sqlite/src/shell.c
   M /trunk/src/third_party/sqlite/src/shell_icu_linux.c
   M /trunk/src/third_party/sqlite/src/shell_icu_win.c
   M /trunk/src/third_party/sqlite/src/sqlite3ext.h
   M /trunk/src/third_party/sqlite/src/sqliteInt.h
   M /trunk/src/third_party/sqlite/src/sqliteLimit.h
   M /trunk/src/third_party/sqlite/src/status.c
   M /trunk/src/third_party/sqlite/src/table.c
   M /trunk/src/third_party/sqlite/src/tclsqlite.c
   M /trunk/src/third_party/sqlite/src/test1.c
   M /trunk/src/third_party/sqlite/src/test2.c
   M /trunk/src/third_party/sqlite/src/test3.c
   M /trunk/src/third_party/sqlite/src/test4.c
   M /trunk/src/third_party/sqlite/src/test5.c
   M /trunk/src/third_party/sqlite/src/test6.c
   M /trunk/src/third_party/sqlite/src/test7.c
   M /trunk/src/third_party/sqlite/src/test8.c
   M /trunk/src/third_party/sqlite/src/test9.c
   M /trunk/src/third_party/sqlite/src/test_async.c
   M /trunk/src/third_party/sqlite/src/test_autoext.c
   M /trunk/src/third_party/sqlite/src/test_btree.c
   M /trunk/src/third_party/sqlite/src/test_config.c
   M /trunk/src/third_party/sqlite/src/test_devsym.c
   M /trunk/src/third_party/sqlite/src/test_func.c
   M /trunk/src/third_party/sqlite/src/test_hexio.c
   M /trunk/src/third_party/sqlite/src/test_loadext.c
   M /trunk/src/third_party/sqlite/src/test_malloc.c
   M /trunk/src/third_party/sqlite/src/test_md5.c
   M /trunk/src/third_party/sqlite/src/test_mutex.c
   M /trunk/src/third_party/sqlite/src/test_onefile.c
   M /trunk/src/third_party/sqlite/src/test_osinst.c
   M /trunk/src/third_party/sqlite/src/test_schema.c
   M /trunk/src/third_party/sqlite/src/test_server.c
   M /trunk/src/third_party/sqlite/src/test_tclvar.c
   M /trunk/src/third_party/sqlite/src/test_thread.c
   M /trunk/src/third_party/sqlite/src/tokenize.c
   M /trunk/src/third_party/sqlite/src/trigger.c
   M /trunk/src/third_party/sqlite/src/update.c
   M /trunk/src/third_party/sqlite/src/utf.c
   M /trunk/src/third_party/sqlite/src/util.c
   M /trunk/src/third_party/sqlite/src/vacuum.c
   M /trunk/src/third_party/sqlite/src/vdbe.c
   M /trunk/src/third_party/sqlite/src/vdbe.h
   M /trunk/src/third_party/sqlite/src/vdbeInt.h
   M /trunk/src/third_party/sqlite/src/vdbeapi.c
   M /trunk/src/third_party/sqlite/src/vdbeaux.c
   M /trunk/src/third_party/sqlite/src/vdbeblob.c
   M /trunk/src/third_party/sqlite/src/vdbefifo.c
   M /trunk/src/third_party/sqlite/src/vdbemem.c
   M /trunk/src/third_party/sqlite/src/vtab.c
   M /trunk/src/third_party/sqlite/src/where.c
   M /trunk/src/third_party/sqlite/test/crashtest1.c
   M /trunk/src/third_party/sqlite/test/threadtest1.c
   M /trunk/src/third_party/sqlite/test/threadtest2.c
   M /trunk/src/third_party/sqlite/tool/diffdb.c
   M /trunk/src/third_party/sqlite/tool/lemon.c
   M /trunk/src/third_party/sqlite/tool/lempar.c
   M /trunk/src/third_party/sqlite/tool/mkkeywordhash.c
   M /trunk/src/third_party/sqlite/tool/report1.txt
   M /trunk/src/third_party/sqlite/tool/showdb.c
   M /trunk/src/third_party/sqlite/tool/showjournal.c
   M /trunk/src/third_party/sqlite/tool/speedtest16.c
   M /trunk/src/third_party/sqlite/tool/speedtest8.c
   M /trunk/src/third_party/sqlite/tool/speedtest8inst1.c
   M /trunk/src/tools/traceline/svgui/startup-release.json
   M /trunk/src/tools/traceline/svgui/traceline.css
   M /trunk/src/tools/traceline/svgui/traceline.js
   M /trunk/src/tools/traceline/svgui/traceline.xml
   M /trunk/src/tools/traceline/traceline/assembler.h
   M /trunk/src/tools/traceline/traceline/assembler_unittest.cc
   M /trunk/src/tools/traceline/traceline/logging.h
   M /trunk/src/tools/traceline/traceline/main.cc
   M /trunk/src/tools/traceline/traceline/rdtsc.h
   M /trunk/src/tools/traceline/traceline/scripts/crit_sec.js
   M /trunk/src/tools/traceline/traceline/scripts/heap.js
   M /trunk/src/tools/traceline/traceline/sidestep/ia32_modrm_map.cc
   M /trunk/src/tools/traceline/traceline/sidestep/ia32_opcode_map.cc
   M /trunk/src/tools/traceline/traceline/sidestep/mini_disassembler.cc
   M /trunk/src/tools/traceline/traceline/sidestep/mini_disassembler.h
   M /trunk/src/tools/traceline/traceline/sidestep/mini_disassembler_types.h
   M /trunk/src/tools/traceline/traceline/stubs.asm
   M /trunk/src/tools/traceline/traceline/sym_resolver.h
   M /trunk/src/tools/traceline/traceline/syscall_map.h
   M /trunk/src/webkit/data/layout_tests/pending/plugins/iframe-shims-expected.txt
   M /trunk/src/webkit/data/layout_tests/pending/plugins/iframe-shims.html
   M /trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/function-toString-semicolon-insertion-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css1/box_properties/float-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css1/box_properties/float-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/css1/box_properties/float-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/5408255-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/deletionUI-single-instance-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/deletionUI-single-instance-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/deletionUI-single-instance-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/4076267-2-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/5156401-1-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/5387578-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/bad-placeholder-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-match-style-001-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-text-019-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/cleared-by-relayout-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/drag-in-iframe-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/drag-text-delay-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/inactive-selection-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/move-past-trailing-space-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/move-past-trailing-space-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/move-past-trailing-space-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/wrapped-line-caret-1-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/wrapped-line-caret-1-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/wrapped-line-caret-1-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/wrapped-line-caret-2-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/wrapped-line-caret-2-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/wrapped-line-caret-2-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/basic/min-pref-width-nowrap-floats-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/basic/min-pref-width-nowrap-floats-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/float-avoidance-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/float-avoidance-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/float-avoidance-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/001-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/001-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/001-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/001-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/001-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/001-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/002-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/002-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/002-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/002-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/002-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/002-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/003-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/004-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/005-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/006-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/007-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/008-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/008-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/008-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/008-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/008-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/008-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/009-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/009-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/009-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/009-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/009-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/009-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/010-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/010-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/010-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/010-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/010-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/background-image/010-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/001-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/001-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/001-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/001-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/001-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/001-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/002-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/002-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/002-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/002-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/002-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/002-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/003-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/004-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/005-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/006-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-declarative-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-declarative-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-declarative-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-xhtml-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-xhtml-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/body-propagation/overflow/007-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/box-shadow/border-radius-big-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/box-shadow/border-radius-big-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/box-shadow/border-radius-big-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvasDrawingIntoSelf-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvasDrawingIntoSelf-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/drawImage-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/drawImage-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/fill-stroke-clip-reset-path-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/fill-stroke-clip-reset-path-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/fill-stroke-clip-reset-path-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/patternfill-repeat-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/patternfill-repeat-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-1-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-1-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-1-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-2-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-2-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-2-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-3-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-3-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-3-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-4-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-4-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-4-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-5-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-5-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-5-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-6-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-6-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/shadow-offset-6-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/background-shorthand-invalid-url-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/background-shorthand-invalid-url-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/background-shorthand-invalid-url-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/resize-corner-tracking-transformed-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/resize-corner-tracking-transformed-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/resize-corner-tracking-transformed-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/variables/color-hex-test-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/variables/invalid-identifier-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/word-space-extra-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/css/word-space-extra-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/Element/offsetLeft-offsetTop-body-quirk-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/Element/offsetLeft-offsetTop-html-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/HTMLDocument/document-open-return-value-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/HTMLObjectElement/object-as-frame-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/standalone-image-drag-to-editable-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/standalone-image-drag-to-editable-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/standalone-image-drag-to-editable-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/button-default-title-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/button-default-title-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/button-default-title-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/control-clip-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/control-clip-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/control-clip-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/form-hides-table-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/form-hides-table-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/form-hides-table-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/input-disabled-color-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/input-disabled-color-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/input-disabled-color-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/linebox-overflow-in-textarea-padding-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/password-placeholder-text-security-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/password-placeholder-text-security-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/password-placeholder-text-security-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/list-item-gradient-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/list-item-gradient-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/list-item-gradient-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/function-toString-semicolon-insertion-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/leaks/002-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/loader/data-url-encoding-html-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/loader/data-url-encoding-svg-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/column-rules-stacking-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/column-rules-stacking-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/column-rules-stacking-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-dynamic-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-dynamic-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-dynamic-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-h-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-h-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-h-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-v-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-v-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-v-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/replaced-breaking-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/replaced-breaking-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/replaced-breaking-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/runin/generated-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/runin/generated-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/runin/generated-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/text-field-baseline-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/text-field-baseline-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/text-field-baseline-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/animate-elem-34-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
   M /trunk/src/webkit/glue/resources/pan_icon.png
   M /trunk/src/webkit/glue/resources/textarea_resize_corner.png
   M /trunk/src/webkit/glue/stacking_order_iterator.cc
   M /trunk/src/webkit/glue/stacking_order_iterator.h
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/resources/textAreaResizeCorner.png
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Remove executable bit from a bunch of files that shouldn't have it.

(No code change.)

git ls-tree -r HEAD | grep '^100755' | cut -f2 |
   egrep '\.(png|txt|mm|cc|h|checksum|asm|js|html|c|css|xml|grd|json)$' |
   xargs chmod a-x
------------------------------------------------------------------------
r15801 | willchan@chromium.org | 2009-05-12 00:30:16 +0200 (Tue, 12 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Revert "Only show the original RWHV or the interstitial page at any time."
It broke ui_tests.

Review URL: http://codereview.chromium.org/112017
------------------------------------------------------------------------
r15799 | estade@chromium.org | 2009-05-12 00:18:31 +0200 (Tue, 12 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/common/gtk_util.cc

GTK: Don't custom paint background of findbar.

This makes the findbar look like the rest of the toolbar.

Review URL: http://codereview.chromium.org/113214
------------------------------------------------------------------------
r15798 | estade@chromium.org | 2009-05-12 00:18:19 +0200 (Tue, 12 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Download progress and complete animation on linux.

Review URL: http://codereview.chromium.org/113179
------------------------------------------------------------------------
r15796 | glen@chromium.org | 2009-05-12 00:04:16 +0200 (Tue, 12 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Fix browser theme provider cache miss crash.

BUG=11717

Review URL: http://codereview.chromium.org/113225
------------------------------------------------------------------------
r15795 | paulg@google.com | 2009-05-11 23:59:58 +0200 (Mon, 11 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc

Add a histogram to measure the number of times we ask
for a prefix that the SafeBrowsing servers have, but
that the full hashes provided in the response don't
match the URL we're looking up.

Review URL: http://codereview.chromium.org/115201
------------------------------------------------------------------------
r15792 | willchan@chromium.org | 2009-05-11 23:51:59 +0200 (Mon, 11 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Only show the original RWHV or the interstitial page at any time.
In Windows this doesn't matter, since the interstitial page just renders on top of the original RWHV.
In Linux, the two RWHV widgets are in the same content view vbox, so we need to hide one of them so they both don't render on the screen.
BUG=http://www.crbug.com/8486

Review URL: http://codereview.chromium.org/112014
------------------------------------------------------------------------
r15790 | shess@chromium.org | 2009-05-11 23:47:01 +0200 (Mon, 11 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Use Chrome facilities for omnibox state save and restore on Mac.

TabContents has a facility for storing a bag of stuff across
current-tab changes.  Wire up AutocompleteEditViewMac to use that
facility.  Unfork some code in Browser::TabSelectedAt() so that the
new code gets used, and straighten up the Mac code along the code path
between there and AutocompleteEditViewMac.

This overall change also exposed a couple bugs/mis-features in the
AutocompleteEditViewMac code.

TEST=Text field maintains contents and selection across tab changes, even when edited.

Review URL: http://codereview.chromium.org/114017
------------------------------------------------------------------------
r15789 | paulg@google.com | 2009-05-11 23:46:15 +0200 (Mon, 11 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc

Add a performance test for measuring hash implementation time.

Review URL: http://codereview.chromium.org/115198
------------------------------------------------------------------------
r15786 | pkasting@chromium.org | 2009-05-11 23:37:43 +0200 (Mon, 11 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Fix regression where exact-match URLs could fail to be promoted when longer URLs were typed more.

We should alwys look up whether we have an exact match, regardless of the input type, and use it if we have it.  My change to not add the "exact match" entry for UNKNOWN input should have only affected the case where that match doesn't, in fact, exist.

BUG=1844093
Review URL: http://codereview.chromium.org/113223
------------------------------------------------------------------------
r15785 | erikkay@google.com | 2009-05-11 23:30:30 +0200 (Mon, 11 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h

Add a comment to reflect API reality in RenderWidgetHostView.
See also http://codereview.chromium.org/113204 .

TBR=sky


Review URL: http://codereview.chromium.org/113224
------------------------------------------------------------------------
r15784 | xji@chromium.org | 2009-05-11 23:25:37 +0200 (Mon, 11 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

This CL revert the fix for issue 2780 - RTL: Omnibar - message "Press Tab to search Google" doesn't show correctly in a "New Tab" for RTL locales.
(http://crbug.com/2780)

Previous fix at http://codereview.chromium.org/100360 may have regressed the startup time by about 5ms/6.7% due to multiple call of PosFromChar().

Ts regression chart is at:
http://build.chromium.org/buildbot/perf/xp-release-dual-core/startup/report.html?history=150

I am reverting the CL while working on solutions.
Review URL: http://codereview.chromium.org/113221
------------------------------------------------------------------------
r15783 | mmoss@chromium.org | 2009-05-11 23:24:01 +0200 (Mon, 11 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/resources/linux-splash-chrome.html

Add splash appropriate for Linux official builds.

Review URL: http://codereview.chromium.org/115147

------------------------------------------------------------------------
r15781 | erikkay@google.com | 2009-05-11 23:18:12 +0200 (Mon, 11 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Fix a bug where the extension toolstrip could get reparented to the desktop.

BUG=11743
TEST=follow the steps described in the bug


Review URL: http://codereview.chromium.org/113204
------------------------------------------------------------------------
r15777 | shess@chromium.org | 2009-05-11 22:39:08 +0200 (Mon, 11 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Style the omnibox results for v2.

The style is based on the gtk code (autocomplete_popup_view_gtk.cc), with some local tweaks.  I broke this off from the rest of the review so I could experiment with making it nail omnibox-v2, but eventually realized that I don't have enough data for that.  This at least makes things look nicer, and I believe it provides all of the function that will be needed (the remainder is precisely defining fonts and colors and possibly minor highlighting variations).

Summary: I want something concrete so that complaints about v2 wrongness can be specific.

Review URL: http://codereview.chromium.org/99312
------------------------------------------------------------------------
r15769 | phajdan.jr@chromium.org | 2009-05-11 21:00:12 +0200 (Mon, 11 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc

Hopefully fix Windows compile by adding atlbase.h include on Windows.

I probably got bitten by precompiled headers. :-/

Review URL: http://codereview.chromium.org/115193
------------------------------------------------------------------------
r15768 | phajdan.jr@chromium.org | 2009-05-11 20:49:18 +0200 (Mon, 11 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_unittest.cc

De-couple TaskManager from TableView code.

This is another step towards porting the TaskManager.

TEST=Launch Chrome, open the task manager. You should see correctly reported and updated resource data.

http://crbug.com/11461

Review URL: http://codereview.chromium.org/115031
------------------------------------------------------------------------
r15755 | deanm@chromium.org | 2009-05-11 18:36:43 +0200 (Mon, 11 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Reimplement NineBox using Cairo.

- Fixes a bug we've had for a long time drawing the wrench button.  We would
  over-tile the center portion, and draw the right images on top of it.
- Move away from x1 .. x2 parameters to more clear width and height.
- Makes the code significantly more straightforward and efficient.

Review URL: http://codereview.chromium.org/115181

------------------------------------------------------------------------
r15749 | thestig@chromium.org | 2009-05-11 07:32:31 +0200 (Mon, 11 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Put test_user_data in a temp directory instead of using base::DIR_EXE. (try 2)

base::DIR_EXE could be a very long path, which causes socket creation to fail because socket paths have a limited length. Let's use a temp directory instead. We should also clean up the temp dir when we're done. Also abort if the socket path is too long.

Reviewed in issue 115107
Review URL: http://codereview.chromium.org/113193
------------------------------------------------------------------------
r15742 | darin@chromium.org | 2009-05-10 22:57:22 +0200 (Sun, 10 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/common/native_web_keyboard_event_mac.mm
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/mac/webview_host.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm

Fix mac build bustage.  I forgot about the .mm files!

TBR=dglazkov

------------------------------------------------------------------------
r15739 | darin@chromium.org | 2009-05-10 22:30:41 +0200 (Sun, 10 May 2009) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/chrome/common/native_web_keyboard_event_win.cc
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/media/video_renderer_impl.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/webmediaplayer_impl.cc
   M /trunk/src/chrome/renderer/webmediaplayer_impl.h
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/test/render_view_test.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   A /trunk/src/webkit/api (from /trunk/deps/third_party/WebKit/WebKit/chromium:15728)
   M /trunk/src/webkit/api/README
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/dragclient_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.cc
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.h
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webclipboard_impl.h
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.cc
   M /trunk/src/webkit/glue/webdropdata.cc
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webmediaplayerclient_impl.cc
   M /trunk/src/webkit/glue/webmediaplayerclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webthemeengine_impl_win.cc
   M /trunk/src/webkit/glue/webthemeengine_impl_win.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/glue/webworker_impl.cc
   M /trunk/src/webkit/glue/webworker_impl.h
   M /trunk/src/webkit/glue/webworkerclient_impl.cc
   M /trunk/src/webkit/glue/webworkerclient_impl.h
   M /trunk/src/webkit/tools/test_shell/drag_delegate.cc
   M /trunk/src/webkit/tools/test_shell/drop_delegate.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.cc
   M /trunk/src/webkit/tools/test_shell/mock_webclipboard_impl.h
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webworker_helper.cc
   M /trunk/src/webkit/tools/test_shell/test_webworker_helper.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_webworker.h
   M /trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   M /trunk/src/webkit/webkit.gyp

Move WebKit API to src/webkit/api.

R=dglazkov

Review URL: http://codereview.chromium.org/113186
------------------------------------------------------------------------
r15736 | apavlov@chromium.org | 2009-05-10 10:42:52 +0200 (Sun, 10 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h


Review URL: http://codereview.chromium.org/93119
------------------------------------------------------------------------
r15734 | ben@chromium.org | 2009-05-10 08:21:49 +0200 (Sun, 10 May 2009) | 2 lines
Changed paths:
   M /trunk/src/app/DEPS
   A /trunk/src/chrome/browser/views/chrome_views_delegate.cc
   A /trunk/src/chrome/browser/views/chrome_views_delegate.h
   A /trunk/src/views/views_delegate.h

Forgot to add these files as part of last change.

------------------------------------------------------------------------
r15733 | ben@chromium.org | 2009-05-10 07:58:40 +0200 (Sun, 10 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/DEPS
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/views.vcproj
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/window_delegate.cc

Add a new ViewsDelegate interface and implementation in the windows browser UI.

Provides a way for saving and restoring window placement, obtaining system helpers etc.

http://crbug.com/11633

TEST=make sure window placement saving works, clipboard, and that windows in the taskbar have a chrome icon.

Review URL: http://codereview.chromium.org/113173
------------------------------------------------------------------------
r15729 | aa@chromium.org | 2009-05-10 01:15:13 +0200 (Sun, 10 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Fix white flash when resizing window larger.

BUG=11544
TEST=Load a webpage, resize window larger. Window should not
flash white while resizing.

Review URL: http://codereview.chromium.org/113185
------------------------------------------------------------------------
r15728 | glen@chromium.org | 2009-05-09 20:38:30 +0200 (Sat, 09 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Fix NOTREACHED in status bubble if window is made too small.

Review URL: http://codereview.chromium.org/100150
------------------------------------------------------------------------
r15727 | glen@chromium.org | 2009-05-09 18:51:07 +0200 (Sat, 09 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h

Use scoped pointers for the theme information in an Extension.

Also includes http://codereview.chromium.org/115166 by Craig Schlenter

BUG=11692

Review URL: http://codereview.chromium.org/112012
------------------------------------------------------------------------
r15726 | glen@chromium.org | 2009-05-09 17:48:28 +0200 (Sat, 09 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc

Attempt to fix leak in extensions (no Purify here).

TBR=beng

Review URL: http://codereview.chromium.org/115165
------------------------------------------------------------------------
r15725 | ben@chromium.org | 2009-05-09 09:35:05 +0200 (Sat, 09 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/views/window/non_client_view.cc

Use the non-native frame when using themes even on Aero Glass.

Review URL: http://codereview.chromium.org/113183
------------------------------------------------------------------------
r15718 | glen@chromium.org | 2009-05-09 07:28:46 +0200 (Sat, 09 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Temporarily revert char* to std::string because Linux and Mac are throwing 'defined but not used' errors (the
strings are used by themes).

TBR=beng

Review URL: http://codereview.chromium.org/113184
------------------------------------------------------------------------
r15717 | glen@chromium.org | 2009-05-09 07:13:31 +0200 (Sat, 09 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc

Make 'reset theme' work.
GenerateFrameImages tweaking.
Convert global std::strings to char*

Review URL: http://codereview.chromium.org/115161
------------------------------------------------------------------------
r15716 | jcampan@chromium.org | 2009-05-09 06:55:25 +0200 (Sat, 09 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Fix the build in debug mode.

TBR=ben
Review URL: http://codereview.chromium.org/115160
------------------------------------------------------------------------
r15715 | jcampan@chromium.org | 2009-05-09 06:41:30 +0200 (Sat, 09 May 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

There was a potential race when showing the default browser info-bar on star-up,
between the info-bar showing and the first navigation.
If the first navigation was committed after the bar had been shown, the bar
would hide (as it is supposed to hide on navigation).
This CL makes the bar linger for few seconds before it is hidden on the next
navigation.

BUG=11427
TEST=Have a test server that blocks for few seconds before serving a page.
     Make that your home page (or set "sessino restore" and make that page your
     last visited page). Make sure Chrome is not the default browser.
     Start Chrome, the info-bar should appear and stay around. After few
     seconds have elapsed, navigating to another page should cause the info-bar
     to disappear.
TBR=ben
Review URL: http://codereview.chromium.org/113177
------------------------------------------------------------------------
r15714 | glen@chromium.org | 2009-05-09 06:10:45 +0200 (Sat, 09 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Some unnecessary painting and initing was being done.

TBR=beng

Review URL: http://codereview.chromium.org/113182
------------------------------------------------------------------------
r15712 | glen@chromium.org | 2009-05-09 05:15:24 +0200 (Sat, 09 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h

Random cleanups and stubs to get cross platform build going.

TBR=beng

Review URL: http://codereview.chromium.org/115158
------------------------------------------------------------------------
r15710 | glen@chromium.org | 2009-05-09 04:53:46 +0200 (Sat, 09 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_theme_provider.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

To get things green:
- Add ifdef for filepath init (there is probably a better way of doing this).
- Make Linux UI use active/inactive tabs instead of hover/OTR.

TBR=beng

Review URL: http://codereview.chromium.org/113180
------------------------------------------------------------------------
r15709 | glen@chromium.org | 2009-05-09 04:19:19 +0200 (Sat, 09 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/chrome.gyp

Add browser_theme_provider to GYP so that Mac and Linux can build.

Temporarily remove theme resource validation to get unittests passing.

TBR=beng

Review URL: http://codereview.chromium.org/113178
------------------------------------------------------------------------
r15708 | glen@chromium.org | 2009-05-09 03:53:45 +0200 (Sat, 09 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Add stubs for UserChangedThemes to Mac and Linux.

Review URL: http://codereview.chromium.org/115156
------------------------------------------------------------------------
r15706 | glen@chromium.org | 2009-05-09 03:30:19 +0200 (Sat, 09 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc

Remove unnecessary win_util from dom_ui.

TBR=beng

Review URL: http://codereview.chromium.org/113175
------------------------------------------------------------------------
r15704 | glen@chromium.org | 2009-05-09 03:07:42 +0200 (Sat, 09 May 2009) | 9 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/app.vcproj
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle.h
   A /trunk/src/app/theme_provider.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/theme/app_top_center.png
   M /trunk/src/chrome/app/theme/app_top_left.png
   M /trunk/src/chrome/app/theme/app_top_right.png
   M /trunk/src/chrome/app/theme/back.png
   M /trunk/src/chrome/app/theme/back_d.png
   D /trunk/src/chrome/app/theme/constrained_bottom_center.png
   D /trunk/src/chrome/app/theme/constrained_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/constrained_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/constrained_left_side.png
   D /trunk/src/chrome/app/theme/constrained_right_side.png
   D /trunk/src/chrome/app/theme/constrained_top_center.png
   D /trunk/src/chrome/app/theme/constrained_top_left_corner.png
   D /trunk/src/chrome/app/theme/constrained_top_right_corner.png
   M /trunk/src/chrome/app/theme/content_bottom_center.png
   M /trunk/src/chrome/app/theme/content_bottom_left_corner.png
   M /trunk/src/chrome/app/theme/content_bottom_right_corner.png
   M /trunk/src/chrome/app/theme/content_left_side.png
   M /trunk/src/chrome/app/theme/content_right_side.png
   M /trunk/src/chrome/app/theme/content_top_center.png
   M /trunk/src/chrome/app/theme/content_top_left_corner.png
   M /trunk/src/chrome/app/theme/content_top_right_corner.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_center.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_center_otr.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_left_corner_otr.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_right_corner_otr.png
   D /trunk/src/chrome/app/theme/dewindow_left_side.png
   D /trunk/src/chrome/app/theme/dewindow_left_side_otr.png
   D /trunk/src/chrome/app/theme/dewindow_right_side.png
   D /trunk/src/chrome/app/theme/dewindow_right_side_otr.png
   D /trunk/src/chrome/app/theme/dewindow_top_center.png
   D /trunk/src/chrome/app/theme/dewindow_top_center_otr.png
   D /trunk/src/chrome/app/theme/dewindow_top_left_corner.png
   D /trunk/src/chrome/app/theme/dewindow_top_left_corner_otr.png
   D /trunk/src/chrome/app/theme/dewindow_top_right_corner.png
   D /trunk/src/chrome/app/theme/dewindow_top_right_corner_otr.png
   M /trunk/src/chrome/app/theme/forward.png
   M /trunk/src/chrome/app/theme/forward_d.png
   M /trunk/src/chrome/app/theme/go.png
   M /trunk/src/chrome/app/theme/locationbg.png
   M /trunk/src/chrome/app/theme/menu_chrome.png
   M /trunk/src/chrome/app/theme/menu_page.png
   A /trunk/src/chrome/app/theme/notused.png
   A /trunk/src/chrome/app/theme/ntp_background.png
   M /trunk/src/chrome/app/theme/reload.png
   M /trunk/src/chrome/app/theme/reload_d.png
   M /trunk/src/chrome/app/theme/star.png
   M /trunk/src/chrome/app/theme/star_d.png
   M /trunk/src/chrome/app/theme/starred.png
   M /trunk/src/chrome/app/theme/stop.png
   M /trunk/src/chrome/app/theme/tab_active_center.png
   M /trunk/src/chrome/app/theme/tab_active_left.png
   M /trunk/src/chrome/app/theme/tab_active_right.png
   D /trunk/src/chrome/app/theme/tab_hover_center.png
   D /trunk/src/chrome/app/theme/tab_hover_left.png
   D /trunk/src/chrome/app/theme/tab_hover_right.png
   M /trunk/src/chrome/app/theme/tab_inactive_center.png
   D /trunk/src/chrome/app/theme/tab_inactive_center_otr.png
   D /trunk/src/chrome/app/theme/tab_inactive_center_v.png
   M /trunk/src/chrome/app/theme/tab_inactive_left.png
   D /trunk/src/chrome/app/theme/tab_inactive_left_otr.png
   D /trunk/src/chrome/app/theme/tab_inactive_left_v.png
   M /trunk/src/chrome/app/theme/tab_inactive_right.png
   D /trunk/src/chrome/app/theme/tab_inactive_right_otr.png
   D /trunk/src/chrome/app/theme/tab_inactive_right_v.png
   A /trunk/src/chrome/app/theme/theme_frame_default.png
   A /trunk/src/chrome/app/theme/theme_frame_default_inactive.png
   A /trunk/src/chrome/app/theme/theme_frame_default_incognito.png
   A /trunk/src/chrome/app/theme/theme_frame_default_incognito_inactive.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/app/theme/theme_tab_background.png
   A /trunk/src/chrome/app/theme/theme_tab_background_glass.png
   A /trunk/src/chrome/app/theme/theme_tab_background_incognito.png
   A /trunk/src/chrome/app/theme/theme_toolbar_default.png
   M /trunk/src/chrome/app/theme/window_bottom_center.png
   D /trunk/src/chrome/app/theme/window_bottom_center_otr.png
   M /trunk/src/chrome/app/theme/window_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/window_bottom_left_corner_otr.png
   M /trunk/src/chrome/app/theme/window_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/window_bottom_right_corner_otr.png
   M /trunk/src/chrome/app/theme/window_left_side.png
   D /trunk/src/chrome/app/theme/window_left_side_otr.png
   M /trunk/src/chrome/app/theme/window_right_side.png
   D /trunk/src/chrome/app/theme/window_right_side_otr.png
   M /trunk/src/chrome/app/theme/window_top_center.png
   D /trunk/src/chrome/app/theme/window_top_center_otr.png
   M /trunk/src/chrome/app/theme/window_top_left_corner.png
   D /trunk/src/chrome/app/theme/window_top_left_corner_otr.png
   M /trunk/src/chrome/app/theme/window_top_right_corner.png
   D /trunk/src/chrome/app/theme/window_top_right_corner_otr.png
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/browser_theme_provider.cc
   A /trunk/src/chrome/browser/browser_theme_provider.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_theme_source.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   A /trunk/src/chrome/test/data/extensions/theme.crx
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils.h
   M /trunk/src/skia/ext/skia_utils_unittest.cc
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/views.vcproj
   A /trunk/src/views/widget/default_theme_provider.cc
   A /trunk/src/views/widget/default_theme_provider.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h

This is the first pass at themes.

This CL is paired with http://codereview.chromium.org/67284

This CL (for commit purposes) includes http://codereview.chromium.org/67284

BUG=4463,11232,11233,11234,11235

Review URL: http://codereview.chromium.org/99030
------------------------------------------------------------------------
r15703 | paulg@google.com | 2009-05-09 03:06:18 +0200 (Sat, 09 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Decrease the SafeBrowsing false positive rate.

This CL replaces the weak hashing functions of the bloom
filter for a more thorough mixing function. The bloom
filter is modified to use and store random keys in the
mixing function. This addresses the need for randomizing
the contents of each user's bloom filter to prevent a
false positive for a popular site causing a global spike
in hash requests.

BUG=10584 (http://crbug.com/10584)
BUG=10634 (http://crbug.com/10634)

Review URL: http://codereview.chromium.org/113064
------------------------------------------------------------------------
r15702 | pkasting@chromium.org | 2009-05-09 02:33:04 +0200 (Sat, 09 May 2009) | 2 lines
Changed paths:
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Implement the popup blocking whitelist pref.  This makes the whitelist actually function.BUG=11440
Review URL: http://codereview.chromium.org/115149
------------------------------------------------------------------------
r15701 | cpu@google.com | 2009-05-09 02:27:42 +0200 (Sat, 09 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add customized first run tabs
- More refactor of BrowserInit and LaunchWithProfile
- hardcoded magic names : new_tab_page and welcome_page

BUG=9706

TEST=see the bug for detailed instructions.

Review URL: http://codereview.chromium.org/115139
------------------------------------------------------------------------
r15698 | mbelshe@google.com | 2009-05-09 02:02:24 +0200 (Sat, 09 May 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Defer window.close(), resizeTo() and moveTo() actions
by posting a task back to the message loop before notifying
the RenderWidgetHost to perform these operations.
Otherwise the JS code races with the browser to use the
modified window.

BUG=http://crbug.com/6377
BUG=http://crbug.com/6192

Cache a pending_window_rect on the render_view (moved from
prior CL where I had it on the chrome_client_impl).  This 
is a short lived cache, and not a complete solution.  It
fixes this case, where a JS script makes multiple operations
and expects the GetWindowSize() to be correct immedately
after having called SetWindowSize().  

BUG=http://crbug.com/835



Review URL: http://codereview.chromium.org/115030
------------------------------------------------------------------------
r15695 | willchan@chromium.org | 2009-05-09 01:14:39 +0200 (Sat, 09 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/tools/valgrind/suppressions.txt

Stop leaking RenderWidgetHostViewGtk.

Don't bother calling gfx::RemoveAllChildren() in TabContentsViewGtk when creating a new RWHV, since any previously existing RWHV widget should already have been deleted.

This also fixes interstitial pages crashing.  Although instead we have two RWHV widgets in the same TabContentsView vbox :)  I'll fix that in a later changelist.

Also update the valgrind suppressions file.

BUG=http://www.crbug.com/10747
BUG=http://www.crbug.com/8486

Review URL: http://codereview.chromium.org/115145
------------------------------------------------------------------------
r15694 | ben@chromium.org | 2009-05-09 01:12:25 +0200 (Sat, 09 May 2009) | 5 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/app.vcproj
   M /trunk/src/app/gfx/icon_util.cc
   M /trunk/src/app/gfx/text_elider.cc
   M /trunk/src/app/os_exchange_data.cc
   M /trunk/src/app/os_exchange_data_unittest.cc
   A /trunk/src/app/win_util.cc (from /trunk/src/chrome/common/win_util.cc:15686)
   A /trunk/src/app/win_util.h (from /trunk/src/chrome/common/win_util.h:15686)
   A /trunk/src/app/win_util_unittest.cc (from /trunk/src/chrome/common/win_util_unittest.cc:15686)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/win_safe_util.cc
   D /trunk/src/chrome/common/win_util.cc
   D /trunk/src/chrome/common/win_util.h
   D /trunk/src/chrome/common/win_util_unittest.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/views/DEPS
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/drag_utils.cc
   M /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/window_win.cc

Move win_util.h from common to app.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113169
------------------------------------------------------------------------
r15691 | xji@chromium.org | 2009-05-09 00:43:37 +0200 (Sat, 09 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc

This CL fix issue 9837 - RTL: "Pop-ups blocked" bar should be at left-bottom for RTL Chrome.

The fix is to position the 'pop-ups blocked' bar at the bottom left for RTL chrome.

Test:
1. Launch Hebrew Chrome
2. load http://www.brg8.com/
3. Observe the 'pop-up blocked' bar after the page load.
Review URL: http://codereview.chromium.org/89004
------------------------------------------------------------------------
r15688 | ben@chromium.org | 2009-05-09 00:15:31 +0200 (Sat, 09 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

move this to app/gfx, part of previous commit
------------------------------------------------------------------------
r15687 | ben@chromium.org | 2009-05-09 00:14:38 +0200 (Sat, 09 May 2009) | 4 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/gfx/color_utils.cc (from /trunk/src/chrome/common/gfx/color_utils.cc:15683)
   A /trunk/src/app/gfx/color_utils.h (from /trunk/src/chrome/common/gfx/color_utils.h:15683)
   A /trunk/src/app/gfx/text_elider.cc (from /trunk/src/chrome/common/gfx/text_elider.cc:15683)
   A /trunk/src/app/gfx/text_elider.h (from /trunk/src/chrome/common/gfx/text_elider.h:15683)
   A /trunk/src/app/gfx/text_elider_unittest.cc (from /trunk/src/chrome/common/gfx/text_elider_unittest.cc:15683)
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   D /trunk/src/chrome/browser/drag_utils.cc
   D /trunk/src/chrome/browser/drag_utils.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/printing/page_overlays.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   D /trunk/src/chrome/browser/views/standard_layout.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/accessibility_types.h
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/gfx/color_utils.cc
   D /trunk/src/chrome/common/gfx/color_utils.h
   D /trunk/src/chrome/common/gfx/text_elider.cc
   D /trunk/src/chrome/common/gfx/text_elider.h
   D /trunk/src/chrome/common/gfx/text_elider_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/views/DEPS
   A /trunk/src/views/accessibility/accessibility_types.h (from /trunk/src/chrome/common/accessibility_types.h:15683)
   M /trunk/src/views/accessibility/view_accessibility.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/message_box_view.cc
   A /trunk/src/views/drag_utils.cc (from /trunk/src/chrome/browser/drag_utils.cc:15683)
   A /trunk/src/views/drag_utils.h (from /trunk/src/chrome/browser/drag_utils.h:15683)
   A /trunk/src/views/standard_layout.h (from /trunk/src/chrome/browser/views/standard_layout.h:15683)
   M /trunk/src/views/view.h
   M /trunk/src/views/views.vcproj
   M /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/window/dialog_client_view.cc

Move color_utils, text_elider, drag_utils, accessibility_types, standard_layout to new locations in app/ and views/

http://crbug.com/11387
Review URL: http://codereview.chromium.org/113143
------------------------------------------------------------------------
r15685 | mbelshe@google.com | 2009-05-09 00:09:56 +0200 (Sat, 09 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Landing approved patch for Yuta Kitamura (yutak@google.com)

This patch fixes an assertion failure that occurs when Windows is back
from sleep.  

BUG=11141

Original changelist is http://codereview.chromium.org/109034


------------------------------------------------------------------------
r15682 | huanr@chromium.org | 2009-05-08 23:26:07 +0200 (Fri, 08 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Fix a potential crash in automation framework when
a browser window is closed.

BUG=http://crbug.com/11659

Review URL: http://codereview.chromium.org/113155
------------------------------------------------------------------------
r15681 | estade@chromium.org | 2009-05-08 23:18:02 +0200 (Fri, 08 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h

Linux: Store/restore focus in tab contents during tab swithcing.

BUG=8604

Review URL: http://codereview.chromium.org/113166
------------------------------------------------------------------------
r15680 | erikkay@google.com | 2009-05-08 23:09:11 +0200 (Fri, 08 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/views/controls/native_view_host.cc
   M /trunk/src/views/controls/native_view_host.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h

Add PreferredSizeChanged() to View to allow subviews to notify their parents that they'd really like another layout.R=skyTEST=none
Review URL: http://codereview.chromium.org/113133
------------------------------------------------------------------------
r15676 | tc@google.com | 2009-05-08 22:39:25 +0200 (Fri, 08 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/webkit/webkit.gyp

Enable generation of da.pak, he,pak, and zh-TW.pak.  Re-enable
locale UI tests on windows and linux.

Not sure if this will work on mac with resource bundles, so leaving
this disabled for now.

BUG=9758

Review URL: http://codereview.chromium.org/113158

------------------------------------------------------------------------
r15671 | pkasting@chromium.org | 2009-05-08 21:41:49 +0200 (Fri, 08 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_host.h
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.h
   M /trunk/src/chrome/browser/debugger/debugger_io.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.h

Enable ctrl-shift-L for app/popup windows and fix a crash.  Patch by Yusuke Sato (see http://codereview.chromium.org/115050 ), r=me.

BUG=8071,11559
------------------------------------------------------------------------
r15670 | pkasting@chromium.org | 2009-05-08 21:38:31 +0200 (Fri, 08 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Various popup UI fixes:
* Remove "show popup notification" option, pref, and all associated machinery.
* Toggling whitelisting on for a site no longer hides the "manage" button.
* Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button.

Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents.

BUG=11440
Review URL: http://codereview.chromium.org/115112
------------------------------------------------------------------------
r15667 | mal@chromium.org | 2009-05-08 21:05:11 +0200 (Fri, 08 May 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   M /trunk/src/chrome/browser/security/resources/ssl_error.html
   M /trunk/src/chrome/browser/security/resources/ssl_roadblock.html

Fix for b/1837411 -- Interstitial title lines bleed together.

The line height for titles in the warning interstitials is too small. 
In English, a second line starts to abut the line above it if the 
browser is narrow.

In languages with ligatures above the line, a second line bleeds 
into the first, impairing readability. This is compounded in languages
like Tamil and Marathi, where the title of the interstitial warning 
is quite long and likely to break on two lines.

My solution is to set the line height to 140% in the .title.

TEST= Navigate to ianfette.org with Chrome's lang set to ta or mr. The title 
lines in the anti-malware blocking page should not bleed together.
BUG= 1837411
Review URL: http://codereview.chromium.org/113140
------------------------------------------------------------------------
r15666 | estade@chromium.org | 2009-05-08 21:01:11 +0200 (Fri, 08 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/link_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Linux: clean up some focus issues.

- Set focus to render view after finishing find.
- Make all custom buttons unfocusable. (matches windows chrome)
- Let the GtkWindow's default keyhandler run when the child widget fails to handle the key press event. Previously I optimized this out, but it turns out to be necessary because when a tab is pressed while focus is at the boundary of a child widget (e.g. the last button in an infobar) the focus has to traverse to the next child widget (e.g. the render view), and this is handled by the GtkWindow's key handler (and not the infobar's key handler).

BUG=8604,11560
Review URL: http://codereview.chromium.org/115113
------------------------------------------------------------------------
r15665 | estade@chromium.org | 2009-05-08 21:01:02 +0200 (Fri, 08 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/icon_loader.h
   A /trunk/src/chrome/browser/icon_loader_linux.cc
   A /trunk/src/chrome/browser/icon_loader_mac.mm
   M /trunk/src/chrome/browser/icon_loader_win.cc
   D /trunk/src/chrome/browser/icon_loader_win.h
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/icon_manager.h
   A /trunk/src/chrome/browser/icon_manager_linux.cc
   A /trunk/src/chrome/browser/icon_manager_mac.mm
   A /trunk/src/chrome/browser/icon_manager_win.cc
   M /trunk/src/chrome/chrome.gyp

Stub implementation of linux, mac icon loader/manager.

Define a platform specific type IconGroupID which helps with caching multiple requests for the same icon. Previously we just used the file path (or the extension), but on POSIX we use mime types rather than extensions.
Review URL: http://codereview.chromium.org/113120
------------------------------------------------------------------------
r15663 | stoyan@chromium.org | 2009-05-08 20:44:44 +0200 (Fri, 08 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Pass external tab handle when Chrome sends outgoing notifications through automation interface.
Review URL: http://codereview.chromium.org/115134
------------------------------------------------------------------------
r15651 | evan@chromium.org | 2009-05-08 19:50:40 +0200 (Fri, 08 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash.html

linux: new splash page.

Review URL: http://codereview.chromium.org/113148
------------------------------------------------------------------------
r15650 | erg@google.com | 2009-05-08 19:37:42 +0200 (Fri, 08 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Update the instructional text's visibility on bookmark add/remove events.

Review URL: http://codereview.chromium.org/114016
------------------------------------------------------------------------
r15649 | tc@google.com | 2009-05-08 19:33:05 +0200 (Fri, 08 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Remove a comment that doesn't seem to be true anymore.  Change to using an assert.

I tried using a debugger to repro, but was unable to.

BUG=9914

Review URL: http://codereview.chromium.org/115111

------------------------------------------------------------------------
r15642 | erg@google.com | 2009-05-08 18:36:08 +0200 (Fri, 08 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Fix regression introduced in r15560 where all bookmark buttons became folders.

http://crbug.com/11628

Review URL: http://codereview.chromium.org/113134
------------------------------------------------------------------------
r15638 | pinkerton@chromium.org | 2009-05-08 17:55:45 +0200 (Fri, 08 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Fix default browser info string to change text and color instead of hiding/showing. Record default browser metric.
Review URL: http://codereview.chromium.org/115129
------------------------------------------------------------------------
r15635 | phajdan.jr@chromium.org | 2009-05-08 16:41:08 +0200 (Fri, 08 May 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/common/important_file_writer.cc
   M /trunk/src/chrome/common/important_file_writer.h
   M /trunk/src/chrome/common/important_file_writer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h

Converted BookmarkStorage to use ImportantFileWriter

Also made BookmarkStorage completely responsible for
migration of bookmark data from history database.
Previously the logic crossed file and class boundaries a few
times. This made it a bit hard to follow. Now it should be
a bit more clear.

Made ImportantFileWriter also batch data serializations.

TEST=Make sure that bookmarks still work. Also test migrating bookmarks from history database.

http://crbug.com/10618

Review URL: http://codereview.chromium.org/99192
------------------------------------------------------------------------
r15633 | pfeldman@chromium.org | 2009-05-08 13:28:32 +0200 (Fri, 08 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

DevTools: Style drive by

Review URL: http://codereview.chromium.org/115124
------------------------------------------------------------------------
r15612 | huanr@chromium.org | 2009-05-08 04:29:15 +0200 (Fri, 08 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc

Try fixing session restore UI tests.
  - Change async ApplyAccelerator to sync RunCommand.
  - Renable disabled tests.

Review URL: http://codereview.chromium.org/113129
------------------------------------------------------------------------
r15608 | hclam@chromium.org | 2009-05-08 03:46:46 +0200 (Fri, 08 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Revert r15607
r15607 broke the build
TBR=brg, thestig

------------------------------------------------------------------------
r15607 | thestig@chromium.org | 2009-05-08 03:20:25 +0200 (Fri, 08 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Put test_user_data in a temp directory instead of using base::DIR_EXE.

base::DIR_EXE could be a very long path, which causes socket creation to fail because socket paths have a limited length. Let's use a temp directory instead. We should also clean up the temp dir when we're done.

Also abort if the socket path is too long.
Review URL: http://codereview.chromium.org/115107
------------------------------------------------------------------------
r15604 | ben@chromium.org | 2009-05-08 02:34:05 +0200 (Fri, 08 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/app_modal_dialog_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_win.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/debugger/devtools_view.h
   M /trunk/src/chrome/browser/debugger/devtools_window_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.h
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/event_utils.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.h
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/standard_layout.h
   M /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/uninstall_dialog.cc
   M /trunk/src/chrome/browser/views/uninstall_dialog.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   D /trunk/src/chrome/views
   A /trunk/src/views (from /trunk/src/chrome/views:15557)
   M /trunk/src/views/DEPS
   M /trunk/src/views/accelerator.cc
   M /trunk/src/views/accelerator.h
   M /trunk/src/views/accessibility/view_accessibility.cc
   M /trunk/src/views/accessibility/view_accessibility.h
   M /trunk/src/views/accessibility/view_accessibility_wrapper.cc
   M /trunk/src/views/accessibility/view_accessibility_wrapper.h
   M /trunk/src/views/background.cc
   M /trunk/src/views/background.h
   M /trunk/src/views/border.cc
   M /trunk/src/views/border.h
   M /trunk/src/views/controls/button/button.cc
   M /trunk/src/views/controls/button/button.h
   M /trunk/src/views/controls/button/button_dropdown.cc
   M /trunk/src/views/controls/button/button_dropdown.h
   M /trunk/src/views/controls/button/checkbox.cc
   M /trunk/src/views/controls/button/checkbox.h
   M /trunk/src/views/controls/button/custom_button.cc
   M /trunk/src/views/controls/button/custom_button.h
   M /trunk/src/views/controls/button/image_button.cc
   M /trunk/src/views/controls/button/image_button.h
   M /trunk/src/views/controls/button/menu_button.cc
   M /trunk/src/views/controls/button/menu_button.h
   M /trunk/src/views/controls/button/native_button.cc
   M /trunk/src/views/controls/button/native_button.h
   M /trunk/src/views/controls/button/native_button_win.cc
   M /trunk/src/views/controls/button/native_button_win.h
   M /trunk/src/views/controls/button/native_button_wrapper.h
   M /trunk/src/views/controls/button/radio_button.cc
   M /trunk/src/views/controls/button/radio_button.h
   M /trunk/src/views/controls/button/text_button.cc
   M /trunk/src/views/controls/button/text_button.h
   M /trunk/src/views/controls/combo_box.cc
   M /trunk/src/views/controls/combo_box.h
   M /trunk/src/views/controls/hwnd_view.cc
   M /trunk/src/views/controls/hwnd_view.h
   M /trunk/src/views/controls/image_view.cc
   M /trunk/src/views/controls/image_view.h
   M /trunk/src/views/controls/label.cc
   M /trunk/src/views/controls/label.h
   M /trunk/src/views/controls/label_unittest.cc
   M /trunk/src/views/controls/link.cc
   M /trunk/src/views/controls/link.h
   M /trunk/src/views/controls/menu/chrome_menu.cc
   M /trunk/src/views/controls/menu/chrome_menu.h
   M /trunk/src/views/controls/menu/controller.h
   M /trunk/src/views/controls/menu/menu.cc
   M /trunk/src/views/controls/menu/menu.h
   M /trunk/src/views/controls/menu/view_menu_delegate.h
   M /trunk/src/views/controls/message_box_view.cc
   M /trunk/src/views/controls/message_box_view.h
   M /trunk/src/views/controls/native_control.cc
   M /trunk/src/views/controls/native_control.h
   M /trunk/src/views/controls/native_control_win.cc
   M /trunk/src/views/controls/native_control_win.h
   M /trunk/src/views/controls/native_view_host.cc
   M /trunk/src/views/controls/native_view_host.h
   M /trunk/src/views/controls/scroll_view.cc
   M /trunk/src/views/controls/scroll_view.h
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/bitmap_scroll_bar.h
   M /trunk/src/views/controls/scrollbar/native_scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/native_scroll_bar.h
   M /trunk/src/views/controls/scrollbar/scroll_bar.cc
   M /trunk/src/views/controls/scrollbar/scroll_bar.h
   M /trunk/src/views/controls/separator.cc
   M /trunk/src/views/controls/separator.h
   M /trunk/src/views/controls/single_split_view.cc
   M /trunk/src/views/controls/single_split_view.h
   M /trunk/src/views/controls/tabbed_pane.cc
   M /trunk/src/views/controls/tabbed_pane.h
   M /trunk/src/views/controls/table/group_table_view.cc
   M /trunk/src/views/controls/table/group_table_view.h
   M /trunk/src/views/controls/table/table_view.cc
   M /trunk/src/views/controls/table/table_view.h
   M /trunk/src/views/controls/table/table_view_unittest.cc
   M /trunk/src/views/controls/text_field.cc
   M /trunk/src/views/controls/text_field.h
   M /trunk/src/views/controls/throbber.cc
   M /trunk/src/views/controls/throbber.h
   M /trunk/src/views/controls/tree/tree_model.h
   M /trunk/src/views/controls/tree/tree_node_iterator.h
   M /trunk/src/views/controls/tree/tree_node_iterator_unittest.cc
   M /trunk/src/views/controls/tree/tree_node_model.h
   M /trunk/src/views/controls/tree/tree_view.cc
   M /trunk/src/views/controls/tree/tree_view.h
   M /trunk/src/views/event.cc
   M /trunk/src/views/event.h
   M /trunk/src/views/event_gtk.cc
   M /trunk/src/views/event_win.cc
   M /trunk/src/views/fill_layout.cc
   M /trunk/src/views/fill_layout.h
   M /trunk/src/views/focus/external_focus_tracker.cc
   M /trunk/src/views/focus/external_focus_tracker.h
   M /trunk/src/views/focus/focus_manager.cc
   M /trunk/src/views/focus/focus_manager.h
   M /trunk/src/views/focus/focus_manager_unittest.cc
   M /trunk/src/views/focus/focus_util_win.cc
   M /trunk/src/views/focus/focus_util_win.h
   M /trunk/src/views/focus/view_storage.cc
   M /trunk/src/views/focus/view_storage.h
   M /trunk/src/views/grid_layout.cc
   M /trunk/src/views/grid_layout.h
   M /trunk/src/views/grid_layout_unittest.cc
   M /trunk/src/views/layout_manager.cc
   M /trunk/src/views/layout_manager.h
   M /trunk/src/views/painter.cc
   M /trunk/src/views/painter.h
   M /trunk/src/views/repeat_controller.cc
   M /trunk/src/views/repeat_controller.h
   M /trunk/src/views/view.cc
   M /trunk/src/views/view.h
   M /trunk/src/views/view_constants.cc
   M /trunk/src/views/view_constants.h
   M /trunk/src/views/view_gtk.cc
   M /trunk/src/views/view_unittest.cc
   M /trunk/src/views/view_win.cc
   M /trunk/src/views/views.vcproj
   M /trunk/src/views/widget/accelerator_handler.cc
   M /trunk/src/views/widget/accelerator_handler.h
   M /trunk/src/views/widget/aero_tooltip_manager.cc
   M /trunk/src/views/widget/aero_tooltip_manager.h
   M /trunk/src/views/widget/root_view.cc
   M /trunk/src/views/widget/root_view.h
   M /trunk/src/views/widget/root_view_drop_target.cc
   M /trunk/src/views/widget/root_view_drop_target.h
   M /trunk/src/views/widget/root_view_gtk.cc
   M /trunk/src/views/widget/root_view_win.cc
   M /trunk/src/views/widget/tooltip_manager.cc
   M /trunk/src/views/widget/tooltip_manager.h
   M /trunk/src/views/widget/widget.h
   M /trunk/src/views/widget/widget_gtk.cc
   M /trunk/src/views/widget/widget_gtk.h
   M /trunk/src/views/widget/widget_win.cc
   M /trunk/src/views/widget/widget_win.h
   M /trunk/src/views/window/client_view.cc
   M /trunk/src/views/window/client_view.h
   M /trunk/src/views/window/custom_frame_view.cc
   M /trunk/src/views/window/custom_frame_view.h
   M /trunk/src/views/window/dialog_client_view.cc
   M /trunk/src/views/window/dialog_client_view.h
   M /trunk/src/views/window/dialog_delegate.cc
   M /trunk/src/views/window/dialog_delegate.h
   M /trunk/src/views/window/native_frame_view.cc
   M /trunk/src/views/window/native_frame_view.h
   M /trunk/src/views/window/non_client_view.cc
   M /trunk/src/views/window/non_client_view.h
   M /trunk/src/views/window/window.h
   M /trunk/src/views/window/window_delegate.cc
   M /trunk/src/views/window/window_delegate.h
   M /trunk/src/views/window/window_resources.h
   M /trunk/src/views/window/window_win.cc
   M /trunk/src/views/window/window_win.h

Move src/chrome/views to src/views. RS=darin http://crbug.com/11387
------------------------------------------------------------------------
r15602 | tc@google.com | 2009-05-08 02:12:38 +0200 (Fri, 08 May 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/hung_renderer_dialog_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add hung renderer dialog on linux.  Pretty much just follow the
windows view code and do the same thing.

BUG=11083

Review URL: http://codereview.chromium.org/115109

------------------------------------------------------------------------
r15596 | mpcomplete@google.com | 2009-05-08 01:39:47 +0200 (Fri, 08 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc

Fix memory leak in SiteInstance::CreateSiteInstanceForURL.

TBR=creis
Review URL: http://codereview.chromium.org/115110
------------------------------------------------------------------------
r15595 | cpu@google.com | 2009-05-08 01:37:59 +0200 (Fri, 08 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc

Refactor BrowserInit in preparation for customized first run tabs
- BrowserInit is now a instanciable class
- The 'bag of static functions' part is mostly unchanged
- unused members in the interface moved to the cc file

TEST= no visible change. interactive UI tests sufice

BUG=9706


Review URL: http://codereview.chromium.org/113113
------------------------------------------------------------------------
r15587 | aa@chromium.org | 2009-05-07 23:44:12 +0200 (Thu, 07 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Make background pages work more nicely with the tabs API.

Changed ExtensionHost so that it returns NULL if it doesn't have
a browser, instead of getting the last active one. The problem
is that if ExtensionHost returns the last active browser at the
time it's constructed, it might be garbage by the time it is
used.

Changed tab functions to use more consistent logic to determine
the 'current' browser to operate on.

Review URL: http://codereview.chromium.org/115071
------------------------------------------------------------------------
r15586 | estade@chromium.org | 2009-05-07 23:42:56 +0200 (Thu, 07 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Move pgup/dn special casing to browser window gtk.

Review URL: http://codereview.chromium.org/112006
------------------------------------------------------------------------
r15582 | erg@google.com | 2009-05-07 23:24:30 +0200 (Thu, 07 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Implement the "(empty)" disabled item placed in empty bookmark menus.

(As a side effect, this patch also fixes disabled items in the rest
of the bookmarks bar.)

Review URL: http://codereview.chromium.org/113119
------------------------------------------------------------------------
r15579 | huanr@chromium.org | 2009-05-07 22:51:42 +0200 (Thu, 07 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h

Consolidate notifiers used by different automation
IPC messages.
Make OpenIncognito synchronuous.

Review URL: http://codereview.chromium.org/115092
------------------------------------------------------------------------
r15577 | estade@chromium.org | 2009-05-07 22:42:24 +0200 (Thu, 07 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/icon_loader.h
   A /trunk/src/chrome/browser/icon_loader_win.cc
   A /trunk/src/chrome/browser/icon_loader_win.h
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/chrome.gyp

Windows icon loader refactor in preparation for port.

Review URL: http://codereview.chromium.org/115056
------------------------------------------------------------------------
r15573 | xji@chromium.org | 2009-05-07 22:14:29 +0200 (Thu, 07 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

this CL changes some comments in the fix of issue 2780

BUG=http://crbug.com/2780
Review URL: http://codereview.chromium.org/115097
------------------------------------------------------------------------
r15572 | estade@chromium.org | 2009-05-07 22:03:06 +0200 (Thu, 07 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Linux: enable unload ui tests, which pass after r15025 (and again after r15332).

Review URL: http://codereview.chromium.org/99294
------------------------------------------------------------------------
r15571 | estade@chromium.org | 2009-05-07 21:44:25 +0200 (Thu, 07 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Clicking right mouse button after selecting an image (or a whitespace character)
brings up a context menu containing "Search Google for''".

This change will fix the above by not adding the menu item if the selection
string is empty.

BUG=10798

patch by yuzo@google.com
original review: <http://codereview.chromium.org/100246>

------------------------------------------------------------------------
r15570 | estade@chromium.org | 2009-05-07 21:37:55 +0200 (Thu, 07 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

GTK: Handle some accelerators after the focused widget has had a chance to handle the keypress.

Also, don't try to give the browser commands that are disabled.

----

(this description may need to be re-written)

BUG=11526
Review URL: http://codereview.chromium.org/113050
------------------------------------------------------------------------
r15568 | pinkerton@chromium.org | 2009-05-07 21:26:00 +0200 (Thu, 07 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Enable the zoom button and stub out an implementation until we can get the real rect from WebCore.
Review URL: http://codereview.chromium.org/115096
------------------------------------------------------------------------
r15565 | mpcomplete@google.com | 2009-05-07 21:21:16 +0200 (Thu, 07 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.h

Fix an issue with SiteInstance where special URLs would not always get grouped
together.

This is also useful for chrome-extension URLs, where we want any URLs for a
given extension to be grouped in the same process.

BUG=11501,11002
Review URL: http://codereview.chromium.org/115003
------------------------------------------------------------------------
r15562 | xji@chromium.org | 2009-05-07 20:35:15 +0200 (Thu, 07 May 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

This CL fixes issue 2780 - RTL: Omnibar - message "Press Tab to search Google" doesn't show correctly in a "New Tab" for RTL locales.
(http://crbug.com/2780)

The error happens in LocationBarView::TextDisplayWidth() which does not correctly calculate the location entry's text display width.

The fix itself contains comments so hope it is self-explained.

Test steps:
1. Start Chrome with a new user data directory (or clean up all browsing data) and make sure the UI language is Hebrew.
2 Type www.google.com in the omnibox and press Enter.
3 Close and re-open the browser.
4 Type character "h" in Ominibox

Without the fix, only "tab" button is showing as keyword hint.
With the fix, Hebrew translation of "press tab to search google" is displayed. Please be noted: you need to have enough space in omnibox in order for the whole keyword hint to be displayed, otherwise, only "tab" button will be displayed.
Review URL: http://codereview.chromium.org/100360
------------------------------------------------------------------------
r15560 | erg@google.com | 2009-05-07 20:18:50 +0200 (Thu, 07 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Connect a menu to the "Other bookmarks" button.

Review URL: http://codereview.chromium.org/113104
------------------------------------------------------------------------
r15559 | evan@chromium.org | 2009-05-07 20:17:44 +0200 (Thu, 07 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

linux: use possibly_invalid_spec() for displaying a URL.

BUG=11472

Review URL: http://codereview.chromium.org/113109
------------------------------------------------------------------------
r15558 | ben@chromium.org | 2009-05-07 20:09:08 +0200 (Thu, 07 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc

Adjust the position of the tabstrip to leave space for window controls in RTL languages.

http://crbug.com/11223
Review URL: http://codereview.chromium.org/115091
------------------------------------------------------------------------
r15551 | pinkerton@chromium.org | 2009-05-07 18:03:04 +0200 (Thu, 07 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Fix bug with cocoa -> gfx coordinates.
Review URL: http://codereview.chromium.org/115089
------------------------------------------------------------------------
r15549 | avi@google.com | 2009-05-07 17:46:44 +0200 (Thu, 07 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm

Still need to release all top-level objects of a nib.

Review URL: http://codereview.chromium.org/115045
------------------------------------------------------------------------
r15547 | deanm@chromium.org | 2009-05-07 17:34:49 +0200 (Thu, 07 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/views/location_bar_view.h

Implement some basic drawing of Linux Omnibox SSL lock icons.

BUG=10965

Review URL: http://codereview.chromium.org/115084

------------------------------------------------------------------------
r15545 | deanm@chromium.org | 2009-05-07 16:22:25 +0200 (Thu, 07 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc

Change the Linux sad tab message wrapping to match Windows.

Allow the message to go multiline, and it will just clip if it can't fit.

Review URL: http://codereview.chromium.org/113099

------------------------------------------------------------------------
r15543 | pfeldman@chromium.org | 2009-05-07 15:54:11 +0200 (Thu, 07 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc

DevTools: Preserve WebInspector window while switching RenderViewHost.

Review URL: http://codereview.chromium.org/115082
------------------------------------------------------------------------
r15538 | phajdan.jr@chromium.org | 2009-05-07 13:04:17 +0200 (Thu, 07 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Don't link-depend on views/ in chrome/browser/gtk

This is a preparation for removing even more dependencies on views/
on Linux, but further parts are more complicated.

http://crbug.com/11066

Review URL: http://codereview.chromium.org/115078
------------------------------------------------------------------------
r15537 | hbono@chromium.org | 2009-05-07 10:20:43 +0200 (Thu, 07 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Uses the MirroringContext class in omnibox2.
Because of the lack of my comments, omnibox2 does not use this MirroringContext class to re-order the text runs and fragments. (Sorry for the lack of comments.)
This change uses the MirroringContext class and adds comments that describe it.
Review URL: http://codereview.chromium.org/100248
------------------------------------------------------------------------
r15526 | pfeldman@chromium.org | 2009-05-07 08:27:41 +0200 (Thu, 07 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_manager_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

DevTools: Enable debugging of non-TabContents including extensions.

Review URL: http://codereview.chromium.org/115028
------------------------------------------------------------------------
r15489 | ben@chromium.org | 2009-05-07 03:32:50 +0200 (Thu, 07 May 2009) | 15 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/hwnd_notification_source.h (from /trunk/src/chrome/views/widget/hwnd_notification_source.h:15470)
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/views/controls/native_control.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc
   M /trunk/src/chrome/views/focus/focus_manager.h
   M /trunk/src/chrome/views/focus/view_storage.cc
   M /trunk/src/chrome/views/focus/view_storage.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   D /trunk/src/chrome/views/widget/hwnd_notification_source.h
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/window/window.h
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Remove all traces of NotificationService from views.

Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay.

Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work.

Moves the HWNDNotificationSource to common, since it's used by BrowserView.

Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed.

http://crbug.com/11387


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15468
Review URL: http://codereview.chromium.org/113016
------------------------------------------------------------------------
r15487 | hclam@chromium.org | 2009-05-07 03:15:09 +0200 (Thu, 07 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc

Disable some unit tests due to webkit merge 43242:43321

TBR=darin
BUG=11569

Disabling these two tests:
  RenderViewTest.ExtensionMessagesOpenChannel
  RenderViewTest.ExtensionMessagesOnConnect


Review URL: http://codereview.chromium.org/115054
------------------------------------------------------------------------
r15484 | glen@chromium.org | 2009-05-07 02:52:59 +0200 (Thu, 07 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Remove a no-longer needed hack that appeared to break button layout for NTP form controls in Arabic on firstview.

BUG=11484
TEST=Launch Chrome in Arabic, on the first new tab page that appears click _Remove Thumbnails_, and verify that the buttons have the same content as subsequent new tab pages opened in that session. (Open a new NTP with Ctrl+T and compare).
TBR=arv
Review URL: http://codereview.chromium.org/113071
------------------------------------------------------------------------
r15481 | aa@chromium.org | 2009-05-07 02:14:31 +0200 (Thu, 07 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Add inspect links for all active views in chrome://extensions.

Also:
* Add ID to the information in chrome://extensions.
* Call ExtensionMessageService::RegisterExtension() for all
  RVHs, not just ExtensionHost.
* Teach RVHD to be able to return the current URL.
* Renamed "background" to "background_page" in the manifest.

Review URL: http://codereview.chromium.org/113027
------------------------------------------------------------------------
r15475 | pkasting@chromium.org | 2009-05-07 01:46:22 +0200 (Thu, 07 May 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Popup whitelisting checkpoint.

This provides some basic UI for the popup whitelist.  The actual whitelist is completely unimplemented and just has TODOs at the hook points.  The actual blocking behavior of the browser is unchanged.

The popup blocker bubble menu now gets an extra section below the popups with checkable "Always show popups from <host>" items (usually one, can be more on pages with popups from iframes from different hosts).  Clicking one of these will whitelist a hostname and open its popups, and remove it from the menu.  When navigating to a page with whitelisted popups, the popup blocker bubble is opened (showing "Blocked Popups: 0", text subject to change), and the menu contains the checked entr(y/ies) relevant to these page.  Clicking one of these un-whitelists the host and removes the entry from the menu (closing the menu if that was the last such entry).

Known UI questions:
* Wording is all speculative
* Should manually closing all popups associated with a whitelisted site remove that entry/close the menu automatically?  (I suspect yes)
* Should un-whitelisting a site via the menu entry close its popups, just like whitelisting it opens them?  (Not sure)
* Should menu items for sites stick around after toggling their whitelisting status, thus keeping the bubble onscreen until it's manually closed, the page is navigated, etc.?  (While this is slightly more consistent, I suspect the answer is no)

BUG=11440
Review URL: http://codereview.chromium.org/113058
------------------------------------------------------------------------
r15472 | rafaelw@chromium.org | 2009-05-07 01:36:33 +0200 (Thu, 07 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

BUG=112200
R=erikkay

Review URL: http://codereview.chromium.org/115033
------------------------------------------------------------------------
r15470 | ben@chromium.org | 2009-05-07 01:23:11 +0200 (Thu, 07 May 2009) | 1 line
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/hwnd_notification_source.h
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/views/controls/native_control.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc
   M /trunk/src/chrome/views/focus/focus_manager.h
   M /trunk/src/chrome/views/focus/view_storage.cc
   M /trunk/src/chrome/views/focus/view_storage.h
   M /trunk/src/chrome/views/views.vcproj
   A /trunk/src/chrome/views/widget/hwnd_notification_source.h (from /trunk/src/chrome/views/widget/hwnd_notification_source.h:15467)
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/window/window.h
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Reverting 15468.
------------------------------------------------------------------------
r15468 | ben@chromium.org | 2009-05-07 00:52:08 +0200 (Thu, 07 May 2009) | 13 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/hwnd_notification_source.h (from /trunk/src/chrome/views/widget/hwnd_notification_source.h:15365)
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/views/controls/native_control.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc
   M /trunk/src/chrome/views/focus/focus_manager.h
   M /trunk/src/chrome/views/focus/view_storage.cc
   M /trunk/src/chrome/views/focus/view_storage.h
   M /trunk/src/chrome/views/views.vcproj
   D /trunk/src/chrome/views/widget/hwnd_notification_source.h
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/window/window.h
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Remove all traces of NotificationService from views.

Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay.

Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work.

Moves the HWNDNotificationSource to common, since it's used by BrowserView.

Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113016
------------------------------------------------------------------------
r15465 | arv@chromium.org | 2009-05-07 00:19:26 +0200 (Thu, 07 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Fix issue where the favicon got centered vertically in RTL mode instead of
keeping the value from the previous rule. The default value for
background-position-y is center if not specified.

http://crbug.com/11549

Review URL: http://codereview.chromium.org/113059
------------------------------------------------------------------------
r15463 | erg@google.com | 2009-05-07 00:03:00 +0200 (Thu, 07 May 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_gtk.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.cc:15462)
   A /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller_win.h (from /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.h:15462)
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/chrome.gyp

Clicking on a folder in the bookmark bar now shows its contents as a menu.

http://crbug.com/11250

Review URL: http://codereview.chromium.org/114005
------------------------------------------------------------------------
r15461 | estade@chromium.org | 2009-05-06 23:24:14 +0200 (Wed, 06 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Raise the find bar window every time it's shown via Show().

(It shouldn't be necessary to raise it when it's shown via SetDialogPosition().)

BUG=11515

Review URL: http://codereview.chromium.org/113055
------------------------------------------------------------------------
r15454 | mpcomplete@google.com | 2009-05-06 22:56:05 +0200 (Wed, 06 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   A /trunk/src/chrome/browser/extensions/extension_process_manager.h
   A /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc (from /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc:15292)
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Resurrect ExtensionProcessManager.  Move the code for starting extension
instances from ExtensionsService to the manager.

Unlike ExtensionsService, EPM is not shared between an incognito Profile and
its parent.
Review URL: http://codereview.chromium.org/109044
------------------------------------------------------------------------
r15453 | erikkay@google.com | 2009-05-06 22:42:22 +0200 (Wed, 06 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_shelf.cc

Tweak the padding around toolstrips on the extension shelf.

Review URL: http://codereview.chromium.org/113051
------------------------------------------------------------------------
r15452 | pinkerton@chromium.org | 2009-05-06 22:37:46 +0200 (Wed, 06 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm

Messed up dependency key in one case when applying feedback. TBR=thomasvl
Review URL: http://codereview.chromium.org/113049
------------------------------------------------------------------------
r15450 | erikkay@google.com | 2009-05-06 22:16:53 +0200 (Wed, 06 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Skip the download shelf altogether for extension downloads.  The current UI looks pretty weird with it.  This won't work great for larger extensions that take more than a couple of seconds to download, but we'll address that with extension specific UI when the DL manager is refactored.

TEST=download a crx file, verify that it installs with no shelf.  download another type of file, verify that it uses the shelf properly.
Review URL: http://codereview.chromium.org/113038
------------------------------------------------------------------------
r15446 | jcampan@chromium.org | 2009-05-06 21:44:37 +0200 (Wed, 06 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc

The last redesign of interstitial pages made them to be a render view painted on top of the normal page.
Because they were not know from the tab contents container, the actual hidden page behind them would still get focus. That was particularly noticeable when tabbing.

BUG=11505
TEST=Open a page that triggers an interstitial (ex: https://ebay.com). Press tab to cycle the focus.
     Make sure the focus is moved as expected.
Review URL: http://codereview.chromium.org/113039
------------------------------------------------------------------------
r15445 | pinkerton@chromium.org | 2009-05-06 21:41:37 +0200 (Wed, 06 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm
   M /trunk/src/chrome/browser/shell_integration.h
   A /trunk/src/chrome/browser/shell_integration_mac.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/pref_member.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   A /trunk/src/third_party/mozilla/include/NSWorkspace+Utils.h
   A /trunk/src/third_party/mozilla/include/NSWorkspace+Utils.m
   M /trunk/src/third_party/mozilla/include/README.chromium

Implement most of the "basics" pref panel on Mac, including code to set the default browser. Fix up some related comments around the code.
Review URL: http://codereview.chromium.org/113032
------------------------------------------------------------------------
r15435 | willchan@chromium.org | 2009-05-06 20:45:56 +0200 (Wed, 06 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/sad_tab_gtk.cc
   A /trunk/src/chrome/browser/gtk/sad_tab_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/chrome.gyp

Render a "sad tab" on tab crash.
Uses the NotificationRegistrar to notice TAB_CONTENTS_[DIS]CONNECTED events.  When it disconnects, add a SadTabGtk to the TabContentsView.  Delete it when the tab contents reconnects.
BUG=http://www.crbug.com/11081
TEST=Open http://about:crash.  Verify that the sad tab renders properly.  Navigate to another page to make sure the SadTabGtk is correctly replaced with a new RenderWidgetHostViewGtk.

Review URL: http://codereview.chromium.org/111003
------------------------------------------------------------------------
r15434 | stoyan@chromium.org | 2009-05-06 20:45:33 +0200 (Wed, 06 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

Destroy browser/content related C++ object on WM_DESTROY message, rather than OnFinalMessage
Review URL: http://codereview.chromium.org/115034
------------------------------------------------------------------------
r15430 | estade@chromium.org | 2009-05-06 20:24:08 +0200 (Wed, 06 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

Linux: remember user's last selected path for select file dialogs.

Note that paths are remembered separately for save and open. This is *not* the same behavior as windows chrome/linux firefox, which remember the same path for both save and open. My justification is the following scenario:

1. User presses ctrl-o, and selects a file from the desktop.
2. One hour later, user presses ctrl-s to save a webpage.
3. User expects to be saving to his default download dir, but instead gets the desktop.
4. Huh?

Review URL: http://codereview.chromium.org/115007
------------------------------------------------------------------------
r15427 | erikkay@google.com | 2009-05-06 20:08:08 +0200 (Wed, 06 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Fix for a DCHECK regression introduced by http://codereview.chromium.org/112001
Code was removing itself as an observer for something it was no longer observing.

TEST=interactive_ui_tests.exe --gtest_filter=BookmarkBarViewTest1.Basic

TBR=sky

Review URL: http://codereview.chromium.org/113037
------------------------------------------------------------------------
r15424 | tc@google.com | 2009-05-06 19:53:26 +0200 (Wed, 06 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/hung_renderer_dialog.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   D /trunk/src/chrome/browser/views/hung_renderer_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Refactor view from methods to show hung renderer dialog.

This moves the methods into a header that all platforms
can use and keeps the windows implementation in
hung_renderer_view.cc.

Review URL: http://codereview.chromium.org/109039
------------------------------------------------------------------------
r15423 | dglazkov@chromium.org | 2009-05-06 19:37:21 +0200 (Wed, 06 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc

Add an extra colon to make inspector work again.

This was broken by http://codereview.chromium.org/101026.


R=glen
BUG=11532
TESt=open inspector. Inspector shouldn't show a blank page.

Review URL: http://codereview.chromium.org/113034
------------------------------------------------------------------------
r15422 | tc@google.com | 2009-05-06 19:15:42 +0200 (Wed, 06 May 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc

Fix the "pick a new user data dir" dialog on windows.

There were three things to be fixed:
1) We don't need to run a separate message loop after the
dialog closes.  The MessageLoopForUI handles this properly.
2) When tearing down browser_process_impl, io_loop
hasn't been initialized yet, so we check to make sure it
exists before using it.
3) We don't call window->Close() because that deletes the
dialog class before we're done using it.  This means we leak
the window, but that's ok because we're going to exit anyway.

Review URL: http://codereview.chromium.org/114004
------------------------------------------------------------------------
r15417 | erikkay@google.com | 2009-05-06 18:58:56 +0200 (Wed, 06 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_shelf.cc
   A /trunk/src/chrome/browser/extensions/extension_shelf.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Create a separate UI surface for extensions (bottom shelf) and remove them from the bookmarks bar (for now).
The current implementation doesn't do anything new except for always appear when extensions are loaded.

TEST=install an extension and see it show up in the new bottom bar
TEST=unit_tests.exe --gtest_filter=ExtensionViewTest.BottomBar


Review URL: http://codereview.chromium.org/112001
------------------------------------------------------------------------
r15416 | jcampan@chromium.org | 2009-05-06 18:48:06 +0200 (Wed, 06 May 2009) | 8 lines
Changed paths:
   D /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Adding a test for a testing that the bug http://crbug.com/9791 is really fixed.
Removing the interstitial UI tests: they test the same functionalities as the unit-tests but are flacky and
most of them have been disabled (a new unit-test for the "show interstitial and then navigate back" has been added to cover for a case that the unit-tests were not covering).

TEST=Run the unit-tests.
BUG=6729,3327

Review URL: http://codereview.chromium.org/109038
------------------------------------------------------------------------
r15415 | finnur@chromium.org | 2009-05-06 18:46:11 +0200 (Wed, 06 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/page_action.cc
   M /trunk/src/chrome/common/page_action.h

PageActions now work across tabs and windows.

The extension system now provides TabId to extensions so it is now possible to activate PageActions in other tabs besides the first in the tab strip. :)

BUG=None
TEST=None (requires a PageAction extension to test against).

Review URL: http://codereview.chromium.org/109046
------------------------------------------------------------------------
r15409 | maruel@chromium.org | 2009-05-06 17:08:12 +0200 (Wed, 06 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Reverting 15399.

broke purify
Review URL: http://codereview.chromium.org/115026
------------------------------------------------------------------------
r15405 | deanm@chromium.org | 2009-05-06 14:26:42 +0200 (Wed, 06 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Redraw the location bar on reload. This change is Gtk+ port of 100198.

http://codereview.chromium.org/100198

Patch by Yusuke Sato.

Review URL: http://codereview.chromium.org/106007

------------------------------------------------------------------------
r15402 | deanm@chromium.org | 2009-05-06 11:44:44 +0200 (Wed, 06 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.h

Improvements to Linux InfoBubble and BookmarkBubble.
  - Introduce a delegate to notify when the bubble is closed.
  - Destroy the objects when the widgets are destroyed.
  - Cleanup some style issues, add a bunch more comments.

Review URL: http://codereview.chromium.org/99276

------------------------------------------------------------------------
r15399 | brettw@chromium.org | 2009-05-06 10:50:23 +0200 (Wed, 06 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Change Browser::GetIndexOfController to GetIndexOfTabContents. Now that we
don't have tab contents switching, identifying tabs by their controller is
weird, so we should gradually move to only using TabContents*.
Review URL: http://codereview.chromium.org/115018
------------------------------------------------------------------------
r15398 | yurys@google.com | 2009-05-06 10:30:00 +0200 (Wed, 06 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.h

In process-per-tab mode devtools window may be open for the devtools window using hotkey. This should be useful for development.
Review URL: http://codereview.chromium.org/108028
------------------------------------------------------------------------
r15396 | brettw@chromium.org | 2009-05-06 10:03:15 +0200 (Wed, 06 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc

Reset the window favicon when the throbber is complete. This fixes the bug using
the Vista frame for popups that the throbber icon is never replaced.

http://crbug.com/8078
Review URL: http://codereview.chromium.org/113024
------------------------------------------------------------------------
r15395 | phajdan.jr@chromium.org | 2009-05-06 09:27:40 +0200 (Wed, 06 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

Make task_manager.h a bit more independent from views.

Let the internal TaskManagerContents be the DialogDelegate
instead of the TaskManager itself.

This is a small step towards porting the TaskManager.

TEST=Launch chrome.exe, open the Task Manager, close it. Close the browser. Nothing should be broken, the browser should not crash.

http://crbug.com/11461

Review URL: http://codereview.chromium.org/111002
------------------------------------------------------------------------
r15393 | rafaelw@chromium.org | 2009-05-06 08:54:36 +0200 (Wed, 06 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h

Added FindTabById which finds the Browser, TabStripModel, TabContents & index associated with a given tab_id.

tabs.get(), move(), update() & delete() can now find tabs in any window by the tab_id

BUG=11200
R=mpComplete

Review URL: http://codereview.chromium.org/110005
------------------------------------------------------------------------
r15392 | rafaelw@chromium.org | 2009-05-06 08:44:39 +0200 (Wed, 06 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html
   M /trunk/src/chrome/test/in_process_browser_test.cc

honor index in createTab()

BUG=11200
R=brettw,beng

Review URL: http://codereview.chromium.org/99300
------------------------------------------------------------------------
r15387 | estade@chromium.org | 2009-05-06 07:16:50 +0200 (Wed, 06 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Merge two TabContents::InvalidateTypes types and properly update tab download icon.

INVALIDATE_FAVICON and INVALIDATE_TITLE become INVALIDATE_TAB. Also removed some dead code.

TEST=starting a download in a tab should show the download icon. Closing the dshelf should make the icon disappear.

Review URL: http://codereview.chromium.org/109050
------------------------------------------------------------------------
r15382 | estade@chromium.org | 2009-05-06 06:42:16 +0200 (Wed, 06 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h

Find bar:

- system bell for linux find bar when search not found
- move "not found" logic to find bar controller

Review URL: http://codereview.chromium.org/112002
------------------------------------------------------------------------
r15379 | huanr@chromium.org | 2009-05-06 06:23:43 +0200 (Wed, 06 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h

Make RestoreTab synchronuous.

Review URL: http://codereview.chromium.org/109053
------------------------------------------------------------------------
r15378 | glen@chromium.org | 2009-05-06 06:21:16 +0200 (Wed, 06 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   M /trunk/src/chrome/common/extensions/url_pattern_unittest.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc

Change chrome-ui to chrome. I didn't go too far in converting existing strings to using the url_constant (shipshipship).

Users (such as those on Beta and Dev using session restore) attempting to load the old pages will see a blank white screen.

BUG=11272
TEST=Verify that the inspector, debugger, history, downloads and newtab pages load with chrome:// URLS. Verify that replacing the chrome:// with chrome-ui:// does not work.


Review URL: http://codereview.chromium.org/101026
------------------------------------------------------------------------
r15371 | ben@chromium.org | 2009-05-06 04:23:31 +0200 (Wed, 06 May 2009) | 4 lines
Changed paths:
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/drag_drop_types.cc (from /trunk/src/chrome/common/drag_drop_types.cc:15365)
   A /trunk/src/app/drag_drop_types.h (from /trunk/src/chrome/common/drag_drop_types.h:15365)
   A /trunk/src/app/gfx/favicon_size.h (from /trunk/src/chrome/common/gfx/favicon_size.h:15365)
   A /trunk/src/app/gfx/icon_util.cc (from /trunk/src/chrome/common/gfx/icon_util.cc:15365)
   A /trunk/src/app/gfx/icon_util.h (from /trunk/src/chrome/common/gfx/icon_util.h:15365)
   A /trunk/src/app/gfx/icon_util_unittest.cc (from /trunk/src/chrome/common/gfx/icon_util_unittest.cc:15365)
   A /trunk/src/app/gfx/insets.h (from /trunk/src/chrome/common/gfx/insets.h:15365)
   A /trunk/src/app/gfx/path.h (from /trunk/src/chrome/common/gfx/path.h:15365)
   A /trunk/src/app/gfx/path_gtk.cc (from /trunk/src/chrome/common/gfx/path_gtk.cc:15365)
   A /trunk/src/app/gfx/path_win.cc (from /trunk/src/chrome/common/gfx/path_win.cc:15365)
   A /trunk/src/app/message_box_flags.h (from /trunk/src/chrome/common/message_box_flags.h:15365)
   A /trunk/src/app/os_exchange_data.cc (from /trunk/src/chrome/common/os_exchange_data.cc:15365)
   A /trunk/src/app/os_exchange_data.h (from /trunk/src/chrome/common/os_exchange_data.h:15365)
   A /trunk/src/app/os_exchange_data_unittest.cc (from /trunk/src/chrome/common/os_exchange_data_unittest.cc:15365)
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/uninstall_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/drag_drop_types.cc
   D /trunk/src/chrome/common/drag_drop_types.h
   D /trunk/src/chrome/common/gfx/favicon_size.h
   D /trunk/src/chrome/common/gfx/icon_util.cc
   D /trunk/src/chrome/common/gfx/icon_util.h
   D /trunk/src/chrome/common/gfx/icon_util_unittest.cc
   D /trunk/src/chrome/common/gfx/insets.h
   D /trunk/src/chrome/common/gfx/path.h
   D /trunk/src/chrome/common/gfx/path_gtk.cc
   D /trunk/src/chrome/common/gfx/path_win.cc
   D /trunk/src/chrome/common/message_box_flags.h
   D /trunk/src/chrome/common/os_exchange_data.cc
   D /trunk/src/chrome/common/os_exchange_data.h
   D /trunk/src/chrome/common/os_exchange_data_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/border.h
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/label.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.h
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/table/table_view.cc
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/controls/throbber.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/view_win.cc
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/root_view_drop_target.cc
   M /trunk/src/chrome/views/widget/root_view_drop_target.h
   M /trunk/src/chrome/views/widget/root_view_win.cc
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/dialog_delegate.h
   M /trunk/src/chrome/views/window/window_win.cc

Move: drag_drop_types, favicon_size, icon_util, insets, path, message_box_flags, os_exchange_data to src/app

http://crbug.com/11387
Review URL: http://codereview.chromium.org/115012
------------------------------------------------------------------------
r15368 | estade@chromium.org | 2009-05-06 03:19:23 +0200 (Wed, 06 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Add a lot of hotkeys to linux.

BUG=11476
Review URL: http://codereview.chromium.org/108037
------------------------------------------------------------------------
r15367 | ben@chromium.org | 2009-05-06 03:13:41 +0200 (Wed, 06 May 2009) | 5 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/app.vcproj
   M /trunk/src/app/gfx/chrome_canvas.cc
   M /trunk/src/app/gfx/chrome_canvas_linux.cc
   M /trunk/src/app/gfx/chrome_canvas_win.cc
   A /trunk/src/app/gfx/chrome_font.h (from /trunk/src/chrome/common/gfx/chrome_font.h:15360)
   A /trunk/src/app/gfx/chrome_font_gtk.cc (from /trunk/src/chrome/common/gfx/chrome_font_gtk.cc:15360)
   A /trunk/src/app/gfx/chrome_font_mac.mm (from /trunk/src/chrome/common/gfx/chrome_font_mac.mm:15360)
   A /trunk/src/app/gfx/chrome_font_skia.cc (from /trunk/src/chrome/common/gfx/chrome_font_skia.cc:15360)
   A /trunk/src/app/gfx/chrome_font_unittest.cc (from /trunk/src/chrome/common/gfx/chrome_font_unittest.cc:15360)
   A /trunk/src/app/gfx/chrome_font_win.cc (from /trunk/src/chrome/common/gfx/chrome_font_win.cc:15360)
   M /trunk/src/app/resource_bundle.cc
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_mac.mm
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/gfx/chrome_font.h
   D /trunk/src/chrome/common/gfx/chrome_font_gtk.cc
   D /trunk/src/chrome/common/gfx/chrome_font_mac.mm
   D /trunk/src/chrome/common/gfx/chrome_font_skia.cc
   D /trunk/src/chrome/common/gfx/chrome_font_unittest.cc
   D /trunk/src/chrome/common/gfx/chrome_font_win.cc
   M /trunk/src/chrome/common/gfx/text_elider.cc
   M /trunk/src/chrome/common/gfx/text_elider.h
   M /trunk/src/chrome/common/gfx/text_elider_unittest.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/controls/button/menu_button.h
   M /trunk/src/chrome/views/controls/button/native_button.h
   M /trunk/src/chrome/views/controls/button/text_button.h
   M /trunk/src/chrome/views/controls/combo_box.cc
   M /trunk/src/chrome/views/controls/label.cc
   M /trunk/src/chrome/views/controls/label.h
   M /trunk/src/chrome/views/controls/link.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.h
   M /trunk/src/chrome/views/controls/menu/menu.cc
   M /trunk/src/chrome/views/controls/tabbed_pane.cc
   M /trunk/src/chrome/views/controls/text_field.h
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.h
   M /trunk/src/chrome/views/window/window_win.cc

move chrome_font to app/gfx

http://crbug.com/11387

Review URL: http://codereview.chromium.org/115010
------------------------------------------------------------------------
r15364 | evan@chromium.org | 2009-05-06 02:49:56 +0200 (Wed, 06 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Uncomment the crash checks in UITest::TearDown since CountFilesCreatedAfter
has been implemented for POSIX environment.

BUG=9833

Review URL: http://codereview.chromium.org/99360
Patch from Albert Bachand <albertb@google.com>.
------------------------------------------------------------------------
r15361 | ben@chromium.org | 2009-05-06 02:39:23 +0200 (Wed, 06 May 2009) | 5 lines
Changed paths:
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/gfx
   A /trunk/src/app/gfx/chrome_canvas.cc (from /trunk/src/chrome/common/gfx/chrome_canvas.cc:15352)
   A /trunk/src/app/gfx/chrome_canvas.h (from /trunk/src/chrome/common/gfx/chrome_canvas.h:15352)
   A /trunk/src/app/gfx/chrome_canvas_linux.cc (from /trunk/src/chrome/common/gfx/chrome_canvas_linux.cc:15352)
   A /trunk/src/app/gfx/chrome_canvas_win.cc (from /trunk/src/chrome/common/gfx/chrome_canvas_win.cc:15352)
   M /trunk/src/app/l10n_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/gfx/chrome_canvas.cc
   D /trunk/src/chrome/common/gfx/chrome_canvas.h
   D /trunk/src/chrome/common/gfx/chrome_canvas_linux.cc
   D /trunk/src/chrome/common/gfx/chrome_canvas_win.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/border.cc
   M /trunk/src/chrome/views/controls/button/checkbox.cc
   M /trunk/src/chrome/views/controls/button/image_button.cc
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/combo_box.cc
   M /trunk/src/chrome/views/controls/hwnd_view.cc
   M /trunk/src/chrome/views/controls/image_view.cc
   M /trunk/src/chrome/views/controls/label.cc
   M /trunk/src/chrome/views/controls/label_unittest.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/menu/menu.cc
   M /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/controls/single_split_view.cc
   M /trunk/src/chrome/views/controls/tabbed_pane.cc
   M /trunk/src/chrome/views/controls/table/group_table_view.cc
   M /trunk/src/chrome/views/controls/table/table_view.cc
   M /trunk/src/chrome/views/controls/throbber.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/view_win.cc
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/root_view_gtk.cc
   M /trunk/src/chrome/views/widget/root_view_win.cc
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc

Move chrome_canvas to app/gfx

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113011
------------------------------------------------------------------------
r15359 | jungshik@google.com | 2009-05-06 02:11:57 +0200 (Wed, 06 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc

Make the width of the reset options confirmation dialog localizable.It's currently hard-coded to be 400, but it needs to be localizable.I made it localizable and set the value to 80 (which makes it exactly the same width as the current one) for most locales except for Malayalam for which it's too narrow. Once reviewed and landed in the trunk, this need to be merged to the branch. BUG=11267
TEST=Run CHrome with '--lang=ml', go to Options | Advanced and click on 'Restore the defaul settings' button 
at the bottom. The dialog box popping up should not have any truncated strings due to the dimension of the dialog being too small
Review URL: http://codereview.chromium.org/100008
------------------------------------------------------------------------
r15354 | scherkus@chromium.org | 2009-05-06 02:00:15 +0200 (Wed, 06 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/renderer/media/simple_data_source.cc
   A /trunk/src/chrome/renderer/media/simple_data_source.h
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/renderer/webmediaplayer_delegate_impl.cc

Add --simple-data-source which uses simplified media resource loading.

Comes in really handy for demo purposes and for testing playback performance with buffering and range requests removed from the equation.

Review URL: http://codereview.chromium.org/109049
------------------------------------------------------------------------
r15353 | wtc@chromium.org | 2009-05-06 01:55:59 +0200 (Wed, 06 May 2009) | 14 lines
Changed paths:
   M /trunk/src/base/hmac.h
   M /trunk/src/base/hmac_mac.cc
   M /trunk/src/base/hmac_nss.cc
   M /trunk/src/base/hmac_unittest.cc
   M /trunk/src/base/hmac_win.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc

Separate the key setting code in the constructor of HMAC class into the Init
method.

Overload the Init method for char* and std::string.

Add DCHECKs to the destruction methods in ~HMAC in hmac_win.cc.

The patch is written by Takeshi Yoshino <tyoshino@google.com>.
Original code review: http://codereview.chromium.org/88062

R=wtc
http://crbug.com/2297
TEST=base_unittests should pass.  Safe browsing should continue to work.
Review URL: http://codereview.chromium.org/113001
------------------------------------------------------------------------
r15352 | ben@chromium.org | 2009-05-06 01:38:56 +0200 (Wed, 06 May 2009) | 4 lines
Changed paths:
   M /trunk/src/app/DEPS
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/l10n_util.cc (from /trunk/src/chrome/common/l10n_util.cc:15319)
   A /trunk/src/app/l10n_util.h (from /trunk/src/chrome/common/l10n_util.h:15319)
   A /trunk/src/app/l10n_util_posix.cc (from /trunk/src/chrome/common/l10n_util_posix.cc:15319)
   A /trunk/src/app/l10n_util_unittest.cc (from /trunk/src/chrome/common/l10n_util_unittest.cc:15319)
   A /trunk/src/app/l10n_util_win.cc (from /trunk/src/chrome/common/l10n_util_win.cc:15319)
   A /trunk/src/app/l10n_util_win.h (from /trunk/src/chrome/common/l10n_util_win.h:15319)
   M /trunk/src/app/resource_bundle_linux.cc
   M /trunk/src/app/resource_bundle_win.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_gtk.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/input_window_dialog_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/uninstall_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas_win.cc
   M /trunk/src/chrome/common/gfx/chrome_font_win.cc
   D /trunk/src/chrome/common/l10n_util.cc
   D /trunk/src/chrome/common/l10n_util.h
   D /trunk/src/chrome/common/l10n_util_posix.cc
   D /trunk/src/chrome/common/l10n_util_unittest.cc
   D /trunk/src/chrome/common/l10n_util_win.cc
   D /trunk/src/chrome/common/l10n_util_win.h
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/common/time_format_unittest.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/controls/button/button_dropdown.cc
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/button/native_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/combo_box.cc
   M /trunk/src/chrome/views/controls/label.cc
   M /trunk/src/chrome/views/controls/label_unittest.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/menu/menu.cc
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/native_control.cc
   M /trunk/src/chrome/views/controls/native_control_win.cc
   M /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/controls/tabbed_pane.cc
   M /trunk/src/chrome/views/controls/table/table_view.cc
   M /trunk/src/chrome/views/controls/table/table_view.h
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/widget/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/widget/tooltip_manager.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc

Move l10n_util to app/

http://crbug.com/11387
Review URL: http://codereview.chromium.org/109043
------------------------------------------------------------------------
r15340 | jhawkins@chromium.org | 2009-05-05 23:54:35 +0200 (Tue, 05 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Handle mouse back and forward buttons for page navigation.

BUG=11439
Review URL: http://codereview.chromium.org/108038
------------------------------------------------------------------------
r15335 | estade@chromium.org | 2009-05-05 22:50:44 +0200 (Tue, 05 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

Linux download shelf: remove download items when the associated download is removed.

BUG=11381
TEST=in opt mode: download something, go to downloads tab, clear all, go back to tab with downloaded item. The shelf should be gone.

Review URL: http://codereview.chromium.org/100366
------------------------------------------------------------------------
r15334 | jhawkins@chromium.org | 2009-05-05 22:43:09 +0200 (Tue, 05 May 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/gtk/tabs/tab_button_gtk.cc
   D /trunk/src/chrome/browser/gtk/tabs/tab_button_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Remove the no-longer used TabButtonGtk class.
Review URL: http://codereview.chromium.org/108035
------------------------------------------------------------------------
r15330 | jhawkins@chromium.org | 2009-05-05 22:27:00 +0200 (Tue, 05 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   A /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc
   A /trunk/src/chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/chrome.gyp

Implement Linux tabs as widgets.  This moves tab input handling into the correct object.  This change also adds an initial DraggedTabControllerGtk.
Review URL: http://codereview.chromium.org/99371
------------------------------------------------------------------------
r15329 | robertshield@google.com | 2009-05-05 22:17:25 +0200 (Tue, 05 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adding first run bypass command line flag.

This allows the browser to start up without ever showing the first run UI, regardless of whether the First Run sentinel file is present. Quite useful for automated testing ;-)
Review URL: http://codereview.chromium.org/99344
------------------------------------------------------------------------
r15328 | jeremy@chromium.org | 2009-05-05 22:07:19 +0200 (Tue, 05 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/renderer/renderer.sb

Fixes for 10.6

* Workaround for rdar://6857649 - NSGradient fails when using LAB Colorspace
* Update sandbox config file for 10.6

BUG=11265
TEST=Open Chrome on 10.6, it should have tabs and the tab title should reflect
the title of the page that's currently loaded.

Review URL: http://codereview.chromium.org/109032
------------------------------------------------------------------------
r15326 | pkasting@chromium.org | 2009-05-05 22:00:22 +0200 (Tue, 05 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Plumb the creator URL for popups up to the browser.  We don't yet use this for anything; it will be used for whitelisting popups by hostname.

BUG=11440
Review URL: http://codereview.chromium.org/105004
------------------------------------------------------------------------
r15323 | arv@chromium.org | 2009-05-05 21:54:05 +0200 (Tue, 05 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/resources/dom_ui.css
   M /trunk/src/chrome/browser/resources/history.html
   A /trunk/src/chrome/browser/resources/local_strings.js
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/tools/grit/grit/format/html_inline.py

Move the shared JS and CSS out of the HTML files and into separate files.

Review URL: http://codereview.chromium.org/99151
------------------------------------------------------------------------
r15322 | jhawkins@chromium.org | 2009-05-05 21:33:44 +0200 (Tue, 05 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

The bookmark bar app menu item should have a checkbox displayed next to it when it's selected.
Review URL: http://codereview.chromium.org/109036
------------------------------------------------------------------------
r15321 | shess@chromium.org | 2009-05-05 21:33:39 +0200 (Tue, 05 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

Convert autocomplete to use a custom matrix and button cell.

On the user-visible side this change enables mouse hover (the item
under the mouse is highlighted), and lays out the text omnibox v2
style.  Only hover really needed the control change, but I have
another change queued up to style the popup text.  It uses different
colors and shades, and really looked horrible with the NSTableView
highlighting.  [Which is why this part of the CL is coming first.]

TEST=Omnibox popup works and shows highlighting under the mouse in addition to the keyboard-selected item.

Review URL: http://codereview.chromium.org/99310
------------------------------------------------------------------------
r15320 | estade@chromium.org | 2009-05-05 21:32:57 +0200 (Tue, 05 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Set infobar text to black (overriding system default color).

Since we set the background color, we can't go letting the theme choose the text color unless we want to potentially end up with white on yellow.

Review URL: http://codereview.chromium.org/108034
------------------------------------------------------------------------
r15319 | arv@chromium.org | 2009-05-05 21:05:51 +0200 (Tue, 05 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Center the download progress meter behind the icon.

I moved the image down 2px as well as adjusted the margins. I tried keeping
the image at 0px but it looks better when moved down slightlty :-)


http://crbug.com/10057

Review URL: http://codereview.chromium.org/99286
------------------------------------------------------------------------
r15310 | rafaelw@chromium.org | 2009-05-05 20:25:01 +0200 (Tue, 05 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/json_schema.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/test/data/extensions/json_schema_test.js
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html
   M /trunk/src/chrome/test/data/extensions/samples/gmail/gmail_checker.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

BUG=11200
R=aa

Review URL: http://codereview.chromium.org/110001
------------------------------------------------------------------------
r15300 | sky@chromium.org | 2009-05-05 18:53:12 +0200 (Tue, 05 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Makes closed window icon appear on right side when rtl.

BUG=11463
TEST=see bug

Review URL: http://codereview.chromium.org/108019
------------------------------------------------------------------------
r15292 | pfeldman@chromium.org | 2009-05-05 12:32:33 +0200 (Tue, 05 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/debugger/devtools_client_host.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_manager_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.h
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

DevTools: localize window title, append inspected tab url there.

Review URL: http://codereview.chromium.org/109014
------------------------------------------------------------------------
r15280 | brettw@chromium.org | 2009-05-05 08:34:19 +0200 (Tue, 05 May 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h

Don't start the throbber when loading javascript URLs. This fixes a
regression from my "start the throbber sooner" patch that made JS URLs keep
throbbing forever.

This patch just adds a check to see if the URL is JS, and doesn't synthesize
the load start message. It seems kind of like a hcak, but I think it's the
right thing. As I argued in the last patch (the comment for the block I
modified here), we really need the throbbing status to be synchronous. This
means we need to basically duplicate the logic for when WebKit will do the
throbber in this function.

BUG=11422
Review URL: http://codereview.chromium.org/105009
------------------------------------------------------------------------
r15275 | ben@chromium.org | 2009-05-05 06:52:11 +0200 (Tue, 05 May 2009) | 5 lines
Changed paths:
   A /trunk/src/app/animation.cc (from /trunk/src/chrome/common/animation.cc:15263)
   A /trunk/src/app/animation.h (from /trunk/src/chrome/common/animation.h:15263)
   A /trunk/src/app/animation_unittest.cc (from /trunk/src/chrome/common/animation_unittest.cc:15263)
   M /trunk/src/app/app.vcproj
   A /trunk/src/app/slide_animation.cc (from /trunk/src/chrome/common/slide_animation.cc:15263)
   A /trunk/src/app/slide_animation.h (from /trunk/src/chrome/common/slide_animation.h:15263)
   A /trunk/src/app/throb_animation.cc (from /trunk/src/chrome/common/throb_animation.cc:15263)
   A /trunk/src/app/throb_animation.h (from /trunk/src/chrome/common/throb_animation.h:15263)
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/animation.cc
   D /trunk/src/chrome/common/animation.h
   D /trunk/src/chrome/common/animation_unittest.cc
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/slide_animation.cc
   D /trunk/src/chrome/common/slide_animation.h
   D /trunk/src/chrome/common/throb_animation.cc
   D /trunk/src/chrome/common/throb_animation.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/controls/button/custom_button.cc
   M /trunk/src/chrome/views/controls/button/custom_button.h
   M /trunk/src/chrome/views/controls/button/image_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/tabbed_pane.cc

Move *Animation to app/

http://crbug.com/11387

Review URL: http://codereview.chromium.org/109001
------------------------------------------------------------------------
r15274 | ben@chromium.org | 2009-05-05 06:14:11 +0200 (Tue, 05 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/clipboard_service.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/view_unittest.cc

Get rid of the ClipboardService class and header... it is nothing but a shell around base::Clipboard now.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/105011
------------------------------------------------------------------------
r15272 | ben@chromium.org | 2009-05-05 05:31:44 +0200 (Tue, 05 May 2009) | 5 lines
Changed paths:
   M /trunk/src/app/resource_bundle.h
   M /trunk/src/base/base.gyp
   A /trunk/src/base/scoped_vector.h (from /trunk/src/chrome/common/scoped_vector.h:15263)
   A /trunk/src/base/stl_util-inl.h (from /trunk/src/chrome/common/stl_util-inl.h:15263)
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/command_updater.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/printing/page_range.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_page_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/l10n_util_unittest.cc
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/common/pref_service.cc
   D /trunk/src/chrome/common/scoped_vector.h
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   D /trunk/src/chrome/common/stl_util-inl.h
   M /trunk/src/chrome/common/task_queue.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.hxx
   M /trunk/src/chrome/views/controls/menu/menu.cc
   M /trunk/src/chrome/views/controls/tabbed_pane.cc
   M /trunk/src/chrome/views/controls/tree/tree_node_model.h
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/focus/view_storage.cc

Move scoped_vector.h and stl_util-inl.h to base/

http://crbug.com/11387

Review URL: http://codereview.chromium.org/107001
------------------------------------------------------------------------
r15271 | rafaelw@chromium.org | 2009-05-05 05:05:00 +0200 (Tue, 05 May 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/gmail/gmail_checker.html
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/toolstrip.html
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

implemented API style/convention changes, including:

-tabs.update()
-tabs.move()
-tabs.remove()
-tabs.update()
-tabs.create()
-tabs.get()
-all tab events, except onUpdated

implemented
-tabs.getSelected()
-tabs.getAllInWindow()
-windows.getCurrent()
-windows.getFocused()
-windows.getAll(populate)
-windows.onFocusedChanged()

-ExtensionBrowserEventRouter now uses BrowserList::Observer

Review URL: http://codereview.chromium.org/100345
------------------------------------------------------------------------
r15269 | finnur@chromium.org | 2009-05-05 04:40:07 +0200 (Tue, 05 May 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h

FindBarView::UpdateForResult is not a good place to 
beep if nothing was found on the page. The reason is
that it is gets called when you switch from one tab
to the other. I've added a function to FindBar that
the controller can call and each platform can
implement whatever sound they want to use.

BUG=10823
TEST=Open google.com, search for z0, it should beep
(no matches). Open new tab, switch back to the old
tab and it should not beep.

Review URL: http://codereview.chromium.org/99372
------------------------------------------------------------------------
r15264 | ben@chromium.org | 2009-05-05 04:05:11 +0200 (Tue, 05 May 2009) | 7 lines
Changed paths:
   A /trunk/src/app
   A /trunk/src/app/DEPS
   A /trunk/src/app/app.vcproj
   A /trunk/src/app/app.vsprops
   A /trunk/src/app/resource_bundle.cc (from /trunk/src/chrome/common/resource_bundle.cc:15227)
   A /trunk/src/app/resource_bundle.h (from /trunk/src/chrome/common/resource_bundle.h:15227)
   A /trunk/src/app/resource_bundle_linux.cc (from /trunk/src/chrome/common/resource_bundle_linux.cc:15227)
   A /trunk/src/app/resource_bundle_mac.mm (from /trunk/src/chrome/common/resource_bundle_mac.mm:15227)
   A /trunk/src/app/resource_bundle_win.cc (from /trunk/src/chrome/common/resource_bundle_win.cc:15227)
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/dom_ui/debugger_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/jstemplate_builder.cc
   M /trunk/src/chrome/common/l10n_util.cc
   D /trunk/src/chrome/common/resource_bundle.cc
   D /trunk/src/chrome/common/resource_bundle.h
   D /trunk/src/chrome/common/resource_bundle_linux.cc
   D /trunk/src/chrome/common/resource_bundle_mac.mm
   D /trunk/src/chrome/common/resource_bundle_win.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/greasemonkey_api_unittest.cc
   M /trunk/src/chrome/renderer/extensions/json_schema_unittest.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/combo_box.cc
   M /trunk/src/chrome/views/controls/label.cc
   M /trunk/src/chrome/views/controls/scroll_view.cc
   M /trunk/src/chrome/views/controls/tabbed_pane.cc
   M /trunk/src/chrome/views/controls/table/table_view.cc
   M /trunk/src/chrome/views/controls/throbber.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/focus/focus_manager_unittest.cc
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc

Adds toplevel app/ directory and moves ResourceBundle into it.
No changes to resource bundle yet, just the move to keep this CL as compact as possible.
Adds new vcproj and gyp file for app dir.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/100354
------------------------------------------------------------------------
r15263 | paulg@google.com | 2009-05-05 03:24:40 +0200 (Tue, 05 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc

Add support for handling files containing URLs with a sampling
weight. Also print out a few more statistics like the number
of URLs examined and the number of host + path pairs looked up.

Review URL: http://codereview.chromium.org/105005
------------------------------------------------------------------------
r15262 | jhawkins@chromium.org | 2009-05-05 02:57:09 +0200 (Tue, 05 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Constrain the gtk menu popup to the bounds of the current monitor.
Review URL: http://codereview.chromium.org/106001
------------------------------------------------------------------------
r15261 | mpcomplete@google.com | 2009-05-05 02:50:53 +0200 (Tue, 05 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/notification_type.h

Add a RENDERER_PROCESS_CLOSED notification that gets sent when we close the
RenderProcessHost's process_.  This is similar to RENDER_PROCESS_TERMINATED,
but the latter is not always sent since the process could get reused.  It also
takes the place of RENDERER_PROCESS_CRASHED, where this one contains a boolean
Details indicating whether the process crashed (true) or just exited (false).
Review URL: http://codereview.chromium.org/100277
------------------------------------------------------------------------
r15258 | estade@chromium.org | 2009-05-05 02:40:06 +0200 (Tue, 05 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/test_location_bar.h
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc

Linux: enable omni box ui test and automation proxy ui test.

Enable a lot of (already essentially working) automation code along the way.

Review URL: http://codereview.chromium.org/100278
------------------------------------------------------------------------
r15257 | erg@google.com | 2009-05-05 02:35:09 +0200 (Tue, 05 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   A /trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
   A /trunk/src/chrome/browser/gtk/bookmark_tree_model.cc
   A /trunk/src/chrome/browser/gtk/bookmark_tree_model.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/chrome.gyp

Port the folder selector portion of the BookmarkEditor to GTK.

Mirrors the BookmarkEditorView method, where the contents of BookmarkModel
are copied to a temporary model so changes can be discarded if the user hits
Cancel. In the GTK version, we copy not into another BookmarkModel, but into
a GtkTreeStore, which serves as a model to the GtkTreeView on screen.

Also ports the unit tests.

http://crbug.com/11250

Review URL: http://codereview.chromium.org/99361
------------------------------------------------------------------------
r15256 | estade@chromium.org | 2009-05-05 02:34:36 +0200 (Tue, 05 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: show the correct cursor when the render view regains focus.

BUG=11407

Review URL: http://codereview.chromium.org/105002
------------------------------------------------------------------------
r15255 | jhawkins@chromium.org | 2009-05-05 02:17:44 +0200 (Tue, 05 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

Highlight the next find result when the return key is pressed in the Linux find bar.
Review URL: http://codereview.chromium.org/99376
------------------------------------------------------------------------
r15249 | aa@chromium.org | 2009-05-05 00:53:14 +0200 (Tue, 05 May 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Several minor visual fixes to toolstrips:

* Layout toolstrips on the left of the bookmark bar so that
  something always obviously happens when you install one.
  This is in response to some feedback I've gotten demoing
  toolstrips for various people.

* Open the NTP on install if the bookmarkbar isn't visible.
  Again, I'm trying to make something happen when you
  install an extension. This won't be the permanent behavior
  but it seems like doing nothing if you have your bookmark
  bar detached is likely to confuse people.

* Fix a bug where we kept trying to resize the toolstrip
  back to the width it had when it was first made visible.

* Fix a bug where we didn't always repaint the bookmarkbar
  after the toolstrip preferred width changed.

This also seems to fix the issue where the buildbot sample
shows up overlayed on top of tab contents, though I didn't
mean to fix that with this CL.

Review URL: http://codereview.chromium.org/100310
------------------------------------------------------------------------
r15247 | finnur@chromium.org | 2009-05-05 00:48:08 +0200 (Tue, 05 May 2009) | 8 lines
Changed paths:
   D /trunk/src/chrome/app/theme/rss.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/test_location_bar.h
   D /trunk/src/webkit/glue/feed.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Fix bug 9812: Remove current RSS code in favor of new more generalized
PageAction code that serves the same purpose (and more).

BUG=9812
TEST=No test needed, this shouldn't result in any noticable difference
since the RSS parsing was disabled.

Review URL: http://codereview.chromium.org/100356
------------------------------------------------------------------------
r15245 | sky@chromium.org | 2009-05-04 23:47:17 +0200 (Mon, 04 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc

Fixes bug in search provider. It wasn't setting template_url and
correct fill_into_edit for keywords.

BUG=11416
TEST=see bug

Review URL: http://codereview.chromium.org/100350
------------------------------------------------------------------------
r15238 | mpcomplete@google.com | 2009-05-04 22:53:19 +0200 (Mon, 04 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h

Undo part of brettw's WebContents refactor that removed TabContentsDelegate
code from HtmlDialogView.

BUG=http://code.google.com/p/chromium/issues/detail?id=9884
Review URL: http://codereview.chromium.org/99305
------------------------------------------------------------------------
r15237 | ben@chromium.org | 2009-05-04 22:49:27 +0200 (Mon, 04 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h

Fix a couple of aesthetic nits about infobars that have been broken since I redid them a few months back.

- close button is properly centered horizontally
- animation looks correct - layout no longer dependent on current frame height

http://crbug.com/11389
Review URL: http://codereview.chromium.org/99332
------------------------------------------------------------------------
r15234 | estade@chromium.org | 2009-05-04 22:20:31 +0200 (Mon, 04 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Fix linux ui tests broken by r15112.

also re-enable tests that I disabled in an attempt to green the bot

TBR=tony

Review URL: http://codereview.chromium.org/100351
------------------------------------------------------------------------
r15229 | estade@chromium.org | 2009-05-04 20:42:30 +0200 (Mon, 04 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Temporarily disable failing ui tests on linux.

TBR=cpu

Review URL: http://codereview.chromium.org/100348
------------------------------------------------------------------------
r15226 | rohitrao@chromium.org | 2009-05-04 20:05:14 +0200 (Mon, 04 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Fixes focus issues when browsing on Mac.

http://crbug.com/10032
TEST=Open a new tab and browse to www.google.com. Type something
and check that focus is correctly set to the text field.

Review URL: http://codereview.chromium.org/99327
------------------------------------------------------------------------
r15225 | estade@chromium.org | 2009-05-04 19:59:55 +0200 (Mon, 04 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

Linux: tweak find bar.

- (attempt to) fix find bar z ordering in a simpler way
- get "close without animation" right.

Review URL: http://codereview.chromium.org/100286
------------------------------------------------------------------------
r15221 | thestig@chromium.org | 2009-05-04 19:50:31 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/renderer/extensions/json_schema_unittest.cc

Deprecate wstring version of PathService::Get() in unit tests.
Review URL: http://codereview.chromium.org/100292
------------------------------------------------------------------------
r15219 | sidchat@google.com | 2009-05-04 19:44:25 +0200 (Mon, 04 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h

Change in enable-spellcheck checkbox in Languages Options Tab should not be considered unless OK is clicked.

Issue=11013
Review URL: http://codereview.chromium.org/99095
------------------------------------------------------------------------
r15217 | deanm@chromium.org | 2009-05-04 19:40:50 +0200 (Mon, 04 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Make the Linux find bar look a bit better.
  - Fake some anti-aliasing so the text entry matches the next/prev images.
  - Match padding pixel perfect with Windows.

Review URL: http://codereview.chromium.org/99275

------------------------------------------------------------------------
r15212 | pkasting@chromium.org | 2009-05-04 19:12:19 +0200 (Mon, 04 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Remove "output=chrome" as the Suggest team has deprecated it server-side.

BUG=1660988
Review URL: http://codereview.chromium.org/102024
------------------------------------------------------------------------
r15211 | pkasting@chromium.org | 2009-05-04 19:10:29 +0200 (Mon, 04 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/test_location_bar.h

Reset the omnibox contents when the user reloads the page.  Patch by Yusuke Sato (see http://codereview.chromium.org/100198 ), r=me.

BUG=2985
------------------------------------------------------------------------
r15210 | pfeldman@chromium.org | 2009-05-04 18:58:47 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

DevTools: Wire existing shortcutto out of process devtools.
Review URL: http://codereview.chromium.org/99345
------------------------------------------------------------------------
r15204 | deanm@chromium.org | 2009-05-04 18:20:55 +0200 (Mon, 04 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Fix some recently small size / position regressions in Linux Omnibox.

Review URL: http://codereview.chromium.org/100343

------------------------------------------------------------------------
r15202 | brettw@chromium.org | 2009-05-04 12:00:18 +0200 (Mon, 04 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix find in page. When fixing the conflict after updating, I accidentally
removed the code that updates the find in page commands.
Review URL: http://codereview.chromium.org/100331
------------------------------------------------------------------------
r15201 | brettw@chromium.org | 2009-05-04 11:32:57 +0200 (Mon, 04 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Fix a regression that the sad tab favicon is not displayed when a tab crashes.
This regressed in my favicon/title updating change because the crashed state
is not updated on the codepath, since it comes from the tab.

The other approach would have been to make this call through the "update
everything" codepath for tbe state changing, but that's executed on a timer, and
it's nice to show the tab crash right away since the check is very inexpensive.

BUG=http://crbug.com/10756
Review URL: http://codereview.chromium.org/99341
------------------------------------------------------------------------
r15197 | brettw@chromium.org | 2009-05-04 10:26:33 +0200 (Mon, 04 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

More linux build fixes
------------------------------------------------------------------------
r15196 | brettw@chromium.org | 2009-05-04 10:15:04 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Fix Linux build.
Review URL: http://codereview.chromium.org/99339
------------------------------------------------------------------------
r15195 | brettw@chromium.org | 2009-05-04 10:15:01 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Fix the mac build from my WebContents rename.
Review URL: http://codereview.chromium.org/100329
------------------------------------------------------------------------
r15194 | brettw@chromium.org | 2009-05-04 09:58:34 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/cross_site_request_manager.h
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_node.h
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.h
   M /trunk/src/chrome/browser/dom_ui/debugger_ui.cc
   M /trunk/src/chrome/browser/dom_ui/debugger_ui.h
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.cc
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_util.cc
   M /trunk/src/chrome/browser/tab_contents/tab_util.h
   M /trunk/src/chrome/browser/tab_contents/test_web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_web_contents.h
   D /trunk/src/chrome/browser/tab_contents/web_contents.cc
   D /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.h
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/plugin/npobject_util.h
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc

Replace all occurrances of WebContents with TabContents.
Review URL: http://codereview.chromium.org/99177
------------------------------------------------------------------------
r15192 | evan@chromium.org | 2009-05-04 05:34:41 +0200 (Mon, 04 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

linux: set the window icon (used in alt-tab list, etc.)

BUG=11354

Review URL: http://codereview.chromium.org/100303
------------------------------------------------------------------------
r15191 | ben@chromium.org | 2009-05-04 05:03:33 +0200 (Mon, 04 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/locales/ar.vcproj
   M /trunk/src/chrome/app/locales/bg.vcproj
   M /trunk/src/chrome/app/locales/bn.vcproj
   M /trunk/src/chrome/app/locales/ca.vcproj
   M /trunk/src/chrome/app/locales/cs.vcproj
   M /trunk/src/chrome/app/locales/da.vcproj
   M /trunk/src/chrome/app/locales/de.vcproj
   M /trunk/src/chrome/app/locales/el.vcproj
   M /trunk/src/chrome/app/locales/en-GB.vcproj
   M /trunk/src/chrome/app/locales/en-US.vcproj
   M /trunk/src/chrome/app/locales/es-419.vcproj
   M /trunk/src/chrome/app/locales/es.vcproj
   M /trunk/src/chrome/app/locales/et.vcproj
   M /trunk/src/chrome/app/locales/fi.vcproj
   M /trunk/src/chrome/app/locales/fil.vcproj
   M /trunk/src/chrome/app/locales/fr.vcproj
   M /trunk/src/chrome/app/locales/gu.vcproj
   M /trunk/src/chrome/app/locales/he.vcproj
   M /trunk/src/chrome/app/locales/hi.vcproj
   M /trunk/src/chrome/app/locales/hr.vcproj
   M /trunk/src/chrome/app/locales/hu.vcproj
   M /trunk/src/chrome/app/locales/id.vcproj
   M /trunk/src/chrome/app/locales/it.vcproj
   M /trunk/src/chrome/app/locales/ja.vcproj
   M /trunk/src/chrome/app/locales/kn.vcproj
   M /trunk/src/chrome/app/locales/ko.vcproj
   M /trunk/src/chrome/app/locales/lt.vcproj
   M /trunk/src/chrome/app/locales/lv.vcproj
   M /trunk/src/chrome/app/locales/ml.vcproj
   M /trunk/src/chrome/app/locales/mr.vcproj
   M /trunk/src/chrome/app/locales/nb.vcproj
   M /trunk/src/chrome/app/locales/nl.vcproj
   M /trunk/src/chrome/app/locales/or.vcproj
   M /trunk/src/chrome/app/locales/pl.vcproj
   M /trunk/src/chrome/app/locales/pt-BR.vcproj
   M /trunk/src/chrome/app/locales/pt-PT.vcproj
   M /trunk/src/chrome/app/locales/ro.vcproj
   M /trunk/src/chrome/app/locales/ru.vcproj
   M /trunk/src/chrome/app/locales/sk.vcproj
   M /trunk/src/chrome/app/locales/sl.vcproj
   M /trunk/src/chrome/app/locales/sr.vcproj
   M /trunk/src/chrome/app/locales/sv.vcproj
   M /trunk/src/chrome/app/locales/ta.vcproj
   M /trunk/src/chrome/app/locales/te.vcproj
   M /trunk/src/chrome/app/locales/th.vcproj
   M /trunk/src/chrome/app/locales/tr.vcproj
   M /trunk/src/chrome/app/locales/uk.vcproj
   M /trunk/src/chrome/app/locales/vi.vcproj
   M /trunk/src/chrome/app/locales/zh-CN.vcproj
   M /trunk/src/chrome/app/locales/zh-TW.vcproj
   A /trunk/src/chrome/app/theme/app_top_center.png (from /trunk/src/chrome/app/theme/app_top_center.png:15176)
   A /trunk/src/chrome/app/theme/app_top_left.png (from /trunk/src/chrome/app/theme/app_top_left.png:15176)
   A /trunk/src/chrome/app/theme/app_top_right.png (from /trunk/src/chrome/app/theme/app_top_right.png:15176)
   A /trunk/src/chrome/app/theme/close.png (from /trunk/src/chrome/app/theme/close.png:15176)
   A /trunk/src/chrome/app/theme/close_h.png (from /trunk/src/chrome/app/theme/close_h.png:15176)
   A /trunk/src/chrome/app/theme/close_p.png (from /trunk/src/chrome/app/theme/close_p.png:15176)
   A /trunk/src/chrome/app/theme/close_sa.png (from /trunk/src/chrome/app/theme/close_sa.png:15176)
   A /trunk/src/chrome/app/theme/close_sa_h.png (from /trunk/src/chrome/app/theme/close_sa_h.png:15176)
   A /trunk/src/chrome/app/theme/close_sa_p.png (from /trunk/src/chrome/app/theme/close_sa_p.png:15176)
   A /trunk/src/chrome/app/theme/content_bottom_center.png (from /trunk/src/chrome/app/theme/content_bottom_center.png:15176)
   A /trunk/src/chrome/app/theme/content_bottom_left_corner.png (from /trunk/src/chrome/app/theme/content_bottom_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/content_bottom_right_corner.png (from /trunk/src/chrome/app/theme/content_bottom_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/content_left_side.png (from /trunk/src/chrome/app/theme/content_left_side.png:15176)
   A /trunk/src/chrome/app/theme/content_right_side.png (from /trunk/src/chrome/app/theme/content_right_side.png:15176)
   R /trunk/src/chrome/app/theme/content_top_center.png (from /trunk/src/chrome/app/theme/content_top_center.png:15176)
   R /trunk/src/chrome/app/theme/content_top_left_corner.png (from /trunk/src/chrome/app/theme/content_top_left_corner.png:15176)
   R /trunk/src/chrome/app/theme/content_top_right_corner.png (from /trunk/src/chrome/app/theme/content_top_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_bottom_center.png (from /trunk/src/chrome/app/theme/dewindow_bottom_center.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png (from /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png (from /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_left_side.png (from /trunk/src/chrome/app/theme/dewindow_left_side.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_right_side.png (from /trunk/src/chrome/app/theme/dewindow_right_side.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_top_center.png (from /trunk/src/chrome/app/theme/dewindow_top_center.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_top_left_corner.png (from /trunk/src/chrome/app/theme/dewindow_top_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_top_right_corner.png (from /trunk/src/chrome/app/theme/dewindow_top_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/folder_closed.png (from /trunk/src/chrome/app/theme/folder_closed.png:15176)
   A /trunk/src/chrome/app/theme/folder_closed_rtl.png (from /trunk/src/chrome/app/theme/folder_closed_rtl.png:15176)
   A /trunk/src/chrome/app/theme/folder_open.png (from /trunk/src/chrome/app/theme/folder_open.png:15176)
   A /trunk/src/chrome/app/theme/folder_open_rtl.png (from /trunk/src/chrome/app/theme/folder_open_rtl.png:15176)
   A /trunk/src/chrome/app/theme/input_alert.png (from /trunk/src/chrome/app/theme/input_alert.png:15176)
   A /trunk/src/chrome/app/theme/input_good.png (from /trunk/src/chrome/app/theme/input_good.png:15176)
   A /trunk/src/chrome/app/theme/input_unknown.png (from /trunk/src/chrome/app/theme/input_unknown.png:15176)
   A /trunk/src/chrome/app/theme/maximize.png (from /trunk/src/chrome/app/theme/maximize.png:15176)
   A /trunk/src/chrome/app/theme/maximize_h.png (from /trunk/src/chrome/app/theme/maximize_h.png:15176)
   A /trunk/src/chrome/app/theme/maximize_p.png (from /trunk/src/chrome/app/theme/maximize_p.png:15176)
   A /trunk/src/chrome/app/theme/minimize.png (from /trunk/src/chrome/app/theme/minimize.png:15176)
   A /trunk/src/chrome/app/theme/minimize_h.png (from /trunk/src/chrome/app/theme/minimize_h.png:15176)
   A /trunk/src/chrome/app/theme/minimize_p.png (from /trunk/src/chrome/app/theme/minimize_p.png:15176)
   A /trunk/src/chrome/app/theme/restore.png (from /trunk/src/chrome/app/theme/restore.png:15176)
   A /trunk/src/chrome/app/theme/restore_h.png (from /trunk/src/chrome/app/theme/restore_h.png:15176)
   A /trunk/src/chrome/app/theme/restore_p.png (from /trunk/src/chrome/app/theme/restore_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_b_h.png (from /trunk/src/chrome/app/theme/textbutton_b_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_b_p.png (from /trunk/src/chrome/app/theme/textbutton_b_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_bl_h.png (from /trunk/src/chrome/app/theme/textbutton_bl_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_bl_p.png (from /trunk/src/chrome/app/theme/textbutton_bl_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_br_h.png (from /trunk/src/chrome/app/theme/textbutton_br_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_br_p.png (from /trunk/src/chrome/app/theme/textbutton_br_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_c_h.png (from /trunk/src/chrome/app/theme/textbutton_c_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_c_p.png (from /trunk/src/chrome/app/theme/textbutton_c_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_l_h.png (from /trunk/src/chrome/app/theme/textbutton_l_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_l_p.png (from /trunk/src/chrome/app/theme/textbutton_l_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_r_h.png (from /trunk/src/chrome/app/theme/textbutton_r_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_r_p.png (from /trunk/src/chrome/app/theme/textbutton_r_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_t_h.png (from /trunk/src/chrome/app/theme/textbutton_t_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_t_p.png (from /trunk/src/chrome/app/theme/textbutton_t_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tl_h.png (from /trunk/src/chrome/app/theme/textbutton_tl_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tl_p.png (from /trunk/src/chrome/app/theme/textbutton_tl_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tr_h.png (from /trunk/src/chrome/app/theme/textbutton_tr_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tr_p.png (from /trunk/src/chrome/app/theme/textbutton_tr_p.png:15176)
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/app/theme/throbber.png (from /trunk/src/chrome/app/theme/throbber.png:15176)
   A /trunk/src/chrome/app/theme/window_bottom_center.png (from /trunk/src/chrome/app/theme/window_bottom_center.png:15176)
   A /trunk/src/chrome/app/theme/window_bottom_left_corner.png (from /trunk/src/chrome/app/theme/window_bottom_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/window_bottom_right_corner.png (from /trunk/src/chrome/app/theme/window_bottom_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/window_left_side.png (from /trunk/src/chrome/app/theme/window_left_side.png:15176)
   A /trunk/src/chrome/app/theme/window_right_side.png (from /trunk/src/chrome/app/theme/window_right_side.png:15176)
   A /trunk/src/chrome/app/theme/window_top_center.png (from /trunk/src/chrome/app/theme/window_top_center.png:15176)
   A /trunk/src/chrome/app/theme/window_top_left_corner.png (from /trunk/src/chrome/app/theme/window_top_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/window_top_right_corner.png (from /trunk/src/chrome/app/theme/window_top_right_corner.png:15176)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/controls/button/button_dropdown.cc
   M /trunk/src/chrome/views/controls/button/image_button.cc
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/scroll_view.cc
   M /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/controls/throbber.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   D /trunk/src/chrome/views/resources
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc

roll back r15177
------------------------------------------------------------------------
r15188 | ben@chromium.org | 2009-05-04 04:59:26 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/controls/button/button_dropdown.cc
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/resources/views_strings.grd
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc

Reverting 15180.
Review URL: http://codereview.chromium.org/100323
------------------------------------------------------------------------
r15187 | ben@chromium.org | 2009-05-04 04:56:46 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc

Reverting 15181.
Review URL: http://codereview.chromium.org/100322
------------------------------------------------------------------------
r15186 | ben@chromium.org | 2009-05-04 04:55:59 +0200 (Mon, 04 May 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/app/theme/app_top_center.png
   D /trunk/src/chrome/app/theme/app_top_left.png
   D /trunk/src/chrome/app/theme/app_top_right.png
   D /trunk/src/chrome/app/theme/close.png
   D /trunk/src/chrome/app/theme/close_h.png
   D /trunk/src/chrome/app/theme/close_p.png
   D /trunk/src/chrome/app/theme/close_sa.png
   D /trunk/src/chrome/app/theme/close_sa_h.png
   D /trunk/src/chrome/app/theme/close_sa_p.png
   D /trunk/src/chrome/app/theme/content_bottom_center.png
   D /trunk/src/chrome/app/theme/content_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/content_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/content_left_side.png
   D /trunk/src/chrome/app/theme/content_right_side.png
   R /trunk/src/chrome/app/theme/content_top_center.png (from /trunk/src/chrome/app/theme/content_top_center.png:15181)
   R /trunk/src/chrome/app/theme/content_top_left_corner.png (from /trunk/src/chrome/app/theme/content_top_left_corner.png:15181)
   R /trunk/src/chrome/app/theme/content_top_right_corner.png (from /trunk/src/chrome/app/theme/content_top_right_corner.png:15181)
   D /trunk/src/chrome/app/theme/dewindow_bottom_center.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/dewindow_left_side.png
   D /trunk/src/chrome/app/theme/dewindow_right_side.png
   D /trunk/src/chrome/app/theme/dewindow_top_center.png
   D /trunk/src/chrome/app/theme/dewindow_top_left_corner.png
   D /trunk/src/chrome/app/theme/dewindow_top_right_corner.png
   D /trunk/src/chrome/app/theme/folder_closed.png
   D /trunk/src/chrome/app/theme/folder_closed_rtl.png
   D /trunk/src/chrome/app/theme/folder_open.png
   D /trunk/src/chrome/app/theme/folder_open_rtl.png
   D /trunk/src/chrome/app/theme/input_alert.png
   D /trunk/src/chrome/app/theme/input_good.png
   D /trunk/src/chrome/app/theme/input_unknown.png
   D /trunk/src/chrome/app/theme/maximize.png
   D /trunk/src/chrome/app/theme/maximize_h.png
   D /trunk/src/chrome/app/theme/maximize_p.png
   D /trunk/src/chrome/app/theme/minimize.png
   D /trunk/src/chrome/app/theme/minimize_h.png
   D /trunk/src/chrome/app/theme/minimize_p.png
   D /trunk/src/chrome/app/theme/restore.png
   D /trunk/src/chrome/app/theme/restore_h.png
   D /trunk/src/chrome/app/theme/restore_p.png
   D /trunk/src/chrome/app/theme/textbutton_b_h.png
   D /trunk/src/chrome/app/theme/textbutton_b_p.png
   D /trunk/src/chrome/app/theme/textbutton_bl_h.png
   D /trunk/src/chrome/app/theme/textbutton_bl_p.png
   D /trunk/src/chrome/app/theme/textbutton_br_h.png
   D /trunk/src/chrome/app/theme/textbutton_br_p.png
   D /trunk/src/chrome/app/theme/textbutton_c_h.png
   D /trunk/src/chrome/app/theme/textbutton_c_p.png
   D /trunk/src/chrome/app/theme/textbutton_l_h.png
   D /trunk/src/chrome/app/theme/textbutton_l_p.png
   D /trunk/src/chrome/app/theme/textbutton_r_h.png
   D /trunk/src/chrome/app/theme/textbutton_r_p.png
   D /trunk/src/chrome/app/theme/textbutton_t_h.png
   D /trunk/src/chrome/app/theme/textbutton_t_p.png
   D /trunk/src/chrome/app/theme/textbutton_tl_h.png
   D /trunk/src/chrome/app/theme/textbutton_tl_p.png
   D /trunk/src/chrome/app/theme/textbutton_tr_h.png
   D /trunk/src/chrome/app/theme/textbutton_tr_p.png
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/app/theme/throbber.png
   D /trunk/src/chrome/app/theme/window_bottom_center.png
   D /trunk/src/chrome/app/theme/window_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/window_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/window_left_side.png
   D /trunk/src/chrome/app/theme/window_right_side.png
   D /trunk/src/chrome/app/theme/window_top_center.png
   D /trunk/src/chrome/app/theme/window_top_left_corner.png
   D /trunk/src/chrome/app/theme/window_top_right_corner.png
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/throbber.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/resources/views_resources.grd
   M /trunk/src/chrome/views/window/custom_frame_view.cc

Reverting 15182.
Review URL: http://codereview.chromium.org/101024
------------------------------------------------------------------------
r15182 | ben@chromium.org | 2009-05-04 04:33:38 +0200 (Mon, 04 May 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/app_top_center.png (from /trunk/src/chrome/app/theme/app_top_center.png:15176)
   A /trunk/src/chrome/app/theme/app_top_left.png (from /trunk/src/chrome/app/theme/app_top_left.png:15176)
   A /trunk/src/chrome/app/theme/app_top_right.png (from /trunk/src/chrome/app/theme/app_top_right.png:15176)
   A /trunk/src/chrome/app/theme/close.png (from /trunk/src/chrome/app/theme/close.png:15176)
   A /trunk/src/chrome/app/theme/close_h.png (from /trunk/src/chrome/app/theme/close_h.png:15176)
   A /trunk/src/chrome/app/theme/close_p.png (from /trunk/src/chrome/app/theme/close_p.png:15176)
   A /trunk/src/chrome/app/theme/close_sa.png (from /trunk/src/chrome/app/theme/close_sa.png:15176)
   A /trunk/src/chrome/app/theme/close_sa_h.png (from /trunk/src/chrome/app/theme/close_sa_h.png:15176)
   A /trunk/src/chrome/app/theme/close_sa_p.png (from /trunk/src/chrome/app/theme/close_sa_p.png:15176)
   A /trunk/src/chrome/app/theme/content_bottom_center.png (from /trunk/src/chrome/app/theme/content_bottom_center.png:15176)
   A /trunk/src/chrome/app/theme/content_bottom_left_corner.png (from /trunk/src/chrome/app/theme/content_bottom_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/content_bottom_right_corner.png (from /trunk/src/chrome/app/theme/content_bottom_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/content_left_side.png (from /trunk/src/chrome/app/theme/content_left_side.png:15176)
   A /trunk/src/chrome/app/theme/content_right_side.png (from /trunk/src/chrome/app/theme/content_right_side.png:15176)
   R /trunk/src/chrome/app/theme/content_top_center.png (from /trunk/src/chrome/app/theme/content_top_center.png:15176)
   R /trunk/src/chrome/app/theme/content_top_left_corner.png (from /trunk/src/chrome/app/theme/content_top_left_corner.png:15176)
   R /trunk/src/chrome/app/theme/content_top_right_corner.png (from /trunk/src/chrome/app/theme/content_top_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_bottom_center.png (from /trunk/src/chrome/app/theme/dewindow_bottom_center.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png (from /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png (from /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_left_side.png (from /trunk/src/chrome/app/theme/dewindow_left_side.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_right_side.png (from /trunk/src/chrome/app/theme/dewindow_right_side.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_top_center.png (from /trunk/src/chrome/app/theme/dewindow_top_center.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_top_left_corner.png (from /trunk/src/chrome/app/theme/dewindow_top_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/dewindow_top_right_corner.png (from /trunk/src/chrome/app/theme/dewindow_top_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/folder_closed.png (from /trunk/src/chrome/app/theme/folder_closed.png:15176)
   A /trunk/src/chrome/app/theme/folder_closed_rtl.png (from /trunk/src/chrome/app/theme/folder_closed_rtl.png:15176)
   A /trunk/src/chrome/app/theme/folder_open.png (from /trunk/src/chrome/app/theme/folder_open.png:15176)
   A /trunk/src/chrome/app/theme/folder_open_rtl.png (from /trunk/src/chrome/app/theme/folder_open_rtl.png:15176)
   A /trunk/src/chrome/app/theme/input_alert.png (from /trunk/src/chrome/app/theme/input_alert.png:15176)
   A /trunk/src/chrome/app/theme/input_good.png (from /trunk/src/chrome/app/theme/input_good.png:15176)
   A /trunk/src/chrome/app/theme/input_unknown.png (from /trunk/src/chrome/app/theme/input_unknown.png:15176)
   A /trunk/src/chrome/app/theme/maximize.png (from /trunk/src/chrome/app/theme/maximize.png:15176)
   A /trunk/src/chrome/app/theme/maximize_h.png (from /trunk/src/chrome/app/theme/maximize_h.png:15176)
   A /trunk/src/chrome/app/theme/maximize_p.png (from /trunk/src/chrome/app/theme/maximize_p.png:15176)
   A /trunk/src/chrome/app/theme/minimize.png (from /trunk/src/chrome/app/theme/minimize.png:15176)
   A /trunk/src/chrome/app/theme/minimize_h.png (from /trunk/src/chrome/app/theme/minimize_h.png:15176)
   A /trunk/src/chrome/app/theme/minimize_p.png (from /trunk/src/chrome/app/theme/minimize_p.png:15176)
   A /trunk/src/chrome/app/theme/restore.png (from /trunk/src/chrome/app/theme/restore.png:15176)
   A /trunk/src/chrome/app/theme/restore_h.png (from /trunk/src/chrome/app/theme/restore_h.png:15176)
   A /trunk/src/chrome/app/theme/restore_p.png (from /trunk/src/chrome/app/theme/restore_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_b_h.png (from /trunk/src/chrome/app/theme/textbutton_b_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_b_p.png (from /trunk/src/chrome/app/theme/textbutton_b_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_bl_h.png (from /trunk/src/chrome/app/theme/textbutton_bl_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_bl_p.png (from /trunk/src/chrome/app/theme/textbutton_bl_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_br_h.png (from /trunk/src/chrome/app/theme/textbutton_br_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_br_p.png (from /trunk/src/chrome/app/theme/textbutton_br_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_c_h.png (from /trunk/src/chrome/app/theme/textbutton_c_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_c_p.png (from /trunk/src/chrome/app/theme/textbutton_c_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_l_h.png (from /trunk/src/chrome/app/theme/textbutton_l_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_l_p.png (from /trunk/src/chrome/app/theme/textbutton_l_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_r_h.png (from /trunk/src/chrome/app/theme/textbutton_r_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_r_p.png (from /trunk/src/chrome/app/theme/textbutton_r_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_t_h.png (from /trunk/src/chrome/app/theme/textbutton_t_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_t_p.png (from /trunk/src/chrome/app/theme/textbutton_t_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tl_h.png (from /trunk/src/chrome/app/theme/textbutton_tl_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tl_p.png (from /trunk/src/chrome/app/theme/textbutton_tl_p.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tr_h.png (from /trunk/src/chrome/app/theme/textbutton_tr_h.png:15176)
   A /trunk/src/chrome/app/theme/textbutton_tr_p.png (from /trunk/src/chrome/app/theme/textbutton_tr_p.png:15176)
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/app/theme/throbber.png (from /trunk/src/chrome/app/theme/throbber.png:15176)
   A /trunk/src/chrome/app/theme/window_bottom_center.png (from /trunk/src/chrome/app/theme/window_bottom_center.png:15176)
   A /trunk/src/chrome/app/theme/window_bottom_left_corner.png (from /trunk/src/chrome/app/theme/window_bottom_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/window_bottom_right_corner.png (from /trunk/src/chrome/app/theme/window_bottom_right_corner.png:15176)
   A /trunk/src/chrome/app/theme/window_left_side.png (from /trunk/src/chrome/app/theme/window_left_side.png:15176)
   A /trunk/src/chrome/app/theme/window_right_side.png (from /trunk/src/chrome/app/theme/window_right_side.png:15176)
   A /trunk/src/chrome/app/theme/window_top_center.png (from /trunk/src/chrome/app/theme/window_top_center.png:15176)
   A /trunk/src/chrome/app/theme/window_top_left_corner.png (from /trunk/src/chrome/app/theme/window_top_left_corner.png:15176)
   A /trunk/src/chrome/app/theme/window_top_right_corner.png (from /trunk/src/chrome/app/theme/window_top_right_corner.png:15176)
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/throbber.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/resources/views_resources.grd
   M /trunk/src/chrome/views/window/custom_frame_view.cc

Bustage fix:

Add back these files which I removed earlier since Linux is using them.

The resources are duplicate until I collapse them into src/app/ later this week.

Review URL: http://codereview.chromium.org/100320
------------------------------------------------------------------------
r15181 | ben@chromium.org | 2009-05-04 04:08:27 +0200 (Mon, 04 May 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc

Make the header include of views_strings.h here windows-only, temporarily (we duplicate the strings in generated_resources.h)
------------------------------------------------------------------------
r15180 | ben@chromium.org | 2009-05-04 03:59:52 +0200 (Mon, 04 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/controls/button/button_dropdown.cc
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/resources/views_strings.grd
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc

Bustage fix for mac and linux:

Duplicate views strings and rename them to uniquify them to get mac and linux going again.

TODO(beng): move these strings into the forthcoming app/ dependency so that mac linux and windows can rely on it.

Review URL: http://codereview.chromium.org/99335
------------------------------------------------------------------------
r15177 | ben@chromium.org | 2009-05-04 03:03:10 +0200 (Mon, 04 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/locales/ar.vcproj
   M /trunk/src/chrome/app/locales/bg.vcproj
   M /trunk/src/chrome/app/locales/bn.vcproj
   M /trunk/src/chrome/app/locales/ca.vcproj
   M /trunk/src/chrome/app/locales/cs.vcproj
   M /trunk/src/chrome/app/locales/da.vcproj
   M /trunk/src/chrome/app/locales/de.vcproj
   M /trunk/src/chrome/app/locales/el.vcproj
   M /trunk/src/chrome/app/locales/en-GB.vcproj
   M /trunk/src/chrome/app/locales/en-US.vcproj
   M /trunk/src/chrome/app/locales/es-419.vcproj
   M /trunk/src/chrome/app/locales/es.vcproj
   M /trunk/src/chrome/app/locales/et.vcproj
   M /trunk/src/chrome/app/locales/fi.vcproj
   M /trunk/src/chrome/app/locales/fil.vcproj
   M /trunk/src/chrome/app/locales/fr.vcproj
   M /trunk/src/chrome/app/locales/gu.vcproj
   M /trunk/src/chrome/app/locales/he.vcproj
   M /trunk/src/chrome/app/locales/hi.vcproj
   M /trunk/src/chrome/app/locales/hr.vcproj
   M /trunk/src/chrome/app/locales/hu.vcproj
   M /trunk/src/chrome/app/locales/id.vcproj
   M /trunk/src/chrome/app/locales/it.vcproj
   M /trunk/src/chrome/app/locales/ja.vcproj
   M /trunk/src/chrome/app/locales/kn.vcproj
   M /trunk/src/chrome/app/locales/ko.vcproj
   M /trunk/src/chrome/app/locales/lt.vcproj
   M /trunk/src/chrome/app/locales/lv.vcproj
   M /trunk/src/chrome/app/locales/ml.vcproj
   M /trunk/src/chrome/app/locales/mr.vcproj
   M /trunk/src/chrome/app/locales/nb.vcproj
   M /trunk/src/chrome/app/locales/nl.vcproj
   M /trunk/src/chrome/app/locales/or.vcproj
   M /trunk/src/chrome/app/locales/pl.vcproj
   M /trunk/src/chrome/app/locales/pt-BR.vcproj
   M /trunk/src/chrome/app/locales/pt-PT.vcproj
   M /trunk/src/chrome/app/locales/ro.vcproj
   M /trunk/src/chrome/app/locales/ru.vcproj
   M /trunk/src/chrome/app/locales/sk.vcproj
   M /trunk/src/chrome/app/locales/sl.vcproj
   M /trunk/src/chrome/app/locales/sr.vcproj
   M /trunk/src/chrome/app/locales/sv.vcproj
   M /trunk/src/chrome/app/locales/ta.vcproj
   M /trunk/src/chrome/app/locales/te.vcproj
   M /trunk/src/chrome/app/locales/th.vcproj
   M /trunk/src/chrome/app/locales/tr.vcproj
   M /trunk/src/chrome/app/locales/uk.vcproj
   M /trunk/src/chrome/app/locales/vi.vcproj
   M /trunk/src/chrome/app/locales/zh-CN.vcproj
   M /trunk/src/chrome/app/locales/zh-TW.vcproj
   D /trunk/src/chrome/app/theme/app_top_center.png
   D /trunk/src/chrome/app/theme/app_top_left.png
   D /trunk/src/chrome/app/theme/app_top_right.png
   D /trunk/src/chrome/app/theme/close.png
   D /trunk/src/chrome/app/theme/close_h.png
   D /trunk/src/chrome/app/theme/close_p.png
   D /trunk/src/chrome/app/theme/close_sa.png
   D /trunk/src/chrome/app/theme/close_sa_h.png
   D /trunk/src/chrome/app/theme/close_sa_p.png
   D /trunk/src/chrome/app/theme/content_bottom_center.png
   D /trunk/src/chrome/app/theme/content_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/content_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/content_left_side.png
   D /trunk/src/chrome/app/theme/content_right_side.png
   R /trunk/src/chrome/app/theme/content_top_center.png
   R /trunk/src/chrome/app/theme/content_top_left_corner.png
   R /trunk/src/chrome/app/theme/content_top_right_corner.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_center.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/dewindow_left_side.png
   D /trunk/src/chrome/app/theme/dewindow_right_side.png
   D /trunk/src/chrome/app/theme/dewindow_top_center.png
   D /trunk/src/chrome/app/theme/dewindow_top_left_corner.png
   D /trunk/src/chrome/app/theme/dewindow_top_right_corner.png
   D /trunk/src/chrome/app/theme/folder_closed.png
   D /trunk/src/chrome/app/theme/folder_closed_rtl.png
   D /trunk/src/chrome/app/theme/folder_open.png
   D /trunk/src/chrome/app/theme/folder_open_rtl.png
   D /trunk/src/chrome/app/theme/input_alert.png
   D /trunk/src/chrome/app/theme/input_good.png
   D /trunk/src/chrome/app/theme/input_unknown.png
   D /trunk/src/chrome/app/theme/maximize.png
   D /trunk/src/chrome/app/theme/maximize_h.png
   D /trunk/src/chrome/app/theme/maximize_p.png
   D /trunk/src/chrome/app/theme/minimize.png
   D /trunk/src/chrome/app/theme/minimize_h.png
   D /trunk/src/chrome/app/theme/minimize_p.png
   D /trunk/src/chrome/app/theme/restore.png
   D /trunk/src/chrome/app/theme/restore_h.png
   D /trunk/src/chrome/app/theme/restore_p.png
   D /trunk/src/chrome/app/theme/textbutton_b_h.png
   D /trunk/src/chrome/app/theme/textbutton_b_p.png
   D /trunk/src/chrome/app/theme/textbutton_bl_h.png
   D /trunk/src/chrome/app/theme/textbutton_bl_p.png
   D /trunk/src/chrome/app/theme/textbutton_br_h.png
   D /trunk/src/chrome/app/theme/textbutton_br_p.png
   D /trunk/src/chrome/app/theme/textbutton_c_h.png
   D /trunk/src/chrome/app/theme/textbutton_c_p.png
   D /trunk/src/chrome/app/theme/textbutton_l_h.png
   D /trunk/src/chrome/app/theme/textbutton_l_p.png
   D /trunk/src/chrome/app/theme/textbutton_r_h.png
   D /trunk/src/chrome/app/theme/textbutton_r_p.png
   D /trunk/src/chrome/app/theme/textbutton_t_h.png
   D /trunk/src/chrome/app/theme/textbutton_t_p.png
   D /trunk/src/chrome/app/theme/textbutton_tl_h.png
   D /trunk/src/chrome/app/theme/textbutton_tl_p.png
   D /trunk/src/chrome/app/theme/textbutton_tr_h.png
   D /trunk/src/chrome/app/theme/textbutton_tr_p.png
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/app/theme/throbber.png
   D /trunk/src/chrome/app/theme/window_bottom_center.png
   D /trunk/src/chrome/app/theme/window_bottom_left_corner.png
   D /trunk/src/chrome/app/theme/window_bottom_right_corner.png
   D /trunk/src/chrome/app/theme/window_left_side.png
   D /trunk/src/chrome/app/theme/window_right_side.png
   D /trunk/src/chrome/app/theme/window_top_center.png
   D /trunk/src/chrome/app/theme/window_top_left_corner.png
   D /trunk/src/chrome/app/theme/window_top_right_corner.png
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/controls/button/button_dropdown.cc
   M /trunk/src/chrome/views/controls/button/image_button.cc
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/scroll_view.cc
   M /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/controls/throbber.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   A /trunk/src/chrome/views/resources
   A /trunk/src/chrome/views/resources/app_top_center.png (from /trunk/src/chrome/app/theme/app_top_center.png:15170)
   A /trunk/src/chrome/views/resources/app_top_left.png (from /trunk/src/chrome/app/theme/app_top_left.png:15170)
   A /trunk/src/chrome/views/resources/app_top_right.png (from /trunk/src/chrome/app/theme/app_top_right.png:15170)
   A /trunk/src/chrome/views/resources/close.png (from /trunk/src/chrome/app/theme/close.png:15170)
   A /trunk/src/chrome/views/resources/close_h.png (from /trunk/src/chrome/app/theme/close_h.png:15170)
   A /trunk/src/chrome/views/resources/close_p.png (from /trunk/src/chrome/app/theme/close_p.png:15170)
   A /trunk/src/chrome/views/resources/close_sa.png (from /trunk/src/chrome/app/theme/close_sa.png:15170)
   A /trunk/src/chrome/views/resources/close_sa_h.png (from /trunk/src/chrome/app/theme/close_sa_h.png:15170)
   A /trunk/src/chrome/views/resources/close_sa_p.png (from /trunk/src/chrome/app/theme/close_sa_p.png:15170)
   A /trunk/src/chrome/views/resources/content_bottom_center.png (from /trunk/src/chrome/app/theme/content_bottom_center.png:15170)
   A /trunk/src/chrome/views/resources/content_bottom_left_corner.png (from /trunk/src/chrome/app/theme/content_bottom_left_corner.png:15170)
   A /trunk/src/chrome/views/resources/content_bottom_right_corner.png (from /trunk/src/chrome/app/theme/content_bottom_right_corner.png:15170)
   A /trunk/src/chrome/views/resources/content_left_side.png (from /trunk/src/chrome/app/theme/content_left_side.png:15170)
   A /trunk/src/chrome/views/resources/content_right_side.png (from /trunk/src/chrome/app/theme/content_right_side.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_bottom_center.png (from /trunk/src/chrome/app/theme/dewindow_bottom_center.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_bottom_left_corner.png (from /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_bottom_right_corner.png (from /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_left_side.png (from /trunk/src/chrome/app/theme/dewindow_left_side.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_right_side.png (from /trunk/src/chrome/app/theme/dewindow_right_side.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_top_center.png (from /trunk/src/chrome/app/theme/dewindow_top_center.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_top_left_corner.png (from /trunk/src/chrome/app/theme/dewindow_top_left_corner.png:15170)
   A /trunk/src/chrome/views/resources/dewindow_top_right_corner.png (from /trunk/src/chrome/app/theme/dewindow_top_right_corner.png:15170)
   A /trunk/src/chrome/views/resources/folder_closed.png (from /trunk/src/chrome/app/theme/folder_closed.png:15170)
   A /trunk/src/chrome/views/resources/folder_closed_rtl.png (from /trunk/src/chrome/app/theme/folder_closed_rtl.png:15170)
   A /trunk/src/chrome/views/resources/folder_open.png (from /trunk/src/chrome/app/theme/folder_open.png:15170)
   A /trunk/src/chrome/views/resources/folder_open_rtl.png (from /trunk/src/chrome/app/theme/folder_open_rtl.png:15170)
   A /trunk/src/chrome/views/resources/input_alert.png (from /trunk/src/chrome/app/theme/input_alert.png:15170)
   A /trunk/src/chrome/views/resources/input_good.png (from /trunk/src/chrome/app/theme/input_good.png:15170)
   A /trunk/src/chrome/views/resources/input_unknown.png (from /trunk/src/chrome/app/theme/input_unknown.png:15170)
   A /trunk/src/chrome/views/resources/maximize.png (from /trunk/src/chrome/app/theme/maximize.png:15170)
   A /trunk/src/chrome/views/resources/maximize_h.png (from /trunk/src/chrome/app/theme/maximize_h.png:15170)
   A /trunk/src/chrome/views/resources/maximize_p.png (from /trunk/src/chrome/app/theme/maximize_p.png:15170)
   A /trunk/src/chrome/views/resources/minimize.png (from /trunk/src/chrome/app/theme/minimize.png:15170)
   A /trunk/src/chrome/views/resources/minimize_h.png (from /trunk/src/chrome/app/theme/minimize_h.png:15170)
   A /trunk/src/chrome/views/resources/minimize_p.png (from /trunk/src/chrome/app/theme/minimize_p.png:15170)
   A /trunk/src/chrome/views/resources/restore.png (from /trunk/src/chrome/app/theme/restore.png:15170)
   A /trunk/src/chrome/views/resources/restore_h.png (from /trunk/src/chrome/app/theme/restore_h.png:15170)
   A /trunk/src/chrome/views/resources/restore_p.png (from /trunk/src/chrome/app/theme/restore_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_b_h.png (from /trunk/src/chrome/app/theme/textbutton_b_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_b_p.png (from /trunk/src/chrome/app/theme/textbutton_b_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_bl_h.png (from /trunk/src/chrome/app/theme/textbutton_bl_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_bl_p.png (from /trunk/src/chrome/app/theme/textbutton_bl_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_br_h.png (from /trunk/src/chrome/app/theme/textbutton_br_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_br_p.png (from /trunk/src/chrome/app/theme/textbutton_br_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_c_h.png (from /trunk/src/chrome/app/theme/textbutton_c_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_c_p.png (from /trunk/src/chrome/app/theme/textbutton_c_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_l_h.png (from /trunk/src/chrome/app/theme/textbutton_l_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_l_p.png (from /trunk/src/chrome/app/theme/textbutton_l_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_r_h.png (from /trunk/src/chrome/app/theme/textbutton_r_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_r_p.png (from /trunk/src/chrome/app/theme/textbutton_r_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_t_h.png (from /trunk/src/chrome/app/theme/textbutton_t_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_t_p.png (from /trunk/src/chrome/app/theme/textbutton_t_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_tl_h.png (from /trunk/src/chrome/app/theme/textbutton_tl_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_tl_p.png (from /trunk/src/chrome/app/theme/textbutton_tl_p.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_tr_h.png (from /trunk/src/chrome/app/theme/textbutton_tr_h.png:15170)
   A /trunk/src/chrome/views/resources/textbutton_tr_p.png (from /trunk/src/chrome/app/theme/textbutton_tr_p.png:15170)
   A /trunk/src/chrome/views/resources/throbber.png (from /trunk/src/chrome/app/theme/throbber.png:15170)
   A /trunk/src/chrome/views/resources/views_resources.grd
   A /trunk/src/chrome/views/resources/views_resources.vcproj
   A /trunk/src/chrome/views/resources/views_strings.grd
   A /trunk/src/chrome/views/resources/views_strings.vcproj
   A /trunk/src/chrome/views/resources/window_bottom_center.png (from /trunk/src/chrome/app/theme/window_bottom_center.png:15170)
   A /trunk/src/chrome/views/resources/window_bottom_left_corner.png (from /trunk/src/chrome/app/theme/window_bottom_left_corner.png:15170)
   A /trunk/src/chrome/views/resources/window_bottom_right_corner.png (from /trunk/src/chrome/app/theme/window_bottom_right_corner.png:15170)
   A /trunk/src/chrome/views/resources/window_left_side.png (from /trunk/src/chrome/app/theme/window_left_side.png:15170)
   A /trunk/src/chrome/views/resources/window_right_side.png (from /trunk/src/chrome/app/theme/window_right_side.png:15170)
   A /trunk/src/chrome/views/resources/window_top_center.png (from /trunk/src/chrome/app/theme/window_top_center.png:15170)
   A /trunk/src/chrome/views/resources/window_top_left_corner.png (from /trunk/src/chrome/app/theme/window_top_left_corner.png:15170)
   A /trunk/src/chrome/views/resources/window_top_right_corner.png (from /trunk/src/chrome/app/theme/window_top_right_corner.png:15170)
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc

Extract all views resources into:
views_strings.[grd,vcproj]
views_resources.[grd,vcproj]

Moves views images (.png files) from app/theme to views/resources dir.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/100317
------------------------------------------------------------------------
r15176 | mal@chromium.org | 2009-05-04 01:27:14 +0200 (Mon, 04 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Blind fix for ChromeBot crashes.

A ChromeBot run for 172.17 was very top heavy (77/103 crashes) with:

[vector:703]	      std::vector<PasswordManagerTableModel::PasswordRow
*,std::allocator<PasswordManagerTableModel::PasswordRow *> >::size()
[browser_init.cc:140] `anonymous namespace'::NotifyNotDefaultBrowserTask::Run()
[message_loop.cc:308] MessageLoop::RunTask(Task *)

I'm going to try a null check on |tab| before we invoke
tab->infobar_delegate_count().

This applies the change made to 172 to trunk.

TBR= jcampan,ben

BUG= 11388
Review URL: http://codereview.chromium.org/99331
------------------------------------------------------------------------
r15171 | ben@chromium.org | 2009-05-03 23:10:35 +0200 (Sun, 03 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Fix two bugs in the omnibox2 popup:

- popup frequently flashes white after being updated. This was because rows weren't being laid out after being added so they had zero size after async changes to the model.
- text ran off the right side because DrawStringFragment wasn't clamping the output width to the available width. Does this now, and so eliding works.

Review URL: http://codereview.chromium.org/101023
------------------------------------------------------------------------
r15170 | robertshield@google.com | 2009-05-03 17:57:53 +0200 (Sun, 03 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Fix multiple instances of first run dialog appearing when Chrome is started again while a first run dialog is visible. Also cause the original first run dialog to come to foreground.

BUG=http://crbug.com/10765

Review URL: http://codereview.chromium.org/99281
------------------------------------------------------------------------
r15142 | tommi@google.com | 2009-05-02 18:45:27 +0200 (Sat, 02 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/views/focus/focus_manager.cc
   M /trunk/src/chrome/views/focus/focus_manager.h
   M /trunk/src/chrome/views/widget/accelerator_handler.cc

Allowing the client to handle escape and keyup events.

Review URL: http://codereview.chromium.org/99293
------------------------------------------------------------------------
r15137 | jcampan@chromium.org | 2009-05-02 09:18:30 +0200 (Sat, 02 May 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Relanding the following CL (it was breaking the UI tests because a
NOTREACHED() would be triggered in that case).

If Chrome is not the default browser, tell the user, unless:
- it is the first run
- the user already said not to warn him/her about it
- an info-bar is already showing.

BUG=9049
TEST=Run a new install of chrome, proceed through the first run flow, don't
     make Chrome your default browser.  No info-bar warning about Chrome not
     being the default browser should be shown.
     Restart Chrome, such an info-bar should be shown. Click the x on the
     info-bar to close it. Restart Chrome. The info-bar should be shown.
     Select "Set as default". Restart Chrome, the info-bar should not be shown.
     Start IE, make it your default browser (Tools menu, 'Internet option',
     Programs tab). Restart Chrome, it should show the default browser info-bar.
     Select "Don't ask me again". Restart Chrome, the info-bar should not be
     shown.

Review URL: http://codereview.chromium.org/100287
------------------------------------------------------------------------
r15127 | thestig@chromium.org | 2009-05-02 02:56:57 +0200 (Sat, 02 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util_unittest.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/layout_plugin_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_test_helper.cc
   M /trunk/src/chrome/test/ui/sunspider_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/v8_benchmark_uitest.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Yet more deprecation of the wstring version of PathService::Get() for UI tests.
Review URL: http://codereview.chromium.org/99298
------------------------------------------------------------------------
r15125 | ben@chromium.org | 2009-05-02 02:40:02 +0200 (Sat, 02 May 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/app/theme/chromium/chromium_icon_32.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/views/controls/button/native_button.cc
   M /trunk/src/chrome/views/controls/button/native_button.h

Add chrome/chromium icons as PNGs.

Also, add support to NativeButton for rendering as default independently of behaving as default. This will be used by the default browser infobar.
Adds methods to the infobar delegate interface to allow the delegate to specify that it wants its Accept button to appear as the default button.

http://crbug.com/9049


Review URL: http://codereview.chromium.org/100288
------------------------------------------------------------------------
r15122 | jcampan@chromium.org | 2009-05-02 01:34:29 +0200 (Sat, 02 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Reverting 15115, it sadly breaks the ui tests.

TBR=beng
Review URL: http://codereview.chromium.org/100285
------------------------------------------------------------------------
r15118 | evan@chromium.org | 2009-05-02 01:16:46 +0200 (Sat, 02 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc

linux: fix inverted infobubble logic.

Review URL: http://codereview.chromium.org/100282
------------------------------------------------------------------------
r15116 | aa@chromium.org | 2009-05-02 01:15:31 +0200 (Sat, 02 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Don't try and install extensions when --enable-extensions isn't
on.

Also, pop up a dialog telling the user they probably forgot to
turn on the flag.

Review URL: http://codereview.chromium.org/99295
------------------------------------------------------------------------
r15115 | jcampan@chromium.org | 2009-05-02 01:13:32 +0200 (Sat, 02 May 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

If Chrome is not the default browser, tell the user, unless:
- it is the first run
- the user already said not to warn him/her about it
- an info-bar is already showing.

BUG=9049
TEST=Run a new install of chrome, proceed through the first run flow, don't
     make Chrome your default browser.  No info-bar warning about Chrome not
     being the default browser should be shown.
     Restart Chrome, such an info-bar should be shown. Click the x on the
     info-bar to close it. Restart Chrome. The info-bar should be shown.
     Select "Set as default". Restart Chrome, the info-bar should not be shown.
     Start IE, make it your default browser (Tools menu, 'Internet option',
     Programs tab). Restart Chrome, it should show the default browser info-bar.
     Select "Don't ask me again". Restart Chrome, the info-bar should not be
     shown.

Review URL: http://codereview.chromium.org/99301
------------------------------------------------------------------------
r15114 | sidchat@google.com | 2009-05-02 00:54:32 +0200 (Sat, 02 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h

Fix the issue with Options menu fonts display bigger than size of fonts actually set. This was happening because Windows Font Picker returns font size in points, whereas the corresponding pref members for serif, sans-serif and fixed-width fonts expect font size in pixels.Issue=7806TEST: Go to options > fonts and languages > fonts tab and change serif font to 16 and click OK. Then open a new Tab page - the corresponding fonts should be that size.NOTE: I don't know why the div element set to 16pt serif font is not the same height as that shown by the font picker. That is a separate issue I think.
Review URL: http://codereview.chromium.org/100228
------------------------------------------------------------------------
r15113 | jungshik@google.com | 2009-05-02 00:51:50 +0200 (Sat, 02 May 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/webkit/glue/context_menu.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

This CL makes Chrome on par with Firefox in terms of 'GetSuggestedFilename' for file download via context-menu.

For a download initiated with a click on a link in a web page, a webkit-side change is necessary, which will be done later.

Add a field (referrer_charset) to URLRequestContext and DownloadCreateInfo. It's set to the character encoding of a document where the download request originates from when it's known (download initiated via "save as" in the context menu). 

If it's not known (a download initiated by clicking on a download link or typing a url directly to the omnibox), it's initialized to the default character encoding in the user's preference. I guess this is marginally better than leaving it empty (in that case, step 2b below will be skipped and step 2c will be taken) because a user has a better control over how raw 8bit characters in C-D are interpreted (especially on Windows where a reboot is required to change the OS default codepage). 

This is later passed to GetSuggestedFilename and used as one of fallback encodings (1. UTF-8, 2. origin_charset, 3. default OS codepage). With this change, we support the following:

1. RFC 2047
2. Raw-8bit-characters : a. UTF-8, b. origin_charset, c. default os codepage. 
3. %-escaped UTF-8. 

In this CL, for #3, I didn't add a fallback similar to one used for #2. If necessary, it can be added easily. New entries are added to 3 existing tests. What's previously not covered (raw 8bit Content-Disposition header) is now covered in all 3 tests. 

BUG=1148
TEST=net unit test: NetUtilTest.GetFileNameFromCD                    
                    NetUtilTest.GetSuggestedFilename         
     unittest : DownloadManagerTest.TestDownloadFilename

Review URL: http://codereview.chromium.org/83002
------------------------------------------------------------------------
r15112 | estade@chromium.org | 2009-05-02 00:44:56 +0200 (Sat, 02 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h

Make the findbar slide in/out.

Change SlideAnimatorGtk so that its GtkFixed doesn't have its own window. Giving that fixed its own GdkWindow meant that as a client of SlideAnimatorGtk you were pretty much cornered into having rectangular widgets (unless you want to perform a lot of expensive operations during every frame of the slide). We solve the clipping problem this creates by making a "render area" vbox in BrowserWindowGtk that is all part of a single GdkWindow hierarchy.

This isn't yet perfect as there are sometimes occlusion problems with infobars. That will probably need to be solved in the same way it was solved for the tab contents container. This patch is already hard enough to grok, so I'm going to leave that problem for another patch.

Review URL: http://codereview.chromium.org/102021
------------------------------------------------------------------------
r15109 | tc@google.com | 2009-05-02 00:37:12 +0200 (Sat, 02 May 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/chrome.gyp

Fix a bug in session restore on linux/mac.  We were pickling the
page title as a wstring, but reading it back as a string16.  This
allows the SessionRestoreUITests to pass.

Also enable the inspector ui test which is currently disabled, but the code compiles fine on linux/mac.

BUG=10516

Review URL: http://codereview.chromium.org/99297

------------------------------------------------------------------------
r15105 | finnur@chromium.org | 2009-05-02 00:02:34 +0200 (Sat, 02 May 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_page_actions_module.cc
   A /trunk/src/chrome/browser/extensions/extension_page_actions_module.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/page_action.cc
   A /trunk/src/chrome/common/page_action.h
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/test_location_bar.h

This is the first part of the PageAction implementation. More work is required, but this is a good checkpoint.

Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api

This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader).

Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :)

BUG=None
TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is  not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA.
Review URL: http://codereview.chromium.org/99253
------------------------------------------------------------------------
r15104 | ananta@chromium.org | 2009-05-01 23:58:37 +0200 (Fri, 01 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Ensure that the underlying web_contents has focus in the external tab container
when it receives the SetInitialFocus notification from the client. 


Review URL: http://codereview.chromium.org/102022
------------------------------------------------------------------------
r15102 | agl@chromium.org | 2009-05-01 23:37:31 +0200 (Fri, 01 May 2009) | 50 lines
Changed paths:
   M /trunk/src/base/debug_util_posix.cc
   M /trunk/src/base/directory_watcher_inotify.cc
   A /trunk/src/base/eintr_wrapper.h
   M /trunk/src/base/file_descriptor_shuffle.cc
   M /trunk/src/base/file_util_linux.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/message_pump_glib.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/common/file_descriptor_set_posix.cc
   M /trunk/src/chrome/common/file_descriptor_set_unittest.cc
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_send_fds_test.cc
   M /trunk/src/chrome/common/process_watcher_posix.cc
   M /trunk/src/chrome/common/transport_dib_mac.cc
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/listen_socket.cc
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/telnet_server.cc

POSIX: Add a macro for handling EINTR.

On POSIX systems, system calls can be interrupted by signals. In this
case, they'll return EINTR, indicating that the system call needs to
be restarted.

(The situation is a little more complicated than this with SA_RESTART,
but you can read man 7 signal if you like.)

The short of it is that you need to catch EINTR and restart the call
for these system calls:

 * read, readv, write, writev, ioctl
 * open() when dealing with a fifo
 * wait*
 * Anything socket based (send*, recv*, connect, accept etc)
 * flock and lock control with fcntl
 * mq_ functions which can block
 * futex
 * sem_wait (and timed wait)
 * pause, sigsuspend, sigtimedwait, sigwaitinfo
 * poll, epoll_wait, select and 'p' versions of the same
 * msgrcv, msgsnd, semop, semtimedop
 * close (although, on Linux, EINTR won't happen here)
 * any sleep functions (careful, you need to handle this are restart
   with different arguments)

We've been a little sloppy with this until now. This patch adds a
macro for dealing with this and corrects every case of these system
calls (that I found).

The macro is HANDLE_EINTR in base/eintr_wrapper.h. It's safe to
include on Windows and is a no-op there.

On POSIX, it uses GCC magic to return the correct type based on the
expression and restarts the system call if it throws EINTR.

And you can use it like:
 HANDLE_EINTR(close(fd));

Or:
 ssize_t bytes_read = HANDLE_EINTR(read(fd, buffer, len));

*BEWARE* that it will evaluate the argument multiple times, so this is
not safe:
 HANDLE_EINTR(close(FireMissiles()));

http://groups.google.com/group/chromium-dev/browse_thread/thread/41a35b2a457d73a0
http://codereview.chromium.org/100225

------------------------------------------------------------------------
r15099 | shess@chromium.org | 2009-05-01 23:23:37 +0200 (Fri, 01 May 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Enable user_script_master_unittest for Mac since DirectoryWatcher was ported.
[See http://crbug.com/10967 ]

Review URL: http://codereview.chromium.org/99280
------------------------------------------------------------------------
r15098 | jam@chromium.org | 2009-05-01 23:20:47 +0200 (Fri, 01 May 2009) | 2 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/worker/DEPS
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.h
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webworkerclient_impl.cc
   M /trunk/src/webkit/glue/webworkerclient_impl.h

Run workers in separate processes.
Review URL: http://codereview.chromium.org/99016
------------------------------------------------------------------------
r15097 | mpcomplete@google.com | 2009-05-01 23:17:49 +0200 (Fri, 01 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/extensions/bindings_utils.cc
   M /trunk/src/chrome/renderer/extensions/bindings_utils.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html
   M /trunk/src/chrome/test/render_view_test.cc

Pass down the opener tab when a message channel is opened to an extension.

Also did a bunch of cleanup of ExtensionMessageService.  I converted it to
primarily UI-thread habitation, with one function that needs to be on the IO
thread so it can handle a synchronous IPC message.

TEST=N/A
Review URL: http://codereview.chromium.org/99261
------------------------------------------------------------------------
r15094 | shess@chromium.org | 2009-05-01 22:54:12 +0200 (Fri, 01 May 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Remove StopAutocomplete() helper from AutocompletePopupViewMac.

When the code was originally written, GetModel() was not required by AutocompletePopupView, now it's easy enough to use that instead.

Review URL: http://codereview.chromium.org/99278
------------------------------------------------------------------------
r15063 | hclam@chromium.org | 2009-05-01 19:37:01 +0200 (Fri, 01 May 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/renderer/audio_message_filter.cc
   M /trunk/src/chrome/renderer/audio_message_filter.h

Measure IPC latency for audio
With this patch there's totally 5 measurements for audio IPC
1. Total round trip time
   browser request a packet until it gets a packet
2. Browser receive latency
   time for a packet to arrive browser from renderer
3. Browser process time
   time for browser to process the packet
4. Renderer receive latency
   time for a packet to arrive renderer from browser
5. Renderer process time
   process time on a packet in renderer

They are all using low resolution timer with accuracy of ~1-15ms.
Since we have a budget of ~200ms (for now) without clicks, I think
the accuracy shouldn't be a big problem, unless for case 1 where
we want to measure exact amount of clicks.

Review URL: http://codereview.chromium.org/99213
------------------------------------------------------------------------
r15061 | shess@chromium.org | 2009-05-01 19:24:49 +0200 (Fri, 01 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Release the autocomplete popup panel when not visible.

Review URL: http://codereview.chromium.org/100260
------------------------------------------------------------------------
r15058 | huanr@chromium.org | 2009-05-01 19:00:29 +0200 (Fri, 01 May 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h

Making CloseWindow and CloseTab automation API
synchronous and robust.

Adding automation APIs with corresponding
IPC messages to count and find normal browser
windows.


Review URL: http://codereview.chromium.org/99268
------------------------------------------------------------------------
r15055 | avi@google.com | 2009-05-01 18:00:15 +0200 (Fri, 01 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

More focus fixing.

Review URL: http://codereview.chromium.org/99262
------------------------------------------------------------------------
r15050 | erikkay@google.com | 2009-05-01 17:12:56 +0200 (Fri, 01 May 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/test/render_view_test.cc

Only send events to renderers that are listening to an event.Notify browser when a renderer is listening to an event.
Review URL: http://codereview.chromium.org/100214
------------------------------------------------------------------------
r15042 | deanm@chromium.org | 2009-05-01 13:25:12 +0200 (Fri, 01 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Fix a small undercalculation of the space available a result description.

Calculate from the actual text width, not the allocated text width.

Review URL: http://codereview.chromium.org/99222

------------------------------------------------------------------------
r15035 | abarth@chromium.org | 2009-05-01 07:26:45 +0200 (Fri, 01 May 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Add a title to the "download in progress" dialog.

R=thestig
BUG=10681
TEST=Start a long download.  Try to quit the browser.  Notice the spiffy title on the dialog box.


Review URL: http://codereview.chromium.org/100241
------------------------------------------------------------------------
r15032 | thestig@chromium.org | 2009-05-01 06:31:22 +0200 (Fri, 01 May 2009) | 2 lines
Changed paths:
   M /trunk/src/base/event_recorder.cc
   M /trunk/src/base/event_recorder.h
   M /trunk/src/base/event_recorder_stubs.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Deprecate wstring version of PathService::Get() in webkit.
Review URL: http://codereview.chromium.org/99266
------------------------------------------------------------------------
r15028 | agl@chromium.org | 2009-05-01 03:41:50 +0200 (Fri, 01 May 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc

Linux: terminate clipboard handling on the UI thread.

After discussing with various people, I think we're going to do this
in the short term at least. Currently we're calling into GTK from the
IO thread and Bad Things Happen when one does that.

We would like to write an Xlib, fully asynchronous system for dealing
with the clipboard (and to get the clipboard stuff out of base!). That
would let us avoid sending the selection over the IPC channel each
time it updates too.

However, that's going to be a lot of work and we have crashing
browsers happening /right now/. Also, Evan thinks that maybe we don't
have the deadlock situation on Linux that we do on Windows with
terminating sync requests from the renderer on the UI thread.

http://codereview.chromium.org/100238

BUG=9865

------------------------------------------------------------------------
r15027 | ericroman@google.com | 2009-05-01 03:25:14 +0200 (Fri, 01 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Undisable the temporarily disabled test, by fixing the URL expectation to have %22 instead of \" (to match change in GURL canonicalization).

BUG=11142
TBR=evan

Review URL: http://codereview.chromium.org/100148
------------------------------------------------------------------------
r15022 | ben@chromium.org | 2009-05-01 02:17:09 +0200 (Fri, 01 May 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/window/non_client_view.cc

People should just use GetWindow() instead of calling GetWidget()->GetWindow()

Review URL: http://codereview.chromium.org/102020
------------------------------------------------------------------------
r15020 | abarth@chromium.org | 2009-05-01 02:11:40 +0200 (Fri, 01 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

Stop the location bar from flashing white when navigating from one HTTPS site to another.  To do this, we have to make sure the SSLManager sees the DidCommitProvisionalLoad event before the location bar draws itself to the screen.

BUG=11157
TEST=Navigate from one HTTPS site to another and watch the location bar carefully.  It shouln't flash anymore.

Review URL: http://codereview.chromium.org/99247
------------------------------------------------------------------------
r15018 | abarth@chromium.org | 2009-05-01 02:03:49 +0200 (Fri, 01 May 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc

Add some histograms to see how often users click through blocking pages.

R=jar

Review URL: http://codereview.chromium.org/99020

------------------------------------------------------------------------
r15014 | estade@chromium.org | 2009-05-01 01:15:02 +0200 (Fri, 01 May 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

GTK: give the findbox curvy edges.

Most of the new code concerns shaping the widget to be non-rectangular.

Also, sprinkle some "const" qualifiers on NineBox functions.

Review URL: http://codereview.chromium.org/100224
------------------------------------------------------------------------
r15013 | munjal@chromium.org | 2009-05-01 01:09:01 +0200 (Fri, 01 May 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_model_test_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Implement ID persistence for bookmarks:
- Bookmark codec now takes in a ctor argument persist_ids
- If it's true, it will serialize IDs of bookmarks when encoding, and
  deserialize already serialized IDs (if present) when decoding.
- During decoding, unique-ify the IDs if they are not unique.
- Add unit tests for all new code.


Coming up in a separate changelist:
- Move ID generation logic to bookmark model, and make it non-static.

Review URL: http://codereview.chromium.org/99217
------------------------------------------------------------------------
r14993 | estade@chromium.org | 2009-04-30 23:10:20 +0200 (Thu, 30 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

GTK: Allow the user to resize the chromium window as small as they like.

Review URL: http://codereview.chromium.org/100219
------------------------------------------------------------------------
r14991 | rohitrao@chromium.org | 2009-04-30 22:58:30 +0200 (Thu, 30 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Fixes the implementation of TabContentsViewMac::TakeFocus().

Review URL: http://codereview.chromium.org/99245
------------------------------------------------------------------------
r14990 | rohitrao@chromium.org | 2009-04-30 22:58:19 +0200 (Thu, 30 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Changes the way we calculate hit rects in TabView to reduce
overlap between tabs.

TEST=Open a few tabs, try clicking on the right half of the close button that's
to the left of the selected tab.

Review URL: http://codereview.chromium.org/99225
------------------------------------------------------------------------
r14989 | ben@chromium.org | 2009-04-30 22:55:35 +0200 (Thu, 30 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h

Adds a GetWindow method to View.

Review URL: http://codereview.chromium.org/100221
------------------------------------------------------------------------
r14988 | kuchhal@chromium.org | 2009-04-30 22:55:12 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/installer/util/master_preferences.h

Add two new master preferences (import_bookmarks and make_default_browser_for_user). make_default_browser_for_user will make Chrome default on the first run of Chrome instead of installer doing it. This will allow Chrome to import user profile data from current default browser, before making Chrome default.

BUG=9708,10912

Review URL: http://codereview.chromium.org/99165

------------------------------------------------------------------------
r14985 | ben@chromium.org | 2009-04-30 22:40:53 +0200 (Thu, 30 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Don't show popups before tabs have been added. Instead, prevent the BrowserView from restoring focus to the tab if the window that contains it isn't visible. This prevents blur events from being fired incorrectly.

http://crbug.com/7991

Review URL: http://codereview.chromium.org/99248
------------------------------------------------------------------------
r14982 | jcampan@chromium.org | 2009-04-30 21:54:31 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc
   M /trunk/src/chrome/views/focus/focus_manager.h

Patch for accelerator clean-up from Hamaji.
See http://codereview.chromium.org/99161

TBR=hamami

Review URL: http://codereview.chromium.org/99228
------------------------------------------------------------------------
r14981 | pinkerton@chromium.org | 2009-04-30 21:41:21 +0200 (Thu, 30 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm

Turn off unit test that fails on builder.
------------------------------------------------------------------------
r14976 | rafaelw@chromium.org | 2009-04-30 21:34:25 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

use EXTENSION_FUNCTION_VALIDATE in extension_tabs_module.cc

BUG=11200
R=erikkay

Review URL: http://codereview.chromium.org/100213
------------------------------------------------------------------------
r14974 | ben@chromium.org | 2009-04-30 21:31:18 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Correct omnibox2 popup placement for RTL languages.

Xiaomei, I just applied the code that you suggested in your email and it worked.


Review URL: http://codereview.chromium.org/99237
------------------------------------------------------------------------
r14973 | estade@chromium.org | 2009-04-30 21:28:41 +0200 (Thu, 30 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc

GTK: Directly allocate widgets that are children of GtkFixed.

BUG=11190

Review URL: http://codereview.chromium.org/99243
------------------------------------------------------------------------
r14972 | mal@chromium.org | 2009-04-30 21:27:44 +0200 (Thu, 30 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Upadte version for the  Lithuanian spell check dictionary.

BUG= 11175
R= sidchat
TEST= See bug. Also check that the dictionary under Chrome\Application\Dictionaries
is lt-lt-1-3.bdic.
Review URL: http://codereview.chromium.org/99241
------------------------------------------------------------------------
r14967 | pinkerton@chromium.org | 2009-04-30 21:23:58 +0200 (Thu, 30 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm

Add notification (and unit test) for closing prefs window so it can be cleaned up properly in the app controller. Make the prefs window controller the window's delegate so it gets close notifications.
Review URL: http://codereview.chromium.org/99238
------------------------------------------------------------------------
r14958 | pinkerton@chromium.org | 2009-04-30 19:59:24 +0200 (Thu, 30 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   A /trunk/src/chrome/browser/cocoa/preferences_window_controller.h
   A /trunk/src/chrome/browser/cocoa/preferences_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/preferences_window_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add a very basic preferences window controller with unit test. Fix the prefs nib to know the FileOwner is a NSWindowController and hook them together.
Review URL: http://codereview.chromium.org/102015
------------------------------------------------------------------------
r14952 | jcampan@chromium.org | 2009-04-30 19:11:10 +0200 (Thu, 30 Apr 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Relanding this, it was missing the Mac unit-test change, that was breaking the build.
TBR=ben

Closing the last tab with a download in-progress would cause the tab to be
closed and become unusable if the user decides not to proceed with the browser
shutdown.
This is because we check for in-progress downloads when the browser is closed,
and the tab is closed before that, leaving the tab-strip in a bad state.

This CL ensures we also bring-up the confirmation dialog when the last tab is
closed.

BUG=10680
TEST=Start downloading a big file. While the file is downloading, close all
tabs. When closing the last tab, the in-progress download dialog should be
shown. Select the 'Wait for downloads', the download tab should be shown and
the previous tab should still be displayed and functional.
Close all tabs again, this time select the 'Close and cancel downloads'
option, the browser should be closed.
Review URL: http://codereview.chromium.org/100210
------------------------------------------------------------------------
r14951 | tim@chromium.org | 2009-04-30 19:00:24 +0200 (Thu, 30 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/in_process_browser_test.cc

Fix issue 11006 - any plugin process started by InProcessBrowserTest was
using the unit_test executable rather than chrome.exe.  This patch repurposes
the --renderer-path switch to be --browser-subprocess-path for both plugins and
renderers.  

BUG=11006
TEST=Any InProcessBrowserTest (they all will start at least one renderer). Use
NavigateToURL to a URL containing flash, we shouldn't crash.


Review URL: http://codereview.chromium.org/99011
------------------------------------------------------------------------
r14949 | jcampan@chromium.org | 2009-04-30 18:42:05 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Reverting 14948.

Broke the Mac build.

TBR=ben
Review URL: http://codereview.chromium.org/99224
------------------------------------------------------------------------
r14948 | jcampan@chromium.org | 2009-04-30 18:30:38 +0200 (Thu, 30 Apr 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Closing the last tab with a download in-progress would cause the tab to be
closed and become unusable if the user decides not to proceed with the browser
shutdown.
This is because we check for in-progress downloads when the browser is closed,
and the tab is closed before that, leaving the tab-strip in a bad state.

This CL ensures we also bring-up the confirmation dialog when the last tab is
closed.

BUG=10680
TEST=Start downloading a big file. While the file is downloading, close all
tabs. When closing the last tab, the in-progress download dialog should be
shown. Select the 'Wait for downloads', the download tab should be shown and
the previous tab should still be displayed and functional.
Close all tabs again, this time select the 'Close and cancel downloads'
option, the browser should be closed.


Review URL: http://codereview.chromium.org/99195
------------------------------------------------------------------------
r14945 | pinkerton@chromium.org | 2009-04-30 18:01:52 +0200 (Thu, 30 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   A /trunk/src/chrome/app/nibs/en.lproj/Preferences.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/chrome.gyp

Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use scoped pointers to manage memory.
Review URL: http://codereview.chromium.org/100206
------------------------------------------------------------------------
r14944 | deanm@chromium.org | 2009-04-30 17:56:46 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/app/theme/o2_globe_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_history_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_more_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_search_selected_dark.png
   A /trunk/src/chrome/app/theme/o2_star_selected_dark.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Add a dark selected icon set for the Omnibox results.

This is used for Linux, where we're currently not doing inverse selection.

Review URL: http://codereview.chromium.org/100207

------------------------------------------------------------------------
r14943 | deanm@chromium.org | 2009-04-30 17:30:19 +0200 (Thu, 30 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

The "size-request" event is run-first, clean up the Omnibox handler.

This wasn't actually a bug in that everything worked fine.  It just meant we
were calling the default handler twice, and returning from what should have
been a void function.

Review URL: http://codereview.chromium.org/99218

------------------------------------------------------------------------
r14942 | deanm@chromium.org | 2009-04-30 17:28:52 +0200 (Thu, 30 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Use the new selected icons in Linux Omnibox.

Review URL: http://codereview.chromium.org/100200

------------------------------------------------------------------------
r14941 | deanm@chromium.org | 2009-04-30 17:24:37 +0200 (Thu, 30 Apr 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/info_bubble_gtk.cc
   A /trunk/src/chrome/browser/gtk/info_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Implement a mostly working InfoBubble with a shim BookmarkBubble.

This ended up being implemented as a toplevel instead of a popup, to handle
things like virtual desktop switching.  I imagine there are some other problems
we might hit, like the window getting decorated, etc.  Although I think the
shape mask might prevent decorations from being visible.  This is not pixel
perfect with Windows, since we're not anti-aliasing the frame border.

Review URL: http://codereview.chromium.org/100203

------------------------------------------------------------------------
r14939 | rohitrao@chromium.org | 2009-04-30 16:52:00 +0200 (Thu, 30 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm

Minimal SetInitialFocus and RestoreFocus. These aren't final, but this
does resolve the location bar not being focused bug on the mac build.

Patch by Sean Bryant (sean@cyberwang.net).

BUG=9419

Review URL: http://codereview.chromium.org/100140
------------------------------------------------------------------------
r14934 | phajdan.jr@chromium.org | 2009-04-30 10:59:39 +0200 (Thu, 30 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/views/window/dialog_client_view.h

Make task_manager_resource_providers.cc compile on POSIX.

TEST=Make sure that the task manager isn't obviously broken on Windows.

Review URL: http://codereview.chromium.org/93067
------------------------------------------------------------------------
r14933 | hbono@chromium.org | 2009-04-30 10:30:44 +0200 (Thu, 30 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

A quick fix for supporting bidirectional texts in omnibox2.
It seems the AutocompleteResultView::DrawString() function calls the AutocompleteResultView::DrawStringFragment() function even when |text_start| is greater than |text_end|, i.e. there are not matching characters.
This change filters out the above case and fixes a couple of lint errors.
Review URL: http://codereview.chromium.org/100196
------------------------------------------------------------------------
r14924 | rafaelw@chromium.org | 2009-04-30 02:48:51 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/samples/tabs/tabs_api.html

Implement removeWindow, onWindowCreated, onWindowRemoved.

BUG=11200
R=aa

Review URL: http://codereview.chromium.org/100164
------------------------------------------------------------------------
r14914 | aa@chromium.org | 2009-04-30 01:52:27 +0200 (Thu, 30 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_host.cc
   M /trunk/src/chrome/browser/extensions/extension_host.h
   M /trunk/src/chrome/test/data/extensions/samples/bookmarks/bookmark_api.html
   D /trunk/src/chrome/test/data/extensions/samples/bookmarks/extensions_toolstrip.css
   M /trunk/src/chrome/test/data/extensions/samples/buildbot/buildbot.html
   D /trunk/src/chrome/test/data/extensions/samples/buildbot/extensions_toolstrip.css
   D /trunk/src/chrome/test/data/extensions/samples/buildbot.crx
   D /trunk/src/chrome/test/data/extensions/samples/gmail/extensions_toolstrip.css
   M /trunk/src/chrome/test/data/extensions/samples/gmail/gmail_checker.html
   D /trunk/src/chrome/test/data/extensions/samples/gmail.crx
   D /trunk/src/chrome/test/data/extensions/samples/subscribe/extensions_toolstrip.css
   M /trunk/src/chrome/test/data/extensions/samples/subscribe/toolstrip.html
   D /trunk/src/chrome/test/data/extensions/samples/subscribe.crx

Fix race where sometimes CSS is not applied to toolstrips. I
think this was happening because we were injecting from the the
browser at load_start, but the document might not be established
in the renderer by the time this message is received.

Since we are now not even showing the toolstrip until
load_complete, it is no big deal to delay the CSS injection
until then.

Review URL: http://codereview.chromium.org/100182
------------------------------------------------------------------------
r14913 | dkegel@google.com | 2009-04-30 01:44:36 +0200 (Thu, 30 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Avoid invalid read reported by valgrind, http://crbug.com/11132,
when tab->GetActiveEntry() is NULL.

Review URL: http://codereview.chromium.org/100172
------------------------------------------------------------------------
r14912 | thestig@chromium.org | 2009-04-30 01:14:03 +0200 (Thu, 30 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Basic fullscreen mode for Linux, without the animated exit bubble.

Parts of the code are from ermilov.maxim@gmail.com. Thanks!

BUG=8405
Review URL: http://codereview.chromium.org/100106
------------------------------------------------------------------------
r14910 | pkasting@chromium.org | 2009-04-30 01:08:37 +0200 (Thu, 30 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/controls/menu/menu.cc
   M /trunk/src/chrome/views/controls/menu/menu.h

Make "Reopen closed tab" be "Reopen closed window" when a window is the top item on the closed tabs stack.

Original patch by Miranda Callahan (see http://codereview.chromium.org/100054 ), r=me.

BUG=11183
------------------------------------------------------------------------
r14902 | mpcomplete@google.com | 2009-04-30 00:24:31 +0200 (Thu, 30 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   A /trunk/src/chrome/browser/extensions/extension_host.cc (from /trunk/src/chrome/browser/extensions/extension_view.cc:14092)
   A /trunk/src/chrome/browser/extensions/extension_host.h (from /trunk/src/chrome/browser/extensions/extension_view.h:14092)
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   D /trunk/src/chrome/test/data/extensions/extension1
   D /trunk/src/chrome/test/data/extensions/extension2
   D /trunk/src/chrome/test/data/extensions/extension3
   A /trunk/src/chrome/test/data/extensions/good/extension2/2/background.html
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json

Refactor ExtensionView to support a UI-less extension instance.
- Introduce ExtensionHost, which is the guy that talks to the RenderViewHost.
- ExtensionView holds an ExtensionHost, and also renders its contents in an
  HWND.
- Added code to load a page optionally specified in the manifest as a
  background process whenever it exists.
Review URL: http://codereview.chromium.org/92043
------------------------------------------------------------------------
r14901 | jcampan@chromium.org | 2009-04-30 00:24:01 +0200 (Thu, 30 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   M /trunk/src/chrome/test/data/ssl/google.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h

Migrating the SSL UI tests to be browser tests.
Reenabling all of them.
Hopefully it'll help with flakiness.

Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux.

BUG=6584,2136
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/101013
------------------------------------------------------------------------
r14898 | pinkerton@chromium.org | 2009-04-30 00:08:04 +0200 (Thu, 30 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Move window chrome into drag overlay so they stand out more during a drag out of a window.
Review URL: http://codereview.chromium.org/99206
------------------------------------------------------------------------
r14894 | kuchhal@chromium.org | 2009-04-29 23:37:09 +0200 (Wed, 29 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Fix a DCHECK hit from RefCountedBase class.

Review URL: http://codereview.chromium.org/100170

------------------------------------------------------------------------
r14893 | estade@chromium.org | 2009-04-29 23:33:52 +0200 (Wed, 29 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h

Fix SlideAnimatorGtk::OpenWithoutAnimation().

We weren't sizing the GtkFixed widget because the animation delegate callbacks weren't being called. Now we artificially call AnimationProgressed() once we know what size the GtkFixed should be.

TEST=switching back to a tab that has an infobar open should properly display that infobar.

Review URL: http://codereview.chromium.org/99110
------------------------------------------------------------------------
r14889 | estade@chromium.org | 2009-04-29 23:22:27 +0200 (Wed, 29 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

missing file from last commit

------------------------------------------------------------------------
r14886 | pkasting@chromium.org | 2009-04-29 23:19:27 +0200 (Wed, 29 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Second attempt at cleaning up handling of --disable-popup-blocking.  I didn't realize that now window.open() will result in a popup with this flag, where before it resulted in a tab.  This necessitated changes to a test that expected one window and two tabs to expect two windows each with one tab.

I also fixed the test to not crash when some expectations were not met (by using ASSERT_ instead of EXPECT_), and to properly use (expected, actual) instead of (actual, expected).
Review URL: http://codereview.chromium.org/99203
------------------------------------------------------------------------
r14885 | estade@chromium.org | 2009-04-29 23:17:36 +0200 (Wed, 29 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc

Linux findbar improvements:

* clean up toolbar/infobar/findbar borders
* move findbar to BrowserWindowGtk's vbox (so it stacks on top of infobar, as on windows)
* properly show findbar when switching between tabs
Review URL: http://codereview.chromium.org/99166
------------------------------------------------------------------------
r14880 | ben@chromium.org | 2009-04-29 22:32:03 +0200 (Wed, 29 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Patch from <yuzo@google.com>:

Disable view-source if the page source is not viewable as text.
For example, a page of content type application/x-shockwave-flash
is not viewable.

http://crbug.com/9562

Review URL: http://codereview.chromium.org/66061

------------------------------------------------------------------------
r14879 | pinkerton@chromium.org | 2009-04-29 22:30:54 +0200 (Wed, 29 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Implement dropping of tabs into an existing tab strip from another window. Implement dragging and dropping of tabs within a window.
Review URL: http://codereview.chromium.org/102010
------------------------------------------------------------------------
r14877 | erikkay@google.com | 2009-04-29 22:28:46 +0200 (Wed, 29 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   M /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/bookmarks/bookmark_api.html
   M /trunk/src/chrome/test/data/extensions/bookmarks/bookmark_view.html

more extensions bookmarks changes:* add schema verification* add unit tests for schema* add a few new methods (getTree, getChildren)* add events
Review URL: http://codereview.chromium.org/102009
------------------------------------------------------------------------
r14876 | avi@google.com | 2009-04-29 22:26:20 +0200 (Wed, 29 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Switch to a raw kAEOpenDocuments AppleEvent handler for opening dropped files to avoid crashes when Cocoa feeds us files specified on the command line.

Review URL: http://codereview.chromium.org/100142
------------------------------------------------------------------------
r14873 | ben@chromium.org | 2009-04-29 22:04:07 +0200 (Wed, 29 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/o2_globe_selected.png
   A /trunk/src/chrome/app/theme/o2_history_selected.png
   A /trunk/src/chrome/app/theme/o2_more_selected.png
   A /trunk/src/chrome/app/theme/o2_search_selected.png
   A /trunk/src/chrome/app/theme/o2_star_selected.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Add descriptive text for omnibox popup result items.

Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.

Back to using system colors. Adds highlight icons.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14826
Review URL: http://codereview.chromium.org/99102
------------------------------------------------------------------------
r14870 | sky@chromium.org | 2009-04-29 21:48:50 +0200 (Wed, 29 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Fixes bug in dragging tabs. Specifically if you only have one window
with one tab, drag the tab, and while dragging click and release the
right mouse button we get all confused. This is because we get two
OnMousePressed events in a row, which results in cancelling out the
current drag which doesn't work well when only one tab with one window
is left.

BUG=10800
TEST=see bug

Review URL: http://codereview.chromium.org/100169
------------------------------------------------------------------------
r14869 | jhawkins@chromium.org | 2009-04-29 21:45:42 +0200 (Wed, 29 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Close the hovered tab on middle mouse click in the Linux tabstrip.

BUG=11146
Review URL: http://codereview.chromium.org/99194
------------------------------------------------------------------------
r14868 | sky@chromium.org | 2009-04-29 21:40:09 +0200 (Wed, 29 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/widget/widget.h
   M /trunk/src/chrome/views/widget/widget_gtk.cc
   M /trunk/src/chrome/views/widget/widget_gtk.h
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/widget/widget_win.h
   M /trunk/src/chrome/views/window/non_client_view.cc
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Two changes:

. Removes MoveToFront on Widget.
. CHanges AsWindow to GetWindow.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/99133
------------------------------------------------------------------------
r14862 | sgjesse@chromium.org | 2009-04-29 20:54:22 +0200 (Wed, 29 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc

Stop debugger by escape key.

BUG=6890

Review URL: http://codereview.chromium.org/92116

------------------------------------------------------------------------
r14855 | dkegel@google.com | 2009-04-29 20:16:43 +0200 (Wed, 29 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Free gtk list.  Should fix valgrind warning

24 (12 direct, 12 indirect) bytes in 1 blocks are definitely lost in loss record 54 of 258 
   at malloc (vg_replace_malloc.c:178)
   ...
   by gtk_container_foreach (in /usr/lib/libgtk-x11-2.0.so.0.1200.9)
   by gtk_container_get_children (in /usr/lib/libgtk-x11-2.0.so.0.1200.9)
   by (anonymous namespace)::OnDialogResponse(_GtkDialog*, int, AppModalDialog*) (app_modal_dialog_gtk.cc:24)

Review URL: http://codereview.chromium.org/102007
------------------------------------------------------------------------
r14853 | evan@chromium.org | 2009-04-29 19:55:35 +0200 (Wed, 29 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Revert "Instead of passing down a switch to the renderer, storing a member, etc., just implement --disable-popup-blocking in the browser at the point where we make the final policy decision."

This reverts commit r14851.

As it DID NOT PASS THE TRY BOTS.
------------------------------------------------------------------------
r14851 | pkasting@chromium.org | 2009-04-29 18:26:43 +0200 (Wed, 29 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Instead of passing down a switch to the renderer, storing a member, etc., just implement --disable-popup-blocking in the browser at the point where we make the final policy decision.
Review URL: http://codereview.chromium.org/100132
------------------------------------------------------------------------
r14848 | deanm@chromium.org | 2009-04-29 17:54:09 +0200 (Wed, 29 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Unref the GC so it's destroy after we create it.

Review URL: http://codereview.chromium.org/99190

------------------------------------------------------------------------
r14846 | mbelshe@google.com | 2009-04-29 17:53:26 +0200 (Wed, 29 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/resources/about_memory.html

Support for showing memory usage of 64-bit IE in a 32-bit Chromium 

This is a changelist for http://codereview.chromium.org/75031 by Kent Tamura (tkent@google.com)


Review URL: http://codereview.chromium.org/100111
------------------------------------------------------------------------
r14845 | deanm@chromium.org | 2009-04-29 17:50:23 +0200 (Wed, 29 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Back to creating a new GC for each expose.

The style (or at least the GCs) are shared across widgets, so they shouldn't
be modified, or should be restored.  Creating a GC should be cheap enough, I
was overthinking this.

Review URL: http://codereview.chromium.org/100161

------------------------------------------------------------------------
r14841 | rohitrao@chromium.org | 2009-04-29 16:37:55 +0200 (Wed, 29 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Adds items to the Window menu on Mac.

TEST=Open multiple windows, make sure the entries in the Window menu
match the titles of the currently selected tabs.

Review URL: http://codereview.chromium.org/100121
------------------------------------------------------------------------
r14828 | ben@chromium.org | 2009-04-29 07:11:00 +0200 (Wed, 29 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/theme/o2_globe_selected.png
   D /trunk/src/chrome/app/theme/o2_history_selected.png
   D /trunk/src/chrome/app/theme/o2_more_selected.png
   D /trunk/src/chrome/app/theme/o2_search_selected.png
   D /trunk/src/chrome/app/theme/o2_star_selected.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Reverting 14826.
------------------------------------------------------------------------
r14827 | ukai@chromium.org | 2009-04-29 06:57:24 +0200 (Wed, 29 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Support PgUp/PgDn in Omnibox for "first entry/last entry"

BUG=6857

------------------------------------------------------------------------
r14826 | ben@chromium.org | 2009-04-29 06:46:44 +0200 (Wed, 29 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/o2_globe_selected.png
   A /trunk/src/chrome/app/theme/o2_history_selected.png
   A /trunk/src/chrome/app/theme/o2_more_selected.png
   A /trunk/src/chrome/app/theme/o2_search_selected.png
   A /trunk/src/chrome/app/theme/o2_star_selected.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Add descriptive text for omnibox popup result items.

Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.

Back to using system colors. Adds highlight icons.

Review URL: http://codereview.chromium.org/99102
------------------------------------------------------------------------
r14819 | brettw@chromium.org | 2009-04-29 04:42:09 +0200 (Wed, 29 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h

Write a test for my previous patch to fix a crash in back/forward navigations
creating new tabs.
Review URL: http://codereview.chromium.org/100031
------------------------------------------------------------------------
r14815 | ericroman@google.com | 2009-04-29 03:34:05 +0200 (Wed, 29 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Update a test expectation due to rolling GURL dep.
One test still needs further investigation, disabling it.

BUG=11142

Review URL: http://codereview.chromium.org/99167
------------------------------------------------------------------------
r14801 | kuchhal@chromium.org | 2009-04-29 01:49:14 +0200 (Wed, 29 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/common/platform_util_mac.mm

Fix mac build break.

Review URL: http://codereview.chromium.org/100139

------------------------------------------------------------------------
r14798 | paul@chromium.org | 2009-04-29 01:34:37 +0200 (Wed, 29 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/webkit/glue/webmenurunner_mac.h
   M /trunk/src/webkit/glue/webmenurunner_mac.mm
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm

Style fixes for previous review:
http://codereview.chromium.org/92062

I didn't make WebMenuRunner's menu_ a scoped_nsobject, because I'm not
sure how that will ever be released (~scoped_nsobject won't get called
from a Cocoa object's dealloc?).

Review URL: http://codereview.chromium.org/99088
------------------------------------------------------------------------
r14796 | tc@google.com | 2009-04-29 01:17:20 +0200 (Wed, 29 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Bah, I should compile before fixing.  Need to assign the results of
g_list_next().

TBR=evan

Review URL: http://codereview.chromium.org/99159

------------------------------------------------------------------------
r14792 | jhawkins@chromium.org | 2009-04-29 00:57:48 +0200 (Wed, 29 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fix the case where a previous tab is closing and the mouse is pressed on a tab to the right of the closing tab.
Review URL: http://codereview.chromium.org/100116
------------------------------------------------------------------------
r14791 | tc@google.com | 2009-04-29 00:57:10 +0200 (Wed, 29 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Implement a couple more methods for dialog boxes including the prompt box.

BUG=9623

Review URL: http://codereview.chromium.org/100124

------------------------------------------------------------------------
r14785 | estade@chromium.org | 2009-04-28 23:29:08 +0200 (Tue, 28 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

Linux: Make the findbar hang over the render view.

BUG=10948
Review URL: http://codereview.chromium.org/100077
------------------------------------------------------------------------
r14773 | evan@chromium.org | 2009-04-28 21:58:53 +0200 (Tue, 28 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc

plugins: Some obvious ifdef removals (code that previously wouldn't link).

Review URL: http://codereview.chromium.org/100118
------------------------------------------------------------------------
r14763 | erg@google.com | 2009-04-28 21:32:15 +0200 (Tue, 28 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_editor.h
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/chrome.gyp

Create a bookmark editor dialog interface and implement a GTK version.

The GTK version is currently limited to only editing the name/url of the
bookmark; I'm submitting this since it's getting big and I want a design
review.

Review URL: http://codereview.chromium.org/99131
------------------------------------------------------------------------
r14762 | kuchhal@chromium.org | 2009-04-28 21:30:51 +0200 (Tue, 28 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_view.cc

Make Chrome default after importing from current default browser.

BUG=11094

Review URL: http://codereview.chromium.org/99136

------------------------------------------------------------------------
r14758 | pinkerton@chromium.org | 2009-04-28 21:03:39 +0200 (Tue, 28 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/en.lproj/TabView.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm

Support for tabs reaching a threshold before tearing off (magnetism), showing position of where the tab will go in the destination tab strip. Use new close box icon. Don't draw the tab title over the close box. Patch from alcor@google.com
------------------------------------------------------------------------
r14751 | evan@chromium.org | 2009-04-28 20:28:30 +0200 (Tue, 28 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Disable Tab1Tab2, as it's flaky.

BUG=10941

Review URL: http://codereview.chromium.org/99138
------------------------------------------------------------------------
r14743 | jhawkins@chromium.org | 2009-04-28 19:47:30 +0200 (Tue, 28 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Always simulate a mouse movement after animations in the Linux tabstrip to make sure we never have a stale hover index.
Review URL: http://codereview.chromium.org/101009
------------------------------------------------------------------------
r14738 | jcampan@chromium.org | 2009-04-28 19:17:10 +0200 (Tue, 28 Apr 2009) | 22 lines
Changed paths:
   A /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc (from /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc:14668)
   A /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc (from /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc:14668)
   D /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/chrome.sln
   A /trunk/src/chrome/test/browser (from /trunk/src/chrome/test/browser:14668)
   M /trunk/src/chrome/test/browser/browser_tests_dll.vcproj
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   A /trunk/src/chrome/tools/build/win/browser_tests_dll.vsprops (from /trunk/src/chrome/tools/build/win/browser_tests_dll.vsprops:14668)

Relanding this: 

This patch adds a new kind of tests: browser tests.
They are intended to provide an alternative to the UI tests, hopefully helping
with flackiness.
These tests are in-process browser test.
There are 2 projects to build the tests:
- the browser_test.dll that contains the tests, the gtest framework and the
browser classes.
- the browser_test_launcher.exe.

The launcher loads the browser_test.dll for each test, run the test and then
unloads the DLL. This insures the static initializers are run before each test
and that any atexit handler is invoked properly.

This is Windows only for now.

BUG=9764
TEST=Run browser_test.exe
TBR=maruel

Review URL: http://codereview.chromium.org/99097
------------------------------------------------------------------------
r14737 | avi@google.com | 2009-04-28 19:15:19 +0200 (Tue, 28 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Allow File>Open File with no window open.

Review URL: http://codereview.chromium.org/99128
------------------------------------------------------------------------
r14729 | rohitrao@chromium.org | 2009-04-28 16:48:20 +0200 (Tue, 28 Apr 2009) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/find_bar_bridge_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Unittest for FindBarBridge.

TEST=The new unittest passes.
BUG=10802
------------------------------------------------------------------------
r14726 | pinkerton@chromium.org | 2009-04-28 15:32:03 +0200 (Tue, 28 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm

Swap NOTIMPLEMENTED with a bug comment.
Review URL: http://codereview.chromium.org/99085
------------------------------------------------------------------------
r14718 | brettw@chromium.org | 2009-04-28 08:52:35 +0200 (Tue, 28 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Synchronously update the loading state when a load starts so that the UI will
be more responsive and the loading state won't be out-of-sync with anything
else. This also removes the synchronous update to the throbber when we load a
URL because this happens before the loda actually starts, giving a flash of the
default favicon. The load start call made by RenderViewHost will cover this
case after the load actually starts.

BUG=11051
Review URL: http://codereview.chromium.org/100033
------------------------------------------------------------------------
r14717 | phajdan.jr@chromium.org | 2009-04-28 08:50:36 +0200 (Tue, 28 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/important_file_writer.cc
   A /trunk/src/chrome/common/important_file_writer.h
   A /trunk/src/chrome/common/important_file_writer_unittest.cc
   M /trunk/src/chrome/common/pref_member_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h

ImportantFileWriter

Introducing a class for writing important files, preventing their corruption during writing.

Switched PrefService to use it. Other classes will be switched in future changesets.

TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences.

http://crbug.com/10618

Review URL: http://codereview.chromium.org/83001
------------------------------------------------------------------------
r14710 | rafaelw@chromium.org | 2009-04-28 05:09:53 +0200 (Tue, 28 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Implement tabs.createWindow extension api call. Required: (a) new RVHDelegate & TabContentsDelegate method(s) CreateExtensionFunctionDispatcher() so that the dispatcher could be created with (an optional) browser attached to it, while avoiding having render_host depend on browser.h

BUG=11092:
R=aa,mpComplete,darin,pkasting

Review URL: http://codereview.chromium.org/79070
------------------------------------------------------------------------
r14708 | agl@chromium.org | 2009-04-28 03:50:01 +0200 (Tue, 28 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

POSIX: = {0} syntax causes a warning.

(Replace with memset)

------------------------------------------------------------------------
r14705 | agl@chromium.org | 2009-04-28 03:37:23 +0200 (Tue, 28 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/base/process_posix.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/process_watcher.cc
   A /trunk/src/chrome/common/process_watcher_posix.cc
   A /trunk/src/chrome/common/process_watcher_win.cc (from /trunk/src/chrome/common/process_watcher.cc:14702)
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

POSIX: don't spawn zombies.

http://codereview.chromium.org/93147

BUG=9401

------------------------------------------------------------------------
r14690 | willchan@chromium.org | 2009-04-28 02:14:47 +0200 (Tue, 28 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Filter modifier to only include accelerator modifiers.

Review URL: http://codereview.chromium.org/99103
------------------------------------------------------------------------
r14689 | klink@chromium.org | 2009-04-28 02:12:01 +0200 (Tue, 28 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   A /trunk/src/chrome/common/accessibility_types.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.h
   M /trunk/src/chrome/views/controls/button/button.cc
   M /trunk/src/chrome/views/controls/button/button.h
   M /trunk/src/chrome/views/controls/button/button_dropdown.cc
   M /trunk/src/chrome/views/controls/button/button_dropdown.h
   M /trunk/src/chrome/views/controls/button/menu_button.cc
   M /trunk/src/chrome/views/controls/button/menu_button.h
   M /trunk/src/chrome/views/controls/label.cc
   M /trunk/src/chrome/views/controls/label.h
   M /trunk/src/chrome/views/controls/label_unittest.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/chrome/views/widget/root_view_win.cc

Removes the use of Windows-specific types for accessibility roles and states in Views and Browser\Views. Helps with the porting effort, and makes for a cleaner implementation.
Review URL: http://codereview.chromium.org/93085
------------------------------------------------------------------------
r14688 | evan@chromium.org | 2009-04-28 02:11:27 +0200 (Tue, 28 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Convert Windows Sleep to PlatformThread::Sleep

First stage to make tests/others cross-platform.

BUG=None
TEST=Ran tests successfully (windows)

Review URL: http://codereview.chromium.org/63113
Patch from Mohamed Mansour <m0.interactive@gmail.com>.
------------------------------------------------------------------------
r14687 | jcampan@chromium.org | 2009-04-28 01:59:39 +0200 (Tue, 28 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h

When navigating from an interstitial to another page with an interstitial, we should not discard the non committed entries, as this would cause the new navigation pending entry to go away.

BUG=9791
TEST=Visit a page with an SSL error (ex: https://ebay.com). Focus the location bar and press enter (to navigate again to that page). The interstitial should be shown again and the location bar should show the URL. Also ensure that interstitial pages (SSL and safe browsing) still work as expected.
Review URL: http://codereview.chromium.org/100002
------------------------------------------------------------------------
r14683 | munjal@chromium.org | 2009-04-28 01:09:07 +0200 (Tue, 28 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Remove the unwanted code snippet that was removed by Tim, but
reintroduced in a later CL (probably due to SVN merge). This will
fix p13n build.


Review URL: http://codereview.chromium.org/99078
------------------------------------------------------------------------
r14682 | aa@chromium.org | 2009-04-28 01:04:48 +0200 (Tue, 28 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/data/extensions/test/Resizer/resizer.html
   M /trunk/src/webkit/glue/webview_impl.cc

Fix several painting glitches for toolstrips.

* Reset HWND size when HWNDHtmlView changes size. The two should always be in sync.

* Race: We might already have frames when RenderWidget receives a new background, need to set these to transparent too.

* Race: Toolstrip background not always available by the time ExtensionToolstrip is constucted

* Make images line up correctly for toolstrip buttons.

Review URL: http://codereview.chromium.org/99042
------------------------------------------------------------------------
r14680 | tc@google.com | 2009-04-28 01:01:34 +0200 (Tue, 28 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Revert r14620 which was a rollback of r14549 and r14508.  This
change re-enables the ui tests.  Since jam re-enabled some tests,
I had to #ifdef around 4 tests that are not shutting down cleanly
on linux.  It looks like we have renderers that aren't shutting
down properly (pegged at 100% cpu).

Review URL: http://codereview.chromium.org/100061

------------------------------------------------------------------------
r14678 | jcampan@chromium.org | 2009-04-28 00:55:05 +0200 (Tue, 28 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Landing Hamaji's patch.
See http://codereview.chromium.org/93135
Review URL: http://codereview.chromium.org/99079
------------------------------------------------------------------------
r14673 | paul@chromium.org | 2009-04-28 00:07:18 +0200 (Tue, 28 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fix a popup menu offset bug.

BUG=8389

Review URL: http://codereview.chromium.org/99075
------------------------------------------------------------------------
r14669 | jcampan@chromium.org | 2009-04-27 23:53:03 +0200 (Mon, 27 Apr 2009) | 4 lines
Changed paths:
   D /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   D /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc
   A /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/chrome.sln
   D /trunk/src/chrome/test/browser
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   D /trunk/src/chrome/tools/build/win/browser_tests_dll.vsprops

Reverting my change it breaks release compilation on Windows.

TBR=maruel
Review URL: http://codereview.chromium.org/103001
------------------------------------------------------------------------
r14667 | shess@chromium.org | 2009-04-27 23:36:52 +0200 (Mon, 27 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc

Unfork some code who's dependency has landed on Mac.
I believe that this was originally commented out due to fonts not
being quite wired in.

Review URL: http://codereview.chromium.org/92142
------------------------------------------------------------------------
r14665 | kuchhal@chromium.org | 2009-04-27 23:30:55 +0200 (Mon, 27 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc

Do not send stats from Chromium builds.

BUG=1435533

Review URL: http://codereview.chromium.org/93109

------------------------------------------------------------------------
r14664 | jcampan@chromium.org | 2009-04-27 23:29:31 +0200 (Mon, 27 Apr 2009) | 14 lines
Changed paths:
   A /trunk/src/chrome/browser/ssl/ssl_browser_tests.cc
   A /trunk/src/chrome/browser/views/find_bar_win_browsertest.cc (from /trunk/src/chrome/browser/views/find_bar_win_unittest.cc:14127)
   D /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/chrome.sln
   A /trunk/src/chrome/test/browser
   A /trunk/src/chrome/test/browser/browser_tests_dll.vcproj
   A /trunk/src/chrome/test/browser/browser_tests_launcher.cc
   A /trunk/src/chrome/test/browser/browser_tests_launcher.vcproj
   A /trunk/src/chrome/test/browser/run_all_unittests.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   A /trunk/src/chrome/tools/build/win/browser_tests_dll.vsprops

This patch adds a new kind of tests: browser tests.
They are intended to provide an alternative to the UI tests, hopefully helping with flackiness.
These tests are in-process browser test.
There are 2 projects to build the tests:
- the browser_test.dll that contains the tests, the gtest framework and the browser classes.
- the browser_test_launcher.exe.

The launcher loads the browser_test.dll for each test, run the test and then unloads the DLL. This insures the static initializers are run before each test and that any atexit handler is invoked properly.

This is Windows only for now.

BUG=9764
TEST=Run browser_test.exe
Review URL: http://codereview.chromium.org/88066
------------------------------------------------------------------------
r14659 | shess@chromium.org | 2009-04-27 23:15:40 +0200 (Mon, 27 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Update selected line in model before accepting input when the user clicks in the popup.
BUG=10932

Review URL: http://codereview.chromium.org/93130
------------------------------------------------------------------------
r14657 | mark@chromium.org | 2009-04-27 23:11:34 +0200 (Mon, 27 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/quarantine_mac.h
   A /trunk/src/chrome/common/quarantine_mac.mm

Add quarantine metadata to downloads on the Mac.  Patch by Stuart Morgan
<stuart.morgan@gmail.com>.

BUG=10853

Code review URL: http://codereview.chromium.org/99005

------------------------------------------------------------------------
r14649 | jcampan@chromium.org | 2009-04-27 22:51:51 +0200 (Mon, 27 Apr 2009) | 15 lines
Changed paths:
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/views/widget/widget_win.cc

Relanding this. 
The Ole unitialization was failing on one of the Vista build-bot.
It is not clear when the Ole initialization is balanced when a CRichEditCtrl is created/destructed.
So I now turn it off explicitly.

This CL makes sure we unregister our Windows window classes when shut-down.
It also balances-out an OLE initialization performed by the CRichEditCTRL.

This is necessary for allowing to reload chrome.dll in a process, which is what
the browser tests will do.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/101004
------------------------------------------------------------------------
r14641 | shess@chromium.org | 2009-04-27 22:06:29 +0200 (Mon, 27 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm

Clean up construction of LocationBarViewMac objects.
This removes the need for SetField() accessors on
AutocompleteEditViewMac and AutocompletePopupViewMac, and also removes
the Init() wart on LocationBarViewMac.  Now everything is wired up in
the constructor.

Review URL: http://codereview.chromium.org/92136
------------------------------------------------------------------------
r14640 | jhawkins@chromium.org | 2009-04-27 22:03:59 +0200 (Mon, 27 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Fix a few crashes when trying to drag a closing tab.
Review URL: http://codereview.chromium.org/99065
------------------------------------------------------------------------
r14637 | scherkus@chromium.org | 2009-04-27 21:56:41 +0200 (Mon, 27 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/webmediaplayer_delegate_impl.cc

Adds --no-audio, which replaces the audio IPC layer with a mock audio device.

Useful for testing <audio> and <video> over remote desktop or on machines without sound cards.  Should also let mac/linux playback videos without our audio layer being implemented on those platforms.

Review URL: http://codereview.chromium.org/93132
------------------------------------------------------------------------
r14625 | avi@google.com | 2009-04-27 20:11:29 +0200 (Mon, 27 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Now that we have file dialogs, we might as well hook up "Open File" on the Mac.

Review URL: http://codereview.chromium.org/93145
------------------------------------------------------------------------
r14620 | tc@google.com | 2009-04-27 19:48:18 +0200 (Mon, 27 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Speculatively roll back r14549 and r14508.  The chrome browser
process is pegged at 100% cpu after ui_tests has exited.  Seeing
if this is the cause.  Will re-roll forward if it's not.

TBR=estade

Review URL: http://codereview.chromium.org/100047

------------------------------------------------------------------------
r14619 | willchan@chromium.org | 2009-04-27 19:27:54 +0200 (Mon, 27 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Add keyboard accelerators for IDC_FIND_NEXT and IDC_FIND_PREVIOUS.

Review URL: http://codereview.chromium.org/101007
------------------------------------------------------------------------
r14618 | pkasting@chromium.org | 2009-04-27 19:24:49 +0200 (Mon, 27 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/widget/widget_win.h
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/non_client_view.cc
   M /trunk/src/chrome/views/window/non_client_view.h
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Don't allow the browser window to be resized so small that layout starts breaking horribly.  When it _is_ small, draw the frame correctly.

This is an incomplete fix; only non-Aero main/popup/app windows are handled so far, but this was becoming hairy enough I wanted to checkpoint it.

BUG=9885
Review URL: http://codereview.chromium.org/100005
------------------------------------------------------------------------
r14615 | phajdan.jr@chromium.org | 2009-04-27 19:11:45 +0200 (Mon, 27 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Fix a memory leak in TaskManager

http://crbug.com/11068

Review URL: http://codereview.chromium.org/99059
------------------------------------------------------------------------
r14613 | jhawkins@chromium.org | 2009-04-27 19:02:50 +0200 (Mon, 27 Apr 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes a gcc-4.3 warning in tab_strip_gtk.cc.
Also factorizes some code in tab_strip.cc and tab_strip_gtk.cc.

One of the inlined call to GenerateStartAndEndWidths with end_tab_count =
start_tab_count - 1 caused line 164 to be rewritten as:
  if (start_tab_count < start_tab_count - 1 &&

  which raised the following warning with gcc-4.3:
    tab_strip_gtk.cc:164: warning: assuming signed overflow does not occur when
    assuming that (X - c) > X is always false

patch by vincent.zanotti@gmail.com <http://codereview.chromium.org/99031>

R=me
Review URL: http://codereview.chromium.org/100045
------------------------------------------------------------------------
r14612 | munjal@chromium.org | 2009-04-27 18:56:23 +0200 (Mon, 27 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_codec_unittest.cc

Add a way to checksum bookmark data to help determine if the
bookmarks file was changed by the user between two chrome runs.
- BookmarkCodec now serializes a checksum of bookmark data along
  side bookmark data during encoding.
- During decoding BookmarkCodec computes the checksum of deserialized
  data, and it also reads the checksum in the file.
- BookmarkCodec exposes both the checksums via getters.
- Add unit tests for BookmarkCodec, right now only checksum related.

Review URL: http://codereview.chromium.org/69028
------------------------------------------------------------------------
r14611 | tc@google.com | 2009-04-27 18:56:11 +0200 (Mon, 27 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h

Remove svn:executable and set svn:eol-style to LF.

TBR=dean
Review URL: http://codereview.chromium.org/99060
------------------------------------------------------------------------
r14609 | sky@chromium.org | 2009-04-27 18:15:44 +0200 (Mon, 27 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/common/page_transition_types.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Searching by keyword now generates a visit against the site with a
transition type of TAB_TO_SEARCH. This visit increments the typed
count and ensures if you use TAB_TO_SEARCH you still get autocompleted
to the site.

I'll add some tests for this, but want to make sure we're ok with it
before I do that.

BUG=3633
TEST=will be covered by unit tests.

Review URL: http://codereview.chromium.org/93087
------------------------------------------------------------------------
r14605 | deanm@chromium.org | 2009-04-27 17:40:29 +0200 (Mon, 27 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h

Linux Omnibox results improvements:
  - Honor the damage rect when painting result lines.
  - Move some code from GdkRectangle to gfx::Rect.
  - Drop GC creation and just use one from the widget's style.
  - Fix a bug in content/description width allocation.
  - Factor out the icon loading and switch into IconForMatch().

Review URL: http://codereview.chromium.org/99050

------------------------------------------------------------------------
r14604 | deanm@chromium.org | 2009-04-27 17:38:31 +0200 (Mon, 27 Apr 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc

Massively improve the performance of dragging a window over our window.

Our toolbar background is a 1 pixel wide image, which we tile by drawing a
pixbuf over and over.  The way the toolbar is laid out, everything shares
the same window.  The toolbar is painted first, then the buttons on top of
it, etc.  If the toolbar painting is slow, you can see gray trails when you
drag a window over and the exposes are slow to come back to X.

Honor the damage rect, so when we get tons of tiny exposes we aren't doing
this really inefficient tiling over the entire toolbar.  Improving the tiling
performance needs to be done separately.

Review URL: http://codereview.chromium.org/100036

------------------------------------------------------------------------
r14601 | pinkerton@chromium.org | 2009-04-27 15:07:38 +0200 (Mon, 27 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   A /trunk/src/chrome/browser/cocoa/tab_strip_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add a stub test for TabStripController. It doesn't fully work because of issues
creating WebContents objects. A bug has been filed to come back to it.
------------------------------------------------------------------------
r14600 | pinkerton@chromium.org | 2009-04-27 15:04:08 +0200 (Mon, 27 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm

Remove a NOTIMPLEMENTED() that's not necessary on Mac.
Review URL: http://codereview.chromium.org/97004
------------------------------------------------------------------------
r14599 | phajdan.jr@chromium.org | 2009-04-27 14:55:40 +0200 (Mon, 27 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.h

Add virtual dtor for TaskManager::ResourceProvider.

It has virtual methods but no virtual dtor. This change may help
fix memory leaks which appeared after adding unit tests for TaskManager.

Review URL: http://codereview.chromium.org/100041
------------------------------------------------------------------------
r14592 | deanm@chromium.org | 2009-04-27 10:13:43 +0200 (Mon, 27 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Use AutocompletePopupPositioner for the Linux Omnibox.

Now a few less magic numbers in exchange for a lot more plumbing.

BUG=10966

Review URL: http://codereview.chromium.org/92127

------------------------------------------------------------------------
r14591 | deanm@chromium.org | 2009-04-27 10:11:23 +0200 (Mon, 27 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h

Linux Omnibox mouse support.
 - Paint both concepts of hovered and selected lines.
 - Track mouse movements and button up/down.

TEST=Select, drag, and click entries in the Omnibox results.  Should behave just like Windows.

Review URL: http://codereview.chromium.org/92124

------------------------------------------------------------------------
r14590 | phajdan.jr@chromium.org | 2009-04-27 08:58:27 +0200 (Mon, 27 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.h
   A /trunk/src/chrome/browser/task_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add basic unit tests for TaskManager.

For now the tests are Windows-only, because the TaskManager isn't ported.
But they should make porting effort a bit safer.

TEST=Make sure that tests from unit_tests matching TaskManagerTest.* pass.

http://crbug.com/10844

Review URL: http://codereview.chromium.org/92071
------------------------------------------------------------------------
r14573 | abarth@chromium.org | 2009-04-27 01:54:41 +0200 (Mon, 27 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc

Revert 14569
------------------------------------------------------------------------
r14569 | abarth@chromium.org | 2009-04-27 01:35:22 +0200 (Mon, 27 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc

Add some histograms to see how often users click through blocking pages.

R=jar

Review URL: http://codereview.chromium.org/99020
------------------------------------------------------------------------
r14568 | abarth@chromium.org | 2009-04-27 01:30:48 +0200 (Mon, 27 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h

Monitor some sensitive UI actions for evidence of clickjacking.

Defending against clickjacking on these UI elements has a usability cost.  We should measure to see if anyone is trying these attacks before inventing some crazy half-workaround.

R=jar

Review URL: http://codereview.chromium.org/99021
------------------------------------------------------------------------
r14549 | agl@chromium.org | 2009-04-26 02:05:54 +0200 (Sun, 26 Apr 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/unload_uitest.cc

Linux: implement automation for modal dialogs.

The Linux ui_tests are currently red because
BrowserCloseBeforeUnloadOK and BrowserCloseBeforeUnloadCancel are
failing. This is because we didn't implement several automation
functions regarding modal dialogs and someone obviously wrote a test
which needed them.

So this is a TBR in order to green the tree.

TBR=tony

http://codereview.chromium.org/99032

------------------------------------------------------------------------
r14533 | brettw@chromium.org | 2009-04-25 21:43:52 +0200 (Sat, 25 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix a crash I introduced in r14053. It removed the setting of the controller in
one arm of an if statement.

BUG=10930
Review URL: http://codereview.chromium.org/99003
------------------------------------------------------------------------
r14518 | ben@chromium.org | 2009-04-25 06:41:17 +0200 (Sat, 25 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Show icons in the new omnibox popup.

Also fix some crashes.

Review URL: http://codereview.chromium.org/98003
------------------------------------------------------------------------
r14517 | jam@chromium.org | 2009-04-25 03:15:11 +0200 (Sat, 25 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/webkit/build/WebCore/WebCore.vcproj
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/webkit.gyp

Fix sudden termination after the latest WebKit merge.

BUG=10927

Review URL: http://codereview.chromium.org/93104
------------------------------------------------------------------------
r14508 | estade@chromium.org | 2009-04-25 01:55:36 +0200 (Sat, 25 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Port unload_uitest.cc and enable some of the tests on linux.

Make WaitForSingleProcess respect base::kNoTimeout (which is equivalent to INFINITE on windows).

Review URL: http://codereview.chromium.org/99008
------------------------------------------------------------------------
r14505 | estade@chromium.org | 2009-04-25 01:48:36 +0200 (Sat, 25 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Passing correct HWND to CreateChromeWindow(). The HWND of the toplevel window
should be passed.

BUG=9191

patch by yusukes@google.com <http://codereview.chromium.org/97011>

------------------------------------------------------------------------
r14502 | estade@chromium.org | 2009-04-25 01:37:06 +0200 (Sat, 25 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/shell_dialogs.h

Gtk file selection filters, first cut.

Review URL: http://codereview.chromium.org/92153
------------------------------------------------------------------------
r14499 | agl@chromium.org | 2009-04-25 01:27:11 +0200 (Sat, 25 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/process_watcher.cc (from /trunk/src/chrome/common/process_watcher_win.cc:14495)
   D /trunk/src/chrome/common/process_watcher_posix.cc
   D /trunk/src/chrome/common/process_watcher_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Revert "POSIX: Don't spawn zombies." (r14488)

Something else is trying to reap children in the ui_tests and causing
a mess. Reverting since it's a Friday night.

------------------------------------------------------------------------
r14492 | jcampan@chromium.org | 2009-04-25 00:39:50 +0200 (Sat, 25 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/views/widget/widget_win.cc

Reverting 14489.
Review URL: http://codereview.chromium.org/99004
------------------------------------------------------------------------
r14489 | jcampan@chromium.org | 2009-04-25 00:11:12 +0200 (Sat, 25 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/views/widget/widget_win.cc

This CL makes sure we unregister our Windows window classes when shut-down.
It also balances-out an OLE initialization performed by the CRichEditCTRL.

This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/93026
------------------------------------------------------------------------
r14488 | agl@chromium.org | 2009-04-25 00:09:58 +0200 (Sat, 25 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.cc
   D /trunk/src/chrome/common/process_watcher.cc
   A /trunk/src/chrome/common/process_watcher_posix.cc
   A /trunk/src/chrome/common/process_watcher_win.cc (from /trunk/src/chrome/common/process_watcher.cc:14487)
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

POSIX: Don't spawn zombies.

TEST=Navigate to several different sites and check that no Chrome zombies are roaming around.
BUG=9401

------------------------------------------------------------------------
r14486 | finnur@chromium.org | 2009-04-25 00:05:35 +0200 (Sat, 25 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc

No code change, just converting CRLF to LF to prevent changes
to this file from messing up the try server.

TBR=aa

Review URL: http://codereview.chromium.org/93156
------------------------------------------------------------------------
r14485 | erg@google.com | 2009-04-25 00:04:28 +0200 (Sat, 25 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc

Fix word wrapping on the license label.

This uses the trick described here:
http://blog.16software.com/dynamic-label-wrapping-in-gtk

Review URL: http://codereview.chromium.org/93153
------------------------------------------------------------------------
r14482 | evan@chromium.org | 2009-04-25 00:02:23 +0200 (Sat, 25 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/process_singleton_win.cc

Fix for minimum size check

cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t)

Review URL: http://codereview.chromium.org/93078
------------------------------------------------------------------------
r14481 | finnur@chromium.org | 2009-04-25 00:02:19 +0200 (Sat, 25 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h

Pass the ExtensionID to the ExtensionFunctionDispatcher.

This is needed for PageActions that deal with IDs, so
that we can check if one PageAction is trying to change
another PageAction. This converts the object 
ExtensionFunctionDispatcher in RenderViewHost from a
member to a scoped ptr so we can reset it on navigate.

BUG=None
TEST=Extensions should work as before (no visible
change).

Review URL: http://codereview.chromium.org/93125
------------------------------------------------------------------------
r14479 | kuchhal@chromium.org | 2009-04-24 23:48:34 +0200 (Fri, 24 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc

Revert "Do not send stats from Chromium builds."
This reverts commit 4a0189db765fe94f5df360c0907a585e26c9f681.

Revert "Fix build break."
This reverts commit eada493cf28975e56395aa3e2d3a0dc267a7f2c7.

Review URL: http://codereview.chromium.org/92162

------------------------------------------------------------------------
r14478 | kuchhal@chromium.org | 2009-04-24 23:37:51 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Fix build break.

BUG=1435533

Review URL: http://codereview.chromium.org/93154

------------------------------------------------------------------------
r14475 | tc@google.com | 2009-04-24 23:22:33 +0200 (Fri, 24 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/common/ipc_message_utils.h

Add a gcc warning if we don't check the results of ReadParam.  Some
of the buildbots noticed that we weren't checking the results when
generating log output.

AGL gets the credit for tracking this down.

Review URL: http://codereview.chromium.org/93126

------------------------------------------------------------------------
r14474 | kuchhal@chromium.org | 2009-04-24 23:22:28 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc

Do not send stats from Chromium builds.

BUG=1435533

Review URL: http://codereview.chromium.org/93109

------------------------------------------------------------------------
r14473 | kuchhal@chromium.org | 2009-04-24 23:16:24 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_win.cc

Make uninstall dialog handle keyboard events (TAB).

BUG=10950

Review URL: http://codereview.chromium.org/93140

------------------------------------------------------------------------
r14471 | paul@chromium.org | 2009-04-24 23:12:11 +0200 (Fri, 24 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc

Implement HTML selects as native Cocoa controls for Chrome.

BUG=8389 (http://crbug.com/8389)

Review URL: http://codereview.chromium.org/57032
------------------------------------------------------------------------
r14470 | pkasting@chromium.org | 2009-04-24 23:07:50 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc

Fix DCHECK when typing certain kinds of input on certain profiles.

This is actually a very old bug that some of my recent changes exposed more widely.  In PromoteOrCreateShorterSuggestion(), we could create a totally bogus search base, which, if added to the history matches, would then break.  In the old code, we'd create this match, but usually not add it to the history match set because we'd already have a What You Typed match; in my new code that's frequently no longer the case.

BUG=10926
Review URL: http://codereview.chromium.org/92154
------------------------------------------------------------------------
r14463 | pkasting@chromium.org | 2009-04-24 22:24:19 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h

The accidental search infobar was almost never appearing.  Fix that regression.  Now we don't rely on the presence of a "what you typed" match in the result set; instead the AutocompleteResult determines the alternate nav URL directly.

To do this I refactored some of the code from the history URL provider over to AutocompleteInput.

BUG=10808
Review URL: http://codereview.chromium.org/92140
------------------------------------------------------------------------
r14462 | erg@google.com | 2009-04-24 22:23:49 +0200 (Fri, 24 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/gtk/about_chrome_dialog.cc
   A /trunk/src/chrome/browser/gtk/about_chrome_dialog.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/chrome.gyp

Create an about dialog for GTK Chromium.

Review URL: http://codereview.chromium.org/93128
------------------------------------------------------------------------
r14449 | deanm@chromium.org | 2009-04-24 20:56:27 +0200 (Fri, 24 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Override GtkTextView's size request width in the Linux Omnibox.

GtkTextView requests enough space to fit all of the text.  It turns out if you
weren't doing something to restrict the window size (like using a tiling
manager) long text in the edit would push the window to fit the text.

Review URL: http://codereview.chromium.org/93127

------------------------------------------------------------------------
r14443 | tc@google.com | 2009-04-24 20:06:05 +0200 (Fri, 24 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_resources.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/theme_resources_util.cc
   A /trunk/src/chrome/browser/theme_resources_util.h
   A /trunk/src/chrome/browser/theme_resources_util_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj
   A /trunk/src/tools/grit/grit/format/resource_map.py
   M /trunk/src/tools/grit/grit/node/include.py
   M /trunk/src/tools/grit/grit/node/misc.py
   M /trunk/src/tools/grit/grit/tool/build.py

First cut at adding a map between strings names and resource ids.

This creates a mapping for all the entries in the
theme_resources.grd file and adds a static method for querying
the mapping.

BUG=10639

Review URL: http://codereview.chromium.org/92085

------------------------------------------------------------------------
r14442 | rohitrao@chromium.org | 2009-04-24 19:51:22 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Removes FindBar cruft from TabContentsViewMac.

TEST=Ran Chromium, clicked around, found something in page.  Nothing seems to
have broken.

Review URL: http://codereview.chromium.org/93124
------------------------------------------------------------------------
r14441 | tc@google.com | 2009-04-24 19:49:42 +0200 (Fri, 24 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/message_box_view.h

Make messages in javascript's alert copyable.

Now, we can copy the message by Ctrl-C.

BUG=5879

Patch by hamaji@google.com via
http://codereview.chromium.org/93112

Review URL: http://codereview.chromium.org/92133

------------------------------------------------------------------------
r14439 | agl@chromium.org | 2009-04-24 19:27:22 +0200 (Fri, 24 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc

Linux: fix root window co-ordinates.

(I screwed up. Thanks to Dean for noticing.)

TBR=tony

http://codereview.chromium.org/92132

------------------------------------------------------------------------
r14438 | darin@chromium.org | 2009-04-24 19:17:45 +0200 (Fri, 24 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webplugin.h
   A /trunk/src/webkit/glue/webplugininfo.h (from /trunk/src/webkit/glue/webplugin.h:14288)
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/webkit.gyp

Chrome side of using WebPluginListBuilder.

I also broke glue/webplugininfo.h out of glue/webplugin.h as part of this
change.  Eventually, glue/webplugin.h will go away and be moved into the WebKit
API, but the structures left in glue/webplugininfo.h need to remain since they
are used extensively throughout Chrome.

BUG=10922
R=dglazkov

Review URL: http://codereview.chromium.org/93116
------------------------------------------------------------------------
r14436 | robertshield@google.com | 2009-04-24 19:05:40 +0200 (Fri, 24 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Adding missing null check in case of missing file version info.

Review URL: http://codereview.chromium.org/88041
------------------------------------------------------------------------
r14435 | arv@chromium.org | 2009-04-24 19:03:05 +0200 (Fri, 24 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Fixes issue where the placeholder text was not shown because there is no DOM
property for the placeholder attribute.

BUG=10940

TEST=Make sure that the search boxes (not Search your history) on the new tab
page has place holder text.

Review URL: http://codereview.chromium.org/92107
------------------------------------------------------------------------
r14433 | brettw@chromium.org | 2009-04-24 19:01:11 +0200 (Fri, 24 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h

Use the NotificationRegistrar for the remaining TAB_CONTENTS_DESTROYED
notifications to see if it can fix a crash.
Review URL: http://codereview.chromium.org/92129
------------------------------------------------------------------------
r14432 | willchan@chromium.org | 2009-04-24 18:59:11 +0200 (Fri, 24 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc

Linux: Stop hitting a DCHECK in GoButtonGtk on shutdown.
Turns out we can get 2 gtk leave events in a row on shutdown, if the cursor is already hovering over the go button.
BUG=10851

Review URL: http://codereview.chromium.org/93055
------------------------------------------------------------------------
r14428 | aa@chromium.org | 2009-04-24 18:41:55 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css

Add CSS to make toolstrip buttons look closer to native ones.

Please refer to this URL to have your mind blown:
http://aaronboodman.com/z_dropbox/whoa/

Review URL: http://codereview.chromium.org/92119
------------------------------------------------------------------------
r14425 | dglazkov@chromium.org | 2009-04-24 17:39:36 +0200 (Fri, 24 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc

Disable TabDraggingTest.Tab1Tab3 due to flakiness.

TBR=ben
BUG=10941
TEST=0

Review URL: http://codereview.chromium.org/93098
------------------------------------------------------------------------
r14424 | rohitrao@chromium.org | 2009-04-24 17:22:31 +0200 (Fri, 24 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_factory.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   M /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   M /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Unittest for FindBarCocoaController.

TEST=The new unittest passes.
BUG=10802
------------------------------------------------------------------------
r14414 | brettw@chromium.org | 2009-04-24 07:16:32 +0200 (Fri, 24 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Kill WebContents by moving the remaining methods to TabContents. WebContents
remains as a shell so I don't have to change all the callers in this CL.
Review URL: http://codereview.chromium.org/92115
------------------------------------------------------------------------
r14412 | brettw@chromium.org | 2009-04-24 05:28:54 +0200 (Fri, 24 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Move another batch of functions for WebContents to TabContents. This also
updates the Dev tools manager to take a TabContents (a pointer was being
passed from the TabContents which made it break).
Review URL: http://codereview.chromium.org/92101
------------------------------------------------------------------------
r14411 | ben@chromium.org | 2009-04-24 05:16:02 +0200 (Fri, 24 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Crude text style rendering in the omnibox 2 popup. I copied most of the DrawString/DrawStringFragment stuff from the old code. I am pretty sure the RTL stuff doesn't actually work, I just copied enough in to get things to compile/work.

Will sort out RTL later once LTR works.

Review URL: http://codereview.chromium.org/93092
------------------------------------------------------------------------
r14409 | thestig@chromium.org | 2009-04-24 04:59:14 +0200 (Fri, 24 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/gfx/text_elider.cc
   M /trunk/src/chrome/common/gfx/text_elider.h
   M /trunk/src/chrome/common/gfx/text_elider_unittest.cc

Remove deprecated file_util::GetFilenameWithoutExtensionFromPath(), also convert ElideFilename() to take a FilePath.
Review URL: http://codereview.chromium.org/92060
------------------------------------------------------------------------
r14407 | agl@chromium.org | 2009-04-24 04:29:29 +0200 (Fri, 24 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: stop popups from flickering

Before, clicking on a select would produce a noticable flicker as it
appeared at the top-left of the screen before moving to the correct
location.

http://codereview.chromium.org/93111

------------------------------------------------------------------------
r14405 | agl@chromium.org | 2009-04-24 03:59:32 +0200 (Fri, 24 Apr 2009) | 23 lines
Changed paths:
   M /trunk/src/base/base.gyp
   A /trunk/src/base/gfx/gtk_native_view_id_manager.cc
   A /trunk/src/base/gfx/gtk_native_view_id_manager.h
   M /trunk/src/base/gfx/native_widget_types.h
   A /trunk/src/base/gfx/native_widget_types_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Linux: use opaque NativeViewIds

Currently we are still passing GtkWidget* into the renderer and
trusting the value on the way out. With this patch we switch to using
opaque values.

These opaque values are handled by a GtkNativeViewIdManger, a
singleton object which maintains the list of currently valid ids and
their current X window ids.

We don't pass the X window ids directly to the renderer because they
are a) guessable and b) possibly variable for a GtkWidget. From a
patch size point of view, the X window isn't current created at the
point where we need it so significant work would be needed to reorder
operations to fix that as well.

This patch also removes the GTK accesses from the BACKGROUND_X11
thread which were a temporary hack.

http://codereview.chromium.org/92110

BUG=9014,9869,10787

------------------------------------------------------------------------
r14402 | tim@chromium.org | 2009-04-24 03:23:58 +0200 (Fri, 24 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Remove unused bits and pieces of #ifdefed code that isn't used.
Review URL: http://codereview.chromium.org/93042
------------------------------------------------------------------------
r14396 | estade@chromium.org | 2009-04-24 02:26:17 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Port and enable most of TabRestoreUITest on linux.

- fill in necessary bits of automation proxy, also mock out some windows-only functions on posix so that the IPC messages don't get completely ignored (so we get NOTIMPLEMENTEDs rather than just hanging when porting future UI tests)
- add IsWindowActive to platform_util

Review URL: http://codereview.chromium.org/93096
------------------------------------------------------------------------
r14385 | jhawkins@chromium.org | 2009-04-24 01:51:27 +0200 (Fri, 24 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Remove a function that is no longer used.
Review URL: http://codereview.chromium.org/97009
------------------------------------------------------------------------
r14379 | thestig@chromium.org | 2009-04-24 01:19:51 +0200 (Fri, 24 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Check for view source mode in DOM UI mode.

BUG=9183
Review URL: http://codereview.chromium.org/67030
------------------------------------------------------------------------
r14378 | aa@chromium.org | 2009-04-24 01:19:14 +0200 (Fri, 24 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Add transparency support to RenderWidgetHostView.

This is used to make the background behind toolstrips 'shine
through' them. It isn't possible to make them really transparent
due to cleartype (cleartype must know the pixels behind the text
to work), so instead we paint the background we want behind the
transparent webview.

Review URL: http://codereview.chromium.org/88076
------------------------------------------------------------------------
r14377 | jam@chromium.org | 2009-04-24 01:16:27 +0200 (Fri, 24 Apr 2009) | 6 lines
Changed paths:
   M /trunk/deps/third_party/WebKit/WebKit/chromium/public/WebKit.h
   M /trunk/deps/third_party/WebKit/WebKit/chromium/src/WebKit.cpp
   M /trunk/src/base/registry.cc
   M /trunk/src/base/registry.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/plugins/plugin_constants_win.h
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc

Allow Flash (and other plugins) to be installed without restarting the browser.  This works by monitoring the MozillaPlugins registry key and reloading the plugin list afterwards.

Note: I'll commit the WebKit change separately, but putting it in this change right now so everything can be reviewed together.

BUG=10574
Review URL: http://codereview.chromium.org/88020
------------------------------------------------------------------------
r14376 | pam@chromium.org | 2009-04-24 01:11:56 +0200 (Fri, 24 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Re-enable all tests. Disable CheckActiveWindow() instead. The sporadic
failures of window_proxy->IsActive() to complete are problematic, but we
should keep other coverage while investigating.

TBR=robertshield

BUG=10916
TEST=covered by buildbot ui_test
Review URL: http://codereview.chromium.org/93094
------------------------------------------------------------------------
r14375 | stoyan@chromium.org | 2009-04-24 01:09:43 +0200 (Fri, 24 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Move Browser implementation of callback interfaces into the private section.
Split TabContentsDelegate and PageNavigator.
Review URL: http://codereview.chromium.org/88063
------------------------------------------------------------------------
r14373 | tc@google.com | 2009-04-24 01:04:50 +0200 (Fri, 24 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Fix a bug caught by Werror on the jaunty bot.  gtk_message_dialog_new
takes a printf style format string.

Review URL: http://codereview.chromium.org/97008

------------------------------------------------------------------------
r14372 | jhawkins@chromium.org | 2009-04-24 01:03:58 +0200 (Fri, 24 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add initial support for dragging tabs in the Linux tab strip.
* Tabs cannot be dragged out of the browser window.
* Most of this logic needs to be refactored into DraggedTabControllerGtk.
Review URL: http://codereview.chromium.org/92028
------------------------------------------------------------------------
r14371 | erg@google.com | 2009-04-24 01:00:17 +0200 (Fri, 24 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   A /trunk/src/chrome/browser/input_window_dialog.h
   A /trunk/src/chrome/browser/input_window_dialog_gtk.cc
   A /trunk/src/chrome/browser/input_window_dialog_win.cc (from /trunk/src/chrome/browser/views/input_window.cc:14358)
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/browser/views/input_window.cc
   D /trunk/src/chrome/browser/views/input_window.h
   M /trunk/src/chrome/chrome.gyp

Adds (non-working) folders and GTK dialogs.

- Folders can be created and edited in the bookmark bar. They
  aren't drop targets nor do they popup a menu with their contents.
- Refactor the input window interface to be platform neutral
  and use that in EditFolderController.

Review URL: http://codereview.chromium.org/87010
------------------------------------------------------------------------
r14369 | estade@chromium.org | 2009-04-24 00:58:05 +0200 (Fri, 24 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Linux: Properly plumb infobar close button event.

BUG=10865

Review URL: http://codereview.chromium.org/92057
------------------------------------------------------------------------
r14368 | estade@chromium.org | 2009-04-24 00:57:54 +0200 (Fri, 24 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

GTK: Don't triple buffer the tab strip.

Review URL: http://codereview.chromium.org/93054
------------------------------------------------------------------------
r14363 | ananta@chromium.org | 2009-04-24 00:55:56 +0200 (Fri, 24 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc

Provide a way for a TabContentsDelegate to take focus when we receive a notification from the
renderer that it is done cycling through the controls on the page.

Review URL: http://codereview.chromium.org/93001
------------------------------------------------------------------------
r14362 | brettw@chromium.org | 2009-04-24 00:55:01 +0200 (Fri, 24 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Move a bunch of functions from WebContents to TabContents. Change the services
used by the getters I moved to take a TabContents instead of a WebContents.
Review URL: http://codereview.chromium.org/96010
------------------------------------------------------------------------
r14348 | robertshield@google.com | 2009-04-23 22:57:45 +0200 (Thu, 23 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Disabling flaky TabRestoreUITest.RestoreToDifferentWindow test.

BUG=http://crbug.com/10916

TBR=http://codereview.chromium.org/92086

Review URL: http://codereview.chromium.org/92086
------------------------------------------------------------------------
r14343 | brettw@chromium.org | 2009-04-23 21:47:19 +0200 (Thu, 23 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/site_instance_unittest.cc

Hopefully fix the leak in the SiteInstance unittest (again). Processing the
pending messages must happen *after* the WebContents is destroyed, since the
messages we're processing are sent from the destructor.
Review URL: http://codereview.chromium.org/93081
------------------------------------------------------------------------
r14341 | estade@chromium.org | 2009-04-23 21:39:49 +0200 (Thu, 23 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Remove outdated comment. No code change.

------------------------------------------------------------------------
r14340 | robertshield@google.com | 2009-04-23 21:28:30 +0200 (Thu, 23 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Disabling TabRestoreUITest, RestoreWindowAndTab unit test as per sporadic failures here:

http://hae14.jail:8010/waterfall?builder=Vista%20Tests%20(dbg)(1)
log: http://hae14.jail:8010/builders/Vista%20Tests%20(dbg)(1)/builds/5460/steps/ui_tests/logs/stdio

BUG=http://code.google.com/p/chromium/issues/detail?id=10916

TBR=http://codereview.chromium.org/92083

Review URL: http://codereview.chromium.org/92083
------------------------------------------------------------------------
r14338 | evan@chromium.org | 2009-04-23 20:43:35 +0200 (Thu, 23 Apr 2009) | 16 lines
Changed paths:
   M /trunk/src/base/string_util_posix.h
   M /trunk/src/base/string_util_win.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/ipc_channel.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/transport_dib.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/npobject_proxy.cc
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.cc
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/npobject_util.cc
   M /trunk/src/chrome/plugin/npobject_util.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/webplugin_impl.cc

linux (and some posix): multiprocess plugins compiling.

The goal of this change is to *not* make any behavioral change, but to
instead just get all the plugin-related files linking on Linux with
a bunch of NOTIMPLEMENTED()s in the appropriate places.  It's enormous
enough already without any refactorings or new features.

Changes include:
 - Lots of gcc warning fixes.
 - Use portable replacements for Windows-specific functions (_strdup, etc.).
 - Use TransportDIB instead of just shared memory in the plugin messaging.
   Note that this is not fleshed out on Linux and on Windows it just hacks
   in the existing handles so there should be no functional change.
 - Fix --plugin-launcher to use cross-platform APIs.

Review URL: http://codereview.chromium.org/79020
------------------------------------------------------------------------
r14336 | mpcomplete@google.com | 2009-04-23 20:37:08 +0200 (Thu, 23 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Arrange so ExtensionMessageService::RendererReady is called on the IO thread.
This fixes a bug where it wouldn't notice when a renderer died because it was
observing the notification on the wrong thread.  This also simplifies some
logic in ExtensionMessageService.
Review URL: http://codereview.chromium.org/88002
------------------------------------------------------------------------
r14335 | stoyan@chromium.org | 2009-04-23 20:24:32 +0200 (Thu, 23 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Allow creating external tab in incognito mode.

Review URL: http://codereview.chromium.org/88051
------------------------------------------------------------------------
r14328 | avi@google.com | 2009-04-23 20:07:51 +0200 (Thu, 23 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/test/chrome_process_util_linux.cc
   M /trunk/src/chrome/test/chrome_process_util_mac.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Create a ChromeProcessUtil for the Mac, and enable it in the tests.

Review URL: http://codereview.chromium.org/95009
------------------------------------------------------------------------
r14315 | sky@chromium.org | 2009-04-23 18:37:58 +0200 (Thu, 23 Apr 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   A /trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

A basic search provider unit test. This tests asserts a handful of things:
. The default/keyword suggest providers are queried appropriately.
. History results are asked for default/keyword providers.

More assertions can be added over time, but we have to start some
where.

This uncovered one bug in SearchProvider, we were never marking the
provider as properly done.

BUG=3636
TEST=none

Review URL: http://codereview.chromium.org/87062
------------------------------------------------------------------------
r14314 | robertshield@google.com | 2009-04-23 18:30:36 +0200 (Thu, 23 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/widget/widget_win.h
   M /trunk/src/chrome/views/window/non_client_view.cc
   M /trunk/src/chrome/views/window/non_client_view.h
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Reverting r14276 (http://codereview.chromium.org/88069) which causes unit test breakage.

Example: http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/1268/steps/unit_tests/logs/stdio

TBR=http://codereview.chromium.org/95010


Review URL: http://codereview.chromium.org/95010
------------------------------------------------------------------------
r14313 | kuchhal@chromium.org | 2009-04-23 18:25:07 +0200 (Thu, 23 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc

Importer should import browser data from the browser that user selected.

BUG=9710

Review URL: http://codereview.chromium.org/93039

------------------------------------------------------------------------
r14309 | sky@chromium.org | 2009-04-23 17:40:03 +0200 (Thu, 23 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/chromium/product_logo_16.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html

Changes closed windows on the new tab page to show the Chromium/Chrome
icon and the text to show the number of closed windows.

BUG=9022
TEST=With more than one window open close a window. Go to the new tab
  page and make sure you see an entry for the closed window. The entry
  should have the chrome/chromium logo and instead of 'Window' it
  should say the number of tabs in the window.

Review URL: http://codereview.chromium.org/92022
------------------------------------------------------------------------
r14305 | rafaelw@chromium.org | 2009-04-23 17:09:58 +0200 (Thu, 23 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc

Refactor index value capture outside of DCHECK to fix build failure in release.

Review URL: http://codereview.chromium.org/93060
------------------------------------------------------------------------
r14301 | pinkerton@chromium.org | 2009-04-23 16:37:32 +0200 (Thu, 23 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h

Allow appkit-driven animations in unit tests to work correctly.
Review URL: http://codereview.chromium.org/95003
------------------------------------------------------------------------
r14291 | levin@chromium.org | 2009-04-23 09:13:31 +0200 (Thu, 23 Apr 2009) | 24 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/WEBKIT_MERGE_REVISION
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/insert-3907422-fix-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-text-015-expected.checksum
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-text-015-expected.png
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-text-015-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/select-all-iframe-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/font-family-with-space-expected.txt
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.checksum
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.png
   A /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.txt
   M /trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/pointer-events-path-expected.txt
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/port/bindings/v8/v8_custom.cpp
   M /trunk/src/webkit/tools/layout_tests/test_expectations.txt

Merge: chromium side [42671:42725]

Rebaselines:

http://trac.webkit.org/changeset/42722 resulted in
  LayoutTests/editing/inserting/insert-3907422-fix.html
  LayoutTests/editing/pasteboard/paste-text-015.html
  LayoutTests/editing/style/font-family-with-space.html


http://trac.webkit.org/changeset/42723 resulted in
  LayoutTests/editing/selection/select-all-iframe.html
  LayoutTests/svg/custom/pointer-events-path.svg

http://trac.webkit.org/changeset/42716 resulted in
  LayoutTests/fast/dom/HTMLSelectElement/named-options.html

http://trac.webkit.org/changeset/42725
Broke the close event behavior and resulted in disabling these ui tests:
 * BrowserCloseBeforeUnloadOK and  
 * BrowserCloseBeforeUnloadCancel


Review URL: http://codereview.chromium.org/92051
------------------------------------------------------------------------
r14290 | jcampan@chromium.org | 2009-04-23 09:09:51 +0200 (Thu, 23 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

In the new tab page, when in edit move, right-clicking on a thumbnail should not trigger its deletion.

BUG=10527
TEST=Open the New Tab Page. Click the "Remove thumbnails" link to enter edit mode. Right-click on a thumbnail. The context menu should be displayed and the thumbnail should not be removed.
Review URL: http://codereview.chromium.org/92018
------------------------------------------------------------------------
r14288 | hbono@chromium.org | 2009-04-23 07:49:47 +0200 (Thu, 23 Apr 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Browser Crash when opening urls with NEW_BACKGROUND_TAB disposition

When that disposition is used and no "normal" window is opened, it crashes.
"normal" means non POPUP, non APPLICATION window type. This happens because
background disposition doens't focus or activate the window unless selected. A
crash happens because GetSelectedTabContents() is null since nothing initially
there.

This fix might have stopped it crash, but would be best to see if its a "good"
approach.

I fixed some lints such as, header file already exists, extra white space, etc)
BUG=10591 ( http://crbug.com/10591 )

Original patch by Mohamed Mansour (see http://codereview.chromium.org/67205/show), r=me,pkasting
Review URL: http://codereview.chromium.org/93058
------------------------------------------------------------------------
r14284 | ben@chromium.org | 2009-04-23 03:36:33 +0200 (Thu, 23 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Move the positioner code into autocompletepopupview.h so that linux can use it too.
Review URL: http://codereview.chromium.org/87007
------------------------------------------------------------------------
r14282 | jrg@chromium.org | 2009-04-23 03:18:13 +0200 (Thu, 23 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/base/test_suite.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.h
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/browser_window_cocoa_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Fix problem with bookmark bar introduced by window sharing; pref
  change needs to change all open windows with the same preferences,
  not just the current one).
Improve unit testing.
Limit bookmark menu size width (1st pass).
Cleanup/delete of code which no longer does much.

Review URL: http://codereview.chromium.org/79068
------------------------------------------------------------------------
r14281 | robertshield@google.com | 2009-04-23 03:16:45 +0200 (Thu, 23 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Revert of http://codereview.chromium.org/87058 which appears to hang the XP Tests.

Log of hanging tests:
http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/1246/steps/unit_tests/logs/stdio

TBR=http://codereview.chromium.org/92055

Review URL: http://codereview.chromium.org/92055
------------------------------------------------------------------------
r14278 | arv@chromium.org | 2009-04-23 02:27:08 +0200 (Thu, 23 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/chrome/browser/resources/about_memory.html
   M /trunk/src/chrome/browser/resources/about_plugins.html
   M /trunk/src/chrome/browser/resources/about_stats.html
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/extensions_ui.html
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html

Some random cleanups in the HTML files.

Use HTML5 placeholder instead of js code for the text input place holders.

Use HTML5 doctype in all html files.

Skip optional type in script and style tags.

Some small optimizations in LocalStrings.


Review URL: http://codereview.chromium.org/88072
------------------------------------------------------------------------
r14276 | pkasting@chromium.org | 2009-04-23 02:08:19 +0200 (Thu, 23 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/widget/widget_win.h
   M /trunk/src/chrome/views/window/non_client_view.cc
   M /trunk/src/chrome/views/window/non_client_view.h
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Don't allow the browser window to be resized so small that layout starts breaking horribly.  When it _is_ small, draw the frame correctly.This is an incomplete fix; only non-Aero main/popup/app windows are handled so far, but this was becoming hairy enough I wanted to checkpoint it.BUG=9885
Review URL: http://codereview.chromium.org/88069
------------------------------------------------------------------------
r14273 | evan@chromium.org | 2009-04-23 01:53:25 +0200 (Thu, 23 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

Don't send resize messages until the renderer has been initialized.

[Retry of 14260 with fixed unit test.]

1) Moves renderer_initialized_ from RenderWidgetView into RenderWidgetHost (its parent).  Should be identical semantics to before.
2) Test renderer_initialized_ in RWH::WasResized().

This also reverts r13725, which was another attempt at fixing this problem.

BUG=9830,10659
TEST=From the Linux start page, click a link then click back -- should not get a gray page.  From Google reader, click a link (which spawns a new tab within the same process) -- should not get a gray page.

Review URL: http://codereview.chromium.org/93038
------------------------------------------------------------------------
r14270 | pkasting@chromium.org | 2009-04-23 01:46:45 +0200 (Thu, 23 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc

Hide the exit bubble when the main window is inactivated, and don't re-show until it's reactivated.

BUG=8945
Review URL: http://codereview.chromium.org/93048
------------------------------------------------------------------------
r14267 | evan@chromium.org | 2009-04-23 01:15:27 +0200 (Thu, 23 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

Revert "Don't send resize messages until the renderer has been initialized."

This reverts commit r14260.
------------------------------------------------------------------------
r14265 | ben@chromium.org | 2009-04-23 01:02:15 +0200 (Thu, 23 Apr 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/gfx/insets.h
   M /trunk/src/chrome/views/controls/button/checkbox.cc
   M /trunk/src/chrome/views/controls/button/checkbox.h
   M /trunk/src/chrome/views/controls/button/radio_button.cc
   M /trunk/src/chrome/views/controls/button/radio_button.h
   M /trunk/src/chrome/views/controls/label.cc
   M /trunk/src/chrome/views/controls/label.h
   M /trunk/src/chrome/views/controls/label_unittest.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/widget/root_view.cc

Fix focus rects for checkboxes and radio buttons:

- add concept of default insets to view which get added to any other insets provided by the user. used by label to provide room for a focus border.
- provide the ability for the label to paint its focus border even if it isn't focused. needed because the outer container (the checkbox) gets focus but the inner label does not, however the label knows best the location of its text around which the focus border must be drawn.

please note:
- also make it easier to click checkboxes by not resetting mouse_pressed_handler_ in RootView when a view decides it doesn't want to handle a drag. this is so we can still receive mousereleased notifications when the mouse is released... it's "difficult" to click checkboxes and radio buttons when you accidentally drag a little on their label. (this is the root view change).

- fix slight alignment issue on the general page of options.


Also fix a slight error in my last radio checkbox - clicking on a checked radio button should still focus it.

http://crbug.com/10834

TEST=visit options, Minor Tweaks. click the "always ask before downloading" checkbox and observe that the focus rect tightly surrounds the text label instead of stretching to the right side of the dialog.
Visit options, click an already-checked radio button. observe that it takes focus.
Visit options, click on any checkbox or radio button, drag slightly then release (still within the bounds of the item). note the item is now toggled or selected. click down then drag out and release, note that it is not toggled or selected.

Review URL: http://codereview.chromium.org/92004
------------------------------------------------------------------------
r14264 | erikkay@google.com | 2009-04-23 01:02:13 +0200 (Thu, 23 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Fix ExtensionView to properly set the size of the RenderWidgetHostView.  Without this, GetClientRect would return a size of 0,0 for the view, which would prevent the tooltip machinery from working properly.
Review URL: http://codereview.chromium.org/87058
------------------------------------------------------------------------
r14260 | evan@chromium.org | 2009-04-23 00:45:44 +0200 (Thu, 23 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

Don't send resize messages until the renderer has been initialized.

1) Moves renderer_initialized_ from RenderWidgetView into RenderWidgetHost (its parent).  Should be identical semantics to before.
2) Test renderer_initialized_ in RWH::WasResized().

This also reverts r13725, which was another attempt at fixing this problem.

BUG=9830,10659
TEST=From the Linux start page, click a link then click back -- should not get a
gray page.  From Google reader, click a link (which spawns a new tab within the
same process) -- should not get a gray page.

Review URL: http://codereview.chromium.org/93038
------------------------------------------------------------------------
r14256 | brettw@chromium.org | 2009-04-23 00:31:42 +0200 (Thu, 23 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/context_menu.h

Always enable copy-link-address in context menu.

Added a new field into ContextMenuParam only for this purpose. The new field
won't be validated in frontend processes. In this way, even if renderer
processes are going to mad, the frontend would be OK if the frontend uses this
new field only for copying into the clipboard.

Fix checked in for Shinichiro Hamaji
Original code review: http://codereview.chromium.org/91002

BUG=2725
------------------------------------------------------------------------
r14255 | rafaelw@chromium.org | 2009-04-23 00:28:45 +0200 (Thu, 23 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/test/TabsAPI/1/tabs_api.html

implement remaining tab events (except for onTabUpdated).


Review URL: http://codereview.chromium.org/88053
------------------------------------------------------------------------
r14253 | brettw@chromium.org | 2009-04-23 00:06:10 +0200 (Thu, 23 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc

Don't delete the DOM UI property for the callback when the DOM UI is torn down.
With my ownership changes, the TabContents owns the RVHManager which owns the
DOMUI. This means that the DOM UI is deleted from ~TabContents and it will
crash during destruction if we access the TabContents to delete the property.

Review URL: http://codereview.chromium.org/92042
------------------------------------------------------------------------
r14252 | shess@chromium.org | 2009-04-22 23:51:53 +0200 (Wed, 22 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Run user_script_master_unittest.cc on Mac.
Removed anonymous namespace, Mac's gcc won't allow friend to reach
into anonymous namespaces.

Noticed that UserScriptMasterTest.NoScripts hanged it DirectoryWatcher
was not implemented.  Added a timeout event so that now it fails
slowly.

Then I disabled that test for non-Windows.  Other tests pass, lets get
those in the system!

Review URL: http://codereview.chromium.org/88075
------------------------------------------------------------------------
r14243 | jianli@chromium.org | 2009-04-22 23:18:00 +0200 (Wed, 22 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_service.cc

Fix an assert caused by trying to add duplicate observers for multiple workers.
Review URL: http://codereview.chromium.org/87072
------------------------------------------------------------------------
r14242 | pam@chromium.org | 2009-04-22 23:04:24 +0200 (Wed, 22 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Weaken is_active check more, since it appears that Chromium can switch to and
from being the frontmost app during the course of a ui_tests run. This way
errors will show up in more carefully controlled local tests, but won't turn
the bots red.

BUG=5278
TEST=make sure TabRestoreUiTest.* don't fail due to is_active being false


Review URL: http://codereview.chromium.org/92038
------------------------------------------------------------------------
r14241 | estade@chromium.org | 2009-04-22 22:45:42 +0200 (Wed, 22 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

Unbreak build.

TBR=pinkerton

Review URL: http://codereview.chromium.org/93037
------------------------------------------------------------------------
r14239 | pinkerton@chromium.org | 2009-04-22 22:38:33 +0200 (Wed, 22 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/base/base_paths_mac.mm
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/chrome.gyp

Enable more tests, change a NOTREACHED to a bug since it's not fatal in the download code. Get other tests compiling even if disabled. Mark why tests are failing in gyp file.
Review URL: http://codereview.chromium.org/92033
------------------------------------------------------------------------
r14237 | estade@chromium.org | 2009-04-22 22:24:06 +0200 (Wed, 22 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Avoid DCHECK in nine box during download shelf animation.

That DCHECK might be a little overzealous, but is probably useful for most situations, so I'm leaving it.

TBR=tony
Review URL: http://codereview.chromium.org/92036
------------------------------------------------------------------------
r14234 | pam@chromium.org | 2009-04-22 22:03:08 +0200 (Wed, 22 Apr 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Restore closed tabs into new windows when necessary, and track the windows they
came from so they're restored together (into the same new window) when
appropriate.

Fix safety check on tab index when restoring: make it check the correct
browser.

Change some ASSERTs to EXPECTs in the unit test for greater coverage.

BUG=5278
TEST=Open a window with two tabs, close both (closing the window), then
  restore both. Make sure both restored tabs are in the same window.  Open
  a window with multiple tabs, close a tab, then close the window using 
  its close box. Restore both and make sure the tab goes back into the window.
Review URL: http://codereview.chromium.org/92001
------------------------------------------------------------------------
r14230 | brettw@chromium.org | 2009-04-22 21:22:57 +0200 (Wed, 22 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Move all data members from WebContents to TabContents in preparation for
merging the two. This is extremely straightforward except for the
GearsCreateShortcutCallbackFunctor which I had to move to the header (with a
TODO and its associated function OnGearsCreateShortcutDone) and some of the
constructors for the members which took a WebContents that I had to cast.

I tried to reorganize the data to have some kind of groupings.

I made the member initializers all explicit for TabContents because the
extreme number of them makes them difficult to keep track of.
Review URL: http://codereview.chromium.org/88021
------------------------------------------------------------------------
r14227 | stoyan@chromium.org | 2009-04-22 21:07:58 +0200 (Wed, 22 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h

Remove unused implementation of TabContentsDelegate in HtmlDialogView.
Review URL: http://codereview.chromium.org/87031
------------------------------------------------------------------------
r14222 | jhawkins@chromium.org | 2009-04-22 20:56:19 +0200 (Wed, 22 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Remove a debugging change that was accidentally added to r14123.

TBR=tony
Review URL: http://codereview.chromium.org/88045
------------------------------------------------------------------------
r14220 | estade@chromium.org | 2009-04-22 20:54:11 +0200 (Wed, 22 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   M /trunk/src/chrome/browser/gtk/slide_animator_gtk.h

Add new item animation to download shelf.

Also, fix duration and tween type for download shelf open animation.

Review URL: http://codereview.chromium.org/88064
------------------------------------------------------------------------
r14212 | pinkerton@chromium.org | 2009-04-22 20:35:10 +0200 (Wed, 22 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/base/base_paths_mac.mm
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/platform_util_mac.mm

Fix DIR_SOURCE_ROOT to work in bundles like Chromium.app. Add more ui tests. Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel).
Review URL: http://codereview.chromium.org/93025
------------------------------------------------------------------------
r14208 | brettw@chromium.org | 2009-04-22 20:06:28 +0200 (Wed, 22 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/site_instance_unittest.cc

Don't leak the RenderProcessHost when running site instance unit tests by
flusing the message queue (containing the delete message).

BUG=10782
Review URL: http://codereview.chromium.org/92023
------------------------------------------------------------------------
r14206 | agl@chromium.org | 2009-04-22 19:56:06 +0200 (Wed, 22 Apr 2009) | 26 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   A /trunk/src/webkit/tools/test_shell/test_shell_x11.cc
   A /trunk/src/webkit/tools/test_shell/test_shell_x11.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/webkit.gyp

Linux: move X operations from the IO to UI2 thread.

(r14075 take two)

Currently we perform several X operations on the IO thread including
geometry and clipboard work. This is causing races inside Xlib and
crashing the browser.

These are the result of synchronous calls from the renderer, so we
cannot route these requests to the UI thread without risking deadlock.
Thus we introduce the UI2 thread. This thread has a second connection
to the X server and can perform X operations safely the without UI
thread.

Work remains to be done:

Since we still have the hack where we pass GtkWidget pointers into the
renderer and back, we still have to access these structures from the
IO and UI2 threads. This still needs to be fixed, but this is not the
patch for it.

Also, not all the X calls from the IO thread have been moved over in
this patch; just a few small ones.

http://codereview.chromium.org/67145

------------------------------------------------------------------------
r14204 | sidchat@google.com | 2009-04-22 19:40:52 +0200 (Wed, 22 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   A /trunk/src/chrome/third_party/hunspell/dictionaries/README_en_AU.txt
   A /trunk/src/chrome/third_party/hunspell/dictionaries/en_AU.aff
   A /trunk/src/chrome/third_party/hunspell/dictionaries/en_AU.dic

Add Australian English spell check support.

Issue=8934
Review URL: http://codereview.chromium.org/89006
------------------------------------------------------------------------
r14202 | avi@chromium.org | 2009-04-22 19:21:40 +0200 (Wed, 22 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Properly construct shell filters (forgetting the asterisk means it works but doesn't show existing files).

BUG=10734

Review URL: http://codereview.chromium.org/93019
------------------------------------------------------------------------
r14187 | apavlov@chromium.org | 2009-04-22 17:13:07 +0200 (Wed, 22 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.cc
   M /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   M /trunk/src/chrome/browser/debugger/devtools_remote.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_message.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_message_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.h
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h


Review URL: http://codereview.chromium.org/87034
------------------------------------------------------------------------
r14179 | hbono@chromium.org | 2009-04-22 07:37:01 +0200 (Wed, 22 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

An experimental fix for Issue 9718.
This change enables the keyboard shortcuts "control + right-shift" and "control + left-shift" only on a PC having RTL languages (i.e. Arabic or Hebrew) installed.

BUG=9718 "Regression: Only use RCtrl + RShift to change directionality if RTL input languages are installed"
Review URL: http://codereview.chromium.org/67296
------------------------------------------------------------------------
r14163 | erg@google.com | 2009-04-22 02:12:29 +0200 (Wed, 22 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_test.cc
   M /trunk/src/chrome/chrome.gyp

Enable BookmarkContextMenuTest under Linux.

Review URL: http://codereview.chromium.org/89011
------------------------------------------------------------------------
r14162 | tc@google.com | 2009-04-22 02:12:15 +0200 (Wed, 22 Apr 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Provide an override for Webview drop effect.

Used for gears file drag & drop in chrome, provide a setter api to override
the default webview drop effect.  If gears overrides the drop_effect, then
either a "copy" or "none" cursor is shown to the user.  Otherwise, the drop
effect shown is the default for the webview (controlled by WebKit).

Also remove a TODO: during drag and drop, remember the drop accept state of
the webview (in drag enter, drag over).  Use that to prevent drops on webviews
that can't accept the drop data.

BUG=7995

Original patch from Noel Gordon via
http://codereview.chromium.org/67297

Review URL: http://codereview.chromium.org/88073

------------------------------------------------------------------------
r14159 | tc@google.com | 2009-04-22 01:49:18 +0200 (Wed, 22 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/uninstall_dialog.cc
   M /trunk/src/chrome/browser/views/uninstall_dialog.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/common/message_box_flags.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/dialog_delegate.cc
   M /trunk/src/chrome/views/window/dialog_delegate.h

Reland r14146 which refactors DialogButton into cross platform
code.  This is the same as the last change except I renamed
class MessageBox to class MessageBoxFlags to avoid conflicting
with the same name in windows.h.

Review URL: http://codereview.chromium.org/87065
------------------------------------------------------------------------
r14158 | xji@chromium.org | 2009-04-22 01:44:02 +0200 (Wed, 22 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/views/controls/text_field.cc

This CL fixes 
issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and 
issue 8686 - RTL: Can't select RTL text from Chrome UI boxes

The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).

The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in  https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605

BUG=6125
BUG=8686

Review URL: http://codereview.chromium.org/86003
------------------------------------------------------------------------
r14156 | pkasting@chromium.org | 2009-04-22 01:33:18 +0200 (Wed, 22 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Better omnibox handling of numeric input.  Now we search based on the user's original input instead of a transformed dotted quad when typing numeric hostnames; this should help noticeably in countries like China where such hostnames ("56.com") are popular.

Original patch by Fumitoshi Ukai (see http://codereview.chromium.org/88011 ), r=me.

BUG=10054
------------------------------------------------------------------------
r14155 | erg@google.com | 2009-04-22 01:20:18 +0200 (Wed, 22 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_gtk.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_win.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/chrome.gyp

Merge BookmarkContextMenuGtk back into BookmarkContextMenu.

Review URL: http://codereview.chromium.org/87038
------------------------------------------------------------------------
r14149 | ben@chromium.org | 2009-04-22 00:44:28 +0200 (Wed, 22 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Reland this change from yesterday. Gets basic text in omnibox2 popup working. Ugly.

------------------------------------------------------------------------
r14148 | evan@chromium.org | 2009-04-22 00:42:29 +0200 (Wed, 22 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

posix: URLFixerUpper would DCHECK on input "/".

Also, add some more tests to cover this case.

Review URL: http://codereview.chromium.org/87048
------------------------------------------------------------------------
r14147 | tc@google.com | 2009-04-22 00:31:47 +0200 (Wed, 22 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/uninstall_dialog.cc
   M /trunk/src/chrome/browser/views/uninstall_dialog.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/common/message_box_flags.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/dialog_delegate.cc
   M /trunk/src/chrome/views/window/dialog_delegate.h

Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"
This reverts commit r14146.

MessageBox is redefined to MessageBoxW by windows.  I need to rename the
class.

Review URL: http://codereview.chromium.org/87064

------------------------------------------------------------------------
r14146 | tc@google.com | 2009-04-22 00:17:33 +0200 (Wed, 22 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   M /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/uninstall_dialog.cc
   M /trunk/src/chrome/browser/views/uninstall_dialog.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/common/message_box_flags.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/dialog_delegate.cc
   M /trunk/src/chrome/views/window/dialog_delegate.h

Refactor DialogDelegate so the DialogButton enum is in cross platform
code.

This is mostly a find & replace in our code to use the new location
of the enum.

I also deleted some GetDialogButtons methods in child classes
because they were identical to the parent version in DialogDelegate.

This will allow more code to be enabled on linux/mac in the
automation provider.

Review URL: http://codereview.chromium.org/88008
------------------------------------------------------------------------
r14141 | sky@chromium.org | 2009-04-21 23:58:45 +0200 (Tue, 21 Apr 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/net/test_url_fetcher_factory.cc
   A /trunk/src/chrome/browser/net/test_url_fetcher_factory.h
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Makes it possible to mock URLFetcher.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/87035
------------------------------------------------------------------------
r14137 | jam@chromium.org | 2009-04-21 23:48:36 +0200 (Tue, 21 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   A /trunk/src/chrome/test/data/npapi/create_instance_in_paint.html
   M /trunk/src/chrome/test/ui/npapi_test_helper.cc
   M /trunk/src/chrome/test/ui/npapi_test_helper.h
   M /trunk/src/chrome/test/ui/npapi_uitest.cc
   M /trunk/src/webkit/glue/plugins/test/npapi_test_plugin.vcproj
   M /trunk/src/webkit/glue/plugins/test/plugin_client.cc
   A /trunk/src/webkit/glue/plugins/test/plugin_create_instance_in_paint.cc
   A /trunk/src/webkit/glue/plugins/test/plugin_create_instance_in_paint.h
   M /trunk/src/webkit/glue/plugins/test/plugin_test.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Fix hang seen in plugin process because plugin creation ended up having to wait on UI thread.  Instead of using sync messages, the plugin hwnd is initially parented to the RenderWidgetHost's HWND.  It's then lazily reparented to an intermediate HWND on the UI thread when it comes time to move it.

BUG=10711
TEST=added regression tests, but testers please confirm plugins on top video sites are placed correctly.
Review URL: http://codereview.chromium.org/67285
------------------------------------------------------------------------
r14136 | avi@google.com | 2009-04-21 23:47:40 +0200 (Tue, 21 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/process_singleton_mac.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Implement (kinda) ProcessSingleton for the Mac.

Review URL: http://codereview.chromium.org/88031
------------------------------------------------------------------------
r14134 | avi@google.com | 2009-04-21 23:43:09 +0200 (Tue, 21 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_init.h

Handle file drops and URL open requests. Along with declaring that we handle the http scheme, this allows Chromium to be set as a default browser for the Mac.

Review URL: http://codereview.chromium.org/87043
------------------------------------------------------------------------
r14133 | estade@chromium.org | 2009-04-21 23:42:55 +0200 (Tue, 21 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Unbreak accelerators, and add ctrl+_ for zoom out.

Review URL: http://codereview.chromium.org/87041
------------------------------------------------------------------------
r14132 | estade@chromium.org | 2009-04-21 23:42:43 +0200 (Tue, 21 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc

GTK: Properly escape download item label markup.

BUG=10766

Review URL: http://codereview.chromium.org/88055
------------------------------------------------------------------------
r14131 | estade@chromium.org | 2009-04-21 23:42:34 +0200 (Tue, 21 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc

Fix a memory leak in the download shelf.

Windows doesn't explicitly delete the DownloadItemView objects because the View destructor deletes child views automatically.

BUG=10739

Review URL: http://codereview.chromium.org/88044
------------------------------------------------------------------------
r14127 | sgk@google.com | 2009-04-21 23:08:57 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc

Fix #include (.h, not .cc).
Review URL: http://codereview.chromium.org/88050
------------------------------------------------------------------------
r14123 | estade@chromium.org | 2009-04-21 20:45:04 +0200 (Tue, 21 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Hook up alt-d on linux.

Also clean up some accelerators.

BUG=10803

Review URL: http://codereview.chromium.org/90008
------------------------------------------------------------------------
r14119 | xji@chromium.org | 2009-04-21 19:27:47 +0200 (Tue, 21 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc

This CL fix issue 2674 - search engine name containing parenthesis is not displayed correctly in Omnibox
NavSuggest drop-down list.

The fix is to adjust the search engine name according to locale direction so that the search engine name containing parenthesis are marked with RLE-PDF to be displayed correctly in RTL UI.

BUG=2674

Review URL: http://codereview.chromium.org/79005
------------------------------------------------------------------------
r14118 | estade@chromium.org | 2009-04-21 19:20:45 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h

I missed this file in my last checkin

------------------------------------------------------------------------
r14116 | estade@chromium.org | 2009-04-21 19:12:53 +0200 (Tue, 21 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/slide_animator_gtk.cc
   A /trunk/src/chrome/browser/gtk/slide_animator_gtk.h
   M /trunk/src/chrome/chrome.gyp

Add open/close animations to infobar, download shelf.

Animations are implemented by packing the native widget structure into a GtkFixed which resizes and moves its contents around based on AnimationDelegate callbacks.

Review URL: http://codereview.chromium.org/88005
------------------------------------------------------------------------
r14115 | jhawkins@chromium.org | 2009-04-21 19:12:21 +0200 (Tue, 21 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Handle a race between the remove tab animation resizing the closing tab and the gtk mouse events.  Fixes a crash where the hover index would become stale before a leave-notify event.

BUG=10776
Review URL: http://codereview.chromium.org/88037
------------------------------------------------------------------------
r14099 | pinkerton@chromium.org | 2009-04-21 17:13:12 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/sad_tab_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Unit test for sad tab view.
Review URL: http://codereview.chromium.org/87028
------------------------------------------------------------------------
r14098 | pinkerton@chromium.org | 2009-04-21 16:24:54 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/tab_cell_unittest.mm
   A /trunk/src/chrome/browser/cocoa/toolbar_button_cell_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Unit tests for button cells we use in the UI.
Review URL: http://codereview.chromium.org/87023
------------------------------------------------------------------------
r14097 | dkegel@google.com | 2009-04-21 16:23:05 +0200 (Tue, 21 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Fix a leak introduced in http://codereview.chromium.org/62061

Fixes valgrind warning
09:57:13 valgrind_analyze.py [ERROR] Leak_DefinitelyLost
1 bytes in 1 blocks are definitely lost in loss record 2 of 260
  operator new(unsigned int) (vg_replace_malloc.c:195)
  FileVersionInfo::CreateFileVersionInfoForCurrentModule() (base/file_version_info_linux.cc:21)
  AutomationProvider::ConnectToChannel(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&) (chrome/browser/automation/automation_provider.cc:811)


Review URL: http://codereview.chromium.org/79087
------------------------------------------------------------------------
r14096 | apavlov@chromium.org | 2009-04-21 16:20:55 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.h
   M /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_remote_service.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h


Review URL: http://codereview.chromium.org/77006
------------------------------------------------------------------------
r14095 | pinkerton@chromium.org | 2009-04-21 15:54:03 +0200 (Tue, 21 Apr 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/cocoa/find_bar_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/grow_box_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/tab_strip_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/tab_view_unittest.mm
   A /trunk/src/chrome/browser/cocoa/toolbar_view_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add a bunch of basic unit tests for view classes.
------------------------------------------------------------------------
r14093 | avi@google.com | 2009-04-21 15:21:15 +0200 (Tue, 21 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Rework the RWHV so that when it gets a paint message from the renderer it immediately paints. Also, implement the fix for updates done for the other platforms in http://codereview.chromium.org/66013 .

Review URL: http://codereview.chromium.org/89001
------------------------------------------------------------------------
r14091 | phajdan.jr@chromium.org | 2009-04-21 10:09:30 +0200 (Tue, 21 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/test/chrome_process_util_linux.cc
   A /trunk/src/chrome/test/chrome_process_util_uitest.cc

More solid detection of browser process in chrome_process_util_linux.cc:

- use GetAppOutput instead of popen
- make unexpected conditions fatal (otherwise the tests using this code
  would mistakenly assume that there is no running browser process)

Also add a constant for SingletonSocket.

Make necessary adjustments to GetAppOutput - ignore stderr (because fuser
prints the file name to stderr and having stderr in |output| would
require more parsing).

Review URL: http://codereview.chromium.org/77031
------------------------------------------------------------------------
r14086 | brettw@chromium.org | 2009-04-21 05:28:32 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Rename web_contents_view to tab_contents_view to fix the mac build.
Review URL: http://codereview.chromium.org/88019
------------------------------------------------------------------------
r14084 | brettw@chromium.org | 2009-04-21 05:21:51 +0200 (Tue, 21 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

Fix a leak of the NavigationController during many tests. A duplicate
NavigationController was begin created from when we had to create this
separately.

BUG=10781
Review URL: http://codereview.chromium.org/88018
------------------------------------------------------------------------
r14083 | brettw@chromium.org | 2009-04-21 04:37:45 +0200 (Tue, 21 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view.cc (from /trunk/src/chrome/browser/tab_contents/web_contents_view.cc:14063)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view.h (from /trunk/src/chrome/browser/tab_contents/web_contents_view.h:14063)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc (from /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc:14063)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h (from /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h:14063)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h (from /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h:14063)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm (from /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm:14063)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc (from /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc:14063)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_view_win.h (from /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h:14063)
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   D /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   D /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   D /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   D /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   D /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   D /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   D /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   D /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp

Rename web_contents_view* files to tab_contents_view* to reflect my previous
rename of the classes.
Review URL: http://codereview.chromium.org/87009
------------------------------------------------------------------------
r14080 | agl@chromium.org | 2009-04-21 03:48:32 +0200 (Tue, 21 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/webkit/webkit.gyp

I managed to break test_shell. Reverting. I'll fix tomorrow.

Reverts r14075

------------------------------------------------------------------------
r14075 | agl@chromium.org | 2009-04-21 03:12:09 +0200 (Tue, 21 Apr 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/webkit/webkit.gyp

Linux: move X operations from the IO to UI2 thread.

Currently we perform several X operations on the IO thread including
geometry and clipboard work. This is causing races inside Xlib and
crashing the browser.

These are the result of synchronous calls from the renderer, so we
cannot route these requests to the UI thread without risking deadlock.
Thus we introduce the UI2 thread. This thread has a second connection
to the X server and can perform X operations safely the without UI
thread.

Work remains to be done:

Since we still have the hack where we pass GtkWidget pointers into the
renderer and back, we still have to access these structures from the
IO and UI2 threads. This still needs to be fixed, but this is not the
patch for it.

Also, not all the X calls from the IO thread have been moved over in
this patch; just a few small ones.

http://codereview.chromium.org/67145

------------------------------------------------------------------------
r14068 | pam@chromium.org | 2009-04-21 01:14:18 +0200 (Tue, 21 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Disable check for active window when it doesn't look like Chromium is the front
app. This should fix the buildbots but still allow a manual test.

TBR=erikkay

BUG=5278
TEST=run ui_tests with another app at the front. Make sure TabRestoreUITest.*
    pass with no "is_active" failures.

Review URL: http://codereview.chromium.org/88012
------------------------------------------------------------------------
r14067 | ben@chromium.org | 2009-04-21 00:23:48 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

Roll back this change until I can understand why it's having adverse effects.

------------------------------------------------------------------------
r14066 | jhawkins@chromium.org | 2009-04-21 00:12:40 +0200 (Tue, 21 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Make sure to free any remaining tabs on tabstrip destruction.  There are two cases where the remove tab animation is not used when closing tabs, and we were leaking these tabs in those cases.
Review URL: http://codereview.chromium.org/87004
------------------------------------------------------------------------
r14065 | evan@chromium.org | 2009-04-21 00:10:02 +0200 (Tue, 21 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/plugin_process_host.cc

posix: port PrependCommand to Windows and use for the plugin launcher.

Review URL: http://codereview.chromium.org/88006
------------------------------------------------------------------------
r14063 | brettw@chromium.org | 2009-04-21 00:05:12 +0200 (Tue, 21 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Rename WebContentsView* to TabContentsView* in preparation for merging
TabContents and WebContents.

This also removes the Destroy method from the print manager's header file. I
removed the impl in a previous change but forgot the header.
Review URL: http://codereview.chromium.org/90004
------------------------------------------------------------------------
r14062 | pam@chromium.org | 2009-04-21 00:01:03 +0200 (Tue, 21 Apr 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

When restoring a closed tab using either ctrl-shift-T or the context menu, put
it back into the window it came from, at the tabstrip index it occupied before,
and activate (select) both the window and the tab.

Restoring a tab from the New Tab Page replaces the NTP, as before.

If the window the tab was in no longer exists, put the tab at the end of the
current window's tabstrip. This behavior may change in a later patch.

BUG=5278
TEST=Open two windows, with >1 tabs each. Close a tab, not the one at the end,
  in one of the windows. Switch to the other window and choose "Undo Closed
  Tab" from the tabstrip context menu, or type ctrl-shift-T. The tab should
  be restored where it was, and activated (selected and brought to the front).
Review URL: http://codereview.chromium.org/69015
------------------------------------------------------------------------
r14060 | ben@chromium.org | 2009-04-20 23:53:00 +0200 (Mon, 20 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h

First round of getting text into the omnibox2 popup. Looks ugly and has no bolding.

Review URL: http://codereview.chromium.org/89005
------------------------------------------------------------------------
r14054 | pkasting@chromium.org | 2009-04-20 21:56:55 +0200 (Mon, 20 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Only create a What You Typed match when it's likely to be relevant.  See bug for detailed algorithm.I elected to go the simple route of just not constructing a match for non-inline-autocompleting "UNKNOWN" inputs.  The win from the "force this to appear" proposal just doesn't seem to justify the code complexity and lost popup slot.BUG=4037
Review URL: http://codereview.chromium.org/79062
------------------------------------------------------------------------
r14053 | brettw@chromium.org | 2009-04-20 21:55:57 +0200 (Mon, 20 Apr 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Re-land my change to clean up TabContents/WebContents ownership. This
is the same except in tab_strip_model_unittest I fixed a leak by making a
WebContents on the stack, I added a factory to the SiteInstance unittest to
prevent another leak, and I re-added a NULL set to the external_tab_container.

Fix the ownership model of TabContents and NavigationController. Previously the
NavigationController owned the TabContents, and there were extra steps required
at creation and destruction to clean everything up properly.

NavigationController is now a member of TabContents, and there is no setup or
tear down necessary other than the constructor and destructor. I could remove
the tab contents creation in the NavigationController, as well as all the
weird destruction code in WebContents which got moved to the destructor.

I made the controller getter return a reference since the ownership is clear
and there is no possibility of NULL. This required changing a lot of tiles, but
many of them were simplified since they no longer have to NULL check.
Previous review URL: http://codereview.chromium.org/69043

Review URL: http://codereview.chromium.org/67294
------------------------------------------------------------------------
r14047 | pinkerton@chromium.org | 2009-04-20 21:14:36 +0200 (Mon, 20 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm

Test forcing the display of the controller's view.
Review URL: http://codereview.chromium.org/86002
------------------------------------------------------------------------
r14042 | pkasting@chromium.org | 2009-04-20 20:51:07 +0200 (Mon, 20 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h

Trivial cleanup of a recently added function:
* Make const
* Move to be with other function (not variables) in header
* Move in C++ file to match order in header
Review URL: http://codereview.chromium.org/67274
------------------------------------------------------------------------
r14040 | willchan@chromium.org | 2009-04-20 20:39:08 +0200 (Mon, 20 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/field_trial.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/net/http/http_network_transaction.cc

Add a FieldTrial and histograms for measuring impact of http prioritization.
Currently this FieldTrial is measuring the transaction latencies of requests, separated into frame/subframe requests vs subresource requests.  We run a 2% holdback experiment where the people in the holdback don't have http prioritization enabled.  Add class static method to ResourceDispatcherHost to disable http prioritization.
BUG=10486

Review URL: http://codereview.chromium.org/67119
------------------------------------------------------------------------
r14036 | deanm@chromium.org | 2009-04-20 19:22:18 +0200 (Mon, 20 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Better alignment of the omnibox edit entry.

- Let the GtkTextView size itself naturally.  Have the AutocompleteEditViewGtk
  keep the GtkTextView vertically aligned (inside of a GtkAlignment).  The
  non-used space of the alignment is "transparent" by virtue of the alignment
  not having a window, so the LocationBarView will paint the background.
- Move the background color code to the location bar, and have the location
  custom paint the border and background color.

Review URL: http://codereview.chromium.org/67263

------------------------------------------------------------------------
r14031 | pkasting@chromium.org | 2009-04-20 18:47:46 +0200 (Mon, 20 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/base/gfx/point.cc
   M /trunk/src/base/gfx/point.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h

Hide the Fullscreen exit bubble if the mouse goes idle.  It took a depressing amount of time for me to think my way through this algorithm :(

Along the way I added an operator=() to convert from POINT to gfx::Point() since doing explicit temp conversion for a case like this annoys me.

BUG=10568
Review URL: http://codereview.chromium.org/67265
------------------------------------------------------------------------
r14030 | pinkerton@chromium.org | 2009-04-20 18:32:57 +0200 (Mon, 20 Apr 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/base_view_unittest.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/chrome.gyp

Add a unit test for BaseView. Add a helper to get the contentView more easily.
Review URL: http://codereview.chromium.org/82001
------------------------------------------------------------------------
r14025 | ananta@chromium.org | 2009-04-20 07:39:33 +0200 (Mon, 20 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Make sure that the window is repositioned and if applicable visible before reparenting it.

This is to workaround a strange behavior in Windows, where if the parent window is from
a different thread and the window becomes visible after reparenting it, the thread inputs
are not attached correctly causing focus and other issues.


Review URL: http://codereview.chromium.org/67292
------------------------------------------------------------------------
r14006 | brettw@chromium.org | 2009-04-18 21:52:40 +0200 (Sat, 18 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Reverting 14005.
------------------------------------------------------------------------
r14005 | brettw@chromium.org | 2009-04-18 20:09:36 +0200 (Sat, 18 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/ui_test_utils.cc

Fix the ownership model of TabContents and NavigationController. Previously the
NavigationController owned the TabContents, and there were extra steps required
at creation and destruction to clean everything up properly.

NavigationController is now a member of TabContents, and there is no setup or
tear down necessary other than the constructor and destructor. I could remove
the tab contents creation in the NavigationController, as well as all the
weird destruction code in WebContents which got moved to the destructor.

I made the controller getter return a reference since the ownership is clear
and there is no possibility of NULL. This required changing a lot of tiles, but
many of them were simplified since they no longer have to NULL check.
Review URL: http://codereview.chromium.org/69043
------------------------------------------------------------------------
r13981 | paulg@google.com | 2009-04-18 01:31:45 +0200 (Sat, 18 Apr 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/safe_browsing/filter_false_positive_perftest.cc
   A /trunk/src/chrome/test/data/safe_browsing/filter
   A /trunk/src/chrome/test/data/safe_browsing/filter/database
   A /trunk/src/chrome/test/data/safe_browsing/filter/urls
   M /trunk/src/chrome/test/perf/perftests.vcproj

Create a test program for generating false positive statistics
for SafeBrowsing data.

The program reads a regular SafeBrowsing database and creates
bloom filters of various sizes, comparing the hit and miss
statistics against a list of URLs.

BUG=10584 (http://crbug.com/10584)

Review URL: http://codereview.chromium.org/67245
------------------------------------------------------------------------
r13977 | erikkay@google.com | 2009-04-18 01:09:10 +0200 (Sat, 18 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc
   A /trunk/src/chrome/browser/extensions/extension_bookmarks_module.h
   M /trunk/src/chrome/browser/extensions/extension_function.cc
   M /trunk/src/chrome/browser/extensions/extension_function.h
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/bookmarks
   A /trunk/src/chrome/test/data/extensions/bookmarks/bookmark_api.html
   A /trunk/src/chrome/test/data/extensions/bookmarks/bookmark_view.html
   A /trunk/src/chrome/test/data/extensions/bookmarks/manifest.json

A subset of the bookmarks API- missing events- missing unit tests- missing ability to change URL
Review URL: http://codereview.chromium.org/77003
------------------------------------------------------------------------
r13970 | mbelshe@google.com | 2009-04-17 23:53:58 +0200 (Fri, 17 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_started_animation.h

Due to some crashes in teardown, change NotificationObservers
for TAB_CONTENTS_DESTROYED to use the NotificationRegistrar 
to ensure proper cleanup.


Review URL: http://codereview.chromium.org/79051
------------------------------------------------------------------------
r13969 | rohitrao@chromium.org | 2009-04-17 23:39:09 +0200 (Fri, 17 Apr 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/FindBar.xib
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window_factory.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_bridge.h
   A /trunk/src/chrome/browser/cocoa/find_bar_bridge.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.h
   A /trunk/src/chrome/browser/cocoa/find_bar_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/find_bar_view.h
   A /trunk/src/chrome/browser/cocoa/find_bar_view.mm
   M /trunk/src/chrome/chrome.gyp

Initial implementation of the FindBar on Mac.
------------------------------------------------------------------------
r13967 | ben@chromium.org | 2009-04-17 23:15:30 +0200 (Fri, 17 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/browser/views/toolbar_view.h

Move the implementation of AutocompletePopupView from AutocompletePopupWin to AutocompletePopupContentsView, a more central location.

Review URL: http://codereview.chromium.org/77012
------------------------------------------------------------------------
r13963 | pinkerton@chromium.org | 2009-04-17 22:21:21 +0200 (Fri, 17 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Remove a hack that's no longer needed.
Review URL: http://codereview.chromium.org/79050
------------------------------------------------------------------------
r13961 | brg@chromium.com | 2009-04-17 22:19:16 +0200 (Fri, 17 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Valgrind reports memory leak in unit test.  This is true since we had re-used the XmlReader object for each test.  This CL changes this to use a new XmlReader object per test.
Review URL: http://codereview.chromium.org/79049
------------------------------------------------------------------------
r13960 | avi@chromium.org | 2009-04-17 21:57:24 +0200 (Fri, 17 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Fixes saving files that don't have valid extensions.

Two fixes here. First was a disturbing discovery that FilePath::Extension returns an extension starting with a period. I am of the belief that this is the wrong API to expose, but that's a different fight. Fixed.

Second is a subtle behavior of the old code that wasn't preserved. In the case where the extension did not exist in the registry, the old code dropped the extension from the filter. We now also do so.

BUG=10561

Review URL: http://codereview.chromium.org/79045
------------------------------------------------------------------------
r13959 | pinkerton@chromium.org | 2009-04-17 21:52:40 +0200 (Fri, 17 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   A /trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Implement a unit test for the toolbar controller. Plumb the profile into the loation bar instead of picking it up globally, which cannnot be unit tested.
Review URL: http://codereview.chromium.org/79041
------------------------------------------------------------------------
r13958 | paulg@google.com | 2009-04-17 21:51:40 +0200 (Fri, 17 Apr 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Reduce the false positive rate for SafeBrowsing gethash requests.

This CL increases the memory consumption of the bloom filter used
by the SafeBrowsing system in order to decrease the number of false
positive gethash requests (gethash requests that result in an empty
or 204 response from the servers).

The filter size in bytes is calculated as:
  number_of_add_prefixes * bits_per_prefix / 8

From analysis of our histograms, users have between 250k - 330k add
prefixes. 'bits_per_prefix' is hard coded to 25, which means that we
expect the typical bloom filter to be between 760-1000 kB, compared
to the current value of approximately 450 kB.

We add histograms to track the filter size, as well as the number of
gethash requests that return empty results and non-empty results.

BUG=10584 (http://crbug.com/10584)

Review URL: http://codereview.chromium.org/67243
------------------------------------------------------------------------
r13956 | scherkus@chromium.org | 2009-04-17 21:29:41 +0200 (Fri, 17 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer.h

Fix break due to disabling Toolbar5Importer test.

Review URL: http://codereview.chromium.org/69044
------------------------------------------------------------------------
r13955 | scherkus@chromium.org | 2009-04-17 21:15:29 +0200 (Fri, 17 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Disabled Toolbar5ImporterTest.BookmarkParse due to failing valgrind/purify tests.

BUG=10679

Review URL: http://codereview.chromium.org/79048
------------------------------------------------------------------------
r13945 | finnur@chromium.org | 2009-04-17 19:00:12 +0200 (Fri, 17 Apr 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   A /trunk/src/chrome/test/data/find_in_page/end_state.html
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/webkit/glue/webframe_impl.cc

Fix 10573: Dismissing Find-in page doesn't set focus
to the link found.

We no longer use the selection controller to
highlight the active match. Before this change,
the focus would not be set if the user had changed
the selection. After this change, the focus will
be set unless the user has selected something on
the page.

I also wrote an in-browser unit test for this to
catch this regression in the future, but it is
disabled due to problem with running multiple
in-process browser tests in a row (teardown
problem).

BUG=10573
TEST=Covered by in process browser test now, see
bug for repro steps.

Review URL: http://codereview.chromium.org/79024
------------------------------------------------------------------------
r13942 | tc@google.com | 2009-04-17 18:36:09 +0200 (Fri, 17 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.h

Add a comment explaining the ownership model between AppModalDialog
and the NativeDialog.

Review URL: http://codereview.chromium.org/77034

------------------------------------------------------------------------
r13941 | tc@google.com | 2009-04-17 18:34:50 +0200 (Fri, 17 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Refactor NineBox to take 9 image ids instead of having to create
the GdkPixbuf array and passing it into the constructor.  This allows
us to remove some resource_bundle.h includes.

Clean up the style in gtk_chrome_button.cc.  There was some C style
and moved the globals to just static pointers.  I verified with
a debugger that we call gtk_chrome_button_class_init only once.

Review URL: http://codereview.chromium.org/69025

------------------------------------------------------------------------
r13938 | glen@chromium.org | 2009-04-17 17:51:22 +0200 (Fri, 17 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

EscapeQueryParamValue differs from encodeURIComponent in that it doesn't escape spaces, so we have to do some manual fiddling to make searches that have come from the New Tab Page work (see GetHistoryURLWithSearchText).

BUG=9940
TEST=Verify that searches from the new tab page and from the history page result in the same search query appearing in the history results page.

Review URL: http://codereview.chromium.org/67249
------------------------------------------------------------------------
r13937 | glen@chromium.org | 2009-04-17 17:50:31 +0200 (Fri, 17 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc

History observer was observing the wrong profile in incognito mode.

BUG=9984
TEST=Open two history tabs, one inside an incognito window. Delete a day's history in each and observe that the changes are reflected in the other.

Review URL: http://codereview.chromium.org/67250
------------------------------------------------------------------------
r13932 | pinkerton@chromium.org | 2009-04-17 16:32:01 +0200 (Fri, 17 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_mac.mm

Delete dialog after calling completion routines.
Review URL: http://codereview.chromium.org/69037
------------------------------------------------------------------------
r13931 | sky@chromium.org | 2009-04-17 16:19:41 +0200 (Fri, 17 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h

Makes SupportsFeature virtual and adds a virtual destructor to Browser.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/69022
------------------------------------------------------------------------
r13926 | kuchhal@chromium.org | 2009-04-17 15:24:57 +0200 (Fri, 17 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   A /trunk/src/chrome/browser/views/uninstall_dialog.cc
   A /trunk/src/chrome/browser/views/uninstall_dialog.h
   M /trunk/src/chrome/common/result_codes.h
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/util_constants.h

On uninstall ask whether to delete profile.

BUG=8431

Review URL: http://codereview.chromium.org/62097

------------------------------------------------------------------------
r13919 | rafaelw@chromium.org | 2009-04-17 06:55:08 +0200 (Fri, 17 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/test/data/extensions/test/TabsAPI/1/tabs_api.html

added windows.getWindows() and tabs.moveTab()

Review URL: http://codereview.chromium.org/79026
------------------------------------------------------------------------
r13915 | brettw@chromium.org | 2009-04-17 04:07:42 +0200 (Fri, 17 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc

Remove overlap between TabContents and WebContents. Now all the functions in
TabContents are either pure virtual and implemented in WebContnets, or are
non-virtual. This makes it possible to merge the classes by a union operation.
Review URL: http://codereview.chromium.org/66057
------------------------------------------------------------------------
r13908 | pkasting@chromium.org | 2009-04-17 02:24:43 +0200 (Fri, 17 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/widget/widget_win.h
   M /trunk/src/chrome/views/window/window.h
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/chrome/views/window/window_win.h

Reorganize fullscreen mode handling.  Now nearly everything is in WindowWin.  This also includes work area change notifications, which only really apply to Windows (and not pure Widgets) anyway.  Some parts (namely, the browser-specific things) are still in BrowserView.This allows me to fix the bug where unlocking your screen resized fullscreen mode windows incorrectly.There are probably one or two other small bits tangled in here -- this got a bit messy.  I moved the exit bubble out of browser/ because it wasn't browser-specific; in theory, any WindowWin can now go into fullscreen mode.BUG=8159
Review URL: http://codereview.chromium.org/78002
------------------------------------------------------------------------
r13901 | ben@chromium.org | 2009-04-17 01:39:09 +0200 (Fri, 17 Apr 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
   A /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj

Split out the contents view into its own header. rename it to AutocompletePopupContentsView from AutocompletePopupViewContents too.

No other changes.

Review URL: http://codereview.chromium.org/79032
------------------------------------------------------------------------
r13898 | jhawkins@chromium.org | 2009-04-17 01:18:35 +0200 (Fri, 17 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Make sure to delete the tab when we remove it from the tab strip.  Also removes a call to Layout that should be removed now that we have RemoveTabAnimation.
Review URL: http://codereview.chromium.org/79029
------------------------------------------------------------------------
r13897 | ben@chromium.org | 2009-04-17 01:18:15 +0200 (Fri, 17 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h

Start creating results rows, making sure their visual representation is clipped by the containing popup's roundrect. No text yet, though they seem to actually work when clicked on.

This is not the final construction I'd like, but I'm checkpointing here before the changelist gets any bigger.

In the end, I'm thinking AutocompletePopupView will end up being implemented by the popup's contents view rather than the popup itself. I want to do this because the popup, the contents view and the individual result item views need access to the model and as it stands I need to wire model data methods all the way from the result view up to the popup which is annoying. But for now, I have some of that wiring. I'll do this adjustment after this one, since it requires creating some new files.

Review URL: http://codereview.chromium.org/79023
------------------------------------------------------------------------
r13895 | brg@chromium.com | 2009-04-17 00:59:02 +0200 (Fri, 17 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   A /trunk/src/chrome/browser/importer/toolbar_importer.cc
   A /trunk/src/chrome/browser/importer/toolbar_importer.h
   A /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Re-introducing the toolbar importer code.This is the same code that was removed in CL http://codereview.chromium.org/18550.The UI will be reworked in a CL immediately following review/submission of this code.Please contact Nick Baum for information regarding this change.
Review URL: http://codereview.chromium.org/66065
------------------------------------------------------------------------
r13892 | brettw@chromium.org | 2009-04-17 00:39:59 +0200 (Fri, 17 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   A /trunk/src/chrome/browser/tab_contents/render_view_host_manager_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Fix the process creation problem. This forces transitions between
BrowsingInstances when we force a transition for DOM UIs.

BUG=9364
TEST=see bug
Review URL: http://codereview.chromium.org/67201
------------------------------------------------------------------------
r13891 | jhawkins@chromium.org | 2009-04-17 00:36:57 +0200 (Fri, 17 Apr 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/gtk/tabs/tab_button_gtk.cc
   A /trunk/src/chrome/browser/gtk/tabs/tab_button_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/chrome.gyp

Refactor the tab button logic into TabButtonGtk.
* Modify the tabstrip input handling to match the new interface.
Review URL: http://codereview.chromium.org/79025
------------------------------------------------------------------------
r13890 | sky@chromium.org | 2009-04-17 00:33:41 +0200 (Fri, 17 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h

Make Browser::set_window defined all the time, and adds the ability to
set the non client frame view.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/67236
------------------------------------------------------------------------
r13888 | xji@chromium.org | 2009-04-17 00:28:35 +0200 (Fri, 17 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc

This CL fixes issue 5729 - RTL: TabStrip context menu should be positioned properly, If window is not maxmized.
(http://crbug.com/5729).

The fix is to popup tabstrip context menu from the left of the click in RTL UI.

Without the fix, tabstrip context menu always popup from the right of the click.
Review URL: http://codereview.chromium.org/73021
------------------------------------------------------------------------
r13887 | mpcomplete@google.com | 2009-04-17 00:27:21 +0200 (Fri, 17 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   D /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   D /trunk/src/chrome/browser/extensions/extension_process_manager.h
   D /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Remove ExtensionProcessManager and move its functionality onto
ExtensionsService.

Also add "chrome-extension" to the list of schemes that BrowsingInstance
groups per-site, instead of per-tab.  This means that navigating to an
extension URL will use the same process as a running extension toolstrip.
Review URL: http://codereview.chromium.org/77002
------------------------------------------------------------------------
r13877 | michaeln@google.com | 2009-04-16 23:05:47 +0200 (Thu, 16 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_manager.cc
   M /trunk/src/net/url_request/url_request_job_manager.h
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_test_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc

URLRequest::Interceptor enhancements1) Allow an interceptor to change its mind and not intercept after all. This allows the decision to start or not to start to be made asynchronously.2) Allow an interceptor to intercept on error conditions if the original job fails. This is to support the FALLBACK semantics in the appcache.Info about where this is going can be found in the appcache design doc at https://docs.google.com/a/google.com/Doc?docid=agv6ghfsqr_15f749cgt3&hl=enI still have to put together test cases, so I'm not ready to submit this yet, but wanted to get some feedback at this point. 
Review URL: http://codereview.chromium.org/67019
------------------------------------------------------------------------
r13869 | pinkerton@chromium.org | 2009-04-16 21:39:42 +0200 (Thu, 16 Apr 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/app_modal_dialog_mac.mm
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/chrome.gyp

Implement app modal dialogs on mac.
Review URL: http://codereview.chromium.org/79012
------------------------------------------------------------------------
r13859 | pinkerton@chromium.org | 2009-04-16 20:25:18 +0200 (Thu, 16 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   A /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add a test helper to pull out some common code. Add a test for tab controller. Don't dead-strip un-referenced objective-C code in the unit_test target. Use the appropriate bundle when loading the tab nib. (take two, most of this was backed out earlier).
Review URL: http://codereview.chromium.org/77004
------------------------------------------------------------------------
r13857 | erg@google.com | 2009-04-16 20:19:17 +0200 (Thu, 16 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/gtk_util.cc (from /trunk/src/base/gfx/gtk_util.cc:13853)
   A /trunk/src/chrome/common/gtk_util.h
   M /trunk/src/chrome/common/resource_bundle_linux.cc

Recommit previous change with GYP files fixed.

Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements.
Also:
- Fixes window dispositions (shift-click works on bookmark bar items).
- Reorganizes gtk_utils

Original Review URL: http://codereview.chromium.org/76002

Review URL: http://codereview.chromium.org/67223
------------------------------------------------------------------------
r13852 | thestig@chromium.org | 2009-04-16 19:47:34 +0200 (Thu, 16 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Remove deprecated version of UITest::DieFileDie().
Review URL: http://codereview.chromium.org/75008
------------------------------------------------------------------------
r13851 | amit@chromium.org | 2009-04-16 19:45:37 +0200 (Thu, 16 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Add a new notification for automation customers that the 
external tab has finished loading. Unfortunately we cannot
reuse AutomationMsg_InitialLoadsComplete because it has
overloaded meaning.

Review URL: http://codereview.chromium.org/69018
------------------------------------------------------------------------
r13847 | tc@google.com | 2009-04-16 18:52:36 +0200 (Thu, 16 Apr 2009) | 14 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/common/resource_bundle.h
   M /trunk/src/chrome/common/resource_bundle_linux.cc

Have ResourceBundle own GdkPixbufs.

This is the same as how ResourceBundle owns the SkBitmaps it loads.
This should be faster than before because ResourceBundle will only
load each bitmap once and cache the image.

Also fix a memory leak in GdkPixbufFromSkBitmap.

valgrind says we're not leaking here.

BUG=9988

Review URL: http://codereview.chromium.org/67179

------------------------------------------------------------------------
r13845 | deanm@chromium.org | 2009-04-16 18:25:52 +0200 (Thu, 16 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h

Bold matched portions of text in Linux Omnibox.

- Refactor a bunch of the Pango attributes code.
- Walk the classifications, and create the pango attributes for
  the text foreground color and weight (bolding).
- Cache the GdkGC and PangoLayout across expose messages.

Review URL: http://codereview.chromium.org/75041

------------------------------------------------------------------------
r13843 | sky@chromium.org | 2009-04-16 18:13:14 +0200 (Thu, 16 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/common/notification_type.h

Adds notification for when info bubble is created.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/75022
------------------------------------------------------------------------
r13840 | awalker@google.com | 2009-04-16 17:30:46 +0200 (Thu, 16 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/build/common.gypi
   D /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   D /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Reverting 13839,13838.
Review URL: http://codereview.chromium.org/67220
------------------------------------------------------------------------
r13839 | pinkerton@chromium.org | 2009-04-16 17:07:37 +0200 (Thu, 16 Apr 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/cocoa/cocoa_test_helper.h
   A /trunk/src/chrome/browser/cocoa/tab_controller_unittest.mm

Add a helper, and add the test file that broke the build.
------------------------------------------------------------------------
r13838 | pinkerton@chromium.org | 2009-04-16 16:42:13 +0200 (Thu, 16 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/chrome.gyp

Allow unit_tests (and other non-bundle executables) to rely on objectiveC that's
not directly referenced (such as only in a nib file). Add test for tab
controller.
------------------------------------------------------------------------
r13835 | deanm@chromium.org | 2009-04-16 14:20:03 +0200 (Thu, 16 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

More Linux Omnibox v2 work, based on feedback from Cole.

- Don't let the content push the description out of the results.
- Paint URLs green and other results (suggestions) black.
- Use a darker gray for the description and drop the bolding, when the
  description is selected, use a preblended color against the background.
- Move to using Pango attributes instead of markup.  This is more code, but a
  better step towards bolding the matched portions of results.

Review URL: http://codereview.chromium.org/67176

------------------------------------------------------------------------
r13827 | brettw@chromium.org | 2009-04-16 06:56:36 +0200 (Thu, 16 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc

Fix a mess I made before checkin. I started trying something else but gave
up and forgot to put it back.
Review URL: http://codereview.chromium.org/75021
------------------------------------------------------------------------
r13825 | huanr@chromium.org | 2009-04-16 04:46:33 +0200 (Thu, 16 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Consolidate ApplyAccelerator and RunCommand code
paths which do the same thing.
  - On browser side, remove
    AutomationMsg_ApplyAccelerator IPC message
    and ApplyAccelerator function in
    automation_provider.
  - On client side, let ApplyAccelerator simply
    call RunCommandAsync.
With the change, converting all commands to
synchronous mode should benefit both.

Review URL: http://codereview.chromium.org/67152
------------------------------------------------------------------------
r13824 | rafaelw@chromium.org | 2009-04-16 04:41:28 +0200 (Thu, 16 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_browser_event_router.cc
   A /trunk/src/chrome/browser/extensions/extension_browser_event_router.h
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/test/TabsAPI/1/tabs_api.html

Initial plumbing for sending events from the browser to extension renderers. Implement onTabMoved.


Review URL: http://codereview.chromium.org/73065
------------------------------------------------------------------------
r13823 | rafaelw@chromium.org | 2009-04-16 03:27:13 +0200 (Thu, 16 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

ad an argument to MoveTabContentsAt() that switches whether the moved tab is set as the selected tab, or if the selected tab is left selected (but possibly moved).

Review URL: http://codereview.chromium.org/63153
------------------------------------------------------------------------
r13816 | aa@chromium.org | 2009-04-16 02:05:52 +0200 (Thu, 16 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc

Miscellaneous API sprucing.

- Camel-case event names.
- Rename chromium.self in content scripts to chromium.extension.
- Move onConnect in extension process to chromium.self.onConnect.
- Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API.
- Make toolstrips not wrap by default
- Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack.

Review URL: http://codereview.chromium.org/67162
------------------------------------------------------------------------
r13813 | erg@google.com | 2009-04-16 01:53:46 +0200 (Thu, 16 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   D /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/gtk_util.cc
   D /trunk/src/chrome/common/gtk_util.h

Reverts the previous two commits. (r13812 and r13811).

Review URL: http://codereview.chromium.org/75023
------------------------------------------------------------------------
r13811 | erg@google.com | 2009-04-16 01:28:36 +0200 (Thu, 16 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/gtk_util.cc (from /trunk/src/base/gfx/gtk_util.cc:13809)
   A /trunk/src/chrome/common/gtk_util.h

Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements.

Also:
- Fixes window dispositions (shift-click works on bookmark bar items).
- Reorganizes gtk_utils

Review URL: http://codereview.chromium.org/76002
------------------------------------------------------------------------
r13810 | sky@chromium.org | 2009-04-16 01:26:02 +0200 (Thu, 16 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/dock_info.h

Adds a factory method for creating DockInfos.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/75015
------------------------------------------------------------------------
r13808 | brettw@chromium.org | 2009-04-16 01:19:42 +0200 (Thu, 16 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/devtools_view.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   D /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/chrome.gyp

Remove TabContnetsType from everywhere.

I also removed the notion of the "active" tab contents since there is only one
per tab now, and all the messages to replace them.
Review URL: http://codereview.chromium.org/67173
------------------------------------------------------------------------
r13807 | pkasting@chromium.org | 2009-04-16 01:17:37 +0200 (Thu, 16 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Allow users to hit ctrl-shift-delete ("clear browsing data") even in fullscreen mode.

I elected not to continue to leave this disabled for app-mode windows since there's no menu entry for it.  Not sure if that was the right call.

BUG=9318
Review URL: http://codereview.chromium.org/67188
------------------------------------------------------------------------
r13805 | sidchat@google.com | 2009-04-16 01:15:06 +0200 (Thu, 16 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Fix issue: If SpellChecker is disabled through UI, then right-click context menu's spell checker language option should be unchecked.

Issue=7239
Review URL: http://codereview.chromium.org/75014
------------------------------------------------------------------------
r13796 | aa@chromium.org | 2009-04-15 23:48:10 +0200 (Wed, 15 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

TBR: Revert "Miscellaneous API sprucing."
This reverts commit 052b8f424d1550deebf3dc562d7c47dde72d7f76.

Review URL: http://codereview.chromium.org/78001
------------------------------------------------------------------------
r13792 | aa@chromium.org | 2009-04-15 23:26:54 +0200 (Wed, 15 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Miscellaneous API sprucing.

- Camel-case event names.
- Rename chromium.self in content scripts to chromium.extension.
- Move onConnect in extension process to chromium.self.onConnect.
- Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API.
- Make toolstrips not wrap by default
- Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack.

Review URL: http://codereview.chromium.org/67162
------------------------------------------------------------------------
r13786 | hclam@chromium.org | 2009-04-15 22:43:44 +0200 (Wed, 15 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   A /trunk/src/chrome/browser/views/options/exceptions_page_view.cc
   A /trunk/src/chrome/browser/views/options/exceptions_page_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   A /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.cc
   A /trunk/src/chrome/browser/views/options/passwords_exceptions_window_view.h
   A /trunk/src/chrome/browser/views/options/passwords_page_view.cc
   A /trunk/src/chrome/browser/views/options/passwords_page_view.h
   D /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   D /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   D /trunk/src/chrome/browser/views/password_manager_view.cc
   D /trunk/src/chrome/browser/views/password_manager_view.h

Use tab to group "Show saved passwords" and "Exceptions"
BUG=9026
"Show saved passwords" and "Exceptions" were splited into
2 dialogs, group together in one single dialog with
different pages by tabbing.

Review URL: http://codereview.chromium.org/67055
------------------------------------------------------------------------
r13784 | ben@chromium.org | 2009-04-15 22:42:54 +0200 (Wed, 15 Apr 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/omnibox_b.png
   A /trunk/src/chrome/app/theme/omnibox_bl.png
   A /trunk/src/chrome/app/theme/omnibox_br.png
   A /trunk/src/chrome/app/theme/omnibox_l.png
   A /trunk/src/chrome/app/theme/omnibox_r.png
   A /trunk/src/chrome/app/theme/omnibox_t.png
   A /trunk/src/chrome/app/theme/omnibox_tl.png
   A /trunk/src/chrome/app/theme/omnibox_tr.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   M /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/views/widget/widget.h
   M /trunk/src/chrome/views/widget/widget_gtk.cc
   M /trunk/src/chrome/views/widget/widget_gtk.h
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/widget/widget_win.h

Make the omnibox popup look nicer. Add dropshadow images (not final). Experiment with some effects.

Adds a positioner interface that allows the popup to size itself to the width of the edit view + the width of the star and go buttons. (Basically the toolbar needs to help the popup position itself).

No results yet!

Review URL: http://codereview.chromium.org/68011
------------------------------------------------------------------------
r13783 | hclam@chromium.org | 2009-04-15 22:38:47 +0200 (Wed, 15 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Set media cache back to its maximum ~1.8GB
We allow media cache to be set to its maximum for testing
purpose.

TBR=fbarchard, scherkus, rvargas
Review URL: http://codereview.chromium.org/67175
------------------------------------------------------------------------
r13779 | sverrir@google.com | 2009-04-15 22:29:58 +0200 (Wed, 15 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Make the importer respect the user selected languge.  On install the language can
either be set by a command line argument or a registry key (set by Omaha).  The problem 
with the registry key approach is that the language is put into the local state but its not
persisted before the importer process is launched and that process is therefore oblivious to
the language and uses the default one.

------------------------------------------------------------------------
r13773 | jungshik@google.com | 2009-04-15 21:16:10 +0200 (Wed, 15 Apr 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/chrome_font_win.cc
   M /trunk/src/chrome/common/l10n_util_win.cc
   M /trunk/src/chrome/common/l10n_util_win.h
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/views/controls/menu/chrome_menu.cc
   M /trunk/src/chrome/views/controls/menu/menu.cc
   M /trunk/src/chrome/views/controls/table/table_view.cc
   M /trunk/src/chrome/views/controls/tree/tree_view.cc
   M /trunk/src/chrome/views/widget/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/widget/tooltip_manager.cc
   M /trunk/src/chrome/views/widget/tooltip_manager.h
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/custom_frame_view.h
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.h

For some Indian locales, the automatic font fallback by Windows UI components leads to too tiny glyphs for UI strings.  Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale).

It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch).

For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used. 

For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150. 

When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY. 

While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner.

The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac. 

TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same. 
2.UI test in en-US locale should pass.
3. Running UI tests under Purify should not have any new leak.

BUG=7319
Review URL: http://codereview.chromium.org/62064
------------------------------------------------------------------------
r13770 | pkasting@chromium.org | 2009-04-15 20:49:41 +0200 (Wed, 15 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc

Try to fix yet another compile failure

------------------------------------------------------------------------
r13767 | pkasting@chromium.org | 2009-04-15 20:40:39 +0200 (Wed, 15 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.h

Change GTK Go button impl to match the changes I already made to the Windows implementation.
Review URL: http://codereview.chromium.org/67178
------------------------------------------------------------------------
r13761 | pkasting@chromium.org | 2009-04-15 20:08:49 +0200 (Wed, 15 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/test/test_browser_window.h

Fix regression I introduced where Stop/Go button would toggle state instantly instead of having protections against accidental user actions while the mouse was hovering the button.

I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple.

BUG=9843
Review URL: http://codereview.chromium.org/67156
------------------------------------------------------------------------
r13755 | pinkerton@chromium.org | 2009-04-15 19:26:08 +0200 (Wed, 15 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/command_observer_bridge.h
   A /trunk/src/chrome/browser/cocoa/command_observer_bridge_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Unit test for command observer bridge class. Add ifdef guards that were missing in the original header file.
Review URL: http://codereview.chromium.org/73082
------------------------------------------------------------------------
r13753 | tim@chromium.org | 2009-04-15 19:15:41 +0200 (Wed, 15 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile_manager_unittest.cc

Disable a test I added yesterday in attempt to track down
purify regression.

TBR=erikkay

Review URL: http://codereview.chromium.org/68016
------------------------------------------------------------------------
r13749 | deanm@chromium.org | 2009-04-15 18:40:46 +0200 (Wed, 15 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Make Linux Omnibox results look more like the v2 mocks.

- Put back description text.  No fancy handling here for when the content
  would push the description off, they just ellipsize together.
- Load the 5 new types of icons, and display them based on the match.
- Change the popup size and positioning to fit under the star and go buttons.

Review URL: http://codereview.chromium.org/73080

------------------------------------------------------------------------
r13742 | sky@chromium.org | 2009-04-15 16:41:48 +0200 (Wed, 15 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h

Fixes regression in painting info bubble. This is the result of
changes to DrawRectInt. Previously a width/height of 0 was treated as a 1
pixel line, where as now nothing gets drawn. I've special cased this
again.

BUG=9931
TEST=see bug

Review URL: http://codereview.chromium.org/67149
------------------------------------------------------------------------
r13741 | deanm@chromium.org | 2009-04-15 16:16:00 +0200 (Wed, 15 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Fixing a crash which could occur when a string containing multibyte characters is passed to AutocompleteEditViewGtk::EmphasizeURLComponents().

The AutocompleteInput::Parse works in a wstring, so the parts indices are also for a wstring.  Convert these to utf8 byte indices.

BUG=10539

Review URL: http://codereview.chromium.org/73078

------------------------------------------------------------------------
r13740 | pinkerton@chromium.org | 2009-04-15 15:58:17 +0200 (Wed, 15 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add unit test for bookmark bar controller.
Review URL: http://codereview.chromium.org/73051
------------------------------------------------------------------------
r13738 | mmoss@chromium.org | 2009-04-15 08:02:26 +0200 (Wed, 15 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disable BrowserFocusTest.BrowsersRememberFocus until it can be looked at.

This seems likely due to the changes in http://codereview.chromium.org/67139

TBR=huanr

Review URL: http://codereview.chromium.org/73070

------------------------------------------------------------------------
r13732 | finnur@chromium.org | 2009-04-15 05:54:32 +0200 (Wed, 15 Apr 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/find_backend_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Adding a unit test for testing the prepopulation text during search.

Review URL: http://codereview.chromium.org/73059
------------------------------------------------------------------------
r13730 | brettw@chromium.org | 2009-04-15 05:25:11 +0200 (Wed, 15 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/browser_url_handler.h
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/toolbar_model.cc

Remove TabContentsType from the NavigationController external interface and in
some related areas. I removed all uses of this in the previous patch.
Review URL: http://codereview.chromium.org/73057
------------------------------------------------------------------------
r13726 | willchan@chromium.org | 2009-04-15 03:28:35 +0200 (Wed, 15 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Oops.  Fix build.
s/WebContentsView/WebContentsViewMac/

Review URL: http://codereview.chromium.org/73062
------------------------------------------------------------------------
r13725 | willchan@chromium.org | 2009-04-15 02:52:44 +0200 (Wed, 15 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

Fix missing backing store in Linux.

Issue: In the renderer host, the RenderWidgetHostView gets created before the ViewMsg_New gets sent.  In the Linux code, gtk packing of the RenderWidgetHostView will cause a configure-event to happen, which leads to ViewHost_Resize getting sent before the ViewMsg_New gets sent.  This eventually leads to the backing store never getting created.  See the bug report for details.

Fix:
Add a SetChildSize() method to WebContentsView.
Windows and Mac keep their current flow of just calling SetSize() on the child.
Linux defers packing from the RenderWidgetHostView creation to the SetChildSize() call.

BUG=9830

Review URL: http://codereview.chromium.org/67044
------------------------------------------------------------------------
r13723 | jcampan@chromium.org | 2009-04-15 02:17:53 +0200 (Wed, 15 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/base/values.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html

Few changes to the NTP remove thumbnails:
- some minor string changes
- there is now a Cancel button next to the Done button to restore the thumbnails removed during the current editing session
- link and favico are opacified as well in remove mode
- now using a dictionary instead of a list to store the URL blacklist for faster access
- now storing URL hashes instead of URLs (for privacy and also because the DictionaryValue breaks down keys on . characters)

BUG=None
TEST=Make sure removing thumbnails works as expected. Start removing thumbnails then click Cancel, verify that the thumbnails just removed are restored.
Review URL: http://codereview.chromium.org/69007
------------------------------------------------------------------------
r13722 | jhawkins@chromium.org | 2009-04-15 01:58:08 +0200 (Wed, 15 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc

Simplify TabGtk::ContextMenuController by adding methods to dynamically build a MenuGtk and use them.
Review URL: http://codereview.chromium.org/68013
------------------------------------------------------------------------
r13721 | estade@chromium.org | 2009-04-15 01:50:18 +0200 (Wed, 15 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc

Fix syntax error.

TBR=mmoss

Review URL: http://codereview.chromium.org/69009
------------------------------------------------------------------------
r13720 | aa@chromium.org | 2009-04-15 01:40:41 +0200 (Wed, 15 Apr 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   A /trunk/src/chrome/renderer/extensions/json_schema_unittest.cc
   M /trunk/src/chrome/renderer/js_only_v8_extensions.cc
   M /trunk/src/chrome/renderer/js_only_v8_extensions.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/renderer/resources/json_schema.js
   A /trunk/src/chrome/test/data/extensions/json_schema_test.js
   A /trunk/src/chrome/test/data/js_test_runner.html
   A /trunk/src/chrome/test/render_view_test.cc
   A /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add JsonSchema-based validation for the tab APIs.

Arv: can you take json_schema.js and json_schema_test.js.
Matt: you take the rest.

Review URL: http://codereview.chromium.org/66006
------------------------------------------------------------------------
r13719 | tc@google.com | 2009-04-15 01:38:13 +0200 (Wed, 15 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Convert instances of WideToUTF8(l10n_util::GetString( to
l10n_util::GetStringUTF8 in the gtk code.  This saves us some string
conversions.

BUG=9688

Review URL: http://codereview.chromium.org/73056

------------------------------------------------------------------------
r13718 | estade@chromium.org | 2009-04-15 01:25:16 +0200 (Wed, 15 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Clean up icon loader/manager in preparation for porting.

Remove a bunch of unused functions and change wstrings to filepaths and remove an obsolete enum.

Review URL: http://codereview.chromium.org/73007
------------------------------------------------------------------------
r13716 | estade@chromium.org | 2009-04-15 01:15:47 +0200 (Wed, 15 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/chrome_process_util.cc
   A /trunk/src/chrome/test/chrome_process_util_linux.cc
   A /trunk/src/chrome/test/chrome_process_util_mac.cc
   M /trunk/src/chrome/test/chrome_process_util_win.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Implement chrome_proces_util for linux and enable download ui test.

To get the PID from the socket, we use lsof (fuser doesn't work with unix sockets apparently).

The download shelf, save page, and browser ui tests now pass.

Review URL: http://codereview.chromium.org/66071
------------------------------------------------------------------------
r13715 | aa@chromium.org | 2009-04-15 00:42:35 +0200 (Wed, 15 Apr 2009) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_content_script_inject_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Remove ExtensionContentScriptInject unit test.

This was somehow causing crashes in ExtensionViewTest.

Review URL: http://codereview.chromium.org/68012
------------------------------------------------------------------------
r13714 | jhawkins@chromium.org | 2009-04-15 00:40:03 +0200 (Wed, 15 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Implement context menu handling for the Linux tab strip.
Review URL: http://codereview.chromium.org/73053
------------------------------------------------------------------------
r13711 | ace@google.com | 2009-04-15 00:20:18 +0200 (Wed, 15 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Add command line flag that removes randomness from javascript functions, to be used during reliability_tests.

Review URL: http://codereview.chromium.org/63143
------------------------------------------------------------------------
r13709 | huanr@chromium.org | 2009-04-15 00:18:06 +0200 (Wed, 15 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h

Remove the usage of GetLastActiveBrowserWindow
as the function is flakey.

BUG=10501

Review URL: http://codereview.chromium.org/67139
------------------------------------------------------------------------
r13707 | brettw@chromium.org | 2009-04-15 00:13:55 +0200 (Wed, 15 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   D /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   D /trunk/src/chrome/browser/tab_contents/tab_contents_factory.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h
   D /trunk/src/chrome/test/test_tab_contents.cc
   D /trunk/src/chrome/test/test_tab_contents.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Remove the TestTabContents. This makes BrowserWithTestWindow use the
TestRenderViewHost instead. There are some changes to browser_commands_unittest
to support this. Now that we're using proper TabContentes, I had to stub out
a FocusManager call since there isn't a proper view hierarchy created.

Remove TabContents collection and switching from the NavigationController. I
tried to keep the same interface to the NavigationController since I tried that
in a previous patch and the change blew up.

Remove the TabContents factory. Callers now create a WebContents directly.
Review URL: http://codereview.chromium.org/67113
------------------------------------------------------------------------
r13704 | pinkerton@chromium.org | 2009-04-15 00:06:13 +0200 (Wed, 15 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Remove two lines that were from a different experiment and got checked in
accidentally. Those lines only have an effect for non-textured windows. Patch from nicothakis@googlemail.com.
------------------------------------------------------------------------
r13703 | tim@chromium.org | 2009-04-15 00:05:33 +0200 (Wed, 15 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc

Give each HistoryService instance it's own backend thread.
I had originally planned to push history_thread up to BrowserProcess,
but was scared away by the comment in ~Profile that talks about HistoryService
calling back into the bookmark bar model, and that it depended on join()ing at
that particular time to ensure this doesn't happen after the bookmark bar model has been reset.

I didn't use scoped_ptr for the thread because it makes the little dance
in CleanUp awkward.

TEST=any existing test that exersizes the history service. I added a ProfileManager
test that would fail without this change.

Review URL: http://codereview.chromium.org/73012
------------------------------------------------------------------------
r13700 | shess@chromium.org | 2009-04-14 22:54:28 +0200 (Tue, 14 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Implement OnBeforePossibleChange() and OnAfterPossibleChange() to fix delete in Mac Omnibox.

BUG=10030

Review URL: http://codereview.chromium.org/67136
------------------------------------------------------------------------
r13699 | thestig@chromium.org | 2009-04-14 22:51:56 +0200 (Tue, 14 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

Remove extra zoom menu items.
Review URL: http://codereview.chromium.org/73023
------------------------------------------------------------------------
r13696 | finnur@chromium.org | 2009-04-14 22:14:24 +0200 (Tue, 14 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h

A fix for the Find box forwarding scroll messages to the page when it shouldn't.

TEST=Open Find on a page with scrollbars, type in 'nomatch', scroll to the middle of the page, set the cursor at the end of the Find text field and add '!', '(' and ')' to the search string. Make sure the page doesn't scroll.
BUG=10509
Review URL: http://codereview.chromium.org/67135
------------------------------------------------------------------------
r13695 | avi@google.com | 2009-04-14 22:08:00 +0200 (Tue, 14 Apr 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/SaveAccessoryView.xib
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add a Cocoa file picker.

Review URL: http://codereview.chromium.org/73044
------------------------------------------------------------------------
r13693 | cpu@google.com | 2009-04-14 21:50:26 +0200 (Tue, 14 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc

Clamp text size in js message box dialogs
- Long text peg cpu at 100% for a couple of minutes for the UI thread
- Now with extra protection for OnUnload()

BUG=8863

TEST=existing ui tests suffice.


Review URL: http://codereview.chromium.org/73043
------------------------------------------------------------------------
r13686 | thomasvl@chromium.org | 2009-04-14 21:03:41 +0200 (Tue, 14 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/chrome.gyp

The history tests relies on being about to reset a profile, which means we need
  to load a bunch of resources. For the Mac, this means we build the app first
  and the unittest looks into the app bundle to pull resources.

Review URL: http://codereview.chromium.org/73046
------------------------------------------------------------------------
r13685 | avi@google.com | 2009-04-14 20:57:37 +0200 (Tue, 14 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fixes a bug where scrolling up would draw over the horizontal
scrollbar on mac.

Patch by rohitrao.

http://codereview.chromium.org/73042

------------------------------------------------------------------------
r13683 | pkasting@chromium.org | 2009-04-14 20:38:31 +0200 (Tue, 14 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/views/window/window_win.cc

Don't reserve space for an auto-hide taskbar that's not always-on-top.  Windows native behavior is to cover these.

BUG=9976
Review URL: http://codereview.chromium.org/66055
------------------------------------------------------------------------
r13682 | agl@chromium.org | 2009-04-14 20:34:31 +0200 (Tue, 14 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Linux: don't drop invalid scroll requests.

When performing an anchor jump, WebKit will send a scroll request with
an invalid scroll magnitude (greater than the size of the window). We
must still process the paint request attached however.

BUG=10494
http://codereview.chromium.org/67132

------------------------------------------------------------------------
r13681 | pkasting@chromium.org | 2009-04-14 20:33:32 +0200 (Tue, 14 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h

Fix problems correctly invalidating/repainting when our updated paint rect for a large area came back while we were repainting a smaller area.
Review URL: http://codereview.chromium.org/66013
------------------------------------------------------------------------
r13680 | paulg@google.com | 2009-04-14 20:30:34 +0200 (Tue, 14 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/common/notification_type.h

Remove unused notifications.

The old download tab page was the only consumer of
these notifications, so they're no longer necessary.

Review URL: http://codereview.chromium.org/69003
------------------------------------------------------------------------
r13679 | jhawkins@chromium.org | 2009-04-14 20:25:45 +0200 (Tue, 14 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fix a crash when the browser opens a popup window in Linux.
Review URL: http://codereview.chromium.org/73045
------------------------------------------------------------------------
r13676 | tc@google.com | 2009-04-14 20:15:59 +0200 (Tue, 14 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_gtk.cc

Fix a gcc warning about uninitialized variables.

app_modal_dialog_gtk.cc:46:warning: ‘message_type’ may be used uninitialized in this function
app_modal_dialog_gtk.cc:46:warning: ‘buttons’ may be used uninitialized in this function

Review URL: http://codereview.chromium.org/73040

------------------------------------------------------------------------
r13674 | pinkerton@chromium.org | 2009-04-14 20:09:13 +0200 (Tue, 14 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   A /trunk/src/chrome/browser/cocoa/status_bubble_mac_unittest.mm
   M /trunk/src/chrome/chrome.gyp

Add unit test for status bubble mac.
Review URL: http://codereview.chromium.org/67131
------------------------------------------------------------------------
r13671 | pkasting@chromium.org | 2009-04-14 19:42:14 +0200 (Tue, 14 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc

Color/emphasize correct portions of view-source: URLs.  Original patch by Shinichiro Hamaji (see http://codereview.chromium.org/62094/show ), r=me.

BUG=2349
------------------------------------------------------------------------
r13670 | pkasting@chromium.org | 2009-04-14 19:37:04 +0200 (Tue, 14 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h

Fix status bubble shadow being opaque, which made the bubble appear to be off by one pixel.  This reverts Brett's fix for issue 8651 and instead fixes that issue by ensuring the text bounding box does not overlap the status bubble shadow.  This also makes kShadowThickness (renamed for consistency with the browser frame) a class-scoped constant so the browser view can access it, eliminating a magic number.

BUG=9928
Review URL: http://codereview.chromium.org/67059
------------------------------------------------------------------------
r13668 | sky@chromium.org | 2009-04-14 19:16:24 +0200 (Tue, 14 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Makes the omnibox show past searches and suggestions for keywords.
We talked about primary and secondary, but after doing it all I felt
keyword and default better portrayed what is going on.

After trying this out I think we need to tune relevancy. But that
can be done later

BUG=3636
TEST=make sure omnibox isn't broken.

Review URL: http://codereview.chromium.org/66073
------------------------------------------------------------------------
r13662 | idanan@chromium.org | 2009-04-14 17:23:43 +0200 (Tue, 14 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Added undo tab closing item to Tab menu.

Review URL: http://codereview.chromium.org/62151
------------------------------------------------------------------------
r13661 | pinkerton@chromium.org | 2009-04-14 17:23:39 +0200 (Tue, 14 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/TabContents.xib
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.h
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp

Collapse bookmark bars into a single bar per window, rather than one per tab.
Create a separate controller for the bar. Hide bar when it's not supposed to be
visible instead of just allowing it to be covered by content (it's not always
covered, which leads to drawing errors).
------------------------------------------------------------------------
r13660 | maruel@chromium.org | 2009-04-14 17:07:04 +0200 (Tue, 14 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h

Prevent an extension from double observing a message filter.

Fixes Vista ui_test debug failures.

Patch by Paul Godavari

Review: http://codereview.chromium.org/67120

------------------------------------------------------------------------
r13652 | aa@chromium.org | 2009-04-14 09:07:18 +0200 (Tue, 14 Apr 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   D /trunk/src/chrome/renderer/extensions/json_schema_unittest.cc
   M /trunk/src/chrome/renderer/js_only_v8_extensions.cc
   M /trunk/src/chrome/renderer/js_only_v8_extensions.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   D /trunk/src/chrome/renderer/resources/json_schema.js
   D /trunk/src/chrome/test/data/extensions/json_schema_test.js
   D /trunk/src/chrome/test/data/js_test_runner.html
   D /trunk/src/chrome/test/render_view_test.cc
   D /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Revert "Add JsonSchema-based validation for the tab APIs."
This reverts commit 4f47758f5238f2e5b05d9de18f390bfe2aeb6980.

Revert "TBR: Fix unit tests, line endings."
This reverts commit 257fa01e20c46c68dce1c5992b75c64686cb1a66.

Review URL: http://codereview.chromium.org/67122
------------------------------------------------------------------------
r13651 | aa@chromium.org | 2009-04-14 08:48:59 +0200 (Tue, 14 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/test/data/extensions/json_schema_test.js

TBR: Fix unit tests, line endings.

Review URL: http://codereview.chromium.org/67121
------------------------------------------------------------------------
r13649 | aa@chromium.org | 2009-04-14 08:10:31 +0200 (Tue, 14 Apr 2009) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_messages_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   A /trunk/src/chrome/renderer/extensions/json_schema_unittest.cc
   M /trunk/src/chrome/renderer/js_only_v8_extensions.cc
   M /trunk/src/chrome/renderer/js_only_v8_extensions.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/renderer/resources/json_schema.js
   A /trunk/src/chrome/test/data/extensions/json_schema_test.js
   A /trunk/src/chrome/test/data/js_test_runner.html
   A /trunk/src/chrome/test/render_view_test.cc
   A /trunk/src/chrome/test/render_view_test.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add JsonSchema-based validation for the tab APIs.

Arv: can you take json_schema.js and json_schema_test.js.
Matt: you take the rest.

Review URL: http://codereview.chromium.org/66006
------------------------------------------------------------------------
r13644 | paulg@google.com | 2009-04-14 04:03:20 +0200 (Tue, 14 Apr 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/notification_type.h

Fix a crash where the ResourceMessageFilter is deleted before a
SafeBrowsing check has completed. The problem occurs since the
SafeBrowsingResourceHandler is not deleted when its associated
URLRequest is cleaned up *and* a SafeBrowsing check is in progress.
When the check completes, the next resource handler in the chain
(the AsyncResourceHandler which caches a pointer the now deleted
ResourceMessageFilter) will crash.

This CL adds a notification for objects to know when the
ResourceMessageFilter is destroyed.

BUG=8544 (http://crbug.com)

Review URL: http://codereview.chromium.org/63036
------------------------------------------------------------------------
r13643 | estade@chromium.org | 2009-04-14 03:39:41 +0200 (Tue, 14 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/link_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h

Linux: Ignore certain menu accelerators.

Review URL: http://codereview.chromium.org/73003
------------------------------------------------------------------------
r13637 | brettw@chromium.org | 2009-04-14 01:35:51 +0200 (Tue, 14 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   D /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   D /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/chrome.gyp

Remove the DOMUIHost. It is not used by any code.

This also does a minor fix for forward-declares of RenderViewHostFactory.
Review URL: http://codereview.chromium.org/66046
------------------------------------------------------------------------
r13636 | tc@google.com | 2009-04-14 01:34:19 +0200 (Tue, 14 Apr 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc

Fix the title of a JavaScript dialog box.

Currently, the title of a JavaScript dialog box contains "Alert"
regardless of how it's made: whether by alert(), prompt(), or confirm().

"Alert" should be there only when the dialog box is created by alert().

Tested by: unittest, ui_tests, manually

BUG=2359

Original patch by yuzo@google.com at http://codereview.chromium.org/67099

Review URL: http://codereview.chromium.org/70002

------------------------------------------------------------------------
r13629 | jam@chromium.org | 2009-04-14 01:18:02 +0200 (Tue, 14 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   M /trunk/src/chrome/common/notification_type.h

Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, instead create a new one for crashing.

The old way of using notifications was incorrect since a RenderProcessHost might have sent only one notification even though a new renderer might have been created after a crash.

BUG=9379

Review URL: http://codereview.chromium.org/66069
------------------------------------------------------------------------
r13618 | willchan@chromium.org | 2009-04-14 00:23:18 +0200 (Tue, 14 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/go_button_gtk.h
   M /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Implement tooltips for the Go/Stop button in Linux.
BUG=9381

Review URL: http://codereview.chromium.org/67064
------------------------------------------------------------------------
r13613 | finnur@chromium.org | 2009-04-14 00:16:03 +0200 (Tue, 14 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Once you search for something in a tab, you are very likely to search for the same thing in another tab. Therefore, if you haven't searched for anything within that tab then Chrome should prepopulate the Find box with the last string you searched for (in any tab).

BUG=876
TEST=Open google.com, Ctrl+F, search for 'e'. Open a new tab/new window/open a link in a new window. In all of those new tabs the Find box should be prepopulated with 'e' that is selected (for easy overwriting).
Review URL: http://codereview.chromium.org/67066
------------------------------------------------------------------------
r13612 | mpcomplete@google.com | 2009-04-14 00:15:29 +0200 (Tue, 14 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/renderer/extensions/event_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Hook up extension events to the json parser, and change the extension message
passing stuff to use json.

Also made sure to lowercase extension IDs when looking them up in
ExtensionMessageService.
Review URL: http://codereview.chromium.org/67054
------------------------------------------------------------------------
r13611 | jcampan@chromium.org | 2009-04-13 21:00:29 +0200 (Mon, 13 Apr 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/ntp_x_icon.png
   A /trunk/src/chrome/app/theme/ntp_x_icon_active.png
   A /trunk/src/chrome/app/theme/ntp_x_icon_hover.png
   A /trunk/src/chrome/app/theme/ntp_x_icon_small.png
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.h
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

This CL adds some UI to remove most-visited thumbnails from the New Tab Page.
The URL of removed thumbnails is added to a blacklist, which is a user pref.

I had to modify the VisitSegmentDatabase::QuerySegmentUsage not to return a
fixed number of items, as now we may filter the ones we get back.

Note: this adds between 20 and 30ms to the first NTP load on my machine (a
3 to 5% increase).

BUG=685
TEST=Open the NTP. Click the 'Edit thumbnails' link.  Remove some thumbnails.
     Press Done. Edit again, use the "Restore removed" link.

Review URL: http://codereview.chromium.org/67037
------------------------------------------------------------------------
r13609 | jcampan@chromium.org | 2009-04-13 20:43:25 +0200 (Mon, 13 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

My previous refactoring of the mouse-wheel redirecting code
caused menus (such as the book-mark menu) to be closed on mouse-wheel scroll.
I had put the rerouting of the mouse-wheel messages in the RenderWidgetViewWin::OnWheelEvent after the workaround for the Thinkpad mousewheel driver, which closes the popups.
In the original code, the rerouting was done in the FocusManager by way of sub-classing and was therefore happening before RenderWidgetViewWin::OnWheelEvent.
This CL reverts to the original order which fixes the bug.

BUG=9752
TEST=Have a profile with lots of bookmarks in a folder on the bookmark toolbar, click on the folder to bring up the scrollable menu. The menu should scroll when you use the mouse-wheel.

Review URL: http://codereview.chromium.org/67063
------------------------------------------------------------------------
r13605 | brettw@chromium.org | 2009-04-13 20:22:22 +0200 (Mon, 13 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/views/controls/hwnd_view.h

Add a comment to the hwnd view about proper usage. I was using it incorrectly
in when trying to do some ui demos.

Add a hook for the frame window test I'm doing.
Review URL: http://codereview.chromium.org/58013
------------------------------------------------------------------------
r13604 | huanr@chromium.org | 2009-04-13 20:15:14 +0200 (Mon, 13 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h

A few more UI commands: duplicate tab, open window.
Convert them to synchronous mode, move to 
AutoMatedUITestBase, add unit test.

Review URL: http://codereview.chromium.org/66066
------------------------------------------------------------------------
r13600 | robertshield@google.com | 2009-04-13 19:01:35 +0200 (Mon, 13 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc


Review URL: http://codereview.chromium.org/62160
------------------------------------------------------------------------
r13598 | robertshield@google.com | 2009-04-13 18:45:29 +0200 (Mon, 13 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h

Adding versioning support to the chrome automation protocol.

Review URL: http://codereview.chromium.org/62061
------------------------------------------------------------------------
r13595 | erikkay@google.com | 2009-04-13 17:46:41 +0200 (Mon, 13 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   M /trunk/src/chrome/browser/extensions/extension_process_manager.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   A /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
   A /trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip2.html

Hook up a bit more plumbing to ExtensionView which should allow popup windows and widgets to work.Add in a quick hack that lets you bring up the web inspector.
Review URL: http://codereview.chromium.org/67029
------------------------------------------------------------------------
r13592 | pinkerton@chromium.org | 2009-04-13 16:58:54 +0200 (Mon, 13 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm

Adds the ability to open a new window by clicking on the dock icon,
if there are no currently open windows.  If there are minimized windows
but no open windows, the most recently minimized window will open. Patch from rohitrao@google.com

BUG=9548
------------------------------------------------------------------------
r13591 | pinkerton@chromium.org | 2009-04-13 16:55:47 +0200 (Mon, 13 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Disable Leopard's automatic window title gradient height detection, as it gets
confused by our tabs. Patch from rohitrao@google.com. 
------------------------------------------------------------------------
r13589 | pinkerton@chromium.org | 2009-04-13 14:53:03 +0200 (Mon, 13 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/browser/status_bubble.h

Convert more members to scoped pointers. Move status bubble into browser window controller. Move extra window retain into BWC because it's needed for things in there, not the BrowserWindow impl. Be explicit about the ordering and nature of the ownership in BWC, which should be better since it's now all in one place. Clean up a lot of un-used cruft in tab strip and tab contents now that the toolbaris no longer there, preparing for the BookmarkBar to leave as well.
Review URL: http://codereview.chromium.org/66047
------------------------------------------------------------------------
r13588 | hbono@chromium.org | 2009-04-13 06:56:20 +0200 (Mon, 13 Apr 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

A quick fix for Issue 9762 and 9763.
This is caused by my change r12434 that does not check if there are any other keys pressed when a user presses left-control and left-shift keys (or right-control and right-shift keys).
To fix this issue, this change does not only add the above check, but also it adds code that cancels updating the text direction if a user presses another key while he/she is pressing control and shift keys.

BUG=9762 "Regression: Shift+Ctrl+Arrow selection combination also changes text direction in RTL UIs"
BUG=9763 "Ctrl+Shift text alignment depends of the sides of both the Ctrl and the Shift keys"

TEST=In a LTR <textarea> element, pressing a control key, pressing a right-shift key, releasing the right-shift key, and verify its text direction is changed to RTL.
TEST=In an RTL <textarea> element, pressing a control key, pressing a left-shift key, releasing the left-shift key, and verify its text direction is changed to LTR.
TEST=In a LTR <textarea> element, pressing a right-shift key, pressing a control key, releasing the right-shift key, and verify its text direction is still LTR.
TEST=In a LTR <textarea> element, pressing a control key, pressing a right-shift key, releasing the control key, and verify its text direction is changed to RTL.
TEST=In an RTL <textarea> element, pressing a left-shift key, pressing a control key, releasing the left-shift key, and verify its text direction is still RTL.
TEST=In an RTL <textarea> element, pressing a control key, pressing a left-shift key, releasing the control key, and verify its text direction is changed to LTR.
TEST=In a LTR <textarea> element, pressing a control key, pressing a right-shift key, pressing an arrow key, releasing the right-shift key, and verify its text direction is still LTR.
Review URL: http://codereview.chromium.org/63117
------------------------------------------------------------------------
r13573 | avi@chromium.org | 2009-04-12 22:03:08 +0200 (Sun, 12 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Refactoring; switch the |filter| parameter into something that is more amenable to cross-platform implementation.

BUG=9852

Review URL: http://codereview.chromium.org/63093
------------------------------------------------------------------------
r13556 | thestig@chromium.org | 2009-04-11 04:29:00 +0200 (Sat, 11 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/standard_menus.cc

Enable zooming in on Linux.
Review URL: http://codereview.chromium.org/66068
------------------------------------------------------------------------
r13550 | arv@chromium.org | 2009-04-11 01:51:56 +0200 (Sat, 11 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/tools/grit/grit/format/html_inline.py

This adds link[rel=icon] elements to the DOM UI html files for downloads and 
history.

It also adds code to inline the resources for <link rel="icon"> elements

BUG=9805

Review URL: http://codereview.chromium.org/66041
------------------------------------------------------------------------
r13545 | estade@chromium.org | 2009-04-11 00:43:40 +0200 (Sat, 11 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/link_button_gtk.cc
   M /trunk/src/chrome/browser/gtk/link_button_gtk.h

Make linux link buttons pretty.

- set text to red while button is active
- get rid of border spacing

Review URL: http://codereview.chromium.org/66058
------------------------------------------------------------------------
r13544 | jar@chromium.org | 2009-04-11 00:29:29 +0200 (Sat, 11 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_win.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h

Remove histogram connection to base classes in stats_counter

Now that histograms move data from renderer to browser, there
is less reason to connect to stats counters.
Stats counters were using shared memory, and now they may
plausibly use the histogram's IPC mechanism instead to
move data to the browser.  The first step is remove the
inheritance, and teh next (plausible/future) step
would be to implement counters as histograms with only
one bucket.

r=mbelshe
Review URL: http://codereview.chromium.org/66029
------------------------------------------------------------------------
r13543 | erg@google.com | 2009-04-10 23:53:14 +0200 (Fri, 10 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Use favicons in the bookmark bar under GTK.

Review URL: http://codereview.chromium.org/66056
------------------------------------------------------------------------
r13542 | scherkus@chromium.org | 2009-04-10 23:53:00 +0200 (Fri, 10 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.h

Removing --enable-video and instead relying on having DLLs present.

I measured a ~10ms startup regression when the DLLs are not present and a ~20ms
regression when the DLLs are present and loaded in render_process.cc.

Not sure how else to tackle this problem since we need these DLLs loaded before
the sandbox is engaged.

Review URL: http://codereview.chromium.org/63101
------------------------------------------------------------------------
r13541 | shess@chromium.org | 2009-04-10 23:31:09 +0200 (Fri, 10 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Fix missing virtual GetModel().
GetModel() was added by http://codereview.chromium.org/67035 which
running my change on the trybots, and I trusted the merge.

Review URL: http://codereview.chromium.org/66054
------------------------------------------------------------------------
r13539 | ben@chromium.org | 2009-04-10 22:59:18 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h

Fix build bustage - make sure GTK Autocomplete edit/popup implement the GetModel interface method.

TBR=deanm
Review URL: http://codereview.chromium.org/66052
------------------------------------------------------------------------
r13538 | ben@chromium.org | 2009-04-10 22:43:19 +0200 (Fri, 10 Apr 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/app/theme/o2-globe.png
   A /trunk/src/chrome/app/theme/o2-history.png
   A /trunk/src/chrome/app/theme/o2-more.png
   A /trunk/src/chrome/app/theme/o2-search.png
   A /trunk/src/chrome/app/theme/o2-star.png
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   A /trunk/src/chrome/browser/views/autocomplete
   A /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc
   A /trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Allow a different omnibox popup to be enabled via the command line (--enable-omnibox2).

This will allow a views-based omnibox popup conforming to the new spec (stub provided) to be brought up without disturbing ToT UX.

Also adds new images from Nicholas.

Review URL: http://codereview.chromium.org/67035
------------------------------------------------------------------------
r13536 | thestig@chromium.org | 2009-04-10 22:30:34 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/filter_unittest.cc
   M /trunk/src/net/base/filter_unittest.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h

Give the filter setup more context so it can figure out whether it's downloading a file or not. Only refuse to gunzip svgz files on download, so we can send an uncompressed svgz file to webkit.

BUG=9737
Review URL: http://codereview.chromium.org/62111
------------------------------------------------------------------------
r13534 | shess@chromium.org | 2009-04-10 22:14:00 +0200 (Fri, 10 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

Initial implemention of Mac Omnibox.

AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView.  AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs).

AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner.  It works with the popup view to make sure the popup is positioned correctly.  AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model).

LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views.  It is mostly placeholder code stolen from the gtk implementation.

---

I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future.  So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc.

Review URL: http://codereview.chromium.org/50074
------------------------------------------------------------------------
r13532 | pkasting@chromium.org | 2009-04-10 22:01:31 +0200 (Fri, 10 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.h

Fix PCH-related build break

------------------------------------------------------------------------
r13531 | pkasting@chromium.org | 2009-04-10 21:55:40 +0200 (Fri, 10 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

Fix various problems with the window_sizer code.
AdjustBoundsToBeVisibleOnMonitorContaining() is somewhat misnamed (but I can't think of a better name, so I just commented to this effect).  It tries to ensure each edge is visible on *some* monitor (although it doesn't actually even do that in pathological cases), and adjusts things to be "on the desired monitor" if not.  There were various bugs in this, including checking the wrong coordinates for work areas off the right/bottom sides of the primary work area, and adjusting to the wrong top/left coordinates when the desired monitor's work area was not at (0,0).  Additionally, PositionIsOffscreen() actually returned whether the position is _onscreen_, which confused me greatly.In addition, this code used a cache of work area sizes, which is unfortunately wrong since work areas can change as the program is running.  Now it re-gets the work areas, which is a little slower, but presumably doesn't actually matter.

This also simplified the unittest code some (making it more correct in the process) and added a few tests for cases that my original version of this got wrong but which didn't trigger test failures.

Review URL: http://codereview.chromium.org/65013
------------------------------------------------------------------------
r13530 | wtc@chromium.org | 2009-04-10 21:51:58 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Fix a typo (LOAD_ENABLE_FILE) in a comment added in r11661.

R=hclam
Review URL: http://codereview.chromium.org/67043
------------------------------------------------------------------------
r13527 | brettw@chromium.org | 2009-04-10 21:31:40 +0200 (Fri, 10 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.cc
   M /trunk/src/chrome/test/browser_with_test_window_test.h
   M /trunk/src/chrome/test/test_tab_contents.cc
   M /trunk/src/chrome/test/test_tab_contents.h

Remove auto commit from TestTabContents. This is the thing preventing me from
replacing it with WebContents. Fortunately, only one test was affected.
Review URL: http://codereview.chromium.org/66003
------------------------------------------------------------------------
r13526 | estade@chromium.org | 2009-04-10 21:26:32 +0200 (Fri, 10 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h

GTK: implement link info bars (first cut).

Also make GetIcon a function in InfoBarDelegate since all its inheritors have a function of that name, and putting it in InfoBarDelegate allows us to make InfoBar more generic.

Review URL: http://codereview.chromium.org/66025
------------------------------------------------------------------------
r13525 | estade@chromium.org | 2009-04-10 21:25:17 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   A /trunk/src/chrome/browser/gtk/link_button_gtk.cc
   A /trunk/src/chrome/browser/gtk/link_button_gtk.h
   M /trunk/src/chrome/chrome.gyp

Factor out MakeLinkButton into its own class.

This also gets rid of the event box, which means we can stick it in widgets that are custom painted.
Review URL: http://codereview.chromium.org/66023
------------------------------------------------------------------------
r13522 | pinkerton@chromium.org | 2009-04-10 21:01:08 +0200 (Fri, 10 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Take two converting to scoped pointers, without ui_test failures.
Review URL: http://codereview.chromium.org/67039
------------------------------------------------------------------------
r13518 | erg@google.com | 2009-04-10 19:58:48 +0200 (Fri, 10 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Fill in NOTIMPLEMENTEDs in BookmarkBarGtk. Can now reorder bookmarks.

Review URL: http://codereview.chromium.org/66022
------------------------------------------------------------------------
r13516 | willchan@chromium.org | 2009-04-10 19:37:16 +0200 (Fri, 10 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fix gcc warnings when -Wall got re-enabled for Linux.

browser/gtk/bookmark_bar_gtk.cc: In static member function 'static gboolean BookmarkBarGtk::OnToolbarDragLeave(GtkToolbar*, GdkDragContext*, guint, BookmarkBarGtk*)':
browser/gtk/bookmark_bar_gtk.cc:372: warning: control reaches end of non-void function
/usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h: In constructor 'TabRendererGtk::TabRendererGtk()':
/usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h:241: warning: 'TabRendererGtk::loading_animation_' will be initialized after
/usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h:238: warning:   'TabRendererGtk::CloseButtonState TabRendererGtk::close_button_state_'
browser/gtk/tabs/tab_renderer_gtk.cc:139: warning:   when initialized here
browser/gtk/tabs/tab_strip_gtk.cc: In member function 'GdkRegion* NewTabButton::MakeRegionForButton() const':
browser/gtk/tabs/tab_strip_gtk.cc:152: warning: unused variable 'h'

Review URL: http://codereview.chromium.org/67038
------------------------------------------------------------------------
r13515 | jcampan@chromium.org | 2009-04-10 18:57:58 +0200 (Fri, 10 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

The dialog delegate for the in-progress download warning was deleted twice. It is the content view for the dialog and as such is automatically deleted when the dialog is closed.
So it does not need to delete itself on the DeleteDelegate() callback.
We were also leaking the label_.

BUG=9959
TEST=Start a big download, close the browser while the download is in progress. A dialog pops-up. Try the close button. The browser should close (and not crash!). Try again but this time with "Wait for donwloads to finish". 

Review URL: http://codereview.chromium.org/66038
------------------------------------------------------------------------
r13512 | pinkerton@chromium.org | 2009-04-10 18:43:01 +0200 (Fri, 10 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

backing out r13504 due to ui_test issues
------------------------------------------------------------------------
r13506 | pinkerton@chromium.org | 2009-04-10 18:09:01 +0200 (Fri, 10 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h

Fix dtor ordering, browser must destruct last.
------------------------------------------------------------------------
r13504 | pinkerton@chromium.org | 2009-04-10 17:46:34 +0200 (Fri, 10 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/build/common.gypi
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Force c++ dtors to get called in objc interfaces (it was always on since gcc4.2, but this makes it explicit). Use scoped_* goodness.
Review URL: http://codereview.chromium.org/70001
------------------------------------------------------------------------
r13502 | pfeldman@chromium.org | 2009-04-10 15:52:30 +0200 (Fri, 10 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/debugger_remote_service.cc
   A /trunk/src/chrome/browser/debugger/debugger_remote_service.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   A /trunk/src/chrome/browser/debugger/devtools_protocol_handler.cc
   A /trunk/src/chrome/browser/debugger/devtools_protocol_handler.h
   A /trunk/src/chrome/browser/debugger/devtools_remote.h
   A /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc
   A /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.h
   A /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
   A /trunk/src/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
   A /trunk/src/chrome/browser/debugger/devtools_remote_message.cc
   A /trunk/src/chrome/browser/debugger/devtools_remote_message.h
   A /trunk/src/chrome/browser/debugger/devtools_remote_message_unittest.cc
   A /trunk/src/chrome/browser/debugger/devtools_remote_service.cc
   A /trunk/src/chrome/browser/debugger/devtools_remote_service.h
   A /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.cc
   A /trunk/src/chrome/browser/debugger/inspectable_tab_proxy.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

DevTools. Add V8 Application Remote Debugging Protocol support by apavlov. Original CL: http://codereview.chromium.org/56109

Review URL: http://codereview.chromium.org/66031
------------------------------------------------------------------------
r13497 | rafaelw@chromium.org | 2009-04-10 06:23:12 +0200 (Fri, 10 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   A /trunk/src/chrome/test/data/extensions/test
   A /trunk/src/chrome/test/data/extensions/test/TabsAPI
   A /trunk/src/chrome/test/data/extensions/test/TabsAPI/1
   A /trunk/src/chrome/test/data/extensions/test/TabsAPI/1/jstemplate_compiled.js
   A /trunk/src/chrome/test/data/extensions/test/TabsAPI/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/test/TabsAPI/1/tabs_api.html
   A /trunk/src/chrome/test/data/extensions/test/TabsAPI/Current Version

Flesh out more extensions tab api (added getTab, removeTab, updateTab)

Review URL: http://codereview.chromium.org/62178
------------------------------------------------------------------------
r13491 | ben@chromium.org | 2009-04-10 04:37:22 +0200 (Fri, 10 Apr 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/search_engines/template_url_scraper_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/unittest_test_server.h

Scrape search definitions from forms that have onsubmit handlers. The scraping is done after submit events are handled by the page DOM so doing this is safe.

Adds test infrastructure for determining that scraping occurs on submit:
- allow testserver to be configured to serve pages from / on the server
- provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission

Eric, please review the test server changes.
Scott, please look over everything else.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13444
Review URL: http://codereview.chromium.org/62145
------------------------------------------------------------------------
r13490 | jhawkins@chromium.org | 2009-04-10 04:00:51 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Remove instances of the New Tab button images that are not being used anymore.

TBR=tony
Review URL: http://codereview.chromium.org/66027
------------------------------------------------------------------------
r13489 | jhawkins@chromium.org | 2009-04-10 03:58:54 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Comment the unselected_width parameter to the newly-added LayoutNewTabButton method.  Also remove some c-style comments that slipped in.

TBR=evan
Review URL: http://codereview.chromium.org/66026
------------------------------------------------------------------------
r13487 | jhawkins@chromium.org | 2009-04-10 03:24:08 +0200 (Fri, 10 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add the New Tab button for Linux tabstrip.
Review URL: http://codereview.chromium.org/67025
------------------------------------------------------------------------
r13486 | aa@chromium.org | 2009-04-10 03:01:15 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_content_script_inject_unittest.cc

Remove content script unit test. Too flakey. Will revisit
and try to use something lower-level, like a RenderView directly.

Review URL: http://codereview.chromium.org/66021
------------------------------------------------------------------------
r13478 | sgk@google.com | 2009-04-10 00:51:41 +0200 (Fri, 10 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/build/all.gyp
   M /trunk/src/build/common.gypi
   M /trunk/src/build/external_code.gypi
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/third_party/ffmpeg/ffmpeg.gyp
   M /trunk/src/third_party/harfbuzz/harfbuzz.gyp
   M /trunk/src/third_party/libevent/libevent.gyp
   M /trunk/src/webkit/webkit.gyp

Restore -Wall to Linux build and set up for -Werror.
* Add -Wall to build/common.gypi (and -Werror, commented out for now).
* Have build/external_code.gypi remove -Wall (and -Werror).
* Remove chromium_code definition from build/all.gyp.
* Remove chromium_code definitions from third_party/ *.gyp files.
* Remove scons-specific -Werror removal in webkit.gyp.
* Remove unused variables from:
  base/clipboard_linux.cc
  chrome/browser/gtk/download_shelf_gtk.cc
  chrome/browser/gtk/bookmark_bar_gtk.cc
Review URL: http://codereview.chromium.org/66001
------------------------------------------------------------------------
r13475 | tim@chromium.org | 2009-04-10 00:43:55 +0200 (Fri, 10 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

The profile Source parameter of a BookmarkModelLoaded event can be null during testing.
MetricsService and WebContents weren't handling this case properly.

Review URL: http://codereview.chromium.org/66007
------------------------------------------------------------------------
r13467 | thestig@chromium.org | 2009-04-09 23:59:04 +0200 (Thu, 09 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc

Change the download UI not to report xx bytes of 0 bytes. Just report "xx bytes" instead, so this does not require additional translations.

BUG=9782

Review URL: http://codereview.chromium.org/67005
------------------------------------------------------------------------
r13466 | tc@google.com | 2009-04-09 23:56:29 +0200 (Thu, 09 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Fix ctrl+tab/ctrl+shift+tab were not working if web contents did not have focus (e.g., location bar or find bar had focus).  Refactor the special keypress handling so these accelerators work when gtk widgets have focus.

Review URL: http://codereview.chromium.org/67011

------------------------------------------------------------------------
r13465 | willchan@chromium.org | 2009-04-09 23:47:55 +0200 (Thu, 09 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Cleanup small mistakes from my previous changelists.
Fix GoButtonGtkTest.ChangeModeStop test to call what it's actually supposed to test.
Replace tabs with spaces in chrome.gyp.  Also delete a double entry I added earlier.

Review URL: http://codereview.chromium.org/62190
------------------------------------------------------------------------
r13464 | estade@chromium.org | 2009-04-09 23:46:15 +0200 (Thu, 09 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h

UI test portage, second try.

first try here: <http://codereview.chromium.org/63149>

Review URL: http://codereview.chromium.org/67006
------------------------------------------------------------------------
r13463 | erg@google.com | 2009-04-09 23:36:05 +0200 (Thu, 09 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   M /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h

Use two CustomDrawButtonBases to draw ToolbarStarToggleGtk.

Review URL: http://codereview.chromium.org/67012
------------------------------------------------------------------------
r13458 | brettw@chromium.org | 2009-04-09 23:06:59 +0200 (Thu, 09 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Fix a flicker of the URL bar after you enter it. The code
inBrowser::OpenURLFromTab was not using the current tab when no source was
specified. This means we didn't update the correct tab.

This change uses the computed current URL for updating, and also clarifies the
comments in the TabContentsDelegate about what NULL means.

BUG=9799
Review URL: http://codereview.chromium.org/63125
------------------------------------------------------------------------
r13457 | ben@chromium.org | 2009-04-09 22:53:04 +0200 (Thu, 09 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc

Disable inactive rendering for the frame before select popups are initialized, since initializing shows them which causes activation to change.

This fixes the regression where select widgets deactivated the frame.s

Review URL: http://codereview.chromium.org/67008
------------------------------------------------------------------------
r13455 | pinkerton@chromium.org | 2009-04-09 22:49:26 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Re-order the steps used to create the new browser window on a tab drag in order to make sure the TabContents' delegate doesn't get clobbered. Fix the define of a file that had been moved a while ago.
Review URL: http://codereview.chromium.org/67007
------------------------------------------------------------------------
r13453 | jcampan@chromium.org | 2009-04-09 22:40:06 +0200 (Thu, 09 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

This CL adds a confirmation box when closing the browser with in-progress downloads.

BUG=1028
TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode.
Review URL: http://codereview.chromium.org/62131
------------------------------------------------------------------------
r13452 | erg@google.com | 2009-04-09 22:28:19 +0200 (Thu, 09 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   A /trunk/src/chrome/browser/gtk/gtk_chrome_button.cc
   A /trunk/src/chrome/browser/gtk/gtk_chrome_button.h
   M /trunk/src/chrome/chrome.gyp

Make CustomContainerButton a gtk widget.

Review URL: http://codereview.chromium.org/62171
------------------------------------------------------------------------
r13451 | jianli@chromium.org | 2009-04-09 22:19:25 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc

Fix empty title for worker process host when running the worker from a url without domain.
Review URL: http://codereview.chromium.org/63147
------------------------------------------------------------------------
r13450 | jhawkins@chromium.org | 2009-04-09 22:13:22 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/url_constants.cc

Make about:linux-splash the default home page and remove an ifdef so we can see the NTP for new tabs.
Review URL: http://codereview.chromium.org/65018
------------------------------------------------------------------------
r13448 | ben@chromium.org | 2009-04-09 21:48:55 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   D /trunk/src/chrome/browser/search_engines/template_url_scraper_unittest.cc
   M /trunk/src/chrome/test/data/template_url_scraper
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/unittest_test_server.h

revert until I can figure out why the tests are hanging

------------------------------------------------------------------------
r13447 | mpcomplete@google.com | 2009-04-09 21:33:20 +0200 (Thu, 09 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   A /trunk/src/chrome/browser/extensions/extension_process_manager.cc
   A /trunk/src/chrome/browser/extensions/extension_process_manager.h
   A /trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Introducing ExtensionProcessManager.  This manages the ExtensionViews to
ensure there is only 1 process per extension.

I also changed ExtensionMessageService from singleton to one instance per
Profile.  This means messages can only be passed to extensions and scripts
within the same profile.
Review URL: http://codereview.chromium.org/62132
------------------------------------------------------------------------
r13446 | finnur@chromium.org | 2009-04-09 21:21:04 +0200 (Thu, 09 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Find window keyboard forwarding, part 2.

Also prevent Ctrl+Home and Ctrl+End from being eaten by
the Find window.

Review URL: http://codereview.chromium.org/62180
------------------------------------------------------------------------
r13444 | ben@chromium.org | 2009-04-09 21:10:41 +0200 (Thu, 09 Apr 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/search_engines/template_url_scraper_unittest.cc
   A /trunk/src/chrome/test/data/template_url_scraper
   A /trunk/src/chrome/test/data/template_url_scraper/submit_handler
   A /trunk/src/chrome/test/data/template_url_scraper/submit_handler/index.html
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/unittest_test_server.h

Scrape search definitions from forms that have onsubmit handlers. The scraping is done after submit events are handled by the page DOM so doing this is safe.

Adds test infrastructure for determining that scraping occurs on submit:
- allow testserver to be configured to serve pages from / on the server
- provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission

Eric, please review the test server changes.
Scott, please look over everything else.
Review URL: http://codereview.chromium.org/62145
------------------------------------------------------------------------
r13443 | estade@chromium.org | 2009-04-09 20:56:16 +0200 (Thu, 09 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

back out r13442

TBR=pinkerton

------------------------------------------------------------------------
r13442 | estade@chromium.org | 2009-04-09 20:49:02 +0200 (Thu, 09 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

UI test string portage.

These files now compile on linux (but they don't link) and they still pass windows. When Pawel gets done with his changes to UI test stuff, we should be able to just enable these tests.

The changes to chrome.gyp are just to fix lint errors.
Review URL: http://codereview.chromium.org/63149
------------------------------------------------------------------------
r13441 | pinkerton@chromium.org | 2009-04-09 20:44:51 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/en.lproj/TabContents.xib
   A /trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/command_observer_bridge.h
   A /trunk/src/chrome/browser/cocoa/command_observer_bridge.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/toolbar_controller.h
   A /trunk/src/chrome/browser/cocoa/toolbar_controller.mm
   M /trunk/src/chrome/chrome.gyp

Flatten down to a single toolbar per window, significantly simplifying the tab strip as it now no longer needs to forward messages for everything. Created a toolbar controller to encapsulate much of the toolbar logic that was in the tab contents controller. Better parameterized the tab strip controller so that it could switch any view, not just the main window's content view, when switching tabs.
Review URL: http://codereview.chromium.org/65011
------------------------------------------------------------------------
r13440 | jhawkins@chromium.org | 2009-04-09 20:40:51 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add a resize layout animation to the Linux tabstrip.
Review URL: http://codereview.chromium.org/65014
------------------------------------------------------------------------
r13437 | tc@google.com | 2009-04-09 20:17:09 +0200 (Thu, 09 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog.h
   A /trunk/src/chrome/browser/app_modal_dialog_gtk.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/chrome.gyp

Actually implement js message boxes on linux.  This handles
alert, confirm and onbeforeunload.  prompt has a dialog, but there's
no text field.  I'll work on that next.

It turns out there's no nested message loop on the windows side,
so there's no nested message loop here either.

BUG=9493

Review URL: http://codereview.chromium.org/63134

------------------------------------------------------------------------
r13435 | thestig@chromium.org | 2009-04-09 19:47:35 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/password_manager/encryptor.cc
   A /trunk/src/chrome/browser/password_manager/encryptor_linux.cc
   A /trunk/src/chrome/browser/password_manager/encryptor_mac.mm
   A /trunk/src/chrome/browser/password_manager/encryptor_win.cc (from /trunk/src/chrome/browser/password_manager/encryptor.cc:10748)
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add dummy encryptor implementations for mac and linux.
Review URL: http://codereview.chromium.org/43095
------------------------------------------------------------------------
r13433 | jhawkins@chromium.org | 2009-04-09 19:45:51 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add a remove tab animation for the Linux tabstrip.
Review URL: http://codereview.chromium.org/64004
------------------------------------------------------------------------
r13427 | erg@google.com | 2009-04-09 18:39:07 +0200 (Thu, 09 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc

Add a const cast.

Review URL: http://codereview.chromium.org/62172
------------------------------------------------------------------------
r13426 | maruel@chromium.org | 2009-04-09 18:36:44 +0200 (Thu, 09 Apr 2009) | 52 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/page_overlays.cc
   M /trunk/src/chrome/browser/printing/page_overlays.h
   M /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Implement Printer Preference Persistence (Step 1/3)

Introduce new "Preferences" for printer overlays were added in PrefNames:  
- printing.page.header.left  
- printing.page.header.center 
- printing.page.header.right 
- printing.page.footer.left 
- printing.page.footer.center 
- printing.page.footer.right

The prefs file will look like this:

"printing": {
   "page": {
      "header": {
         "left": " ",
         "center": " ",
         "right": " "
      },
      "footer": {
         "left": "{date}",
         "center": " ",
         "right": " "
      }
   }
}

The steps for Printer Preferences:

Step 1:
 Introduce some sort of persistence for header/footer which is located 
in the Preference file.

Step 2:
 Allow PrinterQuery to read those stored preferences and setup 
PrinterSettings so that it will apply it when printing.

Step 3:
 Create a UI for the print preference, so that the users will easily 
change those printing settings.

NOTE: I tested the following approach while doing a simple Hack with 
PrintJob (if you see the previous patch), and it works great, with some 
bad after effect.
It was done for testing purposes. So I hope we are going in the right
direction.

BUG=947 (http://crbug.com/947)

Patch contributed by Mohamed Mansour <m0.interactive@gmail.com>

Review: http://codereview.chromium.org/60118/show
------------------------------------------------------------------------
r13423 | pfeldman@chromium.org | 2009-04-09 18:09:43 +0200 (Thu, 09 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/devtools/js/net_agent.js
   M /trunk/src/webkit/glue/devtools/net_agent.h
   M /trunk/src/webkit/glue/devtools/net_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/net_agent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webview_impl.cc

DevTools: Cache resources before attach, hide agents behind the flag.

Review URL: http://codereview.chromium.org/65010
------------------------------------------------------------------------
r13421 | pfeldman@chromium.org | 2009-04-09 17:05:55 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/devtools/js/net_agent.js
   M /trunk/src/webkit/glue/devtools/net_agent.h
   M /trunk/src/webkit/glue/devtools/net_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/net_agent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webview_impl.cc

Reverting 13419.
Review URL: http://codereview.chromium.org/65008
------------------------------------------------------------------------
r13419 | pfeldman@chromium.org | 2009-04-09 16:39:32 +0200 (Thu, 09 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/devtools/js/net_agent.js
   M /trunk/src/webkit/glue/devtools/net_agent.h
   M /trunk/src/webkit/glue/devtools/net_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/net_agent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webview_impl.cc

DevTools: Cache resource metainfo even when debugger agent is not attached.
- Cache 200 resources
- Hide agent functionality behind the flag
Review URL: http://codereview.chromium.org/62183
------------------------------------------------------------------------
r13413 | deanm@chromium.org | 2009-04-09 12:21:57 +0200 (Thu, 09 Apr 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h

Move to custom painting the omnibox results with GDK.

- Don't draw with ChromeCanvas, we will have better text layout by using
  Pango directly, and better remote X performance by not blitting a bitmap.
- Text is draw with Pango on top of GDK (no Cairo inbetween).
- Double buffered server side, and just a few GDK operations for rects.
- Improve our handling of InvalidateLine / PaintUpdatesNow.  We previously
  always invalidated the entire window.  We now communicate with the model
  the way we should, and only invalidate damaged lines, and then do a sync
  paint in PaintUpdatesNow to repaint them.

This is a small step backwards, because we are no longer showing the
description text.  This easy to fix, but I'm going to try to implement the
entire new results look and icons at the same time.

Review URL: http://codereview.chromium.org/63119

------------------------------------------------------------------------
r13409 | willchan@chromium.org | 2009-04-09 08:40:57 +0200 (Thu, 09 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   A /trunk/src/chrome/browser/gtk/go_button_gtk.cc
   A /trunk/src/chrome/browser/gtk/go_button_gtk.h
   A /trunk/src/chrome/browser/gtk/go_button_gtk_unittest.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/chrome.gyp

Implement stop/go button for Linux.
Refactored code out of CustomDrawButton into CustomDrawButtonBase to be shared with GoButtonGtk.
Replaced the existing non-togglable go button with GoButtonGtk.
Note that tooltip support isn't done yet, as it changes based on the state of the location bar and the go/stop state.
Add a simple test.
Fix some minor lint errors.
BUG=9381

Review URL: http://codereview.chromium.org/62154
------------------------------------------------------------------------
r13406 | rafaelw@chromium.org | 2009-04-09 03:49:11 +0200 (Thu, 09 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_function.cc

Check that the ExtensionFunction has a callback for attempting to send a response.

Review URL: http://codereview.chromium.org/63130
------------------------------------------------------------------------
r13402 | jhawkins@chromium.org | 2009-04-09 03:15:31 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add an insert tab animation for the Linux tabstrip.
Review URL: http://codereview.chromium.org/62170
------------------------------------------------------------------------
r13401 | evan@chromium.org | 2009-04-09 03:14:29 +0200 (Thu, 09 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

linux: offset toolbar graphic so tabs merge in properly.

Review URL: http://codereview.chromium.org/63148
------------------------------------------------------------------------
r13399 | aa@chromium.org | 2009-04-09 03:06:17 +0200 (Thu, 09 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Fix leak in ChromeURLRequestContext. I read the code wrong; we
always want to delete the cache instance.

Review URL: http://codereview.chromium.org/63138
------------------------------------------------------------------------
r13398 | jcampan@chromium.org | 2009-04-09 03:03:11 +0200 (Thu, 09 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc

When a DOMUI dialog contains HTML with a select or a text-field which would have auto-fill, bringing the popup crashes the browser.  This is because the WebContentView may not have a delegate.

BUG=None
TEST=Requires code change, adding a select or a text-field to the Gears dialog for example.
Review URL: http://codereview.chromium.org/63146
------------------------------------------------------------------------
r13396 | estade@chromium.org | 2009-04-09 02:57:10 +0200 (Thu, 09 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Copy text selection from renderer to browser every time it changes.

BUG=9848
Review URL: http://codereview.chromium.org/63145
------------------------------------------------------------------------
r13395 | thestig@chromium.org | 2009-04-09 02:23:36 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Fix a missing #include in the mac source.
Review URL: http://codereview.chromium.org/62169
------------------------------------------------------------------------
r13394 | thestig@chromium.org | 2009-04-09 01:47:46 +0200 (Thu, 09 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Scaffolding cleanup.
Review URL: http://codereview.chromium.org/63142
------------------------------------------------------------------------
r13393 | ben@chromium.org | 2009-04-09 01:46:17 +0200 (Thu, 09 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Distributor logo and " - App Name" shouldn't be shown on app frame windows.

http://crbug.com/6138

Review URL: http://codereview.chromium.org/62167
------------------------------------------------------------------------
r13390 | estade@chromium.org | 2009-04-09 01:38:17 +0200 (Thu, 09 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc

Linux: Hook up confirm info bar buttons. Session restore works.

Review URL: http://codereview.chromium.org/62163
------------------------------------------------------------------------
r13389 | finnur@chromium.org | 2009-04-09 01:38:16 +0200 (Thu, 09 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/controls/text_field.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

When the Find bar has focus it eats keypresses such as PageUp, PageDown and Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar.

This patch forwards those selected keypresses to the page for its perusal.

Known issues: Just like Firefox, the page doesn't scroll if it has frames.

SONG=I like to fixit fixit. I like to fixit fixit.
BUG=7079
TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F.
Review URL: http://codereview.chromium.org/62129
------------------------------------------------------------------------
r13388 | estade@chromium.org | 2009-04-09 01:38:16 +0200 (Thu, 09 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc

Properly handle empty components when converting url_parse::Parsed object.

Add a unittest for the below bug.

BUG=9859

Review URL: http://codereview.chromium.org/62162
------------------------------------------------------------------------
r13382 | jhawkins@chromium.org | 2009-04-08 23:58:19 +0200 (Wed, 08 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Implement mouse input handling for the close button in the Linux tabstrip.
Review URL: http://codereview.chromium.org/63136
------------------------------------------------------------------------
r13378 | hclam@chromium.org | 2009-04-08 22:13:38 +0200 (Wed, 08 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc

Use histogram in AudioRendererHost to measure IPC audio latency
Measure ICP audio latency using histogram.

Review URL: http://codereview.chromium.org/63128
------------------------------------------------------------------------
r13376 | thestig@chromium.org | 2009-04-08 22:06:33 +0200 (Wed, 08 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.h

Remove more unneeded scaffolding.
Review URL: http://codereview.chromium.org/63129
------------------------------------------------------------------------
r13371 | mpcomplete@google.com | 2009-04-08 20:35:34 +0200 (Wed, 08 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/renderer/extensions/bindings_utils.h
   A /trunk/src/chrome/renderer/extensions/event_bindings.cc
   A /trunk/src/chrome/renderer/extensions/event_bindings.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/renderer/renderer_resources.grd
   A /trunk/src/chrome/renderer/resources/event_bindings.js
   M /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html

Add aa's Event class to our javascript bindings and use it in our extension
message passing API.
Review URL: http://codereview.chromium.org/62069
------------------------------------------------------------------------
r13369 | aa@chromium.org | 2009-04-08 20:33:30 +0200 (Wed, 08 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   A /trunk/src/chrome/browser/extensions/extension_content_script_inject_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   A /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   A /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   A /trunk/src/chrome/test/data/extensions/content_script_inject/js_test.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script1.css
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script1a.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script1b.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script2.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script3.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject_page.html
   M /trunk/src/chrome/test/data/purify/unit_tests.exe_MLK.txt
   M /trunk/src/chrome/test/data/purify/unit_tests.exe_UMR.txt
   M /trunk/src/chrome/test/unit/unittests.vcproj

Try one more time to check in http://codereview.chromium.org/60112

Added this test to the list of skipped purify tests as it is
experience the same issue as ExtensionView test.

I also found an unrelated memory leak and created a patch
separately: http://codereview.chromium.org/63073

Review URL: http://codereview.chromium.org/63075
------------------------------------------------------------------------
r13367 | evan@chromium.org | 2009-04-08 20:18:25 +0200 (Wed, 08 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/iframe_uitest.cc

linux: temporarily disable a test due to flakiness.

Relevant bugs have been filed.

TBR=tony

Review URL: http://codereview.chromium.org/64001
------------------------------------------------------------------------
r13364 | jcampan@chromium.org | 2009-04-08 19:45:25 +0200 (Wed, 08 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Ensure the previous/next button don't get focused when clicked.
We keep the button focusable so they can be tab traversed.

BUG=9772
TEST=See bug
Review URL: http://codereview.chromium.org/62144
------------------------------------------------------------------------
r13362 | pfeldman@chromium.org | 2009-04-08 19:30:16 +0200 (Wed, 08 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/webkit/glue/devtools/dom_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/dom_agent_impl.h
   M /trunk/src/webkit/glue/devtools/dom_agent_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/debugger_agent.js
   M /trunk/src/webkit/glue/devtools/js/dom_agent.js
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc

DevTools: Fix errors found during dogfooding.

Review URL: http://codereview.chromium.org/62152
------------------------------------------------------------------------
r13361 | sidchat@google.com | 2009-04-08 19:29:24 +0200 (Wed, 08 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

Fix issue 7337, where a file of mime type "text/x-registry" with extension "reg" was getting saved with extension "download" instead.

Issue=7337
Review URL: http://codereview.chromium.org/58007
------------------------------------------------------------------------
r13360 | amit@chromium.org | 2009-04-08 19:03:03 +0200 (Wed, 08 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

Fix mouse wheel redirection when omnibox has focus

Since focus manager subclass now no longer handlers mouse wheel
redirection, handle WM_MOUSEWHEEL in autocomplete_edit_view_win
and give other windows chance to handle mouse wheel.


Bug 9647


Review URL: http://codereview.chromium.org/63061
------------------------------------------------------------------------
r13357 | pkasting@chromium.org | 2009-04-08 18:38:19 +0200 (Wed, 08 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc

Attempt to fix crash that I don't fully understand and can't repro :(

BUG=8933
Review URL: http://codereview.chromium.org/63085
------------------------------------------------------------------------
r13355 | pinkerton@chromium.org | 2009-04-08 18:14:06 +0200 (Wed, 08 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/ui/dom_checker_uitest.cc

Enable a bunch of ui tests on Mac.
Review URL: http://codereview.chromium.org/63122
------------------------------------------------------------------------
r13350 | deanm@chromium.org | 2009-04-08 16:49:56 +0200 (Wed, 08 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc

Remove our only use of dynamic_cast, which is not needed.

We don't want to ever use RTTI.  This was casting a WebContents to a
TabContents, which is a simple and safe upcase, since WebContents derives from
TabContents.  It should have just been a static_cast.

Review URL: http://codereview.chromium.org/62147

------------------------------------------------------------------------
r13348 | idanan@chromium.org | 2009-04-08 16:14:35 +0200 (Wed, 08 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Added restore and add tab to the system menu so that these operations
can be done from there.

BUG=2144

Review URL: http://codereview.chromium.org/62113
------------------------------------------------------------------------
r13346 | pinkerton@chromium.org | 2009-04-08 15:46:34 +0200 (Wed, 08 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   A /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h
   A /trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
   M /trunk/src/chrome/chrome.gyp

Refactor tab model observer for cocoa into a separate class so it can be re-used. Mark tab as visible when switching to it so tabs loaded in the background work.
Review URL: http://codereview.chromium.org/63087
------------------------------------------------------------------------
r13343 | abarth@chromium.org | 2009-04-08 08:11:34 +0200 (Wed, 08 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/media/data_source_impl.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/worker/test_worker_main.cc
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/unittest_test_server.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Revert 12739, 12740, and 12741 because we're going to fix Issue 7448 purely in WebKit.
------------------------------------------------------------------------
r13342 | shess@chromium.org | 2009-04-08 06:53:50 +0200 (Wed, 08 Apr 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   A /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   A /trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/chrome.gyp

Move location bar bridge out of tab_contents_controller.

[So that I don't keep getting conflicts as I work to finish the omnibox change
  http://codereview.chromium.org/50074
]

Review URL: http://codereview.chromium.org/63096
------------------------------------------------------------------------
r13340 | estade@chromium.org | 2009-04-08 06:28:25 +0200 (Wed, 08 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h

Temporary fix for omnibox crash.

BUG=9760

Review URL: http://codereview.chromium.org/63095
------------------------------------------------------------------------
r13339 | jar@chromium.org | 2009-04-08 06:22:44 +0200 (Wed, 08 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/net/http/http_network_session.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/net.gyp

DNS prefetch experiment extension: Consider different connection count limits

This CL both enables selection of a run-time selected limit
on the number of connections to a single host, and varies
that limit to see how it relates to DNS prefetch latency
in connections.

r=wtc
Review URL: http://codereview.chromium.org/62083
------------------------------------------------------------------------
r13336 | estade@chromium.org | 2009-04-08 04:41:38 +0200 (Wed, 08 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Stuff needed for alert info bars.

TBR=evan

Review URL: http://codereview.chromium.org/63111
------------------------------------------------------------------------
r13334 | evan@chromium.org | 2009-04-08 04:00:48 +0200 (Wed, 08 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

linux: don't crash on alert infobars.

estade didn't sufficiently test his change.  Luckily, the fix is trivial.

TBR=estade

Review URL: http://codereview.chromium.org/62138
------------------------------------------------------------------------
r13331 | evan@chromium.org | 2009-04-08 03:44:20 +0200 (Wed, 08 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

posix: implement AutomationWindowTracker.

Review URL: http://codereview.chromium.org/62135
------------------------------------------------------------------------
r13329 | estade@chromium.org | 2009-04-08 03:34:55 +0200 (Wed, 08 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   M /trunk/src/chrome/browser/gtk/infobar_gtk.h

More info bar implementation.

Review URL: http://codereview.chromium.org/62136
------------------------------------------------------------------------
r13326 | ananta@chromium.org | 2009-04-08 03:26:07 +0200 (Wed, 08 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Support the new popup and new window dispositions in the external tab container. 

Disabled the TRACK_HWND_DESTRUCTION macro in render_widget_host_view_win.cc as it fires consistently
for the external tab container probably due to multiple WM_DESTROY messages received for the
container, when the parent window is destroyed. 

Fixes bug http://b/issue?id=1747547

Bug=1747547

Review URL: http://codereview.chromium.org/63074
------------------------------------------------------------------------
r13325 | jhawkins@chromium.org | 2009-04-08 03:25:09 +0200 (Wed, 08 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Fix a crash on tab closure.  We now use our own model data and check that the hovering index is not out of bounds.

BUG=9803
Review URL: http://codereview.chromium.org/62133
------------------------------------------------------------------------
r13322 | erg@google.com | 2009-04-08 03:05:13 +0200 (Wed, 08 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h

Reimplement the bookmark bar to use a GtkToolbar.

Add all bookmark buttons to a GtkToolbar. All bookmark buttons are draggable,
though we don't accept drops yet since I still need to figure out how to
communicate with the model.

Review URL: http://codereview.chromium.org/63099
------------------------------------------------------------------------
r13320 | aa@chromium.org | 2009-04-08 03:00:17 +0200 (Wed, 08 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc

hclam: picked you for this review based on the revision log of ChromeURLRequestContext, but feel free to redirect if there is someone better.

Fix leak of media_request_context_. This is kind of a nasty
fix though. I think that ChromeURLRequestContext needs to be
refactored more, but not sure exactly how right now. If you
don't like this fix, I won't feel bad nuking it and letting
someone working on this area handle it.

Review URL: http://codereview.chromium.org/63073
------------------------------------------------------------------------
r13313 | cpu@google.com | 2009-04-08 02:20:32 +0200 (Wed, 08 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_win.cc

Greatly reduce the race window in ProcessSingleton
- fix only for windows
- Anantha has a good test to be commited RSN

BUG=9593

Review URL: http://codereview.chromium.org/57082
------------------------------------------------------------------------
r13312 | huanr@chromium.org | 2009-04-08 02:04:27 +0200 (Wed, 08 Apr 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.cc
   A /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_base.h
   A /trunk/src/chrome/test/automated_ui_tests/automated_ui_test_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.vcproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Skeleton setup for new Automated UI test framework.

- Add automated_ui_test_base.{cc,h} that defines an
AutomatedUITestBase class. This class can be used
for both UI test suites and automated UI test running
on ChromeBot.

- Add automated_ui_test_test and include it in UI
test suite so we can individually test all commands
provided in AutomatedUITestBase. 

- Change AutomatedUITest to be a subclass of
AutomatedUITestBase. Move RunCommandAsync(),
RunCommand(), and NewTab() from AutomatedUITest
to AutomatedUITestBase. The plan is moving all
individual UI command functions (after they are
converted to sync mode) to AutomatedUITestBase so
they can be shared by UI test suites and automated
UI test.

- In automation_provider.cc, add a mapping mechanism
from command to notification type. This will make it
easy to add more command types.

Review URL: http://codereview.chromium.org/56190
------------------------------------------------------------------------
r13311 | paulg@google.com | 2009-04-08 02:01:38 +0200 (Wed, 08 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Remove unused database code.

The new storage system doesn't check URLs on the DB thread
any longer, so this code is never called.

Review URL: http://codereview.chromium.org/62110
------------------------------------------------------------------------
r13310 | tc@google.com | 2009-04-08 01:57:13 +0200 (Wed, 08 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_factory_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

Fix the findbar crash.

FindBarController is no longer owned by the BrowserWindow, it is
owned by Browser.  So we can remove the FindBarController code in
BrowserWindowGtk.  Also, go ahead and implement
BrowserWindow::CreateFindBar (which creates the gtk widget and adds
it to the gtk widget hierarchy) and enable the code on linux.

Since the widgets are created and added to the hierarchy later,
we attach the signals after the widgets have been "realized".

Review URL: http://codereview.chromium.org/62126

------------------------------------------------------------------------
r13305 | darin@chromium.org | 2009-04-08 01:24:58 +0200 (Wed, 08 Apr 2009) | 23 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/worker/test_worker_main.cc
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   D /trunk/src/webkit/glue/clipboard_conversion.cc
   D /trunk/src/webkit/glue/clipboard_conversion.h
   M /trunk/src/webkit/glue/devtools/debugger_agent_impl.cc
   M /trunk/src/webkit/glue/dragclient_impl.cc
   M /trunk/src/webkit/glue/feed_preview.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/webdropdata.cc
   M /trunk/src/webkit/glue/webdropdata.h
   A /trunk/src/webkit/glue/webdropdata_win.cc (from /trunk/src/webkit/glue/webdropdata.cc:13286)
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/drag_delegate.cc
   M /trunk/src/webkit/tools/test_shell/drop_delegate.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/webkit.gyp

Switch to using WebDragData in WebView and WebViewDelegate.

I also cleaned up some of the WebView and WebViewDelegate methods to pass
WebPoint instead of pairs of ints or gfx::Point.

With this change, I am keeping webkit/glue/webdropdata.{h,cc}, which is what
Chrome uses to pass around the equivalent data.  Now, it is possible to
construct a WebDropData from a WebKit::WebDragData and to also get a
WebKit::WebDragData from a WebDropData.  Hence, the conversion between
WebDropData and ChromiumDataObject (see clipboard_conversion.{h,cc}) is now
removed in favor of conversion between WebDropData and WebKit::WebDragData.

Conversion between WebKit::WebDragData and WebCore::ChromiumDataObject is very
cheap (just reference counting).

Finally, this change also brings in WebData, which is now used by the return
value of WebKitClient::loadResource.  As a companion to that change, I also
changed webkit_glue::GetDataResource to return StringPiece instead of
std::string.  That also saves on an unnecessary buffer copy.

R=dglazkov

Review URL: http://codereview.chromium.org/63084
------------------------------------------------------------------------
r13302 | evan@chromium.org | 2009-04-08 01:21:31 +0200 (Wed, 08 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

linux: pass a bunch more ui tests.

Mostly random portability fixes: use portable functions, use FilePath, etc.

Review URL: http://codereview.chromium.org/62117
------------------------------------------------------------------------
r13288 | hclam@chromium.org | 2009-04-07 23:32:31 +0200 (Tue, 07 Apr 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/media/audio/audio_output.h
   M /trunk/src/media/audio/mac/audio_output_mac.cc
   M /trunk/src/media/audio/mac/audio_output_mac.h
   M /trunk/src/media/audio/win/audio_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.cc
   M /trunk/src/media/audio/win/waveout_output_win.h

Fix some threading issues and some refactoring in AudioRendererHost
1. AudioRendererHost should not wait on IO thread.
   Calling AudioOutputStream::Start requests some
   audio packets by calling IPCAudioSource::OnMoreData,
   resulting in a deadlock. I implemented a prefetching
   logic to solve this problem, source has to know
   how many internal buffers the implementation of
   AudioOutputStream is using and prepare the
   same amount of packets before calling
   AudioOutputStream::Start.
2. When IPCAudioSource::OnMoreData is waiting for
   packet to arrive, calling AudioOutputStream::Stop
   will result in a deadlock since it expects
   OnMoreData to return. Should wake up all waiting
   threads before calling AudioOutputStream::Stop.
3. Did some refactoring and move the message handlers
   completely into AudioRendererHost, it was clumsy
   to call to AudioRendererHost from ResourceMessageFilter.
   Also moved all logics of using shared memory for
   packet passing, prefetching to IPCAudioSource.
   AudioRendererHost is now merely a container that
   manages and delegates calls to IPCAudioSource. This
   refactoring is helpful because the next step is to
   implement standalone IPC channel for audio.
Review URL: http://codereview.chromium.org/57023
------------------------------------------------------------------------
r13286 | rvargas@google.com | 2009-04-07 23:24:58 +0200 (Tue, 07 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Disable user metrics reporting for chromium builds.

Review URL: http://codereview.chromium.org/62071
------------------------------------------------------------------------
r13285 | arv@chromium.org | 2009-04-07 23:21:12 +0200 (Tue, 07 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/resources/downloads.html

Cloned from 62030

Add a "Clear All" link to the downloads page.

Fixes jankiness of the blue bar in the download page as it loads.

Improve rendering time of the downloads page by chunking the number of
download items to do before scheduling the timeout.

BUG=9033

Review URL: http://codereview.chromium.org/62115
------------------------------------------------------------------------
r13282 | ben@chromium.org | 2009-04-07 23:09:58 +0200 (Tue, 07 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Re-land popup routing fix for browser.

Just the bugfix + test now. Test is disabled pending a working framework.

http://crbug.com/8472

Review URL: http://codereview.chromium.org/59007
------------------------------------------------------------------------
r13279 | jam@chromium.org | 2009-04-07 22:57:13 +0200 (Tue, 07 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Use one worker process per domain until we hit the maximum count of 10, then reuse processes.

Also add a test mode --webworker-process-per-core to create a worker process per worker until we hit the number of cores, then reuse.

Review URL: http://codereview.chromium.org/61001
------------------------------------------------------------------------
r13278 | tc@google.com | 2009-04-07 22:41:11 +0200 (Tue, 07 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fix a crash seen when trying to paste on linux.

Review URL: http://codereview.chromium.org/63069

------------------------------------------------------------------------
r13276 | tc@google.com | 2009-04-07 22:18:28 +0200 (Tue, 07 Apr 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/app_modal_dialog.cc
   A /trunk/src/chrome/browser/app_modal_dialog.h
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   A /trunk/src/chrome/browser/app_modal_dialog_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/js_before_unload_handler.h
   D /trunk/src/chrome/browser/js_before_unload_handler_win.cc
   D /trunk/src/chrome/browser/js_before_unload_handler_win.h
   A /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   D /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   D /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   A /trunk/src/chrome/browser/views/jsmessage_box_dialog.cc
   A /trunk/src/chrome/browser/views/jsmessage_box_dialog.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/views/views.vcproj
   D /trunk/src/chrome/views/window/app_modal_dialog_delegate.h

Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.

JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class.  This change converts it into an MVC so we can port to linux/mac.

AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view.

The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text.  I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text.

Review URL: http://codereview.chromium.org/63033
------------------------------------------------------------------------
r13275 | evan@chromium.org | 2009-04-07 22:02:15 +0200 (Tue, 07 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc

posix: the code path on either side of this ifdef is identical.

Looks like someone cleaned up the code but missed this part.

Review URL: http://codereview.chromium.org/63072
------------------------------------------------------------------------
r13273 | jcampan@chromium.org | 2009-04-07 21:58:03 +0200 (Tue, 07 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h

Disables the download item on the download-shelf when the file is opened.
This is to mitigate against multiple clicks when a file takes some time to show anything to the user when opened (typically a setup.exe).
By changing the title and disabling the button, we indicate to the user that an action was taken.

BUG=7264
TEST=Download a file (image for example). In the download shelf, press the download item. The download item text should change to "Opening..." and it should be disabled (not responsive to clicks/drag and drops).
Review URL: http://codereview.chromium.org/58014
------------------------------------------------------------------------
r13265 | thestig@chromium.org | 2009-04-07 21:22:27 +0200 (Tue, 07 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/common/jstemplate_builder.h
   M /trunk/src/chrome/test/v8_unit_test.h

Remove unneeded includes of base/string_piece.h
Review URL: http://codereview.chromium.org/62016
------------------------------------------------------------------------
r13260 | avi@google.com | 2009-04-07 19:47:52 +0200 (Tue, 07 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc

Fix "Save page as..." functionality. Fix by Roland Steiner.

http://codereview.chromium.org/63045

------------------------------------------------------------------------
r13258 | michaeln@google.com | 2009-04-07 19:45:54 +0200 (Tue, 07 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/common/app_cache
   A /trunk/src/chrome/common/app_cache/app_cache_context_impl.cc
   A /trunk/src/chrome/common/app_cache/app_cache_context_impl.h
   A /trunk/src/chrome/common/app_cache/app_cache_dispatcher.cc
   A /trunk/src/chrome/common/app_cache/app_cache_dispatcher.h
   A /trunk/src/chrome/common/app_cache/app_cache_dispatcher_host.cc
   A /trunk/src/chrome/common/app_cache/app_cache_dispatcher_host.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/media/data_source_impl.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/worker/test_worker_main.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/unittest_test_server.h
   A /trunk/src/webkit/glue/webappcachecontext.cc
   A /trunk/src/webkit/glue/webappcachecontext.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webresponse.h
   M /trunk/src/webkit/glue/webresponse_impl.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/webkit.gyp

Adds new messages and widens some existing messages between the renderer and browser processes to support an implementation of the HTML5AppCache spec with most of the logic running in the browser process.  The gist of most of the changes are to indicate which frame each resource request is coming from, and to indicate which appcache each response was retrieved from (if any).See https://docs.google.com/a/google.com/Doc?docid=agv6ghfsqr_15f749cgt3&hl=en
Review URL: http://codereview.chromium.org/9712
------------------------------------------------------------------------
r13257 | brettw@chromium.org | 2009-04-07 19:14:50 +0200 (Tue, 07 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Comment out a test that I accidentally uncommented in my previous CL.
------------------------------------------------------------------------
r13256 | brettw@chromium.org | 2009-04-07 19:05:06 +0200 (Tue, 07 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Clarify the documentation for loading_only on TabRenderer::UpdateData.
Review URL: http://codereview.chromium.org/63029
------------------------------------------------------------------------
r13255 | brettw@chromium.org | 2009-04-07 18:48:07 +0200 (Tue, 07 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   A /trunk/src/chrome/browser/renderer_host/render_view_host_factory.cc
   A /trunk/src/chrome/browser/renderer_host/render_view_host_factory.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/test_web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/chrome.gyp

Make the RenderViewHostFactory a global. This prevents us from having to pass
a factory pointer around all the time. Removing TestTabContents will require
making the Browser object keep track of the Factory pointer as well, so I think
the global is the best approach and cleans some things up.
Review URL: http://codereview.chromium.org/62044
------------------------------------------------------------------------
r13253 | ananta@chromium.org | 2009-04-07 18:13:45 +0200 (Tue, 07 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Updated the AutomationMsg_TabReposition IPC to be able to set the parent of a window.

Bug=1751431

Review URL: http://codereview.chromium.org/62042
------------------------------------------------------------------------
r13250 | deanm@chromium.org | 2009-04-07 16:47:39 +0200 (Tue, 07 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix a NOTREACHED in GTK accelerator handling when capslock is on.

BUG=9806

Review URL: http://codereview.chromium.org/62105

------------------------------------------------------------------------
r13249 | pinkerton@chromium.org | 2009-04-07 16:12:44 +0200 (Tue, 07 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Layout the tabs explicitly when creating a background tab. Update to correct tab model observer API so we once again get update messages.
Review URL: http://codereview.chromium.org/63022
------------------------------------------------------------------------
r13248 | deanm@chromium.org | 2009-04-07 15:57:22 +0200 (Tue, 07 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc

Destroy the GTK info bar container widget when the object is destroyed.

BUG=9802

Review URL: http://codereview.chromium.org/62104

------------------------------------------------------------------------
r13243 | aa@chromium.org | 2009-04-07 12:26:31 +0200 (Tue, 07 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   D /trunk/src/chrome/browser/extensions/extension_content_script_inject_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   D /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   D /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   D /trunk/src/chrome/test/data/extensions/content_script_inject/js_test.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script1.css
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script1a.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script1b.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script2.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject/script3.js
   D /trunk/src/chrome/test/data/extensions/content_script_inject_page.html
   M /trunk/src/chrome/test/unit/unittests.vcproj

Revert "Implement chromium.self in content scripts..."

This reverts commit 61ab30f52667e739602ab2af4fd8f2d8a0a2a2f0.

Still seeing memory errors.

Review URL: http://codereview.chromium.org/63056
------------------------------------------------------------------------
r13242 | phajdan.jr@chromium.org | 2009-04-07 12:17:12 +0200 (Tue, 07 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/layout_plugin_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/dom_operations_unittest.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/iframe_redirect_unittest.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlrequest_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.h

Switching things to FilePath:

Remove following deprecated wstring-using functions:

net/net_util: FilePathToFileURL
net/net_util: FileURLToFilePath

Switch net/base/upload_data to FilePath.
Switch upload-related parts of net/url_request/url_request to FilePath.

Made necessary adjustments in rest of code (a lot).

Review URL: http://codereview.chromium.org/63011
------------------------------------------------------------------------
r13241 | hbono@chromium.org | 2009-04-07 11:32:45 +0200 (Tue, 07 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

A quick fix for Issue 9596.
This issue is caused by my bonehead mistake in r4300: I misunderstand the behavior of Vista when we call the SetWindowsText() function. It actually cancels an ongoing composition. So, changing this behavior caused this regression.

To fix this issue, this change cancels an ongoing composition instead of completing it. As far as I tested on my XP PC, this fix works also on XP. 

BUG=9596
Review URL: http://codereview.chromium.org/60084
------------------------------------------------------------------------
r13238 | aa@chromium.org | 2009-04-07 10:01:50 +0200 (Tue, 07 Apr 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   A /trunk/src/chrome/browser/extensions/extension_content_script_inject_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   A /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   A /trunk/src/chrome/browser/extensions/test_extension_loader.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/chrome/renderer/user_script_slave.cc
   A /trunk/src/chrome/test/data/extensions/content_script_inject
   A /trunk/src/chrome/test/data/extensions/content_script_inject/js_test.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/manifest.json
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script1.css
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script1a.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script1b.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script2.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject/script3.js
   A /trunk/src/chrome/test/data/extensions/content_script_inject_page.html
   M /trunk/src/chrome/test/unit/unittests.vcproj

Implement chromium.self in content scripts, so that developers don't
have to know and copy/paste their extension ID.

This required moving the code that defaults the extension ID earlier
in the load process.

Also fixed some bugs:
* fixed a bug that was causing all user scripts to get executed in
  the same context.
* made the greasemonkey api only available in 'standalone' user
  scripts.
* re-added the anonymous function wrapper that is supposed to wrap
  content scripts.

Also added unit tests for the fixed bugs.

Review URL: http://codereview.chromium.org/60112
------------------------------------------------------------------------
r13237 | pfeldman@chromium.org | 2009-04-07 09:52:31 +0200 (Tue, 07 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

DevTools: tell agent it has client attached early (prior to the navigation).

Review URL: http://codereview.chromium.org/60115
------------------------------------------------------------------------
r13227 | shess@chromium.org | 2009-04-07 07:18:09 +0200 (Tue, 07 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   D /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   D /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   D /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   D /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   D /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   D /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp

Revert "Initial implemention of Mac Omnibox."

Reverts:
http://codereview.chromium.org/50074
http://src.chromium.org/viewvc/chrome?view=rev&revision=13201

Review URL: http://codereview.chromium.org/63047
------------------------------------------------------------------------
r13219 | estade@chromium.org | 2009-04-07 03:32:43 +0200 (Tue, 07 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc

Fix a selection clipboard leak.

BUG=9503

Review URL: http://codereview.chromium.org/62087
------------------------------------------------------------------------
r13215 | tim@chromium.org | 2009-04-07 02:49:05 +0200 (Tue, 07 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc

Support p13n HTML dialogs.

Review URL: http://codereview.chromium.org/62084
------------------------------------------------------------------------
r13206 | estade@chromium.org | 2009-04-07 01:33:08 +0200 (Tue, 07 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   A /trunk/src/chrome/browser/gtk/infobar_container_gtk.cc
   A /trunk/src/chrome/browser/gtk/infobar_container_gtk.h
   A /trunk/src/chrome/browser/gtk/infobar_gtk.cc
   A /trunk/src/chrome/browser/gtk/infobar_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Basic infobars on linux.

All infobars consist of nothing but a non-functioning close button.

Review URL: http://codereview.chromium.org/62070
------------------------------------------------------------------------
r13203 | erikkay@google.com | 2009-04-07 01:10:37 +0200 (Tue, 07 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc

Fix a couple of (likely rare) crashers that can happen if a tab is closed right as it's about to display a JS modal dialog.

I don't know how these would be triggered in the field.  I ran into them through misuse of the current API (trying to pass in a NULL WebContents).

Review URL: http://codereview.chromium.org/62079
------------------------------------------------------------------------
r13201 | shess@chromium.org | 2009-04-07 00:51:11 +0200 (Tue, 07 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
   A /trunk/src/chrome/browser/cocoa/location_bar_view_mac.h
   A /trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp

Initial implemention of Mac Omnibox.

AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView.  AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs).

AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner.  It works with the popup view to make sure the popup is positioned correctly.  AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model).

LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views.  It is mostly placeholder code stolen from the gtk implementation.

---

I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future.  So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc.

Review URL: http://codereview.chromium.org/50074
------------------------------------------------------------------------
r13195 | willchan@chromium.org | 2009-04-06 23:30:27 +0200 (Mon, 06 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   A /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk_unittest.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h
   M /trunk/src/chrome/chrome.gyp

Implement loading animations.  I've ignored the app mode and popup cases since I don't think the Linux port supports those modes yet.  I also ignored RTL.  I've made some minor lint/style cleanups along the way.

BUG=9380
Review URL: http://codereview.chromium.org/60104
------------------------------------------------------------------------
r13193 | erg@google.com | 2009-04-06 23:21:34 +0200 (Mon, 06 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc
   A /trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/chrome.gyp

First implementation of a bookmark bar.

Currently, the bookmark bar only reads state on startup so to see this
work, you have to go to a page, click the star button (that isn't hooked up
yet either), and then restart chromium.

Review URL: http://codereview.chromium.org/60071

------------------------------------------------------------------------
r13192 | pinkerton@chromium.org | 2009-04-06 23:14:57 +0200 (Mon, 06 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm

Correctly initialize all parts of the tab to unselected when it's created, keeping it in sync with the member var.
Review URL: http://codereview.chromium.org/62074
------------------------------------------------------------------------
r13189 | jhawkins@chromium.org | 2009-04-06 23:13:29 +0200 (Mon, 06 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Un-hover the current highlighted tab when the mouse leaves the tabstrip.
Review URL: http://codereview.chromium.org/62075
------------------------------------------------------------------------
r13187 | finnur@chromium.org | 2009-04-06 22:57:39 +0200 (Mon, 06 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/views/controls/text_field.cc

Pasting successfully into a TextField should always trigger
OnContentsChanged on the controller.

BUG=None
TEST=
1) Navigate to google.com, copy the contents of the OmniBox (the URL) and paste it back into the OmniBox. The dropdown should appear.

2) Navigate to google.com, copy the word Privacy into the clipboard. Open the Find box, Paste into the Find bar. It should search. Close the Find bar. Reopen the Find bar. Paste again. It should search.

Review URL: http://codereview.chromium.org/63014
------------------------------------------------------------------------
r13182 | erg@google.com | 2009-04-06 22:30:40 +0200 (Mon, 06 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   A /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc
   A /trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h
   M /trunk/src/chrome/chrome.gyp

Write the star toggle button. Clicking it will bookmark the page.

(Clicking it a second time won't remove the bookmark; need to write the
infobubble next...)

Review URL: http://codereview.chromium.org/63020

------------------------------------------------------------------------
r13181 | darin@chromium.org | 2009-04-06 22:21:59 +0200 (Mon, 06 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/webkit.gyp

Stop serializing WebString over IPC.  The new rule is that only POD (plain old
data) types from WebKit API are allowed to be used in the browser process.

I added a big note about this to webkit_param_traits.h to explain the details
of this decision.

R=dglazkov

Review URL: http://codereview.chromium.org/62032
------------------------------------------------------------------------
r13178 | jhawkins@chromium.org | 2009-04-06 21:53:14 +0200 (Mon, 06 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Update the definition of TabChangedAt in TabStripGtk to match the latest version in tab_strip_model.h.  This fixes a bug where we didn't receive tab change messages from the model.
Review URL: http://codereview.chromium.org/63021
------------------------------------------------------------------------
r13175 | jhawkins@chromium.org | 2009-04-06 21:28:16 +0200 (Mon, 06 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Fix the positioning of the title in TabRendererGtk now that ChromeCanvas text rendering is fixed.

TBR=deanm
Review URL: http://codereview.chromium.org/62066
------------------------------------------------------------------------
r13168 | avi@chromium.org | 2009-04-06 20:08:34 +0200 (Mon, 06 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview_delegate.h

First pass of refactoring dialogs.

Review URL: http://codereview.chromium.org/60110
------------------------------------------------------------------------
r13162 | sidchat@google.com | 2009-04-06 19:08:00 +0200 (Mon, 06 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc

Fix issue 8589: Disable spellcheck field from the context menu when spell check is disabled from the options menu.

Issue=8589
Review URL: http://codereview.chromium.org/60097
------------------------------------------------------------------------
r13152 | deanm@chromium.org | 2009-04-06 13:42:24 +0200 (Mon, 06 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Fix include guards in GTK tabstrip (chrome/browser/gtk/tabs/).

The include guards should now match the file paths.

Review URL: http://codereview.chromium.org/62051

------------------------------------------------------------------------
r13148 | paulg@google.com | 2009-04-06 05:39:15 +0200 (Mon, 06 Apr 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

Fix a crash when canceling a save page operation.

This crash occurs under the following conditions:
1. Launch Chrome and navigate to any web page
2. Save that page (via ctrl+s or menu option)
3. Click cancel in the Save As dialog box that appears
4. Save the page again

This fix checks to see if the SavePackage was initialized when
handling a stop operation, and skips it if nothing has started.

BUG=9738 (http://crbug.com/9738)

Review URL: http://codereview.chromium.org/62048
------------------------------------------------------------------------
r13144 | nsylvain@chromium.org | 2009-04-06 02:35:20 +0200 (Mon, 06 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/locale_tests_uitest.cc

Oops, #ifdef = #if
Review URL: http://codereview.chromium.org/63005
------------------------------------------------------------------------
r13142 | nsylvain@chromium.org | 2009-04-06 02:29:16 +0200 (Mon, 06 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/locale_tests_uitest.cc

It looks like the local files are not built anymore on linux
in debug. I'm disabling these tests since they fail.

Bug: 9758
Review URL: http://codereview.chromium.org/62047
------------------------------------------------------------------------
r13137 | brettw@chromium.org | 2009-04-05 19:37:54 +0200 (Sun, 05 Apr 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Reverting 13136.
------------------------------------------------------------------------
r13136 | brettw@chromium.org | 2009-04-05 19:06:57 +0200 (Sun, 05 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Re-enable the NavigationControllerHistory test.
Review URL: http://codereview.chromium.org/62040
------------------------------------------------------------------------
r13135 | brettw@chromium.org | 2009-04-05 19:05:35 +0200 (Sun, 05 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Remove more reliance on tab contents types.
Review URL: http://codereview.chromium.org/62041
------------------------------------------------------------------------
r13134 | finnur@chromium.org | 2009-04-05 06:52:58 +0200 (Sun, 05 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_factory.mm
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Moving the Find bar ownership to the Browser object for portability and testability purposes.BUG=None.TEST=No new functionality, just moving stuff around and as such it is covered by pre-existing tests.
Review URL: http://codereview.chromium.org/60105
------------------------------------------------------------------------
r13132 | brettw@chromium.org | 2009-04-04 23:32:40 +0200 (Sat, 04 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/test/testing_profile.h

Remove some uses of custom tab contents types from some tests.

This required redoing the tests that used it to use the new RenderViewHost
test harness. This is mostly straightforward, but required more work for the
NavigationController tests.

I removed a few random places that were testing for the tab types. I also
made different versions of a few functions that don't take tab contents types
next to the existing ones that do, so my touched code won't have to be changed
again when I remove the tab contents types.

Review URL: http://codereview.chromium.org/62039
------------------------------------------------------------------------
r13131 | brettw@chromium.org | 2009-04-04 19:55:46 +0200 (Sat, 04 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Make the throbber throb sooner after you navigate. This fixes the new tab page,
which would not start throbbing until the load committed. I think this was always
broken, but switching the tab contents types covered it up.

Now I have a flag that goes along with the tab updating that indicates if it's
a load update or a full update. This is necessary to avoid updating the title
to the page's URL until it does actually commit.

BUG=9310
Review URL: http://codereview.chromium.org/60066
------------------------------------------------------------------------
r13130 | rafaelw@chromium.org | 2009-04-04 03:56:42 +0200 (Sat, 04 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h

Callbacks through ChromeClient->RenderView->RenderViewHost for ContentsDidChangeSize so that extensions can change their toolbar size when the contained contents changes size.

Review URL: http://codereview.chromium.org/56122
------------------------------------------------------------------------
r13127 | estade@chromium.org | 2009-04-04 01:19:02 +0200 (Sat, 04 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h

Gtk: pass the correct event time when we show right click context menus in the render view.

Review URL: http://codereview.chromium.org/62024
------------------------------------------------------------------------
r13123 | hclam@chromium.org | 2009-04-04 01:05:36 +0200 (Sat, 04 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc

Change the size of media cache
Setting media cache too large caused creation of cache backend failed
because rvargas is performing a experiment that limits cache size
to ~240MB, respect such change.

TBR=rvargas
Review URL: http://codereview.chromium.org/62028
------------------------------------------------------------------------
r13116 | davemoore@chromium.org | 2009-04-03 23:39:26 +0200 (Fri, 03 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/base/time.cc
   M /trunk/src/base/time.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   A /trunk/src/chrome/renderer/extensions/loadtimes_extension_bindings.cc
   A /trunk/src/chrome/renderer/extensions/loadtimes_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/webkit/glue/webdatasource.h
   M /trunk/src/webkit/glue/webdatasource_impl.cc
   M /trunk/src/webkit/glue/webdatasource_impl.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h

- Added support for keeping track of load times.
For each document loaded we record the time the page was requested by the user
(or as close as we can get to that), the time the load process started, the time
the
document and it's dependent resources (scripts) have been loaded (before
onload())
and the time all the document's resources have been loaded.
We use this data for two things:

1) We histogram the deltas between the time marks
2) We expose the times to javascript running on the page which was loaded

Review URL: http://codereview.chromium.org/42527
------------------------------------------------------------------------
r13114 | jungshik@google.com | 2009-04-03 23:30:51 +0200 (Fri, 03 Apr 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   M /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   M /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   M /trunk/src/chrome/app/resources/locale_settings_da.xtb
   M /trunk/src/chrome/app/resources/locale_settings_de.xtb
   M /trunk/src/chrome/app/resources/locale_settings_el.xtb
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   M /trunk/src/chrome/app/resources/locale_settings_es.xtb
   M /trunk/src/chrome/app/resources/locale_settings_et.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   M /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   M /trunk/src/chrome/app/resources/locale_settings_id.xtb
   M /trunk/src/chrome/app/resources/locale_settings_it.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   M /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   M /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   M /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   M /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_or.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   M /trunk/src/chrome/app/resources/locale_settings_te.xtb
   M /trunk/src/chrome/app/resources/locale_settings_th.xtb
   M /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   M /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   M /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/incognito_tab.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/common/gfx/chrome_font.h
   M /trunk/src/chrome/common/gfx/chrome_font_win.cc
   M /trunk/src/chrome/common/resource_bundle.cc
   M /trunk/src/chrome/common/resource_bundle.h
   M /trunk/src/chrome/third_party/jstemplate/jstemplate.js
   M /trunk/src/chrome/third_party/jstemplate/jstemplate_compiled.js

Make the font family and the font size used in dom UI localizable. This is a part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI. 

For some Indian languages (Malayalam, Bengali and Telugu), we have to 
use a bigger size and a font family for that script on Windows. 
This is because Windows' stock fonts for those scripts are smaller
than fonts for other scripts at a given size.

I removed 'WEB' style in chrome_font.h because it's not used anywhere any more
after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is 
recycled to localize the font family (or the list of font families) for html UI.

I also back-ported the support for setting 'style.fooBar' property to our copy
of Jstemplate (JstProcessor.prototype.jstValues_).


BUG=7319

Review URL: http://codereview.chromium.org/57025
------------------------------------------------------------------------
r13113 | tc@google.com | 2009-04-03 23:30:12 +0200 (Fri, 03 Apr 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc

NULL check web_contents_ to prevent a crash.
In the notification observer, web_contents_ can be set to NULL so
check for a NULL web_contents_ in GetWindowTitle.  All the other
methods check web_contents_ before using it too.

BUG=9672

Review URL: http://codereview.chromium.org/56205
------------------------------------------------------------------------
r13112 | jhawkins@chromium.org | 2009-04-03 23:26:41 +0200 (Fri, 03 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Create a well-defined region that closely matches the shape of the tab to use for hit testing in the Linux tabstrip.
Review URL: http://codereview.chromium.org/62013
------------------------------------------------------------------------
r13110 | ericroman@google.com | 2009-04-03 23:13:33 +0200 (Fri, 03 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Make ProxyResolverV8 the default.
Replace the flag --v8-proxy-resolver with --winhttp-proxy-resolver to reflect new default.

BUG=74,2764
Review URL: http://codereview.chromium.org/62022
------------------------------------------------------------------------
r13109 | estade@chromium.org | 2009-04-03 23:11:41 +0200 (Fri, 03 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Gtk: Insert a border at the bottom of the toolbar.

Review URL: http://codereview.chromium.org/62021
------------------------------------------------------------------------
r13106 | sky@chromium.org | 2009-04-03 22:47:16 +0200 (Fri, 03 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Fixes regression in dragging bookmark bar. The bookmark bar would not
allow drags when on the new tab page.

BUG=9674
TEST=see bug, but make sure dragging from bookmark bar works in all modes.

Review URL: http://codereview.chromium.org/60096
------------------------------------------------------------------------
r13104 | shess@chromium.org | 2009-04-03 22:36:21 +0200 (Fri, 03 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Add some hysterisis to tab dragging on Mac.

http://code.google.com/p/chromium/issues/detail?id=9670

Review URL: http://codereview.chromium.org/60072
------------------------------------------------------------------------
r13103 | georged@chromium.org | 2009-04-03 22:28:44 +0200 (Fri, 03 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Adds temporary warning when installing Chrome extensions. The warning
will be replaced with the final extension installation UI when
available.

Review URL: http://codereview.chromium.org/60079
------------------------------------------------------------------------
r13093 | thestig@chromium.org | 2009-04-03 20:18:55 +0200 (Fri, 03 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/webkit/glue/glue_serialize_unittest.cc

Remove unneeded uses of base/pickle.h. Add some explicit #includes.
Review URL: http://codereview.chromium.org/60095
------------------------------------------------------------------------
r13091 | estade@chromium.org | 2009-04-03 19:43:32 +0200 (Fri, 03 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc

Put a border around the find bar text entry field.

Review URL: http://codereview.chromium.org/56207
------------------------------------------------------------------------
r13090 | thestig@chromium.org | 2009-04-03 19:39:29 +0200 (Fri, 03 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove unneeded temp_scaffolding_stubs.h includes. Remove ConstrainedWindow from the scaffold. Added a bunch of explicit #includes that used to be implicitly included through temp_scaffolding_stubs.h.
Review URL: http://codereview.chromium.org/60077
------------------------------------------------------------------------
r13089 | phajdan.jr@chromium.org | 2009-04-03 19:18:27 +0200 (Fri, 03 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Remove deprecated wstring ctor of JSONFileValueSerializer.

Switched callers to FilePath.

Review URL: http://codereview.chromium.org/62009
------------------------------------------------------------------------
r13088 | jcampan@chromium.org | 2009-04-03 19:18:04 +0200 (Fri, 03 Apr 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

This CL adds unit-tests for the SafeBrowsingBlockingPage class.
This required:
- creating a factory to create SafeBrowsingBlockingPage
  instances (so unit-tests can provide their own sub-classes).
- making the code posts tasks on the current message loop
  when there is no IO thread.  This should only happen in
  tests scenarios where we only have 1 thread.

BUG=6731
TEST=Run the unit-tests. In Chrome, navigate to pages flagged as malware (ex: ianfette.org) and make sure the safe browsing feature still works as expected.

     
Review URL: http://codereview.chromium.org/56135
------------------------------------------------------------------------
r13086 | phajdan.jr@chromium.org | 2009-04-03 19:01:36 +0200 (Fri, 03 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc

Make OpenProcessHandle report an error when it couldn't open the handle.

One more step to land http://codereview.chromium.org/54003 (chrome_process_util).

Review URL: http://codereview.chromium.org/62004
------------------------------------------------------------------------
r13082 | pfeldman@chromium.org | 2009-04-03 14:22:37 +0200 (Fri, 03 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc

DevTools: Add devtools messages into the about:ipc dialog.

Review URL: http://codereview.chromium.org/60090
------------------------------------------------------------------------
r13080 | deanm@chromium.org | 2009-04-03 12:15:10 +0200 (Fri, 03 Apr 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc

Remove two unneeded uses of std::floor in the GTK tab code.

- <cmath> was not included, breaking some builds
- one floor was used without the std:: prefix

These floor calls should have been redundant, the result was assigned to an
int, which will cause the same truncation anyway.

Pointed out by Hironori Bono and Craig Schlenter.

Review URL: http://codereview.chromium.org/60088

------------------------------------------------------------------------
r13079 | pfeldman@chromium.org | 2009-04-03 12:06:57 +0200 (Fri, 03 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/devtools_messages.h (from /trunk/src/chrome/renderer/devtools_messages.h:13077)
   A /trunk/src/chrome/common/devtools_messages_internal.h (from /trunk/src/chrome/renderer/devtools_messages_internal.h:13077)
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_client.cc
   M /trunk/src/chrome/renderer/devtools_client.h
   D /trunk/src/chrome/renderer/devtools_messages.h
   D /trunk/src/chrome/renderer/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/renderer.vcproj

DevTools: move devtools messages to common.

Review URL: http://codereview.chromium.org/60087
------------------------------------------------------------------------
r13069 | aa@chromium.org | 2009-04-03 07:14:19 +0200 (Fri, 03 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Move code to allow dns queries (and accompanying
TODO) from each in-process ui test into the base
class, since it is really the base class that is
initiating these queries (by way of starting the
browser).

Review URL: http://codereview.chromium.org/56173
------------------------------------------------------------------------
r13065 | brettw@chromium.org | 2009-04-03 05:05:11 +0200 (Fri, 03 Apr 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   D /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc
   D /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h
   A /trunk/src/chrome/browser/dom_ui/html_dialog_ui.cc (from /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc:11924)
   A /trunk/src/chrome/browser/dom_ui/html_dialog_ui.h (from /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h:11924)
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/test/test_browser_window.h

Move HTML dialogs out of their own tab contents type. Moved functions to new
file html_dialog_ui.*

Move WebContents view creation into the constructor, which makes a bunch of
extra calls to CreateView unnecessary.

Remove unused CallJavascriptFunction() functions in DOMUI.

Review URL: http://codereview.chromium.org/56065
------------------------------------------------------------------------
r13063 | agl@chromium.org | 2009-04-03 04:29:45 +0200 (Fri, 03 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/base_switches.cc
   M /trunk/src/base/base_switches.h
   M /trunk/src/base/file_descriptor_posix.h
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/common/chrome_counters.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/common_message_utils.cc
   D /trunk/src/chrome/common/common_message_utils.h
   A /trunk/src/chrome/common/file_descriptor_set_posix.cc (from /trunk/src/ipc/file_descriptor_set_posix.cc:13062)
   A /trunk/src/chrome/common/file_descriptor_set_posix.h (from /trunk/src/ipc/file_descriptor_set_posix.h:13062)
   A /trunk/src/chrome/common/file_descriptor_set_unittest.cc (from /trunk/src/ipc/file_descriptor_set_unittest.cc:13062)
   D /trunk/src/chrome/common/gurl_serialisation_unittest.cc
   A /trunk/src/chrome/common/ipc_channel.h (from /trunk/src/ipc/ipc_channel.h:13062)
   A /trunk/src/chrome/common/ipc_channel_posix.cc (from /trunk/src/ipc/ipc_channel_posix.cc:13062)
   A /trunk/src/chrome/common/ipc_channel_posix.h (from /trunk/src/ipc/ipc_channel_posix.h:13062)
   A /trunk/src/chrome/common/ipc_channel_proxy.cc (from /trunk/src/ipc/ipc_channel_proxy.cc:13062)
   A /trunk/src/chrome/common/ipc_channel_proxy.h (from /trunk/src/ipc/ipc_channel_proxy.h:13062)
   A /trunk/src/chrome/common/ipc_channel_win.cc (from /trunk/src/ipc/ipc_channel_win.cc:13062)
   A /trunk/src/chrome/common/ipc_channel_win.h (from /trunk/src/ipc/ipc_channel_win.h:13062)
   A /trunk/src/chrome/common/ipc_fuzzing_tests.cc (from /trunk/src/ipc/ipc_fuzzing_tests.cc:13062)
   A /trunk/src/chrome/common/ipc_logging.cc (from /trunk/src/ipc/ipc_logging.cc:13062)
   A /trunk/src/chrome/common/ipc_logging.h (from /trunk/src/ipc/ipc_logging.h:13062)
   A /trunk/src/chrome/common/ipc_maybe.h
   A /trunk/src/chrome/common/ipc_message.cc (from /trunk/src/ipc/ipc_message.cc:13062)
   A /trunk/src/chrome/common/ipc_message.h (from /trunk/src/ipc/ipc_message.h:13062)
   A /trunk/src/chrome/common/ipc_message_macros.h (from /trunk/src/ipc/ipc_message_macros.h:13062)
   A /trunk/src/chrome/common/ipc_message_unittest.cc (from /trunk/src/chrome/common/gurl_serialisation_unittest.cc:13062)
   A /trunk/src/chrome/common/ipc_message_utils.cc (from /trunk/src/chrome/common/common_message_utils.cc:13062)
   A /trunk/src/chrome/common/ipc_message_utils.h (from /trunk/src/ipc/ipc_message_utils.h:13062)
   A /trunk/src/chrome/common/ipc_send_fds_test.cc (from /trunk/src/ipc/ipc_send_fds_test.cc:13062)
   A /trunk/src/chrome/common/ipc_sync_channel.cc (from /trunk/src/ipc/ipc_sync_channel.cc:13062)
   A /trunk/src/chrome/common/ipc_sync_channel.h (from /trunk/src/ipc/ipc_sync_channel.h:13062)
   A /trunk/src/chrome/common/ipc_sync_channel_unittest.cc (from /trunk/src/ipc/ipc_sync_channel_unittest.cc:13062)
   A /trunk/src/chrome/common/ipc_sync_message.cc (from /trunk/src/ipc/ipc_sync_message.cc:13062)
   A /trunk/src/chrome/common/ipc_sync_message.h (from /trunk/src/ipc/ipc_sync_message.h:13062)
   A /trunk/src/chrome/common/ipc_sync_message_unittest.cc (from /trunk/src/ipc/ipc_sync_message_unittest.cc:13062)
   A /trunk/src/chrome/common/ipc_sync_message_unittest.h (from /trunk/src/ipc/ipc_sync_message_unittest.h:13062)
   A /trunk/src/chrome/common/ipc_test_sink.cc (from /trunk/src/ipc/ipc_test_sink.cc:13062)
   A /trunk/src/chrome/common/ipc_test_sink.h (from /trunk/src/ipc/ipc_test_sink.h:13062)
   A /trunk/src/chrome/common/ipc_tests.cc (from /trunk/src/ipc/ipc_tests.cc:13062)
   A /trunk/src/chrome/common/ipc_tests.h (from /trunk/src/ipc/ipc_tests.h:13062)
   A /trunk/src/chrome/common/ipc_tests.vcproj
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   M /trunk/src/chrome/renderer/debug_message_handler.h
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_messages.h
   M /trunk/src/chrome/renderer/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/data/purify/ipc_tests.exe_UMR.txt
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   D /trunk/src/ipc/file_descriptor_set_posix.cc
   D /trunk/src/ipc/file_descriptor_set_posix.h
   D /trunk/src/ipc/file_descriptor_set_unittest.cc
   D /trunk/src/ipc/ipc.gyp
   D /trunk/src/ipc/ipc_channel.h
   D /trunk/src/ipc/ipc_channel_posix.cc
   D /trunk/src/ipc/ipc_channel_posix.h
   D /trunk/src/ipc/ipc_channel_proxy.cc
   D /trunk/src/ipc/ipc_channel_proxy.h
   D /trunk/src/ipc/ipc_channel_win.cc
   D /trunk/src/ipc/ipc_channel_win.h
   D /trunk/src/ipc/ipc_counters.cc
   D /trunk/src/ipc/ipc_counters.h
   D /trunk/src/ipc/ipc_fuzzing_tests.cc
   D /trunk/src/ipc/ipc_logging.cc
   D /trunk/src/ipc/ipc_logging.h
   D /trunk/src/ipc/ipc_message.cc
   D /trunk/src/ipc/ipc_message.h
   D /trunk/src/ipc/ipc_message_macros.h
   D /trunk/src/ipc/ipc_message_utils.cc
   D /trunk/src/ipc/ipc_message_utils.h
   D /trunk/src/ipc/ipc_send_fds_test.cc
   D /trunk/src/ipc/ipc_switches.cc
   D /trunk/src/ipc/ipc_switches.h
   D /trunk/src/ipc/ipc_sync_channel.cc
   D /trunk/src/ipc/ipc_sync_channel.h
   D /trunk/src/ipc/ipc_sync_channel_unittest.cc
   D /trunk/src/ipc/ipc_sync_message.cc
   D /trunk/src/ipc/ipc_sync_message.h
   D /trunk/src/ipc/ipc_sync_message_unittest.cc
   D /trunk/src/ipc/ipc_sync_message_unittest.h
   D /trunk/src/ipc/ipc_test_sink.cc
   D /trunk/src/ipc/ipc_test_sink.h
   D /trunk/src/ipc/ipc_tests.cc
   D /trunk/src/ipc/ipc_tests.h

Revert "Move IPC code to ipc/"

This reverts commit r13062 which, unsurprisingly, broke the build.

------------------------------------------------------------------------
r13062 | agl@chromium.org | 2009-04-03 04:19:49 +0200 (Fri, 03 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/base_switches.cc
   M /trunk/src/base/base_switches.h
   M /trunk/src/base/file_descriptor_posix.h
   M /trunk/src/build/all.gyp
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/common/chrome_counters.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/common_message_utils.cc (from /trunk/src/chrome/common/ipc_message_utils.cc:13061)
   A /trunk/src/chrome/common/common_message_utils.h
   D /trunk/src/chrome/common/file_descriptor_set_posix.cc
   D /trunk/src/chrome/common/file_descriptor_set_posix.h
   D /trunk/src/chrome/common/file_descriptor_set_unittest.cc
   A /trunk/src/chrome/common/gurl_serialisation_unittest.cc (from /trunk/src/chrome/common/ipc_message_unittest.cc:13061)
   D /trunk/src/chrome/common/ipc_channel.h
   D /trunk/src/chrome/common/ipc_channel_posix.cc
   D /trunk/src/chrome/common/ipc_channel_posix.h
   D /trunk/src/chrome/common/ipc_channel_proxy.cc
   D /trunk/src/chrome/common/ipc_channel_proxy.h
   D /trunk/src/chrome/common/ipc_channel_win.cc
   D /trunk/src/chrome/common/ipc_channel_win.h
   D /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   D /trunk/src/chrome/common/ipc_logging.cc
   D /trunk/src/chrome/common/ipc_logging.h
   D /trunk/src/chrome/common/ipc_maybe.h
   D /trunk/src/chrome/common/ipc_message.cc
   D /trunk/src/chrome/common/ipc_message.h
   D /trunk/src/chrome/common/ipc_message_macros.h
   D /trunk/src/chrome/common/ipc_message_unittest.cc
   D /trunk/src/chrome/common/ipc_message_utils.cc
   D /trunk/src/chrome/common/ipc_message_utils.h
   D /trunk/src/chrome/common/ipc_send_fds_test.cc
   D /trunk/src/chrome/common/ipc_sync_channel.cc
   D /trunk/src/chrome/common/ipc_sync_channel.h
   D /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   D /trunk/src/chrome/common/ipc_sync_message.cc
   D /trunk/src/chrome/common/ipc_sync_message.h
   D /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   D /trunk/src/chrome/common/ipc_sync_message_unittest.h
   D /trunk/src/chrome/common/ipc_test_sink.cc
   D /trunk/src/chrome/common/ipc_test_sink.h
   D /trunk/src/chrome/common/ipc_tests.cc
   D /trunk/src/chrome/common/ipc_tests.h
   D /trunk/src/chrome/common/ipc_tests.vcproj
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/webkit_param_traits.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   M /trunk/src/chrome/renderer/debug_message_handler.h
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_messages.h
   M /trunk/src/chrome/renderer/devtools_messages_internal.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/data/purify/ipc_tests.exe_UMR.txt
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   A /trunk/src/ipc
   A /trunk/src/ipc/file_descriptor_set_posix.cc (from /trunk/src/chrome/common/file_descriptor_set_posix.cc:13061)
   A /trunk/src/ipc/file_descriptor_set_posix.h (from /trunk/src/chrome/common/file_descriptor_set_posix.h:13061)
   A /trunk/src/ipc/file_descriptor_set_unittest.cc (from /trunk/src/chrome/common/file_descriptor_set_unittest.cc:13061)
   A /trunk/src/ipc/ipc.gyp
   A /trunk/src/ipc/ipc_channel.h (from /trunk/src/chrome/common/ipc_channel.h:13061)
   A /trunk/src/ipc/ipc_channel_posix.cc (from /trunk/src/chrome/common/ipc_channel_posix.cc:13061)
   A /trunk/src/ipc/ipc_channel_posix.h (from /trunk/src/chrome/common/ipc_channel_posix.h:13061)
   A /trunk/src/ipc/ipc_channel_proxy.cc (from /trunk/src/chrome/common/ipc_channel_proxy.cc:13061)
   A /trunk/src/ipc/ipc_channel_proxy.h (from /trunk/src/chrome/common/ipc_channel_proxy.h:13061)
   A /trunk/src/ipc/ipc_channel_win.cc (from /trunk/src/chrome/common/ipc_channel_win.cc:13061)
   A /trunk/src/ipc/ipc_channel_win.h (from /trunk/src/chrome/common/ipc_channel_win.h:13061)
   A /trunk/src/ipc/ipc_counters.cc
   A /trunk/src/ipc/ipc_counters.h
   A /trunk/src/ipc/ipc_fuzzing_tests.cc (from /trunk/src/chrome/common/ipc_fuzzing_tests.cc:13061)
   A /trunk/src/ipc/ipc_logging.cc (from /trunk/src/chrome/common/ipc_logging.cc:13061)
   A /trunk/src/ipc/ipc_logging.h (from /trunk/src/chrome/common/ipc_logging.h:13061)
   A /trunk/src/ipc/ipc_message.cc (from /trunk/src/chrome/common/ipc_message.cc:13061)
   A /trunk/src/ipc/ipc_message.h (from /trunk/src/chrome/common/ipc_message.h:13061)
   A /trunk/src/ipc/ipc_message_macros.h (from /trunk/src/chrome/common/ipc_message_macros.h:13061)
   A /trunk/src/ipc/ipc_message_utils.cc
   A /trunk/src/ipc/ipc_message_utils.h (from /trunk/src/chrome/common/ipc_message_utils.h:13061)
   A /trunk/src/ipc/ipc_send_fds_test.cc (from /trunk/src/chrome/common/ipc_send_fds_test.cc:13061)
   A /trunk/src/ipc/ipc_switches.cc
   A /trunk/src/ipc/ipc_switches.h
   A /trunk/src/ipc/ipc_sync_channel.cc (from /trunk/src/chrome/common/ipc_sync_channel.cc:13061)
   A /trunk/src/ipc/ipc_sync_channel.h (from /trunk/src/chrome/common/ipc_sync_channel.h:13061)
   A /trunk/src/ipc/ipc_sync_channel_unittest.cc (from /trunk/src/chrome/common/ipc_sync_channel_unittest.cc:13061)
   A /trunk/src/ipc/ipc_sync_message.cc (from /trunk/src/chrome/common/ipc_sync_message.cc:13061)
   A /trunk/src/ipc/ipc_sync_message.h (from /trunk/src/chrome/common/ipc_sync_message.h:13061)
   A /trunk/src/ipc/ipc_sync_message_unittest.cc (from /trunk/src/chrome/common/ipc_sync_message_unittest.cc:13061)
   A /trunk/src/ipc/ipc_sync_message_unittest.h (from /trunk/src/chrome/common/ipc_sync_message_unittest.h:13061)
   A /trunk/src/ipc/ipc_test_sink.cc (from /trunk/src/chrome/common/ipc_test_sink.cc:13061)
   A /trunk/src/ipc/ipc_test_sink.h (from /trunk/src/chrome/common/ipc_test_sink.h:13061)
   A /trunk/src/ipc/ipc_tests.cc (from /trunk/src/chrome/common/ipc_tests.cc:13061)
   A /trunk/src/ipc/ipc_tests.h (from /trunk/src/chrome/common/ipc_tests.h:13061)

Move IPC code to ipc/

(No review URL: Rietvelt couldn't cope)

------------------------------------------------------------------------
r13057 | mpcomplete@google.com | 2009-04-03 01:56:11 +0200 (Fri, 03 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_resources.grd
   A /trunk/src/chrome/renderer/resources/renderer_extension_bindings.js
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html

Add code to support 2-way communication between extensions and renderers.  The code is almost fully symmetrical, except that right now a channel can only be opened to an extension (by ID).  It should be trivial to open a channel to a tab, once we have a solid tab API.
Review URL: http://codereview.chromium.org/56037
------------------------------------------------------------------------
r13053 | jhawkins@chromium.org | 2009-04-03 01:10:47 +0200 (Fri, 03 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Add basic mouse input handling for Linux TabStrip.
Review URL: http://codereview.chromium.org/56200
------------------------------------------------------------------------
r13052 | paulg@google.com | 2009-04-03 00:59:23 +0200 (Fri, 03 Apr 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h

Speculative fix for a crash in resource handlers.

Investigating the crash dumps for this bug, it looks like
under certain network error conditions, the resource handlers
are freed before the SafeBrowsing check has completed. When
the check runs, it calls into invalid memory and crashes.

BUG=8544 (http://crbug.com/8544)


Review URL: http://codereview.chromium.org/60043
------------------------------------------------------------------------
r13045 | estade@chromium.org | 2009-04-03 00:30:35 +0200 (Fri, 03 Apr 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/webkit/glue/window_open_disposition.h

Only create one downloads tab per window. If there is already a Downloads
tab, then switch to it instead of creating new one. Introduce FOCUS_SINGLETON_TAB disposition.

patch by Mohamed Mansour <http://codereview.chromium.org/50003/show>

Review URL: http://codereview.chromium.org/60062
------------------------------------------------------------------------
r13044 | estade@chromium.org | 2009-04-03 00:30:26 +0200 (Fri, 03 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/tools/gtk_clipboard_dump/gtk_clipboard_dump.cc

Copy selection to x clipboard.

Review URL: http://codereview.chromium.org/55052
------------------------------------------------------------------------
r13039 | ben@chromium.org | 2009-04-02 23:51:20 +0200 (Thu, 02 Apr 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   D /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Revert until sequencing issue fixed.

------------------------------------------------------------------------
r13036 | ben@chromium.org | 2009-04-02 23:30:36 +0200 (Thu, 02 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/browser_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Fix a case where non-tabbed browser windows could open tabs. Also includes UI test for this.

http://crbug.com/8472

Review URL: http://codereview.chromium.org/56094
------------------------------------------------------------------------
r13031 | estade@chromium.org | 2009-04-02 22:47:06 +0200 (Thu, 02 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Paste from the x clipboard into webkit.

Review URL: http://codereview.chromium.org/51008
------------------------------------------------------------------------
r13028 | finnur@chromium.org | 2009-04-02 22:07:15 +0200 (Thu, 02 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Bug 2220 lists two cases where the inactive highlighting doesn't reappear on FindNext. This is a simple fix for one of those cases (user presses Refresh after Find).

BUG=2220
TEST=Open google.com, press Find, press e, press Refresh, press F3 (or FindNext button in UI). Then make sure the inactive matches are highlighted (not just the active match).
Review URL: http://codereview.chromium.org/56193
------------------------------------------------------------------------
r13025 | estade@chromium.org | 2009-04-02 21:20:38 +0200 (Thu, 02 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Don't allow hotkeys to activate un-activatable menu items on linux.

BUG=9400
Review URL: http://codereview.chromium.org/56184
------------------------------------------------------------------------
r13019 | estade@chromium.org | 2009-04-02 19:29:41 +0200 (Thu, 02 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc

A file I left out of rietveld issue 56153

TBR=paul

Review URL: http://codereview.chromium.org/56182
------------------------------------------------------------------------
r13000 | georged@chromium.org | 2009-04-02 01:33:45 +0200 (Thu, 02 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.cc

Installing extensions (drag/drop, download crx file) will now be
handled by the Chrome instance w/o shell execute. This will install
the extension in the proper profile using the running bits.

Review URL: http://codereview.chromium.org/55046
------------------------------------------------------------------------
r12993 | darin@chromium.org | 2009-04-02 01:07:19 +0200 (Thu, 02 Apr 2009) | 10 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/webkit_param_traits.h (from /trunk/src/chrome/common/render_messages.h:12976)
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/worker/test_worker_main.cc
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/glue.vcproj
   D /trunk/src/webkit/glue/screen_info.h
   M /trunk/src/webkit/glue/webkit_glue.h
   D /trunk/src/webkit/glue/webkit_glue_gtk.cc
   D /trunk/src/webkit/glue/webkit_glue_mac.mm
   D /trunk/src/webkit/glue/webkit_glue_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   M /trunk/src/webkit/webkit.gyp

Replace webkit/glue/screen_info.h with WebKit/chromium/public/WebScreenInfo.h

This also eliminates webkit_glue::GetScreenInfo and webkit_glue::GetScreenInfoHelper.

As part of this CL, I also extracted all of the ParamTraits for WebKit API
types into chrome/common/webkit_param_traits.h.

R=dglazkov

Review URL: http://codereview.chromium.org/58008
------------------------------------------------------------------------
r12982 | sgk@google.com | 2009-04-02 00:05:12 +0200 (Thu, 02 Apr 2009) | 2 lines
Changed paths:
   D /trunk/src/base/SConstruct
   D /trunk/src/base/base.scons
   D /trunk/src/base/base_gfx.scons
   D /trunk/src/base/base_main.scons
   D /trunk/src/base/base_sln.scons
   D /trunk/src/base/base_unittests.scons
   D /trunk/src/base/debug_message.scons
   D /trunk/src/base/gfx/using_base_gfx.scons
   D /trunk/src/base/using_base.scons
   D /trunk/src/breakpad/SConscript
   D /trunk/src/breakpad/breakpad_handler.scons
   D /trunk/src/breakpad/breakpad_sender.scons
   D /trunk/src/breakpad/using_breakpad.scons
   D /trunk/src/build/SConscript.googleurl
   D /trunk/src/build/SConscript.main
   D /trunk/src/build/SConscript.v8
   D /trunk/src/build/common.scons
   D /trunk/src/build/debug.scons
   D /trunk/src/build/external_code.scons
   D /trunk/src/build/googleurl.scons
   D /trunk/src/build/googleurl_lib.scons
   D /trunk/src/build/googleurl_unittests.scons
   D /trunk/src/build/internal/chromium_build.scons
   D /trunk/src/build/internal/chromium_build_google_chrome.scons
   D /trunk/src/build/internal/essential.scons
   D /trunk/src/build/internal/release_defaults.scons
   D /trunk/src/build/internal/release_impl.scons
   D /trunk/src/build/internal/release_impl_checksenabled.scons
   D /trunk/src/build/internal/release_impl_coverage.scons
   D /trunk/src/build/internal/release_impl_dom_stats.scons
   D /trunk/src/build/internal/release_impl_official.scons
   D /trunk/src/build/internal/release_impl_purify.scons
   D /trunk/src/build/release.scons
   D /trunk/src/build/using_googleurl.scons
   D /trunk/src/build/using_v8.scons
   D /trunk/src/chrome/SConscript
   D /trunk/src/chrome/SConstruct
   D /trunk/src/chrome/app/chrome_resources.scons
   D /trunk/src/chrome/app/chrome_strings.scons
   D /trunk/src/chrome/app/locales/locales.scons
   D /trunk/src/chrome/app/theme/theme_dll.scons
   D /trunk/src/chrome/browser/browser.scons
   D /trunk/src/chrome/browser/debugger/debugger.scons
   D /trunk/src/chrome/browser/views/SConscript
   D /trunk/src/chrome/chrome_main.scons
   D /trunk/src/chrome/chrome_sln.scons
   D /trunk/src/chrome/common/common.scons
   D /trunk/src/chrome/common/ipc_tests.scons
   D /trunk/src/chrome/installer/mini_installer/mini_installer.scons
   D /trunk/src/chrome/installer/setup/setup.scons
   D /trunk/src/chrome/installer/util/installer_unittests.scons
   D /trunk/src/chrome/installer/util/util.scons
   D /trunk/src/chrome/plugin/plugin.scons
   D /trunk/src/chrome/renderer/renderer.scons
   D /trunk/src/chrome/test/activex_test_control/activex_test_control.scons
   D /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.scons
   D /trunk/src/chrome/test/automation/automation.scons
   D /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.scons
   D /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.scons
   D /trunk/src/chrome/test/memory_test/memory_test.scons
   D /trunk/src/chrome/test/mini_installer_test/mini_installer_test.scons
   D /trunk/src/chrome/test/page_cycler/page_cycler_tests.scons
   D /trunk/src/chrome/test/perf/perftests.scons
   D /trunk/src/chrome/test/plugin/plugin_tests.scons
   D /trunk/src/chrome/test/reliability/reliability_tests.scons
   D /trunk/src/chrome/test/security_tests/security_tests.scons
   D /trunk/src/chrome/test/selenium/selenium_tests.scons
   D /trunk/src/chrome/test/startup/startup_tests.scons
   D /trunk/src/chrome/test/tab_switching/tab_switching_test.scons
   D /trunk/src/chrome/test/ui/ui_tests.scons
   D /trunk/src/chrome/test/unit/unit_tests.scons
   D /trunk/src/chrome/third_party/hunspell/SConscript
   D /trunk/src/chrome/third_party/hunspell/using_hunspell.scons
   D /trunk/src/chrome/third_party/wtl/using_wtl.scons
   D /trunk/src/chrome/tools/convert_dict/convert_dict.scons
   D /trunk/src/chrome/tools/crash_service/crash_service.scons
   D /trunk/src/chrome/tools/perf/flush_cache/flush_cache.scons
   D /trunk/src/chrome/tools/profiles/generate_profile.scons
   D /trunk/src/chrome/tools/test/image_diff/image_diff.scons
   D /trunk/src/chrome/views/SConscript
   D /trunk/src/chrome/worker/worker.scons
   D /trunk/src/google_update/SConscript
   D /trunk/src/google_update/using_google_update.scons
   D /trunk/src/media/SConstruct
   D /trunk/src/media/media.scons
   D /trunk/src/media/media_lib.scons
   D /trunk/src/media/media_player.scons
   D /trunk/src/media/media_unittests.scons
   D /trunk/src/media/using_media.scons
   D /trunk/src/net/SConstruct
   D /trunk/src/net/crash_cache.scons
   D /trunk/src/net/dump_cache.scons
   D /trunk/src/net/net_lib.scons
   D /trunk/src/net/net_main.scons
   D /trunk/src/net/net_perftests.scons
   D /trunk/src/net/net_resources.scons
   D /trunk/src/net/net_sln.scons
   D /trunk/src/net/net_unittests.scons
   D /trunk/src/net/stress_cache.scons
   D /trunk/src/net/tools/tld_cleanup/tld_cleanup.scons
   D /trunk/src/net/using_net.scons
   D /trunk/src/printing/SConstruct
   D /trunk/src/printing/printing.scons
   D /trunk/src/printing/printing_lib.scons
   D /trunk/src/printing/printing_unittests.scons
   D /trunk/src/printing/using_printing.scons
   D /trunk/src/sandbox/SConstruct
   D /trunk/src/sandbox/sandbox.scons
   D /trunk/src/sandbox/sandbox_sln.scons
   D /trunk/src/sandbox/src/sandbox_lib.scons
   D /trunk/src/sandbox/tests/common/sandbox_common.scons
   D /trunk/src/sandbox/tests/integration_tests/sbox_integration_tests.scons
   D /trunk/src/sandbox/tests/unit_tests/sbox_unittests.scons
   D /trunk/src/sandbox/tests/validation_tests/sbox_validation_tests.scons
   D /trunk/src/sandbox/using_sandbox.scons
   D /trunk/src/sandbox/wow_helper/wow_helper.scons
   D /trunk/src/sdch/SConscript
   D /trunk/src/sdch/using_sdch.scons
   D /trunk/src/skia/SConscript
   D /trunk/src/skia/using_skia.scons
   D /trunk/src/testing/SConscript.gtest
   D /trunk/src/testing/using_gtest.scons
   D /trunk/src/third_party/bzip2/bzip2.scons
   D /trunk/src/third_party/bzip2/using_bzip2.scons
   D /trunk/src/third_party/libevent/libevent.scons
   D /trunk/src/third_party/libevent/using_libevent.scons
   D /trunk/src/third_party/libjpeg/libjpeg.scons
   D /trunk/src/third_party/libjpeg/using_libjpeg.scons
   D /trunk/src/third_party/libpng/libpng.scons
   D /trunk/src/third_party/libpng/using_libpng.scons
   D /trunk/src/third_party/libxml/libxml.scons
   D /trunk/src/third_party/libxml/using_libxml.scons
   D /trunk/src/third_party/libxslt/libxslt.scons
   D /trunk/src/third_party/libxslt/using_libxslt.scons
   D /trunk/src/third_party/modp_b64/modp_b64.scons
   D /trunk/src/third_party/modp_b64/using_modp_b64.scons
   D /trunk/src/third_party/npapi/using_npapi.scons
   D /trunk/src/third_party/sqlite/SConscript
   D /trunk/src/third_party/zlib/using_zlib.scons
   D /trunk/src/third_party/zlib/zlib.scons
   D /trunk/src/tools/grit/build/using_generated_resources.scons
   D /trunk/src/tools/gtk_clipboard_dump/gcd.scons
   D /trunk/src/webkit/SConscript
   D /trunk/src/webkit/SConscript.javascriptcore_pcre
   D /trunk/src/webkit/SConscript.port
   D /trunk/src/webkit/SConstruct
   D /trunk/src/webkit/activex_shim/SConscript
   D /trunk/src/webkit/activex_shim_dll/SConscript
   D /trunk/src/webkit/build/JSConfig/SConscript
   D /trunk/src/webkit/build/JavaScriptCore/SConscript
   D /trunk/src/webkit/build/V8Bindings/SConscript
   D /trunk/src/webkit/build/WebCore/SConscript
   D /trunk/src/webkit/build/WebKit/SConscript
   D /trunk/src/webkit/build/port/SConscript
   D /trunk/src/webkit/build/webkit_resources/SConscript
   D /trunk/src/webkit/build/webkit_strings/SConscript
   D /trunk/src/webkit/default_plugin/SConscript
   D /trunk/src/webkit/glue/SConscript
   D /trunk/src/webkit/glue/plugins/test/SConscript
   D /trunk/src/webkit/tools/npapi_layout_test_plugin/SConscript
   D /trunk/src/webkit/tools/test_shell/SConscript
   D /trunk/src/webkit/webkit_main.scons
   D /trunk/src/webkit/webkit_sln.scons

Remove the checked-in scons configuration files.
Review URL: http://codereview.chromium.org/53121
------------------------------------------------------------------------
r12966 | estade@chromium.org | 2009-04-01 20:41:23 +0200 (Wed, 01 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/common/platform_util.h
   M /trunk/src/chrome/common/platform_util_linux.cc
   M /trunk/src/chrome/common/platform_util_mac.mm
   M /trunk/src/chrome/common/platform_util_win.cc

Re-enable save package on linux, mac.

Review URL: http://codereview.chromium.org/56153
------------------------------------------------------------------------
r12964 | estade@chromium.org | 2009-04-01 20:37:27 +0200 (Wed, 01 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Don't try to set the cursor on null windows.

Review URL: http://codereview.chromium.org/59003
------------------------------------------------------------------------
r12930 | ben@chromium.org | 2009-04-01 04:05:07 +0200 (Wed, 01 Apr 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/window/non_client_view.cc
   M /trunk/src/chrome/views/window/non_client_view.h

Fix distributor logo placement on glass frame when window is restored from fullscreen.

Force a layout in WM_NCCALCSIZE since NC metrics can change as a result of handling this message.

http://crbug.com/8511

Review URL: http://codereview.chromium.org/56086
------------------------------------------------------------------------
r12928 | jam@chromium.org | 2009-04-01 03:48:52 +0200 (Wed, 01 Apr 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/npobject_proxy.cc
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_util.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

Port plugin messages.

Review URL: http://codereview.chromium.org/49050
------------------------------------------------------------------------
r12922 | agl@chromium.org | 2009-04-01 03:02:10 +0200 (Wed, 01 Apr 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database_manager.h

Build fix: DeleteURLAndFavicon was a friend.

... so the FRIEND_TEST needs the "DISABLED_" in it too :(

------------------------------------------------------------------------
r12921 | agl@chromium.org | 2009-04-01 02:47:20 +0200 (Wed, 01 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc

Disable DeleteURLAndFavicon

This test started failing. However, reverting doesn't change anything!
Disabling for now, hclam is looking into it.

------------------------------------------------------------------------
r12916 | darin@chromium.org | 2009-04-01 01:30:59 +0200 (Wed, 01 Apr 2009) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   D /trunk/src/webkit/glue/console_message_level.h
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/webkit.gyp

Use WebConsoleMessage instead of ConsoleMessageLevel.

R=dglazkov

Review URL: http://codereview.chromium.org/57073
------------------------------------------------------------------------
r12908 | agl@chromium.org | 2009-03-31 23:20:35 +0200 (Tue, 31 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h

Linux: don't use static ChromeFont objects

With Darin's change (12485) we now have huge library trees from almost
every target. This is breaking because the static ChromeFont is
entering Skia before Skia has been constructed. This will only bite us
in the future if we have static ChromeFont objects.

------------------------------------------------------------------------
r12901 | brettw@chromium.org | 2009-03-31 22:18:17 +0200 (Tue, 31 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc

OCD fixing of style for the initializer list of ExtensionView.
Review URL: http://codereview.chromium.org/56113
------------------------------------------------------------------------
r12898 | estade@chromium.org | 2009-03-31 22:13:38 +0200 (Tue, 31 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Fix ninebox rendering.

- Correct some wrong x/y coords.
- Get rid of FillWidget. We can't paint the widget with a debugging color because some of our images are partially translucent, so the debug color will shine through.

TEST=CustomContainerButton hover-over should now appear properly. Download items in the shelf should appear properly.

Review URL: http://codereview.chromium.org/56091
------------------------------------------------------------------------
r12897 | estade@chromium.org | 2009-03-31 22:13:21 +0200 (Tue, 31 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

Don't create an empty folder when saving complete html pages with no extra resources to save.

patch by Paul Robinson <http://codereview.chromium.org/57030>

Review URL: http://codereview.chromium.org/56089
------------------------------------------------------------------------
r12896 | glen@chromium.org | 2009-03-31 22:11:01 +0200 (Tue, 31 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Record new tab button presses.

Review URL: http://codereview.chromium.org/56049
------------------------------------------------------------------------
r12881 | darin@chromium.org | 2009-03-31 20:08:40 +0200 (Tue, 31 Mar 2009) | 15 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   D /trunk/src/webkit/glue/find_in_page_request.h
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webkit_glue.cc
   D /trunk/src/webkit/glue/webscriptsource.h
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/webkit.gyp

Use WebScriptSource and WebFindInPageRequest from the WebKit API.

This change introduces some helper functions in glue_util.cc for efficient
conversion between WebString and WebCore::String when inside the implementation
of webkit/glue.  This is a temporary change since eventually all code in glue
that uses WebCore will be moved into the WebKit API implementation.

Instead of making the Chrome automation use WebFindInPageRequest, I decided to
introduce AutomationMsg_Find_Params as a copy of the old FindInPageRequest
structure.  That preserves the IPC protocol and avoids making the automation
library depend on WebKit.

R=dglazkov

Review URL: http://codereview.chromium.org/57060
------------------------------------------------------------------------
r12880 | jhawkins@chromium.org | 2009-03-31 20:07:12 +0200 (Tue, 31 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   M /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Convert the gtk tab rendering code to use ChromeCanvas instead of directly drawing with gdk.
Review URL: http://codereview.chromium.org/57063
------------------------------------------------------------------------
r12876 | markus@chromium.org | 2009-03-31 19:50:33 +0200 (Tue, 31 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/net/base/client_socket.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/base/ssl_client_socket.h
   M /trunk/src/net/base/ssl_client_socket_mac.cc
   M /trunk/src/net/base/ssl_client_socket_mac.h
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_client_socket_win.cc
   M /trunk/src/net/base/ssl_client_socket_win.h
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/tcp_client_socket.h
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/tcp_client_socket_win.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Resubmitted code from revision 12809. The bug in the Windows SSL stack that
this code originally uncovered has been fixed in a separate changelist.

------------------------------------------------------------------------
r12874 | paulg@google.com | 2009-03-31 19:36:28 +0200 (Tue, 31 Mar 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Delete downloads after updating observers.

The download page adds itself as an observer to in-progress
and unconfirmed dangerous downloads, and removes itself when
the download manager indicates its state has changed.

This caused a crash when the downloads were deleted during a
"clear browsing data" operation, since the delete happened
before the download page was notified of a download manager
state change. The download page then attempted to remove itself
from a deleted item.

BUG=9444 (http://crbug.com/9444)

Review URL: http://codereview.chromium.org/56096
------------------------------------------------------------------------
r12856 | sverrir@chromium.org | 2009-03-31 16:34:43 +0200 (Tue, 31 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_settings.cc
   M /trunk/src/chrome/browser/printing/print_settings.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/printing/printed_page.h
   M /trunk/src/chrome/browser/printing/win_printing_context.cc

Simplify code in PrintSettings.  Removes support for settings margins
etc in metric units but I will add again if required.  This is to prepare
adding user defined print settings.
Also fixes some typos in printing code.

Review URL: http://codereview.chromium.org/56077
------------------------------------------------------------------------
r12837 | aa@chromium.org | 2009-03-31 06:21:45 +0200 (Tue, 31 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/no_id
   A /trunk/src/chrome/test/data/extensions/no_id/manifest.json

Make the "id" key for extension manifests optional in
--load-extension mode. This makes this mode more convenient, and
should lead to less copy-and-paste of extension IDs.

Also, remove the "format_version" key. This is basically
duplicated in the code that checks the version number of the crx
file format. And if we ever really need a format version for the
manifest, we can always add it later.

Review URL: http://codereview.chromium.org/56044
------------------------------------------------------------------------
r12836 | huanr@chromium.org | 2009-03-31 06:16:44 +0200 (Tue, 31 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Mechanic change based on comment from previous code review.
Rename RunCommand to RunCommandAsync and RunCommandSync to
RunCommand.

Review URL: http://codereview.chromium.org/57039
------------------------------------------------------------------------
r12819 | estade@chromium.org | 2009-03-31 01:06:59 +0200 (Tue, 31 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc

Display a title for files in the back/forward menu.

Patch by Paul Robinson <http://codereview.chromium.org/56045>

BUG=7871

Review URL: http://codereview.chromium.org/57013
------------------------------------------------------------------------
r12818 | brettw@chromium.org | 2009-03-31 01:06:27 +0200 (Tue, 31 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc

Fix some line endings in browser/dom_ui.

Review URL: http://codereview.chromium.org/57028
------------------------------------------------------------------------
r12816 | markus@chromium.org | 2009-03-31 00:23:51 +0200 (Tue, 31 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/net/base/client_socket.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/base/ssl_client_socket.h
   M /trunk/src/net/base/ssl_client_socket_mac.cc
   M /trunk/src/net/base/ssl_client_socket_mac.h
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_client_socket_win.cc
   M /trunk/src/net/base/ssl_client_socket_win.h
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/tcp_client_socket.h
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/tcp_client_socket_win.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Reverting, as this changelist broke unittests on Windows.

------------------------------------------------------------------------
r12810 | pinkerton@chromium.org | 2009-03-30 23:14:20 +0200 (Mon, 30 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm

Make NTP work by correctly marking the kind of urls we type in. Patch from rohitrao@google.com. http://codereview.chromium.org/55058
------------------------------------------------------------------------
r12809 | markus@chromium.org | 2009-03-30 23:09:30 +0200 (Mon, 30 Mar 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/net/base/client_socket.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/base/ssl_client_socket.h
   M /trunk/src/net/base/ssl_client_socket_mac.cc
   M /trunk/src/net/base/ssl_client_socket_mac.h
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_client_socket_win.cc
   M /trunk/src/net/base/ssl_client_socket_win.h
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/tcp_client_socket.h
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/tcp_client_socket_win.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Change the bad-certificate handler for SSL (using NSS) to return an
error.

This requires a few additional changes in the rest of the code. In
particular, we now have to teach HttpNetworkTransaction about how to
restart connections with bad certificates. This was originally
intended to be done by ReconnectIgnoringLastError(), but that API
turns out be very difficult to implement in the SSLClientSocket. So,
instead, we just create a completely new SSLClientSocket.

We also have to be careful to store a copy of the certificate from
within the bad-certificate handler, as it won't be available by the
time GetSSLInfo() is called.

And we fix a bug that would cause us to erroneously talk SSL on
reconnected TCP sockets, even though we were still supposed to
negotiate a proxy tunnel first.

Review URL: http://codereview.chromium.org/43115
------------------------------------------------------------------------
r12799 | paulg@google.com | 2009-03-30 22:02:36 +0200 (Mon, 30 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove Windows "Save As" dialogs from Save Page code.In this change:- convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691)
Review URL: http://codereview.chromium.org/45048
------------------------------------------------------------------------
r12795 | jhawkins@chromium.org | 2009-03-30 21:49:53 +0200 (Mon, 30 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   D /trunk/src/chrome/browser/gtk/tab_strip_gtk.cc
   D /trunk/src/chrome/browser/gtk/tab_strip_gtk.h
   A /trunk/src/chrome/browser/gtk/tabs
   A /trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc
   A /trunk/src/chrome/browser/gtk/tabs/tab_gtk.h
   A /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
   A /trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h
   A /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc
   A /trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h

Break out the tab rendering logic into TabGtk and TabRendererGtk.
Review URL: http://codereview.chromium.org/56030
------------------------------------------------------------------------
r12790 | jcampan@chromium.org | 2009-03-30 20:47:53 +0200 (Mon, 30 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

The NativeButton HWND would not be created yet when we were setting the initial focus in the first run bubble view.
This CL makes sure to set the focus when everything is set-up.

BUG=9387
TEST=Run chrome to show the first run bubble (you can use the --first-run parameter). When Chrome comes-up, it shows the "Search from here" info bubble. The focus should be on the "Keep Google..." button.
Review URL: http://codereview.chromium.org/55019
------------------------------------------------------------------------
r12780 | phajdan.jr@chromium.org | 2009-03-30 19:37:37 +0200 (Mon, 30 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/common/net/cache_uitest.cc

Platform cleanup in chrome UI tests.

Can't include them in the Linux build yet because they
wouldn't pass.

Review URL: http://codereview.chromium.org/57010
------------------------------------------------------------------------
r12774 | phajdan.jr@chromium.org | 2009-03-30 17:22:45 +0200 (Mon, 30 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc

Cleanup in automation. Remove WaitForTabCountToChange.

WaitForTabCountToBecome is easier to use and more reliable.

Also removed Windows2000-specific code from accessibility unit tests.

Review URL: http://codereview.chromium.org/45070
------------------------------------------------------------------------
r12773 | brettw@chromium.org | 2009-03-30 17:09:32 +0200 (Mon, 30 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc

Fix the DOMUIToStandard unit test and uncomment it. The NavigationController
wasn't getting hooked up properly to the WebContents, and we were getting the
wrong RenderViewHost out of it later on in the test.
Review URL: http://codereview.chromium.org/55045
------------------------------------------------------------------------
r12759 | hbono@chromium.org | 2009-03-30 05:59:15 +0200 (Mon, 30 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

A workaround fix for Issue 3693.
To investigate the behavior of Safari, it seems to finish an ongoing composition when we click a left mouse button. So, this change just emulates the behavior.

BUG=3693
Review URL: http://codereview.chromium.org/42691
------------------------------------------------------------------------
r12756 | evan@chromium.org | 2009-03-29 23:28:32 +0200 (Sun, 29 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Remove NOTIMPLEMENTED bits for fast shutdown code on non-Windows.

This was just temporary code anyway.

Review URL: http://codereview.chromium.org/49048
------------------------------------------------------------------------
r12752 | darin@chromium.org | 2009-03-28 23:06:33 +0100 (Sat, 28 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_network_dialog.cc

Fix crash that occurs when the about:network window is closed while still
tracking network jobs.

BUG=9446
R=brettw

Review URL: http://codereview.chromium.org/45072
------------------------------------------------------------------------
r12746 | aa@chromium.org | 2009-03-28 21:52:59 +0100 (Sat, 28 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Fix linux build.

Review URL: http://codereview.chromium.org/55055
------------------------------------------------------------------------
r12744 | aa@chromium.org | 2009-03-28 20:56:51 +0100 (Sat, 28 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/base/json_reader.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/extensions/extension_api_handler.cc
   D /trunk/src/chrome/browser/extensions/extension_api_handler.h
   A /trunk/src/chrome/browser/extensions/extension_function.cc
   A /trunk/src/chrome/browser/extensions/extension_function.h
   A /trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc
   A /trunk/src/chrome/browser/extensions/extension_function_dispatcher.h
   A /trunk/src/chrome/browser/extensions/extension_tabs_module.cc
   A /trunk/src/chrome/browser/extensions/extension_tabs_module.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   M /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/resources/extension_process_bindings.js

Add more of the server-side plumbing for extension APIs. Also
added getTabsForWindow() to drive it.

Review URL: http://codereview.chromium.org/42680
------------------------------------------------------------------------
r12739 | abarth@chromium.org | 2009-03-28 08:13:19 +0100 (Sat, 28 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/media/data_source_impl.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Add the ability to specify a default MIME type when loading a resource.  We'll need this to correctly load stylesheets that lack a Content-Type header in standards mode.

We're waiting on https://bugs.webkit.org/show_bug.cgi?id=24904 upstream before this works fully.  This change, as it stands, is a no-op.

R=wtc
BUG=7448

Review URL: http://codereview.chromium.org/55049
------------------------------------------------------------------------
r12732 | jcampan@chromium.org | 2009-03-28 02:47:58 +0100 (Sat, 28 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

A crash report from the field reports that we are removing a SafeBrowsingBlockingPage from a global map that is not to be found causing a stl exception to be thrown.
I am not sure what the cause is yet, my investigations results are in the bug comment.
This is a work-around the crasher while I keep investigating.

BUG=9442
TEST=Access a page which contains sub-resource malware.
Review URL: http://codereview.chromium.org/49049
------------------------------------------------------------------------
r12730 | xji@chromium.org | 2009-03-28 02:09:13 +0100 (Sat, 28 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

This CL fixes a lint issue -- line exceeding 80 characters.
Review URL: http://codereview.chromium.org/56039
------------------------------------------------------------------------
r12728 | darin@chromium.org | 2009-03-28 00:30:22 +0100 (Sat, 28 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/native_web_keyboard_event.h
   M /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   M /trunk/src/chrome/common/native_web_keyboard_event_mac.mm
   M /trunk/src/chrome/common/native_web_keyboard_event_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/webkit/build/WebKit/SConscript
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   M /trunk/src/webkit/build/WebKit/WebKit.vsprops
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/event_conversion.h
   M /trunk/src/webkit/glue/glue.vcproj
   D /trunk/src/webkit/glue/webinputevent.h
   D /trunk/src/webkit/glue/webinputevent_util.cc
   D /trunk/src/webkit/glue/webinputevent_util.h
   D /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webview_host.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_win.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   M /trunk/src/webkit/webkit.gyp

Use Webkit::WebInputEvent and remove webkit/glue/webinputevent.

This change adds a temporary dependency on src/KeyIdentifier.{h,cpp} which I am going to remove after this CL.  I didn't want to grow this CL any larger.

R=dglazkov

Review URL: http://codereview.chromium.org/53099
------------------------------------------------------------------------
r12727 | jcampan@chromium.org | 2009-03-28 00:29:45 +0100 (Sat, 28 Mar 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

The URL in the bug triggers an SSL interstitial for a redirect that redirects to a bad SSL page.

This happens because:
- when proceeding on an interstitial, we wait for the navigation to commit before hiding the current interstitial
- when showing an interstitial, if an interstitial is already showing we call DontProceed on it

In the case of this bug, the interstitial has already been approved when the showing of the 2nd interstitial calls DontProceed on it, causing bad things to happen.

The fix is easy: we shouldn't call DontProceed on an interstitial already "Proceeded".


BUG=9286
TEST=See bug.
Review URL: http://codereview.chromium.org/56019
------------------------------------------------------------------------
r12722 | tc@google.com | 2009-03-28 00:07:30 +0100 (Sat, 28 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/js_before_unload_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/message_box_flags.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/message_box_view.h

Move message flags into a separate header that can be used
outside the views system.  Mac will need this as well when
implementing message boxes.

Review URL: http://codereview.chromium.org/56026
------------------------------------------------------------------------
r12713 | evan@chromium.org | 2009-03-27 22:55:31 +0100 (Fri, 27 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_strip_gtk.cc

Properly fix menu display when using dark system themes.

The drawing code in the tab strip was modifying the GC, which affected
the GC used for drawing menus.

Review URL: http://codereview.chromium.org/55022
------------------------------------------------------------------------
r12706 | brettw@chromium.org | 2009-03-27 21:57:13 +0100 (Fri, 27 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc

Comment out the crashing test so the tree can be open while I fix it.
------------------------------------------------------------------------
r12703 | jam@chromium.org | 2009-03-27 21:45:59 +0100 (Fri, 27 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/plugin.scons
   M /trunk/src/chrome/plugin/plugin.vcproj
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   D /trunk/src/chrome/plugin/plugin_process.cc
   D /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/worker.scons
   M /trunk/src/chrome/worker/worker.vcproj
   M /trunk/src/chrome/worker/worker_main.cc
   D /trunk/src/chrome/worker/worker_process.cc
   D /trunk/src/chrome/worker/worker_process.h
   M /trunk/src/chrome/worker/worker_thread.cc

Refactor plugin process code which checks with the browser process before shutdown, to avoid races in which the browser process thinks the process is fine to use while it's shutting down.  I also removed PluginProcess/WorkerProcess since they didn't have any code in them now.

I removed the plugin process code which waits 10 seconds before shutting itself down.  That was a premature optimization, since testing with/without this didn't show any difference (see http://www/~jabdelmalek/chrome/test/plugins/processes.html).  In both cases, the plugin on a page would get recreated in less than 100ms, even with reusing or starting a plugin process from scratch.  We already spawn new renderer processes on back and forth if it's a different origin, and the plugin will be in the cache anyways.


Review URL: http://codereview.chromium.org/53091
------------------------------------------------------------------------
r12700 | brettw@chromium.org | 2009-03-27 21:39:53 +0100 (Fri, 27 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Reverting 12673.
Review URL: http://codereview.chromium.org/56020
------------------------------------------------------------------------
r12691 | brettw@chromium.org | 2009-03-27 21:01:07 +0100 (Fri, 27 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc

Fix lineendings for dom ui unittest.
Review URL: http://codereview.chromium.org/55037
------------------------------------------------------------------------
r12690 | mbelshe@google.com | 2009-03-27 20:56:54 +0100 (Fri, 27 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Hide StatsTable behind --enable-stats-table.



Review URL: http://codereview.chromium.org/49045
------------------------------------------------------------------------
r12689 | glen@chromium.org | 2009-03-27 20:54:29 +0100 (Fri, 27 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

- Change alignment of 'delete this day' so it's not off floating in the middle of nowhere.
- Fix history text-wrapping issues.

BUG=8147

Review URL: http://codereview.chromium.org/56001
------------------------------------------------------------------------
r12688 | idanan@chromium.org | 2009-03-27 20:50:59 +0100 (Fri, 27 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

Issue 348: can view old incognito cache if main process left running

Same place we clear cookies when the last incognito window is closed,
destroy the entire incognito profile which by implication destoys the
incognito cache.

BUG=348

Review URL: http://codereview.chromium.org/53101
------------------------------------------------------------------------
r12683 | estade@chromium.org | 2009-03-27 20:02:29 +0100 (Fri, 27 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/webkit/glue/webcursor_gtk_data.h

Render widget host view cursors:

- Make UpdateCursorIfOverSelf private and only exist on mac and win.
- update loading state for linux and show a loading cursor appropriately.

BUG=9385
Review URL: http://codereview.chromium.org/53130
------------------------------------------------------------------------
r12677 | pinkerton@chromium.org | 2009-03-27 19:43:57 +0100 (Fri, 27 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Correctly position windows that are detached during a drag, instead of relying on the default window position in the nib. Stub a little more of WindowSizer, but only enough to get drag working. Default new windows to 1024x768.
Review URL: http://codereview.chromium.org/55023
------------------------------------------------------------------------
r12676 | paulg@google.com | 2009-03-27 19:43:08 +0100 (Fri, 27 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix a race condition opening a downloaded file.

There is a potential race condition where we attempt
to open, via the shell, a fast completing download
before it has been renamed. This fix posts the rename
operation before calling DownloadFinished, which posts
the shell open.

BUG=3954 (http://crbug.com/3954)

Review URL: http://codereview.chromium.org/42685
------------------------------------------------------------------------
r12675 | darin@chromium.org | 2009-03-27 19:42:21 +0100 (Fri, 27 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   A /trunk/src/chrome/test/data/sync_xmlhttprequest_disallowed.html
   M /trunk/src/webkit/glue/resource_loader_bridge.cc

Fix renderer hang caused when a synchronous XHR is disallowed for security
reasons (via ShouldServiceReqeuest).

BUG=8401
R=jam

Review URL: http://codereview.chromium.org/56016
------------------------------------------------------------------------
r12673 | evan@chromium.org | 2009-03-27 19:17:12 +0100 (Fri, 27 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Revert "Fix issues with DOM UI that cause focus to not be set to the URL bar and the"

This reverts commit r12668 because it failed to compile on Mac.
------------------------------------------------------------------------
r12668 | brettw@chromium.org | 2009-03-27 18:58:46 +0100 (Fri, 27 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Fix issues with DOM UI that cause focus to not be set to the URL bar and the
URL to be hidden improperly. This code takes into account the somewhat crazy
state that happens during initial tab load.

BUG=9352
TEST=unit test should cover it
Review URL: http://codereview.chromium.org/55015
------------------------------------------------------------------------
r12665 | brettw@chromium.org | 2009-03-27 18:50:53 +0100 (Fri, 27 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc

Disable about:network for official builds since it's buggy.

BUG=9426
Review URL: http://codereview.chromium.org/56009
------------------------------------------------------------------------
r12663 | glen@chromium.org | 2009-03-27 18:01:05 +0100 (Fri, 27 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html

Fix downloads RTL Bustage 

BUG=8433

Review URL: http://codereview.chromium.org/55017
------------------------------------------------------------------------
r12662 | phajdan.jr@chromium.org | 2009-03-27 17:55:39 +0100 (Fri, 27 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Fix interactive_ui_tests failures by temporarily allowing direct dns lookup.

Review URL: http://codereview.chromium.org/56010
------------------------------------------------------------------------
r12661 | glen@chromium.org | 2009-03-27 17:52:05 +0100 (Fri, 27 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/resources/downloads.html

Add date information to the downloads page.

BUG=8433


Review URL: http://codereview.chromium.org/55002
------------------------------------------------------------------------
r12657 | pinkerton@chromium.org | 2009-03-27 17:41:26 +0100 (Fri, 27 Mar 2009) | 1 line
Changed paths:
   A /trunk/src/chrome/browser/cocoa/tab_controller_target.h

Forgot a file in last checkin.
------------------------------------------------------------------------
r12656 | pinkerton@chromium.org | 2009-03-27 17:34:45 +0100 (Fri, 27 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/TabView.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/browser/cocoa/tab_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Hook up close button in tabs. Patch from rohitrao@google.com.
------------------------------------------------------------------------
r12655 | avi@google.com | 2009-03-27 17:32:00 +0100 (Fri, 27 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Don't order the bubble window front; it shows up just fine.

Fix by Rohit.

http://crbug.com/9422
Review URL: http://codereview.chromium.org/55016
------------------------------------------------------------------------
r12653 | phajdan.jr@chromium.org | 2009-03-27 17:22:26 +0100 (Fri, 27 Mar 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/host_resolver_unittest.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/http/http_network_layer_unittest.cc

Prevent making real DNS lookups by chrome tests.

- by default a test which makes external DNS lookup directly or indirectly will fail

- added a quite simple way to allow a test to make external queries

- added a way to make external queries fail (for tests which don't need them to succeed but it's hard to not make the query)

- made neccessary adjustments to existing tests so that they still pass

http://crbug.com/9109

Review URL: http://codereview.chromium.org/45026
------------------------------------------------------------------------
r12650 | avi@google.com | 2009-03-27 17:18:02 +0100 (Fri, 27 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

CreateNewWindowInternal and ShowCreatedWindowInternal aren't actually platform-dependent, so fold them into their only callers, CreateNewWindow and ShowCreatedWindow.

Review URL: http://codereview.chromium.org/42645
------------------------------------------------------------------------
r12640 | pfeldman@chromium.org | 2009-03-27 13:36:21 +0100 (Fri, 27 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_messages_internal.h
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   M /trunk/src/webkit/glue/devtools/tools_agent.h
   M /trunk/src/webkit/glue/webdevtoolsagent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h

DevTools: add support for navigating to other tab while inspecting.


Review URL: http://codereview.chromium.org/53098
------------------------------------------------------------------------
r12632 | huanr@chromium.org | 2009-03-27 04:05:56 +0100 (Fri, 27 Mar 2009) | 28 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

This check in is the initial step to try improve UI
automation framework. Currently we are not consistent in
UI automation. After receiving the automation message,
the automation provider in browser does not always
execute UI commands synchronously. In many cases, it
simply sends back an acknowledgement and dispatches
the command. On the test client side, it waits and
polls the result after sending the message.

I think this causes lots of UI test flakeyness and makes
the test slow. I plan to convert all asynchronous
execution to synchronous. It may take some time to get
them all done. I CC'ed a few people so they are aware of
this ongoing work. Feel free to comment on whether and
how to address the issue.

This check in adds an UI automation message
AutomationMsg_WindowExecuteCommandSync that executes
accelerators synchronously. The existing automation
message AutomationMsg_WindowExecuteCommand only
dispatches the accelerator.

There are many UI accelerators using the existing async
version. In this check in I only made the conversion
for IDC_NEW_TAB to try out the new mechanism.


Review URL: http://codereview.chromium.org/53108
------------------------------------------------------------------------
r12631 | xji@chromium.org | 2009-03-27 02:16:20 +0100 (Fri, 27 Mar 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/views/window/custom_frame_view.cc
   M /trunk/src/chrome/views/window/window_win.cc

This CL fix issue 5724 - RTL: Windows context menu with Alt+Space Bar should be displayed on right side of the window.
(http://crbug.com/5724)

and issue 5738 - RTL: App drop-down menu should be displayed below the favicon
(http://crbug.com/5738)

In RTL UI, the x-axis of the system menu was computed as the MirroredXCoordinateInsideView(x-axis in LTR UI);
Also, the menu was right-aligned relative to the x-axis.

It fixes the system menu position in the following 3 situations:
1. press alt+space (such as in application short-cut, in chrome browser, in pop-up dialog such as option/clear browsing data), the system menu appears on the right side of the window (instead of left side, without the fix).

2. click favicon of application shortcut, the system menu appears on the right side of the window (instead of left side, without the fix).

3. right click on chrome browser tab, system menu appears at
left side of the click (instead of right side of the click).

Please be noted that:
System menu itself is not yet mirrored. This CL only fixes its display position. 
Review URL: http://codereview.chromium.org/53120
------------------------------------------------------------------------
r12629 | jrg@chromium.org | 2009-03-27 01:37:19 +0100 (Fri, 27 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm

Fix leaks found by valgrind (which now works on the Mac!)
http://code.google.com/p/chromium/issues/detail?id=9376

Review URL: http://codereview.chromium.org/53116
------------------------------------------------------------------------
r12624 | estade@chromium.org | 2009-03-27 00:51:20 +0100 (Fri, 27 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

Gtk download shelf:

- show status text (when appropriate)
- set text colors
- limit the size of the download item view and elide text to fit
- don't let download items spill over on the right (hide and show them as shelf grows and shrinks)

Review URL: http://codereview.chromium.org/42672
------------------------------------------------------------------------
r12620 | jhawkins@chromium.org | 2009-03-27 00:33:05 +0100 (Fri, 27 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Change NineBox to render into a GtkWidget.  This offers a minor speedup and simplification of code because we get rid of the pixbuf middleman.
Review URL: http://codereview.chromium.org/42620
------------------------------------------------------------------------
r12616 | tc@google.com | 2009-03-27 00:12:25 +0100 (Fri, 27 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix our browser window close path to be more like windows.

We try to run onbeforeunload handlers (and cause the renderer
to hang) and we close all the tabs first which properly destroys
the tabcontents and webcontents.

Review URL: http://codereview.chromium.org/53083

------------------------------------------------------------------------
r12615 | evan@chromium.org | 2009-03-27 00:10:06 +0100 (Fri, 27 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

More NOTIMPLEMENTEDs into bugs.

Review URL: http://codereview.chromium.org/42668
------------------------------------------------------------------------
r12613 | evan@chromium.org | 2009-03-27 00:06:41 +0100 (Fri, 27 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Fix unintialized variable (only affected unit test).
------------------------------------------------------------------------
r12612 | sky@chromium.org | 2009-03-27 00:06:03 +0100 (Fri, 27 Mar 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/history/query_parser.cc

Temporary fix to avoid crash in typing in Omnibox. The crash happens
if you have a lower case string that is longer than the mixed case
string and we get a match at the end of the string. This crashed
because the offset is now past the end of the string.

This fix is temporary in that it avoids the crash by not highlighting
a match in the string. The right fix will be better parsing so we
correctly recognize how the two strings line up, but that'll happen
later.

BUG=9335
TEST=Create a bookmark with the title on the page
http://www.google.com/support/forum/p/Chrome/thread?fid=3b64f0cdd1e29e94000466022c425763&hl=en
, then type in i and make sure we don't crash. This is also covered by
unit tests now, so don't feel you need to test it.

Review URL: http://codereview.chromium.org/42664
------------------------------------------------------------------------
r12610 | tc@google.com | 2009-03-27 00:05:17 +0100 (Fri, 27 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Fix crash when trying to handle keyboard accelerators
while the current tab contents is no longer in the view
hierarchy (ie., it got switched out).

Review URL: http://codereview.chromium.org/45068

------------------------------------------------------------------------
r12604 | evan@chromium.org | 2009-03-26 22:15:06 +0100 (Thu, 26 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Fix/punt on a bunch of NOTIMPLEMENTEDs.

Review URL: http://codereview.chromium.org/53065
------------------------------------------------------------------------
r12601 | evan@chromium.org | 2009-03-26 22:13:28 +0100 (Thu, 26 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Temporarily work around a hang in unimplemented drag and drop.

Review URL: http://codereview.chromium.org/53105
------------------------------------------------------------------------
r12600 | evan@chromium.org | 2009-03-26 22:12:48 +0100 (Thu, 26 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Make it more obvious when our backing store has failed us.

Review URL: http://codereview.chromium.org/53104
------------------------------------------------------------------------
r12599 | sky@chromium.org | 2009-03-26 22:08:55 +0100 (Thu, 26 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend.cc

Fixes possible crash in visitdb. As far as I can tell the archive_db_
is NULL, leading to this crash.

BUG=8932
TEST=none

Review URL: http://codereview.chromium.org/53112
------------------------------------------------------------------------
r12598 | xji@chromium.org | 2009-03-26 22:06:32 +0100 (Thu, 26 Mar 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

This CL is a work around for the following 2 issues:
issue 7252 --[New Tab] page, the underline of linked text should be under all text
http://crbug.com/7252

issue 7697 -- RTL: New Tab page - bad display of page titles with RTL text
http://crbug.com/7697

The bug is caused by WebKit not rendering text-overflow:ellipsis correctly for mixed bidi text with rtl directionality.

The workaround is to change text-overflow to 'clip' for text with 'rtl' directionality.

(The workaround we thought by changing 'text-overflow' to 'clip' in the style, such as in 'html[dir='rtl'] .thumbnail-title', does not work well. 'text-overflow:clip' caused pure English text overlap with the right-aligned favicon in RTL New Tab page).


Review URL: http://codereview.chromium.org/42636
------------------------------------------------------------------------
r12597 | tc@google.com | 2009-03-26 22:05:07 +0100 (Thu, 26 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix fast shutdown

The check for unload handlers was backwards.  This bug was introduced in r7901 <http://codereview.chromium.org/17453>.

Also, remove the call to process_.Close().  When we Terminate the process, we get a IPC channel error and BrowserRenderProcessHost::OnChannelError gets called.  This method needs the handle so it can call DidProcessCrash.  It also does the call to process_.Close() for us.

Review URL: http://codereview.chromium.org/42653
------------------------------------------------------------------------
r12593 | jrg@chromium.org | 2009-03-26 21:34:59 +0100 (Thu, 26 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Fix build

------------------------------------------------------------------------
r12588 | jam@chromium.org | 2009-03-26 20:40:29 +0100 (Thu, 26 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   A /trunk/src/chrome/test/data/npapi/private.html
   M /trunk/src/chrome/test/ui/npapi_test_helper.cc
   M /trunk/src/chrome/test/ui/npapi_test_helper.h
   M /trunk/src/chrome/test/ui/npapi_uitest.cpp
   M /trunk/src/third_party/npapi/bindings/npapi.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/test/npapi_test_plugin.vcproj
   M /trunk/src/webkit/glue/plugins/test/plugin_client.cc
   A /trunk/src/webkit/glue/plugins/test/plugin_private_test.cc
   A /trunk/src/webkit/glue/plugins/test/plugin_private_test.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.h

Expose whether we're in private browsing mode to plugins.I chose to implement this for multi-process mode only and not --single-process or --in-process-plugins, since I wanted to send this data from the browser process, not the renderer (in case it's exploited).

BUG=158
Review URL: http://codereview.chromium.org/52037
------------------------------------------------------------------------
r12586 | jrg@chromium.org | 2009-03-26 20:37:43 +0100 (Thu, 26 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/render_view.cc

Minor tweaks to get chrome-ui://extensions working on the Mac.

Review URL: http://codereview.chromium.org/42627
------------------------------------------------------------------------
r12582 | estade@chromium.org | 2009-03-26 19:50:51 +0100 (Thu, 26 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Linux download shelf:

- Show status text.
- Pack new items on the left.

Review URL: http://codereview.chromium.org/53084
------------------------------------------------------------------------
r12581 | tc@google.com | 2009-03-26 19:43:26 +0100 (Thu, 26 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Hook up ctrl+tab and ctrl+shift+tab for switching tabs in linux

We can't just add accelerators for these because GDK_Tab and GDK_ISO_Left_Tab are not valid accelerator keys:
http://www.google.com/codesearch/p?hl=en#ycarM8Ghiog/gtk+-2.4.0/gtk/gtkaccelgroup.c&q=gtk_accel_groups_activate&l=805

Instead, handle these keys in keypress and forward the event on to BrowserWindowGtk::OnAccelerator directly.  We stash a pointer to BrowserWindowGtk on the GtkWindow.

Review URL: http://codereview.chromium.org/42611

------------------------------------------------------------------------
r12575 | pinkerton@chromium.org | 2009-03-26 19:26:46 +0100 (Thu, 26 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm

Make the standard tab width wider to better match windows.
Review URL: http://codereview.chromium.org/42652
------------------------------------------------------------------------
r12573 | avi@google.com | 2009-03-26 19:05:19 +0100 (Thu, 26 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Enable child RWHVs on the Mac.

http://crbug.com/8824

Review URL: http://codereview.chromium.org/45040
------------------------------------------------------------------------
r12568 | sky@chromium.org | 2009-03-26 18:49:11 +0100 (Thu, 26 Mar 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/webkit_glue.h

Fixes bug where first login attempt to hotmail after session restore
wouldn't work. The problem was we weren't storing post URLs at all
(because of bug 1361980). This resulted in session restore trying to
restore some redirects along the way that likely had bogus state in
them (perhaps referencing cookies that were nuked), resulting in the
first login failing. The fix is to persist POST URLs to disk for
session restore, but not the actual POST data. This way there
shouldn't be any problems as outlined in 1361980.

BUG=7727
TEST=see bug

Review URL: http://codereview.chromium.org/42619
------------------------------------------------------------------------
r12555 | avi@google.com | 2009-03-26 17:10:57 +0100 (Thu, 26 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

WebContentsView became more than just an interface with 48103 (r12483). If we move web_contents_ to the base class, we might as well finish the job.

Review URL: http://codereview.chromium.org/49041
------------------------------------------------------------------------
r12554 | robertshield@google.com | 2009-03-26 17:05:21 +0100 (Thu, 26 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc


Passing a foreground window to the google update code so that if it triggers UAC prompts, they can launch in the foreground.

Review URL: http://codereview.chromium.org/42606
------------------------------------------------------------------------
r12552 | pinkerton@chromium.org | 2009-03-26 16:48:57 +0100 (Thu, 26 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_view.mm

Remove obsolete TODOs.
Review URL: http://codereview.chromium.org/49042
------------------------------------------------------------------------
r12550 | pinkerton@chromium.org | 2009-03-26 16:30:28 +0100 (Thu, 26 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Allow live tabs to be dragged out of a window. Change TabStripModel such that
the caller must now explicitly show the newly created browser rather than it
happening automatically. 
------------------------------------------------------------------------
r12544 | deanm@chromium.org | 2009-03-26 13:47:08 +0100 (Thu, 26 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Revert Linux Omnibox color changes in r12516.

This just reverts the Omnibox portion of the change.  This code is structured to match Windows, and will eventually be pulled from LocationBarView.

Review URL: http://codereview.chromium.org/53093

------------------------------------------------------------------------
r12540 | xji@chromium.org | 2009-03-26 07:25:07 +0100 (Thu, 26 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

This CL fix issue 8649 -- RTL: Wrong parenthesis direction is displayed on "About Google Chrome" dialog
(http://crbug.com/8649).

The fix is to adjust the string according to locale,
so that the pure English string in RTL locale is surrounded by left-right-embedding mark for parenthesis to be displayed correctly.


Review URL: http://codereview.chromium.org/42096
------------------------------------------------------------------------
r12539 | xji@chromium.org | 2009-03-26 07:22:06 +0100 (Thu, 26 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util_unittest.cc

Fix the path layout in both bookmark manager and download location. (issue 8997)
http://crbug.com/8997

Previously, the path itself and every single path component are marked with LTR marks.

The fix is only mark the path as a whole (but not every single path component)with LTR marks.

Review URL: http://codereview.chromium.org/49034
------------------------------------------------------------------------
r12533 | brettw@chromium.org | 2009-03-26 03:52:55 +0100 (Thu, 26 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Fix purify error for DOM UI unit test.
Review URL: http://codereview.chromium.org/42633
------------------------------------------------------------------------
r12520 | rvargas@google.com | 2009-03-26 00:44:20 +0100 (Thu, 26 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   A /trunk/src/net/base/cache_type.h
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/backend_impl.h
   M /trunk/src/net/disk_cache/backend_unittest.cc
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc
   M /trunk/src/net/disk_cache/disk_cache_test_base.cc
   M /trunk/src/net/disk_cache/eviction.cc
   M /trunk/src/net/disk_cache/eviction.h
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/disk_cache/trace.cc
   M /trunk/src/net/disk_cache/trace.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/net.gyp
   M /trunk/src/net/tools/crash_cache/crash_cache.cc

Disk cache: First pass to make it possible to have
multiple instances of BackendImpl. We need multiple
objects to be able to support media files on the cache.

After this change, histograms will be the only thing that
get messed up by multiple disk caches.

Review URL: http://codereview.chromium.org/49027
------------------------------------------------------------------------
r12517 | jcampan@chromium.org | 2009-03-26 00:27:19 +0100 (Thu, 26 Mar 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc
   A /trunk/src/chrome/views/focus/focus_util_win.cc (from /trunk/src/chrome/views/focus/focus_util_win.cc:12499)
   A /trunk/src/chrome/views/focus/focus_util_win.h (from /trunk/src/chrome/views/focus/focus_util_win.h:12499)
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/widget/widget_win.h

Relanding since it was breaking the Release build (because of missing includes).


Moving the mouse-wheel message rerouting code out of the focus manager.
This is part of the effort of making the focus manager not window specific.

BUG=None
TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with
a Chrome window, the option window, the task manager table) when it is active
and when it is inactive. Also try using the mouse-wheel on a plugin with a
scroll-view (for example
http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html)
when the browser window is not active, the plugin should scroll.
TBR=ben

Review URL: http://codereview.chromium.org/42624
------------------------------------------------------------------------
r12516 | estade@chromium.org | 2009-03-26 00:24:14 +0100 (Thu, 26 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Linux UI theming:

- Improve appearance of menus by setting background to white (matching windows and fitting better with the overall appearance).
- Disable user theming of native widgets: since our widgets are a hodge-podge of native and custom-drawn, there's no way we can support user theming. Eventually users will be able to choose a theme for chromium; until then make everything look like chrome.

Review URL: http://codereview.chromium.org/49035
------------------------------------------------------------------------
r12515 | brettw@chromium.org | 2009-03-26 00:12:16 +0100 (Thu, 26 Mar 2009) | 15 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc (from /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc:12475)
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Make the bookmarks bar disappear when the load after the new tab page commits
rather than when it is pending. This makes it change at the same time the
page changes.

To support this, we now have to keep track of both a pending and a committed
DOMUI object. This is tracked by the RenderManager, which does a similar
swapping between pending and committed RenderViewHosts.

Previous review URL: http://codereview.chromium.org/42512
The only difference is I swapped the order of creating the DOM UI in
RenderViewHostManager::Navigate.

BUG=8963

Review URL: http://codereview.chromium.org/42623
------------------------------------------------------------------------
r12510 | jhawkins@chromium.org | 2009-03-25 23:47:11 +0100 (Wed, 25 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_strip_gtk.cc

Use the correct g_free instead of free when freeing memory passed to us from gtk.
Review URL: http://codereview.chromium.org/53072
------------------------------------------------------------------------
r12509 | thestig@chromium.org | 2009-03-25 23:43:37 +0100 (Wed, 25 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

Add an exception to DownloadManager::GenerateExtension() for .tar.gz files with mime_type "application/x-tar".

BUG=5772
Review URL: http://codereview.chromium.org/42622
------------------------------------------------------------------------
r12508 | aa@chromium.org | 2009-03-25 23:40:23 +0100 (Wed, 25 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions_ui.html

Restore revision 12329, which I accidentally clobbered when
I moved this file.

See:
http://codereview.chromium.org/49011
http://codereview.chromium.org/42435

Review URL: http://codereview.chromium.org/42585
------------------------------------------------------------------------
r12501 | jrg@chromium.org | 2009-03-25 23:11:43 +0100 (Wed, 25 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   M /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller_unittest.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Bookmark menu work.  Notes:
- "add bookmark" menu item enable state (e.g. disabled if no windows)
- bookmark menus built dynamically (like before)
- bookmark menus rebuild when a bookmark is added/removed
- bookmark menus take the current browser to where you want to go
- works with multiple windows (main window goes to bookmark location)
- works with no windows (bookmarks open a new window)

Review URL: http://codereview.chromium.org/49005
------------------------------------------------------------------------
r12500 | jcampan@chromium.org | 2009-03-25 23:05:11 +0100 (Wed, 25 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc
   D /trunk/src/chrome/views/focus/focus_util_win.cc
   D /trunk/src/chrome/views/focus/focus_util_win.h
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/widget/widget_win.h

Reverting 12498.
Review URL: http://codereview.chromium.org/53073
------------------------------------------------------------------------
r12499 | cpu@google.com | 2009-03-25 22:55:44 +0100 (Wed, 25 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h

Wire the alternate desktop shortcut text
- second set of changes, one small one to come
- adds a parameter on the desktop shortcut creator function that indicate the text to use
- plumbs the master preference and the command line parameter

BUG=1522969


Review URL: http://codereview.chromium.org/42586
------------------------------------------------------------------------
r12498 | jcampan@chromium.org | 2009-03-25 22:55:15 +0100 (Wed, 25 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/views/focus/focus_manager.cc
   A /trunk/src/chrome/views/focus/focus_util_win.cc
   A /trunk/src/chrome/views/focus/focus_util_win.h
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/widget/widget_win.h

Moving the mouse-wheel message rerouting code out of the focus manager.
This is part of the effort of making the focus manager not window specific.

BUG=None
TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with a Chrome window, the option window, the task manager table) when it is active and when it is inactive. Also try using the mouse-wheel on a plugin with a scroll-view (for example http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html) when the browser window is not active, the plugin should scroll.
Review URL: http://codereview.chromium.org/53037
------------------------------------------------------------------------
r12497 | avi@google.com | 2009-03-25 22:51:40 +0100 (Wed, 25 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Fix crasher due to improperly initializing variables.

Review URL: http://codereview.chromium.org/45060
------------------------------------------------------------------------
r12492 | evan@chromium.org | 2009-03-25 21:55:42 +0100 (Wed, 25 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Revert "Fix/punt on a bunch of NOTIMPLEMENTEDs."

This reverts commit r12489.
------------------------------------------------------------------------
r12491 | brettw@chromium.org | 2009-03-25 21:45:28 +0100 (Wed, 25 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble_views.cc

Remove the black line from the bottom of the status bubble.

TEST=Make the Chrome window on top of a white window with a link at the very
     bottom of the window. Hover over the link so that the status bubble moves
     outside the chrome window and over the background. The bottom line should
     be consistent and not have the part under the text be black.
Review URL: http://codereview.chromium.org/53068
------------------------------------------------------------------------
r12490 | willchan@chromium.org | 2009-03-25 21:42:55 +0100 (Wed, 25 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/net/base/client_socket_handle.cc
   M /trunk/src/net/base/client_socket_handle.h
   M /trunk/src/net/base/client_socket_pool.cc
   M /trunk/src/net/base/client_socket_pool.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_request_info.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Reverting 12479 which reverted 12470.

This change is the same as 12470, except with HttpRequestInfo::priority initialized in the initializer list, which should fix the purify errors.
Review URL: http://codereview.chromium.org/53066
------------------------------------------------------------------------
r12489 | evan@chromium.org | 2009-03-25 21:31:47 +0100 (Wed, 25 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Fix/punt on a bunch of NOTIMPLEMENTEDs.

Review URL: http://codereview.chromium.org/53065
------------------------------------------------------------------------
r12485 | darin@chromium.org | 2009-03-25 20:55:08 +0100 (Wed, 25 Mar 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/weburlrequest_impl.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Chrome changes to support cached form submissions.

The solution is to add a user-defined identifier to UploadData.
If that identifier is set, and if the request method is POST,
then HttpCache will enable caching for the response.  (The cache
key will be a composition of the identifier and the URL.)  A
subsequent POST request to the same URL with the same identifier
will "hit" the previously generated cache entry.  Reuse from the
cache is subject to all of the standard rules.

For reference, here are the corresponding net changes:
http://codereview.chromium.org/52028

Here are the corresponding WebKit changes:
http://trac.webkit.org/changeset/41919

BUG=2636
R=sky
Review URL: http://codereview.chromium.org/52040
------------------------------------------------------------------------
r12483 | estade@chromium.org | 2009-03-25 20:46:28 +0100 (Wed, 25 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

Refactor some widget creation code in web_contents_view and render_widget_host_view.

This only affects popups. The advantages of this refactoring are to get rid of a TODO and allow some unforking of web_contents_view_*.

Review URL: http://codereview.chromium.org/48103
------------------------------------------------------------------------
r12482 | estade@chromium.org | 2009-03-25 20:45:59 +0100 (Wed, 25 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/base/clipboard.cc
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/base/scoped_clipboard_writer.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/tools/gtk_clipboard_dump/gtk_clipboard_dump.cc
   M /trunk/src/webkit/glue/webclipboard_impl.cc

Linux: write images to clipboard.

Writing a bitmap to the clipboard is a rather slow operation, as it involves piping it over IPC and then converting it to a PNG.

Review URL: http://codereview.chromium.org/42592
------------------------------------------------------------------------
r12479 | willchan@chromium.org | 2009-03-25 20:18:03 +0100 (Wed, 25 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/net/base/client_socket_handle.cc
   M /trunk/src/net/base/client_socket_handle.h
   M /trunk/src/net/base/client_socket_pool.cc
   M /trunk/src/net/base/client_socket_pool.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_request_info.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Reverting 12470.

caused purify errors
Review URL: http://codereview.chromium.org/45055
------------------------------------------------------------------------
r12476 | brettw@chromium.org | 2009-03-25 19:41:13 +0100 (Wed, 25 Mar 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 12469.
Review URL: http://codereview.chromium.org/53062
------------------------------------------------------------------------
r12475 | phajdan.jr@chromium.org | 2009-03-25 19:30:45 +0100 (Wed, 25 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h

Cleanup in chrome/browser

- make more things const
- remove unreferenced declaration of GetGoButton
- fix indentation in one place

Review URL: http://codereview.chromium.org/53053
------------------------------------------------------------------------
r12474 | estade@chromium.org | 2009-03-25 19:29:00 +0100 (Wed, 25 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webcursor_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc

Don't override user's default cursor with GDK_ARROW.

BUG=8786

Review URL: http://codereview.chromium.org/42587
------------------------------------------------------------------------
r12470 | willchan@chromium.org | 2009-03-25 19:14:29 +0100 (Wed, 25 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/net/base/client_socket_handle.cc
   M /trunk/src/net/base/client_socket_handle.h
   M /trunk/src/net/base/client_socket_pool.cc
   M /trunk/src/net/base/client_socket_pool.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_request_info.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Prioritize which HTTP requests get a socket first by adding a priority level to various methods and classes.  Fix lint errors along the way.

R=darin,wtc
BUG=8993
Review URL: http://codereview.chromium.org/42541
------------------------------------------------------------------------
r12469 | brettw@chromium.org | 2009-03-25 19:14:29 +0100 (Wed, 25 Mar 2009) | 10 lines
Changed paths:
   A /trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unittests.vcproj

Make the bookmarks bar disappear when the load after the new tab page commits
rather than when it is pending. This makes it change at the same time the
page changes.

To support this, we now have to keep track of both a pending and a committed
DOMUI object. This is tracked by the RenderManager, which does a similar
swapping between pending and committed RenderViewHosts.

BUG=8963
Review URL: http://codereview.chromium.org/42512
------------------------------------------------------------------------
r12450 | sky@google.com | 2009-03-25 15:39:31 +0100 (Wed, 25 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/infobars/infobars.cc

Removes bogus DCHECK in ConfirmInfoBar::ButtonPressed. The DCHECK is
bogus as InfoBar adds a button that invokes this method as well.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/53034
------------------------------------------------------------------------
r12449 | sky@google.com | 2009-03-25 15:39:13 +0100 (Wed, 25 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Moves bookmark menu to be before other menus.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/42568
------------------------------------------------------------------------
r12434 | hbono@chromium.org | 2009-03-25 05:31:11 +0100 (Wed, 25 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   A /trunk/src/webkit/glue/webtextdirection.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h

A tricky fix for Issue 1845 (Take 2).

This is almost the same change as <http://codereview.chromium.org/39252/show>, which caused a build break on a Linux buildbot while compiling my new template function in "chrome/common/render_messages.h".
Even though I was not able to reproduce the build errors on my Linux box, I removed this function and use the int type in my IPC message 'ViewMsg_SetTextDirection'.

BUG=1845
Review URL: http://codereview.chromium.org/42495
------------------------------------------------------------------------
r12426 | jungshik@google.com | 2009-03-25 01:57:18 +0100 (Wed, 25 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookmark
s.html' file. Update the unit test to match the change in bookmark_html_writer.cc

The initial CL got reverted because the unittest failed. This CL changes the unittest. 



BUG=6957

Review URL: http://codereview.chromium.org/48042
------------------------------------------------------------------------
r12423 | tc@google.com | 2009-03-25 01:36:17 +0100 (Wed, 25 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_strip_gtk.cc

Don't try to paint tabs if there are no tabs to paint.

BUG=9214

Review URL: http://codereview.chromium.org/53033

------------------------------------------------------------------------
r12418 | hclam@chromium.org | 2009-03-25 01:10:46 +0100 (Wed, 25 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc

Fix a bug in RDH that it overlooked a resource message
TBR=darin
ViewHostMsg_DownloadProgress_ACK is a resource message but it is
overlooked by RDH and thus not processed. This patch adds the
message to ResourceDispatcherHost::IsResourceDispatcherHostMessage
to enable processing the message.

Review URL: http://codereview.chromium.org/53030
------------------------------------------------------------------------
r12417 | hclam@chromium.org | 2009-03-25 01:09:23 +0100 (Wed, 25 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Folder path was not set correctly for media cache
TBR=darin
Fixed a bug in ProfileImpl and OffTheRecordProfileImpl that path to
media cache folder was set incorrectly.

Review URL: http://codereview.chromium.org/45046
------------------------------------------------------------------------
r12410 | thestig@chromium.org | 2009-03-25 00:38:01 +0100 (Wed, 25 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc

Prevent data read errors from crashing the browser.

In ResourceDispatcherHost::OnResponseStarted(), if Read() causes an error, it calls OnResponseCompleted(). For a download, this hits the NOTREACHED() in DownloadThrottlingResourceHandler::OnResponseCompleted().

This patch checks for the error status, and returns false, which causes the download to finish, which saves an empty file of size 0.

BUG=8170
Review URL: http://codereview.chromium.org/42573
------------------------------------------------------------------------
r12408 | aa@chromium.org | 2009-03-25 00:35:48 +0100 (Wed, 25 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   D /trunk/src/chrome/browser/resources/extensions.html
   A /trunk/src/chrome/browser/resources/extensions_toolstrip.css
   A /trunk/src/chrome/browser/resources/extensions_ui.html (from /trunk/src/chrome/browser/resources/extensions.html:12398)
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Implement default css for toolstrips.

Review URL: http://codereview.chromium.org/42435
------------------------------------------------------------------------
r12403 | idanan@chromium.org | 2009-03-25 00:27:29 +0100 (Wed, 25 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/test_location_bar.h
   M /trunk/src/chrome/views/controls/button/custom_button.cc
   M /trunk/src/chrome/views/controls/button/custom_button.h

Redone http://codereview.chromium.org/42571

Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. 

BUG=6477
TBR=maruel

Review URL: http://codereview.chromium.org/53020
------------------------------------------------------------------------
r12395 | estade@chromium.org | 2009-03-24 21:40:44 +0100 (Tue, 24 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/platform_util.h
   A /trunk/src/chrome/common/platform_util_linux.cc
   A /trunk/src/chrome/common/platform_util_mac.mm
   A /trunk/src/chrome/common/platform_util_win.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Implement basic ShowItemInFolder for linux.

Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future.


Review URL: http://codereview.chromium.org/52034
------------------------------------------------------------------------
r12388 | estade@chromium.org | 2009-03-24 21:14:16 +0100 (Tue, 24 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h

Switch some more ASCII locale code wstrings to strings.

Also, don't alphabetize available spellchecker locale codes.

Review URL: http://codereview.chromium.org/42531
------------------------------------------------------------------------
r12385 | maruel@chromium.org | 2009-03-24 20:35:15 +0100 (Tue, 24 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/controls/button/custom_button.cc
   M /trunk/src/chrome/views/controls/button/custom_button.h

Reverting r12383, caused a build breakage on all platforms.

TBR=idanan
Review URL: http://codereview.chromium.org/42571
------------------------------------------------------------------------
r12383 | idanan@chromium.org | 2009-03-24 20:06:12 +0100 (Tue, 24 Mar 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/controls/button/custom_button.cc
   M /trunk/src/chrome/views/controls/button/custom_button.h

Issue 6477: Support modifier clicks on UI elements

Mouse event flags transformed to WindoOpenDisposition so that
browser commands can all inteterpert event modifiers. Implemented
home, forward and backwards middle-click andshift middle click.

Previously working on issue 358 which was market a duplicate
and concerned with the home and tabstrip subset of this behavior:
Can't open a new tab by middle-clicking home button.

No functionality has been lost or altered, only the use ofmodifiers
give access to increased functionality.

BUG=6477
TBR=ben@chromium.org

------------------------------------------------------------------------
r12378 | tc@google.com | 2009-03-24 19:38:12 +0100 (Tue, 24 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

Make the find bar blue.  Hooks up the prev/next buttons and the
close button.

Review URL: http://codereview.chromium.org/50079

------------------------------------------------------------------------
r12375 | glen@chromium.org | 2009-03-24 19:21:03 +0100 (Tue, 24 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html

New tab page was linking to the wrong URL for the history page. We don't need the message and can just put an actual URL in the page.

BUG=8961

Review URL: http://codereview.chromium.org/49014
------------------------------------------------------------------------
r12371 | deanm@chromium.org | 2009-03-24 19:13:30 +0100 (Tue, 24 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Improve the Linux Omnibox ssl background / scheme coloring.

We now correctly reset the background color on tab switches, and navigations from a ssl to non-ssl page.

BUG=8236,9225

Review URL: http://codereview.chromium.org/49015

------------------------------------------------------------------------
r12366 | glen@chromium.org | 2009-03-24 18:55:39 +0100 (Tue, 24 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/theme/download_progress_background32.png
   M /trunk/src/chrome/app/theme/download_progress_foreground32.png
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/resources/downloads.html

Add a progress meter to the downloads page.

Add the progress status text indicator code from the old history page.

Make 'cancel' visible when paused.

More RTL fixes.

BUG=8220,8334

Review URL: http://codereview.chromium.org/42550
------------------------------------------------------------------------
r12365 | glen@chromium.org | 2009-03-24 18:54:47 +0100 (Tue, 24 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_backend.cc

History import was exercising a codepath that didn't have code to update HistoryBackend::first_recorded_time_

BUG=8827


Review URL: http://codereview.chromium.org/42546
------------------------------------------------------------------------
r12364 | sky@google.com | 2009-03-24 18:49:42 +0100 (Tue, 24 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Fixes crash in new tab page when searching from a field other than the
first.

BUG=8583
TEST=see bug

Review URL: http://codereview.chromium.org/42566
------------------------------------------------------------------------
r12359 | pinkerton@chromium.org | 2009-03-24 16:27:45 +0100 (Tue, 24 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm

Make sure we never pass a nil charcode, AppKit gets very unhappy about that.
Review URL: http://codereview.chromium.org/45033
------------------------------------------------------------------------
r12356 | phajdan.jr@chromium.org | 2009-03-24 15:28:46 +0100 (Tue, 24 Mar 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unit_tests.scons

Porting of unit tests in chrome/

- enable following tests on Linux:
    browser/net/resolve_proxy_msg_helper_unittest.cc
    browser/profile_manager_unittest.cc
    browser/sessions/tab_restore_service_unittest.cc
    common/time_format_unittest.cc

- sync chrome.gyp

- fix a bug in resolve_proxy_msg_helper_unittest that triggered
  a DCHECK on POSIX.

  It freed the WaitableEvent too early because Wait in dtor
  was effectively a noop because the event was already in signaled
  state from previous operations and a manual-reset flag was set.

  The fix was to put the WaitableEvent in automatic reset mode.

- misc GCC-related cleanups

http://crbug.com/9227

Review URL: http://codereview.chromium.org/53007
------------------------------------------------------------------------
r12355 | pfeldman@chromium.org | 2009-03-24 14:54:28 +0100 (Tue, 24 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/renderer/devtools_agent.cc
   M /trunk/src/chrome/renderer/devtools_agent.h
   M /trunk/src/chrome/renderer/devtools_messages_internal.h
   M /trunk/src/webkit/glue/devtools/dom_agent.h
   M /trunk/src/webkit/glue/devtools/dom_agent_impl.cc
   M /trunk/src/webkit/glue/devtools/dom_agent_impl.h
   M /trunk/src/webkit/glue/devtools/dom_agent_unittest.cc
   M /trunk/src/webkit/glue/devtools/js/devtools.js
   M /trunk/src/webkit/glue/devtools/js/devtools_callback.js
   M /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   M /trunk/src/webkit/glue/devtools/js/dom_agent.js
   M /trunk/src/webkit/glue/devtools/js/inspector_controller_impl.js
   M /trunk/src/webkit/glue/webdevtoolsagent.h
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsagent_impl.h
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.cc
   M /trunk/src/webkit/glue/webdevtoolsclient_impl.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Wire 'Inspect Element' action to the new DevTools (depending on the devtools flag):
- Add new devtools IPC message
- Expose WebView's hit target
- Refactor dom_agent interaction not to send information known to client
- Collect incoming messages on the client until frontend is loaded
- Add Inspect Element scenario into the devtools_host_stub

Review URL: http://codereview.chromium.org/45022
------------------------------------------------------------------------
r12348 | phajdan.jr@chromium.org | 2009-03-24 10:34:14 +0100 (Tue, 24 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h

Get rid of WaitForWindowCountToChange.

The function had confusing semantics, was marked to be removed,
and could induce flakiness in tests which used it.

WaitForWindowCountToBecome is much better replacement for it.

Review URL: http://codereview.chromium.org/49007
------------------------------------------------------------------------
r12347 | aa@chromium.org | 2009-03-24 10:18:27 +0100 (Tue, 24 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_api_handler.cc
   A /trunk/src/chrome/browser/extensions/extension_api_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/extensions/extension_process_bindings.cc
   A /trunk/src/chrome/renderer/extensions/extension_process_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/renderer/renderer_resources.grd
   A /trunk/src/chrome/renderer/resources/extension_process_bindings.js
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.h

Add basic infrastructure for sending async browser API request and receiving results.

Review URL: http://codereview.chromium.org/42262
------------------------------------------------------------------------
r12339 | hclam@chromium.org | 2009-03-24 03:51:15 +0100 (Tue, 24 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Fix a bug in ResourceMessageFilter
TBR=darin
There's a typo in resource_message_filter.cc that disallows
media request context being used for any requests. This
patch fixes it.

Review URL: http://codereview.chromium.org/42548
------------------------------------------------------------------------
r12335 | jam@chromium.org | 2009-03-24 03:01:11 +0100 (Tue, 24 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/webkit/glue/webworkerclient.h

Finish hooking up the worker process UI: use the domains of the workers as the title in the task manager, and show an infobar when a page's workers die.

I also cleaned up the code in RenderView which creates a window and widget, since when I originally wrote it I wasn't aware of RenderViewHost::FromID.

Review URL: http://codereview.chromium.org/45025
------------------------------------------------------------------------
r12332 | glen@chromium.org | 2009-03-24 01:38:44 +0100 (Tue, 24 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/downloads.html
   M /trunk/src/chrome/browser/resources/history.html

Make the history and downloads pages work in RTL.

BUG=8334

Review URL: http://codereview.chromium.org/42544
------------------------------------------------------------------------
r12329 | georged@chromium.org | 2009-03-24 01:22:09 +0100 (Tue, 24 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions.html

Extensions now support css user script definition. This checkin adds
the css user script information to chrome-ui://extensions/

Review URL: http://codereview.chromium.org/49011
------------------------------------------------------------------------
r12322 | mpcomplete@google.com | 2009-03-23 23:38:43 +0100 (Mon, 23 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_message_service.cc
   M /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc

Rename ExtensionMessageService::PostMessage because windows #defines that to
be something that breaks our build.

TBR=aa
Review URL: http://codereview.chromium.org/52029
------------------------------------------------------------------------
r12319 | mpcomplete@google.com | 2009-03-23 23:21:43 +0100 (Mon, 23 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_message_service.cc
   A /trunk/src/chrome/browser/extensions/extension_message_service.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/renderer/extensions/extension_bindings.cc
   D /trunk/src/chrome/renderer/extensions/extension_bindings.h
   A /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc
   A /trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html

Initial rev at a message passing API for extensions.  So far, only passing
messages to the extension process is supported.
Review URL: http://codereview.chromium.org/48090
------------------------------------------------------------------------
r12317 | ben@chromium.org | 2009-03-23 22:55:52 +0100 (Mon, 23 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/views/controls/button/button.h
   R /trunk/src/chrome/views/controls/button/checkbox.cc (from /trunk/src/chrome/views/controls/button/checkbox2.cc:12233)
   R /trunk/src/chrome/views/controls/button/checkbox.h (from /trunk/src/chrome/views/controls/button/checkbox2.h:12235)
   D /trunk/src/chrome/views/controls/button/checkbox2.cc
   D /trunk/src/chrome/views/controls/button/checkbox2.h
   R /trunk/src/chrome/views/controls/button/native_button.cc (from /trunk/src/chrome/views/controls/button/native_button2.cc:12233)
   R /trunk/src/chrome/views/controls/button/native_button.h (from /trunk/src/chrome/views/controls/button/native_button2.h:12172)
   D /trunk/src/chrome/views/controls/button/native_button2.cc
   D /trunk/src/chrome/views/controls/button/native_button2.h
   M /trunk/src/chrome/views/controls/button/native_button_win.cc
   M /trunk/src/chrome/views/controls/button/native_button_win.h
   M /trunk/src/chrome/views/controls/button/native_button_wrapper.h
   R /trunk/src/chrome/views/controls/button/radio_button.cc (from /trunk/src/chrome/views/controls/button/radio_button2.cc:12235)
   R /trunk/src/chrome/views/controls/button/radio_button.h (from /trunk/src/chrome/views/controls/button/radio_button2.h:12235)
   D /trunk/src/chrome/views/controls/button/radio_button2.cc
   D /trunk/src/chrome/views/controls/button/radio_button2.h
   M /trunk/src/chrome/views/controls/message_box_view.cc
   M /trunk/src/chrome/views/controls/message_box_view.h
   M /trunk/src/chrome/views/controls/native_control_win.cc
   M /trunk/src/chrome/views/focus/focus_manager_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/window/dialog_client_view.cc
   M /trunk/src/chrome/views/window/dialog_client_view.h
   M /trunk/src/chrome/views/window/dialog_delegate.cc

The death knell for the old native buttons, checkboxes and radio buttons.
Replace with renamed NativeButton2, Checkbox2, RadioButton2.

Review URL: http://codereview.chromium.org/50083
------------------------------------------------------------------------
r12316 | jhawkins@chromium.org | 2009-03-23 22:47:30 +0100 (Mon, 23 Mar 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/tab_strip_gtk.cc
   A /trunk/src/chrome/browser/gtk/tab_strip_gtk.h
   M /trunk/src/chrome/chrome.gyp

Add initial implementation of the Linux TabStrip.

The following are implemented:
* Keyboard shortcuts for next/prev/close tab.
* Tab layout and rendering.

The following need to be implemented:
* Mouse input handling.
* Animations.
* TabGtk, TabRendererGtk.
* Dragging.
* Fix a NOTREACHED in navigation_controller.cc.

Review URL: http://codereview.chromium.org/42457
------------------------------------------------------------------------
r12314 | maruel@chromium.org | 2009-03-23 22:23:06 +0100 (Mon, 23 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc

Removed zombie hunter code

BUG=6468

Review URL: http://codereview.chromium.org/46076
------------------------------------------------------------------------
r12310 | shess@chromium.org | 2009-03-23 22:00:36 +0100 (Mon, 23 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Fully enable history_url_provider_unittest.cc for Mac.

gfx::GetCleanStringFromUrl() got implemented for Mac at some point (I
suspect when fonts landed), so now all of this code should be
portable.

There is a slight difference in how ElideUrl() works, due to font
metric differences, but that should not be relevant to this code.

Review URL: http://codereview.chromium.org/42513
------------------------------------------------------------------------
r12305 | erg@google.com | 2009-03-23 21:26:56 +0100 (Mon, 23 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/chrome/views/event.h
   A /trunk/src/chrome/views/event_gtk.cc
   A /trunk/src/chrome/views/event_win.cc
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/root_view_gtk.cc
   M /trunk/src/chrome/views/widget/widget_gtk.cc
   M /trunk/src/chrome/views/widget/widget_gtk.h

Deliver events and notifications to the RootView.

Review URL: http://codereview.chromium.org/42519

------------------------------------------------------------------------
r12298 | hclam@chromium.org | 2009-03-23 19:57:14 +0100 (Mon, 23 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

BUG=9094

GetRequestContextForMedia() in ProfileImpl and OffTheRecordProfileImpl
now respect --disk-cache-dir. Since the snippet for getting the path
from --disk-cache-dir is very short, it's not necessary to keep it in
a separate method so I duplicated the snippet and used it in both
classes.

Review URL: http://codereview.chromium.org/42517
------------------------------------------------------------------------
r12297 | hclam@chromium.org | 2009-03-23 19:45:45 +0100 (Mon, 23 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Fix an invalid DCHECK for media request context
BUG=9082

Since I forwarded CreateOffTheRecordForMedia to
CreateOriginalForMedia, it triggers a DCHECK. Since the
implementation of off the record media cache is not going to be
implemented soon, I duplicated the implementation of
CreateOriginalForMedia.

Review URL: http://codereview.chromium.org/42467
------------------------------------------------------------------------
r12287 | avi@google.com | 2009-03-23 17:10:12 +0100 (Mon, 23 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Updating to use scoped_nsobject.

Review URL: http://codereview.chromium.org/52017
------------------------------------------------------------------------
r12284 | avi@google.com | 2009-03-23 16:28:57 +0100 (Mon, 23 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Hook up popup windows on Mac (no blocking yet).

Review URL: http://codereview.chromium.org/52015
------------------------------------------------------------------------
r12281 | phajdan.jr@chromium.org | 2009-03-23 15:35:35 +0100 (Mon, 23 Mar 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/chrome/test/ui/ui_tests.scons

Port more UI tests to Linux.

- enable following ui tests on Linux:
    history_uitest.cc
    inspector_controller_uitest.cc
    browser/history/redirect_uitest.cc
    browser/locale_tests_uitest.cc
    browser/sanity_uitest.cc

- move information about Linux-specific splash page
  to more generic location and enable more logic
  about start page on Linux

- maintainability cleanups (DISABLED_ instead of #if 0)

- misc GCC-related cleanups

Review URL: http://codereview.chromium.org/49006
------------------------------------------------------------------------
r12280 | avi@google.com | 2009-03-23 15:23:15 +0100 (Mon, 23 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc

Handle null window_id references and refer to a bug for further improvement.

Review URL: http://codereview.chromium.org/47002
------------------------------------------------------------------------
r12274 | yurys@google.com | 2009-03-23 11:43:58 +0100 (Mon, 23 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/devtools_client_host.h
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   M /trunk/src/chrome/browser/debugger/devtools_manager_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.h
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/browser/debugger/devtools_window_gtk.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_mac.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.cc
   M /trunk/src/chrome/browser/debugger/devtools_window_win.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/data/purify/unit_tests.exe.gtest.txt

Currently we have two types of devtools UI: Chrome built in developer tools window and remote debugger connected over TCP(apavlov is working on it). To allow DevToolsManager coordinate both types of devtools uniformly their API is extracted into DevToolsClientHost interface.

Fix purify errors in DevToolsManager unit tests.
BUG=9150
Review URL: http://codereview.chromium.org/50009
------------------------------------------------------------------------
r12273 | rafaelw@chromium.org | 2009-03-23 06:05:49 +0100 (Mon, 23 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/resources/extensions.html
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json

Support for extensions permissions. This CL only contains, parsing, initializing values into Extension, outputting values to the extension_ui, and appropriate unit test changes


Review URL: http://codereview.chromium.org/42480
------------------------------------------------------------------------
r12271 | jar@chromium.org | 2009-03-23 03:45:11 +0100 (Mon, 23 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/base/field_trial.cc
   M /trunk/src/base/field_trial.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/net/http/http_network_transaction.cc

Attempt to detect impact of disabling dns prefetching on transaction latency

This is also meant to exercise the field trial infrastructure.

r=mbelshe
Review URL: http://codereview.chromium.org/50084
------------------------------------------------------------------------
r12269 | shess@chromium.org | 2009-03-22 21:41:40 +0100 (Sun, 22 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/renderer/render_widget_unittest.cc

Free unit tests for Mac: BookmarkHTMLWriterTest, BookmarkUtilsTest,
DownloadRequestManagerTest, URLFetcher*Test, TimeFormat, RenderWidgetTest

Review URL: http://codereview.chromium.org/50081
------------------------------------------------------------------------
r12267 | nsylvain@chromium.org | 2009-03-22 18:01:07 +0100 (Sun, 22 Mar 2009) | 3 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_user_script_inject_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   D /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   D /trunk/src/chrome/browser/extensions/test_extension_loader.h
   D /trunk/src/chrome/test/data/extensions/user_script_inject
   D /trunk/src/chrome/test/data/extensions/user_script_inject_page.html
   M /trunk/src/chrome/test/unit/unittests.vcproj

Revert change 12247 because it created a lot of memory regressions
in the purify unit test.
Review URL: http://codereview.chromium.org/45021
------------------------------------------------------------------------
r12265 | pfeldman@chromium.org | 2009-03-22 07:42:12 +0100 (Sun, 22 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   A /trunk/src/webkit/glue/devtools/devtools_copy.rules
   A /trunk/src/webkit/glue/devtools/js
   A /trunk/src/webkit/glue/devtools/js/base.js
   A /trunk/src/webkit/glue/devtools/js/devtools.html
   A /trunk/src/webkit/glue/devtools/js/devtools.js
   A /trunk/src/webkit/glue/devtools/js/devtools_host_stub.js
   A /trunk/src/webkit/glue/devtools/js/dom.js
   A /trunk/src/webkit/glue/devtools/js/inspector_controller.js
   A /trunk/src/webkit/glue/devtools/js/inspector_controller_impl.js
   A /trunk/src/webkit/glue/devtools/js/json.js
   A /trunk/src/webkit/glue/devtools/js/net.js
   M /trunk/src/webkit/glue/glue.vcproj

Initial revision of the DevTools frontend.

Review URL: http://codereview.chromium.org/45012
------------------------------------------------------------------------
r12248 | finnur@chromium.org | 2009-03-21 18:21:21 +0100 (Sat, 21 Mar 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc

Bug 6474: Rename the Cancel button to Close in Clear Browsing Data.

At one point we changed the Clear Browsing Data dialog to remember
the values of the combobox and the checkboxes between runs. Like 
with the Options dialog, changes you make take effect immediately
and as such having a Cancel button is misleading. Therefore, I am
proposing we rename it to Close.

BUG=6474
TEST=Open Clear Browsing Data dialog. The button should now say
Close.

Review URL: http://codereview.chromium.org/45019
------------------------------------------------------------------------
r12247 | aa@chromium.org | 2009-03-21 17:32:40 +0100 (Sat, 21 Mar 2009) | 9 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_user_script_inject_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   A /trunk/src/chrome/browser/extensions/test_extension_loader.cc
   A /trunk/src/chrome/browser/extensions/test_extension_loader.h
   A /trunk/src/chrome/test/data/extensions/user_script_inject
   A /trunk/src/chrome/test/data/extensions/user_script_inject/1
   A /trunk/src/chrome/test/data/extensions/user_script_inject/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/user_script_inject/1/script.js
   A /trunk/src/chrome/test/data/extensions/user_script_inject/Current Version
   A /trunk/src/chrome/test/data/extensions/user_script_inject_page.html
   M /trunk/src/chrome/test/unit/unittests.vcproj

Committing issue 39299:
Test for extension user script load and inject.

This add a test that a user script actually gets injected into
pages and runs. Before we only had unit tests for the various
classes and weren't testing the system end-to-end.

Review URL: http://codereview.chromium.org/51003
Patch from Steve Krulewitz <skrulx@gmail.com>.
------------------------------------------------------------------------
r12244 | aa@chromium.org | 2009-03-21 06:36:49 +0100 (Sat, 21 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip.html
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip1.html (from /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip.html:12243)
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip2.html (from /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip.html:12243)

Allow multiple toolstrips in an extension.

Review URL: http://codereview.chromium.org/42439
------------------------------------------------------------------------
r12238 | paulg@google.com | 2009-03-21 02:24:01 +0100 (Sat, 21 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Remove the old and no longer used SafeBrowsing storage
implementation.
Review URL: http://codereview.chromium.org/45016
------------------------------------------------------------------------
r12227 | estade@chromium.org | 2009-03-20 23:54:59 +0100 (Fri, 20 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Fix linux input breakage: Don't wrap an important line in a DCHECK!

------------------------------------------------------------------------
r12221 | jcampan@chromium.org | 2009-03-20 23:28:17 +0100 (Fri, 20 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Pressing the Del key while a item is selected in the autocomplete popup deletes that suggestion from the DB.

BUG=6176
TEST=Bring up the autofill popup in a form. Select an item and press the Del key. The item should be removed from the popup and should not show on subsequent autofill popups.
Review URL: http://codereview.chromium.org/42258
------------------------------------------------------------------------
r12220 | finnur@chromium.org | 2009-03-20 23:00:44 +0100 (Fri, 20 Mar 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h

Fix DCHECK in DownloadRequestDialogDelegateWin::DeleteDelegate

This DCHECK occurs when we click Allow on the "This webpage is trying to download multiple files" dialog.

When...
   DownloadRequestDialogDelegate
... and ...
   DownloadRequestDialogDelegateWin
... were created, both classes by accident contained a host_ member.

This causes a DCHECK in...

   DownloadRequestDialogDelegateWin::DeleteDelegate()

... because the host_ in the child class is never initialized. I
believe the intent is to check the host_ of the parent class, so
I deleted the definition of host from xxxDelegateWin.

Review URL: http://codereview.chromium.org/50072
------------------------------------------------------------------------
r12219 | estade@chromium.org | 2009-03-20 22:56:56 +0100 (Fri, 20 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Remove errant debugging line.

Review URL: http://codereview.chromium.org/50073
------------------------------------------------------------------------
r12217 | sky@google.com | 2009-03-20 22:38:29 +0100 (Fri, 20 Mar 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/app/theme/menu_bookmark.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.h
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   A /trunk/src/chrome/browser/views/bookmark_menu_button.cc
   A /trunk/src/chrome/browser/views/bookmark_menu_button.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/views/controls/button/menu_button.h

Adds a bookmark menu. This is experimental. To turn on you need
--bookmark-menu.

BUG=3206
TEST=Turn on the bookmark menu via --bookmark-menu and make sure it
  works. Also make sure I didn't break anything on the bookmark bar.

Review URL: http://codereview.chromium.org/42460
------------------------------------------------------------------------
r12214 | tc@google.com | 2009-03-20 22:13:46 +0100 (Fri, 20 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Consolidate into a single shutdown path.

This consolidates the shutdown path.  We used to have two paths depending
of whether the user hit the X on the window manager or used wrench -> exit.
Now both do the same thing: call BrowserWindowGtk::Close().

Review URL: http://codereview.chromium.org/42372

------------------------------------------------------------------------
r12213 | phajdan.jr@chromium.org | 2009-03-20 22:06:37 +0100 (Fri, 20 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_tests.scons

Enable first UI test on Linux (browser/images_uitest.cc)

- less things #ifdef-ed
- replaced Windows-specific functions with portable equivalents

Review URL: http://codereview.chromium.org/50059
------------------------------------------------------------------------
r12210 | aa@chromium.org | 2009-03-20 21:38:43 +0100 (Fri, 20 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json

Allow multiple js files per content script. Thanks to georged for making this so easy.

Review URL: http://codereview.chromium.org/42438
------------------------------------------------------------------------
r12209 | estade@chromium.org | 2009-03-20 21:35:40 +0100 (Fri, 20 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: Restore normal event handling for key events that are not to be sent to webkit.

We want to pass all key events to webkit. But other widgets shouldn't get key events till after they've been checked against our accelerators. This fixes the problem that pressing ctrl-page{up,down} in the location bar moves the cursor rather than changing tabs.

Review URL: http://codereview.chromium.org/50069
------------------------------------------------------------------------
r12207 | klink@chromium.org | 2009-03-20 21:12:25 +0100 (Fri, 20 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   D /trunk/src/chrome/common/accessibility.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/glue.vcproj
   D /trunk/src/webkit/glue/glue_accessibility.cc
   D /trunk/src/webkit/glue/glue_accessibility.h
   A /trunk/src/webkit/glue/glue_accessibility_object.cc
   A /trunk/src/webkit/glue/glue_accessibility_object.h
   A /trunk/src/webkit/glue/webaccessibility.h
   A /trunk/src/webkit/glue/webaccessibilitymanager.h
   A /trunk/src/webkit/glue/webaccessibilitymanager_impl.cc
   A /trunk/src/webkit/glue/webaccessibilitymanager_impl.h

Removes all use of COM and dependencies on Windows-specific classes (including the use of AccessibleBase and AccessibleDocument) in the glue accessibility implementation.Introduces the GlueAccessibilityObject, which serves as a platform-independent wrapper directly around WebKit's AccessibilityObject (also platoform-independent).Updates naming/comments to reflect the independence of IAccessible both in glue and (where appropriate) in the browser-side accessibility. 
Review URL: http://codereview.chromium.org/46013
------------------------------------------------------------------------
r12206 | estade@chromium.org | 2009-03-20 20:37:34 +0100 (Fri, 20 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h

Linux UI hook ups:

- Fix new tab focus
- attach f5 for refresh

Review URL: http://codereview.chromium.org/42422
------------------------------------------------------------------------
r12200 | estade@chromium.org | 2009-03-20 19:16:04 +0100 (Fri, 20 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Hook up ctrl-w for close tab on linux.

Delay the handling of certain accelerators so we don't try to destroy a widget that GTK is reffing as a result of event handling.

Patch based on another by Dean McNamee.

Review URL: http://codereview.chromium.org/42421
------------------------------------------------------------------------
r12198 | pinkerton@chromium.org | 2009-03-20 18:59:26 +0100 (Fri, 20 Mar 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.h
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/chrome.gyp

Implement context menus on Mac.
Review URL: http://codereview.chromium.org/42448
------------------------------------------------------------------------
r12188 | avi@google.com | 2009-03-20 16:00:50 +0100 (Fri, 20 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Updating TODO list; turns out that the fade is working but too quickly for my laptop to show.

Review URL: http://codereview.chromium.org/47003
------------------------------------------------------------------------
r12186 | pinkerton@chromium.org | 2009-03-20 14:25:01 +0100 (Fri, 20 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Rewrite tab layout to a centralized method rather than moving things around ad hoc in the insert and delete tab methods. Tabs now scale down in size (to a min size) rather than overflowing. Selected tab takes on normal size. 
Review URL: http://codereview.chromium.org/42411
------------------------------------------------------------------------
r12184 | estade@chromium.org | 2009-03-20 05:14:58 +0100 (Fri, 20 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Make GTK accelerator setup code more compact.

Review URL: http://codereview.chromium.org/50042
------------------------------------------------------------------------
r12178 | abarth@chromium.org | 2009-03-20 02:37:47 +0100 (Fri, 20 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   A /trunk/src/chrome/test/data/ssl/blank_page.html
   A /trunk/src/chrome/test/data/ssl/page_with_http_script.html
   A /trunk/src/chrome/test/data/ssl/randomize_hash.js

SSLPolicy fix: Step 9 of 9 (hopefully!).

Change our algorithm for computing the state of our SSL security indicators.  Previously, we were computing this state for a single navigation entry.  Although this matches other browsers, it fails to take the same-origin policy into account.  For example, if one tab is contaminated with insecure content, that insecure content can spread to all the tabs in the same security origin.

R=jcampan,wtc
BUG=8706
TEST=SSLUITest.TestMixedContentsRandomizeHash,SSLUITest.TestMixedContentsTwoTabs

Review URL: http://codereview.chromium.org/42314
------------------------------------------------------------------------
r12172 | erg@google.com | 2009-03-20 00:54:35 +0100 (Fri, 20 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/controls/button/custom_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/chrome/views/widget/root_view_gtk.cc
   M /trunk/src/chrome/views/widget/root_view_win.cc
   M /trunk/src/chrome/views/widget/widget_gtk.cc
   M /trunk/src/chrome/views/window/window_win.cc
   M /trunk/src/skia/ext/platform_canvas_linux.h

Now have a TextButton rendering (sort of; doesn't respond to mouse events so
I don't know if it'll draw the border correctly).

Now with fixes to compile under Windows.

Review URL: http://codereview.chromium.org/42427

------------------------------------------------------------------------
r12166 | jar@chromium.org | 2009-03-19 23:24:50 +0100 (Thu, 19 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/time_win_unittest.cc
   M /trunk/src/base/tracked_objects.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h

Fix a bunch of tiny near-bugs and bugs that static analysis identified

r=mbelshe,brettw
Review URL: http://codereview.chromium.org/50014
------------------------------------------------------------------------
r12163 | erg@google.com | 2009-03-19 23:07:48 +0100 (Thu, 19 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/controls/button/custom_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/chrome/views/widget/root_view_gtk.cc
   M /trunk/src/chrome/views/widget/root_view_win.cc
   M /trunk/src/chrome/views/widget/widget_gtk.cc
   M /trunk/src/skia/ext/platform_canvas_linux.h

Revert "Now have a TextButton rendering." Broke Windows.

TBR=beng

Review URL: http://codereview.chromium.org/50035

------------------------------------------------------------------------
r12162 | erg@google.com | 2009-03-19 23:02:24 +0100 (Thu, 19 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/controls/button/custom_button.cc
   M /trunk/src/chrome/views/controls/button/text_button.cc
   M /trunk/src/chrome/views/widget/root_view.cc
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/chrome/views/widget/root_view_gtk.cc
   M /trunk/src/chrome/views/widget/root_view_win.cc
   M /trunk/src/chrome/views/widget/widget_gtk.cc
   M /trunk/src/skia/ext/platform_canvas_linux.h

Now have a TextButton rendering (sort of; doesn't respond to mouse events so I don't know if it'll draw the border correctly).

Review URL: http://codereview.chromium.org/42414

------------------------------------------------------------------------
r12160 | ben@chromium.org | 2009-03-19 22:18:44 +0100 (Thu, 19 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/controls/button/checkbox.cc
   A /trunk/src/chrome/views/controls/button/checkbox2.cc
   A /trunk/src/chrome/views/controls/button/checkbox2.h
   A /trunk/src/chrome/views/controls/button/native_button2.cc
   A /trunk/src/chrome/views/controls/button/native_button2.h
   M /trunk/src/chrome/views/controls/button/native_button_win.cc
   M /trunk/src/chrome/views/controls/button/native_button_win.h
   M /trunk/src/chrome/views/controls/button/native_button_wrapper.h
   M /trunk/src/chrome/views/controls/button/radio_button.cc
   M /trunk/src/chrome/views/controls/hwnd_view.cc
   M /trunk/src/chrome/views/controls/hwnd_view.h
   M /trunk/src/chrome/views/controls/native_control_win.cc
   M /trunk/src/chrome/views/controls/native_control_win.h
   M /trunk/src/chrome/views/controls/text_field.cc
   M /trunk/src/chrome/views/views.vcproj

Create cross-platform NativeButton2 class that wraps a NativeButtonWin.Once I get this to work I'll rename it NativeButton and remove the old one.
Review URL: http://codereview.chromium.org/48117
------------------------------------------------------------------------
r12158 | tc@google.com | 2009-03-19 22:04:11 +0100 (Thu, 19 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/find_bar.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/webkit/glue/find_in_page_request.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Convert FindInPage wstrings to string16.

Review URL: http://codereview.chromium.org/42408

------------------------------------------------------------------------
r12155 | pinkerton@chromium.org | 2009-03-19 21:53:07 +0100 (Thu, 19 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Implement focusing location bar with cmd-L on mac. Removes some more platform ifdefs that are no longer necessary in Browser. Patch from thakis@google.com.
------------------------------------------------------------------------
r12125 | pinkerton@chromium.org | 2009-03-19 20:11:25 +0100 (Thu, 19 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/BrowserWindow.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_view.mm
   A /trunk/src/chrome/browser/cocoa/tab_window_controller.h
   A /trunk/src/chrome/browser/cocoa/tab_window_controller.mm
   M /trunk/src/chrome/chrome.gyp

Stage 1 of tab dragging infrastructure, disabled. Put in a base class below the browser window for windows with tabs to promote re-use in contexts other than just the browser. Add code to the tab view to track drags, but it's disabled as it still needs much work.
Review URL: http://codereview.chromium.org/42397
------------------------------------------------------------------------
r12108 | sidchat@google.com | 2009-03-19 19:06:20 +0100 (Thu, 19 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Remove extra language under "Spell-checker options" context menu

Issue=8127
Review URL: http://codereview.chromium.org/48082
------------------------------------------------------------------------
r12106 | avi@google.com | 2009-03-19 18:53:06 +0100 (Thu, 19 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Fixing build by initializing all variables; TBR.

------------------------------------------------------------------------
r12103 | avi@google.com | 2009-03-19 18:40:18 +0100 (Thu, 19 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   M /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm

Make the status bubble avoid the mouse.

Review URL: http://codereview.chromium.org/42398
------------------------------------------------------------------------
r12097 | erg@google.com | 2009-03-19 18:26:23 +0100 (Thu, 19 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/test/ui/ui_tests.scons
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/controls/tabbed_pane.cc
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/chrome/views/event.h
   A /trunk/src/chrome/views/fill_layout.cc
   A /trunk/src/chrome/views/fill_layout.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/chrome/views/widget/root_view_gtk.cc
   A /trunk/src/chrome/views/widget/widget_gtk.cc
   A /trunk/src/chrome/views/widget/widget_gtk.h
   M /trunk/src/chrome/views/widget/widget_win.cc
   M /trunk/src/chrome/views/widget/widget_win.h
   M /trunk/src/skia/ext/platform_canvas_linux.h

Render into a ChromeCanvasPaint object in a RootView under Linux.

Review URL: http://codereview.chromium.org/45014

------------------------------------------------------------------------
r12091 | avi@google.com | 2009-03-19 16:10:15 +0100 (Thu, 19 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc

Plumb up mouse motion for the status bubbles.

Review URL: http://codereview.chromium.org/48151
------------------------------------------------------------------------
r12089 | hbono@chromium.org | 2009-03-19 13:06:14 +0100 (Thu, 19 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h

A quick fix for Issue 2720.
To investigate this issue, we noticed some IMEs got confused when we change the text in a rich-edit control and finish an ongoing IME composition while they are composing a text. To prevent this, we accept keywords when they are activated.
Review URL: http://codereview.chromium.org/42275
------------------------------------------------------------------------
r12087 | darin@chromium.org | 2009-03-19 08:31:20 +0100 (Thu, 19 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/web_cache_manager_unittest.cc

Fix WebCacheManager unit tests to use a WebCacheManager instance per test case.
This avoids problems caused by other unit tests that modify the shared instance.

TBR=abarth

Review URL: http://codereview.chromium.org/42386
------------------------------------------------------------------------
r12085 | darin@chromium.org | 2009-03-19 07:27:47 +0100 (Thu, 19 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/cache_manager_host.cc
   D /trunk/src/chrome/browser/cache_manager_host.h
   D /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/renderer_host/web_cache_manager.cc (from /trunk/src/chrome/browser/cache_manager_host.cc:11619)
   A /trunk/src/chrome/browser/renderer_host/web_cache_manager.h (from /trunk/src/chrome/browser/cache_manager_host.h:11619)
   A /trunk/src/chrome/browser/renderer_host/web_cache_manager_unittest.cc (from /trunk/src/chrome/browser/cache_manager_host_unittest.cc:11619)
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_webkitclient_impl.cc
   M /trunk/src/webkit/build/WebKit/SConscript
   M /trunk/src/webkit/build/WebKit/WebKit.vcproj
   M /trunk/src/webkit/build/WebKit/WebKit.vsprops
   M /trunk/src/webkit/build/WebKit/using_WebKit.vsprops
   M /trunk/src/webkit/build/webkit_common_includes.vsprops
   M /trunk/src/webkit/glue/SConscript
   D /trunk/src/webkit/glue/cache_manager.cc
   D /trunk/src/webkit/glue/cache_manager.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.h
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.cc
   M /trunk/src/webkit/glue/simple_webmimeregistry_impl.h
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webclipboard_impl.h
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkitclient_impl.cc
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webthemeengine_impl_win.cc
   M /trunk/src/webkit/glue/webthemeengine_impl_win.h
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/webkit.gyp

Chrome-side of moving webkit/glue/cache_manager.{h,cc} to the WebKit API layer.

This also includes a change to not have third_party/WebKit/WebKit/chromium/public
in the global include path.  Most of the code changes pertain to this.

I also took this opportunity to do some renaming:
  browser/cache_manager_host -> browser/renderer_host/web_cache_manager

R=brettw

Review URL: http://codereview.chromium.org/42194
------------------------------------------------------------------------
r12083 | abarth@chromium.org | 2009-03-19 06:41:06 +0100 (Thu, 19 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h

Remove useless BlockedRequest class.

R=wtc
BUG=8860

Review URL: http://codereview.chromium.org/42384
------------------------------------------------------------------------
r12080 | agl@chromium.org | 2009-03-19 05:06:37 +0100 (Thu, 19 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc

Check return value of AbsolutePath

(found by Coverity)

Review URL: http://codereview.chromium.org/48161

------------------------------------------------------------------------
r12074 | georged@chromium.org | 2009-03-19 03:32:39 +0100 (Thu, 19 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc


Review URL: http://codereview.chromium.org/42382
------------------------------------------------------------------------
r12046 | cpu@google.com | 2009-03-19 01:10:48 +0100 (Thu, 19 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc

Reuse the eula terms from the chrome resources
- that outta reduce the fat that setup.exe gained
- this is the chrome side of the fix

BUG=8894

Review URL: http://codereview.chromium.org/48114
------------------------------------------------------------------------
r12040 | jam@chromium.org | 2009-03-19 00:47:54 +0100 (Thu, 19 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/common/child_process_info.h

Fix single-process ui test failures from my previous change.  The problem was that the wrong pid was being sent to RDH from RMF.  It needs to be the fake pid for the in-process renderer.

BUG=8890
Review URL: http://codereview.chromium.org/42366
------------------------------------------------------------------------
r12038 | jam@chromium.org | 2009-03-19 00:46:53 +0100 (Thu, 19 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/debug_flags.h
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/worker/worker_main.cc

Refactor sandboxing code so that it can be used by worker processes.

Review URL: http://codereview.chromium.org/42311
------------------------------------------------------------------------
r12035 | agl@chromium.org | 2009-03-19 00:42:13 +0100 (Thu, 19 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc

Add missing 'return true' to stop switch fall though.

(found by Coverity)

Review URL: http://codereview.chromium.org/42370

------------------------------------------------------------------------
r12034 | tc@google.com | 2009-03-19 00:41:02 +0100 (Thu, 19 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Navigating to about:memory page from Task manager should bring up the
minimized
browser window.

BUG=4557 ( http://crbug.com/4557 )

Original patch by Mohamed Mansour <m0.interactive@gmail.com> in
http://codereview.chromium.org/42208/show

Review URL: http://codereview.chromium.org/48167

------------------------------------------------------------------------
r12032 | agl@chromium.org | 2009-03-19 00:28:06 +0100 (Thu, 19 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc

Linux: fix crash when renderer asks for the location of a NULL window

There are cases where the renderer asks for the root rectangle of its
window before we have a window for it. Since we still have the
NativeViewId hack in place, this previously caused a crash.

Review URL: http://codereview.chromium.org/42356

------------------------------------------------------------------------
r12030 | agl@chromium.org | 2009-03-19 00:24:48 +0100 (Thu, 19 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc

Check return values for ReadInt in SSL manager

(found by Coverity)

Review URL: http://codereview.chromium.org/42369

------------------------------------------------------------------------
r12025 | agl@chromium.org | 2009-03-19 00:20:40 +0100 (Thu, 19 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix possible memory leak.

(Coverity discovered it.)

Review URL: http://codereview.chromium.org/49002

------------------------------------------------------------------------
r12021 | hclam@chromium.org | 2009-03-18 23:57:04 +0100 (Wed, 18 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

CreateResourceRequest() in
chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
is not updated when |request_context| is added to
ViewHostMsg_Resource_Request.

In r11816 CreateResourceRequest() is used to prepare
ViewHostMsg_Resource_Request with |request_context| uninitialized,
giving the purify bot red. Initializing the variable should fix the
UMR error.

Review URL: http://codereview.chromium.org/42360
------------------------------------------------------------------------
r12016 | georged@chromium.org | 2009-03-18 22:26:24 +0100 (Wed, 18 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/style1.css
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/style2.css
   M /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h


Review URL: http://codereview.chromium.org/42288
------------------------------------------------------------------------
r12014 | finnur@chromium.org | 2009-03-18 22:17:21 +0100 (Wed, 18 Mar 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h

Bug 4688: First run bubble ignores user's keyboard attempt
(tab) to change Search Engine. Not a good first impression.

BUG=4688
TEST=Open Chrome using --first-run, press Cancel on the
import dialog and watch the First Run bubble come up. Use Tab
and then Enter and the Change Search Engine should appear.

Then try it again, but this time click outside the bubble to
dismiss it (corner case that could lead to a crash).

Review URL: http://codereview.chromium.org/48138
------------------------------------------------------------------------
r12012 | agl@chromium.org | 2009-03-18 22:04:27 +0100 (Wed, 18 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Linux: fix scrolling

I had assuming that we always scroll the whole window; I was wrong.
This patch fixes issues with 'ghost' scrollbars appearing when the
window looses focus and with huge misrendering when scrolling iframes.

Review URL: http://codereview.chromium.org/42357

------------------------------------------------------------------------
r12009 | estade@chromium.org | 2009-03-18 21:50:46 +0100 (Wed, 18 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Ports all of the chrome/browser/history code to use FilePath, except
for DownloadDatabase, InMemoryDatabase, and RedirectUiTest.  Except for in those
files, we now only use std::wstring for text strings.

This CL also enables two more unittests on Mac.

patch by Rohit Rao.
http://codereview.chromium.org/48018

------------------------------------------------------------------------
r11998 | phajdan.jr@chromium.org | 2009-03-18 20:08:32 +0100 (Wed, 18 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider_list.cc
   M /trunk/src/chrome/browser/automation/automation_provider_list.h
   A /trunk/src/chrome/browser/automation/automation_provider_list_generic.cc
   A /trunk/src/chrome/browser/automation/automation_provider_list_mac.mm
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/test/startup/startup_test.cc

Make startup_tests build and work on Mac.

Also ensure that Chromium.app quits properly between the tests.

http://crbug.com/8391

Review URL: http://codereview.chromium.org/42306
------------------------------------------------------------------------
r11991 | estade@chromium.org | 2009-03-18 19:32:07 +0100 (Wed, 18 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc

Implement GTK dropdown menus.

These are used for <select> html items, for example.

Review URL: http://codereview.chromium.org/48054
------------------------------------------------------------------------
r11988 | estade@chromium.org | 2009-03-18 19:03:45 +0100 (Wed, 18 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Fix mac build break.

tbr=avi

Review URL: http://codereview.chromium.org/48139
------------------------------------------------------------------------
r11983 | robertshield@google.com | 2009-03-18 18:39:43 +0100 (Wed, 18 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc


Fix underflow that would cause either an access violation or an infinite loop if we were ever to get a "chrome_config" node back in metrics response data.

Review URL: http://codereview.chromium.org/42335
------------------------------------------------------------------------
r11982 | estade@chromium.org | 2009-03-18 18:38:26 +0100 (Wed, 18 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Remove BrowserWindow::Init().

This belongs as a private method of BrowserView. Neither mac nor linux uses it.

Review URL: http://codereview.chromium.org/42298
------------------------------------------------------------------------
r11981 | paulg@google.com | 2009-03-18 18:36:47 +0100 (Wed, 18 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Fix errors detected by coverity.
Review URL: http://codereview.chromium.org/48136
------------------------------------------------------------------------
r11980 | avi@google.com | 2009-03-18 18:36:45 +0100 (Wed, 18 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/renderer_host/resource_message_filter_gtk.cc
   A /trunk/src/chrome/browser/renderer_host/resource_message_filter_mac.mm
   A /trunk/src/chrome/browser/renderer_host/resource_message_filter_win.cc
   M /trunk/src/chrome/chrome.gyp

Adds Get(Root)WindowRect handlers for the Mac.

Fixes http://crbug.com/8829 .

Review URL: http://codereview.chromium.org/42336
------------------------------------------------------------------------
r11975 | jianli@chromium.org | 2009-03-18 18:24:55 +0100 (Wed, 18 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc

Reland the changes to use command line switch to turn on worker feature.
Review URL: http://codereview.chromium.org/48106
------------------------------------------------------------------------
r11974 | thestig@chromium.org | 2009-03-18 18:19:50 +0100 (Wed, 18 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/waitable_event.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/disk_cache/mapped_file.h
   M /trunk/src/net/http/http_auth.h
   M /trunk/src/net/http/http_vary_data.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/bitmap_platform_device_mac.h
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc

Remove unneeded uses of base/ref_counted.h.
Review URL: http://codereview.chromium.org/48105
------------------------------------------------------------------------
r11973 | idanan@chromium.org | 2009-03-18 18:17:25 +0100 (Wed, 18 Mar 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix dragging a Chrome window which has a single tab by the tab itself.

A change in 9953 made a tab of a single chrome-window with a single tab part of the
client area so that double-clicks on it are not treated as non-client double-clicks
and that the tab context-menu appears instead of the system context menu (see issue
3787). That change also solved issue 2827 (which is not restructed to the close
button of the right-most tab).

Change 10929 reverted 9953 partially, keeping the sinle-tab of a single-window as
part of the client area but removed the double-click swallowing code that was needed
to fix 2827. In doing so, dragging a single-tabbed single chrome window by the tab
(not the tabstrip) no longer worked. This small changes only fixes that behavior. It
turns out that there was a use case where some users want double-clicks to be considered
as two single-clicks (see issue 8287) and swallowing the double-click breaks this.

Review URL: http://codereview.chromium.org/46033
------------------------------------------------------------------------
r11966 | brettw@chromium.org | 2009-03-18 16:37:51 +0100 (Wed, 18 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

Remove an assertion I added in my DOM UI change. It looks like this happens in
some cases and doesn't represent an actual problem.
Review URL: http://codereview.chromium.org/48134
------------------------------------------------------------------------
r11964 | finnur@chromium.org | 2009-03-18 15:59:35 +0100 (Wed, 18 Mar 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/find_bar_controller.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/views/controls/hwnd_view.cc
   M /trunk/src/webkit/glue/webframe_impl.cc

Fixing a few minor issues found during static analysis of the Chromium codebase.

find_bar_controller.cc:

Unused local variable created.

hwnd_view.cc:

The local definition of parent overshadows param passed in.

google_update.cc:

Uninitialized member variable.

webframe_impl.cc:

The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change.

Review URL: http://codereview.chromium.org/42321
------------------------------------------------------------------------
r11962 | phajdan.jr@chromium.org | 2009-03-18 15:35:58 +0100 (Wed, 18 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/base/base.gyp
   M /trunk/src/base/base.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/directory_watcher.h
   A /trunk/src/base/directory_watcher_inotify.cc
   M /trunk/src/base/directory_watcher_unittest.cc
   M /trunk/src/base/directory_watcher_win.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc

Port DirectoryWatcher to Linux using inotify.

Review URL: http://codereview.chromium.org/42037
------------------------------------------------------------------------
r11954 | hbono@chromium.org | 2009-03-18 07:18:58 +0100 (Wed, 18 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   D /trunk/src/webkit/glue/webtextdirection.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h

Reverting 11953.
Review URL: http://codereview.chromium.org/48121
------------------------------------------------------------------------
r11953 | hbono@chromium.org | 2009-03-18 06:46:29 +0100 (Wed, 18 Mar 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   A /trunk/src/webkit/glue/webtextdirection.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h

A tricky fix for Issue 1845.

This change is a very tricky fix for Issue 1845 in chromium: cant alignt text to the right using right shift and right ctrl.This change consists of two parts listed below.

1. Emulating the implementation of Safari that changes the text-direction of an input element.

Safari uses context menus to change the text direction. This change adds an IPC message 'ViewMsg_SetTextDirection', which notifies the new text direction. Also, it adds two functions: RenderWidgetHost::UpdateTextDirection() and RenderWidgetHost::NotifyTextDirection(). They encapsulate the new IPC message so that we can use them both when we presses a set of keys and when we add context-menu items which change the text direction.

2. Calling the above interface when pressing right-shift and right-control keys, or when left-shift and left-control keys.

This modifies the RenderWidgetHostViewWin::OnKeyEvent() function and call the above text-direction interfaces when a user finishes pressing the keys. As you can imagine, if we send an IPC message every time when we receive a WM_KEYDOWN event, we continue sending IPC messages while a user is pressing the keys.

BUG=1845
Review URL: http://codereview.chromium.org/39252
------------------------------------------------------------------------
r11938 | abarth@chromium.org | 2009-03-18 02:26:39 +0100 (Wed, 18 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc

Remove bogus DCHECK
------------------------------------------------------------------------
r11937 | abarth@chromium.org | 2009-03-18 02:07:07 +0100 (Wed, 18 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h

SSLPolicy Fix: Step 8.

Cleanup the SSLPolicy API.  This should be the last reorganization patch.  The next step should be the substantive changes.

R=jcampan
BUG=8706

Review URL: http://codereview.chromium.org/48091
------------------------------------------------------------------------
r11936 | jrg@chromium.org | 2009-03-18 01:57:49 +0100 (Wed, 18 Mar 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/nibs/en.lproj/MainMenu.xib
   M /trunk/src/chrome/app/nibs/en.lproj/TabContents.xib
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.h
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_bar_state_controller_unittest.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.h
   A /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm
   A /trunk/src/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
   A /trunk/src/chrome/browser/cocoa/browser_test_helper.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.h

Mac bookmark work.  

- The bookmark menu is populated dynamically with bookmarks, including
  subfolders --> submenus.  E.g. star something --> shows up in menu.
  Menu items are disabled but always present and current.
- Always Show Bookmarks" menu now live; reads from / writes to
  preference, and shows correct "toggle state".
- Bookmark bar on each tab, present if requested.  (Currently an empty box).
- Random stuff; e.g. bookmark prefs init moved to a x-plat location.

This CL does not contain Cole's views.

Bried english description of the nib file changes:
- add a new view for the bookmark bar in the tab; hook it up to the controller
- Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009)
- Remove dummy bookmark menu items

Review URL: http://codereview.chromium.org/46078
------------------------------------------------------------------------
r11928 | thestig@chromium.org | 2009-03-18 00:03:57 +0100 (Wed, 18 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/worker_host/worker_service.h

Remove unneeded uses of base/hash_tables.h.
Review URL: http://codereview.chromium.org/48098
------------------------------------------------------------------------
r11927 | mpcomplete@google.com | 2009-03-17 23:49:41 +0100 (Tue, 17 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Fix bug where an extension toolstrip would sometimes get added twice to the
bookmark bar.  The problem was that sometimes the EXTENSIONS_LOADED
notification would get sent before we initialized the bookmark view (which
adds the initial extension toolstrips).
Review URL: http://codereview.chromium.org/42252
------------------------------------------------------------------------
r11925 | brettw@chromium.org | 2009-03-17 23:45:34 +0100 (Tue, 17 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/devtools_view.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/debugger_ui.cc
   M /trunk/src/chrome/browser/dom_ui/debugger_ui.h
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.cc
   M /trunk/src/chrome/browser/dom_ui/devtools_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   D /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   D /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_factory.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_favicon_source.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_thumbnail_source.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Merge DOMUIContents into WebContents.
I did a lot of cleanup of the DOM UI system as part of this.
Review URL: http://codereview.chromium.org/42227
------------------------------------------------------------------------
r11924 | sky@google.com | 2009-03-17 23:43:05 +0100 (Tue, 17 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc

Fixes crash on showing info bubble.

BUG=8854
TEST=see bug

Review URL: http://codereview.chromium.org/42302
------------------------------------------------------------------------
r11914 | klink@chromium.org | 2009-03-17 22:17:04 +0100 (Tue, 17 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.h
   A /trunk/src/chrome/views/accessibility/view_accessibility_wrapper.cc
   A /trunk/src/chrome/views/accessibility/view_accessibility_wrapper.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_win.cc
   M /trunk/src/chrome/views/views.vcproj

Renames AccessibleWrapper to ViewAccessibilityWrapper for clarity. 

Reorders the functions in ViewAccessibility to match the order used in BrowserAccessibility, accessibility.h and in Glue/WebKit.

Review URL: http://codereview.chromium.org/46011
------------------------------------------------------------------------
r11900 | agl@chromium.org | 2009-03-17 20:36:02 +0100 (Tue, 17 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h

Use anonymous shared memory for VisitedLinks.

We already pass a handle to the shared memory via IPC but, when we
create it, we create a named segment. These segments are not garbage
collected on POSIX.

Since nobody actually uses the name of the segment, use an anonymous
segment instead and remove the functions.

Review URL: http://codereview.chromium.org/48087

------------------------------------------------------------------------
r11899 | levin@chromium.org | 2009-03-17 20:25:06 +0100 (Tue, 17 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc

This test only passed if RLZTracker::InitRlz hadn't been called, 
so it failed when the test run order happened to change.

This change fixes that.

Review URL: http://codereview.chromium.org/42283
------------------------------------------------------------------------
r11895 | avi@google.com | 2009-03-17 20:15:22 +0100 (Tue, 17 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/cocoa/status_bubble_mac.h
   A /trunk/src/chrome/browser/cocoa/status_bubble_mac.mm
   M /trunk/src/chrome/chrome.gyp

First pass at Mac status bubble.

Review URL: http://codereview.chromium.org/48070
------------------------------------------------------------------------
r11892 | abarth@chromium.org | 2009-03-17 19:56:42 +0100 (Tue, 17 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h

SSLPolicy Fix: Step 7.

Simplify SSLPolicy to prepare for changing its algorithm.  This change should not change the SSLPolicy behavior at all.

R=jcampan
BUG=8706

Review URL: http://codereview.chromium.org/48060
------------------------------------------------------------------------
r11891 | abarth@chromium.org | 2009-03-17 19:56:23 +0100 (Tue, 17 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc

SSLPolicy Fix: Step 6.

Merge in changes to SSLHostState.  We now can store whether a specific origin is "broken," which is the key new bit of state that we need to share between tabs.

Currently, there is a naming inconsistency between the SSLManager names and the SSLHostState names.  I'll clear this up when I merge in the new SSLManager.

R=jcampan
BUG=8706

Review URL: http://codereview.chromium.org/42274
------------------------------------------------------------------------
r11880 | mark@chromium.org | 2009-03-17 18:53:23 +0100 (Tue, 17 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h

Don't initialize members from themselves, especially when they're uninitialized.
Review URL: http://codereview.chromium.org/42286
------------------------------------------------------------------------
r11876 | sky@google.com | 2009-03-17 18:38:25 +0100 (Tue, 17 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Fixes bug where favicons wouldn't always show up in history page. This
would happen for an URLs that contained parens. These need to be
escaped when using in CSS.

BUG=none
TEST=Go to a page that has parens in it (such as
  http://en.wikipedia.org/wiki/The_Wire_(season_5) ). Then open up
  history and make sure you get a favicon for the site.

Review URL: http://codereview.chromium.org/48043
------------------------------------------------------------------------
r11875 | tc@google.com | 2009-03-17 18:31:11 +0100 (Tue, 17 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc

Register more prefs on linux/mac.

Review URL: http://codereview.chromium.org/48052

------------------------------------------------------------------------
r11873 | deanm@chromium.org | 2009-03-17 18:24:59 +0100 (Tue, 17 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h

Cleanup GTK toolbar tooltips.  Move from GtkTooltips to GtkTooltip API.

Move away from the deprecated GtkTooltips API, instead using the preferred methods on GtkWidget.  Add missing tooltips to the back and forward buttons.

This also fixes a memory leak of the old tooltips object which is no longer needed.

BUG=8868

Review URL: http://codereview.chromium.org/48068

------------------------------------------------------------------------
r11872 | deanm@chromium.org | 2009-03-17 18:23:19 +0100 (Tue, 17 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h

Ensure that MenuGtks are destroyed before their accelerator group.

When a MenuGtk is created, it is passed a GtkAccelGroup.  Previously the GtkMenu widgets were destroyed after the browser window, which was the owner of the GtkAccelGroup.  Make the toolbar own a reference to the GtkAccelGroup, and teardown all GtkMenus that reference it beforehand.

Some MenuGtk cleanup while debugging the problem.

BUG=8866

Review URL: http://codereview.chromium.org/48065

------------------------------------------------------------------------
r11871 | agl@chromium.org | 2009-03-17 17:40:40 +0100 (Tue, 17 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/build/V8Bindings/build-generated-files.sh
   M /trunk/src/webkit/build/webkit_common_defines.vsprops
   M /trunk/src/webkit/port/bindings/v8/V8WorkerCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/WorkerContextExecutionProxy.cpp
   M /trunk/src/webkit/port/bindings/v8/WorkerContextExecutionProxy.h

Revert "Enable building worker and use command line switch to turn on ..."

This reverts commit 11870.

------------------------------------------------------------------------
r11870 | jianli@chromium.org | 2009-03-17 17:13:09 +0100 (Tue, 17 Mar 2009) | 2 lines
Changed paths:
   M /trunk/deps/third_party/WebKit/WebKit/chromium/public/WebKit.h
   M /trunk/deps/third_party/WebKit/WebKit/chromium/src/WebKit.cpp
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/webkit/build/V8Bindings/build-generated-files.sh
   M /trunk/src/webkit/build/webkit_common_defines.vsprops
   M /trunk/src/webkit/port/bindings/v8/V8WorkerCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/WorkerContextExecutionProxy.cpp
   M /trunk/src/webkit/port/bindings/v8/WorkerContextExecutionProxy.h

Enable building worker and use command line switch to turn on this feature.
Review URL: http://codereview.chromium.org/41029
------------------------------------------------------------------------
r11863 | yurys@google.com | 2009-03-17 16:33:11 +0100 (Tue, 17 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/dom_ui/dev_tools_ui.cc
   D /trunk/src/chrome/browser/dom_ui/dev_tools_ui.h
   A /trunk/src/chrome/browser/dom_ui/devtools_ui.cc (from /trunk/src/chrome/browser/dom_ui/dev_tools_ui.cc:11854)
   A /trunk/src/chrome/browser/dom_ui/devtools_ui.h (from /trunk/src/chrome/browser/dom_ui/dev_tools_ui.h:11854)
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/ipc_message_macros.h
   D /trunk/src/chrome/renderer/dev_tools_agent.cc
   D /trunk/src/chrome/renderer/dev_tools_agent.h
   D /trunk/src/chrome/renderer/dev_tools_client.cc
   D /trunk/src/chrome/renderer/dev_tools_client.h
   D /trunk/src/chrome/renderer/dev_tools_messages.h
   D /trunk/src/chrome/renderer/dev_tools_messages_internal.h
   A /trunk/src/chrome/renderer/devtools_agent.cc (from /trunk/src/chrome/renderer/dev_tools_agent.cc:11854)
   A /trunk/src/chrome/renderer/devtools_agent.h (from /trunk/src/chrome/renderer/dev_tools_agent.h:11854)
   A /trunk/src/chrome/renderer/devtools_client.cc (from /trunk/src/chrome/renderer/dev_tools_client.cc:11854)
   A /trunk/src/chrome/renderer/devtools_client.h (from /trunk/src/chrome/renderer/dev_tools_client.h:11854)
   A /trunk/src/chrome/renderer/devtools_messages.h (from /trunk/src/chrome/renderer/dev_tools_messages.h:11854)
   A /trunk/src/chrome/renderer/devtools_messages_internal.h (from /trunk/src/chrome/renderer/dev_tools_messages_internal.h:11854)
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj

Use devtool_ prefix instead of dev_tools_ to be consistent with the rest code.
Review URL: http://codereview.chromium.org/42281
------------------------------------------------------------------------
r11859 | deanm@chromium.org | 2009-03-17 15:09:25 +0100 (Tue, 17 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Don't leak AutocompleteEditViewGtk objects.  I meant reset() not release().

Review URL: http://codereview.chromium.org/48066

------------------------------------------------------------------------
r11855 | yurys@google.com | 2009-03-17 13:05:48 +0100 (Tue, 17 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.cc
   M /trunk/src/chrome/browser/debugger/devtools_manager.h
   A /trunk/src/chrome/browser/debugger/devtools_manager_unittest.cc
   M /trunk/src/chrome/browser/debugger/devtools_window.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Initial unit tests implementation.
Review URL: http://codereview.chromium.org/42233
------------------------------------------------------------------------
r11854 | abarth@chromium.org | 2009-03-17 11:14:15 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc

Add missing file.
------------------------------------------------------------------------
r11853 | abarth@chromium.org | 2009-03-17 11:08:24 +0100 (Tue, 17 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/notification_type.h

SSLPolicy Fix: Step 5.

Add a new notification type to notify other SSLManagers when a security origin becomes contaminated with mixed content.

TBR=wtc
BUG=8706


Review URL: http://codereview.chromium.org/48059
------------------------------------------------------------------------
r11852 | phajdan.jr@chromium.org | 2009-03-17 10:35:11 +0100 (Tue, 17 Mar 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Porting unit tests in chrome/

Enable following tests on Linux:
  browser/autocomplete/autocomplete_unittest.cc
  browser/navigation_controller_unittest.cc
  browser/search_engines/template_url_model_unittest.cc
  browser/sessions/session_backend_unittest.cc
  browser/tab_contents/web_contents_unittest.cc

Remove not-existing file from remove list for Linux.

Check for zero-size write in SessionBackend because it's an error in POSIX (but is ok from the session backend's perspective).

Review URL: http://codereview.chromium.org/42223
------------------------------------------------------------------------
r11851 | abarth@chromium.org | 2009-03-17 10:18:06 +0100 (Tue, 17 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/media/data_source_impl.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/unittest_test_server.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

SSLPolicy Fix: Step 3.

Plumbing the security origin of the frame making the request to SSL land.

R=wtc
BUG=8706

Review URL: http://codereview.chromium.org/48038
------------------------------------------------------------------------
r11850 | abarth@chromium.org | 2009-03-17 07:11:08 +0100 (Tue, 17 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

SSL Fix: Step 4.

Plumb the security origin information for memory cache loads too.

R=wtc
BUG=8706


Review URL: http://codereview.chromium.org/42263
------------------------------------------------------------------------
r11842 | ben@chromium.org | 2009-03-17 06:02:55 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/task_manager.cc

Forgot these two files.
------------------------------------------------------------------------
r11841 | ben@chromium.org | 2009-03-17 05:56:55 +0100 (Tue, 17 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/back_forward_menu_model_win.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/js_before_unload_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/common/gfx/text_elider.cc
   M /trunk/src/chrome/common/gfx/text_elider_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/accessibility/view_accessibility.h
   M /trunk/src/chrome/views/background.h
   D /trunk/src/chrome/views/bitmap_scroll_bar.cc
   D /trunk/src/chrome/views/bitmap_scroll_bar.h
   D /trunk/src/chrome/views/button.cc
   D /trunk/src/chrome/views/button.h
   D /trunk/src/chrome/views/button_dropdown.cc
   D /trunk/src/chrome/views/button_dropdown.h
   D /trunk/src/chrome/views/checkbox.cc
   D /trunk/src/chrome/views/checkbox.h
   D /trunk/src/chrome/views/chrome_menu.cc
   D /trunk/src/chrome/views/chrome_menu.h
   D /trunk/src/chrome/views/combo_box.cc
   D /trunk/src/chrome/views/combo_box.h
   D /trunk/src/chrome/views/controller.h
   A /trunk/src/chrome/views/controls/button/button.cc (from /trunk/src/chrome/views/button.cc:11810)
   A /trunk/src/chrome/views/controls/button/button.h (from /trunk/src/chrome/views/button.h:11810)
   A /trunk/src/chrome/views/controls/button/button_dropdown.cc (from /trunk/src/chrome/views/button_dropdown.cc:11811)
   A /trunk/src/chrome/views/controls/button/button_dropdown.h (from /trunk/src/chrome/views/button_dropdown.h:11810)
   A /trunk/src/chrome/views/controls/button/checkbox.cc (from /trunk/src/chrome/views/checkbox.cc:11810)
   A /trunk/src/chrome/views/controls/button/checkbox.h (from /trunk/src/chrome/views/checkbox.h:11810)
   A /trunk/src/chrome/views/controls/button/custom_button.cc (from /trunk/src/chrome/views/custom_button.cc:11810)
   A /trunk/src/chrome/views/controls/button/custom_button.h (from /trunk/src/chrome/views/custom_button.h:11810)
   A /trunk/src/chrome/views/controls/button/image_button.cc (from /trunk/src/chrome/views/image_button.cc:11810)
   A /trunk/src/chrome/views/controls/button/image_button.h (from /trunk/src/chrome/views/image_button.h:11810)
   A /trunk/src/chrome/views/controls/button/menu_button.cc (from /trunk/src/chrome/views/menu_button.cc:11811)
   A /trunk/src/chrome/views/controls/button/menu_button.h (from /trunk/src/chrome/views/menu_button.h:11810)
   A /trunk/src/chrome/views/controls/button/native_button.cc (from /trunk/src/chrome/views/native_button.cc:11810)
   A /trunk/src/chrome/views/controls/button/native_button.h (from /trunk/src/chrome/views/native_button.h:11810)
   A /trunk/src/chrome/views/controls/button/radio_button.cc (from /trunk/src/chrome/views/radio_button.cc:11811)
   A /trunk/src/chrome/views/controls/button/radio_button.h (from /trunk/src/chrome/views/radio_button.h:11810)
   A /trunk/src/chrome/views/controls/button/text_button.cc (from /trunk/src/chrome/views/text_button.cc:11810)
   A /trunk/src/chrome/views/controls/button/text_button.h (from /trunk/src/chrome/views/text_button.h:11810)
   A /trunk/src/chrome/views/controls/combo_box.cc (from /trunk/src/chrome/views/combo_box.cc:11810)
   A /trunk/src/chrome/views/controls/combo_box.h (from /trunk/src/chrome/views/combo_box.h:11810)
   A /trunk/src/chrome/views/controls/hwnd_view.cc (from /trunk/src/chrome/views/hwnd_view.cc:11837)
   A /trunk/src/chrome/views/controls/hwnd_view.h (from /trunk/src/chrome/views/hwnd_view.h:11810)
   A /trunk/src/chrome/views/controls/image_view.cc (from /trunk/src/chrome/views/image_view.cc:11810)
   A /trunk/src/chrome/views/controls/image_view.h (from /trunk/src/chrome/views/image_view.h:11810)
   A /trunk/src/chrome/views/controls/label.cc (from /trunk/src/chrome/views/label.cc:11810)
   A /trunk/src/chrome/views/controls/label.h (from /trunk/src/chrome/views/label.h:11810)
   A /trunk/src/chrome/views/controls/label_unittest.cc (from /trunk/src/chrome/views/label_unittest.cc:11810)
   A /trunk/src/chrome/views/controls/link.cc (from /trunk/src/chrome/views/link.cc:11810)
   A /trunk/src/chrome/views/controls/link.h (from /trunk/src/chrome/views/link.h:11810)
   A /trunk/src/chrome/views/controls/menu/chrome_menu.cc (from /trunk/src/chrome/views/chrome_menu.cc:11811)
   A /trunk/src/chrome/views/controls/menu/chrome_menu.h (from /trunk/src/chrome/views/chrome_menu.h:11810)
   A /trunk/src/chrome/views/controls/menu/controller.h (from /trunk/src/chrome/views/controller.h:11810)
   A /trunk/src/chrome/views/controls/menu/menu.cc (from /trunk/src/chrome/views/menu.cc:11810)
   A /trunk/src/chrome/views/controls/menu/menu.h (from /trunk/src/chrome/views/menu.h:11810)
   A /trunk/src/chrome/views/controls/menu/view_menu_delegate.h (from /trunk/src/chrome/views/view_menu_delegate.h:11810)
   A /trunk/src/chrome/views/controls/message_box_view.cc (from /trunk/src/chrome/views/message_box_view.cc:11824)
   A /trunk/src/chrome/views/controls/message_box_view.h (from /trunk/src/chrome/views/message_box_view.h:11810)
   A /trunk/src/chrome/views/controls/native_control.cc (from /trunk/src/chrome/views/native_control.cc:11837)
   A /trunk/src/chrome/views/controls/native_control.h (from /trunk/src/chrome/views/native_control.h:11810)
   A /trunk/src/chrome/views/controls/scroll_view.cc (from /trunk/src/chrome/views/scroll_view.cc:11811)
   A /trunk/src/chrome/views/controls/scroll_view.h (from /trunk/src/chrome/views/scroll_view.h:11810)
   A /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.cc (from /trunk/src/chrome/views/bitmap_scroll_bar.cc:11811)
   A /trunk/src/chrome/views/controls/scrollbar/bitmap_scroll_bar.h (from /trunk/src/chrome/views/bitmap_scroll_bar.h:11810)
   A /trunk/src/chrome/views/controls/scrollbar/native_scroll_bar.cc (from /trunk/src/chrome/views/native_scroll_bar.cc:11811)
   A /trunk/src/chrome/views/controls/scrollbar/native_scroll_bar.h (from /trunk/src/chrome/views/native_scroll_bar.h:11810)
   A /trunk/src/chrome/views/controls/scrollbar/scroll_bar.cc (from /trunk/src/chrome/views/scroll_bar.cc:11810)
   A /trunk/src/chrome/views/controls/scrollbar/scroll_bar.h (from /trunk/src/chrome/views/scroll_bar.h:11810)
   A /trunk/src/chrome/views/controls/separator.cc (from /trunk/src/chrome/views/separator.cc:11810)
   A /trunk/src/chrome/views/controls/separator.h (from /trunk/src/chrome/views/separator.h:11810)
   A /trunk/src/chrome/views/controls/single_split_view.cc (from /trunk/src/chrome/views/single_split_view.cc:11810)
   A /trunk/src/chrome/views/controls/single_split_view.h (from /trunk/src/chrome/views/single_split_view.h:11810)
   A /trunk/src/chrome/views/controls/tabbed_pane.cc (from /trunk/src/chrome/views/tabbed_pane.cc:11811)
   A /trunk/src/chrome/views/controls/tabbed_pane.h (from /trunk/src/chrome/views/tabbed_pane.h:11810)
   A /trunk/src/chrome/views/controls/table/group_table_view.cc (from /trunk/src/chrome/views/group_table_view.cc:11810)
   A /trunk/src/chrome/views/controls/table/group_table_view.h (from /trunk/src/chrome/views/group_table_view.h:11810)
   A /trunk/src/chrome/views/controls/table/table_view.cc (from /trunk/src/chrome/views/table_view.cc:11810)
   A /trunk/src/chrome/views/controls/table/table_view.h (from /trunk/src/chrome/views/table_view.h:11810)
   A /trunk/src/chrome/views/controls/table/table_view_unittest.cc (from /trunk/src/chrome/views/table_view_unittest.cc:11819)
   A /trunk/src/chrome/views/controls/text_field.cc (from /trunk/src/chrome/views/text_field.cc:11811)
   A /trunk/src/chrome/views/controls/text_field.h (from /trunk/src/chrome/views/text_field.h:11810)
   A /trunk/src/chrome/views/controls/throbber.cc (from /trunk/src/chrome/views/throbber.cc:11810)
   A /trunk/src/chrome/views/controls/throbber.h (from /trunk/src/chrome/views/throbber.h:11810)
   A /trunk/src/chrome/views/controls/tree/tree_model.h (from /trunk/src/chrome/views/tree_model.h:11810)
   A /trunk/src/chrome/views/controls/tree/tree_node_iterator.h (from /trunk/src/chrome/views/tree_node_iterator.h:11810)
   A /trunk/src/chrome/views/controls/tree/tree_node_iterator_unittest.cc (from /trunk/src/chrome/views/tree_node_iterator_unittest.cc:11810)
   A /trunk/src/chrome/views/controls/tree/tree_node_model.h (from /trunk/src/chrome/views/tree_node_model.h:11810)
   A /trunk/src/chrome/views/controls/tree/tree_view.cc (from /trunk/src/chrome/views/tree_view.cc:11837)
   A /trunk/src/chrome/views/controls/tree/tree_view.h (from /trunk/src/chrome/views/tree_view.h:11810)
   D /trunk/src/chrome/views/custom_button.cc
   D /trunk/src/chrome/views/custom_button.h
   D /trunk/src/chrome/views/decision.cc
   D /trunk/src/chrome/views/decision.h
   M /trunk/src/chrome/views/event.h
   A /trunk/src/chrome/views/focus/focus_manager_unittest.cc (from /trunk/src/chrome/views/focus_manager_unittest.cc:11819)
   D /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/grid_layout.h
   D /trunk/src/chrome/views/group_table_view.cc
   D /trunk/src/chrome/views/group_table_view.h
   D /trunk/src/chrome/views/hwnd_view.cc
   D /trunk/src/chrome/views/hwnd_view.h
   D /trunk/src/chrome/views/image_button.cc
   D /trunk/src/chrome/views/image_button.h
   D /trunk/src/chrome/views/image_view.cc
   D /trunk/src/chrome/views/image_view.h
   D /trunk/src/chrome/views/label.cc
   D /trunk/src/chrome/views/label.h
   D /trunk/src/chrome/views/label_unittest.cc
   M /trunk/src/chrome/views/layout_manager.h
   D /trunk/src/chrome/views/link.cc
   D /trunk/src/chrome/views/link.h
   D /trunk/src/chrome/views/menu.cc
   D /trunk/src/chrome/views/menu.h
   D /trunk/src/chrome/views/menu_button.cc
   D /trunk/src/chrome/views/menu_button.h
   D /trunk/src/chrome/views/message_box_view.cc
   D /trunk/src/chrome/views/message_box_view.h
   D /trunk/src/chrome/views/native_button.cc
   D /trunk/src/chrome/views/native_button.h
   D /trunk/src/chrome/views/native_control.cc
   D /trunk/src/chrome/views/native_control.h
   D /trunk/src/chrome/views/native_scroll_bar.cc
   D /trunk/src/chrome/views/native_scroll_bar.h
   M /trunk/src/chrome/views/painter.h
   D /trunk/src/chrome/views/radio_button.cc
   D /trunk/src/chrome/views/radio_button.h
   D /trunk/src/chrome/views/scroll_bar.cc
   D /trunk/src/chrome/views/scroll_bar.h
   D /trunk/src/chrome/views/scroll_view.cc
   D /trunk/src/chrome/views/scroll_view.h
   D /trunk/src/chrome/views/separator.cc
   D /trunk/src/chrome/views/separator.h
   D /trunk/src/chrome/views/single_split_view.cc
   D /trunk/src/chrome/views/single_split_view.h
   D /trunk/src/chrome/views/tabbed_pane.cc
   D /trunk/src/chrome/views/tabbed_pane.h
   D /trunk/src/chrome/views/table_view.cc
   D /trunk/src/chrome/views/table_view.h
   D /trunk/src/chrome/views/table_view_unittest.cc
   D /trunk/src/chrome/views/text_button.cc
   D /trunk/src/chrome/views/text_button.h
   D /trunk/src/chrome/views/text_field.cc
   D /trunk/src/chrome/views/text_field.h
   D /trunk/src/chrome/views/throbber.cc
   D /trunk/src/chrome/views/throbber.h
   D /trunk/src/chrome/views/tree_model.h
   D /trunk/src/chrome/views/tree_node_iterator.h
   D /trunk/src/chrome/views/tree_node_iterator_unittest.cc
   D /trunk/src/chrome/views/tree_node_model.h
   D /trunk/src/chrome/views/tree_view.cc
   D /trunk/src/chrome/views/tree_view.h
   D /trunk/src/chrome/views/view_menu_delegate.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/window/custom_frame_view.h
   M /trunk/src/chrome/views/window/dialog_client_view.h

Move controls into their own dir under chrome/views/controls

TBR=sky

Review URL: http://codereview.chromium.org/48058
------------------------------------------------------------------------
r11837 | ben@chromium.org | 2009-03-17 03:54:02 +0100 (Tue, 17 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/views/SConscript
   D /trunk/src/chrome/views/external_focus_tracker.cc
   D /trunk/src/chrome/views/external_focus_tracker.h
   A /trunk/src/chrome/views/focus/external_focus_tracker.cc (from /trunk/src/chrome/views/external_focus_tracker.cc:11810)
   A /trunk/src/chrome/views/focus/external_focus_tracker.h (from /trunk/src/chrome/views/external_focus_tracker.h:11810)
   A /trunk/src/chrome/views/focus/focus_manager.cc (from /trunk/src/chrome/views/focus_manager.cc:11811)
   A /trunk/src/chrome/views/focus/focus_manager.h (from /trunk/src/chrome/views/focus_manager.h:11810)
   A /trunk/src/chrome/views/focus/view_storage.cc (from /trunk/src/chrome/views/view_storage.cc:11810)
   A /trunk/src/chrome/views/focus/view_storage.h (from /trunk/src/chrome/views/view_storage.h:11810)
   D /trunk/src/chrome/views/focus_manager.cc
   D /trunk/src/chrome/views/focus_manager.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/tree_view.cc
   D /trunk/src/chrome/views/view_storage.cc
   D /trunk/src/chrome/views/view_storage.h
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget/accelerator_handler.cc
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/chrome/views/widget/widget_win.h
   M /trunk/src/chrome/views/window/dialog_client_view.h

Move focus related files into a new chrome/views/focus subdir

TBR=sky

Review URL: http://codereview.chromium.org/48056
------------------------------------------------------------------------
r11836 | ben@chromium.org | 2009-03-17 03:31:24 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

fix bustage - file moved
------------------------------------------------------------------------
r11831 | ben@chromium.org | 2009-03-17 03:03:16 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

bustage fix - moved file
------------------------------------------------------------------------
r11830 | ben@chromium.org | 2009-03-17 03:02:45 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/importer/importer.cc

bustage fix - moved file
------------------------------------------------------------------------
r11829 | ben@chromium.org | 2009-03-17 03:01:48 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h

bustage fix - moved file
------------------------------------------------------------------------
r11828 | ben@chromium.org | 2009-03-17 02:59:05 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc

bustage fix - file moved
------------------------------------------------------------------------
r11827 | ben@chromium.org | 2009-03-17 02:57:59 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h

bustage fix - file moved
------------------------------------------------------------------------
r11826 | ben@chromium.org | 2009-03-17 02:55:27 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window_win.cc

bustage fix - file moved
------------------------------------------------------------------------
r11825 | ben@chromium.org | 2009-03-17 02:55:03 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/devtools_window_win.h

bustage fix - file moved
------------------------------------------------------------------------
r11822 | ben@chromium.org | 2009-03-17 02:50:25 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

fix bustage - moved file
------------------------------------------------------------------------
r11819 | ben@chromium.org | 2009-03-17 02:44:36 +0100 (Tue, 17 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/input_window.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/views/SConscript
   D /trunk/src/chrome/views/app_modal_dialog_delegate.h
   D /trunk/src/chrome/views/client_view.cc
   D /trunk/src/chrome/views/client_view.h
   D /trunk/src/chrome/views/custom_frame_view.cc
   D /trunk/src/chrome/views/custom_frame_view.h
   D /trunk/src/chrome/views/dialog_client_view.cc
   D /trunk/src/chrome/views/dialog_client_view.h
   D /trunk/src/chrome/views/dialog_delegate.cc
   D /trunk/src/chrome/views/dialog_delegate.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   D /trunk/src/chrome/views/native_frame_view.cc
   D /trunk/src/chrome/views/native_frame_view.h
   D /trunk/src/chrome/views/non_client_view.cc
   D /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget/accelerator_handler.h
   M /trunk/src/chrome/views/widget/aero_tooltip_manager.h
   M /trunk/src/chrome/views/widget/hwnd_notification_source.h
   M /trunk/src/chrome/views/widget/root_view.h
   M /trunk/src/chrome/views/widget/root_view_drop_target.h
   M /trunk/src/chrome/views/widget/tooltip_manager.h
   M /trunk/src/chrome/views/widget/widget.h
   M /trunk/src/chrome/views/widget/widget_win.h
   A /trunk/src/chrome/views/window/app_modal_dialog_delegate.h (from /trunk/src/chrome/views/app_modal_dialog_delegate.h:11810)
   A /trunk/src/chrome/views/window/client_view.cc (from /trunk/src/chrome/views/client_view.cc:11810)
   A /trunk/src/chrome/views/window/client_view.h (from /trunk/src/chrome/views/client_view.h:11810)
   A /trunk/src/chrome/views/window/custom_frame_view.cc (from /trunk/src/chrome/views/custom_frame_view.cc:11810)
   A /trunk/src/chrome/views/window/custom_frame_view.h (from /trunk/src/chrome/views/custom_frame_view.h:11810)
   A /trunk/src/chrome/views/window/dialog_client_view.cc (from /trunk/src/chrome/views/dialog_client_view.cc:11810)
   A /trunk/src/chrome/views/window/dialog_client_view.h (from /trunk/src/chrome/views/dialog_client_view.h:11810)
   A /trunk/src/chrome/views/window/dialog_delegate.cc (from /trunk/src/chrome/views/dialog_delegate.cc:11810)
   A /trunk/src/chrome/views/window/dialog_delegate.h (from /trunk/src/chrome/views/dialog_delegate.h:11810)
   A /trunk/src/chrome/views/window/native_frame_view.cc (from /trunk/src/chrome/views/native_frame_view.cc:11810)
   A /trunk/src/chrome/views/window/native_frame_view.h (from /trunk/src/chrome/views/native_frame_view.h:11810)
   A /trunk/src/chrome/views/window/non_client_view.cc (from /trunk/src/chrome/views/non_client_view.cc:11811)
   A /trunk/src/chrome/views/window/non_client_view.h (from /trunk/src/chrome/views/non_client_view.h:11810)
   A /trunk/src/chrome/views/window/window.h (from /trunk/src/chrome/views/window.h:11810)
   A /trunk/src/chrome/views/window/window_delegate.cc (from /trunk/src/chrome/views/window_delegate.cc:11810)
   A /trunk/src/chrome/views/window/window_delegate.h (from /trunk/src/chrome/views/window_delegate.h:11810)
   A /trunk/src/chrome/views/window/window_resources.h (from /trunk/src/chrome/views/window_resources.h:11810)
   A /trunk/src/chrome/views/window/window_win.cc (from /trunk/src/chrome/views/window_win.cc:11811)
   A /trunk/src/chrome/views/window/window_win.h (from /trunk/src/chrome/views/window_win.h:11811)
   D /trunk/src/chrome/views/window.h
   D /trunk/src/chrome/views/window_delegate.cc
   D /trunk/src/chrome/views/window_delegate.h
   D /trunk/src/chrome/views/window_resources.h
   D /trunk/src/chrome/views/window_win.cc
   D /trunk/src/chrome/views/window_win.h

Move windowing related objects into chrome/views/window subdir.

TBR=sky

Review URL: http://codereview.chromium.org/42272
------------------------------------------------------------------------
r11818 | ben@chromium.org | 2009-03-17 02:08:42 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc

fix bustage -moved file
------------------------------------------------------------------------
r11817 | ben@chromium.org | 2009-03-17 02:08:29 +0100 (Tue, 17 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

fix bustage - moved file
------------------------------------------------------------------------
r11816 | jam@chromium.org | 2009-03-17 01:52:35 +0100 (Tue, 17 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h

Hide the details about ResourceDispatcherHost messages from child processes.  The usage of RDH is now like RD, the client sends the message to RDH to see if it should handle it.  I added methods to the Receiver interface so that RDH can get to the process id/handle/type when starting requests.
Review URL: http://codereview.chromium.org/42202
------------------------------------------------------------------------
r11811 | ben@chromium.org | 2009-03-17 01:36:12 +0100 (Tue, 17 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/views/SConscript
   D /trunk/src/chrome/views/accelerator_handler.cc
   D /trunk/src/chrome/views/accelerator_handler.h
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   D /trunk/src/chrome/views/aero_tooltip_manager.cc
   D /trunk/src/chrome/views/aero_tooltip_manager.h
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   D /trunk/src/chrome/views/hwnd_notification_source.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/radio_button.cc
   D /trunk/src/chrome/views/root_view.cc
   D /trunk/src/chrome/views/root_view.h
   D /trunk/src/chrome/views/root_view_drop_target.cc
   D /trunk/src/chrome/views/root_view_drop_target.h
   D /trunk/src/chrome/views/root_view_gtk.cc
   D /trunk/src/chrome/views/root_view_win.cc
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/text_field.cc
   D /trunk/src/chrome/views/tooltip_manager.cc
   D /trunk/src/chrome/views/tooltip_manager.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/view_win.cc
   M /trunk/src/chrome/views/views.vcproj
   A /trunk/src/chrome/views/widget/accelerator_handler.cc (from /trunk/src/chrome/views/accelerator_handler.cc:11786)
   A /trunk/src/chrome/views/widget/accelerator_handler.h (from /trunk/src/chrome/views/accelerator_handler.h:11786)
   A /trunk/src/chrome/views/widget/aero_tooltip_manager.cc (from /trunk/src/chrome/views/aero_tooltip_manager.cc:11786)
   A /trunk/src/chrome/views/widget/aero_tooltip_manager.h (from /trunk/src/chrome/views/aero_tooltip_manager.h:11786)
   A /trunk/src/chrome/views/widget/hwnd_notification_source.h (from /trunk/src/chrome/views/hwnd_notification_source.h:11786)
   A /trunk/src/chrome/views/widget/root_view.cc (from /trunk/src/chrome/views/root_view.cc:11786)
   A /trunk/src/chrome/views/widget/root_view.h (from /trunk/src/chrome/views/root_view.h:11786)
   A /trunk/src/chrome/views/widget/root_view_drop_target.cc (from /trunk/src/chrome/views/root_view_drop_target.cc:11786)
   A /trunk/src/chrome/views/widget/root_view_drop_target.h (from /trunk/src/chrome/views/root_view_drop_target.h:11786)
   A /trunk/src/chrome/views/widget/root_view_gtk.cc (from /trunk/src/chrome/views/root_view_gtk.cc:11786)
   A /trunk/src/chrome/views/widget/root_view_win.cc (from /trunk/src/chrome/views/root_view_win.cc:11786)
   A /trunk/src/chrome/views/widget/tooltip_manager.cc (from /trunk/src/chrome/views/tooltip_manager.cc:11786)
   A /trunk/src/chrome/views/widget/tooltip_manager.h (from /trunk/src/chrome/views/tooltip_manager.h:11786)
   A /trunk/src/chrome/views/widget/widget.h (from /trunk/src/chrome/views/widget.h:11786)
   A /trunk/src/chrome/views/widget/widget_win.cc (from /trunk/src/chrome/views/widget_win.cc:11786)
   A /trunk/src/chrome/views/widget/widget_win.h (from /trunk/src/chrome/views/widget_win.h:11786)
   D /trunk/src/chrome/views/widget.h
   D /trunk/src/chrome/views/widget_win.cc
   D /trunk/src/chrome/views/widget_win.h
   M /trunk/src/chrome/views/window_win.cc
   M /trunk/src/chrome/views/window_win.h

Move widget related files into views/widget

TBR=sky

------------------------------------------------------------------------
r11810 | hclam@chromium.org | 2009-03-17 01:30:01 +0100 (Tue, 17 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h

Move response_data_file from ResourceResponseHead to webkit_glue::ResponseInfo
We would like to use the entry response_data_file in ResourceResponseHead
(currently in chrome/browser/resource_handler.h) in chrome/renderer. So refactor the
member and move it to webkit_glue::ResourceLoaderBridge::ResponsseInfo which
is the base class of ResourceResponseHead.

Review URL: http://codereview.chromium.org/42199
------------------------------------------------------------------------
r11802 | tc@google.com | 2009-03-17 00:38:42 +0100 (Tue, 17 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.cc

Flush the visited link database after a write.  If we crash,
we're not guaranteed that the write will make it to the kernel.

BUG=8710

Review URL: http://codereview.chromium.org/42264

------------------------------------------------------------------------
r11799 | ben@chromium.org | 2009-03-17 00:25:13 +0100 (Tue, 17 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   D /trunk/src/chrome/views/base_button.cc
   D /trunk/src/chrome/views/base_button.h
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.h
   R /trunk/src/chrome/views/button.cc (from /trunk/src/chrome/views/base_button.cc:11711)
   R /trunk/src/chrome/views/button.h (from /trunk/src/chrome/views/base_button.h:11711)
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/button_dropdown.h
   A /trunk/src/chrome/views/custom_button.cc
   A /trunk/src/chrome/views/custom_button.h
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   A /trunk/src/chrome/views/image_button.cc (from /trunk/src/chrome/views/button.cc:11711)
   A /trunk/src/chrome/views/image_button.h (from /trunk/src/chrome/views/button.h:11711)
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/menu_button.h
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_button.h
   M /trunk/src/chrome/views/views.vcproj

Rework the Button API to be saner in preparation for NativeControl rejiggering.BaseButton->Button, CustomButtonButton->ImageButtonToggleButton->ToggleImageButtonRemoving SetListener (buttons take listener through ctor)Tidy up source files. No functionality changes, just naming and organization.Look at the button classes first, then everything else.
Review URL: http://codereview.chromium.org/46096
------------------------------------------------------------------------
r11784 | shess@chromium.org | 2009-03-16 23:15:28 +0100 (Mon, 16 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/chrome.gyp

Use URLFixerUpper to clean up potential url before going there.

Review URL: http://codereview.chromium.org/42249
------------------------------------------------------------------------
r11777 | estade@chromium.org | 2009-03-16 22:03:01 +0100 (Mon, 16 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

Change a function name.

GetTopLevelNativeView changed to GetTopLevelNativeWindow since it returns a NativeWindow rather than a NativeView. NativeWindows are inherently top level, so the new name is a little redundant, but I think it is clearer than GetNativeWindow since "window" can have different definitions on different platforms.

Review URL: http://codereview.chromium.org/42244
------------------------------------------------------------------------
r11768 | wtc@chromium.org | 2009-03-16 21:13:33 +0100 (Mon, 16 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/net.gyp
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   A /trunk/src/net/url_request/url_request_new_ftp_job.cc
   A /trunk/src/net/url_request/url_request_new_ftp_job.h

Add command line switch "--new-ftp" for new portable FTP
implementation.

Add the (empty) URLRequestNewFtpJob class.

Contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>.

BUG=4965
R=darin,wtc
Review URL: http://codereview.chromium.org/42197
------------------------------------------------------------------------
r11767 | erg@google.com | 2009-03-16 21:11:08 +0100 (Mon, 16 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/webkit/glue/webview_impl.cc

Fix keyboard scrolling on non-Windows platforms.

Review URL: http://codereview.chromium.org/46057

------------------------------------------------------------------------
r11766 | thestig@chromium.org | 2009-03-16 21:02:42 +0100 (Mon, 16 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/condition_variable.h
   M /trunk/src/base/condition_variable_posix.cc
   M /trunk/src/base/condition_variable_win.cc
   M /trunk/src/base/event_recorder.cc
   M /trunk/src/base/message_pump_mac.h
   M /trunk/src/base/message_pump_mac.mm
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/visit_tracker.h
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/common/worker_thread_ticker.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/media/base/pipeline.h
   M /trunk/src/media/base/pipeline_impl_unittest.cc
   M /trunk/src/net/base/tcp_pinger.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc

Removed unneeded includes of base/time.h.
Review URL: http://codereview.chromium.org/48019
------------------------------------------------------------------------
r11762 | pinkerton@chromium.org | 2009-03-16 20:57:16 +0100 (Mon, 16 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm

Replace a NOTIMPLEMENTED() with a bug.
Review URL: http://codereview.chromium.org/42241
------------------------------------------------------------------------
r11759 | estade@chromium.org | 2009-03-16 20:51:56 +0100 (Mon, 16 Mar 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Linux accelerators cleanup:
- Give renderer a chance to handle accelerators before browser does.
- Handle browser accelerators that aren't attached to any particular UI element in BrowserWindowGtk rather than in BrowserToolbarGtk
- Use Browser::ExecuteCommand() to handle accelerator activation
- Switch a random void* to gfx::NativeWindow
- Enable three browser commands on linux : Focus Location, Focus Search, Open file

This fully enables ctrl-l, ctrl-k, and ctrl-o. This fixes copy-pasta in the omnibox. This fixes the problem Dean described with <http://www.quirksmode.org/js/keys.html>.

bug=8659

Review URL: http://codereview.chromium.org/42190
------------------------------------------------------------------------
r11755 | nsylvain@chromium.org | 2009-03-16 20:08:10 +0100 (Mon, 16 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc

Reverting change 11746 because it broke the unit tests.

Review URL: http://codereview.chromium.org/42240
------------------------------------------------------------------------
r11750 | deanm@chromium.org | 2009-03-16 19:30:47 +0100 (Mon, 16 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h

Move a bunch of our GTK code that was previous manually handling references (and often doing it incorrect / leaking) to use an OwnedWidgetGtk.

Review URL: http://codereview.chromium.org/48007

------------------------------------------------------------------------
r11746 | jungshik@google.com | 2009-03-16 19:24:51 +0100 (Mon, 16 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc

A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookmarks.html' file. 

BUG=6957


Review URL: http://codereview.chromium.org/46008
------------------------------------------------------------------------
r11743 | phajdan.jr@chromium.org | 2009-03-16 19:12:06 +0100 (Mon, 16 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.h

Make debug check in visitedlink_master.h more informative
by changing DCHECK to DCHECK_EQ.

We're getting a lot of trouble with this check, and I just received
a report on irc about problems with it even after my last visitedlink
change (r11734). More information in the error message may help.

Review URL: http://codereview.chromium.org/42235
------------------------------------------------------------------------
r11742 | dkegel@google.com | 2009-03-16 19:07:16 +0100 (Mon, 16 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc

Added missing <stdlib.h>, needed on ubuntu 8.10.

Review URL: http://codereview.chromium.org/42206
------------------------------------------------------------------------
r11734 | phajdan.jr@chromium.org | 2009-03-16 17:45:36 +0100 (Mon, 16 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/base/shared_memory_win.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Port visitedlink tests to Linux. Also make them pass on Linux, which
may fix the attached bug.

The problem was that the debug check was in wrong place (too early, before
every member was initialized), so it failed in the test.

BUG=8710

Review URL: http://codereview.chromium.org/48005
------------------------------------------------------------------------
r11731 | glen@chromium.org | 2009-03-16 16:41:16 +0100 (Mon, 16 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Fix escaping issue with non-ASCII history search input.

Issue was that EscapeQueryParamValue is equivalent to encodeURIComponent(), not escape()

BUG=8346

Review URL: http://codereview.chromium.org/42215
------------------------------------------------------------------------
r11730 | sky@google.com | 2009-03-16 16:08:49 +0100 (Mon, 16 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/history.html

Fixes bug in history where if you didn't have history results for the
current day we would never show any results.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/42196
------------------------------------------------------------------------
r11729 | shess@chromium.org | 2009-03-16 15:36:41 +0100 (Mon, 16 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable AutocompleteTest, HistoryURLProviderTest,
HistoryContentsProviderTest, and KeywordProviderTest from
chrome/browser/autocomplete.

NOTIMPLEMENTED bits where HistoryURLProviderTest and AutocompleteTest
have UI dependencies, and ExternalProtocolHandler has OS dependencies.
Review URL: http://codereview.chromium.org/43034
------------------------------------------------------------------------
r11727 | yurys@google.com | 2009-03-16 14:42:47 +0100 (Mon, 16 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   D /trunk/src/chrome/browser/debugger/dev_tools_view.cc
   D /trunk/src/chrome/browser/debugger/dev_tools_view.h
   D /trunk/src/chrome/browser/debugger/dev_tools_window.cc
   D /trunk/src/chrome/browser/debugger/dev_tools_window.h
   A /trunk/src/chrome/browser/debugger/devtools_manager.cc
   A /trunk/src/chrome/browser/debugger/devtools_manager.h
   A /trunk/src/chrome/browser/debugger/devtools_view.cc (from /trunk/src/chrome/browser/debugger/dev_tools_view.cc:11623)
   A /trunk/src/chrome/browser/debugger/devtools_view.h (from /trunk/src/chrome/browser/debugger/dev_tools_view.h:11623)
   A /trunk/src/chrome/browser/debugger/devtools_window.h (from /trunk/src/chrome/browser/debugger/dev_tools_window.h:11623)
   A /trunk/src/chrome/browser/debugger/devtools_window_gtk.cc
   A /trunk/src/chrome/browser/debugger/devtools_window_mac.cc
   A /trunk/src/chrome/browser/debugger/devtools_window_win.cc (from /trunk/src/chrome/browser/debugger/dev_tools_window.cc:11623)
   A /trunk/src/chrome/browser/debugger/devtools_window_win.h (from /trunk/src/chrome/browser/debugger/dev_tools_window.h:11623)
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/testing_browser_process.h

DevToolsManager is a service in the browser process that manages all open developer tools windows. It's supposed to route devtoools messages. Also it will notify DevToolsClient when inspected renderer crashes or when it's changes due to cross-site navigation. Currently when inspected tab is closed it will close devtools window as well.

Devtools state moved from RenderViewHost and WebContentsView to the manager.

Please look at devtools_manager.{h,cc} in the first place.
Review URL: http://codereview.chromium.org/42076
------------------------------------------------------------------------
r11716 | estade@chromium.org | 2009-03-16 00:23:25 +0100 (Mon, 16 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Linux: Change the cursor back to the default arrow when the render view loses focus.

BUG=8726

Review URL: http://codereview.chromium.org/42210
------------------------------------------------------------------------
r11701 | ben@chromium.org | 2009-03-14 08:35:08 +0100 (Sat, 14 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

forgot this file
------------------------------------------------------------------------
r11700 | ben@chromium.org | 2009-03-14 08:30:08 +0100 (Sat, 14 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

forgot this file
------------------------------------------------------------------------
r11699 | ben@chromium.org | 2009-03-14 08:22:13 +0100 (Sat, 14 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   D /trunk/src/chrome/views/window.cc
   R /trunk/src/chrome/views/window.h (from /trunk/src/chrome/views/window.h:11695)
   M /trunk/src/chrome/views/window_delegate.h
   A /trunk/src/chrome/views/window_win.cc (from /trunk/src/chrome/views/window_win.cc:11695)
   A /trunk/src/chrome/views/window_win.h (from /trunk/src/chrome/views/window_win.h:11695)

Rename Window->WindowWin
Pull basic Window interface out of WindowWin into new interface, Window.
Convert code to use it.

Review URL: http://codereview.chromium.org/46079
------------------------------------------------------------------------
r11696 | ben@chromium.org | 2009-03-14 04:13:06 +0100 (Sat, 14 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   A /trunk/src/chrome/views/window.cc (from /trunk/src/chrome/views/window.cc:11694)
   R /trunk/src/chrome/views/window.h (from /trunk/src/chrome/views/window.h:11694)
   M /trunk/src/chrome/views/window_delegate.h
   D /trunk/src/chrome/views/window_win.cc
   D /trunk/src/chrome/views/window_win.h

rollback again
------------------------------------------------------------------------
r11695 | ben@chromium.org | 2009-03-14 03:49:59 +0100 (Sat, 14 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   D /trunk/src/chrome/views/window.cc
   R /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.h
   A /trunk/src/chrome/views/window_win.cc (from /trunk/src/chrome/views/window.cc:11673)
   A /trunk/src/chrome/views/window_win.h (from /trunk/src/chrome/views/window.h:11673)

Rename Window->WindowWin
Pull basic Window interface out of WindowWin into new interface, Window.
Convert code to use it.

Review URL: http://codereview.chromium.org/42201
------------------------------------------------------------------------
r11687 | sky@google.com | 2009-03-14 00:56:48 +0100 (Sat, 14 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/views/view_win.cc

Disallows dragging from the bookmark bar when the bookmark bar is
closed or animating. This fixes a case where clicking on a bookmark
bar, then hitting control-b triggers a drag.

BUG=8674
TEST=see bug

Review URL: http://codereview.chromium.org/46066
------------------------------------------------------------------------
r11680 | thestig@chromium.org | 2009-03-14 00:12:09 +0100 (Sat, 14 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/time.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/common/ipc_message.h

Remove unneeded includes of gtest_prod.h. Reduce usage from 689 to 601.
Review URL: http://codereview.chromium.org/42189
------------------------------------------------------------------------
r11677 | estade@chromium.org | 2009-03-13 23:42:16 +0100 (Fri, 13 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Implement 2 more gtk dialogs: open file and open multiple files.

Test for single file dialog:
- <html><body><input type=file></body></html>
Test for multiple files dialog:
- <html><body><input type=file multiple></body></html>

Review URL: http://codereview.chromium.org/46024
------------------------------------------------------------------------
r11672 | finnur@chromium.org | 2009-03-13 22:52:32 +0100 (Fri, 13 Mar 2009) | 18 lines
Changed paths:
   A /trunk/src/chrome/app/theme/rss.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/test_location_bar.h
   A /trunk/src/webkit/glue/feed.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

RSS feed support (part 1), 2nd attempt.

Part 1 is RSS feed auto-discovery.

This will parse the web page header to find the
feeds in the document and notify the browser to
display the RSS icon in the toolbar. You can
click on the icon, but it will just navigate to
the first feed on the page, which (unless it has
been designed to be browser friendly) will just
dump XML as text on the user.

For this reason I have disabled the code that
makes the RSS icon appear and intend to enable 
it when we have a good landing page to display
the XML.

Review URL: http://codereview.chromium.org/46055
------------------------------------------------------------------------
r11671 | ben@chromium.org | 2009-03-13 22:24:42 +0100 (Fri, 13 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   R /trunk/src/chrome/views/window.h (from /trunk/src/chrome/views/window.h:11667)
   M /trunk/src/chrome/views/window_delegate.h
   D /trunk/src/chrome/views/window_win.cc
   D /trunk/src/chrome/views/window_win.h

revert
------------------------------------------------------------------------
r11668 | ben@chromium.org | 2009-03-13 21:51:58 +0100 (Fri, 13 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   D /trunk/src/chrome/views/window.cc
   R /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.h
   A /trunk/src/chrome/views/window_win.cc (from /trunk/src/chrome/views/window.cc:11562)
   A /trunk/src/chrome/views/window_win.h (from /trunk/src/chrome/views/window.h:11559)

Rename Window->WindowWin
Pull basic Window interface out of WindowWin into new interface, Window.
Convert code to use it.

Review URL: http://codereview.chromium.org/42169
------------------------------------------------------------------------
r11666 | sky@google.com | 2009-03-13 21:30:35 +0100 (Fri, 13 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   A /trunk/src/chrome/browser/views/frame/browser_root_view.cc
   A /trunk/src/chrome/browser/views/frame/browser_root_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/views/non_client_view.h

Makes drops above the tabstrip work again. This stopped working
because of changes to the view hiearchy.

BUG=8669
TEST=see bug

Review URL: http://codereview.chromium.org/42176
------------------------------------------------------------------------
r11665 | jar@chromium.org | 2009-03-13 21:29:58 +0100 (Fri, 13 Mar 2009) | 30 lines
Changed paths:
   M /trunk/src/base/histogram.h
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/filter_unittest.cc
   M /trunk/src/net/base/filter_unittest.h
   M /trunk/src/net/base/sdch_filter.cc
   M /trunk/src/net/base/sdch_filter.h
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_metrics.cc
   M /trunk/src/net/url_request/url_request_job_metrics.h

wtc: please look at URL related code, and hooks and nits
you might have commented on before.

huanr: please look at sdch_filter code.  The intent was
no semantic change, and only change in histograms and
stats gathered.  I wanted to be sure I had better stats
on several failure cases, as the turn-around time of
adding stats to instrument such cases after they surface
is just too long.

The big feature is the mechanism for getting the total
number of bytes passed to a filter.  We use the filter
context to achieve this, and then the SDCH filter can
calculate compression ratio (from pre-gunzip vs post
SDCH decompress).

The number of bytes read was also histogrammed in a number
of error scenarios, to better diagnose what is going on
when these cases arrise (example: When some data is still
buffered in the VCDIFF decoder).

The sdch_filter destructor was getting long and hard
to read with multiple if blocks, so I cleaned that up
as well a bit (less indentation, and use of early returns).

Nits not included in previous CL that earlier are listed
as well.

r=wtc,huanr
Review URL: http://codereview.chromium.org/40319
------------------------------------------------------------------------
r11662 | mpcomplete@google.com | 2009-03-13 21:08:49 +0100 (Fri, 13 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc

Disable single-process mode in ExtensionViewTest, to see if it's causing
buildbot problems.
Review URL: http://codereview.chromium.org/46052
------------------------------------------------------------------------
r11661 | hclam@chromium.org | 2009-03-13 21:06:57 +0100 (Fri, 13 Mar 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/profile.cc
   A /trunk/src/chrome/browser/renderer_host/media_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/media_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/disk_cache/entry_impl.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_response_info.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h

Highlights of changes:
1. Added entry to ResourceResponseHead so that it contains
   either a base::PlatformFile (OS_WIN) or
   base::FileDescriptor (OS_POSIX) for passing the file
   handle from browser to renderer process.
2. Also added IPC messages for reporting download progress
   and ACK message for it. ResourceLoaderBridge::Peer::OnDownloadProgress
   is added so that the peer is notified of the download
   progress in the renderer process.
3. Load flag to kick start the resource loading for media
   files. LOAD_MEDIA_RESOURCE is added so that
   ResourceDispatcherHost knows how to use a different
   ResourceHandler for handling media resource request.

Review URL: http://codereview.chromium.org/27168
------------------------------------------------------------------------
r11659 | estade@chromium.org | 2009-03-13 21:01:43 +0100 (Fri, 13 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/chrome/browser/download/download_file.cc

Implement DownloadFile::Rename() for posix. Downloads work on linux!

Review URL: http://codereview.chromium.org/46020
------------------------------------------------------------------------
r11658 | sky@google.com | 2009-03-13 20:54:11 +0100 (Fri, 13 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

Fixes a regression were showing a link brought a browser when to front
when it shouldn't have.

BUG=8730
TEST=see bug

Review URL: http://codereview.chromium.org/46054
------------------------------------------------------------------------
r11655 | brettw@chromium.org | 2009-03-13 20:23:16 +0100 (Fri, 13 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   D /trunk/src/chrome/browser/debugger/debugger_contents.cc
   D /trunk/src/chrome/browser/debugger/debugger_contents.h
   A /trunk/src/chrome/browser/dom_ui/debugger_ui.cc (from /trunk/src/chrome/browser/debugger/debugger_contents.cc:11541)
   A /trunk/src/chrome/browser/dom_ui/debugger_ui.h (from /trunk/src/chrome/browser/debugger/debugger_contents.h:11541)
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Rename DebuggerContents to DebuggerUI and move to the dom_ui folder.
Review URL: http://codereview.chromium.org/46036
------------------------------------------------------------------------
r11653 | brettw@chromium.org | 2009-03-13 20:21:41 +0100 (Fri, 13 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h

Ports TextDatabase and ExpireHistoryTest to use FilePath.

Patch by rohitrao@google.com
http://codereview.chromium.org/40001
------------------------------------------------------------------------
r11652 | avi@google.com | 2009-03-13 20:12:20 +0100 (Fri, 13 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Adjust the plus button offset to match Windows more.

Review URL: http://codereview.chromium.org/46042
------------------------------------------------------------------------
r11651 | thestig@chromium.org | 2009-03-13 20:11:59 +0100 (Fri, 13 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/command_line.h
   M /trunk/src/base/condition_variable.h
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/logging.h
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_pump_glib.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/time_format.cc
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/libxml_utils.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/installer/util/helper_unittest.cc
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/l10n_string_util.cc
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/repeat_controller.h
   M /trunk/src/chrome/views/tree_node_model.h
   M /trunk/src/media/base/mock_filter_host.h
   M /trunk/src/media/filters/ffmpeg_demuxer.cc
   M /trunk/src/media/filters/null_audio_renderer.h
   M /trunk/src/net/base/client_socket_pool.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/tcp_client_socket.h
   M /trunk/src/net/disk_cache/entry_impl.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/sandbox/src/job_unittest.cc
   M /trunk/src/sandbox/src/named_pipe_policy.cc
   M /trunk/src/sandbox/src/restricted_token_unittest.cc
   M /trunk/src/sandbox/src/win_utils.cc
   M /trunk/src/sandbox/src/win_utils.h
   M /trunk/src/webkit/activex_shim/dispatch_object.h
   M /trunk/src/webkit/glue/autocomplete_input_listener.h
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/image_decoder.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/webkitclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h

Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files to ~400.
Review URL: http://codereview.chromium.org/46039
------------------------------------------------------------------------
r11648 | finnur@chromium.org | 2009-03-13 19:19:52 +0100 (Fri, 13 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Reverting 11642.

Reverting for now. Will try again later
Review URL: http://codereview.chromium.org/46046
------------------------------------------------------------------------
r11647 | deanm@chromium.org | 2009-03-13 19:19:37 +0100 (Fri, 13 Mar 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Fix ownership error with GtkTextTagTable and GtkTextTag.

When we create with gtk_text_buffer_create_tag:

"""
The returned tag is owned by the buffer's tag table, so the ref count will be equal to one.
"""

We do not own the tags, only the table.

Review URL: http://codereview.chromium.org/46044

------------------------------------------------------------------------
r11646 | finnur@chromium.org | 2009-03-13 19:17:36 +0100 (Fri, 13 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Reverting 11641.

Reverting for now. Will try again later
Review URL: http://codereview.chromium.org/46045
------------------------------------------------------------------------
r11645 | finnur@chromium.org | 2009-03-13 19:15:01 +0100 (Fri, 13 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/AUTHORS
   D /trunk/src/chrome/app/theme/rss.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/test_location_bar.h
   D /trunk/src/webkit/glue/feed.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Reverting 11640.

Reverting for now. Will try again later
------------------------------------------------------------------------
r11644 | deanm@chromium.org | 2009-03-13 18:50:34 +0100 (Fri, 13 Mar 2009) | 13 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Improve the look of the Linux omnibox.

- Paint a border around the input widget, which makes it fit better into the
  toolbar.  A bordered widget is also very nice to have for debugging, so I
  abstracted a small helper for making a bordered bin.

- Improve the results popup by painting with some Pango attributes.  Sort of
  looks awful over NX, but I'm hoping it looks better on a real session.

BUG=8236

Review URL: http://codereview.chromium.org/46035

------------------------------------------------------------------------
r11642 | finnur@chromium.org | 2009-03-13 18:41:42 +0100 (Fri, 13 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disabling a couple of UI tests while I investigate.

TBR=ojan
Review URL: http://codereview.chromium.org/46040
------------------------------------------------------------------------
r11641 | finnur@chromium.org | 2009-03-13 18:18:53 +0100 (Fri, 13 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Adding missing function to LocationBarViewGtk.

TBR=evanm

Review URL: http://codereview.chromium.org/46038
------------------------------------------------------------------------
r11640 | finnur@chromium.org | 2009-03-13 18:03:07 +0100 (Fri, 13 Mar 2009) | 13 lines
Changed paths:
   M /trunk/src/AUTHORS
   A /trunk/src/chrome/app/theme/rss.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/test_location_bar.h
   A /trunk/src/webkit/glue/feed.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

RSS feed support (part 1)

Part 1 is RSS feed auto-discovery. 

This will parse the web page header to find the feeds in the document and notify
the browser to display the RSS icon in the toolbar. You can click on the icon,
but it will just navigate to the first feed on the page, which (unless it has
been designed to be browser friendly) will just dump XML as text on the user.

For this reason I have disabled the code that makes the RSS icon appear and
intend to enable it when we have a good landing page to display the XML.

Review URL: http://codereview.chromium.org/43109
------------------------------------------------------------------------
r11639 | xji@chromium.org | 2009-03-13 18:00:38 +0100 (Fri, 13 Mar 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc

This CL fixes issue 8684 -- RTL Regression: Text should be right aligned for RTL languages on "Bookmark Manager"
(http://crbug.com/8684)

The problem is canvas.DrawStringWithHalo() within BookmarkTableView::PaintAltText() always use left alignment. 

The fix is to pass the correct canvas text alignment when DrawStringWithHalo().


Test:
1. Run Hebrew Chrome
2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog
3. Select "Search"
4. Observe

Without the fix:
Text "Enter a query in the text field above to search your bookmarks" is 
left aligned

With the fix:
The above text is right aligned Hebrew


Review URL: http://codereview.chromium.org/43146
------------------------------------------------------------------------
r11638 | pkasting@chromium.org | 2009-03-13 17:34:48 +0100 (Fri, 13 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Revert a change made to try and make purify errors go away now that Erik Kay has disabled purify runs for the relevant tests.
Review URL: http://codereview.chromium.org/42162
------------------------------------------------------------------------
r11636 | deanm@chromium.org | 2009-03-13 17:20:27 +0100 (Fri, 13 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Cleanup AutocompleteEditViewGtk's resources and widgets.

Review URL: http://codereview.chromium.org/46034

------------------------------------------------------------------------
r11634 | amit@chromium.org | 2009-03-13 17:13:02 +0100 (Fri, 13 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc

Fix a crash when with chrome-ui://about/" or anything invalid

If DOMUIContents::InitCurrentUI returns true then current_ui_
should always be valid. Changed logic inside to make sure that
this is the case.



Review URL: http://codereview.chromium.org/46009
------------------------------------------------------------------------
r11629 | maruel@chromium.org | 2009-03-13 15:36:40 +0100 (Fri, 13 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/webkit/glue/glue_serialize.h

Remove unneeded includes.
Review URL: http://codereview.chromium.org/43091
------------------------------------------------------------------------
r11628 | deanm@chromium.org | 2009-03-13 14:34:11 +0100 (Fri, 13 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Fix some browser shutdown issues on Linux.

The previous code ended up destroying the BrowserWindow (removing it from BrowserList) while BrowserList was in the middle of iterating.  Push the deletion onto the message loop (using DeleteSoon) to emulate what I'm guessing happens on Windows (the message is queue instead of processed right away).

This fixes a second bug involving re-entrancy issues with Close() and window_, we now make sure to set window_ to NULL before any events might fire.

BUG=8712

Review URL: http://codereview.chromium.org/43135

------------------------------------------------------------------------
r11627 | deanm@chromium.org | 2009-03-13 13:59:30 +0100 (Fri, 13 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Call into the IM hooks from the Linux Omnibox keyboard handling.

This should give input methods the proper chance to handle enter and escape.

Review URL: http://codereview.chromium.org/43149

------------------------------------------------------------------------
r11617 | thestig@chromium.org | 2009-03-13 05:27:33 +0100 (Fri, 13 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/thread_collision_warner.cc
   M /trunk/src/base/thread_collision_warner.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/media/base/pipeline_impl_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Remove unneeded platform_thread.h includes. Reduces number of includes from 598 to 511.
Review URL: http://codereview.chromium.org/42165
------------------------------------------------------------------------
r11613 | abarth@chromium.org | 2009-03-13 03:51:49 +0100 (Fri, 13 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/visitedlink_common.cc
   M /trunk/src/chrome/common/visitedlink_common.h

Don't leak visited site information from original profile to OTR profile.

BUG=8388
R=brettw

Review URL: http://codereview.chromium.org/42114
------------------------------------------------------------------------
r11604 | ananta@chromium.org | 2009-03-13 01:47:45 +0100 (Fri, 13 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Add support for repositioning/resizing a tab window. This is needed as the SetWindowPos call
can fail on Vista if the caller is running under low IL.

Review URL: http://codereview.chromium.org/42150
------------------------------------------------------------------------
r11601 | jam@chromium.org | 2009-03-13 01:18:06 +0100 (Fri, 13 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   D /trunk/src/chrome/renderer/chrome_plugin_host.cc
   D /trunk/src/chrome/renderer/chrome_plugin_host.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj

Get rid of the gears in renderer process code.  This allows me to do some cleanup in how resource dispatching happens in a future cl.
Review URL: http://codereview.chromium.org/42158
------------------------------------------------------------------------
r11594 | estade@chromium.org | 2009-03-13 00:36:30 +0100 (Fri, 13 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   A /trunk/src/chrome/browser/gtk/dialogs_gtk.cc
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Gtk dialogs, first cut.

Only the Save As file selection dialog is implemented for now.

Review URL: http://codereview.chromium.org/42152
------------------------------------------------------------------------
r11593 | thestig@chromium.org | 2009-03-13 00:20:46 +0100 (Fri, 13 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/base/data_pack_unittest.cc
   M /trunk/src/base/directory_watcher_unittest.cc
   M /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/base/file_util_linux.cc
   M /trunk/src/base/file_version_info_linux.cc
   M /trunk/src/base/gfx/rect_unittest.cc
   M /trunk/src/base/histogram_unittest.cc
   M /trunk/src/base/path_service_unittest.cc
   M /trunk/src/base/pickle_unittest.cc
   M /trunk/src/base/pr_time_unittest.cc
   M /trunk/src/base/process_posix.cc
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/system_monitor_posix.cc
   M /trunk/src/base/tracked_objects_unittest.cc
   M /trunk/src/base/watchdog_unittest.cc
   M /trunk/src/chrome/browser/command_updater_unittest.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/visit_tracker.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/common/animation_unittest.cc
   M /trunk/src/chrome/common/bzip2_unittest.cc
   M /trunk/src/chrome/common/chrome_paths_linux.cc
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas_skia.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas_win.cc
   M /trunk/src/chrome/common/gfx/emf_unittest.cc
   M /trunk/src/chrome/common/worker_thread_ticker_unittest.cc
   M /trunk/src/chrome/installer/util/create_reg_key_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/helper_unittest.cc
   M /trunk/src/chrome/installer/util/lzma_util.cc
   M /trunk/src/chrome/installer/util/move_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/set_reg_value_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/work_item_list_unittest.cc
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/separator.cc
   M /trunk/src/media/audio/win/audio_output_win_unittest.cc
   M /trunk/src/media/base/synchronizer.cc
   M /trunk/src/net/base/bzip2_filter.cc
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/sandbox/src/filesystem_dispatcher.cc
   M /trunk/src/sandbox/src/named_pipe_dispatcher.cc
   M /trunk/src/sandbox/src/named_pipe_policy.cc
   M /trunk/src/sandbox/src/process_thread_policy.cc
   M /trunk/src/sandbox/src/registry_dispatcher.cc
   M /trunk/src/sandbox/src/sync_dispatcher.cc
   M /trunk/src/sandbox/src/target_process.cc
   M /trunk/src/sandbox/src/win2k_threadpool.cc
   M /trunk/src/webkit/default_plugin/default_plugin.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc

Remove logging.h from cc files that don't use it.
Review URL: http://codereview.chromium.org/42155
------------------------------------------------------------------------
r11590 | thestig@chromium.org | 2009-03-12 23:41:54 +0100 (Thu, 12 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/condition_variable.h
   M /trunk/src/base/non_thread_safe.cc
   M /trunk/src/base/non_thread_safe.h
   M /trunk/src/base/task.h
   M /trunk/src/base/test_file_util_win.cc
   M /trunk/src/base/timer.h
   M /trunk/src/base/watchdog.h
   M /trunk/src/base/worker_pool_linux.cc
   M /trunk/src/base/worker_pool_win.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/url_fetcher_protect.cc
   M /trunk/src/chrome/browser/net/url_fetcher_protect.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/window_sizer_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/disk_cache/mapped_file_posix.cc
   M /trunk/src/net/disk_cache/mapped_file_win.cc
   M /trunk/src/net/disk_cache/mem_backend_impl.cc
   M /trunk/src/net/disk_cache/mem_entry_impl.cc
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/sandbox/src/sandbox_policy_base.cc
   M /trunk/src/sandbox/src/sandbox_policy_base.h
   M /trunk/src/tools/memory_watcher/hotkey.h
   M /trunk/src/tools/memory_watcher/memory_watcher.h
   M /trunk/src/webkit/default_plugin/plugin_impl_mac.h
   M /trunk/src/webkit/default_plugin/plugin_impl_win.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/cpp_bound_class.cc
   M /trunk/src/webkit/glue/cpp_bound_class.h
   M /trunk/src/webkit/glue/glue_accessibility.cc
   M /trunk/src/webkit/glue/inspector_client_impl.cc

Remove unneeded uses of logging.h in header files.
Review URL: http://codereview.chromium.org/43148
------------------------------------------------------------------------
r11587 | amit@chromium.org | 2009-03-12 23:26:09 +0100 (Thu, 12 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Fix 'inspect element' crash when hosted in external tab

If chrome tab is hosted in an external tab and 'inspect 
element' is invoked via GUI (as opposed to sending an
automation request for AutomationMsg_InspectElement), 
we get a crash in AutomationProvider::ReceivedInspectElementResponse

BUG=1694650


Review URL: http://codereview.chromium.org/43102
------------------------------------------------------------------------
r11575 | pinkerton@chromium.org | 2009-03-12 21:38:45 +0100 (Thu, 12 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/en.lproj/TabView.xib
   M /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Don't rely on subview ordering to be equivalent to tab ordering. Allows us to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image.
Review URL: http://codereview.chromium.org/43144
------------------------------------------------------------------------
r11571 | jam@chromium.org | 2009-03-12 21:15:31 +0100 (Thu, 12 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Fix SessionRestoreUITest.TwoTabsSecondSelected in single process mode.

This is admitedly a little hacky, but I don't care as much since it's single-process mode and I don't think there's another way to solve it.  The problem is that SiteInstance::GetProcess should always reuse an existing renderer "process", but GetExistingProcessHost() won't return the in-process renderer until RenderProcessHost::Init is called, which is after the second GetProcess call.  So since we generate the in-process 'pid', I do it in the constructor instead of in Init.

Review URL: http://codereview.chromium.org/42144
------------------------------------------------------------------------
r11568 | mpcomplete@google.com | 2009-03-12 20:58:20 +0100 (Thu, 12 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Run ExtensionViewTest in single-process mode to try to make it less flaky.

Changed InProcessBrowserTest to restore the original CommandLine after it
tears down.
Review URL: http://codereview.chromium.org/42084
------------------------------------------------------------------------
r11566 | ben@chromium.org | 2009-03-12 20:44:40 +0100 (Thu, 12 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc

bustage
------------------------------------------------------------------------
r11565 | ben@chromium.org | 2009-03-12 20:43:34 +0100 (Thu, 12 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

bustage
------------------------------------------------------------------------
r11564 | ben@chromium.org | 2009-03-12 20:39:09 +0100 (Thu, 12 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

bustage
------------------------------------------------------------------------
r11562 | ben@chromium.org | 2009-03-12 20:29:06 +0100 (Thu, 12 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view_win.cc
   M /trunk/src/chrome/views/widget.h
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h
   M /trunk/src/chrome/views/window.cc

Make Widget return a gfx::NativeView instead of a HWND.

Review URL: http://codereview.chromium.org/43124
------------------------------------------------------------------------
r11558 | sky@google.com | 2009-03-12 20:10:22 +0100 (Thu, 12 Mar 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/browser/bookmarks/base_bookmark_model_observer.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/views/chrome_menu.cc

Refactors code for showing bookmarks menus into a standalone class
that isn't tied to the bookmark bar. Removes some dead code from the
bookmark bar, and fixes a UMR in chrome_menu that I found when running
under purify. There isn't any behavior change in this patch.

BUG=none
TEST=this is a large refactoring of how bookmark menus are
  shown. Please thoroughly test menus on the bookmark bar to make sure I
  didn't screw anything up.

Review URL: http://codereview.chromium.org/42128
------------------------------------------------------------------------
r11550 | pkasting@chromium.org | 2009-03-12 19:02:56 +0100 (Thu, 12 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Make toggling fullscreen mode on/off significantly less janky-looking by means of various crazy hacks.
Review URL: http://codereview.chromium.org/42106
------------------------------------------------------------------------
r11545 | tc@google.com | 2009-03-12 18:14:31 +0100 (Thu, 12 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h

fix linux build.  we need to include basictypes.h to get
DISALLOW_COPY_AND_ASSIGN

TBR=finnur

Review URL: http://codereview.chromium.org/43140

------------------------------------------------------------------------
r11544 | tc@google.com | 2009-03-12 18:03:37 +0100 (Thu, 12 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/find_bar.h
   A /trunk/src/chrome/browser/find_bar_controller.cc
   A /trunk/src/chrome/browser/find_bar_controller.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   M /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.gyp

Some work in refactoring FindBarWin/FindBarView so
we can share code across platforms.

See http://code.google.com/p/chromium/wiki/FindBarRefactoring for
more information about the design.

Review URL: http://codereview.chromium.org/42057
------------------------------------------------------------------------
r11541 | pinkerton@chromium.org | 2009-03-12 17:35:23 +0100 (Thu, 12 Mar 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/en.lproj/TabView.xib
   A /trunk/src/chrome/app/theme/nav.pdf
   A /trunk/src/chrome/browser/cocoa/tab_controller.h
   A /trunk/src/chrome/browser/cocoa/tab_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   A /trunk/src/chrome/browser/cocoa/tab_view.h
   A /trunk/src/chrome/browser/cocoa/tab_view.mm
   M /trunk/src/chrome/chrome.gyp

Add a TabController class to manage a TabView (with corresponding xib). Rewrite strip controller to create and manage TabControllers instead of NSButtons.
Review URL: http://codereview.chromium.org/43137
------------------------------------------------------------------------
r11530 | deanm@chromium.org | 2009-03-12 14:02:31 +0100 (Thu, 12 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Have RenderWidgetHostViewGtk take ownership of its widget.

We previously left the widget floating, the reference would be sunk by the first container it was added to, if removed from this container it would be destroyed.  This was happening in WebContentsViewGtk, and then we were double-destroying the widget in RenderWidgetHostViewGtk::Destroy().

BUG=8707

Review URL: http://codereview.chromium.org/42119

------------------------------------------------------------------------
r11529 | deanm@chromium.org | 2009-03-12 12:20:43 +0100 (Thu, 12 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

Hookup the escape key on Linux Omnibox to revert to the permanent text (like Windows).

BUG=8236

Review URL: http://codereview.chromium.org/42074

------------------------------------------------------------------------
r11528 | deanm@chromium.org | 2009-03-12 12:16:01 +0100 (Thu, 12 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Fix a Linux Omnibox bug where a widget was used after it was destroyed.

Review URL: http://codereview.chromium.org/42073

------------------------------------------------------------------------
r11527 | deanm@chromium.org | 2009-03-12 12:15:14 +0100 (Thu, 12 Mar 2009) | 30 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Better keyboard and mouse handling in Omnibox:

- Grab enter key events before they get to GtkTextView.
  We need to do this, otherwise enter when text is selected
  will replace the text, and we won't get a chance to catch
  that happening.  This might have problems with IME, but it
  should be straightforward to fix anything IME related.

- Don't deselect when we lose focus.  This sometimes looks a
  bit strange, but it's the GTK thing to do.  This also unbreaks
  copy and paste via the context menu, since popping up the
  context menu makes the GtkTextView lose focus.

- Rewrite the inefficent newline eater.  This should now only be
  needed for newlines that didn't come from the keyboard (like when
  you paste text).  Use the builtin iter support for finding line
  boundaries, hopefully more efficient than checking the characters
  one by one.  Still might have some bad behavior when pasting a ton
  of newline characters, but that can be improved later.

This fixes inline autocomplete, you can now hit the enter key on an
inline autocompleted suggestion, and you will get the intented navigation,
instead of the navigation with the selected completion removed.

This also adds support for alt-enter in Omnibox to navigate in a new tab.

BUG=8236

Review URL: http://codereview.chromium.org/43072

------------------------------------------------------------------------
r11526 | deanm@chromium.org | 2009-03-12 12:13:38 +0100 (Thu, 12 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc

Add a GDK_COLOR_RGB macro for constructing GdkColors.

This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0.

Review URL: http://codereview.chromium.org/43077

------------------------------------------------------------------------
r11513 | sky@google.com | 2009-03-12 04:10:51 +0100 (Thu, 12 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc

Fixes bug were sorting bookmarks wouldn't trigger a save.

BUG=8655
TEST=see bug

Review URL: http://codereview.chromium.org/42103
------------------------------------------------------------------------
r11509 | jam@chromium.org | 2009-03-12 02:55:13 +0100 (Thu, 12 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h

Stop having renderers use both pids and a monotonically increasing "host_id".  This allows ResourceDispatcher to be used by child processes other than renderers.  I've done minor related cleanup on the way to make the code simpler.
Review URL: http://codereview.chromium.org/42054
------------------------------------------------------------------------
r11503 | pkasting@chromium.org | 2009-03-12 01:40:23 +0100 (Thu, 12 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h

Make fullscreen exit bubble link work by preventing the bubble from ever being activated.  Not sure why this worked in the first place and then regressed.

BUG=8318
Review URL: http://codereview.chromium.org/43107
------------------------------------------------------------------------
r11502 | thestig@chromium.org | 2009-03-12 01:23:07 +0100 (Thu, 12 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/net_util.h

Remove unneeded includes of googleurl/src/url_parse.h and url_canon.h.
Review URL: http://codereview.chromium.org/42102
------------------------------------------------------------------------
r11501 | jcampan@chromium.org | 2009-03-12 01:21:28 +0100 (Thu, 12 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/view_storage.cc
   M /trunk/src/chrome/views/view_storage.h

Moving the storing/restoring of the focus from TabContents to WebContentsView. This makes TabContents less dependent on views.

This requires few contortions with DOMUIs (NTP, history and downloads tab) as they still need to set the initial focus specifically.

BUG=None
TEST=Run the interactive tests.
Review URL: http://codereview.chromium.org/39269
------------------------------------------------------------------------
r11482 | pinkerton@chromium.org | 2009-03-11 22:03:13 +0100 (Wed, 11 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_cell.mm
   M /trunk/src/chrome/chrome.gyp

Bring over more code from cole to improve the appearance of tabs. Start building parts of GTM that are needed for theming.
Review URL: http://codereview.chromium.org/42081
------------------------------------------------------------------------
r11477 | sgk@google.com | 2009-03-11 21:33:04 +0100 (Wed, 11 Mar 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/debugger/debugger_shell_stubs.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Enable building of browser/debugger/debugger_{contents,shell}.cc on Linux.
This required getting rid of the stubs in common/temp_scaffolding_stubs.cc
to avoid duplicate symbols, in favor of moving the stubs into a separate
module for use when porting to new platforms.
Review URL: http://codereview.chromium.org/43089
------------------------------------------------------------------------
r11471 | mpcomplete@google.com | 2009-03-11 20:27:53 +0100 (Wed, 11 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Reverting 11467.
Review URL: http://codereview.chromium.org/43093
------------------------------------------------------------------------
r11468 | pinkerton@chromium.org | 2009-03-11 20:17:20 +0100 (Wed, 11 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_view.mm

Getting rid of dead code.
Review URL: http://codereview.chromium.org/43090
------------------------------------------------------------------------
r11467 | mpcomplete@google.com | 2009-03-11 20:04:08 +0100 (Wed, 11 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h

Try to make ExtensionViewTest less flaky by running it in single-process mode.
Review URL: http://codereview.chromium.org/42055
------------------------------------------------------------------------
r11465 | maruel@chromium.org | 2009-03-11 19:52:38 +0100 (Wed, 11 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/download/save_package.cc

Change to make the 'save as...' dialog choose the default download path you have selected in your prefs instead of always choosing the chrome::DIR_DEFAULT_DOWNLOADS path.
This will only affect you if you have not used 'save as...' before and do not have a SaveFileDefaultDirectory set.

Patch contributed by Paul Robinson <paulRobinson85@googlemail.com>

BUG=8049
Review URL: http://codereview.chromium.org/43016
------------------------------------------------------------------------
r11462 | tc@google.com | 2009-03-11 19:47:24 +0100 (Wed, 11 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_resources.scons
   M /trunk/src/chrome/browser/browser_main.cc

Fix directory listings in mac and linux by making sure the code
for loading the template is enabled and the resource exists.

Review URL: http://codereview.chromium.org/42053

------------------------------------------------------------------------
r11459 | phajdan.jr@chromium.org | 2009-03-11 19:35:10 +0100 (Wed, 11 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Hopefully make DownloadTest.UnknownSize not-flaky.

http://crbug.com/7191

Review URL: http://codereview.chromium.org/43046
------------------------------------------------------------------------
r11446 | pinkerton@chromium.org | 2009-03-11 15:57:22 +0100 (Wed, 11 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Add a couple more unit tests to the Mac build
Review URL: http://codereview.chromium.org/43076
------------------------------------------------------------------------
r11444 | avi@chromium.org | 2009-03-11 15:53:13 +0100 (Wed, 11 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/en.lproj/TabContents.xib
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Initial pass at copy/paste. Menu items are always enabled. This matches Windows; we'll do better soon.

Review URL: http://codereview.chromium.org/42018
------------------------------------------------------------------------
r11435 | pinkerton@chromium.org | 2009-03-11 14:21:35 +0100 (Wed, 11 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/test_tab_contents.h

Remove TabContents from scaffolding. Yay!
Review URL: http://codereview.chromium.org/43039
------------------------------------------------------------------------
r11434 | deanm@chromium.org | 2009-03-11 13:11:13 +0100 (Wed, 11 Mar 2009) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/views/constrained_window_animation.cc
   D /trunk/src/chrome/browser/views/constrained_window_animation.h
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/test/automation/ui_controls.cc
   D /trunk/src/chrome/test/automation/ui_controls.h
   D /trunk/src/chrome/test/test_file_util.cc
   D /trunk/src/chrome/test/test_file_util.h

Remove some empty source files from the tree.

It looks like these were originally meant to be deleted, but instead all of their lines were removed and the empty file was left behind.

Review URL: http://codereview.chromium.org/43021

------------------------------------------------------------------------
r11411 | glen@chromium.org | 2009-03-11 02:24:08 +0100 (Wed, 11 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/resources/history.html

Stop history search going on beyond the start of history.
Stop losing first-searches on history page due to 

BUG=8438,8456

Review URL: http://codereview.chromium.org/43054
------------------------------------------------------------------------
r11407 | estade@chromium.org | 2009-03-11 01:34:12 +0100 (Wed, 11 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/common/l10n_util.h

Change SpellChecker::Language to be an ASCII string.

Review URL: http://codereview.chromium.org/41028
------------------------------------------------------------------------
r11406 | estade@chromium.org | 2009-03-11 01:32:51 +0100 (Wed, 11 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

Add the show all downloads link to the download shelf on linux.
Review URL: http://codereview.chromium.org/43053
------------------------------------------------------------------------
r11393 | jam@chromium.org | 2009-03-10 23:44:13 +0100 (Tue, 10 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_util.cc

A little cleanup of ResourceDispatcherHost to make it less renderer centric, since it's used by plugin and worker processes.

Review URL: http://codereview.chromium.org/43001
------------------------------------------------------------------------
r11391 | sky@google.com | 2009-03-10 23:38:49 +0100 (Tue, 10 Mar 2009) | 11 lines
Changed paths:
   A /trunk/src/chrome/app/theme/dock_tab_high.png
   A /trunk/src/chrome/app/theme/dock_tab_max.png
   A /trunk/src/chrome/app/theme/dock_tab_wide.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Changes docking in the following ways:
. Dock icons for window docking positions could go offscreen
  before.
. It was possible to show the maximize indicator on the wrong
  screen. This was because equals was not comparing the monitor bounds.
. Tweaks to color, size and animation from Glen.

BUG=none
TEST=make sure there are no bugs with docking tabs.

Review URL: http://codereview.chromium.org/42041
------------------------------------------------------------------------
r11385 | avi@chromium.org | 2009-03-10 23:01:44 +0100 (Tue, 10 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fixes stretchy effect when window is enlarged past the backing bitmap's size.

Review URL: http://codereview.chromium.org/43037
------------------------------------------------------------------------
r11384 | avi@chromium.org | 2009-03-10 23:01:36 +0100 (Tue, 10 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Pass unhandled events to Cocoa; thanks to Dmitri for the event fix.

Review URL: http://codereview.chromium.org/42039
------------------------------------------------------------------------
r11383 | avi@chromium.org | 2009-03-10 23:01:15 +0100 (Tue, 10 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_mac.mm
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/webkit/glue/simple_clipboard_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.h

This changes the base clipboard class, as accomplishing paste requires that Clipboard::FormatType be IPC-able. The lowest-common denominator of unsigned int, NSString*, and GdkAtom is string, so string it is. (Linux changes by estade.)

Review URL: http://codereview.chromium.org/41012
------------------------------------------------------------------------
r11379 | jam@chromium.org | 2009-03-10 22:55:21 +0100 (Tue, 10 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Get rid of --start-renderers-manually since it's been broken for a long time (the browser needs the renderer's handle to duplicate handles).
Review URL: http://codereview.chromium.org/43035
------------------------------------------------------------------------
r11377 | jhawkins@chromium.org | 2009-03-10 22:52:07 +0100 (Tue, 10 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h

Move the tab images into the TabRenderer class.
Review URL: http://codereview.chromium.org/43038
------------------------------------------------------------------------
r11375 | mpcomplete@google.com | 2009-03-10 22:25:56 +0100 (Tue, 10 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Fix interactive UI tests.  It was crashing due to a NULL ExtensionsService in the unit test.

TBR=sky
Review URL: http://codereview.chromium.org/43042
------------------------------------------------------------------------
r11374 | mpcomplete@google.com | 2009-03-10 21:54:29 +0100 (Tue, 10 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc

Re-enable ExtensionViewTest.
Review URL: http://codereview.chromium.org/42040
------------------------------------------------------------------------
r11372 | pinkerton@chromium.org | 2009-03-10 21:31:32 +0100 (Tue, 10 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

First step at removing TabContents from temp scaffolding. Get rid of duplicated code in scaffolding in deference to equivalent code in tab_contents.cc.
Review URL: http://codereview.chromium.org/42031
------------------------------------------------------------------------
r11371 | mpcomplete@google.com | 2009-03-10 21:29:42 +0100 (Tue, 10 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc

Extra disable ExtensionViewTest.
------------------------------------------------------------------------
r11370 | jam@chromium.org | 2009-03-10 21:21:01 +0100 (Tue, 10 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Instead of queuing ResourceDispatcher IPC messages in RenderView, use ResourceDispatcherHost's ability to block requests for a given route in the browser process.  This is in prepration for switching to one ResourceDispatcher in the renderer process, instead of one per RenderView, to share more code between child processes.

I realize that this means that resource requests for RenderViews created by other RenderViews will start a little bit later now (after a hop to the UI thread and back), but I don't think it should lead to much delay (since if our UI thread is that bogged down, we have bigger problems).  I'll make sure this is the case by looking at the page cyclers.

Review URL: http://codereview.chromium.org/42005
------------------------------------------------------------------------
r11369 | estade@chromium.org | 2009-03-10 21:05:43 +0100 (Tue, 10 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

Make the download shelf in gtk look prettier (add top border, improve spacing).

Review URL: http://codereview.chromium.org/42025
------------------------------------------------------------------------
r11368 | estade@chromium.org | 2009-03-10 21:05:34 +0100 (Tue, 10 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Port navigation controller unittest to posix.

It now compiles, but doesn't link.

Review URL: http://codereview.chromium.org/43028
------------------------------------------------------------------------
r11366 | mpcomplete@google.com | 2009-03-10 20:44:27 +0100 (Tue, 10 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc

Disable ExtensionViewTest.Index while I fix it.

TBR=erikkay
------------------------------------------------------------------------
r11364 | tc@google.com | 2009-03-10 20:26:19 +0100 (Tue, 10 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/find_bar_gtk.cc
   A /trunk/src/chrome/browser/gtk/find_bar_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h

First cut at the find bar.

Ctrl+F will display a box (pushing down the web contents) that typing
into will cause webkit to highlight on the page.  Esc will dismiss the
box.

I also changed the gtk_widget_show_all in browser window to be a regular gtk_widget_show.  Child widgets need to manually show themselves now.

Review URL: http://codereview.chromium.org/42026

------------------------------------------------------------------------
r11360 | mpcomplete@google.com | 2009-03-10 20:15:08 +0100 (Tue, 10 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/index.html
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip.html (from /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip.html:11294)
   M /trunk/src/chrome/views/view.cc

Unrevert 11294.
- include stub fix so that linux/mac still build.
- fix DCHECK in views code.
- fix unit test.
Review URL: http://codereview.chromium.org/41020
------------------------------------------------------------------------
r11359 | pkasting@chromium.org | 2009-03-10 20:14:20 +0100 (Tue, 10 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Highlight tab close button on click.  Original patch by kimworking@gmail.com, r=me; see http://codereview.chromium.org/28302 .

BUG=7690
------------------------------------------------------------------------
r11355 | pkasting@chromium.org | 2009-03-10 20:09:07 +0100 (Tue, 10 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/views/window.cc

Make Chromium windows not hide auto-hide taskbars, take 2.

This is very similar to r10845, but also includes a regression fix for issue 8410, where locking and unlocking the screen would cause mispositioning of child content.

BUG=20,8410

Review URL: http://codereview.chromium.org/42027
------------------------------------------------------------------------
r11339 | deanm@chromium.org | 2009-03-10 17:56:27 +0100 (Tue, 10 Mar 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Some cleanups and hookups to LocationBarViewGtk.

- Rename FocusLocation to SetFocus (and don't make it select all).
  This matches the Windows style more closely.
- Implement SetUserText (basically copied from Windows w/ a TODO).
- Switch to the gtk_accel APIs instead of using the widget ones.
- Hookup FocusSearch (and its ctrl-k accelerator).
- Hookup AcceptInput (the go button now works!).
- Fix lack of space before {
- Rename edit_view_ to location_entry_ to match the Windows LocationBarView.
- Don't plumb FocusLocationBar through BrowserWindow -> BrowserToolbar.

Review URL: http://codereview.chromium.org/43025

------------------------------------------------------------------------
r11331 | deanm@chromium.org | 2009-03-10 15:23:48 +0100 (Tue, 10 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/app/google_update_client.h
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider_list.cc
   M /trunk/src/chrome/browser/automation/automation_provider_list.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.cc
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.cc
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.h
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_win.cc
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_prefs.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/browser_url_handler.h
   M /trunk/src/chrome/browser/browser_window_factory.mm
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   M /trunk/src/chrome/browser/cancelable_request.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/chrome_plugin_host.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/cross_site_request_manager.cc
   M /trunk/src/chrome/browser/cross_site_request_manager.h
   M /trunk/src/chrome/browser/debugger/debugger_contents.h
   M /trunk/src/chrome/browser/debugger/debugger_host.h
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.h
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/debugger/dev_tools_view.cc
   M /trunk/src/chrome/browser/debugger/dev_tools_view.h
   M /trunk/src/chrome/browser/debugger/dev_tools_window.cc
   M /trunk/src/chrome/browser/debugger/dev_tools_window.h
   M /trunk/src/chrome/browser/dom_operation_notification_details.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dev_tools_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dev_tools_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_item_model.h
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate.h
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_item.cc
   M /trunk/src/chrome/browser/download/save_item.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/download/save_types.h
   M /trunk/src/chrome/browser/drag_utils.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.h
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.h
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_database.cc
   M /trunk/src/chrome/browser/history/in_memory_database.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/page_usage_data.cc
   M /trunk/src/chrome/browser/history/page_usage_data.h
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/history/snippet.h
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/history/visit_tracker.cc
   M /trunk/src/chrome/browser/history/visit_tracker.h
   M /trunk/src/chrome/browser/history/visit_tracker_unittest.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.h
   M /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/browser/ime_input.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/jankometer.h
   M /trunk/src/chrome/browser/js_before_unload_handler.h
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h
   M /trunk/src/chrome/browser/load_notification_details.h
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_unittest.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/meta_table_helper.h
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_response.cc
   M /trunk/src/chrome/browser/metrics/metrics_response.h
   M /trunk/src/chrome/browser/metrics/metrics_response_unittest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.cc
   M /trunk/src/chrome/browser/metrics/user_metrics.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/page_state.h
   M /trunk/src/chrome/browser/password_manager/encryptor_unittest.cc
   M /trunk/src/chrome/browser/password_manager/ie7_password.cc
   M /trunk/src/chrome/browser/password_manager/ie7_password.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/printing/page_number.cc
   M /trunk/src/chrome/browser/printing/page_number.h
   M /trunk/src/chrome/browser/printing/page_number_unittest.cc
   M /trunk/src/chrome/browser/printing/page_overlays.cc
   M /trunk/src/chrome/browser/printing/page_overlays.h
   M /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   M /trunk/src/chrome/browser/printing/page_range.cc
   M /trunk/src/chrome/browser/printing/page_range.h
   M /trunk/src/chrome/browser/printing/page_range_unittest.cc
   M /trunk/src/chrome/browser/printing/page_setup.cc
   M /trunk/src/chrome/browser/printing/page_setup.h
   M /trunk/src/chrome/browser/printing/page_setup_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/print_settings.cc
   M /trunk/src/chrome/browser/printing/print_settings.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/printing/printed_page.cc
   M /trunk/src/chrome/browser/printing/printed_page.h
   M /trunk/src/chrome/browser/printing/printed_pages_source.h
   M /trunk/src/chrome/browser/printing/printer_query.cc
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/printing/printing_test.h
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/printing/win_printing_context_unittest.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/rlz/rlz.h
   M /trunk/src/chrome/browser/rlz/rlz_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/browser/search_engines/template_url.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/search_engines/template_url_parser.h
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/session_startup_pref.h
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.h
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/page_navigator.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_contents/tab_util.h
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/event_utils.cc
   M /trunk/src/chrome/browser/views/event_utils.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.h
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/input_window.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/standard_layout.h
   M /trunk/src/chrome/browser/views/status_bubble_views.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/theme_helpers.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/window_sizer_unittest.cc
   M /trunk/src/chrome/common/animation.cc
   M /trunk/src/chrome/common/animation.h
   M /trunk/src/chrome/common/animation_unittest.cc
   M /trunk/src/chrome/common/bzip2_unittest.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/common/chrome_counters.h
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/chrome_process_filter.cc
   M /trunk/src/chrome/common/chrome_process_filter.h
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/classfactory.cc
   M /trunk/src/chrome/common/classfactory.h
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/debug_flags.h
   M /trunk/src/chrome/common/drag_drop_types.cc
   M /trunk/src/chrome/common/drag_drop_types.h
   M /trunk/src/chrome/common/env_vars.cc
   M /trunk/src/chrome/common/env_vars.h
   M /trunk/src/chrome/common/filter_policy.h
   M /trunk/src/chrome/common/gears_api.h
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/common/gfx/chrome_font.h
   M /trunk/src/chrome/common/gfx/chrome_font_gtk.cc
   M /trunk/src/chrome/common/gfx/chrome_font_win.cc
   M /trunk/src/chrome/common/gfx/color_utils.cc
   M /trunk/src/chrome/common/gfx/color_utils.h
   M /trunk/src/chrome/common/gfx/emf.cc
   M /trunk/src/chrome/common/gfx/emf.h
   M /trunk/src/chrome/common/gfx/emf_unittest.cc
   M /trunk/src/chrome/common/gfx/favicon_size.h
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/common/gfx/icon_util.h
   M /trunk/src/chrome/common/gfx/icon_util_unittest.cc
   M /trunk/src/chrome/common/gfx/insets.h
   M /trunk/src/chrome/common/gfx/utils.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message.cc
   M /trunk/src/chrome/common/ipc_message.h
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_unittest.cc
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_sync_channel.h
   M /trunk/src/chrome/common/ipc_sync_message.cc
   M /trunk/src/chrome/common/ipc_sync_message.h
   M /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.h
   M /trunk/src/chrome/common/json_value_serializer.cc
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/json_value_serializer_perftest.cc
   M /trunk/src/chrome/common/jstemplate_builder.cc
   M /trunk/src/chrome/common/jstemplate_builder.h
   M /trunk/src/chrome/common/l10n_util_win.cc
   M /trunk/src/chrome/common/l10n_util_win.h
   M /trunk/src/chrome/common/libxml_utils.cc
   M /trunk/src/chrome/common/libxml_utils.h
   M /trunk/src/chrome/common/logging_chrome.h
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/common/message_router.cc
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/common/mru_cache.h
   M /trunk/src/chrome/common/navigation_types.h
   M /trunk/src/chrome/common/net/cache_uitest.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.h
   M /trunk/src/chrome/common/net/url_util_unittest.cc
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_service.cc
   M /trunk/src/chrome/common/notification_service.h
   M /trunk/src/chrome/common/notification_service_unittest.cc
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/common/os_exchange_data_unittest.cc
   M /trunk/src/chrome/common/page_transition_types.h
   M /trunk/src/chrome/common/page_zoom.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/pref_member.cc
   M /trunk/src/chrome/common/pref_member.h
   M /trunk/src/chrome/common/pref_member_unittest.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/resource_bundle.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/scoped_vector.h
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   M /trunk/src/chrome/common/sqlite_compiled_statement.h
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/common/task_queue.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/throb_animation.cc
   M /trunk/src/chrome/common/throb_animation.h
   M /trunk/src/chrome/common/thumbnail_score.cc
   M /trunk/src/chrome/common/thumbnail_score.h
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/common/time_format_unittest.cc
   M /trunk/src/chrome/common/unzip.cc
   M /trunk/src/chrome/common/unzip.h
   M /trunk/src/chrome/common/unzip_unittest.cc
   M /trunk/src/chrome/common/visitedlink_common.h
   M /trunk/src/chrome/common/win_safe_util.cc
   M /trunk/src/chrome/common/win_safe_util.h
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_thread_ticker.h
   M /trunk/src/chrome/installer/mini_installer/mini_installer.cc
   M /trunk/src/chrome/installer/mini_installer/mini_installer.h
   M /trunk/src/chrome/installer/mini_installer/pe_resource.cc
   M /trunk/src/chrome/installer/mini_installer/pe_resource.h
   M /trunk/src/chrome/installer/setup/compat_checks_unittest.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/setup_constants.cc
   M /trunk/src/chrome/installer/setup/setup_constants.h
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/compat_checks.cc
   M /trunk/src/chrome/installer/util/compat_checks_unittest.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/create_dir_work_item.cc
   M /trunk/src/chrome/installer/util/create_dir_work_item.h
   M /trunk/src/chrome/installer/util/create_dir_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/create_reg_key_work_item.cc
   M /trunk/src/chrome/installer/util/create_reg_key_work_item.h
   M /trunk/src/chrome/installer/util/create_reg_key_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item.cc
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item.h
   M /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/delete_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.h
   M /trunk/src/chrome/installer/util/helper.cc
   M /trunk/src/chrome/installer/util/helper.h
   M /trunk/src/chrome/installer/util/helper_unittest.cc
   M /trunk/src/chrome/installer/util/html_dialog.h
   M /trunk/src/chrome/installer/util/html_dialog_impl.cc
   M /trunk/src/chrome/installer/util/install_util.h
   M /trunk/src/chrome/installer/util/l10n_string_util.cc
   M /trunk/src/chrome/installer/util/l10n_string_util.h
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/lzma_util.cc
   M /trunk/src/chrome/installer/util/lzma_util.h
   M /trunk/src/chrome/installer/util/move_tree_work_item.h
   M /trunk/src/chrome/installer/util/set_reg_value_work_item.cc
   M /trunk/src/chrome/installer/util/set_reg_value_work_item.h
   M /trunk/src/chrome/installer/util/set_reg_value_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/version.cc
   M /trunk/src/chrome/installer/util/version.h
   M /trunk/src/chrome/installer/util/work_item.cc
   M /trunk/src/chrome/installer/util/work_item.h
   M /trunk/src/chrome/installer/util/work_item_list.cc
   M /trunk/src/chrome/installer/util/work_item_list.h
   M /trunk/src/chrome/installer/util/work_item_list_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/npobject_stub.cc
   M /trunk/src/chrome/plugin/npobject_util.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/about_handler.cc
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.cc
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   M /trunk/src/chrome/renderer/chrome_plugin_host.h
   M /trunk/src/chrome/renderer/debug_message_handler.cc
   M /trunk/src/chrome/renderer/dev_tools_agent.cc
   M /trunk/src/chrome/renderer/dev_tools_agent.h
   M /trunk/src/chrome/renderer/dev_tools_client.cc
   M /trunk/src/chrome/renderer/dev_tools_client.h
   M /trunk/src/chrome/renderer/dev_tools_messages.h
   M /trunk/src/chrome/renderer/dev_tools_messages_internal.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/extensions/greasemonkey_api_unittest.cc
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/external_js_object.cc
   M /trunk/src/chrome/renderer/external_js_object.h
   M /trunk/src/chrome/renderer/localized_error.h
   M /trunk/src/chrome/renderer/net/render_dns_master.cc
   M /trunk/src/chrome/renderer/net/render_dns_master.h
   M /trunk/src/chrome/renderer/net/render_dns_queue.cc
   M /trunk/src/chrome/renderer/net/render_dns_queue.h
   M /trunk/src/chrome/renderer/net/render_dns_queue_unittest.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.cc
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/visitedlink_slave.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.h
   M /trunk/src/chrome/test/accessibility/browser_impl.cc
   M /trunk/src/chrome/test/accessibility/browser_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h
   M /trunk/src/chrome/test/accessibility/keyboard_util.cc
   M /trunk/src/chrome/test/accessibility/keyboard_util.h
   M /trunk/src/chrome/test/accessibility/registry_util.cc
   M /trunk/src/chrome/test/accessibility/registry_util.h
   M /trunk/src/chrome/test/accessibility/tab_impl.cc
   M /trunk/src/chrome/test/accessibility/tab_impl.h
   M /trunk/src/chrome/test/activex_test_control/activex_test_control.cc
   M /trunk/src/chrome/test/activex_test_control/chrome_test_control.cc
   M /trunk/src/chrome/test/activex_test_control/chrome_test_control.h
   M /trunk/src/chrome/test/activex_test_control/chrome_test_control_cp.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_handle_tracker.cc
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.h
   M /trunk/src/chrome/test/injection_test_dll.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.h
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.h
   M /trunk/src/chrome/test/mini_installer_test/test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/perf/mem_usage.cc
   M /trunk/src/chrome/test/perf/mem_usage.h
   M /trunk/src/chrome/test/perf/perftests.cc
   M /trunk/src/chrome/test/reliability/page_load_test.h
   M /trunk/src/chrome/test/reliability/reliability_test_suite.h
   M /trunk/src/chrome/test/reliability/run_all_unittests.cc
   M /trunk/src/chrome/test/security_tests/ipc_security_tests.cc
   M /trunk/src/chrome/test/security_tests/ipc_security_tests.h
   M /trunk/src/chrome/test/security_tests/security_tests.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/test_notification_tracker.cc
   M /trunk/src/chrome/test/test_notification_tracker.h
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/sandbox_uitests.cc
   M /trunk/src/chrome/test/v8_unit_test.h
   M /trunk/src/chrome/tools/build/win/precompiled.h
   M /trunk/src/chrome/tools/build/win/precompiled_wtl.h
   M /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   M /trunk/src/chrome/tools/convert_dict/aff_reader.h
   M /trunk/src/chrome/tools/convert_dict/convert_dict.cc
   M /trunk/src/chrome/tools/convert_dict/dic_reader.cc
   M /trunk/src/chrome/tools/convert_dict/dic_reader.h
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.cc
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.h
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.h
   M /trunk/src/chrome/tools/crash_service/main.cc
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/accelerator.h
   M /trunk/src/chrome/views/accelerator_handler.h
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.cc
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.h
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.h
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.h
   M /trunk/src/chrome/views/app_modal_dialog_delegate.h
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/background.h
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.h
   M /trunk/src/chrome/views/border.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/checkbox.cc
   M /trunk/src/chrome/views/checkbox.h
   M /trunk/src/chrome/views/combo_box.cc
   M /trunk/src/chrome/views/combo_box.h
   M /trunk/src/chrome/views/controller.h
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   M /trunk/src/chrome/views/decision.cc
   M /trunk/src/chrome/views/decision.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_client_view.h
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/external_focus_tracker.cc
   M /trunk/src/chrome/views/external_focus_tracker.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/grid_layout.cc
   M /trunk/src/chrome/views/grid_layout.h
   M /trunk/src/chrome/views/grid_layout_unittest.cc
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view.h
   M /trunk/src/chrome/views/image_view.cc
   M /trunk/src/chrome/views/image_view.h
   M /trunk/src/chrome/views/layout_manager.cc
   M /trunk/src/chrome/views/layout_manager.h
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/link.h
   M /trunk/src/chrome/views/menu.cc
   M /trunk/src/chrome/views/menu.h
   M /trunk/src/chrome/views/menu_button.h
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/message_box_view.h
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/native_scroll_bar.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/painter.h
   M /trunk/src/chrome/views/radio_button.cc
   M /trunk/src/chrome/views/radio_button.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/root_view_drop_target.h
   M /trunk/src/chrome/views/scroll_bar.cc
   M /trunk/src/chrome/views/scroll_bar.h
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/scroll_view.h
   M /trunk/src/chrome/views/separator.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_button.h
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/throbber.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view_menu_delegate.h
   M /trunk/src/chrome/views/view_storage.cc
   M /trunk/src/chrome/views/widget.h
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window_delegate.cc
   M /trunk/src/chrome/views/window_delegate.h
   M /trunk/src/chrome/views/window_resources.h

NO CODE CHANGE

Normalize end of file newlines in chrome/.  All files end in a single newline.

Review URL: http://codereview.chromium.org/42015

------------------------------------------------------------------------
r11327 | deanm@chromium.org | 2009-03-10 14:03:19 +0100 (Tue, 10 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/base/gfx/gtk_util.cc
   M /trunk/src/base/gfx/gtk_util.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Move GdkPixbufFromSkBitmap to gtk_util so it can easily be shared.

Review URL: http://codereview.chromium.org/38009

------------------------------------------------------------------------
r11325 | deanm@chromium.org | 2009-03-10 13:50:42 +0100 (Tue, 10 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_factory_gtk.cc
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc

Normalize end of file newlines in chrome/browser/gtk/.

All files should now end in only a single newline.

Review URL: http://codereview.chromium.org/42010
------------------------------------------------------------------------
r11324 | deanm@chromium.org | 2009-03-10 13:47:14 +0100 (Tue, 10 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc

Add a copyright header to location_bar_view_gtk.cc.

This is a new file committed in r11323, adding a proper copyright header.

Review URL: http://codereview.chromium.org/43013

------------------------------------------------------------------------
r11323 | deanm@chromium.org | 2009-03-10 13:35:31 +0100 (Tue, 10 Mar 2009) | 8 lines
Changed paths:
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   A /trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc
   A /trunk/src/chrome/browser/gtk/location_bar_view_gtk.h

Implement a GTK LocationBarView and Autocomplete{Edit,Popup}View.

This implements some beginning functionality of "omnibox".  It uses GtkTextView for a rich text edit for the location bar.  Color emphasis, inline autocomplete, and the results popup work.  You can select one of the omnibox results using the keyboard.  Mouse selection doesn't work.  The results popup code will have to be scraped and reimplemented with cairo / pango.

BUG=8236

Review URL: http://codereview.chromium.org/40013

------------------------------------------------------------------------
r11322 | yurys@google.com | 2009-03-10 13:27:34 +0100 (Tue, 10 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc

Added null-check for current DOMUI.

BUG=8546
Review URL: http://codereview.chromium.org/43010
------------------------------------------------------------------------
r11321 | yurys@google.com | 2009-03-10 10:59:04 +0100 (Tue, 10 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

If the flag is specified developer tools window will be opened instead of Console Debugger when user clicks Debug JavaScript. This is a temporary solution and we will get rid of this flag as well as of debugger console when developer tools implement all their functionality.
Review URL: http://codereview.chromium.org/39259
------------------------------------------------------------------------
r11311 | ben@chromium.org | 2009-03-10 01:15:38 +0100 (Tue, 10 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/input_window.cc

InputWindow's window delegate should pass DeleteDelegate through to its own delegate to avoid
crashing because of not cleaning up.

http://crbug.com/8573

Review URL: http://codereview.chromium.org/40326
------------------------------------------------------------------------
r11300 | markus@chromium.org | 2009-03-09 23:31:39 +0100 (Mon, 09 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h

Adds support for BlockTillLoaded to Linux.
Review URL: http://codereview.chromium.org/39298
------------------------------------------------------------------------
r11299 | ben@chromium.org | 2009-03-09 23:29:01 +0100 (Mon, 09 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Make the last tab part of the client area instead of the non-client as it is now.

Remove some stupid code in the Tab's mouse pressed handler that was duplicating the nc-hittest handler. o_O.

http://crbug.com/8519

Review URL: http://codereview.chromium.org/41018
------------------------------------------------------------------------
r11295 | mpcomplete@google.com | 2009-03-09 23:08:37 +0100 (Mon, 09 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/index.html (from /trunk/src/chrome/test/data/extensions/good/extension1/1/index.html:11293)
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip.html

Reverting 11294.
Review URL: http://codereview.chromium.org/40321
------------------------------------------------------------------------
r11294 | mpcomplete@google.com | 2009-03-09 22:50:18 +0100 (Mon, 09 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   D /trunk/src/chrome/test/data/extensions/good/extension1/1/index.html
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/toolstrip.html (from /trunk/src/chrome/test/data/extensions/good/extension1/1/index.html:11167)

Support loading extensions into the bookmark toolbar.

Misc cleanup:
- remove duplicate comments on Extension accessors
- remove useless function in ExtensionsService
Review URL: http://codereview.chromium.org/39285
------------------------------------------------------------------------
r11292 | jcampan@chromium.org | 2009-03-09 22:27:15 +0100 (Mon, 09 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Relanding the CL removing Windows specific code from the interstitial page.
Somehow it was not compiling in non-debug anymore because of a this being used in the initializer without the right warning removed macro.

BUG=None
TEST=Visit a bad HTTPS page, make sure interstitial still shows and works properly.
Review URL: http://codereview.chromium.org/41015
------------------------------------------------------------------------
r11289 | sidchat@google.com | 2009-03-09 22:20:36 +0100 (Mon, 09 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Remove the spellcheck language preference setting when UI language is changed, so that spellcheck language falls back to default.

Issue=7811
------------------------------------------------------------------------
r11288 | estade@chromium.org | 2009-03-09 22:11:36 +0100 (Mon, 09 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.h
   M /trunk/src/chrome/test/test_tab_contents.h
   M /trunk/src/chrome/test/unit/unit_tests.scons

Enable download_request_manager_unittest on linux.

Review URL: http://codereview.chromium.org/41002
------------------------------------------------------------------------
r11287 | sky@google.com | 2009-03-09 22:11:01 +0100 (Mon, 09 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc

Fixes session restore bug where we wouldn't necessarily correctly
restore the maximized state. The problem was we were using a boolean
when we really needed three values: use the default, explicitly
maximized or explicitly normal.

I'm also removing a bogus DLOG in info_bubble.

BUG=7930
TEST=see bug

Review URL: http://codereview.chromium.org/40306
------------------------------------------------------------------------
r11286 | tc@google.com | 2009-03-09 21:56:36 +0100 (Mon, 09 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_strings.scons
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

hook up history and download menu items

Small fix to get them to display (need to include webkit strings in our
language pak files).

Review URL: http://codereview.chromium.org/39296

------------------------------------------------------------------------
r11285 | sky@google.com | 2009-03-09 21:55:54 +0100 (Mon, 09 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h

Fixes crash in ResizeCorner. ResizeCorner was caching the BrowserView
that created it, but if a tab contained a download shelf and was
dragged to a new window the ResizeCorner would be referencing the
wrong BrowserView. I've changed the code to look up the ancestor
BrowserView as necessary.

BUG=8477
TEST=see bug

Review URL: http://codereview.chromium.org/41010
------------------------------------------------------------------------
r11284 | pkasting@chromium.org | 2009-03-09 21:41:27 +0100 (Mon, 09 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/views/window.cc

Back out r10845 because it caused too many other regressions.

------------------------------------------------------------------------
r11283 | jrg@chromium.org | 2009-03-09 21:40:06 +0100 (Mon, 09 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Remove compile warning on OSX if branded

Review URL: http://codereview.chromium.org/40316
------------------------------------------------------------------------
r11279 | hclam@chromium.org | 2009-03-09 21:13:01 +0100 (Mon, 09 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h

BUG=8345
Added a PasswordManagerTableModelObserver to listen for row count change events.
PasswordManagerView and PasswordManagerExceptionsView are listening to the
event.
Move the |instance_| variable from static global to the respective class to
avoid future misuse of the variable.

Review URL: http://codereview.chromium.org/39313
------------------------------------------------------------------------
r11278 | jcampan@chromium.org | 2009-03-09 21:07:23 +0100 (Mon, 09 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Reverting 11277.

Reverting build bustage
Review URL: http://codereview.chromium.org/40315
------------------------------------------------------------------------
r11277 | jcampan@chromium.org | 2009-03-09 20:57:50 +0100 (Mon, 09 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Removing Windows specific code from interstitial pages.

BUG=None
TEST=Navigate to bad https URL, make sure interstitial page still shows up and works as expected.
Review URL: http://codereview.chromium.org/40311
------------------------------------------------------------------------
r11275 | tommi@chromium.org | 2009-03-09 20:48:37 +0100 (Mon, 09 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Changing ForwardMessageToExternalHost to postMessage and passing a proper
MessageEvent object to the onmessage handler.

Also adding support for origin and target parameters.  The origin parameter is
implicit but target can be specified when calling postMessage.  If no target
is specified we default to "*".

At the moment I'm only allowing target == "*" messages to pass through since
I haven't implemented support for matching more complicated patterns :)

Review URL: http://codereview.chromium.org/40128
------------------------------------------------------------------------
r11274 | munjal@chromium.org | 2009-03-09 20:37:36 +0100 (Mon, 09 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes issue 8435 (http://code.google.com/p/chromium/issues/detail?id=8435)

Review URL: http://codereview.chromium.org/39303
------------------------------------------------------------------------
r11271 | estade@chromium.org | 2009-03-09 20:21:21 +0100 (Mon, 09 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.h
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.cc
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h

Implement right click context menu on gtk.

Review URL: http://codereview.chromium.org/40266
------------------------------------------------------------------------
r11262 | sky@google.com | 2009-03-09 19:27:34 +0100 (Mon, 09 Mar 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_backend_unittest.cc

Fixes possible crash in SessionBackend. I believe what's happening
here is we fail to create the file, and so current_session_file_.get()
is NULL and we crash. current_session_file_.get() is NULL if
OpenAndWriteHeader returns NULL (which is does if the full header
isn't written correctly.

Here's how I'm changing the code:
. The file is now truncated instead of closed/reopened. Hopefully this avoids the possibility of a scanner locking the file and the delete failing.
. Added a unit test for coverage of truncation.
. The file is opened in exclusive access. There is no reason why a scanner should open this file.
. Added null checks.

BUG=8476
TEST=none

Review URL: http://codereview.chromium.org/39275
------------------------------------------------------------------------
r11249 | phajdan.jr@chromium.org | 2009-03-09 18:01:37 +0100 (Mon, 09 Mar 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/history/page_usage_data.h
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_backend_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.cc
   M /trunk/src/chrome/browser/sessions/session_service_test_helper.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Run more unit tests on Linux:

- used string16 instead of wstring where needed
- replaced GetTickCount calls with portable functions from base/time.h
- misc GCC cleanups
- enabled following unit tests on Linux:

    browser/autocomplete/history_contents_provider_unittest.cc
    browser/autocomplete/history_url_provider_unittest.cc
    browser/autocomplete/keyword_provider_unittest.cc
    browser/bookmarks/bookmark_html_writer_unittest.cc

Review URL: http://codereview.chromium.org/39335
------------------------------------------------------------------------
r11248 | jar@chromium.org | 2009-03-09 17:53:31 +0100 (Mon, 09 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/net/base/bzip2_filter.cc
   M /trunk/src/net/base/bzip2_filter.h
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   A /trunk/src/net/base/filter_unittest.h
   M /trunk/src/net/base/gzip_filter.cc
   M /trunk/src/net/base/gzip_filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   M /trunk/src/net/base/sdch_filter.cc
   M /trunk/src/net/base/sdch_filter.h
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/url_request/url_request_about_job.cc
   M /trunk/src/net/url_request/url_request_about_job.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_ftp_job.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_simple_job.cc
   M /trunk/src/net/url_request/url_request_simple_job.h
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_test_job.h

Use FilterContext to allow filters to access URLRequestJob data

r=wtc,darin,huanr
Review URL: http://codereview.chromium.org/40138
------------------------------------------------------------------------
r11233 | rafaelw@chromium.org | 2009-03-09 02:47:37 +0100 (Mon, 09 Mar 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/extensions/extension_ui_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/resources/extensions.html
   M /trunk/src/chrome/chrome.gyp
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/js_files
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/js_files/script3.js
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/ui
   A /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output
   A /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json
   A /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json
   A /trunk/src/chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

chrome-ui://extensions/ is now populated with data collected from the ExtensionsService and ExtensionErrorReporter

Review URL: http://codereview.chromium.org/39026
------------------------------------------------------------------------
r11221 | jcampan@chromium.org | 2009-03-08 08:41:31 +0100 (Sun, 08 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Landing again the CL that adds security info to canceled requests (last time it was causing sync XMLHttpRequests to hang, breaking many layout tests).

TBR=darin
Review URL: http://codereview.chromium.org/39321
------------------------------------------------------------------------
r11219 | jar@chromium.org | 2009-03-08 05:52:15 +0100 (Sun, 08 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

The MetricsService are not initialized unless the user have opted in

See contributed CL 28315 by Xharze

BUG=2278
Review URL: http://codereview.chromium.org/40274
------------------------------------------------------------------------
r11201 | nsylvain@chromium.org | 2009-03-07 17:13:11 +0100 (Sat, 07 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Revert change 11197 because it created 138 new layout tests
failures.

Review URL: http://codereview.chromium.org/39311
------------------------------------------------------------------------
r11197 | jcampan@chromium.org | 2009-03-07 08:47:52 +0100 (Sat, 07 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Landing again the CL that adds security info to canceled requests (it was breaking NPAPI tests on Vista due to an erroneuous commented line).

TBR=darin


Review URL: http://codereview.chromium.org/39309
------------------------------------------------------------------------
r11187 | jcampan@chromium.org | 2009-03-07 02:31:57 +0100 (Sat, 07 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Reverting 11179.

Reverting CL as plugin UI tests fail on Vista
Review URL: http://codereview.chromium.org/40260
------------------------------------------------------------------------
r11186 | estade@chromium.org | 2009-03-07 02:20:02 +0100 (Sat, 07 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc

oops

------------------------------------------------------------------------
r11184 | estade@chromium.org | 2009-03-07 02:16:38 +0100 (Sat, 07 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc

fix windows build break.

tbr=tony

Review URL: http://codereview.chromium.org/40259
------------------------------------------------------------------------
r11183 | estade@chromium.org | 2009-03-07 02:06:38 +0100 (Sat, 07 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   D /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   D /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.h
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.cc
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_win.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/clipboard_service.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Refactor render view context menu in preparation for porting.

* RenderViewContextMenu is now cross platform. Each platform needs to implement an inheritor that fills in the virtual methods.
* RenderViewContextMenuController was deleted. Platform agnostic elements from it were added to RenderViewContextMenu, while the Menu::Delegate implemenation was moved to RenderViewContextMenuWin.
* Some more (minor) refactoring may need to be performed as the rest of the menu actions are ported.
* include clipboard_service.h on all platforms (not sure why it wasn't included before)
Review URL: http://codereview.chromium.org/40249
------------------------------------------------------------------------
r11182 | mmoss@chromium.org | 2009-03-07 01:50:40 +0100 (Sat, 07 Mar 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/renderer_host/backing_store_mac.cc (from /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc:11181)
   D /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc
   M /trunk/src/chrome/chrome.gyp

Rename _posix to _mac since it doesn't build on Linux.

Fixes a gyp Linux build error because gyp expects all _posix files to actually
build on all posix platforms.

Review URL: http://codereview.chromium.org/39290

------------------------------------------------------------------------
r11180 | jungshik@google.com | 2009-03-07 01:26:00 +0100 (Sat, 07 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/resources/locale_settings_he.xtb
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc

Make both Hebrew Visual (ISO-8859-8) and Hebrew Logical (ISO-8859-8-I)
available in the encoding menu. Make windows-1255 come before
ISO-8859-8* both in the full encoding list and in Hebew Chrome's
static list. 

BUG=2927

Review URL: http://codereview.chromium.org/39248
------------------------------------------------------------------------
r11179 | jcampan@chromium.org | 2009-03-07 01:19:38 +0100 (Sat, 07 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

This CL adds a way to specify the security info when canceling a URLRequest.
This allows to tag a request on the renderer side with its security info.  It is useful for the "frame info" dialog.
When showing that dialog for blocked frames, the security info can be retrieved and users can see the cert details for the blocked frame.

TEST=Open a page containing a frame served over bad HTTPS.  The frame is blocked (replaced with a warning message). Right-click, select "Frame info". The dialog should have a "show cert" button which when pressed should show the frame's bad cert.
BUG=2853
Review URL: http://codereview.chromium.org/7276
------------------------------------------------------------------------
r11177 | markus@chromium.org | 2009-03-07 01:07:04 +0100 (Sat, 07 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc

Enable interstitial pages for SSL certificate errors on Linux.

There are still problems with this patch, as acknowledging the interstitial page often fails to load a new page. Instead, it just displays a blank gray page. This appears to be somewhat timing related.

Nonetheless, this changelist is strictly an improvement over what we have right now. So, I would still like to commit it.

Ideally, I'd like to remove the special-case Windows code. But I don't have a Windows machine to check whether the new code is actually a full superset of the old Windows code.
Review URL: http://codereview.chromium.org/40095
------------------------------------------------------------------------
r11174 | tc@google.com | 2009-03-07 00:20:14 +0100 (Sat, 07 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable the character encoding menu, zoom menu, and the help menu item.

The character encoding menu is still broken in that it doesn't load the
encoding names (sub-menu items), but auto detect might work.

Review URL: http://codereview.chromium.org/39286

------------------------------------------------------------------------
r11169 | mpcomplete@google.com | 2009-03-06 23:40:40 +0100 (Fri, 06 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc

Fix build break.

TBR=aa
Review URL: http://codereview.chromium.org/39283
------------------------------------------------------------------------
r11167 | mpcomplete@google.com | 2009-03-06 23:29:19 +0100 (Fri, 06 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix Purify UMR and MLK due to ExtensionViewTest:
- UMR was caused by stubbing out GetHistoryListCount, which RenderViewHost
  expected to initialize its out params.
- MLK was (I think) caused by the IPC reply message to the javascript alert
  never getting freed.

BUG=8364
Review URL: http://codereview.chromium.org/39157
------------------------------------------------------------------------
r11166 | erg@google.com | 2009-03-06 23:12:34 +0100 (Fri, 06 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Implement accelerators in the gtk port (try 2).
- Adds accelerators to all the menu items that had them on windows.
- Adds accelerators to back (Alt+left), forward (Alt+right), reload
  (Ctr+R) and focus the URL box (Ctr+L).

Review URL: http://codereview.chromium.org/39278

------------------------------------------------------------------------
r11159 | amit@chromium.org | 2009-03-06 22:30:08 +0100 (Fri, 06 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Add url to AutomationMsg_DidNavigate 

Automation clients can now find out the url navigated to
instead of just index in the history.


Review URL: http://codereview.chromium.org/39205
------------------------------------------------------------------------
r11152 | erg@google.com | 2009-03-06 21:50:52 +0100 (Fri, 06 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/native_web_keyboard_event.h
   A /trunk/src/chrome/common/native_web_keyboard_event_linux.cc
   A /trunk/src/chrome/common/native_web_keyboard_event_mac.mm
   A /trunk/src/chrome/common/native_web_keyboard_event_win.cc
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_win.cc

RenderWidgetHost now only accepts a new NativeWebKeyboardEvent which owns a copy of the native os event.

Only the WebKeyboardEvent is sent over the IPC barrier, but the full structure passed to the unhandled key event handler.

BUG=4772

Review URL: http://codereview.chromium.org/40065

------------------------------------------------------------------------
r11146 | mark@chromium.org | 2009-03-06 21:13:23 +0100 (Fri, 06 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds a command line flag, --user-scripts-dir=..., to specify a directory to use
in place of the default user scripts location. This eases development of
userscripts since you can simply point the browser at your SCM checkout location
instead of needing to try to sync things into your local userscripts directory.

Code review URL: http://codereview.chromium.org/37011

Checking in for slightlyoff
------------------------------------------------------------------------
r11141 | jam@chromium.org | 2009-03-06 20:56:12 +0100 (Fri, 06 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h

Fix renderer hang that occurs when a RenderWidget with outstanding synchronous XHR requests is closed.  Currently we cancel all the pending URLRequestJobs, however at that point it doesn't have a pointer to get to the SyncResourceHandler object.

BUG=1575301
Review URL: http://codereview.chromium.org/39246
------------------------------------------------------------------------
r11132 | ben@chromium.org | 2009-03-06 20:19:05 +0100 (Fri, 06 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.h

Test to see if we can reduce some crashes by deferring delegate destruction until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit).

Review URL: http://codereview.chromium.org/40192
------------------------------------------------------------------------
r11109 | yurys@google.com | 2009-03-06 15:44:35 +0100 (Fri, 06 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/dev_tools_view.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

- Developer tools frontend is served from chrom-ui://devtools/tools.html

- Serve Web Inspector JS files from chrom-ui://devtools/ domain in addition to chrom-ui://inspector/. We cannot simply reuse "inspector" domain for now as we need different tab content types for console debugger and new developer tools front-end. When developer tools support all console debugger and web inspector features we will remove "inspector" domain from the source list.


Review URL: http://codereview.chromium.org/40222
------------------------------------------------------------------------
r11093 | jam@chromium.org | 2009-03-06 03:46:56 +0100 (Fri, 06 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Don't run unload tests that hang the renderer in single-process mode, since now the browser thread waits for the renderer thread on shutdown.

Review URL: http://codereview.chromium.org/39245
------------------------------------------------------------------------
r11092 | estade@chromium.org | 2009-03-06 03:45:46 +0100 (Fri, 06 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   A /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc (from /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc:11071)
   A /trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h (from /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h:11071)
   D /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   D /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Rename browser_toolbar_view_gtk.{h,cc} to browser_toolbar_gtk.{h,cc}

Review URL: http://codereview.chromium.org/39237
------------------------------------------------------------------------
r11074 | estade@chromium.org | 2009-03-06 01:59:22 +0100 (Fri, 06 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h

Create a dropdown menu for the GTK download shelf.

Review URL: http://codereview.chromium.org/39236
------------------------------------------------------------------------
r11073 | jam@chromium.org | 2009-03-06 01:58:43 +0100 (Fri, 06 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Redo my single process cleanup.  The problem was that Stop() had to be called in RendererMainThread's dtor, not Thread's, otherwise the vtable lookup won't use RendererMainThread's CleanUp function.
Review URL: http://codereview.chromium.org/40199
------------------------------------------------------------------------
r11068 | estade@chromium.org | 2009-03-06 01:43:44 +0100 (Fri, 06 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Refactor the download shelf context menu in preparation for porting.

* Delete DownloadDestinationContextMenu, which is not used anywhere.
* Delete the unused download menu item types from the ContextMenuCommands enum.
* Merge BaseContextMenu and DownloadShelfContextMenu, move them from download_util.{h,cc} to download_shelf.{h,cc}
* Take the windows-specific code from the new DownloadShelfContextMenu and put it in DownloadShelfContextMenuWin in download_item_view.cc (the only place it's used). DownloadShelfContextMenuWin extends DownloadShelfContextMenu and Menu::Delegate.

Review URL: http://codereview.chromium.org/40184
------------------------------------------------------------------------
r11063 | finnur@chromium.org | 2009-03-06 01:34:57 +0100 (Fri, 06 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Fixing two small regressions in the Find box:

1) If the Find textfield is populated when the Find box is shown, the FindPrevious and FindNext buttons should also be enabled. (issue 8369)

2) If you search for something that is not on the page, you get "0 of 0" in red. Press Esc and Ctrl+F and the label is gone but the red background color for the label remains (no bug on file, found during testing).

BUG=8369
TEST=Open about:blank in Chrome. Press Ctrl+F, search for 'e' (get 0 of 0), close the Find box, reopen the Find box. Observe 'e' is in box, it is highlighted and no red is visible. Also, FindPrevious and FindNext buttons should be enabled.
Review URL: http://codereview.chromium.org/39233
------------------------------------------------------------------------
r11058 | nsylvain@chromium.org | 2009-03-06 00:49:41 +0100 (Fri, 06 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Revert 11048 because it caused crashes in the ui_tests single process.


Review URL: http://codereview.chromium.org/39231
------------------------------------------------------------------------
r11056 | nsylvain@chromium.org | 2009-03-06 00:27:25 +0100 (Fri, 06 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/session_history_uitest.cc

Disable the session_history ui tests because it fails
too often. I filed bug 8444.

Review URL: http://codereview.chromium.org/39226
------------------------------------------------------------------------
r11050 | munjal@chromium.org | 2009-03-06 00:20:29 +0100 (Fri, 06 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a command-line disable-p13n and use that to disable
p13n related features.

Review URL: http://codereview.chromium.org/39029
------------------------------------------------------------------------
r11048 | jam@chromium.org | 2009-03-05 23:33:32 +0100 (Thu, 05 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Instead of destruction RendererMainThread objects via a singelton, which may make them get destructed after browser shutdown, make them a member variable of BrowserRenderProcessHost.

Review URL: http://codereview.chromium.org/39218
------------------------------------------------------------------------
r11041 | agl@chromium.org | 2009-03-05 22:40:11 +0100 (Thu, 05 Mar 2009) | 16 lines
Changed paths:
   M /trunk/src/base/file_descriptor_posix.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_process.cc

POSIX: Rewrite IPC's interaction with FileDescriptor

The FileDescriptor API is clearly too hard to use. It's the only IPC
data type which is non-POD and serialising an invalid file descriptor
is fatal to Chrome on POSIX. The use of Maybe is possibly non-obvious
to non-functional programmers.

This patch merges Maybe and FileDescriptor so that serialising invalid
file descriptors is permitted and results in -1 at the other end.
(Serialising /closed/ a file descriptor is still fatal.) Also, it adds
a pointer in base/file_descriptor.h to instructions for its use with
IPC. Although it's generally bad practice to mention IPC in base, in
this case I cannot find another suitable location.

Review URL: http://codereview.chromium.org/39208

------------------------------------------------------------------------
r11034 | jcampan@chromium.org | 2009-03-05 22:22:03 +0100 (Thu, 05 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

The new history and download tab caused a regression where opening the NTP would not focus the location bar.
DOM UI now by default focus the page.
The NTP one focus the location bar.

Also removed some unused fields from the history and download DOM UI.

BUG=8356
TEST=Open NTP, focus should be on location bar
Review URL: http://codereview.chromium.org/39173
------------------------------------------------------------------------
r11032 | maruel@google.com | 2009-03-05 22:07:27 +0100 (Thu, 05 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/base/icu_util.cc
   M /trunk/src/base/logging.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.h
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/session_startup_pref.h
   M /trunk/src/chrome/browser/sessions/session_backend_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/theme_helpers.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/classfactory.cc
   M /trunk/src/chrome/common/classfactory.h
   M /trunk/src/chrome/common/ipc_channel_win.cc
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_sync_channel.cc
   M /trunk/src/chrome/common/ipc_sync_channel.h
   M /trunk/src/chrome/common/ipc_sync_message.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.h

NO CODE CHANGE.

Split the lines >80 cols. (Part 1)
Review URL: http://codereview.chromium.org/39206
------------------------------------------------------------------------
r11030 | brettw@chromium.org | 2009-03-05 21:47:28 +0100 (Thu, 05 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h

Remove the chrome view contents tab contents type. Nobody uses it.
Review URL: http://codereview.chromium.org/39212
------------------------------------------------------------------------
r11029 | estade@chromium.org | 2009-03-05 21:36:31 +0100 (Thu, 05 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h

Several little style cleanups in GTK download shelf code.

Review URL: http://codereview.chromium.org/40174
------------------------------------------------------------------------
r11026 | brettw@chromium.org | 2009-03-05 21:18:07 +0100 (Thu, 05 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/js_before_unload_handler.h
   M /trunk/src/chrome/browser/js_before_unload_handler_win.cc
   M /trunk/src/chrome/browser/js_before_unload_handler_win.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Try #2 of "make JavaScript alerts reflect the URL of the frame they came from,
not the enclosing frame." The diffrence between this one and the previous version
of this patch is the addition of test_webview_delegate.

BUG=1686837
Review URL: http://codereview.chromium.org/39163
Review URL: http://codereview.chromium.org/40175
------------------------------------------------------------------------
r11024 | brettw@chromium.org | 2009-03-05 21:17:00 +0100 (Thu, 05 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Remove the TAB_CONTENTS_NEW_TAB_UI tab contents type. This was not actually used
now, so everytime this appears was dead code.
Review URL: http://codereview.chromium.org/39200
------------------------------------------------------------------------
r11022 | sidchat@google.com | 2009-03-05 21:11:36 +0100 (Thu, 05 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h

Fix the bug: Scrolling the Spell-checker drop-down box adds the languages scrolled. Basically, when a spell check language changes, it is added to the accept languages list so that it is remembered later. However, when the list gets scrolled, it keeps adding all the languages it scrolled. So, I decided to fix this by adding only the latest language selected as the spell check dictionary language in the drop down.

Issue=8374
Review URL: http://codereview.chromium.org/40145
------------------------------------------------------------------------
r11016 | mal@chromium.org | 2009-03-05 21:01:41 +0100 (Thu, 05 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Reduce the height of options on the Languages panel.

I changed two instances of kUnrelatedControlLargeVerticalSpacing to 
the shorter kUnrelatedControlVerticalSpacing. 

Tested on XP (Luna, no theme) and Vista Aero. 

BUG= 5511
R= ben
Review URL: http://codereview.chromium.org/40148
------------------------------------------------------------------------
r11008 | brettw@chromium.org | 2009-03-05 19:29:56 +0100 (Thu, 05 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/js_before_unload_handler.h
   M /trunk/src/chrome/browser/js_before_unload_handler_win.cc
   M /trunk/src/chrome/browser/js_before_unload_handler_win.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webview_delegate.h

Reverting 11002.
Review URL: http://codereview.chromium.org/39203
------------------------------------------------------------------------
r11002 | brettw@chromium.org | 2009-03-05 18:59:23 +0100 (Thu, 05 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view.cc
   M /trunk/src/chrome/browser/extensions/extension_view.h
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/js_before_unload_handler.h
   M /trunk/src/chrome/browser/js_before_unload_handler_win.cc
   M /trunk/src/chrome/browser/js_before_unload_handler_win.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webview_delegate.h

Make JavaScript alerts reflect the URL of the frame they came from, not the
enclosing frame.

BUG=1686837
Review URL: http://codereview.chromium.org/39163
------------------------------------------------------------------------
r10993 | sky@google.com | 2009-03-05 17:30:25 +0100 (Thu, 05 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc

Changes bookmark sorting to sort folders first.

BUG=8338
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/39175
------------------------------------------------------------------------
r10988 | nsylvain@chromium.org | 2009-03-05 16:38:46 +0100 (Thu, 05 Mar 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h

Revert change 10975 and 10972 because it broke the purify 
tests, and it might have caused a unit tests failure.

purify error :  UMR in URLRequest::response_data_file
failing test:
URLFetcherHeadersTest.Headers:
c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(222): error: Value of: source->response_headers()->GetNormalizedHeader("cache-control", &header)
  Actual: false
Expected: true
c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(223): error: Value of: header
  Actual: ""
Expected: "private"
c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(181): error: Value of: response_code
  Actual: 404
Expected: 200

Release only.

Review URL: http://codereview.chromium.org/39191
------------------------------------------------------------------------
r10986 | pinkerton@chromium.org | 2009-03-05 15:11:52 +0100 (Thu, 05 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Get history and download HTML UIs into Mac/Linux builds along with supporting icon scaffolding.
Review URL: http://codereview.chromium.org/39132
------------------------------------------------------------------------
r10982 | maruel@chromium.org | 2009-03-05 13:46:38 +0100 (Thu, 05 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/base/object_watcher_unittest.cc
   M /trunk/src/base/observer_list_threadsafe.h
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/time_win_unittest.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_exe_main.mm
   M /trunk/src/chrome/app/keystone_glue.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_win.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_win.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/cocoa/base_view.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/grow_box_view.h
   M /trunk/src/chrome/browser/cocoa/grow_box_view.m
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.mm
   M /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/command_updater.h
   M /trunk/src/chrome/browser/command_updater_unittest.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/debugger/debugger_host.h
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.h
   M /trunk/src/chrome/browser/debugger/debugger_io.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/debugger/dev_tools_view.cc
   M /trunk/src/chrome/browser/debugger/dev_tools_view.h
   M /trunk/src/chrome/browser/debugger/dev_tools_window.cc
   M /trunk/src/chrome/browser/debugger/dev_tools_window.h
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dev_tools_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dev_tools_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate.h
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   M /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.h
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_factory_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/history/history_publisher_none.cc
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_win.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/printing/page_number_unittest.cc
   M /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   M /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/repost_form_warning.h
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/test_web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service_win.cc
   M /trunk/src/chrome/browser/webdata/web_database_win.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   M /trunk/src/chrome/browser/worker_host/worker_process_host.h
   M /trunk/src/chrome/browser/worker_host/worker_service.cc
   M /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/common/bindings_policy.h
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/chrome_paths_mac.mm
   M /trunk/src/chrome/common/chrome_paths_win.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/gfx/chrome_font.h
   M /trunk/src/chrome/common/gfx/chrome_font_mac.mm
   M /trunk/src/chrome/common/gfx/text_elider.cc
   M /trunk/src/chrome/common/ipc_maybe.h
   M /trunk/src/chrome/common/ipc_sync_channel.cc
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/l10n_util.h
   M /trunk/src/chrome/common/l10n_util_win.cc
   M /trunk/src/chrome/common/l10n_util_win.h
   M /trunk/src/chrome/common/page_zoom.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/resource_bundle_mac.mm
   M /trunk/src/chrome/common/sandbox_init_wrapper.cc
   M /trunk/src/chrome/common/sandbox_init_wrapper.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/common/transport_dib.h
   M /trunk/src/chrome/common/transport_dib_linux.cc
   M /trunk/src/chrome/common/transport_dib_mac.cc
   M /trunk/src/chrome/common/transport_dib_win.cc
   M /trunk/src/chrome/common/worker_messages.h
   M /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h
   M /trunk/src/chrome/common/x11_util_internal.h
   M /trunk/src/chrome/installer/gcapi/gcapi.cc
   M /trunk/src/chrome/installer/gcapi/gcapi.h
   M /trunk/src/chrome/installer/gcapi/gcapi_test.cc
   M /trunk/src/chrome/installer/gcapi/resource.h
   M /trunk/src/chrome/installer/mini_installer/mini_installer.cc
   M /trunk/src/chrome/installer/setup/compat_checks_unittest.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/util/compat_checks.cc
   M /trunk/src/chrome/installer/util/compat_checks.h
   M /trunk/src/chrome/installer/util/compat_checks_unittest.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item.cc
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item.h
   M /trunk/src/chrome/installer/util/delete_reg_value_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/html_dialog.h
   M /trunk/src/chrome/installer/util/html_dialog_impl.cc
   M /trunk/src/chrome/installer/util/prebuild/create_string_rc.py
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/dev_tools_agent.cc
   M /trunk/src/chrome/renderer/dev_tools_agent.h
   M /trunk/src/chrome/renderer/dev_tools_client.cc
   M /trunk/src/chrome/renderer/dev_tools_client.h
   M /trunk/src/chrome/renderer/dev_tools_messages.h
   M /trunk/src/chrome/renderer/dev_tools_messages_internal.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/extensions/greasemonkey_api_unittest.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/audio_renderer_impl.h
   M /trunk/src/chrome/renderer/media/data_source_impl.cc
   M /trunk/src/chrome/renderer/media/data_source_impl.h
   M /trunk/src/chrome/renderer/media/video_renderer_impl.cc
   M /trunk/src/chrome/renderer/media/video_renderer_impl.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.cc
   M /trunk/src/chrome/renderer/renderer_histogram_snapshots.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_linux.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/renderer/renderer_webkitclient_impl.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/renderer/webmediaplayer_delegate_impl.cc
   M /trunk/src/chrome/renderer/webmediaplayer_delegate_impl.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.cc
   M /trunk/src/chrome/renderer/webworker_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json
   M /trunk/src/chrome/test/data/pref_service/overlay.json
   M /trunk/src/chrome/test/data/pref_service/read.json
   M /trunk/src/chrome/test/data/safe_browsing/download_update.py
   M /trunk/src/chrome/test/debugger/debugger_unittests.py
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/interactive_ui/npapi_interactive_test.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/test_location_bar.h
   M /trunk/src/chrome/test/ui/npapi_test_helper.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cpp
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/v8_unit_test.cc
   M /trunk/src/chrome/test/v8_unit_test.h
   M /trunk/src/chrome/tools/automated_ui_test_tools/auto_ui_test_input_generator.py
   M /trunk/src/chrome/tools/build/win/create_installer_archive.py
   M /trunk/src/chrome/tools/build/win/dependencies.py
   M /trunk/src/chrome/tools/build/win/sln_deps.py
   M /trunk/src/chrome/tools/convert_dict/dic_reader.cc
   M /trunk/src/chrome/tools/extensions/chromium_extension.py
   M /trunk/src/chrome/tools/extract_actions.py
   M /trunk/src/chrome/tools/history-viz.py
   M /trunk/src/chrome/tools/test/smoketests.py
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/chrome/views/custom_frame_view.cc
   M /trunk/src/chrome/views/custom_frame_view.h
   M /trunk/src/chrome/views/dialog_client_view.h
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/grid_layout.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view.h
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/native_frame_view.cc
   M /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/root_view_gtk.cc
   M /trunk/src/chrome/views/root_view_win.cc
   M /trunk/src/chrome/views/single_split_view.cc
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/tree_model.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view_gtk.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/view_win.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.cc
   M /trunk/src/chrome/views/window_delegate.h
   M /trunk/src/chrome/worker/webworkerclient_proxy.cc
   M /trunk/src/chrome/worker/webworkerclient_proxy.h
   M /trunk/src/chrome/worker/worker_main.cc
   M /trunk/src/chrome/worker/worker_process.cc
   M /trunk/src/chrome/worker/worker_process.h
   M /trunk/src/chrome/worker/worker_thread.cc
   M /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/gears/site_scons/utils.py
   M /trunk/src/media/audio/linux/audio_manager_linux.cc
   M /trunk/src/media/audio/mac/audio_manager_mac.cc
   M /trunk/src/media/audio/win/audio_output_win.cc
   M /trunk/src/media/base/mock_filter_host.h
   M /trunk/src/media/base/mock_media_filters.h
   M /trunk/src/media/base/mock_pipeline.h
   M /trunk/src/media/base/synchronizer.cc
   M /trunk/src/media/base/synchronizer.h
   M /trunk/src/media/filters/audio_renderer_base.cc
   M /trunk/src/media/filters/audio_renderer_base.h
   M /trunk/src/media/filters/audio_renderer_impl.cc
   M /trunk/src/media/filters/audio_renderer_impl.h
   M /trunk/src/media/filters/file_data_source.cc
   M /trunk/src/media/filters/file_data_source.h
   M /trunk/src/media/filters/file_data_source_unittest.cc
   M /trunk/src/media/filters/null_audio_renderer.cc
   M /trunk/src/media/filters/null_audio_renderer.h
   M /trunk/src/media/filters/test_video_renderer.h
   M /trunk/src/media/filters/video_renderer_base.cc
   M /trunk/src/media/filters/video_renderer_base.h
   M /trunk/src/media/filters/video_renderer_unittest.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/effective_tld_names.cc
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/gzip_filter.cc
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/base/host_resolver_unittest.h
   M /trunk/src/net/base/listen_socket.cc
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/mime_sniffer_unittest.cc
   M /trunk/src/net/base/nss_memio.c
   M /trunk/src/net/base/nss_memio.h
   M /trunk/src/net/base/platform_mime_util_linux.cc
   M /trunk/src/net/base/sdch_filter.cc
   M /trunk/src/net/base/sdch_filter.h
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/base/ssl_client_socket_mac.cc
   M /trunk/src/net/base/ssl_client_socket_mac.h
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/tcp_pinger.h
   M /trunk/src/net/base/tcp_pinger_unittest.cc
   M /trunk/src/net/base/telnet_server.cc
   M /trunk/src/net/base/test_completion_callback_unittest.cc
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc
   M /trunk/src/net/disk_cache/disk_cache_test_util.cc
   M /trunk/src/net/disk_cache/entry_unittest.cc
   M /trunk/src/net/disk_cache/file.h
   M /trunk/src/net/disk_cache/stats_histogram.cc
   M /trunk/src/net/disk_cache/stats_histogram.h
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/ftp/ftp_network_layer.cc
   M /trunk/src/net/ftp/ftp_network_layer.h
   M /trunk/src/net/ftp/ftp_network_session.h
   M /trunk/src/net/ftp/ftp_network_transaction.cc
   M /trunk/src/net/ftp/ftp_network_transaction.h
   M /trunk/src/net/ftp/ftp_request_info.h
   M /trunk/src/net/ftp/ftp_response_info.h
   M /trunk/src/net/ftp/ftp_transaction.h
   M /trunk/src/net/ftp/ftp_transaction_factory.h
   M /trunk/src/net/http/http_auth.cc
   M /trunk/src/net/http/http_auth.h
   M /trunk/src/net/http/http_auth_cache.cc
   M /trunk/src/net/http/http_auth_handler.cc
   M /trunk/src/net/http/http_auth_handler.h
   M /trunk/src/net/http/http_auth_handler_basic.cc
   M /trunk/src/net/http/http_auth_handler_basic.h
   M /trunk/src/net/http/http_auth_handler_basic_unittest.cc
   M /trunk/src/net/http/http_auth_handler_digest.cc
   M /trunk/src/net/http/http_auth_handler_digest.h
   M /trunk/src/net/http/http_auth_handler_digest_unittest.cc
   M /trunk/src/net/http/http_auth_unittest.cc
   M /trunk/src/net/http/http_chunked_decoder.cc
   M /trunk/src/net/http/http_chunked_decoder.h
   M /trunk/src/net/http/http_response_headers.cc
   M /trunk/src/net/http/http_response_headers_unittest.cc
   M /trunk/src/net/http/http_util.h
   M /trunk/src/net/http/http_version.h
   M /trunk/src/net/http/md4.cc
   M /trunk/src/net/http/md4.h
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/proxy/proxy_config_service_win.cc
   M /trunk/src/net/proxy/proxy_resolver_mac.cc
   M /trunk/src/net/proxy/proxy_resolver_script.h
   M /trunk/src/net/proxy/proxy_resolver_v8.h
   M /trunk/src/net/proxy/proxy_resolver_v8_unittest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/proxy/proxy_server.cc
   M /trunk/src/net/proxy/proxy_server.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_manager.cc
   M /trunk/src/net/url_request/url_request_job_tracker.h
   M /trunk/src/sandbox/src/interception.cc
   M /trunk/src/sandbox/src/interception_unittest.cc
   M /trunk/src/sandbox/src/sandbox_nt_util.cc
   M /trunk/src/sandbox/src/unload_dll_test.cc
   M /trunk/src/sandbox/src/win2k_threadpool.cc
   M /trunk/src/testing/multiprocess_func_list.cc
   M /trunk/src/testing/multiprocess_func_list.h
   M /trunk/src/testing/platform_test.h
   M /trunk/src/tools/channel_changer/resource.h
   M /trunk/src/tools/code_coverage/coverage.py
   M /trunk/src/tools/code_coverage/process_coverage.py
   M /trunk/src/tools/data_pack/data_pack.py
   M /trunk/src/tools/data_pack/repack.py
   M /trunk/src/tools/data_pack/scons.py
   M /trunk/src/tools/grit/grit/clique.py
   M /trunk/src/tools/grit/grit/clique_unittest.py
   M /trunk/src/tools/grit/grit/extern/FP.py
   M /trunk/src/tools/grit/grit/extern/tclib.py
   M /trunk/src/tools/grit/grit/format/data_pack.py
   M /trunk/src/tools/grit/grit/format/data_pack_unittest.py
   M /trunk/src/tools/grit/grit/format/html_inline.py
   M /trunk/src/tools/grit/grit/format/interface.py
   M /trunk/src/tools/grit/grit/format/rc.py
   M /trunk/src/tools/grit/grit/format/rc_header.py
   M /trunk/src/tools/grit/grit/format/rc_header_unittest.py
   M /trunk/src/tools/grit/grit/format/rc_unittest.py
   M /trunk/src/tools/grit/grit/gather/admin_template.py
   M /trunk/src/tools/grit/grit/gather/admin_template_unittest.py
   M /trunk/src/tools/grit/grit/gather/interface.py
   M /trunk/src/tools/grit/grit/gather/muppet_strings.py
   M /trunk/src/tools/grit/grit/gather/muppet_strings_unittest.py
   M /trunk/src/tools/grit/grit/gather/rc.py
   M /trunk/src/tools/grit/grit/gather/rc_unittest.py
   M /trunk/src/tools/grit/grit/gather/regexp.py
   M /trunk/src/tools/grit/grit/gather/tr_html.py
   M /trunk/src/tools/grit/grit/gather/tr_html_unittest.py
   M /trunk/src/tools/grit/grit/gather/txt.py
   M /trunk/src/tools/grit/grit/grd_reader.py
   M /trunk/src/tools/grit/grit/grd_reader_unittest.py
   M /trunk/src/tools/grit/grit/grit_runner.py
   M /trunk/src/tools/grit/grit/grit_runner_unittest.py
   M /trunk/src/tools/grit/grit/node/base.py
   M /trunk/src/tools/grit/grit/node/base_unittest.py
   M /trunk/src/tools/grit/grit/node/custom/__init__.py
   M /trunk/src/tools/grit/grit/node/custom/filename.py
   M /trunk/src/tools/grit/grit/node/custom/filename_unittest.py
   M /trunk/src/tools/grit/grit/node/empty.py
   M /trunk/src/tools/grit/grit/node/include.py
   M /trunk/src/tools/grit/grit/node/io.py
   M /trunk/src/tools/grit/grit/node/io_unittest.py
   M /trunk/src/tools/grit/grit/node/mapping.py
   M /trunk/src/tools/grit/grit/node/message.py
   M /trunk/src/tools/grit/grit/node/message_unittest.py
   M /trunk/src/tools/grit/grit/node/misc.py
   M /trunk/src/tools/grit/grit/node/misc_unittest.py
   M /trunk/src/tools/grit/grit/node/structure.py
   M /trunk/src/tools/grit/grit/node/structure_unittest.py
   M /trunk/src/tools/grit/grit/node/variant.py
   M /trunk/src/tools/grit/grit/pseudo.py
   M /trunk/src/tools/grit/grit/pseudo_unittest.py
   M /trunk/src/tools/grit/grit/shortcuts.py
   M /trunk/src/tools/grit/grit/shortcuts_unittests.py
   M /trunk/src/tools/grit/grit/tclib.py
   M /trunk/src/tools/grit/grit/tclib_unittest.py
   M /trunk/src/tools/grit/grit/test_suite_all.py
   M /trunk/src/tools/grit/grit/tool/build.py
   M /trunk/src/tools/grit/grit/tool/count.py
   M /trunk/src/tools/grit/grit/tool/diff_structures.py
   M /trunk/src/tools/grit/grit/tool/interface.py
   M /trunk/src/tools/grit/grit/tool/menu_from_parts.py
   M /trunk/src/tools/grit/grit/tool/newgrd.py
   M /trunk/src/tools/grit/grit/tool/postprocess_interface.py
   M /trunk/src/tools/grit/grit/tool/postprocess_unittest.py
   M /trunk/src/tools/grit/grit/tool/preprocess_interface.py
   M /trunk/src/tools/grit/grit/tool/preprocess_unittest.py
   M /trunk/src/tools/grit/grit/tool/rc2grd.py
   M /trunk/src/tools/grit/grit/tool/rc2grd_unittest.py
   M /trunk/src/tools/grit/grit/tool/resize.py
   M /trunk/src/tools/grit/grit/tool/test.py
   M /trunk/src/tools/grit/grit/tool/toolbar_postprocess.py
   M /trunk/src/tools/grit/grit/tool/toolbar_preprocess.py
   M /trunk/src/tools/grit/grit/tool/transl2tc.py
   M /trunk/src/tools/grit/grit/tool/transl2tc_unittest.py
   M /trunk/src/tools/grit/grit/tool/unit.py
   M /trunk/src/tools/grit/grit/util.py
   M /trunk/src/tools/grit/grit/util_unittest.py
   M /trunk/src/tools/grit/grit/xtb_reader.py
   M /trunk/src/tools/grit/grit/xtb_reader_unittest.py
   M /trunk/src/tools/gtk_clipboard_dump/gtk_clipboard_dump.cc
   M /trunk/src/tools/measure_page_load_time/ie_bho/MeasurePageLoadTime.cpp
   M /trunk/src/tools/measure_page_load_time/ie_bho/MeasurePageLoadTimeBHO.cpp
   M /trunk/src/tools/measure_page_load_time/ie_bho/MeasurePageLoadTimeBHO.h
   M /trunk/src/tools/measure_page_load_time/ie_bho/resource.h
   M /trunk/src/tools/measure_page_load_time/ie_bho/stdafx.h
   M /trunk/src/tools/memory_watcher/call_stack.cc
   M /trunk/src/tools/memory_watcher/ia32_modrm_map.cc
   M /trunk/src/tools/memory_watcher/ia32_opcode_map.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.h
   M /trunk/src/tools/memory_watcher/mini_disassembler.cc
   M /trunk/src/tools/memory_watcher/mini_disassembler.h
   M /trunk/src/tools/memory_watcher/mini_disassembler_types.h
   M /trunk/src/tools/memory_watcher/preamble_patcher.cc
   M /trunk/src/tools/memory_watcher/preamble_patcher.h
   M /trunk/src/tools/memory_watcher/preamble_patcher_with_stub.cc
   M /trunk/src/tools/purify/chrome_tests.py
   M /trunk/src/tools/purify/common.py
   M /trunk/src/tools/purify/purify_analyze.py
   M /trunk/src/tools/purify/purify_coverage.py
   M /trunk/src/tools/purify/purify_inuse.py
   M /trunk/src/tools/purify/purify_message.py
   M /trunk/src/tools/purify/purify_test.py
   M /trunk/src/tools/purify/quantify_test.py
   M /trunk/src/tools/python/google/httpd_utils.py
   M /trunk/src/tools/python/google/logging_utils.py
   M /trunk/src/tools/python/google/path_utils.py
   M /trunk/src/tools/python/google/platform_utils_win.py
   M /trunk/src/tools/site_compare/command_line.py
   M /trunk/src/tools/site_compare/commands/compare2.py
   M /trunk/src/tools/site_compare/commands/maskmaker.py
   M /trunk/src/tools/site_compare/commands/measure.py
   M /trunk/src/tools/site_compare/commands/scrape.py
   M /trunk/src/tools/site_compare/commands/timeload.py
   M /trunk/src/tools/site_compare/drivers/__init__.py
   M /trunk/src/tools/site_compare/drivers/win32/keyboard.py
   M /trunk/src/tools/site_compare/drivers/win32/mouse.py
   M /trunk/src/tools/site_compare/drivers/win32/windowing.py
   M /trunk/src/tools/site_compare/operators/__init__.py
   M /trunk/src/tools/site_compare/operators/equals.py
   M /trunk/src/tools/site_compare/operators/equals_with_mask.py
   M /trunk/src/tools/site_compare/scrapers/__init__.py
   M /trunk/src/tools/site_compare/scrapers/chrome/__init__.py
   M /trunk/src/tools/site_compare/scrapers/chrome/chrome011010.py
   M /trunk/src/tools/site_compare/scrapers/chrome/chrome01970.py
   M /trunk/src/tools/site_compare/scrapers/chrome/chromebase.py
   M /trunk/src/tools/site_compare/scrapers/firefox/__init__.py
   M /trunk/src/tools/site_compare/scrapers/firefox/firefox2.py
   M /trunk/src/tools/site_compare/scrapers/ie/__init__.py
   M /trunk/src/tools/site_compare/scrapers/ie/ie7.py
   M /trunk/src/tools/site_compare/site_compare.py
   M /trunk/src/tools/site_compare/utils/browser_iterate.py
   M /trunk/src/tools/traceline/svgui/startup-release.json
   M /trunk/src/tools/traceline/traceline/assembler.h
   M /trunk/src/tools/traceline/traceline/assembler_unittest.cc
   M /trunk/src/tools/traceline/traceline/logging.h
   M /trunk/src/tools/traceline/traceline/main.cc
   M /trunk/src/tools/traceline/traceline/rdtsc.h
   M /trunk/src/tools/traceline/traceline/scripts/alloc.py
   M /trunk/src/tools/traceline/traceline/scripts/crit_sec.py
   M /trunk/src/tools/traceline/traceline/scripts/filter_short.py
   M /trunk/src/tools/traceline/traceline/scripts/scstats.py
   M /trunk/src/tools/traceline/traceline/scripts/syscalls.py
   M /trunk/src/tools/traceline/traceline/sidestep/ia32_modrm_map.cc
   M /trunk/src/tools/traceline/traceline/sidestep/ia32_opcode_map.cc
   M /trunk/src/tools/traceline/traceline/sidestep/mini_disassembler.cc
   M /trunk/src/tools/traceline/traceline/sidestep/mini_disassembler.h
   M /trunk/src/tools/traceline/traceline/sidestep/mini_disassembler_types.h
   M /trunk/src/tools/traceline/traceline/sym_resolver.h
   M /trunk/src/tools/traceline/traceline/syscall_map.h
   M /trunk/src/tools/valgrind/chrome_tests.py
   M /trunk/src/tools/valgrind/valgrind_analyze.py
   M /trunk/src/tools/valgrind/valgrind_test.py
   M /trunk/src/tools/xcodebodge/xcodebodge.py
   M /trunk/src/webkit/activex_shim/activex_plugin.h
   M /trunk/src/webkit/activex_shim/activex_shared.cc
   M /trunk/src/webkit/activex_shim/activex_util.cc
   M /trunk/src/webkit/activex_shim/web_activex_site.h
   M /trunk/src/webkit/build/JavaScriptCore/pthread.h
   M /trunk/src/webkit/build/precompiled_webkit.cc
   M /trunk/src/webkit/build/precompiled_webkit_c.c
   M /trunk/src/webkit/build/webkit_version.py
   M /trunk/src/webkit/default_plugin/default_plugin_resources.h
   M /trunk/src/webkit/default_plugin/install_dialog.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.h
   M /trunk/src/webkit/default_plugin/plugin_impl.h
   M /trunk/src/webkit/default_plugin/plugin_impl_mac.h
   M /trunk/src/webkit/glue/alt_404_page_resource_fetcher.cc
   M /trunk/src/webkit/glue/autofill_form.cc
   M /trunk/src/webkit/glue/autofill_form.h
   M /trunk/src/webkit/glue/back_forward_list_client_impl.cc
   M /trunk/src/webkit/glue/back_forward_list_client_impl.h
   M /trunk/src/webkit/glue/cache_manager.cc
   M /trunk/src/webkit/glue/clipboard_conversion.cc
   M /trunk/src/webkit/glue/clipboard_conversion.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/cpp_binding_example.cc
   M /trunk/src/webkit/glue/cpp_binding_example.h
   M /trunk/src/webkit/glue/cpp_bound_class_unittest.cc
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/cpp_variant.h
   M /trunk/src/webkit/glue/cpp_variant_unittest.cc
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/dragclient_impl.cc
   M /trunk/src/webkit/glue/dragclient_impl.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.h
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/localized_strings.cc
   M /trunk/src/webkit/glue/media_player_private_impl.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.cc
   M /trunk/src/webkit/glue/multipart_response_delegate_unittest.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener_unittest.cc
   M /trunk/src/webkit/glue/password_form.h
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_linux.cc
   M /trunk/src/webkit/glue/plugins/plugin_stream_posix.cc
   M /trunk/src/webkit/glue/plugins/plugin_stream_win.cc
   M /trunk/src/webkit/glue/plugins/plugin_stubs.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.cc
   M /trunk/src/webkit/glue/regular_expression_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher.cc
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/scoped_clipboard_writer_glue.h
   M /trunk/src/webkit/glue/screen_info.h
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/stacking_order_iterator.cc
   M /trunk/src/webkit/glue/stacking_order_iterator.h
   M /trunk/src/webkit/glue/webcursor_gtk.cc
   M /trunk/src/webkit/glue/webcursor_gtk_data.h
   M /trunk/src/webkit/glue/webcursor_mac.mm
   M /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/glue/webdatasource.h
   M /trunk/src/webkit/glue/webdatasource_impl.cc
   M /trunk/src/webkit/glue/webdatasource_impl.h
   M /trunk/src/webkit/glue/webdocumentloader_impl.cc
   M /trunk/src/webkit/glue/webdocumentloader_impl.h
   M /trunk/src/webkit/glue/webdropdata.h
   M /trunk/src/webkit/glue/weberror_impl.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webhistoryitem_impl.cc
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue_gtk.cc
   M /trunk/src/webkit/glue/webkit_glue_mac.mm
   M /trunk/src/webkit/glue/webkit_glue_win.cc
   M /trunk/src/webkit/glue/webmediaplayer.h
   M /trunk/src/webkit/glue/webmediaplayer_delegate.h
   M /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/webresponse.h
   M /trunk/src/webkit/glue/webresponse_impl.h
   M /trunk/src/webkit/glue/weburlrequest_impl.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/glue/webworker.h
   M /trunk/src/webkit/glue/webworker_impl.cc
   M /trunk/src/webkit/glue/webworker_impl.h
   M /trunk/src/webkit/glue/webworkerclient.h
   M /trunk/src/webkit/glue/webworkerclient_impl.cc
   M /trunk/src/webkit/glue/webworkerclient_impl.h
   M /trunk/src/webkit/pending/AccessibleBase.cpp
   M /trunk/src/webkit/pending/AccessibleBase.h
   M /trunk/src/webkit/pending/AccessibleDocument.cpp
   M /trunk/src/webkit/pending/AccessibleDocument.h
   M /trunk/src/webkit/port/bindings/v8/JSDOMBinding.cpp
   M /trunk/src/webkit/port/bindings/v8/JSDOMBinding.h
   M /trunk/src/webkit/port/bindings/v8/JSXPathNSResolver.cpp
   M /trunk/src/webkit/port/bindings/v8/RGBColor.cpp
   M /trunk/src/webkit/port/bindings/v8/RGBColor.h
   M /trunk/src/webkit/port/bindings/v8/ScriptController.cpp
   M /trunk/src/webkit/port/bindings/v8/ScriptController.h
   M /trunk/src/webkit/port/bindings/v8/V8CanvasPixelArrayCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/V8MessagePortCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/V8SVGPODTypeWrapper.h
   M /trunk/src/webkit/port/bindings/v8/V8WorkerContextCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/V8WorkerCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/V8XMLHttpRequestCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/WorkerContextExecutionProxy.cpp
   M /trunk/src/webkit/port/bindings/v8/WorkerContextExecutionProxy.h
   M /trunk/src/webkit/port/bindings/v8/WorkerScriptController.cpp
   M /trunk/src/webkit/port/bindings/v8/WorkerScriptController.h
   M /trunk/src/webkit/port/bindings/v8/extensions/GCController.cpp
   M /trunk/src/webkit/port/bindings/v8/extensions/GCController.h
   M /trunk/src/webkit/port/bindings/v8/extensions/Gears.cpp
   M /trunk/src/webkit/port/bindings/v8/extensions/Interval.cpp
   M /trunk/src/webkit/port/bindings/v8/extensions/Interval.h
   M /trunk/src/webkit/port/bindings/v8/extensions/Playback.cpp
   M /trunk/src/webkit/port/bindings/v8/extensions/Playback.h
   M /trunk/src/webkit/port/bindings/v8/npruntime.cpp
   M /trunk/src/webkit/port/bindings/v8/npruntime_impl.h
   M /trunk/src/webkit/port/bindings/v8/npruntime_priv.h
   M /trunk/src/webkit/port/bindings/v8/v8_binding.h
   M /trunk/src/webkit/port/bindings/v8/v8_collection.h
   M /trunk/src/webkit/port/bindings/v8/v8_custom.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_custom.h
   M /trunk/src/webkit/port/bindings/v8/v8_events.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_events.h
   M /trunk/src/webkit/port/bindings/v8/v8_helpers.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_index.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_index.h
   M /trunk/src/webkit/port/bindings/v8/v8_nodefilter.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_np_utils.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_npobject.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.h
   M /trunk/src/webkit/tools/layout_tests/layout_package/compare_failures.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/compare_failures_unittest.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/path_utils.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/platform_utils_linux.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/platform_utils_mac.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/platform_utils_win.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/test_expectations.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/test_types_unittest.py
   M /trunk/src/webkit/tools/layout_tests/run_webkit_tests.py
   M /trunk/src/webkit/tools/layout_tests/test_types/fuzzy_image_diff.py
   M /trunk/src/webkit/tools/layout_tests/test_types/simplified_text_diff.py
   M /trunk/src/webkit/tools/layout_tests/test_types/test_type_base.py
   M /trunk/src/webkit/tools/merge/diff3-wrapper.py
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/PluginObject.cpp
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/PluginObject.h
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/TestObject.cpp
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/TestObject.h
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/main.cpp
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/resource.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/DumpRenderTreePasteboard.h
   M /trunk/src/webkit/tools/test_shell/mac/DumpRenderTreePasteboard.m
   M /trunk/src/webkit/tools/test_shell/mac/test_shell_webview.mm
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/resource.h
   M /trunk/src/webkit/tools/test_shell/run_all_tests.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/test_navigation_controller.cc
   M /trunk/src/webkit/tools/test_shell/test_navigation_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_platform_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_shell_platform_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_platform_delegate_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.h
   M /trunk/src/webkit/tools/test_shell/test_shell_webkit_init.h
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc
   M /trunk/src/webkit/tools/webcore_unit_tests/BMPImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/GKURL_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/TransparencyWin_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/UniscribeHelper_unittest.cpp
   M /trunk/src/webkit/tools/webcore_unit_tests/XBMImageDecoder_unittest.cpp

Fixes CRLF and trailing white spaces.
------------------------------------------------------------------------
r10978 | phajdan.jr@chromium.org | 2009-03-05 10:38:38 +0100 (Thu, 05 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/base/base.scons
   M /trunk/src/base/process_util_posix.cc
   A /trunk/src/base/test_file_util_posix.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/test/automation/automation.scons
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/startup/startup_tests.scons
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_tests.scons

Make startup_tests build and run on Linux (except reference tests).

Review URL: http://codereview.chromium.org/27240
------------------------------------------------------------------------
r10972 | hclam@chromium.org | 2009-03-05 07:38:52 +0100 (Thu, 05 Mar 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h

Highlights of changes:
1. Added entry to ResourceResponseHead so that it contains
   either a base::PlatformFile (OS_WIN) or
   base::FileDescriptor (OS_POSIX) for passing the file
   handle from browser to renderer process.
2. Also added IPC messages for reporting download progress
   and ACK message for it. ResourceLoaderBridge::Peer::OnDownloadProgress
   is added so that the peer is notified of the download
   progress in the renderer process.
3. Load flag to kick start the resource loading for media
   files. LOAD_MEDIA_RESOURCE is added so that
   ResourceDispatcherHost knows how to use a different
   ResourceHandler for handling media resource request.

Review URL: http://codereview.chromium.org/27168
------------------------------------------------------------------------
r10970 | hbono@chromium.org | 2009-03-05 04:41:51 +0100 (Thu, 05 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_icu.cc
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85 (Take 2)

This is the same change as "http://codereview.chromium.org/20219/show", which I reverted it because it caused build breaks on sandbox. To investigate this build break, it seems this build break is somehow caused by "base/string_util.cc" that includes the TrimWhiteSpaceUTF8() function. To fix this build break, I moved the TrimWhiteSpaceUTF8() function to "base/string_util_icu.cc".

BUG=7377
Review URL: http://codereview.chromium.org/28310
------------------------------------------------------------------------
r10969 | estade@chromium.org | 2009-03-05 04:28:22 +0100 (Thu, 05 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/browser/gtk/nine_box.h

Put the dropdown menu button on the linux download shelf.

Also set the background color.

Also extend NineBox a little bit.

Review URL: http://codereview.chromium.org/40139
------------------------------------------------------------------------
r10962 | ananta@chromium.org | 2009-03-05 03:09:41 +0100 (Thu, 05 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h

Fix a crash in chrome.exe caused by the external tab container instance getting destroyed without
going through the proper window shutdown sequence when the external host crashes.

The fix is to ensure that we clean up correctly when the external tab instance goes away. Will add a unit test in a subsequent CB.

Bug=1688967

Review URL: http://codereview.chromium.org/39086
------------------------------------------------------------------------
r10960 | ananta@chromium.org | 2009-03-05 03:07:18 +0100 (Thu, 05 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h

Ensure that we display a sad face for a windowed plugin when the plugin process crashes. This was a regression introduced by creating the plugin parent on the browser UI thread, which remains valid when the plugin process crashes.

The fix is to track plugin wrapper windows in the PluginProcessHost class and destroy any remaining windows in the destructor. Removed the DestroyWindowTask
which destroys the windows on the UI thread. We can achieve the same result by posting WM_CLOSE messages to these windows.

This fixes http://code.google.com/p/chromium/issues/detail?id=7673

Bug=7673

Review URL: http://codereview.chromium.org/40120
------------------------------------------------------------------------
r10956 | tc@google.com | 2009-03-05 02:35:05 +0100 (Thu, 05 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Replace a notimplemented with a bug about full screen mode.

Review URL: http://codereview.chromium.org/40142

------------------------------------------------------------------------
r10954 | evan@chromium.org | 2009-03-05 02:30:05 +0100 (Thu, 05 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc

Fix a toolbar width TODO.

Review URL: http://codereview.chromium.org/39168
------------------------------------------------------------------------
r10951 | shess@chromium.org | 2009-03-05 02:20:56 +0100 (Thu, 05 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/third_party/hunspell/copy_dictionary_files.rules
   M /trunk/src/chrome/third_party/hunspell/hunspell.gyp
   M /trunk/src/chrome/third_party/hunspell/hunspell.vcproj

Changes spellcheck_unittest to read dictionaries directly from the src tree.  Removes the build rules to copy test dictionaries to Dictionaries/.

Review URL: http://codereview.chromium.org/40082
Patch from rohitrao.
------------------------------------------------------------------------
r10944 | sky@google.com | 2009-03-05 01:27:37 +0100 (Thu, 05 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc

Fixes regression where bookmark manager would show black background
when not results are found for a search string. Using your halo
methods does the trick.

BUG=8367
TEST=see bug

Review URL: http://codereview.chromium.org/39165
------------------------------------------------------------------------
r10941 | brettw@chromium.org | 2009-03-05 00:55:06 +0100 (Thu, 05 Mar 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h

Clean up the browser about URL handler to not derive from WebContents. It is
instead integrated in the BrowserURLHandler for special schemes. This solves
a number of problems and cleans things up nicely.

Most of the functions were not necessary to have in the header file of the
browser about handler, so I made them local to the .cc file. I moved everything
around, but there was no change to any of the About...() functions.

This improves the about:memory page to not include the memory of the new tab
page it replaced. The entry for itself also has the proper title. This works
by using a meta refresh to the actual page, the the process transition no longer
happens at the same time as the about:memory page computation.

This also fixes problems with the about:network and about:ipc dialogs opening
blank pages and also re-opening the dialog when you close the browser.
Review URL: http://codereview.chromium.org/27238
------------------------------------------------------------------------
r10938 | cpu@google.com | 2009-03-05 00:42:53 +0100 (Thu, 05 Mar 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc

Some cleanup of backing_store_win.cc

- Fix a small leak (solved by re-selecting the initial bitmap into the dc at dtor time)
- Remove one set of GetDC(NULL) + GetDeviceCaps() + ReleaseDC()
- Remove some dead code

The removal of GetDC(NULL) might speed up Vista drawing a little bit, as is rummored that
this operation is expensive when DWM + Aero is enabled.

The integer overflow check is no longer possible. I'll file a bug so it is not lost.


TEST= existing test suffice

Review URL: http://codereview.chromium.org/21516
------------------------------------------------------------------------
r10937 | tc@google.com | 2009-03-05 00:36:05 +0100 (Thu, 05 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Take two at hooking up title bar on linux.

The only change from before is moving a method from a windows #ifdef
section to outside it.

TBR=evan

Review URL: http://codereview.chromium.org/39158

------------------------------------------------------------------------
r10935 | estade@chromium.org | 2009-03-05 00:24:47 +0100 (Thu, 05 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   A /trunk/src/chrome/browser/gtk/download_item_gtk.cc
   A /trunk/src/chrome/browser/gtk/download_item_gtk.h
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   M /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc

Add download items to the download shelf in linux.

Review URL: http://codereview.chromium.org/40136
------------------------------------------------------------------------
r10934 | brettw@chromium.org | 2009-03-04 23:57:01 +0100 (Wed, 04 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/drag_utils.h

Fix transparency for dragged downloads and links by using the halo text
routines. This also removes CreateDragImageForLink which is never called.
Review URL: http://codereview.chromium.org/39082
------------------------------------------------------------------------
r10929 | ben@chromium.org | 2009-03-04 23:23:07 +0100 (Wed, 04 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h
   M /trunk/src/chrome/views/window.cc

Revert r9953 since it caused regressions like: 
http://crbug.com/8287

Eyeballing the code in RootView, this change seems wrong.
Review URL: http://codereview.chromium.org/40124
------------------------------------------------------------------------
r10928 | ben@chromium.org | 2009-03-04 23:22:17 +0100 (Wed, 04 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/options_window_view.cc

Fix potential crash if the saved options tab is ever out of bounds.

http://crbug.com/8342

Review URL: http://codereview.chromium.org/40090
------------------------------------------------------------------------
r10927 | estade@chromium.org | 2009-03-04 23:19:41 +0100 (Wed, 04 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_shelf.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   A /trunk/src/chrome/browser/gtk/download_shelf_gtk.cc
   A /trunk/src/chrome/browser/gtk/download_shelf_gtk.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Basic download shelf implementation on linux.

It shows and hides at appropriate times, and that's about it.

TEST=navigate to a savable page and select "save page as" from the page menu. Click the x. Save the page again. The shelf should pop up, go away, pop up again.

Review URL: http://codereview.chromium.org/38004
------------------------------------------------------------------------
r10924 | tc@google.com | 2009-03-04 22:44:43 +0100 (Wed, 04 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Revert "Hook up the app title to the page title."
This reverts commit 10923.

Review URL: http://codereview.chromium.org/40130

------------------------------------------------------------------------
r10923 | tc@google.com | 2009-03-04 22:37:59 +0100 (Wed, 04 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Hook up the app title to the page title.

Review URL: http://codereview.chromium.org/39114

------------------------------------------------------------------------
r10918 | avi@chromium.org | 2009-03-04 22:04:04 +0100 (Wed, 04 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc

Fixing WebKeyboardEvent.

Review URL: http://codereview.chromium.org/39075
------------------------------------------------------------------------
r10913 | erikkay@google.com | 2009-03-04 21:27:04 +0100 (Wed, 04 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/base/version.h
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/common/resource_bundle.cc
   M /trunk/src/chrome/common/resource_bundle.h

Add trivial theming support in extensions.
NOTE: This is not final API.  It *will* change.  It's purely for testing purposes.
Review URL: http://codereview.chromium.org/40042
------------------------------------------------------------------------
r10907 | ben@chromium.org | 2009-03-04 20:43:35 +0100 (Wed, 04 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Fix another regression. Coordinate calculation in the OpaqueBrowserFrameView::HitTest method was wrong.

http://crbug.com/8365

Review URL: http://codereview.chromium.org/37008
------------------------------------------------------------------------
r10903 | evan@chromium.org | 2009-03-04 20:00:43 +0100 (Wed, 04 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc

Register SSLManager preferences on linux and mac.

This should fix the following error:
FATAL:common/pref_service.cc(314)] Check failed: false. Trying to read an unregistered pref: security.mixed_content_filtering

Review URL: http://codereview.chromium.org/39006
------------------------------------------------------------------------
r10896 | pkasting@chromium.org | 2009-03-04 19:22:07 +0100 (Wed, 04 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc

Reland r10674, which got lost during Ben's reorg of the frame code.

I guess CalculateWindowSizeForClientSize() disappeared in that reorg?  That's the one part of the old change I can't find where to put.

BUG=8151
Review URL: http://codereview.chromium.org/39074
------------------------------------------------------------------------
r10891 | glen@chromium.org | 2009-03-04 17:48:17 +0100 (Wed, 04 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc

Fix crasher in InitCurrentUI.
Also fix a leak while I'm here.

TBR=brettw

Review URL: http://codereview.chromium.org/40112
------------------------------------------------------------------------
r10889 | deanm@chromium.org | 2009-03-04 17:43:56 +0100 (Wed, 04 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Try to fix a Purify UMR error.  This isn't great, but it's better than nothing.

BUG=8314

Review URL: http://codereview.chromium.org/39125
------------------------------------------------------------------------
r10885 | aa@chromium.org | 2009-03-04 09:02:51 +0100 (Wed, 04 Mar 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Also fixes a bug where an externally installed
extension was loaded twice the first run after
installation.

I still ExtensionServiceBackend is begging to be split apart into individual tasks, this was just a quick spruce-up while I was in the file.

The main things I changed are:

* Moved extension_path_ from a member back into parameters where relevant. This just didn't feel right as state to me. It isn't relevant to all the methods the way alert_on_error_ and frontend_ are. This created the majority of the noise in the change, but is the least important.

* Renamed OnExtensionsLoadedFromDirectory to OnExtensionsLoaded since it is called in response to LoadExtension() too.

* Made install_directory_ be a parameter to backend's constructor instead of passed into each appropriate method. Again, this felt more appropriate because the install directory is relevant to the whole object.

* Hoisted checking for uninstalled external extensions up out of LoadExtension() into LoadExtensionsFromInstallDirectory(). It wasn't doing any harm in LoadExtension(), but it didn't seem relevant to other places where LoadExtension() is used (for example --load-extension and --install-extension).

* Hoisted installation success notification up out of InstallOrUpdateExtension() into InstallExtension(). This prevented having to pass around a be_noisy argument since InstallExtension() is only used for handling --install-extension, and InstallOrUpdateExtension() is just the private impl.

Review URL: http://codereview.chromium.org/40002
------------------------------------------------------------------------
r10881 | aa@chromium.org | 2009-03-04 08:21:43 +0100 (Wed, 04 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.cc
   M /trunk/src/chrome/browser/extensions/extension_error_reporter.h

Fix bone-headed bug where ExtensionErrorReporter
gets deleted after first message is sent from a
background thread.

Review URL: http://codereview.chromium.org/39034
------------------------------------------------------------------------
r10878 | brettw@chromium.org | 2009-03-04 07:53:20 +0100 (Wed, 04 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc

Fix the Linux build
------------------------------------------------------------------------
r10877 | brettw@chromium.org | 2009-03-04 07:50:21 +0100 (Wed, 04 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc

Fix stupid typo causing the navigation entry unit tests to fail.
Review URL: http://codereview.chromium.org/39117
------------------------------------------------------------------------
r10876 | brettw@chromium.org | 2009-03-04 07:34:37 +0100 (Wed, 04 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

Fix 16/wide build bustange on non-Windows.
Review URL: http://codereview.chromium.org/39116
------------------------------------------------------------------------
r10875 | brettw@chromium.org | 2009-03-04 07:13:02 +0100 (Wed, 04 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Fix the build with some forgotten string conversions on non-Windows.
Review URL: http://codereview.chromium.org/40099
------------------------------------------------------------------------
r10873 | tc@google.com | 2009-03-04 06:37:01 +0100 (Wed, 04 Mar 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/views/view_unittest.cc

Take 2 at moving SupportsWindowFeature from BrowserView
to Browser.

Turns out the test regression was actually caused by r10806 which
removed an anonymous namespace causing the TestView class to collide
with the same class in render_widget_host_unittest.cc.

For now, fix by adding the TestView in the view unittest to the
anon namespace.  shess is going to try to re-add the namespace to
render_widget_host_unittest.cc too.

TBR=pkasting

Review URL: http://codereview.chromium.org/40058
------------------------------------------------------------------------
r10872 | brettw@chromium.org | 2009-03-04 06:29:27 +0100 (Wed, 04 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Convert NavigationEntry title to string16. TabContents::GetTitle no longer needs
to be virtual, either.

This also changes how the display URL is computed. Instead of doing it
preemptively, we now do so lazily. This allows us to do the URL formatting
correctly using the elider so that we can do IDN and unescaping.

I changed string_util's singleton functions. I was worried that other code
might make a singleton of string, which would give you this same value as a
non-const string. This would mean our empty strings might no longer be empty.
Review URL: http://codereview.chromium.org/39022
------------------------------------------------------------------------
r10865 | glen@chromium.org | 2009-03-04 05:07:41 +0100 (Wed, 04 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

Fix back button behavior for DOMUI contents (or at least make it as not-broken as before) - I forgot to add this line to the nav controller.

BUG=8212	


Review URL: http://codereview.chromium.org/40076
------------------------------------------------------------------------
r10864 | glen@chromium.org | 2009-03-04 05:07:34 +0100 (Wed, 04 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc

Show icons for exe files in download manager. Issue was that the paths were coming in with the wrong slash direction and escaping, which was OK for non-exes, but strangely bad for exes.

BUG=8327

Review URL: http://codereview.chromium.org/40068
------------------------------------------------------------------------
r10863 | glen@chromium.org | 2009-03-04 05:07:23 +0100 (Wed, 04 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/resources/downloads.html

* Make the download page focus the input field onload.* Fix spacing between controls (Pause/Cancel).* Help deblock download UI creation (timeout in downloads.html, kMaxDownloads in downloads_ui.cc)* Allow resume for paused downloads
BUG=8271,8270,8130,8330
Review URL: http://codereview.chromium.org/40047
------------------------------------------------------------------------
r10862 | glen@chromium.org | 2009-03-04 05:07:18 +0100 (Wed, 04 Mar 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Make New Tab Page work correctly in incognito mode (8294)

Add a workaround to force the New Tab Page title to 'New Tab' (8282)

Make DOMUI Pages get focus correctly (8271)

Please also sanity-check DOMUI/DOMUIContents integration.

BUG=8294,8282,8271


Review URL: http://codereview.chromium.org/39057
------------------------------------------------------------------------
r10860 | estade@chromium.org | 2009-03-04 04:36:36 +0100 (Wed, 04 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_mac.mm
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/pickle.cc
   M /trunk/src/base/pickle.h
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/base/scoped_clipboard_writer.h
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/simple_clipboard_impl.cc
   M /trunk/src/webkit/glue/webclipboard_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.h

Update clipboard classes to use string16 and FilePath instead of wstring.

Update callers as well.

This patch builds on a patch by mark.a.lindner@gmail.com which can be found at http://codereview.chromium.org/28294

Review URL: http://codereview.chromium.org/27370
------------------------------------------------------------------------
r10859 | robertshield@google.com | 2009-03-04 04:22:32 +0100 (Wed, 04 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/util.vcproj
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/test/data/pref_service/write.golden.json

Add a set of long-running metrics to Chrome that are sent up only at uninstall time via the uninstall survey page.These uninstall metrics are collected according to the same opt-in policy as the existing UMA code. They are stored along with other prefs in the browser's Local State file. At uninstall time, the Local State file is copied to a temporary location during the file deletion stage and then read to extract the uninstall metrics. If the user selected to have metrics reported, the uninstall metrics are then sent up to the uninstall survey page that is currently opened. 
Review URL: http://codereview.chromium.org/27092
------------------------------------------------------------------------
r10857 | ben@chromium.org | 2009-03-04 03:51:34 +0100 (Wed, 04 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h

Fix regression where the window caption buttons weren't clickable when maximized. This is because of the nonclient frameview/clientview hierarchy changes.

Make sure that the frame gets a chance to respond to GetViewForPoint before the client view if the client view does not visually overlap.

http://crbug.com/8312

Review URL: http://codereview.chromium.org/40062
------------------------------------------------------------------------
r10852 | jam@chromium.org | 2009-03-04 02:37:06 +0100 (Wed, 04 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Add comment regarding why single-process and in-process-plugins are disabled for Chrome Release builds.
Review URL: http://codereview.chromium.org/39046
------------------------------------------------------------------------
r10848 | pkasting@chromium.org | 2009-03-04 01:50:14 +0100 (Wed, 04 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc

Fix release-only build break.
------------------------------------------------------------------------
r10847 | jam@chromium.org | 2009-03-04 01:39:56 +0100 (Wed, 04 Mar 2009) | 8 lines
Changed paths:
   M /trunk/deps/third_party/WebKit/WebCore/workers/WorkerMessagingProxy.cpp
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   A /trunk/src/chrome/browser/worker_host
   A /trunk/src/chrome/browser/worker_host/worker_process_host.cc
   A /trunk/src/chrome/browser/worker_host/worker_process_host.h
   A /trunk/src/chrome/browser/worker_host/worker_service.cc
   A /trunk/src/chrome/browser/worker_host/worker_service.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/worker_messages.h
   A /trunk/src/chrome/common/worker_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/renderer/webworker_proxy.cc
   A /trunk/src/chrome/renderer/webworker_proxy.h
   A /trunk/src/chrome/worker
   A /trunk/src/chrome/worker/webworkerclient_proxy.cc
   A /trunk/src/chrome/worker/webworkerclient_proxy.h
   A /trunk/src/chrome/worker/worker.scons
   A /trunk/src/chrome/worker/worker.vcproj
   A /trunk/src/chrome/worker/worker_main.cc
   A /trunk/src/chrome/worker/worker_process.cc
   A /trunk/src/chrome/worker/worker_process.h
   A /trunk/src/chrome/worker/worker_thread.cc
   A /trunk/src/chrome/worker/worker_thread.h
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webview_delegate.h
   A /trunk/src/webkit/glue/webworker.h
   A /trunk/src/webkit/glue/webworker_impl.cc
   A /trunk/src/webkit/glue/webworker_impl.h
   A /trunk/src/webkit/glue/webworkerclient.h
   A /trunk/src/webkit/glue/webworkerclient_impl.cc
   A /trunk/src/webkit/glue/webworkerclient_impl.h

Initial checkin of the out of process worker implementation.

WebWorkerClient/WebWorker are parallel interfaces of WebCore::{WorkerObjectProxy, WorkerContextProxy} that use Chrome data types.  When WebKit requests a WorkerObjectProxy, we create an instance of WebWorkerClientImpl.  This class creates an object that implements a Chromium version of WorkerObjectProxy (i.e. with Chrome data types) through WebViewDelegate.  That object is a WebWorkerProxy and talks over IPC to a WebWorker object in the worker process.  The WebWorker object creates the actual WebCore::Worker object using another class in glue: WebWorkerImpl.

When the WebCore::Worker object running in the worker process wants to talk back to the code running in the renderer, it talks to WebWorkerImpl which implements WebCore::WorkerObjectProxy.  WebWorkerImpl converts the data types to Chrome compatible ones, and then calls the WebWorkerClient version which does IPC to get to the renderer process.  This ends up at WebWorkerProxy, which calls WebWorkerClientImpl (the original class).

In future changes, sandboxing, multiple worker processes etc will be added.  Note that I also had to make two small changes to WebKit, since WorkerMessagingProxy couldn't be created as is for the nested worker case.  I'll either check it in myself or work with Jian to do so.
Review URL: http://codereview.chromium.org/27157
------------------------------------------------------------------------
r10845 | pkasting@chromium.org | 2009-03-04 01:36:48 +0100 (Wed, 04 Mar 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc
   M /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/views/window.cc

Make Chromium windows not hide auto-hide taskbars.

There are a few caveats here:

* On Aero glass, if the auto-hide taskbar is at the top of the screen, we get one row of nonclient pixels along the bottom of the screen (not too noticeable for light-colored pages, looks a bit odd with a dark page).  I can't find a way around this.

* Switching between fullscreen and normal mode can leave things a bit confused until you click another app and then reactivate Chromium.  This seems to happen with other applications too (e.g. Firefox fullscreen mode) so I'm not too worried.

* Chromium does not deal well with toggling the taskbar's auto-hide setting (or, I think, its position?) unless you restore and remaximize the window.  I tried to fix this via modified handling of WM_SETTINGCHANGE but only made things worse and so gave up.

BUG=20
Review URL: http://codereview.chromium.org/28338
------------------------------------------------------------------------
r10844 | estade@chromium.org | 2009-03-04 01:05:25 +0100 (Wed, 04 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/test/data/pref_service/read.json
   M /trunk/src/chrome/test/data/pref_service/write.golden.json
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unit_tests.scons

Add FilePath setter/getter to pref service. Change callers to use it rather than the string methods.

Update the pref service unit test and enable it on linux.

Also switch over some wstrings to filepaths where appropriate.

BUG=8154
Review URL: http://codereview.chromium.org/27354
------------------------------------------------------------------------
r10837 | nsylvain@chromium.org | 2009-03-03 23:59:43 +0100 (Tue, 03 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_reader_unittest.cc
   M /trunk/src/base/json_writer.cc
   M /trunk/src/base/json_writer.h
   M /trunk/src/base/json_writer_unittest.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/render_view.cc

revert broken change 10833
------------------------------------------------------------------------
r10835 | jhawkins@chromium.org | 2009-03-03 23:09:04 +0100 (Tue, 03 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Remove an include of a header that was removed in r10832.

TBR=ben
Review URL: http://codereview.chromium.org/39069
------------------------------------------------------------------------
r10834 | jhawkins@chromium.org | 2009-03-03 23:01:12 +0100 (Tue, 03 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.gyp

Update browser.scons and chrome.gyp to match files removed in r10832.

TBR=ben
Review URL: http://codereview.chromium.org/39067
------------------------------------------------------------------------
r10833 | dsh@google.com | 2009-03-03 22:49:53 +0100 (Tue, 03 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_reader_unittest.cc
   M /trunk/src/base/json_writer.cc
   M /trunk/src/base/json_writer.h
   M /trunk/src/base/json_writer_unittest.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_ui.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/render_view.cc

Port DictionaryValue to use string16 instead of wstring.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10818
Review URL: http://codereview.chromium.org/31014
------------------------------------------------------------------------
r10832 | ben@chromium.org | 2009-03-03 22:49:29 +0100 (Tue, 03 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   D /trunk/src/chrome/browser/base_history_model.cc
   D /trunk/src/chrome/browser/base_history_model.h
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/history_model.cc
   D /trunk/src/chrome/browser/history_model.h
   D /trunk/src/chrome/browser/history_tab_ui.cc
   D /trunk/src/chrome/browser/history_tab_ui.h
   D /trunk/src/chrome/browser/history_view.cc
   D /trunk/src/chrome/browser/history_view.h
   D /trunk/src/chrome/browser/tab_contents/native_ui_contents.cc
   D /trunk/src/chrome/browser/tab_contents/native_ui_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   D /trunk/src/chrome/browser/views/download_tab_view.cc
   D /trunk/src/chrome/browser/views/download_tab_view.h

Remove NativeUI, HistoryTabUI, DownloadsTabUI since they've been superceded.

Review URL: http://codereview.chromium.org/39005
------------------------------------------------------------------------
r10830 | jhawkins@chromium.org | 2009-03-03 22:41:43 +0100 (Tue, 03 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Move RemoveTabAt to the TabStrip interface from RemoveTabAnimation.
* This change is needed to allow a clean refactoring of TabStrip.  The animation classes should be as cross-platform as possible.
* RemoveTabStrip animation now requests the TabStrip to remove a tab for it.
Review URL: http://codereview.chromium.org/27366
------------------------------------------------------------------------
r10827 | ericroman@google.com | 2009-03-03 22:37:09 +0100 (Tue, 03 Mar 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h

Add a command line flag --v8-proxy-resolver, to select the new PAC implementation.

When running in single process mode, this flag has no effect (since we can't run side by side with the renderer's V8).

In regular mode, the v8 resolver is currently running in the browser process.
This means it has to share with the v8 debugger shell.
Added locking around the debugger shell so they can peacefully co-exist.

When this flag is enabled, PAC scripts are downloaded through the browser.

BUG=74,2764

Review URL: http://codereview.chromium.org/27365
------------------------------------------------------------------------
r10821 | nsylvain@chromium.org | 2009-03-03 21:46:40 +0100 (Tue, 03 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_reader_unittest.cc
   M /trunk/src/base/json_writer.cc
   M /trunk/src/base/json_writer.h
   M /trunk/src/base/json_writer_unittest.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/render_view.cc

Revert dsh's change 10818
------------------------------------------------------------------------
r10820 | pinkerton@chromium.org | 2009-03-03 21:23:04 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/chrome.gyp
   D /trunk/src/chrome/common/chrome_paths_mac.cc
   A /trunk/src/chrome/common/chrome_paths_mac.mm (from /trunk/src/chrome/common/chrome_paths_mac.cc:10800)

Implement some chrome path getters for Mac OS and un-comment their uses in the download manager. Move chrome_paths_mac from a .cc to a .mm to allow Cocoa.
Review URL: http://codereview.chromium.org/39041
------------------------------------------------------------------------
r10818 | dsh@google.com | 2009-03-03 21:21:01 +0100 (Tue, 03 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_reader_unittest.cc
   M /trunk/src/base/json_writer.cc
   M /trunk/src/base/json_writer.h
   M /trunk/src/base/json_writer_unittest.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/render_view.cc

Port DictionaryValue to use string16 instead of wstring.

Review URL: http://codereview.chromium.org/31014
------------------------------------------------------------------------
r10814 | tc@google.com | 2009-03-03 20:51:33 +0100 (Tue, 03 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/locales/ar.vcproj
   M /trunk/src/chrome/app/locales/bg.vcproj
   M /trunk/src/chrome/app/locales/bn.vcproj
   M /trunk/src/chrome/app/locales/ca.vcproj
   M /trunk/src/chrome/app/locales/cs.vcproj
   M /trunk/src/chrome/app/locales/da.vcproj
   M /trunk/src/chrome/app/locales/de.vcproj
   M /trunk/src/chrome/app/locales/el.vcproj
   M /trunk/src/chrome/app/locales/en-GB.vcproj
   M /trunk/src/chrome/app/locales/en-US.vcproj
   M /trunk/src/chrome/app/locales/es-419.vcproj
   M /trunk/src/chrome/app/locales/es.vcproj
   M /trunk/src/chrome/app/locales/et.vcproj
   M /trunk/src/chrome/app/locales/fi.vcproj
   M /trunk/src/chrome/app/locales/fil.vcproj
   M /trunk/src/chrome/app/locales/fr.vcproj
   M /trunk/src/chrome/app/locales/gu.vcproj
   M /trunk/src/chrome/app/locales/he.vcproj
   M /trunk/src/chrome/app/locales/hi.vcproj
   M /trunk/src/chrome/app/locales/hr.vcproj
   M /trunk/src/chrome/app/locales/hu.vcproj
   M /trunk/src/chrome/app/locales/id.vcproj
   M /trunk/src/chrome/app/locales/it.vcproj
   M /trunk/src/chrome/app/locales/ja.vcproj
   M /trunk/src/chrome/app/locales/kn.vcproj
   M /trunk/src/chrome/app/locales/ko.vcproj
   M /trunk/src/chrome/app/locales/lt.vcproj
   M /trunk/src/chrome/app/locales/lv.vcproj
   M /trunk/src/chrome/app/locales/ml.vcproj
   M /trunk/src/chrome/app/locales/mr.vcproj
   M /trunk/src/chrome/app/locales/nb.vcproj
   M /trunk/src/chrome/app/locales/nl.vcproj
   M /trunk/src/chrome/app/locales/or.vcproj
   M /trunk/src/chrome/app/locales/pl.vcproj
   M /trunk/src/chrome/app/locales/pt-BR.vcproj
   M /trunk/src/chrome/app/locales/pt-PT.vcproj
   M /trunk/src/chrome/app/locales/ro.vcproj
   M /trunk/src/chrome/app/locales/ru.vcproj
   M /trunk/src/chrome/app/locales/sk.vcproj
   M /trunk/src/chrome/app/locales/sl.vcproj
   M /trunk/src/chrome/app/locales/sr.vcproj
   M /trunk/src/chrome/app/locales/sv.vcproj
   M /trunk/src/chrome/app/locales/ta.vcproj
   M /trunk/src/chrome/app/locales/te.vcproj
   M /trunk/src/chrome/app/locales/th.vcproj
   M /trunk/src/chrome/app/locales/tr.vcproj
   M /trunk/src/chrome/app/locales/uk.vcproj
   M /trunk/src/chrome/app/locales/vi.vcproj
   M /trunk/src/chrome/app/locales/zh-CN.vcproj
   M /trunk/src/chrome/app/locales/zh-TW.vcproj
   M /trunk/src/chrome/app/resources/locale_settings.grd
   A /trunk/src/chrome/app/resources/locale_settings_ar.rc
   D /trunk/src/chrome/app/resources/locale_settings_ar.xtb
   A /trunk/src/chrome/app/resources/locale_settings_bg.rc
   D /trunk/src/chrome/app/resources/locale_settings_bg.xtb
   A /trunk/src/chrome/app/resources/locale_settings_bn.rc
   D /trunk/src/chrome/app/resources/locale_settings_bn.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ca.rc
   D /trunk/src/chrome/app/resources/locale_settings_ca.xtb
   A /trunk/src/chrome/app/resources/locale_settings_cs.rc
   D /trunk/src/chrome/app/resources/locale_settings_cs.xtb
   A /trunk/src/chrome/app/resources/locale_settings_da.rc
   D /trunk/src/chrome/app/resources/locale_settings_da.xtb
   A /trunk/src/chrome/app/resources/locale_settings_de.rc
   D /trunk/src/chrome/app/resources/locale_settings_de.xtb
   A /trunk/src/chrome/app/resources/locale_settings_el.rc
   D /trunk/src/chrome/app/resources/locale_settings_el.xtb
   A /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   D /trunk/src/chrome/app/resources/locale_settings_en-GB.xtb
   A /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   D /trunk/src/chrome/app/resources/locale_settings_en-US.xtb
   A /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   D /trunk/src/chrome/app/resources/locale_settings_es-419.xtb
   A /trunk/src/chrome/app/resources/locale_settings_es.rc
   D /trunk/src/chrome/app/resources/locale_settings_es.xtb
   A /trunk/src/chrome/app/resources/locale_settings_et.rc
   D /trunk/src/chrome/app/resources/locale_settings_et.xtb
   A /trunk/src/chrome/app/resources/locale_settings_fi.rc
   D /trunk/src/chrome/app/resources/locale_settings_fi.xtb
   A /trunk/src/chrome/app/resources/locale_settings_fil.rc
   D /trunk/src/chrome/app/resources/locale_settings_fil.xtb
   A /trunk/src/chrome/app/resources/locale_settings_fr.rc
   D /trunk/src/chrome/app/resources/locale_settings_fr.xtb
   A /trunk/src/chrome/app/resources/locale_settings_gu.rc
   D /trunk/src/chrome/app/resources/locale_settings_gu.xtb
   A /trunk/src/chrome/app/resources/locale_settings_he.rc
   D /trunk/src/chrome/app/resources/locale_settings_he.xtb
   A /trunk/src/chrome/app/resources/locale_settings_hi.rc
   D /trunk/src/chrome/app/resources/locale_settings_hi.xtb
   A /trunk/src/chrome/app/resources/locale_settings_hr.rc
   D /trunk/src/chrome/app/resources/locale_settings_hr.xtb
   A /trunk/src/chrome/app/resources/locale_settings_hu.rc
   D /trunk/src/chrome/app/resources/locale_settings_hu.xtb
   A /trunk/src/chrome/app/resources/locale_settings_id.rc
   D /trunk/src/chrome/app/resources/locale_settings_id.xtb
   A /trunk/src/chrome/app/resources/locale_settings_it.rc
   D /trunk/src/chrome/app/resources/locale_settings_it.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ja.rc
   D /trunk/src/chrome/app/resources/locale_settings_ja.xtb
   A /trunk/src/chrome/app/resources/locale_settings_kn.rc
   D /trunk/src/chrome/app/resources/locale_settings_kn.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ko.rc
   D /trunk/src/chrome/app/resources/locale_settings_ko.xtb
   A /trunk/src/chrome/app/resources/locale_settings_lt.rc
   D /trunk/src/chrome/app/resources/locale_settings_lt.xtb
   A /trunk/src/chrome/app/resources/locale_settings_lv.rc
   D /trunk/src/chrome/app/resources/locale_settings_lv.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ml.rc
   D /trunk/src/chrome/app/resources/locale_settings_ml.xtb
   A /trunk/src/chrome/app/resources/locale_settings_mr.rc
   D /trunk/src/chrome/app/resources/locale_settings_mr.xtb
   A /trunk/src/chrome/app/resources/locale_settings_nb.rc
   D /trunk/src/chrome/app/resources/locale_settings_nb.xtb
   A /trunk/src/chrome/app/resources/locale_settings_nl.rc
   D /trunk/src/chrome/app/resources/locale_settings_nl.xtb
   A /trunk/src/chrome/app/resources/locale_settings_or.rc
   D /trunk/src/chrome/app/resources/locale_settings_or.xtb
   A /trunk/src/chrome/app/resources/locale_settings_pl.rc
   D /trunk/src/chrome/app/resources/locale_settings_pl.xtb
   A /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   D /trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb
   A /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   D /trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ro.rc
   D /trunk/src/chrome/app/resources/locale_settings_ro.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ru.rc
   D /trunk/src/chrome/app/resources/locale_settings_ru.xtb
   A /trunk/src/chrome/app/resources/locale_settings_sk.rc
   D /trunk/src/chrome/app/resources/locale_settings_sk.xtb
   A /trunk/src/chrome/app/resources/locale_settings_sl.rc
   D /trunk/src/chrome/app/resources/locale_settings_sl.xtb
   A /trunk/src/chrome/app/resources/locale_settings_sr.rc
   D /trunk/src/chrome/app/resources/locale_settings_sr.xtb
   A /trunk/src/chrome/app/resources/locale_settings_sv.rc
   D /trunk/src/chrome/app/resources/locale_settings_sv.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ta.rc
   D /trunk/src/chrome/app/resources/locale_settings_ta.xtb
   A /trunk/src/chrome/app/resources/locale_settings_te.rc
   D /trunk/src/chrome/app/resources/locale_settings_te.xtb
   A /trunk/src/chrome/app/resources/locale_settings_th.rc
   D /trunk/src/chrome/app/resources/locale_settings_th.xtb
   A /trunk/src/chrome/app/resources/locale_settings_tr.rc
   D /trunk/src/chrome/app/resources/locale_settings_tr.xtb
   A /trunk/src/chrome/app/resources/locale_settings_uk.rc
   D /trunk/src/chrome/app/resources/locale_settings_uk.xtb
   A /trunk/src/chrome/app/resources/locale_settings_vi.rc
   D /trunk/src/chrome/app/resources/locale_settings_vi.xtb
   A /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   D /trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb
   A /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   D /trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/tools/grit/grit/node/message.py
   M /trunk/src/tools/grit/grit/tclib.py

Revert "Use grit to generate locale rc files and remove the old locale rc files from the tree."

Revert "window_ is null during BrowserWindow creation.  Assume full screen"

Revert "Move SupportsWindowFeature from BrowserView to Browser so"

------------------------------------------------------------------------
r10813 | avi@chromium.org | 2009-03-03 20:29:45 +0100 (Tue, 03 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unit_tests.scons

Enables bookmark_model_unittest on Mac and Linux.

Committed on behalf of rohitrao.

http://codereview.chromium.org/28299/show


------------------------------------------------------------------------
r10808 | avi@chromium.org | 2009-03-03 19:27:44 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   D /trunk/src/webkit/glue/webinputevent_util.cc
   D /trunk/src/webkit/glue/webinputevent_util.h
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc

Reverting 10794.
Review URL: http://codereview.chromium.org/40027
------------------------------------------------------------------------
r10807 | rafaelw@chromium.org | 2009-03-03 19:19:37 +0100 (Tue, 03 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/extensions.html

Removing CRLFs from extensions.html

Review URL: http://codereview.chromium.org/39025
------------------------------------------------------------------------
r10806 | shess@chromium.org | 2009-03-03 19:09:44 +0100 (Tue, 03 Mar 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/chrome.gyp

Ship some tests which aren't related to what I'm working on:
  RenderViewHostTest, RenderWidgetHostTest (added to gyp)
  RenderDnsMasterTest, DnsQueueTest (already in gyp)
  MetricsLogTest, MetricsResponseTest (already in gyp)

NOTE: Now that we're all-gyp-all-the-time, only the first couple tests are really being added.

Review URL: http://codereview.chromium.org/27297
------------------------------------------------------------------------
r10805 | tc@google.com | 2009-03-03 18:58:42 +0100 (Tue, 03 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

window_ is null during BrowserWindow creation.  Assume full screen
is false.

TBR=pkasting

Review URL: http://codereview.chromium.org/39023
------------------------------------------------------------------------
r10804 | tc@google.com | 2009-03-03 18:47:41 +0100 (Tue, 03 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Move SupportsWindowFeature from BrowserView to Browser so
we can share the code on all platforms.  I still left a
SupportsWindowFeature method in BrowserView that handles
fullscreen mode which is (for now) a Windows specific
feature.

Review URL: http://codereview.chromium.org/27372
------------------------------------------------------------------------
r10803 | sky@google.com | 2009-03-03 18:37:44 +0100 (Tue, 03 Mar 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes regression where escape was not removing a newly bookmarked
page.

BUG=none
TEST=press the star button on a page you haven't bookmarked. The star
  should light up. Press escape, the bubble should close and the
  bookmark should be removed. Repeat with an existing bookmark and
  make sure pressing escape doesn't remove the bookmark.

Review URL: http://codereview.chromium.org/40019
------------------------------------------------------------------------
r10800 | deanm@chromium.org | 2009-03-03 17:43:01 +0100 (Tue, 03 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/location_bar_view.h

Clean up a few comments / formatting related to the location bar.

Correct the includes, forward declare TabContents.

Review URL: http://codereview.chromium.org/39011
------------------------------------------------------------------------
r10799 | deanm@chromium.org | 2009-03-03 17:40:43 +0100 (Tue, 03 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Plumb GetLocationBar through to the toolbar.

The toolbar will own the LocationBarView, which implements the LocationBar interface.  Plumb the request for the LocationBar through from the browser window to the toolbar.

Review URL: http://codereview.chromium.org/40008

------------------------------------------------------------------------
r10797 | pinkerton@chromium.org | 2009-03-03 17:24:10 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove more ifdefs where all platforms now share the implementation.
Review URL: http://codereview.chromium.org/39017
------------------------------------------------------------------------
r10794 | avi@chromium.org | 2009-03-03 17:02:04 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   A /trunk/src/webkit/glue/webinputevent_util.cc
   A /trunk/src/webkit/glue/webinputevent_util.h
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.gyp
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc

Fixing WebKeyboardEvent. Third time's the charm.
Review URL: http://codereview.chromium.org/27332
------------------------------------------------------------------------
r10790 | pinkerton@chromium.org | 2009-03-03 15:26:54 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_view.cc

Remove some instances of NOTIMPLEMENTED in favor of hooking up functionality or filing a bug as a placeholder. Reduces noise at startup.
Review URL: http://codereview.chromium.org/27353
------------------------------------------------------------------------
r10789 | deanm@chromium.org | 2009-03-03 14:44:21 +0100 (Tue, 03 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.h
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.h

Fix some include guards in browser/gtk.

Review URL: http://codereview.chromium.org/39012
------------------------------------------------------------------------
r10788 | deanm@chromium.org | 2009-03-03 13:40:12 +0100 (Tue, 03 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/browser.scons

Cleanup the autocomplete model includes.  Move from a deprecated std::wstring to utf8 url fixer upper function.

These files should now compile on Linux.

Review URL: http://codereview.chromium.org/28323

------------------------------------------------------------------------
r10787 | jhawkins@chromium.org | 2009-03-03 07:43:17 +0100 (Tue, 03 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc

Fix a crash when installing plugins.
* Make sure the scoped_ptr is initialized before trying to open a file.
* Assign the result of FilePath::Append to download_file_path_.

R=ananta
BUG=8087
Review URL: http://codereview.chromium.org/28349
------------------------------------------------------------------------
r10783 | hbono@chromium.org | 2009-03-03 06:23:19 +0100 (Tue, 03 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/webkit/glue/webview_impl.cc

Make our IME backend platform-independent.
This change makes our IME backend run not only on Windows but also on Linux and Mac. This change also adds another unit-test which verifies the backend runs on Linux and Mac without problems.
Review URL: http://codereview.chromium.org/27124
------------------------------------------------------------------------
r10782 | glen@chromium.org | 2009-03-03 05:35:36 +0100 (Tue, 03 Mar 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Make history and downloads open once per window unless the user modifies their view.

Also fix the back dropdown so that it opens the DOMUI version of History rather than the NativeUI version.

BUG=8086,8297

Review URL: http://codereview.chromium.org/39002
------------------------------------------------------------------------
r10779 | ben@chromium.org | 2009-03-03 04:43:15 +0100 (Tue, 03 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_frame.cc

Fix a small issue changing back to glass frame from opaque where the
------------------------------------------------------------------------
r10777 | ben@chromium.org | 2009-03-03 03:59:12 +0100 (Tue, 03 Mar 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/views/window.cc

Make it so that dropdown selects don't deactivate the main frame when opened http://crbug.com/8247
------------------------------------------------------------------------
r10773 | glen@chromium.org | 2009-03-03 02:47:22 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/resources/history.html

Resolve crash when deleting history by preventing the deleter from being called multiple times. We need to add UI to make what's happening clearer to the user, but this gets us over the hump for now. Also change the history page to queue deletions.Allow history search from the new tab page.Make history title inclusion safer (createTextNode changes).Show starred status on history page.BUG=8214,8163,8271,8284 
Review URL: http://codereview.chromium.org/28308
------------------------------------------------------------------------
r10771 | jam@chromium.org | 2009-03-03 02:38:50 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_test_suite.h

Don't expose --single-process and --in-process-plugins for official Chrome releases.
Review URL: http://codereview.chromium.org/28347
------------------------------------------------------------------------
r10767 | dsh@google.com | 2009-03-03 02:21:09 +0100 (Tue, 03 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc

Port Replace(First)SubstringsAfterOffset to string16.

Review URL: http://codereview.chromium.org/28324
------------------------------------------------------------------------
r10761 | thestig@chromium.org | 2009-03-03 01:41:23 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/chrome_exe.vcproj
   M /trunk/src/chrome/app/chrome_exe_main.cc
   D /trunk/src/chrome/app/result_codes.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/common/process_watcher.cc
   A /trunk/src/chrome/common/result_codes.h (from /trunk/src/chrome/app/result_codes.h:10621)
   M /trunk/src/chrome/installer/setup/uninstall.cc

Move chrome/apps/result_codes.h to chrome/common/result_codes.h
Review URL: http://codereview.chromium.org/28279
------------------------------------------------------------------------
r10760 | ananta@chromium.org | 2009-03-03 01:39:17 +0100 (Tue, 03 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Register an onmessage handler with the external host binding instead of explicitly passing
in a target Javascript function to execute. The onmessage handler is a one argument Javascript
function for now.

Review URL: http://codereview.chromium.org/28291
------------------------------------------------------------------------
r10757 | ben@chromium.org | 2009-03-03 01:28:00 +0100 (Tue, 03 Mar 2009) | 34 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   D /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   D /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   D /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   D /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   A /trunk/src/chrome/browser/views/frame/browser_frame.cc (from /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc:10646)
   R /trunk/src/chrome/browser/views/frame/browser_frame.h (from /trunk/src/chrome/browser/views/frame/aero_glass_frame.h:10646)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   D /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   A /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc (from /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc:10646)
   A /trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h (from /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h:10646)
   A /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc (from /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc:10646)
   A /trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h (from /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h:10646)
   D /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   D /trunk/src/chrome/browser/views/frame/opaque_frame.h
   D /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   D /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   A /trunk/src/chrome/views/custom_frame_view.cc (from /trunk/src/chrome/views/default_non_client_view.cc:10646)
   A /trunk/src/chrome/views/custom_frame_view.h (from /trunk/src/chrome/views/default_non_client_view.h:10646)
   D /trunk/src/chrome/views/custom_frame_window.cc
   D /trunk/src/chrome/views/custom_frame_window.h
   D /trunk/src/chrome/views/default_non_client_view.cc
   D /trunk/src/chrome/views/default_non_client_view.h
   A /trunk/src/chrome/views/native_frame_view.cc
   A /trunk/src/chrome/views/native_frame_view.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/widget.h
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Support DWM switching.

This completes the collapsing of window types and browser frames around a single class: views::Window. CustomFrameWindow is removed with this change.

The Browser window is represented by a single views::Window subclass: BrowserFrame, which replaces both AeroGlassFrame and OpaqueFrame.

NonClientView is now a container of two sibling classes - the Window's ClientView (in the Browser's case, BrowserView), and a NonClientFrameView subclass, which provides the rendering for the non-client portions of the window. These Views are siblings rather than the ClientView a child of the NonClientFrameView because when the DWM is toggled, the ClientView would have to be re-parented. Many Views make the assumption they are only inserted into a View hierarchy once, and so this is problematic. By having the views be siblings, this is avoided.

With this in mind, all of the former NonClientViews now become NonClientFrameView subclasses:

DefaultNonClientView -> CustomFrameView
(non-existent, NonClientView) -> NativeFrameView
AeroGlassNonClientView -> GlassBrowserFrameView
OpaqueNonClientView -> OpaqueBrowserFrameView

The latter two derive from NonClientFrameView via BrowserNonClientFrameView, which adds some extras.

I also had to modify the TabRenderer class to know how to drop its cache of tab background images when the theme changes since it uses different ones for Glass and non-Glass.

This change also fixes a few non-client flicker issues relating to window non-client activation by using more ScopedRedrawLocks. (Touches info_bubble.cc, window.cc)

Bugs fixed:
http://crbug.com/153
http://crbug.com/747
http://crbug.com/2371
http://crbug.com/3264
http://crbug.com/8234
Plumbing for http://crbug.com/8247

Design docs:
http://dev.chromium.org/developers/design-documents/views-windowing
http://dev.chromium.org/developers/design-documents/browser-window

Review URL: http://codereview.chromium.org/27317
------------------------------------------------------------------------
r10754 | mark@chromium.org | 2009-03-03 01:22:22 +0100 (Tue, 03 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/third_party/hunspell/hunspell.gyp

Enable spellcheck_unittest.cc.
Review URL: http://codereview.chromium.org/28335
------------------------------------------------------------------------
r10751 | erg@google.com | 2009-03-03 01:21:40 +0100 (Tue, 03 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h

Fix crash introduced in r10563 where we modified a RenderWidgetHost after it had been deallocated.


Review URL: http://codereview.chromium.org/27363
------------------------------------------------------------------------
r10750 | mpcomplete@google.com | 2009-03-03 01:15:59 +0100 (Tue, 03 Mar 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix ExtensionViewTest and reenable it.

Also, normalize extension IDs to lower case when reading them in.  GURL
lower cases them when used as hostnames, so string comparisons need to be done
in lower case to work.
Review URL: http://codereview.chromium.org/28331
------------------------------------------------------------------------
r10745 | hclam@chromium.org | 2009-03-02 23:53:18 +0100 (Mon, 02 Mar 2009) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/disk_cache/entry_impl.cc
   M /trunk/src/net/disk_cache/entry_impl.h
   M /trunk/src/net/disk_cache/entry_unittest.cc
   M /trunk/src/net/disk_cache/mem_entry_impl.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/webkit/glue/resource_loader_bridge.h

Proposed change to support resource loading for media files.

Highlights of changes:
- Added methods to disk_cache::Entry:
  - Entry::PrepareTargetAsExternalFile(int index)
    Prepare a stream in an entry to use external file for storage.
  - Entry::GetExternalFile(int index)
    Get the external file backing the stream in the entry.
- Added a property "CacheType type_" to HttpCache, along with setter and getter.
  There shall be two cache types, COMMON_CACHE and MEDIA_CACHE for distinguishing between different purpose of HttpCache. We have this property to trigger special behavior for caching needs of media files.
- Added static methods to ChromeURLRequestContext
  - ChromeURLRequestContext::CreateOriginalForMedia
    Create a URLRequestContext for media files for the original profile.
  - ChromeURLRequestContext::CreateOffTheRecordForMedia
    Create a URLRequestContext for media files for off the record profile.
- Added method to Profile interface.
  - GetRequestContextForMedia
    To get the request context for media files from the context.

Design decissions:
- Enforce writing to external file by calling methods to Entry rather than construct Backend by a different flag.
  Since we only want a valid and full response to go into an external file rather than redirection response or erroneous response, we should let HttpCache::Transaction to decide when to have an external file for response data. We eliminate a lot of useless external cache files.
- Adding the CacheType enum and property to HttpCache, we could allow possible (?) future extensions to HttpCache to handle other different caching needs. And there's no need to add change constructors of HttpCache, but maybe we should add a specific constructor to accomodate a media HttpCache?
- Adding Profile::GetRequestContextForMedia()
  Since we will need to use this new request context in ResourceDispatcherHost, I think the best place to keep it is in the profile. Also we will expose to user that there's a separate cache for media, so it's better to expose it in the Profile level to allow settings to the media cache, e.g. max file size, etc.

Review URL: http://codereview.chromium.org/19747
------------------------------------------------------------------------
r10744 | ericroman@google.com | 2009-03-02 23:51:02 +0100 (Mon, 02 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc

Add file that got missing from main checkin.

TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/27357
------------------------------------------------------------------------
r10740 | thestig@chromium.org | 2009-03-02 23:40:58 +0100 (Mon, 02 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/base/string16.cc
   M /trunk/src/base/string16.h
   M /trunk/src/chrome/browser/password_manager/encryptor.cc
   M /trunk/src/chrome/browser/password_manager/encryptor.h
   M /trunk/src/chrome/browser/password_manager/encryptor_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Convert encryptor.cc and friends to string16.
Review URL: http://codereview.chromium.org/28292
------------------------------------------------------------------------
r10735 | glen@chromium.org | 2009-03-02 22:58:44 +0100 (Mon, 02 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc

Fix order of downloads list (HTH it happened, I don't know).

BUG=8283

Review URL: http://codereview.chromium.org/28328
------------------------------------------------------------------------
r10732 | brettw@chromium.org | 2009-03-02 22:49:12 +0100 (Mon, 02 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/common/gfx/chrome_canvas_win.cc
   M /trunk/src/chrome/views/border.cc
   M /trunk/src/chrome/views/border.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/default_non_client_view.cc
   M /trunk/src/chrome/views/default_non_client_view.h
   M /trunk/src/chrome/views/label_unittest.cc
   M /trunk/src/chrome/views/root_view_win.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/window.cc

Fix bookmark and menu drag images by making a halo around them. This makes
the ClearType composited on the correct color to fix the semitransparent pixels
into 1-bit transparency pixels.

Remove some unnecessary header file dependencies on ChromeCanvas I noticed
when compiling this patch.

BUG=8258
Review URL: http://codereview.chromium.org/27321
------------------------------------------------------------------------
r10726 | jhawkins@chromium.org | 2009-03-02 22:39:29 +0100 (Mon, 02 Mar 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/test/unit/unit_tests.scons

Add site_instance_unittest.cc to the Posix build.
Review URL: http://codereview.chromium.org/27299
------------------------------------------------------------------------
r10725 | estade@chromium.org | 2009-03-02 22:39:07 +0100 (Mon, 02 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable focus-change via tabbing on Linux.

Review URL: http://codereview.chromium.org/28248
------------------------------------------------------------------------
r10722 | maruel@chromium.org | 2009-03-02 21:57:53 +0100 (Mon, 02 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc

Fix a slight error in the atl includes. We are using the CRect class from WTL and not from ATL...

TBR=deanm
Review URL: http://codereview.chromium.org/28326
------------------------------------------------------------------------
r10721 | maruel@chromium.org | 2009-03-02 21:50:39 +0100 (Mon, 02 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/window_sizer.cc

Fix compilations errors introduced by revision 10712.

TBR=deanm
Review URL: http://codereview.chromium.org/27347
------------------------------------------------------------------------
r10715 | deanm@chromium.org | 2009-03-02 20:12:05 +0100 (Mon, 02 Mar 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Remove includes to the newly removed edit_drop_target.h header.

Review URL: http://codereview.chromium.org/28319
------------------------------------------------------------------------
r10712 | deanm@chromium.org | 2009-03-02 19:58:26 +0100 (Mon, 02 Mar 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc (from /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc:10707)
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   D /trunk/src/chrome/browser/autocomplete/edit_drop_target.cc
   D /trunk/src/chrome/browser/autocomplete/edit_drop_target.h
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Separate the AutocompleteEditView from the cross-platform code.

Separate the platform specific AutocompleteEditView from the cross-platform model and controller.  This leaves the model/controller in autocomplete_edit.{h,cc}, and moves the view into autocomplete_edit_view.h and autocomplete_edit_view_win.{h,cc}.

There is now an abstract interface (AutocompleteEditView) which the model uses to talk to the view.  Other views (for example, the LocationBarView) will still talk directly to the AutocompleteEditViewWin, which is the full Chrome view.

This change also pulled in the Windows specific edit_drop_target code into autocomplete_edit_view_win.cc.

Review URL: http://codereview.chromium.org/27327
------------------------------------------------------------------------
r10707 | deanm@chromium.org | 2009-03-02 18:56:29 +0100 (Mon, 02 Mar 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.gyp

Create the PopupView from the EditView, not the PopupModel.

It is hard to instantiate platform-specifc classes (like the AutocompletePopupView) from cross-platform classes (like the model).

This does what makes more sense, create platform specific instances from platform specific code.  The AutocompleteEditView now creates the AutocompletePopupView.  The AutocompletePopupView now creates the AutocompletePopupModel.

This also requires exposing AutocompletePopupViewWin, so that in the future the AutcompletePopupViewWin will be able to be created with an AutocompleteEditViewWin pointer.  This sort of reverts some of my previous changes, as is pulls the interface out of autocomplete_popup_view_win.cc and into autocomplete_popup_view_win.h.  This is sad but neccessary.

This removes the AutocompletePopupView::CreatePopupView factory, and replaces it by directly instantiating the platform-specific view instance.

Review URL: http://codereview.chromium.org/28313
------------------------------------------------------------------------
r10689 | glen@chromium.org | 2009-03-01 20:59:35 +0100 (Sun, 01 Mar 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Fix crash; dom_ui_ is destroyed by LoadURL.

BUG=8158

Review URL: http://codereview.chromium.org/27285
------------------------------------------------------------------------
r10683 | mal@chromium.org | 2009-03-01 00:03:42 +0100 (Sun, 01 Mar 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Fix the misspelling of GetLaunchShortcutKind().

TBR= cpu
Review URL: http://codereview.chromium.org/27314
------------------------------------------------------------------------
r10680 | jam@chromium.org | 2009-02-28 22:26:59 +0100 (Sat, 28 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Run the unload tests in single process mode, after my fix to single process mode.

BUG=7933
Review URL: http://codereview.chromium.org/27311
------------------------------------------------------------------------
r10679 | deanm@chromium.org | 2009-02-28 16:36:45 +0100 (Sat, 28 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h

Remove Windows ifdefs, all views will need to implement this method.

Review URL: http://codereview.chromium.org/27274
------------------------------------------------------------------------
r10676 | ananta@chromium.org | 2009-02-28 06:45:47 +0100 (Sat, 28 Feb 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Attempt 2 at landing this.

Don't call SetPriorityClass if CBSText.dll is loaded in the browser process. The
CBSText.dll loads as a global GetMessage hook into the browser process and
intercepts/unintercepts the kernel32 API SetPriorityClass in a background
thread. If the browser calls this API just
when it is intercepted the dlls interceptor proc messes up the stack while
returning back, which causes random crashes in the browser.

The hacky fix for now is to check for this dll and not invoke the API. We will
beautify this fix if it works in the wild.

This fixes http://code.google.com/p/chromium/issues/detail?id=6418

Bug=6418

Review URL: http://codereview.chromium.org/27298
------------------------------------------------------------------------
r10675 | rafaelw@chromium.org | 2009-02-28 03:26:30 +0100 (Sat, 28 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   A /trunk/src/chrome/browser/extensions/extensions_ui.cc
   A /trunk/src/chrome/browser/extensions/extensions_ui.h
   A /trunk/src/chrome/browser/resources/extensions.html
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Initial work on chrome-ui://extensions/ page. URL now displays a static template page

Review URL: http://codereview.chromium.org/28172
------------------------------------------------------------------------
r10674 | pkasting@chromium.org | 2009-02-28 03:20:05 +0100 (Sat, 28 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Fix system menu positioning in fullscreen mode to be at the upper left corner of the screen.

BUG=8151
Review URL: http://codereview.chromium.org/28247
------------------------------------------------------------------------
r10668 | jrg@chromium.org | 2009-02-28 02:41:26 +0100 (Sat, 28 Feb 2009) | 16 lines
Changed paths:
   A /trunk/src/chrome/app/keystone_glue.h
   A /trunk/src/chrome/app/keystone_glue.m (from /trunk/src/webkit/tools/test_shell/mac/KeystoneGlue.m:10495)
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Adapt (and move) mark@chromium.org's Keystone integration to Chromium.
Call it from the Browser.  (no-op if not packaged for branding).
Add new build target "app_packaging" to package (if possible).
(app_packaging target intentionally left out of "All").

For convenience, here is the app_packaging script embedded in the xcodeproj:

  PACKAGER="${PROJECT_DIR}/tools/mac/package_chrome.sh"
  if [ -f "${PACKAGER}" ]; then
    "${PACKAGER}"
  fi

Mark, I know this is not in gyp... I am happy to have this klobbered
and redo it (in gyp) at the appropriate time.

Review URL: http://codereview.chromium.org/27293
------------------------------------------------------------------------
r10666 | cpu@google.com | 2009-02-28 02:22:22 +0100 (Sat, 28 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

Wire chrome shortcuts tooltip (installation)
- Not complete since we are waiting for translations
- For chromium the tooltip says "Browse the internet"

BUG=b/1522969

Review URL: http://codereview.chromium.org/28272
------------------------------------------------------------------------
r10664 | dsh@google.com | 2009-02-28 02:01:50 +0100 (Sat, 28 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Get rid of wstring variants of StringToFoo.

Review URL: http://codereview.chromium.org/28281
------------------------------------------------------------------------
r10660 | jcampan@chromium.org | 2009-02-28 01:48:30 +0100 (Sat, 28 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

When starting Chrome with the option to go to the home page on start-up, the focus was set to the location bar, not the page.
I had previously fixed this problem for restore-session, not for the home page case.

BUG=6000
TEST=Set www.google.com as your home page, select "on start-up open my home page". Start Chrome, Google page should be shown, focus should be on the Google search field.


Review URL: http://codereview.chromium.org/28287
------------------------------------------------------------------------
r10659 | sky@google.com | 2009-02-28 01:41:27 +0100 (Sat, 28 Feb 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/test/test_browser_window.h

Does two changes to appease chrome bot runs:

. Changes InfoBubble to properly initialize all fields in member
  initializer list and set the delegate before show on the off chance
  the bubble is deleted from show. This should no longer happen after
  the second change.
. Only show the bookmark bubble if the browser window is active. I
  experimented with conditionally enabling the star and this turns out
  to be a bit error prone.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/31016
------------------------------------------------------------------------
r10657 | estade@chromium.org | 2009-02-28 01:35:02 +0100 (Sat, 28 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_item_model.h
   A /trunk/src/chrome/browser/download/download_shelf.cc
   A /trunk/src/chrome/browser/download/download_shelf.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Refactor download shelf and prepare for porting.

Side effect of removing some views dependencies from places they don't belong.

Review URL: http://codereview.chromium.org/28252
------------------------------------------------------------------------
r10653 | tc@google.com | 2009-02-28 00:59:33 +0100 (Sat, 28 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Revert "Don't call SetPriorityClass if CBSText.dll is loaded in the browser
process. The CBSText.dll loads as a global GetMessage hook into the browser
process and intercepts/unintercepts the kernel32 API SetPriorityClass in a
background thread. If the browser calls this API just"

This file is compiled on all platforms and this is windows specific code.

This reverts commit r10648.

Review URL: http://codereview.chromium.org/29008

------------------------------------------------------------------------
r10650 | willchan@chromium.org | 2009-02-28 00:52:34 +0100 (Sat, 28 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/cache_manager_host.cc

Drop whitespace at end of line
Fix formatting for initializer list
Use ASSERT_GE when appropriate
Don't #include a header twice
etc
Review URL: http://codereview.chromium.org/28137
------------------------------------------------------------------------
r10648 | ananta@chromium.org | 2009-02-28 00:51:18 +0100 (Sat, 28 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Don't call SetPriorityClass if CBSText.dll is loaded in the browser process. The CBSText.dll loads as a global GetMessage hook into the browser process and intercepts/unintercepts the kernel32 API SetPriorityClass in a background thread. If the browser calls this API just
when it is intercepted the dlls interceptor proc messes up the stack while returning back, which causes random crashes in the browser.

The hacky fix for now is to check for this dll and not invoke the API. We will beautify this fix if it works in the wild.

This fixes http://code.google.com/p/chromium/issues/detail?id=6418

Bug=6418


Review URL: http://codereview.chromium.org/27257
------------------------------------------------------------------------
r10647 | hclam@chromium.org | 2009-02-28 00:51:16 +0100 (Sat, 28 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Implementation of AudioRendererHost
Completing the implementation of AudioRendererHost in
chrome/browser/renderer_host/audio_renderer_host.cc
with ResourceMessageFilter actually delegating calls to it
when corresponding IPC messages are received.

With this patch we should be able to send audio related IPC
messages to browser with working audio, but we still need
to complete the singleton paradigm for AudioManager to start
using it in unit test and renderer.

Review URL: http://codereview.chromium.org/21494
------------------------------------------------------------------------
r10645 | sidchat@google.com | 2009-02-28 00:49:38 +0100 (Sat, 28 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Update version number for the upgraded French and Polish dictionaries.

Issue=7745
Review URL: http://codereview.chromium.org/28196
------------------------------------------------------------------------
r10636 | mad@chromium.org | 2009-02-27 23:12:58 +0100 (Fri, 27 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

When we open a popup window from an app window, we used to identify this popup window as an app too.

To not lose this functionality, yet fix bug 5739 about those app popup windows which would persist their window placement, I decided to add a new enum browser type item which is a bit combination of both popup and app so we can track those.

bug= http://crbug.com/5739

Review URL: http://codereview.chromium.org/28271
------------------------------------------------------------------------
r10633 | sky@google.com | 2009-02-27 23:05:08 +0100 (Fri, 27 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/views/tree_model.h
   M /trunk/src/chrome/views/tree_node_model.h

Wires up sorting of bookmarks to the 'organize menu' in the bookmark
manager (Glen says no context menus for now). All
BookmarkModelObservers have been updated appropriately.

BUG=1750
TEST=bring up the bookmark manager and try the 'Reorder by title' menu
  item, make sure it works and I didn't screw up anything around it.

Review URL: http://codereview.chromium.org/27262
------------------------------------------------------------------------
r10628 | mpcomplete@google.com | 2009-02-27 22:45:49 +0100 (Fri, 27 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_view_unittest.cc

Disable the ExtensionViewTest while I investigate why it's hanging on the
buildbots.

TBR=aa
Review URL: http://codereview.chromium.org/28273
------------------------------------------------------------------------
r10621 | pinkerton@chromium.org | 2009-02-27 20:47:51 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/English.lproj/TabContents.xib
   A /trunk/src/chrome/app/theme/stop.pdf
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add "stop" image to project. Clean up project so app/theme is a proper group and its children could be relative to it rather than their grandparent. Plumb loading status into Mac controllers. Add more loading status info to stub TabContents. Make browser window a little taller and wider so NTP didn't show scrollbars.
Review URL: http://codereview.chromium.org/31017
------------------------------------------------------------------------
r10620 | mpcomplete@google.com | 2009-02-27 20:35:09 +0100 (Fri, 27 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_view.cc
   A /trunk/src/chrome/browser/extensions/extension_view.h
   A /trunk/src/chrome/browser/extensions/extension_view_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   A /trunk/src/chrome/common/bindings_policy.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   A /trunk/src/chrome/renderer/extensions/extension_bindings.cc
   A /trunk/src/chrome/renderer/extensions/extension_bindings.h
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/index.html
   M /trunk/src/chrome/test/unit/unittests.vcproj

Prototype extension process.  This is a proof of concept, with a lot of
rough edges.  Mostly this just fires up a renderer with an "extension" object
exposed, which right now only has a single method "getTestString".

I also did some misc cleanup along the way.
Review URL: http://codereview.chromium.org/27187
------------------------------------------------------------------------
r10619 | mark@chromium.org | 2009-02-27 20:28:52 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   A /trunk/src/build/mac/make_ib_classes.py
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.h
   M /trunk/src/chrome/chrome.gyp

Ensure classes only referenced by .xib files end up in the executable
Review URL: http://codereview.chromium.org/27277
------------------------------------------------------------------------
r10616 | pinkerton@chromium.org | 2009-02-27 19:32:54 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove a few more NOTIMPLEMENTED methods.
Review URL: http://codereview.chromium.org/28263
------------------------------------------------------------------------
r10615 | pinkerton@chromium.org | 2009-02-27 18:54:43 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Switch from NOTIMPLEMENTED in RenderWidgetHostViewMac::MovePluginWindows() to using a bug to track. Cleans up console output significantly.
Review URL: http://codereview.chromium.org/28260
------------------------------------------------------------------------
r10611 | aa@chromium.org | 2009-02-27 18:19:18 +0100 (Fri, 27 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/extension_error_reporter.cc
   A /trunk/src/chrome/browser/extensions/extension_error_reporter.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Add a centralized error reporter to the
extensions sytem. This can be called from any
component on any thread. The hope is that this
will encourage more thorough error handling.

Review URL: http://codereview.chromium.org/27165
------------------------------------------------------------------------
r10610 | agl@chromium.org | 2009-02-27 18:18:35 +0100 (Fri, 27 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Fix painting issue after a renderer crash

When a renderer crashes, the RenderProcessHost may be reused once the
user refreshes. Because of this, the TransportDIB cache, added in
r10071 was getting used while stale, causing painting issues.

This patch clears the TransportDIB cache after a renderer crash.

BUG=8065

Review URL: http://codereview.chromium.org/28238

------------------------------------------------------------------------
r10607 | deanm@chromium.org | 2009-02-27 16:34:07 +0100 (Fri, 27 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc

Make AutocompletePopupView a virtual interface.

The AutocompletePopupModel needs to be able to communicate with the view.  Since the view implementation will be platform specific, we abstract our a virtual interface that the different platform view implementations must all implement.  This allows the Model and View to communicate, while hiding the platform differences.

This change makes the previous Windows AutocompletePopupView into AutocompletePopupViewWin, a subclass of AutocompletePopupView.

Review URL: http://codereview.chromium.org/28258
------------------------------------------------------------------------
r10606 | deanm@chromium.org | 2009-02-27 15:49:51 +0100 (Fri, 27 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   D /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   D /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_win.cc (from /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc:10605)
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.gyp

Pull the autocomplete popup into separate model and view files.

- autocomplete_popup.h is now autocomplete_popup_{model,view}.h.
- autocomplete_popup.cc is now autocomplete_popup_{model,view_win}.cc
- The view header is still Windows specific, but this will be addressed soon.
- Rename is_open to IsOpen, in preparation for making a interface for the view.
- Update the project files.

Review URL: http://codereview.chromium.org/27272
------------------------------------------------------------------------
r10605 | pinkerton@chromium.org | 2009-02-27 15:20:50 +0100 (Fri, 27 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Fix the tab strip controller to use a list of controllers rather than relying on
a map of TabContents to controllers since the TabContents can change with no way
to update the map.
------------------------------------------------------------------------
r10604 | pinkerton@chromium.org | 2009-02-27 15:20:35 +0100 (Fri, 27 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable new tab page for Mac and Linux
------------------------------------------------------------------------
r10603 | deanm@chromium.org | 2009-02-27 13:08:09 +0100 (Fri, 27 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/edit_drop_target.cc
   M /trunk/src/chrome/browser/autocomplete/edit_drop_target.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h

Misc formatting / cleanup in the autocomplete code.

- Reformat / reword some comments.
- Update include guards to the new style.
- Remove trailing blank lines from end of files.
- Clean up some includes.
- Pull the CompareQuality functor into the implementation.
- Pull kQueryDelayMs into the implementation.

Review URL: http://codereview.chromium.org/27206

------------------------------------------------------------------------
r10589 | jhawkins@chromium.org | 2009-02-27 06:20:21 +0100 (Fri, 27 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.gyp

Finish porting importer for Posix:
* Remove references to toolbar_importer.cc as that file was removed from the tree.
* Add firefox[23]_importer.cc to the Posix build.
* Move ie_importer.cc to the win-only section of the scons file.
Review URL: http://codereview.chromium.org/28249
------------------------------------------------------------------------
r10585 | idanan@chromium.org | 2009-02-27 05:51:26 +0100 (Fri, 27 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h

Issue 7318: Popup Titlebar Appears Under Windows Taskbar

Simple fix to make sure the task bar placement and size is
taking into consideration when placing a new popup window.

BUG=7318

Review URL: http://codereview.chromium.org/29002
------------------------------------------------------------------------
r10584 | jhawkins@chromium.org | 2009-02-27 05:29:26 +0100 (Fri, 27 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Re-land r10564 with a fix for unit tests.  Fixed a typo in an ifdef.

Make firefox_importer_utils.cc compile on Posix.
TBR=evan
Review URL: http://codereview.chromium.org/29006
------------------------------------------------------------------------
r10583 | jnd@chromium.org | 2009-02-27 05:23:23 +0100 (Fri, 27 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc

Now we sort encoding menu according to current application locale, we also
need to sort the "Default Encoding" drop down list under "Chrome Options->Minor 
Tweaks->Fonts and Encoding" since Firefox already supports it.

BUG=8084

Review URL: http://codereview.chromium.org/28179
------------------------------------------------------------------------
r10575 | mad@chromium.org | 2009-02-27 03:48:36 +0100 (Fri, 27 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Completely disable the resize corner until we find a solution for the performance drop...

But only for Windows so the guys on the Mac can still play with it...

Review URL: http://codereview.chromium.org/28198
------------------------------------------------------------------------
r10574 | nick@chromium.org | 2009-02-27 03:43:51 +0100 (Fri, 27 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Revert change 10433, which resulted in an
invalid startup order.

R=munjal

Review URL: http://codereview.chromium.org/28243
------------------------------------------------------------------------
r10570 | jhawkins@chromium.org | 2009-02-27 03:28:16 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Reverting 10564.
Review URL: http://codereview.chromium.org/28244
------------------------------------------------------------------------
r10564 | jhawkins@chromium.org | 2009-02-27 02:59:09 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Make firefox_importer_utils.cc compile on Posix.
Review URL: http://codereview.chromium.org/27249
------------------------------------------------------------------------
r10563 | erg@google.com | 2009-02-27 02:57:05 +0100 (Fri, 27 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/webkit/glue/webinputevent.h

Don't send WebInputEvents from the renderer to the browser.

The browser process now keeps a queue of the last keyboard
events that it sent to the renderer in a queue and pops them
on ACK. If a key is unhandled, we use the copy in the browser
process; we don't even send the key back in the ACK anymore.
Review URL: http://codereview.chromium.org/27244
------------------------------------------------------------------------
r10556 | tc@google.com | 2009-02-27 02:05:59 +0100 (Fri, 27 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/tools/grit/grit/node/base.py

Add os support to grit so we can conditionally include resources based on
platform.

Review URL: http://codereview.chromium.org/28237

------------------------------------------------------------------------
r10548 | pkasting@chromium.org | 2009-02-27 01:52:14 +0100 (Fri, 27 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Fix toolbar keyboard focus (shift-alt-t), which was broken by me, and toolbar button context menus on VK_APPS, which was broken by Jonas.

The overall focus issue was caused by my change that made View::RequestFocus() sanity-check that the View was focusable.  The toolbar uses a crazy hack where it purposefully wants to get focus even though it's not focusable.  :P

The context menu issue was caused by Jonas changing the name of a virtual function, presumably not realizing it was a virtual, not just a simple accessor.  I changed the name back and marked this function (and several others) as virtual.  In order to avoid blowing up the source in toolbar_view.cc, I reverted users of the accessor to just using the member variable name.

Also reordered a couple functions to match the order they were originally declared in View.h.
Review URL: http://codereview.chromium.org/27175
------------------------------------------------------------------------
r10546 | pkasting@chromium.org | 2009-02-27 01:49:03 +0100 (Fri, 27 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window_delegate.h

Non-functional cleanup:
* Clarify some comments.
* Simplify some redundant boolean logic.
* Add a helper function for something a lot of callers were checking manually.
* Fix lint.
Review URL: http://codereview.chromium.org/27247
------------------------------------------------------------------------
r10545 | mmoss@chromium.org | 2009-02-27 01:46:25 +0100 (Fri, 27 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/views/SConscript

Fix Linux shared build breakages due to undefined symbols.

Review URL: http://codereview.chromium.org/28206

------------------------------------------------------------------------
r10542 | erikkay@google.com | 2009-02-27 01:35:11 +0100 (Fri, 27 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc

Fixed a unittest that I missed during my previous id format change.

TBR=aa
Review URL: http://codereview.chromium.org/27248
------------------------------------------------------------------------
r10540 | erikkay@google.com | 2009-02-27 00:51:48 +0100 (Fri, 27 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.h

Fix build break on linux (compiler warning).

TBR=evan

Review URL: http://codereview.chromium.org/28231
------------------------------------------------------------------------
r10536 | jhawkins@chromium.org | 2009-02-27 00:48:03 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc

Fix the linux modules build.  Comparision between signed and unsigned integers.
Review URL: http://codereview.chromium.org/28232
------------------------------------------------------------------------
r10535 | pkasting@chromium.org | 2009-02-27 00:42:00 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix a DCHECK in certain cases when coming out of fullscreen mode.  The frame gets to layout before the browser view, but it needs to know what the browser view's tabstrip layout is going to look like, or it will lay out wrong.
Review URL: http://codereview.chromium.org/27231
------------------------------------------------------------------------
r10530 | sky@google.com | 2009-02-27 00:37:10 +0100 (Fri, 27 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Fixes regression where bookmark bar would appear all black. Actually,
it wasn't that the bookmark bar was all black, rather that BrowserView
thought the bookmark bar was parented when in fact it wasn't. The
black was the result of BrowserView reserving the space for the
bookmark bar and not painting anything in it's space.

BUG=7922
TEST=see bug

Review URL: http://codereview.chromium.org/28191
------------------------------------------------------------------------
r10529 | erikkay@google.com | 2009-02-27 00:36:17 +0100 (Fri, 27 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json
   M /trunk/src/chrome/test/data/extensions/good.crx

Enforce new id format (hex str of sha-1)

Review URL: http://codereview.chromium.org/27236
------------------------------------------------------------------------
r10528 | jhawkins@chromium.org | 2009-02-27 00:36:12 +0100 (Fri, 27 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Make importer.cc compile on Posix.
Review URL: http://codereview.chromium.org/27242
------------------------------------------------------------------------
r10523 | agl@chromium.org | 2009-02-27 00:18:22 +0100 (Fri, 27 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Linux: support displays without Xrender support.

VNC servers don't support Xrender. For this use case, we implement a
slow fallback which byte-fiddles the Skia bitmaps as needed to support
32 and 24 bit visuals.

Review URL: http://codereview.chromium.org/27227

------------------------------------------------------------------------
r10508 | jam@chromium.org | 2009-02-26 22:05:00 +0100 (Thu, 26 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Remove old comment.  TBR=kuchhal
------------------------------------------------------------------------
r10507 | jam@chromium.org | 2009-02-26 21:36:43 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Fix BrowserTest.ThirtyFourTabs and possibly other ui tests in single-process mode.  The problem was that RenderProcess was being destructed on both threads at the same time because of the scoped_ptr.
Review URL: http://codereview.chromium.org/27228
------------------------------------------------------------------------
r10506 | mark@chromium.org | 2009-02-26 21:24:48 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/toolbar_model.cc

Back out r10487 too
Review URL: http://codereview.chromium.org/28209
------------------------------------------------------------------------
r10505 | mark@chromium.org | 2009-02-26 21:10:38 +0100 (Thu, 26 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/site_instance_unittest.cc

Attempting backout of r10495 due to  ui_tests:
ResourceDispatcherTest.CrossSiteAfterCrash
PageLoadTest.Reliability
CrashRecoveryUITest.Reload
CrashRecoveryUITest.LoadInNewTab
Review URL: http://codereview.chromium.org/28208
------------------------------------------------------------------------
r10504 | jcampan@chromium.org | 2009-02-26 20:43:35 +0100 (Thu, 26 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

This CL addresses several issues with focus in application mode:
- when started, the focus was not on the page (it was on the location bar, which is not shown)
- ALT-F4 would not work at that point since the location bar was focused but not showing
- since the location bar was focusable, tabbing through would focus it (causing the focus to go to the top window).

BUG=8124,6046,8126
TEST=See bugs.
R=sky
Review URL: http://codereview.chromium.org/28202
------------------------------------------------------------------------
r10502 | ben@chromium.org | 2009-02-26 20:41:55 +0100 (Thu, 26 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/window.cc

Makes it so windows opened from links in Windows Live Messenger cause the window to appear instead of being invisible.

The discovery is that Windows enforces that you call ShowWindow with the value of STARTUPINFO's wShowWindow field first before calling it with any other value, otherwise all subsequent calls are ignored. I used to have code that flattened the return value of a function into something that would ensure the window is visible, but what I actually needed to do was show the window twice in this case. Ick.

http://crbug.com/3126

TEST=Have someone send you a link in a Windows Live Messenger window, click it without Chrome running (Chrome must be default browser), and a Chrome window should appear, visible, loading the link.
Also try running chrome.exe from bash to make sure that still works.

Review URL: http://codereview.chromium.org/27190
------------------------------------------------------------------------
r10500 | mad@chromium.org | 2009-02-26 20:31:50 +0100 (Thu, 26 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc

Revert change made in http://codereview.chromium.org/10925.
It was mistakenly resting the wrong iterator, so I also renamed the outer one to avoid confusion.

BUG=2569

Review URL: http://codereview.chromium.org/28200
------------------------------------------------------------------------
r10495 | brettw@chromium.org | 2009-02-26 20:08:15 +0100 (Thu, 26 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/site_instance_unittest.cc

Fix unit tests.
------------------------------------------------------------------------
r10492 | jhawkins@chromium.org | 2009-02-26 19:50:55 +0100 (Thu, 26 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc

Add a missing header from r10487.

TBR=brettw
------------------------------------------------------------------------
r10490 | finnur@google.com | 2009-02-26 19:45:45 +0100 (Thu, 26 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix 8063: Find-in-page remains open on History/Downloads page.

Added a UI test to catch this in the future. Also, in some of the UI tests I added a generic URL for pages that don't care about the content of the page and are just testing visibility of the Find box, etc.

TEST=Covered by tests already.
BUG=8063
Review URL: http://codereview.chromium.org/28162
------------------------------------------------------------------------
r10489 | finnur@google.com | 2009-02-26 19:42:23 +0100 (Thu, 26 Feb 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc

Fixing crash in StartFinding (2nd attempt).

The first attempt to fix this was unsuccessful and crashes showed
up again during the automated ui testing. I still can't reproduce
locally, but when I look again at the crash dump I think that the
fact that it looked like the FindBarView was destroyed is misleading
and the real issue is the same as with the crash in StopFinding
(that web_contents has been destroyed moments before we receive the
request).

I am therefore removing the code I added earlier and replacing it
with a null check for web_contents.

TEST=Covered by automated ui tests.
BUG=8048

Review URL: http://codereview.chromium.org/27219
------------------------------------------------------------------------
r10488 | jcampan@chromium.org | 2009-02-26 19:41:52 +0100 (Thu, 26 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Relanding the following:

When restoring a session, the browser is shown after a tab is selected causing
the focus to be on the location bar (not tab contents for web pages).
This CL ensures the tab decides where the focus should be after the browser is
shown.

BUG=6000
TEST=See bug
R=sky
Review URL: http://codereview.chromium.org/28156
------------------------------------------------------------------------
r10487 | brettw@chromium.org | 2009-02-26 19:39:24 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/renderer/about_handler.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc

More URL constants replacement.
Review URL: http://codereview.chromium.org/28170
------------------------------------------------------------------------
r10486 | jhawkins@chromium.org | 2009-02-26 19:36:17 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Remove view_source_contents.cc from the porting list as this file was removed in r10346.

TBR=brettw
Review URL: http://codereview.chromium.org/28195
------------------------------------------------------------------------
r10485 | mad@chromium.org | 2009-02-26 19:36:12 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Prevent the display of the resize corner bitmap on top of the download shelf when the browser window is maximized.

BUG=8025
Review URL: http://codereview.chromium.org/28168
------------------------------------------------------------------------
r10483 | evan@chromium.org | 2009-02-26 19:18:06 +0100 (Thu, 26 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/resources/linux-splash.html

Remove the base64 stop sign graphic and use CSS instead. (R=agl)
------------------------------------------------------------------------
r10482 | erikkay@google.com | 2009-02-26 19:07:50 +0100 (Thu, 26 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix a memory leak in extension install.

Review URL: http://codereview.chromium.org/27215
------------------------------------------------------------------------
r10475 | kuchhal@chromium.org | 2009-02-26 18:25:37 +0100 (Thu, 26 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Disabling ThirtyFourTabs test.

TBR=jam
BUG=8119

Review URL: http://codereview.chromium.org/28190

------------------------------------------------------------------------
r10474 | jhawkins@chromium.org | 2009-02-26 18:05:02 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/chrome.gyp
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make render_view_context_menu.cc compile on Posix.
Review URL: http://codereview.chromium.org/27193
------------------------------------------------------------------------
r10473 | deanm@chromium.org | 2009-02-26 17:45:01 +0100 (Thu, 26 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc

Add the IDC_GO mapping for the go button widget.

We previously crashed with a NOTREACHED() when you clicked the go button.

Review URL: http://codereview.chromium.org/27205
------------------------------------------------------------------------
r10471 | deanm@chromium.org | 2009-02-26 17:14:56 +0100 (Thu, 26 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Remove zombie hunting on startup.

We are hopefully over our zombie problems, and this can cause other troubles.  This should also improve startup performance, since we don't need to iterate all processes on the system on startup.

BUG=6468

Review URL: http://codereview.chromium.org/27203

------------------------------------------------------------------------
r10470 | avi@chromium.org | 2009-02-26 16:59:53 +0100 (Thu, 26 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.mm

We have localization (w00t!). Using it.

Review URL: http://codereview.chromium.org/28188
------------------------------------------------------------------------
r10469 | avi@chromium.org | 2009-02-26 16:36:37 +0100 (Thu, 26 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   D /trunk/src/webkit/glue/webinputevent_utils.cc
   D /trunk/src/webkit/glue/webinputevent_utils.h
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc

Reverting key change (again); this breaks every keyboard layout test there is. Will fix and recommit.

Review URL: http://codereview.chromium.org/28186
------------------------------------------------------------------------
r10467 | deanm@chromium.org | 2009-02-26 16:21:50 +0100 (Thu, 26 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/base/iat_patch.cc
   M /trunk/src/base/iat_patch.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h

Try a new approach to fixing IAT unpatch crashes when the DLL is gone.

Have the IAT patcher take some "ownership" of the DLL, by taking a library name and then calling LoadLibrary() / FreeLibrary() to manage the reference count.  This means as long is there isn't some other reference count balancing bug happening in the process, the DLL will never be unloaded while we are patched.

This effectively reverts r9929, the VirtualQuery additional checks are removed.

BUG=7701

Review URL: http://codereview.chromium.org/21453
------------------------------------------------------------------------
r10464 | avi@chromium.org | 2009-02-26 15:38:40 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   A /trunk/src/webkit/glue/webinputevent_utils.cc
   A /trunk/src/webkit/glue/webinputevent_utils.h
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc

Fixing WebKeyboardEvent. For reals this time.

A recommit of http://codereview.chromium.org/27056 .
Review URL: http://codereview.chromium.org/28136
------------------------------------------------------------------------
r10460 | thomasvl@chromium.org | 2009-02-26 13:41:40 +0100 (Thu, 26 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/resource_bundle.h
   A /trunk/src/chrome/common/resource_bundle_mac.mm (from /trunk/src/chrome/common/resource_bundle_linux.cc:10335)
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   A /trunk/src/chrome/tools/mac_copy_grit_resources.sh
   A /trunk/src/chrome/tools/mac_repack_grit_resources.sh

Wire up resource bundles on the mac:
- compile resource_bundle
- add resource_bundle_mac by cloning the linux and using some NSBundle to find
  the files.
- enable resource bundles on the mac in the calling code.
- added script to app target to repack .pak files into larger chunks (chrome,
  theme, and localized bits).
- added script to copy repacked files into the app bundle.
Review URL: http://codereview.chromium.org/28171
------------------------------------------------------------------------
r10458 | hbono@chromium.org | 2009-02-26 11:21:49 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/build/googleurl.xcodeproj/project.pbxproj
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

Reverting 10456.
Review URL: http://codereview.chromium.org/28180
------------------------------------------------------------------------
r10456 | hbono@chromium.org | 2009-02-26 11:02:52 +0100 (Thu, 26 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/build/googleurl.xcodeproj/project.pbxproj
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc

Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85
To fix this issue, this change adds a new function TrimWhitespaceUTF8(), which trims space characters (including non-printable characters and broken UTF-8 characters) from either end of a UTF-8 string.
Please feel free to give me your comments since I'm not sure this implimentation is correct. (Maybe this implementation trims too aggressively.)

BUG=7377
Review URL: http://codereview.chromium.org/20219
------------------------------------------------------------------------
r10455 | yurys@google.com | 2009-02-26 10:13:01 +0100 (Thu, 26 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/dev_tools_view.cc
   A /trunk/src/chrome/browser/debugger/dev_tools_view.h
   A /trunk/src/chrome/browser/debugger/dev_tools_window.cc
   A /trunk/src/chrome/browser/debugger/dev_tools_window.h
   A /trunk/src/chrome/browser/dom_ui/dev_tools_ui.cc
   A /trunk/src/chrome/browser/dom_ui/dev_tools_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h

Developer tools messages are forwarded as wrapped IPC::Messages(previously they were represented as int type+string body).

I stole IPC::Message serialization code from jam's CL(http://codereview.chromium.org/20413).

jam: please look at message forwarding code. When tools messages are send from browser to renderer they are also wrapped(unlike worker messages which are unwrapped and sent as is). It allows to describe developer tools messages in its own file instead of putting all of them into render_messages_internal.h

brettw: please check if it's OK to have ForwardMessageToToolsClient in WebContentsView

Review URL: http://codereview.chromium.org/21540
------------------------------------------------------------------------
r10443 | jhawkins@chromium.org | 2009-02-26 03:49:32 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make web_drag_source.cc compile on Posix.
Review URL: http://codereview.chromium.org/27192
------------------------------------------------------------------------
r10442 | agl@chromium.org | 2009-02-26 03:30:12 +0100 (Thu, 26 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_resources.grd
   A /trunk/src/chrome/browser/resources/linux-splash.html
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc

Linux: add splash screen

In preparation for an internal launch, this adds a splash screen as
the startup URL for Linux which has a few FAQs.

------------------------------------------------------------------------
r10441 | jam@chromium.org | 2009-02-26 03:27:11 +0100 (Thu, 26 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h

Make IPC::Logging register to watch for message loop destruction.

BUG=8029

Review URL: http://codereview.chromium.org/28154
------------------------------------------------------------------------
r10440 | agl@chromium.org | 2009-02-26 03:26:07 +0100 (Thu, 26 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Linux: fixes for tab contents switching

Previously, removing a view_ from its container destroyed it. We fix
this by disabling GTK's auto reference stealing.

------------------------------------------------------------------------
r10439 | agl@chromium.org | 2009-02-26 03:20:08 +0100 (Thu, 26 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/common/x11_util.cc
   M /trunk/src/chrome/common/x11_util.h

Linux: fix GDK error when switching tab contents

When we remove a drawing area from a container, GTK destroys the X
window. However, the BackingStore remembers the old X window id and
emits X requests using the wrong id.

This change makes the window id an argument to ShowRect and makes the
pixmaps from the root window instead.

Review: http://codereview.chromium.org/27169

------------------------------------------------------------------------
r10438 | wtc@chromium.org | 2009-02-26 02:57:09 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc

OS_MAC should be OS_MACOSX.

R=brettw
Review URL: http://codereview.chromium.org/28157
------------------------------------------------------------------------
r10437 | brettw@chromium.org | 2009-02-26 02:56:02 +0100 (Thu, 26 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_parser.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/url_constants.cc
   M /trunk/src/chrome/common/url_constants.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc

Coalesce more hardcoded schemes to using predefined constants.

Review URL: http://codereview.chromium.org/31008
------------------------------------------------------------------------
r10436 | jhawkins@chromium.org | 2009-02-26 02:51:21 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make chrome_plugin_host.cc and chrome_plugin_util.cc compile on Posix.
Review URL: http://codereview.chromium.org/27150
------------------------------------------------------------------------
r10435 | tc@google.com | 2009-02-26 02:48:55 +0100 (Thu, 26 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h

Implements a method to enable/disable the "Remove All" button
in the password manager. This method is called whenever the
password manager window is opened and disables the button if
there are no passwords stored. It is also called when all of
the stored passwords are removed.

BUG=7228

Original patch by Kyle Nahrgang <kpn24@drexel.edu> in
http://codereview.chromium.org/28063/show

Review URL: http://codereview.chromium.org/27191
------------------------------------------------------------------------
r10433 | munjal@chromium.org | 2009-02-26 02:33:33 +0100 (Thu, 26 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc

Create ProfilePersonalization in the ctor of ProfileImpl instead of lazily creating it.

Review URL: http://codereview.chromium.org/28143
------------------------------------------------------------------------
r10432 | munjal@chromium.org | 2009-02-26 02:33:18 +0100 (Thu, 26 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Hide profiles behind a command-line switch since the user-data-dir stuff
wouldn't work on Mac.

See bug http://code.google.com/p/chromium/issues/detail?id=7987

Review URL: http://codereview.chromium.org/28093
------------------------------------------------------------------------
r10431 | pkasting@chromium.org | 2009-02-26 02:28:52 +0100 (Thu, 26 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Fix fullscreen mode opacity issues on Aero glass.  We need to not extend the glass into the client area at all in fullscreen mode or text over it becomes semitransparent.

Because I can't use "IsTabStripVisible()" to indicate "do we need to goof with the window frame" anymore, I've introduced "IsNormalMode()" instead, and tried to change callers of the former to use the latter where appropriate.

BUG=8066
Review URL: http://codereview.chromium.org/28159
------------------------------------------------------------------------
r10430 | tc@google.com | 2009-02-26 02:27:55 +0100 (Thu, 26 Feb 2009) | 14 lines
Changed paths:
   M /trunk/src/base/base_drop_target.cc
   M /trunk/src/base/base_drop_target.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webdropdata.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Add an identity (id) to system drag & drop.

Used for gears file drag & drop in chrome, assign a drag id (identity) to
each drag and drop session.

Send the identity to the renderer WebViewImpl in drag enter notifications,
provide a getter method.

BUG=7995

Original patch by noel.gordon@gmail.com in:
http://codereview.chromium.org/28108/show

Review URL: http://codereview.chromium.org/28158
------------------------------------------------------------------------
r10414 | finnur@google.com | 2009-02-26 01:08:35 +0100 (Thu, 26 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win.cc

We can get into a state where the automation framework presses the Close button in the Find box after the tab has been destroyed. This causes the Find box to act on a NULL web_contents_ pointer.

We now guard against this by checking for NULL web_contents before performing any work that relies on it.

(I can't reproduce this bug manually or by running the automation testing locally, but this is an attempt to fix the crash by using the information gathered from looking at the crash dump).


Review URL: http://codereview.chromium.org/27173
------------------------------------------------------------------------
r10413 | finnur@google.com | 2009-02-26 01:08:22 +0100 (Thu, 26 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_view.cc

We can get into a state where the automation framework sends a search string, which ends up in a handler in the FindBarView that has already been destroyed, causing a crash. 

We now explicitly null the controller for the text field when destroying the view so that if it is still receiving messages they will be ignored by the view.

(I can't reproduce this bug manually or by running the automation testing locally, but this is an attempt to fix the crash by using the information gathered from looking at the crash dump).

Review URL: http://codereview.chromium.org/27172
------------------------------------------------------------------------
r10412 | erikkay@google.com | 2009-02-26 01:04:15 +0100 (Thu, 26 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/good.crx

Auto install and update extensions from a registry defined location.  This allows developers to install a chrome extension and manage its update process completely indepdendently of Chrome's built-in mechanism.
Review URL: http://codereview.chromium.org/28040
------------------------------------------------------------------------
r10411 | nick@chromium.org | 2009-02-26 01:00:54 +0100 (Thu, 26 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Refactor the p13n NTP handler.

Review URL: http://codereview.chromium.org/27174
------------------------------------------------------------------------
r10407 | ananta@chromium.org | 2009-02-26 00:53:52 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Don't send the receiver function name in the ExternalHostBindings::ForwardMessageToExternalHost
CPP binding exposed for sending messages from Chrome to an external host,

Review URL: http://codereview.chromium.org/27125
------------------------------------------------------------------------
r10403 | erg@google.com | 2009-02-26 00:42:30 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc

Revert "Implement accelerators in the gtk port" at avi's request.

This reverts commit 1dbbeb791d5a9ae0740afb5d7eb57710c93b7f38.

------------------------------------------------------------------------
r10402 | jcampan@chromium.org | 2009-02-26 00:39:20 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Reverting 10400.

Reverting broke the linux build
Review URL: http://codereview.chromium.org/27178
------------------------------------------------------------------------
r10400 | jcampan@chromium.org | 2009-02-26 00:35:35 +0100 (Thu, 26 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

When restoring a session, the browser is shown after a tab is selected causing the focus to be on the location bar (not tab contents for web pages).
This CL ensures the tab decides where the focus should be after the browser is shown.

BUG=6000
TEST=See bug
R=sky
Review URL: http://codereview.chromium.org/28152
------------------------------------------------------------------------
r10399 | shess@chromium.org | 2009-02-26 00:32:47 +0100 (Thu, 26 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add the hunspell project to Chrome.app and get spellchecker compiling
for Mac.

Review URL: http://codereview.chromium.org/28053
------------------------------------------------------------------------
r10395 | evan@chromium.org | 2009-02-25 23:49:08 +0100 (Wed, 25 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton_linux.cc

Add bug links for ProcessSingleton.

Review URL: http://codereview.chromium.org/28142
------------------------------------------------------------------------
r10387 | erg@google.com | 2009-02-25 23:16:51 +0100 (Wed, 25 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc

Implement accelerators in the gtk port.

- Adds accelerators to all the menu items that had them on windows.
- Adds accelerators to back (Alt+left), forward (Alt+right), reload
  (Ctr+R) and focus the URL box (Ctr+L).

Review URL: http://codereview.chromium.org/28105

------------------------------------------------------------------------
r10384 | jcampan@chromium.org | 2009-02-25 23:01:00 +0100 (Wed, 25 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/views/widget_win.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

This CL causes the autofill popup to hide when the browser window is moved or resized.

TEST=Bring up an autofill popup in a form, move the browser. The autofill popup should be closed.
BUG=7401
R=ben
Review URL: http://codereview.chromium.org/28126
------------------------------------------------------------------------
r10383 | pinkerton@chromium.org | 2009-02-25 23:00:45 +0100 (Wed, 25 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/TabContents.xib
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Change url bar text according to the model when updating the toolbar. Fix vtable issue in ToolbarModel by using correct declaration.
Review URL: http://codereview.chromium.org/27163
------------------------------------------------------------------------
r10381 | jar@chromium.org | 2009-02-25 22:36:06 +0100 (Wed, 25 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Avoid race crash: Don't drop reference to URL fetcher until data is extracted

I also removed a redundant reset in the constructor.

bug=7693

r=brettw
Review URL: http://codereview.chromium.org/27159
------------------------------------------------------------------------
r10375 | mpcomplete@google.com | 2009-02-25 21:50:19 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Fix the case of invoking chrome with --install-extension when chrome was not
running.  It now opens a new chrome window instead of leaving a ghost process
around.
Review URL: http://codereview.chromium.org/28079
------------------------------------------------------------------------
r10374 | estade@chromium.org | 2009-02-25 21:44:08 +0100 (Wed, 25 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Ports SpellChecker to use FilePaths instead of wstring.

by Rohit Rao (rohitrao@google.com)

issue: http://codereview.chromium.org/28013

------------------------------------------------------------------------
r10372 | pkasting@chromium.org | 2009-02-25 21:41:30 +0100 (Wed, 25 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Update animations in fullscreen mode to prevent stuck throbbers.

Also makes SUpportsWindowFeature() private since no one outside the class was using it.

BUG=8031
Review URL: http://codereview.chromium.org/28129
------------------------------------------------------------------------
r10370 | estade@chromium.org | 2009-02-25 21:35:26 +0100 (Wed, 25 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/toolbar_model.cc

One more ElideUrl->GetCleanStringFromUrl

Review URL: http://codereview.chromium.org/28131
------------------------------------------------------------------------
r10369 | agl@chromium.org | 2009-02-25 21:34:04 +0100 (Wed, 25 Feb 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_x.cc
   D /trunk/src/chrome/browser/renderer_host/backing_store_xcb.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/transport_dib.h
   M /trunk/src/chrome/common/transport_dib_linux.cc
   A /trunk/src/chrome/common/x11_util.cc
   A /trunk/src/chrome/common/x11_util.h
   A /trunk/src/chrome/common/x11_util_internal.h
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/test/unit/unit_tests.scons

Linux: server side backing stores

This converts Linux to using server-side backing stores. Rather than
keeping a backing store in heap memory in the browser, we create a
pixmap in the X server. This means that expose messages don't require
us to transport any images to the X server, we can just direct it to
paint from the pixmap. Also, scrolling can be performed server side
also. This greatly improves performance over remote X.

Also, shared memory transport to the X server is implemented. Shared
memory segments can be created in the renderer and mapped directly
into the X server.

Review URL: http://codereview.chromium.org/27147

------------------------------------------------------------------------
r10368 | pinkerton@chromium.org | 2009-02-25 21:33:23 +0100 (Wed, 25 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/gfx/chrome_font.h
   A /trunk/src/chrome/common/gfx/chrome_font_mac.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable the ToolbarModel on Mac and Linux. Implement ChromeFont on Mac.
Review URL: http://codereview.chromium.org/28124
------------------------------------------------------------------------
r10366 | nsylvain@chromium.org | 2009-02-25 21:26:44 +0100 (Wed, 25 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util_unittest.cc
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/test/mini_installer_test/test.cc

Fix all places where we used the GetWinVersion function
incorrectly.

bug:7802
Review URL: http://codereview.chromium.org/28128
------------------------------------------------------------------------
r10363 | estade@chromium.org | 2009-02-25 20:51:04 +0100 (Wed, 25 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h

Change some calls to gfx::ElideUrl() to using gfx::GetCleanStringFromUrl()

Review URL: http://codereview.chromium.org/27148
------------------------------------------------------------------------
r10362 | kuchhal@chromium.org | 2009-02-25 20:40:17 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   D /trunk/src/webkit/glue/webinputevent_utils.cc
   D /trunk/src/webkit/glue/webinputevent_utils.h
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc

Revert "Fixing WebKeyboardEvent."

Review URL: http://codereview.appspot.com/21071

------------------------------------------------------------------------
r10361 | jrg@chromium.org | 2009-02-25 20:20:28 +0100 (Wed, 25 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main_mac.mm

Fix menubar activation in context of temp LSUIElement=1 hack.

Review URL: http://codereview.chromium.org/27145
------------------------------------------------------------------------
r10360 | avi@chromium.org | 2009-02-25 20:19:53 +0100 (Wed, 25 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_linux.cc
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   A /trunk/src/webkit/glue/webinputevent_utils.cc
   A /trunk/src/webkit/glue/webinputevent_utils.h
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc

Fixing WebKeyboardEvent.

Review URL: http://codereview.chromium.org/27056
------------------------------------------------------------------------
r10359 | pkasting@chromium.org | 2009-02-25 20:18:26 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Force the browser to restored mode before going fullscreen, since Windows doesn't seem to want to hide the taskbar for maximized windows regardless of their dimensions.

BUG=7997
Review URL: http://codereview.chromium.org/27146
------------------------------------------------------------------------
r10353 | sky@google.com | 2009-02-25 19:30:25 +0100 (Wed, 25 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Fixes bogus DCHECK in bookmark_bar_view. I needed to add the check for
testing_ as we don't want it hit in the interactive tests, and the
check should be for removing, so that I wanted is_add, not !is_add.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/28122
------------------------------------------------------------------------
r10352 | jar@chromium.org | 2009-02-25 19:26:29 +0100 (Wed, 25 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_trial.cc
   M /trunk/src/chrome/browser/browser_trial.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Remove memory model experiment

We've already removed the histograms (during cleanup of other files) so
this just discards the remaining uses of the constants, along with the
experiment establishment portion.

r=mbelshe
Review URL: http://codereview.chromium.org/27032
------------------------------------------------------------------------
r10351 | phajdan.jr@chromium.org | 2009-02-25 19:25:45 +0100 (Wed, 25 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Compile parts of chrome/browser/automation on Linux.

This patch involves heavy temporary stubbing-out of windowsic parts
of automation framework.

Review URL: http://codereview.chromium.org/28092
------------------------------------------------------------------------
r10347 | kuchhal@chromium.org | 2009-02-25 19:07:21 +0100 (Wed, 25 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Disable ThirtyFoudTabs test as it is failing consitently now on all buildbots.

TBR=sky,sidchat
BUG=5668

Review URL: http://codereview.appspot.com/20072

------------------------------------------------------------------------
r10346 | brettw@chromium.org | 2009-02-25 19:04:59 +0100 (Wed, 25 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   D /trunk/src/chrome/browser/tab_contents/view_source_contents.cc
   D /trunk/src/chrome/browser/tab_contents/view_source_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc

Delete the ViewSourceTabContents.

This removes all the tab contents type stuff for view source mode. The
RenderViewHostManager now automatically switches RenderViews when we turn view
source mode on or off to get the desired effect.

I also moved some instances of hardcoded schemes into chrome_constants.h, and
renamed RendererCreated/Ready/Gone to RenderViewCreated/Ready/Gone to reflect
what they actually mean.
Review URL: http://codereview.chromium.org/28089
------------------------------------------------------------------------
r10344 | glen@chromium.org | 2009-02-25 18:47:58 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable history and downloads by default, port NewTabUI from DOMUIHost to DOMUI.

NewTabUI is only included on OS(WIN) because DOMUI doesn't appear to have been ported.
Review URL: http://codereview.chromium.org/28104
------------------------------------------------------------------------
r10343 | jhawkins@chromium.org | 2009-02-25 18:28:30 +0100 (Wed, 25 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make bookmark_context_menu.cc and bookmark_drop_info.cc compile on Posix.
Review URL: http://codereview.chromium.org/28103
------------------------------------------------------------------------
r10341 | pkasting@chromium.org | 2009-02-25 18:16:02 +0100 (Wed, 25 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/locationbg_readonly_center.png
   A /trunk/src/chrome/app/theme/locationbg_readonly_edge.png (from /trunk/src/chrome/app/theme/locationbg_readonly_left.png:10201)
   D /trunk/src/chrome/app/theme/locationbg_readonly_left.png
   D /trunk/src/chrome/app/theme/locationbg_readonly_right.png
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Make non-glass popups match new mockup from Glen.

Unfortunately glass popups can't be made to match the mockup unless we want to completely reimplement Windows titlebar drawing, so I'm leaving them pretty much unchanged :(

BUG=7569
Review URL: http://codereview.chromium.org/28072
------------------------------------------------------------------------
r10338 | pkasting@chromium.org | 2009-02-25 18:09:21 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Allow JS Debugger shortcut to work in fullscreen mode, since there's no reason not to.

BUG=8023
Review URL: http://codereview.chromium.org/27110
------------------------------------------------------------------------
r10337 | pkasting@chromium.org | 2009-02-25 18:05:42 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Fix system menu positioning a bit.  In Aero glass, the maximized mode menu was going offscreen by one pixel, causing Windows to reposition it strangely.  In both frames, the vertical offset below the tabstrip needed a bit of tweaking.

BUG=7927
Review URL: http://codereview.chromium.org/27115
------------------------------------------------------------------------
r10336 | jcampan@chromium.org | 2009-02-25 17:15:18 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Trying again to land this CL that makes the browser focus UI tests in process.

TBR=sky
Review URL: http://codereview.chromium.org/27122
------------------------------------------------------------------------
r10333 | pinkerton@chromium.org | 2009-02-25 15:02:12 +0100 (Wed, 25 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Add "new tab" ui to the build and remove some of the scaffolding. Fix compatibility issues with GCC.
Review URL: http://codereview.chromium.org/28088
------------------------------------------------------------------------
r10330 | jar@chromium.org | 2009-02-25 07:10:17 +0100 (Wed, 25 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/renderer/renderer_histogram_snapshots.cc
   A /trunk/src/chrome/renderer/renderer_histogram_snapshots.h
   M /trunk/src/chrome/renderer/renderer_main.cc

Initial support for Renderer Side Histograms

Patch contributed by Raman Tenneti

see also patch number 21038

Review URL: http://codereview.chromium.org/27034
------------------------------------------------------------------------
r10326 | jrg@chromium.org | 2009-02-25 05:56:21 +0100 (Wed, 25 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/app-Info.plist
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/common/child_thread.cc
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_mac.mm

Temporary fix for the Cocoa-in-renderer problem.

Review URL: http://codereview.chromium.org/27108
------------------------------------------------------------------------
r10325 | sky@google.com | 2009-02-25 05:12:23 +0100 (Wed, 25 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Adds some debugging code in hopes of figuring out who is removing the
bookmark bar.

BUG=7857
TEST=none

Review URL: http://codereview.chromium.org/28100
------------------------------------------------------------------------
r10324 | wtc@chromium.org | 2009-02-25 03:53:01 +0100 (Wed, 25 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/login_prompt.cc

Add a new message id IDS_LOGIN_DIALOG_DESCRIPTION_NO_REALM,
which is a variant of IDS_LOGIN_DIALOG_DESCRIPTION that
doesn't have a realm.  Some HTTP authentication schemes
such as NTLM don't have a realm.

In IDS_LOGIN_DIALOG_DESCRIPTION, changed the placeholder's
name from "TITLE" to "REALM".

R=eroman,tony
BUG=6567,6824
Review URL: http://codereview.chromium.org/27117
------------------------------------------------------------------------
r10322 | ben@chromium.org | 2009-02-25 03:40:50 +0100 (Wed, 25 Feb 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/app_modal_dialog_delegate.h
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   D /trunk/src/chrome/browser/app_modal_dialog_queue_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   A /trunk/src/chrome/views/app_modal_dialog_delegate.h (from /trunk/src/chrome/views/app_modal_dialog_delegate.h:10319)
   M /trunk/src/chrome/views/views.vcproj

ui test fail. revert.

------------------------------------------------------------------------
r10321 | jcampan@chromium.org | 2009-02-25 03:02:46 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/scoped_ole_initializer.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 10318.

Reverting again...
Review URL: http://codereview.chromium.org/28106
------------------------------------------------------------------------
r10320 | ben@chromium.org | 2009-02-25 02:54:03 +0100 (Wed, 25 Feb 2009) | 5 lines
Changed paths:
   A /trunk/src/chrome/browser/app_modal_dialog_delegate.h (from /trunk/src/chrome/views/app_modal_dialog_delegate.h:10204)
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   A /trunk/src/chrome/browser/app_modal_dialog_queue_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   D /trunk/src/chrome/views/app_modal_dialog_delegate.h
   M /trunk/src/chrome/views/views.vcproj

AppModalDialogQueue shouldn't depend on views.

Add a simple test, too.

Review URL: http://codereview.chromium.org/27080
------------------------------------------------------------------------
r10318 | jcampan@chromium.org | 2009-02-25 02:35:56 +0100 (Wed, 25 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/scoped_ole_initializer.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Landing again the move of browser focus UI tests to in process.

TBR=sky
Review URL: http://codereview.chromium.org/28097
------------------------------------------------------------------------
r10317 | tc@google.com | 2009-02-25 01:57:43 +0100 (Wed, 25 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   M /trunk/src/chrome/browser/dom_ui/fileicon_source.cc

fix clobber build

these are new files missed by r10306.

tbr=deanm

Review URL: http://codereview.chromium.org/28101

------------------------------------------------------------------------
r10316 | jcampan@chromium.org | 2009-02-25 01:33:08 +0100 (Wed, 25 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc

This make accelerators work in interstitial pages.
Interstitial pages are RVH whose view is shown on top of the actual tab.
Some more work is required to make find in page work.

BUG=7056
TEST=Open an page that triggers an interstitial (ex: https://ebay.com), press CTRL-T, a new tab should be opened.
Review URL: http://codereview.chromium.org/21298
------------------------------------------------------------------------
r10314 | estade@chromium.org | 2009-02-25 01:22:27 +0100 (Wed, 25 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/webkit/glue/dom_serializer.cc

Get save page working on posix.

* rearrange some IFDEFs
* trim whitespace on suggest name

Also fix a relatively new bug in DomSerializer.
Review URL: http://codereview.chromium.org/27106
------------------------------------------------------------------------
r10313 | sky@google.com | 2009-02-25 01:22:01 +0100 (Wed, 25 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/views/tree_node_model.h

Adds ability to sort the children of a node in the bookmark model. I
plan on doing this in chunks, next phase is updating observers, then
changing the bookmark manager to call into the new method.

BUG=1750
TEST=none yet

Review URL: http://codereview.chromium.org/27082
------------------------------------------------------------------------
r10307 | tc@google.com | 2009-02-25 00:50:13 +0100 (Wed, 25 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h
   A /trunk/src/chrome/common/l10n_util_win.cc
   A /trunk/src/chrome/common/l10n_util_win.h
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/menu.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/tooltip_manager.cc

Move windows specific functions from l10n_util.h to l10n_util_win.h.

Review URL: http://codereview.chromium.org/27103
------------------------------------------------------------------------
r10306 | tc@google.com | 2009-02-25 00:38:55 +0100 (Wed, 25 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/debugger/resources/debugger_resources.grd
   M /trunk/src/chrome/common/common_resources.grd
   M /trunk/src/chrome/renderer/renderer_resources.grd
   M /trunk/src/net/base/net_resources.grd
   M /trunk/src/tools/grit/grit/scons.py
   M /trunk/src/tools/grit/grit/tool/build.py
   M /trunk/src/webkit/glue/webkit_resources.grd
   M /trunk/src/webkit/glue/webkit_strings.grd
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_resources.grd

Final step in converting all grit includes to have grit in the path.

Fixes some linux/mac issues that were pending and fix up the scons build to
expect the file in the grit subdir.

BUG=7537

Review URL: http://codereview.chromium.org/28035

------------------------------------------------------------------------
r10302 | aa@chromium.org | 2009-02-25 00:07:45 +0100 (Wed, 25 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/renderer/user_script_slave.cc

Add logging to ExtensionsService, UserScriptMaster,
and PluginChannel to be able to see what happens
when chrome runs extensions headless.

It would be better to modify the existing
IPC::Logging mechanism than add logging to
PluginChannel, so that it could be useful for
debugging other types of IPC problems. But I don't
have time to do that right now.

Review URL: http://codereview.chromium.org/28091
------------------------------------------------------------------------
r10300 | jhawkins@chromium.org | 2009-02-24 23:45:56 +0100 (Tue, 24 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make bookmark_drag_data.cc compile on Posix.
Review URL: http://codereview.chromium.org/31007
------------------------------------------------------------------------
r10299 | estade@chromium.org | 2009-02-24 23:42:05 +0100 (Tue, 24 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths_linux.cc

Final step needed to get be able to download things on linux.

There's still no UI though.

Review URL: http://codereview.chromium.org/27097
------------------------------------------------------------------------
r10297 | jcampan@chromium.org | 2009-02-24 23:23:23 +0100 (Tue, 24 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Reverting 10295.

Reverting my last CL
Review URL: http://codereview.chromium.org/28095
------------------------------------------------------------------------
r10295 | jcampan@chromium.org | 2009-02-24 23:06:22 +0100 (Tue, 24 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

Converted the browser focus interactive ui tests to be in process.
Some testing I did as part of my in-progress focus refactoring seemed to indicate they are flacky.
With this CL, they now mostly use the blocking calls when simulating UI actions (instead of relying on timers).

BUG=None
TEST=Run the tests BrowserFocusTest.* in the interactive tests.
Review URL: http://codereview.chromium.org/27083
------------------------------------------------------------------------
r10293 | jhawkins@chromium.org | 2009-02-24 22:47:16 +0100 (Tue, 24 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Make bookmark_utils.cc compile on Posix.
Review URL: http://codereview.chromium.org/27100
------------------------------------------------------------------------
r10291 | paulg@google.com | 2009-02-24 22:25:53 +0100 (Tue, 24 Feb 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

Clean up WebKit resources after starting a download.

Downloads initiated in the renderer process have associated
resources that need to be cleaned up properly. Since we handle
downloads in the browser process, the renderer was not receiving
the completion notification and thus hanging on to resources.

We now send the renderer a completion notification once we detect
that a resource request is a download, so that the renderer can
properly clean up.

BUG=6531 (http://crbug.com/6531)

Review URL: http://codereview.chromium.org/20524
------------------------------------------------------------------------
r10288 | jhawkins@chromium.org | 2009-02-24 21:41:20 +0100 (Tue, 24 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc

Some cleanups in response to brettw's comments to r10277.
* Remove build_config.h from a file that isn't using it.
* Return something useful from StringForURLDisplay.
* Use basictypes.h instead of build_config.h.
Review URL: http://codereview.chromium.org/27099
------------------------------------------------------------------------
r10281 | phajdan.jr@chromium.org | 2009-02-24 21:11:33 +0100 (Tue, 24 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_handle_tracker.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/startup/startup_test.cc

Platform cleanup in automation code.

Review URL: http://codereview.chromium.org/27098
------------------------------------------------------------------------
r10277 | jhawkins@chromium.org | 2009-02-24 20:32:15 +0100 (Tue, 24 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make autocomplete.cc and dependencies compile on Posix.
Review URL: http://codereview.chromium.org/28061
------------------------------------------------------------------------
r10276 | dsh@google.com | 2009-02-24 20:08:23 +0100 (Tue, 24 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/histogram_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/ipc_channel_win.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/net/base/connection_type_histograms.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/sdch_filter.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/block_files.cc
   M /trunk/src/net/disk_cache/entry_impl.cc
   M /trunk/src/net/disk_cache/eviction.cc
   M /trunk/src/net/disk_cache/rankings.cc
   M /trunk/src/net/disk_cache/stats.cc
   M /trunk/src/net/disk_cache/stats_histogram.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc

Use string for Histogram names since these are all ASCII anyway.
Wide-character literals cause problems between platforms.

Review URL: http://codereview.chromium.org/28046
------------------------------------------------------------------------
r10275 | evan@chromium.org | 2009-02-24 20:02:43 +0100 (Tue, 24 Feb 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h

Implement ResourceMessageFilter::OnGetWindowRect and OnGetRootWindowRect
on linux. This fixes a problem typing in the username when authenticating
to gmail.

The error message was:

FATAL:browser/renderer_host/render_view_host.cc(658)] Check failed:
false. Can't send sync messages to UI thread without pumping messages
in the renderer or else deadlocks can occur if the pagehas windowed
plugins! (message type 8219)

Review URL: http://codereview.chromium.org/28026
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
------------------------------------------------------------------------
r10273 | avi@chromium.org | 2009-02-24 19:47:49 +0100 (Tue, 24 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Taking out unfinished code. I don't understand what role these functions play, and I put in quickly-ported Windows code. It crashes, so I'm taking it out until I can properly write it.

Review URL: http://codereview.chromium.org/31005
------------------------------------------------------------------------
r10270 | estade@chromium.org | 2009-02-24 19:33:49 +0100 (Tue, 24 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/download/download_request_dialog_delegate.h
   A /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.cc
   A /trunk/src/chrome/browser/download/download_request_dialog_delegate_win.h
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Download request manager refactoring.

Pull out the dialog delegate to a separate file so we can swap it out with other implementations on other platforms.

Also, build download_request_manager.cc on POSIX.

Review URL: http://codereview.chromium.org/27062
------------------------------------------------------------------------
r10268 | sky@google.com | 2009-02-24 18:22:43 +0100 (Tue, 24 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/test/data/purify/ui_tests.gtest.txt

Attempt at fixing flakeyness when running session restore ui tests in
purify. I believe the ui test isn't waiting for the session restore to
complete, so that when the ui test does various asserts the state of
the browser is wrong.

BUG=6495
TEST=covered by tests

Review URL: http://codereview.chromium.org/28051
------------------------------------------------------------------------
r10257 | pinkerton@chromium.org | 2009-02-24 16:11:05 +0100 (Tue, 24 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Add some browser/dom_ui files to Mac and Linux. Fix errors exposed by GCC.
Review URL: http://codereview.chromium.org/27090
------------------------------------------------------------------------
r10249 | tommi@chromium.org | 2009-02-24 04:04:12 +0100 (Tue, 24 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Removing WS_POPUP before calling SetParent to avoid stealing the focus (flicker) during initialization.

Review URL: http://codereview.chromium.org/27066
------------------------------------------------------------------------
r10246 | estade@chromium.org | 2009-02-24 03:30:04 +0100 (Tue, 24 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.h

Make download manager treat mixed-case extensions the same as lower-case extensions when judging whether a file is executable.

Also, store known executable file extensions as narrow strings since they are all ASCII anyway.

r=jcampan
BUG=7455
Review URL: http://codereview.chromium.org/29003
------------------------------------------------------------------------
r10238 | jar@chromium.org | 2009-02-24 02:25:06 +0100 (Tue, 24 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Re-re-roll use of ongoing logs to gather stability metrics

This was rolled back to try to use only the initial logs to gather statibility
stats, because we were having trouble capturing data in ongoing logs.

We now resolved the problem (which was actually only on the stability
branch), so we'll roll back to using this method and verify it in the
dev branch.

tbr=mal
Review URL: http://codereview.chromium.org/27061
------------------------------------------------------------------------
r10236 | ben@chromium.org | 2009-02-24 02:18:57 +0100 (Tue, 24 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h

HtmlDialogContentsDelegate should not subclass views::WindowDelegate, for portability reasons (views isn't used on Mac or Linux).

Instead, add modal/title getting methods to HtmlDialogContentsDelegate directly, and have the UI (HtmlDialogView) call to these in the Modal/ModelessHtmlDialogDelegate in its implementation of views::WindowDelegate instead.

TEST=open any page and test that Page->Create application shortcuts still works. visit any site that uses Gears and make sure the Gears Allow/Deny dialog still comes up.
Review URL: http://codereview.chromium.org/27074
------------------------------------------------------------------------
r10231 | finnur@google.com | 2009-02-24 01:10:29 +0100 (Tue, 24 Feb 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/find_notification_details.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/webkit/glue/webframe_impl.cc

The find bar should be owned and managed from the BrowserView, not the WebContentsView, since it's part of the "chrome".

Design Doc: http://dev.chromium.org/developers/design-documents/find-bar

Things done:
- Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed.
- Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view.
- Moved find control methods to WebContents.
- Added recent find result state to WebContents.
- Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered.
- Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc.
- Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs.
- Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab.
- view.h: Don't lay out child views again if they have a layout manager, it already updated them.

TEST=Find box should work as before.
BUG=3245

Review URL: http://codereview.chromium.org/27025
------------------------------------------------------------------------
r10229 | estade@chromium.org | 2009-02-24 01:04:14 +0100 (Tue, 24 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix linux build break.

tbr=jhawkins

Review URL: http://codereview.chromium.org/28052
------------------------------------------------------------------------
r10228 | mmoss@chromium.org | 2009-02-24 00:58:00 +0100 (Tue, 24 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/build/SConscript.main
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/tools/convert_dict/convert_dict.scons
   M /trunk/src/net/net_lib.scons
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript

Multiple fixes for broken Linux SHARED=1 build. This gets things building, but the resulting 'chrome' binary crashes on start-up (test_shell seems to work better).

Review URL: http://codereview.chromium.org/27054

------------------------------------------------------------------------
r10226 | estade@chromium.org | 2009-02-24 00:54:18 +0100 (Tue, 24 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_item_model.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/save_package.cc
   D /trunk/src/chrome/browser/download/save_page_model.cc
   D /trunk/src/chrome/browser/download/save_page_model.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Refactor BaseDownloadItemModel and its inheritors.

* Move BaseDownloadItemModel to download_item_model.h. Previously it was in a windows-specific file in chrome/browser/views/.
* Move SavePageModel to download_item_model.{cc,h}.

Review URL: http://codereview.chromium.org/28033
------------------------------------------------------------------------
r10225 | evan@chromium.org | 2009-02-24 00:54:02 +0100 (Tue, 24 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/process_singleton.h
   M /trunk/src/chrome/common/chrome_paths_linux.cc

Obey the XDG base directory spec and use ~/.config/chromium on Linux.

As discussed here:
http://groups.google.com/group/chromium-dev/browse_thread/thread/41e9154311779e1a

Review URL: http://codereview.chromium.org/27069
------------------------------------------------------------------------
r10224 | evan@chromium.org | 2009-02-24 00:53:31 +0100 (Tue, 24 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Fix more gcc 4.3 warnings.

Review URL: http://codereview.chromium.org/28045
------------------------------------------------------------------------
r10223 | erg@google.com | 2009-02-24 00:53:21 +0100 (Tue, 24 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Clear out the vbox before adding a new widget.

This prevents the weird issue where gtk tries to pack both views into the box.
It isn't optimal, though. This solution leaves the area blank since it clears
the old renderer as soon as the new one is created instead of waiting until
the new renderer has something to display.

Review URL: http://codereview.chromium.org/27057

------------------------------------------------------------------------
r10222 | jhawkins@chromium.org | 2009-02-24 00:53:17 +0100 (Tue, 24 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make plugin_installer.cc compile on Posix.
Review URL: http://codereview.chromium.org/31001
------------------------------------------------------------------------
r10221 | estade@chromium.org | 2009-02-24 00:53:14 +0100 (Tue, 24 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix a download regression.

FilePath::Extension() returns ".extension" whereas file_util::GetExtensionFromFilename() returns just "extension"

Review URL: http://codereview.chromium.org/27071
------------------------------------------------------------------------
r10220 | kuchhal@chromium.org | 2009-02-24 00:14:53 +0100 (Tue, 24 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   A /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/accelerator.cc

Revert "Revert "Fullscreen mode UI.""
This reverts commit 243e461e4a659a6e8008befc2c76a55680860f01.

Review URL: http://codereview.appspot.com/21057

------------------------------------------------------------------------
r10217 | kuchhal@chromium.org | 2009-02-23 23:52:31 +0100 (Mon, 23 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   D /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   D /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/accelerator.cc

Revert "Fullscreen mode UI."
This reverts commit d108cc705611554de13712935ec11942dd390a5d.

Review URL: http://codereview.appspot.com/21056

------------------------------------------------------------------------
r10215 | jrg@chromium.org | 2009-02-23 22:54:26 +0100 (Mon, 23 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_factory.mm

Update header ref to new location.

Review URL: http://codereview.chromium.org/27063
------------------------------------------------------------------------
r10214 | pkasting@chromium.org | 2009-02-23 22:34:36 +0100 (Mon, 23 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/fullscreen_exit_bubble.cc
   A /trunk/src/chrome/browser/views/fullscreen_exit_bubble.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/accelerator.cc

Fullscreen mode UI.

This requires a change that is currently out for review from sky.

BUG=534
TEST=App menu should have a "full screen mode" entry; going into fullscreen mode should display a bubble at the top of the screen, which should slide away after a few seconds; mousing to the screen top will show the bubble again, and clicking the link inside should exit fullscreen mode.
Review URL: http://codereview.chromium.org/28012
------------------------------------------------------------------------
r10211 | jar@chromium.org | 2009-02-23 22:14:38 +0100 (Mon, 23 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_log.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Discard crash data during first run of a new version.

Avoid confusion associated with uploading crash data from an old version
during the first run of a new version.

Carlos: Please confirm that you're fine with discarding metrics about
installer and Render in Sbox.

Evan: Please confirm that I got all the usage/crash stats.

r=cpu,evanm,mal
Review URL: http://codereview.chromium.org/28017
------------------------------------------------------------------------
r10210 | jhawkins@chromium.org | 2009-02-23 22:03:04 +0100 (Mon, 23 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/child_process_host.cc
   M /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make plugin_process_host.cc and child_process_host.cc compile on Posix.
Review URL: http://codereview.chromium.org/27018
------------------------------------------------------------------------
r10201 | phajdan.jr@chromium.org | 2009-02-23 20:22:13 +0100 (Mon, 23 Feb 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h

Fix a crash when dns prefetching was being shut down without being started.

This happened when BrowserMain exited before the point when we initialized dns prefetching, but after BrowserProcessImpl was created. We do shutdown of dns prefetching in ~BrowserProcessImpl.

Example way to trigger the crash: open a saved HTML page while Chrome is already running.

Change ShutdownDnsPrefetch to EnsureDnsPrefetchingShutdown which does nothing
if dns prefetching  has not been initialized. This is the simplest way
to prevent the crash and we don't want to complicate the startup sequence even more.

BUG=7900

Review URL: http://codereview.chromium.org/27048
------------------------------------------------------------------------
r10197 | ericroman@google.com | 2009-02-23 20:04:40 +0100 (Mon, 23 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_mac.h
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc

Add support to ProxyService for downloading a PAC script on behalf of the ProxyResolver. A ProxyResolver can select this new behavior by subclassing ProxyResolver with |does_fetch = false|. A consequence of this change is that proxy resolve requests are maintained in a queue by ProxyService (rather than implicitly in a queue on the PAC thread's message loop). This simplifies cancellation.This solves issue 7461, and is work-in-progress towards {2764, 74}BUG=7461
Review URL: http://codereview.chromium.org/21328
------------------------------------------------------------------------
r10191 | pkasting@chromium.org | 2009-02-23 18:46:02 +0100 (Mon, 23 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/event_utils.h

Fix a bogus end-of-file comment.
Review URL: http://codereview.chromium.org/28008
------------------------------------------------------------------------
r10190 | pkasting@chromium.org | 2009-02-23 18:45:50 +0100 (Mon, 23 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h

A few minor changes to WidgetWin:

* Add a Show() method to match Hide(), and use it in existing code.  This abstracts the specifics of this a bit and will be convenient for fullscreen UI.

* Safe Hide() (and, for speed, Close()) behind IsWindow() checks just like CloseNow(), which I'll need for some tricky window-closing code in the fullscreen UI.  (Right now, Hide() will eventually fail an assertion if you call it when the widget is no longer a window, which seems unnecessarily harsh.)
Review URL: http://codereview.chromium.org/27017
------------------------------------------------------------------------
r10187 | pinkerton@chromium.org | 2009-02-23 18:25:44 +0100 (Mon, 23 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/cocoa/browser_window_controller.mm

Fix references to moved files
------------------------------------------------------------------------
r10186 | pinkerton@chromium.org | 2009-02-23 18:24:11 +0100 (Mon, 23 Feb 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/browser_window_cocoa.h
   D /trunk/src/chrome/browser/browser_window_cocoa.mm
   D /trunk/src/chrome/browser/browser_window_controller.h
   D /trunk/src/chrome/browser/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/browser_window_cocoa.h (from /trunk/src/chrome/browser/browser_window_cocoa.h:10183)
   A /trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm (from /trunk/src/chrome/browser/browser_window_cocoa.mm:10183)
   A /trunk/src/chrome/browser/cocoa/browser_window_controller.h (from /trunk/src/chrome/browser/browser_window_controller.h:10183)
   A /trunk/src/chrome/browser/cocoa/browser_window_controller.mm (from /trunk/src/chrome/browser/browser_window_controller.mm:10183)
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Move Cocoa-specific files into the cocoa folder
Review URL: http://codereview.chromium.org/28028
------------------------------------------------------------------------
r10178 | xji@chromium.org | 2009-02-23 07:00:44 +0100 (Mon, 23 Feb 2009) | 45 lines
Changed paths:
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas_win.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h
   M /trunk/src/chrome/common/l10n_util_unittest.cc
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/label.h
   M /trunk/src/chrome/views/label_unittest.cc
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/message_box_view.h

This CL fixes issue 6099 -- bad display of multi-line English message in pop ups.
(http://crbug.com/6099)

Currently, in RTL locales, a pure *multi-line* English message is displayed as right aligned and has RTL directionality (such as the ending punctuation appears at the very left).

Single-line message works fine.

I do not know why, but simply putting LRE-PDF around a multi-line English text which has the following flags 
DT_WORDBREAK | DT_RTLREADING 
wont render the English message as LTR.
We have to remove the DT_RTLREADING to render multi-line English message correctly in LTR direction.


The fix is that in RTL locales, for JavaScript message, if the message is pure English, the alignment is set to be left-aligned, and the directionality is set to be left-to-right. If the message is mixed BiDi text, the alignment and the directionality is determined by the directionality of the first character with strong directionality in the text. 

JavaScript message is a MessageBoxView, and the message is a view::Label. Both MessageBoxView and Label are used by Chrome's UI  as well.
If the message is one of Chrome UI's, the alignment and directionality of the message should be taken from that of the UI's.

In order to distinguish where the message comes from, a new flag kFlagWebMessage is introduced in MessageBoxView, and a new argument is introduced in Label::SetHorizontalAlignment() to control whether the alignment need to be flipped or not for RTL locales.

Consequently, quite a few files which calls Label::SetHorizontalAlignment() are changed.

The main changes are in 5 areas. Other files are changed due to the signature change of Label::SetHorizontalAlignment().

1. jsmessage_box_handler.cc: pass in extra flag kFlagWebPage when creating MessageBoxView to indicate the message box is one from a web page, not from Chrome UI.

2. l10n_util.h/.cc
added function GetFirstStrongDirection()

3. label.h/.cc
a new argument is introduced in Label::SetHorizontalAlignment() to control whether the alignment need to be flipped or not for RTL locales.

4. message_box_view.cc
when init message box view, if the flag is kFlagWebPage, get the text directionality from the text itself (not Chrome UI's) and calls Label::SetHorizontalAlignment() to not resetting the flag for RTL locales.

5. chrome_canvas_win.cc
5.1 ComputeFormatFlags()
only set flag DT_RTLREADING for RTL locales if the text contains strong RTL characters and the alignment is RIGHT aligned. All labels of Chrome's UI and other Chrome UI components in RTL locales have been set as (or flipped to) RIGHT aligned. 

5.2 DoDrawText()
Only adjust string for locale is the reading direction is DT_RTLREADING.



Review URL: http://codereview.chromium.org/18863
------------------------------------------------------------------------
r10167 | tc@google.com | 2009-02-23 00:03:27 +0100 (Mon, 23 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_win.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_page_model.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/standard_menus.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history_tab_ui.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/js_before_unload_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/process_singleton_win.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/native_ui_contents.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/repost_form_warning_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/chrome.xcodeproj/generate_headers.sh
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/DEPS
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/tools/grit/build/grit_localized_resources.rules
   M /trunk/src/tools/grit/build/grit_resources.rules
   M /trunk/src/webkit/DEPS
   M /trunk/src/webkit/default_plugin/install_dialog.cc
   M /trunk/src/webkit/default_plugin/plugin_impl_win.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/feed_preview.cc
   M /trunk/src/webkit/glue/localized_strings.cc
   M /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/webkit.xcodeproj/glue_prebuild.sh

Update include paths for grit files.  Go ahead and resort
the headers too.

Review URL: http://codereview.chromium.org/21472
------------------------------------------------------------------------
r10155 | estade@chromium.org | 2009-02-22 02:21:56 +0100 (Sun, 22 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/base/hash_tables.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Bring download_file, download_manager into POSIX build.

Also shuffle a bunch of headers.

Review URL: http://codereview.chromium.org/27024
------------------------------------------------------------------------
r10154 | agl@chromium.org | 2009-02-22 00:18:28 +0100 (Sun, 22 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc

Purify bot fix

Purify was upset about a memory allocation issue in unit_tests where
HANDLE values were getting reused.

------------------------------------------------------------------------
r10153 | agl@chromium.org | 2009-02-21 22:08:28 +0100 (Sat, 21 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Correctly evict smallest transport DIB cache member

Previously, I failed to update the smallest size so far when a smaller element
was found.

(bug found by cpu)

Review URL: http://codereview.chromium.org/28007

------------------------------------------------------------------------
r10146 | jam@chromium.org | 2009-02-21 09:52:55 +0100 (Sat, 21 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

blacklist some more tests in single process
------------------------------------------------------------------------
r10144 | jam@chromium.org | 2009-02-21 09:05:28 +0100 (Sat, 21 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   A /trunk/src/chrome/common/child_thread.cc
   A /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_process.cc
   M /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/net/render_dns_master.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Refactor code from RenderThread and PluginThread and move it to ChildThread.  ChildProcess now owns the ChildThread, which removes duplicate code and simplifies things.

Clean up ChildProcess, there really was no need for all the templates and statics in it and its subclasses.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10080
Review URL: http://codereview.chromium.org/21502
------------------------------------------------------------------------
r10142 | estade@chromium.org | 2009-02-21 03:07:01 +0100 (Sat, 21 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Fix linux/mac build bustage.

TBR=mpcomplete

Review URL: http://codereview.chromium.org/27031
------------------------------------------------------------------------
r10139 | mpcomplete@google.com | 2009-02-21 02:44:30 +0100 (Sat, 21 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h

Add NPAPI plugins contained in extensions to the PluginList.
Review URL: http://codereview.chromium.org/20521
------------------------------------------------------------------------
r10134 | rafaelw@chromium.org | 2009-02-21 01:05:48 +0100 (Sat, 21 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc

Create the extensions (<Profile>/Extensions) and user script (<Profile>/User Scripts) directories during start up if they don't already exists

Review URL: http://codereview.chromium.org/29001
------------------------------------------------------------------------
r10130 | darin@chromium.org | 2009-02-21 00:30:37 +0100 (Sat, 21 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

More fixes for bad reference counting.

TBR=erikkay

Review URL: http://codereview.chromium.org/27021
------------------------------------------------------------------------
r10128 | agl@chromium.org | 2009-02-20 23:08:11 +0100 (Fri, 20 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h

Fix unit test memory leak

(found by purify)

TBR=brettw

Review URL: http://codereview.chromium.org/27012

------------------------------------------------------------------------
r10127 | agl@chromium.org | 2009-02-20 22:44:05 +0100 (Fri, 20 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc

Purify fix

It appears that we were previously leaking HANDLEs but when this
changed to objects, purify picked it up.

------------------------------------------------------------------------
r10126 | estade@chromium.org | 2009-02-20 22:09:00 +0100 (Fri, 20 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/webkit/glue/image_decoder.cc

Show page icons on back/forward menu lists on linux.

Also fix some gtk memory warnings and enable some code for favicon fetching.

Review URL: http://codereview.chromium.org/21532
------------------------------------------------------------------------
r10123 | sidchat@google.com | 2009-02-20 22:02:57 +0100 (Fri, 20 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/browser/spellchecker.cc

Add UI support for the newly added Turkish and Estonian spellcheckers.
Issue=4782
Review URL: http://codereview.chromium.org/28003
------------------------------------------------------------------------
r10121 | xji@chromium.org | 2009-02-20 21:42:10 +0100 (Fri, 20 Feb 2009) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h
   M /trunk/src/chrome/common/l10n_util_unittest.cc


This CL fix the following 2 bugs:
1.7324 -- RTL: Path contains Hebrew is wrong on "Download location" text box
(http://crbug.com/7324)

2. 7326 -- RTL: Folder icon missing on "Download location" text box
(http://crbug.com/7326)

The fix are:
1. force path to have LTR directionality.
2. draw icon in mirrored position in RTL locales.

Steps for test:
1. Create a folder with a Hebrew file name on Hebrew XP
2. Change the download location to the folder created in step 1
3. Observe the path displayed on "Google Chrome Options" --> "Minor Tweaks" --> "Download location" text box

Without the fix: 
The path contains Hebrew folder name is wrong. It displayed as "cCBA\:" while the path is "c:\CBA" where "CBA" is a Hebrew folder name.
And there is no folder icon in the "download location" text box.

With the fix:
The path displayed correctly as "c:\CBA" or "c:\CBA\FED" where "FED" is subfolder of "CBA".
And the folder icon showed at the very right.


Review URL: http://codereview.chromium.org/20038
------------------------------------------------------------------------
r10116 | xji@chromium.org | 2009-02-20 21:12:53 +0100 (Fri, 20 Feb 2009) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/views/location_bar_view.cc

ï»¿This CL fixes issue 2674 - Omnibar displays wrong parenthesis for "arabia.msn.comâ€¬"
(http://crbug.com/2674)

The issue is: in RTL locale, the search engine name, if ending with punctuation, might not be displayed correctly in omnibox keyword text and omnibox keyword hint.

Fix: adjust the search engine keyword description (short name) for RTL locale so that the pure LTR search engine name 
is marked with LRE-PDF pair to be displayed correctly. For example, "MSN(English)" is displayed as is, not as "(MSN(English".

Reproduce steps:
Looks like the "MSN(English)" is no longer a default search engine name. We can make one by the following steps:
1. Open "customize and control Google Chrome" --> "Options",
2. under "basics" tab, under "Default search:", click "Manage"
3. click on one search engine from the "default search options", then click "edit". For example, pick "AOL". 
4. change the "name" from "AOL" to "AOL(English)".

Without the fix, in RTL Chrome, when type in "aol.com" in omnibox, the omni keyword hint shows "(AOL(English - xxxx <tab> yyy" while "xxx" stands for "to search" in Hebrew and "yyy" stands for "press" in Hebrew. After press <tab>, the keyword text in omnibox is ":(AOL(English - zzz" while "zzz" stands for "search" in Hebrew.

With the fix, the name "AOL(English)" is displayed correctly in the above 2 places.


Review URL: http://codereview.chromium.org/21320
------------------------------------------------------------------------
r10113 | erg@google.com | 2009-02-20 20:43:11 +0100 (Fri, 20 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc

Use the URLFixerUpper on entry

Review URL: http://codereview.chromium.org/27004

------------------------------------------------------------------------
r10111 | evan@chromium.org | 2009-02-20 20:15:02 +0100 (Fri, 20 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/custom_button.cc
   M /trunk/src/chrome/browser/gtk/custom_button.h
   M /trunk/src/chrome/browser/gtk/nine_box.cc
   M /trunk/src/chrome/common/resource_bundle.h
   M /trunk/src/chrome/common/resource_bundle_linux.cc

Draw custom menu buttons properly.

This is an iterative process towards code to be proud of; the previous
code of mine was horrible, this is less bad, and my next attempt at it
will be pretty, I promise.

Review URL: http://codereview.chromium.org/28001
------------------------------------------------------------------------
r10109 | erg@google.com | 2009-02-20 19:57:15 +0100 (Fri, 20 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Implement the logic to change Renderers. We can now navigate between pages!

Review URL: http://codereview.chromium.org/27002

------------------------------------------------------------------------
r10105 | maruel@chromium.org | 2009-02-20 18:55:55 +0100 (Fri, 20 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/printing/print_settings.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   D /trunk/src/chrome/browser/printing/units.cc
   D /trunk/src/chrome/browser/printing/units.h
   D /trunk/src/chrome/browser/printing/units_unittest.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   A /trunk/src/printing
   A /trunk/src/printing/DEPS
   A /trunk/src/printing/printing.vcproj
   A /trunk/src/printing/printing.vsprops
   A /trunk/src/printing/printing_unittests.vcproj
   A /trunk/src/printing/units.cc (from /trunk/src/chrome/browser/printing/units.cc:10032)
   A /trunk/src/printing/units.h (from /trunk/src/chrome/browser/printing/units.h:10032)
   A /trunk/src/printing/units_unittest.cc (from /trunk/src/chrome/browser/printing/units_unittest.cc:10032)
   M /trunk/src/webkit/webkit.sln
   M /trunk/src/webkit/webkit_armu.sln
   M /trunk/src/webkit/webkit_kjs.sln

Move units to new module printing. Add printing_unittests on Windows too. Make test_shell and chrome_dll dependent on printing.
Review URL: http://codereview.chromium.org/21475
------------------------------------------------------------------------
r10104 | deanm@chromium.org | 2009-02-20 18:43:03 +0100 (Fri, 20 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Implement RenderWidgetHostViewGtk::Destroy.

This follows the same style as on Windows, destroy the native window in Destroy(), not in the destructor.

Review URL: http://codereview.chromium.org/20538

------------------------------------------------------------------------
r10102 | jhawkins@chromium.org | 2009-02-20 18:21:30 +0100 (Fri, 20 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make plugin_service.cc compile on Posix.
Review URL: http://codereview.chromium.org/20531
------------------------------------------------------------------------
r10101 | darin@chromium.org | 2009-02-20 18:00:42 +0100 (Fri, 20 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   D /trunk/src/chrome/browser/debugger/tools_contents.cc
   D /trunk/src/chrome/browser/debugger/tools_contents.h
   D /trunk/src/chrome/browser/debugger/tools_view.cc
   D /trunk/src/chrome/browser/debugger/tools_view.h
   D /trunk/src/chrome/browser/debugger/tools_window.cc
   D /trunk/src/chrome/browser/debugger/tools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

Revert r10090, which was committed without proper review.

TBR=brettw

Review URL: http://codereview.chromium.org/20539
------------------------------------------------------------------------
r10099 | pinkerton@chromium.org | 2009-02-20 17:48:29 +0100 (Fri, 20 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/English.lproj/TabContents.xib
   A /trunk/src/chrome/app/theme/grow_box.png
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/grow_box_view.h
   A /trunk/src/chrome/browser/cocoa/grow_box_view.m
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Roll our own grow box since the OS one wants to indent by 3px due to the textured window style.
Review URL: http://codereview.chromium.org/21544
------------------------------------------------------------------------
r10090 | yurys@google.com | 2009-02-20 12:14:55 +0100 (Fri, 20 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/tools_contents.cc
   A /trunk/src/chrome/browser/debugger/tools_contents.h
   A /trunk/src/chrome/browser/debugger/tools_view.cc
   A /trunk/src/chrome/browser/debugger/tools_view.h
   A /trunk/src/chrome/browser/debugger/tools_window.cc
   A /trunk/src/chrome/browser/debugger/tools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

Add tab content type for developer tools UI.
Add code routing messages between ToolsAgent and ToolsClient in the browser process.

There is no direct IPC channel between inspected process and developer tools UI so all messages have to be routed through the browser process.

On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object.

On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI.

(darin: tools message representation will be later changed from id+string to just IPC::Message)
Review URL: http://codereview.chromium.org/21510
------------------------------------------------------------------------
r10089 | deanm@chromium.org | 2009-02-20 12:05:12 +0100 (Fri, 20 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h

Reformat some omnibox enum comments.  This helps readability a bit by using more horizontal space.

Review URL: http://codereview.chromium.org/21511
------------------------------------------------------------------------
r10087 | hbono@chromium.org | 2009-02-20 10:10:03 +0100 (Fri, 20 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc

Fix for Issue 6431 "Two issues about Vietnamese Spell-Checker".
This issue is caused by my stupid mistake in the SpellcheckWordIterator class. Unfortunately, the class does not treat combining characters as word characters for languages which uses combining characters (e.g. Vietnamese, Thai, etc.) because the ICU exemplar set is canonicalized and it does not include combining characters.
To fix this, this change decomposes an exemplar set and also mark the decomposed characters (including combining characters) as word characters.

BUG=6431


Review URL: http://codereview.chromium.org/21079
------------------------------------------------------------------------
r10085 | aa@chromium.org | 2009-02-20 10:00:21 +0100 (Fri, 20 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix linux tests. Can't rely on directory iteration order.

Review URL: http://codereview.chromium.org/20532
------------------------------------------------------------------------
r10084 | aa@chromium.org | 2009-02-20 09:14:39 +0100 (Fri, 20 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/test/data/extensions/bad/missing_content_script
   A /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1
   A /trunk/src/chrome/test/data/extensions/bad/missing_content_script/1/manifest.json
   A /trunk/src/chrome/test/data/extensions/bad/missing_content_script/Current Version
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/script1.js
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/script2.js

Complain when an extension does not contain a user script it claims to.

Review URL: http://codereview.chromium.org/21436
------------------------------------------------------------------------
r10083 | mmoss@chromium.org | 2009-02-20 09:06:04 +0100 (Fri, 20 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Make BrowserWindowGtk work with resource bundle theme images.

This is a quick fix to allow chrome to run from outside the build tree (so I
can make a demo package). More extensive reworking is underway separately by
evanm.

Review URL: http://codereview.chromium.org/20530

------------------------------------------------------------------------
r10082 | jam@chromium.org | 2009-02-20 08:15:17 +0100 (Fri, 20 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   D /trunk/src/chrome/common/child_thread.cc
   D /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_process.cc
   M /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/net/render_dns_master.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Reverting 10080.
------------------------------------------------------------------------
r10080 | jam@chromium.org | 2009-02-20 06:23:36 +0100 (Fri, 20 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/base/thread.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   A /trunk/src/chrome/common/child_thread.cc
   A /trunk/src/chrome/common/child_thread.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_process.cc
   M /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/mock_render_process.h
   M /trunk/src/chrome/renderer/net/render_dns_master.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc

Refactor code from RenderThread and PluginThread and move it to ChildThread.  ChildProcess now owns the ChildThread, which removes duplicate code and simplifies things.

Clean up ChildProcess, there really was no need for all the templates and statics in it and its subclasses.
Review URL: http://codereview.chromium.org/21502
------------------------------------------------------------------------
r10077 | jnd@chromium.org | 2009-02-20 05:51:28 +0100 (Fri, 20 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc

We will sort the encoding menu items according to current used UI language except the UTF-8 encoding and the recently selectd encodings.
For details, see Fix bug http://code.google.com/p/chromium/issues/detail?id=7647

BUG=7647
Review URL: http://codereview.chromium.org/21414
------------------------------------------------------------------------
r10075 | jhawkins@chromium.org | 2009-02-20 04:33:11 +0100 (Fri, 20 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/user_data_manager.h

Remove a forward declaration that is not being used.
Review URL: http://codereview.chromium.org/20528
------------------------------------------------------------------------
r10074 | jhawkins@chromium.org | 2009-02-20 04:20:17 +0100 (Fri, 20 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make user_data_manager.cc compile on Posix.
Review URL: http://codereview.chromium.org/20525
------------------------------------------------------------------------
r10071 | agl@chromium.org | 2009-02-20 03:00:04 +0100 (Fri, 20 Feb 2009) | 41 lines
Changed paths:
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/base/timer.h
   M /trunk/src/base/timer_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store_xcb.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   D /trunk/src/chrome/common/bitmap_wire_data.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/ipc_maybe.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/transport_dib.h
   A /trunk/src/chrome/common/transport_dib_linux.cc
   A /trunk/src/chrome/common/transport_dib_mac.cc
   A /trunk/src/chrome/common/transport_dib_win.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/skia/ext/bitmap_platform_device_linux.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/platform_canvas_linux.cc
   M /trunk/src/skia/ext/platform_canvas_linux.h
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   M /trunk/src/skia/ext/platform_canvas_mac.h

Bitmap transport

This patch reworks bitmap transport on all platforms. Linux and Mac
are switched from serialising bitmaps over the IPC channel to using
shared memory. All platforms gain a shared memory mapping cache on the
host side.

The concept of a TransportDIB (device independent bitmap) is added to
encapsulate most of the platform specifics.

On Linux, we use SysV shared memory. This is because X shared pixmaps,
which predate POSIX SHM, can only use SysV. By using SysV between
renderer and browser, we open up the possibility to map the shared
memory directly from the renderer to the X server.

On Mac, we use POSIX shared memory. However, since this needs
filesystem access and the Mac renderer is sandboxed from the
filesystem, we add two new messages from renderer -> browser:

The first, AllocTransportDIB, synchronously creates a transport DIB in
the browser and passes a handle back to the renderer. The second,
FreeTransportDIB, asynchronously, notifies the browser that it may
close its handle to the shared memory region.

On Mac, the shared memory regions are identified by their inode
numbers on the wire. This means that the browser must keep handles
open to all the allocated shared memory regions (since an inode number
is insufficient to map the region). The alternative design is that the
renderer passes the file descriptor with each paint operation. Since
passing file descriptors is special case in the code, I felt that it
would be best to minimise their use. Creating and freeing transport
DIBs are relatively rare operations relative to paints and scrolls.

On Windows, most of the code remains the same, except that Windows now
uses the mapping cache added in this patch. This allows the browser to
maintain a shared memory mapping for a transport DIB over several
paints. Previously it mapped and unmapped for every operation, causing
lots of TLB and VM churn.

Review URL: http://codereview.chromium.org/21485

------------------------------------------------------------------------
r10070 | estade@chromium.org | 2009-02-20 01:45:16 +0100 (Fri, 20 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/unit/unit_tests.scons

Port save_package_unittest to posix.

Review URL: http://codereview.chromium.org/20514
------------------------------------------------------------------------
r10069 | ananta@chromium.org | 2009-02-20 01:43:42 +0100 (Fri, 20 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc

Fix a UMR in the IPC message ViewHostMsg_FrameNavigate, which occured as a result 
of revision r10023.

This fixes http://code.google.com/p/chromium/issues/detail?id=7869

Bug=7869

Review URL: http://codereview.chromium.org/20519
------------------------------------------------------------------------
r10068 | idanan@chromium.org | 2009-02-20 01:39:58 +0100 (Fri, 20 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Enable dragging of single tab between two windows.

To determine if a window is draggable, all that was needed is to call HasAvailableDrag action
instead of ContainsExactlyOneTab which was not we wanted anyways.

BUG=7861

Review URL: http://codereview.chromium.org/21525
------------------------------------------------------------------------
r10066 | jhawkins@chromium.org | 2009-02-20 01:23:58 +0100 (Fri, 20 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Add a line back in that was accidentally removed before the commit.  Fixes the linux build.
Review URL: http://codereview.chromium.org/21530
------------------------------------------------------------------------
r10065 | jhawkins@chromium.org | 2009-02-20 01:20:18 +0100 (Fri, 20 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Make template_url_fetcher.cc compile on Posix.
Review URL: http://codereview.chromium.org/20522
------------------------------------------------------------------------
r10058 | evan@chromium.org | 2009-02-20 00:25:06 +0100 (Fri, 20 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h

Remove the home button on Linux.

This actually obeys the pref, but we have no way to set the pref.

Review URL: http://codereview.chromium.org/24024
------------------------------------------------------------------------
r10057 | evan@chromium.org | 2009-02-20 00:23:27 +0100 (Fri, 20 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   M /trunk/src/chrome/tools/convert_dict/convert_dict.cc

Fix some GCC 4.3 warnings.

BUG=7742

Review URL: http://codereview.chromium.org/20512
------------------------------------------------------------------------
r10055 | dkegel@google.com | 2009-02-19 23:57:09 +0100 (Thu, 19 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/base/x509_certificate_nss.cc
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/unittest_test_server.h
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Enable SSL error handling in Linux again.

Evan, could you review the change since http://codereview.chromium.org/20444 :
- load temporary root cert in test_shell

Thanks!
Review URL: http://codereview.chromium.org/20511
------------------------------------------------------------------------
r10053 | evan@chromium.org | 2009-02-19 23:47:53 +0100 (Thu, 19 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/custom_button.cc
   A /trunk/src/chrome/browser/gtk/custom_button.h

Relocate custom button code to its own files, in anticipation of more changes.

(Next is to fix the menu buttons.)

Review URL: http://codereview.chromium.org/20509
------------------------------------------------------------------------
r10051 | glen@chromium.org | 2009-02-19 23:26:06 +0100 (Thu, 19 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/resources/history.html

* Add day deletion to history
* Speed up history viewing by swapping the search depth to day rather than month - it's now orders of magnitude faster for people who visit more than 30 pages a day, and very slightly slower for people who visit less than 10 pages a day.

Review URL: http://codereview.chromium.org/21182
------------------------------------------------------------------------
r10050 | glen@chromium.org | 2009-02-19 23:25:22 +0100 (Thu, 19 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   A /trunk/src/chrome/browser/dom_ui/downloads_ui.cc
   A /trunk/src/chrome/browser/dom_ui/downloads_ui.h
   A /trunk/src/chrome/browser/dom_ui/fileicon_source.cc
   A /trunk/src/chrome/browser/dom_ui/fileicon_source.h
   A /trunk/src/chrome/browser/resources/downloads.html

Initial checkin of the HTML downloads UI. It's not yet complete (lacking interface polish). But is enough for us to begin removing the native UI.ojan, please review downloads.htmlpaul, please review everything else
Review URL: http://codereview.chromium.org/20110
------------------------------------------------------------------------
r10045 | erg@google.com | 2009-02-19 23:01:26 +0100 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.cc
   A /trunk/src/chrome/browser/gtk/tab_contents_container_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h

Add a TabContentsContainerGtk to remove the current hack that inserts the
RenderViewHostGtk native_view() into the widget heiarchy.

(Now we're crashing on cross site instance navigation because it
looks like we aren't updating some internal reference to the new renderer.)

Review URL: http://codereview.chromium.org/21517

------------------------------------------------------------------------
r10044 | estade@chromium.org | 2009-02-19 22:59:32 +0100 (Thu, 19 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

save_package.cc: Move UI test special casing to a helper function.

This effectively mocks out prompt-spawning win_util calls and keeps untested lines of code to a minimum.
Review URL: http://codereview.chromium.org/21492
------------------------------------------------------------------------
r10042 | paulg@google.com | 2009-02-19 22:58:14 +0100 (Thu, 19 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Report malware sub resources and their containing page to the
SafeBrowsing service for faster malware detection.

Any malware resource that we detect on a page is reported if
the page that contains it is not in the blacklist AND the user
has opted in to reporting stats.

BUG=7607 (http://crbug.com/7607)

Review URL: http://codereview.chromium.org/21474
------------------------------------------------------------------------
r10041 | estade@chromium.org | 2009-02-19 22:56:31 +0100 (Thu, 19 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/unit/unit_tests.scons

Port TabContentsFactory to posix.

Enable back_forward_menu_model_unittest on linux.
Review URL: http://codereview.chromium.org/21522
------------------------------------------------------------------------
r10040 | evan@chromium.org | 2009-02-19 22:55:45 +0100 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc

Fix status bubble positioning on non-tiled window managers.

gtk_window_get_position includes the window decoration, so it was the wrong
function to use.
Also, switch to using the requisition rather than getting the top-level size,
as that is what we use elsewhere.

Review URL: http://codereview.chromium.org/21515
------------------------------------------------------------------------
r10039 | evan@chromium.org | 2009-02-19 22:55:07 +0100 (Thu, 19 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

Remove a workaround made obsolete by Tony's l10n work.

Review URL: http://codereview.chromium.org/20503
------------------------------------------------------------------------
r10037 | evan@chromium.org | 2009-02-19 22:54:37 +0100 (Thu, 19 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Add a comment to a metrics_service.cc NOTIMPLEMENTED.

Review URL: http://codereview.chromium.org/21523
------------------------------------------------------------------------
r10034 | jhawkins@chromium.org | 2009-02-19 22:52:45 +0100 (Thu, 19 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/webkit/glue/context_menu.h

Make render_view_context_menu_controller.cc compile on Posix.
Review URL: http://codereview.chromium.org/21497
------------------------------------------------------------------------
r10028 | cpu@google.com | 2009-02-19 20:19:17 +0100 (Thu, 19 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Fix test because GetBrowserProcessCount counts the browser as well :)

TBR=maruel


Review URL: http://codereview.chromium.org/21518
------------------------------------------------------------------------
r10024 | cpu@google.com | 2009-02-19 19:47:41 +0100 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/common/chrome_constants.cc

Update the table of RAM vs number of renderers
- revised my guesstimate of 25 MB per renderer to 40MB, which I think is more appropiate for long lived tabs, since short lived tabs don't really matter here.
- the lower end (< 1GB) has less total renderers
- the middle has about the same
- the upper end (> 2GB) has more renderers
- added test to open 34 tabs.

Review URL: http://codereview.chromium.org/21484
------------------------------------------------------------------------
r10023 | ananta@chromium.org | 2009-02-19 19:41:31 +0100 (Thu, 19 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/webkit/glue/webview_delegate.h

Send over the HTTP status code in the ViewHostMsg_FrameNavigate message coming in from the renderer. 

A failed HTTP navigation like a 404 response to a request is followed by two responses. The first one which is associated with the failed response. This does not send over any information about the failure to the browser and thus appears as a normal navigation.The second response is for the actual 404 page being loaded. 

For network errors the browser does get notified via RenderView::DidFailProvisionalLoadWithError. However due to a prototype mismatch the corresponding function in WebContents is never invoked.

Added a new automation message AutomationMsg_NavigationFailed, which carries information about failed navigations to automation clients.The changes to the navigation controller include sending over the http status code and the URL to observers.

The ExternalTabContainer also subscribes to the FAIL_PROVISIONAL_LOAD_WITH_ERROR notification, so it can inform clients about errors. We also ignore the next NAV_ENTRY_COMMITTED notification after an error due to the reasons mentioned above.


Review URL: http://codereview.chromium.org/21495
------------------------------------------------------------------------
r10021 | phajdan.jr@chromium.org | 2009-02-19 19:23:25 +0100 (Thu, 19 Feb 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   D /trunk/src/chrome/browser/net/dns_slave.cc
   D /trunk/src/chrome/browser/net/dns_slave.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/net/base/host_resolver.h

Clean up dns prefetch code, and also port it.

- remove slave threads and use HostResolver in asynchronous mode instead (while still limiting number of concurrent lookups)

- make the implementation portable and make DnsMaster unit test compile and pass on Linux

- add more tests to DnsMaster unit test to simulate various shutdown scenarios, concurrent lookups, and to verify that we don't exceed our limit of concurrent lookup requests)

- remove some tests which relied on specifics of slaves' inner working

- adjust initialization and shutdown of dns prefetching (now it relies on the IO message loop being present)

Bonus: shutdown is almost instant now, no need to have a timeout.

BUG=5687, 6683

Review URL: http://codereview.chromium.org/15076
------------------------------------------------------------------------
r10019 | pinkerton@chromium.org | 2009-02-19 19:05:14 +0100 (Thu, 19 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/renderer/render_widget.cc

Hook up the resize rect for Mac and enable its use in the renderer (mac-only). 
Review URL: http://codereview.chromium.org/21512
------------------------------------------------------------------------
r10014 | ericroman@google.com | 2009-02-19 12:46:48 +0100 (Thu, 19 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc

Update test expectation.
This needs the port numbers, since they now get properly inferred.

TBR=wtc@chromium.org

Review URL: http://codereview.chromium.org/20490
------------------------------------------------------------------------
r10010 | ericroman@google.com | 2009-02-19 09:11:42 +0100 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   M /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/proxy/proxy_config_service_fixed.h
   M /trunk/src/net/proxy/proxy_config_service_win.cc
   M /trunk/src/net/proxy/proxy_resolver_mac.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   A /trunk/src/net/proxy/proxy_server.cc
   A /trunk/src/net/proxy/proxy_server.h
   A /trunk/src/net/proxy/proxy_server_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Add parsing for PAC result strings -- ProxyInfo::UsePacString().

Added the support class ProxyServer to avoid losing the proxy server's type information (http, socks) when populating the list.

The format of the configuration strings has been extended accordingly to include an optional [<scheme>"://"] prefix.
(i.e. "http://", "socks4://", "socks5://").

Review URL: http://codereview.chromium.org/20398
------------------------------------------------------------------------
r10007 | aa@chromium.org | 2009-02-19 08:03:05 +0100 (Thu, 19 Feb 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/test/data/extensions/bad_hash.crx
   M /trunk/src/chrome/test/data/extensions/bad_json.crx
   M /trunk/src/chrome/test/data/extensions/bad_magic.crx
   M /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json
   M /trunk/src/chrome/test/data/extensions/good.crx

Manifest renames.

Renamed "user_scripts" back to "content_scripts"
and "files" to "js". The latter I'm a bit unsure
about and would like feedback on.

Frequently, authors only need to inject CSS, not
JS (witness usersstyles.org and the Stylish
Firefox extension). Making CSS injection first-
class allows us to tighten permissions for that
case and gives a fast path when that is all
authors want to do.

So I renamed "files" to "js" so that we could
someday have "css", too.

Review URL: http://codereview.chromium.org/21422
------------------------------------------------------------------------
r10005 | estade@chromium.org | 2009-02-19 05:37:57 +0100 (Thu, 19 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc

Port back_forward_menu_model_unittest to linux.

Also port TabContentsFactory.

Review URL: http://codereview.chromium.org/21496
------------------------------------------------------------------------
r10004 | evan@chromium.org | 2009-02-19 04:37:12 +0100 (Thu, 19 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/status_bubble_gtk.cc
   A /trunk/src/chrome/browser/gtk/status_bubble_gtk.h
   M /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Super-simplistic status bubble on Linux.

(I just want to see when pages are loading, y'know...)

Review URL: http://codereview.chromium.org/21500
------------------------------------------------------------------------
r10003 | estade@chromium.org | 2009-02-19 03:57:32 +0100 (Thu, 19 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.h

Fix gcc 4.3 build break.

TBR=agl

Review URL: http://codereview.chromium.org/21499
------------------------------------------------------------------------
r10001 | hbono@chromium.org | 2009-02-19 03:36:36 +0100 (Thu, 19 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/views/label_unittest.cc

Changes line endings from CRLF to LF and add svn:eol-style to LF.

No code changes. This change just changes the CRLF line endings found by your change to make your change work on Mac and Linux trybots.
Review URL: http://codereview.chromium.org/21445
------------------------------------------------------------------------
r10000 | erikkay@google.com | 2009-02-19 02:26:13 +0100 (Thu, 19 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Support controlling extensions with a pref in addition to command-line.

Review URL: http://codereview.chromium.org/20481
------------------------------------------------------------------------
r9999 | estade@chromium.org | 2009-02-19 02:19:34 +0100 (Thu, 19 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_item.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Bring up save_package, save_item, save_file_manager on posix.

Review URL: http://codereview.chromium.org/20479
------------------------------------------------------------------------
r9998 | sky@google.com | 2009-02-19 01:58:45 +0100 (Thu, 19 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Disables dragging of imgs in recently closed window section.

BUG=5836
TEST=see bug

Review URL: http://codereview.chromium.org/21490
------------------------------------------------------------------------
r9997 | dkegel@google.com | 2009-02-19 01:48:06 +0100 (Thu, 19 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/unittest_test_server.h

Revert 9992, as it broke origin-header-for-https.html on Webkit Linux builder

Review URL: http://codereview.chromium.org/21488
------------------------------------------------------------------------
r9996 | paul@chromium.org | 2009-02-19 01:25:23 +0100 (Thu, 19 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Bring the SafeBrowsingProtocolManager out of scaffolding.
Review URL: http://codereview.chromium.org/20480
------------------------------------------------------------------------
r9995 | jar@chromium.org | 2009-02-19 01:20:20 +0100 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc

Protect dictionary fetch operation in shutdown scenario.

In a shutdown scenario, the default context may already be nulled out,
and hence we need to avoid trying to get dictionaries at that late
juncture.

r=darin
Review URL: http://codereview.chromium.org/21462
------------------------------------------------------------------------
r9994 | jhawkins@chromium.org | 2009-02-19 01:06:22 +0100 (Thu, 19 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/perf/perftests.scons

Make safe_browsing_blocking_page.cc compile on Posix.
Review URL: http://codereview.chromium.org/21480
------------------------------------------------------------------------
r9993 | tc@google.com | 2009-02-19 00:56:35 +0100 (Thu, 19 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc

Add menu shortcuts on linux instead of & everywhere.

Review URL: http://codereview.chromium.org/21486

------------------------------------------------------------------------
r9992 | dkegel@google.com | 2009-02-19 00:42:36 +0100 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/unittest_test_server.h

Undo revert http://codereview.chromium.org/23028
Changes since original http://codereview.chromium.org/16207 :
- use Release rather than delete on reference counted objects
- Preserve bool WaitToFinish(int milliseconds) 
  and std::wstring GetDataDirectory() at Tommi's request,
  and add unit test for WaitToFinish().

Review URL: http://codereview.chromium.org/20444
------------------------------------------------------------------------
r9991 | sky@google.com | 2009-02-19 00:30:19 +0100 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/test/data/purify/ui_tests.gtest.txt

Renables the session restore ui tests in hopes of finding out why they
are flakey. I'll watch the bot to see where they are failing after
landing. Also fixes leaks in the tests I noticed when run under Purify.

BUG=6495
TEST=none

Review URL: http://codereview.chromium.org/20477
------------------------------------------------------------------------
r9988 | estade@chromium.org | 2009-02-18 23:47:28 +0100 (Wed, 18 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

Fix save complete .html page.

BUG=7616

Review URL: http://codereview.chromium.org/21482
------------------------------------------------------------------------
r9986 | estade@chromium.org | 2009-02-18 23:39:31 +0100 (Wed, 18 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_item.cc
   M /trunk/src/chrome/browser/download/save_item.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_types.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/dom_serializer.h
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc

Prepare some files for porting:

- Trade in some old wstrings for FilePaths.
- Remove some unnecessary headers.

Review URL: http://codereview.chromium.org/21466
------------------------------------------------------------------------
r9983 | estade@chromium.org | 2009-02-18 23:30:16 +0100 (Wed, 18 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   A /trunk/src/chrome/browser/back_forward_menu_model_win.cc
   A /trunk/src/chrome/browser/back_forward_menu_model_win.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.cc
   A /trunk/src/chrome/browser/gtk/back_forward_menu_model_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/menu_gtk.cc
   M /trunk/src/chrome/browser/gtk/menu_gtk.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Port back_forward_menu_model to linux.

* Refactor BackForwardMenuModel.
 - Create platform-specific subclasses that implement menu delegate interfaces
 - Push almost all functionality into BackForwardMenuModel
* Implement GTK back/forward dropdowns (in MenuGtk and BrowserToolbarViewGtk)

Review URL: http://codereview.chromium.org/21440
------------------------------------------------------------------------
r9982 | pkasting@chromium.org | 2009-02-18 23:26:53 +0100 (Wed, 18 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/test_browser_window.h

Fix two problems with bookmarking and fullscreen mode:
* The bubble didn't close when toggling in/out of fullscreen mode.  This was because we only ever closed on an activation change, rather than on a window move.  Made the bubble close when the window moves.  This required refactoring the bubble code to have a static instance; once I did that I also cleaned up the rest of the code a bit to not check if the bubble was already showing, and just let the bookmark bubble itself take care of this.
* The bubble positioning was wrong in fullscreen mode.  This was because the toolbar layout was in turn wrong in fullscreen mode.  Made the toolbars able to handle being 0-height.

BUG=534
TEST=Bookmark a page and hit F11.  The bubble should disappear.  Hit ctrl-D.  The bubble should appear at the right spot, not floating in the middle of the screen.  Hit F11 again.  The bubble should disappear, and the toolbar button should be drawn undepressed.
Review URL: http://codereview.chromium.org/21479
------------------------------------------------------------------------
r9980 | evan@chromium.org | 2009-02-18 23:04:28 +0100 (Wed, 18 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/process_singleton.h
   A /trunk/src/chrome/browser/process_singleton_linux.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Implement skeletal ProcessSingleton on Linux to cut down on NOTIMPLEMENTED()s.

We now will refuse to run a second browser process if one is already running;
making the second invocation bring up new windows in the first remains left to
be implemented.

Review URL: http://codereview.chromium.org/20448

------------------------------------------------------------------------
r9974 | sky@google.com | 2009-02-18 22:56:32 +0100 (Wed, 18 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info.cc

Changes tab dragging code to continue iterating through windows if
window's rect contains the point but the window region doesn't. This
is necessary as some apps create a window the size of the desktop
and set a window region on it. Without this check we don't allow
docking when these apps are running.

BUG=6149
TEST=see bug

Review URL: http://codereview.chromium.org/21476
------------------------------------------------------------------------
r9973 | pinkerton@chromium.org | 2009-02-18 22:51:39 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_controller.mm

Fix window close and application quit on Mac to call the proper Browser machinery in the proper order. Add comments to BrowserWindow::Close to stress its assumptions. DCHECK that nobody adds a NULL browser to the browser list.
Review URL: http://codereview.chromium.org/20460
------------------------------------------------------------------------
r9971 | jhawkins@chromium.org | 2009-02-18 22:43:00 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/views/window_delegate.h

Make interstitial_page.cc compile on Posix.
Review URL: http://codereview.chromium.org/21467
------------------------------------------------------------------------
r9969 | pkasting@chromium.org | 2009-02-18 22:38:19 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Clean up toolbar layout code.  I originally did this while looking into bookmark bubble positioning issues.
Review URL: http://codereview.chromium.org/20467
------------------------------------------------------------------------
r9968 | paulg@google.com | 2009-02-18 22:38:08 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

Add the referrer value to the new NavigationEntry.
Review URL: http://codereview.chromium.org/21464
------------------------------------------------------------------------
r9967 | sky@google.com | 2009-02-18 22:37:45 +0100 (Wed, 18 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h

Fixes drag of images from new tab page. We need to pass in the mime
type, otherwise webkit isn't able to get the mime type and we try and
drag an image with a bogus name.

BUG=none
TEST=drag a thumbnail from the new tab to explorer. You should end up
     with a file named foo.png.

Review URL: http://codereview.chromium.org/21435
------------------------------------------------------------------------
r9959 | maruel@chromium.org | 2009-02-18 21:06:13 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc

Build break. In revision 9958, I hadn't intented to commit this change.
Review URL: http://codereview.chromium.org/20466
------------------------------------------------------------------------
r9958 | maruel@chromium.org | 2009-02-18 20:47:21 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/base/atomic_ref_count.h
   M /trunk/src/base/ref_counted.h
   M /trunk/src/base/revocable_store.h
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs_win.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/plugin.vcproj
   M /trunk/src/media/base/buffers.h
   A /trunk/src/net/base/client_socket.cc
   M /trunk/src/net/base/client_socket.h
   A /trunk/src/net/base/io_buffer.cc
   M /trunk/src/net/base/io_buffer.h
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/build/net.vcproj
   A /trunk/src/net/disk_cache/addr.cc
   M /trunk/src/net/disk_cache/addr.h
   M /trunk/src/net/disk_cache/rankings.h
   M /trunk/src/net/disk_cache/storage_block-inl.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_transaction.cc
   A /trunk/src/net/http/http_response_info.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/url_request/mime_sniffer_proxy.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_error_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_filter.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_simple_job.cc
   M /trunk/src/net/url_request/url_request_simple_job.h
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/net/url_request/url_request_view_cache_job.cc
   M /trunk/src/net/url_request/url_request_view_cache_job.h
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.cc
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/feed_preview.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   A /trunk/src/webkit/glue/resource_loader_bridge.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/webdatasource.h
   M /trunk/src/webkit/glue/webdatasource_impl.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webhistoryitem.h
   M /trunk/src/webkit/glue/webhistoryitem_impl.h
   A /trunk/src/webkit/glue/webplugin_delegate.cc
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webresponse.h
   M /trunk/src/webkit/glue/webresponse_impl.h
   M /trunk/src/webkit/glue/weburlrequest.h
   M /trunk/src/webkit/glue/weburlrequest_impl.cc
   M /trunk/src/webkit/glue/weburlrequest_impl.h
   A /trunk/src/webkit/glue/webview_delegate.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/webkit.xcodeproj/project.pbxproj

Reduce the amount of included header files. Vast change like in "Oh God! This revision changes half of the source files!".
Review URL: http://codereview.chromium.org/20378
------------------------------------------------------------------------
r9956 | tc@google.com | 2009-02-18 20:10:58 +0100 (Wed, 18 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_strings.scons
   M /trunk/src/chrome/app/chrome_strings.vcproj
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   D /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_bn.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_gu.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_kn.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_ml.rc
   M /trunk/src/chrome/app/resources/locale_settings_mr.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_or.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_ta.rc
   M /trunk/src/chrome/app/resources/locale_settings_te.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/chrome.xcodeproj/generate_headers.sh
   M /trunk/src/chrome/common/gfx/chrome_font_win.cc

Add locale_settings.grd to the build.  This generates
a locale_settings.h file that we use on all platforms.  However,
the rc generation isn't correct yet, so for now, use the existing
locale_settings_*.rc files.

Also go ahead and generate the en-US locale pak on linux.

Review URL: http://codereview.chromium.org/20447
------------------------------------------------------------------------
r9955 | tc@google.com | 2009-02-18 20:02:12 +0100 (Wed, 18 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

fix linux build, add stub functions to browser window gtk

Review URL: http://codereview.chromium.org/21463

------------------------------------------------------------------------
r9954 | pkasting@chromium.org | 2009-02-18 20:00:50 +0100 (Wed, 18 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm

Stub more Mac functions to fix another build break

TBR=pinkerton
Review URL: http://codereview.chromium.org/20463
------------------------------------------------------------------------
r9953 | idanan@chromium.org | 2009-02-18 19:55:46 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h

Solved 2 bugs which caused Chrome to maximize itself whendouble clicking, either on the new tab button, on the closetab button or on a single tab.BUG=2827BUG=3787The problem comes from the Windows event sequence upon adouble-click (simplified here):1 - hit-test2 - mouse-down4 - mouse-up/click5 - hit-test6 - mouse down7 - mouse up/double-clickThe 1st hit-test is always performed correctly, returningclient for tabs and non-client for the tab-strip (background).The 2nd hit test is not performed correctly to avoid crashesin Chromebot from events being processed while tabs are animating.Since we have no record of these crashes, Ben prefers we keepthis special-case, even though we are responding incorrectlyto the windows hit-test. So, when the tabs are animating wereturn a HTNOWHERE hit which the caller translates into anHTCAPTION hit. This even though a tab-control (new-tab/close-tab)may have been hit.The problem is that having returned HTCAPTION to Windows defaultmessage handling, we get a NON-CLIENT double-click event insteadof a standard one.To keep the behavior of the second hit-test AND prevent theChrome window from maximizing, this change simply declaresthe non-client double-click as handled when the tabs areanimating.Another trick we pulled in the hit-test is to return HTCAPTIONwhen a single tab is present. This allows the entire window to be dragged but causes the context menu to be wrong and the windowto maximize when double clicking on the single tab.The solution here is to correct return a client hit for a singletab and, upon handling a client single-click, delegate to thenon-client single-click default handler.
Review URL: http://codereview.chromium.org/21268
------------------------------------------------------------------------
r9950 | pkasting@chromium.org | 2009-02-18 19:49:00 +0100 (Wed, 18 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/test/test_browser_window.h

Preliminary fullscreen mode support.

There is no UI for this (yet), just F11 to toggle in and out.

BUG=534
Review URL: http://codereview.chromium.org/20423
------------------------------------------------------------------------
r9947 | yurys@google.com | 2009-02-18 18:12:12 +0100 (Wed, 18 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   D /trunk/src/chrome/browser/debugger/tools_contents.cc
   D /trunk/src/chrome/browser/debugger/tools_contents.h
   D /trunk/src/chrome/browser/debugger/tools_view.cc
   D /trunk/src/chrome/browser/debugger/tools_view.h
   D /trunk/src/chrome/browser/debugger/tools_window.cc
   D /trunk/src/chrome/browser/debugger/tools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   D /trunk/src/chrome/renderer/tools_agent.cc
   D /trunk/src/chrome/renderer/tools_agent.h
   D /trunk/src/chrome/renderer/tools_client.cc
   D /trunk/src/chrome/renderer/tools_client.h
   D /trunk/src/chrome/renderer/tools_messages.h
   M /trunk/src/webkit/glue/glue.vcproj
   D /trunk/src/webkit/glue/tools_proxy.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Reverting 9944.

This change broke ui, interactive and Vista Perf tests. I felt like reverting.
Review URL: http://codereview.chromium.org/24020
------------------------------------------------------------------------
r9944 | yurys@google.com | 2009-02-18 17:17:21 +0100 (Wed, 18 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/tools_contents.cc
   A /trunk/src/chrome/browser/debugger/tools_contents.h
   A /trunk/src/chrome/browser/debugger/tools_view.cc
   A /trunk/src/chrome/browser/debugger/tools_view.h
   A /trunk/src/chrome/browser/debugger/tools_window.cc
   A /trunk/src/chrome/browser/debugger/tools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/renderer/tools_agent.cc
   A /trunk/src/chrome/renderer/tools_agent.h
   A /trunk/src/chrome/renderer/tools_client.cc
   A /trunk/src/chrome/renderer/tools_client.h
   A /trunk/src/chrome/renderer/tools_messages.h
   M /trunk/src/webkit/glue/glue.vcproj
   A /trunk/src/webkit/glue/tools_proxy.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Create communication channel between developer tools UI implemented in JS and residing in a process different from inspected page renderer process. There is no direct IPC channel between the two processes so all messages are routed through browser process.

On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object. 

On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI.

This change is a slightly modified version of http://codereview.chromium.org/20221/show
Review URL: http://codereview.chromium.org/20430
------------------------------------------------------------------------
r9935 | jam@chromium.org | 2009-02-18 04:47:48 +0100 (Wed, 18 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   A /trunk/src/chrome/common/child_process_host.cc
   A /trunk/src/chrome/common/child_process_host.h
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj

Take out common functionality from PluginProcessHost and move it to ChildProcessHost.

Review URL: http://codereview.chromium.org/21443
------------------------------------------------------------------------
r9930 | erg@google.com | 2009-02-18 02:15:31 +0100 (Wed, 18 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Display the current URL and connect the entry widget to OpenURLFromTab().

This currently crashes when trying to load a new URL. (It looks like some housekeeping isn't being done in RenderWidgetHostViewGtk, the underlying widget isn't attached to any GTK window...)

Review URL: http://codereview.chromium.org/21438

------------------------------------------------------------------------
r9926 | evan@chromium.org | 2009-02-18 01:52:01 +0100 (Wed, 18 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/process_singleton.cc
   A /trunk/src/chrome/browser/process_singleton_win.cc (from /trunk/src/chrome/browser/process_singleton.cc:9923)

Follow-up rename to my previous commit.

process_singleton.cc can just become process_singleton_win.cc since it's all Windows-specific.

Review URL: http://codereview.chromium.org/20442

------------------------------------------------------------------------
r9925 | jcampan@chromium.org | 2009-02-18 01:46:20 +0100 (Wed, 18 Feb 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/new_profile_dialog.cc
   M /trunk/src/chrome/browser/views/new_profile_dialog.h
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/select_profile_dialog.cc
   M /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/dialog_delegate.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view.h
   M /trunk/src/chrome/views/window_delegate.h

HtmlDialogs had focus problems.
They would not be focused when shown and tab traversal was not working.

This was caused by several issues:
- HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default.
- DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab.
- DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view).

Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method.

BUG=6859
TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields

Review URL: http://codereview.chromium.org/21439
------------------------------------------------------------------------
r9923 | evan@chromium.org | 2009-02-18 01:34:21 +0100 (Wed, 18 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/message_window.cc
   D /trunk/src/chrome/browser/message_window.h
   A /trunk/src/chrome/browser/process_singleton.cc (from /trunk/src/chrome/browser/message_window.cc:9922)
   A /trunk/src/chrome/browser/process_singleton.h (from /trunk/src/chrome/browser/message_window.h:9922)
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Rename MessageWindow to ProcessSingleton in anticipation of more refactoring.

Review URL: http://codereview.chromium.org/20437

------------------------------------------------------------------------
r9918 | jhawkins@chromium.org | 2009-02-18 00:32:51 +0100 (Wed, 18 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make gears_integration.cc compile on Posix.  Change the GearsCreateShortcut callback to use GearsShortCutData2.
Review URL: http://codereview.chromium.org/20412
------------------------------------------------------------------------
r9917 | brettw@chromium.org | 2009-02-18 00:29:25 +0100 (Wed, 18 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.cc

Check the file handle for NULL before using it to write. Under some
circumstances this might be NULL if we opened the file after initialization and
it failed. In this case, we should just silently fail rather than throwing
an invalid parameter exception.

I'm not 100% sure this will fix the bug below, I did this by inspection.

BUG=7566
Review URL: http://codereview.chromium.org/21425
------------------------------------------------------------------------
r9916 | cpu@google.com | 2009-02-18 00:05:41 +0100 (Wed, 18 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Fix crasher in GetDefaultSearchEngineName() in first run bubble.
- It seems that BrowserList::GetLastActive() is returning null, probably it takes longer now for the browser to become active.
- But rather than guessing the profile, get it from the guts of the location bar.
- crasher is ranked #34 by Laforge

BUG=6211

Review URL: http://codereview.chromium.org/20381
------------------------------------------------------------------------
r9915 | brettw@chromium.org | 2009-02-18 00:01:12 +0100 (Wed, 18 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Fix a memory leak of the renderer thread objects in single process mode.

BUG=6538
Review URL: http://codereview.chromium.org/21432
------------------------------------------------------------------------
r9914 | thestig@chromium.org | 2009-02-17 23:56:03 +0100 (Tue, 17 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Add importer/firefox_profile_lock_posix.cc to the build.
Review URL: http://codereview.chromium.org/21427
------------------------------------------------------------------------
r9912 | jar@chromium.org | 2009-02-17 23:50:14 +0100 (Tue, 17 Feb 2009) | 18 lines
Changed paths:
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Persist info about subresources on pages for DNS pre-resolution

The DNS pre-resolution system already "learns" what domains are commonly
needed when rendering sub-resources of a page at a given domain.
This patch saves (some of) the information learned into a persistent
pref, and restores it on startup.

For now, I put in a wimpy pruning of the list each time I save, so that
the list will not grow endlessly from session to session.  I probably need
a better pruning algorithm, such as one that prunes after a given amount
of time, rather than only during shutdown.  For now, this should get
a lot of nice results, and provide slightly larger than needed lists to
users that have long lived sessions, which is similar to the current 
performance, where I didn't persist any info, and only pruned (actually
discarded) all learned info at shutdown.

r=mbelshe
Review URL: http://codereview.chromium.org/21374
------------------------------------------------------------------------
r9911 | tc@google.com | 2009-02-17 23:43:02 +0100 (Tue, 17 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/common/resource_bundle.cc
   M /trunk/src/chrome/common/resource_bundle_linux.cc

Hook up theme images and chrome resource data on linux.

Go ahead and convert our toolbar buttons to using the theme data
pack file.

Review URL: http://codereview.chromium.org/20433

------------------------------------------------------------------------
r9909 | aa@chromium.org | 2009-02-17 23:30:21 +0100 (Tue, 17 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/test/data/extensions/bad
   A /trunk/src/chrome/test/data/extensions/bad/invalid_manifest
   A /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/1
   A /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/1/manifest.json (from /trunk/src/chrome/test/data/extensions/invalid_manifest/manifest.json:9908)
   A /trunk/src/chrome/test/data/extensions/bad/invalid_manifest/Current Version
   A /trunk/src/chrome/test/data/extensions/bad/no_manifest
   A /trunk/src/chrome/test/data/extensions/bad/no_manifest/1
   A /trunk/src/chrome/test/data/extensions/bad/no_manifest/1/not_a_manifest (from /trunk/src/chrome/test/data/extensions/no_manifest/not_a_manifest:9908)
   A /trunk/src/chrome/test/data/extensions/bad/no_manifest/Current Version
   A /trunk/src/chrome/test/data/extensions/bad/no_version
   A /trunk/src/chrome/test/data/extensions/bad/no_version/git_abhors_empty_dirs
   D /trunk/src/chrome/test/data/extensions/extension1/manifest.json
   D /trunk/src/chrome/test/data/extensions/extension2/manifest.json
   D /trunk/src/chrome/test/data/extensions/extension3/1.0/manifest.json
   D /trunk/src/chrome/test/data/extensions/extension3/Current Version
   A /trunk/src/chrome/test/data/extensions/good
   A /trunk/src/chrome/test/data/extensions/good/extension1
   A /trunk/src/chrome/test/data/extensions/good/extension1/1
   A /trunk/src/chrome/test/data/extensions/good/extension1/1/manifest.json (from /trunk/src/chrome/test/data/extensions/extension1/manifest.json:9908)
   A /trunk/src/chrome/test/data/extensions/good/extension1/Current Version
   A /trunk/src/chrome/test/data/extensions/good/extension2
   A /trunk/src/chrome/test/data/extensions/good/extension2/2
   A /trunk/src/chrome/test/data/extensions/good/extension2/2/manifest.json (from /trunk/src/chrome/test/data/extensions/extension2/manifest.json:9908)
   A /trunk/src/chrome/test/data/extensions/good/extension2/Current Version
   A /trunk/src/chrome/test/data/extensions/good/extension3
   A /trunk/src/chrome/test/data/extensions/good/extension3/1.0
   A /trunk/src/chrome/test/data/extensions/good/extension3/1.0/manifest.json (from /trunk/src/chrome/test/data/extensions/extension3/1.0/manifest.json:9908)
   A /trunk/src/chrome/test/data/extensions/good/extension3/Current
   A /trunk/src/chrome/test/data/extensions/good/extension3/Current Version (from /trunk/src/chrome/test/data/extensions/extension3/Current Version:9908)
   D /trunk/src/chrome/test/data/extensions/invalid_manifest/manifest.json
   D /trunk/src/chrome/test/data/extensions/no_manifest/not_a_manifest

Do two TODOs related to --load-extension:
* Stop watching extension dirs for user script changes.
* Stop supporting unversioned extension dirs.

Also a few minor related cleanups.

Review URL: http://codereview.chromium.org/20390
------------------------------------------------------------------------
r9908 | pinkerton@chromium.org | 2009-02-17 23:13:19 +0100 (Tue, 17 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove TabContentsDelegate from scaffolding. Remove a large chunk of ifdef'd code from browser.cc to go along with it as well as enabling more functionality.
Review URL: http://codereview.chromium.org/21424
------------------------------------------------------------------------
r9907 | sky@google.com | 2009-02-17 23:07:03 +0100 (Tue, 17 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Changes new tab page to not make a link for recently closed
windows. It was rather bogus that we were doing this before as there
is nothing for the window to link to.

BUG=5836
TEST=see bug

Review URL: http://codereview.chromium.org/21426
------------------------------------------------------------------------
r9905 | avi@chromium.org | 2009-02-17 23:04:50 +0100 (Tue, 17 Feb 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/base_view.h (from /trunk/src/chrome/browser/cocoa/event_view.h:9875)
   A /trunk/src/chrome/browser/cocoa/base_view.mm (from /trunk/src/chrome/browser/cocoa/event_view.mm:9875)
   D /trunk/src/chrome/browser/cocoa/event_view.h
   D /trunk/src/chrome/browser/cocoa/event_view.mm
   M /trunk/src/chrome/browser/cocoa/sad_tab_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Significantly rework coordinate handling for the Cocoa views. Fixes tons of redraw and scrolling issues.

Review URL: http://codereview.chromium.org/20435
------------------------------------------------------------------------
r9903 | evan@chromium.org | 2009-02-17 22:40:15 +0100 (Tue, 17 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc

Keyboard focus mostly works on Linux.

I added more TODOs than I removed, but they're now for more subtle cases:
 - the web page didn't handle a keystroke and our accelerators should;
 - you tab off the end of the list of tabbable things on the page.

Review URL: http://codereview.chromium.org/21428

------------------------------------------------------------------------
r9902 | pinkerton@chromium.org | 2009-02-17 21:44:37 +0100 (Tue, 17 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm

Default to using the current tab when opening a url until we hook up more advanced gestures. Returning to create a new tab is just wrong.
Review URL: http://codereview.chromium.org/20434
------------------------------------------------------------------------
r9901 | jungshik@google.com | 2009-02-17 21:44:34 +0100 (Tue, 17 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Change the encoding for tapuz.co.il to UTF-8 from windows-1255 and update the version to 20.

BUG=7271
TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" and set the default 
search engine to tapuz (it's in Hebrew) and type a keyword in the omnibox and select search with 'tapuz'.
Search result should come up with multiple hits. 

Review URL: http://codereview.chromium.org/20315
------------------------------------------------------------------------
r9899 | avi@chromium.org | 2009-02-17 21:19:48 +0100 (Tue, 17 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc

Registering the AutoFill manager because someone added it to the build without registering its prefs.

Review URL: http://codereview.chromium.org/20431
------------------------------------------------------------------------
r9898 | evan@chromium.org | 2009-02-17 20:47:15 +0100 (Tue, 17 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk/nine_box.cc
   A /trunk/src/chrome/browser/gtk/nine_box.h

Make the toolbar background themed on Linux.

Add a class for managing images for scalable themed widgets, and then
implement the toolbar on top of this.

Review URL: http://codereview.chromium.org/21390

------------------------------------------------------------------------
r9893 | erg@google.com | 2009-02-17 20:02:45 +0100 (Tue, 17 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/menu_gtk.cc
   A /trunk/src/chrome/browser/gtk/menu_gtk.h
   A /trunk/src/chrome/browser/gtk/standard_menus.cc
   A /trunk/src/chrome/browser/gtk/standard_menus.h

Create a menu wrapper class for GTK menus, and use it for the page and app menus.

Review URL: http://codereview.chromium.org/20245

------------------------------------------------------------------------
r9892 | pinkerton@chromium.org | 2009-02-17 19:54:23 +0100 (Tue, 17 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Unstub some more of the Browser object, including the part that sets it as the delegate of the TabContents object. That allows page-load notifications to make their way through the browser UI layer. Hook up notification to Mac tab strip to set the title as it's changed.
Review URL: http://codereview.chromium.org/20429
------------------------------------------------------------------------
r9887 | tc@google.com | 2009-02-17 19:03:27 +0100 (Tue, 17 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   A /trunk/src/chrome/browser/browser_main_gtk.cc (from /trunk/src/chrome/browser/gtk/browser_main_gtk.cc:9881)
   D /trunk/src/chrome/browser/gtk/browser_main_gtk.cc

put browser_main_gtk.cc next to other browser_main* cc files.

Review URL: http://codereview.chromium.org/21418

------------------------------------------------------------------------
r9884 | pkasting@chromium.org | 2009-02-17 18:47:01 +0100 (Tue, 17 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm

Stub a function for Mac to get it to compile with my recent change.

TBR=pinkerton
Review URL: http://codereview.chromium.org/20424
------------------------------------------------------------------------
r9883 | pkasting@chromium.org | 2009-02-17 18:40:41 +0100 (Tue, 17 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Add stub for GTK to get it to build with my recent change.

TBR=tony
Review URL: http://codereview.chromium.org/21416
------------------------------------------------------------------------
r9882 | pkasting@chromium.org | 2009-02-17 18:33:13 +0100 (Tue, 17 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tab_contents/native_ui_contents.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

When internal functions try to focus the location bar, check whether it's focusable, and clear the focus if it's not.  This shouldn't kick in in any cases today (I don't think), but it will matter in fullscreen mode, where creating a new tab should not attempt to focus the (unfocusable) location bar, but should not do nothing either, since these leaves focus in a hosed state.

There are other choices here.  I could make View::RequestFocus() try and clear the focus if the view is not focusable.  That seems likely to cause side-effects unless I restore a lot of the calls to IsFocusable() that I previously removed.  I also don't know whether sticking this on BrowserWindow was the right approach; if there's a better spot architecturally, speak up.
Review URL: http://codereview.chromium.org/21368
------------------------------------------------------------------------
r9879 | avi@chromium.org | 2009-02-17 17:52:30 +0100 (Tue, 17 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Fixes resizing. (The content will still be scaled a bit until the roundtrip happens.)

Review URL: http://codereview.chromium.org/21415
------------------------------------------------------------------------
r9876 | avi@chromium.org | 2009-02-17 17:01:15 +0100 (Tue, 17 Feb 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/sad_tab_view.h
   A /trunk/src/chrome/browser/cocoa/sad_tab_view.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Sad Tab view for the Mac.

Review URL: http://codereview.chromium.org/20334
------------------------------------------------------------------------
r9874 | pinkerton@chromium.org | 2009-02-17 15:45:03 +0100 (Tue, 17 Feb 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/app/theme/starred.pdf
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Implement SetStarredState on LocationBar for Mac.
Review URL: http://codereview.chromium.org/21317
------------------------------------------------------------------------
r9872 | hclam@chromium.org | 2009-02-17 07:28:08 +0100 (Tue, 17 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h

Add render view id to AudioRendererHost
AudioRendererHost were assigning ids in the browser process, that means
CreateStream has to be done in a synchronous IPC call. To avoid that we
allow renderer processes to provide the stream id when they do
CreateStrea. Then to identify a IPCAudioSource inside AudioRendererHost
we need a tuple of (render_view_id, stream_id). By doing this we can
create stream asynchronously just like BeginRequest in
ResourceDispatcherHost.

Review URL: http://codereview.chromium.org/21319
------------------------------------------------------------------------
r9864 | hclam@chromium.org | 2009-02-16 22:52:32 +0100 (Mon, 16 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/DEPS
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/media/audio/audio_output.h

IPC messages definitions for audio related requests from
renderer to browser.
Defined IPC messages that maps to methods exposed by
AudioRendererHost that serves audio related requests.
Also with handlers in ResourceMessageFilter for the newly
added IPC messages.

Review URL: http://codereview.chromium.org/21340
------------------------------------------------------------------------
r9862 | hclam@chromium.org | 2009-02-16 21:59:26 +0100 (Mon, 16 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/media/audio/audio_output.h

Revert r9861 to fix build
TBR=?

Review URL: http://codereview.chromium.org/21399
------------------------------------------------------------------------
r9861 | hclam@chromium.org | 2009-02-16 21:32:41 +0100 (Mon, 16 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/media/audio/audio_output.h

IPC messages definitions for audio related requests from
renderer to browser.
Defined IPC messages that maps to methods exposed by
AudioRendererHost that serves audio related requests.
Also with handlers in ResourceMessageFilter for the newly
added IPC messages.

Review URL: http://codereview.chromium.org/21340
------------------------------------------------------------------------
r9857 | evan@chromium.org | 2009-02-16 17:59:05 +0100 (Mon, 16 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Call RegisterURLRequestChromeJob on browser startup for Linux and Mac.
Without this, ChromeURLDataManager::RemoveFileSource triggers a DCHECK for
the "inspector" source since that's being called during shutdown lately.

Review URL: http://codereview.chromium.org/20399
Patch from Craig Schlenter <craig.schlenter@gmail.com>.

------------------------------------------------------------------------
r9856 | maruel@chromium.org | 2009-02-16 16:01:45 +0100 (Mon, 16 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   D /trunk/src/chrome/browser/debugger/tools_contents.cc
   D /trunk/src/chrome/browser/debugger/tools_contents.h
   D /trunk/src/chrome/browser/debugger/tools_view.cc
   D /trunk/src/chrome/browser/debugger/tools_view.h
   D /trunk/src/chrome/browser/debugger/tools_window.cc
   D /trunk/src/chrome/browser/debugger/tools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   D /trunk/src/chrome/renderer/tools_agent.cc
   D /trunk/src/chrome/renderer/tools_agent.h
   D /trunk/src/chrome/renderer/tools_client.cc
   D /trunk/src/chrome/renderer/tools_client.h
   D /trunk/src/chrome/renderer/tools_messages.h
   M /trunk/src/chrome/views/window_delegate.h
   M /trunk/src/webkit/glue/glue.vcproj
   D /trunk/src/webkit/glue/tools_proxy.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Reverting 9855.

This change didn't have any description and it broke the tree
Review URL: http://codereview.chromium.org/21393
------------------------------------------------------------------------
r9855 | yurys@google.com | 2009-02-16 15:12:53 +0100 (Mon, 16 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/tools_contents.cc
   A /trunk/src/chrome/browser/debugger/tools_contents.h
   A /trunk/src/chrome/browser/debugger/tools_view.cc
   A /trunk/src/chrome/browser/debugger/tools_view.h
   A /trunk/src/chrome/browser/debugger/tools_window.cc
   A /trunk/src/chrome/browser/debugger/tools_window.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/renderer/tools_agent.cc
   A /trunk/src/chrome/renderer/tools_agent.h
   A /trunk/src/chrome/renderer/tools_client.cc
   A /trunk/src/chrome/renderer/tools_client.h
   A /trunk/src/chrome/renderer/tools_messages.h
   M /trunk/src/chrome/views/window_delegate.h
   M /trunk/src/webkit/glue/glue.vcproj
   A /trunk/src/webkit/glue/tools_proxy.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h


Review URL: http://codereview.chromium.org/20405
------------------------------------------------------------------------
r9853 | phajdan.jr@chromium.org | 2009-02-16 12:09:12 +0100 (Mon, 16 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc

Platform cleanup in autocomplete unit tests.

Review URL: http://codereview.chromium.org/21353
------------------------------------------------------------------------
r9850 | evan@chromium.org | 2009-02-16 08:00:37 +0100 (Mon, 16 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc

Register some more prefs on startup, now that their modules work.

------------------------------------------------------------------------
r9849 | evanm@google.com | 2009-02-16 07:32:45 +0100 (Mon, 16 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc

Register PasswordManager prefs for Mac and Linux.

Review URL: http://codereview.chromium.org/20392
Patch from Craig Schlenter <craig.schlenter@gmail.com>.

------------------------------------------------------------------------
r9848 | jhawkins@chromium.org | 2009-02-16 06:28:06 +0100 (Mon, 16 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make browser_shudown.cc compile on Posix.  This is r9835 with a fix for the mac build.
Review URL: http://codereview.chromium.org/20393
------------------------------------------------------------------------
r9840 | mal@chromium.org | 2009-02-15 08:33:02 +0100 (Sun, 15 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Rollback r9835 and r9837: Mac build broken.

r9835: Make browser_shutdown.cc compile on Posix.
Review URL: http://codereview.chromium.org/20384

r9837: Fix the mac build.  Add a stubbed ResourceBundle::CleanupSharedInstance.
Review URL: http://codereview.chromium.org/20387

TBR= jhawkins

Review URL: http://codereview.chromium.org/21385
------------------------------------------------------------------------
r9835 | jhawkins@chromium.org | 2009-02-15 03:40:26 +0100 (Sun, 15 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make browser_shutdown.cc compile on Posix.
Review URL: http://codereview.chromium.org/20384
------------------------------------------------------------------------
r9833 | jhawkins@chromium.org | 2009-02-15 02:48:40 +0100 (Sun, 15 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make password_manager.cc compile on Posix.
Review URL: http://codereview.chromium.org/20383
------------------------------------------------------------------------
r9831 | jhawkins@chromium.org | 2009-02-15 01:31:13 +0100 (Sun, 15 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_url_handler.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Make browser_url_handler.cc compile on Posix.
Review URL: http://codereview.chromium.org/21380
------------------------------------------------------------------------
r9830 | estade@chromium.org | 2009-02-15 01:09:42 +0100 (Sun, 15 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc

Clean up some includes in sessions/ directory.

Review URL: http://codereview.chromium.org/21379
------------------------------------------------------------------------
r9829 | jhawkins@chromium.org | 2009-02-15 00:27:27 +0100 (Sun, 15 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/base_session_service.cc

Use the ALLOW_THIS_IN_INITIALIZER_LIST instead of a pragma.

R=dank
Review URL: http://codereview.chromium.org/21378
------------------------------------------------------------------------
r9828 | jhawkins@chromium.org | 2009-02-15 00:19:47 +0100 (Sun, 15 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make base_session_service.cc compile on Posix.
Review URL: http://codereview.chromium.org/21377
------------------------------------------------------------------------
r9827 | dkegel@google.com | 2009-02-15 00:14:35 +0100 (Sun, 15 Feb 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/unittest_test_server.h

Reverting r9823 (http://codereview.chromium.org/16207) because 

1) the Interactive Tests (dbg) buildbot needs the SSL cert installed

2) the same buildbot showed a refcounting problem, e.g. 
FATAL:ref_counted.cc(22)] Check failed: in_dtor_. RefCounted object deleted without calling Release()
c:\b\slave\chromium-dbg-builder\build\src\chrome\browser\views\find_bar_win_interactive_uitest.cc(57): error: Value of: NULL != server.get()
  Actual: false
Expected: true
[  FAILED  ] FindInPageTest.CrashEscHandlers (2109 ms)

3) the Webkit Linux buildbot failed four tests
 redirect302-frames.html cross-frame-access-protocol-explicit-domain.html
 cross-frame-access-protocol.html origin-header-for-https.html

I'm leaving the tcp_pinger files in for the moment, they shouldn't hurt anything.

Review URL: http://codereview.chromium.org/23028
------------------------------------------------------------------------
r9826 | jhawkins@chromium.org | 2009-02-14 23:53:35 +0100 (Sat, 14 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make session_restore.cc compile on Posix.
Review URL: http://codereview.chromium.org/21376
------------------------------------------------------------------------
r9825 | hclam@chromium.org | 2009-02-14 20:55:48 +0100 (Sat, 14 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h

Rollback my change that seems to break some tests.
TBR

Review URL: http://codereview.chromium.org/21375
------------------------------------------------------------------------
r9824 | hclam@chromium.org | 2009-02-14 07:36:58 +0100 (Sat, 14 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h

Add render view id to AudioRendererHost
AudioRendererHost were assigning ids in the browser process, that means
CreateStream has to be done in a synchronous IPC call. To avoid that we
allow renderer processes to provide the stream id when they do
CreateStrea. Then to identify a IPCAudioSource inside AudioRendererHost
we need a tuple of (render_view_id, stream_id). By doing this we can
create stream asynchronously just like BeginRequest in
ResourceDispatcherHost.

Review URL: http://codereview.chromium.org/21319
------------------------------------------------------------------------
r9823 | dkegel@google.com | 2009-02-14 06:26:10 +0100 (Sat, 14 Feb 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   A /trunk/src/net/base/tcp_pinger.h
   A /trunk/src/net/base/tcp_pinger_unittest.cc
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/unittest_test_server.h

ssl_client_socket_unittest.cc: launch local server with TestServerLauncher 
rather than use bugs.webkit.org, fixes TODO(darin)
Add tests with bad server certs

ssl_client_socket_nss.cc: fix bugs revealed by new tests

tcp_pinger.cc: helper class to do synchronous connect from tests.
Has to work inside ui tests where one can't use TestCompletionCallback.

ssl_test_util: renamed class TestServerLauncher, added Start/Stop methods.
Make part of net.lib to work around link error in test_shell_tests.

url_request_unittest.h: use TestServerLauncher to manage server.

SSL client tests disabled for now on Mac.

BUG=7114
Review URL: http://codereview.chromium.org/16207
------------------------------------------------------------------------
r9822 | aa@chromium.org | 2009-02-14 05:15:16 +0100 (Sat, 14 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/common/extensions/user_script.cc
   M /trunk/src/chrome/common/extensions/user_script.h
   M /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Add early-injection capability to user scripts.

Review URL: http://codereview.chromium.org/19624
------------------------------------------------------------------------
r9821 | aa@chromium.org | 2009-02-14 05:09:51 +0100 (Sat, 14 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc

Add chrome-extension to the list of "web-safe" schemes for
resource loading. This makes web pages able to refer to
resources inside extensions.

Review URL: http://codereview.chromium.org/20371
------------------------------------------------------------------------
r9820 | maruel@chromium.org | 2009-02-14 03:33:16 +0100 (Sat, 14 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/browser/browser_window_factory.mm
   M /trunk/src/chrome/browser/navigation_entry_unittest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc

NO CODE CHANGE.

Set svn:eol-style=LF

------------------------------------------------------------------------
r9811 | jhawkins@chromium.org | 2009-02-14 02:33:02 +0100 (Sat, 14 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.h
   M /trunk/src/chrome/browser/sessions/session_backend.cc
   M /trunk/src/chrome/browser/sessions/session_backend.h
   M /trunk/src/chrome/browser/sessions/session_backend_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Port session_backend.cc to Posix.

* Using FilePath for paths instead of wstring.
* File operations using cross-platform FileStream instead of win32 API.

Review URL: http://codereview.chromium.org/20327
------------------------------------------------------------------------
r9809 | estade@chromium.org | 2009-02-14 02:20:41 +0100 (Sat, 14 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/net/base/mime_util.cc
   M /trunk/src/net/base/mime_util.h
   M /trunk/src/net/base/mime_util_unittest.cc
   M /trunk/src/net/base/platform_mime_util.h
   M /trunk/src/net/base/platform_mime_util_linux.cc
   M /trunk/src/net/base/platform_mime_util_mac.cc
   M /trunk/src/net/base/platform_mime_util_win.cc
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/plugins/plugin_stream.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Change mime type utils to operate on platform-specific string types for filenames/file extensions.

Review URL: http://codereview.chromium.org/21327
------------------------------------------------------------------------
r9808 | estade@chromium.org | 2009-02-14 02:20:24 +0100 (Sat, 14 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Build alternate_nav_url_fetcher.cc on posix

Review URL: http://codereview.chromium.org/24018
------------------------------------------------------------------------
r9807 | maruel@chromium.org | 2009-02-14 01:47:23 +0100 (Sat, 14 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Disable the printing UI tests again :(

BUG=7721

Review URL: http://codereview.chromium.org/21372
------------------------------------------------------------------------
r9804 | jam@chromium.org | 2009-02-14 00:16:42 +0100 (Sat, 14 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/common/child_process_info.cc
   M /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/debug_flags.cc
   M /trunk/src/chrome/common/debug_flags.h
   M /trunk/src/chrome/test/ui/ui_test.cc

Have ChildProcessInfo contain a list of all running child processes (i.e. instead of Service and other child process service maintain it).  In a future change I'll start moving some of the code from PluginProcessHost to ChildProcessInfo.
Review URL: http://codereview.chromium.org/24017
------------------------------------------------------------------------
r9800 | ananta@chromium.org | 2009-02-13 23:43:28 +0100 (Fri, 13 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Enabling the BrowsersRememberFocus interactive UI test. The fix is to change the
AutomationMsg_ActivateWindow and AutomationMsg_OpenNewBrowserWindow automation messages 
to sync messages.

Review URL: http://codereview.chromium.org/20363
------------------------------------------------------------------------
r9799 | pkasting@chromium.org | 2009-02-13 23:39:52 +0100 (Fri, 13 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Cleanup in preparation for Fullscreen mode.

* Remove some unnecessary cruft from BrowserView.

* Change Find bar to position itself based on the translated bounds of the bookmark bar or toolbar, whichever is found.  This is a bit simpler than the offset-based version before and works much better with Fullscreen mode.

* Make Bookmark bar not have a strange "1 px" minimum size, which was only needed because we were always subtracting that much in the BrowserView layout functions.

* Change BrowserView toolbar layout functions to always lay out toolbars (instead of only when visible; they are 0-height when invisible), and explicitly set their visibility.  This shouldn't have any visible effect, but it goes hand-in-hand with the Find bar changes.

* Add a function on the Bookmark bar to determine if we're displaying detached, and change various callers to use it.  Right now this does fairly little, but in Fullscreen mode it becomes necessary because we always display the Bookmark bar this way.  There is one user-visible effect: when toggling the Bookmark bar on/off while the Find bar is visible, the Find bar will now snap to the Bookmark bar only when it finishes "attaching" to the toolbar, not as soon as it starts.  Finnur and I both think this actually looks slightly better.
Review URL: http://codereview.chromium.org/21359
------------------------------------------------------------------------
r9791 | cpu@google.com | 2009-02-13 21:52:18 +0100 (Fri, 13 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/gtk/browser_main_gtk.cc

Small cleanup of DoUninstallTasks()
- eliminates one #ifdef
- Did I mention is cleaner?


Review URL: http://codereview.chromium.org/21331
------------------------------------------------------------------------
r9790 | erikkay@google.com | 2009-02-13 21:51:20 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

Put up a dialog for extension load and install errors.  (this is temporary until we get a more permanent location for errors)


Review URL: http://codereview.chromium.org/20366
------------------------------------------------------------------------
r9789 | mpcomplete@google.com | 2009-02-13 21:48:39 +0100 (Fri, 13 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_util.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h

Fix a crash bug in memory_utils.cc caused by assuming that the
RenderViewHost's delegate is a WebContents.
Review URL: http://codereview.chromium.org/23025
------------------------------------------------------------------------
r9788 | tc@google.com | 2009-02-13 21:35:20 +0100 (Fri, 13 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd

Set the line endings to grd files as LF in the tree.  Leave
the svn:eol-style property as blank. This should allow
the try servers to apply patches.

TBR=glen
Review URL: http://codereview.chromium.org/20370
------------------------------------------------------------------------
r9785 | estade@chromium.org | 2009-02-13 21:25:14 +0100 (Fri, 13 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h

Hook up browser cursors on linux.

Review URL: http://codereview.chromium.org/21358
------------------------------------------------------------------------
r9784 | tc@google.com | 2009-02-13 21:19:59 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/chrome_resources.vcproj
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   A /trunk/src/chrome/browser/debugger/resources/debugger_resources.grd
   D /trunk/src/chrome/browser/debugger/resources/debugger_resources.h
   D /trunk/src/chrome/browser/debugger/resources/debugger_resources.rc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome.xcodeproj/generate_headers.sh
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/common_resources.grd
   D /trunk/src/chrome/common/common_resources.h
   D /trunk/src/chrome/common/common_resources.rc
   M /trunk/src/chrome/common/jstemplate_builder.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/renderer/renderer_resources.grd
   D /trunk/src/chrome/renderer/renderer_resources.h
   D /trunk/src/chrome/renderer/renderer_resources.rc
   M /trunk/src/chrome/renderer/user_script_slave.cc

Port remaining .rc data resource files to grd.  This includes
debugger_resources.rc, common_resources.rc, and renderer_resources.rc.

Review URL: http://codereview.chromium.org/21307
------------------------------------------------------------------------
r9777 | idanan@google.com | 2009-02-13 20:28:53 +0100 (Fri, 13 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Originally this change was intended as the solution to accidentally maximizing Chrome by double-clicking on the new tab button. This solution does work but another one is being coded for a more general problem. This change solves also the accidental maximizing of Chrome when double-clicking the close tab button except on the last tab (rightmost in LTR systems). See issue 2827 for further details.This change removes a band-aid which did not perform a hit-test on the tab-strip while it is animating in order to avoid unknown chromebot crashes as reported by Ben. The removal of the fix makes the hit-test perform as expected.Trying this now, at Peter's suggestion, so that we can measure and diagnose potential problems hidden by the said band-aid.

[NOTE]
Revied and approved as http://codereview.chromium.org/20329
by Peter kasting. Had to copy changes to repo where I have
commit rights.
------------------------------------------------------------------------
r9776 | thestig@chromium.org | 2009-02-13 20:25:45 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc

Add debugger_shell to the POSIX build.

Reviewed in issue 20321. Got reverted, but was not the cause of the debugger test failure.
Review URL: http://codereview.chromium.org/21355
------------------------------------------------------------------------
r9774 | tc@google.com | 2009-02-13 20:23:36 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

add infobar_delegate.cc to the build

Review URL: http://codereview.chromium.org/20341

------------------------------------------------------------------------
r9768 | estade@chromium.org | 2009-02-13 19:44:19 +0100 (Fri, 13 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc

Fix an off-by-one error in posix backing store scrolling.

This error (sometimes) caused a crash when scrolling all the way to the bottom of a page and then attempting to scroll back up.

Review URL: http://codereview.chromium.org/20361
------------------------------------------------------------------------
r9766 | pkasting@chromium.org | 2009-02-13 19:40:10 +0100 (Fri, 13 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Make system menus show up at the right place for all frames, whether they're triggered by clicking the window icon or hitting alt-space.  Make clicking the icon for windows without a non-client view (e.g. the Bookmark Manager on Aero Glass) bring up the system menu.

Clean up more dead code, verbose code, or unnecessary statics/members.

TEST=Right-click titlebars, hit alt-space, and left-click window icons (where present), for:
* Main window
* Dialogs, e.g. the bookmark manager
* Popups
* App windows
When right-clicking, a system menu should appear at the cursor.  For the other cases, a system menu should appear at the system native location (roughly just below the titlebar).
Review URL: http://codereview.chromium.org/20225
------------------------------------------------------------------------
r9765 | pkasting@chromium.org | 2009-02-13 19:27:38 +0100 (Fri, 13 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/view.cc

Don't focus unfocusable things.
Review URL: http://codereview.chromium.org/20348
------------------------------------------------------------------------
r9764 | pkasting@chromium.org | 2009-02-13 19:11:55 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h

Make some functions const.  This will help with my fullscreen mode changes.

The only tricky bit here is how GetBookmarkBarView() is no longer guaranteed to return non-NULL.  The only caller of this is the automation framework, in one place, which explicitly NULL-checks the result and does the right thing, so there should not be any problems.
Review URL: http://codereview.chromium.org/23026
------------------------------------------------------------------------
r9763 | avi@chromium.org | 2009-02-13 19:07:44 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc

Register Metrics prefs for Mac and Linux.

http://codereview.chromium.org/20350

------------------------------------------------------------------------
r9756 | joshia@google.com | 2009-02-13 17:59:22 +0100 (Fri, 13 Feb 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc

Check for hung plugin windows before detaching them

The process of detaching plugin windows from tab window
involves windows messages across browser and plugin process.
If the pungin process is hung this hangs the browser 
shutdown sequence. 

This workaround first checks if the plugin is responsive
before detaching its window from the tab. If a plugin is
hung, it's window would not be detached (and would be
destroyed with the tab window). 

The side effect of not detaching is that some plugins
expect their window to be valid until they get NPAPI 
shut down notifications and may crash if those 
notifications were sent after the window was destroyed.
But since the plugin is hung anyway, we can go ahead
not detaching the window. Plugin process will be 
cleaned up later.

BUG=3613



Review URL: http://codereview.chromium.org/20301
------------------------------------------------------------------------
r9751 | phajdan.jr@chromium.org | 2009-02-13 15:41:55 +0100 (Fri, 13 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_unittest.cc

Platform cleanup in chrome/browser/history/history_unittest.cc.

Review URL: http://codereview.chromium.org/21314
------------------------------------------------------------------------
r9749 | abarth@chromium.org | 2009-02-13 11:04:35 +0100 (Fri, 13 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/ssl/ssl_host_state.cc (from /trunk/src/chrome/browser/ssl/ssl_host_state.cc:9747)
   A /trunk/src/chrome/browser/ssl/ssl_host_state.h (from /trunk/src/chrome/browser/ssl/ssl_host_state.h:9747)
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/testing_profile.h

Remember that we've white listed a certificate when we switch to a new tab.

R=wtc
BUG=6456

------------------------------------------------------------------------
r9748 | abarth@chromium.org | 2009-02-13 09:48:30 +0100 (Fri, 13 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   D /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   D /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Revert 9747
------------------------------------------------------------------------
r9747 | abarth@chromium.org | 2009-02-13 09:34:46 +0100 (Fri, 13 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/ssl/ssl_host_state.cc
   A /trunk/src/chrome/browser/ssl/ssl_host_state.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Remember that we've white listed a certificate when we switch to a new tab.

R=wtc
BUG=6456

Review URL: http://codereview.chromium.org/20296
------------------------------------------------------------------------
r9744 | tommi@chromium.org | 2009-02-13 06:15:26 +0100 (Fri, 13 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Fixing reverse tabbing.

Review URL: http://codereview.chromium.org/21341
------------------------------------------------------------------------
r9730 | thestig@chromium.org | 2009-02-13 02:52:48 +0100 (Fri, 13 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add TableModel to the scaffold, so we don't depend on views.
Review URL: http://codereview.chromium.org/21315
------------------------------------------------------------------------
r9726 | pkasting@chromium.org | 2009-02-13 02:47:10 +0100 (Fri, 13 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

Try and make the GetXXXBounds() functions share more code to be shorter, and change a name to make it a bit clearer.  No user-visible change.
Review URL: http://codereview.chromium.org/21332
------------------------------------------------------------------------
r9724 | evan@chromium.org | 2009-02-13 02:44:07 +0100 (Fri, 13 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fewer NOTIMPLEMENTED()s, more comments.

------------------------------------------------------------------------
r9723 | evan@chromium.org | 2009-02-13 02:44:03 +0100 (Fri, 13 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Remove a NOTIMPLEMENTED().  It's obviously wrong and we will be revisiting
it with plugins anyway.

------------------------------------------------------------------------
r9722 | evan@chromium.org | 2009-02-13 02:43:59 +0100 (Fri, 13 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/common/l10n_util.cc

Relocate a NOTIMPLEMENTED() to its proper place.

------------------------------------------------------------------------
r9721 | paul@chromium.org | 2009-02-13 02:36:50 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Fix build break.

TBR=evan

------------------------------------------------------------------------
r9720 | paul@chromium.org | 2009-02-13 02:25:50 +0100 (Fri, 13 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/load_notification_details.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Port most of MetricsService to Mac and linux.
Review URL: http://codereview.chromium.org/20338
------------------------------------------------------------------------
r9717 | thestig@chromium.org | 2009-02-13 01:49:00 +0100 (Fri, 13 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc

Reverting 9706. Hopefully this will fix the broken debugger_test.
Review URL: http://codereview.chromium.org/21329
------------------------------------------------------------------------
r9716 | evan@chromium.org | 2009-02-13 01:40:41 +0100 (Fri, 13 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/l10n_util.cc

Fix tiny fonts in Mac/Linux.  Tony deserves credit for this.

Review URL: http://codereview.chromium.org/21323

------------------------------------------------------------------------
r9707 | thestig@chromium.org | 2009-02-12 22:11:13 +0100 (Thu, 12 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Remove firefox[23]_importer.cc from the POSIX build.

Another step in fixing the dynamic run.
Review URL: http://codereview.chromium.org/20323
------------------------------------------------------------------------
r9706 | thestig@chromium.org | 2009-02-12 22:11:05 +0100 (Thu, 12 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc

Add debugger_shell to the POSIX build.

Fixes static linking for the chrome executable on Linux.
Review URL: http://codereview.chromium.org/20321
------------------------------------------------------------------------
r9703 | estade@chromium.org | 2009-02-12 22:00:23 +0100 (Thu, 12 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Reapply of Tony's r9656 (Add chrome/browser/ssl/ssl_manager.cc to the build.)

Also port 2 more files in browser/ssl to posix

* ssl_policy
* ssl_blocking_page

Review URL: http://codereview.chromium.org/21297
------------------------------------------------------------------------
r9702 | avi@chromium.org | 2009-02-12 21:58:46 +0100 (Thu, 12 Feb 2009) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/event_view.h
   A /trunk/src/chrome/browser/cocoa/event_view.mm
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Pump events to the renderer. Doesn't work currently due to activation issues.

Review URL: http://codereview.chromium.org/21306
------------------------------------------------------------------------
r9701 | mpcomplete@google.com | 2009-02-12 21:57:54 +0100 (Thu, 12 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a --load-plugin flag to load an NPAPI plugin from an arbitrary location.
This is to support running Chromebot to exercise a given NPAPI plugin.
Review URL: http://codereview.chromium.org/21279
------------------------------------------------------------------------
r9697 | evan@chromium.org | 2009-02-12 21:34:02 +0100 (Thu, 12 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Use real URLFixerUpper.  Makes URLs on command line work.

Review URL: http://codereview.chromium.org/21303

------------------------------------------------------------------------
r9692 | maruel@chromium.org | 2009-02-12 20:49:04 +0100 (Thu, 12 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.cc
   M /trunk/src/webkit/glue/scoped_clipboard_writer_glue.h
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webplugin_delegate.h

Lots of small nits to help to split off webkit.dll.
- Stop directly referencing WebPluginDelegateImpl.
- Make the password manager to not allocation the data on heap.
- Remove some unneeded includes.
Review URL: http://codereview.chromium.org/20208
------------------------------------------------------------------------
r9689 | maruel@chromium.org | 2009-02-12 20:32:55 +0100 (Thu, 12 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Reenable tests disabled in r9262.
Review URL: http://codereview.chromium.org/20313
------------------------------------------------------------------------
r9686 | tc@google.com | 2009-02-12 20:29:05 +0100 (Thu, 12 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/browser_resources.grd

Have consistent line endings on .grd files (currently cr-lf since
that's what most of the lines are).

TBR=evanm

Review URL: http://codereview.chromium.org/21301
------------------------------------------------------------------------
r9685 | evan@chromium.org | 2009-02-12 20:23:05 +0100 (Thu, 12 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Port browser_about_handler. Some parts are still NOTIMPLEMENTED.

Review URL: http://codereview.chromium.org/20300
Patch from Craig Schlenter <craig.schlenter@gmail.com>.

------------------------------------------------------------------------
r9683 | evan@chromium.org | 2009-02-12 20:04:20 +0100 (Thu, 12 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/google_update_client.cc
   M /trunk/src/chrome/app/theme/theme_resources.grd
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/browser_resources.grd
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   M /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/installer/gcapi/gcapi.cc
   M /trunk/src/chrome/installer/gcapi/gcapi.h
   M /trunk/src/chrome/installer/gcapi/gcapi_dll.vcproj
   M /trunk/src/chrome/installer/gcapi/gcapi_lib.vcproj
   M /trunk/src/chrome/installer/gcapi/gcapi_test.cc
   M /trunk/src/chrome/installer/gcapi/gcapi_test.rc
   M /trunk/src/chrome/installer/gcapi/gcapi_test.vcproj
   M /trunk/src/chrome/installer/gcapi/resource.h
   M /trunk/src/chrome/installer/setup/eula/oem_ar.html
   M /trunk/src/chrome/installer/setup/eula/oem_bg.html
   M /trunk/src/chrome/installer/setup/eula/oem_ca.html
   M /trunk/src/chrome/installer/setup/eula/oem_cs.html
   M /trunk/src/chrome/installer/setup/eula/oem_da.html
   M /trunk/src/chrome/installer/setup/eula/oem_de.html
   M /trunk/src/chrome/installer/setup/eula/oem_el.html
   M /trunk/src/chrome/installer/setup/eula/oem_en-GB.html
   M /trunk/src/chrome/installer/setup/eula/oem_es-419.html
   M /trunk/src/chrome/installer/setup/eula/oem_es.html
   M /trunk/src/chrome/installer/setup/eula/oem_et.html
   M /trunk/src/chrome/installer/setup/eula/oem_fi.html
   M /trunk/src/chrome/installer/setup/eula/oem_fil.html
   M /trunk/src/chrome/installer/setup/eula/oem_fr.html
   M /trunk/src/chrome/installer/setup/eula/oem_hi.html
   M /trunk/src/chrome/installer/setup/eula/oem_hr.html
   M /trunk/src/chrome/installer/setup/eula/oem_hu.html
   M /trunk/src/chrome/installer/setup/eula/oem_id.html
   M /trunk/src/chrome/installer/setup/eula/oem_it.html
   M /trunk/src/chrome/installer/setup/eula/oem_iw.html
   M /trunk/src/chrome/installer/setup/eula/oem_ja.html
   M /trunk/src/chrome/installer/setup/eula/oem_ko.html
   M /trunk/src/chrome/installer/setup/eula/oem_lt.html
   M /trunk/src/chrome/installer/setup/eula/oem_lv.html
   M /trunk/src/chrome/installer/setup/eula/oem_nl.html
   M /trunk/src/chrome/installer/setup/eula/oem_no.html
   M /trunk/src/chrome/installer/setup/eula/oem_pl.html
   M /trunk/src/chrome/installer/setup/eula/oem_pt-BR.html
   M /trunk/src/chrome/installer/setup/eula/oem_pt-PT.html
   M /trunk/src/chrome/installer/setup/eula/oem_ro.html
   M /trunk/src/chrome/installer/setup/eula/oem_ru.html
   M /trunk/src/chrome/installer/setup/eula/oem_sk.html
   M /trunk/src/chrome/installer/setup/eula/oem_sl.html
   M /trunk/src/chrome/installer/setup/eula/oem_sr.html
   M /trunk/src/chrome/installer/setup/eula/oem_sv.html
   M /trunk/src/chrome/installer/setup/eula/oem_th.html
   M /trunk/src/chrome/installer/setup/eula/oem_tr.html
   M /trunk/src/chrome/installer/setup/eula/oem_uk.html
   M /trunk/src/chrome/installer/setup/eula/oem_vi.html
   M /trunk/src/chrome/installer/setup/eula/oem_zh-CN.html
   M /trunk/src/chrome/installer/setup/eula/oem_zh-TW.html
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/util/install_util.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate.h
   M /trunk/src/chrome/renderer/renderer_main_platform_delegate_win.cc
   M /trunk/src/chrome/test/data/extensions/extension1/manifest.json
   M /trunk/src/chrome/test/data/extensions/extension2/manifest.json
   M /trunk/src/chrome/test/data/nosniff-test.html
   M /trunk/src/chrome/test/data/nosniff-test.html.mock-http-headers

Remove the executable bit from a bunch of files that shouldn't have had it.

R=tony (looked over my shoulder before I committed)

------------------------------------------------------------------------
r9681 | avi@chromium.org | 2009-02-12 19:43:56 +0100 (Thu, 12 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm

IB outlets only get filled in during awakening, not initialization. D'oh!

Review URL: http://codereview.chromium.org/20302
------------------------------------------------------------------------
r9673 | pinkerton@chromium.org | 2009-02-12 19:05:11 +0100 (Thu, 12 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Implement UpdateToolbar from BrowserWindow on Mac without dragging in too much of the Omnibar code.
Review URL: http://codereview.chromium.org/20306
------------------------------------------------------------------------
r9672 | tc@google.com | 2009-02-12 19:04:26 +0100 (Thu, 12 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Revert "Add chrome/browser/ssl/ssl_manager.cc to the build."
This reverts commit 9656.

Review URL: http://codereview.chromium.org/20308

------------------------------------------------------------------------
r9671 | phajdan.jr@chromium.org | 2009-02-12 18:49:42 +0100 (Thu, 12 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Porting in chrome/

- make following unit tests compile and pass on Linux:
    browser/history/expire_history_backend_unittest.cc
    browser/history/history_backend_unittest.cc
    browser/history/history_querying_unittest.cc
    browser/history/starred_url_database_unittest.cc

- #include cleanup (less #ifdefs, more explicit deps)

Review URL: http://codereview.chromium.org/21247
------------------------------------------------------------------------
r9664 | tc@google.com | 2009-02-12 18:14:07 +0100 (Thu, 12 Feb 2009) | 22 lines
Changed paths:
   M /trunk/src/build/all.xcodeproj/project.pbxproj
   M /trunk/src/chrome/SConscript
   A /trunk/src/chrome/app/chrome_resources.vcproj (from /trunk/src/chrome/browser/resources/browser_resources.vcproj:9663)
   M /trunk/src/chrome/app/theme/SConscript
   D /trunk/src/chrome/app/theme/distribution_resources.rc
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   A /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/app/theme/theme_resources.h
   D /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/history_tab_ui.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   D /trunk/src/chrome/browser/resources/browser_resources.vcproj
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome.xcodeproj/generate_headers.sh
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/test/automation/automation.vsprops
   M /trunk/src/chrome/views/DEPS
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/tools/grit/build/grit_resource_file.bat
   M /trunk/src/tools/grit/build/grit_resources.rules
   M /trunk/src/tools/grit/grit/scons.py
   M /trunk/src/tools/grit/grit/tool/build.py

Second try of landing chrome_resources project.  Changes from last time:
- fix scons dependencies by adding a target for grit/theme_resources.h
- fix mac build by adding grit to unittest include path
- fix check deps by adding rules for /grit dir.

Create a chrome_resources.vcproj that holds grd files that hold
non-string resources.  Put browser_resources.grd into this vcproj.

Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.

I did a find/replace on the theme_resources include line.

Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner.  I'll migrate the others
in follow up patches.

theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.

Review URL: http://codereview.chromium.org/24011

------------------------------------------------------------------------
r9656 | tc@google.com | 2009-02-12 17:45:32 +0100 (Thu, 12 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add chrome/browser/ssl/ssl_manager.cc to the build.

Review URL: http://codereview.chromium.org/21275

------------------------------------------------------------------------
r9654 | mad@chromium.org | 2009-02-12 15:46:17 +0100 (Thu, 12 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/slide_animation.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/tools/test/smoketests.py
   D /trunk/src/chrome/views/resize_corner.cc
   D /trunk/src/chrome/views/resize_corner.h
   M /trunk/src/chrome/views/views.vcproj

This is an attempt at finding the reason for the page_cycler slowness caused by
the new resize corner. Local experiment led me to believe that it is WebKit
that is slower when we specify a resize corner area.

To validate this hypothesis, I always return an empty rect to WebKit, but I
still compute and push the rect to the render widget and I also draw the bitmap
even if this will cause it to be drawn on top of the scroll bars when there is
only one.

TBR=brettw

------------------------------------------------------------------------
r9651 | deanm@chromium.org | 2009-02-12 14:49:26 +0100 (Thu, 12 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Validate HWNDs that the renderer asks to be moved.

We make sure any window is a child of the render view window before moving it.

BUG=7590

Review URL: http://codereview.chromium.org/24012
------------------------------------------------------------------------
r9647 | thestig@chromium.org | 2009-02-12 05:53:51 +0100 (Thu, 12 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make fav_icon_helper compile on POSIX, remove some unneeded #includes.
Review URL: http://codereview.chromium.org/20286
------------------------------------------------------------------------
r9636 | hclam@chromium.org | 2009-02-12 02:56:58 +0100 (Thu, 12 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc

Fix a memory leak caused by AudioRenedererHost.

BUG=7608

AudioManager::CreateAudioManager() saves the instance in a static
variable and let it leak, so don't call it until there's a better
lifetime management of it.

Review URL: http://codereview.chromium.org/21277
------------------------------------------------------------------------
r9635 | estade@chromium.org | 2009-02-12 02:56:32 +0100 (Thu, 12 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_item.cc
   M /trunk/src/chrome/browser/download/save_item.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_types.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/dom_serializer.h
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc

Change url wstrings to GURLS

Review URL: http://codereview.chromium.org/20273
------------------------------------------------------------------------
r9634 | tc@google.com | 2009-02-12 02:28:58 +0100 (Thu, 12 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   D /trunk/src/chrome/app/chrome_resources.vcproj
   M /trunk/src/chrome/app/theme/SConscript
   A /trunk/src/chrome/app/theme/distribution_resources.rc
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   D /trunk/src/chrome/app/theme/theme_resources.grd
   A /trunk/src/chrome/app/theme/theme_resources.h
   A /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/history_tab_ui.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   A /trunk/src/chrome/browser/resources/browser_resources.vcproj (from /trunk/src/chrome/app/chrome_resources.vcproj:9632)
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome.xcodeproj/generate_headers.sh
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/test/automation/automation.vsprops
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/tools/grit/build/grit_resource_file.bat
   M /trunk/src/tools/grit/build/grit_resources.rules
   M /trunk/src/tools/grit/grit/tool/build.py

Revert "Create a chrome_resources.vcproj that holds grd files that hold"
This reverts commit r9631.
TBR=deanm

Review URL: http://codereview.chromium.org/23023

------------------------------------------------------------------------
r9632 | jhawkins@chromium.org | 2009-02-12 02:16:30 +0100 (Thu, 12 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make tab_restore_service.cc compile on Mac and Linux.
Review URL: http://codereview.chromium.org/23022
------------------------------------------------------------------------
r9631 | tc@google.com | 2009-02-12 02:15:32 +0100 (Thu, 12 Feb 2009) | 16 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   A /trunk/src/chrome/app/chrome_resources.vcproj (from /trunk/src/chrome/browser/resources/browser_resources.vcproj:9630)
   M /trunk/src/chrome/app/theme/SConscript
   D /trunk/src/chrome/app/theme/distribution_resources.rc
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   A /trunk/src/chrome/app/theme/theme_resources.grd
   D /trunk/src/chrome/app/theme/theme_resources.h
   D /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/history_tab_ui.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   D /trunk/src/chrome/browser/resources/browser_resources.vcproj
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/status_bubble_views.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome.xcodeproj/generate_headers.sh
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/test/automation/automation.vsprops
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/tools/grit/build/grit_resource_file.bat
   M /trunk/src/tools/grit/build/grit_resources.rules
   M /trunk/src/tools/grit/grit/tool/build.py

Create a chrome_resources.vcproj that holds grd files that hold
non-string resources.  Put browser_resources.grd into this vcproj.

Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.

I did a find/replace on the theme_resources include line.

Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner.  I'll migrate the others
in follow up patches.

theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.

Review URL: http://codereview.chromium.org/20247
------------------------------------------------------------------------
r9627 | evan@chromium.org | 2009-02-12 01:41:52 +0100 (Thu, 12 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h

Blind build fix?

------------------------------------------------------------------------
r9622 | evan@chromium.org | 2009-02-12 00:58:31 +0100 (Thu, 12 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.cc

Bring history.cc and dependents into the build.

Review URL: http://codereview.chromium.org/20284

------------------------------------------------------------------------
r9621 | jam@chromium.org | 2009-02-12 00:55:10 +0100 (Thu, 12 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/metrics/metrics_log.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   D /trunk/src/chrome/browser/plugin_process_info.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/resources/about_memory.html
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   A /trunk/src/chrome/common/child_process_info.cc
   A /trunk/src/chrome/common/child_process_info.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/notification_type.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Refactor plugin process code in the browser process so that the browser/about:memory/task manager/metrics code doesn't depend on PluginProcessHost pointers.  In a future changelist I'll add one central child process registry in the browser process.
Review URL: http://codereview.chromium.org/20196
------------------------------------------------------------------------
r9612 | paul@chromium.org | 2009-02-12 00:28:27 +0100 (Thu, 12 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Port CrossSiteResourceHandler to Mac and Linux.

(Was http://codereview.chromium.org/23019)

Review URL: http://codereview.chromium.org/20274
------------------------------------------------------------------------
r9608 | jhawkins@chromium.org | 2009-02-12 00:19:44 +0100 (Thu, 12 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.h

Make session_service.cc compile on Mac and Linux.
Review URL: http://codereview.chromium.org/23018
------------------------------------------------------------------------
r9601 | pinkerton@chromium.org | 2009-02-11 22:56:58 +0100 (Wed, 11 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Implement more of the TabContentsDelegate to hook up loading URLs from the location bar where there is UI to do so.
Review URL: http://codereview.chromium.org/21264
------------------------------------------------------------------------
r9597 | jar@chromium.org | 2009-02-11 22:37:04 +0100 (Wed, 11 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h

Fetch SDCH dictionary as soon as current URL fetch completes

Rather than just waiting for 15 seconds, this patch fetches the
"suggested dicitionary" as soon as the current download completes.
This avoids stealing bandwidth from the original download, but 
works as quickly as possible to get the dictionary, so that the
user can receive compression results asap.

r=wtc
Review URL: http://codereview.chromium.org/20254
------------------------------------------------------------------------
r9596 | evan@chromium.org | 2009-02-11 22:32:57 +0100 (Wed, 11 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.h
   M /trunk/src/chrome/browser/webdata/web_data_service.h

Remove final traces of IE from cross-platform password manager.

(It's still there for Windows, but not on other platforms.)

Review URL: http://codereview.chromium.org/21168

------------------------------------------------------------------------
r9595 | evan@chromium.org | 2009-02-11 22:32:29 +0100 (Wed, 11 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h

Fix some plugin-related NOTIMPLEMENTED()s in gtk Chrome.

We can sneak around not removing the NOTIMPLEMENTED()s completely by
implementing a function halfway -- if a page ends up needing a plugin
we'll get the NOTIMPLEMENTED() again.

With this change I no longer get repeated NOTIMPLEMENTED spew while
running.

Review URL: http://codereview.chromium.org/20264

------------------------------------------------------------------------
r9592 | ananta@chromium.org | 2009-02-11 22:06:57 +0100 (Wed, 11 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Changing the AutomationMsg_SavePackageShouldPromptUser message to a sync message
to fix the SavePage tests on Vista.

TBR=jam

Review URL: http://codereview.chromium.org/21265
------------------------------------------------------------------------
r9591 | ananta@chromium.org | 2009-02-11 21:57:11 +0100 (Wed, 11 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc

Disabling the BrowsersRememberFocus test in interactive ui tests to keep
the tree green, while I debug it.

TBR=nsylvain

Review URL: http://codereview.chromium.org/21260
------------------------------------------------------------------------
r9585 | ananta@chromium.org | 2009-02-11 20:14:56 +0100 (Wed, 11 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/constrained_window_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

The Chrome Automation framework is based on a homegrown request response IPC model and thus ends up duplicating a lot of functionality already available in the SyncChannel.

This CL gets the automation framework to use the SyncChannel. The request response IPCs have been changed to sync IPCs.

Review URL: http://codereview.chromium.org/20189
------------------------------------------------------------------------
r9583 | sidchat@google.com | 2009-02-11 20:03:21 +0100 (Wed, 11 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

Add a unit test to check that the extension is not repeated in a downloaded file name.

Issue=1503
Review URL: http://codereview.chromium.org/21257
------------------------------------------------------------------------
r9580 | agl@chromium.org | 2009-02-11 19:59:20 +0100 (Wed, 11 Feb 2009) | 19 lines
Changed paths:
   A /trunk/src/base/file_descriptor_posix.h
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/base/shared_memory_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   A /trunk/src/chrome/common/descriptor_set_posix.cc
   A /trunk/src/chrome/common/descriptor_set_posix.h
   D /trunk/src/chrome/common/file_descriptor_posix.cc
   D /trunk/src/chrome/common/file_descriptor_posix.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_channel_posix.h
   M /trunk/src/chrome/common/ipc_message.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_send_fds_test.cc
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread_unittest.cc

POSIX: Transfer network data using shared memory

This patch adds the long planned support for sharing memory on POSIX
by transporting file descriptors. It largely builds on the shared
memory cleanup work by jrg.

We move FileDescriptor out of chrome/common/file_descriptor_posix.h
and into base/file_descriptor_posix.h. Since all that's left in the
chrome/common verion is the DescriptorSet, those files are renamed to
descriptor_set.[h|cc].

The SharedMemoryHandle on POSIX then becomes a typedef to a
FileDescriptor and thus can be serialised over IPC.

After that, it's mostly a case of cleaning up those snippets of code
which considered SharedMemoryHandles to be scaler values.

Review URL: http://codereview.chromium.org/21208

------------------------------------------------------------------------
r9570 | jcampan@chromium.org | 2009-02-11 18:22:43 +0100 (Wed, 11 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/webkit/glue/autofill_form.cc

This CL ensures we don't store empty values in the autofill form DB.
Also it applies a clean-up to remove any empty values previously stored in the DB.

BUG=6111
TEST=Submit a form and leave some fields empty. Come back to that form, click on a field that was empty. No autofill popup should show up (or if one show up, it should not contains empty values).
Review URL: http://codereview.chromium.org/21217
------------------------------------------------------------------------
r9557 | jam@chromium.org | 2009-02-11 06:38:41 +0100 (Wed, 11 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message_macros.h

Redo my IPC change, undoing the linker dependency.
Review URL: http://codereview.chromium.org/21225
------------------------------------------------------------------------
r9552 | evan@chromium.org | 2009-02-11 04:29:16 +0100 (Wed, 11 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Handle tooltip message so we get fewer NOTIMPLEMENTED()s.

------------------------------------------------------------------------
r9551 | hclam@chromium.org | 2009-02-11 04:07:27 +0100 (Wed, 11 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   M /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/media/audio/audio_output.h
   A /trunk/src/media/audio/linux
   A /trunk/src/media/audio/linux/audio_manager_linux.cc
   A /trunk/src/media/audio/mac
   A /trunk/src/media/audio/mac/audio_manager_mac.cc
   M /trunk/src/media/media.xcodeproj/project.pbxproj
   M /trunk/src/media/media_lib.scons

Construct AudioRendererHost in BrowserRendererProcessHost, also construct
ResourceMessageFilter with pointer to it so we can delegate requests to it from IPC later.

Review URL: http://codereview.chromium.org/20131
------------------------------------------------------------------------
r9550 | estade@chromium.org | 2009-02-11 04:02:44 +0100 (Wed, 11 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/renderer/render_widget.cc

Implement browser scrolling on posix.

This code still has not been tested on nested scroll frames (e.g. webkit/data/test_shell/iframes/test1.html) because they don't render correctly yet. But it does work for scrolling horizontally and vertically on the main frame.

Review URL: http://codereview.chromium.org/20244
------------------------------------------------------------------------
r9548 | evan@chromium.org | 2009-02-11 03:36:37 +0100 (Wed, 11 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h

Draw custom buttons in toolbar.

The menu buttons aren't quite right yet, but the rest seem pretty good.

Review URL: http://codereview.chromium.org/20252

------------------------------------------------------------------------
r9547 | estade@chromium.org | 2009-02-11 03:19:22 +0100 (Wed, 11 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Port some strings in download/save_package.cc

Review URL: http://codereview.chromium.org/23004
------------------------------------------------------------------------
r9543 | patrick@chromium.org | 2009-02-11 02:39:07 +0100 (Wed, 11 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Fix a potential infinite loop in TabRestoreUITest.RestoreToDifferentWindow.

The variable tab_count is never changed inside the while loop.
Review URL: http://codereview.chromium.org/21200
------------------------------------------------------------------------
r9541 | rvargas@google.com | 2009-02-11 02:33:14 +0100 (Wed, 11 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc

Fix a browser crash when the URLRequestChromeJob goes away
from the NotifyReadComplete notification.

BUG=7485

Review URL: http://codereview.chromium.org/20162
------------------------------------------------------------------------
r9540 | rvargas@google.com | 2009-02-11 02:32:58 +0100 (Wed, 11 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/base/shared_memory.h
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc

Fix a browser crash when the async resource handler keeps an
IOBuffer after a failed attempt to send the data to a (now gone)
renderer. The shared memory section is unmapped so the buffer
must not be kept around and possibly re-used.

I'm also fixing a leak reported by purify.

BUG=7487
BUG=7374


Review URL: http://codereview.chromium.org/21222
------------------------------------------------------------------------
r9539 | shess@chromium.org | 2009-02-11 02:29:39 +0100 (Wed, 11 Feb 2009) | 17 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/gfx/rect_unittest.cc
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc

Unittest gardening on MacOS X:

 - base/gfx/rect_unittest.cc had a typo
 - base/waitable_event_watcher_unittest.cc enabled
 - chrome/common/pref_member_unittest.cc enabled
 - chrome/common/json_value_serializer_unittest.cc had a Windows-only
   bit which currently works fine on Mac.
 - These worked once an anonymous namespace was cleared up:
   chrome/browser/history/query_parser_unittest.cc
   chrome/browser/history/url_database_unittest.cc
   chrome/common/json_value_serializer_unittest.cc

Some
required minor editting to remove anonymous namespaces for test
classes.

Review URL: http://codereview.chromium.org/20241
------------------------------------------------------------------------
r9536 | ananta@chromium.org | 2009-02-11 01:39:37 +0100 (Wed, 11 Feb 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/message_window.cc

Maintain a refcounted AutomationProvider pointer in the ExternalTabContainer. This ensures that we don't crash the browser while trying to dereference a freed AutomationProvider pointer.

When a Chrome browser instance starts up, we attempt to locate an already running instance and defer to it to complete the navigation request. However it is quite possible for the running instance to exit while we attempt to send a WM_COPYDATA message to it. This caused a bunch
of ASSERTS to fire off in the browser. 

Fixes as below:-
1. If GetWindowThreadProcessId fails, we bail out and try to launch a new chrome instance
2. If SendMessageTimeout fails, we check if the window is still valid. If not we bail out and try to launch a new chrome instance.
3. We return an error from the WM_COPYDATA handler if the chrome instance is in the process of shutting down. We handle this at the caller end, i.e. in NotifyOtherProcess.

Bug=1643310

Review URL: http://codereview.chromium.org/23016
------------------------------------------------------------------------
r9533 | jhawkins@chromium.org | 2009-02-11 01:13:59 +0100 (Wed, 11 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make browsing_data_remover.cc compile on Mac and Linux.
Review URL: http://codereview.chromium.org/21232
------------------------------------------------------------------------
r9531 | estade@chromium.org | 2009-02-11 00:33:54 +0100 (Wed, 11 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Fill in more gtk callbacks in RenderWidgetHostViewGtk.

Mostly ripped directly from WebWidgetHostGtk.

Review URL: http://codereview.chromium.org/24009
------------------------------------------------------------------------
r9527 | jcampan@chromium.org | 2009-02-10 23:55:50 +0100 (Tue, 10 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc

Attempt at preventing a crasher.
In some cases TaskManagerResource can still be alive and pointing to a deleted WebContents, not sure how it can happen.
Now also listening for TabContent destruction notifications in case we are missing the WebContents one for some reason.

BUG=7321
Review URL: http://codereview.chromium.org/21233
------------------------------------------------------------------------
r9526 | aa@chromium.org | 2009-02-10 23:44:21 +0100 (Tue, 10 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Optionally support URLPatterns in standalone user
scripts via the @match declaration.

In the future, maybe @include will be deprecated
and result in a warning.

Review URL: http://codereview.chromium.org/20127
------------------------------------------------------------------------
r9522 | avi@chromium.org | 2009-02-10 23:35:30 +0100 (Tue, 10 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Turn on Mac cursor support now that we're already linking in the world.

Review URL: http://codereview.chromium.org/21227
------------------------------------------------------------------------
r9518 | ben@chromium.org | 2009-02-10 23:25:09 +0100 (Tue, 10 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Move opener/group relationship forgetting on navigation into TabStripModel from browser, and write unit tests for it.

Review URL: http://codereview.chromium.org/20233
------------------------------------------------------------------------
r9517 | kuchhal@chromium.org | 2009-02-10 23:07:09 +0100 (Tue, 10 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/slide_animation.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/test/test_browser_window.h
   A /trunk/src/chrome/views/resize_corner.cc (from /trunk/src/chrome/views/resize_corner.cc:9492)
   A /trunk/src/chrome/views/resize_corner.h (from /trunk/src/chrome/views/resize_corner.h:9492)
   M /trunk/src/chrome/views/views.vcproj

Reverting 9493.
Review URL: http://codereview.chromium.org/21231
------------------------------------------------------------------------
r9513 | jhawkins@chromium.org | 2009-02-10 22:01:06 +0100 (Tue, 10 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Make character_encoding.cc compile on Mac and Linux.
Review URL: http://codereview.chromium.org/21220
------------------------------------------------------------------------
r9512 | jam@chromium.org | 2009-02-10 21:53:34 +0100 (Tue, 10 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc

MovePluginWindows should always be called, even if suppress_view_updating_ is true.  This fixes a regression when the code got refactored.

BUG=7541
Review URL: http://codereview.chromium.org/20211
------------------------------------------------------------------------
r9507 | avi@chromium.org | 2009-02-10 21:32:06 +0100 (Tue, 10 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/native_ui_contents.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Switch from HWNDs to NativeViews, take 2. (First attempt was r9409, in which I missed a file.)

Review URL: http://codereview.chromium.org/20226
------------------------------------------------------------------------
r9506 | estade@chromium.org | 2009-02-10 21:31:30 +0100 (Tue, 10 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Do some more work on RenderWidgetHostViewGtk

* hook up mouse presses
* hook up resizes
* move gtk widget code into a container class (a la WebWidgetHostGtk)

Review URL: http://codereview.chromium.org/20230
------------------------------------------------------------------------
r9505 | sidchat@google.com | 2009-02-10 21:28:43 +0100 (Tue, 10 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc

Disable context menu item "Open image in new tab" from context menu for thumbnail images for Most Visited page.

Issue=2608

Review URL: http://codereview.chromium.org/24003
------------------------------------------------------------------------
r9501 | avi@chromium.org | 2009-02-10 21:13:54 +0100 (Tue, 10 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Switch the Mac accessor method name to match the GTK one (consistency is good).

Review URL: http://codereview.chromium.org/21221
------------------------------------------------------------------------
r9495 | paul@chromium.org | 2009-02-10 20:52:17 +0100 (Tue, 10 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove tab_util from scaffolding.
Review URL: http://codereview.chromium.org/20207
------------------------------------------------------------------------
r9494 | jam@chromium.org | 2009-02-10 20:38:55 +0100 (Tue, 10 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message_macros.h

revert my ipc change due to compile failure in debug ipc_tests

Review URL: http://codereview.chromium.org/20229
------------------------------------------------------------------------
r9493 | mad@chromium.org | 2009-02-10 20:18:15 +0100 (Tue, 10 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/slide_animation.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/test/test_browser_window.h
   D /trunk/src/chrome/views/resize_corner.cc
   D /trunk/src/chrome/views/resize_corner.h
   M /trunk/src/chrome/views/views.vcproj

Relanding of http://codereview.chromium.org/16488.
Adding proper project dependency in chrome.sln.

Review URL: http://codereview.chromium.org/21188
------------------------------------------------------------------------
r9492 | jam@chromium.org | 2009-02-10 20:14:33 +0100 (Tue, 10 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message_macros.h

Fix ipc logging for non browser processes.  I broke this in my last refactoring, since the logger functions only got registered in the browser.  This fix registers them using a global object for each message type (that's only compiled when debugging is enabled).  One less thing to take care of when creating new message types.
Review URL: http://codereview.chromium.org/20213
------------------------------------------------------------------------
r9490 | phajdan.jr@chromium.org | 2009-02-10 19:54:50 +0100 (Tue, 10 Feb 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/unit/unit_tests.scons

Porting unit tests in chrome/

- Make following unit tests compile and pass on Linux:
   browser/
    command_updater_unittest.cc
    metrics/metrics_log_unittest.cc
    search_engines/template_url_parser_unittest.cc
    search_engines/template_url_prepopulate_data_unittest.cc

- Add renderer/renderer_main_unittest.cc to list of compiled files (currently stubbed out on Linux)

- Remove DebuggerWrapper stubs and make more files from browser/debugger build on Linux.

- Sync XCode project file.

- Misc cleanups needed for GCC.

Review URL: http://codereview.chromium.org/21181
------------------------------------------------------------------------
r9487 | avi@chromium.org | 2009-02-10 19:51:58 +0100 (Tue, 10 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/TabContents.xib
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Hook views up.

Review URL: http://codereview.chromium.org/21212
------------------------------------------------------------------------
r9482 | kuchhal@chromium.org | 2009-02-10 19:32:38 +0100 (Tue, 10 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

fix compile failure
------------------------------------------------------------------------
r9481 | kuchhal@chromium.org | 2009-02-10 19:23:44 +0100 (Tue, 10 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Try reverting r9409 to see if it fixes crashes on chromebot.

TBR=avi
Review URL: http://codereview.chromium.org/21215
------------------------------------------------------------------------
r9478 | tommi@chromium.org | 2009-02-10 16:20:27 +0100 (Tue, 10 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Reapplying tab support (change 9388).  I synced and re-applied my change and found the automation tests not hanging.
I also took a look at the logs from the hanging buildbots and the reverted change didn't touch on any of the code that appeared to be hanging.
I also put breakpoints on the modified functions while running ui_tests.exe and nothing hit, so it looks like a fluke.

I did get a hang though when running an old build of ui_tests.exe with a new version of chrome.dll.
Is there any chance that there could have been a stale version on the build bots?

Review URL: http://codereview.chromium.org/20214
------------------------------------------------------------------------
r9476 | agl@chromium.org | 2009-02-10 10:41:25 +0100 (Tue, 10 Feb 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: fix crash in OnGetScreenInfo

In the ViewMsg_New, we pass a NativeViewId to the renderer. When
WebKit wishes to know the metrics of the window, it echos that id back
in a ViewHostMsg_GetScreenInfo. Without this patch, it echos back NULL
and the browser crashes.

This highlights a semi-major TODO for the porting effort at some
point. We need to abstract the NativeViewIds from the NativeViews as
we cannot trust pointer values from the renderers.

The conversion code is in base/gfx/native_widget_types.h and currently
just casts between them (which is correct for Windows, where both
typedefs are HWNDs). One, maybe interresting idea is that we could
generate a random secret key in the browser and HMAC sign the pointer
values.

------------------------------------------------------------------------
r9469 | agl@chromium.org | 2009-02-10 09:14:54 +0100 (Tue, 10 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Linux: fix uninited variable

------------------------------------------------------------------------
r9465 | agl@chromium.org | 2009-02-10 07:10:10 +0100 (Tue, 10 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Linux: porting effort

Commit a few cleanups from my tree before starting on getting async
resources working.

------------------------------------------------------------------------
r9457 | sky@google.com | 2009-02-10 05:15:43 +0100 (Tue, 10 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/common/notification_type.h

Adds some debugging code in hopes of isolating bug 6316. I suspect the
RVH is getting deleted some how and the RVHM isn't cleanly up
correctly.

BUG=6316
TEST=none

Review URL: http://codereview.chromium.org/20185
------------------------------------------------------------------------
r9451 | evan@chromium.org | 2009-02-10 04:45:01 +0100 (Tue, 10 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

#ifdef around a DCHECK in a Windows-specific code path.

------------------------------------------------------------------------
r9450 | estade@chromium.org | 2009-02-10 04:33:18 +0100 (Tue, 10 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc

Remove dead code from last commit.

------------------------------------------------------------------------
r9449 | estade@chromium.org | 2009-02-10 04:30:44 +0100 (Tue, 10 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h

Linux: save BrowserWindowGtk's vbox as a member variable

also update the WebContents display hack to not crash on startup

Review URL: http://codereview.chromium.org/21204
------------------------------------------------------------------------
r9448 | evan@chromium.org | 2009-02-10 04:25:40 +0100 (Tue, 10 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h

Re-check in some of my dynamic linking change.

We can't link in any more of these fixed .cc files because of a chain of
dependencies:
- temp_scaffolding_stubs defines the same symbols as these files
- removing the scaffolding pulls in more source
- pulling in that extra source breaks on Mac.

I have resigned myself to checking in this small bit.

------------------------------------------------------------------------
r9447 | evan@chromium.org | 2009-02-10 03:48:27 +0100 (Tue, 10 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Revert basically everything I've done today as it fails mysteriously
and I lack the patience to diagnose why mac doesn't link in libjpeg.

------------------------------------------------------------------------
r9445 | estade@chromium.org | 2009-02-10 03:17:23 +0100 (Tue, 10 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.cc
   M /trunk/src/chrome/browser/gtk/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_widget.cc

Get the renderer closer to rendering something on linux.

* implement some stubbed functions
* comment out some unimplemented IPC calls
* hack a webcontents widget into BrowserWindow so that something displays

Review URL: http://codereview.chromium.org/20204
------------------------------------------------------------------------
r9444 | evan@chromium.org | 2009-02-10 03:16:05 +0100 (Tue, 10 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Bring a bunch more headers into the non-Windows build:
 - history
 - autocomplete
 - bookmarks

These were all reviewed separately but turned out to be interdependent.  :~(

Review URL: http://codereview.chromium.org/21170

------------------------------------------------------------------------
r9443 | pkasting@chromium.org | 2009-02-10 02:57:46 +0100 (Tue, 10 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/views/non_client_view.h

Fix UI test regression, there's a better way to refactor this anyway.

TBR=glen
Review URL: http://codereview.chromium.org/24007
------------------------------------------------------------------------
r9438 | agl@chromium.org | 2009-02-10 01:52:14 +0100 (Tue, 10 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

POSIX: add command line option to launch renderers in a wrapper

For example, ./Hammer/chrome --renderer-cmd-prefix="gdb --args"

Review URL: http://codereview.chromium.org/21190

------------------------------------------------------------------------
r9433 | pkasting@chromium.org | 2009-02-09 23:48:03 +0100 (Mon, 09 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h

Make aero glass code look more like other nonclient views in hopes of easing refactoring.  More cleanup.  Change tabstrip layout to match opaque frame.

BUG=5054
Review URL: http://codereview.chromium.org/20161
------------------------------------------------------------------------
r9432 | avi@chromium.org | 2009-02-09 23:46:07 +0100 (Mon, 09 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm

Speling fix.

Review URL: http://codereview.chromium.org/21185
------------------------------------------------------------------------
r9429 | maruel@chromium.org | 2009-02-09 23:27:10 +0100 (Mon, 09 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc

NO CODE CHANGE. Fix EOL in autofill_manager.cc.

------------------------------------------------------------------------
r9421 | erg@google.com | 2009-02-09 23:02:55 +0100 (Mon, 09 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   D /trunk/src/chrome/browser/browser_main_gtk.cc
   D /trunk/src/chrome/browser/browser_window_factory_gtk.cc
   D /trunk/src/chrome/browser/browser_window_gtk.cc
   D /trunk/src/chrome/browser/browser_window_gtk.h
   A /trunk/src/chrome/browser/gtk
   A /trunk/src/chrome/browser/gtk/browser_main_gtk.cc (from /trunk/src/chrome/browser/browser_main_gtk.cc:9419)
   A /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.cc
   A /trunk/src/chrome/browser/gtk/browser_toolbar_view_gtk.h
   A /trunk/src/chrome/browser/gtk/browser_window_factory_gtk.cc (from /trunk/src/chrome/browser/browser_window_factory_gtk.cc:9419)
   A /trunk/src/chrome/browser/gtk/browser_window_gtk.cc (from /trunk/src/chrome/browser/browser_window_gtk.cc:9419)
   A /trunk/src/chrome/browser/gtk/browser_window_gtk.h (from /trunk/src/chrome/browser/browser_window_gtk.h:9419)

Porting the toolbar to GTK.

Quite a bit of TODOs in the code, but it displays and properly
enables/disables buttons and routes mouse clicks.

This also moves all the gtk files into the gtk/ folder, at Ben's request.

Review URL: http://codereview.chromium.org/21176

------------------------------------------------------------------------
r9419 | jrg@chromium.org | 2009-02-09 22:59:21 +0100 (Mon, 09 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Hook up the browser bar just a little bit more.
We now hit the TabContentsDelegate in temp_scaffolding_stubs.h.

Review URL: http://codereview.chromium.org/21178
------------------------------------------------------------------------
r9418 | tc@google.com | 2009-02-09 22:58:55 +0100 (Mon, 09 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   A /trunk/src/chrome/browser/browser_resources.grd
   D /trunk/src/chrome/browser/browser_resources.h
   D /trunk/src/chrome/browser/browser_resources.rc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/browser_resources.vcproj
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome.xcodeproj/generate_headers.sh
   M /trunk/src/chrome/chrome_kjs.sln
   D /trunk/src/chrome/tools/build/win/flattened_html_file.bat
   D /trunk/src/chrome/tools/build/win/flattened_html_file.rules
   D /trunk/src/chrome/tools/build/win/html_inline.py
   A /trunk/src/tools/grit/grit/format/html_inline.py (from /trunk/src/chrome/tools/build/win/html_inline.py:9417)
   M /trunk/src/tools/grit/grit/format/rc.py
   M /trunk/src/tools/grit/grit/node/include.py

Move browser_resources.rc into a a grd file.  While I'm at it,
I removed the flatten_html visual studio rule and just rolled the
functionality directly into GRIT.

The sln change is to have browser depend on browser_resources (now needed for browser_resources.h).

Review URL: http://codereview.chromium.org/21148
------------------------------------------------------------------------
r9415 | tc@google.com | 2009-02-09 22:53:55 +0100 (Mon, 09 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_gtk.cc

Revert "Linux build fix"
This reverts commit r9411.

Brett's revert requires this.

TBR=brettw

Review URL: http://codereview.chromium.org/20194

------------------------------------------------------------------------
r9414 | brettw@chromium.org | 2009-02-09 22:33:13 +0100 (Mon, 09 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/slide_animation.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/test/test_browser_window.h
   A /trunk/src/chrome/views/resize_corner.cc (from /trunk/src/chrome/views/resize_corner.cc:9407)
   A /trunk/src/chrome/views/resize_corner.h (from /trunk/src/chrome/views/resize_corner.h:9407)
   M /trunk/src/chrome/views/views.vcproj

Reverting 9408.
Review URL: http://codereview.chromium.org/20190
------------------------------------------------------------------------
r9413 | jhawkins@chromium.org | 2009-02-09 22:07:35 +0100 (Mon, 09 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_gtk.cc
   M /trunk/src/chrome/browser/browser_window_gtk.h

Add more state implementation to the BrowserWindowGtk object.  Window bounds and state are now tracked and configurable.
Review URL: http://codereview.chromium.org/21177
------------------------------------------------------------------------
r9411 | agl@chromium.org | 2009-02-09 21:31:16 +0100 (Mon, 09 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_gtk.cc

Linux build fix

TBR=mad

Review URL: http://codereview.chromium.org/20187

------------------------------------------------------------------------
r9409 | avi@chromium.org | 2009-02-09 21:20:47 +0100 (Mon, 09 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Switch from HWNDs to NativeViews.

Review URL: http://codereview.chromium.org/21143
------------------------------------------------------------------------
r9408 | mad@chromium.org | 2009-02-09 21:10:17 +0100 (Mon, 09 Feb 2009) | 31 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_gtk.cc
   M /trunk/src/chrome/browser/browser_window_gtk.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/slide_animation.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/test/test_browser_window.h
   D /trunk/src/chrome/views/resize_corner.cc
   D /trunk/src/chrome/views/resize_corner.h
   M /trunk/src/chrome/views/views.vcproj

Add a new resizer corner.

To display a resize bitmap and handle the mouse interactions as requested in
http://code.google.com/p/chromium/issues/detail?id=458.
BUG=458

There are unfortunately two cases to handle and they must be handled separately.
The first one is when there are no bottom shelf like the download bar,
and the case where there is one.

For the case without, we must draw on top of what we receive from WebKit,
so we intercept the bitmap in RenderWidgetHostViewWin::OnPaint() so that we
can draw the resize corner bitmap on top of it (taking into account whether
we are in a right to left language or not).

For the case where we have a bottom shelf, we use a dedicated view that we
properly layout on top of the bottom shelf view (which takes care of handling
the RTL language case for us).

Same split for the mouse interactions. Without the bottom shelf, we must deal
with it in RenderWidgetHostViewWin::OnMouseEvent() by sending the root window
a WM_NCLBUTTONDOWN message with either HTBOTTOMRIGHT or HTBOTTOMLEFT (based on
the RTL setting) and let the OS take care of the resizing. IF we have a bottom
shelf, we must deal with the mouse interaction in
BrowserView::NonClientHitTest()
to either return HTBOTTOMRIGHT or HTBOTTOMLEFT (again, based on the RTL setting)
and, again, let the OS take care of the resizing.

More details here:
http://code.google.com/p/chromium/wiki/BrowserViewResizer

------------------------------------------------------------------------
r9403 | sidchat@google.com | 2009-02-09 20:44:17 +0100 (Mon, 09 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

Fix the extension repetition problem with download manager. Enabled the corresponding (disabled) unit test.

Issue=1503
Review URL: http://codereview.chromium.org/23013
------------------------------------------------------------------------
r9401 | pinkerton@chromium.org | 2009-02-09 20:40:36 +0100 (Mon, 09 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/command_updater_unittest.cc

Test the RemoveCommandObserver() routine that removes an observer from all its registered commands.
Review URL: http://codereview.chromium.org/20180
------------------------------------------------------------------------
r9400 | stoyan@chromium.org | 2009-02-09 20:28:41 +0100 (Mon, 09 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/chrome/browser/message_window.cc
   M /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc
   M /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/net/disk_cache/stress_cache.cc

Fix the windows implementation of KillProcess and WaitForSingleProcess to not close the process handle that they do not own.
Review URL: http://codereview.chromium.org/24004
------------------------------------------------------------------------
r9392 | kuchhal@chromium.org | 2009-02-09 18:37:13 +0100 (Mon, 09 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Reverting 9388 to see if this fixes ui tests.

TBR=tommi
Review URL: http://codereview.chromium.org/20179
------------------------------------------------------------------------
r9388 | tommi@chromium.org | 2009-02-09 17:46:25 +0100 (Mon, 09 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Adding support for tab notifications and initializing the focus of an automated tab.

Review URL: http://codereview.chromium.org/20125
------------------------------------------------------------------------
r9386 | pinkerton@chromium.org | 2009-02-09 16:35:47 +0100 (Mon, 09 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/base/scoped_nsautorelease_pool.h
   M /trunk/src/base/scoped_nsautorelease_pool.mm
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/common/main_function_params.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/renderer_main_unittest.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc

Add Recycle() method to scoped autorelease pool to allow cleaning out any junk
created at startup before the main runloop. Correct quit on Mac to let the
BrowserProcess shut down the event loop when its refcount goes to zero after
cleaning up all browser windows.
------------------------------------------------------------------------
r9385 | jar@chromium.org | 2009-02-09 06:49:22 +0100 (Mon, 09 Feb 2009) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Force all stability stats into "initial log" (don't use ongoing log)

The goal of this checkin is to effectively roll-back our stats gathering
methodology for stability stats to ONLY use the initial log.  This has
some negative consequences (time lag, and bias against data from happy
ongoing users).  We're doing this because there appears to be a BIG
survivability differnce between initial and ongoing logs.  Perhaps we
are even getting multiple recordings of data from initial logs.
Until this is corrected, it is not safe to send part of the stability
info (crashes) only in the initial logs, while we send pageloads in
part via ongoing logs.

To absolutely minimize risk, I decided to leave the inter-log delay
at 20 minutes, so that there is no chance of changing the log saving
resource utilization (i.e., going over the limits).  It was at 5
when we started the process, but since it has no impact on the initial
log, it won't harm the stability stats, and it may reduce load on
the front end log saving servers.

bug=1564631

r=huanr,evanm
Review URL: http://codereview.chromium.org/21160
------------------------------------------------------------------------
r9375 | rvargas@google.com | 2009-02-07 02:58:42 +0100 (Sat, 07 Feb 2009) | 14 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds a command line switch to allow the user to specify the location
of the disk cache, rather than in the profile directory. The command
line switch overrides the cache location regardless the chosen
profile.

In this implementation, the supplied directory name must should not
contain spaces.

BUG=6688

submitted by bekkra.
original code review http://codereview.chromium.org/21094/show


------------------------------------------------------------------------
r9351 | jam@chromium.org | 2009-02-06 23:45:14 +0100 (Fri, 06 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Handle review comments form previous change.  Also, use enum types and not int in IPC messages to make things clearer.

Review URL: http://codereview.chromium.org/20140
------------------------------------------------------------------------
r9350 | pinkerton@chromium.org | 2009-02-06 23:37:13 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/command_updater.cc
   M /trunk/src/chrome/browser/command_updater.h

Add a method to CommandUpdater to remove an observer from all commands at once.
Review URL: http://codereview.chromium.org/21140
------------------------------------------------------------------------
r9349 | creis@google.com | 2009-02-06 23:33:57 +0100 (Fri, 06 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_instance.h
   A /trunk/src/chrome/browser/navigation_entry_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Adds a unit test for NavigationEntry.  Also adds a comment to BrowsingInstance
to explain that it is unit tested in site_instance_unittest.cc.

BUG=7371
BUG=7369
TEST=NavigationEntryTest.*


Review URL: http://codereview.chromium.org/21132
------------------------------------------------------------------------
r9346 | avi@google.com | 2009-02-06 23:25:40 +0100 (Fri, 06 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm

Auto-resize the inner view.

Review URL: http://codereview.chromium.org/20143
------------------------------------------------------------------------
r9344 | cpu@google.com | 2009-02-06 23:23:55 +0100 (Fri, 06 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Add UMA counter to track how users launch Chrome
- Histogram is named Launch.Modes
- We have different buckets for : direct execution, webapp, shell, quicklaunch and desktop shortcuts

BUG=7216

Review URL: http://codereview.chromium.org/21109
------------------------------------------------------------------------
r9339 | tc@google.com | 2009-02-06 22:58:16 +0100 (Fri, 06 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

disable download test while sid fixes offline

TBR=sid

Review URL: http://codereview.chromium.org/20142

------------------------------------------------------------------------
r9338 | pinkerton@chromium.org | 2009-02-06 22:12:59 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Ensure toolbar buttons are in sync with command updater when tab becomes selected. Remove a NOTIMPLEMENTED that shouldn't be there.
Review URL: http://codereview.chromium.org/20138
------------------------------------------------------------------------
r9337 | abarth@chromium.org | 2009-02-06 21:59:15 +0100 (Fri, 06 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webview_impl.cc

Add a command line option --disable-web-security.  People can use this option when the same-origin policy interferes with testing their web sites.

R=deanm
BUG=6449

Review URL: http://codereview.chromium.org/20101
------------------------------------------------------------------------
r9336 | gwilson@google.com | 2009-02-06 21:49:35 +0100 (Fri, 06 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Fixes the EULA dialog to explicitly unset the usagestats flag if the checkbox is not selected.  Before, the dialog would simply not modify the value already set.

BUG=7426
R=cpu

Review URL: http://codereview.chromium.org/21134
------------------------------------------------------------------------
r9334 | pinkerton@chromium.org | 2009-02-06 21:32:34 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/browser/location_bar.h

Create a stub LocationBar object on Mac to communicate between the bar and the Browser.
Review URL: http://codereview.chromium.org/20136
------------------------------------------------------------------------
r9332 | thestig@chromium.org | 2009-02-06 21:19:05 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Janitorial: browser_render_process_host header/lint cleanup. Remove lots of header files it doesn't need and add the ones it does use.
Review URL: http://codereview.chromium.org/21135
------------------------------------------------------------------------
r9330 | avi@google.com | 2009-02-06 21:12:07 +0100 (Fri, 06 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h (from /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h:9176)
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm (from /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc:9176)
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   A /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.h (from /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h:9176)
   A /trunk/src/chrome/browser/tab_contents/web_contents_view_mac.mm (from /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc:9176)
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Initial Mac port of web_contents_view and render_widget_host_view.

Review URL: http://codereview.chromium.org/20124
------------------------------------------------------------------------
r9326 | jhawkins@chromium.org | 2009-02-06 20:29:30 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make cert_store.cc compile on Mac and Linux.
Review URL: http://codereview.chromium.org/20135
------------------------------------------------------------------------
r9325 | tc@google.com | 2009-02-06 20:03:29 +0100 (Fri, 06 Feb 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   A /trunk/src/chrome/browser/net/dns_slave.cc
   A /trunk/src/chrome/browser/net/dns_slave.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h

Revert "Clean up dns prefetch code, and also port it."
This reverts commit r9312.

Revert "Fix HostResolver crash when MessageLoop is destroyed during"
This reverts commit r9317.

BUG=5687,6683

TBR=ph

Review URL: http://codereview.chromium.org/21133

------------------------------------------------------------------------
r9321 | estade@chromium.org | 2009-02-06 19:39:18 +0100 (Fri, 06 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h

Fix linux build bustage.

tbr=pinkerton

Review URL: http://codereview.chromium.org/20130
------------------------------------------------------------------------
r9319 | estade@chromium.org | 2009-02-06 19:16:42 +0100 (Fri, 06 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   A /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.cc
   A /trunk/src/chrome/browser/tab_contents/web_contents_view_gtk.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Stub out web_contents_view_gtk.

Also start using the new render_widget_host_view_gtk

Review URL: http://codereview.chromium.org/21119
------------------------------------------------------------------------
r9318 | pinkerton@chromium.org | 2009-02-06 19:14:48 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/TabContents.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable/disable buttons when the corresponding command updates in the model.
Review URL: http://codereview.chromium.org/21128
------------------------------------------------------------------------
r9315 | pkasting@chromium.org | 2009-02-06 18:33:14 +0100 (Fri, 06 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.cc

Support custom border widths.  Allow user to resize the window (instead of doing nothing) when over our client edge graphics.  Make resize corner behavior on XP more native.  More cleanup.

BUG=5054
Review URL: http://codereview.chromium.org/21116
------------------------------------------------------------------------
r9312 | phajdan.jr@chromium.org | 2009-02-06 13:16:53 +0100 (Fri, 06 Feb 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   D /trunk/src/chrome/browser/net/dns_slave.cc
   D /trunk/src/chrome/browser/net/dns_slave.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/net/base/host_resolver.h

Clean up dns prefetch code, and also port it.

- remove slave threads and use HostResolver in asynchronous mode instead (while still limiting number of concurrent lookups)
- make the implementation portable and make DnsMaster unit test compile and pass on Linux
- add more tests to DnsMaster unit test to simulate various shutdown scenarios, concurrent lookups, and to verify that we don't exceed our limit of concurrent lookup requests)
- remove some tests which relied on specifics of slaves' inner working

Bonus: shutdown is almost instant now, no need to have a timeout.

BUG=5687, 6683
Review URL: http://codereview.chromium.org/15076
------------------------------------------------------------------------
r9304 | pinkerton@chromium.org | 2009-02-06 04:39:18 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Remove many more ifdefs around un-used methods to enable more functionality for mac and linux.
Review URL: http://codereview.chromium.org/21118
------------------------------------------------------------------------
r9303 | brettw@chromium.org | 2009-02-06 04:32:12 +0100 (Fri, 06 Feb 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   D /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc
   D /trunk/src/chrome/browser/tab_contents/ipc_status_view.h
   D /trunk/src/chrome/browser/tab_contents/status_view.cc
   D /trunk/src/chrome/browser/tab_contents/status_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/views/SConscript
   A /trunk/src/chrome/browser/views/about_ipc_dialog.cc (from /trunk/src/chrome/browser/views/about_ipc_dialog.cc:9093)
   A /trunk/src/chrome/browser/views/about_ipc_dialog.h (from /trunk/src/chrome/browser/views/about_ipc_dialog.h:9093)
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj

Move the about:ipc tab to a dialog. This patch is kind of a hack, the Windows
specific code for the settings dialog and the table view are just copied from
the old dialog. I tried to change as little as possible. The only significant
change should be that I commented out saving the settings in the profile.

This is a re-land of my previous patch which didn't ifdef the code based on the
IPC logging preprocessor define.
Previous review URL: http://codereview.chromium.org/19741
Review URL: http://codereview.chromium.org/20033
------------------------------------------------------------------------
r9301 | paul@chromium.org | 2009-02-06 02:57:39 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Port SafeBrowsingProtocolManager to Mac and linux.
Review URL: http://codereview.chromium.org/20119
------------------------------------------------------------------------
r9299 | jam@chromium.org | 2009-02-06 02:35:30 +0100 (Fri, 06 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc

Commit my changes that simplify automation message unpacking.

TBR=amit
Review URL: http://codereview.chromium.org/24002
------------------------------------------------------------------------
r9298 | ericroman@google.com | 2009-02-06 02:13:22 +0100 (Fri, 06 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_test_job.cc

Add a constraint on how many requests can be outstanding for any given render process (browser-side).

Once the constraint is reached, subsequent requests will fail with net::ERR_INSUFFICIENT_RESOURCES.

The bound is defined as "25 MB", which represents the amount of private bytes we expect  the pending requests to consume in the browser. This number translates into around 6000 typical requests.

Note that the upload data of a request is not currently considered part of the request's in-memory cost -- more data is needed on the average/maximum upload sizes of users before deciding what a compatible limit is.

BUG=5688
Review URL: http://codereview.chromium.org/18541
------------------------------------------------------------------------
r9297 | erg@google.com | 2009-02-06 01:58:09 +0100 (Fri, 06 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_gtk.cc
   M /trunk/src/chrome/browser/browser_window_gtk.h

Make the new linux browser shut down cleanly.

Review URL: http://codereview.chromium.org/21112

------------------------------------------------------------------------
r9292 | brettw@google.com | 2009-02-06 01:28:24 +0100 (Fri, 06 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Fix the Linux build by adding resource_message_filter to the build.
------------------------------------------------------------------------
r9291 | brettw@google.com | 2009-02-06 01:19:17 +0100 (Fri, 06 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/base/image_util.h
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make ResourceMessageFilter compile on Mac. It stubs out a substantial part of
the printing. It creates new base functions for converting PIDs to handles, and
then closing them (since Windows requires this). This also fixes the formatting
of image_util.
Review URL: http://codereview.chromium.org/20109
------------------------------------------------------------------------
r9290 | pinkerton@chromium.org | 2009-02-06 01:16:45 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Make sure tab contents get cleaned up and dealloc'd correctly when a tab closes.
Review URL: http://codereview.chromium.org/20117
------------------------------------------------------------------------
r9288 | thestig@chromium.org | 2009-02-06 01:15:51 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Make render_widget_host_unittest compile and run on POSIX.
Review URL: http://codereview.chromium.org/20115
------------------------------------------------------------------------
r9285 | munjal@chromium.org | 2009-02-06 01:06:12 +0100 (Fri, 06 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc

New menu item for personalization project.

Review URL: http://codereview.chromium.org/21006
------------------------------------------------------------------------
r9284 | rvargas@google.com | 2009-02-06 01:05:44 +0100 (Fri, 06 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/net/base/io_buffer.h

Fix a memory leak on the async resource handler.

BUG=7374

Review URL: http://codereview.chromium.org/20099
------------------------------------------------------------------------
r9276 | estade@chromium.org | 2009-02-06 00:33:01 +0100 (Fri, 06 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser.scons
   A /trunk/src/chrome/browser/browser_window_factory_gtk.cc
   A /trunk/src/chrome/browser/browser_window_gtk.cc
   A /trunk/src/chrome/browser/browser_window_gtk.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Stub implementation of gtk browser window.

Review URL: http://codereview.chromium.org/21107
------------------------------------------------------------------------
r9273 | pinkerton@chromium.org | 2009-02-06 00:03:33 +0100 (Fri, 06 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm

Implement tab detach notifications to remove tabs from UI.
Review URL: http://codereview.chromium.org/21100
------------------------------------------------------------------------
r9270 | aa@chromium.org | 2009-02-05 23:51:54 +0100 (Thu, 05 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/extensions/url_pattern.cc
   M /trunk/src/chrome/common/extensions/url_pattern.h
   A /trunk/src/chrome/common/extensions/user_script.cc
   A /trunk/src/chrome/common/extensions/user_script.h
   A /trunk/src/chrome/common/extensions/user_script_unittest.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   D /trunk/src/chrome/renderer/user_script_slave_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Integrate URLPattern with Extension user scripts.
Also refactored the UserScript class in
UserScriptSlave and the UserScriptInfo structure
in UserScriptMaster into a common location.

Review URL: http://codereview.chromium.org/21070
------------------------------------------------------------------------
r9269 | thestig@chromium.org | 2009-02-05 23:47:10 +0100 (Thu, 05 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h

Cleanup some forward declared structs that are not being used.

Also do some lint removal while I'm at it.
Review URL: http://codereview.chromium.org/20107
------------------------------------------------------------------------
r9262 | maruel@chromium.org | 2009-02-05 22:42:09 +0100 (Thu, 05 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Temporarily disable the printing test while I find out what I did wrong.

TBR=brettw
Review URL: http://codereview.chromium.org/20105
------------------------------------------------------------------------
r9257 | agl@chromium.org | 2009-02-05 22:13:39 +0100 (Thu, 05 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/resource_bundle.cc

Linux: get us to the point where we crash at browser->window()->Show()

Review URL: http://codereview.chromium.org/20098

------------------------------------------------------------------------
r9253 | agl@chromium.org | 2009-02-05 22:08:31 +0100 (Thu, 05 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h

Linux: add a big, stubby RenderWidgetHostView

This implementation is a lot of NOTIMPLEMENTEDs with a little bit of
drawing code. It provides a skeleton for future implementation efforts
and does, at least, build.

Review URL: http://codereview.chromium.org/21091

------------------------------------------------------------------------
r9250 | pinkerton@chromium.org | 2009-02-05 22:04:46 +0100 (Thu, 05 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Hook up tab close menu item and plumb tab closing scaffolding through UI layer on Mac. Fix several unregistered prefs issues from other checkins.
Review URL: http://codereview.chromium.org/21092
------------------------------------------------------------------------
r9245 | brettw@chromium.org | 2009-02-05 21:33:22 +0100 (Thu, 05 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_request_details.h

Fix the build due to conflict with Paul's change
------------------------------------------------------------------------
r9243 | brettw@chromium.org | 2009-02-05 21:27:18 +0100 (Thu, 05 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

Fix the build from my previous file move.
Review URL: http://codereview.chromium.org/20096
------------------------------------------------------------------------
r9242 | brettw@chromium.org | 2009-02-05 21:17:07 +0100 (Thu, 05 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   A /trunk/src/chrome/browser/renderer_host/resource_message_filter.cc (from /trunk/src/chrome/browser/resource_message_filter.cc:9146)
   A /trunk/src/chrome/browser/renderer_host/resource_message_filter.h (from /trunk/src/chrome/browser/resource_message_filter.h:9146)
   A /trunk/src/chrome/browser/renderer_host/resource_request_details.h (from /trunk/src/chrome/browser/resource_request_details.h:9158)
   D /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   D /trunk/src/chrome/browser/repost_form_warning_dialog.h
   D /trunk/src/chrome/browser/resource_message_filter.cc
   D /trunk/src/chrome/browser/resource_message_filter.h
   D /trunk/src/chrome/browser/resource_request_details.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   A /trunk/src/chrome/browser/tab_contents/repost_form_warning.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   A /trunk/src/chrome/browser/views/repost_form_warning_view.cc (from /trunk/src/chrome/browser/repost_form_warning_dialog.cc:9042)
   A /trunk/src/chrome/browser/views/repost_form_warning_view.h (from /trunk/src/chrome/browser/repost_form_warning_dialog.h:9042)
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Move resource_message_filter and resource_request_details to the renderer_host.

Make the repost form warning portable by abstracting the show function from
the view. Rename the Windows repost form warning and move it to browser/views.

This also fixes a comment in browser_process.h
Review URL: http://codereview.chromium.org/20066
------------------------------------------------------------------------
r9240 | pinkerton@chromium.org | 2009-02-05 21:03:48 +0100 (Thu, 05 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h

Correctly spawn render process for posix.
Review URL: http://codereview.chromium.org/20088
------------------------------------------------------------------------
r9237 | maruel@chromium.org | 2009-02-05 20:20:36 +0100 (Thu, 05 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printed_pages_source.h

Remove black magic and >100 lines. Unhook a lot of dead code.
Review URL: http://codereview.chromium.org/21057
------------------------------------------------------------------------
r9232 | pkasting@chromium.org | 2009-02-05 19:49:46 +0100 (Thu, 05 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc

Fix compiler warning with GCC 4.3.  Patch by Craig Schlenter (see http://codereview.chromium.org/20075 ), r=me.
------------------------------------------------------------------------
r9231 | paul@chromium.org | 2009-02-05 19:48:08 +0100 (Thu, 05 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/resource_request_details.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/net/base/x509_certificate.cc

Port the ResourceDispatcherHost to Mac and linux.
Review URL: http://codereview.chromium.org/20073
------------------------------------------------------------------------
r9227 | estade@chromium.org | 2009-02-05 19:34:21 +0100 (Thu, 05 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add some more scaffolding, enable some browser_main code on linux.

Review URL: http://codereview.chromium.org/21067
------------------------------------------------------------------------
r9226 | pinkerton@chromium.org | 2009-02-05 19:33:15 +0100 (Thu, 05 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add in NavigationController to linux and mac. 
Review URL: http://codereview.chromium.org/21064
------------------------------------------------------------------------
r9223 | agl@chromium.org | 2009-02-05 19:00:28 +0100 (Thu, 05 Feb 2009) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc

POSIX: Backing store scrolling.

In the long term, we plan to get rid of all this code and "do things
properly". However, for now we are implementing several shortcuts to
get something which can render. Part one of this was BitmapWireData
(r9065) which transported updates from the renderer over the IPC
channel. This patch implements the fast-scrolling path, slowly.

It might seem that this is something which Skia should be doing.
However, copying from one bitmap to the same bitmap needs to be
handled very differently from bitblitting from one to another to save
writing to locations that you'll need to read from later on. I can't
see any indication in the Skia code that it handles this case so, in
order to get something working quickly, we write our own, small,
bitblitter.

Since this code hasn't been tested, it's almost certainly buggy.
However, we don't get to test it until we get a little more of the
browser up and running.

Review URL: http://codereview.chromium.org/21050

------------------------------------------------------------------------
r9221 | stoyan@chromium.org | 2009-02-05 18:41:38 +0100 (Thu, 05 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/common/DEPS
   A /trunk/src/chrome/common/gfx/DEPS
   A /trunk/src/chrome/installer/setup/DEPS
   A /trunk/src/chrome/plugin/DEPS
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/test/DEPS
   A /trunk/src/chrome/third_party/hunspell/google/DEPS
   A /trunk/src/chrome/tools/DEPS
   A /trunk/src/chrome/views/DEPS
   A /trunk/src/net/base/DEPS
   M /trunk/src/tools/checkdeps/checkdeps.py
   M /trunk/src/webkit/DEPS
   M /trunk/src/webkit/glue/DEPS
   A /trunk/src/webkit/tools/DEPS

Fix the dependency checker tool. Rules for a directory did modify their directory parent rules. Using copy.copy() solves the problem.Additional fix when "allow-current-directory" rules was not applied if DEPS file is missing.

Updated few DEPS file with reasonable rules.
To prevent tree closing other dependencies are added. These need to be either legitimated or dependency removed.
Review URL: http://codereview.chromium.org/21025
------------------------------------------------------------------------
r9219 | kuchhal@chromium.org | 2009-02-05 18:08:58 +0100 (Thu, 05 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Fix unintentional edit from r9218.

Review URL: http://codereview.chromium.org/21083
------------------------------------------------------------------------
r9218 | kuchhal@chromium.org | 2009-02-05 17:51:43 +0100 (Thu, 05 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

Open Chrome Window instead of tab when it is launched from a shortcut.

BUG=7356

Review URL: http://codereview.chromium.org/20074
------------------------------------------------------------------------
r9215 | phajdan.jr@chromium.org | 2009-02-05 13:31:02 +0100 (Thu, 05 Feb 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Usual round of porting in chrome/

- make following unit tests run and pass on Linux:
     browser/cache_manager_host_unittest.cc
     browser/google_url_tracker_unittest.cc

- trivial cleanups needed for GCC

- remove CacheManagerHost and ResolveProxyMsgHelper from temporary scaffolding stubs and use real implementations instead

- update chrome.xcodeproj to reflect above change

Review URL: http://codereview.chromium.org/20057
------------------------------------------------------------------------
r9212 | thomasvl@chromium.org | 2009-02-05 05:38:55 +0100 (Thu, 05 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Remove the stale ifdef/comment since the it's using the command line class now
  for building up the launch of a renderer.
Review URL: http://codereview.chromium.org/20071
------------------------------------------------------------------------
r9209 | jam@chromium.org | 2009-02-05 04:26:29 +0100 (Thu, 05 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/history/history.cc
   D /trunk/src/chrome/browser/iaccessible_function_ids.h
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/view_source_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   A /trunk/src/chrome/common/accessibility.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/debug_message_handler.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/test_tab_contents.cc
   A /trunk/src/webkit/glue/context_menu.h (from /trunk/src/webkit/glue/context_node_types.h:9176)
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   D /trunk/src/webkit/glue/context_node_types.h
   M /trunk/src/webkit/glue/dragclient_impl.cc
   M /trunk/src/webkit/glue/glue.vcproj
   M /trunk/src/webkit/glue/glue_accessibility.cc
   M /trunk/src/webkit/glue/glue_accessibility.h
   M /trunk/src/webkit/glue/webview_delegate.h

Finish taking out render_messages.h includes from headers.

Review URL: http://codereview.chromium.org/20072
------------------------------------------------------------------------
r9200 | thestig@chromium.org | 2009-02-05 02:03:56 +0100 (Thu, 05 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/unit/unit_tests.scons

Make mock_render_process_host, test_web_contents, and testing_profile compile on POSIX.
Review URL: http://codereview.chromium.org/23005
------------------------------------------------------------------------
r9189 | jam@chromium.org | 2009-02-05 00:44:46 +0100 (Thu, 05 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h

Commiting the changes from my previous cl that are specific to not including render_messages.h/plugin_message.h unless necessary.

TBR=mpcomplete

Review URL: http://codereview.chromium.org/20059
------------------------------------------------------------------------
r9176 | thestig@chromium.org | 2009-02-04 23:07:54 +0100 (Wed, 04 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Make autofill_manager compile on POSIX.
Review URL: http://codereview.chromium.org/22002
------------------------------------------------------------------------
r9174 | tommi@chromium.org | 2009-02-04 22:52:48 +0100 (Wed, 04 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Explicitly removing WS_POPUP after initialization so that users of the ExternalTabContainer class can control whether or not it's set.

Review URL: http://codereview.chromium.org/19768
------------------------------------------------------------------------
r9173 | pinkerton@chromium.org | 2009-02-04 22:49:38 +0100 (Wed, 04 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Enable render_widget_host, render_view_host and backing_store. Remove the RenderWidgetHostManager from the scaffolding.
Review URL: http://codereview.chromium.org/20044
------------------------------------------------------------------------
r9167 | jam@chromium.org | 2009-02-04 21:10:12 +0100 (Wed, 04 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   D /trunk/src/chrome/common/ipc_sync_channel_unittest.h
   M /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.h
   D /trunk/src/chrome/common/plugin_messages.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   D /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc

Commit just the changes to make creating new IPC channel types easier.
TBR=mpcomplete

Review URL: http://codereview.chromium.org/21052
------------------------------------------------------------------------
r9163 | hclam@chromium.org | 2009-02-04 20:47:59 +0100 (Wed, 04 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS

Added missing DEPS for fixing builds
Added +media/audio to chrome/browser/DEPS.

Review URL: http://codereview.chromium.org/21053
------------------------------------------------------------------------
r9161 | jcampan@chromium.org | 2009-02-04 20:38:30 +0100 (Wed, 04 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/time.cc
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

This CL adds macro used to track the creation and destruction
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714

Note: this CL was previously committed and reverted because it broke the sandbox integration module.
Review URL: http://codereview.chromium.org/21032
------------------------------------------------------------------------
r9159 | hclam@chromium.org | 2009-02-04 20:28:53 +0100 (Wed, 04 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/renderer_host/audio_renderer_host.cc
   A /trunk/src/chrome/browser/renderer_host/audio_renderer_host.h
   A /trunk/src/chrome/browser/renderer_host/audio_renderer_host_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

AudioRendererHost and unit test files
AudioRendererHost provide service in browser process for AudioRenderer to access hardware in render process.
There will be one AudioRendererHost for every RenderProcessHost, each one of AudioRendererHost will service multiple AudioRenderer in the related render process.
The main functionality of AudioRendererHost is to group audio related services and provide access to AudioRenderer through IPC. It maps an internal stream id to the actual AudioOutputStream which most calls are delegated to.
AudioRendererHost::IPCAudioSource is to implement audio data source using IPC.

Review URL: http://codereview.chromium.org/21008
------------------------------------------------------------------------
r9157 | thestig@chromium.org | 2009-02-04 20:22:40 +0100 (Wed, 04 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Make render_view_host_manager.cc compile on POSIX.

Get rid of forward-declared enums in render_view_host.h and unneeded headers in render_view_host_manager.h.
Review URL: http://codereview.chromium.org/21048
------------------------------------------------------------------------
r9155 | ben@chromium.org | 2009-02-04 20:13:30 +0100 (Wed, 04 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Attempt to fix a crash in case the TabContents gets destroyed somehow.

http://crbug.com/6702

Review URL: http://codereview.chromium.org/20032
------------------------------------------------------------------------
r9149 | brettw@chromium.org | 2009-02-04 19:59:09 +0100 (Wed, 04 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h

Partial porting of the about handler.
Review URL: http://codereview.chromium.org/20045
------------------------------------------------------------------------
r9140 | avi@google.com | 2009-02-04 18:58:46 +0100 (Wed, 04 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/browser/search_engines/template_url_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Bring many of the template_url classes into the fold for the Mac. Note that template_url_model_unittest isn't there; it requires a working database first.

Review URL: http://codereview.chromium.org/19714
------------------------------------------------------------------------
r9132 | jam@chromium.org | 2009-02-04 09:58:19 +0100 (Wed, 04 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_unittest.cc
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.h
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_bundle.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/webkit/glue/glue_accessibility.cc
   M /trunk/src/webkit/glue/glue_accessibility.h

Revert my change to get the tree green.  Not sure why the tests became flaky.  I'll try to check them in again but in smaller chunks tomorrow.

TBR=mpcomplete

Review URL: http://codereview.chromium.org/21039
------------------------------------------------------------------------
r9129 | xji@chromium.org | 2009-02-04 07:33:55 +0100 (Wed, 04 Feb 2009) | 36 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html


This change list fix issue 5926 -- RTL: Text in [New Tab] should be truncated from RightToLeft instead of LeftToRight.
(http://crbug.com/5926)

Basically, the issue is that in RTL locales, the thumbnail title etc. text will always be truncated from left, even if they are pure English. For example, "mail.yahoo.com" whose title is "Yahoo! the best web based email!" will be truncated to "best web-based email!".
We should be able to truncate the title as "Yahoo! the be...".

The fix is to set the direction style of each title in the [New Tab] html page for title to be displayed and truncated correctly.

The fix consists 2 part: new_tab_ui.cc in backend and new_tab.html in frontend.

1. new_tab_ui.cc
For thumbnail title, recent bookmark title, and recently closed tab titles, originally, we set "title" and "url" into the data we pass to JS in new_tab.html. The fix added the title's "direction" to the data. The direction is by default  "ltr" and is set as "rtl" when there is character having strong directionality in the title.

2. new_tab.html
2.1 set text-alignment in thumbnail-title, bookmark container, and recently closed container to be "right" for RTL locales.
2.2 explicitly set title's directionality in the above 3 sections.


Test:
1. open Chrome in RTL locales.
2. open the following pages:
http://yahoo.com
http://gmail.com
http://mail.yahoo.com
http://wikipedia.com
http://msdn.microsoft.com/en-us/default.aspx
http://arabic.arabia.msn.com/default.aspx
http://he.wikipedia.org/
3. bookmark, close some of them.
4. open [New Tab]




Review URL: http://codereview.chromium.org/19738
------------------------------------------------------------------------
r9123 | jam@chromium.org | 2009-02-04 04:15:58 +0100 (Wed, 04 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_unittest.cc
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   D /trunk/src/chrome/common/ipc_sync_channel_unittest.h
   M /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.h
   D /trunk/src/chrome/common/plugin_messages.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   D /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/webkit/glue/glue_accessibility.cc
   M /trunk/src/webkit/glue/glue_accessibility.h

Make it easier/less work/less error-prone to create new IPC channel types (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h.  Also make the message class starting IDs come from an enum to ensure we don't use a value twice.  I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking.  Most of this was in the automation code.  I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest
Review URL: http://codereview.chromium.org/20015
------------------------------------------------------------------------
r9116 | pkasting@chromium.org | 2009-02-04 02:02:00 +0100 (Wed, 04 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h

Improved OTR avatar and popup window rendering.  Neither one precisely matches the old code but IMO each looks better.

Once again, the aero_glass_non_client_view changes here are hackish, and will get cleaned up later.

BUG=5054
Review URL: http://codereview.chromium.org/20011
------------------------------------------------------------------------
r9115 | pinkerton@chromium.org | 2009-02-04 01:59:11 +0100 (Wed, 04 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Add site_instance, navigation_entry, browsing_instance, renderer_security_policy, and render_widget_helper to mac and linux builds. Adds a hash for Profile so it can be put into a hash table on gcc.
Review URL: http://codereview.chromium.org/21021
------------------------------------------------------------------------
r9113 | erikkay@google.com | 2009-02-04 01:53:08 +0100 (Wed, 04 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Fix a leak in the extension installation code.
Review URL: http://codereview.chromium.org/21027
------------------------------------------------------------------------
r9110 | ojan@google.com | 2009-02-04 00:34:04 +0100 (Wed, 04 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Reverting 9109.

Broke the build.
Review URL: http://codereview.chromium.org/20029
------------------------------------------------------------------------
r9109 | jcampan@chromium.org | 2009-02-04 00:20:59 +0100 (Wed, 04 Feb 2009) | 8 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

This CL adds macro used to track the creation and destruction
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714



Review URL: http://codereview.chromium.org/21018
------------------------------------------------------------------------
r9107 | erikkay@google.com | 2009-02-04 00:00:30 +0100 (Wed, 04 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Add a command line flag to load a single extension from an arbitrary (non-versioned) directory.  This is designed for developers to iterate on extension development without having to go through the install process.

Review URL: http://codereview.chromium.org/20020
------------------------------------------------------------------------
r9106 | sidchat@google.com | 2009-02-03 23:56:56 +0100 (Tue, 03 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Remember change in Spell Check language by putting it in the list of accept languages when the user changes the language from languages options menu.

It also includes a fix (required for this change to work) when existing users are updated to use language only code for spellcheck languages instead of languages+region. 

Issue=5829
Review URL: http://codereview.chromium.org/19520
------------------------------------------------------------------------
r9094 | ojan@google.com | 2009-02-03 19:52:05 +0100 (Tue, 03 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_about_handler.cc
   A /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc (from /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc:9089)
   A /trunk/src/chrome/browser/tab_contents/ipc_status_view.h (from /trunk/src/chrome/browser/tab_contents/ipc_status_view.h:9089)
   A /trunk/src/chrome/browser/tab_contents/status_view.cc (from /trunk/src/chrome/browser/tab_contents/status_view.cc:9089)
   A /trunk/src/chrome/browser/tab_contents/status_view.h (from /trunk/src/chrome/browser/tab_contents/status_view.h:9089)
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/views/SConscript
   D /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   D /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj

Reverting 9090.

Broke chromium full build.
Review URL: http://codereview.chromium.org/21024
------------------------------------------------------------------------
r9090 | brettw@chromium.org | 2009-02-03 18:47:07 +0100 (Tue, 03 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_about_handler.cc
   D /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc
   D /trunk/src/chrome/browser/tab_contents/ipc_status_view.h
   D /trunk/src/chrome/browser/tab_contents/status_view.cc
   D /trunk/src/chrome/browser/tab_contents/status_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/views/SConscript
   A /trunk/src/chrome/browser/views/about_ipc_dialog.cc
   A /trunk/src/chrome/browser/views/about_ipc_dialog.h
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj

Move the about:ipc tab to a dialog. This patch is kind of a hack, the Windows
specific code for the settings dialog and the table view are just copied from
the old dialog. I tried to change as little as possible. The only significant
change should be that I commented out saving the settings in the profile.
Review URL: http://codereview.chromium.org/19741
------------------------------------------------------------------------
r9082 | erikkay@google.com | 2009-02-03 17:34:06 +0100 (Tue, 03 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h

Extension loading improvements.
Add a method that allows loading a single specific extension.
Load extensions upon successful install.

Review is for which ever one of you gets in first, or both if you care. ;-)

Review URL: http://codereview.chromium.org/19759
------------------------------------------------------------------------
r9065 | thestig@chromium.org | 2009-02-03 03:11:48 +0100 (Tue, 03 Feb 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   A /trunk/src/chrome/browser/renderer_host/backing_store_posix.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   A /trunk/src/chrome/common/bitmap_wire_data.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   M /trunk/src/skia/ext/platform_canvas_mac.h
   M /trunk/src/skia/ext/platform_canvas_win.cc
   M /trunk/src/skia/ext/platform_canvas_win.h

From agl. Cleaned up version of issue 19046.

POSIX: bitmap data on the wire

On Windows, when drawing a given rect in the renderer, we allocate memory for the bitmap, render and send a shared memory handle across IPC. In the browser, we bitblit the shared memory to the backing store and draw it to the screen.

In the long term, on Linux, we want the backingstore to be shared with both X and the renderer. The renderer then draws directly to that store, sends an IPC to the browser and the browser sends a message to X to bitblit to the display. Since only cache a few backing stores we'll need messages from the browser to tell the renderer to attach and detatch from shared memory regions as they get created and evicted.

In the short term, however, to get something that works, we make a BitmapWireData typedef. This will be a shared memory region on Windows, as before, and on POSIX we'll be sending the bitmap data over the wire. Obviously this'll be pretty slow but it'll work sooner.
Review URL: http://codereview.chromium.org/19491
------------------------------------------------------------------------
r9062 | pkasting@chromium.org | 2009-02-03 02:43:19 +0100 (Tue, 03 Feb 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc

Fix some of the most egregious problems with Aero glass frames.  These changes are basically hacks, but they're hacks that get our frame width, tabstrip layout (in non-OTR mode), and client edge drawing to exactly match pre-Magic-BrowzR code.  In subsequent changes I will clean this all up to work better.

This also fixes windows refusing to become activated.

BUG=5054,6174
Review URL: http://codereview.chromium.org/19548
------------------------------------------------------------------------
r9058 | ben@chromium.org | 2009-02-03 02:13:29 +0100 (Tue, 03 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc

Fix a divide by zero crash with a temporary workaround (until we have themes).

http://crbug.com/6294

Review URL: http://codereview.chromium.org/19767
------------------------------------------------------------------------
r9055 | pinkerton@chromium.org | 2009-02-03 02:09:53 +0100 (Tue, 03 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

first stab at scaffolding WebContents.
Review URL: http://codereview.chromium.org/19757
------------------------------------------------------------------------
r9054 | dimich@google.com | 2009-02-03 02:03:17 +0100 (Tue, 03 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/webkit/build/WebCore/WebCore.vcproj

Reverting 9052.
Review URL: http://codereview.chromium.org/20004
------------------------------------------------------------------------
r9052 | dimich@google.com | 2009-02-03 00:33:36 +0100 (Tue, 03 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/webkit/build/WebCore/WebCore.vcproj

Try to disable PCH on browser and WebCore.
Review URL: http://codereview.chromium.org/19766
------------------------------------------------------------------------
r9041 | phajdan.jr@chromium.org | 2009-02-02 13:18:46 +0100 (Mon, 02 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_publisher.cc
   M /trunk/src/chrome/browser/history/history_publisher.h
   A /trunk/src/chrome/browser/history/history_publisher_none.cc
   A /trunk/src/chrome/browser/history/history_publisher_win.cc (from /trunk/src/chrome/browser/history/history_publisher.cc:9040)
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/tools/profiles/thumbnail-inl.h

Port some unit tests from chrome/browser/

Makes over 200 tests pass on Linux.

Review URL: http://codereview.chromium.org/18758
------------------------------------------------------------------------
r9034 | ben@chromium.org | 2009-02-02 07:42:05 +0100 (Mon, 02 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/message_window.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   D /trunk/src/chrome/browser/web_app.cc
   D /trunk/src/chrome/browser/web_app.h
   D /trunk/src/chrome/browser/web_app_icon_manager.cc
   D /trunk/src/chrome/browser/web_app_icon_manager.h
   D /trunk/src/chrome/browser/web_app_launcher.cc
   D /trunk/src/chrome/browser/web_app_launcher.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Remove old web app code it's no longer needed. Simplifies startup a little.

Also fixes a regression from the BrowserInit porting work. I was a little over-zealous removing the CommandLine handling. It turns out that it's this that MessageWindow uses to convey the command line of the signalling process to the existing process, and that the existing process re-runs BrowserInit with the signalling process' command line. So I plumbed that back through again.

Review URL: http://codereview.chromium.org/19746
------------------------------------------------------------------------
r9030 | beng@google.com | 2009-02-01 21:24:01 +0100 (Sun, 01 Feb 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Will the real BrowserProcessImpl please stand up?

Review URL: http://codereview.chromium.org/19743
------------------------------------------------------------------------
r9029 | brettw@chromium.org | 2009-02-01 20:06:19 +0100 (Sun, 01 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/views/root_view_gtk.cc

More bustage fixes
------------------------------------------------------------------------
r9028 | brettw@chromium.org | 2009-02-01 19:59:35 +0100 (Sun, 01 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc

More bustage fixes.
------------------------------------------------------------------------
r9027 | brettw@chromium.org | 2009-02-01 19:54:57 +0100 (Sun, 01 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/visitedlink_master.h

More bustage fixes.
------------------------------------------------------------------------
r9026 | brettw@chromium.org | 2009-02-01 19:46:53 +0100 (Sun, 01 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc

More fixes.
------------------------------------------------------------------------
r9025 | brettw@chromium.org | 2009-02-01 19:41:15 +0100 (Sun, 01 Feb 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

More bustage fixes.
Review URL: http://codereview.chromium.org/19530
------------------------------------------------------------------------
r9024 | brettw@chromium.org | 2009-02-01 19:34:05 +0100 (Sun, 01 Feb 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Update the temp scaffolding stubs for my header change. It was pulling in the
notification service via some other dependency before.

Also fix some other omissions I made.
Review URL: http://codereview.chromium.org/19529
------------------------------------------------------------------------
r9023 | brettw@chromium.org | 2009-02-01 19:24:39 +0100 (Sun, 01 Feb 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc

Address a review comment I forgot in my previous patch.
------------------------------------------------------------------------
r9022 | brettw@chromium.org | 2009-02-01 19:23:00 +0100 (Sun, 01 Feb 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser_process.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/visitedlink_master.h

Fix a bunch of header includes. I removed some unnecessary headers from a
variety of places and added ones in other files that were accidentally
depending on them.
Review URL: http://codereview.chromium.org/19742
------------------------------------------------------------------------
r9020 | brettw@chromium.org | 2009-02-01 19:16:56 +0100 (Sun, 01 Feb 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_constrained_window_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.cc
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_node.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history_model.cc
   M /trunk/src/chrome/browser/history_model.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler_win.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/metrics/user_metrics.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/chrome/common/notification_registrar.cc
   M /trunk/src/chrome/common/notification_registrar.h
   M /trunk/src/chrome/common/notification_service.cc
   M /trunk/src/chrome/common/notification_service.h
   M /trunk/src/chrome/common/notification_service_unittest.cc
   A /trunk/src/chrome/common/notification_type.h (from /trunk/src/chrome/common/notification_types.h:9018)
   D /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/common/pref_member.cc
   M /trunk/src/chrome/common/pref_member.h
   M /trunk/src/chrome/common/pref_member_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/test/in_process_browser_test.cc
   M /trunk/src/chrome/test/in_process_browser_test.h
   M /trunk/src/chrome/test/test_notification_tracker.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/ui_test_utils.cc
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager.h
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view_win.cc
   M /trunk/src/chrome/views/view_storage.cc
   M /trunk/src/chrome/views/view_storage.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/window.cc

Remove most header file dependencies on the notification type list. It is
really painful to add more types, since lots of headers include the
notification service to derive from the notification observer. This splits that
out, so much less of the project should end up including notification_types.h

---Paths modified but not in any changelist:
Review URL: http://codereview.chromium.org/19744
------------------------------------------------------------------------
r9019 | beng@google.com | 2009-01-31 21:18:52 +0100 (Sat, 31 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/message_window.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Re-land this changelist to make BrowserInit work on Mac.

R=pinkerton,brettw

Review URL: http://codereview.chromium.org/19528
------------------------------------------------------------------------
r9017 | jar@chromium.org | 2009-01-31 06:11:50 +0100 (Sat, 31 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc

Remove DNS pre-resolution model of OS cache

Force OS to decide about doing network lookup, rather
than guessing whether it is in the cache before asking
the OS.  This will cost more OS operations, but should
roughly double the hit rate for scan based pre-resolution.

r=mbelshe
Review URL: http://codereview.chromium.org/19524
------------------------------------------------------------------------
r9006 | ericroman@google.com | 2009-01-31 02:34:20 +0100 (Sat, 31 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.cc
   A /trunk/src/chrome/browser/net/resolve_proxy_msg_helper.h
   A /trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Move proxy resolve requests out of plugin/renderer process, and into the browser.

Review URL: http://codereview.chromium.org/14142
------------------------------------------------------------------------
r9005 | erikkay@google.com | 2009-01-31 02:33:28 +0100 (Sat, 31 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   A /trunk/src/chrome/test/data/extensions/extension3
   A /trunk/src/chrome/test/data/extensions/extension3/1.0
   A /trunk/src/chrome/test/data/extensions/extension3/1.0/manifest.json
   A /trunk/src/chrome/test/data/extensions/extension3/Current Version

Add support for loading Current Version. (haven't removed the old style loading yet)

Review URL: http://codereview.chromium.org/19525
------------------------------------------------------------------------
r9003 | rvargas@google.com | 2009-01-31 02:19:57 +0100 (Sat, 31 Jan 2009) | 16 lines
Changed paths:
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc

Make sure that Clipboard operations that require dispatching
of windows messages are performed on the UI thread.

SetClipboardData requires the clipboard to be open with a handle
to a window that will be notified when the contents are going to
change again. If Windows messages are not processed, any other app
writing to the clipboard will be locked while we acknowledge their
request (by processing the message).

The IO thread doesn't pump windows messages anymore so write
clipboard operations cannot be performed from that thread and have
to be posted to another thread.

BUG=5823

Review URL: http://codereview.chromium.org/19733
------------------------------------------------------------------------
r9000 | ben@chromium.org | 2009-01-31 01:33:17 +0100 (Sat, 31 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Roll back these tab changes since there are still issues.

TBR=idanan
Review URL: http://codereview.chromium.org/19735
------------------------------------------------------------------------
r8999 | beng@google.com | 2009-01-31 01:21:27 +0100 (Sat, 31 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/message_window.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Rollback 8998

------------------------------------------------------------------------
r8998 | beng@google.com | 2009-01-31 00:52:16 +0100 (Sat, 31 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/message_window.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Bring up BrowserInit on MacOS X.

Review URL: http://codereview.chromium.org/19695
------------------------------------------------------------------------
r8995 | mpcomplete@google.com | 2009-01-31 00:36:41 +0100 (Sat, 31 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

Register .crx file handler to install Chrome extensions.

Have files of that type automatically download and open.
Review URL: http://codereview.chromium.org/19403
------------------------------------------------------------------------
r8994 | ananta@chromium.org | 2009-01-31 00:32:02 +0100 (Sat, 31 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Ignore invalid plugin windows coming in from the renderer for moving. As the plugin parent window which lives on the browser UI thread is destroyed asynchronously, we may have stale windows which have already been destroyed sent by the renderer for moving around.The DeferWindowPos API fails on receiving such a window.


Review URL: http://codereview.chromium.org/19523
------------------------------------------------------------------------
r8991 | tim@chromium.org | 2009-01-30 23:52:44 +0100 (Fri, 30 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/common/notification_types.h

NTP twiddling for p13n

Review URL: http://codereview.chromium.org/19420
------------------------------------------------------------------------
r8987 | brettw@chromium.org | 2009-01-30 22:17:02 +0100 (Fri, 30 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc

Random bits of de-Winification for WebContents.
Review URL: http://codereview.chromium.org/19721
------------------------------------------------------------------------
r8978 | brettw@chromium.org | 2009-01-30 20:34:38 +0100 (Fri, 30 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/js_before_unload_handler.cc
   M /trunk/src/chrome/browser/js_before_unload_handler.h
   A /trunk/src/chrome/browser/js_before_unload_handler_win.cc (from /trunk/src/chrome/browser/js_before_unload_handler.cc:8933)
   A /trunk/src/chrome/browser/js_before_unload_handler_win.h (from /trunk/src/chrome/browser/js_before_unload_handler.h:8933)
   D /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   A /trunk/src/chrome/browser/jsmessage_box_handler_win.cc (from /trunk/src/chrome/browser/jsmessage_box_handler.cc:8933)
   A /trunk/src/chrome/browser/jsmessage_box_handler_win.h (from /trunk/src/chrome/browser/jsmessage_box_handler.h:8933)
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

Allow porting of the JS message boxes. I split out the implementation into
platform-specific files, and have WebContents just use the platform-independent
header that declares the creation functions.
Review URL: http://codereview.chromium.org/19719
------------------------------------------------------------------------
r8977 | phajdan.jr@chromium.org | 2009-01-30 20:33:53 +0100 (Fri, 30 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h

Correct sqlite wrapper behavior on systems where wchar_t is UTF-32,
for example Linux.

The problem was that old code assumed wstring is UTF-16, which resulted
in string corruption on Linux. I actually tested it on browser/history
unit tests, see http://codereview.chromium.org/18758.

Review URL: http://codereview.chromium.org/18805
------------------------------------------------------------------------
r8975 | maruel@chromium.org | 2009-01-30 20:16:54 +0100 (Fri, 30 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj

Fix EOL.

------------------------------------------------------------------------
r8971 | brettw@google.com | 2009-01-30 19:46:24 +0100 (Fri, 30 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.h

Make the download manager compile on Linux & Mac.
Review URL: http://codereview.chromium.org/19711
------------------------------------------------------------------------
r8951 | brettw@chromium.org | 2009-01-30 06:59:59 +0100 (Fri, 30 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Porting in the download manager (plus tiny bits of cleanup).
Review URL: http://codereview.chromium.org/19697
------------------------------------------------------------------------
r8949 | gwilson@google.com | 2009-01-30 03:56:15 +0100 (Fri, 30 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Modifies LaunchSetupWithParam to properly append the kInstallerDir and kSetupExe constants to the executable path.

Review URL: http://codereview.chromium.org/19493
------------------------------------------------------------------------
r8948 | cpu@google.com | 2009-01-30 03:36:55 +0100 (Fri, 30 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Move RLZ back to 90 seconds delayed init

BUG=1609821

Review URL: http://codereview.chromium.org/19694
------------------------------------------------------------------------
r8947 | pkasting@chromium.org | 2009-01-30 03:36:54 +0100 (Fri, 30 Jan 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/views/custom_frame_window.cc

Fix various problems with constrained windows and/or custom frame windows:
* Wrong titlebar height
* Titlebars not handling custom font size properly
* Drawing errors in maximized mode
* One-pixel overlap glitch on bottom corners of client edges
* Borders not handling custom border sizes correctly
* Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip)
* Wrong icon sizing (only a problem in theory, no one uses this code ATM)

These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable.

BUG=5054
Review URL: http://codereview.chromium.org/19484
------------------------------------------------------------------------
r8940 | wtc@chromium.org | 2009-01-30 02:13:22 +0100 (Fri, 30 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Change kMetricsURL to
https://clients4.google.com/firefox/metrics/collect,
which has a certificate that matches the host name.
Remove the net::LOAD_IGNORE_CERT_COMMON_NAME_INVALID
load flag.

R=evanm
BUG=b/876021
Review URL: http://codereview.chromium.org/19450
------------------------------------------------------------------------
r8934 | sky@google.com | 2009-01-30 01:40:43 +0100 (Fri, 30 Jan 2009) | 10 lines
Changed paths:
   M /trunk/src/base/command_line.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   A /trunk/src/chrome/browser/views/find_bar_win_unittest.cc
   M /trunk/src/chrome/common/main_function_params.h
   A /trunk/src/chrome/test/in_process_browser_test.cc
   A /trunk/src/chrome/test/in_process_browser_test.h
   A /trunk/src/chrome/test/ui_test_utils.cc
   A /trunk/src/chrome/test/ui_test_utils.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Provides the ability to write a unit test that brings up a browser. As
a proof of concept I converted
FindInPageControllerTest.FindInPageFrames over to this.

See the description in InProcessBrowserTest for how it all works.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/19644
------------------------------------------------------------------------
r8933 | thestig@chromium.org | 2009-01-30 01:34:11 +0100 (Fri, 30 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   M /trunk/src/skia/ext/platform_canvas_mac.h
   M /trunk/src/skia/ext/platform_canvas_win.cc
   M /trunk/src/skia/ext/platform_canvas_win.h

Fix a bunch of lint complaints in preparation to land issue 19046. Mostly formatting changes, i.e. CRLF, space at end of line.
Review URL: http://codereview.chromium.org/19486
------------------------------------------------------------------------
r8930 | tc@google.com | 2009-01-30 00:32:06 +0100 (Fri, 30 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   A /trunk/src/base/idle_timer_none.cc
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/chrome_exe_main.mm
   A /trunk/src/chrome/app/chrome_exe_main_gtk.cc (from /trunk/src/chrome/app/chrome_exe_main.mm:8929)
   M /trunk/src/chrome/browser/browser.scons
   A /trunk/src/chrome/browser/browser_main_gtk.cc
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc

Create a stub chrome executable that crashes when run.

This is mostly making sure we have all the symbols we need.

Review URL: http://codereview.chromium.org/19683

------------------------------------------------------------------------
r8928 | cpu@google.com | 2009-01-30 00:25:08 +0100 (Fri, 30 Jan 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/setup/setup_constants.cc
   M /trunk/src/chrome/installer/setup/setup_constants.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc

This CL fixes bugs with EULA
- The first run import will trigger the eula again : this requires changes in browser_main.cc
  so the master prefs are not processed again by the importer process
- The launch of setup.exe to show the eula was using a path that only works on developer builds
  this requires relocating a constant from setup_constants to util_constants

BUG=1468838


Review URL: http://codereview.chromium.org/19680
------------------------------------------------------------------------
r8927 | pkasting@chromium.org | 2009-01-30 00:25:05 +0100 (Fri, 30 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/views/custom_frame_window.cc

Reorganize DefaultNonClientView and ConstrainedWindowNonClientView to match changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation.

This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible.  The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes.

This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons.  (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.)
Review URL: http://codereview.chromium.org/19684
------------------------------------------------------------------------
r8926 | erikkay@google.com | 2009-01-30 00:19:19 +0100 (Fri, 30 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_types.h
   A /trunk/src/chrome/test/data/extensions/bad_hash.crx
   A /trunk/src/chrome/test/data/extensions/bad_json.crx
   A /trunk/src/chrome/test/data/extensions/bad_magic.crx
   D /trunk/src/chrome/test/data/extensions/extension1/manifest
   A /trunk/src/chrome/test/data/extensions/extension1/manifest.json (from /trunk/src/chrome/test/data/extensions/extension1/manifest:7887)
   D /trunk/src/chrome/test/data/extensions/extension2/manifest
   A /trunk/src/chrome/test/data/extensions/extension2/manifest.json (from /trunk/src/chrome/test/data/extensions/extension2/manifest:7887)
   A /trunk/src/chrome/test/data/extensions/good.crx
   A /trunk/src/chrome/test/data/extensions/not_an_extension.crx
   M /trunk/src/chrome/tools/extensions/chromium_extension.py

Simple installation of extensions using chrome.exe --install-extensionChanged manifest filename to end in .json.Updated authoring script to include sha256 hash of zip file.

Review URL: http://codereview.chromium.org/18477
------------------------------------------------------------------------
r8923 | brettw@chromium.org | 2009-01-30 00:00:43 +0100 (Fri, 30 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h

Clean up the Windows-ness in the sizing of new views. Write a bunch of comments
about issues I discovered in this process.
Review URL: http://codereview.chromium.org/19677
------------------------------------------------------------------------
r8916 | pkasting@chromium.org | 2009-01-29 23:06:40 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h

Per Glen, remove the bottom border of maximized windows.  I went ahead and also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be.
Review URL: http://codereview.chromium.org/19477
------------------------------------------------------------------------
r8915 | sky@google.com | 2009-01-29 22:59:55 +0100 (Thu, 29 Jan 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/net/cache_uitest.cc
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h

Provide the option for HTTPServer to be created with a specific
MessageLoop. I'm going to need this when running ui tests in
process. In this case I'll pass in the IO thread.

I'll change all callers to use the new method, but before doing that
wanted to make sure you're ok with it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/19039
------------------------------------------------------------------------
r8913 | mpcomplete@google.com | 2009-01-29 22:29:15 +0100 (Thu, 29 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Re-enable the NoScript unittest.

Turns out we need to broadcast the NOTIFY_USER_SCRIPTS_LOADED message even if
there are no scripts.  I just removed the DCHECK that expects scripts.
Review URL: http://codereview.chromium.org/19475
------------------------------------------------------------------------
r8909 | pinkerton@chromium.org | 2009-01-29 21:16:06 +0100 (Thu, 29 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/BrowserWindow.xib
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

rest of the rename, accidentally leftout. TBR.
------------------------------------------------------------------------
r8905 | pinkerton@chromium.org | 2009-01-29 21:05:47 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/cocoa/tab_bar_view.h
   D /trunk/src/chrome/browser/cocoa/tab_bar_view.mm
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   M /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   A /trunk/src/chrome/browser/cocoa/tab_strip_view.h (from /trunk/src/chrome/browser/cocoa/tab_bar_view.h:8902)
   A /trunk/src/chrome/browser/cocoa/tab_strip_view.mm (from /trunk/src/chrome/browser/cocoa/tab_bar_view.mm:8902)

rename from tab_bar to tab_strip to be more consistent with windows
Review URL: http://codereview.chromium.org/19473
------------------------------------------------------------------------
r8902 | pinkerton@google.com | 2009-01-29 20:24:21 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/BrowserWindow.xib
   M /trunk/src/chrome/app/nibs/English.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa/tab_strip_controller.h
   A /trunk/src/chrome/browser/cocoa/tab_strip_controller.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

hookup tabs to the model and handle new tab creation
Review URL: http://codereview.chromium.org/19669
------------------------------------------------------------------------
r8900 | pkasting@chromium.org | 2009-01-29 20:05:51 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

Remove pointless function override (the base class does the exact same thing already).
Review URL: http://codereview.chromium.org/19653
------------------------------------------------------------------------
r8898 | brettw@google.com | 2009-01-29 19:41:13 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/cocoa/shell_dialogs_mac.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Add a stub shell dialogs to help us get linking faster.
Review URL: http://codereview.chromium.org/19672
------------------------------------------------------------------------
r8897 | maruel@chromium.org | 2009-01-29 19:40:23 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Disable the test while investigating.
Review URL: http://codereview.chromium.org/19671
------------------------------------------------------------------------
r8896 | glen@chromium.org | 2009-01-29 19:35:42 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/deps/third_party/WebKit/WebCore/loader/FrameLoader.cpp
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc

Change chrome:// to chrome-ui://, fix up one chrome-resource:// reference.
Review URL: http://codereview.chromium.org/18175
------------------------------------------------------------------------
r8895 | brettw@chromium.org | 2009-01-29 19:11:14 +0100 (Thu, 29 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/browser/views/shell_dialogs.cc
   A /trunk/src/chrome/browser/views/shell_dialogs_win.cc (from /trunk/src/chrome/browser/views/shell_dialogs.cc:8883)

Make the shared shell dialog not use Windows types, as well as the web contents
code that runs it.
Review URL: http://codereview.chromium.org/19666
------------------------------------------------------------------------
r8891 | pkasting@chromium.org | 2009-01-29 18:51:45 +0100 (Thu, 29 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h

Move kClientEdgeThickness from BrowserView to NonClientView (which makes more sense anyway) so I'll be able to use it in custom_frame_window.cc.

Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places.  Seems I couldn't make up my mind on that one.
Review URL: http://codereview.chromium.org/19458
------------------------------------------------------------------------
r8886 | maruel@chromium.org | 2009-01-29 17:58:07 +0100 (Thu, 29 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Re-land revision 8821 with the ui test fixed.

Disconnect the "browser controlled printing" and always delegate the control flow to the renderer.
Simplify the tests by not using a message loop anymore.

Followup changes will remove more parts that are not needed anymore.
Review URL: http://codereview.chromium.org/19460
------------------------------------------------------------------------
r8879 | maruel@chromium.org | 2009-01-29 17:08:23 +0100 (Thu, 29 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc

Disable DownloadTest.UnknownSize because it is flaky.

BUG=7191
Review URL: http://codereview.chromium.org/19665
------------------------------------------------------------------------
r8878 | brettw@chromium.org | 2009-01-29 16:57:57 +0100 (Thu, 29 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h

Remove the Windows set focus call and bad-design browser call from the new tab
UI by plumbing through a delegate notification. This will also fix metrics for
the "focus the URL bar" command.

This also includes some OCD URL-formatting changes to the DOM UI that I noticed.
Review URL: http://codereview.chromium.org/19455
------------------------------------------------------------------------
r8866 | cpu@google.com | 2009-01-29 04:27:35 +0100 (Thu, 29 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/util/html_dialog.h
   M /trunk/src/chrome/installer/util/html_dialog_impl.cc
   M /trunk/src/chrome/installer/util/util_constants.h

Wire the stats consent checkbox of the EULA
- Collected in setup.exe passed to chrome via return code
- Depends on an updated oem.html and JS code by Glen

BUG=1468838


Review URL: http://codereview.chromium.org/19649
------------------------------------------------------------------------
r8857 | mpcomplete@chromium.org | 2009-01-29 03:07:25 +0100 (Thu, 29 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc

Temporarily disable failing test while I fix it.

TBR=aa

Review URL: http://codereview.chromium.org/19654
------------------------------------------------------------------------
r8854 | paulg@google.com | 2009-01-29 02:53:05 +0100 (Thu, 29 Jan 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/clipboard_conversion.cc
   M /trunk/src/webkit/glue/webdropdata.h

Generate a proper file name when dragging an image from a
web page to the desktop.

We receive information about the image from WebKit in the
render which includes the image URL, MIME type and a guess
as to what the file name is. If the filename is empty, we
synthesize a file name based on the URL. In all cases, we
set the file extension to the MIME type that was detected
by WebKit.

This change is the Chromium portion of image dragging. The
WebKit portion has been committed as:
http://trac.webkit.org/changeset/40294

BUG=6481 (http://crbug.com/6481)

Review URL: http://codereview.chromium.org/19417
------------------------------------------------------------------------
r8851 | mpcomplete@chromium.org | 2009-01-29 02:12:05 +0100 (Thu, 29 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master.cc

Fix DCHECK when handling NOTIFY_USER_SCRIPTS_LOADED by not broadcasting the
message if we don't have any scripts.

Review URL: http://codereview.chromium.org/19441
------------------------------------------------------------------------
r8849 | pkasting@chromium.org | 2009-01-29 01:55:57 +0100 (Thu, 29 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Fix incorrect spacing/width calculation for titlebar text.  I used the wrong constants, oops.

Also some tiny reorderings and similar nonfunctional changes in order to make this class closer to its sibling NonClientView subclasses, so I can eventually refactor them all more easily.
Review URL: http://codereview.chromium.org/19447
------------------------------------------------------------------------
r8847 | rvargas@google.com | 2009-01-29 01:30:47 +0100 (Thu, 29 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/completion_callback.h
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   A /trunk/src/net/base/io_buffer.h
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_simple_job.cc
   M /trunk/src/net/url_request/url_request_simple_job.h
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_test_job.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Change URLRequest to use a ref-counted buffer for actual IO.

This will re-land http://codereview.chromium.org/18390

BUG=5325

Review URL: http://codereview.chromium.org/19004
------------------------------------------------------------------------
r8846 | brettw@chromium.org | 2009-01-29 01:30:32 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc

Rename RenderWidgetHostView::GetPluginHWND to GetPluginNativeView
Review URL: http://codereview.chromium.org/19438
------------------------------------------------------------------------
r8841 | tim@chromium.org | 2009-01-29 01:13:46 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.h

fix p13n build.
Review URL: http://codereview.chromium.org/18835
------------------------------------------------------------------------
r8834 | mark@chromium.org | 2009-01-29 00:37:55 +0100 (Thu, 29 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Roll back r8821
Review URL: http://codereview.chromium.org/19453
------------------------------------------------------------------------
r8832 | tc@google.com | 2009-01-29 00:13:22 +0100 (Thu, 29 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons

Add browser files to the linux build that mac has already
ported and added to the xcode build.

Not much here, seems the earlier porting stuff just works.

Review URL: http://codereview.chromium.org/19637

------------------------------------------------------------------------
r8831 | avi@chromium.org | 2009-01-28 22:54:32 +0100 (Wed, 28 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/message_window.cc
   M /trunk/src/chrome/browser/message_window.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url.cc
   M /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Porting profiles to the Mac.

Review URL: http://codereview.chromium.org/19623
------------------------------------------------------------------------
r8830 | sky@google.com | 2009-01-28 22:53:16 +0100 (Wed, 28 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/rlz/rlz.h

Adds cleanup code to RLZ so that we don't leak an OmniBoxUsageObserver
on shutdown. This came up in running in process ui tests through
purify.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/19428
------------------------------------------------------------------------
r8828 | joshia@google.com | 2009-01-28 22:50:39 +0100 (Wed, 28 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Better control over window creation of external tabs

Improving automation interface to offer better control over
window creation of external tabs. The changes allow us
to specify a parent window, initial size and window style.


Review URL: http://codereview.chromium.org/19048
------------------------------------------------------------------------
r8827 | brettw@chromium.org | 2009-01-28 22:39:21 +0100 (Wed, 28 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/browser/views/logging_about_dialog.cc
   D /trunk/src/chrome/browser/views/logging_about_dialog.h

Reverting 8822.
Review URL: http://codereview.chromium.org/19439
------------------------------------------------------------------------
r8826 | creis@google.com | 2009-01-28 22:15:49 +0100 (Wed, 28 Jan 2009) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc

This prevents an occasional DCHECK seen during the SSL UI test that happened
because of the unresponsive tab logic.  If we are short-cutting a slow
beforeunload handler, we now avoid a redundant call to SetNavigationsSuspended.

Also clarified a few comments, removed what appeared to be an unnecessary call
to DidNavigateMainFrame, and re-enabled tests that were likely disabled due
to this issue.

BUG=6950
BUG=6698
TEST=SSLUITest.TestHTTPSExpiredCertAndDontProceed --single-process
TEST=SSLUITest.TestHTTPWithBrokenHTTPSResource
TEST=SSLUITest.TestOKHTTPS
TEST=SSLUITest.TestHTTPSExpiredCertAndProceed



Review URL: http://codereview.chromium.org/19006
------------------------------------------------------------------------
r8822 | brettw@chromium.org | 2009-01-28 21:30:15 +0100 (Wed, 28 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_network_dialog.cc
   M /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   A /trunk/src/chrome/browser/views/logging_about_dialog.cc (from /trunk/src/chrome/browser/views/about_network_dialog.cc:8721)
   A /trunk/src/chrome/browser/views/logging_about_dialog.h (from /trunk/src/chrome/browser/views/about_network_dialog.h:8721)

Factor out the common parts of the about network dialog. I will be using this
for the about IPC dialog next.
Review URL: http://codereview.chromium.org/19433
------------------------------------------------------------------------
r8821 | maruel@chromium.org | 2009-01-28 21:23:58 +0100 (Wed, 28 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Disconnect the "browser controlled printing" and always delegate the control flow to the renderer.
Followup changes will remove more parts that are not needed anymore.
Review URL: http://codereview.chromium.org/18860
------------------------------------------------------------------------
r8820 | ananta@chromium.org | 2009-01-28 21:23:48 +0100 (Wed, 28 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc

Ensure that windowed plugins get keyboard focus in WM_MOUSEACTIVATe. This regressed with the introduction
of the Plugin wrapper window which parents the actual plugin window in the plugin process. We need to set focus to the actual plugin window when we receive a WM_MOUSEACTIVATE in the browser caused by a click on the plugin window.

This fixes http://code.google.com/p/chromium/issues/detail?id=7143

Bug=7143

Review URL: http://codereview.chromium.org/19626
------------------------------------------------------------------------
r8819 | brettw@chromium.org | 2009-01-28 21:14:45 +0100 (Wed, 28 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc

Make WebContentsView portable by using the native view types.
Review URL: http://codereview.chromium.org/19632
------------------------------------------------------------------------
r8817 | jeremy@chromium.org | 2009-01-28 19:58:06 +0100 (Wed, 28 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.cc

Remove extrenuous DLOG from VisitedLinkMaster::InitFromFile()
since it prints a confusing message on first run.

Review URL: http://codereview.chromium.org/19429
------------------------------------------------------------------------
r8816 | sidchat@google.com | 2009-01-28 19:50:55 +0100 (Wed, 28 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Get rid of unnecessary region code from spellcheck language/locale codes. Fix of Linux by using ARRAYSIZE_UNSAFE instead of arraysize.

Issue=Issue=6329
Review URL: http://codereview.chromium.org/18567
------------------------------------------------------------------------
r8815 | pkasting@chromium.org | 2009-01-28 19:39:02 +0100 (Wed, 28 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc
   M /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/context_node_types.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Context menus for text selections in editable boxes and links should include the Search menu item.  Original patch by Brian Duff (see http://codereview.chromium.org/16510 ), r=me.

BUG=1925
------------------------------------------------------------------------
r8806 | brettw@chromium.org | 2009-01-28 18:45:19 +0100 (Wed, 28 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc
   M /trunk/src/chrome/common/ipc_test_sink.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Write some basic RenderWidgetHost unittests for the more tricky behavior.
Review URL: http://codereview.chromium.org/19419
------------------------------------------------------------------------
r8800 | aa@chromium.org | 2009-01-28 10:22:44 +0100 (Wed, 28 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Remove extraneous uses of the --enable-user-script
switch. It's better to check this at one chokepoint
(initialization) and let the rest of the code work
the same, but end up as no-ops.

Review URL: http://codereview.chromium.org/18401
------------------------------------------------------------------------
r8797 | estade@chromium.org | 2009-01-28 06:47:15 +0100 (Wed, 28 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h

Safe browsing cleanup:

* wstring -> FilePath
* create versions of WriteFile/ReadFile with FilePath signatures

Review URL: http://codereview.chromium.org/19610
------------------------------------------------------------------------
r8795 | sky@google.com | 2009-01-28 06:32:19 +0100 (Wed, 28 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h

Adds a variable indicating whether resources should be deleted on
shutdown. Normally it's true, but I'm going to set it to false for in
process ui tests. I can't delete the ResourceBundle for these tests as
many classes cache SkBitmaps from the resource bundle in statics.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/19609
------------------------------------------------------------------------
r8794 | mal@chromium.org | 2009-01-28 05:25:58 +0100 (Wed, 28 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Rolback r8793: Remove extraneous uses of the --enable-user-script
switch. It's better to check this at one chokepoint
(initialization) and let the rest of the code work
the same, but end up as no-ops.

This seems to break ui_tests.


Review URL: http://codereview.chromium.org/19418
------------------------------------------------------------------------
r8793 | aa@chromium.org | 2009-01-28 04:29:28 +0100 (Wed, 28 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Remove extraneous uses of the --enable-user-script
switch. It's better to check this at one chokepoint
(initialization) and let the rest of the code work
the same, but end up as no-ops.

Review URL: http://codereview.chromium.org/18401
------------------------------------------------------------------------
r8792 | agl@chromium.org | 2009-01-28 03:59:07 +0100 (Wed, 28 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/renderer_host/backing_store.cc
   M /trunk/src/chrome/browser/renderer_host/backing_store_win.cc

Move Windows specific backing-store functions into backing_store_win.cc

A previous change forked backing_store.cc into backing_store_win.cc. This patch
trims both to leave the platform-independent functions in backing_store.cc and
the Windows specific functions in backing_store_win.cc.

Review URL: http://codereview.chromium.org/19605

------------------------------------------------------------------------
r8790 | cpu@google.com | 2009-01-28 03:45:17 +0100 (Wed, 28 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Process the EULA distro param, to direct chrome to show the EULA dialog
- This is the EULA post installation case. Other cases possible.
- Chrome waits forever until user dismises the dialog
- Chrome will exit ipso-facto if user declines.

BUG=1468838


Review URL: http://codereview.chromium.org/19601
------------------------------------------------------------------------
r8782 | jrg@chromium.org | 2009-01-28 02:30:17 +0100 (Wed, 28 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/renderer/render_process.cc
   A /trunk/src/chrome/renderer/render_process_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   A /trunk/src/webkit/glue/mock_webkit_glue.cc

Unit test addition, cleanup for render_process/thread.

Review URL: http://codereview.chromium.org/19606
------------------------------------------------------------------------
r8780 | kuchhal@chromium.org | 2009-01-28 02:17:58 +0100 (Wed, 28 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Make purify happy by fixing memory leak that shows up during shutdown.

BUG=6528

Review URL: http://codereview.chromium.org/19407
------------------------------------------------------------------------
r8773 | sky@google.com | 2009-01-28 01:15:54 +0100 (Wed, 28 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Adds the ability to have browser windows shown with a specific
state. I need this for in process ui tests. I can move this to be
private and make the test a friend if you prefer.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/19404
------------------------------------------------------------------------
r8771 | agl@chromium.org | 2009-01-28 00:51:12 +0100 (Wed, 28 Jan 2009) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/renderer_host/backing_store_win.cc (from /trunk/src/chrome/browser/renderer_host/backing_store.cc:8769)

Fork backing_store.cc into backing_store_win.cc in preparation for a
future CL which will delete the Windows specific code from
backing_store.cc and the platform-independent code from
backing_store_win.cc.

By forking in this manner, history is correctly preserved.

------------------------------------------------------------------------
r8768 | sky@google.com | 2009-01-28 00:20:12 +0100 (Wed, 28 Jan 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h

Modifies shutdown/startup in the following manner:

. Before registering the scheme 'chrome' with GURL we make sure it
  isn't already registered. I need this as I'm going to invoke
  BrowserMain multiple times and didn't want the list of schemes to
  have n-chromes.
. Removes ResourceBundle::CleanupSharedInstance from
  browser_shutdown. We do this from BrowserMain already, so there is
  no need in doing it here.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/18861
------------------------------------------------------------------------
r8764 | darin@chromium.org | 2009-01-27 23:28:54 +0100 (Tue, 27 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.h

Add support for UA spoofing, and spoof Safari's UA string when loading URLs
from *.mail.live.com (to fix hotmail).

BUG=4111
R=wtc

Review URL: http://codereview.chromium.org/19025
------------------------------------------------------------------------
r8763 | pkasting@chromium.org | 2009-01-27 23:26:11 +0100 (Tue, 27 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/theme/locationbg_readonly_left.png
   M /trunk/src/chrome/app/theme/locationbg_readonly_right.png
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc

Extend the popup-mode location bar out into the nonclient view.  This makes popup mode pixel perfect except for the off-by-one sizing regression caught by the interactive UI test, which I haven't figured out yet.

BUG=5054
Review URL: http://codereview.chromium.org/18862
------------------------------------------------------------------------
r8762 | ben@chromium.org | 2009-01-27 23:17:29 +0100 (Tue, 27 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/message_window.cc
   A /trunk/src/chrome/browser/message_window.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Move MessageWindow out into its own file. BrowserInit is now cross-platform-capable.

Fix up the header includes in browser_init.cc/h removing a bunch of windows stuff.

Review URL: http://codereview.chromium.org/19034
------------------------------------------------------------------------
r8758 | pkasting@chromium.org | 2009-01-27 23:00:33 +0100 (Tue, 27 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Fix a small, subtle problem that caused an interactive_ui_test failure.

BUG=5054
Review URL: http://codereview.chromium.org/18865
------------------------------------------------------------------------
r8756 | agl@chromium.org | 2009-01-27 22:39:15 +0100 (Tue, 27 Jan 2009) | 16 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/gfx/native_widget_types.h
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   A /trunk/src/chrome/common/modal_dialog_event.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/pending/AccessibleBase.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

POSIX: gfx::NativeViewId and CrossProcessEvent

Create a couple new typedefs for porting work. Firstly,
gfx::NativeViewId is a handle to a platform specific widget in the
renderer process. For Windows, this is just a HWND as before. However,
in other platforms the ids used in the renderer process will be
something else.

CrossProcessEvent is the type of a HANDLE to a Windows event object
which is used across processes. Since we aren't going to support these
sorts of events on non-Windows platforms, this will have to go away at
some point. For now, however, this lets us build code without too many
ifdefs all over the place.

Review URL: http://codereview.chromium.org/18768

------------------------------------------------------------------------
r8755 | tommi@chromium.org | 2009-01-27 22:30:30 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc

Give the container a chance to handle function keys.

Review URL: http://codereview.chromium.org/19036
------------------------------------------------------------------------
r8745 | ben@chromium.org | 2009-01-27 21:15:35 +0100 (Tue, 27 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/location_bar.h (from /trunk/src/chrome/browser/location_bar.h:8703)
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/test_browser_window.h
   A /trunk/src/chrome/test/test_location_bar.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Re-land this from earlier... unit tests no longer crash.

Extract a cross platform LocationBar interface.
Adds a TestLocationBar object that unit tests can use to mock the location bar (fixes NULL deref).

Review URL: http://codereview.chromium.org/18851
------------------------------------------------------------------------
r8740 | pinkerton@google.com | 2009-01-27 20:41:20 +0100 (Tue, 27 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

remove scaffolding mock of TabStripModel and replace it with the real deal. Remove some more ifdefs in Browser to implement delegate overrides.
Review URL: http://codereview.chromium.org/19019
------------------------------------------------------------------------
r8734 | jeremy@chromium.org | 2009-01-27 20:08:39 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Roll forward 8722,8721

Review URL: http://codereview.chromium.org/19028
------------------------------------------------------------------------
r8732 | jrg@chromium.org | 2009-01-27 20:04:50 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/renderer/render_thread_unittest.cc
   M /trunk/src/chrome/renderer/render_view_unittest.cc
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/webkit/glue/glue_accessibility.h

render_* work.

Review URL: http://codereview.chromium.org/18650
------------------------------------------------------------------------
r8731 | sky@google.com | 2009-01-27 19:41:14 +0100 (Tue, 27 Jan 2009) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fixes tab contents crash. This changes a number of things in dragged
tab controller:

. DraggedTabController now installs itself as the delegate of the
  TabContents immediately. It needs to do this so that it can stay in
  sync if the selected TabContents of the NavigationController
  changes.
. DraggedTabController forwards changes to the selected TabContents to
  the original delegate. This needs to be done so that the original
  delegate can do any cleanup it needs to do. For example, Browser
  needs to know if the tab contents changes so that it can remove
  entries from its internal mapping of what TabContents need to be
  updated. Similarly the TabStripModel needs to install a listener on
  the new TabContents type.
. If the tab is destroyed while dragging we shouldn't set the
  attached_tabstrip_ to NULL. Doing so results in invoking
  source_tabstrip_->DestroyDraggedSourceTab(source_tab_), which is not
  what should happen.

These changes are subtle, so give them a good think.

BUG=6369
TEST=this is covered by chrome bot tests. But be sure and exercise tab
  dragging in as many permutations as you can to make sure this
  doesn't break anything.

Review URL: http://codereview.chromium.org/19026
------------------------------------------------------------------------
r8726 | pkasting@chromium.org | 2009-01-27 18:58:51 +0100 (Tue, 27 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Make popups closer to pixel-perfect.  The main problem is that the toolbar is constrained to the width of the client area, when it actually needs to extend out two pixesl on each side into the current nonclient area.  I don't have a good fix for this, hoping Ben comes up with a brilliant idea.

BUG=5054
Review URL: http://codereview.chromium.org/18799
------------------------------------------------------------------------
r8723 | maruel@chromium.org | 2009-01-27 18:38:31 +0100 (Tue, 27 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Reverting 8722,8721.
Review URL: http://codereview.chromium.org/19024
------------------------------------------------------------------------
r8721 | jeremy@chromium.org | 2009-01-27 18:13:02 +0100 (Tue, 27 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

First step of porting VisitedLinkMaster to POSIX:
* Use POSIX file access APIs rather than HANDLEs.
* Add stubs so that VisitedLinkMaster compiles on POSIX.

Still to be done:
* Bring up Surrounding infrastructure to turn on unit tests.

Review URL: http://codereview.chromium.org/18530
------------------------------------------------------------------------
r8718 | avi@chromium.org | 2009-01-27 17:28:44 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_main.cc

Unimportant cleanup.

Review URL: http://codereview.chromium.org/18847
------------------------------------------------------------------------
r8704 | nsylvain@chromium.org | 2009-01-27 04:39:30 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   D /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Revert change 8693 because it breaks the unit_tests.
TBR
Review URL: http://codereview.chromium.org/19009
------------------------------------------------------------------------
r8699 | estade@chromium.org | 2009-01-27 03:46:41 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/base.sln
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_gfx.vsprops
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/gfx/base_gfx.scons
   A /trunk/src/base/gfx/jpeg_codec.cc (from /trunk/src/base/gfx/jpeg_codec.cc:8692)
   A /trunk/src/base/gfx/jpeg_codec.h (from /trunk/src/base/gfx/jpeg_codec.h:8692)
   A /trunk/src/base/gfx/jpeg_codec_unittest.cc (from /trunk/src/base/gfx/jpeg_codec_unittest.cc:8692)
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/common.vsprops
   D /trunk/src/chrome/common/jpeg_codec.cc
   D /trunk/src/chrome/common/jpeg_codec.h
   D /trunk/src/chrome/common/jpeg_codec_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Try2 of issue 18772. (move jpeg_codec* to base/gfx)

Review URL: http://codereview.chromium.org/18838
------------------------------------------------------------------------
r8696 | kuchhal@chromium.org | 2009-01-27 02:32:20 +0100 (Tue, 27 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration.cc

Fix regression caused by CommandLine change.

BUG=6863

Review URL: http://codereview.chromium.org/19001
------------------------------------------------------------------------
r8694 | estade@chromium.org | 2009-01-27 02:11:36 +0100 (Tue, 27 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_gfx.vsprops
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/gfx/base_gfx.scons
   D /trunk/src/base/gfx/jpeg_codec.cc
   D /trunk/src/base/gfx/jpeg_codec.h
   D /trunk/src/base/gfx/jpeg_codec_unittest.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/common.vsprops
   A /trunk/src/chrome/common/jpeg_codec.cc (from /trunk/src/chrome/common/jpeg_codec.cc:8691)
   A /trunk/src/chrome/common/jpeg_codec.h (from /trunk/src/chrome/common/jpeg_codec.h:8691)
   A /trunk/src/chrome/common/jpeg_codec_unittest.cc (from /trunk/src/chrome/common/jpeg_codec_unittest.cc:8691)
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

undo 8692 (fix build failure)

------------------------------------------------------------------------
r8693 | ben@chromium.org | 2009-01-27 02:07:18 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/location_bar.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Extract a cross-platform LocationBar interface accessible via the BrowserWindow interface that the Browser object can use to do locationbar-ey things without directly depending on Views.

Review URL: http://codereview.chromium.org/18826
------------------------------------------------------------------------
r8692 | estade@chromium.org | 2009-01-27 02:04:56 +0100 (Tue, 27 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_gfx.vsprops
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/gfx/base_gfx.scons
   A /trunk/src/base/gfx/jpeg_codec.cc (from /trunk/src/chrome/common/jpeg_codec.cc:8639)
   A /trunk/src/base/gfx/jpeg_codec.h (from /trunk/src/chrome/common/jpeg_codec.h:8639)
   A /trunk/src/base/gfx/jpeg_codec_unittest.cc (from /trunk/src/chrome/common/jpeg_codec_unittest.cc:8639)
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/common.vsprops
   D /trunk/src/chrome/common/jpeg_codec.cc
   D /trunk/src/chrome/common/jpeg_codec.h
   D /trunk/src/chrome/common/jpeg_codec_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Move jpeg_codec.* to base/gfx

Review URL: http://codereview.chromium.org/18772
------------------------------------------------------------------------
r8683 | agl@chromium.org | 2009-01-27 00:43:04 +0100 (Tue, 27 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Revert "Make render_view_host compile on Mac & Linux, add to the build."

Review URL: http://codereview.chromium.org/18796

------------------------------------------------------------------------
r8680 | brettw@chromium.org | 2009-01-27 00:31:48 +0100 (Tue, 27 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc

Fix the build.
Review URL: http://codereview.chromium.org/18829
------------------------------------------------------------------------
r8677 | brettw@chromium.org | 2009-01-27 00:28:04 +0100 (Tue, 27 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc

Fix the build.
Review URL: http://codereview.chromium.org/18790
------------------------------------------------------------------------
r8672 | brettw@google.com | 2009-01-27 00:19:03 +0100 (Tue, 27 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h

Make render_view_host compile on Mac & Linux, add to the build.
Review URL: http://codereview.chromium.org/18600
------------------------------------------------------------------------
r8663 | erikkay@google.com | 2009-01-26 22:38:11 +0100 (Mon, 26 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/common/unzip.cc
   M /trunk/src/net/base/file_stream.h
   M /trunk/src/net/base/file_stream_posix.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/file_stream_win.cc
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/url_request/url_request_file_job.cc

Change FileStream to use FilePath instead of wstring.
Review URL: http://codereview.chromium.org/18764
------------------------------------------------------------------------
r8661 | phajdan.jr@chromium.org | 2009-01-26 21:57:48 +0100 (Mon, 26 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/views/SConscript

Include chrome/browser/views/SConscript in Linux build.

And build few files from there on Linux.

Review URL: http://codereview.chromium.org/18760
------------------------------------------------------------------------
r8660 | brettw@chromium.org | 2009-01-26 21:52:26 +0100 (Mon, 26 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_helper.h
   M /trunk/src/chrome/browser/resource_message_filter.cc

Make RenderWidgetHelper portable.
Review URL: http://codereview.chromium.org/18802
------------------------------------------------------------------------
r8658 | pkasting@chromium.org | 2009-01-26 21:28:25 +0100 (Mon, 26 Jan 2009) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h

This change should have few user-visible effects.  I think I slightly modified the window layout (by a pixel or so) in the popup window case, which I haven't tried to make pixel-perfect yet anyway.  Otherwise it's all reorg.

Clean up logic of nonclient view to be more consistent and coherent.  Most things are now based on a small set of core functions that return various frame/nonclient thicknesses.  This allows a noticeable reduction in the number of hardcoded constants, makes the code make more sense (even though a few places are longer than before), and makes it much easier to do things in the future like resizing various borders or handling system metrics better.

Rename and update comments for all constants to be more descriptive and less redundant.

Rename helper functions and variables for consistency, now that they've changed.

Remove an unused variant of TileImageInt().  Add a new one that takes an offset into the source image.  This is used to rewrite the maximized bottom border tiling call in a way that doesn't rely on someone else clipping out or painting over the overdraw from tiling "too large" a source image.  Probably no visible effect.

Make resize border hittest helper function able to handle borders of varying widths, and try to make parameter names more meaningful.  Technically, we don't need the extra flexibility, since our bottom and side borders are the same thickness, but since there are different functions calculating that thickness on the caller side, it didn't hurt to not rely on that for the future.

BUG=5054
Review URL: http://codereview.chromium.org/18804
------------------------------------------------------------------------
r8655 | pinkerton@google.com | 2009-01-26 21:18:18 +0100 (Mon, 26 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm

Add some more menu items from cole
Review URL: http://codereview.chromium.org/18776
------------------------------------------------------------------------
r8653 | pinkerton@google.com | 2009-01-26 21:03:04 +0100 (Mon, 26 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/TabContents.xib
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   M /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm

fix button cell to use cell's tag for appearance, not the button's cell which is reserved for command dispatch
Review URL: http://codereview.chromium.org/18773
------------------------------------------------------------------------
r8651 | darin@chromium.org | 2009-01-26 20:38:05 +0100 (Mon, 26 Jan 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Close the handle to the child process after terminating it.  This avoids
calling RegisterWaitForSingleObject with a handle to a process that has
already been terminated.  (See the use of ProcessWatcher in the destructor
of BrowserRenderProcessHost.)  I'm not sure that this explains why RWFSO
fails, but it seems like a reasonable change anyways.  The MSDN docs do
not give any reasons for why RWFSO might fail.

R=maruel
BUG=3782

Review URL: http://codereview.chromium.org/18810
------------------------------------------------------------------------
r8640 | sky@google.com | 2009-01-26 19:32:54 +0100 (Mon, 26 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc

Fixes possible crash in restoring a previously closed window. The
crash would occur if we pruned a tab and the index of selected tab was
> tab_count - pruned_count.

BUG=none
TEST=make sure no problems with restoring closed windows.

Review URL: http://codereview.chromium.org/18737
------------------------------------------------------------------------
r8637 | pkasting@chromium.org | 2009-01-26 18:42:58 +0100 (Mon, 26 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/views/custom_frame_window.cc

Two of the three places that set a window mask had it wrong.  Fix it.
Review URL: http://codereview.chromium.org/18580
------------------------------------------------------------------------
r8628 | maruel@chromium.org | 2009-01-26 17:19:44 +0100 (Mon, 26 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   A /trunk/src/chrome/browser/net/dns_slave.cc (from /trunk/src/chrome/browser/net/dns_slave.cc:8624)
   A /trunk/src/chrome/browser/net/dns_slave.h (from /trunk/src/chrome/browser/net/dns_slave.h:8624)
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/scoped_host_mapper.h

Reverting 8627,8625.
Review URL: http://codereview.chromium.org/18598
------------------------------------------------------------------------
r8627 | phajdan.jr@chromium.org | 2009-01-26 16:26:54 +0100 (Mon, 26 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.cc

Fix MSVC warning.

TBR=maruel
Review URL: http://codereview.chromium.org/18594
------------------------------------------------------------------------
r8625 | phajdan.jr@chromium.org | 2009-01-26 16:10:43 +0100 (Mon, 26 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   D /trunk/src/chrome/browser/net/dns_slave.cc
   D /trunk/src/chrome/browser/net/dns_slave.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/scoped_host_mapper.h

Clean up dns prefetch code, and also port it.

BUG=5687, 6683

Review URL: http://codereview.chromium.org/15076
------------------------------------------------------------------------
r8622 | phajdan.jr@chromium.org | 2009-01-26 10:29:08 +0100 (Mon, 26 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/tree_node_model.h

Small porting in chrome/

This is actually http://codereview.chromium.org/18446 without
process_watcher changes.

Review URL: http://codereview.chromium.org/18724
------------------------------------------------------------------------
r8614 | aa@chromium.org | 2009-01-25 06:08:54 +0100 (Sun, 25 Jan 2009) | 12 lines
Changed paths:
   M /trunk/src/base/directory_watcher_unittest.cc
   M /trunk/src/base/directory_watcher_win.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

Add user script support to extensions.

This is implemented mostly by relying on the existing
user script code. But since extension user scripts are
declared, not discovered in a directory, I had to add
support for adding 'lone' user scripts to
UserScriptMaster. This led to a bit of refactoring.

Note that this CL relies on:
http://codereview.chromium.org/18352

Review URL: http://codereview.chromium.org/18198
------------------------------------------------------------------------
r8612 | ben@chromium.org | 2009-01-24 08:07:34 +0100 (Sat, 24 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Make sure the TabStripModelDelegate can never be NULL.

TBR=brettw
Review URL: http://codereview.chromium.org/18578
------------------------------------------------------------------------
r8611 | brettw@chromium.org | 2009-01-24 07:16:13 +0100 (Sat, 24 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h

Random de-Windows-ification-ism-izing in renderer_host.
Review URL: http://codereview.chromium.org/18577
------------------------------------------------------------------------
r8610 | brettw@chromium.org | 2009-01-24 06:28:50 +0100 (Sat, 24 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h

Do some cleanup in the resource message filter. Hopefully it will compile on
Linux and Mac now.
Review URL: http://codereview.chromium.org/18740
------------------------------------------------------------------------
r8608 | brettw@chromium.org | 2009-01-24 05:25:00 +0100 (Sat, 24 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_view_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h

Do some header file cleanup of RenderWidgetHost. I moved everything to be
private except the few functions that actually are overridden by
RenderViewHost.
Review URL: http://codereview.chromium.org/18739
------------------------------------------------------------------------
r8606 | ben@chromium.org | 2009-01-24 03:47:58 +0100 (Sat, 24 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/sessions/session_types.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/test_browser_window.h

Two things:

- remove views dependencies from browser by moving profile related dialog actions into BrowserWindow.
- simplify the include dependencies in TabStripModel (making it easier to bring up on mac) by implementing more of its high level functionality in the delegate.

Review URL: http://codereview.chromium.org/18736
------------------------------------------------------------------------
r8605 | rvargas@google.com | 2009-01-24 03:39:54 +0100 (Sat, 24 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/completion_callback.h
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   D /trunk/src/net/base/io_buffer.h
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_simple_job.cc
   M /trunk/src/net/url_request/url_request_simple_job.h
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_test_job.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

revert r8603

Review URL: http://codereview.chromium.org/18576
------------------------------------------------------------------------
r8604 | brettw@chromium.org | 2009-01-24 03:26:00 +0100 (Sat, 24 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   D /trunk/src/chrome/browser/tab_contents/network_status_view.cc
   D /trunk/src/chrome/browser/tab_contents/network_status_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   A /trunk/src/chrome/browser/views/about_network_dialog.cc
   A /trunk/src/chrome/browser/views/about_network_dialog.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/text_field.h

Create a dialog box for the about:network view and kill the tab type.
This adds an AppendText method to the text field view.

The job tracker stuff is just copied from the old network status file.
Review URL: http://codereview.chromium.org/18728
------------------------------------------------------------------------
r8603 | rvargas@google.com | 2009-01-24 02:54:05 +0100 (Sat, 24 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/net/url_fetcher.cc
   M /trunk/src/chrome/browser/net/url_fetcher.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/completion_callback.h
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   A /trunk/src/net/base/io_buffer.h
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/proxy/proxy_script_fetcher.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_simple_job.cc
   M /trunk/src/net/url_request/url_request_simple_job.h
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_test_job.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

Change URLRequest to use a ref-counted buffer for actual IO.The ref-counting will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325
Review URL: http://codereview.chromium.org/18390
------------------------------------------------------------------------
r8599 | sky@google.com | 2009-01-24 00:51:22 +0100 (Sat, 24 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h

Fixes leak of CertStore on shutdown.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/18568
------------------------------------------------------------------------
r8598 | brg@chromium.com | 2009-01-24 00:43:55 +0100 (Sat, 24 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   D /trunk/src/chrome/browser/importer/toolbar_importer.cc
   D /trunk/src/chrome/browser/importer/toolbar_importer.h
   D /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Pull toolbar importer from trunk.
This change was requested by personalization.
Review URL: http://codereview.chromium.org/18550
------------------------------------------------------------------------
r8595 | brettw@chromium.org | 2009-01-24 00:29:31 +0100 (Sat, 24 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h

Add missing file from last checkin.
------------------------------------------------------------------------
r8594 | brettw@chromium.org | 2009-01-24 00:14:11 +0100 (Sat, 24 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/renderer_host/backing_store.cc
   A /trunk/src/chrome/browser/renderer_host/backing_store.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h

Separate out the backing store from the RenderWidgetHost into its own file to
make porting easier.

I also did some cleanup in the scrolling and painting areas, collapsing the
confusing ScrollRect call inside OnMsgScrollRect to just be inside the function
and call a new function on the backing store to scroll it. Same for painting.

This also moves plugin window moving to the view.
Review URL: http://codereview.chromium.org/18702
------------------------------------------------------------------------
r8593 | xji@chromium.org | 2009-01-24 00:13:05 +0100 (Sat, 24 Jan 2009) | 60 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/common/l10n_util.h
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_control.h
   M /trunk/src/chrome/views/table_view.cc

===================================================
This change list fixes the following 2 chrome bugs:

2821 RTL: Ellipsis appeared at right for RTL locales on "Task Manager - Google Chrome" dialog
(http://crbug.com/2821)

6132: Strings in tables are displayed LTR when they should be RTL
(http://crbug.com/6132)

===================================================
Background:

The above 2 bugs are related to Chrome task manager.
Task manager is a TableView, which is a subclass of NativeControl.

Currently, TableView window is created by using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, which is wrong.

WS_EX_LAYOUTRTL | WS_EX_RTLREADING renders a RTL alignment but LTR reading order.
Please see the following blog for detail:
http://blogs.msdn.com/michkap/archive/2007/03/11/1857043.aspx

We need to replace the above flag with WS_EX_LAYOUTRTL only.

Consequently, we need to make sure that the various implementations of TableModel::GetText adjust the 
returned text appropriately if need be. For example, if the text in an URL, then the returned text should be explicitly marked as LTR text.

Please note: there are several other places where we create RTL window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, such as AutoCompleteEditView (omnibox), MenuHostWindow,
TextField (for example, text in bookmark dialog), and other NativeControl (including checkbox, combobox, native_button, radio_button, separator, tabbed_pane, and tree view).

They all need to be fixed. And the following bug is filed for tracking.
http://crbug.com/6573
 
===================================================

The fix is based on Idan's comments on bug 6132

1.create the table view with WS_EX_LAYOUTRTL (rather than WS_EX_LAYOUTRTL | WS_EX_RTLREADING) 

2 Make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. 
If the text in an URL, then the returned text is explicitly marked as LTR text. 
Otherwise, the returned text is marked with LTR if it is RTL environment and there is no strong RTL character in the text. This is to avoid the wrong placement of (or wrong mirrored) ending-punctuation.

===================================================
Since we have quite a few places creating window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING style. We decided to migrate to the right style step to step.

This is the first step, and there is unnecessary function introduced by this change list.

1.
I am using l10n_util::GetExtendedTooltipStyles() for the right style for now. And I marked a TODO there to obsolete this function name, replace with GetExtendedStyles eventually. (the l10n_util.h is no longer in the change list since I've checked it in with another CL).

2. 
I introduced native_control::GetAdditionalRTLStyle() which should replace GetAdditionalExStyle() eventually.


===================================================
When wrapping text with LTR format in GetText(),
ideally, we should parse the text to check whether this is a n URL or not (for example, a webpage title could be an URL, or user could add URL as search engine's name or keyword).
I did not do that and only added a TODO there because I think that might be rare case and parsing the text might cause performance degradation.

Review URL: http://codereview.chromium.org/18076
------------------------------------------------------------------------
r8587 | sky@google.com | 2009-01-23 23:19:32 +0100 (Fri, 23 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

I'm relanding the UserDataManager leak fix. I didn't realize we had
stubs for mac which needed to be updated too. This time I'll wait for
the bots to finish compiling before committing.

BUG=none
TEST=none
TBR=munjal

Review URL: http://codereview.chromium.org/18566
------------------------------------------------------------------------
r8584 | sky@google.com | 2009-01-23 23:02:50 +0100 (Fri, 23 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.h

Reverts my user data manager change as it breaks the mac buildbot.

BUG=none
TEST=none
TBR=munjal

Review URL: http://codereview.chromium.org/18564
------------------------------------------------------------------------
r8581 | sky@google.com | 2009-01-23 22:52:01 +0100 (Fri, 23 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/user_data_manager.h

Fixes leak of UserDataManager on shutdown.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/18714
------------------------------------------------------------------------
r8578 | jcampan@chromium.org | 2009-01-23 22:05:34 +0100 (Fri, 23 Jan 2009) | 17 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_resources.h
   M /trunk/src/chrome/browser/browser_resources.rc
   M /trunk/src/chrome/browser/resources/browser_resources.vcproj
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   A /trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h

This CL makes the safe browsing interstitial page support multiple unsafe resources in one page.
We had a bug when an interstitial was showing and another unsafe resource was detected. We would show another interstitial on top of the original one, causing the DontProceed method to be invoked several times. That would cause us to remove more than once an entry from the navigation controller and cause crashers.

With this new CL, if an interstitial shows and a new resource is flagged as bad, the SafeBrowsingBlockingPage will queue that notification. If the user decides to proceed through the interstitial, we'll create another interstitial warning about all the unsafe resources we have received so far.

This CL also contains a fix for a crasher that would happen when closing a tab with a safe browsing interstitial.

BUG=5916,6207,6306
TEST=Test all actions in the interstitial you get when opening pages with the followin scenarios:
- Main page is malware
- Main page is fishing
- Main page is OK contains resources (images,iframes...) which are malware
- Main page is OK contains resources (images,iframes...) which are phishing
- Main page is OK contains resources (images,iframes...) some of them phishing, some of then malware.
Note that when there are more than one bad resource, it is normal to see a 1st interstitial, then another one listing all the other bad resources.
(ex of malware site http://ianfette.org, phishing site http://cvisit.tripod.com)
Review URL: http://codereview.chromium.org/18346
------------------------------------------------------------------------
r8577 | sgk@google.com | 2009-01-23 22:02:30 +0100 (Fri, 23 Jan 2009) | 25 lines
Changed paths:
   M /trunk/src/chrome/app/locales/da.vcproj
   M /trunk/src/chrome/app/locales/en-US.vcproj
   M /trunk/src/chrome/app/locales/he.vcproj
   M /trunk/src/chrome/app/locales/zh-TW.vcproj
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/installer/util/util.vcproj
   M /trunk/src/chrome/test/automation/automation.vcproj
   M /trunk/src/chrome/tools/test/image_diff/image_diff.vcproj
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_resources.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/testing/gtest.vcproj
   M /trunk/src/third_party/libpng/libpng.vcproj
   M /trunk/src/third_party/zlib/zlib.vcproj

Prep for generated .vcproj files:
Fix minor stylistic inconsistencies in some .vcproj files:
* /> tag termination:
    net\net_resources.vcproj
* Add empty <ToolFiles>, <References> and <Globals> sections:
    net\net_resources.vcproj
    third_party\zlib\zlib.vcproj
    third_party\libpng\libpng.vcproj
    chrome\tools\test\image_diff\image_diff.vcproj
* Remove .\ on file names where its use is inconsistent with the rest
  of the file names in the .vcproj:
    net\build\net.vcproj
    net\build\net_unittests.vcproj
    chrome\installer\util\util.vcproj
* Add explicit RootNamespace attribute:
    chrome\test\automation\automation.vcproj
    testing\gtest.vcproj
* Fix file order in four locales that don't match other locale .vcproj files:
    chrome\app\locales\da.vcproj
    chrome\app\locales\he.vcproj
    chrome\app\locales\zh-TW.vcproj
    chrome\app\locales\en-US.vcproj
* Remove duplicate files from the list:
    chrome\browser\views\browser_views.vcproj (event_utils.[ch])
Review URL: http://codereview.chromium.org/18555
------------------------------------------------------------------------
r8576 | aa@chromium.org | 2009-01-23 21:48:59 +0100 (Fri, 23 Jan 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.h
   D /trunk/src/chrome/browser/extensions/extension_protocols_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/test/data/extensions/extension1/manifest
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Try again to commit r8486, which updates the manifest
parsing in the Extension class to also parse out user
script details.

The problem was that extension_protocols.cc appears to
link OK if you don't refer to anything in it, but as
soon as you try to use something defined in it, a bunch
of other symbols it refers to turn up undefined.

To avoid this problem in the future, I stopped compiling
extensions_protocol.cc so that we would realize if we
tried to use it.

Also in this change, I absolutified paths in
ExtensionsService before creating Extension instances.
On Linux, the path that PathService was giving us was
not absolute.

Review URL: http://codereview.chromium.org/18704
------------------------------------------------------------------------
r8572 | ben@chromium.org | 2009-01-23 21:37:29 +0100 (Fri, 23 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/test/test_browser_window.h

Don't expose the go and star button views directly through the BrowserWindow interface (for porting).
Review URL: http://codereview.chromium.org/18540
------------------------------------------------------------------------
r8571 | pinkerton@google.com | 2009-01-23 21:37:09 +0100 (Fri, 23 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/BrowserWindow.xib
   A /trunk/src/chrome/app/nibs/English.lproj/TabContents.xib
   A /trunk/src/chrome/app/theme/back.pdf
   A /trunk/src/chrome/app/theme/forward.pdf
   A /trunk/src/chrome/app/theme/go.pdf
   A /trunk/src/chrome/app/theme/newtab.pdf
   A /trunk/src/chrome/app/theme/reload.pdf
   A /trunk/src/chrome/app/theme/star.pdf
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   A /trunk/src/chrome/browser/cocoa
   A /trunk/src/chrome/browser/cocoa/tab_bar_view.h
   A /trunk/src/chrome/browser/cocoa/tab_bar_view.mm
   A /trunk/src/chrome/browser/cocoa/tab_cell.h
   A /trunk/src/chrome/browser/cocoa/tab_cell.mm
   A /trunk/src/chrome/browser/cocoa/tab_contents_controller.h
   A /trunk/src/chrome/browser/cocoa/tab_contents_controller.mm
   A /trunk/src/chrome/browser/cocoa/toolbar_button_cell.h
   A /trunk/src/chrome/browser/cocoa/toolbar_button_cell.mm
   A /trunk/src/chrome/browser/cocoa/toolbar_view.h
   A /trunk/src/chrome/browser/cocoa/toolbar_view.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

ui refresh from cole. make it look chromey and get the basic framework for the views we'll need.
Review URL: http://codereview.chromium.org/18720
------------------------------------------------------------------------
r8570 | mark@chromium.org | 2009-01-23 21:01:19 +0100 (Fri, 23 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/process_watcher.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/tree_node_model.h

Revert r8560 due to broken interactive_ui_tests
Review URL: http://codereview.chromium.org/18722
------------------------------------------------------------------------
r8569 | paulg@google.com | 2009-01-23 20:42:33 +0100 (Fri, 23 Jan 2009) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Fix a bug when saving web pages that have a period in their title.

The save dialog code attempts to generate a file extension based on
the suggested name provided to it, which in the case of saving a web
page is the title. If that title contains a '.' character, it treats
anything that follows as the file extension and appends it to the name
the user selects.

For example, saving a page with the title "Google Inc. - A search engine"
and the user choosing the save name as "Google" will result in the saved
file being named "Google. - A search engine.htm" when it should be
"Google.htm".

In the case of saving a web page, we can ignore trying to figure out
the file extension since we already know it will be ".htm".

BUG=6105 (http://crbug.com/6105)

Review URL: http://codereview.chromium.org/18699
------------------------------------------------------------------------
r8566 | brettw@chromium.org | 2009-01-23 20:12:09 +0100 (Fri, 23 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Reverting 8565.
Review URL: http://codereview.chromium.org/18718
------------------------------------------------------------------------
r8565 | sidchat@google.com | 2009-01-23 19:49:18 +0100 (Fri, 23 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Get rid of unnecessary region code from spellcheck language/locale codes

Issue=6329
Review URL: http://codereview.chromium.org/18694
------------------------------------------------------------------------
r8564 | brettw@chromium.org | 2009-01-23 19:38:13 +0100 (Fri, 23 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/security_style.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   A /trunk/src/chrome/browser/tab_contents/security_style.h (from /trunk/src/chrome/browser/security_style.h:8476)
   M /trunk/src/chrome/test/automation/tab_proxy.h

Move security style into the tab_contents directory. This is the last part of
the "Tab Contents (old)" group!
Review URL: http://codereview.chromium.org/18686
------------------------------------------------------------------------
r8562 | sky@google.com | 2009-01-23 19:28:38 +0100 (Fri, 23 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_shutdown.cc

Adds call to unload plugins on shutdown.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/18715
------------------------------------------------------------------------
r8561 | nick@chromium.org | 2009-01-23 19:28:24 +0100 (Fri, 23 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/base/gfx/png_encoder.cc
   M /trunk/src/base/gfx/png_encoder.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/security_filter_peer.cc

Add a PNGEncoder helper function that takes an SkBitmap,
which is how PNGEncode is used almost everywhere.

This should be strictly no functional change, except for the
ImageFilterPeer::DataReady case, where we now take an
SkAutoLockPixels where previously we did not.

Review URL: http://codereview.chromium.org/18347
------------------------------------------------------------------------
r8560 | phajdan.jr@chromium.org | 2009-01-23 19:03:29 +0100 (Fri, 23 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/process_watcher.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/tree_node_model.h

Porting in chrome/

Review URL: http://codereview.chromium.org/18446
------------------------------------------------------------------------
r8559 | abarth@chromium.org | 2009-01-23 18:30:50 +0100 (Fri, 23 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

When the server says "nosniff" but then doesn't give us a Content-Type we now treat the response as "text/plain".  Before, we treated the response as a download.  This behavior is (a) safer and (b) matches what we expect in IE8.

R=darin

Review URL: http://codereview.chromium.org/18549
------------------------------------------------------------------------
r8555 | sky@google.com | 2009-01-23 17:06:14 +0100 (Fri, 23 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h

Fixes leak of shutdown event in BrowserProcess.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/18534
------------------------------------------------------------------------
r8548 | sky@google.com | 2009-01-23 06:25:28 +0100 (Fri, 23 Jan 2009) | 7 lines
Changed paths:
   D /trunk/src/chrome/browser/app_mode_navigation_uitest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   D /trunk/src/chrome/test/data/appmodenavigation_test.html
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Backs out 8523 in hopes of a greener tree.

BUG=none
TEST=none
TBR=brg

Review URL: http://codereview.chromium.org/18548
------------------------------------------------------------------------
r8547 | sky@google.com | 2009-01-23 06:24:57 +0100 (Fri, 23 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

Relands 8521, it isn't the culprit. Sorry John.

BUG=none
TEST=none
TBR=jam
Review URL: http://codereview.chromium.org/18706
------------------------------------------------------------------------
r8546 | sky@google.com | 2009-01-23 05:19:47 +0100 (Fri, 23 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

Backs out r8521 in hopes of greener trees.

BUG=none
TEST=none
TBR=jam
Review URL: http://codereview.chromium.org/18545
------------------------------------------------------------------------
r8544 | hclam@chromium.org | 2009-01-23 04:32:44 +0100 (Fri, 23 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   A /trunk/src/chrome/browser/views/password_manager_exceptions_view.cc
   A /trunk/src/chrome/browser/views/password_manager_exceptions_view.h
   M /trunk/src/chrome/browser/views/password_manager_view.h

BUG=1007

Added a dialog for removing exceptions of password manager
Added the PasswordManagerExceptionsView class for removing exception of password manager added by "Never for this site" button. Also added a button in "Minor Tweaks" tab for openning the dialog.

Review URL: http://codereview.chromium.org/18494
------------------------------------------------------------------------
r8543 | jar@google.com | 2009-01-23 04:12:04 +0100 (Fri, 23 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc

Change histogram for eviction to get details of long tail


r=petersont
Review URL: http://codereview.chromium.org/18705
------------------------------------------------------------------------
r8536 | estade@chromium.org | 2009-01-23 02:51:23 +0100 (Fri, 23 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/net/url_fixer_upper.cc
   M /trunk/src/chrome/browser/net/url_fixer_upper.h
   M /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/gfx/text_elider.cc
   M /trunk/src/chrome/common/gfx/text_elider.h
   M /trunk/src/chrome/test/unit/unit_tests.scons

Fix strings in url_fixer_upper.

* change URLs from wstring to string
* change filenames from wstring to FilePath
* url_fixer_upper{_unittest}.cc building on posix

Review URL: http://codereview.chromium.org/18525
------------------------------------------------------------------------
r8531 | jar@chromium.org | 2009-01-23 02:00:16 +0100 (Fri, 23 Jan 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h

Handle race between deleting a low use referrer acruing value

Prevent a DCHECK from firing.

As we adaptively learn about referrers to enhance DNS
pre-resolution, we are forced to evict some entries
to prevent accidentally getting really large lists
(when we make mistakes).  Sometimes we evict a 
referred item from a list *while* that item is being
resolved (because it was in teh list).  In that case,
we have to be careful when we try to acrue credit 
(latency savings).

r=paulg
Review URL: http://codereview.chromium.org/18527
------------------------------------------------------------------------
r8527 | jungshik@google.com | 2009-01-23 01:39:47 +0100 (Fri, 23 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/net/http/http_util.cc
   M /trunk/src/net/http/http_util.h
   M /trunk/src/net/http/http_util_unittest.cc

Add q-values to languages in Accept-Language HTTP header to be compatible with Apache.
Add q-values to charsets in Accept-Charset header in the same way as Firefox does. 

BUG=5899
TEST=HttpUtilTest.Accept*  (net_unittest)


Review URL: http://codereview.chromium.org/17340
------------------------------------------------------------------------
r8523 | brg@chromium.com | 2009-01-23 01:02:44 +0100 (Fri, 23 Jan 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/app_mode_navigation_uitest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   A /trunk/src/chrome/test/data/appmodenavigation_test.html
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Changes to insure that when in app-mode, links open in the default browser.  This change should have no affect on Chrome when not in app-mode.Tested against Gmail.  UITests added as app_mode_navigation_uitest.
Review URL: http://codereview.chromium.org/18093
------------------------------------------------------------------------
r8521 | jam@chromium.org | 2009-01-23 00:44:30 +0100 (Fri, 23 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/render_widget_host.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h

Fix reloading a page with a pdf not working.  The problem was that we were sending an invalid window to DeferWindowPos (the previous window as it's going away).  But we didn't really need to override setParentVisible since overriding setParent is enough.
Review URL: http://codereview.chromium.org/18519
------------------------------------------------------------------------
r8517 | ben@chromium.org | 2009-01-23 00:09:44 +0100 (Fri, 23 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/status_bubble.h

fix bustage
------------------------------------------------------------------------
r8515 | ben@chromium.org | 2009-01-22 23:57:19 +0100 (Thu, 22 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/status_bubble.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   D /trunk/src/chrome/browser/views/status_bubble.cc
   D /trunk/src/chrome/browser/views/status_bubble.h
   A /trunk/src/chrome/browser/views/status_bubble_views.cc (from /trunk/src/chrome/browser/views/status_bubble.cc:8386)
   A /trunk/src/chrome/browser/views/status_bubble_views.h (from /trunk/src/chrome/browser/views/status_bubble.h:8386)

Make the browser talk to the status bubble through an abstract interface to remove the views dependency.

Review URL: http://codereview.chromium.org/18487
------------------------------------------------------------------------
r8514 | ben@chromium.org | 2009-01-22 23:55:07 +0100 (Thu, 22 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/command_updater_unittest.cc

Re-enable this test now that I've properly initialized the result member variable.

TBR=tc
Review URL: http://codereview.chromium.org/18602
------------------------------------------------------------------------
r8496 | maruel@chromium.org | 2009-01-22 21:09:11 +0100 (Thu, 22 Jan 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

(1) If you create tabs and manage to resize the window before the
pending layout occurs, you get truncated tabs (As described in
issue 6505). Upon resize therefore we reset the reserved width for 
tabs.

(2) When inserting a tab as the second-to-last tab, the size
of tabs was incorrect. This lead to shriking tabs in multiple
cases (as described in issue 3258).
BUG=6505
BUG=3258

Patch contributed by Itai Danan <idanana@google.com>

------------------------------------------------------------------------
r8494 | aa@chromium.org | 2009-01-22 21:03:30 +0100 (Thu, 22 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.h
   A /trunk/src/chrome/browser/extensions/extension_protocols_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/test/data/extensions/extension1/manifest
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Revert "Parse more user script info out of the manifest and expose"
This reverts commit fc3fd1062c06f803775c16d11f742d85d540e415.

Review URL: http://codereview.chromium.org/18681
------------------------------------------------------------------------
r8493 | pinkerton@google.com | 2009-01-22 20:49:33 +0100 (Thu, 22 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

More scaffolding for back/forward/reload/home, start of WebContents
Review URL: http://codereview.chromium.org/18507
------------------------------------------------------------------------
r8492 | pinkerton@google.com | 2009-01-22 20:48:52 +0100 (Thu, 22 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/BrowserWindow.xib
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm

remove the NSToolbar, improve the appearance a little bit. ObjC style member names.
Review URL: http://codereview.chromium.org/18501
------------------------------------------------------------------------
r8487 | sidchat@google.com | 2009-01-22 20:27:59 +0100 (Thu, 22 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Change spell check dictionary download URL to now include edgedl

BUG=1592281
Review URL: http://codereview.chromium.org/18631
------------------------------------------------------------------------
r8486 | aa@chromium.org | 2009-01-22 20:27:56 +0100 (Thu, 22 Jan 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.h
   D /trunk/src/chrome/browser/extensions/extension_protocols_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/test/data/extensions/extension1/manifest
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Parse more user script info out of the manifest and expose
it on the Extension class.

Removed Extension::CopyToValue() because it was only being
used in unit tests.

Centralize functions for creation of absolute URLs and
paths to extension resources in Extension class and move
corresponding unit tests.

Various other minor nitpickery.

Review URL: http://codereview.chromium.org/18352
------------------------------------------------------------------------
r8481 | brettw@chromium.org | 2009-01-22 19:58:51 +0100 (Thu, 22 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Fix unit tests build
------------------------------------------------------------------------
r8479 | brettw@chromium.org | 2009-01-22 19:33:54 +0100 (Thu, 22 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc

Fix messed up include path.
Review URL: http://codereview.chromium.org/18512
------------------------------------------------------------------------
r8475 | brettw@chromium.org | 2009-01-22 19:10:56 +0100 (Thu, 22 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

More Linux fixing.
------------------------------------------------------------------------
r8472 | brettw@chromium.org | 2009-01-22 19:01:08 +0100 (Thu, 22 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

More liunx bustage.
------------------------------------------------------------------------
r8471 | brettw@chromium.org | 2009-01-22 18:55:56 +0100 (Thu, 22 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Hopefully fix Mac & Linux build.
Review URL: http://codereview.chromium.org/18673
------------------------------------------------------------------------
r8470 | brettw@chromium.org | 2009-01-22 18:48:25 +0100 (Thu, 22 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   D /trunk/src/chrome/browser/render_view_context_menu.cc
   D /trunk/src/chrome/browser/render_view_context_menu.h
   D /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   D /trunk/src/chrome/browser/render_view_context_menu_controller.h
   D /trunk/src/chrome/browser/render_view_host.cc
   D /trunk/src/chrome/browser/render_view_host.h
   D /trunk/src/chrome/browser/render_view_host_delegate.h
   D /trunk/src/chrome/browser/render_view_host_manager.cc
   D /trunk/src/chrome/browser/render_view_host_manager.h
   D /trunk/src/chrome/browser/render_widget_helper.cc
   D /trunk/src/chrome/browser/render_widget_helper.h
   D /trunk/src/chrome/browser/render_widget_host.cc
   D /trunk/src/chrome/browser/render_widget_host.h
   D /trunk/src/chrome/browser/render_widget_host_view.h
   D /trunk/src/chrome/browser/render_widget_host_view_win.cc
   D /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/render_view_host.cc (from /trunk/src/chrome/browser/render_view_host.cc:8443)
   A /trunk/src/chrome/browser/renderer_host/render_view_host.h (from /trunk/src/chrome/browser/render_view_host.h:8443)
   A /trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h (from /trunk/src/chrome/browser/render_view_host_delegate.h:8443)
   A /trunk/src/chrome/browser/renderer_host/render_widget_helper.cc (from /trunk/src/chrome/browser/render_widget_helper.cc:8443)
   A /trunk/src/chrome/browser/renderer_host/render_widget_helper.h (from /trunk/src/chrome/browser/render_widget_helper.h:8443)
   A /trunk/src/chrome/browser/renderer_host/render_widget_host.cc (from /trunk/src/chrome/browser/render_widget_host.cc:8443)
   A /trunk/src/chrome/browser/renderer_host/render_widget_host.h (from /trunk/src/chrome/browser/render_widget_host.h:8443)
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_view.h (from /trunk/src/chrome/browser/render_widget_host_view.h:8443)
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc (from /trunk/src/chrome/browser/render_widget_host_view_win.cc:8443)
   A /trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h (from /trunk/src/chrome/browser/render_widget_host_view_win.h:8443)
   A /trunk/src/chrome/browser/renderer_host/renderer_security_policy.cc (from /trunk/src/chrome/browser/renderer_security_policy.cc:8443)
   A /trunk/src/chrome/browser/renderer_host/renderer_security_policy.h (from /trunk/src/chrome/browser/renderer_security_policy.h:8443)
   A /trunk/src/chrome/browser/renderer_host/renderer_security_policy_unittest.cc (from /trunk/src/chrome/browser/renderer_security_policy_unittest.cc:8443)
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   D /trunk/src/chrome/browser/renderer_security_policy.cc
   D /trunk/src/chrome/browser/renderer_security_policy.h
   D /trunk/src/chrome/browser/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc (from /trunk/src/chrome/browser/render_view_context_menu.cc:8443)
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu.h (from /trunk/src/chrome/browser/render_view_context_menu.h:8443)
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.cc (from /trunk/src/chrome/browser/render_view_context_menu_controller.cc:8443)
   A /trunk/src/chrome/browser/tab_contents/render_view_context_menu_controller.h (from /trunk/src/chrome/browser/render_view_context_menu_controller.h:8443)
   A /trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc (from /trunk/src/chrome/browser/render_view_host_manager.cc:8443)
   A /trunk/src/chrome/browser/tab_contents/render_view_host_manager.h (from /trunk/src/chrome/browser/render_view_host_manager.h:8443)
   M /trunk/src/chrome/browser/tab_contents/tab_util.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.cc
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/web_app.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move files out of browser and into either renderer_host or tab_contents.

This also fixes a crash in the web contents unit test in a commented-out test and re-enable it.
Review URL: http://codereview.chromium.org/18504
------------------------------------------------------------------------
r8461 | sky@google.com | 2009-01-22 17:54:54 +0100 (Thu, 22 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc

Disables another SSL test as it is causing hangs.

BUG=none
TEST=none
TBR=jcampan

Review URL: http://codereview.chromium.org/18665
------------------------------------------------------------------------
r8454 | deanm@chromium.org | 2009-01-22 16:23:34 +0100 (Thu, 22 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/directory_watcher_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/net/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/unzip_unittest.cc
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc

Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII("").

Review URL: http://codereview.chromium.org/18499
------------------------------------------------------------------------
r8441 | cpu@google.com | 2009-01-22 03:31:17 +0100 (Thu, 22 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc

The WebContents CL broke unit tests
 http://src.chromium.org/viewvc/chrome?view=rev&revision=8416

Blind attempt to fix it.

TBR=brettw


Review URL: http://codereview.chromium.org/18648
------------------------------------------------------------------------
r8435 | ben@chromium.org | 2009-01-22 02:34:52 +0100 (Thu, 22 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browser_window_cocoa.h
   M /trunk/src/chrome/browser/browser_window_cocoa.mm
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/test/test_browser_window.h

Move automation specific accessors to their own interface to make their purpose clear, and make porting easier.

Review URL: http://codereview.chromium.org/18481
------------------------------------------------------------------------
r8434 | agl@chromium.org | 2009-01-22 02:33:15 +0100 (Thu, 22 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc

Linux: move win_util.h to Windows specific block

Review URL: http://codereview.chromium.org/18483

------------------------------------------------------------------------
r8432 | jam@chromium.org | 2009-01-22 02:27:38 +0100 (Thu, 22 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/webkit/glue/plugins/plugin_constants_win.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc

More speedup of scrolling when many windowed plugins in a page.  Scrolling is now at parity with single process browsers in my testing.

This works by making painting of child windows asynchronous.  The key is to send, not post, the custom message.  This allows the redraw message to jump the queue and get dispatched before other queued [Windows, IPC] messages, which eliminates painting artifacts.

Now that painting is asynchronous, I had to take out the SWP_NOREDRAW flag to DeferWindowPos.  While it's slightly faster without it, the visual aritfacts are noticable.

Review URL: http://codereview.chromium.org/18637
------------------------------------------------------------------------
r8430 | agl@chromium.org | 2009-01-22 02:23:11 +0100 (Thu, 22 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/renderer_main.cc

POSIX: Get render_process_host to build.

This is an adopted CL from Evan. Original:
  http://codereview.chromium.org/14504

(see original for review comments etc)

Review URL: http://codereview.chromium.org/16814

------------------------------------------------------------------------
r8417 | mpcomplete@google.com | 2009-01-22 00:52:48 +0100 (Thu, 22 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc

Fix a timing issue that caused gears to fail to load sometimes.

BUG=http://b/issue?id=1559007
BUG=http://code.google.com/p/chromium/issues/detail?id=4219
Review URL: http://codereview.chromium.org/18604
------------------------------------------------------------------------
r8416 | brettw@chromium.org | 2009-01-22 00:50:15 +0100 (Thu, 22 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   A /trunk/src/chrome/browser/tab_contents/test_web_contents.cc
   A /trunk/src/chrome/browser/tab_contents/test_web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Factor out the test web contents from the WebContents unit test so that it can
be used by other tests. Properly hook up the MockRenderProcessHost so it gets
created when initialized by SiteInstances through a factory object. Fix other
bugs with the test harness I found when I switched all the WebContents test
over to using it.
Review URL: http://codereview.chromium.org/18432
------------------------------------------------------------------------
r8410 | evan@chromium.org | 2009-01-22 00:42:25 +0100 (Thu, 22 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc

Fix SecondLaunch unit test.

BUG=6722

Review URL: http://codereview.chromium.org/18472

------------------------------------------------------------------------
r8406 | tim@chromium.org | 2009-01-22 00:20:48 +0100 (Thu, 22 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.cc

Fix issue 6520 by ensuring that InfoBarClosed is called whenever a tab is closed or a navigation to a URL that is not supported by the current TabContentsType takes place by invoking it on all InfoBarDelegates from TabContents::Destroy(), which is the best least-common-denominator I've found for doing this work. Alternatively I could have made InfoBarDelegate listen for TAB_CONTENTS_DESTROYED and self-invoke InfoBarClosed but that seemed unorthodox (relatively speaking).

This prevents InfoBarDelegates from leaking in these cases.

BUG=6520
Review URL: http://codereview.chromium.org/18381
------------------------------------------------------------------------
r8392 | sky@google.com | 2009-01-21 23:12:32 +0100 (Wed, 21 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc

Disables another flakey interstitial uit test:(

BUG=none
TEST=none
TBR=jcampan

Review URL: http://codereview.chromium.org/18634
------------------------------------------------------------------------
r8391 | munjal@chromium.org | 2009-01-21 23:11:37 +0100 (Wed, 21 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix p13n build break due to a change in CommandLine class.
This was not noticed since this code only builds if
CHROME_PERSONALIZATION is defined.

Review URL: http://codereview.chromium.org/18618
------------------------------------------------------------------------
r8387 | pinkerton@google.com | 2009-01-21 23:04:44 +0100 (Wed, 21 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/nibs/English.lproj/MainMenu.xib
   M /trunk/src/chrome/browser/app_controller_mac.h
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window_controller.h
   M /trunk/src/chrome/browser/browser_window_controller.mm
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

add basic command handling for browser window and for where there are no windows open. Can now create new browser windows.
Review URL: http://codereview.chromium.org/18458
------------------------------------------------------------------------
r8386 | agl@chromium.org | 2009-01-21 21:28:21 +0100 (Wed, 21 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/renderer_main.cc

* Revert "POSIX: Get render_process_host to build."
* Revert "Build fix: release builds seemed to break"

Review URL: http://codereview.chromium.org/18460

------------------------------------------------------------------------
r8385 | agl@chromium.org | 2009-01-21 21:23:46 +0100 (Wed, 21 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Build fix: release builds seemed to break

Review URL: http://codereview.chromium.org/18459

------------------------------------------------------------------------
r8384 | agl@chromium.org | 2009-01-21 21:01:31 +0100 (Wed, 21 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h
   M /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/renderer/render_process.h

POSIX: Get render_process_host to build.

This is an adopted CL from Evan. Original:
  http://codereview.chromium.org/14504

(see original for review comments etc)

Review URL: http://codereview.chromium.org/16814

------------------------------------------------------------------------
r8381 | sky@google.com | 2009-01-21 20:33:54 +0100 (Wed, 21 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc

Disables an interstitial test that occassionally fails.

BUG=none
TEST=none
TBR=jcampan
Review URL: http://codereview.chromium.org/18621
------------------------------------------------------------------------
r8364 | pinkerton@google.com | 2009-01-21 17:41:33 +0100 (Wed, 21 Jan 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/app/nibs/English.lproj/BrowserWindow.xib
   M /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   A /trunk/src/chrome/browser/browser_window_cocoa.h
   A /trunk/src/chrome/browser/browser_window_cocoa.mm
   A /trunk/src/chrome/browser/browser_window_controller.h
   A /trunk/src/chrome/browser/browser_window_controller.mm
   A /trunk/src/chrome/browser/browser_window_factory.mm
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h

Get browser window showing using a Browser object and accompanying scaffolding. Adds browser window controller and shim from NSWindow to BrowserWindow.
Review URL: http://codereview.chromium.org/18368
------------------------------------------------------------------------
r8361 | jar@chromium.org | 2009-01-21 09:04:38 +0100 (Wed, 21 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Discard corrupt old logs in UMA upload

Detect logs that are unacceptable to the server, and don't
retransmit them (it won't help to send them again).

bug= 1505736

r=huanr,evanm
Review URL: http://codereview.chromium.org/18444
------------------------------------------------------------------------
r8357 | ben@chromium.org | 2009-01-21 03:08:54 +0100 (Wed, 21 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/test/unit/unit_tests.scons

Fix the scons build
------------------------------------------------------------------------
r8355 | tc@google.com | 2009-01-21 03:01:21 +0100 (Wed, 21 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

actually re-enable the test
TBR=ben

Review URL: http://codereview.chromium.org/18441
------------------------------------------------------------------------
r8351 | stoyan@chromium.org | 2009-01-21 02:21:48 +0100 (Wed, 21 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc

Refactor automation wrappers. Move the methods from AutomationProxy to the appropriate classes.
Review URL: http://codereview.chromium.org/18335
------------------------------------------------------------------------
r8350 | jcampan@chromium.org | 2009-01-21 02:08:44 +0100 (Wed, 21 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc

A crasher would happen if you navigate to a page triggering an interstitial from the new tab page, then press back in the interstitial.
The crasher would happen because the navigation controller collects (destroys) the previous tab contents when a navigation is initiated. In this case, when navigating back (by just discarding the non committed entries), it would not be expect that the tab contents would be NULL.

It seems we do not need to collect the unused tab contents on NavigateToPendingEntry() since we are collecting any unused TabContents in NavigationController::RendererDidNavigate().

BUG=6408
TEST=From the new page, enter the URL to a malware site (ex: http://ianfette.org), press Back (or close the tab), there should be no crash.

Review URL: http://codereview.chromium.org/18433
------------------------------------------------------------------------
r8349 | pkasting@chromium.org | 2009-01-21 02:05:39 +0100 (Wed, 21 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Correct icon/title sizing/placement for varying titlebar font sizes.  This matches Windows pixel-for-pixel except where we adjust things slightly in restored mode to look better with our frame shape, and in occasional cases where our scaling differs slightly, mainly because the Windows icon caching makes it almost impossible to tell what the "correct" Windows behavior actually is.

This depends on my oustanding "fix scaled icon problems" change.

BUG=5054
Review URL: http://codereview.chromium.org/18396
------------------------------------------------------------------------
r8348 | pkasting@chromium.org | 2009-01-21 02:05:25 +0100 (Wed, 21 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc

Fix some problems with scaled icons.  This allows the TabIconView to automatically scale the throbber and favicon to whatever size the View itself is.  Notably, this does NOT change tab_renderer.cc, which _also_ draws favicons -- the former is used by app windows and the latter by standard tabs.  Argh!  I'm not going to bother unifying these for now even though it'd be nice, since we never scale up our tabs, just our app titlebars.

BUG=5054
Review URL: http://codereview.chromium.org/18392
------------------------------------------------------------------------
r8347 | evan@chromium.org | 2009-01-21 02:00:22 +0100 (Wed, 21 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/base/logging.cc
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/perf_test_suite.h
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/test_suite.h
   M /trunk/src/chrome/app/breakpad.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/debug_flags.cc
   M /trunk/src/chrome/common/debug_flags.h
   M /trunk/src/chrome/common/ipc_channel_posix.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/common/main_function_params.h
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   M /trunk/src/chrome/common/temp_scaffolding_stubs.h
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/reliability/reliability_test_suite.h
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/sandbox_uitests.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_test_suite.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/tools/test/image_diff/image_diff.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/webkit/activex_shim/activex_shared.cc
   M /trunk/src/webkit/glue/plugins/plugin_list_win.cc
   M /trunk/src/webkit/tools/test_shell/mac/main.mm
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/run_all_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

Make CommandLine into a normal object, with some statics for getting at the current process's command line.

One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before.  (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.)

Review URL: http://codereview.chromium.org/18248

------------------------------------------------------------------------
r8346 | agl@chromium.org | 2009-01-21 01:50:45 +0100 (Wed, 21 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/command_updater_unittest.cc

Disable a unittest which has never passed

Review URL: http://codereview.chromium.org/18437

------------------------------------------------------------------------
r8342 | paulg@google.com | 2009-01-21 01:07:24 +0100 (Wed, 21 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/history/download_database.cc

Fix two bugs that resulted in misplaced downloads and missing
file names in the download page.

BUG=6335 (crbug.com/6335 - "Download location ignored")


Review URL: http://codereview.chromium.org/18388
------------------------------------------------------------------------
r8336 | ben@chromium.org | 2009-01-21 00:32:54 +0100 (Wed, 21 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/command_updater_unittest.cc

Remove unnecessary unit tests (now we're just using ObserverList).

TBR=pinkerton
Review URL: http://codereview.chromium.org/18386
------------------------------------------------------------------------
r8334 | sky@google.com | 2009-01-21 00:21:04 +0100 (Wed, 21 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/ssl/ssl_uitest.cc

Disables a couple of consistently flakey/hanging tests.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/18384
------------------------------------------------------------------------
r8333 | brettw@chromium.org | 2009-01-21 00:17:56 +0100 (Wed, 21 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Scons updates for about:internets removal.
Review URL: http://codereview.chromium.org/18415
------------------------------------------------------------------------
r8332 | ben@chromium.org | 2009-01-21 00:03:14 +0100 (Wed, 21 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/command_updater.cc (from /trunk/src/chrome/browser/controller.cc:8217)
   A /trunk/src/chrome/browser/command_updater.h (from /trunk/src/chrome/browser/controller.h:8217)
   A /trunk/src/chrome/browser/command_updater_unittest.cc (from /trunk/src/chrome/browser/controller_unittest.cc:8217)
   D /trunk/src/chrome/browser/controller.cc
   D /trunk/src/chrome/browser/controller.h
   D /trunk/src/chrome/browser/controller_unittest.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   D /trunk/src/chrome/browser/views/delay_view.cc
   D /trunk/src/chrome/browser/views/delay_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/controller.h
   M /trunk/src/chrome/views/message_box_view.cc

Rework the command updater to not be dependent on views::Button (needed for porting).

TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list.
Review URL: http://codereview.chromium.org/18343
------------------------------------------------------------------------
r8324 | tc@google.com | 2009-01-20 22:49:23 +0100 (Tue, 20 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

disable WindowSessionEnd which was failing in debug

this seemed to be due to rolling forward the browser window change.

TBR=ben

Review URL: http://codereview.chromium.org/18429
------------------------------------------------------------------------
r8304 | jar@chromium.org | 2009-01-20 21:32:42 +0100 (Tue, 20 Jan 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics/metrics_service.cc

Add more production logging to diagnose upload problem

It appears that some logs get "stuck" trying to be sent,
so I've changed a number of DLOG() calls to LOG() calls.

I also added a bit of info to the LOG() calls, and made
minor edits.

bug=1505736

r=evanm
Review URL: http://codereview.chromium.org/18354
------------------------------------------------------------------------
r8293 | brettw@chromium.org | 2009-01-20 19:31:35 +0100 (Tue, 20 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc

Fix purify errors in previous testing patch.
Review URL: http://codereview.chromium.org/18409
------------------------------------------------------------------------
r8292 | tc@google.com | 2009-01-20 19:26:36 +0100 (Tue, 20 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Revert "revert r8217 until memory tests are fixed."  This re-applies r8217.
This reverts commit r8245.

TBR=ben

Review URL: http://codereview.chromium.org/18410

------------------------------------------------------------------------
r8283 | brettw@chromium.org | 2009-01-20 18:09:38 +0100 (Tue, 20 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   D /trunk/src/chrome/browser/tab_contents/about_internets_status_view.cc
   D /trunk/src/chrome/browser/tab_contents/about_internets_status_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h

Remove the about:internets view :(
This will make it diffitult to remove the tab contents type system and to port,
so I'm sadly removing it.
Review URL: http://codereview.chromium.org/18408
------------------------------------------------------------------------
r8282 | brettw@chromium.org | 2009-01-20 17:06:25 +0100 (Tue, 20 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc

Remove old initializer.
------------------------------------------------------------------------
r8281 | brettw@chromium.org | 2009-01-20 17:00:54 +0100 (Tue, 20 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   A /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc (from /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc:8262)
   A /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h (from /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h:8262)
   A /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc (from /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc:8262)
   A /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc (from /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc:8262)
   A /trunk/src/chrome/browser/renderer_host/test_render_view_host.h (from /trunk/src/chrome/browser/renderer_host/test_render_view_host.h:8262)
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 8263.
Review URL: http://codereview.chromium.org/18351
------------------------------------------------------------------------
r8280 | phajdan.jr@chromium.org | 2009-01-20 16:44:59 +0100 (Tue, 20 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/password_manager/password_form_manager.cc
   A /trunk/src/chrome/browser/password_manager/password_form_manager_win.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.cc
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   A /trunk/src/chrome/browser/webdata/web_data_service_win.cc

Porting in chrome/browser/

Review URL: http://codereview.chromium.org/17606
------------------------------------------------------------------------
r8263 | brettw@chromium.org | 2009-01-18 08:10:37 +0100 (Sun, 18 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   D /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   D /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   D /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   D /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   D /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 8262.
Review URL: http://codereview.chromium.org/18190
------------------------------------------------------------------------
r8262 | brettw@chromium.org | 2009-01-18 07:30:56 +0100 (Sun, 18 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   A /trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc
   A /trunk/src/chrome/browser/renderer_host/mock_render_process_host.h
   A /trunk/src/chrome/browser/renderer_host/render_view_host_unittest.cc
   A /trunk/src/chrome/browser/renderer_host/test_render_view_host.cc
   A /trunk/src/chrome/browser/renderer_host/test_render_view_host.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Create some test framework for RenderViewHost. Create a simple RenderView unit
test for illustrative purposes.

Review URL: http://codereview.chromium.org/18350
------------------------------------------------------------------------
r8258 | maruel@chromium.org | 2009-01-17 22:01:04 +0100 (Sat, 17 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h

NO CODE CHANGE. (Force a build)

------------------------------------------------------------------------
r8257 | abarth@chromium.org | 2009-01-17 20:15:36 +0100 (Sat, 17 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/base/histogram.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc

Collect some metrics on nosniff.  There is some concern that respecting this header causes more harm than good.

R=darin


Review URL: http://codereview.chromium.org/18214
------------------------------------------------------------------------
r8253 | sgk@google.com | 2009-01-17 03:25:22 +0100 (Sat, 17 Jan 2009) | 49 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/debug_message.scons
   M /trunk/src/base/gfx/base_gfx.scons
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/locales/locales.scons
   M /trunk/src/chrome/app/resources/SConscript
   M /trunk/src/chrome/app/theme/SConscript
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/chrome.scons
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/ipc_tests.scons
   M /trunk/src/chrome/installer/mini_installer/mini_installer.scons
   M /trunk/src/chrome/installer/setup/setup.scons
   M /trunk/src/chrome/installer/util/installer_unittests.scons
   M /trunk/src/chrome/installer/util/util.scons
   M /trunk/src/chrome/plugin/plugin.scons
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/test/activex_test_control/activex_test_control.scons
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.scons
   M /trunk/src/chrome/test/automation/automation.scons
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.scons
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.scons
   M /trunk/src/chrome/test/memory_test/memory_test.scons
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test.scons
   M /trunk/src/chrome/test/page_cycler/page_cycler_tests.scons
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/test/plugin/plugin_tests.scons
   M /trunk/src/chrome/test/reliability/reliability_tests.scons
   M /trunk/src/chrome/test/security_tests/security_tests.scons
   M /trunk/src/chrome/test/selenium/selenium_tests.scons
   M /trunk/src/chrome/test/startup/startup_tests.scons
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.scons
   M /trunk/src/chrome/test/ui/ui_tests.scons
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/tools/convert_dict/convert_dict.scons
   M /trunk/src/chrome/tools/crash_service/crash_service.scons
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.scons
   M /trunk/src/chrome/tools/profiles/generate_profile.scons
   M /trunk/src/chrome/tools/test/image_diff/image_diff.scons
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/net/crash_cache.scons
   M /trunk/src/net/dump_cache.scons
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_perftests.scons
   M /trunk/src/net/net_resources.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/stress_cache.scons
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.scons
   M /trunk/src/site_scons/site_tools/_Node_MSVS.py
   M /trunk/src/site_scons/site_tools/chromium_builders.py
   M /trunk/src/skia/SConscript
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/third_party/libpng/libpng.scons
   M /trunk/src/third_party/zlib/zlib.scons

Generate all chrome .vcproj files:

* Path name translation (/ to \) of various MSVSTool attributes.
* Explicit keyword= arguments to MSVSProject.  This will likely
  go away eventually in favor of uniform behavior.
* Add a relative_path_substitutions array that can be used
  to substitute in Visual Studio variable like $(OutDir).
* Add a local_directory_prefix that can be set to './' to only
  affect files in the current directory.
* Additional Keyword ordering in Tool attributes to continue to
  match the default order Visual Studio generates.
* Add a Derived() proxy class that can wrap a File node to tell
  the .vcproj generation that we want the derived file, not its
  source(s), in the file list.
* In the individual *.scons files, add the necessary files (mostly
  .h files) to file lists, and update MSVSProject() calls with
  the additional necessary information.

Result is identical .vcproj files modulo the following differences:

* Four locales .vcproj files (da, en-US, he and zh-TW) with
  source file orders that don't match the other locale .vcproj
  files have re-ordered file lists to match the rest.
* Cosmetic XML changes (white space, ending tags) in:
    chrome/app/chrome_dll.vcproj
    chrome/app/generated_resources.vcproj
    net/build/net_resources.vcproj
* Removal or addition of ./ prefixes from various files that don't
  match the other file specifications within their individual
  .vcproj files:
    chrome/installer/util/util.vcproj
    net/build/net.vcproj
    net/build/net_unittests.vcproj
* Add missing empty sections (<ToolFiles>, <References>, <Globals>)
  for consistency with other .vcproj files:
    chrome/tools/test/image_diff/image_diff.vcproj
    third_party/libpng/libpng.vcproj
    third_party/zlib/zlib.vcproj
* Add missing RootNameSpace attribute:
    chrome/test/automation/automation.vcproj
    testing/gtest.vcproj
* Use && instead of \r\n as a command separator, to sidestep
  XML-generation problems:
    chrome/app/chrome_exe.vcproj
* Remove unnecessary (?) duplicate files in the file list:
    chrome/browser/views/browser_views.vcproj
      (event_utils.cc and event_utils.h were duplicated)
  
Review URL: http://codereview.chromium.org/17603
------------------------------------------------------------------------
r8249 | aa@chromium.org | 2009-01-17 02:21:47 +0100 (Sat, 17 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.h
   M /trunk/src/chrome/browser/extensions/user_script_master.cc
   M /trunk/src/chrome/browser/extensions/user_script_master.h
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/renderer/user_script_slave.cc
   M /trunk/src/chrome/renderer/user_script_slave.h
   M /trunk/src/chrome/renderer/user_script_slave_unittest.cc

Move parsing of metadata header into browser process. This is a prerequisite
to getting user scripts working in extensions because extensions won't express
their metadata using the UserScript header, so parsing can't be done in the
renderer.

Review URL: http://codereview.chromium.org/18308
------------------------------------------------------------------------
r8245 | ben@chromium.org | 2009-01-17 01:01:57 +0100 (Sat, 17 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

revert r8217 until memory tests are fixed.

------------------------------------------------------------------------
r8244 | paulg@google.com | 2009-01-17 00:51:44 +0100 (Sat, 17 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc

End the SafeBrowsing update cycle when the update response
contains no chunk URLs (i.e. the client is up to date).

We currently don't handle this case properly, which results
in a DCHECK being hit.

BUG=6049 (http://crbug.com/6049)

Review URL: http://codereview.chromium.org/18181
------------------------------------------------------------------------
r8239 | jam@chromium.org | 2009-01-17 00:04:23 +0100 (Sat, 17 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/plugins/test/plugin_npobject_lifetime_test.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Improve scrolling performance when there are many windowed plugins in a page.

This works by parenting windowed plugins with an HWND that's hosted in the browser process, so that no synchronous cross process messages are used when scrolling. 
BUG=5428
Review URL: http://codereview.chromium.org/18082
------------------------------------------------------------------------
r8236 | tim@chromium.org | 2009-01-16 23:46:51 +0100 (Fri, 16 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.cc
   M /trunk/src/chrome/browser/password_manager/password_manager.h
   M /trunk/src/chrome/browser/ssl/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h

Fix issue 6296 by using a dedicated delegate instance for each infobar that the PasswordManager opens, rather than always using the PasswordManager itself as the delegate. 
The crash was occuring because before one infobar completely finished closing (i.e during its close animation), another password infobar would be opened, and for a moment in time two infobars are pointing to the same delegate. When the initial closing animation completes, it would null-out a field (pending_decision_manager_), which the now visible infobar would depend on when the user clicks one of the native buttons. This click would dereference a null member, hence causing the crash.

Other clients of infobars seem to be immune to this problem because they either all create dedicated delegate instances per infobar, or they don't reset any state on InfoBarClosed.

I think (at the very least) the infobar code should document that it can be risky to use a "shared" delegate due to the possibility of two simultaneously visible infobars referring to the same delegate.
Review URL: http://codereview.chromium.org/18065
------------------------------------------------------------------------
r8234 | ben@chromium.org | 2009-01-16 23:41:42 +0100 (Fri, 16 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Pull app modal dialog handling out of the BrowserList to remove the ChromeViews dependency. (Required for porting).

TEST=Open two browser windows. In one, enter "javascript:alert('Foo');" into the address bar and hit enter. Click on the other window. The modal dialog should be focused and the window it was opened over should flash in the taskbar,

Review URL: http://codereview.chromium.org/18179
------------------------------------------------------------------------
r8232 | jeremy@chromium.org | 2009-01-16 23:28:55 +0100 (Fri, 16 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

roll forward r8227.

Review URL: http://codereview.chromium.org/18336
------------------------------------------------------------------------
r8230 | dglazkov@google.com | 2009-01-16 23:11:14 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Reverting 8227.
Review URL: http://codereview.chromium.org/18177
------------------------------------------------------------------------
r8227 | jeremy@chromium.org | 2009-01-16 23:05:32 +0100 (Fri, 16 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Update browser/browser.scons to reconcile OSX and Linux.

Review URL: http://codereview.chromium.org/18170
------------------------------------------------------------------------
r8226 | tc@google.com | 2009-01-16 23:05:15 +0100 (Fri, 16 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

re-enable savepage ui test

The ui tests continued to time out after this test was disabled.
Looks like someone disconnected the bot and fixed something.  the
tests are now all passing, so I think we can re-enable.

Review URL: http://codereview.chromium.org/18331
------------------------------------------------------------------------
r8224 | ben@chromium.org | 2009-01-16 22:47:27 +0100 (Fri, 16 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.h
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   A /trunk/src/chrome/browser/net/url_fetcher.cc (from /trunk/src/chrome/browser/url_fetcher.cc:8164)
   A /trunk/src/chrome/browser/net/url_fetcher.h (from /trunk/src/chrome/browser/url_fetcher.h:8164)
   A /trunk/src/chrome/browser/net/url_fetcher_protect.cc (from /trunk/src/chrome/browser/url_fetcher_protect.cc:8164)
   A /trunk/src/chrome/browser/net/url_fetcher_protect.h (from /trunk/src/chrome/browser/url_fetcher_protect.h:8164)
   A /trunk/src/chrome/browser/net/url_fetcher_unittest.cc (from /trunk/src/chrome/browser/url_fetcher_unittest.cc:8164)
   A /trunk/src/chrome/browser/net/url_fixer_upper.cc (from /trunk/src/chrome/browser/url_fixer_upper.cc:8164)
   A /trunk/src/chrome/browser/net/url_fixer_upper.h (from /trunk/src/chrome/browser/url_fixer_upper.h:8164)
   A /trunk/src/chrome/browser/net/url_fixer_upper_unittest.cc (from /trunk/src/chrome/browser/url_fixer_upper_unittest.cc:8164)
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/search_engines/template_url_fetcher.h
   M /trunk/src/chrome/browser/spellchecker.cc
   D /trunk/src/chrome/browser/url_fetcher.cc
   D /trunk/src/chrome/browser/url_fetcher.h
   D /trunk/src/chrome/browser/url_fetcher_protect.cc
   D /trunk/src/chrome/browser/url_fetcher_protect.h
   D /trunk/src/chrome/browser/url_fetcher_unittest.cc
   D /trunk/src/chrome/browser/url_fixer_upper.cc
   D /trunk/src/chrome/browser/url_fixer_upper.h
   D /trunk/src/chrome/browser/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move url_* to net subdir

Review URL: http://codereview.chromium.org/18305
------------------------------------------------------------------------
r8217 | ben@chromium.org | 2009-01-16 22:15:48 +0100 (Fri, 16 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

window.cc should not include browser_list.h ... dependent (non-browser) windows are closed when they receive a notification rather than by being called directly from BrowserList. Also browser_list.cc should not include window.h, required for porting.

TEST=Open browser. Open options dialog box. Close browser. Options dialog should close too.

Review URL: http://codereview.chromium.org/18328
------------------------------------------------------------------------
r8205 | xji@chromium.org | 2009-01-16 20:53:00 +0100 (Fri, 16 Jan 2009) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h

This change list fix issues 6093 [settings] bad directionality for gears button
(http://crbug.com/6093).

The directionality of gears button is already fixed.
This CL fixes the wrong location of ":".

It adds RLM at the end of string "Google Gears:" for Hebrew and Arabic Chrome,
so that the ":" in "Google Gears:" in Hebrew is displayed leftmost instead of
rightmost.


Test:
1) open chrome, Hebrew UI
2) option -> under the hood -> google gears

Without the fix, the name appears as "Google Gears:".
With the fix, the name appears as ":Google Gears".


Review URL: http://codereview.chromium.org/18279
------------------------------------------------------------------------
r8194 | brettw@chromium.org | 2009-01-16 20:20:56 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/about_internets_status_view.h
   M /trunk/src/chrome/browser/tab_contents/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents/interstitial_page.h
   M /trunk/src/chrome/browser/tab_contents/ipc_status_view.h
   M /trunk/src/chrome/browser/tab_contents/native_ui_contents.h
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/network_status_view.h
   M /trunk/src/chrome/browser/tab_contents/page_navigator.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.h
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   M /trunk/src/chrome/browser/tab_contents/status_view.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_contents/tab_util.h
   M /trunk/src/chrome/browser/tab_contents/view_source_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/browser/tab_contents/web_drag_source.h
   M /trunk/src/chrome/browser/tab_contents/web_drop_target.h

Fix the include guards in tab_contents/* for the new location.
Review URL: http://codereview.chromium.org/18160
------------------------------------------------------------------------
r8188 | brettw@chromium.org | 2009-01-16 19:31:26 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/metrics/metrics_service.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/profile.cc
   D /trunk/src/chrome/browser/render_process_host.cc
   D /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   A /trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc (from /trunk/src/chrome/browser/render_process_host.cc:8123)
   A /trunk/src/chrome/browser/renderer_host/browser_render_process_host.h (from /trunk/src/chrome/browser/render_process_host.h:8123)
   A /trunk/src/chrome/browser/renderer_host/render_process_host.cc
   A /trunk/src/chrome/browser/renderer_host/render_process_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents/site_instance.h
   M /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents/tab_util.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/test/testing_profile.h

Move functions required by the rest of the browser from RenderProcessHost to an interface and move the implementation to BrowserRenderProcessHost. This will allow me to write render view unit tests without using the actual renderer, but there are no tests yet.
Review URL: http://codereview.chromium.org/18132
------------------------------------------------------------------------
r8185 | pinkerton@google.com | 2009-01-16 18:47:57 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/nibs/English.lproj/MainMenu.xib
   A /trunk/src/chrome/browser/app_controller_mac.h
   A /trunk/src/chrome/browser/app_controller_mac.mm
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_mac.mm
   M /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_paths.cc
   A /trunk/src/chrome/common/temp_scaffolding_stubs.cpp
   A /trunk/src/chrome/common/temp_scaffolding_stubs.h

mac bootstrapping of browser main and app startup bits
Review URL: http://codereview.chromium.org/18112
------------------------------------------------------------------------
r8183 | wtc@google.com | 2009-01-16 18:42:17 +0100 (Fri, 16 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_unittest.cc

Make GetSignonRealm a global function as opposed to
a static method of the LoginHandler class, which
should remain an interface with only pure virtual
methods.

R=eroman
Review URL: http://codereview.chromium.org/18106
------------------------------------------------------------------------
r8182 | brettw@chromium.org | 2009-01-16 18:41:33 +0100 (Fri, 16 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc

Fix a crash when handling close tab accelerators. The class would still be
accessed after the accelerator was handled, and close tab accelerators will
cause the view to be deleted out from under us.

BUG=6321
Review URL: http://codereview.chromium.org/18151
------------------------------------------------------------------------
r8179 | maruel@chromium.org | 2009-01-16 18:20:54 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Removed a stray string.
Review URL: http://codereview.chromium.org/18317
------------------------------------------------------------------------
r8178 | maruel@chromium.org | 2009-01-16 18:12:36 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Disable the test SavePageTest.CleanFilenameFromPageTitle due to bug 6514.
Review URL: http://codereview.chromium.org/18154
------------------------------------------------------------------------
r8174 | sgjesse@chromium.org | 2009-01-16 15:09:52 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/resources/debugger_shell.js

Update the command line JavaScript debugger to support the changed debugger protocol in V8 0.4.8. All the debugger tests now pass.
Review URL: http://codereview.chromium.org/18149
------------------------------------------------------------------------
r8170 | xji@chromium.org | 2009-01-16 08:29:21 +0100 (Fri, 16 Jan 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/common/gfx/text_elider.h

This change list fix issue 3233: RTL: Wrong URL showing on Javascript pop up window
( http://crbug.com/3233)

The fix put LTR-PDF pair around URL to force URL to be LTR always.

test step:
1. open RTL Chrome
2. open http://www.w3.org/International/tests/test-rtl-chrome-4
3. click any "click me" button

without the fix, the ending "/" in the URL appears at left-most in the alert window title.
with the fix, the ending "/" in the URL appears correctly.


Review URL: http://codereview.chromium.org/18088
------------------------------------------------------------------------
r8166 | darin@chromium.org | 2009-01-16 06:16:56 +0100 (Fri, 16 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h

Run ShellExecute on the file thread instead of the IO thread.  ShellExecute can
be janky so we don't want to be calling it on the IO thread.  The file thread
is really the "blocking io" thread, and it's where we call ShellExecute for
other things.

R=nsylvain

Review URL: http://codereview.chromium.org/18120
------------------------------------------------------------------------
r8165 | ben@chromium.org | 2009-01-16 04:29:03 +0100 (Fri, 16 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/ssl
   A /trunk/src/chrome/browser/ssl/ssl_blocking_page.cc (from /trunk/src/chrome/browser/ssl_blocking_page.cc:8131)
   A /trunk/src/chrome/browser/ssl/ssl_blocking_page.h (from /trunk/src/chrome/browser/ssl_blocking_page.h:8131)
   A /trunk/src/chrome/browser/ssl/ssl_error_info.cc (from /trunk/src/chrome/browser/ssl_error_info.cc:8131)
   A /trunk/src/chrome/browser/ssl/ssl_error_info.h (from /trunk/src/chrome/browser/ssl_error_info.h:8131)
   A /trunk/src/chrome/browser/ssl/ssl_manager.cc (from /trunk/src/chrome/browser/ssl_manager.cc:8131)
   A /trunk/src/chrome/browser/ssl/ssl_manager.h (from /trunk/src/chrome/browser/ssl_manager.h:8131)
   A /trunk/src/chrome/browser/ssl/ssl_policy.cc (from /trunk/src/chrome/browser/ssl_policy.cc:8131)
   A /trunk/src/chrome/browser/ssl/ssl_policy.h (from /trunk/src/chrome/browser/ssl_policy.h:8131)
   A /trunk/src/chrome/browser/ssl/ssl_uitest.cc (from /trunk/src/chrome/browser/ssl_uitest.cc:8131)
   D /trunk/src/chrome/browser/ssl_blocking_page.cc
   D /trunk/src/chrome/browser/ssl_blocking_page.h
   D /trunk/src/chrome/browser/ssl_error_info.cc
   D /trunk/src/chrome/browser/ssl_error_info.h
   D /trunk/src/chrome/browser/ssl_manager.cc
   D /trunk/src/chrome/browser/ssl_manager.h
   D /trunk/src/chrome/browser/ssl_policy.cc
   D /trunk/src/chrome/browser/ssl_policy.h
   D /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Move all the SSL stuff into its own subdir

Review URL: http://codereview.chromium.org/18137
------------------------------------------------------------------------
r8164 | paulg@google.com | 2009-01-16 03:57:22 +0100 (Fri, 16 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Remove timeout constants from ui_tests. All tests will now
use accessors for various timeouts which can be set (via
command line parameters) to values appropriate to the test
environment, such as longer timeouts when running under purify.
Review URL: http://codereview.chromium.org/18109
------------------------------------------------------------------------
r8156 | ben@chromium.org | 2009-01-16 02:29:22 +0100 (Fri, 16 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_main_win.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/history_tab_ui.cc
   M /trunk/src/chrome/browser/history_view.cc
   A /trunk/src/chrome/browser/metrics
   A /trunk/src/chrome/browser/metrics/metrics_log.cc (from /trunk/src/chrome/browser/metrics_log.cc:8131)
   A /trunk/src/chrome/browser/metrics/metrics_log.h (from /trunk/src/chrome/browser/metrics_log.h:8131)
   A /trunk/src/chrome/browser/metrics/metrics_log_unittest.cc (from /trunk/src/chrome/browser/metrics_log_unittest.cc:8131)
   A /trunk/src/chrome/browser/metrics/metrics_response.cc (from /trunk/src/chrome/browser/metrics_response.cc:8131)
   A /trunk/src/chrome/browser/metrics/metrics_response.h (from /trunk/src/chrome/browser/metrics_response.h:8131)
   A /trunk/src/chrome/browser/metrics/metrics_response_unittest.cc (from /trunk/src/chrome/browser/metrics_response_unittest.cc:8131)
   A /trunk/src/chrome/browser/metrics/metrics_service.cc (from /trunk/src/chrome/browser/metrics_service.cc:8148)
   A /trunk/src/chrome/browser/metrics/metrics_service.h (from /trunk/src/chrome/browser/metrics_service.h:8131)
   A /trunk/src/chrome/browser/metrics/metrics_service_uitest.cc (from /trunk/src/chrome/browser/metrics_service_uitest.cc:8131)
   A /trunk/src/chrome/browser/metrics/user_metrics.cc (from /trunk/src/chrome/browser/user_metrics.cc:8131)
   A /trunk/src/chrome/browser/metrics/user_metrics.h (from /trunk/src/chrome/browser/user_metrics.h:8131)
   D /trunk/src/chrome/browser/metrics_log.cc
   D /trunk/src/chrome/browser/metrics_log.h
   D /trunk/src/chrome/browser/metrics_log_unittest.cc
   D /trunk/src/chrome/browser/metrics_response.cc
   D /trunk/src/chrome/browser/metrics_response.h
   D /trunk/src/chrome/browser/metrics_response_unittest.cc
   D /trunk/src/chrome/browser/metrics_service.cc
   D /trunk/src/chrome/browser/metrics_service.h
   D /trunk/src/chrome/browser/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   D /trunk/src/chrome/browser/user_metrics.cc
   D /trunk/src/chrome/browser/user_metrics.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move metrics files into a subdir

Review URL: http://codereview.chromium.org/18302
------------------------------------------------------------------------
r8149 | ben@chromium.org | 2009-01-16 01:42:23 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Fix windows scons build.

------------------------------------------------------------------------
r8148 | ben@chromium.org | 2009-01-16 01:31:04 +0100 (Fri, 16 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   A /trunk/src/chrome/browser/search_engines
   A /trunk/src/chrome/browser/search_engines/template_url.cc (from /trunk/src/chrome/browser/template_url.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url.h (from /trunk/src/chrome/browser/template_url.h:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc (from /trunk/src/chrome/browser/template_url_fetcher.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_fetcher.h (from /trunk/src/chrome/browser/template_url_fetcher.h:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_model.cc (from /trunk/src/chrome/browser/template_url_model.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_model.h (from /trunk/src/chrome/browser/template_url_model.h:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc (from /trunk/src/chrome/browser/template_url_model_unittest.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_parser.cc (from /trunk/src/chrome/browser/template_url_parser.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_parser.h (from /trunk/src/chrome/browser/template_url_parser.h:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc (from /trunk/src/chrome/browser/template_url_parser_unittest.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc (from /trunk/src/chrome/browser/template_url_prepopulate_data.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h (from /trunk/src/chrome/browser/template_url_prepopulate_data.h:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc (from /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc:8111)
   A /trunk/src/chrome/browser/search_engines/template_url_unittest.cc (from /trunk/src/chrome/browser/template_url_unittest.cc:8111)
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   D /trunk/src/chrome/browser/template_url.cc
   D /trunk/src/chrome/browser/template_url.h
   D /trunk/src/chrome/browser/template_url_fetcher.cc
   D /trunk/src/chrome/browser/template_url_fetcher.h
   D /trunk/src/chrome/browser/template_url_model.cc
   D /trunk/src/chrome/browser/template_url_model.h
   D /trunk/src/chrome/browser/template_url_model_unittest.cc
   D /trunk/src/chrome/browser/template_url_parser.cc
   D /trunk/src/chrome/browser/template_url_parser.h
   D /trunk/src/chrome/browser/template_url_parser_unittest.cc
   D /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   D /trunk/src/chrome/browser/template_url_prepopulate_data.h
   D /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc
   D /trunk/src/chrome/browser/template_url_unittest.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move search code to a subdir

------------------------------------------------------------------------
r8126 | agl@chromium.org | 2009-01-15 23:25:11 +0100 (Thu, 15 Jan 2009) | 23 lines
Changed paths:
   M /trunk/src/base/atomic_ref_count.h
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/waitable_event.h
   D /trunk/src/base/waitable_event_generic.cc
   A /trunk/src/base/waitable_event_posix.cc
   M /trunk/src/base/waitable_event_unittest.cc
   A /trunk/src/base/waitable_event_watcher.h
   A /trunk/src/base/waitable_event_watcher_posix.cc
   A /trunk/src/base/waitable_event_watcher_unittest.cc
   A /trunk/src/base/waitable_event_watcher_win.cc
   M /trunk/src/base/waitable_event_win.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view.h
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message.h
   M /trunk/src/chrome/common/ipc_sync_channel.cc
   M /trunk/src/chrome/common/ipc_sync_channel.h
   M /trunk/src/chrome/common/ipc_sync_message.cc
   M /trunk/src/chrome/common/ipc_sync_message.h
   M /trunk/src/chrome/plugin/npobject_proxy.cc
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_util.cc
   M /trunk/src/chrome/plugin/npobject_util.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/testing_browser_process.h

WaitableEvent is the replacement for Windows events. Previously in the code, a HANDLE from CreateEvent was used for signaling, both within a process and across processes.

WaitableEvent is the cross platform replacement for this. To convert:
  * HANDLE -> base::WaitableEvent*
  * ScopedHandle -> scoped_ptr<base::WaitableEvent>
  * CreateEvent -> new base::WaitableEvent
  * SetEvent -> base::WaitableEvent::Signal
  * ResetEvent -> base::WaitableEvent::Reset
  * ObjectWatcher -> base::WaitableEventWatcher
  * WaitForMultipleObjects -> static base::WaitableEvent::WaitMany

ObjectWatcher remains for Windows specific code. WaitableEventWatcher has an identical interface save,
  * It uses WaitableEvents, not HANDLEs
  * It returns void from StartWatching and StopWatcher, rather than errors. System internal errors are fatal to the address space

IMPORTANT: There are semantic differences between the different platforms. WaitableEvents on Windows are implemented on top of events. Windows events work across process and this is used mostly for modal dialog support. Windows events can be duplicated with DuplicateHandle.

On other platforms, WaitableEvent works only within a single process. In the future we shall have to replace the current uses of cross-process events with IPCs.

BEWARE: HANDLE, on Windows, is a void *. Since any pointer type coerces to void *, you can pass a WaitableEvent * where a HANDLE is expected without any build-time errors.

Review URL: http://codereview.chromium.org/16554

------------------------------------------------------------------------
r8111 | ben@chromium.org | 2009-01-15 20:54:56 +0100 (Thu, 15 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   D /trunk/src/chrome/browser/search_engines
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   A /trunk/src/chrome/browser/template_url.cc (from /trunk/src/chrome/browser/template_url.cc:8109)
   A /trunk/src/chrome/browser/template_url.h (from /trunk/src/chrome/browser/template_url.h:8109)
   A /trunk/src/chrome/browser/template_url_fetcher.cc (from /trunk/src/chrome/browser/template_url_fetcher.cc:8109)
   A /trunk/src/chrome/browser/template_url_fetcher.h (from /trunk/src/chrome/browser/template_url_fetcher.h:8109)
   A /trunk/src/chrome/browser/template_url_model.cc (from /trunk/src/chrome/browser/template_url_model.cc:8109)
   A /trunk/src/chrome/browser/template_url_model.h (from /trunk/src/chrome/browser/template_url_model.h:8109)
   A /trunk/src/chrome/browser/template_url_model_unittest.cc (from /trunk/src/chrome/browser/template_url_model_unittest.cc:8109)
   A /trunk/src/chrome/browser/template_url_parser.cc (from /trunk/src/chrome/browser/template_url_parser.cc:8109)
   A /trunk/src/chrome/browser/template_url_parser.h (from /trunk/src/chrome/browser/template_url_parser.h:8109)
   A /trunk/src/chrome/browser/template_url_parser_unittest.cc (from /trunk/src/chrome/browser/template_url_parser_unittest.cc:8109)
   A /trunk/src/chrome/browser/template_url_prepopulate_data.cc (from /trunk/src/chrome/browser/template_url_prepopulate_data.cc:8109)
   A /trunk/src/chrome/browser/template_url_prepopulate_data.h (from /trunk/src/chrome/browser/template_url_prepopulate_data.h:8109)
   A /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc (from /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc:8109)
   A /trunk/src/chrome/browser/template_url_unittest.cc (from /trunk/src/chrome/browser/template_url_unittest.cc:8109)
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Fie.

------------------------------------------------------------------------
r8110 | ben@chromium.org | 2009-01-15 20:43:13 +0100 (Thu, 15 Jan 2009) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/search_engines
   A /trunk/src/chrome/browser/search_engines/template_url.cc (from /trunk/src/chrome/browser/template_url.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url.h (from /trunk/src/chrome/browser/template_url.h:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_fetcher.cc (from /trunk/src/chrome/browser/template_url_fetcher.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_fetcher.h (from /trunk/src/chrome/browser/template_url_fetcher.h:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_model.cc (from /trunk/src/chrome/browser/template_url_model.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_model.h (from /trunk/src/chrome/browser/template_url_model.h:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc (from /trunk/src/chrome/browser/template_url_model_unittest.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_parser.cc (from /trunk/src/chrome/browser/template_url_parser.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_parser.h (from /trunk/src/chrome/browser/template_url_parser.h:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_parser_unittest.cc (from /trunk/src/chrome/browser/template_url_parser_unittest.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.cc (from /trunk/src/chrome/browser/template_url_prepopulate_data.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data.h (from /trunk/src/chrome/browser/template_url_prepopulate_data.h:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc (from /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc:8109)
   A /trunk/src/chrome/browser/search_engines/template_url_unittest.cc (from /trunk/src/chrome/browser/template_url_unittest.cc:8109)
   D /trunk/src/chrome/browser/template_url.cc
   D /trunk/src/chrome/browser/template_url.h
   D /trunk/src/chrome/browser/template_url_fetcher.cc
   D /trunk/src/chrome/browser/template_url_fetcher.h
   D /trunk/src/chrome/browser/template_url_model.cc
   D /trunk/src/chrome/browser/template_url_model.h
   D /trunk/src/chrome/browser/template_url_model_unittest.cc
   D /trunk/src/chrome/browser/template_url_parser.cc
   D /trunk/src/chrome/browser/template_url_parser.h
   D /trunk/src/chrome/browser/template_url_parser_unittest.cc
   D /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   D /trunk/src/chrome/browser/template_url_prepopulate_data.h
   D /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc
   D /trunk/src/chrome/browser/template_url_unittest.cc

Part of previous move that seems to have gotten botched.

------------------------------------------------------------------------
r8109 | ben@chromium.org | 2009-01-15 20:34:28 +0100 (Thu, 15 Jan 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fix for Issue 3258: Tabs created when tabstrip is compressed pending resize
relayout should not force resize relayout.

This is proposed solution one from the comment#5 which is to
create new tabs without resizing existing tabs unless there is
no room for the new tab.

BUG=3258

Change from Itai Danan (idanan@google.com)
Code review: http://codereview.chromium.org/14050

------------------------------------------------------------------------
r8108 | ben@chromium.org | 2009-01-15 20:33:07 +0100 (Thu, 15 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc
   M /trunk/src/chrome/browser/template_url.cc
   M /trunk/src/chrome/browser/template_url.h
   M /trunk/src/chrome/browser/template_url_fetcher.cc
   M /trunk/src/chrome/browser/template_url_fetcher.h
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model.h
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/template_url_parser.cc
   M /trunk/src/chrome/browser/template_url_parser.h
   M /trunk/src/chrome/browser/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/browser/template_url_unittest.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move search engines files into subdir

Review URL: http://codereview.chromium.org/18263
------------------------------------------------------------------------
r8091 | nsylvain@chromium.org | 2009-01-15 16:30:00 +0100 (Thu, 15 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_unittest.cc

Revert change 8081 because it breaks the unit tests
Review URL: http://codereview.chromium.org/18274
------------------------------------------------------------------------
r8085 | ericroman@google.com | 2009-01-15 07:43:48 +0100 (Thu, 15 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   A /trunk/src/chrome/browser/login_prompt_unittest.cc (from /trunk/src/net/base/auth_cache_unittest.cc:7972)
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   D /trunk/src/net/base/auth_cache.cc
   D /trunk/src/net/base/auth_cache.h
   D /trunk/src/net/base/auth_cache_unittest.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   A /trunk/src/net/ftp/ftp_auth_cache.cc (from /trunk/src/net/base/auth_cache.cc:7972)
   A /trunk/src/net/ftp/ftp_auth_cache.h (from /trunk/src/net/base/auth_cache.h:7972)
   A /trunk/src/net/ftp/ftp_auth_cache_unittest.cc
   M /trunk/src/net/ftp/ftp_network_layer.cc
   M /trunk/src/net/ftp/ftp_network_layer.h
   M /trunk/src/net/ftp/ftp_network_session.h
   M /trunk/src/net/ftp/ftp_transaction_factory.h
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_ftp_job.cc

post-winhttp cleanup: refactor net/base/auth_cache into net/ftp/ftp_auth_cache.

Also moves AuthCache::HttpKey() --> GetSignonRealmKey().

Review URL: http://codereview.chromium.org/18218
------------------------------------------------------------------------
r8081 | levin@chromium.org | 2009-01-15 07:03:21 +0100 (Thu, 15 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_unittest.cc

This test only passed if RLZTracker::InitRlz hadn't been called, 
so it failed when the test run order happened to change.

This change fixes that.

Review URL: http://codereview.chromium.org/18222
------------------------------------------------------------------------
r8076 | paulg@google.com | 2009-01-15 04:46:41 +0100 (Thu, 15 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj

Remove non-existant files that should have been removed
in this CL: http://codereview.chromium.org/18259
Review URL: http://codereview.chromium.org/18083
------------------------------------------------------------------------
r8067 | ben@chromium.org | 2009-01-15 02:45:09 +0100 (Thu, 15 Jan 2009) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tab_contents/web_contents.cc

fix bustage
------------------------------------------------------------------------
r8066 | ben@chromium.org | 2009-01-15 02:35:45 +0100 (Thu, 15 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/encryptor.cc
   D /trunk/src/chrome/browser/encryptor.h
   D /trunk/src/chrome/browser/encryptor_unittest.cc
   D /trunk/src/chrome/browser/ie7_password.cc
   D /trunk/src/chrome/browser/ie7_password.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   D /trunk/src/chrome/browser/password_form_manager.cc
   D /trunk/src/chrome/browser/password_form_manager.h
   D /trunk/src/chrome/browser/password_form_manager_unittest.cc
   A /trunk/src/chrome/browser/password_manager
   A /trunk/src/chrome/browser/password_manager/encryptor.cc (from /trunk/src/chrome/browser/encryptor.cc:8041)
   A /trunk/src/chrome/browser/password_manager/encryptor.h (from /trunk/src/chrome/browser/encryptor.h:8041)
   A /trunk/src/chrome/browser/password_manager/encryptor_unittest.cc (from /trunk/src/chrome/browser/encryptor_unittest.cc:8041)
   A /trunk/src/chrome/browser/password_manager/ie7_password.cc (from /trunk/src/chrome/browser/ie7_password.cc:8041)
   A /trunk/src/chrome/browser/password_manager/ie7_password.h (from /trunk/src/chrome/browser/ie7_password.h:8041)
   A /trunk/src/chrome/browser/password_manager/password_form_manager.cc (from /trunk/src/chrome/browser/password_form_manager.cc:8041)
   A /trunk/src/chrome/browser/password_manager/password_form_manager.h (from /trunk/src/chrome/browser/password_form_manager.h:8041)
   A /trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc (from /trunk/src/chrome/browser/password_form_manager_unittest.cc:8041)
   A /trunk/src/chrome/browser/password_manager/password_manager.cc (from /trunk/src/chrome/browser/password_manager.cc:8058)
   A /trunk/src/chrome/browser/password_manager/password_manager.h (from /trunk/src/chrome/browser/password_manager.h:8058)
   D /trunk/src/chrome/browser/password_manager.cc
   D /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database_win.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move password manager files into a subdir

Review URL: http://codereview.chromium.org/18259
------------------------------------------------------------------------
r8060 | pkasting@chromium.org | 2009-01-15 02:09:58 +0100 (Thu, 15 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Render maximized mode better when using nonstandard border widths.

This change is a bit gross.  It calls out to GetSystemMetrics() all over this code, which just shows how many places are sizing themselves from the window edge instead of from the window border edge.  When cleaning this file up to be more sane, I intend to make most of these functions position themselves based on the border edge, which should cut down the number of these calls to just a couple (and perhaps collapse some of the constants together too).

BUG=5054

TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window.  Make sure the window controls appear where you expect instead of partly or totally off the screen edges.
Review URL: http://codereview.chromium.org/18255
------------------------------------------------------------------------
r8059 | pkasting@chromium.org | 2009-01-15 02:05:11 +0100 (Thu, 15 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fix status bubble positioning with custom border widths by positioning the bubble relative to the client area and then converting to parent coordinates instead of trying to position it absolutely with hardcoded constants.

Also changes an Offset() call to ConvertPointToView(), which is functionally the same but I think clearer in intent.

BUG=5054

TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window. Make sure when hovering a link that the status bubble appears aligned with the screen corner instead of partly offscreen.
Review URL: http://codereview.chromium.org/18253
------------------------------------------------------------------------
r8058 | ben@chromium.org | 2009-01-15 01:59:16 +0100 (Thu, 15 Jan 2009) | 3 lines
Changed paths:
   D /trunk/src/chrome/browser/about_internets_status_view.cc
   D /trunk/src/chrome/browser/about_internets_status_view.h
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/automation/automation_constrained_window_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/cert_store.cc
   D /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/history_tab_ui.h
   M /trunk/src/chrome/browser/history_view.cc
   D /trunk/src/chrome/browser/infobar_delegate.cc
   D /trunk/src/chrome/browser/infobar_delegate.h
   D /trunk/src/chrome/browser/interstitial_page.cc
   D /trunk/src/chrome/browser/interstitial_page.h
   D /trunk/src/chrome/browser/ipc_status_view.cc
   D /trunk/src/chrome/browser/ipc_status_view.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/load_notification_details.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/memory_details.cc
   D /trunk/src/chrome/browser/native_ui_contents.cc
   D /trunk/src/chrome/browser/native_ui_contents.h
   D /trunk/src/chrome/browser/navigation_controller.cc
   D /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   D /trunk/src/chrome/browser/navigation_entry.cc
   D /trunk/src/chrome/browser/navigation_entry.h
   D /trunk/src/chrome/browser/network_status_view.cc
   D /trunk/src/chrome/browser/network_status_view.h
   D /trunk/src/chrome/browser/page_navigator.h
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_manager.cc
   D /trunk/src/chrome/browser/provisional_load_details.cc
   D /trunk/src/chrome/browser/provisional_load_details.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/sessions/base_session_service.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service_unittest.cc
   M /trunk/src/chrome/browser/sessions/session_types.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   D /trunk/src/chrome/browser/site_instance.cc
   D /trunk/src/chrome/browser/site_instance.h
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   D /trunk/src/chrome/browser/status_view.cc
   D /trunk/src/chrome/browser/status_view.h
   A /trunk/src/chrome/browser/tab_contents
   A /trunk/src/chrome/browser/tab_contents/about_internets_status_view.cc (from /trunk/src/chrome/browser/about_internets_status_view.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/about_internets_status_view.h (from /trunk/src/chrome/browser/about_internets_status_view.h:8041)
   A /trunk/src/chrome/browser/tab_contents/constrained_window.h (from /trunk/src/chrome/browser/constrained_window.h:8041)
   A /trunk/src/chrome/browser/tab_contents/infobar_delegate.cc (from /trunk/src/chrome/browser/infobar_delegate.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/infobar_delegate.h (from /trunk/src/chrome/browser/infobar_delegate.h:8041)
   A /trunk/src/chrome/browser/tab_contents/interstitial_page.cc (from /trunk/src/chrome/browser/interstitial_page.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/interstitial_page.h (from /trunk/src/chrome/browser/interstitial_page.h:8041)
   A /trunk/src/chrome/browser/tab_contents/ipc_status_view.cc (from /trunk/src/chrome/browser/ipc_status_view.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/ipc_status_view.h (from /trunk/src/chrome/browser/ipc_status_view.h:8041)
   A /trunk/src/chrome/browser/tab_contents/native_ui_contents.cc (from /trunk/src/chrome/browser/native_ui_contents.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/native_ui_contents.h (from /trunk/src/chrome/browser/native_ui_contents.h:8041)
   A /trunk/src/chrome/browser/tab_contents/navigation_controller.cc (from /trunk/src/chrome/browser/navigation_controller.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/navigation_controller.h (from /trunk/src/chrome/browser/navigation_controller.h:8041)
   A /trunk/src/chrome/browser/tab_contents/navigation_entry.cc (from /trunk/src/chrome/browser/navigation_entry.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/navigation_entry.h (from /trunk/src/chrome/browser/navigation_entry.h:8041)
   A /trunk/src/chrome/browser/tab_contents/network_status_view.cc (from /trunk/src/chrome/browser/network_status_view.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/network_status_view.h (from /trunk/src/chrome/browser/network_status_view.h:8041)
   A /trunk/src/chrome/browser/tab_contents/page_navigator.h (from /trunk/src/chrome/browser/page_navigator.h:8041)
   A /trunk/src/chrome/browser/tab_contents/provisional_load_details.cc (from /trunk/src/chrome/browser/provisional_load_details.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/provisional_load_details.h (from /trunk/src/chrome/browser/provisional_load_details.h:8041)
   A /trunk/src/chrome/browser/tab_contents/site_instance.cc (from /trunk/src/chrome/browser/site_instance.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/site_instance.h (from /trunk/src/chrome/browser/site_instance.h:8041)
   A /trunk/src/chrome/browser/tab_contents/status_view.cc (from /trunk/src/chrome/browser/status_view.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/status_view.h (from /trunk/src/chrome/browser/status_view.h:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_contents.cc (from /trunk/src/chrome/browser/tab_contents.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_contents.h (from /trunk/src/chrome/browser/tab_contents.h:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h (from /trunk/src/chrome/browser/tab_contents_delegate.h:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_factory.cc (from /trunk/src/chrome/browser/tab_contents_factory.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_factory.h (from /trunk/src/chrome/browser/tab_contents_factory.h:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_contents_type.h (from /trunk/src/chrome/browser/tab_contents_type.h:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_util.cc (from /trunk/src/chrome/browser/tab_util.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/tab_util.h (from /trunk/src/chrome/browser/tab_util.h:8041)
   A /trunk/src/chrome/browser/tab_contents/view_source_contents.cc (from /trunk/src/chrome/browser/view_source_contents.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/view_source_contents.h (from /trunk/src/chrome/browser/view_source_contents.h:8041)
   A /trunk/src/chrome/browser/tab_contents/view_source_uitest.cc (from /trunk/src/chrome/browser/view_source_uitest.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/web_contents.cc (from /trunk/src/chrome/browser/web_contents.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/web_contents.h (from /trunk/src/chrome/browser/web_contents.h:8041)
   A /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc (from /trunk/src/chrome/browser/web_contents_unittest.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/web_contents_view.cc (from /trunk/src/chrome/browser/web_contents_view.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/web_contents_view.h (from /trunk/src/chrome/browser/web_contents_view.h:8041)
   A /trunk/src/chrome/browser/tab_contents/web_contents_view_win.cc (from /trunk/src/chrome/browser/web_contents_view_win.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/web_contents_view_win.h (from /trunk/src/chrome/browser/web_contents_view_win.h:8041)
   A /trunk/src/chrome/browser/tab_contents/web_drag_source.cc (from /trunk/src/chrome/browser/web_drag_source.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/web_drag_source.h (from /trunk/src/chrome/browser/web_drag_source.h:8041)
   A /trunk/src/chrome/browser/tab_contents/web_drop_target.cc (from /trunk/src/chrome/browser/web_drop_target.cc:8041)
   A /trunk/src/chrome/browser/tab_contents/web_drop_target.h (from /trunk/src/chrome/browser/web_drop_target.h:8041)
   D /trunk/src/chrome/browser/tab_contents.cc
   D /trunk/src/chrome/browser/tab_contents.h
   D /trunk/src/chrome/browser/tab_contents_delegate.h
   D /trunk/src/chrome/browser/tab_contents_factory.cc
   D /trunk/src/chrome/browser/tab_contents_factory.h
   D /trunk/src/chrome/browser/tab_contents_type.h
   D /trunk/src/chrome/browser/tab_util.cc
   D /trunk/src/chrome/browser/tab_util.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   D /trunk/src/chrome/browser/view_source_contents.cc
   D /trunk/src/chrome/browser/view_source_contents.h
   D /trunk/src/chrome/browser/view_source_uitest.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_tab_view.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/web_app.cc
   M /trunk/src/chrome/browser/web_app_icon_manager.cc
   D /trunk/src/chrome/browser/web_contents.cc
   D /trunk/src/chrome/browser/web_contents.h
   D /trunk/src/chrome/browser/web_contents_unittest.cc
   D /trunk/src/chrome/browser/web_contents_view.cc
   D /trunk/src/chrome/browser/web_contents_view.h
   D /trunk/src/chrome/browser/web_contents_view_win.cc
   D /trunk/src/chrome/browser/web_contents_view_win.h
   D /trunk/src/chrome/browser/web_drag_source.cc
   D /trunk/src/chrome/browser/web_drag_source.h
   D /trunk/src/chrome/browser/web_drop_target.cc
   D /trunk/src/chrome/browser/web_drop_target.h
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/test_tab_contents.cc
   M /trunk/src/chrome/test/test_tab_contents.h
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move a bunch of TabContents related files into a tab_contents subdir

Review URL: http://codereview.chromium.org/18250
------------------------------------------------------------------------
r8052 | paulg@google.com | 2009-01-15 01:13:23 +0100 (Thu, 15 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

More ui_test purify changes.
Review URL: http://codereview.chromium.org/18069
------------------------------------------------------------------------
r8040 | jcampan@chromium.org | 2009-01-14 22:17:11 +0100 (Wed, 14 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

When opening a new tab by pressing CTRL-T in app mode, the location bar would not get focused.
This is because when the tab was shown its browser window is not yet active.

BUG=6380
TEST=Open an app (ex: gmail), press CTRL-T, this opens a new browser with a new tab. Navigate to google.com in the new tab. Go back to the app, press CTRL-T again, a new tab should be opened and the location bar should have focus.
Review URL: http://codereview.chromium.org/18017
------------------------------------------------------------------------
r8022 | agl@chromium.org | 2009-01-14 18:49:12 +0100 (Wed, 14 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc

Build fix: altbase.h inclusion in hang_monitor

r8020 tickled an issue by removing altbase.h from a header file where it
shouldn't have been needed.

Review URL: http://codereview.chromium.org/18228

------------------------------------------------------------------------
r8007 | sky@google.com | 2009-01-14 16:51:10 +0100 (Wed, 14 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/browser_commands_unittest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   A /trunk/src/chrome/test/browser_with_test_window_test.cc
   A /trunk/src/chrome/test/browser_with_test_window_test.h
   A /trunk/src/chrome/test/test_browser_window.h
   M /trunk/src/chrome/test/test_tab_contents.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/window_delegate.cc

Provides the infrastructure for Browser unit tests that create a
BrowserWindow with only a TabStrip. I also converted two ui tests over
to unit tests to make sure it all worked. I had to add a bunch of null
checks to Browser and a couple of other places.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/17386
------------------------------------------------------------------------
r8002 | levin@chromium.org | 2009-01-14 09:56:52 +0100 (Wed, 14 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc

Fix linux build of unittests.

TBR=evan

------------------------------------------------------------------------
r8001 | levin@chromium.org | 2009-01-14 09:27:39 +0100 (Wed, 14 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc

Fix UrlFetcher unittest.

TBR=joshia,iyengar

Review URL: http://codereview.chromium.org/18220
------------------------------------------------------------------------
r7998 | levin@chromium.org | 2009-01-14 03:18:36 +0100 (Wed, 14 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_unittest.cc

Temp fix for windows unit tests.

TBR=dimich

------------------------------------------------------------------------
r7990 | darin@chromium.org | 2009-01-14 01:34:43 +0100 (Wed, 14 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_dialogs.h

Fix the release build by including <vector>

TBR=zork

Review URL: http://codereview.chromium.org/18032
------------------------------------------------------------------------
r7989 | pkasting@chromium.org | 2009-01-14 01:02:59 +0100 (Wed, 14 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

After playing around with a modified image from Glen, I concluded that a comment I wrote saying something should be changed was wrong.  So fix the comment.
Review URL: http://codereview.chromium.org/18028
------------------------------------------------------------------------
r7986 | zork@google.com | 2009-01-14 00:54:57 +0100 (Wed, 14 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Updating so that Gears can spawn file selectors when running in the renderer process
Review URL: http://codereview.chromium.org/14907
------------------------------------------------------------------------
r7976 | pkasting@chromium.org | 2009-01-13 23:34:48 +0100 (Tue, 13 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Pixel perfection on tabstrip for non-Aero frame.  This gets both ends of the tabstrip positioned correctly for normal and incognito windows, in both restored and maximized modes.The chief change was to correctly transform the bounds returned by the non-client view into the BrowserView's coordinate system, as the Views system expected.  To make this not break the world I then had to actually return the right coordinates in the non-client view :).  Updated comments on function declarations to hopefully match reality.For convenience this also introduces a function to get the horizontal border size and cleans up existing code to use it.BUG=5054
Review URL: http://codereview.chromium.org/18019
------------------------------------------------------------------------
r7970 | wtc@google.com | 2009-01-13 22:37:21 +0100 (Tue, 13 Jan 2009) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   D /trunk/src/net/http/cert_status_cache.cc
   D /trunk/src/net/http/cert_status_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   D /trunk/src/net/http/http_transaction_winhttp.cc
   D /trunk/src/net/http/http_transaction_winhttp.h
   D /trunk/src/net/http/http_transaction_winhttp_unittest.cc
   D /trunk/src/net/http/winhttp_request_throttle.cc
   D /trunk/src/net/http/winhttp_request_throttle.h
   D /trunk/src/net/http/winhttp_request_throttle_unittest.cc
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/webkit/tools/layout_tests/run_webkit_tests.py
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.h
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

Remove HttpTransactionWinHttp and the --winhttp command-line
switch.

Remove WinHttpThrottle and CertStatusCache, which are only
used by HttpTransactionWinHttp.

Fix nits reported by cpplint.py.

R=eroman,darin
BUG=6323
Review URL: http://codereview.chromium.org/17635
------------------------------------------------------------------------
r7932 | deanm@chromium.org | 2009-01-13 17:19:42 +0100 (Tue, 13 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/history_ui.cc

Remove a std::string static constructor in the new history dom ui.

Review URL: http://codereview.chromium.org/17361

------------------------------------------------------------------------
r7927 | deanm@chromium.org | 2009-01-13 15:56:13 +0100 (Tue, 13 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/cache_manager_host_unittest.cc

Remove a static initializer for a TimeDelta constant.

Review URL: http://codereview.chromium.org/17631

------------------------------------------------------------------------
r7925 | deanm@chromium.org | 2009-01-13 13:41:14 +0100 (Tue, 13 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc

Remove a static initializer while reducing a bit of casting.

Review URL: http://codereview.chromium.org/17628

------------------------------------------------------------------------
r7913 | ojan@google.com | 2009-01-13 02:43:26 +0100 (Tue, 13 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Add hover cards to the recently closed windows on the new tab page.
Review URL: http://codereview.chromium.org/17226
------------------------------------------------------------------------
r7909 | brg@chromium.com | 2009-01-13 01:56:49 +0100 (Tue, 13 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Regression for importer.  Updated the code to reflect the coding standards of the chrome team.
Review URL: http://codereview.chromium.org/10272
------------------------------------------------------------------------
r7908 | pkasting@chromium.org | 2009-01-13 01:55:40 +0100 (Tue, 13 Jan 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Pixel perfection on OTR icon.  The tabstrip is still positioned/sized wrong relative to the OTR icon, sadly.

Much of the issue here is because the OTR image was a child view in the old code and isn't in the new.  As a result, we have to:
* Change the drawing order to draw the OTR image after the tabstrip (like a child view would normally have been drawn), so the tabstrip's semi-transparent pixels don't overlay it
* Change the bounds calculation and drawing code to clip the image properly in maximized mode (where a child view would have been clipped naturally)

Since I changed the calling order of the OTR functions, I also changed their declaration/definition order to follow suit.

This also tries to rename a few constants to be more consistent.  I can't figure out how to make any of these read nicely :(

BUG=5054
Review URL: http://codereview.chromium.org/17362
------------------------------------------------------------------------
r7907 | jam@chromium.org | 2009-01-13 01:54:21 +0100 (Tue, 13 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/webplugin.h

Fix layout test failures.  Looks like keying the plugins based on OriginalFileName didn't work, since different filenames might still have the same value (i.e. QuickTime).  Instead I did what Firefox does, which is collect the list of directories in one pass, then crawl them in another.
Review URL: http://codereview.chromium.org/17367
------------------------------------------------------------------------
r7905 | joshia@google.com | 2009-01-13 01:02:25 +0100 (Tue, 13 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Check if the delegate in WebContents::CanTerminate is valid
before invoking on it. not doing this causes a UT test
'VisibleBrowserTest.WindowOpenClose' to crash frequently.



Review URL: http://codereview.chromium.org/17366
------------------------------------------------------------------------
r7901 | joshia@google.com | 2009-01-13 00:03:08 +0100 (Tue, 13 Jan 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

On exit do not terminate renderers hosted in external tabs

When a browser window is closed, we just terminate
all existing renderers for fast shutdown. If we have
any renderers hosted externally using automation they
are also killed during this process. 

The fix is to prevent fast termination if any of the
tabs are hosted by automation.


Review URL: http://codereview.chromium.org/17453
------------------------------------------------------------------------
r7898 | jcampan@chromium.org | 2009-01-12 23:40:07 +0100 (Mon, 12 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/interstitial_page.cc
   M /trunk/src/chrome/browser/interstitial_page.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

This CL adds a way to block resource requests in the ResourceDispatcherHost for specific RenderViewHosts.
This is used by the interstitial code to prevent the original page from making network requests while the interstitial is showing.

Several UI tests are still required to test this. Because of the inherent complexity of the scenarios to test this, I'm afraid these tests are going to be flakey and soon after disabled (like many of the interstitial UI tests at this point).
This will be done next as part of my next effort to mock some of the WebContents stuff.

TEST=Run the unit tests. Create a page that does XMLHttpRequests and log when the requests complete with the time it did. While that page is shown, switch to a malware/bad SSL page. Come back to the page, ensure no requests were processed while the interstitial was showing.
BUG=None
Review URL: http://codereview.chromium.org/16546
------------------------------------------------------------------------
r7891 | tommi@chromium.org | 2009-01-12 21:14:08 +0100 (Mon, 12 Jan 2009) | 43 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc

Fixing crash in SafeBrowsingDatabaseBloom:
When SafeBrowsingDatabaseBloom is going out of scope (see stack trace below) Close() is called.
When insert_transaction_ is non NULL, it holds a pointer to the database, |db_|, which is owned by SafeBrowsingDatabaseBloom.
Close() closes the database but did not free |insert_transaction_| which causes |insert_transaction_| to attempt to rollback the transaction with an invalid database pointer.

The fix is simply to reset the transaction before closing the database.

Stack:
0:009> kP
ChildEBP RetAddr  
0579fa14 027e73e0 ntdll!RtlEnterCriticalSection+0xb
0579fa24 027958e6 chrome_12d0000!winMutexEnter(
			struct sqlite3_mutex * p = 0xdddddddd)+0x10 [c:\chromium\src\third_party\sqlite\src\mutex_w32.c @ 185]
0579fa34 0278d76c chrome_12d0000!sqlite3_mutex_enter(
			struct sqlite3_mutex * p = 0xdddddddd)+0x16 [c:\chromium\src\third_party\sqlite\src\mutex.c @ 111]
0579fa80 029655f8 chrome_12d0000!sqlite3_exec(
			struct sqlite3 * db = 0x06df6618, 
			char * zSql = 0x043feec0 "ROLLBACK", 
			<function> * xCallback = 0x00000000, 
			void * pArg = 0x00000000, 
			char ** pzErrMsg = 0x00000000)+0x4c [c:\chromium\src\third_party\sqlite\src\legacy.c @ 50]
0579faa4 02965523 chrome_12d0000!SQLTransaction::EndCommand(
			char * command = 0x043feec0 "ROLLBACK")+0x48 [c:\chromium\src\chrome\common\sqlite_utils.cc @ 96]
0579fab8 029654ea chrome_12d0000!SQLTransaction::Rollback(void)+0x23 [c:\chromium\src\chrome\common\sqlite_utils.h @ 57]
0579fac4 02965496 chrome_12d0000!SQLTransaction::~SQLTransaction(void)+0x2a [c:\chromium\src\chrome\common\sqlite_utils.cc @ 82]
0579fad0 01ad0cdf chrome_12d0000!SQLTransaction::`scalar deleting destructor'(void)+0x16
0579faf0 01ac8c49 chrome_12d0000!scoped_ptr<SQLTransaction>::~scoped_ptr<SQLTransaction>(void)+0x3f [c:\chromium\src\base\scoped_ptr.h @ 72]
0579fafc 01ac8a86 chrome_12d0000!SafeBrowsingDatabaseBloom::~SafeBrowsingDatabaseBloom(void)+0x49 [c:\chromium\src\chrome\browser\safe_browsing\safe_browsing_database_bloom.cc @ 61]
0579fb08 017bb3a0 chrome_12d0000!SafeBrowsingDatabaseBloom::`scalar deleting destructor'(void)+0x16
0579fb28 01c66a99 chrome_12d0000!DeleteTask<SafeBrowsingDatabase>::Run(void)+0x40 [c:\chromium\src\base\task.h @ 227]
0579fbd8 01c66b45 chrome_12d0000!MessageLoop::RunTask(
			class Task * task = 0x0800df10)+0xb9 [c:\chromium\src\base\message_loop.cc @ 308]
0579fbe8 01c67029 chrome_12d0000!MessageLoop::DeferOrRunPendingTask(
			struct MessageLoop::PendingTask * pending_task = 0x0579fc04)+0x35 [c:\chromium\src\base\message_loop.cc @ 319]
0579fc24 01cea44c chrome_12d0000!MessageLoop::DoWork(void)+0xe9 [c:\chromium\src\base\message_loop.cc @ 408]
0579fd04 01c663bb chrome_12d0000!base::MessagePumpDefault::Run(
			class base::MessagePump::Delegate * delegate = 0x0579feb4)+0xbc [c:\chromium\src\base\message_pump_default.cc @ 23]
0579fdb0 01c66220 chrome_12d0000!MessageLoop::RunInternal(void)+0xfb [c:\chromium\src\base\message_loop.cc @ 197]
0579fde8 01c660aa chrome_12d0000!MessageLoop::RunHandler(void)+0x90 [c:\chromium\src\base\message_loop.cc @ 181]
0579fe10 01c86d38 chrome_12d0000!MessageLoop::Run(void)+0x3a [c:\chromium\src\base\message_loop.cc @ 155]
0579ffa4 01c86071 chrome_12d0000!base::Thread::ThreadMain(void)+0xb8 [c:\chromium\src\base\thread.cc @ 156]

Review URL: http://codereview.chromium.org/17617
------------------------------------------------------------------------
r7888 | jam@chromium.org | 2009-01-12 20:43:44 +0100 (Mon, 12 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Get rid of lowercasing plugin filenames in order to determine if two paths point to the same plugin.  Check plugin versions and load the latest version if multiple versions are found.I've also refactored and cleaned PluginList so that it doesn't depend on PluginLib, which only made sense a long time ago when plugins were loaded in process.  Now PluginLib will only be loaded in the plugin process (and not in the browser process as well).
Review URL: http://codereview.chromium.org/17451
------------------------------------------------------------------------
r7887 | erikkay@google.com | 2009-01-12 20:36:42 +0100 (Mon, 12 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/data/extensions/extension1/manifest
   M /trunk/src/chrome/test/data/extensions/extension2/manifest

Add version to list of required fields.  This is required prep work for extension installation.

Review URL: http://codereview.chromium.org/17320
------------------------------------------------------------------------
r7873 | sidchat@google.com | 2009-01-12 19:54:11 +0100 (Mon, 12 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Part 3 of 'Add common words for each language, and remove forbidden words'

Update spellchecker to use version 1.2 dictionaries for 19 languages.

Issue=2837
Review URL: http://codereview.chromium.org/17337
------------------------------------------------------------------------
r7871 | pkasting@chromium.org | 2009-01-12 19:51:58 +0100 (Mon, 12 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

No user-visible change.  Minor code cleanup I split out from the OTR fixes I'm looking at; mostly just making code shorter.  I tried not to remove temps where they added significant clarity, e.g. where they prevented nested ?: operators.  A few cases like LayoutOTRAvatar() are kinda gross-looking, partly because the final version of those will be a bit simpler.
Review URL: http://codereview.chromium.org/17614
------------------------------------------------------------------------
r7864 | phajdan.jr@chromium.org | 2009-01-12 13:56:20 +0100 (Mon, 12 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/renderer/net/render_dns_queue_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Add more tests to unit_tests on Linux, and some platform cleanups.

Review URL: http://codereview.chromium.org/17277
------------------------------------------------------------------------
r7857 | mad@chromium.org | 2009-01-11 04:15:38 +0100 (Sun, 11 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_shelf_view.cc

Fixes 6007 (download shelf won't close) by moving the call to show the download shelf from 
AddDownload to AddDownload View...


------------------------------------------------------------------------
r7856 | sgk@google.com | 2009-01-10 23:22:33 +0100 (Sat, 10 Jan 2009) | 26 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/base_sln.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/debug_message.scons
   M /trunk/src/base/gfx/base_gfx.scons
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/chrome_sln.scons
   M /trunk/src/net/crash_cache.scons
   M /trunk/src/net/dump_cache.scons
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_perftests.scons
   M /trunk/src/net/net_resources.scons
   M /trunk/src/net/net_sln.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/stress_cache.scons
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.scons
   M /trunk/src/sandbox/sandbox_sln.scons
   M /trunk/src/site_scons/site_tools/_Node_MSVS.py
   M /trunk/src/site_scons/site_tools/chromium_builders.py
   M /trunk/src/skia/SConscript
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/third_party/libpng/libpng.scons
   M /trunk/src/third_party/sqlite/SConscript
   M /trunk/src/third_party/zlib/zlib.scons
   M /trunk/src/webkit/activex_shim_dll/SConscript
   M /trunk/src/webkit/webkit_sln.scons

Updates to Visual Studio project generation to accomodate
recent changes and get rid of cut-and-paste:

* Add generation of the new net_resource.vcproj file.
* Accomodate the net\net.vsprops file.
* New base.vcproj dependency in activex_shim_dll.vcproj.
* New tld_cleanup.vcproj dependency in net.vcproj.
* New ondemand_updates.vcproj dependencies in
  gcapi_{dll,lib}.vcproj.
* Re-order dump_cache.vcproj dependencies to match new
  checked-in solutions.
* New input file directory layout in zlib (minizip folder)
  and testing\gtest (hierarchy).
* Use a new dest= argument to ChromeMSVSSolution()
  and ChromeMSVSProject() to get rid of cut-and-pste
  installation code, and provide a central point for
  controlling when/whether we want to generate the files
  only under the build directory, or drop them in place
  for checking in.
* Comment out an unnecessarily verbose warning if the
  buildtarget is executed with an action that we don't
  map to specific Visual Studio settings.  Sometimes
  this is normal and okay, but the warning should get
  restored at some point when we work out the precise
  conditions under which it makes sense.
Review URL: http://codereview.chromium.org/17602
------------------------------------------------------------------------
r7841 | aa@chromium.org | 2009-01-09 23:14:27 +0100 (Fri, 09 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols.cc
   M /trunk/src/chrome/browser/extensions/extension_protocols_unittest.cc

Move Contains() method to file_utils, stop relying on in extensions_protocol

Review URL: http://codereview.chromium.org/16805
------------------------------------------------------------------------
r7836 | aa@chromium.org | 2009-01-09 22:30:28 +0100 (Fri, 09 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/extensions/extension_protocol.cc
   D /trunk/src/chrome/browser/extensions/extension_protocol.h
   D /trunk/src/chrome/browser/extensions/extension_protocol_unittest.cc
   A /trunk/src/chrome/browser/extensions/extension_protocols.cc (from /trunk/src/chrome/browser/extensions/extension_protocol.cc:7827)
   A /trunk/src/chrome/browser/extensions/extension_protocols.h (from /trunk/src/chrome/browser/extensions/extension_protocol.h:7827)
   A /trunk/src/chrome/browser/extensions/extension_protocols_unittest.cc (from /trunk/src/chrome/browser/extensions/extension_protocol_unittest.cc:7827)
   M /trunk/src/chrome/test/unit/unittests.vcproj

Rename extension_protocol* to extension_protocols*

Review URL: http://codereview.chromium.org/17433
------------------------------------------------------------------------
r7827 | aa@chromium.org | 2009-01-09 21:37:35 +0100 (Fri, 09 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions/user_script_master.cc (from /trunk/src/chrome/browser/greasemonkey_master.cc:7826)
   A /trunk/src/chrome/browser/extensions/user_script_master.h (from /trunk/src/chrome/browser/greasemonkey_master.h:7826)
   A /trunk/src/chrome/browser/extensions/user_script_master_unittest.cc (from /trunk/src/chrome/browser/greasemonkey_master_unittest.cc:7826)
   D /trunk/src/chrome/browser/greasemonkey_master.cc
   D /trunk/src/chrome/browser/greasemonkey_master.h
   D /trunk/src/chrome/browser/greasemonkey_master_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/renderer/greasemonkey_slave.cc
   D /trunk/src/chrome/renderer/greasemonkey_slave.h
   D /trunk/src/chrome/renderer/greasemonkey_slave_unittest.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/renderer/user_script_slave.cc (from /trunk/src/chrome/renderer/greasemonkey_slave.cc:7826)
   A /trunk/src/chrome/renderer/user_script_slave.h (from /trunk/src/chrome/renderer/greasemonkey_slave.h:7826)
   A /trunk/src/chrome/renderer/user_script_slave_unittest.cc (from /trunk/src/chrome/renderer/greasemonkey_slave_unittest.cc:7826)
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

This is a rename of the term 'Greasemonkey' to 'user script' in Chromium.
I'm doing this to avoid confusion with the Firefox version of Greasemonkey and
also because 'user script' is really the correct generic term.

At the same time, I also moved user_script_master* into extensions/ because I want these two pieces to get closer and closer such that standalone user scripts are just a very small extension. Also extensions will be relying on most of the user script code.

Review URL: http://codereview.chromium.org/17281
------------------------------------------------------------------------
r7825 | pinkerton@google.com | 2009-01-09 21:28:44 +0100 (Fri, 09 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   A /trunk/src/chrome/app/scoped_ole_initializer.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/main_function_params.h
   A /trunk/src/chrome/common/sandbox_init_wrapper.cc
   A /trunk/src/chrome/common/sandbox_init_wrapper.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/sandbox/src/sandbox.h

remove chrome dependencies from win sandboxing headers. Wrap sandbox code to
make the main routine a little cleaner. Unify the parameters of each of the "main" entry points so we can more easily abstract platform differences in the future. BUG=5323
Review URL: http://codereview.chromium.org/17426
------------------------------------------------------------------------
r7824 | paulg@google.com | 2009-01-09 21:23:49 +0100 (Fri, 09 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

More ui_test purification. The extra timeout seems to
avoid the testserver.py stalling issue.
Review URL: http://codereview.chromium.org/17305
------------------------------------------------------------------------
r7823 | jcampan@chromium.org | 2009-01-09 21:21:11 +0100 (Fri, 09 Jan 2009) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/web_contents_view.cc
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/mock_render_thread.cc
   M /trunk/src/chrome/renderer/mock_render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

The popup for autofill is now never activated, even when clicked.
This allows us to hide it when the page loses focus.
(doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer).

Most of the file changes are just renaming focus_on_show to activatable.

TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well.
BUG=3844,5830
Review URL: http://codereview.chromium.org/17455
------------------------------------------------------------------------
r7804 | tim@chromium.org | 2009-01-09 17:50:14 +0100 (Fri, 09 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc

HtmlDialogView is hard-wired to the gears application shortcut dialogs but it doesn't have to be. The delegates don't need to be strictly gears either, but for now they are only used by gears and this simple change allows re-use of HtmlDialogView + HtmlDialogContents + HtmlDialogContentsDelegate.
Review URL: http://codereview.chromium.org/17441
------------------------------------------------------------------------
r7798 | ananta@chromium.org | 2009-01-09 02:20:38 +0100 (Fri, 09 Jan 2009) | 40 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webcursor.cc
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webcursor_gtk.cc
   M /trunk/src/webkit/glue/webcursor_mac.mm
   M /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Add support for custom cursors set by windowless plugins. Windowless plugins typically set the cursor in NPP_HandleEvent for WM_MOUSEMOVE.The current implementation looks for the cursor type and if the typedoes not match predefinedcursor types defaults to the pointer cursor.

The fixes are as below:-
1. Marshal the HCURSOR after copying it to ensure that it  
   remains valid. This works as a HCURSOR is a user object  
   and can be used across processes. Ideally we would 
   like  to convert it to a skia bitmap but there are issues 
   with converting monochrome cursors.

2. Added support for marshaling platform specific data in  
   the webcursor Serialize/Deserialize functions. This is in  
   the form of functions like InitPlatformData,  
   SerializePlatformData, DeserializePlatformData, etc.  
   which are stubbed out for the other platforms.

3. Mimic webkit windowless plugin behavior where it sets a  
   flag to ignore the next setCursor after HandleEvent of  
   WM_MOUSEMOVE. If  we don't do this the cursor keeps  
   changing between a pointerCursor and the cursor set by  
   the plugin which also causes flicker.

4. Fixed the WebCursor::IsEqual function to ensure that it  
   checks all fields for equality.

5. The browser(RenderWidgetHostViewWin) now maintains a 
   WebCursor instance representing the current cursor. Any 
   cursor updates received from the renderer update the 
   current cursor member maintained by the browser.

6. We intercept the SetCursor API for windowless plugins 
   like Flash and Silverlight and remember the cursor being 
   set. We don't invoke the original API as the browser UI 
   thread would do it anyways. This fixes the annoying 
   cursor flicker caused by the windowless flash plugin 
   instance constantly setting the cursor even when the tab
   is not visible.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=3800.

Review URL: http://codereview.chromium.org/15088
------------------------------------------------------------------------
r7792 | ananta@chromium.org | 2009-01-09 01:44:32 +0100 (Fri, 09 Jan 2009) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Make sure that the active tab contents is destroyed when navigating back from the tab contents to the downloads page. This is a special case as the current code in the navigation controller only schedules a tab contents for destroy when the tab contents displayed last is different from the active tab contents. When we navigate away from a webcontents to the Downloads page which is a native UI tab contents, 
we check for whether the last displayed tab contents type differs from the active type. They both match as the back operation is yet to be initiated. 

Eventually the active tab contents change to the download page. We don't clean up the previous tab contents fully thus resulting in the renderer process continuing to run.

This fixes http://code.google.com/p/chromium/issues/detail?id=5828

R=jcampan

Review URL: http://codereview.chromium.org/17258
------------------------------------------------------------------------
r7762 | tc@google.com | 2009-01-08 22:58:04 +0100 (Thu, 08 Jan 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/debugger/debugger_disabled.vsprops
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   A /trunk/src/net/base/net_resources.grd
   D /trunk/src/net/base/net_resources.h
   D /trunk/src/net/base/net_resources.rc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/registry_controlled_domain.cc
   M /trunk/src/net/build/convert_tld_data.rules
   M /trunk/src/net/build/net.vcproj
   A /trunk/src/net/build/net_resources.vcproj
   M /trunk/src/net/net.sln
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_resources.scons
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.scons
   M /trunk/src/webkit/build/localized_strings/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript
   M /trunk/src/webkit/tools/test_shell/test_shell.vcproj
   M /trunk/src/webkit/tools/test_shell/test_shell_tests.vcproj
   M /trunk/src/webkit/webkit.sln
   M /trunk/src/webkit/webkit_armu.sln
   M /trunk/src/webkit/webkit_kjs.sln

Remove net_resources.rc and net_resources.h and replace it
with a grd file that generates the same thing.  We want to do
this so on linux, we will have grit generate the .h file and
a platform specific resource file.

There's some munging going on to be able to get the
effective_tld_names_clean.dat file included in the rc.

This works in visual studio and scons.  I need to update
chrome_kjs.sln and the webkit*.sln files and the mac build before committing.

Review URL: http://codereview.chromium.org/16565
------------------------------------------------------------------------
r7759 | aa@chromium.org | 2009-01-08 22:47:41 +0100 (Thu, 08 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/extensions/extension_protocol.cc
   M /trunk/src/chrome/browser/extensions/extension_protocol.h
   M /trunk/src/chrome/browser/greasemonkey_master.h
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h

Add chrome-user-script:// protocol

This is a step towards getting user scripts working in extensions. It's a bit
janky to use the form chrome-user-script://<script file>/ (with no path), but
GURL assumes that there is always a host, but path is optional, making this
approach simpler than alternatives.

Review URL: http://codereview.chromium.org/16592
------------------------------------------------------------------------
r7755 | erikkay@google.com | 2009-01-08 21:45:27 +0100 (Thu, 08 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/view_source_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/net/cache_uitest.cc
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/mimetype_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/unittest_test_server.h

Add FTP unit test in preparation for portable FTP implementation.
Clean up test server code.

Originally from issue 12939, written by Ibrar Ahmed (ibrar.ahmed@gmail.com)

(take 2)

Review URL: http://codereview.chromium.org/17040
------------------------------------------------------------------------
r7747 | pkasting@chromium.org | 2009-01-08 19:57:45 +0100 (Thu, 08 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc

Fixup and verify URLs from the server before adding them to the autocomplete dropdown.

Original patch by Brian Duff, r=me (see http://codereview.chromium.org/16503 ), tweaked some.

BUG=5806
------------------------------------------------------------------------
r7742 | dimich@google.com | 2009-01-08 19:09:44 +0100 (Thu, 08 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc

Re-enable ui test after WebKit merge which pulled the fix from upstream.
Review URL: http://codereview.chromium.org/17259
------------------------------------------------------------------------
r7727 | phajdan.jr@chromium.org | 2009-01-08 15:27:23 +0100 (Thu, 08 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc

Fix broken browser_views on Windows.

TBR=maruel, deanm
Review URL: http://codereview.chromium.org/17417
------------------------------------------------------------------------
r7725 | phajdan.jr@chromium.org | 2009-01-08 13:07:23 +0100 (Thu, 08 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/provisional_load_details.cc
   M /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Porting in chrome/ (add 6 files to Linux SCons build)

Review URL: http://codereview.chromium.org/17052
------------------------------------------------------------------------
r7711 | paulg@google.com | 2009-01-08 02:32:15 +0100 (Thu, 08 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc

Fix linux / mac build.
Review URL: http://codereview.chromium.org/17256
------------------------------------------------------------------------
r7710 | paulg@google.com | 2009-01-08 02:22:30 +0100 (Thu, 08 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Ignore GetHash results for lists that we don't support.

BUG=5597 (http://crbug.com/5597)
Review URL: http://codereview.chromium.org/16595
------------------------------------------------------------------------
r7703 | jcampan@chromium.org | 2009-01-08 01:13:45 +0100 (Thu, 08 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/web_contents.h

Attempt at fixing bug 5800.
When pressing back on an interstitial with a cross site navigation pending, we should cancel the pending without running the unload handler on the previous page.

BUG=5800
TEST=See bug.
Review URL: http://codereview.chromium.org/17061
------------------------------------------------------------------------
r7689 | cpu@google.com | 2009-01-07 23:30:09 +0100 (Wed, 07 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h

Clear the refferer registry entry upon succesful ping
- Is not needed after that point

BUG = 1517308


Review URL: http://codereview.chromium.org/16552
------------------------------------------------------------------------
r7688 | aa@chromium.org | 2009-01-07 23:29:23 +0100 (Wed, 07 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/greasemonkey_master.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Move user script directory into profile.

Review URL: http://codereview.chromium.org/17242
------------------------------------------------------------------------
r7687 | aa@chromium.org | 2009-01-07 23:19:50 +0100 (Wed, 07 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/base/directory_watcher_unittest.cc
   M /trunk/src/base/directory_watcher_win.cc
   M /trunk/src/chrome/browser/greasemonkey_master.cc

Don't DCHECK if a watched directory doesn't exist.
The caller can't easily check whether a directory exists before calling this
functions. Also modify GreasemonkeyMaster to allow this condition.

Review URL: http://codereview.chromium.org/16580
------------------------------------------------------------------------
r7683 | tc@google.com | 2009-01-07 22:43:20 +0100 (Wed, 07 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   A /trunk/src/chrome/test/data/save_page/c.htm

Add a UI test to make sure we sanitize the filename
of files saved using the "Save page as..." menu item.

This involves adding a new automation provider method
for disabling the dialog prompting for a filename.

Review URL: http://codereview.chromium.org/16555
------------------------------------------------------------------------
r7671 | pinkerton@google.com | 2009-01-07 19:40:46 +0100 (Wed, 07 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/template_url.cc
   A /trunk/src/chrome/chrome.xcodeproj/browser_prebuild.sh
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Integrate grit into mac build. Add more files that are building in scons to the xcode project
Review URL: http://codereview.chromium.org/17237
------------------------------------------------------------------------
r7664 | finnur@google.com | 2009-01-07 19:10:33 +0100 (Wed, 07 Jan 2009) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/chrome/browser/url_fixer_upper_unittest.cc

Checking in patch for Brian Duff, reviewed by pkasting (http://codereview.chromium.org/16511)

If the URL text has no scheme, and starts with ftp., then 
default the scheme to ftp: instead of http:. Fixes issue 565.

BUG=565


------------------------------------------------------------------------
r7644 | jcampan@chromium.org | 2009-01-07 02:30:58 +0100 (Wed, 07 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_manager.cc

In some cases (related to window.open() with no contents, see bug for more details) we may get notified of SSL error or mixed-contents without a NavigationEntry.
This CL ensures we don't crash in that case.

BUG=3845
TEST=See bug.
Review URL: http://codereview.chromium.org/17218
------------------------------------------------------------------------
r7630 | estade@chromium.org | 2009-01-07 00:31:41 +0100 (Wed, 07 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/common/win_safe_util.cc
   M /trunk/src/chrome/common/win_safe_util.h
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Convert download manager to FilePath.

(Fixed up version of issue 17032. Now passes all unit tests.)

Review URL: http://codereview.chromium.org/16533
------------------------------------------------------------------------
r7622 | paulg@google.com | 2009-01-06 23:17:57 +0100 (Tue, 06 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h

Add histograms to track the size of SafeBrowsing Updates.
We will now measure:
  - the number of chunk URLs in an update
  - the size of each chunk URL
  - the total size of an update

Review URL: http://codereview.chromium.org/17213
------------------------------------------------------------------------
r7620 | klink@chromium.org | 2009-01-06 22:54:40 +0100 (Tue, 06 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Enables restoring of keyboard focus to the the toolbar button that last had focus, before focus was lost (e.g to a dialog, another window, etc). Setting focus using the toolbar focus keyboard shortcut will still reset focus to the first enabled, visible button (starting at the Back button).

BUG=5750

Review URL: http://codereview.chromium.org/15098
------------------------------------------------------------------------
r7617 | avi@google.com | 2009-01-06 22:39:04 +0100 (Tue, 06 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/webkit/glue/plugins/nphostapi.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc

Change "dll" to "plugin" where appropriate.

Review URL: http://codereview.chromium.org/16543
------------------------------------------------------------------------
r7615 | finnur@google.com | 2009-01-06 22:29:26 +0100 (Tue, 06 Jan 2009) | 24 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Applying patch for Mohamed Mansour (reviewed by pkasting): http://codereview.chromium.org/16246

CRASH at Tab::OnMouseReleased

Some strange thing is happening that it crashes for view::HitTest, it can never
ENTER that function. It seems that the tab is being destroyed and as pkasting
stated on IRC: 
"Part of this may be because our retarded Views designs can't distinguish which
buttons are being held versus clicked in these sorts of cases (I filed a bug on
this about a year and a half ago, internally)"

When a tab has ended dragging (EndDrag), if something was being dragged and you
end it, it actually cleans the TabDelegate and assigns its value to 'freed
memory' which is 0xfeeefeee. Therefore it crashes while dragging, because the
object no longer exists. I couldn't do if (delegate_) cause that always returns
true since delegate has 0xfeeefeee. 

So I just changed the return type from void to bool for underlying EndDragImpl
and pumped it to tab.cc. That way, we can know if a tab is destroyed or not.

BUG=5819 (http://crbug.com/5819)

TEST=Dragging tabs around, closing while dragging, and closing tabs.

------------------------------------------------------------------------
r7605 | paulg@google.com | 2009-01-06 21:30:44 +0100 (Tue, 06 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc

Make browser_uitest more Purify friendly.
Review URL: http://codereview.chromium.org/16544
------------------------------------------------------------------------
r7600 | tc@google.com | 2009-01-06 20:48:35 +0100 (Tue, 06 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

clean up safe browsing pref registration by following the
naming convention of other Local State register prefs methods.

Review URL: http://codereview.chromium.org/17207
------------------------------------------------------------------------
r7599 | jar@google.com | 2009-01-06 20:37:40 +0100 (Tue, 06 Jan 2009) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_log.h
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h

(Correctly) acquire real-time UMA stats for aggregation

Properly nest XML so existing back-end code can grok the data.
Include plugin crash stats as well.

Correct bug where default time for interlog transmission is set (in case
the server does not provide a value).

bug=1564631

r=evanm,hunar
Review URL: http://codereview.chromium.org/17068
------------------------------------------------------------------------
r7595 | tc@google.com | 2009-01-06 20:04:39 +0100 (Tue, 06 Jan 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/web_contents.cc

Prevent files saved via the "Save as..." page menu item from
being named maliciously.  This is mainly copying some code from
the download manager because it seems like a pretty large task to
refactor the save-as code right now.

Here's a demo page:
http://ponderer.org/tests/title-with-.exe.html

Clean up the naming convention of register prefs for the
safe browsing service to make it more like the other
register methods.

Review URL: http://codereview.chromium.org/16523
------------------------------------------------------------------------
r7590 | jeremy@chromium.org | 2009-01-06 18:39:36 +0100 (Tue, 06 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/common/page_transition_types.h

Turn on GetVisibleVisitsInRange test on POSIX.

Review URL: http://codereview.chromium.org/16524
------------------------------------------------------------------------
r7589 | brettw@chromium.org | 2009-01-06 17:58:03 +0100 (Tue, 06 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h

This is a redo of my previous notification registrar change. I saw a crash in handling NAV_ENTRY_COMMITTED, so am changing all consumers of this to use the registrar so that it is impossible to forget to unregister.

The difference is that in tab_contents I moved the removal code in RemoveInfoBar to only remove the listener if an infobar was actually removed.
Review URL: http://codereview.chromium.org/16534
------------------------------------------------------------------------
r7588 | avi@google.com | 2009-01-06 17:48:45 +0100 (Tue, 06 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_info.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_process.cc
   M /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_delegate.h

Move plugins to FilePaths, some cleanup

Review URL: http://codereview.chromium.org/16456
------------------------------------------------------------------------
r7583 | tc@google.com | 2009-01-06 06:44:01 +0100 (Tue, 06 Jan 2009) | 7 lines
Changed paths:
   M /trunk/src/build/SConscript.main
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/renderer/renderer.scons
   A /trunk/src/tools/grit/build/using_generated_resources.scons

Add using_generated_resources.scons to the build.  This
is the same as using_generated_resources.vsprops.
Replace existing paths with this scons file if the SConscript
file has already been converted to the using_ format.

Review URL: http://codereview.chromium.org/14902

------------------------------------------------------------------------
r7582 | brettw@chromium.org | 2009-01-06 05:50:52 +0100 (Tue, 06 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h

Reverting 7581.
Review URL: http://codereview.chromium.org/17069
------------------------------------------------------------------------
r7581 | brettw@chromium.org | 2009-01-06 05:27:05 +0100 (Tue, 06 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/sessions/session_service.cc
   M /trunk/src/chrome/browser/sessions/session_service.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h

Change all classes that use the NOTIFY_NAV_ENTRY_COMMITTED notification to use the notification registrar. This is a speculative fix for a crash I happened to catch in a debugger where the pointer was invalid when dispatching this notifcation. It could be one of these consumers is leaking it's registered observer (the TabContents is the most suspicious one).
Review URL: http://codereview.chromium.org/16519
------------------------------------------------------------------------
r7577 | kuchhal@chromium.org | 2009-01-06 04:02:08 +0100 (Tue, 06 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc

* Disable test that seems to have been broken by r7570\

TBR=dglazkov
BUG=6030

Review URL: http://codereview.chromium.org/16530
------------------------------------------------------------------------
r7575 | maruel@chromium.org | 2009-01-06 03:55:12 +0100 (Tue, 06 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Reverting 7574 which reverted 7570. It was an error on my part.
Review URL: http://codereview.chromium.org/16529
------------------------------------------------------------------------
r7574 | maruel@chromium.org | 2009-01-06 03:29:45 +0100 (Tue, 06 Jan 2009) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Reverting 7570.
Review URL: http://codereview.chromium.org/16528
------------------------------------------------------------------------
r7572 | estade@chromium.org | 2009-01-06 00:59:36 +0100 (Tue, 06 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc

Keep trying to undo 7564.

tbr=jhawkins

Review URL: http://codereview.chromium.org/17062
------------------------------------------------------------------------
r7571 | estade@chromium.org | 2009-01-06 00:36:01 +0100 (Tue, 06 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_path_unittest.cc
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc

Unbreak unit tests. Revert r7564.

tbr=jhawkins

Review URL: http://codereview.chromium.org/16522
------------------------------------------------------------------------
r7570 | jeremy@chromium.org | 2009-01-06 00:20:02 +0100 (Tue, 06 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

* Port l10n_utiL and it's unit test on POSIX.
* Bringup visit_database_unittest.cc on POSIX

Review URL: http://codereview.chromium.org/17025
------------------------------------------------------------------------
r7564 | estade@chromium.org | 2009-01-05 23:36:56 +0100 (Mon, 05 Jan 2009) | 5 lines
Changed paths:
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc

* switch download manager to using FilePath
* add empty() function to FilePath
* implement file_util::GetFileExtensionFromPath

Review URL: http://codereview.chromium.org/17032
------------------------------------------------------------------------
r7563 | finnur@google.com | 2009-01-05 23:35:54 +0100 (Mon, 05 Jan 2009) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc


Checking in a patch from m0interactive, reviewed by pkasting. Quote:

Ctrl+U should show up view-source on Application shortcuts.
According to pkasting in dev mailing list:

"Ctrl-U for an application should do what the context menu 
option does: open a source tab in some normal window."

Hence, made it a NEW_FOREGROUND_TAB for disposition

BUG=http://crbug.com/5115

------------------------------------------------------------------------
r7560 | tc@google.com | 2009-01-05 22:58:01 +0100 (Mon, 05 Jan 2009) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_binaries.vsprops
   M /trunk/src/chrome/app/generated_resources.vcproj
   M /trunk/src/chrome/browser/browser.vsprops
   M /trunk/src/chrome/browser/debugger/debugger.vsprops
   M /trunk/src/chrome/common/common.vsprops
   M /trunk/src/chrome/renderer/renderer.vsprops
   M /trunk/src/chrome/tools/build/win/unit_test.vsprops
   D /trunk/src/chrome/tools/build/win/using_generated_strings.vsprops
   M /trunk/src/chrome/views/views.vsprops
   A /trunk/src/tools/grit/build/grit_localized_resources.rules (from /trunk/src/tools/grit/build/grit_resource_file.rules:7559)
   D /trunk/src/tools/grit/build/grit_resource_file.rules
   A /trunk/src/tools/grit/build/grit_resources.rules
   A /trunk/src/tools/grit/build/using_generated_resources.vsprops (from /trunk/src/chrome/tools/build/win/using_generated_strings.vsprops:7559)
   M /trunk/src/webkit/build/glue/glue.vsprops
   M /trunk/src/webkit/build/localized_strings/localized_strings.vcproj
   M /trunk/src/webkit/default_plugin/default_plugin.vsprops
   M /trunk/src/webkit/tools/test_shell/test_shell.vsprops

Some more GRIT refactoring.

Moved the grit .vsprops file from chrome/tools/build/win/ to
/tools/grit/build and renamed to using_generated_resources.vsprops.
Updated non-chrome projects to use the this new vsprops file.

Created a new .rules file and renamed the old one.  Now there are
grit_resources.rules and grit_localized_resources.rules.  The latter
is what we use now, but I'll be adding some grd files that use the
former in a follow up change.

This is just vsprops reshuffling for now.  I'll also add a
using_generated_resources.scons in a follow up change.

Review URL: http://codereview.chromium.org/14901
------------------------------------------------------------------------
r7550 | jungshik@google.com | 2009-01-05 20:32:50 +0100 (Mon, 05 Jan 2009) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Add the home page url of the ICU project to the credit file. 


Review URL: http://codereview.chromium.org/14180
------------------------------------------------------------------------
r7546 | phajdan.jr@chromium.org | 2009-01-05 19:19:23 +0100 (Mon, 05 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/webkit/build/WebCore/SConscript

Windows SCons build fixes.

Review URL: http://codereview.chromium.org/17054
------------------------------------------------------------------------
r7540 | phajdan.jr@chromium.org | 2009-01-03 20:48:58 +0100 (Sat, 03 Jan 2009) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Fix part of linking problems in Windows SCons build.

Review URL: http://codereview.chromium.org/17049
------------------------------------------------------------------------
r7539 | phajdan.jr@chromium.org | 2009-01-03 15:50:51 +0100 (Sat, 03 Jan 2009) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h

g++ 4.3.x doesn't seem to like forward declarations
with namespace::classname so declare the forward
declaration inside the appropriate namespace.

Review URL: http://codereview.chromium.org/16508
Patch from Craig Schlenter.
------------------------------------------------------------------------
r7529 | phajdan.jr@chromium.org | 2008-12-31 12:58:24 +0100 (Wed, 31 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   M /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h

Porting in chrome/

Review URL: http://codereview.chromium.org/17016
------------------------------------------------------------------------
r7524 | hclam@chromium.org | 2008-12-31 03:08:33 +0100 (Wed, 31 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Bug fix issue 4669 (http://code.google.com/p/chromium/issues/detail?id=4669)
When doing a view source action and then go to other address and back to view source page. Forward addresses become backward addresses.
The reason is that every view source page is treated as a standard load because content_state() is always empty. The content state should be filled in SetContentStateIfEmpty()

Review URL: http://codereview.chromium.org/16221
------------------------------------------------------------------------
r7514 | nsylvain@chromium.org | 2008-12-31 00:29:54 +0100 (Wed, 31 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/view_source_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/net/cache_uitest.cc
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/mimetype_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/unittest_test_server.h

Revert 7508.7509 and 7510
Review URL: http://codereview.chromium.org/17030
------------------------------------------------------------------------
r7508 | erikkay@google.com | 2008-12-30 22:49:21 +0100 (Tue, 30 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/view_source_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/net/cache_uitest.cc
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/mimetype_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/unittest_test_server.h

Add FTP unit test in preparation for portable FTP implementation.
Clean up test server code.

Originally from issue 12939, written by Ibrar Ahmed (ibrar.ahmed@gmail.com)


Review URL: http://codereview.chromium.org/16490
------------------------------------------------------------------------
r7503 | jar@google.com | 2008-12-30 21:50:01 +0100 (Tue, 30 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/base/tracked_objects.h
   M /trunk/src/chrome/browser/browser_main.cc

Provide and use auto startup/teardown for tracked objects

Avoid races with message loop teardown


r=nsylvain
Review URL: http://codereview.chromium.org/17023
------------------------------------------------------------------------
r7499 | phajdan.jr@chromium.org | 2008-12-30 14:13:34 +0100 (Tue, 30 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/string_util.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.cc
   M /trunk/src/net/base/cookie_monster.cc

Remove compatibility #defines in string_util.h

Review URL: http://codereview.chromium.org/17014
------------------------------------------------------------------------
r7496 | xji@chromium.org | 2008-12-30 02:02:18 +0100 (Tue, 30 Dec 2008) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Enable Hebrew spell checker after Jeremy fixed the underlying Webkit bug.

Related bug: http://code.google.com/p/chromium/issues/detail?id=2779
Related Webkit fix: http://trac.webkit.org/changeset/36874

Test:
Steps to repro:
1) open chrome, Hebrew UI
2) make sure the spell checker is on, and is set to Hebrew
3) type some Hebrew text in a RTL box (like RTL plain text finto), and use a
Hebrew word that the speller does not know.
4) type some more


Without the underlying Webkit fix:
the highlight marker is in a wrong location, and keeps moving while typing more
words after the unrecognized one.

With the underlying Webkit fix:
the highlight marker is in a correct and fixed location.

Review URL: http://codereview.chromium.org/16606
------------------------------------------------------------------------
r7486 | aa@chromium.org | 2008-12-29 20:59:08 +0100 (Mon, 29 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_reader.h
   M /trunk/src/base/json_reader_unittest.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   M /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/common/json_value_serializer.cc
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/json_value_serializer_perftest.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Change the signature of JSONReader::Read() and related
methods to be more friendly to use with scoped_ptr. Change
all the callsites.

Review URL: http://codereview.chromium.org/16270
------------------------------------------------------------------------
r7480 | evanm@google.com | 2008-12-26 05:40:58 +0100 (Fri, 26 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Blind attempt at a fix for the Windows SCons build.
I didn't break it, but it'd be useful for verifying my other changes
didn't break things if the Windows SCons build were green.

------------------------------------------------------------------------
r7479 | evanm@google.com | 2008-12-26 05:38:25 +0100 (Fri, 26 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/gfx/base_gfx.scons
   M /trunk/src/breakpad/SConscript
   M /trunk/src/build/SConscript.main
   M /trunk/src/build/SConscript.v8
   M /trunk/src/build/googleurl_lib.scons
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/installer/util/util.scons
   M /trunk/src/chrome/plugin/plugin.scons
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/test/automation/automation.scons
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/gears/SConscript
   M /trunk/src/gears/SConscript.browser
   M /trunk/src/media/media_lib.scons
   M /trunk/src/net/net_lib.scons
   M /trunk/src/sandbox/src/sandbox_lib.scons
   M /trunk/src/sdch/SConscript
   M /trunk/src/skia/SConscript
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/third_party/bspatch/bspatch.scons
   M /trunk/src/third_party/bzip2/bzip2.scons
   M /trunk/src/third_party/libevent/libevent.scons
   M /trunk/src/third_party/libjpeg/libjpeg.scons
   M /trunk/src/third_party/libpng/libpng.scons
   M /trunk/src/third_party/libxml/libxml.scons
   M /trunk/src/third_party/libxslt/libxslt.scons
   M /trunk/src/third_party/lzma_sdk/lzma_sdk.scons
   M /trunk/src/third_party/modp_b64/modp_b64.scons
   M /trunk/src/third_party/sqlite/SConscript
   M /trunk/src/third_party/zlib/zlib.scons
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/activex_shim/SConscript
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/V8Bindings/SConscript
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/default_plugin/SConscript
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript

Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the updated ICU dep that uses it as well.
Add a SHARED scons command-line flag to build shared libraries.

Review URL: http://codereview.chromium.org/16477

------------------------------------------------------------------------
r7462 | aa@chromium.org | 2008-12-24 01:21:26 +0100 (Wed, 24 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   A /trunk/src/chrome/browser/extensions/extension_protocol.cc
   A /trunk/src/chrome/browser/extensions/extension_protocol.h
   A /trunk/src/chrome/browser/extensions/extension_protocol_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/greasemonkey_master.cc
   M /trunk/src/chrome/browser/greasemonkey_master_unittest.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   M /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Implement extension:// protocol.

Review URL: http://codereview.chromium.org/15010
------------------------------------------------------------------------
r7448 | aa@chromium.org | 2008-12-23 23:34:50 +0100 (Tue, 23 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/net/chrome_url_request_context.cc
   A /trunk/src/chrome/browser/net/chrome_url_request_context.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/net/url_request/url_request_context.h

Refactor the two URLRequestContext subclasses in profile.cc into a new shared
ChromeRequestContext class. This will allow us to put browser-specific request
context here rather than in URLRequestContext and eliminates a lot of
duplicate code.

I looked at having two different classes using either inheritance (as proposed
by the existing TODO) or composition, but it seems like there isn't enough
difference between these two classes to justify it.

Removed is_off_the_record() because it wasn't being used anywhere and did a
few other minor code cleanup things.

Review URL: http://codereview.chromium.org/16408
------------------------------------------------------------------------
r7432 | jeremy@chromium.org | 2008-12-23 21:30:19 +0100 (Tue, 23 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/unit/unit_tests.scons

* Bring up GreaseMonkeySlave unittest on OS X.
* Fix missing Autoreleasepool warning in SafeBrowsing Unittest.

Review URL: http://codereview.chromium.org/16243
------------------------------------------------------------------------
r7412 | finnur@google.com | 2008-12-23 06:34:56 +0100 (Tue, 23 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Reverting my landing (of a patch by external contributer).
I jumped the gun, Peter raised additional issues after we
both LGTM'ed (and I didn't notice those emails).

TBR=pkasting
Review URL: http://codereview.chromium.org/16234
------------------------------------------------------------------------
r7408 | finnur@google.com | 2008-12-23 05:52:08 +0100 (Tue, 23 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Landing a patch for m0interactive (already in the AUTHORS list):

Ctrl+U should show up view-source on Application shortcuts.
According to pkasting in dev mailing list:

"Ctrl-U for an application should do what the context menu
option does: open a source tab in some normal window."

Hence, made it a NEW_FOREGROUND_TAB for disposition

TBR=pkasting
BUG=http://crbug.com/5115
Review URL: http://codereview.chromium.org/16233
------------------------------------------------------------------------
r7400 | jcampan@chromium.org | 2008-12-23 02:07:32 +0100 (Tue, 23 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/render_widget_helper.cc
   A /trunk/src/chrome/browser/renderer_host (from /trunk/src/chrome/browser/renderer_host:7337)
   D /trunk/src/chrome/browser/resource_dispatcher_host.cc
   D /trunk/src/chrome/browser/resource_dispatcher_host.h
   D /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc
   D /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/resource_request_details.h
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/tab_util.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/test/perf/perftests.vcproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

New attempt at landing the resource_dispatcher_host.cc splitting (broke the build on Friday).

TBR=darin
Review URL: http://codereview.chromium.org/15801
------------------------------------------------------------------------
r7391 | pkasting@chromium.org | 2008-12-23 00:18:37 +0100 (Tue, 23 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Make Maximized Mode Not Suck, part 1 (checkpoint).

Pixel perfection (I think) on Normal and App windows, maximized and restored, on Windows XP Luna with default fonts and border widths.  Among other things, fixes window control placement, tabstrip height, window icon/title placement, and client edge drawing (especially at the tops/bottoms of windows).

Known to still be broken: Popup windows
Untested: Vista non-Aero, Classic, non-default fonts/borders, non-main windows (Options, Task Manager, etc.)

This change is pretty hacky in some places; once I get the behavior nailed perfectly I'll need to go back and try and cut down on the number of constants and use better logic instead.  I do at least try to remove some of the current hacks or else document them.

Eventually I'll need Ben's and Glen's eyeballs for things, as I've had to make judgment calls about the correct behaviors; some of these I copied our 1.0 behavior, and some I've tried to ape a native app more closely.  Especially tricky are the positioning of window icons/titles, since our titlebar isn't quite like a native one.

BUG=5054
Review URL: http://codereview.chromium.org/16219
------------------------------------------------------------------------
r7384 | jcampan@chromium.org | 2008-12-22 23:24:14 +0100 (Mon, 22 Dec 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_unittest.cc

My Friday fix for some stack trashing introduced some heap trashing!
The tests create PageInterstitial objects which are self-owned (they delete themselves when hidden).
The tests test whether the PageInterstitial instance has been deleted by passing a local variable boolean to its constructor that the InterstitialPage sets to true when deleted.

In the stack trashing case, in one of the test the interstitial was deleted from the TearDown() method, so outside of the scope of the test. The interstitial was still accessing the local variable from the test scope, trashing the stack.
My previous fix introduced a state guard class allocated on the stack that would notify the InterstitialPage when deleted so it would clear any reference to the local vars, which fixed the stack trashing.
But this created a new problem: when the interstitial is deleted in the scope of the unit tests, the state guard object still holds a reference to the now deleted interstitial and calls a method on it when itself deleted.

This CL ensures the state guard class does not access any deleted interstitial.

BUG=5789


Review URL: http://codereview.chromium.org/16423
------------------------------------------------------------------------
r7355 | jcampan@chromium.org | 2008-12-22 19:01:39 +0100 (Mon, 22 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_unittest.cc


Review URL: http://codereview.chromium.org/16209
------------------------------------------------------------------------
r7345 | phajdan.jr@chromium.org | 2008-12-20 13:01:50 +0100 (Sat, 20 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.h

Attempt to fix Windows build.

Review URL: http://codereview.chromium.org/14920
------------------------------------------------------------------------
r7344 | phajdan.jr@chromium.org | 2008-12-20 12:51:23 +0100 (Sat, 20 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/net/dns_slave.h

Platform cleanup in chrome/browser/net.

Preparing for more complex changes.

Review URL: http://codereview.chromium.org/14919
------------------------------------------------------------------------
r7338 | jcampan@chromium.org | 2008-12-20 02:47:48 +0100 (Sat, 20 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/render_widget_helper.cc
   D /trunk/src/chrome/browser/renderer_host
   A /trunk/src/chrome/browser/resource_dispatcher_host.cc (from /trunk/src/chrome/browser/resource_dispatcher_host.cc:7335)
   A /trunk/src/chrome/browser/resource_dispatcher_host.h (from /trunk/src/chrome/browser/resource_dispatcher_host.h:7335)
   A /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc (from /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc:7335)
   A /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc (from /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc:7335)
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/resource_request_details.h
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/tab_util.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting my CL to fix build bustage.

TBR=maruel
Review URL: http://codereview.chromium.org/15099
------------------------------------------------------------------------
r7336 | jcampan@chromium.org | 2008-12-20 02:18:59 +0100 (Sat, 20 Dec 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/render_widget_helper.cc
   A /trunk/src/chrome/browser/renderer_host
   A /trunk/src/chrome/browser/renderer_host/async_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/async_resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/cross_site_resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/download_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/download_resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc (from /trunk/src/chrome/browser/resource_dispatcher_host.cc:6999)
   A /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h (from /trunk/src/chrome/browser/resource_dispatcher_host.h:6999)
   A /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc (from /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc:6999)
   A /trunk/src/chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc (from /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc:6999)
   A /trunk/src/chrome/browser/renderer_host/resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/save_file_resource_handler.h
   A /trunk/src/chrome/browser/renderer_host/sync_resource_handler.cc
   A /trunk/src/chrome/browser/renderer_host/sync_resource_handler.h
   D /trunk/src/chrome/browser/resource_dispatcher_host.cc
   D /trunk/src/chrome/browser/resource_dispatcher_host.h
   D /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc
   D /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/resource_request_details.h
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/tab_util.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

This CL moves the different resource handlers from resource_dispatcher_host.cc into their own files, into a new renderer_host directory.
Their is no functionality change in this CL.

The motivation for doing that was:
- resource_dispatcher_host.cc has become very long and more than 1/3 of the code is for the resource handler.
- having the resource handler in their own file allows having unit tests for them.

BUG=none
TEST=run all unit tests and UI tests.
Review URL: http://codereview.chromium.org/14487
------------------------------------------------------------------------
r7330 | jcampan@chromium.org | 2008-12-20 00:54:24 +0100 (Sat, 20 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_unittest.cc

The unit test WebContentsTest.ShowInterstitialProceedMultipleCommands was crashing.
This was caused by a class dereferencing a pointer to a local variable out of the scope of the local var, trashing the stack.

BUG=5700
TEST=Run the unit tests.
Review URL: http://codereview.chromium.org/14909
------------------------------------------------------------------------
r7322 | pkasting@chromium.org | 2008-12-19 23:07:01 +0100 (Fri, 19 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc

After staring at this line of code I realized it was saying something much simpler.
Review URL: http://codereview.chromium.org/14904
------------------------------------------------------------------------
r7308 | maruel@chromium.org | 2008-12-19 18:52:08 +0100 (Fri, 19 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Reverting 7304 to reapply 7296. It wasn't its fault.
Review URL: http://codereview.chromium.org/15083
------------------------------------------------------------------------
r7304 | maruel@chromium.org | 2008-12-19 17:35:09 +0100 (Fri, 19 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Reverting 7296.

From http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Reliability
There is a clear increase of crashes after this change. It really seems like a heap overflow but it's hard to tell. Reverting to see if it helps the reliability tests. If not, we can reapply this change and find another culprit.
Review URL: http://codereview.chromium.org/15081
------------------------------------------------------------------------
r7301 | sky@google.com | 2008-12-19 15:58:40 +0100 (Fri, 19 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/dock_info.h

Changes docking behavior to not offer a maximize drop target if there
is a maxmized tabbed browser on the monitor already. I don't feel this
is the right long term behavior, but until we figure that out I'm
going with this.

BUG=4878
TEST=maximize a tabbed browser, drag a tab out of the tabbed browser
  toward the top of the screen and make sure you aren't offered a
  dock target. Now restore the tabbed browser, drag a tab toward the
  top of the screen and make sure you are offered a maximized drop
  target.

Review URL: http://codereview.chromium.org/14858
------------------------------------------------------------------------
r7300 | sky@google.com | 2008-12-19 15:58:27 +0100 (Fri, 19 Dec 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes bug where we wouldn't necessarily start throbber timer on drop
of a tab if the page was loading. The fix is to call
LoadingStateChanged, which makes sure everything is in sync and the
timer is running (if necessary).

BUG=2524
TEST=Create two windows. In one of the windows load a page that takes
  a long time to load. Drag the tab into the first window and make sure
  when the tab snaps to the final position the throbber starts
  appropriately. 

Review URL: http://codereview.chromium.org/15056
------------------------------------------------------------------------
r7297 | sgk@google.com | 2008-12-19 09:10:30 +0100 (Fri, 19 Dec 2008) | 47 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/base.scons
   M /trunk/src/base/base_lib.scons
   A /trunk/src/base/base_sln.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/debug_message.scons
   M /trunk/src/base/gfx/base_gfx.scons
   M /trunk/src/breakpad/SConscript
   M /trunk/src/build/SConscript.main
   M /trunk/src/build/SConscript.v8
   M /trunk/src/build/googleurl_lib.scons
   M /trunk/src/chrome/SConscript
   A /trunk/src/chrome/app/locales/locales.scons
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/chrome.scons
   A /trunk/src/chrome/chrome_sln.scons
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/ipc_tests.scons
   M /trunk/src/chrome/installer/mini_installer/installer_unittests.scons
   M /trunk/src/chrome/installer/mini_installer/mini_installer.scons
   M /trunk/src/chrome/installer/setup/setup.scons
   M /trunk/src/chrome/installer/util/util.scons
   M /trunk/src/chrome/plugin/plugin.scons
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/test/activex_test_control/activex_test_control.scons
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.scons
   M /trunk/src/chrome/test/automation/automation.scons
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.scons
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.scons
   M /trunk/src/chrome/test/memory_test/memory_test.scons
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test.scons
   M /trunk/src/chrome/test/page_cycler/page_cycler_tests.scons
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/test/plugin/plugin_tests.scons
   M /trunk/src/chrome/test/reliability/reliability_tests.scons
   M /trunk/src/chrome/test/security_tests/security_tests.scons
   M /trunk/src/chrome/test/selenium/selenium_tests.scons
   M /trunk/src/chrome/test/startup/startup_tests.scons
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.scons
   M /trunk/src/chrome/test/ui/ui_tests.scons
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/tools/convert_dict/convert_dict.scons
   M /trunk/src/chrome/tools/crash_service/crash_service.scons
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.scons
   M /trunk/src/chrome/tools/profiles/generate_profile.scons
   M /trunk/src/chrome/tools/test/image_diff/image_diff.scons
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/google_update/SConscript
   M /trunk/src/media/media_lib.scons
   M /trunk/src/media/media_unittests.scons
   M /trunk/src/net/crash_cache.scons
   M /trunk/src/net/dump_cache.scons
   M /trunk/src/net/net.scons
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_perftests.scons
   M /trunk/src/net/net_resources.scons
   A /trunk/src/net/net_sln.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/stress_cache.scons
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.scons
   M /trunk/src/rlz/SConscript
   M /trunk/src/sandbox/sandbox.scons
   A /trunk/src/sandbox/sandbox_sln.scons
   M /trunk/src/sdch/SConscript
   M /trunk/src/site_scons/site_tools/chromium_builders.py
   M /trunk/src/skia/SConscript
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/third_party/bsdiff/bsdiff.scons
   M /trunk/src/third_party/bspatch/bspatch.scons
   M /trunk/src/third_party/bzip2/bzip2.scons
   M /trunk/src/third_party/libjpeg/libjpeg.scons
   M /trunk/src/third_party/libpng/libpng.scons
   M /trunk/src/third_party/libxml/libxml.scons
   M /trunk/src/third_party/libxslt/libxslt.scons
   M /trunk/src/third_party/lzma_sdk/lzma_sdk.scons
   M /trunk/src/third_party/modp_b64/modp_b64.scons
   M /trunk/src/third_party/scons/scons-local/SCons/Environment.py
   M /trunk/src/third_party/sqlite/SConscript
   M /trunk/src/third_party/zlib/zlib.scons
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/activex_shim/SConscript
   M /trunk/src/webkit/activex_shim_dll/SConscript
   M /trunk/src/webkit/build/JSConfig/SConscript
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/V8Bindings/SConscript
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/build/localized_strings/SConscript
   M /trunk/src/webkit/default_plugin/SConscript
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/plugins/test/SConscript
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript
   M /trunk/src/webkit/webkit.scons
   A /trunk/src/webkit/webkit_sln.scons

Initial generation of native Visual Studio solution files
(project files still to come).  To wit:
* Solution file configuration is in *_sln.scons files (base\base_sln.scons,
  chrome\chrome_sln.scons).
* Individual Project file configuration is in the the .scons file for
  the relevant target (base\base_unittests.scons,
  third_party\libxml\libxml.scons, etc.)--that is, where their file
  lists will live.
* MSVSProject() calls are currently placeholders that establish
  the existence of Project Nodes (and Project dependencies) but don't yet
  have actual Project configuration information (file lists, .vsprops, etc.).
* Configuraiton is very manual.  In particular, the entries in the .sln
  file will be written out in exactly the order specified in the
  configuration(s).  The current ordering is taken from our existing
  .sln files, so we can generate virtually the same configurations
  on output.
* Generated solution files are nearly byte-for-byte identical
  with our existing .sln files, modulo:
  * net\dump_cache has a WebsiteProperties sections (making that
    configurable per project isn't important right now);
  * sandbox\sandbox.sln was missing a dependency of base.vcproj on
    on debug_message.vcproj (present in other .sln files)
  * webkit\webkit.sln was missing dependencies of WebCore.vcproj on
    libxml_config.vcproj and libxslt_config.vcproj (present in
    chrome.sln);
  * add a handful of other miscellaneous missing dependencies on various
    .vcproj definitions in chrome.sln (present in other .sln files).
  * remove stats_viewer.csproj from chrome.sln (sorry, mbelshe),
    which was complicating the solution configuration with unnecessary
    (for us) "Mixed Platform" types;
* All MSVSFolder(), MSVSProject() and MSVSSolution() calls have
  hard-wired guid= values taken from our existing configuration,
  so we can: 1) verify generation of working configs; 2) minimize
  diffs when checking in generated .sln files.  We can remove
  these in the future in favor of extracting them from existing
  .sln files if we wish.
* Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution()
  wrappers to chromium_builders.py, that gate the underlying call to
  the env.MSVS*() builders based on whether env.Bit('msvs') is set
  (i.e., we're in --mode=msvs).
* Remove platform-specific gating of to-be-ported .scons files that we
  now need to load on any platform to generate coheren MSVS files.
  Move the env.Bit('windows') tests for actually building their
  executables into the individual .scons files.


Review URL: http://codereview.chromium.org/14472
------------------------------------------------------------------------
r7296 | scherkus@chromium.org | 2008-12-19 08:33:24 +0100 (Fri, 19 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc

Switched dns_global.cc over to UTF-8 strings.

Review URL: http://codereview.chromium.org/15065
------------------------------------------------------------------------
r7289 | pkasting@chromium.org | 2008-12-19 03:26:15 +0100 (Fri, 19 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/tabbed_pane.h

Select the Languages tab of the fonts and languages dialog when using spellcheck context menu commands to change spellchecking options.  Patch by Mohamed Mansour, r=me,sky; see http://codereview.chromium.org/15031.  Tweaked by me.

BUG=5639
------------------------------------------------------------------------
r7286 | jnd@google.com | 2008-12-19 02:48:16 +0100 (Fri, 19 Dec 2008) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

We need to add UI test for "Encoding" menu to avoid regression.
For this purpose, I have created several methods in automation API.
They can be used for the above UI tests.

1 get the current used encoding name of the page in the specified tab.
2 get value of the encoding auto detection option.
3 enables and disable the encoding auto detection.
4 use the specified encoding to override the encoding of the page in the
 specified tab.

BUG=5515

The corresponding UI test is coming soon

Review URL: http://codereview.chromium.org/14162
------------------------------------------------------------------------
r7284 | jcampan@chromium.org | 2008-12-19 02:26:02 +0100 (Fri, 19 Dec 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_unittest.cc

The WebContentsTest.ShowInterstitialProceedMultipleCommands unit test seem to crash on the "XP Test" build bot and has been temporarily disabled.

Not sure yet why it crashes, I cannot repro locally and Purify is not reporting any memory errors.

Disabling it temporarily.

BUG=5700


Review URL: http://codereview.chromium.org/14876
------------------------------------------------------------------------
r7283 | scherkus@chromium.org | 2008-12-19 02:09:45 +0100 (Fri, 19 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/session_startup_pref.cc

Changed SessionStartupPref to use UTF-8 strings.

Review URL: http://codereview.chromium.org/14875
------------------------------------------------------------------------
r7282 | scherkus@chromium.org | 2008-12-19 02:01:33 +0100 (Fri, 19 Dec 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc

Updated HtmlDialogContents to use UTF-8 strings.
------------------------------------------------------------------------
r7281 | jcampan@chromium.org | 2008-12-19 01:42:30 +0100 (Fri, 19 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/interstitial_page.cc
   M /trunk/src/chrome/browser/interstitial_page.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/provisional_load_details.cc
   M /trunk/src/chrome/browser/provisional_load_details.h
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_util.cc
   M /trunk/src/chrome/browser/tab_util.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/test_tab_contents.cc


Review URL: http://codereview.chromium.org/14809
------------------------------------------------------------------------
r7270 | sgk@google.com | 2008-12-19 00:26:29 +0100 (Fri, 19 Dec 2008) | 14 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/gfx/base_gfx.scons
   M /trunk/src/breakpad/SConscript
   M /trunk/src/build/SConscript.v8
   M /trunk/src/build/debug.scons
   M /trunk/src/build/external_code.scons
   M /trunk/src/build/googleurl_lib.scons
   M /trunk/src/build/googleurl_unittests.scons
   M /trunk/src/build/internal/essential.scons
   M /trunk/src/build/internal/release_impl_dom_stats.scons
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/chrome.scons
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/ipc_tests.scons
   M /trunk/src/chrome/installer/mini_installer/installer_unittests.scons
   M /trunk/src/chrome/installer/mini_installer/mini_installer.scons
   M /trunk/src/chrome/installer/setup/setup.scons
   M /trunk/src/chrome/plugin/plugin.scons
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/test/activex_test_control/activex_test_control.scons
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.scons
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.scons
   M /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.scons
   M /trunk/src/chrome/test/memory_test/memory_test.scons
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test.scons
   M /trunk/src/chrome/test/page_cycler/page_cycler_tests.scons
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/test/plugin/plugin_tests.scons
   M /trunk/src/chrome/test/reliability/reliability_tests.scons
   M /trunk/src/chrome/test/security_tests/security_tests.scons
   M /trunk/src/chrome/test/selenium/selenium_tests.scons
   M /trunk/src/chrome/test/startup/startup_tests.scons
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.scons
   M /trunk/src/chrome/test/ui/ui_tests.scons
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/tools/convert_dict/convert_dict.scons
   M /trunk/src/chrome/tools/crash_service/crash_service.scons
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.scons
   M /trunk/src/chrome/tools/profiles/generate_profile.scons
   M /trunk/src/chrome/tools/test/image_diff/image_diff.scons
   M /trunk/src/media/media_lib.scons
   M /trunk/src/media/media_unittests.scons
   M /trunk/src/net/crash_cache.scons
   M /trunk/src/net/dump_cache.scons
   M /trunk/src/net/net.scons
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_perftests.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/stress_cache.scons
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.scons
   M /trunk/src/sandbox/src/sandbox_lib.scons
   M /trunk/src/sandbox/tests/common/sandbox_common.scons
   M /trunk/src/sandbox/tests/integration_tests/sbox_integration_tests.scons
   M /trunk/src/sandbox/tests/unit_tests/sbox_unittests.scons
   M /trunk/src/sandbox/tests/validation_tests/sbox_validation_tests.scons
   M /trunk/src/sandbox/wow_helper/wow_helper.scons
   M /trunk/src/sdch/SConscript
   M /trunk/src/skia/SConscript
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/third_party/bspatch/bspatch.scons
   M /trunk/src/third_party/bzip2/bzip2.scons
   M /trunk/src/third_party/libevent/libevent.scons
   M /trunk/src/third_party/libjpeg/libjpeg.scons
   M /trunk/src/third_party/libpng/libpng.scons
   M /trunk/src/third_party/libxml/libxml.scons
   M /trunk/src/third_party/libxslt/libxslt.scons
   M /trunk/src/third_party/lzma_sdk/lzma_sdk.scons
   M /trunk/src/third_party/sqlite/SConscript
   M /trunk/src/third_party/zlib/zlib.scons
   M /trunk/src/webkit/SConscript
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/V8Bindings/SConscript
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/build/localized_strings/SConscript
   M /trunk/src/webkit/build/port/SConscript
   M /trunk/src/webkit/default_plugin/SConscript
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/plugins/test/SConscript
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript

Convert from using env['PLATFORM'] directly to using the more flexible
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
  other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
------------------------------------------------------------------------
r7266 | paulg@google.com | 2008-12-19 00:18:14 +0100 (Fri, 19 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc

Increase timeout for ui_test.
Review URL: http://codereview.chromium.org/15061
------------------------------------------------------------------------
r7262 | brettw@google.com | 2008-12-18 23:41:31 +0100 (Thu, 18 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/web_contents.cc

Fix a DCHECK in the IFrameTest.InEmptyFrame by removing it. The behavior is
correct, and the condition can be hit differently than assumed by the DCHECK.

BUG=3035
Review URL: http://codereview.chromium.org/15050
------------------------------------------------------------------------
r7258 | paulg@google.com | 2008-12-18 23:14:30 +0100 (Thu, 18 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_restore_uitest.cc

Make the tab restore ui_tests Purify friendly.
Review URL: http://codereview.chromium.org/15053
------------------------------------------------------------------------
r7256 | hclam@chromium.org | 2008-12-18 22:40:36 +0100 (Thu, 18 Dec 2008) | 27 lines
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/renderer/renderer_glue.cc
   A /trunk/src/chrome/renderer/webmediaplayer_delegate_impl.cc
   A /trunk/src/chrome/renderer/webmediaplayer_delegate_impl.h
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/glue/SConscript
   A /trunk/src/webkit/glue/media_player_private_impl.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webkit_glue.h
   A /trunk/src/webkit/glue/webmediaplayer.h
   A /trunk/src/webkit/glue/webmediaplayer_delegate.h
   A /trunk/src/webkit/glue/webmediaplayer_impl.cc
   A /trunk/src/webkit/glue/webmediaplayer_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/port/platform/graphics/chromium/MediaPlayerPrivateChromium.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.h

Bridge out media player from MediaPlayerPrivate.

- Remove MediaPlayerPrivateChromium.cpp and move it to webkit/glue/media_player_private_impl.cc

- Added the following classes:
  WebMediaPlayer
  WebMediaPlayerImpl
  WebMediaPlayerDelegate
  WebMediaPlayerDelegateImpl
  TestWebMediaPlayerDelegate
  VideoStackMediaPlayer (Just a forward declaration)

- One include fix for webkit/glue/webframe.h

- Overview of what each class is doing:
  WebMediaPlayer and WebMediaPlayerImpl
  Wrapper over the MediaPlayerPrivate, it provides methods like Repaint(), NotifyNetworkStateChange(), etc to VideoStackMediaPlayer. It also creates the ResourceHandle for VideoStackMediaPlayer for resource loading, or maybe VideoStackMediaPlayer can simply use webkit_glue::ResourceDispatcher?

  WebMediaPlayerDelegate, WebMediaPlayerDelegateImpl
  Delegate calls from webkit to the internal media player. 

  MediaPlayerPrivate
  Forward calls to WebMidiaPlayerDelegate, creates WebMediaPlayerDelegate and WebMediaPlayer in the constructor. Expose some public methods to WebMediaPlayer so we can actually do repaint and notification of changes.



Review URL: http://codereview.chromium.org/13762
------------------------------------------------------------------------
r7242 | paulg@google.com | 2008-12-18 20:11:38 +0100 (Thu, 18 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc

Make some more ui_test Purify friendly.
Review URL: http://codereview.chromium.org/15027
------------------------------------------------------------------------
r7239 | klink@chromium.org | 2008-12-18 20:07:34 +0100 (Thu, 18 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc

Adds the Home button to the MSAA focus order, if enabled. Also removes an unnecessary check from ViewAccessibility.

Review URL: http://codereview.chromium.org/15026
------------------------------------------------------------------------
r7235 | sky@google.com | 2008-12-18 20:01:38 +0100 (Thu, 18 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h

Fixes browser crash that could occur if the user closed a tab with an
unload handler, then right clicked on the tab. The fix is to close the
menu if the tab closes.

BUG=4846
TEST=see bug

Review URL: http://codereview.chromium.org/14843
------------------------------------------------------------------------
r7228 | erg@google.com | 2008-12-18 19:36:23 +0100 (Thu, 18 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

This fixes a crash while trying to duplicate an application window.

Review URL: http://codereview.chromium.org/14823
------------------------------------------------------------------------
r7226 | paulg@google.com | 2008-12-18 19:21:53 +0100 (Thu, 18 Dec 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/ui/history_uitest.cc
   M /trunk/src/chrome/test/ui/npapi_uitest.cpp
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/tools/purify/chrome_tests.py

Initial support for running the ui_tests under Purify on the
buildbots.

With these changes, I've been able to get 106 of about 185
ui_tests running under Purify on my machine (I haven't gotten
to the remaining tests yet) with minimal changes.

The changes here are timeout related, allowing us to specify
longer timeouts in chrome_tests.py rather than hard coding them
in the tests themselves. We'll likely have to experiment on the
buildbots with different timeout values, depending on how fast
the bots are.

Review URL: http://codereview.chromium.org/14184
------------------------------------------------------------------------
r7220 | brettw@google.com | 2008-12-18 18:36:54 +0100 (Thu, 18 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Don't handle in-page navigations if it's for a subframe. Previously we would
compare the URL with the main frame to see if it was in page. In very rare
cases, these can actually be the same, which will confuse us.

http://crbug.com/5585
Review URL: http://codereview.chromium.org/14824
------------------------------------------------------------------------
r7218 | phajdan.jr@chromium.org | 2008-12-18 18:03:57 +0100 (Thu, 18 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/chrome.scons

Porting in browser/debugger/
Review URL: http://codereview.chromium.org/14841
------------------------------------------------------------------------
r7216 | phajdan.jr@chromium.org | 2008-12-18 18:01:37 +0100 (Thu, 18 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Unbreak Windows scons build caused by my importer porting.
Review URL: http://codereview.chromium.org/14840
------------------------------------------------------------------------
r7215 | phajdan.jr@chromium.org | 2008-12-18 17:58:28 +0100 (Thu, 18 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Reverting 7214.
Review URL: http://codereview.chromium.org/15403
------------------------------------------------------------------------
r7214 | phajdan.jr@chromium.org | 2008-12-18 17:56:23 +0100 (Thu, 18 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Unbreak Windows scons build caused by my importer porting.
Review URL: http://codereview.chromium.org/14840
------------------------------------------------------------------------
r7205 | xji@chromium.org | 2008-12-18 03:34:17 +0100 (Thu, 18 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

This CL fixes issue 4224: Window Management controls don't work with maximized RTL Chrome windows.
When checking whether a point is within a window management button view's boundary,
need to apply mirroring transformation on the view's boundary to work for RTL chrome.

http://crbug.com/4224

TEST:
1. Launch Chrome with any RTL (Eg: he, ar)
2. Maximize the browser window.
3. Hover over window management controls (min,restore,close), they all work correctly in the sense that the buttons got highlighted and react to user events. (without this fix, when hover over window management controls, the buttons won't get highlighted at all and they won't react to user events)


Review URL: http://codereview.chromium.org/14129
------------------------------------------------------------------------
r7201 | jcampan@chromium.org | 2008-12-18 02:24:40 +0100 (Thu, 18 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h

Make sure the text field is focused when doing a JavaScript prompt (which shows an alert box with a text field in it).

BUG=5333
TEST=Load a page that does a prompt("Hello", "World"). It should open an alert box with a text field with the contents 'World'. The text should be selected and the text field should have focus. Make sure alert() and confirm() still have the OK button focused when used.
Review URL: http://codereview.chromium.org/15023
------------------------------------------------------------------------
r7199 | scherkus@chromium.org | 2008-12-18 02:22:23 +0100 (Thu, 18 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Switch Extension over to UTF8 strings.

Value now stores everything internally as UTF8 strings, so I'm going around switching code over from wstring to string.

Feel free to reject the change if you need wstring!

Review URL: http://codereview.chromium.org/15020
------------------------------------------------------------------------
r7195 | erg@google.com | 2008-12-18 01:54:08 +0100 (Thu, 18 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Duplicate popup window should have same size and scroll 
position as original popup.
BUG=5632 (http://crbug.com/5632)

Patch by Mohamed Mansour.
Review URL: http://codereview.chromium.org/14812
------------------------------------------------------------------------
r7188 | sky@google.com | 2008-12-18 01:09:55 +0100 (Thu, 18 Dec 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/sessions/session_restore.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.cc
   M /trunk/src/chrome/browser/sessions/tab_restore_service.h
   M /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Makes the tab restore service contain any windows that were open at
the time of a crash.

BUG=5465
TEST=Bring up chrome, go to google.com. Wait a minute. Kill chrome via
  the task manager. Launch chrome again. Make sure the new tab page
  shows an entry named 'Window (g)' where g is Google's favicon.

Review URL: http://codereview.chromium.org/14172
------------------------------------------------------------------------
r7187 | scherkus@chromium.org | 2008-12-18 01:07:59 +0100 (Thu, 18 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc

Switched MetricsService over to using UTF8 string values.

This is part of my ongoing wide string vanquishing.

Review URL: http://codereview.chromium.org/15013
------------------------------------------------------------------------
r7186 | jcampan@chromium.org | 2008-12-18 01:05:49 +0100 (Thu, 18 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/interstitial_page.cc
   M /trunk/src/chrome/browser/interstitial_page.h

Fixed mixed EOLs and set svn EOL prop for interstitial_page.[h,cc]

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/14819
------------------------------------------------------------------------
r7182 | brettw@google.com | 2008-12-18 00:29:40 +0100 (Thu, 18 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/gfx/native_theme.cc
   M /trunk/src/base/gfx/native_theme.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/common/gfx/chrome_canvas_skia.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas_win.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/skia/ext/bitmap_platform_device.h
   M /trunk/src/skia/ext/bitmap_platform_device_linux.cc
   M /trunk/src/skia/ext/bitmap_platform_device_linux.h
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   M /trunk/src/skia/ext/bitmap_platform_device_mac.h
   M /trunk/src/skia/ext/bitmap_platform_device_win.cc
   M /trunk/src/skia/ext/bitmap_platform_device_win.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/platform_canvas.h
   M /trunk/src/skia/ext/platform_canvas_linux.cc
   M /trunk/src/skia/ext/platform_canvas_linux.h
   M /trunk/src/skia/ext/platform_canvas_mac.cc
   M /trunk/src/skia/ext/platform_canvas_mac.h
   M /trunk/src/skia/ext/platform_canvas_unittest.cc
   M /trunk/src/skia/ext/platform_canvas_win.cc
   M /trunk/src/skia/ext/platform_canvas_win.h
   M /trunk/src/skia/ext/platform_device.h
   M /trunk/src/skia/ext/platform_device_linux.cc
   M /trunk/src/skia/ext/platform_device_linux.h
   M /trunk/src/skia/ext/platform_device_mac.cc
   M /trunk/src/skia/ext/platform_device_mac.h
   M /trunk/src/skia/ext/platform_device_win.cc
   M /trunk/src/skia/ext/platform_device_win.h
   M /trunk/src/skia/ext/vector_canvas.cc
   M /trunk/src/skia/ext/vector_canvas.h
   M /trunk/src/skia/ext/vector_canvas_unittest.cc
   M /trunk/src/skia/ext/vector_device.cc
   M /trunk/src/skia/ext/vector_device.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/port/platform/chromium/ScrollbarThemeChromiumWin.cpp
   M /trunk/src/webkit/port/platform/graphics/chromium/ImageBufferData.h
   M /trunk/src/webkit/port/platform/graphics/skia/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/skia/PlatformContextSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/skia/PlatformContextSkia.h
   M /trunk/src/webkit/port/rendering/RenderThemeWin.cpp
   M /trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Move the "platform" wrappers in skia/ext to the skia namespace.
Review URL: http://codereview.chromium.org/14110
------------------------------------------------------------------------
r7177 | sky@google.com | 2008-12-17 23:47:53 +0100 (Wed, 17 Dec 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/views/chrome_menu.cc

Changes menu's Dispatcher to translate/dispatch message before
returning false. This way we don't screw up the message pump. I also
needed to slightly tweak the bookmark bar test that was hitting this
code path.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/15008
------------------------------------------------------------------------
r7165 | jar@google.com | 2008-12-17 22:34:36 +0100 (Wed, 17 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_log.h
   M /trunk/src/chrome/browser/metrics_service.cc

Increase UMA upload interval, and upload usage stats more often


r=evanm
Review URL: http://codereview.chromium.org/14186
------------------------------------------------------------------------
r7161 | sky@google.com | 2008-12-17 22:24:18 +0100 (Wed, 17 Dec 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_tab_view.cc

Fixes crash in download tab view that resulted from attempting to
paint a download at downloads_.size(). This happened if the last
download is visible, in which case row_stop == downloads_.size() and
because the loop iterates to row_stop we try accessing
downloads_[downloads_.size()].

BUG=5520
TEST=Bring up the downloads view and make sure you can scroll to the
  end of your downloads without crashing.

Review URL: http://codereview.chromium.org/14806
------------------------------------------------------------------------
r7153 | jcampan@chromium.org | 2008-12-17 20:57:24 +0100 (Wed, 17 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/interstitial_page.cc
   M /trunk/src/chrome/browser/interstitial_page.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/provisional_load_details.cc
   M /trunk/src/chrome/browser/provisional_load_details.h
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_util.cc
   M /trunk/src/chrome/browser/tab_util.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/test/test_tab_contents.cc

Reverting 7149.
Review URL: http://codereview.chromium.org/15004
------------------------------------------------------------------------
r7151 | evanm@google.com | 2008-12-17 20:44:37 +0100 (Wed, 17 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_model.cc

Fix Linux release build.

Review URL: http://codereview.chromium.org/15401

------------------------------------------------------------------------
r7149 | jcampan@chromium.org | 2008-12-17 20:36:52 +0100 (Wed, 17 Dec 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_request_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/interstitial_page.cc
   M /trunk/src/chrome/browser/interstitial_page.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/provisional_load_details.cc
   M /trunk/src/chrome/browser/provisional_load_details.h
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_util.cc
   M /trunk/src/chrome/browser/tab_util.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/test/test_tab_contents.cc

Revamp of the interstitial pages.
The interstitial is now a RVH that is displayed on top of the WebContents with no interaction with the WebContents' RenderViewHostManager.
This simplifies the states that the RenderViewHostManager has. The interstitial is responsible for hiding and deleting itself when told to proceed/not proceed or when a navigation occurs or the tab is closed.
The interstitial now uses a data URL (instead of loading some alternate HTML), which allowed me to remove some interstitial flags from NavigationController::LoadCommittedDetails and ProvisionalLoadDetails.

Also changed tab_utils::GetTabContentsByID to return a WebContents since only WebContents have a RVH associated with them.

TEST=Run all ui tests and unit tests.

Review URL: http://codereview.chromium.org/13764
------------------------------------------------------------------------
r7146 | phajdan.jr@chromium.org | 2008-12-17 20:04:50 +0100 (Wed, 17 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/url_fixer_upper_unittest.cc

Unbreak unit_test failure on Windows.
Review URL: http://codereview.chromium.org/15002
------------------------------------------------------------------------
r7142 | phajdan.jr@chromium.org | 2008-12-17 19:30:28 +0100 (Wed, 17 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/compiler_specific.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/ssl_error_info.cc
   M /trunk/src/chrome/browser/url_fetcher.cc
   M /trunk/src/chrome/browser/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/common/gfx/favicon_size.h

Platform cleanup in browser/ and porting of few files.
Review URL: http://codereview.chromium.org/14466
------------------------------------------------------------------------
r7141 | pkasting@chromium.org | 2008-12-17 19:11:23 +0100 (Wed, 17 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Mostly cleanup.
* Use temporary variables when we're going to call AsWebContents() repeatedly
* Remove some NOTREACHED()s that don't really help debugging (and none of the surrounding code checks)
* Try and simplify or make clearer some bits of code

Also enables/disables some commands more selectively: IDC_GO is now enabled only when the go button is visible (i.e. when we're not loading), and several commands whose UI is only available in normal windows are now only enabled in normal windows.  This last change fixes a number of weird effects where you could hit different shortcuts in web app and popup windows and trigger commands with little or no UI feedback.
Review URL: http://codereview.chromium.org/14182
------------------------------------------------------------------------
r7129 | jam@chromium.org | 2008-12-17 03:35:46 +0100 (Wed, 17 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc

DatabaseLoadComplete now needs to be run after OnIOInitialize, so change the order of the PostTask.

BUG=5587
Review URL: http://codereview.chromium.org/14499
------------------------------------------------------------------------
r7127 | maruel@chromium.org | 2008-12-17 03:25:44 +0100 (Wed, 17 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/condition_variable_unittest.cc
   M /trunk/src/base/revocable_store.h
   A /trunk/src/base/thread_collision_warner.cc
   A /trunk/src/base/thread_collision_warner.h
   A /trunk/src/base/thread_collision_warner_unittest.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h

Adds a helper class used to mark/define critical section in a class and then install controls to check that those critical sections are not violated.

This CL is due the thread posted on chromium-dev:
http://groups.google.com/group/chromium-dev/browse_frm/thread/30af0b63b6adb245.

From Gaetano Mendola <mendola bigfoot com>
Review URL: http://codereview.chromium.org/8621
------------------------------------------------------------------------
r7126 | agl@chromium.org | 2008-12-17 03:03:23 +0100 (Wed, 17 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.h
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/widget.h
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h

Replace some CRects with gfx::Rect

Review URL: http://codereview.chromium.org/14173

------------------------------------------------------------------------
r7122 | ojan@google.com | 2008-12-17 02:14:00 +0100 (Wed, 17 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add some initial before unload tests. We still need tests
for multiple tabs with beforeunload/unload handlers.
Review URL: http://codereview.chromium.org/14085
------------------------------------------------------------------------
r7119 | pkasting@chromium.org | 2008-12-17 02:08:33 +0100 (Wed, 17 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Make stop work again (I broke it).  Rather than revert to the previous working-but-lame code, this cleans up the code a little further by actually enabling/disabling the stop command at the right times.

BUG=5542
Review URL: http://codereview.chromium.org/14498
------------------------------------------------------------------------
r7116 | mpcomplete@google.com | 2008-12-17 02:02:35 +0100 (Wed, 17 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc

Add a test for fts2 prefix searching.
Review URL: http://codereview.chromium.org/14177
------------------------------------------------------------------------
r7112 | estade@chromium.org | 2008-12-17 00:15:19 +0100 (Wed, 17 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

fix build

------------------------------------------------------------------------
r7109 | estade@chromium.org | 2008-12-16 23:58:11 +0100 (Tue, 16 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/base/basictypes.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/spellcheck_unittest.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Port the spell checker to posix.

It all builds but does not link yet.

Review URL: http://codereview.chromium.org/14408
------------------------------------------------------------------------
r7094 | tim@chromium.org | 2008-12-16 21:58:02 +0100 (Tue, 16 Dec 2008) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h

Fix for crbug.com/5471 (browser crash regression).

The "pending_save_manager_" used to only be non-null
between the time the user hits 'Submit' on a form and we either 1) show an 
infobar, or 2) update an existing login. Now, instead, the member only gets reset on 
InfoBarClosed(), and so this ordering of events was causing a crash:

--ExpireInfoBar, removes delegate from infobar_delegates_
--WebContents::DidStopLoading, causes PasswordManager to call AddInfoBar because it
has a pending_save_manager_ (and AddInfoBar succeeds because there is no "equal" 
delegate already in the set)
--Animation terminates, which calls InfoBarClosed(), and resets the 
pending_save_manager_
--Now we have an infobar and a null pending_save_manager_, so clicking Accept/Cancel 
will deref 0.

Renamed |pending_save_manager_| to |provisional_save_manager_| to be more consistent,
and added |pending_decision_manager_| to take responsibility of the PasswordFormManager
in |provisional_save_manager_| when the infobar comes in to play, so that we have
the same ownership model as before the new infobar changes.


Review URL: http://codereview.chromium.org/14464
------------------------------------------------------------------------
r7093 | maruel@chromium.org | 2008-12-16 21:56:44 +0100 (Tue, 16 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/base.sln
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/build/debug_message.vcproj
   M /trunk/src/breakpad/breakpad_handler.vcproj
   M /trunk/src/breakpad/breakpad_sender.vcproj
   M /trunk/src/build/internal/release_impl_coverage.vsprops
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/chrome_exe.vcproj
   M /trunk/src/chrome/app/generated_resources.vcproj
   M /trunk/src/chrome/app/locales/ar.vcproj
   M /trunk/src/chrome/app/locales/bg.vcproj
   M /trunk/src/chrome/app/locales/bn.vcproj
   M /trunk/src/chrome/app/locales/ca.vcproj
   M /trunk/src/chrome/app/locales/cs.vcproj
   M /trunk/src/chrome/app/locales/da.vcproj
   M /trunk/src/chrome/app/locales/de.vcproj
   M /trunk/src/chrome/app/locales/el.vcproj
   M /trunk/src/chrome/app/locales/en-GB.vcproj
   M /trunk/src/chrome/app/locales/en-US.vcproj
   M /trunk/src/chrome/app/locales/es-419.vcproj
   M /trunk/src/chrome/app/locales/es.vcproj
   M /trunk/src/chrome/app/locales/et.vcproj
   M /trunk/src/chrome/app/locales/fi.vcproj
   M /trunk/src/chrome/app/locales/fil.vcproj
   M /trunk/src/chrome/app/locales/fr.vcproj
   M /trunk/src/chrome/app/locales/gu.vcproj
   M /trunk/src/chrome/app/locales/he.vcproj
   M /trunk/src/chrome/app/locales/hi.vcproj
   M /trunk/src/chrome/app/locales/hr.vcproj
   M /trunk/src/chrome/app/locales/hu.vcproj
   M /trunk/src/chrome/app/locales/id.vcproj
   M /trunk/src/chrome/app/locales/it.vcproj
   M /trunk/src/chrome/app/locales/ja.vcproj
   M /trunk/src/chrome/app/locales/kn.vcproj
   M /trunk/src/chrome/app/locales/ko.vcproj
   M /trunk/src/chrome/app/locales/lt.vcproj
   M /trunk/src/chrome/app/locales/lv.vcproj
   M /trunk/src/chrome/app/locales/ml.vcproj
   M /trunk/src/chrome/app/locales/mr.vcproj
   M /trunk/src/chrome/app/locales/nb.vcproj
   M /trunk/src/chrome/app/locales/nl.vcproj
   M /trunk/src/chrome/app/locales/or.vcproj
   M /trunk/src/chrome/app/locales/pl.vcproj
   M /trunk/src/chrome/app/locales/pt-BR.vcproj
   M /trunk/src/chrome/app/locales/pt-PT.vcproj
   M /trunk/src/chrome/app/locales/ro.vcproj
   M /trunk/src/chrome/app/locales/ru.vcproj
   M /trunk/src/chrome/app/locales/sk.vcproj
   M /trunk/src/chrome/app/locales/sl.vcproj
   M /trunk/src/chrome/app/locales/sr.vcproj
   M /trunk/src/chrome/app/locales/sv.vcproj
   M /trunk/src/chrome/app/locales/ta.vcproj
   M /trunk/src/chrome/app/locales/te.vcproj
   M /trunk/src/chrome/app/locales/th.vcproj
   M /trunk/src/chrome/app/locales/tr.vcproj
   M /trunk/src/chrome/app/locales/uk.vcproj
   M /trunk/src/chrome/app/locales/vi.vcproj
   M /trunk/src/chrome/app/locales/zh-CN.vcproj
   M /trunk/src/chrome/app/locales/zh-TW.vcproj
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   M /trunk/src/chrome/browser/debugger/debugger_disabled.vcproj
   M /trunk/src/chrome/browser/resources/browser_resources.vcproj
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_tests.vcproj
   M /trunk/src/chrome/installer/gcapi/gcapi.vsprops
   M /trunk/src/chrome/installer/gcapi/gcapi_dll.vcproj
   M /trunk/src/chrome/installer/gcapi/gcapi_lib.vcproj
   M /trunk/src/chrome/installer/gcapi/gcapi_test.vcproj
   M /trunk/src/chrome/installer/mini_installer/mini_installer.vcproj
   M /trunk/src/chrome/installer/setup/setup.vcproj
   M /trunk/src/chrome/installer/util/installer_unittests.vcproj
   M /trunk/src/chrome/installer/util/prebuild/util_prebuild.vcproj
   M /trunk/src/chrome/installer/util/util.vcproj
   M /trunk/src/chrome/plugin/plugin.vcproj
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/test/activex_test_control/activex_test_control.vcproj
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.vcproj
   M /trunk/src/chrome/test/automation/automation.vcproj
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.vcproj
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/memory_test/memory_test.vcproj
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test.vcproj
   M /trunk/src/chrome/test/page_cycler/page_cycler_tests.vcproj
   M /trunk/src/chrome/test/perf/perftests.vcproj
   M /trunk/src/chrome/test/plugin/plugin_tests.vcproj
   M /trunk/src/chrome/test/reliability/reliability_tests.vcproj
   M /trunk/src/chrome/test/security_tests/security_tests.vcproj
   M /trunk/src/chrome/test/selenium/selenium_tests.vcproj
   M /trunk/src/chrome/test/startup/startup_tests.vcproj
   M /trunk/src/chrome/test/tab_switching/tab_switching.vcproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/third_party/hunspell/hunspell.vcproj
   M /trunk/src/chrome/tools/convert_dict/convert_dict.vcproj
   M /trunk/src/chrome/tools/crash_service/crash_service.vcproj
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.vcproj
   M /trunk/src/chrome/tools/profiles/generate_profile.vcproj
   M /trunk/src/chrome/tools/test/image_diff/image_diff.vcproj
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/gears/gears.vcproj
   M /trunk/src/google_update/ondemand_updates.vcproj
   M /trunk/src/media/build/media.vcproj
   M /trunk/src/media/build/media_unittests.vcproj
   M /trunk/src/media/media.sln
   M /trunk/src/net/build/crash_cache.vcproj
   M /trunk/src/net/build/dump_cache.vcproj
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_perftests.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/build/stress_cache.vcproj
   M /trunk/src/net/build/tld_cleanup.vcproj
   M /trunk/src/net/net.sln
   M /trunk/src/rlz/rlz.vcproj
   M /trunk/src/sandbox/sandbox.sln
   M /trunk/src/sandbox/sandbox_poc/pocdll/pocdll.vcproj
   M /trunk/src/sandbox/sandbox_poc/sandbox_poc.vcproj
   M /trunk/src/sandbox/src/sandbox.vcproj
   M /trunk/src/sandbox/tests/integration_tests/sbox_integration_tests.vcproj
   M /trunk/src/sandbox/tests/unit_tests/sbox_unittests.vcproj
   M /trunk/src/sandbox/tests/validation_tests/sbox_validation_tests.vcproj
   M /trunk/src/sandbox/tools/finder/finder.vcproj
   M /trunk/src/sandbox/tools/launcher/launcher.vcproj
   M /trunk/src/sandbox/wow_helper/wow_helper.vcproj
   M /trunk/src/sandbox/wow_helper.sln
   M /trunk/src/sdch/sdch.vcproj
   M /trunk/src/skia/skia.vcproj
   M /trunk/src/testing/gtest.vcproj
   M /trunk/src/third_party/bsdiff/bsdiff.vcproj
   M /trunk/src/third_party/bspatch/bspatch.vcproj
   M /trunk/src/third_party/bzip2/bzip2.vcproj
   M /trunk/src/third_party/libjpeg/libjpeg.vcproj
   M /trunk/src/third_party/libpng/libpng.vcproj
   M /trunk/src/third_party/libxml/build/libxml.vcproj
   M /trunk/src/third_party/libxml/build/libxml_config.vcproj
   M /trunk/src/third_party/libxslt/build/libxslt.vcproj
   M /trunk/src/third_party/libxslt/build/libxslt_config.vcproj
   M /trunk/src/third_party/lzma_sdk/7z_C.vcproj
   M /trunk/src/third_party/modp_b64/modp_b64.vcproj
   M /trunk/src/third_party/npapi/npspy/windows/npspy.sln
   M /trunk/src/third_party/npapi/npspy/windows/npspy.vcproj
   M /trunk/src/third_party/npapi/npspy/windows/spysetup.vcproj
   M /trunk/src/third_party/sqlite/sqlite.vcproj
   M /trunk/src/third_party/zlib/zlib.vcproj
   M /trunk/src/tools/channel_changer/channel_changer.sln
   M /trunk/src/tools/channel_changer/channel_changer.vcproj
   M /trunk/src/tools/measure_page_load_time/ie_bho/MeasurePageLoadTime.vcproj
   M /trunk/src/tools/memory_watcher/memory_watcher.vcproj
   M /trunk/src/webkit/activex_shim/activex_shim.vcproj
   M /trunk/src/webkit/activex_shim_dll/activex_shim_dll.vcproj
   M /trunk/src/webkit/build/JSConfig/KJSConfig.vcproj
   M /trunk/src/webkit/build/JSConfig/V8Config.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/JavaScriptCore.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/JavaScriptCore_pcre.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/WTF.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/testapi.vcproj
   M /trunk/src/webkit/build/KJSBindings/KJSBindings.vcproj
   M /trunk/src/webkit/build/KJSBindings/KJSBindings_prebuild.vcproj
   M /trunk/src/webkit/build/V8Bindings/V8Bindings.vcproj
   M /trunk/src/webkit/build/V8Bindings/V8Bindings_prebuild.vcproj
   M /trunk/src/webkit/build/WebCore/WebCore.vcproj
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/build/localized_strings/localized_strings.vcproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/default_plugin/default_plugin.vcproj
   M /trunk/src/webkit/glue/plugins/test/npapi_test_plugin.vcproj
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/npapi_layout_test_plugin.vcproj
   M /trunk/src/webkit/tools/test_shell/test_shell.vcproj
   M /trunk/src/webkit/tools/test_shell/test_shell_tests.vcproj
   M /trunk/src/webkit/webkit.sln
   M /trunk/src/webkit/webkit_armu.sln
   M /trunk/src/webkit/webkit_kjs.sln

Switch back svn:eol-style=native for .sln, .vcproj and .vsprops files.
Patch fails otherwise on non-Windows platforms.
Review URL: http://codereview.chromium.org/14478
------------------------------------------------------------------------
r7091 | sky@google.com | 2008-12-16 21:42:25 +0100 (Tue, 16 Dec 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Attempt 2 at this. This differs from first version in that I renamed
set_store to ClearStore and properly remove an observer I added. And I'm
disabling a test that needs more investigation.

Makes the interactive bookmark bar view tests faster by disabling
saving. This is why BookmarkBarViewTest9 keeps timing out.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/14471
------------------------------------------------------------------------
r7087 | phajdan.jr@chromium.org | 2008-12-16 21:34:39 +0100 (Tue, 16 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/ssl_error_info.cc
   M /trunk/src/chrome/browser/url_fetcher.cc
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/chrome/browser/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/common/gfx/favicon_size.h

Reverting 7083,7079.

I tested locally with gcc 4.3, but gcc 4.2 behaves differently and fails.
Review URL: http://codereview.chromium.org/14165
------------------------------------------------------------------------
r7079 | phajdan.jr@chromium.org | 2008-12-16 21:05:14 +0100 (Tue, 16 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/ssl_error_info.cc
   M /trunk/src/chrome/browser/url_fetcher.cc
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/chrome/browser/url_fixer_upper_unittest.cc

Platform cleanup in browser/ and porting of few files.

Review URL: http://codereview.chromium.org/14466
------------------------------------------------------------------------
r7069 | cpu@google.com | 2008-12-16 19:47:34 +0100 (Tue, 16 Dec 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Fixes crash at ResourceDispatcherHost::BeginDownload
 - It is a 'planned' crash in a CHECK(false)
 - Now is a bug because the user can trigger it by alt-click in a  <a href=data:xxxxx >

The codepath in question skips all the checks we do in the downloadmanager and on the UI command handlers.

BUG=5112

Review URL: http://codereview.chromium.org/12968
------------------------------------------------------------------------
r7068 | sky@google.com | 2008-12-16 19:46:25 +0100 (Tue, 16 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Reverts r7062 as caused failures on interactive tests.

------------------------------------------------------------------------
r7064 | pkasting@chromium.org | 2008-12-16 18:58:19 +0100 (Tue, 16 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Fix Justin Haygood's last name (sorry!).  Patch by Mohamed Mansour, r=me; see http://codereview.chromium.org/14148

BUG=5558
------------------------------------------------------------------------
r7063 | sky@google.com | 2008-12-16 18:52:08 +0100 (Tue, 16 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h

Fixes info bubble painting bug. This was happening because we were
using layered windows incorrectly. According to the docs if you invoke
SetLayeredWindowAttributes, then you shouldn't invoke
UpdateLayeredWindow (unless you remove then add the WS_EX_LAYERED
style bit). My approach here is to disable the backing buffer for the
info bubble. I had problems toggling the WS_EX_LAYERED at the end up
the animation. The text field would not paint when I did this...

BUG=5351
TEST=bookmark a page. When the bubble appears press shift-tab and make
  sure you see a focus rect around the remove link.

Review URL: http://codereview.chromium.org/14131
------------------------------------------------------------------------
r7062 | sky@google.com | 2008-12-16 18:51:56 +0100 (Tue, 16 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc

Makes the interactive bookmark bar view tests faster by disabling
saving. This is why BookmarkBarViewTest9 keeps timing out.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/14449
------------------------------------------------------------------------
r7061 | phajdan.jr@chromium.org | 2008-12-16 17:58:27 +0100 (Tue, 16 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/metrics_log.cc

Port few files in browser/ to Linux.
Review URL: http://codereview.chromium.org/14462
------------------------------------------------------------------------
r7052 | phajdan.jr@chromium.org | 2008-12-16 12:12:13 +0100 (Tue, 16 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/template_url.cc
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   A /trunk/src/chrome/browser/webdata/web_database_win.cc

Porting in browser/webdata and template_url.
Review URL: http://codereview.chromium.org/14419
------------------------------------------------------------------------
r7044 | abarth@chromium.org | 2008-12-16 05:06:24 +0100 (Tue, 16 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h

Don't show chrome://about/foo as the title for about:foo.  Instead, show about:foo.

R=evanm


Review URL: http://codereview.chromium.org/14203
------------------------------------------------------------------------
r7032 | pkasting@chromium.org | 2008-12-16 02:41:00 +0100 (Tue, 16 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/metrics_log.cc

Omnibox metrics logging patch splitout, part 6: Log more omnibox data (client side).

This is the last patch.  It can't go in until Evan and I test it.
Review URL: http://codereview.chromium.org/10666
------------------------------------------------------------------------
r7026 | wtc@google.com | 2008-12-16 01:53:25 +0100 (Tue, 16 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Remove unnecessary temporary GlobalRequestID objects.
(I found these while investigating bug 4749.)

R=eroman
Review URL: http://codereview.chromium.org/12974
------------------------------------------------------------------------
r7021 | pkasting@chromium.org | 2008-12-16 01:33:34 +0100 (Tue, 16 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/widget_win.h

Rip out custom WM_GETMINMAXINFO handling entirely.  I think this is a relic of the old Halo Frame.  Trying to rip it out halfway results in problems, like the taskbar not un-auto-hiding when Chromium is maximized.

This should result in correct handling of maximized windows on multiple monitors with different resolutions, taskbar positions, and auto-hide settings (since we're just using the native Windows code to do everything).

BUG=943445
Review URL: http://codereview.chromium.org/14446
------------------------------------------------------------------------
r7020 | klink@chromium.org | 2008-12-16 01:24:30 +0100 (Tue, 16 Dec 2008) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.cc (from /trunk/src/chrome/views/accessibility/autocomplete_accessibility.cc:6737)
   A /trunk/src/chrome/browser/autocomplete/autocomplete_accessibility.h (from /trunk/src/chrome/views/accessibility/autocomplete_accessibility.h:6737)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.cc
   D /trunk/src/chrome/views/accessibility/autocomplete_accessibility.cc
   D /trunk/src/chrome/views/accessibility/autocomplete_accessibility.h
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/views.vcproj

Eliminates the dependencies between views and browser, and also does some other minor cleanups. The special casing for the OmniBox that used to live in the ViewAccessibility code could be removed due to the fact that the only assistive technologies depending on this case are now testing tools. The end-user tools will see no difference, and the testing tools can access the OmniBox IAccessible by directly giving it keyboard/mouse focus.

BUG=2237


Review URL: http://codereview.chromium.org/14036
------------------------------------------------------------------------
r7017 | jcampan@chromium.org | 2008-12-16 01:05:15 +0100 (Tue, 16 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.cpp
   M /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.h

Changes to the autofill popup:
- we now reuse the existing popup if there is one (instead of creating a new on with each key stoke), this prevents the flickering we used to see.
- we don't hide the popup on every key stroke, instead we rely on the client editor telling us the field is not being edited anymore.

TEST=Enter some text in a form's text field several times, the autofill should show and not flicker.
BUG=5258
Review URL: http://codereview.chromium.org/14100
------------------------------------------------------------------------
r7016 | finnur@google.com | 2008-12-16 00:53:41 +0100 (Tue, 16 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Add a ui test to make sure the Find box does not go away on Reload but does
go away when you navigate to a new page.

Review URL: http://codereview.chromium.org/14130
------------------------------------------------------------------------
r7005 | abarth@chromium.org | 2008-12-15 22:14:00 +0100 (Mon, 15 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Second attempt at extending the back button to the left edge when maximized.

This time, we do everything programatically and extend the target area only when the window is maximized.  After this patch, we don't actually get the left-most pixel to be targetable on XP because our frame code is borked, but this should work once we unbork that.

BUG=3484
R=beng

Review URL: http://codereview.chromium.org/13782
------------------------------------------------------------------------
r7004 | abarth@chromium.org | 2008-12-15 21:56:46 +0100 (Mon, 15 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Cleanup IsExecutableMimeType.

R=cpu

Review URL: http://codereview.chromium.org/14417
------------------------------------------------------------------------
r7000 | sidchat@google.com | 2008-12-15 21:18:04 +0100 (Mon, 15 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h

Add "Enable spell check for this field" menu option in sub context menu for context menu over text box, and deploy its functionality accordingly across the code. This patch also allows manual switch-on of spell check in single line text box fields.

Review URL: http://codereview.chromium.org/13731
------------------------------------------------------------------------
r6996 | sky@google.com | 2008-12-15 20:28:28 +0100 (Mon, 15 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h

Fixes cookies view regression where I broke deleting by way of delete
key. I broke this when I added an observer method for the deletion so
that overriding key down no longer works.

BUG=5472
TEST=see bug

Review URL: http://codereview.chromium.org/14430
------------------------------------------------------------------------
r6991 | sky@google.com | 2008-12-15 19:07:06 +0100 (Mon, 15 Dec 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h

Changes the bookmark bubble to have the following logic:
. We only apply edits when the bubble is closed (previously selecting
  a different folder resulted in an immediate action).
. Hitting escape cancels any edits.
. When the bubble is shown for newly bookmarked items hitting escape
  removes the bookmark.
. If you click 'Edit...' or select 'Choose another folder...' any
  edits are applied immediately before the editor is shown.

BUG=5015
TEST=thorougly test the bookmark bubble to make sure I haven't broken
  anything.

Review URL: http://codereview.chromium.org/14074
------------------------------------------------------------------------
r6974 | mbelshe@google.com | 2008-12-13 21:48:36 +0100 (Sat, 13 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/system_monitor.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   D /trunk/src/chrome/browser/suspend_controller.cc
   D /trunk/src/chrome/browser/suspend_controller.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/views/widget_win.h

A new shot at the old system monitor changelist.

Review URL: http://codereview.chromium.org/12883
------------------------------------------------------------------------
r6972 | wtc@google.com | 2008-12-13 19:27:23 +0100 (Sat, 13 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h

Remove all the CHECKs I added to debug issue 4749.

TBR=eroman
BUG=4749
Review URL: http://codereview.chromium.org/14108
------------------------------------------------------------------------
r6968 | ericroman@google.com | 2008-12-13 05:52:01 +0100 (Sat, 13 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/http/http_transaction_winhttp.h
   M /trunk/src/net/http/http_transaction_winhttp_unittest.cc
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   D /trunk/src/net/url_request/url_request_context.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Reverting 6966.

this failed UI tests catastrophically
Review URL: http://codereview.chromium.org/14103
------------------------------------------------------------------------
r6966 | ericroman@google.com | 2008-12-13 04:44:24 +0100 (Sat, 13 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/http/http_transaction_winhttp.h
   M /trunk/src/net/http/http_transaction_winhttp_unittest.cc
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/proxy/proxy_script_fetcher_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   A /trunk/src/net/url_request/url_request_context.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Use automatic memory management for URLRequestContext's members.
Also make ProxyService refcounted so the sharing between profiles is explicit.

Review URL: http://codereview.chromium.org/13701
------------------------------------------------------------------------
r6953 | estade@chromium.org | 2008-12-13 00:43:03 +0100 (Sat, 13 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/spellchecker.cc

revert r6938

(i.e. reapply 6935, with fix)
Review URL: http://codereview.chromium.org/14087
------------------------------------------------------------------------
r6951 | wtc@google.com | 2008-12-13 00:25:28 +0100 (Sat, 13 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Remove a CHECK in RemovePendingRequest that asserts a
condition that could be false in the new HTTP stack.

R=rvargas
BUG=4749
Review URL: http://codereview.chromium.org/13799
------------------------------------------------------------------------
r6948 | brettw@google.com | 2008-12-13 00:07:42 +0100 (Sat, 13 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/gfx/native_theme.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/common/gfx/color_utils.cc
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/single_split_view.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/skia/ext/platform_device_win.cc
   M /trunk/src/skia/ext/skia_utils.cc
   M /trunk/src/skia/ext/skia_utils.h
   M /trunk/src/skia/ext/skia_utils_win.cc
   M /trunk/src/skia/ext/skia_utils_win.h
   M /trunk/src/skia/ext/vector_device.cc
   M /trunk/src/webkit/port/platform/graphics/chromium/FontChromiumWin.cpp
   M /trunk/src/webkit/port/rendering/RenderThemeWin.cpp

Move skia_utils into the skia namespace.
Review URL: http://codereview.chromium.org/14079
------------------------------------------------------------------------
r6942 | erg@google.com | 2008-12-12 23:34:30 +0100 (Fri, 12 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   A /trunk/src/chrome/test/data/constrained_files/window_blur_test.html

Test to make sure issue 4737 doesn't regress.
Review URL: http://codereview.chromium.org/13800
------------------------------------------------------------------------
r6940 | tc@google.com | 2008-12-12 23:17:35 +0100 (Fri, 12 Dec 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/locales/ar.vcproj
   M /trunk/src/chrome/app/locales/bg.vcproj
   M /trunk/src/chrome/app/locales/bn.vcproj
   M /trunk/src/chrome/app/locales/ca.vcproj
   M /trunk/src/chrome/app/locales/cs.vcproj
   M /trunk/src/chrome/app/locales/da.vcproj
   M /trunk/src/chrome/app/locales/de.vcproj
   M /trunk/src/chrome/app/locales/el.vcproj
   M /trunk/src/chrome/app/locales/en-GB.vcproj
   M /trunk/src/chrome/app/locales/en-US.vcproj
   M /trunk/src/chrome/app/locales/es-419.vcproj
   M /trunk/src/chrome/app/locales/es.vcproj
   M /trunk/src/chrome/app/locales/et.vcproj
   M /trunk/src/chrome/app/locales/fi.vcproj
   M /trunk/src/chrome/app/locales/fil.vcproj
   M /trunk/src/chrome/app/locales/fr.vcproj
   M /trunk/src/chrome/app/locales/gu.vcproj
   M /trunk/src/chrome/app/locales/he.vcproj
   M /trunk/src/chrome/app/locales/hi.vcproj
   M /trunk/src/chrome/app/locales/hr.vcproj
   M /trunk/src/chrome/app/locales/hu.vcproj
   M /trunk/src/chrome/app/locales/id.vcproj
   M /trunk/src/chrome/app/locales/it.vcproj
   M /trunk/src/chrome/app/locales/ja.vcproj
   M /trunk/src/chrome/app/locales/kn.vcproj
   M /trunk/src/chrome/app/locales/ko.vcproj
   M /trunk/src/chrome/app/locales/lt.vcproj
   M /trunk/src/chrome/app/locales/lv.vcproj
   M /trunk/src/chrome/app/locales/ml.vcproj
   M /trunk/src/chrome/app/locales/mr.vcproj
   M /trunk/src/chrome/app/locales/nb.vcproj
   M /trunk/src/chrome/app/locales/nl.vcproj
   M /trunk/src/chrome/app/locales/or.vcproj
   M /trunk/src/chrome/app/locales/pl.vcproj
   M /trunk/src/chrome/app/locales/pt-BR.vcproj
   M /trunk/src/chrome/app/locales/pt-PT.vcproj
   M /trunk/src/chrome/app/locales/ro.vcproj
   M /trunk/src/chrome/app/locales/ru.vcproj
   M /trunk/src/chrome/app/locales/sk.vcproj
   M /trunk/src/chrome/app/locales/sl.vcproj
   M /trunk/src/chrome/app/locales/sr.vcproj
   M /trunk/src/chrome/app/locales/sv.vcproj
   M /trunk/src/chrome/app/locales/ta.vcproj
   M /trunk/src/chrome/app/locales/te.vcproj
   M /trunk/src/chrome/app/locales/th.vcproj
   M /trunk/src/chrome/app/locales/tr.vcproj
   M /trunk/src/chrome/app/locales/uk.vcproj
   M /trunk/src/chrome/app/locales/vi.vcproj
   M /trunk/src/chrome/app/locales/zh-CN.vcproj
   M /trunk/src/chrome/app/locales/zh-TW.vcproj
   M /trunk/src/chrome/app/resources/SConscript
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/debugger/debugger.scons
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/renderer/renderer.scons
   M /trunk/src/chrome/tools/build/win/language_dll.vsprops
   M /trunk/src/chrome/tools/build/win/using_generated_strings.vsprops
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/tools/grit/build/grit_resource_file.bat
   M /trunk/src/tools/grit/build/grit_resource_file.rules
   M /trunk/src/webkit/SConscript
   M /trunk/src/webkit/build/glue/glue.vsprops
   M /trunk/src/webkit/build/localized_strings/SConscript
   M /trunk/src/webkit/build/localized_strings/localized_strings.vcproj
   M /trunk/src/webkit/default_plugin/default_plugin.vsprops
   M /trunk/src/webkit/tools/test_shell/SConscript
   M /trunk/src/webkit/tools/test_shell/test_shell.vcproj
   M /trunk/src/webkit/tools/test_shell/test_shell.vsprops

Have GRIT generate files into a common directory.

Joi has convinced me that GRIT should generate platform specific
resources files.  This is easier than parsing .rc files because
GRIT effectively has an .rc parser.  To that end, we need to
convert some existing .rc files to .grd files (e.g., net_resources.rc
and webkit_resources.rc).  Rather than having every grd file output
to a different place and -I all the different paths, have GRIT
generate all files into one directory.  This directory is
grit_derived_sources.

Review URL: http://codereview.chromium.org/13776
------------------------------------------------------------------------
r6938 | ojan@google.com | 2008-12-12 23:12:43 +0100 (Fri, 12 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/spellchecker.cc

Reverting 6935.

Broke compile
Review URL: http://codereview.chromium.org/14083
------------------------------------------------------------------------
r6935 | estade@chromium.org | 2008-12-12 23:05:23 +0100 (Fri, 12 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/spellchecker.cc

Implement the memory mapped file class for posix.

Review URL: http://codereview.chromium.org/14073
------------------------------------------------------------------------
r6921 | brettw@google.com | 2008-12-12 21:19:14 +0100 (Fri, 12 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/webkit/port/platform/graphics/skia/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/skia/NativeImageSkia.cpp

Move Image operations and convolver to the skia namespace and clean up a few (but not all) base types.
Review URL: http://codereview.chromium.org/13726
------------------------------------------------------------------------
r6920 | brettw@google.com | 2008-12-12 21:16:50 +0100 (Fri, 12 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/common/property_bag.cc
   M /trunk/src/chrome/common/property_bag.h

Add PropertyBag to TabContents. Convert the autocomplete state as a proof of concept. Add necessary const accessors to property bag.

BUG=5260
Review URL: http://codereview.chromium.org/13707
------------------------------------------------------------------------
r6919 | estade@chromium.org | 2008-12-12 21:12:38 +0100 (Fri, 12 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Add a MemoryMappedFile class to file_util.

Factor out windowisms from the spell checker.

Review URL: http://codereview.chromium.org/14041
------------------------------------------------------------------------
r6909 | sky@google.com | 2008-12-12 20:00:57 +0100 (Fri, 12 Dec 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/dock_info.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h

During tab dragging if you hover over a browser window we now move it
to front after a delay. Also made docking to another window bring the
other window to front.

BUG=2038
TEST=Create two window with two tabs each. Drag a tab from one window
  onto the other window (not the tab area), hold it for a second and
  make sure the other window comes to front.

Review URL: http://codereview.chromium.org/14057
------------------------------------------------------------------------
r6907 | erg@google.com | 2008-12-12 19:50:39 +0100 (Fri, 12 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix onblur= handelers getting called on popup window creation. This regressed in r5417.

ISSUE=http://crbug.com/4737
Review URL: http://codereview.chromium.org/13271
------------------------------------------------------------------------
r6904 | sky@google.com | 2008-12-12 19:40:24 +0100 (Fri, 12 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Makes open all work again on the bookmark bar's context menu.

BUG=4540
TEST=Right click on the bookmark bar (not over a button) and make sure
  open all opens all the bookmarks on the bookmark bar.

Review URL: http://codereview.chromium.org/13790
------------------------------------------------------------------------
r6902 | sky@google.com | 2008-12-12 19:32:22 +0100 (Fri, 12 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Fixes bookmark menus so that they align properly when rtl.

BUG=5418
TEST=see bug

Review URL: http://codereview.chromium.org/14053
------------------------------------------------------------------------
r6890 | sky@google.com | 2008-12-12 17:54:44 +0100 (Fri, 12 Dec 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Changes bookmark manager's import to show a description in the files
of type instead of *.html.

BUG=4479
TEST=Bring up the bookmark manager, click tools->import. Make sure the
  import dialog 'files of type' has something like 'Chrome Document'
  (although this depends upon your registry), and that selecting it
  shows all html and htm files. Additionally make sure you have 'all
  files' in the 'files of type' combobox too.

Review URL: http://codereview.chromium.org/14025
------------------------------------------------------------------------
r6886 | phajdan.jr@chromium.org | 2008-12-12 13:00:40 +0100 (Fri, 12 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/test_file_util.h
   M /trunk/src/base/test_file_util_linux.cc
   M /trunk/src/base/test_file_util_mac.cc
   M /trunk/src/base/test_file_util_win.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/chrome.scons
   M /trunk/src/chrome/test/perf/perftests.cc
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc

Port flush_cache tool and perf_tests.

BUG=4160,4263

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6815
Review URL: http://codereview.chromium.org/9639
------------------------------------------------------------------------
r6885 | phajdan.jr@chromium.org | 2008-12-12 12:33:28 +0100 (Fri, 12 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   A /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   A /trunk/src/chrome/browser/importer/firefox_profile_lock_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc

browser porting, part 2 - importer
Review URL: http://codereview.chromium.org/12688
------------------------------------------------------------------------
r6878 | abarth@chromium.org | 2008-12-12 04:26:07 +0100 (Fri, 12 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Once we've decided that a path doesn't exist, reserve it by creating an empty file so that we don't later think that the same path doesn't exist.

BUG=3662
R=paulg

Review URL: http://codereview.chromium.org/13336
------------------------------------------------------------------------
r6868 | glen@chromium.org | 2008-12-12 02:40:21 +0100 (Fri, 12 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Reduce the amount of space between the location bar and the bookmark bar by allowing the bookmark bar to overlap the toolbar when 'always shown'. This reduces the total height of the toolbar stack by 4 pixels and makes it look better.
Review URL: http://codereview.chromium.org/12668
------------------------------------------------------------------------
r6839 | ojan@google.com | 2008-12-12 00:03:32 +0100 (Fri, 12 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/unload_uitest.cc
   D /trunk/src/chrome/test/data/unload

Move to using data URLs for unload tests and generally
cleanup the unload tests in preparation for adding
in tests for beforeunload.
Review URL: http://codereview.chromium.org/14017
------------------------------------------------------------------------
r6836 | sky@google.com | 2008-12-11 23:36:47 +0100 (Thu, 11 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html

Changes new tab page to show recently closed window correctly.

BUG=4804
TEST=none

Review URL: http://codereview.chromium.org/13760
------------------------------------------------------------------------
r6826 | agl@chromium.org | 2008-12-11 22:50:41 +0100 (Thu, 11 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/base/gfx/native_widget_types.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkit_glue_gtk.cc
   M /trunk/src/webkit/glue/webkit_glue_win.cc
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/port/platform/chromium/PlatformWidget.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.h
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webview_host_win.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Rename ViewHandle to NativeView et al.

ViewHandle is a very unfortunate name when we actually start dealing with
views, so we are renaming the cross-platform typedefs to make it clear
that they refer to platform specific native UI elements.

Review URL: http://codereview.chromium.org/13754

------------------------------------------------------------------------
r6822 | wtc@google.com | 2008-12-11 22:13:55 +0100 (Thu, 11 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Change the sense of a CHECK to see if the opposite
condition is ever false.

R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/13370
------------------------------------------------------------------------
r6817 | jungshik@google.com | 2008-12-11 21:30:49 +0100 (Thu, 11 Dec 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc

A follow-up to a recent unforking of WebCore/platform/text/TextCodecICU.cpp (r6540).
Up to now, we canonicalized to EUC-KR, TIS-620 and GB2312, but with
unforking, we'd better canonicalize to windows-949, windows-874 and GBK.

Another change is necessary in Webkit (Document.cpp), which I'll do it while unforking it. 

BUG=3703

Review URL: http://codereview.chromium.org/13645
------------------------------------------------------------------------
r6816 | phajdan.jr@chromium.org | 2008-12-11 21:14:13 +0100 (Thu, 11 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/test_file_util.h
   M /trunk/src/base/test_file_util_linux.cc
   M /trunk/src/base/test_file_util_mac.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/chrome.scons
   M /trunk/src/chrome/test/perf/perftests.cc
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc

Reverting 6815.
Review URL: http://codereview.chromium.org/14006
------------------------------------------------------------------------
r6815 | phajdan.jr@chromium.org | 2008-12-11 21:03:54 +0100 (Thu, 11 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/test_file_util.h
   M /trunk/src/base/test_file_util_linux.cc
   M /trunk/src/base/test_file_util_mac.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/chrome.scons
   M /trunk/src/chrome/test/perf/perftests.cc
   M /trunk/src/chrome/test/perf/perftests.scons
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc

Port flush_cache tool and perf_tests.

BUG=4160,4263
Review URL: http://codereview.chromium.org/9639
------------------------------------------------------------------------
r6807 | pkasting@chromium.org | 2008-12-11 20:20:26 +0100 (Thu, 11 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Try and make some spellcheck code more obvious by using typedefs.

I am not convinced this patch is a net win.  Please share your thoughts on if using a Language/Languages set of types is better or worse than what we're doing now.
Review URL: http://codereview.chromium.org/13367
------------------------------------------------------------------------
r6806 | phajdan.jr@chromium.org | 2008-12-11 20:16:00 +0100 (Thu, 11 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Clean up about box for unofficial builds.

Currently unofficial builds (Chromium) display there an error message
that update server is unavailable. This is obvious (there is no update
server for trunk builds), but looks bad. This patch removes
the message for unofficial builds.
Review URL: http://codereview.chromium.org/13352
------------------------------------------------------------------------
r6805 | wtc@google.com | 2008-12-11 20:15:59 +0100 (Thu, 11 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_policy.cc

Remove a stale comment.  net::ERR_CERT_UNABLE_TO_CHECK_REVOCATION
now causes the security style to be set to authentication broken.
(The security style is set elsewhere, not here, but this comment
is still confusing.)

R=jcampan
BUG=4749
Review URL: http://codereview.chromium.org/13371
------------------------------------------------------------------------
r6792 | phajdan.jr@chromium.org | 2008-12-11 18:59:58 +0100 (Thu, 11 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix extensions_service_unittest on Linux.

I was getting failures which are not present on buildbot,
I don't know why. But with these changes it should be more solid.

This also prevents a segfault which I got (out of bounds array access).
Review URL: http://codereview.chromium.org/13258
------------------------------------------------------------------------
r6789 | phajdan.jr@chromium.org | 2008-12-11 16:33:26 +0100 (Thu, 11 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Reverting 6787. inteded to commit other changelist.
Review URL: http://codereview.chromium.org/13387
------------------------------------------------------------------------
r6787 | phajdan.jr@chromium.org | 2008-12-11 16:27:30 +0100 (Thu, 11 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix extensions_service_unittest on Linux.

I was getting failures which are not present on buildbot,
I don't know why. But with these changes it should be more solid.

This also prevents a segfault which I got (out of bounds array access).
Review URL: http://codereview.chromium.org/13258
------------------------------------------------------------------------
r6784 | avi@google.com | 2008-12-11 15:55:12 +0100 (Thu, 11 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/greasemonkey_master.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/user_data_manager.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/disk_cache/cache_util_posix.cc
   M /trunk/src/net/tools/dump_cache/dump_files.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc

Move file enumeration to filepaths.

Review URL: http://codereview.chromium.org/13315
------------------------------------------------------------------------
r6777 | sky@google.com | 2008-12-11 04:59:44 +0100 (Thu, 11 Dec 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h

Fixes a handful of related bookmark manager bugs/requests:

. Adds a search field before the text field.
. When the search node is selected and there are no results or no
  search text, a descriptive label is drawn on top of the table
  telling the user what's happening.
. In the bookmark menus Edit... is now Rename... for folders.

BUG=5272 5319 5273 4165
TEST=see individual bugs

Review URL: http://codereview.chromium.org/13724
------------------------------------------------------------------------
r6776 | sky@google.com | 2008-12-11 04:36:50 +0100 (Thu, 11 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/sessions/session_restore.cc

Fixes two session restore bugs:

. If the user launches incognito we don't attempt to restore last
  session and instead just do default launch behavior (new tab page).
. Don't show the session restore info bar when launched incognito. I'm
  assuming that if the user launched in incognito they were previously
  running incognito so that there is nothing to restore.

BUG=4381 5119
TEST=turn on session restore and launch with --incognito, make sure
  the incognito window comes up.

Review URL: http://codereview.chromium.org/13368
------------------------------------------------------------------------
r6766 | pkasting@chromium.org | 2008-12-11 02:04:07 +0100 (Thu, 11 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/spellcheck_unittest.cc

Missed this file in my previous cleanup patch.
Review URL: http://codereview.chromium.org/13729
------------------------------------------------------------------------
r6764 | sky@google.com | 2008-12-11 01:41:26 +0100 (Thu, 11 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Only allow bookmark keyboard shortcut for tabbed browsers.

BUG=5055
TEST=make sure control-d does nothing for apps and popup windows

Review URL: http://codereview.chromium.org/13363
------------------------------------------------------------------------
r6760 | pkasting@chromium.org | 2008-12-11 01:20:45 +0100 (Thu, 11 Dec 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h

Better build bustage fix: Commit the rest of the original patch.  Rolls back the previous blind fix I tried.
------------------------------------------------------------------------
r6759 | pkasting@chromium.org | 2008-12-11 01:05:22 +0100 (Thu, 11 Dec 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h

Blind attempt at build fix.  I don't know why this should be necessary.
------------------------------------------------------------------------
r6758 | pkasting@chromium.org | 2008-12-11 00:52:43 +0100 (Thu, 11 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/template_url.cc
   M /trunk/src/chrome/browser/template_url.h
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/template_url_unittest.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h

Make the autocomplete system and various other connected bits of code use GURL instead of wstring where appropriate.  Original patch by phajdan.jr@gmail.com, r=me,sky.  See http://codereview.chromium.org/13205 .

BUG=715234
------------------------------------------------------------------------
r6753 | pkasting@chromium.org | 2008-12-11 00:08:55 +0100 (Thu, 11 Dec 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.h

Another attempted, untested build fix.
------------------------------------------------------------------------
r6748 | finnur@google.com | 2008-12-10 23:31:07 +0100 (Wed, 10 Dec 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc

Fix regression with Find in page focus on trunk. 

Basically, if the Find box is open, pressing Ctrl+F should
set focus to the text field. This regressed when the Find
box moved into web_contents_view. 

I have added a UI test to catch this in the future.

Review URL: http://codereview.chromium.org/13721
------------------------------------------------------------------------
r6746 | wtc@google.com | 2008-12-10 23:30:18 +0100 (Wed, 10 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h

Remove the unneeded CHECKs.  Add a CHECK to determine
whether the recursive call to RemovePendingRequest is
removing the same or a different request.

R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/13329
------------------------------------------------------------------------
r6745 | pkasting@chromium.org | 2008-12-10 23:28:58 +0100 (Wed, 10 Dec 2008) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Cleanup part 6.

Lots of small things (mostly in spellcheck code), e.g.:
* L"" -> std::wstring()
* type *var; -> type* var;
* Fix parameter line-wrapping to comply with style guide
* Remove unnecessary classname scoping inside class delcaration
* Remove empty declaration
* Add/remove blank lines in hopes of increasing readability
* Add block ("{", "}") around local use of a temporary that is later redefined
* Fold temps into other statements where obvious
* Use std::find() instead of hand-rolling the same functionality
* Combine distinct cases in switch statements when they all do the same thing
* Range-check to avoid some algorithmic work when it's not needed
* at() -> []

...and various others.  Pretty much every change stands on its own.  Do not hesitate to complain about changes you think are unhelpful to the code, this change is something of a dumping ground.  (I did try to avoid the sort of gratuitous "const"-adding that has gotten me in trouble before :). )
Review URL: http://codereview.chromium.org/13688
------------------------------------------------------------------------
r6721 | pkasting@chromium.org | 2008-12-10 19:49:10 +0100 (Wed, 10 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Cleanup part 5.

Reorder identifiers, functions, initalization statements, etc. to all match.  This preserves the original groups Ben created but makes a couple of changes:
* Within each group, the order is now "by GUI order" instead of random.  This can be subjective, but when I tried doing alphabetical order, it resulted in related functionality being separated pretty arbitrarily.
* I moved the "window management" functions next to (but above) the "page-related" functions (this seemed a little more logical, but maybe not)

I also renamed UpdateNavigationCommands() to try and reflect that it updates a lot more than navigation commands, and moved some unconditionally-initialized commands (profile stuff) in there over to InitCommandState() where they belong.
Review URL: http://codereview.chromium.org/13681
------------------------------------------------------------------------
r6717 | sky@google.com | 2008-12-10 19:14:04 +0100 (Wed, 10 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h

Fixes regression in info bubble that caused crash on clicking star on
history page.

BUG=4397
TEST=go to history page, click on a star and make sure star bubble
  pops up.

Review URL: http://codereview.chromium.org/13349
------------------------------------------------------------------------
r6714 | sky@google.com | 2008-12-10 18:22:32 +0100 (Wed, 10 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_utils_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Changes bookmark manager search to use contains vs starts with and to
search urls.

BUG=4065
TEST=create the URL foo.com and type 'foo.com' in the bookmark manager
search box. Make sure the url you just typed shows up in the table.

Review URL: http://codereview.chromium.org/13679
------------------------------------------------------------------------
r6713 | sky@google.com | 2008-12-10 18:17:56 +0100 (Wed, 10 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/ie_importer.cc

Adds NULL checks for LoadLibrary and GetProcAddress calls in
IEImporter. As far as I could tell the crash was because LoadLibrary
returned null.

BUG=3897
TEST=none

Review URL: http://codereview.chromium.org/13319
------------------------------------------------------------------------
r6710 | brettw@google.com | 2008-12-10 17:16:35 +0100 (Wed, 10 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/NativeImageSkia.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell_tests.vcproj

Reverting 6709,6708,6706.
Review URL: http://codereview.chromium.org/13345
------------------------------------------------------------------------
r6706 | brettw@google.com | 2008-12-10 16:01:10 +0100 (Wed, 10 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/skia/ext/convolver.cc
   M /trunk/src/skia/ext/convolver.h
   M /trunk/src/skia/ext/convolver_unittest.cc
   M /trunk/src/skia/ext/image_operations.cc
   M /trunk/src/skia/ext/image_operations.h
   M /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/NativeImageSkia.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell_tests.vcproj

Remove base dependency from image_operations and associated unittests. I also renamed the namespace from "gfx" to "skia".

This also adds back the image_operations_unittest to a project (this had gotten lost in my move).
Review URL: http://codereview.chromium.org/13143
------------------------------------------------------------------------
r6693 | ericroman@google.com | 2008-12-10 05:11:27 +0100 (Wed, 10 Dec 2008) | 29 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/http/http_transaction_winhttp.h
   M /trunk/src/net/http/http_transaction_winhttp_unittest.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Misc proxy service changes.

(1) Changed the proxy service ownership model -- rather than being a
detail of the HTTP stack, it is now a dependency owned by
UrlRequestContext.
 - ProxyService is owned by UrlRequestContext (before was
   HttpNetworkSession)
 - ProxyResolver is owned by ProxyService (before was
   HttpNetworkSession)

Being able to share the proxy service is needed in several places,
including incognito mode http context (http://crbug.com/3564), and for
proxy resolving in the new FTP stack.

(2) Added an IPC for getting of the ProxyResolverWinHttp dependency in
the plugin process. Not hooked up yet, but intent is to route the
proxy resolve requests through the browser process.

(3) Changed some unit tests which were depending on the system proxy
settings (this was a sideffect of their calling
HttpNetworkLayer::CreateFactory(NULL)).

(4) Moved the first-time ProxyService::UpdateConfig out of the
constructor and into the initial request. Done to avoid startup
perf regressions, since the ProxyService construction is now done
earlier (on the startup critical path).

BUG=3564
Review URL: http://codereview.chromium.org/12938
------------------------------------------------------------------------
r6670 | finnur@google.com | 2008-12-10 01:31:45 +0100 (Wed, 10 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/link.h

Fixing 4687: Enter in FirstRun UI starts import when Customize link is focued.

We now properly handle Enter when links are focused. I also made it so that links navigate on KeyDown (when you press Enter or Space) instead of on KeyUp. This matches WebKit and native Windows behavior.
Review URL: http://codereview.chromium.org/13321
------------------------------------------------------------------------
r6651 | cpu@google.com | 2008-12-10 00:16:58 +0100 (Wed, 10 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

First run is going into infinite recursion if started from master prefs
- keeps creating importer processes
- the issue is the creation of the first run sentinel file needs to
  happen before starting the new process.

BUG=1535947

Review URL: http://codereview.chromium.org/13312
------------------------------------------------------------------------
r6633 | laforge@chromium.org | 2008-12-09 22:56:31 +0100 (Tue, 09 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Fixed a link in the about_credits.html
Bug: 4793: about:credits LIBXSLT bad homepage link
TBR=laforge@chromium.org
------------------------------------------------------------------------
r6628 | pkasting@chromium.org | 2008-12-09 22:24:11 +0100 (Tue, 09 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/theme/frozen_plugin.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Cleanup part 4.

Remove dead/unnecessary resources/identifiers/code.

The trickiest bit of this to review are the browser.cc changes, where various commands are no longer initialized multiple times.
Review URL: http://codereview.chromium.org/13648
------------------------------------------------------------------------
r6627 | pinkerton@google.com | 2008-12-09 22:20:16 +0100 (Tue, 09 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_exe_main.mm
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/browser_main_mac.mm
   A /trunk/src/chrome/browser/browser_main_win.cc
   A /trunk/src/chrome/browser/browser_main_win.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/sandbox/src/sandbox.h

step one of some refactoring to allow other platforms to re-use the app initialization code.
Review URL: http://codereview.chromium.org/13295
------------------------------------------------------------------------
r6622 | wtc@google.com | 2008-12-09 21:52:58 +0100 (Tue, 09 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h

Now we know the delete iter->second call in
RemovePendingRequest causes a request to be removed
from pending_requests_.  Add the removing_pending_request_
member and some DCHECKS to catch that in action.

R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/13270
------------------------------------------------------------------------
r6615 | glen@chromium.org | 2008-12-09 21:21:26 +0100 (Tue, 09 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc

Let the debugger work again. Error was due to me not noticing the change in debugger URL.

BUG=5287


Review URL: http://codereview.chromium.org/13298
------------------------------------------------------------------------
r6606 | finnur@google.com | 2008-12-09 20:21:46 +0100 (Tue, 09 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble.h

Fix a memory leak in the StatusBubble. We were leaking a
WidgetWin for the popup.

I observed this in Purify and confirmed in the debugger 
that the destructor for WidgetWin was never called.

Review URL: http://codereview.chromium.org/13672
------------------------------------------------------------------------
r6604 | sky@google.com | 2008-12-09 20:16:02 +0100 (Tue, 09 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc

Adds QueryParser::ExtractQueryWords. For consistent this should
probably be ParseQuery, but I couldn't bring myself to another
ParseQuery method. I'm going to need this for bookmark queries.

BUG=4065
TEST=none

Review URL: http://codereview.chromium.org/13296
------------------------------------------------------------------------
r6599 | glen@chromium.org | 2008-12-09 19:44:11 +0100 (Tue, 09 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Slightly updated about:credits from dannyb.

Review URL: http://codereview.chromium.org/13292
------------------------------------------------------------------------
r6595 | sky@google.com | 2008-12-09 19:25:38 +0100 (Tue, 09 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc

Changes query parser to sort and coalesce overlapping match positions.

BUG=5305
TEST=see bug

Review URL: http://codereview.chromium.org/13666
------------------------------------------------------------------------
r6589 | sky@google.com | 2008-12-09 18:34:17 +0100 (Tue, 09 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc

Moves some utility functions out of bookmark model into
bookmark_utils. In addition I've converted to using
TreeNodeIterator. This doesn't contain any functionality changes.

BUG=4065
TEST=none

Review URL: http://codereview.chromium.org/13642
------------------------------------------------------------------------
r6587 | finnur@google.com | 2008-12-09 17:10:06 +0100 (Tue, 09 Dec 2008) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

I tried running the browser in Purify and the browser crashed on me. 
Basically, the animations were really slow and at one point I got 
a NULL pointer read because TabContents was NULL while updating 
the animations. 

Call stack:

    TabContents::is_loading(void)const [browser\tab_contents.h:214]
    Browser::IsCurrentPageLoading(void)const [browser\browser.cc:400]
    BrowserView::LoadingAnimationCallback(void) [browser\views\frame\browser_view.cc:1325]
    ... removed Timer calls for clarity...

We already check the return value of GetSelectedTabContents in many 
places. It makes sense to do it here also, I think.

Review URL: http://codereview.chromium.org/13647
------------------------------------------------------------------------
r6562 | jungshik@google.com | 2008-12-09 01:40:56 +0100 (Tue, 09 Dec 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Make the spellcheck-context-menu generation code more robust/future-proof (fil and fil-PH will match each other). 
Currently, en-AU, de-CH, fr-CA do not match any spellcheck language. With
this change, they will match en-US, de-DE, fr-FR, respectively unless 
there's an exact (more specific) match. Matching en-{AU,NZ,ZA} with en-US
is not ideal.

BUG=5251
TEST=Add 'fr-CA' (but NOT fr or fr-FR) to the accept-language list and see if 'fr-FR' comes up
in the list of spell-check languages in the context menu of a textarea. Add 'de' (but not de-DE) to a-l list and see if 'de-DE' comes up in the list of spell-check languages in the context menu. 


Review URL: http://codereview.chromium.org/13262
------------------------------------------------------------------------
r6551 | pkasting@chromium.org | 2008-12-09 00:04:54 +0100 (Tue, 09 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/browser/browser.cc

Cleanup part 3.

This changes only whitespace, no code change at all.

Attempt to make a couple of long multi-column chunks of text more readable by putting everything within the block at the same offsets.  In the case of the .rc file, the entire file is now consistently indented.  No lines I'm touching go over 80 columns.

What I'm doing to browser.cc here we already do in a few (shorter) cases elsewhere, I think to good effect.
Review URL: http://codereview.chromium.org/13641
------------------------------------------------------------------------
r6549 | pkasting@chromium.org | 2008-12-09 00:04:48 +0100 (Tue, 09 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Cleanup part 2.

Add appcommands that we have browser commands for.

BUG=1113069
Review URL: http://codereview.chromium.org/13639
------------------------------------------------------------------------
r6545 | wtc@google.com | 2008-12-08 22:57:11 +0100 (Mon, 08 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

The CHECK I added in r6458 fails.  So I'm refining that
CHECK to narrow down where it starts to fail.

R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/13634
------------------------------------------------------------------------
r6536 | finnur@google.com | 2008-12-08 21:51:48 +0100 (Mon, 08 Dec 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Fix 1955: Show Chromium build number after version (Chromium only)

People download random builds of Chromium off our server. This makes it easier
for them to figure out what build number they are using by showing it in the 
About box (in parenthesis right after the version number).

This change does not change the way we display versions in Google Chrome.

Review URL: http://codereview.chromium.org/13194
------------------------------------------------------------------------
r6535 | pkasting@chromium.org | 2008-12-08 21:50:05 +0100 (Mon, 08 Dec 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/sessions/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/view_source_uitest.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/views/text_field.cc

Cleanup, part 1.

* Consistently use underscores between words in identifiers (IDC_NEWTAB -> IDC_NEW_TAB)
* Make some identifiers clearer or more up-to-date (IDC_DUPLICATE -> IDC_DUPLICATE_TAB, IDC_GOOFFTHERECORD -> IDC_NEW_INCOGNITO_WINDOW, IDC_NEWPROFILEWINDOW -> IDC_PROFILE_MENU)
* Try and make string identifiers (IDS_xxx) match their corresponding IDC_xxx commands.  Tony tells me this will not cause any need for retranslation.
* As much as possible (without modifying automated UI test XML files), use "Bookmark Bar", not "Bookmarks Bar" (this seemed to be prevailing usage in the code)
* Fix 80-column issues

This patch touches move files than any subsequent patches, but should be the most rubber-stampable.

Review URL: http://codereview.chromium.org/13633
------------------------------------------------------------------------
r6532 | finnur@google.com | 2008-12-08 21:29:43 +0100 (Mon, 08 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/webkit/glue/webframe_impl.cc

Fixing 5132: Find-in-page reports wrong ordinal when restarting search in sub-frame

ReportFindInPageSelection calls OrdinalOfFirstMatchForFrame internally, so we don't need to do it again at the call site.

Added a test to catch this in the future.

Review URL: http://codereview.chromium.org/13190
------------------------------------------------------------------------
r6528 | tc@google.com | 2008-12-08 20:17:10 +0100 (Mon, 08 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc

bad merge, no need to delete a scoped_ptr

TBR=aa

Review URL: http://codereview.chromium.org/13252

------------------------------------------------------------------------
r6525 | sky@google.com | 2008-12-08 20:00:24 +0100 (Mon, 08 Dec 2008) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Fixes bug during tab close that results in all tabs after closed tab
getting shifted to the left by one pixel. Forcing another layout (by
resizing window or such) results in everything fixing itself.

When closing a tab we resize the closed tabs width to
Tab::GetMinimumUnselectedSize().width(). Subsequent tabs are
positioned at width +
kTabHOffset. Tab::GetMinimumUnselectedSize().width() is 15, where as
kTabHOffset is -16, resulting in all subsequent tabs shifting to the
left by 1.

You'll have to tell me if this is the right fix. I suspect this could
also be fixed by changing Tab::GetMinimumUnselectedSize().width() to
be kTabHOffset, but I'm not sure what the effects of that are. We
could also enforce next x not shifting back in AnimationLayout

BUG=none
TEST=create two tabs, select the first and close it. Resize the window
a bit and make sure the tab doesn't shift to the right.

Review URL: http://codereview.chromium.org/13625
------------------------------------------------------------------------
r6524 | aa@chromium.org | 2008-12-08 19:43:53 +0100 (Mon, 08 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Fix a leak in ExtensionsService and another in ExtensionsServiceTest.

Review URL: http://codereview.chromium.org/13610
------------------------------------------------------------------------
r6522 | aa@chromium.org | 2008-12-08 19:25:00 +0100 (Mon, 08 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   M /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.h
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc

Report errors during extension load. Change all the error strings to utf-8.

Review URL: http://codereview.chromium.org/13229
------------------------------------------------------------------------
r6497 | glen@chromium.org | 2008-12-08 00:48:03 +0100 (Mon, 08 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_resources.h
   M /trunk/src/chrome/browser/browser_resources.rc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_contents.h
   A /trunk/src/chrome/browser/dom_ui/history_ui.cc
   A /trunk/src/chrome/browser/dom_ui/history_ui.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/resources/browser_resources.vcproj
   A /trunk/src/chrome/browser/resources/history.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/browser/site_instance.cc
   M /trunk/src/chrome/browser/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents_type.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.cpp

Reupload of 12418

Review URL: http://codereview.chromium.org/13183
------------------------------------------------------------------------
r6496 | aa@chromium.org | 2008-12-08 00:06:41 +0100 (Mon, 08 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj

Capitalize the 'Extensions' folder in the visual studio project for consistency.

Review URL: http://codereview.chromium.org/13613
------------------------------------------------------------------------
r6495 | dkegel@google.com | 2008-12-07 21:25:46 +0100 (Sun, 07 Dec 2008) | 23 lines
Changed paths:
   M /trunk/src/base/nss_init.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   D /trunk/src/chrome/test/data/ssl/certificates
   M /trunk/src/net/base/ssl_client_socket_nss.cc
   M /trunk/src/net/base/ssl_client_socket_nss.h
   M /trunk/src/net/base/ssl_test_util.cc
   M /trunk/src/net/base/ssl_test_util.h
   M /trunk/src/net/build/net.vcproj
   A /trunk/src/net/data/ssl
   A /trunk/src/net/data/ssl/certificates
   A /trunk/src/net/data/ssl/certificates/expired_cert.pem
   A /trunk/src/net/data/ssl/certificates/invalid_cert.pem
   A /trunk/src/net/data/ssl/certificates/ok_cert.pem
   A /trunk/src/net/data/ssl/certificates/root_ca_cert.crt
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/url_request/url_request_unittest.cc

Third time's a charm?
Fix part of http://code.google.com/p/chromium/issues/detail?id=4510
and improve https support in test shell on linux.

This is the same as the earlier ssl cert cl
(see http://codereview.chromium.org/11249),
but with the certs moved so net can use them without
reaching over into chrome's pants and causing
test failure on the 'modules' Windows build server,
which is set up to test net and base but not chrome.

For this to pass, we will need to install 
the certs on the windows module and try servers.
(And make sure tlslite is present.)

(A later CL will finish implementing SSLInfo for Linux,
and probably reference net/base/ssl_test_util.cc 
from all three vcproj files that need it, 
even though that's ugly, because that's less ugly
that referencing it from net.lib's vcproj.)


Review URL: http://codereview.chromium.org/12930
------------------------------------------------------------------------
r6490 | sky@google.com | 2008-12-06 20:30:19 +0100 (Sat, 06 Dec 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   D /trunk/src/chrome/browser/session_backend.cc
   D /trunk/src/chrome/browser/session_backend.h
   D /trunk/src/chrome/browser/session_backend_unittest.cc
   D /trunk/src/chrome/browser/session_id.h
   D /trunk/src/chrome/browser/session_restore.cc
   D /trunk/src/chrome/browser/session_restore.h
   D /trunk/src/chrome/browser/session_restore_uitest.cc
   D /trunk/src/chrome/browser/session_service.cc
   D /trunk/src/chrome/browser/session_service.h
   D /trunk/src/chrome/browser/session_service_test_helper.cc
   D /trunk/src/chrome/browser/session_service_test_helper.h
   D /trunk/src/chrome/browser/session_service_unittest.cc
   A /trunk/src/chrome/browser/sessions
   A /trunk/src/chrome/browser/sessions/base_session_service.cc
   A /trunk/src/chrome/browser/sessions/base_session_service.h
   A /trunk/src/chrome/browser/sessions/session_backend.cc (from /trunk/src/chrome/browser/session_backend.cc:6356)
   A /trunk/src/chrome/browser/sessions/session_backend.h (from /trunk/src/chrome/browser/session_backend.h:6356)
   A /trunk/src/chrome/browser/sessions/session_backend_unittest.cc (from /trunk/src/chrome/browser/session_backend_unittest.cc:6356)
   A /trunk/src/chrome/browser/sessions/session_command.cc
   A /trunk/src/chrome/browser/sessions/session_command.h
   A /trunk/src/chrome/browser/sessions/session_id.cc
   A /trunk/src/chrome/browser/sessions/session_id.h (from /trunk/src/chrome/browser/session_id.h:6356)
   A /trunk/src/chrome/browser/sessions/session_restore.cc (from /trunk/src/chrome/browser/session_restore.cc:6356)
   A /trunk/src/chrome/browser/sessions/session_restore.h (from /trunk/src/chrome/browser/session_restore.h:6356)
   A /trunk/src/chrome/browser/sessions/session_restore_uitest.cc (from /trunk/src/chrome/browser/session_restore_uitest.cc:6356)
   A /trunk/src/chrome/browser/sessions/session_service.cc (from /trunk/src/chrome/browser/session_service.cc:6356)
   A /trunk/src/chrome/browser/sessions/session_service.h (from /trunk/src/chrome/browser/session_service.h:6356)
   A /trunk/src/chrome/browser/sessions/session_service_test_helper.cc (from /trunk/src/chrome/browser/session_service_test_helper.cc:6356)
   A /trunk/src/chrome/browser/sessions/session_service_test_helper.h (from /trunk/src/chrome/browser/session_service_test_helper.h:6356)
   A /trunk/src/chrome/browser/sessions/session_service_unittest.cc (from /trunk/src/chrome/browser/session_service_unittest.cc:6356)
   A /trunk/src/chrome/browser/sessions/session_types.cc
   A /trunk/src/chrome/browser/sessions/session_types.h
   A /trunk/src/chrome/browser/sessions/tab_restore_service.cc (from /trunk/src/chrome/browser/tab_restore_service.cc:6356)
   A /trunk/src/chrome/browser/sessions/tab_restore_service.h (from /trunk/src/chrome/browser/tab_restore_service.h:6356)
   A /trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc
   D /trunk/src/chrome/browser/tab_restore_service.cc
   D /trunk/src/chrome/browser/tab_restore_service.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/test/ui/ui_tests.scons
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Makes the tab restore service persist closed tabs/windows to disk and
reload them when asked.

Sorry for largish looking change. It's made big by refactoring common
code between TabRestoreService and SessionService into a common
superclass. At the same time I removed some dead code and shuffled the
session related classes into a single directory for easier perusal.

BUG=384
TEST=close the browser, start the browser and make sure the new tab
     page shows closed windows/tabs from the previous session.

Review URL: http://codereview.chromium.org/13152
------------------------------------------------------------------------
r6489 | sky@google.com | 2008-12-06 20:29:28 +0100 (Sat, 06 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fixes possible flicker when tab finishes animating back to dragged
position.

BUG=NONE
TEST=none

Review URL: http://codereview.chromium.org/13221
------------------------------------------------------------------------
r6459 | aa@chromium.org | 2008-12-05 23:14:46 +0100 (Fri, 05 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_reader.h
   M /trunk/src/base/json_reader_unittest.cc
   M /trunk/src/base/values.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/extensions/extensions_service.cc
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/common/json_value_serializer.cc
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/json_value_serializer_perftest.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/installer/util/master_preferences.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Add error messages to JSONReader and friends. This required a bit of refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL.

Review URL: http://codereview.chromium.org/13169
------------------------------------------------------------------------
r6458 | wtc@google.com | 2008-12-05 23:01:11 +0100 (Fri, 05 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Add a CHECK to assert that each invocation of
ResourceDispatcherHost::RemovePendingRequest removes
exactly one URLRequest from pending_requests_.

R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/12977
------------------------------------------------------------------------
r6445 | erikkay@google.com | 2008-12-05 21:26:29 +0100 (Fri, 05 Dec 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h

fix chrome_paths to make some test dirs relative to base::DIR_SOURCE_ROOT
rather than chrome::DIR_APP.  DIR_APP is in different relative locations on
different platforms while DIR_SOURCE_ROOT is the same, so this allows us to
share code and be correct on all platforms.

Also, enable extensions_service_unittest for Mac and Linux and add an 
NSAutoreleasePool to ChromeTestSuite (which is now being used by
run_all_unittests on Mac and Linux per my earlier checkin).

Review URL: http://codereview.chromium.org/13177
------------------------------------------------------------------------
r6442 | munjal@chromium.org | 2008-12-05 21:02:03 +0100 (Fri, 05 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc

UserData Options tab
Plumbing for User Data tab in Options dialog.


Review URL: http://codereview.chromium.org/13150
------------------------------------------------------------------------
r6440 | gwilson@google.com | 2008-12-05 20:36:03 +0100 (Fri, 05 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h

Change "client" parameter in RLZ ping to "referral" 
to match Omaha's changes.

BUG=1520348

Review URL: http://codereview.chromium.org/12975
------------------------------------------------------------------------
r6437 | sidchat@google.com | 2008-12-05 19:32:27 +0100 (Fri, 05 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Fix the layout of the Spell Check Options part, in the languages tab, in the Fonts and Languages Options Menu, to match with the Mock.

Issue=4401
Review URL: http://codereview.chromium.org/12957
------------------------------------------------------------------------
r6436 | erikkay@google.com | 2008-12-05 18:34:22 +0100 (Fri, 05 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/extensions/extension.cc

Fixed a bogus initialization of string constants.  The stack allocated string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory.  This showed up in the purify tests.

Sorry I missed this in the initial code review.


Review URL: http://codereview.chromium.org/13204
------------------------------------------------------------------------
r6424 | abarth@chromium.org | 2008-12-05 08:58:39 +0100 (Fri, 05 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc

We should let binary/octet-stream have an EXE extension to fix compat with digsby.com and ohloh.net

BUG=1573
R=darin

Review URL: http://codereview.chromium.org/13165
------------------------------------------------------------------------
r6422 | abarth@chromium.org | 2008-12-05 08:24:44 +0100 (Fri, 05 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc
   A /trunk/src/chrome/test/data/nosniff-test.html
   A /trunk/src/chrome/test/data/nosniff-test.html.mock-http-headers

Disable the content sniffing algorithm if the server instructs us to do so with the nosniff directive.

For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx

R=deanm,darin

Review URL: http://codereview.chromium.org/12982
------------------------------------------------------------------------
r6410 | sgk@google.com | 2008-12-05 02:14:40 +0100 (Fri, 05 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/views/SConscript

Add new multiprofile files to the SCons build:
chrome\browser\user_data_manager.cc
chrome\browser\view\new_profile_dialog.cc
chrome\browser\view\select_profile_dialog.cc
Review URL: http://codereview.chromium.org/12948
------------------------------------------------------------------------
r6408 | sgk@google.com | 2008-12-05 02:11:11 +0100 (Fri, 05 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.scons

Add new debugger_host_impl.cpp to the SCons build.
Review URL: http://codereview.chromium.org/12947
------------------------------------------------------------------------
r6403 | aa@chromium.org | 2008-12-05 01:38:25 +0100 (Fri, 05 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/extensions/extension.cc
   M /trunk/src/chrome/browser/extensions/extension.h
   A /trunk/src/chrome/browser/extensions/extensions_service.cc
   A /trunk/src/chrome/browser/extensions/extensions_service.h
   A /trunk/src/chrome/browser/extensions/extensions_service_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/test/data/extensions
   A /trunk/src/chrome/test/data/extensions/extension1
   A /trunk/src/chrome/test/data/extensions/extension1/manifest
   A /trunk/src/chrome/test/data/extensions/extension2
   A /trunk/src/chrome/test/data/extensions/extension2/manifest
   A /trunk/src/chrome/test/data/extensions/invalid_manifest
   A /trunk/src/chrome/test/data/extensions/no_manifest
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Introduce ExtensionsService. Load extensions on startup from a directory in
the profile if a command-line flag is present.

Please carefully scrutinize the threading/ref-counting schenanigans.

Review URL: http://codereview.chromium.org/12876
------------------------------------------------------------------------
r6402 | jcampan@chromium.org | 2008-12-05 01:37:20 +0100 (Fri, 05 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/test/automation/automation.vsprops
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Adding the capacity to interact with modal dialogs to the automation framework.
This change will be used by Ojan to implement some unload handler tests.

TEST=Run the ui tests.
Review URL: http://codereview.chromium.org/13113
------------------------------------------------------------------------
r6400 | kuchhal@chromium.org | 2008-12-05 01:32:38 +0100 (Fri, 05 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/google_update.cc

* Do not try to update distribution other than Google Chrome.

BUG=5109

Review URL: http://codereview.chromium.org/13140
------------------------------------------------------------------------
r6394 | paulg@google.com | 2008-12-05 00:22:15 +0100 (Fri, 05 Dec 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/url_fetcher.cc

Do not add the Content-Length header in the URLFetcher,
since that header will be added later in
HttpNetworkTransaction::BuildRequestHeaders.

This change prevents POST requests from having a duplicate
Content-Length header.
Review URL: http://codereview.chromium.org/12965
------------------------------------------------------------------------
r6387 | estade@chromium.org | 2008-12-04 21:46:06 +0100 (Thu, 04 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/session_restore_uitest.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc

Get rid of kPathSeparator on windows. Port some wstring function to take FilePaths. Re-enable relevant posix unit tests.
Review URL: http://codereview.chromium.org/12893
------------------------------------------------------------------------
r6372 | scherkus@chromium.org | 2008-12-04 20:43:48 +0100 (Thu, 04 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/build/debug_message.vcproj
   M /trunk/src/breakpad/breakpad_handler.vcproj
   M /trunk/src/breakpad/breakpad_sender.vcproj
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/chrome_exe.vcproj
   M /trunk/src/chrome/app/generated_resources.vcproj
   M /trunk/src/chrome/app/locales/ar.vcproj
   M /trunk/src/chrome/app/locales/bg.vcproj
   M /trunk/src/chrome/app/locales/bn.vcproj
   M /trunk/src/chrome/app/locales/ca.vcproj
   M /trunk/src/chrome/app/locales/cs.vcproj
   M /trunk/src/chrome/app/locales/da.vcproj
   M /trunk/src/chrome/app/locales/de.vcproj
   M /trunk/src/chrome/app/locales/el.vcproj
   M /trunk/src/chrome/app/locales/en-GB.vcproj
   M /trunk/src/chrome/app/locales/en-US.vcproj
   M /trunk/src/chrome/app/locales/es-419.vcproj
   M /trunk/src/chrome/app/locales/es.vcproj
   M /trunk/src/chrome/app/locales/et.vcproj
   M /trunk/src/chrome/app/locales/fi.vcproj
   M /trunk/src/chrome/app/locales/fil.vcproj
   M /trunk/src/chrome/app/locales/fr.vcproj
   M /trunk/src/chrome/app/locales/gu.vcproj
   M /trunk/src/chrome/app/locales/he.vcproj
   M /trunk/src/chrome/app/locales/hi.vcproj
   M /trunk/src/chrome/app/locales/hr.vcproj
   M /trunk/src/chrome/app/locales/hu.vcproj
   M /trunk/src/chrome/app/locales/id.vcproj
   M /trunk/src/chrome/app/locales/it.vcproj
   M /trunk/src/chrome/app/locales/ja.vcproj
   M /trunk/src/chrome/app/locales/kn.vcproj
   M /trunk/src/chrome/app/locales/ko.vcproj
   M /trunk/src/chrome/app/locales/lt.vcproj
   M /trunk/src/chrome/app/locales/lv.vcproj
   M /trunk/src/chrome/app/locales/ml.vcproj
   M /trunk/src/chrome/app/locales/mr.vcproj
   M /trunk/src/chrome/app/locales/nb.vcproj
   M /trunk/src/chrome/app/locales/nl.vcproj
   M /trunk/src/chrome/app/locales/or.vcproj
   M /trunk/src/chrome/app/locales/pl.vcproj
   M /trunk/src/chrome/app/locales/pt-BR.vcproj
   M /trunk/src/chrome/app/locales/pt-PT.vcproj
   M /trunk/src/chrome/app/locales/ro.vcproj
   M /trunk/src/chrome/app/locales/ru.vcproj
   M /trunk/src/chrome/app/locales/sk.vcproj
   M /trunk/src/chrome/app/locales/sl.vcproj
   M /trunk/src/chrome/app/locales/sr.vcproj
   M /trunk/src/chrome/app/locales/sv.vcproj
   M /trunk/src/chrome/app/locales/ta.vcproj
   M /trunk/src/chrome/app/locales/te.vcproj
   M /trunk/src/chrome/app/locales/th.vcproj
   M /trunk/src/chrome/app/locales/tr.vcproj
   M /trunk/src/chrome/app/locales/uk.vcproj
   M /trunk/src/chrome/app/locales/vi.vcproj
   M /trunk/src/chrome/app/locales/zh-CN.vcproj
   M /trunk/src/chrome/app/locales/zh-TW.vcproj
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   M /trunk/src/chrome/browser/debugger/debugger_disabled.vcproj
   M /trunk/src/chrome/browser/resources/browser_resources.vcproj
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/ipc_tests.vcproj
   M /trunk/src/chrome/installer/gcapi/gcapi_dll.vcproj
   M /trunk/src/chrome/installer/gcapi/gcapi_lib.vcproj
   M /trunk/src/chrome/installer/mini_installer/mini_installer.vcproj
   M /trunk/src/chrome/installer/setup/setup.vcproj
   M /trunk/src/chrome/installer/util/installer_unittests.vcproj
   M /trunk/src/chrome/installer/util/prebuild/util_prebuild.vcproj
   M /trunk/src/chrome/installer/util/util.vcproj
   M /trunk/src/chrome/plugin/plugin.vcproj
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/test/activex_test_control/activex_test_control.vcproj
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.vcproj
   M /trunk/src/chrome/test/automation/automation.vcproj
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.vcproj
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/memory_test/memory_test.vcproj
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test.vcproj
   M /trunk/src/chrome/test/page_cycler/page_cycler_tests.vcproj
   M /trunk/src/chrome/test/perf/perftests.vcproj
   M /trunk/src/chrome/test/plugin/plugin_tests.vcproj
   M /trunk/src/chrome/test/reliability/reliability_tests.vcproj
   M /trunk/src/chrome/test/security_tests/security_tests.vcproj
   M /trunk/src/chrome/test/selenium/selenium_tests.vcproj
   M /trunk/src/chrome/test/startup/startup_tests.vcproj
   M /trunk/src/chrome/test/tab_switching/tab_switching.vcproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/third_party/hunspell/hunspell.vcproj
   M /trunk/src/chrome/tools/convert_dict/convert_dict.vcproj
   M /trunk/src/chrome/tools/crash_service/crash_service.vcproj
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.vcproj
   M /trunk/src/chrome/tools/profiles/generate_profile.vcproj
   M /trunk/src/chrome/tools/test/image_diff/image_diff.vcproj
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/gears/gears.vcproj
   M /trunk/src/google_update/ondemand_updates.vcproj
   M /trunk/src/media/build/media.vcproj
   M /trunk/src/media/build/media_unittests.vcproj
   M /trunk/src/net/build/crash_cache.vcproj
   M /trunk/src/net/build/dump_cache.vcproj
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_perftests.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/build/stress_cache.vcproj
   M /trunk/src/net/build/tld_cleanup.vcproj
   M /trunk/src/rlz/rlz.vcproj
   M /trunk/src/sandbox/sandbox_poc/pocdll/pocdll.vcproj
   M /trunk/src/sandbox/sandbox_poc/sandbox_poc.vcproj
   M /trunk/src/sandbox/src/sandbox.vcproj
   M /trunk/src/sandbox/tests/integration_tests/sbox_integration_tests.vcproj
   M /trunk/src/sandbox/tests/unit_tests/sbox_unittests.vcproj
   M /trunk/src/sandbox/tests/validation_tests/sbox_validation_tests.vcproj
   M /trunk/src/sandbox/tools/finder/finder.vcproj
   M /trunk/src/sandbox/tools/launcher/launcher.vcproj
   M /trunk/src/sandbox/wow_helper/wow_helper.vcproj
   M /trunk/src/sdch/sdch.vcproj
   M /trunk/src/skia/skia.vcproj
   M /trunk/src/testing/gtest.vcproj
   M /trunk/src/third_party/bsdiff/bsdiff.vcproj
   M /trunk/src/third_party/bspatch/bspatch.vcproj
   M /trunk/src/third_party/bzip2/bzip2.vcproj
   M /trunk/src/third_party/libjpeg/libjpeg.vcproj
   M /trunk/src/third_party/libpng/libpng.vcproj
   M /trunk/src/third_party/libxml/build/libxml.vcproj
   M /trunk/src/third_party/libxml/build/libxml_config.vcproj
   M /trunk/src/third_party/libxslt/build/libxslt.vcproj
   M /trunk/src/third_party/libxslt/build/libxslt_config.vcproj
   M /trunk/src/third_party/lzma_sdk/7z_C.vcproj
   M /trunk/src/third_party/modp_b64/modp_b64.vcproj
   M /trunk/src/third_party/npapi/npspy/windows/npspy.sln
   M /trunk/src/third_party/npapi/npspy/windows/npspy.vcproj
   M /trunk/src/third_party/npapi/npspy/windows/spysetup.vcproj
   M /trunk/src/third_party/sqlite/sqlite.vcproj
   M /trunk/src/third_party/zlib/zlib.vcproj
   M /trunk/src/tools/channel_changer/channel_changer.sln
   M /trunk/src/tools/channel_changer/channel_changer.vcproj
   M /trunk/src/tools/measure_page_load_time/ie_bho/MeasurePageLoadTime.vcproj
   M /trunk/src/tools/memory_watcher/memory_watcher.vcproj
   M /trunk/src/webkit/activex_shim/activex_shim.vcproj
   M /trunk/src/webkit/activex_shim_dll/activex_shim_dll.vcproj
   M /trunk/src/webkit/build/JSConfig/KJSConfig.vcproj
   M /trunk/src/webkit/build/JSConfig/V8Config.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/JavaScriptCore.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/JavaScriptCore_pcre.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/WTF.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/testapi.vcproj
   M /trunk/src/webkit/build/KJSBindings/KJSBindings.vcproj
   M /trunk/src/webkit/build/KJSBindings/KJSBindings_prebuild.vcproj
   M /trunk/src/webkit/build/V8Bindings/V8Bindings.vcproj
   M /trunk/src/webkit/build/V8Bindings/V8Bindings_prebuild.vcproj
   M /trunk/src/webkit/build/WebCore/WebCore.vcproj
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/build/localized_strings/localized_strings.vcproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/default_plugin/default_plugin.vcproj
   M /trunk/src/webkit/glue/plugins/test/npapi_test_plugin.vcproj
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/npapi_layout_test_plugin.vcproj
   M /trunk/src/webkit/tools/test_shell/test_shell.vcproj
   M /trunk/src/webkit/tools/test_shell/test_shell_tests.vcproj

Changed svn:eol-style of all .sln and .vcproj files to CRLF
Review URL: http://codereview.chromium.org/13133
------------------------------------------------------------------------
r6369 | finnur@google.com | 2008-12-04 20:32:49 +0100 (Thu, 04 Dec 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-page

I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames. 

Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden).

Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it.

I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious).

Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test.
Review URL: http://codereview.chromium.org/13130
------------------------------------------------------------------------
r6364 | sidchat@google.com | 2008-12-04 19:53:16 +0100 (Thu, 04 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc

Add support in spell check options sub-context menu to pop up fonts and languages options menu.
Review URL: http://codereview.chromium.org/12908
------------------------------------------------------------------------
r6337 | paulg@google.com | 2008-12-04 01:33:04 +0100 (Thu, 04 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Make sure we end the update process if we get an errorfrom the servers. Previously, if we got a 400 (or other)error response, we'd leave the database and transactionopen.BUG=5060 (http://crbug.com/5060)
Review URL: http://codereview.chromium.org/12918
------------------------------------------------------------------------
r6333 | munjal@chromium.org | 2008-12-04 00:52:03 +0100 (Thu, 04 Dec 2008) | 46 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_bn.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_gu.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_kn.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_ml.rc
   M /trunk/src/chrome/app/resources/locale_settings_mr.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_or.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_ta.rc
   M /trunk/src/chrome/app/resources/locale_settings_te.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   A /trunk/src/chrome/browser/user_data_manager.cc
   A /trunk/src/chrome/browser/user_data_manager.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   A /trunk/src/chrome/browser/views/new_profile_dialog.cc
   A /trunk/src/chrome/browser/views/new_profile_dialog.h
   A /trunk/src/chrome/browser/views/select_profile_dialog.cc
   A /trunk/src/chrome/browser/views/select_profile_dialog.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/message_box_view.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Chromium-MultiProfile-Prototype
Summary
=======
Implement a prototype of multiple profiles in Chrome by
utilizing the functionality of user-data-dir command line
flag that already exists.

A profile in this case is an umbrella for all user data
including cookies, history, bookmarks, settings, etc. Each
profile gives the user a separation of all these data
elements.

User Interface
==============
- Wrench > "New window in profile" menu item, with sub-menu items.
	This new menu item has sub menu items for each existing
	profile, for up to 9 profiles, and one more sub menu item
	to launch a window in a new profile. The 9 sub-menu items
	also have the accelerators like CTRL + SHIFT + 1, CTRL +
	SHIFT + 2, etc. If there are more than 9 profiles, we
	will also show an extra sub-menu item, "Other...".
- New Profile dialog box
	This dialog box is shown to the use when (s)he clicks
	Wrench > New window in profile > <New Profile>. It lets
	the user specify a profile name, and also shows a checkbox
	to create a desktop shortcut to launch Chrome in that profile.
- Choose profile dialog box
	This dialog box lets the user select a profile from a drop
	down to open a new window in. It also has an item <New Profile>
	in the drop down, selecting which will show the new profile
	dialog box mentioned above. CTRL + M shortcut also launches
	this dialog box.

Code Organization
=================
chrome\browser\user_data_dir_profile_manager.h/.cc:
	This class provides an abstraction of profiles on top of the user
	data dir command line flag.

chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc
	New profile dialog box code.

chrome\browser\views\user_data_dir_profiles_dialog.h/.cc
	Choose profile dialog box code.

Review URL: http://codereview.chromium.org/12895
------------------------------------------------------------------------
r6318 | ananta@chromium.org | 2008-12-03 23:35:04 +0100 (Wed, 03 Dec 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc

Removing the IsHungAppWindow DCHECK as it does not seem to be indicating
anything useful about the window at this point. It seems to fire at times
even when SendMessageTimeout succeeds on the plugin window, which indicates
some race condition between Windows updating its state about whether the
window is hung.

Fixes http://code.google.com/p/chromium/issues/detail?id=5066

Bug=5066
R=nsylvain

Review URL: http://codereview.chromium.org/12920
------------------------------------------------------------------------
r6312 | brettw@google.com | 2008-12-03 22:28:33 +0100 (Wed, 03 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/skia/SConscript
   A /trunk/src/skia/ext/skia_utils.cc (from /trunk/src/skia/ext/skia_utils_win.cc:6306)
   A /trunk/src/skia/ext/skia_utils.h (from /trunk/src/skia/ext/skia_utils_win.h:6306)
   M /trunk/src/skia/ext/skia_utils_win.cc
   M /trunk/src/skia/ext/skia_utils_win.h
   M /trunk/src/skia/skia.vcproj

Split the cross-platform part of skia_utils_win into skia_utils. Use this new
function when possible. Add a little documentation. This does not change the
Mac build, I'll do that in a separate pass, and the function moved is never
used on the mac).
Review URL: http://codereview.chromium.org/12917
------------------------------------------------------------------------
r6306 | brettw@google.com | 2008-12-03 21:48:29 +0100 (Wed, 03 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/gfx/base_gfx.scons
   D /trunk/src/base/gfx/skia_utils.cc
   D /trunk/src/base/gfx/skia_utils.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/common/gfx/color_utils.cc
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/single_split_view.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/skia/SConscript
   M /trunk/src/skia/ext/platform_device_win.cc
   A /trunk/src/skia/ext/skia_utils_win.cc (from /trunk/src/base/gfx/skia_utils.cc:6295)
   A /trunk/src/skia/ext/skia_utils_win.h (from /trunk/src/base/gfx/skia_utils.h:6295)
   M /trunk/src/skia/ext/vector_device.cc
   M /trunk/src/skia/skia.vcproj
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.cpp
   M /trunk/src/webkit/port/rendering/RenderThemeWin.cpp

Move base/gfx/skia_util to skia/ext/skia_util_win.
In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function).
Review URL: http://codereview.chromium.org/13101
------------------------------------------------------------------------
r6297 | jcampan@chromium.org | 2008-12-03 19:43:05 +0100 (Wed, 03 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/render_view_host.cc

The onbeforeunload event could be sent more than once to a page.
This would happen if you closed a tab more than once and if you closed the browser several times (while it is waiting for unloads to execute).

BUG=5029
TEST=See bug
Review URL: http://codereview.chromium.org/13078
------------------------------------------------------------------------
r6290 | brettw@google.com | 2008-12-03 17:22:10 +0100 (Wed, 03 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/gfx/base_gfx.scons
   D /trunk/src/base/gfx/convolver.cc
   D /trunk/src/base/gfx/convolver.h
   D /trunk/src/base/gfx/convolver_unittest.cc
   D /trunk/src/base/gfx/image_operations.cc
   D /trunk/src/base/gfx/image_operations.h
   D /trunk/src/base/gfx/image_operations_unittest.cc
   D /trunk/src/base/gfx/img_resize_perftest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/views/button.cc
   A /trunk/src/skia/ext/convolver.cc (from /trunk/src/base/gfx/convolver.cc:6267)
   A /trunk/src/skia/ext/convolver.h (from /trunk/src/base/gfx/convolver.h:6267)
   A /trunk/src/skia/ext/convolver_unittest.cc (from /trunk/src/base/gfx/convolver_unittest.cc:6267)
   A /trunk/src/skia/ext/image_operations.cc (from /trunk/src/base/gfx/image_operations.cc:6267)
   A /trunk/src/skia/ext/image_operations.h (from /trunk/src/base/gfx/image_operations.h:6267)
   A /trunk/src/skia/ext/image_operations_unittest.cc (from /trunk/src/base/gfx/image_operations_unittest.cc:6267)
   M /trunk/src/skia/skia.vcproj
   M /trunk/src/skia/skia.xcodeproj/project.pbxproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/NativeImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.cpp

Move convolver and image_operations from base/gfx to skia/ext. This is just
like my previous change except does no namespace renaming and doesn't touch
skia_utils.
Review URL: http://codereview.chromium.org/13080
------------------------------------------------------------------------
r6288 | pinkerton@google.com | 2008-12-03 15:40:29 +0100 (Wed, 03 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

add a few files that now compile
Review URL: http://codereview.chromium.org/13062
------------------------------------------------------------------------
r6287 | dkegel@google.com | 2008-12-03 15:05:30 +0100 (Wed, 03 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_uitest.cc

Encapsulate https server creation a bit more in preparation for getting the
cert paths from SSLTestUtil in net/base/ssl_test_util.h

Review URL: http://codereview.chromium.org/13063
------------------------------------------------------------------------
r6286 | sgjesse@chromium.org | 2008-12-03 15:04:49 +0100 (Wed, 03 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   A /trunk/src/chrome/browser/debugger/debugger_host.h
   A /trunk/src/chrome/browser/debugger/debugger_host_impl.cpp
   A /trunk/src/chrome/browser/debugger/debugger_host_impl.h
   M /trunk/src/chrome/browser/debugger/debugger_io.h
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.h
   M /trunk/src/chrome/browser/debugger/debugger_shell.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/webkit/build/port/port.vcproj
   A /trunk/src/webkit/port/page/inspector/DebuggerConsole.js (from /trunk/src/chrome/browser/debugger/resources/debugger.js:6284)
   A /trunk/src/webkit/port/page/inspector/DebuggerIPC.js
   A /trunk/src/webkit/port/page/inspector/DebuggerPanel.js (from /trunk/src/chrome/browser/debugger/resources/debugger.js:6284)
   A /trunk/src/webkit/port/page/inspector/DebuggerShell.js (from /trunk/src/chrome/browser/debugger/resources/debugger_shell.js:6284)
   A /trunk/src/webkit/port/page/inspector/debugger.css (from /trunk/src/chrome/browser/debugger/resources/debugger.css:6284)
   A /trunk/src/webkit/port/page/inspector/debugger.html (from /trunk/src/chrome/browser/debugger/resources/debugger.html:6284)

Copy of http://codereview.chromium.org/13003 created by yury.semikhatsky@gmail.com for final commit.
Review URL: http://codereview.chromium.org/13092
------------------------------------------------------------------------
r6279 | ben@chromium.org | 2008-12-03 08:54:25 +0100 (Wed, 03 Dec 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h

Roll back this change.
------------------------------------------------------------------------
r6278 | sgk@google.com | 2008-12-03 08:16:18 +0100 (Wed, 03 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/views/SConscript

Remove old infobar code from the SCons build.
Review URL: http://codereview.chromium.org/13083
------------------------------------------------------------------------
r6277 | ben@chromium.org | 2008-12-03 07:10:00 +0100 (Wed, 03 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/views/widget_win.cc
   M /trunk/src/chrome/views/widget_win.h

RootView should be destroyed in WM_NCDESTROY not after it.

Review URL: http://codereview.chromium.org/12632
------------------------------------------------------------------------
r6273 | ben@chromium.org | 2008-12-03 04:06:37 +0100 (Wed, 03 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   D /trunk/src/chrome/browser/session_crashed_view.cc
   D /trunk/src/chrome/browser/session_crashed_view.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   D /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.cc
   D /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.h
   D /trunk/src/chrome/browser/views/info_bar_confirm_view.cc
   D /trunk/src/chrome/browser/views/info_bar_confirm_view.h
   D /trunk/src/chrome/browser/views/info_bar_item_view.cc
   D /trunk/src/chrome/browser/views/info_bar_item_view.h
   D /trunk/src/chrome/browser/views/info_bar_message_view.cc
   D /trunk/src/chrome/browser/views/info_bar_message_view.h
   D /trunk/src/chrome/browser/views/info_bar_view.cc
   D /trunk/src/chrome/browser/views/info_bar_view.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Tear out all the old infobar code.

http://crbug.com/4620

Review URL: http://codereview.chromium.org/13077
------------------------------------------------------------------------
r6268 | ben@chromium.org | 2008-12-03 02:36:00 +0100 (Wed, 03 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/infobar_delegate.cc
   M /trunk/src/chrome/browser/infobar_delegate.h
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h

Convert Alternate NavURL Fetcher to use the new infobar framework.

http://crbug.com/4620

Review URL: http://codereview.chromium.org/13070
------------------------------------------------------------------------
r6266 | brettw@google.com | 2008-12-03 02:11:58 +0100 (Wed, 03 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/gfx/base_gfx.scons
   A /trunk/src/base/gfx/convolver.cc (from /trunk/src/base/gfx/convolver.cc:6247)
   A /trunk/src/base/gfx/convolver.h (from /trunk/src/base/gfx/convolver.h:6247)
   A /trunk/src/base/gfx/convolver_unittest.cc (from /trunk/src/base/gfx/convolver_unittest.cc:6247)
   A /trunk/src/base/gfx/image_operations.cc (from /trunk/src/base/gfx/image_operations.cc:6247)
   A /trunk/src/base/gfx/image_operations.h (from /trunk/src/base/gfx/image_operations.h:6247)
   A /trunk/src/base/gfx/image_operations_unittest.cc (from /trunk/src/base/gfx/image_operations_unittest.cc:6247)
   A /trunk/src/base/gfx/img_resize_perftest.cc (from /trunk/src/base/gfx/img_resize_perftest.cc:6247)
   M /trunk/src/base/gfx/native_theme.cc
   A /trunk/src/base/gfx/skia_utils.cc (from /trunk/src/base/gfx/skia_utils.cc:6247)
   A /trunk/src/base/gfx/skia_utils.h (from /trunk/src/base/gfx/skia_utils.h:6247)
   A /trunk/src/base/gfx/skia_utils_mac.cc (from /trunk/src/base/gfx/skia_utils_mac.cc:6247)
   A /trunk/src/base/gfx/skia_utils_mac.h (from /trunk/src/base/gfx/skia_utils_mac.h:6247)
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/color_utils.cc
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/single_split_view.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/skia/SConscript
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   D /trunk/src/skia/ext/convolver.cc
   D /trunk/src/skia/ext/convolver.h
   D /trunk/src/skia/ext/convolver_unittest.cc
   D /trunk/src/skia/ext/image_operations.cc
   D /trunk/src/skia/ext/image_operations.h
   D /trunk/src/skia/ext/image_operations_unittest.cc
   M /trunk/src/skia/ext/platform_device_mac.cc
   M /trunk/src/skia/ext/platform_device_win.cc
   D /trunk/src/skia/ext/skia_utils.cc
   D /trunk/src/skia/ext/skia_utils.h
   D /trunk/src/skia/ext/skia_utils_mac.cc
   D /trunk/src/skia/ext/skia_utils_mac.h
   D /trunk/src/skia/ext/skia_utils_win.cc
   D /trunk/src/skia/ext/skia_utils_win.h
   M /trunk/src/skia/ext/vector_device.cc
   M /trunk/src/skia/skia.vcproj
   M /trunk/src/skia/skia.xcodeproj/project.pbxproj
   M /trunk/src/webkit/port/platform/graphics/FontWin.cpp
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/NativeImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.cpp
   M /trunk/src/webkit/port/rendering/RenderThemeWin.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell_tests.vcproj

Revert my skia file moves because of layout test failures.
Review URL: http://codereview.chromium.org/12892
------------------------------------------------------------------------
r6261 | scherkus@chromium.org | 2008-12-03 01:48:32 +0100 (Wed, 03 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h

Updated the design document URLs for ResourceDispatcher and ResourceDispatcherHost
Review URL: http://codereview.chromium.org/12890
------------------------------------------------------------------------
r6260 | pkasting@chromium.org | 2008-12-03 01:47:58 +0100 (Wed, 03 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/word_iterator.cc
   M /trunk/src/base/word_iterator.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/history/snippet.h
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history_view.cc

Make WordIterator and Snippet::MatchPositions use size_t instead of int for offsets into strings.  This avoids some casts.  I also added a typedef for Snippet::MatchPosition which cleans up a bit of the calling code a little.
Review URL: http://codereview.chromium.org/13064
------------------------------------------------------------------------
r6258 | finnur@google.com | 2008-12-03 01:32:22 +0100 (Wed, 03 Dec 2008) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Fix issue 4829: No file extensions listed when saving images

We were not supplying a filter list for the Save As dialog. 

Now that we do, the user can select between, for example, say *.jpg and *.* as filters and we behave as follows:

With a *.jpg filter active, user enters foo and we save the file as: foo.jpg
With a *.jpg filter active, user enters foo. and we save the file as: foo..jpg (which is consistent with IE)
With a *.jpg filter active, user enters foo.jpg, we save the file as: foo.jpg
With a *.jpg filter active, user enters foo.jpeg, we save the file as: foo.jpeg (not foo.jpg or foo.jpeg.jpg)

With a *.* filter active, we respect whatever user enters as extension, except if the filename contains one or more trailing dots then we strip out all those trailing dots.

Also test filenames created when saving web pages, as opposed to images (should work as before).

Review URL: http://codereview.chromium.org/12836
------------------------------------------------------------------------
r6248 | brettw@google.com | 2008-12-02 23:35:42 +0100 (Tue, 02 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/base/build/base_gfx.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   M /trunk/src/base/gfx/base_gfx.scons
   D /trunk/src/base/gfx/convolver.cc
   D /trunk/src/base/gfx/convolver.h
   D /trunk/src/base/gfx/convolver_unittest.cc
   D /trunk/src/base/gfx/image_operations.cc
   D /trunk/src/base/gfx/image_operations.h
   D /trunk/src/base/gfx/image_operations_unittest.cc
   D /trunk/src/base/gfx/img_resize_perftest.cc
   M /trunk/src/base/gfx/native_theme.cc
   D /trunk/src/base/gfx/skia_utils.cc
   D /trunk/src/base/gfx/skia_utils.h
   D /trunk/src/base/gfx/skia_utils_mac.cc
   D /trunk/src/base/gfx/skia_utils_mac.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/common/gfx/color_utils.cc
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/single_split_view.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/skia/SConscript
   M /trunk/src/skia/ext/bitmap_platform_device_mac.cc
   A /trunk/src/skia/ext/convolver.cc (from /trunk/src/base/gfx/convolver.cc:6142)
   A /trunk/src/skia/ext/convolver.h (from /trunk/src/base/gfx/convolver.h:6142)
   A /trunk/src/skia/ext/convolver_unittest.cc (from /trunk/src/base/gfx/convolver_unittest.cc:6142)
   A /trunk/src/skia/ext/image_operations.cc (from /trunk/src/base/gfx/image_operations.cc:6142)
   A /trunk/src/skia/ext/image_operations.h (from /trunk/src/base/gfx/image_operations.h:6142)
   A /trunk/src/skia/ext/image_operations_unittest.cc (from /trunk/src/base/gfx/image_operations_unittest.cc:6142)
   M /trunk/src/skia/ext/platform_device_mac.cc
   M /trunk/src/skia/ext/platform_device_win.cc
   A /trunk/src/skia/ext/skia_utils.cc (from /trunk/src/base/gfx/skia_utils.cc:6142)
   A /trunk/src/skia/ext/skia_utils.h (from /trunk/src/base/gfx/skia_utils.h:6142)
   A /trunk/src/skia/ext/skia_utils_mac.cc (from /trunk/src/base/gfx/skia_utils_mac.cc:6142)
   A /trunk/src/skia/ext/skia_utils_mac.h (from /trunk/src/base/gfx/skia_utils_mac.h:6142)
   A /trunk/src/skia/ext/skia_utils_win.cc (from /trunk/src/base/gfx/skia_utils.cc:6142)
   A /trunk/src/skia/ext/skia_utils_win.h (from /trunk/src/base/gfx/skia_utils.h:6142)
   M /trunk/src/skia/ext/vector_device.cc
   M /trunk/src/skia/skia.vcproj
   M /trunk/src/webkit/port/platform/graphics/FontWin.cpp
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/NativeImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.cpp
   M /trunk/src/webkit/port/rendering/RenderThemeWin.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell_tests.vcproj

Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.

This changes the namespace in those files from "gfx" to "skia".

I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win.

There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted.
Review URL: http://codereview.chromium.org/12842
------------------------------------------------------------------------
r6244 | pinkerton@google.com | 2008-12-02 22:39:56 +0100 (Tue, 02 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/renderer/renderer.scons

add more files to mac chrome project, build a few more tests. Fix typo in scons file for darwin. Use compiler define for MSVC pragma.
Review URL: http://codereview.chromium.org/13060
------------------------------------------------------------------------
r6241 | wtc@google.com | 2008-12-02 22:27:45 +0100 (Tue, 02 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Change a DCHECK to CHECK to help debug a crash in
release builds.

R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/12874
------------------------------------------------------------------------
r6239 | brettw@google.com | 2008-12-02 22:03:51 +0100 (Tue, 02 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Fix a comment. This was brought up by Ojan in a review for my previous patch, but I forgot to fix it before checking in.
Review URL: http://codereview.chromium.org/12877
------------------------------------------------------------------------
r6227 | jeremy@chromium.org | 2008-12-02 20:20:15 +0100 (Tue, 02 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/condition_variable_unittest.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/path_service_unittest.cc
   D /trunk/src/base/platform_test.h
   D /trunk/src/base/platform_test_mac.mm
   M /trunk/src/base/sys_info_unittest.cc
   M /trunk/src/base/thread_unittest.cc
   M /trunk/src/base/worker_pool_unittest.cc
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/file_stream_unittest.cc
   M /trunk/src/net/base/gzip_filter_unittest.cc
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/tcp_client_socket_unittest.cc
   M /trunk/src/net/base/telnet_server_unittest.cc
   M /trunk/src/net/base/test_completion_callback_unittest.cc
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc
   M /trunk/src/net/disk_cache/disk_cache_test_base.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/net.xcodeproj/project.pbxproj
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/testing/gtest.xcodeproj/project.pbxproj
   A /trunk/src/testing/platform_test.h (from /trunk/src/base/platform_test.h:6222)
   A /trunk/src/testing/platform_test_mac.mm (from /trunk/src/base/platform_test_mac.mm:6222)

* Cleanup: move base/platform_test.h -> testing/
* Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild

Review URL: http://codereview.chromium.org/13052
------------------------------------------------------------------------
r6225 | brettw@google.com | 2008-12-02 20:08:56 +0100 (Tue, 02 Dec 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Remove the URL and title from the state getting functions and IPC messages.

If the title or URL changes, we'll be updated in other ways, so this extra processing is wasted.
Review URL: http://codereview.chromium.org/12859
------------------------------------------------------------------------
r6211 | aa@chromium.org | 2008-12-02 08:52:33 +0100 (Tue, 02 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/extensions
   A /trunk/src/chrome/browser/extensions/extension.cc
   A /trunk/src/chrome/browser/extensions/extension.h
   A /trunk/src/chrome/browser/extensions/extension_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Introduce Extension class that can serializer and deserialize from Value
instances.

------------------------------------------------------------------------
r6210 | sgk@google.com | 2008-12-02 08:36:03 +0100 (Tue, 02 Dec 2008) | 14 lines
Changed paths:
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/build/SConscript.main
   M /trunk/src/build/debug.scons
   M /trunk/src/build/internal/essential.scons
   M /trunk/src/build/internal/release_defaults.scons
   M /trunk/src/build/internal/release_impl_checksenabled.scons
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/site_scons/site_tools/chromium_builders.py

Fixes and enhancements
* Configurable CHROME_BUILD_TYPE command line or external environment
  variable for selecting appropriate release_impl*.scons settings
  (_checksenabled, _coverage, _dom_stats, _official, _purify).
* Configurable CHROMIUM_BUILD command line or external environment
  variable for selecting appropriate chromium_build*.scons settings
  (_google_chrome).
* Configurable /INCREMENTAL linking via command line or external
  environment variable ($INCREMENTAL), through appropriate setting
  of an internal $CHROMIUM_INCREMENTAL_FLAGS construction variable.
* Full link of release builds by default.
* Alphabetize *.scons files in the mac_env.FilterOut() list.
* Explicitly set _checksenabled.scons link flags.
Review URL: http://codereview.chromium.org/13039
------------------------------------------------------------------------
r6198 | nsylvain@chromium.org | 2008-12-02 04:42:24 +0100 (Tue, 02 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

We have a bunch of new ui tests failure that started
approximatively at this revision. I'm reverting to make
sure.

tbr: wtc
Review URL: http://codereview.chromium.org/12855
------------------------------------------------------------------------
r6196 | ben@chromium.org | 2008-12-02 03:41:34 +0100 (Tue, 02 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h

Convert SSL info bars to use the new system.

http://crbug.com/4620

Review URL: http://codereview.chromium.org/12847
------------------------------------------------------------------------
r6193 | jar@google.com | 2008-12-02 02:32:34 +0100 (Tue, 02 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h

Add instrumentation to and tighten SDCH implementation


r=huanr,kmixter,openvcdiff
Review URL: http://codereview.chromium.org/12699
------------------------------------------------------------------------
r6189 | wtc@google.com | 2008-12-02 01:30:43 +0100 (Tue, 02 Dec 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Change a DCHECK to CHECK to help debug a crash in
release builds.

R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/12465
------------------------------------------------------------------------
r6184 | pkasting@chromium.org | 2008-12-02 00:54:12 +0100 (Tue, 02 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc

Don't close tabs on middle-click when the release happens off the tab.  Patch by Mohamed Mansour, r=ben.  See http://codereview.chromium.org/12816/ .

BUG=1062
------------------------------------------------------------------------
r6168 | pkasting@chromium.org | 2008-12-01 22:53:05 +0100 (Mon, 01 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h

<esc> in the AutocompleteEdit should select all the text when reverting to the permanent text.  Only pass it through as an accelerator if we don't end up changing anything.  Patch by Mohamed Mansour, r=me.  See http://codereview.chromium.org/10800 .

BUG=4203
------------------------------------------------------------------------
r6166 | pkasting@chromium.org | 2008-12-01 22:47:54 +0100 (Mon, 01 Dec 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h

Fixes for some trivial issues (remove unneeded constants, int->size_t in a few cases).  Patch by phajdan.jr@gmail.com, r=me.  See http://codereview.chromium.org/11586 .
------------------------------------------------------------------------
r6165 | erg@google.com | 2008-12-01 22:39:31 +0100 (Mon, 01 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Fix window.open()/window.close() regression by disabling window.close() until a message comes back
from the Browser thread saying that it's OK to allow javascript close calls.

ISSUE=http://crbug.com/4007
Review URL: http://codereview.chromium.org/12691
------------------------------------------------------------------------
r6162 | sidchat@google.com | 2008-12-01 22:08:11 +0100 (Mon, 01 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu.h
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Add a new submenu in the context menu for a text box. This submenu displays some spell check languages that Chrome supports, derived from the accept languages list and the current spell check language. The spell check language which is currently set is shown to be selected. The user can click on some other spell check language, and it will become effective immediately (this part of the code was addressed in a previous CL, and has been checked in).
Review URL: http://codereview.chromium.org/12614
------------------------------------------------------------------------
r6155 | nsylvain@chromium.org | 2008-12-01 21:23:22 +0100 (Mon, 01 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   D /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   D /trunk/src/chrome/browser/importer/firefox_profile_lock_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc

Revert change 6149 because it broke the unit tests on windows.

Review URL: http://codereview.chromium.org/12834
------------------------------------------------------------------------
r6150 | sky@google.com | 2008-12-01 20:18:20 +0100 (Mon, 01 Dec 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Landing http://codereview.chromium.org/12502 for sverrir:

Fix selection after deleting cookies.  The selection was seemingly random
because the model to view mapping changed when deleting items.

BUG=3692
TEST=Try deleting items in cookies view and make sure selection doesn't jump around unexpectedly.

------------------------------------------------------------------------
r6149 | agl@chromium.org | 2008-12-01 20:10:18 +0100 (Mon, 01 Dec 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   A /trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc
   A /trunk/src/chrome/browser/importer/firefox_profile_lock_win.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc

browser porting, part 2 - importer

Review URL: http://codereview.chromium.org/12688
Patch from Pawel Hajdan jr.

------------------------------------------------------------------------
r6144 | sky@google.com | 2008-12-01 17:25:32 +0100 (Mon, 01 Dec 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Changes filter used when importing in bookmark manager to include
*.htm.

BUG=4388
TEST=Create a file name foo.htm. Go to bookmark manager, choose
  import, navigate to directory with foo.htm and make sure the the
  open dialog shows foo.htm.

Review URL: http://codereview.chromium.org/12459
------------------------------------------------------------------------
r6142 | maruel@chromium.org | 2008-12-01 15:34:42 +0100 (Mon, 01 Dec 2008) | 2 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   A /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reapply 5971 which was reverted in 5974. The unit test wasn't unregistering the observer correctly.
Review URL: http://codereview.chromium.org/12474
------------------------------------------------------------------------
r6127 | mbelshe@google.com | 2008-12-01 01:52:40 +0100 (Mon, 01 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/system_monitor.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   A /trunk/src/chrome/browser/suspend_controller.cc (from /trunk/src/chrome/browser/suspend_controller.cc:6125)
   A /trunk/src/chrome/browser/suspend_controller.h (from /trunk/src/chrome/browser/suspend_controller.h:6125)
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/views/widget_win.h

Rollback

Review URL: http://codereview.chromium.org/13009
------------------------------------------------------------------------
r6126 | mbelshe@google.com | 2008-12-01 00:54:35 +0100 (Mon, 01 Dec 2008) | 3 lines
Changed paths:
   M /trunk/src/base/system_monitor.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   D /trunk/src/chrome/browser/suspend_controller.cc
   D /trunk/src/chrome/browser/suspend_controller.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/views/widget_win.h

A new copy of the old system monitor changelist.

Review URL: http://codereview.chromium.org/12817
------------------------------------------------------------------------
r6099 | estade@chromium.org | 2008-11-27 05:03:57 +0100 (Thu, 27 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_linux.cc
   M /trunk/src/base/file_util_mac.mm
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_mac.mm

Remove file_util::kPathSeparator from posix.

Review URL: http://codereview.chromium.org/12489
------------------------------------------------------------------------
r6094 | ananta@chromium.org | 2008-11-27 02:56:27 +0100 (Thu, 27 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc

Reverting 5927 as John has a better fix for this issue.
was as below:-

R=jam
Bug=4582

Review URL: http://codereview.chromium.org/12402

Review URL: http://codereview.chromium.org/10787
------------------------------------------------------------------------
r6091 | jcampan@chromium.org | 2008-11-27 02:44:44 +0100 (Thu, 27 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc

Reenabling a DCHECK that was causing the ui tests to hang on the dbg build bots, which I could not reproduce locally.
I'll try to investigate on the bots.

TBR=nsylvain
Review URL: http://codereview.chromium.org/10979
------------------------------------------------------------------------
r6083 | pkasting@chromium.org | 2008-11-27 02:02:20 +0100 (Thu, 27 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_service.cc

* Don't do an idle check in StartLogTransmissionTimer().  This check makes us never re-set timers after sending logs.  The check in TryToStartTransmission() is sufficient to halt uploading and timers after a user has been idle.
* Various small style fixes to comply with style guide, around args alignment and indentation.

Review URL: http://codereview.chromium.org/11452
------------------------------------------------------------------------
r6070 | tc@google.com | 2008-11-27 00:19:39 +0100 (Thu, 27 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/net/referrer.cc

fix linux opt build
Set initial values to 0.

TBR=jar

Review URL: http://codereview.chromium.org/12507

------------------------------------------------------------------------
r6050 | jcampan@chromium.org | 2008-11-26 22:16:35 +0100 (Wed, 26 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Relanding docus manager crasher work-around.

TBR=ben
Review URL: http://codereview.chromium.org/12685
------------------------------------------------------------------------
r6034 | tc@google.com | 2008-11-26 18:44:32 +0100 (Wed, 26 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/net/referrer.cc
   M /trunk/src/chrome/browser/net/referrer.h

Fixed two simple compilations that stopped browser/net/referrer.cc
from compiling on linux.

Patch by Kunal Thakar <kunalt@gmail.com>,
original CL: http://codereview.chromium.org/10773

Review URL: http://codereview.chromium.org/12674

------------------------------------------------------------------------
r6030 | cpu@google.com | 2008-11-26 03:44:08 +0100 (Wed, 26 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h

Add client parameter to the RLZ ping
- Does nothing on regular chrome or chromium installs
- up to google_update to put data in 'client'

BUG=1503035


Review URL: http://codereview.chromium.org/12657
------------------------------------------------------------------------
r6020 | jcampan@chromium.org | 2008-11-26 01:38:13 +0100 (Wed, 26 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Reverting my previous commit, it seems to be breaking the UI tests in debug mode.


Review URL: http://codereview.chromium.org/12666
------------------------------------------------------------------------
r6018 | sky@google.com | 2008-11-26 01:26:26 +0100 (Wed, 26 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/text_field.h

Changes keyword editor to map all input in the keyword field to lower
case.

BUG=4520
TEST=bring up the keyword editor, type some text and make sure it gets
  mapped to lower case.

Review URL: http://codereview.chromium.org/12452
------------------------------------------------------------------------
r6016 | pkasting@chromium.org | 2008-11-26 01:20:30 +0100 (Wed, 26 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_view_win.cc

Attempted fix for some wheel/touchpad scrolling errors.

The nTrackPos member of SCROLLINFO is not actually the scroll position, and can't be set by a SetScrollInfo() call.  Thus the SetScrollInfo() calls were actually setting the scroll position of the fake scroll bars to the upper left corner.

This change sets the scroll position to the center of each scrollbar, in the hopes that some mouse drivers were querying the scroll position or thumb position and not sending scroll left/up messages when they found the page was already scrolled all the way left/up.

This change may not help, but it won't hurt, and the old code was definitely wrong.
Review URL: http://codereview.chromium.org/12415
------------------------------------------------------------------------
r6015 | paulg@google.com | 2008-11-26 01:18:27 +0100 (Wed, 26 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Turn on the new SafeBrowsing by default. To use the older
implemenation, use the command line flag: --old-safe-browsing

Review URL: http://codereview.chromium.org/12448
------------------------------------------------------------------------
r6014 | creis@google.com | 2008-11-26 01:16:51 +0100 (Wed, 26 Nov 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/site_instance.cc
   M /trunk/src/chrome/browser/site_instance.h
   M /trunk/src/chrome/browser/site_instance_unittest.cc

Don't create separate SiteInstances for pages from the same domain and scheme
but from different ports.  (These pages can still access each other.)

(This is copied from http://codereview.chromium.org/12443, which has already
been reviewed by darin and abarth.  Just had to commit from a different
checked out codebase.)

BUG=4792
R=darin,abarth


Review URL: http://codereview.chromium.org/12451
------------------------------------------------------------------------
r6008 | deanm@chromium.org | 2008-11-26 00:29:56 +0100 (Wed, 26 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/test/ui/ui_test.cc

Fix up paths now that test_file_util has moved.

Review URL: http://codereview.chromium.org/12453
------------------------------------------------------------------------
r6007 | deanm@chromium.org | 2008-11-26 00:14:46 +0100 (Wed, 26 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc

Port some files in chrome/browser/ - part 1.

Review URL: http://codereview.chromium.org/11402
Patch from Pawel Hajdan Jr.
------------------------------------------------------------------------
r6004 | deanm@chromium.org | 2008-11-25 23:46:59 +0100 (Tue, 25 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/watchdog.cc
   M /trunk/src/base/watchdog.h
   M /trunk/src/base/watchdog_unittest.cc
   M /trunk/src/chrome/browser/jankometer.cc

Port base/watchdog to Linux.

BUG=4632

Review URL: http://codereview.chromium.org/11326
Patch from Pawel Hajdan Jr.
------------------------------------------------------------------------
r6003 | sky@google.com | 2008-11-25 23:45:39 +0100 (Tue, 25 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/browser/tab_restore_service.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h

Changes tab restore service to handle restoring closed windows as a
single unit. Sadly I've written another ui test. Lets hope it isn't
flakey. Glen is going to change the NTP to deal with this appropriately.

BUG=4686
TEST=Try closing a window (with more than one window open), hitting
  control-shift-t, and make sure the window and all it's tabs comes
  back.

Review URL: http://codereview.chromium.org/11377
------------------------------------------------------------------------
r6000 | jcampan@chromium.org | 2008-11-25 23:27:41 +0100 (Tue, 25 Nov 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Some crashes reported from the field seems to indicate that when
storing/restoring the focused view on a tab, the focus manager or focused view
is garbage.
I have not been able to repro any of these crashers and was not able to discover
much from the mini-dumps.
This is a simple work-around that just prevents the storing/restoring of focus
when closing a tab, to avoid the cases reported in the crasher.

Note this is the equivalent of CL 12622 (which is on the release branck), which was reviewed by Ben. 

BUG=4633 

Review URL: http://codereview.chromium.org/12652
------------------------------------------------------------------------
r5998 | sky@google.com | 2008-11-25 22:52:10 +0100 (Tue, 25 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents_view.cc
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/common/notification_types.h

Attempt at fixing crash in WebContents::ShowWidget. I suspect this is
happening because the RenderWidgetHost is getting destroyed between
the time it is created but before it it shown (perhaps the renderer
went away).

BUG=4629
TEST=none

Review URL: http://codereview.chromium.org/12439
------------------------------------------------------------------------
r5996 | sky@google.com | 2008-11-25 22:29:45 +0100 (Tue, 25 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h

Changes table_view to get position for context menu from the current
position of the mose. I've no idea why, but it seems when RTL the
position passed to OnContextMenu is wrong in weird inconsistent
ways. I thought it was interted, but that isn't always the case. I'm
also changing the anchor position to top_right when RTL.

BUG=4750
TEST=see bug

Review URL: http://codereview.chromium.org/12447
------------------------------------------------------------------------
r5994 | cpu@google.com | 2008-11-25 22:18:23 +0100 (Tue, 25 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

The first run sentinel does not get created for system install
- Vista case mostly if user has UAC enabled
- The sentinel path is not writeable if you are not elevated so
  first run keeps happening every time.

BUG=1503885

Review URL: http://codereview.chromium.org/12650
------------------------------------------------------------------------
r5992 | erg@google.com | 2008-11-25 22:14:44 +0100 (Tue, 25 Nov 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc

Changelist for erg's readability review.

I am submitting BlockedPopupContainer for my C++ windows readability review. It's original code reviews are:
http://codereview.chromium.org/8782
http://codereview.chromium.org/9373
http://codereview.chromium.org/10606

In addition to the above reviews, the test cases have been (re)written in:
http://codereview.chromium.org/10206
http://codereview.chromium.org/9709
http://codereview.chromium.org/10282

Review URL: http://codereview.chromium.org/10618
------------------------------------------------------------------------
r5989 | sky@google.com | 2008-11-25 22:08:22 +0100 (Tue, 25 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h

Fix for 1498134, possible crash when cancelling a url request. The
crash happened because OnReadCompleted would invoke CompleteRead which
might invoke CancelRequest and delete the request. If this happened
when control returned back to OnReadCompleted the request was deleted,
yet ResourceDispatcherHost assumed it wasn't.

BUG=1498134
TEST=none

Review URL: http://codereview.chromium.org/12602
------------------------------------------------------------------------
r5988 | erg@google.com | 2008-11-25 21:32:48 +0100 (Tue, 25 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc

Set the delegate on incoming TabContents in BlockedPopupContainer::ReplaceContents.

Review URL: http://codereview.chromium.org/12646
------------------------------------------------------------------------
r5982 | jungshik@google.com | 2008-11-25 20:03:18 +0100 (Tue, 25 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_package.cc

Enable the encoding menu for javascript and css files. 

BUG=3565
TEST=Open a JS or CSS file by clicking a link to it in view-source and see if the encoding menu is enabled.


Review URL: http://codereview.chromium.org/12619
------------------------------------------------------------------------
r5974 | maruel@chromium.org | 2008-11-25 15:45:39 +0100 (Tue, 25 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   D /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Reverting 5971.
Review URL: http://codereview.chromium.org/12637
------------------------------------------------------------------------
r5971 | maruel@chromium.org | 2008-11-25 14:47:50 +0100 (Tue, 25 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   A /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add superficial unit test for PrintJob. That's a start.
Add more DCHECKs.
Same as r5607 except that Thread.StopSoon is fixed.
Review URL: http://codereview.chromium.org/11534
------------------------------------------------------------------------
r5957 | ben@chromium.org | 2008-11-25 02:55:10 +0100 (Tue, 25 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/infobar_delegate.h
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h

Fix crash with plugin installer infobar due to the infobardelegate not being removed from the containing TabContents.

http://crbug.com/4620

Review URL: http://codereview.chromium.org/12624
------------------------------------------------------------------------
r5954 | ben@chromium.org | 2008-11-25 02:06:05 +0100 (Tue, 25 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/infobar_delegate.cc
   M /trunk/src/chrome/browser/infobar_delegate.h
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/session_crashed_view.cc
   M /trunk/src/chrome/browser/session_crashed_view.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/notification_types.h

Re-land 5929 (r5882) with crash fix and also this change:

http://codereview.chromium.org/11392/show

which fixes the remainder of the UI test issues apparently.

http://crbug.com/4620

------------------------------------------------------------------------
r5948 | jungshik@google.com | 2008-11-25 01:15:14 +0100 (Tue, 25 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc

Get rid of ISO-8859-9 in the character encoding menu because it's now treated as an alias to its superset, windows-1254.

BUG=4746
TEST=visit http://www.sabah.com.tr (ISO-8859-9 page) and make sure that 'Turkish' is checked in the encoding menu


Review URL: http://codereview.chromium.org/11811
------------------------------------------------------------------------
r5944 | estade@chromium.org | 2008-11-25 00:37:04 +0100 (Tue, 25 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/directory_lister_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_posix.cc
   M /trunk/src/net/base/net_util_win.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Clean up some net/ code. Change a number of wstrings to FilePaths.

Review URL: http://codereview.chromium.org/12409
------------------------------------------------------------------------
r5939 | klink@chromium.org | 2008-11-24 23:01:21 +0100 (Mon, 24 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc

Fixes a potential memory leak with a message creation.

Review URL: http://codereview.chromium.org/11579
------------------------------------------------------------------------
r5933 | ben@chromium.org | 2008-11-24 22:28:50 +0100 (Mon, 24 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/common/notification_types.h

rollback
------------------------------------------------------------------------
r5929 | ben@chromium.org | 2008-11-24 21:38:03 +0100 (Mon, 24 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/common/notification_types.h

Re-land r5882 with a crash fix.

http://codereview.chromium.org/11559

------------------------------------------------------------------------
r5927 | ananta@chromium.org | 2008-11-24 20:11:56 +0100 (Mon, 24 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc

Don't reenter Webkit, while it waits for outgoing sync calls to complete. This
fixes bug http://code.google.com/p/chromium/issues/detail?id=4582, which is a crash in the renderer process, which occurs when the renderer receives a sync message requesting accessibility information from the browser, while it waits
for the PluginDestroyed sync call to unwind.

The ViewMsg_GetAccessibilityInfo has a timeout associated with it, which indicates that it is ok for the call to fail. We now turn off the unblock flag on the sync message which will ensure that it does not reenter Webkit in this scenario.

R=jcampan
Bug=4582

Review URL: http://codereview.chromium.org/12402
------------------------------------------------------------------------
r5922 | maruel@chromium.org | 2008-11-24 18:33:44 +0100 (Mon, 24 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/common/notification_types.h

Reverting 5882. It broke LoginPromptTest.TestBasicAuth and .TestTwoAuths.
Review URL: http://codereview.chromium.org/11399
------------------------------------------------------------------------
r5894 | brettw@google.com | 2008-11-22 20:38:00 +0100 (Sat, 22 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/build/base_gfx.vcproj
   D /trunk/src/base/gfx/bitmap_platform_device.h
   D /trunk/src/base/gfx/bitmap_platform_device_linux.h
   D /trunk/src/base/gfx/bitmap_platform_device_mac.h
   D /trunk/src/base/gfx/bitmap_platform_device_win.h
   M /trunk/src/base/gfx/native_theme.cc
   D /trunk/src/base/gfx/platform_canvas_win.h
   D /trunk/src/base/gfx/platform_device.h
   D /trunk/src/base/gfx/platform_device_win.h
   D /trunk/src/base/gfx/vector_canvas.h
   D /trunk/src/base/gfx/vector_device.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/skia/ext/bitmap_platform_device_win.h
   M /trunk/src/skia/ext/platform_canvas_linux.cc
   M /trunk/src/skia/ext/platform_canvas_unittest.cc
   M /trunk/src/skia/ext/vector_canvas.cc
   M /trunk/src/skia/ext/vector_canvas.h
   M /trunk/src/skia/ext/vector_device.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/port/platform/graphics/FontWin.cpp
   M /trunk/src/webkit/port/platform/graphics/GraphicsContextSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_win.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webview_host_win.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host_win.cc

Remove base versions of the graphics headers, which previously just forwarded to the skia ones.
Review URL: http://codereview.chromium.org/11588
------------------------------------------------------------------------
r5892 | sgk@google.com | 2008-11-22 03:00:05 +0100 (Sat, 22 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/views/SConscript

Add new infobar files to SCons build.
Review URL: http://codereview.chromium.org/11380
------------------------------------------------------------------------
r5886 | evanm@google.com | 2008-11-22 01:55:29 +0100 (Sat, 22 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/jankometer.cc

Build fix 2.

------------------------------------------------------------------------
r5885 | evanm@google.com | 2008-11-22 01:51:32 +0100 (Sat, 22 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/jankometer.cc

Build fix.

------------------------------------------------------------------------
r5882 | ben@chromium.org | 2008-11-22 01:40:20 +0100 (Sat, 22 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.cc
   M /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/common/notification_types.h

This change makes the following infobars use the new system:

- save password

Review URL: http://codereview.chromium.org/11559
------------------------------------------------------------------------
r5881 | wtc@google.com | 2008-11-22 01:38:04 +0100 (Sat, 22 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Back out r5252 temporarily to see if it is related to the
crash in ResourceDispatcherHost::OnReadCompleted.

R=eroman
BUG=b/1498134
Review URL: http://codereview.chromium.org/11584
------------------------------------------------------------------------
r5880 | evanm@google.com | 2008-11-22 01:37:21 +0100 (Sat, 22 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/stats_counters.h
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/stats_table.h
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/renderer/net/render_dns_queue.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/port/bindings/scripts/CodeGeneratorV8.pm
   M /trunk/src/webkit/port/bindings/v8/V8MessagePortCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/V8XMLHttpRequestCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/npruntime.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_custom.cpp
   M /trunk/src/webkit/port/platform/chromium/ChromiumBridge.h
   M /trunk/src/webkit/tools/test_shell/mac/main.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Remove use of wide characters in stats table identifiers.

Review URL: http://codereview.chromium.org/11544

------------------------------------------------------------------------
r5858 | ben@chromium.org | 2008-11-21 23:35:11 +0100 (Fri, 21 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/infobar_delegate.h

fix bustage
------------------------------------------------------------------------
r5856 | ben@chromium.org | 2008-11-21 23:27:24 +0100 (Fri, 21 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/infobar_delegate.cc
   A /trunk/src/chrome/browser/infobar_delegate.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/infobars
   A /trunk/src/chrome/browser/views/infobars/infobar_container.cc
   A /trunk/src/chrome/browser/views/infobars/infobar_container.h
   A /trunk/src/chrome/browser/views/infobars/infobars.cc
   A /trunk/src/chrome/browser/views/infobars/infobars.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/notification_types.h

Beginnings of a new InfoBar system.

This implements AlertInfoBar and InfoBarContainer. It also makes the crashed plugin/js oom infobars use this new system.

Design Doc: http://dev.chromium.org/developers/design-documents/info-barshttp://crbug.com/4620

Review URL: http://codereview.chromium.org/11318
------------------------------------------------------------------------
r5855 | sky@google.com | 2008-11-21 23:27:03 +0100 (Fri, 21 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/session_service.cc

Attempt 2 at this fix. I hit after my patch. The problem appears to be
that it is possible for browser list to return a browser with no
window/tabs. This is possible depending upon timing of these. I'm
moving the checks into the session service.

BUG=4666
TEST=no direct way to test this as its rather random. But make sure
  you don't encounter any problems with session restore.

Review URL: http://codereview.chromium.org/11362
------------------------------------------------------------------------
r5854 | erikkay@google.com | 2008-11-21 23:22:41 +0100 (Fri, 21 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Fix a few leaks in SafeBrowsing.  These have been around since the beginning, but have been hit by a particular pattern that's being sent down by the SB servers recently.BUG=http://code.google.com/p/chromium/issues/detail?id=4522
Review URL: http://codereview.chromium.org/11336
------------------------------------------------------------------------
r5850 | evanm@google.com | 2008-11-21 22:27:45 +0100 (Fri, 21 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/stats_counters.h
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/stats_table.h
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/renderer/net/render_dns_queue.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/port/bindings/scripts/CodeGeneratorV8.pm
   M /trunk/src/webkit/port/bindings/v8/V8MessagePortCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/V8XMLHttpRequestCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/npruntime.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_custom.cpp
   M /trunk/src/webkit/port/platform/chromium/ChromiumBridge.h
   M /trunk/src/webkit/tools/test_shell/mac/main.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Rollback "Remove use of wide characters in stats table identifiers."

This reverts commit r5847.

------------------------------------------------------------------------
r5849 | ben@chromium.org | 2008-11-21 21:51:20 +0100 (Fri, 21 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/find_bar_win.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/accessibility/constants.h
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.h
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/client_view.cc
   D /trunk/src/chrome/views/container.h
   D /trunk/src/chrome/views/container_win.cc
   D /trunk/src/chrome/views/container_win.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/tabbed_pane.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   A /trunk/src/chrome/views/widget.h (from /trunk/src/chrome/views/container.h:5835)
   A /trunk/src/chrome/views/widget_win.cc (from /trunk/src/chrome/views/container_win.cc:5835)
   A /trunk/src/chrome/views/widget_win.h (from /trunk/src/chrome/views/container_win.h:5835)
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Rename Container->Widget

R=erg

review url = http://codereview.chromium.org/11348/show

------------------------------------------------------------------------
r5847 | evanm@google.com | 2008-11-21 21:47:00 +0100 (Fri, 21 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/stats_counters.h
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/stats_table.h
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/renderer/net/render_dns_queue.cc
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/port/bindings/scripts/CodeGeneratorV8.pm
   M /trunk/src/webkit/port/bindings/v8/V8MessagePortCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/V8XMLHttpRequestCustom.cpp
   M /trunk/src/webkit/port/bindings/v8/npruntime.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_custom.cpp
   M /trunk/src/webkit/port/platform/chromium/ChromiumBridge.h
   M /trunk/src/webkit/tools/test_shell/mac/main.mm
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Remove use of wide characters in stats table identifiers.

Review URL: http://codereview.chromium.org/11544

------------------------------------------------------------------------
r5846 | glen@chromium.org | 2008-11-21 21:44:16 +0100 (Fri, 21 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/resources/new_tab.html

Fix issue where NTP metrics for restored tabs weren't getting recorded correctly.

BUG=4668

Review URL: http://codereview.chromium.org/11356
------------------------------------------------------------------------
r5844 | sky@google.com | 2008-11-21 21:24:09 +0100 (Fri, 21 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fixes possible crash in creating Browser. The crash could happen
because its possible for the browserwindow to be null when
SaveWindowPlacement is invoked (when the browserwindow is initially
created). If the SessionService ends up asking the browser for the
browserwindow it would get null and crash.

BUG=4666
TEST=no direct way to test this as its rather random. But make sure
  you don't encounter any problems with session restore.

Review URL: http://codereview.chromium.org/11567
------------------------------------------------------------------------
r5832 | pkasting@chromium.org | 2008-11-21 19:57:31 +0100 (Fri, 21 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Discard CHAR events if their corresponding KEY_DOWN events triggered accelerators.

Original patch by Alex Mendes de Costa (alexmdac@gmail.com) on http://codereview.chromium.org/11268, r=me.

BUG=91
------------------------------------------------------------------------
r5831 | pinkerton@google.com | 2008-11-21 19:54:19 +0100 (Fri, 21 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc

Plumb WebCore's windowResizerRect() through glue and renderer. Enables Mac scrollbars to not overlap the in-window resizer widget.
Review URL: http://codereview.chromium.org/11353
------------------------------------------------------------------------
r5797 | sky@google.com | 2008-11-21 00:07:41 +0100 (Fri, 21 Nov 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/dock_info.cc
   A /trunk/src/chrome/browser/dock_info.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/common/slide_animation.h
   M /trunk/src/chrome/common/win_util.cc

Adds various docking positions when dragging around a tab. I've added
the ability to dock to the following locations:

Maximize the window on drop.

Resize the window to fill up the left, bottom, or right half of the
monitor.

Tile the newly created window with an existing chrome window such that
the two are on top of each other and fill the height of the monitor,
or tiled such that they fill the width of the monitor.

The graphics suxor. Glen says he'll come up with something better once
its landed.

BUG=none
TEST=4628

Review URL: http://codereview.chromium.org/11325
------------------------------------------------------------------------
r5794 | kuchhal@chromium.org | 2008-11-20 23:41:52 +0100 (Thu, 20 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

* fix build error

Review URL: http://codereview.chromium.org/11550
------------------------------------------------------------------------
r5793 | kuchhal@chromium.org | 2008-11-20 23:35:45 +0100 (Thu, 20 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

* fix build error

Review URL: http://codereview.chromium.org/11548
------------------------------------------------------------------------
r5791 | kuchhal@chromium.org | 2008-11-20 23:26:53 +0100 (Thu, 20 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.vsprops
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/google_update/google_update_idl.idl

- If the exe rename command fails try calling Google Update to do the same job. This works when we are logged into XP/Vista as limited rights user.
- Update Google Update idl file that has the recently added COM object.
- Add --system-level to the rename command that gets added to the registry.
- Remove all the code to uninstall Gears MSI. Now most of the user have been upgraded to Chrome installer that includes gears.dll.

BUG=1463346

Review URL: http://codereview.chromium.org/11255
------------------------------------------------------------------------
r5778 | jam@chromium.org | 2008-11-20 19:56:50 +0100 (Thu, 20 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_message_filter.cc

Don't CHECK if we couldn't get a handle to the renderer process, it may have just died.

BUG=4267
Review URL: http://codereview.chromium.org/11515
------------------------------------------------------------------------
r5740 | deanm@chromium.org | 2008-11-20 02:08:17 +0100 (Thu, 20 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/base/net_module.cc
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/registry_controlled_domain.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Make the net resource interface use StringPiece instead of std::string.  This means we can point directly into the resource in the binary, instead of copying.  This makes sense for the TLD data, which doesn't need to be copied around.
Review URL: http://codereview.chromium.org/11506
------------------------------------------------------------------------
r5736 | tc@google.com | 2008-11-20 01:38:38 +0100 (Thu, 20 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/base/net_module.cc
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/registry_controlled_domain.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Revert "Make the net resource interface use StringPiece instead of
std::string.  This means we can point directly into the resource in the
binary, instead of copying.  This makes sense for the TLD data, which doesn't
need to be copied around."

This reverts commit r5735.

TBR=deanm

Review URL: http://codereview.chromium.org/11298

------------------------------------------------------------------------
r5735 | deanm@chromium.org | 2008-11-20 01:28:34 +0100 (Thu, 20 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/base/net_module.cc
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/registry_controlled_domain.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Make the net resource interface use StringPiece instead of std::string.  This means we can point directly into the resource in the binary, instead of copying.  This makes sense for the TLD data, which doesn't need to be copied around.
Review URL: http://codereview.chromium.org/11296
------------------------------------------------------------------------
r5733 | sky@google.com | 2008-11-20 01:10:47 +0100 (Thu, 20 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Don't execute a NOTREACHED in TabStrip::DestroyDraggedSourceTab if the
tab strip contains the tab but the model is closing all. Normally the
end of the animation removes the tab, but if we're closing all tabs
the animation isn't run. I was hitting this when I have more than one
window open and drag a tab in a window with a single tab and release
it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/11294
------------------------------------------------------------------------
r5729 | deanm@chromium.org | 2008-11-20 00:44:24 +0100 (Thu, 20 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Cache the generated html for directory listings.  This will allow the net resource provider system to return direct pointers into the resources instead of copying.
Review URL: http://codereview.chromium.org/11501
------------------------------------------------------------------------
r5726 | kuchhal@chromium.org | 2008-11-20 00:05:25 +0100 (Thu, 20 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h

Move creation of 'open with' registry keys to installer. We should place nice and not create these keys on every Chrome start just in case user wants a customized open with list. So now we only create these keys at installation or when user choses to make Chrome default browser. Also we clean them up on uninstall.

BUG=1190855

Review URL: http://codereview.chromium.org/11491
------------------------------------------------------------------------
r5724 | sky@google.com | 2008-11-20 00:01:28 +0100 (Thu, 20 Nov 2008) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h

Fixes crash when showing modal dialog from context menu. With this
sequence ContainerWin remains on the stack while the modal dialog is
showing. Prior to this fix we would delete the ContainerWin, so that
when the modal dialog closed control would return to a deleted
object. The fix is to effectively delay deleting of the ConatinerWins
used by menus.

BUG=4580
TEST=This is the sequence that triggered the crash: open a folder on
  the bookmark bar, right child on a child folder that has more than 15
  descendant URLs, click open all, a dialog should appear asking if you
  really want to open all, click cancel and make sure it doesn't crash.
  This is a subtle change to bookmark menus though, would be good to
  thoroughly exercise the menus in as many permutations as you can
  think of.

Review URL: http://codereview.chromium.org/11289
------------------------------------------------------------------------
r5723 | ben@chromium.org | 2008-11-19 23:53:30 +0100 (Wed, 19 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/status_view.cc
   M /trunk/src/chrome/browser/status_view.h
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_factory.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Re-land this change: http://codereview.chromium.org/10967/show

Now with two improvements:
- no longer create WebContentsViews as WS_VISIBLE, to prevent them from showing up in the taskbar
- make sure overridden CreateView in NativeUIContents and StatusView have the correct signature.

------------------------------------------------------------------------
r5709 | sgk@google.com | 2008-11-19 21:49:47 +0100 (Wed, 19 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Remove chrome\browser\frame_util.cc from the SCons build.
Review URL: http://codereview.chromium.org/11485
------------------------------------------------------------------------
r5705 | deanm@chromium.org | 2008-11-19 21:28:38 +0100 (Wed, 19 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc

Send the chrome.dll base address in the UMA initial log.  This will help us detect address space collisions where chrome.dll is needing to be rebased, and it will help us choose a better base address.

Review URL: http://codereview.chromium.org/6540
------------------------------------------------------------------------
r5700 | deanm@chromium.org | 2008-11-19 20:46:27 +0100 (Wed, 19 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/url_request/url_request_http_job.cc

Enforce httponly on cookies coming from the renderer.  This prevents javascript from setting a new httponly cookie, and more importantly from overwriting httponly cookies.

Patch from Marius Schilder.
Review URL: http://codereview.chromium.org/11275
------------------------------------------------------------------------
r5686 | joshia@google.com | 2008-11-19 19:26:09 +0100 (Wed, 19 Nov 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs.cc

Submitting for developer0420@gmail.com


The LPITEMIDLIST returned from SHBrowseForFolder might not get released if
SHGetPathFromIDList fails

Added in the comment changes

Added GetDisplayNameOf for getting selection, using old way if 
STRRET Structure type does not equal STRRET_WSTR as I was
unable to get complete code coverage.

Added BrowseCallbackProc and listen to MSG so
that we can highlight existing value

Added in the comment changes ( changed to smart pointer for managing
COM interface pointers.)

Review URL: http://codereview.chromium.org/11481
------------------------------------------------------------------------
r5674 | beng@google.com | 2008-11-19 08:24:12 +0100 (Wed, 19 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h

Change by Alex Mendes da Costa <alexmdac@google.com>

Use the most recently used download path when displaying a "save as" dialog. Reset the download path when the user clears the download history.

BUG=293 (http://code.google.com/p/chromium/issues/detail?id=293)

Review URL: http://codereview.chromium.org/10743


------------------------------------------------------------------------
r5669 | ben@chromium.org | 2008-11-19 03:27:16 +0100 (Wed, 19 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   D /trunk/src/chrome/browser/browser_type.h
   D /trunk/src/chrome/browser/frame_util.cc
   D /trunk/src/chrome/browser/frame_util.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/common/notification_types.h

Land this change again now I've fixed the crash.
------------------------------------------------------------------------
r5662 | tc@google.com | 2008-11-19 02:20:01 +0100 (Wed, 19 Nov 2008) | 14 lines
Changed paths:
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_util.cc
   M /trunk/src/base/clipboard_util.h
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/scoped_clipboard_writer.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/common/os_exchange_data.h
   M /trunk/src/chrome/common/os_exchange_data_unittest.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/clipboard_conversion.cc
   M /trunk/src/webkit/glue/webdropdata.cc
   M /trunk/src/webkit/glue/webdropdata.h
   M /trunk/src/webkit/port/platform/chromium/ChromiumDataObject.cpp
   M /trunk/src/webkit/port/platform/chromium/ChromiumDataObject.h
   M /trunk/src/webkit/port/platform/chromium/ClipboardChromium.cpp
   M /trunk/src/webkit/port/platform/chromium/DragDataChromium.cpp

Remove cf_html from webdropdata.h.  This is windows
specific code so we should handle it before we get
to webkit.

CF_HTML needs the source URL to resolve relative URLs
so I added that to the format and plumb it through
from webcore.

I also did some small refactoring so we only have one
implementation of converting to/from CF_HTML and regular
markup.  We can tweak these converters (and add unit tests)
in follow up changes.

Review URL: http://codereview.chromium.org/11247
------------------------------------------------------------------------
r5653 | ben@chromium.org | 2008-11-19 01:25:08 +0100 (Wed, 19 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

put back this change now chromebot has had a chance to run
------------------------------------------------------------------------
r5652 | ben@chromium.org | 2008-11-19 01:19:49 +0100 (Wed, 19 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Make sure the browser window is visible, even if the startup info says that it should be hidden. This fixes the problem of invisible browser window when launched from bash.

http://crbug.com/4438
Review URL: http://codereview.chromium.org/11454
------------------------------------------------------------------------
r5644 | paulg@google.com | 2008-11-18 23:54:04 +0100 (Tue, 18 Nov 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc

Fix a crash that occurs during the browser shutdown process.

It is possible that during the shutdown process, the database thread
posts tasks back to the IO thread which result in calls to the
SafeBrowsing protocol manager object. This object will have been
deleted by the time the posted task runs, resulting in a crash.

This change checks the enabled_ flag (which is set to false when
the shutdown starts) for all tasks posted to the IO thread to
protect against access to deleted objects.

BUG = http://crbug.com/4531

Review URL: http://codereview.chromium.org/11245
------------------------------------------------------------------------
r5638 | ben@chromium.org | 2008-11-18 22:39:55 +0100 (Tue, 18 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

fix bustage
------------------------------------------------------------------------
r5636 | ben@chromium.org | 2008-11-18 22:31:32 +0100 (Tue, 18 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc

Roll back a bunch of changes to tab dragging that seem to not have helped reduce the crashiness any :-/

r5335 dragged_tab_controller.cc (delegate NULL setting)
r5124 changes to make AutomationProvider::WindowSimulateDrag use SendInput instead of SendMessage
r5117 dragged_tab_controller.cc (delegate NULL setting)

------------------------------------------------------------------------
r5608 | maruel@chromium.org | 2008-11-18 17:10:01 +0100 (Tue, 18 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   D /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Revert 5607 because it caused a base_unittest failure.
Review URL: http://codereview.chromium.org/11234
------------------------------------------------------------------------
r5607 | maruel@chromium.org | 2008-11-18 16:41:01 +0100 (Tue, 18 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/base/thread.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   A /trunk/src/chrome/browser/printing/print_job_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add superficial unit test for PrintJob. That's a start.
Add more DCHECKs.
Review URL: http://codereview.chromium.org/10957
------------------------------------------------------------------------
r5598 | nsylvain@chromium.org | 2008-11-18 04:48:01 +0100 (Tue, 18 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   A /trunk/src/chrome/browser/browser_type.h (from /trunk/src/chrome/browser/browser_type.h:5595)
   A /trunk/src/chrome/browser/frame_util.cc (from /trunk/src/chrome/browser/frame_util.cc:5595)
   A /trunk/src/chrome/browser/frame_util.h (from /trunk/src/chrome/browser/frame_util.h:5595)
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/common/notification_types.h

Revert change 5596 because it broke the build
Review URL: http://codereview.chromium.org/11439
------------------------------------------------------------------------
r5597 | paulg@google.com | 2008-11-18 03:03:31 +0100 (Tue, 18 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h

Clean up a friend test declaration.
Review URL: http://codereview.chromium.org/11431
------------------------------------------------------------------------
r5596 | ben@chromium.org | 2008-11-18 03:00:53 +0100 (Tue, 18 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   D /trunk/src/chrome/browser/browser_type.h
   D /trunk/src/chrome/browser/frame_util.cc
   D /trunk/src/chrome/browser/frame_util.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/common/notification_types.h

Last couple of bits of new-frame related cleanup:

- Remove frame_util.cc, moving functions to BrowserList (endsession) and BrowserView (GetBrowserWindowForHWND)
- Tidy up interface for TabIconView model. The model now sources only the information it needs (loading state and favicon).
- Replace BrowserType class with an enum on Browser.

http://crbug.com/2320
http://crbug.com/3363

Review URL: http://codereview.chromium.org/10786
------------------------------------------------------------------------
r5577 | pkasting@chromium.org | 2008-11-17 22:45:19 +0100 (Mon, 17 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

At Yahoo!'s request, add a "fr=crmas" identifier to their prepopulate entries.Also fix up some of the suggest URLs to be more consistent.

BUG=4102
Review URL: http://codereview.chromium.org/11214
------------------------------------------------------------------------
r5576 | pkasting@chromium.org | 2008-11-17 22:40:05 +0100 (Mon, 17 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h

It's possible for GetOleInterface() to return NULL.  Degrade gracefully in this case.

BUG=3906
Review URL: http://codereview.chromium.org/11213
------------------------------------------------------------------------
r5575 | sky@google.com | 2008-11-17 22:32:42 +0100 (Mon, 17 Nov 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h

Attempt at fixing possible crash in ModalHTMLDialogDelegate. It's
possible to get more than one NOTIFY_WEB_CONTENTS_DISCONNECTED. The
first time ModalHTMLDialogDelegate gets a
NOTIFY_WEB_CONTENTS_DISCONNECTED it sets the contents_ to NULL. This
is problematic because the destructor than removes the observer using
a source of NULL. Instead we should remove the observer immediately,
then NULL out the contents_.

BUG=4129
TEST=covered by QEMU

Review URL: http://codereview.chromium.org/11413
------------------------------------------------------------------------
r5574 | sky@google.com | 2008-11-17 22:31:20 +0100 (Mon, 17 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Changes about view to explicitly set the background to white. This way
even though the field is disabled you get a white background.

BUG=4511
TEST=Bring up about chrome and make sure background of version string
  is white.

Review URL: http://codereview.chromium.org/11421
------------------------------------------------------------------------
r5573 | ben@chromium.org | 2008-11-17 22:29:15 +0100 (Mon, 17 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_factory.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Rollback! Now with 25% more HWND.

:-/
------------------------------------------------------------------------
r5560 | sky@google.com | 2008-11-17 17:27:51 +0100 (Mon, 17 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc

Makes opening a bookmark activate the window.

BUG=4447
TEST=see bug

Review URL: http://codereview.chromium.org/10765
------------------------------------------------------------------------
r5555 | ben@chromium.org | 2008-11-17 04:18:05 +0100 (Mon, 17 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

fixing bustage
------------------------------------------------------------------------
r5554 | ben@chromium.org | 2008-11-17 03:49:03 +0100 (Mon, 17 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_factory.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Remove HWND from TabContents creation. 

R=brettw ReviewURL: http://codereview.chromium.org/10967/show
------------------------------------------------------------------------
r5546 | ben@chromium.org | 2008-11-16 04:40:30 +0100 (Sun, 16 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Quick test to locate position of crash on qemu. Will remove after one batch of crashes.
------------------------------------------------------------------------
r5545 | ben@chromium.org | 2008-11-16 04:03:13 +0100 (Sun, 16 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Prevent crashes in QEMU by (correctly) saying no commands are enabled when there is no selected tab. This is significantly simpler than NULL checking all over the place since no one should call ExecuteCommand without first calling IsCommandEnabled.

TBR=sky
Review URL: http://codereview.chromium.org/10783
------------------------------------------------------------------------
r5531 | ananta@chromium.org | 2008-11-15 04:03:30 +0100 (Sat, 15 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/views/tabbed_pane.cc

Fix erase method usage on STL containers in Chrome. Invoking erase on the iterator renders it invalid. We were continuing to use this iterator. 

R=darin

Review URL: http://codereview.chromium.org/10925
------------------------------------------------------------------------
r5529 | jar@google.com | 2008-11-15 03:39:45 +0100 (Sat, 15 Nov 2008) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/base/sdch_filter.cc
   M /trunk/src/net/base/sdch_filter_unittest.cc
   M /trunk/src/net/base/sdch_manager.cc

Open up SDCH for all sites, in preparation for latency tests

Since the stability test is going well (so far) on
".google.com," this change will open up support for SDCH
compression to all sites. This will allow for more
international testing as well.

I tightened down the restrictions on who can set up a dictionary for
a given domain.  I'm pretty sure it is at least as restrictive as the
current SDCH spec.

I also supplied a default expiration time for using an SDCH
dictionary at 30 days (as per SDCH spec).

To be safer with the latency histograms, I also tightened the period of
time we measure, on the off chance that the page some-how asks for more
bytes after everything has been read/rendered.

r=openvcdiff,hunar
Review URL: http://codereview.chromium.org/11009
------------------------------------------------------------------------
r5523 | ben@chromium.org | 2008-11-15 02:10:54 +0100 (Sat, 15 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Remove a bunch of NULL checks that seem unnecessary, and document some checks that are.
Review URL: http://codereview.chromium.org/10962
------------------------------------------------------------------------
r5520 | ben@chromium.org | 2008-11-15 01:32:04 +0100 (Sat, 15 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Make the Browser restore saved last size/position using the WindowDelegate code rather than hand-rolling its own.

Review URL: http://codereview.chromium.org/10959
------------------------------------------------------------------------
r5517 | deanm@chromium.org | 2008-11-15 00:28:29 +0100 (Sat, 15 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/base/rand_util.cc
   M /trunk/src/base/rand_util.h
   M /trunk/src/base/rand_util_posix.cc
   M /trunk/src/base/rand_util_win.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc

RandUInt -> RandUint to match the style of other Uint functions.
Review URL: http://codereview.chromium.org/10767
------------------------------------------------------------------------
r5513 | ben@chromium.org | 2008-11-14 23:40:44 +0100 (Fri, 14 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Rewire the throbber so that the timer for updating lives on BrowserView, not TabStrip, so that app window/popup throbber updating doesn't need to be plumbed through the tabstrip and the browser object!

http://crbug.com/3297
Review URL: http://codereview.chromium.org/10761
------------------------------------------------------------------------
r5511 | brg@chromium.com | 2008-11-14 23:40:19 +0100 (Fri, 14 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Switch to avoid first-run pop-up from displaying while in app-mode.
Review URL: http://codereview.chromium.org/10675
------------------------------------------------------------------------
r5510 | cpu@google.com | 2008-11-14 23:36:24 +0100 (Fri, 14 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

Create first run sentinel file when the distribution param skip_first_run_ui is set
- So we don't do a 'second run UI'

BUG=1485094


Review URL: http://codereview.chromium.org/10708
------------------------------------------------------------------------
r5509 | mbelshe@google.com | 2008-11-14 23:17:25 +0100 (Fri, 14 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/base/system_monitor.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   A /trunk/src/chrome/browser/suspend_controller.cc (from /trunk/src/chrome/browser/suspend_controller.cc:5488)
   A /trunk/src/chrome/browser/suspend_controller.h (from /trunk/src/chrome/browser/suspend_controller.h:5488)
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/views/container_win.h


Review URL: http://codereview.chromium.org/10958
------------------------------------------------------------------------
r5506 | glen@chromium.org | 2008-11-14 21:40:51 +0100 (Fri, 14 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/views/single_split_view.cc
   M /trunk/src/chrome/views/single_split_view.h

Make the bookmark manager blue.


Review URL: http://codereview.chromium.org/11006
------------------------------------------------------------------------
r5502 | ericroman@google.com | 2008-11-14 21:18:09 +0100 (Fri, 14 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Add mimetypes on the "chrome-resource://" responses.
This is necessary to get javascript debugger loading CSS, post-webkit-merge.

http://code.google.com/p/chromium/issues/detail?id=4181

Review URL: http://codereview.chromium.org/10941
------------------------------------------------------------------------
r5497 | ben@chromium.org | 2008-11-14 20:53:42 +0100 (Fri, 14 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

fix bustage
------------------------------------------------------------------------
r5492 | ben@chromium.org | 2008-11-14 20:24:31 +0100 (Fri, 14 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc

Rid most of the Browser object of HWND dependencies.

Review URL: http://codereview.chromium.org/10929
------------------------------------------------------------------------
r5489 | mbelshe@google.com | 2008-11-14 20:07:32 +0100 (Fri, 14 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/base/system_monitor.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   D /trunk/src/chrome/browser/suspend_controller.cc
   D /trunk/src/chrome/browser/suspend_controller.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/views/container_win.h


Change to integrate SystemMonitor changes into chrome.
This enables the dynamic detection of battery status
changes so that we can turn on/off the hi-res timer.




Review URL: http://codereview.chromium.org/10264
------------------------------------------------------------------------
r5488 | agl@chromium.org | 2008-11-14 19:54:02 +0100 (Fri, 14 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons

Port some unit tests in chrome/browser/

This first requires http://codereview.chromium.org/8618 .

Only snippet_unittest is enabled for build. For rest of files
it's only a platform cleanup.

Review URL: http://codereview.chromium.org/8191
Patch from Paweł Hajdan jr.

------------------------------------------------------------------------
r5486 | sgk@google.com | 2008-11-14 19:31:05 +0100 (Fri, 14 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/SConscript

Remove browser\views\frame\browser_view2.cc and
browser\views\old_frames from the SCons build.
Review URL: http://codereview.chromium.org/10723
------------------------------------------------------------------------
r5483 | agl@chromium.org | 2008-11-14 18:48:40 +0100 (Fri, 14 Nov 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/template_url_parser.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/common/l10n_util.h
   A /trunk/src/chrome/views/tree_model.h
   M /trunk/src/chrome/views/tree_node_model.h
   M /trunk/src/chrome/views/tree_view.h
   M /trunk/src/chrome/views/views.vcproj

Port some files in chrome/browser/

#ifdef out windows-specific portion of chrome/common/l10n_util.h,
which allows me to port some other files.

I also extracted parts of chrome/views/tree_view.h to tree_model.h,
so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h
is platform-independent and can be included in files using it as base class.

Review URL: http://codereview.chromium.org/8618
Patch from Paweł Hajdan jr.

------------------------------------------------------------------------
r5481 | petersont@google.com | 2008-11-14 18:23:00 +0100 (Fri, 14 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

New unit test for webdatabase functions that record form entries for autofill.
Review URL: http://codereview.chromium.org/10903
------------------------------------------------------------------------
r5448 | brettw@google.com | 2008-11-14 04:48:21 +0100 (Fri, 14 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc

Fix build bustage, I missed this file with my base namespace changes.
Review URL: http://codereview.chromium.org/10738
------------------------------------------------------------------------
r5446 | brettw@google.com | 2008-11-14 04:25:15 +0100 (Fri, 14 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/gfx/platform_canvas_win.cc
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/process.h
   M /trunk/src/base/process_posix.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_linux.cc
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/base/process_win.cc
   M /trunk/src/base/run_all_perftests.cc
   M /trunk/src/base/run_all_unittests.cc
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/base/shared_memory_unittest.cc
   M /trunk/src/base/shared_memory_win.cc
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/base/trace_event.h
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/result_codes.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/greasemonkey_master.cc
   M /trunk/src/chrome/browser/greasemonkey_master.h
   M /trunk/src/chrome/browser/greasemonkey_master_unittest.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/chrome_process_filter.h
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/process_watcher.cc
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/helper.cc
   M /trunk/src/chrome/installer/util/run_all_unittests.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/greasemonkey_slave.cc
   M /trunk/src/chrome/renderer/greasemonkey_slave.h
   M /trunk/src/chrome/renderer/greasemonkey_slave_unittest.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/visitedlink_slave.cc
   M /trunk/src/chrome/renderer/visitedlink_slave.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/perf/mem_usage.cc
   M /trunk/src/chrome/test/perf/perftests.cc
   M /trunk/src/chrome/test/reliability/run_all_unittests.cc
   M /trunk/src/chrome/test/ui/run_all_unittests.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/unit/run_all_unittests.cc
   M /trunk/src/chrome/tools/convert_dict/convert_dict.cc
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/chrome/tools/profiles/generate_profile.cc
   M /trunk/src/chrome/tools/test/image_diff/image_diff.cc
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/scoped_clipboard_writer_glue.h
   M /trunk/src/webkit/tools/test_shell/run_all_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Add Terminate() to the Process object, have RenderProcessHost use this to avoid some more Windows specific code.

Move Process and SharedMemory into the base namespace (most changes).

Review URL: http://codereview.chromium.org/10895
------------------------------------------------------------------------
r5445 | brettw@google.com | 2008-11-14 04:24:02 +0100 (Fri, 14 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/find_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/label_unittest.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h

Make border and background setting and getting non-virtual and use the correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual.
Review URL: http://codereview.chromium.org/10638
------------------------------------------------------------------------
r5434 | paulg@google.com | 2008-11-14 02:51:18 +0100 (Fri, 14 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Update the user delay histogram for the SafeBrowsing.
Review URL: http://codereview.chromium.org/10916
------------------------------------------------------------------------
r5429 | ben@chromium.org | 2008-11-14 02:20:31 +0100 (Fri, 14 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Fixes the interactive ui tests by correctly initializing the specified popup bounds.

TBR=erg
Review URL: http://codereview.chromium.org/10724
------------------------------------------------------------------------
r5427 | ben@chromium.org | 2008-11-14 02:06:53 +0100 (Fri, 14 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/window_sizer_unittest.cc

Fix build bustage:

- Apparently blank tabs must have NewTabUIURL as their URL.
- flag wasn't initialized.

Review URL: http://codereview.chromium.org/10721
------------------------------------------------------------------------
r5423 | paulg@google.com | 2008-11-14 01:40:47 +0100 (Fri, 14 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Add histograms to measure new SafeBrowsing performance.
Review URL: http://codereview.chromium.org/10712
------------------------------------------------------------------------
r5418 | sgk@google.com | 2008-11-14 01:31:06 +0100 (Fri, 14 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Remove chrome\browser\browser_commands.cc from the SCons build.
Remove a duplicate entry for safe_browsing\safe_browsing_service.cc.
Review URL: http://codereview.chromium.org/10904
------------------------------------------------------------------------
r5417 | ben@chromium.org | 2008-11-14 01:29:05 +0100 (Fri, 14 Nov 2008) | 24 lines
Changed paths:
   M /trunk/src/base/process_util_win.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/app/google_update_client.cc
   M /trunk/src/chrome/app/google_update_client.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_restore.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/web_app_launcher.cc
   M /trunk/src/chrome/browser/web_app_launcher.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.cc
   M /trunk/src/chrome/views/window_delegate.h

Re-do the way browser windows are shown:

- Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo.
- Remove show_command plumbing from all over the place (session restore, web app launcher, etc)

Change the way browser windows are constructed:
- The browser constructor now takes just a type and a profile, and simply initializes the object.
- Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters.
- Window creation is split out into a separate step to be called post configuration.
- Assorted static helper functions added to Browser to make construction of common types easy.
- Remove Browser::Show in favor of BrowserWindow::Show
- Adjust all callers to use the new helpers.

Change the way ChromeViews restores window placement:
- Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState.
- Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds
- Window::Show calls WindowDelegate::RestoreMaximizedState
- Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead.
- Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds.
- Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut.

http://crbug.com/3557

Review URL: http://codereview.chromium.org/10896
------------------------------------------------------------------------
r5416 | sky@google.com | 2008-11-14 01:28:39 +0100 (Fri, 14 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fixes bug where we were not checking if an app from another window
was on top of Chrome's topmost brower window when attempting to dock a
dragged tab.

BUG=1094303
TEST=see bug

Review URL: http://codereview.chromium.org/10715
------------------------------------------------------------------------
r5409 | glen@chromium.org | 2008-11-14 00:51:23 +0100 (Fri, 14 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Stop the search boxes being too wide on RTL languages.

BUG=4365

Review URL: http://codereview.chromium.org/10688
------------------------------------------------------------------------
r5400 | sky@google.com | 2008-11-14 00:19:25 +0100 (Fri, 14 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc

Fixes bug in adding bookmark groups. Adding wasn't setting the
modified date, which meant newly added groups wouldn't show up in the
combobox of the bookmark bubble.

BUG=766
TEST=see bug

Review URL: http://codereview.chromium.org/10709
------------------------------------------------------------------------
r5397 | sky@google.com | 2008-11-14 00:09:49 +0100 (Fri, 14 Nov 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h

Three menu bugs:
. If a context menu was shown from a menu, then hidden we did not keep
  mouse capture and bad things happened (menu wouldn't go away when
   clicking else where, crash ...).
. We only update menu sizes on first show of a menu. That way if a
  context menu doesn't have icons things don't shift around.
. If nothing was selected in the menu pressing the context menu
  showed the context menu for the root. It doesn't make sense for the
  root menu to have a context menu.

BUG=4364
TEST=see bug

Review URL: http://codereview.chromium.org/10706
------------------------------------------------------------------------
r5381 | paulg@google.com | 2008-11-13 22:50:34 +0100 (Thu, 13 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc

Reduce memory consumption by keeping the SafeBrowsing
database closed when not processing updates.

Review URL: http://codereview.chromium.org/10643
------------------------------------------------------------------------
r5367 | sky@google.com | 2008-11-13 21:21:58 +0100 (Thu, 13 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h

Puts chrome menus on a slimfast diet: they are no longer chubby. I
added an option such that menus can be rendered in two ways, chubby or
skinny. The only places that uses the taller menus is the bookmark
bar.

I also made the menus use the right font.

BUG=1074332
TEST=none

Review URL: http://codereview.chromium.org/10865
------------------------------------------------------------------------
r5365 | petersont@google.com | 2008-11-13 21:13:28 +0100 (Thu, 13 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/webdata/web_database.cc

Reordered some logic to fix a bug which caused the clearing of the database to malfunction.

Review URL: http://codereview.chromium.org/10862
------------------------------------------------------------------------
r5354 | sky@google.com | 2008-11-13 20:24:44 +0100 (Thu, 13 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Changes UnloadUITest to navigate to last URL synchronously in hopes of
making ui test more consistent. I suspect I could get the same effect
by changing the last sleep to kMaxTestExecutionTime, but seems best to
use the sync function here.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/10692
------------------------------------------------------------------------
r5335 | beng@google.com | 2008-11-13 08:05:22 +0100 (Thu, 13 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h

Some speculative fixes for UI test flakiness.
- make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests.
- potential crashes caused by NULL TabcontentsDelegates.

TBR=sky
Review URL: http://codereview.chromium.org/10674
------------------------------------------------------------------------
r5329 | pkasting@chromium.org | 2008-11-13 01:19:00 +0100 (Thu, 13 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h

Omnibox metrics logging patch splitout, part 5: Add additional AutocompleteMatch types, and pass a type to the AutocompleteMatch constructor.  The added detail in the new types is not used for anything functional; its sole purpose is for metric logging.  Someday we could probably update other bits of the code to make use of this, though (e.g. the paste-and-search vs. paste-and-go determinant code).

These are separable changes, but doing either one without the other would have required an annoying number of fragile temporary changes.
Review URL: http://codereview.chromium.org/10855
------------------------------------------------------------------------
r5313 | kuchhal@chromium.org | 2008-11-12 23:39:58 +0100 (Wed, 12 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h

* Try to rename chrome exes in shutdown path as well.

BUG=1463346

Review URL: http://codereview.chromium.org/10805
------------------------------------------------------------------------
r5312 | petersont@google.com | 2008-11-12 23:39:14 +0100 (Wed, 12 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h

New functions in WebDatabase and WebDataService for the removal of form entries made between two given times.  BrowserDataRemover::Remove now clears autofill data.

BUG=3870

Review URL: http://codereview.chromium.org/9775
------------------------------------------------------------------------
r5307 | pkasting@chromium.org | 2008-11-12 23:16:09 +0100 (Wed, 12 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h

Omnibox metrics logging patch splitout, part 5: Add TypeToString() helpers.  One of these is unused for the moment.
Review URL: http://codereview.chromium.org/10657
------------------------------------------------------------------------
r5304 | sky@google.com | 2008-11-12 23:10:20 +0100 (Wed, 12 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/base/task.h
   M /trunk/src/base/tuple.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h

Adds the ability for save dialogs to take a default extension.

BUG=4287
TEST=see bug

Review URL: http://codereview.chromium.org/10621
------------------------------------------------------------------------
r5301 | ben@chromium.org | 2008-11-12 22:55:24 +0100 (Wed, 12 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc

Fix infobubble crash due to first run bubble having slightly different initialization path than the bookmarks bubble.

http://crbug.com/4344
Review URL: http://codereview.chromium.org/10849
------------------------------------------------------------------------
r5289 | ben@chromium.org | 2008-11-12 21:50:27 +0100 (Wed, 12 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

Break out command execution from ExecuteCommand implementation into separate functions.
Review URL: http://codereview.chromium.org/10823
------------------------------------------------------------------------
r5286 | mbelshe@google.com | 2008-11-12 21:03:37 +0100 (Wed, 12 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.cc

If setProcessBackgrounded fails, don't continue through
this function.  This is defensive coding being added in
part to see if it doesn't reveal anything interesting 
for bug 1231568

Review URL: http://codereview.chromium.org/11003
------------------------------------------------------------------------
r5281 | kuchhal@chromium.org | 2008-11-12 20:44:02 +0100 (Wed, 12 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/google_update_client.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h

* Need to read version from registry if relaunching browser.

BUG=4316

Review URL: http://codereview.chromium.org/10820
------------------------------------------------------------------------
r5276 | pkasting@chromium.org | 2008-11-12 20:32:49 +0100 (Wed, 12 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc

Omnibox metrics logging patch splitout, part 3: Pass match.type to the edit and let it make the determination about showing the search hint, instead of making the determination in the popup.

In the ultimate patch, the types on which we'll show the hint will expand, so this saved duplicating some logic at points in the popup; in retrospect it makes more sense anyway, since there's no reason for the popup to know anything about the search hint.  That's more the edit's job anyway.
Review URL: http://codereview.chromium.org/10839
------------------------------------------------------------------------
r5271 | pkasting@chromium.org | 2008-11-12 20:19:02 +0100 (Wed, 12 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc

Omnibox metrics logging patch splitout, part 2: Remove the AutocompleteMatch NULL constructor.  It's too easy to forget to set various members with this.

The changes from .resize() to .erase() are necessary because the compiler doesn't know resize() won't be enlarging the vector and thus needing to access the NULL constructor.  The changes to the HistoryContents shortcut code were similarly necessary to avoid a NULL construction, but in the end I think made the resulting code a bit clearer.
Review URL: http://codereview.chromium.org/10837
------------------------------------------------------------------------
r5261 | pkasting@chromium.org | 2008-11-12 18:38:33 +0100 (Wed, 12 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_log.h

Omnibox metrics logging patch splitout, part 1: Random miscellaneous small style and similar changes.  In one or two cases the motivation is not obvious without looking at the original patch.
Review URL: http://codereview.chromium.org/10822
------------------------------------------------------------------------
r5252 | sky@google.com | 2008-11-12 05:27:26 +0100 (Wed, 12 Nov 2008) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Makes sure ResourceDispatcherHost properly cleans up a cancelled
request that is not in a pending state. When we cancel a URLRequest
with no pending IO, nothing happens. This means ResourceDispatcherHost
doesn't clean up its maps and delete the URLRequest.

Another possibility for fixing this is to invoke OnResponseCompleted,
but as the request isn't really completed that may cause other bad
things.

Let me know if you think this should be fixed in another way.

BUG=4302
TEST=see bug

Review URL: http://codereview.chromium.org/10814
------------------------------------------------------------------------
r5246 | ben@chromium.org | 2008-11-12 02:19:57 +0100 (Wed, 12 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/browser_commands.cc

Reorder browser.cc to match style guide, and remove browser_commands.cc

Review URL: http://codereview.chromium.org/10623
------------------------------------------------------------------------
r5236 | ben@chromium.org | 2008-11-12 01:26:06 +0100 (Wed, 12 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc

Reorder functions in browser.h
Also remove unnecessary functions:
- Browser::MoveToFront
- Browser::WindowActivationChanged
- Browser::ExecuteWindowsAppCommand
Also rename function:
- Browser::ShowNativeUI -> Browser::ShowNativeUITab

Review URL: http://codereview.chromium.org/10617
------------------------------------------------------------------------
r5235 | maruel@chromium.org | 2008-11-12 01:17:06 +0100 (Wed, 12 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_indexer.idl

Fix history_indexer.idl to stop from rebuilding it every time.
Review URL: http://codereview.chromium.org/10816
------------------------------------------------------------------------
r5233 | sky@google.com | 2008-11-12 01:05:35 +0100 (Wed, 12 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/views/group_table_view.cc
   M /trunk/src/chrome/views/group_table_view.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h

Changes TableView to have its own mouse handling code so that we can
start a drag when user clicks anywhere on a row.

BUG=4306
TEST=thoroughly test drag and drop of bookmark manager table.

Review URL: http://codereview.chromium.org/9776
------------------------------------------------------------------------
r5222 | ben@chromium.org | 2008-11-11 23:44:44 +0100 (Tue, 11 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

oops
------------------------------------------------------------------------
r5221 | ben@chromium.org | 2008-11-11 23:43:23 +0100 (Tue, 11 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

oops
------------------------------------------------------------------------
r5219 | brettw@google.com | 2008-11-11 23:35:19 +0100 (Tue, 11 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/base/process.h
   M /trunk/src/base/process_posix.cc
   M /trunk/src/base/process_win.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/web_contents.cc

Remove some Windows-specific stuff from RenderProcessHost by having callers get the process handle and PID directly from the corresponding Process object.
Review URL: http://codereview.chromium.org/10608
------------------------------------------------------------------------
r5214 | ben@chromium.org | 2008-11-11 23:27:34 +0100 (Tue, 11 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/session_restore.cc

Remove ShowAndFit variation of Browser::Show, since the "varation" doesn't seem to actually work.

Review URL: http://codereview.chromium.org/10807
------------------------------------------------------------------------
r5212 | erg@google.com | 2008-11-11 23:14:51 +0100 (Tue, 11 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/blocked_popup_container.cc
   M /trunk/src/chrome/browser/views/blocked_popup_container.h

Style fixes to BlockedPopupContainer before I submit
it for my readability review.

Review URL: http://codereview.chromium.org/10606
------------------------------------------------------------------------
r5211 | ben@chromium.org | 2008-11-11 23:03:15 +0100 (Tue, 11 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Move the hang monitor to the BrowserView, since it's highly Windows/HWND specific.

http://crbug.com/4310

Review URL: http://codereview.chromium.org/10601
------------------------------------------------------------------------
r5210 | sidchat@google.com | 2008-11-11 23:01:29 +0100 (Tue, 11 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h

Accept the changes in the UI Language in Options ... -> Language Menu only if "OK" button is clicked - otherwise, discard the changes.

Issue=2835
Review URL: http://codereview.chromium.org/9777
------------------------------------------------------------------------
r5209 | ben@chromium.org | 2008-11-11 22:57:56 +0100 (Tue, 11 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/window_sizer.cc

More cleanup in Browser:

- remove "RunSimpleFrameMenu" method that isn't used anymore.
- rename Browser::GetType() to Browser::type()


Review URL: http://codereview.chromium.org/10605
------------------------------------------------------------------------
r5207 | paulg@google.com | 2008-11-11 22:49:56 +0100 (Tue, 11 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Handle the possibility of failure when starting a
SafeBrowsing update transaction.

If we fail to start the transaction, we report the error
to the protocol manager which aborts the update process.
Review URL: http://codereview.chromium.org/9778
------------------------------------------------------------------------
r5198 | erg@google.com | 2008-11-11 21:13:44 +0100 (Tue, 11 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   A /trunk/src/chrome/test/data/constrained_files/block_alert.html
   A /trunk/src/chrome/test/data/constrained_files/show_alert.html
   A /trunk/src/chrome/test/data/constrained_files/show_alert_2.html

Only block alert() requests from blocked popups; not all popups.

Add two unit tests to make sure we do the right thing; required
adding a bunch of stuff to the automation layer.

Review URL: http://codereview.chromium.org/10282
------------------------------------------------------------------------
r5196 | ben@chromium.org | 2008-11-11 20:33:32 +0100 (Tue, 11 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h

Fix a crash when dismissing an infobubble... could not locate Window*

Review URL: http://codereview.chromium.org/10405
------------------------------------------------------------------------
r5181 | beng@google.com | 2008-11-11 18:53:30 +0100 (Tue, 11 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

These files were missed from my last cleanup CL.
Fix bustage.

------------------------------------------------------------------------
r5180 | beng@google.com | 2008-11-11 18:40:47 +0100 (Tue, 11 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/browser_window.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h

Cleanup and rearrange methods on BrowserWindow interface.

Review URL: http://codereview.chromium.org/10291
------------------------------------------------------------------------
r5178 | ananta@chromium.org | 2008-11-11 18:21:29 +0100 (Tue, 11 Nov 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc

Ensure that windowed plugins get focus during WM_MOUSEACTIVATE. This fixes
bug http://code.google.com/p/chromium/issues/detail?id=4273, which shows up
when windowed plugins enter modal loops like context menu and keyboard navigation
does not work in the menu.

We were not converting the coordinates returned by GetCursorPos to client coordinates correctly, which caused us to miss the child window (Plugin) at times.

This also fixes bug http://code.google.com/p/chromium/issues/detail?id=937, which was an issue with menu selections in Java menus. This occured because we would force 
the child window to have focus in every WM_MOUSEACTIVATE message. In this case the Java plugin window, which is a child of the plugin window already has focus. It receives a WM_KILLFOCUS message due to the forced SetFocus in our handler and takes out the menu, thus ignoring the menu selection. Fix for this issue is to handle WM_MOUSEACTIVATE only if a child window of RenderWidgetHostHWND does not have focus.

R=amit
Bug=4273

Review URL: http://codereview.chromium.org/10004
------------------------------------------------------------------------
r5175 | pinkerton@google.com | 2008-11-11 17:31:13 +0100 (Tue, 11 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/process_util_mac.mm
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

make sure we match all the tests and files that linux has running. We were never building process_posix, but now the newly added unit tests use it.
Review URL: http://codereview.chromium.org/10221
------------------------------------------------------------------------
r5159 | paulg@google.com | 2008-11-11 03:17:51 +0100 (Tue, 11 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h
   D /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add support for 256 bit full hashes to the new implementation.

This CL replaces the following, which seems to have become inaccessible:
http://codereview.chromium.org/9202/

Review URL: http://codereview.chromium.org/10402
------------------------------------------------------------------------
r5152 | ben@chromium.org | 2008-11-11 02:01:43 +0100 (Tue, 11 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   A /trunk/src/chrome/browser/views/frame/browser_view.cc (from /trunk/src/chrome/browser/views/frame/browser_view2.cc:5138)
   A /trunk/src/chrome/browser/views/frame/browser_view.h (from /trunk/src/chrome/browser/views/frame/browser_view2.h:5138)
   D /trunk/src/chrome/browser/views/frame/browser_view2.cc
   D /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Rename BrowserView2 to BrowserView.

http://crbug.com/4286

Review URL: http://codereview.chromium.org/9759
------------------------------------------------------------------------
r5151 | petersont@google.com | 2008-11-11 02:01:09 +0100 (Tue, 11 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/glue/autofill_form.cc
   M /trunk/src/webkit/glue/autofill_form.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc


Review URL: http://codereview.chromium.org/10005
------------------------------------------------------------------------
r5148 | sky@google.com | 2008-11-11 01:35:39 +0100 (Tue, 11 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_request_manager.cc

Fixes bug where carpet bombing dialog would come in some situations it
should not have.

BUG=4136
TEST=see bug for details, along with 4220. You should also verify that
  carpet bombing dialog comes up when it should.

Review URL: http://codereview.chromium.org/10270
------------------------------------------------------------------------
r5139 | ben@chromium.org | 2008-11-11 00:22:51 +0100 (Tue, 11 Nov 2008) | 1 line
Changed paths:
   D /trunk/src/chrome/browser/views/frame/browser_view.cc
   D /trunk/src/chrome/browser/views/frame/browser_view.h

Forgot to remove these files.
------------------------------------------------------------------------
r5130 | ben@chromium.org | 2008-11-10 23:04:15 +0100 (Mon, 10 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/browser/frame_util.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/find_bar_win.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   D /trunk/src/chrome/browser/views/old_frames
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/ui/ui_test.h

Removes the old frames.

http://crbug.com/2324
Review URL: http://codereview.chromium.org/10265
------------------------------------------------------------------------
r5129 | glen@chromium.org | 2008-11-10 22:56:50 +0100 (Mon, 10 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Move 'learn more' in the privacy section to its own line.

BUG=4264


Review URL: http://codereview.chromium.org/9749
------------------------------------------------------------------------
r5125 | sky@google.com | 2008-11-10 22:31:59 +0100 (Mon, 10 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/tree_view.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h

Changes tree/table to pass in an appropriate location when the context
menu is invoked from the keyboard.

BUG=4029
TEST=In the bookmark manager bring up the context menu of the
  tree/table via the menu key and make sure the menu appears at a
  reasonable location.

Review URL: http://codereview.chromium.org/10256
------------------------------------------------------------------------
r5124 | ben@chromium.org | 2008-11-10 22:29:34 +0100 (Mon, 10 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc

Re-land this change now that I've made a speculative fix to the DraggedTabController.
Review URL: http://codereview.chromium.org/10263
------------------------------------------------------------------------
r5121 | glen@chromium.org | 2008-11-10 21:56:31 +0100 (Mon, 10 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/theme/menu_droparrow.png
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/views/menu_button.cc

Minor layout changes that make the bookmark manager and popup blocker look better.

BUG=4271

Review URL: http://codereview.chromium.org/10262
------------------------------------------------------------------------
r5117 | ben@chromium.org | 2008-11-10 20:35:38 +0100 (Mon, 10 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Tweak delegate setting in the DraggedTabController to be more robust. Delegates should be NULLed more aggressively.

Review URL: http://codereview.chromium.org/10235
------------------------------------------------------------------------
r5115 | erg@google.com | 2008-11-10 20:21:45 +0100 (Mon, 10 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   A /trunk/src/chrome/test/data/constrained_files/openclose_main.html
   A /trunk/src/chrome/test/data/constrained_files/openclose_one.html
   A /trunk/src/chrome/test/data/constrained_files/openclose_two.html

Make sure that we deny javascript window.close() requests when we are showing
a blocked popup notification.
Review URL: http://codereview.chromium.org/9709
------------------------------------------------------------------------
r5106 | maruel@chromium.org | 2008-11-10 16:06:38 +0100 (Mon, 10 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Fix tests ImporterTest.Firefox2Importer and Firefox3Importer.

BUG=4185
Review URL: http://codereview.chromium.org/9484
------------------------------------------------------------------------
r5095 | hbono@chromium.org | 2008-11-10 07:42:49 +0100 (Mon, 10 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/webkit/glue/webinputevent_win.cc

Implements a WM_MOUSEHWHEEL message handler.
A change r2266 removed fake scroll bars used to handle WM_MOUSEWHEEL messages. This change prevents Windows from sending WM_HSCROLL messages when tilting a mouse wheel (Windows sends WM_HSCROLL messages only to a window which has scroll bars.) and this causes a regression problem that we cannot use tilt-wheel to scroll horizontally.
To solve this problem, this change implements a WM_MOUSEHWHEEL (0x020E) message handler to dispatch tilt-wheel events to the RenderWidgetHostViewWin::OnWheelEvents() function. Also, It changes scroll direction in creating a WebMouseWheelEvent instance.
Review URL: http://codereview.chromium.org/9319
------------------------------------------------------------------------
r5059 | petersont@google.com | 2008-11-08 03:38:04 +0100 (Sat, 08 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc


Review URL: http://codereview.chromium.org/10237
------------------------------------------------------------------------
r5058 | petersont@google.com | 2008-11-08 03:13:09 +0100 (Sat, 08 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autofill_manager.cc
   M /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc

Entries in a form get recorded when the user submits the form.  Database and pop-up menu talk to each other.  Pop-up menu appears containing suggestions.
Review URL: http://codereview.chromium.org/9462
------------------------------------------------------------------------
r5057 | kuchhal@chromium.org | 2008-11-08 02:37:06 +0100 (Sat, 08 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

* Create unique event in global namespace
so that we can detect Chrome instances across user sessions.

Review URL: http://codereview.chromium.org/10234
------------------------------------------------------------------------
r5052 | sgk@google.com | 2008-11-08 01:52:23 +0100 (Sat, 08 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Add history/history_publisher.cc and history/history_indexer.idl.
Review URL: http://codereview.chromium.org/9719
------------------------------------------------------------------------
r5048 | sgk@google.com | 2008-11-08 01:29:01 +0100 (Sat, 08 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Add chrome\browser\autofill_manager.cc and
chrome\browser\net\referrer.cc to the SCons build (on Windows).
Review URL: http://codereview.chromium.org/9710
------------------------------------------------------------------------
r5046 | ben@chromium.org | 2008-11-08 01:11:31 +0100 (Sat, 08 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc

Roll this change back until I understand the crashes.

------------------------------------------------------------------------
r5031 | brg@chromium.com | 2008-11-08 00:18:04 +0100 (Sat, 08 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Removed lint problems.  NO funcationality changes.
Review URL: http://codereview.chromium.org/10219
------------------------------------------------------------------------
r5030 | nsylvain@chromium.org | 2008-11-08 00:13:58 +0100 (Sat, 08 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc

We have a crash caused by view_ being NULL here.

Everywhere else in this class we look to see
if view_ is NULL before dereferencing it, except
in this case.

This would fix a crash found in the distributed tests.

BUG: 1074508

Review URL: http://codereview.chromium.org/9674
------------------------------------------------------------------------
r5028 | paulg@google.com | 2008-11-08 00:05:33 +0100 (Sat, 08 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc

Update the SafeBrowsing protocol version to 2.2, which handles
- Zero sized chunks
- Redirect URL format changes

http://crbug.com/3418

Review URL: http://codereview.chromium.org/10222
------------------------------------------------------------------------
r5027 | glen@chromium.org | 2008-11-08 00:05:24 +0100 (Sat, 08 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc

Looks like a size method got left behind in the gfx update. Also make sure that we only restore the page info window position, but not the size.

Plus some dead code removal in options_window_view.

BUG=3509

Review URL: http://codereview.chromium.org/10218
------------------------------------------------------------------------
r5026 | sky@google.com | 2008-11-08 00:05:11 +0100 (Sat, 08 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Fixes bug in building filter string for open dialog that resulted in
showing garbage in files types combobox.

BUG=4211
TEST=bring up bookmark manager, click on import, click on 'files of
  type' and make sure you only see *.html.

Review URL: http://codereview.chromium.org/10225
------------------------------------------------------------------------
r5018 | jcampan@chromium.org | 2008-11-07 22:35:03 +0100 (Fri, 07 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/web_contents_view.cc
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/autocomplete_input_listener.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   A /trunk/src/webkit/glue/form_autocomplete_listener.cc
   A /trunk/src/webkit/glue/form_autocomplete_listener.h
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl_mac.mm
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/port/page/chromium/ChromeClientChromium.h
   M /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.cpp
   M /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.h
   M /trunk/src/webkit/webkit.xcodeproj/project.pbxproj

Landing this again as I cannot reproduce the perf regression locally.
Will investigate on the bot.

TBR=nsylvain


Review URL: http://codereview.chromium.org/9700
------------------------------------------------------------------------
r5014 | ben@chromium.org | 2008-11-07 21:24:24 +0100 (Fri, 07 Nov 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc

Make AutomationProvider::WindowSimulateDrag use SendInput instead of sending messages directly to the targeted window.

http://crbug.com/4067


Review URL: http://codereview.chromium.org/9485
------------------------------------------------------------------------
r5005 | erg@google.com | 2008-11-07 20:28:16 +0100 (Fri, 07 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc

Updates one of the unit tests I disabled when I rewrote the popup blocker UI.
Review URL: http://codereview.chromium.org/10206
------------------------------------------------------------------------
r5003 | brettw@google.com | 2008-11-07 20:18:10 +0100 (Fri, 07 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database_manager.cc

Fix initialization order to fix Mac & Linux.
Review URL: http://codereview.chromium.org/10209
------------------------------------------------------------------------
r5002 | brettw@google.com | 2008-11-07 20:03:40 +0100 (Fri, 07 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser.vsprops
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   A /trunk/src/chrome/browser/history/history_indexer.idl
   A /trunk/src/chrome/browser/history/history_publisher.cc
   A /trunk/src/chrome/browser/history/history_publisher.h
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Added a new interface IChromeHistoryIndexer which needs to be implemented by
indexers which are interested in indexing Chrome's web history. These should
register their CLSID in HKCU\Software\Google\Google Chrome\IndexerPlugins and
this is be used by Chrome to publish its index.
Added code to publish the index too.

Checked in for Vijay Thadkal <veejay.t.s@gmail.com> (Google). Reitveld #9007.
------------------------------------------------------------------------
r4993 | sky@google.com | 2008-11-07 18:53:09 +0100 (Fri, 07 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/tree_view.h

Adds cut/copy/paste support to the bookmark manager tree/table and
context menus.

BUG=4186
TEST=try cut/copy/paste from table/tree in the bookmark manager as
  well as context menus in bookmark manager.

Review URL: http://codereview.chromium.org/9481
------------------------------------------------------------------------
r4988 | brettw@google.com | 2008-11-07 17:13:31 +0100 (Fri, 07 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Fix crash in the icon manager. The decoding could be NULL, which would then get
dereferenced in specific cases. We would have to create the failed icon twice,
so that it would think the icon was already in the cache, when in fact a NULL
value was being cached.

BUG=1259695
Review URL: http://codereview.chromium.org/9672
------------------------------------------------------------------------
r4968 | sky@google.com | 2008-11-07 05:31:35 +0100 (Fri, 07 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/base/task.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_html_writer.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/tree_view.h
   M /trunk/src/net/base/escape.h

Adds import/export of bookmarks to bookmarks.html file.

BUG=1649
TEST=bring up bookmark manager and try out import/export from the
     tools menu. Note that import ALWAYS creates a new folder under
     the 'Other bookmarks folder' with the name of Imported (x). This
     is by design.

Review URL: http://codereview.chromium.org/9471
------------------------------------------------------------------------
r4960 | cpu@google.com | 2008-11-07 04:28:44 +0100 (Fri, 07 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h

Potential fix for FF importing issue
- Select the highest FF version, not just the the HCKU one.
- I don't have a repro case, it is a blind fix

Seems like leftovers of old FF installs in HCKU are tripping us, that
is my guess, now we would find FF3 in HKLM.

BUG=3109


Review URL: http://codereview.chromium.org/9675
------------------------------------------------------------------------
r4949 | kuchhal@chromium.org | 2008-11-07 02:27:57 +0100 (Fri, 07 Nov 2008) | 16 lines
Changed paths:
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup_constants.cc
   M /trunk/src/chrome/installer/setup/setup_constants.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   A /trunk/src/chrome/installer/util/delete_reg_value_work_item.cc
   A /trunk/src/chrome/installer/util/delete_reg_value_work_item.h
   A /trunk/src/chrome/installer/util/delete_reg_value_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/installer_unittests.vcproj
   M /trunk/src/chrome/installer/util/util.vcproj
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/installer/util/work_item.cc
   M /trunk/src/chrome/installer/util/work_item.h
   M /trunk/src/chrome/installer/util/work_item_list.cc
   M /trunk/src/chrome/installer/util/work_item_list.h

Implement the new mechanism we are going to use for handling Chromium updates
while it is in use. This should work for per user as well as system level
installs (after some additional changes once Google Update changes are ready).
The following scenarios should work now:
- If Chromium is using two different profiles at the same time we do not switch
chrome executables until all of them are closed.
- The old version of Chromium can be run after a restart if the renaming of
executables fails.
- We will not use environment variable any more but we need to keep it until all
the users get this change on their machines.
- opv/rename registry keys and new_chrome.exe should always together. If one
exist all three should exist because they are created and deleted as one atomic
operation (as much as possible given laws of physics).
BUG=1463346

Review URL: http://codereview.chromium.org/9436
------------------------------------------------------------------------
r4940 | jcampan@chromium.org | 2008-11-07 01:35:36 +0100 (Fri, 07 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc

A crasher would happen if you donwload an exe and the download has completed by the time the download item is created, you have the download tab opened and you press on the discard button.
This is because such downloads gets added to a vector that is used to unregister the DownloadTabView as an observer.
We were deleting the download item before notifying the DownloadTabView, which would cause it to access the deleted download item.

BUG=4134
TEST=Open the download tab, start the download of a short exe. Click the discard button in the dangerous download prompt.
Review URL: http://codereview.chromium.org/9435
------------------------------------------------------------------------
r4935 | ojan@google.com | 2008-11-07 01:12:25 +0100 (Fri, 07 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Continue with crosssite navigations if alerts are suppressed
in an unload handler (i.e. we have an infinite-ish alert loop).
Review URL: http://codereview.chromium.org/9477
------------------------------------------------------------------------
r4934 | erg@google.com | 2008-11-07 01:08:26 +0100 (Fri, 07 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/web_contents.cc

Prevent window.close() working from Javascript when a blocked popup notification exists. This is a copy of Firefox's behaviour.

BUG=crbug.com/4007
Review URL: http://codereview.chromium.org/9656
------------------------------------------------------------------------
r4929 | jar@google.com | 2008-11-07 00:32:53 +0100 (Fri, 07 Nov 2008) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   A /trunk/src/chrome/browser/net/referrer.cc
   A /trunk/src/chrome/browser/net/referrer.h
   M /trunk/src/net/base/dns_resolution_observer.cc
   M /trunk/src/net/base/dns_resolution_observer.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_transaction_winhttp.cc

Adaptively identify URL subresources and pre-resolve hosts via DNS

Use the HTTP "referer" header to identify subresources used during a
page load.  Store that info, and use it when next visiting the referenced
hosts to pre-resolve the (probably) needed subresources.

This set of changes will surely evolve as we see how it plays out
on broader distribution (via histogram measurments), but this should be
the foundation of the change.

In design specs, this was previously referred to as "adaptive correlated
DNS prefetching."

r=mbelshe


Review URL: http://codereview.chromium.org/9168
------------------------------------------------------------------------
r4912 | glen@chromium.org | 2008-11-06 22:27:37 +0100 (Thu, 06 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/printing/page_overlays.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/common/common.scons
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/gfx/text_elider.cc (from /trunk/src/chrome/common/gfx/url_elider.cc:4387)
   A /trunk/src/chrome/common/gfx/text_elider.h (from /trunk/src/chrome/common/gfx/url_elider.h:4387)
   A /trunk/src/chrome/common/gfx/text_elider_unittest.cc (from /trunk/src/chrome/common/gfx/url_elider_unittest.cc:4387)
   D /trunk/src/chrome/common/gfx/url_elider.cc
   D /trunk/src/chrome/common/gfx/url_elider.h
   D /trunk/src/chrome/common/gfx/url_elider_unittest.cc
   M /trunk/src/chrome/test/unit/unit_tests.scons
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/tooltip_manager.cc

Add a function for eliding filenames to a set pixel width while preserving the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208
Review URL: http://codereview.chromium.org/9613
------------------------------------------------------------------------
r4908 | jcampan@chromium.org | 2008-11-06 21:09:34 +0100 (Thu, 06 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/web_contents_view.cc
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/autocomplete_input_listener.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   D /trunk/src/webkit/glue/form_autocomplete_listener.cc
   D /trunk/src/webkit/glue/form_autocomplete_listener.h
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl_mac.mm
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/port/page/chromium/ChromeClientChromium.h
   M /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.cpp
   M /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.h

Reverting the autofill popu CL as it creates perf regression.

TBR=nsylvain

Review URL: http://codereview.chromium.org/9460
------------------------------------------------------------------------
r4906 | ojan@google.com | 2008-11-06 21:06:43 +0100 (Thu, 06 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Enable unload UI tests again, but don't run them for single-process.
Review URL: http://codereview.chromium.org/9464
------------------------------------------------------------------------
r4872 | hbono@chromium.org | 2008-11-06 08:40:53 +0100 (Thu, 06 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/ime_input.cc
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/browser/render_widget_host_view.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h

Changes parameters used by IME code to fix several issues caused by Japanese IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.

BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
------------------------------------------------------------------------
r4870 | finnur@google.com | 2008-11-06 05:41:29 +0100 (Thu, 06 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/app/theme/chromium/about_background.png
   A /trunk/src/chrome/app/theme/chromium/about_background_color.png
   M /trunk/src/chrome/app/theme/chromium/about_background_rtl.png
   M /trunk/src/chrome/app/theme/distribution_resources.rc
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Fix Large Font issues in About box (issue 2458).

Review URL: http://codereview.chromium.org/9432
------------------------------------------------------------------------
r4867 | brg@chromium.com | 2008-11-06 04:31:06 +0100 (Thu, 06 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.cc
   M /trunk/src/chrome/browser/importer/toolbar_importer.h
   A /trunk/src/chrome/browser/importer/toolbar_importer_unittest.cc

Toolbar Importer Pass2
Implements the following features
1.  Toolbar import always available after first run
2.  Deduping of imported favorites
3.  Removes attempt to import favicons (not supported through Toolbar UI atm)
4.  Always the user to cancel from the UI safely
5.  Unittests for parsing
(TODO Better UI for login)
Review URL: http://codereview.chromium.org/9414
------------------------------------------------------------------------
r4861 | ojan@google.com | 2008-11-06 03:06:55 +0100 (Thu, 06 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/unload_uitest.cc

Disable new tests that are failing on buildbot.
Review URL: http://codereview.chromium.org/9446
------------------------------------------------------------------------
r4855 | ojan@google.com | 2008-11-06 02:18:56 +0100 (Thu, 06 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   A /trunk/src/chrome/browser/unload_uitest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   A /trunk/src/chrome/test/data/unload/beforeunloadlooping.html
   M /trunk/src/chrome/test/data/unload/nolisteners.html
   M /trunk/src/chrome/test/data/unload/unload.html
   M /trunk/src/chrome/test/data/unload/unloadlooping.html
   M /trunk/src/chrome/test/data/unload/unloadloopingalert.html
   M /trunk/src/chrome/test/data/unload/unloadloopingtwosecondsalert.html
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Bandaid patch so that we continue with crosssite navigations  instead of closing the tab if the beforeunload /unload handler hangs. This patch does the right user-visible behavior, but I'm not a huge fan of the plumbing necessary to make it work. Totally open to cleanup suggestions.

There's also currently one bug that I haven't been able to pinpoint in the UI test. It only treats the first UI test of the four that I run as a cross-site navigation. No matter which test I run first. I wonder if there is some state I should be setting/clearing before/after each test run?

Also there's a DHECK that we hit that the UI test exposed. I 'm not sure it's a case that a user could actually hit though and it's not new with this code, so I added a TODO.

Can I get help from a mac person on adding the UI test to the xcode project?

BUG=3198
Review URL: http://codereview.chromium.org/8920
------------------------------------------------------------------------
r4846 | darin@chromium.org | 2008-11-06 01:36:52 +0100 (Thu, 06 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   M /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/webcursor.cc
   M /trunk/src/webkit/glue/webcursor.h
   A /trunk/src/webkit/glue/webcursor_win.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/port/page/chromium/ChromeClientChromium.h
   M /trunk/src/webkit/port/platform/chromium/ChromiumBridge.h
   M /trunk/src/webkit/port/platform/chromium/CursorChromium.cpp
   M /trunk/src/webkit/port/platform/chromium/PlatformCursor.h
   M /trunk/src/webkit/port/platform/chromium/WidgetChromium.cpp
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Eliminate CursorChromium's dependency on webkit/glue.

Also modified WidgetChromium to use ChromiumBridge instead of talking to ChromeClientChromium.  I want to eliminate that fake interface in favor of just having our code talk directly to ChromeClientImpl, but that means a dependency on webkit/glue, so I needed to use ChromiumBridge.  Long-term, I'd like to propose changes upstream to HostWindow and ChromeClient to avoid this usage of ChromiumBridge.

The most impactful part of this CL is the change to move the enumeration of cursor types from WebCursor to PlatformCursor.  This means that WebCursor consumers no longer have access to the type enumeration.  I replaced that with helper functions on WebCursor.  I think the result not only achieves the goal of breaking CursorChromium's dependency on webkit/glue but is also much cleaner.

R=iyengar,eseidel
Review URL: http://codereview.chromium.org/9072
------------------------------------------------------------------------
r4839 | agl@chromium.org | 2008-11-06 00:39:02 +0100 (Thu, 06 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/thumbnail_database.h

Whitespace typo fix from CL 8722

Review URL: http://codereview.chromium.org/9611

------------------------------------------------------------------------
r4833 | jar@google.com | 2008-11-05 23:51:49 +0100 (Wed, 05 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_host_info.cc

Add two UMA histograms for DNS prefetching

I have a more complex change list, and wanted to be able to carefully
constrast the before-and-after impact.  

r=mbelshe

Review URL: http://codereview.chromium.org/9166
------------------------------------------------------------------------
r4825 | amit@chromium.org | 2008-11-05 23:24:09 +0100 (Wed, 05 Nov 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h

Quick and easy fix for vista taskbar auto hide issue

In vista we designate the main frame border as a part
of non-client area. This is similar to a popup window having resizing 
border. The default logic to maximize such a window, stretches the
borders outside of the screen and the client area occupies the entire
work area. As a result windows taskbar treats it as a 'full screen'
application and hides itself in an auto-hide mode.

An XP-like fix for this, that is to reduce client area vertically by 
one pixel, would most likely involve overriding WM_SYSCOMMAND of 
SC_MAXIMIZE. Hence, this is a cheap, although a bit ugly fix in 
WM_GETMINMAXINFO handling.


BUG=20


Review URL: http://codereview.chromium.org/9305
------------------------------------------------------------------------
r4811 | brettw@google.com | 2008-11-05 21:37:56 +0100 (Wed, 05 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/common/sqlite_utils.cc

Don't crash when getting strings out of the database. column_text is a little dangerous because it can return NULL. Most STL string stuff can't handle this.  I changed the uses to column_string() which handles NULL properly and generates STL strings for us.

BUG=3770
Review URL: http://codereview.chromium.org/9189
------------------------------------------------------------------------
r4809 | petersont@google.com | 2008-11-05 21:26:28 +0100 (Wed, 05 Nov 2008) | 2 lines
Changed paths:
   A /trunk/src/chrome/browser/autofill_manager.cc
   A /trunk/src/chrome/browser/autofill_manager.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/webkit/glue/webview_delegate.h

Added functions to WebDatabase and WebDataService for recording frequent entries in text input elements in forms.  Also added the class AutofillManager which gets instantiated once per WebContents and provides an API from which the database can be easily accessed to provide a list of possible desired values to be entered in a text field given what the user has already typed there.
Review URL: http://codereview.chromium.org/8845
------------------------------------------------------------------------
r4808 | ben@chromium.org | 2008-11-05 21:21:45 +0100 (Wed, 05 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Roll back. Sigh. Still not fixed.

------------------------------------------------------------------------
r4804 | jcampan@chromium.org | 2008-11-05 20:28:08 +0100 (Wed, 05 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/web_contents_view.cc
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/render_widget_unittest.cc
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/autocomplete_input_listener.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   A /trunk/src/webkit/glue/form_autocomplete_listener.cc
   A /trunk/src/webkit/glue/form_autocomplete_listener.h
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webplugin_impl_mac.mm
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/port/page/chromium/ChromeClientChromium.h
   M /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.cpp
   A /trunk/src/webkit/port/platform/chromium/PopupMenuChromium.h

This CL adds the autofill UI in forms.
When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup.

Listeners are set on the form text field in a similar fashion than for password save.

The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows.
The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown.
Review URL: http://codereview.chromium.org/8885
------------------------------------------------------------------------
r4803 | ben@chromium.org | 2008-11-05 20:18:58 +0100 (Wed, 05 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Reinstate this commented-out code now the root cause of the problem has been fixed.

------------------------------------------------------------------------
r4802 | ben@chromium.org | 2008-11-05 20:15:00 +0100 (Wed, 05 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Some bandaids for tab dragging UI tests:

- automation provider was moving mouse pointer to position in client coords, not
screen coords as required.
- TabStrip was allowing drags to occur in invalid conditions.

This doesn't completely fix the underlying broken-ness of the SimulateDrag
function, however I've not yet been able to get a version of it using SendInput
working.

http://crbug.com/4067
------------------------------------------------------------------------
r4799 | erg@google.com | 2008-11-05 20:03:25 +0100 (Wed, 05 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/menu_droparrow.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/SConscript
   A /trunk/src/chrome/browser/views/blocked_popup_container.cc
   A /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_animation.cc
   M /trunk/src/chrome/browser/views/constrained_window_animation.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/views/menu_button.cc

This is r4523, with a few changes to make things work under Vista.

- Explicitly set_delegate(NULL) before releasing a TabContents. (I think
  the order messages are getting handled is different from XP; this only
  seems neccessary under Vista.)
- r4523 and someone elses change added entries to theme_resources.rc at
  roughly the same time, causing happy fun crashes.
- Roll in sgk's SConscript fix.

Review URL: http://codereview.chromium.org/9373
------------------------------------------------------------------------
r4797 | rvargas@google.com | 2008-11-05 19:53:45 +0100 (Wed, 05 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/sandbox_policy.cc

New batch of dlls to evict from the render process (top crashers).

Review URL: http://codereview.chromium.org/9376
------------------------------------------------------------------------
r4792 | nsylvain@chromium.org | 2008-11-05 19:35:49 +0100 (Wed, 05 Nov 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc

When a windowless plugin is hanging, the browser process
is also hanging because of the "dummy activation window".

Unfortunately we used to skip the hung plugin notification
dialog for this window. I'm changing this behavior to display
it even for this window.

We don't know what plugin it is, so we just display "an
unknown plugin", but this is better than nothing.

This is a potential fix for 3383.

I do not expect to completely fix 3383 with it, but it
should help minimize the problem.

bug:3383


Review URL: http://codereview.chromium.org/9386
------------------------------------------------------------------------
r4788 | maruel@chromium.org | 2008-11-05 19:16:57 +0100 (Wed, 05 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Make the test "pass" when the internal data is not found.
Review URL: http://codereview.chromium.org/9416
------------------------------------------------------------------------
r4782 | sgk@google.com | 2008-11-05 18:20:22 +0100 (Wed, 05 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons
   M /trunk/src/chrome/views/SConscript

Add to SCons build:
chrome\browser\bookmarks\bookmark_drop_info.cc
chrome\browser\importer\toolbar_importer.cc
chrome\views\view_constants.cc
Review URL: http://codereview.chromium.org/9387
------------------------------------------------------------------------
r4780 | sky@google.com | 2008-11-05 16:39:44 +0100 (Wed, 05 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_test.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Fixes two bookmark manager bugs:
. Pressing enter when more than one folder is selected opens them all.
. Show in folder is only enabled when it makes sense: you've selected a
  bookmark in the table and the table is showing recently bookmarked
  or search results.

BUG=4034 4044
TEST=see bugs

Review URL: http://codereview.chromium.org/9367
------------------------------------------------------------------------
r4769 | abarth@chromium.org | 2008-11-05 10:25:22 +0100 (Wed, 05 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   A /trunk/src/chrome/test/data/download-test3.gif (from /trunk/src/chrome/test/data/download-test3.html:4603)
   A /trunk/src/chrome/test/data/download-test3.gif.mock-http-headers (from /trunk/src/chrome/test/data/download-test3.html.mock-http-headers:4603)
   D /trunk/src/chrome/test/data/download-test3.html
   D /trunk/src/chrome/test/data/download-test3.html.mock-http-headers

Tell the user that HTML documents can harm their computer because they can. 
This patch blocks all the extensions that we register.

R=nsylvain
BUG=1463961


------------------------------------------------------------------------
r4728 | sgk@google.com | 2008-11-05 02:57:11 +0100 (Wed, 05 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Remove duplicate save_file.cc from the Windows-specific list.
Review URL: http://codereview.chromium.org/9153
------------------------------------------------------------------------
r4723 | agl@chromium.org | 2008-11-05 02:41:22 +0100 (Wed, 05 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc

Wrap forward declarations in their relevant namespace

Forward declarations can't simply use "class $namespace::$class;" syntax.  Instead one needs to use "namespace $namespace { class $class; }" syntax.

Review URL: http://codereview.chromium.org/8722
Patch from James Vega.

------------------------------------------------------------------------
r4721 | maruel@chromium.org | 2008-11-05 02:38:01 +0100 (Wed, 05 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/test/data/ssl
   A /trunk/src/chrome/test/data/ssl/certificates
   A /trunk/src/chrome/test/data/ssl/certificates/expired_cert.pem
   A /trunk/src/chrome/test/data/ssl/certificates/invalid_cert.pem
   A /trunk/src/chrome/test/data/ssl/certificates/ok_cert.pem
   A /trunk/src/chrome/test/data/ssl/certificates/root_ca_cert.crt

Add the test certificates. Rename the directory to make the transition easier.

BUG=b/1330770
Review URL: http://codereview.chromium.org/9332
------------------------------------------------------------------------
r4719 | estade@chromium.org | 2008-11-05 02:34:30 +0100 (Wed, 05 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/build/base.vcproj
   A /trunk/src/base/clipboard.cc
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_linux.cc
   M /trunk/src/base/clipboard_mac.mm
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   A /trunk/src/base/scoped_clipboard_writer.cc
   A /trunk/src/base/scoped_clipboard_writer.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   D /trunk/src/chrome/common/clipboard_service.cc
   M /trunk/src/chrome/common/clipboard_service.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/webkit/build/glue/glue.vcproj
   A /trunk/src/webkit/glue/scoped_clipboard_writer_glue.h
   M /trunk/src/webkit/glue/simple_clipboard_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/port/platform/win/PasteboardWin.cpp

Rewrote the clipboard API to be more concurrent. Added a helper class to make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org

Review URL: http://codereview.chromium.org/9154
------------------------------------------------------------------------
r4717 | brettw@google.com | 2008-11-05 01:51:37 +0100 (Wed, 05 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Evil hack to prevent a crash with interstitials across different tab contents types.

BUG=2855
Review URL: http://codereview.chromium.org/9141
------------------------------------------------------------------------
r4713 | kuchhal@chromium.org | 2008-11-05 01:21:16 +0100 (Wed, 05 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/installer/setup/main.cc

Temporary code to upgrade Chrome open command for existing users.

From 'chrome %1' to 'chrome -- %1'. For more information see r4016 and crbug.com/3808

Review URL: http://codereview.chromium.org/8988
------------------------------------------------------------------------
r4705 | ananta@chromium.org | 2008-11-05 00:38:32 +0100 (Wed, 05 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/app/google_update_client.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/install_util.h

This fixes the following bugs1. http://b/issue?id=1447957   For machine installs we need to use a different version of the Omaha updater.2. http://b/issue?id=1447951   For Vista we need to elevate while performing the update operation. This only applies to machine installs. Update checks also instantiate the same COM object. However it does not need elevation.Bug=1447957, 1447951R=finnur, kuchhal
Review URL: http://codereview.chromium.org/8221
------------------------------------------------------------------------
r4700 | ericroman@google.com | 2008-11-04 23:44:00 +0100 (Tue, 04 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Fix typo.

Review URL: http://codereview.chromium.org/9371
------------------------------------------------------------------------
r4688 | huanr@chromium.org | 2008-11-04 23:23:17 +0100 (Tue, 04 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   A /trunk/src/chrome/installer/util/master_preferences.cc
   A /trunk/src/chrome/installer/util/master_preferences.h
   M /trunk/src/chrome/installer/util/util.vcproj

Refactoring master preference parsing code into installer util so
it can be shared by first run and set up. There is no functionality
change in this CL.

Review URL: http://codereview.chromium.org/9338
------------------------------------------------------------------------
r4649 | maruel@chromium.org | 2008-11-04 21:57:58 +0100 (Tue, 04 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_parser_unittest.cc

Fix the TemplateURLParserTest tests for use in external buildbots.
Review URL: http://codereview.chromium.org/8222
------------------------------------------------------------------------
r4633 | brg@chromium.com | 2008-11-04 20:54:49 +0100 (Tue, 04 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   A /trunk/src/chrome/browser/importer/toolbar_importer.cc
   A /trunk/src/chrome/browser/importer/toolbar_importer.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h

Toolbar Import - Issue 8801, migrated from public tree to svn enlistment.
------------------------------------------------------------------------
r4629 | sgk@google.com | 2008-11-04 20:34:31 +0100 (Tue, 04 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   D /trunk/src/chrome/browser/debugger/SConscript
   A /trunk/src/chrome/browser/debugger/debugger.scons (from /trunk/src/chrome/browser/debugger/SConscript:4526)
   M /trunk/src/chrome/chrome.scons
   D /trunk/src/chrome/test/interactive_ui/SConscript
   A /trunk/src/chrome/test/interactive_ui/interactive_ui_tests.scons (from /trunk/src/chrome/test/interactive_ui/SConscript:4526)
   M /trunk/src/google_update/using_google_update.scons

More SCons renaming:
* Rename two SConscript files that needed fixing in response to
  environment changes in the calling SConscript hierarchy:
  chrome\test\interactive_ui\SConscript => interactive_ui_tests.scons
  chrome\browser\debugger\SConscript => debugger.scons
* Add the google_update library to LIBS in the using_google_update.scons file.
Review URL: http://codereview.chromium.org/9309
------------------------------------------------------------------------
r4626 | finnur@google.com | 2008-11-04 20:30:42 +0100 (Tue, 04 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_data_remover.cc

Fix hang in clearing browsing data from incognito mode.

When deleting Keywords, the BrowsingDataRemover class may need to load the TemplateURLModel if it isn't loaded and delete keywords asynchronously from the Observe function. The check to see if we were getting the model with the right profile wasn't taking into account that we might be doing this while incognito, which led to us failing to set the waiting_for_keywords_ flag, resulting in a hang (issue 2145). This fixes that.

Review URL: http://codereview.chromium.org/9333
------------------------------------------------------------------------
r4625 | sky@google.com | 2008-11-04 20:29:08 +0100 (Tue, 04 Nov 2008) | 6 lines
Changed paths:
   A /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_drop_info.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_utils.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   M /trunk/src/chrome/browser/views/bookmark_folder_tree_view.h
   M /trunk/src/chrome/browser/views/bookmark_table_view.cc
   M /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   A /trunk/src/chrome/views/view_constants.cc
   A /trunk/src/chrome/views/view_constants.h
   M /trunk/src/chrome/views/views.vcproj

Adds support for autoscrolling on drag to bookmark tree/table.

BUG=674
TEST=none

Review URL: http://codereview.chromium.org/9042
------------------------------------------------------------------------
r4614 | brettw@google.com | 2008-11-04 19:34:29 +0100 (Tue, 04 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Roll back my last change, it broke a unit test.
Review URL: http://codereview.chromium.org/9119
------------------------------------------------------------------------
r4608 | brettw@google.com | 2008-11-04 19:13:51 +0100 (Tue, 04 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Evil wallpaper hack to hide a crash when going back from an interstitial and then renavigating very quickly.
BUG=2855
Review URL: http://codereview.chromium.org/9330
------------------------------------------------------------------------
r4604 | abarth@chromium.org | 2008-11-04 18:18:54 +0100 (Tue, 04 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

Rolling back
------------------------------------------------------------------------
r4603 | abarth@chromium.org | 2008-11-04 18:00:53 +0100 (Tue, 04 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_exe.cc

Tell the user that HTML documents can harm their computer because they can. 
This patch blocks all the extensions that we register.

R=nsylvain
BUG=1463961


------------------------------------------------------------------------
r4600 | maruel@chromium.org | 2008-11-04 17:09:52 +0100 (Tue, 04 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printed_document.cc

Use ElideUrl for urls. It is much nicer.
Review URL: http://codereview.chromium.org/9265
------------------------------------------------------------------------
r4569 | hbono@chromium.org | 2008-11-04 07:35:01 +0100 (Tue, 04 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ime_input.cc
   M /trunk/src/chrome/browser/ime_input.h

A fix for Issue 2768 "IME: Current clause of Japanese IME doesn't appear to reflect its rage change."
This issue is caused by my code that cannot extract a target clause from a composition string when there is an input clause after a target clause.
when a user changes the range of a target clause, Japanese IMEs creates a composite clause which consists of a new target clause and an input clause. My IME code treats such composite clause as a target clause and cannot reflect the change.
To fix this problem, this code changes the algorithm which extracts a target clause.
Review URL: http://codereview.chromium.org/8970
------------------------------------------------------------------------
r4557 | sky@google.com | 2008-11-04 05:44:43 +0100 (Tue, 04 Nov 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc

Fixes two bookmark manager bugs. Use Activate instead of MoveToFront
so that we restore the window if minimized/iconified and give focus to
the search field.

BUG=4038 4044
TEST=see bugs

Review URL: http://codereview.chromium.org/9069
------------------------------------------------------------------------
r4556 | sky@google.com | 2008-11-04 05:44:35 +0100 (Tue, 04 Nov 2008) | 8 lines
Changed paths:
   A /trunk/src/chrome/app/theme/bookmark_manager_recent.png
   A /trunk/src/chrome/app/theme/bookmark_manager_search.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/tree_view.h

Adds support for models to provide addition icons to the tree. Updates
the bookmarks folder tree model to return custom icons for search and
recently bookmarked.

BUG=674
TEST=none

Review URL: http://codereview.chromium.org/9047
------------------------------------------------------------------------
r4539 | erg@google.com | 2008-11-04 02:29:24 +0100 (Tue, 04 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   D /trunk/src/chrome/app/theme/menu_droparrow.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   D /trunk/src/chrome/browser/views/blocked_popup_container.cc
   D /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_animation.cc
   M /trunk/src/chrome/browser/views/constrained_window_animation.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/views/menu_button.cc

Revert change r4523 because Vista doesn't like it.

TBR=nsylvain

------------------------------------------------------------------------
r4532 | sgk@google.com | 2008-11-04 01:54:28 +0100 (Tue, 04 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.scons

Remove old bookmarks/bookmark_drag_utils.cc entry.
Review URL: http://codereview.chromium.org/9292
------------------------------------------------------------------------
r4523 | erg@google.com | 2008-11-04 01:19:59 +0100 (Tue, 04 Nov 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/menu_droparrow.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   A /trunk/src/chrome/browser/views/blocked_popup_container.cc
   A /trunk/src/chrome/browser/views/blocked_popup_container.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_animation.cc
   M /trunk/src/chrome/browser/views/constrained_window_animation.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/views/menu_button.cc

Redo how we block popups. Rip out the old constrained popup window cruft (while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests.

Review URL: http://codereview.chromium.org/8782
------------------------------------------------------------------------
r4517 | ananta@chromium.org | 2008-11-04 00:21:38 +0100 (Tue, 04 Nov 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc

This fixes bug http://code.google.com/p/chromium/issues/detail?id=3907, which
was a crash in the browser in the IPC handler codepath which handles scrolling.

The crash occured because of a failure to find the backing store for the RenderWidgetHost instance. We would end up dereferencing a NULL backing store pointer and crash.

The fix for this is to check for a NULL backing store and return. 

R=darin
Bug=3907


Review URL: http://codereview.chromium.org/9056
------------------------------------------------------------------------
r4512 | sky@google.com | 2008-11-04 00:14:01 +0100 (Tue, 04 Nov 2008) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   M /trunk/src/chrome/browser/views/bookmark_manager_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Miscellaneous bookmark manager polish:

. Adds a menu button on the bookmark manager. If I finish up import
  I'll add a second one for importing.
. Creating new page/folder from menu items selects new item in table.
. I changed around the FolderBookmarkTableModel to copy the contents
  into a vector (now extends VectorBackedTabledModel). This is
  necessitated by TableView not providing a moved notification. The
  problem with previous approach is that I sent out ModelChanged on
  any change, which loses selection and causes things to snap around.
  I considered adding a moved method to TableView, but it's too much
  work at this time.
. Added persisting of divider location in bookmark manager.
. When focus is on table pressing enter on a folder descends into the
  folder, and pressing backspace goes back up a folder.

BUG=674
TEST=none

Review URL: http://codereview.chromium.org/8967
------------------------------------------------------------------------
r4509 | ben@chromium.org | 2008-11-04 00:12:23 +0100 (Tue, 04 Nov 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Revert some of my earlier change to see if this fixes dist tests, and revert my earlier experiment.

------------------------------------------------------------------------
r4487 | cpu@google.com | 2008-11-03 21:53:54 +0100 (Mon, 03 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc

More distro installer params work
- Move params to "distribution" group
- Add "import_search_engine", "show_welcome_page" params
- Now the welcome page and the bubble actually work
- Some cleanup

BUG=1394863

Review URL: http://codereview.chromium.org/9207
------------------------------------------------------------------------
r4484 | glen@chromium.org | 2008-11-03 21:47:23 +0100 (Mon, 03 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Make the right side of the bookmarks bar lay out correctly.

BUG=3961

Review URL: http://codereview.chromium.org/8983
------------------------------------------------------------------------
r4480 | aa@google.com | 2008-11-03 21:08:33 +0100 (Mon, 03 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/renderer/debug_message_handler.cc
   M /trunk/src/chrome/renderer/debug_message_handler.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Change some places where we were using javascript: URLs to use
WebFrame::ExecuteJavaScript() instead.

Review URL: http://codereview.chromium.org/8826
------------------------------------------------------------------------
r4474 | ben@chromium.org | 2008-11-03 20:43:47 +0100 (Mon, 03 Nov 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

check in for one cycle to see if this fixes the dist tests.
------------------------------------------------------------------------
r4456 | sgk@google.com | 2008-11-03 18:51:23 +0100 (Mon, 03 Nov 2008) | 11 lines
Changed paths:
   A /trunk/src/breakpad/using_breakpad.scons
   M /trunk/src/chrome/SConscript
   D /trunk/src/chrome/browser/SConscript
   A /trunk/src/chrome/browser/browser.scons (from /trunk/src/chrome/browser/SConscript:4447)
   M /trunk/src/chrome/chrome.scons
   A /trunk/src/chrome/third_party/hunspell/using_hunspell.scons
   A /trunk/src/chrome/third_party/wtl/using_wtl.scons
   A /trunk/src/google_update/using_google_update.scons
   A /trunk/src/third_party/npapi/using_npapi.scons

Convert browser.lib to the new naming:
* Move chrome/browser/SConscript => chrome/browser/browser.scons.
* Use using_*.scons files instead of by-hand settings.
* Add new using_*.scons files:
    breakpad/using_breakpad.scons
    chrome/third_party/hunspell/using_hunspell.scons
    chrome/third_party/wtl/using_wtl.scons
    google_update/using_google_update.scons
    third_party/npapi/using_npapi.scons
* Delete some unused CPPPATH directories.
Review URL: http://codereview.chromium.org/9243
------------------------------------------------------------------------
r4450 | glen@chromium.org | 2008-11-03 17:14:46 +0100 (Mon, 03 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h

Always show file extensions in the shelf.

BUG=1208

Review URL: http://codereview.chromium.org/8991
------------------------------------------------------------------------
r4425 | jungshik@google.com | 2008-11-02 19:49:28 +0100 (Sun, 02 Nov 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Add widely-used variants of en, fr, de and it.
More comprehensive changes will be made for post 1.0. 
This is good enough for 1.0.

TBR=sidchat
BUG=1723
TEST=In Accept-Language menu,  Germain (Switzerland), French(Canada), etc are listed.


Review URL: http://codereview.chromium.org/9027
------------------------------------------------------------------------
r4386 | glen@chromium.org | 2008-11-02 00:36:17 +0100 (Sun, 02 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h

Rollback r4382 because I'm daft (submitted the wrong thing)

TBR=ben

------------------------------------------------------------------------
r4382 | glen@chromium.org | 2008-11-01 23:57:52 +0100 (Sat, 01 Nov 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h

Unescape and use the filename when we have no title to display for a given entry (instead of displaying the whole path). This unifies the display of titles for local and remote files.

For anyone watching, this is how tab titles will change:
'http://blah.com/index.html' will be 'index.html'
'http://blah.com/meat%20pie.pdf' will be 'meat pie.pdf'
'file://C:/blah/blue%20cheese.txt' will be 'blue cheese.txt' (previously this sometimes changed between the URL and blue%20cheese.txt depending on how the file was opened).

BUG=2529,2375


Review URL: http://codereview.chromium.org/8973
------------------------------------------------------------------------
r4373 | cpu@google.com | 2008-11-01 19:39:37 +0100 (Sat, 01 Nov 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Changed the notification for the rlz
 - this one is back mergeable, I hope.

Review URL: http://codereview.chromium.org/9000
------------------------------------------------------------------------
r4362 | beng@google.com | 2008-11-01 07:41:10 +0100 (Sat, 01 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc

Fix interactive test crashes.

TBR=glen

Review URL: http://codereview.chromium.org/9002
------------------------------------------------------------------------
r4352 | ben@chromium.org | 2008-11-01 01:23:44 +0100 (Sat, 01 Nov 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h

Second attempt at fixing dist crash... more accurately control the lifetime of the dragged tab container.

http://crbug.com/3939

Review URL: http://codereview.chromium.org/8800
------------------------------------------------------------------------
r4346 | cpu@google.com | 2008-11-01 00:44:54 +0100 (Sat, 01 Nov 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

On first run process the master prefs json, only one entry matters to us.
- skip or not first run dialgos
- on skip import silently search provider only

BUG=1394863

Review URL: http://codereview.chromium.org/8758
------------------------------------------------------------------------
r4344 | ananta@chromium.org | 2008-11-01 00:34:03 +0100 (Sat, 01 Nov 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/data/History/history_length_test1.html
   M /trunk/src/chrome/test/data/History/history_length_test2.html

This fixes the VerifyHistoryLength ui test flakiness. The test initiates page navigations in timers and reads the history length to validate it.

When we receive a request to initiate a navigation in the browser, we send out the request to the renderer and then immediately read the history length and send it out in an update history length request. This causes the test to fail at times as it reads a stale history length. 

When we receive the DidAddHistoryItem notification in the renderer, we should not update the history length for the start page navigation. This results in the test failure at times as it reads an incorrect history length.

R=jam

Review URL: http://codereview.chromium.org/8898
------------------------------------------------------------------------
r4335 | darin@chromium.org | 2008-10-31 23:28:40 +0100 (Fri, 31 Oct 2008) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/build/glue/glue.vcproj
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   A /trunk/src/webkit/glue/chromium_bridge_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   A /trunk/src/webkit/glue/webkit_glue_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h
   D /trunk/src/webkit/port/platform/Language.cpp
   A /trunk/src/webkit/port/platform/chromium/ChromiumBridge.h
   A /trunk/src/webkit/port/platform/chromium/PlatformScreenChromium.cpp (from /trunk/src/webkit/port/platform/win/PlatformScreenWin.cpp:4274)
   D /trunk/src/webkit/port/platform/win/PlatformScreenWin.cpp

Takes steps to make our PlatformScreen implementation more portable.

Introduces ChromiumBridge as a means for our WebCore port to depend on the embedder indirectly.  This will be extended to support the rest of our port.

WebWidgetImpl and ChromeClientImpl both needed to have their platformWindow getter implemented.  This fixes a regression related to the most recent merge.

Removes the orphaned Language.cpp (see the real one in the platform/chromium directory.

Changed webkit_glue::GetMonitorInfoForWindow to webkit_glue::GetScreenInfo.  This resulted in a varied amount of plumbing changes.  It also pushes the platform specific bits up into the browser where they belong.

ScreenInfo is a struct that is part of the webkit/glue API.

R=dglazkov,eseidel

Review URL: http://codereview.chromium.org/8761
------------------------------------------------------------------------
r4334 | jcampan@chromium.org | 2008-10-31 23:19:43 +0100 (Fri, 31 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/dialog_delegate.h
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/message_box_view.h

Some code in MessageBoxView was focusing the first focusable element in the view, overidding the focus set from the DialogDelegate.
We now only rely on the dialog delegate.
Also changed dialog delegate so the default button is also the focused button.

BUG=98
TEST=Open a javascript alert then confirm dialog. A button should be focused. Open all dialogs in Chrome. A button should be focused by default.
Review URL: http://codereview.chromium.org/8786
------------------------------------------------------------------------
r4326 | klink@chromium.org | 2008-10-31 22:31:34 +0100 (Fri, 31 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/button_dropdown.h
   M /trunk/src/chrome/views/container_win.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h

Adds support for keyboard-triggered (through VK_APPS and SHIFT+VK_F10) right-click menu, specifically on the toolbar's back/forward buttons.

Review URL: http://codereview.chromium.org/8942
------------------------------------------------------------------------
r4323 | paulg@google.com | 2008-10-31 22:11:41 +0100 (Fri, 31 Oct 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.h

Fix a bug where languages that have a long string for the
dangerous download warning cause an overlap with the label
for that download's URL.

We now use a locale-specific pixel value which changes the
height of each download's view on the download page so that
this overlap no longer happens.

BUG=3824 (http://code.google.com/p/chromium/issues/detail?id=3824)


Review URL: http://codereview.chromium.org/8933
------------------------------------------------------------------------
r4322 | mpcomplete@google.com | 2008-10-31 22:10:11 +0100 (Fri, 31 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc

Fix regression of b/issue?id=1280317.  We need to do a case-insensitive
compare of filenames to test if a plugin is Gears.

BUG=1280317
Review URL: http://codereview.chromium.org/8784
------------------------------------------------------------------------
r4317 | finnur@google.com | 2008-10-31 21:31:23 +0100 (Fri, 31 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

2nd part of the reorganize options under 'UnderTheHood' (bug  3655):

The link 'learn more' now points to a yet-to-be-created article in the help center. I moved it also, so that it appears to the right of the label (instead of below the label).

And finally, I added missing definitions for the Bookmark Manager, which I noticed while I was changing this.

Review URL: http://codereview.chromium.org/8777
------------------------------------------------------------------------
r4314 | brettw@google.com | 2008-10-31 21:08:55 +0100 (Fri, 31 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_view_win.cc

Add the comment for why we detach plugin windows when the WebContents is
destroyed. This is from the commit log of the patch checking this code in in
the old repo.
------------------------------------------------------------------------
r4306 | nsylvain@chromium.org | 2008-10-31 19:38:43 +0100 (Fri, 31 Oct 2008) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_util.cc

Background:
1. We can tell chrome to "always open this type of file" when
downloading. This is disabled for executable for security
reasons. 

2. When downloading an executable files we download
a .download instead. 

-=-=

The problem is that the "always open this type of file" is enabled
for executables during the download because we check the extension
of the file to know if it's an executable or not, and during download
we see .download, and we don't consider it an executable.

The fix is to look at the "original_name" when it's present to get
the extension of the real file, not the .download.

BUG:3814


Review URL: http://codereview.chromium.org/8918
------------------------------------------------------------------------
r4300 | hbono@chromium.org | 2008-10-31 18:53:48 +0100 (Fri, 31 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

A fix for Issue 3156 in chromium: "OmniBox: NavSuggest doesn't work fine when you select NavSuggest suggested item before finalizing IME."To investigate this issue today, a rich-edit control of Windows XP does not finish an ongoing composition before changing its text with a SetWindowText() call. (Thanks pkasting for colleting my corrupted comments.)To solve this issue, this change manually finishes an ongoing composition before calling the function.
Review URL: http://codereview.chromium.org/8669
------------------------------------------------------------------------
r4295 | ben@chromium.org | 2008-10-31 18:22:08 +0100 (Fri, 31 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Attempt to fix dist crashes or at least make them crash with more understandable stack traces. Destroy the dragged representation immediately, not after returning to the message loop.

Review URL: http://codereview.chromium.org/8926
------------------------------------------------------------------------
r4294 | finnur@google.com | 2008-10-31 18:16:26 +0100 (Fri, 31 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h

Fix RTL issues in the About box (bug 3756).

I used the BiDiLineIterator, which I moved out of the AutocompletePopup and into the l10n_util file. I also added a wrapper function around ubidi_getLogicalRun.

Review URL: http://codereview.chromium.org/8727
------------------------------------------------------------------------
r4292 | jcampan@chromium.org | 2008-10-31 18:14:02 +0100 (Fri, 31 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Adding preferences and clear browsing data for form autofill.

BUG=None
TEST=Open the 'Clear browsing data' dialog, there should be a check box for from data. Open the options dialogue, 2nd tab, there should be an option for autofill.
Review URL: http://codereview.chromium.org/8740
------------------------------------------------------------------------
r4289 | sidchat@google.com | 2008-10-31 18:10:01 +0100 (Fri, 31 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_context_menu.cc

Display "No suggestions found" for misspelled words with no suggestions.

Issue=1677
Review URL: http://codereview.chromium.org/8408
------------------------------------------------------------------------
r4285 | maruel@chromium.org | 2008-10-31 17:18:52 +0100 (Fri, 31 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/win_printing_context.cc

Remove an hack to enable the parent window. It seems to cause crashes in the field. I wonder why I had kept it active.
Review URL: http://codereview.chromium.org/8963
------------------------------------------------------------------------
r4267 | sky@google.com | 2008-10-31 04:32:06 +0100 (Fri, 31 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/base/observer_list.h
   M /trunk/src/base/observer_list_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc

Adds the ability for ObserverList to not notify observers added during
notification. I need this for bookmarks. If a new observer is added
while the bookmark model is in the process of sending out notification
the newly added observer gets confused.

BUG=674
TEST=none

Review URL: http://codereview.chromium.org/8919
------------------------------------------------------------------------
r4260 | ananta@chromium.org | 2008-10-31 01:09:55 +0100 (Fri, 31 Oct 2008) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/webkit/default_plugin/chrome_plugins_file.xml
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.h
   M /trunk/src/webkit/default_plugin/plugin_impl.cc
   M /trunk/src/webkit/default_plugin/plugin_impl.h

This fixes http://code.google.com/p/chromium/issues/detail?id=3769, which
is to allow users to download the java plugin via our plugin installer.

The plugin installer currently supports URLs which point to executable files.
However the java runtime path is timed and changes frequently. As a stop gap
fix for this, I added a facility in the plugin installer which indicates if
a URL is a display URL. If yes then we navigate to this URL in a new tab,
and allow the user to download the plugin from there.

The format of the chrome_plugins_file.xml has been changed to have each plugin
node specify a list of mime types. This reduces a great deal of duplicated 
information in the plugins file.

Changed the plugin finder URL to http://dl.google.com/chrome/plugins/plugins2.xml
to ensure that older clients continue to work.

Bug=3769
R=jam

Review URL: http://codereview.chromium.org/8729
------------------------------------------------------------------------
r4256 | aa@chromium.org | 2008-10-31 00:57:59 +0100 (Fri, 31 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/greasemonkey_master.cc
   M /trunk/src/chrome/browser/greasemonkey_master.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h

Make it so that you can refresh and see changes in Greasemonkey
scripts immediately, without having to restart the renderer.

Review URL: http://codereview.chromium.org/8908
------------------------------------------------------------------------
r4254 | evanm@google.com | 2008-10-31 00:54:04 +0100 (Fri, 31 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/base/base_paths.cc
   M /trunk/src/base/base_paths_linux.cc
   M /trunk/src/base/file_path.cc
   M /trunk/src/base/file_path.h
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_linux.cc
   M /trunk/src/base/file_util_mac.mm
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/icu_util.cc
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/base/path_service_unittest.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/save_page_uitest.cc

Begin the first small step towards using FilePath everywhere:
- Add some transition APIs.
- Start migrating some code to transition APIs.

Review URL: http://codereview.chromium.org/8825

------------------------------------------------------------------------
r4251 | glen@chromium.org | 2008-10-31 00:52:00 +0100 (Fri, 31 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/about_credits.html

Include webkit licence changes, make page prettier with expando licence sections and homepage links.

Review URL: http://codereview.chromium.org/8905
------------------------------------------------------------------------
r4250 | glen@chromium.org | 2008-10-31 00:51:39 +0100 (Fri, 31 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/web_contents.cc

Fix for HTTP AUTH prompts allowing save-password infobars to be shown after a transition away from the appropriate page while that page was loading. 

The issue was the LoginPrompt set up a provisional password save prior to the start of a page load, and DidNavigate is not called early enough when a user navigates, which they have an opportunity to do in the HTTP auth case (details in bug comments).

BUG=2792
Review URL: http://codereview.chromium.org/8647
------------------------------------------------------------------------
r4249 | tc@google.com | 2008-10-31 00:51:39 +0100 (Fri, 31 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/web_drop_target.cc
   M /trunk/src/chrome/browser/web_drop_target.h

When acting as a drop target, the webview keeps a cache of
the drop data so we don't have to send it over the IPC for
each drag move.  However, if a page load happens during
the drop, the webview changes and we lose the cached
data.

To handle this, we keep track of which RVH we're dragging
over and if it changes, we re-send the drop data.
Review URL: http://codereview.chromium.org/8744
------------------------------------------------------------------------
r4228 | sgk@google.com | 2008-10-30 21:31:37 +0100 (Thu, 30 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/views/SConscript

SCons config for recent bookmark changes.
Review URL: http://codereview.chromium.org/8921
------------------------------------------------------------------------
r4226 | ojan@google.com | 2008-10-30 20:42:54 +0100 (Thu, 30 Oct 2008) | 1 line
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/render_view_host.cc

Roll deps to pull in new third_party/WebKit
------------------------------------------------------------------------
r4215 | sgk@google.com | 2008-10-30 18:43:13 +0100 (Thu, 30 Oct 2008) | 31 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/automation/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/memory_test/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/views/SConscript

Accumulated SCons changes for Windows chrome build, round II:
Includes other recent additions, and doesn't fix everything,
but gets significant pieces back on track:
* New/additional library dependencies in various test executables
  (too many to be worth listing).
* Portability:  put library base names in $LIBS instead of explicitly
  listing .lib files.
* Have interactive_ui re-use various object files from test/ui
  instead of (re-)listing the .cc files.
* Add new files:
  chrome\browser\bookmarks\bookmark_drag_data.cc
  chrome\browser\bookmarks\bookmark_drag_utils.cc
  chrome\browser\bookmarks\bookmark_table_model.cc
  chrome\browser\browser_trial.cc
  chrome\browser\download\download_request_manager_unittest.cc
  chrome\browser\greasmonkey_master.cc
  chrome\browser\spellcheck_unittest.cc
  chrome\browser\views\find_bar_view.cc
  chrome\browser\views\find_bar_win.cc
  chrome\renderer\greasemonkey_slave.cc
* Remove old files:
  chrome\browser\find_in_page_controller.cc
  chrome\browser\find_in_page_view.cc
  chrome\renderer\spellcheck_unittest.cc
* Remove relative reference to ../../app/google_update_settings$OBJSUFFIX.
* Get rid of by-hand /IMPLIB and /MAP flags.
* Prefix / suffix portability in the jscre library.
* Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources.
* Add $CHROME_DIR/app/resources to CPPPATH.
* Add icu38 directories to CPPPATH for building chrome/views files.
Review URL: http://codereview.chromium.org/8742
------------------------------------------------------------------------
r4213 | hbono@chromium.org | 2008-10-30 17:22:56 +0100 (Thu, 30 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/common/gfx/chrome_font.h
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/window.cc

Fix Issue 2918 in chromium: Chrome dialog displayed in large size with Meiryo font.This issue is caused by a font whose text metric |tmAveCharWidth| is not precise as noted in Microsoft Knowledge Base 145994 (*1) To handle this case, this change uses the ChromeFont::horizontal_dlus_to_pixels() function instead of the ChromeFont::ave_char_width() function.(*1) http://support.microsoft.com/kb/145994BUG=2918
Review URL: http://codereview.chromium.org/8051
------------------------------------------------------------------------
r4212 | sky@google.com | 2008-10-30 17:17:04 +0100 (Thu, 30 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Makes form resubmission dialog work again. This was a regression
introduced during NavigationController refactoring.

BUG=2616
TEST=see bug

Review URL: http://codereview.chromium.org/8865
------------------------------------------------------------------------
r4206 | sgk@google.com | 2008-10-30 06:55:47 +0100 (Thu, 30 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/automation/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/memory_test/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/views/SConscript

Revert r4205 to track down buildbot unit_tests failure.
Review URL: http://codereview.chromium.org/8730
------------------------------------------------------------------------
r4205 | sgk@google.com | 2008-10-30 06:35:44 +0100 (Thu, 30 Oct 2008) | 31 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/automation/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/memory_test/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/views/SConscript

Accumulated SCons changes for Windows chrome build and other
recent additions (doesn't fix everything, but gets significant
pieces back on track).
* New/additional library dependencies in various test executables
  (too many to be worth listing).
* Portability:  put library base names in $LIBS instead of explicitly
  listing .lib files.
* Have interactive_ui re-use various object files from test/ui
  instead of (re-)listing the .cc files.
* Add new files:
  chrome\browser\bookmarks\bookmark_drag_data.cc
  chrome\browser\bookmarks\bookmark_drag_utils.cc
  chrome\browser\bookmarks\bookmark_table_model.cc
  chrome\browser\browser_trial.cc
  chrome\browser\download\download_request_manager_unittest.cc
  chrome\browser\greasmonkey_master.cc
  chrome\browser\spellcheck_unittest.cc
  chrome\browser\views\find_bar_view.cc
  chrome\browser\views\find_bar_win.cc
  chrome\renderer\greasemonkey_slave.cc
* Remove old files:
  chrome\browser\find_in_page_controller.cc
  chrome\browser\find_in_page_view.cc
  chrome\renderer\spellcheck_unittest.cc
* Remove relative reference to ../../app/google_update_settings$OBJSUFFIX.
* Get rid of by-hand /IMPLIB and /MAP flags.
* Prefix / suffix portability in the jscre library.
* Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources.
* Add $CHROME_DIR/app/resources to CPPPATH.
* Add icu38 directories to CPPPATH for building chrome/views files.
Review URL: http://codereview.chromium.org/8725
------------------------------------------------------------------------
r4202 | sky@google.com | 2008-10-30 03:58:36 +0100 (Thu, 30 Oct 2008) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/session_crashed_view.cc
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_restore.h
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h

Changes session restore to account for apps and popups. If you have
session restore enabled any time you transition from no tabbed
browsers to a tabbed browser (in the same profile) we restore your
last session, where the last session was any previously open tabbed
browsers. For example, if you start Chrome from an installed app
shortcut then create a new tabbed browser (by any means) we'll restore
your last session. This gives the illustion that apps are running in
their own process.

I would love to have test coverage of this, but I'm loathe to write
anymore flakey UI tests. Need to revisit post 1.0.

BUG=1883
TEST=thoroughly test session restore, especially with application
  shortcuts and popups.

Review URL: http://codereview.chromium.org/8856
------------------------------------------------------------------------
r4201 | brettw@google.com | 2008-10-30 03:36:20 +0100 (Thu, 30 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc

Make sure titles and bodies of web pages that come into the history system very
late are indexed. Very slow pages (>20 seconds) would previously not get indexed.

BUG=3835
Review URL: http://codereview.chromium.org/8899
------------------------------------------------------------------------
r4200 | paulg@google.com | 2008-10-30 01:58:58 +0100 (Thu, 30 Oct 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Remove downloads from the completed dangerous downloads list
when they are deleted via "Clear browsing data".

There was definite crash a shutdown, and sporadic crashes when
idling (but after a dangerous download was complete but not yet
confirmed) after a user cleared their browsing data, since the
dangerous list kept around a pointer to a download that had
been deleted elsewhere.

BUG=3498 (http://code.google.com/p/chromium/issues/detail?id=3498)

Review URL: http://codereview.chromium.org/8728
------------------------------------------------------------------------
r4195 | pkasting@chromium.org | 2008-10-30 01:14:44 +0100 (Thu, 30 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/chrome/browser/meta_table_helper.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.h

Add compatible version support since it was only halfway in place, and try and make our database versioning code and logging more similar across various consumers.

The compatible version support isn't really used yet.  It was going to be used for my cookie change until we decided that the old code was too busted to be forward-compatible.  It seems worthwhile to put this in but maybe I am wrong.

The logging similarity stuff is fairly useful.  In a couple consumers in the old code, we DLOGed instead of LOGing, which meant that most people would get nothing in the log at all.  I think it's a little weird that in a lot of these consumers, logging is all we do; for example, if you use a too-new cookie DB, you get output in the log, but no actual dialog box while the browser is running -- your cookies just silently don't get saved to disk.  Seems bad, but I'm not prepared to try and do major surgery to address that (and add translated strings, etc.).  At least now we'll actually get log messages in release builds instead of nothing at all.

Because my last-access change touches this code, I'm considering asking that this change be merged back to the branch.
Review URL: http://codereview.chromium.org/8712
------------------------------------------------------------------------
r4192 | glen@chromium.org | 2008-10-30 00:43:30 +0100 (Thu, 30 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/resources/new_tab.html

Add more UMA collection to the New Tab Page

BUG=1450986

Review URL: http://codereview.chromium.org/8686
------------------------------------------------------------------------
r4191 | sky@google.com | 2008-10-30 00:38:06 +0100 (Thu, 30 Oct 2008) | 21 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll_resource.h
   M /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   D /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   D /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h
   D /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.cc (from /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc:3822)
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu.h (from /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h:3822)
   A /trunk/src/chrome/browser/bookmarks/bookmark_context_menu_test.cc (from /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc:3822)
   D /trunk/src/chrome/browser/bookmarks/bookmark_drag_utils.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_drag_utils.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_utils.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_drag_utils.cc:3969)
   A /trunk/src/chrome/browser/bookmarks/bookmark_utils.h (from /trunk/src/chrome/browser/bookmarks/bookmark_drag_utils.h:3969)
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   A /trunk/src/chrome/browser/views/bookmark_folder_tree_view.cc
   A /trunk/src/chrome/browser/views/bookmark_folder_tree_view.h
   A /trunk/src/chrome/browser/views/bookmark_manager_view.cc
   A /trunk/src/chrome/browser/views/bookmark_manager_view.h
   A /trunk/src/chrome/browser/views/bookmark_table_view.cc
   A /trunk/src/chrome/browser/views/bookmark_table_view.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h

First cut at the bookmark manager. There are still a fair number of
rough edges, but I'm at a good point where I want to land what I
have. Here's what is left:

. Flicker on show, likely the result of restoring window placement.
. tree flickers when dragging splitter.
. table/tree need to autoscroll when drop cursor held at bottom of view.
. prompts for deleting.
. When you move an item the table snaps to the top, this is because
  I'm sending out model changed. need a better notification.
. Operations in menu to add need to change selection.
. Remember split location.

I would have preferred to split this up into a couple of reviews, but
everything is intertwined now. Sorry.

BUG=674
TEST=don't test the bookmark manager yet, but make sure bookmark bar
  still works.

Review URL: http://codereview.chromium.org/8197
------------------------------------------------------------------------
r4190 | pkasting@chromium.org | 2008-10-30 00:34:36 +0100 (Thu, 30 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

Fix more problems with search providers.

onet.pl apparently moved their search service out of beta, and changed the URLs accordingly, since the time I put the original list together.

In the other two cases, changing encodings to UTF-8 seemed to fix issues with words in the local languages, and who am I to argue with the results.

BUG=3804,3809,3816
Review URL: http://codereview.chromium.org/8719
------------------------------------------------------------------------
r4186 | bradnelson@chromium.org | 2008-10-30 00:16:17 +0100 (Thu, 30 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/views/SConscript

Fixing some windows scons build breaks.

Review URL: http://codereview.chromium.org/8723
------------------------------------------------------------------------
r4179 | glen@chromium.org | 2008-10-29 23:51:58 +0100 (Wed, 29 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h

Only show the language restart warning once, and only if needed.

BUG=2835

Review URL: http://codereview.chromium.org/8195
------------------------------------------------------------------------
r4177 | glen@chromium.org | 2008-10-29 23:20:40 +0100 (Wed, 29 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix for Save Page downloads not notifying their observers on completion.

BUG=3417

Review URL: http://codereview.chromium.org/8804
------------------------------------------------------------------------
r4172 | evanm@google.com | 2008-10-29 22:51:08 +0100 (Wed, 29 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/greasemonkey_master_unittest.cc

The SharedMemory is owned by the GreasemonkeyMaster, not the unit test.  My previous attempt at fixing the purify problem was overzealous; I just needed to fix the uninitialized boolean that my previous "fix" did.  This change halfway-reverts to before that state.

Review URL: http://codereview.chromium.org/8893

------------------------------------------------------------------------
r4163 | evanm@google.com | 2008-10-29 21:32:31 +0100 (Wed, 29 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/greasemonkey_master.cc
   M /trunk/src/chrome/browser/greasemonkey_master_unittest.cc

Free memory in unit test, so purify doesn't complain.

Review URL: http://codereview.chromium.org/8405

------------------------------------------------------------------------
r4155 | ben@chromium.org | 2008-10-29 20:32:00 +0100 (Wed, 29 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fix a couple of tab related bugs:

- moving the window while a tab is animating to its final resting position disembodies the tab
- it's possible to make a tab disappear while clicking on another tab while a tab is animating to its final resting position

http://crbug.com/2388
http://crbug.com/1142

Review URL: http://codereview.chromium.org/8689
------------------------------------------------------------------------
r4145 | pkasting@chromium.org | 2008-10-29 19:24:01 +0100 (Wed, 29 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc

Trivial patch: add whitespace to some SQL statements to turn "INSERT INTO foo(bar,baz)VALUES(?,?)" into "INSERT INTO foo (bar, baz) VALUES (?,?)" (which is the way we have it in most of our code).

This was annoying me while I tried to track down cases where we omitted the appropriate fieldnames from our SQL statements.
Review URL: http://codereview.chromium.org/8855
------------------------------------------------------------------------
r4140 | sidchat@google.com | 2008-10-29 19:13:26 +0100 (Wed, 29 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/test/testing_profile.h

Add option to disable/enable Spell Check. In addition, remove additional code in resource message filter, which was initilaizing spellchecker in the filter if it was NULL. This part of the code is not required since the resource message filter should not initialize spellchecker; it is up to the profile to give the spellchecker to the resource message filter.

Issue = 120

Review URL: http://codereview.chromium.org/7935
------------------------------------------------------------------------
r4117 | paulg@google.com | 2008-10-29 01:54:35 +0100 (Wed, 29 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h

Fix a minor memory leak.

BUG=1340229


Review URL: http://codereview.chromium.org/8690
------------------------------------------------------------------------
r4103 | tim@chromium.org | 2008-10-28 23:52:59 +0100 (Tue, 28 Oct 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h

Fix crbug.com/3684.

Change 6053 involved making the PasswordManagerView's table model contain a vector
of stack-allocated PasswordRow that owned a heap allocated PasswordForm, but 
std::vector creates temp PasswordRow's internally (on the stack) that were deleting the 
PasswordForm in their dtor. This accidental vector-internal delete caused subsequent
operations on saved_signons_ to blow up.

My fix is to make PasswordRows a vector of heap allocated PasswordRow instead, and
have a STLElementDeleter member handle cleanup.


Review URL: http://codereview.chromium.org/8651
------------------------------------------------------------------------
r4098 | wtc@google.com | 2008-10-28 23:20:13 +0100 (Tue, 28 Oct 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl_policy.h

Don't automatically deny subresource requests that have minor
certificate errors (ERR_CERT_NO_REVOCATION_MECHANISM and
ERR_CERT_UNABLE_TO_CHECK_REVOCATION).

This requires moving the code that automatically denies
subresource requests into only the SSLPolicy subclasses
that need it.  To avoid duplicating that code in five classes,
I added convenience methods for handling overridable certificate
errors and fatal errors.

R=jcampan,abarth
Review URL: http://codereview.chromium.org/8085
------------------------------------------------------------------------
r4093 | finnur@google.com | 2008-10-28 22:49:11 +0100 (Tue, 28 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Fix browser crash when closing popups (issue 3631).

The Google Bookmarks bookmarklet opens a popup window that allows you to bookmark a page. When the window closes we crash because we dereference a NULL TabContents pointer the we get from GetSelectedTabContents(). This fixes that.

Review URL: http://codereview.chromium.org/8185
------------------------------------------------------------------------
r4087 | paulg@google.com | 2008-10-28 21:30:28 +0100 (Tue, 28 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc

Give the new implementation a unique name for the database
and filter storage so that it can run side by side with the
old implementation without data loss.
Review URL: http://codereview.chromium.org/8844
------------------------------------------------------------------------
r4086 | ericroman@google.com | 2008-10-28 21:26:15 +0100 (Tue, 28 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/navigation_entry.h
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/session_service_test_helper.cc
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/renderer/render_view.cc

Add referrer to session restore.

http://code.google.com/p/chromium/issues/detail?id=3774

Review URL: http://codereview.chromium.org/8649
------------------------------------------------------------------------
r4069 | evanm@google.com | 2008-10-28 18:25:25 +0100 (Tue, 28 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/greasemonkey_master.cc
   M /trunk/src/chrome/browser/greasemonkey_master.h
   A /trunk/src/chrome/browser/greasemonkey_master_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

- Make user script loading asynchronous on the file thread.
- Automatically reload scripts when the directory changes.
- Add a unit test for the GreasemonkeyMaster.
Review URL: http://codereview.chromium.org/7472
------------------------------------------------------------------------
r4055 | sky@google.com | 2008-10-28 04:04:20 +0100 (Tue, 28 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Makes sure TaskManager doesn't return an empty icon. If we return an
empty icon we get an ugly black square in the table.

BUG=3784
TEST=Follow steps in bug, also make sure you don't see any problems
  with icons in task manager.

Review URL: http://codereview.chromium.org/8208
------------------------------------------------------------------------
r4050 | tc@google.com | 2008-10-28 01:53:22 +0100 (Tue, 28 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc

Make it so the user can't drag javascript: links to the
desktop from web content or the bookmarks bar.  Maintain
the ability to drag javascript: links from web content
to the bookmarks bar or to drag the javascript: link as
plain text.

BUG=3431
Review URL: http://codereview.chromium.org/8638
------------------------------------------------------------------------
r4049 | jungshik@google.com | 2008-10-28 01:44:12 +0100 (Tue, 28 Oct 2008) | 15 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h

Do not localize the name of 'download' directory. Chrome's UI languages can be
changed and a user will be confused as to where her download goes. 

Add DIR_DEFAULT_DOWNLOADS to chrome_paths (which is set to 'Downloads' under DIR_USER_DOCUMENTS) 
and use that in both save_package and download_manager.

This patch does not offer a migration path.

BUG=3097
TEST=Switch Chrome's UI to non-English and download a file. The file should be downloaded to '..\My Documents\Downloads'
rather than '..\My Documents\<'Downloads' in that language>. 



Review URL: http://codereview.chromium.org/7945
------------------------------------------------------------------------
r4036 | ericroman@google.com | 2008-10-28 00:01:50 +0100 (Tue, 28 Oct 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h
   M /trunk/src/chrome/browser/page_navigator.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/browser/web_drop_target.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Plumb the referrer throughout the OpenURL APIs.

http://code.google.com/p/chromium/issues/detail?id=3224

Caveats:
* Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer.
* Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.)
* Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version.

Review URL: http://codereview.chromium.org/8186
------------------------------------------------------------------------
r4032 | paulg@google.com | 2008-10-27 23:49:22 +0100 (Mon, 27 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h

Clean up the chunk processing pipeline. We are no longer
asynchronous, so we can greatly simplify the code.

Refactor BuildBloomFilter() to smaller worker functions.
Review URL: http://codereview.chromium.org/8605
------------------------------------------------------------------------
r4022 | dsh@google.com | 2008-10-27 21:43:33 +0100 (Mon, 27 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/base/condition_variable.h
   M /trunk/src/base/condition_variable_posix.cc
   M /trunk/src/base/condition_variable_unittest.cc
   M /trunk/src/base/condition_variable_win.cc
   M /trunk/src/base/field_trial.cc
   M /trunk/src/base/field_trial.h
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/histogram_unittest.cc
   M /trunk/src/base/idletimer_unittest.cc
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump.h
   M /trunk/src/base/message_pump_default.cc
   M /trunk/src/base/message_pump_default.h
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/message_pump_libevent.h
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/message_pump_win.h
   M /trunk/src/base/observer_list_unittest.cc
   M /trunk/src/base/perftimer.h
   M /trunk/src/base/pr_time_unittest.cc
   M /trunk/src/base/spin_wait.h
   M /trunk/src/base/stats_counters.h
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/base/time.cc
   M /trunk/src/base/time.h
   M /trunk/src/base/time_format.cc
   M /trunk/src/base/time_format.h
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/time_unittest.cc
   M /trunk/src/base/time_unittest_win.cc
   M /trunk/src/base/time_win.cc
   M /trunk/src/base/timer_unittest.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/base/tracked.cc
   M /trunk/src/base/tracked.h
   M /trunk/src/base/tracked_objects.cc
   M /trunk/src/base/tracked_objects.h
   M /trunk/src/base/waitable_event.h
   M /trunk/src/base/waitable_event_generic.cc
   M /trunk/src/base/waitable_event_unittest.cc
   M /trunk/src/base/waitable_event_win.cc
   M /trunk/src/base/watchdog.cc
   M /trunk/src/base/watchdog.h
   M /trunk/src/base/watchdog_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/base_history_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_types_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.h
   M /trunk/src/chrome/browser/history_model.cc
   M /trunk/src/chrome/browser/history_model.h
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/ie7_password.h
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/ipc_status_view.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/load_notification_details.h
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_log.h
   M /trunk/src/chrome/browser/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/password_form_manager.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/session_backend.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service_test_helper.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/browser/tab_restore_service.h
   M /trunk/src/chrome/browser/template_url.h
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model.h
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/url_fetcher_protect.cc
   M /trunk/src/chrome/browser/url_fetcher_protect.h
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/common/animation.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_sync_channel.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/thumbnail_score.cc
   M /trunk/src/chrome/common/thumbnail_score.h
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/common/time_format.h
   M /trunk/src/chrome/common/time_format_unittest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/menu_button.h
   M /trunk/src/chrome/views/repeat_controller.cc
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/net/base/client_socket_pool.cc
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_unittest.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/base/x509_certificate_mac.cc
   M /trunk/src/net/base/x509_certificate_unittest.cc
   M /trunk/src/net/base/x509_certificate_win.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/backend_impl.h
   M /trunk/src/net/disk_cache/backend_unittest.cc
   M /trunk/src/net/disk_cache/block_files.cc
   M /trunk/src/net/disk_cache/block_files_unittest.cc
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc
   M /trunk/src/net/disk_cache/disk_cache_test_util.cc
   M /trunk/src/net/disk_cache/entry_impl.cc
   M /trunk/src/net/disk_cache/entry_impl.h
   M /trunk/src/net/disk_cache/entry_unittest.cc
   M /trunk/src/net/disk_cache/mem_backend_impl.cc
   M /trunk/src/net/disk_cache/mem_backend_impl.h
   M /trunk/src/net/disk_cache/mem_entry_impl.cc
   M /trunk/src/net/disk_cache/mem_entry_impl.h
   M /trunk/src/net/disk_cache/rankings.cc
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_response_headers.cc
   M /trunk/src/net/http/http_response_headers.h
   M /trunk/src/net/http/http_response_headers_unittest.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job_metrics.cc
   M /trunk/src/net/url_request/url_request_job_metrics.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   M /trunk/src/webkit/glue/password_form.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/resource_handle_impl.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/port/platform/chromium/SystemTimeChromium.cpp
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc

Move Time, TimeDelta and TimeTicks into namespace base.

Review URL: http://codereview.chromium.org/7995
------------------------------------------------------------------------
r4021 | pkasting@chromium.org | 2008-10-27 21:39:46 +0100 (Mon, 27 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc

Update prepopulate data by request for a couple different issues.

Revert keyword dialog to being unsorted by default, which is appropriate for users looking at search engines -- users looking for keywords can always click the column header to sort things.

BUG=3219,1358883
Review URL: http://codereview.chromium.org/8802
------------------------------------------------------------------------
r4017 | cpu@google.com | 2008-10-27 20:34:44 +0100 (Mon, 27 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/rlz/rlz.h

Update RLZ according to the bugs:
BUG = 1447656
BUG = 1391110

Review URL: http://codereview.chromium.org/8171
------------------------------------------------------------------------
r4015 | jar@google.com | 2008-10-27 19:55:52 +0100 (Mon, 27 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_slave.cc
   M /trunk/src/chrome/browser/net/dns_slave.h
   M /trunk/src/chrome/common/net/dns.h
   M /trunk/src/net/base/dns_resolution_observer.h

Cleanup of DNS prefetch related files

I have a separate change list coming to support predictive DNS resolutions,
so I pulled out a pile of mechanical changes (with no semantic changes
intendend).

r=mbelshe
Review URL: http://codereview.chromium.org/8624
------------------------------------------------------------------------
r4006 | kuchhal@chromium.org | 2008-10-27 19:00:10 +0100 (Mon, 27 Oct 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/installer/util/shell_util.h

* Update comments from code review feedback.
------------------------------------------------------------------------
r4005 | finnur@google.com | 2008-10-27 18:56:55 +0100 (Mon, 27 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc

Reshuffling the options in the UnderTheHood section. A summary of my changes:Renamed ContentSection to WebContentSection to reflect changes that have already been made to the UI (prior to this change list).Renamed GeneralSection to PrivacySectionMoved various checkboxes that appear in other categories in the "Under the hood"-tab to appear under the new PrivacySection.Moved the checkbox "Use a suggestion service" from Edit Search Engines to the PrivacySection, since we don't want it in two different places. - If you check the "Use Suggest" but have a provider that doesn't support it, it will just not perform Suggest queries.The mock I was following has the Learn More link right after the text blurb, but this version has the link below the text. We need to figure out what we want to do here.
Review URL: http://codereview.chromium.org/7985
------------------------------------------------------------------------
r4001 | jungshik@google.com | 2008-10-27 17:52:47 +0100 (Mon, 27 Oct 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Update contents_mime_type_ of WebContents only for the main frame. RenderView does not set the value for sub frames.
As a result,  we ended up resetting to NULL by updating it for any frame.  
This CL should go in for both trunk and 0.3.154.x branch.

BUG=2929
TEST=Open http://fund.eastmoney.com in a tab, switch to another tab and then switch back. Encoding menu should be enabled 
which tab you're in. 


Review URL: http://codereview.chromium.org/8206
------------------------------------------------------------------------
r3999 | glen@chromium.org | 2008-10-27 17:10:10 +0100 (Mon, 27 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Window controls were aligned to the top of the window, so their rollover states caused the window border not to be shown.

Review URL: http://codereview.chromium.org/4044
------------------------------------------------------------------------
r3998 | glen@chromium.org | 2008-10-27 17:09:50 +0100 (Mon, 27 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Declare encoding on the New Tab.

BUG=998

Review URL: http://codereview.chromium.org/8080
------------------------------------------------------------------------
r3989 | tc@google.com | 2008-10-26 04:05:11 +0100 (Sun, 26 Oct 2008) | 3 lines
Changed paths:
   A /trunk/src/chrome/browser/spellcheck_unittest.cc (from /trunk/src/chrome/renderer/spellcheck_unittest.cc:3969)
   D /trunk/src/chrome/renderer/spellcheck_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move the spellcheck unittest into browser next to the file
it tests.
Review URL: http://codereview.chromium.org/8176
------------------------------------------------------------------------
r3978 | finnur@google.com | 2008-10-25 17:48:28 +0200 (Sat, 25 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Remember the clear browsing data combo box selection.

(Checking in for external contributer Arthur Lussos <developer0420@gmail.com>, who is already listed in AUTHORS)
Reviewed at http://codereview.chromium.org/7946

Review URL: http://codereview.chromium.org/7993
------------------------------------------------------------------------
r3972 | paulg@google.com | 2008-10-25 02:54:37 +0200 (Sat, 25 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Disable a long running test.
Review URL: http://codereview.chromium.org/8177
------------------------------------------------------------------------
r3961 | kuchhal@chromium.org | 2008-10-25 01:08:05 +0200 (Sat, 25 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h

Add a command line option to installer that will let user set Chrome as
default browser.
------------------------------------------------------------------------
r3959 | paulg@google.com | 2008-10-25 01:02:00 +0200 (Sat, 25 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Changes to allow running the new SafeBrowsing storage system,contained in SafeBrowsingDatabaseBloom, via a command line flag(--new-safe-browsing).
Review URL: http://codereview.chromium.org/6807
------------------------------------------------------------------------
r3940 | jar@google.com | 2008-10-24 23:47:40 +0200 (Fri, 24 Oct 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Turn on SDCH support for google.com by default.

I'll just turn it on for google.com to start with, since I think google
is the only server supporting this experimental protocol.  This doesn't 
catch all the google usages, as search in Europe/Asia etc. may use a
different server, but this should get some baseline tip-o-tree usage.

After a week or two (without problems), I'll open it up by default for
all sites on the net.

r=openvcdiff
Review URL: http://codereview.chromium.org/8154
------------------------------------------------------------------------
r3923 | glen@chromium.org | 2008-10-24 19:41:11 +0200 (Fri, 24 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Remove the status bubble 1px overhang.

BUG=1015,1156722

Review URL: http://codereview.chromium.org/7907
------------------------------------------------------------------------
r3922 | kuchhal@chromium.org | 2008-10-24 19:37:06 +0200 (Fri, 24 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/common/resource_bundle.cc

Make resource bundle return red square box again instead of empty bitmap
as it looks like some users get NULL when they ask for bitmap resource.

BUG=1432071
------------------------------------------------------------------------
r3913 | kuchhal@chromium.org | 2008-10-24 18:18:27 +0200 (Fri, 24 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h

    Add installer command line option to create shortcuts (desktop and quick
    launch).
------------------------------------------------------------------------
r3904 | cpu@google.com | 2008-10-24 05:14:57 +0200 (Fri, 24 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Slight signature changes for rlz lib
- to match new version

Review URL: http://codereview.chromium.org/8141
------------------------------------------------------------------------
r3898 | sky@google.com | 2008-10-24 04:04:37 +0200 (Fri, 24 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj

Forgot to include this in changed files.

I'm TBRing this one.

BUG=674
TEST=none
Review URL: http://codereview.chromium.org/7965
------------------------------------------------------------------------
r3896 | sky@google.com | 2008-10-24 03:54:26 +0200 (Fri, 24 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_drag_utils.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_drag_utils.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Refactors some of the bookmark drag and drop code into a separate
class that I can use in the bookmark manager.

BUG=674
TEST=make sure drag and drop on the bookmark bar still works,
     especially when moving folders around.

Review URL: http://codereview.chromium.org/8115
------------------------------------------------------------------------
r3858 | evanm@google.com | 2008-10-23 23:15:42 +0200 (Thu, 23 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.cc
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.h
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Port some more parts of browser/

This first needs http://codereview.chromium.org/6492
(porting base/process_util).

BUG=2333

Review URL: http://codereview.chromium.org/6268

------------------------------------------------------------------------
r3852 | ananta@chromium.org | 2008-10-23 22:49:07 +0200 (Thu, 23 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h
   M /trunk/src/chrome/browser/tab_contents.cc

This fixes http://code.google.com/p/chromium/issues/detail?id=2529, which is
tabs displaying Loading/Untitled in Chrome. We should display the page URL
if the title of the page is blank.

Fix on these lines.

R=beng

Review URL: http://codereview.chromium.org/7905
------------------------------------------------------------------------
r3844 | jungshik@google.com | 2008-10-23 21:55:10 +0200 (Thu, 23 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Set |contents_mime_type| early enough so that the encoding menu is enabled on the first load of a page
in a tab. 


BUG=2929
TEST=Launch Chrome, go to www.google.com and make sure that the encoding menu is enabled.

Review URL: http://codereview.chromium.org/7894
------------------------------------------------------------------------
r3821 | tc@google.com | 2008-10-23 20:00:58 +0200 (Thu, 23 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Add a separate string for showing that chrome updated without
a version number. This makes it easier for translators to
handle both cases.

BUG=2656
Review URL: http://codereview.chromium.org/7900
------------------------------------------------------------------------
r3814 | sky@google.com | 2008-10-23 18:47:41 +0200 (Thu, 23 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_folder_tree_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_table_model.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_table_model_unittest.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/tree_node_model.h

Adds models needed by the bookmark manager. Specifically a
BookmarkTableModel, which will be used to show one of the following:
the children of a folder, recently bookmarked or the results of a
search. And the tree model implementation that shows the folders.

BUG=674
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/8063
------------------------------------------------------------------------
r3811 | kasperl@google.com | 2008-10-23 15:00:34 +0200 (Thu, 23 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.h
   M /trunk/src/webkit/port/bindings/v8/v8_events.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_npobject.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.cpp

Update V8 in Chromium and fix compilation errors 
resulting from API changes.

NOTE: I'll probably submit this with a slightly later
V8; I'm still waiting for the try-finally issue to
be resolved.
Review URL: http://codereview.chromium.org/7913
------------------------------------------------------------------------
r3805 | tc@google.com | 2008-10-23 02:57:50 +0200 (Thu, 23 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Disable link doctor when in off the record/incognito mode.

BUG=3493
Review URL: http://codereview.chromium.org/8088
------------------------------------------------------------------------
r3803 | ben@chromium.org | 2008-10-23 02:37:56 +0200 (Thu, 23 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fix crash due to NULL deref.

http://crbug.com/3183
Review URL: http://codereview.chromium.org/8069
------------------------------------------------------------------------
r3797 | estade@chromium.org | 2008-10-23 01:48:34 +0200 (Thu, 23 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc

Change a dependency from clipboard_util.h to the more cross-platform clipboard.h

Review URL: http://codereview.chromium.org/7884
------------------------------------------------------------------------
r3776 | ericroman@google.com | 2008-10-23 00:04:54 +0200 (Thu, 23 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Change the default http stack for chrome.exe from winhttp to the new one.

http://code.google.com/p/chromium/issues/detail?id=2645

Review URL: http://codereview.chromium.org/7876
------------------------------------------------------------------------
r3770 | evanm@google.com | 2008-10-22 23:33:27 +0200 (Wed, 22 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/stats_table.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/web_contents.cc

Reduce header dependencies.

Random files in V8Bindings were getting rebuilt when I touched process_util.h.  I tracked it down to stats_table.h and shared_memory.h.  This change cuts down some dependencies there; more could be removed if we made some of our FooHandle typedefs into abstract data types instead.

Review URL: http://codereview.chromium.org/7307

------------------------------------------------------------------------
r3759 | jungshik@google.com | 2008-10-22 22:23:52 +0200 (Wed, 22 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Make the character encoding override work again. There are two other bugs with character encoding override, but it seems that it's better to fix them separately.

BUG=3315

Review URL: http://codereview.chromium.org/7647
------------------------------------------------------------------------
r3754 | glen@google.com | 2008-10-22 22:07:36 +0200 (Wed, 22 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc

Apply the already-reviewed <http://codereview.chromium.org/2936> by developer0420.

I updated it to always have reload enabled, as you sometimes want to reload while a page is loading.

BUG=204
TBR=ben

Review URL: http://codereview.chromium.org/8016
------------------------------------------------------------------------
r3727 | bradnelson@google.com | 2008-10-22 08:04:33 +0200 (Wed, 22 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/renderer/SConscript

Switching hash/ to $CHROME_SRC_DIR/chrome down in chrome.

Review URL: http://codereview.chromium.org/7856
------------------------------------------------------------------------
r3725 | bradnelson@google.com | 2008-10-22 07:03:39 +0200 (Wed, 22 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/base/base_lib.scons
   M /trunk/src/base/base_unittests.scons
   M /trunk/src/base/gfx/base_gfx.scons
   M /trunk/src/breakpad/SConscript
   M /trunk/src/build/SConscript.main
   M /trunk/src/build/SConscript.v8
   M /trunk/src/build/googleurl_lib.scons
   M /trunk/src/build/googleurl_unittests.scons
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/app/resources/SConscript
   M /trunk/src/chrome/app/theme/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/debugger/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/plugin/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/activex_test_control/SConscript
   M /trunk/src/chrome/test/automation/SConscript
   M /trunk/src/chrome/test/chrome_plugin/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/memory_test/SConscript
   M /trunk/src/chrome/test/mini_installer_test/SConscript
   M /trunk/src/chrome/test/page_cycler/SConscript
   M /trunk/src/chrome/test/plugin/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/security_tests/SConscript
   M /trunk/src/chrome/test/selenium/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/test/tab_switching/SConscript
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/tools/crash_service/SConscript
   M /trunk/src/chrome/tools/perf/flush_cache/SConscript
   M /trunk/src/chrome/tools/test/image_diff/SConscript
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/gears/SConscript.googleurl
   M /trunk/src/net/crash_cache.scons
   M /trunk/src/net/net_lib.scons
   M /trunk/src/net/net_perftests.scons
   M /trunk/src/net/net_resources.scons
   M /trunk/src/net/net_unittests.scons
   M /trunk/src/net/stress_cache.scons
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.scons
   M /trunk/src/skia/SConscript
   M /trunk/src/third_party/libpng/libpng.scons
   M /trunk/src/third_party/modp_b64/modp_b64.scons
   M /trunk/src/webkit/SConscript
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/activex_shim/SConscript
   M /trunk/src/webkit/activex_shim_dll/SConscript
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/localized_strings/SConscript
   M /trunk/src/webkit/build/port/SConscript
   M /trunk/src/webkit/default_plugin/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript

Using $CHROME_SRC_DIR in place of hash/..
This will facilitate changing where the main sconstruct lives.

Review URL: http://codereview.chromium.org/7847
------------------------------------------------------------------------
r3724 | ben@chromium.org | 2008-10-22 06:43:20 +0200 (Wed, 22 Oct 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc

forgot this file too
------------------------------------------------------------------------
r3721 | ben@chromium.org | 2008-10-22 06:19:19 +0200 (Wed, 22 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/views/base_button.h
   M /trunk/src/chrome/views/non_client_view.h

Fix the bug with the minimize/restore buttons getting stuck hot when the window is restored.
Turns out the messages we receive prior to becoming restored/minimized etc are not sufficient to restore the button to its appropriate state. Since this is specific to the implementation of these controls, I have provided a solution specific to them.

http://crbug.com/3559
Review URL: http://codereview.chromium.org/7803
------------------------------------------------------------------------
r3717 | paulg@google.com | 2008-10-22 04:05:09 +0200 (Wed, 22 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Change the detection of the list name from parsing a URL
to storing it from the update in order to avoid breaking
due to changes in the format.
Review URL: http://codereview.chromium.org/7851
------------------------------------------------------------------------
r3714 | jar@google.com | 2008-10-22 03:07:22 +0200 (Wed, 22 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc

Correct typo in histogram name (I left out the word trial)

r=mbelshe
Review URL: http://codereview.chromium.org/8045
------------------------------------------------------------------------
r3711 | ericroman@google.com | 2008-10-22 02:32:54 +0200 (Wed, 22 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Rollback r3693 as it caused a 7% startup test slowdown.

BUG=3639

Review URL: http://codereview.chromium.org/8044
------------------------------------------------------------------------
r3705 | finnur@google.com | 2008-10-22 01:51:23 +0200 (Wed, 22 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Fixing various layout issues with the download shelf:

1) Bug 3424: If you download an EXE which takes a while to start and you switch tabs before it does, then when you come back to the tab it would truncate the dangerous download on the right because we have never cached the size of the label. We now perform a SizeLabelToMinWidth() in the constructor of DownloadItem for dangerous downloads to make sure the calculation has taken place when needed.

2) Bug 3424: Once I fixed the problem above, I also noticed that the Save and Discard buttons would not show since the cached button sizes are 0 because the view animation took place while the shelf was hidden (while the shelf had no parent). By triggering a Layout of the shelf after setting the bounds, this triggers the buttons to draw appropriately.

3) Bug 3459: The remaining work was to fix the truncation on the bottom of the dangerous download view by taking the size of the progress icon for non-dangerous downloads into account. Ideally, we should increase the size of a non-dangerous download view if the warning icon or the buttons on the dangerous download view cause the size to increase, but I find that unlikely and it should be easy to fix if we come across that.

Review URL: http://codereview.chromium.org/7843
------------------------------------------------------------------------
r3697 | jcampan@chromium.org | 2008-10-22 00:59:45 +0200 (Wed, 22 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Temporary disabling accessibility in the renderer to work-around bug 1432077 which causes a crasher on tablet PCs (which for some reason issue WM_GETOBJECT messages).
Once that bug is fixed (John is currently working on it), then we can reenable it.

BUG=1432077

Review URL: http://codereview.chromium.org/7823
------------------------------------------------------------------------
r3696 | jar@google.com | 2008-10-22 00:30:55 +0200 (Wed, 22 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc

Create memory histograms that also depend on the memory-model experiment

The experiment was set up to measure tab switch time impact, and this
mod will allow us to see the impact on user memory (and user perception of
memory).

r=mbelshe
Review URL: http://codereview.chromium.org/8027
------------------------------------------------------------------------
r3693 | ericroman@google.com | 2008-10-21 23:49:49 +0200 (Tue, 21 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Change the default http stack for chrome.exe from winhttp to the new one.

http://code.google.com/p/chromium/issues/detail?id=2645

Review URL: http://codereview.chromium.org/7668
------------------------------------------------------------------------
r3692 | tc@google.com | 2008-10-21 23:45:54 +0200 (Tue, 21 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webinputevent_mac.mm
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc

Remove WebKeyboardEvent::key_data because we don't actually use it
anymore.  This makes WebKeyboardEvent easier to port to other
platforms.
Review URL: http://codereview.chromium.org/8026
------------------------------------------------------------------------
r3687 | deanm@chromium.org | 2008-10-21 23:29:01 +0200 (Tue, 21 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome.dll.deps
   M /trunk/src/chrome/browser/visitedlink_master.cc

Don't use UuidCreate as a source of randomness, and it's not portable.  This removes chrome.dll's dependence on rpcrt4.dll (although it will still likely be loaded later).  If the change is fine, I will also remove it from the depends list and the build configuration files.
Review URL: http://codereview.chromium.org/7818
------------------------------------------------------------------------
r3684 | mark@chromium.org | 2008-10-21 23:08:50 +0200 (Tue, 21 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/url_fetcher.cc
   M /trunk/src/chrome/browser/url_fetcher.h
   M /trunk/src/chrome/browser/url_fetcher_protect.cc
   M /trunk/src/chrome/browser/url_fetcher_protect.h
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Run MetricsResponseTest on the Mac.  This test depended on
url_fetcher_protect.h, which contained a ProtectEntry class, but this name
conflicts with the ProtectEntry function in QuickDraw, and apparently QuickDraw
headers were being brought in by some other system header we use.  Rename our
ProtectEntry to URLFetcherProtectEntry, and change ProtectManager for
consistency.
Review URL: http://codereview.chromium.org/7834
------------------------------------------------------------------------
r3666 | brettw@google.com | 2008-10-21 20:08:09 +0200 (Tue, 21 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc

Fix a timing problem that caused the find bar's coordinates to be incorrect.
The visible flag was getting set twice from two different sources, one of which
was wrong.
Review URL: http://codereview.chromium.org/7820
------------------------------------------------------------------------
r3663 | brettw@google.com | 2008-10-21 19:41:42 +0200 (Tue, 21 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc

Add a sleep to temporarily fix the find in page test.
Review URL: http://codereview.chromium.org/7819
------------------------------------------------------------------------
r3655 | brettw@google.com | 2008-10-21 17:20:20 +0200 (Tue, 21 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/find_bar_win_uitest.cc

Fix include path from last checkin.
Review URL: http://codereview.chromium.org/7815
------------------------------------------------------------------------
r3654 | brettw@google.com | 2008-10-21 17:03:01 +0200 (Tue, 21 Oct 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   D /trunk/src/chrome/browser/find_in_page_controller.cc
   D /trunk/src/chrome/browser/find_in_page_controller.h
   D /trunk/src/chrome/browser/find_in_page_controller_interactive_uitest.cc
   D /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   D /trunk/src/chrome/browser/find_in_page_view.cc
   D /trunk/src/chrome/browser/find_in_page_view.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   A /trunk/src/chrome/browser/views/find_bar_view.cc (from /trunk/src/chrome/browser/find_in_page_view.cc:3600)
   A /trunk/src/chrome/browser/views/find_bar_view.h (from /trunk/src/chrome/browser/find_in_page_view.h:3600)
   A /trunk/src/chrome/browser/views/find_bar_win.cc (from /trunk/src/chrome/browser/find_in_page_controller.cc:3600)
   A /trunk/src/chrome/browser/views/find_bar_win.h (from /trunk/src/chrome/browser/find_in_page_controller.h:3600)
   A /trunk/src/chrome/browser/views/find_bar_win_interactive_uitest.cc (from /trunk/src/chrome/browser/find_in_page_controller_interactive_uitest.cc:3606)
   A /trunk/src/chrome/browser/views/find_bar_win_uitest.cc (from /trunk/src/chrome/browser/find_in_page_controller_uitest.cc:3606)
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Factor find in page out of WebContents and into the view, since it is almost
all view specific. Rename find in page controller to be "FindBarWin", and
find in page view to be "findBarView" (since this is not Windows specific, but
"Views" specific).

I did lots of simplification and moving around of the find in page API. I
coalesced several of the show functions into one master function on the view.

I removed some other sizing and window updating code from WebContents and moved
it to the view.
Review URL: http://codereview.chromium.org/7667
------------------------------------------------------------------------
r3645 | ben@chromium.org | 2008-10-21 03:47:22 +0200 (Tue, 21 Oct 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h

try rolling this back to see if it helps
------------------------------------------------------------------------
r3644 | aa@chromium.org | 2008-10-21 03:00:46 +0200 (Tue, 21 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/greasemonkey_master.cc

Fix breakage from r3643.

------------------------------------------------------------------------
r3643 | aa@chromium.org | 2008-10-21 02:49:49 +0200 (Tue, 21 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/greasemonkey_master.cc
   M /trunk/src/chrome/browser/greasemonkey_master.h
   M /trunk/src/chrome/renderer/greasemonkey_slave.cc
   M /trunk/src/chrome/renderer/greasemonkey_slave.h

Show the path to the Greasemonkey script that caused an error
in the console.

Review URL: http://codereview.chromium.org/7533
------------------------------------------------------------------------
r3630 | glen@google.com | 2008-10-20 23:09:48 +0200 (Mon, 20 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

To go with the retardation of recently closed tabs, remove the yellow from the style.

Review URL: http://codereview.chromium.org/7624
------------------------------------------------------------------------
r3627 | jar@google.com | 2008-10-20 22:40:14 +0200 (Mon, 20 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc

Restore field trial for memory model

Rollback was not needed to correct distributed test regression.

This reverts changes in 3608, which were done to try to repair the
regression.

r=huanr
Review URL: http://codereview.chromium.org/7522
------------------------------------------------------------------------
r3621 | pkasting@chromium.org | 2008-10-20 21:35:07 +0200 (Mon, 20 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc

Fix ctrl-k not working.

This was just an artifact of how I changed my mind a number of times during the AutocompleteEdit model/view split and failed to ultimately do the right thing here.

BUG=2901
Review URL: http://codereview.chromium.org/7672
------------------------------------------------------------------------
r3620 | beng@google.com | 2008-10-20 21:32:40 +0200 (Mon, 20 Oct 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h

More Windows-is-a-crack-baby mitigation.

I think I've finally fixed this. Knock on wood. Turns out that these two
additional places do non-client rendering:

- DefWindowProc for WM_NCLBUTTONDOWN
- the function EnableMenuItem (called from CustomFrameWindow::OnInitMenu)

For the first case, we also need to unlock updating when we begin to receive
mouse move events during modal size/move loops, otherwise the feedback won't be
visually continuous.

http://crbug.com/3264
Review URL: http://codereview.chromium.org/7662
------------------------------------------------------------------------
r3608 | jar@google.com | 2008-10-20 19:43:59 +0200 (Mon, 20 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc

Disable FieldTrial code to repair UI reliability test regression

r=mbelshe
Review URL: http://codereview.chromium.org/7520
------------------------------------------------------------------------
r3604 | jar@google.com | 2008-10-19 19:45:21 +0200 (Sun, 19 Oct 2008) | 11 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   A /trunk/src/base/field_trial.cc
   A /trunk/src/base/field_trial.h
   A /trunk/src/base/field_trial_unittest.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   A /trunk/src/chrome/browser/browser_trial.cc
   A /trunk/src/chrome/browser/browser_trial.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc

Construct a field trial to see if HIGH or MEDIUM memory model "works better"

Includes definition of a FieldTrial class to support this.
I have thoughts in my head about how this will eventually
extend to be controllable via UMA (as well as being able
to run tests defined at compile time, as was done in this
example.


r=mbelshe, mmentovai
Review URL: http://codereview.chromium.org/7638
------------------------------------------------------------------------
r3603 | finnur@google.com | 2008-10-19 06:37:48 +0200 (Sun, 19 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Issue 3487: We now set the bounds for the links in the About box as soon as we know where they should be placed, instead of waiting until the Layout call to do so. This fixes an issue of the links not appearing at all -- something, that I can't reproduce myself, but Darin could on his Vista machine (until he tried this fix). 
Review URL: http://codereview.chromium.org/7513
------------------------------------------------------------------------
r3601 | brettw@google.com | 2008-10-18 17:37:29 +0200 (Sat, 18 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Move more platform-specific stuff from WebContents to the view.

I refactored the way title setting is done since there were two parts that duplicated the logic and did so slightly differently.

I removed some old code in RendererGone whose premise is no longer valid and had the effect of creating a bug with no benefit.

I moved the sad tab view from WebContents to the view. Amusingly, the view was the only one using this, but it would go poke inside of the WebContents to get it.
Review URL: http://codereview.chromium.org/7650
------------------------------------------------------------------------
r3579 | ben@chromium.org | 2008-10-18 01:44:49 +0200 (Sat, 18 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Support shortcut show styles for "run maximized", "run minimized" etc.

http://crbug.com/3278
Review URL: http://codereview.chromium.org/7504
------------------------------------------------------------------------
r3575 | sky@google.com | 2008-10-18 00:44:28 +0200 (Sat, 18 Oct 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h

Changes BookmarkDragData to allow for multiple nodes. I'm going to
need this for the bookmark manager, which will let you drag multiple
nodes around.

I didn't make the bookmark bar deal with multiple nodes though (it
won't allow a drop of multiple nodes). I may add support for this at
some point, but not in this patch.

BUG=674
TEST=covered by unit tests, but make sure the aren't problems dragging
  around bookmarks on the bookmark bar, especially with folders.

Review URL: http://codereview.chromium.org/7498
------------------------------------------------------------------------
r3570 | jcampan@chromium.org | 2008-10-18 00:06:58 +0200 (Sat, 18 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

We were still warning about a dangerous download when the user has picked the option to always ask for download.

BUG=3539
TEST=Select the option "always ask for download". Download an exe. You should not see a dangerous download warning.
Review URL: http://codereview.chromium.org/7634
------------------------------------------------------------------------
r3569 | ben@chromium.org | 2008-10-17 23:56:10 +0200 (Fri, 17 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h

Straighten out the way the system menu works a bit. We no longer create the menu every time it is shown (or reset it). Resetting it caused some system-wide system menu items to be voted off the island (e.g. nView desktop manager, and some other third party addins). Resetting also caused some of the NC overpainting issues to be worse.
This simplifies things a bit by creating the menu at frame creation time, then when the menu is run doing enabling only.
Review URL: http://codereview.chromium.org/7497
------------------------------------------------------------------------
r3568 | erg@google.com | 2008-10-17 23:53:08 +0200 (Fri, 17 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/base/ref_counted.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/test/data/constrained_files/infinite_popups.html
   A /trunk/src/chrome/test/data/constrained_files/infinite_popups_impl.html

Remove throttling code from the Browser process and implement throttling in the Renderer.

The previous way of doing throttling was just calling CloseContents() on a window to reject it. But since the Browser is notified about a window opening asynchronously, by the time the CloseContents() sends a message back to the Renderer, a bunch more windows have been opened, leading to memory exhaustion. 

Instead, make all RenderViews created from a parent RenderView share a counter and start refusing to create RenderViews if too many RV have been created. Every RenderView (except for the first one) is assumed to be an unrequested popup, until notified by the Browser process by either a ViewMsg_DisassociateFromPopupCount message (this RenderView is a new top level page) or a ViewMsg_DisassociatePopup message (this RenderView is a requested popup and therefore shouldn't count against the count.)

BUG=3382, 2632
Review URL: http://codereview.chromium.org/7388
------------------------------------------------------------------------
r3567 | ericroman@google.com | 2008-10-17 23:43:20 +0200 (Fri, 17 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/mime_sniffer_unittest.cc

Fix problem where "text/xml" responses get buffered past 512 bytes, causing the response to be truncated.

BUG=3521

Review URL: http://codereview.chromium.org/7610
------------------------------------------------------------------------
r3563 | mark@chromium.org | 2008-10-17 23:16:13 +0200 (Fri, 17 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/chrome.xcodeproj/project.pbxproj

Make ChromeThreadTest and TextDatabaseTest inherit from PlatformTest for
autorelease pool management on the Mac.
Review URL: http://codereview.chromium.org/7640
------------------------------------------------------------------------
r3556 | ben@chromium.org | 2008-10-17 22:29:50 +0200 (Fri, 17 Oct 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

more bustage fixes
------------------------------------------------------------------------
r3550 | ben@chromium.org | 2008-10-17 21:33:09 +0200 (Fri, 17 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/views/container.h
   M /trunk/src/chrome/views/container_win.cc
   M /trunk/src/chrome/views/container_win.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h

Convert SchedulePaint and a few other methods to use gfx types.

http://crbug.com/2186
Review URL: http://codereview.chromium.org/7468
------------------------------------------------------------------------
r3549 | brettw@google.com | 2008-10-17 21:29:29 +0200 (Fri, 17 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc

Remove some code I accidentally left in which is causing asserts and crashes.
close_on_deactivate_ was getting set to true which was deleting the object,
causing us to crash later. The code that originally set this externally is
still there, so this restores the old behavior.

TEST=Press tab on any page, it shouldn't assert or crash.
Review URL: http://codereview.chromium.org/7631
------------------------------------------------------------------------
r3546 | sidchat@google.com | 2008-10-17 20:36:48 +0200 (Fri, 17 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Fix a potential crasher in SpellChecker Add to dictionary feature.

Issue=3039
Review URL: http://codereview.chromium.org/7484
------------------------------------------------------------------------
r3543 | sky@google.com | 2008-10-17 20:07:02 +0200 (Fri, 17 Oct 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_process.h
   A /trunk/src/chrome/browser/download/download_request_manager.cc
   A /trunk/src/chrome/browser/download/download_request_manager.h
   A /trunk/src/chrome/browser/download/download_request_manager_unittest.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents_factory.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   A /trunk/src/chrome/test/test_tab_contents.cc
   A /trunk/src/chrome/test/test_tab_contents.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/message_box_view.h

Adds the anti-carpet bombing dialog. More specifically a new
EventHandler now exists between the buffered event handler and
download event handler. This new event handler asks the
DownloadRequestManager whether the download is allowed. This may
prompt the user and then the download continues or is canceled. The
DownloadRequestManager receives the request on the IO thread, forwards
to the UI thread, makes the decision, then notifies back on the IO
thread.

BUG=3422
TEST=make sure you don't see any problems downloading content.

Review URL: http://codereview.chromium.org/7479
------------------------------------------------------------------------
r3542 | cpu@google.com | 2008-10-17 20:05:54 +0200 (Fri, 17 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h

Add processing for a master profile json file on first run. Allows:
- set home page / show home button
- show bookmarks bar

Review URL: http://codereview.chromium.org/7369
------------------------------------------------------------------------
r3536 | jcampan@chromium.org | 2008-10-17 19:34:16 +0200 (Fri, 17 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc

Fix bug 3470, where the download tab would show the temporary name for dangerous downloads (see download_tab_view.cc).

Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first).

BUG=3470, 3471
TEST=see bugs
Review URL: http://codereview.chromium.org/7395
------------------------------------------------------------------------
r3534 | finnur@google.com | 2008-10-17 19:19:43 +0200 (Fri, 17 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc

Add some trace statements in an attempt to find the reason why a Find test is flaky. This will be removed once I get a run that hangs again.

Review URL: http://codereview.chromium.org/7626
------------------------------------------------------------------------
r3533 | ben@chromium.org | 2008-10-17 19:19:34 +0200 (Fri, 17 Oct 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc

testing a theory...
------------------------------------------------------------------------
r3529 | sky@google.com | 2008-10-17 17:39:21 +0200 (Fri, 17 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h

Removes expiring of recently closed tabs from new tab page. Also makes
it so that if you restore a tab we remove from the tab restore service
(this is what control-shift-t does too).

BUG=2598
TEST=make sure closed tabs still show up on the new tab page.
Review URL: http://codereview.chromium.org/4016
------------------------------------------------------------------------
r3528 | glen@google.com | 2008-10-17 17:38:10 +0200 (Fri, 17 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h

Fix bug where a shelf or infobar would not be closed correctly when closing a tab. 

The issue was because ShelfVisibilityChangedImpl is called twice, once with a null current_tab for the closing tab (via TabClosingAt), and once on selection of the new tab (via TabSelectedAt) - the first call nulls the shelves without doing a Layout, the nulled shelves then don't show up in the second call, so Layout is never called.

http://crbug.com/2069

BUG=2069

Review URL: http://codereview.chromium.org/7155
------------------------------------------------------------------------
r3527 | brettw@google.com | 2008-10-17 17:29:03 +0200 (Fri, 17 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host_view.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/render_widget_host_view_win.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   A /trunk/src/chrome/browser/web_contents_view.cc
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc

Separate out most view creation from WebContents. This adds a new sub-delegate to RenderViewHostDelegate which is implemented by WebContentsView. I did a lot of plumbing and moving around as a result.
Review URL: http://codereview.chromium.org/6608
------------------------------------------------------------------------
r3512 | tc@google.com | 2008-10-17 07:38:32 +0200 (Fri, 17 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

The translation lead requested that this sentence be a single
string, otherwise it will likely be grammatically incorrect.

This is a hack until http://crbug.com/3295 is implemented.
Review URL: http://codereview.chromium.org/7396
------------------------------------------------------------------------
r3506 | hbono@chromium.org | 2008-10-17 05:24:23 +0200 (Fri, 17 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

A quick fix for a possible assertion caused by r3407.
When a user opens a "Fonts and Languages" dialog (through [Options] -> [Change Font and Language Settings]) and presses its "OK" button without changing anything, the debug build of Chromium raises an assert exception because the LanguagePageView::SaveChanges() function reads the value of an initialized member variable |LanguagePageView::spellcheck_language_index_selected_|.
To prevent this possible assertion, this change initializes the member variable |LanguagePageView::spellcheck_language_index_selected_| to -1 in the constructor of the LanguagePageView class.
Review URL: http://codereview.chromium.org/7387
------------------------------------------------------------------------
r3499 | aa@google.com | 2008-10-17 02:12:14 +0200 (Fri, 17 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.h

Adding missing file from r3496.

------------------------------------------------------------------------
r3496 | aa@google.com | 2008-10-17 01:57:47 +0200 (Fri, 17 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/greasemonkey_master.cc
   A /trunk/src/chrome/browser/greasemonkey_master.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/greasemonkey_slave.cc
   A /trunk/src/chrome/renderer/greasemonkey_slave.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h

Adds a bit of Greasemonkey support hidden behind the --enable-greasemonkey flag. Implementation follows the pattern of the visited links system.

Things still to be done:
- stop using a hardcoded script directory
- watch script directory and update shared memory when necessary
- move file io to background thread
- support for @include patterns -- now, all scripts are applied to all pages
Review URL: http://codereview.chromium.org/7254
------------------------------------------------------------------------
r3495 | ben@chromium.org | 2008-10-17 01:51:38 +0200 (Fri, 17 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/controller.cc
   M /trunk/src/chrome/browser/controller.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_controller.h
   M /trunk/src/chrome/browser/find_in_page_controller_interactive_uitest.cc
   M /trunk/src/chrome/browser/find_in_page_view.cc
   M /trunk/src/chrome/browser/find_in_page_view.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/browser/frame_util.h
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history_tab_ui.cc
   M /trunk/src/chrome/browser/history_tab_ui.h
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/history_view.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/js_before_unload_handler.cc
   M /trunk/src/chrome/browser/js_before_unload_handler.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.h
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/status_view.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/delay_view.cc
   M /trunk/src/chrome/browser/views/delay_view.h
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/event_utils.cc
   M /trunk/src/chrome/browser/views/event_utils.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.h
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.cc
   M /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.h
   M /trunk/src/chrome/browser/views/info_bar_confirm_view.cc
   M /trunk/src/chrome/browser/views/info_bar_confirm_view.h
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.h
   M /trunk/src/chrome/browser/views/info_bar_message_view.cc
   M /trunk/src/chrome/browser/views/info_bar_message_view.h
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/info_bar_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/input_window.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/browser/views/old_frames/frame_view.cc
   M /trunk/src/chrome/browser/views/old_frames/frame_view.h
   M /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/standard_layout.h
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/accelerator.h
   M /trunk/src/chrome/views/accelerator_handler.cc
   M /trunk/src/chrome/views/accelerator_handler.h
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.cc
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.h
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.h
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.h
   M /trunk/src/chrome/views/app_modal_dialog_delegate.h
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/background.h
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/base_button.h
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.h
   M /trunk/src/chrome/views/border.cc
   M /trunk/src/chrome/views/border.h
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button.h
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/button_dropdown.h
   M /trunk/src/chrome/views/checkbox.cc
   M /trunk/src/chrome/views/checkbox.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/chrome/views/combo_box.cc
   M /trunk/src/chrome/views/combo_box.h
   M /trunk/src/chrome/views/container.h
   M /trunk/src/chrome/views/container_win.cc
   M /trunk/src/chrome/views/container_win.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/decision.cc
   M /trunk/src/chrome/views/decision.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_client_view.h
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/dialog_delegate.h
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/external_focus_tracker.cc
   M /trunk/src/chrome/views/external_focus_tracker.h
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/grid_layout.cc
   M /trunk/src/chrome/views/grid_layout.h
   M /trunk/src/chrome/views/grid_layout_unittest.cc
   M /trunk/src/chrome/views/group_table_view.cc
   M /trunk/src/chrome/views/group_table_view.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view.h
   M /trunk/src/chrome/views/image_view.cc
   M /trunk/src/chrome/views/image_view.h
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/label.h
   M /trunk/src/chrome/views/layout_manager.cc
   M /trunk/src/chrome/views/layout_manager.h
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/link.h
   M /trunk/src/chrome/views/menu.cc
   M /trunk/src/chrome/views/menu.h
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/menu_button.h
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/message_box_view.h
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/native_button.h
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_control.h
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/native_scroll_bar.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/painter.h
   M /trunk/src/chrome/views/radio_button.cc
   M /trunk/src/chrome/views/radio_button.h
   M /trunk/src/chrome/views/repeat_controller.cc
   M /trunk/src/chrome/views/repeat_controller.h
   M /trunk/src/chrome/views/resize_corner.cc
   M /trunk/src/chrome/views/resize_corner.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/root_view_drop_target.h
   M /trunk/src/chrome/views/scroll_bar.cc
   M /trunk/src/chrome/views/scroll_bar.h
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/scroll_view.h
   M /trunk/src/chrome/views/separator.cc
   M /trunk/src/chrome/views/separator.h
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/tabbed_pane.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_button.h
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/text_field.h
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/throbber.h
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.h
   M /trunk/src/chrome/views/tree_node_model.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/tree_view.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_menu_delegate.h
   M /trunk/src/chrome/views/view_storage.cc
   M /trunk/src/chrome/views/view_storage.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.cc
   M /trunk/src/chrome/views/window_delegate.h
   M /trunk/src/chrome/views/window_resources.h

Rename ChromeViews namespace to views

http://crbug.com/2188
------------------------------------------------------------------------
r3493 | finnur@google.com | 2008-10-17 01:27:04 +0200 (Fri, 17 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_shelf_view.cc

Fixing build: GetViewContainer changed name from under me. :)

TBR=jcampan

Review URL: http://codereview.chromium.org/7464
------------------------------------------------------------------------
r3492 | finnur@google.com | 2008-10-17 01:15:34 +0200 (Fri, 17 Oct 2008) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_shelf_view.cc

Fix crash in downloading files (issue 3423).

I was finally able to reproduce a problem where we would crash when
clicking Save on the Download Tab (it would also crash during animation
of the items on the download shelf after switching away from the tab
downloading).

The reason for the crash is that if the controls on the download shelf
have not been laid out once (before switching to a tab that doesn't have
a download shelf), then we'll crash inside NativeControlContainer ctor
when it tries to ValidateNativeControl() (it walks up the parent
hierarchy trying to find the ViewContainer and ends up dereferencing a
NULL pointer).


This was reviewed by jcampan as http://codereview.chromium.org/7446
I had to recreate the changelist before submitting (long story).


Review URL: http://codereview.chromium.org/7604
------------------------------------------------------------------------
r3485 | agl@chromium.org | 2008-10-16 23:01:42 +0200 (Thu, 16 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/test/testing_browser_process.h

Remove more shared_event that I missed last time

TBR=evan

Review URL: http://codereview.chromium.org/7397

------------------------------------------------------------------------
r3480 | jcampan@chromium.org | 2008-10-16 22:19:48 +0200 (Thu, 16 Oct 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc

When a mixed-content resource was loaded, we would apply the mixed-content state to the active entry, which would be the pending entry if there is one.
That caused a problem in cases where a bad resource is loading and we are initiating a navigation from the browser (and therefore creating a pending entry).

More details:
In the GoodFrame test, the top-frame is HTTPS and we load an HTTP frame with an image. As soon as the bad frame has loaded, we navigate back (creating a pending entry). In rare cases, the notification for the mixed-content image of the HTTP frame would happen after the back action, mistakingly setting the mixed-content state on the pending entry.

BUG=2742
TEST=Run the SSL UI tests 1000 times.
Review URL: http://codereview.chromium.org/7440
------------------------------------------------------------------------
r3471 | ben@chromium.org | 2008-10-16 20:17:47 +0200 (Thu, 16 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/base/gfx/rect.cc
   M /trunk/src/base/gfx/rect.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_view.cc
   M /trunk/src/chrome/browser/find_in_page_view.h
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/history_view.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/delay_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.h
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/info_bar_view.h
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.h
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/checkbox.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/chrome/views/container_win.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/decision.cc
   M /trunk/src/chrome/views/decision.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_client_view.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view.h
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_control.h
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/native_scroll_bar.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/scroll_view.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/text_field.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_unittest.cc

Make View::SetBounds take a const gfx::Rect& instead of a const CRect&
Make View::DidChangeBounds call Layout by default, eliminating this function from most places.

http://crbug.com/2186

Review URL: http://codereview.chromium.org/7429
------------------------------------------------------------------------
r3470 | mark@chromium.org | 2008-10-16 20:05:45 +0200 (Thu, 16 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc

Return without doing anything instead of dereferencing junk in unexpected cases.
Review URL: http://codereview.chromium.org/7416
------------------------------------------------------------------------
r3468 | sidchat@google.com | 2008-10-16 19:55:42 +0200 (Thu, 16 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Update SpellChecker to download the latest version of the bdic dictionary files.
Review URL: http://codereview.chromium.org/6474
------------------------------------------------------------------------
r3464 | sky@google.com | 2008-10-16 17:43:12 +0200 (Thu, 16 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Makes the following changes to the bookmark bar context menu:
. Nukes the open menu item.
. Adds open incognito and for folders open all incognito.

BUG=144
TEST=Fully test the context menu of bookmark folders/urls.

Review URL: http://codereview.chromium.org/7357
------------------------------------------------------------------------
r3463 | sgk@google.com | 2008-10-16 14:56:33 +0200 (Thu, 16 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript

Add browser\interstitial_page.cc to the SCons build.
Move render_widget_host_hwnd.cc to render_widget_host_win.cc.
Review URL: http://codereview.chromium.org/7336
------------------------------------------------------------------------
r3455 | mal@chromium.org | 2008-10-16 08:46:44 +0200 (Thu, 16 Oct 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Change the prefix for unconfirmed, potentially dangerous downloads 

  from: dangerous_download_%d

  to:   unconfirmed %d 

We want to avoid alarming names in the UI.

I'm open to better suggestions for the prefix.

R= jcampan@chromium.org, brian@chromium.org


Review URL: http://codereview.chromium.org/7107
------------------------------------------------------------------------
r3448 | petersont@google.com | 2008-10-16 04:18:07 +0200 (Thu, 16 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/test/ui/ui_test.cc


This is the same change as 2419 minus a line of debug code I accidentally left in browser_main.cc which ignored the user preference.

Review URL: http://codereview.chromium.org/4229
------------------------------------------------------------------------
r3443 | ben@chromium.org | 2008-10-16 03:24:47 +0200 (Thu, 16 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Fix broken resize from bottom with magic frame.

Review URL: http://codereview.chromium.org/7358
------------------------------------------------------------------------
r3441 | ben@chromium.org | 2008-10-16 02:26:30 +0200 (Thu, 16 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_controller.h
   M /trunk/src/chrome/browser/find_in_page_view.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/network_status_view.cc
   M /trunk/src/chrome/browser/network_status_view.h
   M /trunk/src/chrome/browser/render_widget_host_view_win.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h
   M /trunk/src/chrome/common/gfx/url_elider.cc
   M /trunk/src/chrome/common/gfx/url_elider_unittest.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/accessibility/constants.h
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.h
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/client_view.cc
   A /trunk/src/chrome/views/container.h (from /trunk/src/chrome/views/view_container.h:3405)
   A /trunk/src/chrome/views/container_win.cc (from /trunk/src/chrome/views/hwnd_view_container.cc:3405)
   A /trunk/src/chrome/views/container_win.h (from /trunk/src/chrome/views/hwnd_view_container.h:3405)
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/hwnd_view.cc
   D /trunk/src/chrome/views/hwnd_view_container.cc
   D /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/tabbed_pane.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   D /trunk/src/chrome/views/view_container.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Rename ViewContainer to Container and HWNDViewContainer to ContainerWin.

http://crbug.com/3430
Review URL: http://codereview.chromium.org/7376
------------------------------------------------------------------------
r3425 | paulg@google.com | 2008-10-15 23:55:32 +0200 (Wed, 15 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc

As agreed on by the SafeBrowsing server team:

1. Back off when we encounter a parse error.

2. Ignore commands we don't understand instead of returning an error.

3. Make redirect URL parsing in an update response more robust to changes in format.
Review URL: http://codereview.chromium.org/7329
------------------------------------------------------------------------
r3423 | kuchhal@chromium.org | 2008-10-15 23:37:46 +0200 (Wed, 15 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/result_codes.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/install_util.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h

Add a check in Chrome to not run user level mode if machine level Chrome
is already installed.
------------------------------------------------------------------------
r3420 | jar@google.com | 2008-10-15 23:21:37 +0200 (Wed, 15 Oct 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter.cc
   M /trunk/src/net/base/gzip_filter.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/base/sdch_filter.cc
   M /trunk/src/net/base/sdch_filter.h
   M /trunk/src/net/base/sdch_filter_unitest.cc
   M /trunk/src/net/base/sdch_manager.cc
   M /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h

Add a lot of robustness to SDCH filter decoding

a) Do meta-refresh (and partially disable sdch) when we have an sdch decode
error early on (due to lack of dictionary).

b) Gracefully handle proxy removal of "gzip" in "content-encoding: sdch,gzip". 

c) Recover from completely stripped content encoding (in response to a
request for which we advertised an SDCH dictionary) by using a filter
that can optionally decode sdch with an optional gzip as well.

Some field tests have shown problems with this protocol's 
transit across the ether. The general approach we've adopted
is to stop using SDCH on the problematic site when we have problems. This
will prevent a malicious site from shutting down all use of SDCH.

r=kmixter,openvcdiff,huanr

Review URL: http://codereview.chromium.org/6433
------------------------------------------------------------------------
r3407 | sidchat@google.com | 2008-10-15 21:30:41 +0200 (Wed, 15 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/test/testing_profile.h

Change SpellChecker language without restarting the browser.

Review URL: http://codereview.chromium.org/7056
------------------------------------------------------------------------
r3402 | beng@google.com | 2008-10-15 20:15:51 +0200 (Wed, 15 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

This file was left out of my last checkin due to prior gcl cruft.

http://crbug.com/2186
------------------------------------------------------------------------
r3400 | beng@google.com | 2008-10-15 20:02:30 +0200 (Wed, 15 Oct 2008) | 14 lines
Changed paths:
   M /trunk/src/base/gfx/size.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_view.cc
   M /trunk/src/chrome/browser/find_in_page_view.h
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/delay_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.h
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/info_bar_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.h
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button.h
   M /trunk/src/chrome/views/checkbox.cc
   M /trunk/src/chrome/views/checkbox.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/chrome/views/combo_box.cc
   M /trunk/src/chrome/views/combo_box.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/decision.cc
   M /trunk/src/chrome/views/decision.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_client_view.h
   M /trunk/src/chrome/views/grid_layout.cc
   M /trunk/src/chrome/views/grid_layout.h
   M /trunk/src/chrome/views/grid_layout_unittest.cc
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view.h
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/image_view.cc
   M /trunk/src/chrome/views/image_view.h
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/label.h
   M /trunk/src/chrome/views/layout_manager.cc
   M /trunk/src/chrome/views/layout_manager.h
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/menu_button.h
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/native_button.h
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/native_scroll_bar.h
   M /trunk/src/chrome/views/radio_button.cc
   M /trunk/src/chrome/views/radio_button.h
   M /trunk/src/chrome/views/separator.cc
   M /trunk/src/chrome/views/separator.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_button.h
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/text_field.h
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/throbber.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/window.cc

Convert GetPreferredSize from:

void GetPreferredSize(CSize* out);

to:

gfx::Size GetPreferredSize();

.. and update some other places to use gfx::Size as well.

http://crbug.com/2186


Review URL: http://codereview.chromium.org/7344
------------------------------------------------------------------------
r3399 | ben@chromium.org | 2008-10-15 20:01:10 +0200 (Wed, 15 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Insert NULL check to fix dist crash

Review URL: http://codereview.chromium.org/7407
------------------------------------------------------------------------
r3398 | maruel@google.com | 2008-10-15 19:56:40 +0200 (Wed, 15 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.h

Change #ifdef _DEBUG test to #ifndef NDEBUG test.
Review URL: http://codereview.chromium.org/7404
------------------------------------------------------------------------
r3396 | jcampan@chromium.org | 2008-10-15 19:48:32 +0200 (Wed, 15 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download/download_manager.cc

Fix a crasher when shutting down with a pending dangerous download.

BUG=3457
TEST=See bug
Review URL: http://codereview.chromium.org/7406
------------------------------------------------------------------------
r3385 | ben@chromium.org | 2008-10-15 01:47:31 +0200 (Wed, 15 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Enable magic browzr again.

R=mal
------------------------------------------------------------------------
r3384 | ben@chromium.org | 2008-10-15 01:45:09 +0200 (Wed, 15 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/old_frames/frame_view.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_unittest.cc

Convert HitTest/GetViewForPoint to use gfx::Point

http://crbug.com/2186
Review URL: http://codereview.chromium.org/7331
------------------------------------------------------------------------
r3382 | brettw@google.com | 2008-10-15 01:19:42 +0200 (Wed, 15 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/views/focus_manager.cc

Fix some places I missed the renaming changes.
Review URL: http://codereview.chromium.org/7332
------------------------------------------------------------------------
r3379 | brettw@google.com | 2008-10-15 00:56:54 +0200 (Wed, 15 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   D /trunk/src/chrome/browser/render_widget_host_hwnd.h
   M /trunk/src/chrome/browser/render_widget_host_view.h
   A /trunk/src/chrome/browser/render_widget_host_view_win.cc (from /trunk/src/chrome/browser/render_widget_host_hwnd.cc:3337)
   A /trunk/src/chrome/browser/render_widget_host_view_win.h (from /trunk/src/chrome/browser/render_widget_host_hwnd.h:3337)
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Rename RenderWidgetHostHWND to RenderWidgetHostViewWin for consistency with other view-related classes.

No logic change.
Review URL: http://codereview.chromium.org/7310
------------------------------------------------------------------------
r3377 | brettw@google.com | 2008-10-15 00:55:17 +0200 (Wed, 15 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/page_zoom.h (from /trunk/src/chrome/common/text_zoom.h:3355)
   M /trunk/src/chrome/common/render_messages_internal.h
   D /trunk/src/chrome/common/text_zoom.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc

Rename various text zoom related stuff to be more generic, since we now can
optionally zoom the page. I added an easy way in render_view to toggle between
text zoom and full page zoom, and allowed the embedder to specify this in the
glue layer. This allows me to fix the text zoom layout test, which specifically
asks that the text be zoomed.
Review URL: http://codereview.chromium.org/7320
------------------------------------------------------------------------
r3367 | ben@chromium.org | 2008-10-14 23:42:14 +0200 (Tue, 14 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Try and find the location of crash
Review URL: http://codereview.chromium.org/7323
------------------------------------------------------------------------
r3365 | ben@chromium.org | 2008-10-14 22:58:44 +0200 (Tue, 14 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/base/gfx/point.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/root_view_drop_target.h
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_unittest.cc

Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.

http://crbug.com/2186

Review URL: http://codereview.chromium.org/7317
------------------------------------------------------------------------
r3348 | ben@chromium.org | 2008-10-14 19:03:07 +0200 (Tue, 14 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/base/gfx/rect.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_view.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/grid_layout_unittest.cc
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_unittest.cc

Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. 

http://crbug.com/2186

Review URL: http://codereview.chromium.org/7136
------------------------------------------------------------------------
r3347 | brettw@google.com | 2008-10-14 18:52:52 +0200 (Tue, 14 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_view.h

Fix the build by including string.
Review URL: http://codereview.chromium.org/7303
------------------------------------------------------------------------
r3346 | brettw@google.com | 2008-10-14 18:42:25 +0200 (Tue, 14 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_view.h
   M /trunk/src/chrome/browser/web_contents_view_win.cc
   M /trunk/src/chrome/browser/web_contents_view_win.h

Move more view stuff out of WebContents. This moves context menus and info
bars. I removed the associated functions on TabContents, and have callers call
directly through to the view when the care about mucking with the info bar
(which is busted, IMO).

Review URL: http://codereview.chromium.org/7245
------------------------------------------------------------------------
r3340 | mal@chromium.org | 2008-10-14 04:39:09 +0200 (Tue, 14 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Revert r3334 to disable magic_browzR and see if that fixes the crashes in the 
reliability tests.

TBR= ben@chromium.org 
Review URL: http://codereview.chromium.org/7135
------------------------------------------------------------------------
r3334 | ben@chromium.org | 2008-10-14 02:06:35 +0200 (Tue, 14 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Turn on MagicBrowzr again.

Review URL: http://codereview.chromium.org/7280
------------------------------------------------------------------------
r3331 | ben@chromium.org | 2008-10-14 01:57:12 +0200 (Tue, 14 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/download_item_view.cc

Fix crash in saving pages.

http://crbug.com/3393
Review URL: http://codereview.chromium.org/7285
------------------------------------------------------------------------
r3324 | jcampan@chromium.org | 2008-10-14 00:42:47 +0200 (Tue, 14 Oct 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   A /trunk/src/chrome/browser/interstitial_page.cc
   A /trunk/src/chrome/browser/interstitial_page.h
   D /trunk/src/chrome/browser/interstitial_page_delegate.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/common/notification_types.h

This is the first pass at refactoring the interstitial page.
The SSL and malware blocking pages were doing similar things  in 2 different classes.
There is now a base class called InterstitialPage that contains the common logic.
As part of that refactoring, the safe browsing was changed so that the SafeBrowsingBlockingPage is only used from the UI thread.

This CL also adds transient entries to the navigation controller: that type of entry gets deleted as soon as a navigation occurs. It is used by interstitial that need to create such a temporary entry while they show.

BUG=3013
TEST=Run the unit tests and ui tests.



Review URL: http://codereview.chromium.org/6311
------------------------------------------------------------------------
r3323 | jam@chromium.org | 2008-10-14 00:28:39 +0200 (Tue, 14 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc

Make plugin processes (except Gears) run at normal priority.

This fixes a lot of the spurious unresponsive plugin dialogs, and also makes it so that the browser process isn't hung waiting for a low priority plugin process when cpu usage is high.

I was able to simulate this by using 100% cpu in a test program.  Before this change, the dialog always comes up and a flash video never plays.  The browser process is also hung.  With this change the video plays and I can interact with the browser.
Review URL: http://codereview.chromium.org/7129
------------------------------------------------------------------------
r3322 | jcampan@chromium.org | 2008-10-14 00:23:42 +0200 (Tue, 14 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   M /trunk/src/chrome/browser/security/resources/ssl_error.html
   M /trunk/src/chrome/browser/security/resources/ssl_roadblock.html

I forgot to make the background images not dnd-able on the blocking pages.

TEST=Visit https://ebay.com. On the blocking page, try dragging things around. You should not be able to.
BUG=3235


Review URL: http://codereview.chromium.org/7127
------------------------------------------------------------------------
r3318 | sgk@google.com | 2008-10-13 23:53:11 +0200 (Mon, 13 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript

Add new web_contents_view_win.cc to the SCons build.
Review URL: http://codereview.chromium.org/7269
------------------------------------------------------------------------
r3314 | paulg@google.com | 2008-10-13 23:03:51 +0200 (Mon, 13 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Minor code clean up.
Review URL: http://codereview.chromium.org/7271
------------------------------------------------------------------------
r3313 | erg@google.com | 2008-10-13 23:01:03 +0200 (Mon, 13 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc

Popups opened from popups should be constrained and subject to constrained popup limits.

This solves the UI issue, but there's still the backend stuff which I've filled as http://crbug.com/3382

BUG=2632
Review URL: http://codereview.chromium.org/7233
------------------------------------------------------------------------
r3307 | ben@chromium.org | 2008-10-13 21:56:42 +0200 (Mon, 13 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/views/custom_frame_window.cc

Use system title bar font for app windows, detached popups, constrained popups.

http://crbug.com/3376

Review URL: http://codereview.chromium.org/7274
------------------------------------------------------------------------
r3293 | ben@chromium.org | 2008-10-13 19:25:52 +0200 (Mon, 13 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h

Hook up throbber animation for vista detached popup windows and app windows.

http://crbug.com/3296

Review URL: http://codereview.chromium.org/7261
------------------------------------------------------------------------
r3292 | ben@chromium.org | 2008-10-13 19:25:36 +0200 (Mon, 13 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h

Assorted improvements to window maximization and flicker on Windows Vista with aero-glass disabled.

http://crbug.com/2488
Review URL: http://codereview.chromium.org/7262
------------------------------------------------------------------------
r3287 | finnur@google.com | 2008-10-13 16:48:53 +0200 (Mon, 13 Oct 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Tweaks for the text on the About box (from bug 3360):

1. "Google Chrome is made possible by the Google Chrome open source..." should read "Google Chrome is made possible by the Chromium open source..."

2. The second link in that sentence should be "<a>open source software</a>" Currently the word "software" isn't part of the link.

3. There shouldn't be a period at the end of "Google Chrome Terms of Service." Not a sentence.


Review URL: http://codereview.chromium.org/7112
------------------------------------------------------------------------
r3268 | klink@chromium.org | 2008-10-11 05:30:04 +0200 (Sat, 11 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc

Fixes a null pointer bug, and adds null checks around potentially dying process and channel.

Review URL: http://codereview.chromium.org/7099
------------------------------------------------------------------------
r3265 | ben@chromium.org | 2008-10-11 03:21:48 +0200 (Sat, 11 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc

Remove black line above detached poppup location bars

http://crbug.com/3332
Review URL: http://codereview.chromium.org/7098
------------------------------------------------------------------------
r3264 | ben@chromium.org | 2008-10-11 03:04:29 +0200 (Sat, 11 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h

Add incognito icon to vista frame windows that are incognito.

http://crbug.com/2471

Review URL: http://codereview.chromium.org/7250
------------------------------------------------------------------------
r3256 | ben@chromium.org | 2008-10-10 23:56:57 +0200 (Fri, 10 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h

Fix RTL issues with opaque frame. 

http://crbug.com/3247

Review URL: http://codereview.chromium.org/7240
------------------------------------------------------------------------
r3243 | brettw@google.com | 2008-10-10 22:34:35 +0200 (Fri, 10 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   A /trunk/src/chrome/browser/web_contents_view.h
   A /trunk/src/chrome/browser/web_contents_view_win.cc
   A /trunk/src/chrome/browser/web_contents_view_win.h

Start splitting out view-related stuff from WebContents into a new class WebContentsViewWin, accessed through an abstract interface WebContentsView.  This is incomplete but is a good start. There are still a bunch of pass-throughs required for the TabContents overrides. These won't be able to be cleaned up until we kill TabContents.
Review URL: http://codereview.chromium.org/7205
------------------------------------------------------------------------
r3239 | glen@google.com | 2008-10-10 22:16:55 +0200 (Fri, 10 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   A /trunk/src/chrome/app/resources/terms
   A /trunk/src/chrome/app/resources/terms/terms_ar.html
   A /trunk/src/chrome/app/resources/terms/terms_bg.html
   A /trunk/src/chrome/app/resources/terms/terms_ca.html
   A /trunk/src/chrome/app/resources/terms/terms_chromium.html
   A /trunk/src/chrome/app/resources/terms/terms_cs.html
   A /trunk/src/chrome/app/resources/terms/terms_da.html
   A /trunk/src/chrome/app/resources/terms/terms_de.html
   A /trunk/src/chrome/app/resources/terms/terms_el.html
   A /trunk/src/chrome/app/resources/terms/terms_en-GB.html
   A /trunk/src/chrome/app/resources/terms/terms_en.html
   A /trunk/src/chrome/app/resources/terms/terms_es-419.html
   A /trunk/src/chrome/app/resources/terms/terms_es.html
   A /trunk/src/chrome/app/resources/terms/terms_et.html
   A /trunk/src/chrome/app/resources/terms/terms_fi.html
   A /trunk/src/chrome/app/resources/terms/terms_fil.html
   A /trunk/src/chrome/app/resources/terms/terms_fr.html
   A /trunk/src/chrome/app/resources/terms/terms_he.html
   A /trunk/src/chrome/app/resources/terms/terms_hi.html
   A /trunk/src/chrome/app/resources/terms/terms_hr.html
   A /trunk/src/chrome/app/resources/terms/terms_hu.html
   A /trunk/src/chrome/app/resources/terms/terms_id.html
   A /trunk/src/chrome/app/resources/terms/terms_it.html
   A /trunk/src/chrome/app/resources/terms/terms_ja.html
   A /trunk/src/chrome/app/resources/terms/terms_ko.html
   A /trunk/src/chrome/app/resources/terms/terms_lt.html
   A /trunk/src/chrome/app/resources/terms/terms_lv.html
   A /trunk/src/chrome/app/resources/terms/terms_nb.html
   A /trunk/src/chrome/app/resources/terms/terms_nl.html
   A /trunk/src/chrome/app/resources/terms/terms_pl.html
   A /trunk/src/chrome/app/resources/terms/terms_pt-BR.html
   A /trunk/src/chrome/app/resources/terms/terms_pt-PT.html
   A /trunk/src/chrome/app/resources/terms/terms_ro.html
   A /trunk/src/chrome/app/resources/terms/terms_ru.html
   A /trunk/src/chrome/app/resources/terms/terms_sk.html
   A /trunk/src/chrome/app/resources/terms/terms_sl.html
   A /trunk/src/chrome/app/resources/terms/terms_sr.html
   A /trunk/src/chrome/app/resources/terms/terms_sv.html
   A /trunk/src/chrome/app/resources/terms/terms_th.html
   A /trunk/src/chrome/app/resources/terms/terms_tr.html
   A /trunk/src/chrome/app/resources/terms/terms_uk.html
   A /trunk/src/chrome/app/resources/terms/terms_vi.html
   A /trunk/src/chrome/app/resources/terms/terms_zh-CN.html
   A /trunk/src/chrome/app/resources/terms/terms_zh-TW.html
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_resources.h
   M /trunk/src/chrome/browser/browser_resources.rc
   A /trunk/src/chrome/browser/resources/about_credits.html
   M /trunk/src/chrome/browser/resources/browser_resources.vcproj
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/resource_bundle.cc

Add about:terms to Chrome, and about:licenses to Chromium and Chrome.
Review URL: http://codereview.chromium.org/6804
------------------------------------------------------------------------
r3228 | jcampan@chromium.org | 2008-10-10 20:50:32 +0200 (Fri, 10 Oct 2008) | 11 lines
Changed paths:
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/theme/download_button_right_bottom_no_dd.png
   A /trunk/src/chrome/app/theme/download_button_right_middle_no_dd.png
   A /trunk/src/chrome/app/theme/download_button_right_top_no_dd.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.h
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/native_button.h

This CL adds prompting for dangerous types of files (executable) when they are automatically downloaded.

The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download.
If discarded the download is removed (and its file deleted).
If saved, download goes as usual.
Dangerous downloads not confirmed by the user are deleted on shutdown.

TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded).


Review URL: http://codereview.chromium.org/6043
------------------------------------------------------------------------
r3222 | finnur@google.com | 2008-10-10 19:48:15 +0200 (Fri, 10 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Terms of Service don't apply to Chromium. Remove the link from the About box.

Review URL: http://codereview.chromium.org/7231
------------------------------------------------------------------------
r3205 | tc@google.com | 2008-10-10 09:56:30 +0200 (Fri, 10 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/third_party/libxslt/SConscript

fix linux build
By fixing other places where we tried to include libxml/scons but it is now libxml/DerivedSources.

TBR=sgk

Review URL: http://codereview.chromium.org/7071

------------------------------------------------------------------------
r3178 | finnur@google.com | 2008-10-10 05:36:33 +0200 (Fri, 10 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Forgot a .h file. 

TBR=tc

Review URL: http://codereview.chromium.org/7208
------------------------------------------------------------------------
r3176 | finnur@google.com | 2008-10-10 05:28:53 +0200 (Fri, 10 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Allow the translators to chose which link appears first in the About box.

Review URL: http://codereview.chromium.org/7035
------------------------------------------------------------------------
r3168 | ben@chromium.org | 2008-10-10 03:26:14 +0200 (Fri, 10 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h

Make loading animations on app windows not call WM_SETICON on every frame. Ow.

Review URL: http://codereview.chromium.org/7204
------------------------------------------------------------------------
r3165 | paulg@google.com | 2008-10-10 02:53:21 +0200 (Fri, 10 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Fix a couple of UMRs in the unit tests.
Review URL: http://codereview.chromium.org/7047
------------------------------------------------------------------------
r3155 | cpu@google.com | 2008-10-10 01:32:23 +0200 (Fri, 10 Oct 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/sandbox_policy.cc

Add a bunch of dlls to our dll eviction blacklist

Using the data collected by Marc-Antoine from 3800 dumps, I have selected the dlls that we
want to vote out of the island. This should reduce the number of crashes we suffer because
these dlls interact badly with the sandbox.
 - This change only afects renderers
 - We won't block it if the dll is not first found loaded in the browser process
 - Testing this is going to be challenging.

Review URL: http://codereview.chromium.org/6376
------------------------------------------------------------------------
r3152 | ben@chromium.org | 2008-10-10 01:20:40 +0200 (Fri, 10 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Fix regression with app window titles.

Review URL: http://codereview.chromium.org/7039
------------------------------------------------------------------------
r3148 | paulg@google.com | 2008-10-10 01:05:27 +0200 (Fri, 10 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc

Provide an option to turn on the new SafeBrowsing storage system
via a command line flag ("--new-safe-browsing").

This is to ease testing and is not yet ready for production use.

Review URL: http://codereview.chromium.org/6390
------------------------------------------------------------------------
r3144 | ben@chromium.org | 2008-10-10 00:30:54 +0200 (Fri, 10 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Account for the distributor logo when sizing the title text bounds.

http://crbug.com/2711
Review URL: http://codereview.chromium.org/6387
------------------------------------------------------------------------
r3137 | ojan@google.com | 2008-10-09 23:58:05 +0200 (Thu, 09 Oct 2008) | 12 lines
Changed paths:
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/build/base_gfx.vcproj
   D /trunk/src/base/gfx/bitmap_header.cc
   D /trunk/src/base/gfx/bitmap_header.h
   M /trunk/src/base/gfx/bitmap_platform_device_win.cc
   A /trunk/src/base/gfx/gdi_util.cc (from /trunk/src/base/gfx/bitmap_header.cc:3038)
   A /trunk/src/base/gfx/gdi_util.h (from /trunk/src/base/gfx/bitmap_header.h:3038)
   M /trunk/src/base/gfx/native_theme.cc
   M /trunk/src/base/gfx/vector_canvas_unittest.cc
   M /trunk/src/base/gfx/vector_device.cc
   M /trunk/src/base/tuple.h
   M /trunk/src/base/tuple_unittest.cc
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/webkit/build/glue/glue.vcproj
   A /trunk/src/webkit/data/layout_tests/pending/plugins/iframe-shims-expected.txt
   A /trunk/src/webkit/data/layout_tests/pending/plugins/iframe-shims.html
   A /trunk/src/webkit/data/layout_tests/pending/plugins/simple_blank.swf
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   A /trunk/src/webkit/glue/stacking_order_iterator.cc
   A /trunk/src/webkit/glue/stacking_order_iterator.h
   M /trunk/src/webkit/glue/webcursor.cc
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/SkiaUtils.cpp
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc

Patch by Thatcher Ulrich <tulrich@google.com>.

Implement "iframe shim" behavior for windowed plugins.

In FF and IE on windows, iframes are implemented as native HWNDs.  
This has the side effect that iframes display on top of windowed 
plugins. This side effect has long been known as a workaround for
allowing HTML elements to appear above plugin content.

BUG=1788

Review URL: http://codereview.chromium.org/7032
------------------------------------------------------------------------
r3131 | paulg@google.com | 2008-10-09 23:31:57 +0200 (Thu, 09 Oct 2008) | 23 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Support zero size chunks in the current implementation.

This allows the SafeBrowsing servers to send us Add and Sub
chunks with no content so that when we report our update
status, the request size is decreased.

Our update status request contains a list of all chunks that
we have received from the service, and this can get fragmented
over time. For example, the part of the request containing our
phishing chunks might look like this:

  goog-phish-shavar:a:1,3,5,7,9,11,13,15,17

By sending zero size chunks for the chunk numbers missing from
the above example, the report will now look like:

  goog-phish-shavar:a:1-17

Given the large number of chunks and the rate of chunk expiry,
this change will reduce the client request size.

BUG= http://code.google.com/p/chromium/issues/detail?id=3262
Review URL: http://codereview.chromium.org/6369
------------------------------------------------------------------------
r3127 | sky@google.com | 2008-10-09 22:56:59 +0200 (Thu, 09 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/base/lock.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h

Changes BookmarkModel to not grab the same lock twice.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6391
------------------------------------------------------------------------
r3117 | finnur@google.com | 2008-10-09 21:40:53 +0200 (Thu, 09 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/google_chrome_strings.grd
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Changing the About box according to mockups. Basically, we now want to have a paragraph of text with embedded links (to the Chromium project, credits and terms of service).
Review URL: http://codereview.chromium.org/6563
------------------------------------------------------------------------
r3113 | pkasting@chromium.org | 2008-10-09 20:21:27 +0200 (Thu, 09 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/common/notification_types.h

Move |result_| and |latest_result_| to the autocomplete controller.

This purposefully does not change the communication interface between the edit and the popup; that's coming in a subsequent pass.  As a result, right now the popup isn't really much simpler.  That should eventually change.
Review URL: http://codereview.chromium.org/6596
------------------------------------------------------------------------
r3112 | jcampan@chromium.org | 2008-10-09 20:18:47 +0200 (Thu, 09 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Makes sure the network usage is also reported for non tabs (right now only the browser process).

BUG=1282443
TEST=Open the task manager, type in something in the location bar.  The network usage for the browser process should show some activity.
Review URL: http://codereview.chromium.org/7019
------------------------------------------------------------------------
r3108 | jcampan@chromium.org | 2008-10-09 19:55:38 +0200 (Thu, 09 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h

This CL makes the task manager columns sortable.
It ensures the CPU usage is only computed once per periodic update.
Also it now posts tasks instead of using a timer, as timers can fire erraticly if the thread is really busy.

BUG=95
TEST=Open the task manager. Click on the columns to sort.
Review URL: http://codereview.chromium.org/7016
------------------------------------------------------------------------
r3099 | jcampan@chromium.org | 2008-10-09 18:20:58 +0200 (Thu, 09 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

One more link that needs drag and drop disabled in the malware blocking page.

BUG=3235
Review URL: http://codereview.chromium.org/6360
------------------------------------------------------------------------
r3091 | sgjesse@chromium.org | 2008-10-09 09:37:36 +0200 (Thu, 09 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/resources/debugger_shell.js
   M /trunk/src/chrome/test/debugger/test_protocol.js

Initialize string to the empty string to avoid 'undefinedXXX' when appending XXX.

Format frame numbers with two digits when presenting the output from teh f command.

BUG=1304224
Review URL: http://codereview.chromium.org/6079
------------------------------------------------------------------------
r3087 | ben@chromium.org | 2008-10-09 03:33:53 +0200 (Thu, 09 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Roll back changes to the client area size calculation, since this fix didn't work.

------------------------------------------------------------------------
r3084 | cpu@google.com | 2008-10-09 03:01:03 +0200 (Thu, 09 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

New default brandcode.

BUG=1397407

Review URL: http://codereview.chromium.org/6597
------------------------------------------------------------------------
r3078 | klink@chromium.org | 2008-10-09 02:03:18 +0200 (Thu, 09 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_accessibility.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.cc
   M /trunk/src/chrome/browser/browser_accessibility_manager.h
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc

Fixes crash in BrowserAccessibilityManager destructor (see CPBrowsingContextManager for example of this type of fix). 

Also fixes small style issue, to be consistent with other Singleton implementations.

Review URL: http://codereview.chromium.org/6282
------------------------------------------------------------------------
r3076 | ben@chromium.org | 2008-10-09 01:46:58 +0200 (Thu, 09 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   D /trunk/src/chrome/browser/views/window_resources.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/views.vcproj
   A /trunk/src/chrome/views/window_resources.h (from /trunk/src/chrome/browser/views/window_resources.h:3070)

Move window_resources.h to chrome/views to remove bad dependency of chrome/views on chrome/browser

http://crbug.com/2395

Review URL: http://codereview.chromium.org/7002
------------------------------------------------------------------------
r3072 | ben@chromium.org | 2008-10-09 01:07:19 +0200 (Thu, 09 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc

Constrained window title text colors are inverted.

http://crbug.com/3249
Review URL: http://codereview.chromium.org/6367
------------------------------------------------------------------------
r3071 | ben@chromium.org | 2008-10-09 01:07:12 +0200 (Thu, 09 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Always position and size the toolbar view, since it's used to position other elements.

Regression from changelist earlier today.

Review URL: http://codereview.chromium.org/6365
------------------------------------------------------------------------
r3061 | pkasting@chromium.org | 2008-10-08 23:55:42 +0200 (Wed, 08 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h

This file was supposed to get committed during my last refactoring chunk but got left out by mistake.
Review URL: http://codereview.chromium.org/5659
------------------------------------------------------------------------
r3056 | kuchhal@chromium.org | 2008-10-08 23:29:05 +0200 (Wed, 08 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/install_util.h

Reuse a method that will be required for criteria checker as well.

Review URL: http://codereview.chromium.org/6587
------------------------------------------------------------------------
r3052 | sky@google.com | 2008-10-08 23:12:05 +0200 (Wed, 08 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc

Fixes leak in new test.

BUG=none
TBR=pkasting

Review URL: http://codereview.chromium.org/6362
------------------------------------------------------------------------
r3038 | ben@chromium.org | 2008-10-08 21:58:34 +0200 (Wed, 08 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc

Make it so that you can resize glass windows from the bottom.

http://crbug.com/2483

Review URL: http://codereview.chromium.org/6593
------------------------------------------------------------------------
r3037 | jcampan@chromium.org | 2008-10-08 21:57:52 +0200 (Wed, 08 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   M /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   D /trunk/src/chrome/browser/resources/ssl_error.html
   M /trunk/src/chrome/browser/security/resources/ssl_error.html
   M /trunk/src/chrome/browser/security/resources/ssl_roadblock.html

Disabled the drag and drop of images and links in the blocking pages to prevent bad navigations.
Removed an unused file as well.

BUG=3235
TEST=Trigger a blocking page (ex: https://ebay.com). Try dragging the warning image and link around. This should not do anything.
Review URL: http://codereview.chromium.org/6590
------------------------------------------------------------------------
r3036 | sky@google.com | 2008-10-08 21:54:52 +0200 (Wed, 08 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc

External contribution from developer0420@gmail.com. Pressing enter in
the bookmark bubble when focus is on the edit button should start editing.

BUG=2863
TEST=Bring up the bookmark bubble, move focus to the edit button and press
  enter. Make sure the editor comes up.

Review URL: http://codereview.chromium.org/6594
------------------------------------------------------------------------
r3034 | ben@chromium.org | 2008-10-08 21:45:10 +0200 (Wed, 08 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Attempt to fix more standard non-client painting by extending the client area of the frame to the top of the window.

http://crbug.com/3246

Review URL: http://codereview.chromium.org/6349
------------------------------------------------------------------------
r3033 | erg@google.com | 2008-10-08 21:38:25 +0200 (Wed, 08 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc

Fix problem with popups frames when magic_browzr.
Some code got committed which made assumptions which
were only true when magic_browzr was on.

Review URL: http://codereview.chromium.org/5649
------------------------------------------------------------------------
r3032 | mpcomplete@google.com | 2008-10-08 21:35:21 +0200 (Wed, 08 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/renderer/render_process.cc

Hackish changes to make gears work in the renderer with the sandbox.
Review URL: http://codereview.chromium.org/6434
------------------------------------------------------------------------
r3031 | paulg@google.com | 2008-10-08 21:34:13 +0200 (Wed, 08 Oct 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Fixes to the experimental bloom filter storage code.
Update the unittest to handle the bloom filter storage
implementation and fix a test scenario.

This change does not affect the current working implementation.

Review URL: http://codereview.chromium.org/6513
------------------------------------------------------------------------
r3022 | wtc@google.com | 2008-10-08 20:25:50 +0200 (Wed, 08 Oct 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/net/base/ssl_client_socket.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Use the new HTTP stack by default in the net module's
tests, but continue to use WinHTTP by default in the
test shell and chrome.

The mapping of CRYPT_E_NO_REVOCATION_CHECK to
ERR_CERT_NO_REVOCATION_MECHANISM (a certificate error
code) is necessary to make the HTTPSTestServer's start
and shutdown GET commands work.  (The TestDelegate
ignores all certificate errors.)

R=darin
Review URL: http://codereview.chromium.org/6472
------------------------------------------------------------------------
r3018 | cpu@google.com | 2008-10-08 20:04:53 +0200 (Wed, 08 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc

klockwork bug: variable delared in nested scope

BUG=3084

Review URL: http://codereview.chromium.org/6227
------------------------------------------------------------------------
r3013 | maruel@google.com | 2008-10-08 19:01:47 +0200 (Wed, 08 Oct 2008) | 12 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Adds an --incognito switch that can be used to launch Chrome in Incognito mode.
You can combine this with --app= to launch an app in Chrome that has no effect
on the user's profile.

Note that this is not the same thing as launching chrome.exe
--user-data-dir=/dev/null, which would give you an completely empty profile
instead of loading the user's profile as read-only.

BUG=1790,2012

Patch by Yarin Kaul <yarin.kaul@gmail.com>
Review URL: http://codereview.chromium.org/6584
------------------------------------------------------------------------
r3012 | jcampan@chromium.org | 2008-10-08 18:44:19 +0200 (Wed, 08 Oct 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Clicking the diagnostic link on the malware page would triggers a DCHECK.
The diagnostic URL was not formatted properly and we would load an empty URL.

BUG=2957
TEST=Navigate to www.ianfette.us, the malware interstitial shows. Click the diagnostic link, you should see the diagnostic google page.
Review URL: http://codereview.chromium.org/6081
------------------------------------------------------------------------
r3010 | sky@google.com | 2008-10-08 17:44:52 +0200 (Wed, 08 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h

Enables sorting of the tables in the password editor and the URL
picker dialog.

BUG=2949
TEST=Try sorting in the password manager dialog table as well as when
  adding a URL to the list of URLs to open on startup.

Review URL: http://codereview.chromium.org/6053
------------------------------------------------------------------------
r3008 | sky@google.com | 2008-10-08 17:22:34 +0200 (Wed, 08 Oct 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model.h
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   A /trunk/src/chrome/browser/template_url_prepopulate_data_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Fixes crasher in TemplateURLModel that occurred when the db had
multiple keywords with the same prepopulate id. We had this for
Hungary.

BUG=3192
TEST=make sure you don't see any problems with keywords.

Review URL: http://codereview.chromium.org/6284
------------------------------------------------------------------------
r2994 | beng@google.com | 2008-10-08 06:18:37 +0200 (Wed, 08 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc

Ctrl+W should close app windows too

http://crbug.com/2478
------------------------------------------------------------------------
r2991 | beng@google.com | 2008-10-08 06:04:46 +0200 (Wed, 08 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc

Fix crash due to lack of NULL checking in one case.

http://crbug.com/3183
------------------------------------------------------------------------
r2990 | paulg@google.com | 2008-10-08 04:14:08 +0200 (Wed, 08 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.h
   M /trunk/src/chrome/browser/safe_browsing/chunk_range_unittest.cc

Make chunk ranges searchable.
Review URL: http://codereview.chromium.org/5645
------------------------------------------------------------------------
r2879 | ben@chromium.org | 2008-10-06 17:38:30 +0200 (Mon, 06 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Reduce the amount of excessive updating done when there is no window icon to be
updated.

Improves sunspider results.

------------------------------------------------------------------------
r2874 | deanm@chromium.org | 2008-10-06 12:07:26 +0200 (Mon, 06 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/net/base/listen_socket_unittest.h

Move all callers to EnsureWinsockInit, and away from using WinsockInit instances.
Review URL: http://codereview.chromium.org/6486
------------------------------------------------------------------------
r2814 | erikkay@google.com | 2008-10-03 00:13:41 +0200 (Fri, 03 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.cc (from /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc:2440)
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_bloom.h (from /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h:2440)
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

A partially working implementation of a faster safe browsing implementation.

Review URL: http://codereview.chromium.org/5643
------------------------------------------------------------------------
r2793 | deanm@google.com | 2008-10-02 17:11:22 +0200 (Thu, 02 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_file.h
   M /trunk/src/chrome/browser/download/save_types.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_types_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/snippet.h
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/history/visit_tracker.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/template_url.cc
   M /trunk/src/chrome/browser/template_url.h
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/mru_cache.h

Port some more of chrome/ to Linux.

Original review: http://codereview.chromium.org/4247

Patch from Pawel Hajdan Jr.
------------------------------------------------------------------------
r2790 | deanm@chromium.org | 2008-10-02 14:49:59 +0200 (Thu, 02 Oct 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

- Add a note about a subtle requirement of the current code (bug 2994).
- Don't statically construct the cookie icon, removing a static constructor.
- Properly enable and disable the cookie text fields.  Patch from Arthur Lussos.
Review URL: http://codereview.chromium.org/6077
------------------------------------------------------------------------
r2778 | tc@google.com | 2008-10-02 00:31:35 +0200 (Thu, 02 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src
   M /trunk/src/DEPS
   M /trunk/src/base/atomicops_unittest.cc
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/condition_variable_unittest.cc
   M /trunk/src/base/condition_variable_win.cc
   R /trunk/src/base/cpu.cc (from /branches/chrome_webkit_merge_branch/base/cpu.cc:2775)
   R /trunk/src/base/cpu.h (from /branches/chrome_webkit_merge_branch/base/cpu.h:2775)
   M /trunk/src/base/debug_util_win.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/gfx/bitmap_platform_device_linux.cc
   M /trunk/src/base/gfx/bitmap_platform_device_linux.h
   M /trunk/src/base/gfx/bitmap_platform_device_win.cc
   M /trunk/src/base/gfx/bitmap_platform_device_win.h
   M /trunk/src/base/gfx/platform_canvas_linux.cc
   M /trunk/src/base/gfx/platform_canvas_linux.h
   M /trunk/src/base/gfx/platform_canvas_unittest.cc
   M /trunk/src/base/gfx/platform_canvas_win.cc
   M /trunk/src/base/gfx/platform_canvas_win.h
   M /trunk/src/base/gfx/platform_device_linux.cc
   M /trunk/src/base/gfx/platform_device_linux.h
   M /trunk/src/base/gfx/platform_device_win.cc
   M /trunk/src/base/gfx/platform_device_win.h
   M /trunk/src/base/histogram_unittest.cc
   M /trunk/src/base/hmac_nss.cc
   M /trunk/src/base/lock_impl_posix.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/message_pump_libevent.h
   R /trunk/src/base/message_pump_mac.h (from /branches/chrome_webkit_merge_branch/base/message_pump_mac.h:2775)
   R /trunk/src/base/message_pump_mac.mm (from /branches/chrome_webkit_merge_branch/base/message_pump_mac.mm:2775)
   M /trunk/src/base/nss_init.cc
   M /trunk/src/base/nss_init.h
   M /trunk/src/base/pr_time_unittest.cc
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/process_util_win.cc
   R /trunk/src/base/scoped_nsautorelease_pool.h (from /branches/chrome_webkit_merge_branch/base/scoped_nsautorelease_pool.h:2775)
   R /trunk/src/base/scoped_nsautorelease_pool.mm (from /branches/chrome_webkit_merge_branch/base/scoped_nsautorelease_pool.mm:2775)
   M /trunk/src/base/shared_memory_win.cc
   M /trunk/src/base/simple_thread.cc
   M /trunk/src/base/simple_thread.h
   M /trunk/src/base/simple_thread_unittest.cc
   M /trunk/src/base/string_util_posix.h
   M /trunk/src/base/sys_info_unittest.cc
   R /trunk/src/base/system_monitor.cc (from /branches/chrome_webkit_merge_branch/base/system_monitor.cc:2775)
   R /trunk/src/base/system_monitor.h (from /branches/chrome_webkit_merge_branch/base/system_monitor.h:2775)
   R /trunk/src/base/system_monitor_unittest.cc (from /branches/chrome_webkit_merge_branch/base/system_monitor_unittest.cc:2775)
   R /trunk/src/base/system_monitor_win.cc (from /branches/chrome_webkit_merge_branch/base/system_monitor_win.cc:2775)
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/time_unittest_win.cc
   M /trunk/src/base/tracked_objects_unittest.cc
   M /trunk/src/base/watchdog_unittest.cc
   M /trunk/src/build/internal/essential.vsprops
   M /trunk/src/chrome/app/chrome.dll.deps
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/theme/chromium/BRANDING
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/download/download_exe.cc
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/download/download_item_model.cc
   M /trunk/src/chrome/browser/download/download_item_model.h
   M /trunk/src/chrome/browser/download/download_manager.cc
   M /trunk/src/chrome/browser/download/download_manager.h
   M /trunk/src/chrome/browser/download/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download/download_uitest.cc
   M /trunk/src/chrome/browser/download/download_util.cc
   M /trunk/src/chrome/browser/download/download_util.h
   M /trunk/src/chrome/browser/download/save_file.cc
   M /trunk/src/chrome/browser/download/save_file.h
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_file_manager.h
   M /trunk/src/chrome/browser/download/save_item.cc
   M /trunk/src/chrome/browser/download/save_item.h
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/download/save_package_unittest.cc
   M /trunk/src/chrome/browser/download/save_page_model.cc
   M /trunk/src/chrome/browser/download/save_page_model.h
   M /trunk/src/chrome/browser/download/save_page_uitest.cc
   M /trunk/src/chrome/browser/download/save_types.h
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.cc
   M /trunk/src/chrome/browser/importer/firefox2_importer.h
   M /trunk/src/chrome/browser/importer/firefox3_importer.cc
   M /trunk/src/chrome/browser/importer/firefox3_importer.h
   M /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.h
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/importer/firefox_profile_lock.h
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.h
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/importer/importer.h
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/importer/mork_reader.cc
   M /trunk/src/chrome/browser/importer/mork_reader.h
   R /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc (from /branches/chrome_webkit_merge_branch/chrome/browser/net/sdch_dictionary_fetcher.cc:2775)
   R /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h (from /branches/chrome_webkit_merge_branch/chrome/browser/net/sdch_dictionary_fetcher.h:2775)
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc
   M /trunk/src/chrome/browser/session_id.h
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.h
   M /trunk/src/chrome/browser/views/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/views/external_protocol_dialog.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/old_frames/frame_view.cc
   M /trunk/src/chrome/browser/views/old_frames/frame_view.h
   M /trunk/src/chrome/browser/views/old_frames/point_buffer.cc
   M /trunk/src/chrome/browser/views/old_frames/point_buffer.h
   M /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.h
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.h
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/browser/views/standard_layout.h
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/user_data_dir_dialog.h
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/resource_bundle.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.h
   M /trunk/src/chrome/renderer/render_view.cc
   R /trunk/src/chrome/renderer/render_widget_unittest.cc (from /branches/chrome_webkit_merge_branch/chrome/renderer/render_widget_unittest.cc:2775)
   M /trunk/src/chrome/renderer/renderer_glue.cc
   R /trunk/src/chrome/test/data/ssl/frame_left.html (from /branches/chrome_webkit_merge_branch/chrome/test/data/ssl/frame_left.html:2775)
   R /trunk/src/chrome/test/data/ssl/frame_right.html (from /branches/chrome_webkit_merge_branch/chrome/test/data/ssl/frame_right.html:2775)
   R /trunk/src/chrome/test/data/ssl/top_frame.html (from /branches/chrome_webkit_merge_branch/chrome/test/data/ssl/top_frame.html:2775)
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_client_view.h
   R /trunk/src/chrome/views/table_view_unittest.cc (from /branches/chrome_webkit_merge_branch/chrome/views/table_view_unittest.cc:2775)
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/gears/SConscript
   R /trunk/src/gears/SConscript.dll (from /branches/chrome_webkit_merge_branch/gears/SConscript.dll:2775)
   R /trunk/src/gears/SConscript.googleurl (from /branches/chrome_webkit_merge_branch/gears/SConscript.googleurl:2775)
   M /trunk/src/gears/SConscript.libgd
   M /trunk/src/gears/SConscript.libjpeg
   M /trunk/src/gears/SConscript.libpng
   M /trunk/src/gears/SConscript.portaudio
   M /trunk/src/gears/SConscript.sqlite
   M /trunk/src/gears/SConscript.zlib
   M /trunk/src/gears/SConstruct
   M /trunk/src/net/base/client_socket_handle.cc
   M /trunk/src/net/base/client_socket_handle.h
   M /trunk/src/net/base/client_socket_pool.cc
   M /trunk/src/net/base/client_socket_pool.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/base/platform_mime_util_linux.cc
   M /trunk/src/net/base/run_all_unittests.cc
   R /trunk/src/net/base/scoped_host_mapper.h (from /branches/chrome_webkit_merge_branch/net/base/scoped_host_mapper.h:2775)
   R /trunk/src/net/base/sdch_filter.cc (from /branches/chrome_webkit_merge_branch/net/base/sdch_filter.cc:2775)
   R /trunk/src/net/base/sdch_filter.h (from /branches/chrome_webkit_merge_branch/net/base/sdch_filter.h:2775)
   R /trunk/src/net/base/sdch_filter_unitest.cc (from /branches/chrome_webkit_merge_branch/net/base/sdch_filter_unitest.cc:2775)
   R /trunk/src/net/base/sdch_manager.cc (from /branches/chrome_webkit_merge_branch/net/base/sdch_manager.cc:2775)
   R /trunk/src/net/base/sdch_manager.h (from /branches/chrome_webkit_merge_branch/net/base/sdch_manager.h:2775)
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/test_completion_callback_unittest.cc
   R /trunk/src/net/base/x509_certificate.cc (from /branches/chrome_webkit_merge_branch/net/base/x509_certificate.cc:2775)
   M /trunk/src/net/disk_cache/file_win.cc
   M /trunk/src/net/disk_cache/mapped_file_win.cc
   R /trunk/src/net/disk_cache/stats_histogram.cc (from /branches/chrome_webkit_merge_branch/net/disk_cache/stats_histogram.cc:2775)
   R /trunk/src/net/disk_cache/stats_histogram.h (from /branches/chrome_webkit_merge_branch/net/disk_cache/stats_histogram.h:2775)
   R /trunk/src/net/http/http_auth.cc (from /branches/chrome_webkit_merge_branch/net/http/http_auth.cc:2775)
   R /trunk/src/net/http/http_auth.h (from /branches/chrome_webkit_merge_branch/net/http/http_auth.h:2775)
   R /trunk/src/net/http/http_auth_handler.cc (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler.cc:2775)
   R /trunk/src/net/http/http_auth_handler.h (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler.h:2775)
   R /trunk/src/net/http/http_auth_handler_basic.cc (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler_basic.cc:2775)
   R /trunk/src/net/http/http_auth_handler_basic.h (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler_basic.h:2775)
   R /trunk/src/net/http/http_auth_handler_basic_unittest.cc (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler_basic_unittest.cc:2775)
   R /trunk/src/net/http/http_auth_handler_digest.cc (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler_digest.cc:2775)
   R /trunk/src/net/http/http_auth_handler_digest.h (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler_digest.h:2775)
   R /trunk/src/net/http/http_auth_handler_digest_unittest.cc (from /branches/chrome_webkit_merge_branch/net/http/http_auth_handler_digest_unittest.cc:2775)
   R /trunk/src/net/http/http_auth_unittest.cc (from /branches/chrome_webkit_merge_branch/net/http/http_auth_unittest.cc:2775)
   M /trunk/src/net/proxy/proxy_resolver_fixed.cc
   M /trunk/src/net/proxy/proxy_resolver_fixed.h
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/sandbox/SConstruct
   M /trunk/src/sandbox/src/unload_dll_test.cc
   M /trunk/src/sandbox/tests/integration_tests/sbox_integration_tests.vcproj
   M /trunk/src/sandbox/tests/unit_tests/sbox_unittests.vcproj
   M /trunk/src/sandbox/tests/validation_tests/sbox_validation_tests.vcproj
   R /trunk/src/sdch/SConscript (from /branches/chrome_webkit_merge_branch/sdch/SConscript:2775)
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/AUTHORS
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/COPYING
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/ChangeLog
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/INSTALL
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/Makefile.am
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/THANKS
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/aclocal.m4
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/config.guess
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/config.sub
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/configure
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/configure.ac
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/m4/ac_have_attribute.m4
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/m4/acx_pthread.m4
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/missing
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/changelog
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/compat
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/control
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/copyright
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/docs
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/rpm/rpm.spec
   R /trunk/src/sdch/sdch.xcodeproj (from /branches/chrome_webkit_merge_branch/sdch/sdch.xcodeproj:2775)
   R /trunk/src/sdch/sdch.xcodeproj/project.pbxproj (from /branches/chrome_webkit_merge_branch/sdch/sdch.xcodeproj/project.pbxproj:2775)
   R /trunk/src/sdch/sdch.xcodeproj/sdch_prebuild.sh (from /branches/chrome_webkit_merge_branch/sdch/sdch.xcodeproj/sdch_prebuild.sh:2775)
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/third_party/libevent/SConscript
   M /trunk/src/third_party/libevent/compat/sys/_time.h
   M /trunk/src/third_party/libevent/compat/sys/queue.h
   M /trunk/src/third_party/libevent/evdns.h
   M /trunk/src/third_party/libevent/event-config.h
   M /trunk/src/third_party/libevent/event-internal.h
   M /trunk/src/third_party/libevent/event.h
   M /trunk/src/third_party/libevent/event_rpcgen.py
   M /trunk/src/third_party/libevent/evhttp.h
   M /trunk/src/third_party/libevent/evrpc-internal.h
   M /trunk/src/third_party/libevent/evrpc.h
   M /trunk/src/third_party/libevent/evsignal.h
   M /trunk/src/third_party/libevent/evutil.h
   M /trunk/src/third_party/libevent/http-internal.h
   M /trunk/src/third_party/libevent/linux/config.h
   M /trunk/src/third_party/libevent/log.h
   M /trunk/src/third_party/libevent/min_heap.h
   M /trunk/src/third_party/libevent/strlcpy-internal.h
   M /trunk/src/third_party/libevent/test/regress.gen.h
   M /trunk/src/third_party/libevent/test/regress.h
   M /trunk/src/third_party/libxml/libxml.xcodeproj
   M /trunk/src/third_party/libxml/linux/config.h
   M /trunk/src/third_party/libxml/linux/include/libxml/xmlversion.h
   M /trunk/src/third_party/libxslt/linux/config.h
   M /trunk/src/third_party/libxslt/linux/libexslt/exsltconfig.h
   M /trunk/src/third_party/libxslt/linux/libxslt/xsltconfig.h
   M /trunk/src/third_party/libxslt/linux/libxslt/xsltwin32config.h
   M /trunk/src/third_party/scons/scons-LICENSE
   M /trunk/src/third_party/scons/scons-local/SCons
   M /trunk/src/third_party/scons/scons-local/SCons/Action.py
   M /trunk/src/third_party/scons/scons-local/SCons/Builder.py
   M /trunk/src/third_party/scons/scons-local/SCons/CacheDir.py
   M /trunk/src/third_party/scons/scons-local/SCons/Conftest.py
   M /trunk/src/third_party/scons/scons-local/SCons/Debug.py
   M /trunk/src/third_party/scons/scons-local/SCons/Defaults.py
   M /trunk/src/third_party/scons/scons-local/SCons/Environment.py
   M /trunk/src/third_party/scons/scons-local/SCons/Errors.py
   M /trunk/src/third_party/scons/scons-local/SCons/Executor.py
   M /trunk/src/third_party/scons/scons-local/SCons/Job.py
   M /trunk/src/third_party/scons/scons-local/SCons/Memoize.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node
   M /trunk/src/third_party/scons/scons-local/SCons/Node/Alias.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node/FS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node/Python.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options
   M /trunk/src/third_party/scons/scons-local/SCons/Options/BoolOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/EnumOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/ListOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/PackageOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/PathOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/PathList.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/aix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/cygwin.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/darwin.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/hpux.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/irix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/os2.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/posix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/sunos.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/win32.py
   M /trunk/src/third_party/scons/scons-local/SCons/SConf.py
   M /trunk/src/third_party/scons/scons-local/SCons/SConsign.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/C.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/D.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/Dir.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/Fortran.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/IDL.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/LaTeX.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/Prog.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script
   M /trunk/src/third_party/scons/scons-local/SCons/Script/Interactive.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/Main.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/SConsOptions.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/SConscript.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Sig.py
   M /trunk/src/third_party/scons/scons-local/SCons/Subst.py
   M /trunk/src/third_party/scons/scons-local/SCons/Taskmaster.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/386asm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/BitKeeper.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/CVS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/FortranCommon.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/JavaCommon.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/Perforce.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/PharLapCommon.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/RCS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/SCCS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/Subversion.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixc++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixf77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixlink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/applelink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/as.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/bcc32.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/c++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/cc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/cvf.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/default.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dmd.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dvi.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dvipdf.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dvips.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/f77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/f90.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/f95.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/filesystem.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/fortran.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/g++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/g77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gas.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gfortran.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gnulink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gs.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/hpc++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/hpcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/hplink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/icc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/icl.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ifl.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ifort.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ilink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ilink32.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/install.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/intelc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/jar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/javac.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/javah.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/latex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/lex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/link.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/linkloc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/m4.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/masm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/midl.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mingw.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mslib.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mslink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/msvc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/msvs.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mwcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mwld.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/nasm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/ipk.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/msi.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/rpm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/src_tarbz2.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/src_targz.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/src_zip.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/tarbz2.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/targz.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/zip.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/pdf.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/pdflatex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/pdftex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/qt.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/rmic.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/rpcgen.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/rpm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgiar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgic++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgicc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgilink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunc++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/suncc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunf77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunf90.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunf95.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunlink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/swig.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/tar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/tex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/tlib.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/wix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/yacc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/zip.py
   M /trunk/src/third_party/scons/scons-local/SCons/Util.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/BoolVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/EnumVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/ListVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/PackageVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/PathVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Warnings.py
   M /trunk/src/third_party/scons/scons-local/SCons/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat
   M /trunk/src/third_party/scons/scons-local/SCons/compat/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_UserString.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_hashlib.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_itertools.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_optparse.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_sets.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_sets15.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_shlex.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_subprocess.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_textwrap.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/builtins.py
   M /trunk/src/third_party/scons/scons-local/SCons/cpp.py
   M /trunk/src/third_party/scons/scons-local/SCons/dblite.py
   M /trunk/src/third_party/scons/scons-local/SCons/exitfuncs.py
   M /trunk/src/third_party/sqlite
   R /trunk/src/third_party/sqlite/os_unix.c (from /branches/chrome_webkit_merge_branch/third_party/sqlite/os_unix.c:2775)
   M /trunk/src/tools/code_coverage/coverage.py
   M /trunk/src/tools/code_coverage/process_coverage.py
   M /trunk/src/tools/memory_watcher/call_stack.cc
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/SConstruct
   M /trunk/src/webkit/build/JSConfig/create-config.sh
   M /trunk/src/webkit/build/JavaScriptCore/JavaScriptCore.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/JavaScriptCore/WTF.vcproj
   M /trunk/src/webkit/build/JavaScriptCore/copy_files.bat
   M /trunk/src/webkit/build/JavaScriptCore/javascriptcore.vsprops
   M /trunk/src/webkit/build/JavaScriptCore/wtf.vsprops
   M /trunk/src/webkit/build/KJSBindings/build-generated-files.sh
   M /trunk/src/webkit/build/V8Bindings/V8Bindings.vcproj
   M /trunk/src/webkit/build/V8Bindings/build-generated-files.sh
   M /trunk/src/webkit/build/WebCore/DerivedSources.make
   M /trunk/src/webkit/build/WebCore/WebCore.vcproj
   M /trunk/src/webkit/build/port/SConscript
   M /trunk/src/webkit/build/port/port.vcproj
   M /trunk/src/webkit/build/webkit_common.vsprops
   A /trunk/src/webkit/build/webkit_common_defines.vsprops (from /branches/chrome_webkit_merge_branch/webkit/build/webkit_common_defines.vsprops:2775)
   M /trunk/src/webkit/build/webkit_common_includes.vsprops
   M /trunk/src/webkit/config.h.in
   M /trunk/src/webkit/data/dom_serializer/htmlentities_in_text.htm
   M /trunk/src/webkit/data/dom_serializer/note.xml
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/editing/pasteboard/paste-text-013-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/fast/block/basic
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/fast/repaint/continuation-after-outline-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/fast/text/international/rtl-white-space-pre-wrap-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/anchor-basic-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/anchor-frames-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/anchor-goback-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/anchor-subframeload-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/javascriptlink-basic-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/javascriptlink-frames-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/javascriptlink-goback-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/javascriptlink-subframeload-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/post-goback2-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/postredirect-goback2-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/redirect302-frames-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/redirect302-goback-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/redirect302-subframeload-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/relativeanchor-basic-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/relativeanchor-frames-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/relativeanchor-goback-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/slowmetaredirect-basic-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/slowtimerredirect-basic-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/success200-basic-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/success200-frames-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/success200-frames-loadsame-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/success200-goback-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/success200-loadsame-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/success200-reload-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/success200-subframeload-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/timerredirect-basic-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/timerredirect-frames-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/timerredirect-goback-expected.txt
   D /trunk/src/webkit/data/layout_test_results/common/LayoutTests/http/tests/navigation/timerredirect-subframeload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/batik/text/textProperties-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/circular-marker-reference-1-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/circular-marker-reference-2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/circular-marker-reference-3-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/circular-marker-reference-4-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/js-late-marker-and-object-creation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/js-late-marker-creation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/non-circular-marker-reference-expected.txt
   M /trunk/src/webkit/data/layout_test_results/common/LayoutTests/svg/custom/shapes-supporting-markers-expected.txt
   A /trunk/src/webkit/data/layout_test_results/common/LayoutTests/xsl (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/common/LayoutTests/xsl:2775)
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/batik/filters/filterRegions-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/batik/paints/patternPreserveAspectRatioA-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/batik/text/textEffect2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/batik/text/textProperties-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/clip-path-referencing-use-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/empty-clip-path-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/feComponentTransfer-Discrete-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/feComponentTransfer-Gamma-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/feComponentTransfer-Linear-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/feComponentTransfer-Table-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/marker-default-width-height-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/marker-overflow-clip-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/non-opaque-filters-expected.txt
   M /trunk/src/webkit/data/layout_test_results/kjs/LayoutTests/svg/custom/shapes-supporting-markers-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/box_properties/acid_test-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/box_properties/acid_test-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/box_properties/acid_test-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/box_properties/clear-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/color_and_background/background_position-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/color_and_background/background_position-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/color_and_background/background_repeat-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css1/color_and_background/background_repeat-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t040105-import-01-b-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t040105-import-01-b-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t040105-import-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0402-syntax-05-f-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0402-syntax-05-f-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0402-syntax-05-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0402-syntax-06-f-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0402-syntax-06-f-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t0402-syntax-06-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t040306-syntax-01-f-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t040306-syntax-01-f-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t040306-syntax-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t09-c5526c-display-00-e-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t09-c5526c-display-00-e-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t09-c5526c-display-00-e-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/deleting/delete-block-merge-contents-018-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/deleting/delete-block-table-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/deleting/delete-br-011-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/deleting/delete-br-012-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/deleting/delete-br-012-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/deleting/delete-br-012-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/deleting/delete-to-select-table-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/4920488-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/5144139-1-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/5144139-1-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/5144139-1-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/5482023-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/boldSelection-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/create-list-with-hr-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/italicizeByCharacter-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/modifyForeColorByCharacter-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/print-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/selectAll-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/selectAll-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/selectAll-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/execCommand/strikethroughSelection-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/inserting/4959067-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/inserting/insert-div-022-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/4631972-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/4840662-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/5245519-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/block-wrappers-necessary-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/block-wrappers-necessary-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/block-wrappers-necessary-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/merge-end-blockquote-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-list-001-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-match-style-001-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-table-001-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-text-003-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-text-010-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-text-012-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-text-013-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/paste-text-014-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/pasteboard/smart-paste-001-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/4983858-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/after-line-wrap-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/contenteditable-click-inside-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/contenteditable-click-inside-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/contenteditable-click-inside-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/contenteditable-click-outside-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/contenteditable-click-outside-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/contenteditable-click-outside-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/drag-text-delay-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/drag-text-delay-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/drag-text-delay-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/drag-text-delay-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/drag-text-delay-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/drag-text-delay-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/editable-html-element-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/selection/editable-non-editable-crash-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/apple-style-editable-mix-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/create-block-for-style-007-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/create-block-for-style-008-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/create-block-for-style-012-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/create-block-for-style-012-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/create-block-for-style-012-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/font-family-with-space-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/style-3681552-fix-001-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/style/style-boundary-005-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/undo/undo-combined-delete-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/undo/undo-delete-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/editing/undo/undo-forward-delete-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize02-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize02-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize02-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize02-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize10-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize10-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize10-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize10-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize11-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize11-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize11-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize11-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize13-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize13-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize13-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize13-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize14-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize14-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize14-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize14-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize17-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize17-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize17-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize17-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize18-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize18-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize18-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize18-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize19-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize19-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize19-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/size/backgroundSize19-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-1-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-1-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-2-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-2-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-3-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-3-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-4-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-4-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-5-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-5-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-6-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/backgrounds/svg-as-background-6-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/basic/001-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/basic/011-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/basic/011-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/basic/011-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/float/float-avoidance-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/float/float-avoidance-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/float/float-avoidance-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/margin-collapse/103-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/margin-collapse/103-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/margin-collapse/103-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-ltr-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-rtl-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/block/positioning/auto/006-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/box-shadow/basic-shadows-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/box-shadow/basic-shadows-expected.png
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/canvas/access-zero-sized-canvas-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/canvas/access-zero-sized-canvas-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/canvas/canvasDrawingIntoSelf-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/canvas/canvasDrawingIntoSelf-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/canvas/drawImage-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/canvas/drawImage-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/clip/015-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/clip/outline-overflowClip-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/attribute-selector-empty-value-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/attribute-selector-empty-value-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/attribute-selector-empty-value-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/attribute-selector-empty-value-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/attribute-selector-empty-value-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/attribute-selector-empty-value-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/begin-end-contain-selector-empty-value-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/begin-end-contain-selector-empty-value-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/begin-end-contain-selector-empty-value-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/begin-end-contain-selector-empty-value-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/begin-end-contain-selector-empty-value-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/begin-end-contain-selector-empty-value-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/computed-style-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/computed-style-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/computed-style-without-renderer-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/computed-style-without-renderer-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/counters/invalidate-cached-counter-node-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/counters/invalidate-cached-counter-node-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/counters/invalidate-cached-counter-node-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/counters/invalidate-cached-counter-node-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/counters/invalidate-cached-counter-node-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/counters/invalidate-cached-counter-node-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/dynamic-sibling-selector-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/dynamic-sibling-selector-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/dynamic-sibling-selector-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/dynamic-sibling-selector-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/dynamic-sibling-selector-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/dynamic-sibling-selector-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-after-float-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-after-float-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-after-float-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-after-float-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-after-float-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-after-float-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-float-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-skip-out-of-flow-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-skip-out-of-flow-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-skip-out-of-flow-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-skip-out-of-flow-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-skip-out-of-flow-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/first-letter-skip-out-of-flow-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-in-media-rule-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-in-media-rule-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-in-media-rule-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-in-media-rule-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-in-media-rule-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-in-media-rule-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-locally-installed-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-locally-installed-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-locally-installed-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-locally-installed-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-locally-installed-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-locally-installed-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-multiple-faces-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-multiple-faces-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-multiple-faces-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-multiple-faces-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-multiple-faces-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-face-multiple-faces-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-size-negative-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-size-negative-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-size-negative-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-size-negative-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-size-negative-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-size-negative-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-weight-1-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-weight-1-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-weight-1-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-weight-1-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-weight-1-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/font-weight-1-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-negative-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-negative-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-negative-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-negative-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-negative-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-negative-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-overflow-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-overflow-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-overflow-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-overflow-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-overflow-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/line-height-overflow-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/link-outside-head-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/link-outside-head-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/link-outside-head-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/link-outside-head-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/link-outside-head-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/link-outside-head-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/live-cssrules-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/live-cssrules-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/live-cssrules-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/live-cssrules-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/live-cssrules-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/live-cssrules-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-quirk-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-quirk-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-quirk-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-quirk-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-quirk-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-quirk-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-strict-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-strict-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-strict-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-strict-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-strict-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/margin-bottom-form-element-strict-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/remove-shorthand-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/remove-shorthand-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/simple-selector-chain-parsing-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/simple-selector-chain-parsing-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/simple-selector-chain-parsing-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/simple-selector-chain-parsing-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/simple-selector-chain-parsing-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/simple-selector-chain-parsing-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-outside-head-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-outside-head-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-outside-head-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-outside-head-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-outside-head-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-outside-head-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-parsed-outside-head-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-parsed-outside-head-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-parsed-outside-head-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-parsed-outside-head-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-parsed-outside-head-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/style-parsed-outside-head-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/transform-default-parameter-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/transform-default-parameter-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/transform-default-parameter-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/transform-default-parameter-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/transform-default-parameter-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/transform-default-parameter-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/value-list-out-of-bounds-crash-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/value-list-out-of-bounds-crash-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/value-list-out-of-bounds-crash-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/value-list-out-of-bounds-crash-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/value-list-out-of-bounds-crash-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/value-list-out-of-bounds-crash-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/variables (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/variables:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-font-size-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-font-size-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-font-size-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-font-size-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-font-size-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-font-size-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-property-parsing-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-property-parsing-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-property-parsing-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-property-parsing-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-property-parsing-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/css/zoom-property-parsing-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css-generated-content/hover-style-change-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/doctypes/003-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/doctypes/003-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/doctypes/003-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/SelectorAPI/dumpNodeList-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/dom-parse-serialize-display-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/dom-parse-serialize-display-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/dom-parse-serialize-display-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/dom-parse-serialize-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/dom-parse-serialize-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dom/dom-parse-serialize-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/insert-before-table-part-in-continuation-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/insertAdjacentElement-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/positioned-movement-with-positioned-children-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/positioned-movement-with-positioned-children-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/positioned-movement-with-positioned-children-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/positioned-movement-with-positioned-children-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/positioned-movement-with-positioned-children-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/dynamic/selection-highlight-adjust-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/events/onunload-clears-onbeforeunload-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/events/onunload-clears-onbeforeunload-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/events/onunload-not-on-body-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/events/onunload-not-on-body-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/flexbox/016-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/button-submit-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/button-submit-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/button-submit-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/button-submit-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/button-submit-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/button-submit-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/control-clip-overflow-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/control-clip-overflow-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/control-clip-overflow-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/control-clip-overflow-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/control-clip-overflow-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/control-clip-overflow-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/form-and-frame-interaction-retains-values-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/form-and-frame-interaction-retains-values-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-align-image-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-double-click-selection-gap-bug-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-first-letter-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-first-letter-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-first-letter-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-first-letter-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-first-letter-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/input-first-letter-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/listbox-onchange-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/search-display-none-cancel-button-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/search-display-none-cancel-button-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/search-display-none-cancel-button-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/search-display-none-cancel-button-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/search-display-none-cancel-button-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/search-display-none-cancel-button-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/selected-index-assert-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/tabbing-input-iframe-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/forms/textarea-rows-cols-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/001-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/contentWindow_Frame-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/contentWindow_iFrame-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/iframe-option-crash-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/iframe-with-frameborder-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/viewsource-attribute-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/viewsource-attribute-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/frames/viewsource-attribute-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/continuation-outlines-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/continuation-outlines-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/continuation-outlines-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/continuation-outlines-with-layers-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/continuation-outlines-with-layers-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/continuation-outlines-with-layers-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/drawStyledEmptyInlines-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/drawStyledEmptyInlines-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/drawStyledEmptyInlines-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/emptyInlinesWithinLists-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/emptyInlinesWithinLists-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/emptyInlinesWithinLists-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-padding-disables-text-quirk-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-padding-disables-text-quirk-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-padding-disables-text-quirk-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-padding-disables-text-quirk-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-padding-disables-text-quirk-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-padding-disables-text-quirk-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-text-quirk-bpm-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-text-quirk-bpm-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-text-quirk-bpm-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-text-quirk-bpm-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-text-quirk-bpm-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/inline-text-quirk-bpm-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/percentage-margins-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/percentage-margins-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/percentage-margins-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/percentage-margins-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/percentage-margins-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/inline/percentage-margins-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/invalid/020-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/invalid/missing-dl-end-tag-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/invalid/missing-dl-end-tag-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/invalid/missing-dl-end-tag-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/invalid/missing-dt-end-tag-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/invalid/missing-dt-end-tag-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/invalid/missing-dt-end-tag-expected.txt
   R /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/deep-recursion-test-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/js/deep-recursion-test-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/exception-codegen-crash-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/js/exception-codegen-crash-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/function-decompilation-operatiors-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/js/function-decompilation-operatiors-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/function-prototype-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/modify-non-references-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/number-toExponential-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/regexp-overflow-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/js/regexp-overflow-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/js/switch-behaviour-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/js/switch-behaviour-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/lists/markers-in-selection-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/media/mq-js-stylesheet-media-03-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/media/mq-js-stylesheet-media-03-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/media/mq-js-stylesheet-media-03-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/media/mq-js-stylesheet-media-04-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/media/mq-js-stylesheet-media-04-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/media/mq-js-stylesheet-media-04-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-style-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-style-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-style-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-style-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-style-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-style-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-textarea-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-textarea-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-textarea-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-textarea-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-textarea-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/comment-in-textarea-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/entity-comment-in-style-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/entity-comment-in-style-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/entity-comment-in-textarea-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/entity-comment-in-textarea-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/entity-end-script-tag-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/entity-end-script-tag-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-style-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-style-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-style-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-style-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-style-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-style-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-textarea-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-textarea-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-textarea-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-textarea-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-textarea-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/parser/open-comment-in-textarea-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/caret-outside-block-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/caret-outside-block-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/caret-outside-block-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/caret-outside-block-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/caret-outside-block-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/caret-outside-block-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/clipped-relative-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/inline-outline-repaint-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/layout-state-only-positioned-expected.checksum
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/layout-state-relative-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/layout-state-relative-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/layout-state-relative-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/layout-state-relative-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/layout-state-relative-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/layout-state-relative-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-1-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-1-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-1-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-1-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-1-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-1-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-10-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-10-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-10-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-10-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-10-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-10-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-2-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-2-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-2-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-2-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-2-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-2-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-3-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-3-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-3-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-3-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-3-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-3-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-4-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-4-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-4-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-4-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-4-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-4-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-5-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-5-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-5-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-5-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-5-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-5-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-6-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-6-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-6-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-6-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-6-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-6-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-7-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-7-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-7-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-7-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-7-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-7-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-8-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-8-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-8-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-8-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-8-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-8-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-9-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-9-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-9-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-9-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-9-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/line-flow-with-floats-9-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/lines-with-layout-delta-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/lines-with-layout-delta-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/lines-with-layout-delta-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/lines-with-layout-delta-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/lines-with-layout-delta-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/lines-with-layout-delta-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-2-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-2-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-2-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-2-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-3-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-3-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-3-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-3-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/subtree-root-clip-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/table-two-pass-layout-overpaint-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/table-two-pass-layout-overpaint-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/table-two-pass-layout-overpaint-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/repaint/table-two-pass-layout-overpaint-expected.png:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/replaced/replaced-breaking-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/replaced/replaced-breaking-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/replaced/replaced-breaking-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/replaced/width100percent-textarea-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/selectors/159-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/selectors/177a-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/table/form-with-table-style-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/table/form-with-table-style-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/table/form-with-table-style-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/atsui-spacing-features-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/atsui-spacing-features-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/atsui-spacing-features-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/basic/014-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/embed-at-end-of-pre-wrap-line-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/embed-at-end-of-pre-wrap-line-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/embed-at-end-of-pre-wrap-line-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/international/bidi-AN-after-empty-run-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/international/bidi-AN-after-empty-run-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/international/bidi-AN-after-empty-run-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/international/bidi-AN-after-empty-run-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/international/bidi-AN-after-empty-run-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/international/bidi-AN-after-empty-run-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/international/rtl-white-space-pre-wrap-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/selection-hard-linebreak-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/shadow-no-blur-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/shadow-no-blur-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/shadow-no-blur-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/shadow-no-blur-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/shadow-no-blur-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/shadow-no-blur-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-2-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-2-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-2-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-2-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-2-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-2-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/trailing-white-space-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-in-pre-crash-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-in-pre-crash-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-in-pre-crash-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-in-pre-crash-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-in-pre-crash-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-in-pre-crash-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-styled-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-styled-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-styled-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-styled-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-styled-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/wbr-styled-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/nowrap-clear-float-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/nowrap-clear-float-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/nowrap-clear-float-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/nowrap-clear-float-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/nowrap-clear-float-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/nowrap-clear-float-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/pre-wrap-last-char-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/document-function-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/document-function-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/document-function-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-enc-cyr-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-enc-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-import-depth-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-import-depth-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-import-depth-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-relative-path-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-relative-path-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt-relative-path-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/fast/xsl/xslt_unicode-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/local/file-url-sent-as-referer-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/anchor-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/anchor-frames-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/anchor-goback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/anchor-subframeload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/javascriptlink-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/javascriptlink-goback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/javascriptlink-subframeload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/metaredirect-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/metaredirect-frames-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/metaredirect-goback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/metaredirect-subframeload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/post-goback2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/postredirect-goback2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/redirect302-frames-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/redirect302-goback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/redirect302-subframeload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/relativeanchor-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/relativeanchor-frames-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/relativeanchor-goback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/slowmetaredirect-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/slowtimerredirect-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/success200-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/success200-frames-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/success200-frames-loadsame-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/success200-goback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/success200-loadsame-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/success200-reload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/success200-subframeload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/timerredirect-basic-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/timerredirect-frames-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/timerredirect-goback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/navigation/timerredirect-subframeload-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/cross-frame-access-history-put-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-align-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-align-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-align-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-align-04-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-align-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-align-06-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-text-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-text-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-text-07-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-text-08-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/filters/filterRegions-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/masking/maskRegions-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/paints/gradientLimit-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/paints/patternPreserveAspectRatioA-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/paints/patternRegionA-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/paints/patternRegions-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/text/longTextOnPath-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/text/textAnchor-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/text/textAnchor2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/text/textAnchor3-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/text/textEffect2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/text/textLength-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/batik/text/textProperties2-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/carto.net/button-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/carto.net/colourpicker-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/carto.net/combobox-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/carto.net/scrollbar-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/carto.net/selectionlist-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/carto.net/slider-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/carto.net/textbox-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/css/css-box-min-width-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/absolute-sized-svg-in-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/alignment-baseline-modes-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/clip-path-referencing-use-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/container-opacity-clip-viewBox-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/coords-relative-units-transforms-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/createelement-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/dominant-baseline-hanging-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/dominant-baseline-modes-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/dynamic-svg-document-creation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/empty-clip-path-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/feComponentTransfer-Discrete-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/feComponentTransfer-Gamma-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/feComponentTransfer-Linear-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/feComponentTransfer-Table-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/fill-fallback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/focus-ring-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/foreign-object-skew-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/foreignObject-crash-on-hover-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/foreignObject-crash-on-hover-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/foreignObject-crash-on-hover-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/getTransformToElement-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/getscreenctm-in-mixed-content-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/getsvgdocument-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/gradient-cycle-detection-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/gradient-deep-referencing-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/hit-test-unclosed-subpaths-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/hit-test-with-br-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/image-parent-translation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/image-small-width-height-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/image-with-prefix-in-webarchive-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/image-with-prefix-in-webarchive-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/inline-svg-in-xhtml-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/invalid-css-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/invalid-fill-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/invalid-fill-hex-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/invalid-lengthlist-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/js-late-clipPath-and-object-creation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/js-late-clipPath-creation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/js-late-pattern-and-object-creation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/js-late-pattern-creation-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/junk-data-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/linking-a-03-b-transform-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/linking-a-03-b-viewTarget-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/linking-a-03-b-zoomAndPan-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/marker-default-width-height-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/marker-overflow-clip-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/missing-xlink-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/non-opaque-filters-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/path-bad-data-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/pattern-cycle-detection-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/pattern-deep-referencing-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/pattern-rotate-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/percentage-of-html-parent-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/pointer-events-path-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/preserve-aspect-ratio-syntax-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/rootmost-svg-xy-attrs-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/second-inline-text-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/shape-rendering-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/shapes-supporting-markers-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/simpleCDF-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/stroke-fallback-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/stroked-pattern-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/struct-use-09-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/style-attribute-font-size-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/svg-float-border-padding-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/svg-overflow-types-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/text-clip-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/text-dom-01-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/text-hit-test-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-clipped-hit-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-detach-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-dynamic-append-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-elementInstance-event-target-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-elementInstance-methods-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-event-handler-on-referenced-element-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-event-handler-on-use-element-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-events-crash-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-instanceRoot-modifications-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-modify-container-in-target-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-modify-target-container-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-modify-target-symbol-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-on-g-containing-symbol-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-on-g-containing-use-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-on-g-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-on-rect-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-on-symbol-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-on-use-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-property-changes-through-dom-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-property-changes-through-svg-dom-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-recursion-1-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-recursion-3-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-recursion-4-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-referencing-nonexisting-symbol-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/use-transform-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/viewbox-syntax-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/custom/viewport-em-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/data-types/002-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/error/003-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/error/010-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/error/011-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/error/012-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/error/017-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/links/003-broken-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/003-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/004-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/005-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/006-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/008-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/009-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/010-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/mixed/011-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/perf/003-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/perf/004-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/perf/005-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/perf/006-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/rendering-model/003-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/rendering-model/004-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/text/001-broken-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/viewbox/002-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/hixie/viewbox/003-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-align-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-align-02-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-align-03-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-align-04-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-align-05-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-align-06-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-altglyph-01-b-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-altglyph-01-b-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-altglyph-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-fonts-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-spacing-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-04-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-05-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-06-t-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-06-t-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-06-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-07-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-text-08-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-tref-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-tselect-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-tselect-02-f-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-tspan-01-b-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-ws-01-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/text-ws-02-t-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/text/textPathBoundsBug-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/webarchive/svg-feimage-subresources-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/svg/webarchive/svg-feimage-subresources-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/svg/webarchive/svg-script-subresouces-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/svg/webarchive/svg-script-subresouces-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-2-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-2-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-2-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-2-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-2-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-2-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-4-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-4-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug2479-4-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug26553-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug26553-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug26553-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug278266-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug278266-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug278266-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug278266-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug278266-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug278266-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug3037-1-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug38916-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug4093-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug4093-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug4093-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug44505-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug44505-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug44505-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug51140-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug51727-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug51727-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug51727-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug52505-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug52505-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug52505-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug52506-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug52506-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug52506-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug57828-2-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug57828-2-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug57828-2-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug8411-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug8411-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug8411-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug8411-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug8411-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug8411-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/core/bloomberg-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/core/bloomberg-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/core/bloomberg-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/bugs/bug56024-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/bugs/bug56024-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/bugs/bug56024-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/core/captions1-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/core/captions1-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/core/captions1-expected.txt
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/other/test4-expected.checksum
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/other/test4-expected.png
   M /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla_expected_failures/other/test4-expected.txt
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/archive-empty-frame-dom-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/archive-empty-frame-dom-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/archive-empty-frame-source-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/archive-empty-frame-source-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/archive-with-unencoded-url-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/archive-with-unencoded-url-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/doctype-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/doctype-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/doctype-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/doctype-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/doctype-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/doctype-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-body-background-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-body-background-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-css-import-expected.checksum (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-css-import-expected.checksum:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-css-import-expected.png (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-css-import-expected.png:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-css-import-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-css-import-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-duplicate-resources-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-duplicate-resources-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-frameset-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-frameset-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-img-src-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-img-src-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-input-src-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-input-src-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-link-href-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-link-href-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-object-data-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-object-data-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-script-src-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-script-src-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-table-background-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-table-background-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-td-background-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-td-background-expected.txt:2775)
   A /trunk/src/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-xml-stylesheet-expected.txt (from /branches/chrome_webkit_merge_branch/webkit/data/layout_test_results/v8/LayoutTests/webarchive/test-xml-stylesheet-expected.txt:2775)
   M /trunk/src/webkit/data/layout_test_results/v8/pending/svg/carto.net/window-expected.txt
   M /trunk/src/webkit/data/layout_tests/chrome/fast/forms/basic-textareas-quirks-expected.txt
   M /trunk/src/webkit/glue/autocomplete_input_listener_unittest.cc
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/cpp_bound_class.cc
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/cpp_variant_unittest.cc
   M /trunk/src/webkit/glue/debugger.cc
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.h
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/glue_serialize_unittest.cc
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/image_decoder.cc
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/inspector_client_impl.h
   M /trunk/src/webkit/glue/localized_strings.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/regular_expression_unittest.cc
   M /trunk/src/webkit/glue/resource_handle_win.cc
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/webcursor.cc
   M /trunk/src/webkit/glue/webdatasource.h
   M /trunk/src/webkit/glue/webdatasource_impl.cc
   M /trunk/src/webkit/glue/webdatasource_impl.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webinputevent_win.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webkit_resources.h
   M /trunk/src/webkit/glue/webkit_resources.rc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webtextinput_impl.cc
   M /trunk/src/webkit/glue/webview_impl.cc
   D /trunk/src/webkit/pending/AXObjectCache.cpp
   D /trunk/src/webkit/pending/AXObjectCache.h
   D /trunk/src/webkit/pending/AccessibilityObject.cpp
   D /trunk/src/webkit/pending/AccessibilityObject.h
   M /trunk/src/webkit/pending/AccessibleBase.cpp
   M /trunk/src/webkit/pending/AccessibleDocument.cpp
   D /trunk/src/webkit/pending/Arena.h
   M /trunk/src/webkit/pending/AtomicString.cpp
   A /trunk/src/webkit/pending/AtomicString.h (from /branches/chrome_webkit_merge_branch/webkit/pending/AtomicString.h:2775)
   D /trunk/src/webkit/pending/BitmapImage.cpp
   D /trunk/src/webkit/pending/BitmapImage.h
   D /trunk/src/webkit/pending/CSSFontFaceRule.h
   D /trunk/src/webkit/pending/CSSFontSelector.cpp
   D /trunk/src/webkit/pending/CSSPageRule.h
   D /trunk/src/webkit/pending/CSSParser.cpp
   D /trunk/src/webkit/pending/CSSStyleRule.h
   M /trunk/src/webkit/pending/CSSStyleSelector.cpp
   M /trunk/src/webkit/pending/CachedCSSStyleSheet.cpp
   M /trunk/src/webkit/pending/CachedResource.h
   M /trunk/src/webkit/pending/CachedScript.cpp
   D /trunk/src/webkit/pending/CanvasGradient.cpp
   D /trunk/src/webkit/pending/CanvasGradient.h
   D /trunk/src/webkit/pending/CanvasPattern.cpp
   D /trunk/src/webkit/pending/CanvasPattern.h
   R /trunk/src/webkit/pending/CanvasRenderingContext2D.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/CanvasRenderingContext2D.cpp:2775)
   A /trunk/src/webkit/pending/CanvasRenderingContext2D.h (from /branches/chrome_webkit_merge_branch/webkit/pending/CanvasRenderingContext2D.h:2775)
   A /trunk/src/webkit/pending/CanvasRenderingContext2D.idl (from /branches/chrome_webkit_merge_branch/webkit/pending/CanvasRenderingContext2D.idl:2775)
   D /trunk/src/webkit/pending/CanvasStyle.cpp
   D /trunk/src/webkit/pending/CanvasStyle.h
   D /trunk/src/webkit/pending/CharacterData.cpp
   D /trunk/src/webkit/pending/Chrome.cpp
   A /trunk/src/webkit/pending/CompositeAnimation.h (from /branches/chrome_webkit_merge_branch/webkit/pending/CompositeAnimation.h:2775)
   A /trunk/src/webkit/pending/Console.h (from /branches/chrome_webkit_merge_branch/webkit/pending/Console.h:2775)
   D /trunk/src/webkit/pending/ContainerNode.cpp
   A /trunk/src/webkit/pending/DNS.h (from /branches/chrome_webkit_merge_branch/webkit/pending/DNS.h:2775)
   M /trunk/src/webkit/pending/DOMWindow.cpp
   M /trunk/src/webkit/pending/DOMWindow.h
   M /trunk/src/webkit/pending/DeleteButtonController.cpp
   D /trunk/src/webkit/pending/DeleteSelectionCommand.cpp
   D /trunk/src/webkit/pending/DeprecatedString.cpp
   M /trunk/src/webkit/pending/DerivedSources.make
   D /trunk/src/webkit/pending/DocLoader.cpp
   D /trunk/src/webkit/pending/DocLoader.h
   M /trunk/src/webkit/pending/Document.cpp
   R /trunk/src/webkit/pending/Document.h (from /branches/chrome_webkit_merge_branch/webkit/pending/Document.h:2775)
   M /trunk/src/webkit/pending/DragController.cpp
   D /trunk/src/webkit/pending/Editor.h
   A /trunk/src/webkit/pending/EmptyClients.h (from /branches/chrome_webkit_merge_branch/webkit/pending/EmptyClients.h:2775)
   M /trunk/src/webkit/pending/EventHandler.cpp
   D /trunk/src/webkit/pending/EventHandler.h
   D /trunk/src/webkit/pending/EventTarget.cpp
   D /trunk/src/webkit/pending/EventTarget.h
   D /trunk/src/webkit/pending/EventTargetNode.cpp
   D /trunk/src/webkit/pending/EventTargetNode.h
   A /trunk/src/webkit/pending/ExceptionContext.h (from /branches/chrome_webkit_merge_branch/webkit/pending/ExceptionContext.h:2775)
   A /trunk/src/webkit/pending/FileSystem.h (from /branches/chrome_webkit_merge_branch/webkit/pending/FileSystem.h:2775)
   M /trunk/src/webkit/pending/FileSystemWin.cpp
   D /trunk/src/webkit/pending/FloatConversion.h
   R /trunk/src/webkit/pending/Font.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/Font.cpp:2775)
   M /trunk/src/webkit/pending/FontCache.cpp
   M /trunk/src/webkit/pending/FontCache.h
   M /trunk/src/webkit/pending/FontDescription.h
   M /trunk/src/webkit/pending/Frame.cpp
   D /trunk/src/webkit/pending/Frame.h
   M /trunk/src/webkit/pending/FrameLoader.cpp
   M /trunk/src/webkit/pending/FrameLoader.h
   M /trunk/src/webkit/pending/FrameLoaderClient.h
   D /trunk/src/webkit/pending/FramePrivate.h
   D /trunk/src/webkit/pending/FrameView.cpp
   D /trunk/src/webkit/pending/FrameView.h
   M /trunk/src/webkit/pending/GIFImageDecoder.cpp
   D /trunk/src/webkit/pending/GlobalHistory.h
   D /trunk/src/webkit/pending/GlyphWidthMap.cpp
   D /trunk/src/webkit/pending/GlyphWidthMap.h
   A /trunk/src/webkit/pending/GraphicsContext.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/GraphicsContext.cpp:2775)
   R /trunk/src/webkit/pending/GraphicsContext.h (from /branches/chrome_webkit_merge_branch/webkit/pending/GraphicsContext.h:2775)
   R /trunk/src/webkit/pending/HTMLAnchorElement.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/HTMLAnchorElement.cpp:2775)
   D /trunk/src/webkit/pending/HTMLAnchorElement.h
   D /trunk/src/webkit/pending/HTMLAnchorElement.idl
   D /trunk/src/webkit/pending/HTMLAppletElement.cpp
   D /trunk/src/webkit/pending/HTMLAppletElement.h
   D /trunk/src/webkit/pending/HTMLAreaElement.cpp
   D /trunk/src/webkit/pending/HTMLAreaElement.h
   D /trunk/src/webkit/pending/HTMLAreaElement.idl
   A /trunk/src/webkit/pending/HTMLAttributeNames.in (from /branches/chrome_webkit_merge_branch/webkit/pending/HTMLAttributeNames.in:2775)
   D /trunk/src/webkit/pending/HTMLButtonElement.idl
   D /trunk/src/webkit/pending/HTMLCanvasElement.cpp
   D /trunk/src/webkit/pending/HTMLElement.cpp
   D /trunk/src/webkit/pending/HTMLElement.h
   D /trunk/src/webkit/pending/HTMLElement.idl
   D /trunk/src/webkit/pending/HTMLEmbedElement.cpp
   D /trunk/src/webkit/pending/HTMLEmbedElement.h
   D /trunk/src/webkit/pending/HTMLFieldSetElement.cpp
   D /trunk/src/webkit/pending/HTMLGenericFormElement.cpp
   D /trunk/src/webkit/pending/HTMLGenericFormElement.h
   D /trunk/src/webkit/pending/HTMLInputElement.cpp
   D /trunk/src/webkit/pending/HTMLInputElement.h
   D /trunk/src/webkit/pending/HTMLInputElement.idl
   D /trunk/src/webkit/pending/HTMLLabelElement.idl
   D /trunk/src/webkit/pending/HTMLLegendElement.cpp
   D /trunk/src/webkit/pending/HTMLLegendElement.idl
   M /trunk/src/webkit/pending/HTMLLinkElement.cpp
   M /trunk/src/webkit/pending/HTMLLinkElement.h
   D /trunk/src/webkit/pending/HTMLObjectElement.cpp
   D /trunk/src/webkit/pending/HTMLObjectElement.h
   D /trunk/src/webkit/pending/HTMLObjectElement.idl
   D /trunk/src/webkit/pending/HTMLOptGroupElement.cpp
   D /trunk/src/webkit/pending/HTMLOptionElement.cpp
   D /trunk/src/webkit/pending/HTMLParser.cpp
   M /trunk/src/webkit/pending/HTMLPlugInElement.cpp
   M /trunk/src/webkit/pending/HTMLPlugInElement.h
   D /trunk/src/webkit/pending/HTMLScriptElement.cpp
   D /trunk/src/webkit/pending/HTMLScriptElement.h
   D /trunk/src/webkit/pending/HTMLSelectElement.idl
   D /trunk/src/webkit/pending/HTMLTextAreaElement.idl
   D /trunk/src/webkit/pending/HTMLTokenizer.cpp
   R /trunk/src/webkit/pending/Image.h (from /branches/chrome_webkit_merge_branch/webkit/pending/Image.h:2775)
   D /trunk/src/webkit/pending/ImageBuffer.h
   D /trunk/src/webkit/pending/IndentOutdentCommand.cpp
   M /trunk/src/webkit/pending/InspectorController.h
   D /trunk/src/webkit/pending/JSSVGLazyEventListener.cpp
   M /trunk/src/webkit/pending/KURL.cpp
   M /trunk/src/webkit/pending/KURL.h
   D /trunk/src/webkit/pending/MouseEvent.h
   A /trunk/src/webkit/pending/NSResolver.h (from /branches/chrome_webkit_merge_branch/webkit/pending/NSResolver.h:2775)
   D /trunk/src/webkit/pending/NamedAttrMap.cpp
   A /trunk/src/webkit/pending/NetworkStateNotifier.h (from /branches/chrome_webkit_merge_branch/webkit/pending/NetworkStateNotifier.h:2775)
   R /trunk/src/webkit/pending/Node.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/Node.cpp:2775)
   R /trunk/src/webkit/pending/Node.h (from /branches/chrome_webkit_merge_branch/webkit/pending/Node.h:2775)
   A /trunk/src/webkit/pending/NodeFilter.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/NodeFilter.cpp:2775)
   A /trunk/src/webkit/pending/NodeFilter.h (from /branches/chrome_webkit_merge_branch/webkit/pending/NodeFilter.h:2775)
   A /trunk/src/webkit/pending/NodeFilterCondition.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/NodeFilterCondition.cpp:2775)
   A /trunk/src/webkit/pending/NodeFilterCondition.h (from /branches/chrome_webkit_merge_branch/webkit/pending/NodeFilterCondition.h:2775)
   A /trunk/src/webkit/pending/NodeIterator.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/NodeIterator.cpp:2775)
   A /trunk/src/webkit/pending/NodeIterator.h (from /branches/chrome_webkit_merge_branch/webkit/pending/NodeIterator.h:2775)
   R /trunk/src/webkit/pending/Page.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/Page.cpp:2775)
   M /trunk/src/webkit/pending/Page.h
   D /trunk/src/webkit/pending/Path.h
   R /trunk/src/webkit/pending/Peerable.h (from /branches/chrome_webkit_merge_branch/webkit/pending/Peerable.h:2775)
   M /trunk/src/webkit/pending/PlatformKeyboardEvent.h
   D /trunk/src/webkit/pending/RemoveFormatCommand.cpp
   D /trunk/src/webkit/pending/RenderBlock.cpp
   M /trunk/src/webkit/pending/RenderButton.cpp
   M /trunk/src/webkit/pending/RenderButton.h
   D /trunk/src/webkit/pending/RenderFlow.h
   M /trunk/src/webkit/pending/RenderMenuList.cpp
   M /trunk/src/webkit/pending/RenderMenuList.h
   D /trunk/src/webkit/pending/RenderObject.cpp
   D /trunk/src/webkit/pending/RenderObject.h
   D /trunk/src/webkit/pending/RenderPart.h
   M /trunk/src/webkit/pending/RenderPartObject.cpp
   A /trunk/src/webkit/pending/RenderStyle.h (from /branches/chrome_webkit_merge_branch/webkit/pending/RenderStyle.h:2775)
   D /trunk/src/webkit/pending/RenderTable.cpp
   M /trunk/src/webkit/pending/RenderText.cpp
   D /trunk/src/webkit/pending/RenderText.h
   M /trunk/src/webkit/pending/RenderTextControl.cpp
   M /trunk/src/webkit/pending/RenderTheme.h
   D /trunk/src/webkit/pending/RenderWordBreak.cpp
   D /trunk/src/webkit/pending/RenderWordBreak.h
   D /trunk/src/webkit/pending/ReplaceSelectionCommand.cpp
   A /trunk/src/webkit/pending/SMILTimeContainer.h (from /branches/chrome_webkit_merge_branch/webkit/pending/SMILTimeContainer.h:2775)
   D /trunk/src/webkit/pending/SVGDocumentExtensions.cpp
   D /trunk/src/webkit/pending/SVGImage.cpp
   D /trunk/src/webkit/pending/SVGImageEmptyClients.h
   D /trunk/src/webkit/pending/SVGRootInlineBox.cpp
   A /trunk/src/webkit/pending/ScriptController.h (from /branches/chrome_webkit_merge_branch/webkit/pending/ScriptController.h:2775)
   M /trunk/src/webkit/pending/SecurityOrigin.cpp
   M /trunk/src/webkit/pending/SecurityOrigin.h
   M /trunk/src/webkit/pending/Selection.cpp
   M /trunk/src/webkit/pending/Settings.cpp
   M /trunk/src/webkit/pending/Settings.h
   M /trunk/src/webkit/pending/SimpleFontData.cpp
   M /trunk/src/webkit/pending/SimpleFontData.h
   R /trunk/src/webkit/pending/String.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/String.cpp:2775)
   D /trunk/src/webkit/pending/StringHash.h
   M /trunk/src/webkit/pending/StringImpl.cpp
   M /trunk/src/webkit/pending/StringImpl.h
   D /trunk/src/webkit/pending/TextCodec.cpp
   D /trunk/src/webkit/pending/TextCodec.h
   M /trunk/src/webkit/pending/TextCodecICU.cpp
   D /trunk/src/webkit/pending/TextCodecUTF16.cpp
   D /trunk/src/webkit/pending/TextDecoder.cpp
   M /trunk/src/webkit/pending/TextResourceDecoder.cpp
   M /trunk/src/webkit/pending/TextResourceDecoder.h
   A /trunk/src/webkit/pending/Traversal.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/Traversal.cpp:2775)
   A /trunk/src/webkit/pending/Traversal.h (from /branches/chrome_webkit_merge_branch/webkit/pending/Traversal.h:2775)
   M /trunk/src/webkit/pending/TreeShared.h
   A /trunk/src/webkit/pending/TreeWalker.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/TreeWalker.cpp:2775)
   A /trunk/src/webkit/pending/TreeWalker.h (from /branches/chrome_webkit_merge_branch/webkit/pending/TreeWalker.h:2775)
   M /trunk/src/webkit/pending/WebCoreFrameBridge.h
   M /trunk/src/webkit/pending/XMLHttpRequest.cpp
   M /trunk/src/webkit/pending/XMLHttpRequest.h
   D /trunk/src/webkit/pending/XMLTokenizer.cpp
   M /trunk/src/webkit/pending/XSLImportRule.cpp
   M /trunk/src/webkit/pending/XSLStyleSheet.cpp
   M /trunk/src/webkit/pending/XSLStyleSheet.h
   D /trunk/src/webkit/pending/XSLTProcessor.cpp
   D /trunk/src/webkit/pending/bidi.cpp
   D /trunk/src/webkit/pending/kjs
   D /trunk/src/webkit/pending/makeprop.pl
   D /trunk/src/webkit/pending/makevalues.pl
   D /trunk/src/webkit/pending/markup.cpp
   R /trunk/src/webkit/pending/pcre_exec.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/pcre_exec.cpp:2775)
   D /trunk/src/webkit/pending/wtf/FastMalloc.cpp
   D /trunk/src/webkit/pending/wtf/FastMalloc.h
   D /trunk/src/webkit/pending/wtf/Platform.h
   M /trunk/src/webkit/pending/wtf/RefCounted.h
   A /trunk/src/webkit/pending/wtf/RefPtrHashMap.h (from /branches/chrome_webkit_merge_branch/webkit/pending/wtf/RefPtrHashMap.h:2775)
   A /trunk/src/webkit/pending/wtf/ThreadingWin.cpp (from /branches/chrome_webkit_merge_branch/webkit/pending/wtf/ThreadingWin.cpp:2775)
   M /trunk/src/webkit/port/DerivedSources.make
   M /trunk/src/webkit/port/bindings/scripts/CodeGenerator.pm
   M /trunk/src/webkit/port/bindings/scripts/CodeGeneratorV8.pm
   A /trunk/src/webkit/port/bindings/v8/JSNSResolver.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/bindings/v8/JSNSResolver.cpp:2775)
   A /trunk/src/webkit/port/bindings/v8/JSNSResolver.h (from /branches/chrome_webkit_merge_branch/webkit/port/bindings/v8/JSNSResolver.h:2775)
   M /trunk/src/webkit/port/bindings/v8/V8SVGPODTypeWrapper.h
   A /trunk/src/webkit/port/bindings/v8/V8XMLHttpRequestCustom.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/bindings/v8/V8XMLHttpRequestCustom.cpp:2775)
   M /trunk/src/webkit/port/bindings/v8/np_v8object.cpp
   M /trunk/src/webkit/port/bindings/v8/npruntime_internal.h
   M /trunk/src/webkit/port/bindings/v8/v8_binding.h
   M /trunk/src/webkit/port/bindings/v8/v8_collection.h
   M /trunk/src/webkit/port/bindings/v8/v8_custom.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_custom.h
   M /trunk/src/webkit/port/bindings/v8/v8_events.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_index.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_index.h
   M /trunk/src/webkit/port/bindings/v8/v8_nodefilter.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_nodefilter.h
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.cpp
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.h
   A /trunk/src/webkit/port/bridge/ExceptionContextV8.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/bridge/ExceptionContextV8.cpp:2775)
   M /trunk/src/webkit/port/bridge/FrameWin.cpp
   D /trunk/src/webkit/port/bridge/HistoryWin.cpp
   D /trunk/src/webkit/port/bridge/JSBridge.h
   D /trunk/src/webkit/port/bridge/KJSBridge.cpp
   D /trunk/src/webkit/port/bridge/KJSBridge.h
   A /trunk/src/webkit/port/bridge/ScriptControllerKJS.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/bridge/ScriptControllerKJS.cpp:2775)
   A /trunk/src/webkit/port/bridge/ScriptControllerV8.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/bridge/ScriptControllerV8.cpp:2775)
   D /trunk/src/webkit/port/bridge/V8Bridge.cpp
   D /trunk/src/webkit/port/bridge/V8Bridge.h
   M /trunk/src/webkit/port/css/RGBColor.cpp
   M /trunk/src/webkit/port/css/RGBColor.h
   M /trunk/src/webkit/port/dom/Document.idl
   A /trunk/src/webkit/port/dom/NSResolver.idl (from /branches/chrome_webkit_merge_branch/webkit/port/dom/NSResolver.idl:2775)
   M /trunk/src/webkit/port/history/BackForwardList.h
   M /trunk/src/webkit/port/loader/IconDatabaseNone.cpp
   A /trunk/src/webkit/port/page/AccessibilityObjectWin.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/page/AccessibilityObjectWin.cpp:2775)
   A /trunk/src/webkit/port/page/Console.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/page/Console.cpp:2775)
   M /trunk/src/webkit/port/page/DOMWindow.idl
   M /trunk/src/webkit/port/page/EventHandlerWin.cpp
   M /trunk/src/webkit/port/page/Location.cpp
   M /trunk/src/webkit/port/page/Location.h
   M /trunk/src/webkit/port/page/Navigator.h
   M /trunk/src/webkit/port/page/inspector/InspectorController.cpp
   M /trunk/src/webkit/port/platform/ClipboardUtilitiesWin.cpp
   M /trunk/src/webkit/port/platform/ClipboardUtilitiesWin.h
   M /trunk/src/webkit/port/platform/ClipboardWin.cpp
   M /trunk/src/webkit/port/platform/ClipboardWin.h
   M /trunk/src/webkit/port/platform/Cursor.h
   M /trunk/src/webkit/port/platform/CursorWin.cpp
   M /trunk/src/webkit/port/platform/DragDataWin.cpp
   M /trunk/src/webkit/port/platform/EditorWin.cpp
   M /trunk/src/webkit/port/platform/FileChooserWin.cpp
   M /trunk/src/webkit/port/platform/GKURL.cpp
   M /trunk/src/webkit/port/platform/GKURL_unittest.cpp
   M /trunk/src/webkit/port/platform/MIMETypeRegistry.cpp
   M /trunk/src/webkit/port/platform/MimeTypeRegistryWin.cpp
   M /trunk/src/webkit/port/platform/PasteboardWin.cpp
   M /trunk/src/webkit/port/platform/PlatformScrollBar.h
   M /trunk/src/webkit/port/platform/PlatformScrollBarWin.cpp
   M /trunk/src/webkit/port/platform/PopupMenuWin.cpp
   M /trunk/src/webkit/port/platform/ScrollViewWin.cpp
   D /trunk/src/webkit/port/platform/cairo.h
   M /trunk/src/webkit/port/platform/graphics/AffineTransformSkia.cpp
   A /trunk/src/webkit/port/platform/graphics/ColorSkia.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/ColorSkia.cpp:2775)
   A /trunk/src/webkit/port/platform/graphics/FloatPointSkia.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/FloatPointSkia.cpp:2775)
   A /trunk/src/webkit/port/platform/graphics/FloatRectSkia.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/FloatRectSkia.cpp:2775)
   M /trunk/src/webkit/port/platform/graphics/FontCacheWin.cpp
   M /trunk/src/webkit/port/platform/graphics/FontPlatformData.h
   M /trunk/src/webkit/port/platform/graphics/FontPlatformDataWin.cpp
   M /trunk/src/webkit/port/platform/graphics/FontWin.cpp
   A /trunk/src/webkit/port/platform/graphics/GradientSkia.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/GradientSkia.cpp:2775)
   A /trunk/src/webkit/port/platform/graphics/GraphicsContextPlatformPrivate.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/GraphicsContextPlatformPrivate.cpp:2775)
   A /trunk/src/webkit/port/platform/graphics/GraphicsContextPlatformPrivate.h (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/GraphicsContextPlatformPrivate.h:2775)
   D /trunk/src/webkit/port/platform/graphics/GraphicsContextPrivate.cpp
   D /trunk/src/webkit/port/platform/graphics/GraphicsContextPrivate.h
   M /trunk/src/webkit/port/platform/graphics/GraphicsContextSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/IconWin.cpp
   M /trunk/src/webkit/port/platform/graphics/ImageBufferSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/ImageSourceSkia.cpp
   A /trunk/src/webkit/port/platform/graphics/IntPointSkia.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/IntPointSkia.cpp:2775)
   M /trunk/src/webkit/port/platform/graphics/IntPointWin.cpp
   A /trunk/src/webkit/port/platform/graphics/IntRectSkia.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/IntRectSkia.cpp:2775)
   M /trunk/src/webkit/port/platform/graphics/IntRectWin.cpp
   M /trunk/src/webkit/port/platform/graphics/IntSizeWin.cpp
   M /trunk/src/webkit/port/platform/graphics/PathSkia.cpp
   A /trunk/src/webkit/port/platform/graphics/PatternSkia.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/graphics/PatternSkia.cpp:2775)
   M /trunk/src/webkit/port/platform/graphics/PlatformGraphics.h
   M /trunk/src/webkit/port/platform/graphics/SkGraphicsContext.cpp
   M /trunk/src/webkit/port/platform/graphics/SkiaUtils.cpp
   M /trunk/src/webkit/port/platform/graphics/SkiaUtils.h
   M /trunk/src/webkit/port/platform/graphics/svg/SVGPaintServerGradientSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/svg/SVGPaintServerPatternSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/svg/SVGPaintServerSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/svg/SkiaSupport.cpp
   M /trunk/src/webkit/port/platform/image-decoders/gif/GIFImageDecoder.cpp
   M /trunk/src/webkit/port/platform/image-decoders/ico/ICOImageDecoder.cpp
   M /trunk/src/webkit/port/platform/image-decoders/ico/ICOImageDecoder_unittest.cpp
   M /trunk/src/webkit/port/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
   M /trunk/src/webkit/port/platform/image-decoders/png/PNGImageDecoder.cpp
   A /trunk/src/webkit/port/platform/network/AuthenticationChallenge.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/network/AuthenticationChallenge.cpp:2775)
   A /trunk/src/webkit/port/platform/network/AuthenticationChallenge.h (from /branches/chrome_webkit_merge_branch/webkit/port/platform/network/AuthenticationChallenge.h:2775)
   M /trunk/src/webkit/port/platform/network/CookieJarWin.cpp
   A /trunk/src/webkit/port/platform/network/DNS.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/network/DNS.cpp:2775)
   A /trunk/src/webkit/port/platform/network/NetworkStateNotifierWin.cpp (from /branches/chrome_webkit_merge_branch/webkit/port/platform/network/NetworkStateNotifierWin.cpp:2775)
   A /trunk/src/webkit/port/platform/network/ResourceError.h (from /branches/chrome_webkit_merge_branch/webkit/port/platform/network/ResourceError.h:2775)
   M /trunk/src/webkit/port/platform/network/ResourceRequest.h
   A /trunk/src/webkit/port/plugins (from /branches/chrome_webkit_merge_branch/webkit/port/plugins:2775)
   M /trunk/src/webkit/port/rendering/RenderThemeWin.cpp
   D /trunk/src/webkit/port/xml/XMLHttpRequest.idl
   M /trunk/src/webkit/tools/layout_tests/test_lists/tests_fixable.txt
   M /trunk/src/webkit/tools/layout_tests/test_lists/tests_ignored.txt
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/PluginObject.cpp
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.vcproj
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Merge the chrome_webkit_merge_branch back on to trunk.  This brings us
up to webkit@36102.

------------------------------------------------------------------------
r2761 | sgk@google.com | 2008-10-01 19:41:58 +0200 (Wed, 01 Oct 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/webkit/glue/SConscript

Add the new *accessibility*.cc source files to the SCons build.
Review URL: http://codereview.chromium.org/6042
------------------------------------------------------------------------
r2760 | mark@chromium.org | 2008-10-01 19:40:13 +0200 (Wed, 01 Oct 2008) | 5 lines
Changed paths:
   M /trunk/src/base/event_recorder.cc
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/gfx/vector_canvas_unittest.cc
   M /trunk/src/base/perftimer.cc
   M /trunk/src/base/trace_event.cc
   M /trunk/src/base/trace_event.h
   M /trunk/src/chrome/browser/download/download_file.cc
   M /trunk/src/chrome/browser/download/download_file.h
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/third_party/hunspell/google/hunspell_tests.cc
   M /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   M /trunk/src/chrome/tools/convert_dict/convert_dict.cc
   M /trunk/src/chrome/tools/convert_dict/dic_reader.cc
   M /trunk/src/chrome/tools/test/image_diff/image_diff.cc

Cross-platform wrappers for fopen, _wfopen_s, etc.
Patch by PaweÅ‚ Hajdan jr <phajdan.jr@gmail.com>.

http://codereview.chromium.org/6005

------------------------------------------------------------------------
r2756 | sky@google.com | 2008-10-01 17:21:16 +0200 (Wed, 01 Oct 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc

Fixes a couple of bookmark bar bugs:
. The folders on the bookmark bar now fade in like urls.
. You can now middle click on folders to open all URLs.
. If you attempt to open a folder with more than 15 urls we'll prompt
  before openning.

BUG=242 529 1295385
TEST=middle click on a folder on the bookmark bar and make sure it
  opens all tabs in the background. Try this with a folder containing
  more than 15 bookmarks and make sure you get a message box before
  asking if you really want to open them all.

Review URL: http://codereview.chromium.org/6020
------------------------------------------------------------------------
r2742 | paulg@google.com | 2008-10-01 02:37:18 +0200 (Wed, 01 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h

Change the SafeBrowsing client version to use the proper
Google Chrome version number.
Review URL: http://codereview.chromium.org/6022
------------------------------------------------------------------------
r2738 | klink@chromium.org | 2008-10-01 01:56:50 +0200 (Wed, 01 Oct 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/browser_accessibility.cc
   A /trunk/src/chrome/browser/browser_accessibility.h
   A /trunk/src/chrome/browser/browser_accessibility_manager.cc
   A /trunk/src/chrome/browser/browser_accessibility_manager.h
   A /trunk/src/chrome/browser/iaccessible_function_ids.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   M /trunk/src/chrome/browser/render_widget_host_hwnd.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/build/glue/glue.vcproj
   A /trunk/src/webkit/glue/glue_accessibility.cc
   A /trunk/src/webkit/glue/glue_accessibility.h

Adds MSAA/IAccessible exposure of web content.

Review URL: http://codereview.chromium.org/4057
------------------------------------------------------------------------
r2714 | deanm@chromium.org | 2008-09-30 16:55:27 +0200 (Tue, 30 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc

Use RandUInt64 instead of going from signed to unsigned.
Review URL: http://codereview.chromium.org/6011
------------------------------------------------------------------------
r2697 | mark@chromium.org | 2008-09-30 00:18:01 +0200 (Tue, 30 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   A /trunk/src/base/rand_util.cc
   A /trunk/src/base/rand_util.h
   A /trunk/src/base/rand_util_posix.cc
   A /trunk/src/base/rand_util_unittest.cc
   A /trunk/src/base/rand_util_win.cc
   M /trunk/src/base/sys_info.h
   M /trunk/src/base/sys_info_posix.cc
   M /trunk/src/base/sys_info_unittest.cc
   M /trunk/src/base/sys_info_win.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/importer/importer_unittest.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/common/common.vcproj
   D /trunk/src/chrome/common/env_util.cc
   D /trunk/src/chrome/common/env_util.h
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/process_watcher.cc
   D /trunk/src/chrome/common/rand_util.cc
   D /trunk/src/chrome/common/rand_util.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc

Refactoring for portability:
 - Move chrome/common/env_util to base/sys_info
 - Move chrome/common/rand_util to base/rand_util (new), simplify its public
   interface, and fix its implementation

Patch by Paweł Hajdan, Jr. <phajdan.jr@gmail.com>

http://codereview.chromium.org/4079

------------------------------------------------------------------------
r2691 | darin@google.com | 2008-09-29 23:02:03 +0200 (Mon, 29 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

rollback unintended change
------------------------------------------------------------------------
r2690 | darin@google.com | 2008-09-29 23:01:07 +0200 (Mon, 29 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h

Add a command line switch for fastback work.

patch by abarth@chromium.org

R=darin
BUG=2879


------------------------------------------------------------------------
r2688 | sky@google.com | 2008-09-29 22:33:11 +0200 (Mon, 29 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Fixes crash in NavigationController that occured on closing tab if
only navigation in tab was an interstitial.

BUG=2964
TEST=Drag the following URL into

Review URL: http://codereview.chromium.org/4337
------------------------------------------------------------------------
r2684 | tc@google.com | 2008-09-29 20:45:11 +0200 (Mon, 29 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   A /trunk/src/chrome/test/data/iframe404-inner.html
   A /trunk/src/chrome/test/data/iframe404-inner.html.mock-http-headers
   A /trunk/src/chrome/test/data/iframe404.html
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc

Disable alternate error pages on frames and iframes.  This is
a request from the link doctor team.

Add a UI test that verifies that no link doctor page is loaded.
Review URL: http://codereview.chromium.org/5032
------------------------------------------------------------------------
r2678 | sky@google.com | 2008-09-29 19:43:46 +0200 (Mon, 29 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/cookies_view.cc

Enables sorting of cookie views. Also fixes in bug in deletion that
assumed selection was always contiguous.

BUG=2949
TEST=Go to options->Under the hood->Cookies and make sure sorting the
  columns works. Also make sure deleting deletes the appropriate rows.

Review URL: http://codereview.chromium.org/4328
------------------------------------------------------------------------
r2677 | wtc@google.com | 2008-09-29 19:42:29 +0200 (Mon, 29 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h

Don't use cert_lock_ as a reentrant lock.  RemoveCert is
renamed RemoveCertInternal to stress the fact that it should
be called with the lock held.

Fix miscellaneous nits complained by cpplint.

R=jcampan
Review URL: http://codereview.chromium.org/5024
------------------------------------------------------------------------
r2665 | jar@google.com | 2008-09-28 20:01:34 +0200 (Sun, 28 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/net/base/dns_resolution_observer.cc

Avoid using of interlocked increment to facilitate porting.

The code did not end up needing the use of interlocked operations.
All the initialization is called on one thread (the main thread).

bug=1311434

r=deanm
Review URL: http://codereview.chromium.org/4076
------------------------------------------------------------------------
r2659 | finnur@google.com | 2008-09-27 17:58:49 +0200 (Sat, 27 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc

Enabling test I wrote for Find to catch crash described in issue 1341577.

Review URL: http://codereview.chromium.org/5018
------------------------------------------------------------------------
r2655 | sgk@google.com | 2008-09-27 01:50:21 +0200 (Sat, 27 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/views/SConscript

Catch up SCons Windows build with recent file shuffling and other changes:
* New browser\download\ subdirectory.
* New browser\importer\ subdirectory.
* New browser\views\old_frames subdirectory.
* Add common/notification_registrar.cc.
* Remove title_chomper{,_unittest}.cc.
* Link against sdch where empirically necessary.
* No libevent.lib on Windows, comment out until Linux hits the .dll logic.
Review URL: http://codereview.chromium.org/4310
------------------------------------------------------------------------
r2654 | darin@chromium.org | 2008-09-27 01:40:45 +0200 (Sat, 27 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc

Don't let a malicious web site open an unbounded number of constrained popups.

Patch by abarth@chromium.org

R=ben
BUG=2632

------------------------------------------------------------------------
r2643 | finnur@google.com | 2008-09-26 23:18:39 +0200 (Fri, 26 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Make the link in the About box clickable (Issue 657)

The URL in the About box was added as a last minute string addition. I have now made it clickable. I also converted the TextField for the main label into a regular label, since there is no need to copy anything anylonger. 

Review URL: http://codereview.chromium.org/5013
------------------------------------------------------------------------
r2641 | brettw@google.com | 2008-09-26 23:01:01 +0200 (Fri, 26 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_unittest.cc

Sync the function names. The unit tests overrode this function to prevent interactions with the UI.
Review URL: http://codereview.chromium.org/5011
------------------------------------------------------------------------
r2640 | brettw@google.com | 2008-09-26 22:27:23 +0200 (Fri, 26 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/ipc_status_view.cc

Fix build bustage from my previous renaming.
Review URL: http://codereview.chromium.org/4307
------------------------------------------------------------------------
r2636 | cpu@google.com | 2008-09-26 21:45:48 +0200 (Fri, 26 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

Fix for a crash in the info bubble at first run
- Null deref in GetDefaultSearchEngineName
- This is a stopgap fix

Issue = 2573 

Review URL: http://codereview.chromium.org/4304
------------------------------------------------------------------------
r2634 | brettw@google.com | 2008-09-26 21:30:34 +0200 (Fri, 26 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/view_source_contents.cc
   M /trunk/src/chrome/browser/views/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Reorganize the declarations to have some grouping and logical ordering in tab contents and web contents. Reorder the derived classes overrides to match, and reorder the definitions of the functions to match the order in the header file.

This doesn't actually change any code. I removed a few functions that were declared but never implemented (!) as well as some that were marked vitual but were never overridden. I renamed some things to make them more consistent.
Review URL: http://codereview.chromium.org/5005
------------------------------------------------------------------------
r2633 | jar@google.com | 2008-09-26 20:38:03 +0200 (Fri, 26 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc

Change made based on comment in previous CL (that had already landed).

Add extra check on received dictionary status before saving it for use

r=kmixter,openvcdiff
Review URL: http://codereview.chromium.org/4285
------------------------------------------------------------------------
r2631 | sky@google.com | 2008-09-26 19:45:36 +0200 (Fri, 26 Sep 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/group_table_view.cc
   M /trunk/src/chrome/views/group_table_view.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h
   A /trunk/src/chrome/views/table_view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj

Adds the ability to sort TableView. Contrary to what we spoke about
the other day I ended up doing the sorting in tableview. This makes it
a heck of lot easier than having every model have to deal with it. As
part of this I removed the optional non-caching logic from TableView,
which was never used. Sadly though, this means there are coordinate
transformations.

I've only enabled sorting in the keyword editor, I have to make sure
all the other places that use TableView can deal with it. For example,
task manager can't deal with it currently as it expects the getters to
be called only once where as when sorting they may be called multiple
times.

BUG=2790
TEST=This enables sorting ONLY in the keyword editor. Make sure there
  aren't any problems in adding/removing/changing entries in the
  keyword editor after this.

Review URL: http://codereview.chromium.org/4276
------------------------------------------------------------------------
r2630 | sky@google.com | 2008-09-26 17:24:50 +0200 (Fri, 26 Sep 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/importer/importer.cc

Fixes bug in importer where we could set the default search provider
to one that doesn't support replacement. Also changed uniquing to
consider invalid OSDD urls. Need this to pick up Windows Live Search.

I also changed the ff importer to return out early on if it couldn't
find the value for the search provider. I encountered this do to
hitting a NOTREACHED.

BUG=1507
TEST=In IE set your default search to Live Search. Import from IE and
  make sure Chrome sets the default search to Live Search. Also make
  sure this didn't break keyword importing.

Review URL: http://codereview.chromium.org/4281
------------------------------------------------------------------------
r2623 | jungshik@google.com | 2008-09-26 02:51:06 +0200 (Fri, 26 Sep 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

See if 'charset' is available in HTTP response header and use that to convert the response to UTF-8 before
sending over to JSON deserializer. (previously this issue was tracked internally as issue 1293145)


BUG=2806
TEST=In French Chrome, set your default search engine to Voila and begin to type a word with an accented letters and see
if 'Search Voila for ' contains the word (it's not a bullet-proof test).
In Korean chrome, set the default search engine to Daum and begin to type a Korean word (with Korean IME on, type 'qk').


Review URL: http://codereview.chromium.org/4287
------------------------------------------------------------------------
r2615 | rvargas@google.com | 2008-09-26 01:27:32 +0200 (Fri, 26 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/url_fetcher.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc

Make sure that the request context is released when a URLFetcher is deleted.

BUG=b/1340170
TEST=unittest

Review URL: http://codereview.chromium.org/4077
------------------------------------------------------------------------
r2612 | brettw@google.com | 2008-09-26 00:11:06 +0200 (Fri, 26 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_drop_target.cc

Move a bunch of stuff out of WebContents. I removed a bunch of render view host pass-throughs and just made the callers call the render view host directly. I don't think we're trying to isolate the layers to this degree, and WebContents is so big these just added noise.

I removed the RenderViewHost->WebContents->SavePackage pass-through by using a delegate that the SavePackage implements (like we already do for find in page). I also noticed some file upload stuff wasn't used at all and removed it.
Review URL: http://codereview.chromium.org/4088
------------------------------------------------------------------------
r2611 | maruel@google.com | 2008-09-26 00:08:44 +0200 (Fri, 26 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/base/atomicops_unittest.cc
   M /trunk/src/base/cpu.cc
   M /trunk/src/base/cpu.h
   M /trunk/src/base/gfx/bitmap_platform_device_linux.cc
   M /trunk/src/base/gfx/bitmap_platform_device_linux.h
   M /trunk/src/base/gfx/bitmap_platform_device_win.cc
   M /trunk/src/base/gfx/bitmap_platform_device_win.h
   M /trunk/src/base/gfx/platform_canvas_linux.cc
   M /trunk/src/base/gfx/platform_canvas_linux.h
   M /trunk/src/base/gfx/platform_canvas_win.cc
   M /trunk/src/base/gfx/platform_canvas_win.h
   M /trunk/src/base/gfx/platform_device_linux.cc
   M /trunk/src/base/gfx/platform_device_linux.h
   M /trunk/src/base/gfx/platform_device_win.cc
   M /trunk/src/base/gfx/platform_device_win.h
   M /trunk/src/base/hmac_nss.cc
   M /trunk/src/base/message_pump_libevent.cc
   M /trunk/src/base/message_pump_libevent.h
   M /trunk/src/base/nss_init.cc
   M /trunk/src/base/nss_init.h
   M /trunk/src/base/process_util_posix.cc
   M /trunk/src/base/simple_thread.cc
   M /trunk/src/base/simple_thread.h
   M /trunk/src/base/simple_thread_unittest.cc
   M /trunk/src/base/sys_info_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/gears/SConscript
   M /trunk/src/gears/SConscript.dll
   M /trunk/src/gears/SConscript.googleurl
   M /trunk/src/gears/SConscript.libgd
   M /trunk/src/gears/SConscript.libjpeg
   M /trunk/src/gears/SConscript.libpng
   M /trunk/src/gears/SConscript.portaudio
   M /trunk/src/gears/SConscript.sqlite
   M /trunk/src/gears/SConscript.zlib
   M /trunk/src/gears/SConstruct
   M /trunk/src/net/base/host_resolver_unittest.cc
   M /trunk/src/net/base/platform_mime_util_linux.cc
   M /trunk/src/net/base/scoped_host_mapper.h
   M /trunk/src/net/base/tcp_client_socket_libevent.cc
   M /trunk/src/net/base/test_completion_callback_unittest.cc
   M /trunk/src/sandbox/SConstruct
   M /trunk/src/sandbox/src/unload_dll_test.cc
   M /trunk/src/sdch/SConscript
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/third_party/libevent/SConscript
   M /trunk/src/third_party/libevent/compat/sys/_time.h
   M /trunk/src/third_party/libevent/compat/sys/queue.h
   M /trunk/src/third_party/libevent/evdns.h
   M /trunk/src/third_party/libevent/event-config.h
   M /trunk/src/third_party/libevent/event-internal.h
   M /trunk/src/third_party/libevent/event.h
   M /trunk/src/third_party/libevent/event_rpcgen.py
   M /trunk/src/third_party/libevent/evhttp.h
   M /trunk/src/third_party/libevent/evrpc-internal.h
   M /trunk/src/third_party/libevent/evrpc.h
   M /trunk/src/third_party/libevent/evsignal.h
   M /trunk/src/third_party/libevent/evutil.h
   M /trunk/src/third_party/libevent/http-internal.h
   M /trunk/src/third_party/libevent/linux/config.h
   M /trunk/src/third_party/libevent/log.h
   M /trunk/src/third_party/libevent/min_heap.h
   M /trunk/src/third_party/libevent/strlcpy-internal.h
   M /trunk/src/third_party/libevent/test/regress.gen.h
   M /trunk/src/third_party/libevent/test/regress.h
   M /trunk/src/third_party/libxml/linux/config.h
   M /trunk/src/third_party/libxml/linux/include/libxml/xmlversion.h
   M /trunk/src/third_party/libxslt/linux/config.h
   M /trunk/src/third_party/libxslt/linux/libexslt/exsltconfig.h
   M /trunk/src/third_party/libxslt/linux/libxslt/xsltconfig.h
   M /trunk/src/third_party/libxslt/linux/libxslt/xsltwin32config.h
   M /trunk/src/third_party/scons/scons-LICENSE
   M /trunk/src/third_party/scons/scons-local/SCons/Action.py
   M /trunk/src/third_party/scons/scons-local/SCons/Builder.py
   M /trunk/src/third_party/scons/scons-local/SCons/CacheDir.py
   M /trunk/src/third_party/scons/scons-local/SCons/Conftest.py
   M /trunk/src/third_party/scons/scons-local/SCons/Debug.py
   M /trunk/src/third_party/scons/scons-local/SCons/Defaults.py
   M /trunk/src/third_party/scons/scons-local/SCons/Environment.py
   M /trunk/src/third_party/scons/scons-local/SCons/Errors.py
   M /trunk/src/third_party/scons/scons-local/SCons/Executor.py
   M /trunk/src/third_party/scons/scons-local/SCons/Job.py
   M /trunk/src/third_party/scons/scons-local/SCons/Memoize.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node/Alias.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node/FS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node/Python.py
   M /trunk/src/third_party/scons/scons-local/SCons/Node/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/BoolOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/EnumOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/ListOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/PackageOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/PathOption.py
   M /trunk/src/third_party/scons/scons-local/SCons/Options/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/PathList.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/aix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/cygwin.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/darwin.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/hpux.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/irix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/os2.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/posix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/sunos.py
   M /trunk/src/third_party/scons/scons-local/SCons/Platform/win32.py
   M /trunk/src/third_party/scons/scons-local/SCons/SConf.py
   M /trunk/src/third_party/scons/scons-local/SCons/SConsign.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/C.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/D.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/Dir.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/Fortran.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/IDL.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/LaTeX.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/Prog.py
   M /trunk/src/third_party/scons/scons-local/SCons/Scanner/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/Interactive.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/Main.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/SConsOptions.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/SConscript.py
   M /trunk/src/third_party/scons/scons-local/SCons/Script/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Sig.py
   M /trunk/src/third_party/scons/scons-local/SCons/Subst.py
   M /trunk/src/third_party/scons/scons-local/SCons/Taskmaster.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/386asm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/BitKeeper.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/CVS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/FortranCommon.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/JavaCommon.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/Perforce.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/PharLapCommon.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/RCS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/SCCS.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/Subversion.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixc++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixf77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/aixlink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/applelink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/as.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/bcc32.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/c++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/cc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/cvf.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/default.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dmd.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dvi.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dvipdf.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/dvips.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/f77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/f90.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/f95.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/filesystem.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/fortran.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/g++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/g77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gas.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gfortran.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gnulink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/gs.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/hpc++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/hpcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/hplink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/icc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/icl.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ifl.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ifort.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ilink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/ilink32.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/install.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/intelc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/jar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/javac.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/javah.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/latex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/lex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/link.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/linkloc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/m4.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/masm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/midl.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mingw.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mslib.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mslink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/msvc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/msvs.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mwcc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/mwld.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/nasm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/ipk.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/msi.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/rpm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/src_tarbz2.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/src_targz.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/src_zip.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/tarbz2.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/targz.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/packaging/zip.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/pdf.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/pdflatex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/pdftex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/qt.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/rmic.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/rpcgen.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/rpm.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgiar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgic++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgicc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sgilink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunc++.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/suncc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunf77.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunf90.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunf95.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/sunlink.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/swig.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/tar.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/tex.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/tlib.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/wix.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/yacc.py
   M /trunk/src/third_party/scons/scons-local/SCons/Tool/zip.py
   M /trunk/src/third_party/scons/scons-local/SCons/Util.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/BoolVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/EnumVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/ListVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/PackageVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/PathVariable.py
   M /trunk/src/third_party/scons/scons-local/SCons/Variables/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/Warnings.py
   M /trunk/src/third_party/scons/scons-local/SCons/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/__init__.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_UserString.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_hashlib.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_itertools.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_optparse.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_sets.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_sets15.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_shlex.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_subprocess.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/_scons_textwrap.py
   M /trunk/src/third_party/scons/scons-local/SCons/compat/builtins.py
   M /trunk/src/third_party/scons/scons-local/SCons/cpp.py
   M /trunk/src/third_party/scons/scons-local/SCons/dblite.py
   M /trunk/src/third_party/scons/scons-local/SCons/exitfuncs.py
   M /trunk/src/tools/code_coverage/coverage.py
   M /trunk/src/tools/code_coverage/process_coverage.py
   M /trunk/src/tools/memory_watcher/call_stack.cc
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/SConstruct
   M /trunk/src/webkit/pending/Peerable.h
   M /trunk/src/webkit/pending/WebCoreFrameBridge.h
   M /trunk/src/webkit/port/bindings/v8/v8_collection.h

Wow, it's been a while since we cleaned EOL.

Ran dos2unix on *.cc, *.h, *.py and SCons*.*
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.cc
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.h
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.py
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\SCons*.*


------------------------------------------------------------------------
r2609 | darin@chromium.org | 2008-09-25 23:35:10 +0200 (Thu, 25 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/base/timer.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h

Stop spamming delayed tasks on each input event.

R=mbelshe
BUG=2693

Review URL: http://codereview.chromium.org/4262
------------------------------------------------------------------------
r2605 | finnur@google.com | 2008-09-25 22:55:12 +0200 (Thu, 25 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h

"Make Chrome your default browser" should now appear as a checkbox at the bottom of the First Run dialogs and be opt-out. Therefore I moved it from the FirstRunCustomizeView view to the FirstRunViewBase.

I also moved the override function for GetDialogButtonLabel to the base class (since both dialogs should have the same label for the OK button) and aligned the "Import" label vertically to the "Import" combobox.
Review URL: http://codereview.chromium.org/4244
------------------------------------------------------------------------
r2573 | brettw@google.com | 2008-09-24 23:21:48 +0200 (Wed, 24 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/navigation_types.h

Remove DidNavigate from the tab contents delegate and all the related plumbing.
I added additional information to the regular load commit notification so all
interested parties can listen for that instead.

I removed the old navigation type enum, and replaced it with the enum from
the NavigationController, so it's now public.
Review URL: http://codereview.chromium.org/3112
------------------------------------------------------------------------
r2571 | pkasting@chromium.org | 2008-09-24 22:48:29 +0200 (Wed, 24 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Add a command-line switch to change the user agent.BUG=757345
Review URL: http://codereview.chromium.org/4059
------------------------------------------------------------------------
r2564 | jungshik@google.com | 2008-09-24 21:51:35 +0200 (Wed, 24 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

Disable 'suggest' for voila and orange (both use voila) because the result comes back in ISO-8859-1.
Change the encoding for voila to ISO-8859-1. The front page of Voila.fr is in UTF-8 but the search result pages are
in ISO-8859-1 and voila.fr expects a query to be in ISO-8859-1. 

BUG=2722
TEST=Set your default search engine to voila (in French Chrome) and type a keyword with accented letters. It should come back correctly in the search result page.


Review URL: http://codereview.chromium.org/4068
------------------------------------------------------------------------
r2560 | jcampan@chromium.org | 2008-09-24 20:55:42 +0200 (Wed, 24 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_uitest.cc

Temporarily disabling 2 SSL UI tests because they are flacky.

BUG=2742
TBR=nsylvain
Review URL: http://codereview.chromium.org/4256
------------------------------------------------------------------------
r2558 | darin@chromium.org | 2008-09-24 20:34:43 +0200 (Wed, 24 Sep 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h

If a RenderWidgetHelper::PaintMsgProxy is deleted without being Run, then the
RenderWidgetHelper gets angry.  This change allows the PaintMsgProxy to be
deleted without being Run.

This change is to support deleting all tasks that have made it into a
MessageLoop without being Run.  Currently, we leak those tasks, but I'd like to
change that to allow us to avoid some hacks that exist to help Purify.

R=brettw
BUG=2734

Review URL: http://codereview.chromium.org/4251
------------------------------------------------------------------------
r2553 | jcampan@chromium.org | 2008-09-24 19:42:42 +0200 (Wed, 24 Sep 2008) | 16 lines
Changed paths:
   M /trunk/src/base/observer_list.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/provisional_load_details.cc
   M /trunk/src/chrome/browser/provisional_load_details.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/data/ssl/bad_iframe.html
   A /trunk/src/chrome/test/data/ssl/frame_left.html
   A /trunk/src/chrome/test/data/ssl/frame_right.html
   M /trunk/src/chrome/test/data/ssl/page_with_mixed_contents.html
   A /trunk/src/chrome/test/data/ssl/top_frame.html
   M /trunk/src/webkit/glue/resource_handle_win.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/webresponse.h
   M /trunk/src/webkit/glue/webresponse_impl.h
   M /trunk/src/webkit/port/platform/network/ResourceResponse.h
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc

This CL adds new UI tests for the SSL UI.
Some more info:

SSL UI Tests:
Added new tests for redirects and frames.
Also improved the mixed-content test to exercise the "block mixed-contents" preference and the show info-bar.

Automation:
For the new UI tests, added methods to tab_proxy and browser_proxy. The ones of most interest are GetLastNavigatinTime and WaitForNavigation that ensures we wait for a navigation to occur or have occured when taking actions that asynchronously trigger navigations.

Resource loading:
Added a flag to the response we get when loading a resource that indicates whether that resource was filtered (blocked or altered) by the security peer. We use this flag to notify back the browser when we report a load has been committed.
This is so the SSL manager knows a frame has been filtered (in which case we have no cert info but should not consider that as unsafe).

BUG=2004
Review URL: http://codereview.chromium.org/3165
------------------------------------------------------------------------
r2549 | brettw@google.com | 2008-09-24 18:49:09 +0200 (Wed, 24 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Fix a crash when a frame was inserted into a popup and navigated. I added a
test for this case. I also checked the other navigation cases to see if we
were relying on state from the renderer (which might be malicious) and the
controller being in sync, and I didn't see any others in this area. I clarified
some comments so it should be more clearly correct.

BUG=1279570
Review URL: http://codereview.chromium.org/4250
------------------------------------------------------------------------
r2538 | nick@chromium.org | 2008-09-24 02:50:07 +0200 (Wed, 24 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h

Personalization pointer tweak.

Review URL: http://codereview.chromium.org/4238
------------------------------------------------------------------------
r2536 | jar@google.com | 2008-09-24 02:22:41 +0200 (Wed, 24 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_service.cc

Null out member so that it will be properly reset in StartLogging()

r=petersont
Review URL: http://codereview.chromium.org/4242
------------------------------------------------------------------------
r2529 | jcampan@chromium.org | 2008-09-24 00:59:06 +0200 (Wed, 24 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc

A crasher happens when restoring the focus as a result of switching tab, because the browser window does not have a focus manager.
I am not sure how this could happen, this CL just bullet-proofs the code.

BUG=1384044
Review URL: http://codereview.chromium.org/4054
------------------------------------------------------------------------
r2520 | cpu@google.com | 2008-09-23 22:34:33 +0200 (Tue, 23 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Try to re-land issue 3200
- it was causing trouble in the distributed tests
- now does not try to load the dll in headless configs

Review URL: http://codereview.chromium.org/4233
------------------------------------------------------------------------
r2518 | jcampan@chromium.org | 2008-09-23 22:21:46 +0200 (Tue, 23 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/ie_importer.cc
   M /trunk/src/chrome/browser/importer/ie_importer.h

Removing the check for creation time on favorites when importing with IE.
We were comparing the creation date of the favorite with the profile dir creation date, and ignoring the favorite if they were created around the same time (in an effort to get rid of IE defaults favorites).
This was causing problems as some users seem to import their profile and have profile dir and favorites created at the same time.
Review URL: http://codereview.chromium.org/4207
------------------------------------------------------------------------
r2504 | jcampan@chromium.org | 2008-09-23 20:49:52 +0200 (Tue, 23 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/page_info_window.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webview_delegate.h

This CL enables the Page info menu when right-clicking on a page/frame.
For the frame case, the SSL info had to be added to the show menu message (as the navigation entry contains the top frame SSL info).

BUG=2467
TEST=Open a page over HTTPS with multiple frames. Right-click and select shot page info.
Review URL: http://codereview.chromium.org/4034
------------------------------------------------------------------------
r2501 | joshia@google.com | 2008-09-23 20:32:10 +0200 (Tue, 23 Sep 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Fix bottom right resize corner flicker during size.

Handle WM_NCPAINT and handle it (do nothing) instead of
passing it down to DefWindowProc.

B=2577
TEST=resizing window using botom right corner and watch
for any odd GUI effects. 

Review URL: http://codereview.chromium.org/3192
------------------------------------------------------------------------
r2487 | sky@google.com | 2008-09-23 17:27:22 +0200 (Tue, 23 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Fixes crasher that occurs when using keyboard to navigate focus and
enter triggers a focus change.

BUG=2554
TEST=see bug

Review URL: http://codereview.chromium.org/4014
------------------------------------------------------------------------
r2475 | nsylvain@chromium.org | 2008-09-23 06:20:18 +0200 (Tue, 23 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Once again for a mysterious reason all sites are crashing in 
the distributed test at this location:

chrome_23e0000!v8::internal::Builtins::Setup+0x2bb 

Revert this change because it seems to be the culprit.

Review URL: http://codereview.chromium.org/4206
------------------------------------------------------------------------
r2474 | finnur@google.com | 2008-09-23 05:18:03 +0200 (Tue, 23 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc

Issue 2509: Duplicate tab should not create a new window.

Review URL: http://codereview.chromium.org/3147
------------------------------------------------------------------------
r2469 | jar@google.com | 2008-09-23 03:18:16 +0200 (Tue, 23 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc (from /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc:2445)
   A /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h (from /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h:2445)
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/DEPS
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   A /trunk/src/net/base/sdch_filter.cc
   A /trunk/src/net/base/sdch_filter.h (from /trunk/src/net/base/sdch_filter.h:2445)
   A /trunk/src/net/base/sdch_filter_unitest.cc (from /trunk/src/net/base/sdch_filter_unitest.cc:2445)
   A /trunk/src/net/base/sdch_manager.cc (from /trunk/src/net/base/sdch_manager.cc:2445)
   A /trunk/src/net/base/sdch_manager.h (from /trunk/src/net/base/sdch_manager.h:2445)
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/net.sln
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/webkit.sln
   M /trunk/src/webkit/webkit_kjs.sln

Re-land SDCH filter support experiment

Fix up solution files for webkit and net

Add one line keyword change to help linux build

r=hunanr,openvcdiff,nsylvain
Review URL: http://codereview.chromium.org/4026
------------------------------------------------------------------------
r2467 | cpu@google.com | 2008-09-23 03:04:50 +0200 (Tue, 23 Sep 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/rlz/rlz.cc

Load RLZ in 20 seconds instead of 100 seconds.
- And have a way to set the initial events even if chrome
  was shut down before it was able to initialize and
  thus we have an empty rlz.

Apparently a sizeable % of our users have an empty
rlz string and it looks like this can be the cause.

BUG= 1372961

Review URL: http://codereview.chromium.org/3200
------------------------------------------------------------------------
r2465 | mal@chromium.org | 2008-09-23 02:51:37 +0200 (Tue, 23 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Revert r2253 to turn off magic_browzR by default and restore the
--magic_browzR command line switch.

R= ben@chromium.org
Review URL: http://codereview.chromium.org/4031
------------------------------------------------------------------------
r2458 | sky@google.com | 2008-09-23 00:23:43 +0200 (Tue, 23 Sep 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h

I'm going to try and land this again. This is exactly the same change as you reviewed earlier.

Fixes mnemonic bug in chrome menus. After this change you can indicate
whether menus have mnemonics. Mnemonics are shown if the menus have
mnemonics, and the OS says we should show them.

BUG=1355952
TEST=add a bookmark and change the title to &foo. Move the bookmark to
  a folder, click on the folder and make sure the title shows the &.

Review URL: http://codereview.chromium.org/4021
------------------------------------------------------------------------
r2457 | finnur@google.com | 2008-09-23 00:12:28 +0200 (Tue, 23 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs.cc

Fix for issue 2617: After using Ctrl+O to open a local file the directory is locked.

Review URL: http://codereview.chromium.org/3194
------------------------------------------------------------------------
r2446 | jar@google.com | 2008-09-22 20:21:11 +0200 (Mon, 22 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   D /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   D /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/DEPS
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   M /trunk/src/net/base/sdch_filter.cc
   D /trunk/src/net/base/sdch_filter.h
   D /trunk/src/net/base/sdch_filter_unitest.cc
   D /trunk/src/net/base/sdch_manager.cc
   D /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h

Rollback 2444 and 2443 to get linux and mac prep

Also need to augment sln dependencies

tbr
Review URL: http://codereview.chromium.org/3188
------------------------------------------------------------------------
r2445 | sky@google.com | 2008-09-22 20:08:59 +0200 (Mon, 22 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h

Reverts fix for 2554.


Review URL: http://codereview.chromium.org/4017
------------------------------------------------------------------------
r2443 | jar@google.com | 2008-09-22 19:24:28 +0200 (Mon, 22 Sep 2008) | 21 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc
   A /trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   A /trunk/src/net/base/sdch_filter.cc
   A /trunk/src/net/base/sdch_filter.h
   A /trunk/src/net/base/sdch_filter_unitest.cc
   A /trunk/src/net/base/sdch_manager.cc
   A /trunk/src/net/base/sdch_manager.h
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h

Experimental integration of delta compression content encoding


The command line option "sdch-enable" enables support of sdch
and automtic lazy download of dictionaries.  Optionally it
can select a singular domain to work from.

By default, all domains are enabled when the flag is used.
"-sdch-enable=".google.com"  Enables it only for Google.

When the switch is not set on the command line, all this
code is completely disabled.

Still TBD:
a) Finish implementation of security details (much of it is in place)
b) Add tests for security details.


r=huanr,ajenjo,kmixter

Review URL: http://codereview.chromium.org/461
------------------------------------------------------------------------
r2442 | sky@google.com | 2008-09-22 19:21:04 +0200 (Mon, 22 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h

Fixes mnemonic bug in chrome menus. After this change you can indicate
whether menus have mnemonics. Mnemonics are shown if the menus have
mnemonics, and the OS says we should show them.

BUG=1355952
TEST=add a bookmark and change the title to &foo. Move the bookmark to
  a folder, click on the folder and make sure the title shows the &.

Review URL: http://codereview.chromium.org/4002
------------------------------------------------------------------------
r2441 | cpu@google.com | 2008-09-22 19:11:04 +0200 (Mon, 22 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/sandbox_policy.h

Use the new dll injection blocking api of the sandbox to block
the loading of dlls that cause renderer crashes.
- Remove the old FreeLibrary() method

Review URL: http://codereview.chromium.org/2458
------------------------------------------------------------------------
r2437 | deanm@chromium.org | 2008-09-20 13:42:49 +0200 (Sat, 20 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Cleanup EOL and include guards, including fixing one guard that was not the correct path.  Lack of EOL on bloom_filter.h had broken the Linux build, this is a fatal warning with GCC.
Review URL: http://codereview.chromium.org/4007
------------------------------------------------------------------------
r2434 | paulg@google.com | 2008-09-20 04:03:08 +0200 (Sat, 20 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_impl_unittest.cc (from /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc:2429)
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Create a SafeBrowsing database interface to more easily
facilitate alternate implementations.

The current SafeBrowsingDatabase code is moved to *_impl files.
Adding a new implementation can be done via command line flags
in the SafeBrowsingDatabase::Create factory method.
Review URL: http://codereview.chromium.org/3162
------------------------------------------------------------------------
r2433 | nsylvain@chromium.org | 2008-09-20 03:55:50 +0200 (Sat, 20 Sep 2008) | 22 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Revert change 2419 because it breaks the build

The stack crashing is this one:
chrome_2650000!xmlTextWriterStartElement+0x23
chrome_2650000!MetricsLog::StartElement+0xb5
chrome_2650000!MetricsLog::ScopedElement::ScopedElement+0x67
chrome_2650000!MetricsLog::RecordHistogramDelta+0xd8
chrome_2650000!MetricsService::RecordHistogram+0x122
chrome_2650000!MetricsService::RecordCurrentHistograms+0xc3
chrome_2650000!MetricsService::StopRecording+0x94
chrome_2650000!MetricsService::PushPendingLogsToUnsentLists+0xbf
chrome_2650000!MetricsService::SetRecording+0x36f
chrome_2650000!MetricsService::Stop+0x11
chrome_2650000!BrowserMain+0xefa
chrome_2650000!ChromeMain+0x862

It looks like writer_ is null on invalid.

It also look like there is debugging code that was left
in.

Review URL: http://codereview.chromium.org/4005
------------------------------------------------------------------------
r2426 | pkasting@chromium.org | 2008-09-20 00:36:33 +0200 (Sat, 20 Sep 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc

Stop exposing manually_selected_match_ outside the AutocompletePopupModel.  The main goal of this is to be a first step towards divorcing the popup and the edit from each other.

To do this, I changed the behavior of manual selections.  They now do not persist once the user types more characters, hits esc, etc.  Our old behavior, which Brett and I designed long ago, turns out to have been a mistake; users who arrowed to an item and then typed more weren't expecting "stickiness" on their previous choice, and it led to user mistakes.

This also required changing how we do the "keyword UI" persistence in the case where the user switches into keyword UI, but then deletes all his text.  Previously, we used manually_selected_match_ with a provider affinity to the keyword provider in order to accomplish this.  Now we stick another flag on the AutocompleteInput, which, when set, biases the keyword provider to return the best results.  The user-visible effect of this is that when in keyword UI mode with no query string, the selected entry in the popup will be the first, rather than third, entry.  This is a small win.

While here I fixed the bug where editing a string and transforming it into a keyword search would avoid switching into keyword UI (as expected), but also delete the keyword off the visible string (oops).  I also made us lock the popup once the user changes the manually_selected_match_, in order to give a little more stability to it.

I'm sorry this makes so many behavioral changes at once.  All this code is tangled together and untangling it is hard :(

The keyword-related variables in the AutocompleteEditModel seem a mess.  They are probably worse now than before this change; I think I need a followup change at some point to make them all more sane.  It seems like we have three variables and complex conditionals where two, and simpler ones, would do.

BUG=997976,1201974,1204173
Review URL: http://codereview.chromium.org/3172
------------------------------------------------------------------------
r2419 | petersont@google.com | 2008-09-19 22:36:59 +0200 (Fri, 19 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

This is the same change as issue 1633 ( http://codereview.chromium.org/1633 ) together with the disabling of a test called MetricsServiceTest.CloseRenderersNormally which the change makes obsolete (see bug 2522.)

Review URL: http://codereview.chromium.org/2995
------------------------------------------------------------------------
r2417 | finnur@google.com | 2008-09-19 22:10:23 +0200 (Fri, 19 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h

Landing a patch for Adam. See http://codereview.chromium.org/3136 for details.

TBR=abarth

Review URL: http://codereview.chromium.org/2996
------------------------------------------------------------------------
r2414 | zork@google.com | 2008-09-19 20:42:46 +0200 (Fri, 19 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc

Adding a CPAPI function to make a function call asynchonously on the plugin thread.
Review URL: http://codereview.chromium.org/2969
------------------------------------------------------------------------
r2413 | sky@google.com | 2008-09-19 20:33:48 +0200 (Fri, 19 Sep 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/importer/importer.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Changes the bookmark model to allow more than one bookmark to
reference the same url. Clicking the star button edits the most
recently added bookmark for the URL. Dragging a button/star always
does a move, otherwise drops on the bookmark bar create a new
bookmark.

Also changed the add page context menu for the bookmark bar to
remember where you invoked it from.

BUG=1173228 1678

Review URL: http://codereview.chromium.org/3203
------------------------------------------------------------------------
r2411 | finnur@google.com | 2008-09-19 19:26:37 +0200 (Fri, 19 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc

Attempt at fixing flaky Find test.

The waterfall (build.chromium.org) has been complaining about this test for a while now. Nicolas and I looked at this, but we don't see anything wrong. We theorized this is because we issue Find right after the navigation and maybe the tab isn't ready. We'll see what happens with this change.

Review URL: http://codereview.chromium.org/2978
------------------------------------------------------------------------
r2408 | deanm@google.com | 2008-09-19 17:58:55 +0200 (Fri, 19 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/cross_site_request_manager.h
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/chrome/browser/metrics_log.h
   M /trunk/src/chrome/browser/metrics_response_unittest.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/printing/page_number.h
   M /trunk/src/chrome/browser/printing/page_range_unittest.cc
   M /trunk/src/chrome/browser/printing/units_unittest.cc
   M /trunk/src/chrome/browser/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_security_policy.h
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/common/animation_unittest.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/sqlite_utils.h

Build a bunch more of chrome/ on Linux.

Patch from Pawel Hajdan Jr.
------------------------------------------------------------------------
r2374 | erikkay@google.com | 2008-09-18 21:28:45 +0200 (Thu, 18 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/test/data/purify/unit_tests.exe_MLK_flakey.txt

Fix an old leak in tab_strip_model_unittest which had recently contributed to a new leak showing up.  The leak was caused by not cleaning up after ReplaceTabContents.
Review URL: http://codereview.chromium.org/2954
------------------------------------------------------------------------
r2366 | brettw@google.com | 2008-09-18 19:53:23 +0200 (Thu, 18 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

NULL check the return value during navigation to prevent a crash.

BUG=1384003
Review URL: http://codereview.chromium.org/2966
------------------------------------------------------------------------
r2361 | deanm@chromium.org | 2008-09-18 14:56:04 +0200 (Thu, 18 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc

Enable safe browsing tests exercising VerifyMAC.  Reorder libraries to match the dependency order required on Posix.

Patch from Pawel Hajdan Jr.
Review URL: http://codereview.chromium.org/3143
------------------------------------------------------------------------
r2360 | deanm@chromium.org | 2008-09-18 14:44:40 +0200 (Thu, 18 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc

Fix a typo in r2358.
Review URL: http://codereview.chromium.org/3142
------------------------------------------------------------------------
r2358 | deanm@chromium.org | 2008-09-18 14:18:14 +0200 (Thu, 18 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/base/sys_info.h
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/common/env_util.cc
   M /trunk/src/chrome/common/env_util.h

Add cross platform base::SysInfo::AmountOfPhysicalMemoryMB to replace the Windows only env_util::GetPhysicalMemoryMB.

From Seo Sanghyeon.
Review URL: http://codereview.chromium.org/2962
------------------------------------------------------------------------
r2355 | ben@chromium.org | 2008-09-18 05:47:18 +0200 (Thu, 18 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Add some padding between the right edge of the new tab button and the left edge of the window controls.

http://crbug.com/2451

Review URL: http://codereview.chromium.org/3130
------------------------------------------------------------------------
r2354 | ben@chromium.org | 2008-09-18 05:47:13 +0200 (Thu, 18 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Make sure window controls in maximized browser windows can be hit-tested as the appropriate HTCLOSE HTMINBUTTON etc types. Buggy code would previously prevent this from happening by detecting the entire area to the right of the tabstrip as being part of the caption.

http://crbug.com/2449

Review URL: http://codereview.chromium.org/2955
------------------------------------------------------------------------
r2344 | nsylvain@chromium.org | 2008-09-18 02:06:00 +0200 (Thu, 18 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/importer/importer_unittest.cc

Disable part of the Importer unit test because it fails
on windows sp3 (clean machine).

See bug 2466.

Review URL: http://codereview.chromium.org/3127
------------------------------------------------------------------------
r2337 | erg@google.com | 2008-09-18 00:25:33 +0200 (Thu, 18 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_view.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_tab_view.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/old_frames/frame_view.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/page_info_window.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/border.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/checkbox.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/chrome/views/combo_box.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/grid_layout.cc
   M /trunk/src/chrome/views/grid_layout_unittest.cc
   M /trunk/src/chrome/views/image_view.cc
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/painter.h
   M /trunk/src/chrome/views/radio_button.cc
   M /trunk/src/chrome/views/resize_corner.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/separator.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window.cc

Rename legacy methods that were in CamelCase to unix_hacker.
Required going through and modifying some of the code to 
solve name clashes.

Review URL: http://codereview.chromium.org/2945
------------------------------------------------------------------------
r2334 | finnur@google.com | 2008-09-18 00:04:06 +0200 (Thu, 18 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Fix for issue 2362: On-demand update hang with "Checking for update..."

We have been restructuring the message loop code lately and the MessageLoop on the file thread is not dispatching messages as it was before. I have changed the file thread to start with type MessageLoop::TYPE_IO, which pumps messages in such a way that Google Update can communicate back to us. 

I'm not sure what the best way to test this is but I ran the UI tests and the unit tests and they all pass.
Review URL: http://codereview.chromium.org/2918
------------------------------------------------------------------------
r2323 | pkasting@chromium.org | 2008-09-17 22:05:44 +0200 (Wed, 17 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/url_request/url_request_http_job.cc

Don't set any cookies as a result of the Google URL Tracker update check.  This way, if users clear their cookies and restart, they won't have to wonder why a Google cookie has suddenly mysteriously appeared.

BUG=1204
Review URL: http://codereview.chromium.org/2937
------------------------------------------------------------------------
r2322 | sidchat@google.com | 2008-09-17 22:02:04 +0200 (Wed, 17 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu.h
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/renderer/spellcheck_unittest.cc
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.cxx
   M /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.hxx

Add support for "Add to dictionary" in the context menu.
Review URL: http://codereview.chromium.org/2446
------------------------------------------------------------------------
r2319 | tc@google.com | 2008-09-17 20:16:01 +0200 (Wed, 17 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
   M /trunk/src/chrome/test/unit/run_all_unittests.cc

Include chrome SConscript.unit_tests in Linux build.

BUG=2335

Original patch by phajdan.jr@gmail.com in
http://codereview.chromium.org/2891

R=mark,sgk
Review URL: http://codereview.chromium.org/2939
------------------------------------------------------------------------
r2317 | tc@google.com | 2008-09-17 19:45:02 +0200 (Wed, 17 Sep 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/printing/page_number.cc
   M /trunk/src/chrome/browser/printing/page_setup.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h

Include chrome/browser/SConscript in Linux build.

In dns_host_info.cc there was probably a bug (hardcoded 1
instead of length.

BUG=2333
R=mark,sgk

Original patch by phajdan.jr@gmail.com at:
http://codereview.chromium.org/2890

Review URL: http://codereview.chromium.org/3108
------------------------------------------------------------------------
r2313 | brettw@google.com | 2008-09-17 19:16:24 +0200 (Wed, 17 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/provisional_load_details.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/common/notification_types.h

Delete the provisional load commit notification since it duplicates the nav entry committed notification.

I had to add some more stuff to the nav entry committed structure which now looks suspiciously like the provisional load details structure. I'll see how I can improve this in a future pass.

I used the new NotificationRegistrar to automatically unregister for notifications in the SSL manager, which reduces some code.
Review URL: http://codereview.chromium.org/3095
------------------------------------------------------------------------
r2310 | sky@google.com | 2008-09-17 18:28:49 +0200 (Wed, 17 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/common/notification_types.h

Wires up session restore so that it correctly deals with the
navigation controller removing entries from the front of its list.

BUG=1324021
TEST=covered by unit tests, but make sure you don't see problems with
  session restore.

Review URL: http://codereview.chromium.org/2906
------------------------------------------------------------------------
r2299 | beng@google.com | 2008-09-17 06:35:48 +0200 (Wed, 17 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   D /trunk/src/chrome/browser/views/window_resources.cc
   M /trunk/src/chrome/browser/views/window_resources.h
   M /trunk/src/chrome/views/custom_frame_window.cc

Don't load the font for the window title if we're not going to be painting a text title bar... ie. don't load the font for the title bar for the main browser window since we won't use it - it's only used for app windows.

http://crbug.com/2369

Review URL: http://codereview.chromium.org/2919
------------------------------------------------------------------------
r2298 | beng@google.com | 2008-09-17 06:34:03 +0200 (Wed, 17 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/test/accessibility/constants.h

Re-land this fix from earlier. Since I was making the tab icon view optional, I needed to adjust the accessibility tests so that they use the right index.

Don't initialize the TabIconView if we don't need to. It's expensive to create.

http://crbug/2369

------------------------------------------------------------------------
r2297 | finnur@google.com | 2008-09-17 05:16:38 +0200 (Wed, 17 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

According to reports in the field, some XP machines have a registry flag that says "Disable UAC". Possibly, this is governed by a policy setting on corporate networks.

In any case, this causes the About box to think we can't perform on-demand updates. We should never block on-demand updates on XP.

Review URL: http://codereview.chromium.org/2901
------------------------------------------------------------------------
r2295 | beng@google.com | 2008-09-17 03:09:50 +0200 (Wed, 17 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Roll back this fix until I can figure out why it;s crashing the ui tests

------------------------------------------------------------------------
r2294 | beng@google.com | 2008-09-17 02:35:26 +0200 (Wed, 17 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Don't initialize the TabIconView if we don't need to. It's expensive to create.

http://crbug.com/2369

Review URL: http://codereview.chromium.org/2917
------------------------------------------------------------------------
r2292 | beng@google.com | 2008-09-17 02:12:08 +0200 (Wed, 17 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Revert this earlier fix since it didn't do any good.

------------------------------------------------------------------------
r2291 | wtc@google.com | 2008-09-17 01:19:34 +0200 (Wed, 17 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_policy.cc

Always block the request for a sub-resource with an
SSL certificate error.

R=abarth,jcampan
BUG=2316
Review URL: http://codereview.chromium.org/3091
------------------------------------------------------------------------
r2290 | sky@google.com | 2008-09-17 01:17:01 +0200 (Wed, 17 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmarks/bookmark_model.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/history/history.cc

Adds logging of loading/saving bookmarks to help me diagnose why some
folks are having problems.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2914
------------------------------------------------------------------------
r2289 | sky@google.com | 2008-09-17 01:15:30 +0200 (Wed, 17 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc

Fixed bookmark bubble bug. If you changed the title, then clicked edit
the title would revert.

BUG=1353834
TEST=Create a bookmark, on the bubble type in a new name, click edit
  and make sure the editor that pops up has the name you just typed in.

Review URL: http://codereview.chromium.org/3093
------------------------------------------------------------------------
r2285 | beng@google.com | 2008-09-16 23:28:24 +0200 (Tue, 16 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Attempt to reduce startup regression by deferring load of inactive window bitmaps until they're actually needed.

http://crbug.com/2369

Review URL: http://codereview.chromium.org/2907
------------------------------------------------------------------------
r2279 | brettw@google.com | 2008-09-16 23:00:48 +0200 (Tue, 16 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h

Remove the rest of the alternate nav url fetcher from the navigation controller.
This changes the memory model around a bit, and it's not the most clear thing
ever, not that it was before. The alternate URL fetcher is now responsible for
deleting itself in most cases.

BUG=2370 (Assertion when using the alternate URL tracker twice in a row)
BUG=1324500 (Move the AlternateNavURLFetcher logic out of NavigationController)
Review URL: http://codereview.chromium.org/2905
------------------------------------------------------------------------
r2278 | jhaas@chromium.org | 2008-09-16 22:41:22 +0200 (Tue, 16 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h

Added code for personalization to the new frame class

Review URL: http://codereview.chromium.org/3074
------------------------------------------------------------------------
r2276 | brettw@google.com | 2008-09-16 22:16:08 +0200 (Tue, 16 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/notification_registrar.cc
   A /trunk/src/chrome/common/notification_registrar.h

Remove an explicit call from the NavigationController to the alternate URL
fetcher since there is already a notification that does this.

I created a class that will automatically unregister for notifications when it
goes out of scope and used it here. I think it will be useful for most consumers
of notifications.
Review URL: http://codereview.chromium.org/2895
------------------------------------------------------------------------
r2266 | joshia@google.com | 2008-09-16 19:39:00 +0200 (Tue, 16 Sep 2008) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   M /trunk/src/chrome/browser/render_widget_host_hwnd.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/views/focus_manager.cc

Touchpad support for laptops

This fix is a workaround to receive mouse wheel and scroll messages 
from synaptics touchpad driver used in majority of laptops. 

Removed fake scroll bars in RenderWidgetHostHwnd so that it can now
receive mouse wheel messages from synaptics drivers for Dell, Toshiba 
laptops. 

Added fake scroll bars to WebContents so that it can receive scroll
messages. WebContents then reflects scroll messages to the view to
give it a chance to handle them.


BUG=4

TEST=Touchpad scrolling and zooming (control + scroll) on various laptops.


Review URL: http://codereview.chromium.org/2878
------------------------------------------------------------------------
r2261 | sky@google.com | 2008-09-16 17:22:48 +0200 (Tue, 16 Sep 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/download/save_file_manager.cc
   M /trunk/src/chrome/browser/download/save_package.cc
   M /trunk/src/chrome/browser/download/save_package.h

Fixes two crashers in saving page:
1. GetTabID was being called AFTER the process was destroyed, which
   means we could try and deref NULL. By caching the value we don't
   have to worry about whether the web contents goes away or not.
2. A PostTask was done, then we assumed the SaveItem still
   exists. That isn't the case if the user canceled the save.

BUG=2206
TEST=none, just make sure save page as still works correctly.

Review URL: http://codereview.chromium.org/3034
------------------------------------------------------------------------
r2255 | beng@google.com | 2008-09-16 02:37:56 +0200 (Tue, 16 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab.cc
   M /trunk/src/chrome/browser/views/tabs/tab.h
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_unittest.cc

Allow Views to support an optional hit-test mask. Make hittest use this.
Make GetViewForPoint call HitTest instead of rolling its own crude hit testing.
Update custom-shaped views to use this framework instead of overriding hittest themselves.

B=2273

Review URL: http://codereview.chromium.org/3051
------------------------------------------------------------------------
r2254 | tim@chromium.org | 2008-09-16 02:37:37 +0200 (Tue, 16 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/test/testing_profile.h

Remove registration step between NavigationController > Profile.
No code path requires NavigationControllers to register themselves
with a profile. We won't need this moving forward, either. 

Review URL: http://codereview.chromium.org/2869
------------------------------------------------------------------------
r2253 | beng@google.com | 2008-09-16 02:18:56 +0200 (Tue, 16 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Turn on the magic frames.

B=1031854
Review URL: http://codereview.chromium.org/3063
------------------------------------------------------------------------
r2252 | wtc@google.com | 2008-09-16 02:14:56 +0200 (Tue, 16 Sep 2008) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_policy.cc

In DefaultPolicy::OnCertError, if a cert error is allowed,
we should skip the code that determines what to do about
a sub-resource.  This is because in some HTTPS
implementations, we continue to get errors on a cert after
we have ignored that cert's errors.  The current code works
with WinHTTP because WinHTTP stops sending errors on a cert
after we have ignored that cert's errors.  This changelist
allows the code to work with both kinds of HTTPS
implementations.

Fix nits (extra semicolons and insufficient whitespace)
reported by cpplint.py.

R=abarth,jcampan
BUG=1272567
Review URL: http://codereview.chromium.org/2816
------------------------------------------------------------------------
r2251 | beng@google.com | 2008-09-16 02:10:43 +0200 (Tue, 16 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Fix bug where bookmark bar wouldn't animate away but would rather snap closed (new frames)

B=1031854
Review URL: http://codereview.chromium.org/3052
------------------------------------------------------------------------
r2247 | brettw@google.com | 2008-09-16 01:44:14 +0200 (Tue, 16 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Try again to fix the memory problems in NavigationController. The previous one
issued a DCHECK when I manlually deleted the NavigationController because the
tabs were still there. Calling destroy fixes this, although I have to manually
NULL out some test pointers to prevent double-frees.
Review URL: http://codereview.chromium.org/3070
------------------------------------------------------------------------
r2246 | zork@google.com | 2008-09-16 01:43:42 +0200 (Tue, 16 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h

Adding sync plugin messages, and plugin broadcasts to the renderer processes

Review URL: http://codereview.chromium.org/2411
------------------------------------------------------------------------
r2239 | brettw@google.com | 2008-09-15 23:57:21 +0200 (Mon, 15 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Revert my last fix for a memory leak in the navigation controller tests. This
causes an assertion in debug mode. I think this needs to be done another way.
Review URL: http://codereview.chromium.org/2873
------------------------------------------------------------------------
r2237 | brettw@google.com | 2008-09-15 22:47:53 +0200 (Mon, 15 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Fix a leak in the unit tests.
Review URL: http://codereview.chromium.org/3067
------------------------------------------------------------------------
r2233 | pkasting@chromium.org | 2008-09-15 22:33:14 +0200 (Mon, 15 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model.h

Fix unittest bustage due to NULL pointer deref (only in unittest mode, I hope).

Also commit some comment changes which were supposed to go in my original patch but missed it.

TBR=sky
BUG=1291

Review URL: http://codereview.chromium.org/2870
------------------------------------------------------------------------
r2223 | pkasting@chromium.org | 2008-09-15 20:28:09 +0200 (Mon, 15 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/common/notification_types.h

Make the GoogleURLTracker only fetch the Google hostname if the user's default search engine is Google.  Our existing restrictions still apply: no fetches before five seconds after startup, and no more than one fetch per run.

Because of lazy initialization everywhere, this was hairier than I'd hoped.  We have to ensure we don't try to fetch until the profile has been created, lest GetDefaultRequestContext() return NULL.  Note that this was actually a bug in the existing product: if you set your startup page to, say, about:blank, and started the browser and did nothing at all for five seconds, we'd crash.

BUG=1291
Review URL: http://codereview.chromium.org/1942
------------------------------------------------------------------------
r2222 | tc@google.com | 2008-09-15 20:20:54 +0200 (Mon, 15 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add preferences for the clear browsing data dialog so that
the user choices are persistent.

Patch by Arthur Lussos <developer0420@gmail.com>
Original issue at http://codereview.chromium.org/3014

Review URL: http://codereview.chromium.org/3059
------------------------------------------------------------------------
r2220 | brettw@google.com | 2008-09-15 20:13:29 +0200 (Mon, 15 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Remove the unneeded pending entry from the unit tests.
Review URL: http://codereview.chromium.org/2859
------------------------------------------------------------------------
r2210 | beng@google.com | 2008-09-15 08:34:12 +0200 (Mon, 15 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc

Occasionally GetLastActiveBrowserWindow fails on the build bots, probably because of the locked desktop. Replace this call in the non-interactive ui tests with a call to GetBrowserWindow(0), which is what GetActiveTab (called a few lines earlier) does anyway.

B=2235

Review URL: http://codereview.chromium.org/2844
------------------------------------------------------------------------
r2209 | beng@google.com | 2008-09-15 00:55:00 +0200 (Mon, 15 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc

Hit test zone for the new tab button should follow its visible shape.

B=2270
Review URL: http://codereview.chromium.org/2843
------------------------------------------------------------------------
r2208 | beng@google.com | 2008-09-15 00:50:33 +0200 (Mon, 15 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/test/accessibility/constants.h

Revert these changes now the experiment is complete.

------------------------------------------------------------------------
r2207 | beng@google.com | 2008-09-14 23:53:58 +0200 (Sun, 14 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/test/accessibility/constants.h

Yet another test, this time with a tweak to the find test.

------------------------------------------------------------------------
r2206 | brettw@google.com | 2008-09-14 23:29:30 +0200 (Sun, 14 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_unittest.cc

Fix a debug assertin when running the web contents unit test. The error is in
the test since it would give the same page ID to two different pages in the
same site instance, which should not happen.
Review URL: http://codereview.chromium.org/2842
------------------------------------------------------------------------
r2205 | beng@google.com | 2008-09-14 22:54:35 +0200 (Sun, 14 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc

A couple of tweaks to the AeroGlassNonClientView:
- fix broken window resizing using the sizing borders... || should have been an &&, resulted in all non-client areas being treated as window caption.
- use the width of the client view to size the tabstrip rather than the width of the non-client view. this was causing the new tab button to be clipped.

B=2218,2267
Review URL: http://codereview.chromium.org/2841
------------------------------------------------------------------------
r2204 | beng@google.com | 2008-09-14 22:53:47 +0200 (Sun, 14 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Roll back frame test now buildbots have cycled.

------------------------------------------------------------------------
r2203 | beng@google.com | 2008-09-14 22:07:33 +0200 (Sun, 14 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Test frames on the builders again to see if notification change helped.
------------------------------------------------------------------------
r2202 | beng@google.com | 2008-09-14 22:07:29 +0200 (Sun, 14 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Include the area to the right of the tabstrip underneath the window controls in the window caption area.

B=1031854
Review URL: http://codereview.chromium.org/2840
------------------------------------------------------------------------
r2201 | brettw@google.com | 2008-09-14 17:42:43 +0200 (Sun, 14 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service_test_helper.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/common/render_messages.h

This is almost a complete rewrite of DidNavigate and the associated NavigationController logic. The approach is that the NavigationController should be responsible for the logic and memory management of navigation. Previously, half the logic and memory management lived in WebContents which made it very hard to figure out what was going on.

I split out the various navigation types into separate functions, which then copy and update any existing NavigationEntry as necessary. Previously, WebContents would make a new one which would be manually populated with random fields (I think some were forgotten, too), and then the NavigationController may or may not commit it.

Review URL: http://codereview.chromium.org/479
------------------------------------------------------------------------
r2188 | beng@google.com | 2008-09-14 06:37:29 +0200 (Sun, 14 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Roll back frames now test run is complete.

B=1031854

------------------------------------------------------------------------
r2183 | beng@google.com | 2008-09-14 05:40:38 +0200 (Sun, 14 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h

Test new frames on buildbots again.

B=1031854
------------------------------------------------------------------------
r2180 | beng@google.com | 2008-09-14 04:31:13 +0200 (Sun, 14 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Fix interactive UI tests...

- in the UI tests, SimulateOSClick was taking screen coordinates and the browser automation provider was treating them as client. For a click, screen coordinates seems better and is what most users were sending. This was causing the focus tests to fail since tabs weren't getting clicked on. Not sure why this wasn't affecting non-new-frames!
- a math error in BrowserView2 was leading to incorrect window sizing in constrained window tests.
- new frames mean layout is slightly different, and a constant in the constrained window test needed to be adjusted.

Review URL: http://codereview.chromium.org/2828
------------------------------------------------------------------------
r2177 | beng@google.com | 2008-09-14 04:11:30 +0200 (Sun, 14 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/accessibility/constants.h

Get the new frames to pass the accessibility UI tests.

B=2235

Review URL: http://codereview.chromium.org/3039
------------------------------------------------------------------------
r2176 | paulg@google.com | 2008-09-14 03:43:24 +0200 (Sun, 14 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.cc

Fix an include path.
Review URL: http://codereview.chromium.org/3041
------------------------------------------------------------------------
r2174 | paulg@google.com | 2008-09-14 03:09:50 +0200 (Sun, 14 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/download/save_file.cc (from /trunk/src/chrome/browser/save_file.cc:2173)
   A /trunk/src/chrome/browser/download/save_file.h (from /trunk/src/chrome/browser/save_file.h:2173)
   A /trunk/src/chrome/browser/download/save_file_manager.cc (from /trunk/src/chrome/browser/save_file_manager.cc:2173)
   A /trunk/src/chrome/browser/download/save_file_manager.h (from /trunk/src/chrome/browser/save_file_manager.h:2173)
   A /trunk/src/chrome/browser/download/save_item.cc (from /trunk/src/chrome/browser/save_item.cc:2173)
   A /trunk/src/chrome/browser/download/save_item.h (from /trunk/src/chrome/browser/save_item.h:2173)
   A /trunk/src/chrome/browser/download/save_package.cc (from /trunk/src/chrome/browser/save_package.cc:2173)
   A /trunk/src/chrome/browser/download/save_package.h (from /trunk/src/chrome/browser/save_package.h:2173)
   A /trunk/src/chrome/browser/download/save_package_unittest.cc (from /trunk/src/chrome/browser/save_package_unittest.cc:2173)
   A /trunk/src/chrome/browser/download/save_page_model.cc (from /trunk/src/chrome/browser/save_page_model.cc:2173)
   A /trunk/src/chrome/browser/download/save_page_model.h (from /trunk/src/chrome/browser/save_page_model.h:2173)
   A /trunk/src/chrome/browser/download/save_page_uitest.cc (from /trunk/src/chrome/browser/save_page_uitest.cc:2173)
   A /trunk/src/chrome/browser/download/save_types.h (from /trunk/src/chrome/browser/save_types.h:2173)
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   D /trunk/src/chrome/browser/save_file.cc
   D /trunk/src/chrome/browser/save_file.h
   D /trunk/src/chrome/browser/save_file_manager.cc
   D /trunk/src/chrome/browser/save_file_manager.h
   D /trunk/src/chrome/browser/save_item.cc
   D /trunk/src/chrome/browser/save_item.h
   D /trunk/src/chrome/browser/save_package.cc
   D /trunk/src/chrome/browser/save_package.h
   D /trunk/src/chrome/browser/save_package_unittest.cc
   D /trunk/src/chrome/browser/save_page_model.cc
   D /trunk/src/chrome/browser/save_page_model.h
   D /trunk/src/chrome/browser/save_page_uitest.cc
   D /trunk/src/chrome/browser/save_types.h
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move the Save Page code to the browser/download/ directory.
Review URL: http://codereview.chromium.org/3040
------------------------------------------------------------------------
r2172 | beng@google.com | 2008-09-13 22:16:22 +0200 (Sat, 13 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_view.cc

fix build bustage
------------------------------------------------------------------------
r2171 | beng@google.com | 2008-09-13 22:13:28 +0200 (Sat, 13 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_view.cc

fix build bustage
------------------------------------------------------------------------
r2169 | beng@google.com | 2008-09-13 21:40:50 +0200 (Sat, 13 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   D /trunk/src/chrome/browser/external_protocol_dialog.cc
   D /trunk/src/chrome/browser/external_protocol_dialog.h
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   D /trunk/src/chrome/browser/page_info_window.cc
   D /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   D /trunk/src/chrome/browser/standard_layout.h
   D /trunk/src/chrome/browser/tab_contents_container_view.cc
   D /trunk/src/chrome/browser/tab_contents_container_view.h
   M /trunk/src/chrome/browser/task_manager.cc
   D /trunk/src/chrome/browser/user_data_dir_dialog.cc
   D /trunk/src/chrome/browser/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   A /trunk/src/chrome/browser/views/external_protocol_dialog.cc (from /trunk/src/chrome/browser/external_protocol_dialog.cc:2150)
   A /trunk/src/chrome/browser/views/external_protocol_dialog.h (from /trunk/src/chrome/browser/external_protocol_dialog.h:2150)
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.cc
   M /trunk/src/chrome/browser/views/info_bar_confirm_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/vista_frame.cc
   M /trunk/src/chrome/browser/views/old_frames/xp_frame.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   A /trunk/src/chrome/browser/views/page_info_window.cc (from /trunk/src/chrome/browser/page_info_window.cc:2150)
   A /trunk/src/chrome/browser/views/page_info_window.h (from /trunk/src/chrome/browser/page_info_window.h:2150)
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   A /trunk/src/chrome/browser/views/standard_layout.h (from /trunk/src/chrome/browser/standard_layout.h:2150)
   A /trunk/src/chrome/browser/views/tab_contents_container_view.cc (from /trunk/src/chrome/browser/tab_contents_container_view.cc:2150)
   A /trunk/src/chrome/browser/views/tab_contents_container_view.h (from /trunk/src/chrome/browser/tab_contents_container_view.h:2150)
   A /trunk/src/chrome/browser/views/user_data_dir_dialog.cc (from /trunk/src/chrome/browser/user_data_dir_dialog.cc:2150)
   A /trunk/src/chrome/browser/views/user_data_dir_dialog.h (from /trunk/src/chrome/browser/user_data_dir_dialog.h:2150)

Move more UI stuff into browser/views

B=2205
Review URL: http://codereview.chromium.org/2825
------------------------------------------------------------------------
r2168 | beng@google.com | 2008-09-13 21:40:25 +0200 (Sat, 13 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h

turn off new frames again.
------------------------------------------------------------------------
r2167 | beng@google.com | 2008-09-13 21:00:58 +0200 (Sat, 13 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser_process_impl.h

testing new frames on one cycle of buildbots
------------------------------------------------------------------------
r2166 | paulg@google.com | 2008-09-13 04:48:59 +0200 (Sat, 13 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   A /trunk/src/chrome/browser/download
   A /trunk/src/chrome/browser/download/download_exe.cc (from /trunk/src/chrome/browser/download_exe.cc:2154)
   A /trunk/src/chrome/browser/download/download_file.cc (from /trunk/src/chrome/browser/download_file.cc:2154)
   A /trunk/src/chrome/browser/download/download_file.h (from /trunk/src/chrome/browser/download_file.h:2154)
   A /trunk/src/chrome/browser/download/download_item_model.cc (from /trunk/src/chrome/browser/download_item_model.cc:2154)
   A /trunk/src/chrome/browser/download/download_item_model.h (from /trunk/src/chrome/browser/download_item_model.h:2154)
   A /trunk/src/chrome/browser/download/download_manager.cc (from /trunk/src/chrome/browser/download_manager.cc:2154)
   A /trunk/src/chrome/browser/download/download_manager.h (from /trunk/src/chrome/browser/download_manager.h:2154)
   A /trunk/src/chrome/browser/download/download_manager_unittest.cc (from /trunk/src/chrome/browser/download_manager_unittest.cc:2154)
   A /trunk/src/chrome/browser/download/download_uitest.cc (from /trunk/src/chrome/browser/download_uitest.cc:2154)
   A /trunk/src/chrome/browser/download/download_util.cc (from /trunk/src/chrome/browser/download_util.cc:2154)
   A /trunk/src/chrome/browser/download/download_util.h (from /trunk/src/chrome/browser/download_util.h:2154)
   D /trunk/src/chrome/browser/download_exe.cc
   D /trunk/src/chrome/browser/download_file.cc
   D /trunk/src/chrome/browser/download_file.h
   D /trunk/src/chrome/browser/download_item_model.cc
   D /trunk/src/chrome/browser/download_item_model.h
   D /trunk/src/chrome/browser/download_manager.cc
   D /trunk/src/chrome/browser/download_manager.h
   D /trunk/src/chrome/browser/download_manager_unittest.cc
   D /trunk/src/chrome/browser/download_tab_view.cc
   D /trunk/src/chrome/browser/download_tab_view.h
   D /trunk/src/chrome/browser/download_uitest.cc
   D /trunk/src/chrome/browser/download_util.cc
   D /trunk/src/chrome/browser/download_util.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/save_package.cc
   M /trunk/src/chrome/browser/save_page_model.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   A /trunk/src/chrome/browser/views/download_tab_view.cc (from /trunk/src/chrome/browser/download_tab_view.cc:2154)
   A /trunk/src/chrome/browser/views/download_tab_view.h (from /trunk/src/chrome/browser/download_tab_view.h:2154)
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/test/ui/ui_tests.vcproj
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move the download code to new directories:
browser/download/
browser/views/

Review URL: http://codereview.chromium.org/2826
------------------------------------------------------------------------
r2161 | maruel@google.com | 2008-09-13 03:49:57 +0200 (Sat, 13 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Back r2151 since it causes ui tests failures.
Review URL: http://codereview.chromium.org/3037
------------------------------------------------------------------------
r2158 | beng@google.com | 2008-09-13 03:30:05 +0200 (Sat, 13 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/frame_util.cc
   D /trunk/src/chrome/browser/frame_view.cc
   D /trunk/src/chrome/browser/frame_view.h
   D /trunk/src/chrome/browser/point_buffer.cc
   D /trunk/src/chrome/browser/point_buffer.h
   D /trunk/src/chrome/browser/simple_vista_frame.cc
   D /trunk/src/chrome/browser/simple_vista_frame.h
   D /trunk/src/chrome/browser/simple_xp_frame.cc
   D /trunk/src/chrome/browser/simple_xp_frame.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   A /trunk/src/chrome/browser/views/old_frames
   A /trunk/src/chrome/browser/views/old_frames/frame_view.cc (from /trunk/src/chrome/browser/frame_view.cc:2150)
   A /trunk/src/chrome/browser/views/old_frames/frame_view.h (from /trunk/src/chrome/browser/frame_view.h:2150)
   A /trunk/src/chrome/browser/views/old_frames/point_buffer.cc (from /trunk/src/chrome/browser/point_buffer.cc:2150)
   A /trunk/src/chrome/browser/views/old_frames/point_buffer.h (from /trunk/src/chrome/browser/point_buffer.h:2150)
   A /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.cc (from /trunk/src/chrome/browser/simple_vista_frame.cc:2150)
   A /trunk/src/chrome/browser/views/old_frames/simple_vista_frame.h (from /trunk/src/chrome/browser/simple_vista_frame.h:2150)
   A /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.cc (from /trunk/src/chrome/browser/simple_xp_frame.cc:2150)
   A /trunk/src/chrome/browser/views/old_frames/simple_xp_frame.h (from /trunk/src/chrome/browser/simple_xp_frame.h:2150)
   A /trunk/src/chrome/browser/views/old_frames/vista_frame.cc (from /trunk/src/chrome/browser/vista_frame.cc:2150)
   A /trunk/src/chrome/browser/views/old_frames/vista_frame.h (from /trunk/src/chrome/browser/vista_frame.h:2150)
   A /trunk/src/chrome/browser/views/old_frames/xp_frame.cc (from /trunk/src/chrome/browser/xp_frame.cc:2150)
   A /trunk/src/chrome/browser/views/old_frames/xp_frame.h (from /trunk/src/chrome/browser/xp_frame.h:2150)
   M /trunk/src/chrome/browser/views/tabs/tab_strip.cc
   D /trunk/src/chrome/browser/vista_frame.cc
   D /trunk/src/chrome/browser/vista_frame.h
   D /trunk/src/chrome/browser/window_clipping_info.cc
   D /trunk/src/chrome/browser/window_clipping_info.h
   D /trunk/src/chrome/browser/xp_frame.cc
   D /trunk/src/chrome/browser/xp_frame.h

Move XPFrame, VistaFrame to views/old_frames

Also remove WindowClippingInfo, since it's not used by anyone.

And fix a couple of header include issues.

B=2205

Review URL: http://codereview.chromium.org/2820
------------------------------------------------------------------------
r2157 | beng@google.com | 2008-09-13 03:19:59 +0200 (Sat, 13 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h

Forgot to commit these two files.

B=2205

------------------------------------------------------------------------
r2154 | beng@google.com | 2008-09-13 02:56:27 +0200 (Sat, 13 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/firefox2_importer.cc
   D /trunk/src/chrome/browser/firefox2_importer.h
   D /trunk/src/chrome/browser/firefox3_importer.cc
   D /trunk/src/chrome/browser/firefox3_importer.h
   D /trunk/src/chrome/browser/firefox_importer_unittest.cc
   D /trunk/src/chrome/browser/firefox_importer_utils.cc
   D /trunk/src/chrome/browser/firefox_importer_utils.h
   D /trunk/src/chrome/browser/firefox_profile_lock.cc
   D /trunk/src/chrome/browser/firefox_profile_lock.h
   M /trunk/src/chrome/browser/first_run.cc
   D /trunk/src/chrome/browser/ie_importer.cc
   D /trunk/src/chrome/browser/ie_importer.h
   A /trunk/src/chrome/browser/importer
   A /trunk/src/chrome/browser/importer/firefox2_importer.cc (from /trunk/src/chrome/browser/firefox2_importer.cc:2150)
   A /trunk/src/chrome/browser/importer/firefox2_importer.h (from /trunk/src/chrome/browser/firefox2_importer.h:2150)
   A /trunk/src/chrome/browser/importer/firefox3_importer.cc (from /trunk/src/chrome/browser/firefox3_importer.cc:2150)
   A /trunk/src/chrome/browser/importer/firefox3_importer.h (from /trunk/src/chrome/browser/firefox3_importer.h:2150)
   A /trunk/src/chrome/browser/importer/firefox_importer_unittest.cc (from /trunk/src/chrome/browser/firefox_importer_unittest.cc:2150)
   A /trunk/src/chrome/browser/importer/firefox_importer_utils.cc (from /trunk/src/chrome/browser/firefox_importer_utils.cc:2150)
   A /trunk/src/chrome/browser/importer/firefox_importer_utils.h (from /trunk/src/chrome/browser/firefox_importer_utils.h:2150)
   A /trunk/src/chrome/browser/importer/firefox_profile_lock.cc (from /trunk/src/chrome/browser/firefox_profile_lock.cc:2150)
   A /trunk/src/chrome/browser/importer/firefox_profile_lock.h (from /trunk/src/chrome/browser/firefox_profile_lock.h:2150)
   A /trunk/src/chrome/browser/importer/ie_importer.cc (from /trunk/src/chrome/browser/ie_importer.cc:2150)
   A /trunk/src/chrome/browser/importer/ie_importer.h (from /trunk/src/chrome/browser/ie_importer.h:2150)
   A /trunk/src/chrome/browser/importer/importer.cc (from /trunk/src/chrome/browser/importer.cc:2150)
   A /trunk/src/chrome/browser/importer/importer.h (from /trunk/src/chrome/browser/importer.h:2150)
   A /trunk/src/chrome/browser/importer/importer_unittest.cc (from /trunk/src/chrome/browser/importer_unittest.cc:2150)
   A /trunk/src/chrome/browser/importer/mork_reader.cc (from /trunk/src/chrome/browser/mork_reader.cc:2150)
   A /trunk/src/chrome/browser/importer/mork_reader.h (from /trunk/src/chrome/browser/mork_reader.h:2150)
   D /trunk/src/chrome/browser/importer.cc
   D /trunk/src/chrome/browser/importer.h
   D /trunk/src/chrome/browser/importer_unittest.cc
   D /trunk/src/chrome/browser/mork_reader.cc
   D /trunk/src/chrome/browser/mork_reader.h
   D /trunk/src/chrome/browser/title_chomper.cc
   D /trunk/src/chrome/browser/title_chomper.h
   D /trunk/src/chrome/browser/title_chomper_unittest.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Move importer files into an importer subdirectory.

Also delete title chomper no one uses it.

B=2205
Review URL: http://codereview.chromium.org/3035
------------------------------------------------------------------------
r2151 | petersont@google.com | 2008-09-13 02:06:01 +0200 (Sat, 13 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

Added routines to MetricsService to parse the server response and respond to the request to cease uploading with some probability.

Review URL: http://codereview.chromium.org/1633
------------------------------------------------------------------------
r2150 | beng@google.com | 2008-09-13 01:55:28 +0200 (Sat, 13 Sep 2008) | 5 lines
Changed paths:
   D /trunk/src/chrome/browser/app_integration
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/shell
   D /trunk/src/chrome/browser/wizard

Remove some files and directories we no longer use (We can resurrect them from svn history later)

B=2205

Review URL: http://codereview.chromium.org/2817
------------------------------------------------------------------------
r2145 | beng@google.com | 2008-09-13 01:20:28 +0200 (Sat, 13 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix black flash when detaching tabs.

B=2199

Review URL: http://codereview.chromium.org/3028
------------------------------------------------------------------------
r2144 | sky@google.com | 2008-09-13 01:18:53 +0200 (Sat, 13 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history_model.cc

Fixes bug where history view was not showing star state correctly.

BUG=2117
TEST=See bug

Review URL: http://codereview.chromium.org/3027
------------------------------------------------------------------------
r2143 | brettw@google.com | 2008-09-13 01:08:30 +0200 (Sat, 13 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Revert the change that fixed the encoding when viewing source in subframes.
This makes view source for some pages (for example Google Reader) not work
properly. I speculate that telling WebKit to change the encoding (which causes
a reload) right after starting the real load makes it confused.
Review URL: http://codereview.chromium.org/3022
------------------------------------------------------------------------
r2142 | beng@google.com | 2008-09-13 01:00:52 +0200 (Sat, 13 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/frame_view.cc
   M /trunk/src/chrome/browser/simple_xp_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc

forgot these files, fixing clobber build
------------------------------------------------------------------------
r2140 | beng@google.com | 2008-09-13 00:44:06 +0200 (Sat, 13 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   D /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   D /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   D /trunk/src/chrome/browser/tabs/dragged_tab_view.cc
   D /trunk/src/chrome/browser/tabs/dragged_tab_view.h
   D /trunk/src/chrome/browser/tabs/hwnd_photobooth.cc
   D /trunk/src/chrome/browser/tabs/hwnd_photobooth.h
   D /trunk/src/chrome/browser/tabs/tab.cc
   D /trunk/src/chrome/browser/tabs/tab.h
   D /trunk/src/chrome/browser/tabs/tab_dragging_test.cc
   D /trunk/src/chrome/browser/tabs/tab_renderer.cc
   D /trunk/src/chrome/browser/tabs/tab_renderer.h
   D /trunk/src/chrome/browser/tabs/tab_strip.cc
   D /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   A /trunk/src/chrome/browser/views/tabs
   A /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc (from /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc:2027)
   A /trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h (from /trunk/src/chrome/browser/tabs/dragged_tab_controller.h:2027)
   A /trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc (from /trunk/src/chrome/browser/tabs/dragged_tab_view.cc:2027)
   A /trunk/src/chrome/browser/views/tabs/dragged_tab_view.h (from /trunk/src/chrome/browser/tabs/dragged_tab_view.h:2027)
   A /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.cc (from /trunk/src/chrome/browser/tabs/hwnd_photobooth.cc:2027)
   A /trunk/src/chrome/browser/views/tabs/hwnd_photobooth.h (from /trunk/src/chrome/browser/tabs/hwnd_photobooth.h:2027)
   A /trunk/src/chrome/browser/views/tabs/tab.cc (from /trunk/src/chrome/browser/tabs/tab.cc:2027)
   A /trunk/src/chrome/browser/views/tabs/tab.h (from /trunk/src/chrome/browser/tabs/tab.h:2027)
   A /trunk/src/chrome/browser/views/tabs/tab_dragging_test.cc (from /trunk/src/chrome/browser/tabs/tab_dragging_test.cc:2027)
   A /trunk/src/chrome/browser/views/tabs/tab_renderer.cc (from /trunk/src/chrome/browser/tabs/tab_renderer.cc:2027)
   A /trunk/src/chrome/browser/views/tabs/tab_renderer.h (from /trunk/src/chrome/browser/tabs/tab_renderer.h:2027)
   A /trunk/src/chrome/browser/views/tabs/tab_strip.cc (from /trunk/src/chrome/browser/tabs/tab_strip.cc:2027)
   A /trunk/src/chrome/browser/views/tabs/tab_strip.h (from /trunk/src/chrome/browser/tabs/tab_strip.h:2027)
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj

Move View components of the Browser's tab strip into the browser_views project, and into the views/ subdirectory on disk.

B=2198
Review URL: http://codereview.chromium.org/3020
------------------------------------------------------------------------
r2137 | jcampan@chromium.org | 2008-09-12 23:20:04 +0200 (Fri, 12 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download_tab_view.cc
   M /trunk/src/chrome/browser/download_util.cc
   M /trunk/src/chrome/browser/download_util.h
   M /trunk/src/chrome/browser/views/download_item_view.cc

Removing static initializers.

BUG=None
TEST=Make sure download bar is still working fine.
Review URL: http://codereview.chromium.org/2431
------------------------------------------------------------------------
r2119 | sky@google.com | 2008-09-12 19:28:12 +0200 (Fri, 12 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_parser.cc
   M /trunk/src/chrome/browser/template_url_parser.h
   M /trunk/src/chrome/browser/template_url_parser_unittest.cc

Allows OSDD files to contain https.

BUG=2153
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/2454
------------------------------------------------------------------------
r2116 | erg@google.com | 2008-09-12 19:01:27 +0200 (Fri, 12 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Prevent constrained popup windows from trying to become real
windows by using alert().

B=1372216
Review URL: http://codereview.chromium.org/1970
------------------------------------------------------------------------
r2104 | erg@google.com | 2008-09-12 02:02:49 +0200 (Fri, 12 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h

Actually fix the javascript alert crasher in a way that
doesn't introduce new crashes.

B=1368898
Review URL: http://codereview.chromium.org/1966
------------------------------------------------------------------------
r2090 | finnur@google.com | 2008-09-11 23:54:47 +0200 (Thu, 11 Sep 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_manager.cc

Fixing bug 1951: Browser crash on View-Source of an https page.
http://code.google.com/p/chromium/issues/detail?id=1951

We load the page in view-source mode, then request the favicon to show in the tab. The SSLManager gets notified about OnRequestStarted for both the page and the favicon, but the favicon request gets redirected from:

https://www.solomobile.ca/favicon.ico
... to ...
http://www.solomobile.ca/Error.aspx?aspxerrorpath=/Page-Not-Found.aspx

The SSLManager sees this as mixed content and while handling that it writes a debug message to the console, but in the process of writing the debug message we crash when GetTabContents(TAB_CONTENTS_WEB) returns NULL (since the current tab is TAB_CONTENTS_VIEW_SOURCE). Given that this is a debug message we are trying to write with a function that is only implemented on WebContents we should just NULL check the GetTabContents(TAB_CONTENTS_WEB) return value (and not log the debug message).

Review URL: http://codereview.chromium.org/2445
------------------------------------------------------------------------
r2088 | erg@google.com | 2008-09-11 23:54:28 +0200 (Thu, 11 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h

Reverting constrained window change. Seems to break tests on TOT.

Review URL: http://codereview.chromium.org/2447
------------------------------------------------------------------------
r2087 | jcampan@chromium.org | 2008-09-11 23:50:32 +0200 (Thu, 11 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_uitest.cc

As described in bug 2136, this test is flaky.
Temporarily disabling it.
Review URL: http://codereview.chromium.org/1955
------------------------------------------------------------------------
r2084 | maruel@google.com | 2008-09-11 23:25:07 +0200 (Thu, 11 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc

Two minor fixes. Fix the hard coded desired dpi and remove an unneeded include.
Review URL: http://codereview.chromium.org/1954
------------------------------------------------------------------------
r2083 | darin@chromium.org | 2008-09-11 23:24:10 +0200 (Thu, 11 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Avoid starting the pause timer if it is already started.

R=sky

Review URL: http://codereview.chromium.org/2443
------------------------------------------------------------------------
r2081 | sky@google.com | 2008-09-11 23:19:29 +0200 (Thu, 11 Sep 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/icon_manager.cc

Fixes bug in IconManager where it was possible for callback to be
invoked with a deleted pointer. We never hit this as none of the
callers use the SkBitmap supplied to the callback. I was tempted to
nuke the SkBitmap from the callback, but seems useful.

BUG=1372146
TEST=none

Review URL: http://codereview.chromium.org/2438
------------------------------------------------------------------------
r2079 | erg@google.com | 2008-09-11 22:55:28 +0200 (Thu, 11 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h

Fix crasher and possible security vulnerability in popup
handling.

B=1368898
Review URL: http://codereview.chromium.org/2437
------------------------------------------------------------------------
r2071 | sidchat@google.com | 2008-09-11 19:44:41 +0200 (Thu, 11 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Update URL for dictionary download.

Review URL: http://codereview.chromium.org/1401
------------------------------------------------------------------------
r2063 | sky@google.com | 2008-09-11 18:41:18 +0200 (Thu, 11 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/session_service_test_helper.cc
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/browser/tab_restore_service.cc

Changes session service to not persist NavigationEntries that have
POST data. This is a security problem as POST data can contain
passwords in plain text.

BUG=1361980
TEST=none

------------------------------------------------------------------------
r2058 | jcampan@chromium.org | 2008-09-11 17:48:56 +0200 (Thu, 11 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   A /trunk/src/chrome/test/data/ssl/page_with_unsafe_popup.html

Closing a tab with a constrained pop-up showing an SSL interstitial would crash the browser.

BUG=1966
TEST=Open a page that opens a popup which is served over bad SSL. Close the tab.
Review URL: http://codereview.chromium.org/1898
------------------------------------------------------------------------
r2057 | sky@google.com | 2008-09-11 17:22:32 +0200 (Thu, 11 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_bar_model.cc
   D /trunk/src/chrome/browser/bookmarks/bookmark_bar_model.h
   D /trunk/src/chrome/browser/bookmarks/bookmark_bar_model_unittest.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc
   A /trunk/src/chrome/browser/bookmarks/bookmark_model.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_bar_model.cc:1988)
   A /trunk/src/chrome/browser/bookmarks/bookmark_model.h (from /trunk/src/chrome/browser/bookmarks/bookmark_bar_model.h:1988)
   A /trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc (from /trunk/src/chrome/browser/bookmarks/bookmark_bar_model_unittest.cc:1988)
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmarks/bookmark_storage.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history_model.cc
   M /trunk/src/chrome/browser/history_model.h
   M /trunk/src/chrome/browser/ie_importer.cc
   M /trunk/src/chrome/browser/importer.cc
   M /trunk/src/chrome/browser/importer.h
   M /trunk/src/chrome/browser/importer_unittest.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Renames BoomarkBarModel to BookmarkModel.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1912
------------------------------------------------------------------------
r2053 | deanm@chromium.org | 2008-09-11 13:18:34 +0200 (Thu, 11 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.cc

Tuck the ram/num_processes map into a function, and remove a static initializer.
Review URL: http://codereview.chromium.org/1936
------------------------------------------------------------------------
r2051 | beng@google.com | 2008-09-11 05:59:09 +0200 (Thu, 11 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc

Make sure the tabstrip doesn't have the chin above it in maximized view in aero.

B=1031854
Review URL: http://codereview.chromium.org/2414
------------------------------------------------------------------------
r2042 | beng@google.com | 2008-09-11 02:15:25 +0200 (Thu, 11 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   M /trunk/src/chrome/views/tooltip_manager.cc

Set an upper limit to the number of characters that can appear in a tooltip string.

B=1368905

Review URL: http://codereview.chromium.org/2409
------------------------------------------------------------------------
r2026 | petersont@google.com | 2008-09-11 00:12:19 +0200 (Thu, 11 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/views/group_table_view.cc
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h

Double clicking on an item in the task manager should bring the relevant tab forward.

Review URL: http://codereview.chromium.org/1822
------------------------------------------------------------------------
r2008 | finnur@google.com | 2008-09-10 22:04:12 +0200 (Wed, 10 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/google_update/google_update_idl.idl

Google Update gave us a new IDL and asked us to change the CLSID const we use. Effectively there should be no change here. This is not required for the beta branch.
Review URL: http://codereview.chromium.org/1901
------------------------------------------------------------------------
r2004 | pkasting@chromium.org | 2008-09-10 21:35:52 +0200 (Wed, 10 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   M /trunk/src/chrome/browser/autocomplete/edit_drop_target.cc
   M /trunk/src/chrome/browser/autocomplete/edit_drop_target.h
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/views/accessibility/autocomplete_accessibility.cc
   M /trunk/src/chrome/views/accessibility/autocomplete_accessibility.h

First pass at splitting the AutocompleteEdit into Model and View.  This was noticeably harder than with the Popup and I'm not at all sure I've made the right decisions :(.  The View code is about 3x larger than the model.

BUG=1343512
Review URL: http://codereview.chromium.org/1872
------------------------------------------------------------------------
r2003 | finnur@google.com | 2008-09-10 21:30:35 +0200 (Wed, 10 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

The About box was needlessly blocking Chrome on Vista SP1 (with UAC disabled) from performing an On-demand update. Google Update has worked around the issue - for SP1 and up that is - so we can relax the restriction a bit.

Review URL: http://codereview.chromium.org/1708
------------------------------------------------------------------------
r1998 | jcampan@chromium.org | 2008-09-10 20:12:23 +0200 (Wed, 10 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

If you click a link to a malware page or if a page redirects to malware, the malware blocking page is shown but it says that the malware page is a resource of the originating page.
This is because the blocking page was using the page URL to determine if we are dealing with the main frame, and in these cases the URL was not set yet.

BUG=1335251
TEST=Navigate to a page that has a link to malware. Click on the link. The malware blocking page should be displayed and should indicate that the page is malware (and not that the originating page contains malware).
Review URL: http://codereview.chromium.org/1881
------------------------------------------------------------------------
r1996 | beng@google.com | 2008-09-10 20:05:11 +0200 (Wed, 10 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h

Fix grab bag of AeroGlassFrame issues:
- better names and documentation for varions kOnstants in the AeroGlassNonClientView
- AeroGlassFrame now uses the actual bounds of the tabstrip to adjust the DWM frame, rather than hard-coding constants.
- fix bug in hit testing that meant that tabs weren't selectable... wrong coordinate system used for one function call... not sure how this didn't affect XP?!!

B=1031854

Review URL: http://codereview.chromium.org/1882
------------------------------------------------------------------------
r1978 | darin@chromium.org | 2008-09-10 08:36:34 +0200 (Wed, 10 Sep 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h

Don't send queries when URL is like:
- starts with http:// or https:// and includes username (e.g.
http://me@test.com/)
- starts with http:// or https:// and includes query (e.g. http://test.com/?q=x)
- starts with https:// and includes path component (e.g. https://test.com/path)
so as not to leak user data to the suggest server.

Patch by takayoshi.kochi@gmail.com
BUG=1647


------------------------------------------------------------------------
r1949 | beng@google.com | 2008-09-10 01:28:28 +0200 (Wed, 10 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc

Bounds check the tab index before attempting to index into the TabStripModel using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints.

B=1366019

------------------------------------------------------------------------
r1945 | mpcomplete@google.com | 2008-09-10 01:11:17 +0200 (Wed, 10 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/html_dialog_view.cc

Fix bug with resizeBy in Gears dialogs.

BUG=1340253
Review URL: http://codereview.chromium.org/1867
------------------------------------------------------------------------
r1944 | sky@google.com | 2008-09-10 01:08:13 +0200 (Wed, 10 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   D /trunk/src/chrome/browser/bookmark_bar_model.cc
   D /trunk/src/chrome/browser/bookmark_bar_model.h
   D /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   D /trunk/src/chrome/browser/bookmark_codec.cc
   D /trunk/src/chrome/browser/bookmark_codec.h
   D /trunk/src/chrome/browser/bookmark_drag_data.cc
   D /trunk/src/chrome/browser/bookmark_drag_data.h
   D /trunk/src/chrome/browser/bookmark_drag_data_unittest.cc
   D /trunk/src/chrome/browser/bookmark_storage.cc
   D /trunk/src/chrome/browser/bookmark_storage.h
   A /trunk/src/chrome/browser/bookmarks/bookmark_bar_model.cc (from /trunk/src/chrome/browser/bookmark_bar_model.cc:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_bar_model.h (from /trunk/src/chrome/browser/bookmark_bar_model.h:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_bar_model_unittest.cc (from /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_codec.cc (from /trunk/src/chrome/browser/bookmark_codec.cc:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_codec.h (from /trunk/src/chrome/browser/bookmark_codec.h:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc (from /trunk/src/chrome/browser/bookmark_drag_data.cc:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h (from /trunk/src/chrome/browser/bookmark_drag_data.h:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_drag_data_unittest.cc (from /trunk/src/chrome/browser/bookmark_drag_data_unittest.cc:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_storage.cc (from /trunk/src/chrome/browser/bookmark_storage.cc:1899)
   A /trunk/src/chrome/browser/bookmarks/bookmark_storage.h (from /trunk/src/chrome/browser/bookmark_storage.h:1899)
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history_model.cc
   M /trunk/src/chrome/browser/ie_importer.cc
   M /trunk/src/chrome/browser/importer.cc
   M /trunk/src/chrome/browser/importer.h
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Moves bookmark related classes into bookmarks directory. There are no
code changes here (other than converting to COPY_AND_BLAH_BLAH and
updating include guards).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1868
------------------------------------------------------------------------
r1938 | beng@google.com | 2008-09-10 00:16:58 +0200 (Wed, 10 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc

backing out checkin to closed tree
------------------------------------------------------------------------
r1936 | beng@google.com | 2008-09-10 00:10:27 +0200 (Wed, 10 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc

Bounds check the tab index before attempting to index into the TabStripModel using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints.

B=1366019

------------------------------------------------------------------------
r1903 | beng@google.com | 2008-09-09 19:56:52 +0200 (Tue, 09 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Patch from Szymon Piechowicz <szymonpiechowicz@o2.pl>

Moves the New Tab, Window, Incognito Window menu items from the Page menu to the Wrench menu.

Code review: http://codereview.chromium.org/1826

------------------------------------------------------------------------
r1883 | cpu@google.com | 2008-09-09 02:11:52 +0200 (Tue, 09 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Adding a CHECK in a memcpy that it is not trivial to understand.

Review URL: http://codereview.chromium.org/1630
------------------------------------------------------------------------
r1874 | jcampan@google.com | 2008-09-09 00:58:53 +0200 (Tue, 09 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_policy.cc

Pages with mixed content were shown as secure.

BUG=1347301
TEST=Go to https://www.corp.google.com the page should not be reported as safe (the location bar should not show a lock).
Review URL: http://codereview.chromium.org/2201
------------------------------------------------------------------------
r1871 | nsylvain@google.com | 2008-09-09 00:33:45 +0200 (Tue, 09 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/edit_drop_target.h
   M /trunk/src/chrome/browser/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/external_protocol_dialog.h
   M /trunk/src/chrome/browser/external_protocol_handler.cc

Change the external protocol handler to look at the
command that will be run before warning the user. If
the command is empty, there is no reason to warn.

I removed a dcheck. This dcheck is good, but unfortunately
we can't use g_browser_process in the io_thread.
Review URL: http://codereview.chromium.org/1632
------------------------------------------------------------------------
r1862 | erg@google.com | 2008-09-08 22:51:30 +0200 (Mon, 08 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/controller.h
   M /trunk/src/chrome/browser/download_file.h
   M /trunk/src/chrome/browser/download_manager.h
   M /trunk/src/chrome/browser/download_tab_view.cc
   M /trunk/src/chrome/browser/download_tab_view.h
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/save_file_manager.h
   M /trunk/src/chrome/browser/save_package.h
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/net/disk_cache/mem_backend_impl.h
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/url_request/url_request_filter.h
   M /trunk/src/webkit/glue/dom_serializer.h
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/entity_map.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h

Replace all instances of <hash_map> with a "base/hash_tabe.h",
which does the right thing based on whatever platform we're
compiling for, along with changing the hardcoded "stdext::",
which is a MSVC++ism to use base::hash_{map,set}.

B=1869
Review URL: http://codereview.chromium.org/1629
------------------------------------------------------------------------
r1857 | maruel@google.com | 2008-09-08 21:07:18 +0200 (Mon, 08 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc

Use FRIEND_TEST() instead of guessing the test class name (!)
Review URL: http://codereview.chromium.org/1626
------------------------------------------------------------------------
r1852 | deanm@google.com | 2008-09-08 20:09:33 +0200 (Mon, 08 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc

Disable a flakey test.
BUG=http://code.google.com/p/chromium/issues/detail?id=1880
Review URL: http://codereview.chromium.org/1816
------------------------------------------------------------------------
r1850 | beng@google.com | 2008-09-08 20:01:31 +0200 (Mon, 08 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

A couple of quick TODO and other cleanups.

B=1031854

Review URL: http://codereview.chromium.org/1624
------------------------------------------------------------------------
r1849 | beng@google.com | 2008-09-08 19:43:47 +0200 (Mon, 08 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Support WM_APPCOMMAND on Window. Make it just pass through to WindowDelegate::ExecuteWindowsCommand. The delegate needs to pre-translate for it.

This allows my mouse's back and forward buttons to work on the new frames.

B=1031854

Review URL: http://codereview.chromium.org/1620
------------------------------------------------------------------------
r1846 | deanm@google.com | 2008-09-08 19:11:31 +0200 (Mon, 08 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

Hopefully remove 102 unneeded static initializers.  This should require less memory, since now we will share the PrepopulatedEngines across the language locales.
Review URL: http://codereview.chromium.org/1619
------------------------------------------------------------------------
r1845 | sky@google.com | 2008-09-08 18:56:03 +0200 (Mon, 08 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Makes new tab page update properly when its told bookmarks are
changed.

BUG=1861
TEST=see bug

Review URL: http://codereview.chromium.org/1618
------------------------------------------------------------------------
r1838 | sky@google.com | 2008-09-08 16:46:36 +0200 (Mon, 08 Sep 2008) | 11 lines
Changed paths:
   M /trunk/src/AUTHORS
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/menu.cc

This patch is from Andrew Brampton <me@bramp.net>.

This patches allows menu items in PopUpMenus to be clicked with the right mouse
button.
menu.cc controls the web content popup menus, and some others
chrome_menu{.cc,.h} controls popup menu on the chrome, for example right
clicking on a tab.

BUG=718
TEST=Bring up any menu (wrench/document) and right click on one of the items. This should select the item. Try the same with any of the bookmark menus.

------------------------------------------------------------------------
r1833 | brettw@google.com | 2008-09-08 04:26:32 +0200 (Mon, 08 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix a crash (visible sometimes in the single process UI tests in
RestoreToDifferentWindow).
Review URL: http://codereview.chromium.org/1809
------------------------------------------------------------------------
r1832 | beng@google.com | 2008-09-08 02:45:31 +0200 (Mon, 08 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Make sure the browser is destroyed during DestroyBrowser because EndSession handling needs it to be synchronously deleted, rather than by the Window's destruction.

B=1031854
Review URL: http://codereview.chromium.org/452
------------------------------------------------------------------------
r1831 | brettw@google.com | 2008-09-08 01:57:40 +0200 (Mon, 08 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/notification_types.h

Fix SSL state in the URL bar being incorrect. Going to an EV site like https://www.verisign.com/ would not should the EV name in the URL bar unless you did something like switch tabs away and back because in my cleanup I removed the notification that this was depending on.

This patch adds a new NOTIFY_SSL_STATE_CHANGED notification which is broadcast by the various SSL components when they update the flags. The browser now listens for this notification and will update the URL bar.

BUG=1359547
TEST=see repro steps in bug

Review URL: http://codereview.chromium.org/436
------------------------------------------------------------------------
r1828 | beng@google.com | 2008-09-07 20:45:26 +0200 (Sun, 07 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/common/win_util.cc

Don't reinvent the wheel - base::wclscpy does this work in one line of code.

Review URL: http://codereview.chromium.org/1807
------------------------------------------------------------------------
r1819 | tc@google.com | 2008-09-06 03:56:21 +0200 (Sat, 06 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/locales/locale_settings.h
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc

Allow the import lock dialog to be sized by locale.

Also increase the height of the Italian first run bubble.

BUG=1334381,1359145
Review URL: http://codereview.chromium.org/482
------------------------------------------------------------------------
r1817 | paulg@google.com | 2008-09-06 02:54:58 +0200 (Sat, 06 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Fix a memory leak introduced in the SafeBrowsing prefix cache test.

BUG=1484
Review URL: http://codereview.chromium.org/481
------------------------------------------------------------------------
r1810 | beng@google.com | 2008-09-05 23:47:34 +0200 (Fri, 05 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/common/win_util.cc

Clamp open file name size.

B=1362425
Review URL: http://codereview.chromium.org/476
------------------------------------------------------------------------
r1809 | finnur@google.com | 2008-09-05 23:36:57 +0200 (Fri, 05 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Readding UI test I pulled yesterday; hopefully the bots will like it more now. I need to wait for the bookmark bar to become visible so I plumbed in similar code as for the Find box instead of using Sleep's. 
Review URL: http://codereview.chromium.org/473
------------------------------------------------------------------------
r1803 | sky@google.com | 2008-09-05 22:39:47 +0200 (Fri, 05 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc

Fixes keyword editor to show error image when keyword isn't valid.

BUG=1318
TEST=Edit a keyword in the keyword editor. Change the keyword to one
  that is being used by another keyword. Make sure the icon updates
  appropriately.

Review URL: http://codereview.chromium.org/258
------------------------------------------------------------------------
r1754 | sky@google.com | 2008-09-05 04:44:51 +0200 (Fri, 05 Sep 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc

Attempt at fixing crash. I believe this is happening during session
end, which has a different shutdown path and is possible for the model
to be deleted before the view.

I'm also adding checking to XPFrame/VistaFrame to make sure the
BookmarkBarView doesn't have a parent in the destructor. This
shouldn't be possible, but I'm adding the check to be sure;)

BUG=1359852
TEST=make sure you don't see problems with bookmarks

Review URL: http://codereview.chromium.org/440
------------------------------------------------------------------------
r1753 | cpu@google.com | 2008-09-05 04:25:32 +0200 (Fri, 05 Sep 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/download_manager.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Same CL as 448. Had to redo it.

Change the default download path if needed, in Vista it could be set tothe
destkop which is a risky location.- Remove reading the download location from IE
in vista.BUG=b/1355855

This was already LGTmed


Review URL: http://codereview.chromium.org/462
------------------------------------------------------------------------
r1748 | paulg@google.com | 2008-09-05 03:44:33 +0200 (Fri, 05 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h

Cache empty responses from the SafeBrowsing servers for GetHash
requests so that we don't keep asking for full hashes that don't
exist. We flush this cache with each update, which is a little
aggressive, but on the safe side.

BUG=1358225
Review URL: http://codereview.chromium.org/454
------------------------------------------------------------------------
r1746 | beng@google.com | 2008-09-05 02:25:58 +0200 (Fri, 05 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

New Frames.

Fix browser UI tests relating to page titles. "- Chromium" was not being appended to the window title.

B=1031854

------------------------------------------------------------------------
r1736 | finnur@google.com | 2008-09-04 23:24:38 +0200 (Thu, 04 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc

My new test is failing on the bots. Disabling while I investigate.

TBR=sky

Review URL: http://codereview.chromium.org/446
------------------------------------------------------------------------
r1729 | jam@chromium.org | 2008-09-04 22:52:36 +0200 (Thu, 04 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc

Fix the issue where a sub chunk coming in before an add chunk, both containg the same prefixes, will lead to the whole hostname looking like it's blocked.

BUG=1358531
Review URL: http://codereview.chromium.org/439
------------------------------------------------------------------------
r1727 | finnur@google.com | 2008-09-04 22:30:00 +0200 (Thu, 04 Sep 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc

Fixing issue 1343052: a regression where the Find box moves up when you open a new tab and close it again.

This is because during a TabClosingAt call, we end up calling ShowTabContents(NULL) which leads to ShelfVisibilityChangedImpl(NULL). Because the parameter current_tab is NULL, we end up removing the BookmarkBarView from the RootView (only to add it back a little too late), the Find window thinks there is no BookmarkBar and hence moves up a bit.

I am also enabling the disabled UI test I wrote for this, since it should now pass.

BUG=1343052
TEST=Covered by UI test.

Review URL: http://codereview.chromium.org/441
------------------------------------------------------------------------
r1726 | sidchat@google.com | 2008-09-04 22:26:32 +0200 (Thu, 04 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc

Invoke a flag setting for 'dictionary download over' in the IO loop through a proxy in the UI loop.

Review URL: http://codereview.chromium.org/438
------------------------------------------------------------------------
r1724 | mmentovai@google.com | 2008-09-04 21:00:37 +0200 (Thu, 04 Sep 2008) | 3 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/build/base.vcproj
   D /trunk/src/base/hmac.cc
   M /trunk/src/base/hmac.h
   A /trunk/src/base/hmac_mac.cc
   M /trunk/src/base/hmac_unittest.cc
   A /trunk/src/base/hmac_win.cc (from /trunk/src/base/hmac.cc:1686)
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc

HMAC-SHA1 implementation for Mac based on CommonCrypto;
allow Windows HMAC-SHA1 to use keys longer than 16 bytes.
Review URL: http://codereview.chromium.org/218
------------------------------------------------------------------------
r1720 | wtc@google.com | 2008-09-04 18:40:10 +0200 (Thu, 04 Sep 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/web_contents.cc

Clean up brettw's checkin of r1032.

Fix a DCHECK on ssl().content_status() in web_contents.cc.

Remove the unused ResetInternal method of NavigationController.

R=brettw
Review URL: http://codereview.chromium.org/221
------------------------------------------------------------------------
r1710 | maruel@google.com | 2008-09-04 05:36:44 +0200 (Thu, 04 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   A /trunk/src/chrome/browser/views/window_resources.cc
   A /trunk/src/chrome/browser/views/window_resources.h
   M /trunk/src/chrome/views/custom_frame_window.cc

Fix the polymorphic WindowResources class and FramePartBitmap enum.

TBR=ben
Review URL: http://codereview.chromium.org/224
------------------------------------------------------------------------
r1709 | sky@google.com | 2008-09-04 05:35:33 +0200 (Thu, 04 Sep 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/test/testing_profile.h

Fixes crash in BookmarkBarView. If the HistoryService fails to load it
was possible for BookmarkBarView to deref NULL (the model_
field). There is no point in having the BookmarkBarView wait for
history to load now though, so I've taken this out which makes it
impossible to get in this situation.

BUG=1356168
TEST=make sure bookmarks still work correctly

Review URL: http://codereview.chromium.org/426
------------------------------------------------------------------------
r1708 | sky@google.com | 2008-09-04 05:35:28 +0200 (Thu, 04 Sep 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/history_model.cc
   M /trunk/src/chrome/browser/history_view.cc

Fixes crash in history view. The crash occurs with the following
sequence:

1. Delete a day of history.
2. Before the delete finishes, click to delete another day.
3. While the modal dialog is up wait for the delete/reload to
   complete.
4. Click ok.

This crashes because the index supplied to delete in step 2 is bogus
after step 3 completes.

I suspect we could make this a bit more elegant, but I'm holding off
until we figure out the HTML versions of these.

BUG=1358107
TEST=Make sure history deletion still works.

Review URL: http://codereview.chromium.org/602
------------------------------------------------------------------------
r1703 | maruel@google.com | 2008-09-04 03:03:30 +0200 (Thu, 04 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc

Fix the include order in aero_glass_frame.cc. This was causing issues with WPO enabled.
Review URL: http://codereview.chromium.org/430
------------------------------------------------------------------------
r1702 | erg@google.com | 2008-09-04 02:43:12 +0200 (Thu, 04 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc

Localize the 11th hour popup window hack. Right before release, we made a change to the behaviour of constrained windows, where we hard coded English strings. Localize this now...
Review URL: http://codereview.chromium.org/427
------------------------------------------------------------------------
r1698 | beng@google.com | 2008-09-04 00:36:40 +0200 (Thu, 04 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

Make sure the new frames' BrowserView2::TabSelectedAt calls TabContents::DidBecomeSelected, like Browser::TabSelectedAt does for the old frames. This was causing tab-restore related features (undo close tab, duplicate tab) to result in sad tab being shown when using the magic_browzR switch.

B=1031854

------------------------------------------------------------------------
r1684 | darin@google.com | 2008-09-03 20:18:14 +0200 (Wed, 03 Sep 2008) | 6 lines
Changed paths:
   M /trunk/src/base/idletimer_unittest.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/timer.cc
   M /trunk/src/base/timer.h
   M /trunk/src/base/timer_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/download_file.cc
   M /trunk/src/chrome/browser/download_file.h
   M /trunk/src/chrome/browser/download_manager.cc
   M /trunk/src/chrome/browser/download_manager.h
   M /trunk/src/chrome/browser/download_tab_view.cc
   M /trunk/src/chrome/browser/download_tab_view.h
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/repeat_controller.cc
   M /trunk/src/chrome/views/repeat_controller.h
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/throbber.h
   M /trunk/src/net/disk_cache/disk_cache_test_util.cc
   M /trunk/src/net/disk_cache/disk_cache_test_util.h

Minor cleanup to OneShotTimer and RepeatingTimer:  moves more of the member variables into the Task subclass.

Also included in this change: deprecate MessageLoop::timer_manager(), and change consumers over to use OneShotTimer or RepeatingTimer.

R=beng
BUG=1346553
------------------------------------------------------------------------
r1673 | sgjesse@google.com | 2008-09-03 13:57:01 +0200 (Wed, 03 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS

Changed the allowed include path from v8/public to v8/include in the
browser DEPS file.
------------------------------------------------------------------------
r1672 | sgjesse@google.com | 2008-09-03 12:53:39 +0200 (Wed, 03 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_node.h
   M /trunk/src/chrome/browser/debugger/debugger_shell.h
   M /trunk/src/chrome/tools/build/win/test_shell_tests.vsprops
   M /trunk/src/webkit/build/V8Bindings/using_v8bindings.vsprops
   M /trunk/src/webkit/glue/debugger.cc
   M /trunk/src/webkit/glue/debugger.h

Change the path of the V8 API headers from public to include
------------------------------------------------------------------------
r1664 | petersont@google.com | 2008-09-03 03:43:42 +0200 (Wed, 03 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

c_str was getting called on the return value of a function.  The return value would get destroyed when out of scope invalidating the pointer.  Quick fix: copy the return value of the function into a local std::string, and call c_str on that.

R=nsylvain

------------------------------------------------------------------------
r1662 | sky@google.com | 2008-09-03 02:18:21 +0200 (Wed, 03 Sep 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Fixes crash in making Chrome the default browser from the options
dialog. The crash happened if you clicked 'make chrome the default',
then closed the window before we verified the choice stuck.

BUG=1355679
TEST=make sure setting chrome as the default browser still works.

------------------------------------------------------------------------
r1659 | sky@google.com | 2008-09-03 00:06:44 +0200 (Wed, 03 Sep 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_storage.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   A /trunk/src/chrome/test/interactive_ui/view_event_test_base.cc (from /trunk/src/chrome/test/ui/view_event_test_base.cc:1529)
   A /trunk/src/chrome/test/interactive_ui/view_event_test_base.h (from /trunk/src/chrome/test/ui/view_event_test_base.h:1529)
   D /trunk/src/chrome/test/ui/view_event_test_base.cc
   D /trunk/src/chrome/test/ui/view_event_test_base.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Moves the bookmark bar view test into the interactive tests. To get
this to work I changed the interactive ui tests to link with
everything the unit tests do. I did this by way of clicking on the
dependencies dialog in VS. Let me know if that wasn't right. I also
had to slightly tweak BookmarkBarModel and BookmarkStorage to deal
with changes I did a while back. These changes only matter during
testing (background thread is NULL).

BUG=1318942
TEST=none

------------------------------------------------------------------------
r1657 | jam@chromium.org | 2008-09-02 22:46:01 +0200 (Tue, 02 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc

Take out uneeded comment (and test public Rietveld instance!).

------------------------------------------------------------------------
r1636 | deanm@google.com | 2008-09-02 15:11:46 +0200 (Tue, 02 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/base/atomic_sequence_num.h
   M /trunk/src/base/timer.cc
   M /trunk/src/chrome/browser/printing/print_settings.cc

Add a LinkerInitialized constructor to AtomicSequenceNumber.
------------------------------------------------------------------------
r1624 | mal@google.com | 2008-09-02 04:30:55 +0200 (Tue, 02 Sep 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

Add sourceid=chrome to Google's entry on trunk.

BUG=1176073,1322174,1341137
TBR= pkasting@google.com
------------------------------------------------------------------------
r1607 | sgk@google.com | 2008-09-01 17:11:09 +0200 (Mon, 01 Sep 2008) | 2 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/SConstruct
   M /trunk/src/base/gfx/SConscript
   M /trunk/src/breakpad/SConscript
   M /trunk/src/build/SConscript.googleurl
   M /trunk/src/build/SConscript.v8
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/SConstruct
   M /trunk/src/chrome/app/resources/SConscript
   M /trunk/src/chrome/app/theme/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/debugger/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/plugin/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/activex_test_control/SConscript
   M /trunk/src/chrome/test/automation/SConscript
   M /trunk/src/chrome/test/chrome_plugin/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/memory_test/SConscript
   M /trunk/src/chrome/test/mini_installer_test/SConscript
   M /trunk/src/chrome/test/page_cycler/SConscript
   M /trunk/src/chrome/test/plugin/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/security_tests/SConscript
   M /trunk/src/chrome/test/selenium/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/test/tab_switching/SConscript
   M /trunk/src/chrome/tools/crash_service/SConscript
   M /trunk/src/chrome/tools/perf/flush_cache/SConscript
   M /trunk/src/chrome/tools/test/image_diff/SConscript
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/google_update/SConscript
   M /trunk/src/net/SConscript
   M /trunk/src/net/tools/tld_cleanup/SConscript
   M /trunk/src/rlz/SConscript
   M /trunk/src/sandbox/SConstruct
   M /trunk/src/sandbox/src/SConscript
   M /trunk/src/skia/SConscript
   M /trunk/src/testing/SConscript.gtest
   M /trunk/src/webkit/SConscript
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/activex_shim/SConscript
   M /trunk/src/webkit/activex_shim_dll/SConscript
   M /trunk/src/webkit/build/JSConfig/SConscript
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/V8Bindings/SConscript
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/build/localized_strings/SConscript
   M /trunk/src/webkit/build/port/SConscript
   M /trunk/src/webkit/default_plugin/SConscript
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/plugins/test/SConscript
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript

Update Copyright text in SCons config files.
TBR: beng
------------------------------------------------------------------------
r1603 | nsylvain@google.com | 2008-09-01 01:30:18 +0200 (Mon, 01 Sep 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Disable the "Complex" Script because it fails.

BUG:1353559
TBR:maruel

------------------------------------------------------------------------
r1601 | rahulk@google.com | 2008-09-01 01:03:58 +0200 (Mon, 01 Sep 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Change SafeBrowsing client name for Chromium.BUG=1296800
------------------------------------------------------------------------
r1600 | rahulk@google.com | 2008-08-31 21:05:03 +0200 (Sun, 31 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/renderer/renderer_main.cc

Some more changes so that Chromium and Google Chrome do not clash with each other while running at the same time.

BUG=1296800

------------------------------------------------------------------------
r1586 | aa@google.com | 2008-08-30 03:36:02 +0200 (Sat, 30 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/common/sqlite_compiled_statement.h
   M /trunk/src/chrome/common/sqlite_utils.h
   D /trunk/src/chrome/third_party/sqlite
   A /trunk/src/third_party/sqlite (from /trunk/src/chrome/third_party/sqlite:986)
   D /trunk/src/third_party/sqlite/limits.h
   M /trunk/src/third_party/sqlite/sqlite.vcproj
   M /trunk/src/tools/purify/purify_message.py

Move SQLite from src/chrome/third_party to src/third_party
since it will be shared with WebCore and Gears in the
future.
------------------------------------------------------------------------
r1565 | ifette@google.com | 2008-08-30 01:42:20 +0200 (Sat, 30 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc

On line 138 of protocol_manager.cc we were converting a std::string
to a char*. The string could contain null bytes, which led to data
loss and failures in safebrowsing.

R=wtc
BUG=1352561
------------------------------------------------------------------------
r1564 | erg@google.com | 2008-08-30 01:41:12 +0200 (Sat, 30 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc

Implement the 11th hour Google Chrome Beta behaviour for constrained
popup windwos:

- Pull out the favicon
- Manually check the current locale; if it's an english one then
  display the string "Popup Blocked", otherwise use just the
  popup's title (without the product name suffixed to it).

BUG=1085485
------------------------------------------------------------------------
r1547 | cpu@google.com | 2008-08-29 21:51:06 +0200 (Fri, 29 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/logging_chrome.cc

Adds a logging level command line switch

- Adds --log-level=n  with n=0,1,2,3
- Increases the default logging level from INFO to WARNING there is way too much noise there.

------------------------------------------------------------------------
r1546 | sky@google.com | 2008-08-29 21:48:58 +0200 (Fri, 29 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/common/notification_types.h

Modifies the query parser to provide the position of the match in the
title. I'm going to use this in the omnibox. There are a couple of
other random spelling errors I came across that are included for your
review pleasure.

BUG=1256202
TEST=none

------------------------------------------------------------------------
r1545 | sky@google.com | 2008-08-29 21:46:56 +0200 (Fri, 29 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h

Makes the HistoryContentsProvider query bookmark titles. I nuked a
couple of fields that I felt were redundant. I'm pretty sure I got the
same logic, but you better stare at this to convince yourself.

BUG=1256202
TEST=covered by unit tests

------------------------------------------------------------------------
r1538 | sky@google.com | 2008-08-29 20:45:30 +0200 (Fri, 29 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h

Fixes bug where it was possible for tab to get the wrong title. Came
across this in investigating another problem.

BUG=1307747
TEST=Create > 3 tabs. In the last one open the html file attached to
  1305707. Click on the button. Rapidly drag the first tab in and
  out of the tab strip and make sure none of the remaining tabs get the wrong title.

------------------------------------------------------------------------
r1533 | pamg@google.com | 2008-08-29 18:39:54 +0200 (Fri, 29 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_shell.h

Fix disabled debugger project in JSC.

TBR=sgjesse

BUG=none
TEST=none
------------------------------------------------------------------------
r1526 | sgjesse@google.com | 2008-08-29 13:07:40 +0200 (Fri, 29 Aug 2008) | 35 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/chrome/browser/debugger/resources/debugger_shell.js
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/debug_message_handler.cc
   M /trunk/src/chrome/renderer/debug_message_handler.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/test/debugger/test_protocol.js
   M /trunk/src/webkit/glue/debugger.cc
   M /trunk/src/webkit/glue/debugger.h

Made changes to the JavaScript debugger in preparing for an upcoming
change in V8 where the implicit breaks currently issued when receiving
a command while running will be removed. To get in contact with the
V8 debugging interface and send messages V8 needs to be in the break
state. Getting V8 into the break state will be the responsebility of the
debugger using the V8 debugging interface.

Changed the messages between the renderer and the debugger. There are now
explicit messages for break and detach. Alse renamed the SendToDebugger
message to DebugCommand. There is now messages DebugAttach, DebugBreak,
DebugCommand and DebugDetach. The message DebugBreak has a force flag
to indicate whether the renderer should issue some JavaScript to help
the break along or whether it should just schedule a break to happen
whenever JavaScript executes.

Removed the artificial attach JSON response send by the renderer and
replaced that with an on debug attach call to the debugger shell. This
call is reouted to the on_attach function in the debugger JavScript code.

Changed the debugger to issue break requests whenever a suitable command,
e.g. setting a break point, is issued. In this case a flag is used to
track whether execution should be automatically resumed after the command
have been send to the V8 debugger interface. Changed the handling of the
plain break event to not force a break by executing additional JavaScript.
Thereby a plain break does not break JavaScript execution until code on
the tab beeing debugged is actually executed.

Set the command name explicitly on all commands.

Removed parseSimpleCommand as it was just used for the the continue command
for which an explicit parseContinueCommand has been added.

Removed the last_command field from DebugShell as it was not used.

Updated the debugger protocol test to reflect the removed attach event.
------------------------------------------------------------------------
r1521 | sgk@google.com | 2008-08-29 11:02:49 +0200 (Fri, 29 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript
   D /trunk/src/chrome/browser/navigation_performance_viewer.cc
   D /trunk/src/chrome/browser/navigation_performance_viewer.h

Remove navigation_performance_viewer.{cc,h} from the SCons build,
and for real.
TBR: brettw
------------------------------------------------------------------------
r1512 | sky@google.com | 2008-08-29 00:33:36 +0200 (Fri, 29 Aug 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h

Fixes crash in ClearBrowsingDataView that can only occur during the
automated tests. If the window is closed while a removal is in
progress the BrowsingDataRemover would be left with a reference to a
deleted object. This can only happen during automated testing as
while clearing is in progress we don't allow the user to close the
dialog.

BUG=1138705
TEST=covered by automated test bot

------------------------------------------------------------------------
r1508 | finnur@google.com | 2008-08-29 00:11:13 +0200 (Fri, 29 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc

We should not EXPECT to get a browser object or a window object, we should ASSERT that we got it (which ends the test on NULL pointers). Otherwise we continue on and crash when we try to use these pointers, such as when passing it into GetBrowserForWindow.

------------------------------------------------------------------------
r1507 | brettw@google.com | 2008-08-29 00:11:07 +0200 (Fri, 29 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/web_contents_unittest.cc

Forgotten unit test chanes.
------------------------------------------------------------------------
r1506 | brettw@google.com | 2008-08-29 00:10:17 +0200 (Fri, 29 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/info_bar_view.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/notification_types.h

Make a step on refactoring navigation. The eventual plan is to have the NavigationController create and commit the new NavigationEntries (currently WebContents does a bunch of the details of this which is hard to understand and not easily testable).

This tries to consolidate the logic that I want to move to the NavigationController without actually moving it there yet. I removed all of the "PreCommit" functions in WebContents, since when the NavigationController does
all of the committing, there won't be a phase where the NavigationEntry exists but isn't committed.

Most of the logic could be moved to the PostCommit functions without any problem, which is an indication that the current design was busted anyway. I had to precompute some data and pass it to the *PostCommit function to work around some of the components that required old data. I had to change InfoBars around since it relied on having both the committed and uncommitted entries, but I think the new design is much better anyway.

BUG=1343593,1343146
------------------------------------------------------------------------
r1502 | darin@google.com | 2008-08-28 22:50:12 +0200 (Thu, 28 Aug 2008) | 21 lines
Changed paths:
   M /trunk/src/base/idle_timer.cc
   M /trunk/src/base/idle_timer.h
   M /trunk/src/base/idletimer_unittest.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/task.h
   M /trunk/src/base/timer.cc
   M /trunk/src/base/timer.h
   M /trunk/src/base/timer_unittest.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/download_file.h
   M /trunk/src/chrome/browser/download_tab_view.h
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/save_file_manager.h
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/common/animation.cc
   M /trunk/src/chrome/common/animation.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/views/throbber.h
   M /trunk/src/net/base/client_socket_pool.cc
   M /trunk/src/net/base/client_socket_pool.h
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/backend_impl.h
   M /trunk/src/net/disk_cache/stress_cache.cc

Simplify OneShotTimer and RepeatingTimer.  Fix up all consumers.

Major changes:

OneShotTimer and RepeatingTimer become template classes that no longer require
a Task or a Timer object.  They just use PostDelayedTask.  Under the hood that
still uses a Timer object.

The API is much simpler for consumers as they now no longer need to worry about
allocating a Task or managing the lifetime of the object pointer held by the
Task.

I added some new unit tests to timer_unittest.cc to cover the API.

I preserved the old TimerManager / Timer API for now, but I plan to soon kill
it.

R=brettw
BUG=1346553


------------------------------------------------------------------------
r1501 | sky@google.com | 2008-08-28 22:43:50 +0200 (Thu, 28 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc

Attempt at fixing crash in TaskManager. I'm skeptical this is it, but
it's worth a shot.

BUG=1345092
TEST=none

------------------------------------------------------------------------
r1498 | finnur@google.com | 2008-08-28 22:12:36 +0200 (Thu, 28 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_interactive_uitest.cc

Fix for the redness in the interactive test. We were using GetActiveWindow to get the Browser window, which internally uses ::GetForegroundWindow(). This means that when other application windows are on top we fail to get the Browser window. By switching to GetLastActiveWindow() we avoid that.

------------------------------------------------------------------------
r1496 | erg@google.com | 2008-08-28 20:36:37 +0200 (Thu, 28 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

The GetWindowRect must return the rect of the container HWND; not the actual window rect. The usage of GetWindowRect in the ChromeClientImpl::windowRect() function is erroneous, and my modification of GetWindowRect to return the HWND's root ancestor rect broke drop down combo boxes and other embeded controls.

So instead, add a GetRootWindowRect which gets the root anncestor of the HWND's rect and use it in ChromeClientImpl::windowRect().

BUG=1344367,1186573,1334505
------------------------------------------------------------------------
r1492 | pkasting@google.com | 2008-08-28 19:20:26 +0200 (Thu, 28 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h

Split the AutocompletePopup into model and view classes, step 1.

The just adds "Model" and "View" to the end of the current classname, leaves everything in the same files, and doesn't really change or remove any functionality, creation order, ownership semantics, etc.  In other words, it's basically just moving some code around to get things split into two classes, and the harder work comes later.

Also removes/trims some overly long comments, fixes a couple comment errors I noticed, and trims one or two bits of logic to be shorter.

What really needs review the most is the high-level decisions about how to split data and functionality between the two classes.

BUG=1343512
------------------------------------------------------------------------
r1491 | finnur@google.com | 2008-08-28 19:14:28 +0200 (Thu, 28 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h

No code change, just changing a comment (a nit from my previous review). This fixes that.

TBR=sky

------------------------------------------------------------------------
r1488 | finnur@google.com | 2008-08-28 18:31:57 +0200 (Thu, 28 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_controller.h
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h

Adding a test to catch regressions where the Find box moves when you open and close a tab. Test is disabled until we fix  the bug.

Also made the error message for when tests fails because crash_service isn't running a bit explicit (unrelated to the rest of this change).

BUG=1343052

------------------------------------------------------------------------
r1487 | sky@google.com | 2008-08-28 18:10:30 +0200 (Thu, 28 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h

Fixes regression where we were no longer deleting TabContents when
navigating to a new TabContents.

BUG=1349274
TEST=none

------------------------------------------------------------------------
r1481 | jabdelmalek@google.com | 2008-08-28 07:31:41 +0200 (Thu, 28 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc

Fix problem of safebrowsing database removing an add for a hostname when it got a sub for some prefixes.

BUG=1315628
------------------------------------------------------------------------
r1480 | jungshik@google.com | 2008-08-28 06:32:54 +0200 (Thu, 28 Aug 2008) | 17 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

Add region-specific suggest URLs for Yahoo_xx search engines where suggest service is available.

Add utf8 output flag to Naver (#1 engine in Korea) so that JSON comes back in UTF-8. 

meta.ua (Ukraine search engine) was changed similarly.

Change the url for Yahoo_sg to sg.yahoo.com (from tw.yahoo.com) and that for Yahoo_nz to nz.yahoo.com (from sg.yahoo.com)

Disable the suggestion service for Daum because it returns the result in EUC-KR and currently we assume it's in UTF-8 (issue 1293145).

Also disable Yahoo_xx's that do not offer suggestion/ac services. We can do some mappings (e.g. at, ch => de, qc => ca or fr, hk => tw or en and nl,no,dk, fi => en, the rational for the last being that English proficiency of general public in those countries is rather good.), but disable it for now.

BUG=1342120
TEST=Install various language versions of Chrome and set the default search engines to a regional Yahoo variant and see if suggest works in the omnibar. 
Install Korean Chrome and set the default search engine to Naver and see if suggesst works. 


------------------------------------------------------------------------
r1474 | rahulk@google.com | 2008-08-28 02:58:41 +0200 (Thu, 28 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/resources/about_memory.html

Change Chrome references to Chromium on about:memory page. 

BUG=1296800

------------------------------------------------------------------------
r1473 | rahulk@google.com | 2008-08-28 01:40:22 +0200 (Thu, 28 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/chromium_strings.grd
   M /trunk/src/chrome/app/generated_resources.grd
   M /trunk/src/chrome/app/resources/generated_resources_ar.xtb
   M /trunk/src/chrome/app/resources/generated_resources_bg.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ca.xtb
   M /trunk/src/chrome/app/resources/generated_resources_cs.xtb
   M /trunk/src/chrome/app/resources/generated_resources_da.xtb
   M /trunk/src/chrome/app/resources/generated_resources_de.xtb
   M /trunk/src/chrome/app/resources/generated_resources_el.xtb
   M /trunk/src/chrome/app/resources/generated_resources_en-GB.xtb
   M /trunk/src/chrome/app/resources/generated_resources_es-419.xtb
   M /trunk/src/chrome/app/resources/generated_resources_es.xtb
   M /trunk/src/chrome/app/resources/generated_resources_et.xtb
   M /trunk/src/chrome/app/resources/generated_resources_fi.xtb
   M /trunk/src/chrome/app/resources/generated_resources_fil.xtb
   M /trunk/src/chrome/app/resources/generated_resources_fr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_he.xtb
   M /trunk/src/chrome/app/resources/generated_resources_hi.xtb
   M /trunk/src/chrome/app/resources/generated_resources_hr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_hu.xtb
   M /trunk/src/chrome/app/resources/generated_resources_id.xtb
   M /trunk/src/chrome/app/resources/generated_resources_it.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ja.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ko.xtb
   M /trunk/src/chrome/app/resources/generated_resources_lt.xtb
   M /trunk/src/chrome/app/resources/generated_resources_lv.xtb
   M /trunk/src/chrome/app/resources/generated_resources_nl.xtb
   M /trunk/src/chrome/app/resources/generated_resources_no.xtb
   M /trunk/src/chrome/app/resources/generated_resources_pl.xtb
   M /trunk/src/chrome/app/resources/generated_resources_pt-BR.xtb
   M /trunk/src/chrome/app/resources/generated_resources_pt-PT.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ro.xtb
   M /trunk/src/chrome/app/resources/generated_resources_ru.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sk.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sl.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_sv.xtb
   M /trunk/src/chrome/app/resources/generated_resources_th.xtb
   M /trunk/src/chrome/app/resources/generated_resources_tr.xtb
   M /trunk/src/chrome/app/resources/generated_resources_uk.xtb
   M /trunk/src/chrome/app/resources/generated_resources_vi.xtb
   M /trunk/src/chrome/app/resources/generated_resources_zh-CN.xtb
   M /trunk/src/chrome/app/resources/generated_resources_zh-TW.xtb
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/session_crashed_view.cc
   M /trunk/src/chrome/browser/simple_vista_frame.cc
   M /trunk/src/chrome/browser/simple_xp_frame.cc
   M /trunk/src/chrome/browser/ssl_error_info.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/installer/util/prebuild/create_string_rc.py
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/tools/build/win/language_dll.vsprops

Remove Google Chrome specific strings from common resources file and use them from new resources file that is specific to only Google Chrome.

BUG=1110882

------------------------------------------------------------------------
r1458 | sky@google.com | 2008-08-27 21:27:31 +0200 (Wed, 27 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_storage.cc
   M /trunk/src/chrome/common/pref_service.cc

Changes saving of prefs/bookmarks to try move a second time if first
time fails.

BUG=1347276
TEST=none

------------------------------------------------------------------------
r1456 | finnur@google.com | 2008-08-27 21:11:56 +0200 (Wed, 27 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   A /trunk/src/chrome/test/data/find_in_page/bug_1155639.html

Adding a test to make sure Find restarts properly after a timeout.

BUG=1155639

------------------------------------------------------------------------
r1449 | brettw@google.com | 2008-08-27 20:09:07 +0200 (Wed, 27 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h
   M /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents_unittest.cc

Cleanup navigation_entry.h. I made the accessors consistent and in Google style, and organized and commented all the entries. Hopefully it will be much easier to find things and deal with this class.
------------------------------------------------------------------------
r1448 | beng@google.com | 2008-08-27 19:16:49 +0200 (Wed, 27 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc

The positioning of detached dragged tabs was wrong with the new frames, because I wasn't initializing the value I was passing to RestoreWindowPosition with the specified initial bounds.

B=1031854
------------------------------------------------------------------------
r1444 | nsylvain@google.com | 2008-08-27 17:46:17 +0200 (Wed, 27 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h

Fix header guard

------------------------------------------------------------------------
r1440 | nsylvain@google.com | 2008-08-27 16:24:43 +0200 (Wed, 27 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h

Fix header guard

------------------------------------------------------------------------
r1432 | darin@google.com | 2008-08-27 08:41:50 +0200 (Wed, 27 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

Again, call RunAllPending to flush out the pending tasks.  This is done to make
Purify happy.

"wack a mole"

TBR=erikkay

------------------------------------------------------------------------
r1431 | darin@google.com | 2008-08-27 08:33:18 +0200 (Wed, 27 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/views/focus_manager_unittest.cc

Explicitly call RunAllPending in the Teardown phase a few more unit tests to
prevent Purify from complaining about these pending tasks as MLKs.

TBR=erikkay

------------------------------------------------------------------------
r1430 | darin@google.com | 2008-08-27 07:45:10 +0200 (Wed, 27 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc

Flush the message loop in the Teardown phase of these tests.  This helps Purify
not complain about transient memory leaks related to queued up tasks that never
run otherwise.

TBR=erikkay

------------------------------------------------------------------------
r1426 | finnur@google.com | 2008-08-27 06:15:38 +0200 (Wed, 27 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

No code change. Just adding some comments explaining why we need to keep track of whether or not we are importing when Cancel is called. It was non-obvious and it wasn't until I had attempted to remove it that the reason became clear (Cancel is called again when ImportEnded calls Window::Close and we must return true in this case).

------------------------------------------------------------------------
r1425 | finnur@google.com | 2008-08-27 06:15:31 +0200 (Wed, 27 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/data/find_in_page/crash_1341577.html

Adding a UI test to catch the crash described in issue 1341577.This test is disabled, and will be turned on once we fix the issue.I added to TabProxy the ability to do FindNext, which was necessary to reproduce the crash, and changed the automation IPC to take a FindInPageRequest struct, which makes it identical to the IPC we pass to render_view.BUG=1341577
------------------------------------------------------------------------
r1423 | sky@google.com | 2008-08-27 05:27:46 +0200 (Wed, 27 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   M /trunk/src/chrome/browser/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmark_storage.cc
   A /trunk/src/chrome/browser/bookmarks
   A /trunk/src/chrome/browser/bookmarks/bookmark_service.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Makes deleting history no longer delete starred urls. Thiseffectively reenables the code in ExpireHistoryBackend. I also madethe code consistent so that when we delete visits as the result ofhistory deletion we don't change the typed/visit count of theunderlying url.BUG=1214201 1256202TEST=none
------------------------------------------------------------------------
r1416 | beng@google.com | 2008-08-27 03:37:16 +0200 (Wed, 27 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller.cc

Position the find box correctly with the new frames.

B=1031854
------------------------------------------------------------------------
r1413 | beng@google.com | 2008-08-27 01:55:50 +0200 (Wed, 27 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/views/menu.h

Make the system menu for frames have submenus for encoding and text zoom

B=1031854
------------------------------------------------------------------------
r1411 | iyengar@google.com | 2008-08-27 01:51:53 +0200 (Wed, 27 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc

Bumping up the default hung plugin timeout to 30 seconds. This matches with
the hung webpage timeout. The other change is to take out the IsHungAppWindow
call as this is redundant when combined with SendMessageTimeout.

Bug=1308327

------------------------------------------------------------------------
r1388 | klink@google.com | 2008-08-26 20:21:24 +0200 (Tue, 26 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/menu_button.cc

Extends the toolbar keyboard support. Adds skipping of unavailable elements of the toolbar, to accomodate for quicker keyboard traversal. Fixes tooltip display on initial focusing of the toolbar. Also fixes the support for VK_SPACE and VK_ENTER.


------------------------------------------------------------------------
r1373 | darin@google.com | 2008-08-26 09:56:10 +0200 (Tue, 26 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc

Disable the interceptor DCHECK that we are only called from a single thread.
Given recent changes, the unit tests now make URLRequest calls from multiple
threads but not simultaneously.  See TestServer::MakeGETRequest.

I think the interceptor list needs to be stored on the URLRequestContext or
it needs to be made thread safe.

TBR=mpcomplete

------------------------------------------------------------------------
r1371 | darin@google.com | 2008-08-26 09:28:34 +0200 (Tue, 26 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/download_manager_unittest.cc
   M /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/renderer/spellcheck_unittest.cc

fix unit tests
------------------------------------------------------------------------
r1363 | darin@google.com | 2008-08-26 07:55:10 +0200 (Tue, 26 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   M /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   M /trunk/src/chrome/browser/bookmark_storage.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/download_file.cc
   M /trunk/src/chrome/browser/download_manager.cc
   M /trunk/src/chrome/browser/download_manager.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/importer_unittest.cc
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/network_status_view.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/save_file_manager.cc
   M /trunk/src/chrome/browser/save_package.h
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/common/animation_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/ipc_channel.cc
   M /trunk/src/chrome/common/ipc_channel.h
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/process_watcher.cc
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/ui/run_all_unittests.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_test_suite.h
   M /trunk/src/chrome/test/ui/view_event_test_base.cc
   M /trunk/src/chrome/test/ui/view_event_test_base.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/test/unit/run_all_unittests.cc
   M /trunk/src/chrome/views/accelerator_handler.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/view_unittest.cc

Chrome changes corresponding to my message_loop_type CL.

------------------------------------------------------------------------
r1360 | ericcheng@google.com | 2008-08-26 04:02:18 +0200 (Tue, 26 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

Fix build break caused by some functions not ifdef CHROME_PERSONALIZATION'd out.

------------------------------------------------------------------------
r1359 | ericcheng@google.com | 2008-08-26 03:27:35 +0200 (Tue, 26 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/cpp_variant.h
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Some more glue code for the personalization module.
Added ability to invoke a method on an NPObject wrapped in
a CppVariant.

------------------------------------------------------------------------
r1342 | klink@google.com | 2008-08-26 00:26:25 +0200 (Tue, 26 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Sets the visibility bool of the Home button.

------------------------------------------------------------------------
r1341 | brettw@google.com | 2008-08-26 00:18:06 +0200 (Tue, 26 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/navigation_entry.h
   D /trunk/src/chrome/browser/navigation_profiler.cc
   D /trunk/src/chrome/browser/navigation_profiler.h
   D /trunk/src/chrome/browser/navigation_profiler_unittest.cc
   M /trunk/src/chrome/browser/network_status_view.cc
   M /trunk/src/chrome/browser/network_status_view.h
   D /trunk/src/chrome/browser/page_load_tracker.cc
   D /trunk/src/chrome/browser/page_load_tracker.h
   D /trunk/src/chrome/browser/page_load_tracker_unittest.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Remove the profiling system. This wasn't being used and complicated some parts of the code (I'm trying to clean up WebContents). We can ressurect this if we have a better plan for doing profiling that needs to live in the browser.

------------------------------------------------------------------------
r1340 | beng@google.com | 2008-08-26 00:11:49 +0200 (Tue, 26 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.h

Make the AeroGlassFrame better:

- client edge rendering is now pixel-perfect for all BrowserTypes.
- fix NCCALCSIZE handling that was making our top-right corner less than perfectly round
- make system menu work
- remove some unnecessary functions

B=1031854
------------------------------------------------------------------------
r1338 | erg@google.com | 2008-08-26 00:10:37 +0200 (Tue, 26 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc

Create a unit test for making sure constrined popup windows close when their X is clicked. Currently this unit test fails. It should.

BUGS=1341975
------------------------------------------------------------------------
r1335 | beng@google.com | 2008-08-25 23:30:42 +0200 (Mon, 25 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc

Fix bug in constrained windows where the close box was detaching instead of closing. We weren't considering HTCLOSE in the test of acceptable hittest components that might cause detaching.

B=1341975
------------------------------------------------------------------------
r1328 | beng@google.com | 2008-08-25 22:37:28 +0200 (Mon, 25 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/views/window_delegate.cc
   M /trunk/src/chrome/views/window_delegate.h

Second attempt at fixing task manager crash. Provide a protected ReleaseWindow methods that recycled delegates can use to release the window ptr they use. Currently only one delegate uses this (TaskManager). It'd be nice if TaskManager wasn't a singleton...

B=1333829

------------------------------------------------------------------------
r1327 | beng@google.com | 2008-08-25 22:37:23 +0200 (Mon, 25 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab.cc
   M /trunk/src/chrome/browser/tabs/tab.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h

Make tabs highlight and accept clicks based on the shape of the rendered tab, rather than the bounding box of the view that renders it. This allows for truer event handling.

B=656878
------------------------------------------------------------------------
r1326 | beng@google.com | 2008-08-25 22:37:11 +0200 (Mon, 25 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_renderer.cc

Fix flicker of hover state on mouseover of tabs. The pulsating code was a little convoluted and was accidentally causing the non-highlighted state to be painted for the last frame of the animation.

B=1317898

------------------------------------------------------------------------
r1321 | erikkay@google.com | 2008-08-25 22:04:33 +0200 (Mon, 25 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_unittest.cc

Fix a leak in HistoryProfileTest.TypicalProfileVersion.

sqlite3_close returns SQLITE_BUSY if there are any outstanding statements.  Since the SQLStatement object hadn't been destroyed, finalize hadn't been called, so the close failed and a lot of sqlite stuff leaked.


------------------------------------------------------------------------
r1314 | brettw@google.com | 2008-08-25 20:24:45 +0200 (Mon, 25 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Add some new tests for NavigationController for navigations that come in when various navigations are pending. This doesn't actually change any behavior.
------------------------------------------------------------------------
r1306 | deanm@google.com | 2008-08-25 15:54:18 +0200 (Mon, 25 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/base/platform_thread.h
   M /trunk/src/base/platform_thread_posix.cc
   M /trunk/src/base/platform_thread_win.cc
   M /trunk/src/base/thread.cc
   M /trunk/src/base/watchdog.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_slave.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/test/ui/run_all_unittests.cc

Make PlatformThread::SetName operate only on the current thread.
------------------------------------------------------------------------
r1296 | beng@google.com | 2008-08-24 20:57:55 +0200 (Sun, 24 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc

fix release bustage.
------------------------------------------------------------------------
r1295 | beng@google.com | 2008-08-24 20:52:01 +0200 (Sun, 24 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc

fix release bustage.
------------------------------------------------------------------------
r1294 | beng@google.com | 2008-08-24 20:43:07 +0200 (Sun, 24 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/tab_icon_view.cc

fix release bustage.
------------------------------------------------------------------------
r1293 | beng@google.com | 2008-08-24 20:25:11 +0200 (Sun, 24 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.cc

Make the window icon the app icon by default for popups and app windows unless the page specifies a favicon. This ensures that we don't show the default favicon for the window icon. (This is only appropriate for tab icons).

Also make sure popup windows opened from app windows are themselves app windows (and don't show the URL bar)

B=1031854
------------------------------------------------------------------------
r1291 | sky@google.com | 2008-08-24 19:17:55 +0200 (Sun, 24 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/history/history.h

Fixes bogus typedef for HistoryService's empty callback. This turned
up as an UMR. I'm surprised this didn't produce a compiler error.

BUG=1338601
TEST=none

------------------------------------------------------------------------
r1287 | license.bot | 2008-08-24 02:55:55 +0200 (Sun, 24 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/base/at_exit.cc
   M /trunk/src/base/at_exit.h
   M /trunk/src/base/at_exit_unittest.cc
   M /trunk/src/base/atomic_ref_count.h
   M /trunk/src/base/atomic_sequence_num.h
   M /trunk/src/base/atomicops.h
   M /trunk/src/base/atomicops_internals_x86_gcc.cc
   M /trunk/src/base/atomicops_internals_x86_gcc.h
   M /trunk/src/base/atomicops_internals_x86_macosx.h
   M /trunk/src/base/atomicops_internals_x86_msvc.h
   M /trunk/src/base/base_drag_source.cc
   M /trunk/src/base/base_drag_source.h
   M /trunk/src/base/base_drop_target.cc
   M /trunk/src/base/base_drop_target.h
   M /trunk/src/base/base_paths.cc
   M /trunk/src/base/base_paths.h
   M /trunk/src/base/base_paths_linux.cc
   M /trunk/src/base/base_paths_linux.h
   M /trunk/src/base/base_paths_mac.h
   M /trunk/src/base/base_paths_win.cc
   M /trunk/src/base/base_paths_win.h
   M /trunk/src/base/base_switches.cc
   M /trunk/src/base/base_switches.h
   M /trunk/src/base/basictypes.h
   M /trunk/src/base/bzip2_error_handler.cc
   M /trunk/src/base/clipboard.h
   M /trunk/src/base/clipboard_unittest.cc
   M /trunk/src/base/clipboard_util.cc
   M /trunk/src/base/clipboard_util.h
   M /trunk/src/base/clipboard_win.cc
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/command_line.h
   M /trunk/src/base/command_line_unittest.cc
   M /trunk/src/base/compiler_specific.h
   M /trunk/src/base/condition_variable.h
   M /trunk/src/base/condition_variable_posix.cc
   M /trunk/src/base/condition_variable_test.cc
   M /trunk/src/base/condition_variable_win.cc
   M /trunk/src/base/debug_message.cc
   M /trunk/src/base/debug_on_start.cc
   M /trunk/src/base/debug_on_start.h
   M /trunk/src/base/debug_util.cc
   M /trunk/src/base/debug_util.h
   M /trunk/src/base/debug_util_posix.cc
   M /trunk/src/base/debug_util_win.cc
   M /trunk/src/base/event_recorder.cc
   M /trunk/src/base/event_recorder.h
   M /trunk/src/base/file_util.cc
   M /trunk/src/base/file_util.h
   M /trunk/src/base/file_util_linux.cc
   M /trunk/src/base/file_util_posix.cc
   M /trunk/src/base/file_util_unittest.cc
   M /trunk/src/base/file_util_win.cc
   M /trunk/src/base/file_version_info.cc
   M /trunk/src/base/file_version_info.h
   M /trunk/src/base/file_version_info_unittest.cc
   M /trunk/src/base/fix_wp64.h
   M /trunk/src/base/float_util.h
   M /trunk/src/base/gfx/bitmap_header.cc
   M /trunk/src/base/gfx/bitmap_header.h
   M /trunk/src/base/gfx/bitmap_platform_device.h
   M /trunk/src/base/gfx/bitmap_platform_device_mac.cc
   M /trunk/src/base/gfx/bitmap_platform_device_mac.h
   M /trunk/src/base/gfx/bitmap_platform_device_win.cc
   M /trunk/src/base/gfx/bitmap_platform_device_win.h
   M /trunk/src/base/gfx/convolver.cc
   M /trunk/src/base/gfx/convolver.h
   M /trunk/src/base/gfx/convolver_unittest.cc
   M /trunk/src/base/gfx/font_utils.cc
   M /trunk/src/base/gfx/font_utils.h
   M /trunk/src/base/gfx/image_operations.cc
   M /trunk/src/base/gfx/image_operations.h
   M /trunk/src/base/gfx/image_operations_unittest.cc
   M /trunk/src/base/gfx/img_resize_perftest.cc
   M /trunk/src/base/gfx/native_theme.cc
   M /trunk/src/base/gfx/native_theme.h
   M /trunk/src/base/gfx/native_theme_unittest.cc
   M /trunk/src/base/gfx/platform_canvas.h
   M /trunk/src/base/gfx/platform_canvas_mac.cc
   M /trunk/src/base/gfx/platform_canvas_mac.h
   M /trunk/src/base/gfx/platform_canvas_unittest.cc
   M /trunk/src/base/gfx/platform_canvas_win.cc
   M /trunk/src/base/gfx/platform_canvas_win.h
   M /trunk/src/base/gfx/platform_device.h
   M /trunk/src/base/gfx/platform_device_mac.cc
   M /trunk/src/base/gfx/platform_device_mac.h
   M /trunk/src/base/gfx/platform_device_win.cc
   M /trunk/src/base/gfx/platform_device_win.h
   M /trunk/src/base/gfx/png_codec_unittest.cc
   M /trunk/src/base/gfx/png_decoder.cc
   M /trunk/src/base/gfx/png_decoder.h
   M /trunk/src/base/gfx/png_encoder.cc
   M /trunk/src/base/gfx/png_encoder.h
   M /trunk/src/base/gfx/point.cc
   M /trunk/src/base/gfx/point.h
   M /trunk/src/base/gfx/rect.cc
   M /trunk/src/base/gfx/rect.h
   M /trunk/src/base/gfx/rect_unittest.cc
   M /trunk/src/base/gfx/size.cc
   M /trunk/src/base/gfx/size.h
   M /trunk/src/base/gfx/skia_utils.cc
   M /trunk/src/base/gfx/skia_utils.h
   M /trunk/src/base/gfx/skia_utils_mac.cc
   M /trunk/src/base/gfx/skia_utils_mac.h
   M /trunk/src/base/gfx/uniscribe.cc
   M /trunk/src/base/gfx/uniscribe.h
   M /trunk/src/base/gfx/uniscribe_unittest.cc
   M /trunk/src/base/gfx/vector_canvas.cc
   M /trunk/src/base/gfx/vector_canvas.h
   M /trunk/src/base/gfx/vector_canvas_unittest.cc
   M /trunk/src/base/gfx/vector_device.cc
   M /trunk/src/base/gfx/vector_device.h
   M /trunk/src/base/hash_tables.h
   M /trunk/src/base/histogram.cc
   M /trunk/src/base/histogram.h
   M /trunk/src/base/histogram_test.cc
   M /trunk/src/base/hmac.cc
   M /trunk/src/base/hmac.h
   M /trunk/src/base/hmac_unittest.cc
   M /trunk/src/base/iat_patch.cc
   M /trunk/src/base/iat_patch.h
   M /trunk/src/base/icu_util.cc
   M /trunk/src/base/icu_util.h
   M /trunk/src/base/id_map.h
   M /trunk/src/base/idle_timer.cc
   M /trunk/src/base/idle_timer.h
   M /trunk/src/base/idletimer_unittest.cc
   M /trunk/src/base/image_util.cc
   M /trunk/src/base/image_util.h
   M /trunk/src/base/json_reader.cc
   M /trunk/src/base/json_reader.h
   M /trunk/src/base/json_reader_unittest.cc
   M /trunk/src/base/json_writer.cc
   M /trunk/src/base/json_writer.h
   M /trunk/src/base/json_writer_unittest.cc
   M /trunk/src/base/linked_ptr.h
   M /trunk/src/base/linked_ptr_unittest.cc
   M /trunk/src/base/lock.cc
   M /trunk/src/base/lock.h
   M /trunk/src/base/lock_impl.h
   M /trunk/src/base/lock_impl_posix.cc
   M /trunk/src/base/lock_impl_win.cc
   M /trunk/src/base/logging.cc
   M /trunk/src/base/logging.h
   M /trunk/src/base/md5.h
   M /trunk/src/base/memory_debug.cc
   M /trunk/src/base/memory_debug.h
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_unittest.cc
   M /trunk/src/base/message_pump.h
   M /trunk/src/base/message_pump_default.cc
   M /trunk/src/base/message_pump_default.h
   M /trunk/src/base/message_pump_win.cc
   M /trunk/src/base/message_pump_win.h
   M /trunk/src/base/multiprocess_test.h
   M /trunk/src/base/no_windows2000_unittest.h
   M /trunk/src/base/non_thread_safe.cc
   M /trunk/src/base/non_thread_safe.h
   M /trunk/src/base/notimplemented.h
   M /trunk/src/base/object_watcher.cc
   M /trunk/src/base/object_watcher.h
   M /trunk/src/base/object_watcher_unittest.cc
   M /trunk/src/base/observer_list.h
   M /trunk/src/base/observer_list_unittest.cc
   M /trunk/src/base/path_service.cc
   M /trunk/src/base/path_service.h
   M /trunk/src/base/path_service_unittest.cc
   M /trunk/src/base/pe_image.cc
   M /trunk/src/base/pe_image.h
   M /trunk/src/base/pe_image_unittest.cc
   M /trunk/src/base/perftimer.cc
   M /trunk/src/base/perftimer.h
   M /trunk/src/base/pickle.cc
   M /trunk/src/base/pickle.h
   M /trunk/src/base/pickle_unittest.cc
   M /trunk/src/base/platform_test.h
   M /trunk/src/base/platform_thread.h
   M /trunk/src/base/platform_thread_posix.cc
   M /trunk/src/base/platform_thread_win.cc
   M /trunk/src/base/port.h
   M /trunk/src/base/pr_time_test.cc
   M /trunk/src/base/process.cc
   M /trunk/src/base/process.h
   M /trunk/src/base/process_util.cc
   M /trunk/src/base/process_util.h
   M /trunk/src/base/process_util_unittest.cc
   M /trunk/src/base/ref_counted.cc
   M /trunk/src/base/ref_counted.h
   M /trunk/src/base/ref_counted_unittest.cc
   M /trunk/src/base/registry.cc
   M /trunk/src/base/registry.h
   M /trunk/src/base/resource_util.cc
   M /trunk/src/base/resource_util.h
   M /trunk/src/base/revocable_store.cc
   M /trunk/src/base/revocable_store.h
   M /trunk/src/base/run_all_perftests.cc
   M /trunk/src/base/run_all_unittests.cc
   M /trunk/src/base/scoped_cftyperef.h
   M /trunk/src/base/scoped_handle.h
   M /trunk/src/base/scoped_ptr.h
   M /trunk/src/base/sha2.cc
   M /trunk/src/base/sha2.h
   M /trunk/src/base/sha2_unittest.cc
   M /trunk/src/base/shared_event.cc
   M /trunk/src/base/shared_event.h
   M /trunk/src/base/shared_event_unittest.cc
   M /trunk/src/base/shared_memory.h
   M /trunk/src/base/shared_memory_posix.cc
   M /trunk/src/base/shared_memory_unittest.cc
   M /trunk/src/base/shared_memory_win.cc
   M /trunk/src/base/singleton.h
   M /trunk/src/base/singleton_unittest.cc
   M /trunk/src/base/spin_wait.h
   M /trunk/src/base/stack_container.h
   M /trunk/src/base/stack_container_unittest.cc
   M /trunk/src/base/stats_counters.h
   M /trunk/src/base/stats_table.cc
   M /trunk/src/base/stats_table.h
   M /trunk/src/base/stats_table_unittest.cc
   M /trunk/src/base/string16.h
   M /trunk/src/base/string_escape.cc
   M /trunk/src/base/string_escape.h
   M /trunk/src/base/string_escape_unittest.cc
   M /trunk/src/base/string_piece.cc
   M /trunk/src/base/string_piece.h
   M /trunk/src/base/string_piece_unittest.cc
   M /trunk/src/base/string_tokenizer.h
   M /trunk/src/base/string_tokenizer_unittest.cc
   M /trunk/src/base/string_util.cc
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_icu.cc
   M /trunk/src/base/string_util_posix.h
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/string_util_win.h
   M /trunk/src/base/sys_string_conversions.h
   M /trunk/src/base/sys_string_conversions_linux.cc
   M /trunk/src/base/sys_string_conversions_mac.cc
   M /trunk/src/base/sys_string_conversions_win.cc
   M /trunk/src/base/sys_string_conversions_win_unittest.cc
   M /trunk/src/base/task.h
   M /trunk/src/base/test_suite.h
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread.h
   M /trunk/src/base/thread_local_storage.h
   M /trunk/src/base/thread_local_storage_posix.cc
   M /trunk/src/base/thread_local_storage_unittest.cc
   M /trunk/src/base/thread_local_storage_win.cc
   M /trunk/src/base/thread_unittest.cc
   M /trunk/src/base/time.cc
   M /trunk/src/base/time.h
   M /trunk/src/base/time_format.cc
   M /trunk/src/base/time_format.h
   M /trunk/src/base/time_posix.cc
   M /trunk/src/base/time_unittest.cc
   M /trunk/src/base/time_win.cc
   M /trunk/src/base/timer.cc
   M /trunk/src/base/timer.h
   M /trunk/src/base/timer_unittest.cc
   M /trunk/src/base/tracked.cc
   M /trunk/src/base/tracked.h
   M /trunk/src/base/tracked_objects.cc
   M /trunk/src/base/tracked_objects.h
   M /trunk/src/base/tracked_objects_test.cc
   M /trunk/src/base/tuple.h
   M /trunk/src/base/values.cc
   M /trunk/src/base/values.h
   M /trunk/src/base/values_unittest.cc
   M /trunk/src/base/waitable_event.h
   M /trunk/src/base/waitable_event_generic.cc
   M /trunk/src/base/waitable_event_unittest.cc
   M /trunk/src/base/waitable_event_win.cc
   M /trunk/src/base/watchdog.cc
   M /trunk/src/base/watchdog.h
   M /trunk/src/base/watchdog_test.cc
   M /trunk/src/base/win_util.cc
   M /trunk/src/base/win_util.h
   M /trunk/src/base/win_util_unittest.cc
   M /trunk/src/base/windows_message_list.h
   M /trunk/src/base/wmi_util.cc
   M /trunk/src/base/wmi_util.h
   M /trunk/src/base/wmi_util_unittest.cc
   M /trunk/src/base/word_iterator.cc
   M /trunk/src/base/word_iterator.h
   M /trunk/src/base/word_iterator_unittest.cc
   M /trunk/src/base/worker_pool.cc
   M /trunk/src/base/worker_pool.h
   M /trunk/src/build/build_config.h
   M /trunk/src/chrome/app/breakpad.cc
   M /trunk/src/chrome/app/breakpad.h
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/app/chrome_exe_main.cc
   M /trunk/src/chrome/app/chrome_main_uitest.cc
   M /trunk/src/chrome/app/client_util.cc
   M /trunk/src/chrome/app/client_util.h
   M /trunk/src/chrome/app/google_update_client.cc
   M /trunk/src/chrome/app/google_update_client.h
   M /trunk/src/chrome/app/result_codes.h
   M /trunk/src/chrome/browser/about_internets_status_view.cc
   M /trunk/src/chrome/browser/about_internets_status_view.h
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   M /trunk/src/chrome/browser/app_modal_dialog_queue.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   M /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/edit_drop_target.cc
   M /trunk/src/chrome/browser/autocomplete/edit_drop_target.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   M /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   M /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   M /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   M /trunk/src/chrome/browser/automation/automation_constrained_window_tracker.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_list.cc
   M /trunk/src/chrome/browser/automation/automation_provider_list.h
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.cc
   M /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   M /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   M /trunk/src/chrome/browser/automation/automation_window_tracker.h
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.cc
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.h
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.h
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/back_forward_menu_model.h
   M /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   M /trunk/src/chrome/browser/base_history_model.cc
   M /trunk/src/chrome/browser/base_history_model.h
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   M /trunk/src/chrome/browser/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmark_drag_data_unittest.cc
   M /trunk/src/chrome/browser/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmark_storage.h
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_about_handler.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_focus_uitest.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_init.h
   M /trunk/src/chrome/browser/browser_list.cc
   M /trunk/src/chrome/browser/browser_list.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   M /trunk/src/chrome/browser/browser_prefs.h
   M /trunk/src/chrome/browser/browser_process.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/browser_shutdown.h
   M /trunk/src/chrome/browser/browser_type.h
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/browser_url_handler.cc
   M /trunk/src/chrome/browser/browser_url_handler.h
   M /trunk/src/chrome/browser/browser_window.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/browsing_data_remover.h
   M /trunk/src/chrome/browser/browsing_instance.cc
   M /trunk/src/chrome/browser/browsing_instance.h
   M /trunk/src/chrome/browser/cache_manager_host.cc
   M /trunk/src/chrome/browser/cache_manager_host.h
   M /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   M /trunk/src/chrome/browser/cancelable_request.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.cc
   M /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/chrome_plugin_host.h
   M /trunk/src/chrome/browser/chrome_thread.cc
   M /trunk/src/chrome/browser/chrome_thread.h
   M /trunk/src/chrome/browser/chrome_thread_unittest.cc
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/controller.cc
   M /trunk/src/chrome/browser/controller.h
   M /trunk/src/chrome/browser/controller_unittest.cc
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/cross_site_request_manager.cc
   M /trunk/src/chrome/browser/cross_site_request_manager.h
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/browser/debugger/debugger_contents.h
   M /trunk/src/chrome/browser/debugger/debugger_io.h
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.h
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_node.h
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/chrome/browser/dom_operation_notification_details.h
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc
   M /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/download_exe.cc
   M /trunk/src/chrome/browser/download_file.cc
   M /trunk/src/chrome/browser/download_file.h
   M /trunk/src/chrome/browser/download_item_model.cc
   M /trunk/src/chrome/browser/download_item_model.h
   M /trunk/src/chrome/browser/download_manager.cc
   M /trunk/src/chrome/browser/download_manager.h
   M /trunk/src/chrome/browser/download_manager_unittest.cc
   M /trunk/src/chrome/browser/download_tab_view.cc
   M /trunk/src/chrome/browser/download_tab_view.h
   M /trunk/src/chrome/browser/download_uitest.cc
   M /trunk/src/chrome/browser/download_util.cc
   M /trunk/src/chrome/browser/download_util.h
   M /trunk/src/chrome/browser/drag_utils.cc
   M /trunk/src/chrome/browser/drag_utils.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   M /trunk/src/chrome/browser/encryptor.cc
   M /trunk/src/chrome/browser/encryptor.h
   M /trunk/src/chrome/browser/encryptor_unittest.cc
   M /trunk/src/chrome/browser/errorpage_uitest.cc
   M /trunk/src/chrome/browser/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/external_protocol_dialog.h
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/fav_icon_helper.cc
   M /trunk/src/chrome/browser/fav_icon_helper.h
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_controller.h
   M /trunk/src/chrome/browser/find_in_page_controller_interactive_uitest.cc
   M /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   M /trunk/src/chrome/browser/find_in_page_view.cc
   M /trunk/src/chrome/browser/find_in_page_view.h
   M /trunk/src/chrome/browser/find_notification_details.h
   M /trunk/src/chrome/browser/firefox2_importer.cc
   M /trunk/src/chrome/browser/firefox2_importer.h
   M /trunk/src/chrome/browser/firefox3_importer.cc
   M /trunk/src/chrome/browser/firefox3_importer.h
   M /trunk/src/chrome/browser/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/firefox_importer_utils.h
   M /trunk/src/chrome/browser/firefox_profile_lock.cc
   M /trunk/src/chrome/browser/firefox_profile_lock.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/first_run.h
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/browser/frame_util.h
   M /trunk/src/chrome/browser/frame_view.cc
   M /trunk/src/chrome/browser/frame_view.h
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/google_update.h
   M /trunk/src/chrome/browser/google_url_tracker.cc
   M /trunk/src/chrome/browser/google_url_tracker.h
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.h
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc
   M /trunk/src/chrome/browser/hang_monitor/hung_window_detector.h
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/download_database.cc
   M /trunk/src/chrome/browser/history/download_database.h
   M /trunk/src/chrome/browser/history/download_types.h
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_types_unittest.cc
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_database.cc
   M /trunk/src/chrome/browser/history/in_memory_database.h
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/page_usage_data.cc
   M /trunk/src/chrome/browser/history/page_usage_data.h
   M /trunk/src/chrome/browser/history/query_parser.cc
   M /trunk/src/chrome/browser/history/query_parser.h
   M /trunk/src/chrome/browser/history/query_parser_unittest.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/history/snippet.cc
   M /trunk/src/chrome/browser/history/snippet.h
   M /trunk/src/chrome/browser/history/snippet_unittest.cc
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.cc
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   M /trunk/src/chrome/browser/history/text_database_unittest.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.cc
   M /trunk/src/chrome/browser/history/thumbnail_database.h
   M /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/history/visit_database.cc
   M /trunk/src/chrome/browser/history/visit_database.h
   M /trunk/src/chrome/browser/history/visit_database_unittest.cc
   M /trunk/src/chrome/browser/history/visit_tracker.cc
   M /trunk/src/chrome/browser/history/visit_tracker.h
   M /trunk/src/chrome/browser/history/visit_tracker_unittest.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.cc
   M /trunk/src/chrome/browser/history/visitsegment_database.h
   M /trunk/src/chrome/browser/history_model.cc
   M /trunk/src/chrome/browser/history_model.h
   M /trunk/src/chrome/browser/history_tab_ui.cc
   M /trunk/src/chrome/browser/history_tab_ui.h
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/history_view.h
   M /trunk/src/chrome/browser/icon_loader.cc
   M /trunk/src/chrome/browser/icon_loader.h
   M /trunk/src/chrome/browser/icon_manager.cc
   M /trunk/src/chrome/browser/icon_manager.h
   M /trunk/src/chrome/browser/ie7_password.cc
   M /trunk/src/chrome/browser/ie7_password.h
   M /trunk/src/chrome/browser/ie_importer.cc
   M /trunk/src/chrome/browser/ie_importer.h
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/images_uitest.cc
   M /trunk/src/chrome/browser/ime_input.cc
   M /trunk/src/chrome/browser/ime_input.h
   M /trunk/src/chrome/browser/importer.cc
   M /trunk/src/chrome/browser/importer.h
   M /trunk/src/chrome/browser/importer_unittest.cc
   M /trunk/src/chrome/browser/interstitial_page_delegate.h
   M /trunk/src/chrome/browser/interstitial_page_uitest.cc
   M /trunk/src/chrome/browser/ipc_status_view.cc
   M /trunk/src/chrome/browser/ipc_status_view.h
   M /trunk/src/chrome/browser/jankometer.cc
   M /trunk/src/chrome/browser/jankometer.h
   M /trunk/src/chrome/browser/js_before_unload_handler.cc
   M /trunk/src/chrome/browser/js_before_unload_handler.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/load_from_memory_cache_details.h
   M /trunk/src/chrome/browser/load_notification_details.h
   M /trunk/src/chrome/browser/locale_tests_uitest.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/login_prompt_uitest.cc
   M /trunk/src/chrome/browser/memory_details.cc
   M /trunk/src/chrome/browser/memory_details.h
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/chrome/browser/meta_table_helper.h
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_log.h
   M /trunk/src/chrome/browser/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/metrics_response.cc
   M /trunk/src/chrome/browser/metrics_response.h
   M /trunk/src/chrome/browser/metrics_response_unittest.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   M /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h
   M /trunk/src/chrome/browser/navigation_performance_viewer.cc
   M /trunk/src/chrome/browser/navigation_performance_viewer.h
   M /trunk/src/chrome/browser/navigation_profiler.cc
   M /trunk/src/chrome/browser/navigation_profiler.h
   M /trunk/src/chrome/browser/navigation_profiler_unittest.cc
   M /trunk/src/chrome/browser/net/dns_global.cc
   M /trunk/src/chrome/browser/net/dns_global.h
   M /trunk/src/chrome/browser/net/dns_host_info.cc
   M /trunk/src/chrome/browser/net/dns_host_info.h
   M /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/net/dns_slave.cc
   M /trunk/src/chrome/browser/net/dns_slave.h
   M /trunk/src/chrome/browser/network_status_view.cc
   M /trunk/src/chrome/browser/network_status_view.h
   M /trunk/src/chrome/browser/options_window.h
   M /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/page_load_tracker.cc
   M /trunk/src/chrome/browser/page_load_tracker.h
   M /trunk/src/chrome/browser/page_load_tracker_unittest.cc
   M /trunk/src/chrome/browser/page_navigator.h
   M /trunk/src/chrome/browser/page_state.cc
   M /trunk/src/chrome/browser/page_state.h
   M /trunk/src/chrome/browser/password_form_manager.cc
   M /trunk/src/chrome/browser/password_form_manager.h
   M /trunk/src/chrome/browser/password_form_manager_unittest.cc
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/password_manager.h
   M /trunk/src/chrome/browser/plugin_installer.cc
   M /trunk/src/chrome/browser/plugin_installer.h
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/plugin_process_info.h
   M /trunk/src/chrome/browser/plugin_service.cc
   M /trunk/src/chrome/browser/plugin_service.h
   M /trunk/src/chrome/browser/point_buffer.cc
   M /trunk/src/chrome/browser/point_buffer.h
   M /trunk/src/chrome/browser/printing/page_number.cc
   M /trunk/src/chrome/browser/printing/page_number.h
   M /trunk/src/chrome/browser/printing/page_number_unittest.cc
   M /trunk/src/chrome/browser/printing/page_overlays.cc
   M /trunk/src/chrome/browser/printing/page_overlays.h
   M /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   M /trunk/src/chrome/browser/printing/page_range.cc
   M /trunk/src/chrome/browser/printing/page_range.h
   M /trunk/src/chrome/browser/printing/page_range_unittest.cc
   M /trunk/src/chrome/browser/printing/page_setup.cc
   M /trunk/src/chrome/browser/printing/page_setup.h
   M /trunk/src/chrome/browser/printing/page_setup_unittest.cc
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_manager.cc
   M /trunk/src/chrome/browser/printing/print_job_manager.h
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   M /trunk/src/chrome/browser/printing/print_settings.cc
   M /trunk/src/chrome/browser/printing/print_settings.h
   M /trunk/src/chrome/browser/printing/print_view_manager.cc
   M /trunk/src/chrome/browser/printing/print_view_manager.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printed_document.h
   M /trunk/src/chrome/browser/printing/printed_page.cc
   M /trunk/src/chrome/browser/printing/printed_page.h
   M /trunk/src/chrome/browser/printing/printed_pages_source.h
   M /trunk/src/chrome/browser/printing/printer_query.cc
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/printing/printing_test.h
   M /trunk/src/chrome/browser/printing/units.cc
   M /trunk/src/chrome/browser/printing/units.h
   M /trunk/src/chrome/browser/printing/units_unittest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.h
   M /trunk/src/chrome/browser/printing/win_printing_context_unittest.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/profile_manager.cc
   M /trunk/src/chrome/browser/profile_manager.h
   M /trunk/src/chrome/browser/profile_manager_unittest.cc
   M /trunk/src/chrome/browser/provisional_load_details.cc
   M /trunk/src/chrome/browser/provisional_load_details.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_view_context_menu.cc
   M /trunk/src/chrome/browser/render_view_context_menu.h
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/render_view_host_manager.cc
   M /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   M /trunk/src/chrome/browser/render_widget_host_hwnd.h
   M /trunk/src/chrome/browser/render_widget_host_view.h
   M /trunk/src/chrome/browser/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_security_policy.h
   M /trunk/src/chrome/browser/renderer_security_policy_unittest.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/resource_request_details.h
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/browser/rlz/rlz.h
   M /trunk/src/chrome/browser/rlz/rlz_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   M /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   M /trunk/src/chrome/browser/safe_browsing/chunk_range.h
   M /trunk/src/chrome/browser/safe_browsing/chunk_range_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser.h
   M /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
   M /trunk/src/chrome/browser/sandbox_policy.cc
   M /trunk/src/chrome/browser/sandbox_policy.h
   M /trunk/src/chrome/browser/sanity_uitest.cc
   M /trunk/src/chrome/browser/save_file.cc
   M /trunk/src/chrome/browser/save_file.h
   M /trunk/src/chrome/browser/save_file_manager.cc
   M /trunk/src/chrome/browser/save_file_manager.h
   M /trunk/src/chrome/browser/save_item.cc
   M /trunk/src/chrome/browser/save_item.h
   M /trunk/src/chrome/browser/save_package.cc
   M /trunk/src/chrome/browser/save_package.h
   M /trunk/src/chrome/browser/save_package_unittest.cc
   M /trunk/src/chrome/browser/save_page_model.cc
   M /trunk/src/chrome/browser/save_page_model.h
   M /trunk/src/chrome/browser/save_page_uitest.cc
   M /trunk/src/chrome/browser/save_types.h
   M /trunk/src/chrome/browser/security_style.h
   M /trunk/src/chrome/browser/session_backend.cc
   M /trunk/src/chrome/browser/session_backend.h
   M /trunk/src/chrome/browser/session_backend_unittest.cc
   M /trunk/src/chrome/browser/session_crashed_view.cc
   M /trunk/src/chrome/browser/session_crashed_view.h
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/session_id.h
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_restore.h
   M /trunk/src/chrome/browser/session_restore_uitest.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/session_service_test_helper.cc
   M /trunk/src/chrome/browser/session_service_test_helper.h
   M /trunk/src/chrome/browser/session_service_unittest.cc
   M /trunk/src/chrome/browser/session_startup_pref.cc
   M /trunk/src/chrome/browser/session_startup_pref.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/browser/shell_integration.h
   M /trunk/src/chrome/browser/simple_vista_frame.cc
   M /trunk/src/chrome/browser/simple_vista_frame.h
   M /trunk/src/chrome/browser/simple_xp_frame.cc
   M /trunk/src/chrome/browser/simple_xp_frame.h
   M /trunk/src/chrome/browser/site_instance.cc
   M /trunk/src/chrome/browser/site_instance.h
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.cc
   M /trunk/src/chrome/browser/spellcheck_worditerator.h
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.h
   M /trunk/src/chrome/browser/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl_policy.h
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/standard_layout.h
   M /trunk/src/chrome/browser/status_view.cc
   M /trunk/src/chrome/browser/status_view.h
   M /trunk/src/chrome/browser/suspend_controller.cc
   M /trunk/src/chrome/browser/suspend_controller.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/tab_contents_container_view.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents_factory.h
   M /trunk/src/chrome/browser/tab_contents_type.h
   M /trunk/src/chrome/browser/tab_restore_service.cc
   M /trunk/src/chrome/browser/tab_restore_service.h
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_util.cc
   M /trunk/src/chrome/browser/tab_util.h
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_view.h
   M /trunk/src/chrome/browser/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/tabs/hwnd_photobooth.h
   M /trunk/src/chrome/browser/tabs/tab.cc
   M /trunk/src/chrome/browser/tabs/tab.h
   M /trunk/src/chrome/browser/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/browser/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.cc
   M /trunk/src/chrome/browser/task_manager_resource_providers.h
   M /trunk/src/chrome/browser/template_url.cc
   M /trunk/src/chrome/browser/template_url.h
   M /trunk/src/chrome/browser/template_url_fetcher.cc
   M /trunk/src/chrome/browser/template_url_fetcher.h
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model.h
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/template_url_parser.cc
   M /trunk/src/chrome/browser/template_url_parser.h
   M /trunk/src/chrome/browser/template_url_parser_unittest.cc
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/template_url_prepopulate_data.h
   M /trunk/src/chrome/browser/template_url_unittest.cc
   M /trunk/src/chrome/browser/title_chomper.cc
   M /trunk/src/chrome/browser/title_chomper.h
   M /trunk/src/chrome/browser/title_chomper_unittest.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/toolbar_model.h
   M /trunk/src/chrome/browser/url_fetcher.cc
   M /trunk/src/chrome/browser/url_fetcher.h
   M /trunk/src/chrome/browser/url_fetcher_protect.cc
   M /trunk/src/chrome/browser/url_fetcher_protect.h
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/chrome/browser/url_fixer_upper.h
   M /trunk/src/chrome/browser/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/user_metrics.cc
   M /trunk/src/chrome/browser/user_metrics.h
   M /trunk/src/chrome/browser/view_ids.h
   M /trunk/src/chrome/browser/view_source_contents.cc
   M /trunk/src/chrome/browser/view_source_contents.h
   M /trunk/src/chrome/browser/view_source_uitest.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_animation.cc
   M /trunk/src/chrome/browser/views/constrained_window_animation.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/delay_view.cc
   M /trunk/src/chrome/browser/views/delay_view.h
   M /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/download_item_view.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc
   M /trunk/src/chrome/browser/views/download_shelf_view.h
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/download_started_animation.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/event_utils.cc
   M /trunk/src/chrome/browser/views/event_utils.h
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/go_button.cc
   M /trunk/src/chrome/browser/views/go_button.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.h
   M /trunk/src/chrome/browser/views/hwnd_html_view.cc
   M /trunk/src/chrome/browser/views/hwnd_html_view.h
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.cc
   M /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.h
   M /trunk/src/chrome/browser/views/info_bar_confirm_view.cc
   M /trunk/src/chrome/browser/views/info_bar_confirm_view.h
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.h
   M /trunk/src/chrome/browser/views/info_bar_message_view.cc
   M /trunk/src/chrome/browser/views/info_bar_message_view.h
   M /trunk/src/chrome/browser/views/info_bar_view.cc
   M /trunk/src/chrome/browser/views/info_bar_view.h
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/input_window.h
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/location_bar_view.h
   M /trunk/src/chrome/browser/views/login_view.cc
   M /trunk/src/chrome/browser/views/login_view.h
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.h
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/languages_page_view.h
   M /trunk/src/chrome/browser/views/options/options_group_view.cc
   M /trunk/src/chrome/browser/views/options/options_group_view.h
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.h
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/sad_tab_view.cc
   M /trunk/src/chrome/browser/views/sad_tab_view.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/browser/views/shell_dialogs.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/star_toggle.h
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble.h
   M /trunk/src/chrome/browser/views/tab_icon_view.cc
   M /trunk/src/chrome/browser/views/tab_icon_view.h
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/browser/views/theme_helpers.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/browser/visitedlink_master.h
   M /trunk/src/chrome/browser/visitedlink_perftest.cc
   M /trunk/src/chrome/browser/visitedlink_unittest.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/web_app.cc
   M /trunk/src/chrome/browser/web_app.h
   M /trunk/src/chrome/browser/web_app_icon_manager.cc
   M /trunk/src/chrome/browser/web_app_icon_manager.h
   M /trunk/src/chrome/browser/web_app_launcher.cc
   M /trunk/src/chrome/browser/web_app_launcher.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/browser/web_drag_source.cc
   M /trunk/src/chrome/browser/web_drag_source.h
   M /trunk/src/chrome/browser/web_drop_target.cc
   M /trunk/src/chrome/browser/web_drop_target.h
   M /trunk/src/chrome/browser/webdata/web_data_service.cc
   M /trunk/src/chrome/browser/webdata/web_data_service.h
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   M /trunk/src/chrome/browser/window_clipping_info.cc
   M /trunk/src/chrome/browser/window_clipping_info.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/window_sizer.h
   M /trunk/src/chrome/browser/window_sizer_unittest.cc
   M /trunk/src/chrome/browser/wizard/wizard.cc
   M /trunk/src/chrome/browser/wizard/wizard.h
   M /trunk/src/chrome/browser/wizard/wizard_step.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h
   M /trunk/src/chrome/common/animation.cc
   M /trunk/src/chrome/common/animation.h
   M /trunk/src/chrome/common/animation_unittest.cc
   M /trunk/src/chrome/common/bzip2_unittest.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/common/chrome_counters.h
   M /trunk/src/chrome/common/chrome_paths.cc
   M /trunk/src/chrome/common/chrome_paths.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/chrome_plugin_unittest.cc
   M /trunk/src/chrome/common/chrome_plugin_util.cc
   M /trunk/src/chrome/common/chrome_plugin_util.h
   M /trunk/src/chrome/common/chrome_process_filter.cc
   M /trunk/src/chrome/common/chrome_process_filter.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/classfactory.cc
   M /trunk/src/chrome/common/classfactory.h
   M /trunk/src/chrome/common/clipboard_service.cc
   M /trunk/src/chrome/common/clipboard_service.h
   M /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/common/debug_flags.cc
   M /trunk/src/chrome/common/debug_flags.h
   M /trunk/src/chrome/common/drag_drop_types.cc
   M /trunk/src/chrome/common/drag_drop_types.h
   M /trunk/src/chrome/common/env_util.cc
   M /trunk/src/chrome/common/env_util.h
   M /trunk/src/chrome/common/env_vars.cc
   M /trunk/src/chrome/common/env_vars.h
   M /trunk/src/chrome/common/filter_policy.h
   M /trunk/src/chrome/common/gears_api.h
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/common/gfx/chrome_font.cc
   M /trunk/src/chrome/common/gfx/chrome_font.h
   M /trunk/src/chrome/common/gfx/color_utils.cc
   M /trunk/src/chrome/common/gfx/color_utils.h
   M /trunk/src/chrome/common/gfx/emf.cc
   M /trunk/src/chrome/common/gfx/emf.h
   M /trunk/src/chrome/common/gfx/emf_unittest.cc
   M /trunk/src/chrome/common/gfx/favicon_size.h
   M /trunk/src/chrome/common/gfx/icon_util.cc
   M /trunk/src/chrome/common/gfx/icon_util.h
   M /trunk/src/chrome/common/gfx/icon_util_unittest.cc
   M /trunk/src/chrome/common/gfx/insets.h
   M /trunk/src/chrome/common/gfx/path.cc
   M /trunk/src/chrome/common/gfx/path.h
   M /trunk/src/chrome/common/gfx/url_elider.cc
   M /trunk/src/chrome/common/gfx/url_elider.h
   M /trunk/src/chrome/common/gfx/url_elider_unittest.cc
   M /trunk/src/chrome/common/gfx/utils.h
   M /trunk/src/chrome/common/ipc_channel.cc
   M /trunk/src/chrome/common/ipc_channel.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   M /trunk/src/chrome/common/ipc_logging.cc
   M /trunk/src/chrome/common/ipc_logging.h
   M /trunk/src/chrome/common/ipc_message.cc
   M /trunk/src/chrome/common/ipc_message.h
   M /trunk/src/chrome/common/ipc_message_macros.h
   M /trunk/src/chrome/common/ipc_message_unittest.cc
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/ipc_sync_channel.cc
   M /trunk/src/chrome/common/ipc_sync_channel.h
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.h
   M /trunk/src/chrome/common/ipc_sync_message.cc
   M /trunk/src/chrome/common/ipc_sync_message.h
   M /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message_unittest.h
   M /trunk/src/chrome/common/ipc_sync_sender.cc
   M /trunk/src/chrome/common/ipc_sync_sender.h
   M /trunk/src/chrome/common/ipc_tests.cc
   M /trunk/src/chrome/common/ipc_tests.h
   M /trunk/src/chrome/common/jpeg_codec.cc
   M /trunk/src/chrome/common/jpeg_codec.h
   M /trunk/src/chrome/common/jpeg_codec_unittest.cc
   M /trunk/src/chrome/common/json_value_serializer.cc
   M /trunk/src/chrome/common/json_value_serializer.h
   M /trunk/src/chrome/common/json_value_serializer_perftest.cc
   M /trunk/src/chrome/common/json_value_serializer_unittest.cc
   M /trunk/src/chrome/common/jstemplate_builder.cc
   M /trunk/src/chrome/common/jstemplate_builder.h
   M /trunk/src/chrome/common/l10n_util.cc
   M /trunk/src/chrome/common/l10n_util.h
   M /trunk/src/chrome/common/l10n_util_unittest.cc
   M /trunk/src/chrome/common/libxml_utils.cc
   M /trunk/src/chrome/common/libxml_utils.h
   M /trunk/src/chrome/common/logging_chrome.cc
   M /trunk/src/chrome/common/logging_chrome.h
   M /trunk/src/chrome/common/logging_chrome_uitest.cc
   M /trunk/src/chrome/common/message_router.cc
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/common/mru_cache.h
   M /trunk/src/chrome/common/mru_cache_unittest.cc
   M /trunk/src/chrome/common/navigation_types.h
   M /trunk/src/chrome/common/net/cache_uitest.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.h
   M /trunk/src/chrome/common/net/dns.h
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/net/url_request_intercept_job.h
   M /trunk/src/chrome/common/net/url_util_unittest.cc
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_service.cc
   M /trunk/src/chrome/common/notification_service.h
   M /trunk/src/chrome/common/notification_service_unittest.cc
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/common/os_exchange_data.h
   M /trunk/src/chrome/common/os_exchange_data_unittest.cc
   M /trunk/src/chrome/common/page_transition_types.h
   M /trunk/src/chrome/common/plugin_messages.cc
   M /trunk/src/chrome/common/plugin_messages.h
   M /trunk/src/chrome/common/plugin_messages_internal.h
   M /trunk/src/chrome/common/pref_member.cc
   M /trunk/src/chrome/common/pref_member.h
   M /trunk/src/chrome/common/pref_member_unittest.cc
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h
   M /trunk/src/chrome/common/pref_service.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/common/pref_service_uitest.cc
   M /trunk/src/chrome/common/pref_service_unittest.cc
   M /trunk/src/chrome/common/process_watcher.cc
   M /trunk/src/chrome/common/process_watcher.h
   M /trunk/src/chrome/common/rand_util.cc
   M /trunk/src/chrome/common/rand_util.h
   M /trunk/src/chrome/common/ref_counted_util.h
   M /trunk/src/chrome/common/render_messages.cc
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/common/resource_bundle.cc
   M /trunk/src/chrome/common/resource_bundle.h
   M /trunk/src/chrome/common/resource_dispatcher.cc
   M /trunk/src/chrome/common/resource_dispatcher.h
   M /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   M /trunk/src/chrome/common/scoped_vector.h
   M /trunk/src/chrome/common/security_filter_peer.cc
   M /trunk/src/chrome/common/security_filter_peer.h
   M /trunk/src/chrome/common/slide_animation.cc
   M /trunk/src/chrome/common/slide_animation.h
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   M /trunk/src/chrome/common/sqlite_compiled_statement.h
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/common/stl_util-inl.h
   M /trunk/src/chrome/common/task_queue.cc
   M /trunk/src/chrome/common/task_queue.h
   M /trunk/src/chrome/common/text_zoom.h
   M /trunk/src/chrome/common/throb_animation.cc
   M /trunk/src/chrome/common/throb_animation.h
   M /trunk/src/chrome/common/thumbnail_score.cc
   M /trunk/src/chrome/common/thumbnail_score.h
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/common/time_format.h
   M /trunk/src/chrome/common/time_format_unittest.cc
   M /trunk/src/chrome/common/visitedlink_common.cc
   M /trunk/src/chrome/common/visitedlink_common.h
   M /trunk/src/chrome/common/win_safe_util.cc
   M /trunk/src/chrome/common/win_safe_util.h
   M /trunk/src/chrome/common/win_util.cc
   M /trunk/src/chrome/common/win_util.h
   M /trunk/src/chrome/common/win_util_unittest.cc
   M /trunk/src/chrome/common/worker_thread_ticker.cc
   M /trunk/src/chrome/common/worker_thread_ticker.h
   M /trunk/src/chrome/installer/mini_installer/mini_installer.cc
   M /trunk/src/chrome/installer/mini_installer/mini_installer.h
   M /trunk/src/chrome/installer/mini_installer/pe_resource.cc
   M /trunk/src/chrome/installer/mini_installer/pe_resource.h
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.cc
   M /trunk/src/chrome/installer/setup/setup.h
   M /trunk/src/chrome/installer/setup/setup_constants.cc
   M /trunk/src/chrome/installer/setup/setup_constants.h
   M /trunk/src/chrome/installer/setup/uninstall.cc
   M /trunk/src/chrome/installer/setup/uninstall.h
   M /trunk/src/chrome/installer/util/browser_distribution.cc
   M /trunk/src/chrome/installer/util/browser_distribution.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   M /trunk/src/chrome/installer/util/copy_tree_work_item.h
   M /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/create_dir_work_item.cc
   M /trunk/src/chrome/installer/util/create_dir_work_item.h
   M /trunk/src/chrome/installer/util/create_dir_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/create_reg_key_work_item.cc
   M /trunk/src/chrome/installer/util/create_reg_key_work_item.h
   M /trunk/src/chrome/installer/util/create_reg_key_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   M /trunk/src/chrome/installer/util/delete_tree_work_item.h
   M /trunk/src/chrome/installer/util/delete_tree_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   M /trunk/src/chrome/installer/util/google_chrome_distribution.h
   M /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc
   M /trunk/src/chrome/installer/util/google_update_constants.cc
   M /trunk/src/chrome/installer/util/google_update_constants.h
   M /trunk/src/chrome/installer/util/google_update_settings.cc
   M /trunk/src/chrome/installer/util/google_update_settings.h
   M /trunk/src/chrome/installer/util/helper.cc
   M /trunk/src/chrome/installer/util/helper.h
   M /trunk/src/chrome/installer/util/helper_unittest.cc
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/install_util.h
   M /trunk/src/chrome/installer/util/l10n_string_util.h
   M /trunk/src/chrome/installer/util/logging_installer.cc
   M /trunk/src/chrome/installer/util/logging_installer.h
   M /trunk/src/chrome/installer/util/lzma_util.cc
   M /trunk/src/chrome/installer/util/lzma_util.h
   M /trunk/src/chrome/installer/util/run_all_unittests.cc
   M /trunk/src/chrome/installer/util/set_reg_value_work_item.cc
   M /trunk/src/chrome/installer/util/set_reg_value_work_item.h
   M /trunk/src/chrome/installer/util/set_reg_value_work_item_unittest.cc
   M /trunk/src/chrome/installer/util/shell_util.cc
   M /trunk/src/chrome/installer/util/shell_util.h
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/installer/util/version.cc
   M /trunk/src/chrome/installer/util/version.h
   M /trunk/src/chrome/installer/util/work_item.cc
   M /trunk/src/chrome/installer/util/work_item.h
   M /trunk/src/chrome/installer/util/work_item_list.cc
   M /trunk/src/chrome/installer/util/work_item_list.h
   M /trunk/src/chrome/installer/util/work_item_list_unittest.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.cc
   M /trunk/src/chrome/plugin/chrome_plugin_host.h
   M /trunk/src/chrome/plugin/npobject_proxy.cc
   M /trunk/src/chrome/plugin/npobject_proxy.h
   M /trunk/src/chrome/plugin/npobject_stub.cc
   M /trunk/src/chrome/plugin/npobject_stub.h
   M /trunk/src/chrome/plugin/npobject_util.cc
   M /trunk/src/chrome/plugin/npobject_util.h
   M /trunk/src/chrome/plugin/plugin_channel.cc
   M /trunk/src/chrome/plugin/plugin_channel.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_channel_base.h
   M /trunk/src/chrome/plugin/plugin_main.cc
   M /trunk/src/chrome/plugin/plugin_process.cc
   M /trunk/src/chrome/plugin/plugin_process.h
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/plugin/plugin_thread.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   M /trunk/src/chrome/plugin/webplugin_proxy.cc
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/about_handler.cc
   M /trunk/src/chrome/renderer/about_handler.h
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.cc
   M /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   M /trunk/src/chrome/renderer/chrome_plugin_host.cc
   M /trunk/src/chrome/renderer/chrome_plugin_host.h
   M /trunk/src/chrome/renderer/debug_message_handler.cc
   M /trunk/src/chrome/renderer/debug_message_handler.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/external_js_object.cc
   M /trunk/src/chrome/renderer/external_js_object.h
   M /trunk/src/chrome/renderer/localized_error.cc
   M /trunk/src/chrome/renderer/localized_error.h
   M /trunk/src/chrome/renderer/net/render_dns_master.cc
   M /trunk/src/chrome/renderer/net/render_dns_master.h
   M /trunk/src/chrome/renderer/net/render_dns_master_unittest.cc
   M /trunk/src/chrome/renderer/net/render_dns_queue.cc
   M /trunk/src/chrome/renderer/net/render_dns_queue.h
   M /trunk/src/chrome/renderer/net/render_dns_queue_unittest.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.cc
   M /trunk/src/chrome/renderer/plugin_channel_host.h
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/chrome/renderer/spellcheck_unittest.cc
   M /trunk/src/chrome/renderer/visitedlink_slave.cc
   M /trunk/src/chrome/renderer/visitedlink_slave.h
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   M /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.h
   M /trunk/src/chrome/test/accessibility/browser_impl.cc
   M /trunk/src/chrome/test/accessibility/browser_impl.h
   M /trunk/src/chrome/test/accessibility/constants.h
   M /trunk/src/chrome/test/accessibility/keyboard_util.cc
   M /trunk/src/chrome/test/accessibility/keyboard_util.h
   M /trunk/src/chrome/test/accessibility/registry_util.cc
   M /trunk/src/chrome/test/accessibility/registry_util.h
   M /trunk/src/chrome/test/accessibility/tab_impl.cc
   M /trunk/src/chrome/test/accessibility/tab_impl.h
   M /trunk/src/chrome/test/activex_test_control/activex_test_control.cc
   M /trunk/src/chrome/test/activex_test_control/chrome_test_control.cc
   M /trunk/src/chrome/test/activex_test_control/chrome_test_control.h
   M /trunk/src/chrome/test/activex_test_control/chrome_test_control_cp.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.cc
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_constants.h
   M /trunk/src/chrome/test/automation/automation_handle_tracker.cc
   M /trunk/src/chrome/test/automation/automation_handle_tracker.h
   M /trunk/src/chrome/test/automation/automation_messages.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/test/automation/constrained_window_proxy.cc
   M /trunk/src/chrome/test/automation/constrained_window_proxy.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/automation/window_proxy.cc
   M /trunk/src/chrome/test/automation/window_proxy.h
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.cc
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.h
   M /trunk/src/chrome/test/injection_test_dll.h
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.h
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.h
   M /trunk/src/chrome/test/mini_installer_test/test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/perf/mem_usage.cc
   M /trunk/src/chrome/test/perf/mem_usage.h
   M /trunk/src/chrome/test/perf/perftests.cc
   M /trunk/src/chrome/test/perf/url_parse_perftest.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.h
   M /trunk/src/chrome/test/reliability/reliability_test_suite.h
   M /trunk/src/chrome/test/reliability/run_all_unittests.cc
   M /trunk/src/chrome/test/security_tests/ipc_security_tests.cc
   M /trunk/src/chrome/test/security_tests/ipc_security_tests.h
   M /trunk/src/chrome/test/security_tests/security_tests.cc
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/startup/feature_startup_test.cc
   M /trunk/src/chrome/test/startup/startup_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/test_file_util.cc
   M /trunk/src/chrome/test/test_file_util.h
   M /trunk/src/chrome/test/test_notification_tracker.cc
   M /trunk/src/chrome/test/test_notification_tracker.h
   M /trunk/src/chrome/test/testing_browser_process.h
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   M /trunk/src/chrome/test/ui/omnibox_uitest.cc
   M /trunk/src/chrome/test/ui/run_all_unittests.cc
   M /trunk/src/chrome/test/ui/sandbox_uitests.cc
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/test/ui/ui_test_suite.cc
   M /trunk/src/chrome/test/ui/ui_test_suite.h
   M /trunk/src/chrome/test/ui/view_event_test_base.cc
   M /trunk/src/chrome/test/ui/view_event_test_base.h
   M /trunk/src/chrome/test/unit/chrome_test_suite.h
   M /trunk/src/chrome/test/unit/run_all_unittests.cc
   M /trunk/src/chrome/tools/build/win/create_installer_archive.py
   M /trunk/src/chrome/tools/build/win/dependencies.py
   M /trunk/src/chrome/tools/build/win/html_inline.py
   M /trunk/src/chrome/tools/build/win/precompiled.h
   M /trunk/src/chrome/tools/build/win/precompiled_wtl.h
   M /trunk/src/chrome/tools/build/win/sln_deps.py
   M /trunk/src/chrome/tools/build/win/sort_sln.py
   M /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   M /trunk/src/chrome/tools/convert_dict/aff_reader.h
   M /trunk/src/chrome/tools/convert_dict/convert_dict.cc
   M /trunk/src/chrome/tools/convert_dict/dic_reader.cc
   M /trunk/src/chrome/tools/convert_dict/dic_reader.h
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.cc
   M /trunk/src/chrome/tools/convert_dict/hunspell_reader.h
   M /trunk/src/chrome/tools/crash_service/crash_service.cc
   M /trunk/src/chrome/tools/crash_service/crash_service.h
   M /trunk/src/chrome/tools/crash_service/main.cc
   M /trunk/src/chrome/tools/inconsistent-eol.py
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/chrome/tools/profiles/generate_profile.cc
   M /trunk/src/chrome/tools/test/image_diff/image_diff.cc
   M /trunk/src/chrome/tools/test/smoketests.py
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/accelerator.h
   M /trunk/src/chrome/views/accelerator_handler.cc
   M /trunk/src/chrome/views/accelerator_handler.h
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.cc
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.h
   M /trunk/src/chrome/views/accessibility/autocomplete_accessibility.cc
   M /trunk/src/chrome/views/accessibility/autocomplete_accessibility.h
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.h
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.h
   M /trunk/src/chrome/views/app_modal_dialog_delegate.h
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/background.h
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/base_button.h
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/bitmap_scroll_bar.h
   M /trunk/src/chrome/views/border.cc
   M /trunk/src/chrome/views/border.h
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button.h
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/button_dropdown.h
   M /trunk/src/chrome/views/checkbox.cc
   M /trunk/src/chrome/views/checkbox.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h
   M /trunk/src/chrome/views/combo_box.cc
   M /trunk/src/chrome/views/combo_box.h
   M /trunk/src/chrome/views/controller.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/decision.cc
   M /trunk/src/chrome/views/decision.h
   M /trunk/src/chrome/views/dialog_client_view.cc
   M /trunk/src/chrome/views/dialog_client_view.h
   M /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/dialog_delegate.h
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/external_focus_tracker.cc
   M /trunk/src/chrome/views/external_focus_tracker.h
   M /trunk/src/chrome/views/focus_manager.cc
   M /trunk/src/chrome/views/focus_manager.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/grid_layout.cc
   M /trunk/src/chrome/views/grid_layout.h
   M /trunk/src/chrome/views/grid_layout_unittest.cc
   M /trunk/src/chrome/views/group_table_view.cc
   M /trunk/src/chrome/views/group_table_view.h
   M /trunk/src/chrome/views/hwnd_notification_source.h
   M /trunk/src/chrome/views/hwnd_view.cc
   M /trunk/src/chrome/views/hwnd_view.h
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/image_view.cc
   M /trunk/src/chrome/views/image_view.h
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/label.h
   M /trunk/src/chrome/views/layout_manager.cc
   M /trunk/src/chrome/views/layout_manager.h
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/link.h
   M /trunk/src/chrome/views/menu.cc
   M /trunk/src/chrome/views/menu.h
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/menu_button.h
   M /trunk/src/chrome/views/message_box_view.cc
   M /trunk/src/chrome/views/message_box_view.h
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/native_button.h
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/native_control.h
   M /trunk/src/chrome/views/native_scroll_bar.cc
   M /trunk/src/chrome/views/native_scroll_bar.h
   M /trunk/src/chrome/views/non_client_view.cc
   M /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/painter.h
   M /trunk/src/chrome/views/radio_button.cc
   M /trunk/src/chrome/views/radio_button.h
   M /trunk/src/chrome/views/repeat_controller.cc
   M /trunk/src/chrome/views/repeat_controller.h
   M /trunk/src/chrome/views/resize_corner.cc
   M /trunk/src/chrome/views/resize_corner.h
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/root_view_drop_target.h
   M /trunk/src/chrome/views/scroll_bar.cc
   M /trunk/src/chrome/views/scroll_bar.h
   M /trunk/src/chrome/views/scroll_view.cc
   M /trunk/src/chrome/views/scroll_view.h
   M /trunk/src/chrome/views/separator.cc
   M /trunk/src/chrome/views/separator.h
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/tabbed_pane.h
   M /trunk/src/chrome/views/table_view.cc
   M /trunk/src/chrome/views/table_view.h
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_button.h
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/text_field.h
   M /trunk/src/chrome/views/throbber.cc
   M /trunk/src/chrome/views/throbber.h
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.h
   M /trunk/src/chrome/views/tree_node_model.h
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/tree_view.h
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_container.h
   M /trunk/src/chrome/views/view_menu_delegate.h
   M /trunk/src/chrome/views/view_storage.cc
   M /trunk/src/chrome/views/view_storage.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.cc
   M /trunk/src/chrome/views/window_delegate.h
   M /trunk/src/net/base/address_list.cc
   M /trunk/src/net/base/address_list.h
   M /trunk/src/net/base/auth.h
   M /trunk/src/net/base/auth_cache.cc
   M /trunk/src/net/base/auth_cache.h
   M /trunk/src/net/base/auth_cache_unittest.cc
   M /trunk/src/net/base/base64.cc
   M /trunk/src/net/base/base64.h
   M /trunk/src/net/base/base64_unittest.cc
   M /trunk/src/net/base/bzip2_filter.cc
   M /trunk/src/net/base/bzip2_filter.h
   M /trunk/src/net/base/bzip2_filter_unittest.cc
   M /trunk/src/net/base/cert_status_flags.h
   M /trunk/src/net/base/client_socket.h
   M /trunk/src/net/base/client_socket_factory.cc
   M /trunk/src/net/base/client_socket_factory.h
   M /trunk/src/net/base/client_socket_handle.cc
   M /trunk/src/net/base/client_socket_handle.h
   M /trunk/src/net/base/client_socket_pool.cc
   M /trunk/src/net/base/client_socket_pool.h
   M /trunk/src/net/base/client_socket_pool_unittest.cc
   M /trunk/src/net/base/completion_callback.h
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/cookie_policy.cc
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/cookie_policy_unittest.cc
   M /trunk/src/net/base/data_url.cc
   M /trunk/src/net/base/data_url.h
   M /trunk/src/net/base/data_url_unittest.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/directory_lister_unittest.cc
   M /trunk/src/net/base/dns_resolution_observer.cc
   M /trunk/src/net/base/dns_resolution_observer.h
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/ev_root_ca_metadata.cc
   M /trunk/src/net/base/ev_root_ca_metadata.h
   M /trunk/src/net/base/filter.cc
   M /trunk/src/net/base/filter.h
   M /trunk/src/net/base/gzip_filter.cc
   M /trunk/src/net/base/gzip_filter.h
   M /trunk/src/net/base/gzip_filter_unittest.cc
   M /trunk/src/net/base/gzip_header.cc
   M /trunk/src/net/base/gzip_header.h
   M /trunk/src/net/base/host_resolver.cc
   M /trunk/src/net/base/host_resolver.h
   M /trunk/src/net/base/listen_socket.cc
   M /trunk/src/net/base/listen_socket.h
   M /trunk/src/net/base/listen_socket_unittest.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/load_flags.h
   M /trunk/src/net/base/load_states.h
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/mime_sniffer.h
   M /trunk/src/net/base/mime_sniffer_unittest.cc
   M /trunk/src/net/base/mime_util.cc
   M /trunk/src/net/base/mime_util.h
   M /trunk/src/net/base/mime_util_unittest.cc
   M /trunk/src/net/base/net_error_list.h
   M /trunk/src/net/base/net_errors.cc
   M /trunk/src/net/base/net_errors.h
   M /trunk/src/net/base/net_module.cc
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_posix.cc
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/base/net_util_win.cc
   M /trunk/src/net/base/platform_mime_util.h
   M /trunk/src/net/base/platform_mime_util_win.cc
   M /trunk/src/net/base/registry_controlled_domain_unittest.cc
   M /trunk/src/net/base/socket.h
   M /trunk/src/net/base/ssl_client_socket.cc
   M /trunk/src/net/base/ssl_client_socket.h
   M /trunk/src/net/base/ssl_client_socket_unittest.cc
   M /trunk/src/net/base/ssl_config_service.cc
   M /trunk/src/net/base/ssl_config_service.h
   M /trunk/src/net/base/ssl_config_service_unittest.cc
   M /trunk/src/net/base/ssl_info.h
   M /trunk/src/net/base/tcp_client_socket.cc
   M /trunk/src/net/base/tcp_client_socket.h
   M /trunk/src/net/base/tcp_client_socket_unittest.cc
   M /trunk/src/net/base/telnet_server.cc
   M /trunk/src/net/base/telnet_server.h
   M /trunk/src/net/base/telnet_server_unittest.cc
   M /trunk/src/net/base/test_completion_callback.h
   M /trunk/src/net/base/upload_data.cc
   M /trunk/src/net/base/upload_data.h
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/base/upload_data_stream.h
   M /trunk/src/net/base/wininet_util.cc
   M /trunk/src/net/base/wininet_util.h
   M /trunk/src/net/base/wininet_util_unittest.cc
   M /trunk/src/net/base/winsock_init.cc
   M /trunk/src/net/base/winsock_init.h
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/build/precompiled_net.cc
   M /trunk/src/net/build/precompiled_net.h
   M /trunk/src/net/disk_cache/addr.h
   M /trunk/src/net/disk_cache/addr_unittest.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/backend_impl.h
   M /trunk/src/net/disk_cache/backend_unittest.cc
   M /trunk/src/net/disk_cache/block_files.cc
   M /trunk/src/net/disk_cache/block_files.h
   M /trunk/src/net/disk_cache/block_files_unittest.cc
   M /trunk/src/net/disk_cache/cache_util.h
   M /trunk/src/net/disk_cache/cache_util_posix.cc
   M /trunk/src/net/disk_cache/cache_util_win.cc
   M /trunk/src/net/disk_cache/disk_cache.h
   M /trunk/src/net/disk_cache/disk_cache_perftest.cc
   M /trunk/src/net/disk_cache/disk_cache_test_base.cc
   M /trunk/src/net/disk_cache/disk_cache_test_base.h
   M /trunk/src/net/disk_cache/disk_cache_test_util.cc
   M /trunk/src/net/disk_cache/disk_cache_test_util.h
   M /trunk/src/net/disk_cache/disk_format.h
   M /trunk/src/net/disk_cache/entry_impl.cc
   M /trunk/src/net/disk_cache/entry_impl.h
   M /trunk/src/net/disk_cache/entry_unittest.cc
   M /trunk/src/net/disk_cache/errors.h
   M /trunk/src/net/disk_cache/file.h
   M /trunk/src/net/disk_cache/file_block.h
   M /trunk/src/net/disk_cache/file_lock.cc
   M /trunk/src/net/disk_cache/file_lock.h
   M /trunk/src/net/disk_cache/file_posix.cc
   M /trunk/src/net/disk_cache/file_win.cc
   M /trunk/src/net/disk_cache/hash.h
   M /trunk/src/net/disk_cache/mapped_file.h
   M /trunk/src/net/disk_cache/mapped_file_posix.cc
   M /trunk/src/net/disk_cache/mapped_file_unittest.cc
   M /trunk/src/net/disk_cache/mapped_file_win.cc
   M /trunk/src/net/disk_cache/mem_backend_impl.cc
   M /trunk/src/net/disk_cache/mem_backend_impl.h
   M /trunk/src/net/disk_cache/mem_entry_impl.cc
   M /trunk/src/net/disk_cache/mem_entry_impl.h
   M /trunk/src/net/disk_cache/mem_rankings.cc
   M /trunk/src/net/disk_cache/mem_rankings.h
   M /trunk/src/net/disk_cache/os_file.h
   M /trunk/src/net/disk_cache/os_file_posix.cc
   M /trunk/src/net/disk_cache/os_file_win.cc
   M /trunk/src/net/disk_cache/rankings.cc
   M /trunk/src/net/disk_cache/rankings.h
   M /trunk/src/net/disk_cache/stats.cc
   M /trunk/src/net/disk_cache/stats.h
   M /trunk/src/net/disk_cache/storage_block-inl.h
   M /trunk/src/net/disk_cache/storage_block.h
   M /trunk/src/net/disk_cache/storage_block_unittest.cc
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/disk_cache/trace.cc
   M /trunk/src/net/disk_cache/trace.h
   M /trunk/src/net/http/cert_status_cache.cc
   M /trunk/src/net/http/cert_status_cache.h
   M /trunk/src/net/http/http_atom_list.h
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_chunked_decoder_unittest.cc
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_layer_unittest.cc
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_request_info.h
   M /trunk/src/net/http/http_response_headers.cc
   M /trunk/src/net/http/http_response_headers.h
   M /trunk/src/net/http/http_response_headers_unittest.cc
   M /trunk/src/net/http/http_response_info.h
   M /trunk/src/net/http/http_transaction.h
   M /trunk/src/net/http/http_transaction_factory.h
   M /trunk/src/net/http/http_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/http/http_transaction_winhttp.h
   M /trunk/src/net/http/http_transaction_winhttp_unittest.cc
   M /trunk/src/net/http/http_util.cc
   M /trunk/src/net/http/http_util.h
   M /trunk/src/net/http/http_util_unittest.cc
   M /trunk/src/net/http/http_vary_data.cc
   M /trunk/src/net/http/http_vary_data.h
   M /trunk/src/net/http/http_vary_data_unittest.cc
   M /trunk/src/net/http/winhttp_request_throttle.cc
   M /trunk/src/net/http/winhttp_request_throttle.h
   M /trunk/src/net/http/winhttp_request_throttle_unittest.cc
   M /trunk/src/net/proxy/proxy_resolver_fixed.cc
   M /trunk/src/net/proxy/proxy_resolver_fixed.h
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/net/tools/testserver/testserver.py
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.h
   M /trunk/src/net/url_request/url_request.cc
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_about_job.cc
   M /trunk/src/net/url_request/url_request_about_job.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_error_job.cc
   M /trunk/src/net/url_request/url_request_error_job.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_file_job.h
   M /trunk/src/net/url_request/url_request_filter.cc
   M /trunk/src/net/url_request/url_request_filter.h
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_ftp_job.h
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_http_job.h
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_job_manager.cc
   M /trunk/src/net/url_request/url_request_job_manager.h
   M /trunk/src/net/url_request/url_request_job_metrics.cc
   M /trunk/src/net/url_request/url_request_job_metrics.h
   M /trunk/src/net/url_request/url_request_job_tracker.cc
   M /trunk/src/net/url_request/url_request_job_tracker.h
   M /trunk/src/net/url_request/url_request_simple_job.cc
   M /trunk/src/net/url_request/url_request_simple_job.h
   M /trunk/src/net/url_request/url_request_status.h
   M /trunk/src/net/url_request/url_request_test_job.cc
   M /trunk/src/net/url_request/url_request_test_job.h
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/net/url_request/url_request_view_cache_job.cc
   M /trunk/src/net/url_request/url_request_view_cache_job.h
   M /trunk/src/sandbox/sandbox_poc/main_ui_window.cc
   M /trunk/src/sandbox/sandbox_poc/main_ui_window.h
   M /trunk/src/sandbox/sandbox_poc/pocdll/exports.h
   M /trunk/src/sandbox/sandbox_poc/pocdll/fs.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/handles.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/invasive.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/network.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/pocdll.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/processes_and_threads.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/registry.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/spyware.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/stdafx.cc
   M /trunk/src/sandbox/sandbox_poc/pocdll/stdafx.h
   M /trunk/src/sandbox/sandbox_poc/pocdll/utils.h
   M /trunk/src/sandbox/sandbox_poc/sandbox.cc
   M /trunk/src/sandbox/sandbox_poc/sandbox.h
   M /trunk/src/sandbox/sandbox_poc/stdafx.cc
   M /trunk/src/sandbox/sandbox_poc/stdafx.h
   M /trunk/src/sandbox/src/Wow64.cc
   M /trunk/src/sandbox/src/Wow64.h
   M /trunk/src/sandbox/src/acl.cc
   M /trunk/src/sandbox/src/acl.h
   M /trunk/src/sandbox/src/broker_services.cc
   M /trunk/src/sandbox/src/broker_services.h
   M /trunk/src/sandbox/src/crosscall_client.h
   M /trunk/src/sandbox/src/crosscall_params.h
   M /trunk/src/sandbox/src/crosscall_server.cc
   M /trunk/src/sandbox/src/crosscall_server.h
   M /trunk/src/sandbox/src/dep.cc
   M /trunk/src/sandbox/src/dep.h
   M /trunk/src/sandbox/src/dep_test.cc
   M /trunk/src/sandbox/src/eat_resolver.cc
   M /trunk/src/sandbox/src/eat_resolver.h
   M /trunk/src/sandbox/src/file_policy_test.cc
   M /trunk/src/sandbox/src/filesystem_dispatcher.cc
   M /trunk/src/sandbox/src/filesystem_dispatcher.h
   M /trunk/src/sandbox/src/filesystem_interception.cc
   M /trunk/src/sandbox/src/filesystem_interception.h
   M /trunk/src/sandbox/src/filesystem_policy.cc
   M /trunk/src/sandbox/src/filesystem_policy.h
   M /trunk/src/sandbox/src/integrity_level_test.cc
   M /trunk/src/sandbox/src/interception.cc
   M /trunk/src/sandbox/src/interception.h
   M /trunk/src/sandbox/src/interception_agent.cc
   M /trunk/src/sandbox/src/interception_agent.h
   M /trunk/src/sandbox/src/interception_internal.h
   M /trunk/src/sandbox/src/interception_unittest.cc
   M /trunk/src/sandbox/src/internal_types.h
   M /trunk/src/sandbox/src/ipc_ping_test.cc
   M /trunk/src/sandbox/src/ipc_tags.h
   M /trunk/src/sandbox/src/ipc_unittest.cc
   M /trunk/src/sandbox/src/job.cc
   M /trunk/src/sandbox/src/job.h
   M /trunk/src/sandbox/src/job_unittest.cc
   M /trunk/src/sandbox/src/named_pipe_dispatcher.cc
   M /trunk/src/sandbox/src/named_pipe_dispatcher.h
   M /trunk/src/sandbox/src/named_pipe_interception.cc
   M /trunk/src/sandbox/src/named_pipe_interception.h
   M /trunk/src/sandbox/src/named_pipe_policy.cc
   M /trunk/src/sandbox/src/named_pipe_policy.h
   M /trunk/src/sandbox/src/named_pipe_policy_test.cc
   M /trunk/src/sandbox/src/nt_internals.h
   M /trunk/src/sandbox/src/pe_image.cc
   M /trunk/src/sandbox/src/pe_image.h
   M /trunk/src/sandbox/src/pe_image_unittest.cc
   M /trunk/src/sandbox/src/policy_broker.cc
   M /trunk/src/sandbox/src/policy_broker.h
   M /trunk/src/sandbox/src/policy_engine_opcodes.cc
   M /trunk/src/sandbox/src/policy_engine_opcodes.h
   M /trunk/src/sandbox/src/policy_engine_params.h
   M /trunk/src/sandbox/src/policy_engine_processor.cc
   M /trunk/src/sandbox/src/policy_engine_processor.h
   M /trunk/src/sandbox/src/policy_engine_unittest.cc
   M /trunk/src/sandbox/src/policy_low_level.cc
   M /trunk/src/sandbox/src/policy_low_level.h
   M /trunk/src/sandbox/src/policy_low_level_unittest.cc
   M /trunk/src/sandbox/src/policy_opcodes_unittest.cc
   M /trunk/src/sandbox/src/policy_params.h
   M /trunk/src/sandbox/src/policy_target.cc
   M /trunk/src/sandbox/src/policy_target.h
   M /trunk/src/sandbox/src/policy_target_test.cc
   M /trunk/src/sandbox/src/process_policy_test.cc
   M /trunk/src/sandbox/src/process_thread_dispatcher.cc
   M /trunk/src/sandbox/src/process_thread_dispatcher.h
   M /trunk/src/sandbox/src/process_thread_interception.cc
   M /trunk/src/sandbox/src/process_thread_interception.h
   M /trunk/src/sandbox/src/process_thread_policy.cc
   M /trunk/src/sandbox/src/process_thread_policy.h
   M /trunk/src/sandbox/src/registry_dispatcher.cc
   M /trunk/src/sandbox/src/registry_dispatcher.h
   M /trunk/src/sandbox/src/registry_interception.cc
   M /trunk/src/sandbox/src/registry_interception.h
   M /trunk/src/sandbox/src/registry_policy.cc
   M /trunk/src/sandbox/src/registry_policy.h
   M /trunk/src/sandbox/src/registry_policy_test.cc
   M /trunk/src/sandbox/src/resolver.cc
   M /trunk/src/sandbox/src/resolver.h
   M /trunk/src/sandbox/src/restricted_token.cc
   M /trunk/src/sandbox/src/restricted_token.h
   M /trunk/src/sandbox/src/restricted_token_unittest.cc
   M /trunk/src/sandbox/src/restricted_token_utils.cc
   M /trunk/src/sandbox/src/restricted_token_utils.h
   M /trunk/src/sandbox/src/sandbox.cc
   M /trunk/src/sandbox/src/sandbox.h
   M /trunk/src/sandbox/src/sandbox_factory.h
   M /trunk/src/sandbox/src/sandbox_nt_types.h
   M /trunk/src/sandbox/src/sandbox_nt_util.cc
   M /trunk/src/sandbox/src/sandbox_nt_util.h
   M /trunk/src/sandbox/src/sandbox_policy.h
   M /trunk/src/sandbox/src/sandbox_policy_base.cc
   M /trunk/src/sandbox/src/sandbox_policy_base.h
   M /trunk/src/sandbox/src/sandbox_types.h
   M /trunk/src/sandbox/src/sandbox_utils.cc
   M /trunk/src/sandbox/src/sandbox_utils.h
   M /trunk/src/sandbox/src/security_level.h
   M /trunk/src/sandbox/src/service_resolver.cc
   M /trunk/src/sandbox/src/service_resolver.h
   M /trunk/src/sandbox/src/service_resolver_unittest.cc
   M /trunk/src/sandbox/src/shared_handles.cc
   M /trunk/src/sandbox/src/shared_handles.h
   M /trunk/src/sandbox/src/sharedmem_ipc_client.cc
   M /trunk/src/sandbox/src/sharedmem_ipc_client.h
   M /trunk/src/sandbox/src/sharedmem_ipc_server.cc
   M /trunk/src/sandbox/src/sharedmem_ipc_server.h
   M /trunk/src/sandbox/src/sid.cc
   M /trunk/src/sandbox/src/sid.h
   M /trunk/src/sandbox/src/sid_unittest.cc
   M /trunk/src/sandbox/src/sidestep/mini_disassembler.h
   M /trunk/src/sandbox/src/sidestep/mini_disassembler_types.h
   M /trunk/src/sandbox/src/sidestep/preamble_patcher.h
   M /trunk/src/sandbox/src/sidestep_resolver.cc
   M /trunk/src/sandbox/src/sidestep_resolver.h
   M /trunk/src/sandbox/src/stdafx.cc
   M /trunk/src/sandbox/src/stdafx.h
   M /trunk/src/sandbox/src/sync_dispatcher.cc
   M /trunk/src/sandbox/src/sync_dispatcher.h
   M /trunk/src/sandbox/src/sync_interception.cc
   M /trunk/src/sandbox/src/sync_interception.h
   M /trunk/src/sandbox/src/sync_policy.cc
   M /trunk/src/sandbox/src/sync_policy.h
   M /trunk/src/sandbox/src/sync_policy_test.cc
   M /trunk/src/sandbox/src/target_interceptions.cc
   M /trunk/src/sandbox/src/target_interceptions.h
   M /trunk/src/sandbox/src/target_process.cc
   M /trunk/src/sandbox/src/target_process.h
   M /trunk/src/sandbox/src/target_services.cc
   M /trunk/src/sandbox/src/target_services.h
   M /trunk/src/sandbox/src/threadpool_unittest.cc
   M /trunk/src/sandbox/src/win2k_threadpool.cc
   M /trunk/src/sandbox/src/win2k_threadpool.h
   M /trunk/src/sandbox/src/win_utils.cc
   M /trunk/src/sandbox/src/win_utils.h
   M /trunk/src/sandbox/tests/common/controller.cc
   M /trunk/src/sandbox/tests/common/controller.h
   M /trunk/src/sandbox/tests/integration_tests/integration_tests.cc
   M /trunk/src/sandbox/tests/integration_tests/integration_tests_test.cc
   M /trunk/src/sandbox/tests/integration_tests/stdafx.cc
   M /trunk/src/sandbox/tests/integration_tests/stdafx.h
   M /trunk/src/sandbox/tests/unit_tests/stdafx.cc
   M /trunk/src/sandbox/tests/unit_tests/stdafx.h
   M /trunk/src/sandbox/tests/unit_tests/unit_tests.cc
   M /trunk/src/sandbox/tests/validation_tests/commands.cc
   M /trunk/src/sandbox/tests/validation_tests/commands.h
   M /trunk/src/sandbox/tests/validation_tests/stdafx.cc
   M /trunk/src/sandbox/tests/validation_tests/stdafx.h
   M /trunk/src/sandbox/tests/validation_tests/suite.cc
   M /trunk/src/sandbox/tests/validation_tests/unit_tests.cc
   M /trunk/src/sandbox/tools/finder/finder.cc
   M /trunk/src/sandbox/tools/finder/finder.h
   M /trunk/src/sandbox/tools/finder/finder_fs.cc
   M /trunk/src/sandbox/tools/finder/finder_kernel.cc
   M /trunk/src/sandbox/tools/finder/finder_registry.cc
   M /trunk/src/sandbox/tools/finder/main.cc
   M /trunk/src/sandbox/tools/finder/ntundoc.h
   M /trunk/src/sandbox/tools/finder/stdafx.cc
   M /trunk/src/sandbox/tools/finder/stdafx.h
   M /trunk/src/sandbox/tools/launcher/launcher.cc
   M /trunk/src/sandbox/tools/launcher/stdafx.cc
   M /trunk/src/sandbox/tools/launcher/stdafx.h
   M /trunk/src/sandbox/wow_helper/service64_resolver.cc
   M /trunk/src/sandbox/wow_helper/service64_resolver.h
   M /trunk/src/sandbox/wow_helper/target_code.cc
   M /trunk/src/sandbox/wow_helper/target_code.h
   M /trunk/src/sandbox/wow_helper/wow_helper.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gflags.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gflags_reporting.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/google/gflags.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest-death-test.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest-death-test.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest-filepath.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest-message.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest-port.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest-spi.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest_main.cc
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest_pred_impl.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/gtest_prod.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/internal/gtest-death-test-internal.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/internal/gtest-filepath.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/internal/gtest-internal.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/internal/gtest-port.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/internal/gtest-string.h
   M /trunk/src/sdch/open_vcdiff/depot/opensource/open-vcdiff/src/gtest/src/gtest-internal-inl.h
   M /trunk/src/skia/precompiled.cc
   M /trunk/src/tools/channel_changer/channel_changer.cc
   M /trunk/src/tools/checkdeps/checkdeps.py
   M /trunk/src/tools/code_coverage/coverage.py
   M /trunk/src/tools/grit/grit/__init__.py
   M /trunk/src/tools/grit/grit/clique.py
   M /trunk/src/tools/grit/grit/clique_unittest.py
   M /trunk/src/tools/grit/grit/constants.py
   M /trunk/src/tools/grit/grit/exception.py
   M /trunk/src/tools/grit/grit/extern/FP.py
   M /trunk/src/tools/grit/grit/extern/tclib.py
   M /trunk/src/tools/grit/grit/format/__init__.py
   M /trunk/src/tools/grit/grit/format/interface.py
   M /trunk/src/tools/grit/grit/format/rc.py
   M /trunk/src/tools/grit/grit/format/rc_header.py
   M /trunk/src/tools/grit/grit/format/rc_header_unittest.py
   M /trunk/src/tools/grit/grit/format/rc_unittest.py
   M /trunk/src/tools/grit/grit/gather/__init__.py
   M /trunk/src/tools/grit/grit/gather/admin_template.py
   M /trunk/src/tools/grit/grit/gather/admin_template_unittest.py
   M /trunk/src/tools/grit/grit/gather/interface.py
   M /trunk/src/tools/grit/grit/gather/muppet_strings.py
   M /trunk/src/tools/grit/grit/gather/muppet_strings_unittest.py
   M /trunk/src/tools/grit/grit/gather/rc.py
   M /trunk/src/tools/grit/grit/gather/rc_unittest.py
   M /trunk/src/tools/grit/grit/gather/regexp.py
   M /trunk/src/tools/grit/grit/gather/tr_html.py
   M /trunk/src/tools/grit/grit/gather/tr_html_unittest.py
   M /trunk/src/tools/grit/grit/gather/txt.py
   M /trunk/src/tools/grit/grit/gather/txt_unittest.py
   M /trunk/src/tools/grit/grit/grd_reader.py
   M /trunk/src/tools/grit/grit/grd_reader_unittest.py
   M /trunk/src/tools/grit/grit/grit_runner.py
   M /trunk/src/tools/grit/grit/grit_runner_unittest.py
   M /trunk/src/tools/grit/grit/node/__init__.py
   M /trunk/src/tools/grit/grit/node/base.py
   M /trunk/src/tools/grit/grit/node/base_unittest.py
   M /trunk/src/tools/grit/grit/node/custom/filename.py
   M /trunk/src/tools/grit/grit/node/custom/filename_unittest.py
   M /trunk/src/tools/grit/grit/node/empty.py
   M /trunk/src/tools/grit/grit/node/include.py
   M /trunk/src/tools/grit/grit/node/io.py
   M /trunk/src/tools/grit/grit/node/io_unittest.py
   M /trunk/src/tools/grit/grit/node/mapping.py
   M /trunk/src/tools/grit/grit/node/message.py
   M /trunk/src/tools/grit/grit/node/message_unittest.py
   M /trunk/src/tools/grit/grit/node/misc.py
   M /trunk/src/tools/grit/grit/node/misc_unittest.py
   M /trunk/src/tools/grit/grit/node/structure.py
   M /trunk/src/tools/grit/grit/node/structure_unittest.py
   M /trunk/src/tools/grit/grit/node/variant.py
   M /trunk/src/tools/grit/grit/pseudo.py
   M /trunk/src/tools/grit/grit/pseudo_unittest.py
   M /trunk/src/tools/grit/grit/scons.py
   M /trunk/src/tools/grit/grit/shortcuts.py
   M /trunk/src/tools/grit/grit/shortcuts_unittests.py
   M /trunk/src/tools/grit/grit/tclib.py
   M /trunk/src/tools/grit/grit/tclib_unittest.py
   M /trunk/src/tools/grit/grit/test_suite_all.py
   M /trunk/src/tools/grit/grit/tool/__init__.py
   M /trunk/src/tools/grit/grit/tool/build.py
   M /trunk/src/tools/grit/grit/tool/count.py
   M /trunk/src/tools/grit/grit/tool/diff_structures.py
   M /trunk/src/tools/grit/grit/tool/interface.py
   M /trunk/src/tools/grit/grit/tool/menu_from_parts.py
   M /trunk/src/tools/grit/grit/tool/newgrd.py
   M /trunk/src/tools/grit/grit/tool/postprocess_interface.py
   M /trunk/src/tools/grit/grit/tool/postprocess_unittest.py
   M /trunk/src/tools/grit/grit/tool/preprocess_interface.py
   M /trunk/src/tools/grit/grit/tool/preprocess_unittest.py
   M /trunk/src/tools/grit/grit/tool/rc2grd.py
   M /trunk/src/tools/grit/grit/tool/rc2grd_unittest.py
   M /trunk/src/tools/grit/grit/tool/resize.py
   M /trunk/src/tools/grit/grit/tool/test.py
   M /trunk/src/tools/grit/grit/tool/toolbar_postprocess.py
   M /trunk/src/tools/grit/grit/tool/toolbar_preprocess.py
   M /trunk/src/tools/grit/grit/tool/transl2tc.py
   M /trunk/src/tools/grit/grit/tool/transl2tc_unittest.py
   M /trunk/src/tools/grit/grit/tool/unit.py
   M /trunk/src/tools/grit/grit/util.py
   M /trunk/src/tools/grit/grit/util_unittest.py
   M /trunk/src/tools/grit/grit/xtb_reader.py
   M /trunk/src/tools/grit/grit/xtb_reader_unittest.py
   M /trunk/src/tools/grit/grit.py
   M /trunk/src/tools/measure_page_load_time/ie_bho/MeasurePageLoadTimeBHO.h
   M /trunk/src/tools/memory_watcher/call_stack.cc
   M /trunk/src/tools/memory_watcher/call_stack.h
   M /trunk/src/tools/memory_watcher/dllmain.cc
   M /trunk/src/tools/memory_watcher/hotkey.h
   M /trunk/src/tools/memory_watcher/memory_hook.cc
   M /trunk/src/tools/memory_watcher/memory_hook.h
   M /trunk/src/tools/memory_watcher/memory_watcher.cc
   M /trunk/src/tools/memory_watcher/memory_watcher.h
   M /trunk/src/tools/purify/chrome_tests.py
   M /trunk/src/tools/purify/common.py
   M /trunk/src/tools/purify/purify_analyze.py
   M /trunk/src/tools/purify/purify_coverage.py
   M /trunk/src/tools/purify/purify_inuse.py
   M /trunk/src/tools/purify/purify_message.py
   M /trunk/src/tools/purify/purify_test.py
   M /trunk/src/tools/purify/quantify_test.py
   M /trunk/src/tools/python/google/gethash_timer.py
   M /trunk/src/tools/python/google/httpd_utils.py
   M /trunk/src/tools/python/google/logging_utils.py
   M /trunk/src/tools/python/google/path_utils.py
   M /trunk/src/tools/python/google/platform_utils.py
   M /trunk/src/tools/python/google/platform_utils_win.py
   M /trunk/src/tools/python/google/process_utils.py
   M /trunk/src/tools/site_compare/command_line.py
   M /trunk/src/tools/site_compare/commands/compare2.py
   M /trunk/src/tools/site_compare/commands/maskmaker.py
   M /trunk/src/tools/site_compare/commands/measure.py
   M /trunk/src/tools/site_compare/commands/scrape.py
   M /trunk/src/tools/site_compare/commands/timeload.py
   M /trunk/src/tools/site_compare/drivers/win32/keyboard.py
   M /trunk/src/tools/site_compare/drivers/win32/mouse.py
   M /trunk/src/tools/site_compare/drivers/win32/windowing.py
   M /trunk/src/tools/site_compare/operators/equals.py
   M /trunk/src/tools/site_compare/operators/equals_with_mask.py
   M /trunk/src/tools/site_compare/scrapers/chrome/chrome011010.py
   M /trunk/src/tools/site_compare/scrapers/chrome/chrome01970.py
   M /trunk/src/tools/site_compare/scrapers/chrome/chromebase.py
   M /trunk/src/tools/site_compare/scrapers/firefox/firefox2.py
   M /trunk/src/tools/site_compare/scrapers/ie/ie7.py
   M /trunk/src/tools/site_compare/site_compare.py
   M /trunk/src/tools/site_compare/utils/browser_iterate.py
   M /trunk/src/webkit/activex_shim/activex_plugin.cc
   M /trunk/src/webkit/activex_shim/activex_plugin.h
   M /trunk/src/webkit/activex_shim/activex_shared.cc
   M /trunk/src/webkit/activex_shim/activex_shared.h
   M /trunk/src/webkit/activex_shim/activex_util.cc
   M /trunk/src/webkit/activex_shim/activex_util.h
   M /trunk/src/webkit/activex_shim/dispatch_object.cc
   M /trunk/src/webkit/activex_shim/dispatch_object.h
   M /trunk/src/webkit/activex_shim/ihtmldocument_impl.h
   M /trunk/src/webkit/activex_shim/iwebbrowser_impl.h
   M /trunk/src/webkit/activex_shim/npn_scripting.cc
   M /trunk/src/webkit/activex_shim/npn_scripting.h
   M /trunk/src/webkit/activex_shim/npp_impl.cc
   M /trunk/src/webkit/activex_shim/npp_impl.h
   M /trunk/src/webkit/activex_shim/web_activex_container.cc
   M /trunk/src/webkit/activex_shim/web_activex_container.h
   M /trunk/src/webkit/activex_shim/web_activex_site.cc
   M /trunk/src/webkit/activex_shim/web_activex_site.h
   M /trunk/src/webkit/activex_shim_dll/activex_shim_dll.cc
   M /trunk/src/webkit/build/JavaScriptCore/pthread.h
   M /trunk/src/webkit/build/JavaScriptCore/sched.h
   M /trunk/src/webkit/build/V8Bindings/precompiled_v8bindings.h
   M /trunk/src/webkit/build/webkit_version.py
   M /trunk/src/webkit/default_plugin/activex_installer.cc
   M /trunk/src/webkit/default_plugin/activex_installer.h
   M /trunk/src/webkit/default_plugin/default_plugin.cc
   M /trunk/src/webkit/default_plugin/default_plugin_shared.h
   M /trunk/src/webkit/default_plugin/install_dialog.cc
   M /trunk/src/webkit/default_plugin/install_dialog.h
   M /trunk/src/webkit/default_plugin/plugin_database_handler.cc
   M /trunk/src/webkit/default_plugin/plugin_database_handler.h
   M /trunk/src/webkit/default_plugin/plugin_impl.cc
   M /trunk/src/webkit/default_plugin/plugin_impl.h
   M /trunk/src/webkit/default_plugin/plugin_install_job_monitor.cc
   M /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h
   M /trunk/src/webkit/default_plugin/plugin_main.cc
   M /trunk/src/webkit/default_plugin/plugin_main.h
   M /trunk/src/webkit/glue/alt_404_page_resource_fetcher.cc
   M /trunk/src/webkit/glue/alt_404_page_resource_fetcher.h
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.cc
   M /trunk/src/webkit/glue/alt_error_page_resource_fetcher.h
   M /trunk/src/webkit/glue/autocomplete_input_listener.cc
   M /trunk/src/webkit/glue/autocomplete_input_listener.h
   M /trunk/src/webkit/glue/autocomplete_input_listener_unittest.cc
   M /trunk/src/webkit/glue/bookmarklet_unittest.cc
   M /trunk/src/webkit/glue/cache_manager.cc
   M /trunk/src/webkit/glue/cache_manager.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/chrome_client_impl.h
   M /trunk/src/webkit/glue/console_message_level.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/context_menu_client_impl.h
   M /trunk/src/webkit/glue/context_menu_unittest.cc
   M /trunk/src/webkit/glue/context_node_types.h
   M /trunk/src/webkit/glue/cpp_binding_example.cc
   M /trunk/src/webkit/glue/cpp_binding_example.h
   M /trunk/src/webkit/glue/cpp_bound_class.cc
   M /trunk/src/webkit/glue/cpp_bound_class.h
   M /trunk/src/webkit/glue/cpp_bound_class_unittest.cc
   M /trunk/src/webkit/glue/cpp_variant.cc
   M /trunk/src/webkit/glue/cpp_variant.h
   M /trunk/src/webkit/glue/cpp_variant_unittest.cc
   M /trunk/src/webkit/glue/debugger.cc
   M /trunk/src/webkit/glue/debugger.h
   M /trunk/src/webkit/glue/dom_operations.cc
   M /trunk/src/webkit/glue/dom_operations.h
   M /trunk/src/webkit/glue/dom_operations_unittest.cc
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/dom_serializer.h
   M /trunk/src/webkit/glue/dom_serializer_delegate.h
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/dragclient_impl.cc
   M /trunk/src/webkit/glue/dragclient_impl.h
   M /trunk/src/webkit/glue/editor_client_impl.cc
   M /trunk/src/webkit/glue/editor_client_impl.h
   M /trunk/src/webkit/glue/entity_map.cc
   M /trunk/src/webkit/glue/entity_map.h
   M /trunk/src/webkit/glue/event_conversion.cc
   M /trunk/src/webkit/glue/event_conversion.h
   M /trunk/src/webkit/glue/feed_preview.cc
   M /trunk/src/webkit/glue/feed_preview.h
   M /trunk/src/webkit/glue/find_in_page_request.h
   M /trunk/src/webkit/glue/form_data.h
   M /trunk/src/webkit/glue/glue_serialize.cc
   M /trunk/src/webkit/glue/glue_serialize.h
   M /trunk/src/webkit/glue/glue_serialize_unittest.cc
   M /trunk/src/webkit/glue/glue_util.cc
   M /trunk/src/webkit/glue/glue_util.h
   M /trunk/src/webkit/glue/iframe_redirect_unittest.cc
   M /trunk/src/webkit/glue/image_decoder.cc
   M /trunk/src/webkit/glue/image_decoder.h
   M /trunk/src/webkit/glue/image_resource_fetcher.cc
   M /trunk/src/webkit/glue/image_resource_fetcher.h
   M /trunk/src/webkit/glue/inspector_client_impl.cc
   M /trunk/src/webkit/glue/inspector_client_impl.h
   M /trunk/src/webkit/glue/mimetype_unittest.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.h
   M /trunk/src/webkit/glue/multipart_response_delegate_unittest.cc
   M /trunk/src/webkit/glue/npruntime_util.cc
   M /trunk/src/webkit/glue/npruntime_util.h
   M /trunk/src/webkit/glue/password_autocomplete_listener.cc
   M /trunk/src/webkit/glue/password_autocomplete_listener.h
   M /trunk/src/webkit/glue/password_autocomplete_listener_unittest.cc
   M /trunk/src/webkit/glue/password_form.h
   M /trunk/src/webkit/glue/password_form_dom_manager.cc
   M /trunk/src/webkit/glue/password_form_dom_manager.h
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.h
   M /trunk/src/webkit/glue/plugins/nphostapi.h
   M /trunk/src/webkit/glue/plugins/plugin_data_stream.cc
   M /trunk/src/webkit/glue/plugins/plugin_data_stream.h
   M /trunk/src/webkit/glue/plugins/plugin_host.cc
   M /trunk/src/webkit/glue/plugins/plugin_host.h
   M /trunk/src/webkit/glue/plugins/plugin_instance.cc
   M /trunk/src/webkit/glue/plugins/plugin_instance.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.h
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.h
   M /trunk/src/webkit/glue/plugins/plugin_stream.cc
   M /trunk/src/webkit/glue/plugins/plugin_stream.h
   M /trunk/src/webkit/glue/plugins/plugin_stream_url.cc
   M /trunk/src/webkit/glue/plugins/plugin_stream_url.h
   M /trunk/src/webkit/glue/plugins/plugin_string_stream.cc
   M /trunk/src/webkit/glue/plugins/plugin_string_stream.h
   M /trunk/src/webkit/glue/plugins/test/npapi_constants.cc
   M /trunk/src/webkit/glue/plugins/test/npapi_constants.h
   M /trunk/src/webkit/glue/plugins/test/npapi_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_arguments_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_arguments_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_client.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_client.h
   M /trunk/src/webkit/glue/plugins/test/plugin_delete_plugin_in_stream_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_delete_plugin_in_stream_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_execute_script_delete_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_execute_script_delete_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_get_javascript_url_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_get_javascript_url_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_geturl_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_geturl_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_new_fails_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_new_fails_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_npobject_lifetime_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_npobject_lifetime_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_npobject_proxy_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_npobject_proxy_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_test.h
   M /trunk/src/webkit/glue/plugins/test/plugin_window_size_test.cc
   M /trunk/src/webkit/glue/plugins/test/plugin_window_size_test.h
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc
   M /trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h
   M /trunk/src/webkit/glue/regular_expression_unittest.cc
   M /trunk/src/webkit/glue/resource_fetcher.cc
   M /trunk/src/webkit/glue/resource_fetcher.h
   M /trunk/src/webkit/glue/resource_fetcher_unittest.cc
   M /trunk/src/webkit/glue/resource_handle_win.cc
   M /trunk/src/webkit/glue/resource_loader_bridge.h
   M /trunk/src/webkit/glue/resource_type.h
   M /trunk/src/webkit/glue/searchable_form_data.cc
   M /trunk/src/webkit/glue/searchable_form_data.h
   M /trunk/src/webkit/glue/simple_clipboard_impl.cc
   M /trunk/src/webkit/glue/unittest_test_server.h
   M /trunk/src/webkit/glue/webcursor.cc
   M /trunk/src/webkit/glue/webcursor.h
   M /trunk/src/webkit/glue/webdatasource.h
   M /trunk/src/webkit/glue/webdropdata.cc
   M /trunk/src/webkit/glue/webdropdata.h
   M /trunk/src/webkit/glue/weberror.h
   M /trunk/src/webkit/glue/weberror_impl.cc
   M /trunk/src/webkit/glue/weberror_impl.h
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_unittest.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.h
   M /trunk/src/webkit/glue/webhistoryitem.h
   M /trunk/src/webkit/glue/webhistoryitem_impl.h
   M /trunk/src/webkit/glue/webinputevent.cc
   M /trunk/src/webkit/glue/webinputevent.h
   M /trunk/src/webkit/glue/webkit_glue.cc
   M /trunk/src/webkit/glue/webkit_glue.h
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_delegate.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webplugin_impl_unittest.cc
   M /trunk/src/webkit/glue/webpreferences.h
   M /trunk/src/webkit/glue/webresponse.h
   M /trunk/src/webkit/glue/webresponse_impl.h
   M /trunk/src/webkit/glue/webtextinput.h
   M /trunk/src/webkit/glue/webtextinput_impl.cc
   M /trunk/src/webkit/glue/webtextinput_impl.h
   M /trunk/src/webkit/glue/weburlrequest.h
   M /trunk/src/webkit/glue/weburlrequest_impl.cc
   M /trunk/src/webkit/glue/weburlrequest_impl.h
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/glue/window_open_disposition.h
   M /trunk/src/webkit/port/bindings/v8/JSXPathNSResolver.h
   M /trunk/src/webkit/port/bindings/v8/V8SVGPODTypeWrapper.h
   M /trunk/src/webkit/port/bindings/v8/dom_wrapper_map.h
   M /trunk/src/webkit/port/bindings/v8/np_v8object.h
   M /trunk/src/webkit/port/bindings/v8/v8_binding.h
   M /trunk/src/webkit/port/bindings/v8/v8_collection.h
   M /trunk/src/webkit/port/bindings/v8/v8_custom.h
   M /trunk/src/webkit/port/bindings/v8/v8_events.h
   M /trunk/src/webkit/port/bindings/v8/v8_helpers.h
   M /trunk/src/webkit/port/bindings/v8/v8_index.h
   M /trunk/src/webkit/port/bindings/v8/v8_nodefilter.h
   M /trunk/src/webkit/port/bindings/v8/v8_np_utils.h
   M /trunk/src/webkit/port/bindings/v8/v8_npobject.h
   M /trunk/src/webkit/port/bindings/v8/v8_proxy.h
   M /trunk/src/webkit/port/bindings/v8/v8_utility.h
   M /trunk/src/webkit/port/bindings/v8/v8_vectornodelist.h
   M /trunk/src/webkit/port/bridge/JSBridge.h
   M /trunk/src/webkit/port/bridge/KJSBridge.h
   M /trunk/src/webkit/port/bridge/V8Bridge.h
   M /trunk/src/webkit/port/css/RGBColor.h
   M /trunk/src/webkit/port/dom/ScheduledAction.h
   M /trunk/src/webkit/port/page/ChromeClientWin.h
   M /trunk/src/webkit/port/page/Location.h
   M /trunk/src/webkit/port/page/Navigator.h
   M /trunk/src/webkit/port/platform/FramelessScrollView.h
   M /trunk/src/webkit/port/platform/LogWin.h
   M /trunk/src/webkit/port/platform/StateTrackingString.h
   M /trunk/src/webkit/port/platform/ThemeData.h
   M /trunk/src/webkit/port/platform/UniscribeStateTextRun.h
   M /trunk/src/webkit/port/platform/WidgetClientWin.h
   M /trunk/src/webkit/port/platform/cairo.h
   M /trunk/src/webkit/port/platform/graphics/ImageSourceSkia.h
   M /trunk/src/webkit/port/platform/graphics/NativeImageSkia.h
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.h
   M /trunk/src/webkit/port/platform/graphics/PlatformGraphics.h
   M /trunk/src/webkit/port/platform/graphics/SkGraphicsContext.h
   M /trunk/src/webkit/port/platform/graphics/SkPaintContext.h
   M /trunk/src/webkit/port/platform/graphics/SkiaUtils.h
   M /trunk/src/webkit/port/platform/graphics/svg/SkiaSupport.h
   M /trunk/src/webkit/port/platform/image-decoders/bmp/BMPImageDecoder.h
   M /trunk/src/webkit/port/platform/image-decoders/bmp/BMPImageReader.h
   M /trunk/src/webkit/port/platform/image-decoders/ico/ICOImageDecoder.h
   M /trunk/src/webkit/tools/layout_tests/layout_package/compare_failures.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/compare_failures_unittest.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/http_server.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/path_utils.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/platform_utils.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/platform_utils_win.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/test_expectations.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/test_failures.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/test_shell_thread.py
   M /trunk/src/webkit/tools/layout_tests/layout_package/test_types_unittest.py
   M /trunk/src/webkit/tools/layout_tests/run_webkit_tests.py
   M /trunk/src/webkit/tools/layout_tests/test_types/image_diff.py
   M /trunk/src/webkit/tools/layout_tests/test_types/simplified_text_diff.py
   M /trunk/src/webkit/tools/layout_tests/test_types/test_type_base.py
   M /trunk/src/webkit/tools/layout_tests/test_types/text_diff.py
   M /trunk/src/webkit/tools/leak_tests/run_node_leak_test.py
   M /trunk/src/webkit/tools/merge/update-branch-webkit.py
   M /trunk/src/webkit/tools/test_shell/drag_delegate.cc
   M /trunk/src/webkit/tools/test_shell/drag_delegate.h
   M /trunk/src/webkit/tools/test_shell/drop_delegate.cc
   M /trunk/src/webkit/tools/test_shell/drop_delegate.h
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.cc
   M /trunk/src/webkit/tools/test_shell/event_sending_controller.h
   M /trunk/src/webkit/tools/test_shell/foreground_helper.h
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.cc
   M /trunk/src/webkit/tools/test_shell/image_decoder_unittest.h
   M /trunk/src/webkit/tools/test_shell/keyboard_unittest.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.cc
   M /trunk/src/webkit/tools/test_shell/layout_test_controller.h
   M /trunk/src/webkit/tools/test_shell/layout_test_controller_unittest.cc
   M /trunk/src/webkit/tools/test_shell/node_leak_test.cc
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/run_all_tests.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc
   M /trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.h
   M /trunk/src/webkit/tools/test_shell/test_navigation_controller.cc
   M /trunk/src/webkit/tools/test_shell/test_navigation_controller.h
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.h
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_switches.h
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h
   M /trunk/src/webkit/tools/test_shell/text_input_controller.cc
   M /trunk/src/webkit/tools/test_shell/text_input_controller.h
   M /trunk/src/webkit/tools/test_shell/text_input_controller_unittest.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.h
   M /trunk/src/webkit/tools/test_shell/webwidget_host.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h

Use a more compact license header in source files.
------------------------------------------------------------------------
r1282 | nsylvain@google.com | 2008-08-23 23:40:52 +0200 (Sat, 23 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/download_uitest.cc

Try to remove the flakyness in the test by adding a Sleep.
------------------------------------------------------------------------
r1249 | rahulk@google.com | 2008-08-23 00:17:57 +0200 (Sat, 23 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.rc
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/app/chrome_exe.rc
   D /trunk/src/chrome/app/resources/chrome.ico
   D /trunk/src/chrome/app/theme/about_background.png
   D /trunk/src/chrome/app/theme/about_background_rtl.png
   A /trunk/src/chrome/app/theme/chromium
   A /trunk/src/chrome/app/theme/chromium/about_background.png
   A /trunk/src/chrome/app/theme/chromium/about_background_rtl.png
   A /trunk/src/chrome/app/theme/chromium/chromium.ico
   A /trunk/src/chrome/app/theme/chromium/product_logo.png
   A /trunk/src/chrome/app/theme/chromium/wizard_icon.png
   A /trunk/src/chrome/app/theme/chromium/wizard_icon_rtl.png
   A /trunk/src/chrome/app/theme/distribution_resources.rc
   D /trunk/src/chrome/app/theme/distributor_logo.png
   D /trunk/src/chrome/app/theme/distributor_logo_light.png
   D /trunk/src/chrome/app/theme/google_theme_resources.rc
   D /trunk/src/chrome/app/theme/product_logo.png
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.rc
   D /trunk/src/chrome/app/theme/wizard_icon.png
   D /trunk/src/chrome/app/theme/wizard_icon_rtl.png
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/browser/resources/new_tab.html
   M /trunk/src/chrome/tools/build/win/html_inline.py

Move distribution specific theme images:
- Google Chrome images are in internal repository now and get checked out into app\theme\google_chrome so delete them from app\theme
- Add Chromium images to app\theme\Chromium
- Modify html inlining script to pick up images from different places depending on environment variable (for now the default is google chrome which will change to chromium).
- Moving icon file to private repository as well so delete it from public repository. In its place add chromium icon.
- chromium\product_logo.png is a not actually a logo but just the blue icon in the same size as google_chrome\product_logo.png. This file makes about:version and new tab page look prettier (imo).

BUG=1296800

------------------------------------------------------------------------
r1219 | deanm@google.com | 2008-08-22 13:38:17 +0200 (Fri, 22 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/browser/net/dns_master.h
   M /trunk/src/chrome/browser/net/dns_slave.cc

Refactor thread naming in the DNS slaves.

BUG=1337196
------------------------------------------------------------------------
r1203 | jar@google.com | 2008-08-22 05:21:15 +0200 (Fri, 22 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h

Preclude large UMA uploads (but ensure histograms and crash data are sent)


bug=1338039

r=petersont,evanm
------------------------------------------------------------------------
r1184 | erg@google.com | 2008-08-21 23:13:01 +0200 (Thu, 21 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h
   M /trunk/src/webkit/glue/chrome_client_impl.cc
   M /trunk/src/webkit/glue/webwidget_delegate.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

Fix ChromeClientImpl::windowRect() to return the current
window's rect. Previously, it was combining the window
origin with the size of the renderer; not the size of the
window.

BUG=1186573
------------------------------------------------------------------------
r1181 | sky@google.com | 2008-08-21 22:56:31 +0200 (Thu, 21 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete.h
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.h
   M /trunk/src/chrome/browser/bookmark_bar_model.h

Fixes up the autocomplete providers to correctly update starred
state. I broke this in order to land my last mongo
patch. HistoryContentsProvider is still lacking in one area.

BUG=1256202
TEST=none

------------------------------------------------------------------------
r1179 | joshia@google.com | 2008-08-21 22:45:22 +0200 (Thu, 21 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents_delegate.h

Add missing file to fix the build
TBR=nsylvain

------------------------------------------------------------------------
r1176 | joshia@google.com | 2008-08-21 22:34:45 +0200 (Thu, 21 Aug 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/external_host_bindings.cc
   M /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Code review changes. Incorporated all the suggestions from previous review. 

One item not changed yet is to rename 'receiver' in ForwardMessageToExternalHost.
The idea is to invoke receiver("message") at the other end. So for example if the
args to ForwardMessageToExternalHost("hello", "world") then we will invoke a
script hello("world") on the other side.

'receiver' doesn't really describe the first argument here so if there is a 
better suggestion, I would be happy to change it :)

------------------------------------------------------------------------
r1173 | brettw@google.com | 2008-08-21 21:59:44 +0200 (Thu, 21 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Fix leak on shutdown in the navigation controller. The pending entry was not
getting deleted.
------------------------------------------------------------------------
r1170 | rahulk@google.com | 2008-08-21 21:33:13 +0200 (Thu, 21 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/build/internal/chromium_build.vsprops
   M /trunk/src/build/internal/chromium_build_google_chrome.vsprops
   A /trunk/src/chrome/app/theme/google_theme_resources.rc (from /trunk/src/chrome/app/theme/google_theme_resources.rc:1164)
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/common/resource_bundle.cc

Unrollback r1158.

BUG=1296800

------------------------------------------------------------------------
r1165 | rahulk@google.com | 2008-08-21 20:18:30 +0200 (Thu, 21 Aug 2008) | 2 lines
Changed paths:
   D /trunk/src/chrome/app/theme/google_theme_resources.rc
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/common/resource_bundle.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc

Revert 1158 as it is breaking ui_tests

------------------------------------------------------------------------
r1163 | sky@google.com | 2008-08-21 20:12:20 +0200 (Thu, 21 Aug 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_model.cc

Fixes bug in BookmarkBarNode. I wasn't resetting a load handle
resulting in the possibility of trying to cancel a bogus load handle.

I'm TBRing this one as I just introduced this and its easy to hit a
DCHECK now.

BUG=1256202
TEST=none


------------------------------------------------------------------------
r1158 | rahulk@google.com | 2008-08-21 19:01:42 +0200 (Thu, 21 Aug 2008) | 5 lines
Changed paths:
   A /trunk/src/chrome/app/theme/google_theme_resources.rc
   M /trunk/src/chrome/app/theme/theme_dll.vcproj
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/common/resource_bundle.cc

Do not display "Google" in titlebar of Chromium builds. 

- Create a new resource file that will contain Google Chrome specific resources. Ideally this new resource file should not be in the Chromium project at all but there doesnt seem to be any way to do conditional includes in vcproj files. So we ifdef its contents.
- Make distributor logo optional. If we do not find it, we do not try to paint/layout logo.

------------------------------------------------------------------------
r1153 | sky@google.com | 2008-08-21 17:20:33 +0200 (Thu, 21 Aug 2008) | 37 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   M /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   M /trunk/src/chrome/browser/bookmark_codec.cc
   M /trunk/src/chrome/browser/bookmark_codec.h
   M /trunk/src/chrome/browser/bookmark_drag_data.cc
   M /trunk/src/chrome/browser/bookmark_drag_data.h
   M /trunk/src/chrome/browser/bookmark_storage.cc
   M /trunk/src/chrome/browser/bookmark_storage.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/history/archived_database.cc
   M /trunk/src/chrome/browser/history/archived_database.h
   M /trunk/src/chrome/browser/history/expire_history_backend.cc
   M /trunk/src/chrome/browser/history/expire_history_backend.h
   M /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history.cc
   M /trunk/src/chrome/browser/history/history.h
   M /trunk/src/chrome/browser/history/history_backend.cc
   M /trunk/src/chrome/browser/history/history_backend.h
   M /trunk/src/chrome/browser/history/history_backend_unittest.cc
   M /trunk/src/chrome/browser/history/history_database.cc
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/history/history_marshaling.h
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/history/history_querying_unittest.cc
   M /trunk/src/chrome/browser/history/history_types.cc
   M /trunk/src/chrome/browser/history/history_types.h
   M /trunk/src/chrome/browser/history/history_unittest.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   M /trunk/src/chrome/browser/history/in_memory_history_backend.h
   M /trunk/src/chrome/browser/history/starred_url_database.cc
   M /trunk/src/chrome/browser/history/starred_url_database.h
   M /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   M /trunk/src/chrome/browser/history/text_database.h
   M /trunk/src/chrome/browser/history/text_database_manager.h
   M /trunk/src/chrome/browser/history/url_database.cc
   M /trunk/src/chrome/browser/history/url_database.h
   M /trunk/src/chrome/browser/history/url_database_unittest.cc
   M /trunk/src/chrome/browser/history_model.cc
   M /trunk/src/chrome/browser/history_model.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/common/chrome_constants.cc
   M /trunk/src/chrome/common/chrome_constants.h
   M /trunk/src/chrome/common/notification_types.h
   A /trunk/src/chrome/test/data/bookmarks
   A /trunk/src/chrome/test/data/bookmarks/History_with_empty_starred
   A /trunk/src/chrome/test/data/bookmarks/History_with_starred
   M /trunk/src/chrome/test/data/profiles/typical_history/Default/History
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/tools/profiles/generate_profile.cc

Moves bookmarks out of history into its own file (JSON).

Interesting points:
. Migration was a bit atypical. Here is the approach I took:
  . If the URL db contains bookmarks it writes the bookmarks to a
    temporary file.
  . When the bookmark bar model is loaded it assumes bookmarks are
    stored in a file. If the bookmarks file doesn't exist it then
    attempts to load from history, after waiting for history to finish
    processing tasks.
. I've broken having the omnibox query for starred only. This patch
  was already too ginormous for me to contemplate this too. I'll return
  to it after I land this.
. Similarly the history page isn't searching for starred titles
  now. As we discussed with Glen, that is probably fine for now.
. I've converted NOTIFY_STARRED_FAVICON_CHANGED to
  NOTIFY_FAVICON_CHANGED and it is notified ANY time a favicon
  changes. I'm mildly concerned about the extra notifications, but
  without having history know about starred it's the best I can do for
  now.
. Autocomplete (specifically URLDatabase::AutocompleteForPrefix)
  previously sorted by starred. It can no longer do this. I don't
  think I can get this functionality back:( Luckily it only mattered
  if you had a starred and non-starred URL with the same type count
  that matched a query. Probably pretty rare.

What's left:
. Fix up HistoryContentsProvider to query for starred entries titles.
. Clean up the delete all case. I basically just made it compile; it
  can be greatly simplified.
. Rename BookmarkBarModel to BookmarksModel.

BUG=1256202
TEST=this is a huge change to bookmarks. Thanfully it's pretty well
  covered by tests, none-the-less make sure you exercise bookmarks
  pretty heavily to make sure nothing is busted.

------------------------------------------------------------------------
r1146 | darin@google.com | 2008-08-21 11:46:32 +0200 (Thu, 21 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/base.xcodeproj/project.pbxproj
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/non_thread_safe.cc
   M /trunk/src/base/non_thread_safe.h
   D /trunk/src/base/platform_thread.cc
   M /trunk/src/base/platform_thread.h
   A /trunk/src/base/platform_thread_posix.cc
   A /trunk/src/base/platform_thread_win.cc
   M /trunk/src/base/thread.cc
   M /trunk/src/base/thread.h
   D /trunk/src/base/thread_posix.cc
   M /trunk/src/base/thread_unittest.cc
   M /trunk/src/base/watchdog.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/net/dns_master.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/renderer_main.cc
   M /trunk/src/webkit/default_plugin/plugin_install_job_monitor.h

Port the Thread class properly to Mac and Linux.  This involved porting
PlatformThread and creating an API on PlatformThread to create a native thread
and later join with it.  I also made a few other tweaks to PlatformThread, such
as eliminating the Current() method which appears to be unused.  The
operator==() is also unused, so I killed it as well.

I made a few other miscellaneous cleanups and adjustments.

------------------------------------------------------------------------
r1144 | jnd@google.com | 2008-08-21 04:58:09 +0200 (Thu, 21 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/character_encoding.cc
   M /trunk/src/chrome/browser/character_encoding.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/webview.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

As Brett pointed it out, We normally use 8-bit for encoding names since they're always ASCII. Plus, wstrings will also be 32-bit characters on Linux and Mac, which is expensive. So I make this CL by using std::string instead of std::wstring every time you have an encoding name.

------------------------------------------------------------------------
r1142 | sgk@google.com | 2008-08-21 03:26:40 +0200 (Thu, 21 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript

Track removal of browser\navigation_controller_base.cc.
TBR: brettw
------------------------------------------------------------------------
r1137 | brettw@google.com | 2008-08-21 02:51:20 +0200 (Thu, 21 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/base/linked_ptr.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   D /trunk/src/chrome/browser/navigation_controller_base.cc
   D /trunk/src/chrome/browser/navigation_controller_base.h

Kill NavigationControllerBase. I merged the two into NavigationController.

This fixes a leak of NavigationEntry's by using the spiffy linked ptr. I had to
add a const to linked_ptr for the comparisons to work.

BUG=1319484
------------------------------------------------------------------------
r1121 | erg@google.com | 2008-08-21 00:40:40 +0200 (Thu, 21 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc

Revert a fix where I mistakenly assumed that numbers coming into 
Browser::MoveContents() were content sizes instead of window sizes;
this broke a unit test and is incorrect.

Reopening the other bug; it seems like webkit is getting totally wrong
numbers when asking for a window's size.

BUG=1334628, 
------------------------------------------------------------------------
r1117 | beng@google.com | 2008-08-21 00:07:28 +0200 (Thu, 21 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/views/window.cc

Allow popups using the new frames to be sized correctly. This involved a slight tweak to how RestoreWindowPosition on Window works - if the window is opened with specified bounds, we still ask the delegate to try and restore the position. The delegate can use the provided bounds as a hint (in the popup case the bounds aren't the true layout bounds of the window, rather the rect contains the window position and content area size) to return the actual bounds of the window.

B=1031854

------------------------------------------------------------------------
r1116 | sky@google.com | 2008-08-21 00:06:21 +0200 (Thu, 21 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc

Fixes leak in BookmarkBarContextMenu test.

BUG=1335232
TEST=none

------------------------------------------------------------------------
r1098 | mpcomplete@google.com | 2008-08-20 20:37:48 +0200 (Wed, 20 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/gears_integration.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/gears_api.h

Chrome changes to allow non-ASCII characters in shortcut filenames.

BUG=1331408
------------------------------------------------------------------------
r1097 | glen@google.com | 2008-08-20 20:12:43 +0200 (Wed, 20 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_bubble.cc

Workaround for truncation of "Search from right here" text when using Hebrew Chrome on Vista. Will file separate bug so the root cause is fixed.

BUG=1325257

------------------------------------------------------------------------
r1082 | nsylvain@google.com | 2008-08-20 05:47:42 +0200 (Wed, 20 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc

Disable this interactive ui tests because it fails on the bot.
------------------------------------------------------------------------
r1063 | tc@google.com | 2008-08-20 00:35:29 +0200 (Wed, 20 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/build/base.vcproj
   A /trunk/src/base/time_format.cc
   A /trunk/src/base/time_format.h
   M /trunk/src/chrome/browser/download_tab_view.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/common/time_format.cc
   M /trunk/src/chrome/common/time_format.h
   M /trunk/src/chrome/common/time_format_unittest.cc
   M /trunk/src/net/base/net_util.cc

Move time formatters that only use ICU into base/time.*
This allows us to use the time formatters in, e.g., net
or webkit.

Remove CookieExpires since it's not used.

BUG=1164516


------------------------------------------------------------------------
r1049 | sidchat@google.com | 2008-08-19 22:09:18 +0200 (Tue, 19 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_dragging_test.cc

Drag tab 2 out of the tab strip.
------------------------------------------------------------------------
r1047 | finnur@google.com | 2008-08-19 21:47:24 +0200 (Tue, 19 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_view.cc

The truncation on the match count label (bug 1110432) has been bugging me a bit. This problem has actually improved a bit over time (we used to truncate from the left, but now we are cutting off a small 1 px strip from the bottom). I noticed that we are extending the label one pixel too far down anyway, so by removing that the problem goes away.

BUG=1110432
TEST=Open Find, paste some random text into the Find box (something that will result in 0 matched) and notice that the red background on the match-count label is rectangular, not 6-sided. :)

------------------------------------------------------------------------
r1046 | darin@google.com | 2008-08-19 21:29:47 +0200 (Tue, 19 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

The automation system can be torn down before all of the notification observers
that the automation system created.

------------------------------------------------------------------------
r1039 | brettw@google.com | 2008-08-19 19:38:12 +0200 (Tue, 19 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_base.cc
   M /trunk/src/chrome/browser/navigation_controller_base.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/chrome/common/notification_types.h
   A /trunk/src/chrome/test/test_notification_tracker.cc (from /trunk/src/chrome/test/test_notification_tracker.cc:962)
   A /trunk/src/chrome/test/test_notification_tracker.h (from /trunk/src/chrome/test/test_notification_tracker.h:962)
   M /trunk/src/chrome/test/unit/unittests.vcproj

Cleans up notifications for the NavigationController. There were several
notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well.

I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about.

I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad.

BUG=1325636,1321376,1325779
------------------------------------------------------------------------
r1038 | beng@google.com | 2008-08-19 19:31:19 +0200 (Tue, 19 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Make the otr avatar icon not show in detached OTR popup windows.

B=1031854
------------------------------------------------------------------------
r1032 | brettw@google.com | 2008-08-19 17:42:20 +0200 (Tue, 19 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_base.cc
   M /trunk/src/chrome/browser/navigation_controller_base.h
   M /trunk/src/chrome/browser/navigation_entry.cc
   M /trunk/src/chrome/browser/navigation_entry.h
   M /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/ssl_uitest.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/web_contents.cc

Factor the SSL state out of the main NavigationEntry into a helper class. This
makes it easier to find stuff and also copy ssl state (just assign).

I made one "real" change in web_contents where I copy the entire SSL state now
to the new entry rather than just a few fields like the old one. I couldn't
figure out why this was necessary: running it shows that this leaves the other
two fields in the uninitialized state which seems wrong.
------------------------------------------------------------------------
r1011 | mmentovai@google.com | 2008-08-19 01:59:51 +0200 (Tue, 19 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/base/DEPS
   M /trunk/src/base/gfx/DEPS
   M /trunk/src/breakpad/DEPS
   M /trunk/src/chrome/DEPS
   M /trunk/src/chrome/app/DEPS
   M /trunk/src/chrome/browser/DEPS
   M /trunk/src/chrome/common/DEPS
   M /trunk/src/chrome/installer/DEPS
   M /trunk/src/chrome/renderer/DEPS
   M /trunk/src/chrome/test/DEPS
   M /trunk/src/chrome/test/perf/DEPS
   M /trunk/src/net/DEPS
   M /trunk/src/skia/DEPS
   M /trunk/src/testing/DEPS
   M /trunk/src/third_party/DEPS
   M /trunk/src/webkit/build/JavaScriptCore/DEPS
   M /trunk/src/webkit/default_plugin/DEPS
   M /trunk/src/webkit/glue/DEPS
   M /trunk/src/webkit/glue/plugins/DEPS

Use LF for newlines in all DEPS files
------------------------------------------------------------------------
r1003 | pkasting@google.com | 2008-08-19 00:30:08 +0200 (Tue, 19 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

* Land the fix for issue 1322174 (which is not last-minute) on the trunk.  This has already landed on branch.
* Revert one of my earlier fixes to hack some RTL engine names to be "LTR-friendly" to work around bugs in the engine management dialog.  We also show these names in _other_ places (like the keyword UI in the omnibox) which are not buggy, so I broke these.
* Change the URLs for msn.co.il, which unlike seemingly all other MSN sites is actually really using MSN and not Live Search under the hood, and thus has a different URL layout.

BUG=1322174,1329557,1329566
------------------------------------------------------------------------
r999 | rahulk@google.com | 2008-08-18 23:39:43 +0200 (Mon, 18 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_exe.vcproj
   M /trunk/src/chrome/browser/shell_integration.cc
   M /trunk/src/chrome/installer/mini_installer/mini_installer.h
   M /trunk/src/chrome/installer/setup/install.cc
   M /trunk/src/chrome/installer/setup/main.cc
   M /trunk/src/chrome/installer/setup/setup.vcproj
   M /trunk/src/chrome/installer/setup/uninstall.cc
   A /trunk/src/chrome/installer/util/browser_distribution.cc
   A /trunk/src/chrome/installer/util/browser_distribution.h
   A /trunk/src/chrome/installer/util/google_chrome_distribution.cc
   A /trunk/src/chrome/installer/util/google_chrome_distribution.h
   A /trunk/src/chrome/installer/util/google_chrome_distribution_unittest.cc (from /trunk/src/chrome/installer/util/install_util_unittest.cc:653)
   M /trunk/src/chrome/installer/util/helper.cc
   M /trunk/src/chrome/installer/util/install_util.cc
   M /trunk/src/chrome/installer/util/install_util.h
   D /trunk/src/chrome/installer/util/install_util_unittest.cc
   M /trunk/src/chrome/installer/util/installer_unittests.vcproj
   M /trunk/src/chrome/installer/util/prebuild/create_string_rc.py
   M /trunk/src/chrome/installer/util/shell_util.cc
   D /trunk/src/chrome/installer/util/using_util.vsprops
   M /trunk/src/chrome/installer/util/util.vcproj
   M /trunk/src/chrome/installer/util/util_constants.cc
   M /trunk/src/chrome/installer/util/util_constants.h
   M /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   M /trunk/src/chrome/test/mini_installer_test/mini_installer_test.vcproj
   M /trunk/src/chrome/tools/build/win/release.rules

First set of changes to start separating Google specific branding from Chromium. This change mostly tries to modify installer to install Chromium or Google Chrome depending on a compile flag. The goal is to try to isolate all the differences in a single class that can be overridden for customization. There is also a lot of refactoring to make this happen.

Some changes are yet to be done but I didn't want to make this change even bigger than it already is. With all these changes the default build should still work as it is (Google Chrome should get installed/uninstalled). The changes yet to be done:
- Separating string resources (this is marked by TODO in one of the files)
- Generate different chrome.7z (Chromium will not include rlz.dll) for mini_installer

BUG=1296800

------------------------------------------------------------------------
r997 | jnd@google.com | 2008-08-18 23:24:29 +0200 (Mon, 18 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   M /trunk/src/chrome/browser/render_view_context_menu_controller.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/webkit/glue/context_menu_client_impl.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h
   M /trunk/src/webkit/pending/FrameLoader.h
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.cc
   M /trunk/src/webkit/tools/test_shell/test_webview_delegate.h

The CL is consist of CLs(1624,1580) for bug:1281734 which are reviewed and LG by brett. I just merge them to single one for passing compilation.
The CL is to fix bug http://b/issue?id=1281734. FireFox uses encoding used by the original webpage to decode the source of the webpage, Chrome does not. We need to add a new parameter which carries the override encoding when opening a view-source URL for viewing its source.

------------------------------------------------------------------------
r992 | beng@google.com | 2008-08-18 22:56:14 +0200 (Mon, 18 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Hook up the window icon for app windows, with a throbber etc.
Also add support for OTR icon.B=1031854
------------------------------------------------------------------------
r972 | maruel@google.com | 2008-08-16 03:25:33 +0200 (Sat, 16 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_shell.h

Explicitly include logging.h in a header that assumed it was already getting included.

TBR=nsylvain@google.com
------------------------------------------------------------------------
r965 | iyengar@google.com | 2008-08-15 23:41:39 +0200 (Fri, 15 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/render_view_host.h

Fix build break.

TBR=joshia

------------------------------------------------------------------------
r964 | iyengar@google.com | 2008-08-15 23:22:15 +0200 (Fri, 15 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Added support for PostMessage from the automation framework to
the renderer.

------------------------------------------------------------------------
r963 | brettw@google.com | 2008-08-15 23:18:04 +0200 (Fri, 15 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_base.cc
   M /trunk/src/chrome/browser/navigation_controller_base.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/chrome/common/notification_types.h
   D /trunk/src/chrome/test/test_notification_tracker.cc
   D /trunk/src/chrome/test/test_notification_tracker.h
   M /trunk/src/chrome/test/unit/unittests.vcproj


------------------------------------------------------------------------
r959 | joshia@google.com | 2008-08-15 22:33:28 +0200 (Fri, 15 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h

Add missing files from the previous change

TBR=iyengar

------------------------------------------------------------------------
r957 | joshia@google.com | 2008-08-15 22:12:42 +0200 (Fri, 15 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/renderer/external_host_bindings.cc
   A /trunk/src/chrome/renderer/external_host_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/chrome/test/automation/automation_messages_internal.h

Code to facilitate sending message to external host.

Note that at this time the parameters to the message
are still tentative. The call goes as a sync call from
renderer to the browser. From then onwards it happens 
async and no return value is available yet.

------------------------------------------------------------------------
r956 | brettw@google.com | 2008-08-15 22:10:49 +0200 (Fri, 15 Aug 2008) | 20 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_base.cc
   M /trunk/src/chrome/browser/navigation_controller_base.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/common/notification_details.h
   M /trunk/src/chrome/common/notification_source.h
   M /trunk/src/chrome/common/notification_types.h
   A /trunk/src/chrome/test/test_notification_tracker.cc
   A /trunk/src/chrome/test/test_notification_tracker.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Cleans up notifications for the NavigationController. There were several
notifications before and some of them were very unclear and misused
(STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases
as well.

I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more
clear and covers (I think!) all the cases that the callers care about.

I added a simple notification testing helper class, and used in the navigation
controller unit tests to make sure we get the proper notifications. I had to
change NotificationSource/Details to have a = and copy constructor so I can
track them easily in my helper. I don't see why this would be bad.

As part of this, I got very frustrated recompiling the world whenever
navigation_types.h changed. So I removed this dependency from the notification
service which everybody includes. Most of the changed files are adding
notification_types.h in the .cc file where it's needed.

BUG=1325636,1321376,1325779

------------------------------------------------------------------------
r955 | timsteele@google.com | 2008-08-15 20:46:34 +0200 (Fri, 15 Aug 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_resources.rc
   M /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/profile.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/renderer_security_policy.cc
   M /trunk/src/chrome/browser/simple_xp_frame.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/notification_types.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/dom_ui_bindings.cc
   M /trunk/src/chrome/renderer/dom_ui_bindings.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/test/testing_profile.h

Copy from http://chrome-reviews.prom.corp.google.com/1237 (new gcl changelist model).

Description was:
Conditionally include personalization/ code by surrounding
the hooks into this module with #ifdef CHROME_PERSONALIZATION
in various .h/.cc files.

Building with the module requires adding this macro as a preprocessor
definition in build/internal/essential.vsprops, and adding it to the
VCResourceCompiler tool's command line (using /d). We will try and
make this easier in the future.

TBR=darin

------------------------------------------------------------------------
r954 | mpcomplete@google.com | 2008-08-15 20:36:46 +0200 (Fri, 15 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/chrome_plugin_host.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/common/chrome_plugin_api.h
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/plugin/webplugin_proxy.h
   M /trunk/src/chrome/renderer/SConscript
   A /trunk/src/chrome/renderer/chrome_plugin_host.cc (from /trunk/src/chrome/plugin/chrome_plugin_host.cc:868)
   A /trunk/src/chrome/renderer/chrome_plugin_host.h (from /trunk/src/chrome/plugin/chrome_plugin_host.h:868)
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/renderer/render_thread.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h
   M /trunk/src/chrome/renderer/renderer.vcproj
   M /trunk/src/webkit/glue/webplugin.h
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/glue/webplugin_impl.h
   M /trunk/src/webkit/glue/webview_delegate.h

Step 1 at making Gears run in the renderer process (enabled by switch
"--gears-in-renderer").  Requires some changes to gears to work.  Most things
work if you disable the sandbox.  One major hole is that update tasks don't
report status to the appropriate renderer.

------------------------------------------------------------------------
r937 | maruel@google.com | 2008-08-15 14:27:03 +0200 (Fri, 15 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/build/base.vcproj
   A /trunk/src/base/ref_counted.cc
   M /trunk/src/base/ref_counted.h
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/browser_window.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/debugger/debugger_io.h
   M /trunk/src/chrome/browser/debugger/debugger_node.cc
   M /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/download_tab_view.cc
   M /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/external_tab_container.h
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_controller.h
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/browser/frame_view.cc
   M /trunk/src/chrome/browser/history_view.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/navigation_controller_base.cc
   M /trunk/src/chrome/browser/navigation_controller_base.h
   M /trunk/src/chrome/browser/network_status_view.cc
   M /trunk/src/chrome/browser/page_load_tracker.cc
   M /trunk/src/chrome/browser/page_load_tracker.h
   M /trunk/src/chrome/browser/password_manager.cc
   M /trunk/src/chrome/browser/printing/page_overlays.cc
   M /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   M /trunk/src/chrome/browser/printing/printer_query.h
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   A /trunk/src/chrome/browser/session_id.h (from /trunk/src/chrome/browser/session_service.h:806)
   M /trunk/src/chrome/browser/session_restore.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/shell_dialogs.h
   M /trunk/src/chrome/browser/simple_xp_frame.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/tabs/tab.cc
   M /trunk/src/chrome/browser/tabs/tab.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/browser/views/browser_views.vcproj
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   A /trunk/src/chrome/browser/views/dom_view.cc
   M /trunk/src/chrome/browser/views/dom_view.h
   M /trunk/src/chrome/browser/views/download_item_view.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/info_bar_item_view.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/views/options/options_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/star_toggle.cc
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/web_app_launcher.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/wizard/wizard.cc
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/common/chrome_plugin_lib.cc
   M /trunk/src/chrome/common/chrome_plugin_lib.h
   M /trunk/src/chrome/common/common.vcproj
   M /trunk/src/chrome/common/drag_drop_types.cc
   M /trunk/src/chrome/common/drag_drop_types.h
   M /trunk/src/chrome/common/gfx/chrome_font.cc
   M /trunk/src/chrome/common/gfx/chrome_font.h
   A /trunk/src/chrome/common/pref_member.cc
   M /trunk/src/chrome/common/pref_member.h
   M /trunk/src/chrome/common/pref_member_unittest.cc
   M /trunk/src/chrome/common/pref_service.h
   M /trunk/src/chrome/test/ui/view_event_test_base.cc
   M /trunk/src/chrome/test/ui/view_event_test_base.h
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/chrome/views/accelerator.cc
   M /trunk/src/chrome/views/accelerator.h
   M /trunk/src/chrome/views/accessibility/accessible_wrapper.h
   M /trunk/src/chrome/views/accessibility/autocomplete_accessibility.cc
   M /trunk/src/chrome/views/accessibility/view_accessibility.cc
   M /trunk/src/chrome/views/base_button.cc
   M /trunk/src/chrome/views/base_button.h
   M /trunk/src/chrome/views/bitmap_scroll_bar.cc
   M /trunk/src/chrome/views/button.cc
   M /trunk/src/chrome/views/button.h
   M /trunk/src/chrome/views/button_dropdown.cc
   M /trunk/src/chrome/views/checkbox.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/combo_box.cc
   M /trunk/src/chrome/views/controller.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   A /trunk/src/chrome/views/dialog_delegate.cc
   M /trunk/src/chrome/views/dialog_delegate.h
   M /trunk/src/chrome/views/event.cc
   M /trunk/src/chrome/views/event.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/label.cc
   M /trunk/src/chrome/views/link.cc
   M /trunk/src/chrome/views/menu.cc
   M /trunk/src/chrome/views/menu.h
   M /trunk/src/chrome/views/menu_button.cc
   M /trunk/src/chrome/views/native_button.cc
   M /trunk/src/chrome/views/native_control.cc
   M /trunk/src/chrome/views/painter.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view_drop_target.cc
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/text_button.cc
   M /trunk/src/chrome/views/text_field.cc
   M /trunk/src/chrome/views/tree_view.cc
   M /trunk/src/chrome/views/view.cc
   M /trunk/src/chrome/views/view.h
   M /trunk/src/chrome/views/view_container.h
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/window.cc
   A /trunk/src/chrome/views/window_delegate.cc
   M /trunk/src/chrome/views/window_delegate.h
   M /trunk/src/net/base/ev_root_ca_metadata.h
   M /trunk/src/net/base/upload_data.cc
   M /trunk/src/net/base/upload_data_stream.cc
   M /trunk/src/net/disk_cache/file.h
   M /trunk/src/net/disk_cache/mapped_file.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.h
   M /trunk/src/webkit/glue/plugins/plugin_data_stream.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.cc

Large patch set (159 files total) to cleanup the includes.

- Slightly reduce the size of the generated .lib files ~3%.
- Reduce the number of implicit and explicit atl and windows includes. hooray!
- Help incremental build by reducing the number of unnecessary included files.
- Split some template class in two, one base class for the common code and the specialization that inherits from the base class.

------------------------------------------------------------------------
r928 | darin@google.com | 2008-08-15 06:32:57 +0200 (Fri, 15 Aug 2008) | 36 lines
Changed paths:
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/message_loop.cc
   M /trunk/src/base/message_loop.h
   M /trunk/src/base/message_loop_unittest.cc
   A /trunk/src/base/message_pump.h
   A /trunk/src/base/message_pump_win.cc
   A /trunk/src/base/message_pump_win.h
   M /trunk/src/base/test_suite.h
   M /trunk/src/base/thread.cc
   M /trunk/src/chrome/app/chrome_dll_main.cc
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/automation/automation_provider_list.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   M /trunk/src/chrome/browser/site_instance_unittest.cc
   M /trunk/src/chrome/browser/url_fetcher_unittest.cc
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h
   M /trunk/src/chrome/common/message_router.h
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/test/automation/automation_proxy.cc
   M /trunk/src/chrome/test/automation/automation_proxy.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/net/http/http_cache_unittest.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/webkit/glue/bookmarklet_unittest.cc
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_test.cc

Introduce MessagePump to represent the native message pump used to drive a
MessageLoop.  A MessageLoop now has a MessagePump.

This will make it possible to port the MessagePump interface to other platforms
as well as to use an IO completion port for our worker threads on Windows.

Currently, there is only MessagePumpWin, which attempts to preserve the
pre-existing behavior of the MessageLoop.

API changes to MessageLoop:

1.  MessageLoop::Quit means return from Run when the MessageLoop would
otherwise wait for more work.

2.  MessageLoop::Quit can no longer be called outside the context of an active Run
call.  So, things like this:
  MessageLoop::current()->Quit();
  MessageLoop::current()->Run();
are now:
  MessageLoop::current()->RunAllPending();

3.  MessageLoop::Quit can no longer be called from other threads.  This means that
PostTask(..., new MessageLoop::QuitTask()) must be used explicitly to Quit across
thread boundaries.

4.  No protection is made to deal with nested MessageLoops involving watched
objects or APCs.  In fact, an assertion is added to flag such cases.  This is a
temporary measure until object watching and APC facilities are removed in favor
of a MessagePump designed around an IO completion port.

As part of this CL, I also changed the automation system to use an
IPC::ChannelProxy instead of an IPC::Channel.  This moves the automation IPC
onto Chrome's IO thread where it belongs.  I also fixed some abuses of
RefCounted in the AutomationProvider class.  It was deleting itself in some
cases!  This led to having to fix the ownership model for AutomationProvider,
which explains the changes to AutomationProviderList and so on.
------------------------------------------------------------------------
r918 | beng@google.com | 2008-08-15 02:19:55 +0200 (Fri, 15 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/browser/frame_util.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   M /trunk/src/chrome/browser/render_widget_host_hwnd.h
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/hwnd_view_container.h

Make theme change notifications for the renderer originate from the RenderWidgetHostHWND, not the frame.

B=1326392

------------------------------------------------------------------------
r908 | erg@google.com | 2008-08-15 01:09:11 +0200 (Fri, 15 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/menu.cc
   M /trunk/src/chrome/views/menu.h

Hook up the system menu in new frames.

BUG=1319684
------------------------------------------------------------------------
r907 | paulg@google.com | 2008-08-15 01:08:14 +0200 (Fri, 15 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/download_file.cc
   M /trunk/src/chrome/browser/download_file.h
   M /trunk/src/chrome/browser/download_manager.cc

Ensure that the default download directory exists when the
DownloadManager is initialized.

BUG=1324355
------------------------------------------------------------------------
r904 | sidchat@google.com | 2008-08-15 00:52:44 +0200 (Fri, 15 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/browser/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h


------------------------------------------------------------------------
r893 | maruel@google.com | 2008-08-14 23:16:24 +0200 (Thu, 14 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/printing/page_setup.cc

Some printers advertise longer printable length than the page length. Remove the DCHECK that was verifying this. I would have liked to had a buffer to accept ~5 inch of difference but at that point, the dpi is not known.
------------------------------------------------------------------------
r890 | ojan@google.com | 2008-08-14 23:07:14 +0200 (Thu, 14 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   A /trunk/src/chrome/test/data/unload
   A /trunk/src/chrome/test/data/unload/nolisteners.html
   A /trunk/src/chrome/test/data/unload/unload.html
   A /trunk/src/chrome/test/data/unload/unloadlooping.html
   A /trunk/src/chrome/test/data/unload/unloadloopingalert.html
   A /trunk/src/chrome/test/data/unload/unloadloopingtwosecondsalert.html

A first stab at testing browser close behavior when there are unload listeners
registered. There are still a ton of tests to add as listed in the TODO, but I 
figured it would be good to get this reviewed first before delving too far into 
figuring out how to deal with beforeunload dialogs.
------------------------------------------------------------------------
r881 | brettw@google.com | 2008-08-14 22:23:36 +0200 (Thu, 14 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/find_in_page_controller.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_view_host_delegate.h
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Make the FindInPageController implement its own delegate interface for
RenderViewHost so that we can get rid of the pass-throughs in WebContents.

I removed some redundant checks in WebContents when calling view() for
render_view_host() since that internally checks the null-ness of
render_view_host().

BUG=1323267

------------------------------------------------------------------------
r879 | beng@google.com | 2008-08-14 22:10:00 +0200 (Thu, 14 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h

Add End-session handling and app modal dialog handling to BrowserView2/New Frames.

B=1031854

------------------------------------------------------------------------
r877 | rahulk@google.com | 2008-08-14 21:28:17 +0200 (Thu, 14 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad.cc
   M /trunk/src/chrome/app/chrome_exe.vcproj
   D /trunk/src/chrome/app/google_update_settings.cc
   D /trunk/src/chrome/app/google_update_settings.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/rlz/rlz.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/installer/setup/uninstall.cc
   A /trunk/src/chrome/installer/util/google_update_settings.cc (from /trunk/src/chrome/app/google_update_settings.cc:870)
   A /trunk/src/chrome/installer/util/google_update_settings.h (from /trunk/src/chrome/app/google_update_settings.h:870)
   M /trunk/src/chrome/installer/util/util.vcproj

Moving GoogleUpdateSettings to util. Installer as well as Chrome needs these settings.

BUG=1296800

------------------------------------------------------------------------
r873 | awalker@google.com | 2008-08-14 19:47:00 +0200 (Thu, 14 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/base/build/base_gfx.vcproj
   D /trunk/src/base/gfx/bitmap_platform_device.cc
   D /trunk/src/base/gfx/bitmap_platform_device.h
   A /trunk/src/base/gfx/bitmap_platform_device_win.cc
   A /trunk/src/base/gfx/bitmap_platform_device_win.h
   M /trunk/src/base/gfx/native_theme.cc
   M /trunk/src/base/gfx/native_theme.h
   D /trunk/src/base/gfx/platform_canvas.cc
   D /trunk/src/base/gfx/platform_canvas.h
   M /trunk/src/base/gfx/platform_canvas_unittest.cc
   A /trunk/src/base/gfx/platform_canvas_win.cc
   A /trunk/src/base/gfx/platform_canvas_win.h
   D /trunk/src/base/gfx/platform_device.cc
   D /trunk/src/base/gfx/platform_device.h
   A /trunk/src/base/gfx/platform_device_win.cc
   A /trunk/src/base/gfx/platform_device_win.h
   M /trunk/src/base/gfx/vector_canvas.cc
   M /trunk/src/base/gfx/vector_canvas.h
   M /trunk/src/base/gfx/vector_canvas_unittest.cc
   M /trunk/src/base/gfx/vector_device.cc
   M /trunk/src/base/gfx/vector_device.h
   M /trunk/src/chrome/browser/printing/printed_document.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   M /trunk/src/chrome/browser/printing/win_printing_context.cc
   M /trunk/src/chrome/browser/views/theme_helpers.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/webkit/glue/webframe.h
   M /trunk/src/webkit/glue/webframe_impl.cc
   M /trunk/src/webkit/glue/webframe_impl.h
   M /trunk/src/webkit/glue/webview_impl.cc
   M /trunk/src/webkit/glue/webview_impl.h
   M /trunk/src/webkit/glue/webwidget.h
   M /trunk/src/webkit/glue/webwidget_impl.cc
   M /trunk/src/webkit/glue/webwidget_impl.h
   M /trunk/src/webkit/pending/CanvasRenderingContext2D.cpp
   M /trunk/src/webkit/port/platform/PlatformScrollBar.h
   M /trunk/src/webkit/port/platform/PlatformScrollBarWin.cpp
   M /trunk/src/webkit/port/platform/ScrollViewWin.cpp
   M /trunk/src/webkit/port/platform/graphics/FontWin.cpp
   M /trunk/src/webkit/port/platform/graphics/GraphicsContextSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/ImageSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/PlatformContextSkia.h
   M /trunk/src/webkit/port/platform/graphics/SkGraphicsContext.cpp
   M /trunk/src/webkit/port/platform/graphics/SkGraphicsContext.h
   M /trunk/src/webkit/port/platform/graphics/SkPaintContext.cpp
   M /trunk/src/webkit/port/platform/graphics/SkPaintContext.h
   M /trunk/src/webkit/port/platform/graphics/svg/SVGPaintServerSkia.cpp
   M /trunk/src/webkit/port/platform/graphics/svg/SkiaSupport.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell.cc
   M /trunk/src/webkit/tools/test_shell/webview_host.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.cc
   M /trunk/src/webkit/tools/test_shell/webwidget_host.h


------------------------------------------------------------------------
r870 | sky@google.com | 2008-08-14 18:26:20 +0200 (Thu, 14 Aug 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc

Fixes two bugs in NavigationController:

. TabContentsWasDestroyed wasn't removing from the collector map,
  resulting.
. The collector map wasn't cleared in Destroy when it should have
  been.

This was the cause of random ui failures.

BUG=1324555
TEST=none

------------------------------------------------------------------------
r858 | iyengar@google.com | 2008-08-14 07:01:07 +0200 (Thu, 14 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

Removing the code which enables using the renderer dib in the browser backing
store as this hurts performance.

Bug=1314407

------------------------------------------------------------------------
r851 | cpu@google.com | 2008-08-14 04:23:20 +0200 (Thu, 14 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_init.cc

HuntForZombieChromeProcesses() is killing the child process of upgrade

- remove call from MessageWindow::~MessageWindow()
- fix bug in zombie killer so it recognizes own childs

BUG=1323601

------------------------------------------------------------------------
r850 | jar@google.com | 2008-08-14 03:51:34 +0200 (Thu, 14 Aug 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/spellchecker.cc
   M /trunk/src/chrome/browser/spellchecker.h

Cleanup spell check file to stop using reference counted pointers without need.

I don't really believe this will solve anything (in terms
of the bug), but it did remove some needless complexity
above the crash site in the stack.  There is a tiny chance
that there is a shutdown race, where the destruction of the
containing object raced ahead of the execution (and
resulting destruction) of a task.  I think the destruction
of the task by the containing object would probably be
bad anyway, and I doubt that it even happens... so this
is all about being cleaner. 
bug=1318039

r=brettw
------------------------------------------------------------------------
r846 | mmentovai@google.com | 2008-08-14 02:41:45 +0200 (Thu, 14 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/base/command_line.cc
   M /trunk/src/base/file_version_info.cc
   M /trunk/src/base/gfx/font_utils.cc
   M /trunk/src/base/win_util.cc
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/history/text_database.cc
   M /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/save_package.cc
   M /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   M /trunk/src/chrome/browser/visitedlink_master.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/memory_test/memory_test.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/reliability/page_load_test.cc
   M /trunk/src/chrome/test/security_tests/ipc_security_tests.cc
   M /trunk/src/net/disk_cache/backend_impl.cc
   M /trunk/src/net/disk_cache/block_files.cc
   M /trunk/src/net/disk_cache/stress_cache.cc
   M /trunk/src/net/tools/crash_cache/crash_cache.cc
   M /trunk/src/net/tools/tld_cleanup/tld_cleanup.cc
   M /trunk/src/sandbox/sandbox_poc/main_ui_window.cc
   M /trunk/src/sandbox/src/file_policy_test.cc
   M /trunk/src/sandbox/tools/finder/main.cc
   M /trunk/src/sandbox/tools/launcher/launcher.cc
   M /trunk/src/webkit/glue/dom_serializer.cc
   M /trunk/src/webkit/glue/webkit_glue.cc

Use %ls instead of %s in wprintf format strings for wchar_t fields.
------------------------------------------------------------------------
r835 | jabdelmalek@google.com | 2008-08-14 00:36:39 +0200 (Thu, 14 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Dummy change.

TBR=sky
------------------------------------------------------------------------
r834 | brettw@google.com | 2008-08-14 00:20:59 +0200 (Thu, 14 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc

Make Javascript alerts do IDN and proper handling of non-standard and file
schemes.

BUG=1323921,1323917


------------------------------------------------------------------------
r831 | sky@google.com | 2008-08-13 23:57:01 +0200 (Wed, 13 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/session_restore_uitest.cc


------------------------------------------------------------------------
r830 | sgk@google.com | 2008-08-13 23:54:15 +0200 (Wed, 13 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript

Add new bookmark_bar_context_menu_tonroller*.cc files and new
bookmark_editor_view_unittest.cc file.
Overlooked adding browser_views.lib to link of unit_tests.exe.
TBR: sky
------------------------------------------------------------------------
r828 | sky@google.com | 2008-08-13 23:51:45 +0200 (Wed, 13 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   A /trunk/src/chrome/browser/views/keyword_editor_view_unittest.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Tests for KeywordEditorView.

BUG=1324185


------------------------------------------------------------------------
r826 | finnur@google.com | 2008-08-13 23:10:05 +0200 (Wed, 13 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

The width of the version field is not wide enough for all cases. We used to use set_default_width, but that gives you a size based on the average font size, so if you pass in 15 you might only fit ie. 11 chars, depending on what the text is.

I'd like to just say, take up all the width you have available - up to the icon in the dialog, that is, but the icon is part of a background image, so I just define a set width for the text field. 

------------------------------------------------------------------------
r825 | beng@google.com | 2008-08-13 22:56:39 +0200 (Wed, 13 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Don't save the window position of popup windows.

B=1031854

------------------------------------------------------------------------
r823 | tc@google.com | 2008-08-13 21:49:10 +0200 (Wed, 13 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/breakpad/SConscript
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/app/resources/SConscript
   M /trunk/src/chrome/app/theme/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/debugger/SConscript
   M /trunk/src/chrome/browser/views/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/plugin/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/activex_test_control/SConscript
   M /trunk/src/chrome/test/automation/SConscript
   M /trunk/src/chrome/test/chrome_plugin/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/memory_test/SConscript
   M /trunk/src/chrome/test/mini_installer_test/SConscript
   M /trunk/src/chrome/test/page_cycler/SConscript
   M /trunk/src/chrome/test/plugin/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/security_tests/SConscript
   M /trunk/src/chrome/test/selenium/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/test/tab_switching/SConscript
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/third_party/sqlite/SConscript
   M /trunk/src/chrome/tools/crash_service/SConscript
   M /trunk/src/chrome/tools/perf/flush_cache/SConscript
   M /trunk/src/chrome/tools/test/image_diff/SConscript
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/google_update/SConscript
   M /trunk/src/net/SConscript
   M /trunk/src/net/tools/tld_cleanup/SConscript
   M /trunk/src/rlz/SConscript
   M /trunk/src/sandbox/src/SConscript
   M /trunk/src/skia/SConscript
   M /trunk/src/third_party/bsdiff/SConscript
   M /trunk/src/third_party/bspatch/SConscript
   M /trunk/src/third_party/bzip2/SConscript
   M /trunk/src/third_party/libjpeg/SConscript
   M /trunk/src/third_party/libpng/SConscript
   M /trunk/src/third_party/libxml/SConscript
   M /trunk/src/third_party/libxslt/SConscript
   M /trunk/src/third_party/lzma_sdk/SConscript
   M /trunk/src/third_party/modp_b64/SConscript
   M /trunk/src/third_party/zlib/SConscript
   M /trunk/src/webkit/SConscript
   M /trunk/src/webkit/activex_shim/SConscript
   M /trunk/src/webkit/activex_shim_dll/SConscript
   M /trunk/src/webkit/build/JSConfig/SConscript
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/V8Bindings/SConscript
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/build/localized_strings/SConscript
   M /trunk/src/webkit/build/port/SConscript
   M /trunk/src/webkit/default_plugin/SConscript
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/plugins/test/SConscript
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript

Set the svn:eol-style to LF on all SConscript files

TBR=evanm
------------------------------------------------------------------------
r818 | beng@google.com | 2008-08-13 20:20:04 +0200 (Wed, 13 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h

Copy contents of FrameView into BrowserView2. Once the old frames retire, we won't need this separate class.

B=1031852
------------------------------------------------------------------------
r817 | sky@google.com | 2008-08-13 20:19:01 +0200 (Wed, 13 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   A /trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Tests for BookmarkEditorView.

BUG=1323423
TEST=this is some tests.


------------------------------------------------------------------------
r813 | sky@google.com | 2008-08-13 19:17:36 +0200 (Wed, 13 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/session_restore_uitest.cc

Changes printf to fprintf(stderr) in hopes of determining flakiness.

BUG=none
TEST=none
------------------------------------------------------------------------
r807 | brettw@google.com | 2008-08-13 17:40:09 +0200 (Wed, 13 Aug 2008) | 18 lines
Changed paths:
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   M /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/history/history_notifications.h
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller.h
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/session_service.h
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/notification_types.h

First, this removes the dependency of NavigationController on the
SessionService. There were already some notifications that could be used to
tell what's going on, and I filled out the rest. I moved some notifications from
various places to the NavigationController.

In ssl_blocking_page, I removed a notification because it also calls
DidNavigateToEntry which does the notification (we got duplicate calls before).
In browser.cc I removed the tab parented notification since this is already
called by NavigationController::SetWindowID.

I removed some obsolete notifications and associated structures, especially in
history (like HOST_DELETED that was never issued).

I renamed the window_map_ in the MetricsService becuase it was actually a map
of controllers and Windows.

This also reorders the navigation_types header file to try to bring some order
to it.
------------------------------------------------------------------------
r805 | sky@google.com | 2008-08-13 17:31:07 +0200 (Wed, 13 Aug 2008) | 7 lines
Changed paths:
   A /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.cc
   A /trunk/src/chrome/browser/bookmark_bar_context_menu_controller.h
   A /trunk/src/chrome/browser/bookmark_bar_context_menu_controller_test.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   M /trunk/src/chrome/test/unit/unittests.vcproj

Moves bookmark bar context menu controller into its own files along
with a test.

BUG=none
TEST=none; just make sure context menu for bookmark bar still works


------------------------------------------------------------------------
r801 | maruel@google.com | 2008-08-13 17:18:54 +0200 (Wed, 13 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/save_page_uitest.cc

Enable back SavePageTest.SaveHTMLOnly since it was mostly failing on Windows 2000
and add debugging information to know how SavePageTest.SaveCompleteHTML is failing.

TBR=rocking
------------------------------------------------------------------------
r800 | maruel@google.com | 2008-08-13 17:09:14 +0200 (Wed, 13 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Disable PrintingLayoutTest.Delayed on Windows 2000 (even though it's already disabled). Also disable PrintingLayoutTest.IFrame, it's still flaky.
------------------------------------------------------------------------
r797 | sky@google.com | 2008-08-13 16:30:27 +0200 (Wed, 13 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/session_restore_uitest.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h

Two changes to help track down why session restore test is failing:
1. Adds a timeout in waiting for a tab to be restored.
2. Adds a bunch of printfs that will hopefully let me figure out where
   the test is failing.

BUG=none
TEST=none


------------------------------------------------------------------------
r796 | maruel@google.com | 2008-08-13 16:27:54 +0200 (Wed, 13 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/views/SConscript (from /trunk/src/chrome/browser/SConscript:711)
   A /trunk/src/chrome/browser/views/browser_views.vcproj (from /trunk/src/chrome/browser/browser.vcproj:711)
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/chrome_kjs.sln
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/memory_test/SConscript
   M /trunk/src/chrome/test/page_cycler/SConscript
   M /trunk/src/chrome/test/plugin/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/selenium/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/test/tab_switching/SConscript

Split browser.lib (200 megs) into browser.lib(242 source files, 175 megs) and browser_views.lib(65 source files, 30 megs).

This will hopefully improve link time (well, not as much as I'd like) and will definitely help non-IB compilation parallelization.
------------------------------------------------------------------------
r779 | finnur@google.com | 2008-08-13 05:11:19 +0200 (Wed, 13 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_commands.cc

When I added some new tests in automated_ui_tests I flushed out a crash in the IDC handler for ViewSource. If Navigate is not called before ViewSource we get a crash when trying to use the output from GetLastCommittedEntry(). To facilitate automatic testing We should instead just check it for null and only do something if a URL is available to us.

------------------------------------------------------------------------
r774 | beng@google.com | 2008-08-13 04:29:51 +0200 (Wed, 13 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc

Quick fix regression from previous change to toolbar - forgot to take into account the width of the Go button when sizing the location bar so that the last button on the toolbar (the app menu) spilled off the end.

TBR=glen

------------------------------------------------------------------------
r770 | beng@google.com | 2008-08-13 03:17:07 +0200 (Wed, 13 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/app/theme/locationbg_readonly_center.png
   M /trunk/src/chrome/app/theme/locationbg_readonly_left.png
   M /trunk/src/chrome/app/theme/locationbg_readonly_right.png
   M /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   M /trunk/src/chrome/browser/views/location_bar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h

Makes the toolbar/location bar look nice in popup windows.

Rather than creating a frankenstein separate window type for popups, this just uses BrowserView2, and the regular BrowserToolbarView, but hides all the irrelevant controls.

B=1031854
------------------------------------------------------------------------
r766 | cpu@google.com | 2008-08-13 02:18:24 +0200 (Wed, 13 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/breakpad.cc
   M /trunk/src/chrome/app/chrome_exe.vcproj
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h
   M /trunk/src/chrome/common/env_vars.cc
   M /trunk/src/chrome/common/env_vars.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Add a couple of metrics to help us quantify two cases that can prevent us to get crash reports.
- Added env_vars to exe project instead of keep duplicating the strings.

------------------------------------------------------------------------
r750 | sky@google.com | 2008-08-13 00:37:38 +0200 (Wed, 13 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/external_tab_container.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/root_view.cc
   M /trunk/src/chrome/views/root_view.h

Minor cleanup of RootView. Removes unused double_buffered field from
RootView, as well as renaming RootView::ProcessPendingPaint to PaintNow.

BUG=1255929
TEST=none


------------------------------------------------------------------------
r747 | tc@google.com | 2008-08-12 23:43:41 +0200 (Tue, 12 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Disable the Delayed UI test so the tree will be green.

TBR=maruel
------------------------------------------------------------------------
r732 | ojan@google.com | 2008-08-12 20:41:31 +0200 (Tue, 12 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Add a bit of plumbing to make it so Browser doesn't need to know about RenderViewHost.

Don't know how what I had before built. Tested more thoroughly this time.
------------------------------------------------------------------------
r731 | sgk@google.com | 2008-08-12 20:39:38 +0200 (Tue, 12 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript

Add browser\render_view_host_manager.cc to SCons build.
TBR: brettw
------------------------------------------------------------------------
r729 | maruel@google.com | 2008-08-12 20:38:00 +0200 (Tue, 12 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_job.cc
   M /trunk/src/chrome/browser/printing/print_job.h
   M /trunk/src/chrome/browser/printing/print_job_worker.cc
   M /trunk/src/chrome/browser/printing/printing_layout_uitest.cc

Use the new Thread::StopSoon() facility. Add a new tight loop to control the worker thread shutdown in a way that is safe even for printer driver that displays a dialog box and attaches to the browser window.

BUG=1274015
------------------------------------------------------------------------
r725 | erikkay@google.com | 2008-08-12 19:55:37 +0200 (Tue, 12 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/cancelable_request.cc
   M /trunk/src/chrome/browser/cancelable_request.h
   M /trunk/src/chrome/browser/navigation_profiler.cc
   M /trunk/src/chrome/browser/renderer_security_policy.cc

Fix a few places that wind up using Lock recursively.

------------------------------------------------------------------------
r724 | ojan@google.com | 2008-08-12 19:42:02 +0200 (Tue, 12 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Revert this CL. Breaks compile.
------------------------------------------------------------------------
r721 | maruel@google.com | 2008-08-12 19:32:49 +0200 (Tue, 12 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/SConscript.unit_tests
   A /trunk/src/chrome/browser/printing/page_number_unittest.cc
   A /trunk/src/chrome/browser/printing/page_overlays_unittest.cc
   A /trunk/src/chrome/browser/printing/page_range_unittest.cc
   A /trunk/src/chrome/browser/printing/units_unittest.cc
   M /trunk/src/chrome/test/unit/unittests.vcproj

Add some printing related unit tests.
------------------------------------------------------------------------
r720 | ojan@google.com | 2008-08-12 19:30:55 +0200 (Tue, 12 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h

Add a bit of plumbing just so Browser doesn't need to know about RenderViewHost.
------------------------------------------------------------------------
r719 | ojan@google.com | 2008-08-12 19:30:47 +0200 (Tue, 12 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc

Remove an invalid DCHECK. If we are closing the browser and
the beforeunload handler hangs, then is_waiting_for_unload_ack
will be true here.
------------------------------------------------------------------------
r716 | brettw@google.com | 2008-08-12 18:11:09 +0200 (Tue, 12 Aug 2008) | 10 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   A /trunk/src/chrome/browser/render_view_host_manager.cc
   A /trunk/src/chrome/browser/render_view_host_manager.h
   M /trunk/src/chrome/browser/ssl_blocking_page.cc
   M /trunk/src/chrome/browser/tab_contents.h
   M /trunk/src/chrome/browser/tab_contents_container_view.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents.h
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/browser/web_drop_target.cc
   M /trunk/src/chrome/common/notification_types.h

Move RenderViewHost management out of WebContents into a new
RenderViewHostManager object.

The goal for this patch is to change no logic or APIs, just move the code. So
there are some not very clean callback functions and no new unit tests for this
file (although is is still covered by the same WebContents unit tests). This
should make the actual cleanup in a later pass much easier to follow.

I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents.

------------------------------------------------------------------------
r713 | maruel@google.com | 2008-08-12 17:22:13 +0200 (Tue, 12 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/meta_table_helper.cc
   M /trunk/src/chrome/browser/page_load_tracker.cc
   M /trunk/src/chrome/common/chrome_counters.cc
   M /trunk/src/chrome/common/chrome_counters.h
   M /trunk/src/chrome/common/gfx/chrome_canvas.cc
   M /trunk/src/chrome/common/gfx/chrome_canvas.h
   M /trunk/src/chrome/common/ipc_message_utils.cc
   M /trunk/src/chrome/common/ipc_message_utils.h
   M /trunk/src/chrome/common/sqlite_compiled_statement.cc
   M /trunk/src/chrome/common/sqlite_compiled_statement.h
   M /trunk/src/chrome/common/sqlite_utils.cc
   M /trunk/src/chrome/common/sqlite_utils.h
   M /trunk/src/chrome/views/background.cc
   M /trunk/src/chrome/views/border.cc
   M /trunk/src/chrome/views/combo_box.cc

Cleanup a few files, reduce the number of includes.

Applied glint.

No code change, just moving around.
------------------------------------------------------------------------
r711 | darin@google.com | 2008-08-12 07:11:38 +0200 (Tue, 12 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/net/http/http_network_transaction.cc
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_fixed.cc
   M /trunk/src/net/proxy/proxy_resolver_fixed.h
   M /trunk/src/net/proxy/proxy_resolver_winhttp.cc
   M /trunk/src/net/proxy/proxy_resolver_winhttp.h
   M /trunk/src/net/proxy/proxy_service.cc
   M /trunk/src/net/proxy/proxy_service.h
   M /trunk/src/net/proxy/proxy_service_unittest.cc
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc

Change the ProxyService to work with ASCII strings.

------------------------------------------------------------------------
r708 | beng@google.com | 2008-08-12 06:09:26 +0200 (Tue, 12 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc

Fiddle with destruction order of the dragged tab controller to ensure that there's still a TabStrip available for it.

B=1145714

------------------------------------------------------------------------
r702 | finnur@google.com | 2008-08-12 05:13:44 +0200 (Tue, 12 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/views/importing_progress_view.cc

Fix crash due to race condition in ImportingProgressView.

What is happening is that the ImporterView creates an ImportingProgressView to show the progress of the import but the ImportingProgressView receives the Cancel event before ImportStarted, so importing_ is not set to true. Cancel will think import is done and returns true (allowing the view to be destroyed) and then the ImporterView will try to communicate with a dead observer.

By initializing importing_ to true this crash is avoided (we wouldn't be creating the view unless we were about to import, right?).

BUG=1320194
TEST=Open Import dialog, press Enter and then Esc really quickly and Chrome should not crash (try it 10 times to be sure).

------------------------------------------------------------------------
r695 | ifette@google.com | 2008-08-12 04:19:33 +0200 (Tue, 12 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc

Updating the SafeBrowsing database version to 3, to reset everyone's database
after we had database corruption last week from bad data being served
------------------------------------------------------------------------
r691 | jcampan@google.com | 2008-08-12 03:25:41 +0200 (Tue, 12 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/browser_shutdown.cc
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/common/ipc_channel_proxy.cc
   M /trunk/src/chrome/common/ipc_channel_proxy.h
   M /trunk/src/chrome/common/ipc_sync_channel.cc
   M /trunk/src/chrome/common/ipc_sync_channel.h
   M /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   M /trunk/src/chrome/common/ipc_sync_message.cc
   M /trunk/src/chrome/common/ipc_sync_message.h
   M /trunk/src/chrome/plugin/plugin_channel_base.cc
   M /trunk/src/chrome/plugin/plugin_thread.cc
   M /trunk/src/chrome/renderer/render_thread.cc
   M /trunk/src/chrome/test/testing_browser_process.h

Enabling sync_channel in the browser to allow accessibility code making blocking calls.  This replaces my previous CL that was somehow duplicating some of these functionalities.

BUG=None
TEST=Run the unit tests.
------------------------------------------------------------------------
r688 | sgk@google.com | 2008-08-12 02:31:12 +0200 (Tue, 12 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/build/SConscript.v8
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/browser/SConscript

SCons build updates:
* Add base\file_util_linux.cc.
* Add unit tests base\{idletimer,string_escape}_unittest.cc.
* Add chrome\browser\views\hwnd_html_view.cc.
* Add chrome\browser\tabs\tab_dragging_test.cc.
* Add chrome\browser\views\bookmark_bar_view_test.cc
* Add chrome\test\ui\view_event_test_base.cc.
* Only define on Windows build of base:  _Win32_WINNT=0x0600, WINVER=0x0600, _HAS_EXCEPTIONS=0.
TBR: bradnelson
------------------------------------------------------------------------
r685 | ojan@google.com | 2008-08-12 01:43:08 +0200 (Tue, 12 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/tab_contents_delegate.h

Don't terminate the process when a tab becomes unresponsive during 
unload/beforeunload. Instead, just call close on it. If two tabs are in the
same process, then terminating the process is totally wrong.
This also avoids the bugs where we show sad tab, or don't remove the
tab from the tabstrip.

Also, remove a couple of bogus DCHECKS.

BUG=1314995,1301757
------------------------------------------------------------------------
r679 | ojan@google.com | 2008-08-12 01:03:19 +0200 (Tue, 12 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.cc

If a sync message can't be routed, respond immediately with an error.
This will allow us to process alerts correctly if they happen after
the tab has been closed in the browser process.
------------------------------------------------------------------------
r675 | sidchat@google.com | 2008-08-12 00:53:17 +0200 (Tue, 12 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

Move Tab Drag Tests inside Project interactive_ui_tests

------------------------------------------------------------------------
r673 | tc@google.com | 2008-08-12 00:43:58 +0200 (Tue, 12 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc

If the user runs chrome with a language on the command line on
first-run, make sure we pass that language to the importer process.

The code for this is basically a copy of what is in
chrome/browser/render_process_host.cc:291.

TEST=Run "chrome --lang=ko --first-run" and import settings during first
  run.  Make sure the importer dialog is in Korean.

------------------------------------------------------------------------
r671 | jabdelmalek@google.com | 2008-08-11 22:06:33 +0200 (Mon, 11 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc

Per discussion with Brian/Mark/Ben, set the renderer timeout to 20 seconds but keep the plugin
at 10.  Not too ideal because the plugin dialog will come up incorrectl if webkit is hung, but
let's try it out for the next release and see if we're still getting complaints.

TBR=beng

------------------------------------------------------------------------
r668 | beng@google.com | 2008-08-11 21:24:25 +0200 (Mon, 11 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Small fix to remove a pixel gap between the client edge of the toolbars and the client edge of the content area.

B=1031854

------------------------------------------------------------------------
r665 | jabdelmalek@google.com | 2008-08-11 20:42:44 +0200 (Mon, 11 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/render_widget_host.cc

Set the hung renderer and plugin timeout to 10 seconds.

BUG=1314703
------------------------------------------------------------------------
r660 | beng@google.com | 2008-08-11 19:46:17 +0200 (Mon, 11 Aug 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/frame_util.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h
   M /trunk/src/chrome/views/hwnd_view_container.h

Another Frame Grab-Bag

- makes more stuff in Browser object only happen if you're using the old frames- rename BrowserWindow::Update to BrowserWindow::UpdateToolbar since that's what it does
- add window position save/restore handling to Browser- remove BrowserWindow::BrowserDidPaint
- relic from HaloFrame days- remove BrowserWindow::GetRootView - unused and exposes impl details- remove BrowserWindow::DetachFromBrowser - unused
- store BrowserView2* on HWND's property list so infobubbles can access it later- both frames (Opaque and AeroGlass) notify the BrowserView2 when they're moved so BrowserView2 can reposition the status bubble and close the autocomplete popup
- remove BrowserView2::ShowTabContents - no longer used
- remove BrowserView2::ShelfVisibilityChanged - no longer used
- remove BrowserView2::SetWindowTitle - never used
- remove BrowserView2::ProfileChanged - now called from TabSelectedAt- properly unhook infobars etc when a tab is detached

B=1031854
------------------------------------------------------------------------
r656 | timsteele@google.com | 2008-08-11 19:02:31 +0200 (Mon, 11 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/views/hwnd_html_view.cc
   A /trunk/src/chrome/browser/views/hwnd_html_view.h

A simple view that wraps a RenderViewHost in an HWNDView, to facilitate
rendering HTML as an arbitrary browser view. DOMView currently does something
like this, but it uses TabContents and is hence pretty heavyweight. We may be 
able to replace DOMView with HWNDHtmlView.
------------------------------------------------------------------------
r654 | sky@google.com | 2008-08-11 18:40:57 +0200 (Mon, 11 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/ui_controls.cc
   M /trunk/src/chrome/browser/automation/ui_controls.h
   M /trunk/src/chrome/browser/bookmark_bar_model.cc
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.h
   A /trunk/src/chrome/browser/views/bookmark_bar_view_test.cc
   M /trunk/src/chrome/test/testing_profile.cc
   M /trunk/src/chrome/test/testing_profile.h
   A /trunk/src/chrome/test/ui/view_event_test_base.cc
   A /trunk/src/chrome/test/ui/view_event_test_base.h
   M /trunk/src/chrome/test/unit/unittests.vcproj
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h
   M /trunk/src/chrome/views/menu_button.cc

A set of tests to exercise chrome menus as well as parts of bookmark
bar view. These are disabled until we straighten out the buildbot that
is always logged in.

BUG=1318922
TEST=this is just a bunch of tests.


------------------------------------------------------------------------
r651 | darin@google.com | 2008-08-11 17:40:23 +0200 (Mon, 11 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/net/build/net.vcproj
   M /trunk/src/net/build/net_unittests.vcproj
   M /trunk/src/net/http/http_cache.cc
   M /trunk/src/net/http/http_cache.h
   M /trunk/src/net/http/http_network_layer.cc
   M /trunk/src/net/http/http_network_layer.h
   M /trunk/src/net/http/http_network_session.h
   M /trunk/src/net/http/http_network_transaction.h
   M /trunk/src/net/http/http_network_transaction_unittest.cc
   D /trunk/src/net/http/http_proxy_resolver_fixed.cc
   D /trunk/src/net/http/http_proxy_resolver_fixed.h
   D /trunk/src/net/http/http_proxy_resolver_winhttp.cc
   D /trunk/src/net/http/http_proxy_resolver_winhttp.h
   D /trunk/src/net/http/http_proxy_service.cc
   D /trunk/src/net/http/http_proxy_service.h
   D /trunk/src/net/http/http_proxy_service_unittest.cc
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/http/http_transaction_winhttp.h
   A /trunk/src/net/proxy
   A /trunk/src/net/proxy/proxy_resolver_fixed.cc (from /trunk/src/net/http/http_proxy_resolver_fixed.cc:632)
   A /trunk/src/net/proxy/proxy_resolver_fixed.h (from /trunk/src/net/http/http_proxy_resolver_fixed.h:632)
   A /trunk/src/net/proxy/proxy_resolver_winhttp.cc (from /trunk/src/net/http/http_proxy_resolver_winhttp.cc:632)
   A /trunk/src/net/proxy/proxy_resolver_winhttp.h (from /trunk/src/net/http/http_proxy_resolver_winhttp.h:632)
   A /trunk/src/net/proxy/proxy_service.cc (from /trunk/src/net/http/http_proxy_service.cc:632)
   A /trunk/src/net/proxy/proxy_service.h (from /trunk/src/net/http/http_proxy_service.h:632)
   A /trunk/src/net/proxy/proxy_service_unittest.cc (from /trunk/src/net/http/http_proxy_service_unittest.cc:632)
   M /trunk/src/webkit/glue/plugins/mozilla_extensions.cc

Rename HttpProxy* classes to Proxy*.  Move them into a net/proxy/ subdirectory.

I'm making this change because proxy resolution is really not specific to the HTTP protocol.  We need to use the proxy service in our FTP implementation, for example.  I made a separate directory instead of just putting these in base, because I anticipate more files once we have our own PAC implementation.
------------------------------------------------------------------------
r638 | beng@google.com | 2008-08-10 22:49:48 +0200 (Sun, 10 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc

Increase the hung renderer warning delay to 30s temporarily.
------------------------------------------------------------------------
r633 | beng@google.com | 2008-08-09 23:23:21 +0200 (Sat, 09 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.cc

Make sure the TabStrip is laid out after a drag-detach operation is completed. This is important because if there was a pending animation it was canceled, potentially leaving the TabStrip in a bad visual state.

Also remove some debugging code that wasn't useful.

B=1317895
------------------------------------------------------------------------
r614 | beng@google.com | 2008-08-09 03:18:15 +0200 (Sat, 09 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Allow the window icon to be shown in the task bar, Alt+Tab etc.

B=1031854

------------------------------------------------------------------------
r612 | beng@google.com | 2008-08-09 02:38:19 +0200 (Sat, 09 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/simple_xp_frame.cc
   M /trunk/src/chrome/browser/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/views/custom_frame_window.cc

Even more tweaks.

- make window icon and title work on app windows
- make window title updating sync with the task bar
- make Aero Glass frame respect app mode settings
- move title formatting routine from TabRenderer into Browser (a more central location)
- appearance adjustments for app windows with info bars
------------------------------------------------------------------------
r611 | paulg@google.com | 2008-08-09 02:17:07 +0200 (Sat, 09 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/net/dns_master.cc

Remove includes that are already included in the header.
------------------------------------------------------------------------
r609 | sidchat@google.com | 2008-08-09 02:08:43 +0200 (Sat, 09 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_dragging_test.cc

Comment out the tests for now.

------------------------------------------------------------------------
r606 | sidchat@google.com | 2008-08-09 01:20:53 +0200 (Sat, 09 Aug 2008) | 4 lines
Changed paths:
   A /trunk/src/chrome/browser/tabs/tab_dragging_test.cc
   M /trunk/src/chrome/test/ui/ui_tests.vcproj

M    chrome/test/ui/ui_tests.vcproj
AM   chrome/browser/tabs/tab_dragging_test.cc


------------------------------------------------------------------------
r605 | beng@google.com | 2008-08-09 01:17:41 +0200 (Sat, 09 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

More tweaks to the frames. Provide proper layout for the title bar in app mode.
B=1031854
------------------------------------------------------------------------
r603 | tc@google.com | 2008-08-09 00:34:20 +0200 (Sat, 09 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/content_page_view.cc

Wrap the text in a label in the options dialog.

BUG=1314224
TEST=chrome --lang=fil, options, middle tab, the last section should not
  have elided text.
------------------------------------------------------------------------
r602 | tc@google.com | 2008-08-09 00:34:04 +0200 (Sat, 09 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_view.cc

Fix a bug in the first run dialog where the "Google Chrome is ready to
complete your installation." text would overlap the product icon.

BUG=1252749
TEST=chrome --lang=el --first-run and verify that the text wraps
------------------------------------------------------------------------
r601 | glen@google.com | 2008-08-09 00:24:51 +0200 (Sat, 09 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/tab_contents.cc

Fix for bug where we weren't resizing the content area at the end of a download shelf animation. This was caused by a disconnect between tabcontents::shelf_visible_ and the finished state.

BUG=1317014

------------------------------------------------------------------------
r600 | brettw@google.com | 2008-08-09 00:07:48 +0200 (Sat, 09 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/DEPS
   A /trunk/src/base/DEPS
   M /trunk/src/base/debug_on_start.cc
   A /trunk/src/base/gfx/DEPS
   A /trunk/src/breakpad/DEPS
   A /trunk/src/chrome/DEPS
   A /trunk/src/chrome/app/DEPS
   A /trunk/src/chrome/browser/DEPS
   A /trunk/src/chrome/common/DEPS
   A /trunk/src/chrome/installer/DEPS
   A /trunk/src/chrome/renderer/DEPS
   A /trunk/src/chrome/test/DEPS
   A /trunk/src/chrome/test/perf/DEPS
   A /trunk/src/net/DEPS
   A /trunk/src/skia/DEPS
   A /trunk/src/third_party/DEPS
   A /trunk/src/webkit/build/JavaScriptCore/DEPS
   A /trunk/src/webkit/default_plugin/DEPS
   A /trunk/src/webkit/glue/DEPS
   A /trunk/src/webkit/glue/plugins/DEPS

Add deps files and rules for the checkdeps script.
------------------------------------------------------------------------
r585 | erg@google.com | 2008-08-08 21:48:19 +0200 (Fri, 08 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h

Allow constrained popups to resize themselves...up to 10 times. (Then we ignore their pleas for resizes since they're obviously up to no good.)

BUG=1255747
------------------------------------------------------------------------
r578 | erikkay@google.com | 2008-08-08 20:26:20 +0200 (Fri, 08 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/app/resources/locale_settings_ar.rc
   M /trunk/src/chrome/app/resources/locale_settings_bg.rc
   M /trunk/src/chrome/app/resources/locale_settings_ca.rc
   M /trunk/src/chrome/app/resources/locale_settings_cs.rc
   M /trunk/src/chrome/app/resources/locale_settings_da.rc
   M /trunk/src/chrome/app/resources/locale_settings_de.rc
   M /trunk/src/chrome/app/resources/locale_settings_el.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   M /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   M /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   M /trunk/src/chrome/app/resources/locale_settings_es.rc
   M /trunk/src/chrome/app/resources/locale_settings_et.rc
   M /trunk/src/chrome/app/resources/locale_settings_fi.rc
   M /trunk/src/chrome/app/resources/locale_settings_fil.rc
   M /trunk/src/chrome/app/resources/locale_settings_fr.rc
   M /trunk/src/chrome/app/resources/locale_settings_he.rc
   M /trunk/src/chrome/app/resources/locale_settings_hi.rc
   M /trunk/src/chrome/app/resources/locale_settings_hr.rc
   M /trunk/src/chrome/app/resources/locale_settings_hu.rc
   M /trunk/src/chrome/app/resources/locale_settings_id.rc
   M /trunk/src/chrome/app/resources/locale_settings_it.rc
   M /trunk/src/chrome/app/resources/locale_settings_ja.rc
   M /trunk/src/chrome/app/resources/locale_settings_ko.rc
   M /trunk/src/chrome/app/resources/locale_settings_lt.rc
   M /trunk/src/chrome/app/resources/locale_settings_lv.rc
   M /trunk/src/chrome/app/resources/locale_settings_nb.rc
   M /trunk/src/chrome/app/resources/locale_settings_nl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pl.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   M /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   M /trunk/src/chrome/app/resources/locale_settings_ro.rc
   M /trunk/src/chrome/app/resources/locale_settings_ru.rc
   M /trunk/src/chrome/app/resources/locale_settings_sk.rc
   M /trunk/src/chrome/app/resources/locale_settings_sl.rc
   M /trunk/src/chrome/app/resources/locale_settings_sr.rc
   M /trunk/src/chrome/app/resources/locale_settings_sv.rc
   M /trunk/src/chrome/app/resources/locale_settings_th.rc
   M /trunk/src/chrome/app/resources/locale_settings_tr.rc
   M /trunk/src/chrome/app/resources/locale_settings_uk.rc
   M /trunk/src/chrome/app/resources/locale_settings_vi.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   M /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   M /trunk/src/chrome/browser/views/about_chrome_view.cc

Simplify AboutChromeView to only contain what someone would need to make a support request, removing official build number and user agent.  The more detailed version information is in about:version.

BUG=1300256

------------------------------------------------------------------------
r573 | beng@google.com | 2008-08-08 19:46:13 +0200 (Fri, 08 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_process.h
   M /trunk/src/chrome/browser/browser_process_impl.cc
   M /trunk/src/chrome/browser/browser_process_impl.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc

Tweaks to make the opaque frame look better including adding support for app windows. Document the constants in the non-client view. Make the OTR frame work. Add a check to browser process that we use to check if we're using the new frames so we can disable various functionality that isn't appropriate.

B=1031854
------------------------------------------------------------------------
r570 | brettw@google.com | 2008-08-08 19:16:25 +0200 (Fri, 08 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/firefox_importer_unittest.cc
   M /trunk/src/chrome/browser/importer_unittest.cc

Update Firefox importer tests to be in sync with the new escaping rules
for < and > in queries.
------------------------------------------------------------------------
r557 | darin@google.com | 2008-08-08 09:56:39 +0200 (Fri, 08 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_widget_host.cc

Third times a charm!  This is an attempt at re-landing r408.  This time the UI test is revised to give the browser a chance to notice a crashed tab.

TBR=nsylvain
------------------------------------------------------------------------
r543 | jar@google.com | 2008-08-08 00:49:27 +0200 (Fri, 08 Aug 2008) | 14 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_service.cc

Save memory prefs to disks more often

The goal is to reduce the window where it is possible that a crash of Chrome
will cause double counting of prior crashes.
This change records all the (hopefully consistent) memory-resident state of the
metrics service to disk as soon as we get an ack from UMA that a
log was received.
Without this, there is a possible gap between when the stats are copied
to a log, and sent, vs. when the (now) zeroed crash count is written to disk.


bug=1314946

r=evanm,petersont
------------------------------------------------------------------------
r535 | beng@google.com | 2008-08-07 22:37:43 +0200 (Thu, 07 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller.cc

Fix find box being positioned incorrectly. I moved the toolbar view into another view, so it's y-coordinate is always 0. Need to convert to ViewContainer coords to make the positioning work correctly.

B=1306098

------------------------------------------------------------------------
r529 | beng@google.com | 2008-08-07 21:45:53 +0200 (Thu, 07 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/find_in_page_controller.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/views/hwnd_view_container.h

More improvements to the frames. Consolidate some of the optional bar (bookmark, info, download) showing/layout, add a notion of supported window features, hook up some accelerator handling goop etc.

B=1031854

------------------------------------------------------------------------
r523 | beng@google.com | 2008-08-07 20:28:35 +0200 (Thu, 07 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab.cc
   M /trunk/src/chrome/browser/tabs/tab.h
   M /trunk/src/chrome/browser/tabs/tab_renderer.cc
   M /trunk/src/chrome/browser/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/chrome_menu.h

Make tabs affected by context menu actions pulse. The effect is somewhat subtle since I'm re-using the selection animation.

Added support to the Menu Delegate for notifications of when selection moves within the menu.

B=1313339
------------------------------------------------------------------------
r522 | darin@google.com | 2008-08-07 20:02:20 +0200 (Thu, 07 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/render_widget_host.cc

Disable the code that tries to use the transport DIB as the backing store of
the renderer.  I think this might be impacting preformance in a negative way.

R=iyengar

------------------------------------------------------------------------
r521 | tc@google.com | 2008-08-07 19:47:33 +0200 (Thu, 07 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/first_run_view.cc

Wrap text in the chrome first run dialog.


TEST=run chrome --lang=de --first-run and make sure the first bullet point wraps properly
BUG=1297554
------------------------------------------------------------------------
r516 | rahulk@google.com | 2008-08-07 17:49:49 +0200 (Thu, 07 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser_main.cc

Patch uninstall until we fix bug 1308130.

BUG=1311781
------------------------------------------------------------------------
r515 | brettw@google.com | 2008-08-07 17:29:49 +0200 (Thu, 07 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/base/string_util.h
   M /trunk/src/base/string_util_icu.cc
   M /trunk/src/base/string_util_mac.cc
   M /trunk/src/base/string_util_unittest.cc
   M /trunk/src/base/string_util_win.cc
   M /trunk/src/chrome/browser/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/tools/perf/flush_cache/flush_cache.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/sandbox/tests/common/controller.cc
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/plugins/plugin_list.cc
   M /trunk/src/webkit/glue/webplugin_impl.cc
   M /trunk/src/webkit/port/bridge/PluginsWin.cpp

Remove the old NativeMB functions from string util, and use the new ones in sys_strings.h. I also removed duplicated code from the sandbox that can now use this, and fixed one case in the bug reporter that should not have been using the native multibyte encoding.
------------------------------------------------------------------------
r510 | deanm@google.com | 2008-08-07 16:10:08 +0200 (Thu, 07 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/common/child_process.cc
   M /trunk/src/chrome/common/child_process.h
   M /trunk/src/chrome/plugin/plugin_process.cc

Move away from the deprecated atomic.h interface to AtomicRefCount and AtomicSequenceNumber.
------------------------------------------------------------------------
r503 | darin@google.com | 2008-08-07 09:24:18 +0200 (Thu, 07 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_widget_host.cc

rollback r498 and r500 to repair test bustage
------------------------------------------------------------------------
r500 | darin@google.com | 2008-08-07 09:00:58 +0200 (Thu, 07 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.cc

fix unit_test failures, where process_.handle() may be null
------------------------------------------------------------------------
r498 | darin@google.com | 2008-08-07 08:31:41 +0200 (Thu, 07 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_widget_host.cc

Revised r408 such that we no longer sometimes fail MetricsServiceTest.CrashRenderers.

That test showed that we were exiting the browser process without noticing that a child process had crashed.  I fixed that by simply adding a check to see if the child process is still around before initiating the normal close of the child process.  This corresponds to the case where the browser decides to close a renderer.

As a result, the race for the MessageLoop to receive a Task notifying the RenderProcessHost of a crashed renderer is removed from the picture.

The bulk of this CL is just re-landing r408, which jar reviewed.
------------------------------------------------------------------------
r469 | erg@google.com | 2008-08-07 01:27:17 +0200 (Thu, 07 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Restored tabs should be considered "owned" by whatever random tab is currently open.

BUG=1305200
------------------------------------------------------------------------
r466 | finnur@google.com | 2008-08-07 00:49:45 +0200 (Thu, 07 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/find_in_page_controller_interactive_uitest.cc
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/tab_proxy.cc
   M /trunk/src/chrome/test/automation/tab_proxy.h
   M /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj

Adding an interactive UI test to catch when switching between two tabs (both with FindInPage open) is trashing the Esc handler and causing a crash.

I originally tried an automated_ui test, but was unable to get it to work since Focus changes are involved.

BUG=1303709


------------------------------------------------------------------------
r465 | erikkay@google.com | 2008-08-07 00:33:53 +0200 (Thu, 07 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_about_handler.cc
   M /trunk/src/chrome/browser/browser_resources.rc
   M /trunk/src/chrome/browser/resources/about_version.html
   M /trunk/src/chrome/browser/resources/browser_resources.vcproj

* add webkit version and V8 version to about:version
* reformat page
* use new product image rather than an http link to google.com

BUG=1300256
------------------------------------------------------------------------
r458 | evanm@google.com | 2008-08-06 23:26:07 +0200 (Wed, 06 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/build/base.vcproj
   M /trunk/src/base/build/base_unittests.vcproj
   D /trunk/src/base/fixed_string.h
   D /trunk/src/base/fixed_string_unittest.cc
   M /trunk/src/chrome/browser/about_internets_status_view.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc

Drop FixedString.  It's only used in two places, one where it doesn't really matter and the other where it was incorrect.
------------------------------------------------------------------------
r443 | beng@google.com | 2008-08-06 20:46:35 +0200 (Wed, 06 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc

B=1302955 R=sky attempt to bandaid situation where tab_data_ and child list can get out of sync
------------------------------------------------------------------------
r438 | nsylvain@google.com | 2008-08-06 19:48:24 +0200 (Wed, 06 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_widget_host.cc

Revert change 408 to see if it fixes the ui tests.

------------------------------------------------------------------------
r429 | deanm@google.com | 2008-08-06 15:42:44 +0200 (Wed, 06 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_settings.cc

The printing NewCookie() must start counting at 1 and not 0, since 0
is reserved to mark a document as unassigned.


------------------------------------------------------------------------
r426 | deanm@google.com | 2008-08-06 14:05:24 +0200 (Wed, 06 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/printing/print_settings.cc
   M /trunk/src/chrome/browser/printing/print_settings.h

Move the printing cookie from direct atomic operations to AtomicSequenceNumber.


------------------------------------------------------------------------
r422 | iyengar@google.com | 2008-08-06 07:30:12 +0200 (Wed, 06 Aug 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/common/mru_cache.h
   M /trunk/src/chrome/common/render_messages.h
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_process.h
   M /trunk/src/chrome/renderer/render_widget.cc
   M /trunk/src/chrome/renderer/render_widget.h

This fixes http://b/issue?id=1257424, which is a need to implement a global backing store cache. The current backing store cache is only used for invisible tabs and every other RenderWidgetHost holds a reference to its backing store.

This CB proposes a change where in we have a global backing store cache, whose size can be controlled based on strategies like available resources etc. At this point the strategy is not implemented and the size is left at 5.
We no longer maintain a reference to the backing store in the RenderWidgetHost. Every host queries the global cache for its backing store. The cache provides methods to create the backing store and populate it with the required dib. 
The other change is to use the renderer dib when the size of the bitmap being painted is the same as the backing store size. This is an attempt to improve performance in operations like scrolling. 

Bug=1257424




------------------------------------------------------------------------
r421 | finnur@google.com | 2008-08-06 05:14:11 +0200 (Wed, 06 Aug 2008) | 13 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/views/focus_manager.h

Fix 1303709: Crash: Switching between tabs with a Find box open on both tabs nulls the Esc handler

This is a temporary fix until we fix this properly:
http://b/issue?id=1307173

This change makes sure that when we Register as the Esc handler, we store who was registered at the time the Find box was opened for the first time (as opposed to always restoring to what RegisterAccelerator tells us was registered before us).

Also, if we have already been unregistered, we don't restore the old value. 

This prevents us from restoring to another tab's handler when the tab registering gets focus notification before the tab *un*registering receives blur notification (through FocusWillChange).

BUG=1303709
TEST=Manually perform the steps listed in the bug and make sure it doesn't crash. Also make sure that the browser's Esc handler still works after closing the Find box.
------------------------------------------------------------------------
r411 | erg@google.com | 2008-08-06 02:36:48 +0200 (Wed, 06 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h

The rectangle passed in to MoveContents is a content rectangle, not a window rectangle as I assumed.

BUG=1186573
------------------------------------------------------------------------
r408 | darin@google.com | 2008-08-06 01:17:53 +0200 (Wed, 06 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/plugin_process_host.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_widget_host.cc

Convert more consumers of ML::WatchObject to ObjectWatcher.
------------------------------------------------------------------------
r402 | beng@google.com | 2008-08-06 00:34:28 +0200 (Wed, 06 Aug 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc

Fix crash due to race conditions in the way Browser unhooks its
NotificationObserver for WebContents disconnection... not all codepaths would
result in Browser being removed as an observer. This change simplifies things a
bit by adding Browser as an observer for a TabContents whenever it is inserted
into the Browser's tabstrip, and removing it whenever it's detached. These
notifications are designed to be symmetrical and handle all use cases including
create/destroy(close) and also tab dragging/detaching.

Thanks to Adam for helping diagnose this and suggesting this fix.

B=1307678
------------------------------------------------------------------------
r401 | pkasting@google.com | 2008-08-06 00:32:31 +0200 (Wed, 06 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

Another day, another prepopulate data change.

This should be the last substantive change to this list for beta; these are the search engine additions/removals from the quality team.  The only remaining change after this is the last-minute change to the Google referrer that we need to wait until next week to do.

BUG=1307246
------------------------------------------------------------------------
r396 | glen@google.com | 2008-08-05 23:56:45 +0200 (Tue, 05 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/vista_frame.cc

Left-align the distributor logo on RTL Vista while we wait for a properly flipped frame.

BUG=1308358
------------------------------------------------------------------------
r394 | maruel@google.com | 2008-08-05 23:23:36 +0200 (Tue, 05 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/app/result_codes.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc

Reapply revision 380 since it wasn't the cause of the build breakage.

------------------------------------------------------------------------
r390 | nsylvain@google.com | 2008-08-05 21:52:32 +0200 (Tue, 05 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/app/result_codes.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc

Revert revision 380 to see if it fixes the build. Please reapply once the tree is green.
------------------------------------------------------------------------
r380 | rahulk@google.com | 2008-08-05 19:30:38 +0200 (Tue, 05 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/result_codes.h
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/installer/setup/uninstall.cc

While uninstalling Chrome look for return codes from chrome.exe that indicate success instead of checking for failure codes. This will prevent us from uninstalling Chrome when chrome.exe process gets killed.

BUG=1307273
------------------------------------------------------------------------
r377 | beng@google.com | 2008-08-05 19:02:31 +0200 (Tue, 05 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Grab bag of random cleanups, implementation of some more methods, etc. I'm going to become more methodical about this soon, I promise.

B=1031854
------------------------------------------------------------------------
r360 | beng@google.com | 2008-08-05 03:49:35 +0200 (Tue, 05 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h

fix bustage
------------------------------------------------------------------------
r359 | beng@google.com | 2008-08-05 03:45:00 +0200 (Tue, 05 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Add the TabStrip to the BrowserView2. (hooked up for OpaqueFrame only at this point). Make non-client hittest logic mostly work. Window is somewhat interactive again. Yay!

B=1031854
------------------------------------------------------------------------
r352 | beng@google.com | 2008-08-05 02:06:22 +0200 (Tue, 05 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   M /trunk/src/chrome/browser/views/frame/browser_view2.cc
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h

Add the AeroGlassFrame and AeroGlassNonClientView for Vista.

Note that AeroGlassFrame needs a NonClientView as well - even though Windows draws most of the frame and its borders, we do some custom rendering in the non-client area, such as the distributor logo, the client edge and toolbar backgrounds. This necessitated allowing Window to support an optional NonClientView. I just jimmied this in for now... can clean up that API later if desired.

B=1031854
------------------------------------------------------------------------
r351 | jcampan@google.com | 2008-08-05 01:28:47 +0200 (Tue, 05 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/tools/automated_ui_test_tools/README.txt
   M /trunk/src/chrome/tools/automated_ui_test_tools/possible_actions.txt

Another attempt at this CL.
I had to revert because it was somehow causing regressions on the page cycler and start-up tests.
(I suspect because I did add an IPC message not at the end of the message list)

TBR=beng
------------------------------------------------------------------------
r346 | sgk@google.com | 2008-08-05 00:50:15 +0200 (Tue, 05 Aug 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript

Add browser/views/frame/browser_view2.cc.
TBR: beng
------------------------------------------------------------------------
r345 | jcampan@google.com | 2008-08-05 00:26:34 +0200 (Tue, 05 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/page_info_window.cc

Don't show the "Cert info" button when running with Gears (or anytime you have a cert with no associated os cert handle) as it requires the os cert handle.

BUG=1302313
TEST=Run GMail with Gears in offline mode. Open the page info. There should be no Cert Info button.


------------------------------------------------------------------------
r342 | paulg@google.com | 2008-08-05 00:12:22 +0200 (Tue, 05 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/download_tab_view.cc

Fix a bug where we try to reference a floating view after
its corresponding object has been removed via the "Clear
browsing data" command.

BUG=1270230
------------------------------------------------------------------------
r341 | petersont@google.com | 2008-08-04 23:59:45 +0200 (Mon, 04 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/metrics_service.cc
   M /trunk/src/chrome/browser/metrics_service.h

Implemented xml parsing of UMA server response data.
Used libxml rather than scanf/the wrapper class XmlReader.
More data from the response are recorded to be used later to control the transmissions.

------------------------------------------------------------------------
r337 | jcampan@google.com | 2008-08-04 22:40:50 +0200 (Mon, 04 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/tools/automated_ui_test_tools/README.txt
   M /trunk/src/chrome/tools/automated_ui_test_tools/possible_actions.txt

Reverting my last commit, it seems to cause regression on the page cycler tests.

TBR=beng
------------------------------------------------------------------------
r336 | darin@google.com | 2008-08-04 22:30:18 +0200 (Mon, 04 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.h

fix build bustage
------------------------------------------------------------------------
r333 | jcampan@google.com | 2008-08-04 21:59:31 +0200 (Mon, 04 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/automation/automation_provider.h
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   M /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   M /trunk/src/chrome/test/automation/automation_messages_internal.h
   M /trunk/src/chrome/test/automation/browser_proxy.cc
   M /trunk/src/chrome/test/automation/browser_proxy.h
   M /trunk/src/chrome/tools/automated_ui_test_tools/README.txt
   M /trunk/src/chrome/tools/automated_ui_test_tools/possible_actions.txt

Added testing of Chromium dialogs to the automated ui tests.
The new dialog command fires up a dialog (chosen randomly) and exercises it.

BUG=None
TEST=Run the automated_ui_test
------------------------------------------------------------------------
r332 | creis@google.com | 2008-08-04 21:36:36 +0200 (Mon, 04 Aug 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/navigation_controller.cc
   M /trunk/src/chrome/browser/navigation_controller_unittest.cc

Ensures that we clean up TabContents with other types after a navigation commits, even if their NavigationEntries aren't adjacent to the current entry.

Also makes NavigationController::Destroy compatible with NavigationControllerTest, which adds more tab types than TAB_CONTENTS_NUM_TYPES.  Also re-enables the SwitchTypes tests and adds another to prevent regression of this bug.

BUG=1296773
TEST=NavigationControllerTest.SwitchTypesCleanup
------------------------------------------------------------------------
r330 | beng@google.com | 2008-08-04 20:39:28 +0200 (Mon, 04 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc

When a new tab is opened (either the new tab page via Ctrl+T or pressing the new tab button) or an address is opened from the address bar in a new tab (by pressing Alt+Enter), the opener is remembered briefly, allowing quick lookup in a new tab without disrupting the z-order experience.

Full explanation in bug:

B=1266404
------------------------------------------------------------------------
r329 | beng@google.com | 2008-08-04 20:39:13 +0200 (Mon, 04 Aug 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/views/frame/browser_frame.h
   A /trunk/src/chrome/browser/views/frame/browser_view2.cc
   A /trunk/src/chrome/browser/views/frame/browser_view2.h
   M /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   M /trunk/src/chrome/browser/views/frame/opaque_frame.h
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   M /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/client_view.h

Bring up the new frame (opaque version for XP only, for now).

I've hidden this frame behind a command line switch (--magic_browzR) so as not to destabilize the main browser UI any further. Note that running with this switch is likely buggy, incomplete, crashy, etc.

In order to make this work without disrupting a lot of existing code, I've had to make another BrowserView class (temporary) - BrowserView2. This also has to be a BrowserWindow implementor since that's the interface Browser uses to communicate with the UI.

BrowserView2 and OpaqueNonClientView are the major new files in this CL, but BrowserView2 is pretty similar to BrowserView. OpaqueNonClientView is the view that renders the titlebar/borders/etc. It's layout/painting routines are a bit simpler than XPFrame's!

B=1031854
------------------------------------------------------------------------
r325 | erg@google.com | 2008-08-04 19:58:00 +0200 (Mon, 04 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/constrained_window.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/webkit/port/bindings/v8/v8_custom.cpp

Fix several issues with popup window locations:

1) Remove ConstrainedWindow::GenerateInitialBounds(), which is old and crufty and no longer relevant now that there are no unsuppressed, constrained popup windows.
2) Move the browser side positioning logic into Browser::BuildPopupWindow().
3) Fix the window.open() handler so that when we aren't given top=/left= coordinates, we don't set the window origin (allowing the browser to do something more intelligent).

BUG=1290758
------------------------------------------------------------------------
r306 | sgk@google.com | 2008-08-03 23:21:54 +0200 (Sun, 03 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.automated_ui_tests
   M /trunk/src/chrome/SConscript.ui_tests
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/app/resources/SConscript
   M /trunk/src/chrome/app/theme/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/debugger/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/plugin/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/activex_test_control/SConscript
   M /trunk/src/chrome/test/automation/SConscript
   M /trunk/src/chrome/test/chrome_plugin/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/mini_installer_test/SConscript
   M /trunk/src/chrome/test/page_cycler/SConscript
   M /trunk/src/chrome/test/plugin/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/security_tests/SConscript
   M /trunk/src/chrome/test/selenium/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/test/tab_switching/SConscript
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/third_party/sqlite/SConscript
   M /trunk/src/chrome/tools/crash_service/SConscript
   M /trunk/src/chrome/tools/perf/flush_cache/SConscript
   M /trunk/src/chrome/tools/test/image_diff/SConscript
   M /trunk/src/chrome/views/SConscript

Convert chrome SConscript files to psuedo-builder calls.
TBR: evanm,bradnelson


------------------------------------------------------------------------
r295 | mal@google.com | 2008-08-03 00:36:08 +0200 (Sun, 03 Aug 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

r65 was reverted in r71 because of a crash spike in the reliability tests.

It hasn't relanded, yet, so I thought I'd put it back before it slips through the cracks.

Original Description (r65, creis):
Makes the process model heuristic for generated searches only apply in --process-per-site, since it isn't relevant otherwise.  (This matters now that process-per-site-instance is the default.)

BUG=1256259
TEST=Visit a non-Google page, then run a search from the location bar.  The tab should switch renderer processes.



------------------------------------------------------------------------
r292 | maruel@google.com | 2008-08-02 20:37:12 +0200 (Sat, 02 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/save_page_uitest.cc

Filed bug 1306067 to reenable SavePageTest.SaveHTMLOnly. It is very flaky.

TBR
------------------------------------------------------------------------
r290 | maruel@google.com | 2008-08-02 20:03:31 +0200 (Sat, 02 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/app/browser.dll.deps
   M /trunk/src/chrome/app/plugin.dll.deps
   M /trunk/src/chrome/app/renderer.dll.deps
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/chrome.sln
   M /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/common_glue.cc
   M /trunk/src/chrome/renderer/render_process.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc

Trim the dependencies of the plugin_dll and renderer_dll projects. Browser_dll will follow. At this point, plugin.dll and renderer.dll are roughly 35% smaller than browser.dll and chrome.dll

BUG=1211534
------------------------------------------------------------------------
r274 | pkasting@google.com | 2008-08-02 02:46:56 +0200 (Sat, 02 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc

Lots of fixes for various issues with the prepopulate data uncovered during testing.

TBR=sky
BUG=1291438,1291559,1291598,1293274,1295631,1295636,1298147,1305160
------------------------------------------------------------------------
r273 | ojan@google.com | 2008-08-02 02:44:47 +0200 (Sat, 02 Aug 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/resource_message_filter.h
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/web_contents_unittest.cc
   M /trunk/src/chrome/common/render_messages_internal.h
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/chrome/renderer/render_view.h

A bunch of cleanups to beforeunload/unload handling.
1. Remove all the is_closing_browser plumbing. WebContents/TabContents/RenderViewHost/etc really shouldn't (and don't!) need to know anything about whether we're closing the browser or not. 
2. Refactor the handling of beforeunload/unload state in browser.cc. I think this makes it considerably easier to reason about the correctness of it.
3. Added a couple TODOs for future cleanups that would have made this change a bit too large.
------------------------------------------------------------------------
r272 | glen@google.com | 2008-08-02 02:44:22 +0200 (Sat, 02 Aug 2008) | 3 lines
Changed paths:
   A /trunk/src/chrome/app/theme/distributor_logo_light.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/test/accessibility/constants.h

Make our distributor logo light on XP (and leave it dark on Vista).

Also conveniently fixes accessibility test 'failures' introduced by the last distributor logo change.
------------------------------------------------------------------------
r270 | glen@google.com | 2008-08-02 01:38:52 +0200 (Sat, 02 Aug 2008) | 2 lines
Changed paths:
   A /trunk/src/chrome/app/theme/distributor_logo.png
   M /trunk/src/chrome/app/theme/theme_resources.h
   M /trunk/src/chrome/app/theme/theme_resources.rc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h

Add a non-interactive distributor logo to the window frame. This logo disappears in maximized view to avoid taking away from the tab strip.

------------------------------------------------------------------------
r267 | glen@google.com | 2008-08-02 00:32:50 +0200 (Sat, 02 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/native_ui_contents.h

Let the logo display correctly on the History and Downloads pages in RTL. This really should be using our GridLayout, but GridLayout had trouble both handling our row-spanned images, and cropping the image correctly when the column got too small (it center-cropped it). In the interests of not adding complication for Beta, I just modified the existing code.

BUG=1304459
------------------------------------------------------------------------
r261 | sgk@google.com | 2008-08-01 23:45:48 +0200 (Fri, 01 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/build/SConscript.main
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/test/chrome_plugin/SConscript
   M /trunk/src/chrome/test/security_tests/SConscript

SCons build:
* Add base\object{,_watcher}.cc.
* Add chrome\browser\bookmark_{codec,storage}.cc.
* Add chrome\views\frame\browser_window_factory.cc.
* Split of app\main.cc into app\chrome_{dll,exe}_main.cc, with added CPPDEFINES for {BROWSER,RENDERER,PLUGIN}_DLL.
* Move $CSCRIPT, $PLATFORMSDK* and $VISUAL_STUDIO variables to the win32-specific construction environment.
* Remove unnecessary comments.
TBR: bradnelson
------------------------------------------------------------------------
r258 | beng@google.com | 2008-08-01 22:42:27 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc

Automation provider should send real windows messages to the window when simulating drags, rather than ChromeViews events. Sending ChromeViews events directly to the RootView means that capture isn't set up properly and some state relating to dragging isn't saved on the frame.

B=1303306
------------------------------------------------------------------------
r253 | ojan@google.com | 2008-08-01 20:44:46 +0200 (Fri, 01 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Make closetabsopenedby walk the whole tabstrip instead of just all the tabs to the right of the tab whose context menu was used.
------------------------------------------------------------------------
r251 | timsteele@google.com | 2008-08-01 20:11:04 +0200 (Fri, 01 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/renderer/render_view.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/glue/webview_delegate.h

Fix DCHECK in history_backend by ensuring we clear redirect tracking state whenever the RenderView is told that a provisional load has started for the main frame.

The DCHECK(params->referrer == params->redirects[0]) was firing because:
a) page A was loaded, triggered WillPerformClientRedirect
b) after the provisional load started for the destination page of A's client redirect, but before this load was committed, the browser makes a Navigation request for page B.
c) When page B's load is committed, the RenderView's completed_client_redirect_src_ was still set, resulting in a CLIENT_REDIRECT transition type and forwarding the src value through params->referrer -- but params->redirects was now completely unrelated. Kaboom.

This fix should be general enough to handle cases (that are relatively likely in the wild) where WebKit legitimately cancels the redirect, instead of just the browser doing so. Note we can't depend on dispatchDidCancelClientRedirect because we get that callback on both completion and cancellation of a client redirect.
------------------------------------------------------------------------
r249 | pkasting@google.com | 2008-08-01 19:38:56 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/template_url.cc
   M /trunk/src/chrome/browser/template_url.h
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/template_url_model.h
   M /trunk/src/chrome/browser/template_url_model_unittest.cc
   M /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   M /trunk/src/chrome/browser/template_url_unittest.cc
   M /trunk/src/chrome/browser/webdata/web_database.cc
   M /trunk/src/chrome/browser/webdata/web_database.h
   M /trunk/src/chrome/browser/webdata/web_database_unittest.cc

Add the ability to dynamically generate keywords.  Mark the Google engine as needing this.  This ensures that users in countries where the Google base URL is not "google.com" will see the appropriate keyword for their local country (and can trigger it for tab-to-search, etc.).

BUG=1301290
------------------------------------------------------------------------
r248 | sky@google.com | 2008-08-01 19:36:48 +0200 (Fri, 01 Aug 2008) | 8 lines
Changed paths:
   M /trunk/src/chrome/browser/bookmark_bar_model.h
   M /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   A /trunk/src/chrome/browser/bookmark_codec.cc
   A /trunk/src/chrome/browser/bookmark_codec.h
   A /trunk/src/chrome/browser/bookmark_storage.cc
   A /trunk/src/chrome/browser/bookmark_storage.h

Adds a backend for the bookmarks bar that reads/writes to a JSON
file. These files aren't being built or used yet (though a test case
exists that is ifdef'd out).

BUG=1256202
TEST=none


------------------------------------------------------------------------
r245 | beng@google.com | 2008-08-01 19:05:27 +0200 (Fri, 01 Aug 2008) | 15 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/frame/browser_window_factory.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/views/toolbar_view.h
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h
   M /trunk/src/chrome/test/accessibility/accessibility_util.cc
   M /trunk/src/chrome/test/accessibility/accessibility_util.h
   M /trunk/src/chrome/test/accessibility/constants.h

Adds the BrowserView to the XPFrame/VistaFrame, and moves the BrowserToolbarView and StatusBubble into it.

Also restructures the creation of the Frame. This is significant! The Browser now constructs a frame via a new static BrowserWindow::CreateBrowserWindow method (see browser_window_factory.cc). Recall the diagram in the architectural overview doc - the BrowserView object is the one that implements the interface that the Browser object uses to communicate with the UI. The Browser object communicates to the BrowserView directly through this interface, but not directly to the frame.

What actually happens right now in CreateBrowserWindow is that an XP/VistaFrame is constructed, but this is _not_ the object returned to the Browser, rather when the XP/VistaFrame is init'ed, it constructs a BrowserView that also implements BrowserWindow. This is the object that's returned to the Browser.

Since both BrowserView and XP/VistaFrame implement BrowserWindow, I am now able to gradually migrate functionality from the frames to BrowserView. During this process BrowserWindow functions not handled yet by BrowserView will be forwarded to the appropriate frame.

Modifies the Accessibility UI tests to account for this extra level of indirection (should only be temporary while I'm moving things around).

This does actually pass the UI tests.

See the whiteboard in my office for a diagram. This is a bit confusing right now since there's so much going on. Sadly the only way to get where we need to go incrementally is to make a mess on the way.

B=1031854
------------------------------------------------------------------------
r238 | deanm@google.com | 2008-08-01 14:33:21 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/task_manager_resource_providers.h

Forward declare Task in ssl_manager.h.  Cleanup some uses of notification_service.h.

TBR=maruel
------------------------------------------------------------------------
r236 | deanm@google.com | 2008-08-01 10:22:15 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

Fix a bug introduced with the locking changes to login_prompt.cc :\

TBR=maruel
------------------------------------------------------------------------
r235 | deanm@google.com | 2008-08-01 09:52:03 +0200 (Fri, 01 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/login_prompt.cc

Remove atomic operations from login_prompt.cc.  Removes an atomic tess and set, and replaces it with a lock.  Rename confusing GotAuth test and set method to was WasAuthHandled, which will optionally marked as handled.
------------------------------------------------------------------------
r218 | pkasting@google.com | 2008-08-01 03:57:42 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/importer.cc

Pick the most commonly used search engine as the default when we have competing can-be-default choices with the same host and path.  Previously we would end up picking the least commonly used engine in this case.

BUG=1303406
------------------------------------------------------------------------
r217 | pkasting@google.com | 2008-08-01 03:48:35 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/search_provider.cc

Allow trailing commas in JSON responses from suggestion services.  Various real-world servers return responses like this and there's no obvious reason to disallow it, even though technically it violates the JSON spec.

BUG=1295216
------------------------------------------------------------------------
r216 | ojan@google.com | 2008-08-01 03:42:58 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Have CommandCloseTabsOpenedBy iterate through the tabs in reverse order to avoid race conditions with tab closing now that it's async.

BUG=1303289
------------------------------------------------------------------------
r214 | beng@google.com | 2008-08-01 02:31:26 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/frame/browser_view.cc
   M /trunk/src/chrome/browser/views/frame/browser_view.h

Make BrowserView implement the BrowserWindow interface so we  can start moving frame functionality into it.

B=1031854
------------------------------------------------------------------------
r213 | beng@google.com | 2008-08-01 02:26:18 +0200 (Fri, 01 Aug 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h

Move the BookmarkBarView into the frames.

Yes this causes duplicate code, but only for a brief while until I can bring up BrowserView at which point this code will move from the frames to that object. "It gets worse before it gets better".

B=1031854
------------------------------------------------------------------------
r212 | paulg@google.com | 2008-08-01 02:14:02 +0200 (Fri, 01 Aug 2008) | 16 lines
Changed paths:
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc

Eliminate the infinite read loop that can occasionally allow
a large, fast network request to monopolize the IO thread.

This particular bug was tickled by an FTP download where
pause tasks posted to the IO thread from the UI thread were
blocked from running until the FTP transfer was completed,
leading to user noticeable jankiness.

I added histograms to the previous read loop and noticed
that during regular browsing and downloading sessions, the
number of times the loop was traversed was 1 for something
like 99.5% of the time. This leads me to believe that
eliminating the read loop in favor of asynchronous tasks
will not impact performance.

BUG=1270179
------------------------------------------------------------------------
r210 | glen@google.com | 2008-08-01 01:58:32 +0200 (Fri, 01 Aug 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/simple_xp_frame.cc

Minor alignment tweaks to simple XP frame.
------------------------------------------------------------------------
r209 | glen@google.com | 2008-08-01 01:27:13 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/resources/new_tab.html

Stop the new tab page fading in if it's not your startup tab.

BUG=1295355
------------------------------------------------------------------------
r208 | erikkay@google.com | 2008-08-01 01:23:45 +0200 (Fri, 01 Aug 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_contents.cc
   M /trunk/src/chrome/common/chrome_switches.cc
   M /trunk/src/chrome/common/chrome_switches.h

Command-line flag to allow the debugger UI to be loaded from the filesystem rather than the DLL.  Very useful for rapid development.


------------------------------------------------------------------------
r205 | beng@google.com | 2008-08-01 00:41:28 +0200 (Fri, 01 Aug 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_window.h
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h

Move BrowserToolbarView to the frames (XPFrame/VistaFrame).

This causes some temporary duplication of code in xp/vista frames but it will be temporary. My goal is to move all the top level browser level views into the frames. From there, I will move them from the frames into their new home - BrowserView (chrome/browser/views/frames/browser_view.cc), and each frame will host a BrowserView. This will reduce duplication of code.

To make this change I had to add a bunch of methods to the BrowserWindow (nee ChromeFrame) interface to provide access to some of the toolbar's contents. Excuse the ugly API, we will be improving this incrementally.

B=1031854
------------------------------------------------------------------------
r199 | jcampan@google.com | 2008-07-31 23:15:45 +0200 (Thu, 31 Jul 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/ssl_uitest.cc

Updated the SSL UI test with the common name from the new cert.

BUG=1293555
TEST=Run the ssl ui tests.
------------------------------------------------------------------------
r197 | beng@google.com | 2008-07-31 23:02:22 +0200 (Thu, 31 Jul 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/navigation_controller_base.cc

Fix issue where debugger wasn't showing its contents.

Since the debugger window hosts a HWND, it should be initialized when the DebuggerView is inserted into the hierarchy, such that it gets sized properly. Also the DebuggerView needed to propagate changes to its own bounds into the inner view.

Also fixes a DCHECK in NavigationController that wasn't handling the existence of the debugger.

B=1302810
------------------------------------------------------------------------
r196 | sgk@google.com | 2008-07-31 22:58:34 +0200 (Thu, 31 Jul 2008) | 9 lines
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/debugger/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/views/SConscript

Fix SCons breakage, plus latest updates:
* Update src/DEPS to latest icu38 rev.
* Add new browser/views/frame/*.cc files.
* Add new browser/debugger/debugger_contents.cc file.
* Add new views/dialog_client_view.cc file.
* Build new browser/debugger/resources/debugger_resources.rc file.
* Add a new ChromeVersionRC() builder to the environment to provide a simpler, abstract interface for the four *version.rc files we build, with fixed definitions of $VERSION_BAT and $CHROME_SRC_DIR.
* Fix the definition of $HTML_INLINE.
R=deanm,bradnelson
------------------------------------------------------------------------
r193 | finnur@google.com | 2008-07-31 22:14:44 +0200 (Thu, 31 Jul 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/advanced_page_view.h
   M /trunk/src/chrome/browser/views/options/general_page_view.cc

Fix 1303177: Homepage field left enabled even though Reset to Default sets homepage to New Tab page.

The fix is to enable the textfield when the NewTabPageIsHomePage setting is changed. 

I also left out a change to the header guard from my last checkin (no code change). That's included in this changelist.

BUG=1303177
------------------------------------------------------------------------
r192 | darin@google.com | 2008-07-31 21:40:37 +0200 (Thu, 31 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   M /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h
   M /trunk/src/chrome/browser/back_forward_menu_model.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/browser_uitest.cc
   M /trunk/src/chrome/browser/browsing_data_remover.cc
   M /trunk/src/chrome/browser/cert_store.cc
   M /trunk/src/chrome/browser/cert_store.h
   M /trunk/src/chrome/browser/crash_recovery_uitest.cc
   M /trunk/src/chrome/browser/download_manager.cc
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/history/redirect_uitest.cc
   M /trunk/src/chrome/browser/iframe_uitest.cc
   M /trunk/src/chrome/browser/metrics_service_uitest.cc
   M /trunk/src/chrome/browser/net/dns_master_unittest.cc
   M /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/profile.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   M /trunk/src/chrome/browser/save_file_manager.cc
   M /trunk/src/chrome/browser/save_package.cc
   M /trunk/src/chrome/browser/session_history_uitest.cc
   M /trunk/src/chrome/browser/session_restore_uitest.cc
   M /trunk/src/chrome/browser/site_instance.cc
   M /trunk/src/chrome/browser/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl_error_info.h
   M /trunk/src/chrome/browser/ssl_manager.cc
   M /trunk/src/chrome/browser/ssl_manager.h
   M /trunk/src/chrome/browser/ssl_policy.cc
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_restore_uitest.cc
   M /trunk/src/chrome/browser/template_url_model.cc
   M /trunk/src/chrome/browser/toolbar_model.cc
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/chrome/browser/url_fixer_upper_unittest.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/common/gfx/url_elider.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.cc
   M /trunk/src/chrome/common/net/cookie_monster_sqlite.h
   M /trunk/src/chrome/common/net/url_request_intercept_job.cc
   M /trunk/src/chrome/common/os_exchange_data.cc
   M /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   M /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   M /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   M /trunk/src/chrome/test/plugin/plugin_test.cpp
   M /trunk/src/chrome/test/selenium/selenium_test.cc
   M /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   M /trunk/src/chrome/test/ui/layout_plugin_uitest.cpp
   M /trunk/src/chrome/test/ui/npapi_uitest.cpp
   M /trunk/src/net/base/cookie_monster.cc
   M /trunk/src/net/base/cookie_monster.h
   M /trunk/src/net/base/cookie_monster_perftest.cc
   M /trunk/src/net/base/cookie_monster_unittest.cc
   M /trunk/src/net/base/cookie_policy.cc
   M /trunk/src/net/base/cookie_policy.h
   M /trunk/src/net/base/cookie_policy_unittest.cc
   M /trunk/src/net/base/listen_socket_unittest.h
   M /trunk/src/net/base/net_module.cc
   M /trunk/src/net/base/net_module.h
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/base/net_util.h
   M /trunk/src/net/base/net_util_unittest.cc
   M /trunk/src/net/base/registry_controlled_domain.cc
   M /trunk/src/net/base/registry_controlled_domain.h
   M /trunk/src/net/base/registry_controlled_domain_unittest.cc
   M /trunk/src/net/base/winsock_init.cc
   M /trunk/src/net/base/winsock_init.h
   M /trunk/src/net/base/x509_certificate.cc
   M /trunk/src/net/base/x509_certificate.h
   M /trunk/src/net/http/http_transaction_winhttp.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_http_job.cc
   M /trunk/src/net/url_request/url_request_unittest.cc
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/dom_operations_unittest.cc
   M /trunk/src/webkit/glue/dom_serializer_unittest.cc
   M /trunk/src/webkit/glue/multipart_response_delegate.cc
   M /trunk/src/webkit/glue/resource_handle_win.cc
   M /trunk/src/webkit/tools/test_shell/plugin_tests.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_main.cc
   M /trunk/src/webkit/tools/test_shell/test_shell_request_context.cc

Move more net classes into the net namespace.  Also remove the net_util namespace in favor of the net namespace.

This is a purely mechanical change.  There should be no logic changes.
------------------------------------------------------------------------
r191 | finnur@google.com | 2008-07-31 20:49:32 +0200 (Thu, 31 Jul 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/google_update.cc
   M /trunk/src/chrome/browser/google_update.h

We were reporting Google Update errors as error:0, due to the fact that we were not catching the failure code from Google Update and reporting it. This is now fixed.

This is mentioned on the side in this bug (although this check-in does not fix this bug)

BUG=1302580
------------------------------------------------------------------------
r181 | maruel@google.com | 2008-07-31 18:36:21 +0200 (Thu, 31 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/visitedlink_master.cc

Simplifies the project configuration by setting the lib dependency in the source file.

BUG=1211534
------------------------------------------------------------------------
r180 | erikkay@google.com | 2008-07-31 18:25:09 +0200 (Thu, 31 Jul 2008) | 9 lines
Changed paths:
   M /trunk/src/chrome/app/chrome_dll.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_resources.h
   M /trunk/src/chrome/browser/browser_resources.rc
   M /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/debugger_contents.cc
   A /trunk/src/chrome/browser/debugger/debugger_contents.h
   M /trunk/src/chrome/browser/debugger/debugger_disabled.vcproj
   M /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.cc
   M /trunk/src/chrome/browser/debugger/debugger_shell.h
   M /trunk/src/chrome/browser/debugger/debugger_view.cc
   M /trunk/src/chrome/browser/debugger/debugger_view.h
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   A /trunk/src/chrome/browser/debugger/resources
   A /trunk/src/chrome/browser/debugger/resources/debugger.css
   A /trunk/src/chrome/browser/debugger/resources/debugger.html
   A /trunk/src/chrome/browser/debugger/resources/debugger.js
   A /trunk/src/chrome/browser/debugger/resources/debugger_resources.h
   A /trunk/src/chrome/browser/debugger/resources/debugger_resources.rc
   A /trunk/src/chrome/browser/debugger/resources/debugger_shell.js (from /trunk/src/chrome/browser/resources/debugger_shell.js:64)
   D /trunk/src/chrome/browser/resources/debugger_shell.js
   M /trunk/src/chrome/browser/tab_contents_factory.cc
   M /trunk/src/chrome/browser/tab_contents_type.h
   M /trunk/src/chrome/test/debugger/debugger_unittests.py

Initial cleanup and refactoring to make debugger UI use DHTML and get rid of the last of its native UI.  This is done using a DOMUIHost subclass and a new TabContents type.

This checkin also fixes a few minor issues:
* hitting the keyboard accelerator brings the current debugger window to front
* text is grayed out when in "running" mode rather than "paused"
* up/down arrows have command-line history (transient)
* some text used to get eaten when you first bring up the window ("attached to <tabname>"), this is now handled

 
------------------------------------------------------------------------
r174 | sgk@google.com | 2008-07-31 09:25:19 +0200 (Thu, 31 Jul 2008) | 12 lines
Changed paths:
   M /trunk/src/base/SConscript
   M /trunk/src/base/gfx/SConscript
   M /trunk/src/breakpad/SConscript
   M /trunk/src/build/SConscript.googleurl
   M /trunk/src/build/SConscript.main
   M /trunk/src/build/SConscript.v8
   M /trunk/src/chrome/SConscript
   M /trunk/src/chrome/SConscript.unit_tests
   M /trunk/src/chrome/app/theme/SConscript
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/chrome/browser/debugger/SConscript
   M /trunk/src/chrome/common/SConscript
   M /trunk/src/chrome/installer/mini_installer/SConscript
   M /trunk/src/chrome/installer/setup/SConscript
   M /trunk/src/chrome/installer/util/SConscript
   M /trunk/src/chrome/plugin/SConscript
   M /trunk/src/chrome/renderer/SConscript
   M /trunk/src/chrome/test/interactive_ui/SConscript
   M /trunk/src/chrome/test/mini_installer_test/SConscript
   M /trunk/src/chrome/test/page_cycler/SConscript
   M /trunk/src/chrome/test/plugin/SConscript
   M /trunk/src/chrome/test/reliability/SConscript
   M /trunk/src/chrome/test/selenium/SConscript
   M /trunk/src/chrome/test/startup/SConscript
   M /trunk/src/chrome/test/tab_switching/SConscript
   M /trunk/src/chrome/third_party/hunspell/SConscript
   M /trunk/src/chrome/third_party/sqlite/SConscript
   M /trunk/src/chrome/tools/test/image_diff/SConscript
   M /trunk/src/chrome/views/SConscript
   M /trunk/src/net/SConscript
   M /trunk/src/net/tools/tld_cleanup/SConscript
   M /trunk/src/sandbox/src/SConscript
   M /trunk/src/skia/SConscript
   M /trunk/src/third_party/bsdiff/SConscript
   M /trunk/src/third_party/bspatch/SConscript
   M /trunk/src/third_party/bzip2/SConscript
   M /trunk/src/third_party/libjpeg/SConscript
   M /trunk/src/third_party/libpng/SConscript
   M /trunk/src/third_party/libxml/SConscript
   M /trunk/src/third_party/libxslt/SConscript
   M /trunk/src/third_party/lzma_sdk/SConscript
   M /trunk/src/third_party/zlib/SConscript
   M /trunk/src/webkit/SConscript
   M /trunk/src/webkit/SConscript.javascriptcore_pcre
   M /trunk/src/webkit/SConscript.port
   M /trunk/src/webkit/activex_shim/SConscript
   M /trunk/src/webkit/build/JavaScriptCore/SConscript
   M /trunk/src/webkit/build/V8Bindings/SConscript
   M /trunk/src/webkit/build/WebCore/SConscript
   M /trunk/src/webkit/default_plugin/SConscript
   M /trunk/src/webkit/glue/SConscript
   M /trunk/src/webkit/glue/plugins/test/SConscript
   M /trunk/src/webkit/tools/npapi_layout_test_plugin/SConscript
   M /trunk/src/webkit/tools/test_shell/SConscript

Initial cleanups en route to coalescing the get-it-built cut-and-paste from various SConscripts into readable and maintainable shape.  To wit:
* Put the near-universal settings of /DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS, /DWIN32_LEAN_AND_MEAN, /wd4503 and /wd4819 in the base construction environment.
* Sort various unsorted source file lists.
* Fix indentation and quoting for consistency in a couple SConscript files that escaped previous dragnets.
* Eliminate two left-over uses of Split() for input file lists.
* Give the devenv invocation to build v8_shell.exe the full path to the relevant .vcproj file.
* Add /nologo to the base LINKFLAGS setting.
* Remove various CPPPATH and other settings that have been hanging around commented out from the Visual Studio build (in case we needed them, which we evidently don't).
* Get rid of unnecessary env.File() and env.Dir() calls in various settings (esp. CPPPATH) and source file lists.
* Add copyright notice to an overlooked SConscript file.
* Clean up version.bat invocation.
TBR: bradnelson
------------------------------------------------------------------------
r168 | beng@google.com | 2008-07-31 06:45:06 +0200 (Thu, 31 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/views/frame
   A /trunk/src/chrome/browser/views/frame/aero_glass_frame.cc
   A /trunk/src/chrome/browser/views/frame/aero_glass_frame.h
   A /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.cc
   A /trunk/src/chrome/browser/views/frame/aero_glass_non_client_view.h
   A /trunk/src/chrome/browser/views/frame/browser_frame.h
   A /trunk/src/chrome/browser/views/frame/browser_view.cc
   A /trunk/src/chrome/browser/views/frame/browser_view.h
   A /trunk/src/chrome/browser/views/frame/opaque_frame.cc
   A /trunk/src/chrome/browser/views/frame/opaque_frame.h
   A /trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc
   A /trunk/src/chrome/browser/views/frame/opaque_non_client_view.h

Stub out the files to be used for the new browser frame.

B=1031854
------------------------------------------------------------------------
r153 | beng@google.com | 2008-07-31 02:42:17 +0200 (Thu, 31 Jul 2008) | 11 lines
Changed paths:
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   A /trunk/src/chrome/views/dialog_client_view.cc (from /trunk/src/chrome/views/client_view.cc:97)
   A /trunk/src/chrome/views/dialog_client_view.h (from /trunk/src/chrome/views/client_view.h:97)
   M /trunk/src/chrome/views/dialog_delegate.h
   M /trunk/src/chrome/views/views.vcproj
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.h

Move dialog-specific aspects of ClientView into a new subclass DialogClientView.

ClientView becomes a generic representation of the View that occupies the "client area" of a window. All Windows now require a Client View (though they can use the default).

Adjust WindowDelegate to provide a method for constructing the ClientView for a Window. The DialogDelegate overrides this to construct the DialogClientView. In the future, other specialized delegates will construct ClientViews specific to them, e.g. WizardDelegate would construct WizardClientView.

Adjust the Window Init method to set up this new required Client View, and make some tweaks to CustomFrameWindow to make all this work.

Remove all traces of dialog specific handling in Window into DialogClientView.

B=1280060
------------------------------------------------------------------------
r152 | ojan@google.com | 2008-07-31 02:27:11 +0200 (Thu, 31 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc

Adds exitcodes for the TerminateProcess calls on hung renderers. There are still plenty of TerminateProcess(..., 0) calls, but these are the ones I know.
------------------------------------------------------------------------
r151 | brettw@google.com | 2008-07-31 01:50:22 +0200 (Thu, 31 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/net/base/data_url.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc

I looked at the full dump from the previous crashes and it looks like a testing issue. Hopefully it will be magically unbroken.
------------------------------------------------------------------------
r149 | rahulk@google.com | 2008-07-31 01:47:37 +0200 (Thu, 31 Jul 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/app/google_update_settings.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_main.cc
   M /trunk/src/chrome/browser/views/options/advanced_contents_view.cc

At the first run use Omaha usagestats key to determine whether to collect user metrics.

BUG=1299579
TEST=With clean profile and no "first run" file, start Chrome and make sure that Under the Hood->Help make Chrome better... option is checked or unchecked depending on whether the value of HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}\usagestats key is 1 or 0. 


------------------------------------------------------------------------
r144 | sky@google.com | 2008-07-31 01:04:17 +0200 (Thu, 31 Jul 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/history/history_database.h

Removes a method never implemented in HistoryDB.

BUG=none
TEST=none; this is just cleanup


------------------------------------------------------------------------
r143 | glen@google.com | 2008-07-31 00:44:50 +0200 (Thu, 31 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/tab_contents.cc
   M /trunk/src/chrome/browser/tab_contents_delegate.h
   M /trunk/src/chrome/browser/views/download_shelf_view.cc

Make the download arrow show and hide correctly in response to shelf visibility. This was caused by both the shelf_visible_ bool not being set by the download shelf correctly, and the tab renderer not being aware of the new state.

BUG=1300997
------------------------------------------------------------------------
r142 | pkasting@google.com | 2008-07-31 00:40:08 +0200 (Thu, 31 Jul 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_commands.cc

Simple change to make the "New [incognito] window" commands work like you'd expect.

The old behavior disabled "New incognito window" when in incognito windows, created a new incognito tab instead of a new window when you already had an incognito window open, and gave you no way to get a non-incognito window from an incognito one.

Now, both commands are always enabled, and both do exactly what they say they'll do no matter what type of window you're currently in.

BUG=1190035
------------------------------------------------------------------------
r141 | beng@google.com | 2008-07-31 00:30:22 +0200 (Thu, 31 Jul 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   A /trunk/src/chrome/views/non_client_view.cc
   A /trunk/src/chrome/views/non_client_view.h
   M /trunk/src/chrome/views/views.vcproj

Make NonClientView an interface independent of CustomFrameWindow (i.e. move it into its own file).

Rename NonClientView's HitTest method to NonClientHitTest, so it doesn't collide with View's HitTest method.

Also, consolidate some duplicated code between CustomFrameWindow and ConstrainedWindow's non-client view impl.

B=1300864
------------------------------------------------------------------------
r139 | stanguturi@google.com | 2008-07-31 00:05:33 +0200 (Thu, 31 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.h

Made changes to display tooltip window when user navigates through the icons in the toolbar using keyboard arrow keys.

I have already fixed this issue. (Issue:801). I have got LGTM also. But, I have checked in the code when tree was closed. So, all my changes were reverted. So, this new issue is created to upload the same changes.
------------------------------------------------------------------------
r135 | sgk@google.com | 2008-07-30 22:21:24 +0200 (Wed, 30 Jul 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/SConscript
   M /trunk/src/net/SConscript
   M /trunk/src/sandbox/src/SConscript
   M /trunk/src/webkit/build/port/SConscript

Update SCons build for recent changes:
Delete chrome_frame.cc, add frame_util.cc.
url_request_http_cache_job.cc => url_request_http_job.cc.
Rename sandbox *tests.exe to sbox_*.exe per upstream.
Define ENABLE_CROSS_DOCUMENT_MESSAGING when generating V8 bindings.
TBR: bradnelson
------------------------------------------------------------------------
r128 | sidchat@google.com | 2008-07-30 20:48:31 +0200 (Wed, 30 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc

Insert a comma


------------------------------------------------------------------------
r119 | jcampan@google.com | 2008-07-30 19:29:22 +0200 (Wed, 30 Jul 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/views/info_bar_view.cc

Make sure we remove info-bars on reload.

BUG=1296826
TEST=See bug
------------------------------------------------------------------------
r116 | darin@google.com | 2008-07-30 18:40:10 +0200 (Wed, 30 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/download_manager.cc
   M /trunk/src/chrome/browser/firefox2_importer.cc
   M /trunk/src/chrome/browser/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/gears_integration.cc
   M /trunk/src/chrome/browser/login_prompt.cc
   M /trunk/src/chrome/browser/login_prompt.h
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/plugin_process_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.cc
   M /trunk/src/chrome/browser/resource_dispatcher_host.h
   M /trunk/src/chrome/browser/resource_message_filter.cc
   M /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/web_app.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/renderer/renderer_glue.cc
   M /trunk/src/net/base/auth.h
   M /trunk/src/net/base/auth_cache.cc
   M /trunk/src/net/base/auth_cache.h
   M /trunk/src/net/base/auth_cache_unittest.cc
   M /trunk/src/net/base/base64.cc
   M /trunk/src/net/base/base64.h
   M /trunk/src/net/base/base64_unittest.cc
   M /trunk/src/net/base/data_url.cc
   M /trunk/src/net/base/data_url.h
   M /trunk/src/net/base/data_url_unittest.cc
   M /trunk/src/net/base/directory_lister.cc
   M /trunk/src/net/base/directory_lister.h
   M /trunk/src/net/base/directory_lister_unittest.cc
   M /trunk/src/net/base/dns_resolution_observer.cc
   M /trunk/src/net/base/dns_resolution_observer.h
   M /trunk/src/net/base/mime_sniffer.cc
   M /trunk/src/net/base/mime_sniffer.h
   M /trunk/src/net/base/mime_sniffer_unittest.cc
   M /trunk/src/net/base/mime_util.cc
   M /trunk/src/net/base/mime_util.h
   M /trunk/src/net/base/mime_util_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_transaction_factory.h
   M /trunk/src/net/http/http_transaction_unittest.h
   M /trunk/src/net/url_request/mime_sniffer_proxy.cc
   M /trunk/src/net/url_request/mime_sniffer_proxy.h
   M /trunk/src/net/url_request/url_request.h
   M /trunk/src/net/url_request/url_request_context.h
   M /trunk/src/net/url_request/url_request_file_dir_job.cc
   M /trunk/src/net/url_request/url_request_file_dir_job.h
   M /trunk/src/net/url_request/url_request_file_job.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc
   M /trunk/src/net/url_request/url_request_ftp_job.h
   M /trunk/src/net/url_request/url_request_http_cache_job.cc
   M /trunk/src/net/url_request/url_request_http_cache_job.h
   M /trunk/src/net/url_request/url_request_inet_job.cc
   M /trunk/src/net/url_request/url_request_inet_job.h
   M /trunk/src/net/url_request/url_request_job.cc
   M /trunk/src/net/url_request/url_request_job.h
   M /trunk/src/net/url_request/url_request_unittest.h
   M /trunk/src/webkit/glue/plugins/plugin_lib.cc
   M /trunk/src/webkit/glue/resource_handle_win.cc
   M /trunk/src/webkit/glue/webframeloaderclient_impl.cc
   M /trunk/src/webkit/port/bridge/PluginsWin.cpp
   M /trunk/src/webkit/port/platform/MIMETypeRegistry.cpp
   M /trunk/src/webkit/tools/test_shell/test_shell.cc

Move some more classes from net/base into the net:: namespace.
------------------------------------------------------------------------
r114 | evanm@google.com | 2008-07-30 18:05:48 +0200 (Wed, 30 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/metrics_log.cc

Send the "shutdown didn't get to finish" metric to UMA.
------------------------------------------------------------------------
r107 | finnur@google.com | 2008-07-30 07:58:17 +0200 (Wed, 30 Jul 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_init.cc
   M /trunk/src/chrome/browser/importer.cc
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.cc
   M /trunk/src/chrome/browser/views/options/general_page_view.h
   M /trunk/src/chrome/common/pref_names.cc
   M /trunk/src/chrome/common/pref_names.h

Fix 1295677: REGRESSION: Import SETS startup page to imported home page.

We had only kHomePage pref before, which if blank/set to chrome-internal: meant that the New Tab page should be shown when Home is pressed. Now we add a pref called kHomePageIsNewTabPage for this purpose, which allows us to set the kHomePage value during import without actually using it as the HomePage (effectively importing home page becomes importing a default suggestion for when the users want a home page instead of the New Tab page).

BUG=1295677

------------------------------------------------------------------------
r105 | beng@google.com | 2008-07-30 07:43:17 +0200 (Wed, 30 Jul 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/find_in_page_controller.cc
   M /trunk/src/chrome/browser/native_ui_contents.cc
   M /trunk/src/chrome/browser/network_status_view.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_view.cc
   M /trunk/src/chrome/browser/tabs/hwnd_photobooth.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/views/download_started_animation.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/chrome/views/chrome_menu.cc
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/hwnd_view_container.cc
   M /trunk/src/chrome/views/hwnd_view_container.h
   M /trunk/src/chrome/views/tabbed_pane.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window.cc

Make HWNDViewContainer set up its contents view separately from its Init method.
This is needed as a first step in further adjustments I'm going to be making to
Window, ClientView, etc.

B=1280060
------------------------------------------------------------------------
r102 | beng@google.com | 2008-07-30 06:48:39 +0200 (Wed, 30 Jul 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/automation/automation_provider.cc
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/browser.vcproj
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/browser_list.cc
   A /trunk/src/chrome/browser/browser_window.h (from /trunk/src/chrome/browser/chrome_frame.h:27)
   D /trunk/src/chrome/browser/chrome_frame.cc
   D /trunk/src/chrome/browser/chrome_frame.h
   A /trunk/src/chrome/browser/frame_util.cc (from /trunk/src/chrome/browser/chrome_frame.cc:27)
   A /trunk/src/chrome/browser/frame_util.h
   M /trunk/src/chrome/browser/frame_view.cc
   M /trunk/src/chrome/browser/frame_view.h
   M /trunk/src/chrome/browser/session_service.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   M /trunk/src/chrome/browser/views/first_run_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.cc
   M /trunk/src/chrome/browser/views/info_bubble.h
   M /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/browser/vista_frame.cc
   M /trunk/src/chrome/browser/vista_frame.h
   M /trunk/src/chrome/browser/window_sizer.cc
   M /trunk/src/chrome/browser/xp_frame.cc
   M /trunk/src/chrome/browser/xp_frame.h

Rename ChromeFrame->BrowserWindow
Move static utility functions to FrameUtil class.

B=1294302

------------------------------------------------------------------------
r97 | beng@google.com | 2008-07-30 06:18:32 +0200 (Wed, 30 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/debugger/debugger_window.h
   M /trunk/src/chrome/browser/login_prompt.cc

forgot these files
------------------------------------------------------------------------
r96 | beng@google.com | 2008-07-30 06:12:18 +0200 (Wed, 30 Jul 2008) | 19 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser_commands.cc
   M /trunk/src/chrome/browser/debugger/debugger_window.cc
   M /trunk/src/chrome/browser/external_protocol_dialog.cc
   M /trunk/src/chrome/browser/external_protocol_dialog.h
   M /trunk/src/chrome/browser/first_run.cc
   M /trunk/src/chrome/browser/importer.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.cc
   M /trunk/src/chrome/browser/jsmessage_box_handler.h
   M /trunk/src/chrome/browser/page_info_window.cc
   M /trunk/src/chrome/browser/page_info_window.h
   M /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   M /trunk/src/chrome/browser/repost_form_warning_dialog.h
   M /trunk/src/chrome/browser/task_manager.cc
   M /trunk/src/chrome/browser/task_manager.h
   M /trunk/src/chrome/browser/user_data_dir_dialog.cc
   M /trunk/src/chrome/browser/user_data_dir_dialog.h
   M /trunk/src/chrome/browser/views/about_chrome_view.cc
   M /trunk/src/chrome/browser/views/about_chrome_view.h
   M /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   M /trunk/src/chrome/browser/views/bookmark_editor_view.h
   M /trunk/src/chrome/browser/views/bug_report_view.cc
   M /trunk/src/chrome/browser/views/bug_report_view.h
   M /trunk/src/chrome/browser/views/clear_browsing_data.cc
   M /trunk/src/chrome/browser/views/clear_browsing_data.h
   M /trunk/src/chrome/browser/views/constrained_window_impl.cc
   M /trunk/src/chrome/browser/views/constrained_window_impl.h
   M /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   M /trunk/src/chrome/browser/views/edit_keyword_controller.h
   M /trunk/src/chrome/browser/views/first_run_customize_view.cc
   M /trunk/src/chrome/browser/views/first_run_customize_view.h
   M /trunk/src/chrome/browser/views/first_run_view.cc
   M /trunk/src/chrome/browser/views/first_run_view.h
   M /trunk/src/chrome/browser/views/first_run_view_base.cc
   M /trunk/src/chrome/browser/views/first_run_view_base.h
   M /trunk/src/chrome/browser/views/html_dialog_view.cc
   M /trunk/src/chrome/browser/views/html_dialog_view.h
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.cc
   M /trunk/src/chrome/browser/views/importer_lock_view.h
   M /trunk/src/chrome/browser/views/importer_view.cc
   M /trunk/src/chrome/browser/views/importer_view.h
   M /trunk/src/chrome/browser/views/importing_progress_view.cc
   M /trunk/src/chrome/browser/views/importing_progress_view.h
   M /trunk/src/chrome/browser/views/input_window.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.cc
   M /trunk/src/chrome/browser/views/keyword_editor_view.h
   M /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   M /trunk/src/chrome/browser/views/options/content_page_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.cc
   M /trunk/src/chrome/browser/views/options/cookies_view.h
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   M /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   M /trunk/src/chrome/browser/views/options/languages_page_view.cc
   M /trunk/src/chrome/browser/views/options/options_window_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.cc
   M /trunk/src/chrome/browser/views/password_manager_view.h
   M /trunk/src/chrome/browser/views/restart_message_box.cc
   M /trunk/src/chrome/browser/views/restart_message_box.h
   M /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   M /trunk/src/chrome/browser/views/shelf_item_dialog.h
   M /trunk/src/chrome/views/client_view.cc
   M /trunk/src/chrome/views/custom_frame_window.cc
   M /trunk/src/chrome/views/custom_frame_window.h
   M /trunk/src/chrome/views/focus_manager_unittest.cc
   M /trunk/src/chrome/views/view_unittest.cc
   M /trunk/src/chrome/views/window.cc
   M /trunk/src/chrome/views/window.h
   M /trunk/src/chrome/views/window_delegate.h

Window Delegate Improvements:

- Windows now must have a Delegate. Just construct the default WindowDelegate
if
you don't want to have to write one in testing.
- Windows now obtain their contents view by asking the delegate via
WindowDelegate::GetContentsView.
- Contents views no longer need to manually store a pointer to the Window that
contains them, WindowDelegate does this automatically via its window()
accessor.

Reviewer notes:
- review window_delegate.h first, then
- window.h/cc
- custom frame window.h/cc
- constrained_window_impl.h/cc
- then everything else (just updating all call sites)

B=1280060
------------------------------------------------------------------------
r90 | beng@google.com | 2008-07-30 03:32:58 +0200 (Wed, 30 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc

Fix one more glitch when drag-attaching a tab to the tabstrip. Other tabs in the strip were instantly sized to their start size for the insert tab animation (which is their current size) but this calculation didn't take into account the fact that a newly inserted tab has a minimum size so their initial size isn't just the width / n other tabs, it's (width / n other tabs) - (min width / n other tabs)

B=1285677
------------------------------------------------------------------------
r85 | ojan@google.com | 2008-07-30 02:58:03 +0200 (Wed, 30 Jul 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents_unittest.cc

Fix broken unittest. AttemptToClosePage now sets up state.
Do the same in the overridden method in TestRenderViewHost.

TBR=abarth

------------------------------------------------------------------------
r84 | beng@google.com | 2008-07-30 02:41:08 +0200 (Wed, 30 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip.cc

Fix a crash. Now sometimes TabContentses can be NULL it seems.

B=1297990
------------------------------------------------------------------------
r83 | beng@google.com | 2008-07-30 02:41:01 +0200 (Wed, 30 Jul 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

I screwed this one up, and had my index munging wrong.

This is actually a much simpler approach. Get the TabContents that the context menu was brought up for and reverse walk the list closing all Tabs that don't match. Duh.

B=1298878
------------------------------------------------------------------------
r82 | ojan@google.com | 2008-07-30 01:47:55 +0200 (Wed, 30 Jul 2008) | 2 lines
Changed paths:
   M /trunk/src/chrome/browser/render_view_host.cc

Fix hang detection when closing a tab to not fire when a modal dialog is open.

------------------------------------------------------------------------
r81 | ojan@google.com | 2008-07-30 01:32:47 +0200 (Wed, 30 Jul 2008) | 3 lines
Changed paths:
   M /trunk/src/chrome/browser/browser.cc
   M /trunk/src/chrome/browser/browser.h
   M /trunk/src/chrome/browser/render_process_host.cc
   M /trunk/src/chrome/browser/render_process_host.h
   M /trunk/src/chrome/browser/render_view_host.cc
   M /trunk/src/chrome/browser/render_view_host.h
   M /trunk/src/chrome/browser/render_widget_helper.cc
   M /trunk/src/chrome/browser/render_widget_helper.h
   M /trunk/src/chrome/browser/render_widget_host.cc
   M /trunk/src/chrome/browser/render_widget_host.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/views/hung_renderer_view.cc
   M /trunk/src/chrome/browser/web_contents.cc

Fix not closing the browser with hung, crashed and interstitial tabs. Adds a 1 second hang monitor for the beforeunload/unload events to fire.

BUG=1296059
------------------------------------------------------------------------
r74 | nsylvain@google.com | 2008-07-29 23:54:26 +0200 (Tue, 29 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.h

Revert revision 73 because it was checked in when the tree was closed.
------------------------------------------------------------------------
r73 | stanguturi@google.com | 2008-07-29 23:45:28 +0200 (Tue, 29 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/views/toolbar_view.cc
   M /trunk/src/chrome/views/aero_tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.cc
   M /trunk/src/chrome/views/tooltip_manager.h

Made changes to display the tooltip window when user navigates through the icons in the toolbar using keyboard arrow keys.
------------------------------------------------------------------------
r71 | nsylvain@google.com | 2008-07-29 22:57:35 +0200 (Tue, 29 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/DEPS
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/chrome/browser/web_contents.cc
   M /trunk/src/net/base/data_url.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/http/http_proxy_service.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc

Reverting revision 70, 66 and 65 to fix crashes.
------------------------------------------------------------------------
r68 | evanm@google.com | 2008-07-29 19:33:56 +0200 (Tue, 29 Jul 2008) | 6 lines
Changed paths:
   M /trunk/src/chrome/browser/resources/new_tab.html

Make the new tab thumbnail slighly less confusing -- laid out properly,
but unclickable -- when something goes wrong and the page is fed garbage
input.  (I don't expect new users will ever see this, but migration bugs
in previous versions have made this a recurring problem.)


------------------------------------------------------------------------
r66 | brettw@google.com | 2008-07-29 18:36:36 +0200 (Tue, 29 Jul 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/url_fixer_upper.cc
   M /trunk/src/net/base/data_url.cc
   M /trunk/src/net/base/escape.cc
   M /trunk/src/net/base/escape.h
   M /trunk/src/net/base/escape_unittest.cc
   M /trunk/src/net/base/net_util.cc
   M /trunk/src/net/url_request/url_request_ftp_job.cc

Puts back the optional unescaping of control characters and URL parse-affecting characters. That patch was reverted due to build problems.

This is heavily modified from the original patch. That patch required an additional function and a bunch of internal boolean flags. This one uses the new flags enum I wrote to add this to the existing functionality more cleanly.

BUG=1271340
BUG=1258819
Review URL: http://chrome-reviews.prom.corp.google.com/804
------------------------------------------------------------------------
r65 | creis@google.com | 2008-07-29 18:35:45 +0200 (Tue, 29 Jul 2008) | 4 lines
Changed paths:
   M /trunk/src/chrome/browser/web_contents.cc

Makes the process model heuristic for generated searches only apply in --process-per-site, since it isn't relevant otherwise.  (This matters now that process-per-site-instance is the default.)

BUG=1256259
TEST=Visit a non-Google page, then run a search from the location bar.  The tab should switch renderer processes.
------------------------------------------------------------------------
r63 | beng@google.com | 2008-07-29 07:52:57 +0200 (Tue, 29 Jul 2008) | 5 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   M /trunk/src/chrome/browser/tabs/tab_strip_model.h

Add a return value to InternalCloseTabContentsAt, indicating whether or not the TabContents was closed immediately or if we're waiting for an unload handler to fire.

Adjust indices in Close other tabs handler to take into account the fact that some tabs may not close immediately

B=1295790
------------------------------------------------------------------------
r57 | beng@google.com | 2008-07-29 05:00:37 +0200 (Tue, 29 Jul 2008) | 7 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   M /trunk/src/chrome/browser/tabs/tab_strip.cc
   M /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model.cc

Ugh. It turns out we were never properly removing the dragged tab from the source tabstrip when a drag was completed. This was causing various problems, which were highlighted when you reverted a drag (e.g. press esc or alt+tab while dragging).

See my comments inline in the diff for explanations.

This manifests as Venkat's latest repro in:

B=1262392
------------------------------------------------------------------------
r56 | pkasting@google.com | 2008-07-29 02:46:48 +0200 (Tue, 29 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/google_url_tracker_unittest.cc

Save a few lines since I don't need a test fixture.  This was just silly oversight on my part due to not having written a new unittest in a while.
------------------------------------------------------------------------
r54 | tc@google.com | 2008-07-29 02:28:30 +0200 (Tue, 29 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc

Fix the build.  I meant to include this in the chrome side of the previous change.
------------------------------------------------------------------------
r47 | timsteele@google.com | 2008-07-29 00:51:47 +0200 (Tue, 29 Jul 2008) | 2 lines
Changed paths:
   D /trunk/src/chrome/browser/avatar

Delete empty, unused avatar folder.

------------------------------------------------------------------------
r36 | deanm@google.com | 2008-07-28 20:47:39 +0200 (Mon, 28 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   M /trunk/src/chrome/browser/encryptor.h
   M /trunk/src/chrome/browser/tabs/tab.h
   M /trunk/src/chrome/browser/tabs/tab_renderer.h
   M /trunk/src/chrome/browser/tabs/tab_strip.h
   M /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   M /trunk/src/chrome/browser/web_app_launcher.h
   M /trunk/src/chrome/views/tree_view.h

Fix a few incorrect #endif's in include guards.
------------------------------------------------------------------------
r35 | beng@google.com | 2008-07-28 18:36:13 +0200 (Mon, 28 Jul 2008) | 12 lines
Changed paths:
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   M /trunk/src/chrome/browser/tabs/dragged_tab_controller.h

Fix some glitches dragging tabs.

- Fix what looks like an off-by-one in tab attaching (line 504 in diff)
- Ensure ideal bounds are appropriately generated for dragging so that insertion
index calculations work properly (line 452, 492)
- Provide a threshold so that when dragging left and right a tab must be
displaced by at least threshold before tabs are reordered again to prevent
jittering. Default threshold is 16px for standard sized tabs, scaled down in the
ratio of the unselected current tab size to the standard size depending on the
number of tabs open.

B=1285677
------------------------------------------------------------------------
r34 | nsylvain@google.com | 2008-07-28 17:45:13 +0200 (Mon, 28 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/metrics_log_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.h

Fix compile errors due to missing includes.
------------------------------------------------------------------------
r33 | deanm@google.com | 2008-07-28 16:49:35 +0200 (Mon, 28 Jul 2008) | 1 line
Changed paths:
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.cc
   M /trunk/src/chrome/browser/automation/url_request_failed_dns_job.h
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   M /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   M /trunk/src/chrome/browser/download_file.cc
   M /trunk/src/chrome/browser/download_file.h
   M /trunk/src/chrome/browser/download_manager.cc
   M /trunk/src/chrome/browser/download_manager.h
   M /trunk/src/chrome/browser/external_protocol_handler.cc
   M /trunk/src/chrome/browser/external_protocol_handler.h
   M /trunk/src/chrome/browser/firefox_importer_utils.cc
   M /trunk/src/chrome/browser/firefox_importer_utils.h
   M /trunk/src/chrome/browser/google_util.cc
   M /trunk/src/chrome/browser/google_util.h
   M /trunk/src/chrome/browser/history/history_database.h
   M /trunk/src/chrome/browser/metrics_log.cc
   M /trunk/src/chrome/browser/metrics_log.h
   M /trunk/src/chrome/browser/printing/print_job_worker.h
   M /trunk/src/chrome/browser/renderer_security_policy.cc
   M /trunk/src/chrome/browser/renderer_security_policy.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   M /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   M /trunk/src/chrome/browser/save_file_manager.cc
   M /trunk/src/chrome/browser/save_file_manager.h
   M /trunk/src/chrome/browser/ssl_error_info.cc
   M /trunk/src/chrome/browser/ssl_error_info.h
   M /trunk/src/chrome/browser/views/status_bubble.cc
   M /trunk/src/chrome/browser/views/status_bubble.h
   M /trunk/src/chrome/common/gfx/url_elider.cc
   M /trunk/src/chrome/common/gfx/url_elider.h
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.cc
   M /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.h
   M /trunk/src/chrome/test/ui/ui_test.cc
   M /trunk/src/chrome/test/ui/ui_test.h
   M /trunk/src/chrome/views/tooltip_manager.h

Try to cut down on some unnecessary dependencies.  Remove any unused includes of gurl.h in header files, and forward declare GURL where possible.
------------------------------------------------------------------------
r15 | initial.commit | 2008-07-27 01:55:29 +0200 (Sun, 27 Jul 2008) | 2 lines
Changed paths:
   A /trunk/src/chrome
   A /trunk/src/chrome/AUTHORS
   A /trunk/src/chrome/BRANDING
   A /trunk/src/chrome/SConscript
   A /trunk/src/chrome/SConscript.automated_ui_tests
   A /trunk/src/chrome/SConscript.ui_tests
   A /trunk/src/chrome/SConscript.unit_tests
   A /trunk/src/chrome/SConstruct
   A /trunk/src/chrome/VERSION
   A /trunk/src/chrome/app
   A /trunk/src/chrome/app/FirstRun
   A /trunk/src/chrome/app/breakpad.cc
   A /trunk/src/chrome/app/breakpad.h
   A /trunk/src/chrome/app/check_dependents.bat
   A /trunk/src/chrome/app/chrome.dll.deps
   A /trunk/src/chrome/app/chrome.exe.deps
   A /trunk/src/chrome/app/chrome_dll.rc
   A /trunk/src/chrome/app/chrome_dll.vcproj
   A /trunk/src/chrome/app/chrome_dll.vsprops
   A /trunk/src/chrome/app/chrome_dll_resource.h
   A /trunk/src/chrome/app/chrome_dll_version.rc.version
   A /trunk/src/chrome/app/chrome_exe.rc
   A /trunk/src/chrome/app/chrome_exe.vcproj
   A /trunk/src/chrome/app/chrome_exe.vsprops
   A /trunk/src/chrome/app/chrome_exe_resource.h
   A /trunk/src/chrome/app/chrome_exe_version.rc.version
   A /trunk/src/chrome/app/chrome_link.vsprops
   A /trunk/src/chrome/app/chrome_main.cc
   A /trunk/src/chrome/app/chrome_main_uitest.cc
   A /trunk/src/chrome/app/generated_resources.grd
   A /trunk/src/chrome/app/generated_resources.vcproj
   A /trunk/src/chrome/app/google_update_client.cc
   A /trunk/src/chrome/app/google_update_client.h
   A /trunk/src/chrome/app/google_update_settings.cc
   A /trunk/src/chrome/app/google_update_settings.h
   A /trunk/src/chrome/app/locales
   A /trunk/src/chrome/app/locales/ar.vcproj
   A /trunk/src/chrome/app/locales/bg.vcproj
   A /trunk/src/chrome/app/locales/ca.vcproj
   A /trunk/src/chrome/app/locales/cs.vcproj
   A /trunk/src/chrome/app/locales/da.vcproj
   A /trunk/src/chrome/app/locales/de.vcproj
   A /trunk/src/chrome/app/locales/el.vcproj
   A /trunk/src/chrome/app/locales/en-GB.vcproj
   A /trunk/src/chrome/app/locales/en-US.vcproj
   A /trunk/src/chrome/app/locales/es-419.vcproj
   A /trunk/src/chrome/app/locales/es.vcproj
   A /trunk/src/chrome/app/locales/et.vcproj
   A /trunk/src/chrome/app/locales/fi.vcproj
   A /trunk/src/chrome/app/locales/fil.vcproj
   A /trunk/src/chrome/app/locales/fr.vcproj
   A /trunk/src/chrome/app/locales/he.vcproj
   A /trunk/src/chrome/app/locales/hi.vcproj
   A /trunk/src/chrome/app/locales/hr.vcproj
   A /trunk/src/chrome/app/locales/hu.vcproj
   A /trunk/src/chrome/app/locales/id.vcproj
   A /trunk/src/chrome/app/locales/it.vcproj
   A /trunk/src/chrome/app/locales/ja.vcproj
   A /trunk/src/chrome/app/locales/ko.vcproj
   A /trunk/src/chrome/app/locales/locale_settings.h
   A /trunk/src/chrome/app/locales/lt.vcproj
   A /trunk/src/chrome/app/locales/lv.vcproj
   A /trunk/src/chrome/app/locales/nb.vcproj
   A /trunk/src/chrome/app/locales/nl.vcproj
   A /trunk/src/chrome/app/locales/pl.vcproj
   A /trunk/src/chrome/app/locales/pt-BR.vcproj
   A /trunk/src/chrome/app/locales/pt-PT.vcproj
   A /trunk/src/chrome/app/locales/ro.vcproj
   A /trunk/src/chrome/app/locales/ru.vcproj
   A /trunk/src/chrome/app/locales/sk.vcproj
   A /trunk/src/chrome/app/locales/sl.vcproj
   A /trunk/src/chrome/app/locales/sr.vcproj
   A /trunk/src/chrome/app/locales/sv.vcproj
   A /trunk/src/chrome/app/locales/th.vcproj
   A /trunk/src/chrome/app/locales/tr.vcproj
   A /trunk/src/chrome/app/locales/uk.vcproj
   A /trunk/src/chrome/app/locales/vi.vcproj
   A /trunk/src/chrome/app/locales/zh-CN.vcproj
   A /trunk/src/chrome/app/locales/zh-TW.vcproj
   A /trunk/src/chrome/app/main.cc
   A /trunk/src/chrome/app/resources
   A /trunk/src/chrome/app/resources/SConscript
   A /trunk/src/chrome/app/resources/chrome.ico
   A /trunk/src/chrome/app/resources/generated_resources_ar.xtb
   A /trunk/src/chrome/app/resources/generated_resources_bg.xtb
   A /trunk/src/chrome/app/resources/generated_resources_ca.xtb
   A /trunk/src/chrome/app/resources/generated_resources_cs.xtb
   A /trunk/src/chrome/app/resources/generated_resources_da.xtb
   A /trunk/src/chrome/app/resources/generated_resources_de.xtb
   A /trunk/src/chrome/app/resources/generated_resources_el.xtb
   A /trunk/src/chrome/app/resources/generated_resources_en-GB.xtb
   A /trunk/src/chrome/app/resources/generated_resources_es-419.xtb
   A /trunk/src/chrome/app/resources/generated_resources_es.xtb
   A /trunk/src/chrome/app/resources/generated_resources_et.xtb
   A /trunk/src/chrome/app/resources/generated_resources_fi.xtb
   A /trunk/src/chrome/app/resources/generated_resources_fil.xtb
   A /trunk/src/chrome/app/resources/generated_resources_fr.xtb
   A /trunk/src/chrome/app/resources/generated_resources_he.xtb
   A /trunk/src/chrome/app/resources/generated_resources_hi.xtb
   A /trunk/src/chrome/app/resources/generated_resources_hr.xtb
   A /trunk/src/chrome/app/resources/generated_resources_hu.xtb
   A /trunk/src/chrome/app/resources/generated_resources_id.xtb
   A /trunk/src/chrome/app/resources/generated_resources_it.xtb
   A /trunk/src/chrome/app/resources/generated_resources_ja.xtb
   A /trunk/src/chrome/app/resources/generated_resources_ko.xtb
   A /trunk/src/chrome/app/resources/generated_resources_lt.xtb
   A /trunk/src/chrome/app/resources/generated_resources_lv.xtb
   A /trunk/src/chrome/app/resources/generated_resources_nl.xtb
   A /trunk/src/chrome/app/resources/generated_resources_no.xtb
   A /trunk/src/chrome/app/resources/generated_resources_pl.xtb
   A /trunk/src/chrome/app/resources/generated_resources_pt-BR.xtb
   A /trunk/src/chrome/app/resources/generated_resources_pt-PT.xtb
   A /trunk/src/chrome/app/resources/generated_resources_ro.xtb
   A /trunk/src/chrome/app/resources/generated_resources_ru.xtb
   A /trunk/src/chrome/app/resources/generated_resources_sk.xtb
   A /trunk/src/chrome/app/resources/generated_resources_sl.xtb
   A /trunk/src/chrome/app/resources/generated_resources_sr.xtb
   A /trunk/src/chrome/app/resources/generated_resources_sv.xtb
   A /trunk/src/chrome/app/resources/generated_resources_th.xtb
   A /trunk/src/chrome/app/resources/generated_resources_tr.xtb
   A /trunk/src/chrome/app/resources/generated_resources_uk.xtb
   A /trunk/src/chrome/app/resources/generated_resources_vi.xtb
   A /trunk/src/chrome/app/resources/generated_resources_zh-CN.xtb
   A /trunk/src/chrome/app/resources/generated_resources_zh-TW.xtb
   A /trunk/src/chrome/app/resources/locale_settings_ar.rc
   A /trunk/src/chrome/app/resources/locale_settings_bg.rc
   A /trunk/src/chrome/app/resources/locale_settings_ca.rc
   A /trunk/src/chrome/app/resources/locale_settings_cs.rc
   A /trunk/src/chrome/app/resources/locale_settings_da.rc
   A /trunk/src/chrome/app/resources/locale_settings_de.rc
   A /trunk/src/chrome/app/resources/locale_settings_el.rc
   A /trunk/src/chrome/app/resources/locale_settings_en-GB.rc
   A /trunk/src/chrome/app/resources/locale_settings_en-US.rc
   A /trunk/src/chrome/app/resources/locale_settings_es-419.rc
   A /trunk/src/chrome/app/resources/locale_settings_es.rc
   A /trunk/src/chrome/app/resources/locale_settings_et.rc
   A /trunk/src/chrome/app/resources/locale_settings_fi.rc
   A /trunk/src/chrome/app/resources/locale_settings_fil.rc
   A /trunk/src/chrome/app/resources/locale_settings_fr.rc
   A /trunk/src/chrome/app/resources/locale_settings_he.rc
   A /trunk/src/chrome/app/resources/locale_settings_hi.rc
   A /trunk/src/chrome/app/resources/locale_settings_hr.rc
   A /trunk/src/chrome/app/resources/locale_settings_hu.rc
   A /trunk/src/chrome/app/resources/locale_settings_id.rc
   A /trunk/src/chrome/app/resources/locale_settings_it.rc
   A /trunk/src/chrome/app/resources/locale_settings_ja.rc
   A /trunk/src/chrome/app/resources/locale_settings_ko.rc
   A /trunk/src/chrome/app/resources/locale_settings_lt.rc
   A /trunk/src/chrome/app/resources/locale_settings_lv.rc
   A /trunk/src/chrome/app/resources/locale_settings_nb.rc
   A /trunk/src/chrome/app/resources/locale_settings_nl.rc
   A /trunk/src/chrome/app/resources/locale_settings_pl.rc
   A /trunk/src/chrome/app/resources/locale_settings_pt-BR.rc
   A /trunk/src/chrome/app/resources/locale_settings_pt-PT.rc
   A /trunk/src/chrome/app/resources/locale_settings_ro.rc
   A /trunk/src/chrome/app/resources/locale_settings_ru.rc
   A /trunk/src/chrome/app/resources/locale_settings_sk.rc
   A /trunk/src/chrome/app/resources/locale_settings_sl.rc
   A /trunk/src/chrome/app/resources/locale_settings_sr.rc
   A /trunk/src/chrome/app/resources/locale_settings_sv.rc
   A /trunk/src/chrome/app/resources/locale_settings_th.rc
   A /trunk/src/chrome/app/resources/locale_settings_tr.rc
   A /trunk/src/chrome/app/resources/locale_settings_uk.rc
   A /trunk/src/chrome/app/resources/locale_settings_vi.rc
   A /trunk/src/chrome/app/resources/locale_settings_zh-CN.rc
   A /trunk/src/chrome/app/resources/locale_settings_zh-TW.rc
   A /trunk/src/chrome/app/resources/sadplugin.png
   A /trunk/src/chrome/app/result_codes.h
   A /trunk/src/chrome/app/theme
   A /trunk/src/chrome/app/theme/SConscript
   A /trunk/src/chrome/app/theme/about_background.png
   A /trunk/src/chrome/app/theme/about_background_rtl.png
   A /trunk/src/chrome/app/theme/alert_small.png
   A /trunk/src/chrome/app/theme/app_droparrow.png
   A /trunk/src/chrome/app/theme/app_top_center.png
   A /trunk/src/chrome/app/theme/app_top_left.png
   A /trunk/src/chrome/app/theme/app_top_right.png
   A /trunk/src/chrome/app/theme/arrow_right.png
   A /trunk/src/chrome/app/theme/back.png
   A /trunk/src/chrome/app/theme/back_d.png
   A /trunk/src/chrome/app/theme/back_h.png
   A /trunk/src/chrome/app/theme/back_p.png
   A /trunk/src/chrome/app/theme/bookmark_bar_folder.png
   A /trunk/src/chrome/app/theme/bubble_close.png
   A /trunk/src/chrome/app/theme/bubble_corner_bl.png
   A /trunk/src/chrome/app/theme/bubble_corner_br.png
   A /trunk/src/chrome/app/theme/bubble_corner_tl.png
   A /trunk/src/chrome/app/theme/bubble_corner_tr.png
   A /trunk/src/chrome/app/theme/chevron.png
   A /trunk/src/chrome/app/theme/close.png
   A /trunk/src/chrome/app/theme/close_bar.png
   A /trunk/src/chrome/app/theme/close_bar_h.png
   A /trunk/src/chrome/app/theme/close_bar_p.png
   A /trunk/src/chrome/app/theme/close_h.png
   A /trunk/src/chrome/app/theme/close_p.png
   A /trunk/src/chrome/app/theme/close_sa.png
   A /trunk/src/chrome/app/theme/close_sa_h.png
   A /trunk/src/chrome/app/theme/close_sa_p.png
   A /trunk/src/chrome/app/theme/constrained_bottom_center.png
   A /trunk/src/chrome/app/theme/constrained_bottom_center_v.png
   A /trunk/src/chrome/app/theme/constrained_bottom_left_corner.png
   A /trunk/src/chrome/app/theme/constrained_bottom_left_corner_v.png
   A /trunk/src/chrome/app/theme/constrained_bottom_right_corner.png
   A /trunk/src/chrome/app/theme/constrained_bottom_right_corner_v.png
   A /trunk/src/chrome/app/theme/constrained_left_side.png
   A /trunk/src/chrome/app/theme/constrained_left_side_v.png
   A /trunk/src/chrome/app/theme/constrained_right_side.png
   A /trunk/src/chrome/app/theme/constrained_right_side_v.png
   A /trunk/src/chrome/app/theme/constrained_top_center.png
   A /trunk/src/chrome/app/theme/constrained_top_center_v.png
   A /trunk/src/chrome/app/theme/constrained_top_left_corner.png
   A /trunk/src/chrome/app/theme/constrained_top_left_corner_v.png
   A /trunk/src/chrome/app/theme/constrained_top_right_corner.png
   A /trunk/src/chrome/app/theme/constrained_top_right_corner_v.png
   A /trunk/src/chrome/app/theme/content_bottom_center.png
   A /trunk/src/chrome/app/theme/content_bottom_left_corner.png
   A /trunk/src/chrome/app/theme/content_bottom_right_corner.png
   A /trunk/src/chrome/app/theme/content_left_side.png
   A /trunk/src/chrome/app/theme/content_right_side.png
   A /trunk/src/chrome/app/theme/content_star_d.png
   A /trunk/src/chrome/app/theme/content_star_off.png
   A /trunk/src/chrome/app/theme/content_star_on.png
   A /trunk/src/chrome/app/theme/content_top_center.png
   A /trunk/src/chrome/app/theme/content_top_left_corner.png
   A /trunk/src/chrome/app/theme/content_top_right_corner.png
   A /trunk/src/chrome/app/theme/cookie.png
   A /trunk/src/chrome/app/theme/default_favicon.png
   A /trunk/src/chrome/app/theme/default_thumbnail.png
   A /trunk/src/chrome/app/theme/dewindow_bottom_center.png
   A /trunk/src/chrome/app/theme/dewindow_bottom_center_otr.png
   A /trunk/src/chrome/app/theme/dewindow_bottom_left_corner.png
   A /trunk/src/chrome/app/theme/dewindow_bottom_left_corner_otr.png
   A /trunk/src/chrome/app/theme/dewindow_bottom_right_corner.png
   A /trunk/src/chrome/app/theme/dewindow_bottom_right_corner_otr.png
   A /trunk/src/chrome/app/theme/dewindow_left_side.png
   A /trunk/src/chrome/app/theme/dewindow_left_side_otr.png
   A /trunk/src/chrome/app/theme/dewindow_right_side.png
   A /trunk/src/chrome/app/theme/dewindow_right_side_otr.png
   A /trunk/src/chrome/app/theme/dewindow_top_center.png
   A /trunk/src/chrome/app/theme/dewindow_top_center_otr.png
   A /trunk/src/chrome/app/theme/dewindow_top_left_corner.png
   A /trunk/src/chrome/app/theme/dewindow_top_left_corner_otr.png
   A /trunk/src/chrome/app/theme/dewindow_top_right_corner.png
   A /trunk/src/chrome/app/theme/dewindow_top_right_corner_otr.png
   A /trunk/src/chrome/app/theme/download_animation_begin.png
   A /trunk/src/chrome/app/theme/download_button_center_bottom.png
   A /trunk/src/chrome/app/theme/download_button_center_bottom_h.png
   A /trunk/src/chrome/app/theme/download_button_center_bottom_p.png
   A /trunk/src/chrome/app/theme/download_button_center_middle.png
   A /trunk/src/chrome/app/theme/download_button_center_middle_h.png
   A /trunk/src/chrome/app/theme/download_button_center_middle_p.png
   A /trunk/src/chrome/app/theme/download_button_center_top.png
   A /trunk/src/chrome/app/theme/download_button_center_top_h.png
   A /trunk/src/chrome/app/theme/download_button_center_top_p.png
   A /trunk/src/chrome/app/theme/download_button_left_bottom.png
   A /trunk/src/chrome/app/theme/download_button_left_bottom_h.png
   A /trunk/src/chrome/app/theme/download_button_left_bottom_p.png
   A /trunk/src/chrome/app/theme/download_button_left_middle.png
   A /trunk/src/chrome/app/theme/download_button_left_middle_h.png
   A /trunk/src/chrome/app/theme/download_button_left_middle_p.png
   A /trunk/src/chrome/app/theme/download_button_left_top.png
   A /trunk/src/chrome/app/theme/download_button_left_top_h.png
   A /trunk/src/chrome/app/theme/download_button_left_top_p.png
   A /trunk/src/chrome/app/theme/download_button_menu_bottom.png
   A /trunk/src/chrome/app/theme/download_button_menu_bottom_h.png
   A /trunk/src/chrome/app/theme/download_button_menu_bottom_p.png
   A /trunk/src/chrome/app/theme/download_button_menu_middle.png
   A /trunk/src/chrome/app/theme/download_button_menu_middle_h.png
   A /trunk/src/chrome/app/theme/download_button_menu_middle_p.png
   A /trunk/src/chrome/app/theme/download_button_menu_top.png
   A /trunk/src/chrome/app/theme/download_button_menu_top_h.png
   A /trunk/src/chrome/app/theme/download_button_menu_top_p.png
   A /trunk/src/chrome/app/theme/download_button_right_bottom.png
   A /trunk/src/chrome/app/theme/download_button_right_bottom_h.png
   A /trunk/src/chrome/app/theme/download_button_right_bottom_p.png
   A /trunk/src/chrome/app/theme/download_button_right_middle.png
   A /trunk/src/chrome/app/theme/download_button_right_middle_h.png
   A /trunk/src/chrome/app/theme/download_button_right_middle_p.png
   A /trunk/src/chrome/app/theme/download_button_right_top.png
   A /trunk/src/chrome/app/theme/download_button_right_top_h.png
   A /trunk/src/chrome/app/theme/download_button_right_top_p.png
   A /trunk/src/chrome/app/theme/download_icon.png
   A /trunk/src/chrome/app/theme/download_progress_background16.png
   A /trunk/src/chrome/app/theme/download_progress_background32.png
   A /trunk/src/chrome/app/theme/download_progress_foreground16.png
   A /trunk/src/chrome/app/theme/download_progress_foreground32.png
   A /trunk/src/chrome/app/theme/downloads_favicon.png
   A /trunk/src/chrome/app/theme/downloads_section.png
   A /trunk/src/chrome/app/theme/drop.png
   A /trunk/src/chrome/app/theme/drop_h.png
   A /trunk/src/chrome/app/theme/drop_p.png
   A /trunk/src/chrome/app/theme/find_box_bg.png
   A /trunk/src/chrome/app/theme/find_box_bg_left.png
   A /trunk/src/chrome/app/theme/find_box_bg_left_rtl.png
   A /trunk/src/chrome/app/theme/find_dlg_left_bb_bg.png
   A /trunk/src/chrome/app/theme/find_dlg_left_bg.png
   A /trunk/src/chrome/app/theme/find_dlg_middle_bb_bg.png
   A /trunk/src/chrome/app/theme/find_dlg_middle_bg.png
   A /trunk/src/chrome/app/theme/find_dlg_right_bb_bg.png
   A /trunk/src/chrome/app/theme/find_dlg_right_bg.png
   A /trunk/src/chrome/app/theme/find_next.png
   A /trunk/src/chrome/app/theme/find_next_d.png
   A /trunk/src/chrome/app/theme/find_next_h.png
   A /trunk/src/chrome/app/theme/find_prev.png
   A /trunk/src/chrome/app/theme/find_prev_d.png
   A /trunk/src/chrome/app/theme/find_prev_h.png
   A /trunk/src/chrome/app/theme/folder_closed.png
   A /trunk/src/chrome/app/theme/folder_closed_rtl.png
   A /trunk/src/chrome/app/theme/folder_open.png
   A /trunk/src/chrome/app/theme/folder_open_rtl.png
   A /trunk/src/chrome/app/theme/forward.png
   A /trunk/src/chrome/app/theme/forward_d.png
   A /trunk/src/chrome/app/theme/forward_h.png
   A /trunk/src/chrome/app/theme/forward_p.png
   A /trunk/src/chrome/app/theme/frozen_plugin.png
   A /trunk/src/chrome/app/theme/frozen_tab.png
   A /trunk/src/chrome/app/theme/go.png
   A /trunk/src/chrome/app/theme/go_d.png
   A /trunk/src/chrome/app/theme/go_h.png
   A /trunk/src/chrome/app/theme/go_p.png
   A /trunk/src/chrome/app/theme/history_favicon.png
   A /trunk/src/chrome/app/theme/history_section.png
   A /trunk/src/chrome/app/theme/home.png
   A /trunk/src/chrome/app/theme/home_h.png
   A /trunk/src/chrome/app/theme/home_p.png
   A /trunk/src/chrome/app/theme/infobar_didyoumean.png
   A /trunk/src/chrome/app/theme/infobar_insecure.png
   A /trunk/src/chrome/app/theme/infobar_plugin.png
   A /trunk/src/chrome/app/theme/infobar_plugin_crashed.png
   A /trunk/src/chrome/app/theme/infobar_restore.png
   A /trunk/src/chrome/app/theme/infobar_savepassword.png
   A /trunk/src/chrome/app/theme/input_alert.png
   A /trunk/src/chrome/app/theme/input_good.png
   A /trunk/src/chrome/app/theme/input_unknown.png
   A /trunk/src/chrome/app/theme/insecure_content_stamp.png
   A /trunk/src/chrome/app/theme/keyword_hint_tab.png
   A /trunk/src/chrome/app/theme/location_bar_keyword_search_c.png
   A /trunk/src/chrome/app/theme/location_bar_keyword_search_l.png
   A /trunk/src/chrome/app/theme/location_bar_keyword_search_r.png
   A /trunk/src/chrome/app/theme/locationbg.png
   A /trunk/src/chrome/app/theme/locationbg_readonly_center.png
   A /trunk/src/chrome/app/theme/locationbg_readonly_left.png
   A /trunk/src/chrome/app/theme/locationbg_readonly_right.png
   A /trunk/src/chrome/app/theme/lock_small.png
   A /trunk/src/chrome/app/theme/maximize.png
   A /trunk/src/chrome/app/theme/maximize_h.png
   A /trunk/src/chrome/app/theme/maximize_p.png
   A /trunk/src/chrome/app/theme/menu_chrome.png
   A /trunk/src/chrome/app/theme/menu_chrome_rtl.png
   A /trunk/src/chrome/app/theme/menu_marker.png
   A /trunk/src/chrome/app/theme/menu_page.png
   A /trunk/src/chrome/app/theme/menu_page_rtl.png
   A /trunk/src/chrome/app/theme/minimize.png
   A /trunk/src/chrome/app/theme/minimize_h.png
   A /trunk/src/chrome/app/theme/minimize_p.png
   A /trunk/src/chrome/app/theme/newtab.png
   A /trunk/src/chrome/app/theme/newtab_h.png
   A /trunk/src/chrome/app/theme/newtab_p.png
   A /trunk/src/chrome/app/theme/otr_icon.png
   A /trunk/src/chrome/app/theme/otr_icon_standalone.png
   A /trunk/src/chrome/app/theme/pageinfo_bad.png
   A /trunk/src/chrome/app/theme/pageinfo_good.png
   A /trunk/src/chrome/app/theme/plugin.png
   A /trunk/src/chrome/app/theme/product_logo.png
   A /trunk/src/chrome/app/theme/reload.png
   A /trunk/src/chrome/app/theme/reload_d.png
   A /trunk/src/chrome/app/theme/reload_h.png
   A /trunk/src/chrome/app/theme/reload_p.png
   A /trunk/src/chrome/app/theme/restore.png
   A /trunk/src/chrome/app/theme/restore_h.png
   A /trunk/src/chrome/app/theme/restore_p.png
   A /trunk/src/chrome/app/theme/sadfavicon.png
   A /trunk/src/chrome/app/theme/sadtab.png
   A /trunk/src/chrome/app/theme/star.png
   A /trunk/src/chrome/app/theme/star_d.png
   A /trunk/src/chrome/app/theme/star_h.png
   A /trunk/src/chrome/app/theme/star_p.png
   A /trunk/src/chrome/app/theme/star_small.png
   A /trunk/src/chrome/app/theme/starred.png
   A /trunk/src/chrome/app/theme/starred_h.png
   A /trunk/src/chrome/app/theme/starred_p.png
   A /trunk/src/chrome/app/theme/stop.png
   A /trunk/src/chrome/app/theme/stop_h.png
   A /trunk/src/chrome/app/theme/stop_p.png
   A /trunk/src/chrome/app/theme/tab_active_center.png
   A /trunk/src/chrome/app/theme/tab_active_left.png
   A /trunk/src/chrome/app/theme/tab_active_right.png
   A /trunk/src/chrome/app/theme/tab_close.png
   A /trunk/src/chrome/app/theme/tab_close_h.png
   A /trunk/src/chrome/app/theme/tab_close_p.png
   A /trunk/src/chrome/app/theme/tab_drop_down.png
   A /trunk/src/chrome/app/theme/tab_drop_up.png
   A /trunk/src/chrome/app/theme/tab_hover_center.png
   A /trunk/src/chrome/app/theme/tab_hover_left.png
   A /trunk/src/chrome/app/theme/tab_hover_right.png
   A /trunk/src/chrome/app/theme/tab_inactive_center.png
   A /trunk/src/chrome/app/theme/tab_inactive_center_otr.png
   A /trunk/src/chrome/app/theme/tab_inactive_center_v.png
   A /trunk/src/chrome/app/theme/tab_inactive_left.png
   A /trunk/src/chrome/app/theme/tab_inactive_left_otr.png
   A /trunk/src/chrome/app/theme/tab_inactive_left_v.png
   A /trunk/src/chrome/app/theme/tab_inactive_right.png
   A /trunk/src/chrome/app/theme/tab_inactive_right_otr.png
   A /trunk/src/chrome/app/theme/tab_inactive_right_v.png
   A /trunk/src/chrome/app/theme/textbutton_b_h.png
   A /trunk/src/chrome/app/theme/textbutton_b_p.png
   A /trunk/src/chrome/app/theme/textbutton_bl_h.png
   A /trunk/src/chrome/app/theme/textbutton_bl_p.png
   A /trunk/src/chrome/app/theme/textbutton_br_h.png
   A /trunk/src/chrome/app/theme/textbutton_br_p.png
   A /trunk/src/chrome/app/theme/textbutton_c_h.png
   A /trunk/src/chrome/app/theme/textbutton_c_p.png
   A /trunk/src/chrome/app/theme/textbutton_l_h.png
   A /trunk/src/chrome/app/theme/textbutton_l_p.png
   A /trunk/src/chrome/app/theme/textbutton_r_h.png
   A /trunk/src/chrome/app/theme/textbutton_r_p.png
   A /trunk/src/chrome/app/theme/textbutton_t_h.png
   A /trunk/src/chrome/app/theme/textbutton_t_p.png
   A /trunk/src/chrome/app/theme/textbutton_tl_h.png
   A /trunk/src/chrome/app/theme/textbutton_tl_p.png
   A /trunk/src/chrome/app/theme/textbutton_tr_h.png
   A /trunk/src/chrome/app/theme/textbutton_tr_p.png
   A /trunk/src/chrome/app/theme/theme_dll.vcproj
   A /trunk/src/chrome/app/theme/theme_dll.vsprops
   A /trunk/src/chrome/app/theme/theme_resources.h
   A /trunk/src/chrome/app/theme/theme_resources.rc
   A /trunk/src/chrome/app/theme/throbber.png
   A /trunk/src/chrome/app/theme/throbber_light.png
   A /trunk/src/chrome/app/theme/throbber_waiting.png
   A /trunk/src/chrome/app/theme/update_available.png
   A /trunk/src/chrome/app/theme/update_fail.png
   A /trunk/src/chrome/app/theme/update_uptodate.png
   A /trunk/src/chrome/app/theme/vista_frame_throbber_01.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_02.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_03.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_04.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_05.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_06.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_07.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_08.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_09.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_10.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_11.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_12.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_13.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_14.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_15.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_16.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_17.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_18.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_19.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_20.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_21.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_22.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_23.ico
   A /trunk/src/chrome/app/theme/vista_frame_throbber_24.ico
   A /trunk/src/chrome/app/theme/window_bottom_center.png
   A /trunk/src/chrome/app/theme/window_bottom_center_otr.png
   A /trunk/src/chrome/app/theme/window_bottom_left_corner.png
   A /trunk/src/chrome/app/theme/window_bottom_left_corner_otr.png
   A /trunk/src/chrome/app/theme/window_bottom_right_corner.png
   A /trunk/src/chrome/app/theme/window_bottom_right_corner_otr.png
   A /trunk/src/chrome/app/theme/window_left_side.png
   A /trunk/src/chrome/app/theme/window_left_side_otr.png
   A /trunk/src/chrome/app/theme/window_right_side.png
   A /trunk/src/chrome/app/theme/window_right_side_otr.png
   A /trunk/src/chrome/app/theme/window_top_center.png
   A /trunk/src/chrome/app/theme/window_top_center_otr.png
   A /trunk/src/chrome/app/theme/window_top_left_corner.png
   A /trunk/src/chrome/app/theme/window_top_left_corner_otr.png
   A /trunk/src/chrome/app/theme/window_top_right_corner.png
   A /trunk/src/chrome/app/theme/window_top_right_corner_otr.png
   A /trunk/src/chrome/app/theme/wizard_icon.png
   A /trunk/src/chrome/app/theme/wizard_icon_rtl.png
   A /trunk/src/chrome/browser
   A /trunk/src/chrome/browser/SConscript
   A /trunk/src/chrome/browser/about_internets_status_view.cc
   A /trunk/src/chrome/browser/about_internets_status_view.h
   A /trunk/src/chrome/browser/alternate_nav_url_fetcher.cc
   A /trunk/src/chrome/browser/alternate_nav_url_fetcher.h
   A /trunk/src/chrome/browser/app_integration
   A /trunk/src/chrome/browser/app_modal_dialog_queue.cc
   A /trunk/src/chrome/browser/app_modal_dialog_queue.h
   A /trunk/src/chrome/browser/autocomplete
   A /trunk/src/chrome/browser/autocomplete/autocomplete.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_edit.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup.cc
   A /trunk/src/chrome/browser/autocomplete/autocomplete_popup.h
   A /trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc
   A /trunk/src/chrome/browser/autocomplete/edit_drop_target.cc
   A /trunk/src/chrome/browser/autocomplete/edit_drop_target.h
   A /trunk/src/chrome/browser/autocomplete/history_contents_provider.cc
   A /trunk/src/chrome/browser/autocomplete/history_contents_provider.h
   A /trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc
   A /trunk/src/chrome/browser/autocomplete/history_url_provider.cc
   A /trunk/src/chrome/browser/autocomplete/history_url_provider.h
   A /trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc
   A /trunk/src/chrome/browser/autocomplete/keyword_provider.cc
   A /trunk/src/chrome/browser/autocomplete/keyword_provider.h
   A /trunk/src/chrome/browser/autocomplete/keyword_provider_unittest.cc
   A /trunk/src/chrome/browser/autocomplete/search_provider.cc
   A /trunk/src/chrome/browser/autocomplete/search_provider.h
   A /trunk/src/chrome/browser/automation
   A /trunk/src/chrome/browser/automation/automation_autocomplete_edit_tracker.h
   A /trunk/src/chrome/browser/automation/automation_browser_tracker.h
   A /trunk/src/chrome/browser/automation/automation_constrained_window_tracker.h
   A /trunk/src/chrome/browser/automation/automation_provider.cc
   A /trunk/src/chrome/browser/automation/automation_provider.h
   A /trunk/src/chrome/browser/automation/automation_provider_list.cc
   A /trunk/src/chrome/browser/automation/automation_provider_list.h
   A /trunk/src/chrome/browser/automation/automation_resource_tracker.cc
   A /trunk/src/chrome/browser/automation/automation_resource_tracker.h
   A /trunk/src/chrome/browser/automation/automation_tab_tracker.h
   A /trunk/src/chrome/browser/automation/automation_window_tracker.h
   A /trunk/src/chrome/browser/automation/ui_controls.cc
   A /trunk/src/chrome/browser/automation/ui_controls.h
   A /trunk/src/chrome/browser/automation/url_request_failed_dns_job.cc
   A /trunk/src/chrome/browser/automation/url_request_failed_dns_job.h
   A /trunk/src/chrome/browser/automation/url_request_mock_http_job.cc
   A /trunk/src/chrome/browser/automation/url_request_mock_http_job.h
   A /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.cc
   A /trunk/src/chrome/browser/automation/url_request_mock_net_error_job.h
   A /trunk/src/chrome/browser/automation/url_request_slow_download_job.cc
   A /trunk/src/chrome/browser/automation/url_request_slow_download_job.h
   A /trunk/src/chrome/browser/avatar
   A /trunk/src/chrome/browser/back_forward_menu_model.cc
   A /trunk/src/chrome/browser/back_forward_menu_model.h
   A /trunk/src/chrome/browser/back_forward_menu_model_unittest.cc
   A /trunk/src/chrome/browser/base_history_model.cc
   A /trunk/src/chrome/browser/base_history_model.h
   A /trunk/src/chrome/browser/bookmark_bar_model.cc
   A /trunk/src/chrome/browser/bookmark_bar_model.h
   A /trunk/src/chrome/browser/bookmark_bar_model_unittest.cc
   A /trunk/src/chrome/browser/bookmark_drag_data.cc
   A /trunk/src/chrome/browser/bookmark_drag_data.h
   A /trunk/src/chrome/browser/bookmark_drag_data_unittest.cc
   A /trunk/src/chrome/browser/browser.cc
   A /trunk/src/chrome/browser/browser.h
   A /trunk/src/chrome/browser/browser.vcproj
   A /trunk/src/chrome/browser/browser.vsprops
   A /trunk/src/chrome/browser/browser_about_handler.cc
   A /trunk/src/chrome/browser/browser_about_handler.h
   A /trunk/src/chrome/browser/browser_commands.cc
   A /trunk/src/chrome/browser/browser_focus_uitest.cc
   A /trunk/src/chrome/browser/browser_init.cc
   A /trunk/src/chrome/browser/browser_init.h
   A /trunk/src/chrome/browser/browser_list.cc
   A /trunk/src/chrome/browser/browser_list.h
   A /trunk/src/chrome/browser/browser_main.cc
   A /trunk/src/chrome/browser/browser_prefs.cc
   A /trunk/src/chrome/browser/browser_prefs.h
   A /trunk/src/chrome/browser/browser_process.cc
   A /trunk/src/chrome/browser/browser_process.h
   A /trunk/src/chrome/browser/browser_process_impl.cc
   A /trunk/src/chrome/browser/browser_process_impl.h
   A /trunk/src/chrome/browser/browser_resources.h
   A /trunk/src/chrome/browser/browser_resources.rc
   A /trunk/src/chrome/browser/browser_shutdown.cc
   A /trunk/src/chrome/browser/browser_shutdown.h
   A /trunk/src/chrome/browser/browser_type.h
   A /trunk/src/chrome/browser/browser_uitest.cc
   A /trunk/src/chrome/browser/browser_url_handler.cc
   A /trunk/src/chrome/browser/browser_url_handler.h
   A /trunk/src/chrome/browser/browsing_data_remover.cc
   A /trunk/src/chrome/browser/browsing_data_remover.h
   A /trunk/src/chrome/browser/browsing_instance.cc
   A /trunk/src/chrome/browser/browsing_instance.h
   A /trunk/src/chrome/browser/cache_manager_host.cc
   A /trunk/src/chrome/browser/cache_manager_host.h
   A /trunk/src/chrome/browser/cache_manager_host_unittest.cc
   A /trunk/src/chrome/browser/cancelable_request.cc
   A /trunk/src/chrome/browser/cancelable_request.h
   A /trunk/src/chrome/browser/cert_store.cc
   A /trunk/src/chrome/browser/cert_store.h
   A /trunk/src/chrome/browser/character_encoding.cc
   A /trunk/src/chrome/browser/character_encoding.h
   A /trunk/src/chrome/browser/chrome_frame.cc
   A /trunk/src/chrome/browser/chrome_frame.h
   A /trunk/src/chrome/browser/chrome_plugin_browsing_context.cc
   A /trunk/src/chrome/browser/chrome_plugin_browsing_context.h
   A /trunk/src/chrome/browser/chrome_plugin_host.cc
   A /trunk/src/chrome/browser/chrome_plugin_host.h
   A /trunk/src/chrome/browser/chrome_thread.cc
   A /trunk/src/chrome/browser/chrome_thread.h
   A /trunk/src/chrome/browser/chrome_thread_unittest.cc
   A /trunk/src/chrome/browser/constrained_window.h
   A /trunk/src/chrome/browser/controller.cc
   A /trunk/src/chrome/browser/controller.h
   A /trunk/src/chrome/browser/controller_unittest.cc
   A /trunk/src/chrome/browser/crash_recovery_uitest.cc
   A /trunk/src/chrome/browser/cross_site_request_manager.cc
   A /trunk/src/chrome/browser/cross_site_request_manager.h
   A /trunk/src/chrome/browser/debugger
   A /trunk/src/chrome/browser/debugger/SConscript
   A /trunk/src/chrome/browser/debugger/debugger.vcproj
   A /trunk/src/chrome/browser/debugger/debugger.vsprops
   A /trunk/src/chrome/browser/debugger/debugger_disabled.vcproj
   A /trunk/src/chrome/browser/debugger/debugger_disabled.vsprops
   A /trunk/src/chrome/browser/debugger/debugger_io.h
   A /trunk/src/chrome/browser/debugger/debugger_io_socket.cc
   A /trunk/src/chrome/browser/debugger/debugger_io_socket.h
   A /trunk/src/chrome/browser/debugger/debugger_node.cc
   A /trunk/src/chrome/browser/debugger/debugger_node.h
   A /trunk/src/chrome/browser/debugger/debugger_shell.cc
   A /trunk/src/chrome/browser/debugger/debugger_shell.h
   A /trunk/src/chrome/browser/debugger/debugger_view.cc
   A /trunk/src/chrome/browser/debugger/debugger_view.h
   A /trunk/src/chrome/browser/debugger/debugger_window.cc
   A /trunk/src/chrome/browser/debugger/debugger_window.h
   A /trunk/src/chrome/browser/debugger/debugger_wrapper.cc
   A /trunk/src/chrome/browser/debugger/debugger_wrapper.h
   A /trunk/src/chrome/browser/dom_operation_notification_details.h
   A /trunk/src/chrome/browser/dom_ui
   A /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc
   A /trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.h
   A /trunk/src/chrome/browser/dom_ui/dom_ui_host.cc
   A /trunk/src/chrome/browser/dom_ui/dom_ui_host.h
   A /trunk/src/chrome/browser/dom_ui/html_dialog_contents.cc
   A /trunk/src/chrome/browser/dom_ui/html_dialog_contents.h
   A /trunk/src/chrome/browser/dom_ui/new_tab_ui.cc
   A /trunk/src/chrome/browser/dom_ui/new_tab_ui.h
   A /trunk/src/chrome/browser/download_exe.cc
   A /trunk/src/chrome/browser/download_file.cc
   A /trunk/src/chrome/browser/download_file.h
   A /trunk/src/chrome/browser/download_item_model.cc
   A /trunk/src/chrome/browser/download_item_model.h
   A /trunk/src/chrome/browser/download_manager.cc
   A /trunk/src/chrome/browser/download_manager.h
   A /trunk/src/chrome/browser/download_manager_unittest.cc
   A /trunk/src/chrome/browser/download_tab_view.cc
   A /trunk/src/chrome/browser/download_tab_view.h
   A /trunk/src/chrome/browser/download_uitest.cc
   A /trunk/src/chrome/browser/download_util.cc
   A /trunk/src/chrome/browser/download_util.h
   A /trunk/src/chrome/browser/drag_utils.cc
   A /trunk/src/chrome/browser/drag_utils.h
   A /trunk/src/chrome/browser/encoding_menu_controller_delegate.cc
   A /trunk/src/chrome/browser/encoding_menu_controller_delegate.h
   A /trunk/src/chrome/browser/encryptor.cc
   A /trunk/src/chrome/browser/encryptor.h
   A /trunk/src/chrome/browser/encryptor_unittest.cc
   A /trunk/src/chrome/browser/errorpage_uitest.cc
   A /trunk/src/chrome/browser/external_protocol_dialog.cc
   A /trunk/src/chrome/browser/external_protocol_dialog.h
   A /trunk/src/chrome/browser/external_protocol_handler.cc
   A /trunk/src/chrome/browser/external_protocol_handler.h
   A /trunk/src/chrome/browser/external_tab_container.cc
   A /trunk/src/chrome/browser/external_tab_container.h
   A /trunk/src/chrome/browser/fav_icon_helper.cc
   A /trunk/src/chrome/browser/fav_icon_helper.h
   A /trunk/src/chrome/browser/find_in_page_controller.cc
   A /trunk/src/chrome/browser/find_in_page_controller.h
   A /trunk/src/chrome/browser/find_in_page_controller_uitest.cc
   A /trunk/src/chrome/browser/find_in_page_view.cc
   A /trunk/src/chrome/browser/find_in_page_view.h
   A /trunk/src/chrome/browser/find_notification_details.h
   A /trunk/src/chrome/browser/firefox2_importer.cc
   A /trunk/src/chrome/browser/firefox2_importer.h
   A /trunk/src/chrome/browser/firefox3_importer.cc
   A /trunk/src/chrome/browser/firefox3_importer.h
   A /trunk/src/chrome/browser/firefox_importer_unittest.cc
   A /trunk/src/chrome/browser/firefox_importer_utils.cc
   A /trunk/src/chrome/browser/firefox_importer_utils.h
   A /trunk/src/chrome/browser/firefox_profile_lock.cc
   A /trunk/src/chrome/browser/firefox_profile_lock.h
   A /trunk/src/chrome/browser/first_run.cc
   A /trunk/src/chrome/browser/first_run.h
   A /trunk/src/chrome/browser/frame_view.cc
   A /trunk/src/chrome/browser/frame_view.h
   A /trunk/src/chrome/browser/gears_integration.cc
   A /trunk/src/chrome/browser/gears_integration.h
   A /trunk/src/chrome/browser/google_update.cc
   A /trunk/src/chrome/browser/google_update.h
   A /trunk/src/chrome/browser/google_url_tracker.cc
   A /trunk/src/chrome/browser/google_url_tracker.h
   A /trunk/src/chrome/browser/google_url_tracker_unittest.cc
   A /trunk/src/chrome/browser/google_util.cc
   A /trunk/src/chrome/browser/google_util.h
   A /trunk/src/chrome/browser/hang_monitor
   A /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.cc
   A /trunk/src/chrome/browser/hang_monitor/hung_plugin_action.h
   A /trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc
   A /trunk/src/chrome/browser/hang_monitor/hung_window_detector.h
   A /trunk/src/chrome/browser/history
   A /trunk/src/chrome/browser/history/archived_database.cc
   A /trunk/src/chrome/browser/history/archived_database.h
   A /trunk/src/chrome/browser/history/download_database.cc
   A /trunk/src/chrome/browser/history/download_database.h
   A /trunk/src/chrome/browser/history/download_types.h
   A /trunk/src/chrome/browser/history/expire_history_backend.cc
   A /trunk/src/chrome/browser/history/expire_history_backend.h
   A /trunk/src/chrome/browser/history/expire_history_backend_unittest.cc
   A /trunk/src/chrome/browser/history/history.cc
   A /trunk/src/chrome/browser/history/history.h
   A /trunk/src/chrome/browser/history/history_backend.cc
   A /trunk/src/chrome/browser/history/history_backend.h
   A /trunk/src/chrome/browser/history/history_backend_unittest.cc
   A /trunk/src/chrome/browser/history/history_database.cc
   A /trunk/src/chrome/browser/history/history_database.h
   A /trunk/src/chrome/browser/history/history_marshaling.h
   A /trunk/src/chrome/browser/history/history_notifications.h
   A /trunk/src/chrome/browser/history/history_querying_unittest.cc
   A /trunk/src/chrome/browser/history/history_types.cc
   A /trunk/src/chrome/browser/history/history_types.h
   A /trunk/src/chrome/browser/history/history_types_unittest.cc
   A /trunk/src/chrome/browser/history/history_unittest.cc
   A /trunk/src/chrome/browser/history/in_memory_database.cc
   A /trunk/src/chrome/browser/history/in_memory_database.h
   A /trunk/src/chrome/browser/history/in_memory_history_backend.cc
   A /trunk/src/chrome/browser/history/in_memory_history_backend.h
   A /trunk/src/chrome/browser/history/page_usage_data.cc
   A /trunk/src/chrome/browser/history/page_usage_data.h
   A /trunk/src/chrome/browser/history/query_parser.cc
   A /trunk/src/chrome/browser/history/query_parser.h
   A /trunk/src/chrome/browser/history/query_parser_unittest.cc
   A /trunk/src/chrome/browser/history/redirect_uitest.cc
   A /trunk/src/chrome/browser/history/snippet.cc
   A /trunk/src/chrome/browser/history/snippet.h
   A /trunk/src/chrome/browser/history/snippet_unittest.cc
   A /trunk/src/chrome/browser/history/starred_url_database.cc
   A /trunk/src/chrome/browser/history/starred_url_database.h
   A /trunk/src/chrome/browser/history/starred_url_database_unittest.cc
   A /trunk/src/chrome/browser/history/text_database.cc
   A /trunk/src/chrome/browser/history/text_database.h
   A /trunk/src/chrome/browser/history/text_database_manager.cc
   A /trunk/src/chrome/browser/history/text_database_manager.h
   A /trunk/src/chrome/browser/history/text_database_manager_unittest.cc
   A /trunk/src/chrome/browser/history/text_database_unittest.cc
   A /trunk/src/chrome/browser/history/thumbnail_database.cc
   A /trunk/src/chrome/browser/history/thumbnail_database.h
   A /trunk/src/chrome/browser/history/thumbnail_database_unittest.cc
   A /trunk/src/chrome/browser/history/url_database.cc
   A /trunk/src/chrome/browser/history/url_database.h
   A /trunk/src/chrome/browser/history/url_database_unittest.cc
   A /trunk/src/chrome/browser/history/visit_database.cc
   A /trunk/src/chrome/browser/history/visit_database.h
   A /trunk/src/chrome/browser/history/visit_database_unittest.cc
   A /trunk/src/chrome/browser/history/visit_tracker.cc
   A /trunk/src/chrome/browser/history/visit_tracker.h
   A /trunk/src/chrome/browser/history/visit_tracker_unittest.cc
   A /trunk/src/chrome/browser/history/visitsegment_database.cc
   A /trunk/src/chrome/browser/history/visitsegment_database.h
   A /trunk/src/chrome/browser/history_model.cc
   A /trunk/src/chrome/browser/history_model.h
   A /trunk/src/chrome/browser/history_tab_ui.cc
   A /trunk/src/chrome/browser/history_tab_ui.h
   A /trunk/src/chrome/browser/history_view.cc
   A /trunk/src/chrome/browser/history_view.h
   A /trunk/src/chrome/browser/icon_loader.cc
   A /trunk/src/chrome/browser/icon_loader.h
   A /trunk/src/chrome/browser/icon_manager.cc
   A /trunk/src/chrome/browser/icon_manager.h
   A /trunk/src/chrome/browser/ie7_password.cc
   A /trunk/src/chrome/browser/ie7_password.h
   A /trunk/src/chrome/browser/ie_importer.cc
   A /trunk/src/chrome/browser/ie_importer.h
   A /trunk/src/chrome/browser/iframe_uitest.cc
   A /trunk/src/chrome/browser/images_uitest.cc
   A /trunk/src/chrome/browser/ime_input.cc
   A /trunk/src/chrome/browser/ime_input.h
   A /trunk/src/chrome/browser/importer.cc
   A /trunk/src/chrome/browser/importer.h
   A /trunk/src/chrome/browser/importer_unittest.cc
   A /trunk/src/chrome/browser/interstitial_page_delegate.h
   A /trunk/src/chrome/browser/interstitial_page_uitest.cc
   A /trunk/src/chrome/browser/ipc_status_view.cc
   A /trunk/src/chrome/browser/ipc_status_view.h
   A /trunk/src/chrome/browser/jankometer.cc
   A /trunk/src/chrome/browser/jankometer.h
   A /trunk/src/chrome/browser/js_before_unload_handler.cc
   A /trunk/src/chrome/browser/js_before_unload_handler.h
   A /trunk/src/chrome/browser/jsmessage_box_handler.cc
   A /trunk/src/chrome/browser/jsmessage_box_handler.h
   A /trunk/src/chrome/browser/load_from_memory_cache_details.h
   A /trunk/src/chrome/browser/load_notification_details.h
   A /trunk/src/chrome/browser/locale_tests_uitest.cc
   A /trunk/src/chrome/browser/login_prompt.cc
   A /trunk/src/chrome/browser/login_prompt.h
   A /trunk/src/chrome/browser/login_prompt_uitest.cc
   A /trunk/src/chrome/browser/memory_details.cc
   A /trunk/src/chrome/browser/memory_details.h
   A /trunk/src/chrome/browser/meta_table_helper.cc
   A /trunk/src/chrome/browser/meta_table_helper.h
   A /trunk/src/chrome/browser/metrics_log.cc
   A /trunk/src/chrome/browser/metrics_log.h
   A /trunk/src/chrome/browser/metrics_log_unittest.cc
   A /trunk/src/chrome/browser/metrics_response.cc
   A /trunk/src/chrome/browser/metrics_response.h
   A /trunk/src/chrome/browser/metrics_response_unittest.cc
   A /trunk/src/chrome/browser/metrics_service.cc
   A /trunk/src/chrome/browser/metrics_service.h
   A /trunk/src/chrome/browser/metrics_service_uitest.cc
   A /trunk/src/chrome/browser/modal_html_dialog_delegate.cc
   A /trunk/src/chrome/browser/modal_html_dialog_delegate.h
   A /trunk/src/chrome/browser/mork_reader.cc
   A /trunk/src/chrome/browser/mork_reader.h
   A /trunk/src/chrome/browser/native_ui_contents.cc
   A /trunk/src/chrome/browser/native_ui_contents.h
   A /trunk/src/chrome/browser/navigation_controller.cc
   A /trunk/src/chrome/browser/navigation_controller.h
   A /trunk/src/chrome/browser/navigation_controller_base.cc
   A /trunk/src/chrome/browser/navigation_controller_base.h
   A /trunk/src/chrome/browser/navigation_controller_unittest.cc
   A /trunk/src/chrome/browser/navigation_entry.cc
   A /trunk/src/chrome/browser/navigation_entry.h
   A /trunk/src/chrome/browser/navigation_performance_viewer.cc
   A /trunk/src/chrome/browser/navigation_performance_viewer.h
   A /trunk/src/chrome/browser/navigation_profiler.cc
   A /trunk/src/chrome/browser/navigation_profiler.h
   A /trunk/src/chrome/browser/navigation_profiler_unittest.cc
   A /trunk/src/chrome/browser/net
   A /trunk/src/chrome/browser/net/dns_global.cc
   A /trunk/src/chrome/browser/net/dns_global.h
   A /trunk/src/chrome/browser/net/dns_host_info.cc
   A /trunk/src/chrome/browser/net/dns_host_info.h
   A /trunk/src/chrome/browser/net/dns_host_info_unittest.cc
   A /trunk/src/chrome/browser/net/dns_master.cc
   A /trunk/src/chrome/browser/net/dns_master.h
   A /trunk/src/chrome/browser/net/dns_master_unittest.cc
   A /trunk/src/chrome/browser/net/dns_slave.cc
   A /trunk/src/chrome/browser/net/dns_slave.h
   A /trunk/src/chrome/browser/network_status_view.cc
   A /trunk/src/chrome/browser/network_status_view.h
   A /trunk/src/chrome/browser/options_window.h
   A /trunk/src/chrome/browser/page_info_window.cc
   A /trunk/src/chrome/browser/page_info_window.h
   A /trunk/src/chrome/browser/page_load_tracker.cc
   A /trunk/src/chrome/browser/page_load_tracker.h
   A /trunk/src/chrome/browser/page_load_tracker_unittest.cc
   A /trunk/src/chrome/browser/page_navigator.h
   A /trunk/src/chrome/browser/page_state.cc
   A /trunk/src/chrome/browser/page_state.h
   A /trunk/src/chrome/browser/password_form_manager.cc
   A /trunk/src/chrome/browser/password_form_manager.h
   A /trunk/src/chrome/browser/password_form_manager_unittest.cc
   A /trunk/src/chrome/browser/password_manager.cc
   A /trunk/src/chrome/browser/password_manager.h
   A /trunk/src/chrome/browser/plugin_installer.cc
   A /trunk/src/chrome/browser/plugin_installer.h
   A /trunk/src/chrome/browser/plugin_process_host.cc
   A /trunk/src/chrome/browser/plugin_process_host.h
   A /trunk/src/chrome/browser/plugin_process_info.h
   A /trunk/src/chrome/browser/plugin_service.cc
   A /trunk/src/chrome/browser/plugin_service.h
   A /trunk/src/chrome/browser/point_buffer.cc
   A /trunk/src/chrome/browser/point_buffer.h
   A /trunk/src/chrome/browser/printing
   A /trunk/src/chrome/browser/printing/page_number.cc
   A /trunk/src/chrome/browser/printing/page_number.h
   A /trunk/src/chrome/browser/printing/page_overlays.cc
   A /trunk/src/chrome/browser/printing/page_overlays.h
   A /trunk/src/chrome/browser/printing/page_range.cc
   A /trunk/src/chrome/browser/printing/page_range.h
   A /trunk/src/chrome/browser/printing/page_setup.cc
   A /trunk/src/chrome/browser/printing/page_setup.h
   A /trunk/src/chrome/browser/printing/page_setup_unittest.cc
   A /trunk/src/chrome/browser/printing/print_job.cc
   A /trunk/src/chrome/browser/printing/print_job.h
   A /trunk/src/chrome/browser/printing/print_job_manager.cc
   A /trunk/src/chrome/browser/printing/print_job_manager.h
   A /trunk/src/chrome/browser/printing/print_job_worker.cc
   A /trunk/src/chrome/browser/printing/print_job_worker.h
   A /trunk/src/chrome/browser/printing/print_job_worker_owner.h
   A /trunk/src/chrome/browser/printing/print_settings.cc
   A /trunk/src/chrome/browser/printing/print_settings.h
   A /trunk/src/chrome/browser/printing/print_view_manager.cc
   A /trunk/src/chrome/browser/printing/print_view_manager.h
   A /trunk/src/chrome/browser/printing/printed_document.cc
   A /trunk/src/chrome/browser/printing/printed_document.h
   A /trunk/src/chrome/browser/printing/printed_page.cc
   A /trunk/src/chrome/browser/printing/printed_page.h
   A /trunk/src/chrome/browser/printing/printed_pages_source.h
   A /trunk/src/chrome/browser/printing/printer_query.cc
   A /trunk/src/chrome/browser/printing/printer_query.h
   A /trunk/src/chrome/browser/printing/printing_layout_uitest.cc
   A /trunk/src/chrome/browser/printing/printing_test.h
   A /trunk/src/chrome/browser/printing/units.cc
   A /trunk/src/chrome/browser/printing/units.h
   A /trunk/src/chrome/browser/printing/win_printing_context.cc
   A /trunk/src/chrome/browser/printing/win_printing_context.h
   A /trunk/src/chrome/browser/printing/win_printing_context_unittest.cc
   A /trunk/src/chrome/browser/profile.cc
   A /trunk/src/chrome/browser/profile.h
   A /trunk/src/chrome/browser/profile_manager.cc
   A /trunk/src/chrome/browser/profile_manager.h
   A /trunk/src/chrome/browser/profile_manager_unittest.cc
   A /trunk/src/chrome/browser/provisional_load_details.cc
   A /trunk/src/chrome/browser/provisional_load_details.h
   A /trunk/src/chrome/browser/render_process_host.cc
   A /trunk/src/chrome/browser/render_process_host.h
   A /trunk/src/chrome/browser/render_view_context_menu.cc
   A /trunk/src/chrome/browser/render_view_context_menu.h
   A /trunk/src/chrome/browser/render_view_context_menu_controller.cc
   A /trunk/src/chrome/browser/render_view_context_menu_controller.h
   A /trunk/src/chrome/browser/render_view_host.cc
   A /trunk/src/chrome/browser/render_view_host.h
   A /trunk/src/chrome/browser/render_view_host_delegate.h
   A /trunk/src/chrome/browser/render_widget_helper.cc
   A /trunk/src/chrome/browser/render_widget_helper.h
   A /trunk/src/chrome/browser/render_widget_host.cc
   A /trunk/src/chrome/browser/render_widget_host.h
   A /trunk/src/chrome/browser/render_widget_host_hwnd.cc
   A /trunk/src/chrome/browser/render_widget_host_hwnd.h
   A /trunk/src/chrome/browser/render_widget_host_view.h
   A /trunk/src/chrome/browser/renderer_security_policy.cc
   A /trunk/src/chrome/browser/renderer_security_policy.h
   A /trunk/src/chrome/browser/renderer_security_policy_unittest.cc
   A /trunk/src/chrome/browser/repost_form_warning_dialog.cc
   A /trunk/src/chrome/browser/repost_form_warning_dialog.h
   A /trunk/src/chrome/browser/resource_dispatcher_host.cc
   A /trunk/src/chrome/browser/resource_dispatcher_host.h
   A /trunk/src/chrome/browser/resource_dispatcher_host_uitest.cc
   A /trunk/src/chrome/browser/resource_dispatcher_host_unittest.cc
   A /trunk/src/chrome/browser/resource_message_filter.cc
   A /trunk/src/chrome/browser/resource_message_filter.h
   A /trunk/src/chrome/browser/resource_request_details.h
   A /trunk/src/chrome/browser/resources
   A /trunk/src/chrome/browser/resources/about_memory.html
   A /trunk/src/chrome/browser/resources/about_plugins.html
   A /trunk/src/chrome/browser/resources/about_stats.html
   A /trunk/src/chrome/browser/resources/about_version.html
   A /trunk/src/chrome/browser/resources/browser_resources.vcproj
   A /trunk/src/chrome/browser/resources/debugger_shell.js
   A /trunk/src/chrome/browser/resources/gear.png
   A /trunk/src/chrome/browser/resources/help.gif
   A /trunk/src/chrome/browser/resources/incognito_tab.html
   A /trunk/src/chrome/browser/resources/new_tab.html
   A /trunk/src/chrome/browser/resources/phishing_icon.png
   A /trunk/src/chrome/browser/resources/safe_browsing_malware_block.html
   A /trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html
   A /trunk/src/chrome/browser/resources/ssl_error.html
   A /trunk/src/chrome/browser/rlz
   A /trunk/src/chrome/browser/rlz/rlz.cc
   A /trunk/src/chrome/browser/rlz/rlz.h
   A /trunk/src/chrome/browser/rlz/rlz_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing
   A /trunk/src/chrome/browser/safe_browsing/bloom_filter.cc
   A /trunk/src/chrome/browser/safe_browsing/bloom_filter.h
   A /trunk/src/chrome/browser/safe_browsing/bloom_filter_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/chunk_range.cc
   A /trunk/src/chrome/browser/safe_browsing/chunk_range.h
   A /trunk/src/chrome/browser/safe_browsing/chunk_range_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/database_perftest.cc
   A /trunk/src/chrome/browser/safe_browsing/protocol_manager.cc
   A /trunk/src/chrome/browser/safe_browsing/protocol_manager.h
   A /trunk/src/chrome/browser/safe_browsing/protocol_manager_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/protocol_parser.cc
   A /trunk/src/chrome/browser/safe_browsing/protocol_parser.h
   A /trunk/src/chrome/browser/safe_browsing/protocol_parser_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.cc
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_util.h
   A /trunk/src/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
   A /trunk/src/chrome/browser/sandbox_policy.cc
   A /trunk/src/chrome/browser/sandbox_policy.h
   A /trunk/src/chrome/browser/sanity_uitest.cc
   A /trunk/src/chrome/browser/save_file.cc
   A /trunk/src/chrome/browser/save_file.h
   A /trunk/src/chrome/browser/save_file_manager.cc
   A /trunk/src/chrome/browser/save_file_manager.h
   A /trunk/src/chrome/browser/save_item.cc
   A /trunk/src/chrome/browser/save_item.h
   A /trunk/src/chrome/browser/save_package.cc
   A /trunk/src/chrome/browser/save_package.h
   A /trunk/src/chrome/browser/save_package_unittest.cc
   A /trunk/src/chrome/browser/save_page_model.cc
   A /trunk/src/chrome/browser/save_page_model.h
   A /trunk/src/chrome/browser/save_page_uitest.cc
   A /trunk/src/chrome/browser/save_types.h
   A /trunk/src/chrome/browser/security
   A /trunk/src/chrome/browser/security/resources
   A /trunk/src/chrome/browser/security/resources/ssl_error.html
   A /trunk/src/chrome/browser/security/resources/ssl_roadblock.html
   A /trunk/src/chrome/browser/security/resources/ssl_roadblock_background.png
   A /trunk/src/chrome/browser/security/resources/ssl_roadblock_icon.png
   A /trunk/src/chrome/browser/security/resources/twisty_closed.png
   A /trunk/src/chrome/browser/security/resources/twisty_closed_rtl.png
   A /trunk/src/chrome/browser/security/resources/twisty_open.png
   A /trunk/src/chrome/browser/security_style.h
   A /trunk/src/chrome/browser/session_backend.cc
   A /trunk/src/chrome/browser/session_backend.h
   A /trunk/src/chrome/browser/session_backend_unittest.cc
   A /trunk/src/chrome/browser/session_crashed_view.cc
   A /trunk/src/chrome/browser/session_crashed_view.h
   A /trunk/src/chrome/browser/session_history_uitest.cc
   A /trunk/src/chrome/browser/session_restore.cc
   A /trunk/src/chrome/browser/session_restore.h
   A /trunk/src/chrome/browser/session_restore_uitest.cc
   A /trunk/src/chrome/browser/session_service.cc
   A /trunk/src/chrome/browser/session_service.h
   A /trunk/src/chrome/browser/session_service_test_helper.cc
   A /trunk/src/chrome/browser/session_service_test_helper.h
   A /trunk/src/chrome/browser/session_service_unittest.cc
   A /trunk/src/chrome/browser/session_startup_pref.cc
   A /trunk/src/chrome/browser/session_startup_pref.h
   A /trunk/src/chrome/browser/shell
   A /trunk/src/chrome/browser/shell_dialogs.h
   A /trunk/src/chrome/browser/shell_integration.cc
   A /trunk/src/chrome/browser/shell_integration.h
   A /trunk/src/chrome/browser/simple_vista_frame.cc
   A /trunk/src/chrome/browser/simple_vista_frame.h
   A /trunk/src/chrome/browser/simple_xp_frame.cc
   A /trunk/src/chrome/browser/simple_xp_frame.h
   A /trunk/src/chrome/browser/site_instance.cc
   A /trunk/src/chrome/browser/site_instance.h
   A /trunk/src/chrome/browser/site_instance_unittest.cc
   A /trunk/src/chrome/browser/spellcheck_worditerator.cc
   A /trunk/src/chrome/browser/spellcheck_worditerator.h
   A /trunk/src/chrome/browser/spellchecker.cc
   A /trunk/src/chrome/browser/spellchecker.h
   A /trunk/src/chrome/browser/ssl_blocking_page.cc
   A /trunk/src/chrome/browser/ssl_blocking_page.h
   A /trunk/src/chrome/browser/ssl_error_info.cc
   A /trunk/src/chrome/browser/ssl_error_info.h
   A /trunk/src/chrome/browser/ssl_manager.cc
   A /trunk/src/chrome/browser/ssl_manager.h
   A /trunk/src/chrome/browser/ssl_policy.cc
   A /trunk/src/chrome/browser/ssl_policy.h
   A /trunk/src/chrome/browser/ssl_uitest.cc
   A /trunk/src/chrome/browser/standard_layout.h
   A /trunk/src/chrome/browser/status_view.cc
   A /trunk/src/chrome/browser/status_view.h
   A /trunk/src/chrome/browser/suspend_controller.cc
   A /trunk/src/chrome/browser/suspend_controller.h
   A /trunk/src/chrome/browser/tab_contents.cc
   A /trunk/src/chrome/browser/tab_contents.h
   A /trunk/src/chrome/browser/tab_contents_container_view.cc
   A /trunk/src/chrome/browser/tab_contents_container_view.h
   A /trunk/src/chrome/browser/tab_contents_delegate.h
   A /trunk/src/chrome/browser/tab_contents_factory.cc
   A /trunk/src/chrome/browser/tab_contents_factory.h
   A /trunk/src/chrome/browser/tab_contents_type.h
   A /trunk/src/chrome/browser/tab_restore_service.cc
   A /trunk/src/chrome/browser/tab_restore_service.h
   A /trunk/src/chrome/browser/tab_restore_uitest.cc
   A /trunk/src/chrome/browser/tab_util.cc
   A /trunk/src/chrome/browser/tab_util.h
   A /trunk/src/chrome/browser/tabs
   A /trunk/src/chrome/browser/tabs/dragged_tab_controller.cc
   A /trunk/src/chrome/browser/tabs/dragged_tab_controller.h
   A /trunk/src/chrome/browser/tabs/dragged_tab_view.cc
   A /trunk/src/chrome/browser/tabs/dragged_tab_view.h
   A /trunk/src/chrome/browser/tabs/hwnd_photobooth.cc
   A /trunk/src/chrome/browser/tabs/hwnd_photobooth.h
   A /trunk/src/chrome/browser/tabs/tab.cc
   A /trunk/src/chrome/browser/tabs/tab.h
   A /trunk/src/chrome/browser/tabs/tab_renderer.cc
   A /trunk/src/chrome/browser/tabs/tab_renderer.h
   A /trunk/src/chrome/browser/tabs/tab_strip.cc
   A /trunk/src/chrome/browser/tabs/tab_strip.h
   A /trunk/src/chrome/browser/tabs/tab_strip_model.cc
   A /trunk/src/chrome/browser/tabs/tab_strip_model.h
   A /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc
   A /trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.h
   A /trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc
   A /trunk/src/chrome/browser/task_manager.cc
   A /trunk/src/chrome/browser/task_manager.h
   A /trunk/src/chrome/browser/task_manager_resource_providers.cc
   A /trunk/src/chrome/browser/task_manager_resource_providers.h
   A /trunk/src/chrome/browser/template_url.cc
   A /trunk/src/chrome/browser/template_url.h
   A /trunk/src/chrome/browser/template_url_fetcher.cc
   A /trunk/src/chrome/browser/template_url_fetcher.h
   A /trunk/src/chrome/browser/template_url_model.cc
   A /trunk/src/chrome/browser/template_url_model.h
   A /trunk/src/chrome/browser/template_url_model_unittest.cc
   A /trunk/src/chrome/browser/template_url_parser.cc
   A /trunk/src/chrome/browser/template_url_parser.h
   A /trunk/src/chrome/browser/template_url_parser_unittest.cc
   A /trunk/src/chrome/browser/template_url_prepopulate_data.cc
   A /trunk/src/chrome/browser/template_url_prepopulate_data.h
   A /trunk/src/chrome/browser/template_url_unittest.cc
   A /trunk/src/chrome/browser/title_chomper.cc
   A /trunk/src/chrome/browser/title_chomper.h
   A /trunk/src/chrome/browser/title_chomper_unittest.cc
   A /trunk/src/chrome/browser/toolbar_model.cc
   A /trunk/src/chrome/browser/toolbar_model.h
   A /trunk/src/chrome/browser/url_fetcher.cc
   A /trunk/src/chrome/browser/url_fetcher.h
   A /trunk/src/chrome/browser/url_fetcher_protect.cc
   A /trunk/src/chrome/browser/url_fetcher_protect.h
   A /trunk/src/chrome/browser/url_fetcher_unittest.cc
   A /trunk/src/chrome/browser/url_fixer_upper.cc
   A /trunk/src/chrome/browser/url_fixer_upper.h
   A /trunk/src/chrome/browser/url_fixer_upper_unittest.cc
   A /trunk/src/chrome/browser/user_data_dir_dialog.cc
   A /trunk/src/chrome/browser/user_data_dir_dialog.h
   A /trunk/src/chrome/browser/user_metrics.cc
   A /trunk/src/chrome/browser/user_metrics.h
   A /trunk/src/chrome/browser/view_ids.h
   A /trunk/src/chrome/browser/view_source_contents.cc
   A /trunk/src/chrome/browser/view_source_contents.h
   A /trunk/src/chrome/browser/view_source_uitest.cc
   A /trunk/src/chrome/browser/views
   A /trunk/src/chrome/browser/views/about_chrome_view.cc
   A /trunk/src/chrome/browser/views/about_chrome_view.h
   A /trunk/src/chrome/browser/views/bookmark_bar_view.cc
   A /trunk/src/chrome/browser/views/bookmark_bar_view.h
   A /trunk/src/chrome/browser/views/bookmark_bubble_view.cc
   A /trunk/src/chrome/browser/views/bookmark_bubble_view.h
   A /trunk/src/chrome/browser/views/bookmark_editor_view.cc
   A /trunk/src/chrome/browser/views/bookmark_editor_view.h
   A /trunk/src/chrome/browser/views/bug_report_view.cc
   A /trunk/src/chrome/browser/views/bug_report_view.h
   A /trunk/src/chrome/browser/views/clear_browsing_data.cc
   A /trunk/src/chrome/browser/views/clear_browsing_data.h
   A /trunk/src/chrome/browser/views/constrained_window_animation.cc
   A /trunk/src/chrome/browser/views/constrained_window_animation.h
   A /trunk/src/chrome/browser/views/constrained_window_impl.cc
   A /trunk/src/chrome/browser/views/constrained_window_impl.h
   A /trunk/src/chrome/browser/views/constrained_window_impl_interactive_uitest.cc
   A /trunk/src/chrome/browser/views/delay_view.cc
   A /trunk/src/chrome/browser/views/delay_view.h
   A /trunk/src/chrome/browser/views/dom_view.h
   A /trunk/src/chrome/browser/views/download_item_view.cc
   A /trunk/src/chrome/browser/views/download_item_view.h
   A /trunk/src/chrome/browser/views/download_shelf_view.cc
   A /trunk/src/chrome/browser/views/download_shelf_view.h
   A /trunk/src/chrome/browser/views/download_started_animation.cc
   A /trunk/src/chrome/browser/views/download_started_animation.h
   A /trunk/src/chrome/browser/views/edit_keyword_controller.cc
   A /trunk/src/chrome/browser/views/edit_keyword_controller.h
   A /trunk/src/chrome/browser/views/event_utils.cc
   A /trunk/src/chrome/browser/views/event_utils.h
   A /trunk/src/chrome/browser/views/first_run_bubble.cc
   A /trunk/src/chrome/browser/views/first_run_bubble.h
   A /trunk/src/chrome/browser/views/first_run_customize_view.cc
   A /trunk/src/chrome/browser/views/first_run_customize_view.h
   A /trunk/src/chrome/browser/views/first_run_view.cc
   A /trunk/src/chrome/browser/views/first_run_view.h
   A /trunk/src/chrome/browser/views/first_run_view_base.cc
   A /trunk/src/chrome/browser/views/first_run_view_base.h
   A /trunk/src/chrome/browser/views/go_button.cc
   A /trunk/src/chrome/browser/views/go_button.h
   A /trunk/src/chrome/browser/views/html_dialog_view.cc
   A /trunk/src/chrome/browser/views/html_dialog_view.h
   A /trunk/src/chrome/browser/views/hung_renderer_view.cc
   A /trunk/src/chrome/browser/views/hung_renderer_view.h
   A /trunk/src/chrome/browser/views/importer_lock_view.cc
   A /trunk/src/chrome/browser/views/importer_lock_view.h
   A /trunk/src/chrome/browser/views/importer_view.cc
   A /trunk/src/chrome/browser/views/importer_view.h
   A /trunk/src/chrome/browser/views/importing_progress_view.cc
   A /trunk/src/chrome/browser/views/importing_progress_view.h
   A /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.cc
   A /trunk/src/chrome/browser/views/info_bar_alternate_nav_url_view.h
   A /trunk/src/chrome/browser/views/info_bar_confirm_view.cc
   A /trunk/src/chrome/browser/views/info_bar_confirm_view.h
   A /trunk/src/chrome/browser/views/info_bar_item_view.cc
   A /trunk/src/chrome/browser/views/info_bar_item_view.h
   A /trunk/src/chrome/browser/views/info_bar_message_view.cc
   A /trunk/src/chrome/browser/views/info_bar_message_view.h
   A /trunk/src/chrome/browser/views/info_bar_view.cc
   A /trunk/src/chrome/browser/views/info_bar_view.h
   A /trunk/src/chrome/browser/views/info_bubble.cc
   A /trunk/src/chrome/browser/views/info_bubble.h
   A /trunk/src/chrome/browser/views/input_window.cc
   A /trunk/src/chrome/browser/views/input_window.h
   A /trunk/src/chrome/browser/views/keyword_editor_view.cc
   A /trunk/src/chrome/browser/views/keyword_editor_view.h
   A /trunk/src/chrome/browser/views/location_bar_view.cc
   A /trunk/src/chrome/browser/views/location_bar_view.h
   A /trunk/src/chrome/browser/views/login_view.cc
   A /trunk/src/chrome/browser/views/login_view.h
   A /trunk/src/chrome/browser/views/options
   A /trunk/src/chrome/browser/views/options/advanced_contents_view.cc
   A /trunk/src/chrome/browser/views/options/advanced_contents_view.h
   A /trunk/src/chrome/browser/views/options/advanced_page_view.cc
   A /trunk/src/chrome/browser/views/options/advanced_page_view.h
   A /trunk/src/chrome/browser/views/options/content_page_view.cc
   A /trunk/src/chrome/browser/views/options/content_page_view.h
   A /trunk/src/chrome/browser/views/options/cookies_view.cc
   A /trunk/src/chrome/browser/views/options/cookies_view.h
   A /trunk/src/chrome/browser/views/options/fonts_languages_window_view.cc
   A /trunk/src/chrome/browser/views/options/fonts_languages_window_view.h
   A /trunk/src/chrome/browser/views/options/fonts_page_view.cc
   A /trunk/src/chrome/browser/views/options/fonts_page_view.h
   A /trunk/src/chrome/browser/views/options/general_page_view.cc
   A /trunk/src/chrome/browser/views/options/general_page_view.h
   A /trunk/src/chrome/browser/views/options/language_combobox_model.cc
   A /trunk/src/chrome/browser/views/options/language_combobox_model.h
   A /trunk/src/chrome/browser/views/options/languages_page_view.cc
   A /trunk/src/chrome/browser/views/options/languages_page_view.h
   A /trunk/src/chrome/browser/views/options/options_group_view.cc
   A /trunk/src/chrome/browser/views/options/options_group_view.h
   A /trunk/src/chrome/browser/views/options/options_page_view.cc
   A /trunk/src/chrome/browser/views/options/options_page_view.h
   A /trunk/src/chrome/browser/views/options/options_window_view.cc
   A /trunk/src/chrome/browser/views/password_manager_view.cc
   A /trunk/src/chrome/browser/views/password_manager_view.h
   A /trunk/src/chrome/browser/views/restart_message_box.cc
   A /trunk/src/chrome/browser/views/restart_message_box.h
   A /trunk/src/chrome/browser/views/sad_tab_view.cc
   A /trunk/src/chrome/browser/views/sad_tab_view.h
   A /trunk/src/chrome/browser/views/shelf_item_dialog.cc
   A /trunk/src/chrome/browser/views/shelf_item_dialog.h
   A /trunk/src/chrome/browser/views/shell_dialogs.cc
   A /trunk/src/chrome/browser/views/star_toggle.cc
   A /trunk/src/chrome/browser/views/star_toggle.h
   A /trunk/src/chrome/browser/views/status_bubble.cc
   A /trunk/src/chrome/browser/views/status_bubble.h
   A /trunk/src/chrome/browser/views/tab_icon_view.cc
   A /trunk/src/chrome/browser/views/tab_icon_view.h
   A /trunk/src/chrome/browser/views/theme_helpers.cc
   A /trunk/src/chrome/browser/views/theme_helpers.h
   A /trunk/src/chrome/browser/views/toolbar_star_toggle.cc
   A /trunk/src/chrome/browser/views/toolbar_star_toggle.h
   A /trunk/src/chrome/browser/views/toolbar_view.cc
   A /trunk/src/chrome/browser/views/toolbar_view.h
   A /trunk/src/chrome/browser/visitedlink_master.cc
   A /trunk/src/chrome/browser/visitedlink_master.h
   A /trunk/src/chrome/browser/visitedlink_perftest.cc
   A /trunk/src/chrome/browser/visitedlink_unittest.cc
   A /trunk/src/chrome/browser/vista_frame.cc
   A /trunk/src/chrome/browser/vista_frame.h
   A /trunk/src/chrome/browser/web_app.cc
   A /trunk/src/chrome/browser/web_app.h
   A /trunk/src/chrome/browser/web_app_icon_manager.cc
   A /trunk/src/chrome/browser/web_app_icon_manager.h
   A /trunk/src/chrome/browser/web_app_launcher.cc
   A /trunk/src/chrome/browser/web_app_launcher.h
   A /trunk/src/chrome/browser/web_contents.cc
   A /trunk/src/chrome/browser/web_contents.h
   A /trunk/src/chrome/browser/web_contents_unittest.cc
   A /trunk/src/chrome/browser/web_drag_source.cc
   A /trunk/src/chrome/browser/web_drag_source.h
   A /trunk/src/chrome/browser/web_drop_target.cc
   A /trunk/src/chrome/browser/web_drop_target.h
   A /trunk/src/chrome/browser/webdata
   A /trunk/src/chrome/browser/webdata/web_data_service.cc
   A /trunk/src/chrome/browser/webdata/web_data_service.h
   A /trunk/src/chrome/browser/webdata/web_database.cc
   A /trunk/src/chrome/browser/webdata/web_database.h
   A /trunk/src/chrome/browser/webdata/web_database_unittest.cc
   A /trunk/src/chrome/browser/window_clipping_info.cc
   A /trunk/src/chrome/browser/window_clipping_info.h
   A /trunk/src/chrome/browser/window_sizer.cc
   A /trunk/src/chrome/browser/window_sizer.h
   A /trunk/src/chrome/browser/window_sizer_unittest.cc
   A /trunk/src/chrome/browser/wizard
   A /trunk/src/chrome/browser/wizard/wizard.cc
   A /trunk/src/chrome/browser/wizard/wizard.h
   A /trunk/src/chrome/browser/wizard/wizard_step.h
   A /trunk/src/chrome/browser/xp_frame.cc
   A /trunk/src/chrome/browser/xp_frame.h
   A /trunk/src/chrome/chrome.ib_ini
   A /trunk/src/chrome/chrome.sln
   A /trunk/src/chrome/chrome_kjs.sln
   A /trunk/src/chrome/chrome_kjs.xcodeproj
   A /trunk/src/chrome/chrome_kjs.xcodeproj/project.pbxproj
   A /trunk/src/chrome/common
   A /trunk/src/chrome/common/SConscript
   A /trunk/src/chrome/common/animation.cc
   A /trunk/src/chrome/common/animation.h
   A /trunk/src/chrome/common/animation_unittest.cc
   A /trunk/src/chrome/common/bzip2_unittest.cc
   A /trunk/src/chrome/common/child_process.cc
   A /trunk/src/chrome/common/child_process.h
   A /trunk/src/chrome/common/chrome_constants.cc
   A /trunk/src/chrome/common/chrome_constants.h
   A /trunk/src/chrome/common/chrome_counters.cc
   A /trunk/src/chrome/common/chrome_counters.h
   A /trunk/src/chrome/common/chrome_paths.cc
   A /trunk/src/chrome/common/chrome_paths.h
   A /trunk/src/chrome/common/chrome_plugin_api.h
   A /trunk/src/chrome/common/chrome_plugin_lib.cc
   A /trunk/src/chrome/common/chrome_plugin_lib.h
   A /trunk/src/chrome/common/chrome_plugin_unittest.cc
   A /trunk/src/chrome/common/chrome_plugin_util.cc
   A /trunk/src/chrome/common/chrome_plugin_util.h
   A /trunk/src/chrome/common/chrome_process_filter.cc
   A /trunk/src/chrome/common/chrome_process_filter.h
   A /trunk/src/chrome/common/chrome_switches.cc
   A /trunk/src/chrome/common/chrome_switches.h
   A /trunk/src/chrome/common/classfactory.cc
   A /trunk/src/chrome/common/classfactory.h
   A /trunk/src/chrome/common/clipboard_service.cc
   A /trunk/src/chrome/common/clipboard_service.h
   A /trunk/src/chrome/common/common.vcproj
   A /trunk/src/chrome/common/common.vsprops
   A /trunk/src/chrome/common/common_resources.h
   A /trunk/src/chrome/common/common_resources.rc
   A /trunk/src/chrome/common/debug_flags.cc
   A /trunk/src/chrome/common/debug_flags.h
   A /trunk/src/chrome/common/drag_drop_types.cc
   A /trunk/src/chrome/common/drag_drop_types.h
   A /trunk/src/chrome/common/env_util.cc
   A /trunk/src/chrome/common/env_util.h
   A /trunk/src/chrome/common/env_vars.cc
   A /trunk/src/chrome/common/env_vars.h
   A /trunk/src/chrome/common/filter_policy.h
   A /trunk/src/chrome/common/gears_api.h
   A /trunk/src/chrome/common/gfx
   A /trunk/src/chrome/common/gfx/chrome_canvas.cc
   A /trunk/src/chrome/common/gfx/chrome_canvas.h
   A /trunk/src/chrome/common/gfx/chrome_font.cc
   A /trunk/src/chrome/common/gfx/chrome_font.h
   A /trunk/src/chrome/common/gfx/color_utils.cc
   A /trunk/src/chrome/common/gfx/color_utils.h
   A /trunk/src/chrome/common/gfx/emf.cc
   A /trunk/src/chrome/common/gfx/emf.h
   A /trunk/src/chrome/common/gfx/emf_unittest.cc
   A /trunk/src/chrome/common/gfx/favicon_size.h
   A /trunk/src/chrome/common/gfx/icon_util.cc
   A /trunk/src/chrome/common/gfx/icon_util.h
   A /trunk/src/chrome/common/gfx/icon_util_unittest.cc
   A /trunk/src/chrome/common/gfx/insets.h
   A /trunk/src/chrome/common/gfx/path.cc
   A /trunk/src/chrome/common/gfx/path.h
   A /trunk/src/chrome/common/gfx/url_elider.cc
   A /trunk/src/chrome/common/gfx/url_elider.h
   A /trunk/src/chrome/common/gfx/url_elider_unittest.cc
   A /trunk/src/chrome/common/gfx/utils.h
   A /trunk/src/chrome/common/ipc_channel.cc
   A /trunk/src/chrome/common/ipc_channel.h
   A /trunk/src/chrome/common/ipc_channel_proxy.cc
   A /trunk/src/chrome/common/ipc_channel_proxy.h
   A /trunk/src/chrome/common/ipc_fuzzing_tests.cc
   A /trunk/src/chrome/common/ipc_logging.cc
   A /trunk/src/chrome/common/ipc_logging.h
   A /trunk/src/chrome/common/ipc_message.cc
   A /trunk/src/chrome/common/ipc_message.h
   A /trunk/src/chrome/common/ipc_message_macros.h
   A /trunk/src/chrome/common/ipc_message_unittest.cc
   A /trunk/src/chrome/common/ipc_message_utils.h
   A /trunk/src/chrome/common/ipc_sync_channel.cc
   A /trunk/src/chrome/common/ipc_sync_channel.h
   A /trunk/src/chrome/common/ipc_sync_channel_unittest.cc
   A /trunk/src/chrome/common/ipc_sync_channel_unittest.h
   A /trunk/src/chrome/common/ipc_sync_message.cc
   A /trunk/src/chrome/common/ipc_sync_message.h
   A /trunk/src/chrome/common/ipc_sync_message_unittest.cc
   A /trunk/src/chrome/common/ipc_sync_message_unittest.h
   A /trunk/src/chrome/common/ipc_sync_sender.cc
   A /trunk/src/chrome/common/ipc_sync_sender.h
   A /trunk/src/chrome/common/ipc_tests.cc
   A /trunk/src/chrome/common/ipc_tests.h
   A /trunk/src/chrome/common/ipc_tests.vcproj
   A /trunk/src/chrome/common/jpeg_codec.cc
   A /trunk/src/chrome/common/jpeg_codec.h
   A /trunk/src/chrome/common/jpeg_codec_unittest.cc
   A /trunk/src/chrome/common/json_value_serializer.cc
   A /trunk/src/chrome/common/json_value_serializer.h
   A /trunk/src/chrome/common/json_value_serializer_perftest.cc
   A /trunk/src/chrome/common/json_value_serializer_unittest.cc
   A /trunk/src/chrome/common/jstemplate_builder.cc
   A /trunk/src/chrome/common/jstemplate_builder.h
   A /trunk/src/chrome/common/l10n_util.cc
   A /trunk/src/chrome/common/l10n_util.h
   A /trunk/src/chrome/common/l10n_util_unittest.cc
   A /trunk/src/chrome/common/libxml_utils.cc
   A /trunk/src/chrome/common/libxml_utils.h
   A /trunk/src/chrome/common/logging_chrome.cc
   A /trunk/src/chrome/common/logging_chrome.h
   A /trunk/src/chrome/common/logging_chrome_uitest.cc
   A /trunk/src/chrome/common/message_router.cc
   A /trunk/src/chrome/common/message_router.h
   A /trunk/src/chrome/common/mru_cache.h
   A /trunk/src/chrome/common/mru_cache_unittest.cc
   A /trunk/src/chrome/common/navigation_types.h
   A /trunk/src/chrome/common/net
   A /trunk/src/chrome/common/net/cache_uitest.cc
   A /trunk/src/chrome/common/net/cookie_monster_sqlite.cc
   A /trunk/src/chrome/common/net/cookie_monster_sqlite.h
   A /trunk/src/chrome/common/net/dns.h
   A /trunk/src/chrome/common/net/url_request_intercept_job.cc
   A /trunk/src/chrome/common/net/url_request_intercept_job.h
   A /trunk/src/chrome/common/net/url_util_unittest.cc
   A /trunk/src/chrome/common/notification_details.h
   A /trunk/src/chrome/common/notification_service.cc
   A /trunk/src/chrome/common/notification_service.h
   A /trunk/src/chrome/common/notification_service_unittest.cc
   A /trunk/src/chrome/common/notification_source.h
   A /trunk/src/chrome/common/notification_types.h
   A /trunk/src/chrome/common/os_exchange_data.cc
   A /trunk/src/chrome/common/os_exchange_data.h
   A /trunk/src/chrome/common/os_exchange_data_unittest.cc
   A /trunk/src/chrome/common/page_transition_types.h
   A /trunk/src/chrome/common/plugin_messages.cc
   A /trunk/src/chrome/common/plugin_messages.h
   A /trunk/src/chrome/common/plugin_messages_internal.h
   A /trunk/src/chrome/common/pref_member.h
   A /trunk/src/chrome/common/pref_member_unittest.cc
   A /trunk/src/chrome/common/pref_names.cc
   A /trunk/src/chrome/common/pref_names.h
   A /trunk/src/chrome/common/pref_service.cc
   A /trunk/src/chrome/common/pref_service.h
   A /trunk/src/chrome/common/pref_service_uitest.cc
   A /trunk/src/chrome/common/pref_service_unittest.cc
   A /trunk/src/chrome/common/process_watcher.cc
   A /trunk/src/chrome/common/process_watcher.h
   A /trunk/src/chrome/common/rand_util.cc
   A /trunk/src/chrome/common/rand_util.h
   A /trunk/src/chrome/common/ref_counted_util.h
   A /trunk/src/chrome/common/render_messages.cc
   A /trunk/src/chrome/common/render_messages.h
   A /trunk/src/chrome/common/render_messages_internal.h
   A /trunk/src/chrome/common/resource_bundle.cc
   A /trunk/src/chrome/common/resource_bundle.h
   A /trunk/src/chrome/common/resource_dispatcher.cc
   A /trunk/src/chrome/common/resource_dispatcher.h
   A /trunk/src/chrome/common/resource_dispatcher_unittest.cc
   A /trunk/src/chrome/common/scoped_vector.h
   A /trunk/src/chrome/common/security_filter_peer.cc
   A /trunk/src/chrome/common/security_filter_peer.h
   A /trunk/src/chrome/common/slide_animation.cc
   A /trunk/src/chrome/common/slide_animation.h
   A /trunk/src/chrome/common/sqlite_compiled_statement.cc
   A /trunk/src/chrome/common/sqlite_compiled_statement.h
   A /trunk/src/chrome/common/sqlite_utils.cc
   A /trunk/src/chrome/common/sqlite_utils.h
   A /trunk/src/chrome/common/stl_util-inl.h
   A /trunk/src/chrome/common/task_queue.cc
   A /trunk/src/chrome/common/task_queue.h
   A /trunk/src/chrome/common/text_zoom.h
   A /trunk/src/chrome/common/throb_animation.cc
   A /trunk/src/chrome/common/throb_animation.h
   A /trunk/src/chrome/common/thumbnail_score.cc
   A /trunk/src/chrome/common/thumbnail_score.h
   A /trunk/src/chrome/common/time_format.cc
   A /trunk/src/chrome/common/time_format.h
   A /trunk/src/chrome/common/time_format_unittest.cc
   A /trunk/src/chrome/common/visitedlink_common.cc
   A /trunk/src/chrome/common/visitedlink_common.h
   A /trunk/src/chrome/common/win_safe_util.cc
   A /trunk/src/chrome/common/win_safe_util.h
   A /trunk/src/chrome/common/win_util.cc
   A /trunk/src/chrome/common/win_util.h
   A /trunk/src/chrome/common/win_util_unittest.cc
   A /trunk/src/chrome/common/worker_thread_ticker.cc
   A /trunk/src/chrome/common/worker_thread_ticker.h
   A /trunk/src/chrome/installer
   A /trunk/src/chrome/installer/mini_installer
   A /trunk/src/chrome/installer/mini_installer/SConscript
   A /trunk/src/chrome/installer/mini_installer/chrome.release
   A /trunk/src/chrome/installer/mini_installer/mini_installer.cc
   A /trunk/src/chrome/installer/mini_installer/mini_installer.exe.manifest
   A /trunk/src/chrome/installer/mini_installer/mini_installer.h
   A /trunk/src/chrome/installer/mini_installer/mini_installer.ico
   A /trunk/src/chrome/installer/mini_installer/mini_installer.rc
   A /trunk/src/chrome/installer/mini_installer/mini_installer.vcproj
   A /trunk/src/chrome/installer/mini_installer/mini_installer.vsprops
   A /trunk/src/chrome/installer/mini_installer/mini_installer_debug.vsprops
   A /trunk/src/chrome/installer/mini_installer/mini_installer_exe_version.rc.version
   A /trunk/src/chrome/installer/mini_installer/mini_installer_release.vsprops
   A /trunk/src/chrome/installer/mini_installer/mini_installer_resource.h
   A /trunk/src/chrome/installer/mini_installer/pe_resource.cc
   A /trunk/src/chrome/installer/mini_installer/pe_resource.h
   A /trunk/src/chrome/installer/setup
   A /trunk/src/chrome/installer/setup/SConscript
   A /trunk/src/chrome/installer/setup/install.cc
   A /trunk/src/chrome/installer/setup/main.cc
   A /trunk/src/chrome/installer/setup/setup.cc
   A /trunk/src/chrome/installer/setup/setup.exe.manifest
   A /trunk/src/chrome/installer/setup/setup.h
   A /trunk/src/chrome/installer/setup/setup.ico
   A /trunk/src/chrome/installer/setup/setup.rc
   A /trunk/src/chrome/installer/setup/setup.vcproj
   A /trunk/src/chrome/installer/setup/setup.vsprops
   A /trunk/src/chrome/installer/setup/setup_constants.cc
   A /trunk/src/chrome/installer/setup/setup_constants.h
   A /trunk/src/chrome/installer/setup/setup_debug.vsprops
   A /trunk/src/chrome/installer/setup/setup_exe_version.rc.version
   A /trunk/src/chrome/installer/setup/setup_release.vsprops
   A /trunk/src/chrome/installer/setup/setup_resource.h
   A /trunk/src/chrome/installer/setup/uninstall.cc
   A /trunk/src/chrome/installer/setup/uninstall.h
   A /trunk/src/chrome/installer/util
   A /trunk/src/chrome/installer/util/SConscript
   A /trunk/src/chrome/installer/util/copy_tree_work_item.cc
   A /trunk/src/chrome/installer/util/copy_tree_work_item.h
   A /trunk/src/chrome/installer/util/copy_tree_work_item_unittest.cc
   A /trunk/src/chrome/installer/util/create_dir_work_item.cc
   A /trunk/src/chrome/installer/util/create_dir_work_item.h
   A /trunk/src/chrome/installer/util/create_dir_work_item_unittest.cc
   A /trunk/src/chrome/installer/util/create_reg_key_work_item.cc
   A /trunk/src/chrome/installer/util/create_reg_key_work_item.h
   A /trunk/src/chrome/installer/util/create_reg_key_work_item_unittest.cc
   A /trunk/src/chrome/installer/util/delete_tree_work_item.cc
   A /trunk/src/chrome/installer/util/delete_tree_work_item.h
   A /trunk/src/chrome/installer/util/delete_tree_work_item_unittest.cc
   A /trunk/src/chrome/installer/util/google_update_constants.cc
   A /trunk/src/chrome/installer/util/google_update_constants.h
   A /trunk/src/chrome/installer/util/helper.cc
   A /trunk/src/chrome/installer/util/helper.h
   A /trunk/src/chrome/installer/util/helper_unittest.cc
   A /trunk/src/chrome/installer/util/install_util.cc
   A /trunk/src/chrome/installer/util/install_util.h
   A /trunk/src/chrome/installer/util/install_util_unittest.cc
   A /trunk/src/chrome/installer/util/installer_unittests.vcproj
   A /trunk/src/chrome/installer/util/l10n_string_util.cc
   A /trunk/src/chrome/installer/util/l10n_string_util.h
   A /trunk/src/chrome/installer/util/logging_installer.cc
   A /trunk/src/chrome/installer/util/logging_installer.h
   A /trunk/src/chrome/installer/util/lzma_util.cc
   A /trunk/src/chrome/installer/util/lzma_util.h
   A /trunk/src/chrome/installer/util/prebuild
   A /trunk/src/chrome/installer/util/prebuild/create_string_rc.bat
   A /trunk/src/chrome/installer/util/prebuild/create_string_rc.py
   A /trunk/src/chrome/installer/util/prebuild/util_prebuild.vcproj
   A /trunk/src/chrome/installer/util/prebuild/util_prebuild.vsprops
   A /trunk/src/chrome/installer/util/run_all_unittests.cc
   A /trunk/src/chrome/installer/util/set_reg_value_work_item.cc
   A /trunk/src/chrome/installer/util/set_reg_value_work_item.h
   A /trunk/src/chrome/installer/util/set_reg_value_work_item_unittest.cc
   A /trunk/src/chrome/installer/util/shell_util.cc
   A /trunk/src/chrome/installer/util/shell_util.h
   A /trunk/src/chrome/installer/util/using_util.vsprops
   A /trunk/src/chrome/installer/util/util.vcproj
   A /trunk/src/chrome/installer/util/util_constants.cc
   A /trunk/src/chrome/installer/util/util_constants.h
   A /trunk/src/chrome/installer/util/version.cc
   A /trunk/src/chrome/installer/util/version.h
   A /trunk/src/chrome/installer/util/work_item.cc
   A /trunk/src/chrome/installer/util/work_item.h
   A /trunk/src/chrome/installer/util/work_item_list.cc
   A /trunk/src/chrome/installer/util/work_item_list.h
   A /trunk/src/chrome/installer/util/work_item_list_unittest.cc
   A /trunk/src/chrome/license.txt
   A /trunk/src/chrome/plugin
   A /trunk/src/chrome/plugin/SConscript
   A /trunk/src/chrome/plugin/chrome_plugin_host.cc
   A /trunk/src/chrome/plugin/chrome_plugin_host.h
   A /trunk/src/chrome/plugin/npobject_proxy.cc
   A /trunk/src/chrome/plugin/npobject_proxy.h
   A /trunk/src/chrome/plugin/npobject_stub.cc
   A /trunk/src/chrome/plugin/npobject_stub.h
   A /trunk/src/chrome/plugin/npobject_util.cc
   A /trunk/src/chrome/plugin/npobject_util.h
   A /trunk/src/chrome/plugin/plugin.vcproj
   A /trunk/src/chrome/plugin/plugin_channel.cc
   A /trunk/src/chrome/plugin/plugin_channel.h
   A /trunk/src/chrome/plugin/plugin_channel_base.cc
   A /trunk/src/chrome/plugin/plugin_channel_base.h
   A /trunk/src/chrome/plugin/plugin_main.cc
   A /trunk/src/chrome/plugin/plugin_process.cc
   A /trunk/src/chrome/plugin/plugin_process.h
   A /trunk/src/chrome/plugin/plugin_thread.cc
   A /trunk/src/chrome/plugin/plugin_thread.h
   A /trunk/src/chrome/plugin/webplugin_delegate_stub.cc
   A /trunk/src/chrome/plugin/webplugin_delegate_stub.h
   A /trunk/src/chrome/plugin/webplugin_proxy.cc
   A /trunk/src/chrome/plugin/webplugin_proxy.h
   A /trunk/src/chrome/renderer
   A /trunk/src/chrome/renderer/SConscript
   A /trunk/src/chrome/renderer/about_handler.cc
   A /trunk/src/chrome/renderer/about_handler.h
   A /trunk/src/chrome/renderer/automation
   A /trunk/src/chrome/renderer/automation/dom_automation_controller.cc
   A /trunk/src/chrome/renderer/automation/dom_automation_controller.h
   A /trunk/src/chrome/renderer/debug_message_handler.cc
   A /trunk/src/chrome/renderer/debug_message_handler.h
   A /trunk/src/chrome/renderer/dom_ui_bindings.cc
   A /trunk/src/chrome/renderer/dom_ui_bindings.h
   A /trunk/src/chrome/renderer/external_js_object.cc
   A /trunk/src/chrome/renderer/external_js_object.h
   A /trunk/src/chrome/renderer/localized_error.cc
   A /trunk/src/chrome/renderer/localized_error.h
   A /trunk/src/chrome/renderer/net
   A /trunk/src/chrome/renderer/net/render_dns_master.cc
   A /trunk/src/chrome/renderer/net/render_dns_master.h
   A /trunk/src/chrome/renderer/net/render_dns_master_unittest.cc
   A /trunk/src/chrome/renderer/net/render_dns_queue.cc
   A /trunk/src/chrome/renderer/net/render_dns_queue.h
   A /trunk/src/chrome/renderer/net/render_dns_queue_unittest.cc
   A /trunk/src/chrome/renderer/plugin_channel_host.cc
   A /trunk/src/chrome/renderer/plugin_channel_host.h
   A /trunk/src/chrome/renderer/render_process.cc
   A /trunk/src/chrome/renderer/render_process.h
   A /trunk/src/chrome/renderer/render_thread.cc
   A /trunk/src/chrome/renderer/render_thread.h
   A /trunk/src/chrome/renderer/render_view.cc
   A /trunk/src/chrome/renderer/render_view.h
   A /trunk/src/chrome/renderer/render_widget.cc
   A /trunk/src/chrome/renderer/render_widget.h
   A /trunk/src/chrome/renderer/renderer.vcproj
   A /trunk/src/chrome/renderer/renderer.vsprops
   A /trunk/src/chrome/renderer/renderer_glue.cc
   A /trunk/src/chrome/renderer/renderer_main.cc
   A /trunk/src/chrome/renderer/renderer_resources.h
   A /trunk/src/chrome/renderer/renderer_resources.rc
   A /trunk/src/chrome/renderer/resources
   A /trunk/src/chrome/renderer/resources/error_no_details.html
   A /trunk/src/chrome/renderer/resources/insecure_content_stamp.png
   A /trunk/src/chrome/renderer/resources/neterror.html
   A /trunk/src/chrome/renderer/spellcheck_unittest.cc
   A /trunk/src/chrome/renderer/visitedlink_slave.cc
   A /trunk/src/chrome/renderer/visitedlink_slave.h
   A /trunk/src/chrome/renderer/webplugin_delegate_proxy.cc
   A /trunk/src/chrome/renderer/webplugin_delegate_proxy.h
   A /trunk/src/chrome/test
   A /trunk/src/chrome/test/accessibility
   A /trunk/src/chrome/test/accessibility/accessibility_tests.cc
   A /trunk/src/chrome/test/accessibility/accessibility_util.cc
   A /trunk/src/chrome/test/accessibility/accessibility_util.h
   A /trunk/src/chrome/test/accessibility/browser_impl.cc
   A /trunk/src/chrome/test/accessibility/browser_impl.h
   A /trunk/src/chrome/test/accessibility/constants.h
   A /trunk/src/chrome/test/accessibility/keyboard_util.cc
   A /trunk/src/chrome/test/accessibility/keyboard_util.h
   A /trunk/src/chrome/test/accessibility/registry_util.cc
   A /trunk/src/chrome/test/accessibility/registry_util.h
   A /trunk/src/chrome/test/accessibility/tab_impl.cc
   A /trunk/src/chrome/test/accessibility/tab_impl.h
   A /trunk/src/chrome/test/activex_test_control
   A /trunk/src/chrome/test/activex_test_control/SConscript
   A /trunk/src/chrome/test/activex_test_control/activex_test_control.cc
   A /trunk/src/chrome/test/activex_test_control/activex_test_control.def
   A /trunk/src/chrome/test/activex_test_control/activex_test_control.idl
   A /trunk/src/chrome/test/activex_test_control/activex_test_control.rc
   A /trunk/src/chrome/test/activex_test_control/activex_test_control.rgs
   A /trunk/src/chrome/test/activex_test_control/activex_test_control.vcproj
   A /trunk/src/chrome/test/activex_test_control/activex_test_control.vsprops
   A /trunk/src/chrome/test/activex_test_control/chrome_test_control.bmp
   A /trunk/src/chrome/test/activex_test_control/chrome_test_control.cc
   A /trunk/src/chrome/test/activex_test_control/chrome_test_control.h
   A /trunk/src/chrome/test/activex_test_control/chrome_test_control.rgs
   A /trunk/src/chrome/test/activex_test_control/chrome_test_control_cp.h
   A /trunk/src/chrome/test/activex_test_control/resource.h
   A /trunk/src/chrome/test/automated_ui_tests
   A /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.cc
   A /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.h
   A /trunk/src/chrome/test/automated_ui_tests/automated_ui_tests.vcproj
   A /trunk/src/chrome/test/automation
   A /trunk/src/chrome/test/automation/SConscript
   A /trunk/src/chrome/test/automation/autocomplete_edit_proxy.cc
   A /trunk/src/chrome/test/automation/autocomplete_edit_proxy.h
   A /trunk/src/chrome/test/automation/automation.vcproj
   A /trunk/src/chrome/test/automation/automation.vsprops
   A /trunk/src/chrome/test/automation/automation_constants.h
   A /trunk/src/chrome/test/automation/automation_handle_tracker.cc
   A /trunk/src/chrome/test/automation/automation_handle_tracker.h
   A /trunk/src/chrome/test/automation/automation_messages.h
   A /trunk/src/chrome/test/automation/automation_messages_internal.h
   A /trunk/src/chrome/test/automation/automation_proxy.cc
   A /trunk/src/chrome/test/automation/automation_proxy.h
   A /trunk/src/chrome/test/automation/automation_proxy_uitest.cc
   A /trunk/src/chrome/test/automation/browser_proxy.cc
   A /trunk/src/chrome/test/automation/browser_proxy.h
   A /trunk/src/chrome/test/automation/constrained_window_proxy.cc
   A /trunk/src/chrome/test/automation/constrained_window_proxy.h
   A /trunk/src/chrome/test/automation/tab_proxy.cc
   A /trunk/src/chrome/test/automation/tab_proxy.h
   A /trunk/src/chrome/test/automation/ui_controls.cc
   A /trunk/src/chrome/test/automation/ui_controls.h
   A /trunk/src/chrome/test/automation/window_proxy.cc
   A /trunk/src/chrome/test/automation/window_proxy.h
   A /trunk/src/chrome/test/chrome_plugin
   A /trunk/src/chrome/test/chrome_plugin/SConscript
   A /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.cc
   A /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.def
   A /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.h
   A /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.vcproj
   A /trunk/src/chrome/test/chrome_plugin/test_chrome_plugin.vsprops
   A /trunk/src/chrome/test/data
   A /trunk/src/chrome/test/data/animate1.gif
   A /trunk/src/chrome/test/data/animate2.gif
   A /trunk/src/chrome/test/data/animate3.gif
   A /trunk/src/chrome/test/data/animated-gifs.html
   A /trunk/src/chrome/test/data/cancelled_redirect_test.html
   A /trunk/src/chrome/test/data/columns.html
   A /trunk/src/chrome/test/data/constrained_files
   A /trunk/src/chrome/test/data/constrained_files/constrained_window.html
   A /trunk/src/chrome/test/data/constrained_files/constrained_window_onload_moveto.html
   A /trunk/src/chrome/test/data/constrained_files/constrained_window_onload_resizeto.html
   A /trunk/src/chrome/test/data/constrained_files/target0.html
   A /trunk/src/chrome/test/data/constrained_files/target1.html
   A /trunk/src/chrome/test/data/constrained_files/target_onload_moveto.html
   A /trunk/src/chrome/test/data/constrained_files/target_onload_resizeto.html
   A /trunk/src/chrome/test/data/content-disposition-empty.html
   A /trunk/src/chrome/test/data/content-disposition-empty.html.mock-http-headers
   A /trunk/src/chrome/test/data/content-disposition-inline.html
   A /trunk/src/chrome/test/data/content-disposition-inline.html.mock-http-headers
   A /trunk/src/chrome/test/data/content-sniffer-test0.html
   A /trunk/src/chrome/test/data/content-sniffer-test0.html.mock-http-headers
   A /trunk/src/chrome/test/data/content-sniffer-test1.html
   A /trunk/src/chrome/test/data/content-sniffer-test1.html.mock-http-headers
   A /trunk/src/chrome/test/data/content-sniffer-test2.html
   A /trunk/src/chrome/test/data/content-sniffer-test2.html.mock-http-headers
   A /trunk/src/chrome/test/data/content-sniffer-test3-frame.txt
   A /trunk/src/chrome/test/data/content-sniffer-test3-frame.txt.mock-http-headers
   A /trunk/src/chrome/test/data/content-sniffer-test3.html
   A /trunk/src/chrome/test/data/content-sniffer-test3.html.mock-http-headers
   A /trunk/src/chrome/test/data/cookie1.html
   A /trunk/src/chrome/test/data/download-test1.lib
   A /trunk/src/chrome/test/data/download-test1.lib.mock-http-headers
   A /trunk/src/chrome/test/data/download-test2.html
   A /trunk/src/chrome/test/data/download-test2.html.mock-http-headers
   A /trunk/src/chrome/test/data/download-test3.html
   A /trunk/src/chrome/test/data/download-test3.html.mock-http-headers
   A /trunk/src/chrome/test/data/empty.html
   A /trunk/src/chrome/test/data/file_client_redirect.html
   A /trunk/src/chrome/test/data/find_in_page
   A /trunk/src/chrome/test/data/find_in_page/framedata_general.html
   A /trunk/src/chrome/test/data/find_in_page/framedata_left.html
   A /trunk/src/chrome/test/data/find_in_page/frames.html
   A /trunk/src/chrome/test/data/find_in_page/user-select.html
   A /trunk/src/chrome/test/data/firefox2_nss
   A /trunk/src/chrome/test/data/firefox2_nss/README
   A /trunk/src/chrome/test/data/firefox2_nss/freebl3.dll
   A /trunk/src/chrome/test/data/firefox2_nss/nspr4.dll
   A /trunk/src/chrome/test/data/firefox2_nss/nss3.dll
   A /trunk/src/chrome/test/data/firefox2_nss/plc4.dll
   A /trunk/src/chrome/test/data/firefox2_nss/plds4.dll
   A /trunk/src/chrome/test/data/firefox2_nss/softokn3.dll
   A /trunk/src/chrome/test/data/firefox2_profile
   A /trunk/src/chrome/test/data/firefox2_profile/bookmarks.html
   A /trunk/src/chrome/test/data/firefox2_profile/cert8.db
   A /trunk/src/chrome/test/data/firefox2_profile/cookies.txt
   A /trunk/src/chrome/test/data/firefox2_profile/history.dat
   A /trunk/src/chrome/test/data/firefox2_profile/key3.db
   A /trunk/src/chrome/test/data/firefox2_profile/prefs.js
   A /trunk/src/chrome/test/data/firefox2_profile/signons2.txt
   A /trunk/src/chrome/test/data/firefox3_nss
   A /trunk/src/chrome/test/data/firefox3_nss/README
   A /trunk/src/chrome/test/data/firefox3_nss/freebl3.dll
   A /trunk/src/chrome/test/data/firefox3_nss/mozcrt19.dll
   A /trunk/src/chrome/test/data/firefox3_nss/nspr4.dll
   A /trunk/src/chrome/test/data/firefox3_nss/nss3.dll
   A /trunk/src/chrome/test/data/firefox3_nss/nssdbm3.dll
   A /trunk/src/chrome/test/data/firefox3_nss/nssutil3.dll
   A /trunk/src/chrome/test/data/firefox3_nss/plc4.dll
   A /trunk/src/chrome/test/data/firefox3_nss/plds4.dll
   A /trunk/src/chrome/test/data/firefox3_nss/softokn3.dll
   A /trunk/src/chrome/test/data/firefox3_nss/sqlite3.dll
   A /trunk/src/chrome/test/data/firefox3_profile
   A /trunk/src/chrome/test/data/firefox3_profile/cert8.db
   A /trunk/src/chrome/test/data/firefox3_profile/cookies.sqlite
   A /trunk/src/chrome/test/data/firefox3_profile/key3.db
   A /trunk/src/chrome/test/data/firefox3_profile/places.sqlite
   A /trunk/src/chrome/test/data/firefox3_profile/prefs.js
   A /trunk/src/chrome/test/data/firefox3_profile/search.sqlite
   A /trunk/src/chrome/test/data/firefox3_profile/secmod.db
   A /trunk/src/chrome/test/data/firefox3_profile/signons3.txt
   A /trunk/src/chrome/test/data/focus
   A /trunk/src/chrome/test/data/focus/page_steals_focus.html
   A /trunk/src/chrome/test/data/focus/page_with_focus.html
   A /trunk/src/chrome/test/data/focus/typical_page.html
   A /trunk/src/chrome/test/data/frame_dom_access
   A /trunk/src/chrome/test/data/frame_dom_access/frame_dom_access.html
   A /trunk/src/chrome/test/data/frame_dom_access/frame_level_1.html
   A /trunk/src/chrome/test/data/frame_dom_access/frame_level_2.html
   A /trunk/src/chrome/test/data/google
   A /trunk/src/chrome/test/data/google/google.html
   A /trunk/src/chrome/test/data/google/logo.gif
   A /trunk/src/chrome/test/data/google/x2.gif
   A /trunk/src/chrome/test/data/http_to_file.html
   A /trunk/src/chrome/test/data/icon_util
   A /trunk/src/chrome/test/data/icon_util/128_X_128_icon.ico
   A /trunk/src/chrome/test/data/icon_util/16_X_16_icon.ico
   A /trunk/src/chrome/test/data/ie@cookie[1].txt
   A /trunk/src/chrome/test/data/iframe.html
   A /trunk/src/chrome/test/data/iframe_in_empty_frame.html
   A /trunk/src/chrome/test/data/iframe_in_empty_frame.js
   A /trunk/src/chrome/test/data/inspector
   A /trunk/src/chrome/test/data/inspector/dummy.js
   A /trunk/src/chrome/test/data/inspector/test1.html
   A /trunk/src/chrome/test/data/inspector/test2.html
   A /trunk/src/chrome/test/data/interstitial_page
   A /trunk/src/chrome/test/data/interstitial_page/google.html
   A /trunk/src/chrome/test/data/interstitial_page/interstitial.html
   A /trunk/src/chrome/test/data/interstitial_page/logo.gif
   A /trunk/src/chrome/test/data/interstitial_page/shopping.html
   A /trunk/src/chrome/test/data/interstitial_page/shopping_files
   A /trunk/src/chrome/test/data/interstitial_page/shopping_files/froogle.css
   A /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp0.gif
   A /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp1.gif
   A /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp2.gif
   A /trunk/src/chrome/test/data/interstitial_page/shopping_files/hp3.gif
   A /trunk/src/chrome/test/data/interstitial_page/x2.gif
   A /trunk/src/chrome/test/data/npapi
   A /trunk/src/chrome/test/data/npapi/arguments.html
   A /trunk/src/chrome/test/data/npapi/execute_script_delete_in_npn_evaluate.html
   A /trunk/src/chrome/test/data/npapi/execute_script_delete_in_paint.html
   A /trunk/src/chrome/test/data/npapi/get_javascript_url.html
   A /trunk/src/chrome/test/data/npapi/geturl.html
   A /trunk/src/chrome/test/data/npapi/layout_test_plugin.html
   A /trunk/src/chrome/test/data/npapi/many_plugins.html
   A /trunk/src/chrome/test/data/npapi/new_fails.html
   A /trunk/src/chrome/test/data/npapi/npapi.js
   A /trunk/src/chrome/test/data/npapi/npobject_lifetime_test.html
   A /trunk/src/chrome/test/data/npapi/npobject_lifetime_test_second_instance.html
   A /trunk/src/chrome/test/data/npapi/npobject_proxy.html
   A /trunk/src/chrome/test/data/npapi/self_delete_plugin_geturl.html
   A /trunk/src/chrome/test/data/npapi/self_delete_plugin_invoke.html
   A /trunk/src/chrome/test/data/npapi/self_delete_plugin_stream.html
   A /trunk/src/chrome/test/data/npapi/verify_plugin_window_rect.html
   A /trunk/src/chrome/test/data/omnibox_tests.xml
   A /trunk/src/chrome/test/data/onunload_cookie.html
   A /trunk/src/chrome/test/data/pref_service
   A /trunk/src/chrome/test/data/pref_service/overlay.json
   A /trunk/src/chrome/test/data/pref_service/read.json
   A /trunk/src/chrome/test/data/pref_service/write.golden.json
   A /trunk/src/chrome/test/data/printing
   A /trunk/src/chrome/test/data/printing/alert_small.png
   A /trunk/src/chrome/test/data/printing/cleardot.gif
   A /trunk/src/chrome/test/data/printing/click_me.png
   A /trunk/src/chrome/test/data/printing/iframe.emf
   A /trunk/src/chrome/test/data/printing/iframe.htm
   A /trunk/src/chrome/test/data/printing/iframe.png
   A /trunk/src/chrome/test/data/printing/popup_delayed_print.emf
   A /trunk/src/chrome/test/data/printing/popup_delayed_print.htm
   A /trunk/src/chrome/test/data/printing/popup_delayed_print.png
   A /trunk/src/chrome/test/data/printing/popup_delayed_print_child.htm
   A /trunk/src/chrome/test/data/printing/sadtab.png
   A /trunk/src/chrome/test/data/printing/test1.emf
   A /trunk/src/chrome/test/data/printing/test1.html
   A /trunk/src/chrome/test/data/printing/test1.png
   A /trunk/src/chrome/test/data/printing/test1_cleartype.png
   A /trunk/src/chrome/test/data/printing/test2.emf
   A /trunk/src/chrome/test/data/printing/test2.html
   A /trunk/src/chrome/test/data/printing/test2.png
   A /trunk/src/chrome/test/data/printing/test3.emf
   A /trunk/src/chrome/test/data/printing/test3.html
   A /trunk/src/chrome/test/data/printing/test3.png
   A /trunk/src/chrome/test/data/printing/test4.emf
   A /trunk/src/chrome/test/data/printing/test4.html
   A /trunk/src/chrome/test/data/printing/test4.png
   A /trunk/src/chrome/test/data/printing/test5.emf
   A /trunk/src/chrome/test/data/printing/test5.html
   A /trunk/src/chrome/test/data/printing/test5.png
   A /trunk/src/chrome/test/data/profiles
   A /trunk/src/chrome/test/data/profiles/chrome_prefs
   A /trunk/src/chrome/test/data/profiles/chrome_prefs/History
   A /trunk/src/chrome/test/data/profiles/chrome_prefs/Preferences
   A /trunk/src/chrome/test/data/profiles/sample
   A /trunk/src/chrome/test/data/profiles/sample/Full Text Index
   A /trunk/src/chrome/test/data/profiles/sample/History
   A /trunk/src/chrome/test/data/profiles/sample/Preferences
   A /trunk/src/chrome/test/data/profiles/sample/Thumbnails
   A /trunk/src/chrome/test/data/profiles/sample/Visited Links
   A /trunk/src/chrome/test/data/profiles/sample/Web Data
   A /trunk/src/chrome/test/data/profiles/typical_history
   A /trunk/src/chrome/test/data/profiles/typical_history/Default
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/Cookies
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/Full Text Index
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/History
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/Preferences
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/Thumbnails
   A /trunk/src/chrome/test/data/profiles/typical_history/Default/Visited Links
   A /trunk/src/chrome/test/data/profiles/typical_history/README.txt
   A /trunk/src/chrome/test/data/profiles/window_placement
   A /trunk/src/chrome/test/data/profiles/window_placement/Local State
   A /trunk/src/chrome/test/data/purify
   A /trunk/src/chrome/test/data/purify/ignore.txt
   A /trunk/src/chrome/test/data/purify/ipc_tests.exe_MLK.txt
   A /trunk/src/chrome/test/data/purify/ipc_tests.exe_UMR.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe.gtest.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe_FIM.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe_FIM_flakey.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe_IPR.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe_MLK.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe_MLK_flakey.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe_UMR.txt
   A /trunk/src/chrome/test/data/purify/unit_tests.exe_UMR_flakey.txt
   A /trunk/src/chrome/test/data/read_cookies.html
   A /trunk/src/chrome/test/data/ref_redirect.html
   A /trunk/src/chrome/test/data/resource.h
   A /trunk/src/chrome/test/data/resource.rc
   A /trunk/src/chrome/test/data/safe_browsing
   A /trunk/src/chrome/test/data/safe_browsing/download_update.py
   A /trunk/src/chrome/test/data/safe_browsing/initial
   A /trunk/src/chrome/test/data/safe_browsing/initial/000goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/001goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/002goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/003goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/004goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/005goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/006goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/007goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/008goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/009goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/010goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/011goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/012goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/013goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/014goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/015goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/016goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/017goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/018goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/019goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/020goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/021goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/022goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/023goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/024goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/025goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/026goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/027goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/028goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/029goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/030goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/031goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/032goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/033goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/034goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/035goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/036goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/037goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/038goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/039goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/040goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/041goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/042goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/043goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/044goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/045goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/046goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/047goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/initial/048goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/049goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/050goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/051goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/initial/052goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old
   A /trunk/src/chrome/test/data/safe_browsing/old/SafeBrowsing
   A /trunk/src/chrome/test/data/safe_browsing/old/postdata
   A /trunk/src/chrome/test/data/safe_browsing/old/response
   A /trunk/src/chrome/test/data/safe_browsing/old/updates
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/000goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/001goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/002goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/003goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/004goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/005goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/006goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/007goog-malware-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/008goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/009goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/010goog-malware-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/011goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/012goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/013goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/014goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/015goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/016goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/017goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/018goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/019goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/020goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/021goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/022goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/023goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/024goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/025goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/026goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/027goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/028goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/029goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/030goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/031goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/032goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/033goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/034goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/035goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/036goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/037goog-phish-shavar_s
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/038goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/039goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/040goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/041goog-phish-shavar_a
   A /trunk/src/chrome/test/data/safe_browsing/old/updates/042goog-phish-shavar_a
   A /trunk/src/chrome/test/data/save_page
   A /trunk/src/chrome/test/data/save_page/1.css
   A /trunk/src/chrome/test/data/save_page/1.png
   A /trunk/src/chrome/test/data/save_page/a.htm
   A /trunk/src/chrome/test/data/save_page/b.htm
   A /trunk/src/chrome/test/data/serializer_nested_test.js
   A /trunk/src/chrome/test/data/serializer_test.js
   A /trunk/src/chrome/test/data/serializer_test_nowhitespace.js
   A /trunk/src/chrome/test/data/server-unavailable.html
   A /trunk/src/chrome/test/data/server-unavailable.html.mock-http-headers
   A /trunk/src/chrome/test/data/session_history
   A /trunk/src/chrome/test/data/session_history/bot1.html
   A /trunk/src/chrome/test/data/session_history/bot2.html
   A /trunk/src/chrome/test/data/session_history/bot3.html
   A /trunk/src/chrome/test/data/session_history/form.html
   A /trunk/src/chrome/test/data/session_history/fragment.html
   A /trunk/src/chrome/test/data/session_history/frames.html
   A /trunk/src/chrome/test/data/session_history/no-title.html
   A /trunk/src/chrome/test/data/session_history/post.html
   A /trunk/src/chrome/test/data/session_history/replace.html
   A /trunk/src/chrome/test/data/session_history/top.html
   A /trunk/src/chrome/test/data/ssl
   A /trunk/src/chrome/test/data/ssl/bad_iframe.html
   A /trunk/src/chrome/test/data/ssl/google.html
   A /trunk/src/chrome/test/data/ssl/google_files
   A /trunk/src/chrome/test/data/ssl/google_files/logo.gif
   A /trunk/src/chrome/test/data/ssl/page_with_dynamic_mixed_contents.html
   A /trunk/src/chrome/test/data/ssl/page_with_mixed_contents.html
   A /trunk/src/chrome/test/data/ssl/page_with_refs.html
   A /trunk/src/chrome/test/data/ssl/page_with_unsafe_contents.html
   A /trunk/src/chrome/test/data/ssl/set_foo.js
   A /trunk/src/chrome/test/data/sync_xmlhttprequest.html
   A /trunk/src/chrome/test/data/sync_xmlhttprequest_during_unload.html
   A /trunk/src/chrome/test/data/title1.html
   A /trunk/src/chrome/test/data/title2.html
   A /trunk/src/chrome/test/data/viewsource
   A /trunk/src/chrome/test/data/viewsource/test.html
   A /trunk/src/chrome/test/data/window.close.html
   A /trunk/src/chrome/test/debugger
   A /trunk/src/chrome/test/debugger/debugger_unittests.py
   A /trunk/src/chrome/test/debugger/debugger_unittests.sh
   A /trunk/src/chrome/test/debugger/test_protocol.js
   A /trunk/src/chrome/test/injection_test_dll.h
   A /trunk/src/chrome/test/interactive_ui
   A /trunk/src/chrome/test/interactive_ui/SConscript
   A /trunk/src/chrome/test/interactive_ui/interactive_ui.vcproj
   A /trunk/src/chrome/test/mini_installer_test
   A /trunk/src/chrome/test/mini_installer_test/SConscript
   A /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.cc
   A /trunk/src/chrome/test/mini_installer_test/chrome_mini_installer.h
   A /trunk/src/chrome/test/mini_installer_test/mini_installer_test.vcproj
   A /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.cc
   A /trunk/src/chrome/test/mini_installer_test/mini_installer_test_constants.h
   A /trunk/src/chrome/test/mini_installer_test/test.cc
   A /trunk/src/chrome/test/page_cycler
   A /trunk/src/chrome/test/page_cycler/SConscript
   A /trunk/src/chrome/test/page_cycler/page_cycler_test.cc
   A /trunk/src/chrome/test/page_cycler/page_cycler_tests.vcproj
   A /trunk/src/chrome/test/perf
   A /trunk/src/chrome/test/perf/mem_usage.cc
   A /trunk/src/chrome/test/perf/mem_usage.h
   A /trunk/src/chrome/test/perf/perftests.cc
   A /trunk/src/chrome/test/perf/perftests.vcproj
   A /trunk/src/chrome/test/perf/url_parse_perftest.cc
   A /trunk/src/chrome/test/plugin
   A /trunk/src/chrome/test/plugin/SConscript
   A /trunk/src/chrome/test/plugin/plugin_test.cpp
   A /trunk/src/chrome/test/plugin/plugin_tests.vcproj
   A /trunk/src/chrome/test/reliability
   A /trunk/src/chrome/test/reliability/SConscript
   A /trunk/src/chrome/test/reliability/page_load_test.cc
   A /trunk/src/chrome/test/reliability/page_load_test.h
   A /trunk/src/chrome/test/reliability/reliability_test_suite.h
   A /trunk/src/chrome/test/reliability/reliability_tests.vcproj
   A /trunk/src/chrome/test/reliability/run_all_unittests.cc
   A /trunk/src/chrome/test/security_tests
   A /trunk/src/chrome/test/security_tests/SConscript
   A /trunk/src/chrome/test/security_tests/ipc_security_tests.cc
   A /trunk/src/chrome/test/security_tests/ipc_security_tests.h
   A /trunk/src/chrome/test/security_tests/security_tests.cc
   A /trunk/src/chrome/test/security_tests/security_tests.vcproj
   A /trunk/src/chrome/test/selenium
   A /trunk/src/chrome/test/selenium/README
   A /trunk/src/chrome/test/selenium/SConscript
   A /trunk/src/chrome/test/selenium/expected_failures.txt
   A /trunk/src/chrome/test/selenium/selenium_test.cc
   A /trunk/src/chrome/test/selenium/selenium_tests.vcproj
   A /trunk/src/chrome/test/startup
   A /trunk/src/chrome/test/startup/SConscript
   A /trunk/src/chrome/test/startup/feature_startup_test.cc
   A /trunk/src/chrome/test/startup/startup_test.cc
   A /trunk/src/chrome/test/startup/startup_tests.vcproj
   A /trunk/src/chrome/test/tab_switching
   A /trunk/src/chrome/test/tab_switching/SConscript
   A /trunk/src/chrome/test/tab_switching/tab_switching.vcproj
   A /trunk/src/chrome/test/tab_switching/tab_switching_test.cc
   A /trunk/src/chrome/test/test_file_util.cc
   A /trunk/src/chrome/test/test_file_util.h
   A /trunk/src/chrome/test/testing_browser_process.h
   A /trunk/src/chrome/test/testing_profile.cc
   A /trunk/src/chrome/test/testing_profile.h
   A /trunk/src/chrome/test/ui
   A /trunk/src/chrome/test/ui/inspector_controller_uitest.cc
   A /trunk/src/chrome/test/ui/layout_plugin_uitest.cpp
   A /trunk/src/chrome/test/ui/npapi_uitest.cpp
   A /trunk/src/chrome/test/ui/omnibox_uitest.cc
   A /trunk/src/chrome/test/ui/run_all_unittests.cc
   A /trunk/src/chrome/test/ui/sandbox_uitests.cc
   A /trunk/src/chrome/test/ui/ui_test.cc
   A /trunk/src/chrome/test/ui/ui_test.h
   A /trunk/src/chrome/test/ui/ui_test_suite.cc
   A /trunk/src/chrome/test/ui/ui_test_suite.h
   A /trunk/src/chrome/test/ui/ui_tests.vcproj
   A /trunk/src/chrome/test/unit
   A /trunk/src/chrome/test/unit/chrome_test_suite.h
   A /trunk/src/chrome/test/unit/run_all_unittests.cc
   A /trunk/src/chrome/test/unit/unittests.vcproj
   A /trunk/src/chrome/test/unit/win
   A /trunk/src/chrome/test/unit/win/rundebug.bat
   A /trunk/src/chrome/third_party
   A /trunk/src/chrome/third_party/hunspell
   A /trunk/src/chrome/third_party/hunspell/COPYING
   A /trunk/src/chrome/third_party/hunspell/COPYING.LGPL
   A /trunk/src/chrome/third_party/hunspell/COPYING.MPL
   A /trunk/src/chrome/third_party/hunspell/README
   A /trunk/src/chrome/third_party/hunspell/README.google
   A /trunk/src/chrome/third_party/hunspell/README.myspell
   A /trunk/src/chrome/third_party/hunspell/SConscript
   A /trunk/src/chrome/third_party/hunspell/copy_dictionary_files.rules
   A /trunk/src/chrome/third_party/hunspell/dictionaries
   A /trunk/src/chrome/third_party/hunspell/dictionaries/en-US.aff
   A /trunk/src/chrome/third_party/hunspell/dictionaries/en-US.bdic
   A /trunk/src/chrome/third_party/hunspell/dictionaries/en-US.dic
   A /trunk/src/chrome/third_party/hunspell/google
   A /trunk/src/chrome/third_party/hunspell/google/bdict.h
   A /trunk/src/chrome/third_party/hunspell/google/bdict_reader.cc
   A /trunk/src/chrome/third_party/hunspell/google/bdict_reader.h
   A /trunk/src/chrome/third_party/hunspell/google/bdict_writer.cc
   A /trunk/src/chrome/third_party/hunspell/google/bdict_writer.h
   A /trunk/src/chrome/third_party/hunspell/google/hunspell_tests.cc
   A /trunk/src/chrome/third_party/hunspell/google.patch
   A /trunk/src/chrome/third_party/hunspell/hunspell.vcproj
   A /trunk/src/chrome/third_party/hunspell/hunspell.vsprops
   A /trunk/src/chrome/third_party/hunspell/src
   A /trunk/src/chrome/third_party/hunspell/src/hunspell
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/README
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/affentry.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/affentry.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/affixmgr.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/affixmgr.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/atypes.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/baseaffix.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/csutil.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/csutil.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/dictmgr.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/dictmgr.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hashmgr.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/htypes.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.dsp
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.h
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/hunspell.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/langnum.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/license.hunspell
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/license.myspell
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/suggestmgr.cxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/suggestmgr.hxx
   A /trunk/src/chrome/third_party/hunspell/src/hunspell/utf_info.hxx
   A /trunk/src/chrome/third_party/hunspell/src/parsers
   A /trunk/src/chrome/third_party/hunspell/src/parsers/textparser.cxx
   A /trunk/src/chrome/third_party/hunspell/src/parsers/textparser.hxx
   A /trunk/src/chrome/third_party/hunspell/tests
   A /trunk/src/chrome/third_party/hunspell/tests/1592880.aff
   A /trunk/src/chrome/third_party/hunspell/tests/1592880.dic
   A /trunk/src/chrome/third_party/hunspell/tests/1592880.good
   A /trunk/src/chrome/third_party/hunspell/tests/1592880.test
   A /trunk/src/chrome/third_party/hunspell/tests/Makefile.am
   A /trunk/src/chrome/third_party/hunspell/tests/Makefile.in
   A /trunk/src/chrome/third_party/hunspell/tests/affixes.aff
   A /trunk/src/chrome/third_party/hunspell/tests/affixes.dic
   A /trunk/src/chrome/third_party/hunspell/tests/affixes.good
   A /trunk/src/chrome/third_party/hunspell/tests/affixes.test
   A /trunk/src/chrome/third_party/hunspell/tests/alias.aff
   A /trunk/src/chrome/third_party/hunspell/tests/alias.dic
   A /trunk/src/chrome/third_party/hunspell/tests/alias.good
   A /trunk/src/chrome/third_party/hunspell/tests/alias.test
   A /trunk/src/chrome/third_party/hunspell/tests/alias2.aff
   A /trunk/src/chrome/third_party/hunspell/tests/alias2.dic
   A /trunk/src/chrome/third_party/hunspell/tests/alias2.good
   A /trunk/src/chrome/third_party/hunspell/tests/alias2.morph
   A /trunk/src/chrome/third_party/hunspell/tests/alias2.test
   A /trunk/src/chrome/third_party/hunspell/tests/alias3.aff
   A /trunk/src/chrome/third_party/hunspell/tests/alias3.dic
   A /trunk/src/chrome/third_party/hunspell/tests/alias3.good
   A /trunk/src/chrome/third_party/hunspell/tests/alias3.morph
   A /trunk/src/chrome/third_party/hunspell/tests/alias3.test
   A /trunk/src/chrome/third_party/hunspell/tests/base.aff
   A /trunk/src/chrome/third_party/hunspell/tests/base.dic
   A /trunk/src/chrome/third_party/hunspell/tests/base.good
   A /trunk/src/chrome/third_party/hunspell/tests/base.sug
   A /trunk/src/chrome/third_party/hunspell/tests/base.test
   A /trunk/src/chrome/third_party/hunspell/tests/base.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/break.aff
   A /trunk/src/chrome/third_party/hunspell/tests/break.dic
   A /trunk/src/chrome/third_party/hunspell/tests/break.good
   A /trunk/src/chrome/third_party/hunspell/tests/break.test
   A /trunk/src/chrome/third_party/hunspell/tests/break.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase.good
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase.test
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase2.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase2.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase2.good
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase2.test
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcase2.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcaseutf.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcaseutf.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcaseutf.good
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcaseutf.test
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundcaseutf.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompounddup.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompounddup.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompounddup.good
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompounddup.test
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompounddup.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundpattern.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundpattern.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundpattern.good
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundpattern.test
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundpattern.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundrep.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundrep.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundrep.good
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundrep.test
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundrep.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundtriple.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundtriple.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundtriple.good
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundtriple.test
   A /trunk/src/chrome/third_party/hunspell/tests/checkcompoundtriple.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checksharps.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checksharps.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checksharps.good
   A /trunk/src/chrome/third_party/hunspell/tests/checksharps.sug
   A /trunk/src/chrome/third_party/hunspell/tests/checksharps.test
   A /trunk/src/chrome/third_party/hunspell/tests/checksharps.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/checksharpsutf.aff
   A /trunk/src/chrome/third_party/hunspell/tests/checksharpsutf.dic
   A /trunk/src/chrome/third_party/hunspell/tests/checksharpsutf.good
   A /trunk/src/chrome/third_party/hunspell/tests/checksharpsutf.sug
   A /trunk/src/chrome/third_party/hunspell/tests/checksharpsutf.test
   A /trunk/src/chrome/third_party/hunspell/tests/checksharpsutf.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/circumfix.aff
   A /trunk/src/chrome/third_party/hunspell/tests/circumfix.dic
   A /trunk/src/chrome/third_party/hunspell/tests/circumfix.good
   A /trunk/src/chrome/third_party/hunspell/tests/circumfix.morph
   A /trunk/src/chrome/third_party/hunspell/tests/circumfix.test
   A /trunk/src/chrome/third_party/hunspell/tests/circumfix.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes.aff
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes.dic
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes.good
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes.test
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes2.aff
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes2.dic
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes2.good
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixes2.test
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixesutf.aff
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixesutf.dic
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixesutf.good
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixesutf.test
   A /trunk/src/chrome/third_party/hunspell/tests/complexprefixesutf.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix2.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix2.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix2.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix2.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix3.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix3.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix3.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix3.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundaffix3.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundflag.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundflag.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundflag.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundflag.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundflag.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule2.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule2.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule2.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule2.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule2.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule3.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule3.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule3.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule3.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule3.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule4.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule4.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule4.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule4.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule4.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule5.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule5.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule5.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule5.morph
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule5.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule5.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule6.aff
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule6.dic
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule6.good
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule6.test
   A /trunk/src/chrome/third_party/hunspell/tests/compoundrule6.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/conditionalprefix.aff
   A /trunk/src/chrome/third_party/hunspell/tests/conditionalprefix.dic
   A /trunk/src/chrome/third_party/hunspell/tests/conditionalprefix.good
   A /trunk/src/chrome/third_party/hunspell/tests/conditionalprefix.morph
   A /trunk/src/chrome/third_party/hunspell/tests/conditionalprefix.test
   A /trunk/src/chrome/third_party/hunspell/tests/conditionalprefix.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/flag.aff
   A /trunk/src/chrome/third_party/hunspell/tests/flag.dic
   A /trunk/src/chrome/third_party/hunspell/tests/flag.good
   A /trunk/src/chrome/third_party/hunspell/tests/flag.test
   A /trunk/src/chrome/third_party/hunspell/tests/flaglong.aff
   A /trunk/src/chrome/third_party/hunspell/tests/flaglong.dic
   A /trunk/src/chrome/third_party/hunspell/tests/flaglong.good
   A /trunk/src/chrome/third_party/hunspell/tests/flaglong.test
   A /trunk/src/chrome/third_party/hunspell/tests/flagnum.aff
   A /trunk/src/chrome/third_party/hunspell/tests/flagnum.dic
   A /trunk/src/chrome/third_party/hunspell/tests/flagnum.good
   A /trunk/src/chrome/third_party/hunspell/tests/flagnum.test
   A /trunk/src/chrome/third_party/hunspell/tests/flagutf8.aff
   A /trunk/src/chrome/third_party/hunspell/tests/flagutf8.dic
   A /trunk/src/chrome/third_party/hunspell/tests/flagutf8.good
   A /trunk/src/chrome/third_party/hunspell/tests/flagutf8.test
   A /trunk/src/chrome/third_party/hunspell/tests/fogemorpheme.aff
   A /trunk/src/chrome/third_party/hunspell/tests/fogemorpheme.dic
   A /trunk/src/chrome/third_party/hunspell/tests/fogemorpheme.good
   A /trunk/src/chrome/third_party/hunspell/tests/fogemorpheme.test
   A /trunk/src/chrome/third_party/hunspell/tests/fogemorpheme.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/forbiddenword.aff
   A /trunk/src/chrome/third_party/hunspell/tests/forbiddenword.dic
   A /trunk/src/chrome/third_party/hunspell/tests/forbiddenword.good
   A /trunk/src/chrome/third_party/hunspell/tests/forbiddenword.test
   A /trunk/src/chrome/third_party/hunspell/tests/forbiddenword.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/germancompounding.aff
   A /trunk/src/chrome/third_party/hunspell/tests/germancompounding.dic
   A /trunk/src/chrome/third_party/hunspell/tests/germancompounding.good
   A /trunk/src/chrome/third_party/hunspell/tests/germancompounding.test
   A /trunk/src/chrome/third_party/hunspell/tests/germancompounding.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/germancompoundingold.aff
   A /trunk/src/chrome/third_party/hunspell/tests/germancompoundingold.dic
   A /trunk/src/chrome/third_party/hunspell/tests/germancompoundingold.good
   A /trunk/src/chrome/third_party/hunspell/tests/germancompoundingold.test
   A /trunk/src/chrome/third_party/hunspell/tests/germancompoundingold.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/i35725.aff
   A /trunk/src/chrome/third_party/hunspell/tests/i35725.dic
   A /trunk/src/chrome/third_party/hunspell/tests/i35725.good
   A /trunk/src/chrome/third_party/hunspell/tests/i35725.sug
   A /trunk/src/chrome/third_party/hunspell/tests/i35725.test
   A /trunk/src/chrome/third_party/hunspell/tests/i35725.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/i53643.aff
   A /trunk/src/chrome/third_party/hunspell/tests/i53643.dic
   A /trunk/src/chrome/third_party/hunspell/tests/i53643.good
   A /trunk/src/chrome/third_party/hunspell/tests/i53643.test
   A /trunk/src/chrome/third_party/hunspell/tests/i53643.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/i54633.aff
   A /trunk/src/chrome/third_party/hunspell/tests/i54633.dic
   A /trunk/src/chrome/third_party/hunspell/tests/i54633.good
   A /trunk/src/chrome/third_party/hunspell/tests/i54633.sug
   A /trunk/src/chrome/third_party/hunspell/tests/i54633.test
   A /trunk/src/chrome/third_party/hunspell/tests/i54633.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/i54980.aff
   A /trunk/src/chrome/third_party/hunspell/tests/i54980.dic
   A /trunk/src/chrome/third_party/hunspell/tests/i54980.good
   A /trunk/src/chrome/third_party/hunspell/tests/i54980.test
   A /trunk/src/chrome/third_party/hunspell/tests/i58202.aff
   A /trunk/src/chrome/third_party/hunspell/tests/i58202.dic
   A /trunk/src/chrome/third_party/hunspell/tests/i58202.good
   A /trunk/src/chrome/third_party/hunspell/tests/i58202.sug
   A /trunk/src/chrome/third_party/hunspell/tests/i58202.test
   A /trunk/src/chrome/third_party/hunspell/tests/i58202.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/ignore.aff
   A /trunk/src/chrome/third_party/hunspell/tests/ignore.dic
   A /trunk/src/chrome/third_party/hunspell/tests/ignore.good
   A /trunk/src/chrome/third_party/hunspell/tests/ignore.test
   A /trunk/src/chrome/third_party/hunspell/tests/ignoreutf.aff
   A /trunk/src/chrome/third_party/hunspell/tests/ignoreutf.dic
   A /trunk/src/chrome/third_party/hunspell/tests/ignoreutf.good
   A /trunk/src/chrome/third_party/hunspell/tests/ignoreutf.test
   A /trunk/src/chrome/third_party/hunspell/tests/keepcase.aff
   A /trunk/src/chrome/third_party/hunspell/tests/keepcase.dic
   A /trunk/src/chrome/third_party/hunspell/tests/keepcase.good
   A /trunk/src/chrome/third_party/hunspell/tests/keepcase.sug
   A /trunk/src/chrome/third_party/hunspell/tests/keepcase.test
   A /trunk/src/chrome/third_party/hunspell/tests/keepcase.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/map.aff
   A /trunk/src/chrome/third_party/hunspell/tests/map.dic
   A /trunk/src/chrome/third_party/hunspell/tests/map.sug
   A /trunk/src/chrome/third_party/hunspell/tests/map.test
   A /trunk/src/chrome/third_party/hunspell/tests/map.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/maputf.aff
   A /trunk/src/chrome/third_party/hunspell/tests/maputf.dic
   A /trunk/src/chrome/third_party/hunspell/tests/maputf.sug
   A /trunk/src/chrome/third_party/hunspell/tests/maputf.test
   A /trunk/src/chrome/third_party/hunspell/tests/maputf.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix.aff
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix.dic
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix.good
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix.test
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix2.aff
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix2.dic
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix2.good
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix2.morph
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix2.test
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix3.aff
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix3.dic
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix3.good
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix3.test
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix3.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix4.aff
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix4.dic
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix4.good
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix4.test
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix5.aff
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix5.dic
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix5.good
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix5.test
   A /trunk/src/chrome/third_party/hunspell/tests/needaffix5.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/nosuggest.aff
   A /trunk/src/chrome/third_party/hunspell/tests/nosuggest.dic
   A /trunk/src/chrome/third_party/hunspell/tests/nosuggest.good
   A /trunk/src/chrome/third_party/hunspell/tests/nosuggest.sug
   A /trunk/src/chrome/third_party/hunspell/tests/nosuggest.test
   A /trunk/src/chrome/third_party/hunspell/tests/nosuggest.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/onlyincompound.aff
   A /trunk/src/chrome/third_party/hunspell/tests/onlyincompound.dic
   A /trunk/src/chrome/third_party/hunspell/tests/onlyincompound.good
   A /trunk/src/chrome/third_party/hunspell/tests/onlyincompound.sug
   A /trunk/src/chrome/third_party/hunspell/tests/onlyincompound.test
   A /trunk/src/chrome/third_party/hunspell/tests/onlyincompound.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/rep.aff
   A /trunk/src/chrome/third_party/hunspell/tests/rep.dic
   A /trunk/src/chrome/third_party/hunspell/tests/rep.sug
   A /trunk/src/chrome/third_party/hunspell/tests/rep.test
   A /trunk/src/chrome/third_party/hunspell/tests/rep.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/reputf.aff
   A /trunk/src/chrome/third_party/hunspell/tests/reputf.dic
   A /trunk/src/chrome/third_party/hunspell/tests/reputf.sug
   A /trunk/src/chrome/third_party/hunspell/tests/reputf.test
   A /trunk/src/chrome/third_party/hunspell/tests/reputf.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/slash.aff
   A /trunk/src/chrome/third_party/hunspell/tests/slash.dic
   A /trunk/src/chrome/third_party/hunspell/tests/slash.good
   A /trunk/src/chrome/third_party/hunspell/tests/slash.test
   A /trunk/src/chrome/third_party/hunspell/tests/sug.aff
   A /trunk/src/chrome/third_party/hunspell/tests/sug.dic
   A /trunk/src/chrome/third_party/hunspell/tests/sug.sug
   A /trunk/src/chrome/third_party/hunspell/tests/sug.test
   A /trunk/src/chrome/third_party/hunspell/tests/sug.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/test.sh
   A /trunk/src/chrome/third_party/hunspell/tests/utf8.aff
   A /trunk/src/chrome/third_party/hunspell/tests/utf8.dic
   A /trunk/src/chrome/third_party/hunspell/tests/utf8.good
   A /trunk/src/chrome/third_party/hunspell/tests/utf8.test
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom.aff
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom.dic
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom.good
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom.test
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom2.aff
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom2.dic
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom2.good
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_bom2.test
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_nonbmp.aff
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_nonbmp.dic
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_nonbmp.good
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_nonbmp.test
   A /trunk/src/chrome/third_party/hunspell/tests/utf8_nonbmp.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/utfcompound.aff
   A /trunk/src/chrome/third_party/hunspell/tests/utfcompound.dic
   A /trunk/src/chrome/third_party/hunspell/tests/utfcompound.good
   A /trunk/src/chrome/third_party/hunspell/tests/utfcompound.test
   A /trunk/src/chrome/third_party/hunspell/tests/utfcompound.wrong
   A /trunk/src/chrome/third_party/hunspell/tests/zeroaffix.aff
   A /trunk/src/chrome/third_party/hunspell/tests/zeroaffix.dic
   A /trunk/src/chrome/third_party/hunspell/tests/zeroaffix.good
   A /trunk/src/chrome/third_party/hunspell/tests/zeroaffix.morph
   A /trunk/src/chrome/third_party/hunspell/tests/zeroaffix.test
   A /trunk/src/chrome/third_party/hunspell/using_hunspell.vsprops
   A /trunk/src/chrome/third_party/jstemplate
   A /trunk/src/chrome/third_party/jstemplate/README.txt
   A /trunk/src/chrome/third_party/jstemplate/base.js
   A /trunk/src/chrome/third_party/jstemplate/compile.sh
   A /trunk/src/chrome/third_party/jstemplate/dom.js
   A /trunk/src/chrome/third_party/jstemplate/jstemplate.js
   A /trunk/src/chrome/third_party/jstemplate/jstemplate_compiled.js
   A /trunk/src/chrome/third_party/jstemplate/test
   A /trunk/src/chrome/third_party/jstemplate/test/jstemplate.html
   A /trunk/src/chrome/third_party/jstemplate/test/jstemplate_script.js
   A /trunk/src/chrome/third_party/jstemplate/util.js
   A /trunk/src/chrome/third_party/sqlite
   A /trunk/src/chrome/third_party/sqlite/README.google
   A /trunk/src/chrome/third_party/sqlite/SConscript
   A /trunk/src/chrome/third_party/sqlite/alter.c
   A /trunk/src/chrome/third_party/sqlite/analyze.c
   A /trunk/src/chrome/third_party/sqlite/attach.c
   A /trunk/src/chrome/third_party/sqlite/auth.c
   A /trunk/src/chrome/third_party/sqlite/btree.c
   A /trunk/src/chrome/third_party/sqlite/btree.h
   A /trunk/src/chrome/third_party/sqlite/btreeInt.h
   A /trunk/src/chrome/third_party/sqlite/build.c
   A /trunk/src/chrome/third_party/sqlite/callback.c
   A /trunk/src/chrome/third_party/sqlite/complete.c
   A /trunk/src/chrome/third_party/sqlite/date.c
   A /trunk/src/chrome/third_party/sqlite/delete.c
   A /trunk/src/chrome/third_party/sqlite/expr.c
   A /trunk/src/chrome/third_party/sqlite/fts2.c
   A /trunk/src/chrome/third_party/sqlite/fts2.h
   A /trunk/src/chrome/third_party/sqlite/fts2_hash.c
   A /trunk/src/chrome/third_party/sqlite/fts2_hash.h
   A /trunk/src/chrome/third_party/sqlite/fts2_icu.c
   A /trunk/src/chrome/third_party/sqlite/fts2_porter.c
   A /trunk/src/chrome/third_party/sqlite/fts2_tokenizer.c
   A /trunk/src/chrome/third_party/sqlite/fts2_tokenizer.h
   A /trunk/src/chrome/third_party/sqlite/fts2_tokenizer1.c
   A /trunk/src/chrome/third_party/sqlite/func.c
   A /trunk/src/chrome/third_party/sqlite/hash.c
   A /trunk/src/chrome/third_party/sqlite/hash.h
   A /trunk/src/chrome/third_party/sqlite/icu.c
   A /trunk/src/chrome/third_party/sqlite/insert.c
   A /trunk/src/chrome/third_party/sqlite/keywordhash.h
   A /trunk/src/chrome/third_party/sqlite/legacy.c
   A /trunk/src/chrome/third_party/sqlite/limits.h
   A /trunk/src/chrome/third_party/sqlite/loadext.c
   A /trunk/src/chrome/third_party/sqlite/main.c
   A /trunk/src/chrome/third_party/sqlite/malloc.c
   A /trunk/src/chrome/third_party/sqlite/opcodes.c
   A /trunk/src/chrome/third_party/sqlite/opcodes.h
   A /trunk/src/chrome/third_party/sqlite/os.c
   A /trunk/src/chrome/third_party/sqlite/os.h
   A /trunk/src/chrome/third_party/sqlite/os_common.h
   A /trunk/src/chrome/third_party/sqlite/os_win.c
   A /trunk/src/chrome/third_party/sqlite/pager.c
   A /trunk/src/chrome/third_party/sqlite/pager.h
   A /trunk/src/chrome/third_party/sqlite/parse.c
   A /trunk/src/chrome/third_party/sqlite/parse.h
   A /trunk/src/chrome/third_party/sqlite/pragma.c
   A /trunk/src/chrome/third_party/sqlite/preload-cache.patch
   A /trunk/src/chrome/third_party/sqlite/prepare.c
   A /trunk/src/chrome/third_party/sqlite/printf.c
   A /trunk/src/chrome/third_party/sqlite/random.c
   A /trunk/src/chrome/third_party/sqlite/select.c
   A /trunk/src/chrome/third_party/sqlite/shell.c
   A /trunk/src/chrome/third_party/sqlite/shell_icu.c
   A /trunk/src/chrome/third_party/sqlite/sqlite.vcproj
   A /trunk/src/chrome/third_party/sqlite/sqlite.vsprops
   A /trunk/src/chrome/third_party/sqlite/sqlite3.h
   A /trunk/src/chrome/third_party/sqlite/sqlite3ext.h
   A /trunk/src/chrome/third_party/sqlite/sqliteInt.h
   A /trunk/src/chrome/third_party/sqlite/sqliteLimit.h
   A /trunk/src/chrome/third_party/sqlite/table.c
   A /trunk/src/chrome/third_party/sqlite/tokenize.c
   A /trunk/src/chrome/third_party/sqlite/trigger.c
   A /trunk/src/chrome/third_party/sqlite/update.c
   A /trunk/src/chrome/third_party/sqlite/utf.c
   A /trunk/src/chrome/third_party/sqlite/util.c
   A /trunk/src/chrome/third_party/sqlite/vacuum.c
   A /trunk/src/chrome/third_party/sqlite/vdbe.c
   A /trunk/src/chrome/third_party/sqlite/vdbe.h
   A /trunk/src/chrome/third_party/sqlite/vdbeInt.h
   A /trunk/src/chrome/third_party/sqlite/vdbeapi.c
   A /trunk/src/chrome/third_party/sqlite/vdbeaux.c
   A /trunk/src/chrome/third_party/sqlite/vdbefifo.c
   A /trunk/src/chrome/third_party/sqlite/vdbemem.c
   A /trunk/src/chrome/third_party/sqlite/vtab.c
   A /trunk/src/chrome/third_party/sqlite/where.c
   A /trunk/src/chrome/third_party/wtl
   A /trunk/src/chrome/third_party/wtl/Ms-PL.txt
   A /trunk/src/chrome/third_party/wtl/README.google
   A /trunk/src/chrome/third_party/wtl/include
   A /trunk/src/chrome/third_party/wtl/include/atlapp.h
   A /trunk/src/chrome/third_party/wtl/include/atlcrack.h
   A /trunk/src/chrome/third_party/wtl/include/atlctrls.h
   A /trunk/src/chrome/third_party/wtl/include/atlctrlw.h
   A /trunk/src/chrome/third_party/wtl/include/atlctrlx.h
   A /trunk/src/chrome/third_party/wtl/include/atlddx.h
   A /trunk/src/chrome/third_party/wtl/include/atldlgs.h
   A /trunk/src/chrome/third_party/wtl/include/atlfind.h
   A /trunk/src/chrome/third_party/wtl/include/atlframe.h
   A /trunk/src/chrome/third_party/wtl/include/atlgdi.h
   A /trunk/src/chrome/third_party/wtl/include/atlmisc.h
   A /trunk/src/chrome/third_party/wtl/include/atlprint.h
   A /trunk/src/chrome/third_party/wtl/include/atlres.h
   A /trunk/src/chrome/third_party/wtl/include/atlresce.h
   A /trunk/src/chrome/third_party/wtl/include/atlscrl.h
   A /trunk/src/chrome/third_party/wtl/include/atlsplit.h
   A /trunk/src/chrome/third_party/wtl/include/atltheme.h
   A /trunk/src/chrome/third_party/wtl/include/atluser.h
   A /trunk/src/chrome/third_party/wtl/include/atlwince.h
   A /trunk/src/chrome/third_party/wtl/include/atlwinx.h
   A /trunk/src/chrome/third_party/wtl/readme.htm
   A /trunk/src/chrome/third_party/wtl/using_wtl.vsprops
   A /trunk/src/chrome/tools
   A /trunk/src/chrome/tools/README.google
   A /trunk/src/chrome/tools/automated_ui_test_tools
   A /trunk/src/chrome/tools/automated_ui_test_tools/README.txt
   A /trunk/src/chrome/tools/automated_ui_test_tools/auto_ui_test_input_generator.py
   A /trunk/src/chrome/tools/automated_ui_test_tools/possible_actions.txt
   A /trunk/src/chrome/tools/build
   A /trunk/src/chrome/tools/build/win
   A /trunk/src/chrome/tools/build/win/FILES
   A /trunk/src/chrome/tools/build/win/create_installer_archive.py
   A /trunk/src/chrome/tools/build/win/data_dll.vsprops
   A /trunk/src/chrome/tools/build/win/debugger_disabled.vsprops
   A /trunk/src/chrome/tools/build/win/dependencies.py
   A /trunk/src/chrome/tools/build/win/flattened_html_file.bat
   A /trunk/src/chrome/tools/build/win/flattened_html_file.rules
   A /trunk/src/chrome/tools/build/win/font_file_copy.rules
   A /trunk/src/chrome/tools/build/win/hardlink_failsafe.bat
   A /trunk/src/chrome/tools/build/win/html_inline.py
   A /trunk/src/chrome/tools/build/win/inspector_copy.rules
   A /trunk/src/chrome/tools/build/win/js_engine.vsprops
   A /trunk/src/chrome/tools/build/win/js_engine_impl.vsprops
   A /trunk/src/chrome/tools/build/win/js_engine_impl_kjs.vsprops
   A /trunk/src/chrome/tools/build/win/language_dll.vsprops
   A /trunk/src/chrome/tools/build/win/make_zip.sh
   A /trunk/src/chrome/tools/build/win/map_drive.bat
   A /trunk/src/chrome/tools/build/win/precompiled.cc
   A /trunk/src/chrome/tools/build/win/precompiled.h
   A /trunk/src/chrome/tools/build/win/precompiled.vsprops
   A /trunk/src/chrome/tools/build/win/precompiled_wtl.cc
   A /trunk/src/chrome/tools/build/win/precompiled_wtl.h
   A /trunk/src/chrome/tools/build/win/precompiled_wtl.vsprops
   A /trunk/src/chrome/tools/build/win/release.rules
   A /trunk/src/chrome/tools/build/win/reliability_test.vsprops
   A /trunk/src/chrome/tools/build/win/resource_text_file_copy.rules
   A /trunk/src/chrome/tools/build/win/sort_sln.py
   A /trunk/src/chrome/tools/build/win/test_memory_usage.vsprops
   A /trunk/src/chrome/tools/build/win/test_shell_tests.vsprops
   A /trunk/src/chrome/tools/build/win/ui_test.vsprops
   A /trunk/src/chrome/tools/build/win/unit_test.vsprops
   A /trunk/src/chrome/tools/build/win/using_generated_strings.vsprops
   A /trunk/src/chrome/tools/build/win/using_javascriptcore.vsprops
   A /trunk/src/chrome/tools/build/win/version.bat
   A /trunk/src/chrome/tools/build/win/version.rules
   A /trunk/src/chrome/tools/convert_dict
   A /trunk/src/chrome/tools/convert_dict/aff_reader.cc
   A /trunk/src/chrome/tools/convert_dict/aff_reader.h
   A /trunk/src/chrome/tools/convert_dict/convert_dict.cc
   A /trunk/src/chrome/tools/convert_dict/convert_dict.vcproj
   A /trunk/src/chrome/tools/convert_dict/dic_reader.cc
   A /trunk/src/chrome/tools/convert_dict/dic_reader.h
   A /trunk/src/chrome/tools/convert_dict/hunspell_reader.cc
   A /trunk/src/chrome/tools/convert_dict/hunspell_reader.h
   A /trunk/src/chrome/tools/crash_service
   A /trunk/src/chrome/tools/crash_service/SConscript
   A /trunk/src/chrome/tools/crash_service/crash_service.cc
   A /trunk/src/chrome/tools/crash_service/crash_service.exe.manifest
   A /trunk/src/chrome/tools/crash_service/crash_service.h
   A /trunk/src/chrome/tools/crash_service/crash_service.vcproj
   A /trunk/src/chrome/tools/crash_service/main.cc
   A /trunk/src/chrome/tools/extract_actions.py
   A /trunk/src/chrome/tools/extract_actions.sh
   A /trunk/src/chrome/tools/extract_histograms.py
   A /trunk/src/chrome/tools/history-viz.py
   A /trunk/src/chrome/tools/icudt38.dll
   A /trunk/src/chrome/tools/inconsistent-eol.py
   A /trunk/src/chrome/tools/optipng.exe
   A /trunk/src/chrome/tools/profiles
   A /trunk/src/chrome/tools/profiles/generate_profile.cc
   A /trunk/src/chrome/tools/profiles/generate_profile.vcproj
   A /trunk/src/chrome/tools/profiles/thumbnail-inl.h
   A /trunk/src/chrome/tools/sqlite.exe
   A /trunk/src/chrome/tools/sqlite3_analyzer.exe
   A /trunk/src/chrome/tools/test
   A /trunk/src/chrome/tools/test/generate_mime_tests.pl
   A /trunk/src/chrome/tools/test/image_diff
   A /trunk/src/chrome/tools/test/image_diff/SConscript
   A /trunk/src/chrome/tools/test/image_diff/image_diff.cc
   A /trunk/src/chrome/tools/test/image_diff/image_diff.vcproj
   A /trunk/src/chrome/tools/test/smoketests.py
   A /trunk/src/chrome/views
   A /trunk/src/chrome/views/SConscript
   A /trunk/src/chrome/views/accelerator.cc
   A /trunk/src/chrome/views/accelerator.h
   A /trunk/src/chrome/views/accelerator_handler.cc
   A /trunk/src/chrome/views/accelerator_handler.h
   A /trunk/src/chrome/views/accessibility
   A /trunk/src/chrome/views/accessibility/accessible_wrapper.cc
   A /trunk/src/chrome/views/accessibility/accessible_wrapper.h
   A /trunk/src/chrome/views/accessibility/autocomplete_accessibility.cc
   A /trunk/src/chrome/views/accessibility/autocomplete_accessibility.h
   A /trunk/src/chrome/views/accessibility/view_accessibility.cc
   A /trunk/src/chrome/views/accessibility/view_accessibility.h
   A /trunk/src/chrome/views/aero_tooltip_manager.cc
   A /trunk/src/chrome/views/aero_tooltip_manager.h
   A /trunk/src/chrome/views/app_modal_dialog_delegate.h
   A /trunk/src/chrome/views/background.cc
   A /trunk/src/chrome/views/background.h
   A /trunk/src/chrome/views/base_button.cc
   A /trunk/src/chrome/views/base_button.h
   A /trunk/src/chrome/views/bitmap_scroll_bar.cc
   A /trunk/src/chrome/views/bitmap_scroll_bar.h
   A /trunk/src/chrome/views/border.cc
   A /trunk/src/chrome/views/border.h
   A /trunk/src/chrome/views/button.cc
   A /trunk/src/chrome/views/button.h
   A /trunk/src/chrome/views/button_dropdown.cc
   A /trunk/src/chrome/views/button_dropdown.h
   A /trunk/src/chrome/views/checkbox.cc
   A /trunk/src/chrome/views/checkbox.h
   A /trunk/src/chrome/views/chrome_menu.cc
   A /trunk/src/chrome/views/chrome_menu.h
   A /trunk/src/chrome/views/client_view.cc
   A /trunk/src/chrome/views/client_view.h
   A /trunk/src/chrome/views/combo_box.cc
   A /trunk/src/chrome/views/combo_box.h
   A /trunk/src/chrome/views/controller.h
   A /trunk/src/chrome/views/custom_frame_window.cc
   A /trunk/src/chrome/views/custom_frame_window.h
   A /trunk/src/chrome/views/decision.cc
   A /trunk/src/chrome/views/decision.h
   A /trunk/src/chrome/views/dialog_delegate.h
   A /trunk/src/chrome/views/event.cc
   A /trunk/src/chrome/views/event.h
   A /trunk/src/chrome/views/external_focus_tracker.cc
   A /trunk/src/chrome/views/external_focus_tracker.h
   A /trunk/src/chrome/views/focus_manager.cc
   A /trunk/src/chrome/views/focus_manager.h
   A /trunk/src/chrome/views/focus_manager_unittest.cc
   A /trunk/src/chrome/views/grid_layout.cc
   A /trunk/src/chrome/views/grid_layout.h
   A /trunk/src/chrome/views/grid_layout_unittest.cc
   A /trunk/src/chrome/views/group_table_view.cc
   A /trunk/src/chrome/views/group_table_view.h
   A /trunk/src/chrome/views/hwnd_notification_source.h
   A /trunk/src/chrome/views/hwnd_view.cc
   A /trunk/src/chrome/views/hwnd_view.h
   A /trunk/src/chrome/views/hwnd_view_container.cc
   A /trunk/src/chrome/views/hwnd_view_container.h
   A /trunk/src/chrome/views/image_view.cc
   A /trunk/src/chrome/views/image_view.h
   A /trunk/src/chrome/views/label.cc
   A /trunk/src/chrome/views/label.h
   A /trunk/src/chrome/views/layout_manager.cc
   A /trunk/src/chrome/views/layout_manager.h
   A /trunk/src/chrome/views/link.cc
   A /trunk/src/chrome/views/link.h
   A /trunk/src/chrome/views/menu.cc
   A /trunk/src/chrome/views/menu.h
   A /trunk/src/chrome/views/menu_button.cc
   A /trunk/src/chrome/views/menu_button.h
   A /trunk/src/chrome/views/message_box_view.cc
   A /trunk/src/chrome/views/message_box_view.h
   A /trunk/src/chrome/views/native_button.cc
   A /trunk/src/chrome/views/native_button.h
   A /trunk/src/chrome/views/native_control.cc
   A /trunk/src/chrome/views/native_control.h
   A /trunk/src/chrome/views/native_scroll_bar.cc
   A /trunk/src/chrome/views/native_scroll_bar.h
   A /trunk/src/chrome/views/painter.cc
   A /trunk/src/chrome/views/painter.h
   A /trunk/src/chrome/views/radio_button.cc
   A /trunk/src/chrome/views/radio_button.h
   A /trunk/src/chrome/views/repeat_controller.cc
   A /trunk/src/chrome/views/repeat_controller.h
   A /trunk/src/chrome/views/resize_corner.cc
   A /trunk/src/chrome/views/resize_corner.h
   A /trunk/src/chrome/views/root_view.cc
   A /trunk/src/chrome/views/root_view.h
   A /trunk/src/chrome/views/root_view_drop_target.cc
   A /trunk/src/chrome/views/root_view_drop_target.h
   A /trunk/src/chrome/views/scroll_bar.cc
   A /trunk/src/chrome/views/scroll_bar.h
   A /trunk/src/chrome/views/scroll_view.cc
   A /trunk/src/chrome/views/scroll_view.h
   A /trunk/src/chrome/views/separator.cc
   A /trunk/src/chrome/views/separator.h
   A /trunk/src/chrome/views/tabbed_pane.cc
   A /trunk/src/chrome/views/tabbed_pane.h
   A /trunk/src/chrome/views/table_view.cc
   A /trunk/src/chrome/views/table_view.h
   A /trunk/src/chrome/views/text_button.cc
   A /trunk/src/chrome/views/text_button.h
   A /trunk/src/chrome/views/text_field.cc
   A /trunk/src/chrome/views/text_field.h
   A /trunk/src/chrome/views/throbber.cc
   A /trunk/src/chrome/views/throbber.h
   A /trunk/src/chrome/views/tooltip_manager.cc
   A /trunk/src/chrome/views/tooltip_manager.h
   A /trunk/src/chrome/views/tree_node_model.h
   A /trunk/src/chrome/views/tree_view.cc
   A /trunk/src/chrome/views/tree_view.h
   A /trunk/src/chrome/views/view.cc
   A /trunk/src/chrome/views/view.h
   A /trunk/src/chrome/views/view_container.h
   A /trunk/src/chrome/views/view_menu_delegate.h
   A /trunk/src/chrome/views/view_storage.cc
   A /trunk/src/chrome/views/view_storage.h
   A /trunk/src/chrome/views/view_unittest.cc
   A /trunk/src/chrome/views/views.vcproj
   A /trunk/src/chrome/views/views.vsprops
   A /trunk/src/chrome/views/window.cc
   A /trunk/src/chrome/views/window.h
   A /trunk/src/chrome/views/window_delegate.h

Add chrome to the repository.

------------------------------------------------------------------------
